type
stringclasses 14
values | public
bool 1
class | payload
stringlengths 2
363k
| repo
dict | actor
dict | org
dict | created_at
timestamp[us] | id
stringlengths 10
10
| other
stringlengths 31
69
|
|---|---|---|---|---|---|---|---|---|
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/spatie/laravel-responsecache/pulls/comments/170526003","pull_request_review_id":99221540,"id":170526003,"diff_hunk":"@@ -90,4 +90,14 @@ protected function addCachedHeader(Response $response): Response\n \n return $clonedResponse;\n }\n+\n+ public function forget(string $uri)\n+ {\n+ $request = Request::create($uri);\n+ $hash = $this->hasher->getHashFor($request);\n+\n+ if ($this->cache->has($hash)) {\n+ $this->cache->forget($hash);\n+ }","path":"src/ResponseCache.php","position":12,"original_position":12,"commit_id":"9b2242fd5950bc35df668a1227bc3fae2fc572bf","original_commit_id":"9b2242fd5950bc35df668a1227bc3fae2fc572bf","user":{"login":"freekmurze","id":483853,"avatar_url":"https://avatars2.githubusercontent.com/u/483853?v=4","gravatar_id":"","url":"https://api.github.com/users/freekmurze","html_url":"https://github.com/freekmurze","followers_url":"https://api.github.com/users/freekmurze/followers","following_url":"https://api.github.com/users/freekmurze/following{/other_user}","gists_url":"https://api.github.com/users/freekmurze/gists{/gist_id}","starred_url":"https://api.github.com/users/freekmurze/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freekmurze/subscriptions","organizations_url":"https://api.github.com/users/freekmurze/orgs","repos_url":"https://api.github.com/users/freekmurze/repos","events_url":"https://api.github.com/users/freekmurze/events{/privacy}","received_events_url":"https://api.github.com/users/freekmurze/received_events","type":"User","site_admin":false},"body":"Let's return `$this` here so the method becomes chainable.","created_at":"2018-02-26T08:57:13Z","updated_at":"2018-02-26T08:59:23Z","html_url":"https://github.com/spatie/laravel-responsecache/pull/120#discussion_r170526003","pull_request_url":"https://api.github.com/repos/spatie/laravel-responsecache/pulls/120","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/spatie/laravel-responsecache/pulls/comments/170526003"},"html":{"href":"https://github.com/spatie/laravel-responsecache/pull/120#discussion_r170526003"},"pull_request":{"href":"https://api.github.com/repos/spatie/laravel-responsecache/pulls/120"}}},"pull_request":{"url":"https://api.github.com/repos/spatie/laravel-responsecache/pulls/120","id":171254590,"html_url":"https://github.com/spatie/laravel-responsecache/pull/120","diff_url":"https://github.com/spatie/laravel-responsecache/pull/120.diff","patch_url":"https://github.com/spatie/laravel-responsecache/pull/120.patch","issue_url":"https://api.github.com/repos/spatie/laravel-responsecache/issues/120","number":120,"state":"open","locked":false,"title":"It can forget a specific cached request","user":{"login":"alexjoffroy","id":7209163,"avatar_url":"https://avatars3.githubusercontent.com/u/7209163?v=4","gravatar_id":"","url":"https://api.github.com/users/alexjoffroy","html_url":"https://github.com/alexjoffroy","followers_url":"https://api.github.com/users/alexjoffroy/followers","following_url":"https://api.github.com/users/alexjoffroy/following{/other_user}","gists_url":"https://api.github.com/users/alexjoffroy/gists{/gist_id}","starred_url":"https://api.github.com/users/alexjoffroy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexjoffroy/subscriptions","organizations_url":"https://api.github.com/users/alexjoffroy/orgs","repos_url":"https://api.github.com/users/alexjoffroy/repos","events_url":"https://api.github.com/users/alexjoffroy/events{/privacy}","received_events_url":"https://api.github.com/users/alexjoffroy/received_events","type":"User","site_admin":false},"body":"This PR allows to forget a specific cached request as discussed in https://github.com/spatie/laravel-responsecache/issues/72 and https://github.com/spatie/laravel-responsecache/issues/3","created_at":"2018-02-25T22:09:29Z","updated_at":"2018-02-26T08:59:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ec251dc24986787044b1dee6ae01113ea09c6747","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/spatie/laravel-responsecache/pulls/120/commits","review_comments_url":"https://api.github.com/repos/spatie/laravel-responsecache/pulls/120/comments","review_comment_url":"https://api.github.com/repos/spatie/laravel-responsecache/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spatie/laravel-responsecache/issues/120/comments","statuses_url":"https://api.github.com/repos/spatie/laravel-responsecache/statuses/9b2242fd5950bc35df668a1227bc3fae2fc572bf","head":{"label":"alexjoffroy:feature/forget-specific-uri","ref":"feature/forget-specific-uri","sha":"9b2242fd5950bc35df668a1227bc3fae2fc572bf","user":{"login":"alexjoffroy","id":7209163,"avatar_url":"https://avatars3.githubusercontent.com/u/7209163?v=4","gravatar_id":"","url":"https://api.github.com/users/alexjoffroy","html_url":"https://github.com/alexjoffroy","followers_url":"https://api.github.com/users/alexjoffroy/followers","following_url":"https://api.github.com/users/alexjoffroy/following{/other_user}","gists_url":"https://api.github.com/users/alexjoffroy/gists{/gist_id}","starred_url":"https://api.github.com/users/alexjoffroy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexjoffroy/subscriptions","organizations_url":"https://api.github.com/users/alexjoffroy/orgs","repos_url":"https://api.github.com/users/alexjoffroy/repos","events_url":"https://api.github.com/users/alexjoffroy/events{/privacy}","received_events_url":"https://api.github.com/users/alexjoffroy/received_events","type":"User","site_admin":false},"repo":{"id":122880872,"name":"laravel-responsecache","full_name":"alexjoffroy/laravel-responsecache","owner":{"login":"alexjoffroy","id":7209163,"avatar_url":"https://avatars3.githubusercontent.com/u/7209163?v=4","gravatar_id":"","url":"https://api.github.com/users/alexjoffroy","html_url":"https://github.com/alexjoffroy","followers_url":"https://api.github.com/users/alexjoffroy/followers","following_url":"https://api.github.com/users/alexjoffroy/following{/other_user}","gists_url":"https://api.github.com/users/alexjoffroy/gists{/gist_id}","starred_url":"https://api.github.com/users/alexjoffroy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexjoffroy/subscriptions","organizations_url":"https://api.github.com/users/alexjoffroy/orgs","repos_url":"https://api.github.com/users/alexjoffroy/repos","events_url":"https://api.github.com/users/alexjoffroy/events{/privacy}","received_events_url":"https://api.github.com/users/alexjoffroy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alexjoffroy/laravel-responsecache","description":"Speed up a Laravel app by caching the entire response","fork":true,"url":"https://api.github.com/repos/alexjoffroy/laravel-responsecache","forks_url":"https://api.github.com/repos/alexjoffroy/laravel-responsecache/forks","keys_url":"https://api.github.com/repos/alexjoffroy/laravel-responsecache/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alexjoffroy/laravel-responsecache/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alexjoffroy/laravel-responsecache/teams","hooks_url":"https://api.github.com/repos/alexjoffroy/laravel-responsecache/hooks","issue_events_url":"https://api.github.com/repos/alexjoffroy/laravel-responsecache/issues/events{/number}","events_url":"https://api.github.com/repos/alexjoffroy/laravel-responsecache/events","assignees_url":"https://api.github.com/repos/alexjoffroy/laravel-responsecache/assignees{/user}","branches_url":"https://api.github.com/repos/alexjoffroy/laravel-responsecache/branches{/branch}","tags_url":"https://api.github.com/repos/alexjoffroy/laravel-responsecache/tags","blobs_url":"https://api.github.com/repos/alexjoffroy/laravel-responsecache/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alexjoffroy/laravel-responsecache/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alexjoffroy/laravel-responsecache/git/refs{/sha}","trees_url":"https://api.github.com/repos/alexjoffroy/laravel-responsecache/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alexjoffroy/laravel-responsecache/statuses/{sha}","languages_url":"https://api.github.com/repos/alexjoffroy/laravel-responsecache/languages","stargazers_url":"https://api.github.com/repos/alexjoffroy/laravel-responsecache/stargazers","contributors_url":"https://api.github.com/repos/alexjoffroy/laravel-responsecache/contributors","subscribers_url":"https://api.github.com/repos/alexjoffroy/laravel-responsecache/subscribers","subscription_url":"https://api.github.com/repos/alexjoffroy/laravel-responsecache/subscription","commits_url":"https://api.github.com/repos/alexjoffroy/laravel-responsecache/commits{/sha}","git_commits_url":"https://api.github.com/repos/alexjoffroy/laravel-responsecache/git/commits{/sha}","comments_url":"https://api.github.com/repos/alexjoffroy/laravel-responsecache/comments{/number}","issue_comment_url":"https://api.github.com/repos/alexjoffroy/laravel-responsecache/issues/comments{/number}","contents_url":"https://api.github.com/repos/alexjoffroy/laravel-responsecache/contents/{+path}","compare_url":"https://api.github.com/repos/alexjoffroy/laravel-responsecache/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alexjoffroy/laravel-responsecache/merges","archive_url":"https://api.github.com/repos/alexjoffroy/laravel-responsecache/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alexjoffroy/laravel-responsecache/downloads","issues_url":"https://api.github.com/repos/alexjoffroy/laravel-responsecache/issues{/number}","pulls_url":"https://api.github.com/repos/alexjoffroy/laravel-responsecache/pulls{/number}","milestones_url":"https://api.github.com/repos/alexjoffroy/laravel-responsecache/milestones{/number}","notifications_url":"https://api.github.com/repos/alexjoffroy/laravel-responsecache/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alexjoffroy/laravel-responsecache/labels{/name}","releases_url":"https://api.github.com/repos/alexjoffroy/laravel-responsecache/releases{/id}","deployments_url":"https://api.github.com/repos/alexjoffroy/laravel-responsecache/deployments","created_at":"2018-02-25T21:51:55Z","updated_at":"2018-02-25T21:51:57Z","pushed_at":"2018-02-25T22:15:10Z","git_url":"git://github.com/alexjoffroy/laravel-responsecache.git","ssh_url":"[email protected]:alexjoffroy/laravel-responsecache.git","clone_url":"https://github.com/alexjoffroy/laravel-responsecache.git","svn_url":"https://github.com/alexjoffroy/laravel-responsecache","homepage":"https://murze.be/2015/07/speed-up-a-laravel-app-by-caching-the-entire-response/","size":135,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"spatie:master","ref":"master","sha":"4ab2fcbf6a833e0e787ae57e1d1c2af7d29f186f","user":{"login":"spatie","id":7535935,"avatar_url":"https://avatars0.githubusercontent.com/u/7535935?v=4","gravatar_id":"","url":"https://api.github.com/users/spatie","html_url":"https://github.com/spatie","followers_url":"https://api.github.com/users/spatie/followers","following_url":"https://api.github.com/users/spatie/following{/other_user}","gists_url":"https://api.github.com/users/spatie/gists{/gist_id}","starred_url":"https://api.github.com/users/spatie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spatie/subscriptions","organizations_url":"https://api.github.com/users/spatie/orgs","repos_url":"https://api.github.com/users/spatie/repos","events_url":"https://api.github.com/users/spatie/events{/privacy}","received_events_url":"https://api.github.com/users/spatie/received_events","type":"Organization","site_admin":false},"repo":{"id":39198480,"name":"laravel-responsecache","full_name":"spatie/laravel-responsecache","owner":{"login":"spatie","id":7535935,"avatar_url":"https://avatars0.githubusercontent.com/u/7535935?v=4","gravatar_id":"","url":"https://api.github.com/users/spatie","html_url":"https://github.com/spatie","followers_url":"https://api.github.com/users/spatie/followers","following_url":"https://api.github.com/users/spatie/following{/other_user}","gists_url":"https://api.github.com/users/spatie/gists{/gist_id}","starred_url":"https://api.github.com/users/spatie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spatie/subscriptions","organizations_url":"https://api.github.com/users/spatie/orgs","repos_url":"https://api.github.com/users/spatie/repos","events_url":"https://api.github.com/users/spatie/events{/privacy}","received_events_url":"https://api.github.com/users/spatie/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spatie/laravel-responsecache","description":"Speed up a Laravel app by caching the entire response","fork":false,"url":"https://api.github.com/repos/spatie/laravel-responsecache","forks_url":"https://api.github.com/repos/spatie/laravel-responsecache/forks","keys_url":"https://api.github.com/repos/spatie/laravel-responsecache/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spatie/laravel-responsecache/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spatie/laravel-responsecache/teams","hooks_url":"https://api.github.com/repos/spatie/laravel-responsecache/hooks","issue_events_url":"https://api.github.com/repos/spatie/laravel-responsecache/issues/events{/number}","events_url":"https://api.github.com/repos/spatie/laravel-responsecache/events","assignees_url":"https://api.github.com/repos/spatie/laravel-responsecache/assignees{/user}","branches_url":"https://api.github.com/repos/spatie/laravel-responsecache/branches{/branch}","tags_url":"https://api.github.com/repos/spatie/laravel-responsecache/tags","blobs_url":"https://api.github.com/repos/spatie/laravel-responsecache/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spatie/laravel-responsecache/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spatie/laravel-responsecache/git/refs{/sha}","trees_url":"https://api.github.com/repos/spatie/laravel-responsecache/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spatie/laravel-responsecache/statuses/{sha}","languages_url":"https://api.github.com/repos/spatie/laravel-responsecache/languages","stargazers_url":"https://api.github.com/repos/spatie/laravel-responsecache/stargazers","contributors_url":"https://api.github.com/repos/spatie/laravel-responsecache/contributors","subscribers_url":"https://api.github.com/repos/spatie/laravel-responsecache/subscribers","subscription_url":"https://api.github.com/repos/spatie/laravel-responsecache/subscription","commits_url":"https://api.github.com/repos/spatie/laravel-responsecache/commits{/sha}","git_commits_url":"https://api.github.com/repos/spatie/laravel-responsecache/git/commits{/sha}","comments_url":"https://api.github.com/repos/spatie/laravel-responsecache/comments{/number}","issue_comment_url":"https://api.github.com/repos/spatie/laravel-responsecache/issues/comments{/number}","contents_url":"https://api.github.com/repos/spatie/laravel-responsecache/contents/{+path}","compare_url":"https://api.github.com/repos/spatie/laravel-responsecache/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spatie/laravel-responsecache/merges","archive_url":"https://api.github.com/repos/spatie/laravel-responsecache/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spatie/laravel-responsecache/downloads","issues_url":"https://api.github.com/repos/spatie/laravel-responsecache/issues{/number}","pulls_url":"https://api.github.com/repos/spatie/laravel-responsecache/pulls{/number}","milestones_url":"https://api.github.com/repos/spatie/laravel-responsecache/milestones{/number}","notifications_url":"https://api.github.com/repos/spatie/laravel-responsecache/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spatie/laravel-responsecache/labels{/name}","releases_url":"https://api.github.com/repos/spatie/laravel-responsecache/releases{/id}","deployments_url":"https://api.github.com/repos/spatie/laravel-responsecache/deployments","created_at":"2015-07-16T13:31:04Z","updated_at":"2018-02-25T19:57:37Z","pushed_at":"2018-02-25T22:15:11Z","git_url":"git://github.com/spatie/laravel-responsecache.git","ssh_url":"[email protected]:spatie/laravel-responsecache.git","clone_url":"https://github.com/spatie/laravel-responsecache.git","svn_url":"https://github.com/spatie/laravel-responsecache","homepage":"https://murze.be/2015/07/speed-up-a-laravel-app-by-caching-the-entire-response/","size":132,"stargazers_count":630,"watchers_count":630,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":59,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":59,"open_issues":3,"watchers":630,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spatie/laravel-responsecache/pulls/120"},"html":{"href":"https://github.com/spatie/laravel-responsecache/pull/120"},"issue":{"href":"https://api.github.com/repos/spatie/laravel-responsecache/issues/120"},"comments":{"href":"https://api.github.com/repos/spatie/laravel-responsecache/issues/120/comments"},"review_comments":{"href":"https://api.github.com/repos/spatie/laravel-responsecache/pulls/120/comments"},"review_comment":{"href":"https://api.github.com/repos/spatie/laravel-responsecache/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spatie/laravel-responsecache/pulls/120/commits"},"statuses":{"href":"https://api.github.com/repos/spatie/laravel-responsecache/statuses/9b2242fd5950bc35df668a1227bc3fae2fc572bf"}},"author_association":"NONE"}} | {
"id": 39198480,
"name": "spatie/laravel-responsecache",
"url": "https://api.github.com/repos/spatie/laravel-responsecache"
} | {
"id": 483853,
"login": "freekmurze",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/483853?",
"url": "https://api.github.com/users/freekmurze"
} | {
"id": 7535935,
"login": "spatie",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7535935?",
"url": "https://api.github.com/orgs/spatie"
} | 2018-02-26T08:57:13 | 7295907599 | {"actor":{"display_login":"freekmurze"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/spinnaker/fiat/pulls/comments/201821804","pull_request_review_id":136400009,"id":201821804,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMTgyMTgwNA==","diff_hunk":"@@ -29,5 +29,7 @@\n @Min(1L)\n Integer paginationValue = 100;\n @NotNull\n- Integer membershipCacheTTLSeconds = 60 * 60; // 1 hour\n+ Integer membershipCacheTTLSeconds = 60 * 10; // 10 min time to refresh","path":"fiat-github/src/main/java/com/netflix/spinnaker/fiat/roles/github/GitHubProperties.java","position":5,"original_position":5,"commit_id":"ba60b95d53720a8026cbb786313f5cae87149da0","original_commit_id":"ba60b95d53720a8026cbb786313f5cae87149da0","user":{"login":"ttomsu","id":13141550,"node_id":"MDQ6VXNlcjEzMTQxNTUw","avatar_url":"https://avatars2.githubusercontent.com/u/13141550?v=4","gravatar_id":"","url":"https://api.github.com/users/ttomsu","html_url":"https://github.com/ttomsu","followers_url":"https://api.github.com/users/ttomsu/followers","following_url":"https://api.github.com/users/ttomsu/following{/other_user}","gists_url":"https://api.github.com/users/ttomsu/gists{/gist_id}","starred_url":"https://api.github.com/users/ttomsu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ttomsu/subscriptions","organizations_url":"https://api.github.com/users/ttomsu/orgs","repos_url":"https://api.github.com/users/ttomsu/repos","events_url":"https://api.github.com/users/ttomsu/events{/privacy}","received_events_url":"https://api.github.com/users/ttomsu/received_events","type":"User","site_admin":false},"body":"Is there a reason to bring this TTL down? Wouldn't a lower TTL cause more requests?","created_at":"2018-07-11T20:01:52Z","updated_at":"2018-07-11T20:12:26Z","html_url":"https://github.com/spinnaker/fiat/pull/247#discussion_r201821804","pull_request_url":"https://api.github.com/repos/spinnaker/fiat/pulls/247","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/spinnaker/fiat/pulls/comments/201821804"},"html":{"href":"https://github.com/spinnaker/fiat/pull/247#discussion_r201821804"},"pull_request":{"href":"https://api.github.com/repos/spinnaker/fiat/pulls/247"}}},"pull_request":{"url":"https://api.github.com/repos/spinnaker/fiat/pulls/247","id":200750103,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAwNzUwMTAz","html_url":"https://github.com/spinnaker/fiat/pull/247","diff_url":"https://github.com/spinnaker/fiat/pull/247.diff","patch_url":"https://github.com/spinnaker/fiat/pull/247.patch","issue_url":"https://api.github.com/repos/spinnaker/fiat/issues/247","number":247,"state":"open","locked":false,"title":"fix(roles/github): Reduce burden of github reads for teams and make re…","user":{"login":"rfarrjr","id":431226,"node_id":"MDQ6VXNlcjQzMTIyNg==","avatar_url":"https://avatars0.githubusercontent.com/u/431226?v=4","gravatar_id":"","url":"https://api.github.com/users/rfarrjr","html_url":"https://github.com/rfarrjr","followers_url":"https://api.github.com/users/rfarrjr/followers","following_url":"https://api.github.com/users/rfarrjr/following{/other_user}","gists_url":"https://api.github.com/users/rfarrjr/gists{/gist_id}","starred_url":"https://api.github.com/users/rfarrjr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rfarrjr/subscriptions","organizations_url":"https://api.github.com/users/rfarrjr/orgs","repos_url":"https://api.github.com/users/rfarrjr/repos","events_url":"https://api.github.com/users/rfarrjr/events{/privacy}","received_events_url":"https://api.github.com/users/rfarrjr/received_events","type":"User","site_admin":false},"body":"…silient to rate-limiting.\r\n\r\nAs our github org has grown we have had more and more difficulty with rate-limits from github. This change reworks the calls to github to cache the teams and user information with a default backing cache.\r\n\r\nThe cache can be tweaked with configuration:\r\n```yaml\r\nauth:\r\n groupMembership:\r\n github:\r\n membershipCacheTTLSeconds: 600\r\n membershipCacheTeamsSize: 1000\r\n``` ","created_at":"2018-07-11T15:59:47Z","updated_at":"2018-07-11T20:12:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ec83888957f5640f55a8dde5586550ecfd90d592","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/spinnaker/fiat/pulls/247/commits","review_comments_url":"https://api.github.com/repos/spinnaker/fiat/pulls/247/comments","review_comment_url":"https://api.github.com/repos/spinnaker/fiat/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spinnaker/fiat/issues/247/comments","statuses_url":"https://api.github.com/repos/spinnaker/fiat/statuses/ba60b95d53720a8026cbb786313f5cae87149da0","head":{"label":"rfarrjr:github_perf","ref":"github_perf","sha":"ba60b95d53720a8026cbb786313f5cae87149da0","user":{"login":"rfarrjr","id":431226,"node_id":"MDQ6VXNlcjQzMTIyNg==","avatar_url":"https://avatars0.githubusercontent.com/u/431226?v=4","gravatar_id":"","url":"https://api.github.com/users/rfarrjr","html_url":"https://github.com/rfarrjr","followers_url":"https://api.github.com/users/rfarrjr/followers","following_url":"https://api.github.com/users/rfarrjr/following{/other_user}","gists_url":"https://api.github.com/users/rfarrjr/gists{/gist_id}","starred_url":"https://api.github.com/users/rfarrjr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rfarrjr/subscriptions","organizations_url":"https://api.github.com/users/rfarrjr/orgs","repos_url":"https://api.github.com/users/rfarrjr/repos","events_url":"https://api.github.com/users/rfarrjr/events{/privacy}","received_events_url":"https://api.github.com/users/rfarrjr/received_events","type":"User","site_admin":false},"repo":{"id":97720568,"node_id":"MDEwOlJlcG9zaXRvcnk5NzcyMDU2OA==","name":"fiat","full_name":"rfarrjr/fiat","owner":{"login":"rfarrjr","id":431226,"node_id":"MDQ6VXNlcjQzMTIyNg==","avatar_url":"https://avatars0.githubusercontent.com/u/431226?v=4","gravatar_id":"","url":"https://api.github.com/users/rfarrjr","html_url":"https://github.com/rfarrjr","followers_url":"https://api.github.com/users/rfarrjr/followers","following_url":"https://api.github.com/users/rfarrjr/following{/other_user}","gists_url":"https://api.github.com/users/rfarrjr/gists{/gist_id}","starred_url":"https://api.github.com/users/rfarrjr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rfarrjr/subscriptions","organizations_url":"https://api.github.com/users/rfarrjr/orgs","repos_url":"https://api.github.com/users/rfarrjr/repos","events_url":"https://api.github.com/users/rfarrjr/events{/privacy}","received_events_url":"https://api.github.com/users/rfarrjr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rfarrjr/fiat","description":"Spinnaker auth service","fork":true,"url":"https://api.github.com/repos/rfarrjr/fiat","forks_url":"https://api.github.com/repos/rfarrjr/fiat/forks","keys_url":"https://api.github.com/repos/rfarrjr/fiat/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rfarrjr/fiat/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rfarrjr/fiat/teams","hooks_url":"https://api.github.com/repos/rfarrjr/fiat/hooks","issue_events_url":"https://api.github.com/repos/rfarrjr/fiat/issues/events{/number}","events_url":"https://api.github.com/repos/rfarrjr/fiat/events","assignees_url":"https://api.github.com/repos/rfarrjr/fiat/assignees{/user}","branches_url":"https://api.github.com/repos/rfarrjr/fiat/branches{/branch}","tags_url":"https://api.github.com/repos/rfarrjr/fiat/tags","blobs_url":"https://api.github.com/repos/rfarrjr/fiat/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rfarrjr/fiat/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rfarrjr/fiat/git/refs{/sha}","trees_url":"https://api.github.com/repos/rfarrjr/fiat/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rfarrjr/fiat/statuses/{sha}","languages_url":"https://api.github.com/repos/rfarrjr/fiat/languages","stargazers_url":"https://api.github.com/repos/rfarrjr/fiat/stargazers","contributors_url":"https://api.github.com/repos/rfarrjr/fiat/contributors","subscribers_url":"https://api.github.com/repos/rfarrjr/fiat/subscribers","subscription_url":"https://api.github.com/repos/rfarrjr/fiat/subscription","commits_url":"https://api.github.com/repos/rfarrjr/fiat/commits{/sha}","git_commits_url":"https://api.github.com/repos/rfarrjr/fiat/git/commits{/sha}","comments_url":"https://api.github.com/repos/rfarrjr/fiat/comments{/number}","issue_comment_url":"https://api.github.com/repos/rfarrjr/fiat/issues/comments{/number}","contents_url":"https://api.github.com/repos/rfarrjr/fiat/contents/{+path}","compare_url":"https://api.github.com/repos/rfarrjr/fiat/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rfarrjr/fiat/merges","archive_url":"https://api.github.com/repos/rfarrjr/fiat/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rfarrjr/fiat/downloads","issues_url":"https://api.github.com/repos/rfarrjr/fiat/issues{/number}","pulls_url":"https://api.github.com/repos/rfarrjr/fiat/pulls{/number}","milestones_url":"https://api.github.com/repos/rfarrjr/fiat/milestones{/number}","notifications_url":"https://api.github.com/repos/rfarrjr/fiat/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rfarrjr/fiat/labels{/name}","releases_url":"https://api.github.com/repos/rfarrjr/fiat/releases{/id}","deployments_url":"https://api.github.com/repos/rfarrjr/fiat/deployments","created_at":"2017-07-19T13:40:13Z","updated_at":"2017-07-19T13:40:15Z","pushed_at":"2018-07-11T17:46:34Z","git_url":"git://github.com/rfarrjr/fiat.git","ssh_url":"[email protected]:rfarrjr/fiat.git","clone_url":"https://github.com/rfarrjr/fiat.git","svn_url":"https://github.com/rfarrjr/fiat","homepage":null,"size":715,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"spinnaker:master","ref":"master","sha":"47697f547e9e355147581d5a998f6ca7ae16bb28","user":{"login":"spinnaker","id":7634182,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc2MzQxODI=","avatar_url":"https://avatars1.githubusercontent.com/u/7634182?v=4","gravatar_id":"","url":"https://api.github.com/users/spinnaker","html_url":"https://github.com/spinnaker","followers_url":"https://api.github.com/users/spinnaker/followers","following_url":"https://api.github.com/users/spinnaker/following{/other_user}","gists_url":"https://api.github.com/users/spinnaker/gists{/gist_id}","starred_url":"https://api.github.com/users/spinnaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spinnaker/subscriptions","organizations_url":"https://api.github.com/users/spinnaker/orgs","repos_url":"https://api.github.com/users/spinnaker/repos","events_url":"https://api.github.com/users/spinnaker/events{/privacy}","received_events_url":"https://api.github.com/users/spinnaker/received_events","type":"Organization","site_admin":false},"repo":{"id":61139592,"node_id":"MDEwOlJlcG9zaXRvcnk2MTEzOTU5Mg==","name":"fiat","full_name":"spinnaker/fiat","owner":{"login":"spinnaker","id":7634182,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc2MzQxODI=","avatar_url":"https://avatars1.githubusercontent.com/u/7634182?v=4","gravatar_id":"","url":"https://api.github.com/users/spinnaker","html_url":"https://github.com/spinnaker","followers_url":"https://api.github.com/users/spinnaker/followers","following_url":"https://api.github.com/users/spinnaker/following{/other_user}","gists_url":"https://api.github.com/users/spinnaker/gists{/gist_id}","starred_url":"https://api.github.com/users/spinnaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spinnaker/subscriptions","organizations_url":"https://api.github.com/users/spinnaker/orgs","repos_url":"https://api.github.com/users/spinnaker/repos","events_url":"https://api.github.com/users/spinnaker/events{/privacy}","received_events_url":"https://api.github.com/users/spinnaker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spinnaker/fiat","description":"Spinnaker auth service","fork":false,"url":"https://api.github.com/repos/spinnaker/fiat","forks_url":"https://api.github.com/repos/spinnaker/fiat/forks","keys_url":"https://api.github.com/repos/spinnaker/fiat/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spinnaker/fiat/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spinnaker/fiat/teams","hooks_url":"https://api.github.com/repos/spinnaker/fiat/hooks","issue_events_url":"https://api.github.com/repos/spinnaker/fiat/issues/events{/number}","events_url":"https://api.github.com/repos/spinnaker/fiat/events","assignees_url":"https://api.github.com/repos/spinnaker/fiat/assignees{/user}","branches_url":"https://api.github.com/repos/spinnaker/fiat/branches{/branch}","tags_url":"https://api.github.com/repos/spinnaker/fiat/tags","blobs_url":"https://api.github.com/repos/spinnaker/fiat/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spinnaker/fiat/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spinnaker/fiat/git/refs{/sha}","trees_url":"https://api.github.com/repos/spinnaker/fiat/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spinnaker/fiat/statuses/{sha}","languages_url":"https://api.github.com/repos/spinnaker/fiat/languages","stargazers_url":"https://api.github.com/repos/spinnaker/fiat/stargazers","contributors_url":"https://api.github.com/repos/spinnaker/fiat/contributors","subscribers_url":"https://api.github.com/repos/spinnaker/fiat/subscribers","subscription_url":"https://api.github.com/repos/spinnaker/fiat/subscription","commits_url":"https://api.github.com/repos/spinnaker/fiat/commits{/sha}","git_commits_url":"https://api.github.com/repos/spinnaker/fiat/git/commits{/sha}","comments_url":"https://api.github.com/repos/spinnaker/fiat/comments{/number}","issue_comment_url":"https://api.github.com/repos/spinnaker/fiat/issues/comments{/number}","contents_url":"https://api.github.com/repos/spinnaker/fiat/contents/{+path}","compare_url":"https://api.github.com/repos/spinnaker/fiat/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spinnaker/fiat/merges","archive_url":"https://api.github.com/repos/spinnaker/fiat/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spinnaker/fiat/downloads","issues_url":"https://api.github.com/repos/spinnaker/fiat/issues{/number}","pulls_url":"https://api.github.com/repos/spinnaker/fiat/pulls{/number}","milestones_url":"https://api.github.com/repos/spinnaker/fiat/milestones{/number}","notifications_url":"https://api.github.com/repos/spinnaker/fiat/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spinnaker/fiat/labels{/name}","releases_url":"https://api.github.com/repos/spinnaker/fiat/releases{/id}","deployments_url":"https://api.github.com/repos/spinnaker/fiat/deployments","created_at":"2016-06-14T16:44:56Z","updated_at":"2018-07-09T23:00:23Z","pushed_at":"2018-07-11T17:46:35Z","git_url":"git://github.com/spinnaker/fiat.git","ssh_url":"[email protected]:spinnaker/fiat.git","clone_url":"https://github.com/spinnaker/fiat.git","svn_url":"https://github.com/spinnaker/fiat","homepage":null,"size":645,"stargazers_count":19,"watchers_count":19,"language":"Java","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":184,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":184,"open_issues":2,"watchers":19,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spinnaker/fiat/pulls/247"},"html":{"href":"https://github.com/spinnaker/fiat/pull/247"},"issue":{"href":"https://api.github.com/repos/spinnaker/fiat/issues/247"},"comments":{"href":"https://api.github.com/repos/spinnaker/fiat/issues/247/comments"},"review_comments":{"href":"https://api.github.com/repos/spinnaker/fiat/pulls/247/comments"},"review_comment":{"href":"https://api.github.com/repos/spinnaker/fiat/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spinnaker/fiat/pulls/247/commits"},"statuses":{"href":"https://api.github.com/repos/spinnaker/fiat/statuses/ba60b95d53720a8026cbb786313f5cae87149da0"}},"author_association":"NONE"}} | {
"id": 61139592,
"name": "spinnaker/fiat",
"url": "https://api.github.com/repos/spinnaker/fiat"
} | {
"id": 13141550,
"login": "ttomsu",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/13141550?",
"url": "https://api.github.com/users/ttomsu"
} | {
"id": 7634182,
"login": "spinnaker",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7634182?",
"url": "https://api.github.com/orgs/spinnaker"
} | 2018-07-11T20:01:52 | 7952335339 | {"actor":{"display_login":"ttomsu"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/massgov/mayflower/pulls/comments/223713044","pull_request_review_id":162905343,"id":223713044,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMzcxMzA0NA==","diff_hunk":"@@ -691,23 +858,26 @@\n \"titleContext\": \"\"\n },\n \"stacked\": true,\n- \"links\" : [{\n- \"href\":\"#\",\n- \"text\":\"Log in to UI Online for recipients\",\n- \"info\": \"\",\n- \"property\": \"\"\n- },{\n- \"href\":\"#\",\n- \"text\":\"Appeal UI decision\",\n- \"info\": \"\",\n- \"property\": \"\"\n- },{\n- \"href\":\"#\",\n- \"text\":\"Apply for a job training program\",\n- \"info\": \"\",\n- \"property\": \"\"\n- }]\n+ \"links\": [\n+ {\n+ \"href\": \"#\",\n+ \"text\": \"Log in to UI Online for recipients\",\n+ \"info\": \"\",\n+ \"property\": \"\"\n+ },\n+ {\n+ \"href\": \"#\",\n+ \"text\": \"Appeal UI decision\",\n+ \"info\": \"\",\n+ \"property\": \"\"\n+ },\n+ {\n+ \"href\": \"#\",\n+ \"text\": \"Apply for a job training program\",\n+ \"info\": \"\",\n+ \"property\": \"\"\n+ }\n+ ]\n }\n-\n }\n-}\n+}","path":"patternlab/styleguide/source/_patterns/05-pages/howto.json","position":1406,"original_position":1406,"commit_id":"793e8eac9fd7af9e9a4819f8e3ac7f032f88de09","original_commit_id":"793e8eac9fd7af9e9a4819f8e3ac7f032f88de09","user":{"login":"tnathanjames","id":5727673,"node_id":"MDQ6VXNlcjU3Mjc2NzM=","avatar_url":"https://avatars1.githubusercontent.com/u/5727673?v=4","gravatar_id":"","url":"https://api.github.com/users/tnathanjames","html_url":"https://github.com/tnathanjames","followers_url":"https://api.github.com/users/tnathanjames/followers","following_url":"https://api.github.com/users/tnathanjames/following{/other_user}","gists_url":"https://api.github.com/users/tnathanjames/gists{/gist_id}","starred_url":"https://api.github.com/users/tnathanjames/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tnathanjames/subscriptions","organizations_url":"https://api.github.com/users/tnathanjames/orgs","repos_url":"https://api.github.com/users/tnathanjames/repos","events_url":"https://api.github.com/users/tnathanjames/events{/privacy}","received_events_url":"https://api.github.com/users/tnathanjames/received_events","type":"User","site_admin":false},"body":"Git really likes a single line down at the end of files.","created_at":"2018-10-09T14:00:59Z","updated_at":"2018-10-09T14:00:59Z","html_url":"https://github.com/massgov/mayflower/pull/294#discussion_r223713044","pull_request_url":"https://api.github.com/repos/massgov/mayflower/pulls/294","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/massgov/mayflower/pulls/comments/223713044"},"html":{"href":"https://github.com/massgov/mayflower/pull/294#discussion_r223713044"},"pull_request":{"href":"https://api.github.com/repos/massgov/mayflower/pulls/294"}}},"pull_request":{"url":"https://api.github.com/repos/massgov/mayflower/pulls/294","id":221253975,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIxMjUzOTc1","html_url":"https://github.com/massgov/mayflower/pull/294","diff_url":"https://github.com/massgov/mayflower/pull/294.diff","patch_url":"https://github.com/massgov/mayflower/pull/294.patch","issue_url":"https://api.github.com/repos/massgov/mayflower/issues/294","number":294,"state":"open","locked":false,"title":"Patternlab/DP-10522 adding section to how-tos for return visitors","user":{"login":"clair0917","id":18662734,"node_id":"MDQ6VXNlcjE4NjYyNzM0","avatar_url":"https://avatars2.githubusercontent.com/u/18662734?v=4","gravatar_id":"","url":"https://api.github.com/users/clair0917","html_url":"https://github.com/clair0917","followers_url":"https://api.github.com/users/clair0917/followers","following_url":"https://api.github.com/users/clair0917/following{/other_user}","gists_url":"https://api.github.com/users/clair0917/gists{/gist_id}","starred_url":"https://api.github.com/users/clair0917/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clair0917/subscriptions","organizations_url":"https://api.github.com/users/clair0917/orgs","repos_url":"https://api.github.com/users/clair0917/repos","events_url":"https://api.github.com/users/clair0917/events{/privacy}","received_events_url":"https://api.github.com/users/clair0917/received_events","type":"User","site_admin":false},"body":"## Description\r\nAdds an Account Management organism for returning visitors on how to pages\r\n \r\n## Related Issue / Ticket\r\n\r\n- [JIRA issue DP-10522](https://jira.mass.gov/browse/DP-10522)\r\n\r\n## Steps to Test\r\n<!-- Outline the steps to test or reproduce the PR here. Whenever possible deploy your branch to your fork Github Pages so UAT can be done without rebuilding. See: https://github.com/massgov/mayflower/blob/master/docs/deploy.md -->\r\n\r\n1. The pattern can be reviewed at /?p=organisms-account-manager\r\n2. The patter can be reviewed on the how-to page at /?p=pages-howto\r\n\r\n## Screenshots\r\n<img width=\"885\" alt=\"screen shot 2018-10-08 at 4 58 31 pm\" src=\"https://user-images.githubusercontent.com/18662734/46635865-6db60100-cb1b-11e8-8c7d-6bba9a47d6e2.png\">\r\n\r\n\r\n","created_at":"2018-10-08T21:56:37Z","updated_at":"2018-10-09T14:00:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1b1f52e4516b5f6880a156d209bd056b1a9047ec","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/massgov/mayflower/pulls/294/commits","review_comments_url":"https://api.github.com/repos/massgov/mayflower/pulls/294/comments","review_comment_url":"https://api.github.com/repos/massgov/mayflower/pulls/comments{/number}","comments_url":"https://api.github.com/repos/massgov/mayflower/issues/294/comments","statuses_url":"https://api.github.com/repos/massgov/mayflower/statuses/793e8eac9fd7af9e9a4819f8e3ac7f032f88de09","head":{"label":"massgov:patternlab/DP-10522--adding-section-to-howtos-for-return-visitors","ref":"patternlab/DP-10522--adding-section-to-howtos-for-return-visitors","sha":"793e8eac9fd7af9e9a4819f8e3ac7f032f88de09","user":{"login":"massgov","id":7770800,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc3NzA4MDA=","avatar_url":"https://avatars3.githubusercontent.com/u/7770800?v=4","gravatar_id":"","url":"https://api.github.com/users/massgov","html_url":"https://github.com/massgov","followers_url":"https://api.github.com/users/massgov/followers","following_url":"https://api.github.com/users/massgov/following{/other_user}","gists_url":"https://api.github.com/users/massgov/gists{/gist_id}","starred_url":"https://api.github.com/users/massgov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/massgov/subscriptions","organizations_url":"https://api.github.com/users/massgov/orgs","repos_url":"https://api.github.com/users/massgov/repos","events_url":"https://api.github.com/users/massgov/events{/privacy}","received_events_url":"https://api.github.com/users/massgov/received_events","type":"Organization","site_admin":false},"repo":{"id":137521197,"node_id":"MDEwOlJlcG9zaXRvcnkxMzc1MjExOTc=","name":"mayflower","full_name":"massgov/mayflower","private":false,"owner":{"login":"massgov","id":7770800,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc3NzA4MDA=","avatar_url":"https://avatars3.githubusercontent.com/u/7770800?v=4","gravatar_id":"","url":"https://api.github.com/users/massgov","html_url":"https://github.com/massgov","followers_url":"https://api.github.com/users/massgov/followers","following_url":"https://api.github.com/users/massgov/following{/other_user}","gists_url":"https://api.github.com/users/massgov/gists{/gist_id}","starred_url":"https://api.github.com/users/massgov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/massgov/subscriptions","organizations_url":"https://api.github.com/users/massgov/orgs","repos_url":"https://api.github.com/users/massgov/repos","events_url":"https://api.github.com/users/massgov/events{/privacy}","received_events_url":"https://api.github.com/users/massgov/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/massgov/mayflower","description":"Mayflower Mono Repo (react and pattern lab and documentation)","fork":false,"url":"https://api.github.com/repos/massgov/mayflower","forks_url":"https://api.github.com/repos/massgov/mayflower/forks","keys_url":"https://api.github.com/repos/massgov/mayflower/keys{/key_id}","collaborators_url":"https://api.github.com/repos/massgov/mayflower/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/massgov/mayflower/teams","hooks_url":"https://api.github.com/repos/massgov/mayflower/hooks","issue_events_url":"https://api.github.com/repos/massgov/mayflower/issues/events{/number}","events_url":"https://api.github.com/repos/massgov/mayflower/events","assignees_url":"https://api.github.com/repos/massgov/mayflower/assignees{/user}","branches_url":"https://api.github.com/repos/massgov/mayflower/branches{/branch}","tags_url":"https://api.github.com/repos/massgov/mayflower/tags","blobs_url":"https://api.github.com/repos/massgov/mayflower/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/massgov/mayflower/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/massgov/mayflower/git/refs{/sha}","trees_url":"https://api.github.com/repos/massgov/mayflower/git/trees{/sha}","statuses_url":"https://api.github.com/repos/massgov/mayflower/statuses/{sha}","languages_url":"https://api.github.com/repos/massgov/mayflower/languages","stargazers_url":"https://api.github.com/repos/massgov/mayflower/stargazers","contributors_url":"https://api.github.com/repos/massgov/mayflower/contributors","subscribers_url":"https://api.github.com/repos/massgov/mayflower/subscribers","subscription_url":"https://api.github.com/repos/massgov/mayflower/subscription","commits_url":"https://api.github.com/repos/massgov/mayflower/commits{/sha}","git_commits_url":"https://api.github.com/repos/massgov/mayflower/git/commits{/sha}","comments_url":"https://api.github.com/repos/massgov/mayflower/comments{/number}","issue_comment_url":"https://api.github.com/repos/massgov/mayflower/issues/comments{/number}","contents_url":"https://api.github.com/repos/massgov/mayflower/contents/{+path}","compare_url":"https://api.github.com/repos/massgov/mayflower/compare/{base}...{head}","merges_url":"https://api.github.com/repos/massgov/mayflower/merges","archive_url":"https://api.github.com/repos/massgov/mayflower/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/massgov/mayflower/downloads","issues_url":"https://api.github.com/repos/massgov/mayflower/issues{/number}","pulls_url":"https://api.github.com/repos/massgov/mayflower/pulls{/number}","milestones_url":"https://api.github.com/repos/massgov/mayflower/milestones{/number}","notifications_url":"https://api.github.com/repos/massgov/mayflower/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/massgov/mayflower/labels{/name}","releases_url":"https://api.github.com/repos/massgov/mayflower/releases{/id}","deployments_url":"https://api.github.com/repos/massgov/mayflower/deployments","created_at":"2018-06-15T18:43:35Z","updated_at":"2018-10-05T15:36:27Z","pushed_at":"2018-10-09T13:43:08Z","git_url":"git://github.com/massgov/mayflower.git","ssh_url":"[email protected]:massgov/mayflower.git","clone_url":"https://github.com/massgov/mayflower.git","svn_url":"https://github.com/massgov/mayflower","homepage":"","size":922865,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":41,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":3,"open_issues":41,"watchers":2,"default_branch":"develop"}},"base":{"label":"massgov:develop","ref":"develop","sha":"493b3a06466adcda46ccb06e48220860a59fa337","user":{"login":"massgov","id":7770800,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc3NzA4MDA=","avatar_url":"https://avatars3.githubusercontent.com/u/7770800?v=4","gravatar_id":"","url":"https://api.github.com/users/massgov","html_url":"https://github.com/massgov","followers_url":"https://api.github.com/users/massgov/followers","following_url":"https://api.github.com/users/massgov/following{/other_user}","gists_url":"https://api.github.com/users/massgov/gists{/gist_id}","starred_url":"https://api.github.com/users/massgov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/massgov/subscriptions","organizations_url":"https://api.github.com/users/massgov/orgs","repos_url":"https://api.github.com/users/massgov/repos","events_url":"https://api.github.com/users/massgov/events{/privacy}","received_events_url":"https://api.github.com/users/massgov/received_events","type":"Organization","site_admin":false},"repo":{"id":137521197,"node_id":"MDEwOlJlcG9zaXRvcnkxMzc1MjExOTc=","name":"mayflower","full_name":"massgov/mayflower","private":false,"owner":{"login":"massgov","id":7770800,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc3NzA4MDA=","avatar_url":"https://avatars3.githubusercontent.com/u/7770800?v=4","gravatar_id":"","url":"https://api.github.com/users/massgov","html_url":"https://github.com/massgov","followers_url":"https://api.github.com/users/massgov/followers","following_url":"https://api.github.com/users/massgov/following{/other_user}","gists_url":"https://api.github.com/users/massgov/gists{/gist_id}","starred_url":"https://api.github.com/users/massgov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/massgov/subscriptions","organizations_url":"https://api.github.com/users/massgov/orgs","repos_url":"https://api.github.com/users/massgov/repos","events_url":"https://api.github.com/users/massgov/events{/privacy}","received_events_url":"https://api.github.com/users/massgov/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/massgov/mayflower","description":"Mayflower Mono Repo (react and pattern lab and documentation)","fork":false,"url":"https://api.github.com/repos/massgov/mayflower","forks_url":"https://api.github.com/repos/massgov/mayflower/forks","keys_url":"https://api.github.com/repos/massgov/mayflower/keys{/key_id}","collaborators_url":"https://api.github.com/repos/massgov/mayflower/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/massgov/mayflower/teams","hooks_url":"https://api.github.com/repos/massgov/mayflower/hooks","issue_events_url":"https://api.github.com/repos/massgov/mayflower/issues/events{/number}","events_url":"https://api.github.com/repos/massgov/mayflower/events","assignees_url":"https://api.github.com/repos/massgov/mayflower/assignees{/user}","branches_url":"https://api.github.com/repos/massgov/mayflower/branches{/branch}","tags_url":"https://api.github.com/repos/massgov/mayflower/tags","blobs_url":"https://api.github.com/repos/massgov/mayflower/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/massgov/mayflower/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/massgov/mayflower/git/refs{/sha}","trees_url":"https://api.github.com/repos/massgov/mayflower/git/trees{/sha}","statuses_url":"https://api.github.com/repos/massgov/mayflower/statuses/{sha}","languages_url":"https://api.github.com/repos/massgov/mayflower/languages","stargazers_url":"https://api.github.com/repos/massgov/mayflower/stargazers","contributors_url":"https://api.github.com/repos/massgov/mayflower/contributors","subscribers_url":"https://api.github.com/repos/massgov/mayflower/subscribers","subscription_url":"https://api.github.com/repos/massgov/mayflower/subscription","commits_url":"https://api.github.com/repos/massgov/mayflower/commits{/sha}","git_commits_url":"https://api.github.com/repos/massgov/mayflower/git/commits{/sha}","comments_url":"https://api.github.com/repos/massgov/mayflower/comments{/number}","issue_comment_url":"https://api.github.com/repos/massgov/mayflower/issues/comments{/number}","contents_url":"https://api.github.com/repos/massgov/mayflower/contents/{+path}","compare_url":"https://api.github.com/repos/massgov/mayflower/compare/{base}...{head}","merges_url":"https://api.github.com/repos/massgov/mayflower/merges","archive_url":"https://api.github.com/repos/massgov/mayflower/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/massgov/mayflower/downloads","issues_url":"https://api.github.com/repos/massgov/mayflower/issues{/number}","pulls_url":"https://api.github.com/repos/massgov/mayflower/pulls{/number}","milestones_url":"https://api.github.com/repos/massgov/mayflower/milestones{/number}","notifications_url":"https://api.github.com/repos/massgov/mayflower/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/massgov/mayflower/labels{/name}","releases_url":"https://api.github.com/repos/massgov/mayflower/releases{/id}","deployments_url":"https://api.github.com/repos/massgov/mayflower/deployments","created_at":"2018-06-15T18:43:35Z","updated_at":"2018-10-05T15:36:27Z","pushed_at":"2018-10-09T13:43:08Z","git_url":"git://github.com/massgov/mayflower.git","ssh_url":"[email protected]:massgov/mayflower.git","clone_url":"https://github.com/massgov/mayflower.git","svn_url":"https://github.com/massgov/mayflower","homepage":"","size":922865,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":41,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":3,"open_issues":41,"watchers":2,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/massgov/mayflower/pulls/294"},"html":{"href":"https://github.com/massgov/mayflower/pull/294"},"issue":{"href":"https://api.github.com/repos/massgov/mayflower/issues/294"},"comments":{"href":"https://api.github.com/repos/massgov/mayflower/issues/294/comments"},"review_comments":{"href":"https://api.github.com/repos/massgov/mayflower/pulls/294/comments"},"review_comment":{"href":"https://api.github.com/repos/massgov/mayflower/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/massgov/mayflower/pulls/294/commits"},"statuses":{"href":"https://api.github.com/repos/massgov/mayflower/statuses/793e8eac9fd7af9e9a4819f8e3ac7f032f88de09"}},"author_association":"CONTRIBUTOR"}} | {
"id": 137521197,
"name": "massgov/mayflower",
"url": "https://api.github.com/repos/massgov/mayflower"
} | {
"id": 5727673,
"login": "tnathanjames",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5727673?",
"url": "https://api.github.com/users/tnathanjames"
} | {
"id": 7770800,
"login": "massgov",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7770800?",
"url": "https://api.github.com/orgs/massgov"
} | 2018-10-09T14:00:59 | 8390985606 | {"actor":{"display_login":"tnathanjames"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/grpc/grpc/pulls/comments/174218172","pull_request_review_id":103534061,"id":174218172,"diff_hunk":"@@ -21,17 +21,21 @@\n set NUGET=C:\\nuget\\nuget.exe\n set DOTNET=dotnet\n \n- set -ex","path":"templates/src/csharp/build_packages_dotnetcli.bat.template","position":4,"original_position":4,"commit_id":"5f3a452440c57626fe1b228d853b1e790124b1f2","original_commit_id":"5f3a452440c57626fe1b228d853b1e790124b1f2","user":{"login":"jtattermusch","id":9939684,"avatar_url":"https://avatars1.githubusercontent.com/u/9939684?v=4","gravatar_id":"","url":"https://api.github.com/users/jtattermusch","html_url":"https://github.com/jtattermusch","followers_url":"https://api.github.com/users/jtattermusch/followers","following_url":"https://api.github.com/users/jtattermusch/following{/other_user}","gists_url":"https://api.github.com/users/jtattermusch/gists{/gist_id}","starred_url":"https://api.github.com/users/jtattermusch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jtattermusch/subscriptions","organizations_url":"https://api.github.com/users/jtattermusch/orgs","repos_url":"https://api.github.com/users/jtattermusch/repos","events_url":"https://api.github.com/users/jtattermusch/events{/privacy}","received_events_url":"https://api.github.com/users/jtattermusch/received_events","type":"User","site_admin":false},"body":"This actually wasn't doing anything, it's in a .bat file so it just prints \"set -ex Environment variable -ex not defined\".\r\nBehavior isn't changed by this edit.","created_at":"2018-03-13T17:27:33Z","updated_at":"2018-03-13T17:27:33Z","html_url":"https://github.com/grpc/grpc/pull/14689#discussion_r174218172","pull_request_url":"https://api.github.com/repos/grpc/grpc/pulls/14689","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/grpc/grpc/pulls/comments/174218172"},"html":{"href":"https://github.com/grpc/grpc/pull/14689#discussion_r174218172"},"pull_request":{"href":"https://api.github.com/repos/grpc/grpc/pulls/14689"}}},"pull_request":{"url":"https://api.github.com/repos/grpc/grpc/pulls/14689","id":174729620,"html_url":"https://github.com/grpc/grpc/pull/14689","diff_url":"https://github.com/grpc/grpc/pull/14689.diff","patch_url":"https://github.com/grpc/grpc/pull/14689.patch","issue_url":"https://api.github.com/repos/grpc/grpc/issues/14689","number":14689,"state":"open","locked":false,"title":"Adjust package builds so they can be built on kokoro as well.","user":{"login":"jtattermusch","id":9939684,"avatar_url":"https://avatars1.githubusercontent.com/u/9939684?v=4","gravatar_id":"","url":"https://api.github.com/users/jtattermusch","html_url":"https://github.com/jtattermusch","followers_url":"https://api.github.com/users/jtattermusch/followers","following_url":"https://api.github.com/users/jtattermusch/following{/other_user}","gists_url":"https://api.github.com/users/jtattermusch/gists{/gist_id}","starred_url":"https://api.github.com/users/jtattermusch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jtattermusch/subscriptions","organizations_url":"https://api.github.com/users/jtattermusch/orgs","repos_url":"https://api.github.com/users/jtattermusch/repos","events_url":"https://api.github.com/users/jtattermusch/events{/privacy}","received_events_url":"https://api.github.com/users/jtattermusch/received_events","type":"User","site_admin":false},"body":"Mostly adjustments to the path where to find the artifacts from previous build step.\r\nThese changes are backward compatible with the Jenkins setup (can still be built there).\r\nThe actual kokoro configuration files will come in a followup PR (I was able to build the packages in my experimental setup in kokoro).","created_at":"2018-03-13T17:12:09Z","updated_at":"2018-03-13T17:27:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fd1c3f6d49b4be3f5b8bbb3def702395ac64318f","assignee":{"login":"matt-kwong","id":22083734,"avatar_url":"https://avatars1.githubusercontent.com/u/22083734?v=4","gravatar_id":"","url":"https://api.github.com/users/matt-kwong","html_url":"https://github.com/matt-kwong","followers_url":"https://api.github.com/users/matt-kwong/followers","following_url":"https://api.github.com/users/matt-kwong/following{/other_user}","gists_url":"https://api.github.com/users/matt-kwong/gists{/gist_id}","starred_url":"https://api.github.com/users/matt-kwong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matt-kwong/subscriptions","organizations_url":"https://api.github.com/users/matt-kwong/orgs","repos_url":"https://api.github.com/users/matt-kwong/repos","events_url":"https://api.github.com/users/matt-kwong/events{/privacy}","received_events_url":"https://api.github.com/users/matt-kwong/received_events","type":"User","site_admin":false},"assignees":[{"login":"matt-kwong","id":22083734,"avatar_url":"https://avatars1.githubusercontent.com/u/22083734?v=4","gravatar_id":"","url":"https://api.github.com/users/matt-kwong","html_url":"https://github.com/matt-kwong","followers_url":"https://api.github.com/users/matt-kwong/followers","following_url":"https://api.github.com/users/matt-kwong/following{/other_user}","gists_url":"https://api.github.com/users/matt-kwong/gists{/gist_id}","starred_url":"https://api.github.com/users/matt-kwong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matt-kwong/subscriptions","organizations_url":"https://api.github.com/users/matt-kwong/orgs","repos_url":"https://api.github.com/users/matt-kwong/repos","events_url":"https://api.github.com/users/matt-kwong/events{/privacy}","received_events_url":"https://api.github.com/users/matt-kwong/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":196797751,"url":"https://api.github.com/repos/grpc/grpc/labels/area/packaging%20&%20distribution","name":"area/packaging & distribution","color":"efdb40","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/grpc/grpc/pulls/14689/commits","review_comments_url":"https://api.github.com/repos/grpc/grpc/pulls/14689/comments","review_comment_url":"https://api.github.com/repos/grpc/grpc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/grpc/grpc/issues/14689/comments","statuses_url":"https://api.github.com/repos/grpc/grpc/statuses/5f3a452440c57626fe1b228d853b1e790124b1f2","head":{"label":"jtattermusch:kokoro_prepare_package_building","ref":"kokoro_prepare_package_building","sha":"5f3a452440c57626fe1b228d853b1e790124b1f2","user":{"login":"jtattermusch","id":9939684,"avatar_url":"https://avatars1.githubusercontent.com/u/9939684?v=4","gravatar_id":"","url":"https://api.github.com/users/jtattermusch","html_url":"https://github.com/jtattermusch","followers_url":"https://api.github.com/users/jtattermusch/followers","following_url":"https://api.github.com/users/jtattermusch/following{/other_user}","gists_url":"https://api.github.com/users/jtattermusch/gists{/gist_id}","starred_url":"https://api.github.com/users/jtattermusch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jtattermusch/subscriptions","organizations_url":"https://api.github.com/users/jtattermusch/orgs","repos_url":"https://api.github.com/users/jtattermusch/repos","events_url":"https://api.github.com/users/jtattermusch/events{/privacy}","received_events_url":"https://api.github.com/users/jtattermusch/received_events","type":"User","site_admin":false},"repo":{"id":31382470,"name":"grpc","full_name":"jtattermusch/grpc","owner":{"login":"jtattermusch","id":9939684,"avatar_url":"https://avatars1.githubusercontent.com/u/9939684?v=4","gravatar_id":"","url":"https://api.github.com/users/jtattermusch","html_url":"https://github.com/jtattermusch","followers_url":"https://api.github.com/users/jtattermusch/followers","following_url":"https://api.github.com/users/jtattermusch/following{/other_user}","gists_url":"https://api.github.com/users/jtattermusch/gists{/gist_id}","starred_url":"https://api.github.com/users/jtattermusch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jtattermusch/subscriptions","organizations_url":"https://api.github.com/users/jtattermusch/orgs","repos_url":"https://api.github.com/users/jtattermusch/repos","events_url":"https://api.github.com/users/jtattermusch/events{/privacy}","received_events_url":"https://api.github.com/users/jtattermusch/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jtattermusch/grpc","description":"The C based gRPC (C++, Node.js, Python, Ruby, Objective-C, PHP, C#)","fork":true,"url":"https://api.github.com/repos/jtattermusch/grpc","forks_url":"https://api.github.com/repos/jtattermusch/grpc/forks","keys_url":"https://api.github.com/repos/jtattermusch/grpc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jtattermusch/grpc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jtattermusch/grpc/teams","hooks_url":"https://api.github.com/repos/jtattermusch/grpc/hooks","issue_events_url":"https://api.github.com/repos/jtattermusch/grpc/issues/events{/number}","events_url":"https://api.github.com/repos/jtattermusch/grpc/events","assignees_url":"https://api.github.com/repos/jtattermusch/grpc/assignees{/user}","branches_url":"https://api.github.com/repos/jtattermusch/grpc/branches{/branch}","tags_url":"https://api.github.com/repos/jtattermusch/grpc/tags","blobs_url":"https://api.github.com/repos/jtattermusch/grpc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jtattermusch/grpc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jtattermusch/grpc/git/refs{/sha}","trees_url":"https://api.github.com/repos/jtattermusch/grpc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jtattermusch/grpc/statuses/{sha}","languages_url":"https://api.github.com/repos/jtattermusch/grpc/languages","stargazers_url":"https://api.github.com/repos/jtattermusch/grpc/stargazers","contributors_url":"https://api.github.com/repos/jtattermusch/grpc/contributors","subscribers_url":"https://api.github.com/repos/jtattermusch/grpc/subscribers","subscription_url":"https://api.github.com/repos/jtattermusch/grpc/subscription","commits_url":"https://api.github.com/repos/jtattermusch/grpc/commits{/sha}","git_commits_url":"https://api.github.com/repos/jtattermusch/grpc/git/commits{/sha}","comments_url":"https://api.github.com/repos/jtattermusch/grpc/comments{/number}","issue_comment_url":"https://api.github.com/repos/jtattermusch/grpc/issues/comments{/number}","contents_url":"https://api.github.com/repos/jtattermusch/grpc/contents/{+path}","compare_url":"https://api.github.com/repos/jtattermusch/grpc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jtattermusch/grpc/merges","archive_url":"https://api.github.com/repos/jtattermusch/grpc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jtattermusch/grpc/downloads","issues_url":"https://api.github.com/repos/jtattermusch/grpc/issues{/number}","pulls_url":"https://api.github.com/repos/jtattermusch/grpc/pulls{/number}","milestones_url":"https://api.github.com/repos/jtattermusch/grpc/milestones{/number}","notifications_url":"https://api.github.com/repos/jtattermusch/grpc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jtattermusch/grpc/labels{/name}","releases_url":"https://api.github.com/repos/jtattermusch/grpc/releases{/id}","deployments_url":"https://api.github.com/repos/jtattermusch/grpc/deployments","created_at":"2015-02-26T18:39:52Z","updated_at":"2018-01-30T09:51:28Z","pushed_at":"2018-03-13T17:08:39Z","git_url":"git://github.com/jtattermusch/grpc.git","ssh_url":"[email protected]:jtattermusch/grpc.git","clone_url":"https://github.com/jtattermusch/grpc.git","svn_url":"https://github.com/jtattermusch/grpc","homepage":"","size":156278,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"grpc:master","ref":"master","sha":"129f38a8a5bde9db627b123c3aed91f898cb7cff","user":{"login":"grpc","id":7802525,"avatar_url":"https://avatars1.githubusercontent.com/u/7802525?v=4","gravatar_id":"","url":"https://api.github.com/users/grpc","html_url":"https://github.com/grpc","followers_url":"https://api.github.com/users/grpc/followers","following_url":"https://api.github.com/users/grpc/following{/other_user}","gists_url":"https://api.github.com/users/grpc/gists{/gist_id}","starred_url":"https://api.github.com/users/grpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grpc/subscriptions","organizations_url":"https://api.github.com/users/grpc/orgs","repos_url":"https://api.github.com/users/grpc/repos","events_url":"https://api.github.com/users/grpc/events{/privacy}","received_events_url":"https://api.github.com/users/grpc/received_events","type":"Organization","site_admin":false},"repo":{"id":27729880,"name":"grpc","full_name":"grpc/grpc","owner":{"login":"grpc","id":7802525,"avatar_url":"https://avatars1.githubusercontent.com/u/7802525?v=4","gravatar_id":"","url":"https://api.github.com/users/grpc","html_url":"https://github.com/grpc","followers_url":"https://api.github.com/users/grpc/followers","following_url":"https://api.github.com/users/grpc/following{/other_user}","gists_url":"https://api.github.com/users/grpc/gists{/gist_id}","starred_url":"https://api.github.com/users/grpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grpc/subscriptions","organizations_url":"https://api.github.com/users/grpc/orgs","repos_url":"https://api.github.com/users/grpc/repos","events_url":"https://api.github.com/users/grpc/events{/privacy}","received_events_url":"https://api.github.com/users/grpc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/grpc/grpc","description":"The C based gRPC (C++, Python, Ruby, Objective-C, PHP, C#)","fork":false,"url":"https://api.github.com/repos/grpc/grpc","forks_url":"https://api.github.com/repos/grpc/grpc/forks","keys_url":"https://api.github.com/repos/grpc/grpc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grpc/grpc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grpc/grpc/teams","hooks_url":"https://api.github.com/repos/grpc/grpc/hooks","issue_events_url":"https://api.github.com/repos/grpc/grpc/issues/events{/number}","events_url":"https://api.github.com/repos/grpc/grpc/events","assignees_url":"https://api.github.com/repos/grpc/grpc/assignees{/user}","branches_url":"https://api.github.com/repos/grpc/grpc/branches{/branch}","tags_url":"https://api.github.com/repos/grpc/grpc/tags","blobs_url":"https://api.github.com/repos/grpc/grpc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grpc/grpc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grpc/grpc/git/refs{/sha}","trees_url":"https://api.github.com/repos/grpc/grpc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grpc/grpc/statuses/{sha}","languages_url":"https://api.github.com/repos/grpc/grpc/languages","stargazers_url":"https://api.github.com/repos/grpc/grpc/stargazers","contributors_url":"https://api.github.com/repos/grpc/grpc/contributors","subscribers_url":"https://api.github.com/repos/grpc/grpc/subscribers","subscription_url":"https://api.github.com/repos/grpc/grpc/subscription","commits_url":"https://api.github.com/repos/grpc/grpc/commits{/sha}","git_commits_url":"https://api.github.com/repos/grpc/grpc/git/commits{/sha}","comments_url":"https://api.github.com/repos/grpc/grpc/comments{/number}","issue_comment_url":"https://api.github.com/repos/grpc/grpc/issues/comments{/number}","contents_url":"https://api.github.com/repos/grpc/grpc/contents/{+path}","compare_url":"https://api.github.com/repos/grpc/grpc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grpc/grpc/merges","archive_url":"https://api.github.com/repos/grpc/grpc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grpc/grpc/downloads","issues_url":"https://api.github.com/repos/grpc/grpc/issues{/number}","pulls_url":"https://api.github.com/repos/grpc/grpc/pulls{/number}","milestones_url":"https://api.github.com/repos/grpc/grpc/milestones{/number}","notifications_url":"https://api.github.com/repos/grpc/grpc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grpc/grpc/labels{/name}","releases_url":"https://api.github.com/repos/grpc/grpc/releases{/id}","deployments_url":"https://api.github.com/repos/grpc/grpc/deployments","created_at":"2014-12-08T18:58:53Z","updated_at":"2018-03-13T17:19:30Z","pushed_at":"2018-03-13T17:18:46Z","git_url":"git://github.com/grpc/grpc.git","ssh_url":"[email protected]:grpc/grpc.git","clone_url":"https://github.com/grpc/grpc.git","svn_url":"https://github.com/grpc/grpc","homepage":"https://grpc.io","size":173590,"stargazers_count":14040,"watchers_count":14040,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":true,"forks_count":3113,"mirror_url":null,"archived":false,"open_issues_count":1190,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":3113,"open_issues":1190,"watchers":14040,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/grpc/grpc/pulls/14689"},"html":{"href":"https://github.com/grpc/grpc/pull/14689"},"issue":{"href":"https://api.github.com/repos/grpc/grpc/issues/14689"},"comments":{"href":"https://api.github.com/repos/grpc/grpc/issues/14689/comments"},"review_comments":{"href":"https://api.github.com/repos/grpc/grpc/pulls/14689/comments"},"review_comment":{"href":"https://api.github.com/repos/grpc/grpc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/grpc/grpc/pulls/14689/commits"},"statuses":{"href":"https://api.github.com/repos/grpc/grpc/statuses/5f3a452440c57626fe1b228d853b1e790124b1f2"}},"author_association":"CONTRIBUTOR"}} | {
"id": 27729880,
"name": "grpc/grpc",
"url": "https://api.github.com/repos/grpc/grpc"
} | {
"id": 9939684,
"login": "jtattermusch",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9939684?",
"url": "https://api.github.com/users/jtattermusch"
} | {
"id": 7802525,
"login": "grpc",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7802525?",
"url": "https://api.github.com/orgs/grpc"
} | 2018-03-13T17:27:33 | 7373506552 | {"actor":{"display_login":"jtattermusch"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/grpc/grpc/pulls/comments/188433318","pull_request_review_id":120411494,"id":188433318,"diff_hunk":"@@ -65,4 +65,8 @@\n errors += 1\n \n assert errors == 0\n+# this check comes about from this issue:\n+# https://github.com/grpc/grpc/issues/15381\n+# basically, a change rendered this script useless and we did not realize.","path":"tools/run_tests/sanity/core_banned_functions.py","position":null,"original_position":6,"commit_id":"f02d33cd8e5e74d8f1a31beb62048b46c1138505","original_commit_id":"bd11a12169dad9b4e0131bdf09732e771b600e5e","user":{"login":"ncteisen","id":6148140,"avatar_url":"https://avatars1.githubusercontent.com/u/6148140?v=4","gravatar_id":"","url":"https://api.github.com/users/ncteisen","html_url":"https://github.com/ncteisen","followers_url":"https://api.github.com/users/ncteisen/followers","following_url":"https://api.github.com/users/ncteisen/following{/other_user}","gists_url":"https://api.github.com/users/ncteisen/gists{/gist_id}","starred_url":"https://api.github.com/users/ncteisen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ncteisen/subscriptions","organizations_url":"https://api.github.com/users/ncteisen/orgs","repos_url":"https://api.github.com/users/ncteisen/repos","events_url":"https://api.github.com/users/ncteisen/events{/privacy}","received_events_url":"https://api.github.com/users/ncteisen/received_events","type":"User","site_admin":false},"body":"Done","created_at":"2018-05-15T20:56:15Z","updated_at":"2018-05-15T20:56:15Z","html_url":"https://github.com/grpc/grpc/pull/15384#discussion_r188433318","pull_request_url":"https://api.github.com/repos/grpc/grpc/pulls/15384","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/grpc/grpc/pulls/comments/188433318"},"html":{"href":"https://github.com/grpc/grpc/pull/15384#discussion_r188433318"},"pull_request":{"href":"https://api.github.com/repos/grpc/grpc/pulls/15384"}},"in_reply_to_id":188431559},"pull_request":{"url":"https://api.github.com/repos/grpc/grpc/pulls/15384","id":188215087,"html_url":"https://github.com/grpc/grpc/pull/15384","diff_url":"https://github.com/grpc/grpc/pull/15384.diff","patch_url":"https://github.com/grpc/grpc/pull/15384.patch","issue_url":"https://api.github.com/repos/grpc/grpc/issues/15384","number":15384,"state":"open","locked":false,"title":"Fix Sanity Test for Core Banned Functions","user":{"login":"ncteisen","id":6148140,"avatar_url":"https://avatars1.githubusercontent.com/u/6148140?v=4","gravatar_id":"","url":"https://api.github.com/users/ncteisen","html_url":"https://github.com/ncteisen","followers_url":"https://api.github.com/users/ncteisen/followers","following_url":"https://api.github.com/users/ncteisen/following{/other_user}","gists_url":"https://api.github.com/users/ncteisen/gists{/gist_id}","starred_url":"https://api.github.com/users/ncteisen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ncteisen/subscriptions","organizations_url":"https://api.github.com/users/ncteisen/orgs","repos_url":"https://api.github.com/users/ncteisen/repos","events_url":"https://api.github.com/users/ncteisen/events{/privacy}","received_events_url":"https://api.github.com/users/ncteisen/received_events","type":"User","site_admin":false},"body":"Fixes #15381","created_at":"2018-05-15T18:24:06Z","updated_at":"2018-05-15T20:56:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3f27e6004b6b5c63674e8a64d29f2cb7ca55f991","assignee":{"login":"yashykt","id":4181124,"avatar_url":"https://avatars2.githubusercontent.com/u/4181124?v=4","gravatar_id":"","url":"https://api.github.com/users/yashykt","html_url":"https://github.com/yashykt","followers_url":"https://api.github.com/users/yashykt/followers","following_url":"https://api.github.com/users/yashykt/following{/other_user}","gists_url":"https://api.github.com/users/yashykt/gists{/gist_id}","starred_url":"https://api.github.com/users/yashykt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yashykt/subscriptions","organizations_url":"https://api.github.com/users/yashykt/orgs","repos_url":"https://api.github.com/users/yashykt/repos","events_url":"https://api.github.com/users/yashykt/events{/privacy}","received_events_url":"https://api.github.com/users/yashykt/received_events","type":"User","site_admin":false},"assignees":[{"login":"yashykt","id":4181124,"avatar_url":"https://avatars2.githubusercontent.com/u/4181124?v=4","gravatar_id":"","url":"https://api.github.com/users/yashykt","html_url":"https://github.com/yashykt","followers_url":"https://api.github.com/users/yashykt/followers","following_url":"https://api.github.com/users/yashykt/following{/other_user}","gists_url":"https://api.github.com/users/yashykt/gists{/gist_id}","starred_url":"https://api.github.com/users/yashykt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yashykt/subscriptions","organizations_url":"https://api.github.com/users/yashykt/orgs","repos_url":"https://api.github.com/users/yashykt/repos","events_url":"https://api.github.com/users/yashykt/events{/privacy}","received_events_url":"https://api.github.com/users/yashykt/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":166332702,"url":"https://api.github.com/repos/grpc/grpc/labels/area/core","name":"area/core","color":"efdb40","default":false},{"id":168238370,"url":"https://api.github.com/repos/grpc/grpc/labels/lang/C%23","name":"lang/C#","color":"fad8c7","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/grpc/grpc/pulls/15384/commits","review_comments_url":"https://api.github.com/repos/grpc/grpc/pulls/15384/comments","review_comment_url":"https://api.github.com/repos/grpc/grpc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/grpc/grpc/issues/15384/comments","statuses_url":"https://api.github.com/repos/grpc/grpc/statuses/f02d33cd8e5e74d8f1a31beb62048b46c1138505","head":{"label":"ncteisen:sanity","ref":"sanity","sha":"f02d33cd8e5e74d8f1a31beb62048b46c1138505","user":{"login":"ncteisen","id":6148140,"avatar_url":"https://avatars1.githubusercontent.com/u/6148140?v=4","gravatar_id":"","url":"https://api.github.com/users/ncteisen","html_url":"https://github.com/ncteisen","followers_url":"https://api.github.com/users/ncteisen/followers","following_url":"https://api.github.com/users/ncteisen/following{/other_user}","gists_url":"https://api.github.com/users/ncteisen/gists{/gist_id}","starred_url":"https://api.github.com/users/ncteisen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ncteisen/subscriptions","organizations_url":"https://api.github.com/users/ncteisen/orgs","repos_url":"https://api.github.com/users/ncteisen/repos","events_url":"https://api.github.com/users/ncteisen/events{/privacy}","received_events_url":"https://api.github.com/users/ncteisen/received_events","type":"User","site_admin":false},"repo":{"id":69505172,"name":"grpc","full_name":"ncteisen/grpc","owner":{"login":"ncteisen","id":6148140,"avatar_url":"https://avatars1.githubusercontent.com/u/6148140?v=4","gravatar_id":"","url":"https://api.github.com/users/ncteisen","html_url":"https://github.com/ncteisen","followers_url":"https://api.github.com/users/ncteisen/followers","following_url":"https://api.github.com/users/ncteisen/following{/other_user}","gists_url":"https://api.github.com/users/ncteisen/gists{/gist_id}","starred_url":"https://api.github.com/users/ncteisen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ncteisen/subscriptions","organizations_url":"https://api.github.com/users/ncteisen/orgs","repos_url":"https://api.github.com/users/ncteisen/repos","events_url":"https://api.github.com/users/ncteisen/events{/privacy}","received_events_url":"https://api.github.com/users/ncteisen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ncteisen/grpc","description":"The C based gRPC (C++, Node.js, Python, Ruby, Objective-C, PHP, C#)","fork":true,"url":"https://api.github.com/repos/ncteisen/grpc","forks_url":"https://api.github.com/repos/ncteisen/grpc/forks","keys_url":"https://api.github.com/repos/ncteisen/grpc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ncteisen/grpc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ncteisen/grpc/teams","hooks_url":"https://api.github.com/repos/ncteisen/grpc/hooks","issue_events_url":"https://api.github.com/repos/ncteisen/grpc/issues/events{/number}","events_url":"https://api.github.com/repos/ncteisen/grpc/events","assignees_url":"https://api.github.com/repos/ncteisen/grpc/assignees{/user}","branches_url":"https://api.github.com/repos/ncteisen/grpc/branches{/branch}","tags_url":"https://api.github.com/repos/ncteisen/grpc/tags","blobs_url":"https://api.github.com/repos/ncteisen/grpc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ncteisen/grpc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ncteisen/grpc/git/refs{/sha}","trees_url":"https://api.github.com/repos/ncteisen/grpc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ncteisen/grpc/statuses/{sha}","languages_url":"https://api.github.com/repos/ncteisen/grpc/languages","stargazers_url":"https://api.github.com/repos/ncteisen/grpc/stargazers","contributors_url":"https://api.github.com/repos/ncteisen/grpc/contributors","subscribers_url":"https://api.github.com/repos/ncteisen/grpc/subscribers","subscription_url":"https://api.github.com/repos/ncteisen/grpc/subscription","commits_url":"https://api.github.com/repos/ncteisen/grpc/commits{/sha}","git_commits_url":"https://api.github.com/repos/ncteisen/grpc/git/commits{/sha}","comments_url":"https://api.github.com/repos/ncteisen/grpc/comments{/number}","issue_comment_url":"https://api.github.com/repos/ncteisen/grpc/issues/comments{/number}","contents_url":"https://api.github.com/repos/ncteisen/grpc/contents/{+path}","compare_url":"https://api.github.com/repos/ncteisen/grpc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ncteisen/grpc/merges","archive_url":"https://api.github.com/repos/ncteisen/grpc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ncteisen/grpc/downloads","issues_url":"https://api.github.com/repos/ncteisen/grpc/issues{/number}","pulls_url":"https://api.github.com/repos/ncteisen/grpc/pulls{/number}","milestones_url":"https://api.github.com/repos/ncteisen/grpc/milestones{/number}","notifications_url":"https://api.github.com/repos/ncteisen/grpc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ncteisen/grpc/labels{/name}","releases_url":"https://api.github.com/repos/ncteisen/grpc/releases{/id}","deployments_url":"https://api.github.com/repos/ncteisen/grpc/deployments","created_at":"2016-09-28T21:27:26Z","updated_at":"2018-04-09T14:41:25Z","pushed_at":"2018-05-15T20:55:40Z","git_url":"git://github.com/ncteisen/grpc.git","ssh_url":"[email protected]:ncteisen/grpc.git","clone_url":"https://github.com/ncteisen/grpc.git","svn_url":"https://github.com/ncteisen/grpc","homepage":"","size":160178,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"grpc:master","ref":"master","sha":"7b79130cbf889205dbe1c9f708a1d795fbb9522b","user":{"login":"grpc","id":7802525,"avatar_url":"https://avatars1.githubusercontent.com/u/7802525?v=4","gravatar_id":"","url":"https://api.github.com/users/grpc","html_url":"https://github.com/grpc","followers_url":"https://api.github.com/users/grpc/followers","following_url":"https://api.github.com/users/grpc/following{/other_user}","gists_url":"https://api.github.com/users/grpc/gists{/gist_id}","starred_url":"https://api.github.com/users/grpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grpc/subscriptions","organizations_url":"https://api.github.com/users/grpc/orgs","repos_url":"https://api.github.com/users/grpc/repos","events_url":"https://api.github.com/users/grpc/events{/privacy}","received_events_url":"https://api.github.com/users/grpc/received_events","type":"Organization","site_admin":false},"repo":{"id":27729880,"name":"grpc","full_name":"grpc/grpc","owner":{"login":"grpc","id":7802525,"avatar_url":"https://avatars1.githubusercontent.com/u/7802525?v=4","gravatar_id":"","url":"https://api.github.com/users/grpc","html_url":"https://github.com/grpc","followers_url":"https://api.github.com/users/grpc/followers","following_url":"https://api.github.com/users/grpc/following{/other_user}","gists_url":"https://api.github.com/users/grpc/gists{/gist_id}","starred_url":"https://api.github.com/users/grpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grpc/subscriptions","organizations_url":"https://api.github.com/users/grpc/orgs","repos_url":"https://api.github.com/users/grpc/repos","events_url":"https://api.github.com/users/grpc/events{/privacy}","received_events_url":"https://api.github.com/users/grpc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/grpc/grpc","description":"The C based gRPC (C++, Python, Ruby, Objective-C, PHP, C#)","fork":false,"url":"https://api.github.com/repos/grpc/grpc","forks_url":"https://api.github.com/repos/grpc/grpc/forks","keys_url":"https://api.github.com/repos/grpc/grpc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grpc/grpc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grpc/grpc/teams","hooks_url":"https://api.github.com/repos/grpc/grpc/hooks","issue_events_url":"https://api.github.com/repos/grpc/grpc/issues/events{/number}","events_url":"https://api.github.com/repos/grpc/grpc/events","assignees_url":"https://api.github.com/repos/grpc/grpc/assignees{/user}","branches_url":"https://api.github.com/repos/grpc/grpc/branches{/branch}","tags_url":"https://api.github.com/repos/grpc/grpc/tags","blobs_url":"https://api.github.com/repos/grpc/grpc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grpc/grpc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grpc/grpc/git/refs{/sha}","trees_url":"https://api.github.com/repos/grpc/grpc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grpc/grpc/statuses/{sha}","languages_url":"https://api.github.com/repos/grpc/grpc/languages","stargazers_url":"https://api.github.com/repos/grpc/grpc/stargazers","contributors_url":"https://api.github.com/repos/grpc/grpc/contributors","subscribers_url":"https://api.github.com/repos/grpc/grpc/subscribers","subscription_url":"https://api.github.com/repos/grpc/grpc/subscription","commits_url":"https://api.github.com/repos/grpc/grpc/commits{/sha}","git_commits_url":"https://api.github.com/repos/grpc/grpc/git/commits{/sha}","comments_url":"https://api.github.com/repos/grpc/grpc/comments{/number}","issue_comment_url":"https://api.github.com/repos/grpc/grpc/issues/comments{/number}","contents_url":"https://api.github.com/repos/grpc/grpc/contents/{+path}","compare_url":"https://api.github.com/repos/grpc/grpc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grpc/grpc/merges","archive_url":"https://api.github.com/repos/grpc/grpc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grpc/grpc/downloads","issues_url":"https://api.github.com/repos/grpc/grpc/issues{/number}","pulls_url":"https://api.github.com/repos/grpc/grpc/pulls{/number}","milestones_url":"https://api.github.com/repos/grpc/grpc/milestones{/number}","notifications_url":"https://api.github.com/repos/grpc/grpc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grpc/grpc/labels{/name}","releases_url":"https://api.github.com/repos/grpc/grpc/releases{/id}","deployments_url":"https://api.github.com/repos/grpc/grpc/deployments","created_at":"2014-12-08T18:58:53Z","updated_at":"2018-05-15T20:53:20Z","pushed_at":"2018-05-15T20:55:42Z","git_url":"git://github.com/grpc/grpc.git","ssh_url":"[email protected]:grpc/grpc.git","clone_url":"https://github.com/grpc/grpc.git","svn_url":"https://github.com/grpc/grpc","homepage":"https://grpc.io","size":179123,"stargazers_count":15252,"watchers_count":15252,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":true,"forks_count":3393,"mirror_url":null,"archived":false,"open_issues_count":1251,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":3393,"open_issues":1251,"watchers":15252,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/grpc/grpc/pulls/15384"},"html":{"href":"https://github.com/grpc/grpc/pull/15384"},"issue":{"href":"https://api.github.com/repos/grpc/grpc/issues/15384"},"comments":{"href":"https://api.github.com/repos/grpc/grpc/issues/15384/comments"},"review_comments":{"href":"https://api.github.com/repos/grpc/grpc/pulls/15384/comments"},"review_comment":{"href":"https://api.github.com/repos/grpc/grpc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/grpc/grpc/pulls/15384/commits"},"statuses":{"href":"https://api.github.com/repos/grpc/grpc/statuses/f02d33cd8e5e74d8f1a31beb62048b46c1138505"}},"author_association":"CONTRIBUTOR"}} | {
"id": 27729880,
"name": "grpc/grpc",
"url": "https://api.github.com/repos/grpc/grpc"
} | {
"id": 6148140,
"login": "ncteisen",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6148140?",
"url": "https://api.github.com/users/ncteisen"
} | {
"id": 7802525,
"login": "grpc",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7802525?",
"url": "https://api.github.com/orgs/grpc"
} | 2018-05-15T20:56:15 | 7679482348 | {"actor":{"display_login":"ncteisen"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/grpc/grpc/pulls/comments/194624696","pull_request_review_id":127829789,"id":194624696,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NDYyNDY5Ng==","diff_hunk":"@@ -0,0 +1,198 @@\n+#region Copyright notice and license\n+\n+// Copyright 2018 gRPC authors.\n+//\n+// Licensed under the Apache License, Version 2.0 (the \"License\");\n+// you may not use this file except in compliance with the License.\n+// You may obtain a copy of the License at\n+//\n+// http://www.apache.org/licenses/LICENSE-2.0\n+//\n+// Unless required by applicable law or agreed to in writing, software\n+// distributed under the License is distributed on an \"AS IS\" BASIS,\n+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+// See the License for the specific language governing permissions and\n+// limitations under the License.\n+\n+#endregion\n+\n+using System;\n+using System.Collections.Generic;\n+using System.IO;\n+using System.Text;\n+using Microsoft.Build.Framework;\n+using Microsoft.Build.Utilities;\n+\n+namespace Grpc.Tools {\n+ internal static class DepFileUtil {\n+/*\n+ Sample dependency files. Notable features we have to deal with:\n+ * Slash doubling, must normalize them.\n+ * Spaces in file names. Cannot just \"unwrap\" the line on backslash at eof;\n+ rather, treat every line as containing one file name except for one with\n+ the ':' separator, as containing exactly two.\n+ * Deal with ':' also being drive letter separator (second example).\n+\n+obj\\Release\\net45\\/Foo.cs \\\n+obj\\Release\\net45\\/FooGrpc.cs: C:/foo/include/google/protobuf/wrappers.proto\\\n+ C:/projects/foo/src//foo.proto\n+\n+C:\\projects\\foo\\src\\./foo.grpc.pb.cc \\\n+C:\\projects\\foo\\src\\./foo.grpc.pb.h \\\n+C:\\projects\\foo\\src\\./foo.pb.cc \\\n+C:\\projects\\foo\\src\\./foo.pb.h: C:/foo/include/google/protobuf/wrappers.proto\\\n+ C:/foo/include/google/protobuf/any.proto\\\n+ C:/foo/include/google/protobuf/source_context.proto\\\n+ C:/foo/include/google/protobuf/type.proto\\\n+ foo.proto\n+*/\n+\n+ // Read file names from the dependency file to the right of ':'.\n+ public static string[] ReadDependencyInputs(string protoDepDir, string proto,\n+ TaskLoggingHelper log) {\n+ string depFilename = GetDepFilenameForProto(protoDepDir, proto);\n+ string[] lines = ReadDepFileLines(depFilename, false, log);\n+ if (lines.Length == 0) {\n+ return lines;\n+ }\n+\n+ var result = new List<string>();\n+ bool skip = true;\n+ foreach (string line in lines) {\n+ // Start at the only line separating dependency outputs from inputs.\n+ int ix = skip ? FindLineSeparator(line) : -1;\n+ skip = skip && ix < 0;\n+ if (skip) continue;\n+ string file = ExtractFilenameFromLine(line, ix + 1, line.Length);\n+ if (file == \"\") {\n+ log.LogMessage(MessageImportance.Low,\n+ $\"Skipping unparsable dependency file {depFilename}.\\nLine with error: '{line}'\");\n+ return new string[0];\n+ }\n+\n+ // Do not bend over backwards trying not to include a proto into its\n+ // own list of dependencies. Since a file is not older than self,\n+ // it is safe to add; this is purely a memory optimization.\n+ if (file != proto) {\n+ result.Add(file);\n+ }\n+ }\n+ return result.ToArray();\n+ }\n+\n+ // Read file names from the dependency file to the left of ':'.\n+ public static string[] ReadDependencyOutputs(string depFilename,\n+ TaskLoggingHelper log) {\n+ string[] lines = ReadDepFileLines(depFilename, true, log);\n+ if (lines.Length == 0) {\n+ return lines;\n+ }\n+\n+ var result = new List<string>();\n+ foreach (string line in lines) {\n+ int ix = FindLineSeparator(line);\n+ string file = ExtractFilenameFromLine(line, 0, ix >= 0 ? ix : line.Length);\n+ if (file == \"\") {\n+ log.LogError(\"Unable to parse generated dependency file {0}.\\n\" +\n+ \"Line with error: '{1}'\", depFilename, line);\n+ return new string[0];\n+ }\n+ result.Add(file);\n+\n+ // If this is the line with the separator, do not read further.\n+ if (ix >= 0)\n+ break;\n+ }\n+ return result.ToArray();\n+ }\n+\n+ // Get complete dependency file name from directory hash and file name,\n+ // tucked onto protoDepDir, e. g.\n+ // (\"out\", \"foo/file.proto\") => \"out/deadbeef12345678_file.protodep\".\n+ // This way, the filenames are unique but still possible to make sense of.\n+ public static string GetDepFilenameForProto(string protoDepDir, string proto) {","path":"src/csharp/Grpc.Tools/DepFileUtil.cs","position":113,"original_position":113,"commit_id":"35f14e24eb8f396e30675844f4b0c7f13cde52c6","original_commit_id":"35f14e24eb8f396e30675844f4b0c7f13cde52c6","user":{"login":"kkm000","id":8228229,"node_id":"MDQ6VXNlcjgyMjgyMjk=","avatar_url":"https://avatars3.githubusercontent.com/u/8228229?v=4","gravatar_id":"","url":"https://api.github.com/users/kkm000","html_url":"https://github.com/kkm000","followers_url":"https://api.github.com/users/kkm000/followers","following_url":"https://api.github.com/users/kkm000/following{/other_user}","gists_url":"https://api.github.com/users/kkm000/gists{/gist_id}","starred_url":"https://api.github.com/users/kkm000/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kkm000/subscriptions","organizations_url":"https://api.github.com/users/kkm000/orgs","repos_url":"https://api.github.com/users/kkm000/repos","events_url":"https://api.github.com/users/kkm000/events{/privacy}","received_events_url":"https://api.github.com/users/kkm000/received_events","type":"User","site_admin":false},"body":"I am adding this commentary, and I think it makes sense to reproduce here as I tried to explain it as well as I could:\r\n> Since a project may contain proto files with the same filename but in different\r\n> directories, a unique filename for the dependency file is constructed based on the\r\n> proto file name both name and directory. The directory path can be arbitrary,\r\n> for example, it can be outside of the project, or an absolute path including\r\n> a drive letter, or a UNC network path. A name constructed from such a path by,\r\n> for example, replacing disallowed name characters with an underscore, may well\r\n> be over filesystem's allowed path length, since it will be located under the\r\n> project and solution directories, which are also some level deep from the root.\r\n> Instead of creating long and unwieldy names for these proto sources, we cache\r\n> the full path of the name without the filename, and append the filename to it,\r\n> as in e. g. \"foo/file.proto\" will yield the name \"deadbeef12345678_file\", where\r\n> \"deadbeef12345678\" is a presumed hash value of the string \"foo/\". This allows\r\n> the file names be short, unique (up to a hash collision), and still allowing\r\n> the user to guess their provenance.\r\n\r\nIn other words, I need to encode distinct dependency file names of `foo.proto`, `sub1/sub2/foo.proto`, `../../../../protofiles/helloworld/hello.proto` and `\\\\server.company.local\\fs\\shared\\packages\\protofiles\\helloword\\hello.proto`. I do not want to end up with names like `__server.company.local_fs_shared_packages_protofiles_helloword_hello.protodep` because they may be arbitrarily long and just would not fit into filesystem's path length restriction when placed under `C:\\users\\firstname.lastname.OURDOMAIN\\Documents\\Visual Studio 2017\\myprojects\\SmartAction.SomethingLong.SomethingEvenLonger\\SmartAction.SomethingLong.SomethingEvenLonger.Client\\obj`. This is quite common for the last 3 path components to be like this, and may be not so rare for the rest of this not exactly very contrived path name; I have had real problems exactly like this (and my project directory is `c:\\projects`, not the least *because* of this :) ). Also, they are ugly and no less clash-prone than 64-bit hashes.\r\n","created_at":"2018-06-12T06:17:03Z","updated_at":"2018-06-12T06:17:04Z","html_url":"https://github.com/grpc/grpc/pull/13207#discussion_r194624696","pull_request_url":"https://api.github.com/repos/grpc/grpc/pulls/13207","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/grpc/grpc/pulls/comments/194624696"},"html":{"href":"https://github.com/grpc/grpc/pull/13207#discussion_r194624696"},"pull_request":{"href":"https://api.github.com/repos/grpc/grpc/pulls/13207"}},"in_reply_to_id":179395018},"pull_request":{"url":"https://api.github.com/repos/grpc/grpc/pulls/13207","id":149947745,"node_id":"MDExOlB1bGxSZXF1ZXN0MTQ5OTQ3NzQ1","html_url":"https://github.com/grpc/grpc/pull/13207","diff_url":"https://github.com/grpc/grpc/pull/13207.diff","patch_url":"https://github.com/grpc/grpc/pull/13207.patch","issue_url":"https://api.github.com/repos/grpc/grpc/issues/13207","number":13207,"state":"open","locked":false,"title":"Integrate Grpc.Tools into msbuild system (C# only)","user":{"login":"kkm000","id":8228229,"node_id":"MDQ6VXNlcjgyMjgyMjk=","avatar_url":"https://avatars3.githubusercontent.com/u/8228229?v=4","gravatar_id":"","url":"https://api.github.com/users/kkm000","html_url":"https://github.com/kkm000","followers_url":"https://api.github.com/users/kkm000/followers","following_url":"https://api.github.com/users/kkm000/following{/other_user}","gists_url":"https://api.github.com/users/kkm000/gists{/gist_id}","starred_url":"https://api.github.com/users/kkm000/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kkm000/subscriptions","organizations_url":"https://api.github.com/users/kkm000/orgs","repos_url":"https://api.github.com/users/kkm000/repos","events_url":"https://api.github.com/users/kkm000/events{/privacy}","received_events_url":"https://api.github.com/users/kkm000/received_events","type":"User","site_admin":false},"body":"When Grpc.Tools is added to a C# project, the project recognizes .proto files. These .proto are compiled into .cs files placed in the object directory (under obj/...), and are not shown in Visual Studio, but are available to Intellisense nevertheless.\r\n\r\nThe scripts support both \"classic\" projects and the new dotnet style projects. In line with the latter ones (when .cs files are just dropped into the directory are picked up and compiled), .proto files are handled the same way, so just placing a .proto file into the folder is enough to compile it, and compile its protoc outputs into the project target assembly.\r\n\r\nThe \"classic\" project requires adding .proto files by one, and they are assigned a correct build action automatically. To manually add proto files to msbuild script, use 'ProtoBuf' item type.\r\n\r\nFor native code C++ projects, there is no added support beyond just dropping the compiler as before. For all other project types, an error message is generated on an attempted build. More C++ support is on the way.\r\n\r\nDependency change: the package now adds a dependency on Grpc.Tools of a matching version for managed projects only. This is naturally skipped for native C++, as the managed runtime is not required.\r\n\r\nAlso packaged are proto includes for well-known types.\r\n\r\n----\r\nValidated and confirmed working:\r\n * Windows (VS, classic C#, dotnet C#, C++)\r\n * Linux/Mono (both classic C# and dotnet C#)\r\n * Linux/dotnet (dotnet C# project only)\r\n----\r\nThere are quite a few questions I wanted to discuss. If anyone could help me with proper decicions, I would appreciate it.\r\n\r\n1. The captialization of generated .cs files. When I compile `fooBar.proto`, the resulting .cs file is called `FooBar.proto`. Is there a way around that? This does not seem to make sense in the build like this, when the .cs files are treated at best as temporary. I can certainly script around the issue in msbuild scripts, but why have it in the first place?\r\n\r\n2. If `x.proto` does not contain any RPC services. the corresponding `xGrpc.cs` is not generated (FWIW, the cpp plugin does not do that). This is not good for the build. While it is certainly possible to see if the file *is* there after compilation, it is impossible to learn if it was *actually* produced by it. In other words, if I take a service definition out of x.proto after having previously compiled it, I end up with a stale `xGrpc.cs` that is added to compilation. Of course, it is possible to write some msbuild incantations about this issue as well, but it would be much cleaner just to create a nearly empty xGrpc.cs stub even if no services are defined. So options I am asking about here are \r\n - a) Leave it as is and script some very ugly transformations around it.\r\n - b) Add a plugin option to do always generate the stub.\r\n - c) In fact, forget the option and just always generate the stub.\r\n\r\n3. I want to package cpp plugins also, and support to integrate gRPC into the build process. (I already have it packaged internally). This will cover the build process in Visual Studio. Should we do that?\r\n\r\n4. I am adding a bunch of files to the root of `src/chsarp` that only go into the nuget package. Is it better to place them into a subdirectory? Is `Grpc.Tools` subdirectory good?\r\n\r\n----\r\n/cc @jskeet @hcoona \r\nCloses #4805 \r\nCloses #13098\r\n","created_at":"2017-11-01T02:16:04Z","updated_at":"2018-06-12T06:17:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b8926330dcb69bc74b664e0a23f8b8ad37216b8d","assignee":{"login":"jtattermusch","id":9939684,"node_id":"MDQ6VXNlcjk5Mzk2ODQ=","avatar_url":"https://avatars1.githubusercontent.com/u/9939684?v=4","gravatar_id":"","url":"https://api.github.com/users/jtattermusch","html_url":"https://github.com/jtattermusch","followers_url":"https://api.github.com/users/jtattermusch/followers","following_url":"https://api.github.com/users/jtattermusch/following{/other_user}","gists_url":"https://api.github.com/users/jtattermusch/gists{/gist_id}","starred_url":"https://api.github.com/users/jtattermusch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jtattermusch/subscriptions","organizations_url":"https://api.github.com/users/jtattermusch/orgs","repos_url":"https://api.github.com/users/jtattermusch/repos","events_url":"https://api.github.com/users/jtattermusch/events{/privacy}","received_events_url":"https://api.github.com/users/jtattermusch/received_events","type":"User","site_admin":false},"assignees":[{"login":"jtattermusch","id":9939684,"node_id":"MDQ6VXNlcjk5Mzk2ODQ=","avatar_url":"https://avatars1.githubusercontent.com/u/9939684?v=4","gravatar_id":"","url":"https://api.github.com/users/jtattermusch","html_url":"https://github.com/jtattermusch","followers_url":"https://api.github.com/users/jtattermusch/followers","following_url":"https://api.github.com/users/jtattermusch/following{/other_user}","gists_url":"https://api.github.com/users/jtattermusch/gists{/gist_id}","starred_url":"https://api.github.com/users/jtattermusch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jtattermusch/subscriptions","organizations_url":"https://api.github.com/users/jtattermusch/orgs","repos_url":"https://api.github.com/users/jtattermusch/repos","events_url":"https://api.github.com/users/jtattermusch/events{/privacy}","received_events_url":"https://api.github.com/users/jtattermusch/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":170781264,"node_id":"MDU6TGFiZWwxNzA3ODEyNjQ=","url":"https://api.github.com/repos/grpc/grpc/labels/cla:%20yes","name":"cla: yes","color":"009800","default":false},{"id":168238370,"node_id":"MDU6TGFiZWwxNjgyMzgzNzA=","url":"https://api.github.com/repos/grpc/grpc/labels/lang/C%23","name":"lang/C#","color":"fad8c7","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/grpc/grpc/pulls/13207/commits","review_comments_url":"https://api.github.com/repos/grpc/grpc/pulls/13207/comments","review_comment_url":"https://api.github.com/repos/grpc/grpc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/grpc/grpc/issues/13207/comments","statuses_url":"https://api.github.com/repos/grpc/grpc/statuses/35f14e24eb8f396e30675844f4b0c7f13cde52c6","head":{"label":"kkm000:package-grpc-tools","ref":"package-grpc-tools","sha":"35f14e24eb8f396e30675844f4b0c7f13cde52c6","user":{"login":"kkm000","id":8228229,"node_id":"MDQ6VXNlcjgyMjgyMjk=","avatar_url":"https://avatars3.githubusercontent.com/u/8228229?v=4","gravatar_id":"","url":"https://api.github.com/users/kkm000","html_url":"https://github.com/kkm000","followers_url":"https://api.github.com/users/kkm000/followers","following_url":"https://api.github.com/users/kkm000/following{/other_user}","gists_url":"https://api.github.com/users/kkm000/gists{/gist_id}","starred_url":"https://api.github.com/users/kkm000/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kkm000/subscriptions","organizations_url":"https://api.github.com/users/kkm000/orgs","repos_url":"https://api.github.com/users/kkm000/repos","events_url":"https://api.github.com/users/kkm000/events{/privacy}","received_events_url":"https://api.github.com/users/kkm000/received_events","type":"User","site_admin":false},"repo":{"id":56646296,"node_id":"MDEwOlJlcG9zaXRvcnk1NjY0NjI5Ng==","name":"grpc","full_name":"kkm000/grpc","owner":{"login":"kkm000","id":8228229,"node_id":"MDQ6VXNlcjgyMjgyMjk=","avatar_url":"https://avatars3.githubusercontent.com/u/8228229?v=4","gravatar_id":"","url":"https://api.github.com/users/kkm000","html_url":"https://github.com/kkm000","followers_url":"https://api.github.com/users/kkm000/followers","following_url":"https://api.github.com/users/kkm000/following{/other_user}","gists_url":"https://api.github.com/users/kkm000/gists{/gist_id}","starred_url":"https://api.github.com/users/kkm000/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kkm000/subscriptions","organizations_url":"https://api.github.com/users/kkm000/orgs","repos_url":"https://api.github.com/users/kkm000/repos","events_url":"https://api.github.com/users/kkm000/events{/privacy}","received_events_url":"https://api.github.com/users/kkm000/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kkm000/grpc","description":"My private working copy of gRPC code, do not use. Click here for the original:","fork":true,"url":"https://api.github.com/repos/kkm000/grpc","forks_url":"https://api.github.com/repos/kkm000/grpc/forks","keys_url":"https://api.github.com/repos/kkm000/grpc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kkm000/grpc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kkm000/grpc/teams","hooks_url":"https://api.github.com/repos/kkm000/grpc/hooks","issue_events_url":"https://api.github.com/repos/kkm000/grpc/issues/events{/number}","events_url":"https://api.github.com/repos/kkm000/grpc/events","assignees_url":"https://api.github.com/repos/kkm000/grpc/assignees{/user}","branches_url":"https://api.github.com/repos/kkm000/grpc/branches{/branch}","tags_url":"https://api.github.com/repos/kkm000/grpc/tags","blobs_url":"https://api.github.com/repos/kkm000/grpc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kkm000/grpc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kkm000/grpc/git/refs{/sha}","trees_url":"https://api.github.com/repos/kkm000/grpc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kkm000/grpc/statuses/{sha}","languages_url":"https://api.github.com/repos/kkm000/grpc/languages","stargazers_url":"https://api.github.com/repos/kkm000/grpc/stargazers","contributors_url":"https://api.github.com/repos/kkm000/grpc/contributors","subscribers_url":"https://api.github.com/repos/kkm000/grpc/subscribers","subscription_url":"https://api.github.com/repos/kkm000/grpc/subscription","commits_url":"https://api.github.com/repos/kkm000/grpc/commits{/sha}","git_commits_url":"https://api.github.com/repos/kkm000/grpc/git/commits{/sha}","comments_url":"https://api.github.com/repos/kkm000/grpc/comments{/number}","issue_comment_url":"https://api.github.com/repos/kkm000/grpc/issues/comments{/number}","contents_url":"https://api.github.com/repos/kkm000/grpc/contents/{+path}","compare_url":"https://api.github.com/repos/kkm000/grpc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kkm000/grpc/merges","archive_url":"https://api.github.com/repos/kkm000/grpc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kkm000/grpc/downloads","issues_url":"https://api.github.com/repos/kkm000/grpc/issues{/number}","pulls_url":"https://api.github.com/repos/kkm000/grpc/pulls{/number}","milestones_url":"https://api.github.com/repos/kkm000/grpc/milestones{/number}","notifications_url":"https://api.github.com/repos/kkm000/grpc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kkm000/grpc/labels{/name}","releases_url":"https://api.github.com/repos/kkm000/grpc/releases{/id}","deployments_url":"https://api.github.com/repos/kkm000/grpc/deployments","created_at":"2016-04-20T01:46:39Z","updated_at":"2018-02-07T06:07:26Z","pushed_at":"2018-03-13T03:41:59Z","git_url":"git://github.com/kkm000/grpc.git","ssh_url":"[email protected]:kkm000/grpc.git","clone_url":"https://github.com/kkm000/grpc.git","svn_url":"https://github.com/kkm000/grpc","homepage":"https://github.com/grpc/grpc","size":152068,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":false,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"grpc:master","ref":"master","sha":"44fd6557aefad4689eac7225386aecefd1f9a5bc","user":{"login":"grpc","id":7802525,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc4MDI1MjU=","avatar_url":"https://avatars1.githubusercontent.com/u/7802525?v=4","gravatar_id":"","url":"https://api.github.com/users/grpc","html_url":"https://github.com/grpc","followers_url":"https://api.github.com/users/grpc/followers","following_url":"https://api.github.com/users/grpc/following{/other_user}","gists_url":"https://api.github.com/users/grpc/gists{/gist_id}","starred_url":"https://api.github.com/users/grpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grpc/subscriptions","organizations_url":"https://api.github.com/users/grpc/orgs","repos_url":"https://api.github.com/users/grpc/repos","events_url":"https://api.github.com/users/grpc/events{/privacy}","received_events_url":"https://api.github.com/users/grpc/received_events","type":"Organization","site_admin":false},"repo":{"id":27729880,"node_id":"MDEwOlJlcG9zaXRvcnkyNzcyOTg4MA==","name":"grpc","full_name":"grpc/grpc","owner":{"login":"grpc","id":7802525,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc4MDI1MjU=","avatar_url":"https://avatars1.githubusercontent.com/u/7802525?v=4","gravatar_id":"","url":"https://api.github.com/users/grpc","html_url":"https://github.com/grpc","followers_url":"https://api.github.com/users/grpc/followers","following_url":"https://api.github.com/users/grpc/following{/other_user}","gists_url":"https://api.github.com/users/grpc/gists{/gist_id}","starred_url":"https://api.github.com/users/grpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grpc/subscriptions","organizations_url":"https://api.github.com/users/grpc/orgs","repos_url":"https://api.github.com/users/grpc/repos","events_url":"https://api.github.com/users/grpc/events{/privacy}","received_events_url":"https://api.github.com/users/grpc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/grpc/grpc","description":"The C based gRPC (C++, Python, Ruby, Objective-C, PHP, C#)","fork":false,"url":"https://api.github.com/repos/grpc/grpc","forks_url":"https://api.github.com/repos/grpc/grpc/forks","keys_url":"https://api.github.com/repos/grpc/grpc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grpc/grpc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grpc/grpc/teams","hooks_url":"https://api.github.com/repos/grpc/grpc/hooks","issue_events_url":"https://api.github.com/repos/grpc/grpc/issues/events{/number}","events_url":"https://api.github.com/repos/grpc/grpc/events","assignees_url":"https://api.github.com/repos/grpc/grpc/assignees{/user}","branches_url":"https://api.github.com/repos/grpc/grpc/branches{/branch}","tags_url":"https://api.github.com/repos/grpc/grpc/tags","blobs_url":"https://api.github.com/repos/grpc/grpc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grpc/grpc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grpc/grpc/git/refs{/sha}","trees_url":"https://api.github.com/repos/grpc/grpc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grpc/grpc/statuses/{sha}","languages_url":"https://api.github.com/repos/grpc/grpc/languages","stargazers_url":"https://api.github.com/repos/grpc/grpc/stargazers","contributors_url":"https://api.github.com/repos/grpc/grpc/contributors","subscribers_url":"https://api.github.com/repos/grpc/grpc/subscribers","subscription_url":"https://api.github.com/repos/grpc/grpc/subscription","commits_url":"https://api.github.com/repos/grpc/grpc/commits{/sha}","git_commits_url":"https://api.github.com/repos/grpc/grpc/git/commits{/sha}","comments_url":"https://api.github.com/repos/grpc/grpc/comments{/number}","issue_comment_url":"https://api.github.com/repos/grpc/grpc/issues/comments{/number}","contents_url":"https://api.github.com/repos/grpc/grpc/contents/{+path}","compare_url":"https://api.github.com/repos/grpc/grpc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grpc/grpc/merges","archive_url":"https://api.github.com/repos/grpc/grpc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grpc/grpc/downloads","issues_url":"https://api.github.com/repos/grpc/grpc/issues{/number}","pulls_url":"https://api.github.com/repos/grpc/grpc/pulls{/number}","milestones_url":"https://api.github.com/repos/grpc/grpc/milestones{/number}","notifications_url":"https://api.github.com/repos/grpc/grpc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grpc/grpc/labels{/name}","releases_url":"https://api.github.com/repos/grpc/grpc/releases{/id}","deployments_url":"https://api.github.com/repos/grpc/grpc/deployments","created_at":"2014-12-08T18:58:53Z","updated_at":"2018-06-12T03:27:26Z","pushed_at":"2018-06-12T05:49:43Z","git_url":"git://github.com/grpc/grpc.git","ssh_url":"[email protected]:grpc/grpc.git","clone_url":"https://github.com/grpc/grpc.git","svn_url":"https://github.com/grpc/grpc","homepage":"https://grpc.io","size":184086,"stargazers_count":15725,"watchers_count":15725,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":true,"forks_count":3502,"mirror_url":null,"archived":false,"open_issues_count":967,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":3502,"open_issues":967,"watchers":15725,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/grpc/grpc/pulls/13207"},"html":{"href":"https://github.com/grpc/grpc/pull/13207"},"issue":{"href":"https://api.github.com/repos/grpc/grpc/issues/13207"},"comments":{"href":"https://api.github.com/repos/grpc/grpc/issues/13207/comments"},"review_comments":{"href":"https://api.github.com/repos/grpc/grpc/pulls/13207/comments"},"review_comment":{"href":"https://api.github.com/repos/grpc/grpc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/grpc/grpc/pulls/13207/commits"},"statuses":{"href":"https://api.github.com/repos/grpc/grpc/statuses/35f14e24eb8f396e30675844f4b0c7f13cde52c6"}},"author_association":"CONTRIBUTOR"}} | {
"id": 27729880,
"name": "grpc/grpc",
"url": "https://api.github.com/repos/grpc/grpc"
} | {
"id": 8228229,
"login": "kkm000",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/8228229?",
"url": "https://api.github.com/users/kkm000"
} | {
"id": 7802525,
"login": "grpc",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7802525?",
"url": "https://api.github.com/orgs/grpc"
} | 2018-06-12T06:17:03 | 7810333981 | {"actor":{"display_login":"kkm000"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/grpc/grpc/pulls/comments/237153924","pull_request_review_id":179382521,"id":237153924,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNzE1MzkyNA==","diff_hunk":"@@ -0,0 +1,114 @@\n+# Copyright 2018 The gRPC Authors\n+#\n+# Licensed under the Apache License, Version 2.0 (the \"License\");\n+# you may not use this file except in compliance with the License.\n+# You may obtain a copy of the License at\n+#\n+# http://www.apache.org/licenses/LICENSE-2.0\n+#\n+# Unless required by applicable law or agreed to in writing, software\n+# distributed under the License is distributed on an \"AS IS\" BASIS,\n+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+# See the License for the specific language governing permissions and\n+# limitations under the License.\n+\"\"\"Channelz debug service implementation in gRPC Python.\"\"\"\n+\n+import grpc\n+from grpc._cython import cygrpc\n+\n+import grpc_channelz.v1.channelz_pb2 as _channelz_pb2\n+import grpc_channelz.v1.channelz_pb2_grpc as _channelz_pb2_grpc\n+\n+from google.protobuf import json_format\n+\n+\n+class ChannelzServicer(_channelz_pb2_grpc.ChannelzServicer):\n+ \"\"\"Servicer handling RPCs for service statuses.\"\"\"\n+\n+ # pylint: disable=no-self-use\n+ def GetTopChannels(self, request, context):\n+ try:\n+ return json_format.Parse(\n+ cygrpc.channelz_get_top_channels(request.start_channel_id),\n+ _channelz_pb2.GetTopChannelsResponse(),\n+ )\n+ except ValueError as e:\n+ context.set_code(grpc.StatusCode.INVALID_ARGUMENT)\n+ context.set_details(str(e))\n+\n+ # pylint: disable=no-self-use\n+ def GetServers(self, request, context):\n+ try:\n+ return json_format.Parse(\n+ cygrpc.channelz_get_servers(request.start_server_id),\n+ _channelz_pb2.GetServersResponse(),\n+ )\n+ except ValueError as e:\n+ context.set_code(grpc.StatusCode.INVALID_ARGUMENT)\n+ context.set_details(str(e))\n+\n+ # pylint: disable=no-self-use\n+ def GetServer(self, request, context):\n+ try:\n+ return json_format.Parse(\n+ cygrpc.channelz_get_server(request.server_id),\n+ _channelz_pb2.GetServerResponse(),\n+ )\n+ except ValueError as e:\n+ context.set_code(grpc.StatusCode.INVALID_ARGUMENT)\n+ context.set_details(str(e))\n+\n+ # pylint: disable=no-self-use\n+ def GetServerSockets(self, request, context):\n+ try:\n+ return json_format.Parse(\n+ cygrpc.channelz_get_server_sockets(request.server_id,\n+ request.start_socket_id),\n+ _channelz_pb2.GetServerSocketsResponse(),\n+ )\n+ except ValueError as e:\n+ context.set_code(grpc.StatusCode.INVALID_ARGUMENT)","path":"src/python/grpcio_channelz/grpc_channelz/v1/channelz.py","position":70,"original_position":70,"commit_id":"43599facf4c8b42b8a14d0601556f4231d9d10f8","original_commit_id":"43599facf4c8b42b8a14d0601556f4231d9d10f8","user":{"login":"ncteisen","id":6148140,"node_id":"MDQ6VXNlcjYxNDgxNDA=","avatar_url":"https://avatars1.githubusercontent.com/u/6148140?v=4","gravatar_id":"","url":"https://api.github.com/users/ncteisen","html_url":"https://github.com/ncteisen","followers_url":"https://api.github.com/users/ncteisen/followers","following_url":"https://api.github.com/users/ncteisen/following{/other_user}","gists_url":"https://api.github.com/users/ncteisen/gists{/gist_id}","starred_url":"https://api.github.com/users/ncteisen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ncteisen/subscriptions","organizations_url":"https://api.github.com/users/ncteisen/orgs","repos_url":"https://api.github.com/users/ncteisen/repos","events_url":"https://api.github.com/users/ncteisen/events{/privacy}","received_events_url":"https://api.github.com/users/ncteisen/received_events","type":"User","site_admin":false},"body":"NOT_FOUND","created_at":"2018-11-28T16:14:13Z","updated_at":"2018-11-28T16:20:56Z","html_url":"https://github.com/grpc/grpc/pull/17266#discussion_r237153924","pull_request_url":"https://api.github.com/repos/grpc/grpc/pulls/17266","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/grpc/grpc/pulls/comments/237153924"},"html":{"href":"https://github.com/grpc/grpc/pull/17266#discussion_r237153924"},"pull_request":{"href":"https://api.github.com/repos/grpc/grpc/pulls/17266"}}},"pull_request":{"url":"https://api.github.com/repos/grpc/grpc/pulls/17266","id":232509825,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMyNTA5ODI1","html_url":"https://github.com/grpc/grpc/pull/17266","diff_url":"https://github.com/grpc/grpc/pull/17266.diff","patch_url":"https://github.com/grpc/grpc/pull/17266.patch","issue_url":"https://api.github.com/repos/grpc/grpc/issues/17266","number":17266,"state":"open","locked":false,"title":"Channelz Python wrapper implementation","user":{"login":"lidizheng","id":7394928,"node_id":"MDQ6VXNlcjczOTQ5Mjg=","avatar_url":"https://avatars3.githubusercontent.com/u/7394928?v=4","gravatar_id":"","url":"https://api.github.com/users/lidizheng","html_url":"https://github.com/lidizheng","followers_url":"https://api.github.com/users/lidizheng/followers","following_url":"https://api.github.com/users/lidizheng/following{/other_user}","gists_url":"https://api.github.com/users/lidizheng/gists{/gist_id}","starred_url":"https://api.github.com/users/lidizheng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lidizheng/subscriptions","organizations_url":"https://api.github.com/users/lidizheng/orgs","repos_url":"https://api.github.com/users/lidizheng/repos","events_url":"https://api.github.com/users/lidizheng/events{/privacy}","received_events_url":"https://api.github.com/users/lidizheng/received_events","type":"User","site_admin":false},"body":"See Issue https://github.com/grpc/grpc/issues/17264\r\n* Expose the C-Core API in Cython layer\r\n* Handle the object translation\r\n* Create a separate package for Channelz specifically\r\n* Adding utilities for the new package","created_at":"2018-11-21T01:18:54Z","updated_at":"2018-11-28T16:20:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"db19c138428478917f4998ec5aca6cf6bc8b6cf0","assignee":{"login":"gnossen","id":1644595,"node_id":"MDQ6VXNlcjE2NDQ1OTU=","avatar_url":"https://avatars1.githubusercontent.com/u/1644595?v=4","gravatar_id":"","url":"https://api.github.com/users/gnossen","html_url":"https://github.com/gnossen","followers_url":"https://api.github.com/users/gnossen/followers","following_url":"https://api.github.com/users/gnossen/following{/other_user}","gists_url":"https://api.github.com/users/gnossen/gists{/gist_id}","starred_url":"https://api.github.com/users/gnossen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gnossen/subscriptions","organizations_url":"https://api.github.com/users/gnossen/orgs","repos_url":"https://api.github.com/users/gnossen/repos","events_url":"https://api.github.com/users/gnossen/events{/privacy}","received_events_url":"https://api.github.com/users/gnossen/received_events","type":"User","site_admin":false},"assignees":[{"login":"gnossen","id":1644595,"node_id":"MDQ6VXNlcjE2NDQ1OTU=","avatar_url":"https://avatars1.githubusercontent.com/u/1644595?v=4","gravatar_id":"","url":"https://api.github.com/users/gnossen","html_url":"https://github.com/gnossen","followers_url":"https://api.github.com/users/gnossen/followers","following_url":"https://api.github.com/users/gnossen/following{/other_user}","gists_url":"https://api.github.com/users/gnossen/gists{/gist_id}","starred_url":"https://api.github.com/users/gnossen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gnossen/subscriptions","organizations_url":"https://api.github.com/users/gnossen/orgs","repos_url":"https://api.github.com/users/gnossen/repos","events_url":"https://api.github.com/users/gnossen/events{/privacy}","received_events_url":"https://api.github.com/users/gnossen/received_events","type":"User","site_admin":false},{"login":"ericgribkoff","id":5067076,"node_id":"MDQ6VXNlcjUwNjcwNzY=","avatar_url":"https://avatars2.githubusercontent.com/u/5067076?v=4","gravatar_id":"","url":"https://api.github.com/users/ericgribkoff","html_url":"https://github.com/ericgribkoff","followers_url":"https://api.github.com/users/ericgribkoff/followers","following_url":"https://api.github.com/users/ericgribkoff/following{/other_user}","gists_url":"https://api.github.com/users/ericgribkoff/gists{/gist_id}","starred_url":"https://api.github.com/users/ericgribkoff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericgribkoff/subscriptions","organizations_url":"https://api.github.com/users/ericgribkoff/orgs","repos_url":"https://api.github.com/users/ericgribkoff/repos","events_url":"https://api.github.com/users/ericgribkoff/events{/privacy}","received_events_url":"https://api.github.com/users/ericgribkoff/received_events","type":"User","site_admin":false},{"login":"lidizheng","id":7394928,"node_id":"MDQ6VXNlcjczOTQ5Mjg=","avatar_url":"https://avatars3.githubusercontent.com/u/7394928?v=4","gravatar_id":"","url":"https://api.github.com/users/lidizheng","html_url":"https://github.com/lidizheng","followers_url":"https://api.github.com/users/lidizheng/followers","following_url":"https://api.github.com/users/lidizheng/following{/other_user}","gists_url":"https://api.github.com/users/lidizheng/gists{/gist_id}","starred_url":"https://api.github.com/users/lidizheng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lidizheng/subscriptions","organizations_url":"https://api.github.com/users/lidizheng/orgs","repos_url":"https://api.github.com/users/lidizheng/repos","events_url":"https://api.github.com/users/lidizheng/events{/privacy}","received_events_url":"https://api.github.com/users/lidizheng/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"gnossen","id":1644595,"node_id":"MDQ6VXNlcjE2NDQ1OTU=","avatar_url":"https://avatars1.githubusercontent.com/u/1644595?v=4","gravatar_id":"","url":"https://api.github.com/users/gnossen","html_url":"https://github.com/gnossen","followers_url":"https://api.github.com/users/gnossen/followers","following_url":"https://api.github.com/users/gnossen/following{/other_user}","gists_url":"https://api.github.com/users/gnossen/gists{/gist_id}","starred_url":"https://api.github.com/users/gnossen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gnossen/subscriptions","organizations_url":"https://api.github.com/users/gnossen/orgs","repos_url":"https://api.github.com/users/gnossen/repos","events_url":"https://api.github.com/users/gnossen/events{/privacy}","received_events_url":"https://api.github.com/users/gnossen/received_events","type":"User","site_admin":false},{"login":"ericgribkoff","id":5067076,"node_id":"MDQ6VXNlcjUwNjcwNzY=","avatar_url":"https://avatars2.githubusercontent.com/u/5067076?v=4","gravatar_id":"","url":"https://api.github.com/users/ericgribkoff","html_url":"https://github.com/ericgribkoff","followers_url":"https://api.github.com/users/ericgribkoff/followers","following_url":"https://api.github.com/users/ericgribkoff/following{/other_user}","gists_url":"https://api.github.com/users/ericgribkoff/gists{/gist_id}","starred_url":"https://api.github.com/users/ericgribkoff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericgribkoff/subscriptions","organizations_url":"https://api.github.com/users/ericgribkoff/orgs","repos_url":"https://api.github.com/users/ericgribkoff/repos","events_url":"https://api.github.com/users/ericgribkoff/events{/privacy}","received_events_url":"https://api.github.com/users/ericgribkoff/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":155504844,"node_id":"MDU6TGFiZWwxNTU1MDQ4NDQ=","url":"https://api.github.com/repos/grpc/grpc/labels/kind/enhancement","name":"kind/enhancement","color":"93732c","default":false},{"id":168238186,"node_id":"MDU6TGFiZWwxNjgyMzgxODY=","url":"https://api.github.com/repos/grpc/grpc/labels/lang/Python","name":"lang/Python","color":"fad8c7","default":false},{"id":961831639,"node_id":"MDU6TGFiZWw5NjE4MzE2Mzk=","url":"https://api.github.com/repos/grpc/grpc/labels/release%20notes:%20yes","name":"release notes: yes","color":"5319e7","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/grpc/grpc/pulls/17266/commits","review_comments_url":"https://api.github.com/repos/grpc/grpc/pulls/17266/comments","review_comment_url":"https://api.github.com/repos/grpc/grpc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/grpc/grpc/issues/17266/comments","statuses_url":"https://api.github.com/repos/grpc/grpc/statuses/43599facf4c8b42b8a14d0601556f4231d9d10f8","head":{"label":"lidizheng:python-channelz","ref":"python-channelz","sha":"43599facf4c8b42b8a14d0601556f4231d9d10f8","user":{"login":"lidizheng","id":7394928,"node_id":"MDQ6VXNlcjczOTQ5Mjg=","avatar_url":"https://avatars3.githubusercontent.com/u/7394928?v=4","gravatar_id":"","url":"https://api.github.com/users/lidizheng","html_url":"https://github.com/lidizheng","followers_url":"https://api.github.com/users/lidizheng/followers","following_url":"https://api.github.com/users/lidizheng/following{/other_user}","gists_url":"https://api.github.com/users/lidizheng/gists{/gist_id}","starred_url":"https://api.github.com/users/lidizheng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lidizheng/subscriptions","organizations_url":"https://api.github.com/users/lidizheng/orgs","repos_url":"https://api.github.com/users/lidizheng/repos","events_url":"https://api.github.com/users/lidizheng/events{/privacy}","received_events_url":"https://api.github.com/users/lidizheng/received_events","type":"User","site_admin":false},"repo":{"id":153534845,"node_id":"MDEwOlJlcG9zaXRvcnkxNTM1MzQ4NDU=","name":"grpc","full_name":"lidizheng/grpc","private":false,"owner":{"login":"lidizheng","id":7394928,"node_id":"MDQ6VXNlcjczOTQ5Mjg=","avatar_url":"https://avatars3.githubusercontent.com/u/7394928?v=4","gravatar_id":"","url":"https://api.github.com/users/lidizheng","html_url":"https://github.com/lidizheng","followers_url":"https://api.github.com/users/lidizheng/followers","following_url":"https://api.github.com/users/lidizheng/following{/other_user}","gists_url":"https://api.github.com/users/lidizheng/gists{/gist_id}","starred_url":"https://api.github.com/users/lidizheng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lidizheng/subscriptions","organizations_url":"https://api.github.com/users/lidizheng/orgs","repos_url":"https://api.github.com/users/lidizheng/repos","events_url":"https://api.github.com/users/lidizheng/events{/privacy}","received_events_url":"https://api.github.com/users/lidizheng/received_events","type":"User","site_admin":false},"html_url":"https://github.com/lidizheng/grpc","description":"The C based gRPC (C++, Python, Ruby, Objective-C, PHP, C#)","fork":true,"url":"https://api.github.com/repos/lidizheng/grpc","forks_url":"https://api.github.com/repos/lidizheng/grpc/forks","keys_url":"https://api.github.com/repos/lidizheng/grpc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lidizheng/grpc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lidizheng/grpc/teams","hooks_url":"https://api.github.com/repos/lidizheng/grpc/hooks","issue_events_url":"https://api.github.com/repos/lidizheng/grpc/issues/events{/number}","events_url":"https://api.github.com/repos/lidizheng/grpc/events","assignees_url":"https://api.github.com/repos/lidizheng/grpc/assignees{/user}","branches_url":"https://api.github.com/repos/lidizheng/grpc/branches{/branch}","tags_url":"https://api.github.com/repos/lidizheng/grpc/tags","blobs_url":"https://api.github.com/repos/lidizheng/grpc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lidizheng/grpc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lidizheng/grpc/git/refs{/sha}","trees_url":"https://api.github.com/repos/lidizheng/grpc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lidizheng/grpc/statuses/{sha}","languages_url":"https://api.github.com/repos/lidizheng/grpc/languages","stargazers_url":"https://api.github.com/repos/lidizheng/grpc/stargazers","contributors_url":"https://api.github.com/repos/lidizheng/grpc/contributors","subscribers_url":"https://api.github.com/repos/lidizheng/grpc/subscribers","subscription_url":"https://api.github.com/repos/lidizheng/grpc/subscription","commits_url":"https://api.github.com/repos/lidizheng/grpc/commits{/sha}","git_commits_url":"https://api.github.com/repos/lidizheng/grpc/git/commits{/sha}","comments_url":"https://api.github.com/repos/lidizheng/grpc/comments{/number}","issue_comment_url":"https://api.github.com/repos/lidizheng/grpc/issues/comments{/number}","contents_url":"https://api.github.com/repos/lidizheng/grpc/contents/{+path}","compare_url":"https://api.github.com/repos/lidizheng/grpc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lidizheng/grpc/merges","archive_url":"https://api.github.com/repos/lidizheng/grpc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lidizheng/grpc/downloads","issues_url":"https://api.github.com/repos/lidizheng/grpc/issues{/number}","pulls_url":"https://api.github.com/repos/lidizheng/grpc/pulls{/number}","milestones_url":"https://api.github.com/repos/lidizheng/grpc/milestones{/number}","notifications_url":"https://api.github.com/repos/lidizheng/grpc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lidizheng/grpc/labels{/name}","releases_url":"https://api.github.com/repos/lidizheng/grpc/releases{/id}","deployments_url":"https://api.github.com/repos/lidizheng/grpc/deployments","created_at":"2018-10-17T23:08:39Z","updated_at":"2018-11-27T20:03:25Z","pushed_at":"2018-11-28T01:28:05Z","git_url":"git://github.com/lidizheng/grpc.git","ssh_url":"[email protected]:lidizheng/grpc.git","clone_url":"https://github.com/lidizheng/grpc.git","svn_url":"https://github.com/lidizheng/grpc","homepage":"https://grpc.io","size":189129,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"grpc:master","ref":"master","sha":"c5d22df984d1f8f097ff3064338befedbb36a2c4","user":{"login":"grpc","id":7802525,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc4MDI1MjU=","avatar_url":"https://avatars1.githubusercontent.com/u/7802525?v=4","gravatar_id":"","url":"https://api.github.com/users/grpc","html_url":"https://github.com/grpc","followers_url":"https://api.github.com/users/grpc/followers","following_url":"https://api.github.com/users/grpc/following{/other_user}","gists_url":"https://api.github.com/users/grpc/gists{/gist_id}","starred_url":"https://api.github.com/users/grpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grpc/subscriptions","organizations_url":"https://api.github.com/users/grpc/orgs","repos_url":"https://api.github.com/users/grpc/repos","events_url":"https://api.github.com/users/grpc/events{/privacy}","received_events_url":"https://api.github.com/users/grpc/received_events","type":"Organization","site_admin":false},"repo":{"id":27729880,"node_id":"MDEwOlJlcG9zaXRvcnkyNzcyOTg4MA==","name":"grpc","full_name":"grpc/grpc","private":false,"owner":{"login":"grpc","id":7802525,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc4MDI1MjU=","avatar_url":"https://avatars1.githubusercontent.com/u/7802525?v=4","gravatar_id":"","url":"https://api.github.com/users/grpc","html_url":"https://github.com/grpc","followers_url":"https://api.github.com/users/grpc/followers","following_url":"https://api.github.com/users/grpc/following{/other_user}","gists_url":"https://api.github.com/users/grpc/gists{/gist_id}","starred_url":"https://api.github.com/users/grpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grpc/subscriptions","organizations_url":"https://api.github.com/users/grpc/orgs","repos_url":"https://api.github.com/users/grpc/repos","events_url":"https://api.github.com/users/grpc/events{/privacy}","received_events_url":"https://api.github.com/users/grpc/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/grpc/grpc","description":"The C based gRPC (C++, Python, Ruby, Objective-C, PHP, C#)","fork":false,"url":"https://api.github.com/repos/grpc/grpc","forks_url":"https://api.github.com/repos/grpc/grpc/forks","keys_url":"https://api.github.com/repos/grpc/grpc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grpc/grpc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grpc/grpc/teams","hooks_url":"https://api.github.com/repos/grpc/grpc/hooks","issue_events_url":"https://api.github.com/repos/grpc/grpc/issues/events{/number}","events_url":"https://api.github.com/repos/grpc/grpc/events","assignees_url":"https://api.github.com/repos/grpc/grpc/assignees{/user}","branches_url":"https://api.github.com/repos/grpc/grpc/branches{/branch}","tags_url":"https://api.github.com/repos/grpc/grpc/tags","blobs_url":"https://api.github.com/repos/grpc/grpc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grpc/grpc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grpc/grpc/git/refs{/sha}","trees_url":"https://api.github.com/repos/grpc/grpc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grpc/grpc/statuses/{sha}","languages_url":"https://api.github.com/repos/grpc/grpc/languages","stargazers_url":"https://api.github.com/repos/grpc/grpc/stargazers","contributors_url":"https://api.github.com/repos/grpc/grpc/contributors","subscribers_url":"https://api.github.com/repos/grpc/grpc/subscribers","subscription_url":"https://api.github.com/repos/grpc/grpc/subscription","commits_url":"https://api.github.com/repos/grpc/grpc/commits{/sha}","git_commits_url":"https://api.github.com/repos/grpc/grpc/git/commits{/sha}","comments_url":"https://api.github.com/repos/grpc/grpc/comments{/number}","issue_comment_url":"https://api.github.com/repos/grpc/grpc/issues/comments{/number}","contents_url":"https://api.github.com/repos/grpc/grpc/contents/{+path}","compare_url":"https://api.github.com/repos/grpc/grpc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grpc/grpc/merges","archive_url":"https://api.github.com/repos/grpc/grpc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grpc/grpc/downloads","issues_url":"https://api.github.com/repos/grpc/grpc/issues{/number}","pulls_url":"https://api.github.com/repos/grpc/grpc/pulls{/number}","milestones_url":"https://api.github.com/repos/grpc/grpc/milestones{/number}","notifications_url":"https://api.github.com/repos/grpc/grpc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grpc/grpc/labels{/name}","releases_url":"https://api.github.com/repos/grpc/grpc/releases{/id}","deployments_url":"https://api.github.com/repos/grpc/grpc/deployments","created_at":"2014-12-08T18:58:53Z","updated_at":"2018-11-28T14:32:59Z","pushed_at":"2018-11-28T08:53:59Z","git_url":"git://github.com/grpc/grpc.git","ssh_url":"[email protected]:grpc/grpc.git","clone_url":"https://github.com/grpc/grpc.git","svn_url":"https://github.com/grpc/grpc","homepage":"https://grpc.io","size":199221,"stargazers_count":18232,"watchers_count":18232,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":true,"forks_count":4216,"mirror_url":null,"archived":false,"open_issues_count":1122,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":4216,"open_issues":1122,"watchers":18232,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/grpc/grpc/pulls/17266"},"html":{"href":"https://github.com/grpc/grpc/pull/17266"},"issue":{"href":"https://api.github.com/repos/grpc/grpc/issues/17266"},"comments":{"href":"https://api.github.com/repos/grpc/grpc/issues/17266/comments"},"review_comments":{"href":"https://api.github.com/repos/grpc/grpc/pulls/17266/comments"},"review_comment":{"href":"https://api.github.com/repos/grpc/grpc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/grpc/grpc/pulls/17266/commits"},"statuses":{"href":"https://api.github.com/repos/grpc/grpc/statuses/43599facf4c8b42b8a14d0601556f4231d9d10f8"}},"author_association":"CONTRIBUTOR"}} | {
"id": 27729880,
"name": "grpc/grpc",
"url": "https://api.github.com/repos/grpc/grpc"
} | {
"id": 6148140,
"login": "ncteisen",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6148140?",
"url": "https://api.github.com/users/ncteisen"
} | {
"id": 7802525,
"login": "grpc",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7802525?",
"url": "https://api.github.com/orgs/grpc"
} | 2018-11-28T16:14:13 | 8663024048 | {"actor":{"display_login":"ncteisen"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/DANS-KNAW/easy-bag-store/pulls/comments/244696621","pull_request_review_id":188628382,"id":244696621,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NDY5NjYyMQ==","diff_hunk":"@@ -333,6 +333,18 @@ class StoresServletSpec extends TestSupportFixture\n }\n }\n \n+ it should \"fail when an inactive bag is requested with the wrong queryParams\" in {\n+ val bagId = BagId(UUID.fromString(\"01000000-0000-0000-0000-000000000001\"))\n+ inside(bagStore1.deactivate(bagId)) {\n+ case Success(_) =>\n+ case _ => fail","path":"src/test/scala/nl.knaw.dans.easy.bagstore/server/StoresServletSpec.scala","position":8,"original_position":8,"commit_id":"1e3f4ec4cfefb1c575b1cecc629f6e88ca5eaa7a","original_commit_id":"1e3f4ec4cfefb1c575b1cecc629f6e88ca5eaa7a","user":{"login":"rvanheest","id":5938204,"node_id":"MDQ6VXNlcjU5MzgyMDQ=","avatar_url":"https://avatars2.githubusercontent.com/u/5938204?v=4","gravatar_id":"","url":"https://api.github.com/users/rvanheest","html_url":"https://github.com/rvanheest","followers_url":"https://api.github.com/users/rvanheest/followers","following_url":"https://api.github.com/users/rvanheest/following{/other_user}","gists_url":"https://api.github.com/users/rvanheest/gists{/gist_id}","starred_url":"https://api.github.com/users/rvanheest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rvanheest/subscriptions","organizations_url":"https://api.github.com/users/rvanheest/orgs","repos_url":"https://api.github.com/users/rvanheest/repos","events_url":"https://api.github.com/users/rvanheest/events{/privacy}","received_events_url":"https://api.github.com/users/rvanheest/received_events","type":"User","site_admin":false},"body":"do you mean to write something like `bagStore1.deactivate(bagId) shouldBe a[Success[_]]`?","created_at":"2019-01-02T10:04:29Z","updated_at":"2019-01-02T10:04:30Z","html_url":"https://github.com/DANS-KNAW/easy-bag-store/pull/77#discussion_r244696621","pull_request_url":"https://api.github.com/repos/DANS-KNAW/easy-bag-store/pulls/77","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/DANS-KNAW/easy-bag-store/pulls/comments/244696621"},"html":{"href":"https://github.com/DANS-KNAW/easy-bag-store/pull/77#discussion_r244696621"},"pull_request":{"href":"https://api.github.com/repos/DANS-KNAW/easy-bag-store/pulls/77"}}},"pull_request":{"url":"https://api.github.com/repos/DANS-KNAW/easy-bag-store/pulls/77","id":239505127,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM5NTA1MTI3","html_url":"https://github.com/DANS-KNAW/easy-bag-store/pull/77","diff_url":"https://github.com/DANS-KNAW/easy-bag-store/pull/77.diff","patch_url":"https://github.com/DANS-KNAW/easy-bag-store/pull/77.patch","issue_url":"https://api.github.com/repos/DANS-KNAW/easy-bag-store/issues/77","number":77,"state":"open","locked":false,"title":"EASY-1633 check if file is hidden when returning bag","user":{"login":"stephanHogenboom","id":24325101,"node_id":"MDQ6VXNlcjI0MzI1MTAx","avatar_url":"https://avatars0.githubusercontent.com/u/24325101?v=4","gravatar_id":"","url":"https://api.github.com/users/stephanHogenboom","html_url":"https://github.com/stephanHogenboom","followers_url":"https://api.github.com/users/stephanHogenboom/followers","following_url":"https://api.github.com/users/stephanHogenboom/following{/other_user}","gists_url":"https://api.github.com/users/stephanHogenboom/gists{/gist_id}","starred_url":"https://api.github.com/users/stephanHogenboom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephanHogenboom/subscriptions","organizations_url":"https://api.github.com/users/stephanHogenboom/orgs","repos_url":"https://api.github.com/users/stephanHogenboom/repos","events_url":"https://api.github.com/users/stephanHogenboom/events{/privacy}","received_events_url":"https://api.github.com/users/stephanHogenboom/received_events","type":"User","site_admin":false},"body":"- [x] command line tool\r\n- [x] HTTP\r\n\r\nFixes EASY-1633\r\n\r\n#### When applied it will...\r\n* check if a file is hidden (active) before returning bag\r\n* return a conflict if an inactive bag is request through http\r\n\r\n\r\n#### Where should the reviewer @DANS-KNAW/easy start?\r\n\r\n#### How should this be manually tested?\r\n\r\n#### Related pull requests on github\r\n\r\nrepo | PR\r\n-------------------------- | -----------------\r\neasy- | [PR#](PRlink) ","created_at":"2018-12-18T14:18:15Z","updated_at":"2019-01-02T10:04:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b38ad1dc386650a307aa2763c7f2c2b49359d290","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/DANS-KNAW/easy-bag-store/pulls/77/commits","review_comments_url":"https://api.github.com/repos/DANS-KNAW/easy-bag-store/pulls/77/comments","review_comment_url":"https://api.github.com/repos/DANS-KNAW/easy-bag-store/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DANS-KNAW/easy-bag-store/issues/77/comments","statuses_url":"https://api.github.com/repos/DANS-KNAW/easy-bag-store/statuses/1e3f4ec4cfefb1c575b1cecc629f6e88ca5eaa7a","head":{"label":"stephanHogenboom:EASY-1633","ref":"EASY-1633","sha":"1e3f4ec4cfefb1c575b1cecc629f6e88ca5eaa7a","user":{"login":"stephanHogenboom","id":24325101,"node_id":"MDQ6VXNlcjI0MzI1MTAx","avatar_url":"https://avatars0.githubusercontent.com/u/24325101?v=4","gravatar_id":"","url":"https://api.github.com/users/stephanHogenboom","html_url":"https://github.com/stephanHogenboom","followers_url":"https://api.github.com/users/stephanHogenboom/followers","following_url":"https://api.github.com/users/stephanHogenboom/following{/other_user}","gists_url":"https://api.github.com/users/stephanHogenboom/gists{/gist_id}","starred_url":"https://api.github.com/users/stephanHogenboom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephanHogenboom/subscriptions","organizations_url":"https://api.github.com/users/stephanHogenboom/orgs","repos_url":"https://api.github.com/users/stephanHogenboom/repos","events_url":"https://api.github.com/users/stephanHogenboom/events{/privacy}","received_events_url":"https://api.github.com/users/stephanHogenboom/received_events","type":"User","site_admin":false},"repo":{"id":155863778,"node_id":"MDEwOlJlcG9zaXRvcnkxNTU4NjM3Nzg=","name":"easy-bag-store","full_name":"stephanHogenboom/easy-bag-store","private":false,"owner":{"login":"stephanHogenboom","id":24325101,"node_id":"MDQ6VXNlcjI0MzI1MTAx","avatar_url":"https://avatars0.githubusercontent.com/u/24325101?v=4","gravatar_id":"","url":"https://api.github.com/users/stephanHogenboom","html_url":"https://github.com/stephanHogenboom","followers_url":"https://api.github.com/users/stephanHogenboom/followers","following_url":"https://api.github.com/users/stephanHogenboom/following{/other_user}","gists_url":"https://api.github.com/users/stephanHogenboom/gists{/gist_id}","starred_url":"https://api.github.com/users/stephanHogenboom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephanHogenboom/subscriptions","organizations_url":"https://api.github.com/users/stephanHogenboom/orgs","repos_url":"https://api.github.com/users/stephanHogenboom/repos","events_url":"https://api.github.com/users/stephanHogenboom/events{/privacy}","received_events_url":"https://api.github.com/users/stephanHogenboom/received_events","type":"User","site_admin":false},"html_url":"https://github.com/stephanHogenboom/easy-bag-store","description":"Manage a bag store","fork":true,"url":"https://api.github.com/repos/stephanHogenboom/easy-bag-store","forks_url":"https://api.github.com/repos/stephanHogenboom/easy-bag-store/forks","keys_url":"https://api.github.com/repos/stephanHogenboom/easy-bag-store/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stephanHogenboom/easy-bag-store/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stephanHogenboom/easy-bag-store/teams","hooks_url":"https://api.github.com/repos/stephanHogenboom/easy-bag-store/hooks","issue_events_url":"https://api.github.com/repos/stephanHogenboom/easy-bag-store/issues/events{/number}","events_url":"https://api.github.com/repos/stephanHogenboom/easy-bag-store/events","assignees_url":"https://api.github.com/repos/stephanHogenboom/easy-bag-store/assignees{/user}","branches_url":"https://api.github.com/repos/stephanHogenboom/easy-bag-store/branches{/branch}","tags_url":"https://api.github.com/repos/stephanHogenboom/easy-bag-store/tags","blobs_url":"https://api.github.com/repos/stephanHogenboom/easy-bag-store/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stephanHogenboom/easy-bag-store/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stephanHogenboom/easy-bag-store/git/refs{/sha}","trees_url":"https://api.github.com/repos/stephanHogenboom/easy-bag-store/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stephanHogenboom/easy-bag-store/statuses/{sha}","languages_url":"https://api.github.com/repos/stephanHogenboom/easy-bag-store/languages","stargazers_url":"https://api.github.com/repos/stephanHogenboom/easy-bag-store/stargazers","contributors_url":"https://api.github.com/repos/stephanHogenboom/easy-bag-store/contributors","subscribers_url":"https://api.github.com/repos/stephanHogenboom/easy-bag-store/subscribers","subscription_url":"https://api.github.com/repos/stephanHogenboom/easy-bag-store/subscription","commits_url":"https://api.github.com/repos/stephanHogenboom/easy-bag-store/commits{/sha}","git_commits_url":"https://api.github.com/repos/stephanHogenboom/easy-bag-store/git/commits{/sha}","comments_url":"https://api.github.com/repos/stephanHogenboom/easy-bag-store/comments{/number}","issue_comment_url":"https://api.github.com/repos/stephanHogenboom/easy-bag-store/issues/comments{/number}","contents_url":"https://api.github.com/repos/stephanHogenboom/easy-bag-store/contents/{+path}","compare_url":"https://api.github.com/repos/stephanHogenboom/easy-bag-store/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stephanHogenboom/easy-bag-store/merges","archive_url":"https://api.github.com/repos/stephanHogenboom/easy-bag-store/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stephanHogenboom/easy-bag-store/downloads","issues_url":"https://api.github.com/repos/stephanHogenboom/easy-bag-store/issues{/number}","pulls_url":"https://api.github.com/repos/stephanHogenboom/easy-bag-store/pulls{/number}","milestones_url":"https://api.github.com/repos/stephanHogenboom/easy-bag-store/milestones{/number}","notifications_url":"https://api.github.com/repos/stephanHogenboom/easy-bag-store/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stephanHogenboom/easy-bag-store/labels{/name}","releases_url":"https://api.github.com/repos/stephanHogenboom/easy-bag-store/releases{/id}","deployments_url":"https://api.github.com/repos/stephanHogenboom/easy-bag-store/deployments","created_at":"2018-11-02T12:35:36Z","updated_at":"2018-11-02T12:35:38Z","pushed_at":"2018-12-20T10:10:58Z","git_url":"git://github.com/stephanHogenboom/easy-bag-store.git","ssh_url":"[email protected]:stephanHogenboom/easy-bag-store.git","clone_url":"https://github.com/stephanHogenboom/easy-bag-store.git","svn_url":"https://github.com/stephanHogenboom/easy-bag-store","homepage":"https://dans-knaw.github.io/easy-bag-store","size":7623,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"DANS-KNAW:master","ref":"master","sha":"034ba97469523a3a8b819300a5287f6a30d7d550","user":{"login":"DANS-KNAW","id":7858446,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc4NTg0NDY=","avatar_url":"https://avatars3.githubusercontent.com/u/7858446?v=4","gravatar_id":"","url":"https://api.github.com/users/DANS-KNAW","html_url":"https://github.com/DANS-KNAW","followers_url":"https://api.github.com/users/DANS-KNAW/followers","following_url":"https://api.github.com/users/DANS-KNAW/following{/other_user}","gists_url":"https://api.github.com/users/DANS-KNAW/gists{/gist_id}","starred_url":"https://api.github.com/users/DANS-KNAW/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DANS-KNAW/subscriptions","organizations_url":"https://api.github.com/users/DANS-KNAW/orgs","repos_url":"https://api.github.com/users/DANS-KNAW/repos","events_url":"https://api.github.com/users/DANS-KNAW/events{/privacy}","received_events_url":"https://api.github.com/users/DANS-KNAW/received_events","type":"Organization","site_admin":false},"repo":{"id":76105348,"node_id":"MDEwOlJlcG9zaXRvcnk3NjEwNTM0OA==","name":"easy-bag-store","full_name":"DANS-KNAW/easy-bag-store","private":false,"owner":{"login":"DANS-KNAW","id":7858446,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc4NTg0NDY=","avatar_url":"https://avatars3.githubusercontent.com/u/7858446?v=4","gravatar_id":"","url":"https://api.github.com/users/DANS-KNAW","html_url":"https://github.com/DANS-KNAW","followers_url":"https://api.github.com/users/DANS-KNAW/followers","following_url":"https://api.github.com/users/DANS-KNAW/following{/other_user}","gists_url":"https://api.github.com/users/DANS-KNAW/gists{/gist_id}","starred_url":"https://api.github.com/users/DANS-KNAW/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DANS-KNAW/subscriptions","organizations_url":"https://api.github.com/users/DANS-KNAW/orgs","repos_url":"https://api.github.com/users/DANS-KNAW/repos","events_url":"https://api.github.com/users/DANS-KNAW/events{/privacy}","received_events_url":"https://api.github.com/users/DANS-KNAW/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/DANS-KNAW/easy-bag-store","description":"Manage a bag store","fork":false,"url":"https://api.github.com/repos/DANS-KNAW/easy-bag-store","forks_url":"https://api.github.com/repos/DANS-KNAW/easy-bag-store/forks","keys_url":"https://api.github.com/repos/DANS-KNAW/easy-bag-store/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DANS-KNAW/easy-bag-store/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DANS-KNAW/easy-bag-store/teams","hooks_url":"https://api.github.com/repos/DANS-KNAW/easy-bag-store/hooks","issue_events_url":"https://api.github.com/repos/DANS-KNAW/easy-bag-store/issues/events{/number}","events_url":"https://api.github.com/repos/DANS-KNAW/easy-bag-store/events","assignees_url":"https://api.github.com/repos/DANS-KNAW/easy-bag-store/assignees{/user}","branches_url":"https://api.github.com/repos/DANS-KNAW/easy-bag-store/branches{/branch}","tags_url":"https://api.github.com/repos/DANS-KNAW/easy-bag-store/tags","blobs_url":"https://api.github.com/repos/DANS-KNAW/easy-bag-store/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DANS-KNAW/easy-bag-store/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DANS-KNAW/easy-bag-store/git/refs{/sha}","trees_url":"https://api.github.com/repos/DANS-KNAW/easy-bag-store/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DANS-KNAW/easy-bag-store/statuses/{sha}","languages_url":"https://api.github.com/repos/DANS-KNAW/easy-bag-store/languages","stargazers_url":"https://api.github.com/repos/DANS-KNAW/easy-bag-store/stargazers","contributors_url":"https://api.github.com/repos/DANS-KNAW/easy-bag-store/contributors","subscribers_url":"https://api.github.com/repos/DANS-KNAW/easy-bag-store/subscribers","subscription_url":"https://api.github.com/repos/DANS-KNAW/easy-bag-store/subscription","commits_url":"https://api.github.com/repos/DANS-KNAW/easy-bag-store/commits{/sha}","git_commits_url":"https://api.github.com/repos/DANS-KNAW/easy-bag-store/git/commits{/sha}","comments_url":"https://api.github.com/repos/DANS-KNAW/easy-bag-store/comments{/number}","issue_comment_url":"https://api.github.com/repos/DANS-KNAW/easy-bag-store/issues/comments{/number}","contents_url":"https://api.github.com/repos/DANS-KNAW/easy-bag-store/contents/{+path}","compare_url":"https://api.github.com/repos/DANS-KNAW/easy-bag-store/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DANS-KNAW/easy-bag-store/merges","archive_url":"https://api.github.com/repos/DANS-KNAW/easy-bag-store/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DANS-KNAW/easy-bag-store/downloads","issues_url":"https://api.github.com/repos/DANS-KNAW/easy-bag-store/issues{/number}","pulls_url":"https://api.github.com/repos/DANS-KNAW/easy-bag-store/pulls{/number}","milestones_url":"https://api.github.com/repos/DANS-KNAW/easy-bag-store/milestones{/number}","notifications_url":"https://api.github.com/repos/DANS-KNAW/easy-bag-store/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DANS-KNAW/easy-bag-store/labels{/name}","releases_url":"https://api.github.com/repos/DANS-KNAW/easy-bag-store/releases{/id}","deployments_url":"https://api.github.com/repos/DANS-KNAW/easy-bag-store/deployments","created_at":"2016-12-10T10:19:45Z","updated_at":"2018-12-19T15:23:06Z","pushed_at":"2018-12-20T10:11:00Z","git_url":"git://github.com/DANS-KNAW/easy-bag-store.git","ssh_url":"[email protected]:DANS-KNAW/easy-bag-store.git","clone_url":"https://github.com/DANS-KNAW/easy-bag-store.git","svn_url":"https://github.com/DANS-KNAW/easy-bag-store","homepage":"https://dans-knaw.github.io/easy-bag-store","size":7556,"stargazers_count":3,"watchers_count":3,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":5,"license":null,"forks":8,"open_issues":5,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DANS-KNAW/easy-bag-store/pulls/77"},"html":{"href":"https://github.com/DANS-KNAW/easy-bag-store/pull/77"},"issue":{"href":"https://api.github.com/repos/DANS-KNAW/easy-bag-store/issues/77"},"comments":{"href":"https://api.github.com/repos/DANS-KNAW/easy-bag-store/issues/77/comments"},"review_comments":{"href":"https://api.github.com/repos/DANS-KNAW/easy-bag-store/pulls/77/comments"},"review_comment":{"href":"https://api.github.com/repos/DANS-KNAW/easy-bag-store/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DANS-KNAW/easy-bag-store/pulls/77/commits"},"statuses":{"href":"https://api.github.com/repos/DANS-KNAW/easy-bag-store/statuses/1e3f4ec4cfefb1c575b1cecc629f6e88ca5eaa7a"}},"author_association":"CONTRIBUTOR"}} | {
"id": 76105348,
"name": "DANS-KNAW/easy-bag-store",
"url": "https://api.github.com/repos/DANS-KNAW/easy-bag-store"
} | {
"id": 5938204,
"login": "rvanheest",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5938204?",
"url": "https://api.github.com/users/rvanheest"
} | {
"id": 7858446,
"login": "DANS-KNAW",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7858446?",
"url": "https://api.github.com/orgs/DANS-KNAW"
} | 2019-01-02T10:04:29 | 8822601538 | {"actor":{"display_login":"rvanheest"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/betagouv/beta.gouv.fr/pulls/comments/179703709","pull_request_review_id":109998371,"id":179703709,"diff_hunk":"@@ -0,0 +1,47 @@\n+---\n+title: Zam\n+mission: Alléger la charge de préparation par le gouvernement du débat parlementaire.\n+owner: DINSIC","path":"_startup/zam.md","position":4,"original_position":4,"commit_id":"e8767b7f568d5643ee2aa261485075e33d54dea1","original_commit_id":"e8767b7f568d5643ee2aa261485075e33d54dea1","user":{"login":"jdauphant","id":1238254,"avatar_url":"https://avatars0.githubusercontent.com/u/1238254?v=4","gravatar_id":"","url":"https://api.github.com/users/jdauphant","html_url":"https://github.com/jdauphant","followers_url":"https://api.github.com/users/jdauphant/followers","following_url":"https://api.github.com/users/jdauphant/following{/other_user}","gists_url":"https://api.github.com/users/jdauphant/gists{/gist_id}","starred_url":"https://api.github.com/users/jdauphant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdauphant/subscriptions","organizations_url":"https://api.github.com/users/jdauphant/orgs","repos_url":"https://api.github.com/users/jdauphant/repos","events_url":"https://api.github.com/users/jdauphant/events{/privacy}","received_events_url":"https://api.github.com/users/jdauphant/received_events","type":"User","site_admin":false},"body":"Il manque le nouveau champs \"incubator: dinsic\"\r\n\r\nC'est bizarre que la CI ne cri pas dessus cc @gregoirenovel ","created_at":"2018-04-06T09:26:43Z","updated_at":"2018-04-06T09:26:51Z","html_url":"https://github.com/betagouv/beta.gouv.fr/pull/1361#discussion_r179703709","pull_request_url":"https://api.github.com/repos/betagouv/beta.gouv.fr/pulls/1361","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/betagouv/beta.gouv.fr/pulls/comments/179703709"},"html":{"href":"https://github.com/betagouv/beta.gouv.fr/pull/1361#discussion_r179703709"},"pull_request":{"href":"https://api.github.com/repos/betagouv/beta.gouv.fr/pulls/1361"}}},"pull_request":{"url":"https://api.github.com/repos/betagouv/beta.gouv.fr/pulls/1361","id":178088524,"html_url":"https://github.com/betagouv/beta.gouv.fr/pull/1361","diff_url":"https://github.com/betagouv/beta.gouv.fr/pull/1361.diff","patch_url":"https://github.com/betagouv/beta.gouv.fr/pull/1361.patch","issue_url":"https://api.github.com/repos/betagouv/beta.gouv.fr/issues/1361","number":1361,"state":"open","locked":false,"title":"Add new startup : Zam","user":{"login":"raphaelpierquin","id":549405,"avatar_url":"https://avatars3.githubusercontent.com/u/549405?v=4","gravatar_id":"","url":"https://api.github.com/users/raphaelpierquin","html_url":"https://github.com/raphaelpierquin","followers_url":"https://api.github.com/users/raphaelpierquin/followers","following_url":"https://api.github.com/users/raphaelpierquin/following{/other_user}","gists_url":"https://api.github.com/users/raphaelpierquin/gists{/gist_id}","starred_url":"https://api.github.com/users/raphaelpierquin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raphaelpierquin/subscriptions","organizations_url":"https://api.github.com/users/raphaelpierquin/orgs","repos_url":"https://api.github.com/users/raphaelpierquin/repos","events_url":"https://api.github.com/users/raphaelpierquin/events{/privacy}","received_events_url":"https://api.github.com/users/raphaelpierquin/received_events","type":"User","site_admin":false},"body":"Du feedback sur la forme et le fond sont les bienvenus.\r\nMerci de ne pas merger.","created_at":"2018-03-28T16:06:18Z","updated_at":"2018-04-06T09:26:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dd003e5f9c87606e40c1ad1d0e1d9982eddd6deb","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/betagouv/beta.gouv.fr/pulls/1361/commits","review_comments_url":"https://api.github.com/repos/betagouv/beta.gouv.fr/pulls/1361/comments","review_comment_url":"https://api.github.com/repos/betagouv/beta.gouv.fr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/betagouv/beta.gouv.fr/issues/1361/comments","statuses_url":"https://api.github.com/repos/betagouv/beta.gouv.fr/statuses/e8767b7f568d5643ee2aa261485075e33d54dea1","head":{"label":"betagouv:nouvelleStartupZam","ref":"nouvelleStartupZam","sha":"e8767b7f568d5643ee2aa261485075e33d54dea1","user":{"login":"betagouv","id":7874148,"avatar_url":"https://avatars0.githubusercontent.com/u/7874148?v=4","gravatar_id":"","url":"https://api.github.com/users/betagouv","html_url":"https://github.com/betagouv","followers_url":"https://api.github.com/users/betagouv/followers","following_url":"https://api.github.com/users/betagouv/following{/other_user}","gists_url":"https://api.github.com/users/betagouv/gists{/gist_id}","starred_url":"https://api.github.com/users/betagouv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/betagouv/subscriptions","organizations_url":"https://api.github.com/users/betagouv/orgs","repos_url":"https://api.github.com/users/betagouv/repos","events_url":"https://api.github.com/users/betagouv/events{/privacy}","received_events_url":"https://api.github.com/users/betagouv/received_events","type":"Organization","site_admin":false},"repo":{"id":48237006,"name":"beta.gouv.fr","full_name":"betagouv/beta.gouv.fr","owner":{"login":"betagouv","id":7874148,"avatar_url":"https://avatars0.githubusercontent.com/u/7874148?v=4","gravatar_id":"","url":"https://api.github.com/users/betagouv","html_url":"https://github.com/betagouv","followers_url":"https://api.github.com/users/betagouv/followers","following_url":"https://api.github.com/users/betagouv/following{/other_user}","gists_url":"https://api.github.com/users/betagouv/gists{/gist_id}","starred_url":"https://api.github.com/users/betagouv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/betagouv/subscriptions","organizations_url":"https://api.github.com/users/betagouv/orgs","repos_url":"https://api.github.com/users/betagouv/repos","events_url":"https://api.github.com/users/betagouv/events{/privacy}","received_events_url":"https://api.github.com/users/betagouv/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/betagouv/beta.gouv.fr","description":"Le site public de l'Incubateur de Services Numériques de l'État français.","fork":false,"url":"https://api.github.com/repos/betagouv/beta.gouv.fr","forks_url":"https://api.github.com/repos/betagouv/beta.gouv.fr/forks","keys_url":"https://api.github.com/repos/betagouv/beta.gouv.fr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/betagouv/beta.gouv.fr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/betagouv/beta.gouv.fr/teams","hooks_url":"https://api.github.com/repos/betagouv/beta.gouv.fr/hooks","issue_events_url":"https://api.github.com/repos/betagouv/beta.gouv.fr/issues/events{/number}","events_url":"https://api.github.com/repos/betagouv/beta.gouv.fr/events","assignees_url":"https://api.github.com/repos/betagouv/beta.gouv.fr/assignees{/user}","branches_url":"https://api.github.com/repos/betagouv/beta.gouv.fr/branches{/branch}","tags_url":"https://api.github.com/repos/betagouv/beta.gouv.fr/tags","blobs_url":"https://api.github.com/repos/betagouv/beta.gouv.fr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/betagouv/beta.gouv.fr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/betagouv/beta.gouv.fr/git/refs{/sha}","trees_url":"https://api.github.com/repos/betagouv/beta.gouv.fr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/betagouv/beta.gouv.fr/statuses/{sha}","languages_url":"https://api.github.com/repos/betagouv/beta.gouv.fr/languages","stargazers_url":"https://api.github.com/repos/betagouv/beta.gouv.fr/stargazers","contributors_url":"https://api.github.com/repos/betagouv/beta.gouv.fr/contributors","subscribers_url":"https://api.github.com/repos/betagouv/beta.gouv.fr/subscribers","subscription_url":"https://api.github.com/repos/betagouv/beta.gouv.fr/subscription","commits_url":"https://api.github.com/repos/betagouv/beta.gouv.fr/commits{/sha}","git_commits_url":"https://api.github.com/repos/betagouv/beta.gouv.fr/git/commits{/sha}","comments_url":"https://api.github.com/repos/betagouv/beta.gouv.fr/comments{/number}","issue_comment_url":"https://api.github.com/repos/betagouv/beta.gouv.fr/issues/comments{/number}","contents_url":"https://api.github.com/repos/betagouv/beta.gouv.fr/contents/{+path}","compare_url":"https://api.github.com/repos/betagouv/beta.gouv.fr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/betagouv/beta.gouv.fr/merges","archive_url":"https://api.github.com/repos/betagouv/beta.gouv.fr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/betagouv/beta.gouv.fr/downloads","issues_url":"https://api.github.com/repos/betagouv/beta.gouv.fr/issues{/number}","pulls_url":"https://api.github.com/repos/betagouv/beta.gouv.fr/pulls{/number}","milestones_url":"https://api.github.com/repos/betagouv/beta.gouv.fr/milestones{/number}","notifications_url":"https://api.github.com/repos/betagouv/beta.gouv.fr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/betagouv/beta.gouv.fr/labels{/name}","releases_url":"https://api.github.com/repos/betagouv/beta.gouv.fr/releases{/id}","deployments_url":"https://api.github.com/repos/betagouv/beta.gouv.fr/deployments","created_at":"2015-12-18T13:33:48Z","updated_at":"2018-04-06T05:43:58Z","pushed_at":"2018-04-06T09:10:18Z","git_url":"git://github.com/betagouv/beta.gouv.fr.git","ssh_url":"[email protected]:betagouv/beta.gouv.fr.git","clone_url":"https://github.com/betagouv/beta.gouv.fr.git","svn_url":"https://github.com/betagouv/beta.gouv.fr","homepage":"https://beta.gouv.fr","size":79937,"stargazers_count":58,"watchers_count":58,"language":"HTML","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":142,"mirror_url":null,"archived":false,"open_issues_count":8,"license":null,"forks":142,"open_issues":8,"watchers":58,"default_branch":"master"}},"base":{"label":"betagouv:master","ref":"master","sha":"614c8912491d56828599e86c982b059a5af90c7b","user":{"login":"betagouv","id":7874148,"avatar_url":"https://avatars0.githubusercontent.com/u/7874148?v=4","gravatar_id":"","url":"https://api.github.com/users/betagouv","html_url":"https://github.com/betagouv","followers_url":"https://api.github.com/users/betagouv/followers","following_url":"https://api.github.com/users/betagouv/following{/other_user}","gists_url":"https://api.github.com/users/betagouv/gists{/gist_id}","starred_url":"https://api.github.com/users/betagouv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/betagouv/subscriptions","organizations_url":"https://api.github.com/users/betagouv/orgs","repos_url":"https://api.github.com/users/betagouv/repos","events_url":"https://api.github.com/users/betagouv/events{/privacy}","received_events_url":"https://api.github.com/users/betagouv/received_events","type":"Organization","site_admin":false},"repo":{"id":48237006,"name":"beta.gouv.fr","full_name":"betagouv/beta.gouv.fr","owner":{"login":"betagouv","id":7874148,"avatar_url":"https://avatars0.githubusercontent.com/u/7874148?v=4","gravatar_id":"","url":"https://api.github.com/users/betagouv","html_url":"https://github.com/betagouv","followers_url":"https://api.github.com/users/betagouv/followers","following_url":"https://api.github.com/users/betagouv/following{/other_user}","gists_url":"https://api.github.com/users/betagouv/gists{/gist_id}","starred_url":"https://api.github.com/users/betagouv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/betagouv/subscriptions","organizations_url":"https://api.github.com/users/betagouv/orgs","repos_url":"https://api.github.com/users/betagouv/repos","events_url":"https://api.github.com/users/betagouv/events{/privacy}","received_events_url":"https://api.github.com/users/betagouv/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/betagouv/beta.gouv.fr","description":"Le site public de l'Incubateur de Services Numériques de l'État français.","fork":false,"url":"https://api.github.com/repos/betagouv/beta.gouv.fr","forks_url":"https://api.github.com/repos/betagouv/beta.gouv.fr/forks","keys_url":"https://api.github.com/repos/betagouv/beta.gouv.fr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/betagouv/beta.gouv.fr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/betagouv/beta.gouv.fr/teams","hooks_url":"https://api.github.com/repos/betagouv/beta.gouv.fr/hooks","issue_events_url":"https://api.github.com/repos/betagouv/beta.gouv.fr/issues/events{/number}","events_url":"https://api.github.com/repos/betagouv/beta.gouv.fr/events","assignees_url":"https://api.github.com/repos/betagouv/beta.gouv.fr/assignees{/user}","branches_url":"https://api.github.com/repos/betagouv/beta.gouv.fr/branches{/branch}","tags_url":"https://api.github.com/repos/betagouv/beta.gouv.fr/tags","blobs_url":"https://api.github.com/repos/betagouv/beta.gouv.fr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/betagouv/beta.gouv.fr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/betagouv/beta.gouv.fr/git/refs{/sha}","trees_url":"https://api.github.com/repos/betagouv/beta.gouv.fr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/betagouv/beta.gouv.fr/statuses/{sha}","languages_url":"https://api.github.com/repos/betagouv/beta.gouv.fr/languages","stargazers_url":"https://api.github.com/repos/betagouv/beta.gouv.fr/stargazers","contributors_url":"https://api.github.com/repos/betagouv/beta.gouv.fr/contributors","subscribers_url":"https://api.github.com/repos/betagouv/beta.gouv.fr/subscribers","subscription_url":"https://api.github.com/repos/betagouv/beta.gouv.fr/subscription","commits_url":"https://api.github.com/repos/betagouv/beta.gouv.fr/commits{/sha}","git_commits_url":"https://api.github.com/repos/betagouv/beta.gouv.fr/git/commits{/sha}","comments_url":"https://api.github.com/repos/betagouv/beta.gouv.fr/comments{/number}","issue_comment_url":"https://api.github.com/repos/betagouv/beta.gouv.fr/issues/comments{/number}","contents_url":"https://api.github.com/repos/betagouv/beta.gouv.fr/contents/{+path}","compare_url":"https://api.github.com/repos/betagouv/beta.gouv.fr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/betagouv/beta.gouv.fr/merges","archive_url":"https://api.github.com/repos/betagouv/beta.gouv.fr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/betagouv/beta.gouv.fr/downloads","issues_url":"https://api.github.com/repos/betagouv/beta.gouv.fr/issues{/number}","pulls_url":"https://api.github.com/repos/betagouv/beta.gouv.fr/pulls{/number}","milestones_url":"https://api.github.com/repos/betagouv/beta.gouv.fr/milestones{/number}","notifications_url":"https://api.github.com/repos/betagouv/beta.gouv.fr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/betagouv/beta.gouv.fr/labels{/name}","releases_url":"https://api.github.com/repos/betagouv/beta.gouv.fr/releases{/id}","deployments_url":"https://api.github.com/repos/betagouv/beta.gouv.fr/deployments","created_at":"2015-12-18T13:33:48Z","updated_at":"2018-04-06T05:43:58Z","pushed_at":"2018-04-06T09:10:18Z","git_url":"git://github.com/betagouv/beta.gouv.fr.git","ssh_url":"[email protected]:betagouv/beta.gouv.fr.git","clone_url":"https://github.com/betagouv/beta.gouv.fr.git","svn_url":"https://github.com/betagouv/beta.gouv.fr","homepage":"https://beta.gouv.fr","size":79937,"stargazers_count":58,"watchers_count":58,"language":"HTML","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":142,"mirror_url":null,"archived":false,"open_issues_count":8,"license":null,"forks":142,"open_issues":8,"watchers":58,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/betagouv/beta.gouv.fr/pulls/1361"},"html":{"href":"https://github.com/betagouv/beta.gouv.fr/pull/1361"},"issue":{"href":"https://api.github.com/repos/betagouv/beta.gouv.fr/issues/1361"},"comments":{"href":"https://api.github.com/repos/betagouv/beta.gouv.fr/issues/1361/comments"},"review_comments":{"href":"https://api.github.com/repos/betagouv/beta.gouv.fr/pulls/1361/comments"},"review_comment":{"href":"https://api.github.com/repos/betagouv/beta.gouv.fr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/betagouv/beta.gouv.fr/pulls/1361/commits"},"statuses":{"href":"https://api.github.com/repos/betagouv/beta.gouv.fr/statuses/e8767b7f568d5643ee2aa261485075e33d54dea1"}},"author_association":"CONTRIBUTOR"}} | {
"id": 48237006,
"name": "betagouv/beta.gouv.fr",
"url": "https://api.github.com/repos/betagouv/beta.gouv.fr"
} | {
"id": 1238254,
"login": "jdauphant",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1238254?",
"url": "https://api.github.com/users/jdauphant"
} | {
"id": 7874148,
"login": "betagouv",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7874148?",
"url": "https://api.github.com/orgs/betagouv"
} | 2018-04-06T09:26:43 | 7489886991 | {"actor":{"display_login":"jdauphant"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/test-editor/web-test-navigator/pulls/comments/226179741","pull_request_review_id":165938183,"id":226179741,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNjE3OTc0MQ==","diff_hunk":"@@ -58,4 +71,93 @@ describe('FilterBarComponent', () => {\n expect(hostComponent.filterState.tcl).toBeFalsy();\n expect(hostComponent.filterState.aml).toBeFalsy();\n }));\n+\n+ ['tcl', 'tsl', 'aml'].forEach((type: 'tcl' | 'tsl' | 'aml') =>\n+ it(`never shows ${type} validation markers when ${type} files are not being filtered out`, fakeAsync(() => {\n+ // given\n+ hostComponent.filterState = { tsl: true, tcl: true, aml: true };","path":"src/app/modules/filter-bar/filter-bar.component.spec.ts","position":42,"original_position":42,"commit_id":"6593d739218f67b5b7a7b8ed8d0b3b48e6007ad1","original_commit_id":"6593d739218f67b5b7a7b8ed8d0b3b48e6007ad1","user":{"login":"gunther-bachmann","id":12764214,"node_id":"MDQ6VXNlcjEyNzY0MjE0","avatar_url":"https://avatars3.githubusercontent.com/u/12764214?v=4","gravatar_id":"","url":"https://api.github.com/users/gunther-bachmann","html_url":"https://github.com/gunther-bachmann","followers_url":"https://api.github.com/users/gunther-bachmann/followers","following_url":"https://api.github.com/users/gunther-bachmann/following{/other_user}","gists_url":"https://api.github.com/users/gunther-bachmann/gists{/gist_id}","starred_url":"https://api.github.com/users/gunther-bachmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gunther-bachmann/subscriptions","organizations_url":"https://api.github.com/users/gunther-bachmann/orgs","repos_url":"https://api.github.com/users/gunther-bachmann/repos","events_url":"https://api.github.com/users/gunther-bachmann/events{/privacy}","received_events_url":"https://api.github.com/users/gunther-bachmann/received_events","type":"User","site_admin":false},"body":"should work for filterState = { tsl: false, tcl: false, aml: false }, too, right?","created_at":"2018-10-18T06:20:17Z","updated_at":"2018-10-18T06:29:01Z","html_url":"https://github.com/test-editor/web-test-navigator/pull/33#discussion_r226179741","pull_request_url":"https://api.github.com/repos/test-editor/web-test-navigator/pulls/33","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/test-editor/web-test-navigator/pulls/comments/226179741"},"html":{"href":"https://github.com/test-editor/web-test-navigator/pull/33#discussion_r226179741"},"pull_request":{"href":"https://api.github.com/repos/test-editor/web-test-navigator/pulls/33"}}},"pull_request":{"url":"https://api.github.com/repos/test-editor/web-test-navigator/pulls/33","id":223672819,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIzNjcyODE5","html_url":"https://github.com/test-editor/web-test-navigator/pull/33","diff_url":"https://github.com/test-editor/web-test-navigator/pull/33.diff","patch_url":"https://github.com/test-editor/web-test-navigator/pull/33.patch","issue_url":"https://api.github.com/repos/test-editor/web-test-navigator/issues/33","number":33,"state":"open","locked":false,"title":"show validation markers on filter buttons for filtered-out files","user":{"login":"jjelschen","id":2879473,"node_id":"MDQ6VXNlcjI4Nzk0NzM=","avatar_url":"https://avatars3.githubusercontent.com/u/2879473?v=4","gravatar_id":"","url":"https://api.github.com/users/jjelschen","html_url":"https://github.com/jjelschen","followers_url":"https://api.github.com/users/jjelschen/followers","following_url":"https://api.github.com/users/jjelschen/following{/other_user}","gists_url":"https://api.github.com/users/jjelschen/gists{/gist_id}","starred_url":"https://api.github.com/users/jjelschen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jjelschen/subscriptions","organizations_url":"https://api.github.com/users/jjelschen/orgs","repos_url":"https://api.github.com/users/jjelschen/repos","events_url":"https://api.github.com/users/jjelschen/events{/privacy}","received_events_url":"https://api.github.com/users/jjelschen/received_events","type":"User","site_admin":false},"body":"One thing that is still missing from this PR is displaying tooltip summaries for the validation markers (i.e. \"1 error(s), 2 warning(s), 3 info(s)\"). I need to refactor a bit so that the tree isn't traversed every time Angular tries to re-render parts of the DOM and checks whether to display marker icons and tooltip texts…","created_at":"2018-10-17T16:32:14Z","updated_at":"2018-10-18T06:29:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0bb3a41c3579666b0d864ca9fdda85c802e3f6bb","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/test-editor/web-test-navigator/pulls/33/commits","review_comments_url":"https://api.github.com/repos/test-editor/web-test-navigator/pulls/33/comments","review_comment_url":"https://api.github.com/repos/test-editor/web-test-navigator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/test-editor/web-test-navigator/issues/33/comments","statuses_url":"https://api.github.com/repos/test-editor/web-test-navigator/statuses/6593d739218f67b5b7a7b8ed8d0b3b48e6007ad1","head":{"label":"test-editor:feature/filter-validation-markers","ref":"feature/filter-validation-markers","sha":"6593d739218f67b5b7a7b8ed8d0b3b48e6007ad1","user":{"login":"test-editor","id":7946408,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5NDY0MDg=","avatar_url":"https://avatars3.githubusercontent.com/u/7946408?v=4","gravatar_id":"","url":"https://api.github.com/users/test-editor","html_url":"https://github.com/test-editor","followers_url":"https://api.github.com/users/test-editor/followers","following_url":"https://api.github.com/users/test-editor/following{/other_user}","gists_url":"https://api.github.com/users/test-editor/gists{/gist_id}","starred_url":"https://api.github.com/users/test-editor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/test-editor/subscriptions","organizations_url":"https://api.github.com/users/test-editor/orgs","repos_url":"https://api.github.com/users/test-editor/repos","events_url":"https://api.github.com/users/test-editor/events{/privacy}","received_events_url":"https://api.github.com/users/test-editor/received_events","type":"Organization","site_admin":false},"repo":{"id":145819394,"node_id":"MDEwOlJlcG9zaXRvcnkxNDU4MTkzOTQ=","name":"web-test-navigator","full_name":"test-editor/web-test-navigator","private":false,"owner":{"login":"test-editor","id":7946408,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5NDY0MDg=","avatar_url":"https://avatars3.githubusercontent.com/u/7946408?v=4","gravatar_id":"","url":"https://api.github.com/users/test-editor","html_url":"https://github.com/test-editor","followers_url":"https://api.github.com/users/test-editor/followers","following_url":"https://api.github.com/users/test-editor/following{/other_user}","gists_url":"https://api.github.com/users/test-editor/gists{/gist_id}","starred_url":"https://api.github.com/users/test-editor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/test-editor/subscriptions","organizations_url":"https://api.github.com/users/test-editor/orgs","repos_url":"https://api.github.com/users/test-editor/repos","events_url":"https://api.github.com/users/test-editor/events{/privacy}","received_events_url":"https://api.github.com/users/test-editor/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/test-editor/web-test-navigator","description":"Top level navigation component for test editor projects","fork":false,"url":"https://api.github.com/repos/test-editor/web-test-navigator","forks_url":"https://api.github.com/repos/test-editor/web-test-navigator/forks","keys_url":"https://api.github.com/repos/test-editor/web-test-navigator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/test-editor/web-test-navigator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/test-editor/web-test-navigator/teams","hooks_url":"https://api.github.com/repos/test-editor/web-test-navigator/hooks","issue_events_url":"https://api.github.com/repos/test-editor/web-test-navigator/issues/events{/number}","events_url":"https://api.github.com/repos/test-editor/web-test-navigator/events","assignees_url":"https://api.github.com/repos/test-editor/web-test-navigator/assignees{/user}","branches_url":"https://api.github.com/repos/test-editor/web-test-navigator/branches{/branch}","tags_url":"https://api.github.com/repos/test-editor/web-test-navigator/tags","blobs_url":"https://api.github.com/repos/test-editor/web-test-navigator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/test-editor/web-test-navigator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/test-editor/web-test-navigator/git/refs{/sha}","trees_url":"https://api.github.com/repos/test-editor/web-test-navigator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/test-editor/web-test-navigator/statuses/{sha}","languages_url":"https://api.github.com/repos/test-editor/web-test-navigator/languages","stargazers_url":"https://api.github.com/repos/test-editor/web-test-navigator/stargazers","contributors_url":"https://api.github.com/repos/test-editor/web-test-navigator/contributors","subscribers_url":"https://api.github.com/repos/test-editor/web-test-navigator/subscribers","subscription_url":"https://api.github.com/repos/test-editor/web-test-navigator/subscription","commits_url":"https://api.github.com/repos/test-editor/web-test-navigator/commits{/sha}","git_commits_url":"https://api.github.com/repos/test-editor/web-test-navigator/git/commits{/sha}","comments_url":"https://api.github.com/repos/test-editor/web-test-navigator/comments{/number}","issue_comment_url":"https://api.github.com/repos/test-editor/web-test-navigator/issues/comments{/number}","contents_url":"https://api.github.com/repos/test-editor/web-test-navigator/contents/{+path}","compare_url":"https://api.github.com/repos/test-editor/web-test-navigator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/test-editor/web-test-navigator/merges","archive_url":"https://api.github.com/repos/test-editor/web-test-navigator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/test-editor/web-test-navigator/downloads","issues_url":"https://api.github.com/repos/test-editor/web-test-navigator/issues{/number}","pulls_url":"https://api.github.com/repos/test-editor/web-test-navigator/pulls{/number}","milestones_url":"https://api.github.com/repos/test-editor/web-test-navigator/milestones{/number}","notifications_url":"https://api.github.com/repos/test-editor/web-test-navigator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/test-editor/web-test-navigator/labels{/name}","releases_url":"https://api.github.com/repos/test-editor/web-test-navigator/releases{/id}","deployments_url":"https://api.github.com/repos/test-editor/web-test-navigator/deployments","created_at":"2018-08-23T07:45:52Z","updated_at":"2018-10-11T08:58:20Z","pushed_at":"2018-10-17T16:32:15Z","git_url":"git://github.com/test-editor/web-test-navigator.git","ssh_url":"[email protected]:test-editor/web-test-navigator.git","clone_url":"https://github.com/test-editor/web-test-navigator.git","svn_url":"https://github.com/test-editor/web-test-navigator","homepage":null,"size":241,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"epl-2.0","name":"Eclipse Public License 2.0","spdx_id":"EPL-2.0","url":"https://api.github.com/licenses/epl-2.0","node_id":"MDc6TGljZW5zZTMy"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"test-editor:master","ref":"master","sha":"ed11b20e7610f4ec1ffe1be3e371c07e307f382e","user":{"login":"test-editor","id":7946408,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5NDY0MDg=","avatar_url":"https://avatars3.githubusercontent.com/u/7946408?v=4","gravatar_id":"","url":"https://api.github.com/users/test-editor","html_url":"https://github.com/test-editor","followers_url":"https://api.github.com/users/test-editor/followers","following_url":"https://api.github.com/users/test-editor/following{/other_user}","gists_url":"https://api.github.com/users/test-editor/gists{/gist_id}","starred_url":"https://api.github.com/users/test-editor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/test-editor/subscriptions","organizations_url":"https://api.github.com/users/test-editor/orgs","repos_url":"https://api.github.com/users/test-editor/repos","events_url":"https://api.github.com/users/test-editor/events{/privacy}","received_events_url":"https://api.github.com/users/test-editor/received_events","type":"Organization","site_admin":false},"repo":{"id":145819394,"node_id":"MDEwOlJlcG9zaXRvcnkxNDU4MTkzOTQ=","name":"web-test-navigator","full_name":"test-editor/web-test-navigator","private":false,"owner":{"login":"test-editor","id":7946408,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5NDY0MDg=","avatar_url":"https://avatars3.githubusercontent.com/u/7946408?v=4","gravatar_id":"","url":"https://api.github.com/users/test-editor","html_url":"https://github.com/test-editor","followers_url":"https://api.github.com/users/test-editor/followers","following_url":"https://api.github.com/users/test-editor/following{/other_user}","gists_url":"https://api.github.com/users/test-editor/gists{/gist_id}","starred_url":"https://api.github.com/users/test-editor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/test-editor/subscriptions","organizations_url":"https://api.github.com/users/test-editor/orgs","repos_url":"https://api.github.com/users/test-editor/repos","events_url":"https://api.github.com/users/test-editor/events{/privacy}","received_events_url":"https://api.github.com/users/test-editor/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/test-editor/web-test-navigator","description":"Top level navigation component for test editor projects","fork":false,"url":"https://api.github.com/repos/test-editor/web-test-navigator","forks_url":"https://api.github.com/repos/test-editor/web-test-navigator/forks","keys_url":"https://api.github.com/repos/test-editor/web-test-navigator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/test-editor/web-test-navigator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/test-editor/web-test-navigator/teams","hooks_url":"https://api.github.com/repos/test-editor/web-test-navigator/hooks","issue_events_url":"https://api.github.com/repos/test-editor/web-test-navigator/issues/events{/number}","events_url":"https://api.github.com/repos/test-editor/web-test-navigator/events","assignees_url":"https://api.github.com/repos/test-editor/web-test-navigator/assignees{/user}","branches_url":"https://api.github.com/repos/test-editor/web-test-navigator/branches{/branch}","tags_url":"https://api.github.com/repos/test-editor/web-test-navigator/tags","blobs_url":"https://api.github.com/repos/test-editor/web-test-navigator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/test-editor/web-test-navigator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/test-editor/web-test-navigator/git/refs{/sha}","trees_url":"https://api.github.com/repos/test-editor/web-test-navigator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/test-editor/web-test-navigator/statuses/{sha}","languages_url":"https://api.github.com/repos/test-editor/web-test-navigator/languages","stargazers_url":"https://api.github.com/repos/test-editor/web-test-navigator/stargazers","contributors_url":"https://api.github.com/repos/test-editor/web-test-navigator/contributors","subscribers_url":"https://api.github.com/repos/test-editor/web-test-navigator/subscribers","subscription_url":"https://api.github.com/repos/test-editor/web-test-navigator/subscription","commits_url":"https://api.github.com/repos/test-editor/web-test-navigator/commits{/sha}","git_commits_url":"https://api.github.com/repos/test-editor/web-test-navigator/git/commits{/sha}","comments_url":"https://api.github.com/repos/test-editor/web-test-navigator/comments{/number}","issue_comment_url":"https://api.github.com/repos/test-editor/web-test-navigator/issues/comments{/number}","contents_url":"https://api.github.com/repos/test-editor/web-test-navigator/contents/{+path}","compare_url":"https://api.github.com/repos/test-editor/web-test-navigator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/test-editor/web-test-navigator/merges","archive_url":"https://api.github.com/repos/test-editor/web-test-navigator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/test-editor/web-test-navigator/downloads","issues_url":"https://api.github.com/repos/test-editor/web-test-navigator/issues{/number}","pulls_url":"https://api.github.com/repos/test-editor/web-test-navigator/pulls{/number}","milestones_url":"https://api.github.com/repos/test-editor/web-test-navigator/milestones{/number}","notifications_url":"https://api.github.com/repos/test-editor/web-test-navigator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/test-editor/web-test-navigator/labels{/name}","releases_url":"https://api.github.com/repos/test-editor/web-test-navigator/releases{/id}","deployments_url":"https://api.github.com/repos/test-editor/web-test-navigator/deployments","created_at":"2018-08-23T07:45:52Z","updated_at":"2018-10-11T08:58:20Z","pushed_at":"2018-10-17T16:32:15Z","git_url":"git://github.com/test-editor/web-test-navigator.git","ssh_url":"[email protected]:test-editor/web-test-navigator.git","clone_url":"https://github.com/test-editor/web-test-navigator.git","svn_url":"https://github.com/test-editor/web-test-navigator","homepage":null,"size":241,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"epl-2.0","name":"Eclipse Public License 2.0","spdx_id":"EPL-2.0","url":"https://api.github.com/licenses/epl-2.0","node_id":"MDc6TGljZW5zZTMy"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/test-editor/web-test-navigator/pulls/33"},"html":{"href":"https://github.com/test-editor/web-test-navigator/pull/33"},"issue":{"href":"https://api.github.com/repos/test-editor/web-test-navigator/issues/33"},"comments":{"href":"https://api.github.com/repos/test-editor/web-test-navigator/issues/33/comments"},"review_comments":{"href":"https://api.github.com/repos/test-editor/web-test-navigator/pulls/33/comments"},"review_comment":{"href":"https://api.github.com/repos/test-editor/web-test-navigator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/test-editor/web-test-navigator/pulls/33/commits"},"statuses":{"href":"https://api.github.com/repos/test-editor/web-test-navigator/statuses/6593d739218f67b5b7a7b8ed8d0b3b48e6007ad1"}},"author_association":"CONTRIBUTOR"}} | {
"id": 145819394,
"name": "test-editor/web-test-navigator",
"url": "https://api.github.com/repos/test-editor/web-test-navigator"
} | {
"id": 12764214,
"login": "gunther-bachmann",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/12764214?",
"url": "https://api.github.com/users/gunther-bachmann"
} | {
"id": 7946408,
"login": "test-editor",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7946408?",
"url": "https://api.github.com/orgs/test-editor"
} | 2018-10-18T06:20:17 | 8440243346 | {"actor":{"display_login":"gunther-bachmann"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/fsnotify/fsnotify/pulls/comments/223461623","pull_request_review_id":162594034,"id":223461623,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMzQ2MTYyMw==","diff_hunk":"@@ -6,32 +6,363 @@\n \n package fsnotify\n \n+// #include <errno.h>\n+// #include <strings.h>\n+// #include <unistd.h>\n+// #include <stdio.h>\n+// #include <stdlib.h>\n+// #include <port.h>\n+// #include <sys/stat.h>\n+//\n+// uintptr_t file_obj_to_uintptr (file_obj_t *obj) {\n+// return (uintptr_t)obj;\n+// }\n+//\n+// file_obj_t *uintptr_to_file_obj(uintptr_t ptr) {\n+// return (file_obj_t *)ptr;\n+// }\n+//\n+// uintptr_t ptr_to_uintptr(void *p) {\n+//\treturn (uintptr_t)p;\n+// }\n+//\n+// void *uintptr_to_ptr(uintptr_t i) {\n+//\treturn (void *)i;\n+// }\n+//\n+// struct file_info {\n+// uint mode;\n+// };\n+import \"C\"\n import (\n \t\"errors\"\n+\t\"fmt\"\n+\t\"io/ioutil\"\n+\t\"os\"\n+\t\"path/filepath\"\n+\t\"sync\"\n+\t\"syscall\"\n+\t\"unsafe\"\n )\n \n // Watcher watches a set of files, delivering events to a channel.\n type Watcher struct {\n \tEvents chan Event\n \tErrors chan error\n+\n+\tport C.int // solaris port for underlying FEN system\n+\n+\tmu sync.Mutex\n+\twatches map[string]*C.file_obj_t\n+\n+\tdone chan struct{} // Channel for sending a \"quit message\" to the reader goroutine\n+\tdoneResp chan struct{} // Channel to respond to Close\n }\n \n // NewWatcher establishes a new watcher with the underlying OS and begins waiting for events.\n func NewWatcher() (*Watcher, error) {\n-\treturn nil, errors.New(\"FEN based watcher not yet supported for fsnotify\\n\")\n+\tvar err error\n+\n+\tw := new(Watcher)\n+\tw.Events = make(chan Event)\n+\tw.Errors = make(chan error)\n+\tw.port, err = C.port_create()\n+\tif err != nil {\n+\t\treturn nil, err\n+\t}\n+\tw.watches = make(map[string]*C.file_obj_t)\n+\tw.done = make(chan struct{})\n+\tw.doneResp = make(chan struct{})\n+\n+\tgo w.readEvents()\n+\treturn w, nil\n+}\n+\n+// sendEvent attempts to send an event to the user, returning true if the event\n+// was put in the channel successfully and false if the watcher has been closed.\n+func (w *Watcher) sendEvent(e Event) (sent bool) {\n+\tselect {\n+\tcase w.Events <- e:\n+\t\treturn true\n+\tcase <-w.done:\n+\t\treturn false\n+\t}\n+}\n+\n+// sendError attempts to send an event to the user, returning true if the error\n+// was put in the channel successfully and false if the watcher has been closed.\n+func (w *Watcher) sendError(err error) (sent bool) {\n+\tselect {\n+\tcase w.Errors <- err:\n+\t\treturn true\n+\tcase <-w.done:\n+\t\treturn false\n+\t}\n+}\n+\n+func (w *Watcher) isClosed() bool {\n+\tselect {\n+\tcase <-w.done:\n+\t\treturn true\n+\tdefault:\n+\t\treturn false\n+\t}\n }\n \n // Close removes all watches and closes the events channel.\n func (w *Watcher) Close() error {\n+\tif w.isClosed() {\n+\t\treturn nil\n+\t}\n+\tclose(w.done)\n+\tC.close(w.port)\n+\t<-w.doneResp\n \treturn nil\n }\n \n // Add starts watching the named file or directory (non-recursively).\n-func (w *Watcher) Add(name string) error {\n-\treturn nil\n+func (w *Watcher) Add(path string) error {\n+\tif w.isClosed() {\n+\t\treturn errors.New(\"FEN watcher already closed\")\n+\t}\n+\tstat, err := os.Stat(path)\n+\tswitch {\n+\tcase err != nil:\n+\t\treturn err\n+\tcase stat.IsDir():\n+\t\treturn w.handleDirectory(path, stat, w.associateFile)\n+\tdefault:\n+\t\treturn w.associateFile(path, stat)\n+\t}\n }\n \n // Remove stops watching the the named file or directory (non-recursively).\n-func (w *Watcher) Remove(name string) error {\n+func (w *Watcher) Remove(path string) error {","path":"fen.go","position":null,"original_position":139,"commit_id":"0d807a62bd3474b76d4fe5ff292c31fd5ffd065d","original_commit_id":"62cfb90cd26d34c37e316703ffb1ca94025e7ca0","user":{"login":"isaacdavis","id":12563707,"node_id":"MDQ6VXNlcjEyNTYzNzA3","avatar_url":"https://avatars1.githubusercontent.com/u/12563707?v=4","gravatar_id":"","url":"https://api.github.com/users/isaacdavis","html_url":"https://github.com/isaacdavis","followers_url":"https://api.github.com/users/isaacdavis/followers","following_url":"https://api.github.com/users/isaacdavis/following{/other_user}","gists_url":"https://api.github.com/users/isaacdavis/gists{/gist_id}","starred_url":"https://api.github.com/users/isaacdavis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isaacdavis/subscriptions","organizations_url":"https://api.github.com/users/isaacdavis/orgs","repos_url":"https://api.github.com/users/isaacdavis/repos","events_url":"https://api.github.com/users/isaacdavis/events{/privacy}","received_events_url":"https://api.github.com/users/isaacdavis/received_events","type":"User","site_admin":false},"body":"done.","created_at":"2018-10-08T18:40:25Z","updated_at":"2018-10-08T18:40:25Z","html_url":"https://github.com/fsnotify/fsnotify/pull/263#discussion_r223461623","pull_request_url":"https://api.github.com/repos/fsnotify/fsnotify/pulls/263","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/fsnotify/fsnotify/pulls/comments/223461623"},"html":{"href":"https://github.com/fsnotify/fsnotify/pull/263#discussion_r223461623"},"pull_request":{"href":"https://api.github.com/repos/fsnotify/fsnotify/pulls/263"}},"in_reply_to_id":220778426},"pull_request":{"url":"https://api.github.com/repos/fsnotify/fsnotify/pulls/263","id":211585912,"node_id":"MDExOlB1bGxSZXF1ZXN0MjExNTg1OTEy","html_url":"https://github.com/fsnotify/fsnotify/pull/263","diff_url":"https://github.com/fsnotify/fsnotify/pull/263.diff","patch_url":"https://github.com/fsnotify/fsnotify/pull/263.patch","issue_url":"https://api.github.com/repos/fsnotify/fsnotify/issues/263","number":263,"state":"open","locked":false,"title":"add Solaris FEN support","user":{"login":"isaacdavis","id":12563707,"node_id":"MDQ6VXNlcjEyNTYzNzA3","avatar_url":"https://avatars1.githubusercontent.com/u/12563707?v=4","gravatar_id":"","url":"https://api.github.com/users/isaacdavis","html_url":"https://github.com/isaacdavis","followers_url":"https://api.github.com/users/isaacdavis/followers","following_url":"https://api.github.com/users/isaacdavis/following{/other_user}","gists_url":"https://api.github.com/users/isaacdavis/gists{/gist_id}","starred_url":"https://api.github.com/users/isaacdavis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isaacdavis/subscriptions","organizations_url":"https://api.github.com/users/isaacdavis/orgs","repos_url":"https://api.github.com/users/isaacdavis/repos","events_url":"https://api.github.com/users/isaacdavis/events{/privacy}","received_events_url":"https://api.github.com/users/isaacdavis/received_events","type":"User","site_admin":false},"body":"This pull request fixes #12.\r\n\r\nI'm an employee of Joyent, Inc., and have completed the Google corporate CLA.\r\n\r\n#### What does this pull request do?\r\n\r\nThis pull request adds fsnotify support for Solaris and illumos via Solaris FEN. It is heavily based on #196, authored by @gfrey. As such, and with his approval, I have added @gfrey in the `AUTHORS` file in addition to myself.\r\n\r\nOne major revision to @gfrey's work concerns liveness when the watcher is closed when there is an unconsumed event in the channel - the old pull request would sometimes hang on the TestWatcherClose test. The new concurrency model is borrowed from fsnotify's inotify implementation.\r\n\r\nAnother major revision concerns proper translation of FEN events to fsnotify events, in particular the `FILE_RENAME_TO` FEN event.\r\n\r\n#### Where should the reviewer start?\r\n\r\nThese pages are useful as an introduction to FEN:\r\n* https://xnet.fi/solaris/\r\n* https://solarisrants.wordpress.com/2013/07/24/solaris-file-event-notification/\r\n\r\nThe illumos man pages for [port_create](https://illumos.org/man/3C/port_create) and related functions are also helpful for understanding how to interface with FEN.\r\n\r\nThe discussion on #196 is also worth reading. Some points I'll address here:\r\n* The use of `syscall` appears necessary here because `golang.org/x/sys/unix` does not (to my knowledge) provide a way to get atime and ctime.\r\n* `cgo` is used because, for illumos, the officially supported interface to the OS is libc rather than syscalls, and thus user-level code should refrain from making syscalls directly.\r\n\r\n#### How should this be manually tested?\r\nI ran all tests on a SmartOS host. On SmartOS, Go can be installed from Joyent's [pkgsrc](https://pkgsrc.joyent.com/) repository. fsnotify can then be built and tested as normal.\r\n","created_at":"2018-08-28T23:20:08Z","updated_at":"2018-10-08T18:40:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f2e156184d155f4d085af6203afc585cc48831be","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":110285835,"node_id":"MDU6TGFiZWwxMTAyODU4MzU=","url":"https://api.github.com/repos/fsnotify/fsnotify/labels/Solaris%20(FEN)","name":"Solaris (FEN)","color":"006b75","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/fsnotify/fsnotify/pulls/263/commits","review_comments_url":"https://api.github.com/repos/fsnotify/fsnotify/pulls/263/comments","review_comment_url":"https://api.github.com/repos/fsnotify/fsnotify/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fsnotify/fsnotify/issues/263/comments","statuses_url":"https://api.github.com/repos/fsnotify/fsnotify/statuses/0d807a62bd3474b76d4fe5ff292c31fd5ffd065d","head":{"label":"isaacdavis:solaris-fen","ref":"solaris-fen","sha":"0d807a62bd3474b76d4fe5ff292c31fd5ffd065d","user":{"login":"isaacdavis","id":12563707,"node_id":"MDQ6VXNlcjEyNTYzNzA3","avatar_url":"https://avatars1.githubusercontent.com/u/12563707?v=4","gravatar_id":"","url":"https://api.github.com/users/isaacdavis","html_url":"https://github.com/isaacdavis","followers_url":"https://api.github.com/users/isaacdavis/followers","following_url":"https://api.github.com/users/isaacdavis/following{/other_user}","gists_url":"https://api.github.com/users/isaacdavis/gists{/gist_id}","starred_url":"https://api.github.com/users/isaacdavis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isaacdavis/subscriptions","organizations_url":"https://api.github.com/users/isaacdavis/orgs","repos_url":"https://api.github.com/users/isaacdavis/repos","events_url":"https://api.github.com/users/isaacdavis/events{/privacy}","received_events_url":"https://api.github.com/users/isaacdavis/received_events","type":"User","site_admin":false},"repo":{"id":146493194,"node_id":"MDEwOlJlcG9zaXRvcnkxNDY0OTMxOTQ=","name":"fsnotify","full_name":"isaacdavis/fsnotify","private":false,"owner":{"login":"isaacdavis","id":12563707,"node_id":"MDQ6VXNlcjEyNTYzNzA3","avatar_url":"https://avatars1.githubusercontent.com/u/12563707?v=4","gravatar_id":"","url":"https://api.github.com/users/isaacdavis","html_url":"https://github.com/isaacdavis","followers_url":"https://api.github.com/users/isaacdavis/followers","following_url":"https://api.github.com/users/isaacdavis/following{/other_user}","gists_url":"https://api.github.com/users/isaacdavis/gists{/gist_id}","starred_url":"https://api.github.com/users/isaacdavis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isaacdavis/subscriptions","organizations_url":"https://api.github.com/users/isaacdavis/orgs","repos_url":"https://api.github.com/users/isaacdavis/repos","events_url":"https://api.github.com/users/isaacdavis/events{/privacy}","received_events_url":"https://api.github.com/users/isaacdavis/received_events","type":"User","site_admin":false},"html_url":"https://github.com/isaacdavis/fsnotify","description":"Cross-platform file system notifications for Go.","fork":true,"url":"https://api.github.com/repos/isaacdavis/fsnotify","forks_url":"https://api.github.com/repos/isaacdavis/fsnotify/forks","keys_url":"https://api.github.com/repos/isaacdavis/fsnotify/keys{/key_id}","collaborators_url":"https://api.github.com/repos/isaacdavis/fsnotify/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/isaacdavis/fsnotify/teams","hooks_url":"https://api.github.com/repos/isaacdavis/fsnotify/hooks","issue_events_url":"https://api.github.com/repos/isaacdavis/fsnotify/issues/events{/number}","events_url":"https://api.github.com/repos/isaacdavis/fsnotify/events","assignees_url":"https://api.github.com/repos/isaacdavis/fsnotify/assignees{/user}","branches_url":"https://api.github.com/repos/isaacdavis/fsnotify/branches{/branch}","tags_url":"https://api.github.com/repos/isaacdavis/fsnotify/tags","blobs_url":"https://api.github.com/repos/isaacdavis/fsnotify/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/isaacdavis/fsnotify/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/isaacdavis/fsnotify/git/refs{/sha}","trees_url":"https://api.github.com/repos/isaacdavis/fsnotify/git/trees{/sha}","statuses_url":"https://api.github.com/repos/isaacdavis/fsnotify/statuses/{sha}","languages_url":"https://api.github.com/repos/isaacdavis/fsnotify/languages","stargazers_url":"https://api.github.com/repos/isaacdavis/fsnotify/stargazers","contributors_url":"https://api.github.com/repos/isaacdavis/fsnotify/contributors","subscribers_url":"https://api.github.com/repos/isaacdavis/fsnotify/subscribers","subscription_url":"https://api.github.com/repos/isaacdavis/fsnotify/subscription","commits_url":"https://api.github.com/repos/isaacdavis/fsnotify/commits{/sha}","git_commits_url":"https://api.github.com/repos/isaacdavis/fsnotify/git/commits{/sha}","comments_url":"https://api.github.com/repos/isaacdavis/fsnotify/comments{/number}","issue_comment_url":"https://api.github.com/repos/isaacdavis/fsnotify/issues/comments{/number}","contents_url":"https://api.github.com/repos/isaacdavis/fsnotify/contents/{+path}","compare_url":"https://api.github.com/repos/isaacdavis/fsnotify/compare/{base}...{head}","merges_url":"https://api.github.com/repos/isaacdavis/fsnotify/merges","archive_url":"https://api.github.com/repos/isaacdavis/fsnotify/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/isaacdavis/fsnotify/downloads","issues_url":"https://api.github.com/repos/isaacdavis/fsnotify/issues{/number}","pulls_url":"https://api.github.com/repos/isaacdavis/fsnotify/pulls{/number}","milestones_url":"https://api.github.com/repos/isaacdavis/fsnotify/milestones{/number}","notifications_url":"https://api.github.com/repos/isaacdavis/fsnotify/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/isaacdavis/fsnotify/labels{/name}","releases_url":"https://api.github.com/repos/isaacdavis/fsnotify/releases{/id}","deployments_url":"https://api.github.com/repos/isaacdavis/fsnotify/deployments","created_at":"2018-08-28T18:56:46Z","updated_at":"2018-10-04T19:26:00Z","pushed_at":"2018-10-08T18:39:24Z","git_url":"git://github.com/isaacdavis/fsnotify.git","ssh_url":"[email protected]:isaacdavis/fsnotify.git","clone_url":"https://github.com/isaacdavis/fsnotify.git","svn_url":"https://github.com/isaacdavis/fsnotify","homepage":"https://fsnotify.org","size":365,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":1,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"fsnotify:master","ref":"master","sha":"ccc981bf80385c528a65fbfdd49bf2d8da22aa23","user":{"login":"fsnotify","id":8013877,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgwMTM4Nzc=","avatar_url":"https://avatars1.githubusercontent.com/u/8013877?v=4","gravatar_id":"","url":"https://api.github.com/users/fsnotify","html_url":"https://github.com/fsnotify","followers_url":"https://api.github.com/users/fsnotify/followers","following_url":"https://api.github.com/users/fsnotify/following{/other_user}","gists_url":"https://api.github.com/users/fsnotify/gists{/gist_id}","starred_url":"https://api.github.com/users/fsnotify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fsnotify/subscriptions","organizations_url":"https://api.github.com/users/fsnotify/orgs","repos_url":"https://api.github.com/users/fsnotify/repos","events_url":"https://api.github.com/users/fsnotify/events{/privacy}","received_events_url":"https://api.github.com/users/fsnotify/received_events","type":"Organization","site_admin":false},"repo":{"id":21306961,"node_id":"MDEwOlJlcG9zaXRvcnkyMTMwNjk2MQ==","name":"fsnotify","full_name":"fsnotify/fsnotify","private":false,"owner":{"login":"fsnotify","id":8013877,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgwMTM4Nzc=","avatar_url":"https://avatars1.githubusercontent.com/u/8013877?v=4","gravatar_id":"","url":"https://api.github.com/users/fsnotify","html_url":"https://github.com/fsnotify","followers_url":"https://api.github.com/users/fsnotify/followers","following_url":"https://api.github.com/users/fsnotify/following{/other_user}","gists_url":"https://api.github.com/users/fsnotify/gists{/gist_id}","starred_url":"https://api.github.com/users/fsnotify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fsnotify/subscriptions","organizations_url":"https://api.github.com/users/fsnotify/orgs","repos_url":"https://api.github.com/users/fsnotify/repos","events_url":"https://api.github.com/users/fsnotify/events{/privacy}","received_events_url":"https://api.github.com/users/fsnotify/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/fsnotify/fsnotify","description":"Cross-platform file system notifications for Go.","fork":false,"url":"https://api.github.com/repos/fsnotify/fsnotify","forks_url":"https://api.github.com/repos/fsnotify/fsnotify/forks","keys_url":"https://api.github.com/repos/fsnotify/fsnotify/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fsnotify/fsnotify/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fsnotify/fsnotify/teams","hooks_url":"https://api.github.com/repos/fsnotify/fsnotify/hooks","issue_events_url":"https://api.github.com/repos/fsnotify/fsnotify/issues/events{/number}","events_url":"https://api.github.com/repos/fsnotify/fsnotify/events","assignees_url":"https://api.github.com/repos/fsnotify/fsnotify/assignees{/user}","branches_url":"https://api.github.com/repos/fsnotify/fsnotify/branches{/branch}","tags_url":"https://api.github.com/repos/fsnotify/fsnotify/tags","blobs_url":"https://api.github.com/repos/fsnotify/fsnotify/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fsnotify/fsnotify/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fsnotify/fsnotify/git/refs{/sha}","trees_url":"https://api.github.com/repos/fsnotify/fsnotify/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fsnotify/fsnotify/statuses/{sha}","languages_url":"https://api.github.com/repos/fsnotify/fsnotify/languages","stargazers_url":"https://api.github.com/repos/fsnotify/fsnotify/stargazers","contributors_url":"https://api.github.com/repos/fsnotify/fsnotify/contributors","subscribers_url":"https://api.github.com/repos/fsnotify/fsnotify/subscribers","subscription_url":"https://api.github.com/repos/fsnotify/fsnotify/subscription","commits_url":"https://api.github.com/repos/fsnotify/fsnotify/commits{/sha}","git_commits_url":"https://api.github.com/repos/fsnotify/fsnotify/git/commits{/sha}","comments_url":"https://api.github.com/repos/fsnotify/fsnotify/comments{/number}","issue_comment_url":"https://api.github.com/repos/fsnotify/fsnotify/issues/comments{/number}","contents_url":"https://api.github.com/repos/fsnotify/fsnotify/contents/{+path}","compare_url":"https://api.github.com/repos/fsnotify/fsnotify/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fsnotify/fsnotify/merges","archive_url":"https://api.github.com/repos/fsnotify/fsnotify/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fsnotify/fsnotify/downloads","issues_url":"https://api.github.com/repos/fsnotify/fsnotify/issues{/number}","pulls_url":"https://api.github.com/repos/fsnotify/fsnotify/pulls{/number}","milestones_url":"https://api.github.com/repos/fsnotify/fsnotify/milestones{/number}","notifications_url":"https://api.github.com/repos/fsnotify/fsnotify/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fsnotify/fsnotify/labels{/name}","releases_url":"https://api.github.com/repos/fsnotify/fsnotify/releases{/id}","deployments_url":"https://api.github.com/repos/fsnotify/fsnotify/deployments","created_at":"2014-06-28T16:47:01Z","updated_at":"2018-10-08T07:15:16Z","pushed_at":"2018-10-08T18:39:26Z","git_url":"git://github.com/fsnotify/fsnotify.git","ssh_url":"[email protected]:fsnotify/fsnotify.git","clone_url":"https://github.com/fsnotify/fsnotify.git","svn_url":"https://github.com/fsnotify/fsnotify","homepage":"https://fsnotify.org","size":352,"stargazers_count":2711,"watchers_count":2711,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":315,"mirror_url":null,"archived":false,"open_issues_count":112,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":315,"open_issues":112,"watchers":2711,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fsnotify/fsnotify/pulls/263"},"html":{"href":"https://github.com/fsnotify/fsnotify/pull/263"},"issue":{"href":"https://api.github.com/repos/fsnotify/fsnotify/issues/263"},"comments":{"href":"https://api.github.com/repos/fsnotify/fsnotify/issues/263/comments"},"review_comments":{"href":"https://api.github.com/repos/fsnotify/fsnotify/pulls/263/comments"},"review_comment":{"href":"https://api.github.com/repos/fsnotify/fsnotify/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fsnotify/fsnotify/pulls/263/commits"},"statuses":{"href":"https://api.github.com/repos/fsnotify/fsnotify/statuses/0d807a62bd3474b76d4fe5ff292c31fd5ffd065d"}},"author_association":"NONE"}} | {
"id": 21306961,
"name": "fsnotify/fsnotify",
"url": "https://api.github.com/repos/fsnotify/fsnotify"
} | {
"id": 12563707,
"login": "isaacdavis",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/12563707?",
"url": "https://api.github.com/users/isaacdavis"
} | {
"id": 8013877,
"login": "fsnotify",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/8013877?",
"url": "https://api.github.com/orgs/fsnotify"
} | 2018-10-08T18:40:25 | 8386036073 | {"actor":{"display_login":"isaacdavis"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/drud/ddev/pulls/comments/201125409","pull_request_review_id":135566213,"id":201125409,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMTEyNTQwOQ==","diff_hunk":"@@ -41,6 +42,7 @@ func NewDrupalSettings() *DrupalSettings {\n \t\tDatabasePrefix: \"\",\n \t\tHashSalt: util.RandString(64),\n \t\tSignature: DdevFileSignature,\n+\t\tSyncDir: \"sites/default/files/sync\",","path":"pkg/ddevapp/drupal.go","position":12,"original_position":12,"commit_id":"56e0788da37caac079be328b77e342caa9d96c2b","original_commit_id":"56e0788da37caac079be328b77e342caa9d96c2b","user":{"login":"rfay","id":112444,"node_id":"MDQ6VXNlcjExMjQ0NA==","avatar_url":"https://avatars2.githubusercontent.com/u/112444?v=4","gravatar_id":"","url":"https://api.github.com/users/rfay","html_url":"https://github.com/rfay","followers_url":"https://api.github.com/users/rfay/followers","following_url":"https://api.github.com/users/rfay/following{/other_user}","gists_url":"https://api.github.com/users/rfay/gists{/gist_id}","starred_url":"https://api.github.com/users/rfay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rfay/subscriptions","organizations_url":"https://api.github.com/users/rfay/orgs","repos_url":"https://api.github.com/users/rfay/repos","events_url":"https://api.github.com/users/rfay/events{/privacy}","received_events_url":"https://api.github.com/users/rfay/received_events","type":"User","site_admin":false},"body":"This isn't correct, and results in loads of trouble. This should be relative to the docroot.","created_at":"2018-07-09T19:49:12Z","updated_at":"2018-07-09T19:49:46Z","html_url":"https://github.com/drud/ddev/pull/940#discussion_r201125409","pull_request_url":"https://api.github.com/repos/drud/ddev/pulls/940","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/drud/ddev/pulls/comments/201125409"},"html":{"href":"https://github.com/drud/ddev/pull/940#discussion_r201125409"},"pull_request":{"href":"https://api.github.com/repos/drud/ddev/pulls/940"}}},"pull_request":{"url":"https://api.github.com/repos/drud/ddev/pulls/940","id":197224923,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3MjI0OTIz","html_url":"https://github.com/drud/ddev/pull/940","diff_url":"https://github.com/drud/ddev/pull/940.diff","patch_url":"https://github.com/drud/ddev/pull/940.patch","issue_url":"https://api.github.com/repos/drud/ddev/issues/940","number":940,"state":"open","locked":false,"title":"Drupal8 settings improvements, fixes #504, fixes #680","user":{"login":"andrewfrench","id":3770127,"node_id":"MDQ6VXNlcjM3NzAxMjc=","avatar_url":"https://avatars1.githubusercontent.com/u/3770127?v=4","gravatar_id":"","url":"https://api.github.com/users/andrewfrench","html_url":"https://github.com/andrewfrench","followers_url":"https://api.github.com/users/andrewfrench/followers","following_url":"https://api.github.com/users/andrewfrench/following{/other_user}","gists_url":"https://api.github.com/users/andrewfrench/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewfrench/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewfrench/subscriptions","organizations_url":"https://api.github.com/users/andrewfrench/orgs","repos_url":"https://api.github.com/users/andrewfrench/repos","events_url":"https://api.github.com/users/andrewfrench/events{/privacy}","received_events_url":"https://api.github.com/users/andrewfrench/received_events","type":"User","site_admin":false},"body":"## The Problem/Issue/Bug:\r\nTwo minor settings issues that cause errors on a normal Drupal8 install.\r\n\r\n## How this PR Solves The Problem:\r\nThis PR adds two lines to the generated Drupal8 settings file: the first defines a trusted hosts pattern, the second defines the config sync directory. The existence of these settings lines prevent the errors outlined in #504 and #680.\r\n\r\n## Manual Testing Instructions:\r\n- Install a fresh Drupal8 site\r\n- Navigate to `<site>.ddev.local/admin/reports/status`\r\n- Ensure no errors are presented \r\n\r\n## Automated Testing Overview:\r\n<!-- Please provide an overview of tests introduced by this PR, or an explanation for why no tests are needed. -->\r\n\r\n## Related Issue Link(s):\r\n#504 \r\n#680 \r\n\r\n## Release/Deployment notes:\r\n<!-- Does this affect anything else, or are there ramifications for other code? Does anything have to be done on deployment? -->\r\n\r\n","created_at":"2018-06-25T20:21:47Z","updated_at":"2018-07-09T19:49:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3b5bb5286d28bd3f0b75a70ec6c698a1d3c9b14c","assignee":{"login":"andrewfrench","id":3770127,"node_id":"MDQ6VXNlcjM3NzAxMjc=","avatar_url":"https://avatars1.githubusercontent.com/u/3770127?v=4","gravatar_id":"","url":"https://api.github.com/users/andrewfrench","html_url":"https://github.com/andrewfrench","followers_url":"https://api.github.com/users/andrewfrench/followers","following_url":"https://api.github.com/users/andrewfrench/following{/other_user}","gists_url":"https://api.github.com/users/andrewfrench/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewfrench/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewfrench/subscriptions","organizations_url":"https://api.github.com/users/andrewfrench/orgs","repos_url":"https://api.github.com/users/andrewfrench/repos","events_url":"https://api.github.com/users/andrewfrench/events{/privacy}","received_events_url":"https://api.github.com/users/andrewfrench/received_events","type":"User","site_admin":false},"assignees":[{"login":"andrewfrench","id":3770127,"node_id":"MDQ6VXNlcjM3NzAxMjc=","avatar_url":"https://avatars1.githubusercontent.com/u/3770127?v=4","gravatar_id":"","url":"https://api.github.com/users/andrewfrench","html_url":"https://github.com/andrewfrench","followers_url":"https://api.github.com/users/andrewfrench/followers","following_url":"https://api.github.com/users/andrewfrench/following{/other_user}","gists_url":"https://api.github.com/users/andrewfrench/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewfrench/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewfrench/subscriptions","organizations_url":"https://api.github.com/users/andrewfrench/orgs","repos_url":"https://api.github.com/users/andrewfrench/repos","events_url":"https://api.github.com/users/andrewfrench/events{/privacy}","received_events_url":"https://api.github.com/users/andrewfrench/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/drud/ddev/milestones/8","html_url":"https://github.com/drud/ddev/milestone/8","labels_url":"https://api.github.com/repos/drud/ddev/milestones/8/labels","id":2510355,"node_id":"MDk6TWlsZXN0b25lMjUxMDM1NQ==","number":8,"title":"v1.0.0","description":"","creator":{"login":"rickmanelius","id":913096,"node_id":"MDQ6VXNlcjkxMzA5Ng==","avatar_url":"https://avatars1.githubusercontent.com/u/913096?v=4","gravatar_id":"","url":"https://api.github.com/users/rickmanelius","html_url":"https://github.com/rickmanelius","followers_url":"https://api.github.com/users/rickmanelius/followers","following_url":"https://api.github.com/users/rickmanelius/following{/other_user}","gists_url":"https://api.github.com/users/rickmanelius/gists{/gist_id}","starred_url":"https://api.github.com/users/rickmanelius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rickmanelius/subscriptions","organizations_url":"https://api.github.com/users/rickmanelius/orgs","repos_url":"https://api.github.com/users/rickmanelius/repos","events_url":"https://api.github.com/users/rickmanelius/events{/privacy}","received_events_url":"https://api.github.com/users/rickmanelius/received_events","type":"User","site_admin":false},"open_issues":5,"closed_issues":22,"state":"open","created_at":"2017-05-09T14:49:35Z","updated_at":"2018-07-09T15:52:59Z","due_on":"2018-07-19T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/drud/ddev/pulls/940/commits","review_comments_url":"https://api.github.com/repos/drud/ddev/pulls/940/comments","review_comment_url":"https://api.github.com/repos/drud/ddev/pulls/comments{/number}","comments_url":"https://api.github.com/repos/drud/ddev/issues/940/comments","statuses_url":"https://api.github.com/repos/drud/ddev/statuses/56e0788da37caac079be328b77e342caa9d96c2b","head":{"label":"andrewfrench:2018-06-21_trusted-hosts","ref":"2018-06-21_trusted-hosts","sha":"56e0788da37caac079be328b77e342caa9d96c2b","user":{"login":"andrewfrench","id":3770127,"node_id":"MDQ6VXNlcjM3NzAxMjc=","avatar_url":"https://avatars1.githubusercontent.com/u/3770127?v=4","gravatar_id":"","url":"https://api.github.com/users/andrewfrench","html_url":"https://github.com/andrewfrench","followers_url":"https://api.github.com/users/andrewfrench/followers","following_url":"https://api.github.com/users/andrewfrench/following{/other_user}","gists_url":"https://api.github.com/users/andrewfrench/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewfrench/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewfrench/subscriptions","organizations_url":"https://api.github.com/users/andrewfrench/orgs","repos_url":"https://api.github.com/users/andrewfrench/repos","events_url":"https://api.github.com/users/andrewfrench/events{/privacy}","received_events_url":"https://api.github.com/users/andrewfrench/received_events","type":"User","site_admin":false},"repo":{"id":134309990,"node_id":"MDEwOlJlcG9zaXRvcnkxMzQzMDk5OTA=","name":"ddev","full_name":"andrewfrench/ddev","owner":{"login":"andrewfrench","id":3770127,"node_id":"MDQ6VXNlcjM3NzAxMjc=","avatar_url":"https://avatars1.githubusercontent.com/u/3770127?v=4","gravatar_id":"","url":"https://api.github.com/users/andrewfrench","html_url":"https://github.com/andrewfrench","followers_url":"https://api.github.com/users/andrewfrench/followers","following_url":"https://api.github.com/users/andrewfrench/following{/other_user}","gists_url":"https://api.github.com/users/andrewfrench/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewfrench/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewfrench/subscriptions","organizations_url":"https://api.github.com/users/andrewfrench/orgs","repos_url":"https://api.github.com/users/andrewfrench/repos","events_url":"https://api.github.com/users/andrewfrench/events{/privacy}","received_events_url":"https://api.github.com/users/andrewfrench/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/andrewfrench/ddev","description":"DDEV-Local: a local PHP development environment system","fork":true,"url":"https://api.github.com/repos/andrewfrench/ddev","forks_url":"https://api.github.com/repos/andrewfrench/ddev/forks","keys_url":"https://api.github.com/repos/andrewfrench/ddev/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andrewfrench/ddev/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andrewfrench/ddev/teams","hooks_url":"https://api.github.com/repos/andrewfrench/ddev/hooks","issue_events_url":"https://api.github.com/repos/andrewfrench/ddev/issues/events{/number}","events_url":"https://api.github.com/repos/andrewfrench/ddev/events","assignees_url":"https://api.github.com/repos/andrewfrench/ddev/assignees{/user}","branches_url":"https://api.github.com/repos/andrewfrench/ddev/branches{/branch}","tags_url":"https://api.github.com/repos/andrewfrench/ddev/tags","blobs_url":"https://api.github.com/repos/andrewfrench/ddev/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andrewfrench/ddev/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andrewfrench/ddev/git/refs{/sha}","trees_url":"https://api.github.com/repos/andrewfrench/ddev/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andrewfrench/ddev/statuses/{sha}","languages_url":"https://api.github.com/repos/andrewfrench/ddev/languages","stargazers_url":"https://api.github.com/repos/andrewfrench/ddev/stargazers","contributors_url":"https://api.github.com/repos/andrewfrench/ddev/contributors","subscribers_url":"https://api.github.com/repos/andrewfrench/ddev/subscribers","subscription_url":"https://api.github.com/repos/andrewfrench/ddev/subscription","commits_url":"https://api.github.com/repos/andrewfrench/ddev/commits{/sha}","git_commits_url":"https://api.github.com/repos/andrewfrench/ddev/git/commits{/sha}","comments_url":"https://api.github.com/repos/andrewfrench/ddev/comments{/number}","issue_comment_url":"https://api.github.com/repos/andrewfrench/ddev/issues/comments{/number}","contents_url":"https://api.github.com/repos/andrewfrench/ddev/contents/{+path}","compare_url":"https://api.github.com/repos/andrewfrench/ddev/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andrewfrench/ddev/merges","archive_url":"https://api.github.com/repos/andrewfrench/ddev/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andrewfrench/ddev/downloads","issues_url":"https://api.github.com/repos/andrewfrench/ddev/issues{/number}","pulls_url":"https://api.github.com/repos/andrewfrench/ddev/pulls{/number}","milestones_url":"https://api.github.com/repos/andrewfrench/ddev/milestones{/number}","notifications_url":"https://api.github.com/repos/andrewfrench/ddev/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andrewfrench/ddev/labels{/name}","releases_url":"https://api.github.com/repos/andrewfrench/ddev/releases{/id}","deployments_url":"https://api.github.com/repos/andrewfrench/ddev/deployments","created_at":"2018-05-21T18:37:14Z","updated_at":"2018-07-09T16:22:35Z","pushed_at":"2018-07-09T16:22:34Z","git_url":"git://github.com/andrewfrench/ddev.git","ssh_url":"[email protected]:andrewfrench/ddev.git","clone_url":"https://github.com/andrewfrench/ddev.git","svn_url":"https://github.com/andrewfrench/ddev","homepage":"https://ddev.readthedocs.io","size":40383,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"drud:master","ref":"master","sha":"8f956767188ba249329f545cb3e1b6eda37921d9","user":{"login":"drud","id":8115114,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgxMTUxMTQ=","avatar_url":"https://avatars2.githubusercontent.com/u/8115114?v=4","gravatar_id":"","url":"https://api.github.com/users/drud","html_url":"https://github.com/drud","followers_url":"https://api.github.com/users/drud/followers","following_url":"https://api.github.com/users/drud/following{/other_user}","gists_url":"https://api.github.com/users/drud/gists{/gist_id}","starred_url":"https://api.github.com/users/drud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drud/subscriptions","organizations_url":"https://api.github.com/users/drud/orgs","repos_url":"https://api.github.com/users/drud/repos","events_url":"https://api.github.com/users/drud/events{/privacy}","received_events_url":"https://api.github.com/users/drud/received_events","type":"Organization","site_admin":false},"repo":{"id":80669528,"node_id":"MDEwOlJlcG9zaXRvcnk4MDY2OTUyOA==","name":"ddev","full_name":"drud/ddev","owner":{"login":"drud","id":8115114,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgxMTUxMTQ=","avatar_url":"https://avatars2.githubusercontent.com/u/8115114?v=4","gravatar_id":"","url":"https://api.github.com/users/drud","html_url":"https://github.com/drud","followers_url":"https://api.github.com/users/drud/followers","following_url":"https://api.github.com/users/drud/following{/other_user}","gists_url":"https://api.github.com/users/drud/gists{/gist_id}","starred_url":"https://api.github.com/users/drud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drud/subscriptions","organizations_url":"https://api.github.com/users/drud/orgs","repos_url":"https://api.github.com/users/drud/repos","events_url":"https://api.github.com/users/drud/events{/privacy}","received_events_url":"https://api.github.com/users/drud/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/drud/ddev","description":"DDEV-Local: a local PHP development environment system","fork":false,"url":"https://api.github.com/repos/drud/ddev","forks_url":"https://api.github.com/repos/drud/ddev/forks","keys_url":"https://api.github.com/repos/drud/ddev/keys{/key_id}","collaborators_url":"https://api.github.com/repos/drud/ddev/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/drud/ddev/teams","hooks_url":"https://api.github.com/repos/drud/ddev/hooks","issue_events_url":"https://api.github.com/repos/drud/ddev/issues/events{/number}","events_url":"https://api.github.com/repos/drud/ddev/events","assignees_url":"https://api.github.com/repos/drud/ddev/assignees{/user}","branches_url":"https://api.github.com/repos/drud/ddev/branches{/branch}","tags_url":"https://api.github.com/repos/drud/ddev/tags","blobs_url":"https://api.github.com/repos/drud/ddev/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/drud/ddev/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/drud/ddev/git/refs{/sha}","trees_url":"https://api.github.com/repos/drud/ddev/git/trees{/sha}","statuses_url":"https://api.github.com/repos/drud/ddev/statuses/{sha}","languages_url":"https://api.github.com/repos/drud/ddev/languages","stargazers_url":"https://api.github.com/repos/drud/ddev/stargazers","contributors_url":"https://api.github.com/repos/drud/ddev/contributors","subscribers_url":"https://api.github.com/repos/drud/ddev/subscribers","subscription_url":"https://api.github.com/repos/drud/ddev/subscription","commits_url":"https://api.github.com/repos/drud/ddev/commits{/sha}","git_commits_url":"https://api.github.com/repos/drud/ddev/git/commits{/sha}","comments_url":"https://api.github.com/repos/drud/ddev/comments{/number}","issue_comment_url":"https://api.github.com/repos/drud/ddev/issues/comments{/number}","contents_url":"https://api.github.com/repos/drud/ddev/contents/{+path}","compare_url":"https://api.github.com/repos/drud/ddev/compare/{base}...{head}","merges_url":"https://api.github.com/repos/drud/ddev/merges","archive_url":"https://api.github.com/repos/drud/ddev/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/drud/ddev/downloads","issues_url":"https://api.github.com/repos/drud/ddev/issues{/number}","pulls_url":"https://api.github.com/repos/drud/ddev/pulls{/number}","milestones_url":"https://api.github.com/repos/drud/ddev/milestones{/number}","notifications_url":"https://api.github.com/repos/drud/ddev/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/drud/ddev/labels{/name}","releases_url":"https://api.github.com/repos/drud/ddev/releases{/id}","deployments_url":"https://api.github.com/repos/drud/ddev/deployments","created_at":"2017-02-01T22:09:39Z","updated_at":"2018-07-09T15:52:22Z","pushed_at":"2018-07-09T19:05:39Z","git_url":"git://github.com/drud/ddev.git","ssh_url":"[email protected]:drud/ddev.git","clone_url":"https://github.com/drud/ddev.git","svn_url":"https://github.com/drud/ddev","homepage":"https://ddev.readthedocs.io","size":40347,"stargazers_count":189,"watchers_count":189,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":37,"mirror_url":null,"archived":false,"open_issues_count":100,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":37,"open_issues":100,"watchers":189,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/drud/ddev/pulls/940"},"html":{"href":"https://github.com/drud/ddev/pull/940"},"issue":{"href":"https://api.github.com/repos/drud/ddev/issues/940"},"comments":{"href":"https://api.github.com/repos/drud/ddev/issues/940/comments"},"review_comments":{"href":"https://api.github.com/repos/drud/ddev/pulls/940/comments"},"review_comment":{"href":"https://api.github.com/repos/drud/ddev/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/drud/ddev/pulls/940/commits"},"statuses":{"href":"https://api.github.com/repos/drud/ddev/statuses/56e0788da37caac079be328b77e342caa9d96c2b"}},"author_association":"MEMBER"}} | {
"id": 80669528,
"name": "drud/ddev",
"url": "https://api.github.com/repos/drud/ddev"
} | {
"id": 112444,
"login": "rfay",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/112444?",
"url": "https://api.github.com/users/rfay"
} | {
"id": 8115114,
"login": "drud",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/8115114?",
"url": "https://api.github.com/orgs/drud"
} | 2018-07-09T19:49:12 | 7939729435 | {"actor":{"display_login":"rfay"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/caskdata/cdap/pulls/comments/199982532","pull_request_review_id":134207485,"id":199982532,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5OTk4MjUzMg==","diff_hunk":"@@ -144,6 +142,7 @@ public void readDashboardDetail(FullHttpRequest request, HttpResponder responder\n result.addAll(getScheduledDashboardRecords(schedule, startTimeSecs, endTimeSecs));\n } catch (Exception e) {\n LOG.error(\"Failed to get scheduled program runs for schedule {}\", schedule, e);\n+ throw new RuntimeException(e);","path":"cdap-app-fabric/src/main/java/co/cask/cdap/gateway/handlers/OperationsDashboardHttpHandler.java","position":null,"original_position":20,"commit_id":"7b27aa59315c348b184f2865e5d2de7f6d931d33","original_commit_id":"7b27aa59315c348b184f2865e5d2de7f6d931d33","user":{"login":"poornachandra","id":3181212,"node_id":"MDQ6VXNlcjMxODEyMTI=","avatar_url":"https://avatars2.githubusercontent.com/u/3181212?v=4","gravatar_id":"","url":"https://api.github.com/users/poornachandra","html_url":"https://github.com/poornachandra","followers_url":"https://api.github.com/users/poornachandra/followers","following_url":"https://api.github.com/users/poornachandra/following{/other_user}","gists_url":"https://api.github.com/users/poornachandra/gists{/gist_id}","starred_url":"https://api.github.com/users/poornachandra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/poornachandra/subscriptions","organizations_url":"https://api.github.com/users/poornachandra/orgs","repos_url":"https://api.github.com/users/poornachandra/repos","events_url":"https://api.github.com/users/poornachandra/events{/privacy}","received_events_url":"https://api.github.com/users/poornachandra/received_events","type":"User","site_admin":false},"body":"Let's remove the lambda from here since the code needs to throw exception","created_at":"2018-07-04T00:26:25Z","updated_at":"2018-07-04T00:39:10Z","html_url":"https://github.com/caskdata/cdap/pull/10227#discussion_r199982532","pull_request_url":"https://api.github.com/repos/caskdata/cdap/pulls/10227","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/caskdata/cdap/pulls/comments/199982532"},"html":{"href":"https://github.com/caskdata/cdap/pull/10227#discussion_r199982532"},"pull_request":{"href":"https://api.github.com/repos/caskdata/cdap/pulls/10227"}}},"pull_request":{"url":"https://api.github.com/repos/caskdata/cdap/pulls/10227","id":196855189,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk2ODU1MTg5","html_url":"https://github.com/caskdata/cdap/pull/10227","diff_url":"https://github.com/caskdata/cdap/pull/10227.diff","patch_url":"https://github.com/caskdata/cdap/pull/10227.patch","issue_url":"https://api.github.com/repos/caskdata/cdap/issues/10227","number":10227,"state":"open","locked":false,"title":"[CDAP-13351] Get scheduled runs for Ops Dashboard","user":{"login":"maochf","id":5809268,"node_id":"MDQ6VXNlcjU4MDkyNjg=","avatar_url":"https://avatars3.githubusercontent.com/u/5809268?v=4","gravatar_id":"","url":"https://api.github.com/users/maochf","html_url":"https://github.com/maochf","followers_url":"https://api.github.com/users/maochf/followers","following_url":"https://api.github.com/users/maochf/following{/other_user}","gists_url":"https://api.github.com/users/maochf/gists{/gist_id}","starred_url":"https://api.github.com/users/maochf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maochf/subscriptions","organizations_url":"https://api.github.com/users/maochf/orgs","repos_url":"https://api.github.com/users/maochf/repos","events_url":"https://api.github.com/users/maochf/events{/privacy}","received_events_url":"https://api.github.com/users/maochf/received_events","type":"User","site_admin":false},"body":"https://issues.cask.co/browse/CDAP-13351\r\n\r\nThe PR is organized as 3 commits:\r\n1. Add methods to get schedules by namespace\r\n2. Add methods to get scheduled runs in a given time range\r\n3. Get scheduled runs in Ops Dashboard","created_at":"2018-06-22T22:03:45Z","updated_at":"2018-07-04T00:39:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a4a23171f6e74425d2bef0ea60d66a9e4085310a","assignee":{"login":"gsps1","id":1328150,"node_id":"MDQ6VXNlcjEzMjgxNTA=","avatar_url":"https://avatars0.githubusercontent.com/u/1328150?v=4","gravatar_id":"","url":"https://api.github.com/users/gsps1","html_url":"https://github.com/gsps1","followers_url":"https://api.github.com/users/gsps1/followers","following_url":"https://api.github.com/users/gsps1/following{/other_user}","gists_url":"https://api.github.com/users/gsps1/gists{/gist_id}","starred_url":"https://api.github.com/users/gsps1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gsps1/subscriptions","organizations_url":"https://api.github.com/users/gsps1/orgs","repos_url":"https://api.github.com/users/gsps1/repos","events_url":"https://api.github.com/users/gsps1/events{/privacy}","received_events_url":"https://api.github.com/users/gsps1/received_events","type":"User","site_admin":false},"assignees":[{"login":"gsps1","id":1328150,"node_id":"MDQ6VXNlcjEzMjgxNTA=","avatar_url":"https://avatars0.githubusercontent.com/u/1328150?v=4","gravatar_id":"","url":"https://api.github.com/users/gsps1","html_url":"https://github.com/gsps1","followers_url":"https://api.github.com/users/gsps1/followers","following_url":"https://api.github.com/users/gsps1/following{/other_user}","gists_url":"https://api.github.com/users/gsps1/gists{/gist_id}","starred_url":"https://api.github.com/users/gsps1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gsps1/subscriptions","organizations_url":"https://api.github.com/users/gsps1/orgs","repos_url":"https://api.github.com/users/gsps1/repos","events_url":"https://api.github.com/users/gsps1/events{/privacy}","received_events_url":"https://api.github.com/users/gsps1/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":673594855,"node_id":"MDU6TGFiZWw2NzM1OTQ4NTU=","url":"https://api.github.com/repos/caskdata/cdap/labels/5.0","name":"5.0","color":"ff6600","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/caskdata/cdap/pulls/10227/commits","review_comments_url":"https://api.github.com/repos/caskdata/cdap/pulls/10227/comments","review_comment_url":"https://api.github.com/repos/caskdata/cdap/pulls/comments{/number}","comments_url":"https://api.github.com/repos/caskdata/cdap/issues/10227/comments","statuses_url":"https://api.github.com/repos/caskdata/cdap/statuses/7b27aa59315c348b184f2865e5d2de7f6d931d33","head":{"label":"caskdata:feature/CDAP-13351-dashboard-future-run","ref":"feature/CDAP-13351-dashboard-future-run","sha":"7b27aa59315c348b184f2865e5d2de7f6d931d33","user":{"login":"caskdata","id":8123023,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgxMjMwMjM=","avatar_url":"https://avatars2.githubusercontent.com/u/8123023?v=4","gravatar_id":"","url":"https://api.github.com/users/caskdata","html_url":"https://github.com/caskdata","followers_url":"https://api.github.com/users/caskdata/followers","following_url":"https://api.github.com/users/caskdata/following{/other_user}","gists_url":"https://api.github.com/users/caskdata/gists{/gist_id}","starred_url":"https://api.github.com/users/caskdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caskdata/subscriptions","organizations_url":"https://api.github.com/users/caskdata/orgs","repos_url":"https://api.github.com/users/caskdata/repos","events_url":"https://api.github.com/users/caskdata/events{/privacy}","received_events_url":"https://api.github.com/users/caskdata/received_events","type":"Organization","site_admin":false},"repo":{"id":22542759,"node_id":"MDEwOlJlcG9zaXRvcnkyMjU0Mjc1OQ==","name":"cdap","full_name":"caskdata/cdap","owner":{"login":"caskdata","id":8123023,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgxMjMwMjM=","avatar_url":"https://avatars2.githubusercontent.com/u/8123023?v=4","gravatar_id":"","url":"https://api.github.com/users/caskdata","html_url":"https://github.com/caskdata","followers_url":"https://api.github.com/users/caskdata/followers","following_url":"https://api.github.com/users/caskdata/following{/other_user}","gists_url":"https://api.github.com/users/caskdata/gists{/gist_id}","starred_url":"https://api.github.com/users/caskdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caskdata/subscriptions","organizations_url":"https://api.github.com/users/caskdata/orgs","repos_url":"https://api.github.com/users/caskdata/repos","events_url":"https://api.github.com/users/caskdata/events{/privacy}","received_events_url":"https://api.github.com/users/caskdata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/caskdata/cdap","description":"A Unified Integration Platform - Cask Data Application Platform (CDAP)","fork":false,"url":"https://api.github.com/repos/caskdata/cdap","forks_url":"https://api.github.com/repos/caskdata/cdap/forks","keys_url":"https://api.github.com/repos/caskdata/cdap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/caskdata/cdap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/caskdata/cdap/teams","hooks_url":"https://api.github.com/repos/caskdata/cdap/hooks","issue_events_url":"https://api.github.com/repos/caskdata/cdap/issues/events{/number}","events_url":"https://api.github.com/repos/caskdata/cdap/events","assignees_url":"https://api.github.com/repos/caskdata/cdap/assignees{/user}","branches_url":"https://api.github.com/repos/caskdata/cdap/branches{/branch}","tags_url":"https://api.github.com/repos/caskdata/cdap/tags","blobs_url":"https://api.github.com/repos/caskdata/cdap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/caskdata/cdap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/caskdata/cdap/git/refs{/sha}","trees_url":"https://api.github.com/repos/caskdata/cdap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/caskdata/cdap/statuses/{sha}","languages_url":"https://api.github.com/repos/caskdata/cdap/languages","stargazers_url":"https://api.github.com/repos/caskdata/cdap/stargazers","contributors_url":"https://api.github.com/repos/caskdata/cdap/contributors","subscribers_url":"https://api.github.com/repos/caskdata/cdap/subscribers","subscription_url":"https://api.github.com/repos/caskdata/cdap/subscription","commits_url":"https://api.github.com/repos/caskdata/cdap/commits{/sha}","git_commits_url":"https://api.github.com/repos/caskdata/cdap/git/commits{/sha}","comments_url":"https://api.github.com/repos/caskdata/cdap/comments{/number}","issue_comment_url":"https://api.github.com/repos/caskdata/cdap/issues/comments{/number}","contents_url":"https://api.github.com/repos/caskdata/cdap/contents/{+path}","compare_url":"https://api.github.com/repos/caskdata/cdap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/caskdata/cdap/merges","archive_url":"https://api.github.com/repos/caskdata/cdap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/caskdata/cdap/downloads","issues_url":"https://api.github.com/repos/caskdata/cdap/issues{/number}","pulls_url":"https://api.github.com/repos/caskdata/cdap/pulls{/number}","milestones_url":"https://api.github.com/repos/caskdata/cdap/milestones{/number}","notifications_url":"https://api.github.com/repos/caskdata/cdap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/caskdata/cdap/labels{/name}","releases_url":"https://api.github.com/repos/caskdata/cdap/releases{/id}","deployments_url":"https://api.github.com/repos/caskdata/cdap/deployments","created_at":"2014-08-02T09:00:10Z","updated_at":"2018-07-04T00:25:05Z","pushed_at":"2018-07-04T00:25:08Z","git_url":"git://github.com/caskdata/cdap.git","ssh_url":"[email protected]:caskdata/cdap.git","clone_url":"https://github.com/caskdata/cdap.git","svn_url":"https://github.com/caskdata/cdap","homepage":"http://docs.cask.co/cdap","size":538372,"stargazers_count":236,"watchers_count":236,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":120,"mirror_url":null,"archived":false,"open_issues_count":18,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":120,"open_issues":18,"watchers":236,"default_branch":"develop"}},"base":{"label":"caskdata:develop","ref":"develop","sha":"89fb967d976ed3e8bb416d30a54c6c02453060eb","user":{"login":"caskdata","id":8123023,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgxMjMwMjM=","avatar_url":"https://avatars2.githubusercontent.com/u/8123023?v=4","gravatar_id":"","url":"https://api.github.com/users/caskdata","html_url":"https://github.com/caskdata","followers_url":"https://api.github.com/users/caskdata/followers","following_url":"https://api.github.com/users/caskdata/following{/other_user}","gists_url":"https://api.github.com/users/caskdata/gists{/gist_id}","starred_url":"https://api.github.com/users/caskdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caskdata/subscriptions","organizations_url":"https://api.github.com/users/caskdata/orgs","repos_url":"https://api.github.com/users/caskdata/repos","events_url":"https://api.github.com/users/caskdata/events{/privacy}","received_events_url":"https://api.github.com/users/caskdata/received_events","type":"Organization","site_admin":false},"repo":{"id":22542759,"node_id":"MDEwOlJlcG9zaXRvcnkyMjU0Mjc1OQ==","name":"cdap","full_name":"caskdata/cdap","owner":{"login":"caskdata","id":8123023,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgxMjMwMjM=","avatar_url":"https://avatars2.githubusercontent.com/u/8123023?v=4","gravatar_id":"","url":"https://api.github.com/users/caskdata","html_url":"https://github.com/caskdata","followers_url":"https://api.github.com/users/caskdata/followers","following_url":"https://api.github.com/users/caskdata/following{/other_user}","gists_url":"https://api.github.com/users/caskdata/gists{/gist_id}","starred_url":"https://api.github.com/users/caskdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caskdata/subscriptions","organizations_url":"https://api.github.com/users/caskdata/orgs","repos_url":"https://api.github.com/users/caskdata/repos","events_url":"https://api.github.com/users/caskdata/events{/privacy}","received_events_url":"https://api.github.com/users/caskdata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/caskdata/cdap","description":"A Unified Integration Platform - Cask Data Application Platform (CDAP)","fork":false,"url":"https://api.github.com/repos/caskdata/cdap","forks_url":"https://api.github.com/repos/caskdata/cdap/forks","keys_url":"https://api.github.com/repos/caskdata/cdap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/caskdata/cdap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/caskdata/cdap/teams","hooks_url":"https://api.github.com/repos/caskdata/cdap/hooks","issue_events_url":"https://api.github.com/repos/caskdata/cdap/issues/events{/number}","events_url":"https://api.github.com/repos/caskdata/cdap/events","assignees_url":"https://api.github.com/repos/caskdata/cdap/assignees{/user}","branches_url":"https://api.github.com/repos/caskdata/cdap/branches{/branch}","tags_url":"https://api.github.com/repos/caskdata/cdap/tags","blobs_url":"https://api.github.com/repos/caskdata/cdap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/caskdata/cdap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/caskdata/cdap/git/refs{/sha}","trees_url":"https://api.github.com/repos/caskdata/cdap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/caskdata/cdap/statuses/{sha}","languages_url":"https://api.github.com/repos/caskdata/cdap/languages","stargazers_url":"https://api.github.com/repos/caskdata/cdap/stargazers","contributors_url":"https://api.github.com/repos/caskdata/cdap/contributors","subscribers_url":"https://api.github.com/repos/caskdata/cdap/subscribers","subscription_url":"https://api.github.com/repos/caskdata/cdap/subscription","commits_url":"https://api.github.com/repos/caskdata/cdap/commits{/sha}","git_commits_url":"https://api.github.com/repos/caskdata/cdap/git/commits{/sha}","comments_url":"https://api.github.com/repos/caskdata/cdap/comments{/number}","issue_comment_url":"https://api.github.com/repos/caskdata/cdap/issues/comments{/number}","contents_url":"https://api.github.com/repos/caskdata/cdap/contents/{+path}","compare_url":"https://api.github.com/repos/caskdata/cdap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/caskdata/cdap/merges","archive_url":"https://api.github.com/repos/caskdata/cdap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/caskdata/cdap/downloads","issues_url":"https://api.github.com/repos/caskdata/cdap/issues{/number}","pulls_url":"https://api.github.com/repos/caskdata/cdap/pulls{/number}","milestones_url":"https://api.github.com/repos/caskdata/cdap/milestones{/number}","notifications_url":"https://api.github.com/repos/caskdata/cdap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/caskdata/cdap/labels{/name}","releases_url":"https://api.github.com/repos/caskdata/cdap/releases{/id}","deployments_url":"https://api.github.com/repos/caskdata/cdap/deployments","created_at":"2014-08-02T09:00:10Z","updated_at":"2018-07-04T00:25:05Z","pushed_at":"2018-07-04T00:25:08Z","git_url":"git://github.com/caskdata/cdap.git","ssh_url":"[email protected]:caskdata/cdap.git","clone_url":"https://github.com/caskdata/cdap.git","svn_url":"https://github.com/caskdata/cdap","homepage":"http://docs.cask.co/cdap","size":538372,"stargazers_count":236,"watchers_count":236,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":120,"mirror_url":null,"archived":false,"open_issues_count":18,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":120,"open_issues":18,"watchers":236,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/caskdata/cdap/pulls/10227"},"html":{"href":"https://github.com/caskdata/cdap/pull/10227"},"issue":{"href":"https://api.github.com/repos/caskdata/cdap/issues/10227"},"comments":{"href":"https://api.github.com/repos/caskdata/cdap/issues/10227/comments"},"review_comments":{"href":"https://api.github.com/repos/caskdata/cdap/pulls/10227/comments"},"review_comment":{"href":"https://api.github.com/repos/caskdata/cdap/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/caskdata/cdap/pulls/10227/commits"},"statuses":{"href":"https://api.github.com/repos/caskdata/cdap/statuses/7b27aa59315c348b184f2865e5d2de7f6d931d33"}},"author_association":"CONTRIBUTOR"}} | {
"id": 22542759,
"name": "caskdata/cdap",
"url": "https://api.github.com/repos/caskdata/cdap"
} | {
"id": 3181212,
"login": "poornachandra",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3181212?",
"url": "https://api.github.com/users/poornachandra"
} | {
"id": 8123023,
"login": "caskdata",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/8123023?",
"url": "https://api.github.com/orgs/caskdata"
} | 2018-07-04T00:26:25 | 7915644487 | {"actor":{"display_login":"poornachandra"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/abstracta/jmeter-bzm-plugins/pulls/comments/195523318","pull_request_review_id":128908238,"id":195523318,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NTUyMzMxOA==","diff_hunk":"@@ -203,27 +199,14 @@ public void onData(Stream stream, DataFrame frame, Callback callback) {\n \n if (frame.isEndStream()) {\n result.sampleEnd();\n- // Now collect the results into the HTTP2SampleResult:\n- // TODO Collect connect time and sent bytes\n- int responseLevel = Integer.parseInt(result.getResponseCode()) / 100;\n- switch (responseLevel) {\n- case 3:\n- break;\n- case 4:\n- result.setResponseMessage(HTTP2_RESPONSE_CODE_4);\n- // TODO message depends on the code number\n- break;\n- case 5:\n- break;\n- default:\n- result.setResponseMessage(HTTP2_RESPONSE_RECEIVED);\n- break;\n- }\n-\n result.setSuccessful(isSuccessCode(Integer.parseInt(result.getResponseCode())));\n result.setResponseData(this.responseBytes);\n- result.setPendingResponse(false);\n-\n+ if (!result.isSecondaryRequest()) {","path":"http2/src/main/java/com/blazemeter/jmeter/http2/sampler/HTTP2StreamHandler.java","position":196,"original_position":196,"commit_id":"fa9b042d77b8eb4a6a08594c61125b050efecbfa","original_commit_id":"fa9b042d77b8eb4a6a08594c61125b050efecbfa","user":{"login":"rabelenda","id":3179183,"node_id":"MDQ6VXNlcjMxNzkxODM=","avatar_url":"https://avatars3.githubusercontent.com/u/3179183?v=4","gravatar_id":"","url":"https://api.github.com/users/rabelenda","html_url":"https://github.com/rabelenda","followers_url":"https://api.github.com/users/rabelenda/followers","following_url":"https://api.github.com/users/rabelenda/following{/other_user}","gists_url":"https://api.github.com/users/rabelenda/gists{/gist_id}","starred_url":"https://api.github.com/users/rabelenda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rabelenda/subscriptions","organizations_url":"https://api.github.com/users/rabelenda/orgs","repos_url":"https://api.github.com/users/rabelenda/repos","events_url":"https://api.github.com/users/rabelenda/events{/privacy}","received_events_url":"https://api.github.com/users/rabelenda/received_events","type":"User","site_admin":false},"body":"same as before","created_at":"2018-06-14T18:18:14Z","updated_at":"2018-06-14T18:21:01Z","html_url":"https://github.com/abstracta/jmeter-bzm-plugins/pull/11#discussion_r195523318","pull_request_url":"https://api.github.com/repos/abstracta/jmeter-bzm-plugins/pulls/11","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/abstracta/jmeter-bzm-plugins/pulls/comments/195523318"},"html":{"href":"https://github.com/abstracta/jmeter-bzm-plugins/pull/11#discussion_r195523318"},"pull_request":{"href":"https://api.github.com/repos/abstracta/jmeter-bzm-plugins/pulls/11"}}},"pull_request":{"url":"https://api.github.com/repos/abstracta/jmeter-bzm-plugins/pulls/11","id":194408630,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0NDA4NjMw","html_url":"https://github.com/abstracta/jmeter-bzm-plugins/pull/11","diff_url":"https://github.com/abstracta/jmeter-bzm-plugins/pull/11.diff","patch_url":"https://github.com/abstracta/jmeter-bzm-plugins/pull/11.patch","issue_url":"https://api.github.com/repos/abstracta/jmeter-bzm-plugins/issues/11","number":11,"state":"open","locked":false,"title":"Process assertions and postprocesors","user":{"login":"sebastianlorenzo88","id":33757553,"node_id":"MDQ6VXNlcjMzNzU3NTUz","avatar_url":"https://avatars2.githubusercontent.com/u/33757553?v=4","gravatar_id":"","url":"https://api.github.com/users/sebastianlorenzo88","html_url":"https://github.com/sebastianlorenzo88","followers_url":"https://api.github.com/users/sebastianlorenzo88/followers","following_url":"https://api.github.com/users/sebastianlorenzo88/following{/other_user}","gists_url":"https://api.github.com/users/sebastianlorenzo88/gists{/gist_id}","starred_url":"https://api.github.com/users/sebastianlorenzo88/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebastianlorenzo88/subscriptions","organizations_url":"https://api.github.com/users/sebastianlorenzo88/orgs","repos_url":"https://api.github.com/users/sebastianlorenzo88/repos","events_url":"https://api.github.com/users/sebastianlorenzo88/events{/privacy}","received_events_url":"https://api.github.com/users/sebastianlorenzo88/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-06-12T21:09:35Z","updated_at":"2018-06-14T18:21:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bcca7557b332518ee743bb22eab7f668aaa5ee58","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/abstracta/jmeter-bzm-plugins/pulls/11/commits","review_comments_url":"https://api.github.com/repos/abstracta/jmeter-bzm-plugins/pulls/11/comments","review_comment_url":"https://api.github.com/repos/abstracta/jmeter-bzm-plugins/pulls/comments{/number}","comments_url":"https://api.github.com/repos/abstracta/jmeter-bzm-plugins/issues/11/comments","statuses_url":"https://api.github.com/repos/abstracta/jmeter-bzm-plugins/statuses/fa9b042d77b8eb4a6a08594c61125b050efecbfa","head":{"label":"abstracta:PROCESS_ASSERTIONS_AND_POSTPROCESORS","ref":"PROCESS_ASSERTIONS_AND_POSTPROCESORS","sha":"fa9b042d77b8eb4a6a08594c61125b050efecbfa","user":{"login":"abstracta","id":8450820,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg0NTA4MjA=","avatar_url":"https://avatars3.githubusercontent.com/u/8450820?v=4","gravatar_id":"","url":"https://api.github.com/users/abstracta","html_url":"https://github.com/abstracta","followers_url":"https://api.github.com/users/abstracta/followers","following_url":"https://api.github.com/users/abstracta/following{/other_user}","gists_url":"https://api.github.com/users/abstracta/gists{/gist_id}","starred_url":"https://api.github.com/users/abstracta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abstracta/subscriptions","organizations_url":"https://api.github.com/users/abstracta/orgs","repos_url":"https://api.github.com/users/abstracta/repos","events_url":"https://api.github.com/users/abstracta/events{/privacy}","received_events_url":"https://api.github.com/users/abstracta/received_events","type":"Organization","site_admin":false},"repo":{"id":96132390,"node_id":"MDEwOlJlcG9zaXRvcnk5NjEzMjM5MA==","name":"jmeter-bzm-plugins","full_name":"abstracta/jmeter-bzm-plugins","owner":{"login":"abstracta","id":8450820,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg0NTA4MjA=","avatar_url":"https://avatars3.githubusercontent.com/u/8450820?v=4","gravatar_id":"","url":"https://api.github.com/users/abstracta","html_url":"https://github.com/abstracta","followers_url":"https://api.github.com/users/abstracta/followers","following_url":"https://api.github.com/users/abstracta/following{/other_user}","gists_url":"https://api.github.com/users/abstracta/gists{/gist_id}","starred_url":"https://api.github.com/users/abstracta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abstracta/subscriptions","organizations_url":"https://api.github.com/users/abstracta/orgs","repos_url":"https://api.github.com/users/abstracta/repos","events_url":"https://api.github.com/users/abstracta/events{/privacy}","received_events_url":"https://api.github.com/users/abstracta/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/abstracta/jmeter-bzm-plugins","description":"Consolidated repository with all Enterprise plugins for JMeter","fork":true,"url":"https://api.github.com/repos/abstracta/jmeter-bzm-plugins","forks_url":"https://api.github.com/repos/abstracta/jmeter-bzm-plugins/forks","keys_url":"https://api.github.com/repos/abstracta/jmeter-bzm-plugins/keys{/key_id}","collaborators_url":"https://api.github.com/repos/abstracta/jmeter-bzm-plugins/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/abstracta/jmeter-bzm-plugins/teams","hooks_url":"https://api.github.com/repos/abstracta/jmeter-bzm-plugins/hooks","issue_events_url":"https://api.github.com/repos/abstracta/jmeter-bzm-plugins/issues/events{/number}","events_url":"https://api.github.com/repos/abstracta/jmeter-bzm-plugins/events","assignees_url":"https://api.github.com/repos/abstracta/jmeter-bzm-plugins/assignees{/user}","branches_url":"https://api.github.com/repos/abstracta/jmeter-bzm-plugins/branches{/branch}","tags_url":"https://api.github.com/repos/abstracta/jmeter-bzm-plugins/tags","blobs_url":"https://api.github.com/repos/abstracta/jmeter-bzm-plugins/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/abstracta/jmeter-bzm-plugins/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/abstracta/jmeter-bzm-plugins/git/refs{/sha}","trees_url":"https://api.github.com/repos/abstracta/jmeter-bzm-plugins/git/trees{/sha}","statuses_url":"https://api.github.com/repos/abstracta/jmeter-bzm-plugins/statuses/{sha}","languages_url":"https://api.github.com/repos/abstracta/jmeter-bzm-plugins/languages","stargazers_url":"https://api.github.com/repos/abstracta/jmeter-bzm-plugins/stargazers","contributors_url":"https://api.github.com/repos/abstracta/jmeter-bzm-plugins/contributors","subscribers_url":"https://api.github.com/repos/abstracta/jmeter-bzm-plugins/subscribers","subscription_url":"https://api.github.com/repos/abstracta/jmeter-bzm-plugins/subscription","commits_url":"https://api.github.com/repos/abstracta/jmeter-bzm-plugins/commits{/sha}","git_commits_url":"https://api.github.com/repos/abstracta/jmeter-bzm-plugins/git/commits{/sha}","comments_url":"https://api.github.com/repos/abstracta/jmeter-bzm-plugins/comments{/number}","issue_comment_url":"https://api.github.com/repos/abstracta/jmeter-bzm-plugins/issues/comments{/number}","contents_url":"https://api.github.com/repos/abstracta/jmeter-bzm-plugins/contents/{+path}","compare_url":"https://api.github.com/repos/abstracta/jmeter-bzm-plugins/compare/{base}...{head}","merges_url":"https://api.github.com/repos/abstracta/jmeter-bzm-plugins/merges","archive_url":"https://api.github.com/repos/abstracta/jmeter-bzm-plugins/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/abstracta/jmeter-bzm-plugins/downloads","issues_url":"https://api.github.com/repos/abstracta/jmeter-bzm-plugins/issues{/number}","pulls_url":"https://api.github.com/repos/abstracta/jmeter-bzm-plugins/pulls{/number}","milestones_url":"https://api.github.com/repos/abstracta/jmeter-bzm-plugins/milestones{/number}","notifications_url":"https://api.github.com/repos/abstracta/jmeter-bzm-plugins/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/abstracta/jmeter-bzm-plugins/labels{/name}","releases_url":"https://api.github.com/repos/abstracta/jmeter-bzm-plugins/releases{/id}","deployments_url":"https://api.github.com/repos/abstracta/jmeter-bzm-plugins/deployments","created_at":"2017-07-03T16:52:32Z","updated_at":"2018-06-13T18:09:35Z","pushed_at":"2018-06-14T18:07:10Z","git_url":"git://github.com/abstracta/jmeter-bzm-plugins.git","ssh_url":"[email protected]:abstracta/jmeter-bzm-plugins.git","clone_url":"https://github.com/abstracta/jmeter-bzm-plugins.git","svn_url":"https://github.com/abstracta/jmeter-bzm-plugins","homepage":"","size":2759,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"abstracta:master","ref":"master","sha":"ffdb0060f7f5104100748086e97723d3a9467637","user":{"login":"abstracta","id":8450820,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg0NTA4MjA=","avatar_url":"https://avatars3.githubusercontent.com/u/8450820?v=4","gravatar_id":"","url":"https://api.github.com/users/abstracta","html_url":"https://github.com/abstracta","followers_url":"https://api.github.com/users/abstracta/followers","following_url":"https://api.github.com/users/abstracta/following{/other_user}","gists_url":"https://api.github.com/users/abstracta/gists{/gist_id}","starred_url":"https://api.github.com/users/abstracta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abstracta/subscriptions","organizations_url":"https://api.github.com/users/abstracta/orgs","repos_url":"https://api.github.com/users/abstracta/repos","events_url":"https://api.github.com/users/abstracta/events{/privacy}","received_events_url":"https://api.github.com/users/abstracta/received_events","type":"Organization","site_admin":false},"repo":{"id":96132390,"node_id":"MDEwOlJlcG9zaXRvcnk5NjEzMjM5MA==","name":"jmeter-bzm-plugins","full_name":"abstracta/jmeter-bzm-plugins","owner":{"login":"abstracta","id":8450820,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg0NTA4MjA=","avatar_url":"https://avatars3.githubusercontent.com/u/8450820?v=4","gravatar_id":"","url":"https://api.github.com/users/abstracta","html_url":"https://github.com/abstracta","followers_url":"https://api.github.com/users/abstracta/followers","following_url":"https://api.github.com/users/abstracta/following{/other_user}","gists_url":"https://api.github.com/users/abstracta/gists{/gist_id}","starred_url":"https://api.github.com/users/abstracta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abstracta/subscriptions","organizations_url":"https://api.github.com/users/abstracta/orgs","repos_url":"https://api.github.com/users/abstracta/repos","events_url":"https://api.github.com/users/abstracta/events{/privacy}","received_events_url":"https://api.github.com/users/abstracta/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/abstracta/jmeter-bzm-plugins","description":"Consolidated repository with all Enterprise plugins for JMeter","fork":true,"url":"https://api.github.com/repos/abstracta/jmeter-bzm-plugins","forks_url":"https://api.github.com/repos/abstracta/jmeter-bzm-plugins/forks","keys_url":"https://api.github.com/repos/abstracta/jmeter-bzm-plugins/keys{/key_id}","collaborators_url":"https://api.github.com/repos/abstracta/jmeter-bzm-plugins/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/abstracta/jmeter-bzm-plugins/teams","hooks_url":"https://api.github.com/repos/abstracta/jmeter-bzm-plugins/hooks","issue_events_url":"https://api.github.com/repos/abstracta/jmeter-bzm-plugins/issues/events{/number}","events_url":"https://api.github.com/repos/abstracta/jmeter-bzm-plugins/events","assignees_url":"https://api.github.com/repos/abstracta/jmeter-bzm-plugins/assignees{/user}","branches_url":"https://api.github.com/repos/abstracta/jmeter-bzm-plugins/branches{/branch}","tags_url":"https://api.github.com/repos/abstracta/jmeter-bzm-plugins/tags","blobs_url":"https://api.github.com/repos/abstracta/jmeter-bzm-plugins/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/abstracta/jmeter-bzm-plugins/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/abstracta/jmeter-bzm-plugins/git/refs{/sha}","trees_url":"https://api.github.com/repos/abstracta/jmeter-bzm-plugins/git/trees{/sha}","statuses_url":"https://api.github.com/repos/abstracta/jmeter-bzm-plugins/statuses/{sha}","languages_url":"https://api.github.com/repos/abstracta/jmeter-bzm-plugins/languages","stargazers_url":"https://api.github.com/repos/abstracta/jmeter-bzm-plugins/stargazers","contributors_url":"https://api.github.com/repos/abstracta/jmeter-bzm-plugins/contributors","subscribers_url":"https://api.github.com/repos/abstracta/jmeter-bzm-plugins/subscribers","subscription_url":"https://api.github.com/repos/abstracta/jmeter-bzm-plugins/subscription","commits_url":"https://api.github.com/repos/abstracta/jmeter-bzm-plugins/commits{/sha}","git_commits_url":"https://api.github.com/repos/abstracta/jmeter-bzm-plugins/git/commits{/sha}","comments_url":"https://api.github.com/repos/abstracta/jmeter-bzm-plugins/comments{/number}","issue_comment_url":"https://api.github.com/repos/abstracta/jmeter-bzm-plugins/issues/comments{/number}","contents_url":"https://api.github.com/repos/abstracta/jmeter-bzm-plugins/contents/{+path}","compare_url":"https://api.github.com/repos/abstracta/jmeter-bzm-plugins/compare/{base}...{head}","merges_url":"https://api.github.com/repos/abstracta/jmeter-bzm-plugins/merges","archive_url":"https://api.github.com/repos/abstracta/jmeter-bzm-plugins/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/abstracta/jmeter-bzm-plugins/downloads","issues_url":"https://api.github.com/repos/abstracta/jmeter-bzm-plugins/issues{/number}","pulls_url":"https://api.github.com/repos/abstracta/jmeter-bzm-plugins/pulls{/number}","milestones_url":"https://api.github.com/repos/abstracta/jmeter-bzm-plugins/milestones{/number}","notifications_url":"https://api.github.com/repos/abstracta/jmeter-bzm-plugins/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/abstracta/jmeter-bzm-plugins/labels{/name}","releases_url":"https://api.github.com/repos/abstracta/jmeter-bzm-plugins/releases{/id}","deployments_url":"https://api.github.com/repos/abstracta/jmeter-bzm-plugins/deployments","created_at":"2017-07-03T16:52:32Z","updated_at":"2018-06-13T18:09:35Z","pushed_at":"2018-06-14T18:07:10Z","git_url":"git://github.com/abstracta/jmeter-bzm-plugins.git","ssh_url":"[email protected]:abstracta/jmeter-bzm-plugins.git","clone_url":"https://github.com/abstracta/jmeter-bzm-plugins.git","svn_url":"https://github.com/abstracta/jmeter-bzm-plugins","homepage":"","size":2759,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/abstracta/jmeter-bzm-plugins/pulls/11"},"html":{"href":"https://github.com/abstracta/jmeter-bzm-plugins/pull/11"},"issue":{"href":"https://api.github.com/repos/abstracta/jmeter-bzm-plugins/issues/11"},"comments":{"href":"https://api.github.com/repos/abstracta/jmeter-bzm-plugins/issues/11/comments"},"review_comments":{"href":"https://api.github.com/repos/abstracta/jmeter-bzm-plugins/pulls/11/comments"},"review_comment":{"href":"https://api.github.com/repos/abstracta/jmeter-bzm-plugins/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/abstracta/jmeter-bzm-plugins/pulls/11/commits"},"statuses":{"href":"https://api.github.com/repos/abstracta/jmeter-bzm-plugins/statuses/fa9b042d77b8eb4a6a08594c61125b050efecbfa"}},"author_association":"NONE"}} | {
"id": 96132390,
"name": "abstracta/jmeter-bzm-plugins",
"url": "https://api.github.com/repos/abstracta/jmeter-bzm-plugins"
} | {
"id": 3179183,
"login": "rabelenda",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3179183?",
"url": "https://api.github.com/users/rabelenda"
} | {
"id": 8450820,
"login": "abstracta",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/8450820?",
"url": "https://api.github.com/orgs/abstracta"
} | 2018-06-14T18:18:14 | 7826813002 | {"actor":{"display_login":"rabelenda"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/ofiwg/libfabric/pulls/comments/199776373","pull_request_review_id":133959681,"id":199776373,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5OTc3NjM3Mw==","diff_hunk":"@@ -287,28 +313,31 @@ rxm_msg_process_connreq(struct rxm_ep *rxm_ep, struct fi_info *msg_info,\n \n \trxm_conn->handle.remote_key = remote_cm_data->conn_id;\n \n-\tret = rxm_msg_ep_open(rxm_ep, msg_info, rxm_conn, handle);\n-\tif (ret)\n-\t\tgoto err2;\n-\n \tcm_data.conn_id = rxm_conn->handle.key;\n \tcm_data.proto.eager_size = htonll(cm_data.proto.eager_size);\n \n-\tret = fi_accept(rxm_conn->msg_ep, &cm_data, sizeof(cm_data));\n-\tif (ret) {\n-\t\tFI_WARN(&rxm_prov, FI_LOG_FABRIC,\n-\t\t\t\t\"Unable to accept incoming connection\\n\");\n+\tcmd_connreq = calloc(1, sizeof(struct util_cmap_cmd) +\n+\t\t\t\tsizeof(struct rxm_cmd_connreq_data));\n+\tif (!cmd_connreq)\n \t\tgoto err2;\n-\t}\n+\tcmd_connreq->type = UTIL_CMAP_CMD_INTERNAL;\n+\tconnreq_data.rxm_conn = rxm_conn;\n+\tconnreq_data.cm_data = cm_data;\n+\tmemcpy(cmd_connreq->data, &connreq_data, sizeof(connreq_data));","path":"prov/rxm/src/rxm_conn.c","position":244,"original_position":213,"commit_id":"bb67674df05ba6875d69df6c26b98493d46e13a6","original_commit_id":"9d0a29aa8aa75715789931af85bb58102ffbfd44","user":{"login":"dmitrygladkov","id":11650339,"node_id":"MDQ6VXNlcjExNjUwMzM5","avatar_url":"https://avatars1.githubusercontent.com/u/11650339?v=4","gravatar_id":"","url":"https://api.github.com/users/dmitrygladkov","html_url":"https://github.com/dmitrygladkov","followers_url":"https://api.github.com/users/dmitrygladkov/followers","following_url":"https://api.github.com/users/dmitrygladkov/following{/other_user}","gists_url":"https://api.github.com/users/dmitrygladkov/gists{/gist_id}","starred_url":"https://api.github.com/users/dmitrygladkov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmitrygladkov/subscriptions","organizations_url":"https://api.github.com/users/dmitrygladkov/orgs","repos_url":"https://api.github.com/users/dmitrygladkov/repos","events_url":"https://api.github.com/users/dmitrygladkov/events{/privacy}","received_events_url":"https://api.github.com/users/dmitrygladkov/received_events","type":"User","site_admin":false},"body":"Done","created_at":"2018-07-03T11:45:35Z","updated_at":"2018-07-03T11:45:35Z","html_url":"https://github.com/ofiwg/libfabric/pull/4212#discussion_r199776373","pull_request_url":"https://api.github.com/repos/ofiwg/libfabric/pulls/4212","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ofiwg/libfabric/pulls/comments/199776373"},"html":{"href":"https://github.com/ofiwg/libfabric/pull/4212#discussion_r199776373"},"pull_request":{"href":"https://api.github.com/repos/ofiwg/libfabric/pulls/4212"}},"in_reply_to_id":198609074},"pull_request":{"url":"https://api.github.com/repos/ofiwg/libfabric/pulls/4212","id":196506030,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk2NTA2MDMw","html_url":"https://github.com/ofiwg/libfabric/pull/4212","diff_url":"https://github.com/ofiwg/libfabric/pull/4212.diff","patch_url":"https://github.com/ofiwg/libfabric/pull/4212.patch","issue_url":"https://api.github.com/repos/ofiwg/libfabric/issues/4212","number":4212,"state":"open","locked":false,"title":"cmap, prov/rxm: Implement command queue","user":{"login":"dmitrygladkov","id":11650339,"node_id":"MDQ6VXNlcjExNjUwMzM5","avatar_url":"https://avatars1.githubusercontent.com/u/11650339?v=4","gravatar_id":"","url":"https://api.github.com/users/dmitrygladkov","html_url":"https://github.com/dmitrygladkov","followers_url":"https://api.github.com/users/dmitrygladkov/followers","following_url":"https://api.github.com/users/dmitrygladkov/following{/other_user}","gists_url":"https://api.github.com/users/dmitrygladkov/gists{/gist_id}","starred_url":"https://api.github.com/users/dmitrygladkov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmitrygladkov/subscriptions","organizations_url":"https://api.github.com/users/dmitrygladkov/orgs","repos_url":"https://api.github.com/users/dmitrygladkov/repos","events_url":"https://api.github.com/users/dmitrygladkov/events{/privacy}","received_events_url":"https://api.github.com/users/dmitrygladkov/received_events","type":"User","site_admin":false},"body":"The command queue is used to notify main thread that owns device(domain) resources to perform actions based on commands from CM AV::CMAP.\r\n\r\nSigned-off-by: Dmitry Gladkov <[email protected]>","created_at":"2018-06-21T16:18:05Z","updated_at":"2018-07-03T11:45:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0a82b5a77ea9e6bbf52e705438b53a859dfd8e7a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ofiwg/libfabric/pulls/4212/commits","review_comments_url":"https://api.github.com/repos/ofiwg/libfabric/pulls/4212/comments","review_comment_url":"https://api.github.com/repos/ofiwg/libfabric/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ofiwg/libfabric/issues/4212/comments","statuses_url":"https://api.github.com/repos/ofiwg/libfabric/statuses/bb67674df05ba6875d69df6c26b98493d46e13a6","head":{"label":"dmitrygladkov:rxm_dev","ref":"rxm_dev","sha":"bb67674df05ba6875d69df6c26b98493d46e13a6","user":{"login":"dmitrygladkov","id":11650339,"node_id":"MDQ6VXNlcjExNjUwMzM5","avatar_url":"https://avatars1.githubusercontent.com/u/11650339?v=4","gravatar_id":"","url":"https://api.github.com/users/dmitrygladkov","html_url":"https://github.com/dmitrygladkov","followers_url":"https://api.github.com/users/dmitrygladkov/followers","following_url":"https://api.github.com/users/dmitrygladkov/following{/other_user}","gists_url":"https://api.github.com/users/dmitrygladkov/gists{/gist_id}","starred_url":"https://api.github.com/users/dmitrygladkov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmitrygladkov/subscriptions","organizations_url":"https://api.github.com/users/dmitrygladkov/orgs","repos_url":"https://api.github.com/users/dmitrygladkov/repos","events_url":"https://api.github.com/users/dmitrygladkov/events{/privacy}","received_events_url":"https://api.github.com/users/dmitrygladkov/received_events","type":"User","site_admin":false},"repo":{"id":80634217,"node_id":"MDEwOlJlcG9zaXRvcnk4MDYzNDIxNw==","name":"libfabric","full_name":"dmitrygladkov/libfabric","owner":{"login":"dmitrygladkov","id":11650339,"node_id":"MDQ6VXNlcjExNjUwMzM5","avatar_url":"https://avatars1.githubusercontent.com/u/11650339?v=4","gravatar_id":"","url":"https://api.github.com/users/dmitrygladkov","html_url":"https://github.com/dmitrygladkov","followers_url":"https://api.github.com/users/dmitrygladkov/followers","following_url":"https://api.github.com/users/dmitrygladkov/following{/other_user}","gists_url":"https://api.github.com/users/dmitrygladkov/gists{/gist_id}","starred_url":"https://api.github.com/users/dmitrygladkov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmitrygladkov/subscriptions","organizations_url":"https://api.github.com/users/dmitrygladkov/orgs","repos_url":"https://api.github.com/users/dmitrygladkov/repos","events_url":"https://api.github.com/users/dmitrygladkov/events{/privacy}","received_events_url":"https://api.github.com/users/dmitrygladkov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dmitrygladkov/libfabric","description":"Open Fabric Interfaces","fork":true,"url":"https://api.github.com/repos/dmitrygladkov/libfabric","forks_url":"https://api.github.com/repos/dmitrygladkov/libfabric/forks","keys_url":"https://api.github.com/repos/dmitrygladkov/libfabric/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dmitrygladkov/libfabric/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dmitrygladkov/libfabric/teams","hooks_url":"https://api.github.com/repos/dmitrygladkov/libfabric/hooks","issue_events_url":"https://api.github.com/repos/dmitrygladkov/libfabric/issues/events{/number}","events_url":"https://api.github.com/repos/dmitrygladkov/libfabric/events","assignees_url":"https://api.github.com/repos/dmitrygladkov/libfabric/assignees{/user}","branches_url":"https://api.github.com/repos/dmitrygladkov/libfabric/branches{/branch}","tags_url":"https://api.github.com/repos/dmitrygladkov/libfabric/tags","blobs_url":"https://api.github.com/repos/dmitrygladkov/libfabric/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dmitrygladkov/libfabric/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dmitrygladkov/libfabric/git/refs{/sha}","trees_url":"https://api.github.com/repos/dmitrygladkov/libfabric/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dmitrygladkov/libfabric/statuses/{sha}","languages_url":"https://api.github.com/repos/dmitrygladkov/libfabric/languages","stargazers_url":"https://api.github.com/repos/dmitrygladkov/libfabric/stargazers","contributors_url":"https://api.github.com/repos/dmitrygladkov/libfabric/contributors","subscribers_url":"https://api.github.com/repos/dmitrygladkov/libfabric/subscribers","subscription_url":"https://api.github.com/repos/dmitrygladkov/libfabric/subscription","commits_url":"https://api.github.com/repos/dmitrygladkov/libfabric/commits{/sha}","git_commits_url":"https://api.github.com/repos/dmitrygladkov/libfabric/git/commits{/sha}","comments_url":"https://api.github.com/repos/dmitrygladkov/libfabric/comments{/number}","issue_comment_url":"https://api.github.com/repos/dmitrygladkov/libfabric/issues/comments{/number}","contents_url":"https://api.github.com/repos/dmitrygladkov/libfabric/contents/{+path}","compare_url":"https://api.github.com/repos/dmitrygladkov/libfabric/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dmitrygladkov/libfabric/merges","archive_url":"https://api.github.com/repos/dmitrygladkov/libfabric/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dmitrygladkov/libfabric/downloads","issues_url":"https://api.github.com/repos/dmitrygladkov/libfabric/issues{/number}","pulls_url":"https://api.github.com/repos/dmitrygladkov/libfabric/pulls{/number}","milestones_url":"https://api.github.com/repos/dmitrygladkov/libfabric/milestones{/number}","notifications_url":"https://api.github.com/repos/dmitrygladkov/libfabric/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dmitrygladkov/libfabric/labels{/name}","releases_url":"https://api.github.com/repos/dmitrygladkov/libfabric/releases{/id}","deployments_url":"https://api.github.com/repos/dmitrygladkov/libfabric/deployments","created_at":"2017-02-01T15:37:30Z","updated_at":"2018-06-14T20:42:00Z","pushed_at":"2018-07-02T17:09:39Z","git_url":"git://github.com/dmitrygladkov/libfabric.git","ssh_url":"[email protected]:dmitrygladkov/libfabric.git","clone_url":"https://github.com/dmitrygladkov/libfabric.git","svn_url":"https://github.com/dmitrygladkov/libfabric","homepage":"http://ofiwg.github.io/libfabric/","size":18750,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"ofiwg:master","ref":"master","sha":"975fccdb7e1faa76667d42983538ca90f035d8ea","user":{"login":"ofiwg","id":8459445,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg0NTk0NDU=","avatar_url":"https://avatars1.githubusercontent.com/u/8459445?v=4","gravatar_id":"","url":"https://api.github.com/users/ofiwg","html_url":"https://github.com/ofiwg","followers_url":"https://api.github.com/users/ofiwg/followers","following_url":"https://api.github.com/users/ofiwg/following{/other_user}","gists_url":"https://api.github.com/users/ofiwg/gists{/gist_id}","starred_url":"https://api.github.com/users/ofiwg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ofiwg/subscriptions","organizations_url":"https://api.github.com/users/ofiwg/orgs","repos_url":"https://api.github.com/users/ofiwg/repos","events_url":"https://api.github.com/users/ofiwg/events{/privacy}","received_events_url":"https://api.github.com/users/ofiwg/received_events","type":"Organization","site_admin":false},"repo":{"id":22996097,"node_id":"MDEwOlJlcG9zaXRvcnkyMjk5NjA5Nw==","name":"libfabric","full_name":"ofiwg/libfabric","owner":{"login":"ofiwg","id":8459445,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg0NTk0NDU=","avatar_url":"https://avatars1.githubusercontent.com/u/8459445?v=4","gravatar_id":"","url":"https://api.github.com/users/ofiwg","html_url":"https://github.com/ofiwg","followers_url":"https://api.github.com/users/ofiwg/followers","following_url":"https://api.github.com/users/ofiwg/following{/other_user}","gists_url":"https://api.github.com/users/ofiwg/gists{/gist_id}","starred_url":"https://api.github.com/users/ofiwg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ofiwg/subscriptions","organizations_url":"https://api.github.com/users/ofiwg/orgs","repos_url":"https://api.github.com/users/ofiwg/repos","events_url":"https://api.github.com/users/ofiwg/events{/privacy}","received_events_url":"https://api.github.com/users/ofiwg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ofiwg/libfabric","description":"Open Fabric Interfaces","fork":false,"url":"https://api.github.com/repos/ofiwg/libfabric","forks_url":"https://api.github.com/repos/ofiwg/libfabric/forks","keys_url":"https://api.github.com/repos/ofiwg/libfabric/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ofiwg/libfabric/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ofiwg/libfabric/teams","hooks_url":"https://api.github.com/repos/ofiwg/libfabric/hooks","issue_events_url":"https://api.github.com/repos/ofiwg/libfabric/issues/events{/number}","events_url":"https://api.github.com/repos/ofiwg/libfabric/events","assignees_url":"https://api.github.com/repos/ofiwg/libfabric/assignees{/user}","branches_url":"https://api.github.com/repos/ofiwg/libfabric/branches{/branch}","tags_url":"https://api.github.com/repos/ofiwg/libfabric/tags","blobs_url":"https://api.github.com/repos/ofiwg/libfabric/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ofiwg/libfabric/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ofiwg/libfabric/git/refs{/sha}","trees_url":"https://api.github.com/repos/ofiwg/libfabric/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ofiwg/libfabric/statuses/{sha}","languages_url":"https://api.github.com/repos/ofiwg/libfabric/languages","stargazers_url":"https://api.github.com/repos/ofiwg/libfabric/stargazers","contributors_url":"https://api.github.com/repos/ofiwg/libfabric/contributors","subscribers_url":"https://api.github.com/repos/ofiwg/libfabric/subscribers","subscription_url":"https://api.github.com/repos/ofiwg/libfabric/subscription","commits_url":"https://api.github.com/repos/ofiwg/libfabric/commits{/sha}","git_commits_url":"https://api.github.com/repos/ofiwg/libfabric/git/commits{/sha}","comments_url":"https://api.github.com/repos/ofiwg/libfabric/comments{/number}","issue_comment_url":"https://api.github.com/repos/ofiwg/libfabric/issues/comments{/number}","contents_url":"https://api.github.com/repos/ofiwg/libfabric/contents/{+path}","compare_url":"https://api.github.com/repos/ofiwg/libfabric/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ofiwg/libfabric/merges","archive_url":"https://api.github.com/repos/ofiwg/libfabric/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ofiwg/libfabric/downloads","issues_url":"https://api.github.com/repos/ofiwg/libfabric/issues{/number}","pulls_url":"https://api.github.com/repos/ofiwg/libfabric/pulls{/number}","milestones_url":"https://api.github.com/repos/ofiwg/libfabric/milestones{/number}","notifications_url":"https://api.github.com/repos/ofiwg/libfabric/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ofiwg/libfabric/labels{/name}","releases_url":"https://api.github.com/repos/ofiwg/libfabric/releases{/id}","deployments_url":"https://api.github.com/repos/ofiwg/libfabric/deployments","created_at":"2014-08-15T16:45:53Z","updated_at":"2018-07-02T23:02:33Z","pushed_at":"2018-07-03T00:52:17Z","git_url":"git://github.com/ofiwg/libfabric.git","ssh_url":"[email protected]:ofiwg/libfabric.git","clone_url":"https://github.com/ofiwg/libfabric.git","svn_url":"https://github.com/ofiwg/libfabric","homepage":"http://libfabric.org/","size":18729,"stargazers_count":151,"watchers_count":151,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":140,"mirror_url":null,"archived":false,"open_issues_count":128,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":140,"open_issues":128,"watchers":151,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ofiwg/libfabric/pulls/4212"},"html":{"href":"https://github.com/ofiwg/libfabric/pull/4212"},"issue":{"href":"https://api.github.com/repos/ofiwg/libfabric/issues/4212"},"comments":{"href":"https://api.github.com/repos/ofiwg/libfabric/issues/4212/comments"},"review_comments":{"href":"https://api.github.com/repos/ofiwg/libfabric/pulls/4212/comments"},"review_comment":{"href":"https://api.github.com/repos/ofiwg/libfabric/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ofiwg/libfabric/pulls/4212/commits"},"statuses":{"href":"https://api.github.com/repos/ofiwg/libfabric/statuses/bb67674df05ba6875d69df6c26b98493d46e13a6"}},"author_association":"MEMBER"}} | {
"id": 22996097,
"name": "ofiwg/libfabric",
"url": "https://api.github.com/repos/ofiwg/libfabric"
} | {
"id": 11650339,
"login": "dmitrygladkov",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/11650339?",
"url": "https://api.github.com/users/dmitrygladkov"
} | {
"id": 8459445,
"login": "ofiwg",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/8459445?",
"url": "https://api.github.com/orgs/ofiwg"
} | 2018-07-03T11:45:35 | 7912022520 | {"actor":{"display_login":"dmitrygladkov"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/ofiwg/libfabric/pulls/comments/226875403","pull_request_review_id":166798047,"id":226875403,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNjg3NTQwMw==","diff_hunk":"@@ -412,16 +412,23 @@ static inline int fi_ibv_get_qp_cap(struct ibv_context *ctx,\n \t\tgoto err1;\n \t}\n \n-\tqp_type = (info->ep_attr->type != FI_EP_DGRAM) ?\n-\t\t\t IBV_QPT_RC : IBV_QPT_UD;\n+#ifdef INCLUDE_VERBS_XRC\n+\tif (fi_ibv_using_xrc() && info->ep_attr->type == FI_EP_MSG)\n+\t\tqp_type = IBV_QPT_XRC_SEND;\n+\telse\n+#endif\n+\t\tqp_type = (info->ep_attr->type != FI_EP_DGRAM) ?\n+\t\t\t\t IBV_QPT_RC : IBV_QPT_UD;","path":"prov/verbs/src/verbs_info.c","position":12,"original_position":12,"commit_id":"085078283e366f890dd23212437ea44cf75c2997","original_commit_id":"3240a10f6c94ce32d73bc520b0bf7ccd1b67c27a","user":{"login":"swelch","id":7690298,"node_id":"MDQ6VXNlcjc2OTAyOTg=","avatar_url":"https://avatars0.githubusercontent.com/u/7690298?v=4","gravatar_id":"","url":"https://api.github.com/users/swelch","html_url":"https://github.com/swelch","followers_url":"https://api.github.com/users/swelch/followers","following_url":"https://api.github.com/users/swelch/following{/other_user}","gists_url":"https://api.github.com/users/swelch/gists{/gist_id}","starred_url":"https://api.github.com/users/swelch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swelch/subscriptions","organizations_url":"https://api.github.com/users/swelch/orgs","repos_url":"https://api.github.com/users/swelch/repos","events_url":"https://api.github.com/users/swelch/events{/privacy}","received_events_url":"https://api.github.com/users/swelch/received_events","type":"User","site_admin":false},"body":"@shefty - One possible option might be to add the field \"protocol\" to the \"struct verbs_ep_domain\" and then initialize a second instance for FI_EP_MSG setting the new \"protocol\" field to FI_PROTO_RDMA_CM_IB_XRC. The existing FI_EP_MSG could initialize \"protocol\" to FI_PROTO_RDMA_CM_IB_RC or leave it unspecified and set it when the associated info is being allocated and protocol was not specified. You would then end up with an infos that had an RC protocol based FI_MSG_EP, and if XRC was supported by hardware, an XRC protocol based FI_MSG_EP. This also provides a relatively easy check for the occurrence of XRC in the non-data code path (info->ep_attr->type == FI_EP_MSG && info->ep_attr->protocol == FI_PROTO_RDMA_CM_IB_XRC).","created_at":"2018-10-21T19:42:12Z","updated_at":"2018-10-21T19:42:13Z","html_url":"https://github.com/ofiwg/libfabric/pull/4524#discussion_r226875403","pull_request_url":"https://api.github.com/repos/ofiwg/libfabric/pulls/4524","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ofiwg/libfabric/pulls/comments/226875403"},"html":{"href":"https://github.com/ofiwg/libfabric/pull/4524#discussion_r226875403"},"pull_request":{"href":"https://api.github.com/repos/ofiwg/libfabric/pulls/4524"}},"in_reply_to_id":226396793},"pull_request":{"url":"https://api.github.com/repos/ofiwg/libfabric/pulls/4524","id":222906202,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyOTA2MjAy","html_url":"https://github.com/ofiwg/libfabric/pull/4524","diff_url":"https://github.com/ofiwg/libfabric/pull/4524.diff","patch_url":"https://github.com/ofiwg/libfabric/pull/4524.patch","issue_url":"https://api.github.com/repos/ofiwg/libfabric/issues/4524","number":4524,"state":"open","locked":false,"title":"prov/verbs: Initial experimental XRC EP_MSG implementation. (#36)","user":{"login":"swelch","id":7690298,"node_id":"MDQ6VXNlcjc2OTAyOTg=","avatar_url":"https://avatars0.githubusercontent.com/u/7690298?v=4","gravatar_id":"","url":"https://api.github.com/users/swelch","html_url":"https://github.com/swelch","followers_url":"https://api.github.com/users/swelch/followers","following_url":"https://api.github.com/users/swelch/following{/other_user}","gists_url":"https://api.github.com/users/swelch/gists{/gist_id}","starred_url":"https://api.github.com/users/swelch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swelch/subscriptions","organizations_url":"https://api.github.com/users/swelch/orgs","repos_url":"https://api.github.com/users/swelch/repos","events_url":"https://api.github.com/users/swelch/events{/privacy}","received_events_url":"https://api.github.com/users/swelch/received_events","type":"User","site_admin":false},"body":"@shefty - This initial implementation is intended to only support XRC usage when accompanied\r\nwith the OFI RXM provider. The code must be configured selectable by using \"--with-verbs-xrc\"\r\nand then explicitly enabled via the environment variables:\r\nFI_OFI_RXM_USE_SRX=1, FI_VERBS_USE_XRC=1.\r\n\r\nBoth XRC INI and TGT QP are shared between message endpoints. XRC INI QP are\r\nowned by the domain and shared between MSG endpoints within a process that\r\nis sending to endpoints on the same remote node. XRC TGT QP are owned\r\nby the linux kernel and are shared across processes by endpoints receiving\r\ndata from the endpoints within the same remote process.\r\n\r\nCurrently the RDMA CM is used for connection management setup only and\r\ncreates only the physical INI/TGT QP. Once connections are established,\r\nthe associated RDMA CM ID is destroyed. A subsequent UD method will be\r\nadded for sending disconnect notifications.\r\n\r\nThe data path shares the RC work posting/completion code; although a shared\r\nRX context must be used.\r\n\r\nNOTE: The use of this code requires a small 3 line patch that permits\r\nThe RDMA CM to be used with connected QP without managing the QP as was\r\nintended.\r\n\r\nprov/verbs: Add additional connection establishment debug\r\nprov/verbs: Fix INI QP connection key lookup\r\nprov/verbs: Cleanup comments and debug code\r\nprov/verbs: Correct NULL pointer check and convert assert to abort where needed\r\nprov/verbs: Add additional comments for clarity\r\nprov/verbs: Remove unused member peer_addr from endpoint\r\nprov/verbs: Rebase changes required due to introduction of cm_hdr\r\nprov/verbs: Fix clearing of RC QP struct to 0 when XRC is not configured\r\nprov/verbs: Remove stale dgram struct/prototype\r\n\r\nSigned-off-by: Steve Welch <[email protected]>","created_at":"2018-10-15T13:28:30Z","updated_at":"2018-10-21T19:42:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fbae650117866f99b10bc7e29d08f5a99e29f819","assignee":null,"assignees":[],"requested_reviewers":[{"login":"jswaro","id":10633422,"node_id":"MDQ6VXNlcjEwNjMzNDIy","avatar_url":"https://avatars2.githubusercontent.com/u/10633422?v=4","gravatar_id":"","url":"https://api.github.com/users/jswaro","html_url":"https://github.com/jswaro","followers_url":"https://api.github.com/users/jswaro/followers","following_url":"https://api.github.com/users/jswaro/following{/other_user}","gists_url":"https://api.github.com/users/jswaro/gists{/gist_id}","starred_url":"https://api.github.com/users/jswaro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jswaro/subscriptions","organizations_url":"https://api.github.com/users/jswaro/orgs","repos_url":"https://api.github.com/users/jswaro/repos","events_url":"https://api.github.com/users/jswaro/events{/privacy}","received_events_url":"https://api.github.com/users/jswaro/received_events","type":"User","site_admin":false},{"login":"dmitrygladkov","id":11650339,"node_id":"MDQ6VXNlcjExNjUwMzM5","avatar_url":"https://avatars1.githubusercontent.com/u/11650339?v=4","gravatar_id":"","url":"https://api.github.com/users/dmitrygladkov","html_url":"https://github.com/dmitrygladkov","followers_url":"https://api.github.com/users/dmitrygladkov/followers","following_url":"https://api.github.com/users/dmitrygladkov/following{/other_user}","gists_url":"https://api.github.com/users/dmitrygladkov/gists{/gist_id}","starred_url":"https://api.github.com/users/dmitrygladkov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmitrygladkov/subscriptions","organizations_url":"https://api.github.com/users/dmitrygladkov/orgs","repos_url":"https://api.github.com/users/dmitrygladkov/repos","events_url":"https://api.github.com/users/dmitrygladkov/events{/privacy}","received_events_url":"https://api.github.com/users/dmitrygladkov/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ofiwg/libfabric/pulls/4524/commits","review_comments_url":"https://api.github.com/repos/ofiwg/libfabric/pulls/4524/comments","review_comment_url":"https://api.github.com/repos/ofiwg/libfabric/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ofiwg/libfabric/issues/4524/comments","statuses_url":"https://api.github.com/repos/ofiwg/libfabric/statuses/085078283e366f890dd23212437ea44cf75c2997","head":{"label":"SystemFabricWorks:feature/xrc","ref":"feature/xrc","sha":"085078283e366f890dd23212437ea44cf75c2997","user":{"login":"SystemFabricWorks","id":7690024,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc2OTAwMjQ=","avatar_url":"https://avatars3.githubusercontent.com/u/7690024?v=4","gravatar_id":"","url":"https://api.github.com/users/SystemFabricWorks","html_url":"https://github.com/SystemFabricWorks","followers_url":"https://api.github.com/users/SystemFabricWorks/followers","following_url":"https://api.github.com/users/SystemFabricWorks/following{/other_user}","gists_url":"https://api.github.com/users/SystemFabricWorks/gists{/gist_id}","starred_url":"https://api.github.com/users/SystemFabricWorks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SystemFabricWorks/subscriptions","organizations_url":"https://api.github.com/users/SystemFabricWorks/orgs","repos_url":"https://api.github.com/users/SystemFabricWorks/repos","events_url":"https://api.github.com/users/SystemFabricWorks/events{/privacy}","received_events_url":"https://api.github.com/users/SystemFabricWorks/received_events","type":"Organization","site_admin":false},"repo":{"id":132017100,"node_id":"MDEwOlJlcG9zaXRvcnkxMzIwMTcxMDA=","name":"libfabric","full_name":"SystemFabricWorks/libfabric","private":false,"owner":{"login":"SystemFabricWorks","id":7690024,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc2OTAwMjQ=","avatar_url":"https://avatars3.githubusercontent.com/u/7690024?v=4","gravatar_id":"","url":"https://api.github.com/users/SystemFabricWorks","html_url":"https://github.com/SystemFabricWorks","followers_url":"https://api.github.com/users/SystemFabricWorks/followers","following_url":"https://api.github.com/users/SystemFabricWorks/following{/other_user}","gists_url":"https://api.github.com/users/SystemFabricWorks/gists{/gist_id}","starred_url":"https://api.github.com/users/SystemFabricWorks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SystemFabricWorks/subscriptions","organizations_url":"https://api.github.com/users/SystemFabricWorks/orgs","repos_url":"https://api.github.com/users/SystemFabricWorks/repos","events_url":"https://api.github.com/users/SystemFabricWorks/events{/privacy}","received_events_url":"https://api.github.com/users/SystemFabricWorks/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/SystemFabricWorks/libfabric","description":"SFW OFI Libfabric work (staging area)","fork":true,"url":"https://api.github.com/repos/SystemFabricWorks/libfabric","forks_url":"https://api.github.com/repos/SystemFabricWorks/libfabric/forks","keys_url":"https://api.github.com/repos/SystemFabricWorks/libfabric/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SystemFabricWorks/libfabric/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SystemFabricWorks/libfabric/teams","hooks_url":"https://api.github.com/repos/SystemFabricWorks/libfabric/hooks","issue_events_url":"https://api.github.com/repos/SystemFabricWorks/libfabric/issues/events{/number}","events_url":"https://api.github.com/repos/SystemFabricWorks/libfabric/events","assignees_url":"https://api.github.com/repos/SystemFabricWorks/libfabric/assignees{/user}","branches_url":"https://api.github.com/repos/SystemFabricWorks/libfabric/branches{/branch}","tags_url":"https://api.github.com/repos/SystemFabricWorks/libfabric/tags","blobs_url":"https://api.github.com/repos/SystemFabricWorks/libfabric/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SystemFabricWorks/libfabric/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SystemFabricWorks/libfabric/git/refs{/sha}","trees_url":"https://api.github.com/repos/SystemFabricWorks/libfabric/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SystemFabricWorks/libfabric/statuses/{sha}","languages_url":"https://api.github.com/repos/SystemFabricWorks/libfabric/languages","stargazers_url":"https://api.github.com/repos/SystemFabricWorks/libfabric/stargazers","contributors_url":"https://api.github.com/repos/SystemFabricWorks/libfabric/contributors","subscribers_url":"https://api.github.com/repos/SystemFabricWorks/libfabric/subscribers","subscription_url":"https://api.github.com/repos/SystemFabricWorks/libfabric/subscription","commits_url":"https://api.github.com/repos/SystemFabricWorks/libfabric/commits{/sha}","git_commits_url":"https://api.github.com/repos/SystemFabricWorks/libfabric/git/commits{/sha}","comments_url":"https://api.github.com/repos/SystemFabricWorks/libfabric/comments{/number}","issue_comment_url":"https://api.github.com/repos/SystemFabricWorks/libfabric/issues/comments{/number}","contents_url":"https://api.github.com/repos/SystemFabricWorks/libfabric/contents/{+path}","compare_url":"https://api.github.com/repos/SystemFabricWorks/libfabric/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SystemFabricWorks/libfabric/merges","archive_url":"https://api.github.com/repos/SystemFabricWorks/libfabric/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SystemFabricWorks/libfabric/downloads","issues_url":"https://api.github.com/repos/SystemFabricWorks/libfabric/issues{/number}","pulls_url":"https://api.github.com/repos/SystemFabricWorks/libfabric/pulls{/number}","milestones_url":"https://api.github.com/repos/SystemFabricWorks/libfabric/milestones{/number}","notifications_url":"https://api.github.com/repos/SystemFabricWorks/libfabric/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SystemFabricWorks/libfabric/labels{/name}","releases_url":"https://api.github.com/repos/SystemFabricWorks/libfabric/releases{/id}","deployments_url":"https://api.github.com/repos/SystemFabricWorks/libfabric/deployments","created_at":"2018-05-03T15:45:38Z","updated_at":"2018-10-21T05:29:17Z","pushed_at":"2018-10-21T17:04:09Z","git_url":"git://github.com/SystemFabricWorks/libfabric.git","ssh_url":"[email protected]:SystemFabricWorks/libfabric.git","clone_url":"https://github.com/SystemFabricWorks/libfabric.git","svn_url":"https://github.com/SystemFabricWorks/libfabric","homepage":"http://libfabric.org/","size":22871,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"ofiwg:master","ref":"master","sha":"9acdc04d91128788b9ffba17f75c9d31b1ffe24d","user":{"login":"ofiwg","id":8459445,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg0NTk0NDU=","avatar_url":"https://avatars1.githubusercontent.com/u/8459445?v=4","gravatar_id":"","url":"https://api.github.com/users/ofiwg","html_url":"https://github.com/ofiwg","followers_url":"https://api.github.com/users/ofiwg/followers","following_url":"https://api.github.com/users/ofiwg/following{/other_user}","gists_url":"https://api.github.com/users/ofiwg/gists{/gist_id}","starred_url":"https://api.github.com/users/ofiwg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ofiwg/subscriptions","organizations_url":"https://api.github.com/users/ofiwg/orgs","repos_url":"https://api.github.com/users/ofiwg/repos","events_url":"https://api.github.com/users/ofiwg/events{/privacy}","received_events_url":"https://api.github.com/users/ofiwg/received_events","type":"Organization","site_admin":false},"repo":{"id":22996097,"node_id":"MDEwOlJlcG9zaXRvcnkyMjk5NjA5Nw==","name":"libfabric","full_name":"ofiwg/libfabric","private":false,"owner":{"login":"ofiwg","id":8459445,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg0NTk0NDU=","avatar_url":"https://avatars1.githubusercontent.com/u/8459445?v=4","gravatar_id":"","url":"https://api.github.com/users/ofiwg","html_url":"https://github.com/ofiwg","followers_url":"https://api.github.com/users/ofiwg/followers","following_url":"https://api.github.com/users/ofiwg/following{/other_user}","gists_url":"https://api.github.com/users/ofiwg/gists{/gist_id}","starred_url":"https://api.github.com/users/ofiwg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ofiwg/subscriptions","organizations_url":"https://api.github.com/users/ofiwg/orgs","repos_url":"https://api.github.com/users/ofiwg/repos","events_url":"https://api.github.com/users/ofiwg/events{/privacy}","received_events_url":"https://api.github.com/users/ofiwg/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ofiwg/libfabric","description":"Open Fabric Interfaces","fork":false,"url":"https://api.github.com/repos/ofiwg/libfabric","forks_url":"https://api.github.com/repos/ofiwg/libfabric/forks","keys_url":"https://api.github.com/repos/ofiwg/libfabric/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ofiwg/libfabric/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ofiwg/libfabric/teams","hooks_url":"https://api.github.com/repos/ofiwg/libfabric/hooks","issue_events_url":"https://api.github.com/repos/ofiwg/libfabric/issues/events{/number}","events_url":"https://api.github.com/repos/ofiwg/libfabric/events","assignees_url":"https://api.github.com/repos/ofiwg/libfabric/assignees{/user}","branches_url":"https://api.github.com/repos/ofiwg/libfabric/branches{/branch}","tags_url":"https://api.github.com/repos/ofiwg/libfabric/tags","blobs_url":"https://api.github.com/repos/ofiwg/libfabric/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ofiwg/libfabric/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ofiwg/libfabric/git/refs{/sha}","trees_url":"https://api.github.com/repos/ofiwg/libfabric/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ofiwg/libfabric/statuses/{sha}","languages_url":"https://api.github.com/repos/ofiwg/libfabric/languages","stargazers_url":"https://api.github.com/repos/ofiwg/libfabric/stargazers","contributors_url":"https://api.github.com/repos/ofiwg/libfabric/contributors","subscribers_url":"https://api.github.com/repos/ofiwg/libfabric/subscribers","subscription_url":"https://api.github.com/repos/ofiwg/libfabric/subscription","commits_url":"https://api.github.com/repos/ofiwg/libfabric/commits{/sha}","git_commits_url":"https://api.github.com/repos/ofiwg/libfabric/git/commits{/sha}","comments_url":"https://api.github.com/repos/ofiwg/libfabric/comments{/number}","issue_comment_url":"https://api.github.com/repos/ofiwg/libfabric/issues/comments{/number}","contents_url":"https://api.github.com/repos/ofiwg/libfabric/contents/{+path}","compare_url":"https://api.github.com/repos/ofiwg/libfabric/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ofiwg/libfabric/merges","archive_url":"https://api.github.com/repos/ofiwg/libfabric/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ofiwg/libfabric/downloads","issues_url":"https://api.github.com/repos/ofiwg/libfabric/issues{/number}","pulls_url":"https://api.github.com/repos/ofiwg/libfabric/pulls{/number}","milestones_url":"https://api.github.com/repos/ofiwg/libfabric/milestones{/number}","notifications_url":"https://api.github.com/repos/ofiwg/libfabric/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ofiwg/libfabric/labels{/name}","releases_url":"https://api.github.com/repos/ofiwg/libfabric/releases{/id}","deployments_url":"https://api.github.com/repos/ofiwg/libfabric/deployments","created_at":"2014-08-15T16:45:53Z","updated_at":"2018-10-20T11:15:49Z","pushed_at":"2018-10-21T17:04:11Z","git_url":"git://github.com/ofiwg/libfabric.git","ssh_url":"[email protected]:ofiwg/libfabric.git","clone_url":"https://github.com/ofiwg/libfabric.git","svn_url":"https://github.com/ofiwg/libfabric","homepage":"http://libfabric.org/","size":22939,"stargazers_count":159,"watchers_count":159,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":151,"mirror_url":null,"archived":false,"open_issues_count":126,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":151,"open_issues":126,"watchers":159,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ofiwg/libfabric/pulls/4524"},"html":{"href":"https://github.com/ofiwg/libfabric/pull/4524"},"issue":{"href":"https://api.github.com/repos/ofiwg/libfabric/issues/4524"},"comments":{"href":"https://api.github.com/repos/ofiwg/libfabric/issues/4524/comments"},"review_comments":{"href":"https://api.github.com/repos/ofiwg/libfabric/pulls/4524/comments"},"review_comment":{"href":"https://api.github.com/repos/ofiwg/libfabric/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ofiwg/libfabric/pulls/4524/commits"},"statuses":{"href":"https://api.github.com/repos/ofiwg/libfabric/statuses/085078283e366f890dd23212437ea44cf75c2997"}},"author_association":"CONTRIBUTOR"}} | {
"id": 22996097,
"name": "ofiwg/libfabric",
"url": "https://api.github.com/repos/ofiwg/libfabric"
} | {
"id": 7690298,
"login": "swelch",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7690298?",
"url": "https://api.github.com/users/swelch"
} | {
"id": 8459445,
"login": "ofiwg",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/8459445?",
"url": "https://api.github.com/orgs/ofiwg"
} | 2018-10-21T19:42:12 | 8455952588 | {"actor":{"display_login":"swelch"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/rpm-software-management/libdnf/pulls/comments/183349155","pull_request_review_id":114328480,"id":183349155,"diff_hunk":"@@ -0,0 +1,28 @@\n+\n+#ifndef LIBDNF_MODULEPROFILE_HPP\n+#define LIBDNF_MODULEPROFILE_HPP\n+\n+\n+#include \"Profile.hpp\"\n+\n+#include <memory>\n+#include <modulemd/modulemd.h>","path":"libdnf/module/modulemd/profile/ModuleProfile.hpp","position":9,"original_position":9,"commit_id":"3b5b67409c909d9039c5a0890f62a94e8254083a","original_commit_id":"3b5b67409c909d9039c5a0890f62a94e8254083a","user":{"login":"ignatenkobrain","id":2866862,"avatar_url":"https://avatars1.githubusercontent.com/u/2866862?v=4","gravatar_id":"","url":"https://api.github.com/users/ignatenkobrain","html_url":"https://github.com/ignatenkobrain","followers_url":"https://api.github.com/users/ignatenkobrain/followers","following_url":"https://api.github.com/users/ignatenkobrain/following{/other_user}","gists_url":"https://api.github.com/users/ignatenkobrain/gists{/gist_id}","starred_url":"https://api.github.com/users/ignatenkobrain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ignatenkobrain/subscriptions","organizations_url":"https://api.github.com/users/ignatenkobrain/orgs","repos_url":"https://api.github.com/users/ignatenkobrain/repos","events_url":"https://api.github.com/users/ignatenkobrain/events{/privacy}","received_events_url":"https://api.github.com/users/ignatenkobrain/received_events","type":"User","site_admin":false},"body":"should be just `modulemd.h`","created_at":"2018-04-23T10:41:01Z","updated_at":"2018-04-23T10:41:02Z","html_url":"https://github.com/rpm-software-management/libdnf/pull/427#discussion_r183349155","pull_request_url":"https://api.github.com/repos/rpm-software-management/libdnf/pulls/427","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/rpm-software-management/libdnf/pulls/comments/183349155"},"html":{"href":"https://github.com/rpm-software-management/libdnf/pull/427#discussion_r183349155"},"pull_request":{"href":"https://api.github.com/repos/rpm-software-management/libdnf/pulls/427"}}},"pull_request":{"url":"https://api.github.com/repos/rpm-software-management/libdnf/pulls/427","id":176440227,"html_url":"https://github.com/rpm-software-management/libdnf/pull/427","diff_url":"https://github.com/rpm-software-management/libdnf/pull/427.diff","patch_url":"https://github.com/rpm-software-management/libdnf/pull/427.patch","issue_url":"https://api.github.com/repos/rpm-software-management/libdnf/issues/427","number":427,"state":"open","locked":false,"title":"WIP: [modularity] support for modularity","user":{"login":"mhatina","id":7964232,"avatar_url":"https://avatars1.githubusercontent.com/u/7964232?v=4","gravatar_id":"","url":"https://api.github.com/users/mhatina","html_url":"https://github.com/mhatina","followers_url":"https://api.github.com/users/mhatina/followers","following_url":"https://api.github.com/users/mhatina/following{/other_user}","gists_url":"https://api.github.com/users/mhatina/gists{/gist_id}","starred_url":"https://api.github.com/users/mhatina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhatina/subscriptions","organizations_url":"https://api.github.com/users/mhatina/orgs","repos_url":"https://api.github.com/users/mhatina/repos","events_url":"https://api.github.com/users/mhatina/events{/privacy}","received_events_url":"https://api.github.com/users/mhatina/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-03-21T11:00:10Z","updated_at":"2018-04-23T10:41:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"605061f22a1296f0b0b0c2b38f3ecd2db4ed72e5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/rpm-software-management/libdnf/pulls/427/commits","review_comments_url":"https://api.github.com/repos/rpm-software-management/libdnf/pulls/427/comments","review_comment_url":"https://api.github.com/repos/rpm-software-management/libdnf/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rpm-software-management/libdnf/issues/427/comments","statuses_url":"https://api.github.com/repos/rpm-software-management/libdnf/statuses/3b5b67409c909d9039c5a0890f62a94e8254083a","head":{"label":"mhatina:modularity","ref":"modularity","sha":"3b5b67409c909d9039c5a0890f62a94e8254083a","user":{"login":"mhatina","id":7964232,"avatar_url":"https://avatars1.githubusercontent.com/u/7964232?v=4","gravatar_id":"","url":"https://api.github.com/users/mhatina","html_url":"https://github.com/mhatina","followers_url":"https://api.github.com/users/mhatina/followers","following_url":"https://api.github.com/users/mhatina/following{/other_user}","gists_url":"https://api.github.com/users/mhatina/gists{/gist_id}","starred_url":"https://api.github.com/users/mhatina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhatina/subscriptions","organizations_url":"https://api.github.com/users/mhatina/orgs","repos_url":"https://api.github.com/users/mhatina/repos","events_url":"https://api.github.com/users/mhatina/events{/privacy}","received_events_url":"https://api.github.com/users/mhatina/received_events","type":"User","site_admin":false},"repo":{"id":100239233,"name":"libdnf","full_name":"mhatina/libdnf","owner":{"login":"mhatina","id":7964232,"avatar_url":"https://avatars1.githubusercontent.com/u/7964232?v=4","gravatar_id":"","url":"https://api.github.com/users/mhatina","html_url":"https://github.com/mhatina","followers_url":"https://api.github.com/users/mhatina/followers","following_url":"https://api.github.com/users/mhatina/following{/other_user}","gists_url":"https://api.github.com/users/mhatina/gists{/gist_id}","starred_url":"https://api.github.com/users/mhatina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhatina/subscriptions","organizations_url":"https://api.github.com/users/mhatina/orgs","repos_url":"https://api.github.com/users/mhatina/repos","events_url":"https://api.github.com/users/mhatina/events{/privacy}","received_events_url":"https://api.github.com/users/mhatina/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mhatina/libdnf","description":"Simple package manager built on top of hawkey and librepo","fork":true,"url":"https://api.github.com/repos/mhatina/libdnf","forks_url":"https://api.github.com/repos/mhatina/libdnf/forks","keys_url":"https://api.github.com/repos/mhatina/libdnf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mhatina/libdnf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mhatina/libdnf/teams","hooks_url":"https://api.github.com/repos/mhatina/libdnf/hooks","issue_events_url":"https://api.github.com/repos/mhatina/libdnf/issues/events{/number}","events_url":"https://api.github.com/repos/mhatina/libdnf/events","assignees_url":"https://api.github.com/repos/mhatina/libdnf/assignees{/user}","branches_url":"https://api.github.com/repos/mhatina/libdnf/branches{/branch}","tags_url":"https://api.github.com/repos/mhatina/libdnf/tags","blobs_url":"https://api.github.com/repos/mhatina/libdnf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mhatina/libdnf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mhatina/libdnf/git/refs{/sha}","trees_url":"https://api.github.com/repos/mhatina/libdnf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mhatina/libdnf/statuses/{sha}","languages_url":"https://api.github.com/repos/mhatina/libdnf/languages","stargazers_url":"https://api.github.com/repos/mhatina/libdnf/stargazers","contributors_url":"https://api.github.com/repos/mhatina/libdnf/contributors","subscribers_url":"https://api.github.com/repos/mhatina/libdnf/subscribers","subscription_url":"https://api.github.com/repos/mhatina/libdnf/subscription","commits_url":"https://api.github.com/repos/mhatina/libdnf/commits{/sha}","git_commits_url":"https://api.github.com/repos/mhatina/libdnf/git/commits{/sha}","comments_url":"https://api.github.com/repos/mhatina/libdnf/comments{/number}","issue_comment_url":"https://api.github.com/repos/mhatina/libdnf/issues/comments{/number}","contents_url":"https://api.github.com/repos/mhatina/libdnf/contents/{+path}","compare_url":"https://api.github.com/repos/mhatina/libdnf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mhatina/libdnf/merges","archive_url":"https://api.github.com/repos/mhatina/libdnf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mhatina/libdnf/downloads","issues_url":"https://api.github.com/repos/mhatina/libdnf/issues{/number}","pulls_url":"https://api.github.com/repos/mhatina/libdnf/pulls{/number}","milestones_url":"https://api.github.com/repos/mhatina/libdnf/milestones{/number}","notifications_url":"https://api.github.com/repos/mhatina/libdnf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mhatina/libdnf/labels{/name}","releases_url":"https://api.github.com/repos/mhatina/libdnf/releases{/id}","deployments_url":"https://api.github.com/repos/mhatina/libdnf/deployments","created_at":"2017-08-14T07:14:49Z","updated_at":"2017-08-14T07:14:51Z","pushed_at":"2018-04-23T07:39:45Z","git_url":"git://github.com/mhatina/libdnf.git","ssh_url":"[email protected]:mhatina/libdnf.git","clone_url":"https://github.com/mhatina/libdnf.git","svn_url":"https://github.com/mhatina/libdnf","homepage":null,"size":5900,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rpm-software-management:master","ref":"master","sha":"f8aed091b0bda10b67a01d54d98a65e749cdd254","user":{"login":"rpm-software-management","id":8504469,"avatar_url":"https://avatars3.githubusercontent.com/u/8504469?v=4","gravatar_id":"","url":"https://api.github.com/users/rpm-software-management","html_url":"https://github.com/rpm-software-management","followers_url":"https://api.github.com/users/rpm-software-management/followers","following_url":"https://api.github.com/users/rpm-software-management/following{/other_user}","gists_url":"https://api.github.com/users/rpm-software-management/gists{/gist_id}","starred_url":"https://api.github.com/users/rpm-software-management/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rpm-software-management/subscriptions","organizations_url":"https://api.github.com/users/rpm-software-management/orgs","repos_url":"https://api.github.com/users/rpm-software-management/repos","events_url":"https://api.github.com/users/rpm-software-management/events{/privacy}","received_events_url":"https://api.github.com/users/rpm-software-management/received_events","type":"Organization","site_admin":false},"repo":{"id":18206372,"name":"libdnf","full_name":"rpm-software-management/libdnf","owner":{"login":"rpm-software-management","id":8504469,"avatar_url":"https://avatars3.githubusercontent.com/u/8504469?v=4","gravatar_id":"","url":"https://api.github.com/users/rpm-software-management","html_url":"https://github.com/rpm-software-management","followers_url":"https://api.github.com/users/rpm-software-management/followers","following_url":"https://api.github.com/users/rpm-software-management/following{/other_user}","gists_url":"https://api.github.com/users/rpm-software-management/gists{/gist_id}","starred_url":"https://api.github.com/users/rpm-software-management/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rpm-software-management/subscriptions","organizations_url":"https://api.github.com/users/rpm-software-management/orgs","repos_url":"https://api.github.com/users/rpm-software-management/repos","events_url":"https://api.github.com/users/rpm-software-management/events{/privacy}","received_events_url":"https://api.github.com/users/rpm-software-management/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rpm-software-management/libdnf","description":"Software management library.","fork":false,"url":"https://api.github.com/repos/rpm-software-management/libdnf","forks_url":"https://api.github.com/repos/rpm-software-management/libdnf/forks","keys_url":"https://api.github.com/repos/rpm-software-management/libdnf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rpm-software-management/libdnf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rpm-software-management/libdnf/teams","hooks_url":"https://api.github.com/repos/rpm-software-management/libdnf/hooks","issue_events_url":"https://api.github.com/repos/rpm-software-management/libdnf/issues/events{/number}","events_url":"https://api.github.com/repos/rpm-software-management/libdnf/events","assignees_url":"https://api.github.com/repos/rpm-software-management/libdnf/assignees{/user}","branches_url":"https://api.github.com/repos/rpm-software-management/libdnf/branches{/branch}","tags_url":"https://api.github.com/repos/rpm-software-management/libdnf/tags","blobs_url":"https://api.github.com/repos/rpm-software-management/libdnf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rpm-software-management/libdnf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rpm-software-management/libdnf/git/refs{/sha}","trees_url":"https://api.github.com/repos/rpm-software-management/libdnf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rpm-software-management/libdnf/statuses/{sha}","languages_url":"https://api.github.com/repos/rpm-software-management/libdnf/languages","stargazers_url":"https://api.github.com/repos/rpm-software-management/libdnf/stargazers","contributors_url":"https://api.github.com/repos/rpm-software-management/libdnf/contributors","subscribers_url":"https://api.github.com/repos/rpm-software-management/libdnf/subscribers","subscription_url":"https://api.github.com/repos/rpm-software-management/libdnf/subscription","commits_url":"https://api.github.com/repos/rpm-software-management/libdnf/commits{/sha}","git_commits_url":"https://api.github.com/repos/rpm-software-management/libdnf/git/commits{/sha}","comments_url":"https://api.github.com/repos/rpm-software-management/libdnf/comments{/number}","issue_comment_url":"https://api.github.com/repos/rpm-software-management/libdnf/issues/comments{/number}","contents_url":"https://api.github.com/repos/rpm-software-management/libdnf/contents/{+path}","compare_url":"https://api.github.com/repos/rpm-software-management/libdnf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rpm-software-management/libdnf/merges","archive_url":"https://api.github.com/repos/rpm-software-management/libdnf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rpm-software-management/libdnf/downloads","issues_url":"https://api.github.com/repos/rpm-software-management/libdnf/issues{/number}","pulls_url":"https://api.github.com/repos/rpm-software-management/libdnf/pulls{/number}","milestones_url":"https://api.github.com/repos/rpm-software-management/libdnf/milestones{/number}","notifications_url":"https://api.github.com/repos/rpm-software-management/libdnf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rpm-software-management/libdnf/labels{/name}","releases_url":"https://api.github.com/repos/rpm-software-management/libdnf/releases{/id}","deployments_url":"https://api.github.com/repos/rpm-software-management/libdnf/deployments","created_at":"2014-03-28T09:00:31Z","updated_at":"2018-04-20T11:33:15Z","pushed_at":"2018-04-23T07:59:20Z","git_url":"git://github.com/rpm-software-management/libdnf.git","ssh_url":"[email protected]:rpm-software-management/libdnf.git","clone_url":"https://github.com/rpm-software-management/libdnf.git","svn_url":"https://github.com/rpm-software-management/libdnf","homepage":"","size":5461,"stargazers_count":47,"watchers_count":47,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":56,"mirror_url":null,"archived":false,"open_issues_count":50,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1"},"forks":56,"open_issues":50,"watchers":47,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rpm-software-management/libdnf/pulls/427"},"html":{"href":"https://github.com/rpm-software-management/libdnf/pull/427"},"issue":{"href":"https://api.github.com/repos/rpm-software-management/libdnf/issues/427"},"comments":{"href":"https://api.github.com/repos/rpm-software-management/libdnf/issues/427/comments"},"review_comments":{"href":"https://api.github.com/repos/rpm-software-management/libdnf/pulls/427/comments"},"review_comment":{"href":"https://api.github.com/repos/rpm-software-management/libdnf/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rpm-software-management/libdnf/pulls/427/commits"},"statuses":{"href":"https://api.github.com/repos/rpm-software-management/libdnf/statuses/3b5b67409c909d9039c5a0890f62a94e8254083a"}},"author_association":"MEMBER"}} | {
"id": 18206372,
"name": "rpm-software-management/libdnf",
"url": "https://api.github.com/repos/rpm-software-management/libdnf"
} | {
"id": 2866862,
"login": "ignatenkobrain",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2866862?",
"url": "https://api.github.com/users/ignatenkobrain"
} | {
"id": 8504469,
"login": "rpm-software-management",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/8504469?",
"url": "https://api.github.com/orgs/rpm-software-management"
} | 2018-04-23T10:41:01 | 7570972550 | {"actor":{"display_login":"ignatenkobrain"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/hpi-swa/Squot/pulls/comments/195816354","pull_request_review_id":129261271,"id":195816354,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NTgxNjM1NA==","diff_hunk":"@@ -1,3 +1,4 @@\n accessing\n name: aString\n+\tself validateReferenceName: aString.\n \treferenceName := aString","path":"src/Squit.package/SquitHistorian.class/instance/name..st","position":4,"original_position":4,"commit_id":"dd388dbb981bc25c96e4c440cffd942f90612762","original_commit_id":"dd388dbb981bc25c96e4c440cffd942f90612762","user":{"login":"codeZeilen","id":560608,"node_id":"MDQ6VXNlcjU2MDYwOA==","avatar_url":"https://avatars2.githubusercontent.com/u/560608?v=4","gravatar_id":"","url":"https://api.github.com/users/codeZeilen","html_url":"https://github.com/codeZeilen","followers_url":"https://api.github.com/users/codeZeilen/followers","following_url":"https://api.github.com/users/codeZeilen/following{/other_user}","gists_url":"https://api.github.com/users/codeZeilen/gists{/gist_id}","starred_url":"https://api.github.com/users/codeZeilen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codeZeilen/subscriptions","organizations_url":"https://api.github.com/users/codeZeilen/orgs","repos_url":"https://api.github.com/users/codeZeilen/repos","events_url":"https://api.github.com/users/codeZeilen/events{/privacy}","received_events_url":"https://api.github.com/users/codeZeilen/received_events","type":"User","site_admin":false},"body":"I determined the list by running the tests. For example when running FileSystemGitRepositoryTests>>testAddAndCommitting the method GitRepository>>resolveRef: is called with the name ''/test.git/refs/heads/master'. This is an invalid ref as it starts with a slash.\r\n\r\nThe other issue arises from FileSystemGitRepositoryTests>>setUp, more particular the line:\r\n\r\n```\r\nbasicRepository updateRef: basicRepository headsDir / 'branch1' to: commit1 hexHash;\r\n```\r\n\r\nwhich leads to refPath in `updateRef: refPath to: hexHash` being a FSReference with the path memory:/test.git/refs/heads/branch1. As the FSReference does not have an interface for retrieving the reference name part I assumed that this is nothing an FSReference deals with.","created_at":"2018-06-15T17:44:31Z","updated_at":"2018-06-15T17:44:31Z","html_url":"https://github.com/hpi-swa/Squot/pull/190#discussion_r195816354","pull_request_url":"https://api.github.com/repos/hpi-swa/Squot/pulls/190","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/hpi-swa/Squot/pulls/comments/195816354"},"html":{"href":"https://github.com/hpi-swa/Squot/pull/190#discussion_r195816354"},"pull_request":{"href":"https://api.github.com/repos/hpi-swa/Squot/pulls/190"}},"in_reply_to_id":189472106},"pull_request":{"url":"https://api.github.com/repos/hpi-swa/Squot/pulls/190","id":187666542,"node_id":"MDExOlB1bGxSZXF1ZXN0MTg3NjY2NTQy","html_url":"https://github.com/hpi-swa/Squot/pull/190","diff_url":"https://github.com/hpi-swa/Squot/pull/190.diff","patch_url":"https://github.com/hpi-swa/Squot/pull/190.patch","issue_url":"https://api.github.com/repos/hpi-swa/Squot/issues/190","number":190,"state":"open","locked":false,"title":"Adds validation of reference names ","user":{"login":"codeZeilen","id":560608,"node_id":"MDQ6VXNlcjU2MDYwOA==","avatar_url":"https://avatars2.githubusercontent.com/u/560608?v=4","gravatar_id":"","url":"https://api.github.com/users/codeZeilen","html_url":"https://github.com/codeZeilen","followers_url":"https://api.github.com/users/codeZeilen/followers","following_url":"https://api.github.com/users/codeZeilen/following{/other_user}","gists_url":"https://api.github.com/users/codeZeilen/gists{/gist_id}","starred_url":"https://api.github.com/users/codeZeilen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codeZeilen/subscriptions","organizations_url":"https://api.github.com/users/codeZeilen/orgs","repos_url":"https://api.github.com/users/codeZeilen/repos","events_url":"https://api.github.com/users/codeZeilen/events{/privacy}","received_events_url":"https://api.github.com/users/codeZeilen/received_events","type":"User","site_admin":false},"body":"There are some interesting rules on what is allowed in a reference name and what not. As some users created branches with spaces in them I added validation for this. However, I am not sure whether this is the right place to implement it. ","created_at":"2018-05-13T12:06:34Z","updated_at":"2018-06-15T17:44:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5d1fe6d76d02b4aec7220e04d290ac30dad817e4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/hpi-swa/Squot/pulls/190/commits","review_comments_url":"https://api.github.com/repos/hpi-swa/Squot/pulls/190/comments","review_comment_url":"https://api.github.com/repos/hpi-swa/Squot/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hpi-swa/Squot/issues/190/comments","statuses_url":"https://api.github.com/repos/hpi-swa/Squot/statuses/dd388dbb981bc25c96e4c440cffd942f90612762","head":{"label":"codeZeilen:feature-reference-name-validation","ref":"feature-reference-name-validation","sha":"dd388dbb981bc25c96e4c440cffd942f90612762","user":{"login":"codeZeilen","id":560608,"node_id":"MDQ6VXNlcjU2MDYwOA==","avatar_url":"https://avatars2.githubusercontent.com/u/560608?v=4","gravatar_id":"","url":"https://api.github.com/users/codeZeilen","html_url":"https://github.com/codeZeilen","followers_url":"https://api.github.com/users/codeZeilen/followers","following_url":"https://api.github.com/users/codeZeilen/following{/other_user}","gists_url":"https://api.github.com/users/codeZeilen/gists{/gist_id}","starred_url":"https://api.github.com/users/codeZeilen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codeZeilen/subscriptions","organizations_url":"https://api.github.com/users/codeZeilen/orgs","repos_url":"https://api.github.com/users/codeZeilen/repos","events_url":"https://api.github.com/users/codeZeilen/events{/privacy}","received_events_url":"https://api.github.com/users/codeZeilen/received_events","type":"User","site_admin":false},"repo":{"id":133231659,"node_id":"MDEwOlJlcG9zaXRvcnkxMzMyMzE2NTk=","name":"Squot","full_name":"codeZeilen/Squot","owner":{"login":"codeZeilen","id":560608,"node_id":"MDQ6VXNlcjU2MDYwOA==","avatar_url":"https://avatars2.githubusercontent.com/u/560608?v=4","gravatar_id":"","url":"https://api.github.com/users/codeZeilen","html_url":"https://github.com/codeZeilen","followers_url":"https://api.github.com/users/codeZeilen/followers","following_url":"https://api.github.com/users/codeZeilen/following{/other_user}","gists_url":"https://api.github.com/users/codeZeilen/gists{/gist_id}","starred_url":"https://api.github.com/users/codeZeilen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codeZeilen/subscriptions","organizations_url":"https://api.github.com/users/codeZeilen/orgs","repos_url":"https://api.github.com/users/codeZeilen/repos","events_url":"https://api.github.com/users/codeZeilen/events{/privacy}","received_events_url":"https://api.github.com/users/codeZeilen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/codeZeilen/Squot","description":"Squeak Object Tracker - Version control for arbitrary objects, currently with Git storage","fork":true,"url":"https://api.github.com/repos/codeZeilen/Squot","forks_url":"https://api.github.com/repos/codeZeilen/Squot/forks","keys_url":"https://api.github.com/repos/codeZeilen/Squot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/codeZeilen/Squot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/codeZeilen/Squot/teams","hooks_url":"https://api.github.com/repos/codeZeilen/Squot/hooks","issue_events_url":"https://api.github.com/repos/codeZeilen/Squot/issues/events{/number}","events_url":"https://api.github.com/repos/codeZeilen/Squot/events","assignees_url":"https://api.github.com/repos/codeZeilen/Squot/assignees{/user}","branches_url":"https://api.github.com/repos/codeZeilen/Squot/branches{/branch}","tags_url":"https://api.github.com/repos/codeZeilen/Squot/tags","blobs_url":"https://api.github.com/repos/codeZeilen/Squot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/codeZeilen/Squot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/codeZeilen/Squot/git/refs{/sha}","trees_url":"https://api.github.com/repos/codeZeilen/Squot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/codeZeilen/Squot/statuses/{sha}","languages_url":"https://api.github.com/repos/codeZeilen/Squot/languages","stargazers_url":"https://api.github.com/repos/codeZeilen/Squot/stargazers","contributors_url":"https://api.github.com/repos/codeZeilen/Squot/contributors","subscribers_url":"https://api.github.com/repos/codeZeilen/Squot/subscribers","subscription_url":"https://api.github.com/repos/codeZeilen/Squot/subscription","commits_url":"https://api.github.com/repos/codeZeilen/Squot/commits{/sha}","git_commits_url":"https://api.github.com/repos/codeZeilen/Squot/git/commits{/sha}","comments_url":"https://api.github.com/repos/codeZeilen/Squot/comments{/number}","issue_comment_url":"https://api.github.com/repos/codeZeilen/Squot/issues/comments{/number}","contents_url":"https://api.github.com/repos/codeZeilen/Squot/contents/{+path}","compare_url":"https://api.github.com/repos/codeZeilen/Squot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/codeZeilen/Squot/merges","archive_url":"https://api.github.com/repos/codeZeilen/Squot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/codeZeilen/Squot/downloads","issues_url":"https://api.github.com/repos/codeZeilen/Squot/issues{/number}","pulls_url":"https://api.github.com/repos/codeZeilen/Squot/pulls{/number}","milestones_url":"https://api.github.com/repos/codeZeilen/Squot/milestones{/number}","notifications_url":"https://api.github.com/repos/codeZeilen/Squot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/codeZeilen/Squot/labels{/name}","releases_url":"https://api.github.com/repos/codeZeilen/Squot/releases{/id}","deployments_url":"https://api.github.com/repos/codeZeilen/Squot/deployments","created_at":"2018-05-13T11:40:35Z","updated_at":"2018-05-13T11:40:42Z","pushed_at":"2018-05-14T14:35:49Z","git_url":"git://github.com/codeZeilen/Squot.git","ssh_url":"[email protected]:codeZeilen/Squot.git","clone_url":"https://github.com/codeZeilen/Squot.git","svn_url":"https://github.com/codeZeilen/Squot","homepage":null,"size":3205,"stargazers_count":0,"watchers_count":0,"language":"Smalltalk","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hpi-swa:develop","ref":"develop","sha":"e00c6888d1ad15b258aaf1834e1987c78d32173c","user":{"login":"hpi-swa","id":8598281,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg1OTgyODE=","avatar_url":"https://avatars0.githubusercontent.com/u/8598281?v=4","gravatar_id":"","url":"https://api.github.com/users/hpi-swa","html_url":"https://github.com/hpi-swa","followers_url":"https://api.github.com/users/hpi-swa/followers","following_url":"https://api.github.com/users/hpi-swa/following{/other_user}","gists_url":"https://api.github.com/users/hpi-swa/gists{/gist_id}","starred_url":"https://api.github.com/users/hpi-swa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hpi-swa/subscriptions","organizations_url":"https://api.github.com/users/hpi-swa/orgs","repos_url":"https://api.github.com/users/hpi-swa/repos","events_url":"https://api.github.com/users/hpi-swa/events{/privacy}","received_events_url":"https://api.github.com/users/hpi-swa/received_events","type":"Organization","site_admin":false},"repo":{"id":85003995,"node_id":"MDEwOlJlcG9zaXRvcnk4NTAwMzk5NQ==","name":"Squot","full_name":"hpi-swa/Squot","owner":{"login":"hpi-swa","id":8598281,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg1OTgyODE=","avatar_url":"https://avatars0.githubusercontent.com/u/8598281?v=4","gravatar_id":"","url":"https://api.github.com/users/hpi-swa","html_url":"https://github.com/hpi-swa","followers_url":"https://api.github.com/users/hpi-swa/followers","following_url":"https://api.github.com/users/hpi-swa/following{/other_user}","gists_url":"https://api.github.com/users/hpi-swa/gists{/gist_id}","starred_url":"https://api.github.com/users/hpi-swa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hpi-swa/subscriptions","organizations_url":"https://api.github.com/users/hpi-swa/orgs","repos_url":"https://api.github.com/users/hpi-swa/repos","events_url":"https://api.github.com/users/hpi-swa/events{/privacy}","received_events_url":"https://api.github.com/users/hpi-swa/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hpi-swa/Squot","description":"Squeak Object Tracker - Version control for arbitrary objects, currently with Git storage","fork":false,"url":"https://api.github.com/repos/hpi-swa/Squot","forks_url":"https://api.github.com/repos/hpi-swa/Squot/forks","keys_url":"https://api.github.com/repos/hpi-swa/Squot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hpi-swa/Squot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hpi-swa/Squot/teams","hooks_url":"https://api.github.com/repos/hpi-swa/Squot/hooks","issue_events_url":"https://api.github.com/repos/hpi-swa/Squot/issues/events{/number}","events_url":"https://api.github.com/repos/hpi-swa/Squot/events","assignees_url":"https://api.github.com/repos/hpi-swa/Squot/assignees{/user}","branches_url":"https://api.github.com/repos/hpi-swa/Squot/branches{/branch}","tags_url":"https://api.github.com/repos/hpi-swa/Squot/tags","blobs_url":"https://api.github.com/repos/hpi-swa/Squot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hpi-swa/Squot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hpi-swa/Squot/git/refs{/sha}","trees_url":"https://api.github.com/repos/hpi-swa/Squot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hpi-swa/Squot/statuses/{sha}","languages_url":"https://api.github.com/repos/hpi-swa/Squot/languages","stargazers_url":"https://api.github.com/repos/hpi-swa/Squot/stargazers","contributors_url":"https://api.github.com/repos/hpi-swa/Squot/contributors","subscribers_url":"https://api.github.com/repos/hpi-swa/Squot/subscribers","subscription_url":"https://api.github.com/repos/hpi-swa/Squot/subscription","commits_url":"https://api.github.com/repos/hpi-swa/Squot/commits{/sha}","git_commits_url":"https://api.github.com/repos/hpi-swa/Squot/git/commits{/sha}","comments_url":"https://api.github.com/repos/hpi-swa/Squot/comments{/number}","issue_comment_url":"https://api.github.com/repos/hpi-swa/Squot/issues/comments{/number}","contents_url":"https://api.github.com/repos/hpi-swa/Squot/contents/{+path}","compare_url":"https://api.github.com/repos/hpi-swa/Squot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hpi-swa/Squot/merges","archive_url":"https://api.github.com/repos/hpi-swa/Squot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hpi-swa/Squot/downloads","issues_url":"https://api.github.com/repos/hpi-swa/Squot/issues{/number}","pulls_url":"https://api.github.com/repos/hpi-swa/Squot/pulls{/number}","milestones_url":"https://api.github.com/repos/hpi-swa/Squot/milestones{/number}","notifications_url":"https://api.github.com/repos/hpi-swa/Squot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hpi-swa/Squot/labels{/name}","releases_url":"https://api.github.com/repos/hpi-swa/Squot/releases{/id}","deployments_url":"https://api.github.com/repos/hpi-swa/Squot/deployments","created_at":"2017-03-14T22:37:05Z","updated_at":"2018-06-06T05:34:52Z","pushed_at":"2018-05-27T21:23:47Z","git_url":"git://github.com/hpi-swa/Squot.git","ssh_url":"[email protected]:hpi-swa/Squot.git","clone_url":"https://github.com/hpi-swa/Squot.git","svn_url":"https://github.com/hpi-swa/Squot","homepage":null,"size":2856,"stargazers_count":9,"watchers_count":9,"language":"Smalltalk","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":69,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":5,"open_issues":69,"watchers":9,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/hpi-swa/Squot/pulls/190"},"html":{"href":"https://github.com/hpi-swa/Squot/pull/190"},"issue":{"href":"https://api.github.com/repos/hpi-swa/Squot/issues/190"},"comments":{"href":"https://api.github.com/repos/hpi-swa/Squot/issues/190/comments"},"review_comments":{"href":"https://api.github.com/repos/hpi-swa/Squot/pulls/190/comments"},"review_comment":{"href":"https://api.github.com/repos/hpi-swa/Squot/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hpi-swa/Squot/pulls/190/commits"},"statuses":{"href":"https://api.github.com/repos/hpi-swa/Squot/statuses/dd388dbb981bc25c96e4c440cffd942f90612762"}},"author_association":"MEMBER"}} | {
"id": 85003995,
"name": "hpi-swa/Squot",
"url": "https://api.github.com/repos/hpi-swa/Squot"
} | {
"id": 560608,
"login": "codeZeilen",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/560608?",
"url": "https://api.github.com/users/codeZeilen"
} | {
"id": 8598281,
"login": "hpi-swa",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/8598281?",
"url": "https://api.github.com/orgs/hpi-swa"
} | 2018-06-15T17:44:31 | 7832230317 | {"actor":{"display_login":"codeZeilen"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/NSLS-II/bluesky/pulls/comments/233961731","pull_request_review_id":175497240,"id":233961731,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMzk2MTczMQ==","diff_hunk":"@@ -222,10 +222,9 @@ def __init__(self, md=None, *, loop=None, preprocessors=None,\n \n # Make a logger for this specific RE instance, using the instance's\n # Python id, to keep from mixing output from separate instances.\n- logger_name = \"{name}_id{id}\".format(name=__name__, id=id(self))\n+ logger_name = \"bluesky.RE.{id}\".format(id=id(self))\n self.log = logging.getLogger(logger_name)\n- self.log.setLevel(logging.DEBUG)\n- self.verbose = False # a convenience property, setting log.disabled\n+ self.verbose = True # a convenience property, setting log.disabled","path":"bluesky/run_engine.py","position":9,"original_position":9,"commit_id":"e76dec984dcb964e15de5b2235b1a26a8f71e777","original_commit_id":"e76dec984dcb964e15de5b2235b1a26a8f71e777","user":{"login":"mrakitin","id":13209176,"node_id":"MDQ6VXNlcjEzMjA5MTc2","avatar_url":"https://avatars0.githubusercontent.com/u/13209176?v=4","gravatar_id":"","url":"https://api.github.com/users/mrakitin","html_url":"https://github.com/mrakitin","followers_url":"https://api.github.com/users/mrakitin/followers","following_url":"https://api.github.com/users/mrakitin/following{/other_user}","gists_url":"https://api.github.com/users/mrakitin/gists{/gist_id}","starred_url":"https://api.github.com/users/mrakitin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrakitin/subscriptions","organizations_url":"https://api.github.com/users/mrakitin/orgs","repos_url":"https://api.github.com/users/mrakitin/repos","events_url":"https://api.github.com/users/mrakitin/events{/privacy}","received_events_url":"https://api.github.com/users/mrakitin/received_events","type":"User","site_admin":false},"body":"the comment should be `a convenience property, setting log.enabled`, right?","created_at":"2018-11-15T18:39:21Z","updated_at":"2018-11-15T18:41:43Z","html_url":"https://github.com/NSLS-II/bluesky/pull/1116#discussion_r233961731","pull_request_url":"https://api.github.com/repos/NSLS-II/bluesky/pulls/1116","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/NSLS-II/bluesky/pulls/comments/233961731"},"html":{"href":"https://github.com/NSLS-II/bluesky/pull/1116#discussion_r233961731"},"pull_request":{"href":"https://api.github.com/repos/NSLS-II/bluesky/pulls/1116"}}},"pull_request":{"url":"https://api.github.com/repos/NSLS-II/bluesky/pulls/1116","id":231234804,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxMjM0ODA0","html_url":"https://github.com/NSLS-II/bluesky/pull/1116","diff_url":"https://github.com/NSLS-II/bluesky/pull/1116.diff","patch_url":"https://github.com/NSLS-II/bluesky/pull/1116.patch","issue_url":"https://api.github.com/repos/NSLS-II/bluesky/issues/1116","number":1116,"state":"open","locked":false,"title":"Revisit logging.","user":{"login":"danielballan","id":2279598,"node_id":"MDQ6VXNlcjIyNzk1OTg=","avatar_url":"https://avatars3.githubusercontent.com/u/2279598?v=4","gravatar_id":"","url":"https://api.github.com/users/danielballan","html_url":"https://github.com/danielballan","followers_url":"https://api.github.com/users/danielballan/followers","following_url":"https://api.github.com/users/danielballan/following{/other_user}","gists_url":"https://api.github.com/users/danielballan/gists{/gist_id}","starred_url":"https://api.github.com/users/danielballan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielballan/subscriptions","organizations_url":"https://api.github.com/users/danielballan/orgs","repos_url":"https://api.github.com/users/danielballan/repos","events_url":"https://api.github.com/users/danielballan/events{/privacy}","received_events_url":"https://api.github.com/users/danielballan/received_events","type":"User","site_admin":false},"body":"In the course or writing caproto, I now have better-informed opinions about how libraries should interact with Python's logging module.\r\n\r\nThis PR:\r\n\r\n* includes a nice default logging handler, vendored from caproto, which is turn is a vendor/variation on Tornado's built-in handler\r\n* avoids imposing log levels at import time\r\n* adds DEBUG-level logging next to the `msg_hook`, which imposes a 4% performance hit on message throughput (when DEBUG logging is off) which seems worth paying to me\r\n\r\nExample:\r\n\r\n```python\r\nIn [5]: RE(count([det]))\r\nOut[5]: ('daa5f363-1c44-4fd1-8023-c3289e7c8f81',)\r\n\r\nIn [6]: import logging\r\n\r\nIn [7]: logging.getLogger('bluesky').setLevel('DEBUG')\r\n\r\nIn [8]: RE(count([det]))\r\n[I 10:15:28.478 run_engine:82] Change state on <bluesky.run_engine.RunEngine object at 0x7f76b49cc278> from 'idle' -> 'running'\r\n[D 10:15:28.478 run_engine:1184] stage: (SynGauss(name='det', value=1.0, timestamp=1542294919.6508715)), (), {}\r\n[D 10:15:28.478 run_engine:1184] open_run: (None), (), {'detectors': ['det'], 'num_points': 1, 'num_intervals': 0, 'plan_args': {'detectors': [\"SynGauss(name='det', value=1.0, timestamp=1542294919.6508715)\"], 'num': 1}, 'plan_name': 'count', 'hints': {'dimensions': [(('time',), 'primary')]}}\r\n[D 10:15:28.478 run_engine:1356] Starting new with uid '423c2d6e-690c-4904-a87a-ee82fb08b33f'\r\n[D 10:15:28.481 run_engine:1378] Emitted RunStart (uid='423c2d6e-690c-4904-a87a-ee82fb08b33f')\r\n[D 10:15:28.481 run_engine:1184] checkpoint: (None), (), {}\r\n[D 10:15:28.481 run_engine:1184] trigger: (SynGauss(name='det', value=1.0, timestamp=1542294919.6508715)), (), {'group': 'trigger-7921d8'}\r\n[D 10:15:28.481 run_engine:1999] The object SynGauss(name='det', value=1.0, timestamp=1542294928.4819157) reports trigger is done with status True.\r\n[D 10:15:28.482 run_engine:1184] wait: (None), (), {'group': 'trigger-7921d8'}\r\n[D 10:15:28.482 run_engine:1184] create: (None), (), {'name': 'primary'}\r\n[D 10:15:28.482 run_engine:1184] read: (SynGauss(name='det', value=1.0, timestamp=1542294928.4819157)), (), {}\r\n[D 10:15:28.482 run_engine:1184] save: (None), (), {}\r\n[D 10:15:28.485 run_engine:1693] Emitted Event Descriptor with name 'primary' containing data keys dict_keys(['det']) (uid='3bfb3fd9-dd26-4cf5-b7ab-11223380e760')\r\n[D 10:15:28.486 run_engine:1725] Emitted Event with data keys dict_keys(['det']) (uid='2a308700-548b-4c33-8063-2bfa2c460d7b')\r\n[D 10:15:28.486 run_engine:1184] close_run: (None), (), {'exit_status': None, 'reason': None}\r\n[D 10:15:28.486 run_engine:1411] Stopping run '423c2d6e-690c-4904-a87a-ee82fb08b33f'\r\n[D 10:15:28.487 run_engine:1436] Emitted RunStop (uid='2524a956-1d95-44c3-bf7c-f8b3b0016939')\r\n[D 10:15:28.487 run_engine:1184] unstage: (SynGauss(name='det', value=1.0, timestamp=1542294928.4819157)), (), {}\r\n[I 10:15:28.487 run_engine:82] Change state on <bluesky.run_engine.RunEngine object at 0x7f76b49cc278> from 'running' -> 'idle'\r\nOut[8]: ('423c2d6e-690c-4904-a87a-ee82fb08b33f',)\r\n```\r\n\r\nThis suggests some obvious additional improves. (For example, we should give `RunEngine` as nice repr.) But I propose keeping the scope of this PR limited and iterating from there if we have time. We could do a _lot_ more but I want to make sure this lands in the next release.","created_at":"2018-11-15T15:28:34Z","updated_at":"2018-11-15T18:41:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3e88b6dfa6ce951ee1e045d0997acc6e27966d68","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/NSLS-II/bluesky/pulls/1116/commits","review_comments_url":"https://api.github.com/repos/NSLS-II/bluesky/pulls/1116/comments","review_comment_url":"https://api.github.com/repos/NSLS-II/bluesky/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NSLS-II/bluesky/issues/1116/comments","statuses_url":"https://api.github.com/repos/NSLS-II/bluesky/statuses/e76dec984dcb964e15de5b2235b1a26a8f71e777","head":{"label":"danielballan:redo-logging","ref":"redo-logging","sha":"e76dec984dcb964e15de5b2235b1a26a8f71e777","user":{"login":"danielballan","id":2279598,"node_id":"MDQ6VXNlcjIyNzk1OTg=","avatar_url":"https://avatars3.githubusercontent.com/u/2279598?v=4","gravatar_id":"","url":"https://api.github.com/users/danielballan","html_url":"https://github.com/danielballan","followers_url":"https://api.github.com/users/danielballan/followers","following_url":"https://api.github.com/users/danielballan/following{/other_user}","gists_url":"https://api.github.com/users/danielballan/gists{/gist_id}","starred_url":"https://api.github.com/users/danielballan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielballan/subscriptions","organizations_url":"https://api.github.com/users/danielballan/orgs","repos_url":"https://api.github.com/users/danielballan/repos","events_url":"https://api.github.com/users/danielballan/events{/privacy}","received_events_url":"https://api.github.com/users/danielballan/received_events","type":"User","site_admin":false},"repo":{"id":39904738,"node_id":"MDEwOlJlcG9zaXRvcnkzOTkwNDczOA==","name":"bluesky","full_name":"danielballan/bluesky","private":false,"owner":{"login":"danielballan","id":2279598,"node_id":"MDQ6VXNlcjIyNzk1OTg=","avatar_url":"https://avatars3.githubusercontent.com/u/2279598?v=4","gravatar_id":"","url":"https://api.github.com/users/danielballan","html_url":"https://github.com/danielballan","followers_url":"https://api.github.com/users/danielballan/followers","following_url":"https://api.github.com/users/danielballan/following{/other_user}","gists_url":"https://api.github.com/users/danielballan/gists{/gist_id}","starred_url":"https://api.github.com/users/danielballan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielballan/subscriptions","organizations_url":"https://api.github.com/users/danielballan/orgs","repos_url":"https://api.github.com/users/danielballan/repos","events_url":"https://api.github.com/users/danielballan/events{/privacy}","received_events_url":"https://api.github.com/users/danielballan/received_events","type":"User","site_admin":false},"html_url":"https://github.com/danielballan/bluesky","description":"a data collection interface","fork":true,"url":"https://api.github.com/repos/danielballan/bluesky","forks_url":"https://api.github.com/repos/danielballan/bluesky/forks","keys_url":"https://api.github.com/repos/danielballan/bluesky/keys{/key_id}","collaborators_url":"https://api.github.com/repos/danielballan/bluesky/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/danielballan/bluesky/teams","hooks_url":"https://api.github.com/repos/danielballan/bluesky/hooks","issue_events_url":"https://api.github.com/repos/danielballan/bluesky/issues/events{/number}","events_url":"https://api.github.com/repos/danielballan/bluesky/events","assignees_url":"https://api.github.com/repos/danielballan/bluesky/assignees{/user}","branches_url":"https://api.github.com/repos/danielballan/bluesky/branches{/branch}","tags_url":"https://api.github.com/repos/danielballan/bluesky/tags","blobs_url":"https://api.github.com/repos/danielballan/bluesky/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/danielballan/bluesky/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/danielballan/bluesky/git/refs{/sha}","trees_url":"https://api.github.com/repos/danielballan/bluesky/git/trees{/sha}","statuses_url":"https://api.github.com/repos/danielballan/bluesky/statuses/{sha}","languages_url":"https://api.github.com/repos/danielballan/bluesky/languages","stargazers_url":"https://api.github.com/repos/danielballan/bluesky/stargazers","contributors_url":"https://api.github.com/repos/danielballan/bluesky/contributors","subscribers_url":"https://api.github.com/repos/danielballan/bluesky/subscribers","subscription_url":"https://api.github.com/repos/danielballan/bluesky/subscription","commits_url":"https://api.github.com/repos/danielballan/bluesky/commits{/sha}","git_commits_url":"https://api.github.com/repos/danielballan/bluesky/git/commits{/sha}","comments_url":"https://api.github.com/repos/danielballan/bluesky/comments{/number}","issue_comment_url":"https://api.github.com/repos/danielballan/bluesky/issues/comments{/number}","contents_url":"https://api.github.com/repos/danielballan/bluesky/contents/{+path}","compare_url":"https://api.github.com/repos/danielballan/bluesky/compare/{base}...{head}","merges_url":"https://api.github.com/repos/danielballan/bluesky/merges","archive_url":"https://api.github.com/repos/danielballan/bluesky/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/danielballan/bluesky/downloads","issues_url":"https://api.github.com/repos/danielballan/bluesky/issues{/number}","pulls_url":"https://api.github.com/repos/danielballan/bluesky/pulls{/number}","milestones_url":"https://api.github.com/repos/danielballan/bluesky/milestones{/number}","notifications_url":"https://api.github.com/repos/danielballan/bluesky/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/danielballan/bluesky/labels{/name}","releases_url":"https://api.github.com/repos/danielballan/bluesky/releases{/id}","deployments_url":"https://api.github.com/repos/danielballan/bluesky/deployments","created_at":"2015-07-29T16:42:41Z","updated_at":"2018-06-06T12:17:01Z","pushed_at":"2018-11-15T18:01:23Z","git_url":"git://github.com/danielballan/bluesky.git","ssh_url":"[email protected]:danielballan/bluesky.git","clone_url":"https://github.com/danielballan/bluesky.git","svn_url":"https://github.com/danielballan/bluesky","homepage":"http://danielballan.github.io/bluesky","size":5322,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"NSLS-II:master","ref":"master","sha":"7cd0e9ccbf5fe986d326fbac5f1205decc6d862a","user":{"login":"NSLS-II","id":8700262,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg3MDAyNjI=","avatar_url":"https://avatars3.githubusercontent.com/u/8700262?v=4","gravatar_id":"","url":"https://api.github.com/users/NSLS-II","html_url":"https://github.com/NSLS-II","followers_url":"https://api.github.com/users/NSLS-II/followers","following_url":"https://api.github.com/users/NSLS-II/following{/other_user}","gists_url":"https://api.github.com/users/NSLS-II/gists{/gist_id}","starred_url":"https://api.github.com/users/NSLS-II/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NSLS-II/subscriptions","organizations_url":"https://api.github.com/users/NSLS-II/orgs","repos_url":"https://api.github.com/users/NSLS-II/repos","events_url":"https://api.github.com/users/NSLS-II/events{/privacy}","received_events_url":"https://api.github.com/users/NSLS-II/received_events","type":"Organization","site_admin":false},"repo":{"id":36754446,"node_id":"MDEwOlJlcG9zaXRvcnkzNjc1NDQ0Ng==","name":"bluesky","full_name":"NSLS-II/bluesky","private":false,"owner":{"login":"NSLS-II","id":8700262,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg3MDAyNjI=","avatar_url":"https://avatars3.githubusercontent.com/u/8700262?v=4","gravatar_id":"","url":"https://api.github.com/users/NSLS-II","html_url":"https://github.com/NSLS-II","followers_url":"https://api.github.com/users/NSLS-II/followers","following_url":"https://api.github.com/users/NSLS-II/following{/other_user}","gists_url":"https://api.github.com/users/NSLS-II/gists{/gist_id}","starred_url":"https://api.github.com/users/NSLS-II/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NSLS-II/subscriptions","organizations_url":"https://api.github.com/users/NSLS-II/orgs","repos_url":"https://api.github.com/users/NSLS-II/repos","events_url":"https://api.github.com/users/NSLS-II/events{/privacy}","received_events_url":"https://api.github.com/users/NSLS-II/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/NSLS-II/bluesky","description":"a data collection interface","fork":false,"url":"https://api.github.com/repos/NSLS-II/bluesky","forks_url":"https://api.github.com/repos/NSLS-II/bluesky/forks","keys_url":"https://api.github.com/repos/NSLS-II/bluesky/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NSLS-II/bluesky/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NSLS-II/bluesky/teams","hooks_url":"https://api.github.com/repos/NSLS-II/bluesky/hooks","issue_events_url":"https://api.github.com/repos/NSLS-II/bluesky/issues/events{/number}","events_url":"https://api.github.com/repos/NSLS-II/bluesky/events","assignees_url":"https://api.github.com/repos/NSLS-II/bluesky/assignees{/user}","branches_url":"https://api.github.com/repos/NSLS-II/bluesky/branches{/branch}","tags_url":"https://api.github.com/repos/NSLS-II/bluesky/tags","blobs_url":"https://api.github.com/repos/NSLS-II/bluesky/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NSLS-II/bluesky/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NSLS-II/bluesky/git/refs{/sha}","trees_url":"https://api.github.com/repos/NSLS-II/bluesky/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NSLS-II/bluesky/statuses/{sha}","languages_url":"https://api.github.com/repos/NSLS-II/bluesky/languages","stargazers_url":"https://api.github.com/repos/NSLS-II/bluesky/stargazers","contributors_url":"https://api.github.com/repos/NSLS-II/bluesky/contributors","subscribers_url":"https://api.github.com/repos/NSLS-II/bluesky/subscribers","subscription_url":"https://api.github.com/repos/NSLS-II/bluesky/subscription","commits_url":"https://api.github.com/repos/NSLS-II/bluesky/commits{/sha}","git_commits_url":"https://api.github.com/repos/NSLS-II/bluesky/git/commits{/sha}","comments_url":"https://api.github.com/repos/NSLS-II/bluesky/comments{/number}","issue_comment_url":"https://api.github.com/repos/NSLS-II/bluesky/issues/comments{/number}","contents_url":"https://api.github.com/repos/NSLS-II/bluesky/contents/{+path}","compare_url":"https://api.github.com/repos/NSLS-II/bluesky/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NSLS-II/bluesky/merges","archive_url":"https://api.github.com/repos/NSLS-II/bluesky/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NSLS-II/bluesky/downloads","issues_url":"https://api.github.com/repos/NSLS-II/bluesky/issues{/number}","pulls_url":"https://api.github.com/repos/NSLS-II/bluesky/pulls{/number}","milestones_url":"https://api.github.com/repos/NSLS-II/bluesky/milestones{/number}","notifications_url":"https://api.github.com/repos/NSLS-II/bluesky/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NSLS-II/bluesky/labels{/name}","releases_url":"https://api.github.com/repos/NSLS-II/bluesky/releases{/id}","deployments_url":"https://api.github.com/repos/NSLS-II/bluesky/deployments","created_at":"2015-06-02T18:50:18Z","updated_at":"2018-11-07T22:43:39Z","pushed_at":"2018-11-15T18:01:24Z","git_url":"git://github.com/NSLS-II/bluesky.git","ssh_url":"[email protected]:NSLS-II/bluesky.git","clone_url":"https://github.com/NSLS-II/bluesky.git","svn_url":"https://github.com/NSLS-II/bluesky","homepage":"http://nsls-ii.github.io/bluesky","size":4513,"stargazers_count":34,"watchers_count":34,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":34,"mirror_url":null,"archived":false,"open_issues_count":133,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":34,"open_issues":133,"watchers":34,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NSLS-II/bluesky/pulls/1116"},"html":{"href":"https://github.com/NSLS-II/bluesky/pull/1116"},"issue":{"href":"https://api.github.com/repos/NSLS-II/bluesky/issues/1116"},"comments":{"href":"https://api.github.com/repos/NSLS-II/bluesky/issues/1116/comments"},"review_comments":{"href":"https://api.github.com/repos/NSLS-II/bluesky/pulls/1116/comments"},"review_comment":{"href":"https://api.github.com/repos/NSLS-II/bluesky/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NSLS-II/bluesky/pulls/1116/commits"},"statuses":{"href":"https://api.github.com/repos/NSLS-II/bluesky/statuses/e76dec984dcb964e15de5b2235b1a26a8f71e777"}},"author_association":"CONTRIBUTOR"}} | {
"id": 36754446,
"name": "NSLS-II/bluesky",
"url": "https://api.github.com/repos/NSLS-II/bluesky"
} | {
"id": 13209176,
"login": "mrakitin",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/13209176?",
"url": "https://api.github.com/users/mrakitin"
} | {
"id": 8700262,
"login": "NSLS-II",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/8700262?",
"url": "https://api.github.com/orgs/NSLS-II"
} | 2018-11-15T18:39:21 | 8597442596 | {"actor":{"display_login":"mrakitin"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/BD2KGenomics/toil/pulls/comments/173275682","pull_request_review_id":102439837,"id":173275682,"diff_hunk":"@@ -93,7 +93,7 @@ def __init__(self):\n self.nodeOptions = None\n self.minNodes = None\n self.maxNodes = [10]\n- self.alphaPacking = 0.0\n+ self.alphaTime = 1800","path":"src/toil/common.py","position":5,"original_position":5,"commit_id":"56ab005c17cf1aa1704cde9b4014c9466eef085a","original_commit_id":"56ab005c17cf1aa1704cde9b4014c9466eef085a","user":{"login":"joelarmstrong","id":4723163,"avatar_url":"https://avatars0.githubusercontent.com/u/4723163?v=4","gravatar_id":"","url":"https://api.github.com/users/joelarmstrong","html_url":"https://github.com/joelarmstrong","followers_url":"https://api.github.com/users/joelarmstrong/followers","following_url":"https://api.github.com/users/joelarmstrong/following{/other_user}","gists_url":"https://api.github.com/users/joelarmstrong/gists{/gist_id}","starred_url":"https://api.github.com/users/joelarmstrong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joelarmstrong/subscriptions","organizations_url":"https://api.github.com/users/joelarmstrong/orgs","repos_url":"https://api.github.com/users/joelarmstrong/repos","events_url":"https://api.github.com/users/joelarmstrong/events{/privacy}","received_events_url":"https://api.github.com/users/joelarmstrong/received_events","type":"User","site_admin":false},"body":"I think lower would be fine, but how much lower I'm not sure. My gut tells me 60 would be too low, because the per-node overhead becomes a larger proportion of cost as they run for less time. Basically, because it can take a decent amount of time (IIRC over a minute) just to download and launch the toil container, lower alphaTime means higher cost. I'm not sure there is really an \"optimal\" value of alphaTime, but intuitively I think the cost will increase massively as the value goes below a few minutes.\r\n\r\nAs a totally contrived example, imagine that you are running 1000 jobs that take 1 minute to run and take up exactly one instance each, which costs (say) 1 cent per minute. Also assume the toil container takes one minute to initialize after the instance boots (IIRC this is in the right ballpark). Then running this with different values of alphaTime would yield different costs*:\r\n\r\n- alphaTime = 60: 1000 instances launched for 2 minutes each, $20.00\r\n- alphaTime = 120: 500 instances launched for 3 minutes each, $15.00\r\n- alphaTime = 600: 100 instances launched for 11 minutes each, $11.00\r\n\r\n[*] This is under the simplifying assumption that there is only one scaler decision made, at the start: in reality the last two costs will be different (lower, but with noticably longer runtime; see the first point under 'considerations' up above). Unfortunately calculating the costs with extra scaler decisions is kind of a pain.","created_at":"2018-03-08T20:05:51Z","updated_at":"2018-03-08T20:05:51Z","html_url":"https://github.com/BD2KGenomics/toil/pull/2114#discussion_r173275682","pull_request_url":"https://api.github.com/repos/BD2KGenomics/toil/pulls/2114","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/BD2KGenomics/toil/pulls/comments/173275682"},"html":{"href":"https://github.com/BD2KGenomics/toil/pull/2114#discussion_r173275682"},"pull_request":{"href":"https://api.github.com/repos/BD2KGenomics/toil/pulls/2114"}},"in_reply_to_id":173229021},"pull_request":{"url":"https://api.github.com/repos/BD2KGenomics/toil/pulls/2114","id":173640691,"html_url":"https://github.com/BD2KGenomics/toil/pull/2114","diff_url":"https://github.com/BD2KGenomics/toil/pull/2114.diff","patch_url":"https://github.com/BD2KGenomics/toil/pull/2114.patch","issue_url":"https://api.github.com/repos/BD2KGenomics/toil/issues/2114","number":2114,"state":"open","locked":false,"title":"Autoscaler revamp","user":{"login":"joelarmstrong","id":4723163,"avatar_url":"https://avatars0.githubusercontent.com/u/4723163?v=4","gravatar_id":"","url":"https://api.github.com/users/joelarmstrong","html_url":"https://github.com/joelarmstrong","followers_url":"https://api.github.com/users/joelarmstrong/followers","following_url":"https://api.github.com/users/joelarmstrong/following{/other_user}","gists_url":"https://api.github.com/users/joelarmstrong/gists{/gist_id}","starred_url":"https://api.github.com/users/joelarmstrong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joelarmstrong/subscriptions","organizations_url":"https://api.github.com/users/joelarmstrong/orgs","repos_url":"https://api.github.com/users/joelarmstrong/repos","events_url":"https://api.github.com/users/joelarmstrong/events{/privacy}","received_events_url":"https://api.github.com/users/joelarmstrong/received_events","type":"User","site_admin":false},"body":"This is a slight refactoring and retouching of the autoscaler. This fixes several bugs, some of which are blockers for certain niche use-cases. Notably:\r\n- Services weren't being treated specially by the autoscaler. Services are one case where the degree of parallelization really, really matters. If you have multiple services, they may all need to be running simultaneously before any real work can be done. Previously, if your services had a fairly short runtime, the autoscaler would believe that it could pack them serially, one after the other. This would lead to service deadlocks in some situations.\r\n- New node reservations (reservations are sort of like \"time-slices\" of resource usage at a node, so you can find the projected resource usage at each point in time) weren't split, meaning that a 5-minute job that uses 5 cores would be projected to use 5 cores for the entire 1-hour \"wallTime\" of the instance. This means in certain situations, more nodes would be created than would be optimal.\r\n- A long-running job, which \"extends\" a node reservation for a very long time, could end up causing other jobs to be packed into its extended reservations, even though they may be projected to start several hours in the future. This ends up underprovisioning nodes if you have a few long-running jobs and many more short jobs. (I've noticed the old pre-multiple-node-types scaler underestimating the number of needed nodes with Cactus, though I don't know whether that's caused by this particular bug or not.)\r\n- The ignored nodes functionality didn't work at all, or when it did, only rarely, because the ignoredNodes set was based on IP addresses, and the Mesos batch system was checking *hostnames* to see if they were ignored.\r\n- When running services or other long-running jobs, the ignored nodes functionality would rarely lead to deadlocks, where all N nodes were ignored despite wanting to scale up to N nodes. Now the scaler will \"unignore\" nodes if it changes its mind about scaling up or down.\r\n\r\nFor context, the original scaler worked like this: take the resource requirements of the last 10000 completed jobs, attempt to figure out how many nodes would be able to run those so that all jobs started within an hour. Then multiply that by the length of the current queue times a constant \"alpha packing\" factor. This is nice from a performance point of view (because it only needs to pack at most 10000 jobs), but leads to some *really* weird results, because it used the past to predict the future. It also isn't ideal when you absolutely need parallelism (services), because you *never* want to under-provision like you would with an alphaPacking < 1.0. The current scaler is a blend of using \"recent\" jobs vs. queued jobs, with alphaPacking determining the mix between the two.\r\n\r\nThis alters the scaler so that it works entirely on the basis of queued jobs, and the \"alpha\" parameter is a time. The packing attempts to spawn enough nodes that all the queued jobs will be started by that time. Intuitively this is just a parameter which controls the degree of parallelization, without (hopefully) causing deadlocks if it can help it.\r\n\r\nAnyway, this has been mangled a bit since I last tested it thoroughly, because it's been through a rebase and now selectively cherry-picked off my fork. So it's not ready to merge just yet, but it should be relatively OK.\r\n\r\nSome considerations:\r\n- The scaler basically attempts to set the rate of job completion (assuming homogeneous jobs for simplicity) to n/a, n being the number of jobs and a being the alpha factor. But the scaler will run again in (by default) 60 seconds, and assuming some jobs have been completed, it will try to set the rate of job completion lower (because n is lower). The total number of jobs remaining, n, will decrease from the starting point N as roughly n = N/(t/a + 1). So the end result isn't the local result, that all jobs are started within alpha seconds--quite the contrary, they are almost guaranteed not to unless they can all fit into one node. This isn't a new problem: the old scalers had the exact same behavior, but ironically it didn't really matter because they couldn't scale down very well. We should solve this properly at some point, but for now I recommend increasing the scaler interval.\r\n- The beta parameter has always annoyed me a bit: I like the basic idea, but I think the current behavior is less useful than it could be, and can sometimes lead to problematic under-provisioning. Right now it is basically used to ignore small fluctuations, which is fine. But the problem I usually have with the scaler isn't with small fluctuations, it's with fluctuations that are too large, too fast. Usually this happens when thousands of small jobs are being dumped all at once, right after a series of long jobs, causing the autoscaler to freak out and hit its max -- then it rapidly figures out the jobs are pretty short and adjusts to something smaller than the max within 5 minutes, wasting some money. So I'd prefer the inertia parameter to be something much more like a moving average, which could give the autoscaler a chance to adjust, while still being able to hit the max in a reasonable time. (The moving average could still have some minor fluctuations, so maybe the existing beta parameter behavior would still be needed.)\r\n- How should we order the \"preference\" of nodes to launch? Currently a sort is used which will do the \"right\" thing in the vast, vast majority of cases--but not all. Should we use the ordering provided by the user, and trust them to do it right? Or should we sort to prioritize the cheapest instances first, which is probably what the user wants?","created_at":"2018-03-08T04:07:43Z","updated_at":"2018-03-08T20:05:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"150306cdcf8b385b63c21a75b447d720d0d622f0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":194037021,"url":"https://api.github.com/repos/BD2KGenomics/toil/labels/in%20progress","name":"in progress","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/BD2KGenomics/toil/pulls/2114/commits","review_comments_url":"https://api.github.com/repos/BD2KGenomics/toil/pulls/2114/comments","review_comment_url":"https://api.github.com/repos/BD2KGenomics/toil/pulls/comments{/number}","comments_url":"https://api.github.com/repos/BD2KGenomics/toil/issues/2114/comments","statuses_url":"https://api.github.com/repos/BD2KGenomics/toil/statuses/56ab005c17cf1aa1704cde9b4014c9466eef085a","head":{"label":"BD2KGenomics:autoscaler-revamp","ref":"autoscaler-revamp","sha":"56ab005c17cf1aa1704cde9b4014c9466eef085a","user":{"login":"BD2KGenomics","id":8701293,"avatar_url":"https://avatars0.githubusercontent.com/u/8701293?v=4","gravatar_id":"","url":"https://api.github.com/users/BD2KGenomics","html_url":"https://github.com/BD2KGenomics","followers_url":"https://api.github.com/users/BD2KGenomics/followers","following_url":"https://api.github.com/users/BD2KGenomics/following{/other_user}","gists_url":"https://api.github.com/users/BD2KGenomics/gists{/gist_id}","starred_url":"https://api.github.com/users/BD2KGenomics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BD2KGenomics/subscriptions","organizations_url":"https://api.github.com/users/BD2KGenomics/orgs","repos_url":"https://api.github.com/users/BD2KGenomics/repos","events_url":"https://api.github.com/users/BD2KGenomics/events{/privacy}","received_events_url":"https://api.github.com/users/BD2KGenomics/received_events","type":"Organization","site_admin":false},"repo":{"id":33148320,"name":"toil","full_name":"BD2KGenomics/toil","owner":{"login":"BD2KGenomics","id":8701293,"avatar_url":"https://avatars0.githubusercontent.com/u/8701293?v=4","gravatar_id":"","url":"https://api.github.com/users/BD2KGenomics","html_url":"https://github.com/BD2KGenomics","followers_url":"https://api.github.com/users/BD2KGenomics/followers","following_url":"https://api.github.com/users/BD2KGenomics/following{/other_user}","gists_url":"https://api.github.com/users/BD2KGenomics/gists{/gist_id}","starred_url":"https://api.github.com/users/BD2KGenomics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BD2KGenomics/subscriptions","organizations_url":"https://api.github.com/users/BD2KGenomics/orgs","repos_url":"https://api.github.com/users/BD2KGenomics/repos","events_url":"https://api.github.com/users/BD2KGenomics/events{/privacy}","received_events_url":"https://api.github.com/users/BD2KGenomics/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/BD2KGenomics/toil","description":"A scalable, efficient, cross-platform and easy-to-use workflow engine in pure Python","fork":false,"url":"https://api.github.com/repos/BD2KGenomics/toil","forks_url":"https://api.github.com/repos/BD2KGenomics/toil/forks","keys_url":"https://api.github.com/repos/BD2KGenomics/toil/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BD2KGenomics/toil/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BD2KGenomics/toil/teams","hooks_url":"https://api.github.com/repos/BD2KGenomics/toil/hooks","issue_events_url":"https://api.github.com/repos/BD2KGenomics/toil/issues/events{/number}","events_url":"https://api.github.com/repos/BD2KGenomics/toil/events","assignees_url":"https://api.github.com/repos/BD2KGenomics/toil/assignees{/user}","branches_url":"https://api.github.com/repos/BD2KGenomics/toil/branches{/branch}","tags_url":"https://api.github.com/repos/BD2KGenomics/toil/tags","blobs_url":"https://api.github.com/repos/BD2KGenomics/toil/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BD2KGenomics/toil/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BD2KGenomics/toil/git/refs{/sha}","trees_url":"https://api.github.com/repos/BD2KGenomics/toil/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BD2KGenomics/toil/statuses/{sha}","languages_url":"https://api.github.com/repos/BD2KGenomics/toil/languages","stargazers_url":"https://api.github.com/repos/BD2KGenomics/toil/stargazers","contributors_url":"https://api.github.com/repos/BD2KGenomics/toil/contributors","subscribers_url":"https://api.github.com/repos/BD2KGenomics/toil/subscribers","subscription_url":"https://api.github.com/repos/BD2KGenomics/toil/subscription","commits_url":"https://api.github.com/repos/BD2KGenomics/toil/commits{/sha}","git_commits_url":"https://api.github.com/repos/BD2KGenomics/toil/git/commits{/sha}","comments_url":"https://api.github.com/repos/BD2KGenomics/toil/comments{/number}","issue_comment_url":"https://api.github.com/repos/BD2KGenomics/toil/issues/comments{/number}","contents_url":"https://api.github.com/repos/BD2KGenomics/toil/contents/{+path}","compare_url":"https://api.github.com/repos/BD2KGenomics/toil/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BD2KGenomics/toil/merges","archive_url":"https://api.github.com/repos/BD2KGenomics/toil/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BD2KGenomics/toil/downloads","issues_url":"https://api.github.com/repos/BD2KGenomics/toil/issues{/number}","pulls_url":"https://api.github.com/repos/BD2KGenomics/toil/pulls{/number}","milestones_url":"https://api.github.com/repos/BD2KGenomics/toil/milestones{/number}","notifications_url":"https://api.github.com/repos/BD2KGenomics/toil/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BD2KGenomics/toil/labels{/name}","releases_url":"https://api.github.com/repos/BD2KGenomics/toil/releases{/id}","deployments_url":"https://api.github.com/repos/BD2KGenomics/toil/deployments","created_at":"2015-03-30T21:08:58Z","updated_at":"2018-03-08T02:54:01Z","pushed_at":"2018-03-08T16:53:59Z","git_url":"git://github.com/BD2KGenomics/toil.git","ssh_url":"[email protected]:BD2KGenomics/toil.git","clone_url":"https://github.com/BD2KGenomics/toil.git","svn_url":"https://github.com/BD2KGenomics/toil","homepage":"","size":16319,"stargazers_count":442,"watchers_count":442,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":122,"mirror_url":null,"archived":false,"open_issues_count":316,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":122,"open_issues":316,"watchers":442,"default_branch":"master"}},"base":{"label":"BD2KGenomics:master","ref":"master","sha":"7396751ca449262792348600409b885031a4576d","user":{"login":"BD2KGenomics","id":8701293,"avatar_url":"https://avatars0.githubusercontent.com/u/8701293?v=4","gravatar_id":"","url":"https://api.github.com/users/BD2KGenomics","html_url":"https://github.com/BD2KGenomics","followers_url":"https://api.github.com/users/BD2KGenomics/followers","following_url":"https://api.github.com/users/BD2KGenomics/following{/other_user}","gists_url":"https://api.github.com/users/BD2KGenomics/gists{/gist_id}","starred_url":"https://api.github.com/users/BD2KGenomics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BD2KGenomics/subscriptions","organizations_url":"https://api.github.com/users/BD2KGenomics/orgs","repos_url":"https://api.github.com/users/BD2KGenomics/repos","events_url":"https://api.github.com/users/BD2KGenomics/events{/privacy}","received_events_url":"https://api.github.com/users/BD2KGenomics/received_events","type":"Organization","site_admin":false},"repo":{"id":33148320,"name":"toil","full_name":"BD2KGenomics/toil","owner":{"login":"BD2KGenomics","id":8701293,"avatar_url":"https://avatars0.githubusercontent.com/u/8701293?v=4","gravatar_id":"","url":"https://api.github.com/users/BD2KGenomics","html_url":"https://github.com/BD2KGenomics","followers_url":"https://api.github.com/users/BD2KGenomics/followers","following_url":"https://api.github.com/users/BD2KGenomics/following{/other_user}","gists_url":"https://api.github.com/users/BD2KGenomics/gists{/gist_id}","starred_url":"https://api.github.com/users/BD2KGenomics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BD2KGenomics/subscriptions","organizations_url":"https://api.github.com/users/BD2KGenomics/orgs","repos_url":"https://api.github.com/users/BD2KGenomics/repos","events_url":"https://api.github.com/users/BD2KGenomics/events{/privacy}","received_events_url":"https://api.github.com/users/BD2KGenomics/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/BD2KGenomics/toil","description":"A scalable, efficient, cross-platform and easy-to-use workflow engine in pure Python","fork":false,"url":"https://api.github.com/repos/BD2KGenomics/toil","forks_url":"https://api.github.com/repos/BD2KGenomics/toil/forks","keys_url":"https://api.github.com/repos/BD2KGenomics/toil/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BD2KGenomics/toil/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BD2KGenomics/toil/teams","hooks_url":"https://api.github.com/repos/BD2KGenomics/toil/hooks","issue_events_url":"https://api.github.com/repos/BD2KGenomics/toil/issues/events{/number}","events_url":"https://api.github.com/repos/BD2KGenomics/toil/events","assignees_url":"https://api.github.com/repos/BD2KGenomics/toil/assignees{/user}","branches_url":"https://api.github.com/repos/BD2KGenomics/toil/branches{/branch}","tags_url":"https://api.github.com/repos/BD2KGenomics/toil/tags","blobs_url":"https://api.github.com/repos/BD2KGenomics/toil/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BD2KGenomics/toil/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BD2KGenomics/toil/git/refs{/sha}","trees_url":"https://api.github.com/repos/BD2KGenomics/toil/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BD2KGenomics/toil/statuses/{sha}","languages_url":"https://api.github.com/repos/BD2KGenomics/toil/languages","stargazers_url":"https://api.github.com/repos/BD2KGenomics/toil/stargazers","contributors_url":"https://api.github.com/repos/BD2KGenomics/toil/contributors","subscribers_url":"https://api.github.com/repos/BD2KGenomics/toil/subscribers","subscription_url":"https://api.github.com/repos/BD2KGenomics/toil/subscription","commits_url":"https://api.github.com/repos/BD2KGenomics/toil/commits{/sha}","git_commits_url":"https://api.github.com/repos/BD2KGenomics/toil/git/commits{/sha}","comments_url":"https://api.github.com/repos/BD2KGenomics/toil/comments{/number}","issue_comment_url":"https://api.github.com/repos/BD2KGenomics/toil/issues/comments{/number}","contents_url":"https://api.github.com/repos/BD2KGenomics/toil/contents/{+path}","compare_url":"https://api.github.com/repos/BD2KGenomics/toil/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BD2KGenomics/toil/merges","archive_url":"https://api.github.com/repos/BD2KGenomics/toil/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BD2KGenomics/toil/downloads","issues_url":"https://api.github.com/repos/BD2KGenomics/toil/issues{/number}","pulls_url":"https://api.github.com/repos/BD2KGenomics/toil/pulls{/number}","milestones_url":"https://api.github.com/repos/BD2KGenomics/toil/milestones{/number}","notifications_url":"https://api.github.com/repos/BD2KGenomics/toil/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BD2KGenomics/toil/labels{/name}","releases_url":"https://api.github.com/repos/BD2KGenomics/toil/releases{/id}","deployments_url":"https://api.github.com/repos/BD2KGenomics/toil/deployments","created_at":"2015-03-30T21:08:58Z","updated_at":"2018-03-08T02:54:01Z","pushed_at":"2018-03-08T16:53:59Z","git_url":"git://github.com/BD2KGenomics/toil.git","ssh_url":"[email protected]:BD2KGenomics/toil.git","clone_url":"https://github.com/BD2KGenomics/toil.git","svn_url":"https://github.com/BD2KGenomics/toil","homepage":"","size":16319,"stargazers_count":442,"watchers_count":442,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":122,"mirror_url":null,"archived":false,"open_issues_count":316,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":122,"open_issues":316,"watchers":442,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/BD2KGenomics/toil/pulls/2114"},"html":{"href":"https://github.com/BD2KGenomics/toil/pull/2114"},"issue":{"href":"https://api.github.com/repos/BD2KGenomics/toil/issues/2114"},"comments":{"href":"https://api.github.com/repos/BD2KGenomics/toil/issues/2114/comments"},"review_comments":{"href":"https://api.github.com/repos/BD2KGenomics/toil/pulls/2114/comments"},"review_comment":{"href":"https://api.github.com/repos/BD2KGenomics/toil/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/BD2KGenomics/toil/pulls/2114/commits"},"statuses":{"href":"https://api.github.com/repos/BD2KGenomics/toil/statuses/56ab005c17cf1aa1704cde9b4014c9466eef085a"}},"author_association":"CONTRIBUTOR"}} | {
"id": 33148320,
"name": "BD2KGenomics/toil",
"url": "https://api.github.com/repos/BD2KGenomics/toil"
} | {
"id": 4723163,
"login": "joelarmstrong",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4723163?",
"url": "https://api.github.com/users/joelarmstrong"
} | {
"id": 8701293,
"login": "BD2KGenomics",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/8701293?",
"url": "https://api.github.com/orgs/BD2KGenomics"
} | 2018-03-08T20:05:51 | 7352297706 | {"actor":{"display_login":"joelarmstrong"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/learn-co-students/js-tictactoe-rails-api-v-000/pulls/comments/184475882","pull_request_review_id":115681211,"id":184475882,"diff_hunk":"@@ -1 +1,128 @@\n-// Code your JavaScript / jQuery solution here\n+var turn = 0;\n+var currentGame = 0;\n+\n+var winCombinations = [","path":"app/assets/javascripts/tictactoe.js","position":5,"original_position":5,"commit_id":"002753782864254a31ce4cfed0a33ef30278492a","original_commit_id":"002753782864254a31ce4cfed0a33ef30278492a","user":{"login":"weezwo","id":19954790,"avatar_url":"https://avatars3.githubusercontent.com/u/19954790?v=4","gravatar_id":"","url":"https://api.github.com/users/weezwo","html_url":"https://github.com/weezwo","followers_url":"https://api.github.com/users/weezwo/followers","following_url":"https://api.github.com/users/weezwo/following{/other_user}","gists_url":"https://api.github.com/users/weezwo/gists{/gist_id}","starred_url":"https://api.github.com/users/weezwo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weezwo/subscriptions","organizations_url":"https://api.github.com/users/weezwo/orgs","repos_url":"https://api.github.com/users/weezwo/repos","events_url":"https://api.github.com/users/weezwo/events{/privacy}","received_events_url":"https://api.github.com/users/weezwo/received_events","type":"User","site_admin":false},"body":"Since these will never change, it's best to declare the winning combos as a constant: `const WINNING_COMBOS`","created_at":"2018-04-26T17:45:48Z","updated_at":"2018-04-26T17:51:45Z","html_url":"https://github.com/learn-co-students/js-tictactoe-rails-api-v-000/pull/383#discussion_r184475882","pull_request_url":"https://api.github.com/repos/learn-co-students/js-tictactoe-rails-api-v-000/pulls/383","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/learn-co-students/js-tictactoe-rails-api-v-000/pulls/comments/184475882"},"html":{"href":"https://github.com/learn-co-students/js-tictactoe-rails-api-v-000/pull/383#discussion_r184475882"},"pull_request":{"href":"https://api.github.com/repos/learn-co-students/js-tictactoe-rails-api-v-000/pulls/383"}}},"pull_request":{"url":"https://api.github.com/repos/learn-co-students/js-tictactoe-rails-api-v-000/pulls/383","id":180433793,"html_url":"https://github.com/learn-co-students/js-tictactoe-rails-api-v-000/pull/383","diff_url":"https://github.com/learn-co-students/js-tictactoe-rails-api-v-000/pull/383.diff","patch_url":"https://github.com/learn-co-students/js-tictactoe-rails-api-v-000/pull/383.patch","issue_url":"https://api.github.com/repos/learn-co-students/js-tictactoe-rails-api-v-000/issues/383","number":383,"state":"open","locked":false,"title":"Project submitted","user":{"login":"vlaunyc","id":24817278,"avatar_url":"https://avatars3.githubusercontent.com/u/24817278?v=4","gravatar_id":"","url":"https://api.github.com/users/vlaunyc","html_url":"https://github.com/vlaunyc","followers_url":"https://api.github.com/users/vlaunyc/followers","following_url":"https://api.github.com/users/vlaunyc/following{/other_user}","gists_url":"https://api.github.com/users/vlaunyc/gists{/gist_id}","starred_url":"https://api.github.com/users/vlaunyc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vlaunyc/subscriptions","organizations_url":"https://api.github.com/users/vlaunyc/orgs","repos_url":"https://api.github.com/users/vlaunyc/repos","events_url":"https://api.github.com/users/vlaunyc/events{/privacy}","received_events_url":"https://api.github.com/users/vlaunyc/received_events","type":"User","site_admin":false},"body":null,"created_at":"2018-04-09T21:33:50Z","updated_at":"2018-04-26T17:51:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c146dde2e805936a7a567bd546bad7e4fba894e2","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/learn-co-students/js-tictactoe-rails-api-v-000/pulls/383/commits","review_comments_url":"https://api.github.com/repos/learn-co-students/js-tictactoe-rails-api-v-000/pulls/383/comments","review_comment_url":"https://api.github.com/repos/learn-co-students/js-tictactoe-rails-api-v-000/pulls/comments{/number}","comments_url":"https://api.github.com/repos/learn-co-students/js-tictactoe-rails-api-v-000/issues/383/comments","statuses_url":"https://api.github.com/repos/learn-co-students/js-tictactoe-rails-api-v-000/statuses/002753782864254a31ce4cfed0a33ef30278492a","head":{"label":"vlaunyc:master","ref":"master","sha":"002753782864254a31ce4cfed0a33ef30278492a","user":{"login":"vlaunyc","id":24817278,"avatar_url":"https://avatars3.githubusercontent.com/u/24817278?v=4","gravatar_id":"","url":"https://api.github.com/users/vlaunyc","html_url":"https://github.com/vlaunyc","followers_url":"https://api.github.com/users/vlaunyc/followers","following_url":"https://api.github.com/users/vlaunyc/following{/other_user}","gists_url":"https://api.github.com/users/vlaunyc/gists{/gist_id}","starred_url":"https://api.github.com/users/vlaunyc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vlaunyc/subscriptions","organizations_url":"https://api.github.com/users/vlaunyc/orgs","repos_url":"https://api.github.com/users/vlaunyc/repos","events_url":"https://api.github.com/users/vlaunyc/events{/privacy}","received_events_url":"https://api.github.com/users/vlaunyc/received_events","type":"User","site_admin":false},"repo":{"id":128125044,"name":"js-tictactoe-rails-api-v-000","full_name":"vlaunyc/js-tictactoe-rails-api-v-000","owner":{"login":"vlaunyc","id":24817278,"avatar_url":"https://avatars3.githubusercontent.com/u/24817278?v=4","gravatar_id":"","url":"https://api.github.com/users/vlaunyc","html_url":"https://github.com/vlaunyc","followers_url":"https://api.github.com/users/vlaunyc/followers","following_url":"https://api.github.com/users/vlaunyc/following{/other_user}","gists_url":"https://api.github.com/users/vlaunyc/gists{/gist_id}","starred_url":"https://api.github.com/users/vlaunyc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vlaunyc/subscriptions","organizations_url":"https://api.github.com/users/vlaunyc/orgs","repos_url":"https://api.github.com/users/vlaunyc/repos","events_url":"https://api.github.com/users/vlaunyc/events{/privacy}","received_events_url":"https://api.github.com/users/vlaunyc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vlaunyc/js-tictactoe-rails-api-v-000","description":null,"fork":true,"url":"https://api.github.com/repos/vlaunyc/js-tictactoe-rails-api-v-000","forks_url":"https://api.github.com/repos/vlaunyc/js-tictactoe-rails-api-v-000/forks","keys_url":"https://api.github.com/repos/vlaunyc/js-tictactoe-rails-api-v-000/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vlaunyc/js-tictactoe-rails-api-v-000/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vlaunyc/js-tictactoe-rails-api-v-000/teams","hooks_url":"https://api.github.com/repos/vlaunyc/js-tictactoe-rails-api-v-000/hooks","issue_events_url":"https://api.github.com/repos/vlaunyc/js-tictactoe-rails-api-v-000/issues/events{/number}","events_url":"https://api.github.com/repos/vlaunyc/js-tictactoe-rails-api-v-000/events","assignees_url":"https://api.github.com/repos/vlaunyc/js-tictactoe-rails-api-v-000/assignees{/user}","branches_url":"https://api.github.com/repos/vlaunyc/js-tictactoe-rails-api-v-000/branches{/branch}","tags_url":"https://api.github.com/repos/vlaunyc/js-tictactoe-rails-api-v-000/tags","blobs_url":"https://api.github.com/repos/vlaunyc/js-tictactoe-rails-api-v-000/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vlaunyc/js-tictactoe-rails-api-v-000/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vlaunyc/js-tictactoe-rails-api-v-000/git/refs{/sha}","trees_url":"https://api.github.com/repos/vlaunyc/js-tictactoe-rails-api-v-000/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vlaunyc/js-tictactoe-rails-api-v-000/statuses/{sha}","languages_url":"https://api.github.com/repos/vlaunyc/js-tictactoe-rails-api-v-000/languages","stargazers_url":"https://api.github.com/repos/vlaunyc/js-tictactoe-rails-api-v-000/stargazers","contributors_url":"https://api.github.com/repos/vlaunyc/js-tictactoe-rails-api-v-000/contributors","subscribers_url":"https://api.github.com/repos/vlaunyc/js-tictactoe-rails-api-v-000/subscribers","subscription_url":"https://api.github.com/repos/vlaunyc/js-tictactoe-rails-api-v-000/subscription","commits_url":"https://api.github.com/repos/vlaunyc/js-tictactoe-rails-api-v-000/commits{/sha}","git_commits_url":"https://api.github.com/repos/vlaunyc/js-tictactoe-rails-api-v-000/git/commits{/sha}","comments_url":"https://api.github.com/repos/vlaunyc/js-tictactoe-rails-api-v-000/comments{/number}","issue_comment_url":"https://api.github.com/repos/vlaunyc/js-tictactoe-rails-api-v-000/issues/comments{/number}","contents_url":"https://api.github.com/repos/vlaunyc/js-tictactoe-rails-api-v-000/contents/{+path}","compare_url":"https://api.github.com/repos/vlaunyc/js-tictactoe-rails-api-v-000/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vlaunyc/js-tictactoe-rails-api-v-000/merges","archive_url":"https://api.github.com/repos/vlaunyc/js-tictactoe-rails-api-v-000/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vlaunyc/js-tictactoe-rails-api-v-000/downloads","issues_url":"https://api.github.com/repos/vlaunyc/js-tictactoe-rails-api-v-000/issues{/number}","pulls_url":"https://api.github.com/repos/vlaunyc/js-tictactoe-rails-api-v-000/pulls{/number}","milestones_url":"https://api.github.com/repos/vlaunyc/js-tictactoe-rails-api-v-000/milestones{/number}","notifications_url":"https://api.github.com/repos/vlaunyc/js-tictactoe-rails-api-v-000/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vlaunyc/js-tictactoe-rails-api-v-000/labels{/name}","releases_url":"https://api.github.com/repos/vlaunyc/js-tictactoe-rails-api-v-000/releases{/id}","deployments_url":"https://api.github.com/repos/vlaunyc/js-tictactoe-rails-api-v-000/deployments","created_at":"2018-04-04T21:36:47Z","updated_at":"2018-04-09T21:33:51Z","pushed_at":"2018-04-09T21:33:49Z","git_url":"git://github.com/vlaunyc/js-tictactoe-rails-api-v-000.git","ssh_url":"[email protected]:vlaunyc/js-tictactoe-rails-api-v-000.git","clone_url":"https://github.com/vlaunyc/js-tictactoe-rails-api-v-000.git","svn_url":"https://github.com/vlaunyc/js-tictactoe-rails-api-v-000","homepage":null,"size":180,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"learn-co-students:master","ref":"master","sha":"74bce8766eea264c02c2d0739ab5a035962290f6","user":{"login":"learn-co-students","id":8825476,"avatar_url":"https://avatars3.githubusercontent.com/u/8825476?v=4","gravatar_id":"","url":"https://api.github.com/users/learn-co-students","html_url":"https://github.com/learn-co-students","followers_url":"https://api.github.com/users/learn-co-students/followers","following_url":"https://api.github.com/users/learn-co-students/following{/other_user}","gists_url":"https://api.github.com/users/learn-co-students/gists{/gist_id}","starred_url":"https://api.github.com/users/learn-co-students/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/learn-co-students/subscriptions","organizations_url":"https://api.github.com/users/learn-co-students/orgs","repos_url":"https://api.github.com/users/learn-co-students/repos","events_url":"https://api.github.com/users/learn-co-students/events{/privacy}","received_events_url":"https://api.github.com/users/learn-co-students/received_events","type":"Organization","site_admin":false},"repo":{"id":52471975,"name":"js-tictactoe-rails-api-v-000","full_name":"learn-co-students/js-tictactoe-rails-api-v-000","owner":{"login":"learn-co-students","id":8825476,"avatar_url":"https://avatars3.githubusercontent.com/u/8825476?v=4","gravatar_id":"","url":"https://api.github.com/users/learn-co-students","html_url":"https://github.com/learn-co-students","followers_url":"https://api.github.com/users/learn-co-students/followers","following_url":"https://api.github.com/users/learn-co-students/following{/other_user}","gists_url":"https://api.github.com/users/learn-co-students/gists{/gist_id}","starred_url":"https://api.github.com/users/learn-co-students/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/learn-co-students/subscriptions","organizations_url":"https://api.github.com/users/learn-co-students/orgs","repos_url":"https://api.github.com/users/learn-co-students/repos","events_url":"https://api.github.com/users/learn-co-students/events{/privacy}","received_events_url":"https://api.github.com/users/learn-co-students/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/learn-co-students/js-tictactoe-rails-api-v-000","description":null,"fork":false,"url":"https://api.github.com/repos/learn-co-students/js-tictactoe-rails-api-v-000","forks_url":"https://api.github.com/repos/learn-co-students/js-tictactoe-rails-api-v-000/forks","keys_url":"https://api.github.com/repos/learn-co-students/js-tictactoe-rails-api-v-000/keys{/key_id}","collaborators_url":"https://api.github.com/repos/learn-co-students/js-tictactoe-rails-api-v-000/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/learn-co-students/js-tictactoe-rails-api-v-000/teams","hooks_url":"https://api.github.com/repos/learn-co-students/js-tictactoe-rails-api-v-000/hooks","issue_events_url":"https://api.github.com/repos/learn-co-students/js-tictactoe-rails-api-v-000/issues/events{/number}","events_url":"https://api.github.com/repos/learn-co-students/js-tictactoe-rails-api-v-000/events","assignees_url":"https://api.github.com/repos/learn-co-students/js-tictactoe-rails-api-v-000/assignees{/user}","branches_url":"https://api.github.com/repos/learn-co-students/js-tictactoe-rails-api-v-000/branches{/branch}","tags_url":"https://api.github.com/repos/learn-co-students/js-tictactoe-rails-api-v-000/tags","blobs_url":"https://api.github.com/repos/learn-co-students/js-tictactoe-rails-api-v-000/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/learn-co-students/js-tictactoe-rails-api-v-000/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/learn-co-students/js-tictactoe-rails-api-v-000/git/refs{/sha}","trees_url":"https://api.github.com/repos/learn-co-students/js-tictactoe-rails-api-v-000/git/trees{/sha}","statuses_url":"https://api.github.com/repos/learn-co-students/js-tictactoe-rails-api-v-000/statuses/{sha}","languages_url":"https://api.github.com/repos/learn-co-students/js-tictactoe-rails-api-v-000/languages","stargazers_url":"https://api.github.com/repos/learn-co-students/js-tictactoe-rails-api-v-000/stargazers","contributors_url":"https://api.github.com/repos/learn-co-students/js-tictactoe-rails-api-v-000/contributors","subscribers_url":"https://api.github.com/repos/learn-co-students/js-tictactoe-rails-api-v-000/subscribers","subscription_url":"https://api.github.com/repos/learn-co-students/js-tictactoe-rails-api-v-000/subscription","commits_url":"https://api.github.com/repos/learn-co-students/js-tictactoe-rails-api-v-000/commits{/sha}","git_commits_url":"https://api.github.com/repos/learn-co-students/js-tictactoe-rails-api-v-000/git/commits{/sha}","comments_url":"https://api.github.com/repos/learn-co-students/js-tictactoe-rails-api-v-000/comments{/number}","issue_comment_url":"https://api.github.com/repos/learn-co-students/js-tictactoe-rails-api-v-000/issues/comments{/number}","contents_url":"https://api.github.com/repos/learn-co-students/js-tictactoe-rails-api-v-000/contents/{+path}","compare_url":"https://api.github.com/repos/learn-co-students/js-tictactoe-rails-api-v-000/compare/{base}...{head}","merges_url":"https://api.github.com/repos/learn-co-students/js-tictactoe-rails-api-v-000/merges","archive_url":"https://api.github.com/repos/learn-co-students/js-tictactoe-rails-api-v-000/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/learn-co-students/js-tictactoe-rails-api-v-000/downloads","issues_url":"https://api.github.com/repos/learn-co-students/js-tictactoe-rails-api-v-000/issues{/number}","pulls_url":"https://api.github.com/repos/learn-co-students/js-tictactoe-rails-api-v-000/pulls{/number}","milestones_url":"https://api.github.com/repos/learn-co-students/js-tictactoe-rails-api-v-000/milestones{/number}","notifications_url":"https://api.github.com/repos/learn-co-students/js-tictactoe-rails-api-v-000/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/learn-co-students/js-tictactoe-rails-api-v-000/labels{/name}","releases_url":"https://api.github.com/repos/learn-co-students/js-tictactoe-rails-api-v-000/releases{/id}","deployments_url":"https://api.github.com/repos/learn-co-students/js-tictactoe-rails-api-v-000/deployments","created_at":"2016-02-24T20:24:11Z","updated_at":"2018-03-29T23:07:01Z","pushed_at":"2018-04-25T21:00:33Z","git_url":"git://github.com/learn-co-students/js-tictactoe-rails-api-v-000.git","ssh_url":"[email protected]:learn-co-students/js-tictactoe-rails-api-v-000.git","clone_url":"https://github.com/learn-co-students/js-tictactoe-rails-api-v-000.git","svn_url":"https://github.com/learn-co-students/js-tictactoe-rails-api-v-000","homepage":null,"size":172,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":436,"mirror_url":null,"archived":false,"open_issues_count":388,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":436,"open_issues":388,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/learn-co-students/js-tictactoe-rails-api-v-000/pulls/383"},"html":{"href":"https://github.com/learn-co-students/js-tictactoe-rails-api-v-000/pull/383"},"issue":{"href":"https://api.github.com/repos/learn-co-students/js-tictactoe-rails-api-v-000/issues/383"},"comments":{"href":"https://api.github.com/repos/learn-co-students/js-tictactoe-rails-api-v-000/issues/383/comments"},"review_comments":{"href":"https://api.github.com/repos/learn-co-students/js-tictactoe-rails-api-v-000/pulls/383/comments"},"review_comment":{"href":"https://api.github.com/repos/learn-co-students/js-tictactoe-rails-api-v-000/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/learn-co-students/js-tictactoe-rails-api-v-000/pulls/383/commits"},"statuses":{"href":"https://api.github.com/repos/learn-co-students/js-tictactoe-rails-api-v-000/statuses/002753782864254a31ce4cfed0a33ef30278492a"}},"author_association":"NONE"}} | {
"id": 52471975,
"name": "learn-co-students/js-tictactoe-rails-api-v-000",
"url": "https://api.github.com/repos/learn-co-students/js-tictactoe-rails-api-v-000"
} | {
"id": 19954790,
"login": "weezwo",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/19954790?",
"url": "https://api.github.com/users/weezwo"
} | {
"id": 8825476,
"login": "learn-co-students",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/8825476?",
"url": "https://api.github.com/orgs/learn-co-students"
} | 2018-04-26T17:45:48 | 7592982661 | {"actor":{"display_login":"weezwo"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/comments/187903905","pull_request_review_id":119774621,"id":187903905,"diff_hunk":"@@ -63,13 +63,72 @@ class NetworkStack\n virtual nsapi_error_t gethostbyname(const char *host,\n SocketAddress *address, nsapi_version_t version = NSAPI_UNSPEC);\n \n+ /** Hostname translation callback (asynchronous)\n+ *\n+ * Callback will be called after DNS resolution completes or a failure occurs.\n+ *\n+ * Callback should not take more than 10ms to execute, otherwise it might\n+ * prevent underlying thread processing. A portable user of the callback\n+ * should not make calls to network operations due to stack size limitations.\n+ * The callback should not perform expensive operations such as socket recv/send\n+ * calls or blocking operations.\n+ *\n+ * @param status 0 on success, negative error code on failure\n+ * @param address On success, destination for the host SocketAddress\n+ */\n+ typedef mbed::Callback<void (nsapi_error_t result, SocketAddress *address)> hostbyname_cb_t;\n+\n+ /** Translates a hostname to an IP address (asynchronous)\n+ *\n+ * The hostname may be either a domain name or an IP address. If the\n+ * hostname is an IP address, no network transactions will be performed.\n+ *\n+ * If no stack-specific DNS resolution is provided, the hostname\n+ * will be resolve using a UDP socket on the stack.\n+ *\n+ * Call is non-blocking. Result of the DNS operation is returned by the callback.\n+ * If this function returns failure, callback will not be called. In case result\n+ * is success (IP address was found from DNS cache), callback will be called\n+ * before function returns.\n+ *\n+ * @param host Hostname to resolve\n+ * @param callback Callback that is called for result\n+ * @param version IP version of address to resolve, NSAPI_UNSPEC indicates\n+ * version is chosen by the stack (defaults to NSAPI_UNSPEC)\n+ * @return 0 on success, negative error code on failure or an unique id that\n+ * represents the hostname translation operation and can be passed to\n+ * cancel\n+ */\n+ virtual nsapi_error_t gethostbyname_async(const char *host, hostbyname_cb_t callback,","path":"features/netsocket/NetworkStack.h","position":null,"original_position":72,"commit_id":"0483cca1335d1bf40dd82fbe1143ea632704ec6e","original_commit_id":"ba6a877501db9567f9a8f8a4beab6cf47c362ab6","user":{"login":"mikaleppanen","id":13345641,"avatar_url":"https://avatars1.githubusercontent.com/u/13345641?v=4","gravatar_id":"","url":"https://api.github.com/users/mikaleppanen","html_url":"https://github.com/mikaleppanen","followers_url":"https://api.github.com/users/mikaleppanen/followers","following_url":"https://api.github.com/users/mikaleppanen/following{/other_user}","gists_url":"https://api.github.com/users/mikaleppanen/gists{/gist_id}","starred_url":"https://api.github.com/users/mikaleppanen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikaleppanen/subscriptions","organizations_url":"https://api.github.com/users/mikaleppanen/orgs","repos_url":"https://api.github.com/users/mikaleppanen/repos","events_url":"https://api.github.com/users/mikaleppanen/events{/privacy}","received_events_url":"https://api.github.com/users/mikaleppanen/received_events","type":"User","site_admin":false},"body":"Added new definition: nsapi_value_or_error_t","created_at":"2018-05-14T10:28:02Z","updated_at":"2018-05-14T10:28:03Z","html_url":"https://github.com/ARMmbed/mbed-os/pull/6751#discussion_r187903905","pull_request_url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/6751","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/comments/187903905"},"html":{"href":"https://github.com/ARMmbed/mbed-os/pull/6751#discussion_r187903905"},"pull_request":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/6751"}},"in_reply_to_id":186046406},"pull_request":{"url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/6751","id":184275285,"html_url":"https://github.com/ARMmbed/mbed-os/pull/6751","diff_url":"https://github.com/ARMmbed/mbed-os/pull/6751.diff","patch_url":"https://github.com/ARMmbed/mbed-os/pull/6751.patch","issue_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/6751","number":6751,"state":"open","locked":false,"title":"Add non-blocking DNS functionality to network interface","user":{"login":"mikaleppanen","id":13345641,"avatar_url":"https://avatars1.githubusercontent.com/u/13345641?v=4","gravatar_id":"","url":"https://api.github.com/users/mikaleppanen","html_url":"https://github.com/mikaleppanen","followers_url":"https://api.github.com/users/mikaleppanen/followers","following_url":"https://api.github.com/users/mikaleppanen/following{/other_user}","gists_url":"https://api.github.com/users/mikaleppanen/gists{/gist_id}","starred_url":"https://api.github.com/users/mikaleppanen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikaleppanen/subscriptions","organizations_url":"https://api.github.com/users/mikaleppanen/orgs","repos_url":"https://api.github.com/users/mikaleppanen/repos","events_url":"https://api.github.com/users/mikaleppanen/events{/privacy}","received_events_url":"https://api.github.com/users/mikaleppanen/received_events","type":"User","site_admin":false},"body":"### Description\r\n\r\n- Added non-blocking DNS interface to network interface and network stack.\r\n- Added caching of DNS replies.\r\n- Added a network stack function to get DNS addresses from stack.\r\n- Added call and call_in hooks to onboard network stack to allow calling functions from onboard stack context.\r\n- Added support to call and call_in functions to LWIP and Nanostack.\r\n- Disabled LWIP DNS translator with the exception of DNS address storage used in DNS address get.\r\n\r\n### Pull request type\r\n [ ] Fix\r\n [ ] Refactor\r\n [ ] New target\r\n [X] Feature\r\n [ ] Breaking change\r\n\r\n","created_at":"2018-04-26T09:17:21Z","updated_at":"2018-05-14T10:28:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a1c093b8c8ce18b4b6ff27ae618e71a00521a1a0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":144902129,"url":"https://api.github.com/repos/ARMmbed/mbed-os/labels/needs:%20work","name":"needs: work","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/6751/commits","review_comments_url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/6751/comments","review_comment_url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/6751/comments","statuses_url":"https://api.github.com/repos/ARMmbed/mbed-os/statuses/0483cca1335d1bf40dd82fbe1143ea632704ec6e","head":{"label":"mikaleppanen:non_block_dns","ref":"non_block_dns","sha":"0483cca1335d1bf40dd82fbe1143ea632704ec6e","user":{"login":"mikaleppanen","id":13345641,"avatar_url":"https://avatars1.githubusercontent.com/u/13345641?v=4","gravatar_id":"","url":"https://api.github.com/users/mikaleppanen","html_url":"https://github.com/mikaleppanen","followers_url":"https://api.github.com/users/mikaleppanen/followers","following_url":"https://api.github.com/users/mikaleppanen/following{/other_user}","gists_url":"https://api.github.com/users/mikaleppanen/gists{/gist_id}","starred_url":"https://api.github.com/users/mikaleppanen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikaleppanen/subscriptions","organizations_url":"https://api.github.com/users/mikaleppanen/orgs","repos_url":"https://api.github.com/users/mikaleppanen/repos","events_url":"https://api.github.com/users/mikaleppanen/events{/privacy}","received_events_url":"https://api.github.com/users/mikaleppanen/received_events","type":"User","site_admin":false},"repo":{"id":68590736,"name":"mbed-os","full_name":"mikaleppanen/mbed-os","owner":{"login":"mikaleppanen","id":13345641,"avatar_url":"https://avatars1.githubusercontent.com/u/13345641?v=4","gravatar_id":"","url":"https://api.github.com/users/mikaleppanen","html_url":"https://github.com/mikaleppanen","followers_url":"https://api.github.com/users/mikaleppanen/followers","following_url":"https://api.github.com/users/mikaleppanen/following{/other_user}","gists_url":"https://api.github.com/users/mikaleppanen/gists{/gist_id}","starred_url":"https://api.github.com/users/mikaleppanen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikaleppanen/subscriptions","organizations_url":"https://api.github.com/users/mikaleppanen/orgs","repos_url":"https://api.github.com/users/mikaleppanen/repos","events_url":"https://api.github.com/users/mikaleppanen/events{/privacy}","received_events_url":"https://api.github.com/users/mikaleppanen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mikaleppanen/mbed-os","description":"ARM mbed OS is a platform operating system designed for the internet of things","fork":true,"url":"https://api.github.com/repos/mikaleppanen/mbed-os","forks_url":"https://api.github.com/repos/mikaleppanen/mbed-os/forks","keys_url":"https://api.github.com/repos/mikaleppanen/mbed-os/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mikaleppanen/mbed-os/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mikaleppanen/mbed-os/teams","hooks_url":"https://api.github.com/repos/mikaleppanen/mbed-os/hooks","issue_events_url":"https://api.github.com/repos/mikaleppanen/mbed-os/issues/events{/number}","events_url":"https://api.github.com/repos/mikaleppanen/mbed-os/events","assignees_url":"https://api.github.com/repos/mikaleppanen/mbed-os/assignees{/user}","branches_url":"https://api.github.com/repos/mikaleppanen/mbed-os/branches{/branch}","tags_url":"https://api.github.com/repos/mikaleppanen/mbed-os/tags","blobs_url":"https://api.github.com/repos/mikaleppanen/mbed-os/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mikaleppanen/mbed-os/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mikaleppanen/mbed-os/git/refs{/sha}","trees_url":"https://api.github.com/repos/mikaleppanen/mbed-os/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mikaleppanen/mbed-os/statuses/{sha}","languages_url":"https://api.github.com/repos/mikaleppanen/mbed-os/languages","stargazers_url":"https://api.github.com/repos/mikaleppanen/mbed-os/stargazers","contributors_url":"https://api.github.com/repos/mikaleppanen/mbed-os/contributors","subscribers_url":"https://api.github.com/repos/mikaleppanen/mbed-os/subscribers","subscription_url":"https://api.github.com/repos/mikaleppanen/mbed-os/subscription","commits_url":"https://api.github.com/repos/mikaleppanen/mbed-os/commits{/sha}","git_commits_url":"https://api.github.com/repos/mikaleppanen/mbed-os/git/commits{/sha}","comments_url":"https://api.github.com/repos/mikaleppanen/mbed-os/comments{/number}","issue_comment_url":"https://api.github.com/repos/mikaleppanen/mbed-os/issues/comments{/number}","contents_url":"https://api.github.com/repos/mikaleppanen/mbed-os/contents/{+path}","compare_url":"https://api.github.com/repos/mikaleppanen/mbed-os/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mikaleppanen/mbed-os/merges","archive_url":"https://api.github.com/repos/mikaleppanen/mbed-os/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mikaleppanen/mbed-os/downloads","issues_url":"https://api.github.com/repos/mikaleppanen/mbed-os/issues{/number}","pulls_url":"https://api.github.com/repos/mikaleppanen/mbed-os/pulls{/number}","milestones_url":"https://api.github.com/repos/mikaleppanen/mbed-os/milestones{/number}","notifications_url":"https://api.github.com/repos/mikaleppanen/mbed-os/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mikaleppanen/mbed-os/labels{/name}","releases_url":"https://api.github.com/repos/mikaleppanen/mbed-os/releases{/id}","deployments_url":"https://api.github.com/repos/mikaleppanen/mbed-os/deployments","created_at":"2016-09-19T09:31:54Z","updated_at":"2016-09-19T09:33:08Z","pushed_at":"2018-05-14T10:25:06Z","git_url":"git://github.com/mikaleppanen/mbed-os.git","ssh_url":"[email protected]:mikaleppanen/mbed-os.git","clone_url":"https://github.com/mikaleppanen/mbed-os.git","svn_url":"https://github.com/mikaleppanen/mbed-os","homepage":"https://mbed.com","size":199430,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ARMmbed:feature-emac","ref":"feature-emac","sha":"942209ed8c693938eb1b5b92ed12dc8b1996ec24","user":{"login":"ARMmbed","id":8916057,"avatar_url":"https://avatars3.githubusercontent.com/u/8916057?v=4","gravatar_id":"","url":"https://api.github.com/users/ARMmbed","html_url":"https://github.com/ARMmbed","followers_url":"https://api.github.com/users/ARMmbed/followers","following_url":"https://api.github.com/users/ARMmbed/following{/other_user}","gists_url":"https://api.github.com/users/ARMmbed/gists{/gist_id}","starred_url":"https://api.github.com/users/ARMmbed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARMmbed/subscriptions","organizations_url":"https://api.github.com/users/ARMmbed/orgs","repos_url":"https://api.github.com/users/ARMmbed/repos","events_url":"https://api.github.com/users/ARMmbed/events{/privacy}","received_events_url":"https://api.github.com/users/ARMmbed/received_events","type":"Organization","site_admin":false},"repo":{"id":8270972,"name":"mbed-os","full_name":"ARMmbed/mbed-os","owner":{"login":"ARMmbed","id":8916057,"avatar_url":"https://avatars3.githubusercontent.com/u/8916057?v=4","gravatar_id":"","url":"https://api.github.com/users/ARMmbed","html_url":"https://github.com/ARMmbed","followers_url":"https://api.github.com/users/ARMmbed/followers","following_url":"https://api.github.com/users/ARMmbed/following{/other_user}","gists_url":"https://api.github.com/users/ARMmbed/gists{/gist_id}","starred_url":"https://api.github.com/users/ARMmbed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARMmbed/subscriptions","organizations_url":"https://api.github.com/users/ARMmbed/orgs","repos_url":"https://api.github.com/users/ARMmbed/repos","events_url":"https://api.github.com/users/ARMmbed/events{/privacy}","received_events_url":"https://api.github.com/users/ARMmbed/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ARMmbed/mbed-os","description":"ARM Mbed OS is a platform operating system designed for the internet of things","fork":false,"url":"https://api.github.com/repos/ARMmbed/mbed-os","forks_url":"https://api.github.com/repos/ARMmbed/mbed-os/forks","keys_url":"https://api.github.com/repos/ARMmbed/mbed-os/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ARMmbed/mbed-os/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ARMmbed/mbed-os/teams","hooks_url":"https://api.github.com/repos/ARMmbed/mbed-os/hooks","issue_events_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/events{/number}","events_url":"https://api.github.com/repos/ARMmbed/mbed-os/events","assignees_url":"https://api.github.com/repos/ARMmbed/mbed-os/assignees{/user}","branches_url":"https://api.github.com/repos/ARMmbed/mbed-os/branches{/branch}","tags_url":"https://api.github.com/repos/ARMmbed/mbed-os/tags","blobs_url":"https://api.github.com/repos/ARMmbed/mbed-os/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ARMmbed/mbed-os/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ARMmbed/mbed-os/git/refs{/sha}","trees_url":"https://api.github.com/repos/ARMmbed/mbed-os/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ARMmbed/mbed-os/statuses/{sha}","languages_url":"https://api.github.com/repos/ARMmbed/mbed-os/languages","stargazers_url":"https://api.github.com/repos/ARMmbed/mbed-os/stargazers","contributors_url":"https://api.github.com/repos/ARMmbed/mbed-os/contributors","subscribers_url":"https://api.github.com/repos/ARMmbed/mbed-os/subscribers","subscription_url":"https://api.github.com/repos/ARMmbed/mbed-os/subscription","commits_url":"https://api.github.com/repos/ARMmbed/mbed-os/commits{/sha}","git_commits_url":"https://api.github.com/repos/ARMmbed/mbed-os/git/commits{/sha}","comments_url":"https://api.github.com/repos/ARMmbed/mbed-os/comments{/number}","issue_comment_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/comments{/number}","contents_url":"https://api.github.com/repos/ARMmbed/mbed-os/contents/{+path}","compare_url":"https://api.github.com/repos/ARMmbed/mbed-os/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ARMmbed/mbed-os/merges","archive_url":"https://api.github.com/repos/ARMmbed/mbed-os/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ARMmbed/mbed-os/downloads","issues_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues{/number}","pulls_url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls{/number}","milestones_url":"https://api.github.com/repos/ARMmbed/mbed-os/milestones{/number}","notifications_url":"https://api.github.com/repos/ARMmbed/mbed-os/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ARMmbed/mbed-os/labels{/name}","releases_url":"https://api.github.com/repos/ARMmbed/mbed-os/releases{/id}","deployments_url":"https://api.github.com/repos/ARMmbed/mbed-os/deployments","created_at":"2013-02-18T15:23:11Z","updated_at":"2018-05-14T07:35:43Z","pushed_at":"2018-05-14T10:25:09Z","git_url":"git://github.com/ARMmbed/mbed-os.git","ssh_url":"[email protected]:ARMmbed/mbed-os.git","clone_url":"https://github.com/ARMmbed/mbed-os.git","svn_url":"https://github.com/ARMmbed/mbed-os","homepage":"https://mbed.com","size":206410,"stargazers_count":1653,"watchers_count":1653,"language":"C","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1450,"mirror_url":null,"archived":false,"open_issues_count":492,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":1450,"open_issues":492,"watchers":1653,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/6751"},"html":{"href":"https://github.com/ARMmbed/mbed-os/pull/6751"},"issue":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/issues/6751"},"comments":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/issues/6751/comments"},"review_comments":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/6751/comments"},"review_comment":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/6751/commits"},"statuses":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/statuses/0483cca1335d1bf40dd82fbe1143ea632704ec6e"}},"author_association":"CONTRIBUTOR"}} | {
"id": 8270972,
"name": "ARMmbed/mbed-os",
"url": "https://api.github.com/repos/ARMmbed/mbed-os"
} | {
"id": 13345641,
"login": "mikaleppanen",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/13345641?",
"url": "https://api.github.com/users/mikaleppanen"
} | {
"id": 8916057,
"login": "ARMmbed",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/8916057?",
"url": "https://api.github.com/orgs/ARMmbed"
} | 2018-05-14T10:28:02 | 7669688804 | {"actor":{"display_login":"mikaleppanen"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/ARMmbed/nanostack-libservice/pulls/comments/197137221","pull_request_review_id":130820956,"id":197137221,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NzEzNzIyMQ==","diff_hunk":"@@ -0,0 +1,66 @@\n+/*\n+ * Copyright (c) 2014-2018 ARM Limited. All rights reserved.\n+ * SPDX-License-Identifier: Apache-2.0\n+ * Licensed under the Apache License, Version 2.0 (the License); you may\n+ * not use this file except in compliance with the License.\n+ * You may obtain a copy of the License at\n+ *\n+ * http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an AS IS BASIS, WITHOUT\n+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+#include <string.h>\n+#include <stdlib.h>\n+#include <stdint.h>\n+#include \"common_functions.h\"\n+#include \"ip4string.h\"\n+\n+/**\n+ * Convert numeric IPv4 address string to a binary.\n+ * \\param ip4addr IPv4 address in string format.\n+ * \\param len Length of IPv4 string, maximum of 16..\n+ * \\param dest buffer for address. MUST be 4 bytes.\n+ * \\return boolean set to true if correction succeded, false if it didn't\n+ */\n+bool stoip4(const char *ip4addr, size_t len, void *dest)\n+{\n+ uint8_t *addr = dest;\n+\n+ if (len > 16) { // Too long, not possible\n+ return false;\n+ }\n+\n+ uint_fast8_t stringLength = 0;\n+\n+ //Iterate over each component of the IP\n+ for (uint_fast8_t byteCount = 0; byteCount < 4; byteCount++) {\n+\n+ //For each component, we convert it to the raw value\n+ uint16_t byte = 0;\n+ while(stringLength < len && ip4addr[stringLength] >= '0' && ip4addr[stringLength] <= '9') {\n+ byte *= 10;\n+ byte += ip4addr[stringLength++] - '0';\n+\n+ //We go over the maximum value for an IPv4 component\n+ if(byte > 0xff) {\n+ return false;\n+ }\n+ }\n+\n+ //Append the component\n+ addr[byteCount] = (uint8_t) byte;\n+\n+ //If we're at the end or if the next character is invalid, we stop","path":"source/libip4string/stoip4.c","position":57,"original_position":57,"commit_id":"06dde1a113ce7b3f38920b29faf639f50dcf2b19","original_commit_id":"06dde1a113ce7b3f38920b29faf639f50dcf2b19","user":{"login":"Taiki-San","id":731787,"node_id":"MDQ6VXNlcjczMTc4Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/731787?v=4","gravatar_id":"","url":"https://api.github.com/users/Taiki-San","html_url":"https://github.com/Taiki-San","followers_url":"https://api.github.com/users/Taiki-San/followers","following_url":"https://api.github.com/users/Taiki-San/following{/other_user}","gists_url":"https://api.github.com/users/Taiki-San/gists{/gist_id}","starred_url":"https://api.github.com/users/Taiki-San/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Taiki-San/subscriptions","organizations_url":"https://api.github.com/users/Taiki-San/orgs","repos_url":"https://api.github.com/users/Taiki-San/repos","events_url":"https://api.github.com/users/Taiki-San/events{/privacy}","received_events_url":"https://api.github.com/users/Taiki-San/received_events","type":"User","site_admin":false},"body":"I'm thinking about replacing `return false` by `return byteCount == 3` not to perform this check within the loop. Thoughts?","created_at":"2018-06-21T13:42:51Z","updated_at":"2018-06-21T13:42:52Z","html_url":"https://github.com/ARMmbed/nanostack-libservice/pull/69#discussion_r197137221","pull_request_url":"https://api.github.com/repos/ARMmbed/nanostack-libservice/pulls/69","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/ARMmbed/nanostack-libservice/pulls/comments/197137221"},"html":{"href":"https://github.com/ARMmbed/nanostack-libservice/pull/69#discussion_r197137221"},"pull_request":{"href":"https://api.github.com/repos/ARMmbed/nanostack-libservice/pulls/69"}},"in_reply_to_id":197127340},"pull_request":{"url":"https://api.github.com/repos/ARMmbed/nanostack-libservice/pulls/69","id":195950776,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1OTUwNzc2","html_url":"https://github.com/ARMmbed/nanostack-libservice/pull/69","diff_url":"https://github.com/ARMmbed/nanostack-libservice/pull/69.diff","patch_url":"https://github.com/ARMmbed/nanostack-libservice/pull/69.patch","issue_url":"https://api.github.com/repos/ARMmbed/nanostack-libservice/issues/69","number":69,"state":"open","locked":false,"title":"Add IPv4 string conversion utils","user":{"login":"Taiki-San","id":731787,"node_id":"MDQ6VXNlcjczMTc4Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/731787?v=4","gravatar_id":"","url":"https://api.github.com/users/Taiki-San","html_url":"https://github.com/Taiki-San","followers_url":"https://api.github.com/users/Taiki-San/followers","following_url":"https://api.github.com/users/Taiki-San/following{/other_user}","gists_url":"https://api.github.com/users/Taiki-San/gists{/gist_id}","starred_url":"https://api.github.com/users/Taiki-San/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Taiki-San/subscriptions","organizations_url":"https://api.github.com/users/Taiki-San/orgs","repos_url":"https://api.github.com/users/Taiki-San/repos","events_url":"https://api.github.com/users/Taiki-San/events{/privacy}","received_events_url":"https://api.github.com/users/Taiki-San/received_events","type":"User","site_admin":false},"body":"This PR is in response to https://github.com/ARMmbed/mbed-os/pull/6293#issuecomment-396533529 and introduce two utils, enabling : \r\n\r\n- Conversion of IPv4 adresses from a string to an array of bytes using `stoip4`\r\n- Conversion of IPv4 adresses from an array of bytes to a string, using `ip4tos`\r\n\r\nWas not sure about the convention regarding the headers, so went with the existing ones after updating the year. Do you have any comment?\r\n\r\nIf this PR go through, I'll follow with the second suggestion of @kjbracey-arm then change the original PR (https://github.com/ARMmbed/mbed-os/pull/6293) to use those new utils, if that's ok with everyone.","created_at":"2018-06-19T20:38:01Z","updated_at":"2018-06-21T13:42:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"da33dc0a1c56d48942645b7e71c58f29c5f551b1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ARMmbed/nanostack-libservice/pulls/69/commits","review_comments_url":"https://api.github.com/repos/ARMmbed/nanostack-libservice/pulls/69/comments","review_comment_url":"https://api.github.com/repos/ARMmbed/nanostack-libservice/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ARMmbed/nanostack-libservice/issues/69/comments","statuses_url":"https://api.github.com/repos/ARMmbed/nanostack-libservice/statuses/06dde1a113ce7b3f38920b29faf639f50dcf2b19","head":{"label":"Taiki-San:ipv4","ref":"ipv4","sha":"06dde1a113ce7b3f38920b29faf639f50dcf2b19","user":{"login":"Taiki-San","id":731787,"node_id":"MDQ6VXNlcjczMTc4Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/731787?v=4","gravatar_id":"","url":"https://api.github.com/users/Taiki-San","html_url":"https://github.com/Taiki-San","followers_url":"https://api.github.com/users/Taiki-San/followers","following_url":"https://api.github.com/users/Taiki-San/following{/other_user}","gists_url":"https://api.github.com/users/Taiki-San/gists{/gist_id}","starred_url":"https://api.github.com/users/Taiki-San/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Taiki-San/subscriptions","organizations_url":"https://api.github.com/users/Taiki-San/orgs","repos_url":"https://api.github.com/users/Taiki-San/repos","events_url":"https://api.github.com/users/Taiki-San/events{/privacy}","received_events_url":"https://api.github.com/users/Taiki-San/received_events","type":"User","site_admin":false},"repo":{"id":137780913,"node_id":"MDEwOlJlcG9zaXRvcnkxMzc3ODA5MTM=","name":"nanostack-libservice","full_name":"Taiki-San/nanostack-libservice","owner":{"login":"Taiki-San","id":731787,"node_id":"MDQ6VXNlcjczMTc4Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/731787?v=4","gravatar_id":"","url":"https://api.github.com/users/Taiki-San","html_url":"https://github.com/Taiki-San","followers_url":"https://api.github.com/users/Taiki-San/followers","following_url":"https://api.github.com/users/Taiki-San/following{/other_user}","gists_url":"https://api.github.com/users/Taiki-San/gists{/gist_id}","starred_url":"https://api.github.com/users/Taiki-San/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Taiki-San/subscriptions","organizations_url":"https://api.github.com/users/Taiki-San/orgs","repos_url":"https://api.github.com/users/Taiki-San/repos","events_url":"https://api.github.com/users/Taiki-San/events{/privacy}","received_events_url":"https://api.github.com/users/Taiki-San/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Taiki-San/nanostack-libservice","description":null,"fork":true,"url":"https://api.github.com/repos/Taiki-San/nanostack-libservice","forks_url":"https://api.github.com/repos/Taiki-San/nanostack-libservice/forks","keys_url":"https://api.github.com/repos/Taiki-San/nanostack-libservice/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Taiki-San/nanostack-libservice/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Taiki-San/nanostack-libservice/teams","hooks_url":"https://api.github.com/repos/Taiki-San/nanostack-libservice/hooks","issue_events_url":"https://api.github.com/repos/Taiki-San/nanostack-libservice/issues/events{/number}","events_url":"https://api.github.com/repos/Taiki-San/nanostack-libservice/events","assignees_url":"https://api.github.com/repos/Taiki-San/nanostack-libservice/assignees{/user}","branches_url":"https://api.github.com/repos/Taiki-San/nanostack-libservice/branches{/branch}","tags_url":"https://api.github.com/repos/Taiki-San/nanostack-libservice/tags","blobs_url":"https://api.github.com/repos/Taiki-San/nanostack-libservice/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Taiki-San/nanostack-libservice/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Taiki-San/nanostack-libservice/git/refs{/sha}","trees_url":"https://api.github.com/repos/Taiki-San/nanostack-libservice/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Taiki-San/nanostack-libservice/statuses/{sha}","languages_url":"https://api.github.com/repos/Taiki-San/nanostack-libservice/languages","stargazers_url":"https://api.github.com/repos/Taiki-San/nanostack-libservice/stargazers","contributors_url":"https://api.github.com/repos/Taiki-San/nanostack-libservice/contributors","subscribers_url":"https://api.github.com/repos/Taiki-San/nanostack-libservice/subscribers","subscription_url":"https://api.github.com/repos/Taiki-San/nanostack-libservice/subscription","commits_url":"https://api.github.com/repos/Taiki-San/nanostack-libservice/commits{/sha}","git_commits_url":"https://api.github.com/repos/Taiki-San/nanostack-libservice/git/commits{/sha}","comments_url":"https://api.github.com/repos/Taiki-San/nanostack-libservice/comments{/number}","issue_comment_url":"https://api.github.com/repos/Taiki-San/nanostack-libservice/issues/comments{/number}","contents_url":"https://api.github.com/repos/Taiki-San/nanostack-libservice/contents/{+path}","compare_url":"https://api.github.com/repos/Taiki-San/nanostack-libservice/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Taiki-San/nanostack-libservice/merges","archive_url":"https://api.github.com/repos/Taiki-San/nanostack-libservice/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Taiki-San/nanostack-libservice/downloads","issues_url":"https://api.github.com/repos/Taiki-San/nanostack-libservice/issues{/number}","pulls_url":"https://api.github.com/repos/Taiki-San/nanostack-libservice/pulls{/number}","milestones_url":"https://api.github.com/repos/Taiki-San/nanostack-libservice/milestones{/number}","notifications_url":"https://api.github.com/repos/Taiki-San/nanostack-libservice/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Taiki-San/nanostack-libservice/labels{/name}","releases_url":"https://api.github.com/repos/Taiki-San/nanostack-libservice/releases{/id}","deployments_url":"https://api.github.com/repos/Taiki-San/nanostack-libservice/deployments","created_at":"2018-06-18T16:56:34Z","updated_at":"2018-06-18T16:56:36Z","pushed_at":"2018-06-19T20:29:36Z","git_url":"git://github.com/Taiki-San/nanostack-libservice.git","ssh_url":"[email protected]:Taiki-San/nanostack-libservice.git","clone_url":"https://github.com/Taiki-San/nanostack-libservice.git","svn_url":"https://github.com/Taiki-San/nanostack-libservice","homepage":null,"size":193,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ARMmbed:master","ref":"master","sha":"86fa01cebf553764122d7cbf78dff596e6968b8f","user":{"login":"ARMmbed","id":8916057,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg5MTYwNTc=","avatar_url":"https://avatars3.githubusercontent.com/u/8916057?v=4","gravatar_id":"","url":"https://api.github.com/users/ARMmbed","html_url":"https://github.com/ARMmbed","followers_url":"https://api.github.com/users/ARMmbed/followers","following_url":"https://api.github.com/users/ARMmbed/following{/other_user}","gists_url":"https://api.github.com/users/ARMmbed/gists{/gist_id}","starred_url":"https://api.github.com/users/ARMmbed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARMmbed/subscriptions","organizations_url":"https://api.github.com/users/ARMmbed/orgs","repos_url":"https://api.github.com/users/ARMmbed/repos","events_url":"https://api.github.com/users/ARMmbed/events{/privacy}","received_events_url":"https://api.github.com/users/ARMmbed/received_events","type":"Organization","site_admin":false},"repo":{"id":38824282,"node_id":"MDEwOlJlcG9zaXRvcnkzODgyNDI4Mg==","name":"nanostack-libservice","full_name":"ARMmbed/nanostack-libservice","owner":{"login":"ARMmbed","id":8916057,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg5MTYwNTc=","avatar_url":"https://avatars3.githubusercontent.com/u/8916057?v=4","gravatar_id":"","url":"https://api.github.com/users/ARMmbed","html_url":"https://github.com/ARMmbed","followers_url":"https://api.github.com/users/ARMmbed/followers","following_url":"https://api.github.com/users/ARMmbed/following{/other_user}","gists_url":"https://api.github.com/users/ARMmbed/gists{/gist_id}","starred_url":"https://api.github.com/users/ARMmbed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARMmbed/subscriptions","organizations_url":"https://api.github.com/users/ARMmbed/orgs","repos_url":"https://api.github.com/users/ARMmbed/repos","events_url":"https://api.github.com/users/ARMmbed/events{/privacy}","received_events_url":"https://api.github.com/users/ARMmbed/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ARMmbed/nanostack-libservice","description":null,"fork":false,"url":"https://api.github.com/repos/ARMmbed/nanostack-libservice","forks_url":"https://api.github.com/repos/ARMmbed/nanostack-libservice/forks","keys_url":"https://api.github.com/repos/ARMmbed/nanostack-libservice/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ARMmbed/nanostack-libservice/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ARMmbed/nanostack-libservice/teams","hooks_url":"https://api.github.com/repos/ARMmbed/nanostack-libservice/hooks","issue_events_url":"https://api.github.com/repos/ARMmbed/nanostack-libservice/issues/events{/number}","events_url":"https://api.github.com/repos/ARMmbed/nanostack-libservice/events","assignees_url":"https://api.github.com/repos/ARMmbed/nanostack-libservice/assignees{/user}","branches_url":"https://api.github.com/repos/ARMmbed/nanostack-libservice/branches{/branch}","tags_url":"https://api.github.com/repos/ARMmbed/nanostack-libservice/tags","blobs_url":"https://api.github.com/repos/ARMmbed/nanostack-libservice/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ARMmbed/nanostack-libservice/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ARMmbed/nanostack-libservice/git/refs{/sha}","trees_url":"https://api.github.com/repos/ARMmbed/nanostack-libservice/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ARMmbed/nanostack-libservice/statuses/{sha}","languages_url":"https://api.github.com/repos/ARMmbed/nanostack-libservice/languages","stargazers_url":"https://api.github.com/repos/ARMmbed/nanostack-libservice/stargazers","contributors_url":"https://api.github.com/repos/ARMmbed/nanostack-libservice/contributors","subscribers_url":"https://api.github.com/repos/ARMmbed/nanostack-libservice/subscribers","subscription_url":"https://api.github.com/repos/ARMmbed/nanostack-libservice/subscription","commits_url":"https://api.github.com/repos/ARMmbed/nanostack-libservice/commits{/sha}","git_commits_url":"https://api.github.com/repos/ARMmbed/nanostack-libservice/git/commits{/sha}","comments_url":"https://api.github.com/repos/ARMmbed/nanostack-libservice/comments{/number}","issue_comment_url":"https://api.github.com/repos/ARMmbed/nanostack-libservice/issues/comments{/number}","contents_url":"https://api.github.com/repos/ARMmbed/nanostack-libservice/contents/{+path}","compare_url":"https://api.github.com/repos/ARMmbed/nanostack-libservice/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ARMmbed/nanostack-libservice/merges","archive_url":"https://api.github.com/repos/ARMmbed/nanostack-libservice/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ARMmbed/nanostack-libservice/downloads","issues_url":"https://api.github.com/repos/ARMmbed/nanostack-libservice/issues{/number}","pulls_url":"https://api.github.com/repos/ARMmbed/nanostack-libservice/pulls{/number}","milestones_url":"https://api.github.com/repos/ARMmbed/nanostack-libservice/milestones{/number}","notifications_url":"https://api.github.com/repos/ARMmbed/nanostack-libservice/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ARMmbed/nanostack-libservice/labels{/name}","releases_url":"https://api.github.com/repos/ARMmbed/nanostack-libservice/releases{/id}","deployments_url":"https://api.github.com/repos/ARMmbed/nanostack-libservice/deployments","created_at":"2015-07-09T14:11:00Z","updated_at":"2018-06-19T12:05:22Z","pushed_at":"2018-06-21T06:53:29Z","git_url":"git://github.com/ARMmbed/nanostack-libservice.git","ssh_url":"[email protected]:ARMmbed/nanostack-libservice.git","clone_url":"https://github.com/ARMmbed/nanostack-libservice.git","svn_url":"https://github.com/ARMmbed/nanostack-libservice","homepage":null,"size":194,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":8,"open_issues":6,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ARMmbed/nanostack-libservice/pulls/69"},"html":{"href":"https://github.com/ARMmbed/nanostack-libservice/pull/69"},"issue":{"href":"https://api.github.com/repos/ARMmbed/nanostack-libservice/issues/69"},"comments":{"href":"https://api.github.com/repos/ARMmbed/nanostack-libservice/issues/69/comments"},"review_comments":{"href":"https://api.github.com/repos/ARMmbed/nanostack-libservice/pulls/69/comments"},"review_comment":{"href":"https://api.github.com/repos/ARMmbed/nanostack-libservice/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ARMmbed/nanostack-libservice/pulls/69/commits"},"statuses":{"href":"https://api.github.com/repos/ARMmbed/nanostack-libservice/statuses/06dde1a113ce7b3f38920b29faf639f50dcf2b19"}},"author_association":"NONE"}} | {
"id": 38824282,
"name": "ARMmbed/nanostack-libservice",
"url": "https://api.github.com/repos/ARMmbed/nanostack-libservice"
} | {
"id": 731787,
"login": "Taiki-San",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/731787?",
"url": "https://api.github.com/users/Taiki-San"
} | {
"id": 8916057,
"login": "ARMmbed",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/8916057?",
"url": "https://api.github.com/orgs/ARMmbed"
} | 2018-06-21T13:42:51 | 7858352033 | {"actor":{"display_login":"Taiki-San"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/datalad/datalad/pulls/comments/212420995","pull_request_review_id":149051700,"id":212420995,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMjQyMDk5NQ==","diff_hunk":"@@ -146,3 +151,78 @@ def test_Providers_from_config__files(sysdir, userdir, dsdir):\n providers = Providers.from_config_files(reload=True)\n provider = providers.get_provider('https://crcns.org/data....')\n assert_equal(provider.name, 'usercrcns')\n+\n+\n+@with_tempfile(mkdir=True)\n+def test_providers_enter_new(path):\n+ with patch.multiple(\"appdirs.AppDirs\", site_config_dir=None,\n+ user_config_dir=path):\n+ providers_dir = op.join(path, \"providers\")\n+ providers = Providers.from_config_files(reload=True)\n+\n+ url = \"blah://thing\"\n+ url_re = \"blah:\\/\\/.*\"\n+ auth_type = \"http_auth\"\n+ creds = \"user_password\"\n+\n+ @with_testsui(responses=[\"foo\", url_re, auth_type,\n+ creds, \"no\"])\n+ def no_save():\n+ providers.enter_new(url)\n+ no_save()\n+ assert_false(op.exists(op.join(providers_dir, \"foo.cfg\")))\n+\n+ @with_testsui(responses=[\"foo\", url_re, auth_type,\n+ creds, \"yes\"])\n+ def save():\n+ providers.enter_new(url)\n+ save()\n+ ok_exists(op.join(providers_dir, \"foo.cfg\"))\n+\n+ create_tree(path=providers_dir, tree={\"exists.cfg\": \"\"})\n+ @with_testsui(responses=[\"exists\", \"foobert\", url_re,\n+ auth_type, creds, \"yes\"])\n+ def already_exists():\n+ providers.enter_new(url)\n+ already_exists()\n+ ok_exists(op.join(providers_dir, \"foobert.cfg\"))\n+\n+ @with_testsui(responses=[\"crawdad\", \"yes\"])\n+ def known_provider():\n+ providers.enter_new(url)\n+ known_provider()\n+\n+ @with_testsui(responses=[\"foo2\", url_re, auth_type,\n+ creds, \"yes\"])\n+ def auth_types():\n+ providers.enter_new(url, auth_types=[\"http_basic_auth\"])\n+ auth_types()\n+ ok_exists(op.join(providers_dir, \"foo2.cfg\"))\n+\n+ @with_testsui(responses=[\"foo3\", \"doesn't match\", url_re, auth_type,\n+ creds, \"yes\"])\n+ def nonmatching_url():\n+ providers.enter_new(url, auth_types=[\"http_basic_auth\"])\n+ nonmatching_url()\n+ ok_exists(op.join(providers_dir, \"foo3.cfg\"))","path":"datalad/downloaders/tests/test_providers.py","position":95,"original_position":95,"commit_id":"32216bee42677b3767009c66b91cd2037e28aaf8","original_commit_id":"32216bee42677b3767009c66b91cd2037e28aaf8","user":{"login":"yarikoptic","id":39889,"node_id":"MDQ6VXNlcjM5ODg5","avatar_url":"https://avatars3.githubusercontent.com/u/39889?v=4","gravatar_id":"","url":"https://api.github.com/users/yarikoptic","html_url":"https://github.com/yarikoptic","followers_url":"https://api.github.com/users/yarikoptic/followers","following_url":"https://api.github.com/users/yarikoptic/following{/other_user}","gists_url":"https://api.github.com/users/yarikoptic/gists{/gist_id}","starred_url":"https://api.github.com/users/yarikoptic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yarikoptic/subscriptions","organizations_url":"https://api.github.com/users/yarikoptic/orgs","repos_url":"https://api.github.com/users/yarikoptic/repos","events_url":"https://api.github.com/users/yarikoptic/events{/privacy}","received_events_url":"https://api.github.com/users/yarikoptic/received_events","type":"User","site_admin":false},"body":"you did help! ok,I could continue whenever I get a chance, but not sure when it would be :-(","created_at":"2018-08-23T18:57:26Z","updated_at":"2018-08-23T18:57:27Z","html_url":"https://github.com/datalad/datalad/pull/2708#discussion_r212420995","pull_request_url":"https://api.github.com/repos/datalad/datalad/pulls/2708","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/datalad/datalad/pulls/comments/212420995"},"html":{"href":"https://github.com/datalad/datalad/pull/2708#discussion_r212420995"},"pull_request":{"href":"https://api.github.com/repos/datalad/datalad/pulls/2708"}},"in_reply_to_id":212414669},"pull_request":{"url":"https://api.github.com/repos/datalad/datalad/pulls/2708","id":202989322,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyOTg5MzIy","html_url":"https://github.com/datalad/datalad/pull/2708","diff_url":"https://github.com/datalad/datalad/pull/2708.diff","patch_url":"https://github.com/datalad/datalad/pull/2708.patch","issue_url":"https://api.github.com/repos/datalad/datalad/issues/2708","number":2708,"state":"open","locked":false,"title":"ENH+BF: S3 and downloaders: support anonymous access + interface to add new providers","user":{"login":"yarikoptic","id":39889,"node_id":"MDQ6VXNlcjM5ODg5","avatar_url":"https://avatars3.githubusercontent.com/u/39889?v=4","gravatar_id":"","url":"https://api.github.com/users/yarikoptic","html_url":"https://github.com/yarikoptic","followers_url":"https://api.github.com/users/yarikoptic/followers","following_url":"https://api.github.com/users/yarikoptic/following{/other_user}","gists_url":"https://api.github.com/users/yarikoptic/gists{/gist_id}","starred_url":"https://api.github.com/users/yarikoptic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yarikoptic/subscriptions","organizations_url":"https://api.github.com/users/yarikoptic/orgs","repos_url":"https://api.github.com/users/yarikoptic/repos","events_url":"https://api.github.com/users/yarikoptic/events{/privacy}","received_events_url":"https://api.github.com/users/yarikoptic/received_events","type":"User","site_admin":false},"body":"- [x] Basic and Digest HTTP Auth should work now\r\n- [x] In interactive session would now allow to establish a new provider configuration for which would get saved into a user directory\r\n- [ ] unittests for `process_www_authenticate` etc\r\n- [ ] Test at least for the major portions of the UI to enter the new provider/credential\r\n- [ ] may be would include or just be part of integration test above to test Basic and Digest auth on https://jigsaw.w3.org/HTTP/Basic and https://jigsaw.w3.org/HTTP/Digest\r\n- [x] may be more RFing for credentials (allow to make new one persistent etc)\r\nso marking WIP for now ","created_at":"2018-07-21T03:13:52Z","updated_at":"2018-08-23T18:57:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"355a4cd98290a4917387304ed98950be8b0cbbfe","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":488743117,"node_id":"MDU6TGFiZWw0ODg3NDMxMTc=","url":"https://api.github.com/repos/datalad/datalad/labels/needs-review","name":"needs-review","color":"b60205","default":false}],"milestone":{"url":"https://api.github.com/repos/datalad/datalad/milestones/54","html_url":"https://github.com/datalad/datalad/milestone/54","labels_url":"https://api.github.com/repos/datalad/datalad/milestones/54/labels","id":3542067,"node_id":"MDk6TWlsZXN0b25lMzU0MjA2Nw==","number":54,"title":"Release 0.10.3","description":"","creator":{"login":"yarikoptic","id":39889,"node_id":"MDQ6VXNlcjM5ODg5","avatar_url":"https://avatars3.githubusercontent.com/u/39889?v=4","gravatar_id":"","url":"https://api.github.com/users/yarikoptic","html_url":"https://github.com/yarikoptic","followers_url":"https://api.github.com/users/yarikoptic/followers","following_url":"https://api.github.com/users/yarikoptic/following{/other_user}","gists_url":"https://api.github.com/users/yarikoptic/gists{/gist_id}","starred_url":"https://api.github.com/users/yarikoptic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yarikoptic/subscriptions","organizations_url":"https://api.github.com/users/yarikoptic/orgs","repos_url":"https://api.github.com/users/yarikoptic/repos","events_url":"https://api.github.com/users/yarikoptic/events{/privacy}","received_events_url":"https://api.github.com/users/yarikoptic/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":5,"state":"open","created_at":"2018-08-02T13:36:57Z","updated_at":"2018-08-15T14:01:27Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/datalad/datalad/pulls/2708/commits","review_comments_url":"https://api.github.com/repos/datalad/datalad/pulls/2708/comments","review_comment_url":"https://api.github.com/repos/datalad/datalad/pulls/comments{/number}","comments_url":"https://api.github.com/repos/datalad/datalad/issues/2708/comments","statuses_url":"https://api.github.com/repos/datalad/datalad/statuses/32216bee42677b3767009c66b91cd2037e28aaf8","head":{"label":"yarikoptic:enh-s3","ref":"enh-s3","sha":"32216bee42677b3767009c66b91cd2037e28aaf8","user":{"login":"yarikoptic","id":39889,"node_id":"MDQ6VXNlcjM5ODg5","avatar_url":"https://avatars3.githubusercontent.com/u/39889?v=4","gravatar_id":"","url":"https://api.github.com/users/yarikoptic","html_url":"https://github.com/yarikoptic","followers_url":"https://api.github.com/users/yarikoptic/followers","following_url":"https://api.github.com/users/yarikoptic/following{/other_user}","gists_url":"https://api.github.com/users/yarikoptic/gists{/gist_id}","starred_url":"https://api.github.com/users/yarikoptic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yarikoptic/subscriptions","organizations_url":"https://api.github.com/users/yarikoptic/orgs","repos_url":"https://api.github.com/users/yarikoptic/repos","events_url":"https://api.github.com/users/yarikoptic/events{/privacy}","received_events_url":"https://api.github.com/users/yarikoptic/received_events","type":"User","site_admin":false},"repo":{"id":30428483,"node_id":"MDEwOlJlcG9zaXRvcnkzMDQyODQ4Mw==","name":"datalad","full_name":"yarikoptic/datalad","owner":{"login":"yarikoptic","id":39889,"node_id":"MDQ6VXNlcjM5ODg5","avatar_url":"https://avatars3.githubusercontent.com/u/39889?v=4","gravatar_id":"","url":"https://api.github.com/users/yarikoptic","html_url":"https://github.com/yarikoptic","followers_url":"https://api.github.com/users/yarikoptic/followers","following_url":"https://api.github.com/users/yarikoptic/following{/other_user}","gists_url":"https://api.github.com/users/yarikoptic/gists{/gist_id}","starred_url":"https://api.github.com/users/yarikoptic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yarikoptic/subscriptions","organizations_url":"https://api.github.com/users/yarikoptic/orgs","repos_url":"https://api.github.com/users/yarikoptic/repos","events_url":"https://api.github.com/users/yarikoptic/events{/privacy}","received_events_url":"https://api.github.com/users/yarikoptic/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yarikoptic/datalad","description":"Keep scientific data under control by git and git-annex","fork":true,"url":"https://api.github.com/repos/yarikoptic/datalad","forks_url":"https://api.github.com/repos/yarikoptic/datalad/forks","keys_url":"https://api.github.com/repos/yarikoptic/datalad/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yarikoptic/datalad/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yarikoptic/datalad/teams","hooks_url":"https://api.github.com/repos/yarikoptic/datalad/hooks","issue_events_url":"https://api.github.com/repos/yarikoptic/datalad/issues/events{/number}","events_url":"https://api.github.com/repos/yarikoptic/datalad/events","assignees_url":"https://api.github.com/repos/yarikoptic/datalad/assignees{/user}","branches_url":"https://api.github.com/repos/yarikoptic/datalad/branches{/branch}","tags_url":"https://api.github.com/repos/yarikoptic/datalad/tags","blobs_url":"https://api.github.com/repos/yarikoptic/datalad/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yarikoptic/datalad/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yarikoptic/datalad/git/refs{/sha}","trees_url":"https://api.github.com/repos/yarikoptic/datalad/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yarikoptic/datalad/statuses/{sha}","languages_url":"https://api.github.com/repos/yarikoptic/datalad/languages","stargazers_url":"https://api.github.com/repos/yarikoptic/datalad/stargazers","contributors_url":"https://api.github.com/repos/yarikoptic/datalad/contributors","subscribers_url":"https://api.github.com/repos/yarikoptic/datalad/subscribers","subscription_url":"https://api.github.com/repos/yarikoptic/datalad/subscription","commits_url":"https://api.github.com/repos/yarikoptic/datalad/commits{/sha}","git_commits_url":"https://api.github.com/repos/yarikoptic/datalad/git/commits{/sha}","comments_url":"https://api.github.com/repos/yarikoptic/datalad/comments{/number}","issue_comment_url":"https://api.github.com/repos/yarikoptic/datalad/issues/comments{/number}","contents_url":"https://api.github.com/repos/yarikoptic/datalad/contents/{+path}","compare_url":"https://api.github.com/repos/yarikoptic/datalad/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yarikoptic/datalad/merges","archive_url":"https://api.github.com/repos/yarikoptic/datalad/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yarikoptic/datalad/downloads","issues_url":"https://api.github.com/repos/yarikoptic/datalad/issues{/number}","pulls_url":"https://api.github.com/repos/yarikoptic/datalad/pulls{/number}","milestones_url":"https://api.github.com/repos/yarikoptic/datalad/milestones{/number}","notifications_url":"https://api.github.com/repos/yarikoptic/datalad/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yarikoptic/datalad/labels{/name}","releases_url":"https://api.github.com/repos/yarikoptic/datalad/releases{/id}","deployments_url":"https://api.github.com/repos/yarikoptic/datalad/deployments","created_at":"2015-02-06T19:12:34Z","updated_at":"2016-02-25T18:47:34Z","pushed_at":"2018-08-23T18:31:01Z","git_url":"git://github.com/yarikoptic/datalad.git","ssh_url":"[email protected]:yarikoptic/datalad.git","clone_url":"https://github.com/yarikoptic/datalad.git","svn_url":"https://github.com/yarikoptic/datalad","homepage":null,"size":13815,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"datalad:master","ref":"master","sha":"90d18e325aa308ff9643a0b310ea8a09621e1607","user":{"login":"datalad","id":8927200,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg5MjcyMDA=","avatar_url":"https://avatars2.githubusercontent.com/u/8927200?v=4","gravatar_id":"","url":"https://api.github.com/users/datalad","html_url":"https://github.com/datalad","followers_url":"https://api.github.com/users/datalad/followers","following_url":"https://api.github.com/users/datalad/following{/other_user}","gists_url":"https://api.github.com/users/datalad/gists{/gist_id}","starred_url":"https://api.github.com/users/datalad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/datalad/subscriptions","organizations_url":"https://api.github.com/users/datalad/orgs","repos_url":"https://api.github.com/users/datalad/repos","events_url":"https://api.github.com/users/datalad/events{/privacy}","received_events_url":"https://api.github.com/users/datalad/received_events","type":"Organization","site_admin":false},"repo":{"id":14052034,"node_id":"MDEwOlJlcG9zaXRvcnkxNDA1MjAzNA==","name":"datalad","full_name":"datalad/datalad","owner":{"login":"datalad","id":8927200,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg5MjcyMDA=","avatar_url":"https://avatars2.githubusercontent.com/u/8927200?v=4","gravatar_id":"","url":"https://api.github.com/users/datalad","html_url":"https://github.com/datalad","followers_url":"https://api.github.com/users/datalad/followers","following_url":"https://api.github.com/users/datalad/following{/other_user}","gists_url":"https://api.github.com/users/datalad/gists{/gist_id}","starred_url":"https://api.github.com/users/datalad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/datalad/subscriptions","organizations_url":"https://api.github.com/users/datalad/orgs","repos_url":"https://api.github.com/users/datalad/repos","events_url":"https://api.github.com/users/datalad/events{/privacy}","received_events_url":"https://api.github.com/users/datalad/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/datalad/datalad","description":"Keep scientific data under control with git and git-annex","fork":false,"url":"https://api.github.com/repos/datalad/datalad","forks_url":"https://api.github.com/repos/datalad/datalad/forks","keys_url":"https://api.github.com/repos/datalad/datalad/keys{/key_id}","collaborators_url":"https://api.github.com/repos/datalad/datalad/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/datalad/datalad/teams","hooks_url":"https://api.github.com/repos/datalad/datalad/hooks","issue_events_url":"https://api.github.com/repos/datalad/datalad/issues/events{/number}","events_url":"https://api.github.com/repos/datalad/datalad/events","assignees_url":"https://api.github.com/repos/datalad/datalad/assignees{/user}","branches_url":"https://api.github.com/repos/datalad/datalad/branches{/branch}","tags_url":"https://api.github.com/repos/datalad/datalad/tags","blobs_url":"https://api.github.com/repos/datalad/datalad/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/datalad/datalad/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/datalad/datalad/git/refs{/sha}","trees_url":"https://api.github.com/repos/datalad/datalad/git/trees{/sha}","statuses_url":"https://api.github.com/repos/datalad/datalad/statuses/{sha}","languages_url":"https://api.github.com/repos/datalad/datalad/languages","stargazers_url":"https://api.github.com/repos/datalad/datalad/stargazers","contributors_url":"https://api.github.com/repos/datalad/datalad/contributors","subscribers_url":"https://api.github.com/repos/datalad/datalad/subscribers","subscription_url":"https://api.github.com/repos/datalad/datalad/subscription","commits_url":"https://api.github.com/repos/datalad/datalad/commits{/sha}","git_commits_url":"https://api.github.com/repos/datalad/datalad/git/commits{/sha}","comments_url":"https://api.github.com/repos/datalad/datalad/comments{/number}","issue_comment_url":"https://api.github.com/repos/datalad/datalad/issues/comments{/number}","contents_url":"https://api.github.com/repos/datalad/datalad/contents/{+path}","compare_url":"https://api.github.com/repos/datalad/datalad/compare/{base}...{head}","merges_url":"https://api.github.com/repos/datalad/datalad/merges","archive_url":"https://api.github.com/repos/datalad/datalad/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/datalad/datalad/downloads","issues_url":"https://api.github.com/repos/datalad/datalad/issues{/number}","pulls_url":"https://api.github.com/repos/datalad/datalad/pulls{/number}","milestones_url":"https://api.github.com/repos/datalad/datalad/milestones{/number}","notifications_url":"https://api.github.com/repos/datalad/datalad/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/datalad/datalad/labels{/name}","releases_url":"https://api.github.com/repos/datalad/datalad/releases{/id}","deployments_url":"https://api.github.com/repos/datalad/datalad/deployments","created_at":"2013-11-01T19:40:08Z","updated_at":"2018-08-23T05:45:43Z","pushed_at":"2018-08-23T18:31:03Z","git_url":"git://github.com/datalad/datalad.git","ssh_url":"[email protected]:datalad/datalad.git","clone_url":"https://github.com/datalad/datalad.git","svn_url":"https://github.com/datalad/datalad","homepage":"http://datalad.org","size":13910,"stargazers_count":114,"watchers_count":114,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":40,"mirror_url":null,"archived":false,"open_issues_count":443,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":40,"open_issues":443,"watchers":114,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/datalad/datalad/pulls/2708"},"html":{"href":"https://github.com/datalad/datalad/pull/2708"},"issue":{"href":"https://api.github.com/repos/datalad/datalad/issues/2708"},"comments":{"href":"https://api.github.com/repos/datalad/datalad/issues/2708/comments"},"review_comments":{"href":"https://api.github.com/repos/datalad/datalad/pulls/2708/comments"},"review_comment":{"href":"https://api.github.com/repos/datalad/datalad/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/datalad/datalad/pulls/2708/commits"},"statuses":{"href":"https://api.github.com/repos/datalad/datalad/statuses/32216bee42677b3767009c66b91cd2037e28aaf8"}},"author_association":"MEMBER"}} | {
"id": 14052034,
"name": "datalad/datalad",
"url": "https://api.github.com/repos/datalad/datalad"
} | {
"id": 39889,
"login": "yarikoptic",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/39889?",
"url": "https://api.github.com/users/yarikoptic"
} | {
"id": 8927200,
"login": "datalad",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/8927200?",
"url": "https://api.github.com/orgs/datalad"
} | 2018-08-23T18:57:26 | 8158950902 | {"actor":{"display_login":"yarikoptic"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/AliceO2Group/AliceO2/pulls/comments/191227693","pull_request_review_id":123760420,"id":191227693,"diff_hunk":"@@ -48,15 +48,19 @@ find_package(HEPMC)\n # PR #886 depending on some header files conflict with the IWYU setup\n # disable package for the moment\n #find_package(IWYU)\n-find_package(DDS)\n \n find_package(Boost 1.59 COMPONENTS thread system timer program_options random filesystem chrono exception regex serialization log log_setup unit_test_framework date_time signals REQUIRED)\n # for the guideline support library\n include_directories(${MS_GSL_INCLUDE_DIR})\n \n find_package(AliRoot)\n find_package(FairRoot REQUIRED)\n-find_package(FairMQ REQUIRED)\n+find_package(FairMQInFairRoot)","path":"cmake/O2Dependencies.cmake","position":13,"original_position":13,"commit_id":"35493677c359beb40097d3caaed3aedefea99b98","original_commit_id":"35493677c359beb40097d3caaed3aedefea99b98","user":{"login":"dberzano","id":825677,"avatar_url":"https://avatars3.githubusercontent.com/u/825677?v=4","gravatar_id":"","url":"https://api.github.com/users/dberzano","html_url":"https://github.com/dberzano","followers_url":"https://api.github.com/users/dberzano/followers","following_url":"https://api.github.com/users/dberzano/following{/other_user}","gists_url":"https://api.github.com/users/dberzano/gists{/gist_id}","starred_url":"https://api.github.com/users/dberzano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dberzano/subscriptions","organizations_url":"https://api.github.com/users/dberzano/orgs","repos_url":"https://api.github.com/users/dberzano/repos","events_url":"https://api.github.com/users/dberzano/events{/privacy}","received_events_url":"https://api.github.com/users/dberzano/received_events","type":"User","site_admin":false},"body":"A comment clearly indicating the deprecation. When appropriate we'll get rid of it. It's useful to support both in this hopefully short transition period.","created_at":"2018-05-28T15:01:43Z","updated_at":"2018-05-28T15:01:43Z","html_url":"https://github.com/AliceO2Group/AliceO2/pull/1107#discussion_r191227693","pull_request_url":"https://api.github.com/repos/AliceO2Group/AliceO2/pulls/1107","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/AliceO2Group/AliceO2/pulls/comments/191227693"},"html":{"href":"https://github.com/AliceO2Group/AliceO2/pull/1107#discussion_r191227693"},"pull_request":{"href":"https://api.github.com/repos/AliceO2Group/AliceO2/pulls/1107"}},"in_reply_to_id":191188989},"pull_request":{"url":"https://api.github.com/repos/AliceO2Group/AliceO2/pulls/1107","id":190040690,"html_url":"https://github.com/AliceO2Group/AliceO2/pull/1107","diff_url":"https://github.com/AliceO2Group/AliceO2/pull/1107.diff","patch_url":"https://github.com/AliceO2Group/AliceO2/pull/1107.patch","issue_url":"https://api.github.com/repos/AliceO2Group/AliceO2/issues/1107","number":1107,"state":"open","locked":false,"title":"Support FairRoot repo split","user":{"login":"dennisklein","id":297548,"avatar_url":"https://avatars0.githubusercontent.com/u/297548?v=4","gravatar_id":"","url":"https://api.github.com/users/dennisklein","html_url":"https://github.com/dennisklein","followers_url":"https://api.github.com/users/dennisklein/followers","following_url":"https://api.github.com/users/dennisklein/following{/other_user}","gists_url":"https://api.github.com/users/dennisklein/gists{/gist_id}","starred_url":"https://api.github.com/users/dennisklein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dennisklein/subscriptions","organizations_url":"https://api.github.com/users/dennisklein/orgs","repos_url":"https://api.github.com/users/dennisklein/repos","events_url":"https://api.github.com/users/dennisklein/events{/privacy}","received_events_url":"https://api.github.com/users/dennisklein/received_events","type":"User","site_admin":false},"body":"I have not tested this on a Mac so far.","created_at":"2018-05-23T16:50:07Z","updated_at":"2018-05-28T15:01:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5a3de56e5ae76583b5f3e963be448d27063cb936","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/AliceO2Group/AliceO2/pulls/1107/commits","review_comments_url":"https://api.github.com/repos/AliceO2Group/AliceO2/pulls/1107/comments","review_comment_url":"https://api.github.com/repos/AliceO2Group/AliceO2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/AliceO2Group/AliceO2/issues/1107/comments","statuses_url":"https://api.github.com/repos/AliceO2Group/AliceO2/statuses/35493677c359beb40097d3caaed3aedefea99b98","head":{"label":"dennisklein:support_repo_split","ref":"support_repo_split","sha":"35493677c359beb40097d3caaed3aedefea99b98","user":{"login":"dennisklein","id":297548,"avatar_url":"https://avatars0.githubusercontent.com/u/297548?v=4","gravatar_id":"","url":"https://api.github.com/users/dennisklein","html_url":"https://github.com/dennisklein","followers_url":"https://api.github.com/users/dennisklein/followers","following_url":"https://api.github.com/users/dennisklein/following{/other_user}","gists_url":"https://api.github.com/users/dennisklein/gists{/gist_id}","starred_url":"https://api.github.com/users/dennisklein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dennisklein/subscriptions","organizations_url":"https://api.github.com/users/dennisklein/orgs","repos_url":"https://api.github.com/users/dennisklein/repos","events_url":"https://api.github.com/users/dennisklein/events{/privacy}","received_events_url":"https://api.github.com/users/dennisklein/received_events","type":"User","site_admin":false},"repo":{"id":87539100,"name":"AliceO2","full_name":"dennisklein/AliceO2","owner":{"login":"dennisklein","id":297548,"avatar_url":"https://avatars0.githubusercontent.com/u/297548?v=4","gravatar_id":"","url":"https://api.github.com/users/dennisklein","html_url":"https://github.com/dennisklein","followers_url":"https://api.github.com/users/dennisklein/followers","following_url":"https://api.github.com/users/dennisklein/following{/other_user}","gists_url":"https://api.github.com/users/dennisklein/gists{/gist_id}","starred_url":"https://api.github.com/users/dennisklein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dennisklein/subscriptions","organizations_url":"https://api.github.com/users/dennisklein/orgs","repos_url":"https://api.github.com/users/dennisklein/repos","events_url":"https://api.github.com/users/dennisklein/events{/privacy}","received_events_url":"https://api.github.com/users/dennisklein/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dennisklein/AliceO2","description":"O2 software project for the ALICE experiment at CERN","fork":true,"url":"https://api.github.com/repos/dennisklein/AliceO2","forks_url":"https://api.github.com/repos/dennisklein/AliceO2/forks","keys_url":"https://api.github.com/repos/dennisklein/AliceO2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dennisklein/AliceO2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dennisklein/AliceO2/teams","hooks_url":"https://api.github.com/repos/dennisklein/AliceO2/hooks","issue_events_url":"https://api.github.com/repos/dennisklein/AliceO2/issues/events{/number}","events_url":"https://api.github.com/repos/dennisklein/AliceO2/events","assignees_url":"https://api.github.com/repos/dennisklein/AliceO2/assignees{/user}","branches_url":"https://api.github.com/repos/dennisklein/AliceO2/branches{/branch}","tags_url":"https://api.github.com/repos/dennisklein/AliceO2/tags","blobs_url":"https://api.github.com/repos/dennisklein/AliceO2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dennisklein/AliceO2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dennisklein/AliceO2/git/refs{/sha}","trees_url":"https://api.github.com/repos/dennisklein/AliceO2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dennisklein/AliceO2/statuses/{sha}","languages_url":"https://api.github.com/repos/dennisklein/AliceO2/languages","stargazers_url":"https://api.github.com/repos/dennisklein/AliceO2/stargazers","contributors_url":"https://api.github.com/repos/dennisklein/AliceO2/contributors","subscribers_url":"https://api.github.com/repos/dennisklein/AliceO2/subscribers","subscription_url":"https://api.github.com/repos/dennisklein/AliceO2/subscription","commits_url":"https://api.github.com/repos/dennisklein/AliceO2/commits{/sha}","git_commits_url":"https://api.github.com/repos/dennisklein/AliceO2/git/commits{/sha}","comments_url":"https://api.github.com/repos/dennisklein/AliceO2/comments{/number}","issue_comment_url":"https://api.github.com/repos/dennisklein/AliceO2/issues/comments{/number}","contents_url":"https://api.github.com/repos/dennisklein/AliceO2/contents/{+path}","compare_url":"https://api.github.com/repos/dennisklein/AliceO2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dennisklein/AliceO2/merges","archive_url":"https://api.github.com/repos/dennisklein/AliceO2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dennisklein/AliceO2/downloads","issues_url":"https://api.github.com/repos/dennisklein/AliceO2/issues{/number}","pulls_url":"https://api.github.com/repos/dennisklein/AliceO2/pulls{/number}","milestones_url":"https://api.github.com/repos/dennisklein/AliceO2/milestones{/number}","notifications_url":"https://api.github.com/repos/dennisklein/AliceO2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dennisklein/AliceO2/labels{/name}","releases_url":"https://api.github.com/repos/dennisklein/AliceO2/releases{/id}","deployments_url":"https://api.github.com/repos/dennisklein/AliceO2/deployments","created_at":"2017-04-07T11:30:44Z","updated_at":"2017-04-07T11:30:47Z","pushed_at":"2018-05-23T17:12:42Z","git_url":"git://github.com/dennisklein/AliceO2.git","ssh_url":"[email protected]:dennisklein/AliceO2.git","clone_url":"https://github.com/dennisklein/AliceO2.git","svn_url":"https://github.com/dennisklein/AliceO2","homepage":"","size":83139,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"AliceO2Group:dev","ref":"dev","sha":"52d7de85c11eaea210c848a9906135598c6db0e4","user":{"login":"AliceO2Group","id":9053140,"avatar_url":"https://avatars0.githubusercontent.com/u/9053140?v=4","gravatar_id":"","url":"https://api.github.com/users/AliceO2Group","html_url":"https://github.com/AliceO2Group","followers_url":"https://api.github.com/users/AliceO2Group/followers","following_url":"https://api.github.com/users/AliceO2Group/following{/other_user}","gists_url":"https://api.github.com/users/AliceO2Group/gists{/gist_id}","starred_url":"https://api.github.com/users/AliceO2Group/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AliceO2Group/subscriptions","organizations_url":"https://api.github.com/users/AliceO2Group/orgs","repos_url":"https://api.github.com/users/AliceO2Group/repos","events_url":"https://api.github.com/users/AliceO2Group/events{/privacy}","received_events_url":"https://api.github.com/users/AliceO2Group/received_events","type":"Organization","site_admin":false},"repo":{"id":24898648,"name":"AliceO2","full_name":"AliceO2Group/AliceO2","owner":{"login":"AliceO2Group","id":9053140,"avatar_url":"https://avatars0.githubusercontent.com/u/9053140?v=4","gravatar_id":"","url":"https://api.github.com/users/AliceO2Group","html_url":"https://github.com/AliceO2Group","followers_url":"https://api.github.com/users/AliceO2Group/followers","following_url":"https://api.github.com/users/AliceO2Group/following{/other_user}","gists_url":"https://api.github.com/users/AliceO2Group/gists{/gist_id}","starred_url":"https://api.github.com/users/AliceO2Group/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AliceO2Group/subscriptions","organizations_url":"https://api.github.com/users/AliceO2Group/orgs","repos_url":"https://api.github.com/users/AliceO2Group/repos","events_url":"https://api.github.com/users/AliceO2Group/events{/privacy}","received_events_url":"https://api.github.com/users/AliceO2Group/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/AliceO2Group/AliceO2","description":"O2 software project for the ALICE experiment at CERN","fork":false,"url":"https://api.github.com/repos/AliceO2Group/AliceO2","forks_url":"https://api.github.com/repos/AliceO2Group/AliceO2/forks","keys_url":"https://api.github.com/repos/AliceO2Group/AliceO2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AliceO2Group/AliceO2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AliceO2Group/AliceO2/teams","hooks_url":"https://api.github.com/repos/AliceO2Group/AliceO2/hooks","issue_events_url":"https://api.github.com/repos/AliceO2Group/AliceO2/issues/events{/number}","events_url":"https://api.github.com/repos/AliceO2Group/AliceO2/events","assignees_url":"https://api.github.com/repos/AliceO2Group/AliceO2/assignees{/user}","branches_url":"https://api.github.com/repos/AliceO2Group/AliceO2/branches{/branch}","tags_url":"https://api.github.com/repos/AliceO2Group/AliceO2/tags","blobs_url":"https://api.github.com/repos/AliceO2Group/AliceO2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AliceO2Group/AliceO2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AliceO2Group/AliceO2/git/refs{/sha}","trees_url":"https://api.github.com/repos/AliceO2Group/AliceO2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AliceO2Group/AliceO2/statuses/{sha}","languages_url":"https://api.github.com/repos/AliceO2Group/AliceO2/languages","stargazers_url":"https://api.github.com/repos/AliceO2Group/AliceO2/stargazers","contributors_url":"https://api.github.com/repos/AliceO2Group/AliceO2/contributors","subscribers_url":"https://api.github.com/repos/AliceO2Group/AliceO2/subscribers","subscription_url":"https://api.github.com/repos/AliceO2Group/AliceO2/subscription","commits_url":"https://api.github.com/repos/AliceO2Group/AliceO2/commits{/sha}","git_commits_url":"https://api.github.com/repos/AliceO2Group/AliceO2/git/commits{/sha}","comments_url":"https://api.github.com/repos/AliceO2Group/AliceO2/comments{/number}","issue_comment_url":"https://api.github.com/repos/AliceO2Group/AliceO2/issues/comments{/number}","contents_url":"https://api.github.com/repos/AliceO2Group/AliceO2/contents/{+path}","compare_url":"https://api.github.com/repos/AliceO2Group/AliceO2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AliceO2Group/AliceO2/merges","archive_url":"https://api.github.com/repos/AliceO2Group/AliceO2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AliceO2Group/AliceO2/downloads","issues_url":"https://api.github.com/repos/AliceO2Group/AliceO2/issues{/number}","pulls_url":"https://api.github.com/repos/AliceO2Group/AliceO2/pulls{/number}","milestones_url":"https://api.github.com/repos/AliceO2Group/AliceO2/milestones{/number}","notifications_url":"https://api.github.com/repos/AliceO2Group/AliceO2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AliceO2Group/AliceO2/labels{/name}","releases_url":"https://api.github.com/repos/AliceO2Group/AliceO2/releases{/id}","deployments_url":"https://api.github.com/repos/AliceO2Group/AliceO2/deployments","created_at":"2014-10-07T16:00:34Z","updated_at":"2018-05-28T08:37:36Z","pushed_at":"2018-05-28T15:00:49Z","git_url":"git://github.com/AliceO2Group/AliceO2.git","ssh_url":"[email protected]:AliceO2Group/AliceO2.git","clone_url":"https://github.com/AliceO2Group/AliceO2.git","svn_url":"https://github.com/AliceO2Group/AliceO2","homepage":"","size":85078,"stargazers_count":24,"watchers_count":24,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":80,"mirror_url":null,"archived":false,"open_issues_count":47,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":80,"open_issues":47,"watchers":24,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/AliceO2Group/AliceO2/pulls/1107"},"html":{"href":"https://github.com/AliceO2Group/AliceO2/pull/1107"},"issue":{"href":"https://api.github.com/repos/AliceO2Group/AliceO2/issues/1107"},"comments":{"href":"https://api.github.com/repos/AliceO2Group/AliceO2/issues/1107/comments"},"review_comments":{"href":"https://api.github.com/repos/AliceO2Group/AliceO2/pulls/1107/comments"},"review_comment":{"href":"https://api.github.com/repos/AliceO2Group/AliceO2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/AliceO2Group/AliceO2/pulls/1107/commits"},"statuses":{"href":"https://api.github.com/repos/AliceO2Group/AliceO2/statuses/35493677c359beb40097d3caaed3aedefea99b98"}},"author_association":"CONTRIBUTOR"}} | {
"id": 24898648,
"name": "AliceO2Group/AliceO2",
"url": "https://api.github.com/repos/AliceO2Group/AliceO2"
} | {
"id": 825677,
"login": "dberzano",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/825677?",
"url": "https://api.github.com/users/dberzano"
} | {
"id": 9053140,
"login": "AliceO2Group",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9053140?",
"url": "https://api.github.com/orgs/AliceO2Group"
} | 2018-05-28T15:01:43 | 7739255085 | {"actor":{"display_login":"dberzano"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/AliceO2Group/AliceO2/pulls/comments/228872084","pull_request_review_id":169235048,"id":228872084,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyODg3MjA4NA==","diff_hunk":"@@ -0,0 +1,99 @@\n+// Copyright CERN and copyright holders of ALICE O2. This software is\n+// distributed under the terms of the GNU General Public License v3 (GPL\n+// Version 3), copied verbatim in the file \"COPYING\".\n+//\n+// See http://alice-o2.web.cern.ch/license for full licensing information.\n+//\n+// In applying this license CERN does not waive the privileges and immunities\n+// granted to it by virtue of its status as an Intergovernmental Organization\n+// or submit itself to any jurisdiction.\n+\n+#ifndef ALICEO2_DATASAMPLINGPOLICY_H\n+#define ALICEO2_DATASAMPLINGPOLICY_H\n+\n+/// \\file DataSamplingPolicy.h\n+/// \\brief A declaration of O2 Data Sampling Policy\n+///\n+/// \\author Piotr Konopka, [email protected]\n+\n+#include \"Headers/DataHeader.h\"\n+#include \"Framework/InputSpec.h\"\n+#include \"Framework/Output.h\"\n+#include \"Framework/OutputSpec.h\"\n+#include \"Framework/DataSamplingCondition.h\"\n+\n+#include <boost/property_tree/ptree.hpp>\n+\n+namespace o2\n+{\n+namespace framework\n+{\n+\n+/// A class representing certain policy of sampling data.\n+///\n+/// This class stores information about specified sampling policy - data headers and conditions of sampling.\n+/// For given InputSpec, it can provide corresponding Output to pass data further.\n+class DataSamplingPolicy\n+{\n+ private:\n+ // todo: see if dpl matchers can be used here instead of this strange construction\n+ struct inputSpecHasher {\n+ size_t operator()(const InputSpec& i) const\n+ {\n+ return (static_cast<size_t>(i.description.itg[0]) << 32 |\n+ static_cast<size_t>(i.description.itg[1])) ^\n+ static_cast<size_t>(i.origin.itg[0]);\n+ }\n+ };\n+ struct inputSpecEqual {\n+ bool operator()(const InputSpec& a, const InputSpec& b) const\n+ {\n+ // -1 means 'match all subSpec'\n+ if (a.subSpec == -1 || b.subSpec == -1) {\n+ return a.description == b.description && a.origin == b.origin;\n+ } else {\n+ return a.description == b.description && a.origin == b.origin && a.subSpec == b.subSpec;\n+ }\n+ }\n+ };\n+ using PathMap = std::unordered_map<InputSpec, OutputSpec, inputSpecHasher, inputSpecEqual>;\n+\n+ public:\n+ /// \\brief Constructor.\n+ DataSamplingPolicy();\n+ /// \\brief Constructor.\n+ DataSamplingPolicy(const boost::property_tree::ptree&);\n+ /// \\brief Destructor\n+ ~DataSamplingPolicy();\n+\n+ /// \\brief Configures a policy using structured configuration entry.\n+ void configure(const boost::property_tree::ptree&);\n+ /// \\brief Returns true if this policy requires data with given InputSpec.\n+ bool match(const InputSpec&) const;\n+ /// \\brief Returns true if user-defined conditions of sampling are fulfilled.\n+ bool decide(const o2::framework::DataRef&);\n+ /// \\brief Returns Output for given InputSpec to pass data forward.\n+ const Output prepareOutput(const InputSpec&) const;\n+\n+ const std::string& getName() const;\n+ const PathMap& getPathMap() const;\n+ const header::DataHeader::SubSpecificationType getSubSpec() const;\n+ // optional fairmq channel to send stuff outside of DPL\n+ const std::string& getFairMQOutputChannel() const;\n+ std::string getFairMQOutputChannelName() const;\n+\n+ static header::DataOrigin policyDataOrigin();","path":"Framework/Core/include/Framework/DataSamplingPolicy.h","position":85,"original_position":85,"commit_id":"c8749bafbbe42f1eada9f5db008ba689c095cfcf","original_commit_id":"c8749bafbbe42f1eada9f5db008ba689c095cfcf","user":{"login":"ktf","id":10544,"node_id":"MDQ6VXNlcjEwNTQ0","avatar_url":"https://avatars0.githubusercontent.com/u/10544?v=4","gravatar_id":"","url":"https://api.github.com/users/ktf","html_url":"https://github.com/ktf","followers_url":"https://api.github.com/users/ktf/followers","following_url":"https://api.github.com/users/ktf/following{/other_user}","gists_url":"https://api.github.com/users/ktf/gists{/gist_id}","starred_url":"https://api.github.com/users/ktf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ktf/subscriptions","organizations_url":"https://api.github.com/users/ktf/orgs","repos_url":"https://api.github.com/users/ktf/repos","events_url":"https://api.github.com/users/ktf/events{/privacy}","received_events_url":"https://api.github.com/users/ktf/received_events","type":"User","site_admin":false},"body":"make?","created_at":"2018-10-29T10:34:31Z","updated_at":"2018-10-29T10:34:31Z","html_url":"https://github.com/AliceO2Group/AliceO2/pull/1428#discussion_r228872084","pull_request_url":"https://api.github.com/repos/AliceO2Group/AliceO2/pulls/1428","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/AliceO2Group/AliceO2/pulls/comments/228872084"},"html":{"href":"https://github.com/AliceO2Group/AliceO2/pull/1428#discussion_r228872084"},"pull_request":{"href":"https://api.github.com/repos/AliceO2Group/AliceO2/pulls/1428"}},"in_reply_to_id":228431369},"pull_request":{"url":"https://api.github.com/repos/AliceO2Group/AliceO2/pulls/1428","id":224939038,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI0OTM5MDM4","html_url":"https://github.com/AliceO2Group/AliceO2/pull/1428","diff_url":"https://github.com/AliceO2Group/AliceO2/pull/1428.diff","patch_url":"https://github.com/AliceO2Group/AliceO2/pull/1428.patch","issue_url":"https://api.github.com/repos/AliceO2Group/AliceO2/issues/1428","number":1428,"state":"closed","locked":false,"title":"Reworked Data Sampling","user":{"login":"knopers8","id":14327588,"node_id":"MDQ6VXNlcjE0MzI3NTg4","avatar_url":"https://avatars2.githubusercontent.com/u/14327588?v=4","gravatar_id":"","url":"https://api.github.com/users/knopers8","html_url":"https://github.com/knopers8","followers_url":"https://api.github.com/users/knopers8/followers","following_url":"https://api.github.com/users/knopers8/following{/other_user}","gists_url":"https://api.github.com/users/knopers8/gists{/gist_id}","starred_url":"https://api.github.com/users/knopers8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knopers8/subscriptions","organizations_url":"https://api.github.com/users/knopers8/orgs","repos_url":"https://api.github.com/users/knopers8/repos","events_url":"https://api.github.com/users/knopers8/events{/privacy}","received_events_url":"https://api.github.com/users/knopers8/received_events","type":"User","site_admin":false},"body":"A bigger pull request with reworked Data Sampling. Highlights:\r\n- ability to reconfigure dispatcher during the runtime, by reinitialization\r\n- a new way of configuration that envisages using Data Sampling on the farm\r\n- making use of DataSamplingConditions, providing possibilty to customize sampling behaviour\r\n\r\nPlease do NOT merge yet - it will need to be merged together with a PR on QC repo.","created_at":"2018-10-23T08:17:18Z","updated_at":"2018-10-29T10:34:31Z","closed_at":"2018-10-26T09:09:36Z","merged_at":"2018-10-26T09:09:36Z","merge_commit_sha":"8a345d58e545e228ccc2ddfb5455eea77b25bcd9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/AliceO2Group/AliceO2/pulls/1428/commits","review_comments_url":"https://api.github.com/repos/AliceO2Group/AliceO2/pulls/1428/comments","review_comment_url":"https://api.github.com/repos/AliceO2Group/AliceO2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/AliceO2Group/AliceO2/issues/1428/comments","statuses_url":"https://api.github.com/repos/AliceO2Group/AliceO2/statuses/c8749bafbbe42f1eada9f5db008ba689c095cfcf","head":{"label":"knopers8:new-data-sampling","ref":"new-data-sampling","sha":"c8749bafbbe42f1eada9f5db008ba689c095cfcf","user":{"login":"knopers8","id":14327588,"node_id":"MDQ6VXNlcjE0MzI3NTg4","avatar_url":"https://avatars2.githubusercontent.com/u/14327588?v=4","gravatar_id":"","url":"https://api.github.com/users/knopers8","html_url":"https://github.com/knopers8","followers_url":"https://api.github.com/users/knopers8/followers","following_url":"https://api.github.com/users/knopers8/following{/other_user}","gists_url":"https://api.github.com/users/knopers8/gists{/gist_id}","starred_url":"https://api.github.com/users/knopers8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knopers8/subscriptions","organizations_url":"https://api.github.com/users/knopers8/orgs","repos_url":"https://api.github.com/users/knopers8/repos","events_url":"https://api.github.com/users/knopers8/events{/privacy}","received_events_url":"https://api.github.com/users/knopers8/received_events","type":"User","site_admin":false},"repo":{"id":111108969,"node_id":"MDEwOlJlcG9zaXRvcnkxMTExMDg5Njk=","name":"AliceO2","full_name":"knopers8/AliceO2","private":false,"owner":{"login":"knopers8","id":14327588,"node_id":"MDQ6VXNlcjE0MzI3NTg4","avatar_url":"https://avatars2.githubusercontent.com/u/14327588?v=4","gravatar_id":"","url":"https://api.github.com/users/knopers8","html_url":"https://github.com/knopers8","followers_url":"https://api.github.com/users/knopers8/followers","following_url":"https://api.github.com/users/knopers8/following{/other_user}","gists_url":"https://api.github.com/users/knopers8/gists{/gist_id}","starred_url":"https://api.github.com/users/knopers8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knopers8/subscriptions","organizations_url":"https://api.github.com/users/knopers8/orgs","repos_url":"https://api.github.com/users/knopers8/repos","events_url":"https://api.github.com/users/knopers8/events{/privacy}","received_events_url":"https://api.github.com/users/knopers8/received_events","type":"User","site_admin":false},"html_url":"https://github.com/knopers8/AliceO2","description":"O2 software project for the ALICE experiment at CERN","fork":true,"url":"https://api.github.com/repos/knopers8/AliceO2","forks_url":"https://api.github.com/repos/knopers8/AliceO2/forks","keys_url":"https://api.github.com/repos/knopers8/AliceO2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/knopers8/AliceO2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/knopers8/AliceO2/teams","hooks_url":"https://api.github.com/repos/knopers8/AliceO2/hooks","issue_events_url":"https://api.github.com/repos/knopers8/AliceO2/issues/events{/number}","events_url":"https://api.github.com/repos/knopers8/AliceO2/events","assignees_url":"https://api.github.com/repos/knopers8/AliceO2/assignees{/user}","branches_url":"https://api.github.com/repos/knopers8/AliceO2/branches{/branch}","tags_url":"https://api.github.com/repos/knopers8/AliceO2/tags","blobs_url":"https://api.github.com/repos/knopers8/AliceO2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/knopers8/AliceO2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/knopers8/AliceO2/git/refs{/sha}","trees_url":"https://api.github.com/repos/knopers8/AliceO2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/knopers8/AliceO2/statuses/{sha}","languages_url":"https://api.github.com/repos/knopers8/AliceO2/languages","stargazers_url":"https://api.github.com/repos/knopers8/AliceO2/stargazers","contributors_url":"https://api.github.com/repos/knopers8/AliceO2/contributors","subscribers_url":"https://api.github.com/repos/knopers8/AliceO2/subscribers","subscription_url":"https://api.github.com/repos/knopers8/AliceO2/subscription","commits_url":"https://api.github.com/repos/knopers8/AliceO2/commits{/sha}","git_commits_url":"https://api.github.com/repos/knopers8/AliceO2/git/commits{/sha}","comments_url":"https://api.github.com/repos/knopers8/AliceO2/comments{/number}","issue_comment_url":"https://api.github.com/repos/knopers8/AliceO2/issues/comments{/number}","contents_url":"https://api.github.com/repos/knopers8/AliceO2/contents/{+path}","compare_url":"https://api.github.com/repos/knopers8/AliceO2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/knopers8/AliceO2/merges","archive_url":"https://api.github.com/repos/knopers8/AliceO2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/knopers8/AliceO2/downloads","issues_url":"https://api.github.com/repos/knopers8/AliceO2/issues{/number}","pulls_url":"https://api.github.com/repos/knopers8/AliceO2/pulls{/number}","milestones_url":"https://api.github.com/repos/knopers8/AliceO2/milestones{/number}","notifications_url":"https://api.github.com/repos/knopers8/AliceO2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/knopers8/AliceO2/labels{/name}","releases_url":"https://api.github.com/repos/knopers8/AliceO2/releases{/id}","deployments_url":"https://api.github.com/repos/knopers8/AliceO2/deployments","created_at":"2017-11-17T13:53:31Z","updated_at":"2018-08-22T14:44:25Z","pushed_at":"2018-10-26T07:38:22Z","git_url":"git://github.com/knopers8/AliceO2.git","ssh_url":"[email protected]:knopers8/AliceO2.git","clone_url":"https://github.com/knopers8/AliceO2.git","svn_url":"https://github.com/knopers8/AliceO2","homepage":"","size":85784,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"AliceO2Group:dev","ref":"dev","sha":"18de589e1ccc721978733bc1297de6203d2746f3","user":{"login":"AliceO2Group","id":9053140,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkwNTMxNDA=","avatar_url":"https://avatars0.githubusercontent.com/u/9053140?v=4","gravatar_id":"","url":"https://api.github.com/users/AliceO2Group","html_url":"https://github.com/AliceO2Group","followers_url":"https://api.github.com/users/AliceO2Group/followers","following_url":"https://api.github.com/users/AliceO2Group/following{/other_user}","gists_url":"https://api.github.com/users/AliceO2Group/gists{/gist_id}","starred_url":"https://api.github.com/users/AliceO2Group/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AliceO2Group/subscriptions","organizations_url":"https://api.github.com/users/AliceO2Group/orgs","repos_url":"https://api.github.com/users/AliceO2Group/repos","events_url":"https://api.github.com/users/AliceO2Group/events{/privacy}","received_events_url":"https://api.github.com/users/AliceO2Group/received_events","type":"Organization","site_admin":false},"repo":{"id":24898648,"node_id":"MDEwOlJlcG9zaXRvcnkyNDg5ODY0OA==","name":"AliceO2","full_name":"AliceO2Group/AliceO2","private":false,"owner":{"login":"AliceO2Group","id":9053140,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkwNTMxNDA=","avatar_url":"https://avatars0.githubusercontent.com/u/9053140?v=4","gravatar_id":"","url":"https://api.github.com/users/AliceO2Group","html_url":"https://github.com/AliceO2Group","followers_url":"https://api.github.com/users/AliceO2Group/followers","following_url":"https://api.github.com/users/AliceO2Group/following{/other_user}","gists_url":"https://api.github.com/users/AliceO2Group/gists{/gist_id}","starred_url":"https://api.github.com/users/AliceO2Group/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AliceO2Group/subscriptions","organizations_url":"https://api.github.com/users/AliceO2Group/orgs","repos_url":"https://api.github.com/users/AliceO2Group/repos","events_url":"https://api.github.com/users/AliceO2Group/events{/privacy}","received_events_url":"https://api.github.com/users/AliceO2Group/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/AliceO2Group/AliceO2","description":"O2 software project for the ALICE experiment at CERN","fork":false,"url":"https://api.github.com/repos/AliceO2Group/AliceO2","forks_url":"https://api.github.com/repos/AliceO2Group/AliceO2/forks","keys_url":"https://api.github.com/repos/AliceO2Group/AliceO2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AliceO2Group/AliceO2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AliceO2Group/AliceO2/teams","hooks_url":"https://api.github.com/repos/AliceO2Group/AliceO2/hooks","issue_events_url":"https://api.github.com/repos/AliceO2Group/AliceO2/issues/events{/number}","events_url":"https://api.github.com/repos/AliceO2Group/AliceO2/events","assignees_url":"https://api.github.com/repos/AliceO2Group/AliceO2/assignees{/user}","branches_url":"https://api.github.com/repos/AliceO2Group/AliceO2/branches{/branch}","tags_url":"https://api.github.com/repos/AliceO2Group/AliceO2/tags","blobs_url":"https://api.github.com/repos/AliceO2Group/AliceO2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AliceO2Group/AliceO2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AliceO2Group/AliceO2/git/refs{/sha}","trees_url":"https://api.github.com/repos/AliceO2Group/AliceO2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AliceO2Group/AliceO2/statuses/{sha}","languages_url":"https://api.github.com/repos/AliceO2Group/AliceO2/languages","stargazers_url":"https://api.github.com/repos/AliceO2Group/AliceO2/stargazers","contributors_url":"https://api.github.com/repos/AliceO2Group/AliceO2/contributors","subscribers_url":"https://api.github.com/repos/AliceO2Group/AliceO2/subscribers","subscription_url":"https://api.github.com/repos/AliceO2Group/AliceO2/subscription","commits_url":"https://api.github.com/repos/AliceO2Group/AliceO2/commits{/sha}","git_commits_url":"https://api.github.com/repos/AliceO2Group/AliceO2/git/commits{/sha}","comments_url":"https://api.github.com/repos/AliceO2Group/AliceO2/comments{/number}","issue_comment_url":"https://api.github.com/repos/AliceO2Group/AliceO2/issues/comments{/number}","contents_url":"https://api.github.com/repos/AliceO2Group/AliceO2/contents/{+path}","compare_url":"https://api.github.com/repos/AliceO2Group/AliceO2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AliceO2Group/AliceO2/merges","archive_url":"https://api.github.com/repos/AliceO2Group/AliceO2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AliceO2Group/AliceO2/downloads","issues_url":"https://api.github.com/repos/AliceO2Group/AliceO2/issues{/number}","pulls_url":"https://api.github.com/repos/AliceO2Group/AliceO2/pulls{/number}","milestones_url":"https://api.github.com/repos/AliceO2Group/AliceO2/milestones{/number}","notifications_url":"https://api.github.com/repos/AliceO2Group/AliceO2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AliceO2Group/AliceO2/labels{/name}","releases_url":"https://api.github.com/repos/AliceO2Group/AliceO2/releases{/id}","deployments_url":"https://api.github.com/repos/AliceO2Group/AliceO2/deployments","created_at":"2014-10-07T16:00:34Z","updated_at":"2018-10-29T10:23:19Z","pushed_at":"2018-10-29T10:32:45Z","git_url":"git://github.com/AliceO2Group/AliceO2.git","ssh_url":"[email protected]:AliceO2Group/AliceO2.git","clone_url":"https://github.com/AliceO2Group/AliceO2.git","svn_url":"https://github.com/AliceO2Group/AliceO2","homepage":"","size":99686,"stargazers_count":26,"watchers_count":26,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":85,"mirror_url":null,"archived":false,"open_issues_count":43,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":85,"open_issues":43,"watchers":26,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/AliceO2Group/AliceO2/pulls/1428"},"html":{"href":"https://github.com/AliceO2Group/AliceO2/pull/1428"},"issue":{"href":"https://api.github.com/repos/AliceO2Group/AliceO2/issues/1428"},"comments":{"href":"https://api.github.com/repos/AliceO2Group/AliceO2/issues/1428/comments"},"review_comments":{"href":"https://api.github.com/repos/AliceO2Group/AliceO2/pulls/1428/comments"},"review_comment":{"href":"https://api.github.com/repos/AliceO2Group/AliceO2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/AliceO2Group/AliceO2/pulls/1428/commits"},"statuses":{"href":"https://api.github.com/repos/AliceO2Group/AliceO2/statuses/c8749bafbbe42f1eada9f5db008ba689c095cfcf"}},"author_association":"COLLABORATOR"}} | {
"id": 24898648,
"name": "AliceO2Group/AliceO2",
"url": "https://api.github.com/repos/AliceO2Group/AliceO2"
} | {
"id": 10544,
"login": "ktf",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/10544?",
"url": "https://api.github.com/users/ktf"
} | {
"id": 9053140,
"login": "AliceO2Group",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9053140?",
"url": "https://api.github.com/orgs/AliceO2Group"
} | 2018-10-29T10:34:31 | 8496838907 | {"actor":{"display_login":"ktf"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/machinelearning/pulls/comments/208991198","pull_request_review_id":144916943,"id":208991198,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwODk5MTE5OA==","diff_hunk":"@@ -472,5 +1117,158 @@ internal static unsafe float Dist2(Span<float> src, Span<float> dst)\n }\n }\n \n+ internal static unsafe void ZeroItemsU(AlignedArray dst, int c, int[] indices, int cindices)\n+ {\n+ fixed (float* pDstStart = &dst.Items[0])\n+ fixed (int* pidx = &indices[0])\n+ {\n+ float* pdst = Ptr(dst, pDstStart);\n+\n+ // REVIEW NEEDED: This line expands to (void)(c); but is it necessary?","path":"src/Microsoft.ML.CpuMath/SseIntrinsics.cs","position":758,"original_position":758,"commit_id":"02bfbe6c0f2f8d12ef7ef37006557d4f0616a054","original_commit_id":"02bfbe6c0f2f8d12ef7ef37006557d4f0616a054","user":{"login":"eerhardt","id":8291187,"node_id":"MDQ6VXNlcjgyOTExODc=","avatar_url":"https://avatars3.githubusercontent.com/u/8291187?v=4","gravatar_id":"","url":"https://api.github.com/users/eerhardt","html_url":"https://github.com/eerhardt","followers_url":"https://api.github.com/users/eerhardt/followers","following_url":"https://api.github.com/users/eerhardt/following{/other_user}","gists_url":"https://api.github.com/users/eerhardt/gists{/gist_id}","starred_url":"https://api.github.com/users/eerhardt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eerhardt/subscriptions","organizations_url":"https://api.github.com/users/eerhardt/orgs","repos_url":"https://api.github.com/users/eerhardt/repos","events_url":"https://api.github.com/users/eerhardt/events{/privacy}","received_events_url":"https://api.github.com/users/eerhardt/received_events","type":"User","site_admin":false},"body":"This is not necessary in C#. It is used in C++ to get the compiler to stop complaining that `c` is only used in an Assert.","created_at":"2018-08-09T16:13:10Z","updated_at":"2018-08-09T16:13:10Z","html_url":"https://github.com/dotnet/machinelearning/pull/668#discussion_r208991198","pull_request_url":"https://api.github.com/repos/dotnet/machinelearning/pulls/668","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/dotnet/machinelearning/pulls/comments/208991198"},"html":{"href":"https://github.com/dotnet/machinelearning/pull/668#discussion_r208991198"},"pull_request":{"href":"https://api.github.com/repos/dotnet/machinelearning/pulls/668"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/machinelearning/pulls/668","id":207150081,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3MTUwMDgx","html_url":"https://github.com/dotnet/machinelearning/pull/668","diff_url":"https://github.com/dotnet/machinelearning/pull/668.diff","patch_url":"https://github.com/dotnet/machinelearning/pull/668.patch","issue_url":"https://api.github.com/repos/dotnet/machinelearning/issues/668","number":668,"state":"open","locked":false,"title":"Port all active C# hardware intrinsics APIs for SSE from SIMD native algorithms","user":{"login":"briancylui","id":18178086,"node_id":"MDQ6VXNlcjE4MTc4MDg2","avatar_url":"https://avatars1.githubusercontent.com/u/18178086?v=4","gravatar_id":"","url":"https://api.github.com/users/briancylui","html_url":"https://github.com/briancylui","followers_url":"https://api.github.com/users/briancylui/followers","following_url":"https://api.github.com/users/briancylui/following{/other_user}","gists_url":"https://api.github.com/users/briancylui/gists{/gist_id}","starred_url":"https://api.github.com/users/briancylui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/briancylui/subscriptions","organizations_url":"https://api.github.com/users/briancylui/orgs","repos_url":"https://api.github.com/users/briancylui/repos","events_url":"https://api.github.com/users/briancylui/events{/privacy}","received_events_url":"https://api.github.com/users/briancylui/received_events","type":"User","site_admin":false},"body":"### What's new:\r\n1. Implemented all remaining active SSE intrinsics, including their software fallbacks and passing unit tests\r\n2. Implemented the performance tests of all remaining active SSE intrinsics, except for those that accept `AlignedArray` as an argument\r\n3. Performance test results for all applicable, active SSE intrinsics are updated in https://github.com/briancylui/machinelearning/issues/1\r\n\r\n### Description from https://github.com/dotnet/machinelearning/pull/562:\r\n- with unit tests and performance tests for two target frameworks: .NET Core App 3.0 and .NET Standard 2.0.\r\n- .NET Core App 3.0 gets the new C# hardware intrinsics APIs, while .NET Standard 2.0 gets the original native SIMD algorithms.\r\n- Several things have made this multi-targeting feature possible.\r\n 1. The new CpuMathUtils class that contains the new APIs is implemented as a partial class with method definitions split into two separate files (src\\Microsoft.ML.CpuMath\\CpuMathUtils.[target].cs), only one of which is compiled based on the target framework.\r\n 2. The Microsoft.ML.CpuMath.csproj file makes the switching decision to compile the right files based on the target framework.\r\n\r\n### Structure:\r\n1. All new hardware intrinsics APIs are contained in src\\Microsoft.ML.CpuMath.\r\n2. Unit tests for the two target frameworks live in test\\Microsoft.ML.CpuMath.UnitTests.[target], and contain the same content except for the target framework in .csproj.\r\n3. Performance tests live in test\\Microsoft.ML.CpuMath.PerformanceTests.\r\n\r\n### Changes to users:\r\n1. Originally, users call intrinsics APIs via the SseUtils class in src\\Microsoft.ML.CpuMath\\Sse.cs, but now they call them via the new CpuMathUtils class, which will handle switching between SSE and AVX in the future.\r\n2. CpuMathUtils methods and SseUtils methods share the same signature, but CpuMathUtils methods additionally call a new helper class (SseIntrinsics) for C# implementations of SSE operations.\r\n\r\n### Future follow-up for `CpuMath` enhancement\r\n1. Suggestions on `CpuMath` enhancement in this PR scheduled for future follow-ups have been compiled into an issue page (https://github.com/briancylui/machinelearning/issues/2).\r\n\r\ncc: @eerhardt @tannergooding @safern @danmosemsft ","created_at":"2018-08-08T22:00:40Z","updated_at":"2018-08-09T16:13:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bb4c6c9db5bfb474b2a9a0bab29c00c8526a1490","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/machinelearning/pulls/668/commits","review_comments_url":"https://api.github.com/repos/dotnet/machinelearning/pulls/668/comments","review_comment_url":"https://api.github.com/repos/dotnet/machinelearning/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/machinelearning/issues/668/comments","statuses_url":"https://api.github.com/repos/dotnet/machinelearning/statuses/02bfbe6c0f2f8d12ef7ef37006557d4f0616a054","head":{"label":"briancylui:Sse","ref":"Sse","sha":"02bfbe6c0f2f8d12ef7ef37006557d4f0616a054","user":{"login":"briancylui","id":18178086,"node_id":"MDQ6VXNlcjE4MTc4MDg2","avatar_url":"https://avatars1.githubusercontent.com/u/18178086?v=4","gravatar_id":"","url":"https://api.github.com/users/briancylui","html_url":"https://github.com/briancylui","followers_url":"https://api.github.com/users/briancylui/followers","following_url":"https://api.github.com/users/briancylui/following{/other_user}","gists_url":"https://api.github.com/users/briancylui/gists{/gist_id}","starred_url":"https://api.github.com/users/briancylui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/briancylui/subscriptions","organizations_url":"https://api.github.com/users/briancylui/orgs","repos_url":"https://api.github.com/users/briancylui/repos","events_url":"https://api.github.com/users/briancylui/events{/privacy}","received_events_url":"https://api.github.com/users/briancylui/received_events","type":"User","site_admin":false},"repo":{"id":137632092,"node_id":"MDEwOlJlcG9zaXRvcnkxMzc2MzIwOTI=","name":"machinelearning","full_name":"briancylui/machinelearning","owner":{"login":"briancylui","id":18178086,"node_id":"MDQ6VXNlcjE4MTc4MDg2","avatar_url":"https://avatars1.githubusercontent.com/u/18178086?v=4","gravatar_id":"","url":"https://api.github.com/users/briancylui","html_url":"https://github.com/briancylui","followers_url":"https://api.github.com/users/briancylui/followers","following_url":"https://api.github.com/users/briancylui/following{/other_user}","gists_url":"https://api.github.com/users/briancylui/gists{/gist_id}","starred_url":"https://api.github.com/users/briancylui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/briancylui/subscriptions","organizations_url":"https://api.github.com/users/briancylui/orgs","repos_url":"https://api.github.com/users/briancylui/repos","events_url":"https://api.github.com/users/briancylui/events{/privacy}","received_events_url":"https://api.github.com/users/briancylui/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/briancylui/machinelearning","description":"ML.NET is an open source and cross-platform machine learning framework for .NET.","fork":true,"url":"https://api.github.com/repos/briancylui/machinelearning","forks_url":"https://api.github.com/repos/briancylui/machinelearning/forks","keys_url":"https://api.github.com/repos/briancylui/machinelearning/keys{/key_id}","collaborators_url":"https://api.github.com/repos/briancylui/machinelearning/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/briancylui/machinelearning/teams","hooks_url":"https://api.github.com/repos/briancylui/machinelearning/hooks","issue_events_url":"https://api.github.com/repos/briancylui/machinelearning/issues/events{/number}","events_url":"https://api.github.com/repos/briancylui/machinelearning/events","assignees_url":"https://api.github.com/repos/briancylui/machinelearning/assignees{/user}","branches_url":"https://api.github.com/repos/briancylui/machinelearning/branches{/branch}","tags_url":"https://api.github.com/repos/briancylui/machinelearning/tags","blobs_url":"https://api.github.com/repos/briancylui/machinelearning/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/briancylui/machinelearning/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/briancylui/machinelearning/git/refs{/sha}","trees_url":"https://api.github.com/repos/briancylui/machinelearning/git/trees{/sha}","statuses_url":"https://api.github.com/repos/briancylui/machinelearning/statuses/{sha}","languages_url":"https://api.github.com/repos/briancylui/machinelearning/languages","stargazers_url":"https://api.github.com/repos/briancylui/machinelearning/stargazers","contributors_url":"https://api.github.com/repos/briancylui/machinelearning/contributors","subscribers_url":"https://api.github.com/repos/briancylui/machinelearning/subscribers","subscription_url":"https://api.github.com/repos/briancylui/machinelearning/subscription","commits_url":"https://api.github.com/repos/briancylui/machinelearning/commits{/sha}","git_commits_url":"https://api.github.com/repos/briancylui/machinelearning/git/commits{/sha}","comments_url":"https://api.github.com/repos/briancylui/machinelearning/comments{/number}","issue_comment_url":"https://api.github.com/repos/briancylui/machinelearning/issues/comments{/number}","contents_url":"https://api.github.com/repos/briancylui/machinelearning/contents/{+path}","compare_url":"https://api.github.com/repos/briancylui/machinelearning/compare/{base}...{head}","merges_url":"https://api.github.com/repos/briancylui/machinelearning/merges","archive_url":"https://api.github.com/repos/briancylui/machinelearning/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/briancylui/machinelearning/downloads","issues_url":"https://api.github.com/repos/briancylui/machinelearning/issues{/number}","pulls_url":"https://api.github.com/repos/briancylui/machinelearning/pulls{/number}","milestones_url":"https://api.github.com/repos/briancylui/machinelearning/milestones{/number}","notifications_url":"https://api.github.com/repos/briancylui/machinelearning/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/briancylui/machinelearning/labels{/name}","releases_url":"https://api.github.com/repos/briancylui/machinelearning/releases{/id}","deployments_url":"https://api.github.com/repos/briancylui/machinelearning/deployments","created_at":"2018-06-17T05:47:45Z","updated_at":"2018-07-20T03:27:37Z","pushed_at":"2018-08-09T00:31:33Z","git_url":"git://github.com/briancylui/machinelearning.git","ssh_url":"[email protected]:briancylui/machinelearning.git","clone_url":"https://github.com/briancylui/machinelearning.git","svn_url":"https://github.com/briancylui/machinelearning","homepage":"http://dot.net/ml","size":21149,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"d0664c1063539805c390a0f95231dcbfb87bc974","user":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":132021166,"node_id":"MDEwOlJlcG9zaXRvcnkxMzIwMjExNjY=","name":"machinelearning","full_name":"dotnet/machinelearning","owner":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/machinelearning","description":"ML.NET is an open source and cross-platform machine learning framework for .NET.","fork":false,"url":"https://api.github.com/repos/dotnet/machinelearning","forks_url":"https://api.github.com/repos/dotnet/machinelearning/forks","keys_url":"https://api.github.com/repos/dotnet/machinelearning/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/machinelearning/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/machinelearning/teams","hooks_url":"https://api.github.com/repos/dotnet/machinelearning/hooks","issue_events_url":"https://api.github.com/repos/dotnet/machinelearning/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/machinelearning/events","assignees_url":"https://api.github.com/repos/dotnet/machinelearning/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/machinelearning/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/machinelearning/tags","blobs_url":"https://api.github.com/repos/dotnet/machinelearning/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/machinelearning/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/machinelearning/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/machinelearning/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/machinelearning/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/machinelearning/languages","stargazers_url":"https://api.github.com/repos/dotnet/machinelearning/stargazers","contributors_url":"https://api.github.com/repos/dotnet/machinelearning/contributors","subscribers_url":"https://api.github.com/repos/dotnet/machinelearning/subscribers","subscription_url":"https://api.github.com/repos/dotnet/machinelearning/subscription","commits_url":"https://api.github.com/repos/dotnet/machinelearning/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/machinelearning/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/machinelearning/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/machinelearning/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/machinelearning/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/machinelearning/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/machinelearning/merges","archive_url":"https://api.github.com/repos/dotnet/machinelearning/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/machinelearning/downloads","issues_url":"https://api.github.com/repos/dotnet/machinelearning/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/machinelearning/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/machinelearning/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/machinelearning/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/machinelearning/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/machinelearning/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/machinelearning/deployments","created_at":"2018-05-03T16:20:42Z","updated_at":"2018-08-09T16:08:54Z","pushed_at":"2018-08-09T08:17:32Z","git_url":"git://github.com/dotnet/machinelearning.git","ssh_url":"[email protected]:dotnet/machinelearning.git","clone_url":"https://github.com/dotnet/machinelearning.git","svn_url":"https://github.com/dotnet/machinelearning","homepage":"https://dot.net/ml","size":21103,"stargazers_count":3350,"watchers_count":3350,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":485,"mirror_url":null,"archived":false,"open_issues_count":210,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":485,"open_issues":210,"watchers":3350,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/machinelearning/pulls/668"},"html":{"href":"https://github.com/dotnet/machinelearning/pull/668"},"issue":{"href":"https://api.github.com/repos/dotnet/machinelearning/issues/668"},"comments":{"href":"https://api.github.com/repos/dotnet/machinelearning/issues/668/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/machinelearning/pulls/668/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/machinelearning/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/machinelearning/pulls/668/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/machinelearning/statuses/02bfbe6c0f2f8d12ef7ef37006557d4f0616a054"}},"author_association":"MEMBER"}} | {
"id": 132021166,
"name": "dotnet/machinelearning",
"url": "https://api.github.com/repos/dotnet/machinelearning"
} | {
"id": 8291187,
"login": "eerhardt",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/8291187?",
"url": "https://api.github.com/users/eerhardt"
} | {
"id": 9141961,
"login": "dotnet",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9141961?",
"url": "https://api.github.com/orgs/dotnet"
} | 2018-08-09T16:13:10 | 8091230382 | {"actor":{"display_login":"eerhardt"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/comments/238855642","pull_request_review_id":181500581,"id":238855642,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzODg1NTY0Mg==","diff_hunk":"@@ -747,6 +747,655 @@\n <data name=\"Refactoring_Only\" xml:space=\"preserve\">\n <value>Refactoring Only</value>\n </data>\n+ <data name=\"regex_number_decimal_digit\" xml:space=\"preserve\">","path":"src/Workspaces/Core/Portable/WorkspacesResources.resx","position":4,"original_position":4,"commit_id":"831da41b7c4c82e88486117dffb9520363d57e49","original_commit_id":"8220d810fa2ed73e298c3e6e87268a8658741c13","user":{"login":"CyrusNajmabadi","id":4564579,"node_id":"MDQ6VXNlcjQ1NjQ1Nzk=","avatar_url":"https://avatars3.githubusercontent.com/u/4564579?v=4","gravatar_id":"","url":"https://api.github.com/users/CyrusNajmabadi","html_url":"https://github.com/CyrusNajmabadi","followers_url":"https://api.github.com/users/CyrusNajmabadi/followers","following_url":"https://api.github.com/users/CyrusNajmabadi/following{/other_user}","gists_url":"https://api.github.com/users/CyrusNajmabadi/gists{/gist_id}","starred_url":"https://api.github.com/users/CyrusNajmabadi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CyrusNajmabadi/subscriptions","organizations_url":"https://api.github.com/users/CyrusNajmabadi/orgs","repos_url":"https://api.github.com/users/CyrusNajmabadi/repos","events_url":"https://api.github.com/users/CyrusNajmabadi/events{/privacy}","received_events_url":"https://api.github.com/users/CyrusNajmabadi/received_events","type":"User","site_admin":false},"body":"Wait... i may be confused as to waht you're referring to. Are you asking why \"mark, spacing combining\" starts with a lowercase letter?","created_at":"2018-12-04T21:58:08Z","updated_at":"2018-12-04T21:58:08Z","html_url":"https://github.com/dotnet/roslyn/pull/27694#discussion_r238855642","pull_request_url":"https://api.github.com/repos/dotnet/roslyn/pulls/27694","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/comments/238855642"},"html":{"href":"https://github.com/dotnet/roslyn/pull/27694#discussion_r238855642"},"pull_request":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/27694"}},"in_reply_to_id":238824851},"pull_request":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/27694","id":193851383,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzODUxMzgz","html_url":"https://github.com/dotnet/roslyn/pull/27694","diff_url":"https://github.com/dotnet/roslyn/pull/27694.diff","patch_url":"https://github.com/dotnet/roslyn/pull/27694.patch","issue_url":"https://api.github.com/repos/dotnet/roslyn/issues/27694","number":27694,"state":"open","locked":false,"title":"Add 'completion' support inside regex strings.","user":{"login":"CyrusNajmabadi","id":4564579,"node_id":"MDQ6VXNlcjQ1NjQ1Nzk=","avatar_url":"https://avatars3.githubusercontent.com/u/4564579?v=4","gravatar_id":"","url":"https://api.github.com/users/CyrusNajmabadi","html_url":"https://github.com/CyrusNajmabadi","followers_url":"https://api.github.com/users/CyrusNajmabadi/followers","following_url":"https://api.github.com/users/CyrusNajmabadi/following{/other_user}","gists_url":"https://api.github.com/users/CyrusNajmabadi/gists{/gist_id}","starred_url":"https://api.github.com/users/CyrusNajmabadi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CyrusNajmabadi/subscriptions","organizations_url":"https://api.github.com/users/CyrusNajmabadi/orgs","repos_url":"https://api.github.com/users/CyrusNajmabadi/repos","events_url":"https://api.github.com/users/CyrusNajmabadi/events{/privacy}","received_events_url":"https://api.github.com/users/CyrusNajmabadi/received_events","type":"User","site_admin":false},"body":"Notes:\r\n1. this is a followup PR to https://github.com/dotnet/roslyn/pull/25517. This should be reviewed once that goes in.\r\n2. this change is enormous primarily due to loc-strings. Not only for the short descriptions following the item in hte list, but also for the long description text.\r\n3. The long description text comes from https://docs.microsoft.com/en-us/dotnet/standard/base-types/regular-expression-language-quick-reference\r\n\r\nExamples:\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\nStill to-do:\r\n\r\n- [x] completion lists in empty regex strings. \n- [x] tests\r\n","created_at":"2018-06-10T23:01:30Z","updated_at":"2018-12-04T21:58:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"201981c8e10205607bfe7f7fccc64e6e73fb8db1","assignee":{"login":"dpoeschl","id":235241,"node_id":"MDQ6VXNlcjIzNTI0MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/235241?v=4","gravatar_id":"","url":"https://api.github.com/users/dpoeschl","html_url":"https://github.com/dpoeschl","followers_url":"https://api.github.com/users/dpoeschl/followers","following_url":"https://api.github.com/users/dpoeschl/following{/other_user}","gists_url":"https://api.github.com/users/dpoeschl/gists{/gist_id}","starred_url":"https://api.github.com/users/dpoeschl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dpoeschl/subscriptions","organizations_url":"https://api.github.com/users/dpoeschl/orgs","repos_url":"https://api.github.com/users/dpoeschl/repos","events_url":"https://api.github.com/users/dpoeschl/events{/privacy}","received_events_url":"https://api.github.com/users/dpoeschl/received_events","type":"User","site_admin":false},"assignees":[{"login":"dpoeschl","id":235241,"node_id":"MDQ6VXNlcjIzNTI0MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/235241?v=4","gravatar_id":"","url":"https://api.github.com/users/dpoeschl","html_url":"https://github.com/dpoeschl","followers_url":"https://api.github.com/users/dpoeschl/followers","following_url":"https://api.github.com/users/dpoeschl/following{/other_user}","gists_url":"https://api.github.com/users/dpoeschl/gists{/gist_id}","starred_url":"https://api.github.com/users/dpoeschl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dpoeschl/subscriptions","organizations_url":"https://api.github.com/users/dpoeschl/orgs","repos_url":"https://api.github.com/users/dpoeschl/repos","events_url":"https://api.github.com/users/dpoeschl/events{/privacy}","received_events_url":"https://api.github.com/users/dpoeschl/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[{"name":"roslyn-compiler","id":1803172,"node_id":"MDQ6VGVhbTE4MDMxNzI=","slug":"roslyn-compiler","description":"Roslyn Compiler Team","privacy":"closed","url":"https://api.github.com/teams/1803172","members_url":"https://api.github.com/teams/1803172/members{/member}","repositories_url":"https://api.github.com/teams/1803172/repos","permission":"pull"}],"labels":[{"id":166377917,"node_id":"MDU6TGFiZWwxNjYzNzc5MTc=","url":"https://api.github.com/repos/dotnet/roslyn/labels/Area-IDE","name":"Area-IDE","color":"5319e7","default":false},{"id":288147422,"node_id":"MDU6TGFiZWwyODgxNDc0MjI=","url":"https://api.github.com/repos/dotnet/roslyn/labels/Community","name":"Community","color":"0e8a16","default":false},{"id":912763567,"node_id":"MDU6TGFiZWw5MTI3NjM1Njc=","url":"https://api.github.com/repos/dotnet/roslyn/labels/Need%20Design%20Review","name":"Need Design Review","color":"fbca04","default":false}],"milestone":{"url":"https://api.github.com/repos/dotnet/roslyn/milestones/2","html_url":"https://github.com/dotnet/roslyn/milestone/2","labels_url":"https://api.github.com/repos/dotnet/roslyn/milestones/2/labels","id":937398,"node_id":"MDk6TWlsZXN0b25lOTM3Mzk4","number":2,"title":"Backlog","description":"This represents work which is not planned for a specific release.\r\n\r\n<!---\r\n@huboard:{\"order\":0.25}\r\n-->\r\n","creator":{"login":"jaredpar","id":146967,"node_id":"MDQ6VXNlcjE0Njk2Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/146967?v=4","gravatar_id":"","url":"https://api.github.com/users/jaredpar","html_url":"https://github.com/jaredpar","followers_url":"https://api.github.com/users/jaredpar/followers","following_url":"https://api.github.com/users/jaredpar/following{/other_user}","gists_url":"https://api.github.com/users/jaredpar/gists{/gist_id}","starred_url":"https://api.github.com/users/jaredpar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaredpar/subscriptions","organizations_url":"https://api.github.com/users/jaredpar/orgs","repos_url":"https://api.github.com/users/jaredpar/repos","events_url":"https://api.github.com/users/jaredpar/events{/privacy}","received_events_url":"https://api.github.com/users/jaredpar/received_events","type":"User","site_admin":false},"open_issues":3322,"closed_issues":573,"state":"open","created_at":"2015-01-15T20:46:02Z","updated_at":"2018-12-04T18:16:57Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/dotnet/roslyn/pulls/27694/commits","review_comments_url":"https://api.github.com/repos/dotnet/roslyn/pulls/27694/comments","review_comment_url":"https://api.github.com/repos/dotnet/roslyn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/roslyn/issues/27694/comments","statuses_url":"https://api.github.com/repos/dotnet/roslyn/statuses/831da41b7c4c82e88486117dffb9520363d57e49","head":{"label":"CyrusNajmabadi:regexCompletion","ref":"regexCompletion","sha":"831da41b7c4c82e88486117dffb9520363d57e49","user":{"login":"CyrusNajmabadi","id":4564579,"node_id":"MDQ6VXNlcjQ1NjQ1Nzk=","avatar_url":"https://avatars3.githubusercontent.com/u/4564579?v=4","gravatar_id":"","url":"https://api.github.com/users/CyrusNajmabadi","html_url":"https://github.com/CyrusNajmabadi","followers_url":"https://api.github.com/users/CyrusNajmabadi/followers","following_url":"https://api.github.com/users/CyrusNajmabadi/following{/other_user}","gists_url":"https://api.github.com/users/CyrusNajmabadi/gists{/gist_id}","starred_url":"https://api.github.com/users/CyrusNajmabadi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CyrusNajmabadi/subscriptions","organizations_url":"https://api.github.com/users/CyrusNajmabadi/orgs","repos_url":"https://api.github.com/users/CyrusNajmabadi/repos","events_url":"https://api.github.com/users/CyrusNajmabadi/events{/privacy}","received_events_url":"https://api.github.com/users/CyrusNajmabadi/received_events","type":"User","site_admin":false},"repo":{"id":30565155,"node_id":"MDEwOlJlcG9zaXRvcnkzMDU2NTE1NQ==","name":"roslyn","full_name":"CyrusNajmabadi/roslyn","private":false,"owner":{"login":"CyrusNajmabadi","id":4564579,"node_id":"MDQ6VXNlcjQ1NjQ1Nzk=","avatar_url":"https://avatars3.githubusercontent.com/u/4564579?v=4","gravatar_id":"","url":"https://api.github.com/users/CyrusNajmabadi","html_url":"https://github.com/CyrusNajmabadi","followers_url":"https://api.github.com/users/CyrusNajmabadi/followers","following_url":"https://api.github.com/users/CyrusNajmabadi/following{/other_user}","gists_url":"https://api.github.com/users/CyrusNajmabadi/gists{/gist_id}","starred_url":"https://api.github.com/users/CyrusNajmabadi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CyrusNajmabadi/subscriptions","organizations_url":"https://api.github.com/users/CyrusNajmabadi/orgs","repos_url":"https://api.github.com/users/CyrusNajmabadi/repos","events_url":"https://api.github.com/users/CyrusNajmabadi/events{/privacy}","received_events_url":"https://api.github.com/users/CyrusNajmabadi/received_events","type":"User","site_admin":false},"html_url":"https://github.com/CyrusNajmabadi/roslyn","description":"The .NET Compiler Platform (\"Roslyn\") provides open-source C# and Visual Basic compilers with rich code analysis APIs.","fork":true,"url":"https://api.github.com/repos/CyrusNajmabadi/roslyn","forks_url":"https://api.github.com/repos/CyrusNajmabadi/roslyn/forks","keys_url":"https://api.github.com/repos/CyrusNajmabadi/roslyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CyrusNajmabadi/roslyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CyrusNajmabadi/roslyn/teams","hooks_url":"https://api.github.com/repos/CyrusNajmabadi/roslyn/hooks","issue_events_url":"https://api.github.com/repos/CyrusNajmabadi/roslyn/issues/events{/number}","events_url":"https://api.github.com/repos/CyrusNajmabadi/roslyn/events","assignees_url":"https://api.github.com/repos/CyrusNajmabadi/roslyn/assignees{/user}","branches_url":"https://api.github.com/repos/CyrusNajmabadi/roslyn/branches{/branch}","tags_url":"https://api.github.com/repos/CyrusNajmabadi/roslyn/tags","blobs_url":"https://api.github.com/repos/CyrusNajmabadi/roslyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CyrusNajmabadi/roslyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CyrusNajmabadi/roslyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/CyrusNajmabadi/roslyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CyrusNajmabadi/roslyn/statuses/{sha}","languages_url":"https://api.github.com/repos/CyrusNajmabadi/roslyn/languages","stargazers_url":"https://api.github.com/repos/CyrusNajmabadi/roslyn/stargazers","contributors_url":"https://api.github.com/repos/CyrusNajmabadi/roslyn/contributors","subscribers_url":"https://api.github.com/repos/CyrusNajmabadi/roslyn/subscribers","subscription_url":"https://api.github.com/repos/CyrusNajmabadi/roslyn/subscription","commits_url":"https://api.github.com/repos/CyrusNajmabadi/roslyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/CyrusNajmabadi/roslyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/CyrusNajmabadi/roslyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/CyrusNajmabadi/roslyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/CyrusNajmabadi/roslyn/contents/{+path}","compare_url":"https://api.github.com/repos/CyrusNajmabadi/roslyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CyrusNajmabadi/roslyn/merges","archive_url":"https://api.github.com/repos/CyrusNajmabadi/roslyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CyrusNajmabadi/roslyn/downloads","issues_url":"https://api.github.com/repos/CyrusNajmabadi/roslyn/issues{/number}","pulls_url":"https://api.github.com/repos/CyrusNajmabadi/roslyn/pulls{/number}","milestones_url":"https://api.github.com/repos/CyrusNajmabadi/roslyn/milestones{/number}","notifications_url":"https://api.github.com/repos/CyrusNajmabadi/roslyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CyrusNajmabadi/roslyn/labels{/name}","releases_url":"https://api.github.com/repos/CyrusNajmabadi/roslyn/releases{/id}","deployments_url":"https://api.github.com/repos/CyrusNajmabadi/roslyn/deployments","created_at":"2015-02-09T23:45:22Z","updated_at":"2018-12-04T21:39:25Z","pushed_at":"2018-12-04T21:49:58Z","git_url":"git://github.com/CyrusNajmabadi/roslyn.git","ssh_url":"[email protected]:CyrusNajmabadi/roslyn.git","clone_url":"https://github.com/CyrusNajmabadi/roslyn.git","svn_url":"https://github.com/CyrusNajmabadi/roslyn","homepage":"","size":466643,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"9dcc089c4cdfb646292059f6a832a3a18d87e4ed","user":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":29078997,"node_id":"MDEwOlJlcG9zaXRvcnkyOTA3ODk5Nw==","name":"roslyn","full_name":"dotnet/roslyn","private":false,"owner":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dotnet/roslyn","description":"The Roslyn .NET compiler provides C# and Visual Basic languages with rich code analysis APIs.","fork":false,"url":"https://api.github.com/repos/dotnet/roslyn","forks_url":"https://api.github.com/repos/dotnet/roslyn/forks","keys_url":"https://api.github.com/repos/dotnet/roslyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/roslyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/roslyn/teams","hooks_url":"https://api.github.com/repos/dotnet/roslyn/hooks","issue_events_url":"https://api.github.com/repos/dotnet/roslyn/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/roslyn/events","assignees_url":"https://api.github.com/repos/dotnet/roslyn/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/roslyn/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/roslyn/tags","blobs_url":"https://api.github.com/repos/dotnet/roslyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/roslyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/roslyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/roslyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/roslyn/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/roslyn/languages","stargazers_url":"https://api.github.com/repos/dotnet/roslyn/stargazers","contributors_url":"https://api.github.com/repos/dotnet/roslyn/contributors","subscribers_url":"https://api.github.com/repos/dotnet/roslyn/subscribers","subscription_url":"https://api.github.com/repos/dotnet/roslyn/subscription","commits_url":"https://api.github.com/repos/dotnet/roslyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/roslyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/roslyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/roslyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/roslyn/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/roslyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/roslyn/merges","archive_url":"https://api.github.com/repos/dotnet/roslyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/roslyn/downloads","issues_url":"https://api.github.com/repos/dotnet/roslyn/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/roslyn/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/roslyn/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/roslyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/roslyn/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/roslyn/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/roslyn/deployments","created_at":"2015-01-11T02:39:03Z","updated_at":"2018-12-04T21:27:16Z","pushed_at":"2018-12-04T21:51:30Z","git_url":"git://github.com/dotnet/roslyn.git","ssh_url":"[email protected]:dotnet/roslyn.git","clone_url":"https://github.com/dotnet/roslyn.git","svn_url":"https://github.com/dotnet/roslyn","homepage":"https://docs.microsoft.com/dotnet/csharp/roslyn-sdk/","size":494562,"stargazers_count":10430,"watchers_count":10430,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2479,"mirror_url":null,"archived":false,"open_issues_count":5451,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2479,"open_issues":5451,"watchers":10430,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/27694"},"html":{"href":"https://github.com/dotnet/roslyn/pull/27694"},"issue":{"href":"https://api.github.com/repos/dotnet/roslyn/issues/27694"},"comments":{"href":"https://api.github.com/repos/dotnet/roslyn/issues/27694/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/27694/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/27694/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/roslyn/statuses/831da41b7c4c82e88486117dffb9520363d57e49"}},"author_association":"CONTRIBUTOR"}} | {
"id": 29078997,
"name": "dotnet/roslyn",
"url": "https://api.github.com/repos/dotnet/roslyn"
} | {
"id": 4564579,
"login": "CyrusNajmabadi",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4564579?",
"url": "https://api.github.com/users/CyrusNajmabadi"
} | {
"id": 9141961,
"login": "dotnet",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9141961?",
"url": "https://api.github.com/orgs/dotnet"
} | 2018-12-04T21:58:08 | 8698011019 | {"actor":{"display_login":"CyrusNajmabadi"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/comments/181848097","pull_request_review_id":112544065,"id":181848097,"diff_hunk":"@@ -0,0 +1,57 @@\n+namespace Microsoft.CodeAnalysis.CSharp.UseNameOf\n+{\n+ using System.Collections.Immutable;\n+ using System.Composition;\n+ using System.Threading.Tasks;\n+ using Microsoft.CodeAnalysis.CodeActions;\n+ using Microsoft.CodeAnalysis.CodeFixes;\n+ using Microsoft.CodeAnalysis.CSharp.Syntax;\n+ using Microsoft.CodeAnalysis.Diagnostics;\n+ using Microsoft.CodeAnalysis.Editing;\n+ using Microsoft.CodeAnalysis.Simplification;\n+\n+ [Shared]\n+ [ExportCodeFixProvider(LanguageNames.CSharp, Name = nameof(CSharpUseNameofCodeFixProvider))]\n+ internal class CSharpUseNameofCodeFixProvider : CodeFixProvider\n+ {\n+ public override ImmutableArray<string> FixableDiagnosticIds { get; } = ImmutableArray.Create(\n+ IDEDiagnosticIds.UseNameofDiagnosticId);\n+\n+ public override FixAllProvider GetFixAllProvider() => WellKnownFixAllProviders.BatchFixer;\n+\n+ public override Task RegisterCodeFixesAsync(CodeFixContext context)\n+ {\n+ foreach (var diagnostic in context.Diagnostics)\n+ {\n+ context.RegisterCodeFix(\n+ new CodeAction.DocumentChangeAction(\n+ \"Use nameof.\",\n+ _ => CreateChangedDocument(diagnostic),\n+ \"Use nameof.\"),\n+ diagnostic);\n+ }\n+\n+ return Task.CompletedTask;\n+\n+ async Task<Document> CreateChangedDocument(Diagnostic diagnostic)","path":"src/Features/CSharp/Portable/UseNameOf/CSharpUseNameofCodeFixProvider.cs","position":36,"original_position":36,"commit_id":"07f9dbe57c9c5c4cff94d8cfd3a026f6889080f1","original_commit_id":"07f9dbe57c9c5c4cff94d8cfd3a026f6889080f1","user":{"login":"CyrusNajmabadi","id":4564579,"avatar_url":"https://avatars3.githubusercontent.com/u/4564579?v=4","gravatar_id":"","url":"https://api.github.com/users/CyrusNajmabadi","html_url":"https://github.com/CyrusNajmabadi","followers_url":"https://api.github.com/users/CyrusNajmabadi/followers","following_url":"https://api.github.com/users/CyrusNajmabadi/following{/other_user}","gists_url":"https://api.github.com/users/CyrusNajmabadi/gists{/gist_id}","starred_url":"https://api.github.com/users/CyrusNajmabadi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CyrusNajmabadi/subscriptions","organizations_url":"https://api.github.com/users/CyrusNajmabadi/orgs","repos_url":"https://api.github.com/users/CyrusNajmabadi/repos","events_url":"https://api.github.com/users/CyrusNajmabadi/events{/privacy}","received_events_url":"https://api.github.com/users/CyrusNajmabadi/received_events","type":"User","site_admin":false},"body":"async method names shoudl end with Async.","created_at":"2018-04-16T18:52:47Z","updated_at":"2018-04-16T18:52:47Z","html_url":"https://github.com/dotnet/roslyn/pull/26172#discussion_r181848097","pull_request_url":"https://api.github.com/repos/dotnet/roslyn/pulls/26172","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/comments/181848097"},"html":{"href":"https://github.com/dotnet/roslyn/pull/26172#discussion_r181848097"},"pull_request":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/26172"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/26172","id":181868818,"html_url":"https://github.com/dotnet/roslyn/pull/26172","diff_url":"https://github.com/dotnet/roslyn/pull/26172.diff","patch_url":"https://github.com/dotnet/roslyn/pull/26172.patch","issue_url":"https://api.github.com/repos/dotnet/roslyn/issues/26172","number":26172,"state":"open","locked":false,"title":"Use nameof analyzer & codefix for #26162","user":{"login":"JohanLarsson","id":1640096,"avatar_url":"https://avatars0.githubusercontent.com/u/1640096?v=4","gravatar_id":"","url":"https://api.github.com/users/JohanLarsson","html_url":"https://github.com/JohanLarsson","followers_url":"https://api.github.com/users/JohanLarsson/followers","following_url":"https://api.github.com/users/JohanLarsson/following{/other_user}","gists_url":"https://api.github.com/users/JohanLarsson/gists{/gist_id}","starred_url":"https://api.github.com/users/JohanLarsson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JohanLarsson/subscriptions","organizations_url":"https://api.github.com/users/JohanLarsson/orgs","repos_url":"https://api.github.com/users/JohanLarsson/repos","events_url":"https://api.github.com/users/JohanLarsson/events{/privacy}","received_events_url":"https://api.github.com/users/JohanLarsson/received_events","type":"User","site_admin":false},"body":"Implemented it for arguments only, thinking it will be annoying for declarations and assignments.\r\nSuggest use `nameof` for members of the containing type and parameters and locals in scope.\r\nOnly implemented for CSharp.","created_at":"2018-04-16T13:55:00Z","updated_at":"2018-04-16T18:52:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8be432a565c935c30e3673111c4a15d36949c27f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[{"name":"roslyn-ide","id":1781706,"slug":"roslyn-ide","description":"Roslyn IDE Team","privacy":"closed","url":"https://api.github.com/teams/1781706","members_url":"https://api.github.com/teams/1781706/members{/member}","repositories_url":"https://api.github.com/teams/1781706/repos","permission":"pull"}],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/roslyn/pulls/26172/commits","review_comments_url":"https://api.github.com/repos/dotnet/roslyn/pulls/26172/comments","review_comment_url":"https://api.github.com/repos/dotnet/roslyn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/roslyn/issues/26172/comments","statuses_url":"https://api.github.com/repos/dotnet/roslyn/statuses/07f9dbe57c9c5c4cff94d8cfd3a026f6889080f1","head":{"label":"JohanLarsson:UseNameof","ref":"UseNameof","sha":"07f9dbe57c9c5c4cff94d8cfd3a026f6889080f1","user":{"login":"JohanLarsson","id":1640096,"avatar_url":"https://avatars0.githubusercontent.com/u/1640096?v=4","gravatar_id":"","url":"https://api.github.com/users/JohanLarsson","html_url":"https://github.com/JohanLarsson","followers_url":"https://api.github.com/users/JohanLarsson/followers","following_url":"https://api.github.com/users/JohanLarsson/following{/other_user}","gists_url":"https://api.github.com/users/JohanLarsson/gists{/gist_id}","starred_url":"https://api.github.com/users/JohanLarsson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JohanLarsson/subscriptions","organizations_url":"https://api.github.com/users/JohanLarsson/orgs","repos_url":"https://api.github.com/users/JohanLarsson/repos","events_url":"https://api.github.com/users/JohanLarsson/events{/privacy}","received_events_url":"https://api.github.com/users/JohanLarsson/received_events","type":"User","site_admin":false},"repo":{"id":124847536,"name":"roslyn","full_name":"JohanLarsson/roslyn","owner":{"login":"JohanLarsson","id":1640096,"avatar_url":"https://avatars0.githubusercontent.com/u/1640096?v=4","gravatar_id":"","url":"https://api.github.com/users/JohanLarsson","html_url":"https://github.com/JohanLarsson","followers_url":"https://api.github.com/users/JohanLarsson/followers","following_url":"https://api.github.com/users/JohanLarsson/following{/other_user}","gists_url":"https://api.github.com/users/JohanLarsson/gists{/gist_id}","starred_url":"https://api.github.com/users/JohanLarsson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JohanLarsson/subscriptions","organizations_url":"https://api.github.com/users/JohanLarsson/orgs","repos_url":"https://api.github.com/users/JohanLarsson/repos","events_url":"https://api.github.com/users/JohanLarsson/events{/privacy}","received_events_url":"https://api.github.com/users/JohanLarsson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/JohanLarsson/roslyn","description":"The .NET Compiler Platform (\"Roslyn\") provides open-source C# and Visual Basic compilers with rich code analysis APIs.","fork":true,"url":"https://api.github.com/repos/JohanLarsson/roslyn","forks_url":"https://api.github.com/repos/JohanLarsson/roslyn/forks","keys_url":"https://api.github.com/repos/JohanLarsson/roslyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JohanLarsson/roslyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JohanLarsson/roslyn/teams","hooks_url":"https://api.github.com/repos/JohanLarsson/roslyn/hooks","issue_events_url":"https://api.github.com/repos/JohanLarsson/roslyn/issues/events{/number}","events_url":"https://api.github.com/repos/JohanLarsson/roslyn/events","assignees_url":"https://api.github.com/repos/JohanLarsson/roslyn/assignees{/user}","branches_url":"https://api.github.com/repos/JohanLarsson/roslyn/branches{/branch}","tags_url":"https://api.github.com/repos/JohanLarsson/roslyn/tags","blobs_url":"https://api.github.com/repos/JohanLarsson/roslyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JohanLarsson/roslyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JohanLarsson/roslyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/JohanLarsson/roslyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JohanLarsson/roslyn/statuses/{sha}","languages_url":"https://api.github.com/repos/JohanLarsson/roslyn/languages","stargazers_url":"https://api.github.com/repos/JohanLarsson/roslyn/stargazers","contributors_url":"https://api.github.com/repos/JohanLarsson/roslyn/contributors","subscribers_url":"https://api.github.com/repos/JohanLarsson/roslyn/subscribers","subscription_url":"https://api.github.com/repos/JohanLarsson/roslyn/subscription","commits_url":"https://api.github.com/repos/JohanLarsson/roslyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/JohanLarsson/roslyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/JohanLarsson/roslyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/JohanLarsson/roslyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/JohanLarsson/roslyn/contents/{+path}","compare_url":"https://api.github.com/repos/JohanLarsson/roslyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JohanLarsson/roslyn/merges","archive_url":"https://api.github.com/repos/JohanLarsson/roslyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JohanLarsson/roslyn/downloads","issues_url":"https://api.github.com/repos/JohanLarsson/roslyn/issues{/number}","pulls_url":"https://api.github.com/repos/JohanLarsson/roslyn/pulls{/number}","milestones_url":"https://api.github.com/repos/JohanLarsson/roslyn/milestones{/number}","notifications_url":"https://api.github.com/repos/JohanLarsson/roslyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JohanLarsson/roslyn/labels{/name}","releases_url":"https://api.github.com/repos/JohanLarsson/roslyn/releases{/id}","deployments_url":"https://api.github.com/repos/JohanLarsson/roslyn/deployments","created_at":"2018-03-12T07:04:48Z","updated_at":"2018-03-12T07:05:31Z","pushed_at":"2018-04-16T13:51:47Z","git_url":"git://github.com/JohanLarsson/roslyn.git","ssh_url":"[email protected]:JohanLarsson/roslyn.git","clone_url":"https://github.com/JohanLarsson/roslyn.git","svn_url":"https://github.com/JohanLarsson/roslyn","homepage":"","size":330429,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"5e1c3344ed329d37c49570e04f59e688934d4021","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":29078997,"name":"roslyn","full_name":"dotnet/roslyn","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/roslyn","description":"The .NET Compiler Platform (\"Roslyn\") provides open-source C# and Visual Basic compilers with rich code analysis APIs.","fork":false,"url":"https://api.github.com/repos/dotnet/roslyn","forks_url":"https://api.github.com/repos/dotnet/roslyn/forks","keys_url":"https://api.github.com/repos/dotnet/roslyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/roslyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/roslyn/teams","hooks_url":"https://api.github.com/repos/dotnet/roslyn/hooks","issue_events_url":"https://api.github.com/repos/dotnet/roslyn/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/roslyn/events","assignees_url":"https://api.github.com/repos/dotnet/roslyn/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/roslyn/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/roslyn/tags","blobs_url":"https://api.github.com/repos/dotnet/roslyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/roslyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/roslyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/roslyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/roslyn/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/roslyn/languages","stargazers_url":"https://api.github.com/repos/dotnet/roslyn/stargazers","contributors_url":"https://api.github.com/repos/dotnet/roslyn/contributors","subscribers_url":"https://api.github.com/repos/dotnet/roslyn/subscribers","subscription_url":"https://api.github.com/repos/dotnet/roslyn/subscription","commits_url":"https://api.github.com/repos/dotnet/roslyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/roslyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/roslyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/roslyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/roslyn/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/roslyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/roslyn/merges","archive_url":"https://api.github.com/repos/dotnet/roslyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/roslyn/downloads","issues_url":"https://api.github.com/repos/dotnet/roslyn/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/roslyn/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/roslyn/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/roslyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/roslyn/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/roslyn/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/roslyn/deployments","created_at":"2015-01-11T02:39:03Z","updated_at":"2018-04-16T18:05:51Z","pushed_at":"2018-04-16T18:38:28Z","git_url":"git://github.com/dotnet/roslyn.git","ssh_url":"[email protected]:dotnet/roslyn.git","clone_url":"https://github.com/dotnet/roslyn.git","svn_url":"https://github.com/dotnet/roslyn","homepage":"","size":345048,"stargazers_count":9166,"watchers_count":9166,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2197,"mirror_url":null,"archived":false,"open_issues_count":4657,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":2197,"open_issues":4657,"watchers":9166,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/26172"},"html":{"href":"https://github.com/dotnet/roslyn/pull/26172"},"issue":{"href":"https://api.github.com/repos/dotnet/roslyn/issues/26172"},"comments":{"href":"https://api.github.com/repos/dotnet/roslyn/issues/26172/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/26172/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/26172/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/roslyn/statuses/07f9dbe57c9c5c4cff94d8cfd3a026f6889080f1"}},"author_association":"NONE"}} | {
"id": 29078997,
"name": "dotnet/roslyn",
"url": "https://api.github.com/repos/dotnet/roslyn"
} | {
"id": 4564579,
"login": "CyrusNajmabadi",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4564579?",
"url": "https://api.github.com/users/CyrusNajmabadi"
} | {
"id": 9141961,
"login": "dotnet",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9141961?",
"url": "https://api.github.com/orgs/dotnet"
} | 2018-04-16T18:52:47 | 7538005310 | {"actor":{"display_login":"CyrusNajmabadi"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/comments/232878146","pull_request_review_id":174172356,"id":232878146,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMjg3ODE0Ng==","diff_hunk":"@@ -0,0 +1,477 @@\n+// Copyright (c) Microsoft. All Rights Reserved. Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.\n+\n+using System;\n+using System.Collections.Generic;\n+using System.Collections.Immutable;\n+using System.Globalization;\n+using System.Linq;\n+using System.Threading;\n+using System.Threading.Tasks;\n+using Microsoft.CodeAnalysis;\n+using Microsoft.CodeAnalysis.Completion;\n+using Microsoft.CodeAnalysis.Editor.Shared.Utilities;\n+using Microsoft.CodeAnalysis.Shared.Extensions;\n+using Microsoft.CodeAnalysis.Text;\n+using Microsoft.CodeAnalysis.Text.Shared.Extensions;\n+using Microsoft.VisualStudio.Language.Intellisense.AsyncCompletion;\n+using Microsoft.VisualStudio.Text;\n+using Roslyn.Utilities;\n+using AsyncCompletionData = Microsoft.VisualStudio.Language.Intellisense.AsyncCompletion.Data;\n+using FilterResult = Microsoft.CodeAnalysis.Editor.Implementation.IntelliSense.Completion.Controller.Session.FilterResult;\n+using RoslynCompletionItem = Microsoft.CodeAnalysis.Completion.CompletionItem;\n+using Session = Microsoft.CodeAnalysis.Editor.Implementation.IntelliSense.Completion.Controller.Session;\n+using VSCompletionItem = Microsoft.VisualStudio.Language.Intellisense.AsyncCompletion.Data.CompletionItem;\n+\n+namespace Microsoft.CodeAnalysis.Editor.Implementation.IntelliSense.Completion.AsyncCompletion\n+{\n+ internal class ItemManager : ForegroundThreadAffinitizedObject, IAsyncCompletionItemManager\n+ {\n+ private readonly CompletionHelper _completionHelper;\n+\n+ private const int MaxMRUSize = 10;\n+ private ImmutableArray<string> _recentItems = ImmutableArray<string>.Empty;\n+\n+ internal ItemManager(IThreadingContext threadingContext) : base(threadingContext)\n+ {\n+ _completionHelper = new CompletionHelper(isCaseSensitive: true);\n+ }\n+\n+ public Task<ImmutableArray<VSCompletionItem>> SortCompletionListAsync(\n+ IAsyncCompletionSession session,\n+ AsyncCompletionData.AsyncCompletionSessionInitialDataSnapshot data,\n+ CancellationToken cancellationToken)\n+ {\n+ AssertIsBackground();\n+\n+ SubscribeEvents(session);\n+ return Task.FromResult(data.InitialList.OrderBy(i => i.SortText).ToImmutableArray());\n+ }\n+\n+ public Task<AsyncCompletionData.FilteredCompletionModel> UpdateCompletionListAsync(\n+ IAsyncCompletionSession session,\n+ AsyncCompletionData.AsyncCompletionSessionDataSnapshot data,\n+ CancellationToken cancellationToken)\n+ => Task.FromResult(UpdateCompletionList(session, data, cancellationToken));\n+\n+ private AsyncCompletionData.FilteredCompletionModel UpdateCompletionList(\n+ IAsyncCompletionSession session,\n+ AsyncCompletionData.AsyncCompletionSessionDataSnapshot data,\n+ CancellationToken cancellationToken)\n+ {\n+ AssertIsBackground();\n+\n+ SubscribeEvents(session);\n+ if (!session.Properties.TryGetProperty(CompletionSource.HasSuggestionItemOptions, out bool hasSuggestedItemOptions))\n+ {\n+ // This is the scenario when the session is created out of Roslyn, in some other provider, e.g. in Debugger.\n+ // For now, the default hasSuggestedItemOptions is false. We can discuss if the opposite is required.\n+ hasSuggestedItemOptions = false;\n+ }\n+\n+ var filterText = session.ApplicableToSpan.GetText(data.Snapshot);\n+ var reason = data.Trigger.Reason;\n+\n+ // We do not care about the character in the case. We care about the reason only.\n+ var roslynTrigger = Helpers.GetRoslynTrigger(data.Trigger, data.Trigger.Character);\n+\n+ if (!session.Properties.TryGetProperty(CompletionSource.InitialTriggerKind, out CompletionTriggerKind initialRoslynTriggerKind))\n+ {\n+ initialRoslynTriggerKind = CompletionTriggerKind.Invoke;\n+ }\n+\n+ // Check if the user is typing a number. If so, only proceed if it's a number\n+ // directly after a <dot>. That's because it is actually reasonable for completion\n+ // to be brought up after a <dot> and for the user to want to filter completion\n+ // items based on a number that exists in the name of the item. However, when\n+ // we are not after a dot (i.e. we're being brought up after <space> is typed)\n+ // then we don't want to filter things. Consider the user writing:\n+ //\n+ // dim i =<space>\n+ //\n+ // We'll bring up the completion list here (as VB has completion on <space>).\n+ // If the user then types '3', we don't want to match against Int32.\n+ if (filterText.Length > 0 && char.IsNumber(filterText[0]))\n+ {\n+ if (!IsAfterDot(data.Snapshot, session.ApplicableToSpan))\n+ {\n+ session.Dismiss();\n+ return null;\n+ }\n+ }\n+\n+ // We need to filter if a non-empty strict subset of filters are selected\n+ var selectedFilters = data.SelectedFilters.Where(f => f.IsSelected).Select(f => f.Filter).ToImmutableArray();\n+ var needToFilter = selectedFilters.Length > 0 && selectedFilters.Length < data.SelectedFilters.Length;\n+ var filterReason = Helpers.GetFilterReason(roslynTrigger);\n+\n+ var initialListOfItemsToBeIncluded = new List<ExtendedFilterResult>();\n+ foreach (var item in data.InitialSortedList)\n+ {\n+ cancellationToken.ThrowIfCancellationRequested();\n+\n+ if (needToFilter && ShouldBeFilteredOutOfCompletionList(item, selectedFilters))\n+ {\n+ continue;\n+ }\n+\n+ if (!item.Properties.TryGetProperty(CompletionSource.RoslynItem, out RoslynCompletionItem roslynItem))\n+ {\n+ roslynItem = RoslynCompletionItem.Create(\n+ displayText: item.DisplayText, \n+ filterText: item.FilterText, \n+ sortText: item.SortText,\n+ displayTextSuffix: item.Suffix);\n+ }\n+\n+ if (Session.MatchesFilterText(_completionHelper, roslynItem, filterText, initialRoslynTriggerKind, filterReason, _recentItems))\n+ {\n+ initialListOfItemsToBeIncluded.Add(new ExtendedFilterResult(item, new FilterResult(roslynItem, filterText, matchedFilterText: true)));\n+ }\n+ else\n+ {\n+ // The item didn't match the filter text. We'll still keep it in the list\n+ // if one of two things is true:\n+ //\n+ // 1. The user has only typed a single character. In this case they might\n+ // have just typed the character to get completion. Filtering out items\n+ // here is not desirable.\n+ //\n+ // 2. They brough up completion with ctrl-j or through deletion. In these\n+ // cases we just always keep all the items in the list.\n+ if (roslynTrigger.Kind == CompletionTriggerKind.Deletion ||\n+ roslynTrigger.Kind == CompletionTriggerKind.Invoke ||\n+ filterText.Length <= 1)\n+ {\n+ initialListOfItemsToBeIncluded.Add(new ExtendedFilterResult(item, new FilterResult(roslynItem, filterText, matchedFilterText: false)));\n+ }\n+ }\n+ }\n+\n+ // If the session was created/maintained out of Roslyn, e.g. in debugger; no properties are set and we should use data.Snapshot.\n+ // However, we prefer using the original snapshot in some projection scenarios.\n+ var snapshotForDocument = data.InitialSortedList\n+ .FirstOrDefault(i => i.Properties.ContainsProperty(CompletionSource.TriggerSnapshot))?\n+ .Properties.GetProperty<ITextSnapshot>(CompletionSource.TriggerSnapshot)\n+ ?? data.Snapshot;\n+\n+ var document = snapshotForDocument.GetOpenDocumentInCurrentContextWithChanges();\n+ var completionService = document?.GetLanguageService<CompletionService>();\n+ var completionRules = completionService?.GetRules() ?? CompletionRules.Default;\n+\n+ if (data.Trigger.Reason == AsyncCompletionData.CompletionTriggerReason.Backspace &&\n+ completionRules.DismissIfLastCharacterDeleted &&\n+ session.ApplicableToSpan.GetText(data.Snapshot).Length == 0)\n+ {\n+ // Dismiss the session\n+ return null;\n+ }\n+\n+ if (initialListOfItemsToBeIncluded.Count == 0)\n+ {\n+ return HandleAllItemsFilteredOut(reason, data.SelectedFilters, selectedFilters.Any(), completionRules);\n+ }\n+\n+ var options = document?.Project?.Solution?.Options;\n+ var highlightMatchingPortions = options?.GetOption(CompletionOptions.HighlightMatchingPortionsOfCompletionListItems, document.Project.Language) ?? true;\n+ var showCompletionItemFilters = options?.GetOption(CompletionOptions.ShowCompletionItemFilters, document.Project.Language) ?? true;\n+\n+ var updatedFilters = showCompletionItemFilters\n+ ? GetUpdatedFilters(initialListOfItemsToBeIncluded, data.SelectedFilters)\n+ : ImmutableArray<AsyncCompletionData.CompletionFilterWithState>.Empty;\n+\n+ var highlightedList = GetHighlightedList(initialListOfItemsToBeIncluded, filterText, highlightMatchingPortions).ToImmutableArray();\n+\n+ // If this was deletion, then we control the entire behavior of deletion ourselves.\n+ if (initialRoslynTriggerKind == CompletionTriggerKind.Deletion)\n+ {\n+ return HandleDeletionTrigger(initialListOfItemsToBeIncluded, filterText, updatedFilters, highlightedList);\n+ }\n+\n+ Func<ImmutableArray<RoslynCompletionItem>, string, ImmutableArray<RoslynCompletionItem>> filterMethod;\n+ if (completionService == null)\n+ {\n+ filterMethod = (items, text) => CompletionService.FilterItems(_completionHelper, items, text);\n+ }\n+ else\n+ {\n+ filterMethod = (items, text) => completionService.FilterItems(document, items, text);\n+ }\n+\n+ return HandleNormalFiltering(\n+ filterMethod,\n+ filterText,\n+ updatedFilters,\n+ initialRoslynTriggerKind,\n+ filterReason,\n+ data.Trigger.Character,\n+ initialListOfItemsToBeIncluded,\n+ highlightedList,\n+ hasSuggestedItemOptions);\n+ }\n+\n+ private static bool IsAfterDot(ITextSnapshot snapshot, ITrackingSpan applicableToSpan)\n+ {\n+ var position = applicableToSpan.GetStartPoint(snapshot).Position;\n+ return position > 0 && snapshot[position - 1] == '.';\n+ }\n+\n+ private AsyncCompletionData.FilteredCompletionModel HandleNormalFiltering(\n+ Func<ImmutableArray<RoslynCompletionItem>, string, ImmutableArray<RoslynCompletionItem>> filterMethod,\n+ string filterText,\n+ ImmutableArray<AsyncCompletionData.CompletionFilterWithState> filters,\n+ CompletionTriggerKind initialRoslynTriggerKind,\n+ CompletionFilterReason filterReason,\n+ char typeChar,\n+ List<ExtendedFilterResult> itemsInList,\n+ ImmutableArray<AsyncCompletionData.CompletionItemWithHighlight> highlightedList,\n+ bool hasSuggestedItemOptions)\n+ {\n+ // Not deletion. Defer to the language to decide which item it thinks best\n+ // matches the text typed so far.\n+\n+ // Ask the language to determine which of the *matched* items it wants to select.\n+ var matchingItems = itemsInList.Where(r => r.FilterResult.MatchedFilterText)\n+ .Select(t => t.FilterResult.CompletionItem)\n+ .AsImmutable();\n+\n+ var chosenItems = filterMethod(matchingItems, filterText);\n+\n+ var recentItems = _recentItems;\n+\n+ // Of the items the service returned, pick the one most recently committed\n+ var bestItem = Session.GetBestCompletionItemBasedOnMRU(chosenItems, recentItems);\n+ VSCompletionItem uniqueItem = null;\n+ int selectedItemIndex = 0;\n+\n+ // Determine if we should consider this item 'unique' or not. A unique item\n+ // will be automatically committed if the user hits the 'invoke completion' \n+ // without bringing up the completion list. An item is unique if it was the\n+ // only item to match the text typed so far, and there was at least some text\n+ // typed. i.e. if we have \"Console.$$\" we don't want to commit something\n+ // like \"WriteLine\" since no filter text has actually been provided. HOwever,\n+ // if \"Console.WriteL$$\" is typed, then we do want \"WriteLine\" to be committed.\n+ if (bestItem != null)\n+ {\n+ selectedItemIndex = itemsInList.IndexOf(i => Equals(i.FilterResult.CompletionItem, bestItem));\n+ if (selectedItemIndex > -1 && bestItem != null && matchingItems.Length == 1 && filterText.Length > 0)\n+ {\n+ uniqueItem = highlightedList[selectedItemIndex].CompletionItem;\n+ }\n+ }\n+\n+ // If we don't have a best completion item yet, then pick the first item from the list.\n+ var bestOrFirstCompletionItem = bestItem ?? itemsInList.First().FilterResult.CompletionItem;\n+\n+ // Check that it is a filter symbol. We can be called for a non-filter symbol.\n+ if (filterReason == CompletionFilterReason.Insertion &&\n+ !Controller.IsPotentialFilterCharacter(typeChar) &&\n+ !string.IsNullOrEmpty(filterText) &&\n+ !Controller.IsFilterCharacter(bestOrFirstCompletionItem, typeChar, filterText))\n+ {\n+ return null;\n+ }\n+\n+ var updateSelectionHint = Session.IsHardSelection(\n+ filterText, initialRoslynTriggerKind, bestOrFirstCompletionItem,\n+ _completionHelper, filterReason, recentItems, hasSuggestedItemOptions)\n+ ? AsyncCompletionData.UpdateSelectionHint.Selected\n+ : AsyncCompletionData.UpdateSelectionHint.SoftSelected;\n+\n+ if (selectedItemIndex == -1)\n+ {\n+ selectedItemIndex = 0;\n+ }\n+\n+ return new AsyncCompletionData.FilteredCompletionModel(\n+ highlightedList, selectedItemIndex, filters,\n+ updateSelectionHint, centerSelection: true, uniqueItem);\n+ }\n+\n+ private AsyncCompletionData.FilteredCompletionModel HandleDeletionTrigger(\n+ List<ExtendedFilterResult> filterResults,\n+ string filterText,\n+ ImmutableArray<AsyncCompletionData.CompletionFilterWithState> filters,\n+ ImmutableArray<AsyncCompletionData.CompletionItemWithHighlight> highlightedList)\n+ {","path":"src/EditorFeatures/Core/Implementation/IntelliSense/AsyncCompletion/ItemManager.cs","position":295,"original_position":295,"commit_id":"6d35a6f0077e477206312062cda4d982c1ab0739","original_commit_id":"6d35a6f0077e477206312062cda4d982c1ab0739","user":{"login":"ivanbasov","id":5455484,"node_id":"MDQ6VXNlcjU0NTU0ODQ=","avatar_url":"https://avatars2.githubusercontent.com/u/5455484?v=4","gravatar_id":"","url":"https://api.github.com/users/ivanbasov","html_url":"https://github.com/ivanbasov","followers_url":"https://api.github.com/users/ivanbasov/followers","following_url":"https://api.github.com/users/ivanbasov/following{/other_user}","gists_url":"https://api.github.com/users/ivanbasov/gists{/gist_id}","starred_url":"https://api.github.com/users/ivanbasov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ivanbasov/subscriptions","organizations_url":"https://api.github.com/users/ivanbasov/orgs","repos_url":"https://api.github.com/users/ivanbasov/repos","events_url":"https://api.github.com/users/ivanbasov/events{/privacy}","received_events_url":"https://api.github.com/users/ivanbasov/received_events","type":"User","site_admin":false},"body":"I think the most of the scenario should be covered by HandleAllItemsFilteredOut. The only difference I see is where filterText.Length <= 1.\r\n\r\nAdded [https://github.com/dotnet/roslyn/issues/31135](https://github.com/dotnet/roslyn/issues/31135) to check if we need to specifically cover the case.\r\n\r\n---\r\nIn reply to: [232510424](https://github.com/dotnet/roslyn/pull/29016#discussion_r232510424) [](ancestors = 232510424)","created_at":"2018-11-13T02:30:40Z","updated_at":"2018-11-13T02:30:40Z","html_url":"https://github.com/dotnet/roslyn/pull/29016#discussion_r232878146","pull_request_url":"https://api.github.com/repos/dotnet/roslyn/pulls/29016","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/comments/232878146"},"html":{"href":"https://github.com/dotnet/roslyn/pull/29016#discussion_r232878146"},"pull_request":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/29016"}},"in_reply_to_id":232510424},"pull_request":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/29016","id":205575269,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1NTc1MjY5","html_url":"https://github.com/dotnet/roslyn/pull/29016","diff_url":"https://github.com/dotnet/roslyn/pull/29016.diff","patch_url":"https://github.com/dotnet/roslyn/pull/29016.patch","issue_url":"https://api.github.com/repos/dotnet/roslyn/issues/29016","number":29016,"state":"open","locked":false,"title":"Implementation of new editor completion API","user":{"login":"ivanbasov","id":5455484,"node_id":"MDQ6VXNlcjU0NTU0ODQ=","avatar_url":"https://avatars2.githubusercontent.com/u/5455484?v=4","gravatar_id":"","url":"https://api.github.com/users/ivanbasov","html_url":"https://github.com/ivanbasov","followers_url":"https://api.github.com/users/ivanbasov/followers","following_url":"https://api.github.com/users/ivanbasov/following{/other_user}","gists_url":"https://api.github.com/users/ivanbasov/gists{/gist_id}","starred_url":"https://api.github.com/users/ivanbasov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ivanbasov/subscriptions","organizations_url":"https://api.github.com/users/ivanbasov/orgs","repos_url":"https://api.github.com/users/ivanbasov/repos","events_url":"https://api.github.com/users/ivanbasov/events{/privacy}","received_events_url":"https://api.github.com/users/ivanbasov/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-08-01T22:51:57Z","updated_at":"2018-11-13T02:30:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"80bdf6b2fe3ac9f53b0d02bee7c90443335e2097","assignee":null,"assignees":[],"requested_reviewers":[{"login":"jinujoseph","id":12449387,"node_id":"MDQ6VXNlcjEyNDQ5Mzg3","avatar_url":"https://avatars3.githubusercontent.com/u/12449387?v=4","gravatar_id":"","url":"https://api.github.com/users/jinujoseph","html_url":"https://github.com/jinujoseph","followers_url":"https://api.github.com/users/jinujoseph/followers","following_url":"https://api.github.com/users/jinujoseph/following{/other_user}","gists_url":"https://api.github.com/users/jinujoseph/gists{/gist_id}","starred_url":"https://api.github.com/users/jinujoseph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jinujoseph/subscriptions","organizations_url":"https://api.github.com/users/jinujoseph/orgs","repos_url":"https://api.github.com/users/jinujoseph/repos","events_url":"https://api.github.com/users/jinujoseph/events{/privacy}","received_events_url":"https://api.github.com/users/jinujoseph/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":166377917,"node_id":"MDU6TGFiZWwxNjYzNzc5MTc=","url":"https://api.github.com/repos/dotnet/roslyn/labels/Area-IDE","name":"Area-IDE","color":"5319e7","default":false}],"milestone":{"url":"https://api.github.com/repos/dotnet/roslyn/milestones/18","html_url":"https://github.com/dotnet/roslyn/milestone/18","labels_url":"https://api.github.com/repos/dotnet/roslyn/milestones/18/labels","id":1675130,"node_id":"MDk6TWlsZXN0b25lMTY3NTEzMA==","number":18,"title":"16.0","description":"The version *after* the next major version.","creator":{"login":"gafter","id":3804346,"node_id":"MDQ6VXNlcjM4MDQzNDY=","avatar_url":"https://avatars3.githubusercontent.com/u/3804346?v=4","gravatar_id":"","url":"https://api.github.com/users/gafter","html_url":"https://github.com/gafter","followers_url":"https://api.github.com/users/gafter/followers","following_url":"https://api.github.com/users/gafter/following{/other_user}","gists_url":"https://api.github.com/users/gafter/gists{/gist_id}","starred_url":"https://api.github.com/users/gafter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gafter/subscriptions","organizations_url":"https://api.github.com/users/gafter/orgs","repos_url":"https://api.github.com/users/gafter/repos","events_url":"https://api.github.com/users/gafter/events{/privacy}","received_events_url":"https://api.github.com/users/gafter/received_events","type":"User","site_admin":false},"open_issues":1326,"closed_issues":864,"state":"open","created_at":"2016-03-31T00:06:25Z","updated_at":"2018-11-13T00:21:45Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/dotnet/roslyn/pulls/29016/commits","review_comments_url":"https://api.github.com/repos/dotnet/roslyn/pulls/29016/comments","review_comment_url":"https://api.github.com/repos/dotnet/roslyn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/roslyn/issues/29016/comments","statuses_url":"https://api.github.com/repos/dotnet/roslyn/statuses/6d35a6f0077e477206312062cda4d982c1ab0739","head":{"label":"ivanbasov:asynccompletion","ref":"asynccompletion","sha":"6d35a6f0077e477206312062cda4d982c1ab0739","user":{"login":"ivanbasov","id":5455484,"node_id":"MDQ6VXNlcjU0NTU0ODQ=","avatar_url":"https://avatars2.githubusercontent.com/u/5455484?v=4","gravatar_id":"","url":"https://api.github.com/users/ivanbasov","html_url":"https://github.com/ivanbasov","followers_url":"https://api.github.com/users/ivanbasov/followers","following_url":"https://api.github.com/users/ivanbasov/following{/other_user}","gists_url":"https://api.github.com/users/ivanbasov/gists{/gist_id}","starred_url":"https://api.github.com/users/ivanbasov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ivanbasov/subscriptions","organizations_url":"https://api.github.com/users/ivanbasov/orgs","repos_url":"https://api.github.com/users/ivanbasov/repos","events_url":"https://api.github.com/users/ivanbasov/events{/privacy}","received_events_url":"https://api.github.com/users/ivanbasov/received_events","type":"User","site_admin":false},"repo":{"id":85608790,"node_id":"MDEwOlJlcG9zaXRvcnk4NTYwODc5MA==","name":"roslyn","full_name":"ivanbasov/roslyn","private":false,"owner":{"login":"ivanbasov","id":5455484,"node_id":"MDQ6VXNlcjU0NTU0ODQ=","avatar_url":"https://avatars2.githubusercontent.com/u/5455484?v=4","gravatar_id":"","url":"https://api.github.com/users/ivanbasov","html_url":"https://github.com/ivanbasov","followers_url":"https://api.github.com/users/ivanbasov/followers","following_url":"https://api.github.com/users/ivanbasov/following{/other_user}","gists_url":"https://api.github.com/users/ivanbasov/gists{/gist_id}","starred_url":"https://api.github.com/users/ivanbasov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ivanbasov/subscriptions","organizations_url":"https://api.github.com/users/ivanbasov/orgs","repos_url":"https://api.github.com/users/ivanbasov/repos","events_url":"https://api.github.com/users/ivanbasov/events{/privacy}","received_events_url":"https://api.github.com/users/ivanbasov/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ivanbasov/roslyn","description":"The .NET Compiler Platform (\"Roslyn\") provides open-source C# and Visual Basic compilers with rich code analysis APIs.","fork":true,"url":"https://api.github.com/repos/ivanbasov/roslyn","forks_url":"https://api.github.com/repos/ivanbasov/roslyn/forks","keys_url":"https://api.github.com/repos/ivanbasov/roslyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ivanbasov/roslyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ivanbasov/roslyn/teams","hooks_url":"https://api.github.com/repos/ivanbasov/roslyn/hooks","issue_events_url":"https://api.github.com/repos/ivanbasov/roslyn/issues/events{/number}","events_url":"https://api.github.com/repos/ivanbasov/roslyn/events","assignees_url":"https://api.github.com/repos/ivanbasov/roslyn/assignees{/user}","branches_url":"https://api.github.com/repos/ivanbasov/roslyn/branches{/branch}","tags_url":"https://api.github.com/repos/ivanbasov/roslyn/tags","blobs_url":"https://api.github.com/repos/ivanbasov/roslyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ivanbasov/roslyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ivanbasov/roslyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/ivanbasov/roslyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ivanbasov/roslyn/statuses/{sha}","languages_url":"https://api.github.com/repos/ivanbasov/roslyn/languages","stargazers_url":"https://api.github.com/repos/ivanbasov/roslyn/stargazers","contributors_url":"https://api.github.com/repos/ivanbasov/roslyn/contributors","subscribers_url":"https://api.github.com/repos/ivanbasov/roslyn/subscribers","subscription_url":"https://api.github.com/repos/ivanbasov/roslyn/subscription","commits_url":"https://api.github.com/repos/ivanbasov/roslyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/ivanbasov/roslyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/ivanbasov/roslyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/ivanbasov/roslyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/ivanbasov/roslyn/contents/{+path}","compare_url":"https://api.github.com/repos/ivanbasov/roslyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ivanbasov/roslyn/merges","archive_url":"https://api.github.com/repos/ivanbasov/roslyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ivanbasov/roslyn/downloads","issues_url":"https://api.github.com/repos/ivanbasov/roslyn/issues{/number}","pulls_url":"https://api.github.com/repos/ivanbasov/roslyn/pulls{/number}","milestones_url":"https://api.github.com/repos/ivanbasov/roslyn/milestones{/number}","notifications_url":"https://api.github.com/repos/ivanbasov/roslyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ivanbasov/roslyn/labels{/name}","releases_url":"https://api.github.com/repos/ivanbasov/roslyn/releases{/id}","deployments_url":"https://api.github.com/repos/ivanbasov/roslyn/deployments","created_at":"2017-03-20T17:55:57Z","updated_at":"2017-03-20T17:56:36Z","pushed_at":"2018-11-10T00:24:04Z","git_url":"git://github.com/ivanbasov/roslyn.git","ssh_url":"[email protected]:ivanbasov/roslyn.git","clone_url":"https://github.com/ivanbasov/roslyn.git","svn_url":"https://github.com/ivanbasov/roslyn","homepage":"","size":437786,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:dev16.0-preview2-vs-deps","ref":"dev16.0-preview2-vs-deps","sha":"905cb87bc57ea57930a80613fec9c5851c247946","user":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":29078997,"node_id":"MDEwOlJlcG9zaXRvcnkyOTA3ODk5Nw==","name":"roslyn","full_name":"dotnet/roslyn","private":false,"owner":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dotnet/roslyn","description":"The Roslyn .NET compiler provides C# and Visual Basic languages with rich code analysis APIs.","fork":false,"url":"https://api.github.com/repos/dotnet/roslyn","forks_url":"https://api.github.com/repos/dotnet/roslyn/forks","keys_url":"https://api.github.com/repos/dotnet/roslyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/roslyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/roslyn/teams","hooks_url":"https://api.github.com/repos/dotnet/roslyn/hooks","issue_events_url":"https://api.github.com/repos/dotnet/roslyn/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/roslyn/events","assignees_url":"https://api.github.com/repos/dotnet/roslyn/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/roslyn/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/roslyn/tags","blobs_url":"https://api.github.com/repos/dotnet/roslyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/roslyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/roslyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/roslyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/roslyn/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/roslyn/languages","stargazers_url":"https://api.github.com/repos/dotnet/roslyn/stargazers","contributors_url":"https://api.github.com/repos/dotnet/roslyn/contributors","subscribers_url":"https://api.github.com/repos/dotnet/roslyn/subscribers","subscription_url":"https://api.github.com/repos/dotnet/roslyn/subscription","commits_url":"https://api.github.com/repos/dotnet/roslyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/roslyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/roslyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/roslyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/roslyn/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/roslyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/roslyn/merges","archive_url":"https://api.github.com/repos/dotnet/roslyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/roslyn/downloads","issues_url":"https://api.github.com/repos/dotnet/roslyn/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/roslyn/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/roslyn/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/roslyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/roslyn/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/roslyn/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/roslyn/deployments","created_at":"2015-01-11T02:39:03Z","updated_at":"2018-11-13T02:27:15Z","pushed_at":"2018-11-13T02:08:21Z","git_url":"git://github.com/dotnet/roslyn.git","ssh_url":"[email protected]:dotnet/roslyn.git","clone_url":"https://github.com/dotnet/roslyn.git","svn_url":"https://github.com/dotnet/roslyn","homepage":"https://docs.microsoft.com/dotnet/csharp/roslyn-sdk/","size":486521,"stargazers_count":10338,"watchers_count":10338,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2448,"mirror_url":null,"archived":false,"open_issues_count":5376,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2448,"open_issues":5376,"watchers":10338,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/29016"},"html":{"href":"https://github.com/dotnet/roslyn/pull/29016"},"issue":{"href":"https://api.github.com/repos/dotnet/roslyn/issues/29016"},"comments":{"href":"https://api.github.com/repos/dotnet/roslyn/issues/29016/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/29016/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/29016/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/roslyn/statuses/6d35a6f0077e477206312062cda4d982c1ab0739"}},"author_association":"CONTRIBUTOR"}} | {
"id": 29078997,
"name": "dotnet/roslyn",
"url": "https://api.github.com/repos/dotnet/roslyn"
} | {
"id": 5455484,
"login": "ivanbasov",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5455484?",
"url": "https://api.github.com/users/ivanbasov"
} | {
"id": 9141961,
"login": "dotnet",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9141961?",
"url": "https://api.github.com/orgs/dotnet"
} | 2018-11-13T02:30:40 | 8577951518 | {"actor":{"display_login":"ivanbasov"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/comments/236605618","pull_request_review_id":178711272,"id":236605618,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNjYwNTYxOA==","diff_hunk":"@@ -20,7 +20,7 @@ public override BoundNode VisitIsPatternExpression(BoundIsPatternExpression node\n // Input must be used no more than once in the result. If it is needed repeatedly store its value in a temp and use the temp.\n BoundExpression MakeIsPattern(BoundPattern loweredPattern, BoundExpression loweredInput)\n {\n- var syntax = _factory.Syntax = loweredPattern.Syntax;\n+ _ = _factory.Syntax = loweredPattern.Syntax;","path":"src/Compilers/CSharp/Portable/Lowering/LocalRewriter/LocalRewriter_Patterns.cs","position":5,"original_position":5,"commit_id":"a98e181b504474106dcd080ae092abb8d789d1b6","original_commit_id":"a98e181b504474106dcd080ae092abb8d789d1b6","user":{"login":"mavasani","id":10605811,"node_id":"MDQ6VXNlcjEwNjA1ODEx","avatar_url":"https://avatars2.githubusercontent.com/u/10605811?v=4","gravatar_id":"","url":"https://api.github.com/users/mavasani","html_url":"https://github.com/mavasani","followers_url":"https://api.github.com/users/mavasani/followers","following_url":"https://api.github.com/users/mavasani/following{/other_user}","gists_url":"https://api.github.com/users/mavasani/gists{/gist_id}","starred_url":"https://api.github.com/users/mavasani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mavasani/subscriptions","organizations_url":"https://api.github.com/users/mavasani/orgs","repos_url":"https://api.github.com/users/mavasani/repos","events_url":"https://api.github.com/users/mavasani/events{/privacy}","received_events_url":"https://api.github.com/users/mavasani/received_events","type":"User","site_admin":false},"body":"I am going to leave this one as is for now as this is a very rare case.","created_at":"2018-11-27T10:38:34Z","updated_at":"2018-11-27T10:38:34Z","html_url":"https://github.com/dotnet/roslyn/pull/31387#discussion_r236605618","pull_request_url":"https://api.github.com/repos/dotnet/roslyn/pulls/31387","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/comments/236605618"},"html":{"href":"https://github.com/dotnet/roslyn/pull/31387#discussion_r236605618"},"pull_request":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/31387"}},"in_reply_to_id":236552887},"pull_request":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/31387","id":233808875,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzODA4ODc1","html_url":"https://github.com/dotnet/roslyn/pull/31387","diff_url":"https://github.com/dotnet/roslyn/pull/31387.diff","patch_url":"https://github.com/dotnet/roslyn/pull/31387.patch","issue_url":"https://api.github.com/repos/dotnet/roslyn/issues/31387","number":31387,"state":"open","locked":false,"title":"[DO NOT MERGE] Test PR to show FixAll results from analyzer/fixer added in #30777","user":{"login":"mavasani","id":10605811,"node_id":"MDQ6VXNlcjEwNjA1ODEx","avatar_url":"https://avatars2.githubusercontent.com/u/10605811?v=4","gravatar_id":"","url":"https://api.github.com/users/mavasani","html_url":"https://github.com/mavasani","followers_url":"https://api.github.com/users/mavasani/followers","following_url":"https://api.github.com/users/mavasani/following{/other_user}","gists_url":"https://api.github.com/users/mavasani/gists{/gist_id}","starred_url":"https://api.github.com/users/mavasani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mavasani/subscriptions","organizations_url":"https://api.github.com/users/mavasani/orgs","repos_url":"https://api.github.com/users/mavasani/repos","events_url":"https://api.github.com/users/mavasani/events{/privacy}","received_events_url":"https://api.github.com/users/mavasani/received_events","type":"User","site_admin":false},"body":"Test PR to show FixAll results from analyzer/fixer added in #30777\r\n\r\n1. FixAll in solution seems to take an eternity and never complete, even for existing IDE diagnostics unrelated to #30777. Hence, I applied FixAll in project for couple of projects: CodeAnalysis.csproj and CSharpCodeAnalysis.csproj for this PR. I will file a separate issue to investigate FixAll in solution performance.\r\n2. This PR shows there are still cases where we can tweak the code fix to generate slightly better code, but these seem minor, which can wait for customer feedback.\r\n3. I personally feel unused out variables add a lot of noise and possibly need a different option, such that its default editorconfig value is prefer unused local instead of prefer discard. However, this can wait for more customer feedback.\r\n4. I executed the analyzer added in #30777 (built after the latest commit in #30777) using AnalyzerRunner.exe on the entire Roslyn.sln, and this executed without any asserts. The performance is also comparable to the existing IDE analyzer (I confirmed against MakeFieldReadOnlyAnalyzer's execution time).","created_at":"2018-11-27T07:43:24Z","updated_at":"2018-11-27T10:38:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1ec9b893fc79fcdb6a75786ba600b66f15b15c51","assignee":null,"assignees":[],"requested_reviewers":[{"login":"heejaechang","id":1333179,"node_id":"MDQ6VXNlcjEzMzMxNzk=","avatar_url":"https://avatars3.githubusercontent.com/u/1333179?v=4","gravatar_id":"","url":"https://api.github.com/users/heejaechang","html_url":"https://github.com/heejaechang","followers_url":"https://api.github.com/users/heejaechang/followers","following_url":"https://api.github.com/users/heejaechang/following{/other_user}","gists_url":"https://api.github.com/users/heejaechang/gists{/gist_id}","starred_url":"https://api.github.com/users/heejaechang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heejaechang/subscriptions","organizations_url":"https://api.github.com/users/heejaechang/orgs","repos_url":"https://api.github.com/users/heejaechang/repos","events_url":"https://api.github.com/users/heejaechang/events{/privacy}","received_events_url":"https://api.github.com/users/heejaechang/received_events","type":"User","site_admin":false},{"login":"ivanbasov","id":5455484,"node_id":"MDQ6VXNlcjU0NTU0ODQ=","avatar_url":"https://avatars2.githubusercontent.com/u/5455484?v=4","gravatar_id":"","url":"https://api.github.com/users/ivanbasov","html_url":"https://github.com/ivanbasov","followers_url":"https://api.github.com/users/ivanbasov/followers","following_url":"https://api.github.com/users/ivanbasov/following{/other_user}","gists_url":"https://api.github.com/users/ivanbasov/gists{/gist_id}","starred_url":"https://api.github.com/users/ivanbasov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ivanbasov/subscriptions","organizations_url":"https://api.github.com/users/ivanbasov/orgs","repos_url":"https://api.github.com/users/ivanbasov/repos","events_url":"https://api.github.com/users/ivanbasov/events{/privacy}","received_events_url":"https://api.github.com/users/ivanbasov/received_events","type":"User","site_admin":false},{"login":"jinujoseph","id":12449387,"node_id":"MDQ6VXNlcjEyNDQ5Mzg3","avatar_url":"https://avatars3.githubusercontent.com/u/12449387?v=4","gravatar_id":"","url":"https://api.github.com/users/jinujoseph","html_url":"https://github.com/jinujoseph","followers_url":"https://api.github.com/users/jinujoseph/followers","following_url":"https://api.github.com/users/jinujoseph/following{/other_user}","gists_url":"https://api.github.com/users/jinujoseph/gists{/gist_id}","starred_url":"https://api.github.com/users/jinujoseph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jinujoseph/subscriptions","organizations_url":"https://api.github.com/users/jinujoseph/orgs","repos_url":"https://api.github.com/users/jinujoseph/repos","events_url":"https://api.github.com/users/jinujoseph/events{/privacy}","received_events_url":"https://api.github.com/users/jinujoseph/received_events","type":"User","site_admin":false}],"requested_teams":[{"name":"roslyn-compiler","id":1803172,"node_id":"MDQ6VGVhbTE4MDMxNzI=","slug":"roslyn-compiler","description":"Roslyn Compiler Team","privacy":"closed","url":"https://api.github.com/teams/1803172","members_url":"https://api.github.com/teams/1803172/members{/member}","repositories_url":"https://api.github.com/teams/1803172/repos","permission":"pull"}],"labels":[{"id":166381314,"node_id":"MDU6TGFiZWwxNjYzODEzMTQ=","url":"https://api.github.com/repos/dotnet/roslyn/labels/Area-Analyzers","name":"Area-Analyzers","color":"5319e7","default":false},{"id":166673288,"node_id":"MDU6TGFiZWwxNjY2NzMyODg=","url":"https://api.github.com/repos/dotnet/roslyn/labels/Area-Compilers","name":"Area-Compilers","color":"5319e7","default":false},{"id":278927730,"node_id":"MDU6TGFiZWwyNzg5Mjc3MzA=","url":"https://api.github.com/repos/dotnet/roslyn/labels/PR%20For%20Personal%20Review%20Only","name":"PR For Personal Review Only","color":"000000","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/roslyn/pulls/31387/commits","review_comments_url":"https://api.github.com/repos/dotnet/roslyn/pulls/31387/comments","review_comment_url":"https://api.github.com/repos/dotnet/roslyn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/roslyn/issues/31387/comments","statuses_url":"https://api.github.com/repos/dotnet/roslyn/statuses/a98e181b504474106dcd080ae092abb8d789d1b6","head":{"label":"mavasani:FixAllUnusedExpressions","ref":"FixAllUnusedExpressions","sha":"a98e181b504474106dcd080ae092abb8d789d1b6","user":{"login":"mavasani","id":10605811,"node_id":"MDQ6VXNlcjEwNjA1ODEx","avatar_url":"https://avatars2.githubusercontent.com/u/10605811?v=4","gravatar_id":"","url":"https://api.github.com/users/mavasani","html_url":"https://github.com/mavasani","followers_url":"https://api.github.com/users/mavasani/followers","following_url":"https://api.github.com/users/mavasani/following{/other_user}","gists_url":"https://api.github.com/users/mavasani/gists{/gist_id}","starred_url":"https://api.github.com/users/mavasani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mavasani/subscriptions","organizations_url":"https://api.github.com/users/mavasani/orgs","repos_url":"https://api.github.com/users/mavasani/repos","events_url":"https://api.github.com/users/mavasani/events{/privacy}","received_events_url":"https://api.github.com/users/mavasani/received_events","type":"User","site_admin":false},"repo":{"id":30584055,"node_id":"MDEwOlJlcG9zaXRvcnkzMDU4NDA1NQ==","name":"roslyn","full_name":"mavasani/roslyn","private":false,"owner":{"login":"mavasani","id":10605811,"node_id":"MDQ6VXNlcjEwNjA1ODEx","avatar_url":"https://avatars2.githubusercontent.com/u/10605811?v=4","gravatar_id":"","url":"https://api.github.com/users/mavasani","html_url":"https://github.com/mavasani","followers_url":"https://api.github.com/users/mavasani/followers","following_url":"https://api.github.com/users/mavasani/following{/other_user}","gists_url":"https://api.github.com/users/mavasani/gists{/gist_id}","starred_url":"https://api.github.com/users/mavasani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mavasani/subscriptions","organizations_url":"https://api.github.com/users/mavasani/orgs","repos_url":"https://api.github.com/users/mavasani/repos","events_url":"https://api.github.com/users/mavasani/events{/privacy}","received_events_url":"https://api.github.com/users/mavasani/received_events","type":"User","site_admin":false},"html_url":"https://github.com/mavasani/roslyn","description":"The .NET Compiler Platform (\"Roslyn\") provides open-source C# and Visual Basic compilers with rich code analysis APIs.","fork":true,"url":"https://api.github.com/repos/mavasani/roslyn","forks_url":"https://api.github.com/repos/mavasani/roslyn/forks","keys_url":"https://api.github.com/repos/mavasani/roslyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mavasani/roslyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mavasani/roslyn/teams","hooks_url":"https://api.github.com/repos/mavasani/roslyn/hooks","issue_events_url":"https://api.github.com/repos/mavasani/roslyn/issues/events{/number}","events_url":"https://api.github.com/repos/mavasani/roslyn/events","assignees_url":"https://api.github.com/repos/mavasani/roslyn/assignees{/user}","branches_url":"https://api.github.com/repos/mavasani/roslyn/branches{/branch}","tags_url":"https://api.github.com/repos/mavasani/roslyn/tags","blobs_url":"https://api.github.com/repos/mavasani/roslyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mavasani/roslyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mavasani/roslyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/mavasani/roslyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mavasani/roslyn/statuses/{sha}","languages_url":"https://api.github.com/repos/mavasani/roslyn/languages","stargazers_url":"https://api.github.com/repos/mavasani/roslyn/stargazers","contributors_url":"https://api.github.com/repos/mavasani/roslyn/contributors","subscribers_url":"https://api.github.com/repos/mavasani/roslyn/subscribers","subscription_url":"https://api.github.com/repos/mavasani/roslyn/subscription","commits_url":"https://api.github.com/repos/mavasani/roslyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/mavasani/roslyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/mavasani/roslyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/mavasani/roslyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/mavasani/roslyn/contents/{+path}","compare_url":"https://api.github.com/repos/mavasani/roslyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mavasani/roslyn/merges","archive_url":"https://api.github.com/repos/mavasani/roslyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mavasani/roslyn/downloads","issues_url":"https://api.github.com/repos/mavasani/roslyn/issues{/number}","pulls_url":"https://api.github.com/repos/mavasani/roslyn/pulls{/number}","milestones_url":"https://api.github.com/repos/mavasani/roslyn/milestones{/number}","notifications_url":"https://api.github.com/repos/mavasani/roslyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mavasani/roslyn/labels{/name}","releases_url":"https://api.github.com/repos/mavasani/roslyn/releases{/id}","deployments_url":"https://api.github.com/repos/mavasani/roslyn/deployments","created_at":"2015-02-10T09:12:41Z","updated_at":"2018-11-26T19:32:07Z","pushed_at":"2018-11-27T10:36:24Z","git_url":"git://github.com/mavasani/roslyn.git","ssh_url":"[email protected]:mavasani/roslyn.git","clone_url":"https://github.com/mavasani/roslyn.git","svn_url":"https://github.com/mavasani/roslyn","homepage":"","size":444544,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"547fbc0e803540c3b494e927ae680894cd30f2ef","user":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":29078997,"node_id":"MDEwOlJlcG9zaXRvcnkyOTA3ODk5Nw==","name":"roslyn","full_name":"dotnet/roslyn","private":false,"owner":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dotnet/roslyn","description":"The Roslyn .NET compiler provides C# and Visual Basic languages with rich code analysis APIs.","fork":false,"url":"https://api.github.com/repos/dotnet/roslyn","forks_url":"https://api.github.com/repos/dotnet/roslyn/forks","keys_url":"https://api.github.com/repos/dotnet/roslyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/roslyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/roslyn/teams","hooks_url":"https://api.github.com/repos/dotnet/roslyn/hooks","issue_events_url":"https://api.github.com/repos/dotnet/roslyn/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/roslyn/events","assignees_url":"https://api.github.com/repos/dotnet/roslyn/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/roslyn/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/roslyn/tags","blobs_url":"https://api.github.com/repos/dotnet/roslyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/roslyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/roslyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/roslyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/roslyn/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/roslyn/languages","stargazers_url":"https://api.github.com/repos/dotnet/roslyn/stargazers","contributors_url":"https://api.github.com/repos/dotnet/roslyn/contributors","subscribers_url":"https://api.github.com/repos/dotnet/roslyn/subscribers","subscription_url":"https://api.github.com/repos/dotnet/roslyn/subscription","commits_url":"https://api.github.com/repos/dotnet/roslyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/roslyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/roslyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/roslyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/roslyn/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/roslyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/roslyn/merges","archive_url":"https://api.github.com/repos/dotnet/roslyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/roslyn/downloads","issues_url":"https://api.github.com/repos/dotnet/roslyn/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/roslyn/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/roslyn/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/roslyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/roslyn/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/roslyn/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/roslyn/deployments","created_at":"2015-01-11T02:39:03Z","updated_at":"2018-11-27T08:28:29Z","pushed_at":"2018-11-27T10:36:28Z","git_url":"git://github.com/dotnet/roslyn.git","ssh_url":"[email protected]:dotnet/roslyn.git","clone_url":"https://github.com/dotnet/roslyn.git","svn_url":"https://github.com/dotnet/roslyn","homepage":"https://docs.microsoft.com/dotnet/csharp/roslyn-sdk/","size":489097,"stargazers_count":10401,"watchers_count":10401,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2465,"mirror_url":null,"archived":false,"open_issues_count":5438,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2465,"open_issues":5438,"watchers":10401,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/31387"},"html":{"href":"https://github.com/dotnet/roslyn/pull/31387"},"issue":{"href":"https://api.github.com/repos/dotnet/roslyn/issues/31387"},"comments":{"href":"https://api.github.com/repos/dotnet/roslyn/issues/31387/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/31387/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/31387/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/roslyn/statuses/a98e181b504474106dcd080ae092abb8d789d1b6"}},"author_association":"CONTRIBUTOR"}} | {
"id": 29078997,
"name": "dotnet/roslyn",
"url": "https://api.github.com/repos/dotnet/roslyn"
} | {
"id": 10605811,
"login": "mavasani",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/10605811?",
"url": "https://api.github.com/users/mavasani"
} | {
"id": 9141961,
"login": "dotnet",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9141961?",
"url": "https://api.github.com/orgs/dotnet"
} | 2018-11-27T10:38:34 | 8653365590 | {"actor":{"display_login":"mavasani"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/comments/201158870","pull_request_review_id":135606556,"id":201158870,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMTE1ODg3MA==","diff_hunk":"@@ -2768,6 +2768,52 @@ public override BoundNode VisitNonConstructorMethodBody(BoundNonConstructorMetho\n return null;\n }\n \n+ public override BoundNode VisitNullCoalesingAssignmentOperator(BoundNullCoalesingAssignmentOperator node)\n+ {\n+ LocalState savedState;\n+ if (RegularPropertyAccess(node.LeftOperand))\n+ {\n+ var left = (BoundPropertyAccess)node.LeftOperand;\n+ var property = left.PropertySymbol;\n+ if (property.RefKind == RefKind.None)\n+ {\n+ var readMethod = property.GetOwnOrInheritedGetMethod() ?? property.SetMethod;\n+ var writeMethod = property.GetOwnOrInheritedSetMethod() ?? property.GetMethod;\n+\n+ Debug.Assert(node.HasAnyErrors || (object)readMethod != (object)writeMethod);\n+\n+ VisitReceiverBeforeCall(left.ReceiverOpt, readMethod);\n+ if (_trackExceptions) NotePossibleException(node);\n+ VisitReceiverAfterCall(left.ReceiverOpt, readMethod);\n+\n+ savedState = this.State.Clone();\n+\n+ VisitRvalue(node.RightOperand);\n+ PropertySetter(node, left.ReceiverOpt, writeMethod);\n+\n+ ConditionallyAssignNullCoalescingOperator(node);\n+\n+ IntersectWith(ref this.State, ref savedState);\n+ return null;\n+ }\n+ }\n+\n+ VisitRvalue(node.LeftOperand);\n+ savedState = this.State.Clone();\n+\n+ VisitRvalue(node.RightOperand);\n+ ConditionallyAssignNullCoalescingOperator(node);\n+\n+ IntersectWith(ref this.State, ref savedState);\n+ return null;\n+ }\n+\n+ protected virtual void ConditionallyAssignNullCoalescingOperator(BoundNullCoalesingAssignmentOperator node)","path":"src/Compilers/CSharp/Portable/FlowAnalysis/PreciseAbstractFlowPass.cs","position":44,"original_position":44,"commit_id":"63819958f673804fb9d97ad4bedbdc8e1a0f96e6","original_commit_id":"63819958f673804fb9d97ad4bedbdc8e1a0f96e6","user":{"login":"333fred","id":2371880,"node_id":"MDQ6VXNlcjIzNzE4ODA=","avatar_url":"https://avatars0.githubusercontent.com/u/2371880?v=4","gravatar_id":"","url":"https://api.github.com/users/333fred","html_url":"https://github.com/333fred","followers_url":"https://api.github.com/users/333fred/followers","following_url":"https://api.github.com/users/333fred/following{/other_user}","gists_url":"https://api.github.com/users/333fred/gists{/gist_id}","starred_url":"https://api.github.com/users/333fred/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/333fred/subscriptions","organizations_url":"https://api.github.com/users/333fred/orgs","repos_url":"https://api.github.com/users/333fred/repos","events_url":"https://api.github.com/users/333fred/events{/privacy}","received_events_url":"https://api.github.com/users/333fred/received_events","type":"User","site_admin":false},"body":"No, it's only needed for `DataFlowPass` analysis. `ControlFlowPass` doesn't need this, for example.\r\n\r\n---\r\nIn reply to: [200785081](https://github.com/dotnet/roslyn/pull/28253#discussion_r200785081) [](ancestors = 200785081)","created_at":"2018-07-09T21:52:01Z","updated_at":"2018-07-09T21:52:01Z","html_url":"https://github.com/dotnet/roslyn/pull/28253#discussion_r201158870","pull_request_url":"https://api.github.com/repos/dotnet/roslyn/pulls/28253","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/comments/201158870"},"html":{"href":"https://github.com/dotnet/roslyn/pull/28253#discussion_r201158870"},"pull_request":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/28253"}},"in_reply_to_id":200785081},"pull_request":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/28253","id":198823928,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4ODIzOTI4","html_url":"https://github.com/dotnet/roslyn/pull/28253","diff_url":"https://github.com/dotnet/roslyn/pull/28253.diff","patch_url":"https://github.com/dotnet/roslyn/pull/28253.patch","issue_url":"https://api.github.com/repos/dotnet/roslyn/issues/28253","number":28253,"state":"open","locked":false,"title":"Added binding for null coalescing assignment","user":{"login":"333fred","id":2371880,"node_id":"MDQ6VXNlcjIzNzE4ODA=","avatar_url":"https://avatars0.githubusercontent.com/u/2371880?v=4","gravatar_id":"","url":"https://api.github.com/users/333fred","html_url":"https://github.com/333fred","followers_url":"https://api.github.com/users/333fred/followers","following_url":"https://api.github.com/users/333fred/following{/other_user}","gists_url":"https://api.github.com/users/333fred/gists{/gist_id}","starred_url":"https://api.github.com/users/333fred/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/333fred/subscriptions","organizations_url":"https://api.github.com/users/333fred/orgs","repos_url":"https://api.github.com/users/333fred/repos","events_url":"https://api.github.com/users/333fred/events{/privacy}","received_events_url":"https://api.github.com/users/333fred/received_events","type":"User","site_admin":false},"body":"Added support for initial binding, dataflow passes, and the local lowering\r\npass for null coalescing assignment. IOperation and CFG support will come in\r\na follow-up PR, as will relevant semantic model testing.\r\n\r\n@dotnet/roslyn-compiler for review.\r\n\r\nRelates to feature: https://github.com/dotnet/csharplang/issues/34 and spec: https://github.com/dotnet/csharplang/blob/master/proposals/null-coalescing-assignment.md","created_at":"2018-07-03T00:54:57Z","updated_at":"2018-07-09T21:52:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cc9976142f6bebc33b06d9878989178c794b4f93","assignee":{"login":"jcouv","id":12466233,"node_id":"MDQ6VXNlcjEyNDY2MjMz","avatar_url":"https://avatars2.githubusercontent.com/u/12466233?v=4","gravatar_id":"","url":"https://api.github.com/users/jcouv","html_url":"https://github.com/jcouv","followers_url":"https://api.github.com/users/jcouv/followers","following_url":"https://api.github.com/users/jcouv/following{/other_user}","gists_url":"https://api.github.com/users/jcouv/gists{/gist_id}","starred_url":"https://api.github.com/users/jcouv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcouv/subscriptions","organizations_url":"https://api.github.com/users/jcouv/orgs","repos_url":"https://api.github.com/users/jcouv/repos","events_url":"https://api.github.com/users/jcouv/events{/privacy}","received_events_url":"https://api.github.com/users/jcouv/received_events","type":"User","site_admin":false},"assignees":[{"login":"jcouv","id":12466233,"node_id":"MDQ6VXNlcjEyNDY2MjMz","avatar_url":"https://avatars2.githubusercontent.com/u/12466233?v=4","gravatar_id":"","url":"https://api.github.com/users/jcouv","html_url":"https://github.com/jcouv","followers_url":"https://api.github.com/users/jcouv/followers","following_url":"https://api.github.com/users/jcouv/following{/other_user}","gists_url":"https://api.github.com/users/jcouv/gists{/gist_id}","starred_url":"https://api.github.com/users/jcouv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcouv/subscriptions","organizations_url":"https://api.github.com/users/jcouv/orgs","repos_url":"https://api.github.com/users/jcouv/repos","events_url":"https://api.github.com/users/jcouv/events{/privacy}","received_events_url":"https://api.github.com/users/jcouv/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[{"name":"roslyn-ide","id":1781706,"node_id":"MDQ6VGVhbTE3ODE3MDY=","slug":"roslyn-ide","description":"Roslyn IDE Team","privacy":"closed","url":"https://api.github.com/teams/1781706","members_url":"https://api.github.com/teams/1781706/members{/member}","repositories_url":"https://api.github.com/teams/1781706/repos","permission":"pull"}],"labels":[{"id":166673288,"node_id":"MDU6TGFiZWwxNjY2NzMyODg=","url":"https://api.github.com/repos/dotnet/roslyn/labels/Area-Compilers","name":"Area-Compilers","color":"5319e7","default":false}],"milestone":{"url":"https://api.github.com/repos/dotnet/roslyn/milestones/18","html_url":"https://github.com/dotnet/roslyn/milestone/18","labels_url":"https://api.github.com/repos/dotnet/roslyn/milestones/18/labels","id":1675130,"node_id":"MDk6TWlsZXN0b25lMTY3NTEzMA==","number":18,"title":"16.0","description":"The version *after* the next major version.","creator":{"login":"gafter","id":3804346,"node_id":"MDQ6VXNlcjM4MDQzNDY=","avatar_url":"https://avatars3.githubusercontent.com/u/3804346?v=4","gravatar_id":"","url":"https://api.github.com/users/gafter","html_url":"https://github.com/gafter","followers_url":"https://api.github.com/users/gafter/followers","following_url":"https://api.github.com/users/gafter/following{/other_user}","gists_url":"https://api.github.com/users/gafter/gists{/gist_id}","starred_url":"https://api.github.com/users/gafter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gafter/subscriptions","organizations_url":"https://api.github.com/users/gafter/orgs","repos_url":"https://api.github.com/users/gafter/repos","events_url":"https://api.github.com/users/gafter/events{/privacy}","received_events_url":"https://api.github.com/users/gafter/received_events","type":"User","site_admin":false},"open_issues":1049,"closed_issues":333,"state":"open","created_at":"2016-03-31T00:06:25Z","updated_at":"2018-07-09T21:46:06Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/dotnet/roslyn/pulls/28253/commits","review_comments_url":"https://api.github.com/repos/dotnet/roslyn/pulls/28253/comments","review_comment_url":"https://api.github.com/repos/dotnet/roslyn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/roslyn/issues/28253/comments","statuses_url":"https://api.github.com/repos/dotnet/roslyn/statuses/63819958f673804fb9d97ad4bedbdc8e1a0f96e6","head":{"label":"333fred:coalesce-bind","ref":"coalesce-bind","sha":"63819958f673804fb9d97ad4bedbdc8e1a0f96e6","user":{"login":"333fred","id":2371880,"node_id":"MDQ6VXNlcjIzNzE4ODA=","avatar_url":"https://avatars0.githubusercontent.com/u/2371880?v=4","gravatar_id":"","url":"https://api.github.com/users/333fred","html_url":"https://github.com/333fred","followers_url":"https://api.github.com/users/333fred/followers","following_url":"https://api.github.com/users/333fred/following{/other_user}","gists_url":"https://api.github.com/users/333fred/gists{/gist_id}","starred_url":"https://api.github.com/users/333fred/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/333fred/subscriptions","organizations_url":"https://api.github.com/users/333fred/orgs","repos_url":"https://api.github.com/users/333fred/repos","events_url":"https://api.github.com/users/333fred/events{/privacy}","received_events_url":"https://api.github.com/users/333fred/received_events","type":"User","site_admin":false},"repo":{"id":70755125,"node_id":"MDEwOlJlcG9zaXRvcnk3MDc1NTEyNQ==","name":"roslyn","full_name":"333fred/roslyn","owner":{"login":"333fred","id":2371880,"node_id":"MDQ6VXNlcjIzNzE4ODA=","avatar_url":"https://avatars0.githubusercontent.com/u/2371880?v=4","gravatar_id":"","url":"https://api.github.com/users/333fred","html_url":"https://github.com/333fred","followers_url":"https://api.github.com/users/333fred/followers","following_url":"https://api.github.com/users/333fred/following{/other_user}","gists_url":"https://api.github.com/users/333fred/gists{/gist_id}","starred_url":"https://api.github.com/users/333fred/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/333fred/subscriptions","organizations_url":"https://api.github.com/users/333fred/orgs","repos_url":"https://api.github.com/users/333fred/repos","events_url":"https://api.github.com/users/333fred/events{/privacy}","received_events_url":"https://api.github.com/users/333fred/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/333fred/roslyn","description":"The .NET Compiler Platform (\"Roslyn\") provides open-source C# and Visual Basic compilers with rich code analysis APIs.","fork":true,"url":"https://api.github.com/repos/333fred/roslyn","forks_url":"https://api.github.com/repos/333fred/roslyn/forks","keys_url":"https://api.github.com/repos/333fred/roslyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/333fred/roslyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/333fred/roslyn/teams","hooks_url":"https://api.github.com/repos/333fred/roslyn/hooks","issue_events_url":"https://api.github.com/repos/333fred/roslyn/issues/events{/number}","events_url":"https://api.github.com/repos/333fred/roslyn/events","assignees_url":"https://api.github.com/repos/333fred/roslyn/assignees{/user}","branches_url":"https://api.github.com/repos/333fred/roslyn/branches{/branch}","tags_url":"https://api.github.com/repos/333fred/roslyn/tags","blobs_url":"https://api.github.com/repos/333fred/roslyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/333fred/roslyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/333fred/roslyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/333fred/roslyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/333fred/roslyn/statuses/{sha}","languages_url":"https://api.github.com/repos/333fred/roslyn/languages","stargazers_url":"https://api.github.com/repos/333fred/roslyn/stargazers","contributors_url":"https://api.github.com/repos/333fred/roslyn/contributors","subscribers_url":"https://api.github.com/repos/333fred/roslyn/subscribers","subscription_url":"https://api.github.com/repos/333fred/roslyn/subscription","commits_url":"https://api.github.com/repos/333fred/roslyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/333fred/roslyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/333fred/roslyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/333fred/roslyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/333fred/roslyn/contents/{+path}","compare_url":"https://api.github.com/repos/333fred/roslyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/333fred/roslyn/merges","archive_url":"https://api.github.com/repos/333fred/roslyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/333fred/roslyn/downloads","issues_url":"https://api.github.com/repos/333fred/roslyn/issues{/number}","pulls_url":"https://api.github.com/repos/333fred/roslyn/pulls{/number}","milestones_url":"https://api.github.com/repos/333fred/roslyn/milestones{/number}","notifications_url":"https://api.github.com/repos/333fred/roslyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/333fred/roslyn/labels{/name}","releases_url":"https://api.github.com/repos/333fred/roslyn/releases{/id}","deployments_url":"https://api.github.com/repos/333fred/roslyn/deployments","created_at":"2016-10-13T01:01:16Z","updated_at":"2018-06-26T20:55:25Z","pushed_at":"2018-07-06T19:57:38Z","git_url":"git://github.com/333fred/roslyn.git","ssh_url":"[email protected]:333fred/roslyn.git","clone_url":"https://github.com/333fred/roslyn.git","svn_url":"https://github.com/333fred/roslyn","homepage":"","size":343671,"stargazers_count":4,"watchers_count":4,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":4,"default_branch":"master"}},"base":{"label":"dotnet:features/null-operator-enhancements","ref":"features/null-operator-enhancements","sha":"596646015f0e596f4b497163759f17fc48ef9988","user":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":29078997,"node_id":"MDEwOlJlcG9zaXRvcnkyOTA3ODk5Nw==","name":"roslyn","full_name":"dotnet/roslyn","owner":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/roslyn","description":"The .NET Compiler Platform (\"Roslyn\") provides open-source C# and Visual Basic compilers with rich code analysis APIs.","fork":false,"url":"https://api.github.com/repos/dotnet/roslyn","forks_url":"https://api.github.com/repos/dotnet/roslyn/forks","keys_url":"https://api.github.com/repos/dotnet/roslyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/roslyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/roslyn/teams","hooks_url":"https://api.github.com/repos/dotnet/roslyn/hooks","issue_events_url":"https://api.github.com/repos/dotnet/roslyn/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/roslyn/events","assignees_url":"https://api.github.com/repos/dotnet/roslyn/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/roslyn/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/roslyn/tags","blobs_url":"https://api.github.com/repos/dotnet/roslyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/roslyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/roslyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/roslyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/roslyn/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/roslyn/languages","stargazers_url":"https://api.github.com/repos/dotnet/roslyn/stargazers","contributors_url":"https://api.github.com/repos/dotnet/roslyn/contributors","subscribers_url":"https://api.github.com/repos/dotnet/roslyn/subscribers","subscription_url":"https://api.github.com/repos/dotnet/roslyn/subscription","commits_url":"https://api.github.com/repos/dotnet/roslyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/roslyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/roslyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/roslyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/roslyn/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/roslyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/roslyn/merges","archive_url":"https://api.github.com/repos/dotnet/roslyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/roslyn/downloads","issues_url":"https://api.github.com/repos/dotnet/roslyn/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/roslyn/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/roslyn/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/roslyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/roslyn/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/roslyn/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/roslyn/deployments","created_at":"2015-01-11T02:39:03Z","updated_at":"2018-07-09T17:48:55Z","pushed_at":"2018-07-09T21:42:50Z","git_url":"git://github.com/dotnet/roslyn.git","ssh_url":"[email protected]:dotnet/roslyn.git","clone_url":"https://github.com/dotnet/roslyn.git","svn_url":"https://github.com/dotnet/roslyn","homepage":"","size":408784,"stargazers_count":9537,"watchers_count":9537,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2277,"mirror_url":null,"archived":false,"open_issues_count":4895,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2277,"open_issues":4895,"watchers":9537,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/28253"},"html":{"href":"https://github.com/dotnet/roslyn/pull/28253"},"issue":{"href":"https://api.github.com/repos/dotnet/roslyn/issues/28253"},"comments":{"href":"https://api.github.com/repos/dotnet/roslyn/issues/28253/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/28253/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/28253/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/roslyn/statuses/63819958f673804fb9d97ad4bedbdc8e1a0f96e6"}},"author_association":"MEMBER"}} | {
"id": 29078997,
"name": "dotnet/roslyn",
"url": "https://api.github.com/repos/dotnet/roslyn"
} | {
"id": 2371880,
"login": "333fred",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2371880?",
"url": "https://api.github.com/users/333fred"
} | {
"id": 9141961,
"login": "dotnet",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9141961?",
"url": "https://api.github.com/orgs/dotnet"
} | 2018-07-09T21:52:01 | 7940299663 | {"actor":{"display_login":"333fred"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/comments/221398532","pull_request_review_id":160045991,"id":221398532,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMTM5ODUzMg==","diff_hunk":"@@ -200,6 +200,38 @@ class C {\n VisualStudio.Editor.Verify.CurrentLineText(\"string str = \\\"Hi Roslyn!\\\"$$\", assertCaretPosition: true);\n }\n \n+ [WpfFact, Trait(Traits.Feature, Traits.Features.AutomaticCompletion)]\n+ public void DoubleQuote_FixedInterpolatedVerbatimString()\n+ {\n+ SetUpEditor(@\"\n+class C\n+{\n+ void M()\n+ {\n+ $$\n+ }\n+}\");\n+\n+ VisualStudio.Editor.SendKeys(\"var v = @$\\\"\");\n+ VisualStudio.Editor.Verify.CurrentLineText(\"var v = $@\\\"$$\\\"\", assertCaretPosition: true);\n+\n+ // Backspace removes quotes\n+ VisualStudio.Editor.SendKeys(VirtualKey.Backspace);\n+ VisualStudio.Editor.Verify.CurrentLineText(\"var v = $@$$\", assertCaretPosition: true);\n+\n+ // Undo puts them back\n+ VisualStudio.Editor.Undo();\n+ VisualStudio.Editor.Verify.CurrentLineText(\"var v = $@\\\"$$\\\"\", assertCaretPosition: true);\n+\n+ // First, the FixInterpolatedVerbatimString action is undone (@$ reordering)\n+ VisualStudio.Editor.Undo();\n+ VisualStudio.Editor.Verify.CurrentLineText(\"var v = @$\\\"$$\\\"\", assertCaretPosition: true);\n+\n+ // Then the automatic quote completion is undone","path":"src/VisualStudio/IntegrationTest/IntegrationTests/CSharp/CSharpAutomaticBraceCompletion.cs","position":31,"original_position":31,"commit_id":"0407e108dcfba01a0d8a9f153188d425cfde73a1","original_commit_id":"bdda19e82ed007d96d4125ce103c6ee88962ffd9","user":{"login":"Neme12","id":11444821,"node_id":"MDQ6VXNlcjExNDQ0ODIx","avatar_url":"https://avatars3.githubusercontent.com/u/11444821?v=4","gravatar_id":"","url":"https://api.github.com/users/Neme12","html_url":"https://github.com/Neme12","followers_url":"https://api.github.com/users/Neme12/followers","following_url":"https://api.github.com/users/Neme12/following{/other_user}","gists_url":"https://api.github.com/users/Neme12/gists{/gist_id}","starred_url":"https://api.github.com/users/Neme12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Neme12/subscriptions","organizations_url":"https://api.github.com/users/Neme12/orgs","repos_url":"https://api.github.com/users/Neme12/repos","events_url":"https://api.github.com/users/Neme12/events{/privacy}","received_events_url":"https://api.github.com/users/Neme12/received_events","type":"User","site_admin":false},"body":"```c#\r\nvar foo = \"\" // delete \"\r\nvar foo = \"\r\nvar foo = @\"\r\nvar foo = $@\"\"\r\n\r\n// undo\r\nvar foo = $@\"\r\nvar foo = @$\"\r\nvar foo = \"\r\n```","created_at":"2018-09-28T22:49:56Z","updated_at":"2018-09-28T22:49:57Z","html_url":"https://github.com/dotnet/roslyn/pull/30074#discussion_r221398532","pull_request_url":"https://api.github.com/repos/dotnet/roslyn/pulls/30074","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/comments/221398532"},"html":{"href":"https://github.com/dotnet/roslyn/pull/30074#discussion_r221398532"},"pull_request":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/30074"}},"in_reply_to_id":221365147},"pull_request":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/30074","id":217083865,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3MDgzODY1","html_url":"https://github.com/dotnet/roslyn/pull/30074","diff_url":"https://github.com/dotnet/roslyn/pull/30074.diff","patch_url":"https://github.com/dotnet/roslyn/pull/30074.patch","issue_url":"https://api.github.com/repos/dotnet/roslyn/issues/30074","number":30074,"state":"open","locked":false,"title":"Command handler to replace `@$\"` with `$@\"` when typing interpolated verbatim string","user":{"login":"Neme12","id":11444821,"node_id":"MDQ6VXNlcjExNDQ0ODIx","avatar_url":"https://avatars3.githubusercontent.com/u/11444821?v=4","gravatar_id":"","url":"https://api.github.com/users/Neme12","html_url":"https://github.com/Neme12","followers_url":"https://api.github.com/users/Neme12/followers","following_url":"https://api.github.com/users/Neme12/following{/other_user}","gists_url":"https://api.github.com/users/Neme12/gists{/gist_id}","starred_url":"https://api.github.com/users/Neme12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Neme12/subscriptions","organizations_url":"https://api.github.com/users/Neme12/orgs","repos_url":"https://api.github.com/users/Neme12/repos","events_url":"https://api.github.com/users/Neme12/events{/privacy}","received_events_url":"https://api.github.com/users/Neme12/received_events","type":"User","site_admin":false},"body":"Fixes #30012\r\nrelates to https://github.com/dotnet/csharplang/issues/1630\r\n\r\nLooks like this:\r\n\r\n\r\nreplacement happens immediately after typing `\"`\r\n\r\ntagging @jcouv @CyrusNajmabadi @sharwell ","created_at":"2018-09-20T19:37:33Z","updated_at":"2018-09-28T22:49:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4e4d833cfe1e7dd06bca7f20513d6941a4db504d","assignee":{"login":"sharwell","id":1408396,"node_id":"MDQ6VXNlcjE0MDgzOTY=","avatar_url":"https://avatars1.githubusercontent.com/u/1408396?v=4","gravatar_id":"","url":"https://api.github.com/users/sharwell","html_url":"https://github.com/sharwell","followers_url":"https://api.github.com/users/sharwell/followers","following_url":"https://api.github.com/users/sharwell/following{/other_user}","gists_url":"https://api.github.com/users/sharwell/gists{/gist_id}","starred_url":"https://api.github.com/users/sharwell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sharwell/subscriptions","organizations_url":"https://api.github.com/users/sharwell/orgs","repos_url":"https://api.github.com/users/sharwell/repos","events_url":"https://api.github.com/users/sharwell/events{/privacy}","received_events_url":"https://api.github.com/users/sharwell/received_events","type":"User","site_admin":false},"assignees":[{"login":"sharwell","id":1408396,"node_id":"MDQ6VXNlcjE0MDgzOTY=","avatar_url":"https://avatars1.githubusercontent.com/u/1408396?v=4","gravatar_id":"","url":"https://api.github.com/users/sharwell","html_url":"https://github.com/sharwell","followers_url":"https://api.github.com/users/sharwell/followers","following_url":"https://api.github.com/users/sharwell/following{/other_user}","gists_url":"https://api.github.com/users/sharwell/gists{/gist_id}","starred_url":"https://api.github.com/users/sharwell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sharwell/subscriptions","organizations_url":"https://api.github.com/users/sharwell/orgs","repos_url":"https://api.github.com/users/sharwell/repos","events_url":"https://api.github.com/users/sharwell/events{/privacy}","received_events_url":"https://api.github.com/users/sharwell/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":166377917,"node_id":"MDU6TGFiZWwxNjYzNzc5MTc=","url":"https://api.github.com/repos/dotnet/roslyn/labels/Area-IDE","name":"Area-IDE","color":"5319e7","default":false},{"id":288147422,"node_id":"MDU6TGFiZWwyODgxNDc0MjI=","url":"https://api.github.com/repos/dotnet/roslyn/labels/Community","name":"Community","color":"0e8a16","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/roslyn/pulls/30074/commits","review_comments_url":"https://api.github.com/repos/dotnet/roslyn/pulls/30074/comments","review_comment_url":"https://api.github.com/repos/dotnet/roslyn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/roslyn/issues/30074/comments","statuses_url":"https://api.github.com/repos/dotnet/roslyn/statuses/0407e108dcfba01a0d8a9f153188d425cfde73a1","head":{"label":"Neme12:fixInterpolatedVerbatimString","ref":"fixInterpolatedVerbatimString","sha":"0407e108dcfba01a0d8a9f153188d425cfde73a1","user":{"login":"Neme12","id":11444821,"node_id":"MDQ6VXNlcjExNDQ0ODIx","avatar_url":"https://avatars3.githubusercontent.com/u/11444821?v=4","gravatar_id":"","url":"https://api.github.com/users/Neme12","html_url":"https://github.com/Neme12","followers_url":"https://api.github.com/users/Neme12/followers","following_url":"https://api.github.com/users/Neme12/following{/other_user}","gists_url":"https://api.github.com/users/Neme12/gists{/gist_id}","starred_url":"https://api.github.com/users/Neme12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Neme12/subscriptions","organizations_url":"https://api.github.com/users/Neme12/orgs","repos_url":"https://api.github.com/users/Neme12/repos","events_url":"https://api.github.com/users/Neme12/events{/privacy}","received_events_url":"https://api.github.com/users/Neme12/received_events","type":"User","site_admin":false},"repo":{"id":119984054,"node_id":"MDEwOlJlcG9zaXRvcnkxMTk5ODQwNTQ=","name":"roslyn","full_name":"Neme12/roslyn","private":false,"owner":{"login":"Neme12","id":11444821,"node_id":"MDQ6VXNlcjExNDQ0ODIx","avatar_url":"https://avatars3.githubusercontent.com/u/11444821?v=4","gravatar_id":"","url":"https://api.github.com/users/Neme12","html_url":"https://github.com/Neme12","followers_url":"https://api.github.com/users/Neme12/followers","following_url":"https://api.github.com/users/Neme12/following{/other_user}","gists_url":"https://api.github.com/users/Neme12/gists{/gist_id}","starred_url":"https://api.github.com/users/Neme12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Neme12/subscriptions","organizations_url":"https://api.github.com/users/Neme12/orgs","repos_url":"https://api.github.com/users/Neme12/repos","events_url":"https://api.github.com/users/Neme12/events{/privacy}","received_events_url":"https://api.github.com/users/Neme12/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Neme12/roslyn","description":"The .NET Compiler Platform (\"Roslyn\") provides open-source C# and Visual Basic compilers with rich code analysis APIs.","fork":true,"url":"https://api.github.com/repos/Neme12/roslyn","forks_url":"https://api.github.com/repos/Neme12/roslyn/forks","keys_url":"https://api.github.com/repos/Neme12/roslyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Neme12/roslyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Neme12/roslyn/teams","hooks_url":"https://api.github.com/repos/Neme12/roslyn/hooks","issue_events_url":"https://api.github.com/repos/Neme12/roslyn/issues/events{/number}","events_url":"https://api.github.com/repos/Neme12/roslyn/events","assignees_url":"https://api.github.com/repos/Neme12/roslyn/assignees{/user}","branches_url":"https://api.github.com/repos/Neme12/roslyn/branches{/branch}","tags_url":"https://api.github.com/repos/Neme12/roslyn/tags","blobs_url":"https://api.github.com/repos/Neme12/roslyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Neme12/roslyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Neme12/roslyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/Neme12/roslyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Neme12/roslyn/statuses/{sha}","languages_url":"https://api.github.com/repos/Neme12/roslyn/languages","stargazers_url":"https://api.github.com/repos/Neme12/roslyn/stargazers","contributors_url":"https://api.github.com/repos/Neme12/roslyn/contributors","subscribers_url":"https://api.github.com/repos/Neme12/roslyn/subscribers","subscription_url":"https://api.github.com/repos/Neme12/roslyn/subscription","commits_url":"https://api.github.com/repos/Neme12/roslyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/Neme12/roslyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/Neme12/roslyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/Neme12/roslyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/Neme12/roslyn/contents/{+path}","compare_url":"https://api.github.com/repos/Neme12/roslyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Neme12/roslyn/merges","archive_url":"https://api.github.com/repos/Neme12/roslyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Neme12/roslyn/downloads","issues_url":"https://api.github.com/repos/Neme12/roslyn/issues{/number}","pulls_url":"https://api.github.com/repos/Neme12/roslyn/pulls{/number}","milestones_url":"https://api.github.com/repos/Neme12/roslyn/milestones{/number}","notifications_url":"https://api.github.com/repos/Neme12/roslyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Neme12/roslyn/labels{/name}","releases_url":"https://api.github.com/repos/Neme12/roslyn/releases{/id}","deployments_url":"https://api.github.com/repos/Neme12/roslyn/deployments","created_at":"2018-02-02T13:20:13Z","updated_at":"2018-09-19T20:02:07Z","pushed_at":"2018-09-28T20:49:31Z","git_url":"git://github.com/Neme12/roslyn.git","ssh_url":"[email protected]:Neme12/roslyn.git","clone_url":"https://github.com/Neme12/roslyn.git","svn_url":"https://github.com/Neme12/roslyn","homepage":"","size":398275,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:dev16.0.x","ref":"dev16.0.x","sha":"54d9c3fbb1fa734bc0cd2494e1012430c1e8e090","user":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":29078997,"node_id":"MDEwOlJlcG9zaXRvcnkyOTA3ODk5Nw==","name":"roslyn","full_name":"dotnet/roslyn","private":false,"owner":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dotnet/roslyn","description":"The .NET Compiler Platform (\"Roslyn\") provides open-source C# and Visual Basic compilers with rich code analysis APIs.","fork":false,"url":"https://api.github.com/repos/dotnet/roslyn","forks_url":"https://api.github.com/repos/dotnet/roslyn/forks","keys_url":"https://api.github.com/repos/dotnet/roslyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/roslyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/roslyn/teams","hooks_url":"https://api.github.com/repos/dotnet/roslyn/hooks","issue_events_url":"https://api.github.com/repos/dotnet/roslyn/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/roslyn/events","assignees_url":"https://api.github.com/repos/dotnet/roslyn/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/roslyn/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/roslyn/tags","blobs_url":"https://api.github.com/repos/dotnet/roslyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/roslyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/roslyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/roslyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/roslyn/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/roslyn/languages","stargazers_url":"https://api.github.com/repos/dotnet/roslyn/stargazers","contributors_url":"https://api.github.com/repos/dotnet/roslyn/contributors","subscribers_url":"https://api.github.com/repos/dotnet/roslyn/subscribers","subscription_url":"https://api.github.com/repos/dotnet/roslyn/subscription","commits_url":"https://api.github.com/repos/dotnet/roslyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/roslyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/roslyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/roslyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/roslyn/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/roslyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/roslyn/merges","archive_url":"https://api.github.com/repos/dotnet/roslyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/roslyn/downloads","issues_url":"https://api.github.com/repos/dotnet/roslyn/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/roslyn/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/roslyn/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/roslyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/roslyn/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/roslyn/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/roslyn/deployments","created_at":"2015-01-11T02:39:03Z","updated_at":"2018-09-28T22:17:52Z","pushed_at":"2018-09-28T22:34:38Z","git_url":"git://github.com/dotnet/roslyn.git","ssh_url":"[email protected]:dotnet/roslyn.git","clone_url":"https://github.com/dotnet/roslyn.git","svn_url":"https://github.com/dotnet/roslyn","homepage":"","size":456841,"stargazers_count":9983,"watchers_count":9983,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2381,"mirror_url":null,"archived":false,"open_issues_count":5267,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2381,"open_issues":5267,"watchers":9983,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/30074"},"html":{"href":"https://github.com/dotnet/roslyn/pull/30074"},"issue":{"href":"https://api.github.com/repos/dotnet/roslyn/issues/30074"},"comments":{"href":"https://api.github.com/repos/dotnet/roslyn/issues/30074/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/30074/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/30074/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/roslyn/statuses/0407e108dcfba01a0d8a9f153188d425cfde73a1"}},"author_association":"CONTRIBUTOR"}} | {
"id": 29078997,
"name": "dotnet/roslyn",
"url": "https://api.github.com/repos/dotnet/roslyn"
} | {
"id": 11444821,
"login": "Neme12",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/11444821?",
"url": "https://api.github.com/users/Neme12"
} | {
"id": 9141961,
"login": "dotnet",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9141961?",
"url": "https://api.github.com/orgs/dotnet"
} | 2018-09-28T22:49:56 | 8340855479 | {"actor":{"display_login":"Neme12"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/orleans/pulls/comments/229056684","pull_request_review_id":169465233,"id":229056684,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyOTA1NjY4NA==","diff_hunk":"@@ -0,0 +1,142 @@\n+---\n+layout: page\n+title: Tutorial 1 Hello World\n+---\n+\n+# Tutorial 1: Hello World\n+\n+This process ties into the Hello World sample application available [here](https://github.com/dotnet/orleans/tree/master/Samples/2.0/HelloWorld).\n+The important concepts to get out of this tutorial are:\n+Orleans is not a single, standalone application that you download and install.\n+Orleans is a collection of separate, configurable projects that use NuGet packages to add Orleans functionality to another application.\n+\n+The main concepts of Orleans involve a silo, a client, and one or more grains.\n+Creating an Orleans app involves configuring the silo, configuring the client, and writing the grains.\n+\n+## Configuring the silo\n+\n+Silos are configured programmatically via `SiloHostBuilder` and a number of supplemental option classes.\n+A list of all of the options can be found [here.](http://dotnet.github.io/orleans/Documentation/clusters_and_clients/configuration_guide/list_of_options_classes.html)\n+\n+```csharp\n+[...]\n+ private static async Task<ISiloHost> StartSilo()\n+ {\n+ // define the cluster configuration\n+ var builder = new SiloHostBuilder()\n+ .UseLocalhostClustering()\n+ .Configure<ClusterOptions>(options =>\n+ {\n+ options.ClusterId = \"dev\";\n+ options.ServiceId = \"HelloWorldApp\";\n+ })\n+ .Configure<EndpointOptions>(options => options.AdvertisedIPAddress = IPAddress.Loopback)\n+ .ConfigureApplicationParts(parts => parts.AddApplicationPart(typeof(HelloGrain).Assembly).WithReferences())\n+ .ConfigureLogging(logging => logging.AddConsole());\n+\n+ var host = builder.Build();\n+ await host.StartAsync();\n+ return host;\n+ }\n+```\n+\n+| Option | Used for |\n+|-------------|----------|\n+| `.UseLocalhostClustering()` | Declaring that we are using a single local silo |\n+| `ClusterOptions` | ClusterId is the name for the Orleans cluster must be the same for silo and client so they can talk to each other. ServiceId is the ID used for the application and it must not change across deployments|\n+| `EndpointOptions` | This tells the silo where to listen. For this example, we are using a `loopback`. |\n+| `ConfigureApplicationParts` | Adds the assembly with grain classes to the application setup. |","path":"src/Documentation/tutorials_and_samples/tutorial_1_helloworld.md","position":45,"original_position":48,"commit_id":"a121e4ee498403b7b8a5295584fd0f81fdc91192","original_commit_id":"91e8606b17c2a34245c885529c17336446265b35","user":{"login":"JillHeaden","id":39530834,"node_id":"MDQ6VXNlcjM5NTMwODM0","avatar_url":"https://avatars1.githubusercontent.com/u/39530834?v=4","gravatar_id":"","url":"https://api.github.com/users/JillHeaden","html_url":"https://github.com/JillHeaden","followers_url":"https://api.github.com/users/JillHeaden/followers","following_url":"https://api.github.com/users/JillHeaden/following{/other_user}","gists_url":"https://api.github.com/users/JillHeaden/gists{/gist_id}","starred_url":"https://api.github.com/users/JillHeaden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JillHeaden/subscriptions","organizations_url":"https://api.github.com/users/JillHeaden/orgs","repos_url":"https://api.github.com/users/JillHeaden/repos","events_url":"https://api.github.com/users/JillHeaden/events{/privacy}","received_events_url":"https://api.github.com/users/JillHeaden/received_events","type":"User","site_admin":false},"body":"I may need some clarification about this. ","created_at":"2018-10-29T18:56:10Z","updated_at":"2018-10-29T18:56:10Z","html_url":"https://github.com/dotnet/orleans/pull/5102#discussion_r229056684","pull_request_url":"https://api.github.com/repos/dotnet/orleans/pulls/5102","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/dotnet/orleans/pulls/comments/229056684"},"html":{"href":"https://github.com/dotnet/orleans/pull/5102#discussion_r229056684"},"pull_request":{"href":"https://api.github.com/repos/dotnet/orleans/pulls/5102"}},"in_reply_to_id":228348414},"pull_request":{"url":"https://api.github.com/repos/dotnet/orleans/pulls/5102","id":223725071,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIzNzI1MDcx","html_url":"https://github.com/dotnet/orleans/pull/5102","diff_url":"https://github.com/dotnet/orleans/pull/5102.diff","patch_url":"https://github.com/dotnet/orleans/pull/5102.patch","issue_url":"https://api.github.com/repos/dotnet/orleans/issues/5102","number":5102,"state":"open","locked":false,"title":"Tutorial 1 for Orleans 2.0","user":{"login":"JillHeaden","id":39530834,"node_id":"MDQ6VXNlcjM5NTMwODM0","avatar_url":"https://avatars1.githubusercontent.com/u/39530834?v=4","gravatar_id":"","url":"https://api.github.com/users/JillHeaden","html_url":"https://github.com/JillHeaden","followers_url":"https://api.github.com/users/JillHeaden/followers","following_url":"https://api.github.com/users/JillHeaden/following{/other_user}","gists_url":"https://api.github.com/users/JillHeaden/gists{/gist_id}","starred_url":"https://api.github.com/users/JillHeaden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JillHeaden/subscriptions","organizations_url":"https://api.github.com/users/JillHeaden/orgs","repos_url":"https://api.github.com/users/JillHeaden/repos","events_url":"https://api.github.com/users/JillHeaden/events{/privacy}","received_events_url":"https://api.github.com/users/JillHeaden/received_events","type":"User","site_admin":false},"body":"This tutorial ties in with the Hello World sample. ","created_at":"2018-10-17T19:23:43Z","updated_at":"2018-10-29T18:56:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"29c9adb8d0dcc4486b8e8be69b18552652740e7a","assignee":{"login":"xiazen","id":20803801,"node_id":"MDQ6VXNlcjIwODAzODAx","avatar_url":"https://avatars3.githubusercontent.com/u/20803801?v=4","gravatar_id":"","url":"https://api.github.com/users/xiazen","html_url":"https://github.com/xiazen","followers_url":"https://api.github.com/users/xiazen/followers","following_url":"https://api.github.com/users/xiazen/following{/other_user}","gists_url":"https://api.github.com/users/xiazen/gists{/gist_id}","starred_url":"https://api.github.com/users/xiazen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xiazen/subscriptions","organizations_url":"https://api.github.com/users/xiazen/orgs","repos_url":"https://api.github.com/users/xiazen/repos","events_url":"https://api.github.com/users/xiazen/events{/privacy}","received_events_url":"https://api.github.com/users/xiazen/received_events","type":"User","site_admin":false},"assignees":[{"login":"xiazen","id":20803801,"node_id":"MDQ6VXNlcjIwODAzODAx","avatar_url":"https://avatars3.githubusercontent.com/u/20803801?v=4","gravatar_id":"","url":"https://api.github.com/users/xiazen","html_url":"https://github.com/xiazen","followers_url":"https://api.github.com/users/xiazen/followers","following_url":"https://api.github.com/users/xiazen/following{/other_user}","gists_url":"https://api.github.com/users/xiazen/gists{/gist_id}","starred_url":"https://api.github.com/users/xiazen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xiazen/subscriptions","organizations_url":"https://api.github.com/users/xiazen/orgs","repos_url":"https://api.github.com/users/xiazen/repos","events_url":"https://api.github.com/users/xiazen/events{/privacy}","received_events_url":"https://api.github.com/users/xiazen/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/orleans/pulls/5102/commits","review_comments_url":"https://api.github.com/repos/dotnet/orleans/pulls/5102/comments","review_comment_url":"https://api.github.com/repos/dotnet/orleans/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/orleans/issues/5102/comments","statuses_url":"https://api.github.com/repos/dotnet/orleans/statuses/a121e4ee498403b7b8a5295584fd0f81fdc91192","head":{"label":"JillHeaden:create_tutorial_1_helloworld","ref":"create_tutorial_1_helloworld","sha":"a121e4ee498403b7b8a5295584fd0f81fdc91192","user":{"login":"JillHeaden","id":39530834,"node_id":"MDQ6VXNlcjM5NTMwODM0","avatar_url":"https://avatars1.githubusercontent.com/u/39530834?v=4","gravatar_id":"","url":"https://api.github.com/users/JillHeaden","html_url":"https://github.com/JillHeaden","followers_url":"https://api.github.com/users/JillHeaden/followers","following_url":"https://api.github.com/users/JillHeaden/following{/other_user}","gists_url":"https://api.github.com/users/JillHeaden/gists{/gist_id}","starred_url":"https://api.github.com/users/JillHeaden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JillHeaden/subscriptions","organizations_url":"https://api.github.com/users/JillHeaden/orgs","repos_url":"https://api.github.com/users/JillHeaden/repos","events_url":"https://api.github.com/users/JillHeaden/events{/privacy}","received_events_url":"https://api.github.com/users/JillHeaden/received_events","type":"User","site_admin":false},"repo":{"id":135618100,"node_id":"MDEwOlJlcG9zaXRvcnkxMzU2MTgxMDA=","name":"orleans","full_name":"JillHeaden/orleans","private":false,"owner":{"login":"JillHeaden","id":39530834,"node_id":"MDQ6VXNlcjM5NTMwODM0","avatar_url":"https://avatars1.githubusercontent.com/u/39530834?v=4","gravatar_id":"","url":"https://api.github.com/users/JillHeaden","html_url":"https://github.com/JillHeaden","followers_url":"https://api.github.com/users/JillHeaden/followers","following_url":"https://api.github.com/users/JillHeaden/following{/other_user}","gists_url":"https://api.github.com/users/JillHeaden/gists{/gist_id}","starred_url":"https://api.github.com/users/JillHeaden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JillHeaden/subscriptions","organizations_url":"https://api.github.com/users/JillHeaden/orgs","repos_url":"https://api.github.com/users/JillHeaden/repos","events_url":"https://api.github.com/users/JillHeaden/events{/privacy}","received_events_url":"https://api.github.com/users/JillHeaden/received_events","type":"User","site_admin":false},"html_url":"https://github.com/JillHeaden/orleans","description":"Orleans - Distributed Virtual Actor Model","fork":true,"url":"https://api.github.com/repos/JillHeaden/orleans","forks_url":"https://api.github.com/repos/JillHeaden/orleans/forks","keys_url":"https://api.github.com/repos/JillHeaden/orleans/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JillHeaden/orleans/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JillHeaden/orleans/teams","hooks_url":"https://api.github.com/repos/JillHeaden/orleans/hooks","issue_events_url":"https://api.github.com/repos/JillHeaden/orleans/issues/events{/number}","events_url":"https://api.github.com/repos/JillHeaden/orleans/events","assignees_url":"https://api.github.com/repos/JillHeaden/orleans/assignees{/user}","branches_url":"https://api.github.com/repos/JillHeaden/orleans/branches{/branch}","tags_url":"https://api.github.com/repos/JillHeaden/orleans/tags","blobs_url":"https://api.github.com/repos/JillHeaden/orleans/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JillHeaden/orleans/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JillHeaden/orleans/git/refs{/sha}","trees_url":"https://api.github.com/repos/JillHeaden/orleans/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JillHeaden/orleans/statuses/{sha}","languages_url":"https://api.github.com/repos/JillHeaden/orleans/languages","stargazers_url":"https://api.github.com/repos/JillHeaden/orleans/stargazers","contributors_url":"https://api.github.com/repos/JillHeaden/orleans/contributors","subscribers_url":"https://api.github.com/repos/JillHeaden/orleans/subscribers","subscription_url":"https://api.github.com/repos/JillHeaden/orleans/subscription","commits_url":"https://api.github.com/repos/JillHeaden/orleans/commits{/sha}","git_commits_url":"https://api.github.com/repos/JillHeaden/orleans/git/commits{/sha}","comments_url":"https://api.github.com/repos/JillHeaden/orleans/comments{/number}","issue_comment_url":"https://api.github.com/repos/JillHeaden/orleans/issues/comments{/number}","contents_url":"https://api.github.com/repos/JillHeaden/orleans/contents/{+path}","compare_url":"https://api.github.com/repos/JillHeaden/orleans/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JillHeaden/orleans/merges","archive_url":"https://api.github.com/repos/JillHeaden/orleans/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JillHeaden/orleans/downloads","issues_url":"https://api.github.com/repos/JillHeaden/orleans/issues{/number}","pulls_url":"https://api.github.com/repos/JillHeaden/orleans/pulls{/number}","milestones_url":"https://api.github.com/repos/JillHeaden/orleans/milestones{/number}","notifications_url":"https://api.github.com/repos/JillHeaden/orleans/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JillHeaden/orleans/labels{/name}","releases_url":"https://api.github.com/repos/JillHeaden/orleans/releases{/id}","deployments_url":"https://api.github.com/repos/JillHeaden/orleans/deployments","created_at":"2018-05-31T17:56:36Z","updated_at":"2018-08-03T17:29:17Z","pushed_at":"2018-10-29T13:42:33Z","git_url":"git://github.com/JillHeaden/orleans.git","ssh_url":"[email protected]:JillHeaden/orleans.git","clone_url":"https://github.com/JillHeaden/orleans.git","svn_url":"https://github.com/JillHeaden/orleans","homepage":"http://dotnet.github.io/orleans","size":114295,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:docs","ref":"docs","sha":"32bc0a96a5f073ead98febae15413bcdba3f88d1","user":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":28232663,"node_id":"MDEwOlJlcG9zaXRvcnkyODIzMjY2Mw==","name":"orleans","full_name":"dotnet/orleans","private":false,"owner":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dotnet/orleans","description":"Orleans - Distributed Virtual Actor Model","fork":false,"url":"https://api.github.com/repos/dotnet/orleans","forks_url":"https://api.github.com/repos/dotnet/orleans/forks","keys_url":"https://api.github.com/repos/dotnet/orleans/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/orleans/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/orleans/teams","hooks_url":"https://api.github.com/repos/dotnet/orleans/hooks","issue_events_url":"https://api.github.com/repos/dotnet/orleans/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/orleans/events","assignees_url":"https://api.github.com/repos/dotnet/orleans/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/orleans/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/orleans/tags","blobs_url":"https://api.github.com/repos/dotnet/orleans/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/orleans/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/orleans/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/orleans/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/orleans/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/orleans/languages","stargazers_url":"https://api.github.com/repos/dotnet/orleans/stargazers","contributors_url":"https://api.github.com/repos/dotnet/orleans/contributors","subscribers_url":"https://api.github.com/repos/dotnet/orleans/subscribers","subscription_url":"https://api.github.com/repos/dotnet/orleans/subscription","commits_url":"https://api.github.com/repos/dotnet/orleans/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/orleans/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/orleans/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/orleans/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/orleans/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/orleans/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/orleans/merges","archive_url":"https://api.github.com/repos/dotnet/orleans/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/orleans/downloads","issues_url":"https://api.github.com/repos/dotnet/orleans/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/orleans/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/orleans/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/orleans/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/orleans/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/orleans/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/orleans/deployments","created_at":"2014-12-19T14:32:50Z","updated_at":"2018-10-29T10:27:32Z","pushed_at":"2018-10-29T18:13:13Z","git_url":"git://github.com/dotnet/orleans.git","ssh_url":"[email protected]:dotnet/orleans.git","clone_url":"https://github.com/dotnet/orleans.git","svn_url":"https://github.com/dotnet/orleans","homepage":"http://dotnet.github.io/orleans","size":51069,"stargazers_count":4391,"watchers_count":4391,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":1100,"mirror_url":null,"archived":false,"open_issues_count":415,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1100,"open_issues":415,"watchers":4391,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/orleans/pulls/5102"},"html":{"href":"https://github.com/dotnet/orleans/pull/5102"},"issue":{"href":"https://api.github.com/repos/dotnet/orleans/issues/5102"},"comments":{"href":"https://api.github.com/repos/dotnet/orleans/issues/5102/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/orleans/pulls/5102/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/orleans/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/orleans/pulls/5102/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/orleans/statuses/a121e4ee498403b7b8a5295584fd0f81fdc91192"}},"author_association":"COLLABORATOR"}} | {
"id": 28232663,
"name": "dotnet/orleans",
"url": "https://api.github.com/repos/dotnet/orleans"
} | {
"id": 39530834,
"login": "JillHeaden",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/39530834?",
"url": "https://api.github.com/users/JillHeaden"
} | {
"id": 9141961,
"login": "dotnet",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9141961?",
"url": "https://api.github.com/orgs/dotnet"
} | 2018-10-29T18:56:10 | 8500112529 | {"actor":{"display_login":"JillHeaden"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/docs/pulls/comments/237698822","pull_request_review_id":180054101,"id":237698822,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNzY5ODgyMg==","diff_hunk":"@@ -0,0 +1,180 @@\n+---\n+title: Build ASP.NET Core 2.1 applications deployed as Linux containers into AKS/Kubernetes clusters\n+description: Containerized Docker Application Lifecycle with Microsoft Platform and Tools\n+author: CESARDELATORRE\n+ms.author: wiwagn\n+ms.date: 11/23/2018\n+---\n+# Build ASP.NET Core 2.1 applications deployed as Linux containers into AKS/Kubernetes orchestrator\n+\n+Azure Kubernetes Services (AKS) is Azure's managed Kubernetes orchestrations services that simplify container deployment and management.\n+\n+AKS main features are, an Azure-hosted control plane, automated upgrades, self-healing, user configurable scaling, and a simpler user experience for both developers and cluster operators.\n+\n+In the following examples we'll explore the creation of an ASP.NET Core 2.1 application, using Visual Studio 2017 that runs on Linux and deploys to an AKS Cluster in Azure.\n+\n+## Creating the ASP.NET Core 2.1 Project using Visual Studio 2017\n+\n+ASP.NET Core is a general-purpose development platform maintained by Microsoft and the .NET community on GitHub. It is cross-platform, supporting Windows, macOS and Linux, and can be used in device, cloud, and embedded/IoT scenarios.\n+\n+For this example, we use a simple project based on a Visual Studio Web API template, so you don't need any additional knowledge to create the sample, you only have to create the project using a standard template that includes all the elements to run a small project with a REST API, using ASP.NET Core 2.1 technology.\n+\n+\n+\n+**Figure 4-36**. Creating ASP.NET Core Application\n+\n+To create the sample project, you have to select **New > Project** on Visual Studio and ASP.NET Core Web Application\n+\n+Visual Studio will show a list with Templates for Web Projects. For our example you must select **Web API,** that means you will create an ASP.NET Web API Application.\n+\n+Verify that you have selected ASP.NET Core 2.1 as the framework. The .NET Core 2.1 is included in the last version of Visual Studio 2017 and is automatically installed and configured for you when you install Visual Studio 2017.\n+\n+\n+\n+**Figure 4-37**. Selecting ASP.NET CORE 2.1 and Web API project type\n+\n+If you have any previous version of .NET Core, you can download and install the 2.1 version from [https://www.microsoft.com/net/download/core#/sdk](https://www.microsoft.com/net/download/core#/sdk)\n+\n+You can add Docker support when creating the project in the previous step, or later, so you can \"Dockerize\" your project any time. To add the Docker support after the project creation, right-click on the solution file and select **Add > Docker support** on the context menu.\n+\n+","path":"docs/standard/containerized-lifecycle-architecture/design-develop-containerized-apps/build-aspnet-core-2.1-applications-linux-containers-aks-kubernetes.md","position":40,"original_position":40,"commit_id":"5cf701c42825396d5a611720992489b84cc15ea2","original_commit_id":"5cf701c42825396d5a611720992489b84cc15ea2","user":{"login":"mairaw","id":12971179,"node_id":"MDQ6VXNlcjEyOTcxMTc5","avatar_url":"https://avatars2.githubusercontent.com/u/12971179?v=4","gravatar_id":"","url":"https://api.github.com/users/mairaw","html_url":"https://github.com/mairaw","followers_url":"https://api.github.com/users/mairaw/followers","following_url":"https://api.github.com/users/mairaw/following{/other_user}","gists_url":"https://api.github.com/users/mairaw/gists{/gist_id}","starred_url":"https://api.github.com/users/mairaw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mairaw/subscriptions","organizations_url":"https://api.github.com/users/mairaw/orgs","repos_url":"https://api.github.com/users/mairaw/repos","events_url":"https://api.github.com/users/mairaw/events{/privacy}","received_events_url":"https://api.github.com/users/mairaw/received_events","type":"User","site_admin":false},"body":"a existing -> an existing","created_at":"2018-11-29T23:29:49Z","updated_at":"2018-11-29T23:47:35Z","html_url":"https://github.com/dotnet/docs/pull/9305#discussion_r237698822","pull_request_url":"https://api.github.com/repos/dotnet/docs/pulls/9305","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/dotnet/docs/pulls/comments/237698822"},"html":{"href":"https://github.com/dotnet/docs/pull/9305#discussion_r237698822"},"pull_request":{"href":"https://api.github.com/repos/dotnet/docs/pulls/9305"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/docs/pulls/9305","id":234710765,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM0NzEwNzY1","html_url":"https://github.com/dotnet/docs/pull/9305","diff_url":"https://github.com/dotnet/docs/pull/9305.diff","patch_url":"https://github.com/dotnet/docs/pull/9305.patch","issue_url":"https://api.github.com/repos/dotnet/docs/issues/9305","number":9305,"state":"open","locked":false,"title":"Containerized Docker Application Lifecycle - 00 - General Structure","user":{"login":"mvelosop","id":7357806,"node_id":"MDQ6VXNlcjczNTc4MDY=","avatar_url":"https://avatars2.githubusercontent.com/u/7357806?v=4","gravatar_id":"","url":"https://api.github.com/users/mvelosop","html_url":"https://github.com/mvelosop","followers_url":"https://api.github.com/users/mvelosop/followers","following_url":"https://api.github.com/users/mvelosop/following{/other_user}","gists_url":"https://api.github.com/users/mvelosop/gists{/gist_id}","starred_url":"https://api.github.com/users/mvelosop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mvelosop/subscriptions","organizations_url":"https://api.github.com/users/mvelosop/orgs","repos_url":"https://api.github.com/users/mvelosop/repos","events_url":"https://api.github.com/users/mvelosop/events{/privacy}","received_events_url":"https://api.github.com/users/mvelosop/received_events","type":"User","site_admin":false},"body":"## Summary\r\n\r\n### e-book <--> docs.microsoft.com synchronization\r\n- TOC\r\n- New files\r\n- Article navigation\r\n- Metadata\r\n\r\n","created_at":"2018-11-29T16:49:54Z","updated_at":"2018-11-29T23:47:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a7b32c9503329c694da29e1388a5bf0cb0675df1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/docs/pulls/9305/commits","review_comments_url":"https://api.github.com/repos/dotnet/docs/pulls/9305/comments","review_comment_url":"https://api.github.com/repos/dotnet/docs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/docs/issues/9305/comments","statuses_url":"https://api.github.com/repos/dotnet/docs/statuses/5cf701c42825396d5a611720992489b84cc15ea2","head":{"label":"dotnet-architecture:docker-lifecycle/00-toc-new-files-navigation-metadata","ref":"docker-lifecycle/00-toc-new-files-navigation-metadata","sha":"5cf701c42825396d5a611720992489b84cc15ea2","user":{"login":"dotnet-architecture","id":27453006,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3NDUzMDA2","avatar_url":"https://avatars2.githubusercontent.com/u/27453006?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet-architecture","html_url":"https://github.com/dotnet-architecture","followers_url":"https://api.github.com/users/dotnet-architecture/followers","following_url":"https://api.github.com/users/dotnet-architecture/following{/other_user}","gists_url":"https://api.github.com/users/dotnet-architecture/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet-architecture/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet-architecture/subscriptions","organizations_url":"https://api.github.com/users/dotnet-architecture/orgs","repos_url":"https://api.github.com/users/dotnet-architecture/repos","events_url":"https://api.github.com/users/dotnet-architecture/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet-architecture/received_events","type":"Organization","site_admin":false},"repo":{"id":131441034,"node_id":"MDEwOlJlcG9zaXRvcnkxMzE0NDEwMzQ=","name":"docs","full_name":"dotnet-architecture/docs","private":false,"owner":{"login":"dotnet-architecture","id":27453006,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3NDUzMDA2","avatar_url":"https://avatars2.githubusercontent.com/u/27453006?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet-architecture","html_url":"https://github.com/dotnet-architecture","followers_url":"https://api.github.com/users/dotnet-architecture/followers","following_url":"https://api.github.com/users/dotnet-architecture/following{/other_user}","gists_url":"https://api.github.com/users/dotnet-architecture/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet-architecture/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet-architecture/subscriptions","organizations_url":"https://api.github.com/users/dotnet-architecture/orgs","repos_url":"https://api.github.com/users/dotnet-architecture/repos","events_url":"https://api.github.com/users/dotnet-architecture/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet-architecture/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dotnet-architecture/docs","description":"This repository contains .NET Documentation.","fork":true,"url":"https://api.github.com/repos/dotnet-architecture/docs","forks_url":"https://api.github.com/repos/dotnet-architecture/docs/forks","keys_url":"https://api.github.com/repos/dotnet-architecture/docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet-architecture/docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet-architecture/docs/teams","hooks_url":"https://api.github.com/repos/dotnet-architecture/docs/hooks","issue_events_url":"https://api.github.com/repos/dotnet-architecture/docs/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet-architecture/docs/events","assignees_url":"https://api.github.com/repos/dotnet-architecture/docs/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet-architecture/docs/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet-architecture/docs/tags","blobs_url":"https://api.github.com/repos/dotnet-architecture/docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet-architecture/docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet-architecture/docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet-architecture/docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet-architecture/docs/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet-architecture/docs/languages","stargazers_url":"https://api.github.com/repos/dotnet-architecture/docs/stargazers","contributors_url":"https://api.github.com/repos/dotnet-architecture/docs/contributors","subscribers_url":"https://api.github.com/repos/dotnet-architecture/docs/subscribers","subscription_url":"https://api.github.com/repos/dotnet-architecture/docs/subscription","commits_url":"https://api.github.com/repos/dotnet-architecture/docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet-architecture/docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet-architecture/docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet-architecture/docs/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet-architecture/docs/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet-architecture/docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet-architecture/docs/merges","archive_url":"https://api.github.com/repos/dotnet-architecture/docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet-architecture/docs/downloads","issues_url":"https://api.github.com/repos/dotnet-architecture/docs/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet-architecture/docs/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet-architecture/docs/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet-architecture/docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet-architecture/docs/labels{/name}","releases_url":"https://api.github.com/repos/dotnet-architecture/docs/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet-architecture/docs/deployments","created_at":"2018-04-28T20:13:30Z","updated_at":"2018-11-29T14:17:58Z","pushed_at":"2018-11-29T21:00:06Z","git_url":"git://github.com/dotnet-architecture/docs.git","ssh_url":"[email protected]:dotnet-architecture/docs.git","clone_url":"https://github.com/dotnet-architecture/docs.git","svn_url":"https://github.com/dotnet-architecture/docs","homepage":"https://docs.microsoft.com/dotnet","size":552073,"stargazers_count":6,"watchers_count":6,"language":"PowerShell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":4,"open_issues":0,"watchers":6,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"540e9234073e73a0e2e1c31bedb74935f31a2dcb","user":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":35890081,"node_id":"MDEwOlJlcG9zaXRvcnkzNTg5MDA4MQ==","name":"docs","full_name":"dotnet/docs","private":false,"owner":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dotnet/docs","description":"This repository contains .NET Documentation.","fork":false,"url":"https://api.github.com/repos/dotnet/docs","forks_url":"https://api.github.com/repos/dotnet/docs/forks","keys_url":"https://api.github.com/repos/dotnet/docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/docs/teams","hooks_url":"https://api.github.com/repos/dotnet/docs/hooks","issue_events_url":"https://api.github.com/repos/dotnet/docs/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/docs/events","assignees_url":"https://api.github.com/repos/dotnet/docs/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/docs/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/docs/tags","blobs_url":"https://api.github.com/repos/dotnet/docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/docs/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/docs/languages","stargazers_url":"https://api.github.com/repos/dotnet/docs/stargazers","contributors_url":"https://api.github.com/repos/dotnet/docs/contributors","subscribers_url":"https://api.github.com/repos/dotnet/docs/subscribers","subscription_url":"https://api.github.com/repos/dotnet/docs/subscription","commits_url":"https://api.github.com/repos/dotnet/docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/docs/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/docs/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/docs/merges","archive_url":"https://api.github.com/repos/dotnet/docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/docs/downloads","issues_url":"https://api.github.com/repos/dotnet/docs/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/docs/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/docs/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/docs/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/docs/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/docs/deployments","created_at":"2015-05-19T15:13:32Z","updated_at":"2018-11-29T20:55:29Z","pushed_at":"2018-11-29T22:55:25Z","git_url":"git://github.com/dotnet/docs.git","ssh_url":"[email protected]:dotnet/docs.git","clone_url":"https://github.com/dotnet/docs.git","svn_url":"https://github.com/dotnet/docs","homepage":"https://docs.microsoft.com/dotnet","size":512176,"stargazers_count":1458,"watchers_count":1458,"language":"PowerShell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2959,"mirror_url":null,"archived":false,"open_issues_count":975,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2959,"open_issues":975,"watchers":1458,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/docs/pulls/9305"},"html":{"href":"https://github.com/dotnet/docs/pull/9305"},"issue":{"href":"https://api.github.com/repos/dotnet/docs/issues/9305"},"comments":{"href":"https://api.github.com/repos/dotnet/docs/issues/9305/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/docs/pulls/9305/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/docs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/docs/pulls/9305/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/docs/statuses/5cf701c42825396d5a611720992489b84cc15ea2"}},"author_association":"COLLABORATOR"}} | {
"id": 35890081,
"name": "dotnet/docs",
"url": "https://api.github.com/repos/dotnet/docs"
} | {
"id": 12971179,
"login": "mairaw",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/12971179?",
"url": "https://api.github.com/users/mairaw"
} | {
"id": 9141961,
"login": "dotnet",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9141961?",
"url": "https://api.github.com/orgs/dotnet"
} | 2018-11-29T23:29:49 | 8672888215 | {"actor":{"display_login":"mairaw"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/machinelearning/pulls/comments/237264904","pull_request_review_id":179522239,"id":237264904,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNzI2NDkwNA==","diff_hunk":"@@ -77,6 +77,8 @@ private static VersionInfo GetVersionInfo()\n \n public override Schema Schema => _bindings.Schema;\n \n+ public Schema OutputSchema => Schema;","path":"src/Microsoft.ML.Data/DataView/RowToRowMapperTransform.cs","position":4,"original_position":4,"commit_id":"e962dd6a89363b153de2212b53655a5f2e8f536f","original_commit_id":"e962dd6a89363b153de2212b53655a5f2e8f536f","user":{"login":"Ivanidzo4ka","id":1523833,"node_id":"MDQ6VXNlcjE1MjM4MzM=","avatar_url":"https://avatars3.githubusercontent.com/u/1523833?v=4","gravatar_id":"","url":"https://api.github.com/users/Ivanidzo4ka","html_url":"https://github.com/Ivanidzo4ka","followers_url":"https://api.github.com/users/Ivanidzo4ka/followers","following_url":"https://api.github.com/users/Ivanidzo4ka/following{/other_user}","gists_url":"https://api.github.com/users/Ivanidzo4ka/gists{/gist_id}","starred_url":"https://api.github.com/users/Ivanidzo4ka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ivanidzo4ka/subscriptions","organizations_url":"https://api.github.com/users/Ivanidzo4ka/orgs","repos_url":"https://api.github.com/users/Ivanidzo4ka/repos","events_url":"https://api.github.com/users/Ivanidzo4ka/events{/privacy}","received_events_url":"https://api.github.com/users/Ivanidzo4ka/received_events","type":"User","site_admin":false},"body":">Schema [](start = 38, length = 6)\r\n\r\n_binding.Schema?\r\nAlso I think this is indication of what something went wrong.\r\nIt work before without defining two schemas, right?\r\nYou move schema around and now you need to have two of them.\r\nMaybe that `public override Schema Schema => _bindings.Schema;` should be renamed to OutputSchema?\r\n","created_at":"2018-11-28T21:20:16Z","updated_at":"2018-11-28T21:20:16Z","html_url":"https://github.com/dotnet/machinelearning/pull/1759#discussion_r237264904","pull_request_url":"https://api.github.com/repos/dotnet/machinelearning/pulls/1759","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/dotnet/machinelearning/pulls/comments/237264904"},"html":{"href":"https://github.com/dotnet/machinelearning/pull/1759#discussion_r237264904"},"pull_request":{"href":"https://api.github.com/repos/dotnet/machinelearning/pulls/1759"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/machinelearning/pulls/1759","id":234418974,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM0NDE4OTc0","html_url":"https://github.com/dotnet/machinelearning/pull/1759","diff_url":"https://github.com/dotnet/machinelearning/pull/1759.diff","patch_url":"https://github.com/dotnet/machinelearning/pull/1759.patch","issue_url":"https://api.github.com/repos/dotnet/machinelearning/issues/1759","number":1759,"state":"open","locked":false,"title":"Remove ISchematized interface from the codebase.","user":{"login":"wschin","id":3524474,"node_id":"MDQ6VXNlcjM1MjQ0NzQ=","avatar_url":"https://avatars1.githubusercontent.com/u/3524474?v=4","gravatar_id":"","url":"https://api.github.com/users/wschin","html_url":"https://github.com/wschin","followers_url":"https://api.github.com/users/wschin/followers","following_url":"https://api.github.com/users/wschin/following{/other_user}","gists_url":"https://api.github.com/users/wschin/gists{/gist_id}","starred_url":"https://api.github.com/users/wschin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wschin/subscriptions","organizations_url":"https://api.github.com/users/wschin/orgs","repos_url":"https://api.github.com/users/wschin/repos","events_url":"https://api.github.com/users/wschin/events{/privacy}","received_events_url":"https://api.github.com/users/wschin/received_events","type":"User","site_admin":false},"body":"1. Remove ISchematized\r\n2. For any class that requires a Schema, we add a Schema as its field\r\n3. Rename Schema to OutputSchema in IRowToRowMapper\r\n\r\nFixes #1502.","created_at":"2018-11-28T20:48:23Z","updated_at":"2018-11-28T21:20:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fc196abaee4b35562918fafb5fa8c6e5f77628e2","assignee":null,"assignees":[],"requested_reviewers":[{"login":"TomFinley","id":8295757,"node_id":"MDQ6VXNlcjgyOTU3NTc=","avatar_url":"https://avatars1.githubusercontent.com/u/8295757?v=4","gravatar_id":"","url":"https://api.github.com/users/TomFinley","html_url":"https://github.com/TomFinley","followers_url":"https://api.github.com/users/TomFinley/followers","following_url":"https://api.github.com/users/TomFinley/following{/other_user}","gists_url":"https://api.github.com/users/TomFinley/gists{/gist_id}","starred_url":"https://api.github.com/users/TomFinley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TomFinley/subscriptions","organizations_url":"https://api.github.com/users/TomFinley/orgs","repos_url":"https://api.github.com/users/TomFinley/repos","events_url":"https://api.github.com/users/TomFinley/events{/privacy}","received_events_url":"https://api.github.com/users/TomFinley/received_events","type":"User","site_admin":false},{"login":"sfilipi","id":19392467,"node_id":"MDQ6VXNlcjE5MzkyNDY3","avatar_url":"https://avatars1.githubusercontent.com/u/19392467?v=4","gravatar_id":"","url":"https://api.github.com/users/sfilipi","html_url":"https://github.com/sfilipi","followers_url":"https://api.github.com/users/sfilipi/followers","following_url":"https://api.github.com/users/sfilipi/following{/other_user}","gists_url":"https://api.github.com/users/sfilipi/gists{/gist_id}","starred_url":"https://api.github.com/users/sfilipi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sfilipi/subscriptions","organizations_url":"https://api.github.com/users/sfilipi/orgs","repos_url":"https://api.github.com/users/sfilipi/repos","events_url":"https://api.github.com/users/sfilipi/events{/privacy}","received_events_url":"https://api.github.com/users/sfilipi/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/machinelearning/pulls/1759/commits","review_comments_url":"https://api.github.com/repos/dotnet/machinelearning/pulls/1759/comments","review_comment_url":"https://api.github.com/repos/dotnet/machinelearning/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/machinelearning/issues/1759/comments","statuses_url":"https://api.github.com/repos/dotnet/machinelearning/statuses/e962dd6a89363b153de2212b53655a5f2e8f536f","head":{"label":"wschin:extinguish-i-schematized","ref":"extinguish-i-schematized","sha":"e962dd6a89363b153de2212b53655a5f2e8f536f","user":{"login":"wschin","id":3524474,"node_id":"MDQ6VXNlcjM1MjQ0NzQ=","avatar_url":"https://avatars1.githubusercontent.com/u/3524474?v=4","gravatar_id":"","url":"https://api.github.com/users/wschin","html_url":"https://github.com/wschin","followers_url":"https://api.github.com/users/wschin/followers","following_url":"https://api.github.com/users/wschin/following{/other_user}","gists_url":"https://api.github.com/users/wschin/gists{/gist_id}","starred_url":"https://api.github.com/users/wschin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wschin/subscriptions","organizations_url":"https://api.github.com/users/wschin/orgs","repos_url":"https://api.github.com/users/wschin/repos","events_url":"https://api.github.com/users/wschin/events{/privacy}","received_events_url":"https://api.github.com/users/wschin/received_events","type":"User","site_admin":false},"repo":{"id":142626704,"node_id":"MDEwOlJlcG9zaXRvcnkxNDI2MjY3MDQ=","name":"machinelearning","full_name":"wschin/machinelearning","private":false,"owner":{"login":"wschin","id":3524474,"node_id":"MDQ6VXNlcjM1MjQ0NzQ=","avatar_url":"https://avatars1.githubusercontent.com/u/3524474?v=4","gravatar_id":"","url":"https://api.github.com/users/wschin","html_url":"https://github.com/wschin","followers_url":"https://api.github.com/users/wschin/followers","following_url":"https://api.github.com/users/wschin/following{/other_user}","gists_url":"https://api.github.com/users/wschin/gists{/gist_id}","starred_url":"https://api.github.com/users/wschin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wschin/subscriptions","organizations_url":"https://api.github.com/users/wschin/orgs","repos_url":"https://api.github.com/users/wschin/repos","events_url":"https://api.github.com/users/wschin/events{/privacy}","received_events_url":"https://api.github.com/users/wschin/received_events","type":"User","site_admin":false},"html_url":"https://github.com/wschin/machinelearning","description":"ML.NET is an open source and cross-platform machine learning framework for .NET.","fork":true,"url":"https://api.github.com/repos/wschin/machinelearning","forks_url":"https://api.github.com/repos/wschin/machinelearning/forks","keys_url":"https://api.github.com/repos/wschin/machinelearning/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wschin/machinelearning/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wschin/machinelearning/teams","hooks_url":"https://api.github.com/repos/wschin/machinelearning/hooks","issue_events_url":"https://api.github.com/repos/wschin/machinelearning/issues/events{/number}","events_url":"https://api.github.com/repos/wschin/machinelearning/events","assignees_url":"https://api.github.com/repos/wschin/machinelearning/assignees{/user}","branches_url":"https://api.github.com/repos/wschin/machinelearning/branches{/branch}","tags_url":"https://api.github.com/repos/wschin/machinelearning/tags","blobs_url":"https://api.github.com/repos/wschin/machinelearning/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wschin/machinelearning/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wschin/machinelearning/git/refs{/sha}","trees_url":"https://api.github.com/repos/wschin/machinelearning/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wschin/machinelearning/statuses/{sha}","languages_url":"https://api.github.com/repos/wschin/machinelearning/languages","stargazers_url":"https://api.github.com/repos/wschin/machinelearning/stargazers","contributors_url":"https://api.github.com/repos/wschin/machinelearning/contributors","subscribers_url":"https://api.github.com/repos/wschin/machinelearning/subscribers","subscription_url":"https://api.github.com/repos/wschin/machinelearning/subscription","commits_url":"https://api.github.com/repos/wschin/machinelearning/commits{/sha}","git_commits_url":"https://api.github.com/repos/wschin/machinelearning/git/commits{/sha}","comments_url":"https://api.github.com/repos/wschin/machinelearning/comments{/number}","issue_comment_url":"https://api.github.com/repos/wschin/machinelearning/issues/comments{/number}","contents_url":"https://api.github.com/repos/wschin/machinelearning/contents/{+path}","compare_url":"https://api.github.com/repos/wschin/machinelearning/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wschin/machinelearning/merges","archive_url":"https://api.github.com/repos/wschin/machinelearning/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wschin/machinelearning/downloads","issues_url":"https://api.github.com/repos/wschin/machinelearning/issues{/number}","pulls_url":"https://api.github.com/repos/wschin/machinelearning/pulls{/number}","milestones_url":"https://api.github.com/repos/wschin/machinelearning/milestones{/number}","notifications_url":"https://api.github.com/repos/wschin/machinelearning/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wschin/machinelearning/labels{/name}","releases_url":"https://api.github.com/repos/wschin/machinelearning/releases{/id}","deployments_url":"https://api.github.com/repos/wschin/machinelearning/deployments","created_at":"2018-07-27T21:54:54Z","updated_at":"2018-11-15T17:02:37Z","pushed_at":"2018-11-28T20:45:49Z","git_url":"git://github.com/wschin/machinelearning.git","ssh_url":"[email protected]:wschin/machinelearning.git","clone_url":"https://github.com/wschin/machinelearning.git","svn_url":"https://github.com/wschin/machinelearning","homepage":"https://dot.net/ml","size":29960,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"4d1223d06bcda37ad1049bdde7c134f9d3421797","user":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":132021166,"node_id":"MDEwOlJlcG9zaXRvcnkxMzIwMjExNjY=","name":"machinelearning","full_name":"dotnet/machinelearning","private":false,"owner":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dotnet/machinelearning","description":"ML.NET is an open source and cross-platform machine learning framework for .NET.","fork":false,"url":"https://api.github.com/repos/dotnet/machinelearning","forks_url":"https://api.github.com/repos/dotnet/machinelearning/forks","keys_url":"https://api.github.com/repos/dotnet/machinelearning/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/machinelearning/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/machinelearning/teams","hooks_url":"https://api.github.com/repos/dotnet/machinelearning/hooks","issue_events_url":"https://api.github.com/repos/dotnet/machinelearning/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/machinelearning/events","assignees_url":"https://api.github.com/repos/dotnet/machinelearning/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/machinelearning/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/machinelearning/tags","blobs_url":"https://api.github.com/repos/dotnet/machinelearning/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/machinelearning/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/machinelearning/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/machinelearning/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/machinelearning/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/machinelearning/languages","stargazers_url":"https://api.github.com/repos/dotnet/machinelearning/stargazers","contributors_url":"https://api.github.com/repos/dotnet/machinelearning/contributors","subscribers_url":"https://api.github.com/repos/dotnet/machinelearning/subscribers","subscription_url":"https://api.github.com/repos/dotnet/machinelearning/subscription","commits_url":"https://api.github.com/repos/dotnet/machinelearning/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/machinelearning/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/machinelearning/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/machinelearning/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/machinelearning/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/machinelearning/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/machinelearning/merges","archive_url":"https://api.github.com/repos/dotnet/machinelearning/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/machinelearning/downloads","issues_url":"https://api.github.com/repos/dotnet/machinelearning/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/machinelearning/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/machinelearning/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/machinelearning/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/machinelearning/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/machinelearning/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/machinelearning/deployments","created_at":"2018-05-03T16:20:42Z","updated_at":"2018-11-28T20:59:49Z","pushed_at":"2018-11-28T20:59:45Z","git_url":"git://github.com/dotnet/machinelearning.git","ssh_url":"[email protected]:dotnet/machinelearning.git","clone_url":"https://github.com/dotnet/machinelearning.git","svn_url":"https://github.com/dotnet/machinelearning","homepage":"https://dot.net/ml","size":30056,"stargazers_count":4221,"watchers_count":4221,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":810,"mirror_url":null,"archived":false,"open_issues_count":385,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":810,"open_issues":385,"watchers":4221,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/machinelearning/pulls/1759"},"html":{"href":"https://github.com/dotnet/machinelearning/pull/1759"},"issue":{"href":"https://api.github.com/repos/dotnet/machinelearning/issues/1759"},"comments":{"href":"https://api.github.com/repos/dotnet/machinelearning/issues/1759/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/machinelearning/pulls/1759/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/machinelearning/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/machinelearning/pulls/1759/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/machinelearning/statuses/e962dd6a89363b153de2212b53655a5f2e8f536f"}},"author_association":"MEMBER"}} | {
"id": 132021166,
"name": "dotnet/machinelearning",
"url": "https://api.github.com/repos/dotnet/machinelearning"
} | {
"id": 1523833,
"login": "Ivanidzo4ka",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1523833?",
"url": "https://api.github.com/users/Ivanidzo4ka"
} | {
"id": 9141961,
"login": "dotnet",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9141961?",
"url": "https://api.github.com/orgs/dotnet"
} | 2018-11-28T21:20:16 | 8664818552 | {"actor":{"display_login":"Ivanidzo4ka"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/core-setup/pulls/comments/215093692","pull_request_review_id":152286076,"id":215093692,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNTA5MzY5Mg==","diff_hunk":"@@ -0,0 +1,74 @@\n+# Host tracing\n+\n+The various .NET Core host components provide detailed tracing of diagnostic information which can help solve issues around runtime, framework and assembly resolution and others. \n+\n+## Existing support\n+Currently (as of .NET Core 2.1) the host tracing is only written to the `stderr` output of the process. It can be turned on by setting `COREHOST_TRACE=1`.\n+\n+## Proposed changes\n+For .NET Core 3 the proposal is to keep the existing behavior as described above and add two additional ways to capture the tracing:\n+* Redirect the trace to a file instead - this would be done by setting `COREHOST_TRACE=1` and also `COREHOST_TRACEFILE=<path>` in the environment for the process.\n+* For custom host support a way to capture the trace output in code. This will be done by adding `*_set_trace_listener` functions to `hostfxr` and `hostpolicy` which would let the custom host intercept all tracing.\n+\n+## Components involved\n+Host tracing spans various components:\n+* `dotnet` or `apphost` executable\n+* `hostfxr` library\n+* `hostpolicy` library\n+\n+If a custom host is used it will typically replace the executables and possible even some of the libraries. The custom host can use either `hostfx` or `hostpolicy` directly. So each of these components must support tracing on its own along with the configuration. In case several of these components are used together, they must cooperate and \"share\" the tracing setup.\n+\n+Currently (as of .NET Core 2.1) all these components include the same code for tracing but act completely independently. VIa the fact that they share the same code, the end behavior is that they all write their trace output to the same location `stderr`. The only synchronization currently implemented is that each component fully flushes all internal tracing buffers before transferring control to a different component.\n+\n+## New trace routing\n+By default tracing is disabled and is not routed anywhere. If it's enabled it is routed through an instance of `host_trace_listener` interface.\n+``` C++\n+struct host_trace_listener\n+{\n+ void trace_verbose(const pal::char_t *message);\n+ void trace_info(const pal::char_t *message);\n+ void trace_warning(const pal::char_t *message);\n+ void trace_error(const pal::char_t *message);\n+ void flush();\n+}\n+```\n+\n+The `message` parameter is a standard `NUL` terminated string.\n+\n+The host components provide two built in implementations of this interface:\n+* `stderr_trace_listener` which implements the .NET Core 2.1 behavior of routing tracing to the `stderr` output of the process. This is the default listener which is activated by setting `COREHOST_TRACE=1` environment variable.\n+* `file_trace_listener` which routes tracing into a file. This listener is activated by setting the `COREHOST_TRACE=1` and also providing the full path to the trace file in `COREHOST_TRACEFILE=<path>` environment variable.\n+\n+Custom host can provide its own implementation of `host_trace_listener` by calling:\n+``` C++\n+void hostfxr_set_trace_listener(host_trace_listener* listener)\n+```\n+from the `hostfxr` component or\n+``` C++\n+void corehost_set_trace_listener(host_trace_listener* listener)\n+```\n+from the `hostpolicy` component.\n+\n+The functions behave exactly the same in both components. The `listener` parameter can be:\n+* a pointer to an implementation of `host_trace_listener` which is then registered the only listener for all tracing.\n+* `NULL` value which unregisters any previously registered listener. After this call tracing is disabled.\n+\n+Custom host can and should register the trace listener as the first thing it does with the respective host component to ensure that all tracing is routed to it. \n+\n+Only one trace listener can be registered at any given time. ","path":"Documentation/design-docs/host-tracing.md","position":58,"original_position":58,"commit_id":"dc93bea6efad142a10692284afba301841254d3d","original_commit_id":"dc93bea6efad142a10692284afba301841254d3d","user":{"login":"swaroop-sridhar","id":8977622,"node_id":"MDQ6VXNlcjg5Nzc2MjI=","avatar_url":"https://avatars1.githubusercontent.com/u/8977622?v=4","gravatar_id":"","url":"https://api.github.com/users/swaroop-sridhar","html_url":"https://github.com/swaroop-sridhar","followers_url":"https://api.github.com/users/swaroop-sridhar/followers","following_url":"https://api.github.com/users/swaroop-sridhar/following{/other_user}","gists_url":"https://api.github.com/users/swaroop-sridhar/gists{/gist_id}","starred_url":"https://api.github.com/users/swaroop-sridhar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swaroop-sridhar/subscriptions","organizations_url":"https://api.github.com/users/swaroop-sridhar/orgs","repos_url":"https://api.github.com/users/swaroop-sridhar/repos","events_url":"https://api.github.com/users/swaroop-sridhar/events{/privacy}","received_events_url":"https://api.github.com/users/swaroop-sridhar/received_events","type":"User","site_admin":false},"body":"I think the model here is that we can have multiple listeners based or cooperative protocol in this apps. So, we'll need to run the tests in cooperation with ASP.net.","created_at":"2018-09-04T23:09:14Z","updated_at":"2018-09-04T23:09:14Z","html_url":"https://github.com/dotnet/core-setup/pull/4531#discussion_r215093692","pull_request_url":"https://api.github.com/repos/dotnet/core-setup/pulls/4531","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/dotnet/core-setup/pulls/comments/215093692"},"html":{"href":"https://github.com/dotnet/core-setup/pull/4531#discussion_r215093692"},"pull_request":{"href":"https://api.github.com/repos/dotnet/core-setup/pulls/4531"}},"in_reply_to_id":215080666},"pull_request":{"url":"https://api.github.com/repos/dotnet/core-setup/pulls/4531","id":212771269,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEyNzcxMjY5","html_url":"https://github.com/dotnet/core-setup/pull/4531","diff_url":"https://github.com/dotnet/core-setup/pull/4531.diff","patch_url":"https://github.com/dotnet/core-setup/pull/4531.patch","issue_url":"https://api.github.com/repos/dotnet/core-setup/issues/4531","number":4531,"state":"open","locked":false,"title":"Proposal for improvements of host tracing in .NET Core 3","user":{"login":"vitek-karas","id":10670590,"node_id":"MDQ6VXNlcjEwNjcwNTkw","avatar_url":"https://avatars2.githubusercontent.com/u/10670590?v=4","gravatar_id":"","url":"https://api.github.com/users/vitek-karas","html_url":"https://github.com/vitek-karas","followers_url":"https://api.github.com/users/vitek-karas/followers","following_url":"https://api.github.com/users/vitek-karas/following{/other_user}","gists_url":"https://api.github.com/users/vitek-karas/gists{/gist_id}","starred_url":"https://api.github.com/users/vitek-karas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vitek-karas/subscriptions","organizations_url":"https://api.github.com/users/vitek-karas/orgs","repos_url":"https://api.github.com/users/vitek-karas/repos","events_url":"https://api.github.com/users/vitek-karas/events{/privacy}","received_events_url":"https://api.github.com/users/vitek-karas/received_events","type":"User","site_admin":false},"body":"This is related to #4455 ","created_at":"2018-09-03T14:52:27Z","updated_at":"2018-09-04T23:09:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a7336970141f18a8e10632d5d0555b7a980f0205","assignee":null,"assignees":[],"requested_reviewers":[{"login":"swaroop-sridhar","id":8977622,"node_id":"MDQ6VXNlcjg5Nzc2MjI=","avatar_url":"https://avatars1.githubusercontent.com/u/8977622?v=4","gravatar_id":"","url":"https://api.github.com/users/swaroop-sridhar","html_url":"https://github.com/swaroop-sridhar","followers_url":"https://api.github.com/users/swaroop-sridhar/followers","following_url":"https://api.github.com/users/swaroop-sridhar/following{/other_user}","gists_url":"https://api.github.com/users/swaroop-sridhar/gists{/gist_id}","starred_url":"https://api.github.com/users/swaroop-sridhar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swaroop-sridhar/subscriptions","organizations_url":"https://api.github.com/users/swaroop-sridhar/orgs","repos_url":"https://api.github.com/users/swaroop-sridhar/repos","events_url":"https://api.github.com/users/swaroop-sridhar/events{/privacy}","received_events_url":"https://api.github.com/users/swaroop-sridhar/received_events","type":"User","site_admin":false},{"login":"jeffschwMSFT","id":9561583,"node_id":"MDQ6VXNlcjk1NjE1ODM=","avatar_url":"https://avatars0.githubusercontent.com/u/9561583?v=4","gravatar_id":"","url":"https://api.github.com/users/jeffschwMSFT","html_url":"https://github.com/jeffschwMSFT","followers_url":"https://api.github.com/users/jeffschwMSFT/followers","following_url":"https://api.github.com/users/jeffschwMSFT/following{/other_user}","gists_url":"https://api.github.com/users/jeffschwMSFT/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffschwMSFT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffschwMSFT/subscriptions","organizations_url":"https://api.github.com/users/jeffschwMSFT/orgs","repos_url":"https://api.github.com/users/jeffschwMSFT/repos","events_url":"https://api.github.com/users/jeffschwMSFT/events{/privacy}","received_events_url":"https://api.github.com/users/jeffschwMSFT/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/core-setup/pulls/4531/commits","review_comments_url":"https://api.github.com/repos/dotnet/core-setup/pulls/4531/comments","review_comment_url":"https://api.github.com/repos/dotnet/core-setup/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/core-setup/issues/4531/comments","statuses_url":"https://api.github.com/repos/dotnet/core-setup/statuses/dc93bea6efad142a10692284afba301841254d3d","head":{"label":"vitek-karas:HostTracingDesign","ref":"HostTracingDesign","sha":"dc93bea6efad142a10692284afba301841254d3d","user":{"login":"vitek-karas","id":10670590,"node_id":"MDQ6VXNlcjEwNjcwNTkw","avatar_url":"https://avatars2.githubusercontent.com/u/10670590?v=4","gravatar_id":"","url":"https://api.github.com/users/vitek-karas","html_url":"https://github.com/vitek-karas","followers_url":"https://api.github.com/users/vitek-karas/followers","following_url":"https://api.github.com/users/vitek-karas/following{/other_user}","gists_url":"https://api.github.com/users/vitek-karas/gists{/gist_id}","starred_url":"https://api.github.com/users/vitek-karas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vitek-karas/subscriptions","organizations_url":"https://api.github.com/users/vitek-karas/orgs","repos_url":"https://api.github.com/users/vitek-karas/repos","events_url":"https://api.github.com/users/vitek-karas/events{/privacy}","received_events_url":"https://api.github.com/users/vitek-karas/received_events","type":"User","site_admin":false},"repo":{"id":138876524,"node_id":"MDEwOlJlcG9zaXRvcnkxMzg4NzY1MjQ=","name":"core-setup","full_name":"vitek-karas/core-setup","owner":{"login":"vitek-karas","id":10670590,"node_id":"MDQ6VXNlcjEwNjcwNTkw","avatar_url":"https://avatars2.githubusercontent.com/u/10670590?v=4","gravatar_id":"","url":"https://api.github.com/users/vitek-karas","html_url":"https://github.com/vitek-karas","followers_url":"https://api.github.com/users/vitek-karas/followers","following_url":"https://api.github.com/users/vitek-karas/following{/other_user}","gists_url":"https://api.github.com/users/vitek-karas/gists{/gist_id}","starred_url":"https://api.github.com/users/vitek-karas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vitek-karas/subscriptions","organizations_url":"https://api.github.com/users/vitek-karas/orgs","repos_url":"https://api.github.com/users/vitek-karas/repos","events_url":"https://api.github.com/users/vitek-karas/events{/privacy}","received_events_url":"https://api.github.com/users/vitek-karas/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vitek-karas/core-setup","description":"Installer packages for the .NET Core runtime and libraries","fork":true,"url":"https://api.github.com/repos/vitek-karas/core-setup","forks_url":"https://api.github.com/repos/vitek-karas/core-setup/forks","keys_url":"https://api.github.com/repos/vitek-karas/core-setup/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vitek-karas/core-setup/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vitek-karas/core-setup/teams","hooks_url":"https://api.github.com/repos/vitek-karas/core-setup/hooks","issue_events_url":"https://api.github.com/repos/vitek-karas/core-setup/issues/events{/number}","events_url":"https://api.github.com/repos/vitek-karas/core-setup/events","assignees_url":"https://api.github.com/repos/vitek-karas/core-setup/assignees{/user}","branches_url":"https://api.github.com/repos/vitek-karas/core-setup/branches{/branch}","tags_url":"https://api.github.com/repos/vitek-karas/core-setup/tags","blobs_url":"https://api.github.com/repos/vitek-karas/core-setup/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vitek-karas/core-setup/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vitek-karas/core-setup/git/refs{/sha}","trees_url":"https://api.github.com/repos/vitek-karas/core-setup/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vitek-karas/core-setup/statuses/{sha}","languages_url":"https://api.github.com/repos/vitek-karas/core-setup/languages","stargazers_url":"https://api.github.com/repos/vitek-karas/core-setup/stargazers","contributors_url":"https://api.github.com/repos/vitek-karas/core-setup/contributors","subscribers_url":"https://api.github.com/repos/vitek-karas/core-setup/subscribers","subscription_url":"https://api.github.com/repos/vitek-karas/core-setup/subscription","commits_url":"https://api.github.com/repos/vitek-karas/core-setup/commits{/sha}","git_commits_url":"https://api.github.com/repos/vitek-karas/core-setup/git/commits{/sha}","comments_url":"https://api.github.com/repos/vitek-karas/core-setup/comments{/number}","issue_comment_url":"https://api.github.com/repos/vitek-karas/core-setup/issues/comments{/number}","contents_url":"https://api.github.com/repos/vitek-karas/core-setup/contents/{+path}","compare_url":"https://api.github.com/repos/vitek-karas/core-setup/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vitek-karas/core-setup/merges","archive_url":"https://api.github.com/repos/vitek-karas/core-setup/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vitek-karas/core-setup/downloads","issues_url":"https://api.github.com/repos/vitek-karas/core-setup/issues{/number}","pulls_url":"https://api.github.com/repos/vitek-karas/core-setup/pulls{/number}","milestones_url":"https://api.github.com/repos/vitek-karas/core-setup/milestones{/number}","notifications_url":"https://api.github.com/repos/vitek-karas/core-setup/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vitek-karas/core-setup/labels{/name}","releases_url":"https://api.github.com/repos/vitek-karas/core-setup/releases{/id}","deployments_url":"https://api.github.com/repos/vitek-karas/core-setup/deployments","created_at":"2018-06-27T12:09:50Z","updated_at":"2018-09-03T06:56:35Z","pushed_at":"2018-09-04T20:28:29Z","git_url":"git://github.com/vitek-karas/core-setup.git","ssh_url":"[email protected]:vitek-karas/core-setup.git","clone_url":"https://github.com/vitek-karas/core-setup.git","svn_url":"https://github.com/vitek-karas/core-setup","homepage":"","size":6409,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"eab4b2fd162e453988af973878ddfa7eb9496a6b","user":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":59249196,"node_id":"MDEwOlJlcG9zaXRvcnk1OTI0OTE5Ng==","name":"core-setup","full_name":"dotnet/core-setup","owner":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/core-setup","description":"Installer packages for the .NET Core runtime and libraries","fork":false,"url":"https://api.github.com/repos/dotnet/core-setup","forks_url":"https://api.github.com/repos/dotnet/core-setup/forks","keys_url":"https://api.github.com/repos/dotnet/core-setup/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/core-setup/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/core-setup/teams","hooks_url":"https://api.github.com/repos/dotnet/core-setup/hooks","issue_events_url":"https://api.github.com/repos/dotnet/core-setup/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/core-setup/events","assignees_url":"https://api.github.com/repos/dotnet/core-setup/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/core-setup/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/core-setup/tags","blobs_url":"https://api.github.com/repos/dotnet/core-setup/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/core-setup/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/core-setup/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/core-setup/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/core-setup/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/core-setup/languages","stargazers_url":"https://api.github.com/repos/dotnet/core-setup/stargazers","contributors_url":"https://api.github.com/repos/dotnet/core-setup/contributors","subscribers_url":"https://api.github.com/repos/dotnet/core-setup/subscribers","subscription_url":"https://api.github.com/repos/dotnet/core-setup/subscription","commits_url":"https://api.github.com/repos/dotnet/core-setup/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/core-setup/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/core-setup/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/core-setup/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/core-setup/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/core-setup/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/core-setup/merges","archive_url":"https://api.github.com/repos/dotnet/core-setup/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/core-setup/downloads","issues_url":"https://api.github.com/repos/dotnet/core-setup/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/core-setup/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/core-setup/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/core-setup/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/core-setup/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/core-setup/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/core-setup/deployments","created_at":"2016-05-19T23:07:13Z","updated_at":"2018-09-04T18:11:26Z","pushed_at":"2018-09-04T20:28:30Z","git_url":"git://github.com/dotnet/core-setup.git","ssh_url":"[email protected]:dotnet/core-setup.git","clone_url":"https://github.com/dotnet/core-setup.git","svn_url":"https://github.com/dotnet/core-setup","homepage":"","size":6546,"stargazers_count":234,"watchers_count":234,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":152,"mirror_url":null,"archived":false,"open_issues_count":185,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":152,"open_issues":185,"watchers":234,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/core-setup/pulls/4531"},"html":{"href":"https://github.com/dotnet/core-setup/pull/4531"},"issue":{"href":"https://api.github.com/repos/dotnet/core-setup/issues/4531"},"comments":{"href":"https://api.github.com/repos/dotnet/core-setup/issues/4531/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/core-setup/pulls/4531/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/core-setup/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/core-setup/pulls/4531/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/core-setup/statuses/dc93bea6efad142a10692284afba301841254d3d"}},"author_association":"MEMBER"}} | {
"id": 59249196,
"name": "dotnet/core-setup",
"url": "https://api.github.com/repos/dotnet/core-setup"
} | {
"id": 8977622,
"login": "swaroop-sridhar",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/8977622?",
"url": "https://api.github.com/users/swaroop-sridhar"
} | {
"id": 9141961,
"login": "dotnet",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9141961?",
"url": "https://api.github.com/orgs/dotnet"
} | 2018-09-04T23:09:14 | 8214395519 | {"actor":{"display_login":"swaroop-sridhar"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/coreclr/pulls/comments/174988741","pull_request_review_id":104444855,"id":174988741,"diff_hunk":"@@ -395,10 +397,12 @@ HARDWARE_INTRINSIC(AVX2_BroadcastScalarToVector128, \"BroadcastS\n HARDWARE_INTRINSIC(AVX2_BroadcastScalarToVector256, \"BroadcastScalarToVector256\", AVX2, -1, 32, 1, {INS_vpbroadcastb,INS_vpbroadcastb,INS_vpbroadcastw,INS_vpbroadcastw,INS_vpbroadcastd,INS_vpbroadcastd,INS_vpbroadcastq,INS_vpbroadcastq,INS_vbroadcastss,INS_vbroadcastsd}, HW_Category_SimpleSIMD, HW_Flag_OneTypeGeneric)\n HARDWARE_INTRINSIC(AVX2_CompareEqual, \"CompareEqual\", AVX2, -1, 32, 2, {INS_pcmpeqb, INS_pcmpeqb, INS_pcmpeqw, INS_pcmpeqw, INS_pcmpeqd, INS_pcmpeqd, INS_pcmpeqq, INS_pcmpeqq, INS_invalid, INS_invalid}, HW_Category_SimpleSIMD, HW_Flag_Commutative)\n HARDWARE_INTRINSIC(AVX2_CompareGreaterThan, \"CompareGreaterThan\", AVX2, -1, 32, 2, {INS_pcmpgtb, INS_invalid, INS_pcmpgtw, INS_invalid, INS_pcmpgtd, INS_invalid, INS_pcmpgtq, INS_invalid, INS_invalid, INS_invalid}, HW_Category_SimpleSIMD, HW_Flag_NoFlag)\n+HARDWARE_INTRINSIC(AVX2_ExtractVector128, \"ExtractVector128\", AVX2, -1, 32, -1, {INS_vextracti128,INS_vextracti128,INS_vextracti128,INS_vextracti128,INS_vextracti128,INS_vextracti128,INS_vextracti128,INS_vextracti128,INS_invalid, INS_invalid},HW_Category_IMM, HW_Flag_SpecialImport|HW_Flag_SpecialCodeGen|HW_Flag_FullRangeIMM)","path":"src/jit/hwintrinsiclistxarch.h","position":17,"original_position":17,"commit_id":"077a0f29801a03e19d387e808134580dc303282e","original_commit_id":"077a0f29801a03e19d387e808134580dc303282e","user":{"login":"tannergooding","id":10487869,"avatar_url":"https://avatars3.githubusercontent.com/u/10487869?v=4","gravatar_id":"","url":"https://api.github.com/users/tannergooding","html_url":"https://github.com/tannergooding","followers_url":"https://api.github.com/users/tannergooding/followers","following_url":"https://api.github.com/users/tannergooding/following{/other_user}","gists_url":"https://api.github.com/users/tannergooding/gists{/gist_id}","starred_url":"https://api.github.com/users/tannergooding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tannergooding/subscriptions","organizations_url":"https://api.github.com/users/tannergooding/orgs","repos_url":"https://api.github.com/users/tannergooding/repos","events_url":"https://api.github.com/users/tannergooding/events{/privacy}","received_events_url":"https://api.github.com/users/tannergooding/received_events","type":"User","site_admin":false},"body":"nit: Alignment is off","created_at":"2018-03-16T03:15:30Z","updated_at":"2018-03-16T03:15:30Z","html_url":"https://github.com/dotnet/coreclr/pull/16903#discussion_r174988741","pull_request_url":"https://api.github.com/repos/dotnet/coreclr/pulls/16903","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/comments/174988741"},"html":{"href":"https://github.com/dotnet/coreclr/pull/16903#discussion_r174988741"},"pull_request":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/16903"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/coreclr/pulls/16903","id":174572201,"html_url":"https://github.com/dotnet/coreclr/pull/16903","diff_url":"https://github.com/dotnet/coreclr/pull/16903.diff","patch_url":"https://github.com/dotnet/coreclr/pull/16903.patch","issue_url":"https://api.github.com/repos/dotnet/coreclr/issues/16903","number":16903,"state":"open","locked":false,"title":" Implement AVX/AVX2 Insert/ExtractVector128 intrinsic and AVX Insert/Extract helpers","user":{"login":"fiigii","id":1263030,"avatar_url":"https://avatars1.githubusercontent.com/u/1263030?v=4","gravatar_id":"","url":"https://api.github.com/users/fiigii","html_url":"https://github.com/fiigii","followers_url":"https://api.github.com/users/fiigii/followers","following_url":"https://api.github.com/users/fiigii/following{/other_user}","gists_url":"https://api.github.com/users/fiigii/gists{/gist_id}","starred_url":"https://api.github.com/users/fiigii/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fiigii/subscriptions","organizations_url":"https://api.github.com/users/fiigii/orgs","repos_url":"https://api.github.com/users/fiigii/repos","events_url":"https://api.github.com/users/fiigii/events{/privacy}","received_events_url":"https://api.github.com/users/fiigii/received_events","type":"User","site_admin":false},"body":"@tannergooding @CarolEidt PTAL","created_at":"2018-03-13T06:55:11Z","updated_at":"2018-03-16T03:15:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"79d4a3995e8c1c1418d9882681bcdde517c56330","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/coreclr/pulls/16903/commits","review_comments_url":"https://api.github.com/repos/dotnet/coreclr/pulls/16903/comments","review_comment_url":"https://api.github.com/repos/dotnet/coreclr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/coreclr/issues/16903/comments","statuses_url":"https://api.github.com/repos/dotnet/coreclr/statuses/077a0f29801a03e19d387e808134580dc303282e","head":{"label":"fiigii:avxhelper","ref":"avxhelper","sha":"077a0f29801a03e19d387e808134580dc303282e","user":{"login":"fiigii","id":1263030,"avatar_url":"https://avatars1.githubusercontent.com/u/1263030?v=4","gravatar_id":"","url":"https://api.github.com/users/fiigii","html_url":"https://github.com/fiigii","followers_url":"https://api.github.com/users/fiigii/followers","following_url":"https://api.github.com/users/fiigii/following{/other_user}","gists_url":"https://api.github.com/users/fiigii/gists{/gist_id}","starred_url":"https://api.github.com/users/fiigii/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fiigii/subscriptions","organizations_url":"https://api.github.com/users/fiigii/orgs","repos_url":"https://api.github.com/users/fiigii/repos","events_url":"https://api.github.com/users/fiigii/events{/privacy}","received_events_url":"https://api.github.com/users/fiigii/received_events","type":"User","site_admin":false},"repo":{"id":81883824,"name":"coreclr","full_name":"fiigii/coreclr","owner":{"login":"fiigii","id":1263030,"avatar_url":"https://avatars1.githubusercontent.com/u/1263030?v=4","gravatar_id":"","url":"https://api.github.com/users/fiigii","html_url":"https://github.com/fiigii","followers_url":"https://api.github.com/users/fiigii/followers","following_url":"https://api.github.com/users/fiigii/following{/other_user}","gists_url":"https://api.github.com/users/fiigii/gists{/gist_id}","starred_url":"https://api.github.com/users/fiigii/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fiigii/subscriptions","organizations_url":"https://api.github.com/users/fiigii/orgs","repos_url":"https://api.github.com/users/fiigii/repos","events_url":"https://api.github.com/users/fiigii/events{/privacy}","received_events_url":"https://api.github.com/users/fiigii/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fiigii/coreclr","description":"This repo contains the .NET Core runtime, called CoreCLR, and the base library, called mscorlib. It includes the garbage collector, JIT compiler, base .NET data types and many low-level classes.","fork":true,"url":"https://api.github.com/repos/fiigii/coreclr","forks_url":"https://api.github.com/repos/fiigii/coreclr/forks","keys_url":"https://api.github.com/repos/fiigii/coreclr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fiigii/coreclr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fiigii/coreclr/teams","hooks_url":"https://api.github.com/repos/fiigii/coreclr/hooks","issue_events_url":"https://api.github.com/repos/fiigii/coreclr/issues/events{/number}","events_url":"https://api.github.com/repos/fiigii/coreclr/events","assignees_url":"https://api.github.com/repos/fiigii/coreclr/assignees{/user}","branches_url":"https://api.github.com/repos/fiigii/coreclr/branches{/branch}","tags_url":"https://api.github.com/repos/fiigii/coreclr/tags","blobs_url":"https://api.github.com/repos/fiigii/coreclr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fiigii/coreclr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fiigii/coreclr/git/refs{/sha}","trees_url":"https://api.github.com/repos/fiigii/coreclr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fiigii/coreclr/statuses/{sha}","languages_url":"https://api.github.com/repos/fiigii/coreclr/languages","stargazers_url":"https://api.github.com/repos/fiigii/coreclr/stargazers","contributors_url":"https://api.github.com/repos/fiigii/coreclr/contributors","subscribers_url":"https://api.github.com/repos/fiigii/coreclr/subscribers","subscription_url":"https://api.github.com/repos/fiigii/coreclr/subscription","commits_url":"https://api.github.com/repos/fiigii/coreclr/commits{/sha}","git_commits_url":"https://api.github.com/repos/fiigii/coreclr/git/commits{/sha}","comments_url":"https://api.github.com/repos/fiigii/coreclr/comments{/number}","issue_comment_url":"https://api.github.com/repos/fiigii/coreclr/issues/comments{/number}","contents_url":"https://api.github.com/repos/fiigii/coreclr/contents/{+path}","compare_url":"https://api.github.com/repos/fiigii/coreclr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fiigii/coreclr/merges","archive_url":"https://api.github.com/repos/fiigii/coreclr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fiigii/coreclr/downloads","issues_url":"https://api.github.com/repos/fiigii/coreclr/issues{/number}","pulls_url":"https://api.github.com/repos/fiigii/coreclr/pulls{/number}","milestones_url":"https://api.github.com/repos/fiigii/coreclr/milestones{/number}","notifications_url":"https://api.github.com/repos/fiigii/coreclr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fiigii/coreclr/labels{/name}","releases_url":"https://api.github.com/repos/fiigii/coreclr/releases{/id}","deployments_url":"https://api.github.com/repos/fiigii/coreclr/deployments","created_at":"2017-02-13T23:46:21Z","updated_at":"2018-03-14T17:49:12Z","pushed_at":"2018-03-15T20:49:42Z","git_url":"git://github.com/fiigii/coreclr.git","ssh_url":"[email protected]:fiigii/coreclr.git","clone_url":"https://github.com/fiigii/coreclr.git","svn_url":"https://github.com/fiigii/coreclr","homepage":"https://docs.microsoft.com/dotnet/","size":211069,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"db1408370f3b260d32eab0daa32c148777780797","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":30092893,"name":"coreclr","full_name":"dotnet/coreclr","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/coreclr","description":"This repo contains the .NET Core runtime, called CoreCLR, and the base library, called System.Private.Corelib (or mscorlib). It includes the garbage collector, JIT compiler, base .NET data types and many low-level classes. We welcome contributions.","fork":false,"url":"https://api.github.com/repos/dotnet/coreclr","forks_url":"https://api.github.com/repos/dotnet/coreclr/forks","keys_url":"https://api.github.com/repos/dotnet/coreclr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/coreclr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/coreclr/teams","hooks_url":"https://api.github.com/repos/dotnet/coreclr/hooks","issue_events_url":"https://api.github.com/repos/dotnet/coreclr/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/coreclr/events","assignees_url":"https://api.github.com/repos/dotnet/coreclr/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/coreclr/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/coreclr/tags","blobs_url":"https://api.github.com/repos/dotnet/coreclr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/coreclr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/coreclr/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/coreclr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/coreclr/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/coreclr/languages","stargazers_url":"https://api.github.com/repos/dotnet/coreclr/stargazers","contributors_url":"https://api.github.com/repos/dotnet/coreclr/contributors","subscribers_url":"https://api.github.com/repos/dotnet/coreclr/subscribers","subscription_url":"https://api.github.com/repos/dotnet/coreclr/subscription","commits_url":"https://api.github.com/repos/dotnet/coreclr/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/coreclr/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/coreclr/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/coreclr/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/coreclr/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/coreclr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/coreclr/merges","archive_url":"https://api.github.com/repos/dotnet/coreclr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/coreclr/downloads","issues_url":"https://api.github.com/repos/dotnet/coreclr/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/coreclr/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/coreclr/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/coreclr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/coreclr/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/coreclr/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/coreclr/deployments","created_at":"2015-01-30T22:10:02Z","updated_at":"2018-03-16T03:08:08Z","pushed_at":"2018-03-16T03:08:33Z","git_url":"git://github.com/dotnet/coreclr.git","ssh_url":"[email protected]:dotnet/coreclr.git","clone_url":"https://github.com/dotnet/coreclr.git","svn_url":"https://github.com/dotnet/coreclr","homepage":"https://github.com/dotnet/core","size":212540,"stargazers_count":9049,"watchers_count":9049,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2270,"mirror_url":null,"archived":false,"open_issues_count":1577,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":2270,"open_issues":1577,"watchers":9049,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/16903"},"html":{"href":"https://github.com/dotnet/coreclr/pull/16903"},"issue":{"href":"https://api.github.com/repos/dotnet/coreclr/issues/16903"},"comments":{"href":"https://api.github.com/repos/dotnet/coreclr/issues/16903/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/16903/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/16903/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/coreclr/statuses/077a0f29801a03e19d387e808134580dc303282e"}},"author_association":"COLLABORATOR"}} | {
"id": 30092893,
"name": "dotnet/coreclr",
"url": "https://api.github.com/repos/dotnet/coreclr"
} | {
"id": 10487869,
"login": "tannergooding",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/10487869?",
"url": "https://api.github.com/users/tannergooding"
} | {
"id": 9141961,
"login": "dotnet",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9141961?",
"url": "https://api.github.com/orgs/dotnet"
} | 2018-03-16T03:15:30 | 7388531037 | {"actor":{"display_login":"tannergooding"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/coreclr/pulls/comments/233975813","pull_request_review_id":175515317,"id":233975813,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMzk3NTgxMw==","diff_hunk":"@@ -65,7 +65,7 @@ public static bool TryFormat(float value, Span<byte> destination, out int bytesW\n // be preferable not to have another version of that lying around. Until we really hit a scenario where floating point formatting needs the perf, we'll\n // make do with this.\n //\n- private static bool TryFormatFloatingPoint<T>(T value, Span<byte> destination, out int bytesWritten, StandardFormat format) where T : IFormattable\n+ private static bool TryFormatFloatingPoint<T>(T value, Span<byte> destination, out int bytesWritten, StandardFormat format) where T : ISpanFormattable","path":"src/System.Private.CoreLib/shared/System/Buffers/Text/Utf8Formatter/Utf8Formatter.Float.cs","position":5,"original_position":5,"commit_id":"802950b8a06c2a287e498316745f461708839d0a","original_commit_id":"802950b8a06c2a287e498316745f461708839d0a","user":{"login":"Tornhoof","id":7989549,"node_id":"MDQ6VXNlcjc5ODk1NDk=","avatar_url":"https://avatars1.githubusercontent.com/u/7989549?v=4","gravatar_id":"","url":"https://api.github.com/users/Tornhoof","html_url":"https://github.com/Tornhoof","followers_url":"https://api.github.com/users/Tornhoof/followers","following_url":"https://api.github.com/users/Tornhoof/following{/other_user}","gists_url":"https://api.github.com/users/Tornhoof/gists{/gist_id}","starred_url":"https://api.github.com/users/Tornhoof/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tornhoof/subscriptions","organizations_url":"https://api.github.com/users/Tornhoof/orgs","repos_url":"https://api.github.com/users/Tornhoof/repos","events_url":"https://api.github.com/users/Tornhoof/events{/privacy}","received_events_url":"https://api.github.com/users/Tornhoof/received_events","type":"User","site_admin":false},"body":".TryFormat is in ISpanFormattable","created_at":"2018-11-15T19:21:24Z","updated_at":"2018-11-15T19:21:24Z","html_url":"https://github.com/dotnet/coreclr/pull/21030#discussion_r233975813","pull_request_url":"https://api.github.com/repos/dotnet/coreclr/pulls/21030","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/comments/233975813"},"html":{"href":"https://github.com/dotnet/coreclr/pull/21030#discussion_r233975813"},"pull_request":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/21030"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/coreclr/pulls/21030","id":231305771,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxMzA1Nzcx","html_url":"https://github.com/dotnet/coreclr/pull/21030","diff_url":"https://github.com/dotnet/coreclr/pull/21030.diff","patch_url":"https://github.com/dotnet/coreclr/pull/21030.patch","issue_url":"https://api.github.com/repos/dotnet/coreclr/issues/21030","number":21030,"state":"open","locked":false,"title":"Utf8Formatter: Reduce allocations for floating point","user":{"login":"Tornhoof","id":7989549,"node_id":"MDQ6VXNlcjc5ODk1NDk=","avatar_url":"https://avatars1.githubusercontent.com/u/7989549?v=4","gravatar_id":"","url":"https://api.github.com/users/Tornhoof","html_url":"https://github.com/Tornhoof","followers_url":"https://api.github.com/users/Tornhoof/followers","following_url":"https://api.github.com/users/Tornhoof/following{/other_user}","gists_url":"https://api.github.com/users/Tornhoof/gists{/gist_id}","starred_url":"https://api.github.com/users/Tornhoof/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tornhoof/subscriptions","organizations_url":"https://api.github.com/users/Tornhoof/orgs","repos_url":"https://api.github.com/users/Tornhoof/repos","events_url":"https://api.github.com/users/Tornhoof/events{/privacy}","received_events_url":"https://api.github.com/users/Tornhoof/received_events","type":"User","site_admin":false},"body":"As discussed in https://github.com/dotnet/corefx/issues/25077#issuecomment-439082212\r\n\r\nCan anybody help me how to run the tests for this locally?\r\nIn CoreClr there are no tests for the Utf8Formatter.\r\nIn CoreFx they are still in the System.Memory.Tests project, I tried to copy both changed files into the related corefx directories and build/run tests. But I'm not really convinced my changed code is actually executed, I tried to throw an exception in the code below and still all the tests were successful.","created_at":"2018-11-15T19:20:05Z","updated_at":"2018-11-15T19:21:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"94913a17e886ea37c16805cfce75bb0829cf2e03","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/coreclr/pulls/21030/commits","review_comments_url":"https://api.github.com/repos/dotnet/coreclr/pulls/21030/comments","review_comment_url":"https://api.github.com/repos/dotnet/coreclr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/coreclr/issues/21030/comments","statuses_url":"https://api.github.com/repos/dotnet/coreclr/statuses/802950b8a06c2a287e498316745f461708839d0a","head":{"label":"Tornhoof:StackAllocFormatFloatingPoint","ref":"StackAllocFormatFloatingPoint","sha":"802950b8a06c2a287e498316745f461708839d0a","user":{"login":"Tornhoof","id":7989549,"node_id":"MDQ6VXNlcjc5ODk1NDk=","avatar_url":"https://avatars1.githubusercontent.com/u/7989549?v=4","gravatar_id":"","url":"https://api.github.com/users/Tornhoof","html_url":"https://github.com/Tornhoof","followers_url":"https://api.github.com/users/Tornhoof/followers","following_url":"https://api.github.com/users/Tornhoof/following{/other_user}","gists_url":"https://api.github.com/users/Tornhoof/gists{/gist_id}","starred_url":"https://api.github.com/users/Tornhoof/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tornhoof/subscriptions","organizations_url":"https://api.github.com/users/Tornhoof/orgs","repos_url":"https://api.github.com/users/Tornhoof/repos","events_url":"https://api.github.com/users/Tornhoof/events{/privacy}","received_events_url":"https://api.github.com/users/Tornhoof/received_events","type":"User","site_admin":false},"repo":{"id":157747813,"node_id":"MDEwOlJlcG9zaXRvcnkxNTc3NDc4MTM=","name":"coreclr","full_name":"Tornhoof/coreclr","private":false,"owner":{"login":"Tornhoof","id":7989549,"node_id":"MDQ6VXNlcjc5ODk1NDk=","avatar_url":"https://avatars1.githubusercontent.com/u/7989549?v=4","gravatar_id":"","url":"https://api.github.com/users/Tornhoof","html_url":"https://github.com/Tornhoof","followers_url":"https://api.github.com/users/Tornhoof/followers","following_url":"https://api.github.com/users/Tornhoof/following{/other_user}","gists_url":"https://api.github.com/users/Tornhoof/gists{/gist_id}","starred_url":"https://api.github.com/users/Tornhoof/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tornhoof/subscriptions","organizations_url":"https://api.github.com/users/Tornhoof/orgs","repos_url":"https://api.github.com/users/Tornhoof/repos","events_url":"https://api.github.com/users/Tornhoof/events{/privacy}","received_events_url":"https://api.github.com/users/Tornhoof/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Tornhoof/coreclr","description":"This repo contains the .NET Core runtime, called CoreCLR, and the base library, called System.Private.Corelib (or mscorlib). It includes the garbage collector, JIT compiler, base .NET data types and many low-level classes. We welcome contributions.","fork":true,"url":"https://api.github.com/repos/Tornhoof/coreclr","forks_url":"https://api.github.com/repos/Tornhoof/coreclr/forks","keys_url":"https://api.github.com/repos/Tornhoof/coreclr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Tornhoof/coreclr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Tornhoof/coreclr/teams","hooks_url":"https://api.github.com/repos/Tornhoof/coreclr/hooks","issue_events_url":"https://api.github.com/repos/Tornhoof/coreclr/issues/events{/number}","events_url":"https://api.github.com/repos/Tornhoof/coreclr/events","assignees_url":"https://api.github.com/repos/Tornhoof/coreclr/assignees{/user}","branches_url":"https://api.github.com/repos/Tornhoof/coreclr/branches{/branch}","tags_url":"https://api.github.com/repos/Tornhoof/coreclr/tags","blobs_url":"https://api.github.com/repos/Tornhoof/coreclr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Tornhoof/coreclr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Tornhoof/coreclr/git/refs{/sha}","trees_url":"https://api.github.com/repos/Tornhoof/coreclr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Tornhoof/coreclr/statuses/{sha}","languages_url":"https://api.github.com/repos/Tornhoof/coreclr/languages","stargazers_url":"https://api.github.com/repos/Tornhoof/coreclr/stargazers","contributors_url":"https://api.github.com/repos/Tornhoof/coreclr/contributors","subscribers_url":"https://api.github.com/repos/Tornhoof/coreclr/subscribers","subscription_url":"https://api.github.com/repos/Tornhoof/coreclr/subscription","commits_url":"https://api.github.com/repos/Tornhoof/coreclr/commits{/sha}","git_commits_url":"https://api.github.com/repos/Tornhoof/coreclr/git/commits{/sha}","comments_url":"https://api.github.com/repos/Tornhoof/coreclr/comments{/number}","issue_comment_url":"https://api.github.com/repos/Tornhoof/coreclr/issues/comments{/number}","contents_url":"https://api.github.com/repos/Tornhoof/coreclr/contents/{+path}","compare_url":"https://api.github.com/repos/Tornhoof/coreclr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Tornhoof/coreclr/merges","archive_url":"https://api.github.com/repos/Tornhoof/coreclr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Tornhoof/coreclr/downloads","issues_url":"https://api.github.com/repos/Tornhoof/coreclr/issues{/number}","pulls_url":"https://api.github.com/repos/Tornhoof/coreclr/pulls{/number}","milestones_url":"https://api.github.com/repos/Tornhoof/coreclr/milestones{/number}","notifications_url":"https://api.github.com/repos/Tornhoof/coreclr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Tornhoof/coreclr/labels{/name}","releases_url":"https://api.github.com/repos/Tornhoof/coreclr/releases{/id}","deployments_url":"https://api.github.com/repos/Tornhoof/coreclr/deployments","created_at":"2018-11-15T17:26:52Z","updated_at":"2018-11-15T17:28:06Z","pushed_at":"2018-11-15T18:06:03Z","git_url":"git://github.com/Tornhoof/coreclr.git","ssh_url":"[email protected]:Tornhoof/coreclr.git","clone_url":"https://github.com/Tornhoof/coreclr.git","svn_url":"https://github.com/Tornhoof/coreclr","homepage":"https://github.com/dotnet/core","size":253933,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"356a08f7e90113b31005c02abb14662bc40bed70","user":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":30092893,"node_id":"MDEwOlJlcG9zaXRvcnkzMDA5Mjg5Mw==","name":"coreclr","full_name":"dotnet/coreclr","private":false,"owner":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dotnet/coreclr","description":"This repo contains the .NET Core runtime, called CoreCLR, and the base library, called System.Private.Corelib (or mscorlib). It includes the garbage collector, JIT compiler, base .NET data types and many low-level classes. We welcome contributions.","fork":false,"url":"https://api.github.com/repos/dotnet/coreclr","forks_url":"https://api.github.com/repos/dotnet/coreclr/forks","keys_url":"https://api.github.com/repos/dotnet/coreclr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/coreclr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/coreclr/teams","hooks_url":"https://api.github.com/repos/dotnet/coreclr/hooks","issue_events_url":"https://api.github.com/repos/dotnet/coreclr/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/coreclr/events","assignees_url":"https://api.github.com/repos/dotnet/coreclr/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/coreclr/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/coreclr/tags","blobs_url":"https://api.github.com/repos/dotnet/coreclr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/coreclr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/coreclr/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/coreclr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/coreclr/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/coreclr/languages","stargazers_url":"https://api.github.com/repos/dotnet/coreclr/stargazers","contributors_url":"https://api.github.com/repos/dotnet/coreclr/contributors","subscribers_url":"https://api.github.com/repos/dotnet/coreclr/subscribers","subscription_url":"https://api.github.com/repos/dotnet/coreclr/subscription","commits_url":"https://api.github.com/repos/dotnet/coreclr/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/coreclr/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/coreclr/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/coreclr/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/coreclr/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/coreclr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/coreclr/merges","archive_url":"https://api.github.com/repos/dotnet/coreclr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/coreclr/downloads","issues_url":"https://api.github.com/repos/dotnet/coreclr/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/coreclr/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/coreclr/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/coreclr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/coreclr/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/coreclr/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/coreclr/deployments","created_at":"2015-01-30T22:10:02Z","updated_at":"2018-11-15T18:43:27Z","pushed_at":"2018-11-15T19:20:06Z","git_url":"git://github.com/dotnet/coreclr.git","ssh_url":"[email protected]:dotnet/coreclr.git","clone_url":"https://github.com/dotnet/coreclr.git","svn_url":"https://github.com/dotnet/coreclr","homepage":"https://github.com/dotnet/core","size":253954,"stargazers_count":10502,"watchers_count":10502,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2503,"mirror_url":null,"archived":false,"open_issues_count":2017,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2503,"open_issues":2017,"watchers":10502,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/21030"},"html":{"href":"https://github.com/dotnet/coreclr/pull/21030"},"issue":{"href":"https://api.github.com/repos/dotnet/coreclr/issues/21030"},"comments":{"href":"https://api.github.com/repos/dotnet/coreclr/issues/21030/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/21030/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/21030/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/coreclr/statuses/802950b8a06c2a287e498316745f461708839d0a"}},"author_association":"NONE"}} | {
"id": 30092893,
"name": "dotnet/coreclr",
"url": "https://api.github.com/repos/dotnet/coreclr"
} | {
"id": 7989549,
"login": "Tornhoof",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7989549?",
"url": "https://api.github.com/users/Tornhoof"
} | {
"id": 9141961,
"login": "dotnet",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9141961?",
"url": "https://api.github.com/orgs/dotnet"
} | 2018-11-15T19:21:24 | 8597656839 | {"actor":{"display_login":"Tornhoof"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/comments/217790089","pull_request_review_id":155594849,"id":217790089,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNzc5MDA4OQ==","diff_hunk":"@@ -571,6 +569,18 @@ Namespace Microsoft.CodeAnalysis.VisualBasic.Syntax.InternalSyntax\n tList.Add(MakeWhiteSpaceTrivia(GetText(Here - 1)))\n End If\n \n+ If foundComment Then\n+ Dim comment As SyntaxTrivia = ScanComment()\n+ If Not CheckFeatureAvailability(Feature.CommentsAfterLineContinuation) Then\n+ comment = comment.WithDiagnostics({ErrorFactory.ErrorInfo(ERRID.ERR_CommentsAfterLineContinuationNotAvailable1,\n+ New VisualBasicRequiredLanguageVersion(Feature.CommentsAfterLineContinuation.GetLanguageVersion()))})\n+ End If\n+ tList.Add(comment)\n+ ' Need to call CanGet here to prevent Peek reading past EndOfBuffer. This can happen when file ends with comment but no New Line.\n+ ch = If(CanGet(), Peek(), ChrW(0))","path":"src/Compilers/VisualBasic/Portable/Scanner/Scanner.vb","position":60,"original_position":60,"commit_id":"c80b476b483aa496bb6554b0166ff7ccacea9dac","original_commit_id":"c80b476b483aa496bb6554b0166ff7ccacea9dac","user":{"login":"paul1956","id":12789369,"node_id":"MDQ6VXNlcjEyNzg5MzY5","avatar_url":"https://avatars1.githubusercontent.com/u/12789369?v=4","gravatar_id":"","url":"https://api.github.com/users/paul1956","html_url":"https://github.com/paul1956","followers_url":"https://api.github.com/users/paul1956/followers","following_url":"https://api.github.com/users/paul1956/following{/other_user}","gists_url":"https://api.github.com/users/paul1956/gists{/gist_id}","starred_url":"https://api.github.com/users/paul1956/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paul1956/subscriptions","organizations_url":"https://api.github.com/users/paul1956/orgs","repos_url":"https://api.github.com/users/paul1956/repos","events_url":"https://api.github.com/users/paul1956/events{/privacy}","received_events_url":"https://api.github.com/users/paul1956/received_events","type":"User","site_admin":false},"body":"I was having same conversion with Julien both work, I thought this is shorter, happy to change.","created_at":"2018-09-14T17:41:49Z","updated_at":"2018-09-14T17:41:49Z","html_url":"https://github.com/dotnet/roslyn/pull/28327#discussion_r217790089","pull_request_url":"https://api.github.com/repos/dotnet/roslyn/pulls/28327","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/comments/217790089"},"html":{"href":"https://github.com/dotnet/roslyn/pull/28327#discussion_r217790089"},"pull_request":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/28327"}},"in_reply_to_id":217788133},"pull_request":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/28327","id":199692472,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5NjkyNDcy","html_url":"https://github.com/dotnet/roslyn/pull/28327","diff_url":"https://github.com/dotnet/roslyn/pull/28327.diff","patch_url":"https://github.com/dotnet/roslyn/pull/28327.patch","issue_url":"https://api.github.com/repos/dotnet/roslyn/issues/28327","number":28327,"state":"open","locked":false,"title":"VB: Added support for line continuation comments","user":{"login":"paul1956","id":12789369,"node_id":"MDQ6VXNlcjEyNzg5MzY5","avatar_url":"https://avatars1.githubusercontent.com/u/12789369?v=4","gravatar_id":"","url":"https://api.github.com/users/paul1956","html_url":"https://github.com/paul1956","followers_url":"https://api.github.com/users/paul1956/followers","following_url":"https://api.github.com/users/paul1956/following{/other_user}","gists_url":"https://api.github.com/users/paul1956/gists{/gist_id}","starred_url":"https://api.github.com/users/paul1956/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paul1956/subscriptions","organizations_url":"https://api.github.com/users/paul1956/orgs","repos_url":"https://api.github.com/users/paul1956/repos","events_url":"https://api.github.com/users/paul1956/events{/privacy}","received_events_url":"https://api.github.com/users/paul1956/received_events","type":"User","site_admin":false},"body":"<details><summary>Ask Mode template not completed</summary>\r\n\r\n<!-- This template is not always required. If you aren't sure about whether it's needed or want help filling out the sections,\r\nsubmit the pull request and then ask us for help. :) -->\r\n\r\n### Customer scenario\r\n\r\nIt is very useful to place comments in more places and specifically after a explicate continuation character, for example after an Attribute or before a period \r\n\r\n### Bugs this fixes\r\nNone, new feature\r\n(either VSO or GitHub links)\r\n\r\n### Workarounds, if any\r\nPut comments farther away from the code they refer to.\r\n### Risk\r\nThe change involves a very small change to the scanner, a update to test that currently fail when a comment is after an _ plus 2 new tests. The code looks for a very specific pattern of \"_ '\" or it never gets used.\r\n\r\nThis is generally a measure our how central the affected code is to adjacent\r\nscenarios and thus how likely your fix is to destabilize a broader area of code\r\n\r\n### Performance impact\r\nI added one extra if statement, when there is an explicate line continuation so impact will be small.\r\n\r\n### Is this a regression from a previous update?\r\nno\r\n### Root cause analysis\r\nThis is a new feature but much of the infrastructure anticipated this feature and it is unclear to me why it was left out. \r\nHow did we miss it? What tests are we adding to guard against it in the future?\r\nIt was not missed, some decided to not support this feature.\r\n### How was the bug found?\r\nNot a but, a new feature\r\n\r\n### Test documentation updated?\r\n\r\nIf this is a new non-compiler feature or a significant improvement to an existing feature, update https://github.com/dotnet/roslyn/wiki/Manual-Testing once you know which release it is targeting.\r\n\r\nIt might be good to update some of the error messages that currently say this is not allowed to say how to use the feature. For Example \"_'\" is an error that could say use \"_ '\"\r\n\r\n</details>\r\n","created_at":"2018-07-06T09:26:45Z","updated_at":"2018-09-14T17:41:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ba3cbde80eb4a8e2709580658c1fcdf7d195074b","assignee":{"login":"jcouv","id":12466233,"node_id":"MDQ6VXNlcjEyNDY2MjMz","avatar_url":"https://avatars2.githubusercontent.com/u/12466233?v=4","gravatar_id":"","url":"https://api.github.com/users/jcouv","html_url":"https://github.com/jcouv","followers_url":"https://api.github.com/users/jcouv/followers","following_url":"https://api.github.com/users/jcouv/following{/other_user}","gists_url":"https://api.github.com/users/jcouv/gists{/gist_id}","starred_url":"https://api.github.com/users/jcouv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcouv/subscriptions","organizations_url":"https://api.github.com/users/jcouv/orgs","repos_url":"https://api.github.com/users/jcouv/repos","events_url":"https://api.github.com/users/jcouv/events{/privacy}","received_events_url":"https://api.github.com/users/jcouv/received_events","type":"User","site_admin":false},"assignees":[{"login":"jcouv","id":12466233,"node_id":"MDQ6VXNlcjEyNDY2MjMz","avatar_url":"https://avatars2.githubusercontent.com/u/12466233?v=4","gravatar_id":"","url":"https://api.github.com/users/jcouv","html_url":"https://github.com/jcouv","followers_url":"https://api.github.com/users/jcouv/followers","following_url":"https://api.github.com/users/jcouv/following{/other_user}","gists_url":"https://api.github.com/users/jcouv/gists{/gist_id}","starred_url":"https://api.github.com/users/jcouv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcouv/subscriptions","organizations_url":"https://api.github.com/users/jcouv/orgs","repos_url":"https://api.github.com/users/jcouv/repos","events_url":"https://api.github.com/users/jcouv/events{/privacy}","received_events_url":"https://api.github.com/users/jcouv/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[{"name":"roslyn-ide","id":1781706,"node_id":"MDQ6VGVhbTE3ODE3MDY=","slug":"roslyn-ide","description":"Roslyn IDE Team","privacy":"closed","url":"https://api.github.com/teams/1781706","members_url":"https://api.github.com/teams/1781706/members{/member}","repositories_url":"https://api.github.com/teams/1781706/repos","permission":"pull"},{"name":"roslyn-interactive","id":1803183,"node_id":"MDQ6VGVhbTE4MDMxODM=","slug":"roslyn-interactive","description":"C# & VB Interactive (scripting, debugging, etc)","privacy":"closed","url":"https://api.github.com/teams/1803183","members_url":"https://api.github.com/teams/1803183/members{/member}","repositories_url":"https://api.github.com/teams/1803183/repos","permission":"pull"},{"name":"roslyn-infrastructure","id":1823403,"node_id":"MDQ6VGVhbTE4MjM0MDM=","slug":"roslyn-infrastructure","description":"Permanent and temporary Roslyn infrastructure swat team members","privacy":"closed","url":"https://api.github.com/teams/1823403","members_url":"https://api.github.com/teams/1823403/members{/member}","repositories_url":"https://api.github.com/teams/1823403/repos","permission":"pull"}],"labels":[{"id":166673288,"node_id":"MDU6TGFiZWwxNjY2NzMyODg=","url":"https://api.github.com/repos/dotnet/roslyn/labels/Area-Compilers","name":"Area-Compilers","color":"5319e7","default":false},{"id":288147422,"node_id":"MDU6TGFiZWwyODgxNDc0MjI=","url":"https://api.github.com/repos/dotnet/roslyn/labels/Community","name":"Community","color":"0e8a16","default":false},{"id":166377961,"node_id":"MDU6TGFiZWwxNjYzNzc5NjE=","url":"https://api.github.com/repos/dotnet/roslyn/labels/Language-VB","name":"Language-VB","color":"1d76db","default":false}],"milestone":{"url":"https://api.github.com/repos/dotnet/roslyn/milestones/18","html_url":"https://github.com/dotnet/roslyn/milestone/18","labels_url":"https://api.github.com/repos/dotnet/roslyn/milestones/18/labels","id":1675130,"node_id":"MDk6TWlsZXN0b25lMTY3NTEzMA==","number":18,"title":"16.0","description":"The version *after* the next major version.","creator":{"login":"gafter","id":3804346,"node_id":"MDQ6VXNlcjM4MDQzNDY=","avatar_url":"https://avatars3.githubusercontent.com/u/3804346?v=4","gravatar_id":"","url":"https://api.github.com/users/gafter","html_url":"https://github.com/gafter","followers_url":"https://api.github.com/users/gafter/followers","following_url":"https://api.github.com/users/gafter/following{/other_user}","gists_url":"https://api.github.com/users/gafter/gists{/gist_id}","starred_url":"https://api.github.com/users/gafter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gafter/subscriptions","organizations_url":"https://api.github.com/users/gafter/orgs","repos_url":"https://api.github.com/users/gafter/repos","events_url":"https://api.github.com/users/gafter/events{/privacy}","received_events_url":"https://api.github.com/users/gafter/received_events","type":"User","site_admin":false},"open_issues":1148,"closed_issues":649,"state":"open","created_at":"2016-03-31T00:06:25Z","updated_at":"2018-09-14T08:04:56Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/dotnet/roslyn/pulls/28327/commits","review_comments_url":"https://api.github.com/repos/dotnet/roslyn/pulls/28327/comments","review_comment_url":"https://api.github.com/repos/dotnet/roslyn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/roslyn/issues/28327/comments","statuses_url":"https://api.github.com/repos/dotnet/roslyn/statuses/c80b476b483aa496bb6554b0166ff7ccacea9dac","head":{"label":"paul1956:vblang-65","ref":"vblang-65","sha":"c80b476b483aa496bb6554b0166ff7ccacea9dac","user":{"login":"paul1956","id":12789369,"node_id":"MDQ6VXNlcjEyNzg5MzY5","avatar_url":"https://avatars1.githubusercontent.com/u/12789369?v=4","gravatar_id":"","url":"https://api.github.com/users/paul1956","html_url":"https://github.com/paul1956","followers_url":"https://api.github.com/users/paul1956/followers","following_url":"https://api.github.com/users/paul1956/following{/other_user}","gists_url":"https://api.github.com/users/paul1956/gists{/gist_id}","starred_url":"https://api.github.com/users/paul1956/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paul1956/subscriptions","organizations_url":"https://api.github.com/users/paul1956/orgs","repos_url":"https://api.github.com/users/paul1956/repos","events_url":"https://api.github.com/users/paul1956/events{/privacy}","received_events_url":"https://api.github.com/users/paul1956/received_events","type":"User","site_admin":false},"repo":{"id":38217872,"node_id":"MDEwOlJlcG9zaXRvcnkzODIxNzg3Mg==","name":"roslyn","full_name":"paul1956/roslyn","owner":{"login":"paul1956","id":12789369,"node_id":"MDQ6VXNlcjEyNzg5MzY5","avatar_url":"https://avatars1.githubusercontent.com/u/12789369?v=4","gravatar_id":"","url":"https://api.github.com/users/paul1956","html_url":"https://github.com/paul1956","followers_url":"https://api.github.com/users/paul1956/followers","following_url":"https://api.github.com/users/paul1956/following{/other_user}","gists_url":"https://api.github.com/users/paul1956/gists{/gist_id}","starred_url":"https://api.github.com/users/paul1956/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paul1956/subscriptions","organizations_url":"https://api.github.com/users/paul1956/orgs","repos_url":"https://api.github.com/users/paul1956/repos","events_url":"https://api.github.com/users/paul1956/events{/privacy}","received_events_url":"https://api.github.com/users/paul1956/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/paul1956/roslyn","description":"The .NET Compiler Platform (\"Roslyn\") provides open-source C# and Visual Basic compilers with rich code analysis APIs.","fork":true,"url":"https://api.github.com/repos/paul1956/roslyn","forks_url":"https://api.github.com/repos/paul1956/roslyn/forks","keys_url":"https://api.github.com/repos/paul1956/roslyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/paul1956/roslyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/paul1956/roslyn/teams","hooks_url":"https://api.github.com/repos/paul1956/roslyn/hooks","issue_events_url":"https://api.github.com/repos/paul1956/roslyn/issues/events{/number}","events_url":"https://api.github.com/repos/paul1956/roslyn/events","assignees_url":"https://api.github.com/repos/paul1956/roslyn/assignees{/user}","branches_url":"https://api.github.com/repos/paul1956/roslyn/branches{/branch}","tags_url":"https://api.github.com/repos/paul1956/roslyn/tags","blobs_url":"https://api.github.com/repos/paul1956/roslyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/paul1956/roslyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/paul1956/roslyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/paul1956/roslyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/paul1956/roslyn/statuses/{sha}","languages_url":"https://api.github.com/repos/paul1956/roslyn/languages","stargazers_url":"https://api.github.com/repos/paul1956/roslyn/stargazers","contributors_url":"https://api.github.com/repos/paul1956/roslyn/contributors","subscribers_url":"https://api.github.com/repos/paul1956/roslyn/subscribers","subscription_url":"https://api.github.com/repos/paul1956/roslyn/subscription","commits_url":"https://api.github.com/repos/paul1956/roslyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/paul1956/roslyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/paul1956/roslyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/paul1956/roslyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/paul1956/roslyn/contents/{+path}","compare_url":"https://api.github.com/repos/paul1956/roslyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/paul1956/roslyn/merges","archive_url":"https://api.github.com/repos/paul1956/roslyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/paul1956/roslyn/downloads","issues_url":"https://api.github.com/repos/paul1956/roslyn/issues{/number}","pulls_url":"https://api.github.com/repos/paul1956/roslyn/pulls{/number}","milestones_url":"https://api.github.com/repos/paul1956/roslyn/milestones{/number}","notifications_url":"https://api.github.com/repos/paul1956/roslyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/paul1956/roslyn/labels{/name}","releases_url":"https://api.github.com/repos/paul1956/roslyn/releases{/id}","deployments_url":"https://api.github.com/repos/paul1956/roslyn/deployments","created_at":"2015-06-28T23:18:10Z","updated_at":"2018-07-09T03:46:18Z","pushed_at":"2018-09-14T17:26:58Z","git_url":"git://github.com/paul1956/roslyn.git","ssh_url":"[email protected]:paul1956/roslyn.git","clone_url":"https://github.com/paul1956/roslyn.git","svn_url":"https://github.com/paul1956/roslyn","homepage":"","size":350489,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:features/continuation-comments","ref":"features/continuation-comments","sha":"80149cc70309ad3beb8bd3d9a37e4bda04bcf9b0","user":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":29078997,"node_id":"MDEwOlJlcG9zaXRvcnkyOTA3ODk5Nw==","name":"roslyn","full_name":"dotnet/roslyn","owner":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/roslyn","description":"The .NET Compiler Platform (\"Roslyn\") provides open-source C# and Visual Basic compilers with rich code analysis APIs.","fork":false,"url":"https://api.github.com/repos/dotnet/roslyn","forks_url":"https://api.github.com/repos/dotnet/roslyn/forks","keys_url":"https://api.github.com/repos/dotnet/roslyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/roslyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/roslyn/teams","hooks_url":"https://api.github.com/repos/dotnet/roslyn/hooks","issue_events_url":"https://api.github.com/repos/dotnet/roslyn/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/roslyn/events","assignees_url":"https://api.github.com/repos/dotnet/roslyn/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/roslyn/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/roslyn/tags","blobs_url":"https://api.github.com/repos/dotnet/roslyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/roslyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/roslyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/roslyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/roslyn/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/roslyn/languages","stargazers_url":"https://api.github.com/repos/dotnet/roslyn/stargazers","contributors_url":"https://api.github.com/repos/dotnet/roslyn/contributors","subscribers_url":"https://api.github.com/repos/dotnet/roslyn/subscribers","subscription_url":"https://api.github.com/repos/dotnet/roslyn/subscription","commits_url":"https://api.github.com/repos/dotnet/roslyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/roslyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/roslyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/roslyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/roslyn/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/roslyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/roslyn/merges","archive_url":"https://api.github.com/repos/dotnet/roslyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/roslyn/downloads","issues_url":"https://api.github.com/repos/dotnet/roslyn/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/roslyn/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/roslyn/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/roslyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/roslyn/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/roslyn/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/roslyn/deployments","created_at":"2015-01-11T02:39:03Z","updated_at":"2018-09-14T17:21:56Z","pushed_at":"2018-09-14T17:40:27Z","git_url":"git://github.com/dotnet/roslyn.git","ssh_url":"[email protected]:dotnet/roslyn.git","clone_url":"https://github.com/dotnet/roslyn.git","svn_url":"https://github.com/dotnet/roslyn","homepage":"","size":447861,"stargazers_count":9839,"watchers_count":9839,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2345,"mirror_url":null,"archived":false,"open_issues_count":5091,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2345,"open_issues":5091,"watchers":9839,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/28327"},"html":{"href":"https://github.com/dotnet/roslyn/pull/28327"},"issue":{"href":"https://api.github.com/repos/dotnet/roslyn/issues/28327"},"comments":{"href":"https://api.github.com/repos/dotnet/roslyn/issues/28327/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/28327/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/28327/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/roslyn/statuses/c80b476b483aa496bb6554b0166ff7ccacea9dac"}},"author_association":"NONE"}} | {
"id": 29078997,
"name": "dotnet/roslyn",
"url": "https://api.github.com/repos/dotnet/roslyn"
} | {
"id": 12789369,
"login": "paul1956",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/12789369?",
"url": "https://api.github.com/users/paul1956"
} | {
"id": 9141961,
"login": "dotnet",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9141961?",
"url": "https://api.github.com/orgs/dotnet"
} | 2018-09-14T17:41:49 | 8267513304 | {"actor":{"display_login":"paul1956"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/comments/224537366","pull_request_review_id":163930827,"id":224537366,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNDUzNzM2Ng==","diff_hunk":"@@ -0,0 +1,149 @@\n+// Copyright (c) Microsoft. All Rights Reserved. Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information. \n+\n+using System;\n+using Microsoft.CodeAnalysis.CSharp.Syntax;\n+using Microsoft.CodeAnalysis.CodeActions;\n+using System.Linq;\n+using Microsoft.CodeAnalysis.Formatting;\n+\n+namespace Microsoft.CodeAnalysis.CSharp.CodeRefactorings.PushMemberUp\n+{\n+ internal abstract class AbstractMemberPusher\n+ {\n+ protected string Title { get; }\n+\n+ protected INamedTypeSymbol TargetTypeSymbol { get; }\n+\n+ protected SyntaxNode TargetSyntaxNode { get; }\n+\n+ protected SemanticModel SemanticModel { get; }\n+\n+ protected SyntaxNode UserSelectedNode { get; }\n+\n+ protected Document ContextDocument { get; }\n+\n+ internal AbstractMemberPusher(\n+ INamedTypeSymbol targetTypeSymbol,\n+ SemanticModel semanticModel,\n+ SyntaxNode userSelectedNode,\n+ Document contextDocument)\n+ {\n+ Title = $\"Add to {targetTypeSymbol.Name}\";\n+ TargetTypeSymbol = targetTypeSymbol;\n+ TargetSyntaxNode = TargetTypeSymbol.DeclaringSyntaxReferences.First().GetSyntax();\n+ SemanticModel = semanticModel;\n+ UserSelectedNode = userSelectedNode;\n+ ContextDocument = contextDocument;\n+ }\n+\n+ protected virtual bool IsOrdinaryMethod(MethodDeclarationSyntax methodNode)\n+ {\n+ return SemanticModel.GetDeclaredSymbol(methodNode).MethodKind == MethodKind.Ordinary;\n+ }\n+\n+ protected virtual MemberDeclarationSyntax GeneratePushUpMemberAndFormatting(MemberDeclarationSyntax memberDeclarationSyntax, VariableDeclaratorSyntax variableDeclaratorSyntax = null)\n+ {\n+ // variableDeclaratorNode is not null means it is field or event\n+ SyntaxAnnotation[] formatter = { Formatter.Annotation };\n+ return CreateMemberPushUpSyntax(memberDeclarationSyntax, variableDeclaratorSyntax).WithAdditionalAnnotations(formatter);\n+ }\n+\n+ protected virtual BaseFieldDeclarationSyntax FindFieldAndEventDeclaration(VariableDeclaratorSyntax variableDeclaratorNode)\n+ {\n+ return variableDeclaratorNode.Ancestors().OfType<BaseFieldDeclarationSyntax>().First();","path":"src/Features/CSharp/Portable/CodeRefactorings/PushMemberUp/AbstractMemberPusher.cs","position":53,"original_position":53,"commit_id":"14765bf0f6c6fd05f0196d1b4d6958afe531a18c","original_commit_id":"14765bf0f6c6fd05f0196d1b4d6958afe531a18c","user":{"login":"CyrusNajmabadi","id":4564579,"node_id":"MDQ6VXNlcjQ1NjQ1Nzk=","avatar_url":"https://avatars3.githubusercontent.com/u/4564579?v=4","gravatar_id":"","url":"https://api.github.com/users/CyrusNajmabadi","html_url":"https://github.com/CyrusNajmabadi","followers_url":"https://api.github.com/users/CyrusNajmabadi/followers","following_url":"https://api.github.com/users/CyrusNajmabadi/following{/other_user}","gists_url":"https://api.github.com/users/CyrusNajmabadi/gists{/gist_id}","starred_url":"https://api.github.com/users/CyrusNajmabadi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CyrusNajmabadi/subscriptions","organizations_url":"https://api.github.com/users/CyrusNajmabadi/orgs","repos_url":"https://api.github.com/users/CyrusNajmabadi/repos","events_url":"https://api.github.com/users/CyrusNajmabadi/events{/privacy}","received_events_url":"https://api.github.com/users/CyrusNajmabadi/received_events","type":"User","site_admin":false},"body":"this worries me in case a variable declarator is not in a field/event.","created_at":"2018-10-11T17:33:05Z","updated_at":"2018-10-11T17:33:05Z","html_url":"https://github.com/dotnet/roslyn/pull/30254#discussion_r224537366","pull_request_url":"https://api.github.com/repos/dotnet/roslyn/pulls/30254","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/comments/224537366"},"html":{"href":"https://github.com/dotnet/roslyn/pull/30254#discussion_r224537366"},"pull_request":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/30254"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/30254","id":219550938,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5NTUwOTM4","html_url":"https://github.com/dotnet/roslyn/pull/30254","diff_url":"https://github.com/dotnet/roslyn/pull/30254.diff","patch_url":"https://github.com/dotnet/roslyn/pull/30254.patch","issue_url":"https://api.github.com/repos/dotnet/roslyn/issues/30254","number":30254,"state":"open","locked":false,"title":"(WIP)Push Members Up","user":{"login":"Cosifne","id":24360909,"node_id":"MDQ6VXNlcjI0MzYwOTA5","avatar_url":"https://avatars2.githubusercontent.com/u/24360909?v=4","gravatar_id":"","url":"https://api.github.com/users/Cosifne","html_url":"https://github.com/Cosifne","followers_url":"https://api.github.com/users/Cosifne/followers","following_url":"https://api.github.com/users/Cosifne/following{/other_user}","gists_url":"https://api.github.com/users/Cosifne/gists{/gist_id}","starred_url":"https://api.github.com/users/Cosifne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cosifne/subscriptions","organizations_url":"https://api.github.com/users/Cosifne/orgs","repos_url":"https://api.github.com/users/Cosifne/repos","events_url":"https://api.github.com/users/Cosifne/events{/privacy}","received_events_url":"https://api.github.com/users/Cosifne/received_events","type":"User","site_admin":false},"body":"Related issue: [PushMemberUp/Down](https://github.com/dotnet/roslyn/issues/25145)\r\n\r\nA quick summary of the design (Since the issue page is a little bit messy):\r\n1. Use Quick Action enable user to do some quick refactoring. \r\n2. Create a dialog to provide more complex refactoring like changing the modifier, select multiple member and etc.\r\n\r\nThis contains the code and unit tests to provide push member up function in Quick Action for C#.\r\n\r\nI will continue to working on adding dialog to push member up. But I would like put this part here first to make sure there is no big problem.\r\n\r\n@CyrusNajmabadi @dotnet/roslyn-ide \r\nLooking forward for your advice\r\n","created_at":"2018-10-02T00:06:54Z","updated_at":"2018-10-11T17:33:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"01ac5025e228bac977b87af62a483132ce486d52","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[{"name":"roslyn-ide","id":1781706,"node_id":"MDQ6VGVhbTE3ODE3MDY=","slug":"roslyn-ide","description":"Roslyn IDE Team","privacy":"closed","url":"https://api.github.com/teams/1781706","members_url":"https://api.github.com/teams/1781706/members{/member}","repositories_url":"https://api.github.com/teams/1781706/repos","permission":"pull"}],"labels":[{"id":166377917,"node_id":"MDU6TGFiZWwxNjYzNzc5MTc=","url":"https://api.github.com/repos/dotnet/roslyn/labels/Area-IDE","name":"Area-IDE","color":"5319e7","default":false}],"milestone":{"url":"https://api.github.com/repos/dotnet/roslyn/milestones/36","html_url":"https://github.com/dotnet/roslyn/milestone/36","labels_url":"https://api.github.com/repos/dotnet/roslyn/milestones/36/labels","id":3663714,"node_id":"MDk6TWlsZXN0b25lMzY2MzcxNA==","number":36,"title":"16.0.P2","description":"","creator":{"login":"jinujoseph","id":12449387,"node_id":"MDQ6VXNlcjEyNDQ5Mzg3","avatar_url":"https://avatars3.githubusercontent.com/u/12449387?v=4","gravatar_id":"","url":"https://api.github.com/users/jinujoseph","html_url":"https://github.com/jinujoseph","followers_url":"https://api.github.com/users/jinujoseph/followers","following_url":"https://api.github.com/users/jinujoseph/following{/other_user}","gists_url":"https://api.github.com/users/jinujoseph/gists{/gist_id}","starred_url":"https://api.github.com/users/jinujoseph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jinujoseph/subscriptions","organizations_url":"https://api.github.com/users/jinujoseph/orgs","repos_url":"https://api.github.com/users/jinujoseph/repos","events_url":"https://api.github.com/users/jinujoseph/events{/privacy}","received_events_url":"https://api.github.com/users/jinujoseph/received_events","type":"User","site_admin":false},"open_issues":30,"closed_issues":14,"state":"open","created_at":"2018-09-18T00:39:12Z","updated_at":"2018-10-11T13:44:19Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/dotnet/roslyn/pulls/30254/commits","review_comments_url":"https://api.github.com/repos/dotnet/roslyn/pulls/30254/comments","review_comment_url":"https://api.github.com/repos/dotnet/roslyn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/roslyn/issues/30254/comments","statuses_url":"https://api.github.com/repos/dotnet/roslyn/statuses/14765bf0f6c6fd05f0196d1b4d6958afe531a18c","head":{"label":"Cosifne:shech/push_member","ref":"shech/push_member","sha":"14765bf0f6c6fd05f0196d1b4d6958afe531a18c","user":{"login":"Cosifne","id":24360909,"node_id":"MDQ6VXNlcjI0MzYwOTA5","avatar_url":"https://avatars2.githubusercontent.com/u/24360909?v=4","gravatar_id":"","url":"https://api.github.com/users/Cosifne","html_url":"https://github.com/Cosifne","followers_url":"https://api.github.com/users/Cosifne/followers","following_url":"https://api.github.com/users/Cosifne/following{/other_user}","gists_url":"https://api.github.com/users/Cosifne/gists{/gist_id}","starred_url":"https://api.github.com/users/Cosifne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cosifne/subscriptions","organizations_url":"https://api.github.com/users/Cosifne/orgs","repos_url":"https://api.github.com/users/Cosifne/repos","events_url":"https://api.github.com/users/Cosifne/events{/privacy}","received_events_url":"https://api.github.com/users/Cosifne/received_events","type":"User","site_admin":false},"repo":{"id":151172631,"node_id":"MDEwOlJlcG9zaXRvcnkxNTExNzI2MzE=","name":"roslyn","full_name":"Cosifne/roslyn","private":false,"owner":{"login":"Cosifne","id":24360909,"node_id":"MDQ6VXNlcjI0MzYwOTA5","avatar_url":"https://avatars2.githubusercontent.com/u/24360909?v=4","gravatar_id":"","url":"https://api.github.com/users/Cosifne","html_url":"https://github.com/Cosifne","followers_url":"https://api.github.com/users/Cosifne/followers","following_url":"https://api.github.com/users/Cosifne/following{/other_user}","gists_url":"https://api.github.com/users/Cosifne/gists{/gist_id}","starred_url":"https://api.github.com/users/Cosifne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cosifne/subscriptions","organizations_url":"https://api.github.com/users/Cosifne/orgs","repos_url":"https://api.github.com/users/Cosifne/repos","events_url":"https://api.github.com/users/Cosifne/events{/privacy}","received_events_url":"https://api.github.com/users/Cosifne/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Cosifne/roslyn","description":"The .NET Compiler Platform (\"Roslyn\") provides open-source C# and Visual Basic compilers with rich code analysis APIs.","fork":true,"url":"https://api.github.com/repos/Cosifne/roslyn","forks_url":"https://api.github.com/repos/Cosifne/roslyn/forks","keys_url":"https://api.github.com/repos/Cosifne/roslyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Cosifne/roslyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Cosifne/roslyn/teams","hooks_url":"https://api.github.com/repos/Cosifne/roslyn/hooks","issue_events_url":"https://api.github.com/repos/Cosifne/roslyn/issues/events{/number}","events_url":"https://api.github.com/repos/Cosifne/roslyn/events","assignees_url":"https://api.github.com/repos/Cosifne/roslyn/assignees{/user}","branches_url":"https://api.github.com/repos/Cosifne/roslyn/branches{/branch}","tags_url":"https://api.github.com/repos/Cosifne/roslyn/tags","blobs_url":"https://api.github.com/repos/Cosifne/roslyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Cosifne/roslyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Cosifne/roslyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/Cosifne/roslyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Cosifne/roslyn/statuses/{sha}","languages_url":"https://api.github.com/repos/Cosifne/roslyn/languages","stargazers_url":"https://api.github.com/repos/Cosifne/roslyn/stargazers","contributors_url":"https://api.github.com/repos/Cosifne/roslyn/contributors","subscribers_url":"https://api.github.com/repos/Cosifne/roslyn/subscribers","subscription_url":"https://api.github.com/repos/Cosifne/roslyn/subscription","commits_url":"https://api.github.com/repos/Cosifne/roslyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/Cosifne/roslyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/Cosifne/roslyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/Cosifne/roslyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/Cosifne/roslyn/contents/{+path}","compare_url":"https://api.github.com/repos/Cosifne/roslyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Cosifne/roslyn/merges","archive_url":"https://api.github.com/repos/Cosifne/roslyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Cosifne/roslyn/downloads","issues_url":"https://api.github.com/repos/Cosifne/roslyn/issues{/number}","pulls_url":"https://api.github.com/repos/Cosifne/roslyn/pulls{/number}","milestones_url":"https://api.github.com/repos/Cosifne/roslyn/milestones{/number}","notifications_url":"https://api.github.com/repos/Cosifne/roslyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Cosifne/roslyn/labels{/name}","releases_url":"https://api.github.com/repos/Cosifne/roslyn/releases{/id}","deployments_url":"https://api.github.com/repos/Cosifne/roslyn/deployments","created_at":"2018-10-01T23:07:49Z","updated_at":"2018-10-01T23:08:34Z","pushed_at":"2018-10-10T05:13:44Z","git_url":"git://github.com/Cosifne/roslyn.git","ssh_url":"[email protected]:Cosifne/roslyn.git","clone_url":"https://github.com/Cosifne/roslyn.git","svn_url":"https://github.com/Cosifne/roslyn","homepage":"","size":458967,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"6a0523be64b13acc2a1a400ee78f0fde1c9c4f77","user":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":29078997,"node_id":"MDEwOlJlcG9zaXRvcnkyOTA3ODk5Nw==","name":"roslyn","full_name":"dotnet/roslyn","private":false,"owner":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dotnet/roslyn","description":"The .NET Compiler Platform (\"Roslyn\") provides open-source C# and Visual Basic compilers with rich code analysis APIs.","fork":false,"url":"https://api.github.com/repos/dotnet/roslyn","forks_url":"https://api.github.com/repos/dotnet/roslyn/forks","keys_url":"https://api.github.com/repos/dotnet/roslyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/roslyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/roslyn/teams","hooks_url":"https://api.github.com/repos/dotnet/roslyn/hooks","issue_events_url":"https://api.github.com/repos/dotnet/roslyn/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/roslyn/events","assignees_url":"https://api.github.com/repos/dotnet/roslyn/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/roslyn/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/roslyn/tags","blobs_url":"https://api.github.com/repos/dotnet/roslyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/roslyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/roslyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/roslyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/roslyn/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/roslyn/languages","stargazers_url":"https://api.github.com/repos/dotnet/roslyn/stargazers","contributors_url":"https://api.github.com/repos/dotnet/roslyn/contributors","subscribers_url":"https://api.github.com/repos/dotnet/roslyn/subscribers","subscription_url":"https://api.github.com/repos/dotnet/roslyn/subscription","commits_url":"https://api.github.com/repos/dotnet/roslyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/roslyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/roslyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/roslyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/roslyn/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/roslyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/roslyn/merges","archive_url":"https://api.github.com/repos/dotnet/roslyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/roslyn/downloads","issues_url":"https://api.github.com/repos/dotnet/roslyn/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/roslyn/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/roslyn/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/roslyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/roslyn/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/roslyn/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/roslyn/deployments","created_at":"2015-01-11T02:39:03Z","updated_at":"2018-10-11T16:24:19Z","pushed_at":"2018-10-11T17:09:52Z","git_url":"git://github.com/dotnet/roslyn.git","ssh_url":"[email protected]:dotnet/roslyn.git","clone_url":"https://github.com/dotnet/roslyn.git","svn_url":"https://github.com/dotnet/roslyn","homepage":"","size":462002,"stargazers_count":10163,"watchers_count":10163,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2415,"mirror_url":null,"archived":false,"open_issues_count":5323,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2415,"open_issues":5323,"watchers":10163,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/30254"},"html":{"href":"https://github.com/dotnet/roslyn/pull/30254"},"issue":{"href":"https://api.github.com/repos/dotnet/roslyn/issues/30254"},"comments":{"href":"https://api.github.com/repos/dotnet/roslyn/issues/30254/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/30254/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/30254/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/roslyn/statuses/14765bf0f6c6fd05f0196d1b4d6958afe531a18c"}},"author_association":"NONE"}} | {
"id": 29078997,
"name": "dotnet/roslyn",
"url": "https://api.github.com/repos/dotnet/roslyn"
} | {
"id": 4564579,
"login": "CyrusNajmabadi",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4564579?",
"url": "https://api.github.com/users/CyrusNajmabadi"
} | {
"id": 9141961,
"login": "dotnet",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9141961?",
"url": "https://api.github.com/orgs/dotnet"
} | 2018-10-11T17:33:05 | 8406300868 | {"actor":{"display_login":"CyrusNajmabadi"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/NervanaSystems/ngraph-tf/pulls/comments/202525997","pull_request_review_id":137249457,"id":202525997,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMjUyNTk5Nw==","diff_hunk":"@@ -104,4 +106,30 @@ TEST(tf_exec, axpy) {\n }\n }\n \n+// Test Op :\"Op_RealDiv\"\n+\n+TEST(tf_exec, Op_RealDiv) {\n+ tf::Scope root = tf::Scope::NewRootScope();\n+ root = root.WithDevice(\"/device:NGRAPH:0\");\n+\n+ auto A = tf::ops::Const(root, {{3.f, 5.f}, {2.f, 0.f}});\n+ auto B = tf::ops::Const(root, {{3.f, 2.f}, {.1f, 1.f}});\n+ auto r = tf::ops::RealDiv(root.WithOpName(\"r\"), A, B);\n+\n+ std::vector<tf::Tensor> outputs;\n+ tf::ClientSession session(root);\n+\n+ TF_CHECK_OK(session.Run({r}, &outputs));\n+ \n+ ASSERT_EQ(outputs[0].shape(), tf::TensorShape({2,2}));\n+ //ASSERT_EQ(outputs[0].shape(), A.shape());","path":"test/tf_exec.cpp","position":29,"original_position":29,"commit_id":"0062d826aee1eacc8b7ea79d27a3c96e13f4873c","original_commit_id":"0062d826aee1eacc8b7ea79d27a3c96e13f4873c","user":{"login":"avijit-nervana","id":30507445,"node_id":"MDQ6VXNlcjMwNTA3NDQ1","avatar_url":"https://avatars0.githubusercontent.com/u/30507445?v=4","gravatar_id":"","url":"https://api.github.com/users/avijit-nervana","html_url":"https://github.com/avijit-nervana","followers_url":"https://api.github.com/users/avijit-nervana/followers","following_url":"https://api.github.com/users/avijit-nervana/following{/other_user}","gists_url":"https://api.github.com/users/avijit-nervana/gists{/gist_id}","starred_url":"https://api.github.com/users/avijit-nervana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/avijit-nervana/subscriptions","organizations_url":"https://api.github.com/users/avijit-nervana/orgs","repos_url":"https://api.github.com/users/avijit-nervana/repos","events_url":"https://api.github.com/users/avijit-nervana/events{/privacy}","received_events_url":"https://api.github.com/users/avijit-nervana/received_events","type":"User","site_admin":false},"body":"Please remove the dead code (i.e., commented out code).","created_at":"2018-07-14T21:55:46Z","updated_at":"2018-07-14T21:56:36Z","html_url":"https://github.com/NervanaSystems/ngraph-tf/pull/80#discussion_r202525997","pull_request_url":"https://api.github.com/repos/NervanaSystems/ngraph-tf/pulls/80","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/NervanaSystems/ngraph-tf/pulls/comments/202525997"},"html":{"href":"https://github.com/NervanaSystems/ngraph-tf/pull/80#discussion_r202525997"},"pull_request":{"href":"https://api.github.com/repos/NervanaSystems/ngraph-tf/pulls/80"}}},"pull_request":{"url":"https://api.github.com/repos/NervanaSystems/ngraph-tf/pulls/80","id":201431607,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxNDMxNjA3","html_url":"https://github.com/NervanaSystems/ngraph-tf/pull/80","diff_url":"https://github.com/NervanaSystems/ngraph-tf/pull/80.diff","patch_url":"https://github.com/NervanaSystems/ngraph-tf/pull/80.patch","issue_url":"https://api.github.com/repos/NervanaSystems/ngraph-tf/issues/80","number":80,"state":"open","locked":false,"title":"Implemented Op RealDiv","user":{"login":"shresthamalik","id":20289882,"node_id":"MDQ6VXNlcjIwMjg5ODgy","avatar_url":"https://avatars3.githubusercontent.com/u/20289882?v=4","gravatar_id":"","url":"https://api.github.com/users/shresthamalik","html_url":"https://github.com/shresthamalik","followers_url":"https://api.github.com/users/shresthamalik/followers","following_url":"https://api.github.com/users/shresthamalik/following{/other_user}","gists_url":"https://api.github.com/users/shresthamalik/gists{/gist_id}","starred_url":"https://api.github.com/users/shresthamalik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shresthamalik/subscriptions","organizations_url":"https://api.github.com/users/shresthamalik/orgs","repos_url":"https://api.github.com/users/shresthamalik/repos","events_url":"https://api.github.com/users/shresthamalik/events{/privacy}","received_events_url":"https://api.github.com/users/shresthamalik/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-07-14T02:26:18Z","updated_at":"2018-07-14T21:56:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2e7a98b25e8684e23f231048786c12b548de2eb9","assignee":null,"assignees":[],"requested_reviewers":[{"login":"aprocter","id":680992,"node_id":"MDQ6VXNlcjY4MDk5Mg==","avatar_url":"https://avatars3.githubusercontent.com/u/680992?v=4","gravatar_id":"","url":"https://api.github.com/users/aprocter","html_url":"https://github.com/aprocter","followers_url":"https://api.github.com/users/aprocter/followers","following_url":"https://api.github.com/users/aprocter/following{/other_user}","gists_url":"https://api.github.com/users/aprocter/gists{/gist_id}","starred_url":"https://api.github.com/users/aprocter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aprocter/subscriptions","organizations_url":"https://api.github.com/users/aprocter/orgs","repos_url":"https://api.github.com/users/aprocter/repos","events_url":"https://api.github.com/users/aprocter/events{/privacy}","received_events_url":"https://api.github.com/users/aprocter/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/NervanaSystems/ngraph-tf/pulls/80/commits","review_comments_url":"https://api.github.com/repos/NervanaSystems/ngraph-tf/pulls/80/comments","review_comment_url":"https://api.github.com/repos/NervanaSystems/ngraph-tf/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NervanaSystems/ngraph-tf/issues/80/comments","statuses_url":"https://api.github.com/repos/NervanaSystems/ngraph-tf/statuses/0062d826aee1eacc8b7ea79d27a3c96e13f4873c","head":{"label":"NervanaSystems:shrestha/AddOp_RealDiv","ref":"shrestha/AddOp_RealDiv","sha":"0062d826aee1eacc8b7ea79d27a3c96e13f4873c","user":{"login":"NervanaSystems","id":9260121,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkyNjAxMjE=","avatar_url":"https://avatars2.githubusercontent.com/u/9260121?v=4","gravatar_id":"","url":"https://api.github.com/users/NervanaSystems","html_url":"https://github.com/NervanaSystems","followers_url":"https://api.github.com/users/NervanaSystems/followers","following_url":"https://api.github.com/users/NervanaSystems/following{/other_user}","gists_url":"https://api.github.com/users/NervanaSystems/gists{/gist_id}","starred_url":"https://api.github.com/users/NervanaSystems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NervanaSystems/subscriptions","organizations_url":"https://api.github.com/users/NervanaSystems/orgs","repos_url":"https://api.github.com/users/NervanaSystems/repos","events_url":"https://api.github.com/users/NervanaSystems/events{/privacy}","received_events_url":"https://api.github.com/users/NervanaSystems/received_events","type":"Organization","site_admin":false},"repo":{"id":133988684,"node_id":"MDEwOlJlcG9zaXRvcnkxMzM5ODg2ODQ=","name":"ngraph-tf","full_name":"NervanaSystems/ngraph-tf","owner":{"login":"NervanaSystems","id":9260121,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkyNjAxMjE=","avatar_url":"https://avatars2.githubusercontent.com/u/9260121?v=4","gravatar_id":"","url":"https://api.github.com/users/NervanaSystems","html_url":"https://github.com/NervanaSystems","followers_url":"https://api.github.com/users/NervanaSystems/followers","following_url":"https://api.github.com/users/NervanaSystems/following{/other_user}","gists_url":"https://api.github.com/users/NervanaSystems/gists{/gist_id}","starred_url":"https://api.github.com/users/NervanaSystems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NervanaSystems/subscriptions","organizations_url":"https://api.github.com/users/NervanaSystems/orgs","repos_url":"https://api.github.com/users/NervanaSystems/repos","events_url":"https://api.github.com/users/NervanaSystems/events{/privacy}","received_events_url":"https://api.github.com/users/NervanaSystems/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NervanaSystems/ngraph-tf","description":"Bridge to connect nGraph with TensorFlow","fork":false,"url":"https://api.github.com/repos/NervanaSystems/ngraph-tf","forks_url":"https://api.github.com/repos/NervanaSystems/ngraph-tf/forks","keys_url":"https://api.github.com/repos/NervanaSystems/ngraph-tf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NervanaSystems/ngraph-tf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NervanaSystems/ngraph-tf/teams","hooks_url":"https://api.github.com/repos/NervanaSystems/ngraph-tf/hooks","issue_events_url":"https://api.github.com/repos/NervanaSystems/ngraph-tf/issues/events{/number}","events_url":"https://api.github.com/repos/NervanaSystems/ngraph-tf/events","assignees_url":"https://api.github.com/repos/NervanaSystems/ngraph-tf/assignees{/user}","branches_url":"https://api.github.com/repos/NervanaSystems/ngraph-tf/branches{/branch}","tags_url":"https://api.github.com/repos/NervanaSystems/ngraph-tf/tags","blobs_url":"https://api.github.com/repos/NervanaSystems/ngraph-tf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NervanaSystems/ngraph-tf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NervanaSystems/ngraph-tf/git/refs{/sha}","trees_url":"https://api.github.com/repos/NervanaSystems/ngraph-tf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NervanaSystems/ngraph-tf/statuses/{sha}","languages_url":"https://api.github.com/repos/NervanaSystems/ngraph-tf/languages","stargazers_url":"https://api.github.com/repos/NervanaSystems/ngraph-tf/stargazers","contributors_url":"https://api.github.com/repos/NervanaSystems/ngraph-tf/contributors","subscribers_url":"https://api.github.com/repos/NervanaSystems/ngraph-tf/subscribers","subscription_url":"https://api.github.com/repos/NervanaSystems/ngraph-tf/subscription","commits_url":"https://api.github.com/repos/NervanaSystems/ngraph-tf/commits{/sha}","git_commits_url":"https://api.github.com/repos/NervanaSystems/ngraph-tf/git/commits{/sha}","comments_url":"https://api.github.com/repos/NervanaSystems/ngraph-tf/comments{/number}","issue_comment_url":"https://api.github.com/repos/NervanaSystems/ngraph-tf/issues/comments{/number}","contents_url":"https://api.github.com/repos/NervanaSystems/ngraph-tf/contents/{+path}","compare_url":"https://api.github.com/repos/NervanaSystems/ngraph-tf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NervanaSystems/ngraph-tf/merges","archive_url":"https://api.github.com/repos/NervanaSystems/ngraph-tf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NervanaSystems/ngraph-tf/downloads","issues_url":"https://api.github.com/repos/NervanaSystems/ngraph-tf/issues{/number}","pulls_url":"https://api.github.com/repos/NervanaSystems/ngraph-tf/pulls{/number}","milestones_url":"https://api.github.com/repos/NervanaSystems/ngraph-tf/milestones{/number}","notifications_url":"https://api.github.com/repos/NervanaSystems/ngraph-tf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NervanaSystems/ngraph-tf/labels{/name}","releases_url":"https://api.github.com/repos/NervanaSystems/ngraph-tf/releases{/id}","deployments_url":"https://api.github.com/repos/NervanaSystems/ngraph-tf/deployments","created_at":"2018-05-18T18:08:43Z","updated_at":"2018-07-12T22:23:13Z","pushed_at":"2018-07-14T02:26:18Z","git_url":"git://github.com/NervanaSystems/ngraph-tf.git","ssh_url":"[email protected]:NervanaSystems/ngraph-tf.git","clone_url":"https://github.com/NervanaSystems/ngraph-tf.git","svn_url":"https://github.com/NervanaSystems/ngraph-tf","homepage":"","size":1367,"stargazers_count":21,"watchers_count":21,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":11,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":11,"watchers":21,"default_branch":"master"}},"base":{"label":"NervanaSystems:master","ref":"master","sha":"0c02408365f5ede65498d8d7b1b9cc8bd16d3b24","user":{"login":"NervanaSystems","id":9260121,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkyNjAxMjE=","avatar_url":"https://avatars2.githubusercontent.com/u/9260121?v=4","gravatar_id":"","url":"https://api.github.com/users/NervanaSystems","html_url":"https://github.com/NervanaSystems","followers_url":"https://api.github.com/users/NervanaSystems/followers","following_url":"https://api.github.com/users/NervanaSystems/following{/other_user}","gists_url":"https://api.github.com/users/NervanaSystems/gists{/gist_id}","starred_url":"https://api.github.com/users/NervanaSystems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NervanaSystems/subscriptions","organizations_url":"https://api.github.com/users/NervanaSystems/orgs","repos_url":"https://api.github.com/users/NervanaSystems/repos","events_url":"https://api.github.com/users/NervanaSystems/events{/privacy}","received_events_url":"https://api.github.com/users/NervanaSystems/received_events","type":"Organization","site_admin":false},"repo":{"id":133988684,"node_id":"MDEwOlJlcG9zaXRvcnkxMzM5ODg2ODQ=","name":"ngraph-tf","full_name":"NervanaSystems/ngraph-tf","owner":{"login":"NervanaSystems","id":9260121,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkyNjAxMjE=","avatar_url":"https://avatars2.githubusercontent.com/u/9260121?v=4","gravatar_id":"","url":"https://api.github.com/users/NervanaSystems","html_url":"https://github.com/NervanaSystems","followers_url":"https://api.github.com/users/NervanaSystems/followers","following_url":"https://api.github.com/users/NervanaSystems/following{/other_user}","gists_url":"https://api.github.com/users/NervanaSystems/gists{/gist_id}","starred_url":"https://api.github.com/users/NervanaSystems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NervanaSystems/subscriptions","organizations_url":"https://api.github.com/users/NervanaSystems/orgs","repos_url":"https://api.github.com/users/NervanaSystems/repos","events_url":"https://api.github.com/users/NervanaSystems/events{/privacy}","received_events_url":"https://api.github.com/users/NervanaSystems/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NervanaSystems/ngraph-tf","description":"Bridge to connect nGraph with TensorFlow","fork":false,"url":"https://api.github.com/repos/NervanaSystems/ngraph-tf","forks_url":"https://api.github.com/repos/NervanaSystems/ngraph-tf/forks","keys_url":"https://api.github.com/repos/NervanaSystems/ngraph-tf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NervanaSystems/ngraph-tf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NervanaSystems/ngraph-tf/teams","hooks_url":"https://api.github.com/repos/NervanaSystems/ngraph-tf/hooks","issue_events_url":"https://api.github.com/repos/NervanaSystems/ngraph-tf/issues/events{/number}","events_url":"https://api.github.com/repos/NervanaSystems/ngraph-tf/events","assignees_url":"https://api.github.com/repos/NervanaSystems/ngraph-tf/assignees{/user}","branches_url":"https://api.github.com/repos/NervanaSystems/ngraph-tf/branches{/branch}","tags_url":"https://api.github.com/repos/NervanaSystems/ngraph-tf/tags","blobs_url":"https://api.github.com/repos/NervanaSystems/ngraph-tf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NervanaSystems/ngraph-tf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NervanaSystems/ngraph-tf/git/refs{/sha}","trees_url":"https://api.github.com/repos/NervanaSystems/ngraph-tf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NervanaSystems/ngraph-tf/statuses/{sha}","languages_url":"https://api.github.com/repos/NervanaSystems/ngraph-tf/languages","stargazers_url":"https://api.github.com/repos/NervanaSystems/ngraph-tf/stargazers","contributors_url":"https://api.github.com/repos/NervanaSystems/ngraph-tf/contributors","subscribers_url":"https://api.github.com/repos/NervanaSystems/ngraph-tf/subscribers","subscription_url":"https://api.github.com/repos/NervanaSystems/ngraph-tf/subscription","commits_url":"https://api.github.com/repos/NervanaSystems/ngraph-tf/commits{/sha}","git_commits_url":"https://api.github.com/repos/NervanaSystems/ngraph-tf/git/commits{/sha}","comments_url":"https://api.github.com/repos/NervanaSystems/ngraph-tf/comments{/number}","issue_comment_url":"https://api.github.com/repos/NervanaSystems/ngraph-tf/issues/comments{/number}","contents_url":"https://api.github.com/repos/NervanaSystems/ngraph-tf/contents/{+path}","compare_url":"https://api.github.com/repos/NervanaSystems/ngraph-tf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NervanaSystems/ngraph-tf/merges","archive_url":"https://api.github.com/repos/NervanaSystems/ngraph-tf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NervanaSystems/ngraph-tf/downloads","issues_url":"https://api.github.com/repos/NervanaSystems/ngraph-tf/issues{/number}","pulls_url":"https://api.github.com/repos/NervanaSystems/ngraph-tf/pulls{/number}","milestones_url":"https://api.github.com/repos/NervanaSystems/ngraph-tf/milestones{/number}","notifications_url":"https://api.github.com/repos/NervanaSystems/ngraph-tf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NervanaSystems/ngraph-tf/labels{/name}","releases_url":"https://api.github.com/repos/NervanaSystems/ngraph-tf/releases{/id}","deployments_url":"https://api.github.com/repos/NervanaSystems/ngraph-tf/deployments","created_at":"2018-05-18T18:08:43Z","updated_at":"2018-07-12T22:23:13Z","pushed_at":"2018-07-14T02:26:18Z","git_url":"git://github.com/NervanaSystems/ngraph-tf.git","ssh_url":"[email protected]:NervanaSystems/ngraph-tf.git","clone_url":"https://github.com/NervanaSystems/ngraph-tf.git","svn_url":"https://github.com/NervanaSystems/ngraph-tf","homepage":"","size":1367,"stargazers_count":21,"watchers_count":21,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":11,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":11,"watchers":21,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NervanaSystems/ngraph-tf/pulls/80"},"html":{"href":"https://github.com/NervanaSystems/ngraph-tf/pull/80"},"issue":{"href":"https://api.github.com/repos/NervanaSystems/ngraph-tf/issues/80"},"comments":{"href":"https://api.github.com/repos/NervanaSystems/ngraph-tf/issues/80/comments"},"review_comments":{"href":"https://api.github.com/repos/NervanaSystems/ngraph-tf/pulls/80/comments"},"review_comment":{"href":"https://api.github.com/repos/NervanaSystems/ngraph-tf/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NervanaSystems/ngraph-tf/pulls/80/commits"},"statuses":{"href":"https://api.github.com/repos/NervanaSystems/ngraph-tf/statuses/0062d826aee1eacc8b7ea79d27a3c96e13f4873c"}},"author_association":"NONE"}} | {
"id": 133988684,
"name": "NervanaSystems/ngraph-tf",
"url": "https://api.github.com/repos/NervanaSystems/ngraph-tf"
} | {
"id": 30507445,
"login": "avijit-nervana",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/30507445?",
"url": "https://api.github.com/users/avijit-nervana"
} | {
"id": 9260121,
"login": "NervanaSystems",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9260121?",
"url": "https://api.github.com/orgs/NervanaSystems"
} | 2018-07-14T21:55:46 | 7966423508 | {"actor":{"display_login":"avijit-nervana"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/NervanaSystems/ngraph/pulls/comments/192841523","pull_request_review_id":125695711,"id":192841523,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5Mjg0MTUyMw==","diff_hunk":"@@ -269,51 +293,126 @@ CUDNN_SAFE_CALL(cudnnSetOpTensorDescriptor(opTensorDesc,\n \"with data dilation is not implemented.\");\n }\n }\n- for (int i = 0; i < padding.size(); i++)\n+ bool pad_required = false;\n+ if (padding_below != padding_above)\n {\n- if (padding[i] != padding_above[i])\n- {\n- throw std::runtime_error(node->get_name() +\n- \"with asymmetric padding is not implemented.\");\n- }\n+ pad_required = true;\n+ }\n+ auto output_shape = out[0].get_shape();\n+ auto output_shape_padded = output_shape;\n+ Shape padding_below_back(output_shape.size(), 0);\n+ size_t i = padding_below_back.size() - padding_below.size();\n+ size_t j = 0;\n+ for (; i < padding_below_back.size(); i++)\n+ {\n+ padding_below_back[i] = padding_below[j++];\n }\n \n writer.block_begin(\" // \" + node->get_name());\n- writer << \"float alpha = 1.0;\\n\";\n- writer << \"float beta = 0.0;\\n\";\n-\n- // construct input and output tensor descriptor\n- kernel::emit_cudnnFilterDescriptor(\n- writer, args0, tensor_format, data_type, args[0].get_shape());\n- kernel::emit_cudnnTensorDescriptor(\n- writer, args1, tensor_format, data_type, args[1].get_shape());\n- kernel::emit_cudnnTensorDescriptor(\n- writer, out0, tensor_format, data_type, out[0].get_shape());\n- kernel::emit_cudnnConvolutionDescriptor(writer,\n- conv_descriptor,\n- padding,\n- window_movement_strides,\n- window_dilation_strides,\n- mode,\n- data_type);\n-\n- writer << \"size_t workSpaceSizeInBytes = 0;\\n\";\n- writer << \"CUDNN_SAFE_CALL(cudnnGetConvolutionBackwardDataWorkspaceSize(*ctx->\"\n- \"cudnn_handle, \"\n- << args0 << \", \" << args1 << \", \" << conv_descriptor << \", \" << out0 << \", \"\n- << conv_algo << \", \"\n- << \"&workSpaceSizeInBytes));\\n\";\n-\n- writer << \"void* workspace = \"\n- \"runtime::gpu::create_gpu_buffer(workSpaceSizeInBytes);\\n\";\n-\n- writer << \"CUDNN_SAFE_CALL(cudnnConvolutionBackwardData(*ctx->cudnn_handle, \"\n- << \"&alpha, \" << args0 << \", \" << args[0].get_name() << \", \" << args1 << \", \"\n- << args[1].get_name() << \", \" << conv_descriptor << \", \" << conv_algo << \", \"\n- << \"workspace, workSpaceSizeInBytes, \"\n- << \"&beta, \" << out0 << \", \" << out[0].get_name() << \"));\\n\";\n-\n- writer << \"runtime::gpu::free_gpu_buffer(workspace);\\n\";\n+ if (pad_required)\n+ {\n+ output_shape_padded =\n+ get_padded_shape(output_shape, padding_below, padding_above, {});\n+ auto temp_size =\n+ shape_size(output_shape_padded) * args[0].get_element_type().size();\n+ GPUAllocator allocator =\n+ external_function->get_primitive_emitter()->get_memory_allocator();\n+ size_t idx_workspace = allocator.reserve_workspace(temp_size);\n+ writer << \"void* pad_buffer = runtime::gpu::invoke_memory_primitive(ctx, \"\n+ << idx_workspace << \");\\n\";\n+ auto& cuda_emitter =\n+ external_function->get_primitive_emitter()->get_cuda_emitter();\n+ auto pad_index =\n+ cuda_emitter->build_pad(external_function->ctx().get(),\n+ {{args[0].get_type(), out[0].get_type()}},\n+ output_shape,\n+ output_shape_padded,\n+ padding_below,\n+ padding_above,\n+ Shape{},\n+ std::string(\"0\"));\n+\n+ writer << \"gpu::invoke_primitive(ctx, \" << pad_index << \", \";\n+ writer << \"std::vector<void*>{\" << out[0].get_name() << \"}.data(), \";\n+ writer << \"std::vector<void*>{pad_buffer}.data()\";\n+ writer << \");\\n\";\n+ // asymetric padding has been applied, zero out padding vectors to\n+ // ensure cudnn does not assume padding\n+ std::fill(padding_below.begin(), padding_below.end(), 0);\n+ std::fill(padding_above.begin(), padding_above.end(), 0);\n+ }\n+\n+ auto& cudnn_emitter =\n+ external_function->get_primitive_emitter()->get_cudnn_emitter();\n+\n+ cudnnDataType_t data_type = CUDNN_DATA_FLOAT;\n+ size_t index = cudnn_emitter->build_convolution(external_function->ctx().get(),\n+ data_type,\n+ CUDNNEmitter::Prop::Backward,\n+ args[1].get_shape(),\n+ args[0].get_shape(),\n+ output_shape_padded,\n+ window_movement_strides,\n+ window_dilation_strides,\n+ padding_below);\n+\n+ writer << \"gpu::invoke_primitive(ctx, \" << index << \", \";\n+ writer << \"std::vector<void*>{\" << args[0].get_name() << \",\" << args[1].get_name()\n+ << \"}.data(), \";\n+\n+ if (pad_required)\n+ {\n+ writer << \"std::vector<void*>{pad_buffer}.data()\";\n+ }\n+ else\n+ {\n+ writer << \"std::vector<void*>{\" << out[0].get_name() << \"}.data()\";\n+ }\n+ writer << \");\\n\";\n+\n+ // since we paadded output with another buffer, we neec to copy back to ouput","path":"src/ngraph/runtime/gpu/gpu_emitter.cpp","position":308,"original_position":308,"commit_id":"a1ecca579c92c30d722858e3c9aa807bcf855389","original_commit_id":"a1ecca579c92c30d722858e3c9aa807bcf855389","user":{"login":"csullivan","id":4804563,"node_id":"MDQ6VXNlcjQ4MDQ1NjM=","avatar_url":"https://avatars1.githubusercontent.com/u/4804563?v=4","gravatar_id":"","url":"https://api.github.com/users/csullivan","html_url":"https://github.com/csullivan","followers_url":"https://api.github.com/users/csullivan/followers","following_url":"https://api.github.com/users/csullivan/following{/other_user}","gists_url":"https://api.github.com/users/csullivan/gists{/gist_id}","starred_url":"https://api.github.com/users/csullivan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/csullivan/subscriptions","organizations_url":"https://api.github.com/users/csullivan/orgs","repos_url":"https://api.github.com/users/csullivan/repos","events_url":"https://api.github.com/users/csullivan/events{/privacy}","received_events_url":"https://api.github.com/users/csullivan/received_events","type":"User","site_admin":false},"body":"Small typo in comment.","created_at":"2018-06-04T18:41:37Z","updated_at":"2018-06-04T18:48:15Z","html_url":"https://github.com/NervanaSystems/ngraph/pull/1064#discussion_r192841523","pull_request_url":"https://api.github.com/repos/NervanaSystems/ngraph/pulls/1064","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/NervanaSystems/ngraph/pulls/comments/192841523"},"html":{"href":"https://github.com/NervanaSystems/ngraph/pull/1064#discussion_r192841523"},"pull_request":{"href":"https://api.github.com/repos/NervanaSystems/ngraph/pulls/1064"}}},"pull_request":{"url":"https://api.github.com/repos/NervanaSystems/ngraph/pulls/1064","id":191853449,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkxODUzNDQ5","html_url":"https://github.com/NervanaSystems/ngraph/pull/1064","diff_url":"https://github.com/NervanaSystems/ngraph/pull/1064.diff","patch_url":"https://github.com/NervanaSystems/ngraph/pull/1064.patch","issue_url":"https://api.github.com/repos/NervanaSystems/ngraph/issues/1064","number":1064,"state":"open","locked":false,"title":"gpu convolution asymmetric pad","user":{"login":"fengleitian","id":35274053,"node_id":"MDQ6VXNlcjM1Mjc0MDUz","avatar_url":"https://avatars3.githubusercontent.com/u/35274053?v=4","gravatar_id":"","url":"https://api.github.com/users/fengleitian","html_url":"https://github.com/fengleitian","followers_url":"https://api.github.com/users/fengleitian/followers","following_url":"https://api.github.com/users/fengleitian/following{/other_user}","gists_url":"https://api.github.com/users/fengleitian/gists{/gist_id}","starred_url":"https://api.github.com/users/fengleitian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fengleitian/subscriptions","organizations_url":"https://api.github.com/users/fengleitian/orgs","repos_url":"https://api.github.com/users/fengleitian/repos","events_url":"https://api.github.com/users/fengleitian/events{/privacy}","received_events_url":"https://api.github.com/users/fengleitian/received_events","type":"User","site_admin":false},"body":"This PR add asymmetric padding to Convolution, ConvolutionBackpropData, and ConvolutionBackpropFilter.\r\n1. Refactor the code to avoid emit and compile at runtime.\r\n2. Check and add asymmetric padding.\r\n3. enable convolution test with asymmetric padding.","created_at":"2018-05-31T19:38:59Z","updated_at":"2018-06-04T18:48:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8360d4377a3b7950114eeea4b6c693dacf668dc5","assignee":null,"assignees":[],"requested_reviewers":[{"login":"rkimballn1","id":19153694,"node_id":"MDQ6VXNlcjE5MTUzNjk0","avatar_url":"https://avatars2.githubusercontent.com/u/19153694?v=4","gravatar_id":"","url":"https://api.github.com/users/rkimballn1","html_url":"https://github.com/rkimballn1","followers_url":"https://api.github.com/users/rkimballn1/followers","following_url":"https://api.github.com/users/rkimballn1/following{/other_user}","gists_url":"https://api.github.com/users/rkimballn1/gists{/gist_id}","starred_url":"https://api.github.com/users/rkimballn1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rkimballn1/subscriptions","organizations_url":"https://api.github.com/users/rkimballn1/orgs","repos_url":"https://api.github.com/users/rkimballn1/repos","events_url":"https://api.github.com/users/rkimballn1/events{/privacy}","received_events_url":"https://api.github.com/users/rkimballn1/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":825174556,"node_id":"MDU6TGFiZWw4MjUxNzQ1NTY=","url":"https://api.github.com/repos/NervanaSystems/ngraph/labels/GPU","name":"GPU","color":"3956cc","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/NervanaSystems/ngraph/pulls/1064/commits","review_comments_url":"https://api.github.com/repos/NervanaSystems/ngraph/pulls/1064/comments","review_comment_url":"https://api.github.com/repos/NervanaSystems/ngraph/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NervanaSystems/ngraph/issues/1064/comments","statuses_url":"https://api.github.com/repos/NervanaSystems/ngraph/statuses/a1ecca579c92c30d722858e3c9aa807bcf855389","head":{"label":"NervanaSystems:tfl/gpu_convolution_asymmetric_pad","ref":"tfl/gpu_convolution_asymmetric_pad","sha":"a1ecca579c92c30d722858e3c9aa807bcf855389","user":{"login":"NervanaSystems","id":9260121,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkyNjAxMjE=","avatar_url":"https://avatars2.githubusercontent.com/u/9260121?v=4","gravatar_id":"","url":"https://api.github.com/users/NervanaSystems","html_url":"https://github.com/NervanaSystems","followers_url":"https://api.github.com/users/NervanaSystems/followers","following_url":"https://api.github.com/users/NervanaSystems/following{/other_user}","gists_url":"https://api.github.com/users/NervanaSystems/gists{/gist_id}","starred_url":"https://api.github.com/users/NervanaSystems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NervanaSystems/subscriptions","organizations_url":"https://api.github.com/users/NervanaSystems/orgs","repos_url":"https://api.github.com/users/NervanaSystems/repos","events_url":"https://api.github.com/users/NervanaSystems/events{/privacy}","received_events_url":"https://api.github.com/users/NervanaSystems/received_events","type":"Organization","site_admin":false},"repo":{"id":98252973,"node_id":"MDEwOlJlcG9zaXRvcnk5ODI1Mjk3Mw==","name":"ngraph","full_name":"NervanaSystems/ngraph","owner":{"login":"NervanaSystems","id":9260121,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkyNjAxMjE=","avatar_url":"https://avatars2.githubusercontent.com/u/9260121?v=4","gravatar_id":"","url":"https://api.github.com/users/NervanaSystems","html_url":"https://github.com/NervanaSystems","followers_url":"https://api.github.com/users/NervanaSystems/followers","following_url":"https://api.github.com/users/NervanaSystems/following{/other_user}","gists_url":"https://api.github.com/users/NervanaSystems/gists{/gist_id}","starred_url":"https://api.github.com/users/NervanaSystems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NervanaSystems/subscriptions","organizations_url":"https://api.github.com/users/NervanaSystems/orgs","repos_url":"https://api.github.com/users/NervanaSystems/repos","events_url":"https://api.github.com/users/NervanaSystems/events{/privacy}","received_events_url":"https://api.github.com/users/NervanaSystems/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NervanaSystems/ngraph","description":"nGraph is an open source C++ library, compiler and runtime for Deep Learning frameworks","fork":false,"url":"https://api.github.com/repos/NervanaSystems/ngraph","forks_url":"https://api.github.com/repos/NervanaSystems/ngraph/forks","keys_url":"https://api.github.com/repos/NervanaSystems/ngraph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NervanaSystems/ngraph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NervanaSystems/ngraph/teams","hooks_url":"https://api.github.com/repos/NervanaSystems/ngraph/hooks","issue_events_url":"https://api.github.com/repos/NervanaSystems/ngraph/issues/events{/number}","events_url":"https://api.github.com/repos/NervanaSystems/ngraph/events","assignees_url":"https://api.github.com/repos/NervanaSystems/ngraph/assignees{/user}","branches_url":"https://api.github.com/repos/NervanaSystems/ngraph/branches{/branch}","tags_url":"https://api.github.com/repos/NervanaSystems/ngraph/tags","blobs_url":"https://api.github.com/repos/NervanaSystems/ngraph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NervanaSystems/ngraph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NervanaSystems/ngraph/git/refs{/sha}","trees_url":"https://api.github.com/repos/NervanaSystems/ngraph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NervanaSystems/ngraph/statuses/{sha}","languages_url":"https://api.github.com/repos/NervanaSystems/ngraph/languages","stargazers_url":"https://api.github.com/repos/NervanaSystems/ngraph/stargazers","contributors_url":"https://api.github.com/repos/NervanaSystems/ngraph/contributors","subscribers_url":"https://api.github.com/repos/NervanaSystems/ngraph/subscribers","subscription_url":"https://api.github.com/repos/NervanaSystems/ngraph/subscription","commits_url":"https://api.github.com/repos/NervanaSystems/ngraph/commits{/sha}","git_commits_url":"https://api.github.com/repos/NervanaSystems/ngraph/git/commits{/sha}","comments_url":"https://api.github.com/repos/NervanaSystems/ngraph/comments{/number}","issue_comment_url":"https://api.github.com/repos/NervanaSystems/ngraph/issues/comments{/number}","contents_url":"https://api.github.com/repos/NervanaSystems/ngraph/contents/{+path}","compare_url":"https://api.github.com/repos/NervanaSystems/ngraph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NervanaSystems/ngraph/merges","archive_url":"https://api.github.com/repos/NervanaSystems/ngraph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NervanaSystems/ngraph/downloads","issues_url":"https://api.github.com/repos/NervanaSystems/ngraph/issues{/number}","pulls_url":"https://api.github.com/repos/NervanaSystems/ngraph/pulls{/number}","milestones_url":"https://api.github.com/repos/NervanaSystems/ngraph/milestones{/number}","notifications_url":"https://api.github.com/repos/NervanaSystems/ngraph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NervanaSystems/ngraph/labels{/name}","releases_url":"https://api.github.com/repos/NervanaSystems/ngraph/releases{/id}","deployments_url":"https://api.github.com/repos/NervanaSystems/ngraph/deployments","created_at":"2017-07-25T02:02:38Z","updated_at":"2018-06-04T17:34:48Z","pushed_at":"2018-06-04T18:33:51Z","git_url":"git://github.com/NervanaSystems/ngraph.git","ssh_url":"[email protected]:NervanaSystems/ngraph.git","clone_url":"https://github.com/NervanaSystems/ngraph.git","svn_url":"https://github.com/NervanaSystems/ngraph","homepage":"http://ngraph.nervanasys.com/docs/latest","size":31459,"stargazers_count":486,"watchers_count":486,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":45,"mirror_url":null,"archived":false,"open_issues_count":45,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":45,"open_issues":45,"watchers":486,"default_branch":"master"}},"base":{"label":"NervanaSystems:master","ref":"master","sha":"eef750dfb1f365ff6aaf49244f9543582a7fa74b","user":{"login":"NervanaSystems","id":9260121,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkyNjAxMjE=","avatar_url":"https://avatars2.githubusercontent.com/u/9260121?v=4","gravatar_id":"","url":"https://api.github.com/users/NervanaSystems","html_url":"https://github.com/NervanaSystems","followers_url":"https://api.github.com/users/NervanaSystems/followers","following_url":"https://api.github.com/users/NervanaSystems/following{/other_user}","gists_url":"https://api.github.com/users/NervanaSystems/gists{/gist_id}","starred_url":"https://api.github.com/users/NervanaSystems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NervanaSystems/subscriptions","organizations_url":"https://api.github.com/users/NervanaSystems/orgs","repos_url":"https://api.github.com/users/NervanaSystems/repos","events_url":"https://api.github.com/users/NervanaSystems/events{/privacy}","received_events_url":"https://api.github.com/users/NervanaSystems/received_events","type":"Organization","site_admin":false},"repo":{"id":98252973,"node_id":"MDEwOlJlcG9zaXRvcnk5ODI1Mjk3Mw==","name":"ngraph","full_name":"NervanaSystems/ngraph","owner":{"login":"NervanaSystems","id":9260121,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkyNjAxMjE=","avatar_url":"https://avatars2.githubusercontent.com/u/9260121?v=4","gravatar_id":"","url":"https://api.github.com/users/NervanaSystems","html_url":"https://github.com/NervanaSystems","followers_url":"https://api.github.com/users/NervanaSystems/followers","following_url":"https://api.github.com/users/NervanaSystems/following{/other_user}","gists_url":"https://api.github.com/users/NervanaSystems/gists{/gist_id}","starred_url":"https://api.github.com/users/NervanaSystems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NervanaSystems/subscriptions","organizations_url":"https://api.github.com/users/NervanaSystems/orgs","repos_url":"https://api.github.com/users/NervanaSystems/repos","events_url":"https://api.github.com/users/NervanaSystems/events{/privacy}","received_events_url":"https://api.github.com/users/NervanaSystems/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NervanaSystems/ngraph","description":"nGraph is an open source C++ library, compiler and runtime for Deep Learning frameworks","fork":false,"url":"https://api.github.com/repos/NervanaSystems/ngraph","forks_url":"https://api.github.com/repos/NervanaSystems/ngraph/forks","keys_url":"https://api.github.com/repos/NervanaSystems/ngraph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NervanaSystems/ngraph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NervanaSystems/ngraph/teams","hooks_url":"https://api.github.com/repos/NervanaSystems/ngraph/hooks","issue_events_url":"https://api.github.com/repos/NervanaSystems/ngraph/issues/events{/number}","events_url":"https://api.github.com/repos/NervanaSystems/ngraph/events","assignees_url":"https://api.github.com/repos/NervanaSystems/ngraph/assignees{/user}","branches_url":"https://api.github.com/repos/NervanaSystems/ngraph/branches{/branch}","tags_url":"https://api.github.com/repos/NervanaSystems/ngraph/tags","blobs_url":"https://api.github.com/repos/NervanaSystems/ngraph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NervanaSystems/ngraph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NervanaSystems/ngraph/git/refs{/sha}","trees_url":"https://api.github.com/repos/NervanaSystems/ngraph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NervanaSystems/ngraph/statuses/{sha}","languages_url":"https://api.github.com/repos/NervanaSystems/ngraph/languages","stargazers_url":"https://api.github.com/repos/NervanaSystems/ngraph/stargazers","contributors_url":"https://api.github.com/repos/NervanaSystems/ngraph/contributors","subscribers_url":"https://api.github.com/repos/NervanaSystems/ngraph/subscribers","subscription_url":"https://api.github.com/repos/NervanaSystems/ngraph/subscription","commits_url":"https://api.github.com/repos/NervanaSystems/ngraph/commits{/sha}","git_commits_url":"https://api.github.com/repos/NervanaSystems/ngraph/git/commits{/sha}","comments_url":"https://api.github.com/repos/NervanaSystems/ngraph/comments{/number}","issue_comment_url":"https://api.github.com/repos/NervanaSystems/ngraph/issues/comments{/number}","contents_url":"https://api.github.com/repos/NervanaSystems/ngraph/contents/{+path}","compare_url":"https://api.github.com/repos/NervanaSystems/ngraph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NervanaSystems/ngraph/merges","archive_url":"https://api.github.com/repos/NervanaSystems/ngraph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NervanaSystems/ngraph/downloads","issues_url":"https://api.github.com/repos/NervanaSystems/ngraph/issues{/number}","pulls_url":"https://api.github.com/repos/NervanaSystems/ngraph/pulls{/number}","milestones_url":"https://api.github.com/repos/NervanaSystems/ngraph/milestones{/number}","notifications_url":"https://api.github.com/repos/NervanaSystems/ngraph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NervanaSystems/ngraph/labels{/name}","releases_url":"https://api.github.com/repos/NervanaSystems/ngraph/releases{/id}","deployments_url":"https://api.github.com/repos/NervanaSystems/ngraph/deployments","created_at":"2017-07-25T02:02:38Z","updated_at":"2018-06-04T17:34:48Z","pushed_at":"2018-06-04T18:33:51Z","git_url":"git://github.com/NervanaSystems/ngraph.git","ssh_url":"[email protected]:NervanaSystems/ngraph.git","clone_url":"https://github.com/NervanaSystems/ngraph.git","svn_url":"https://github.com/NervanaSystems/ngraph","homepage":"http://ngraph.nervanasys.com/docs/latest","size":31459,"stargazers_count":486,"watchers_count":486,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":45,"mirror_url":null,"archived":false,"open_issues_count":45,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":45,"open_issues":45,"watchers":486,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NervanaSystems/ngraph/pulls/1064"},"html":{"href":"https://github.com/NervanaSystems/ngraph/pull/1064"},"issue":{"href":"https://api.github.com/repos/NervanaSystems/ngraph/issues/1064"},"comments":{"href":"https://api.github.com/repos/NervanaSystems/ngraph/issues/1064/comments"},"review_comments":{"href":"https://api.github.com/repos/NervanaSystems/ngraph/pulls/1064/comments"},"review_comment":{"href":"https://api.github.com/repos/NervanaSystems/ngraph/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NervanaSystems/ngraph/pulls/1064/commits"},"statuses":{"href":"https://api.github.com/repos/NervanaSystems/ngraph/statuses/a1ecca579c92c30d722858e3c9aa807bcf855389"}},"author_association":"CONTRIBUTOR"}} | {
"id": 98252973,
"name": "NervanaSystems/ngraph",
"url": "https://api.github.com/repos/NervanaSystems/ngraph"
} | {
"id": 4804563,
"login": "csullivan",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4804563?",
"url": "https://api.github.com/users/csullivan"
} | {
"id": 9260121,
"login": "NervanaSystems",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9260121?",
"url": "https://api.github.com/orgs/NervanaSystems"
} | 2018-06-04T18:41:37 | 7773685435 | {"actor":{"display_login":"csullivan"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/NervanaSystems/ngraph/pulls/comments/196690034","pull_request_review_id":130288992,"id":196690034,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NjY5MDAzNA==","diff_hunk":"@@ -84,6 +84,7 @@ include(var_functions)\n option(NGRAPH_UNIT_TEST_ENABLE \"Control the building of unit tests\" TRUE)\n option(NGRAPH_TOOLS_ENABLE \"Control the building of tool\" TRUE)\n option(NGRAPH_CPU_ENABLE \"Control the building of the CPU backend\" TRUE)\n+option(NGRAPH_INTELGPU_ENABLE \"Control the building of the CPU backend with clDNN\" TRUE)","path":"CMakeLists.txt","position":4,"original_position":4,"commit_id":"477d0b4d0ee2dffab1b05f75786165eb12110cec","original_commit_id":"477d0b4d0ee2dffab1b05f75786165eb12110cec","user":{"login":"shssf","id":19515906,"node_id":"MDQ6VXNlcjE5NTE1OTA2","avatar_url":"https://avatars2.githubusercontent.com/u/19515906?v=4","gravatar_id":"","url":"https://api.github.com/users/shssf","html_url":"https://github.com/shssf","followers_url":"https://api.github.com/users/shssf/followers","following_url":"https://api.github.com/users/shssf/following{/other_user}","gists_url":"https://api.github.com/users/shssf/gists{/gist_id}","starred_url":"https://api.github.com/users/shssf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shssf/subscriptions","organizations_url":"https://api.github.com/users/shssf/orgs","repos_url":"https://api.github.com/users/shssf/repos","events_url":"https://api.github.com/users/shssf/events{/privacy}","received_events_url":"https://api.github.com/users/shssf/received_events","type":"User","site_admin":false},"body":"I implement it as TRUE to involve the new code into regular build procedure for all other development work (in all incoming PRs). If we keep it switched FALSE it will be potentially broken by other development work due no regular build tests.\r\nAnyway, I will keep in FALSE as you like.","created_at":"2018-06-20T08:33:23Z","updated_at":"2018-06-20T08:33:23Z","html_url":"https://github.com/NervanaSystems/ngraph/pull/1116#discussion_r196690034","pull_request_url":"https://api.github.com/repos/NervanaSystems/ngraph/pulls/1116","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/NervanaSystems/ngraph/pulls/comments/196690034"},"html":{"href":"https://github.com/NervanaSystems/ngraph/pull/1116#discussion_r196690034"},"pull_request":{"href":"https://api.github.com/repos/NervanaSystems/ngraph/pulls/1116"}},"in_reply_to_id":196494112},"pull_request":{"url":"https://api.github.com/repos/NervanaSystems/ngraph/pulls/1116","id":195317512,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1MzE3NTEy","html_url":"https://github.com/NervanaSystems/ngraph/pull/1116","diff_url":"https://github.com/NervanaSystems/ngraph/pull/1116.diff","patch_url":"https://github.com/NervanaSystems/ngraph/pull/1116.patch","issue_url":"https://api.github.com/repos/NervanaSystems/ngraph/issues/1116","number":1116,"state":"open","locked":false,"title":"Backend/API: First IntelGPU backend based on clDNN with empty functions","user":{"login":"shssf","id":19515906,"node_id":"MDQ6VXNlcjE5NTE1OTA2","avatar_url":"https://avatars2.githubusercontent.com/u/19515906?v=4","gravatar_id":"","url":"https://api.github.com/users/shssf","html_url":"https://github.com/shssf","followers_url":"https://api.github.com/users/shssf/followers","following_url":"https://api.github.com/users/shssf/following{/other_user}","gists_url":"https://api.github.com/users/shssf/gists{/gist_id}","starred_url":"https://api.github.com/users/shssf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shssf/subscriptions","organizations_url":"https://api.github.com/users/shssf/orgs","repos_url":"https://api.github.com/users/shssf/repos","events_url":"https://api.github.com/users/shssf/events{/privacy}","received_events_url":"https://api.github.com/users/shssf/received_events","type":"User","site_admin":false},"body":"This is the first \"empty\" implementation of the backed which will use clDNN library.","created_at":"2018-06-16T04:58:31Z","updated_at":"2018-06-20T08:33:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f891114e4db4c6d32d72c880b35fb1c2ef9132f6","assignee":null,"assignees":[],"requested_reviewers":[{"login":"fengleitian","id":35274053,"node_id":"MDQ6VXNlcjM1Mjc0MDUz","avatar_url":"https://avatars3.githubusercontent.com/u/35274053?v=4","gravatar_id":"","url":"https://api.github.com/users/fengleitian","html_url":"https://github.com/fengleitian","followers_url":"https://api.github.com/users/fengleitian/followers","following_url":"https://api.github.com/users/fengleitian/following{/other_user}","gists_url":"https://api.github.com/users/fengleitian/gists{/gist_id}","starred_url":"https://api.github.com/users/fengleitian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fengleitian/subscriptions","organizations_url":"https://api.github.com/users/fengleitian/orgs","repos_url":"https://api.github.com/users/fengleitian/repos","events_url":"https://api.github.com/users/fengleitian/events{/privacy}","received_events_url":"https://api.github.com/users/fengleitian/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/NervanaSystems/ngraph/pulls/1116/commits","review_comments_url":"https://api.github.com/repos/NervanaSystems/ngraph/pulls/1116/comments","review_comment_url":"https://api.github.com/repos/NervanaSystems/ngraph/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NervanaSystems/ngraph/issues/1116/comments","statuses_url":"https://api.github.com/repos/NervanaSystems/ngraph/statuses/477d0b4d0ee2dffab1b05f75786165eb12110cec","head":{"label":"NervanaSystems:intelgpu_backend","ref":"intelgpu_backend","sha":"477d0b4d0ee2dffab1b05f75786165eb12110cec","user":{"login":"NervanaSystems","id":9260121,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkyNjAxMjE=","avatar_url":"https://avatars2.githubusercontent.com/u/9260121?v=4","gravatar_id":"","url":"https://api.github.com/users/NervanaSystems","html_url":"https://github.com/NervanaSystems","followers_url":"https://api.github.com/users/NervanaSystems/followers","following_url":"https://api.github.com/users/NervanaSystems/following{/other_user}","gists_url":"https://api.github.com/users/NervanaSystems/gists{/gist_id}","starred_url":"https://api.github.com/users/NervanaSystems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NervanaSystems/subscriptions","organizations_url":"https://api.github.com/users/NervanaSystems/orgs","repos_url":"https://api.github.com/users/NervanaSystems/repos","events_url":"https://api.github.com/users/NervanaSystems/events{/privacy}","received_events_url":"https://api.github.com/users/NervanaSystems/received_events","type":"Organization","site_admin":false},"repo":{"id":98252973,"node_id":"MDEwOlJlcG9zaXRvcnk5ODI1Mjk3Mw==","name":"ngraph","full_name":"NervanaSystems/ngraph","owner":{"login":"NervanaSystems","id":9260121,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkyNjAxMjE=","avatar_url":"https://avatars2.githubusercontent.com/u/9260121?v=4","gravatar_id":"","url":"https://api.github.com/users/NervanaSystems","html_url":"https://github.com/NervanaSystems","followers_url":"https://api.github.com/users/NervanaSystems/followers","following_url":"https://api.github.com/users/NervanaSystems/following{/other_user}","gists_url":"https://api.github.com/users/NervanaSystems/gists{/gist_id}","starred_url":"https://api.github.com/users/NervanaSystems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NervanaSystems/subscriptions","organizations_url":"https://api.github.com/users/NervanaSystems/orgs","repos_url":"https://api.github.com/users/NervanaSystems/repos","events_url":"https://api.github.com/users/NervanaSystems/events{/privacy}","received_events_url":"https://api.github.com/users/NervanaSystems/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NervanaSystems/ngraph","description":"nGraph is an open source C++ library, compiler and runtime for Deep Learning frameworks","fork":false,"url":"https://api.github.com/repos/NervanaSystems/ngraph","forks_url":"https://api.github.com/repos/NervanaSystems/ngraph/forks","keys_url":"https://api.github.com/repos/NervanaSystems/ngraph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NervanaSystems/ngraph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NervanaSystems/ngraph/teams","hooks_url":"https://api.github.com/repos/NervanaSystems/ngraph/hooks","issue_events_url":"https://api.github.com/repos/NervanaSystems/ngraph/issues/events{/number}","events_url":"https://api.github.com/repos/NervanaSystems/ngraph/events","assignees_url":"https://api.github.com/repos/NervanaSystems/ngraph/assignees{/user}","branches_url":"https://api.github.com/repos/NervanaSystems/ngraph/branches{/branch}","tags_url":"https://api.github.com/repos/NervanaSystems/ngraph/tags","blobs_url":"https://api.github.com/repos/NervanaSystems/ngraph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NervanaSystems/ngraph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NervanaSystems/ngraph/git/refs{/sha}","trees_url":"https://api.github.com/repos/NervanaSystems/ngraph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NervanaSystems/ngraph/statuses/{sha}","languages_url":"https://api.github.com/repos/NervanaSystems/ngraph/languages","stargazers_url":"https://api.github.com/repos/NervanaSystems/ngraph/stargazers","contributors_url":"https://api.github.com/repos/NervanaSystems/ngraph/contributors","subscribers_url":"https://api.github.com/repos/NervanaSystems/ngraph/subscribers","subscription_url":"https://api.github.com/repos/NervanaSystems/ngraph/subscription","commits_url":"https://api.github.com/repos/NervanaSystems/ngraph/commits{/sha}","git_commits_url":"https://api.github.com/repos/NervanaSystems/ngraph/git/commits{/sha}","comments_url":"https://api.github.com/repos/NervanaSystems/ngraph/comments{/number}","issue_comment_url":"https://api.github.com/repos/NervanaSystems/ngraph/issues/comments{/number}","contents_url":"https://api.github.com/repos/NervanaSystems/ngraph/contents/{+path}","compare_url":"https://api.github.com/repos/NervanaSystems/ngraph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NervanaSystems/ngraph/merges","archive_url":"https://api.github.com/repos/NervanaSystems/ngraph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NervanaSystems/ngraph/downloads","issues_url":"https://api.github.com/repos/NervanaSystems/ngraph/issues{/number}","pulls_url":"https://api.github.com/repos/NervanaSystems/ngraph/pulls{/number}","milestones_url":"https://api.github.com/repos/NervanaSystems/ngraph/milestones{/number}","notifications_url":"https://api.github.com/repos/NervanaSystems/ngraph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NervanaSystems/ngraph/labels{/name}","releases_url":"https://api.github.com/repos/NervanaSystems/ngraph/releases{/id}","deployments_url":"https://api.github.com/repos/NervanaSystems/ngraph/deployments","created_at":"2017-07-25T02:02:38Z","updated_at":"2018-06-20T00:49:41Z","pushed_at":"2018-06-20T06:21:40Z","git_url":"git://github.com/NervanaSystems/ngraph.git","ssh_url":"[email protected]:NervanaSystems/ngraph.git","clone_url":"https://github.com/NervanaSystems/ngraph.git","svn_url":"https://github.com/NervanaSystems/ngraph","homepage":"http://ngraph.nervanasys.com/docs/latest","size":31944,"stargazers_count":497,"watchers_count":497,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":51,"mirror_url":null,"archived":false,"open_issues_count":38,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":51,"open_issues":38,"watchers":497,"default_branch":"master"}},"base":{"label":"NervanaSystems:master","ref":"master","sha":"bdfcf5b439bf45e36443ca2a96e54af48e320e73","user":{"login":"NervanaSystems","id":9260121,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkyNjAxMjE=","avatar_url":"https://avatars2.githubusercontent.com/u/9260121?v=4","gravatar_id":"","url":"https://api.github.com/users/NervanaSystems","html_url":"https://github.com/NervanaSystems","followers_url":"https://api.github.com/users/NervanaSystems/followers","following_url":"https://api.github.com/users/NervanaSystems/following{/other_user}","gists_url":"https://api.github.com/users/NervanaSystems/gists{/gist_id}","starred_url":"https://api.github.com/users/NervanaSystems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NervanaSystems/subscriptions","organizations_url":"https://api.github.com/users/NervanaSystems/orgs","repos_url":"https://api.github.com/users/NervanaSystems/repos","events_url":"https://api.github.com/users/NervanaSystems/events{/privacy}","received_events_url":"https://api.github.com/users/NervanaSystems/received_events","type":"Organization","site_admin":false},"repo":{"id":98252973,"node_id":"MDEwOlJlcG9zaXRvcnk5ODI1Mjk3Mw==","name":"ngraph","full_name":"NervanaSystems/ngraph","owner":{"login":"NervanaSystems","id":9260121,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkyNjAxMjE=","avatar_url":"https://avatars2.githubusercontent.com/u/9260121?v=4","gravatar_id":"","url":"https://api.github.com/users/NervanaSystems","html_url":"https://github.com/NervanaSystems","followers_url":"https://api.github.com/users/NervanaSystems/followers","following_url":"https://api.github.com/users/NervanaSystems/following{/other_user}","gists_url":"https://api.github.com/users/NervanaSystems/gists{/gist_id}","starred_url":"https://api.github.com/users/NervanaSystems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NervanaSystems/subscriptions","organizations_url":"https://api.github.com/users/NervanaSystems/orgs","repos_url":"https://api.github.com/users/NervanaSystems/repos","events_url":"https://api.github.com/users/NervanaSystems/events{/privacy}","received_events_url":"https://api.github.com/users/NervanaSystems/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NervanaSystems/ngraph","description":"nGraph is an open source C++ library, compiler and runtime for Deep Learning frameworks","fork":false,"url":"https://api.github.com/repos/NervanaSystems/ngraph","forks_url":"https://api.github.com/repos/NervanaSystems/ngraph/forks","keys_url":"https://api.github.com/repos/NervanaSystems/ngraph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NervanaSystems/ngraph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NervanaSystems/ngraph/teams","hooks_url":"https://api.github.com/repos/NervanaSystems/ngraph/hooks","issue_events_url":"https://api.github.com/repos/NervanaSystems/ngraph/issues/events{/number}","events_url":"https://api.github.com/repos/NervanaSystems/ngraph/events","assignees_url":"https://api.github.com/repos/NervanaSystems/ngraph/assignees{/user}","branches_url":"https://api.github.com/repos/NervanaSystems/ngraph/branches{/branch}","tags_url":"https://api.github.com/repos/NervanaSystems/ngraph/tags","blobs_url":"https://api.github.com/repos/NervanaSystems/ngraph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NervanaSystems/ngraph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NervanaSystems/ngraph/git/refs{/sha}","trees_url":"https://api.github.com/repos/NervanaSystems/ngraph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NervanaSystems/ngraph/statuses/{sha}","languages_url":"https://api.github.com/repos/NervanaSystems/ngraph/languages","stargazers_url":"https://api.github.com/repos/NervanaSystems/ngraph/stargazers","contributors_url":"https://api.github.com/repos/NervanaSystems/ngraph/contributors","subscribers_url":"https://api.github.com/repos/NervanaSystems/ngraph/subscribers","subscription_url":"https://api.github.com/repos/NervanaSystems/ngraph/subscription","commits_url":"https://api.github.com/repos/NervanaSystems/ngraph/commits{/sha}","git_commits_url":"https://api.github.com/repos/NervanaSystems/ngraph/git/commits{/sha}","comments_url":"https://api.github.com/repos/NervanaSystems/ngraph/comments{/number}","issue_comment_url":"https://api.github.com/repos/NervanaSystems/ngraph/issues/comments{/number}","contents_url":"https://api.github.com/repos/NervanaSystems/ngraph/contents/{+path}","compare_url":"https://api.github.com/repos/NervanaSystems/ngraph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NervanaSystems/ngraph/merges","archive_url":"https://api.github.com/repos/NervanaSystems/ngraph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NervanaSystems/ngraph/downloads","issues_url":"https://api.github.com/repos/NervanaSystems/ngraph/issues{/number}","pulls_url":"https://api.github.com/repos/NervanaSystems/ngraph/pulls{/number}","milestones_url":"https://api.github.com/repos/NervanaSystems/ngraph/milestones{/number}","notifications_url":"https://api.github.com/repos/NervanaSystems/ngraph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NervanaSystems/ngraph/labels{/name}","releases_url":"https://api.github.com/repos/NervanaSystems/ngraph/releases{/id}","deployments_url":"https://api.github.com/repos/NervanaSystems/ngraph/deployments","created_at":"2017-07-25T02:02:38Z","updated_at":"2018-06-20T00:49:41Z","pushed_at":"2018-06-20T06:21:40Z","git_url":"git://github.com/NervanaSystems/ngraph.git","ssh_url":"[email protected]:NervanaSystems/ngraph.git","clone_url":"https://github.com/NervanaSystems/ngraph.git","svn_url":"https://github.com/NervanaSystems/ngraph","homepage":"http://ngraph.nervanasys.com/docs/latest","size":31944,"stargazers_count":497,"watchers_count":497,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":51,"mirror_url":null,"archived":false,"open_issues_count":38,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":51,"open_issues":38,"watchers":497,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NervanaSystems/ngraph/pulls/1116"},"html":{"href":"https://github.com/NervanaSystems/ngraph/pull/1116"},"issue":{"href":"https://api.github.com/repos/NervanaSystems/ngraph/issues/1116"},"comments":{"href":"https://api.github.com/repos/NervanaSystems/ngraph/issues/1116/comments"},"review_comments":{"href":"https://api.github.com/repos/NervanaSystems/ngraph/pulls/1116/comments"},"review_comment":{"href":"https://api.github.com/repos/NervanaSystems/ngraph/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NervanaSystems/ngraph/pulls/1116/commits"},"statuses":{"href":"https://api.github.com/repos/NervanaSystems/ngraph/statuses/477d0b4d0ee2dffab1b05f75786165eb12110cec"}},"author_association":"NONE"}} | {
"id": 98252973,
"name": "NervanaSystems/ngraph",
"url": "https://api.github.com/repos/NervanaSystems/ngraph"
} | {
"id": 19515906,
"login": "shssf",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/19515906?",
"url": "https://api.github.com/users/shssf"
} | {
"id": 9260121,
"login": "NervanaSystems",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9260121?",
"url": "https://api.github.com/orgs/NervanaSystems"
} | 2018-06-20T08:33:23 | 7850433812 | {"actor":{"display_login":"shssf"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/letsencrypt/boulder/pulls/comments/236505925","pull_request_review_id":178594163,"id":236505925,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNjUwNTkyNQ==","diff_hunk":"@@ -0,0 +1,115 @@\n+package main\n+\n+import (\n+\t\"encoding/json\"\n+\t\"flag\"\n+\t\"fmt\"\n+\t\"io/ioutil\"\n+\t\"log\"\n+\t\"net/http\"\n+\t\"sync\"\n+\n+\t\"github.com/letsencrypt/boulder/akamai\"\n+\t\"github.com/letsencrypt/boulder/cmd\"\n+)\n+\n+func main() {\n+\tlistenAddr := flag.String(\"listen\", \"localhost:6789\", \"Address to listen on\")\n+\tsecret := flag.String(\"secret\", \"\", \"Akamai client secret\")\n+\tflag.Parse()\n+\n+\t// v2\n+\tv2Purges := [][]string{}\n+\tv3Purges := [][]string{}\n+\tmu := sync.Mutex{}\n+\n+\thttp.HandleFunc(\"/debug/get-purges\", func(w http.ResponseWriter, r *http.Request) {\n+\t\tmu.Lock()\n+\t\tdefer mu.Unlock()\n+\t\tbody, err := json.Marshal(struct {\n+\t\t\tV2 [][]string\n+\t\t\tV3 [][]string\n+\t\t}{V2: v2Purges, V3: v3Purges})\n+\t\tif err != nil {\n+\t\t\tw.WriteHeader(http.StatusInternalServerError)\n+\t\t\treturn\n+\t\t}\n+\t\tw.Write(body)\n+\t\treturn\n+\t})\n+\n+\thttp.HandleFunc(\"/debug/reset-purges\", func(w http.ResponseWriter, r *http.Request) {\n+\t\tmu.Lock()\n+\t\tdefer mu.Unlock()\n+\t\tv2Purges, v3Purges = [][]string{}, [][]string{}\n+\t\tw.WriteHeader(http.StatusOK)\n+\t\treturn\n+\t})\n+\n+\t// Since v2 and v3 APIs share a bunch of logic just mash them into a single\n+\t// handler.\n+\thttp.HandleFunc(\"/ccu/\", func(w http.ResponseWriter, r *http.Request) {\n+\t\tif r.Method != http.MethodPost {\n+\t\t\tw.WriteHeader(http.StatusMethodNotAllowed)\n+\t\t\tfmt.Println(\"Wrong method:\", r.Method)\n+\t\t\treturn\n+\t\t}\n+\t\tmu.Lock()\n+\t\tdefer mu.Unlock()\n+\t\tvar purgeRequest struct {\n+\t\t\tObjects []string `json:\"objects\"`\n+\t\t\tType string `json:\"type\"`\n+\t\t\tAction string `json:\"action\"`\n+\t\t}\n+\t\tbody, err := ioutil.ReadAll(r.Body)\n+\t\tif err != nil {\n+\t\t\tw.WriteHeader(http.StatusBadRequest)\n+\t\t\tfmt.Println(\"Can't read body:\", err)\n+\t\t\treturn\n+\t\t}\n+\t\tif err = akamai.CheckSignature(*secret, \"http://\"+*listenAddr, r, body); err != nil {\n+\t\t\tw.WriteHeader(http.StatusUnauthorized)\n+\t\t\tfmt.Println(\"Bad signature:\", err)\n+\t\t\treturn\n+\t\t}\n+\t\tif err = json.Unmarshal(body, &purgeRequest); err != nil {\n+\t\t\tw.WriteHeader(http.StatusBadRequest)\n+\t\t\tfmt.Println(\"Can't unmarshal:\", err)\n+\t\t\treturn\n+\t\t}\n+\t\tif r.URL.Path == \"/ccu/v2/queues/default\" {\n+\t\t\tif purgeRequest.Type != \"arl\" || purgeRequest.Action != \"remove\" || len(purgeRequest.Objects) == 0 {\n+\t\t\t\tw.WriteHeader(http.StatusBadRequest)\n+\t\t\t\tfmt.Println(\"Bad parameters:\", purgeRequest)\n+\t\t\t\treturn\n+\t\t\t}\n+\t\t\tv2Purges = append(v2Purges, purgeRequest.Objects)\n+\t\t} else if r.URL.Path == \"/ccu/v3/delete/url/staging\" {\n+\t\t\tif len(purgeRequest.Objects) == 0 || purgeRequest.Type != \"\" || purgeRequest.Action != \"\" {\n+\t\t\t\tw.WriteHeader(http.StatusBadRequest)\n+\t\t\t\tfmt.Println(\"Bad parameters:\", purgeRequest)\n+\t\t\t\treturn\n+\t\t\t}\n+\t\t\tv3Purges = append(v3Purges, purgeRequest.Objects)\n+\t\t}\n+\n+\t\trespObj := struct {\n+\t\t\tPurgeID string\n+\t\t\tHTTPStatus int\n+\t\t\tEstimatedSeconds int\n+\t\t}{\n+\t\t\tPurgeID: \"welcome-to-the-purge\",","path":"test/akamai-test-srv/main.go","position":101,"original_position":101,"commit_id":"721d88f0fe08f2158b4b306547cd07835bb1b8e4","original_commit_id":"721d88f0fe08f2158b4b306547cd07835bb1b8e4","user":{"login":"jsha","id":220205,"node_id":"MDQ6VXNlcjIyMDIwNQ==","avatar_url":"https://avatars1.githubusercontent.com/u/220205?v=4","gravatar_id":"","url":"https://api.github.com/users/jsha","html_url":"https://github.com/jsha","followers_url":"https://api.github.com/users/jsha/followers","following_url":"https://api.github.com/users/jsha/following{/other_user}","gists_url":"https://api.github.com/users/jsha/gists{/gist_id}","starred_url":"https://api.github.com/users/jsha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsha/subscriptions","organizations_url":"https://api.github.com/users/jsha/orgs","repos_url":"https://api.github.com/users/jsha/repos","events_url":"https://api.github.com/users/jsha/events{/privacy}","received_events_url":"https://api.github.com/users/jsha/received_events","type":"User","site_admin":false},"body":":100: ","created_at":"2018-11-27T03:06:19Z","updated_at":"2018-11-27T03:06:33Z","html_url":"https://github.com/letsencrypt/boulder/pull/3946#discussion_r236505925","pull_request_url":"https://api.github.com/repos/letsencrypt/boulder/pulls/3946","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/letsencrypt/boulder/pulls/comments/236505925"},"html":{"href":"https://github.com/letsencrypt/boulder/pull/3946#discussion_r236505925"},"pull_request":{"href":"https://api.github.com/repos/letsencrypt/boulder/pulls/3946"}}},"pull_request":{"url":"https://api.github.com/repos/letsencrypt/boulder/pulls/3946","id":232147004,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMyMTQ3MDA0","html_url":"https://github.com/letsencrypt/boulder/pull/3946","diff_url":"https://github.com/letsencrypt/boulder/pull/3946.diff","patch_url":"https://github.com/letsencrypt/boulder/pull/3946.patch","issue_url":"https://api.github.com/repos/letsencrypt/boulder/issues/3946","number":3946,"state":"open","locked":false,"title":"Add fake Akamai purge server for integration testing","user":{"login":"rolandshoemaker","id":5080674,"node_id":"MDQ6VXNlcjUwODA2NzQ=","avatar_url":"https://avatars3.githubusercontent.com/u/5080674?v=4","gravatar_id":"","url":"https://api.github.com/users/rolandshoemaker","html_url":"https://github.com/rolandshoemaker","followers_url":"https://api.github.com/users/rolandshoemaker/followers","following_url":"https://api.github.com/users/rolandshoemaker/following{/other_user}","gists_url":"https://api.github.com/users/rolandshoemaker/gists{/gist_id}","starred_url":"https://api.github.com/users/rolandshoemaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rolandshoemaker/subscriptions","organizations_url":"https://api.github.com/users/rolandshoemaker/orgs","repos_url":"https://api.github.com/users/rolandshoemaker/repos","events_url":"https://api.github.com/users/rolandshoemaker/events{/privacy}","received_events_url":"https://api.github.com/users/rolandshoemaker/received_events","type":"User","site_admin":false},"body":"Fixes #3916.","created_at":"2018-11-19T23:38:43Z","updated_at":"2018-11-27T03:06:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ebaf435c79d98e93da7052557ef9d14b3bd5df78","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/letsencrypt/boulder/pulls/3946/commits","review_comments_url":"https://api.github.com/repos/letsencrypt/boulder/pulls/3946/comments","review_comment_url":"https://api.github.com/repos/letsencrypt/boulder/pulls/comments{/number}","comments_url":"https://api.github.com/repos/letsencrypt/boulder/issues/3946/comments","statuses_url":"https://api.github.com/repos/letsencrypt/boulder/statuses/721d88f0fe08f2158b4b306547cd07835bb1b8e4","head":{"label":"letsencrypt:akamai-test-srv","ref":"akamai-test-srv","sha":"721d88f0fe08f2158b4b306547cd07835bb1b8e4","user":{"login":"letsencrypt","id":9289019,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkyODkwMTk=","avatar_url":"https://avatars0.githubusercontent.com/u/9289019?v=4","gravatar_id":"","url":"https://api.github.com/users/letsencrypt","html_url":"https://github.com/letsencrypt","followers_url":"https://api.github.com/users/letsencrypt/followers","following_url":"https://api.github.com/users/letsencrypt/following{/other_user}","gists_url":"https://api.github.com/users/letsencrypt/gists{/gist_id}","starred_url":"https://api.github.com/users/letsencrypt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/letsencrypt/subscriptions","organizations_url":"https://api.github.com/users/letsencrypt/orgs","repos_url":"https://api.github.com/users/letsencrypt/repos","events_url":"https://api.github.com/users/letsencrypt/events{/privacy}","received_events_url":"https://api.github.com/users/letsencrypt/received_events","type":"Organization","site_admin":false},"repo":{"id":28283593,"node_id":"MDEwOlJlcG9zaXRvcnkyODI4MzU5Mw==","name":"boulder","full_name":"letsencrypt/boulder","private":false,"owner":{"login":"letsencrypt","id":9289019,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkyODkwMTk=","avatar_url":"https://avatars0.githubusercontent.com/u/9289019?v=4","gravatar_id":"","url":"https://api.github.com/users/letsencrypt","html_url":"https://github.com/letsencrypt","followers_url":"https://api.github.com/users/letsencrypt/followers","following_url":"https://api.github.com/users/letsencrypt/following{/other_user}","gists_url":"https://api.github.com/users/letsencrypt/gists{/gist_id}","starred_url":"https://api.github.com/users/letsencrypt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/letsencrypt/subscriptions","organizations_url":"https://api.github.com/users/letsencrypt/orgs","repos_url":"https://api.github.com/users/letsencrypt/repos","events_url":"https://api.github.com/users/letsencrypt/events{/privacy}","received_events_url":"https://api.github.com/users/letsencrypt/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/letsencrypt/boulder","description":"An ACME-based CA, written in Go.","fork":false,"url":"https://api.github.com/repos/letsencrypt/boulder","forks_url":"https://api.github.com/repos/letsencrypt/boulder/forks","keys_url":"https://api.github.com/repos/letsencrypt/boulder/keys{/key_id}","collaborators_url":"https://api.github.com/repos/letsencrypt/boulder/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/letsencrypt/boulder/teams","hooks_url":"https://api.github.com/repos/letsencrypt/boulder/hooks","issue_events_url":"https://api.github.com/repos/letsencrypt/boulder/issues/events{/number}","events_url":"https://api.github.com/repos/letsencrypt/boulder/events","assignees_url":"https://api.github.com/repos/letsencrypt/boulder/assignees{/user}","branches_url":"https://api.github.com/repos/letsencrypt/boulder/branches{/branch}","tags_url":"https://api.github.com/repos/letsencrypt/boulder/tags","blobs_url":"https://api.github.com/repos/letsencrypt/boulder/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/letsencrypt/boulder/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/letsencrypt/boulder/git/refs{/sha}","trees_url":"https://api.github.com/repos/letsencrypt/boulder/git/trees{/sha}","statuses_url":"https://api.github.com/repos/letsencrypt/boulder/statuses/{sha}","languages_url":"https://api.github.com/repos/letsencrypt/boulder/languages","stargazers_url":"https://api.github.com/repos/letsencrypt/boulder/stargazers","contributors_url":"https://api.github.com/repos/letsencrypt/boulder/contributors","subscribers_url":"https://api.github.com/repos/letsencrypt/boulder/subscribers","subscription_url":"https://api.github.com/repos/letsencrypt/boulder/subscription","commits_url":"https://api.github.com/repos/letsencrypt/boulder/commits{/sha}","git_commits_url":"https://api.github.com/repos/letsencrypt/boulder/git/commits{/sha}","comments_url":"https://api.github.com/repos/letsencrypt/boulder/comments{/number}","issue_comment_url":"https://api.github.com/repos/letsencrypt/boulder/issues/comments{/number}","contents_url":"https://api.github.com/repos/letsencrypt/boulder/contents/{+path}","compare_url":"https://api.github.com/repos/letsencrypt/boulder/compare/{base}...{head}","merges_url":"https://api.github.com/repos/letsencrypt/boulder/merges","archive_url":"https://api.github.com/repos/letsencrypt/boulder/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/letsencrypt/boulder/downloads","issues_url":"https://api.github.com/repos/letsencrypt/boulder/issues{/number}","pulls_url":"https://api.github.com/repos/letsencrypt/boulder/pulls{/number}","milestones_url":"https://api.github.com/repos/letsencrypt/boulder/milestones{/number}","notifications_url":"https://api.github.com/repos/letsencrypt/boulder/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/letsencrypt/boulder/labels{/name}","releases_url":"https://api.github.com/repos/letsencrypt/boulder/releases{/id}","deployments_url":"https://api.github.com/repos/letsencrypt/boulder/deployments","created_at":"2014-12-21T00:29:54Z","updated_at":"2018-11-25T15:09:04Z","pushed_at":"2018-11-26T23:41:19Z","git_url":"git://github.com/letsencrypt/boulder.git","ssh_url":"[email protected]:letsencrypt/boulder.git","clone_url":"https://github.com/letsencrypt/boulder.git","svn_url":"https://github.com/letsencrypt/boulder","homepage":null,"size":33085,"stargazers_count":2702,"watchers_count":2702,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":331,"mirror_url":null,"archived":false,"open_issues_count":118,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":331,"open_issues":118,"watchers":2702,"default_branch":"master"}},"base":{"label":"letsencrypt:master","ref":"master","sha":"965acf381b24a16dffefba6135d308c4ee42e32c","user":{"login":"letsencrypt","id":9289019,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkyODkwMTk=","avatar_url":"https://avatars0.githubusercontent.com/u/9289019?v=4","gravatar_id":"","url":"https://api.github.com/users/letsencrypt","html_url":"https://github.com/letsencrypt","followers_url":"https://api.github.com/users/letsencrypt/followers","following_url":"https://api.github.com/users/letsencrypt/following{/other_user}","gists_url":"https://api.github.com/users/letsencrypt/gists{/gist_id}","starred_url":"https://api.github.com/users/letsencrypt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/letsencrypt/subscriptions","organizations_url":"https://api.github.com/users/letsencrypt/orgs","repos_url":"https://api.github.com/users/letsencrypt/repos","events_url":"https://api.github.com/users/letsencrypt/events{/privacy}","received_events_url":"https://api.github.com/users/letsencrypt/received_events","type":"Organization","site_admin":false},"repo":{"id":28283593,"node_id":"MDEwOlJlcG9zaXRvcnkyODI4MzU5Mw==","name":"boulder","full_name":"letsencrypt/boulder","private":false,"owner":{"login":"letsencrypt","id":9289019,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkyODkwMTk=","avatar_url":"https://avatars0.githubusercontent.com/u/9289019?v=4","gravatar_id":"","url":"https://api.github.com/users/letsencrypt","html_url":"https://github.com/letsencrypt","followers_url":"https://api.github.com/users/letsencrypt/followers","following_url":"https://api.github.com/users/letsencrypt/following{/other_user}","gists_url":"https://api.github.com/users/letsencrypt/gists{/gist_id}","starred_url":"https://api.github.com/users/letsencrypt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/letsencrypt/subscriptions","organizations_url":"https://api.github.com/users/letsencrypt/orgs","repos_url":"https://api.github.com/users/letsencrypt/repos","events_url":"https://api.github.com/users/letsencrypt/events{/privacy}","received_events_url":"https://api.github.com/users/letsencrypt/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/letsencrypt/boulder","description":"An ACME-based CA, written in Go.","fork":false,"url":"https://api.github.com/repos/letsencrypt/boulder","forks_url":"https://api.github.com/repos/letsencrypt/boulder/forks","keys_url":"https://api.github.com/repos/letsencrypt/boulder/keys{/key_id}","collaborators_url":"https://api.github.com/repos/letsencrypt/boulder/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/letsencrypt/boulder/teams","hooks_url":"https://api.github.com/repos/letsencrypt/boulder/hooks","issue_events_url":"https://api.github.com/repos/letsencrypt/boulder/issues/events{/number}","events_url":"https://api.github.com/repos/letsencrypt/boulder/events","assignees_url":"https://api.github.com/repos/letsencrypt/boulder/assignees{/user}","branches_url":"https://api.github.com/repos/letsencrypt/boulder/branches{/branch}","tags_url":"https://api.github.com/repos/letsencrypt/boulder/tags","blobs_url":"https://api.github.com/repos/letsencrypt/boulder/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/letsencrypt/boulder/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/letsencrypt/boulder/git/refs{/sha}","trees_url":"https://api.github.com/repos/letsencrypt/boulder/git/trees{/sha}","statuses_url":"https://api.github.com/repos/letsencrypt/boulder/statuses/{sha}","languages_url":"https://api.github.com/repos/letsencrypt/boulder/languages","stargazers_url":"https://api.github.com/repos/letsencrypt/boulder/stargazers","contributors_url":"https://api.github.com/repos/letsencrypt/boulder/contributors","subscribers_url":"https://api.github.com/repos/letsencrypt/boulder/subscribers","subscription_url":"https://api.github.com/repos/letsencrypt/boulder/subscription","commits_url":"https://api.github.com/repos/letsencrypt/boulder/commits{/sha}","git_commits_url":"https://api.github.com/repos/letsencrypt/boulder/git/commits{/sha}","comments_url":"https://api.github.com/repos/letsencrypt/boulder/comments{/number}","issue_comment_url":"https://api.github.com/repos/letsencrypt/boulder/issues/comments{/number}","contents_url":"https://api.github.com/repos/letsencrypt/boulder/contents/{+path}","compare_url":"https://api.github.com/repos/letsencrypt/boulder/compare/{base}...{head}","merges_url":"https://api.github.com/repos/letsencrypt/boulder/merges","archive_url":"https://api.github.com/repos/letsencrypt/boulder/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/letsencrypt/boulder/downloads","issues_url":"https://api.github.com/repos/letsencrypt/boulder/issues{/number}","pulls_url":"https://api.github.com/repos/letsencrypt/boulder/pulls{/number}","milestones_url":"https://api.github.com/repos/letsencrypt/boulder/milestones{/number}","notifications_url":"https://api.github.com/repos/letsencrypt/boulder/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/letsencrypt/boulder/labels{/name}","releases_url":"https://api.github.com/repos/letsencrypt/boulder/releases{/id}","deployments_url":"https://api.github.com/repos/letsencrypt/boulder/deployments","created_at":"2014-12-21T00:29:54Z","updated_at":"2018-11-25T15:09:04Z","pushed_at":"2018-11-26T23:41:19Z","git_url":"git://github.com/letsencrypt/boulder.git","ssh_url":"[email protected]:letsencrypt/boulder.git","clone_url":"https://github.com/letsencrypt/boulder.git","svn_url":"https://github.com/letsencrypt/boulder","homepage":null,"size":33085,"stargazers_count":2702,"watchers_count":2702,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":331,"mirror_url":null,"archived":false,"open_issues_count":118,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":331,"open_issues":118,"watchers":2702,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/letsencrypt/boulder/pulls/3946"},"html":{"href":"https://github.com/letsencrypt/boulder/pull/3946"},"issue":{"href":"https://api.github.com/repos/letsencrypt/boulder/issues/3946"},"comments":{"href":"https://api.github.com/repos/letsencrypt/boulder/issues/3946/comments"},"review_comments":{"href":"https://api.github.com/repos/letsencrypt/boulder/pulls/3946/comments"},"review_comment":{"href":"https://api.github.com/repos/letsencrypt/boulder/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/letsencrypt/boulder/pulls/3946/commits"},"statuses":{"href":"https://api.github.com/repos/letsencrypt/boulder/statuses/721d88f0fe08f2158b4b306547cd07835bb1b8e4"}},"author_association":"MEMBER"}} | {
"id": 28283593,
"name": "letsencrypt/boulder",
"url": "https://api.github.com/repos/letsencrypt/boulder"
} | {
"id": 220205,
"login": "jsha",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/220205?",
"url": "https://api.github.com/users/jsha"
} | {
"id": 9289019,
"login": "letsencrypt",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9289019?",
"url": "https://api.github.com/orgs/letsencrypt"
} | 2018-11-27T03:06:19 | 8651433192 | {"actor":{"display_login":"jsha"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/axa-ch/patterns-library/pulls/comments/236285909","pull_request_review_id":178328055,"id":236285909,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNjI4NTkwOQ==","diff_hunk":"@@ -17,7 +17,7 @@ const nativeSelect = ({ title, items, size, value }) => html`<div class=\"${class\n items.map(({ name, value: itemValue, url }, index) => {\n const _itemValue = getItemValue(itemValue, index);\n return html`<option value=\"${_itemValue}\" data-url=\"${url}\" ${\n- _itemValue === value ? 'selected' : ''\n+ `${_itemValue}` === `${value}` ? 'selected' : ''","path":"src/components/m-dropdown/_template.js","position":5,"original_position":5,"commit_id":"ee6c3df735f3b850776fa0f77d15d3663eb8bfd8","original_commit_id":"ee6c3df735f3b850776fa0f77d15d3663eb8bfd8","user":{"login":"AndyOGo","id":914443,"node_id":"MDQ6VXNlcjkxNDQ0Mw==","avatar_url":"https://avatars1.githubusercontent.com/u/914443?v=4","gravatar_id":"","url":"https://api.github.com/users/AndyOGo","html_url":"https://github.com/AndyOGo","followers_url":"https://api.github.com/users/AndyOGo/followers","following_url":"https://api.github.com/users/AndyOGo/following{/other_user}","gists_url":"https://api.github.com/users/AndyOGo/gists{/gist_id}","starred_url":"https://api.github.com/users/AndyOGo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndyOGo/subscriptions","organizations_url":"https://api.github.com/users/AndyOGo/orgs","repos_url":"https://api.github.com/users/AndyOGo/repos","events_url":"https://api.github.com/users/AndyOGo/events{/privacy}","received_events_url":"https://api.github.com/users/AndyOGo/received_events","type":"User","site_admin":false},"body":"Guess this check should not be of strict type?\r\nIf so I would just write `_itemValue == value`, the javascript engine will handle type conversion for you, so that stuff like `'4' == 4` will be truthy","created_at":"2018-11-26T14:56:00Z","updated_at":"2018-11-26T14:56:01Z","html_url":"https://github.com/axa-ch/patterns-library/pull/690#discussion_r236285909","pull_request_url":"https://api.github.com/repos/axa-ch/patterns-library/pulls/690","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/axa-ch/patterns-library/pulls/comments/236285909"},"html":{"href":"https://github.com/axa-ch/patterns-library/pull/690#discussion_r236285909"},"pull_request":{"href":"https://api.github.com/repos/axa-ch/patterns-library/pulls/690"}}},"pull_request":{"url":"https://api.github.com/repos/axa-ch/patterns-library/pulls/690","id":233585328,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzNTg1MzI4","html_url":"https://github.com/axa-ch/patterns-library/pull/690","diff_url":"https://github.com/axa-ch/patterns-library/pull/690.diff","patch_url":"https://github.com/axa-ch/patterns-library/pull/690.patch","issue_url":"https://api.github.com/repos/axa-ch/patterns-library/issues/690","number":690,"state":"open","locked":false,"title":"Native dropdown numbers as values selection fixed.","user":{"login":"nakovskijosif","id":42141843,"node_id":"MDQ6VXNlcjQyMTQxODQz","avatar_url":"https://avatars3.githubusercontent.com/u/42141843?v=4","gravatar_id":"","url":"https://api.github.com/users/nakovskijosif","html_url":"https://github.com/nakovskijosif","followers_url":"https://api.github.com/users/nakovskijosif/followers","following_url":"https://api.github.com/users/nakovskijosif/following{/other_user}","gists_url":"https://api.github.com/users/nakovskijosif/gists{/gist_id}","starred_url":"https://api.github.com/users/nakovskijosif/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nakovskijosif/subscriptions","organizations_url":"https://api.github.com/users/nakovskijosif/orgs","repos_url":"https://api.github.com/users/nakovskijosif/repos","events_url":"https://api.github.com/users/nakovskijosif/events{/privacy}","received_events_url":"https://api.github.com/users/nakovskijosif/received_events","type":"User","site_admin":false},"body":"Fixes #688 .\r\n\r\nChanges proposed in this pull request:\r\n\r\nfixed the comparison between different prop types.\r\n\r\n## Type of change\r\n\r\n- [x] Bug fix (non-breaking change which fixes an issue)\r\n \r\n # Checklist:\r\n \r\n - [ ] My code follows the style guidelines of this project\r\n - [ ] I have performed a self-review of my own code\r\n - [ ] I have commented my code, particularly in hard-to-understand areas\r\n - [ ] I have made corresponding changes to the documentation\r\n - [ ] My changes generate no new warnings\r\n - [ ] I have added tests that prove my fix is effective or that my feature works\r\n - [ ] New and existing unit tests pass locally with my changes\r\n - [ ] Any dependent changes have been merged and published in downstream modules\r\n","created_at":"2018-11-26T14:53:55Z","updated_at":"2018-11-26T14:56:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7535e1c2a3928a547bc012a825ba526d46da1440","assignee":null,"assignees":[],"requested_reviewers":[{"login":"LucaMele","id":275235,"node_id":"MDQ6VXNlcjI3NTIzNQ==","avatar_url":"https://avatars0.githubusercontent.com/u/275235?v=4","gravatar_id":"","url":"https://api.github.com/users/LucaMele","html_url":"https://github.com/LucaMele","followers_url":"https://api.github.com/users/LucaMele/followers","following_url":"https://api.github.com/users/LucaMele/following{/other_user}","gists_url":"https://api.github.com/users/LucaMele/gists{/gist_id}","starred_url":"https://api.github.com/users/LucaMele/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LucaMele/subscriptions","organizations_url":"https://api.github.com/users/LucaMele/orgs","repos_url":"https://api.github.com/users/LucaMele/repos","events_url":"https://api.github.com/users/LucaMele/events{/privacy}","received_events_url":"https://api.github.com/users/LucaMele/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/axa-ch/patterns-library/pulls/690/commits","review_comments_url":"https://api.github.com/repos/axa-ch/patterns-library/pulls/690/comments","review_comment_url":"https://api.github.com/repos/axa-ch/patterns-library/pulls/comments{/number}","comments_url":"https://api.github.com/repos/axa-ch/patterns-library/issues/690/comments","statuses_url":"https://api.github.com/repos/axa-ch/patterns-library/statuses/ee6c3df735f3b850776fa0f77d15d3663eb8bfd8","head":{"label":"axa-ch:bugfix/dropdown_numbers_as_values","ref":"bugfix/dropdown_numbers_as_values","sha":"ee6c3df735f3b850776fa0f77d15d3663eb8bfd8","user":{"login":"axa-ch","id":9319056,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkzMTkwNTY=","avatar_url":"https://avatars2.githubusercontent.com/u/9319056?v=4","gravatar_id":"","url":"https://api.github.com/users/axa-ch","html_url":"https://github.com/axa-ch","followers_url":"https://api.github.com/users/axa-ch/followers","following_url":"https://api.github.com/users/axa-ch/following{/other_user}","gists_url":"https://api.github.com/users/axa-ch/gists{/gist_id}","starred_url":"https://api.github.com/users/axa-ch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/axa-ch/subscriptions","organizations_url":"https://api.github.com/users/axa-ch/orgs","repos_url":"https://api.github.com/users/axa-ch/repos","events_url":"https://api.github.com/users/axa-ch/events{/privacy}","received_events_url":"https://api.github.com/users/axa-ch/received_events","type":"Organization","site_admin":false},"repo":{"id":112588368,"node_id":"MDEwOlJlcG9zaXRvcnkxMTI1ODgzNjg=","name":"patterns-library","full_name":"axa-ch/patterns-library","private":false,"owner":{"login":"axa-ch","id":9319056,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkzMTkwNTY=","avatar_url":"https://avatars2.githubusercontent.com/u/9319056?v=4","gravatar_id":"","url":"https://api.github.com/users/axa-ch","html_url":"https://github.com/axa-ch","followers_url":"https://api.github.com/users/axa-ch/followers","following_url":"https://api.github.com/users/axa-ch/following{/other_user}","gists_url":"https://api.github.com/users/axa-ch/gists{/gist_id}","starred_url":"https://api.github.com/users/axa-ch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/axa-ch/subscriptions","organizations_url":"https://api.github.com/users/axa-ch/orgs","repos_url":"https://api.github.com/users/axa-ch/repos","events_url":"https://api.github.com/users/axa-ch/events{/privacy}","received_events_url":"https://api.github.com/users/axa-ch/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/axa-ch/patterns-library","description":"Please share, comment, make issues and work with us! ","fork":false,"url":"https://api.github.com/repos/axa-ch/patterns-library","forks_url":"https://api.github.com/repos/axa-ch/patterns-library/forks","keys_url":"https://api.github.com/repos/axa-ch/patterns-library/keys{/key_id}","collaborators_url":"https://api.github.com/repos/axa-ch/patterns-library/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/axa-ch/patterns-library/teams","hooks_url":"https://api.github.com/repos/axa-ch/patterns-library/hooks","issue_events_url":"https://api.github.com/repos/axa-ch/patterns-library/issues/events{/number}","events_url":"https://api.github.com/repos/axa-ch/patterns-library/events","assignees_url":"https://api.github.com/repos/axa-ch/patterns-library/assignees{/user}","branches_url":"https://api.github.com/repos/axa-ch/patterns-library/branches{/branch}","tags_url":"https://api.github.com/repos/axa-ch/patterns-library/tags","blobs_url":"https://api.github.com/repos/axa-ch/patterns-library/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/axa-ch/patterns-library/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/axa-ch/patterns-library/git/refs{/sha}","trees_url":"https://api.github.com/repos/axa-ch/patterns-library/git/trees{/sha}","statuses_url":"https://api.github.com/repos/axa-ch/patterns-library/statuses/{sha}","languages_url":"https://api.github.com/repos/axa-ch/patterns-library/languages","stargazers_url":"https://api.github.com/repos/axa-ch/patterns-library/stargazers","contributors_url":"https://api.github.com/repos/axa-ch/patterns-library/contributors","subscribers_url":"https://api.github.com/repos/axa-ch/patterns-library/subscribers","subscription_url":"https://api.github.com/repos/axa-ch/patterns-library/subscription","commits_url":"https://api.github.com/repos/axa-ch/patterns-library/commits{/sha}","git_commits_url":"https://api.github.com/repos/axa-ch/patterns-library/git/commits{/sha}","comments_url":"https://api.github.com/repos/axa-ch/patterns-library/comments{/number}","issue_comment_url":"https://api.github.com/repos/axa-ch/patterns-library/issues/comments{/number}","contents_url":"https://api.github.com/repos/axa-ch/patterns-library/contents/{+path}","compare_url":"https://api.github.com/repos/axa-ch/patterns-library/compare/{base}...{head}","merges_url":"https://api.github.com/repos/axa-ch/patterns-library/merges","archive_url":"https://api.github.com/repos/axa-ch/patterns-library/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/axa-ch/patterns-library/downloads","issues_url":"https://api.github.com/repos/axa-ch/patterns-library/issues{/number}","pulls_url":"https://api.github.com/repos/axa-ch/patterns-library/pulls{/number}","milestones_url":"https://api.github.com/repos/axa-ch/patterns-library/milestones{/number}","notifications_url":"https://api.github.com/repos/axa-ch/patterns-library/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/axa-ch/patterns-library/labels{/name}","releases_url":"https://api.github.com/repos/axa-ch/patterns-library/releases{/id}","deployments_url":"https://api.github.com/repos/axa-ch/patterns-library/deployments","created_at":"2017-11-30T08:55:17Z","updated_at":"2018-11-26T14:39:35Z","pushed_at":"2018-11-26T14:53:56Z","git_url":"git://github.com/axa-ch/patterns-library.git","ssh_url":"[email protected]:axa-ch/patterns-library.git","clone_url":"https://github.com/axa-ch/patterns-library.git","svn_url":"https://github.com/axa-ch/patterns-library","homepage":"https://www.axa.ch","size":23047,"stargazers_count":12,"watchers_count":12,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":156,"license":null,"forks":2,"open_issues":156,"watchers":12,"default_branch":"develop"}},"base":{"label":"axa-ch:develop","ref":"develop","sha":"72f35165bc05dc5ab54d56eb8ad155b0ae448ada","user":{"login":"axa-ch","id":9319056,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkzMTkwNTY=","avatar_url":"https://avatars2.githubusercontent.com/u/9319056?v=4","gravatar_id":"","url":"https://api.github.com/users/axa-ch","html_url":"https://github.com/axa-ch","followers_url":"https://api.github.com/users/axa-ch/followers","following_url":"https://api.github.com/users/axa-ch/following{/other_user}","gists_url":"https://api.github.com/users/axa-ch/gists{/gist_id}","starred_url":"https://api.github.com/users/axa-ch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/axa-ch/subscriptions","organizations_url":"https://api.github.com/users/axa-ch/orgs","repos_url":"https://api.github.com/users/axa-ch/repos","events_url":"https://api.github.com/users/axa-ch/events{/privacy}","received_events_url":"https://api.github.com/users/axa-ch/received_events","type":"Organization","site_admin":false},"repo":{"id":112588368,"node_id":"MDEwOlJlcG9zaXRvcnkxMTI1ODgzNjg=","name":"patterns-library","full_name":"axa-ch/patterns-library","private":false,"owner":{"login":"axa-ch","id":9319056,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkzMTkwNTY=","avatar_url":"https://avatars2.githubusercontent.com/u/9319056?v=4","gravatar_id":"","url":"https://api.github.com/users/axa-ch","html_url":"https://github.com/axa-ch","followers_url":"https://api.github.com/users/axa-ch/followers","following_url":"https://api.github.com/users/axa-ch/following{/other_user}","gists_url":"https://api.github.com/users/axa-ch/gists{/gist_id}","starred_url":"https://api.github.com/users/axa-ch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/axa-ch/subscriptions","organizations_url":"https://api.github.com/users/axa-ch/orgs","repos_url":"https://api.github.com/users/axa-ch/repos","events_url":"https://api.github.com/users/axa-ch/events{/privacy}","received_events_url":"https://api.github.com/users/axa-ch/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/axa-ch/patterns-library","description":"Please share, comment, make issues and work with us! ","fork":false,"url":"https://api.github.com/repos/axa-ch/patterns-library","forks_url":"https://api.github.com/repos/axa-ch/patterns-library/forks","keys_url":"https://api.github.com/repos/axa-ch/patterns-library/keys{/key_id}","collaborators_url":"https://api.github.com/repos/axa-ch/patterns-library/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/axa-ch/patterns-library/teams","hooks_url":"https://api.github.com/repos/axa-ch/patterns-library/hooks","issue_events_url":"https://api.github.com/repos/axa-ch/patterns-library/issues/events{/number}","events_url":"https://api.github.com/repos/axa-ch/patterns-library/events","assignees_url":"https://api.github.com/repos/axa-ch/patterns-library/assignees{/user}","branches_url":"https://api.github.com/repos/axa-ch/patterns-library/branches{/branch}","tags_url":"https://api.github.com/repos/axa-ch/patterns-library/tags","blobs_url":"https://api.github.com/repos/axa-ch/patterns-library/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/axa-ch/patterns-library/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/axa-ch/patterns-library/git/refs{/sha}","trees_url":"https://api.github.com/repos/axa-ch/patterns-library/git/trees{/sha}","statuses_url":"https://api.github.com/repos/axa-ch/patterns-library/statuses/{sha}","languages_url":"https://api.github.com/repos/axa-ch/patterns-library/languages","stargazers_url":"https://api.github.com/repos/axa-ch/patterns-library/stargazers","contributors_url":"https://api.github.com/repos/axa-ch/patterns-library/contributors","subscribers_url":"https://api.github.com/repos/axa-ch/patterns-library/subscribers","subscription_url":"https://api.github.com/repos/axa-ch/patterns-library/subscription","commits_url":"https://api.github.com/repos/axa-ch/patterns-library/commits{/sha}","git_commits_url":"https://api.github.com/repos/axa-ch/patterns-library/git/commits{/sha}","comments_url":"https://api.github.com/repos/axa-ch/patterns-library/comments{/number}","issue_comment_url":"https://api.github.com/repos/axa-ch/patterns-library/issues/comments{/number}","contents_url":"https://api.github.com/repos/axa-ch/patterns-library/contents/{+path}","compare_url":"https://api.github.com/repos/axa-ch/patterns-library/compare/{base}...{head}","merges_url":"https://api.github.com/repos/axa-ch/patterns-library/merges","archive_url":"https://api.github.com/repos/axa-ch/patterns-library/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/axa-ch/patterns-library/downloads","issues_url":"https://api.github.com/repos/axa-ch/patterns-library/issues{/number}","pulls_url":"https://api.github.com/repos/axa-ch/patterns-library/pulls{/number}","milestones_url":"https://api.github.com/repos/axa-ch/patterns-library/milestones{/number}","notifications_url":"https://api.github.com/repos/axa-ch/patterns-library/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/axa-ch/patterns-library/labels{/name}","releases_url":"https://api.github.com/repos/axa-ch/patterns-library/releases{/id}","deployments_url":"https://api.github.com/repos/axa-ch/patterns-library/deployments","created_at":"2017-11-30T08:55:17Z","updated_at":"2018-11-26T14:39:35Z","pushed_at":"2018-11-26T14:53:56Z","git_url":"git://github.com/axa-ch/patterns-library.git","ssh_url":"[email protected]:axa-ch/patterns-library.git","clone_url":"https://github.com/axa-ch/patterns-library.git","svn_url":"https://github.com/axa-ch/patterns-library","homepage":"https://www.axa.ch","size":23047,"stargazers_count":12,"watchers_count":12,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":156,"license":null,"forks":2,"open_issues":156,"watchers":12,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/axa-ch/patterns-library/pulls/690"},"html":{"href":"https://github.com/axa-ch/patterns-library/pull/690"},"issue":{"href":"https://api.github.com/repos/axa-ch/patterns-library/issues/690"},"comments":{"href":"https://api.github.com/repos/axa-ch/patterns-library/issues/690/comments"},"review_comments":{"href":"https://api.github.com/repos/axa-ch/patterns-library/pulls/690/comments"},"review_comment":{"href":"https://api.github.com/repos/axa-ch/patterns-library/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/axa-ch/patterns-library/pulls/690/commits"},"statuses":{"href":"https://api.github.com/repos/axa-ch/patterns-library/statuses/ee6c3df735f3b850776fa0f77d15d3663eb8bfd8"}},"author_association":"COLLABORATOR"}} | {
"id": 112588368,
"name": "axa-ch/patterns-library",
"url": "https://api.github.com/repos/axa-ch/patterns-library"
} | {
"id": 914443,
"login": "AndyOGo",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/914443?",
"url": "https://api.github.com/users/AndyOGo"
} | {
"id": 9319056,
"login": "axa-ch",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9319056?",
"url": "https://api.github.com/orgs/axa-ch"
} | 2018-11-26T14:56:00 | 8647723482 | {"actor":{"display_login":"AndyOGo"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/pulls/comments/185354813","pull_request_review_id":116726713,"id":185354813,"diff_hunk":"@@ -14,11 +14,12 @@\n \tplugin.setup = function()\n \t{\n \t\t// Add the default option for pauseFocusSelector\n-\t\tthis.options = $.extend(\n+\t\tthis.options = Object.assign(","path":"src/container/plugins/FocusPlugin.js","position":5,"original_position":5,"commit_id":"5dc7a07ca461a3383f32cd5e145e39011a7661ce","original_commit_id":"5dc7a07ca461a3383f32cd5e145e39011a7661ce","user":{"login":"chipbell4","id":2642329,"avatar_url":"https://avatars3.githubusercontent.com/u/2642329?v=4","gravatar_id":"","url":"https://api.github.com/users/chipbell4","html_url":"https://github.com/chipbell4","followers_url":"https://api.github.com/users/chipbell4/followers","following_url":"https://api.github.com/users/chipbell4/following{/other_user}","gists_url":"https://api.github.com/users/chipbell4/gists{/gist_id}","starred_url":"https://api.github.com/users/chipbell4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chipbell4/subscriptions","organizations_url":"https://api.github.com/users/chipbell4/orgs","repos_url":"https://api.github.com/users/chipbell4/repos","events_url":"https://api.github.com/users/chipbell4/events{/privacy}","received_events_url":"https://api.github.com/users/chipbell4/received_events","type":"User","site_admin":false},"body":"Flagging another `Object.assign` call.","created_at":"2018-05-01T22:49:47Z","updated_at":"2018-05-01T23:02:04Z","html_url":"https://github.com/SpringRoll/SpringRollContainer/pull/10#discussion_r185354813","pull_request_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/pulls/10","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/SpringRoll/SpringRollContainer/pulls/comments/185354813"},"html":{"href":"https://github.com/SpringRoll/SpringRollContainer/pull/10#discussion_r185354813"},"pull_request":{"href":"https://api.github.com/repos/SpringRoll/SpringRollContainer/pulls/10"}}},"pull_request":{"url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/pulls/10","id":185235456,"html_url":"https://github.com/SpringRoll/SpringRollContainer/pull/10","diff_url":"https://github.com/SpringRoll/SpringRollContainer/pull/10.diff","patch_url":"https://github.com/SpringRoll/SpringRollContainer/pull/10.patch","issue_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/issues/10","number":10,"state":"open","locked":false,"title":"Removed jQuery from Container","user":{"login":"SmithAF","id":22455049,"avatar_url":"https://avatars0.githubusercontent.com/u/22455049?v=4","gravatar_id":"","url":"https://api.github.com/users/SmithAF","html_url":"https://github.com/SmithAF","followers_url":"https://api.github.com/users/SmithAF/followers","following_url":"https://api.github.com/users/SmithAF/following{/other_user}","gists_url":"https://api.github.com/users/SmithAF/gists{/gist_id}","starred_url":"https://api.github.com/users/SmithAF/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SmithAF/subscriptions","organizations_url":"https://api.github.com/users/SmithAF/orgs","repos_url":"https://api.github.com/users/SmithAF/repos","events_url":"https://api.github.com/users/SmithAF/events{/privacy}","received_events_url":"https://api.github.com/users/SmithAF/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-05-01T18:00:10Z","updated_at":"2018-05-01T23:02:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2cf5a28c082ecb594f6ff276498024fbfc1dcaee","assignee":null,"assignees":[],"requested_reviewers":[{"login":"Connor93","id":1617275,"avatar_url":"https://avatars3.githubusercontent.com/u/1617275?v=4","gravatar_id":"","url":"https://api.github.com/users/Connor93","html_url":"https://github.com/Connor93","followers_url":"https://api.github.com/users/Connor93/followers","following_url":"https://api.github.com/users/Connor93/following{/other_user}","gists_url":"https://api.github.com/users/Connor93/gists{/gist_id}","starred_url":"https://api.github.com/users/Connor93/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Connor93/subscriptions","organizations_url":"https://api.github.com/users/Connor93/orgs","repos_url":"https://api.github.com/users/Connor93/repos","events_url":"https://api.github.com/users/Connor93/events{/privacy}","received_events_url":"https://api.github.com/users/Connor93/received_events","type":"User","site_admin":false},{"login":"lmckeen","id":11928027,"avatar_url":"https://avatars1.githubusercontent.com/u/11928027?v=4","gravatar_id":"","url":"https://api.github.com/users/lmckeen","html_url":"https://github.com/lmckeen","followers_url":"https://api.github.com/users/lmckeen/followers","following_url":"https://api.github.com/users/lmckeen/following{/other_user}","gists_url":"https://api.github.com/users/lmckeen/gists{/gist_id}","starred_url":"https://api.github.com/users/lmckeen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lmckeen/subscriptions","organizations_url":"https://api.github.com/users/lmckeen/orgs","repos_url":"https://api.github.com/users/lmckeen/repos","events_url":"https://api.github.com/users/lmckeen/events{/privacy}","received_events_url":"https://api.github.com/users/lmckeen/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/pulls/10/commits","review_comments_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/pulls/10/comments","review_comment_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/issues/10/comments","statuses_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/statuses/5dc7a07ca461a3383f32cd5e145e39011a7661ce","head":{"label":"SpringRoll:feature/remove-jquery","ref":"feature/remove-jquery","sha":"5dc7a07ca461a3383f32cd5e145e39011a7661ce","user":{"login":"SpringRoll","id":9436157,"avatar_url":"https://avatars1.githubusercontent.com/u/9436157?v=4","gravatar_id":"","url":"https://api.github.com/users/SpringRoll","html_url":"https://github.com/SpringRoll","followers_url":"https://api.github.com/users/SpringRoll/followers","following_url":"https://api.github.com/users/SpringRoll/following{/other_user}","gists_url":"https://api.github.com/users/SpringRoll/gists{/gist_id}","starred_url":"https://api.github.com/users/SpringRoll/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SpringRoll/subscriptions","organizations_url":"https://api.github.com/users/SpringRoll/orgs","repos_url":"https://api.github.com/users/SpringRoll/repos","events_url":"https://api.github.com/users/SpringRoll/events{/privacy}","received_events_url":"https://api.github.com/users/SpringRoll/received_events","type":"Organization","site_admin":false},"repo":{"id":47125363,"name":"SpringRollContainer","full_name":"SpringRoll/SpringRollContainer","owner":{"login":"SpringRoll","id":9436157,"avatar_url":"https://avatars1.githubusercontent.com/u/9436157?v=4","gravatar_id":"","url":"https://api.github.com/users/SpringRoll","html_url":"https://github.com/SpringRoll","followers_url":"https://api.github.com/users/SpringRoll/followers","following_url":"https://api.github.com/users/SpringRoll/following{/other_user}","gists_url":"https://api.github.com/users/SpringRoll/gists{/gist_id}","starred_url":"https://api.github.com/users/SpringRoll/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SpringRoll/subscriptions","organizations_url":"https://api.github.com/users/SpringRoll/orgs","repos_url":"https://api.github.com/users/SpringRoll/repos","events_url":"https://api.github.com/users/SpringRoll/events{/privacy}","received_events_url":"https://api.github.com/users/SpringRoll/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SpringRoll/SpringRollContainer","description":"The iframe controller for interacting with SpringRoll applications","fork":false,"url":"https://api.github.com/repos/SpringRoll/SpringRollContainer","forks_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/forks","keys_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/teams","hooks_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/hooks","issue_events_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/issues/events{/number}","events_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/events","assignees_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/assignees{/user}","branches_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/branches{/branch}","tags_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/tags","blobs_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/git/refs{/sha}","trees_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/statuses/{sha}","languages_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/languages","stargazers_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/stargazers","contributors_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/contributors","subscribers_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/subscribers","subscription_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/subscription","commits_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/commits{/sha}","git_commits_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/git/commits{/sha}","comments_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/comments{/number}","issue_comment_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/issues/comments{/number}","contents_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/contents/{+path}","compare_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/merges","archive_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/downloads","issues_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/issues{/number}","pulls_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/pulls{/number}","milestones_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/milestones{/number}","notifications_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/labels{/name}","releases_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/releases{/id}","deployments_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/deployments","created_at":"2015-11-30T14:48:40Z","updated_at":"2016-06-14T12:55:32Z","pushed_at":"2018-05-01T18:00:10Z","git_url":"git://github.com/SpringRoll/SpringRollContainer.git","ssh_url":"[email protected]:SpringRoll/SpringRollContainer.git","clone_url":"https://github.com/SpringRoll/SpringRollContainer.git","svn_url":"https://github.com/SpringRoll/SpringRollContainer","homepage":null,"size":356,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":5,"license":null,"forks":2,"open_issues":5,"watchers":0,"default_branch":"master"}},"base":{"label":"SpringRoll:master","ref":"master","sha":"77fab60ce4e0996161b98f28dab872d4a0ca6295","user":{"login":"SpringRoll","id":9436157,"avatar_url":"https://avatars1.githubusercontent.com/u/9436157?v=4","gravatar_id":"","url":"https://api.github.com/users/SpringRoll","html_url":"https://github.com/SpringRoll","followers_url":"https://api.github.com/users/SpringRoll/followers","following_url":"https://api.github.com/users/SpringRoll/following{/other_user}","gists_url":"https://api.github.com/users/SpringRoll/gists{/gist_id}","starred_url":"https://api.github.com/users/SpringRoll/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SpringRoll/subscriptions","organizations_url":"https://api.github.com/users/SpringRoll/orgs","repos_url":"https://api.github.com/users/SpringRoll/repos","events_url":"https://api.github.com/users/SpringRoll/events{/privacy}","received_events_url":"https://api.github.com/users/SpringRoll/received_events","type":"Organization","site_admin":false},"repo":{"id":47125363,"name":"SpringRollContainer","full_name":"SpringRoll/SpringRollContainer","owner":{"login":"SpringRoll","id":9436157,"avatar_url":"https://avatars1.githubusercontent.com/u/9436157?v=4","gravatar_id":"","url":"https://api.github.com/users/SpringRoll","html_url":"https://github.com/SpringRoll","followers_url":"https://api.github.com/users/SpringRoll/followers","following_url":"https://api.github.com/users/SpringRoll/following{/other_user}","gists_url":"https://api.github.com/users/SpringRoll/gists{/gist_id}","starred_url":"https://api.github.com/users/SpringRoll/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SpringRoll/subscriptions","organizations_url":"https://api.github.com/users/SpringRoll/orgs","repos_url":"https://api.github.com/users/SpringRoll/repos","events_url":"https://api.github.com/users/SpringRoll/events{/privacy}","received_events_url":"https://api.github.com/users/SpringRoll/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SpringRoll/SpringRollContainer","description":"The iframe controller for interacting with SpringRoll applications","fork":false,"url":"https://api.github.com/repos/SpringRoll/SpringRollContainer","forks_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/forks","keys_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/teams","hooks_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/hooks","issue_events_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/issues/events{/number}","events_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/events","assignees_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/assignees{/user}","branches_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/branches{/branch}","tags_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/tags","blobs_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/git/refs{/sha}","trees_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/statuses/{sha}","languages_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/languages","stargazers_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/stargazers","contributors_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/contributors","subscribers_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/subscribers","subscription_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/subscription","commits_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/commits{/sha}","git_commits_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/git/commits{/sha}","comments_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/comments{/number}","issue_comment_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/issues/comments{/number}","contents_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/contents/{+path}","compare_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/merges","archive_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/downloads","issues_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/issues{/number}","pulls_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/pulls{/number}","milestones_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/milestones{/number}","notifications_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/labels{/name}","releases_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/releases{/id}","deployments_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/deployments","created_at":"2015-11-30T14:48:40Z","updated_at":"2016-06-14T12:55:32Z","pushed_at":"2018-05-01T18:00:10Z","git_url":"git://github.com/SpringRoll/SpringRollContainer.git","ssh_url":"[email protected]:SpringRoll/SpringRollContainer.git","clone_url":"https://github.com/SpringRoll/SpringRollContainer.git","svn_url":"https://github.com/SpringRoll/SpringRollContainer","homepage":null,"size":356,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":5,"license":null,"forks":2,"open_issues":5,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SpringRoll/SpringRollContainer/pulls/10"},"html":{"href":"https://github.com/SpringRoll/SpringRollContainer/pull/10"},"issue":{"href":"https://api.github.com/repos/SpringRoll/SpringRollContainer/issues/10"},"comments":{"href":"https://api.github.com/repos/SpringRoll/SpringRollContainer/issues/10/comments"},"review_comments":{"href":"https://api.github.com/repos/SpringRoll/SpringRollContainer/pulls/10/comments"},"review_comment":{"href":"https://api.github.com/repos/SpringRoll/SpringRollContainer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SpringRoll/SpringRollContainer/pulls/10/commits"},"statuses":{"href":"https://api.github.com/repos/SpringRoll/SpringRollContainer/statuses/5dc7a07ca461a3383f32cd5e145e39011a7661ce"}},"author_association":"NONE"}} | {
"id": 47125363,
"name": "SpringRoll/SpringRollContainer",
"url": "https://api.github.com/repos/SpringRoll/SpringRollContainer"
} | {
"id": 2642329,
"login": "chipbell4",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2642329?",
"url": "https://api.github.com/users/chipbell4"
} | {
"id": 9436157,
"login": "SpringRoll",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9436157?",
"url": "https://api.github.com/orgs/SpringRoll"
} | 2018-05-01T22:49:47 | 7613836238 | {"actor":{"display_login":"chipbell4"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/confluentinc/ksql/pulls/comments/205846051","pull_request_review_id":141199605,"id":205846051,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNTg0NjA1MQ==","diff_hunk":"@@ -340,4 +349,22 @@ public void shouldCloseInternallyCreatedTopicClientOnClose() {\n // Then:\n verify(topicClient);\n }\n+\n+\n+ @Test\n+ public void shouldParseMultipleStatements() throws IOException {\n+ final String statementsString = new String(Files.readAllBytes(\n+ Paths.get(\"src/test/resources/SampleMultilineStatements.sql\")), \"UTF-8\");\n+\n+ final List<Pair<String, Statement>> parsedStatements =\n+ ksqlEngine.parseStatements(statementsString, new MetaStoreImpl(new TestFunctionRegistry()));\n+ assertThat(parsedStatements.size(), equalTo(7));","path":"ksql-engine/src/test/java/io/confluent/ksql/KsqlEngineTest.java","position":32,"original_position":32,"commit_id":"72c2fac5f669375889878ff03f0a47d97f0efbb7","original_commit_id":"72c2fac5f669375889878ff03f0a47d97f0efbb7","user":{"login":"big-andy-coates","id":8012398,"node_id":"MDQ6VXNlcjgwMTIzOTg=","avatar_url":"https://avatars0.githubusercontent.com/u/8012398?v=4","gravatar_id":"","url":"https://api.github.com/users/big-andy-coates","html_url":"https://github.com/big-andy-coates","followers_url":"https://api.github.com/users/big-andy-coates/followers","following_url":"https://api.github.com/users/big-andy-coates/following{/other_user}","gists_url":"https://api.github.com/users/big-andy-coates/gists{/gist_id}","starred_url":"https://api.github.com/users/big-andy-coates/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/big-andy-coates/subscriptions","organizations_url":"https://api.github.com/users/big-andy-coates/orgs","repos_url":"https://api.github.com/users/big-andy-coates/repos","events_url":"https://api.github.com/users/big-andy-coates/events{/privacy}","received_events_url":"https://api.github.com/users/big-andy-coates/received_events","type":"User","site_admin":false},"body":"If you had in the missing indexes you can replace this with:\r\n\r\n```\r\nassertThat(parsedStatements, contains(\r\n instanceOf(CreateStream.class), instanceOf(SetProperty.class), ... etc.\r\n));","created_at":"2018-07-27T17:30:29Z","updated_at":"2018-07-27T17:50:20Z","html_url":"https://github.com/confluentinc/ksql/pull/1599#discussion_r205846051","pull_request_url":"https://api.github.com/repos/confluentinc/ksql/pulls/1599","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/confluentinc/ksql/pulls/comments/205846051"},"html":{"href":"https://github.com/confluentinc/ksql/pull/1599#discussion_r205846051"},"pull_request":{"href":"https://api.github.com/repos/confluentinc/ksql/pulls/1599"}}},"pull_request":{"url":"https://api.github.com/repos/confluentinc/ksql/pulls/1599","id":202668416,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyNjY4NDE2","html_url":"https://github.com/confluentinc/ksql/pull/1599","diff_url":"https://github.com/confluentinc/ksql/pull/1599.diff","patch_url":"https://github.com/confluentinc/ksql/pull/1599.patch","issue_url":"https://api.github.com/repos/confluentinc/ksql/issues/1599","number":1599,"state":"open","locked":false,"title":"Sync Application(headless) mode behavior with the interactive mode.","user":{"login":"hjafarpour","id":16784742,"node_id":"MDQ6VXNlcjE2Nzg0NzQy","avatar_url":"https://avatars3.githubusercontent.com/u/16784742?v=4","gravatar_id":"","url":"https://api.github.com/users/hjafarpour","html_url":"https://github.com/hjafarpour","followers_url":"https://api.github.com/users/hjafarpour/followers","following_url":"https://api.github.com/users/hjafarpour/following{/other_user}","gists_url":"https://api.github.com/users/hjafarpour/gists{/gist_id}","starred_url":"https://api.github.com/users/hjafarpour/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hjafarpour/subscriptions","organizations_url":"https://api.github.com/users/hjafarpour/orgs","repos_url":"https://api.github.com/users/hjafarpour/repos","events_url":"https://api.github.com/users/hjafarpour/events{/privacy}","received_events_url":"https://api.github.com/users/hjafarpour/received_events","type":"User","site_admin":false},"body":"### Description \r\nThis PR syncs the behavior of Application(headless) mode with the interactive mode in the following cases:\r\n1. We can set config properties for each query the same way we do in the interactive mode.\r\n2. Query validation is done before query execution the same way we do for the interactive mode.\r\n\r\nThis fixes #1598 and #1320 .\r\n\r\nThis PR does not fix the issue with Avro schema inference. This need more discussion on how to handle schema changes in SR.\r\n\r\n### Testing done \r\nUnit tests were added.\r\n\r\n### Reviewer checklist\r\n- [ ] Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).\r\n- [ ] Ensure relevant issues are linked (description should include text like \"Fixes #<issue number>\")\r\n\r\n","created_at":"2018-07-19T20:02:20Z","updated_at":"2018-07-27T17:50:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2e4ab3131b50aaf44e00b85becc1a3ee1591ea65","assignee":{"login":"hjafarpour","id":16784742,"node_id":"MDQ6VXNlcjE2Nzg0NzQy","avatar_url":"https://avatars3.githubusercontent.com/u/16784742?v=4","gravatar_id":"","url":"https://api.github.com/users/hjafarpour","html_url":"https://github.com/hjafarpour","followers_url":"https://api.github.com/users/hjafarpour/followers","following_url":"https://api.github.com/users/hjafarpour/following{/other_user}","gists_url":"https://api.github.com/users/hjafarpour/gists{/gist_id}","starred_url":"https://api.github.com/users/hjafarpour/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hjafarpour/subscriptions","organizations_url":"https://api.github.com/users/hjafarpour/orgs","repos_url":"https://api.github.com/users/hjafarpour/repos","events_url":"https://api.github.com/users/hjafarpour/events{/privacy}","received_events_url":"https://api.github.com/users/hjafarpour/received_events","type":"User","site_admin":false},"assignees":[{"login":"hjafarpour","id":16784742,"node_id":"MDQ6VXNlcjE2Nzg0NzQy","avatar_url":"https://avatars3.githubusercontent.com/u/16784742?v=4","gravatar_id":"","url":"https://api.github.com/users/hjafarpour","html_url":"https://github.com/hjafarpour","followers_url":"https://api.github.com/users/hjafarpour/followers","following_url":"https://api.github.com/users/hjafarpour/following{/other_user}","gists_url":"https://api.github.com/users/hjafarpour/gists{/gist_id}","starred_url":"https://api.github.com/users/hjafarpour/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hjafarpour/subscriptions","organizations_url":"https://api.github.com/users/hjafarpour/orgs","repos_url":"https://api.github.com/users/hjafarpour/repos","events_url":"https://api.github.com/users/hjafarpour/events{/privacy}","received_events_url":"https://api.github.com/users/hjafarpour/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/confluentinc/ksql/pulls/1599/commits","review_comments_url":"https://api.github.com/repos/confluentinc/ksql/pulls/1599/comments","review_comment_url":"https://api.github.com/repos/confluentinc/ksql/pulls/comments{/number}","comments_url":"https://api.github.com/repos/confluentinc/ksql/issues/1599/comments","statuses_url":"https://api.github.com/repos/confluentinc/ksql/statuses/72c2fac5f669375889878ff03f0a47d97f0efbb7","head":{"label":"hjafarpour:Better-Multi-Line-Parsing","ref":"Better-Multi-Line-Parsing","sha":"72c2fac5f669375889878ff03f0a47d97f0efbb7","user":{"login":"hjafarpour","id":16784742,"node_id":"MDQ6VXNlcjE2Nzg0NzQy","avatar_url":"https://avatars3.githubusercontent.com/u/16784742?v=4","gravatar_id":"","url":"https://api.github.com/users/hjafarpour","html_url":"https://github.com/hjafarpour","followers_url":"https://api.github.com/users/hjafarpour/followers","following_url":"https://api.github.com/users/hjafarpour/following{/other_user}","gists_url":"https://api.github.com/users/hjafarpour/gists{/gist_id}","starred_url":"https://api.github.com/users/hjafarpour/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hjafarpour/subscriptions","organizations_url":"https://api.github.com/users/hjafarpour/orgs","repos_url":"https://api.github.com/users/hjafarpour/repos","events_url":"https://api.github.com/users/hjafarpour/events{/privacy}","received_events_url":"https://api.github.com/users/hjafarpour/received_events","type":"User","site_admin":false},"repo":{"id":102027996,"node_id":"MDEwOlJlcG9zaXRvcnkxMDIwMjc5OTY=","name":"ksql","full_name":"hjafarpour/ksql","owner":{"login":"hjafarpour","id":16784742,"node_id":"MDQ6VXNlcjE2Nzg0NzQy","avatar_url":"https://avatars3.githubusercontent.com/u/16784742?v=4","gravatar_id":"","url":"https://api.github.com/users/hjafarpour","html_url":"https://github.com/hjafarpour","followers_url":"https://api.github.com/users/hjafarpour/followers","following_url":"https://api.github.com/users/hjafarpour/following{/other_user}","gists_url":"https://api.github.com/users/hjafarpour/gists{/gist_id}","starred_url":"https://api.github.com/users/hjafarpour/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hjafarpour/subscriptions","organizations_url":"https://api.github.com/users/hjafarpour/orgs","repos_url":"https://api.github.com/users/hjafarpour/repos","events_url":"https://api.github.com/users/hjafarpour/events{/privacy}","received_events_url":"https://api.github.com/users/hjafarpour/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hjafarpour/ksql","description":"KSQL - a Streaming SQL Engine for Apache Kafka ","fork":true,"url":"https://api.github.com/repos/hjafarpour/ksql","forks_url":"https://api.github.com/repos/hjafarpour/ksql/forks","keys_url":"https://api.github.com/repos/hjafarpour/ksql/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hjafarpour/ksql/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hjafarpour/ksql/teams","hooks_url":"https://api.github.com/repos/hjafarpour/ksql/hooks","issue_events_url":"https://api.github.com/repos/hjafarpour/ksql/issues/events{/number}","events_url":"https://api.github.com/repos/hjafarpour/ksql/events","assignees_url":"https://api.github.com/repos/hjafarpour/ksql/assignees{/user}","branches_url":"https://api.github.com/repos/hjafarpour/ksql/branches{/branch}","tags_url":"https://api.github.com/repos/hjafarpour/ksql/tags","blobs_url":"https://api.github.com/repos/hjafarpour/ksql/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hjafarpour/ksql/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hjafarpour/ksql/git/refs{/sha}","trees_url":"https://api.github.com/repos/hjafarpour/ksql/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hjafarpour/ksql/statuses/{sha}","languages_url":"https://api.github.com/repos/hjafarpour/ksql/languages","stargazers_url":"https://api.github.com/repos/hjafarpour/ksql/stargazers","contributors_url":"https://api.github.com/repos/hjafarpour/ksql/contributors","subscribers_url":"https://api.github.com/repos/hjafarpour/ksql/subscribers","subscription_url":"https://api.github.com/repos/hjafarpour/ksql/subscription","commits_url":"https://api.github.com/repos/hjafarpour/ksql/commits{/sha}","git_commits_url":"https://api.github.com/repos/hjafarpour/ksql/git/commits{/sha}","comments_url":"https://api.github.com/repos/hjafarpour/ksql/comments{/number}","issue_comment_url":"https://api.github.com/repos/hjafarpour/ksql/issues/comments{/number}","contents_url":"https://api.github.com/repos/hjafarpour/ksql/contents/{+path}","compare_url":"https://api.github.com/repos/hjafarpour/ksql/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hjafarpour/ksql/merges","archive_url":"https://api.github.com/repos/hjafarpour/ksql/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hjafarpour/ksql/downloads","issues_url":"https://api.github.com/repos/hjafarpour/ksql/issues{/number}","pulls_url":"https://api.github.com/repos/hjafarpour/ksql/pulls{/number}","milestones_url":"https://api.github.com/repos/hjafarpour/ksql/milestones{/number}","notifications_url":"https://api.github.com/repos/hjafarpour/ksql/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hjafarpour/ksql/labels{/name}","releases_url":"https://api.github.com/repos/hjafarpour/ksql/releases{/id}","deployments_url":"https://api.github.com/repos/hjafarpour/ksql/deployments","created_at":"2017-08-31T17:43:25Z","updated_at":"2017-08-31T18:12:01Z","pushed_at":"2018-07-27T17:33:26Z","git_url":"git://github.com/hjafarpour/ksql.git","ssh_url":"[email protected]:hjafarpour/ksql.git","clone_url":"https://github.com/hjafarpour/ksql.git","svn_url":"https://github.com/hjafarpour/ksql","homepage":"","size":10070,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":2,"watchers":0,"default_branch":"0.1.x"}},"base":{"label":"confluentinc:master","ref":"master","sha":"16f545cca86d285fa66d527c042b92002b85580e","user":{"login":"confluentinc","id":9439498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk0Mzk0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/9439498?v=4","gravatar_id":"","url":"https://api.github.com/users/confluentinc","html_url":"https://github.com/confluentinc","followers_url":"https://api.github.com/users/confluentinc/followers","following_url":"https://api.github.com/users/confluentinc/following{/other_user}","gists_url":"https://api.github.com/users/confluentinc/gists{/gist_id}","starred_url":"https://api.github.com/users/confluentinc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/confluentinc/subscriptions","organizations_url":"https://api.github.com/users/confluentinc/orgs","repos_url":"https://api.github.com/users/confluentinc/repos","events_url":"https://api.github.com/users/confluentinc/events{/privacy}","received_events_url":"https://api.github.com/users/confluentinc/received_events","type":"Organization","site_admin":false},"repo":{"id":69400326,"node_id":"MDEwOlJlcG9zaXRvcnk2OTQwMDMyNg==","name":"ksql","full_name":"confluentinc/ksql","owner":{"login":"confluentinc","id":9439498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk0Mzk0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/9439498?v=4","gravatar_id":"","url":"https://api.github.com/users/confluentinc","html_url":"https://github.com/confluentinc","followers_url":"https://api.github.com/users/confluentinc/followers","following_url":"https://api.github.com/users/confluentinc/following{/other_user}","gists_url":"https://api.github.com/users/confluentinc/gists{/gist_id}","starred_url":"https://api.github.com/users/confluentinc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/confluentinc/subscriptions","organizations_url":"https://api.github.com/users/confluentinc/orgs","repos_url":"https://api.github.com/users/confluentinc/repos","events_url":"https://api.github.com/users/confluentinc/events{/privacy}","received_events_url":"https://api.github.com/users/confluentinc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/confluentinc/ksql","description":"KSQL - the Streaming SQL Engine for Apache Kafka ","fork":false,"url":"https://api.github.com/repos/confluentinc/ksql","forks_url":"https://api.github.com/repos/confluentinc/ksql/forks","keys_url":"https://api.github.com/repos/confluentinc/ksql/keys{/key_id}","collaborators_url":"https://api.github.com/repos/confluentinc/ksql/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/confluentinc/ksql/teams","hooks_url":"https://api.github.com/repos/confluentinc/ksql/hooks","issue_events_url":"https://api.github.com/repos/confluentinc/ksql/issues/events{/number}","events_url":"https://api.github.com/repos/confluentinc/ksql/events","assignees_url":"https://api.github.com/repos/confluentinc/ksql/assignees{/user}","branches_url":"https://api.github.com/repos/confluentinc/ksql/branches{/branch}","tags_url":"https://api.github.com/repos/confluentinc/ksql/tags","blobs_url":"https://api.github.com/repos/confluentinc/ksql/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/confluentinc/ksql/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/confluentinc/ksql/git/refs{/sha}","trees_url":"https://api.github.com/repos/confluentinc/ksql/git/trees{/sha}","statuses_url":"https://api.github.com/repos/confluentinc/ksql/statuses/{sha}","languages_url":"https://api.github.com/repos/confluentinc/ksql/languages","stargazers_url":"https://api.github.com/repos/confluentinc/ksql/stargazers","contributors_url":"https://api.github.com/repos/confluentinc/ksql/contributors","subscribers_url":"https://api.github.com/repos/confluentinc/ksql/subscribers","subscription_url":"https://api.github.com/repos/confluentinc/ksql/subscription","commits_url":"https://api.github.com/repos/confluentinc/ksql/commits{/sha}","git_commits_url":"https://api.github.com/repos/confluentinc/ksql/git/commits{/sha}","comments_url":"https://api.github.com/repos/confluentinc/ksql/comments{/number}","issue_comment_url":"https://api.github.com/repos/confluentinc/ksql/issues/comments{/number}","contents_url":"https://api.github.com/repos/confluentinc/ksql/contents/{+path}","compare_url":"https://api.github.com/repos/confluentinc/ksql/compare/{base}...{head}","merges_url":"https://api.github.com/repos/confluentinc/ksql/merges","archive_url":"https://api.github.com/repos/confluentinc/ksql/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/confluentinc/ksql/downloads","issues_url":"https://api.github.com/repos/confluentinc/ksql/issues{/number}","pulls_url":"https://api.github.com/repos/confluentinc/ksql/pulls{/number}","milestones_url":"https://api.github.com/repos/confluentinc/ksql/milestones{/number}","notifications_url":"https://api.github.com/repos/confluentinc/ksql/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/confluentinc/ksql/labels{/name}","releases_url":"https://api.github.com/repos/confluentinc/ksql/releases{/id}","deployments_url":"https://api.github.com/repos/confluentinc/ksql/deployments","created_at":"2016-09-27T21:30:15Z","updated_at":"2018-07-27T16:38:52Z","pushed_at":"2018-07-27T17:33:28Z","git_url":"git://github.com/confluentinc/ksql.git","ssh_url":"[email protected]:confluentinc/ksql.git","clone_url":"https://github.com/confluentinc/ksql.git","svn_url":"https://github.com/confluentinc/ksql","homepage":"","size":9200,"stargazers_count":1813,"watchers_count":1813,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":343,"mirror_url":null,"archived":false,"open_issues_count":335,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":343,"open_issues":335,"watchers":1813,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/confluentinc/ksql/pulls/1599"},"html":{"href":"https://github.com/confluentinc/ksql/pull/1599"},"issue":{"href":"https://api.github.com/repos/confluentinc/ksql/issues/1599"},"comments":{"href":"https://api.github.com/repos/confluentinc/ksql/issues/1599/comments"},"review_comments":{"href":"https://api.github.com/repos/confluentinc/ksql/pulls/1599/comments"},"review_comment":{"href":"https://api.github.com/repos/confluentinc/ksql/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/confluentinc/ksql/pulls/1599/commits"},"statuses":{"href":"https://api.github.com/repos/confluentinc/ksql/statuses/72c2fac5f669375889878ff03f0a47d97f0efbb7"}},"author_association":"MEMBER"}} | {
"id": 69400326,
"name": "confluentinc/ksql",
"url": "https://api.github.com/repos/confluentinc/ksql"
} | {
"id": 8012398,
"login": "big-andy-coates",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/8012398?",
"url": "https://api.github.com/users/big-andy-coates"
} | {
"id": 9439498,
"login": "confluentinc",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9439498?",
"url": "https://api.github.com/orgs/confluentinc"
} | 2018-07-27T17:30:29 | 8029951353 | {"actor":{"display_login":"big-andy-coates"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/confluentinc/ksql/pulls/comments/195262783","pull_request_review_id":128593603,"id":195262783,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NTI2Mjc4Mw==","diff_hunk":"@@ -717,4 +721,134 @@ public void shouldSetShowDescriptionsForShowQueriesDescriptions() {\n ListQueries listQueries = (ListQueries)statement;\n Assert.assertThat(listQueries.getShowExtended(), is(true));\n }\n+\n+ @Test\n+ public void shouldSetSpanExpressionWithSingleSpan() {\n+ String statementString = \"CREATE STREAM foobar as SELECT * from TEST1 JOIN ORDERS ON \"\n+ + \"TEST1.col1 = ORDERS.ORDERID SPAN 10 SECONDS;\";\n+\n+ Statement statement = KSQL_PARSER.buildAst(statementString, metaStore).get(0);\n+\n+ assertThat(statement, instanceOf(CreateStreamAsSelect.class));\n+\n+ CreateStreamAsSelect createStreamAsSelect = (CreateStreamAsSelect) statement;\n+ assertThat(createStreamAsSelect.getQuery().getQueryBody(),\n+ instanceOf(QuerySpecification.class));\n+\n+ QuerySpecification specification =\n+ (QuerySpecification) createStreamAsSelect.getQuery().getQueryBody();\n+\n+ assertThat(specification.getFrom(), instanceOf(Join.class));\n+\n+ Join join = (Join) specification.getFrom();","path":"ksql-parser/src/test/java/io/confluent/ksql/parser/KsqlParserTest.java","position":48,"original_position":48,"commit_id":"4d8438684f3c9cbecb1e640be93e4075aa2091c5","original_commit_id":"4d8438684f3c9cbecb1e640be93e4075aa2091c5","user":{"login":"hjafarpour","id":16784742,"node_id":"MDQ6VXNlcjE2Nzg0NzQy","avatar_url":"https://avatars3.githubusercontent.com/u/16784742?v=4","gravatar_id":"","url":"https://api.github.com/users/hjafarpour","html_url":"https://github.com/hjafarpour","followers_url":"https://api.github.com/users/hjafarpour/followers","following_url":"https://api.github.com/users/hjafarpour/following{/other_user}","gists_url":"https://api.github.com/users/hjafarpour/gists{/gist_id}","starred_url":"https://api.github.com/users/hjafarpour/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hjafarpour/subscriptions","organizations_url":"https://api.github.com/users/hjafarpour/orgs","repos_url":"https://api.github.com/users/hjafarpour/repos","events_url":"https://api.github.com/users/hjafarpour/events{/privacy}","received_events_url":"https://api.github.com/users/hjafarpour/received_events","type":"User","site_admin":false},"body":"final, this one and other places.","created_at":"2018-06-13T23:08:29Z","updated_at":"2018-06-13T23:18:53Z","html_url":"https://github.com/confluentinc/ksql/pull/1417#discussion_r195262783","pull_request_url":"https://api.github.com/repos/confluentinc/ksql/pulls/1417","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/confluentinc/ksql/pulls/comments/195262783"},"html":{"href":"https://github.com/confluentinc/ksql/pull/1417#discussion_r195262783"},"pull_request":{"href":"https://api.github.com/repos/confluentinc/ksql/pulls/1417"}}},"pull_request":{"url":"https://api.github.com/repos/confluentinc/ksql/pulls/1417","id":194449236,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0NDQ5MjM2","html_url":"https://github.com/confluentinc/ksql/pull/1417","diff_url":"https://github.com/confluentinc/ksql/pull/1417.diff","patch_url":"https://github.com/confluentinc/ksql/pull/1417.patch","issue_url":"https://api.github.com/repos/confluentinc/ksql/issues/1417","number":1417,"state":"open","locked":false,"title":"Add new join types to KSQL","user":{"login":"apurvam","id":830220,"node_id":"MDQ6VXNlcjgzMDIyMA==","avatar_url":"https://avatars0.githubusercontent.com/u/830220?v=4","gravatar_id":"","url":"https://api.github.com/users/apurvam","html_url":"https://github.com/apurvam","followers_url":"https://api.github.com/users/apurvam/followers","following_url":"https://api.github.com/users/apurvam/following{/other_user}","gists_url":"https://api.github.com/users/apurvam/gists{/gist_id}","starred_url":"https://api.github.com/users/apurvam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apurvam/subscriptions","organizations_url":"https://api.github.com/users/apurvam/orgs","repos_url":"https://api.github.com/users/apurvam/repos","events_url":"https://api.github.com/users/apurvam/events{/privacy}","received_events_url":"https://api.github.com/users/apurvam/received_events","type":"User","site_admin":false},"body":"### Description \r\n\r\nThis patch adds `LEFT`, `OUTER`, and `INNER` stream-stream and table-table joins. Additionally it adds an `INNER` stream-table join.\r\n\r\nMajority of the logic is in `JoinNode` where a `JoinHelper` is introduced to do the heavy lifting of executing the right join. This helper maximizes code reuse across the join types.\r\n\r\nLot's of redundant grammar constructs were removed as part of this patch. In particular, we had lexical support far `JOIN USING` instead of `JOIN ON`. We had support for CROSS joins in the grammar. These have been removed. \r\n\r\nFixes #731. Fixes #760 .\r\n\r\n### Testing done \r\n1. Parser testing is done `KsqlParserTest`.\r\n2. Correctness testing has been done using the QueryValidationTest which tests all the new join semantics.\r\n\r\nTodo:\r\n1. Add test cases to `JoinNodeTest` to check for failures like if a stream-stream join is executed without a window specification, or if an outer Stream-table is attempted.\r\n2. A couple of test cases in the existing `JoinNode` test were marked as ignored since they make assumption about the names of topology nodes, which have changed. I need to dig in and figure out the correct long term resolution.\r\n\r\nDocumentation updates will be prepared as part of a separate PR, as this is already quite large.\r\n\r\n### Reviewer checklist\r\n- [ ] Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).\r\n- [ ] Ensure relevant issues are linked (description should include text like \"Fixes #<issue number>\")\r\n\r\n","created_at":"2018-06-13T01:33:41Z","updated_at":"2018-06-13T23:18:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6fd1062f3ff5ddd42e9fafc13a3e7bd18d673b24","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/confluentinc/ksql/pulls/1417/commits","review_comments_url":"https://api.github.com/repos/confluentinc/ksql/pulls/1417/comments","review_comment_url":"https://api.github.com/repos/confluentinc/ksql/pulls/comments{/number}","comments_url":"https://api.github.com/repos/confluentinc/ksql/issues/1417/comments","statuses_url":"https://api.github.com/repos/confluentinc/ksql/statuses/4d8438684f3c9cbecb1e640be93e4075aa2091c5","head":{"label":"apurvam:new-joins","ref":"new-joins","sha":"4d8438684f3c9cbecb1e640be93e4075aa2091c5","user":{"login":"apurvam","id":830220,"node_id":"MDQ6VXNlcjgzMDIyMA==","avatar_url":"https://avatars0.githubusercontent.com/u/830220?v=4","gravatar_id":"","url":"https://api.github.com/users/apurvam","html_url":"https://github.com/apurvam","followers_url":"https://api.github.com/users/apurvam/followers","following_url":"https://api.github.com/users/apurvam/following{/other_user}","gists_url":"https://api.github.com/users/apurvam/gists{/gist_id}","starred_url":"https://api.github.com/users/apurvam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apurvam/subscriptions","organizations_url":"https://api.github.com/users/apurvam/orgs","repos_url":"https://api.github.com/users/apurvam/repos","events_url":"https://api.github.com/users/apurvam/events{/privacy}","received_events_url":"https://api.github.com/users/apurvam/received_events","type":"User","site_admin":false},"repo":{"id":106761843,"node_id":"MDEwOlJlcG9zaXRvcnkxMDY3NjE4NDM=","name":"ksql","full_name":"apurvam/ksql","owner":{"login":"apurvam","id":830220,"node_id":"MDQ6VXNlcjgzMDIyMA==","avatar_url":"https://avatars0.githubusercontent.com/u/830220?v=4","gravatar_id":"","url":"https://api.github.com/users/apurvam","html_url":"https://github.com/apurvam","followers_url":"https://api.github.com/users/apurvam/followers","following_url":"https://api.github.com/users/apurvam/following{/other_user}","gists_url":"https://api.github.com/users/apurvam/gists{/gist_id}","starred_url":"https://api.github.com/users/apurvam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apurvam/subscriptions","organizations_url":"https://api.github.com/users/apurvam/orgs","repos_url":"https://api.github.com/users/apurvam/repos","events_url":"https://api.github.com/users/apurvam/events{/privacy}","received_events_url":"https://api.github.com/users/apurvam/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/apurvam/ksql","description":"KSQL - a Streaming SQL Engine for Apache Kafka ","fork":true,"url":"https://api.github.com/repos/apurvam/ksql","forks_url":"https://api.github.com/repos/apurvam/ksql/forks","keys_url":"https://api.github.com/repos/apurvam/ksql/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apurvam/ksql/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apurvam/ksql/teams","hooks_url":"https://api.github.com/repos/apurvam/ksql/hooks","issue_events_url":"https://api.github.com/repos/apurvam/ksql/issues/events{/number}","events_url":"https://api.github.com/repos/apurvam/ksql/events","assignees_url":"https://api.github.com/repos/apurvam/ksql/assignees{/user}","branches_url":"https://api.github.com/repos/apurvam/ksql/branches{/branch}","tags_url":"https://api.github.com/repos/apurvam/ksql/tags","blobs_url":"https://api.github.com/repos/apurvam/ksql/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apurvam/ksql/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apurvam/ksql/git/refs{/sha}","trees_url":"https://api.github.com/repos/apurvam/ksql/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apurvam/ksql/statuses/{sha}","languages_url":"https://api.github.com/repos/apurvam/ksql/languages","stargazers_url":"https://api.github.com/repos/apurvam/ksql/stargazers","contributors_url":"https://api.github.com/repos/apurvam/ksql/contributors","subscribers_url":"https://api.github.com/repos/apurvam/ksql/subscribers","subscription_url":"https://api.github.com/repos/apurvam/ksql/subscription","commits_url":"https://api.github.com/repos/apurvam/ksql/commits{/sha}","git_commits_url":"https://api.github.com/repos/apurvam/ksql/git/commits{/sha}","comments_url":"https://api.github.com/repos/apurvam/ksql/comments{/number}","issue_comment_url":"https://api.github.com/repos/apurvam/ksql/issues/comments{/number}","contents_url":"https://api.github.com/repos/apurvam/ksql/contents/{+path}","compare_url":"https://api.github.com/repos/apurvam/ksql/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apurvam/ksql/merges","archive_url":"https://api.github.com/repos/apurvam/ksql/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apurvam/ksql/downloads","issues_url":"https://api.github.com/repos/apurvam/ksql/issues{/number}","pulls_url":"https://api.github.com/repos/apurvam/ksql/pulls{/number}","milestones_url":"https://api.github.com/repos/apurvam/ksql/milestones{/number}","notifications_url":"https://api.github.com/repos/apurvam/ksql/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apurvam/ksql/labels{/name}","releases_url":"https://api.github.com/repos/apurvam/ksql/releases{/id}","deployments_url":"https://api.github.com/repos/apurvam/ksql/deployments","created_at":"2017-10-13T01:11:55Z","updated_at":"2017-10-13T01:11:58Z","pushed_at":"2018-06-13T22:37:06Z","git_url":"git://github.com/apurvam/ksql.git","ssh_url":"[email protected]:apurvam/ksql.git","clone_url":"https://github.com/apurvam/ksql.git","svn_url":"https://github.com/apurvam/ksql","homepage":"","size":7666,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"0.1.x"}},"base":{"label":"confluentinc:5.0.x","ref":"5.0.x","sha":"8eece10151113cddc40e971c6729a29e9c9b92d5","user":{"login":"confluentinc","id":9439498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk0Mzk0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/9439498?v=4","gravatar_id":"","url":"https://api.github.com/users/confluentinc","html_url":"https://github.com/confluentinc","followers_url":"https://api.github.com/users/confluentinc/followers","following_url":"https://api.github.com/users/confluentinc/following{/other_user}","gists_url":"https://api.github.com/users/confluentinc/gists{/gist_id}","starred_url":"https://api.github.com/users/confluentinc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/confluentinc/subscriptions","organizations_url":"https://api.github.com/users/confluentinc/orgs","repos_url":"https://api.github.com/users/confluentinc/repos","events_url":"https://api.github.com/users/confluentinc/events{/privacy}","received_events_url":"https://api.github.com/users/confluentinc/received_events","type":"Organization","site_admin":false},"repo":{"id":69400326,"node_id":"MDEwOlJlcG9zaXRvcnk2OTQwMDMyNg==","name":"ksql","full_name":"confluentinc/ksql","owner":{"login":"confluentinc","id":9439498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk0Mzk0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/9439498?v=4","gravatar_id":"","url":"https://api.github.com/users/confluentinc","html_url":"https://github.com/confluentinc","followers_url":"https://api.github.com/users/confluentinc/followers","following_url":"https://api.github.com/users/confluentinc/following{/other_user}","gists_url":"https://api.github.com/users/confluentinc/gists{/gist_id}","starred_url":"https://api.github.com/users/confluentinc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/confluentinc/subscriptions","organizations_url":"https://api.github.com/users/confluentinc/orgs","repos_url":"https://api.github.com/users/confluentinc/repos","events_url":"https://api.github.com/users/confluentinc/events{/privacy}","received_events_url":"https://api.github.com/users/confluentinc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/confluentinc/ksql","description":"KSQL - the Streaming SQL Engine for Apache Kafka ","fork":false,"url":"https://api.github.com/repos/confluentinc/ksql","forks_url":"https://api.github.com/repos/confluentinc/ksql/forks","keys_url":"https://api.github.com/repos/confluentinc/ksql/keys{/key_id}","collaborators_url":"https://api.github.com/repos/confluentinc/ksql/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/confluentinc/ksql/teams","hooks_url":"https://api.github.com/repos/confluentinc/ksql/hooks","issue_events_url":"https://api.github.com/repos/confluentinc/ksql/issues/events{/number}","events_url":"https://api.github.com/repos/confluentinc/ksql/events","assignees_url":"https://api.github.com/repos/confluentinc/ksql/assignees{/user}","branches_url":"https://api.github.com/repos/confluentinc/ksql/branches{/branch}","tags_url":"https://api.github.com/repos/confluentinc/ksql/tags","blobs_url":"https://api.github.com/repos/confluentinc/ksql/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/confluentinc/ksql/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/confluentinc/ksql/git/refs{/sha}","trees_url":"https://api.github.com/repos/confluentinc/ksql/git/trees{/sha}","statuses_url":"https://api.github.com/repos/confluentinc/ksql/statuses/{sha}","languages_url":"https://api.github.com/repos/confluentinc/ksql/languages","stargazers_url":"https://api.github.com/repos/confluentinc/ksql/stargazers","contributors_url":"https://api.github.com/repos/confluentinc/ksql/contributors","subscribers_url":"https://api.github.com/repos/confluentinc/ksql/subscribers","subscription_url":"https://api.github.com/repos/confluentinc/ksql/subscription","commits_url":"https://api.github.com/repos/confluentinc/ksql/commits{/sha}","git_commits_url":"https://api.github.com/repos/confluentinc/ksql/git/commits{/sha}","comments_url":"https://api.github.com/repos/confluentinc/ksql/comments{/number}","issue_comment_url":"https://api.github.com/repos/confluentinc/ksql/issues/comments{/number}","contents_url":"https://api.github.com/repos/confluentinc/ksql/contents/{+path}","compare_url":"https://api.github.com/repos/confluentinc/ksql/compare/{base}...{head}","merges_url":"https://api.github.com/repos/confluentinc/ksql/merges","archive_url":"https://api.github.com/repos/confluentinc/ksql/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/confluentinc/ksql/downloads","issues_url":"https://api.github.com/repos/confluentinc/ksql/issues{/number}","pulls_url":"https://api.github.com/repos/confluentinc/ksql/pulls{/number}","milestones_url":"https://api.github.com/repos/confluentinc/ksql/milestones{/number}","notifications_url":"https://api.github.com/repos/confluentinc/ksql/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/confluentinc/ksql/labels{/name}","releases_url":"https://api.github.com/repos/confluentinc/ksql/releases{/id}","deployments_url":"https://api.github.com/repos/confluentinc/ksql/deployments","created_at":"2016-09-27T21:30:15Z","updated_at":"2018-06-13T22:02:17Z","pushed_at":"2018-06-13T23:03:02Z","git_url":"git://github.com/confluentinc/ksql.git","ssh_url":"[email protected]:confluentinc/ksql.git","clone_url":"https://github.com/confluentinc/ksql.git","svn_url":"https://github.com/confluentinc/ksql","homepage":"","size":7975,"stargazers_count":1714,"watchers_count":1714,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":320,"mirror_url":null,"archived":false,"open_issues_count":307,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":320,"open_issues":307,"watchers":1714,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/confluentinc/ksql/pulls/1417"},"html":{"href":"https://github.com/confluentinc/ksql/pull/1417"},"issue":{"href":"https://api.github.com/repos/confluentinc/ksql/issues/1417"},"comments":{"href":"https://api.github.com/repos/confluentinc/ksql/issues/1417/comments"},"review_comments":{"href":"https://api.github.com/repos/confluentinc/ksql/pulls/1417/comments"},"review_comment":{"href":"https://api.github.com/repos/confluentinc/ksql/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/confluentinc/ksql/pulls/1417/commits"},"statuses":{"href":"https://api.github.com/repos/confluentinc/ksql/statuses/4d8438684f3c9cbecb1e640be93e4075aa2091c5"}},"author_association":"COLLABORATOR"}} | {
"id": 69400326,
"name": "confluentinc/ksql",
"url": "https://api.github.com/repos/confluentinc/ksql"
} | {
"id": 16784742,
"login": "hjafarpour",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/16784742?",
"url": "https://api.github.com/users/hjafarpour"
} | {
"id": 9439498,
"login": "confluentinc",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9439498?",
"url": "https://api.github.com/orgs/confluentinc"
} | 2018-06-13T23:08:29 | 7821929705 | {"actor":{"display_login":"hjafarpour"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/confluentinc/confluent-kafka-python/pulls/comments/196139435","pull_request_review_id":129636424,"id":196139435,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NjEzOTQzNQ==","diff_hunk":"@@ -62,6 +62,7 @@ function run_single_in_docker {\n \n pip install confluent_kafka --no-index -f $wheelhouse\n \n+ # Pytest relies on a new version of 6; later versions of pip fail to remove older versions gracefully","path":"tools/test-manylinux.sh","position":null,"original_position":4,"commit_id":"ac184ba84da1ca26ad92ae1a2562d3e4fa56e4d2","original_commit_id":"ac184ba84da1ca26ad92ae1a2562d3e4fa56e4d2","user":{"login":"edenhill","id":524990,"node_id":"MDQ6VXNlcjUyNDk5MA==","avatar_url":"https://avatars0.githubusercontent.com/u/524990?v=4","gravatar_id":"","url":"https://api.github.com/users/edenhill","html_url":"https://github.com/edenhill","followers_url":"https://api.github.com/users/edenhill/followers","following_url":"https://api.github.com/users/edenhill/following{/other_user}","gists_url":"https://api.github.com/users/edenhill/gists{/gist_id}","starred_url":"https://api.github.com/users/edenhill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edenhill/subscriptions","organizations_url":"https://api.github.com/users/edenhill/orgs","repos_url":"https://api.github.com/users/edenhill/repos","events_url":"https://api.github.com/users/edenhill/events{/privacy}","received_events_url":"https://api.github.com/users/edenhill/received_events","type":"User","site_admin":false},"body":"\"new version of 6\"? Do you mean six?","created_at":"2018-06-18T16:18:04Z","updated_at":"2018-06-18T16:18:04Z","html_url":"https://github.com/confluentinc/confluent-kafka-python/pull/403#discussion_r196139435","pull_request_url":"https://api.github.com/repos/confluentinc/confluent-kafka-python/pulls/403","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/confluentinc/confluent-kafka-python/pulls/comments/196139435"},"html":{"href":"https://github.com/confluentinc/confluent-kafka-python/pull/403#discussion_r196139435"},"pull_request":{"href":"https://api.github.com/repos/confluentinc/confluent-kafka-python/pulls/403"}}},"pull_request":{"url":"https://api.github.com/repos/confluentinc/confluent-kafka-python/pulls/403","id":195404624,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1NDA0NjI0","html_url":"https://github.com/confluentinc/confluent-kafka-python/pull/403","diff_url":"https://github.com/confluentinc/confluent-kafka-python/pull/403.diff","patch_url":"https://github.com/confluentinc/confluent-kafka-python/pull/403.patch","issue_url":"https://api.github.com/repos/confluentinc/confluent-kafka-python/issues/403","number":403,"state":"open","locked":false,"title":"Unblock 0.11.5 RC packaging","user":{"login":"rnpridgeon","id":5313961,"node_id":"MDQ6VXNlcjUzMTM5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/5313961?v=4","gravatar_id":"","url":"https://api.github.com/users/rnpridgeon","html_url":"https://github.com/rnpridgeon","followers_url":"https://api.github.com/users/rnpridgeon/followers","following_url":"https://api.github.com/users/rnpridgeon/following{/other_user}","gists_url":"https://api.github.com/users/rnpridgeon/gists{/gist_id}","starred_url":"https://api.github.com/users/rnpridgeon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rnpridgeon/subscriptions","organizations_url":"https://api.github.com/users/rnpridgeon/orgs","repos_url":"https://api.github.com/users/rnpridgeon/repos","events_url":"https://api.github.com/users/rnpridgeon/events{/privacy}","received_events_url":"https://api.github.com/users/rnpridgeon/received_events","type":"User","site_admin":false},"body":"Couldn't come up with a good solution in time but this should unblock us for the time being ","created_at":"2018-06-18T01:02:06Z","updated_at":"2018-06-18T16:18:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cbb3e48b4dd35cc9ce1a5569c2b16f2ea17be3aa","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/confluentinc/confluent-kafka-python/pulls/403/commits","review_comments_url":"https://api.github.com/repos/confluentinc/confluent-kafka-python/pulls/403/comments","review_comment_url":"https://api.github.com/repos/confluentinc/confluent-kafka-python/pulls/comments{/number}","comments_url":"https://api.github.com/repos/confluentinc/confluent-kafka-python/issues/403/comments","statuses_url":"https://api.github.com/repos/confluentinc/confluent-kafka-python/statuses/ac184ba84da1ca26ad92ae1a2562d3e4fa56e4d2","head":{"label":"rnpridgeon:packaging_update","ref":"packaging_update","sha":"ac184ba84da1ca26ad92ae1a2562d3e4fa56e4d2","user":{"login":"rnpridgeon","id":5313961,"node_id":"MDQ6VXNlcjUzMTM5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/5313961?v=4","gravatar_id":"","url":"https://api.github.com/users/rnpridgeon","html_url":"https://github.com/rnpridgeon","followers_url":"https://api.github.com/users/rnpridgeon/followers","following_url":"https://api.github.com/users/rnpridgeon/following{/other_user}","gists_url":"https://api.github.com/users/rnpridgeon/gists{/gist_id}","starred_url":"https://api.github.com/users/rnpridgeon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rnpridgeon/subscriptions","organizations_url":"https://api.github.com/users/rnpridgeon/orgs","repos_url":"https://api.github.com/users/rnpridgeon/repos","events_url":"https://api.github.com/users/rnpridgeon/events{/privacy}","received_events_url":"https://api.github.com/users/rnpridgeon/received_events","type":"User","site_admin":false},"repo":{"id":132631125,"node_id":"MDEwOlJlcG9zaXRvcnkxMzI2MzExMjU=","name":"confluent-kafka-python","full_name":"rnpridgeon/confluent-kafka-python","owner":{"login":"rnpridgeon","id":5313961,"node_id":"MDQ6VXNlcjUzMTM5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/5313961?v=4","gravatar_id":"","url":"https://api.github.com/users/rnpridgeon","html_url":"https://github.com/rnpridgeon","followers_url":"https://api.github.com/users/rnpridgeon/followers","following_url":"https://api.github.com/users/rnpridgeon/following{/other_user}","gists_url":"https://api.github.com/users/rnpridgeon/gists{/gist_id}","starred_url":"https://api.github.com/users/rnpridgeon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rnpridgeon/subscriptions","organizations_url":"https://api.github.com/users/rnpridgeon/orgs","repos_url":"https://api.github.com/users/rnpridgeon/repos","events_url":"https://api.github.com/users/rnpridgeon/events{/privacy}","received_events_url":"https://api.github.com/users/rnpridgeon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rnpridgeon/confluent-kafka-python","description":"Confluent's Apache Kafka Python client","fork":true,"url":"https://api.github.com/repos/rnpridgeon/confluent-kafka-python","forks_url":"https://api.github.com/repos/rnpridgeon/confluent-kafka-python/forks","keys_url":"https://api.github.com/repos/rnpridgeon/confluent-kafka-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rnpridgeon/confluent-kafka-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rnpridgeon/confluent-kafka-python/teams","hooks_url":"https://api.github.com/repos/rnpridgeon/confluent-kafka-python/hooks","issue_events_url":"https://api.github.com/repos/rnpridgeon/confluent-kafka-python/issues/events{/number}","events_url":"https://api.github.com/repos/rnpridgeon/confluent-kafka-python/events","assignees_url":"https://api.github.com/repos/rnpridgeon/confluent-kafka-python/assignees{/user}","branches_url":"https://api.github.com/repos/rnpridgeon/confluent-kafka-python/branches{/branch}","tags_url":"https://api.github.com/repos/rnpridgeon/confluent-kafka-python/tags","blobs_url":"https://api.github.com/repos/rnpridgeon/confluent-kafka-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rnpridgeon/confluent-kafka-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rnpridgeon/confluent-kafka-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/rnpridgeon/confluent-kafka-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rnpridgeon/confluent-kafka-python/statuses/{sha}","languages_url":"https://api.github.com/repos/rnpridgeon/confluent-kafka-python/languages","stargazers_url":"https://api.github.com/repos/rnpridgeon/confluent-kafka-python/stargazers","contributors_url":"https://api.github.com/repos/rnpridgeon/confluent-kafka-python/contributors","subscribers_url":"https://api.github.com/repos/rnpridgeon/confluent-kafka-python/subscribers","subscription_url":"https://api.github.com/repos/rnpridgeon/confluent-kafka-python/subscription","commits_url":"https://api.github.com/repos/rnpridgeon/confluent-kafka-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/rnpridgeon/confluent-kafka-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/rnpridgeon/confluent-kafka-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/rnpridgeon/confluent-kafka-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/rnpridgeon/confluent-kafka-python/contents/{+path}","compare_url":"https://api.github.com/repos/rnpridgeon/confluent-kafka-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rnpridgeon/confluent-kafka-python/merges","archive_url":"https://api.github.com/repos/rnpridgeon/confluent-kafka-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rnpridgeon/confluent-kafka-python/downloads","issues_url":"https://api.github.com/repos/rnpridgeon/confluent-kafka-python/issues{/number}","pulls_url":"https://api.github.com/repos/rnpridgeon/confluent-kafka-python/pulls{/number}","milestones_url":"https://api.github.com/repos/rnpridgeon/confluent-kafka-python/milestones{/number}","notifications_url":"https://api.github.com/repos/rnpridgeon/confluent-kafka-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rnpridgeon/confluent-kafka-python/labels{/name}","releases_url":"https://api.github.com/repos/rnpridgeon/confluent-kafka-python/releases{/id}","deployments_url":"https://api.github.com/repos/rnpridgeon/confluent-kafka-python/deployments","created_at":"2018-05-08T15:46:11Z","updated_at":"2018-06-15T22:49:38Z","pushed_at":"2018-06-18T16:02:43Z","git_url":"git://github.com/rnpridgeon/confluent-kafka-python.git","ssh_url":"[email protected]:rnpridgeon/confluent-kafka-python.git","clone_url":"https://github.com/rnpridgeon/confluent-kafka-python.git","svn_url":"https://github.com/rnpridgeon/confluent-kafka-python","homepage":"http://docs.confluent.io/current/clients/confluent-kafka-python","size":603,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"confluentinc:master","ref":"master","sha":"292a9f908ec10aa34d8fda3af73e73896acce35b","user":{"login":"confluentinc","id":9439498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk0Mzk0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/9439498?v=4","gravatar_id":"","url":"https://api.github.com/users/confluentinc","html_url":"https://github.com/confluentinc","followers_url":"https://api.github.com/users/confluentinc/followers","following_url":"https://api.github.com/users/confluentinc/following{/other_user}","gists_url":"https://api.github.com/users/confluentinc/gists{/gist_id}","starred_url":"https://api.github.com/users/confluentinc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/confluentinc/subscriptions","organizations_url":"https://api.github.com/users/confluentinc/orgs","repos_url":"https://api.github.com/users/confluentinc/repos","events_url":"https://api.github.com/users/confluentinc/events{/privacy}","received_events_url":"https://api.github.com/users/confluentinc/received_events","type":"Organization","site_admin":false},"repo":{"id":56217288,"node_id":"MDEwOlJlcG9zaXRvcnk1NjIxNzI4OA==","name":"confluent-kafka-python","full_name":"confluentinc/confluent-kafka-python","owner":{"login":"confluentinc","id":9439498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk0Mzk0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/9439498?v=4","gravatar_id":"","url":"https://api.github.com/users/confluentinc","html_url":"https://github.com/confluentinc","followers_url":"https://api.github.com/users/confluentinc/followers","following_url":"https://api.github.com/users/confluentinc/following{/other_user}","gists_url":"https://api.github.com/users/confluentinc/gists{/gist_id}","starred_url":"https://api.github.com/users/confluentinc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/confluentinc/subscriptions","organizations_url":"https://api.github.com/users/confluentinc/orgs","repos_url":"https://api.github.com/users/confluentinc/repos","events_url":"https://api.github.com/users/confluentinc/events{/privacy}","received_events_url":"https://api.github.com/users/confluentinc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/confluentinc/confluent-kafka-python","description":"Confluent's Apache Kafka Python client","fork":false,"url":"https://api.github.com/repos/confluentinc/confluent-kafka-python","forks_url":"https://api.github.com/repos/confluentinc/confluent-kafka-python/forks","keys_url":"https://api.github.com/repos/confluentinc/confluent-kafka-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/confluentinc/confluent-kafka-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/confluentinc/confluent-kafka-python/teams","hooks_url":"https://api.github.com/repos/confluentinc/confluent-kafka-python/hooks","issue_events_url":"https://api.github.com/repos/confluentinc/confluent-kafka-python/issues/events{/number}","events_url":"https://api.github.com/repos/confluentinc/confluent-kafka-python/events","assignees_url":"https://api.github.com/repos/confluentinc/confluent-kafka-python/assignees{/user}","branches_url":"https://api.github.com/repos/confluentinc/confluent-kafka-python/branches{/branch}","tags_url":"https://api.github.com/repos/confluentinc/confluent-kafka-python/tags","blobs_url":"https://api.github.com/repos/confluentinc/confluent-kafka-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/confluentinc/confluent-kafka-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/confluentinc/confluent-kafka-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/confluentinc/confluent-kafka-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/confluentinc/confluent-kafka-python/statuses/{sha}","languages_url":"https://api.github.com/repos/confluentinc/confluent-kafka-python/languages","stargazers_url":"https://api.github.com/repos/confluentinc/confluent-kafka-python/stargazers","contributors_url":"https://api.github.com/repos/confluentinc/confluent-kafka-python/contributors","subscribers_url":"https://api.github.com/repos/confluentinc/confluent-kafka-python/subscribers","subscription_url":"https://api.github.com/repos/confluentinc/confluent-kafka-python/subscription","commits_url":"https://api.github.com/repos/confluentinc/confluent-kafka-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/confluentinc/confluent-kafka-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/confluentinc/confluent-kafka-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/confluentinc/confluent-kafka-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/confluentinc/confluent-kafka-python/contents/{+path}","compare_url":"https://api.github.com/repos/confluentinc/confluent-kafka-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/confluentinc/confluent-kafka-python/merges","archive_url":"https://api.github.com/repos/confluentinc/confluent-kafka-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/confluentinc/confluent-kafka-python/downloads","issues_url":"https://api.github.com/repos/confluentinc/confluent-kafka-python/issues{/number}","pulls_url":"https://api.github.com/repos/confluentinc/confluent-kafka-python/pulls{/number}","milestones_url":"https://api.github.com/repos/confluentinc/confluent-kafka-python/milestones{/number}","notifications_url":"https://api.github.com/repos/confluentinc/confluent-kafka-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/confluentinc/confluent-kafka-python/labels{/name}","releases_url":"https://api.github.com/repos/confluentinc/confluent-kafka-python/releases{/id}","deployments_url":"https://api.github.com/repos/confluentinc/confluent-kafka-python/deployments","created_at":"2016-04-14T07:40:41Z","updated_at":"2018-06-18T13:48:50Z","pushed_at":"2018-06-18T16:02:45Z","git_url":"git://github.com/confluentinc/confluent-kafka-python.git","ssh_url":"[email protected]:confluentinc/confluent-kafka-python.git","clone_url":"https://github.com/confluentinc/confluent-kafka-python.git","svn_url":"https://github.com/confluentinc/confluent-kafka-python","homepage":"http://docs.confluent.io/current/clients/confluent-kafka-python","size":562,"stargazers_count":699,"watchers_count":699,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":190,"mirror_url":null,"archived":false,"open_issues_count":42,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":190,"open_issues":42,"watchers":699,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/confluentinc/confluent-kafka-python/pulls/403"},"html":{"href":"https://github.com/confluentinc/confluent-kafka-python/pull/403"},"issue":{"href":"https://api.github.com/repos/confluentinc/confluent-kafka-python/issues/403"},"comments":{"href":"https://api.github.com/repos/confluentinc/confluent-kafka-python/issues/403/comments"},"review_comments":{"href":"https://api.github.com/repos/confluentinc/confluent-kafka-python/pulls/403/comments"},"review_comment":{"href":"https://api.github.com/repos/confluentinc/confluent-kafka-python/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/confluentinc/confluent-kafka-python/pulls/403/commits"},"statuses":{"href":"https://api.github.com/repos/confluentinc/confluent-kafka-python/statuses/ac184ba84da1ca26ad92ae1a2562d3e4fa56e4d2"}},"author_association":"CONTRIBUTOR"}} | {
"id": 56217288,
"name": "confluentinc/confluent-kafka-python",
"url": "https://api.github.com/repos/confluentinc/confluent-kafka-python"
} | {
"id": 524990,
"login": "edenhill",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/524990?",
"url": "https://api.github.com/users/edenhill"
} | {
"id": 9439498,
"login": "confluentinc",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9439498?",
"url": "https://api.github.com/orgs/confluentinc"
} | 2018-06-18T16:18:04 | 7840421236 | {"actor":{"display_login":"edenhill"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/0-complexity/openvcloud/pulls/comments/214548529","pull_request_review_id":151628598,"id":214548529,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNDU0ODUyOQ==","diff_hunk":"@@ -0,0 +1,86 @@\n+#!/usr/bin/env python\n+import github\n+import argparse\n+import yaml\n+from urlparse import urlparse","path":"scripts/versions/releasenotes","position":5,"original_position":5,"commit_id":"c2f5bd279bf8dabdca540080227bfeebb261e854","original_commit_id":"c2f5bd279bf8dabdca540080227bfeebb261e854","user":{"login":"grimpy","id":143869,"node_id":"MDQ6VXNlcjE0Mzg2OQ==","avatar_url":"https://avatars1.githubusercontent.com/u/143869?v=4","gravatar_id":"","url":"https://api.github.com/users/grimpy","html_url":"https://github.com/grimpy","followers_url":"https://api.github.com/users/grimpy/followers","following_url":"https://api.github.com/users/grimpy/following{/other_user}","gists_url":"https://api.github.com/users/grimpy/gists{/gist_id}","starred_url":"https://api.github.com/users/grimpy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grimpy/subscriptions","organizations_url":"https://api.github.com/users/grimpy/orgs","repos_url":"https://api.github.com/users/grimpy/repos","events_url":"https://api.github.com/users/grimpy/events{/privacy}","received_events_url":"https://api.github.com/users/grimpy/received_events","type":"User","site_admin":false},"body":"not sure if we want to be python2/python3 here but in python3 this is `from urllib.parse import urlparse`","created_at":"2018-09-02T18:03:41Z","updated_at":"2018-09-02T18:03:47Z","html_url":"https://github.com/0-complexity/openvcloud/pull/1758#discussion_r214548529","pull_request_url":"https://api.github.com/repos/0-complexity/openvcloud/pulls/1758","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/0-complexity/openvcloud/pulls/comments/214548529"},"html":{"href":"https://github.com/0-complexity/openvcloud/pull/1758#discussion_r214548529"},"pull_request":{"href":"https://api.github.com/repos/0-complexity/openvcloud/pulls/1758"}}},"pull_request":{"url":"https://api.github.com/repos/0-complexity/openvcloud/pulls/1758","id":212603393,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEyNjAzMzkz","html_url":"https://github.com/0-complexity/openvcloud/pull/1758","diff_url":"https://github.com/0-complexity/openvcloud/pull/1758.diff","patch_url":"https://github.com/0-complexity/openvcloud/pull/1758.patch","issue_url":"https://api.github.com/repos/0-complexity/openvcloud/issues/1758","number":1758,"state":"open","locked":false,"title":"add release notes generation script","user":{"login":"alichaddad","id":24762033,"node_id":"MDQ6VXNlcjI0NzYyMDMz","avatar_url":"https://avatars1.githubusercontent.com/u/24762033?v=4","gravatar_id":"","url":"https://api.github.com/users/alichaddad","html_url":"https://github.com/alichaddad","followers_url":"https://api.github.com/users/alichaddad/followers","following_url":"https://api.github.com/users/alichaddad/following{/other_user}","gists_url":"https://api.github.com/users/alichaddad/gists{/gist_id}","starred_url":"https://api.github.com/users/alichaddad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alichaddad/subscriptions","organizations_url":"https://api.github.com/users/alichaddad/orgs","repos_url":"https://api.github.com/users/alichaddad/repos","events_url":"https://api.github.com/users/alichaddad/events{/privacy}","received_events_url":"https://api.github.com/users/alichaddad/received_events","type":"User","site_admin":false},"body":"Relates to https://github.com/0-complexity/openvcloud/issues/1716","created_at":"2018-09-02T17:36:59Z","updated_at":"2018-09-02T18:03:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"39bed81e5052566c9cdb5d880bd8b66bf31f35c0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":340764791,"node_id":"MDU6TGFiZWwzNDA3NjQ3OTE=","url":"https://api.github.com/repos/0-complexity/openvcloud/labels/state_inprogress","name":"state_inprogress","color":"c2e0c6","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/0-complexity/openvcloud/pulls/1758/commits","review_comments_url":"https://api.github.com/repos/0-complexity/openvcloud/pulls/1758/comments","review_comment_url":"https://api.github.com/repos/0-complexity/openvcloud/pulls/comments{/number}","comments_url":"https://api.github.com/repos/0-complexity/openvcloud/issues/1758/comments","statuses_url":"https://api.github.com/repos/0-complexity/openvcloud/statuses/c2f5bd279bf8dabdca540080227bfeebb261e854","head":{"label":"0-complexity:release_notes","ref":"release_notes","sha":"c2f5bd279bf8dabdca540080227bfeebb261e854","user":{"login":"0-complexity","id":9442740,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk0NDI3NDA=","avatar_url":"https://avatars1.githubusercontent.com/u/9442740?v=4","gravatar_id":"","url":"https://api.github.com/users/0-complexity","html_url":"https://github.com/0-complexity","followers_url":"https://api.github.com/users/0-complexity/followers","following_url":"https://api.github.com/users/0-complexity/following{/other_user}","gists_url":"https://api.github.com/users/0-complexity/gists{/gist_id}","starred_url":"https://api.github.com/users/0-complexity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/0-complexity/subscriptions","organizations_url":"https://api.github.com/users/0-complexity/orgs","repos_url":"https://api.github.com/users/0-complexity/repos","events_url":"https://api.github.com/users/0-complexity/events{/privacy}","received_events_url":"https://api.github.com/users/0-complexity/received_events","type":"Organization","site_admin":false},"repo":{"id":52881479,"node_id":"MDEwOlJlcG9zaXRvcnk1Mjg4MTQ3OQ==","name":"openvcloud","full_name":"0-complexity/openvcloud","owner":{"login":"0-complexity","id":9442740,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk0NDI3NDA=","avatar_url":"https://avatars1.githubusercontent.com/u/9442740?v=4","gravatar_id":"","url":"https://api.github.com/users/0-complexity","html_url":"https://github.com/0-complexity","followers_url":"https://api.github.com/users/0-complexity/followers","following_url":"https://api.github.com/users/0-complexity/following{/other_user}","gists_url":"https://api.github.com/users/0-complexity/gists{/gist_id}","starred_url":"https://api.github.com/users/0-complexity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/0-complexity/subscriptions","organizations_url":"https://api.github.com/users/0-complexity/orgs","repos_url":"https://api.github.com/users/0-complexity/repos","events_url":"https://api.github.com/users/0-complexity/events{/privacy}","received_events_url":"https://api.github.com/users/0-complexity/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/0-complexity/openvcloud","description":"OpenvCloud","fork":false,"url":"https://api.github.com/repos/0-complexity/openvcloud","forks_url":"https://api.github.com/repos/0-complexity/openvcloud/forks","keys_url":"https://api.github.com/repos/0-complexity/openvcloud/keys{/key_id}","collaborators_url":"https://api.github.com/repos/0-complexity/openvcloud/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/0-complexity/openvcloud/teams","hooks_url":"https://api.github.com/repos/0-complexity/openvcloud/hooks","issue_events_url":"https://api.github.com/repos/0-complexity/openvcloud/issues/events{/number}","events_url":"https://api.github.com/repos/0-complexity/openvcloud/events","assignees_url":"https://api.github.com/repos/0-complexity/openvcloud/assignees{/user}","branches_url":"https://api.github.com/repos/0-complexity/openvcloud/branches{/branch}","tags_url":"https://api.github.com/repos/0-complexity/openvcloud/tags","blobs_url":"https://api.github.com/repos/0-complexity/openvcloud/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/0-complexity/openvcloud/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/0-complexity/openvcloud/git/refs{/sha}","trees_url":"https://api.github.com/repos/0-complexity/openvcloud/git/trees{/sha}","statuses_url":"https://api.github.com/repos/0-complexity/openvcloud/statuses/{sha}","languages_url":"https://api.github.com/repos/0-complexity/openvcloud/languages","stargazers_url":"https://api.github.com/repos/0-complexity/openvcloud/stargazers","contributors_url":"https://api.github.com/repos/0-complexity/openvcloud/contributors","subscribers_url":"https://api.github.com/repos/0-complexity/openvcloud/subscribers","subscription_url":"https://api.github.com/repos/0-complexity/openvcloud/subscription","commits_url":"https://api.github.com/repos/0-complexity/openvcloud/commits{/sha}","git_commits_url":"https://api.github.com/repos/0-complexity/openvcloud/git/commits{/sha}","comments_url":"https://api.github.com/repos/0-complexity/openvcloud/comments{/number}","issue_comment_url":"https://api.github.com/repos/0-complexity/openvcloud/issues/comments{/number}","contents_url":"https://api.github.com/repos/0-complexity/openvcloud/contents/{+path}","compare_url":"https://api.github.com/repos/0-complexity/openvcloud/compare/{base}...{head}","merges_url":"https://api.github.com/repos/0-complexity/openvcloud/merges","archive_url":"https://api.github.com/repos/0-complexity/openvcloud/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/0-complexity/openvcloud/downloads","issues_url":"https://api.github.com/repos/0-complexity/openvcloud/issues{/number}","pulls_url":"https://api.github.com/repos/0-complexity/openvcloud/pulls{/number}","milestones_url":"https://api.github.com/repos/0-complexity/openvcloud/milestones{/number}","notifications_url":"https://api.github.com/repos/0-complexity/openvcloud/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/0-complexity/openvcloud/labels{/name}","releases_url":"https://api.github.com/repos/0-complexity/openvcloud/releases{/id}","deployments_url":"https://api.github.com/repos/0-complexity/openvcloud/deployments","created_at":"2016-03-01T14:09:28Z","updated_at":"2018-09-02T14:12:15Z","pushed_at":"2018-09-02T17:53:12Z","git_url":"git://github.com/0-complexity/openvcloud.git","ssh_url":"[email protected]:0-complexity/openvcloud.git","clone_url":"https://github.com/0-complexity/openvcloud.git","svn_url":"https://github.com/0-complexity/openvcloud","homepage":null,"size":103320,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":136,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2,"open_issues":136,"watchers":0,"default_branch":"master"}},"base":{"label":"0-complexity:master","ref":"master","sha":"c4803c123a4eee503955ece6cc30f0b9c507f026","user":{"login":"0-complexity","id":9442740,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk0NDI3NDA=","avatar_url":"https://avatars1.githubusercontent.com/u/9442740?v=4","gravatar_id":"","url":"https://api.github.com/users/0-complexity","html_url":"https://github.com/0-complexity","followers_url":"https://api.github.com/users/0-complexity/followers","following_url":"https://api.github.com/users/0-complexity/following{/other_user}","gists_url":"https://api.github.com/users/0-complexity/gists{/gist_id}","starred_url":"https://api.github.com/users/0-complexity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/0-complexity/subscriptions","organizations_url":"https://api.github.com/users/0-complexity/orgs","repos_url":"https://api.github.com/users/0-complexity/repos","events_url":"https://api.github.com/users/0-complexity/events{/privacy}","received_events_url":"https://api.github.com/users/0-complexity/received_events","type":"Organization","site_admin":false},"repo":{"id":52881479,"node_id":"MDEwOlJlcG9zaXRvcnk1Mjg4MTQ3OQ==","name":"openvcloud","full_name":"0-complexity/openvcloud","owner":{"login":"0-complexity","id":9442740,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk0NDI3NDA=","avatar_url":"https://avatars1.githubusercontent.com/u/9442740?v=4","gravatar_id":"","url":"https://api.github.com/users/0-complexity","html_url":"https://github.com/0-complexity","followers_url":"https://api.github.com/users/0-complexity/followers","following_url":"https://api.github.com/users/0-complexity/following{/other_user}","gists_url":"https://api.github.com/users/0-complexity/gists{/gist_id}","starred_url":"https://api.github.com/users/0-complexity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/0-complexity/subscriptions","organizations_url":"https://api.github.com/users/0-complexity/orgs","repos_url":"https://api.github.com/users/0-complexity/repos","events_url":"https://api.github.com/users/0-complexity/events{/privacy}","received_events_url":"https://api.github.com/users/0-complexity/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/0-complexity/openvcloud","description":"OpenvCloud","fork":false,"url":"https://api.github.com/repos/0-complexity/openvcloud","forks_url":"https://api.github.com/repos/0-complexity/openvcloud/forks","keys_url":"https://api.github.com/repos/0-complexity/openvcloud/keys{/key_id}","collaborators_url":"https://api.github.com/repos/0-complexity/openvcloud/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/0-complexity/openvcloud/teams","hooks_url":"https://api.github.com/repos/0-complexity/openvcloud/hooks","issue_events_url":"https://api.github.com/repos/0-complexity/openvcloud/issues/events{/number}","events_url":"https://api.github.com/repos/0-complexity/openvcloud/events","assignees_url":"https://api.github.com/repos/0-complexity/openvcloud/assignees{/user}","branches_url":"https://api.github.com/repos/0-complexity/openvcloud/branches{/branch}","tags_url":"https://api.github.com/repos/0-complexity/openvcloud/tags","blobs_url":"https://api.github.com/repos/0-complexity/openvcloud/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/0-complexity/openvcloud/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/0-complexity/openvcloud/git/refs{/sha}","trees_url":"https://api.github.com/repos/0-complexity/openvcloud/git/trees{/sha}","statuses_url":"https://api.github.com/repos/0-complexity/openvcloud/statuses/{sha}","languages_url":"https://api.github.com/repos/0-complexity/openvcloud/languages","stargazers_url":"https://api.github.com/repos/0-complexity/openvcloud/stargazers","contributors_url":"https://api.github.com/repos/0-complexity/openvcloud/contributors","subscribers_url":"https://api.github.com/repos/0-complexity/openvcloud/subscribers","subscription_url":"https://api.github.com/repos/0-complexity/openvcloud/subscription","commits_url":"https://api.github.com/repos/0-complexity/openvcloud/commits{/sha}","git_commits_url":"https://api.github.com/repos/0-complexity/openvcloud/git/commits{/sha}","comments_url":"https://api.github.com/repos/0-complexity/openvcloud/comments{/number}","issue_comment_url":"https://api.github.com/repos/0-complexity/openvcloud/issues/comments{/number}","contents_url":"https://api.github.com/repos/0-complexity/openvcloud/contents/{+path}","compare_url":"https://api.github.com/repos/0-complexity/openvcloud/compare/{base}...{head}","merges_url":"https://api.github.com/repos/0-complexity/openvcloud/merges","archive_url":"https://api.github.com/repos/0-complexity/openvcloud/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/0-complexity/openvcloud/downloads","issues_url":"https://api.github.com/repos/0-complexity/openvcloud/issues{/number}","pulls_url":"https://api.github.com/repos/0-complexity/openvcloud/pulls{/number}","milestones_url":"https://api.github.com/repos/0-complexity/openvcloud/milestones{/number}","notifications_url":"https://api.github.com/repos/0-complexity/openvcloud/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/0-complexity/openvcloud/labels{/name}","releases_url":"https://api.github.com/repos/0-complexity/openvcloud/releases{/id}","deployments_url":"https://api.github.com/repos/0-complexity/openvcloud/deployments","created_at":"2016-03-01T14:09:28Z","updated_at":"2018-09-02T14:12:15Z","pushed_at":"2018-09-02T17:53:12Z","git_url":"git://github.com/0-complexity/openvcloud.git","ssh_url":"[email protected]:0-complexity/openvcloud.git","clone_url":"https://github.com/0-complexity/openvcloud.git","svn_url":"https://github.com/0-complexity/openvcloud","homepage":null,"size":103320,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":136,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2,"open_issues":136,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/0-complexity/openvcloud/pulls/1758"},"html":{"href":"https://github.com/0-complexity/openvcloud/pull/1758"},"issue":{"href":"https://api.github.com/repos/0-complexity/openvcloud/issues/1758"},"comments":{"href":"https://api.github.com/repos/0-complexity/openvcloud/issues/1758/comments"},"review_comments":{"href":"https://api.github.com/repos/0-complexity/openvcloud/pulls/1758/comments"},"review_comment":{"href":"https://api.github.com/repos/0-complexity/openvcloud/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/0-complexity/openvcloud/pulls/1758/commits"},"statuses":{"href":"https://api.github.com/repos/0-complexity/openvcloud/statuses/c2f5bd279bf8dabdca540080227bfeebb261e854"}},"author_association":"CONTRIBUTOR"}} | {
"id": 52881479,
"name": "0-complexity/openvcloud",
"url": "https://api.github.com/repos/0-complexity/openvcloud"
} | {
"id": 143869,
"login": "grimpy",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/143869?",
"url": "https://api.github.com/users/grimpy"
} | {
"id": 9442740,
"login": "0-complexity",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9442740?",
"url": "https://api.github.com/orgs/0-complexity"
} | 2018-09-02T18:03:41 | 8203160592 | {"actor":{"display_login":"grimpy"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/qTox/qTox/pulls/comments/230656924","pull_request_review_id":171440502,"id":230656924,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMDY1NjkyNA==","diff_hunk":"@@ -0,0 +1,152 @@\n+#include \"bootstrapnodeupdater.h\"\n+\n+#include <QJsonArray>\n+#include <QJsonDocument>\n+#include <QJsonObject>\n+#include <QNetworkAccessManager>\n+#include <QNetworkReply>\n+#include <QRegularExpression>\n+\n+namespace {\n+ const QUrl NodeListAddress{\"https://nodes.tox.chat/json\"};\n+ const QLatin1Literal jsonNodeArrayName{\"nodes\"};\n+ const QLatin1Literal emptyAddress{\"-\"};\n+ const QRegularExpression ToxPkRegEx(QString(\"(^|\\\\s)[A-Fa-f0-9]{%1}($|\\\\s)\").arg(64));\n+}\n+\n+namespace NodeFields {\n+ const QLatin1Literal status_udp{\"status_udp\"};\n+ const QLatin1Literal status_tcp{\"status_tcp\"};\n+ const QLatin1Literal ipv4{\"ipv4\"};\n+ const QLatin1Literal ipv6{\"ipv6\"};\n+ const QLatin1Literal public_key{\"public_key\"};\n+ const QLatin1Literal port{\"port\"};\n+ const QLatin1Literal maintainer{\"maintainer\"};\n+ // TODO(sudden6): make use of this field once we differentiate between TCP nodes, and bootstrap nodes\n+ const QLatin1Literal tcp_ports{\"tcp_ports\"};\n+ const QStringList neededFields{status_udp, status_tcp, ipv4, ipv6, public_key, port, maintainer};\n+}\n+\n+/**\n+ * @brief Fetches a list of currently online bootstrap nodes from node.tox.chat\n+ * @param proxy Proxy to use for the lookup, must outlive this object\n+ */\n+BootstrapNodeUpdater::BootstrapNodeUpdater(const QNetworkProxy &proxy, QObject* parent)\n+ : QObject{parent}\n+ , proxy{proxy}\n+{\n+}\n+\n+bool BootstrapNodeUpdater::requestBootstrapNodes()\n+{\n+ nam.setProxy(proxy);\n+ connect(&nam, &QNetworkAccessManager::finished, this, &BootstrapNodeUpdater::onRequestComplete);\n+\n+ QNetworkRequest request{NodeListAddress};\n+ request.setHeader(QNetworkRequest::ContentTypeHeader, \"application/json\");\n+\n+ nam.get(request);\n+ return true;\n+}\n+\n+void BootstrapNodeUpdater::onRequestComplete(QNetworkReply* reply)\n+{\n+ if(reply->error() != QNetworkReply::NoError){","path":"src/net/bootstrapnodeupdater.cpp","position":54,"original_position":54,"commit_id":"0a1a0f110f8ebfebfd20f5a2052db1f80e4701c5","original_commit_id":"9e03136b1f9bbf6fd3aaed8280ae6960a48140be","user":{"login":"Diadlo","id":6306608,"node_id":"MDQ6VXNlcjYzMDY2MDg=","avatar_url":"https://avatars3.githubusercontent.com/u/6306608?v=4","gravatar_id":"","url":"https://api.github.com/users/Diadlo","html_url":"https://github.com/Diadlo","followers_url":"https://api.github.com/users/Diadlo/followers","following_url":"https://api.github.com/users/Diadlo/following{/other_user}","gists_url":"https://api.github.com/users/Diadlo/gists{/gist_id}","starred_url":"https://api.github.com/users/Diadlo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Diadlo/subscriptions","organizations_url":"https://api.github.com/users/Diadlo/orgs","repos_url":"https://api.github.com/users/Diadlo/repos","events_url":"https://api.github.com/users/Diadlo/events{/privacy}","received_events_url":"https://api.github.com/users/Diadlo/received_events","type":"User","site_admin":false},"body":"Add space after `if` and `for` for all PR","created_at":"2018-11-05T07:55:51Z","updated_at":"2018-11-05T07:58:10Z","html_url":"https://github.com/qTox/qTox/pull/5425#discussion_r230656924","pull_request_url":"https://api.github.com/repos/qTox/qTox/pulls/5425","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/qTox/qTox/pulls/comments/230656924"},"html":{"href":"https://github.com/qTox/qTox/pull/5425#discussion_r230656924"},"pull_request":{"href":"https://api.github.com/repos/qTox/qTox/pulls/5425"}}},"pull_request":{"url":"https://api.github.com/repos/qTox/qTox/pulls/5425","id":228204231,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4MjA0MjMx","html_url":"https://github.com/qTox/qTox/pull/5425","diff_url":"https://github.com/qTox/qTox/pull/5425.diff","patch_url":"https://github.com/qTox/qTox/pull/5425.patch","issue_url":"https://api.github.com/repos/qTox/qTox/issues/5425","number":5425,"state":"open","locked":false,"title":"[WIP] Update list of boostrap nodes directly from nodes.tox.chat","user":{"login":"sudden6","id":5585762,"node_id":"MDQ6VXNlcjU1ODU3NjI=","avatar_url":"https://avatars2.githubusercontent.com/u/5585762?v=4","gravatar_id":"","url":"https://api.github.com/users/sudden6","html_url":"https://github.com/sudden6","followers_url":"https://api.github.com/users/sudden6/followers","following_url":"https://api.github.com/users/sudden6/following{/other_user}","gists_url":"https://api.github.com/users/sudden6/gists{/gist_id}","starred_url":"https://api.github.com/users/sudden6/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sudden6/subscriptions","organizations_url":"https://api.github.com/users/sudden6/orgs","repos_url":"https://api.github.com/users/sudden6/repos","events_url":"https://api.github.com/users/sudden6/events{/privacy}","received_events_url":"https://api.github.com/users/sudden6/received_events","type":"User","site_admin":false},"body":"- [ ] Commits follow our [git commit guidelines](https://github.com/qTox/qTox/blob/master/CONTRIBUTING.md#git-commit-guidelines)\r\n\r\nThis should help us connect to the network faster in case the list changes.\r\n\r\nIntegration in the toxcore bootstrap process is currently missing.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/qtox/qtox/5425)\n<!-- Reviewable:end -->\n","created_at":"2018-11-04T21:28:32Z","updated_at":"2018-11-05T07:58:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c900ed71058b4dcc077e9cf19b18c3caa5d5b233","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/qTox/qTox/pulls/5425/commits","review_comments_url":"https://api.github.com/repos/qTox/qTox/pulls/5425/comments","review_comment_url":"https://api.github.com/repos/qTox/qTox/pulls/comments{/number}","comments_url":"https://api.github.com/repos/qTox/qTox/issues/5425/comments","statuses_url":"https://api.github.com/repos/qTox/qTox/statuses/0a1a0f110f8ebfebfd20f5a2052db1f80e4701c5","head":{"label":"sudden6:feat/nodes_update","ref":"feat/nodes_update","sha":"0a1a0f110f8ebfebfd20f5a2052db1f80e4701c5","user":{"login":"sudden6","id":5585762,"node_id":"MDQ6VXNlcjU1ODU3NjI=","avatar_url":"https://avatars2.githubusercontent.com/u/5585762?v=4","gravatar_id":"","url":"https://api.github.com/users/sudden6","html_url":"https://github.com/sudden6","followers_url":"https://api.github.com/users/sudden6/followers","following_url":"https://api.github.com/users/sudden6/following{/other_user}","gists_url":"https://api.github.com/users/sudden6/gists{/gist_id}","starred_url":"https://api.github.com/users/sudden6/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sudden6/subscriptions","organizations_url":"https://api.github.com/users/sudden6/orgs","repos_url":"https://api.github.com/users/sudden6/repos","events_url":"https://api.github.com/users/sudden6/events{/privacy}","received_events_url":"https://api.github.com/users/sudden6/received_events","type":"User","site_admin":false},"repo":{"id":30754426,"node_id":"MDEwOlJlcG9zaXRvcnkzMDc1NDQyNg==","name":"qTox","full_name":"sudden6/qTox","private":false,"owner":{"login":"sudden6","id":5585762,"node_id":"MDQ6VXNlcjU1ODU3NjI=","avatar_url":"https://avatars2.githubusercontent.com/u/5585762?v=4","gravatar_id":"","url":"https://api.github.com/users/sudden6","html_url":"https://github.com/sudden6","followers_url":"https://api.github.com/users/sudden6/followers","following_url":"https://api.github.com/users/sudden6/following{/other_user}","gists_url":"https://api.github.com/users/sudden6/gists{/gist_id}","starred_url":"https://api.github.com/users/sudden6/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sudden6/subscriptions","organizations_url":"https://api.github.com/users/sudden6/orgs","repos_url":"https://api.github.com/users/sudden6/repos","events_url":"https://api.github.com/users/sudden6/events{/privacy}","received_events_url":"https://api.github.com/users/sudden6/received_events","type":"User","site_admin":false},"html_url":"https://github.com/sudden6/qTox","description":"Powerful Tox client that follows the Tox design guidelines. Formerly called toxgui","fork":true,"url":"https://api.github.com/repos/sudden6/qTox","forks_url":"https://api.github.com/repos/sudden6/qTox/forks","keys_url":"https://api.github.com/repos/sudden6/qTox/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sudden6/qTox/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sudden6/qTox/teams","hooks_url":"https://api.github.com/repos/sudden6/qTox/hooks","issue_events_url":"https://api.github.com/repos/sudden6/qTox/issues/events{/number}","events_url":"https://api.github.com/repos/sudden6/qTox/events","assignees_url":"https://api.github.com/repos/sudden6/qTox/assignees{/user}","branches_url":"https://api.github.com/repos/sudden6/qTox/branches{/branch}","tags_url":"https://api.github.com/repos/sudden6/qTox/tags","blobs_url":"https://api.github.com/repos/sudden6/qTox/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sudden6/qTox/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sudden6/qTox/git/refs{/sha}","trees_url":"https://api.github.com/repos/sudden6/qTox/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sudden6/qTox/statuses/{sha}","languages_url":"https://api.github.com/repos/sudden6/qTox/languages","stargazers_url":"https://api.github.com/repos/sudden6/qTox/stargazers","contributors_url":"https://api.github.com/repos/sudden6/qTox/contributors","subscribers_url":"https://api.github.com/repos/sudden6/qTox/subscribers","subscription_url":"https://api.github.com/repos/sudden6/qTox/subscription","commits_url":"https://api.github.com/repos/sudden6/qTox/commits{/sha}","git_commits_url":"https://api.github.com/repos/sudden6/qTox/git/commits{/sha}","comments_url":"https://api.github.com/repos/sudden6/qTox/comments{/number}","issue_comment_url":"https://api.github.com/repos/sudden6/qTox/issues/comments{/number}","contents_url":"https://api.github.com/repos/sudden6/qTox/contents/{+path}","compare_url":"https://api.github.com/repos/sudden6/qTox/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sudden6/qTox/merges","archive_url":"https://api.github.com/repos/sudden6/qTox/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sudden6/qTox/downloads","issues_url":"https://api.github.com/repos/sudden6/qTox/issues{/number}","pulls_url":"https://api.github.com/repos/sudden6/qTox/pulls{/number}","milestones_url":"https://api.github.com/repos/sudden6/qTox/milestones{/number}","notifications_url":"https://api.github.com/repos/sudden6/qTox/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sudden6/qTox/labels{/name}","releases_url":"https://api.github.com/repos/sudden6/qTox/releases{/id}","deployments_url":"https://api.github.com/repos/sudden6/qTox/deployments","created_at":"2015-02-13T11:55:07Z","updated_at":"2018-10-15T13:13:20Z","pushed_at":"2018-11-04T21:27:03Z","git_url":"git://github.com/sudden6/qTox.git","ssh_url":"[email protected]:sudden6/qTox.git","clone_url":"https://github.com/sudden6/qTox.git","svn_url":"https://github.com/sudden6/qTox","homepage":"http://utoxisfinished.info","size":31408,"stargazers_count":2,"watchers_count":2,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"qTox:master","ref":"master","sha":"9ecb6da0511cd5952d29713ef3146de6200082a0","user":{"login":"qTox","id":9519241,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk1MTkyNDE=","avatar_url":"https://avatars1.githubusercontent.com/u/9519241?v=4","gravatar_id":"","url":"https://api.github.com/users/qTox","html_url":"https://github.com/qTox","followers_url":"https://api.github.com/users/qTox/followers","following_url":"https://api.github.com/users/qTox/following{/other_user}","gists_url":"https://api.github.com/users/qTox/gists{/gist_id}","starred_url":"https://api.github.com/users/qTox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qTox/subscriptions","organizations_url":"https://api.github.com/users/qTox/orgs","repos_url":"https://api.github.com/users/qTox/repos","events_url":"https://api.github.com/users/qTox/events{/privacy}","received_events_url":"https://api.github.com/users/qTox/received_events","type":"Organization","site_admin":false},"repo":{"id":21179164,"node_id":"MDEwOlJlcG9zaXRvcnkyMTE3OTE2NA==","name":"qTox","full_name":"qTox/qTox","private":false,"owner":{"login":"qTox","id":9519241,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk1MTkyNDE=","avatar_url":"https://avatars1.githubusercontent.com/u/9519241?v=4","gravatar_id":"","url":"https://api.github.com/users/qTox","html_url":"https://github.com/qTox","followers_url":"https://api.github.com/users/qTox/followers","following_url":"https://api.github.com/users/qTox/following{/other_user}","gists_url":"https://api.github.com/users/qTox/gists{/gist_id}","starred_url":"https://api.github.com/users/qTox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qTox/subscriptions","organizations_url":"https://api.github.com/users/qTox/orgs","repos_url":"https://api.github.com/users/qTox/repos","events_url":"https://api.github.com/users/qTox/events{/privacy}","received_events_url":"https://api.github.com/users/qTox/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/qTox/qTox","description":"qTox is a chat, voice, video, and file transfer IM client using the encrypted peer-to-peer Tox protocol.","fork":false,"url":"https://api.github.com/repos/qTox/qTox","forks_url":"https://api.github.com/repos/qTox/qTox/forks","keys_url":"https://api.github.com/repos/qTox/qTox/keys{/key_id}","collaborators_url":"https://api.github.com/repos/qTox/qTox/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/qTox/qTox/teams","hooks_url":"https://api.github.com/repos/qTox/qTox/hooks","issue_events_url":"https://api.github.com/repos/qTox/qTox/issues/events{/number}","events_url":"https://api.github.com/repos/qTox/qTox/events","assignees_url":"https://api.github.com/repos/qTox/qTox/assignees{/user}","branches_url":"https://api.github.com/repos/qTox/qTox/branches{/branch}","tags_url":"https://api.github.com/repos/qTox/qTox/tags","blobs_url":"https://api.github.com/repos/qTox/qTox/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/qTox/qTox/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/qTox/qTox/git/refs{/sha}","trees_url":"https://api.github.com/repos/qTox/qTox/git/trees{/sha}","statuses_url":"https://api.github.com/repos/qTox/qTox/statuses/{sha}","languages_url":"https://api.github.com/repos/qTox/qTox/languages","stargazers_url":"https://api.github.com/repos/qTox/qTox/stargazers","contributors_url":"https://api.github.com/repos/qTox/qTox/contributors","subscribers_url":"https://api.github.com/repos/qTox/qTox/subscribers","subscription_url":"https://api.github.com/repos/qTox/qTox/subscription","commits_url":"https://api.github.com/repos/qTox/qTox/commits{/sha}","git_commits_url":"https://api.github.com/repos/qTox/qTox/git/commits{/sha}","comments_url":"https://api.github.com/repos/qTox/qTox/comments{/number}","issue_comment_url":"https://api.github.com/repos/qTox/qTox/issues/comments{/number}","contents_url":"https://api.github.com/repos/qTox/qTox/contents/{+path}","compare_url":"https://api.github.com/repos/qTox/qTox/compare/{base}...{head}","merges_url":"https://api.github.com/repos/qTox/qTox/merges","archive_url":"https://api.github.com/repos/qTox/qTox/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/qTox/qTox/downloads","issues_url":"https://api.github.com/repos/qTox/qTox/issues{/number}","pulls_url":"https://api.github.com/repos/qTox/qTox/pulls{/number}","milestones_url":"https://api.github.com/repos/qTox/qTox/milestones{/number}","notifications_url":"https://api.github.com/repos/qTox/qTox/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/qTox/qTox/labels{/name}","releases_url":"https://api.github.com/repos/qTox/qTox/releases{/id}","deployments_url":"https://api.github.com/repos/qTox/qTox/deployments","created_at":"2014-06-24T20:09:04Z","updated_at":"2018-11-04T12:22:10Z","pushed_at":"2018-11-04T21:28:37Z","git_url":"git://github.com/qTox/qTox.git","ssh_url":"[email protected]:qTox/qTox.git","clone_url":"https://github.com/qTox/qTox.git","svn_url":"https://github.com/qTox/qTox","homepage":"https://qtox.github.io/","size":35628,"stargazers_count":2133,"watchers_count":2133,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":566,"mirror_url":null,"archived":false,"open_issues_count":586,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":566,"open_issues":586,"watchers":2133,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/qTox/qTox/pulls/5425"},"html":{"href":"https://github.com/qTox/qTox/pull/5425"},"issue":{"href":"https://api.github.com/repos/qTox/qTox/issues/5425"},"comments":{"href":"https://api.github.com/repos/qTox/qTox/issues/5425/comments"},"review_comments":{"href":"https://api.github.com/repos/qTox/qTox/pulls/5425/comments"},"review_comment":{"href":"https://api.github.com/repos/qTox/qTox/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/qTox/qTox/pulls/5425/commits"},"statuses":{"href":"https://api.github.com/repos/qTox/qTox/statuses/0a1a0f110f8ebfebfd20f5a2052db1f80e4701c5"}},"author_association":"MEMBER"}} | {
"id": 21179164,
"name": "qTox/qTox",
"url": "https://api.github.com/repos/qTox/qTox"
} | {
"id": 6306608,
"login": "Diadlo",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6306608?",
"url": "https://api.github.com/users/Diadlo"
} | {
"id": 9519241,
"login": "qTox",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9519241?",
"url": "https://api.github.com/orgs/qTox"
} | 2018-11-05T07:55:51 | 8533957445 | {"actor":{"display_login":"Diadlo"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/release-engineering/estuary-updater/pulls/comments/208726819","pull_request_review_id":144597756,"id":208726819,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwODcyNjgxOQ==","diff_hunk":"@@ -0,0 +1,78 @@\n+{\n+ \"body\":{\n+ \"headers\":{\n+ \"content-length\": \"864\", \n+ \"expires\": \"0\", \n+ \"old\": \"BUILDING\", \n+ \"JMS_AMQP_MESSAGE_FORMAT\": \"0\", \n+ \"timestamp\": \"0\", \n+ \"JMS_AMQP_NATIVE\": \"false\", \n+ \"destination\": \"/topic/VirtualTopic.eng.brew.build.complete\", \n+ \"priority\": \"4\", \n+ \"subscription\": \"/queue/Consumer.client-datanommer.upshift-prod.VirtualTopic.eng.>\", \n+ \"message-id\": \"ID:messaging.domain.com-41951-1532471159894-4:793878:0:0:1\", \n+ \"version\": \"17.4.0\", \n+ \"attribute\": \"state\", \n+ \"release\": \"8.el8+1325+72a36e76\", \n+ \"new\": \"COMPLETE\", \n+ \"JMS_AMQP_FirstAcquirer\": \"false\", \n+ \"type\": \"BuildStateChange\", \n+ \"name\": \"python-attrs\"\n+ },\n+ \"msg\":{\n+ \"info\": {\n+ \"package_name\": \"python-attrs\", \n+ \"extra\": {\n+ \"source\": {\n+ \"original_url\": \"git://pkgs.domain.com/rpms/python-attrs?#3be3cb33e6432d8392ac3d9e6edffd990f618432\"\n+ }\n+ }, \n+ \"creation_time\": \"2018-08-03 17:49:42.735506\", \n+ \"completion_time\": null, ","path":"tests/messages/koji/build_complete.json","position":31,"original_position":31,"commit_id":"ca0d879d524ba7f2bd854679fb25fb5b34ed712d","original_commit_id":"ca0d879d524ba7f2bd854679fb25fb5b34ed712d","user":{"login":"mprahl","id":11711106,"node_id":"MDQ6VXNlcjExNzExMTA2","avatar_url":"https://avatars3.githubusercontent.com/u/11711106?v=4","gravatar_id":"","url":"https://api.github.com/users/mprahl","html_url":"https://github.com/mprahl","followers_url":"https://api.github.com/users/mprahl/followers","following_url":"https://api.github.com/users/mprahl/following{/other_user}","gists_url":"https://api.github.com/users/mprahl/gists{/gist_id}","starred_url":"https://api.github.com/users/mprahl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mprahl/subscriptions","organizations_url":"https://api.github.com/users/mprahl/orgs","repos_url":"https://api.github.com/users/mprahl/repos","events_url":"https://api.github.com/users/mprahl/events{/privacy}","received_events_url":"https://api.github.com/users/mprahl/received_events","type":"User","site_admin":false},"body":"This is curious... Unfortunately we need this value but it's not set in the message. I filed:\r\nhttps://pagure.io/koji/issue/1033","created_at":"2018-08-08T20:37:02Z","updated_at":"2018-08-08T20:37:02Z","html_url":"https://github.com/release-engineering/estuary-updater/pull/23#discussion_r208726819","pull_request_url":"https://api.github.com/repos/release-engineering/estuary-updater/pulls/23","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/release-engineering/estuary-updater/pulls/comments/208726819"},"html":{"href":"https://github.com/release-engineering/estuary-updater/pull/23#discussion_r208726819"},"pull_request":{"href":"https://api.github.com/repos/release-engineering/estuary-updater/pulls/23"}}},"pull_request":{"url":"https://api.github.com/repos/release-engineering/estuary-updater/pulls/23","id":206466150,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2NDY2MTUw","html_url":"https://github.com/release-engineering/estuary-updater/pull/23","diff_url":"https://github.com/release-engineering/estuary-updater/pull/23.diff","patch_url":"https://github.com/release-engineering/estuary-updater/pull/23.patch","issue_url":"https://api.github.com/repos/release-engineering/estuary-updater/issues/23","number":23,"state":"open","locked":false,"title":"Add Koji handler for build complete and build tag/untag messages","user":{"login":"sarah256","id":29586620,"node_id":"MDQ6VXNlcjI5NTg2NjIw","avatar_url":"https://avatars0.githubusercontent.com/u/29586620?v=4","gravatar_id":"","url":"https://api.github.com/users/sarah256","html_url":"https://github.com/sarah256","followers_url":"https://api.github.com/users/sarah256/followers","following_url":"https://api.github.com/users/sarah256/following{/other_user}","gists_url":"https://api.github.com/users/sarah256/gists{/gist_id}","starred_url":"https://api.github.com/users/sarah256/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sarah256/subscriptions","organizations_url":"https://api.github.com/users/sarah256/orgs","repos_url":"https://api.github.com/users/sarah256/repos","events_url":"https://api.github.com/users/sarah256/events{/privacy}","received_events_url":"https://api.github.com/users/sarah256/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-08-06T17:28:14Z","updated_at":"2018-08-08T20:37:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"532e91cc00bfb98a8525c6d7d649fa564f42369c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/release-engineering/estuary-updater/pulls/23/commits","review_comments_url":"https://api.github.com/repos/release-engineering/estuary-updater/pulls/23/comments","review_comment_url":"https://api.github.com/repos/release-engineering/estuary-updater/pulls/comments{/number}","comments_url":"https://api.github.com/repos/release-engineering/estuary-updater/issues/23/comments","statuses_url":"https://api.github.com/repos/release-engineering/estuary-updater/statuses/ca0d879d524ba7f2bd854679fb25fb5b34ed712d","head":{"label":"sarah256:koji-handler","ref":"koji-handler","sha":"ca0d879d524ba7f2bd854679fb25fb5b34ed712d","user":{"login":"sarah256","id":29586620,"node_id":"MDQ6VXNlcjI5NTg2NjIw","avatar_url":"https://avatars0.githubusercontent.com/u/29586620?v=4","gravatar_id":"","url":"https://api.github.com/users/sarah256","html_url":"https://github.com/sarah256","followers_url":"https://api.github.com/users/sarah256/followers","following_url":"https://api.github.com/users/sarah256/following{/other_user}","gists_url":"https://api.github.com/users/sarah256/gists{/gist_id}","starred_url":"https://api.github.com/users/sarah256/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sarah256/subscriptions","organizations_url":"https://api.github.com/users/sarah256/orgs","repos_url":"https://api.github.com/users/sarah256/repos","events_url":"https://api.github.com/users/sarah256/events{/privacy}","received_events_url":"https://api.github.com/users/sarah256/received_events","type":"User","site_admin":false},"repo":{"id":137234858,"node_id":"MDEwOlJlcG9zaXRvcnkxMzcyMzQ4NTg=","name":"estuary_updater","full_name":"sarah256/estuary_updater","owner":{"login":"sarah256","id":29586620,"node_id":"MDQ6VXNlcjI5NTg2NjIw","avatar_url":"https://avatars0.githubusercontent.com/u/29586620?v=4","gravatar_id":"","url":"https://api.github.com/users/sarah256","html_url":"https://github.com/sarah256","followers_url":"https://api.github.com/users/sarah256/followers","following_url":"https://api.github.com/users/sarah256/following{/other_user}","gists_url":"https://api.github.com/users/sarah256/gists{/gist_id}","starred_url":"https://api.github.com/users/sarah256/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sarah256/subscriptions","organizations_url":"https://api.github.com/users/sarah256/orgs","repos_url":"https://api.github.com/users/sarah256/repos","events_url":"https://api.github.com/users/sarah256/events{/privacy}","received_events_url":"https://api.github.com/users/sarah256/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sarah256/estuary_updater","description":"A micro-service that updates the Neo4j database for Estuary in real-time ","fork":true,"url":"https://api.github.com/repos/sarah256/estuary_updater","forks_url":"https://api.github.com/repos/sarah256/estuary_updater/forks","keys_url":"https://api.github.com/repos/sarah256/estuary_updater/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sarah256/estuary_updater/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sarah256/estuary_updater/teams","hooks_url":"https://api.github.com/repos/sarah256/estuary_updater/hooks","issue_events_url":"https://api.github.com/repos/sarah256/estuary_updater/issues/events{/number}","events_url":"https://api.github.com/repos/sarah256/estuary_updater/events","assignees_url":"https://api.github.com/repos/sarah256/estuary_updater/assignees{/user}","branches_url":"https://api.github.com/repos/sarah256/estuary_updater/branches{/branch}","tags_url":"https://api.github.com/repos/sarah256/estuary_updater/tags","blobs_url":"https://api.github.com/repos/sarah256/estuary_updater/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sarah256/estuary_updater/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sarah256/estuary_updater/git/refs{/sha}","trees_url":"https://api.github.com/repos/sarah256/estuary_updater/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sarah256/estuary_updater/statuses/{sha}","languages_url":"https://api.github.com/repos/sarah256/estuary_updater/languages","stargazers_url":"https://api.github.com/repos/sarah256/estuary_updater/stargazers","contributors_url":"https://api.github.com/repos/sarah256/estuary_updater/contributors","subscribers_url":"https://api.github.com/repos/sarah256/estuary_updater/subscribers","subscription_url":"https://api.github.com/repos/sarah256/estuary_updater/subscription","commits_url":"https://api.github.com/repos/sarah256/estuary_updater/commits{/sha}","git_commits_url":"https://api.github.com/repos/sarah256/estuary_updater/git/commits{/sha}","comments_url":"https://api.github.com/repos/sarah256/estuary_updater/comments{/number}","issue_comment_url":"https://api.github.com/repos/sarah256/estuary_updater/issues/comments{/number}","contents_url":"https://api.github.com/repos/sarah256/estuary_updater/contents/{+path}","compare_url":"https://api.github.com/repos/sarah256/estuary_updater/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sarah256/estuary_updater/merges","archive_url":"https://api.github.com/repos/sarah256/estuary_updater/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sarah256/estuary_updater/downloads","issues_url":"https://api.github.com/repos/sarah256/estuary_updater/issues{/number}","pulls_url":"https://api.github.com/repos/sarah256/estuary_updater/pulls{/number}","milestones_url":"https://api.github.com/repos/sarah256/estuary_updater/milestones{/number}","notifications_url":"https://api.github.com/repos/sarah256/estuary_updater/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sarah256/estuary_updater/labels{/name}","releases_url":"https://api.github.com/repos/sarah256/estuary_updater/releases{/id}","deployments_url":"https://api.github.com/repos/sarah256/estuary_updater/deployments","created_at":"2018-06-13T15:28:31Z","updated_at":"2018-08-06T13:17:40Z","pushed_at":"2018-08-08T14:20:54Z","git_url":"git://github.com/sarah256/estuary_updater.git","ssh_url":"[email protected]:sarah256/estuary_updater.git","clone_url":"https://github.com/sarah256/estuary_updater.git","svn_url":"https://github.com/sarah256/estuary_updater","homepage":"","size":92,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"release-engineering:master","ref":"master","sha":"a073dd374bf3ce2543759b2fd1c4b833607ea025","user":{"login":"release-engineering","id":9591189,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk1OTExODk=","avatar_url":"https://avatars3.githubusercontent.com/u/9591189?v=4","gravatar_id":"","url":"https://api.github.com/users/release-engineering","html_url":"https://github.com/release-engineering","followers_url":"https://api.github.com/users/release-engineering/followers","following_url":"https://api.github.com/users/release-engineering/following{/other_user}","gists_url":"https://api.github.com/users/release-engineering/gists{/gist_id}","starred_url":"https://api.github.com/users/release-engineering/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/release-engineering/subscriptions","organizations_url":"https://api.github.com/users/release-engineering/orgs","repos_url":"https://api.github.com/users/release-engineering/repos","events_url":"https://api.github.com/users/release-engineering/events{/privacy}","received_events_url":"https://api.github.com/users/release-engineering/received_events","type":"Organization","site_admin":false},"repo":{"id":136977808,"node_id":"MDEwOlJlcG9zaXRvcnkxMzY5Nzc4MDg=","name":"estuary-updater","full_name":"release-engineering/estuary-updater","owner":{"login":"release-engineering","id":9591189,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk1OTExODk=","avatar_url":"https://avatars3.githubusercontent.com/u/9591189?v=4","gravatar_id":"","url":"https://api.github.com/users/release-engineering","html_url":"https://github.com/release-engineering","followers_url":"https://api.github.com/users/release-engineering/followers","following_url":"https://api.github.com/users/release-engineering/following{/other_user}","gists_url":"https://api.github.com/users/release-engineering/gists{/gist_id}","starred_url":"https://api.github.com/users/release-engineering/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/release-engineering/subscriptions","organizations_url":"https://api.github.com/users/release-engineering/orgs","repos_url":"https://api.github.com/users/release-engineering/repos","events_url":"https://api.github.com/users/release-engineering/events{/privacy}","received_events_url":"https://api.github.com/users/release-engineering/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/release-engineering/estuary-updater","description":"A micro-service that updates the Neo4j database for Estuary in real-time ","fork":false,"url":"https://api.github.com/repos/release-engineering/estuary-updater","forks_url":"https://api.github.com/repos/release-engineering/estuary-updater/forks","keys_url":"https://api.github.com/repos/release-engineering/estuary-updater/keys{/key_id}","collaborators_url":"https://api.github.com/repos/release-engineering/estuary-updater/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/release-engineering/estuary-updater/teams","hooks_url":"https://api.github.com/repos/release-engineering/estuary-updater/hooks","issue_events_url":"https://api.github.com/repos/release-engineering/estuary-updater/issues/events{/number}","events_url":"https://api.github.com/repos/release-engineering/estuary-updater/events","assignees_url":"https://api.github.com/repos/release-engineering/estuary-updater/assignees{/user}","branches_url":"https://api.github.com/repos/release-engineering/estuary-updater/branches{/branch}","tags_url":"https://api.github.com/repos/release-engineering/estuary-updater/tags","blobs_url":"https://api.github.com/repos/release-engineering/estuary-updater/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/release-engineering/estuary-updater/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/release-engineering/estuary-updater/git/refs{/sha}","trees_url":"https://api.github.com/repos/release-engineering/estuary-updater/git/trees{/sha}","statuses_url":"https://api.github.com/repos/release-engineering/estuary-updater/statuses/{sha}","languages_url":"https://api.github.com/repos/release-engineering/estuary-updater/languages","stargazers_url":"https://api.github.com/repos/release-engineering/estuary-updater/stargazers","contributors_url":"https://api.github.com/repos/release-engineering/estuary-updater/contributors","subscribers_url":"https://api.github.com/repos/release-engineering/estuary-updater/subscribers","subscription_url":"https://api.github.com/repos/release-engineering/estuary-updater/subscription","commits_url":"https://api.github.com/repos/release-engineering/estuary-updater/commits{/sha}","git_commits_url":"https://api.github.com/repos/release-engineering/estuary-updater/git/commits{/sha}","comments_url":"https://api.github.com/repos/release-engineering/estuary-updater/comments{/number}","issue_comment_url":"https://api.github.com/repos/release-engineering/estuary-updater/issues/comments{/number}","contents_url":"https://api.github.com/repos/release-engineering/estuary-updater/contents/{+path}","compare_url":"https://api.github.com/repos/release-engineering/estuary-updater/compare/{base}...{head}","merges_url":"https://api.github.com/repos/release-engineering/estuary-updater/merges","archive_url":"https://api.github.com/repos/release-engineering/estuary-updater/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/release-engineering/estuary-updater/downloads","issues_url":"https://api.github.com/repos/release-engineering/estuary-updater/issues{/number}","pulls_url":"https://api.github.com/repos/release-engineering/estuary-updater/pulls{/number}","milestones_url":"https://api.github.com/repos/release-engineering/estuary-updater/milestones{/number}","notifications_url":"https://api.github.com/repos/release-engineering/estuary-updater/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/release-engineering/estuary-updater/labels{/name}","releases_url":"https://api.github.com/repos/release-engineering/estuary-updater/releases{/id}","deployments_url":"https://api.github.com/repos/release-engineering/estuary-updater/deployments","created_at":"2018-06-11T20:32:41Z","updated_at":"2018-08-08T14:14:46Z","pushed_at":"2018-08-08T15:24:11Z","git_url":"git://github.com/release-engineering/estuary-updater.git","ssh_url":"[email protected]:release-engineering/estuary-updater.git","clone_url":"https://github.com/release-engineering/estuary-updater.git","svn_url":"https://github.com/release-engineering/estuary-updater","homepage":"","size":85,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/release-engineering/estuary-updater/pulls/23"},"html":{"href":"https://github.com/release-engineering/estuary-updater/pull/23"},"issue":{"href":"https://api.github.com/repos/release-engineering/estuary-updater/issues/23"},"comments":{"href":"https://api.github.com/repos/release-engineering/estuary-updater/issues/23/comments"},"review_comments":{"href":"https://api.github.com/repos/release-engineering/estuary-updater/pulls/23/comments"},"review_comment":{"href":"https://api.github.com/repos/release-engineering/estuary-updater/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/release-engineering/estuary-updater/pulls/23/commits"},"statuses":{"href":"https://api.github.com/repos/release-engineering/estuary-updater/statuses/ca0d879d524ba7f2bd854679fb25fb5b34ed712d"}},"author_association":"COLLABORATOR"}} | {
"id": 136977808,
"name": "release-engineering/estuary-updater",
"url": "https://api.github.com/repos/release-engineering/estuary-updater"
} | {
"id": 11711106,
"login": "mprahl",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/11711106?",
"url": "https://api.github.com/users/mprahl"
} | {
"id": 9591189,
"login": "release-engineering",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9591189?",
"url": "https://api.github.com/orgs/release-engineering"
} | 2018-08-08T20:37:02 | 8086370744 | {"actor":{"display_login":"mprahl"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/release-engineering/assayist/pulls/comments/221701210","pull_request_review_id":160414423,"id":221701210,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMTcwMTIxMA==","diff_hunk":"@@ -0,0 +1,135 @@\n+# SPDX-License-Identifier: GPL-3.0+\n+\n+from assayist.processor.base import Analyzer\n+from assayist.processor.logging import log\n+\n+\n+class MainAnalyzer(Analyzer):\n+ \"\"\"\n+ Look at the json brew output and write neomodels for the basic items identified.\n+\n+ * The Component\n+ * The direct SourceLocation\n+ * The Build itself\n+ * Any produced Artifacts (RPMs or otherwise)\n+ * Any RPMs used in the buildroot\n+ * If it's an image build, an RPMs included in the image\n+ \"\"\"\n+\n+ buildroot_to_artifact = {}\n+\n+ def map_buildroot_to_artifact(self, buildroot_id, artifact_id):\n+ \"\"\"Store the mapping in self.buildroot_to_artifact.\"\"\"\n+ if buildroot_id in self.buildroot_to_artifact:\n+ self.buildroot_to_artifact[buildroot_id].append(artifact_id)\n+ else:\n+ self.buildroot_to_artifact[buildroot_id] = [artifact_id]\n+\n+ def read_and_save_buildroots(self):\n+ \"\"\"Save and link the rpms used in the buildroot for each artifact.\"\"\"\n+ buildroots_info = self.read_metadata_file(self.BUILDROOT_FILE)\n+ for buildroot_id in buildroots_info:\n+ log.debug(\"Creating artifacts for buildroot %s\", buildroot_id)\n+ for rpm_info in buildroots_info[buildroot_id]:\n+ rpm = self.get_or_create_rpm_artifact_from_hash(rpm_info)\n+ if buildroot_id in self.buildroot_to_artifact:\n+ for artifact in self.buildroot_to_artifact[buildroot_id]:\n+ artifact.buildroot_artifacts.connect(rpm)\n+\n+ def construct_and_save_component(self, build_type, build_info):\n+ \"\"\"\n+ Read the build info and contruct the Component.\n+\n+ Returns: (Component, canonical_version)\n+\n+ \"\"\"\n+ if build_type == 'build': # rpm build\n+ cnamespace = 'redhat'\n+ cname = build_info['name']\n+ ctype = 'rpm'\n+ cversion = '%s-%s' % (build_info['version'], build_info['release'])\n+ elif build_type == 'maven':\n+ # What we really want is the contents of the \"Maven groupId\" etc fields.\n+ # However they don't seem to be included in the brew response?!\n+ # Instead let's parse it out with what is (as best as I can tell) the algorithm.\n+ cnamespace, cname = build_info['name'].split('-', 1)\n+ cversion = build_info['version'].replace('_', '-')\n+ ctype = 'java'\n+ elif build_type == 'buildContainer':\n+ cnamespace = 'docker-image'\n+ cname = build_info['name']\n+ cversion = '%s-%s' % (build_info['version'], build_info['release'])\n+ ctype = 'image'\n+ else:\n+ return None, None\n+\n+ component = self.get_or_create_component(\n+ canonical_namespace=cnamespace,\n+ canonical_name=cname,\n+ canonical_type=ctype)\n+ return component, cversion\n+\n+ def run(self):\n+ \"\"\"Do the actual processing.\"\"\"\n+ build_info = self.read_metadata_file(self.BUILD_FILE)\n+ task_info = self.read_metadata_file(self.TASK_FILE)\n+\n+ build_type = None\n+ if task_info:\n+ build_type = task_info['method']\n+\n+ # construct the component\n+ component, canonical_version = self.construct_and_save_component(build_type, build_info)\n+\n+ # construct the SourceLocation\n+ source = build_info['source']\n+ sourceLocation = self.get_or_create_source_location(source, canonical_version)\n+ sourceLocation.component.connect(component)\n+\n+ # construct the build object\n+ build = self.get_or_create_build(build_info['id'], build_type)\n+ build.source_location.connect(sourceLocation)\n+\n+ # if it's an rpm build look at the rpm output and create artifacts\n+ if build_type == 'build':\n+ rpms_info = self.read_metadata_file(self.RPM_FILE)\n+ for rpm_info in rpms_info:\n+ buildroot_id = rpm_info['buildroot_id']\n+ rpm = self.get_or_create_rpm_artifact_from_hash(rpm_info)\n+ rpm.build.connect(build)\n+ self.map_buildroot_to_artifact(buildroot_id, rpm)\n+\n+ self.read_and_save_buildroots()\n+ return # finished processing, rpm builds don't have anything else\n+\n+ # else not an rpm build, record the artifacts\n+ archives_info = self.read_metadata_file(self.ARCHIVE_FILE)\n+ images_rpm_info = self.read_metadata_file(self.IMAGE_RPM_FILE)\n+ for archive_info in archives_info:\n+ log.debug(\"Creating build artifact %s\", archive_info['id'])\n+ aid = archive_info['id']\n+ checksum = archive_info['checksum']\n+ filename = archive_info['filename']\n+ buildroot_id = archive_info['buildroot_id']\n+ arch = 'noarch'\n+ if 'extra' in archive_info \\","path":"assayist/processor/main_analyzer.py","position":115,"original_position":115,"commit_id":"0b0a4e7b6ba55d3d7872a235059239d92f5fd21d","original_commit_id":"0b0a4e7b6ba55d3d7872a235059239d92f5fd21d","user":{"login":"mprahl","id":11711106,"node_id":"MDQ6VXNlcjExNzExMTA2","avatar_url":"https://avatars3.githubusercontent.com/u/11711106?v=4","gravatar_id":"","url":"https://api.github.com/users/mprahl","html_url":"https://github.com/mprahl","followers_url":"https://api.github.com/users/mprahl/followers","following_url":"https://api.github.com/users/mprahl/following{/other_user}","gists_url":"https://api.github.com/users/mprahl/gists{/gist_id}","starred_url":"https://api.github.com/users/mprahl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mprahl/subscriptions","organizations_url":"https://api.github.com/users/mprahl/orgs","repos_url":"https://api.github.com/users/mprahl/repos","events_url":"https://api.github.com/users/mprahl/events{/privacy}","received_events_url":"https://api.github.com/users/mprahl/received_events","type":"User","site_admin":false},"body":"@twaugh will this work for historical container images? If not, we'll need to refactor later.","created_at":"2018-10-01T17:58:36Z","updated_at":"2018-10-01T17:58:36Z","html_url":"https://github.com/release-engineering/assayist/pull/9#discussion_r221701210","pull_request_url":"https://api.github.com/repos/release-engineering/assayist/pulls/9","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/release-engineering/assayist/pulls/comments/221701210"},"html":{"href":"https://github.com/release-engineering/assayist/pull/9#discussion_r221701210"},"pull_request":{"href":"https://api.github.com/repos/release-engineering/assayist/pulls/9"}}},"pull_request":{"url":"https://api.github.com/repos/release-engineering/assayist/pulls/9","id":218820142,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE4ODIwMTQy","html_url":"https://github.com/release-engineering/assayist/pull/9","diff_url":"https://github.com/release-engineering/assayist/pull/9.diff","patch_url":"https://github.com/release-engineering/assayist/pull/9.patch","issue_url":"https://api.github.com/repos/release-engineering/assayist/issues/9","number":9,"state":"open","locked":false,"title":"Main analyzer","user":{"login":"sdherr","id":775480,"node_id":"MDQ6VXNlcjc3NTQ4MA==","avatar_url":"https://avatars1.githubusercontent.com/u/775480?v=4","gravatar_id":"","url":"https://api.github.com/users/sdherr","html_url":"https://github.com/sdherr","followers_url":"https://api.github.com/users/sdherr/followers","following_url":"https://api.github.com/users/sdherr/following{/other_user}","gists_url":"https://api.github.com/users/sdherr/gists{/gist_id}","starred_url":"https://api.github.com/users/sdherr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdherr/subscriptions","organizations_url":"https://api.github.com/users/sdherr/orgs","repos_url":"https://api.github.com/users/sdherr/repos","events_url":"https://api.github.com/users/sdherr/events{/privacy}","received_events_url":"https://api.github.com/users/sdherr/received_events","type":"User","site_admin":false},"body":"The first cut at the Main Analyzer should be finished (see FACTORY-3229).\r\n\r\nI still have to make the changes specified in the update schema doc, but that's for another day. Comments welcome.","created_at":"2018-09-28T00:00:06Z","updated_at":"2018-10-01T17:58:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"63dcac5c040a88cb3907828e71c1ebb037496548","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/release-engineering/assayist/pulls/9/commits","review_comments_url":"https://api.github.com/repos/release-engineering/assayist/pulls/9/comments","review_comment_url":"https://api.github.com/repos/release-engineering/assayist/pulls/comments{/number}","comments_url":"https://api.github.com/repos/release-engineering/assayist/issues/9/comments","statuses_url":"https://api.github.com/repos/release-engineering/assayist/statuses/0b0a4e7b6ba55d3d7872a235059239d92f5fd21d","head":{"label":"release-engineering:main-analyzer","ref":"main-analyzer","sha":"0b0a4e7b6ba55d3d7872a235059239d92f5fd21d","user":{"login":"release-engineering","id":9591189,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk1OTExODk=","avatar_url":"https://avatars3.githubusercontent.com/u/9591189?v=4","gravatar_id":"","url":"https://api.github.com/users/release-engineering","html_url":"https://github.com/release-engineering","followers_url":"https://api.github.com/users/release-engineering/followers","following_url":"https://api.github.com/users/release-engineering/following{/other_user}","gists_url":"https://api.github.com/users/release-engineering/gists{/gist_id}","starred_url":"https://api.github.com/users/release-engineering/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/release-engineering/subscriptions","organizations_url":"https://api.github.com/users/release-engineering/orgs","repos_url":"https://api.github.com/users/release-engineering/repos","events_url":"https://api.github.com/users/release-engineering/events{/privacy}","received_events_url":"https://api.github.com/users/release-engineering/received_events","type":"Organization","site_admin":false},"repo":{"id":145765558,"node_id":"MDEwOlJlcG9zaXRvcnkxNDU3NjU1NTg=","name":"assayist","full_name":"release-engineering/assayist","private":false,"owner":{"login":"release-engineering","id":9591189,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk1OTExODk=","avatar_url":"https://avatars3.githubusercontent.com/u/9591189?v=4","gravatar_id":"","url":"https://api.github.com/users/release-engineering","html_url":"https://github.com/release-engineering","followers_url":"https://api.github.com/users/release-engineering/followers","following_url":"https://api.github.com/users/release-engineering/following{/other_user}","gists_url":"https://api.github.com/users/release-engineering/gists{/gist_id}","starred_url":"https://api.github.com/users/release-engineering/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/release-engineering/subscriptions","organizations_url":"https://api.github.com/users/release-engineering/orgs","repos_url":"https://api.github.com/users/release-engineering/repos","events_url":"https://api.github.com/users/release-engineering/events{/privacy}","received_events_url":"https://api.github.com/users/release-engineering/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/release-engineering/assayist","description":"Application to determining composition of build outputs and containers in the product pipeline","fork":false,"url":"https://api.github.com/repos/release-engineering/assayist","forks_url":"https://api.github.com/repos/release-engineering/assayist/forks","keys_url":"https://api.github.com/repos/release-engineering/assayist/keys{/key_id}","collaborators_url":"https://api.github.com/repos/release-engineering/assayist/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/release-engineering/assayist/teams","hooks_url":"https://api.github.com/repos/release-engineering/assayist/hooks","issue_events_url":"https://api.github.com/repos/release-engineering/assayist/issues/events{/number}","events_url":"https://api.github.com/repos/release-engineering/assayist/events","assignees_url":"https://api.github.com/repos/release-engineering/assayist/assignees{/user}","branches_url":"https://api.github.com/repos/release-engineering/assayist/branches{/branch}","tags_url":"https://api.github.com/repos/release-engineering/assayist/tags","blobs_url":"https://api.github.com/repos/release-engineering/assayist/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/release-engineering/assayist/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/release-engineering/assayist/git/refs{/sha}","trees_url":"https://api.github.com/repos/release-engineering/assayist/git/trees{/sha}","statuses_url":"https://api.github.com/repos/release-engineering/assayist/statuses/{sha}","languages_url":"https://api.github.com/repos/release-engineering/assayist/languages","stargazers_url":"https://api.github.com/repos/release-engineering/assayist/stargazers","contributors_url":"https://api.github.com/repos/release-engineering/assayist/contributors","subscribers_url":"https://api.github.com/repos/release-engineering/assayist/subscribers","subscription_url":"https://api.github.com/repos/release-engineering/assayist/subscription","commits_url":"https://api.github.com/repos/release-engineering/assayist/commits{/sha}","git_commits_url":"https://api.github.com/repos/release-engineering/assayist/git/commits{/sha}","comments_url":"https://api.github.com/repos/release-engineering/assayist/comments{/number}","issue_comment_url":"https://api.github.com/repos/release-engineering/assayist/issues/comments{/number}","contents_url":"https://api.github.com/repos/release-engineering/assayist/contents/{+path}","compare_url":"https://api.github.com/repos/release-engineering/assayist/compare/{base}...{head}","merges_url":"https://api.github.com/repos/release-engineering/assayist/merges","archive_url":"https://api.github.com/repos/release-engineering/assayist/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/release-engineering/assayist/downloads","issues_url":"https://api.github.com/repos/release-engineering/assayist/issues{/number}","pulls_url":"https://api.github.com/repos/release-engineering/assayist/pulls{/number}","milestones_url":"https://api.github.com/repos/release-engineering/assayist/milestones{/number}","notifications_url":"https://api.github.com/repos/release-engineering/assayist/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/release-engineering/assayist/labels{/name}","releases_url":"https://api.github.com/repos/release-engineering/assayist/releases{/id}","deployments_url":"https://api.github.com/repos/release-engineering/assayist/deployments","created_at":"2018-08-22T21:37:18Z","updated_at":"2018-10-01T13:11:22Z","pushed_at":"2018-10-01T16:12:10Z","git_url":"git://github.com/release-engineering/assayist.git","ssh_url":"[email protected]:release-engineering/assayist.git","clone_url":"https://github.com/release-engineering/assayist.git","svn_url":"https://github.com/release-engineering/assayist","homepage":null,"size":58,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"release-engineering:master","ref":"master","sha":"bab12b0513a638265e7443e01db0f1277e9f59ed","user":{"login":"release-engineering","id":9591189,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk1OTExODk=","avatar_url":"https://avatars3.githubusercontent.com/u/9591189?v=4","gravatar_id":"","url":"https://api.github.com/users/release-engineering","html_url":"https://github.com/release-engineering","followers_url":"https://api.github.com/users/release-engineering/followers","following_url":"https://api.github.com/users/release-engineering/following{/other_user}","gists_url":"https://api.github.com/users/release-engineering/gists{/gist_id}","starred_url":"https://api.github.com/users/release-engineering/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/release-engineering/subscriptions","organizations_url":"https://api.github.com/users/release-engineering/orgs","repos_url":"https://api.github.com/users/release-engineering/repos","events_url":"https://api.github.com/users/release-engineering/events{/privacy}","received_events_url":"https://api.github.com/users/release-engineering/received_events","type":"Organization","site_admin":false},"repo":{"id":145765558,"node_id":"MDEwOlJlcG9zaXRvcnkxNDU3NjU1NTg=","name":"assayist","full_name":"release-engineering/assayist","private":false,"owner":{"login":"release-engineering","id":9591189,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk1OTExODk=","avatar_url":"https://avatars3.githubusercontent.com/u/9591189?v=4","gravatar_id":"","url":"https://api.github.com/users/release-engineering","html_url":"https://github.com/release-engineering","followers_url":"https://api.github.com/users/release-engineering/followers","following_url":"https://api.github.com/users/release-engineering/following{/other_user}","gists_url":"https://api.github.com/users/release-engineering/gists{/gist_id}","starred_url":"https://api.github.com/users/release-engineering/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/release-engineering/subscriptions","organizations_url":"https://api.github.com/users/release-engineering/orgs","repos_url":"https://api.github.com/users/release-engineering/repos","events_url":"https://api.github.com/users/release-engineering/events{/privacy}","received_events_url":"https://api.github.com/users/release-engineering/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/release-engineering/assayist","description":"Application to determining composition of build outputs and containers in the product pipeline","fork":false,"url":"https://api.github.com/repos/release-engineering/assayist","forks_url":"https://api.github.com/repos/release-engineering/assayist/forks","keys_url":"https://api.github.com/repos/release-engineering/assayist/keys{/key_id}","collaborators_url":"https://api.github.com/repos/release-engineering/assayist/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/release-engineering/assayist/teams","hooks_url":"https://api.github.com/repos/release-engineering/assayist/hooks","issue_events_url":"https://api.github.com/repos/release-engineering/assayist/issues/events{/number}","events_url":"https://api.github.com/repos/release-engineering/assayist/events","assignees_url":"https://api.github.com/repos/release-engineering/assayist/assignees{/user}","branches_url":"https://api.github.com/repos/release-engineering/assayist/branches{/branch}","tags_url":"https://api.github.com/repos/release-engineering/assayist/tags","blobs_url":"https://api.github.com/repos/release-engineering/assayist/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/release-engineering/assayist/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/release-engineering/assayist/git/refs{/sha}","trees_url":"https://api.github.com/repos/release-engineering/assayist/git/trees{/sha}","statuses_url":"https://api.github.com/repos/release-engineering/assayist/statuses/{sha}","languages_url":"https://api.github.com/repos/release-engineering/assayist/languages","stargazers_url":"https://api.github.com/repos/release-engineering/assayist/stargazers","contributors_url":"https://api.github.com/repos/release-engineering/assayist/contributors","subscribers_url":"https://api.github.com/repos/release-engineering/assayist/subscribers","subscription_url":"https://api.github.com/repos/release-engineering/assayist/subscription","commits_url":"https://api.github.com/repos/release-engineering/assayist/commits{/sha}","git_commits_url":"https://api.github.com/repos/release-engineering/assayist/git/commits{/sha}","comments_url":"https://api.github.com/repos/release-engineering/assayist/comments{/number}","issue_comment_url":"https://api.github.com/repos/release-engineering/assayist/issues/comments{/number}","contents_url":"https://api.github.com/repos/release-engineering/assayist/contents/{+path}","compare_url":"https://api.github.com/repos/release-engineering/assayist/compare/{base}...{head}","merges_url":"https://api.github.com/repos/release-engineering/assayist/merges","archive_url":"https://api.github.com/repos/release-engineering/assayist/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/release-engineering/assayist/downloads","issues_url":"https://api.github.com/repos/release-engineering/assayist/issues{/number}","pulls_url":"https://api.github.com/repos/release-engineering/assayist/pulls{/number}","milestones_url":"https://api.github.com/repos/release-engineering/assayist/milestones{/number}","notifications_url":"https://api.github.com/repos/release-engineering/assayist/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/release-engineering/assayist/labels{/name}","releases_url":"https://api.github.com/repos/release-engineering/assayist/releases{/id}","deployments_url":"https://api.github.com/repos/release-engineering/assayist/deployments","created_at":"2018-08-22T21:37:18Z","updated_at":"2018-10-01T13:11:22Z","pushed_at":"2018-10-01T16:12:10Z","git_url":"git://github.com/release-engineering/assayist.git","ssh_url":"[email protected]:release-engineering/assayist.git","clone_url":"https://github.com/release-engineering/assayist.git","svn_url":"https://github.com/release-engineering/assayist","homepage":null,"size":58,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/release-engineering/assayist/pulls/9"},"html":{"href":"https://github.com/release-engineering/assayist/pull/9"},"issue":{"href":"https://api.github.com/repos/release-engineering/assayist/issues/9"},"comments":{"href":"https://api.github.com/repos/release-engineering/assayist/issues/9/comments"},"review_comments":{"href":"https://api.github.com/repos/release-engineering/assayist/pulls/9/comments"},"review_comment":{"href":"https://api.github.com/repos/release-engineering/assayist/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/release-engineering/assayist/pulls/9/commits"},"statuses":{"href":"https://api.github.com/repos/release-engineering/assayist/statuses/0b0a4e7b6ba55d3d7872a235059239d92f5fd21d"}},"author_association":"NONE"}} | {
"id": 145765558,
"name": "release-engineering/assayist",
"url": "https://api.github.com/repos/release-engineering/assayist"
} | {
"id": 11711106,
"login": "mprahl",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/11711106?",
"url": "https://api.github.com/users/mprahl"
} | {
"id": 9591189,
"login": "release-engineering",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9591189?",
"url": "https://api.github.com/orgs/release-engineering"
} | 2018-10-01T17:58:36 | 8349677256 | {"actor":{"display_login":"mprahl"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/mattermost/docs/pulls/comments/176949160","pull_request_review_id":106738797,"id":176949160,"diff_hunk":"@@ -92,47 +90,28 @@ The various community channels are outlined below, along with the responsibiliti\n \n - Updates `Spreadsheet <https://docs.google.com/spreadsheets/d/1nljd4cFh-9MXF4DxlUnC8b6bdqijkvi8KHquOmK8M6E/edit#gid=0>`_ to track UserVoice issues to be announced in upcoming releases.\n \n-3. `Peer-to-peer Help Channel <https://pre-release.mattermost.com/core/channels/peer-to-peer-help>`_: GitHub Issues with Activity Older than 7 days that have not been created by Mattermost staff\n+3. Weekly, usually Wednesdays, `Peer-to-peer Help Channel <https://pre-release.mattermost.com/core/channels/peer-to-peer-help>`_: GitHub , GitLab and StackOverflow issues with Activity Older than 7 days (that have not been created by Mattermost staff)\n \n - Description:\n \n- - Ops Team @mentions the Community PM and posts a list of “GitHub issues with activity older than 7 days” from the following repos:\n+ - The Community Manager reviews “GitHub, GitLab and StackOverflow issues with activity older than 7 days” from the following repos and adds a list of issues to the daily Peer-to-peer Help channel post:\n \n - https://github.com/mattermost/mattermost-server/issues\n - https://github.com/mattermost/docs/issues\n- - https://github.com/mattermost/ios/issues\n- - https://github.com/mattermost/push-proxy/pulls\n- - https://github.com/mattermost/mattermost-docker-preview/issues\n- - https://github.com/mattermost/mattermost-bot-sample-golang/issues\n- - https://github.com/mattermost/mattermost-load-test/issues\n - https://github.com/mattermost/mattermost-api-reference/issues\n+ - https://github.com/mattermost/mattermost-bot-sample-golang/issues \n+ - https://github.com/mattermost/mattermost-load-test/issues\n+ - https://github.com/mattermost/mattermost-push-proxy\n - [a month or older - reviews are monthly] https://github.com/mattermost/android/pulls\n - [a month or older - reviews are monthly] https://github.com/mattermost/ios/pulls\n-\n- - Community PM Responsibility:\n-\n- - Review the list and either reply (with help from dev if needed) or route to the appropriate person, following up to make sure a response is posted\n+ - http://stackoverflow.com/questions/tagged/mattermost?sort=newest&pageSize=15 \n+ - https://gitlab.com/search?utf8=%E2%9C%93&search=mattermost&group_id=&project_id=20699&scope=issues&repository_ref= \n+ - https://gitlab.com/gitlab-org/gitlab-mattermost/issues \n+ - https://gitlab.com/gitlab-org/omnibus-gitlab/issues?label_name=Mattermost\n+ - https://gitlab.com/gitlab-org/gitlab-ce/issues?label_name=mattermost\n \n 4. Help Wanted GitHub Issues:\n \n - Description:\n \n- - New GitHub Help Wanted issues are automatically created from JIRA tickets and are open for community contributions\n-\n- - Community PM Responsibility:\n-\n- - Review newly created Help Wanted issues for formatting and apply difficulty and language labels defined in the issue description by the triage team\n- - Respond to questions from community members, which get automatically posted in the `Community Heartbeat channel <https://pre-release.mattermost.com/core/channels/community-heartbeat>`_\n- - Follow up with a community member if there hasn't been a response for more than two weeks\n-\n-5. Customer Zendesk Issues:\n-\n- - Description:\n-\n- - Sales team will @mention the community PM in Mattermost with the Zendesk ticket that needs a response\n-\n- - Community PM Responsibility:\n-\n- - Click the Zendesk hashtag to review previous ticket conversation (or view directly in Zendesk)\n- - In the Mattermost thread: Answer the question (with dev help if necessary), or draft a response asking follow up questions\n- - @mention Hanna, and she will reply to the customer in Zendesk\n+ - New GitHub Help Wanted issues are automatically created from JIRA tickets and are open for community contributions. The Community Manager can disregard these issues as they do not need to be posted to the Peer-to-peer Help channel.","path":"source/process/community-process.rst","position":112,"original_position":112,"commit_id":"5a5e2344028f8e9a1c61b51514a73eb56c6f3887","original_commit_id":"5a5e2344028f8e9a1c61b51514a73eb56c6f3887","user":{"login":"lindy65","id":13020833,"avatar_url":"https://avatars1.githubusercontent.com/u/13020833?v=4","gravatar_id":"","url":"https://api.github.com/users/lindy65","html_url":"https://github.com/lindy65","followers_url":"https://api.github.com/users/lindy65/followers","following_url":"https://api.github.com/users/lindy65/following{/other_user}","gists_url":"https://api.github.com/users/lindy65/gists{/gist_id}","starred_url":"https://api.github.com/users/lindy65/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lindy65/subscriptions","organizations_url":"https://api.github.com/users/lindy65/orgs","repos_url":"https://api.github.com/users/lindy65/repos","events_url":"https://api.github.com/users/lindy65/events{/privacy}","received_events_url":"https://api.github.com/users/lindy65/received_events","type":"User","site_admin":false},"body":"Thanks @amyblais :)\r\n\r\nLet me know what you decide @lfbrock and I'll update the PR if you'd prefer community manager to check 'help wanted' issues...","created_at":"2018-03-25T18:28:18Z","updated_at":"2018-03-25T18:28:19Z","html_url":"https://github.com/mattermost/docs/pull/1882#discussion_r176949160","pull_request_url":"https://api.github.com/repos/mattermost/docs/pulls/1882","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/mattermost/docs/pulls/comments/176949160"},"html":{"href":"https://github.com/mattermost/docs/pull/1882#discussion_r176949160"},"pull_request":{"href":"https://api.github.com/repos/mattermost/docs/pulls/1882"}},"in_reply_to_id":176527838},"pull_request":{"url":"https://api.github.com/repos/mattermost/docs/pulls/1882","id":176289485,"html_url":"https://github.com/mattermost/docs/pull/1882","diff_url":"https://github.com/mattermost/docs/pull/1882.diff","patch_url":"https://github.com/mattermost/docs/pull/1882.patch","issue_url":"https://api.github.com/repos/mattermost/docs/issues/1882","number":1882,"state":"open","locked":false,"title":"Update community-process.rst","user":{"login":"lindy65","id":13020833,"avatar_url":"https://avatars1.githubusercontent.com/u/13020833?v=4","gravatar_id":"","url":"https://api.github.com/users/lindy65","html_url":"https://github.com/lindy65","followers_url":"https://api.github.com/users/lindy65/followers","following_url":"https://api.github.com/users/lindy65/following{/other_user}","gists_url":"https://api.github.com/users/lindy65/gists{/gist_id}","starred_url":"https://api.github.com/users/lindy65/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lindy65/subscriptions","organizations_url":"https://api.github.com/users/lindy65/orgs","repos_url":"https://api.github.com/users/lindy65/repos","events_url":"https://api.github.com/users/lindy65/events{/privacy}","received_events_url":"https://api.github.com/users/lindy65/received_events","type":"User","site_admin":false},"body":"General update from Ops to Community Manager, updated repos, etc.","created_at":"2018-03-20T18:53:23Z","updated_at":"2018-03-25T18:28:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f50b087f24434a14cc63418a872a46a11dce322b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":331050524,"url":"https://api.github.com/repos/mattermost/docs/labels/Needs%20PM%20Review","name":"Needs PM Review","color":"006b75","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/mattermost/docs/pulls/1882/commits","review_comments_url":"https://api.github.com/repos/mattermost/docs/pulls/1882/comments","review_comment_url":"https://api.github.com/repos/mattermost/docs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mattermost/docs/issues/1882/comments","statuses_url":"https://api.github.com/repos/mattermost/docs/statuses/5a5e2344028f8e9a1c61b51514a73eb56c6f3887","head":{"label":"mattermost:lindy65-patch-6","ref":"lindy65-patch-6","sha":"5a5e2344028f8e9a1c61b51514a73eb56c6f3887","user":{"login":"mattermost","id":9828093,"avatar_url":"https://avatars1.githubusercontent.com/u/9828093?v=4","gravatar_id":"","url":"https://api.github.com/users/mattermost","html_url":"https://github.com/mattermost","followers_url":"https://api.github.com/users/mattermost/followers","following_url":"https://api.github.com/users/mattermost/following{/other_user}","gists_url":"https://api.github.com/users/mattermost/gists{/gist_id}","starred_url":"https://api.github.com/users/mattermost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattermost/subscriptions","organizations_url":"https://api.github.com/users/mattermost/orgs","repos_url":"https://api.github.com/users/mattermost/repos","events_url":"https://api.github.com/users/mattermost/events{/privacy}","received_events_url":"https://api.github.com/users/mattermost/received_events","type":"Organization","site_admin":false},"repo":{"id":46522468,"name":"docs","full_name":"mattermost/docs","owner":{"login":"mattermost","id":9828093,"avatar_url":"https://avatars1.githubusercontent.com/u/9828093?v=4","gravatar_id":"","url":"https://api.github.com/users/mattermost","html_url":"https://github.com/mattermost","followers_url":"https://api.github.com/users/mattermost/followers","following_url":"https://api.github.com/users/mattermost/following{/other_user}","gists_url":"https://api.github.com/users/mattermost/gists{/gist_id}","starred_url":"https://api.github.com/users/mattermost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattermost/subscriptions","organizations_url":"https://api.github.com/users/mattermost/orgs","repos_url":"https://api.github.com/users/mattermost/repos","events_url":"https://api.github.com/users/mattermost/events{/privacy}","received_events_url":"https://api.github.com/users/mattermost/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mattermost/docs","description":"Mattermost documentation ","fork":false,"url":"https://api.github.com/repos/mattermost/docs","forks_url":"https://api.github.com/repos/mattermost/docs/forks","keys_url":"https://api.github.com/repos/mattermost/docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mattermost/docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mattermost/docs/teams","hooks_url":"https://api.github.com/repos/mattermost/docs/hooks","issue_events_url":"https://api.github.com/repos/mattermost/docs/issues/events{/number}","events_url":"https://api.github.com/repos/mattermost/docs/events","assignees_url":"https://api.github.com/repos/mattermost/docs/assignees{/user}","branches_url":"https://api.github.com/repos/mattermost/docs/branches{/branch}","tags_url":"https://api.github.com/repos/mattermost/docs/tags","blobs_url":"https://api.github.com/repos/mattermost/docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mattermost/docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mattermost/docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/mattermost/docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mattermost/docs/statuses/{sha}","languages_url":"https://api.github.com/repos/mattermost/docs/languages","stargazers_url":"https://api.github.com/repos/mattermost/docs/stargazers","contributors_url":"https://api.github.com/repos/mattermost/docs/contributors","subscribers_url":"https://api.github.com/repos/mattermost/docs/subscribers","subscription_url":"https://api.github.com/repos/mattermost/docs/subscription","commits_url":"https://api.github.com/repos/mattermost/docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/mattermost/docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/mattermost/docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/mattermost/docs/issues/comments{/number}","contents_url":"https://api.github.com/repos/mattermost/docs/contents/{+path}","compare_url":"https://api.github.com/repos/mattermost/docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mattermost/docs/merges","archive_url":"https://api.github.com/repos/mattermost/docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mattermost/docs/downloads","issues_url":"https://api.github.com/repos/mattermost/docs/issues{/number}","pulls_url":"https://api.github.com/repos/mattermost/docs/pulls{/number}","milestones_url":"https://api.github.com/repos/mattermost/docs/milestones{/number}","notifications_url":"https://api.github.com/repos/mattermost/docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mattermost/docs/labels{/name}","releases_url":"https://api.github.com/repos/mattermost/docs/releases{/id}","deployments_url":"https://api.github.com/repos/mattermost/docs/deployments","created_at":"2015-11-19T21:48:32Z","updated_at":"2018-03-23T17:02:32Z","pushed_at":"2018-03-24T13:55:08Z","git_url":"git://github.com/mattermost/docs.git","ssh_url":"[email protected]:mattermost/docs.git","clone_url":"https://github.com/mattermost/docs.git","svn_url":"https://github.com/mattermost/docs","homepage":"https://docs.mattermost.com","size":62426,"stargazers_count":56,"watchers_count":56,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":214,"mirror_url":null,"archived":false,"open_issues_count":120,"license":null,"forks":214,"open_issues":120,"watchers":56,"default_branch":"master"}},"base":{"label":"mattermost:master","ref":"master","sha":"050672ab1de6f7521e31ac42c487ba58400f7626","user":{"login":"mattermost","id":9828093,"avatar_url":"https://avatars1.githubusercontent.com/u/9828093?v=4","gravatar_id":"","url":"https://api.github.com/users/mattermost","html_url":"https://github.com/mattermost","followers_url":"https://api.github.com/users/mattermost/followers","following_url":"https://api.github.com/users/mattermost/following{/other_user}","gists_url":"https://api.github.com/users/mattermost/gists{/gist_id}","starred_url":"https://api.github.com/users/mattermost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattermost/subscriptions","organizations_url":"https://api.github.com/users/mattermost/orgs","repos_url":"https://api.github.com/users/mattermost/repos","events_url":"https://api.github.com/users/mattermost/events{/privacy}","received_events_url":"https://api.github.com/users/mattermost/received_events","type":"Organization","site_admin":false},"repo":{"id":46522468,"name":"docs","full_name":"mattermost/docs","owner":{"login":"mattermost","id":9828093,"avatar_url":"https://avatars1.githubusercontent.com/u/9828093?v=4","gravatar_id":"","url":"https://api.github.com/users/mattermost","html_url":"https://github.com/mattermost","followers_url":"https://api.github.com/users/mattermost/followers","following_url":"https://api.github.com/users/mattermost/following{/other_user}","gists_url":"https://api.github.com/users/mattermost/gists{/gist_id}","starred_url":"https://api.github.com/users/mattermost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattermost/subscriptions","organizations_url":"https://api.github.com/users/mattermost/orgs","repos_url":"https://api.github.com/users/mattermost/repos","events_url":"https://api.github.com/users/mattermost/events{/privacy}","received_events_url":"https://api.github.com/users/mattermost/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mattermost/docs","description":"Mattermost documentation ","fork":false,"url":"https://api.github.com/repos/mattermost/docs","forks_url":"https://api.github.com/repos/mattermost/docs/forks","keys_url":"https://api.github.com/repos/mattermost/docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mattermost/docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mattermost/docs/teams","hooks_url":"https://api.github.com/repos/mattermost/docs/hooks","issue_events_url":"https://api.github.com/repos/mattermost/docs/issues/events{/number}","events_url":"https://api.github.com/repos/mattermost/docs/events","assignees_url":"https://api.github.com/repos/mattermost/docs/assignees{/user}","branches_url":"https://api.github.com/repos/mattermost/docs/branches{/branch}","tags_url":"https://api.github.com/repos/mattermost/docs/tags","blobs_url":"https://api.github.com/repos/mattermost/docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mattermost/docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mattermost/docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/mattermost/docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mattermost/docs/statuses/{sha}","languages_url":"https://api.github.com/repos/mattermost/docs/languages","stargazers_url":"https://api.github.com/repos/mattermost/docs/stargazers","contributors_url":"https://api.github.com/repos/mattermost/docs/contributors","subscribers_url":"https://api.github.com/repos/mattermost/docs/subscribers","subscription_url":"https://api.github.com/repos/mattermost/docs/subscription","commits_url":"https://api.github.com/repos/mattermost/docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/mattermost/docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/mattermost/docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/mattermost/docs/issues/comments{/number}","contents_url":"https://api.github.com/repos/mattermost/docs/contents/{+path}","compare_url":"https://api.github.com/repos/mattermost/docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mattermost/docs/merges","archive_url":"https://api.github.com/repos/mattermost/docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mattermost/docs/downloads","issues_url":"https://api.github.com/repos/mattermost/docs/issues{/number}","pulls_url":"https://api.github.com/repos/mattermost/docs/pulls{/number}","milestones_url":"https://api.github.com/repos/mattermost/docs/milestones{/number}","notifications_url":"https://api.github.com/repos/mattermost/docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mattermost/docs/labels{/name}","releases_url":"https://api.github.com/repos/mattermost/docs/releases{/id}","deployments_url":"https://api.github.com/repos/mattermost/docs/deployments","created_at":"2015-11-19T21:48:32Z","updated_at":"2018-03-23T17:02:32Z","pushed_at":"2018-03-24T13:55:08Z","git_url":"git://github.com/mattermost/docs.git","ssh_url":"[email protected]:mattermost/docs.git","clone_url":"https://github.com/mattermost/docs.git","svn_url":"https://github.com/mattermost/docs","homepage":"https://docs.mattermost.com","size":62426,"stargazers_count":56,"watchers_count":56,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":214,"mirror_url":null,"archived":false,"open_issues_count":120,"license":null,"forks":214,"open_issues":120,"watchers":56,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mattermost/docs/pulls/1882"},"html":{"href":"https://github.com/mattermost/docs/pull/1882"},"issue":{"href":"https://api.github.com/repos/mattermost/docs/issues/1882"},"comments":{"href":"https://api.github.com/repos/mattermost/docs/issues/1882/comments"},"review_comments":{"href":"https://api.github.com/repos/mattermost/docs/pulls/1882/comments"},"review_comment":{"href":"https://api.github.com/repos/mattermost/docs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mattermost/docs/pulls/1882/commits"},"statuses":{"href":"https://api.github.com/repos/mattermost/docs/statuses/5a5e2344028f8e9a1c61b51514a73eb56c6f3887"}},"author_association":"CONTRIBUTOR"}} | {
"id": 46522468,
"name": "mattermost/docs",
"url": "https://api.github.com/repos/mattermost/docs"
} | {
"id": 13020833,
"login": "lindy65",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/13020833?",
"url": "https://api.github.com/users/lindy65"
} | {
"id": 9828093,
"login": "mattermost",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9828093?",
"url": "https://api.github.com/orgs/mattermost"
} | 2018-03-25T18:28:18 | 7431824975 | {"actor":{"display_login":"lindy65"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/mattermost/mattermost-load-test/pulls/comments/200761458","pull_request_review_id":135146401,"id":200761458,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMDc2MTQ1OA==","diff_hunk":"@@ -59,6 +60,7 @@\n \"ChannelLinkChance\": 0.02,\n \"UploadImageChance\": 0.01,\n \"LinkPreviewChance\": 0.2,\n+ \"CustomEmojiChance\": 0.2,","path":"loadtestconfig.default.json","position":12,"original_position":12,"commit_id":"916c221946441506684f3e4f4ddf12df184a708f","original_commit_id":"916c221946441506684f3e4f4ddf12df184a708f","user":{"login":"crspeller","id":3191642,"node_id":"MDQ6VXNlcjMxOTE2NDI=","avatar_url":"https://avatars1.githubusercontent.com/u/3191642?v=4","gravatar_id":"","url":"https://api.github.com/users/crspeller","html_url":"https://github.com/crspeller","followers_url":"https://api.github.com/users/crspeller/followers","following_url":"https://api.github.com/users/crspeller/following{/other_user}","gists_url":"https://api.github.com/users/crspeller/gists{/gist_id}","starred_url":"https://api.github.com/users/crspeller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crspeller/subscriptions","organizations_url":"https://api.github.com/users/crspeller/orgs","repos_url":"https://api.github.com/users/crspeller/repos","events_url":"https://api.github.com/users/crspeller/events{/privacy}","received_events_url":"https://api.github.com/users/crspeller/received_events","type":"User","site_admin":false},"body":"That's a lot of emoji. does that number make sense? What about modeling posts with multiple emoji?","created_at":"2018-07-06T20:32:13Z","updated_at":"2018-07-06T20:32:39Z","html_url":"https://github.com/mattermost/mattermost-load-test/pull/105#discussion_r200761458","pull_request_url":"https://api.github.com/repos/mattermost/mattermost-load-test/pulls/105","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/mattermost/mattermost-load-test/pulls/comments/200761458"},"html":{"href":"https://github.com/mattermost/mattermost-load-test/pull/105#discussion_r200761458"},"pull_request":{"href":"https://api.github.com/repos/mattermost/mattermost-load-test/pulls/105"}}},"pull_request":{"url":"https://api.github.com/repos/mattermost/mattermost-load-test/pulls/105","id":199543102,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5NTQzMTAy","html_url":"https://github.com/mattermost/mattermost-load-test/pull/105","diff_url":"https://github.com/mattermost/mattermost-load-test/pull/105.diff","patch_url":"https://github.com/mattermost/mattermost-load-test/pull/105.patch","issue_url":"https://api.github.com/repos/mattermost/mattermost-load-test/issues/105","number":105,"state":"open","locked":false,"title":"MM-10487 Add bulk load of emojis and test GET /api/v4/emoji/NAME","user":{"login":"jwilander","id":2672098,"node_id":"MDQ6VXNlcjI2NzIwOTg=","avatar_url":"https://avatars0.githubusercontent.com/u/2672098?v=4","gravatar_id":"","url":"https://api.github.com/users/jwilander","html_url":"https://github.com/jwilander","followers_url":"https://api.github.com/users/jwilander/followers","following_url":"https://api.github.com/users/jwilander/following{/other_user}","gists_url":"https://api.github.com/users/jwilander/gists{/gist_id}","starred_url":"https://api.github.com/users/jwilander/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwilander/subscriptions","organizations_url":"https://api.github.com/users/jwilander/orgs","repos_url":"https://api.github.com/users/jwilander/repos","events_url":"https://api.github.com/users/jwilander/events{/privacy}","received_events_url":"https://api.github.com/users/jwilander/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-07-05T17:48:55Z","updated_at":"2018-07-06T20:32:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"125125ae0cc30bf7c8c138a9c9392d82df960a08","assignee":null,"assignees":[],"requested_reviewers":[{"login":"hmhealey","id":3277310,"node_id":"MDQ6VXNlcjMyNzczMTA=","avatar_url":"https://avatars3.githubusercontent.com/u/3277310?v=4","gravatar_id":"","url":"https://api.github.com/users/hmhealey","html_url":"https://github.com/hmhealey","followers_url":"https://api.github.com/users/hmhealey/followers","following_url":"https://api.github.com/users/hmhealey/following{/other_user}","gists_url":"https://api.github.com/users/hmhealey/gists{/gist_id}","starred_url":"https://api.github.com/users/hmhealey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmhealey/subscriptions","organizations_url":"https://api.github.com/users/hmhealey/orgs","repos_url":"https://api.github.com/users/hmhealey/repos","events_url":"https://api.github.com/users/hmhealey/events{/privacy}","received_events_url":"https://api.github.com/users/hmhealey/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":459635129,"node_id":"MDU6TGFiZWw0NTk2MzUxMjk=","url":"https://api.github.com/repos/mattermost/mattermost-load-test/labels/1:%20Dev%20Review","name":"1: Dev Review","color":"eb6420","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/mattermost/mattermost-load-test/pulls/105/commits","review_comments_url":"https://api.github.com/repos/mattermost/mattermost-load-test/pulls/105/comments","review_comment_url":"https://api.github.com/repos/mattermost/mattermost-load-test/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mattermost/mattermost-load-test/issues/105/comments","statuses_url":"https://api.github.com/repos/mattermost/mattermost-load-test/statuses/916c221946441506684f3e4f4ddf12df184a708f","head":{"label":"mattermost:mm-10487","ref":"mm-10487","sha":"916c221946441506684f3e4f4ddf12df184a708f","user":{"login":"mattermost","id":9828093,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk4MjgwOTM=","avatar_url":"https://avatars1.githubusercontent.com/u/9828093?v=4","gravatar_id":"","url":"https://api.github.com/users/mattermost","html_url":"https://github.com/mattermost","followers_url":"https://api.github.com/users/mattermost/followers","following_url":"https://api.github.com/users/mattermost/following{/other_user}","gists_url":"https://api.github.com/users/mattermost/gists{/gist_id}","starred_url":"https://api.github.com/users/mattermost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattermost/subscriptions","organizations_url":"https://api.github.com/users/mattermost/orgs","repos_url":"https://api.github.com/users/mattermost/repos","events_url":"https://api.github.com/users/mattermost/events{/privacy}","received_events_url":"https://api.github.com/users/mattermost/received_events","type":"Organization","site_admin":false},"repo":{"id":69501671,"node_id":"MDEwOlJlcG9zaXRvcnk2OTUwMTY3MQ==","name":"mattermost-load-test","full_name":"mattermost/mattermost-load-test","owner":{"login":"mattermost","id":9828093,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk4MjgwOTM=","avatar_url":"https://avatars1.githubusercontent.com/u/9828093?v=4","gravatar_id":"","url":"https://api.github.com/users/mattermost","html_url":"https://github.com/mattermost","followers_url":"https://api.github.com/users/mattermost/followers","following_url":"https://api.github.com/users/mattermost/following{/other_user}","gists_url":"https://api.github.com/users/mattermost/gists{/gist_id}","starred_url":"https://api.github.com/users/mattermost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattermost/subscriptions","organizations_url":"https://api.github.com/users/mattermost/orgs","repos_url":"https://api.github.com/users/mattermost/repos","events_url":"https://api.github.com/users/mattermost/events{/privacy}","received_events_url":"https://api.github.com/users/mattermost/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mattermost/mattermost-load-test","description":"Tools for profiling Mattermost under heavy load","fork":false,"url":"https://api.github.com/repos/mattermost/mattermost-load-test","forks_url":"https://api.github.com/repos/mattermost/mattermost-load-test/forks","keys_url":"https://api.github.com/repos/mattermost/mattermost-load-test/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mattermost/mattermost-load-test/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mattermost/mattermost-load-test/teams","hooks_url":"https://api.github.com/repos/mattermost/mattermost-load-test/hooks","issue_events_url":"https://api.github.com/repos/mattermost/mattermost-load-test/issues/events{/number}","events_url":"https://api.github.com/repos/mattermost/mattermost-load-test/events","assignees_url":"https://api.github.com/repos/mattermost/mattermost-load-test/assignees{/user}","branches_url":"https://api.github.com/repos/mattermost/mattermost-load-test/branches{/branch}","tags_url":"https://api.github.com/repos/mattermost/mattermost-load-test/tags","blobs_url":"https://api.github.com/repos/mattermost/mattermost-load-test/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mattermost/mattermost-load-test/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mattermost/mattermost-load-test/git/refs{/sha}","trees_url":"https://api.github.com/repos/mattermost/mattermost-load-test/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mattermost/mattermost-load-test/statuses/{sha}","languages_url":"https://api.github.com/repos/mattermost/mattermost-load-test/languages","stargazers_url":"https://api.github.com/repos/mattermost/mattermost-load-test/stargazers","contributors_url":"https://api.github.com/repos/mattermost/mattermost-load-test/contributors","subscribers_url":"https://api.github.com/repos/mattermost/mattermost-load-test/subscribers","subscription_url":"https://api.github.com/repos/mattermost/mattermost-load-test/subscription","commits_url":"https://api.github.com/repos/mattermost/mattermost-load-test/commits{/sha}","git_commits_url":"https://api.github.com/repos/mattermost/mattermost-load-test/git/commits{/sha}","comments_url":"https://api.github.com/repos/mattermost/mattermost-load-test/comments{/number}","issue_comment_url":"https://api.github.com/repos/mattermost/mattermost-load-test/issues/comments{/number}","contents_url":"https://api.github.com/repos/mattermost/mattermost-load-test/contents/{+path}","compare_url":"https://api.github.com/repos/mattermost/mattermost-load-test/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mattermost/mattermost-load-test/merges","archive_url":"https://api.github.com/repos/mattermost/mattermost-load-test/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mattermost/mattermost-load-test/downloads","issues_url":"https://api.github.com/repos/mattermost/mattermost-load-test/issues{/number}","pulls_url":"https://api.github.com/repos/mattermost/mattermost-load-test/pulls{/number}","milestones_url":"https://api.github.com/repos/mattermost/mattermost-load-test/milestones{/number}","notifications_url":"https://api.github.com/repos/mattermost/mattermost-load-test/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mattermost/mattermost-load-test/labels{/name}","releases_url":"https://api.github.com/repos/mattermost/mattermost-load-test/releases{/id}","deployments_url":"https://api.github.com/repos/mattermost/mattermost-load-test/deployments","created_at":"2016-09-28T20:35:52Z","updated_at":"2018-07-06T19:15:38Z","pushed_at":"2018-07-06T19:41:59Z","git_url":"git://github.com/mattermost/mattermost-load-test.git","ssh_url":"[email protected]:mattermost/mattermost-load-test.git","clone_url":"https://github.com/mattermost/mattermost-load-test.git","svn_url":"https://github.com/mattermost/mattermost-load-test","homepage":"","size":66316,"stargazers_count":27,"watchers_count":27,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":19,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":19,"open_issues":4,"watchers":27,"default_branch":"master"}},"base":{"label":"mattermost:master","ref":"master","sha":"db6d1bab9955404d25e355351402565d31b66458","user":{"login":"mattermost","id":9828093,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk4MjgwOTM=","avatar_url":"https://avatars1.githubusercontent.com/u/9828093?v=4","gravatar_id":"","url":"https://api.github.com/users/mattermost","html_url":"https://github.com/mattermost","followers_url":"https://api.github.com/users/mattermost/followers","following_url":"https://api.github.com/users/mattermost/following{/other_user}","gists_url":"https://api.github.com/users/mattermost/gists{/gist_id}","starred_url":"https://api.github.com/users/mattermost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattermost/subscriptions","organizations_url":"https://api.github.com/users/mattermost/orgs","repos_url":"https://api.github.com/users/mattermost/repos","events_url":"https://api.github.com/users/mattermost/events{/privacy}","received_events_url":"https://api.github.com/users/mattermost/received_events","type":"Organization","site_admin":false},"repo":{"id":69501671,"node_id":"MDEwOlJlcG9zaXRvcnk2OTUwMTY3MQ==","name":"mattermost-load-test","full_name":"mattermost/mattermost-load-test","owner":{"login":"mattermost","id":9828093,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk4MjgwOTM=","avatar_url":"https://avatars1.githubusercontent.com/u/9828093?v=4","gravatar_id":"","url":"https://api.github.com/users/mattermost","html_url":"https://github.com/mattermost","followers_url":"https://api.github.com/users/mattermost/followers","following_url":"https://api.github.com/users/mattermost/following{/other_user}","gists_url":"https://api.github.com/users/mattermost/gists{/gist_id}","starred_url":"https://api.github.com/users/mattermost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattermost/subscriptions","organizations_url":"https://api.github.com/users/mattermost/orgs","repos_url":"https://api.github.com/users/mattermost/repos","events_url":"https://api.github.com/users/mattermost/events{/privacy}","received_events_url":"https://api.github.com/users/mattermost/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mattermost/mattermost-load-test","description":"Tools for profiling Mattermost under heavy load","fork":false,"url":"https://api.github.com/repos/mattermost/mattermost-load-test","forks_url":"https://api.github.com/repos/mattermost/mattermost-load-test/forks","keys_url":"https://api.github.com/repos/mattermost/mattermost-load-test/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mattermost/mattermost-load-test/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mattermost/mattermost-load-test/teams","hooks_url":"https://api.github.com/repos/mattermost/mattermost-load-test/hooks","issue_events_url":"https://api.github.com/repos/mattermost/mattermost-load-test/issues/events{/number}","events_url":"https://api.github.com/repos/mattermost/mattermost-load-test/events","assignees_url":"https://api.github.com/repos/mattermost/mattermost-load-test/assignees{/user}","branches_url":"https://api.github.com/repos/mattermost/mattermost-load-test/branches{/branch}","tags_url":"https://api.github.com/repos/mattermost/mattermost-load-test/tags","blobs_url":"https://api.github.com/repos/mattermost/mattermost-load-test/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mattermost/mattermost-load-test/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mattermost/mattermost-load-test/git/refs{/sha}","trees_url":"https://api.github.com/repos/mattermost/mattermost-load-test/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mattermost/mattermost-load-test/statuses/{sha}","languages_url":"https://api.github.com/repos/mattermost/mattermost-load-test/languages","stargazers_url":"https://api.github.com/repos/mattermost/mattermost-load-test/stargazers","contributors_url":"https://api.github.com/repos/mattermost/mattermost-load-test/contributors","subscribers_url":"https://api.github.com/repos/mattermost/mattermost-load-test/subscribers","subscription_url":"https://api.github.com/repos/mattermost/mattermost-load-test/subscription","commits_url":"https://api.github.com/repos/mattermost/mattermost-load-test/commits{/sha}","git_commits_url":"https://api.github.com/repos/mattermost/mattermost-load-test/git/commits{/sha}","comments_url":"https://api.github.com/repos/mattermost/mattermost-load-test/comments{/number}","issue_comment_url":"https://api.github.com/repos/mattermost/mattermost-load-test/issues/comments{/number}","contents_url":"https://api.github.com/repos/mattermost/mattermost-load-test/contents/{+path}","compare_url":"https://api.github.com/repos/mattermost/mattermost-load-test/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mattermost/mattermost-load-test/merges","archive_url":"https://api.github.com/repos/mattermost/mattermost-load-test/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mattermost/mattermost-load-test/downloads","issues_url":"https://api.github.com/repos/mattermost/mattermost-load-test/issues{/number}","pulls_url":"https://api.github.com/repos/mattermost/mattermost-load-test/pulls{/number}","milestones_url":"https://api.github.com/repos/mattermost/mattermost-load-test/milestones{/number}","notifications_url":"https://api.github.com/repos/mattermost/mattermost-load-test/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mattermost/mattermost-load-test/labels{/name}","releases_url":"https://api.github.com/repos/mattermost/mattermost-load-test/releases{/id}","deployments_url":"https://api.github.com/repos/mattermost/mattermost-load-test/deployments","created_at":"2016-09-28T20:35:52Z","updated_at":"2018-07-06T19:15:38Z","pushed_at":"2018-07-06T19:41:59Z","git_url":"git://github.com/mattermost/mattermost-load-test.git","ssh_url":"[email protected]:mattermost/mattermost-load-test.git","clone_url":"https://github.com/mattermost/mattermost-load-test.git","svn_url":"https://github.com/mattermost/mattermost-load-test","homepage":"","size":66316,"stargazers_count":27,"watchers_count":27,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":19,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":19,"open_issues":4,"watchers":27,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mattermost/mattermost-load-test/pulls/105"},"html":{"href":"https://github.com/mattermost/mattermost-load-test/pull/105"},"issue":{"href":"https://api.github.com/repos/mattermost/mattermost-load-test/issues/105"},"comments":{"href":"https://api.github.com/repos/mattermost/mattermost-load-test/issues/105/comments"},"review_comments":{"href":"https://api.github.com/repos/mattermost/mattermost-load-test/pulls/105/comments"},"review_comment":{"href":"https://api.github.com/repos/mattermost/mattermost-load-test/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mattermost/mattermost-load-test/pulls/105/commits"},"statuses":{"href":"https://api.github.com/repos/mattermost/mattermost-load-test/statuses/916c221946441506684f3e4f4ddf12df184a708f"}},"author_association":"CONTRIBUTOR"}} | {
"id": 69501671,
"name": "mattermost/mattermost-load-test",
"url": "https://api.github.com/repos/mattermost/mattermost-load-test"
} | {
"id": 3191642,
"login": "crspeller",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3191642?",
"url": "https://api.github.com/users/crspeller"
} | {
"id": 9828093,
"login": "mattermost",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9828093?",
"url": "https://api.github.com/orgs/mattermost"
} | 2018-07-06T20:32:13 | 7930819805 | {"actor":{"display_login":"crspeller"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/pulls/comments/229121599","pull_request_review_id":169546084,"id":229121599,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyOTEyMTU5OQ==","diff_hunk":"@@ -33,19 +48,30 @@ protected override IEnumerable<ServiceInstanceListener> CreateServiceInstanceLis\n /// <param name=\"cancellationToken\">Canceled when Service Fabric needs to shut down this service instance.</param>\n protected override async Task RunAsync(CancellationToken cancellationToken)\n {\n- // TODO: Replace the following sample code with your own logic \n- // or remove this RunAsync override if it's not needed in your service.\n-\n- long iterations = 0;\n+ var initialised = false;\n \n- while (true)\n+ try\n {\n- cancellationToken.ThrowIfCancellationRequested();\n+ logger.LogInfo(\"Earning Events Stateless Service Start\");\n+ this.jobContextManager = lifetimeScope.Resolve<IJobContextManager<JobContextMessage>>();","path":"src/SFA.DAS.Payments.EarningEvents.EarningEventsService/EarningEventsService.cs","position":64,"original_position":64,"commit_id":"9c047a34e615993b42514f97bf116dc569c4f4c3","original_commit_id":"9c047a34e615993b42514f97bf116dc569c4f4c3","user":{"login":"abroodie","id":2170720,"node_id":"MDQ6VXNlcjIxNzA3MjA=","avatar_url":"https://avatars0.githubusercontent.com/u/2170720?v=4","gravatar_id":"","url":"https://api.github.com/users/abroodie","html_url":"https://github.com/abroodie","followers_url":"https://api.github.com/users/abroodie/followers","following_url":"https://api.github.com/users/abroodie/following{/other_user}","gists_url":"https://api.github.com/users/abroodie/gists{/gist_id}","starred_url":"https://api.github.com/users/abroodie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abroodie/subscriptions","organizations_url":"https://api.github.com/users/abroodie/orgs","repos_url":"https://api.github.com/users/abroodie/repos","events_url":"https://api.github.com/users/abroodie/events{/privacy}","received_events_url":"https://api.github.com/users/abroodie/received_events","type":"User","site_admin":false},"body":"Done","created_at":"2018-10-29T22:29:44Z","updated_at":"2018-10-29T22:29:44Z","html_url":"https://github.com/SkillsFundingAgency/das-payments-V2/pull/51#discussion_r229121599","pull_request_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/pulls/51","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/pulls/comments/229121599"},"html":{"href":"https://github.com/SkillsFundingAgency/das-payments-V2/pull/51#discussion_r229121599"},"pull_request":{"href":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/pulls/51"}},"in_reply_to_id":228858305},"pull_request":{"url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/pulls/51","id":226098475,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2MDk4NDc1","html_url":"https://github.com/SkillsFundingAgency/das-payments-V2/pull/51","diff_url":"https://github.com/SkillsFundingAgency/das-payments-V2/pull/51.diff","patch_url":"https://github.com/SkillsFundingAgency/das-payments-V2/pull/51.patch","issue_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/issues/51","number":51,"state":"open","locked":false,"title":"Pv2 171 earning event service","user":{"login":"davehowlett","id":2296679,"node_id":"MDQ6VXNlcjIyOTY2Nzk=","avatar_url":"https://avatars0.githubusercontent.com/u/2296679?v=4","gravatar_id":"","url":"https://api.github.com/users/davehowlett","html_url":"https://github.com/davehowlett","followers_url":"https://api.github.com/users/davehowlett/followers","following_url":"https://api.github.com/users/davehowlett/following{/other_user}","gists_url":"https://api.github.com/users/davehowlett/gists{/gist_id}","starred_url":"https://api.github.com/users/davehowlett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davehowlett/subscriptions","organizations_url":"https://api.github.com/users/davehowlett/orgs","repos_url":"https://api.github.com/users/davehowlett/repos","events_url":"https://api.github.com/users/davehowlett/events{/privacy}","received_events_url":"https://api.github.com/users/davehowlett/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-10-26T13:28:54Z","updated_at":"2018-10-29T22:29:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6d3cf48d86927fadbc993ee78a0881e69389a823","assignee":null,"assignees":[],"requested_reviewers":[{"login":"abroodie","id":2170720,"node_id":"MDQ6VXNlcjIxNzA3MjA=","avatar_url":"https://avatars0.githubusercontent.com/u/2170720?v=4","gravatar_id":"","url":"https://api.github.com/users/abroodie","html_url":"https://github.com/abroodie","followers_url":"https://api.github.com/users/abroodie/followers","following_url":"https://api.github.com/users/abroodie/following{/other_user}","gists_url":"https://api.github.com/users/abroodie/gists{/gist_id}","starred_url":"https://api.github.com/users/abroodie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abroodie/subscriptions","organizations_url":"https://api.github.com/users/abroodie/orgs","repos_url":"https://api.github.com/users/abroodie/repos","events_url":"https://api.github.com/users/abroodie/events{/privacy}","received_events_url":"https://api.github.com/users/abroodie/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/pulls/51/commits","review_comments_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/pulls/51/comments","review_comment_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/issues/51/comments","statuses_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/statuses/9c047a34e615993b42514f97bf116dc569c4f4c3","head":{"label":"SkillsFundingAgency:PV2-171_earning_event_service","ref":"PV2-171_earning_event_service","sha":"9c047a34e615993b42514f97bf116dc569c4f4c3","user":{"login":"SkillsFundingAgency","id":9841374,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk4NDEzNzQ=","avatar_url":"https://avatars1.githubusercontent.com/u/9841374?v=4","gravatar_id":"","url":"https://api.github.com/users/SkillsFundingAgency","html_url":"https://github.com/SkillsFundingAgency","followers_url":"https://api.github.com/users/SkillsFundingAgency/followers","following_url":"https://api.github.com/users/SkillsFundingAgency/following{/other_user}","gists_url":"https://api.github.com/users/SkillsFundingAgency/gists{/gist_id}","starred_url":"https://api.github.com/users/SkillsFundingAgency/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SkillsFundingAgency/subscriptions","organizations_url":"https://api.github.com/users/SkillsFundingAgency/orgs","repos_url":"https://api.github.com/users/SkillsFundingAgency/repos","events_url":"https://api.github.com/users/SkillsFundingAgency/events{/privacy}","received_events_url":"https://api.github.com/users/SkillsFundingAgency/received_events","type":"Organization","site_admin":false},"repo":{"id":138287680,"node_id":"MDEwOlJlcG9zaXRvcnkxMzgyODc2ODA=","name":"das-payments-V2","full_name":"SkillsFundingAgency/das-payments-V2","private":false,"owner":{"login":"SkillsFundingAgency","id":9841374,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk4NDEzNzQ=","avatar_url":"https://avatars1.githubusercontent.com/u/9841374?v=4","gravatar_id":"","url":"https://api.github.com/users/SkillsFundingAgency","html_url":"https://github.com/SkillsFundingAgency","followers_url":"https://api.github.com/users/SkillsFundingAgency/followers","following_url":"https://api.github.com/users/SkillsFundingAgency/following{/other_user}","gists_url":"https://api.github.com/users/SkillsFundingAgency/gists{/gist_id}","starred_url":"https://api.github.com/users/SkillsFundingAgency/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SkillsFundingAgency/subscriptions","organizations_url":"https://api.github.com/users/SkillsFundingAgency/orgs","repos_url":"https://api.github.com/users/SkillsFundingAgency/repos","events_url":"https://api.github.com/users/SkillsFundingAgency/events{/privacy}","received_events_url":"https://api.github.com/users/SkillsFundingAgency/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/SkillsFundingAgency/das-payments-V2","description":null,"fork":false,"url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2","forks_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/forks","keys_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/teams","hooks_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/hooks","issue_events_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/issues/events{/number}","events_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/events","assignees_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/assignees{/user}","branches_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/branches{/branch}","tags_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/tags","blobs_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/git/refs{/sha}","trees_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/statuses/{sha}","languages_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/languages","stargazers_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/stargazers","contributors_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/contributors","subscribers_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/subscribers","subscription_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/subscription","commits_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/commits{/sha}","git_commits_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/git/commits{/sha}","comments_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/comments{/number}","issue_comment_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/issues/comments{/number}","contents_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/contents/{+path}","compare_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/merges","archive_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/downloads","issues_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/issues{/number}","pulls_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/pulls{/number}","milestones_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/milestones{/number}","notifications_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/labels{/name}","releases_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/releases{/id}","deployments_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/deployments","created_at":"2018-06-22T10:06:34Z","updated_at":"2018-10-24T11:07:26Z","pushed_at":"2018-10-29T15:18:39Z","git_url":"git://github.com/SkillsFundingAgency/das-payments-V2.git","ssh_url":"[email protected]:SkillsFundingAgency/das-payments-V2.git","clone_url":"https://github.com/SkillsFundingAgency/das-payments-V2.git","svn_url":"https://github.com/SkillsFundingAgency/das-payments-V2","homepage":null,"size":2096,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"SkillsFundingAgency:master","ref":"master","sha":"d285603eac328414a3c28fb7a2cfa29374debf7a","user":{"login":"SkillsFundingAgency","id":9841374,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk4NDEzNzQ=","avatar_url":"https://avatars1.githubusercontent.com/u/9841374?v=4","gravatar_id":"","url":"https://api.github.com/users/SkillsFundingAgency","html_url":"https://github.com/SkillsFundingAgency","followers_url":"https://api.github.com/users/SkillsFundingAgency/followers","following_url":"https://api.github.com/users/SkillsFundingAgency/following{/other_user}","gists_url":"https://api.github.com/users/SkillsFundingAgency/gists{/gist_id}","starred_url":"https://api.github.com/users/SkillsFundingAgency/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SkillsFundingAgency/subscriptions","organizations_url":"https://api.github.com/users/SkillsFundingAgency/orgs","repos_url":"https://api.github.com/users/SkillsFundingAgency/repos","events_url":"https://api.github.com/users/SkillsFundingAgency/events{/privacy}","received_events_url":"https://api.github.com/users/SkillsFundingAgency/received_events","type":"Organization","site_admin":false},"repo":{"id":138287680,"node_id":"MDEwOlJlcG9zaXRvcnkxMzgyODc2ODA=","name":"das-payments-V2","full_name":"SkillsFundingAgency/das-payments-V2","private":false,"owner":{"login":"SkillsFundingAgency","id":9841374,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk4NDEzNzQ=","avatar_url":"https://avatars1.githubusercontent.com/u/9841374?v=4","gravatar_id":"","url":"https://api.github.com/users/SkillsFundingAgency","html_url":"https://github.com/SkillsFundingAgency","followers_url":"https://api.github.com/users/SkillsFundingAgency/followers","following_url":"https://api.github.com/users/SkillsFundingAgency/following{/other_user}","gists_url":"https://api.github.com/users/SkillsFundingAgency/gists{/gist_id}","starred_url":"https://api.github.com/users/SkillsFundingAgency/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SkillsFundingAgency/subscriptions","organizations_url":"https://api.github.com/users/SkillsFundingAgency/orgs","repos_url":"https://api.github.com/users/SkillsFundingAgency/repos","events_url":"https://api.github.com/users/SkillsFundingAgency/events{/privacy}","received_events_url":"https://api.github.com/users/SkillsFundingAgency/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/SkillsFundingAgency/das-payments-V2","description":null,"fork":false,"url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2","forks_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/forks","keys_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/teams","hooks_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/hooks","issue_events_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/issues/events{/number}","events_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/events","assignees_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/assignees{/user}","branches_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/branches{/branch}","tags_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/tags","blobs_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/git/refs{/sha}","trees_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/statuses/{sha}","languages_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/languages","stargazers_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/stargazers","contributors_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/contributors","subscribers_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/subscribers","subscription_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/subscription","commits_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/commits{/sha}","git_commits_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/git/commits{/sha}","comments_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/comments{/number}","issue_comment_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/issues/comments{/number}","contents_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/contents/{+path}","compare_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/merges","archive_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/downloads","issues_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/issues{/number}","pulls_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/pulls{/number}","milestones_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/milestones{/number}","notifications_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/labels{/name}","releases_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/releases{/id}","deployments_url":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/deployments","created_at":"2018-06-22T10:06:34Z","updated_at":"2018-10-24T11:07:26Z","pushed_at":"2018-10-29T15:18:39Z","git_url":"git://github.com/SkillsFundingAgency/das-payments-V2.git","ssh_url":"[email protected]:SkillsFundingAgency/das-payments-V2.git","clone_url":"https://github.com/SkillsFundingAgency/das-payments-V2.git","svn_url":"https://github.com/SkillsFundingAgency/das-payments-V2","homepage":null,"size":2096,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/pulls/51"},"html":{"href":"https://github.com/SkillsFundingAgency/das-payments-V2/pull/51"},"issue":{"href":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/issues/51"},"comments":{"href":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/issues/51/comments"},"review_comments":{"href":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/pulls/51/comments"},"review_comment":{"href":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/pulls/51/commits"},"statuses":{"href":"https://api.github.com/repos/SkillsFundingAgency/das-payments-V2/statuses/9c047a34e615993b42514f97bf116dc569c4f4c3"}},"author_association":"CONTRIBUTOR"}} | {
"id": 138287680,
"name": "SkillsFundingAgency/das-payments-V2",
"url": "https://api.github.com/repos/SkillsFundingAgency/das-payments-V2"
} | {
"id": 2170720,
"login": "abroodie",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2170720?",
"url": "https://api.github.com/users/abroodie"
} | {
"id": 9841374,
"login": "SkillsFundingAgency",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9841374?",
"url": "https://api.github.com/orgs/SkillsFundingAgency"
} | 2018-10-29T22:29:44 | 8501280785 | {"actor":{"display_login":"abroodie"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/SkillsFundingAgency/das-employerapprenticeshipsservice/pulls/comments/181002942","pull_request_review_id":111524475,"id":181002942,"diff_hunk":"@@ -0,0 +1,66 @@\n+using MediatR;\n+using SFA.DAS.EAS.Application.Hashing;\n+using SFA.DAS.EAS.Domain.Extensions;\n+using SFA.DAS.EAS.Domain.Models.Transfers;\n+using SFA.DAS.EAS.Infrastructure.Data;\n+using SFA.DAS.EAS.Infrastructure.Extensions;\n+using System;\n+using System.Linq;\n+using System.Threading.Tasks;\n+\n+namespace SFA.DAS.EAS.Application.Queries.GetTransferSenderTransactionDetails\n+{\n+ public class GetTransferTransactionDetailsQueryHandler : IAsyncRequestHandler<GetTransferTransactionDetailsQuery, GetTransferTransactionDetailsResponse>\n+ {\n+ private readonly EmployerFinancialDbContext _dbContext;\n+ private readonly IPublicHashingService _publicHashingService;\n+\n+ public GetTransferTransactionDetailsQueryHandler(EmployerFinancialDbContext dbContext,\n+ IPublicHashingService publicHashingService)\n+ {\n+ _dbContext = dbContext;\n+ _publicHashingService = publicHashingService;\n+ }\n+\n+ public async Task<GetTransferTransactionDetailsResponse> Handle(GetTransferTransactionDetailsQuery query)\n+ {\n+ var result = await _dbContext.GetTransfersByTargetAccountId(\n+ query.AccountId.GetValueOrDefault(),\n+ query.TargetAccountId,\n+ query.PeriodEnd);\n+\n+ var transfers = result as AccountTransfer[] ?? result.ToArray();","path":"src/SFA.DAS.EmployerApprenticeshipsService.Application/Queries/GetTransferSenderTransactionDetails/GetTransferTransactionDetailsQueryHandler.cs","position":null,"original_position":32,"commit_id":"9a4e8ee2dd70b767a464e6d997614922babc6afa","original_commit_id":"36136728e0dbf645f346d1de3a23ac98600d274f","user":{"login":"robinoconnor","id":18703884,"avatar_url":"https://avatars2.githubusercontent.com/u/18703884?v=4","gravatar_id":"","url":"https://api.github.com/users/robinoconnor","html_url":"https://github.com/robinoconnor","followers_url":"https://api.github.com/users/robinoconnor/followers","following_url":"https://api.github.com/users/robinoconnor/following{/other_user}","gists_url":"https://api.github.com/users/robinoconnor/gists{/gist_id}","starred_url":"https://api.github.com/users/robinoconnor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robinoconnor/subscriptions","organizations_url":"https://api.github.com/users/robinoconnor/orgs","repos_url":"https://api.github.com/users/robinoconnor/repos","events_url":"https://api.github.com/users/robinoconnor/events{/privacy}","received_events_url":"https://api.github.com/users/robinoconnor/received_events","type":"User","site_admin":false},"body":"Does this not stop multiple enumerations in the latest code?","created_at":"2018-04-12T08:31:19Z","updated_at":"2018-04-12T08:31:19Z","html_url":"https://github.com/SkillsFundingAgency/das-employerapprenticeshipsservice/pull/1195#discussion_r181002942","pull_request_url":"https://api.github.com/repos/SkillsFundingAgency/das-employerapprenticeshipsservice/pulls/1195","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/SkillsFundingAgency/das-employerapprenticeshipsservice/pulls/comments/181002942"},"html":{"href":"https://github.com/SkillsFundingAgency/das-employerapprenticeshipsservice/pull/1195#discussion_r181002942"},"pull_request":{"href":"https://api.github.com/repos/SkillsFundingAgency/das-employerapprenticeshipsservice/pulls/1195"}},"in_reply_to_id":179522954},"pull_request":{"url":"https://api.github.com/repos/SkillsFundingAgency/das-employerapprenticeshipsservice/pulls/1195","id":179679956,"html_url":"https://github.com/SkillsFundingAgency/das-employerapprenticeshipsservice/pull/1195","diff_url":"https://github.com/SkillsFundingAgency/das-employerapprenticeshipsservice/pull/1195.diff","patch_url":"https://github.com/SkillsFundingAgency/das-employerapprenticeshipsservice/pull/1195.patch","issue_url":"https://api.github.com/repos/SkillsFundingAgency/das-employerapprenticeshipsservice/issues/1195","number":1195,"state":"open","locked":false,"title":"Aml 1936 display receiver transfers","user":{"login":"robinoconnor","id":18703884,"avatar_url":"https://avatars2.githubusercontent.com/u/18703884?v=4","gravatar_id":"","url":"https://api.github.com/users/robinoconnor","html_url":"https://github.com/robinoconnor","followers_url":"https://api.github.com/users/robinoconnor/followers","following_url":"https://api.github.com/users/robinoconnor/following{/other_user}","gists_url":"https://api.github.com/users/robinoconnor/gists{/gist_id}","starred_url":"https://api.github.com/users/robinoconnor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robinoconnor/subscriptions","organizations_url":"https://api.github.com/users/robinoconnor/orgs","repos_url":"https://api.github.com/users/robinoconnor/repos","events_url":"https://api.github.com/users/robinoconnor/events{/privacy}","received_events_url":"https://api.github.com/users/robinoconnor/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-04-05T13:42:14Z","updated_at":"2018-04-12T08:31:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9ef211df8491377ce3db5ae7223cbb37db6e21da","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/SkillsFundingAgency/das-employerapprenticeshipsservice/pulls/1195/commits","review_comments_url":"https://api.github.com/repos/SkillsFundingAgency/das-employerapprenticeshipsservice/pulls/1195/comments","review_comment_url":"https://api.github.com/repos/SkillsFundingAgency/das-employerapprenticeshipsservice/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SkillsFundingAgency/das-employerapprenticeshipsservice/issues/1195/comments","statuses_url":"https://api.github.com/repos/SkillsFundingAgency/das-employerapprenticeshipsservice/statuses/9a4e8ee2dd70b767a464e6d997614922babc6afa","head":{"label":"SkillsFundingAgency:AML-1936_Display_Receiver_Transfers","ref":"AML-1936_Display_Receiver_Transfers","sha":"9a4e8ee2dd70b767a464e6d997614922babc6afa","user":{"login":"SkillsFundingAgency","id":9841374,"avatar_url":"https://avatars1.githubusercontent.com/u/9841374?v=4","gravatar_id":"","url":"https://api.github.com/users/SkillsFundingAgency","html_url":"https://github.com/SkillsFundingAgency","followers_url":"https://api.github.com/users/SkillsFundingAgency/followers","following_url":"https://api.github.com/users/SkillsFundingAgency/following{/other_user}","gists_url":"https://api.github.com/users/SkillsFundingAgency/gists{/gist_id}","starred_url":"https://api.github.com/users/SkillsFundingAgency/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SkillsFundingAgency/subscriptions","organizations_url":"https://api.github.com/users/SkillsFundingAgency/orgs","repos_url":"https://api.github.com/users/SkillsFundingAgency/repos","events_url":"https://api.github.com/users/SkillsFundingAgency/events{/privacy}","received_events_url":"https://api.github.com/users/SkillsFundingAgency/received_events","type":"Organization","site_admin":false},"repo":{"id":62730388,"name":"das-employerapprenticeshipsservice","full_name":"SkillsFundingAgency/das-employerapprenticeshipsservice","owner":{"login":"SkillsFundingAgency","id":9841374,"avatar_url":"https://avatars1.githubusercontent.com/u/9841374?v=4","gravatar_id":"","url":"https://api.github.com/users/SkillsFundingAgency","html_url":"https://github.com/SkillsFundingAgency","followers_url":"https://api.github.com/users/SkillsFundingAgency/followers","following_url":"https://api.github.com/users/SkillsFundingAgency/following{/other_user}","gists_url":"https://api.github.com/users/SkillsFundingAgency/gists{/gist_id}","starred_url":"https://api.github.com/users/SkillsFundingAgency/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SkillsFundingAgency/subscriptions","organizations_url":"https://api.github.com/users/SkillsFundingAgency/orgs","repos_url":"https://api.github.com/users/SkillsFundingAgency/repos","events_url":"https://api.github.com/users/SkillsFundingAgency/events{/privacy}","received_events_url":"https://api.github.com/users/SkillsFundingAgency/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SkillsFundingAgency/das-employerapprenticeshipsservice","description":"Digital Apprenticeship Service - Employer Portal","fork":false,"url":"https://api.github.com/repos/SkillsFundingAgency/das-employerapprenticeshipsservice","forks_url":"https://api.github.com/repos/SkillsFundingAgency/das-employerapprenticeshipsservice/forks","keys_url":"https://api.github.com/repos/SkillsFundingAgency/das-employerapprenticeshipsservice/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SkillsFundingAgency/das-employerapprenticeshipsservice/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SkillsFundingAgency/das-employerapprenticeshipsservice/teams","hooks_url":"https://api.github.com/repos/SkillsFundingAgency/das-employerapprenticeshipsservice/hooks","issue_events_url":"https://api.github.com/repos/SkillsFundingAgency/das-employerapprenticeshipsservice/issues/events{/number}","events_url":"https://api.github.com/repos/SkillsFundingAgency/das-employerapprenticeshipsservice/events","assignees_url":"https://api.github.com/repos/SkillsFundingAgency/das-employerapprenticeshipsservice/assignees{/user}","branches_url":"https://api.github.com/repos/SkillsFundingAgency/das-employerapprenticeshipsservice/branches{/branch}","tags_url":"https://api.github.com/repos/SkillsFundingAgency/das-employerapprenticeshipsservice/tags","blobs_url":"https://api.github.com/repos/SkillsFundingAgency/das-employerapprenticeshipsservice/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SkillsFundingAgency/das-employerapprenticeshipsservice/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SkillsFundingAgency/das-employerapprenticeshipsservice/git/refs{/sha}","trees_url":"https://api.github.com/repos/SkillsFundingAgency/das-employerapprenticeshipsservice/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SkillsFundingAgency/das-employerapprenticeshipsservice/statuses/{sha}","languages_url":"https://api.github.com/repos/SkillsFundingAgency/das-employerapprenticeshipsservice/languages","stargazers_url":"https://api.github.com/repos/SkillsFundingAgency/das-employerapprenticeshipsservice/stargazers","contributors_url":"https://api.github.com/repos/SkillsFundingAgency/das-employerapprenticeshipsservice/contributors","subscribers_url":"https://api.github.com/repos/SkillsFundingAgency/das-employerapprenticeshipsservice/subscribers","subscription_url":"https://api.github.com/repos/SkillsFundingAgency/das-employerapprenticeshipsservice/subscription","commits_url":"https://api.github.com/repos/SkillsFundingAgency/das-employerapprenticeshipsservice/commits{/sha}","git_commits_url":"https://api.github.com/repos/SkillsFundingAgency/das-employerapprenticeshipsservice/git/commits{/sha}","comments_url":"https://api.github.com/repos/SkillsFundingAgency/das-employerapprenticeshipsservice/comments{/number}","issue_comment_url":"https://api.github.com/repos/SkillsFundingAgency/das-employerapprenticeshipsservice/issues/comments{/number}","contents_url":"https://api.github.com/repos/SkillsFundingAgency/das-employerapprenticeshipsservice/contents/{+path}","compare_url":"https://api.github.com/repos/SkillsFundingAgency/das-employerapprenticeshipsservice/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SkillsFundingAgency/das-employerapprenticeshipsservice/merges","archive_url":"https://api.github.com/repos/SkillsFundingAgency/das-employerapprenticeshipsservice/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SkillsFundingAgency/das-employerapprenticeshipsservice/downloads","issues_url":"https://api.github.com/repos/SkillsFundingAgency/das-employerapprenticeshipsservice/issues{/number}","pulls_url":"https://api.github.com/repos/SkillsFundingAgency/das-employerapprenticeshipsservice/pulls{/number}","milestones_url":"https://api.github.com/repos/SkillsFundingAgency/das-employerapprenticeshipsservice/milestones{/number}","notifications_url":"https://api.github.com/repos/SkillsFundingAgency/das-employerapprenticeshipsservice/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SkillsFundingAgency/das-employerapprenticeshipsservice/labels{/name}","releases_url":"https://api.github.com/repos/SkillsFundingAgency/das-employerapprenticeshipsservice/releases{/id}","deployments_url":"https://api.github.com/repos/SkillsFundingAgency/das-employerapprenticeshipsservice/deployments","created_at":"2016-07-06T15:07:32Z","updated_at":"2018-04-10T08:22:18Z","pushed_at":"2018-04-12T07:53:39Z","git_url":"git://github.com/SkillsFundingAgency/das-employerapprenticeshipsservice.git","ssh_url":"[email protected]:SkillsFundingAgency/das-employerapprenticeshipsservice.git","clone_url":"https://github.com/SkillsFundingAgency/das-employerapprenticeshipsservice.git","svn_url":"https://github.com/SkillsFundingAgency/das-employerapprenticeshipsservice","homepage":"https://manage-apprenticeships.service.gov.uk","size":48936,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":22,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":1,"open_issues":22,"watchers":0,"default_branch":"master"}},"base":{"label":"SkillsFundingAgency:master","ref":"master","sha":"829eed5823de24df7f556053bfcae590e96d77df","user":{"login":"SkillsFundingAgency","id":9841374,"avatar_url":"https://avatars1.githubusercontent.com/u/9841374?v=4","gravatar_id":"","url":"https://api.github.com/users/SkillsFundingAgency","html_url":"https://github.com/SkillsFundingAgency","followers_url":"https://api.github.com/users/SkillsFundingAgency/followers","following_url":"https://api.github.com/users/SkillsFundingAgency/following{/other_user}","gists_url":"https://api.github.com/users/SkillsFundingAgency/gists{/gist_id}","starred_url":"https://api.github.com/users/SkillsFundingAgency/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SkillsFundingAgency/subscriptions","organizations_url":"https://api.github.com/users/SkillsFundingAgency/orgs","repos_url":"https://api.github.com/users/SkillsFundingAgency/repos","events_url":"https://api.github.com/users/SkillsFundingAgency/events{/privacy}","received_events_url":"https://api.github.com/users/SkillsFundingAgency/received_events","type":"Organization","site_admin":false},"repo":{"id":62730388,"name":"das-employerapprenticeshipsservice","full_name":"SkillsFundingAgency/das-employerapprenticeshipsservice","owner":{"login":"SkillsFundingAgency","id":9841374,"avatar_url":"https://avatars1.githubusercontent.com/u/9841374?v=4","gravatar_id":"","url":"https://api.github.com/users/SkillsFundingAgency","html_url":"https://github.com/SkillsFundingAgency","followers_url":"https://api.github.com/users/SkillsFundingAgency/followers","following_url":"https://api.github.com/users/SkillsFundingAgency/following{/other_user}","gists_url":"https://api.github.com/users/SkillsFundingAgency/gists{/gist_id}","starred_url":"https://api.github.com/users/SkillsFundingAgency/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SkillsFundingAgency/subscriptions","organizations_url":"https://api.github.com/users/SkillsFundingAgency/orgs","repos_url":"https://api.github.com/users/SkillsFundingAgency/repos","events_url":"https://api.github.com/users/SkillsFundingAgency/events{/privacy}","received_events_url":"https://api.github.com/users/SkillsFundingAgency/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SkillsFundingAgency/das-employerapprenticeshipsservice","description":"Digital Apprenticeship Service - Employer Portal","fork":false,"url":"https://api.github.com/repos/SkillsFundingAgency/das-employerapprenticeshipsservice","forks_url":"https://api.github.com/repos/SkillsFundingAgency/das-employerapprenticeshipsservice/forks","keys_url":"https://api.github.com/repos/SkillsFundingAgency/das-employerapprenticeshipsservice/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SkillsFundingAgency/das-employerapprenticeshipsservice/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SkillsFundingAgency/das-employerapprenticeshipsservice/teams","hooks_url":"https://api.github.com/repos/SkillsFundingAgency/das-employerapprenticeshipsservice/hooks","issue_events_url":"https://api.github.com/repos/SkillsFundingAgency/das-employerapprenticeshipsservice/issues/events{/number}","events_url":"https://api.github.com/repos/SkillsFundingAgency/das-employerapprenticeshipsservice/events","assignees_url":"https://api.github.com/repos/SkillsFundingAgency/das-employerapprenticeshipsservice/assignees{/user}","branches_url":"https://api.github.com/repos/SkillsFundingAgency/das-employerapprenticeshipsservice/branches{/branch}","tags_url":"https://api.github.com/repos/SkillsFundingAgency/das-employerapprenticeshipsservice/tags","blobs_url":"https://api.github.com/repos/SkillsFundingAgency/das-employerapprenticeshipsservice/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SkillsFundingAgency/das-employerapprenticeshipsservice/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SkillsFundingAgency/das-employerapprenticeshipsservice/git/refs{/sha}","trees_url":"https://api.github.com/repos/SkillsFundingAgency/das-employerapprenticeshipsservice/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SkillsFundingAgency/das-employerapprenticeshipsservice/statuses/{sha}","languages_url":"https://api.github.com/repos/SkillsFundingAgency/das-employerapprenticeshipsservice/languages","stargazers_url":"https://api.github.com/repos/SkillsFundingAgency/das-employerapprenticeshipsservice/stargazers","contributors_url":"https://api.github.com/repos/SkillsFundingAgency/das-employerapprenticeshipsservice/contributors","subscribers_url":"https://api.github.com/repos/SkillsFundingAgency/das-employerapprenticeshipsservice/subscribers","subscription_url":"https://api.github.com/repos/SkillsFundingAgency/das-employerapprenticeshipsservice/subscription","commits_url":"https://api.github.com/repos/SkillsFundingAgency/das-employerapprenticeshipsservice/commits{/sha}","git_commits_url":"https://api.github.com/repos/SkillsFundingAgency/das-employerapprenticeshipsservice/git/commits{/sha}","comments_url":"https://api.github.com/repos/SkillsFundingAgency/das-employerapprenticeshipsservice/comments{/number}","issue_comment_url":"https://api.github.com/repos/SkillsFundingAgency/das-employerapprenticeshipsservice/issues/comments{/number}","contents_url":"https://api.github.com/repos/SkillsFundingAgency/das-employerapprenticeshipsservice/contents/{+path}","compare_url":"https://api.github.com/repos/SkillsFundingAgency/das-employerapprenticeshipsservice/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SkillsFundingAgency/das-employerapprenticeshipsservice/merges","archive_url":"https://api.github.com/repos/SkillsFundingAgency/das-employerapprenticeshipsservice/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SkillsFundingAgency/das-employerapprenticeshipsservice/downloads","issues_url":"https://api.github.com/repos/SkillsFundingAgency/das-employerapprenticeshipsservice/issues{/number}","pulls_url":"https://api.github.com/repos/SkillsFundingAgency/das-employerapprenticeshipsservice/pulls{/number}","milestones_url":"https://api.github.com/repos/SkillsFundingAgency/das-employerapprenticeshipsservice/milestones{/number}","notifications_url":"https://api.github.com/repos/SkillsFundingAgency/das-employerapprenticeshipsservice/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SkillsFundingAgency/das-employerapprenticeshipsservice/labels{/name}","releases_url":"https://api.github.com/repos/SkillsFundingAgency/das-employerapprenticeshipsservice/releases{/id}","deployments_url":"https://api.github.com/repos/SkillsFundingAgency/das-employerapprenticeshipsservice/deployments","created_at":"2016-07-06T15:07:32Z","updated_at":"2018-04-10T08:22:18Z","pushed_at":"2018-04-12T07:53:39Z","git_url":"git://github.com/SkillsFundingAgency/das-employerapprenticeshipsservice.git","ssh_url":"[email protected]:SkillsFundingAgency/das-employerapprenticeshipsservice.git","clone_url":"https://github.com/SkillsFundingAgency/das-employerapprenticeshipsservice.git","svn_url":"https://github.com/SkillsFundingAgency/das-employerapprenticeshipsservice","homepage":"https://manage-apprenticeships.service.gov.uk","size":48936,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":22,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":1,"open_issues":22,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SkillsFundingAgency/das-employerapprenticeshipsservice/pulls/1195"},"html":{"href":"https://github.com/SkillsFundingAgency/das-employerapprenticeshipsservice/pull/1195"},"issue":{"href":"https://api.github.com/repos/SkillsFundingAgency/das-employerapprenticeshipsservice/issues/1195"},"comments":{"href":"https://api.github.com/repos/SkillsFundingAgency/das-employerapprenticeshipsservice/issues/1195/comments"},"review_comments":{"href":"https://api.github.com/repos/SkillsFundingAgency/das-employerapprenticeshipsservice/pulls/1195/comments"},"review_comment":{"href":"https://api.github.com/repos/SkillsFundingAgency/das-employerapprenticeshipsservice/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SkillsFundingAgency/das-employerapprenticeshipsservice/pulls/1195/commits"},"statuses":{"href":"https://api.github.com/repos/SkillsFundingAgency/das-employerapprenticeshipsservice/statuses/9a4e8ee2dd70b767a464e6d997614922babc6afa"}},"author_association":"CONTRIBUTOR"}} | {
"id": 62730388,
"name": "SkillsFundingAgency/das-employerapprenticeshipsservice",
"url": "https://api.github.com/repos/SkillsFundingAgency/das-employerapprenticeshipsservice"
} | {
"id": 18703884,
"login": "robinoconnor",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/18703884?",
"url": "https://api.github.com/users/robinoconnor"
} | {
"id": 9841374,
"login": "SkillsFundingAgency",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9841374?",
"url": "https://api.github.com/orgs/SkillsFundingAgency"
} | 2018-04-12T08:31:19 | 7518468327 | {"actor":{"display_login":"robinoconnor"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/htmlacademy-adaptive/296487-mishka/pulls/comments/167397012","pull_request_review_id":95620455,"id":167397012,"diff_hunk":"@@ -1,22 +1,262 @@\n .main-nav {\n+ width: 100%;\n color: @black;\n font-size: 17px;\n font-weight: 700;\n line-height: 24px;\n+ min-height: 316px;\n+}\n+\n+.main-nav__wrapper {\n+ width: 320px;\n+ position: relative;\n }\n \n .main-nav__list {\n padding: 0;\n margin: 0;\n+ list-style: none;\n }\n \n .main-nav__item {\n- width: 320px;\n- height: 79px;\n+ min-height: 79px;\n box-shadow: 0 1px 0 #ececec, inset 0 1px 0 #ececec;\n+ background-color: #ffffff;\n+ position: relative;\n }\n \n-.main-nav__item a {\n- margin: 0 auto;\n+.main-nav__link {\n display: block;\n+ padding-top: 27px;\n+ padding-left: 78px;\n+}\n+\n+.main-nav__active {\n+ min-height: 79px;\n+ box-shadow: 0 1px 0 #ececec, inset 0 1px 0 #ececec;\n+ background-color: #ffffff;\n+}\n+\n+.main-nav__shipping {\n+ display: none;\n+}\n+\n+.main-nav__icon {\n+ position: absolute;\n+ top: 32px;\n+ left: 32px;\n+ opacity: 0.2;\n+}\n+\n+.main-nav__logo {\n+ display: block;\n+ padding-top: 21px;\n+ padding-left: 115px;\n+}\n+\n+.main-nav--opened .main-nav__toggle {\n+ background-image: url(\"../img/icon-menu-close.svg\");\n+ position: absolute;\n+ width: 21px;\n+ height: 21px;\n+ top: 30px;\n+ left: 269px;\n+ font-size: 0;\n+ border: none;\n+ background-color: @white;\n+ z-index: 1;\n+}\n+\n+.main-nav--closed .main-nav__toggle {\n+ display: block;\n+ width: 20px;\n+ height: 14px;\n+ position: absolute;\n+ top: 30px;\n+ left: 267px;\n+ font-size: 0;\n+ border: none;\n+ background-color: @white;\n+ background-image: url(\"../img/icon-menu-open.svg\");\n+}\n+\n+.main-nav__item:nth-child(6),","path":"source/less/main-nav.less","position":87,"original_position":87,"commit_id":"633189998d8a1cc3338884148ce8cdb35e030444","original_commit_id":"633189998d8a1cc3338884148ce8cdb35e030444","user":{"login":"artemka107","id":18405633,"avatar_url":"https://avatars0.githubusercontent.com/u/18405633?v=4","gravatar_id":"","url":"https://api.github.com/users/artemka107","html_url":"https://github.com/artemka107","followers_url":"https://api.github.com/users/artemka107/followers","following_url":"https://api.github.com/users/artemka107/following{/other_user}","gists_url":"https://api.github.com/users/artemka107/gists{/gist_id}","starred_url":"https://api.github.com/users/artemka107/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artemka107/subscriptions","organizations_url":"https://api.github.com/users/artemka107/orgs","repos_url":"https://api.github.com/users/artemka107/repos","events_url":"https://api.github.com/users/artemka107/events{/privacy}","received_events_url":"https://api.github.com/users/artemka107/received_events","type":"User","site_admin":false},"body":"А какая задача стоит перед тобой?","created_at":"2018-02-10T11:58:26Z","updated_at":"2018-02-10T11:58:26Z","html_url":"https://github.com/htmlacademy-adaptive/296487-mishka/pull/10#discussion_r167397012","pull_request_url":"https://api.github.com/repos/htmlacademy-adaptive/296487-mishka/pulls/10","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/htmlacademy-adaptive/296487-mishka/pulls/comments/167397012"},"html":{"href":"https://github.com/htmlacademy-adaptive/296487-mishka/pull/10#discussion_r167397012"},"pull_request":{"href":"https://api.github.com/repos/htmlacademy-adaptive/296487-mishka/pulls/10"}},"in_reply_to_id":167349682},"pull_request":{"url":"https://api.github.com/repos/htmlacademy-adaptive/296487-mishka/pulls/10","id":168117075,"html_url":"https://github.com/htmlacademy-adaptive/296487-mishka/pull/10","diff_url":"https://github.com/htmlacademy-adaptive/296487-mishka/pull/10.diff","patch_url":"https://github.com/htmlacademy-adaptive/296487-mishka/pull/10.patch","issue_url":"https://api.github.com/repos/htmlacademy-adaptive/296487-mishka/issues/10","number":10,"state":"open","locked":false,"title":"Завершаем вёрстку","user":{"login":"AVSStorage","id":33234008,"avatar_url":"https://avatars2.githubusercontent.com/u/33234008?v=4","gravatar_id":"","url":"https://api.github.com/users/AVSStorage","html_url":"https://github.com/AVSStorage","followers_url":"https://api.github.com/users/AVSStorage/followers","following_url":"https://api.github.com/users/AVSStorage/following{/other_user}","gists_url":"https://api.github.com/users/AVSStorage/gists{/gist_id}","starred_url":"https://api.github.com/users/AVSStorage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AVSStorage/subscriptions","organizations_url":"https://api.github.com/users/AVSStorage/orgs","repos_url":"https://api.github.com/users/AVSStorage/repos","events_url":"https://api.github.com/users/AVSStorage/events{/privacy}","received_events_url":"https://api.github.com/users/AVSStorage/received_events","type":"User","site_admin":false},"body":"\n\n---\n:mortar_board: [Завершаем вёрстку](https://up.htmlacademy.ru/adaptive/13/user/296487/tasks/11)\n\n:boom: https://htmlacademy-adaptive.github.io/296487-mishka/10/","created_at":"2018-02-08T23:36:47Z","updated_at":"2018-02-10T11:58:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c723867ff551bfefe6bb5bd4fc4723cec19f44ff","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/htmlacademy-adaptive/296487-mishka/pulls/10/commits","review_comments_url":"https://api.github.com/repos/htmlacademy-adaptive/296487-mishka/pulls/10/comments","review_comment_url":"https://api.github.com/repos/htmlacademy-adaptive/296487-mishka/pulls/comments{/number}","comments_url":"https://api.github.com/repos/htmlacademy-adaptive/296487-mishka/issues/10/comments","statuses_url":"https://api.github.com/repos/htmlacademy-adaptive/296487-mishka/statuses/633189998d8a1cc3338884148ce8cdb35e030444","head":{"label":"AVSStorage:module5-task1","ref":"module5-task1","sha":"633189998d8a1cc3338884148ce8cdb35e030444","user":{"login":"AVSStorage","id":33234008,"avatar_url":"https://avatars2.githubusercontent.com/u/33234008?v=4","gravatar_id":"","url":"https://api.github.com/users/AVSStorage","html_url":"https://github.com/AVSStorage","followers_url":"https://api.github.com/users/AVSStorage/followers","following_url":"https://api.github.com/users/AVSStorage/following{/other_user}","gists_url":"https://api.github.com/users/AVSStorage/gists{/gist_id}","starred_url":"https://api.github.com/users/AVSStorage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AVSStorage/subscriptions","organizations_url":"https://api.github.com/users/AVSStorage/orgs","repos_url":"https://api.github.com/users/AVSStorage/repos","events_url":"https://api.github.com/users/AVSStorage/events{/privacy}","received_events_url":"https://api.github.com/users/AVSStorage/received_events","type":"User","site_admin":false},"repo":{"id":117712883,"name":"296487-mishka","full_name":"AVSStorage/296487-mishka","owner":{"login":"AVSStorage","id":33234008,"avatar_url":"https://avatars2.githubusercontent.com/u/33234008?v=4","gravatar_id":"","url":"https://api.github.com/users/AVSStorage","html_url":"https://github.com/AVSStorage","followers_url":"https://api.github.com/users/AVSStorage/followers","following_url":"https://api.github.com/users/AVSStorage/following{/other_user}","gists_url":"https://api.github.com/users/AVSStorage/gists{/gist_id}","starred_url":"https://api.github.com/users/AVSStorage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AVSStorage/subscriptions","organizations_url":"https://api.github.com/users/AVSStorage/orgs","repos_url":"https://api.github.com/users/AVSStorage/repos","events_url":"https://api.github.com/users/AVSStorage/events{/privacy}","received_events_url":"https://api.github.com/users/AVSStorage/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/AVSStorage/296487-mishka","description":"Алиса Смирнова","fork":true,"url":"https://api.github.com/repos/AVSStorage/296487-mishka","forks_url":"https://api.github.com/repos/AVSStorage/296487-mishka/forks","keys_url":"https://api.github.com/repos/AVSStorage/296487-mishka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AVSStorage/296487-mishka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AVSStorage/296487-mishka/teams","hooks_url":"https://api.github.com/repos/AVSStorage/296487-mishka/hooks","issue_events_url":"https://api.github.com/repos/AVSStorage/296487-mishka/issues/events{/number}","events_url":"https://api.github.com/repos/AVSStorage/296487-mishka/events","assignees_url":"https://api.github.com/repos/AVSStorage/296487-mishka/assignees{/user}","branches_url":"https://api.github.com/repos/AVSStorage/296487-mishka/branches{/branch}","tags_url":"https://api.github.com/repos/AVSStorage/296487-mishka/tags","blobs_url":"https://api.github.com/repos/AVSStorage/296487-mishka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AVSStorage/296487-mishka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AVSStorage/296487-mishka/git/refs{/sha}","trees_url":"https://api.github.com/repos/AVSStorage/296487-mishka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AVSStorage/296487-mishka/statuses/{sha}","languages_url":"https://api.github.com/repos/AVSStorage/296487-mishka/languages","stargazers_url":"https://api.github.com/repos/AVSStorage/296487-mishka/stargazers","contributors_url":"https://api.github.com/repos/AVSStorage/296487-mishka/contributors","subscribers_url":"https://api.github.com/repos/AVSStorage/296487-mishka/subscribers","subscription_url":"https://api.github.com/repos/AVSStorage/296487-mishka/subscription","commits_url":"https://api.github.com/repos/AVSStorage/296487-mishka/commits{/sha}","git_commits_url":"https://api.github.com/repos/AVSStorage/296487-mishka/git/commits{/sha}","comments_url":"https://api.github.com/repos/AVSStorage/296487-mishka/comments{/number}","issue_comment_url":"https://api.github.com/repos/AVSStorage/296487-mishka/issues/comments{/number}","contents_url":"https://api.github.com/repos/AVSStorage/296487-mishka/contents/{+path}","compare_url":"https://api.github.com/repos/AVSStorage/296487-mishka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AVSStorage/296487-mishka/merges","archive_url":"https://api.github.com/repos/AVSStorage/296487-mishka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AVSStorage/296487-mishka/downloads","issues_url":"https://api.github.com/repos/AVSStorage/296487-mishka/issues{/number}","pulls_url":"https://api.github.com/repos/AVSStorage/296487-mishka/pulls{/number}","milestones_url":"https://api.github.com/repos/AVSStorage/296487-mishka/milestones{/number}","notifications_url":"https://api.github.com/repos/AVSStorage/296487-mishka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AVSStorage/296487-mishka/labels{/name}","releases_url":"https://api.github.com/repos/AVSStorage/296487-mishka/releases{/id}","deployments_url":"https://api.github.com/repos/AVSStorage/296487-mishka/deployments","created_at":"2018-01-16T16:54:46Z","updated_at":"2018-01-16T16:54:48Z","pushed_at":"2018-02-08T23:41:28Z","git_url":"git://github.com/AVSStorage/296487-mishka.git","ssh_url":"[email protected]:AVSStorage/296487-mishka.git","clone_url":"https://github.com/AVSStorage/296487-mishka.git","svn_url":"https://github.com/AVSStorage/296487-mishka","homepage":null,"size":438,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"htmlacademy-adaptive:master","ref":"master","sha":"ca88cb5a9d840f306d02d47371ae36f0d8aed530","user":{"login":"htmlacademy-adaptive","id":9918669,"avatar_url":"https://avatars0.githubusercontent.com/u/9918669?v=4","gravatar_id":"","url":"https://api.github.com/users/htmlacademy-adaptive","html_url":"https://github.com/htmlacademy-adaptive","followers_url":"https://api.github.com/users/htmlacademy-adaptive/followers","following_url":"https://api.github.com/users/htmlacademy-adaptive/following{/other_user}","gists_url":"https://api.github.com/users/htmlacademy-adaptive/gists{/gist_id}","starred_url":"https://api.github.com/users/htmlacademy-adaptive/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/htmlacademy-adaptive/subscriptions","organizations_url":"https://api.github.com/users/htmlacademy-adaptive/orgs","repos_url":"https://api.github.com/users/htmlacademy-adaptive/repos","events_url":"https://api.github.com/users/htmlacademy-adaptive/events{/privacy}","received_events_url":"https://api.github.com/users/htmlacademy-adaptive/received_events","type":"Organization","site_admin":false},"repo":{"id":117594041,"name":"296487-mishka","full_name":"htmlacademy-adaptive/296487-mishka","owner":{"login":"htmlacademy-adaptive","id":9918669,"avatar_url":"https://avatars0.githubusercontent.com/u/9918669?v=4","gravatar_id":"","url":"https://api.github.com/users/htmlacademy-adaptive","html_url":"https://github.com/htmlacademy-adaptive","followers_url":"https://api.github.com/users/htmlacademy-adaptive/followers","following_url":"https://api.github.com/users/htmlacademy-adaptive/following{/other_user}","gists_url":"https://api.github.com/users/htmlacademy-adaptive/gists{/gist_id}","starred_url":"https://api.github.com/users/htmlacademy-adaptive/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/htmlacademy-adaptive/subscriptions","organizations_url":"https://api.github.com/users/htmlacademy-adaptive/orgs","repos_url":"https://api.github.com/users/htmlacademy-adaptive/repos","events_url":"https://api.github.com/users/htmlacademy-adaptive/events{/privacy}","received_events_url":"https://api.github.com/users/htmlacademy-adaptive/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/htmlacademy-adaptive/296487-mishka","description":"Алиса Смирнова","fork":false,"url":"https://api.github.com/repos/htmlacademy-adaptive/296487-mishka","forks_url":"https://api.github.com/repos/htmlacademy-adaptive/296487-mishka/forks","keys_url":"https://api.github.com/repos/htmlacademy-adaptive/296487-mishka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/htmlacademy-adaptive/296487-mishka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/htmlacademy-adaptive/296487-mishka/teams","hooks_url":"https://api.github.com/repos/htmlacademy-adaptive/296487-mishka/hooks","issue_events_url":"https://api.github.com/repos/htmlacademy-adaptive/296487-mishka/issues/events{/number}","events_url":"https://api.github.com/repos/htmlacademy-adaptive/296487-mishka/events","assignees_url":"https://api.github.com/repos/htmlacademy-adaptive/296487-mishka/assignees{/user}","branches_url":"https://api.github.com/repos/htmlacademy-adaptive/296487-mishka/branches{/branch}","tags_url":"https://api.github.com/repos/htmlacademy-adaptive/296487-mishka/tags","blobs_url":"https://api.github.com/repos/htmlacademy-adaptive/296487-mishka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/htmlacademy-adaptive/296487-mishka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/htmlacademy-adaptive/296487-mishka/git/refs{/sha}","trees_url":"https://api.github.com/repos/htmlacademy-adaptive/296487-mishka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/htmlacademy-adaptive/296487-mishka/statuses/{sha}","languages_url":"https://api.github.com/repos/htmlacademy-adaptive/296487-mishka/languages","stargazers_url":"https://api.github.com/repos/htmlacademy-adaptive/296487-mishka/stargazers","contributors_url":"https://api.github.com/repos/htmlacademy-adaptive/296487-mishka/contributors","subscribers_url":"https://api.github.com/repos/htmlacademy-adaptive/296487-mishka/subscribers","subscription_url":"https://api.github.com/repos/htmlacademy-adaptive/296487-mishka/subscription","commits_url":"https://api.github.com/repos/htmlacademy-adaptive/296487-mishka/commits{/sha}","git_commits_url":"https://api.github.com/repos/htmlacademy-adaptive/296487-mishka/git/commits{/sha}","comments_url":"https://api.github.com/repos/htmlacademy-adaptive/296487-mishka/comments{/number}","issue_comment_url":"https://api.github.com/repos/htmlacademy-adaptive/296487-mishka/issues/comments{/number}","contents_url":"https://api.github.com/repos/htmlacademy-adaptive/296487-mishka/contents/{+path}","compare_url":"https://api.github.com/repos/htmlacademy-adaptive/296487-mishka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/htmlacademy-adaptive/296487-mishka/merges","archive_url":"https://api.github.com/repos/htmlacademy-adaptive/296487-mishka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/htmlacademy-adaptive/296487-mishka/downloads","issues_url":"https://api.github.com/repos/htmlacademy-adaptive/296487-mishka/issues{/number}","pulls_url":"https://api.github.com/repos/htmlacademy-adaptive/296487-mishka/pulls{/number}","milestones_url":"https://api.github.com/repos/htmlacademy-adaptive/296487-mishka/milestones{/number}","notifications_url":"https://api.github.com/repos/htmlacademy-adaptive/296487-mishka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/htmlacademy-adaptive/296487-mishka/labels{/name}","releases_url":"https://api.github.com/repos/htmlacademy-adaptive/296487-mishka/releases{/id}","deployments_url":"https://api.github.com/repos/htmlacademy-adaptive/296487-mishka/deployments","created_at":"2018-01-15T20:50:14Z","updated_at":"2018-01-16T17:27:53Z","pushed_at":"2018-02-08T23:46:42Z","git_url":"git://github.com/htmlacademy-adaptive/296487-mishka.git","ssh_url":"[email protected]:htmlacademy-adaptive/296487-mishka.git","clone_url":"https://github.com/htmlacademy-adaptive/296487-mishka.git","svn_url":"https://github.com/htmlacademy-adaptive/296487-mishka","homepage":"https://github.com/AVSStorage/296487-mishka","size":454,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":true,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/htmlacademy-adaptive/296487-mishka/pulls/10"},"html":{"href":"https://github.com/htmlacademy-adaptive/296487-mishka/pull/10"},"issue":{"href":"https://api.github.com/repos/htmlacademy-adaptive/296487-mishka/issues/10"},"comments":{"href":"https://api.github.com/repos/htmlacademy-adaptive/296487-mishka/issues/10/comments"},"review_comments":{"href":"https://api.github.com/repos/htmlacademy-adaptive/296487-mishka/pulls/10/comments"},"review_comment":{"href":"https://api.github.com/repos/htmlacademy-adaptive/296487-mishka/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/htmlacademy-adaptive/296487-mishka/pulls/10/commits"},"statuses":{"href":"https://api.github.com/repos/htmlacademy-adaptive/296487-mishka/statuses/633189998d8a1cc3338884148ce8cdb35e030444"}},"author_association":"CONTRIBUTOR"}} | {
"id": 117594041,
"name": "htmlacademy-adaptive/296487-mishka",
"url": "https://api.github.com/repos/htmlacademy-adaptive/296487-mishka"
} | {
"id": 18405633,
"login": "artemka107",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/18405633?",
"url": "https://api.github.com/users/artemka107"
} | {
"id": 9918669,
"login": "htmlacademy-adaptive",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9918669?",
"url": "https://api.github.com/orgs/htmlacademy-adaptive"
} | 2018-02-10T11:58:26 | 7226628953 | {"actor":{"display_login":"artemka107"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/nodejs/modules/pulls/comments/169378301","pull_request_review_id":97895028,"id":169378301,"diff_hunk":"@@ -0,0 +1,78 @@\n+# Preface: Design Principles\n+\n+These are a list of commitments that can be used to define reasons for goals existing.\n+\n+* We are committed to shipping ES Modules (ESM)\n+* We are committed to ESM being first class in Node.js\n+* We are committed to having the Node.js and Web platform as first class runtimes for modules.\n+* Modules installed though a package manager should be able to run after installation without requiring a [preprocessing step](#goal-define-preprocessing-step).\n+* We are committed to not breaking our existing ecosystem for modules\n+* We are committed to providing APIs or conventions such that users will be able to use both CommonJS (CJS) and ESM with support for both workflows.\n+* We are commited to having security be a primary concern for ESM in Node.js.\n+* We are commited to having performance be a primary concern for ESM in Node.js.\n+\n+# Goals\n+\n+1. Enable use of ESM in Node without requiring a flag\n+2. Have files be unable to collide between module systems\n+3. Define a path to write code that runs in both Node and the Browser without a preprocessing step\n+ 1. <a name=\"goal-define-preprocessing-step\"></a>Define what a preprocessing step is\n+ 2. A subset of functionality that is compatible between environments, not requiring either environment implement all features of the other\n+4. Define a path to write libraries that support being used by both\n+ * Node versions supporting ESM\n+ * Node versions that do not support ESM\n+5. Be standards compliant in the nature of our loading of ESM\n+ 1. Contextual module APIs exposed to ESM by default will be placed under `import.meta.*`. This does not relate to per Realm globals nor module specifier resolution.\n+6. Support developer centric workflows for:\n+ 1. Intercepting dependencies and replacing them\n+ 2. Application Performance Monitoring (APM) integration\n+ 3. Multiple distributions of both ESM and CJS in the same package\n+ 4. Creation of userland module systems (JSDOM)\n+ 5. Incremental code base migration from CJS to ESM by migrating individual files\n+7. 100% backwards compatibility with existing CJS code bases if left unchanged\n+8. Provide a path to have singleton references that can be obtained in both module systems\n+\n+# Non-Goals\n+\n+1. Use `.js` file extension for both CJS and ESM without a disambiguation mechanism\n+ * e.g. `require` falling back to CJS when it is unsure about the format of a resolved path\n+2. Interoperability of Module formats with environments that do not support Module formats that Node seeks to support\n+3. Forwards compatibility support for the transition of existing packages from CJS to ESM\n+ 1. loading unknown file formats and `.js` as CJS\n+ 2. usage of `require.extensions`\n+ 3. usage of `require.cache`\n+ 4. usage of `NODE_PATH`, `~/.node_libraries`, `~/.node_modules`, and `$PREFIX/lib/node`\n+4. Standardizing and implementing APIs that explicitly are tailored to APM\n+5. Standardizing and implementing APIs that explicitly are tailored to testing libraries\n+6. Standardizing and implementing APIs that explicitly are tailored to transpilers\n+7. Standardizing and implementing APIs that explicitly are tailored to browser stacks\n+8. Standardizing and implementing APIs that explicitly are tailored to package managers\n+9. Modification of existing `require` behavior\n+ * Modification of implementation details is allowed only if it would be backwards compatible\n+\n+# Goals that are not expected for the first iteration\n+\n+1. 100% stable Loader APIs\n+ * Any Loader APIs shipped must have a forward compatible approach towards their usage, such as providing a feature dection mechanism or versioned API.\n+2. Treatment of `.js` file extension as ESM by default\n+3. Support for the following URL schemes: `data:`, `blob:`, and `https:`\n+\n+# Direction\n+\n+* Build upon the existing work in Node that has designs around using `.mjs`\n+* Enable usage of `.js` for ESM through compatible means of out of band data\n+* Build upon the existing Loader hooks to aid usability\n+ * Creation of in memory Module records","path":"GOALS.md","position":65,"original_position":65,"commit_id":"d2fd3a7249ae2a6b3e4fe259b4fff991eb920604","original_commit_id":"d2fd3a7249ae2a6b3e4fe259b4fff991eb920604","user":{"login":"bmeck","id":234659,"avatar_url":"https://avatars1.githubusercontent.com/u/234659?v=4","gravatar_id":"","url":"https://api.github.com/users/bmeck","html_url":"https://github.com/bmeck","followers_url":"https://api.github.com/users/bmeck/followers","following_url":"https://api.github.com/users/bmeck/following{/other_user}","gists_url":"https://api.github.com/users/bmeck/gists{/gist_id}","starred_url":"https://api.github.com/users/bmeck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmeck/subscriptions","organizations_url":"https://api.github.com/users/bmeck/orgs","repos_url":"https://api.github.com/users/bmeck/repos","events_url":"https://api.github.com/users/bmeck/events{/privacy}","received_events_url":"https://api.github.com/users/bmeck/received_events","type":"User","site_admin":false},"body":"This is the current direction.","created_at":"2018-02-20T16:31:19Z","updated_at":"2018-02-20T16:31:19Z","html_url":"https://github.com/nodejs/modules/pull/23#discussion_r169378301","pull_request_url":"https://api.github.com/repos/nodejs/modules/pulls/23","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/nodejs/modules/pulls/comments/169378301"},"html":{"href":"https://github.com/nodejs/modules/pull/23#discussion_r169378301"},"pull_request":{"href":"https://api.github.com/repos/nodejs/modules/pulls/23"}},"in_reply_to_id":169378019},"pull_request":{"url":"https://api.github.com/repos/nodejs/modules/pulls/23","id":168053244,"html_url":"https://github.com/nodejs/modules/pull/23","diff_url":"https://github.com/nodejs/modules/pull/23.diff","patch_url":"https://github.com/nodejs/modules/pull/23.patch","issue_url":"https://api.github.com/repos/nodejs/modules/issues/23","number":23,"state":"open","locked":false,"title":"initial GOALS declaration","user":{"login":"bmeck","id":234659,"avatar_url":"https://avatars1.githubusercontent.com/u/234659?v=4","gravatar_id":"","url":"https://api.github.com/users/bmeck","html_url":"https://github.com/bmeck","followers_url":"https://api.github.com/users/bmeck/followers","following_url":"https://api.github.com/users/bmeck/following{/other_user}","gists_url":"https://api.github.com/users/bmeck/gists{/gist_id}","starred_url":"https://api.github.com/users/bmeck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmeck/subscriptions","organizations_url":"https://api.github.com/users/bmeck/orgs","repos_url":"https://api.github.com/users/bmeck/repos","events_url":"https://api.github.com/users/bmeck/events{/privacy}","received_events_url":"https://api.github.com/users/bmeck/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-02-08T18:36:03Z","updated_at":"2018-02-20T16:31:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"54df27ce51a29387198760c3adf2a9a2fb7ed0ca","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":831666985,"url":"https://api.github.com/repos/nodejs/modules/labels/modules-agenda","name":"modules-agenda","color":"0e8a16","default":false},{"id":831668908,"url":"https://api.github.com/repos/nodejs/modules/labels/roadmap","name":"roadmap","color":"3269a3","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/modules/pulls/23/commits","review_comments_url":"https://api.github.com/repos/nodejs/modules/pulls/23/comments","review_comment_url":"https://api.github.com/repos/nodejs/modules/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/modules/issues/23/comments","statuses_url":"https://api.github.com/repos/nodejs/modules/statuses/d2fd3a7249ae2a6b3e4fe259b4fff991eb920604","head":{"label":"bmeck:goals","ref":"goals","sha":"d2fd3a7249ae2a6b3e4fe259b4fff991eb920604","user":{"login":"bmeck","id":234659,"avatar_url":"https://avatars1.githubusercontent.com/u/234659?v=4","gravatar_id":"","url":"https://api.github.com/users/bmeck","html_url":"https://github.com/bmeck","followers_url":"https://api.github.com/users/bmeck/followers","following_url":"https://api.github.com/users/bmeck/following{/other_user}","gists_url":"https://api.github.com/users/bmeck/gists{/gist_id}","starred_url":"https://api.github.com/users/bmeck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmeck/subscriptions","organizations_url":"https://api.github.com/users/bmeck/orgs","repos_url":"https://api.github.com/users/bmeck/repos","events_url":"https://api.github.com/users/bmeck/events{/privacy}","received_events_url":"https://api.github.com/users/bmeck/received_events","type":"User","site_admin":false},"repo":{"id":120800101,"name":"modules","full_name":"bmeck/modules","owner":{"login":"bmeck","id":234659,"avatar_url":"https://avatars1.githubusercontent.com/u/234659?v=4","gravatar_id":"","url":"https://api.github.com/users/bmeck","html_url":"https://github.com/bmeck","followers_url":"https://api.github.com/users/bmeck/followers","following_url":"https://api.github.com/users/bmeck/following{/other_user}","gists_url":"https://api.github.com/users/bmeck/gists{/gist_id}","starred_url":"https://api.github.com/users/bmeck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmeck/subscriptions","organizations_url":"https://api.github.com/users/bmeck/orgs","repos_url":"https://api.github.com/users/bmeck/repos","events_url":"https://api.github.com/users/bmeck/events{/privacy}","received_events_url":"https://api.github.com/users/bmeck/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bmeck/modules","description":"Node.js Foundation Modules Team","fork":true,"url":"https://api.github.com/repos/bmeck/modules","forks_url":"https://api.github.com/repos/bmeck/modules/forks","keys_url":"https://api.github.com/repos/bmeck/modules/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bmeck/modules/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bmeck/modules/teams","hooks_url":"https://api.github.com/repos/bmeck/modules/hooks","issue_events_url":"https://api.github.com/repos/bmeck/modules/issues/events{/number}","events_url":"https://api.github.com/repos/bmeck/modules/events","assignees_url":"https://api.github.com/repos/bmeck/modules/assignees{/user}","branches_url":"https://api.github.com/repos/bmeck/modules/branches{/branch}","tags_url":"https://api.github.com/repos/bmeck/modules/tags","blobs_url":"https://api.github.com/repos/bmeck/modules/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bmeck/modules/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bmeck/modules/git/refs{/sha}","trees_url":"https://api.github.com/repos/bmeck/modules/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bmeck/modules/statuses/{sha}","languages_url":"https://api.github.com/repos/bmeck/modules/languages","stargazers_url":"https://api.github.com/repos/bmeck/modules/stargazers","contributors_url":"https://api.github.com/repos/bmeck/modules/contributors","subscribers_url":"https://api.github.com/repos/bmeck/modules/subscribers","subscription_url":"https://api.github.com/repos/bmeck/modules/subscription","commits_url":"https://api.github.com/repos/bmeck/modules/commits{/sha}","git_commits_url":"https://api.github.com/repos/bmeck/modules/git/commits{/sha}","comments_url":"https://api.github.com/repos/bmeck/modules/comments{/number}","issue_comment_url":"https://api.github.com/repos/bmeck/modules/issues/comments{/number}","contents_url":"https://api.github.com/repos/bmeck/modules/contents/{+path}","compare_url":"https://api.github.com/repos/bmeck/modules/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bmeck/modules/merges","archive_url":"https://api.github.com/repos/bmeck/modules/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bmeck/modules/downloads","issues_url":"https://api.github.com/repos/bmeck/modules/issues{/number}","pulls_url":"https://api.github.com/repos/bmeck/modules/pulls{/number}","milestones_url":"https://api.github.com/repos/bmeck/modules/milestones{/number}","notifications_url":"https://api.github.com/repos/bmeck/modules/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bmeck/modules/labels{/name}","releases_url":"https://api.github.com/repos/bmeck/modules/releases{/id}","deployments_url":"https://api.github.com/repos/bmeck/modules/deployments","created_at":"2018-02-08T18:23:23Z","updated_at":"2018-02-08T15:55:07Z","pushed_at":"2018-02-20T14:44:49Z","git_url":"git://github.com/bmeck/modules.git","ssh_url":"[email protected]:bmeck/modules.git","clone_url":"https://github.com/bmeck/modules.git","svn_url":"https://github.com/bmeck/modules","homepage":null,"size":26,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nodejs:master","ref":"master","sha":"3620ac3c740065dd619570da037af9e4f7d52f59","user":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars3.githubusercontent.com/u/9950313?v=4","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":119901830,"name":"modules","full_name":"nodejs/modules","owner":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars3.githubusercontent.com/u/9950313?v=4","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nodejs/modules","description":"Node.js Foundation Modules Team","fork":false,"url":"https://api.github.com/repos/nodejs/modules","forks_url":"https://api.github.com/repos/nodejs/modules/forks","keys_url":"https://api.github.com/repos/nodejs/modules/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/modules/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/modules/teams","hooks_url":"https://api.github.com/repos/nodejs/modules/hooks","issue_events_url":"https://api.github.com/repos/nodejs/modules/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/modules/events","assignees_url":"https://api.github.com/repos/nodejs/modules/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/modules/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/modules/tags","blobs_url":"https://api.github.com/repos/nodejs/modules/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/modules/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/modules/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/modules/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/modules/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/modules/languages","stargazers_url":"https://api.github.com/repos/nodejs/modules/stargazers","contributors_url":"https://api.github.com/repos/nodejs/modules/contributors","subscribers_url":"https://api.github.com/repos/nodejs/modules/subscribers","subscription_url":"https://api.github.com/repos/nodejs/modules/subscription","commits_url":"https://api.github.com/repos/nodejs/modules/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/modules/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/modules/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/modules/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/modules/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/modules/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/modules/merges","archive_url":"https://api.github.com/repos/nodejs/modules/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/modules/downloads","issues_url":"https://api.github.com/repos/nodejs/modules/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/modules/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/modules/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/modules/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/modules/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/modules/releases{/id}","deployments_url":"https://api.github.com/repos/nodejs/modules/deployments","created_at":"2018-02-01T22:33:47Z","updated_at":"2018-02-20T12:51:01Z","pushed_at":"2018-02-20T14:44:51Z","git_url":"git://github.com/nodejs/modules.git","ssh_url":"[email protected]:nodejs/modules.git","clone_url":"https://github.com/nodejs/modules.git","svn_url":"https://github.com/nodejs/modules","homepage":null,"size":20,"stargazers_count":48,"watchers_count":48,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"archived":false,"open_issues_count":18,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":9,"open_issues":18,"watchers":48,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/modules/pulls/23"},"html":{"href":"https://github.com/nodejs/modules/pull/23"},"issue":{"href":"https://api.github.com/repos/nodejs/modules/issues/23"},"comments":{"href":"https://api.github.com/repos/nodejs/modules/issues/23/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/modules/pulls/23/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/modules/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/modules/pulls/23/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/modules/statuses/d2fd3a7249ae2a6b3e4fe259b4fff991eb920604"}},"author_association":"MEMBER"}} | {
"id": 119901830,
"name": "nodejs/modules",
"url": "https://api.github.com/repos/nodejs/modules"
} | {
"id": 234659,
"login": "bmeck",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/234659?",
"url": "https://api.github.com/users/bmeck"
} | {
"id": 9950313,
"login": "nodejs",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9950313?",
"url": "https://api.github.com/orgs/nodejs"
} | 2018-02-20T16:31:19 | 7270450599 | {"actor":{"display_login":"bmeck"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/nodejs/node/pulls/comments/240005216","pull_request_review_id":182944382,"id":240005216,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MDAwNTIxNg==","diff_hunk":"@@ -500,8 +514,49 @@ Interface.prototype._insertString = function(c) {\n // a hack to get the line refreshed if it's needed\n this._moveCursor(0);\n }\n+\n+ searchHistory.call(this);\n };\n \n+function appendSearchResult(result) {\n+ this.previewResult = result !== '' ?\n+ `\\u001b[90m // ${result}\\u001b[39m` : '';\n+\n+ // Cursor to left edge.\n+ cursorTo(this.output, 0);\n+ clearScreenDown(this.output);\n+\n+ this.output.write(this.reverseSearchPrompt + this.line + this.previewResult);\n+ // now move back the cursor to the original position\n+ cursorTo(this.output, this.cursor + this.reverseSearchPrompt.length);\n+}\n+\n+function searchHistory() {\n+\n+ const searchFor = (array, text) => {\n+ const result = [];\n+ for (var i = 0; i < array.length; i++)\n+ if (text.trim() !== '' && array[i].includes(text))\n+ result.push(array[i]);\n+ return result;\n+ };","path":"lib/readline.js","position":66,"original_position":66,"commit_id":"35ab75ce0b22ac059b713bc20779f1bbd7410c69","original_commit_id":"35ab75ce0b22ac059b713bc20779f1bbd7410c69","user":{"login":"BridgeAR","id":8822573,"node_id":"MDQ6VXNlcjg4MjI1NzM=","avatar_url":"https://avatars2.githubusercontent.com/u/8822573?v=4","gravatar_id":"","url":"https://api.github.com/users/BridgeAR","html_url":"https://github.com/BridgeAR","followers_url":"https://api.github.com/users/BridgeAR/followers","following_url":"https://api.github.com/users/BridgeAR/following{/other_user}","gists_url":"https://api.github.com/users/BridgeAR/gists{/gist_id}","starred_url":"https://api.github.com/users/BridgeAR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BridgeAR/subscriptions","organizations_url":"https://api.github.com/users/BridgeAR/orgs","repos_url":"https://api.github.com/users/BridgeAR/repos","events_url":"https://api.github.com/users/BridgeAR/events{/privacy}","received_events_url":"https://api.github.com/users/BridgeAR/received_events","type":"User","site_admin":false},"body":"Nit: Please move this in the outer scope. The function only has to be initialized once instead of on each `searchHistory()` call.","created_at":"2018-12-08T13:37:35Z","updated_at":"2018-12-08T13:56:36Z","html_url":"https://github.com/nodejs/node/pull/24335#discussion_r240005216","pull_request_url":"https://api.github.com/repos/nodejs/node/pulls/24335","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments/240005216"},"html":{"href":"https://github.com/nodejs/node/pull/24335#discussion_r240005216"},"pull_request":{"href":"https://api.github.com/repos/nodejs/node/pulls/24335"}}},"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/24335","id":230413452,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMwNDEzNDUy","html_url":"https://github.com/nodejs/node/pull/24335","diff_url":"https://github.com/nodejs/node/pull/24335.diff","patch_url":"https://github.com/nodejs/node/pull/24335.patch","issue_url":"https://api.github.com/repos/nodejs/node/issues/24335","number":24335,"state":"open","locked":false,"title":"repl: add reverse search to repl","user":{"login":"antsmartian","id":1241511,"node_id":"MDQ6VXNlcjEyNDE1MTE=","avatar_url":"https://avatars2.githubusercontent.com/u/1241511?v=4","gravatar_id":"","url":"https://api.github.com/users/antsmartian","html_url":"https://github.com/antsmartian","followers_url":"https://api.github.com/users/antsmartian/followers","following_url":"https://api.github.com/users/antsmartian/following{/other_user}","gists_url":"https://api.github.com/users/antsmartian/gists{/gist_id}","starred_url":"https://api.github.com/users/antsmartian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antsmartian/subscriptions","organizations_url":"https://api.github.com/users/antsmartian/orgs","repos_url":"https://api.github.com/users/antsmartian/repos","events_url":"https://api.github.com/users/antsmartian/events{/privacy}","received_events_url":"https://api.github.com/users/antsmartian/received_events","type":"User","site_admin":false},"body":"Hello Team, \r\n\r\nI wanted to add reverse search to repl:\r\n\r\n1. Reverse search is supported in linux and unix terminals. \r\n2. User can press `ctrl+r` to search their history \r\n3. When user types in text, we search through `node_repl_history` and show off the matching results. \r\n4. When user press enter we run the matching command on our `repl`. \r\n5. When more results found for a string, pressing `ctrl+r` again will navigate the search results one by one in a circular fashion (if we reach end of the search result). \r\n\r\n\r\nIt's a work in progress need tests, doc etc. \r\n\r\nInitial mode of working is ready. \r\n\r\n\r\n\r\n\r\nNeed thoughts from community on the idea. But I would love to land this on repl 😍 \r\n\r\n##### Checklist\r\n- [x] `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes\r\n- [ ] tests and/or benchmarks are included\r\n- [ ] documentation is changed or added\r\n- [ ] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines)\r\n","created_at":"2018-11-13T10:02:58Z","updated_at":"2018-12-08T13:56:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5ae46e477242640c7bfeaf6c663625e0b6ddc59d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":155435874,"node_id":"MDU6TGFiZWwxNTU0MzU4NzQ=","url":"https://api.github.com/repos/nodejs/node/labels/readline","name":"readline","color":"d4c5f9","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/node/pulls/24335/commits","review_comments_url":"https://api.github.com/repos/nodejs/node/pulls/24335/comments","review_comment_url":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/node/issues/24335/comments","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/35ab75ce0b22ac059b713bc20779f1bbd7410c69","head":{"label":"antsmartian:multiline-strip-comments","ref":"multiline-strip-comments","sha":"35ab75ce0b22ac059b713bc20779f1bbd7410c69","user":{"login":"antsmartian","id":1241511,"node_id":"MDQ6VXNlcjEyNDE1MTE=","avatar_url":"https://avatars2.githubusercontent.com/u/1241511?v=4","gravatar_id":"","url":"https://api.github.com/users/antsmartian","html_url":"https://github.com/antsmartian","followers_url":"https://api.github.com/users/antsmartian/followers","following_url":"https://api.github.com/users/antsmartian/following{/other_user}","gists_url":"https://api.github.com/users/antsmartian/gists{/gist_id}","starred_url":"https://api.github.com/users/antsmartian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antsmartian/subscriptions","organizations_url":"https://api.github.com/users/antsmartian/orgs","repos_url":"https://api.github.com/users/antsmartian/repos","events_url":"https://api.github.com/users/antsmartian/events{/privacy}","received_events_url":"https://api.github.com/users/antsmartian/received_events","type":"User","site_admin":false},"repo":{"id":140859357,"node_id":"MDEwOlJlcG9zaXRvcnkxNDA4NTkzNTc=","name":"node","full_name":"antsmartian/node","private":false,"owner":{"login":"antsmartian","id":1241511,"node_id":"MDQ6VXNlcjEyNDE1MTE=","avatar_url":"https://avatars2.githubusercontent.com/u/1241511?v=4","gravatar_id":"","url":"https://api.github.com/users/antsmartian","html_url":"https://github.com/antsmartian","followers_url":"https://api.github.com/users/antsmartian/followers","following_url":"https://api.github.com/users/antsmartian/following{/other_user}","gists_url":"https://api.github.com/users/antsmartian/gists{/gist_id}","starred_url":"https://api.github.com/users/antsmartian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antsmartian/subscriptions","organizations_url":"https://api.github.com/users/antsmartian/orgs","repos_url":"https://api.github.com/users/antsmartian/repos","events_url":"https://api.github.com/users/antsmartian/events{/privacy}","received_events_url":"https://api.github.com/users/antsmartian/received_events","type":"User","site_admin":false},"html_url":"https://github.com/antsmartian/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":true,"url":"https://api.github.com/repos/antsmartian/node","forks_url":"https://api.github.com/repos/antsmartian/node/forks","keys_url":"https://api.github.com/repos/antsmartian/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/antsmartian/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/antsmartian/node/teams","hooks_url":"https://api.github.com/repos/antsmartian/node/hooks","issue_events_url":"https://api.github.com/repos/antsmartian/node/issues/events{/number}","events_url":"https://api.github.com/repos/antsmartian/node/events","assignees_url":"https://api.github.com/repos/antsmartian/node/assignees{/user}","branches_url":"https://api.github.com/repos/antsmartian/node/branches{/branch}","tags_url":"https://api.github.com/repos/antsmartian/node/tags","blobs_url":"https://api.github.com/repos/antsmartian/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/antsmartian/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/antsmartian/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/antsmartian/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/antsmartian/node/statuses/{sha}","languages_url":"https://api.github.com/repos/antsmartian/node/languages","stargazers_url":"https://api.github.com/repos/antsmartian/node/stargazers","contributors_url":"https://api.github.com/repos/antsmartian/node/contributors","subscribers_url":"https://api.github.com/repos/antsmartian/node/subscribers","subscription_url":"https://api.github.com/repos/antsmartian/node/subscription","commits_url":"https://api.github.com/repos/antsmartian/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/antsmartian/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/antsmartian/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/antsmartian/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/antsmartian/node/contents/{+path}","compare_url":"https://api.github.com/repos/antsmartian/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/antsmartian/node/merges","archive_url":"https://api.github.com/repos/antsmartian/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/antsmartian/node/downloads","issues_url":"https://api.github.com/repos/antsmartian/node/issues{/number}","pulls_url":"https://api.github.com/repos/antsmartian/node/pulls{/number}","milestones_url":"https://api.github.com/repos/antsmartian/node/milestones{/number}","notifications_url":"https://api.github.com/repos/antsmartian/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/antsmartian/node/labels{/name}","releases_url":"https://api.github.com/repos/antsmartian/node/releases{/id}","deployments_url":"https://api.github.com/repos/antsmartian/node/deployments","created_at":"2018-07-13T14:49:10Z","updated_at":"2018-07-13T14:49:34Z","pushed_at":"2018-12-08T07:52:35Z","git_url":"git://github.com/antsmartian/node.git","ssh_url":"[email protected]:antsmartian/node.git","clone_url":"https://github.com/antsmartian/node.git","svn_url":"https://github.com/antsmartian/node","homepage":"https://nodejs.org","size":433465,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nodejs:master","ref":"master","sha":"b5e9086c5a6553d0d7ad6006ac83ed881c35fcdd","user":{"login":"nodejs","id":9950313,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk5NTAzMTM=","avatar_url":"https://avatars3.githubusercontent.com/u/9950313?v=4","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"node_id":"MDEwOlJlcG9zaXRvcnkyNzE5Mzc3OQ==","name":"node","full_name":"nodejs/node","private":false,"owner":{"login":"nodejs","id":9950313,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk5NTAzMTM=","avatar_url":"https://avatars3.githubusercontent.com/u/9950313?v=4","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/nodejs/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":false,"url":"https://api.github.com/repos/nodejs/node","forks_url":"https://api.github.com/repos/nodejs/node/forks","keys_url":"https://api.github.com/repos/nodejs/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/node/teams","hooks_url":"https://api.github.com/repos/nodejs/node/hooks","issue_events_url":"https://api.github.com/repos/nodejs/node/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/node/events","assignees_url":"https://api.github.com/repos/nodejs/node/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/node/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/node/tags","blobs_url":"https://api.github.com/repos/nodejs/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/node/languages","stargazers_url":"https://api.github.com/repos/nodejs/node/stargazers","contributors_url":"https://api.github.com/repos/nodejs/node/contributors","subscribers_url":"https://api.github.com/repos/nodejs/node/subscribers","subscription_url":"https://api.github.com/repos/nodejs/node/subscription","commits_url":"https://api.github.com/repos/nodejs/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/node/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/node/merges","archive_url":"https://api.github.com/repos/nodejs/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/node/downloads","issues_url":"https://api.github.com/repos/nodejs/node/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/node/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/node/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/node/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/node/releases{/id}","deployments_url":"https://api.github.com/repos/nodejs/node/deployments","created_at":"2014-11-26T19:57:11Z","updated_at":"2018-12-08T13:09:41Z","pushed_at":"2018-12-08T13:51:37Z","git_url":"git://github.com/nodejs/node.git","ssh_url":"[email protected]:nodejs/node.git","clone_url":"https://github.com/nodejs/node.git","svn_url":"https://github.com/nodejs/node","homepage":"https://nodejs.org","size":440798,"stargazers_count":56204,"watchers_count":56204,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":12398,"mirror_url":null,"archived":false,"open_issues_count":720,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":12398,"open_issues":720,"watchers":56204,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/24335"},"html":{"href":"https://github.com/nodejs/node/pull/24335"},"issue":{"href":"https://api.github.com/repos/nodejs/node/issues/24335"},"comments":{"href":"https://api.github.com/repos/nodejs/node/issues/24335/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/node/pulls/24335/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/node/pulls/24335/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/node/statuses/35ab75ce0b22ac059b713bc20779f1bbd7410c69"}},"author_association":"CONTRIBUTOR"}} | {
"id": 27193779,
"name": "nodejs/node",
"url": "https://api.github.com/repos/nodejs/node"
} | {
"id": 8822573,
"login": "BridgeAR",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/8822573?",
"url": "https://api.github.com/users/BridgeAR"
} | {
"id": 9950313,
"login": "nodejs",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9950313?",
"url": "https://api.github.com/orgs/nodejs"
} | 2018-12-08T13:37:35 | 8720558576 | {"actor":{"display_login":"BridgeAR"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/nodejs/modules/pulls/comments/172719373","pull_request_review_id":101784504,"id":172719373,"diff_hunk":"@@ -0,0 +1,34 @@\n+## The Module Manifesto\n+\n+We the undersigned agree on the the following,\n+\n+* Getting modules \"right\" is one of the biggest existential threats to JavaScript\n+* This affects a large number of people on this planet (and future planets), with varying interests including but not limited to:\n+ - web applications\n+ - serverside applications and services\n+ - command line interfaces\n+ - libraries and frameworks\n+ - transpilers\n+ - robots\n+ - art and music\n+* Getting modules \"right\" is hard because of these varying interests\n+* Creating a good developer experience is the number one priority\n+* The aim will be to not compromise the Node.js Developer Experience, but we recognize that may be necessary to improve the health of the JavaScript ecosystem\n+* While compromise is neccessary, it is important to recognize when Node.js needs to lead and attempt to influence change at an industry level\n+* The closer the Node.js and Web platform remain the better the developer experience will be\n+\n+* The Node.js implementation of ESModules must have the following features:\n+ - Compliant to ecma262. It is important to follow the standard. If we need changes in the standard we should attempt to accomplish them at tc39.\n+ - Interoperability. It is important to be able to utilize ESModule code from CommonJS and vice versa.\n+ - Hooks. It is important to be able to have hooks into the lifecycle of a Module.\n+ - Multiple Goals. e.g. wasm. It is important that our implementation scales to any number of future goals.\n+* Packages written with the Node.js implementation of ESModules must have the following features.\n+ - Dual mode. It is important that a single package should be capable of being loaded as both ESM and CJS. This does not have to be the default.","path":"MANIFESTO.md","position":26,"original_position":26,"commit_id":"1e83a20f88b6efa352be1090a3d91e7d21196fbb","original_commit_id":"8f692bcc9f10f60611e1916f8c4d477c8c397ff7","user":{"login":"ljharb","id":45469,"avatar_url":"https://avatars1.githubusercontent.com/u/45469?v=4","gravatar_id":"","url":"https://api.github.com/users/ljharb","html_url":"https://github.com/ljharb","followers_url":"https://api.github.com/users/ljharb/followers","following_url":"https://api.github.com/users/ljharb/following{/other_user}","gists_url":"https://api.github.com/users/ljharb/gists{/gist_id}","starred_url":"https://api.github.com/users/ljharb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ljharb/subscriptions","organizations_url":"https://api.github.com/users/ljharb/orgs","repos_url":"https://api.github.com/users/ljharb/repos","events_url":"https://api.github.com/users/ljharb/events{/privacy}","received_events_url":"https://api.github.com/users/ljharb/received_events","type":"User","site_admin":false},"body":"+1, it should be \"multi mode\".","created_at":"2018-03-07T01:47:34Z","updated_at":"2018-03-07T01:47:34Z","html_url":"https://github.com/nodejs/modules/pull/45#discussion_r172719373","pull_request_url":"https://api.github.com/repos/nodejs/modules/pulls/45","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/nodejs/modules/pulls/comments/172719373"},"html":{"href":"https://github.com/nodejs/modules/pull/45#discussion_r172719373"},"pull_request":{"href":"https://api.github.com/repos/nodejs/modules/pulls/45"}},"in_reply_to_id":172691707},"pull_request":{"url":"https://api.github.com/repos/nodejs/modules/pulls/45","id":173284108,"html_url":"https://github.com/nodejs/modules/pull/45","diff_url":"https://github.com/nodejs/modules/pull/45.diff","patch_url":"https://github.com/nodejs/modules/pull/45.patch","issue_url":"https://api.github.com/repos/nodejs/modules/issues/45","number":45,"state":"open","locked":false,"title":"doc: add MANIFESTO.md","user":{"login":"MylesBorins","id":498775,"avatar_url":"https://avatars1.githubusercontent.com/u/498775?v=4","gravatar_id":"","url":"https://api.github.com/users/MylesBorins","html_url":"https://github.com/MylesBorins","followers_url":"https://api.github.com/users/MylesBorins/followers","following_url":"https://api.github.com/users/MylesBorins/following{/other_user}","gists_url":"https://api.github.com/users/MylesBorins/gists{/gist_id}","starred_url":"https://api.github.com/users/MylesBorins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MylesBorins/subscriptions","organizations_url":"https://api.github.com/users/MylesBorins/orgs","repos_url":"https://api.github.com/users/MylesBorins/repos","events_url":"https://api.github.com/users/MylesBorins/events{/privacy}","received_events_url":"https://api.github.com/users/MylesBorins/received_events","type":"User","site_admin":false},"body":"I wanted to take a shot at finding some core principles that our\r\ngroup can rally behind. Please feel free to push a commit to add\r\nyour name to the signatories. Also please comment if anything doesn't\r\nwork for you.","created_at":"2018-03-06T21:19:24Z","updated_at":"2018-03-07T01:47:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bc439b5f575a471355cc1ddd4d1130c8e854febe","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/modules/pulls/45/commits","review_comments_url":"https://api.github.com/repos/nodejs/modules/pulls/45/comments","review_comment_url":"https://api.github.com/repos/nodejs/modules/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/modules/issues/45/comments","statuses_url":"https://api.github.com/repos/nodejs/modules/statuses/1e83a20f88b6efa352be1090a3d91e7d21196fbb","head":{"label":"MylesBorins:manifesto","ref":"manifesto","sha":"1e83a20f88b6efa352be1090a3d91e7d21196fbb","user":{"login":"MylesBorins","id":498775,"avatar_url":"https://avatars1.githubusercontent.com/u/498775?v=4","gravatar_id":"","url":"https://api.github.com/users/MylesBorins","html_url":"https://github.com/MylesBorins","followers_url":"https://api.github.com/users/MylesBorins/followers","following_url":"https://api.github.com/users/MylesBorins/following{/other_user}","gists_url":"https://api.github.com/users/MylesBorins/gists{/gist_id}","starred_url":"https://api.github.com/users/MylesBorins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MylesBorins/subscriptions","organizations_url":"https://api.github.com/users/MylesBorins/orgs","repos_url":"https://api.github.com/users/MylesBorins/repos","events_url":"https://api.github.com/users/MylesBorins/events{/privacy}","received_events_url":"https://api.github.com/users/MylesBorins/received_events","type":"User","site_admin":false},"repo":{"id":120816462,"name":"modules","full_name":"MylesBorins/modules","owner":{"login":"MylesBorins","id":498775,"avatar_url":"https://avatars1.githubusercontent.com/u/498775?v=4","gravatar_id":"","url":"https://api.github.com/users/MylesBorins","html_url":"https://github.com/MylesBorins","followers_url":"https://api.github.com/users/MylesBorins/followers","following_url":"https://api.github.com/users/MylesBorins/following{/other_user}","gists_url":"https://api.github.com/users/MylesBorins/gists{/gist_id}","starred_url":"https://api.github.com/users/MylesBorins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MylesBorins/subscriptions","organizations_url":"https://api.github.com/users/MylesBorins/orgs","repos_url":"https://api.github.com/users/MylesBorins/repos","events_url":"https://api.github.com/users/MylesBorins/events{/privacy}","received_events_url":"https://api.github.com/users/MylesBorins/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MylesBorins/modules","description":"Node.js Foundation Modules Team","fork":true,"url":"https://api.github.com/repos/MylesBorins/modules","forks_url":"https://api.github.com/repos/MylesBorins/modules/forks","keys_url":"https://api.github.com/repos/MylesBorins/modules/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MylesBorins/modules/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MylesBorins/modules/teams","hooks_url":"https://api.github.com/repos/MylesBorins/modules/hooks","issue_events_url":"https://api.github.com/repos/MylesBorins/modules/issues/events{/number}","events_url":"https://api.github.com/repos/MylesBorins/modules/events","assignees_url":"https://api.github.com/repos/MylesBorins/modules/assignees{/user}","branches_url":"https://api.github.com/repos/MylesBorins/modules/branches{/branch}","tags_url":"https://api.github.com/repos/MylesBorins/modules/tags","blobs_url":"https://api.github.com/repos/MylesBorins/modules/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MylesBorins/modules/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MylesBorins/modules/git/refs{/sha}","trees_url":"https://api.github.com/repos/MylesBorins/modules/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MylesBorins/modules/statuses/{sha}","languages_url":"https://api.github.com/repos/MylesBorins/modules/languages","stargazers_url":"https://api.github.com/repos/MylesBorins/modules/stargazers","contributors_url":"https://api.github.com/repos/MylesBorins/modules/contributors","subscribers_url":"https://api.github.com/repos/MylesBorins/modules/subscribers","subscription_url":"https://api.github.com/repos/MylesBorins/modules/subscription","commits_url":"https://api.github.com/repos/MylesBorins/modules/commits{/sha}","git_commits_url":"https://api.github.com/repos/MylesBorins/modules/git/commits{/sha}","comments_url":"https://api.github.com/repos/MylesBorins/modules/comments{/number}","issue_comment_url":"https://api.github.com/repos/MylesBorins/modules/issues/comments{/number}","contents_url":"https://api.github.com/repos/MylesBorins/modules/contents/{+path}","compare_url":"https://api.github.com/repos/MylesBorins/modules/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MylesBorins/modules/merges","archive_url":"https://api.github.com/repos/MylesBorins/modules/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MylesBorins/modules/downloads","issues_url":"https://api.github.com/repos/MylesBorins/modules/issues{/number}","pulls_url":"https://api.github.com/repos/MylesBorins/modules/pulls{/number}","milestones_url":"https://api.github.com/repos/MylesBorins/modules/milestones{/number}","notifications_url":"https://api.github.com/repos/MylesBorins/modules/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MylesBorins/modules/labels{/name}","releases_url":"https://api.github.com/repos/MylesBorins/modules/releases{/id}","deployments_url":"https://api.github.com/repos/MylesBorins/modules/deployments","created_at":"2018-02-08T20:51:05Z","updated_at":"2018-02-08T15:55:07Z","pushed_at":"2018-03-06T23:11:35Z","git_url":"git://github.com/MylesBorins/modules.git","ssh_url":"[email protected]:MylesBorins/modules.git","clone_url":"https://github.com/MylesBorins/modules.git","svn_url":"https://github.com/MylesBorins/modules","homepage":null,"size":38,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nodejs:master","ref":"master","sha":"198b66a77c977cdd4a5d65142cdab2a0fe5ce87f","user":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars3.githubusercontent.com/u/9950313?v=4","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":119901830,"name":"modules","full_name":"nodejs/modules","owner":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars3.githubusercontent.com/u/9950313?v=4","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nodejs/modules","description":"Node.js Foundation Modules Team","fork":false,"url":"https://api.github.com/repos/nodejs/modules","forks_url":"https://api.github.com/repos/nodejs/modules/forks","keys_url":"https://api.github.com/repos/nodejs/modules/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/modules/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/modules/teams","hooks_url":"https://api.github.com/repos/nodejs/modules/hooks","issue_events_url":"https://api.github.com/repos/nodejs/modules/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/modules/events","assignees_url":"https://api.github.com/repos/nodejs/modules/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/modules/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/modules/tags","blobs_url":"https://api.github.com/repos/nodejs/modules/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/modules/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/modules/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/modules/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/modules/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/modules/languages","stargazers_url":"https://api.github.com/repos/nodejs/modules/stargazers","contributors_url":"https://api.github.com/repos/nodejs/modules/contributors","subscribers_url":"https://api.github.com/repos/nodejs/modules/subscribers","subscription_url":"https://api.github.com/repos/nodejs/modules/subscription","commits_url":"https://api.github.com/repos/nodejs/modules/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/modules/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/modules/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/modules/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/modules/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/modules/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/modules/merges","archive_url":"https://api.github.com/repos/nodejs/modules/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/modules/downloads","issues_url":"https://api.github.com/repos/nodejs/modules/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/modules/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/modules/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/modules/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/modules/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/modules/releases{/id}","deployments_url":"https://api.github.com/repos/nodejs/modules/deployments","created_at":"2018-02-01T22:33:47Z","updated_at":"2018-03-06T07:38:13Z","pushed_at":"2018-03-06T23:11:37Z","git_url":"git://github.com/nodejs/modules.git","ssh_url":"[email protected]:nodejs/modules.git","clone_url":"https://github.com/nodejs/modules.git","svn_url":"https://github.com/nodejs/modules","homepage":null,"size":26,"stargazers_count":55,"watchers_count":55,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"archived":false,"open_issues_count":18,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":9,"open_issues":18,"watchers":55,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/modules/pulls/45"},"html":{"href":"https://github.com/nodejs/modules/pull/45"},"issue":{"href":"https://api.github.com/repos/nodejs/modules/issues/45"},"comments":{"href":"https://api.github.com/repos/nodejs/modules/issues/45/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/modules/pulls/45/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/modules/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/modules/pulls/45/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/modules/statuses/1e83a20f88b6efa352be1090a3d91e7d21196fbb"}},"author_association":"OWNER"}} | {
"id": 119901830,
"name": "nodejs/modules",
"url": "https://api.github.com/repos/nodejs/modules"
} | {
"id": 45469,
"login": "ljharb",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/45469?",
"url": "https://api.github.com/users/ljharb"
} | {
"id": 9950313,
"login": "nodejs",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9950313?",
"url": "https://api.github.com/orgs/nodejs"
} | 2018-03-07T01:47:34 | 7341384088 | {"actor":{"display_login":"ljharb"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/weaveworks/cortex/pulls/comments/168795722","pull_request_review_id":97225495,"id":168795722,"diff_hunk":"@@ -224,7 +225,7 @@ func (d *Distributor) getClientFor(ingester *ring.IngesterDesc) (client.Ingester\n \t\treturn client, nil\n \t}\n \n-\tclient, err := d.cfg.ingesterClientFactory(ingester.Addr, d.cfg.CompressToIngester)\n+\tclient, err := d.cfg.ingesterClientFactory(ingester.Addr, d.cfg.CompressToIngester, d.cfg.IngesterClientConfig)","path":"pkg/distributor/distributor.go","position":34,"original_position":34,"commit_id":"4e32b729ab07b0ce6070db074819bdf26b03b617","original_commit_id":"4e32b729ab07b0ce6070db074819bdf26b03b617","user":{"login":"khaines","id":1144092,"avatar_url":"https://avatars3.githubusercontent.com/u/1144092?v=4","gravatar_id":"","url":"https://api.github.com/users/khaines","html_url":"https://github.com/khaines","followers_url":"https://api.github.com/users/khaines/followers","following_url":"https://api.github.com/users/khaines/following{/other_user}","gists_url":"https://api.github.com/users/khaines/gists{/gist_id}","starred_url":"https://api.github.com/users/khaines/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/khaines/subscriptions","organizations_url":"https://api.github.com/users/khaines/orgs","repos_url":"https://api.github.com/users/khaines/repos","events_url":"https://api.github.com/users/khaines/events{/privacy}","received_events_url":"https://api.github.com/users/khaines/received_events","type":"User","site_admin":false},"body":"Agreed. I will make the adjustment.","created_at":"2018-02-16T15:57:59Z","updated_at":"2018-02-16T15:58:00Z","html_url":"https://github.com/weaveworks/cortex/pull/712#discussion_r168795722","pull_request_url":"https://api.github.com/repos/weaveworks/cortex/pulls/712","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/weaveworks/cortex/pulls/comments/168795722"},"html":{"href":"https://github.com/weaveworks/cortex/pull/712#discussion_r168795722"},"pull_request":{"href":"https://api.github.com/repos/weaveworks/cortex/pulls/712"}},"in_reply_to_id":168638317},"pull_request":{"url":"https://api.github.com/repos/weaveworks/cortex/pulls/712","id":169511731,"html_url":"https://github.com/weaveworks/cortex/pull/712","diff_url":"https://github.com/weaveworks/cortex/pull/712.diff","patch_url":"https://github.com/weaveworks/cortex/pull/712.patch","issue_url":"https://api.github.com/repos/weaveworks/cortex/issues/712","number":712,"state":"open","locked":false,"title":"Updating IngesterClient MaxCallRecvMsgSize to be configurable vs fixed size","user":{"login":"khaines","id":1144092,"avatar_url":"https://avatars3.githubusercontent.com/u/1144092?v=4","gravatar_id":"","url":"https://api.github.com/users/khaines","html_url":"https://github.com/khaines","followers_url":"https://api.github.com/users/khaines/followers","following_url":"https://api.github.com/users/khaines/following{/other_user}","gists_url":"https://api.github.com/users/khaines/gists{/gist_id}","starred_url":"https://api.github.com/users/khaines/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/khaines/subscriptions","organizations_url":"https://api.github.com/users/khaines/orgs","repos_url":"https://api.github.com/users/khaines/repos","events_url":"https://api.github.com/users/khaines/events{/privacy}","received_events_url":"https://api.github.com/users/khaines/received_events","type":"User","site_admin":false},"body":"We have some data scenarios where the amount of data exceeds the 64MB fixed size that the grpc client was set to for a max message size (added in [#660](https://github.com/weaveworks/cortex/pull/660)). This update changes that to a configurable command arg flag, with the default being set to 64MB.\r\n\r\n","created_at":"2018-02-15T23:12:46Z","updated_at":"2018-02-16T15:58:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b010c744b9b148c41f731f5e3aa2a75bf4897708","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/weaveworks/cortex/pulls/712/commits","review_comments_url":"https://api.github.com/repos/weaveworks/cortex/pulls/712/comments","review_comment_url":"https://api.github.com/repos/weaveworks/cortex/pulls/comments{/number}","comments_url":"https://api.github.com/repos/weaveworks/cortex/issues/712/comments","statuses_url":"https://api.github.com/repos/weaveworks/cortex/statuses/4e32b729ab07b0ce6070db074819bdf26b03b617","head":{"label":"khaines:khaines/max-msg-size-arg","ref":"khaines/max-msg-size-arg","sha":"4e32b729ab07b0ce6070db074819bdf26b03b617","user":{"login":"khaines","id":1144092,"avatar_url":"https://avatars3.githubusercontent.com/u/1144092?v=4","gravatar_id":"","url":"https://api.github.com/users/khaines","html_url":"https://github.com/khaines","followers_url":"https://api.github.com/users/khaines/followers","following_url":"https://api.github.com/users/khaines/following{/other_user}","gists_url":"https://api.github.com/users/khaines/gists{/gist_id}","starred_url":"https://api.github.com/users/khaines/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/khaines/subscriptions","organizations_url":"https://api.github.com/users/khaines/orgs","repos_url":"https://api.github.com/users/khaines/repos","events_url":"https://api.github.com/users/khaines/events{/privacy}","received_events_url":"https://api.github.com/users/khaines/received_events","type":"User","site_admin":false},"repo":{"id":108338458,"name":"cortex","full_name":"khaines/cortex","owner":{"login":"khaines","id":1144092,"avatar_url":"https://avatars3.githubusercontent.com/u/1144092?v=4","gravatar_id":"","url":"https://api.github.com/users/khaines","html_url":"https://github.com/khaines","followers_url":"https://api.github.com/users/khaines/followers","following_url":"https://api.github.com/users/khaines/following{/other_user}","gists_url":"https://api.github.com/users/khaines/gists{/gist_id}","starred_url":"https://api.github.com/users/khaines/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/khaines/subscriptions","organizations_url":"https://api.github.com/users/khaines/orgs","repos_url":"https://api.github.com/users/khaines/repos","events_url":"https://api.github.com/users/khaines/events{/privacy}","received_events_url":"https://api.github.com/users/khaines/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/khaines/cortex","description":"A multitenant, horizontally scalable Prometheus as a Service","fork":true,"url":"https://api.github.com/repos/khaines/cortex","forks_url":"https://api.github.com/repos/khaines/cortex/forks","keys_url":"https://api.github.com/repos/khaines/cortex/keys{/key_id}","collaborators_url":"https://api.github.com/repos/khaines/cortex/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/khaines/cortex/teams","hooks_url":"https://api.github.com/repos/khaines/cortex/hooks","issue_events_url":"https://api.github.com/repos/khaines/cortex/issues/events{/number}","events_url":"https://api.github.com/repos/khaines/cortex/events","assignees_url":"https://api.github.com/repos/khaines/cortex/assignees{/user}","branches_url":"https://api.github.com/repos/khaines/cortex/branches{/branch}","tags_url":"https://api.github.com/repos/khaines/cortex/tags","blobs_url":"https://api.github.com/repos/khaines/cortex/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/khaines/cortex/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/khaines/cortex/git/refs{/sha}","trees_url":"https://api.github.com/repos/khaines/cortex/git/trees{/sha}","statuses_url":"https://api.github.com/repos/khaines/cortex/statuses/{sha}","languages_url":"https://api.github.com/repos/khaines/cortex/languages","stargazers_url":"https://api.github.com/repos/khaines/cortex/stargazers","contributors_url":"https://api.github.com/repos/khaines/cortex/contributors","subscribers_url":"https://api.github.com/repos/khaines/cortex/subscribers","subscription_url":"https://api.github.com/repos/khaines/cortex/subscription","commits_url":"https://api.github.com/repos/khaines/cortex/commits{/sha}","git_commits_url":"https://api.github.com/repos/khaines/cortex/git/commits{/sha}","comments_url":"https://api.github.com/repos/khaines/cortex/comments{/number}","issue_comment_url":"https://api.github.com/repos/khaines/cortex/issues/comments{/number}","contents_url":"https://api.github.com/repos/khaines/cortex/contents/{+path}","compare_url":"https://api.github.com/repos/khaines/cortex/compare/{base}...{head}","merges_url":"https://api.github.com/repos/khaines/cortex/merges","archive_url":"https://api.github.com/repos/khaines/cortex/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/khaines/cortex/downloads","issues_url":"https://api.github.com/repos/khaines/cortex/issues{/number}","pulls_url":"https://api.github.com/repos/khaines/cortex/pulls{/number}","milestones_url":"https://api.github.com/repos/khaines/cortex/milestones{/number}","notifications_url":"https://api.github.com/repos/khaines/cortex/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/khaines/cortex/labels{/name}","releases_url":"https://api.github.com/repos/khaines/cortex/releases{/id}","deployments_url":"https://api.github.com/repos/khaines/cortex/deployments","created_at":"2017-10-25T23:45:25Z","updated_at":"2017-10-25T23:45:28Z","pushed_at":"2018-02-15T22:51:02Z","git_url":"git://github.com/khaines/cortex.git","ssh_url":"[email protected]:khaines/cortex.git","clone_url":"https://github.com/khaines/cortex.git","svn_url":"https://github.com/khaines/cortex","homepage":null,"size":79703,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"weaveworks:master","ref":"master","sha":"110b705e1db879ef4f9f4a3a8cbdcf8cc1784373","user":{"login":"weaveworks","id":9976052,"avatar_url":"https://avatars1.githubusercontent.com/u/9976052?v=4","gravatar_id":"","url":"https://api.github.com/users/weaveworks","html_url":"https://github.com/weaveworks","followers_url":"https://api.github.com/users/weaveworks/followers","following_url":"https://api.github.com/users/weaveworks/following{/other_user}","gists_url":"https://api.github.com/users/weaveworks/gists{/gist_id}","starred_url":"https://api.github.com/users/weaveworks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weaveworks/subscriptions","organizations_url":"https://api.github.com/users/weaveworks/orgs","repos_url":"https://api.github.com/users/weaveworks/repos","events_url":"https://api.github.com/users/weaveworks/events{/privacy}","received_events_url":"https://api.github.com/users/weaveworks/received_events","type":"Organization","site_admin":false},"repo":{"id":67793333,"name":"cortex","full_name":"weaveworks/cortex","owner":{"login":"weaveworks","id":9976052,"avatar_url":"https://avatars1.githubusercontent.com/u/9976052?v=4","gravatar_id":"","url":"https://api.github.com/users/weaveworks","html_url":"https://github.com/weaveworks","followers_url":"https://api.github.com/users/weaveworks/followers","following_url":"https://api.github.com/users/weaveworks/following{/other_user}","gists_url":"https://api.github.com/users/weaveworks/gists{/gist_id}","starred_url":"https://api.github.com/users/weaveworks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weaveworks/subscriptions","organizations_url":"https://api.github.com/users/weaveworks/orgs","repos_url":"https://api.github.com/users/weaveworks/repos","events_url":"https://api.github.com/users/weaveworks/events{/privacy}","received_events_url":"https://api.github.com/users/weaveworks/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/weaveworks/cortex","description":"A multitenant, horizontally scalable Prometheus as a Service","fork":false,"url":"https://api.github.com/repos/weaveworks/cortex","forks_url":"https://api.github.com/repos/weaveworks/cortex/forks","keys_url":"https://api.github.com/repos/weaveworks/cortex/keys{/key_id}","collaborators_url":"https://api.github.com/repos/weaveworks/cortex/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/weaveworks/cortex/teams","hooks_url":"https://api.github.com/repos/weaveworks/cortex/hooks","issue_events_url":"https://api.github.com/repos/weaveworks/cortex/issues/events{/number}","events_url":"https://api.github.com/repos/weaveworks/cortex/events","assignees_url":"https://api.github.com/repos/weaveworks/cortex/assignees{/user}","branches_url":"https://api.github.com/repos/weaveworks/cortex/branches{/branch}","tags_url":"https://api.github.com/repos/weaveworks/cortex/tags","blobs_url":"https://api.github.com/repos/weaveworks/cortex/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/weaveworks/cortex/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/weaveworks/cortex/git/refs{/sha}","trees_url":"https://api.github.com/repos/weaveworks/cortex/git/trees{/sha}","statuses_url":"https://api.github.com/repos/weaveworks/cortex/statuses/{sha}","languages_url":"https://api.github.com/repos/weaveworks/cortex/languages","stargazers_url":"https://api.github.com/repos/weaveworks/cortex/stargazers","contributors_url":"https://api.github.com/repos/weaveworks/cortex/contributors","subscribers_url":"https://api.github.com/repos/weaveworks/cortex/subscribers","subscription_url":"https://api.github.com/repos/weaveworks/cortex/subscription","commits_url":"https://api.github.com/repos/weaveworks/cortex/commits{/sha}","git_commits_url":"https://api.github.com/repos/weaveworks/cortex/git/commits{/sha}","comments_url":"https://api.github.com/repos/weaveworks/cortex/comments{/number}","issue_comment_url":"https://api.github.com/repos/weaveworks/cortex/issues/comments{/number}","contents_url":"https://api.github.com/repos/weaveworks/cortex/contents/{+path}","compare_url":"https://api.github.com/repos/weaveworks/cortex/compare/{base}...{head}","merges_url":"https://api.github.com/repos/weaveworks/cortex/merges","archive_url":"https://api.github.com/repos/weaveworks/cortex/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/weaveworks/cortex/downloads","issues_url":"https://api.github.com/repos/weaveworks/cortex/issues{/number}","pulls_url":"https://api.github.com/repos/weaveworks/cortex/pulls{/number}","milestones_url":"https://api.github.com/repos/weaveworks/cortex/milestones{/number}","notifications_url":"https://api.github.com/repos/weaveworks/cortex/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/weaveworks/cortex/labels{/name}","releases_url":"https://api.github.com/repos/weaveworks/cortex/releases{/id}","deployments_url":"https://api.github.com/repos/weaveworks/cortex/deployments","created_at":"2016-09-09T11:23:12Z","updated_at":"2018-02-14T16:20:53Z","pushed_at":"2018-02-16T15:27:02Z","git_url":"git://github.com/weaveworks/cortex.git","ssh_url":"[email protected]:weaveworks/cortex.git","clone_url":"https://github.com/weaveworks/cortex.git","svn_url":"https://github.com/weaveworks/cortex","homepage":null,"size":79794,"stargazers_count":411,"watchers_count":411,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":43,"mirror_url":null,"archived":false,"open_issues_count":115,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":43,"open_issues":115,"watchers":411,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/weaveworks/cortex/pulls/712"},"html":{"href":"https://github.com/weaveworks/cortex/pull/712"},"issue":{"href":"https://api.github.com/repos/weaveworks/cortex/issues/712"},"comments":{"href":"https://api.github.com/repos/weaveworks/cortex/issues/712/comments"},"review_comments":{"href":"https://api.github.com/repos/weaveworks/cortex/pulls/712/comments"},"review_comment":{"href":"https://api.github.com/repos/weaveworks/cortex/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/weaveworks/cortex/pulls/712/commits"},"statuses":{"href":"https://api.github.com/repos/weaveworks/cortex/statuses/4e32b729ab07b0ce6070db074819bdf26b03b617"}},"author_association":"NONE"}} | {
"id": 67793333,
"name": "weaveworks/cortex",
"url": "https://api.github.com/repos/weaveworks/cortex"
} | {
"id": 1144092,
"login": "khaines",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1144092?",
"url": "https://api.github.com/users/khaines"
} | {
"id": 9976052,
"login": "weaveworks",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9976052?",
"url": "https://api.github.com/orgs/weaveworks"
} | 2018-02-16T15:57:59 | 7255789096 | {"actor":{"display_login":"khaines"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/usabilla/stylabilla/pulls/comments/225106011","pull_request_review_id":164630512,"id":225106011,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNTEwNjAxMQ==","diff_hunk":"@@ -27,3 +27,6 @@ $sb-main-navigation-width: 75px;\n $sb-main-navigation-overflow-menu-left: $sb-main-navigation-width - 11px;\n $sb-container-margin: $sb-sidepanel-width + $sb-main-navigation-width;\n $sb-overflow-menu-min-width: 150px;\n+\n+// WizardDialog\n+$sb-wizard-dialog-footer-height: 68px;","path":"src/settings/_box.scss","position":6,"original_position":6,"commit_id":"ba56bb73463bb37c33d5e2cd066809251f994d71","original_commit_id":"ba56bb73463bb37c33d5e2cd066809251f994d71","user":{"login":"spirosikmd","id":1057324,"node_id":"MDQ6VXNlcjEwNTczMjQ=","avatar_url":"https://avatars3.githubusercontent.com/u/1057324?v=4","gravatar_id":"","url":"https://api.github.com/users/spirosikmd","html_url":"https://github.com/spirosikmd","followers_url":"https://api.github.com/users/spirosikmd/followers","following_url":"https://api.github.com/users/spirosikmd/following{/other_user}","gists_url":"https://api.github.com/users/spirosikmd/gists{/gist_id}","starred_url":"https://api.github.com/users/spirosikmd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spirosikmd/subscriptions","organizations_url":"https://api.github.com/users/spirosikmd/orgs","repos_url":"https://api.github.com/users/spirosikmd/repos","events_url":"https://api.github.com/users/spirosikmd/events{/privacy}","received_events_url":"https://api.github.com/users/spirosikmd/received_events","type":"User","site_admin":false},"body":"Why are we adding this variable here? Is it only used in the `_wizard-dialog.scss` file?","created_at":"2018-10-15T10:01:46Z","updated_at":"2018-10-15T10:03:48Z","html_url":"https://github.com/usabilla/stylabilla/pull/221#discussion_r225106011","pull_request_url":"https://api.github.com/repos/usabilla/stylabilla/pulls/221","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/usabilla/stylabilla/pulls/comments/225106011"},"html":{"href":"https://github.com/usabilla/stylabilla/pull/221#discussion_r225106011"},"pull_request":{"href":"https://api.github.com/repos/usabilla/stylabilla/pulls/221"}}},"pull_request":{"url":"https://api.github.com/repos/usabilla/stylabilla/pulls/221","id":222462164,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyNDYyMTY0","html_url":"https://github.com/usabilla/stylabilla/pull/221","diff_url":"https://github.com/usabilla/stylabilla/pull/221.diff","patch_url":"https://github.com/usabilla/stylabilla/pull/221.patch","issue_url":"https://api.github.com/repos/usabilla/stylabilla/issues/221","number":221,"state":"open","locked":false,"title":"fix(wizard-dialog): content overflow","user":{"login":"MLKiiwy","id":619217,"node_id":"MDQ6VXNlcjYxOTIxNw==","avatar_url":"https://avatars0.githubusercontent.com/u/619217?v=4","gravatar_id":"","url":"https://api.github.com/users/MLKiiwy","html_url":"https://github.com/MLKiiwy","followers_url":"https://api.github.com/users/MLKiiwy/followers","following_url":"https://api.github.com/users/MLKiiwy/following{/other_user}","gists_url":"https://api.github.com/users/MLKiiwy/gists{/gist_id}","starred_url":"https://api.github.com/users/MLKiiwy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MLKiiwy/subscriptions","organizations_url":"https://api.github.com/users/MLKiiwy/orgs","repos_url":"https://api.github.com/users/MLKiiwy/repos","events_url":"https://api.github.com/users/MLKiiwy/events{/privacy}","received_events_url":"https://api.github.com/users/MLKiiwy/received_events","type":"User","site_admin":false},"body":"Reviewers: @dine @MLKiiwy @spirosikmd @kagnamazian @galagmon @michelvdhoek \r\n\r\n- [x] Add a new example with a content that need a scrollbar and use the modifier : --srcollable\r\n- [x] by default content is not scrollable and should grow as maximum\r\n\r\nTest it here : https://static-staging.usabilla.com/stylabilla/BUB-246-fix-wizard-dialog-content-container/docs/section-components.html#kssref-components-wizard-dialog","created_at":"2018-10-12T13:13:41Z","updated_at":"2018-10-15T10:03:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0917d2f92be476fc4ddc929e9d82d7f43e5830f9","assignee":null,"assignees":[],"requested_reviewers":[{"login":"galagmon","id":19214087,"node_id":"MDQ6VXNlcjE5MjE0MDg3","avatar_url":"https://avatars3.githubusercontent.com/u/19214087?v=4","gravatar_id":"","url":"https://api.github.com/users/galagmon","html_url":"https://github.com/galagmon","followers_url":"https://api.github.com/users/galagmon/followers","following_url":"https://api.github.com/users/galagmon/following{/other_user}","gists_url":"https://api.github.com/users/galagmon/gists{/gist_id}","starred_url":"https://api.github.com/users/galagmon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/galagmon/subscriptions","organizations_url":"https://api.github.com/users/galagmon/orgs","repos_url":"https://api.github.com/users/galagmon/repos","events_url":"https://api.github.com/users/galagmon/events{/privacy}","received_events_url":"https://api.github.com/users/galagmon/received_events","type":"User","site_admin":false},{"login":"michelvdhoek","id":38220441,"node_id":"MDQ6VXNlcjM4MjIwNDQx","avatar_url":"https://avatars3.githubusercontent.com/u/38220441?v=4","gravatar_id":"","url":"https://api.github.com/users/michelvdhoek","html_url":"https://github.com/michelvdhoek","followers_url":"https://api.github.com/users/michelvdhoek/followers","following_url":"https://api.github.com/users/michelvdhoek/following{/other_user}","gists_url":"https://api.github.com/users/michelvdhoek/gists{/gist_id}","starred_url":"https://api.github.com/users/michelvdhoek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michelvdhoek/subscriptions","organizations_url":"https://api.github.com/users/michelvdhoek/orgs","repos_url":"https://api.github.com/users/michelvdhoek/repos","events_url":"https://api.github.com/users/michelvdhoek/events{/privacy}","received_events_url":"https://api.github.com/users/michelvdhoek/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/usabilla/stylabilla/pulls/221/commits","review_comments_url":"https://api.github.com/repos/usabilla/stylabilla/pulls/221/comments","review_comment_url":"https://api.github.com/repos/usabilla/stylabilla/pulls/comments{/number}","comments_url":"https://api.github.com/repos/usabilla/stylabilla/issues/221/comments","statuses_url":"https://api.github.com/repos/usabilla/stylabilla/statuses/ba56bb73463bb37c33d5e2cd066809251f994d71","head":{"label":"usabilla:BUB-246-fix-wizard-dialog-content-container","ref":"BUB-246-fix-wizard-dialog-content-container","sha":"ba56bb73463bb37c33d5e2cd066809251f994d71","user":{"login":"usabilla","id":10025907,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMDI1OTA3","avatar_url":"https://avatars2.githubusercontent.com/u/10025907?v=4","gravatar_id":"","url":"https://api.github.com/users/usabilla","html_url":"https://github.com/usabilla","followers_url":"https://api.github.com/users/usabilla/followers","following_url":"https://api.github.com/users/usabilla/following{/other_user}","gists_url":"https://api.github.com/users/usabilla/gists{/gist_id}","starred_url":"https://api.github.com/users/usabilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/usabilla/subscriptions","organizations_url":"https://api.github.com/users/usabilla/orgs","repos_url":"https://api.github.com/users/usabilla/repos","events_url":"https://api.github.com/users/usabilla/events{/privacy}","received_events_url":"https://api.github.com/users/usabilla/received_events","type":"Organization","site_admin":false},"repo":{"id":94882698,"node_id":"MDEwOlJlcG9zaXRvcnk5NDg4MjY5OA==","name":"stylabilla","full_name":"usabilla/stylabilla","private":false,"owner":{"login":"usabilla","id":10025907,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMDI1OTA3","avatar_url":"https://avatars2.githubusercontent.com/u/10025907?v=4","gravatar_id":"","url":"https://api.github.com/users/usabilla","html_url":"https://github.com/usabilla","followers_url":"https://api.github.com/users/usabilla/followers","following_url":"https://api.github.com/users/usabilla/following{/other_user}","gists_url":"https://api.github.com/users/usabilla/gists{/gist_id}","starred_url":"https://api.github.com/users/usabilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/usabilla/subscriptions","organizations_url":"https://api.github.com/users/usabilla/orgs","repos_url":"https://api.github.com/users/usabilla/repos","events_url":"https://api.github.com/users/usabilla/events{/privacy}","received_events_url":"https://api.github.com/users/usabilla/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/usabilla/stylabilla","description":"Usabilla Styleguide","fork":false,"url":"https://api.github.com/repos/usabilla/stylabilla","forks_url":"https://api.github.com/repos/usabilla/stylabilla/forks","keys_url":"https://api.github.com/repos/usabilla/stylabilla/keys{/key_id}","collaborators_url":"https://api.github.com/repos/usabilla/stylabilla/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/usabilla/stylabilla/teams","hooks_url":"https://api.github.com/repos/usabilla/stylabilla/hooks","issue_events_url":"https://api.github.com/repos/usabilla/stylabilla/issues/events{/number}","events_url":"https://api.github.com/repos/usabilla/stylabilla/events","assignees_url":"https://api.github.com/repos/usabilla/stylabilla/assignees{/user}","branches_url":"https://api.github.com/repos/usabilla/stylabilla/branches{/branch}","tags_url":"https://api.github.com/repos/usabilla/stylabilla/tags","blobs_url":"https://api.github.com/repos/usabilla/stylabilla/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/usabilla/stylabilla/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/usabilla/stylabilla/git/refs{/sha}","trees_url":"https://api.github.com/repos/usabilla/stylabilla/git/trees{/sha}","statuses_url":"https://api.github.com/repos/usabilla/stylabilla/statuses/{sha}","languages_url":"https://api.github.com/repos/usabilla/stylabilla/languages","stargazers_url":"https://api.github.com/repos/usabilla/stylabilla/stargazers","contributors_url":"https://api.github.com/repos/usabilla/stylabilla/contributors","subscribers_url":"https://api.github.com/repos/usabilla/stylabilla/subscribers","subscription_url":"https://api.github.com/repos/usabilla/stylabilla/subscription","commits_url":"https://api.github.com/repos/usabilla/stylabilla/commits{/sha}","git_commits_url":"https://api.github.com/repos/usabilla/stylabilla/git/commits{/sha}","comments_url":"https://api.github.com/repos/usabilla/stylabilla/comments{/number}","issue_comment_url":"https://api.github.com/repos/usabilla/stylabilla/issues/comments{/number}","contents_url":"https://api.github.com/repos/usabilla/stylabilla/contents/{+path}","compare_url":"https://api.github.com/repos/usabilla/stylabilla/compare/{base}...{head}","merges_url":"https://api.github.com/repos/usabilla/stylabilla/merges","archive_url":"https://api.github.com/repos/usabilla/stylabilla/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/usabilla/stylabilla/downloads","issues_url":"https://api.github.com/repos/usabilla/stylabilla/issues{/number}","pulls_url":"https://api.github.com/repos/usabilla/stylabilla/pulls{/number}","milestones_url":"https://api.github.com/repos/usabilla/stylabilla/milestones{/number}","notifications_url":"https://api.github.com/repos/usabilla/stylabilla/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/usabilla/stylabilla/labels{/name}","releases_url":"https://api.github.com/repos/usabilla/stylabilla/releases{/id}","deployments_url":"https://api.github.com/repos/usabilla/stylabilla/deployments","created_at":"2017-06-20T11:12:09Z","updated_at":"2018-10-10T12:20:13Z","pushed_at":"2018-10-15T08:38:26Z","git_url":"git://github.com/usabilla/stylabilla.git","ssh_url":"[email protected]:usabilla/stylabilla.git","clone_url":"https://github.com/usabilla/stylabilla.git","svn_url":"https://github.com/usabilla/stylabilla","homepage":null,"size":898,"stargazers_count":4,"watchers_count":4,"language":"CSS","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":1,"open_issues":1,"watchers":4,"default_branch":"master"}},"base":{"label":"usabilla:master","ref":"master","sha":"43dc99160d8a0be70f8b79955af1d271708fb0ba","user":{"login":"usabilla","id":10025907,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMDI1OTA3","avatar_url":"https://avatars2.githubusercontent.com/u/10025907?v=4","gravatar_id":"","url":"https://api.github.com/users/usabilla","html_url":"https://github.com/usabilla","followers_url":"https://api.github.com/users/usabilla/followers","following_url":"https://api.github.com/users/usabilla/following{/other_user}","gists_url":"https://api.github.com/users/usabilla/gists{/gist_id}","starred_url":"https://api.github.com/users/usabilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/usabilla/subscriptions","organizations_url":"https://api.github.com/users/usabilla/orgs","repos_url":"https://api.github.com/users/usabilla/repos","events_url":"https://api.github.com/users/usabilla/events{/privacy}","received_events_url":"https://api.github.com/users/usabilla/received_events","type":"Organization","site_admin":false},"repo":{"id":94882698,"node_id":"MDEwOlJlcG9zaXRvcnk5NDg4MjY5OA==","name":"stylabilla","full_name":"usabilla/stylabilla","private":false,"owner":{"login":"usabilla","id":10025907,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMDI1OTA3","avatar_url":"https://avatars2.githubusercontent.com/u/10025907?v=4","gravatar_id":"","url":"https://api.github.com/users/usabilla","html_url":"https://github.com/usabilla","followers_url":"https://api.github.com/users/usabilla/followers","following_url":"https://api.github.com/users/usabilla/following{/other_user}","gists_url":"https://api.github.com/users/usabilla/gists{/gist_id}","starred_url":"https://api.github.com/users/usabilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/usabilla/subscriptions","organizations_url":"https://api.github.com/users/usabilla/orgs","repos_url":"https://api.github.com/users/usabilla/repos","events_url":"https://api.github.com/users/usabilla/events{/privacy}","received_events_url":"https://api.github.com/users/usabilla/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/usabilla/stylabilla","description":"Usabilla Styleguide","fork":false,"url":"https://api.github.com/repos/usabilla/stylabilla","forks_url":"https://api.github.com/repos/usabilla/stylabilla/forks","keys_url":"https://api.github.com/repos/usabilla/stylabilla/keys{/key_id}","collaborators_url":"https://api.github.com/repos/usabilla/stylabilla/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/usabilla/stylabilla/teams","hooks_url":"https://api.github.com/repos/usabilla/stylabilla/hooks","issue_events_url":"https://api.github.com/repos/usabilla/stylabilla/issues/events{/number}","events_url":"https://api.github.com/repos/usabilla/stylabilla/events","assignees_url":"https://api.github.com/repos/usabilla/stylabilla/assignees{/user}","branches_url":"https://api.github.com/repos/usabilla/stylabilla/branches{/branch}","tags_url":"https://api.github.com/repos/usabilla/stylabilla/tags","blobs_url":"https://api.github.com/repos/usabilla/stylabilla/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/usabilla/stylabilla/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/usabilla/stylabilla/git/refs{/sha}","trees_url":"https://api.github.com/repos/usabilla/stylabilla/git/trees{/sha}","statuses_url":"https://api.github.com/repos/usabilla/stylabilla/statuses/{sha}","languages_url":"https://api.github.com/repos/usabilla/stylabilla/languages","stargazers_url":"https://api.github.com/repos/usabilla/stylabilla/stargazers","contributors_url":"https://api.github.com/repos/usabilla/stylabilla/contributors","subscribers_url":"https://api.github.com/repos/usabilla/stylabilla/subscribers","subscription_url":"https://api.github.com/repos/usabilla/stylabilla/subscription","commits_url":"https://api.github.com/repos/usabilla/stylabilla/commits{/sha}","git_commits_url":"https://api.github.com/repos/usabilla/stylabilla/git/commits{/sha}","comments_url":"https://api.github.com/repos/usabilla/stylabilla/comments{/number}","issue_comment_url":"https://api.github.com/repos/usabilla/stylabilla/issues/comments{/number}","contents_url":"https://api.github.com/repos/usabilla/stylabilla/contents/{+path}","compare_url":"https://api.github.com/repos/usabilla/stylabilla/compare/{base}...{head}","merges_url":"https://api.github.com/repos/usabilla/stylabilla/merges","archive_url":"https://api.github.com/repos/usabilla/stylabilla/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/usabilla/stylabilla/downloads","issues_url":"https://api.github.com/repos/usabilla/stylabilla/issues{/number}","pulls_url":"https://api.github.com/repos/usabilla/stylabilla/pulls{/number}","milestones_url":"https://api.github.com/repos/usabilla/stylabilla/milestones{/number}","notifications_url":"https://api.github.com/repos/usabilla/stylabilla/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/usabilla/stylabilla/labels{/name}","releases_url":"https://api.github.com/repos/usabilla/stylabilla/releases{/id}","deployments_url":"https://api.github.com/repos/usabilla/stylabilla/deployments","created_at":"2017-06-20T11:12:09Z","updated_at":"2018-10-10T12:20:13Z","pushed_at":"2018-10-15T08:38:26Z","git_url":"git://github.com/usabilla/stylabilla.git","ssh_url":"[email protected]:usabilla/stylabilla.git","clone_url":"https://github.com/usabilla/stylabilla.git","svn_url":"https://github.com/usabilla/stylabilla","homepage":null,"size":898,"stargazers_count":4,"watchers_count":4,"language":"CSS","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":1,"open_issues":1,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/usabilla/stylabilla/pulls/221"},"html":{"href":"https://github.com/usabilla/stylabilla/pull/221"},"issue":{"href":"https://api.github.com/repos/usabilla/stylabilla/issues/221"},"comments":{"href":"https://api.github.com/repos/usabilla/stylabilla/issues/221/comments"},"review_comments":{"href":"https://api.github.com/repos/usabilla/stylabilla/pulls/221/comments"},"review_comment":{"href":"https://api.github.com/repos/usabilla/stylabilla/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/usabilla/stylabilla/pulls/221/commits"},"statuses":{"href":"https://api.github.com/repos/usabilla/stylabilla/statuses/ba56bb73463bb37c33d5e2cd066809251f994d71"}},"author_association":"CONTRIBUTOR"}} | {
"id": 94882698,
"name": "usabilla/stylabilla",
"url": "https://api.github.com/repos/usabilla/stylabilla"
} | {
"id": 1057324,
"login": "spirosikmd",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1057324?",
"url": "https://api.github.com/users/spirosikmd"
} | {
"id": 10025907,
"login": "usabilla",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/10025907?",
"url": "https://api.github.com/orgs/usabilla"
} | 2018-10-15T10:01:46 | 8420455499 | {"actor":{"display_login":"spirosikmd"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/UAVCAN/dsdl/pulls/comments/242446444","pull_request_review_id":185954687,"id":242446444,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MjQ0NjQ0NA==","diff_hunk":"@@ -0,0 +1,106 @@\n+#\n+# This service is used to write and read a register. Write is optional, it is performed if the value provided in\n+# the request is not empty.\n+#\n+# The write operation is performed first, unless skipped by sending an empty value in the request.\n+# The server may attempt to convert the type of the value to the proper type if there is a type mismatch\n+# (e.g. uint8 may be converted to uint16); however, servers are not required to perform implicit type conversion,","path":"uavcan/register/384.Access.0.1.uavcan","position":7,"original_position":7,"commit_id":"ff1e64cdf8f18a3e57ce74afdee599863bd5ab23","original_commit_id":"7fd8855797a31244111c587ea3ed82d7bda85926","user":{"login":"pavel-kirienko","id":3298404,"node_id":"MDQ6VXNlcjMyOTg0MDQ=","avatar_url":"https://avatars2.githubusercontent.com/u/3298404?v=4","gravatar_id":"","url":"https://api.github.com/users/pavel-kirienko","html_url":"https://github.com/pavel-kirienko","followers_url":"https://api.github.com/users/pavel-kirienko/followers","following_url":"https://api.github.com/users/pavel-kirienko/following{/other_user}","gists_url":"https://api.github.com/users/pavel-kirienko/gists{/gist_id}","starred_url":"https://api.github.com/users/pavel-kirienko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pavel-kirienko/subscriptions","organizations_url":"https://api.github.com/users/pavel-kirienko/orgs","repos_url":"https://api.github.com/users/pavel-kirienko/repos","events_url":"https://api.github.com/users/pavel-kirienko/events{/privacy}","received_events_url":"https://api.github.com/users/pavel-kirienko/received_events","type":"User","site_admin":false},"body":"> the comments should mention how to properly introspect register type\r\n\r\nDone.\r\n\r\n> I'm wondering if we should require errors are returned\r\n\r\nOne of the design objectives was to keep this interface very simple and minimalistic. As it implements a basic and commonly used feature of configuration parameter management, it needs to scale well from very resource-constrained systems to complex applications. It seems to be possible to handle all sensible error modes without explicit error information. Specifically, in the case of implicit type conversion errors, the caller will see that the data returned from the server differs from the request, and deduce that there was an error. For robust operation, clients will have to make sure that the data type used in the request matches exactly the discovered type.","created_at":"2018-12-18T08:42:14Z","updated_at":"2018-12-18T08:42:15Z","html_url":"https://github.com/UAVCAN/dsdl/pull/59#discussion_r242446444","pull_request_url":"https://api.github.com/repos/UAVCAN/dsdl/pulls/59","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/UAVCAN/dsdl/pulls/comments/242446444"},"html":{"href":"https://github.com/UAVCAN/dsdl/pull/59#discussion_r242446444"},"pull_request":{"href":"https://api.github.com/repos/UAVCAN/dsdl/pulls/59"}},"in_reply_to_id":242368541},"pull_request":{"url":"https://api.github.com/repos/UAVCAN/dsdl/pulls/59","id":239076850,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM5MDc2ODUw","html_url":"https://github.com/UAVCAN/dsdl/pull/59","diff_url":"https://github.com/UAVCAN/dsdl/pull/59.diff","patch_url":"https://github.com/UAVCAN/dsdl/pull/59.patch","issue_url":"https://api.github.com/repos/UAVCAN/dsdl/issues/59","number":59,"state":"open","locked":false,"title":"Register protocol","user":{"login":"pavel-kirienko","id":3298404,"node_id":"MDQ6VXNlcjMyOTg0MDQ=","avatar_url":"https://avatars2.githubusercontent.com/u/3298404?v=4","gravatar_id":"","url":"https://api.github.com/users/pavel-kirienko","html_url":"https://github.com/pavel-kirienko","followers_url":"https://api.github.com/users/pavel-kirienko/followers","following_url":"https://api.github.com/users/pavel-kirienko/following{/other_user}","gists_url":"https://api.github.com/users/pavel-kirienko/gists{/gist_id}","starred_url":"https://api.github.com/users/pavel-kirienko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pavel-kirienko/subscriptions","organizations_url":"https://api.github.com/users/pavel-kirienko/orgs","repos_url":"https://api.github.com/users/pavel-kirienko/repos","events_url":"https://api.github.com/users/pavel-kirienko/events{/privacy}","received_events_url":"https://api.github.com/users/pavel-kirienko/received_events","type":"User","site_admin":false},"body":"This is the last PR for the new set of standard data types. The motivation and implementation details were discussed here: https://github.com/UAVCAN/dsdl/pull/47","created_at":"2018-12-17T09:30:47Z","updated_at":"2018-12-18T08:42:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b00ca96d19dc54a5c3e8cae0dc1c93bd73b162b7","assignee":{"login":"pavel-kirienko","id":3298404,"node_id":"MDQ6VXNlcjMyOTg0MDQ=","avatar_url":"https://avatars2.githubusercontent.com/u/3298404?v=4","gravatar_id":"","url":"https://api.github.com/users/pavel-kirienko","html_url":"https://github.com/pavel-kirienko","followers_url":"https://api.github.com/users/pavel-kirienko/followers","following_url":"https://api.github.com/users/pavel-kirienko/following{/other_user}","gists_url":"https://api.github.com/users/pavel-kirienko/gists{/gist_id}","starred_url":"https://api.github.com/users/pavel-kirienko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pavel-kirienko/subscriptions","organizations_url":"https://api.github.com/users/pavel-kirienko/orgs","repos_url":"https://api.github.com/users/pavel-kirienko/repos","events_url":"https://api.github.com/users/pavel-kirienko/events{/privacy}","received_events_url":"https://api.github.com/users/pavel-kirienko/received_events","type":"User","site_admin":false},"assignees":[{"login":"pavel-kirienko","id":3298404,"node_id":"MDQ6VXNlcjMyOTg0MDQ=","avatar_url":"https://avatars2.githubusercontent.com/u/3298404?v=4","gravatar_id":"","url":"https://api.github.com/users/pavel-kirienko","html_url":"https://github.com/pavel-kirienko","followers_url":"https://api.github.com/users/pavel-kirienko/followers","following_url":"https://api.github.com/users/pavel-kirienko/following{/other_user}","gists_url":"https://api.github.com/users/pavel-kirienko/gists{/gist_id}","starred_url":"https://api.github.com/users/pavel-kirienko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pavel-kirienko/subscriptions","organizations_url":"https://api.github.com/users/pavel-kirienko/orgs","repos_url":"https://api.github.com/users/pavel-kirienko/repos","events_url":"https://api.github.com/users/pavel-kirienko/events{/privacy}","received_events_url":"https://api.github.com/users/pavel-kirienko/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/UAVCAN/dsdl/pulls/59/commits","review_comments_url":"https://api.github.com/repos/UAVCAN/dsdl/pulls/59/comments","review_comment_url":"https://api.github.com/repos/UAVCAN/dsdl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/UAVCAN/dsdl/issues/59/comments","statuses_url":"https://api.github.com/repos/UAVCAN/dsdl/statuses/ff1e64cdf8f18a3e57ce74afdee599863bd5ab23","head":{"label":"UAVCAN:register","ref":"register","sha":"ff1e64cdf8f18a3e57ce74afdee599863bd5ab23","user":{"login":"UAVCAN","id":10167381,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMTY3Mzgx","avatar_url":"https://avatars2.githubusercontent.com/u/10167381?v=4","gravatar_id":"","url":"https://api.github.com/users/UAVCAN","html_url":"https://github.com/UAVCAN","followers_url":"https://api.github.com/users/UAVCAN/followers","following_url":"https://api.github.com/users/UAVCAN/following{/other_user}","gists_url":"https://api.github.com/users/UAVCAN/gists{/gist_id}","starred_url":"https://api.github.com/users/UAVCAN/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UAVCAN/subscriptions","organizations_url":"https://api.github.com/users/UAVCAN/orgs","repos_url":"https://api.github.com/users/UAVCAN/repos","events_url":"https://api.github.com/users/UAVCAN/events{/privacy}","received_events_url":"https://api.github.com/users/UAVCAN/received_events","type":"Organization","site_admin":false},"repo":{"id":37192629,"node_id":"MDEwOlJlcG9zaXRvcnkzNzE5MjYyOQ==","name":"dsdl","full_name":"UAVCAN/dsdl","private":false,"owner":{"login":"UAVCAN","id":10167381,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMTY3Mzgx","avatar_url":"https://avatars2.githubusercontent.com/u/10167381?v=4","gravatar_id":"","url":"https://api.github.com/users/UAVCAN","html_url":"https://github.com/UAVCAN","followers_url":"https://api.github.com/users/UAVCAN/followers","following_url":"https://api.github.com/users/UAVCAN/following{/other_user}","gists_url":"https://api.github.com/users/UAVCAN/gists{/gist_id}","starred_url":"https://api.github.com/users/UAVCAN/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UAVCAN/subscriptions","organizations_url":"https://api.github.com/users/UAVCAN/orgs","repos_url":"https://api.github.com/users/UAVCAN/repos","events_url":"https://api.github.com/users/UAVCAN/events{/privacy}","received_events_url":"https://api.github.com/users/UAVCAN/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/UAVCAN/dsdl","description":"Regulated DSDL definitions for UAVCAN (standard and third-party)","fork":false,"url":"https://api.github.com/repos/UAVCAN/dsdl","forks_url":"https://api.github.com/repos/UAVCAN/dsdl/forks","keys_url":"https://api.github.com/repos/UAVCAN/dsdl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/UAVCAN/dsdl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/UAVCAN/dsdl/teams","hooks_url":"https://api.github.com/repos/UAVCAN/dsdl/hooks","issue_events_url":"https://api.github.com/repos/UAVCAN/dsdl/issues/events{/number}","events_url":"https://api.github.com/repos/UAVCAN/dsdl/events","assignees_url":"https://api.github.com/repos/UAVCAN/dsdl/assignees{/user}","branches_url":"https://api.github.com/repos/UAVCAN/dsdl/branches{/branch}","tags_url":"https://api.github.com/repos/UAVCAN/dsdl/tags","blobs_url":"https://api.github.com/repos/UAVCAN/dsdl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/UAVCAN/dsdl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/UAVCAN/dsdl/git/refs{/sha}","trees_url":"https://api.github.com/repos/UAVCAN/dsdl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/UAVCAN/dsdl/statuses/{sha}","languages_url":"https://api.github.com/repos/UAVCAN/dsdl/languages","stargazers_url":"https://api.github.com/repos/UAVCAN/dsdl/stargazers","contributors_url":"https://api.github.com/repos/UAVCAN/dsdl/contributors","subscribers_url":"https://api.github.com/repos/UAVCAN/dsdl/subscribers","subscription_url":"https://api.github.com/repos/UAVCAN/dsdl/subscription","commits_url":"https://api.github.com/repos/UAVCAN/dsdl/commits{/sha}","git_commits_url":"https://api.github.com/repos/UAVCAN/dsdl/git/commits{/sha}","comments_url":"https://api.github.com/repos/UAVCAN/dsdl/comments{/number}","issue_comment_url":"https://api.github.com/repos/UAVCAN/dsdl/issues/comments{/number}","contents_url":"https://api.github.com/repos/UAVCAN/dsdl/contents/{+path}","compare_url":"https://api.github.com/repos/UAVCAN/dsdl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/UAVCAN/dsdl/merges","archive_url":"https://api.github.com/repos/UAVCAN/dsdl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/UAVCAN/dsdl/downloads","issues_url":"https://api.github.com/repos/UAVCAN/dsdl/issues{/number}","pulls_url":"https://api.github.com/repos/UAVCAN/dsdl/pulls{/number}","milestones_url":"https://api.github.com/repos/UAVCAN/dsdl/milestones{/number}","notifications_url":"https://api.github.com/repos/UAVCAN/dsdl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/UAVCAN/dsdl/labels{/name}","releases_url":"https://api.github.com/repos/UAVCAN/dsdl/releases{/id}","deployments_url":"https://api.github.com/repos/UAVCAN/dsdl/deployments","created_at":"2015-06-10T11:15:37Z","updated_at":"2018-11-27T14:57:18Z","pushed_at":"2018-12-18T08:21:27Z","git_url":"git://github.com/UAVCAN/dsdl.git","ssh_url":"[email protected]:UAVCAN/dsdl.git","clone_url":"https://github.com/UAVCAN/dsdl.git","svn_url":"https://github.com/UAVCAN/dsdl","homepage":"http://uavcan.org","size":245,"stargazers_count":11,"watchers_count":11,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":30,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":30,"open_issues":3,"watchers":11,"default_branch":"master"}},"base":{"label":"UAVCAN:uavcan-v1.0","ref":"uavcan-v1.0","sha":"8f5587e29696e7760f77d446a78a63e0cfe4d3c5","user":{"login":"UAVCAN","id":10167381,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMTY3Mzgx","avatar_url":"https://avatars2.githubusercontent.com/u/10167381?v=4","gravatar_id":"","url":"https://api.github.com/users/UAVCAN","html_url":"https://github.com/UAVCAN","followers_url":"https://api.github.com/users/UAVCAN/followers","following_url":"https://api.github.com/users/UAVCAN/following{/other_user}","gists_url":"https://api.github.com/users/UAVCAN/gists{/gist_id}","starred_url":"https://api.github.com/users/UAVCAN/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UAVCAN/subscriptions","organizations_url":"https://api.github.com/users/UAVCAN/orgs","repos_url":"https://api.github.com/users/UAVCAN/repos","events_url":"https://api.github.com/users/UAVCAN/events{/privacy}","received_events_url":"https://api.github.com/users/UAVCAN/received_events","type":"Organization","site_admin":false},"repo":{"id":37192629,"node_id":"MDEwOlJlcG9zaXRvcnkzNzE5MjYyOQ==","name":"dsdl","full_name":"UAVCAN/dsdl","private":false,"owner":{"login":"UAVCAN","id":10167381,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMTY3Mzgx","avatar_url":"https://avatars2.githubusercontent.com/u/10167381?v=4","gravatar_id":"","url":"https://api.github.com/users/UAVCAN","html_url":"https://github.com/UAVCAN","followers_url":"https://api.github.com/users/UAVCAN/followers","following_url":"https://api.github.com/users/UAVCAN/following{/other_user}","gists_url":"https://api.github.com/users/UAVCAN/gists{/gist_id}","starred_url":"https://api.github.com/users/UAVCAN/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UAVCAN/subscriptions","organizations_url":"https://api.github.com/users/UAVCAN/orgs","repos_url":"https://api.github.com/users/UAVCAN/repos","events_url":"https://api.github.com/users/UAVCAN/events{/privacy}","received_events_url":"https://api.github.com/users/UAVCAN/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/UAVCAN/dsdl","description":"Regulated DSDL definitions for UAVCAN (standard and third-party)","fork":false,"url":"https://api.github.com/repos/UAVCAN/dsdl","forks_url":"https://api.github.com/repos/UAVCAN/dsdl/forks","keys_url":"https://api.github.com/repos/UAVCAN/dsdl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/UAVCAN/dsdl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/UAVCAN/dsdl/teams","hooks_url":"https://api.github.com/repos/UAVCAN/dsdl/hooks","issue_events_url":"https://api.github.com/repos/UAVCAN/dsdl/issues/events{/number}","events_url":"https://api.github.com/repos/UAVCAN/dsdl/events","assignees_url":"https://api.github.com/repos/UAVCAN/dsdl/assignees{/user}","branches_url":"https://api.github.com/repos/UAVCAN/dsdl/branches{/branch}","tags_url":"https://api.github.com/repos/UAVCAN/dsdl/tags","blobs_url":"https://api.github.com/repos/UAVCAN/dsdl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/UAVCAN/dsdl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/UAVCAN/dsdl/git/refs{/sha}","trees_url":"https://api.github.com/repos/UAVCAN/dsdl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/UAVCAN/dsdl/statuses/{sha}","languages_url":"https://api.github.com/repos/UAVCAN/dsdl/languages","stargazers_url":"https://api.github.com/repos/UAVCAN/dsdl/stargazers","contributors_url":"https://api.github.com/repos/UAVCAN/dsdl/contributors","subscribers_url":"https://api.github.com/repos/UAVCAN/dsdl/subscribers","subscription_url":"https://api.github.com/repos/UAVCAN/dsdl/subscription","commits_url":"https://api.github.com/repos/UAVCAN/dsdl/commits{/sha}","git_commits_url":"https://api.github.com/repos/UAVCAN/dsdl/git/commits{/sha}","comments_url":"https://api.github.com/repos/UAVCAN/dsdl/comments{/number}","issue_comment_url":"https://api.github.com/repos/UAVCAN/dsdl/issues/comments{/number}","contents_url":"https://api.github.com/repos/UAVCAN/dsdl/contents/{+path}","compare_url":"https://api.github.com/repos/UAVCAN/dsdl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/UAVCAN/dsdl/merges","archive_url":"https://api.github.com/repos/UAVCAN/dsdl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/UAVCAN/dsdl/downloads","issues_url":"https://api.github.com/repos/UAVCAN/dsdl/issues{/number}","pulls_url":"https://api.github.com/repos/UAVCAN/dsdl/pulls{/number}","milestones_url":"https://api.github.com/repos/UAVCAN/dsdl/milestones{/number}","notifications_url":"https://api.github.com/repos/UAVCAN/dsdl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/UAVCAN/dsdl/labels{/name}","releases_url":"https://api.github.com/repos/UAVCAN/dsdl/releases{/id}","deployments_url":"https://api.github.com/repos/UAVCAN/dsdl/deployments","created_at":"2015-06-10T11:15:37Z","updated_at":"2018-11-27T14:57:18Z","pushed_at":"2018-12-18T08:21:27Z","git_url":"git://github.com/UAVCAN/dsdl.git","ssh_url":"[email protected]:UAVCAN/dsdl.git","clone_url":"https://github.com/UAVCAN/dsdl.git","svn_url":"https://github.com/UAVCAN/dsdl","homepage":"http://uavcan.org","size":245,"stargazers_count":11,"watchers_count":11,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":30,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":30,"open_issues":3,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/UAVCAN/dsdl/pulls/59"},"html":{"href":"https://github.com/UAVCAN/dsdl/pull/59"},"issue":{"href":"https://api.github.com/repos/UAVCAN/dsdl/issues/59"},"comments":{"href":"https://api.github.com/repos/UAVCAN/dsdl/issues/59/comments"},"review_comments":{"href":"https://api.github.com/repos/UAVCAN/dsdl/pulls/59/comments"},"review_comment":{"href":"https://api.github.com/repos/UAVCAN/dsdl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/UAVCAN/dsdl/pulls/59/commits"},"statuses":{"href":"https://api.github.com/repos/UAVCAN/dsdl/statuses/ff1e64cdf8f18a3e57ce74afdee599863bd5ab23"}},"author_association":"MEMBER"}} | {
"id": 37192629,
"name": "UAVCAN/dsdl",
"url": "https://api.github.com/repos/UAVCAN/dsdl"
} | {
"id": 3298404,
"login": "pavel-kirienko",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3298404?",
"url": "https://api.github.com/users/pavel-kirienko"
} | {
"id": 10167381,
"login": "UAVCAN",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/10167381?",
"url": "https://api.github.com/orgs/UAVCAN"
} | 2018-12-18T08:42:14 | 8770425643 | {"actor":{"display_login":"pavel-kirienko"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/nats-io/go-nats/pulls/comments/172633000","pull_request_review_id":101683886,"id":172633000,"diff_hunk":"@@ -1283,6 +1285,24 @@ func (nc *Conn) sendConnect() error {\n \treturn nil\n }\n \n+// read byte-by-byte from the connection until the given 'c' character is found.\n+func (nc *Conn) readStringUpTo(c byte) (string, error) {","path":"nats.go","position":null,"original_position":29,"commit_id":"15952d72a55d0f498ce7b1f744d9cf63e9940cc1","original_commit_id":"41c5d2b079a93a104cf149c9b6478021edc6bb26","user":{"login":"kozlovic","id":13736691,"avatar_url":"https://avatars3.githubusercontent.com/u/13736691?v=4","gravatar_id":"","url":"https://api.github.com/users/kozlovic","html_url":"https://github.com/kozlovic","followers_url":"https://api.github.com/users/kozlovic/followers","following_url":"https://api.github.com/users/kozlovic/following{/other_user}","gists_url":"https://api.github.com/users/kozlovic/gists{/gist_id}","starred_url":"https://api.github.com/users/kozlovic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kozlovic/subscriptions","organizations_url":"https://api.github.com/users/kozlovic/orgs","repos_url":"https://api.github.com/users/kozlovic/repos","events_url":"https://api.github.com/users/kozlovic/events{/privacy}","received_events_url":"https://api.github.com/users/kozlovic/received_events","type":"User","site_admin":false},"body":"I could not find. We cannot use a buffered reader because it does fill up the buffer in the background, thing that we don't want to happen. I looked at a buffered reader with `io.LimitedReader`, but then you need to know the number of bytes you want to read.\r\n\r\nI did rename the function to `readProto` and don't pass the delimiter anymore. This function is not meant to be an all purpose function.","created_at":"2018-03-06T19:30:45Z","updated_at":"2018-03-06T19:30:45Z","html_url":"https://github.com/nats-io/go-nats/pull/348#discussion_r172633000","pull_request_url":"https://api.github.com/repos/nats-io/go-nats/pulls/348","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/nats-io/go-nats/pulls/comments/172633000"},"html":{"href":"https://github.com/nats-io/go-nats/pull/348#discussion_r172633000"},"pull_request":{"href":"https://api.github.com/repos/nats-io/go-nats/pulls/348"}},"in_reply_to_id":172457278},"pull_request":{"url":"https://api.github.com/repos/nats-io/go-nats/pulls/348","id":173043367,"html_url":"https://github.com/nats-io/go-nats/pull/348","diff_url":"https://github.com/nats-io/go-nats/pull/348.diff","patch_url":"https://github.com/nats-io/go-nats/pull/348.patch","issue_url":"https://api.github.com/repos/nats-io/go-nats/issues/348","number":348,"state":"open","locked":false,"title":"[FIXED] Protocols received right after first PONG may be processed","user":{"login":"kozlovic","id":13736691,"avatar_url":"https://avatars3.githubusercontent.com/u/13736691?v=4","gravatar_id":"","url":"https://api.github.com/users/kozlovic","html_url":"https://github.com/kozlovic","followers_url":"https://api.github.com/users/kozlovic/followers","following_url":"https://api.github.com/users/kozlovic/following{/other_user}","gists_url":"https://api.github.com/users/kozlovic/gists{/gist_id}","starred_url":"https://api.github.com/users/kozlovic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kozlovic/subscriptions","organizations_url":"https://api.github.com/users/kozlovic/orgs","repos_url":"https://api.github.com/users/kozlovic/repos","events_url":"https://api.github.com/users/kozlovic/events{/privacy}","received_events_url":"https://api.github.com/users/kozlovic/received_events","type":"User","site_admin":false},"body":"This manifested with the recent changes where server may send\r\nan async INFO protocol right after sending the initial PONG to\r\nthe client.\r\nAfter the client sends the CONNECT protocol, it expects to receive\r\na PONG. The reading of the protocol is done in place (in the\r\nsendConnect() function) but a buffer reader was used. This is wrong\r\nsince any data/protocol sent right after by the server may be\r\nconsumed when trying to read the PONG instead of leaving that to\r\nthe readLoop.\r\nSince we are just looking for the PONG (or OK and PONG) here, perform\r\na byte-by-byte read there. Alternatively, if doing a buffered read,\r\nthe buffer will have to be passed to the readLoop so that whatever\r\nis in the buffer is read prior to resuming reading from socket.","created_at":"2018-03-06T02:40:18Z","updated_at":"2018-03-06T19:30:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"45ba1eb928e92ec5947aaf99345ea8c055fa89e8","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/nats-io/go-nats/pulls/348/commits","review_comments_url":"https://api.github.com/repos/nats-io/go-nats/pulls/348/comments","review_comment_url":"https://api.github.com/repos/nats-io/go-nats/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nats-io/go-nats/issues/348/comments","statuses_url":"https://api.github.com/repos/nats-io/go-nats/statuses/15952d72a55d0f498ce7b1f744d9cf63e9940cc1","head":{"label":"nats-io:fix_read_after_connect","ref":"fix_read_after_connect","sha":"15952d72a55d0f498ce7b1f744d9cf63e9940cc1","user":{"login":"nats-io","id":10203055,"avatar_url":"https://avatars2.githubusercontent.com/u/10203055?v=4","gravatar_id":"","url":"https://api.github.com/users/nats-io","html_url":"https://github.com/nats-io","followers_url":"https://api.github.com/users/nats-io/followers","following_url":"https://api.github.com/users/nats-io/following{/other_user}","gists_url":"https://api.github.com/users/nats-io/gists{/gist_id}","starred_url":"https://api.github.com/users/nats-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nats-io/subscriptions","organizations_url":"https://api.github.com/users/nats-io/orgs","repos_url":"https://api.github.com/users/nats-io/repos","events_url":"https://api.github.com/users/nats-io/events{/privacy}","received_events_url":"https://api.github.com/users/nats-io/received_events","type":"Organization","site_admin":false},"repo":{"id":5425992,"name":"go-nats","full_name":"nats-io/go-nats","owner":{"login":"nats-io","id":10203055,"avatar_url":"https://avatars2.githubusercontent.com/u/10203055?v=4","gravatar_id":"","url":"https://api.github.com/users/nats-io","html_url":"https://github.com/nats-io","followers_url":"https://api.github.com/users/nats-io/followers","following_url":"https://api.github.com/users/nats-io/following{/other_user}","gists_url":"https://api.github.com/users/nats-io/gists{/gist_id}","starred_url":"https://api.github.com/users/nats-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nats-io/subscriptions","organizations_url":"https://api.github.com/users/nats-io/orgs","repos_url":"https://api.github.com/users/nats-io/repos","events_url":"https://api.github.com/users/nats-io/events{/privacy}","received_events_url":"https://api.github.com/users/nats-io/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nats-io/go-nats","description":"Golang client for NATS, the cloud native messaging system.","fork":false,"url":"https://api.github.com/repos/nats-io/go-nats","forks_url":"https://api.github.com/repos/nats-io/go-nats/forks","keys_url":"https://api.github.com/repos/nats-io/go-nats/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nats-io/go-nats/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nats-io/go-nats/teams","hooks_url":"https://api.github.com/repos/nats-io/go-nats/hooks","issue_events_url":"https://api.github.com/repos/nats-io/go-nats/issues/events{/number}","events_url":"https://api.github.com/repos/nats-io/go-nats/events","assignees_url":"https://api.github.com/repos/nats-io/go-nats/assignees{/user}","branches_url":"https://api.github.com/repos/nats-io/go-nats/branches{/branch}","tags_url":"https://api.github.com/repos/nats-io/go-nats/tags","blobs_url":"https://api.github.com/repos/nats-io/go-nats/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nats-io/go-nats/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nats-io/go-nats/git/refs{/sha}","trees_url":"https://api.github.com/repos/nats-io/go-nats/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nats-io/go-nats/statuses/{sha}","languages_url":"https://api.github.com/repos/nats-io/go-nats/languages","stargazers_url":"https://api.github.com/repos/nats-io/go-nats/stargazers","contributors_url":"https://api.github.com/repos/nats-io/go-nats/contributors","subscribers_url":"https://api.github.com/repos/nats-io/go-nats/subscribers","subscription_url":"https://api.github.com/repos/nats-io/go-nats/subscription","commits_url":"https://api.github.com/repos/nats-io/go-nats/commits{/sha}","git_commits_url":"https://api.github.com/repos/nats-io/go-nats/git/commits{/sha}","comments_url":"https://api.github.com/repos/nats-io/go-nats/comments{/number}","issue_comment_url":"https://api.github.com/repos/nats-io/go-nats/issues/comments{/number}","contents_url":"https://api.github.com/repos/nats-io/go-nats/contents/{+path}","compare_url":"https://api.github.com/repos/nats-io/go-nats/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nats-io/go-nats/merges","archive_url":"https://api.github.com/repos/nats-io/go-nats/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nats-io/go-nats/downloads","issues_url":"https://api.github.com/repos/nats-io/go-nats/issues{/number}","pulls_url":"https://api.github.com/repos/nats-io/go-nats/pulls{/number}","milestones_url":"https://api.github.com/repos/nats-io/go-nats/milestones{/number}","notifications_url":"https://api.github.com/repos/nats-io/go-nats/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nats-io/go-nats/labels{/name}","releases_url":"https://api.github.com/repos/nats-io/go-nats/releases{/id}","deployments_url":"https://api.github.com/repos/nats-io/go-nats/deployments","created_at":"2012-08-15T12:54:59Z","updated_at":"2018-03-06T15:27:30Z","pushed_at":"2018-03-06T19:28:09Z","git_url":"git://github.com/nats-io/go-nats.git","ssh_url":"[email protected]:nats-io/go-nats.git","clone_url":"https://github.com/nats-io/go-nats.git","svn_url":"https://github.com/nats-io/go-nats","homepage":"https://nats.io","size":999,"stargazers_count":1518,"watchers_count":1518,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":202,"mirror_url":null,"archived":false,"open_issues_count":9,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":202,"open_issues":9,"watchers":1518,"default_branch":"master"}},"base":{"label":"nats-io:master","ref":"master","sha":"bfca8afbfcc12e4e1642de90b1d2f6d5758c7717","user":{"login":"nats-io","id":10203055,"avatar_url":"https://avatars2.githubusercontent.com/u/10203055?v=4","gravatar_id":"","url":"https://api.github.com/users/nats-io","html_url":"https://github.com/nats-io","followers_url":"https://api.github.com/users/nats-io/followers","following_url":"https://api.github.com/users/nats-io/following{/other_user}","gists_url":"https://api.github.com/users/nats-io/gists{/gist_id}","starred_url":"https://api.github.com/users/nats-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nats-io/subscriptions","organizations_url":"https://api.github.com/users/nats-io/orgs","repos_url":"https://api.github.com/users/nats-io/repos","events_url":"https://api.github.com/users/nats-io/events{/privacy}","received_events_url":"https://api.github.com/users/nats-io/received_events","type":"Organization","site_admin":false},"repo":{"id":5425992,"name":"go-nats","full_name":"nats-io/go-nats","owner":{"login":"nats-io","id":10203055,"avatar_url":"https://avatars2.githubusercontent.com/u/10203055?v=4","gravatar_id":"","url":"https://api.github.com/users/nats-io","html_url":"https://github.com/nats-io","followers_url":"https://api.github.com/users/nats-io/followers","following_url":"https://api.github.com/users/nats-io/following{/other_user}","gists_url":"https://api.github.com/users/nats-io/gists{/gist_id}","starred_url":"https://api.github.com/users/nats-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nats-io/subscriptions","organizations_url":"https://api.github.com/users/nats-io/orgs","repos_url":"https://api.github.com/users/nats-io/repos","events_url":"https://api.github.com/users/nats-io/events{/privacy}","received_events_url":"https://api.github.com/users/nats-io/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nats-io/go-nats","description":"Golang client for NATS, the cloud native messaging system.","fork":false,"url":"https://api.github.com/repos/nats-io/go-nats","forks_url":"https://api.github.com/repos/nats-io/go-nats/forks","keys_url":"https://api.github.com/repos/nats-io/go-nats/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nats-io/go-nats/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nats-io/go-nats/teams","hooks_url":"https://api.github.com/repos/nats-io/go-nats/hooks","issue_events_url":"https://api.github.com/repos/nats-io/go-nats/issues/events{/number}","events_url":"https://api.github.com/repos/nats-io/go-nats/events","assignees_url":"https://api.github.com/repos/nats-io/go-nats/assignees{/user}","branches_url":"https://api.github.com/repos/nats-io/go-nats/branches{/branch}","tags_url":"https://api.github.com/repos/nats-io/go-nats/tags","blobs_url":"https://api.github.com/repos/nats-io/go-nats/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nats-io/go-nats/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nats-io/go-nats/git/refs{/sha}","trees_url":"https://api.github.com/repos/nats-io/go-nats/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nats-io/go-nats/statuses/{sha}","languages_url":"https://api.github.com/repos/nats-io/go-nats/languages","stargazers_url":"https://api.github.com/repos/nats-io/go-nats/stargazers","contributors_url":"https://api.github.com/repos/nats-io/go-nats/contributors","subscribers_url":"https://api.github.com/repos/nats-io/go-nats/subscribers","subscription_url":"https://api.github.com/repos/nats-io/go-nats/subscription","commits_url":"https://api.github.com/repos/nats-io/go-nats/commits{/sha}","git_commits_url":"https://api.github.com/repos/nats-io/go-nats/git/commits{/sha}","comments_url":"https://api.github.com/repos/nats-io/go-nats/comments{/number}","issue_comment_url":"https://api.github.com/repos/nats-io/go-nats/issues/comments{/number}","contents_url":"https://api.github.com/repos/nats-io/go-nats/contents/{+path}","compare_url":"https://api.github.com/repos/nats-io/go-nats/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nats-io/go-nats/merges","archive_url":"https://api.github.com/repos/nats-io/go-nats/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nats-io/go-nats/downloads","issues_url":"https://api.github.com/repos/nats-io/go-nats/issues{/number}","pulls_url":"https://api.github.com/repos/nats-io/go-nats/pulls{/number}","milestones_url":"https://api.github.com/repos/nats-io/go-nats/milestones{/number}","notifications_url":"https://api.github.com/repos/nats-io/go-nats/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nats-io/go-nats/labels{/name}","releases_url":"https://api.github.com/repos/nats-io/go-nats/releases{/id}","deployments_url":"https://api.github.com/repos/nats-io/go-nats/deployments","created_at":"2012-08-15T12:54:59Z","updated_at":"2018-03-06T15:27:30Z","pushed_at":"2018-03-06T19:28:09Z","git_url":"git://github.com/nats-io/go-nats.git","ssh_url":"[email protected]:nats-io/go-nats.git","clone_url":"https://github.com/nats-io/go-nats.git","svn_url":"https://github.com/nats-io/go-nats","homepage":"https://nats.io","size":999,"stargazers_count":1518,"watchers_count":1518,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":202,"mirror_url":null,"archived":false,"open_issues_count":9,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":202,"open_issues":9,"watchers":1518,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nats-io/go-nats/pulls/348"},"html":{"href":"https://github.com/nats-io/go-nats/pull/348"},"issue":{"href":"https://api.github.com/repos/nats-io/go-nats/issues/348"},"comments":{"href":"https://api.github.com/repos/nats-io/go-nats/issues/348/comments"},"review_comments":{"href":"https://api.github.com/repos/nats-io/go-nats/pulls/348/comments"},"review_comment":{"href":"https://api.github.com/repos/nats-io/go-nats/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nats-io/go-nats/pulls/348/commits"},"statuses":{"href":"https://api.github.com/repos/nats-io/go-nats/statuses/15952d72a55d0f498ce7b1f744d9cf63e9940cc1"}},"author_association":"MEMBER"}} | {
"id": 5425992,
"name": "nats-io/go-nats",
"url": "https://api.github.com/repos/nats-io/go-nats"
} | {
"id": 13736691,
"login": "kozlovic",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/13736691?",
"url": "https://api.github.com/users/kozlovic"
} | {
"id": 10203055,
"login": "nats-io",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/10203055?",
"url": "https://api.github.com/orgs/nats-io"
} | 2018-03-06T19:30:45 | 7339821652 | {"actor":{"display_login":"kozlovic"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/valhalla/valhalla/pulls/comments/192877073","pull_request_review_id":125738619,"id":192877073,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5Mjg3NzA3Mw==","diff_hunk":"@@ -0,0 +1,94 @@\n+package valhalla;\n+\n+message Waypoint {\n+ optional float lat = 1;\n+ optional float lon = 2;\n+ optional string type = 3;\n+ optional uint32 bearing = 4;\n+ optional string name = 5;\n+ optional string street = 6;\n+ optional string side_of_street = 7;\n+}\n+\n+message BoundingBox {\n+ optional float min_lat = 1;\n+ optional float min_lon = 2;\n+ optional float max_lat = 3;\n+ optional float max_lon = 4;\n+}\n+\n+message StreetName {\n+ optional string text = 1; // Text of street name, examples: MD 43 East, White Marsh Boulevard \n+ optional bool is_ref = 2; // true if street name is a ref, examples: true, false\n+}\n+\n+message Step {\n+ optional float distance = 1;\n+ optional uint32 duration = 2;\n+ optional uint32 geometry_index_begin = 3; // begin geometry inclusive index\n+ optional uint32 geometry_index_end = 4; // end geometry inclusive index\n+ optional uint32 maneuver_index_begin = 5; // the index of the maneuver at the start of the step\n+ optional uint32 maneuver_index_end = 6; // the index of the maneuver at the end of the step\n+ repeated StreetName street_names = 7; // consistent street names for the entire step\n+ optional string travel_mode = 8; // travel mode \n+ optional string travel_mode_type = 9; // travel type\n+ optional string driving_side = 10; // legal driving side for this step\n+}\n+ \n+message SignElement {\n+ optional string text = 1; // The actual sign element text, example: I 95 North\n+ optional bool is_ref = 2; // true if sign element is a ref, example: true \n+ optional uint32 consecutive_count = 3; // The frequency of this sign element within a set a consecutive signs\n+}\n+\n+message Sign {\n+ repeated SignElement exit_number_elements = 1; // The list of exit numbers, example: 67B\n+ repeated SignElement exit_branch_elements = 2; // The list of exit branch street names, example: I 95 North\n+ repeated SignElement exit_toward_elements = 3; // The list of exit toward locations, example: New York\n+ repeated SignElement exit_name_elements = 4; // The list of exit names - not used much in US, example: Gettysburg Pike\n+}\n+\n+message Lane {\n+ optional bool valid = 1;","path":"proto/directions.proto","position":null,"original_position":52,"commit_id":"d8250faac57f2c37593eedb44febe72e8788bbe4","original_commit_id":"ae3b18f9b6af11746b744e98d5d3024497735e30","user":{"login":"dgearhart","id":7515853,"node_id":"MDQ6VXNlcjc1MTU4NTM=","avatar_url":"https://avatars3.githubusercontent.com/u/7515853?v=4","gravatar_id":"","url":"https://api.github.com/users/dgearhart","html_url":"https://github.com/dgearhart","followers_url":"https://api.github.com/users/dgearhart/followers","following_url":"https://api.github.com/users/dgearhart/following{/other_user}","gists_url":"https://api.github.com/users/dgearhart/gists{/gist_id}","starred_url":"https://api.github.com/users/dgearhart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgearhart/subscriptions","organizations_url":"https://api.github.com/users/dgearhart/orgs","repos_url":"https://api.github.com/users/dgearhart/repos","events_url":"https://api.github.com/users/dgearhart/events{/privacy}","received_events_url":"https://api.github.com/users/dgearhart/received_events","type":"User","site_admin":false},"body":"Updated","created_at":"2018-06-04T20:53:50Z","updated_at":"2018-06-04T20:53:50Z","html_url":"https://github.com/valhalla/valhalla/pull/1335#discussion_r192877073","pull_request_url":"https://api.github.com/repos/valhalla/valhalla/pulls/1335","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/valhalla/valhalla/pulls/comments/192877073"},"html":{"href":"https://github.com/valhalla/valhalla/pull/1335#discussion_r192877073"},"pull_request":{"href":"https://api.github.com/repos/valhalla/valhalla/pulls/1335"}},"in_reply_to_id":192749326},"pull_request":{"url":"https://api.github.com/repos/valhalla/valhalla/pulls/1335","id":192172214,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkyMTcyMjE0","html_url":"https://github.com/valhalla/valhalla/pull/1335","diff_url":"https://github.com/valhalla/valhalla/pull/1335.diff","patch_url":"https://github.com/valhalla/valhalla/pull/1335.patch","issue_url":"https://api.github.com/repos/valhalla/valhalla/issues/1335","number":1335,"state":"open","locked":false,"title":"[WIP] Added draft version of directions pbf response","user":{"login":"dgearhart","id":7515853,"node_id":"MDQ6VXNlcjc1MTU4NTM=","avatar_url":"https://avatars3.githubusercontent.com/u/7515853?v=4","gravatar_id":"","url":"https://api.github.com/users/dgearhart","html_url":"https://github.com/dgearhart","followers_url":"https://api.github.com/users/dgearhart/followers","following_url":"https://api.github.com/users/dgearhart/following{/other_user}","gists_url":"https://api.github.com/users/dgearhart/gists{/gist_id}","starred_url":"https://api.github.com/users/dgearhart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgearhart/subscriptions","organizations_url":"https://api.github.com/users/dgearhart/orgs","repos_url":"https://api.github.com/users/dgearhart/repos","events_url":"https://api.github.com/users/dgearhart/events{/privacy}","received_events_url":"https://api.github.com/users/dgearhart/received_events","type":"User","site_admin":false},"body":"# Issue\r\n\r\nCreated draft version of directions pbf response for us to discuss\r\n\r\n## Tasklist\r\n\r\n - [ ] do not merge - review only\r\n\r\n","created_at":"2018-06-02T01:27:09Z","updated_at":"2018-06-04T20:53:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3e79086fbe8d0859ff7878b698204fb652480d2f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/valhalla/valhalla/pulls/1335/commits","review_comments_url":"https://api.github.com/repos/valhalla/valhalla/pulls/1335/comments","review_comment_url":"https://api.github.com/repos/valhalla/valhalla/pulls/comments{/number}","comments_url":"https://api.github.com/repos/valhalla/valhalla/issues/1335/comments","statuses_url":"https://api.github.com/repos/valhalla/valhalla/statuses/d8250faac57f2c37593eedb44febe72e8788bbe4","head":{"label":"valhalla:proto_response","ref":"proto_response","sha":"d8250faac57f2c37593eedb44febe72e8788bbe4","user":{"login":"valhalla","id":10232331,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMjMyMzMx","avatar_url":"https://avatars1.githubusercontent.com/u/10232331?v=4","gravatar_id":"","url":"https://api.github.com/users/valhalla","html_url":"https://github.com/valhalla","followers_url":"https://api.github.com/users/valhalla/followers","following_url":"https://api.github.com/users/valhalla/following{/other_user}","gists_url":"https://api.github.com/users/valhalla/gists{/gist_id}","starred_url":"https://api.github.com/users/valhalla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/valhalla/subscriptions","organizations_url":"https://api.github.com/users/valhalla/orgs","repos_url":"https://api.github.com/users/valhalla/repos","events_url":"https://api.github.com/users/valhalla/events{/privacy}","received_events_url":"https://api.github.com/users/valhalla/received_events","type":"Organization","site_admin":false},"repo":{"id":49978193,"node_id":"MDEwOlJlcG9zaXRvcnk0OTk3ODE5Mw==","name":"valhalla","full_name":"valhalla/valhalla","owner":{"login":"valhalla","id":10232331,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMjMyMzMx","avatar_url":"https://avatars1.githubusercontent.com/u/10232331?v=4","gravatar_id":"","url":"https://api.github.com/users/valhalla","html_url":"https://github.com/valhalla","followers_url":"https://api.github.com/users/valhalla/followers","following_url":"https://api.github.com/users/valhalla/following{/other_user}","gists_url":"https://api.github.com/users/valhalla/gists{/gist_id}","starred_url":"https://api.github.com/users/valhalla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/valhalla/subscriptions","organizations_url":"https://api.github.com/users/valhalla/orgs","repos_url":"https://api.github.com/users/valhalla/repos","events_url":"https://api.github.com/users/valhalla/events{/privacy}","received_events_url":"https://api.github.com/users/valhalla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/valhalla/valhalla","description":"Open Source Routing Engine for OpenStreetMap","fork":false,"url":"https://api.github.com/repos/valhalla/valhalla","forks_url":"https://api.github.com/repos/valhalla/valhalla/forks","keys_url":"https://api.github.com/repos/valhalla/valhalla/keys{/key_id}","collaborators_url":"https://api.github.com/repos/valhalla/valhalla/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/valhalla/valhalla/teams","hooks_url":"https://api.github.com/repos/valhalla/valhalla/hooks","issue_events_url":"https://api.github.com/repos/valhalla/valhalla/issues/events{/number}","events_url":"https://api.github.com/repos/valhalla/valhalla/events","assignees_url":"https://api.github.com/repos/valhalla/valhalla/assignees{/user}","branches_url":"https://api.github.com/repos/valhalla/valhalla/branches{/branch}","tags_url":"https://api.github.com/repos/valhalla/valhalla/tags","blobs_url":"https://api.github.com/repos/valhalla/valhalla/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/valhalla/valhalla/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/valhalla/valhalla/git/refs{/sha}","trees_url":"https://api.github.com/repos/valhalla/valhalla/git/trees{/sha}","statuses_url":"https://api.github.com/repos/valhalla/valhalla/statuses/{sha}","languages_url":"https://api.github.com/repos/valhalla/valhalla/languages","stargazers_url":"https://api.github.com/repos/valhalla/valhalla/stargazers","contributors_url":"https://api.github.com/repos/valhalla/valhalla/contributors","subscribers_url":"https://api.github.com/repos/valhalla/valhalla/subscribers","subscription_url":"https://api.github.com/repos/valhalla/valhalla/subscription","commits_url":"https://api.github.com/repos/valhalla/valhalla/commits{/sha}","git_commits_url":"https://api.github.com/repos/valhalla/valhalla/git/commits{/sha}","comments_url":"https://api.github.com/repos/valhalla/valhalla/comments{/number}","issue_comment_url":"https://api.github.com/repos/valhalla/valhalla/issues/comments{/number}","contents_url":"https://api.github.com/repos/valhalla/valhalla/contents/{+path}","compare_url":"https://api.github.com/repos/valhalla/valhalla/compare/{base}...{head}","merges_url":"https://api.github.com/repos/valhalla/valhalla/merges","archive_url":"https://api.github.com/repos/valhalla/valhalla/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/valhalla/valhalla/downloads","issues_url":"https://api.github.com/repos/valhalla/valhalla/issues{/number}","pulls_url":"https://api.github.com/repos/valhalla/valhalla/pulls{/number}","milestones_url":"https://api.github.com/repos/valhalla/valhalla/milestones{/number}","notifications_url":"https://api.github.com/repos/valhalla/valhalla/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/valhalla/valhalla/labels{/name}","releases_url":"https://api.github.com/repos/valhalla/valhalla/releases{/id}","deployments_url":"https://api.github.com/repos/valhalla/valhalla/deployments","created_at":"2016-01-19T19:42:29Z","updated_at":"2018-06-04T20:02:40Z","pushed_at":"2018-06-04T20:53:38Z","git_url":"git://github.com/valhalla/valhalla.git","ssh_url":"[email protected]:valhalla/valhalla.git","clone_url":"https://github.com/valhalla/valhalla.git","svn_url":"https://github.com/valhalla/valhalla","homepage":"","size":96263,"stargazers_count":617,"watchers_count":617,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":121,"mirror_url":null,"archived":false,"open_issues_count":251,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":121,"open_issues":251,"watchers":617,"default_branch":"master"}},"base":{"label":"valhalla:master","ref":"master","sha":"7b9386ffe7590efe832adf799afccf40fd907d17","user":{"login":"valhalla","id":10232331,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMjMyMzMx","avatar_url":"https://avatars1.githubusercontent.com/u/10232331?v=4","gravatar_id":"","url":"https://api.github.com/users/valhalla","html_url":"https://github.com/valhalla","followers_url":"https://api.github.com/users/valhalla/followers","following_url":"https://api.github.com/users/valhalla/following{/other_user}","gists_url":"https://api.github.com/users/valhalla/gists{/gist_id}","starred_url":"https://api.github.com/users/valhalla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/valhalla/subscriptions","organizations_url":"https://api.github.com/users/valhalla/orgs","repos_url":"https://api.github.com/users/valhalla/repos","events_url":"https://api.github.com/users/valhalla/events{/privacy}","received_events_url":"https://api.github.com/users/valhalla/received_events","type":"Organization","site_admin":false},"repo":{"id":49978193,"node_id":"MDEwOlJlcG9zaXRvcnk0OTk3ODE5Mw==","name":"valhalla","full_name":"valhalla/valhalla","owner":{"login":"valhalla","id":10232331,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMjMyMzMx","avatar_url":"https://avatars1.githubusercontent.com/u/10232331?v=4","gravatar_id":"","url":"https://api.github.com/users/valhalla","html_url":"https://github.com/valhalla","followers_url":"https://api.github.com/users/valhalla/followers","following_url":"https://api.github.com/users/valhalla/following{/other_user}","gists_url":"https://api.github.com/users/valhalla/gists{/gist_id}","starred_url":"https://api.github.com/users/valhalla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/valhalla/subscriptions","organizations_url":"https://api.github.com/users/valhalla/orgs","repos_url":"https://api.github.com/users/valhalla/repos","events_url":"https://api.github.com/users/valhalla/events{/privacy}","received_events_url":"https://api.github.com/users/valhalla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/valhalla/valhalla","description":"Open Source Routing Engine for OpenStreetMap","fork":false,"url":"https://api.github.com/repos/valhalla/valhalla","forks_url":"https://api.github.com/repos/valhalla/valhalla/forks","keys_url":"https://api.github.com/repos/valhalla/valhalla/keys{/key_id}","collaborators_url":"https://api.github.com/repos/valhalla/valhalla/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/valhalla/valhalla/teams","hooks_url":"https://api.github.com/repos/valhalla/valhalla/hooks","issue_events_url":"https://api.github.com/repos/valhalla/valhalla/issues/events{/number}","events_url":"https://api.github.com/repos/valhalla/valhalla/events","assignees_url":"https://api.github.com/repos/valhalla/valhalla/assignees{/user}","branches_url":"https://api.github.com/repos/valhalla/valhalla/branches{/branch}","tags_url":"https://api.github.com/repos/valhalla/valhalla/tags","blobs_url":"https://api.github.com/repos/valhalla/valhalla/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/valhalla/valhalla/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/valhalla/valhalla/git/refs{/sha}","trees_url":"https://api.github.com/repos/valhalla/valhalla/git/trees{/sha}","statuses_url":"https://api.github.com/repos/valhalla/valhalla/statuses/{sha}","languages_url":"https://api.github.com/repos/valhalla/valhalla/languages","stargazers_url":"https://api.github.com/repos/valhalla/valhalla/stargazers","contributors_url":"https://api.github.com/repos/valhalla/valhalla/contributors","subscribers_url":"https://api.github.com/repos/valhalla/valhalla/subscribers","subscription_url":"https://api.github.com/repos/valhalla/valhalla/subscription","commits_url":"https://api.github.com/repos/valhalla/valhalla/commits{/sha}","git_commits_url":"https://api.github.com/repos/valhalla/valhalla/git/commits{/sha}","comments_url":"https://api.github.com/repos/valhalla/valhalla/comments{/number}","issue_comment_url":"https://api.github.com/repos/valhalla/valhalla/issues/comments{/number}","contents_url":"https://api.github.com/repos/valhalla/valhalla/contents/{+path}","compare_url":"https://api.github.com/repos/valhalla/valhalla/compare/{base}...{head}","merges_url":"https://api.github.com/repos/valhalla/valhalla/merges","archive_url":"https://api.github.com/repos/valhalla/valhalla/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/valhalla/valhalla/downloads","issues_url":"https://api.github.com/repos/valhalla/valhalla/issues{/number}","pulls_url":"https://api.github.com/repos/valhalla/valhalla/pulls{/number}","milestones_url":"https://api.github.com/repos/valhalla/valhalla/milestones{/number}","notifications_url":"https://api.github.com/repos/valhalla/valhalla/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/valhalla/valhalla/labels{/name}","releases_url":"https://api.github.com/repos/valhalla/valhalla/releases{/id}","deployments_url":"https://api.github.com/repos/valhalla/valhalla/deployments","created_at":"2016-01-19T19:42:29Z","updated_at":"2018-06-04T20:02:40Z","pushed_at":"2018-06-04T20:53:38Z","git_url":"git://github.com/valhalla/valhalla.git","ssh_url":"[email protected]:valhalla/valhalla.git","clone_url":"https://github.com/valhalla/valhalla.git","svn_url":"https://github.com/valhalla/valhalla","homepage":"","size":96263,"stargazers_count":617,"watchers_count":617,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":121,"mirror_url":null,"archived":false,"open_issues_count":251,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":121,"open_issues":251,"watchers":617,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/valhalla/valhalla/pulls/1335"},"html":{"href":"https://github.com/valhalla/valhalla/pull/1335"},"issue":{"href":"https://api.github.com/repos/valhalla/valhalla/issues/1335"},"comments":{"href":"https://api.github.com/repos/valhalla/valhalla/issues/1335/comments"},"review_comments":{"href":"https://api.github.com/repos/valhalla/valhalla/pulls/1335/comments"},"review_comment":{"href":"https://api.github.com/repos/valhalla/valhalla/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/valhalla/valhalla/pulls/1335/commits"},"statuses":{"href":"https://api.github.com/repos/valhalla/valhalla/statuses/d8250faac57f2c37593eedb44febe72e8788bbe4"}},"author_association":"MEMBER"}} | {
"id": 49978193,
"name": "valhalla/valhalla",
"url": "https://api.github.com/repos/valhalla/valhalla"
} | {
"id": 7515853,
"login": "dgearhart",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7515853?",
"url": "https://api.github.com/users/dgearhart"
} | {
"id": 10232331,
"login": "valhalla",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/10232331?",
"url": "https://api.github.com/orgs/valhalla"
} | 2018-06-04T20:53:50 | 7774299132 | {"actor":{"display_login":"dgearhart"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/softdevteam/grammars/pulls/comments/179814255","pull_request_review_id":110132603,"id":179814255,"diff_hunk":"@@ -98,13 +98,13 @@ instanceof INSTANCEOF\n \\|= OREQ\r\n \r\n [0-9]+\\.[0-9]*([eE][+-]?[0-9]+)?[fFdD]?|\\.[0-9]+([eE][+-]?[0-9]+)?[fFdD]?|[0-9]+[eE][+-]?[0-9]+[fFdD]?|[0-9]+[fFdD] FLOATING_POINT_LITERAL\r\n-(0_[0-7]+|0b[01]+|0x[0-9A-Fa-f]+|[0-9]+)[lL]? INTEGER_LITERAL\r\n+(0_[0-7]+|[0-9][0-9_]+[0-9]|0b[01]+|0[xX][0-9A-Fa-f]+|[0-9]+)[lL]? INTEGER_LITERAL\r","path":"java7/java.l","position":null,"original_position":5,"commit_id":"6f577e872a00c1ab43a2e99b555a800fd92ea878","original_commit_id":"61a9eac2938881dd9aaab41324388ef6b103610a","user":{"login":"ptersilie","id":375552,"avatar_url":"https://avatars1.githubusercontent.com/u/375552?v=4","gravatar_id":"","url":"https://api.github.com/users/ptersilie","html_url":"https://github.com/ptersilie","followers_url":"https://api.github.com/users/ptersilie/followers","following_url":"https://api.github.com/users/ptersilie/following{/other_user}","gists_url":"https://api.github.com/users/ptersilie/gists{/gist_id}","starred_url":"https://api.github.com/users/ptersilie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ptersilie/subscriptions","organizations_url":"https://api.github.com/users/ptersilie/orgs","repos_url":"https://api.github.com/users/ptersilie/repos","events_url":"https://api.github.com/users/ptersilie/events{/privacy}","received_events_url":"https://api.github.com/users/ptersilie/received_events","type":"User","site_admin":false},"body":"Good spot. I only fixed the ones that flagged up when parsing the standard library.","created_at":"2018-04-06T16:45:47Z","updated_at":"2018-04-06T16:45:47Z","html_url":"https://github.com/softdevteam/grammars/pull/1#discussion_r179814255","pull_request_url":"https://api.github.com/repos/softdevteam/grammars/pulls/1","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/softdevteam/grammars/pulls/comments/179814255"},"html":{"href":"https://github.com/softdevteam/grammars/pull/1#discussion_r179814255"},"pull_request":{"href":"https://api.github.com/repos/softdevteam/grammars/pulls/1"}},"in_reply_to_id":179810929},"pull_request":{"url":"https://api.github.com/repos/softdevteam/grammars/pulls/1","id":179956006,"html_url":"https://github.com/softdevteam/grammars/pull/1","diff_url":"https://github.com/softdevteam/grammars/pull/1.diff","patch_url":"https://github.com/softdevteam/grammars/pull/1.patch","issue_url":"https://api.github.com/repos/softdevteam/grammars/issues/1","number":1,"state":"open","locked":false,"title":"Add Java7 grammar","user":{"login":"ptersilie","id":375552,"avatar_url":"https://avatars1.githubusercontent.com/u/375552?v=4","gravatar_id":"","url":"https://api.github.com/users/ptersilie","html_url":"https://github.com/ptersilie","followers_url":"https://api.github.com/users/ptersilie/followers","following_url":"https://api.github.com/users/ptersilie/following{/other_user}","gists_url":"https://api.github.com/users/ptersilie/gists{/gist_id}","starred_url":"https://api.github.com/users/ptersilie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ptersilie/subscriptions","organizations_url":"https://api.github.com/users/ptersilie/orgs","repos_url":"https://api.github.com/users/ptersilie/repos","events_url":"https://api.github.com/users/ptersilie/events{/privacy}","received_events_url":"https://api.github.com/users/ptersilie/received_events","type":"User","site_admin":false},"body":"This updates our Java5 grammar to Java7.","created_at":"2018-04-06T13:56:23Z","updated_at":"2018-04-06T16:45:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9f7343f9f390e14492a52fb25e2baa455bbfed8c","assignee":{"login":"ltratt","id":20318,"avatar_url":"https://avatars1.githubusercontent.com/u/20318?v=4","gravatar_id":"","url":"https://api.github.com/users/ltratt","html_url":"https://github.com/ltratt","followers_url":"https://api.github.com/users/ltratt/followers","following_url":"https://api.github.com/users/ltratt/following{/other_user}","gists_url":"https://api.github.com/users/ltratt/gists{/gist_id}","starred_url":"https://api.github.com/users/ltratt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ltratt/subscriptions","organizations_url":"https://api.github.com/users/ltratt/orgs","repos_url":"https://api.github.com/users/ltratt/repos","events_url":"https://api.github.com/users/ltratt/events{/privacy}","received_events_url":"https://api.github.com/users/ltratt/received_events","type":"User","site_admin":false},"assignees":[{"login":"ltratt","id":20318,"avatar_url":"https://avatars1.githubusercontent.com/u/20318?v=4","gravatar_id":"","url":"https://api.github.com/users/ltratt","html_url":"https://github.com/ltratt","followers_url":"https://api.github.com/users/ltratt/followers","following_url":"https://api.github.com/users/ltratt/following{/other_user}","gists_url":"https://api.github.com/users/ltratt/gists{/gist_id}","starred_url":"https://api.github.com/users/ltratt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ltratt/subscriptions","organizations_url":"https://api.github.com/users/ltratt/orgs","repos_url":"https://api.github.com/users/ltratt/repos","events_url":"https://api.github.com/users/ltratt/events{/privacy}","received_events_url":"https://api.github.com/users/ltratt/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/softdevteam/grammars/pulls/1/commits","review_comments_url":"https://api.github.com/repos/softdevteam/grammars/pulls/1/comments","review_comment_url":"https://api.github.com/repos/softdevteam/grammars/pulls/comments{/number}","comments_url":"https://api.github.com/repos/softdevteam/grammars/issues/1/comments","statuses_url":"https://api.github.com/repos/softdevteam/grammars/statuses/6f577e872a00c1ab43a2e99b555a800fd92ea878","head":{"label":"softdevteam:java7","ref":"java7","sha":"6f577e872a00c1ab43a2e99b555a800fd92ea878","user":{"login":"softdevteam","id":10271085,"avatar_url":"https://avatars0.githubusercontent.com/u/10271085?v=4","gravatar_id":"","url":"https://api.github.com/users/softdevteam","html_url":"https://github.com/softdevteam","followers_url":"https://api.github.com/users/softdevteam/followers","following_url":"https://api.github.com/users/softdevteam/following{/other_user}","gists_url":"https://api.github.com/users/softdevteam/gists{/gist_id}","starred_url":"https://api.github.com/users/softdevteam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/softdevteam/subscriptions","organizations_url":"https://api.github.com/users/softdevteam/orgs","repos_url":"https://api.github.com/users/softdevteam/repos","events_url":"https://api.github.com/users/softdevteam/events{/privacy}","received_events_url":"https://api.github.com/users/softdevteam/received_events","type":"Organization","site_admin":false},"repo":{"id":126499610,"name":"grammars","full_name":"softdevteam/grammars","owner":{"login":"softdevteam","id":10271085,"avatar_url":"https://avatars0.githubusercontent.com/u/10271085?v=4","gravatar_id":"","url":"https://api.github.com/users/softdevteam","html_url":"https://github.com/softdevteam","followers_url":"https://api.github.com/users/softdevteam/followers","following_url":"https://api.github.com/users/softdevteam/following{/other_user}","gists_url":"https://api.github.com/users/softdevteam/gists{/gist_id}","starred_url":"https://api.github.com/users/softdevteam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/softdevteam/subscriptions","organizations_url":"https://api.github.com/users/softdevteam/orgs","repos_url":"https://api.github.com/users/softdevteam/repos","events_url":"https://api.github.com/users/softdevteam/events{/privacy}","received_events_url":"https://api.github.com/users/softdevteam/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/softdevteam/grammars","description":"A collection of language grammars for `lrpar`","fork":false,"url":"https://api.github.com/repos/softdevteam/grammars","forks_url":"https://api.github.com/repos/softdevteam/grammars/forks","keys_url":"https://api.github.com/repos/softdevteam/grammars/keys{/key_id}","collaborators_url":"https://api.github.com/repos/softdevteam/grammars/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/softdevteam/grammars/teams","hooks_url":"https://api.github.com/repos/softdevteam/grammars/hooks","issue_events_url":"https://api.github.com/repos/softdevteam/grammars/issues/events{/number}","events_url":"https://api.github.com/repos/softdevteam/grammars/events","assignees_url":"https://api.github.com/repos/softdevteam/grammars/assignees{/user}","branches_url":"https://api.github.com/repos/softdevteam/grammars/branches{/branch}","tags_url":"https://api.github.com/repos/softdevteam/grammars/tags","blobs_url":"https://api.github.com/repos/softdevteam/grammars/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/softdevteam/grammars/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/softdevteam/grammars/git/refs{/sha}","trees_url":"https://api.github.com/repos/softdevteam/grammars/git/trees{/sha}","statuses_url":"https://api.github.com/repos/softdevteam/grammars/statuses/{sha}","languages_url":"https://api.github.com/repos/softdevteam/grammars/languages","stargazers_url":"https://api.github.com/repos/softdevteam/grammars/stargazers","contributors_url":"https://api.github.com/repos/softdevteam/grammars/contributors","subscribers_url":"https://api.github.com/repos/softdevteam/grammars/subscribers","subscription_url":"https://api.github.com/repos/softdevteam/grammars/subscription","commits_url":"https://api.github.com/repos/softdevteam/grammars/commits{/sha}","git_commits_url":"https://api.github.com/repos/softdevteam/grammars/git/commits{/sha}","comments_url":"https://api.github.com/repos/softdevteam/grammars/comments{/number}","issue_comment_url":"https://api.github.com/repos/softdevteam/grammars/issues/comments{/number}","contents_url":"https://api.github.com/repos/softdevteam/grammars/contents/{+path}","compare_url":"https://api.github.com/repos/softdevteam/grammars/compare/{base}...{head}","merges_url":"https://api.github.com/repos/softdevteam/grammars/merges","archive_url":"https://api.github.com/repos/softdevteam/grammars/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/softdevteam/grammars/downloads","issues_url":"https://api.github.com/repos/softdevteam/grammars/issues{/number}","pulls_url":"https://api.github.com/repos/softdevteam/grammars/pulls{/number}","milestones_url":"https://api.github.com/repos/softdevteam/grammars/milestones{/number}","notifications_url":"https://api.github.com/repos/softdevteam/grammars/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/softdevteam/grammars/labels{/name}","releases_url":"https://api.github.com/repos/softdevteam/grammars/releases{/id}","deployments_url":"https://api.github.com/repos/softdevteam/grammars/deployments","created_at":"2018-03-23T14:52:22Z","updated_at":"2018-03-23T17:39:16Z","pushed_at":"2018-04-06T13:56:24Z","git_url":"git://github.com/softdevteam/grammars.git","ssh_url":"[email protected]:softdevteam/grammars.git","clone_url":"https://github.com/softdevteam/grammars.git","svn_url":"https://github.com/softdevteam/grammars","homepage":null,"size":37,"stargazers_count":0,"watchers_count":0,"language":"Yacc","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"softdevteam:master","ref":"master","sha":"9878d80391b6e358b50e8e4d4b2874a35d23eee5","user":{"login":"softdevteam","id":10271085,"avatar_url":"https://avatars0.githubusercontent.com/u/10271085?v=4","gravatar_id":"","url":"https://api.github.com/users/softdevteam","html_url":"https://github.com/softdevteam","followers_url":"https://api.github.com/users/softdevteam/followers","following_url":"https://api.github.com/users/softdevteam/following{/other_user}","gists_url":"https://api.github.com/users/softdevteam/gists{/gist_id}","starred_url":"https://api.github.com/users/softdevteam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/softdevteam/subscriptions","organizations_url":"https://api.github.com/users/softdevteam/orgs","repos_url":"https://api.github.com/users/softdevteam/repos","events_url":"https://api.github.com/users/softdevteam/events{/privacy}","received_events_url":"https://api.github.com/users/softdevteam/received_events","type":"Organization","site_admin":false},"repo":{"id":126499610,"name":"grammars","full_name":"softdevteam/grammars","owner":{"login":"softdevteam","id":10271085,"avatar_url":"https://avatars0.githubusercontent.com/u/10271085?v=4","gravatar_id":"","url":"https://api.github.com/users/softdevteam","html_url":"https://github.com/softdevteam","followers_url":"https://api.github.com/users/softdevteam/followers","following_url":"https://api.github.com/users/softdevteam/following{/other_user}","gists_url":"https://api.github.com/users/softdevteam/gists{/gist_id}","starred_url":"https://api.github.com/users/softdevteam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/softdevteam/subscriptions","organizations_url":"https://api.github.com/users/softdevteam/orgs","repos_url":"https://api.github.com/users/softdevteam/repos","events_url":"https://api.github.com/users/softdevteam/events{/privacy}","received_events_url":"https://api.github.com/users/softdevteam/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/softdevteam/grammars","description":"A collection of language grammars for `lrpar`","fork":false,"url":"https://api.github.com/repos/softdevteam/grammars","forks_url":"https://api.github.com/repos/softdevteam/grammars/forks","keys_url":"https://api.github.com/repos/softdevteam/grammars/keys{/key_id}","collaborators_url":"https://api.github.com/repos/softdevteam/grammars/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/softdevteam/grammars/teams","hooks_url":"https://api.github.com/repos/softdevteam/grammars/hooks","issue_events_url":"https://api.github.com/repos/softdevteam/grammars/issues/events{/number}","events_url":"https://api.github.com/repos/softdevteam/grammars/events","assignees_url":"https://api.github.com/repos/softdevteam/grammars/assignees{/user}","branches_url":"https://api.github.com/repos/softdevteam/grammars/branches{/branch}","tags_url":"https://api.github.com/repos/softdevteam/grammars/tags","blobs_url":"https://api.github.com/repos/softdevteam/grammars/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/softdevteam/grammars/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/softdevteam/grammars/git/refs{/sha}","trees_url":"https://api.github.com/repos/softdevteam/grammars/git/trees{/sha}","statuses_url":"https://api.github.com/repos/softdevteam/grammars/statuses/{sha}","languages_url":"https://api.github.com/repos/softdevteam/grammars/languages","stargazers_url":"https://api.github.com/repos/softdevteam/grammars/stargazers","contributors_url":"https://api.github.com/repos/softdevteam/grammars/contributors","subscribers_url":"https://api.github.com/repos/softdevteam/grammars/subscribers","subscription_url":"https://api.github.com/repos/softdevteam/grammars/subscription","commits_url":"https://api.github.com/repos/softdevteam/grammars/commits{/sha}","git_commits_url":"https://api.github.com/repos/softdevteam/grammars/git/commits{/sha}","comments_url":"https://api.github.com/repos/softdevteam/grammars/comments{/number}","issue_comment_url":"https://api.github.com/repos/softdevteam/grammars/issues/comments{/number}","contents_url":"https://api.github.com/repos/softdevteam/grammars/contents/{+path}","compare_url":"https://api.github.com/repos/softdevteam/grammars/compare/{base}...{head}","merges_url":"https://api.github.com/repos/softdevteam/grammars/merges","archive_url":"https://api.github.com/repos/softdevteam/grammars/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/softdevteam/grammars/downloads","issues_url":"https://api.github.com/repos/softdevteam/grammars/issues{/number}","pulls_url":"https://api.github.com/repos/softdevteam/grammars/pulls{/number}","milestones_url":"https://api.github.com/repos/softdevteam/grammars/milestones{/number}","notifications_url":"https://api.github.com/repos/softdevteam/grammars/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/softdevteam/grammars/labels{/name}","releases_url":"https://api.github.com/repos/softdevteam/grammars/releases{/id}","deployments_url":"https://api.github.com/repos/softdevteam/grammars/deployments","created_at":"2018-03-23T14:52:22Z","updated_at":"2018-03-23T17:39:16Z","pushed_at":"2018-04-06T13:56:24Z","git_url":"git://github.com/softdevteam/grammars.git","ssh_url":"[email protected]:softdevteam/grammars.git","clone_url":"https://github.com/softdevteam/grammars.git","svn_url":"https://github.com/softdevteam/grammars","homepage":null,"size":37,"stargazers_count":0,"watchers_count":0,"language":"Yacc","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/softdevteam/grammars/pulls/1"},"html":{"href":"https://github.com/softdevteam/grammars/pull/1"},"issue":{"href":"https://api.github.com/repos/softdevteam/grammars/issues/1"},"comments":{"href":"https://api.github.com/repos/softdevteam/grammars/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/softdevteam/grammars/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/softdevteam/grammars/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/softdevteam/grammars/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/softdevteam/grammars/statuses/6f577e872a00c1ab43a2e99b555a800fd92ea878"}},"author_association":"OWNER"}} | {
"id": 126499610,
"name": "softdevteam/grammars",
"url": "https://api.github.com/repos/softdevteam/grammars"
} | {
"id": 375552,
"login": "ptersilie",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/375552?",
"url": "https://api.github.com/users/ptersilie"
} | {
"id": 10271085,
"login": "softdevteam",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/10271085?",
"url": "https://api.github.com/orgs/softdevteam"
} | 2018-04-06T16:45:47 | 7492015559 | {"actor":{"display_login":"ptersilie"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/softdevteam/diffract/pulls/comments/171793012","pull_request_review_id":100708828,"id":171793012,"diff_hunk":"@@ -0,0 +1,86 @@\n+// Copyright (c) 2018 King's College London\n+// created by the Software Development Team <http://soft-dev.org/>\n+//\n+// The Universal Permissive License (UPL), Version 1.0\n+//\n+// Subject to the condition set forth below, permission is hereby granted to any\n+// person obtaining a copy of this software, associated documentation and/or\n+// data (collectively the \"Software\"), free of charge and under any and all\n+// copyright rights in the Software, and any and all patent rights owned or\n+// freely licensable by each licensor hereunder covering either (i) the\n+// unmodified Software as contributed to or provided by such licensor, or (ii)\n+// the Larger Works (as defined below), to deal in both\n+//\n+// (a) the Software, and\n+// (b) any piece of software and/or hardware listed in the lrgrwrks.txt file\n+// if one is included with the Software (each a \"Larger Work\" to which the Software\n+// is contributed by such licensors),\n+//\n+// without restriction, including without limitation the rights to copy, create\n+// derivative works of, display, perform, and distribute the Software and make,\n+// use, sell, offer for sale, import, export, have made, and have sold the\n+// Software and the Larger Work(s), and to sublicense the foregoing rights on\n+// either these or other terms.\n+//\n+// This license is subject to the following condition: The above copyright\n+// notice and either this complete permission notice or at a minimum a reference\n+// to the UPL must be included in all copies or substantial portions of the\n+// Software.\n+//\n+// THE SOFTWARE IS PROVIDED \"AS IS\", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR\n+// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,\n+// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE\n+// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER\n+// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,\n+// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE\n+// SOFTWARE.\n+\n+//! Code common to several integration tests.\n+#![warn(missing_docs)]\n+\n+extern crate diffract;\n+\n+use diffract::edit_script::{Chawathe96Config, EditScriptGenerator};\n+use diffract::matchers::MatchTrees;\n+use diffract::parser::{get_lexer, get_parser, parse_file};\n+\n+/// Check that the Chawathe 1996 edit script generator correctly generates an\n+/// edit script for two files and a given matcher.\n+pub fn check_files(path1: &str, path2: &str, matcher: Box<MatchTrees<String>>) {\n+ // Lex and parse the input files.","path":"tests/common.rs","position":50,"original_position":50,"commit_id":"dd75f78ad3f735538b1ce0c00b32473865fc10c7","original_commit_id":"98a0ff4da673cedb932c1668fb3645eb0cad9b66","user":{"login":"ltratt","id":20318,"avatar_url":"https://avatars1.githubusercontent.com/u/20318?v=4","gravatar_id":"","url":"https://api.github.com/users/ltratt","html_url":"https://github.com/ltratt","followers_url":"https://api.github.com/users/ltratt/followers","following_url":"https://api.github.com/users/ltratt/following{/other_user}","gists_url":"https://api.github.com/users/ltratt/gists{/gist_id}","starred_url":"https://api.github.com/users/ltratt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ltratt/subscriptions","organizations_url":"https://api.github.com/users/ltratt/orgs","repos_url":"https://api.github.com/users/ltratt/repos","events_url":"https://api.github.com/users/ltratt/events{/privacy}","received_events_url":"https://api.github.com/users/ltratt/received_events","type":"User","site_admin":false},"body":"Not sure this comment is necessary.","created_at":"2018-03-02T09:00:36Z","updated_at":"2018-03-02T09:00:36Z","html_url":"https://github.com/softdevteam/diffract/pull/81#discussion_r171793012","pull_request_url":"https://api.github.com/repos/softdevteam/diffract/pulls/81","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/softdevteam/diffract/pulls/comments/171793012"},"html":{"href":"https://github.com/softdevteam/diffract/pull/81#discussion_r171793012"},"pull_request":{"href":"https://api.github.com/repos/softdevteam/diffract/pulls/81"}}},"pull_request":{"url":"https://api.github.com/repos/softdevteam/diffract/pulls/81","id":171967345,"html_url":"https://github.com/softdevteam/diffract/pull/81","diff_url":"https://github.com/softdevteam/diffract/pull/81.diff","patch_url":"https://github.com/softdevteam/diffract/pull/81.patch","issue_url":"https://api.github.com/repos/softdevteam/diffract/issues/81","number":81,"state":"open","locked":false,"title":"Improve edit script tests","user":{"login":"snim2","id":97674,"avatar_url":"https://avatars2.githubusercontent.com/u/97674?v=4","gravatar_id":"","url":"https://api.github.com/users/snim2","html_url":"https://github.com/snim2","followers_url":"https://api.github.com/users/snim2/followers","following_url":"https://api.github.com/users/snim2/following{/other_user}","gists_url":"https://api.github.com/users/snim2/gists{/gist_id}","starred_url":"https://api.github.com/users/snim2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snim2/subscriptions","organizations_url":"https://api.github.com/users/snim2/orgs","repos_url":"https://api.github.com/users/snim2/repos","events_url":"https://api.github.com/users/snim2/events{/privacy}","received_events_url":"https://api.github.com/users/snim2/received_events","type":"User","site_admin":false},"body":"This PR:\r\n\r\n * Adds some simple unit tests to `edit_script`\r\n * Adds many integration tests to `test_edit_script`\r\n * Factors out code related to parsing (including code for finding lex and yacc files) which is common to several tests and other parts of the code base\r\n * Adds a slow-running integration test which tests every pair of example files in the `tests` directory (test is ignored by default), and thus fixes #68 \r\n\r\nSeveral unit and integration tests are currently failing and ignored by default, these will be fixed in a later PR (many have already been fixed on the `new_edit_script_tests` branch).","created_at":"2018-02-28T14:23:58Z","updated_at":"2018-03-02T09:00:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d2d2e2a6349c541e7a2c63daa7e3f0b6c7e2cc96","assignee":{"login":"ltratt","id":20318,"avatar_url":"https://avatars1.githubusercontent.com/u/20318?v=4","gravatar_id":"","url":"https://api.github.com/users/ltratt","html_url":"https://github.com/ltratt","followers_url":"https://api.github.com/users/ltratt/followers","following_url":"https://api.github.com/users/ltratt/following{/other_user}","gists_url":"https://api.github.com/users/ltratt/gists{/gist_id}","starred_url":"https://api.github.com/users/ltratt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ltratt/subscriptions","organizations_url":"https://api.github.com/users/ltratt/orgs","repos_url":"https://api.github.com/users/ltratt/repos","events_url":"https://api.github.com/users/ltratt/events{/privacy}","received_events_url":"https://api.github.com/users/ltratt/received_events","type":"User","site_admin":false},"assignees":[{"login":"ltratt","id":20318,"avatar_url":"https://avatars1.githubusercontent.com/u/20318?v=4","gravatar_id":"","url":"https://api.github.com/users/ltratt","html_url":"https://github.com/ltratt","followers_url":"https://api.github.com/users/ltratt/followers","following_url":"https://api.github.com/users/ltratt/following{/other_user}","gists_url":"https://api.github.com/users/ltratt/gists{/gist_id}","starred_url":"https://api.github.com/users/ltratt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ltratt/subscriptions","organizations_url":"https://api.github.com/users/ltratt/orgs","repos_url":"https://api.github.com/users/ltratt/repos","events_url":"https://api.github.com/users/ltratt/events{/privacy}","received_events_url":"https://api.github.com/users/ltratt/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/softdevteam/diffract/pulls/81/commits","review_comments_url":"https://api.github.com/repos/softdevteam/diffract/pulls/81/comments","review_comment_url":"https://api.github.com/repos/softdevteam/diffract/pulls/comments{/number}","comments_url":"https://api.github.com/repos/softdevteam/diffract/issues/81/comments","statuses_url":"https://api.github.com/repos/softdevteam/diffract/statuses/dd75f78ad3f735538b1ce0c00b32473865fc10c7","head":{"label":"softdevteam:improve-edit-script-tests","ref":"improve-edit-script-tests","sha":"dd75f78ad3f735538b1ce0c00b32473865fc10c7","user":{"login":"softdevteam","id":10271085,"avatar_url":"https://avatars0.githubusercontent.com/u/10271085?v=4","gravatar_id":"","url":"https://api.github.com/users/softdevteam","html_url":"https://github.com/softdevteam","followers_url":"https://api.github.com/users/softdevteam/followers","following_url":"https://api.github.com/users/softdevteam/following{/other_user}","gists_url":"https://api.github.com/users/softdevteam/gists{/gist_id}","starred_url":"https://api.github.com/users/softdevteam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/softdevteam/subscriptions","organizations_url":"https://api.github.com/users/softdevteam/orgs","repos_url":"https://api.github.com/users/softdevteam/repos","events_url":"https://api.github.com/users/softdevteam/events{/privacy}","received_events_url":"https://api.github.com/users/softdevteam/received_events","type":"Organization","site_admin":false},"repo":{"id":89625138,"name":"diffract","full_name":"softdevteam/diffract","owner":{"login":"softdevteam","id":10271085,"avatar_url":"https://avatars0.githubusercontent.com/u/10271085?v=4","gravatar_id":"","url":"https://api.github.com/users/softdevteam","html_url":"https://github.com/softdevteam","followers_url":"https://api.github.com/users/softdevteam/followers","following_url":"https://api.github.com/users/softdevteam/following{/other_user}","gists_url":"https://api.github.com/users/softdevteam/gists{/gist_id}","starred_url":"https://api.github.com/users/softdevteam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/softdevteam/subscriptions","organizations_url":"https://api.github.com/users/softdevteam/orgs","repos_url":"https://api.github.com/users/softdevteam/repos","events_url":"https://api.github.com/users/softdevteam/events{/privacy}","received_events_url":"https://api.github.com/users/softdevteam/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/softdevteam/diffract","description":"A Rust implementation of the GumTree differ","fork":false,"url":"https://api.github.com/repos/softdevteam/diffract","forks_url":"https://api.github.com/repos/softdevteam/diffract/forks","keys_url":"https://api.github.com/repos/softdevteam/diffract/keys{/key_id}","collaborators_url":"https://api.github.com/repos/softdevteam/diffract/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/softdevteam/diffract/teams","hooks_url":"https://api.github.com/repos/softdevteam/diffract/hooks","issue_events_url":"https://api.github.com/repos/softdevteam/diffract/issues/events{/number}","events_url":"https://api.github.com/repos/softdevteam/diffract/events","assignees_url":"https://api.github.com/repos/softdevteam/diffract/assignees{/user}","branches_url":"https://api.github.com/repos/softdevteam/diffract/branches{/branch}","tags_url":"https://api.github.com/repos/softdevteam/diffract/tags","blobs_url":"https://api.github.com/repos/softdevteam/diffract/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/softdevteam/diffract/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/softdevteam/diffract/git/refs{/sha}","trees_url":"https://api.github.com/repos/softdevteam/diffract/git/trees{/sha}","statuses_url":"https://api.github.com/repos/softdevteam/diffract/statuses/{sha}","languages_url":"https://api.github.com/repos/softdevteam/diffract/languages","stargazers_url":"https://api.github.com/repos/softdevteam/diffract/stargazers","contributors_url":"https://api.github.com/repos/softdevteam/diffract/contributors","subscribers_url":"https://api.github.com/repos/softdevteam/diffract/subscribers","subscription_url":"https://api.github.com/repos/softdevteam/diffract/subscription","commits_url":"https://api.github.com/repos/softdevteam/diffract/commits{/sha}","git_commits_url":"https://api.github.com/repos/softdevteam/diffract/git/commits{/sha}","comments_url":"https://api.github.com/repos/softdevteam/diffract/comments{/number}","issue_comment_url":"https://api.github.com/repos/softdevteam/diffract/issues/comments{/number}","contents_url":"https://api.github.com/repos/softdevteam/diffract/contents/{+path}","compare_url":"https://api.github.com/repos/softdevteam/diffract/compare/{base}...{head}","merges_url":"https://api.github.com/repos/softdevteam/diffract/merges","archive_url":"https://api.github.com/repos/softdevteam/diffract/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/softdevteam/diffract/downloads","issues_url":"https://api.github.com/repos/softdevteam/diffract/issues{/number}","pulls_url":"https://api.github.com/repos/softdevteam/diffract/pulls{/number}","milestones_url":"https://api.github.com/repos/softdevteam/diffract/milestones{/number}","notifications_url":"https://api.github.com/repos/softdevteam/diffract/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/softdevteam/diffract/labels{/name}","releases_url":"https://api.github.com/repos/softdevteam/diffract/releases{/id}","deployments_url":"https://api.github.com/repos/softdevteam/diffract/deployments","created_at":"2017-04-27T17:51:00Z","updated_at":"2017-06-28T23:14:34Z","pushed_at":"2018-03-01T21:06:38Z","git_url":"git://github.com/softdevteam/diffract.git","ssh_url":"[email protected]:softdevteam/diffract.git","clone_url":"https://github.com/softdevteam/diffract.git","svn_url":"https://github.com/softdevteam/diffract","homepage":null,"size":343,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":10,"watchers":0,"default_branch":"master"}},"base":{"label":"softdevteam:master","ref":"master","sha":"c917a38116259790ac78f80d3f9b5991bfca0a05","user":{"login":"softdevteam","id":10271085,"avatar_url":"https://avatars0.githubusercontent.com/u/10271085?v=4","gravatar_id":"","url":"https://api.github.com/users/softdevteam","html_url":"https://github.com/softdevteam","followers_url":"https://api.github.com/users/softdevteam/followers","following_url":"https://api.github.com/users/softdevteam/following{/other_user}","gists_url":"https://api.github.com/users/softdevteam/gists{/gist_id}","starred_url":"https://api.github.com/users/softdevteam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/softdevteam/subscriptions","organizations_url":"https://api.github.com/users/softdevteam/orgs","repos_url":"https://api.github.com/users/softdevteam/repos","events_url":"https://api.github.com/users/softdevteam/events{/privacy}","received_events_url":"https://api.github.com/users/softdevteam/received_events","type":"Organization","site_admin":false},"repo":{"id":89625138,"name":"diffract","full_name":"softdevteam/diffract","owner":{"login":"softdevteam","id":10271085,"avatar_url":"https://avatars0.githubusercontent.com/u/10271085?v=4","gravatar_id":"","url":"https://api.github.com/users/softdevteam","html_url":"https://github.com/softdevteam","followers_url":"https://api.github.com/users/softdevteam/followers","following_url":"https://api.github.com/users/softdevteam/following{/other_user}","gists_url":"https://api.github.com/users/softdevteam/gists{/gist_id}","starred_url":"https://api.github.com/users/softdevteam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/softdevteam/subscriptions","organizations_url":"https://api.github.com/users/softdevteam/orgs","repos_url":"https://api.github.com/users/softdevteam/repos","events_url":"https://api.github.com/users/softdevteam/events{/privacy}","received_events_url":"https://api.github.com/users/softdevteam/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/softdevteam/diffract","description":"A Rust implementation of the GumTree differ","fork":false,"url":"https://api.github.com/repos/softdevteam/diffract","forks_url":"https://api.github.com/repos/softdevteam/diffract/forks","keys_url":"https://api.github.com/repos/softdevteam/diffract/keys{/key_id}","collaborators_url":"https://api.github.com/repos/softdevteam/diffract/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/softdevteam/diffract/teams","hooks_url":"https://api.github.com/repos/softdevteam/diffract/hooks","issue_events_url":"https://api.github.com/repos/softdevteam/diffract/issues/events{/number}","events_url":"https://api.github.com/repos/softdevteam/diffract/events","assignees_url":"https://api.github.com/repos/softdevteam/diffract/assignees{/user}","branches_url":"https://api.github.com/repos/softdevteam/diffract/branches{/branch}","tags_url":"https://api.github.com/repos/softdevteam/diffract/tags","blobs_url":"https://api.github.com/repos/softdevteam/diffract/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/softdevteam/diffract/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/softdevteam/diffract/git/refs{/sha}","trees_url":"https://api.github.com/repos/softdevteam/diffract/git/trees{/sha}","statuses_url":"https://api.github.com/repos/softdevteam/diffract/statuses/{sha}","languages_url":"https://api.github.com/repos/softdevteam/diffract/languages","stargazers_url":"https://api.github.com/repos/softdevteam/diffract/stargazers","contributors_url":"https://api.github.com/repos/softdevteam/diffract/contributors","subscribers_url":"https://api.github.com/repos/softdevteam/diffract/subscribers","subscription_url":"https://api.github.com/repos/softdevteam/diffract/subscription","commits_url":"https://api.github.com/repos/softdevteam/diffract/commits{/sha}","git_commits_url":"https://api.github.com/repos/softdevteam/diffract/git/commits{/sha}","comments_url":"https://api.github.com/repos/softdevteam/diffract/comments{/number}","issue_comment_url":"https://api.github.com/repos/softdevteam/diffract/issues/comments{/number}","contents_url":"https://api.github.com/repos/softdevteam/diffract/contents/{+path}","compare_url":"https://api.github.com/repos/softdevteam/diffract/compare/{base}...{head}","merges_url":"https://api.github.com/repos/softdevteam/diffract/merges","archive_url":"https://api.github.com/repos/softdevteam/diffract/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/softdevteam/diffract/downloads","issues_url":"https://api.github.com/repos/softdevteam/diffract/issues{/number}","pulls_url":"https://api.github.com/repos/softdevteam/diffract/pulls{/number}","milestones_url":"https://api.github.com/repos/softdevteam/diffract/milestones{/number}","notifications_url":"https://api.github.com/repos/softdevteam/diffract/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/softdevteam/diffract/labels{/name}","releases_url":"https://api.github.com/repos/softdevteam/diffract/releases{/id}","deployments_url":"https://api.github.com/repos/softdevteam/diffract/deployments","created_at":"2017-04-27T17:51:00Z","updated_at":"2017-06-28T23:14:34Z","pushed_at":"2018-03-01T21:06:38Z","git_url":"git://github.com/softdevteam/diffract.git","ssh_url":"[email protected]:softdevteam/diffract.git","clone_url":"https://github.com/softdevteam/diffract.git","svn_url":"https://github.com/softdevteam/diffract","homepage":null,"size":343,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":10,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/softdevteam/diffract/pulls/81"},"html":{"href":"https://github.com/softdevteam/diffract/pull/81"},"issue":{"href":"https://api.github.com/repos/softdevteam/diffract/issues/81"},"comments":{"href":"https://api.github.com/repos/softdevteam/diffract/issues/81/comments"},"review_comments":{"href":"https://api.github.com/repos/softdevteam/diffract/pulls/81/comments"},"review_comment":{"href":"https://api.github.com/repos/softdevteam/diffract/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/softdevteam/diffract/pulls/81/commits"},"statuses":{"href":"https://api.github.com/repos/softdevteam/diffract/statuses/dd75f78ad3f735538b1ce0c00b32473865fc10c7"}},"author_association":"OWNER"}} | {
"id": 89625138,
"name": "softdevteam/diffract",
"url": "https://api.github.com/repos/softdevteam/diffract"
} | {
"id": 20318,
"login": "ltratt",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/20318?",
"url": "https://api.github.com/users/ltratt"
} | {
"id": 10271085,
"login": "softdevteam",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/10271085?",
"url": "https://api.github.com/orgs/softdevteam"
} | 2018-03-02T09:00:36 | 7320788521 | {"actor":{"display_login":"ltratt"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/bitcoinxt/bitcoinxt/pulls/comments/170162394","pull_request_review_id":98807706,"id":170162394,"diff_hunk":"@@ -4956,7 +4958,7 @@ bool ProcessMessage(CNode* pfrom, string strCommand, CDataStream& vRecv,\n else if (pfrom->nVersion == 0)\n {\n // Must have a version message before anything else\n- Misbehaving(pfrom->GetId(), 1);\n+ Misbehaving(pfrom->GetId(), 1, \"version not sent\");","path":"src/main.cpp","position":74,"original_position":74,"commit_id":"ff749a137c229e099d7d3acde29453377ecac20a","original_commit_id":"ff749a137c229e099d7d3acde29453377ecac20a","user":{"login":"dgenr8","id":4284124,"avatar_url":"https://avatars1.githubusercontent.com/u/4284124?v=4","gravatar_id":"","url":"https://api.github.com/users/dgenr8","html_url":"https://github.com/dgenr8","followers_url":"https://api.github.com/users/dgenr8/followers","following_url":"https://api.github.com/users/dgenr8/following{/other_user}","gists_url":"https://api.github.com/users/dgenr8/gists{/gist_id}","starred_url":"https://api.github.com/users/dgenr8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgenr8/subscriptions","organizations_url":"https://api.github.com/users/dgenr8/orgs","repos_url":"https://api.github.com/users/dgenr8/repos","events_url":"https://api.github.com/users/dgenr8/events{/privacy}","received_events_url":"https://api.github.com/users/dgenr8/received_events","type":"User","site_admin":false},"body":"\"no version received\" ?","created_at":"2018-02-23T04:05:59Z","updated_at":"2018-02-23T04:09:34Z","html_url":"https://github.com/bitcoinxt/bitcoinxt/pull/341#discussion_r170162394","pull_request_url":"https://api.github.com/repos/bitcoinxt/bitcoinxt/pulls/341","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/bitcoinxt/bitcoinxt/pulls/comments/170162394"},"html":{"href":"https://github.com/bitcoinxt/bitcoinxt/pull/341#discussion_r170162394"},"pull_request":{"href":"https://api.github.com/repos/bitcoinxt/bitcoinxt/pulls/341"}}},"pull_request":{"url":"https://api.github.com/repos/bitcoinxt/bitcoinxt/pulls/341","id":170556291,"html_url":"https://github.com/bitcoinxt/bitcoinxt/pull/341","diff_url":"https://github.com/bitcoinxt/bitcoinxt/pull/341.diff","patch_url":"https://github.com/bitcoinxt/bitcoinxt/pull/341.patch","issue_url":"https://api.github.com/repos/bitcoinxt/bitcoinxt/issues/341","number":341,"state":"open","locked":false,"title":"Add misbehave reason to Misbehave","user":{"login":"dagurval","id":92707,"avatar_url":"https://avatars2.githubusercontent.com/u/92707?v=4","gravatar_id":"","url":"https://api.github.com/users/dagurval","html_url":"https://github.com/dagurval","followers_url":"https://api.github.com/users/dagurval/followers","following_url":"https://api.github.com/users/dagurval/following{/other_user}","gists_url":"https://api.github.com/users/dagurval/gists{/gist_id}","starred_url":"https://api.github.com/users/dagurval/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dagurval/subscriptions","organizations_url":"https://api.github.com/users/dagurval/orgs","repos_url":"https://api.github.com/users/dagurval/repos","events_url":"https://api.github.com/users/dagurval/events{/privacy}","received_events_url":"https://api.github.com/users/dagurval/received_events","type":"User","site_admin":false},"body":"To simplify debugging","created_at":"2018-02-21T18:49:26Z","updated_at":"2018-02-23T04:09:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"72398b1620663df2becb7abf4e946124c1773832","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/bitcoinxt/bitcoinxt/pulls/341/commits","review_comments_url":"https://api.github.com/repos/bitcoinxt/bitcoinxt/pulls/341/comments","review_comment_url":"https://api.github.com/repos/bitcoinxt/bitcoinxt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bitcoinxt/bitcoinxt/issues/341/comments","statuses_url":"https://api.github.com/repos/bitcoinxt/bitcoinxt/statuses/ff749a137c229e099d7d3acde29453377ecac20a","head":{"label":"dagurval:misbehaving-descr","ref":"misbehaving-descr","sha":"ff749a137c229e099d7d3acde29453377ecac20a","user":{"login":"dagurval","id":92707,"avatar_url":"https://avatars2.githubusercontent.com/u/92707?v=4","gravatar_id":"","url":"https://api.github.com/users/dagurval","html_url":"https://github.com/dagurval","followers_url":"https://api.github.com/users/dagurval/followers","following_url":"https://api.github.com/users/dagurval/following{/other_user}","gists_url":"https://api.github.com/users/dagurval/gists{/gist_id}","starred_url":"https://api.github.com/users/dagurval/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dagurval/subscriptions","organizations_url":"https://api.github.com/users/dagurval/orgs","repos_url":"https://api.github.com/users/dagurval/repos","events_url":"https://api.github.com/users/dagurval/events{/privacy}","received_events_url":"https://api.github.com/users/dagurval/received_events","type":"User","site_admin":false},"repo":{"id":41377829,"name":"bitcoinxt","full_name":"dagurval/bitcoinxt","owner":{"login":"dagurval","id":92707,"avatar_url":"https://avatars2.githubusercontent.com/u/92707?v=4","gravatar_id":"","url":"https://api.github.com/users/dagurval","html_url":"https://github.com/dagurval","followers_url":"https://api.github.com/users/dagurval/followers","following_url":"https://api.github.com/users/dagurval/following{/other_user}","gists_url":"https://api.github.com/users/dagurval/gists{/gist_id}","starred_url":"https://api.github.com/users/dagurval/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dagurval/subscriptions","organizations_url":"https://api.github.com/users/dagurval/orgs","repos_url":"https://api.github.com/users/dagurval/repos","events_url":"https://api.github.com/users/dagurval/events{/privacy}","received_events_url":"https://api.github.com/users/dagurval/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dagurval/bitcoinxt","description":null,"fork":true,"url":"https://api.github.com/repos/dagurval/bitcoinxt","forks_url":"https://api.github.com/repos/dagurval/bitcoinxt/forks","keys_url":"https://api.github.com/repos/dagurval/bitcoinxt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dagurval/bitcoinxt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dagurval/bitcoinxt/teams","hooks_url":"https://api.github.com/repos/dagurval/bitcoinxt/hooks","issue_events_url":"https://api.github.com/repos/dagurval/bitcoinxt/issues/events{/number}","events_url":"https://api.github.com/repos/dagurval/bitcoinxt/events","assignees_url":"https://api.github.com/repos/dagurval/bitcoinxt/assignees{/user}","branches_url":"https://api.github.com/repos/dagurval/bitcoinxt/branches{/branch}","tags_url":"https://api.github.com/repos/dagurval/bitcoinxt/tags","blobs_url":"https://api.github.com/repos/dagurval/bitcoinxt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dagurval/bitcoinxt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dagurval/bitcoinxt/git/refs{/sha}","trees_url":"https://api.github.com/repos/dagurval/bitcoinxt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dagurval/bitcoinxt/statuses/{sha}","languages_url":"https://api.github.com/repos/dagurval/bitcoinxt/languages","stargazers_url":"https://api.github.com/repos/dagurval/bitcoinxt/stargazers","contributors_url":"https://api.github.com/repos/dagurval/bitcoinxt/contributors","subscribers_url":"https://api.github.com/repos/dagurval/bitcoinxt/subscribers","subscription_url":"https://api.github.com/repos/dagurval/bitcoinxt/subscription","commits_url":"https://api.github.com/repos/dagurval/bitcoinxt/commits{/sha}","git_commits_url":"https://api.github.com/repos/dagurval/bitcoinxt/git/commits{/sha}","comments_url":"https://api.github.com/repos/dagurval/bitcoinxt/comments{/number}","issue_comment_url":"https://api.github.com/repos/dagurval/bitcoinxt/issues/comments{/number}","contents_url":"https://api.github.com/repos/dagurval/bitcoinxt/contents/{+path}","compare_url":"https://api.github.com/repos/dagurval/bitcoinxt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dagurval/bitcoinxt/merges","archive_url":"https://api.github.com/repos/dagurval/bitcoinxt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dagurval/bitcoinxt/downloads","issues_url":"https://api.github.com/repos/dagurval/bitcoinxt/issues{/number}","pulls_url":"https://api.github.com/repos/dagurval/bitcoinxt/pulls{/number}","milestones_url":"https://api.github.com/repos/dagurval/bitcoinxt/milestones{/number}","notifications_url":"https://api.github.com/repos/dagurval/bitcoinxt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dagurval/bitcoinxt/labels{/name}","releases_url":"https://api.github.com/repos/dagurval/bitcoinxt/releases{/id}","deployments_url":"https://api.github.com/repos/dagurval/bitcoinxt/deployments","created_at":"2015-08-25T17:28:55Z","updated_at":"2016-01-12T20:17:09Z","pushed_at":"2018-02-22T13:33:22Z","git_url":"git://github.com/dagurval/bitcoinxt.git","ssh_url":"[email protected]:dagurval/bitcoinxt.git","clone_url":"https://github.com/dagurval/bitcoinxt.git","svn_url":"https://github.com/dagurval/bitcoinxt","homepage":null,"size":44272,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bitcoinxt:master","ref":"master","sha":"9fd52b9b412480902c5aed8c0eb82efb9e12fbf2","user":{"login":"bitcoinxt","id":10281400,"avatar_url":"https://avatars3.githubusercontent.com/u/10281400?v=4","gravatar_id":"","url":"https://api.github.com/users/bitcoinxt","html_url":"https://github.com/bitcoinxt","followers_url":"https://api.github.com/users/bitcoinxt/followers","following_url":"https://api.github.com/users/bitcoinxt/following{/other_user}","gists_url":"https://api.github.com/users/bitcoinxt/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoinxt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoinxt/subscriptions","organizations_url":"https://api.github.com/users/bitcoinxt/orgs","repos_url":"https://api.github.com/users/bitcoinxt/repos","events_url":"https://api.github.com/users/bitcoinxt/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoinxt/received_events","type":"Organization","site_admin":false},"repo":{"id":28404361,"name":"bitcoinxt","full_name":"bitcoinxt/bitcoinxt","owner":{"login":"bitcoinxt","id":10281400,"avatar_url":"https://avatars3.githubusercontent.com/u/10281400?v=4","gravatar_id":"","url":"https://api.github.com/users/bitcoinxt","html_url":"https://github.com/bitcoinxt","followers_url":"https://api.github.com/users/bitcoinxt/followers","following_url":"https://api.github.com/users/bitcoinxt/following{/other_user}","gists_url":"https://api.github.com/users/bitcoinxt/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoinxt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoinxt/subscriptions","organizations_url":"https://api.github.com/users/bitcoinxt/orgs","repos_url":"https://api.github.com/users/bitcoinxt/repos","events_url":"https://api.github.com/users/bitcoinxt/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoinxt/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bitcoinxt/bitcoinxt","description":"Bitcoin XT. Most recent release is H - Bitcoin Cash 2017 Nov Fork","fork":false,"url":"https://api.github.com/repos/bitcoinxt/bitcoinxt","forks_url":"https://api.github.com/repos/bitcoinxt/bitcoinxt/forks","keys_url":"https://api.github.com/repos/bitcoinxt/bitcoinxt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bitcoinxt/bitcoinxt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bitcoinxt/bitcoinxt/teams","hooks_url":"https://api.github.com/repos/bitcoinxt/bitcoinxt/hooks","issue_events_url":"https://api.github.com/repos/bitcoinxt/bitcoinxt/issues/events{/number}","events_url":"https://api.github.com/repos/bitcoinxt/bitcoinxt/events","assignees_url":"https://api.github.com/repos/bitcoinxt/bitcoinxt/assignees{/user}","branches_url":"https://api.github.com/repos/bitcoinxt/bitcoinxt/branches{/branch}","tags_url":"https://api.github.com/repos/bitcoinxt/bitcoinxt/tags","blobs_url":"https://api.github.com/repos/bitcoinxt/bitcoinxt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bitcoinxt/bitcoinxt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bitcoinxt/bitcoinxt/git/refs{/sha}","trees_url":"https://api.github.com/repos/bitcoinxt/bitcoinxt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bitcoinxt/bitcoinxt/statuses/{sha}","languages_url":"https://api.github.com/repos/bitcoinxt/bitcoinxt/languages","stargazers_url":"https://api.github.com/repos/bitcoinxt/bitcoinxt/stargazers","contributors_url":"https://api.github.com/repos/bitcoinxt/bitcoinxt/contributors","subscribers_url":"https://api.github.com/repos/bitcoinxt/bitcoinxt/subscribers","subscription_url":"https://api.github.com/repos/bitcoinxt/bitcoinxt/subscription","commits_url":"https://api.github.com/repos/bitcoinxt/bitcoinxt/commits{/sha}","git_commits_url":"https://api.github.com/repos/bitcoinxt/bitcoinxt/git/commits{/sha}","comments_url":"https://api.github.com/repos/bitcoinxt/bitcoinxt/comments{/number}","issue_comment_url":"https://api.github.com/repos/bitcoinxt/bitcoinxt/issues/comments{/number}","contents_url":"https://api.github.com/repos/bitcoinxt/bitcoinxt/contents/{+path}","compare_url":"https://api.github.com/repos/bitcoinxt/bitcoinxt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bitcoinxt/bitcoinxt/merges","archive_url":"https://api.github.com/repos/bitcoinxt/bitcoinxt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bitcoinxt/bitcoinxt/downloads","issues_url":"https://api.github.com/repos/bitcoinxt/bitcoinxt/issues{/number}","pulls_url":"https://api.github.com/repos/bitcoinxt/bitcoinxt/pulls{/number}","milestones_url":"https://api.github.com/repos/bitcoinxt/bitcoinxt/milestones{/number}","notifications_url":"https://api.github.com/repos/bitcoinxt/bitcoinxt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bitcoinxt/bitcoinxt/labels{/name}","releases_url":"https://api.github.com/repos/bitcoinxt/bitcoinxt/releases{/id}","deployments_url":"https://api.github.com/repos/bitcoinxt/bitcoinxt/deployments","created_at":"2014-12-23T15:14:51Z","updated_at":"2018-02-20T08:52:48Z","pushed_at":"2018-02-22T13:33:23Z","git_url":"git://github.com/bitcoinxt/bitcoinxt.git","ssh_url":"[email protected]:bitcoinxt/bitcoinxt.git","clone_url":"https://github.com/bitcoinxt/bitcoinxt.git","svn_url":"https://github.com/bitcoinxt/bitcoinxt","homepage":"","size":43065,"stargazers_count":394,"watchers_count":394,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":134,"mirror_url":null,"archived":false,"open_issues_count":34,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":134,"open_issues":34,"watchers":394,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bitcoinxt/bitcoinxt/pulls/341"},"html":{"href":"https://github.com/bitcoinxt/bitcoinxt/pull/341"},"issue":{"href":"https://api.github.com/repos/bitcoinxt/bitcoinxt/issues/341"},"comments":{"href":"https://api.github.com/repos/bitcoinxt/bitcoinxt/issues/341/comments"},"review_comments":{"href":"https://api.github.com/repos/bitcoinxt/bitcoinxt/pulls/341/comments"},"review_comment":{"href":"https://api.github.com/repos/bitcoinxt/bitcoinxt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bitcoinxt/bitcoinxt/pulls/341/commits"},"statuses":{"href":"https://api.github.com/repos/bitcoinxt/bitcoinxt/statuses/ff749a137c229e099d7d3acde29453377ecac20a"}},"author_association":"MEMBER"}} | {
"id": 28404361,
"name": "bitcoinxt/bitcoinxt",
"url": "https://api.github.com/repos/bitcoinxt/bitcoinxt"
} | {
"id": 4284124,
"login": "dgenr8",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4284124?",
"url": "https://api.github.com/users/dgenr8"
} | {
"id": 10281400,
"login": "bitcoinxt",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/10281400?",
"url": "https://api.github.com/orgs/bitcoinxt"
} | 2018-02-23T04:05:59 | 7285437900 | {"actor":{"display_login":"dgenr8"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/MerlinLabs/styled-material-components/pulls/comments/174345912","pull_request_review_id":103684054,"id":174345912,"diff_hunk":"@@ -11,14 +12,44 @@ const StyledCheckbox = Checkbox.extend`\n stroke-width: 5px;\n }\n `;\n+\n+const Square = styled.div`\n+ background-color: ${props => props.theme.primary};\n+ height: 8px;\n+ width: 8px;\n+`;\n+\n+const ABACheckbox = Checkbox.extend`","path":"pages/checkboxes.js","position":17,"original_position":17,"commit_id":"3fd3d4bfa077dcd4bb28ab9e7961e38b48e069b4","original_commit_id":"3fd3d4bfa077dcd4bb28ab9e7961e38b48e069b4","user":{"login":"petegivens","id":6396211,"avatar_url":"https://avatars3.githubusercontent.com/u/6396211?v=4","gravatar_id":"","url":"https://api.github.com/users/petegivens","html_url":"https://github.com/petegivens","followers_url":"https://api.github.com/users/petegivens/followers","following_url":"https://api.github.com/users/petegivens/following{/other_user}","gists_url":"https://api.github.com/users/petegivens/gists{/gist_id}","starred_url":"https://api.github.com/users/petegivens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petegivens/subscriptions","organizations_url":"https://api.github.com/users/petegivens/orgs","repos_url":"https://api.github.com/users/petegivens/repos","events_url":"https://api.github.com/users/petegivens/events{/privacy}","received_events_url":"https://api.github.com/users/petegivens/received_events","type":"User","site_admin":false},"body":"Yes, probably. I plan to redo the whole checkboxes demo page soon so I'll take care of it then if you think it can wait","created_at":"2018-03-14T03:39:33Z","updated_at":"2018-03-14T03:39:33Z","html_url":"https://github.com/MerlinLabs/styled-material-components/pull/201#discussion_r174345912","pull_request_url":"https://api.github.com/repos/MerlinLabs/styled-material-components/pulls/201","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/MerlinLabs/styled-material-components/pulls/comments/174345912"},"html":{"href":"https://github.com/MerlinLabs/styled-material-components/pull/201#discussion_r174345912"},"pull_request":{"href":"https://api.github.com/repos/MerlinLabs/styled-material-components/pulls/201"}},"in_reply_to_id":174342323},"pull_request":{"url":"https://api.github.com/repos/MerlinLabs/styled-material-components/pulls/201","id":174766879,"html_url":"https://github.com/MerlinLabs/styled-material-components/pull/201","diff_url":"https://github.com/MerlinLabs/styled-material-components/pull/201.diff","patch_url":"https://github.com/MerlinLabs/styled-material-components/pull/201.patch","issue_url":"https://api.github.com/repos/MerlinLabs/styled-material-components/issues/201","number":201,"state":"open","locked":false,"title":"enhancement/Checkbox","user":{"login":"petegivens","id":6396211,"avatar_url":"https://avatars3.githubusercontent.com/u/6396211?v=4","gravatar_id":"","url":"https://api.github.com/users/petegivens","html_url":"https://github.com/petegivens","followers_url":"https://api.github.com/users/petegivens/followers","following_url":"https://api.github.com/users/petegivens/following{/other_user}","gists_url":"https://api.github.com/users/petegivens/gists{/gist_id}","starred_url":"https://api.github.com/users/petegivens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petegivens/subscriptions","organizations_url":"https://api.github.com/users/petegivens/orgs","repos_url":"https://api.github.com/users/petegivens/repos","events_url":"https://api.github.com/users/petegivens/events{/privacy}","received_events_url":"https://api.github.com/users/petegivens/received_events","type":"User","site_admin":false},"body":"Add `checkMark` and `indeterminateMark` props so users can pass in their own checkmark icons. Refactored Checkbox component to eliminate unnecessary wrapper div. \r\n\r\nNow Link: https://docs-zypoftzofl.now.sh/checkboxes/","created_at":"2018-03-13T19:32:50Z","updated_at":"2018-03-14T03:39:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d169230cc8f795745bf8a4443ea14b7ece5c3dde","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/MerlinLabs/styled-material-components/pulls/201/commits","review_comments_url":"https://api.github.com/repos/MerlinLabs/styled-material-components/pulls/201/comments","review_comment_url":"https://api.github.com/repos/MerlinLabs/styled-material-components/pulls/comments{/number}","comments_url":"https://api.github.com/repos/MerlinLabs/styled-material-components/issues/201/comments","statuses_url":"https://api.github.com/repos/MerlinLabs/styled-material-components/statuses/3fd3d4bfa077dcd4bb28ab9e7961e38b48e069b4","head":{"label":"petegivens:fix/Checkbox","ref":"fix/Checkbox","sha":"3fd3d4bfa077dcd4bb28ab9e7961e38b48e069b4","user":{"login":"petegivens","id":6396211,"avatar_url":"https://avatars3.githubusercontent.com/u/6396211?v=4","gravatar_id":"","url":"https://api.github.com/users/petegivens","html_url":"https://github.com/petegivens","followers_url":"https://api.github.com/users/petegivens/followers","following_url":"https://api.github.com/users/petegivens/following{/other_user}","gists_url":"https://api.github.com/users/petegivens/gists{/gist_id}","starred_url":"https://api.github.com/users/petegivens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petegivens/subscriptions","organizations_url":"https://api.github.com/users/petegivens/orgs","repos_url":"https://api.github.com/users/petegivens/repos","events_url":"https://api.github.com/users/petegivens/events{/privacy}","received_events_url":"https://api.github.com/users/petegivens/received_events","type":"User","site_admin":false},"repo":{"id":114942217,"name":"styled-material-components","full_name":"petegivens/styled-material-components","owner":{"login":"petegivens","id":6396211,"avatar_url":"https://avatars3.githubusercontent.com/u/6396211?v=4","gravatar_id":"","url":"https://api.github.com/users/petegivens","html_url":"https://github.com/petegivens","followers_url":"https://api.github.com/users/petegivens/followers","following_url":"https://api.github.com/users/petegivens/following{/other_user}","gists_url":"https://api.github.com/users/petegivens/gists{/gist_id}","starred_url":"https://api.github.com/users/petegivens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petegivens/subscriptions","organizations_url":"https://api.github.com/users/petegivens/orgs","repos_url":"https://api.github.com/users/petegivens/repos","events_url":"https://api.github.com/users/petegivens/events{/privacy}","received_events_url":"https://api.github.com/users/petegivens/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/petegivens/styled-material-components","description":"Coming Soon","fork":true,"url":"https://api.github.com/repos/petegivens/styled-material-components","forks_url":"https://api.github.com/repos/petegivens/styled-material-components/forks","keys_url":"https://api.github.com/repos/petegivens/styled-material-components/keys{/key_id}","collaborators_url":"https://api.github.com/repos/petegivens/styled-material-components/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/petegivens/styled-material-components/teams","hooks_url":"https://api.github.com/repos/petegivens/styled-material-components/hooks","issue_events_url":"https://api.github.com/repos/petegivens/styled-material-components/issues/events{/number}","events_url":"https://api.github.com/repos/petegivens/styled-material-components/events","assignees_url":"https://api.github.com/repos/petegivens/styled-material-components/assignees{/user}","branches_url":"https://api.github.com/repos/petegivens/styled-material-components/branches{/branch}","tags_url":"https://api.github.com/repos/petegivens/styled-material-components/tags","blobs_url":"https://api.github.com/repos/petegivens/styled-material-components/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/petegivens/styled-material-components/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/petegivens/styled-material-components/git/refs{/sha}","trees_url":"https://api.github.com/repos/petegivens/styled-material-components/git/trees{/sha}","statuses_url":"https://api.github.com/repos/petegivens/styled-material-components/statuses/{sha}","languages_url":"https://api.github.com/repos/petegivens/styled-material-components/languages","stargazers_url":"https://api.github.com/repos/petegivens/styled-material-components/stargazers","contributors_url":"https://api.github.com/repos/petegivens/styled-material-components/contributors","subscribers_url":"https://api.github.com/repos/petegivens/styled-material-components/subscribers","subscription_url":"https://api.github.com/repos/petegivens/styled-material-components/subscription","commits_url":"https://api.github.com/repos/petegivens/styled-material-components/commits{/sha}","git_commits_url":"https://api.github.com/repos/petegivens/styled-material-components/git/commits{/sha}","comments_url":"https://api.github.com/repos/petegivens/styled-material-components/comments{/number}","issue_comment_url":"https://api.github.com/repos/petegivens/styled-material-components/issues/comments{/number}","contents_url":"https://api.github.com/repos/petegivens/styled-material-components/contents/{+path}","compare_url":"https://api.github.com/repos/petegivens/styled-material-components/compare/{base}...{head}","merges_url":"https://api.github.com/repos/petegivens/styled-material-components/merges","archive_url":"https://api.github.com/repos/petegivens/styled-material-components/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/petegivens/styled-material-components/downloads","issues_url":"https://api.github.com/repos/petegivens/styled-material-components/issues{/number}","pulls_url":"https://api.github.com/repos/petegivens/styled-material-components/pulls{/number}","milestones_url":"https://api.github.com/repos/petegivens/styled-material-components/milestones{/number}","notifications_url":"https://api.github.com/repos/petegivens/styled-material-components/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/petegivens/styled-material-components/labels{/name}","releases_url":"https://api.github.com/repos/petegivens/styled-material-components/releases{/id}","deployments_url":"https://api.github.com/repos/petegivens/styled-material-components/deployments","created_at":"2017-12-20T23:58:04Z","updated_at":"2018-03-13T20:06:59Z","pushed_at":"2018-03-13T20:18:11Z","git_url":"git://github.com/petegivens/styled-material-components.git","ssh_url":"[email protected]:petegivens/styled-material-components.git","clone_url":"https://github.com/petegivens/styled-material-components.git","svn_url":"https://github.com/petegivens/styled-material-components","homepage":"","size":1531,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"MerlinLabs:master","ref":"master","sha":"6e0d597cdbb347a71e2d035f86e90a42619542ff","user":{"login":"MerlinLabs","id":10405966,"avatar_url":"https://avatars3.githubusercontent.com/u/10405966?v=4","gravatar_id":"","url":"https://api.github.com/users/MerlinLabs","html_url":"https://github.com/MerlinLabs","followers_url":"https://api.github.com/users/MerlinLabs/followers","following_url":"https://api.github.com/users/MerlinLabs/following{/other_user}","gists_url":"https://api.github.com/users/MerlinLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/MerlinLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MerlinLabs/subscriptions","organizations_url":"https://api.github.com/users/MerlinLabs/orgs","repos_url":"https://api.github.com/users/MerlinLabs/repos","events_url":"https://api.github.com/users/MerlinLabs/events{/privacy}","received_events_url":"https://api.github.com/users/MerlinLabs/received_events","type":"Organization","site_admin":false},"repo":{"id":92553109,"name":"styled-material-components","full_name":"MerlinLabs/styled-material-components","owner":{"login":"MerlinLabs","id":10405966,"avatar_url":"https://avatars3.githubusercontent.com/u/10405966?v=4","gravatar_id":"","url":"https://api.github.com/users/MerlinLabs","html_url":"https://github.com/MerlinLabs","followers_url":"https://api.github.com/users/MerlinLabs/followers","following_url":"https://api.github.com/users/MerlinLabs/following{/other_user}","gists_url":"https://api.github.com/users/MerlinLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/MerlinLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MerlinLabs/subscriptions","organizations_url":"https://api.github.com/users/MerlinLabs/orgs","repos_url":"https://api.github.com/users/MerlinLabs/repos","events_url":"https://api.github.com/users/MerlinLabs/events{/privacy}","received_events_url":"https://api.github.com/users/MerlinLabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MerlinLabs/styled-material-components","description":"Styled Components implementation of Material Design","fork":false,"url":"https://api.github.com/repos/MerlinLabs/styled-material-components","forks_url":"https://api.github.com/repos/MerlinLabs/styled-material-components/forks","keys_url":"https://api.github.com/repos/MerlinLabs/styled-material-components/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MerlinLabs/styled-material-components/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MerlinLabs/styled-material-components/teams","hooks_url":"https://api.github.com/repos/MerlinLabs/styled-material-components/hooks","issue_events_url":"https://api.github.com/repos/MerlinLabs/styled-material-components/issues/events{/number}","events_url":"https://api.github.com/repos/MerlinLabs/styled-material-components/events","assignees_url":"https://api.github.com/repos/MerlinLabs/styled-material-components/assignees{/user}","branches_url":"https://api.github.com/repos/MerlinLabs/styled-material-components/branches{/branch}","tags_url":"https://api.github.com/repos/MerlinLabs/styled-material-components/tags","blobs_url":"https://api.github.com/repos/MerlinLabs/styled-material-components/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MerlinLabs/styled-material-components/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MerlinLabs/styled-material-components/git/refs{/sha}","trees_url":"https://api.github.com/repos/MerlinLabs/styled-material-components/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MerlinLabs/styled-material-components/statuses/{sha}","languages_url":"https://api.github.com/repos/MerlinLabs/styled-material-components/languages","stargazers_url":"https://api.github.com/repos/MerlinLabs/styled-material-components/stargazers","contributors_url":"https://api.github.com/repos/MerlinLabs/styled-material-components/contributors","subscribers_url":"https://api.github.com/repos/MerlinLabs/styled-material-components/subscribers","subscription_url":"https://api.github.com/repos/MerlinLabs/styled-material-components/subscription","commits_url":"https://api.github.com/repos/MerlinLabs/styled-material-components/commits{/sha}","git_commits_url":"https://api.github.com/repos/MerlinLabs/styled-material-components/git/commits{/sha}","comments_url":"https://api.github.com/repos/MerlinLabs/styled-material-components/comments{/number}","issue_comment_url":"https://api.github.com/repos/MerlinLabs/styled-material-components/issues/comments{/number}","contents_url":"https://api.github.com/repos/MerlinLabs/styled-material-components/contents/{+path}","compare_url":"https://api.github.com/repos/MerlinLabs/styled-material-components/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MerlinLabs/styled-material-components/merges","archive_url":"https://api.github.com/repos/MerlinLabs/styled-material-components/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MerlinLabs/styled-material-components/downloads","issues_url":"https://api.github.com/repos/MerlinLabs/styled-material-components/issues{/number}","pulls_url":"https://api.github.com/repos/MerlinLabs/styled-material-components/pulls{/number}","milestones_url":"https://api.github.com/repos/MerlinLabs/styled-material-components/milestones{/number}","notifications_url":"https://api.github.com/repos/MerlinLabs/styled-material-components/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MerlinLabs/styled-material-components/labels{/name}","releases_url":"https://api.github.com/repos/MerlinLabs/styled-material-components/releases{/id}","deployments_url":"https://api.github.com/repos/MerlinLabs/styled-material-components/deployments","created_at":"2017-05-26T22:31:13Z","updated_at":"2018-03-14T02:31:26Z","pushed_at":"2018-03-14T02:31:24Z","git_url":"git://github.com/MerlinLabs/styled-material-components.git","ssh_url":"[email protected]:MerlinLabs/styled-material-components.git","clone_url":"https://github.com/MerlinLabs/styled-material-components.git","svn_url":"https://github.com/MerlinLabs/styled-material-components","homepage":"","size":1531,"stargazers_count":28,"watchers_count":28,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":39,"mirror_url":null,"archived":false,"open_issues_count":43,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":39,"open_issues":43,"watchers":28,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/MerlinLabs/styled-material-components/pulls/201"},"html":{"href":"https://github.com/MerlinLabs/styled-material-components/pull/201"},"issue":{"href":"https://api.github.com/repos/MerlinLabs/styled-material-components/issues/201"},"comments":{"href":"https://api.github.com/repos/MerlinLabs/styled-material-components/issues/201/comments"},"review_comments":{"href":"https://api.github.com/repos/MerlinLabs/styled-material-components/pulls/201/comments"},"review_comment":{"href":"https://api.github.com/repos/MerlinLabs/styled-material-components/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/MerlinLabs/styled-material-components/pulls/201/commits"},"statuses":{"href":"https://api.github.com/repos/MerlinLabs/styled-material-components/statuses/3fd3d4bfa077dcd4bb28ab9e7961e38b48e069b4"}},"author_association":"CONTRIBUTOR"}} | {
"id": 92553109,
"name": "MerlinLabs/styled-material-components",
"url": "https://api.github.com/repos/MerlinLabs/styled-material-components"
} | {
"id": 6396211,
"login": "petegivens",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6396211?",
"url": "https://api.github.com/users/petegivens"
} | {
"id": 10405966,
"login": "MerlinLabs",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/10405966?",
"url": "https://api.github.com/orgs/MerlinLabs"
} | 2018-03-14T03:39:33 | 7375974166 | {"actor":{"display_login":"petegivens"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/kontena/pharos-cluster/pulls/comments/216589316","pull_request_review_id":154102800,"id":216589316,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNjU4OTMxNg==","diff_hunk":"@@ -0,0 +1,56 @@\n+# frozen_string_literal: true\n+\n+module Pharos\n+ class SSHCommand < UpCommand\n+ usage \"[OPTIONS] -- [COMMANDS] ...\"\n+ parameter \"[COMMAND] ...\", \"Run command on host\"\n+\n+ banner \"Opens SSH sessions to hosts in the Kontena Pharos cluster.\"\n+\n+ option ['-r', '--role'], 'ROLE', 'select a server by role'\n+ option ['-l', '--label'], 'LABEL=VALUE', 'select a server by label, can be specified multiple times', multivalued: true do |pair|\n+ Hash[*[:key, :value].zip(pair.split('=', 2))]\n+ end\n+ option ['-a', '--address'], 'ADDRESS', 'select a server by public address'\n+ option ['-p', '--private-address'], 'ADDRESS', 'select a server by private address'","path":"lib/pharos/ssh_command.rb","position":15,"original_position":15,"commit_id":"976001fda42562f19d7290e86bbede3c59a65c56","original_commit_id":"976001fda42562f19d7290e86bbede3c59a65c56","user":{"login":"jakolehm","id":1446224,"node_id":"MDQ6VXNlcjE0NDYyMjQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1446224?v=4","gravatar_id":"","url":"https://api.github.com/users/jakolehm","html_url":"https://github.com/jakolehm","followers_url":"https://api.github.com/users/jakolehm/followers","following_url":"https://api.github.com/users/jakolehm/following{/other_user}","gists_url":"https://api.github.com/users/jakolehm/gists{/gist_id}","starred_url":"https://api.github.com/users/jakolehm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jakolehm/subscriptions","organizations_url":"https://api.github.com/users/jakolehm/orgs","repos_url":"https://api.github.com/users/jakolehm/repos","events_url":"https://api.github.com/users/jakolehm/events{/privacy}","received_events_url":"https://api.github.com/users/jakolehm/received_events","type":"User","site_admin":false},"body":"Not sure we need `--private-address`?","created_at":"2018-09-11T08:42:21Z","updated_at":"2018-09-11T08:44:55Z","html_url":"https://github.com/kontena/pharos-cluster/pull/581#discussion_r216589316","pull_request_url":"https://api.github.com/repos/kontena/pharos-cluster/pulls/581","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/kontena/pharos-cluster/pulls/comments/216589316"},"html":{"href":"https://github.com/kontena/pharos-cluster/pull/581#discussion_r216589316"},"pull_request":{"href":"https://api.github.com/repos/kontena/pharos-cluster/pulls/581"}}},"pull_request":{"url":"https://api.github.com/repos/kontena/pharos-cluster/pulls/581","id":212303148,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEyMzAzMTQ4","html_url":"https://github.com/kontena/pharos-cluster/pull/581","diff_url":"https://github.com/kontena/pharos-cluster/pull/581.diff","patch_url":"https://github.com/kontena/pharos-cluster/pull/581.patch","issue_url":"https://api.github.com/repos/kontena/pharos-cluster/issues/581","number":581,"state":"open","locked":false,"title":"Add \"pharos ssh\" command to launch ssh into cluster hosts","user":{"login":"kke","id":224971,"node_id":"MDQ6VXNlcjIyNDk3MQ==","avatar_url":"https://avatars1.githubusercontent.com/u/224971?v=4","gravatar_id":"","url":"https://api.github.com/users/kke","html_url":"https://github.com/kke","followers_url":"https://api.github.com/users/kke/followers","following_url":"https://api.github.com/users/kke/following{/other_user}","gists_url":"https://api.github.com/users/kke/gists{/gist_id}","starred_url":"https://api.github.com/users/kke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kke/subscriptions","organizations_url":"https://api.github.com/users/kke/orgs","repos_url":"https://api.github.com/users/kke/repos","events_url":"https://api.github.com/users/kke/events{/privacy}","received_events_url":"https://api.github.com/users/kke/received_events","type":"User","site_admin":false},"body":"Adds \"pharos ssh\" subcommand that can be used to launch a ssh session that connects to a host in the cluster configuration.\r\n\r\nThere are filtering options to select hosts based on roles, labels or their addresses.\r\n\r\n```\r\nUsage:\r\n pharos-cluster ssh [OPTIONS] -- [COMMANDS] ...\r\n\r\n Opens SSH sessions to hosts in the Kontena Pharos cluster.\r\n\r\nParameters:\r\n [COMMAND] ... Run command on host\r\n\r\nOptions:\r\n -r, --role ROLE select a server by role\r\n -l, --label LABEL=VALUE select a server by label, can be specified multiple times\r\n -a, --address ADDRESS select a server by public address\r\n -p, --private-address ADDRESS select a server by private address\r\n -P, --use-private connect to the private address\r\n -f, --first only perform on the first matching host\r\n -h, --help print help\r\n -c, --config PATH path to config file (default: cluster.yml)\r\n --tf-json PATH path to terraform output json\r\n -y, --yes answer automatically yes to prompts\r\n --[no-]color colorize output (default: true)\r\n -v, --version print pharos-cluster version\r\n -d, --debug enable debug output (default: $DEBUG)\r\n```\r\n\r\n```\r\n$ bundle exec bin/pharos-cluster ssh -r master -- ls -al\r\n==> Reading instructions ...\r\n==> Opening a session to [email protected] ..\r\ntotal 36\r\ndrwxr-xr-x 6 vagrant vagrant 4096 Aug 14 07:33 .\r\ndrwxr-xr-x 4 root root 4096 Aug 2 11:11 ..\r\n-rw-r--r-- 1 vagrant vagrant 220 Mar 6 08:30 .bash_logout\r\n-rw-r--r-- 1 vagrant vagrant 3771 Mar 6 08:30 .bashrc\r\ndrwx------ 2 vagrant vagrant 4096 Aug 2 11:11 .cache\r\ndrwx------ 2 root root 4096 Aug 14 07:33 .gnupg\r\ndrwx------ 2 vagrant vagrant 4096 Aug 2 11:51 .kube\r\n-rw-r--r-- 1 vagrant vagrant 655 Mar 6 08:30 .profile\r\ndrwx------ 2 vagrant vagrant 4096 Mar 6 08:30 .ssh\r\n```\r\n","created_at":"2018-08-31T07:57:37Z","updated_at":"2018-09-11T08:44:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"01c649de9252d4ef5e1bca6fd8cb2ba7ad2cc625","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":844668573,"node_id":"MDU6TGFiZWw4NDQ2Njg1NzM=","url":"https://api.github.com/repos/kontena/pharos-cluster/labels/enhancement","name":"enhancement","color":"a2eeef","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/kontena/pharos-cluster/pulls/581/commits","review_comments_url":"https://api.github.com/repos/kontena/pharos-cluster/pulls/581/comments","review_comment_url":"https://api.github.com/repos/kontena/pharos-cluster/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kontena/pharos-cluster/issues/581/comments","statuses_url":"https://api.github.com/repos/kontena/pharos-cluster/statuses/976001fda42562f19d7290e86bbede3c59a65c56","head":{"label":"kontena:feature/pharos_ssh","ref":"feature/pharos_ssh","sha":"976001fda42562f19d7290e86bbede3c59a65c56","user":{"login":"kontena","id":10419574,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNDE5NTc0","avatar_url":"https://avatars2.githubusercontent.com/u/10419574?v=4","gravatar_id":"","url":"https://api.github.com/users/kontena","html_url":"https://github.com/kontena","followers_url":"https://api.github.com/users/kontena/followers","following_url":"https://api.github.com/users/kontena/following{/other_user}","gists_url":"https://api.github.com/users/kontena/gists{/gist_id}","starred_url":"https://api.github.com/users/kontena/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kontena/subscriptions","organizations_url":"https://api.github.com/users/kontena/orgs","repos_url":"https://api.github.com/users/kontena/repos","events_url":"https://api.github.com/users/kontena/events{/privacy}","received_events_url":"https://api.github.com/users/kontena/received_events","type":"Organization","site_admin":false},"repo":{"id":122439193,"node_id":"MDEwOlJlcG9zaXRvcnkxMjI0MzkxOTM=","name":"pharos-cluster","full_name":"kontena/pharos-cluster","owner":{"login":"kontena","id":10419574,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNDE5NTc0","avatar_url":"https://avatars2.githubusercontent.com/u/10419574?v=4","gravatar_id":"","url":"https://api.github.com/users/kontena","html_url":"https://github.com/kontena","followers_url":"https://api.github.com/users/kontena/followers","following_url":"https://api.github.com/users/kontena/following{/other_user}","gists_url":"https://api.github.com/users/kontena/gists{/gist_id}","starred_url":"https://api.github.com/users/kontena/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kontena/subscriptions","organizations_url":"https://api.github.com/users/kontena/orgs","repos_url":"https://api.github.com/users/kontena/repos","events_url":"https://api.github.com/users/kontena/events{/privacy}","received_events_url":"https://api.github.com/users/kontena/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kontena/pharos-cluster","description":"The simple, solid, certified Kubernetes distribution that just works.","fork":false,"url":"https://api.github.com/repos/kontena/pharos-cluster","forks_url":"https://api.github.com/repos/kontena/pharos-cluster/forks","keys_url":"https://api.github.com/repos/kontena/pharos-cluster/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kontena/pharos-cluster/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kontena/pharos-cluster/teams","hooks_url":"https://api.github.com/repos/kontena/pharos-cluster/hooks","issue_events_url":"https://api.github.com/repos/kontena/pharos-cluster/issues/events{/number}","events_url":"https://api.github.com/repos/kontena/pharos-cluster/events","assignees_url":"https://api.github.com/repos/kontena/pharos-cluster/assignees{/user}","branches_url":"https://api.github.com/repos/kontena/pharos-cluster/branches{/branch}","tags_url":"https://api.github.com/repos/kontena/pharos-cluster/tags","blobs_url":"https://api.github.com/repos/kontena/pharos-cluster/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kontena/pharos-cluster/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kontena/pharos-cluster/git/refs{/sha}","trees_url":"https://api.github.com/repos/kontena/pharos-cluster/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kontena/pharos-cluster/statuses/{sha}","languages_url":"https://api.github.com/repos/kontena/pharos-cluster/languages","stargazers_url":"https://api.github.com/repos/kontena/pharos-cluster/stargazers","contributors_url":"https://api.github.com/repos/kontena/pharos-cluster/contributors","subscribers_url":"https://api.github.com/repos/kontena/pharos-cluster/subscribers","subscription_url":"https://api.github.com/repos/kontena/pharos-cluster/subscription","commits_url":"https://api.github.com/repos/kontena/pharos-cluster/commits{/sha}","git_commits_url":"https://api.github.com/repos/kontena/pharos-cluster/git/commits{/sha}","comments_url":"https://api.github.com/repos/kontena/pharos-cluster/comments{/number}","issue_comment_url":"https://api.github.com/repos/kontena/pharos-cluster/issues/comments{/number}","contents_url":"https://api.github.com/repos/kontena/pharos-cluster/contents/{+path}","compare_url":"https://api.github.com/repos/kontena/pharos-cluster/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kontena/pharos-cluster/merges","archive_url":"https://api.github.com/repos/kontena/pharos-cluster/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kontena/pharos-cluster/downloads","issues_url":"https://api.github.com/repos/kontena/pharos-cluster/issues{/number}","pulls_url":"https://api.github.com/repos/kontena/pharos-cluster/pulls{/number}","milestones_url":"https://api.github.com/repos/kontena/pharos-cluster/milestones{/number}","notifications_url":"https://api.github.com/repos/kontena/pharos-cluster/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kontena/pharos-cluster/labels{/name}","releases_url":"https://api.github.com/repos/kontena/pharos-cluster/releases{/id}","deployments_url":"https://api.github.com/repos/kontena/pharos-cluster/deployments","created_at":"2018-02-22T06:23:53Z","updated_at":"2018-09-10T14:10:57Z","pushed_at":"2018-09-05T13:04:54Z","git_url":"git://github.com/kontena/pharos-cluster.git","ssh_url":"[email protected]:kontena/pharos-cluster.git","clone_url":"https://github.com/kontena/pharos-cluster.git","svn_url":"https://github.com/kontena/pharos-cluster","homepage":"https://pharos.sh","size":901,"stargazers_count":120,"watchers_count":120,"language":"Ruby","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":63,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":6,"open_issues":63,"watchers":120,"default_branch":"master"}},"base":{"label":"kontena:master","ref":"master","sha":"5d777bd1ac78ea59b74fc1e609c6a6e0e66985de","user":{"login":"kontena","id":10419574,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNDE5NTc0","avatar_url":"https://avatars2.githubusercontent.com/u/10419574?v=4","gravatar_id":"","url":"https://api.github.com/users/kontena","html_url":"https://github.com/kontena","followers_url":"https://api.github.com/users/kontena/followers","following_url":"https://api.github.com/users/kontena/following{/other_user}","gists_url":"https://api.github.com/users/kontena/gists{/gist_id}","starred_url":"https://api.github.com/users/kontena/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kontena/subscriptions","organizations_url":"https://api.github.com/users/kontena/orgs","repos_url":"https://api.github.com/users/kontena/repos","events_url":"https://api.github.com/users/kontena/events{/privacy}","received_events_url":"https://api.github.com/users/kontena/received_events","type":"Organization","site_admin":false},"repo":{"id":122439193,"node_id":"MDEwOlJlcG9zaXRvcnkxMjI0MzkxOTM=","name":"pharos-cluster","full_name":"kontena/pharos-cluster","owner":{"login":"kontena","id":10419574,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNDE5NTc0","avatar_url":"https://avatars2.githubusercontent.com/u/10419574?v=4","gravatar_id":"","url":"https://api.github.com/users/kontena","html_url":"https://github.com/kontena","followers_url":"https://api.github.com/users/kontena/followers","following_url":"https://api.github.com/users/kontena/following{/other_user}","gists_url":"https://api.github.com/users/kontena/gists{/gist_id}","starred_url":"https://api.github.com/users/kontena/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kontena/subscriptions","organizations_url":"https://api.github.com/users/kontena/orgs","repos_url":"https://api.github.com/users/kontena/repos","events_url":"https://api.github.com/users/kontena/events{/privacy}","received_events_url":"https://api.github.com/users/kontena/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kontena/pharos-cluster","description":"The simple, solid, certified Kubernetes distribution that just works.","fork":false,"url":"https://api.github.com/repos/kontena/pharos-cluster","forks_url":"https://api.github.com/repos/kontena/pharos-cluster/forks","keys_url":"https://api.github.com/repos/kontena/pharos-cluster/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kontena/pharos-cluster/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kontena/pharos-cluster/teams","hooks_url":"https://api.github.com/repos/kontena/pharos-cluster/hooks","issue_events_url":"https://api.github.com/repos/kontena/pharos-cluster/issues/events{/number}","events_url":"https://api.github.com/repos/kontena/pharos-cluster/events","assignees_url":"https://api.github.com/repos/kontena/pharos-cluster/assignees{/user}","branches_url":"https://api.github.com/repos/kontena/pharos-cluster/branches{/branch}","tags_url":"https://api.github.com/repos/kontena/pharos-cluster/tags","blobs_url":"https://api.github.com/repos/kontena/pharos-cluster/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kontena/pharos-cluster/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kontena/pharos-cluster/git/refs{/sha}","trees_url":"https://api.github.com/repos/kontena/pharos-cluster/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kontena/pharos-cluster/statuses/{sha}","languages_url":"https://api.github.com/repos/kontena/pharos-cluster/languages","stargazers_url":"https://api.github.com/repos/kontena/pharos-cluster/stargazers","contributors_url":"https://api.github.com/repos/kontena/pharos-cluster/contributors","subscribers_url":"https://api.github.com/repos/kontena/pharos-cluster/subscribers","subscription_url":"https://api.github.com/repos/kontena/pharos-cluster/subscription","commits_url":"https://api.github.com/repos/kontena/pharos-cluster/commits{/sha}","git_commits_url":"https://api.github.com/repos/kontena/pharos-cluster/git/commits{/sha}","comments_url":"https://api.github.com/repos/kontena/pharos-cluster/comments{/number}","issue_comment_url":"https://api.github.com/repos/kontena/pharos-cluster/issues/comments{/number}","contents_url":"https://api.github.com/repos/kontena/pharos-cluster/contents/{+path}","compare_url":"https://api.github.com/repos/kontena/pharos-cluster/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kontena/pharos-cluster/merges","archive_url":"https://api.github.com/repos/kontena/pharos-cluster/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kontena/pharos-cluster/downloads","issues_url":"https://api.github.com/repos/kontena/pharos-cluster/issues{/number}","pulls_url":"https://api.github.com/repos/kontena/pharos-cluster/pulls{/number}","milestones_url":"https://api.github.com/repos/kontena/pharos-cluster/milestones{/number}","notifications_url":"https://api.github.com/repos/kontena/pharos-cluster/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kontena/pharos-cluster/labels{/name}","releases_url":"https://api.github.com/repos/kontena/pharos-cluster/releases{/id}","deployments_url":"https://api.github.com/repos/kontena/pharos-cluster/deployments","created_at":"2018-02-22T06:23:53Z","updated_at":"2018-09-10T14:10:57Z","pushed_at":"2018-09-05T13:04:54Z","git_url":"git://github.com/kontena/pharos-cluster.git","ssh_url":"[email protected]:kontena/pharos-cluster.git","clone_url":"https://github.com/kontena/pharos-cluster.git","svn_url":"https://github.com/kontena/pharos-cluster","homepage":"https://pharos.sh","size":901,"stargazers_count":120,"watchers_count":120,"language":"Ruby","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":63,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":6,"open_issues":63,"watchers":120,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kontena/pharos-cluster/pulls/581"},"html":{"href":"https://github.com/kontena/pharos-cluster/pull/581"},"issue":{"href":"https://api.github.com/repos/kontena/pharos-cluster/issues/581"},"comments":{"href":"https://api.github.com/repos/kontena/pharos-cluster/issues/581/comments"},"review_comments":{"href":"https://api.github.com/repos/kontena/pharos-cluster/pulls/581/comments"},"review_comment":{"href":"https://api.github.com/repos/kontena/pharos-cluster/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kontena/pharos-cluster/pulls/581/commits"},"statuses":{"href":"https://api.github.com/repos/kontena/pharos-cluster/statuses/976001fda42562f19d7290e86bbede3c59a65c56"}},"author_association":"CONTRIBUTOR"}} | {
"id": 122439193,
"name": "kontena/pharos-cluster",
"url": "https://api.github.com/repos/kontena/pharos-cluster"
} | {
"id": 1446224,
"login": "jakolehm",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1446224?",
"url": "https://api.github.com/users/jakolehm"
} | {
"id": 10419574,
"login": "kontena",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/10419574?",
"url": "https://api.github.com/orgs/kontena"
} | 2018-09-11T08:42:21 | 8245116642 | {"actor":{"display_login":"jakolehm"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/OperationCode/resources_api/pulls/comments/228214335","pull_request_review_id":168435343,"id":228214335,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyODIxNDMzNQ==","diff_hunk":"@@ -43,6 +81,7 @@ export SQLALCHEMY_DATABASE_URI=postgresql://aaron:[email protected]:5432/resour\n If you make changes to the models.py or other schemas, you need to run a migration and upgrade again:\n \n 1. Set the FLASK_APP environment variable `export FLASK_APP=run.py` or `ENV:FLASK_APP = \"run.py\"`\n+- Windows users follow Step 15 in the Windows setup.","path":"README.md","position":null,"original_position":51,"commit_id":"697d5f910a6a388a2ae830cc28388fc46a6280c5","original_commit_id":"1a2fd096eb1a70ec29d6f99122f0a11113347d14","user":{"login":"VeraButler","id":33324650,"node_id":"MDQ6VXNlcjMzMzI0NjUw","avatar_url":"https://avatars3.githubusercontent.com/u/33324650?v=4","gravatar_id":"","url":"https://api.github.com/users/VeraButler","html_url":"https://github.com/VeraButler","followers_url":"https://api.github.com/users/VeraButler/followers","following_url":"https://api.github.com/users/VeraButler/following{/other_user}","gists_url":"https://api.github.com/users/VeraButler/gists{/gist_id}","starred_url":"https://api.github.com/users/VeraButler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VeraButler/subscriptions","organizations_url":"https://api.github.com/users/VeraButler/orgs","repos_url":"https://api.github.com/users/VeraButler/repos","events_url":"https://api.github.com/users/VeraButler/events{/privacy}","received_events_url":"https://api.github.com/users/VeraButler/received_events","type":"User","site_admin":false},"body":"fixed","created_at":"2018-10-25T15:09:18Z","updated_at":"2018-10-25T15:09:18Z","html_url":"https://github.com/OperationCode/resources_api/pull/43#discussion_r228214335","pull_request_url":"https://api.github.com/repos/OperationCode/resources_api/pulls/43","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/OperationCode/resources_api/pulls/comments/228214335"},"html":{"href":"https://github.com/OperationCode/resources_api/pull/43#discussion_r228214335"},"pull_request":{"href":"https://api.github.com/repos/OperationCode/resources_api/pulls/43"}},"in_reply_to_id":228195314},"pull_request":{"url":"https://api.github.com/repos/OperationCode/resources_api/pulls/43","id":224739704,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI0NzM5NzA0","html_url":"https://github.com/OperationCode/resources_api/pull/43","diff_url":"https://github.com/OperationCode/resources_api/pull/43.diff","patch_url":"https://github.com/OperationCode/resources_api/pull/43.patch","issue_url":"https://api.github.com/repos/OperationCode/resources_api/issues/43","number":43,"state":"open","locked":false,"title":"add windows setup README.md","user":{"login":"VeraButler","id":33324650,"node_id":"MDQ6VXNlcjMzMzI0NjUw","avatar_url":"https://avatars3.githubusercontent.com/u/33324650?v=4","gravatar_id":"","url":"https://api.github.com/users/VeraButler","html_url":"https://github.com/VeraButler","followers_url":"https://api.github.com/users/VeraButler/followers","following_url":"https://api.github.com/users/VeraButler/following{/other_user}","gists_url":"https://api.github.com/users/VeraButler/gists{/gist_id}","starred_url":"https://api.github.com/users/VeraButler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VeraButler/subscriptions","organizations_url":"https://api.github.com/users/VeraButler/orgs","repos_url":"https://api.github.com/users/VeraButler/repos","events_url":"https://api.github.com/users/VeraButler/events{/privacy}","received_events_url":"https://api.github.com/users/VeraButler/received_events","type":"User","site_admin":false},"body":"This needs to be tested @aaron-suarez. Long_common_name offered to help on this. \r\n\r\nThis includes Chocolatey install and postgres setup. ","created_at":"2018-10-22T16:39:38Z","updated_at":"2018-10-25T15:09:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"aa8361acb14fff96938492c453af676de0693f08","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/OperationCode/resources_api/pulls/43/commits","review_comments_url":"https://api.github.com/repos/OperationCode/resources_api/pulls/43/comments","review_comment_url":"https://api.github.com/repos/OperationCode/resources_api/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OperationCode/resources_api/issues/43/comments","statuses_url":"https://api.github.com/repos/OperationCode/resources_api/statuses/697d5f910a6a388a2ae830cc28388fc46a6280c5","head":{"label":"VeraButler:issue-31","ref":"issue-31","sha":"697d5f910a6a388a2ae830cc28388fc46a6280c5","user":{"login":"VeraButler","id":33324650,"node_id":"MDQ6VXNlcjMzMzI0NjUw","avatar_url":"https://avatars3.githubusercontent.com/u/33324650?v=4","gravatar_id":"","url":"https://api.github.com/users/VeraButler","html_url":"https://github.com/VeraButler","followers_url":"https://api.github.com/users/VeraButler/followers","following_url":"https://api.github.com/users/VeraButler/following{/other_user}","gists_url":"https://api.github.com/users/VeraButler/gists{/gist_id}","starred_url":"https://api.github.com/users/VeraButler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VeraButler/subscriptions","organizations_url":"https://api.github.com/users/VeraButler/orgs","repos_url":"https://api.github.com/users/VeraButler/repos","events_url":"https://api.github.com/users/VeraButler/events{/privacy}","received_events_url":"https://api.github.com/users/VeraButler/received_events","type":"User","site_admin":false},"repo":{"id":154177331,"node_id":"MDEwOlJlcG9zaXRvcnkxNTQxNzczMzE=","name":"resources_api","full_name":"VeraButler/resources_api","private":false,"owner":{"login":"VeraButler","id":33324650,"node_id":"MDQ6VXNlcjMzMzI0NjUw","avatar_url":"https://avatars3.githubusercontent.com/u/33324650?v=4","gravatar_id":"","url":"https://api.github.com/users/VeraButler","html_url":"https://github.com/VeraButler","followers_url":"https://api.github.com/users/VeraButler/followers","following_url":"https://api.github.com/users/VeraButler/following{/other_user}","gists_url":"https://api.github.com/users/VeraButler/gists{/gist_id}","starred_url":"https://api.github.com/users/VeraButler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VeraButler/subscriptions","organizations_url":"https://api.github.com/users/VeraButler/orgs","repos_url":"https://api.github.com/users/VeraButler/repos","events_url":"https://api.github.com/users/VeraButler/events{/privacy}","received_events_url":"https://api.github.com/users/VeraButler/received_events","type":"User","site_admin":false},"html_url":"https://github.com/VeraButler/resources_api","description":"API for resources.yml","fork":true,"url":"https://api.github.com/repos/VeraButler/resources_api","forks_url":"https://api.github.com/repos/VeraButler/resources_api/forks","keys_url":"https://api.github.com/repos/VeraButler/resources_api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/VeraButler/resources_api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/VeraButler/resources_api/teams","hooks_url":"https://api.github.com/repos/VeraButler/resources_api/hooks","issue_events_url":"https://api.github.com/repos/VeraButler/resources_api/issues/events{/number}","events_url":"https://api.github.com/repos/VeraButler/resources_api/events","assignees_url":"https://api.github.com/repos/VeraButler/resources_api/assignees{/user}","branches_url":"https://api.github.com/repos/VeraButler/resources_api/branches{/branch}","tags_url":"https://api.github.com/repos/VeraButler/resources_api/tags","blobs_url":"https://api.github.com/repos/VeraButler/resources_api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/VeraButler/resources_api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/VeraButler/resources_api/git/refs{/sha}","trees_url":"https://api.github.com/repos/VeraButler/resources_api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/VeraButler/resources_api/statuses/{sha}","languages_url":"https://api.github.com/repos/VeraButler/resources_api/languages","stargazers_url":"https://api.github.com/repos/VeraButler/resources_api/stargazers","contributors_url":"https://api.github.com/repos/VeraButler/resources_api/contributors","subscribers_url":"https://api.github.com/repos/VeraButler/resources_api/subscribers","subscription_url":"https://api.github.com/repos/VeraButler/resources_api/subscription","commits_url":"https://api.github.com/repos/VeraButler/resources_api/commits{/sha}","git_commits_url":"https://api.github.com/repos/VeraButler/resources_api/git/commits{/sha}","comments_url":"https://api.github.com/repos/VeraButler/resources_api/comments{/number}","issue_comment_url":"https://api.github.com/repos/VeraButler/resources_api/issues/comments{/number}","contents_url":"https://api.github.com/repos/VeraButler/resources_api/contents/{+path}","compare_url":"https://api.github.com/repos/VeraButler/resources_api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/VeraButler/resources_api/merges","archive_url":"https://api.github.com/repos/VeraButler/resources_api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/VeraButler/resources_api/downloads","issues_url":"https://api.github.com/repos/VeraButler/resources_api/issues{/number}","pulls_url":"https://api.github.com/repos/VeraButler/resources_api/pulls{/number}","milestones_url":"https://api.github.com/repos/VeraButler/resources_api/milestones{/number}","notifications_url":"https://api.github.com/repos/VeraButler/resources_api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/VeraButler/resources_api/labels{/name}","releases_url":"https://api.github.com/repos/VeraButler/resources_api/releases{/id}","deployments_url":"https://api.github.com/repos/VeraButler/resources_api/deployments","created_at":"2018-10-22T16:28:07Z","updated_at":"2018-10-22T16:28:09Z","pushed_at":"2018-10-25T15:08:33Z","git_url":"git://github.com/VeraButler/resources_api.git","ssh_url":"[email protected]:VeraButler/resources_api.git","clone_url":"https://github.com/VeraButler/resources_api.git","svn_url":"https://github.com/VeraButler/resources_api","homepage":"","size":209,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"OperationCode:master","ref":"master","sha":"773eb13f6a19eeb6abf0132e724d1084c5da1875","user":{"login":"OperationCode","id":10479364,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNDc5MzY0","avatar_url":"https://avatars3.githubusercontent.com/u/10479364?v=4","gravatar_id":"","url":"https://api.github.com/users/OperationCode","html_url":"https://github.com/OperationCode","followers_url":"https://api.github.com/users/OperationCode/followers","following_url":"https://api.github.com/users/OperationCode/following{/other_user}","gists_url":"https://api.github.com/users/OperationCode/gists{/gist_id}","starred_url":"https://api.github.com/users/OperationCode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OperationCode/subscriptions","organizations_url":"https://api.github.com/users/OperationCode/orgs","repos_url":"https://api.github.com/users/OperationCode/repos","events_url":"https://api.github.com/users/OperationCode/events{/privacy}","received_events_url":"https://api.github.com/users/OperationCode/received_events","type":"Organization","site_admin":false},"repo":{"id":142719769,"node_id":"MDEwOlJlcG9zaXRvcnkxNDI3MTk3Njk=","name":"resources_api","full_name":"OperationCode/resources_api","private":false,"owner":{"login":"OperationCode","id":10479364,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNDc5MzY0","avatar_url":"https://avatars3.githubusercontent.com/u/10479364?v=4","gravatar_id":"","url":"https://api.github.com/users/OperationCode","html_url":"https://github.com/OperationCode","followers_url":"https://api.github.com/users/OperationCode/followers","following_url":"https://api.github.com/users/OperationCode/following{/other_user}","gists_url":"https://api.github.com/users/OperationCode/gists{/gist_id}","starred_url":"https://api.github.com/users/OperationCode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OperationCode/subscriptions","organizations_url":"https://api.github.com/users/OperationCode/orgs","repos_url":"https://api.github.com/users/OperationCode/repos","events_url":"https://api.github.com/users/OperationCode/events{/privacy}","received_events_url":"https://api.github.com/users/OperationCode/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/OperationCode/resources_api","description":"API for programming and cyber security learning resources","fork":false,"url":"https://api.github.com/repos/OperationCode/resources_api","forks_url":"https://api.github.com/repos/OperationCode/resources_api/forks","keys_url":"https://api.github.com/repos/OperationCode/resources_api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OperationCode/resources_api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OperationCode/resources_api/teams","hooks_url":"https://api.github.com/repos/OperationCode/resources_api/hooks","issue_events_url":"https://api.github.com/repos/OperationCode/resources_api/issues/events{/number}","events_url":"https://api.github.com/repos/OperationCode/resources_api/events","assignees_url":"https://api.github.com/repos/OperationCode/resources_api/assignees{/user}","branches_url":"https://api.github.com/repos/OperationCode/resources_api/branches{/branch}","tags_url":"https://api.github.com/repos/OperationCode/resources_api/tags","blobs_url":"https://api.github.com/repos/OperationCode/resources_api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OperationCode/resources_api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OperationCode/resources_api/git/refs{/sha}","trees_url":"https://api.github.com/repos/OperationCode/resources_api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OperationCode/resources_api/statuses/{sha}","languages_url":"https://api.github.com/repos/OperationCode/resources_api/languages","stargazers_url":"https://api.github.com/repos/OperationCode/resources_api/stargazers","contributors_url":"https://api.github.com/repos/OperationCode/resources_api/contributors","subscribers_url":"https://api.github.com/repos/OperationCode/resources_api/subscribers","subscription_url":"https://api.github.com/repos/OperationCode/resources_api/subscription","commits_url":"https://api.github.com/repos/OperationCode/resources_api/commits{/sha}","git_commits_url":"https://api.github.com/repos/OperationCode/resources_api/git/commits{/sha}","comments_url":"https://api.github.com/repos/OperationCode/resources_api/comments{/number}","issue_comment_url":"https://api.github.com/repos/OperationCode/resources_api/issues/comments{/number}","contents_url":"https://api.github.com/repos/OperationCode/resources_api/contents/{+path}","compare_url":"https://api.github.com/repos/OperationCode/resources_api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OperationCode/resources_api/merges","archive_url":"https://api.github.com/repos/OperationCode/resources_api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OperationCode/resources_api/downloads","issues_url":"https://api.github.com/repos/OperationCode/resources_api/issues{/number}","pulls_url":"https://api.github.com/repos/OperationCode/resources_api/pulls{/number}","milestones_url":"https://api.github.com/repos/OperationCode/resources_api/milestones{/number}","notifications_url":"https://api.github.com/repos/OperationCode/resources_api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OperationCode/resources_api/labels{/name}","releases_url":"https://api.github.com/repos/OperationCode/resources_api/releases{/id}","deployments_url":"https://api.github.com/repos/OperationCode/resources_api/deployments","created_at":"2018-07-29T00:42:15Z","updated_at":"2018-10-25T02:01:07Z","pushed_at":"2018-10-25T15:08:34Z","git_url":"git://github.com/OperationCode/resources_api.git","ssh_url":"[email protected]:OperationCode/resources_api.git","clone_url":"https://github.com/OperationCode/resources_api.git","svn_url":"https://github.com/OperationCode/resources_api","homepage":"","size":232,"stargazers_count":4,"watchers_count":4,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"archived":false,"open_issues_count":15,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":9,"open_issues":15,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OperationCode/resources_api/pulls/43"},"html":{"href":"https://github.com/OperationCode/resources_api/pull/43"},"issue":{"href":"https://api.github.com/repos/OperationCode/resources_api/issues/43"},"comments":{"href":"https://api.github.com/repos/OperationCode/resources_api/issues/43/comments"},"review_comments":{"href":"https://api.github.com/repos/OperationCode/resources_api/pulls/43/comments"},"review_comment":{"href":"https://api.github.com/repos/OperationCode/resources_api/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OperationCode/resources_api/pulls/43/commits"},"statuses":{"href":"https://api.github.com/repos/OperationCode/resources_api/statuses/697d5f910a6a388a2ae830cc28388fc46a6280c5"}},"author_association":"NONE"}} | {
"id": 142719769,
"name": "OperationCode/resources_api",
"url": "https://api.github.com/repos/OperationCode/resources_api"
} | {
"id": 33324650,
"login": "VeraButler",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/33324650?",
"url": "https://api.github.com/users/VeraButler"
} | {
"id": 10479364,
"login": "OperationCode",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/10479364?",
"url": "https://api.github.com/orgs/OperationCode"
} | 2018-10-25T15:09:18 | 8481185725 | {"actor":{"display_login":"VeraButler"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/pulls/comments/167392425","pull_request_review_id":95616031,"id":167392425,"diff_hunk":"@@ -0,0 +1,119 @@\n+'use strict'\n+\n+const defaults = require('lodash.defaultsdeep')\n+const clone = require('lodash.clone')\n+const waterfall = require('async/waterfall')\n+const path = require('path')\n+\n+const Daemon = require('./ipfsd-daemon')\n+const defaultConfig = require('./defaults/config')\n+const defaultOptions = require('./defaults/options')\n+\n+/**\n+ * Spawn IPFS Daemons (either JS or Go)\n+ *\n+ * @namespace FactoryDaemon\n+ */\n+class FactoryDaemon {\n+ /**\n+ *\n+ * @param {Object} opts\n+ * - `type` string - 'go' or 'js'\n+ * - `exec` string (optional) - the path of the daemon executable\n+ * @return {*}\n+ */\n+ constructor (options) {\n+ if (options && options.type === 'proc') {\n+ throw new Error('This Factory does not know how to spawn in proc nodes')\n+ }\n+ options = Object.assign({ type: 'go' }, options)\n+ this.type = options.type\n+ this.exec = options.exec\n+ }\n+\n+ /**\n+ * Get the version of the currently used go-ipfs binary.\n+ *\n+ * @memberof FactoryDaemon\n+ * @param {Object} [options={}]\n+ * @param {function(Error, string)} callback\n+ * @returns {undefined}\n+ */\n+ version (options, callback) {\n+ if (typeof options === 'function') {\n+ callback = options\n+ options = {}\n+ }\n+ options = Object.assign({}, options, { type: this.type })\n+ // TODO: (1) this should check to see if it is looking for Go or JS\n+ // TODO: (2) This spawns a whole daemon just to get his version? There is","path":"src/factory-daemon.js","position":49,"original_position":49,"commit_id":"8ff19767895515fdda71126431c06c2285ca22d7","original_commit_id":"b0da61a96c27e37207cab16f7c9b464ae1660e99","user":{"login":"diasdavid","id":1211152,"avatar_url":"https://avatars0.githubusercontent.com/u/1211152?v=4","gravatar_id":"","url":"https://api.github.com/users/diasdavid","html_url":"https://github.com/diasdavid","followers_url":"https://api.github.com/users/diasdavid/followers","following_url":"https://api.github.com/users/diasdavid/following{/other_user}","gists_url":"https://api.github.com/users/diasdavid/gists{/gist_id}","starred_url":"https://api.github.com/users/diasdavid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diasdavid/subscriptions","organizations_url":"https://api.github.com/users/diasdavid/orgs","repos_url":"https://api.github.com/users/diasdavid/repos","events_url":"https://api.github.com/users/diasdavid/events{/privacy}","received_events_url":"https://api.github.com/users/diasdavid/received_events","type":"User","site_admin":false},"body":"It still should check if it is JS or Go","created_at":"2018-02-10T08:02:02Z","updated_at":"2018-02-10T08:04:00Z","html_url":"https://github.com/ipfs/js-ipfsd-ctl/pull/200#discussion_r167392425","pull_request_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/pulls/200","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/pulls/comments/167392425"},"html":{"href":"https://github.com/ipfs/js-ipfsd-ctl/pull/200#discussion_r167392425"},"pull_request":{"href":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/pulls/200"}},"in_reply_to_id":167215090},"pull_request":{"url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/pulls/200","id":167672384,"html_url":"https://github.com/ipfs/js-ipfsd-ctl/pull/200","diff_url":"https://github.com/ipfs/js-ipfsd-ctl/pull/200.diff","patch_url":"https://github.com/ipfs/js-ipfsd-ctl/pull/200.patch","issue_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/issues/200","number":200,"state":"open","locked":false,"title":"The big refactor!","user":{"login":"diasdavid","id":1211152,"avatar_url":"https://avatars0.githubusercontent.com/u/1211152?v=4","gravatar_id":"","url":"https://api.github.com/users/diasdavid","html_url":"https://github.com/diasdavid","followers_url":"https://api.github.com/users/diasdavid/followers","following_url":"https://api.github.com/users/diasdavid/following{/other_user}","gists_url":"https://api.github.com/users/diasdavid/gists{/gist_id}","starred_url":"https://api.github.com/users/diasdavid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diasdavid/subscriptions","organizations_url":"https://api.github.com/users/diasdavid/orgs","repos_url":"https://api.github.com/users/diasdavid/repos","events_url":"https://api.github.com/users/diasdavid/events{/privacy}","received_events_url":"https://api.github.com/users/diasdavid/received_events","type":"User","site_admin":false},"body":"The current ipfsd-ctl is a big mess. There are ~~no~~ only a few browser tests; tests have the setup assert and teardown phases all mixed with sometimes using a describe + before as the assertion; there are multiple files that get loaded in the browser without necessity, this is causing all sorts of problems on other modules https://github.com/ipfs/js-ipfs-api/issues/683; The internals use different names for the things that are exposed (i.e calling daemon-ctrl to the Daemon Factory).\r\n\r\nThere is still a considerable amount of work to do here. I might not be able to finish this today but I intend to have it tomorrow.","created_at":"2018-02-07T11:54:45Z","updated_at":"2018-02-10T08:04:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6c8ab24eaec35c12cac601c7e5e68f2e85b092e1","assignee":{"login":"diasdavid","id":1211152,"avatar_url":"https://avatars0.githubusercontent.com/u/1211152?v=4","gravatar_id":"","url":"https://api.github.com/users/diasdavid","html_url":"https://github.com/diasdavid","followers_url":"https://api.github.com/users/diasdavid/followers","following_url":"https://api.github.com/users/diasdavid/following{/other_user}","gists_url":"https://api.github.com/users/diasdavid/gists{/gist_id}","starred_url":"https://api.github.com/users/diasdavid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diasdavid/subscriptions","organizations_url":"https://api.github.com/users/diasdavid/orgs","repos_url":"https://api.github.com/users/diasdavid/repos","events_url":"https://api.github.com/users/diasdavid/events{/privacy}","received_events_url":"https://api.github.com/users/diasdavid/received_events","type":"User","site_admin":false},"assignees":[{"login":"dryajov","id":1094341,"avatar_url":"https://avatars1.githubusercontent.com/u/1094341?v=4","gravatar_id":"","url":"https://api.github.com/users/dryajov","html_url":"https://github.com/dryajov","followers_url":"https://api.github.com/users/dryajov/followers","following_url":"https://api.github.com/users/dryajov/following{/other_user}","gists_url":"https://api.github.com/users/dryajov/gists{/gist_id}","starred_url":"https://api.github.com/users/dryajov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dryajov/subscriptions","organizations_url":"https://api.github.com/users/dryajov/orgs","repos_url":"https://api.github.com/users/dryajov/repos","events_url":"https://api.github.com/users/dryajov/events{/privacy}","received_events_url":"https://api.github.com/users/dryajov/received_events","type":"User","site_admin":false},{"login":"diasdavid","id":1211152,"avatar_url":"https://avatars0.githubusercontent.com/u/1211152?v=4","gravatar_id":"","url":"https://api.github.com/users/diasdavid","html_url":"https://github.com/diasdavid","followers_url":"https://api.github.com/users/diasdavid/followers","following_url":"https://api.github.com/users/diasdavid/following{/other_user}","gists_url":"https://api.github.com/users/diasdavid/gists{/gist_id}","starred_url":"https://api.github.com/users/diasdavid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diasdavid/subscriptions","organizations_url":"https://api.github.com/users/diasdavid/orgs","repos_url":"https://api.github.com/users/diasdavid/repos","events_url":"https://api.github.com/users/diasdavid/events{/privacy}","received_events_url":"https://api.github.com/users/diasdavid/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":419602045,"url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/labels/in%20progress","name":"in progress","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/pulls/200/commits","review_comments_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/pulls/200/comments","review_comment_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/issues/200/comments","statuses_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/statuses/8ff19767895515fdda71126431c06c2285ca22d7","head":{"label":"ipfs:ipfsd-light","ref":"ipfsd-light","sha":"8ff19767895515fdda71126431c06c2285ca22d7","user":{"login":"ipfs","id":10536621,"avatar_url":"https://avatars0.githubusercontent.com/u/10536621?v=4","gravatar_id":"","url":"https://api.github.com/users/ipfs","html_url":"https://github.com/ipfs","followers_url":"https://api.github.com/users/ipfs/followers","following_url":"https://api.github.com/users/ipfs/following{/other_user}","gists_url":"https://api.github.com/users/ipfs/gists{/gist_id}","starred_url":"https://api.github.com/users/ipfs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ipfs/subscriptions","organizations_url":"https://api.github.com/users/ipfs/orgs","repos_url":"https://api.github.com/users/ipfs/repos","events_url":"https://api.github.com/users/ipfs/events{/privacy}","received_events_url":"https://api.github.com/users/ipfs/received_events","type":"Organization","site_admin":false},"repo":{"id":34555538,"name":"js-ipfsd-ctl","full_name":"ipfs/js-ipfsd-ctl","owner":{"login":"ipfs","id":10536621,"avatar_url":"https://avatars0.githubusercontent.com/u/10536621?v=4","gravatar_id":"","url":"https://api.github.com/users/ipfs","html_url":"https://github.com/ipfs","followers_url":"https://api.github.com/users/ipfs/followers","following_url":"https://api.github.com/users/ipfs/following{/other_user}","gists_url":"https://api.github.com/users/ipfs/gists{/gist_id}","starred_url":"https://api.github.com/users/ipfs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ipfs/subscriptions","organizations_url":"https://api.github.com/users/ipfs/orgs","repos_url":"https://api.github.com/users/ipfs/repos","events_url":"https://api.github.com/users/ipfs/events{/privacy}","received_events_url":"https://api.github.com/users/ipfs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ipfs/js-ipfsd-ctl","description":"Control an IPFS daemon (go-ipfs or js-ipfs) using JavaScript!","fork":false,"url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl","forks_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/forks","keys_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/teams","hooks_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/hooks","issue_events_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/issues/events{/number}","events_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/events","assignees_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/assignees{/user}","branches_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/branches{/branch}","tags_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/tags","blobs_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/git/refs{/sha}","trees_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/statuses/{sha}","languages_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/languages","stargazers_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/stargazers","contributors_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/contributors","subscribers_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/subscribers","subscription_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/subscription","commits_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/commits{/sha}","git_commits_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/git/commits{/sha}","comments_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/comments{/number}","issue_comment_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/issues/comments{/number}","contents_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/contents/{+path}","compare_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/merges","archive_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/downloads","issues_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/issues{/number}","pulls_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/pulls{/number}","milestones_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/milestones{/number}","notifications_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/labels{/name}","releases_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/releases{/id}","deployments_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/deployments","created_at":"2015-04-25T04:40:11Z","updated_at":"2018-01-26T19:37:05Z","pushed_at":"2018-02-10T07:15:13Z","git_url":"git://github.com/ipfs/js-ipfsd-ctl.git","ssh_url":"[email protected]:ipfs/js-ipfsd-ctl.git","clone_url":"https://github.com/ipfs/js-ipfsd-ctl.git","svn_url":"https://github.com/ipfs/js-ipfsd-ctl","homepage":"","size":328,"stargazers_count":35,"watchers_count":35,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":22,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":22,"open_issues":8,"watchers":35,"default_branch":"master"}},"base":{"label":"ipfs:master","ref":"master","sha":"34a3f59c8a41e55fff0377bde11588e51dffb3af","user":{"login":"ipfs","id":10536621,"avatar_url":"https://avatars0.githubusercontent.com/u/10536621?v=4","gravatar_id":"","url":"https://api.github.com/users/ipfs","html_url":"https://github.com/ipfs","followers_url":"https://api.github.com/users/ipfs/followers","following_url":"https://api.github.com/users/ipfs/following{/other_user}","gists_url":"https://api.github.com/users/ipfs/gists{/gist_id}","starred_url":"https://api.github.com/users/ipfs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ipfs/subscriptions","organizations_url":"https://api.github.com/users/ipfs/orgs","repos_url":"https://api.github.com/users/ipfs/repos","events_url":"https://api.github.com/users/ipfs/events{/privacy}","received_events_url":"https://api.github.com/users/ipfs/received_events","type":"Organization","site_admin":false},"repo":{"id":34555538,"name":"js-ipfsd-ctl","full_name":"ipfs/js-ipfsd-ctl","owner":{"login":"ipfs","id":10536621,"avatar_url":"https://avatars0.githubusercontent.com/u/10536621?v=4","gravatar_id":"","url":"https://api.github.com/users/ipfs","html_url":"https://github.com/ipfs","followers_url":"https://api.github.com/users/ipfs/followers","following_url":"https://api.github.com/users/ipfs/following{/other_user}","gists_url":"https://api.github.com/users/ipfs/gists{/gist_id}","starred_url":"https://api.github.com/users/ipfs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ipfs/subscriptions","organizations_url":"https://api.github.com/users/ipfs/orgs","repos_url":"https://api.github.com/users/ipfs/repos","events_url":"https://api.github.com/users/ipfs/events{/privacy}","received_events_url":"https://api.github.com/users/ipfs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ipfs/js-ipfsd-ctl","description":"Control an IPFS daemon (go-ipfs or js-ipfs) using JavaScript!","fork":false,"url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl","forks_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/forks","keys_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/teams","hooks_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/hooks","issue_events_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/issues/events{/number}","events_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/events","assignees_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/assignees{/user}","branches_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/branches{/branch}","tags_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/tags","blobs_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/git/refs{/sha}","trees_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/statuses/{sha}","languages_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/languages","stargazers_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/stargazers","contributors_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/contributors","subscribers_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/subscribers","subscription_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/subscription","commits_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/commits{/sha}","git_commits_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/git/commits{/sha}","comments_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/comments{/number}","issue_comment_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/issues/comments{/number}","contents_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/contents/{+path}","compare_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/merges","archive_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/downloads","issues_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/issues{/number}","pulls_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/pulls{/number}","milestones_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/milestones{/number}","notifications_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/labels{/name}","releases_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/releases{/id}","deployments_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/deployments","created_at":"2015-04-25T04:40:11Z","updated_at":"2018-01-26T19:37:05Z","pushed_at":"2018-02-10T07:15:13Z","git_url":"git://github.com/ipfs/js-ipfsd-ctl.git","ssh_url":"[email protected]:ipfs/js-ipfsd-ctl.git","clone_url":"https://github.com/ipfs/js-ipfsd-ctl.git","svn_url":"https://github.com/ipfs/js-ipfsd-ctl","homepage":"","size":328,"stargazers_count":35,"watchers_count":35,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":22,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":22,"open_issues":8,"watchers":35,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/pulls/200"},"html":{"href":"https://github.com/ipfs/js-ipfsd-ctl/pull/200"},"issue":{"href":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/issues/200"},"comments":{"href":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/issues/200/comments"},"review_comments":{"href":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/pulls/200/comments"},"review_comment":{"href":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/pulls/200/commits"},"statuses":{"href":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/statuses/8ff19767895515fdda71126431c06c2285ca22d7"}},"author_association":"OWNER"}} | {
"id": 34555538,
"name": "ipfs/js-ipfsd-ctl",
"url": "https://api.github.com/repos/ipfs/js-ipfsd-ctl"
} | {
"id": 1211152,
"login": "diasdavid",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1211152?",
"url": "https://api.github.com/users/diasdavid"
} | {
"id": 10536621,
"login": "ipfs",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/10536621?",
"url": "https://api.github.com/orgs/ipfs"
} | 2018-02-10T08:02:02 | 7226341648 | {"actor":{"display_login":"diasdavid"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/ipfs/js-ipfs/pulls/comments/177870801","pull_request_review_id":107826315,"id":177870801,"diff_hunk":"@@ -0,0 +1,50 @@\n+# Quarterly Objectives and Key Results\n+\n+We try to frame our ongoing work using a process based on quarterly Objectives and Key Results (OKRs). Objectives reflect outcomes that are challenging, but realistic. Results are tangible and measurable.\n+\n+## 2018 Q2\n+\n+> Work in Progress\n+\n+### The daemon is stable and so core is reliable\n+\n+- `PX` - OWNER - The uncaught errors and memory usage are under control and a daemon can run for a week non stop\n+- `PX` - OWNER - One or more js-ipfs daemons are part of the IPFS infrastructure\n+- `PX` - OWNER - js.ipfs.io exposes an IPFS Gateway provided by a js-ipfs daemon","path":"OKR.md","position":13,"original_position":13,"commit_id":"196f13979388ae4f9013a902be389b924f554718","original_commit_id":"196f13979388ae4f9013a902be389b924f554718","user":{"login":"VictorBjelkholm","id":459764,"avatar_url":"https://avatars2.githubusercontent.com/u/459764?v=4","gravatar_id":"","url":"https://api.github.com/users/VictorBjelkholm","html_url":"https://github.com/VictorBjelkholm","followers_url":"https://api.github.com/users/VictorBjelkholm/followers","following_url":"https://api.github.com/users/VictorBjelkholm/following{/other_user}","gists_url":"https://api.github.com/users/VictorBjelkholm/gists{/gist_id}","starred_url":"https://api.github.com/users/VictorBjelkholm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VictorBjelkholm/subscriptions","organizations_url":"https://api.github.com/users/VictorBjelkholm/orgs","repos_url":"https://api.github.com/users/VictorBjelkholm/repos","events_url":"https://api.github.com/users/VictorBjelkholm/events{/privacy}","received_events_url":"https://api.github.com/users/VictorBjelkholm/received_events","type":"User","site_admin":false},"body":":+1: Should we have one bootstrapper node be a js-ipfs node as well? My thinking is that the js-ipfs gateway probably won't be used a lot, while a default bootstrap node would get a lot of usage","created_at":"2018-03-28T19:54:52Z","updated_at":"2018-03-28T19:54:53Z","html_url":"https://github.com/ipfs/js-ipfs/pull/1281#discussion_r177870801","pull_request_url":"https://api.github.com/repos/ipfs/js-ipfs/pulls/1281","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ipfs/js-ipfs/pulls/comments/177870801"},"html":{"href":"https://github.com/ipfs/js-ipfs/pull/1281#discussion_r177870801"},"pull_request":{"href":"https://api.github.com/repos/ipfs/js-ipfs/pulls/1281"}},"in_reply_to_id":177866762},"pull_request":{"url":"https://api.github.com/repos/ipfs/js-ipfs/pulls/1281","id":177547880,"html_url":"https://github.com/ipfs/js-ipfs/pull/1281","diff_url":"https://github.com/ipfs/js-ipfs/pull/1281.diff","patch_url":"https://github.com/ipfs/js-ipfs/pull/1281.patch","issue_url":"https://api.github.com/repos/ipfs/js-ipfs/issues/1281","number":1281,"state":"open","locked":false,"title":"OKR.md","user":{"login":"diasdavid","id":1211152,"avatar_url":"https://avatars0.githubusercontent.com/u/1211152?v=4","gravatar_id":"","url":"https://api.github.com/users/diasdavid","html_url":"https://github.com/diasdavid","followers_url":"https://api.github.com/users/diasdavid/followers","following_url":"https://api.github.com/users/diasdavid/following{/other_user}","gists_url":"https://api.github.com/users/diasdavid/gists{/gist_id}","starred_url":"https://api.github.com/users/diasdavid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diasdavid/subscriptions","organizations_url":"https://api.github.com/users/diasdavid/orgs","repos_url":"https://api.github.com/users/diasdavid/repos","events_url":"https://api.github.com/users/diasdavid/events{/privacy}","received_events_url":"https://api.github.com/users/diasdavid/received_events","type":"User","site_admin":false},"body":"Currently just a placeholder. Please submit your proposals for Objects and Key Results through this PR. I'll keep revisiting, add my own and trying to coalesce things until we feel there is something ready to discuss as a group or to present to the rest of the IPFS Community.","created_at":"2018-03-26T19:44:12Z","updated_at":"2018-03-28T19:54:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"59a12a13d7b047c4561fe96bdb7f1a7c0a702b57","assignee":{"login":"wraithgar","id":36607,"avatar_url":"https://avatars2.githubusercontent.com/u/36607?v=4","gravatar_id":"","url":"https://api.github.com/users/wraithgar","html_url":"https://github.com/wraithgar","followers_url":"https://api.github.com/users/wraithgar/followers","following_url":"https://api.github.com/users/wraithgar/following{/other_user}","gists_url":"https://api.github.com/users/wraithgar/gists{/gist_id}","starred_url":"https://api.github.com/users/wraithgar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wraithgar/subscriptions","organizations_url":"https://api.github.com/users/wraithgar/orgs","repos_url":"https://api.github.com/users/wraithgar/repos","events_url":"https://api.github.com/users/wraithgar/events{/privacy}","received_events_url":"https://api.github.com/users/wraithgar/received_events","type":"User","site_admin":false},"assignees":[{"login":"wraithgar","id":36607,"avatar_url":"https://avatars2.githubusercontent.com/u/36607?v=4","gravatar_id":"","url":"https://api.github.com/users/wraithgar","html_url":"https://github.com/wraithgar","followers_url":"https://api.github.com/users/wraithgar/followers","following_url":"https://api.github.com/users/wraithgar/following{/other_user}","gists_url":"https://api.github.com/users/wraithgar/gists{/gist_id}","starred_url":"https://api.github.com/users/wraithgar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wraithgar/subscriptions","organizations_url":"https://api.github.com/users/wraithgar/orgs","repos_url":"https://api.github.com/users/wraithgar/repos","events_url":"https://api.github.com/users/wraithgar/events{/privacy}","received_events_url":"https://api.github.com/users/wraithgar/received_events","type":"User","site_admin":false},{"login":"hugomrdias","id":314190,"avatar_url":"https://avatars1.githubusercontent.com/u/314190?v=4","gravatar_id":"","url":"https://api.github.com/users/hugomrdias","html_url":"https://github.com/hugomrdias","followers_url":"https://api.github.com/users/hugomrdias/followers","following_url":"https://api.github.com/users/hugomrdias/following{/other_user}","gists_url":"https://api.github.com/users/hugomrdias/gists{/gist_id}","starred_url":"https://api.github.com/users/hugomrdias/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hugomrdias/subscriptions","organizations_url":"https://api.github.com/users/hugomrdias/orgs","repos_url":"https://api.github.com/users/hugomrdias/repos","events_url":"https://api.github.com/users/hugomrdias/events{/privacy}","received_events_url":"https://api.github.com/users/hugomrdias/received_events","type":"User","site_admin":false},{"login":"jacobheun","id":639834,"avatar_url":"https://avatars3.githubusercontent.com/u/639834?v=4","gravatar_id":"","url":"https://api.github.com/users/jacobheun","html_url":"https://github.com/jacobheun","followers_url":"https://api.github.com/users/jacobheun/followers","following_url":"https://api.github.com/users/jacobheun/following{/other_user}","gists_url":"https://api.github.com/users/jacobheun/gists{/gist_id}","starred_url":"https://api.github.com/users/jacobheun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jacobheun/subscriptions","organizations_url":"https://api.github.com/users/jacobheun/orgs","repos_url":"https://api.github.com/users/jacobheun/repos","events_url":"https://api.github.com/users/jacobheun/events{/privacy}","received_events_url":"https://api.github.com/users/jacobheun/received_events","type":"User","site_admin":false},{"login":"achingbrain","id":665810,"avatar_url":"https://avatars0.githubusercontent.com/u/665810?v=4","gravatar_id":"","url":"https://api.github.com/users/achingbrain","html_url":"https://github.com/achingbrain","followers_url":"https://api.github.com/users/achingbrain/followers","following_url":"https://api.github.com/users/achingbrain/following{/other_user}","gists_url":"https://api.github.com/users/achingbrain/gists{/gist_id}","starred_url":"https://api.github.com/users/achingbrain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/achingbrain/subscriptions","organizations_url":"https://api.github.com/users/achingbrain/orgs","repos_url":"https://api.github.com/users/achingbrain/repos","events_url":"https://api.github.com/users/achingbrain/events{/privacy}","received_events_url":"https://api.github.com/users/achingbrain/received_events","type":"User","site_admin":false},{"login":"dryajov","id":1094341,"avatar_url":"https://avatars1.githubusercontent.com/u/1094341?v=4","gravatar_id":"","url":"https://api.github.com/users/dryajov","html_url":"https://github.com/dryajov","followers_url":"https://api.github.com/users/dryajov/followers","following_url":"https://api.github.com/users/dryajov/following{/other_user}","gists_url":"https://api.github.com/users/dryajov/gists{/gist_id}","starred_url":"https://api.github.com/users/dryajov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dryajov/subscriptions","organizations_url":"https://api.github.com/users/dryajov/orgs","repos_url":"https://api.github.com/users/dryajov/repos","events_url":"https://api.github.com/users/dryajov/events{/privacy}","received_events_url":"https://api.github.com/users/dryajov/received_events","type":"User","site_admin":false},{"login":"diasdavid","id":1211152,"avatar_url":"https://avatars0.githubusercontent.com/u/1211152?v=4","gravatar_id":"","url":"https://api.github.com/users/diasdavid","html_url":"https://github.com/diasdavid","followers_url":"https://api.github.com/users/diasdavid/followers","following_url":"https://api.github.com/users/diasdavid/following{/other_user}","gists_url":"https://api.github.com/users/diasdavid/gists{/gist_id}","starred_url":"https://api.github.com/users/diasdavid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diasdavid/subscriptions","organizations_url":"https://api.github.com/users/diasdavid/orgs","repos_url":"https://api.github.com/users/diasdavid/repos","events_url":"https://api.github.com/users/diasdavid/events{/privacy}","received_events_url":"https://api.github.com/users/diasdavid/received_events","type":"User","site_admin":false},{"login":"vasco-santos","id":7295071,"avatar_url":"https://avatars2.githubusercontent.com/u/7295071?v=4","gravatar_id":"","url":"https://api.github.com/users/vasco-santos","html_url":"https://github.com/vasco-santos","followers_url":"https://api.github.com/users/vasco-santos/followers","following_url":"https://api.github.com/users/vasco-santos/following{/other_user}","gists_url":"https://api.github.com/users/vasco-santos/gists{/gist_id}","starred_url":"https://api.github.com/users/vasco-santos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vasco-santos/subscriptions","organizations_url":"https://api.github.com/users/vasco-santos/orgs","repos_url":"https://api.github.com/users/vasco-santos/repos","events_url":"https://api.github.com/users/vasco-santos/events{/privacy}","received_events_url":"https://api.github.com/users/vasco-santos/received_events","type":"User","site_admin":false},{"login":"fsdiogo","id":33324750,"avatar_url":"https://avatars3.githubusercontent.com/u/33324750?v=4","gravatar_id":"","url":"https://api.github.com/users/fsdiogo","html_url":"https://github.com/fsdiogo","followers_url":"https://api.github.com/users/fsdiogo/followers","following_url":"https://api.github.com/users/fsdiogo/following{/other_user}","gists_url":"https://api.github.com/users/fsdiogo/gists{/gist_id}","starred_url":"https://api.github.com/users/fsdiogo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fsdiogo/subscriptions","organizations_url":"https://api.github.com/users/fsdiogo/orgs","repos_url":"https://api.github.com/users/fsdiogo/repos","events_url":"https://api.github.com/users/fsdiogo/events{/privacy}","received_events_url":"https://api.github.com/users/fsdiogo/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"wraithgar","id":36607,"avatar_url":"https://avatars2.githubusercontent.com/u/36607?v=4","gravatar_id":"","url":"https://api.github.com/users/wraithgar","html_url":"https://github.com/wraithgar","followers_url":"https://api.github.com/users/wraithgar/followers","following_url":"https://api.github.com/users/wraithgar/following{/other_user}","gists_url":"https://api.github.com/users/wraithgar/gists{/gist_id}","starred_url":"https://api.github.com/users/wraithgar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wraithgar/subscriptions","organizations_url":"https://api.github.com/users/wraithgar/orgs","repos_url":"https://api.github.com/users/wraithgar/repos","events_url":"https://api.github.com/users/wraithgar/events{/privacy}","received_events_url":"https://api.github.com/users/wraithgar/received_events","type":"User","site_admin":false},{"login":"hugomrdias","id":314190,"avatar_url":"https://avatars1.githubusercontent.com/u/314190?v=4","gravatar_id":"","url":"https://api.github.com/users/hugomrdias","html_url":"https://github.com/hugomrdias","followers_url":"https://api.github.com/users/hugomrdias/followers","following_url":"https://api.github.com/users/hugomrdias/following{/other_user}","gists_url":"https://api.github.com/users/hugomrdias/gists{/gist_id}","starred_url":"https://api.github.com/users/hugomrdias/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hugomrdias/subscriptions","organizations_url":"https://api.github.com/users/hugomrdias/orgs","repos_url":"https://api.github.com/users/hugomrdias/repos","events_url":"https://api.github.com/users/hugomrdias/events{/privacy}","received_events_url":"https://api.github.com/users/hugomrdias/received_events","type":"User","site_admin":false},{"login":"jacobheun","id":639834,"avatar_url":"https://avatars3.githubusercontent.com/u/639834?v=4","gravatar_id":"","url":"https://api.github.com/users/jacobheun","html_url":"https://github.com/jacobheun","followers_url":"https://api.github.com/users/jacobheun/followers","following_url":"https://api.github.com/users/jacobheun/following{/other_user}","gists_url":"https://api.github.com/users/jacobheun/gists{/gist_id}","starred_url":"https://api.github.com/users/jacobheun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jacobheun/subscriptions","organizations_url":"https://api.github.com/users/jacobheun/orgs","repos_url":"https://api.github.com/users/jacobheun/repos","events_url":"https://api.github.com/users/jacobheun/events{/privacy}","received_events_url":"https://api.github.com/users/jacobheun/received_events","type":"User","site_admin":false},{"login":"achingbrain","id":665810,"avatar_url":"https://avatars0.githubusercontent.com/u/665810?v=4","gravatar_id":"","url":"https://api.github.com/users/achingbrain","html_url":"https://github.com/achingbrain","followers_url":"https://api.github.com/users/achingbrain/followers","following_url":"https://api.github.com/users/achingbrain/following{/other_user}","gists_url":"https://api.github.com/users/achingbrain/gists{/gist_id}","starred_url":"https://api.github.com/users/achingbrain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/achingbrain/subscriptions","organizations_url":"https://api.github.com/users/achingbrain/orgs","repos_url":"https://api.github.com/users/achingbrain/repos","events_url":"https://api.github.com/users/achingbrain/events{/privacy}","received_events_url":"https://api.github.com/users/achingbrain/received_events","type":"User","site_admin":false},{"login":"dryajov","id":1094341,"avatar_url":"https://avatars1.githubusercontent.com/u/1094341?v=4","gravatar_id":"","url":"https://api.github.com/users/dryajov","html_url":"https://github.com/dryajov","followers_url":"https://api.github.com/users/dryajov/followers","following_url":"https://api.github.com/users/dryajov/following{/other_user}","gists_url":"https://api.github.com/users/dryajov/gists{/gist_id}","starred_url":"https://api.github.com/users/dryajov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dryajov/subscriptions","organizations_url":"https://api.github.com/users/dryajov/orgs","repos_url":"https://api.github.com/users/dryajov/repos","events_url":"https://api.github.com/users/dryajov/events{/privacy}","received_events_url":"https://api.github.com/users/dryajov/received_events","type":"User","site_admin":false},{"login":"vasco-santos","id":7295071,"avatar_url":"https://avatars2.githubusercontent.com/u/7295071?v=4","gravatar_id":"","url":"https://api.github.com/users/vasco-santos","html_url":"https://github.com/vasco-santos","followers_url":"https://api.github.com/users/vasco-santos/followers","following_url":"https://api.github.com/users/vasco-santos/following{/other_user}","gists_url":"https://api.github.com/users/vasco-santos/gists{/gist_id}","starred_url":"https://api.github.com/users/vasco-santos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vasco-santos/subscriptions","organizations_url":"https://api.github.com/users/vasco-santos/orgs","repos_url":"https://api.github.com/users/vasco-santos/repos","events_url":"https://api.github.com/users/vasco-santos/events{/privacy}","received_events_url":"https://api.github.com/users/vasco-santos/received_events","type":"User","site_admin":false},{"login":"fsdiogo","id":33324750,"avatar_url":"https://avatars3.githubusercontent.com/u/33324750?v=4","gravatar_id":"","url":"https://api.github.com/users/fsdiogo","html_url":"https://github.com/fsdiogo","followers_url":"https://api.github.com/users/fsdiogo/followers","following_url":"https://api.github.com/users/fsdiogo/following{/other_user}","gists_url":"https://api.github.com/users/fsdiogo/gists{/gist_id}","starred_url":"https://api.github.com/users/fsdiogo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fsdiogo/subscriptions","organizations_url":"https://api.github.com/users/fsdiogo/orgs","repos_url":"https://api.github.com/users/fsdiogo/repos","events_url":"https://api.github.com/users/fsdiogo/events{/privacy}","received_events_url":"https://api.github.com/users/fsdiogo/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":259619775,"url":"https://api.github.com/repos/ipfs/js-ipfs/labels/in%20progress","name":"in progress","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ipfs/js-ipfs/pulls/1281/commits","review_comments_url":"https://api.github.com/repos/ipfs/js-ipfs/pulls/1281/comments","review_comment_url":"https://api.github.com/repos/ipfs/js-ipfs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ipfs/js-ipfs/issues/1281/comments","statuses_url":"https://api.github.com/repos/ipfs/js-ipfs/statuses/196f13979388ae4f9013a902be389b924f554718","head":{"label":"ipfs:okr","ref":"okr","sha":"196f13979388ae4f9013a902be389b924f554718","user":{"login":"ipfs","id":10536621,"avatar_url":"https://avatars0.githubusercontent.com/u/10536621?v=4","gravatar_id":"","url":"https://api.github.com/users/ipfs","html_url":"https://github.com/ipfs","followers_url":"https://api.github.com/users/ipfs/followers","following_url":"https://api.github.com/users/ipfs/following{/other_user}","gists_url":"https://api.github.com/users/ipfs/gists{/gist_id}","starred_url":"https://api.github.com/users/ipfs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ipfs/subscriptions","organizations_url":"https://api.github.com/users/ipfs/orgs","repos_url":"https://api.github.com/users/ipfs/repos","events_url":"https://api.github.com/users/ipfs/events{/privacy}","received_events_url":"https://api.github.com/users/ipfs/received_events","type":"Organization","site_admin":false},"repo":{"id":20312497,"name":"js-ipfs","full_name":"ipfs/js-ipfs","owner":{"login":"ipfs","id":10536621,"avatar_url":"https://avatars0.githubusercontent.com/u/10536621?v=4","gravatar_id":"","url":"https://api.github.com/users/ipfs","html_url":"https://github.com/ipfs","followers_url":"https://api.github.com/users/ipfs/followers","following_url":"https://api.github.com/users/ipfs/following{/other_user}","gists_url":"https://api.github.com/users/ipfs/gists{/gist_id}","starred_url":"https://api.github.com/users/ipfs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ipfs/subscriptions","organizations_url":"https://api.github.com/users/ipfs/orgs","repos_url":"https://api.github.com/users/ipfs/repos","events_url":"https://api.github.com/users/ipfs/events{/privacy}","received_events_url":"https://api.github.com/users/ipfs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ipfs/js-ipfs","description":"IPFS implementation in JavaScript","fork":false,"url":"https://api.github.com/repos/ipfs/js-ipfs","forks_url":"https://api.github.com/repos/ipfs/js-ipfs/forks","keys_url":"https://api.github.com/repos/ipfs/js-ipfs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ipfs/js-ipfs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ipfs/js-ipfs/teams","hooks_url":"https://api.github.com/repos/ipfs/js-ipfs/hooks","issue_events_url":"https://api.github.com/repos/ipfs/js-ipfs/issues/events{/number}","events_url":"https://api.github.com/repos/ipfs/js-ipfs/events","assignees_url":"https://api.github.com/repos/ipfs/js-ipfs/assignees{/user}","branches_url":"https://api.github.com/repos/ipfs/js-ipfs/branches{/branch}","tags_url":"https://api.github.com/repos/ipfs/js-ipfs/tags","blobs_url":"https://api.github.com/repos/ipfs/js-ipfs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ipfs/js-ipfs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ipfs/js-ipfs/git/refs{/sha}","trees_url":"https://api.github.com/repos/ipfs/js-ipfs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ipfs/js-ipfs/statuses/{sha}","languages_url":"https://api.github.com/repos/ipfs/js-ipfs/languages","stargazers_url":"https://api.github.com/repos/ipfs/js-ipfs/stargazers","contributors_url":"https://api.github.com/repos/ipfs/js-ipfs/contributors","subscribers_url":"https://api.github.com/repos/ipfs/js-ipfs/subscribers","subscription_url":"https://api.github.com/repos/ipfs/js-ipfs/subscription","commits_url":"https://api.github.com/repos/ipfs/js-ipfs/commits{/sha}","git_commits_url":"https://api.github.com/repos/ipfs/js-ipfs/git/commits{/sha}","comments_url":"https://api.github.com/repos/ipfs/js-ipfs/comments{/number}","issue_comment_url":"https://api.github.com/repos/ipfs/js-ipfs/issues/comments{/number}","contents_url":"https://api.github.com/repos/ipfs/js-ipfs/contents/{+path}","compare_url":"https://api.github.com/repos/ipfs/js-ipfs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ipfs/js-ipfs/merges","archive_url":"https://api.github.com/repos/ipfs/js-ipfs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ipfs/js-ipfs/downloads","issues_url":"https://api.github.com/repos/ipfs/js-ipfs/issues{/number}","pulls_url":"https://api.github.com/repos/ipfs/js-ipfs/pulls{/number}","milestones_url":"https://api.github.com/repos/ipfs/js-ipfs/milestones{/number}","notifications_url":"https://api.github.com/repos/ipfs/js-ipfs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ipfs/js-ipfs/labels{/name}","releases_url":"https://api.github.com/repos/ipfs/js-ipfs/releases{/id}","deployments_url":"https://api.github.com/repos/ipfs/js-ipfs/deployments","created_at":"2014-05-30T00:31:06Z","updated_at":"2018-03-28T19:15:32Z","pushed_at":"2018-03-28T19:25:00Z","git_url":"git://github.com/ipfs/js-ipfs.git","ssh_url":"[email protected]:ipfs/js-ipfs.git","clone_url":"https://github.com/ipfs/js-ipfs.git","svn_url":"https://github.com/ipfs/js-ipfs","homepage":"https://ipfs.io","size":8419,"stargazers_count":2064,"watchers_count":2064,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":335,"mirror_url":null,"archived":false,"open_issues_count":77,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":335,"open_issues":77,"watchers":2064,"default_branch":"master"}},"base":{"label":"ipfs:master","ref":"master","sha":"8e3ea44ce260bdd56dd8691e907f55b0eea86c4c","user":{"login":"ipfs","id":10536621,"avatar_url":"https://avatars0.githubusercontent.com/u/10536621?v=4","gravatar_id":"","url":"https://api.github.com/users/ipfs","html_url":"https://github.com/ipfs","followers_url":"https://api.github.com/users/ipfs/followers","following_url":"https://api.github.com/users/ipfs/following{/other_user}","gists_url":"https://api.github.com/users/ipfs/gists{/gist_id}","starred_url":"https://api.github.com/users/ipfs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ipfs/subscriptions","organizations_url":"https://api.github.com/users/ipfs/orgs","repos_url":"https://api.github.com/users/ipfs/repos","events_url":"https://api.github.com/users/ipfs/events{/privacy}","received_events_url":"https://api.github.com/users/ipfs/received_events","type":"Organization","site_admin":false},"repo":{"id":20312497,"name":"js-ipfs","full_name":"ipfs/js-ipfs","owner":{"login":"ipfs","id":10536621,"avatar_url":"https://avatars0.githubusercontent.com/u/10536621?v=4","gravatar_id":"","url":"https://api.github.com/users/ipfs","html_url":"https://github.com/ipfs","followers_url":"https://api.github.com/users/ipfs/followers","following_url":"https://api.github.com/users/ipfs/following{/other_user}","gists_url":"https://api.github.com/users/ipfs/gists{/gist_id}","starred_url":"https://api.github.com/users/ipfs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ipfs/subscriptions","organizations_url":"https://api.github.com/users/ipfs/orgs","repos_url":"https://api.github.com/users/ipfs/repos","events_url":"https://api.github.com/users/ipfs/events{/privacy}","received_events_url":"https://api.github.com/users/ipfs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ipfs/js-ipfs","description":"IPFS implementation in JavaScript","fork":false,"url":"https://api.github.com/repos/ipfs/js-ipfs","forks_url":"https://api.github.com/repos/ipfs/js-ipfs/forks","keys_url":"https://api.github.com/repos/ipfs/js-ipfs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ipfs/js-ipfs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ipfs/js-ipfs/teams","hooks_url":"https://api.github.com/repos/ipfs/js-ipfs/hooks","issue_events_url":"https://api.github.com/repos/ipfs/js-ipfs/issues/events{/number}","events_url":"https://api.github.com/repos/ipfs/js-ipfs/events","assignees_url":"https://api.github.com/repos/ipfs/js-ipfs/assignees{/user}","branches_url":"https://api.github.com/repos/ipfs/js-ipfs/branches{/branch}","tags_url":"https://api.github.com/repos/ipfs/js-ipfs/tags","blobs_url":"https://api.github.com/repos/ipfs/js-ipfs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ipfs/js-ipfs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ipfs/js-ipfs/git/refs{/sha}","trees_url":"https://api.github.com/repos/ipfs/js-ipfs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ipfs/js-ipfs/statuses/{sha}","languages_url":"https://api.github.com/repos/ipfs/js-ipfs/languages","stargazers_url":"https://api.github.com/repos/ipfs/js-ipfs/stargazers","contributors_url":"https://api.github.com/repos/ipfs/js-ipfs/contributors","subscribers_url":"https://api.github.com/repos/ipfs/js-ipfs/subscribers","subscription_url":"https://api.github.com/repos/ipfs/js-ipfs/subscription","commits_url":"https://api.github.com/repos/ipfs/js-ipfs/commits{/sha}","git_commits_url":"https://api.github.com/repos/ipfs/js-ipfs/git/commits{/sha}","comments_url":"https://api.github.com/repos/ipfs/js-ipfs/comments{/number}","issue_comment_url":"https://api.github.com/repos/ipfs/js-ipfs/issues/comments{/number}","contents_url":"https://api.github.com/repos/ipfs/js-ipfs/contents/{+path}","compare_url":"https://api.github.com/repos/ipfs/js-ipfs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ipfs/js-ipfs/merges","archive_url":"https://api.github.com/repos/ipfs/js-ipfs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ipfs/js-ipfs/downloads","issues_url":"https://api.github.com/repos/ipfs/js-ipfs/issues{/number}","pulls_url":"https://api.github.com/repos/ipfs/js-ipfs/pulls{/number}","milestones_url":"https://api.github.com/repos/ipfs/js-ipfs/milestones{/number}","notifications_url":"https://api.github.com/repos/ipfs/js-ipfs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ipfs/js-ipfs/labels{/name}","releases_url":"https://api.github.com/repos/ipfs/js-ipfs/releases{/id}","deployments_url":"https://api.github.com/repos/ipfs/js-ipfs/deployments","created_at":"2014-05-30T00:31:06Z","updated_at":"2018-03-28T19:15:32Z","pushed_at":"2018-03-28T19:25:00Z","git_url":"git://github.com/ipfs/js-ipfs.git","ssh_url":"[email protected]:ipfs/js-ipfs.git","clone_url":"https://github.com/ipfs/js-ipfs.git","svn_url":"https://github.com/ipfs/js-ipfs","homepage":"https://ipfs.io","size":8419,"stargazers_count":2064,"watchers_count":2064,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":335,"mirror_url":null,"archived":false,"open_issues_count":77,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":335,"open_issues":77,"watchers":2064,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ipfs/js-ipfs/pulls/1281"},"html":{"href":"https://github.com/ipfs/js-ipfs/pull/1281"},"issue":{"href":"https://api.github.com/repos/ipfs/js-ipfs/issues/1281"},"comments":{"href":"https://api.github.com/repos/ipfs/js-ipfs/issues/1281/comments"},"review_comments":{"href":"https://api.github.com/repos/ipfs/js-ipfs/pulls/1281/comments"},"review_comment":{"href":"https://api.github.com/repos/ipfs/js-ipfs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ipfs/js-ipfs/pulls/1281/commits"},"statuses":{"href":"https://api.github.com/repos/ipfs/js-ipfs/statuses/196f13979388ae4f9013a902be389b924f554718"}},"author_association":"OWNER"}} | {
"id": 20312497,
"name": "ipfs/js-ipfs",
"url": "https://api.github.com/repos/ipfs/js-ipfs"
} | {
"id": 459764,
"login": "VictorBjelkholm",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/459764?",
"url": "https://api.github.com/users/VictorBjelkholm"
} | {
"id": 10536621,
"login": "ipfs",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/10536621?",
"url": "https://api.github.com/orgs/ipfs"
} | 2018-03-28T19:54:52 | 7449945422 | {"actor":{"display_login":"VictorBjelkholm"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/coala/coala-bears/pulls/comments/226402197","pull_request_review_id":166217036,"id":226402197,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNjQwMjE5Nw==","diff_hunk":"@@ -31,14 +31,19 @@ def run(self, filename, file,\n Detects and fixes PEP8 incompliant code. This bear will not change\n functionality of the code in any way.\n \n- :param max_line_length: Maximum number of characters for a line.\n- When set to 0 allows infinite line length.\n- :param indent_size: Number of spaces per indentation level.\n- :param pep_ignore: A list of errors/warnings to ignore.\n- :param pep_select: A list of errors/warnings to exclusively\n- apply.\n- :param local_pep8_config: Set to true if autopep8 should use a config\n- file as if run normally from this directory.\n+ :param max_line_length:\n+ Maximum number of characters for a line\n+ When set to 0 allows infinite line length.","path":"bears/python/PEP8Bear.py","position":14,"original_position":14,"commit_id":"a1e118c578a5045f540de6072260152313dde4bf","original_commit_id":"a1e118c578a5045f540de6072260152313dde4bf","user":{"login":"sangamcse","id":26381717,"node_id":"MDQ6VXNlcjI2MzgxNzE3","avatar_url":"https://avatars2.githubusercontent.com/u/26381717?v=4","gravatar_id":"","url":"https://api.github.com/users/sangamcse","html_url":"https://github.com/sangamcse","followers_url":"https://api.github.com/users/sangamcse/followers","following_url":"https://api.github.com/users/sangamcse/following{/other_user}","gists_url":"https://api.github.com/users/sangamcse/gists{/gist_id}","starred_url":"https://api.github.com/users/sangamcse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sangamcse/subscriptions","organizations_url":"https://api.github.com/users/sangamcse/orgs","repos_url":"https://api.github.com/users/sangamcse/repos","events_url":"https://api.github.com/users/sangamcse/events{/privacy}","received_events_url":"https://api.github.com/users/sangamcse/received_events","type":"User","site_admin":false},"body":"> after the changes you suggested we require two lines for writing description.\r\n\r\nLook at line 43","created_at":"2018-10-18T17:45:42Z","updated_at":"2018-10-18T17:45:43Z","html_url":"https://github.com/coala/coala-bears/pull/2701#discussion_r226402197","pull_request_url":"https://api.github.com/repos/coala/coala-bears/pulls/2701","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/coala/coala-bears/pulls/comments/226402197"},"html":{"href":"https://github.com/coala/coala-bears/pull/2701#discussion_r226402197"},"pull_request":{"href":"https://api.github.com/repos/coala/coala-bears/pulls/2701"}},"in_reply_to_id":226392791},"pull_request":{"url":"https://api.github.com/repos/coala/coala-bears/pulls/2701","id":217530465,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3NTMwNDY1","html_url":"https://github.com/coala/coala-bears/pull/2701","diff_url":"https://github.com/coala/coala-bears/pull/2701.diff","patch_url":"https://github.com/coala/coala-bears/pull/2701.patch","issue_url":"https://api.github.com/repos/coala/coala-bears/issues/2701","number":2701,"state":"open","locked":false,"title":"PEP8Bear.py: Change the docstring Indentation","user":{"login":"AkshJain99","id":29670791,"node_id":"MDQ6VXNlcjI5NjcwNzkx","avatar_url":"https://avatars2.githubusercontent.com/u/29670791?v=4","gravatar_id":"","url":"https://api.github.com/users/AkshJain99","html_url":"https://github.com/AkshJain99","followers_url":"https://api.github.com/users/AkshJain99/followers","following_url":"https://api.github.com/users/AkshJain99/following{/other_user}","gists_url":"https://api.github.com/users/AkshJain99/gists{/gist_id}","starred_url":"https://api.github.com/users/AkshJain99/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AkshJain99/subscriptions","organizations_url":"https://api.github.com/users/AkshJain99/orgs","repos_url":"https://api.github.com/users/AkshJain99/repos","events_url":"https://api.github.com/users/AkshJain99/events{/privacy}","received_events_url":"https://api.github.com/users/AkshJain99/received_events","type":"User","site_admin":false},"body":"Change in the docstring indentations in PEP8Bear.py.\r\n\r\nCloses https://github.com/coala/coala-bears/issues/2437\r\n\r\n<!--\r\nThanks for your contribution!\r\n\r\nPlease take a quick look at those things down there. They're quite important.\r\nReally! We wrote them for you. Yes you! With utmost care. Read them.\r\n-->\r\n\r\n**For short term contributors:** we understand that getting your commits well\r\ndefined like we require is a hard task and takes some learning. If you\r\nlook to help without wanting to contribute long term there's no need\r\nfor you to learn this. Just drop us a message and we'll take care of brushing\r\nup your stuff for merge!\r\n\r\n### Checklist\r\n\r\n- [x] I read the [commit guidelines](http://coala.io/commit) and I've followed\r\n them.\r\n- [x] I ran coala over my code locally. (*All commits have to pass\r\n individually.* It is not sufficient to have \"fixup commits\" on your PR,\r\n our bot will still report the issues for the previous commit.) You will\r\n likely receive a lot of bot comments and build failures if coala does not\r\n pass on every single commit!\r\n\r\nAfter you submit your pull request, **DO NOT click the 'Update Branch' button.**\r\nWhen asked for a rebase, consult [coala.io/rebase](https://coala.io/rebase)\r\ninstead.\r\n\r\nPlease consider helping us by reviewing other peoples pull requests as well:\r\n\r\n- pick up any PR at <https://coala.io/review>\r\n- review it (check <https://coala.io/reviewing> for more info)\r\n- if you are sure that it needs work, use `corobo mark wip <URL>` to get it out\r\n of the review queue.\r\n\r\nThe more you review, the more your score will grow at coala.io and we will\r\nreview your PRs faster!\r\n","created_at":"2018-09-23T20:50:30Z","updated_at":"2018-10-18T17:45:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"576ec6a2f36593519d95c16e62aaedea89cfc455","assignee":{"login":"AkshJain99","id":29670791,"node_id":"MDQ6VXNlcjI5NjcwNzkx","avatar_url":"https://avatars2.githubusercontent.com/u/29670791?v=4","gravatar_id":"","url":"https://api.github.com/users/AkshJain99","html_url":"https://github.com/AkshJain99","followers_url":"https://api.github.com/users/AkshJain99/followers","following_url":"https://api.github.com/users/AkshJain99/following{/other_user}","gists_url":"https://api.github.com/users/AkshJain99/gists{/gist_id}","starred_url":"https://api.github.com/users/AkshJain99/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AkshJain99/subscriptions","organizations_url":"https://api.github.com/users/AkshJain99/orgs","repos_url":"https://api.github.com/users/AkshJain99/repos","events_url":"https://api.github.com/users/AkshJain99/events{/privacy}","received_events_url":"https://api.github.com/users/AkshJain99/received_events","type":"User","site_admin":false},"assignees":[{"login":"AkshJain99","id":29670791,"node_id":"MDQ6VXNlcjI5NjcwNzkx","avatar_url":"https://avatars2.githubusercontent.com/u/29670791?v=4","gravatar_id":"","url":"https://api.github.com/users/AkshJain99","html_url":"https://github.com/AkshJain99","followers_url":"https://api.github.com/users/AkshJain99/followers","following_url":"https://api.github.com/users/AkshJain99/following{/other_user}","gists_url":"https://api.github.com/users/AkshJain99/gists{/gist_id}","starred_url":"https://api.github.com/users/AkshJain99/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AkshJain99/subscriptions","organizations_url":"https://api.github.com/users/AkshJain99/orgs","repos_url":"https://api.github.com/users/AkshJain99/repos","events_url":"https://api.github.com/users/AkshJain99/events{/privacy}","received_events_url":"https://api.github.com/users/AkshJain99/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":348666639,"node_id":"MDU6TGFiZWwzNDg2NjY2Mzk=","url":"https://api.github.com/repos/coala/coala-bears/labels/area/documentation","name":"area/documentation","color":"c5def5","default":false},{"id":328549778,"node_id":"MDU6TGFiZWwzMjg1NDk3Nzg=","url":"https://api.github.com/repos/coala/coala-bears/labels/difficulty/newcomer","name":"difficulty/newcomer","color":"65C8FF","default":false},{"id":1043797844,"node_id":"MDU6TGFiZWwxMDQzNzk3ODQ0","url":"https://api.github.com/repos/coala/coala-bears/labels/in%20progress","name":"in progress","color":"ededed","default":false},{"id":327367116,"node_id":"MDU6TGFiZWwzMjczNjcxMTY=","url":"https://api.github.com/repos/coala/coala-bears/labels/process/pending%20review","name":"process/pending review","color":"bfe5bf","default":false},{"id":327048723,"node_id":"MDU6TGFiZWwzMjcwNDg3MjM=","url":"https://api.github.com/repos/coala/coala-bears/labels/size/XS","name":"size/XS","color":"00DE0F","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/coala/coala-bears/pulls/2701/commits","review_comments_url":"https://api.github.com/repos/coala/coala-bears/pulls/2701/comments","review_comment_url":"https://api.github.com/repos/coala/coala-bears/pulls/comments{/number}","comments_url":"https://api.github.com/repos/coala/coala-bears/issues/2701/comments","statuses_url":"https://api.github.com/repos/coala/coala-bears/statuses/a1e118c578a5045f540de6072260152313dde4bf","head":{"label":"AkshJain99:mynew","ref":"mynew","sha":"a1e118c578a5045f540de6072260152313dde4bf","user":{"login":"AkshJain99","id":29670791,"node_id":"MDQ6VXNlcjI5NjcwNzkx","avatar_url":"https://avatars2.githubusercontent.com/u/29670791?v=4","gravatar_id":"","url":"https://api.github.com/users/AkshJain99","html_url":"https://github.com/AkshJain99","followers_url":"https://api.github.com/users/AkshJain99/followers","following_url":"https://api.github.com/users/AkshJain99/following{/other_user}","gists_url":"https://api.github.com/users/AkshJain99/gists{/gist_id}","starred_url":"https://api.github.com/users/AkshJain99/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AkshJain99/subscriptions","organizations_url":"https://api.github.com/users/AkshJain99/orgs","repos_url":"https://api.github.com/users/AkshJain99/repos","events_url":"https://api.github.com/users/AkshJain99/events{/privacy}","received_events_url":"https://api.github.com/users/AkshJain99/received_events","type":"User","site_admin":false},"repo":{"id":149470108,"node_id":"MDEwOlJlcG9zaXRvcnkxNDk0NzAxMDg=","name":"coala-bears","full_name":"AkshJain99/coala-bears","private":false,"owner":{"login":"AkshJain99","id":29670791,"node_id":"MDQ6VXNlcjI5NjcwNzkx","avatar_url":"https://avatars2.githubusercontent.com/u/29670791?v=4","gravatar_id":"","url":"https://api.github.com/users/AkshJain99","html_url":"https://github.com/AkshJain99","followers_url":"https://api.github.com/users/AkshJain99/followers","following_url":"https://api.github.com/users/AkshJain99/following{/other_user}","gists_url":"https://api.github.com/users/AkshJain99/gists{/gist_id}","starred_url":"https://api.github.com/users/AkshJain99/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AkshJain99/subscriptions","organizations_url":"https://api.github.com/users/AkshJain99/orgs","repos_url":"https://api.github.com/users/AkshJain99/repos","events_url":"https://api.github.com/users/AkshJain99/events{/privacy}","received_events_url":"https://api.github.com/users/AkshJain99/received_events","type":"User","site_admin":false},"html_url":"https://github.com/AkshJain99/coala-bears","description":"Bears for coala","fork":true,"url":"https://api.github.com/repos/AkshJain99/coala-bears","forks_url":"https://api.github.com/repos/AkshJain99/coala-bears/forks","keys_url":"https://api.github.com/repos/AkshJain99/coala-bears/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AkshJain99/coala-bears/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AkshJain99/coala-bears/teams","hooks_url":"https://api.github.com/repos/AkshJain99/coala-bears/hooks","issue_events_url":"https://api.github.com/repos/AkshJain99/coala-bears/issues/events{/number}","events_url":"https://api.github.com/repos/AkshJain99/coala-bears/events","assignees_url":"https://api.github.com/repos/AkshJain99/coala-bears/assignees{/user}","branches_url":"https://api.github.com/repos/AkshJain99/coala-bears/branches{/branch}","tags_url":"https://api.github.com/repos/AkshJain99/coala-bears/tags","blobs_url":"https://api.github.com/repos/AkshJain99/coala-bears/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AkshJain99/coala-bears/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AkshJain99/coala-bears/git/refs{/sha}","trees_url":"https://api.github.com/repos/AkshJain99/coala-bears/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AkshJain99/coala-bears/statuses/{sha}","languages_url":"https://api.github.com/repos/AkshJain99/coala-bears/languages","stargazers_url":"https://api.github.com/repos/AkshJain99/coala-bears/stargazers","contributors_url":"https://api.github.com/repos/AkshJain99/coala-bears/contributors","subscribers_url":"https://api.github.com/repos/AkshJain99/coala-bears/subscribers","subscription_url":"https://api.github.com/repos/AkshJain99/coala-bears/subscription","commits_url":"https://api.github.com/repos/AkshJain99/coala-bears/commits{/sha}","git_commits_url":"https://api.github.com/repos/AkshJain99/coala-bears/git/commits{/sha}","comments_url":"https://api.github.com/repos/AkshJain99/coala-bears/comments{/number}","issue_comment_url":"https://api.github.com/repos/AkshJain99/coala-bears/issues/comments{/number}","contents_url":"https://api.github.com/repos/AkshJain99/coala-bears/contents/{+path}","compare_url":"https://api.github.com/repos/AkshJain99/coala-bears/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AkshJain99/coala-bears/merges","archive_url":"https://api.github.com/repos/AkshJain99/coala-bears/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AkshJain99/coala-bears/downloads","issues_url":"https://api.github.com/repos/AkshJain99/coala-bears/issues{/number}","pulls_url":"https://api.github.com/repos/AkshJain99/coala-bears/pulls{/number}","milestones_url":"https://api.github.com/repos/AkshJain99/coala-bears/milestones{/number}","notifications_url":"https://api.github.com/repos/AkshJain99/coala-bears/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AkshJain99/coala-bears/labels{/name}","releases_url":"https://api.github.com/repos/AkshJain99/coala-bears/releases{/id}","deployments_url":"https://api.github.com/repos/AkshJain99/coala-bears/deployments","created_at":"2018-09-19T15:13:18Z","updated_at":"2018-09-19T15:13:21Z","pushed_at":"2018-10-18T15:30:32Z","git_url":"git://github.com/AkshJain99/coala-bears.git","ssh_url":"[email protected]:AkshJain99/coala-bears.git","clone_url":"https://github.com/AkshJain99/coala-bears.git","svn_url":"https://github.com/AkshJain99/coala-bears","homepage":"https://coala.io/","size":6031,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"coala:master","ref":"master","sha":"d907a6f717032fba6d86ce3f10cee0e2a9252c55","user":{"login":"coala","id":10620750,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjIwNzUw","avatar_url":"https://avatars3.githubusercontent.com/u/10620750?v=4","gravatar_id":"","url":"https://api.github.com/users/coala","html_url":"https://github.com/coala","followers_url":"https://api.github.com/users/coala/followers","following_url":"https://api.github.com/users/coala/following{/other_user}","gists_url":"https://api.github.com/users/coala/gists{/gist_id}","starred_url":"https://api.github.com/users/coala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coala/subscriptions","organizations_url":"https://api.github.com/users/coala/orgs","repos_url":"https://api.github.com/users/coala/repos","events_url":"https://api.github.com/users/coala/events{/privacy}","received_events_url":"https://api.github.com/users/coala/received_events","type":"Organization","site_admin":false},"repo":{"id":51688289,"node_id":"MDEwOlJlcG9zaXRvcnk1MTY4ODI4OQ==","name":"coala-bears","full_name":"coala/coala-bears","private":false,"owner":{"login":"coala","id":10620750,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjIwNzUw","avatar_url":"https://avatars3.githubusercontent.com/u/10620750?v=4","gravatar_id":"","url":"https://api.github.com/users/coala","html_url":"https://github.com/coala","followers_url":"https://api.github.com/users/coala/followers","following_url":"https://api.github.com/users/coala/following{/other_user}","gists_url":"https://api.github.com/users/coala/gists{/gist_id}","starred_url":"https://api.github.com/users/coala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coala/subscriptions","organizations_url":"https://api.github.com/users/coala/orgs","repos_url":"https://api.github.com/users/coala/repos","events_url":"https://api.github.com/users/coala/events{/privacy}","received_events_url":"https://api.github.com/users/coala/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/coala/coala-bears","description":"Bears for coala","fork":false,"url":"https://api.github.com/repos/coala/coala-bears","forks_url":"https://api.github.com/repos/coala/coala-bears/forks","keys_url":"https://api.github.com/repos/coala/coala-bears/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coala/coala-bears/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coala/coala-bears/teams","hooks_url":"https://api.github.com/repos/coala/coala-bears/hooks","issue_events_url":"https://api.github.com/repos/coala/coala-bears/issues/events{/number}","events_url":"https://api.github.com/repos/coala/coala-bears/events","assignees_url":"https://api.github.com/repos/coala/coala-bears/assignees{/user}","branches_url":"https://api.github.com/repos/coala/coala-bears/branches{/branch}","tags_url":"https://api.github.com/repos/coala/coala-bears/tags","blobs_url":"https://api.github.com/repos/coala/coala-bears/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coala/coala-bears/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coala/coala-bears/git/refs{/sha}","trees_url":"https://api.github.com/repos/coala/coala-bears/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coala/coala-bears/statuses/{sha}","languages_url":"https://api.github.com/repos/coala/coala-bears/languages","stargazers_url":"https://api.github.com/repos/coala/coala-bears/stargazers","contributors_url":"https://api.github.com/repos/coala/coala-bears/contributors","subscribers_url":"https://api.github.com/repos/coala/coala-bears/subscribers","subscription_url":"https://api.github.com/repos/coala/coala-bears/subscription","commits_url":"https://api.github.com/repos/coala/coala-bears/commits{/sha}","git_commits_url":"https://api.github.com/repos/coala/coala-bears/git/commits{/sha}","comments_url":"https://api.github.com/repos/coala/coala-bears/comments{/number}","issue_comment_url":"https://api.github.com/repos/coala/coala-bears/issues/comments{/number}","contents_url":"https://api.github.com/repos/coala/coala-bears/contents/{+path}","compare_url":"https://api.github.com/repos/coala/coala-bears/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coala/coala-bears/merges","archive_url":"https://api.github.com/repos/coala/coala-bears/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coala/coala-bears/downloads","issues_url":"https://api.github.com/repos/coala/coala-bears/issues{/number}","pulls_url":"https://api.github.com/repos/coala/coala-bears/pulls{/number}","milestones_url":"https://api.github.com/repos/coala/coala-bears/milestones{/number}","notifications_url":"https://api.github.com/repos/coala/coala-bears/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coala/coala-bears/labels{/name}","releases_url":"https://api.github.com/repos/coala/coala-bears/releases{/id}","deployments_url":"https://api.github.com/repos/coala/coala-bears/deployments","created_at":"2016-02-14T09:25:11Z","updated_at":"2018-10-14T09:50:35Z","pushed_at":"2018-10-18T15:30:36Z","git_url":"git://github.com/coala/coala-bears.git","ssh_url":"[email protected]:coala/coala-bears.git","clone_url":"https://github.com/coala/coala-bears.git","svn_url":"https://github.com/coala/coala-bears","homepage":"https://coala.io/","size":2304,"stargazers_count":209,"watchers_count":209,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":535,"mirror_url":null,"archived":false,"open_issues_count":642,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":535,"open_issues":642,"watchers":209,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/coala/coala-bears/pulls/2701"},"html":{"href":"https://github.com/coala/coala-bears/pull/2701"},"issue":{"href":"https://api.github.com/repos/coala/coala-bears/issues/2701"},"comments":{"href":"https://api.github.com/repos/coala/coala-bears/issues/2701/comments"},"review_comments":{"href":"https://api.github.com/repos/coala/coala-bears/pulls/2701/comments"},"review_comment":{"href":"https://api.github.com/repos/coala/coala-bears/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/coala/coala-bears/pulls/2701/commits"},"statuses":{"href":"https://api.github.com/repos/coala/coala-bears/statuses/a1e118c578a5045f540de6072260152313dde4bf"}},"author_association":"MEMBER"}} | {
"id": 51688289,
"name": "coala/coala-bears",
"url": "https://api.github.com/repos/coala/coala-bears"
} | {
"id": 26381717,
"login": "sangamcse",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/26381717?",
"url": "https://api.github.com/users/sangamcse"
} | {
"id": 10620750,
"login": "coala",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/10620750?",
"url": "https://api.github.com/orgs/coala"
} | 2018-10-18T17:45:42 | 8444206481 | {"actor":{"display_login":"sangamcse"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/apple/swift/pulls/comments/183951847","pull_request_review_id":115048245,"id":183951847,"diff_hunk":"@@ -581,7 +581,7 @@ std::pair<bool, Pattern*> NameMatcher::walkToPatternPre(Pattern *P) {\n if (isDone() || shouldSkip(P->getSourceRange()))\n return std::make_pair(false, P);\n \n- tryResolve(ASTWalker::ParentTy(P), P->getLoc());\n+ tryResolve(ASTWalker::ParentTy(P), P->getStartLoc());","path":"lib/IDE/SwiftSourceDocInfo.cpp","position":5,"original_position":5,"commit_id":"a0b37596e77e9909943554767653929cf3bc9cd1","original_commit_id":"a0b37596e77e9909943554767653929cf3bc9cd1","user":{"login":"rintaro","id":142081,"avatar_url":"https://avatars1.githubusercontent.com/u/142081?v=4","gravatar_id":"","url":"https://api.github.com/users/rintaro","html_url":"https://github.com/rintaro","followers_url":"https://api.github.com/users/rintaro/followers","following_url":"https://api.github.com/users/rintaro/following{/other_user}","gists_url":"https://api.github.com/users/rintaro/gists{/gist_id}","starred_url":"https://api.github.com/users/rintaro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rintaro/subscriptions","organizations_url":"https://api.github.com/users/rintaro/orgs","repos_url":"https://api.github.com/users/rintaro/repos","events_url":"https://api.github.com/users/rintaro/events{/privacy}","received_events_url":"https://api.github.com/users/rintaro/received_events","type":"User","site_admin":false},"body":"@nkcsgexi is this OK?","created_at":"2018-04-25T06:28:54Z","updated_at":"2018-04-25T06:28:54Z","html_url":"https://github.com/apple/swift/pull/16130#discussion_r183951847","pull_request_url":"https://api.github.com/repos/apple/swift/pulls/16130","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/apple/swift/pulls/comments/183951847"},"html":{"href":"https://github.com/apple/swift/pull/16130#discussion_r183951847"},"pull_request":{"href":"https://api.github.com/repos/apple/swift/pulls/16130"}}},"pull_request":{"url":"https://api.github.com/repos/apple/swift/pulls/16130","id":183721688,"html_url":"https://github.com/apple/swift/pull/16130","diff_url":"https://github.com/apple/swift/pull/16130.diff","patch_url":"https://github.com/apple/swift/pull/16130.patch","issue_url":"https://api.github.com/repos/apple/swift/issues/16130","number":16130,"state":"open","locked":false,"title":"[Parse] Discriminate local variables","user":{"login":"rintaro","id":142081,"avatar_url":"https://avatars1.githubusercontent.com/u/142081?v=4","gravatar_id":"","url":"https://api.github.com/users/rintaro","html_url":"https://github.com/rintaro","followers_url":"https://api.github.com/users/rintaro/followers","following_url":"https://api.github.com/users/rintaro/following{/other_user}","gists_url":"https://api.github.com/users/rintaro/gists{/gist_id}","starred_url":"https://api.github.com/users/rintaro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rintaro/subscriptions","organizations_url":"https://api.github.com/users/rintaro/orgs","repos_url":"https://api.github.com/users/rintaro/repos","events_url":"https://api.github.com/users/rintaro/events{/privacy}","received_events_url":"https://api.github.com/users/rintaro/received_events","type":"User","site_admin":false},"body":"Set local discriminator for all local `VarDecl`s. Otherwise, they cannot be discriminated with USRs. This change is needed for rename refactoring which uses USR for discrimiating variable names.\r\n\r\n[SR-7205](https://bugs.swift.org/browse/SR-7205), rdar://problem/34701880","created_at":"2018-04-24T12:38:08Z","updated_at":"2018-04-25T06:28:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ff3f31468d1d34b3523ade1609d6bfa9e813d91f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apple/swift/pulls/16130/commits","review_comments_url":"https://api.github.com/repos/apple/swift/pulls/16130/comments","review_comment_url":"https://api.github.com/repos/apple/swift/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apple/swift/issues/16130/comments","statuses_url":"https://api.github.com/repos/apple/swift/statuses/a0b37596e77e9909943554767653929cf3bc9cd1","head":{"label":"rintaro:parse-var-discriminator","ref":"parse-var-discriminator","sha":"a0b37596e77e9909943554767653929cf3bc9cd1","user":{"login":"rintaro","id":142081,"avatar_url":"https://avatars1.githubusercontent.com/u/142081?v=4","gravatar_id":"","url":"https://api.github.com/users/rintaro","html_url":"https://github.com/rintaro","followers_url":"https://api.github.com/users/rintaro/followers","following_url":"https://api.github.com/users/rintaro/following{/other_user}","gists_url":"https://api.github.com/users/rintaro/gists{/gist_id}","starred_url":"https://api.github.com/users/rintaro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rintaro/subscriptions","organizations_url":"https://api.github.com/users/rintaro/orgs","repos_url":"https://api.github.com/users/rintaro/repos","events_url":"https://api.github.com/users/rintaro/events{/privacy}","received_events_url":"https://api.github.com/users/rintaro/received_events","type":"User","site_admin":false},"repo":{"id":53176184,"name":"swift","full_name":"rintaro/swift","owner":{"login":"rintaro","id":142081,"avatar_url":"https://avatars1.githubusercontent.com/u/142081?v=4","gravatar_id":"","url":"https://api.github.com/users/rintaro","html_url":"https://github.com/rintaro","followers_url":"https://api.github.com/users/rintaro/followers","following_url":"https://api.github.com/users/rintaro/following{/other_user}","gists_url":"https://api.github.com/users/rintaro/gists{/gist_id}","starred_url":"https://api.github.com/users/rintaro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rintaro/subscriptions","organizations_url":"https://api.github.com/users/rintaro/orgs","repos_url":"https://api.github.com/users/rintaro/repos","events_url":"https://api.github.com/users/rintaro/events{/privacy}","received_events_url":"https://api.github.com/users/rintaro/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rintaro/swift","description":"The Swift Programming Language","fork":true,"url":"https://api.github.com/repos/rintaro/swift","forks_url":"https://api.github.com/repos/rintaro/swift/forks","keys_url":"https://api.github.com/repos/rintaro/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rintaro/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rintaro/swift/teams","hooks_url":"https://api.github.com/repos/rintaro/swift/hooks","issue_events_url":"https://api.github.com/repos/rintaro/swift/issues/events{/number}","events_url":"https://api.github.com/repos/rintaro/swift/events","assignees_url":"https://api.github.com/repos/rintaro/swift/assignees{/user}","branches_url":"https://api.github.com/repos/rintaro/swift/branches{/branch}","tags_url":"https://api.github.com/repos/rintaro/swift/tags","blobs_url":"https://api.github.com/repos/rintaro/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rintaro/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rintaro/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/rintaro/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rintaro/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/rintaro/swift/languages","stargazers_url":"https://api.github.com/repos/rintaro/swift/stargazers","contributors_url":"https://api.github.com/repos/rintaro/swift/contributors","subscribers_url":"https://api.github.com/repos/rintaro/swift/subscribers","subscription_url":"https://api.github.com/repos/rintaro/swift/subscription","commits_url":"https://api.github.com/repos/rintaro/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/rintaro/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/rintaro/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/rintaro/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/rintaro/swift/contents/{+path}","compare_url":"https://api.github.com/repos/rintaro/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rintaro/swift/merges","archive_url":"https://api.github.com/repos/rintaro/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rintaro/swift/downloads","issues_url":"https://api.github.com/repos/rintaro/swift/issues{/number}","pulls_url":"https://api.github.com/repos/rintaro/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/rintaro/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/rintaro/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rintaro/swift/labels{/name}","releases_url":"https://api.github.com/repos/rintaro/swift/releases{/id}","deployments_url":"https://api.github.com/repos/rintaro/swift/deployments","created_at":"2016-03-05T01:24:05Z","updated_at":"2016-11-12T08:40:05Z","pushed_at":"2018-04-25T03:15:51Z","git_url":"git://github.com/rintaro/swift.git","ssh_url":"[email protected]:rintaro/swift.git","clone_url":"https://github.com/rintaro/swift.git","svn_url":"https://github.com/rintaro/swift","homepage":"https://swift.org/","size":268196,"stargazers_count":1,"watchers_count":1,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":2,"open_issues":0,"watchers":1,"default_branch":"empty"}},"base":{"label":"apple:master","ref":"master","sha":"128c50f91bc54a8e42d870047e84c27d18972601","user":{"login":"apple","id":10639145,"avatar_url":"https://avatars0.githubusercontent.com/u/10639145?v=4","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"repo":{"id":44838949,"name":"swift","full_name":"apple/swift","owner":{"login":"apple","id":10639145,"avatar_url":"https://avatars0.githubusercontent.com/u/10639145?v=4","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apple/swift","description":"The Swift Programming Language","fork":false,"url":"https://api.github.com/repos/apple/swift","forks_url":"https://api.github.com/repos/apple/swift/forks","keys_url":"https://api.github.com/repos/apple/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apple/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apple/swift/teams","hooks_url":"https://api.github.com/repos/apple/swift/hooks","issue_events_url":"https://api.github.com/repos/apple/swift/issues/events{/number}","events_url":"https://api.github.com/repos/apple/swift/events","assignees_url":"https://api.github.com/repos/apple/swift/assignees{/user}","branches_url":"https://api.github.com/repos/apple/swift/branches{/branch}","tags_url":"https://api.github.com/repos/apple/swift/tags","blobs_url":"https://api.github.com/repos/apple/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apple/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apple/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/apple/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apple/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/apple/swift/languages","stargazers_url":"https://api.github.com/repos/apple/swift/stargazers","contributors_url":"https://api.github.com/repos/apple/swift/contributors","subscribers_url":"https://api.github.com/repos/apple/swift/subscribers","subscription_url":"https://api.github.com/repos/apple/swift/subscription","commits_url":"https://api.github.com/repos/apple/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/apple/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/apple/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/apple/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/apple/swift/contents/{+path}","compare_url":"https://api.github.com/repos/apple/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apple/swift/merges","archive_url":"https://api.github.com/repos/apple/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apple/swift/downloads","issues_url":"https://api.github.com/repos/apple/swift/issues{/number}","pulls_url":"https://api.github.com/repos/apple/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/apple/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/apple/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apple/swift/labels{/name}","releases_url":"https://api.github.com/repos/apple/swift/releases{/id}","deployments_url":"https://api.github.com/repos/apple/swift/deployments","created_at":"2015-10-23T21:15:07Z","updated_at":"2018-04-25T06:03:56Z","pushed_at":"2018-04-25T06:09:29Z","git_url":"git://github.com/apple/swift.git","ssh_url":"[email protected]:apple/swift.git","clone_url":"https://github.com/apple/swift.git","svn_url":"https://github.com/apple/swift","homepage":"https://swift.org/","size":282236,"stargazers_count":43564,"watchers_count":43564,"language":"C++","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":6829,"mirror_url":null,"archived":false,"open_issues_count":308,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":6829,"open_issues":308,"watchers":43564,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apple/swift/pulls/16130"},"html":{"href":"https://github.com/apple/swift/pull/16130"},"issue":{"href":"https://api.github.com/repos/apple/swift/issues/16130"},"comments":{"href":"https://api.github.com/repos/apple/swift/issues/16130/comments"},"review_comments":{"href":"https://api.github.com/repos/apple/swift/pulls/16130/comments"},"review_comment":{"href":"https://api.github.com/repos/apple/swift/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apple/swift/pulls/16130/commits"},"statuses":{"href":"https://api.github.com/repos/apple/swift/statuses/a0b37596e77e9909943554767653929cf3bc9cd1"}},"author_association":"MEMBER"}} | {
"id": 44838949,
"name": "apple/swift",
"url": "https://api.github.com/repos/apple/swift"
} | {
"id": 142081,
"login": "rintaro",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/142081?",
"url": "https://api.github.com/users/rintaro"
} | {
"id": 10639145,
"login": "apple",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/10639145?",
"url": "https://api.github.com/orgs/apple"
} | 2018-04-25T06:28:54 | 7582787569 | {"actor":{"display_login":"rintaro"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/apple/swift-nio/pulls/comments/183450865","pull_request_review_id":114451638,"id":183450865,"diff_hunk":"@@ -50,36 +50,63 @@ public struct CircularBuffer<E>: CustomStringConvertible, AppendableCollection {\n ///\n /// Amortized *O(1)*\n public mutating func append(_ value: E) {\n+ return self.addLast(value)\n+ }\n+\n+ /// Add an element to the end of the ring buffer.\n+ ///\n+ /// Amortized *O(1)*\n+ public mutating func addLast(_ value: E) {\n self.buffer[self.tailIdx] = value\n self.tailIdx = (self.tailIdx + 1) & self.mask\n \n if self.headIdx == self.tailIdx {\n // No more room left for another append so grow the buffer now.\n- var newBacking: ContiguousArray<E?> = []\n- let newCapacity = self.buffer.count << 1 // Double the storage.\n- precondition(newCapacity > 0, \"Can't double capacity of \\(self.buffer.count)\")\n- assert(newCapacity % 2 == 0)\n-\n- newBacking.reserveCapacity(newCapacity)\n- newBacking.append(contentsOf: self.buffer[self.headIdx..<self.buffer.count])\n- if self.headIdx > 0 {\n- newBacking.append(contentsOf: self.buffer[0..<self.headIdx])\n- }\n- newBacking.append(contentsOf: repeatElement(nil, count: newCapacity - newBacking.count))\n- self.tailIdx = self.buffer.count\n- self.headIdx = 0\n- self.buffer = newBacking\n+ self.doubleCapacity()\n+ }\n+ }\n+\n+ /// Add an element to the front of the ring buffer.\n+ ///\n+ /// Amortized *O(1)*\n+ public mutating func addFirst(_ value: E) {","path":"Sources/NIO/CircularBuffer.swift","position":37,"original_position":37,"commit_id":"198528428e942abe7a2abda529f433934661e941","original_commit_id":"198528428e942abe7a2abda529f433934661e941","user":{"login":"weissi","id":624238,"avatar_url":"https://avatars2.githubusercontent.com/u/624238?v=4","gravatar_id":"","url":"https://api.github.com/users/weissi","html_url":"https://github.com/weissi","followers_url":"https://api.github.com/users/weissi/followers","following_url":"https://api.github.com/users/weissi/following{/other_user}","gists_url":"https://api.github.com/users/weissi/gists{/gist_id}","starred_url":"https://api.github.com/users/weissi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weissi/subscriptions","organizations_url":"https://api.github.com/users/weissi/orgs","repos_url":"https://api.github.com/users/weissi/repos","events_url":"https://api.github.com/users/weissi/events{/privacy}","received_events_url":"https://api.github.com/users/weissi/received_events","type":"User","site_admin":false},"body":"@Lukasa isn't `RangeReplaceableCollection` a thing where you can replace any range by any other range? So for example put 5 elements in a space where there used to be 3 ?\r\n\r\nLike `thing[1...3] = [\"foo\", \"bar\", \"buz\", \"qux\", \"quux\"]` ?","created_at":"2018-04-23T16:06:57Z","updated_at":"2018-04-23T16:06:58Z","html_url":"https://github.com/apple/swift-nio/pull/347#discussion_r183450865","pull_request_url":"https://api.github.com/repos/apple/swift-nio/pulls/347","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apple/swift-nio/pulls/comments/183450865"},"html":{"href":"https://github.com/apple/swift-nio/pull/347#discussion_r183450865"},"pull_request":{"href":"https://api.github.com/repos/apple/swift-nio/pulls/347"}},"in_reply_to_id":183440334},"pull_request":{"url":"https://api.github.com/repos/apple/swift-nio/pulls/347","id":183390485,"html_url":"https://github.com/apple/swift-nio/pull/347","diff_url":"https://github.com/apple/swift-nio/pull/347.diff","patch_url":"https://github.com/apple/swift-nio/pull/347.patch","issue_url":"https://api.github.com/repos/apple/swift-nio/issues/347","number":347,"state":"open","locked":false,"title":"Add last / addFirst to CircularBuffer","user":{"login":"normanmaurer","id":439362,"avatar_url":"https://avatars3.githubusercontent.com/u/439362?v=4","gravatar_id":"","url":"https://api.github.com/users/normanmaurer","html_url":"https://github.com/normanmaurer","followers_url":"https://api.github.com/users/normanmaurer/followers","following_url":"https://api.github.com/users/normanmaurer/following{/other_user}","gists_url":"https://api.github.com/users/normanmaurer/gists{/gist_id}","starred_url":"https://api.github.com/users/normanmaurer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/normanmaurer/subscriptions","organizations_url":"https://api.github.com/users/normanmaurer/orgs","repos_url":"https://api.github.com/users/normanmaurer/repos","events_url":"https://api.github.com/users/normanmaurer/events{/privacy}","received_events_url":"https://api.github.com/users/normanmaurer/received_events","type":"User","site_admin":false},"body":"Motivation:\r\n\r\nIts often useful to be able to add / retrieve elements on both sides of a CircularBuffer.\r\n\r\nModifications:\r\n\r\n- Add last / addFirst to be able to act on both ends.\r\n- Add tests\r\n\r\nResult:\r\n\r\nFixes https://github.com/apple/swift-nio/issues/279","created_at":"2018-04-23T10:30:02Z","updated_at":"2018-04-23T16:06:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4eb7e5766dad5a65601d335280cce07ea70c7fa5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":844994002,"url":"https://api.github.com/repos/apple/swift-nio/labels/needs-minor-version-bump","name":"needs-minor-version-bump","color":"CE32BC","default":false}],"milestone":{"url":"https://api.github.com/repos/apple/swift-nio/milestones/12","html_url":"https://github.com/apple/swift-nio/milestone/12","labels_url":"https://api.github.com/repos/apple/swift-nio/milestones/12/labels","id":3288800,"number":12,"title":"1.6.0","description":null,"creator":{"login":"Lukasa","id":1382556,"avatar_url":"https://avatars1.githubusercontent.com/u/1382556?v=4","gravatar_id":"","url":"https://api.github.com/users/Lukasa","html_url":"https://github.com/Lukasa","followers_url":"https://api.github.com/users/Lukasa/followers","following_url":"https://api.github.com/users/Lukasa/following{/other_user}","gists_url":"https://api.github.com/users/Lukasa/gists{/gist_id}","starred_url":"https://api.github.com/users/Lukasa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lukasa/subscriptions","organizations_url":"https://api.github.com/users/Lukasa/orgs","repos_url":"https://api.github.com/users/Lukasa/repos","events_url":"https://api.github.com/users/Lukasa/events{/privacy}","received_events_url":"https://api.github.com/users/Lukasa/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":3,"state":"open","created_at":"2018-04-23T09:47:09Z","updated_at":"2018-04-23T13:10:53Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/apple/swift-nio/pulls/347/commits","review_comments_url":"https://api.github.com/repos/apple/swift-nio/pulls/347/comments","review_comment_url":"https://api.github.com/repos/apple/swift-nio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apple/swift-nio/issues/347/comments","statuses_url":"https://api.github.com/repos/apple/swift-nio/statuses/198528428e942abe7a2abda529f433934661e941","head":{"label":"normanmaurer:deque","ref":"deque","sha":"198528428e942abe7a2abda529f433934661e941","user":{"login":"normanmaurer","id":439362,"avatar_url":"https://avatars3.githubusercontent.com/u/439362?v=4","gravatar_id":"","url":"https://api.github.com/users/normanmaurer","html_url":"https://github.com/normanmaurer","followers_url":"https://api.github.com/users/normanmaurer/followers","following_url":"https://api.github.com/users/normanmaurer/following{/other_user}","gists_url":"https://api.github.com/users/normanmaurer/gists{/gist_id}","starred_url":"https://api.github.com/users/normanmaurer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/normanmaurer/subscriptions","organizations_url":"https://api.github.com/users/normanmaurer/orgs","repos_url":"https://api.github.com/users/normanmaurer/repos","events_url":"https://api.github.com/users/normanmaurer/events{/privacy}","received_events_url":"https://api.github.com/users/normanmaurer/received_events","type":"User","site_admin":false},"repo":{"id":123526297,"name":"swift-nio","full_name":"normanmaurer/swift-nio","owner":{"login":"normanmaurer","id":439362,"avatar_url":"https://avatars3.githubusercontent.com/u/439362?v=4","gravatar_id":"","url":"https://api.github.com/users/normanmaurer","html_url":"https://github.com/normanmaurer","followers_url":"https://api.github.com/users/normanmaurer/followers","following_url":"https://api.github.com/users/normanmaurer/following{/other_user}","gists_url":"https://api.github.com/users/normanmaurer/gists{/gist_id}","starred_url":"https://api.github.com/users/normanmaurer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/normanmaurer/subscriptions","organizations_url":"https://api.github.com/users/normanmaurer/orgs","repos_url":"https://api.github.com/users/normanmaurer/repos","events_url":"https://api.github.com/users/normanmaurer/events{/privacy}","received_events_url":"https://api.github.com/users/normanmaurer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/normanmaurer/swift-nio","description":"Event-driven network application framework for high performance protocol servers & clients, non-blocking.","fork":true,"url":"https://api.github.com/repos/normanmaurer/swift-nio","forks_url":"https://api.github.com/repos/normanmaurer/swift-nio/forks","keys_url":"https://api.github.com/repos/normanmaurer/swift-nio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/normanmaurer/swift-nio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/normanmaurer/swift-nio/teams","hooks_url":"https://api.github.com/repos/normanmaurer/swift-nio/hooks","issue_events_url":"https://api.github.com/repos/normanmaurer/swift-nio/issues/events{/number}","events_url":"https://api.github.com/repos/normanmaurer/swift-nio/events","assignees_url":"https://api.github.com/repos/normanmaurer/swift-nio/assignees{/user}","branches_url":"https://api.github.com/repos/normanmaurer/swift-nio/branches{/branch}","tags_url":"https://api.github.com/repos/normanmaurer/swift-nio/tags","blobs_url":"https://api.github.com/repos/normanmaurer/swift-nio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/normanmaurer/swift-nio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/normanmaurer/swift-nio/git/refs{/sha}","trees_url":"https://api.github.com/repos/normanmaurer/swift-nio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/normanmaurer/swift-nio/statuses/{sha}","languages_url":"https://api.github.com/repos/normanmaurer/swift-nio/languages","stargazers_url":"https://api.github.com/repos/normanmaurer/swift-nio/stargazers","contributors_url":"https://api.github.com/repos/normanmaurer/swift-nio/contributors","subscribers_url":"https://api.github.com/repos/normanmaurer/swift-nio/subscribers","subscription_url":"https://api.github.com/repos/normanmaurer/swift-nio/subscription","commits_url":"https://api.github.com/repos/normanmaurer/swift-nio/commits{/sha}","git_commits_url":"https://api.github.com/repos/normanmaurer/swift-nio/git/commits{/sha}","comments_url":"https://api.github.com/repos/normanmaurer/swift-nio/comments{/number}","issue_comment_url":"https://api.github.com/repos/normanmaurer/swift-nio/issues/comments{/number}","contents_url":"https://api.github.com/repos/normanmaurer/swift-nio/contents/{+path}","compare_url":"https://api.github.com/repos/normanmaurer/swift-nio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/normanmaurer/swift-nio/merges","archive_url":"https://api.github.com/repos/normanmaurer/swift-nio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/normanmaurer/swift-nio/downloads","issues_url":"https://api.github.com/repos/normanmaurer/swift-nio/issues{/number}","pulls_url":"https://api.github.com/repos/normanmaurer/swift-nio/pulls{/number}","milestones_url":"https://api.github.com/repos/normanmaurer/swift-nio/milestones{/number}","notifications_url":"https://api.github.com/repos/normanmaurer/swift-nio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/normanmaurer/swift-nio/labels{/name}","releases_url":"https://api.github.com/repos/normanmaurer/swift-nio/releases{/id}","deployments_url":"https://api.github.com/repos/normanmaurer/swift-nio/deployments","created_at":"2018-03-02T03:37:41Z","updated_at":"2018-04-23T12:12:47Z","pushed_at":"2018-04-23T12:12:45Z","git_url":"git://github.com/normanmaurer/swift-nio.git","ssh_url":"[email protected]:normanmaurer/swift-nio.git","clone_url":"https://github.com/normanmaurer/swift-nio.git","svn_url":"https://github.com/normanmaurer/swift-nio","homepage":"","size":3301,"stargazers_count":0,"watchers_count":0,"language":"Swift","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apple:master","ref":"master","sha":"9f01374169e4f19785edfebdeda0bfef9ae44abf","user":{"login":"apple","id":10639145,"avatar_url":"https://avatars0.githubusercontent.com/u/10639145?v=4","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"repo":{"id":120498971,"name":"swift-nio","full_name":"apple/swift-nio","owner":{"login":"apple","id":10639145,"avatar_url":"https://avatars0.githubusercontent.com/u/10639145?v=4","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apple/swift-nio","description":"Event-driven network application framework for high performance protocol servers & clients, non-blocking.","fork":false,"url":"https://api.github.com/repos/apple/swift-nio","forks_url":"https://api.github.com/repos/apple/swift-nio/forks","keys_url":"https://api.github.com/repos/apple/swift-nio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apple/swift-nio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apple/swift-nio/teams","hooks_url":"https://api.github.com/repos/apple/swift-nio/hooks","issue_events_url":"https://api.github.com/repos/apple/swift-nio/issues/events{/number}","events_url":"https://api.github.com/repos/apple/swift-nio/events","assignees_url":"https://api.github.com/repos/apple/swift-nio/assignees{/user}","branches_url":"https://api.github.com/repos/apple/swift-nio/branches{/branch}","tags_url":"https://api.github.com/repos/apple/swift-nio/tags","blobs_url":"https://api.github.com/repos/apple/swift-nio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apple/swift-nio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apple/swift-nio/git/refs{/sha}","trees_url":"https://api.github.com/repos/apple/swift-nio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apple/swift-nio/statuses/{sha}","languages_url":"https://api.github.com/repos/apple/swift-nio/languages","stargazers_url":"https://api.github.com/repos/apple/swift-nio/stargazers","contributors_url":"https://api.github.com/repos/apple/swift-nio/contributors","subscribers_url":"https://api.github.com/repos/apple/swift-nio/subscribers","subscription_url":"https://api.github.com/repos/apple/swift-nio/subscription","commits_url":"https://api.github.com/repos/apple/swift-nio/commits{/sha}","git_commits_url":"https://api.github.com/repos/apple/swift-nio/git/commits{/sha}","comments_url":"https://api.github.com/repos/apple/swift-nio/comments{/number}","issue_comment_url":"https://api.github.com/repos/apple/swift-nio/issues/comments{/number}","contents_url":"https://api.github.com/repos/apple/swift-nio/contents/{+path}","compare_url":"https://api.github.com/repos/apple/swift-nio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apple/swift-nio/merges","archive_url":"https://api.github.com/repos/apple/swift-nio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apple/swift-nio/downloads","issues_url":"https://api.github.com/repos/apple/swift-nio/issues{/number}","pulls_url":"https://api.github.com/repos/apple/swift-nio/pulls{/number}","milestones_url":"https://api.github.com/repos/apple/swift-nio/milestones{/number}","notifications_url":"https://api.github.com/repos/apple/swift-nio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apple/swift-nio/labels{/name}","releases_url":"https://api.github.com/repos/apple/swift-nio/releases{/id}","deployments_url":"https://api.github.com/repos/apple/swift-nio/deployments","created_at":"2018-02-06T17:47:31Z","updated_at":"2018-04-23T11:58:58Z","pushed_at":"2018-04-23T16:04:27Z","git_url":"git://github.com/apple/swift-nio.git","ssh_url":"[email protected]:apple/swift-nio.git","clone_url":"https://github.com/apple/swift-nio.git","svn_url":"https://github.com/apple/swift-nio","homepage":"","size":6394,"stargazers_count":3494,"watchers_count":3494,"language":"Swift","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":141,"mirror_url":null,"archived":false,"open_issues_count":50,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":141,"open_issues":50,"watchers":3494,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apple/swift-nio/pulls/347"},"html":{"href":"https://github.com/apple/swift-nio/pull/347"},"issue":{"href":"https://api.github.com/repos/apple/swift-nio/issues/347"},"comments":{"href":"https://api.github.com/repos/apple/swift-nio/issues/347/comments"},"review_comments":{"href":"https://api.github.com/repos/apple/swift-nio/pulls/347/comments"},"review_comment":{"href":"https://api.github.com/repos/apple/swift-nio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apple/swift-nio/pulls/347/commits"},"statuses":{"href":"https://api.github.com/repos/apple/swift-nio/statuses/198528428e942abe7a2abda529f433934661e941"}},"author_association":"MEMBER"}} | {
"id": 120498971,
"name": "apple/swift-nio",
"url": "https://api.github.com/repos/apple/swift-nio"
} | {
"id": 624238,
"login": "weissi",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/624238?",
"url": "https://api.github.com/users/weissi"
} | {
"id": 10639145,
"login": "apple",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/10639145?",
"url": "https://api.github.com/orgs/apple"
} | 2018-04-23T16:06:57 | 7572893636 | {"actor":{"display_login":"weissi"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/ipab-slmc/exotica/pulls/comments/242645163","pull_request_review_id":186205412,"id":242645163,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MjY0NTE2Mw==","diff_hunk":"@@ -631,468 +599,450 @@ PYBIND11_MODULE(_pyexotica, module)\n py::arg(\"Ic\") = KDL::RotationalInertia::Zero())\n .def_static(\"Zero\", &KDL::RigidBodyInertia::Zero);\n \n- py::class_<TaskMap, std::shared_ptr<TaskMap>, Object> taskMap(module, \"TaskMap\");\n- taskMap.def_readonly(\"id\", &TaskMap::Id);\n- taskMap.def_readonly(\"start\", &TaskMap::Start);\n- taskMap.def_readonly(\"length\", &TaskMap::Length);\n- taskMap.def_readonly(\"startJ\", &TaskMap::StartJ);\n- taskMap.def_readonly(\"lengthJ\", &TaskMap::LengthJ);\n- taskMap.def(\"taskSpaceDim\", (int (TaskMap::*)()) & TaskMap::taskSpaceDim);\n- taskMap.def(\"taskSpaceJacobianDim\", &TaskMap::taskSpaceJacobianDim);\n- taskMap.def(\"debug\", &TaskMap::debug);\n-\n- py::class_<TimeIndexedTask, std::shared_ptr<TimeIndexedTask>> timeIndexedTask(module, \"TimeIndexedTask\");\n- timeIndexedTask.def_readonly(\"PhiN\", &TimeIndexedTask::PhiN);\n- timeIndexedTask.def_readonly(\"JN\", &TimeIndexedTask::JN);\n- timeIndexedTask.def_readonly(\"NumTasks\", &TimeIndexedTask::NumTasks);\n- timeIndexedTask.def_readonly(\"y\", &TimeIndexedTask::y);\n- timeIndexedTask.def_readonly(\"ydiff\", &TimeIndexedTask::ydiff);\n- timeIndexedTask.def_readonly(\"Phi\", &TimeIndexedTask::Phi);\n- // timeIndexedTask.def_readonly(\"H\", &TimeIndexedTask::H);\n- timeIndexedTask.def_readonly(\"J\", &TimeIndexedTask::J);\n- timeIndexedTask.def_readonly(\"S\", &TimeIndexedTask::S);\n- timeIndexedTask.def_readonly(\"T\", &TimeIndexedTask::T);\n- timeIndexedTask.def_readonly(\"Tasks\", &TimeIndexedTask::Tasks);\n- timeIndexedTask.def_readonly(\"TaskMaps\", &TimeIndexedTask::TaskMaps);\n-\n- py::class_<EndPoseTask, std::shared_ptr<EndPoseTask>> endPoseTask(module, \"EndPoseTask\");\n- endPoseTask.def_readonly(\"PhiN\", &EndPoseTask::PhiN);\n- endPoseTask.def_readonly(\"JN\", &EndPoseTask::JN);\n- endPoseTask.def_readonly(\"NumTasks\", &EndPoseTask::NumTasks);\n- endPoseTask.def_readonly(\"y\", &EndPoseTask::y);\n- endPoseTask.def_readonly(\"ydiff\", &EndPoseTask::ydiff);\n- endPoseTask.def_readonly(\"Phi\", &EndPoseTask::Phi);\n- // endPoseTask.def_readonly(\"H\", &EndPoseTask::H);\n- endPoseTask.def_readonly(\"J\", &EndPoseTask::J);\n- endPoseTask.def_readonly(\"S\", &EndPoseTask::S);\n- endPoseTask.def_readonly(\"Tasks\", &EndPoseTask::Tasks);\n- endPoseTask.def_readonly(\"TaskMaps\", &EndPoseTask::TaskMaps);\n-\n- py::class_<SamplingTask, std::shared_ptr<SamplingTask>> samplingTask(module, \"SamplingTask\");\n- samplingTask.def_readonly(\"PhiN\", &SamplingTask::PhiN);\n- samplingTask.def_readonly(\"JN\", &SamplingTask::JN);\n- samplingTask.def_readonly(\"NumTasks\", &SamplingTask::NumTasks);\n- samplingTask.def_readonly(\"y\", &SamplingTask::y);\n- samplingTask.def_readonly(\"ydiff\", &SamplingTask::ydiff);\n- samplingTask.def_readonly(\"Phi\", &SamplingTask::Phi);\n- samplingTask.def_readonly(\"S\", &SamplingTask::S);\n- samplingTask.def_readonly(\"Tasks\", &SamplingTask::Tasks);\n- samplingTask.def_readonly(\"TaskMaps\", &SamplingTask::TaskMaps);\n-\n- py::class_<TaskSpaceVector, std::shared_ptr<TaskSpaceVector>> taskSpaceVector(module, \"TaskSpaceVector\");\n- taskSpaceVector.def(\"setZero\", &TaskSpaceVector::setZero);\n- taskSpaceVector.def_readonly(\"data\", &TaskSpaceVector::data);\n- taskSpaceVector.def(\"__sub__\", &TaskSpaceVector::operator-, py::is_operator());\n- taskSpaceVector.def(\"__repr__\", [](TaskSpaceVector* instance) { return ((std::ostringstream&)(std::ostringstream(\"\") << \"TaskSpaceVector (\" << instance->data.transpose() << \")\")).str(); });\n-\n- py::class_<MotionSolver, std::shared_ptr<MotionSolver>, Object> motionSolver(module, \"MotionSolver\");\n- motionSolver.def_property(\"maxIterations\", &MotionSolver::getNumberOfMaxIterations, &MotionSolver::setNumberOfMaxIterations);\n- motionSolver.def(\"getPlanningTime\", &MotionSolver::getPlanningTime);\n- motionSolver.def(\"specifyProblem\", &MotionSolver::specifyProblem, \"Assign problem to the solver\", py::arg(\"planningProblem\"));\n- motionSolver.def(\n- \"solve\", [](std::shared_ptr<MotionSolver> sol) { return Solve(sol); },\n+ py::class_<TaskMap, std::shared_ptr<TaskMap>, Object> task_map(module, \"TaskMap\");\n+ task_map.def_readonly(\"id\", &TaskMap::Id);\n+ task_map.def_readonly(\"start\", &TaskMap::Start);\n+ task_map.def_readonly(\"length\", &TaskMap::Length);\n+ task_map.def_readonly(\"startJ\", &TaskMap::StartJ);\n+ task_map.def_readonly(\"lengthJ\", &TaskMap::LengthJ);\n+ task_map.def(\"task_space_dim\", (int (TaskMap::*)()) & TaskMap::taskSpaceDim);\n+ task_map.def(\"task_Space_jacobian_dim\", &TaskMap::taskSpaceJacobianDim);\n+\n+ py::class_<TimeIndexedTask, std::shared_ptr<TimeIndexedTask>> time_indexed_task(module, \"TimeIndexedTask\");\n+ time_indexed_task.def_readonly(\"PhiN\", &TimeIndexedTask::PhiN);\n+ time_indexed_task.def_readonly(\"JN\", &TimeIndexedTask::JN);\n+ time_indexed_task.def_readonly(\"num_tasks\", &TimeIndexedTask::NumTasks);\n+ time_indexed_task.def_readonly(\"y\", &TimeIndexedTask::y);\n+ time_indexed_task.def_readonly(\"ydiff\", &TimeIndexedTask::ydiff);\n+ time_indexed_task.def_readonly(\"Phi\", &TimeIndexedTask::Phi);\n+ // time_indexed_task.def_readonly(\"H\", &TimeIndexedTask::H);\n+ time_indexed_task.def_readonly(\"J\", &TimeIndexedTask::J);\n+ time_indexed_task.def_readonly(\"S\", &TimeIndexedTask::S);\n+ time_indexed_task.def_readonly(\"T\", &TimeIndexedTask::T);\n+ time_indexed_task.def_readonly(\"Tasks\", &TimeIndexedTask::Tasks);\n+ time_indexed_task.def_readonly(\"TaskMaps\", &TimeIndexedTask::TaskMaps);\n+\n+ py::class_<EndPoseTask, std::shared_ptr<EndPoseTask>> end_pose_task(module, \"EndPoseTask\");\n+ end_pose_task.def_readonly(\"PhiN\", &EndPoseTask::PhiN);\n+ end_pose_task.def_readonly(\"JN\", &EndPoseTask::JN);\n+ end_pose_task.def_readonly(\"num_tasks\", &EndPoseTask::NumTasks);\n+ end_pose_task.def_readonly(\"y\", &EndPoseTask::y);\n+ end_pose_task.def_readonly(\"ydiff\", &EndPoseTask::ydiff);\n+ end_pose_task.def_readonly(\"Phi\", &EndPoseTask::Phi);\n+ // end_pose_task.def_readonly(\"H\", &EndPoseTask::H);\n+ end_pose_task.def_readonly(\"J\", &EndPoseTask::J);\n+ end_pose_task.def_readonly(\"S\", &EndPoseTask::S);\n+ end_pose_task.def_readonly(\"Tasks\", &EndPoseTask::Tasks);\n+ end_pose_task.def_readonly(\"TaskMaps\", &EndPoseTask::TaskMaps);\n+\n+ py::class_<SamplingTask, std::shared_ptr<SamplingTask>> sampling_task(module, \"SamplingTask\");\n+ sampling_task.def_readonly(\"PhiN\", &SamplingTask::PhiN);\n+ sampling_task.def_readonly(\"JN\", &SamplingTask::JN);\n+ sampling_task.def_readonly(\"num_tasks\", &SamplingTask::NumTasks);\n+ sampling_task.def_readonly(\"y\", &SamplingTask::y);\n+ sampling_task.def_readonly(\"ydiff\", &SamplingTask::ydiff);\n+ sampling_task.def_readonly(\"Phi\", &SamplingTask::Phi);\n+ sampling_task.def_readonly(\"S\", &SamplingTask::S);\n+ sampling_task.def_readonly(\"Tasks\", &SamplingTask::Tasks);\n+ sampling_task.def_readonly(\"TaskMaps\", &SamplingTask::TaskMaps);\n+\n+ py::class_<TaskSpaceVector, std::shared_ptr<TaskSpaceVector>> task_space_vector(module, \"TaskSpaceVector\");\n+ task_space_vector.def(\"set_zero\", &TaskSpaceVector::setZero);\n+ task_space_vector.def_readonly(\"data\", &TaskSpaceVector::data);\n+ task_space_vector.def(\"__sub__\", &TaskSpaceVector::operator-, py::is_operator());\n+ task_space_vector.def(\"__repr__\", [](TaskSpaceVector* instance) { return ((std::ostringstream&)(std::ostringstream(\"\") << \"TaskSpaceVector (\" << instance->data.transpose() << \")\")).str(); });\n+\n+ py::class_<MotionSolver, std::shared_ptr<MotionSolver>, Object> motion_solver(module, \"MotionSolver\");\n+ motion_solver.def_property(\"max_iterations\", &MotionSolver::getNumberOfMaxIterations, &MotionSolver::setNumberOfMaxIterations);\n+ motion_solver.def(\"get_planning_time\", &MotionSolver::getPlanningTime);\n+ motion_solver.def(\"specify_problem\", &MotionSolver::specifyProblem, \"Assign problem to the solver\", py::arg(\"planning_problem\"));\n+ motion_solver.def(\n+ \"solve\", [](std::shared_ptr<MotionSolver> sol) {\n+ Eigen::MatrixXd ret;\n+ sol->Solve(ret);\n+ return ret;\n+ },\n \"Solve the problem\");\n- motionSolver.def(\"getProblem\", &MotionSolver::getProblem, py::return_value_policy::reference_internal);\n-\n- py::class_<PlanningProblem, std::shared_ptr<PlanningProblem>, Object> planningProblem(module, \"PlanningProblem\");\n- planningProblem.def(\"getTasks\", &PlanningProblem::getTasks, py::return_value_policy::reference_internal);\n- planningProblem.def(\"getTaskMaps\", &PlanningProblem::getTaskMaps, py::return_value_policy::reference_internal);\n- planningProblem.def(\"getScene\", &PlanningProblem::getScene, py::return_value_policy::reference_internal);\n- planningProblem.def(\"__repr__\", &PlanningProblem::print, \"String representation of the object\", py::arg(\"prepend\") = std::string(\"\"));\n- planningProblem.def_property(\"startState\", &PlanningProblem::getStartState, &PlanningProblem::setStartState);\n- planningProblem.def_property(\"startTime\", &PlanningProblem::getStartTime, &PlanningProblem::setStartTime);\n- planningProblem.def(\"getNumberOfProblemUpdates\", &PlanningProblem::getNumberOfProblemUpdates);\n- planningProblem.def(\"resetNumberOfProblemUpdates\", &PlanningProblem::resetNumberOfProblemUpdates);\n- planningProblem.def(\"getCostEvolution\", (std::pair<std::vector<double>, std::vector<double>>(PlanningProblem::*)()) & PlanningProblem::getCostEvolution);\n- planningProblem.def(\"isValid\", &PlanningProblem::isValid);\n+ motion_solver.def(\"get_problem\", &MotionSolver::getProblem, py::return_value_policy::reference_internal);\n+\n+ py::class_<PlanningProblem, std::shared_ptr<PlanningProblem>, Object> planning_problem(module, \"PlanningProblem\");\n+ planning_problem.def(\"get_tasks\", &PlanningProblem::getTasks, py::return_value_policy::reference_internal);\n+ planning_problem.def(\"get_task_maps\", &PlanningProblem::getTaskMaps, py::return_value_policy::reference_internal);\n+ planning_problem.def(\"get_scene\", &PlanningProblem::getScene, py::return_value_policy::reference_internal);\n+ planning_problem.def(\"__repr__\", &PlanningProblem::print, \"String representation of the object\", py::arg(\"prepend\") = std::string(\"\"));\n+ planning_problem.def_property(\"start_state\", &PlanningProblem::getStartState, &PlanningProblem::setStartState);\n+ planning_problem.def_property(\"start_time\", &PlanningProblem::getStartTime, &PlanningProblem::setStartTime);\n+ planning_problem.def(\"get_number_of_problem_updates\", &PlanningProblem::getNumberOfProblemUpdates);\n+ planning_problem.def(\"reset_number_of_problem_updates\", &PlanningProblem::resetNumberOfProblemUpdates);\n+ planning_problem.def(\"get_cost_evolution\", (std::pair<std::vector<double>, std::vector<double>>(PlanningProblem::*)()) & PlanningProblem::getCostEvolution);\n+ planning_problem.def(\"is_valid\", &PlanningProblem::isValid);\n \n // Problem types\n py::module prob = module.def_submodule(\"Problems\", \"Problem types\");\n \n- py::class_<UnconstrainedTimeIndexedProblem, std::shared_ptr<UnconstrainedTimeIndexedProblem>, PlanningProblem> unconstrainedTimeIndexedProblem(prob, \"UnconstrainedTimeIndexedProblem\");\n- unconstrainedTimeIndexedProblem.def(\"getDuration\", &UnconstrainedTimeIndexedProblem::getDuration);\n- unconstrainedTimeIndexedProblem.def(\"update\", &UnconstrainedTimeIndexedProblem::Update);\n- unconstrainedTimeIndexedProblem.def(\"setGoal\", &UnconstrainedTimeIndexedProblem::setGoal);\n- unconstrainedTimeIndexedProblem.def(\"setRho\", &UnconstrainedTimeIndexedProblem::setRho);\n- unconstrainedTimeIndexedProblem.def(\"getGoal\", &UnconstrainedTimeIndexedProblem::getGoal);\n- unconstrainedTimeIndexedProblem.def(\"getRho\", &UnconstrainedTimeIndexedProblem::getRho);\n- unconstrainedTimeIndexedProblem.def_property(\"tau\",\n- &UnconstrainedTimeIndexedProblem::getTau,\n- &UnconstrainedTimeIndexedProblem::setTau);\n- unconstrainedTimeIndexedProblem.def_readwrite(\"W\", &UnconstrainedTimeIndexedProblem::W);\n- unconstrainedTimeIndexedProblem.def_property(\n- \"InitialTrajectory\",\n- &UnconstrainedTimeIndexedProblem::getInitialTrajectory,\n- &UnconstrainedTimeIndexedProblem::setInitialTrajectory);\n- unconstrainedTimeIndexedProblem.def_property(\"T\",\n- &UnconstrainedTimeIndexedProblem::getT,\n- &UnconstrainedTimeIndexedProblem::setT);\n- unconstrainedTimeIndexedProblem.def_readonly(\"PhiN\", &UnconstrainedTimeIndexedProblem::PhiN);\n- unconstrainedTimeIndexedProblem.def_readonly(\"JN\", &UnconstrainedTimeIndexedProblem::JN);\n- unconstrainedTimeIndexedProblem.def_readonly(\"N\", &UnconstrainedTimeIndexedProblem::N);\n- unconstrainedTimeIndexedProblem.def_readonly(\"NumTasks\", &UnconstrainedTimeIndexedProblem::NumTasks);\n- unconstrainedTimeIndexedProblem.def_readonly(\"Phi\", &UnconstrainedTimeIndexedProblem::Phi);\n- unconstrainedTimeIndexedProblem.def_readonly(\"J\", &UnconstrainedTimeIndexedProblem::J);\n- unconstrainedTimeIndexedProblem.def(\"getScalarTaskCost\", &UnconstrainedTimeIndexedProblem::getScalarTaskCost);\n- unconstrainedTimeIndexedProblem.def(\"getScalarTaskJacobian\", &UnconstrainedTimeIndexedProblem::getScalarTaskJacobian);\n- unconstrainedTimeIndexedProblem.def(\"getScalarTransitionCost\", &UnconstrainedTimeIndexedProblem::getScalarTransitionCost);\n- unconstrainedTimeIndexedProblem.def(\"getScalarTransitionJacobian\", &UnconstrainedTimeIndexedProblem::getScalarTransitionJacobian);\n- unconstrainedTimeIndexedProblem.def_readonly(\"Cost\", &UnconstrainedTimeIndexedProblem::Cost);\n- unconstrainedTimeIndexedProblem.def_property_readonly(\"KinematicSolutions\", &UnconstrainedTimeIndexedProblem::getKinematicSolutions);\n-\n- py::class_<TimeIndexedProblem, std::shared_ptr<TimeIndexedProblem>, PlanningProblem> timeIndexedProblem(prob, \"TimeIndexedProblem\");\n- timeIndexedProblem.def(\"getDuration\", &TimeIndexedProblem::getDuration);\n- timeIndexedProblem.def(\"update\", &TimeIndexedProblem::Update);\n- timeIndexedProblem.def(\"setGoal\", &TimeIndexedProblem::setGoal);\n- timeIndexedProblem.def(\"setRho\", &TimeIndexedProblem::setRho);\n- timeIndexedProblem.def(\"getGoal\", &TimeIndexedProblem::getGoal);\n- timeIndexedProblem.def(\"getRho\", &TimeIndexedProblem::getRho);\n- timeIndexedProblem.def(\"setGoalEQ\", &TimeIndexedProblem::setGoalEQ);\n- timeIndexedProblem.def(\"setRhoEQ\", &TimeIndexedProblem::setRhoEQ);\n- timeIndexedProblem.def(\"getGoalEQ\", &TimeIndexedProblem::getGoalEQ);\n- timeIndexedProblem.def(\"getRhoEQ\", &TimeIndexedProblem::getRhoEQ);\n- timeIndexedProblem.def(\"setGoalNEQ\", &TimeIndexedProblem::setGoalNEQ);\n- timeIndexedProblem.def(\"setRhoNEQ\", &TimeIndexedProblem::setRhoNEQ);\n- timeIndexedProblem.def(\"getGoalNEQ\", &TimeIndexedProblem::getGoalNEQ);\n- timeIndexedProblem.def(\"getRhoNEQ\", &TimeIndexedProblem::getRhoNEQ);\n- timeIndexedProblem.def_property(\"tau\",\n- &TimeIndexedProblem::getTau,\n- &TimeIndexedProblem::setTau);\n- timeIndexedProblem.def_property(\"qDot_max\", &TimeIndexedProblem::getJointVelocityLimit, &TimeIndexedProblem::setJointVelocityLimit);\n- timeIndexedProblem.def_readwrite(\"W\", &TimeIndexedProblem::W);\n- timeIndexedProblem.def_property(\n- \"InitialTrajectory\",\n- &TimeIndexedProblem::getInitialTrajectory,\n- &TimeIndexedProblem::setInitialTrajectory);\n- timeIndexedProblem.def_property(\"T\",\n- &TimeIndexedProblem::getT,\n- &TimeIndexedProblem::setT);\n- timeIndexedProblem.def_readonly(\"PhiN\", &TimeIndexedProblem::PhiN);\n- timeIndexedProblem.def_readonly(\"JN\", &TimeIndexedProblem::JN);\n- timeIndexedProblem.def_readonly(\"N\", &TimeIndexedProblem::N);\n- timeIndexedProblem.def_readonly(\"NumTasks\", &TimeIndexedProblem::NumTasks);\n- timeIndexedProblem.def_readonly(\"Phi\", &TimeIndexedProblem::Phi);\n- timeIndexedProblem.def_readonly(\"J\", &TimeIndexedProblem::J);\n- timeIndexedProblem.def(\"getScalarTaskCost\", &TimeIndexedProblem::getScalarTaskCost);\n- timeIndexedProblem.def(\"getScalarTaskJacobian\", &TimeIndexedProblem::getScalarTaskJacobian);\n- timeIndexedProblem.def(\"getScalarTransitionCost\", &TimeIndexedProblem::getScalarTransitionCost);\n- timeIndexedProblem.def(\"getScalarTransitionJacobian\", &TimeIndexedProblem::getScalarTransitionJacobian);\n- timeIndexedProblem.def(\"getEquality\", &TimeIndexedProblem::getEquality);\n- timeIndexedProblem.def(\"getEqualityJacobian\", &TimeIndexedProblem::getEqualityJacobian);\n- timeIndexedProblem.def(\"getInequality\", &TimeIndexedProblem::getInequality);\n- timeIndexedProblem.def(\"getInequalityJacobian\", &TimeIndexedProblem::getInequalityJacobian);\n- timeIndexedProblem.def(\"getBounds\", &TimeIndexedProblem::getBounds);\n- timeIndexedProblem.def_readonly(\"Cost\", &TimeIndexedProblem::Cost);\n- timeIndexedProblem.def_readonly(\"Inequality\", &TimeIndexedProblem::Inequality);\n- timeIndexedProblem.def_readonly(\"Equality\", &TimeIndexedProblem::Equality);\n-\n- py::class_<BoundedTimeIndexedProblem, std::shared_ptr<BoundedTimeIndexedProblem>, PlanningProblem> boundedTimeIndexedProblem(prob, \"BoundedTimeIndexedProblem\");\n- boundedTimeIndexedProblem.def(\"getDuration\", &BoundedTimeIndexedProblem::getDuration);\n- boundedTimeIndexedProblem.def(\"update\", &BoundedTimeIndexedProblem::Update);\n- boundedTimeIndexedProblem.def(\"setGoal\", &BoundedTimeIndexedProblem::setGoal);\n- boundedTimeIndexedProblem.def(\"setRho\", &BoundedTimeIndexedProblem::setRho);\n- boundedTimeIndexedProblem.def(\"getGoal\", &BoundedTimeIndexedProblem::getGoal);\n- boundedTimeIndexedProblem.def(\"getRho\", &BoundedTimeIndexedProblem::getRho);\n- boundedTimeIndexedProblem.def_property(\"tau\",\n- &BoundedTimeIndexedProblem::getTau,\n- &BoundedTimeIndexedProblem::setTau);\n- boundedTimeIndexedProblem.def_readwrite(\"W\", &BoundedTimeIndexedProblem::W);\n- boundedTimeIndexedProblem.def_property(\n- \"InitialTrajectory\",\n- &BoundedTimeIndexedProblem::getInitialTrajectory,\n- &BoundedTimeIndexedProblem::setInitialTrajectory);\n- boundedTimeIndexedProblem.def_property(\"T\",\n- &BoundedTimeIndexedProblem::getT,\n- &BoundedTimeIndexedProblem::setT);\n- boundedTimeIndexedProblem.def_readonly(\"PhiN\", &BoundedTimeIndexedProblem::PhiN);\n- boundedTimeIndexedProblem.def_readonly(\"JN\", &BoundedTimeIndexedProblem::JN);\n- boundedTimeIndexedProblem.def_readonly(\"N\", &BoundedTimeIndexedProblem::N);\n- boundedTimeIndexedProblem.def_readonly(\"NumTasks\", &BoundedTimeIndexedProblem::NumTasks);\n- boundedTimeIndexedProblem.def_readonly(\"Phi\", &BoundedTimeIndexedProblem::Phi);\n- boundedTimeIndexedProblem.def_readonly(\"J\", &BoundedTimeIndexedProblem::J);\n- boundedTimeIndexedProblem.def(\"getScalarTaskCost\", &BoundedTimeIndexedProblem::getScalarTaskCost);\n- boundedTimeIndexedProblem.def(\"getScalarTaskJacobian\", &BoundedTimeIndexedProblem::getScalarTaskJacobian);\n- boundedTimeIndexedProblem.def(\"getScalarTransitionCost\", &BoundedTimeIndexedProblem::getScalarTransitionCost);\n- boundedTimeIndexedProblem.def(\"getScalarTransitionJacobian\", &BoundedTimeIndexedProblem::getScalarTransitionJacobian);\n- boundedTimeIndexedProblem.def(\"getBounds\", &BoundedTimeIndexedProblem::getBounds);\n- boundedTimeIndexedProblem.def_readonly(\"Cost\", &BoundedTimeIndexedProblem::Cost);\n-\n- py::class_<UnconstrainedEndPoseProblem, std::shared_ptr<UnconstrainedEndPoseProblem>, PlanningProblem> unconstrainedEndPoseProblem(prob, \"UnconstrainedEndPoseProblem\");\n- unconstrainedEndPoseProblem.def(\"update\", &UnconstrainedEndPoseProblem::Update);\n- unconstrainedEndPoseProblem.def(\"setGoal\", &UnconstrainedEndPoseProblem::setGoal);\n- unconstrainedEndPoseProblem.def(\"setRho\", &UnconstrainedEndPoseProblem::setRho);\n- unconstrainedEndPoseProblem.def(\"getGoal\", &UnconstrainedEndPoseProblem::getGoal);\n- unconstrainedEndPoseProblem.def(\"getRho\", &UnconstrainedEndPoseProblem::getRho);\n- unconstrainedEndPoseProblem.def_readwrite(\"W\", &UnconstrainedEndPoseProblem::W);\n- unconstrainedEndPoseProblem.def_readonly(\"PhiN\", &UnconstrainedEndPoseProblem::PhiN);\n- unconstrainedEndPoseProblem.def_readonly(\"JN\", &UnconstrainedEndPoseProblem::JN);\n- unconstrainedEndPoseProblem.def_readonly(\"N\", &UnconstrainedEndPoseProblem::N);\n- unconstrainedEndPoseProblem.def_readonly(\"NumTasks\", &UnconstrainedEndPoseProblem::NumTasks);\n- unconstrainedEndPoseProblem.def_readonly(\"Phi\", &UnconstrainedEndPoseProblem::Phi);\n- unconstrainedEndPoseProblem.def_readonly(\"J\", &UnconstrainedEndPoseProblem::J);\n- unconstrainedEndPoseProblem.def_property_readonly(\"ydiff\", [](UnconstrainedEndPoseProblem* prob) { return prob->Cost.ydiff; });\n- unconstrainedEndPoseProblem.def_property(\"qNominal\", &UnconstrainedEndPoseProblem::getNominalPose, &UnconstrainedEndPoseProblem::setNominalPose);\n- unconstrainedEndPoseProblem.def(\"getScalarCost\", &UnconstrainedEndPoseProblem::getScalarCost);\n- unconstrainedEndPoseProblem.def(\"getScalarJacobian\", &UnconstrainedEndPoseProblem::getScalarJacobian);\n- unconstrainedEndPoseProblem.def(\"getScalarTaskCost\", &UnconstrainedEndPoseProblem::getScalarTaskCost);\n- unconstrainedEndPoseProblem.def_readonly(\"Cost\", &UnconstrainedEndPoseProblem::Cost);\n-\n- py::class_<EndPoseProblem, std::shared_ptr<EndPoseProblem>, PlanningProblem> endPoseProblem(prob, \"EndPoseProblem\");\n- endPoseProblem.def(\"update\", &EndPoseProblem::Update);\n- endPoseProblem.def(\"setGoal\", &EndPoseProblem::setGoal);\n- endPoseProblem.def(\"setRho\", &EndPoseProblem::setRho);\n- endPoseProblem.def(\"getGoal\", &EndPoseProblem::getGoal);\n- endPoseProblem.def(\"getRho\", &EndPoseProblem::getRho);\n- endPoseProblem.def(\"setGoalEQ\", &EndPoseProblem::setGoalEQ);\n- endPoseProblem.def(\"setRhoEQ\", &EndPoseProblem::setRhoEQ);\n- endPoseProblem.def(\"getGoalEQ\", &EndPoseProblem::getGoalEQ);\n- endPoseProblem.def(\"getRhoEQ\", &EndPoseProblem::getRhoEQ);\n- endPoseProblem.def(\"setGoalNEQ\", &EndPoseProblem::setGoalNEQ);\n- endPoseProblem.def(\"setRhoNEQ\", &EndPoseProblem::setRhoNEQ);\n- endPoseProblem.def(\"getGoalNEQ\", &EndPoseProblem::getGoalNEQ);\n- endPoseProblem.def(\"getRhoNEQ\", &EndPoseProblem::getRhoNEQ);\n- endPoseProblem.def_readwrite(\"W\", &EndPoseProblem::W);\n- endPoseProblem.def_readonly(\"PhiN\", &EndPoseProblem::PhiN);\n- endPoseProblem.def_readonly(\"JN\", &EndPoseProblem::JN);\n- endPoseProblem.def_readonly(\"N\", &EndPoseProblem::N);\n- endPoseProblem.def_readonly(\"NumTasks\", &EndPoseProblem::NumTasks);\n- endPoseProblem.def_readonly(\"Phi\", &EndPoseProblem::Phi);\n- endPoseProblem.def_readonly(\"J\", &EndPoseProblem::J);\n- endPoseProblem.def(\"getScalarCost\", &EndPoseProblem::getScalarCost);\n- endPoseProblem.def(\"getScalarJacobian\", &EndPoseProblem::getScalarJacobian);\n- endPoseProblem.def(\"getScalarTaskCost\", &EndPoseProblem::getScalarTaskCost);\n- endPoseProblem.def(\"getEquality\", &EndPoseProblem::getEquality);\n- endPoseProblem.def(\"getEqualityJacobian\", &EndPoseProblem::getEqualityJacobian);\n- endPoseProblem.def(\"getInequality\", &EndPoseProblem::getInequality);\n- endPoseProblem.def(\"getInequalityJacobian\", &EndPoseProblem::getInequalityJacobian);\n- endPoseProblem.def(\"getBounds\", &EndPoseProblem::getBounds);\n- endPoseProblem.def_readonly(\"Cost\", &EndPoseProblem::Cost);\n- endPoseProblem.def_readonly(\"Inequality\", &EndPoseProblem::Inequality);\n- endPoseProblem.def_readonly(\"Equality\", &EndPoseProblem::Equality);\n-\n- py::class_<BoundedEndPoseProblem, std::shared_ptr<BoundedEndPoseProblem>, PlanningProblem> boundedEndPoseProblem(prob, \"BoundedEndPoseProblem\");\n- boundedEndPoseProblem.def(\"update\", &BoundedEndPoseProblem::Update);\n- boundedEndPoseProblem.def(\"setGoal\", &BoundedEndPoseProblem::setGoal);\n- boundedEndPoseProblem.def(\"setRho\", &BoundedEndPoseProblem::setRho);\n- boundedEndPoseProblem.def(\"getGoal\", &BoundedEndPoseProblem::getGoal);\n- boundedEndPoseProblem.def(\"getRho\", &BoundedEndPoseProblem::getRho);\n- boundedEndPoseProblem.def_readwrite(\"W\", &BoundedEndPoseProblem::W);\n- boundedEndPoseProblem.def_readonly(\"PhiN\", &BoundedEndPoseProblem::PhiN);\n- boundedEndPoseProblem.def_readonly(\"JN\", &BoundedEndPoseProblem::JN);\n- boundedEndPoseProblem.def_readonly(\"N\", &BoundedEndPoseProblem::N);\n- boundedEndPoseProblem.def_readonly(\"NumTasks\", &BoundedEndPoseProblem::NumTasks);\n- boundedEndPoseProblem.def_readonly(\"Phi\", &BoundedEndPoseProblem::Phi);\n- boundedEndPoseProblem.def_readonly(\"J\", &BoundedEndPoseProblem::J);\n- boundedEndPoseProblem.def(\"getScalarCost\", &BoundedEndPoseProblem::getScalarCost);\n- boundedEndPoseProblem.def(\"getScalarJacobian\", &BoundedEndPoseProblem::getScalarJacobian);\n- boundedEndPoseProblem.def(\"getScalarTaskCost\", &BoundedEndPoseProblem::getScalarTaskCost);\n- boundedEndPoseProblem.def(\"getBounds\", &BoundedEndPoseProblem::getBounds);\n- boundedEndPoseProblem.def_readonly(\"Cost\", &BoundedEndPoseProblem::Cost);\n-\n- py::class_<SamplingProblem, std::shared_ptr<SamplingProblem>, PlanningProblem> samplingProblem(prob, \"SamplingProblem\");\n- samplingProblem.def(\"update\", &SamplingProblem::Update);\n- samplingProblem.def_property(\"goalState\", &SamplingProblem::getGoalState, &SamplingProblem::setGoalState);\n- samplingProblem.def(\"getSpaceDim\", &SamplingProblem::getSpaceDim);\n- samplingProblem.def(\"getBounds\", &SamplingProblem::getBounds);\n- samplingProblem.def_readonly(\"N\", &SamplingProblem::N);\n- samplingProblem.def_readonly(\"NumTasks\", &SamplingProblem::NumTasks);\n- samplingProblem.def_readonly(\"Phi\", &SamplingProblem::Phi);\n- samplingProblem.def_readonly(\"Inequality\", &SamplingProblem::Inequality);\n- samplingProblem.def_readonly(\"Equality\", &SamplingProblem::Equality);\n- samplingProblem.def(\"setGoalEQ\", &SamplingProblem::setGoalEQ);\n- samplingProblem.def(\"setRhoEQ\", &SamplingProblem::setRhoEQ);\n- samplingProblem.def(\"getGoalEQ\", &SamplingProblem::getGoalEQ);\n- samplingProblem.def(\"getRhoEQ\", &SamplingProblem::getRhoEQ);\n- samplingProblem.def(\"setGoalNEQ\", &SamplingProblem::setGoalNEQ);\n- samplingProblem.def(\"setRhoNEQ\", &SamplingProblem::setRhoNEQ);\n- samplingProblem.def(\"getGoalNEQ\", &SamplingProblem::getGoalNEQ);\n- samplingProblem.def(\"getRhoNEQ\", &SamplingProblem::getRhoNEQ);\n-\n- py::class_<TimeIndexedSamplingProblem, std::shared_ptr<TimeIndexedSamplingProblem>, PlanningProblem> timeIndexedSamplingProblem(prob, \"TimeIndexedSamplingProblem\");\n- timeIndexedSamplingProblem.def(\"update\", &TimeIndexedSamplingProblem::Update);\n- timeIndexedSamplingProblem.def(\"getSpaceDim\", &TimeIndexedSamplingProblem::getSpaceDim);\n- timeIndexedSamplingProblem.def(\"getBounds\", &TimeIndexedSamplingProblem::getBounds);\n- timeIndexedSamplingProblem.def_property(\"goalState\", &TimeIndexedSamplingProblem::getGoalState, &TimeIndexedSamplingProblem::setGoalState);\n- timeIndexedSamplingProblem.def_property(\"goalTime\", &TimeIndexedSamplingProblem::getGoalTime, &TimeIndexedSamplingProblem::setGoalTime);\n- timeIndexedSamplingProblem.def_readonly(\"N\", &TimeIndexedSamplingProblem::N);\n- timeIndexedSamplingProblem.def_readonly(\"NumTasks\", &TimeIndexedSamplingProblem::NumTasks);\n- timeIndexedSamplingProblem.def_readonly(\"Phi\", &TimeIndexedSamplingProblem::Phi);\n- timeIndexedSamplingProblem.def_readonly(\"Inequality\", &TimeIndexedSamplingProblem::Inequality);\n- timeIndexedSamplingProblem.def_readonly(\"Equality\", &TimeIndexedSamplingProblem::Equality);\n- timeIndexedSamplingProblem.def(\"setGoalEQ\", &TimeIndexedSamplingProblem::setGoalEQ);\n- timeIndexedSamplingProblem.def(\"setRhoEQ\", &TimeIndexedSamplingProblem::setRhoEQ);\n- timeIndexedSamplingProblem.def(\"getGoalEQ\", &TimeIndexedSamplingProblem::getGoalEQ);\n- timeIndexedSamplingProblem.def(\"getRhoEQ\", &TimeIndexedSamplingProblem::getRhoEQ);\n- timeIndexedSamplingProblem.def(\"setGoalNEQ\", &TimeIndexedSamplingProblem::setGoalNEQ);\n- timeIndexedSamplingProblem.def(\"setRhoNEQ\", &TimeIndexedSamplingProblem::setRhoNEQ);\n- timeIndexedSamplingProblem.def(\"getGoalNEQ\", &TimeIndexedSamplingProblem::getGoalNEQ);\n- timeIndexedSamplingProblem.def(\"getRhoNEQ\", &TimeIndexedSamplingProblem::getRhoNEQ);\n-\n- py::class_<CollisionProxy, std::shared_ptr<CollisionProxy>> proxy(module, \"CollisionProxy\");\n- proxy.def(py::init());\n- proxy.def_readonly(\"Contact1\", &CollisionProxy::contact1);\n- proxy.def_readonly(\"Contact2\", &CollisionProxy::contact2);\n- proxy.def_readonly(\"Normal1\", &CollisionProxy::normal1);\n- proxy.def_readonly(\"Normal2\", &CollisionProxy::normal2);\n- proxy.def_readonly(\"Distance\", &CollisionProxy::distance);\n- proxy.def_property_readonly(\"Object1\", [](CollisionProxy* instance) { return (instance->e1 && instance->e2) ? instance->e1->Segment.getName() : std::string(\"\"); });\n- proxy.def_property_readonly(\"Object2\", [](CollisionProxy* instance) { return (instance->e1 && instance->e2) ? instance->e2->Segment.getName() : std::string(\"\"); });\n- proxy.def_property_readonly(\"Transform1\", [](CollisionProxy* instance) { return (instance->e1 && instance->e2) ? instance->e1->Frame : KDL::Frame(); });\n- proxy.def_property_readonly(\"Transform2\", [](CollisionProxy* instance) { return (instance->e1 && instance->e2) ? instance->e2->Frame : KDL::Frame(); });\n- proxy.def(\"__repr__\", &CollisionProxy::print);\n-\n- py::class_<ContinuousCollisionProxy, std::shared_ptr<ContinuousCollisionProxy>> continuous_proxy(module, \"ContinuousCollisionProxy\");\n- continuous_proxy.def(py::init());\n- continuous_proxy.def_readonly(\"ContactTransform1\", &ContinuousCollisionProxy::contact_tf1);\n- continuous_proxy.def_readonly(\"ContactTransform2\", &ContinuousCollisionProxy::contact_tf2);\n- continuous_proxy.def_readonly(\"InCollision\", &ContinuousCollisionProxy::in_collision);\n- continuous_proxy.def_readonly(\"TimeOfContact\", &ContinuousCollisionProxy::time_of_contact);\n- continuous_proxy.def_property_readonly(\"Object1\", [](ContinuousCollisionProxy* instance) { return (instance->e1 && instance->e2) ? instance->e1->Segment.getName() : std::string(\"\"); });\n- continuous_proxy.def_property_readonly(\"Object2\", [](ContinuousCollisionProxy* instance) { return (instance->e1 && instance->e2) ? instance->e2->Segment.getName() : std::string(\"\"); });\n- continuous_proxy.def_property_readonly(\"Transform1\", [](ContinuousCollisionProxy* instance) { return (instance->e1 && instance->e2) ? instance->e1->Frame : KDL::Frame(); });\n- continuous_proxy.def_property_readonly(\"Transform2\", [](ContinuousCollisionProxy* instance) { return (instance->e1 && instance->e2) ? instance->e2->Frame : KDL::Frame(); });\n- continuous_proxy.def(\"__repr__\", &ContinuousCollisionProxy::print);\n+ py::class_<UnconstrainedTimeIndexedProblem, std::shared_ptr<UnconstrainedTimeIndexedProblem>, PlanningProblem> unconstrained_time_indexed_problem(prob, \"UnconstrainedTimeIndexedProblem\");\n+ unconstrained_time_indexed_problem.def(\"get_duration\", &UnconstrainedTimeIndexedProblem::getDuration);\n+ unconstrained_time_indexed_problem.def(\"update\", &UnconstrainedTimeIndexedProblem::Update);\n+ unconstrained_time_indexed_problem.def(\"set_goal\", &UnconstrainedTimeIndexedProblem::setGoal);\n+ unconstrained_time_indexed_problem.def(\"set_rho\", &UnconstrainedTimeIndexedProblem::setRho);\n+ unconstrained_time_indexed_problem.def(\"get_goal\", &UnconstrainedTimeIndexedProblem::getGoal);\n+ unconstrained_time_indexed_problem.def(\"get_rho\", &UnconstrainedTimeIndexedProblem::getRho);\n+ unconstrained_time_indexed_problem.def_property(\"tau\", &UnconstrainedTimeIndexedProblem::getTau, &UnconstrainedTimeIndexedProblem::setTau);\n+ unconstrained_time_indexed_problem.def_readwrite(\"W\", &UnconstrainedTimeIndexedProblem::W);\n+ unconstrained_time_indexed_problem.def_property(\"initial_trajectory\", &UnconstrainedTimeIndexedProblem::getInitialTrajectory, &UnconstrainedTimeIndexedProblem::setInitialTrajectory);\n+ unconstrained_time_indexed_problem.def_property(\"T\", &UnconstrainedTimeIndexedProblem::getT, &UnconstrainedTimeIndexedProblem::setT);\n+ unconstrained_time_indexed_problem.def_readonly(\"PhiN\", &UnconstrainedTimeIndexedProblem::PhiN);\n+ unconstrained_time_indexed_problem.def_readonly(\"JN\", &UnconstrainedTimeIndexedProblem::JN);\n+ unconstrained_time_indexed_problem.def_readonly(\"N\", &UnconstrainedTimeIndexedProblem::N);\n+ unconstrained_time_indexed_problem.def_readonly(\"num_tasks\", &UnconstrainedTimeIndexedProblem::NumTasks);\n+ unconstrained_time_indexed_problem.def_readonly(\"Phi\", &UnconstrainedTimeIndexedProblem::Phi);\n+ unconstrained_time_indexed_problem.def_readonly(\"J\", &UnconstrainedTimeIndexedProblem::J);\n+ unconstrained_time_indexed_problem.def(\"get_scalar_task_cost\", &UnconstrainedTimeIndexedProblem::getScalarTaskCost);\n+ unconstrained_time_indexed_problem.def(\"get_scalar_task_jacobian\", &UnconstrainedTimeIndexedProblem::getScalarTaskJacobian);\n+ unconstrained_time_indexed_problem.def(\"get_scalar_transition_cost\", &UnconstrainedTimeIndexedProblem::getScalarTransitionCost);\n+ unconstrained_time_indexed_problem.def(\"get_scalar_transition_jacobian\", &UnconstrainedTimeIndexedProblem::getScalarTransitionJacobian);\n+ unconstrained_time_indexed_problem.def_readonly(\"Cost\", &UnconstrainedTimeIndexedProblem::Cost);\n+ unconstrained_time_indexed_problem.def_property_readonly(\"kinematic_solutions\", &UnconstrainedTimeIndexedProblem::getKinematicSolutions);\n+\n+ py::class_<TimeIndexedProblem, std::shared_ptr<TimeIndexedProblem>, PlanningProblem> time_indexed_problem(prob, \"TimeIndexedProblem\");\n+ time_indexed_problem.def(\"get_duration\", &TimeIndexedProblem::getDuration);\n+ time_indexed_problem.def(\"update\", &TimeIndexedProblem::Update);\n+ time_indexed_problem.def(\"set_goal\", &TimeIndexedProblem::setGoal);\n+ time_indexed_problem.def(\"set_rho\", &TimeIndexedProblem::setRho);\n+ time_indexed_problem.def(\"get_goal\", &TimeIndexedProblem::getGoal);\n+ time_indexed_problem.def(\"get_rho\", &TimeIndexedProblem::getRho);\n+ time_indexed_problem.def(\"set_goal_eq\", &TimeIndexedProblem::setGoalEQ);\n+ time_indexed_problem.def(\"set_rho_eq\", &TimeIndexedProblem::setRhoEQ);\n+ time_indexed_problem.def(\"get_goal_eq\", &TimeIndexedProblem::getGoalEQ);\n+ time_indexed_problem.def(\"get_rho_eq\", &TimeIndexedProblem::getRhoEQ);\n+ time_indexed_problem.def(\"set_goal_neq\", &TimeIndexedProblem::setGoalNEQ);\n+ time_indexed_problem.def(\"set_rho_neq\", &TimeIndexedProblem::setRhoNEQ);\n+ time_indexed_problem.def(\"get_goal_neq\", &TimeIndexedProblem::getGoalNEQ);\n+ time_indexed_problem.def(\"get_rho_neq\", &TimeIndexedProblem::getRhoNEQ);\n+ time_indexed_problem.def_property(\"tau\", &TimeIndexedProblem::getTau, &TimeIndexedProblem::setTau);\n+ time_indexed_problem.def_property(\"q_dot_max\", &TimeIndexedProblem::getJointVelocityLimit, &TimeIndexedProblem::setJointVelocityLimit);\n+ time_indexed_problem.def_readwrite(\"W\", &TimeIndexedProblem::W);\n+ time_indexed_problem.def_property(\"initial_trajectory\", &TimeIndexedProblem::getInitialTrajectory, &TimeIndexedProblem::setInitialTrajectory);\n+ time_indexed_problem.def_property(\"T\", &TimeIndexedProblem::getT, &TimeIndexedProblem::setT);\n+ time_indexed_problem.def_readonly(\"PhiN\", &TimeIndexedProblem::PhiN);\n+ time_indexed_problem.def_readonly(\"JN\", &TimeIndexedProblem::JN);\n+ time_indexed_problem.def_readonly(\"N\", &TimeIndexedProblem::N);\n+ time_indexed_problem.def_readonly(\"num_tasks\", &TimeIndexedProblem::NumTasks);\n+ time_indexed_problem.def_readonly(\"Phi\", &TimeIndexedProblem::Phi);\n+ time_indexed_problem.def_readonly(\"J\", &TimeIndexedProblem::J);\n+ time_indexed_problem.def(\"get_scalar_task_cost\", &TimeIndexedProblem::getScalarTaskCost);\n+ time_indexed_problem.def(\"get_scalar_task_jacobian\", &TimeIndexedProblem::getScalarTaskJacobian);\n+ time_indexed_problem.def(\"get_scalar_transition_cost\", &TimeIndexedProblem::getScalarTransitionCost);\n+ time_indexed_problem.def(\"get_scalar_transition_jacobian\", &TimeIndexedProblem::getScalarTransitionJacobian);\n+ time_indexed_problem.def(\"get_equality\", &TimeIndexedProblem::getEquality);\n+ time_indexed_problem.def(\"get_equality_jacobian\", &TimeIndexedProblem::getEqualityJacobian);\n+ time_indexed_problem.def(\"get_inequality\", &TimeIndexedProblem::getInequality);\n+ time_indexed_problem.def(\"get_inequality_jacobian\", &TimeIndexedProblem::getInequalityJacobian);\n+ time_indexed_problem.def(\"get_bounds\", &TimeIndexedProblem::getBounds);\n+ time_indexed_problem.def_readonly(\"Cost\", &TimeIndexedProblem::Cost);\n+ time_indexed_problem.def_readonly(\"Inequality\", &TimeIndexedProblem::Inequality);\n+ time_indexed_problem.def_readonly(\"Equality\", &TimeIndexedProblem::Equality);\n+\n+ py::class_<BoundedTimeIndexedProblem, std::shared_ptr<BoundedTimeIndexedProblem>, PlanningProblem> bounded_time_indexed_problem(prob, \"BoundedTimeIndexedProblem\");\n+ bounded_time_indexed_problem.def(\"get_duration\", &BoundedTimeIndexedProblem::getDuration);\n+ bounded_time_indexed_problem.def(\"update\", &BoundedTimeIndexedProblem::Update);\n+ bounded_time_indexed_problem.def(\"set_goal\", &BoundedTimeIndexedProblem::setGoal);\n+ bounded_time_indexed_problem.def(\"set_rho\", &BoundedTimeIndexedProblem::setRho);\n+ bounded_time_indexed_problem.def(\"get_goal\", &BoundedTimeIndexedProblem::getGoal);\n+ bounded_time_indexed_problem.def(\"get_rho\", &BoundedTimeIndexedProblem::getRho);\n+ bounded_time_indexed_problem.def_property(\"tau\", &BoundedTimeIndexedProblem::getTau, &BoundedTimeIndexedProblem::setTau);\n+ bounded_time_indexed_problem.def_readwrite(\"W\", &BoundedTimeIndexedProblem::W);\n+ bounded_time_indexed_problem.def_property(\"initial_trajectory\", &BoundedTimeIndexedProblem::getInitialTrajectory, &BoundedTimeIndexedProblem::setInitialTrajectory);\n+ bounded_time_indexed_problem.def_property(\"T\", &BoundedTimeIndexedProblem::getT, &BoundedTimeIndexedProblem::setT);\n+ bounded_time_indexed_problem.def_readonly(\"PhiN\", &BoundedTimeIndexedProblem::PhiN);\n+ bounded_time_indexed_problem.def_readonly(\"JN\", &BoundedTimeIndexedProblem::JN);\n+ bounded_time_indexed_problem.def_readonly(\"N\", &BoundedTimeIndexedProblem::N);\n+ bounded_time_indexed_problem.def_readonly(\"num_tasks\", &BoundedTimeIndexedProblem::NumTasks);\n+ bounded_time_indexed_problem.def_readonly(\"Phi\", &BoundedTimeIndexedProblem::Phi);\n+ bounded_time_indexed_problem.def_readonly(\"J\", &BoundedTimeIndexedProblem::J);\n+ bounded_time_indexed_problem.def(\"get_scalar_task_cost\", &BoundedTimeIndexedProblem::getScalarTaskCost);\n+ bounded_time_indexed_problem.def(\"get_scalar_task_jacobian\", &BoundedTimeIndexedProblem::getScalarTaskJacobian);\n+ bounded_time_indexed_problem.def(\"get_scalar_transition_cost\", &BoundedTimeIndexedProblem::getScalarTransitionCost);\n+ bounded_time_indexed_problem.def(\"get_scalar_transition_jacobian\", &BoundedTimeIndexedProblem::getScalarTransitionJacobian);\n+ bounded_time_indexed_problem.def(\"get_bounds\", &BoundedTimeIndexedProblem::getBounds);\n+ bounded_time_indexed_problem.def_readonly(\"Cost\", &BoundedTimeIndexedProblem::Cost);\n+\n+ py::class_<UnconstrainedEndPoseProblem, std::shared_ptr<UnconstrainedEndPoseProblem>, PlanningProblem> unconstrained_end_pose_problem(prob, \"UnconstrainedEndPoseProblem\");\n+ unconstrained_end_pose_problem.def(\"update\", &UnconstrainedEndPoseProblem::Update);\n+ unconstrained_end_pose_problem.def(\"set_goal\", &UnconstrainedEndPoseProblem::setGoal);\n+ unconstrained_end_pose_problem.def(\"set_rho\", &UnconstrainedEndPoseProblem::setRho);\n+ unconstrained_end_pose_problem.def(\"get_goal\", &UnconstrainedEndPoseProblem::getGoal);\n+ unconstrained_end_pose_problem.def(\"get_rho\", &UnconstrainedEndPoseProblem::getRho);\n+ unconstrained_end_pose_problem.def_readwrite(\"W\", &UnconstrainedEndPoseProblem::W);\n+ unconstrained_end_pose_problem.def_readonly(\"PhiN\", &UnconstrainedEndPoseProblem::PhiN);\n+ unconstrained_end_pose_problem.def_readonly(\"JN\", &UnconstrainedEndPoseProblem::JN);\n+ unconstrained_end_pose_problem.def_readonly(\"N\", &UnconstrainedEndPoseProblem::N);\n+ unconstrained_end_pose_problem.def_readonly(\"num_tasks\", &UnconstrainedEndPoseProblem::NumTasks);\n+ unconstrained_end_pose_problem.def_readonly(\"Phi\", &UnconstrainedEndPoseProblem::Phi);\n+ unconstrained_end_pose_problem.def_readonly(\"J\", &UnconstrainedEndPoseProblem::J);\n+ unconstrained_end_pose_problem.def_property_readonly(\"ydiff\", [](UnconstrainedEndPoseProblem* prob) { return prob->Cost.ydiff; });\n+ unconstrained_end_pose_problem.def_property(\"q_nominal\", &UnconstrainedEndPoseProblem::getNominalPose, &UnconstrainedEndPoseProblem::setNominalPose);\n+ unconstrained_end_pose_problem.def(\"get_scalar_cost\", &UnconstrainedEndPoseProblem::getScalarCost);\n+ unconstrained_end_pose_problem.def(\"get_scalar_jacobian\", &UnconstrainedEndPoseProblem::getScalarJacobian);\n+ unconstrained_end_pose_problem.def(\"get_scalar_task_cost\", &UnconstrainedEndPoseProblem::getScalarTaskCost);\n+ unconstrained_end_pose_problem.def_readonly(\"Cost\", &UnconstrainedEndPoseProblem::Cost);\n+\n+ py::class_<EndPoseProblem, std::shared_ptr<EndPoseProblem>, PlanningProblem> end_pose_problem(prob, \"EndPoseProblem\");\n+ end_pose_problem.def(\"update\", &EndPoseProblem::Update);\n+ end_pose_problem.def(\"set_goal\", &EndPoseProblem::setGoal);\n+ end_pose_problem.def(\"set_rho\", &EndPoseProblem::setRho);\n+ end_pose_problem.def(\"get_goal\", &EndPoseProblem::getGoal);\n+ end_pose_problem.def(\"get_rho\", &EndPoseProblem::getRho);\n+ end_pose_problem.def(\"set_goal_eq\", &EndPoseProblem::setGoalEQ);\n+ end_pose_problem.def(\"set_rho_eq\", &EndPoseProblem::setRhoEQ);\n+ end_pose_problem.def(\"get_goal_eq\", &EndPoseProblem::getGoalEQ);\n+ end_pose_problem.def(\"get_rho_eq\", &EndPoseProblem::getRhoEQ);\n+ end_pose_problem.def(\"set_goal_neq\", &EndPoseProblem::setGoalNEQ);\n+ end_pose_problem.def(\"set_rho_neq\", &EndPoseProblem::setRhoNEQ);\n+ end_pose_problem.def(\"get_goal_neq\", &EndPoseProblem::getGoalNEQ);\n+ end_pose_problem.def(\"get_rho_neq\", &EndPoseProblem::getRhoNEQ);\n+ end_pose_problem.def_readwrite(\"W\", &EndPoseProblem::W);\n+ end_pose_problem.def_readonly(\"PhiN\", &EndPoseProblem::PhiN);\n+ end_pose_problem.def_readonly(\"JN\", &EndPoseProblem::JN);\n+ end_pose_problem.def_readonly(\"N\", &EndPoseProblem::N);\n+ end_pose_problem.def_readonly(\"num_tasks\", &EndPoseProblem::NumTasks);\n+ end_pose_problem.def_readonly(\"Phi\", &EndPoseProblem::Phi);\n+ end_pose_problem.def_readonly(\"J\", &EndPoseProblem::J);\n+ end_pose_problem.def(\"get_scalar_cost\", &EndPoseProblem::getScalarCost);\n+ end_pose_problem.def(\"get_scalar_jacobian\", &EndPoseProblem::getScalarJacobian);\n+ end_pose_problem.def(\"get_scalar_task_cost\", &EndPoseProblem::getScalarTaskCost);\n+ end_pose_problem.def(\"get_equality\", &EndPoseProblem::getEquality);\n+ end_pose_problem.def(\"get_equality_jacobian\", &EndPoseProblem::getEqualityJacobian);\n+ end_pose_problem.def(\"get_inequality\", &EndPoseProblem::getInequality);\n+ end_pose_problem.def(\"get_inequality_jacobian\", &EndPoseProblem::getInequalityJacobian);\n+ end_pose_problem.def(\"get_bounds\", &EndPoseProblem::getBounds);\n+ end_pose_problem.def_readonly(\"Cost\", &EndPoseProblem::Cost);\n+ end_pose_problem.def_readonly(\"Inequality\", &EndPoseProblem::Inequality);\n+ end_pose_problem.def_readonly(\"Equality\", &EndPoseProblem::Equality);\n+\n+ py::class_<BoundedEndPoseProblem, std::shared_ptr<BoundedEndPoseProblem>, PlanningProblem> bounded_end_pose_problem(prob, \"BoundedEndPoseProblem\");\n+ bounded_end_pose_problem.def(\"update\", &BoundedEndPoseProblem::Update);\n+ bounded_end_pose_problem.def(\"set_goal\", &BoundedEndPoseProblem::setGoal);\n+ bounded_end_pose_problem.def(\"set_rho\", &BoundedEndPoseProblem::setRho);\n+ bounded_end_pose_problem.def(\"get_goal\", &BoundedEndPoseProblem::getGoal);\n+ bounded_end_pose_problem.def(\"get_rho\", &BoundedEndPoseProblem::getRho);\n+ bounded_end_pose_problem.def_readwrite(\"W\", &BoundedEndPoseProblem::W);\n+ bounded_end_pose_problem.def_readonly(\"PhiN\", &BoundedEndPoseProblem::PhiN);\n+ bounded_end_pose_problem.def_readonly(\"JN\", &BoundedEndPoseProblem::JN);\n+ bounded_end_pose_problem.def_readonly(\"N\", &BoundedEndPoseProblem::N);\n+ bounded_end_pose_problem.def_readonly(\"num_tasks\", &BoundedEndPoseProblem::NumTasks);\n+ bounded_end_pose_problem.def_readonly(\"Phi\", &BoundedEndPoseProblem::Phi);\n+ bounded_end_pose_problem.def_readonly(\"J\", &BoundedEndPoseProblem::J);\n+ bounded_end_pose_problem.def(\"get_scalar_cost\", &BoundedEndPoseProblem::getScalarCost);\n+ bounded_end_pose_problem.def(\"get_scalar_jacobian\", &BoundedEndPoseProblem::getScalarJacobian);\n+ bounded_end_pose_problem.def(\"get_scalar_task_cost\", &BoundedEndPoseProblem::getScalarTaskCost);\n+ bounded_end_pose_problem.def(\"get_bounds\", &BoundedEndPoseProblem::getBounds);\n+ bounded_end_pose_problem.def_readonly(\"Cost\", &BoundedEndPoseProblem::Cost);\n+\n+ py::class_<SamplingProblem, std::shared_ptr<SamplingProblem>, PlanningProblem> sampling_problem(prob, \"SamplingProblem\");\n+ sampling_problem.def(\"update\", &SamplingProblem::Update);\n+ sampling_problem.def_property(\"goal_state\", &SamplingProblem::getGoalState, &SamplingProblem::setGoalState);\n+ sampling_problem.def(\"get_space_dim\", &SamplingProblem::getSpaceDim);\n+ sampling_problem.def(\"get_bounds\", &SamplingProblem::getBounds);\n+ sampling_problem.def_readonly(\"N\", &SamplingProblem::N);\n+ sampling_problem.def_readonly(\"num_tasks\", &SamplingProblem::NumTasks);\n+ sampling_problem.def_readonly(\"Phi\", &SamplingProblem::Phi);\n+ sampling_problem.def_readonly(\"Inequality\", &SamplingProblem::Inequality);\n+ sampling_problem.def_readonly(\"Equality\", &SamplingProblem::Equality);","path":"exotica_python/src/Exotica.cpp","position":964,"original_position":964,"commit_id":"a30e89f42f8cd7d56e63f683d2aebc5b5f94f027","original_commit_id":"a30e89f42f8cd7d56e63f683d2aebc5b5f94f027","user":{"login":"VladimirIvan","id":4905049,"node_id":"MDQ6VXNlcjQ5MDUwNDk=","avatar_url":"https://avatars0.githubusercontent.com/u/4905049?v=4","gravatar_id":"","url":"https://api.github.com/users/VladimirIvan","html_url":"https://github.com/VladimirIvan","followers_url":"https://api.github.com/users/VladimirIvan/followers","following_url":"https://api.github.com/users/VladimirIvan/following{/other_user}","gists_url":"https://api.github.com/users/VladimirIvan/gists{/gist_id}","starred_url":"https://api.github.com/users/VladimirIvan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VladimirIvan/subscriptions","organizations_url":"https://api.github.com/users/VladimirIvan/orgs","repos_url":"https://api.github.com/users/VladimirIvan/repos","events_url":"https://api.github.com/users/VladimirIvan/events{/privacy}","received_events_url":"https://api.github.com/users/VladimirIvan/received_events","type":"User","site_admin":false},"body":"Lower case (keep Phi)","created_at":"2018-12-18T18:07:41Z","updated_at":"2018-12-18T18:08:57Z","html_url":"https://github.com/ipab-slmc/exotica/pull/457#discussion_r242645163","pull_request_url":"https://api.github.com/repos/ipab-slmc/exotica/pulls/457","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ipab-slmc/exotica/pulls/comments/242645163"},"html":{"href":"https://github.com/ipab-slmc/exotica/pull/457#discussion_r242645163"},"pull_request":{"href":"https://api.github.com/repos/ipab-slmc/exotica/pulls/457"}}},"pull_request":{"url":"https://api.github.com/repos/ipab-slmc/exotica/pulls/457","id":239475257,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM5NDc1MjU3","html_url":"https://github.com/ipab-slmc/exotica/pull/457","diff_url":"https://github.com/ipab-slmc/exotica/pull/457.diff","patch_url":"https://github.com/ipab-slmc/exotica/pull/457.patch","issue_url":"https://api.github.com/repos/ipab-slmc/exotica/issues/457","number":457,"state":"open","locked":false,"title":"Rename/update API exotica_python","user":{"login":"wxmerkt","id":1664508,"node_id":"MDQ6VXNlcjE2NjQ1MDg=","avatar_url":"https://avatars2.githubusercontent.com/u/1664508?v=4","gravatar_id":"","url":"https://api.github.com/users/wxmerkt","html_url":"https://github.com/wxmerkt","followers_url":"https://api.github.com/users/wxmerkt/followers","following_url":"https://api.github.com/users/wxmerkt/following{/other_user}","gists_url":"https://api.github.com/users/wxmerkt/gists{/gist_id}","starred_url":"https://api.github.com/users/wxmerkt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wxmerkt/subscriptions","organizations_url":"https://api.github.com/users/wxmerkt/orgs","repos_url":"https://api.github.com/users/wxmerkt/repos","events_url":"https://api.github.com/users/wxmerkt/events{/privacy}","received_events_url":"https://api.github.com/users/wxmerkt/received_events","type":"User","site_admin":false},"body":"- Renames entire API in `exotica_python` (minor exception where it mirrors KDL C++ API)\r\n- Updates all examples in `exotica_examples` to comply\r\n- Fixes some examples that were broken\r\n\r\nRelates to #421 ","created_at":"2018-12-18T12:41:36Z","updated_at":"2018-12-18T18:08:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"487486128a90503d13c3a7ccddece6e6523f74f2","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ipab-slmc/exotica/pulls/457/commits","review_comments_url":"https://api.github.com/repos/ipab-slmc/exotica/pulls/457/comments","review_comment_url":"https://api.github.com/repos/ipab-slmc/exotica/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ipab-slmc/exotica/issues/457/comments","statuses_url":"https://api.github.com/repos/ipab-slmc/exotica/statuses/a30e89f42f8cd7d56e63f683d2aebc5b5f94f027","head":{"label":"ipab-slmc:wxm-rename-exotica-python","ref":"wxm-rename-exotica-python","sha":"a30e89f42f8cd7d56e63f683d2aebc5b5f94f027","user":{"login":"ipab-slmc","id":10714328,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNzE0MzI4","avatar_url":"https://avatars0.githubusercontent.com/u/10714328?v=4","gravatar_id":"","url":"https://api.github.com/users/ipab-slmc","html_url":"https://github.com/ipab-slmc","followers_url":"https://api.github.com/users/ipab-slmc/followers","following_url":"https://api.github.com/users/ipab-slmc/following{/other_user}","gists_url":"https://api.github.com/users/ipab-slmc/gists{/gist_id}","starred_url":"https://api.github.com/users/ipab-slmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ipab-slmc/subscriptions","organizations_url":"https://api.github.com/users/ipab-slmc/orgs","repos_url":"https://api.github.com/users/ipab-slmc/repos","events_url":"https://api.github.com/users/ipab-slmc/events{/privacy}","received_events_url":"https://api.github.com/users/ipab-slmc/received_events","type":"Organization","site_admin":false},"repo":{"id":44607894,"node_id":"MDEwOlJlcG9zaXRvcnk0NDYwNzg5NA==","name":"exotica","full_name":"ipab-slmc/exotica","private":false,"owner":{"login":"ipab-slmc","id":10714328,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNzE0MzI4","avatar_url":"https://avatars0.githubusercontent.com/u/10714328?v=4","gravatar_id":"","url":"https://api.github.com/users/ipab-slmc","html_url":"https://github.com/ipab-slmc","followers_url":"https://api.github.com/users/ipab-slmc/followers","following_url":"https://api.github.com/users/ipab-slmc/following{/other_user}","gists_url":"https://api.github.com/users/ipab-slmc/gists{/gist_id}","starred_url":"https://api.github.com/users/ipab-slmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ipab-slmc/subscriptions","organizations_url":"https://api.github.com/users/ipab-slmc/orgs","repos_url":"https://api.github.com/users/ipab-slmc/repos","events_url":"https://api.github.com/users/ipab-slmc/events{/privacy}","received_events_url":"https://api.github.com/users/ipab-slmc/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ipab-slmc/exotica","description":"Extensible Optimization Framework","fork":false,"url":"https://api.github.com/repos/ipab-slmc/exotica","forks_url":"https://api.github.com/repos/ipab-slmc/exotica/forks","keys_url":"https://api.github.com/repos/ipab-slmc/exotica/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ipab-slmc/exotica/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ipab-slmc/exotica/teams","hooks_url":"https://api.github.com/repos/ipab-slmc/exotica/hooks","issue_events_url":"https://api.github.com/repos/ipab-slmc/exotica/issues/events{/number}","events_url":"https://api.github.com/repos/ipab-slmc/exotica/events","assignees_url":"https://api.github.com/repos/ipab-slmc/exotica/assignees{/user}","branches_url":"https://api.github.com/repos/ipab-slmc/exotica/branches{/branch}","tags_url":"https://api.github.com/repos/ipab-slmc/exotica/tags","blobs_url":"https://api.github.com/repos/ipab-slmc/exotica/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ipab-slmc/exotica/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ipab-slmc/exotica/git/refs{/sha}","trees_url":"https://api.github.com/repos/ipab-slmc/exotica/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ipab-slmc/exotica/statuses/{sha}","languages_url":"https://api.github.com/repos/ipab-slmc/exotica/languages","stargazers_url":"https://api.github.com/repos/ipab-slmc/exotica/stargazers","contributors_url":"https://api.github.com/repos/ipab-slmc/exotica/contributors","subscribers_url":"https://api.github.com/repos/ipab-slmc/exotica/subscribers","subscription_url":"https://api.github.com/repos/ipab-slmc/exotica/subscription","commits_url":"https://api.github.com/repos/ipab-slmc/exotica/commits{/sha}","git_commits_url":"https://api.github.com/repos/ipab-slmc/exotica/git/commits{/sha}","comments_url":"https://api.github.com/repos/ipab-slmc/exotica/comments{/number}","issue_comment_url":"https://api.github.com/repos/ipab-slmc/exotica/issues/comments{/number}","contents_url":"https://api.github.com/repos/ipab-slmc/exotica/contents/{+path}","compare_url":"https://api.github.com/repos/ipab-slmc/exotica/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ipab-slmc/exotica/merges","archive_url":"https://api.github.com/repos/ipab-slmc/exotica/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ipab-slmc/exotica/downloads","issues_url":"https://api.github.com/repos/ipab-slmc/exotica/issues{/number}","pulls_url":"https://api.github.com/repos/ipab-slmc/exotica/pulls{/number}","milestones_url":"https://api.github.com/repos/ipab-slmc/exotica/milestones{/number}","notifications_url":"https://api.github.com/repos/ipab-slmc/exotica/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ipab-slmc/exotica/labels{/name}","releases_url":"https://api.github.com/repos/ipab-slmc/exotica/releases{/id}","deployments_url":"https://api.github.com/repos/ipab-slmc/exotica/deployments","created_at":"2015-10-20T13:24:57Z","updated_at":"2018-12-18T17:49:45Z","pushed_at":"2018-12-18T17:49:43Z","git_url":"git://github.com/ipab-slmc/exotica.git","ssh_url":"[email protected]:ipab-slmc/exotica.git","clone_url":"https://github.com/ipab-slmc/exotica.git","svn_url":"https://github.com/ipab-slmc/exotica","homepage":"http://wcms.inf.ed.ac.uk/ipab/slmc/research/EXOTica","size":15701,"stargazers_count":13,"watchers_count":13,"language":"C","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":27,"mirror_url":null,"archived":false,"open_issues_count":33,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":27,"open_issues":33,"watchers":13,"default_branch":"master"}},"base":{"label":"ipab-slmc:master","ref":"master","sha":"e612bbb9328b5a8beeee25711eeb2cd644738b53","user":{"login":"ipab-slmc","id":10714328,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNzE0MzI4","avatar_url":"https://avatars0.githubusercontent.com/u/10714328?v=4","gravatar_id":"","url":"https://api.github.com/users/ipab-slmc","html_url":"https://github.com/ipab-slmc","followers_url":"https://api.github.com/users/ipab-slmc/followers","following_url":"https://api.github.com/users/ipab-slmc/following{/other_user}","gists_url":"https://api.github.com/users/ipab-slmc/gists{/gist_id}","starred_url":"https://api.github.com/users/ipab-slmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ipab-slmc/subscriptions","organizations_url":"https://api.github.com/users/ipab-slmc/orgs","repos_url":"https://api.github.com/users/ipab-slmc/repos","events_url":"https://api.github.com/users/ipab-slmc/events{/privacy}","received_events_url":"https://api.github.com/users/ipab-slmc/received_events","type":"Organization","site_admin":false},"repo":{"id":44607894,"node_id":"MDEwOlJlcG9zaXRvcnk0NDYwNzg5NA==","name":"exotica","full_name":"ipab-slmc/exotica","private":false,"owner":{"login":"ipab-slmc","id":10714328,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNzE0MzI4","avatar_url":"https://avatars0.githubusercontent.com/u/10714328?v=4","gravatar_id":"","url":"https://api.github.com/users/ipab-slmc","html_url":"https://github.com/ipab-slmc","followers_url":"https://api.github.com/users/ipab-slmc/followers","following_url":"https://api.github.com/users/ipab-slmc/following{/other_user}","gists_url":"https://api.github.com/users/ipab-slmc/gists{/gist_id}","starred_url":"https://api.github.com/users/ipab-slmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ipab-slmc/subscriptions","organizations_url":"https://api.github.com/users/ipab-slmc/orgs","repos_url":"https://api.github.com/users/ipab-slmc/repos","events_url":"https://api.github.com/users/ipab-slmc/events{/privacy}","received_events_url":"https://api.github.com/users/ipab-slmc/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ipab-slmc/exotica","description":"Extensible Optimization Framework","fork":false,"url":"https://api.github.com/repos/ipab-slmc/exotica","forks_url":"https://api.github.com/repos/ipab-slmc/exotica/forks","keys_url":"https://api.github.com/repos/ipab-slmc/exotica/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ipab-slmc/exotica/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ipab-slmc/exotica/teams","hooks_url":"https://api.github.com/repos/ipab-slmc/exotica/hooks","issue_events_url":"https://api.github.com/repos/ipab-slmc/exotica/issues/events{/number}","events_url":"https://api.github.com/repos/ipab-slmc/exotica/events","assignees_url":"https://api.github.com/repos/ipab-slmc/exotica/assignees{/user}","branches_url":"https://api.github.com/repos/ipab-slmc/exotica/branches{/branch}","tags_url":"https://api.github.com/repos/ipab-slmc/exotica/tags","blobs_url":"https://api.github.com/repos/ipab-slmc/exotica/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ipab-slmc/exotica/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ipab-slmc/exotica/git/refs{/sha}","trees_url":"https://api.github.com/repos/ipab-slmc/exotica/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ipab-slmc/exotica/statuses/{sha}","languages_url":"https://api.github.com/repos/ipab-slmc/exotica/languages","stargazers_url":"https://api.github.com/repos/ipab-slmc/exotica/stargazers","contributors_url":"https://api.github.com/repos/ipab-slmc/exotica/contributors","subscribers_url":"https://api.github.com/repos/ipab-slmc/exotica/subscribers","subscription_url":"https://api.github.com/repos/ipab-slmc/exotica/subscription","commits_url":"https://api.github.com/repos/ipab-slmc/exotica/commits{/sha}","git_commits_url":"https://api.github.com/repos/ipab-slmc/exotica/git/commits{/sha}","comments_url":"https://api.github.com/repos/ipab-slmc/exotica/comments{/number}","issue_comment_url":"https://api.github.com/repos/ipab-slmc/exotica/issues/comments{/number}","contents_url":"https://api.github.com/repos/ipab-slmc/exotica/contents/{+path}","compare_url":"https://api.github.com/repos/ipab-slmc/exotica/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ipab-slmc/exotica/merges","archive_url":"https://api.github.com/repos/ipab-slmc/exotica/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ipab-slmc/exotica/downloads","issues_url":"https://api.github.com/repos/ipab-slmc/exotica/issues{/number}","pulls_url":"https://api.github.com/repos/ipab-slmc/exotica/pulls{/number}","milestones_url":"https://api.github.com/repos/ipab-slmc/exotica/milestones{/number}","notifications_url":"https://api.github.com/repos/ipab-slmc/exotica/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ipab-slmc/exotica/labels{/name}","releases_url":"https://api.github.com/repos/ipab-slmc/exotica/releases{/id}","deployments_url":"https://api.github.com/repos/ipab-slmc/exotica/deployments","created_at":"2015-10-20T13:24:57Z","updated_at":"2018-12-18T17:49:45Z","pushed_at":"2018-12-18T17:49:43Z","git_url":"git://github.com/ipab-slmc/exotica.git","ssh_url":"[email protected]:ipab-slmc/exotica.git","clone_url":"https://github.com/ipab-slmc/exotica.git","svn_url":"https://github.com/ipab-slmc/exotica","homepage":"http://wcms.inf.ed.ac.uk/ipab/slmc/research/EXOTica","size":15701,"stargazers_count":13,"watchers_count":13,"language":"C","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":27,"mirror_url":null,"archived":false,"open_issues_count":33,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":27,"open_issues":33,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ipab-slmc/exotica/pulls/457"},"html":{"href":"https://github.com/ipab-slmc/exotica/pull/457"},"issue":{"href":"https://api.github.com/repos/ipab-slmc/exotica/issues/457"},"comments":{"href":"https://api.github.com/repos/ipab-slmc/exotica/issues/457/comments"},"review_comments":{"href":"https://api.github.com/repos/ipab-slmc/exotica/pulls/457/comments"},"review_comment":{"href":"https://api.github.com/repos/ipab-slmc/exotica/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ipab-slmc/exotica/pulls/457/commits"},"statuses":{"href":"https://api.github.com/repos/ipab-slmc/exotica/statuses/a30e89f42f8cd7d56e63f683d2aebc5b5f94f027"}},"author_association":"MEMBER"}} | {
"id": 44607894,
"name": "ipab-slmc/exotica",
"url": "https://api.github.com/repos/ipab-slmc/exotica"
} | {
"id": 4905049,
"login": "VladimirIvan",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4905049?",
"url": "https://api.github.com/users/VladimirIvan"
} | {
"id": 10714328,
"login": "ipab-slmc",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/10714328?",
"url": "https://api.github.com/orgs/ipab-slmc"
} | 2018-12-18T18:07:41 | 8773890702 | {"actor":{"display_login":"VladimirIvan"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/Consdata/sonarqube-companion/pulls/comments/188096615","pull_request_review_id":120007855,"id":188096615,"diff_hunk":"@@ -0,0 +1,123 @@\n+import {Component} from \"@angular/core\";\n+import {Widget} from \"../widget-service\";\n+import {RankingEntry, RankingModel} from \"./ranking-model\";\n+import {UserStatisticsService} from \"../../statistics/user-statistics-service\";\n+import {Observable} from \"rxjs/Observable\";\n+import {isNullOrUndefined} from \"util\";\n+\n+\n+@Component({\n+ selector: 'ranking-widget',\n+ template: `\n+ <h2>{{title}}</h2>\n+ <div class=\"ranking-widget\">\n+ <div class=\"sk-rotating-plane\" *ngIf=\"!entries\"></div>\n+ <div class=\"ranking-wrapper\" *ngIf=\"!!entries\">\n+ <div class=\"ranking-header\">\n+ <div class=\"ranking-header-element name\">\n+ <div>Name</div>\n+ </div>\n+ <div *ngFor=\"let header of model.severity\" class=\"ranking-header-element counter\">\n+ <div>{{header}}</div>\n+ </div>\n+ </div>\n+ <div class=\"ranking-body\"></div>\n+ <div *ngFor=\"let entry of entries; let i=index\"\n+ class=\"ranking-row\"\n+ [class.blocker]=\"entry.blockers > 0\"\n+ [class.critical]=\"entry.criticals > 0\"\n+ [class.major]=\"entry.majors > 0\"\n+ [class.minor]=\"entry.minors > 0\"\n+ [class.info]=\"entry.infos > 0\"\n+ >\n+ <a target=\"_blank\" href=\"{{getSonarLink(entry.name)}}\" *ngIf=\"!model.limit || i<model.limit\">\n+ <div class=\"ranking-row-element name\">\n+ <div>{{entry.name}}</div>\n+ </div>\n+ <div *ngFor=\"let header of model.severity\" class=\"ranking-header-element counter\">\n+ <div>{{entry[header]}}</div>\n+ </div>\n+ </a>\n+ </div>\n+ </div>\n+ </div>\n+ `,\n+})\n+export class RankingWidgetComponent extends Widget<RankingModel> {\n+\n+ entries: RankingEntry[];\n+ title: string;\n+ compareEntries = function (a, b) {\n+ let result = 0;\n+ this.model.sort.forEach((value, index, array) => {\n+ const asc = value.startsWith(\"+\") ? -1 : 1;\n+ const key = value.slice(1);\n+ if (result == 0) {\n+ if (a[key] > b[key]) {\n+ result = -1 * asc;\n+ } else if (a[key] < b[key]) {\n+ result = 1 * asc;\n+ }\n+ }\n+ });\n+ return result;\n+ };\n+\n+ constructor(private userStatistics: UserStatisticsService) {\n+ super();\n+ }\n+\n+ getStats(from: string, to: string): Observable<any[]> {\n+ return this.userStatistics.getUserStatistics(this.uuid, from, to);\n+ }\n+\n+ getSonarLink(name: string): string {\n+ if (!isNullOrUndefined(this.model.server)) {\n+ return this.model.server +\n+ '/issues?authors=' + name +\n+ '&createdAfter=' + this.model.from +\n+ '&createdBefore=' + this.model.to +\n+ '&statuses=OPEN';","path":"sonarqube-companion-frontend/src/app/widget/ranking/ranking-widget-component.ts","position":80,"original_position":80,"commit_id":"16f71a096bdac5131518cb0b6bb2e5f7e5c1e0d0","original_commit_id":"16f71a096bdac5131518cb0b6bb2e5f7e5c1e0d0","user":{"login":"codacy-bot","id":19940114,"avatar_url":"https://avatars1.githubusercontent.com/u/19940114?v=4","gravatar_id":"","url":"https://api.github.com/users/codacy-bot","html_url":"https://github.com/codacy-bot","followers_url":"https://api.github.com/users/codacy-bot/followers","following_url":"https://api.github.com/users/codacy-bot/following{/other_user}","gists_url":"https://api.github.com/users/codacy-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/codacy-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codacy-bot/subscriptions","organizations_url":"https://api.github.com/users/codacy-bot/orgs","repos_url":"https://api.github.com/users/codacy-bot/repos","events_url":"https://api.github.com/users/codacy-bot/events{/privacy}","received_events_url":"https://api.github.com/users/codacy-bot/received_events","type":"User","site_admin":false},"body":" Issue found: [' should be \"](https://app.codacy.com/app/glipecki/sonarqube-companion/pullRequest?prid=1610947)","created_at":"2018-05-14T21:00:24Z","updated_at":"2018-05-14T21:00:24Z","html_url":"https://github.com/Consdata/sonarqube-companion/pull/60#discussion_r188096615","pull_request_url":"https://api.github.com/repos/Consdata/sonarqube-companion/pulls/60","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/Consdata/sonarqube-companion/pulls/comments/188096615"},"html":{"href":"https://github.com/Consdata/sonarqube-companion/pull/60#discussion_r188096615"},"pull_request":{"href":"https://api.github.com/repos/Consdata/sonarqube-companion/pulls/60"}}},"pull_request":{"url":"https://api.github.com/repos/Consdata/sonarqube-companion/pulls/60","id":185839154,"html_url":"https://github.com/Consdata/sonarqube-companion/pull/60","diff_url":"https://github.com/Consdata/sonarqube-companion/pull/60.diff","patch_url":"https://github.com/Consdata/sonarqube-companion/pull/60.patch","issue_url":"https://api.github.com/repos/Consdata/sonarqube-companion/issues/60","number":60,"state":"open","locked":false,"title":"Ranking","user":{"login":"m87","id":2799669,"avatar_url":"https://avatars1.githubusercontent.com/u/2799669?v=4","gravatar_id":"","url":"https://api.github.com/users/m87","html_url":"https://github.com/m87","followers_url":"https://api.github.com/users/m87/followers","following_url":"https://api.github.com/users/m87/following{/other_user}","gists_url":"https://api.github.com/users/m87/gists{/gist_id}","starred_url":"https://api.github.com/users/m87/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m87/subscriptions","organizations_url":"https://api.github.com/users/m87/orgs","repos_url":"https://api.github.com/users/m87/repos","events_url":"https://api.github.com/users/m87/events{/privacy}","received_events_url":"https://api.github.com/users/m87/received_events","type":"User","site_admin":false},"body":"## Wersja krótka:\r\nDodanie możliwości definiowania rankingu nierozwiązanych naruszeń per user\r\n\r\n## Wersja dłuższa:\r\n* Dodanie serwisu do zbierania statystyk dla danej grupy\r\n * obecnie zdefiniować można statystyki użytkowników:\r\n * Liczbę otwartych naruszeń od danej daty (planuje rozbudować o diffa dodanych/usuniętych oraz statystyki samych usuniętych\r\n* Dodanie funkcjonalność widgetów:\r\n * Na zaś - w kontekście zmiany settingsów z poziomu companiona oraz jedno miejsce gdzie można definiować funkcjonalność dodatkowe np. ranking\r\n * chciałem też pobawić się z dynamicznym tworzeniem componentów - wzorowałem się na ex oraz artykule na blogu - powinno być oki\r\n* Service do pobierania listy aktywnych użytkowników\r\n* Service synchronizacji statystyk\r\n* Cache na userów\r\n* Cache na liczbę naruszeń per user + tabela\r\n* Widget rankingu:\r\n * można zdefiniować tytuł z rozwiązywaniem zmiennych na podstawie modelu widgetu\r\n * można ograniczyć liczbę wyświetlanych pozycji w rankingu\r\n * można zdefiniować kolejność sortowania w rankingu stosują określoną notację\r\n * można zdefiniować listę include i exclude użytkowników, których brać pod uwagę w rankingu\r\n * można zdefiniować datę, od której ranking ma brać po uwagę naruszenia\r\n * ranking jest sprzężony z zakresem wykresu grupy\r\n * jeśli data, od której ranking ma brać po uwagę naruszenia, nie jest zdefiniowana to dolną granicą jest dolna granica suwaka, górna granica jest suwaka jest zawsze brana pod uwagę\r\n * można zdefiniować severity, które wyświetlać w rankingu\r\n * po kilknięciu w wierszy otwiera się sonarqube z filtrami adekwatnymi to zdefiniowanych ustawień/zakresu/użytkownika\r\n * aktualnie nie filtruje per projekt z grupy - z uwagi na to, że w przypadku podglądu w sonarqube trzeba stosować uuid projektu - aktualnie companion nie ma wiedzy o uuid projektów - trzeba dorobić\r\n * oczywiście w oczekiwaniu na dane każdy widget prezentuje kręciął companiona ;)\r\n\r\nDalej planuję:\r\n* rozszerzyć serwis statystyk o naruszenia naprawione - żeby było widać kto najwięcej poprawia\r\n* dodać webhooki do raportowania per użytkownik stanu sonara tzn. będzie można zdefiniować webhooka, który raz w tygodniu wyśle maila/wiadomość na slacku do konkretnego użytkownika z raportem ile wprowadził i ile zdjął naruszeń, Jeśli się da to też będzie callback który z automatu doda raport dla zespołu do retromurku na padlecie \r\n* wykres per użytkownik taki jak dla grupy(po kliknięciu w wiersz)\r\n\r\nDokumentacje do statystyk i rankingu dodam na wiki w najbliższym czasie (będzie tam info m. in. o kolejności includa i excluda oraz o notacji sortowania( w skrócie -blockers sortuje malejąco, jak damy listę to sortuje zgodnie z kolejnością na liście) \r\n\r\n\r\n\r\n\r\n","created_at":"2018-05-03T21:11:09Z","updated_at":"2018-05-14T21:00:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"958879c646323a89393668290df551e4411fb172","assignee":null,"assignees":[],"requested_reviewers":[{"login":"glipecki","id":2287729,"avatar_url":"https://avatars2.githubusercontent.com/u/2287729?v=4","gravatar_id":"","url":"https://api.github.com/users/glipecki","html_url":"https://github.com/glipecki","followers_url":"https://api.github.com/users/glipecki/followers","following_url":"https://api.github.com/users/glipecki/following{/other_user}","gists_url":"https://api.github.com/users/glipecki/gists{/gist_id}","starred_url":"https://api.github.com/users/glipecki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glipecki/subscriptions","organizations_url":"https://api.github.com/users/glipecki/orgs","repos_url":"https://api.github.com/users/glipecki/repos","events_url":"https://api.github.com/users/glipecki/events{/privacy}","received_events_url":"https://api.github.com/users/glipecki/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Consdata/sonarqube-companion/pulls/60/commits","review_comments_url":"https://api.github.com/repos/Consdata/sonarqube-companion/pulls/60/comments","review_comment_url":"https://api.github.com/repos/Consdata/sonarqube-companion/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Consdata/sonarqube-companion/issues/60/comments","statuses_url":"https://api.github.com/repos/Consdata/sonarqube-companion/statuses/16f71a096bdac5131518cb0b6bb2e5f7e5c1e0d0","head":{"label":"Consdata:ranking","ref":"ranking","sha":"16f71a096bdac5131518cb0b6bb2e5f7e5c1e0d0","user":{"login":"Consdata","id":10759137,"avatar_url":"https://avatars0.githubusercontent.com/u/10759137?v=4","gravatar_id":"","url":"https://api.github.com/users/Consdata","html_url":"https://github.com/Consdata","followers_url":"https://api.github.com/users/Consdata/followers","following_url":"https://api.github.com/users/Consdata/following{/other_user}","gists_url":"https://api.github.com/users/Consdata/gists{/gist_id}","starred_url":"https://api.github.com/users/Consdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Consdata/subscriptions","organizations_url":"https://api.github.com/users/Consdata/orgs","repos_url":"https://api.github.com/users/Consdata/repos","events_url":"https://api.github.com/users/Consdata/events{/privacy}","received_events_url":"https://api.github.com/users/Consdata/received_events","type":"Organization","site_admin":false},"repo":{"id":41053417,"name":"sonarqube-companion","full_name":"Consdata/sonarqube-companion","owner":{"login":"Consdata","id":10759137,"avatar_url":"https://avatars0.githubusercontent.com/u/10759137?v=4","gravatar_id":"","url":"https://api.github.com/users/Consdata","html_url":"https://github.com/Consdata","followers_url":"https://api.github.com/users/Consdata/followers","following_url":"https://api.github.com/users/Consdata/following{/other_user}","gists_url":"https://api.github.com/users/Consdata/gists{/gist_id}","starred_url":"https://api.github.com/users/Consdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Consdata/subscriptions","organizations_url":"https://api.github.com/users/Consdata/orgs","repos_url":"https://api.github.com/users/Consdata/repos","events_url":"https://api.github.com/users/Consdata/events{/privacy}","received_events_url":"https://api.github.com/users/Consdata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Consdata/sonarqube-companion","description":"SonarQube Companion","fork":false,"url":"https://api.github.com/repos/Consdata/sonarqube-companion","forks_url":"https://api.github.com/repos/Consdata/sonarqube-companion/forks","keys_url":"https://api.github.com/repos/Consdata/sonarqube-companion/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Consdata/sonarqube-companion/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Consdata/sonarqube-companion/teams","hooks_url":"https://api.github.com/repos/Consdata/sonarqube-companion/hooks","issue_events_url":"https://api.github.com/repos/Consdata/sonarqube-companion/issues/events{/number}","events_url":"https://api.github.com/repos/Consdata/sonarqube-companion/events","assignees_url":"https://api.github.com/repos/Consdata/sonarqube-companion/assignees{/user}","branches_url":"https://api.github.com/repos/Consdata/sonarqube-companion/branches{/branch}","tags_url":"https://api.github.com/repos/Consdata/sonarqube-companion/tags","blobs_url":"https://api.github.com/repos/Consdata/sonarqube-companion/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Consdata/sonarqube-companion/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Consdata/sonarqube-companion/git/refs{/sha}","trees_url":"https://api.github.com/repos/Consdata/sonarqube-companion/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Consdata/sonarqube-companion/statuses/{sha}","languages_url":"https://api.github.com/repos/Consdata/sonarqube-companion/languages","stargazers_url":"https://api.github.com/repos/Consdata/sonarqube-companion/stargazers","contributors_url":"https://api.github.com/repos/Consdata/sonarqube-companion/contributors","subscribers_url":"https://api.github.com/repos/Consdata/sonarqube-companion/subscribers","subscription_url":"https://api.github.com/repos/Consdata/sonarqube-companion/subscription","commits_url":"https://api.github.com/repos/Consdata/sonarqube-companion/commits{/sha}","git_commits_url":"https://api.github.com/repos/Consdata/sonarqube-companion/git/commits{/sha}","comments_url":"https://api.github.com/repos/Consdata/sonarqube-companion/comments{/number}","issue_comment_url":"https://api.github.com/repos/Consdata/sonarqube-companion/issues/comments{/number}","contents_url":"https://api.github.com/repos/Consdata/sonarqube-companion/contents/{+path}","compare_url":"https://api.github.com/repos/Consdata/sonarqube-companion/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Consdata/sonarqube-companion/merges","archive_url":"https://api.github.com/repos/Consdata/sonarqube-companion/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Consdata/sonarqube-companion/downloads","issues_url":"https://api.github.com/repos/Consdata/sonarqube-companion/issues{/number}","pulls_url":"https://api.github.com/repos/Consdata/sonarqube-companion/pulls{/number}","milestones_url":"https://api.github.com/repos/Consdata/sonarqube-companion/milestones{/number}","notifications_url":"https://api.github.com/repos/Consdata/sonarqube-companion/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Consdata/sonarqube-companion/labels{/name}","releases_url":"https://api.github.com/repos/Consdata/sonarqube-companion/releases{/id}","deployments_url":"https://api.github.com/repos/Consdata/sonarqube-companion/deployments","created_at":"2015-08-19T18:47:56Z","updated_at":"2018-03-09T09:53:23Z","pushed_at":"2018-05-14T20:58:20Z","git_url":"git://github.com/Consdata/sonarqube-companion.git","ssh_url":"[email protected]:Consdata/sonarqube-companion.git","clone_url":"https://github.com/Consdata/sonarqube-companion.git","svn_url":"https://github.com/Consdata/sonarqube-companion","homepage":"","size":3891,"stargazers_count":6,"watchers_count":6,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":1,"open_issues":10,"watchers":6,"default_branch":"master"}},"base":{"label":"Consdata:master","ref":"master","sha":"fa41e8f0625aea48d70daf471bb017958d0c04bc","user":{"login":"Consdata","id":10759137,"avatar_url":"https://avatars0.githubusercontent.com/u/10759137?v=4","gravatar_id":"","url":"https://api.github.com/users/Consdata","html_url":"https://github.com/Consdata","followers_url":"https://api.github.com/users/Consdata/followers","following_url":"https://api.github.com/users/Consdata/following{/other_user}","gists_url":"https://api.github.com/users/Consdata/gists{/gist_id}","starred_url":"https://api.github.com/users/Consdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Consdata/subscriptions","organizations_url":"https://api.github.com/users/Consdata/orgs","repos_url":"https://api.github.com/users/Consdata/repos","events_url":"https://api.github.com/users/Consdata/events{/privacy}","received_events_url":"https://api.github.com/users/Consdata/received_events","type":"Organization","site_admin":false},"repo":{"id":41053417,"name":"sonarqube-companion","full_name":"Consdata/sonarqube-companion","owner":{"login":"Consdata","id":10759137,"avatar_url":"https://avatars0.githubusercontent.com/u/10759137?v=4","gravatar_id":"","url":"https://api.github.com/users/Consdata","html_url":"https://github.com/Consdata","followers_url":"https://api.github.com/users/Consdata/followers","following_url":"https://api.github.com/users/Consdata/following{/other_user}","gists_url":"https://api.github.com/users/Consdata/gists{/gist_id}","starred_url":"https://api.github.com/users/Consdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Consdata/subscriptions","organizations_url":"https://api.github.com/users/Consdata/orgs","repos_url":"https://api.github.com/users/Consdata/repos","events_url":"https://api.github.com/users/Consdata/events{/privacy}","received_events_url":"https://api.github.com/users/Consdata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Consdata/sonarqube-companion","description":"SonarQube Companion","fork":false,"url":"https://api.github.com/repos/Consdata/sonarqube-companion","forks_url":"https://api.github.com/repos/Consdata/sonarqube-companion/forks","keys_url":"https://api.github.com/repos/Consdata/sonarqube-companion/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Consdata/sonarqube-companion/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Consdata/sonarqube-companion/teams","hooks_url":"https://api.github.com/repos/Consdata/sonarqube-companion/hooks","issue_events_url":"https://api.github.com/repos/Consdata/sonarqube-companion/issues/events{/number}","events_url":"https://api.github.com/repos/Consdata/sonarqube-companion/events","assignees_url":"https://api.github.com/repos/Consdata/sonarqube-companion/assignees{/user}","branches_url":"https://api.github.com/repos/Consdata/sonarqube-companion/branches{/branch}","tags_url":"https://api.github.com/repos/Consdata/sonarqube-companion/tags","blobs_url":"https://api.github.com/repos/Consdata/sonarqube-companion/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Consdata/sonarqube-companion/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Consdata/sonarqube-companion/git/refs{/sha}","trees_url":"https://api.github.com/repos/Consdata/sonarqube-companion/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Consdata/sonarqube-companion/statuses/{sha}","languages_url":"https://api.github.com/repos/Consdata/sonarqube-companion/languages","stargazers_url":"https://api.github.com/repos/Consdata/sonarqube-companion/stargazers","contributors_url":"https://api.github.com/repos/Consdata/sonarqube-companion/contributors","subscribers_url":"https://api.github.com/repos/Consdata/sonarqube-companion/subscribers","subscription_url":"https://api.github.com/repos/Consdata/sonarqube-companion/subscription","commits_url":"https://api.github.com/repos/Consdata/sonarqube-companion/commits{/sha}","git_commits_url":"https://api.github.com/repos/Consdata/sonarqube-companion/git/commits{/sha}","comments_url":"https://api.github.com/repos/Consdata/sonarqube-companion/comments{/number}","issue_comment_url":"https://api.github.com/repos/Consdata/sonarqube-companion/issues/comments{/number}","contents_url":"https://api.github.com/repos/Consdata/sonarqube-companion/contents/{+path}","compare_url":"https://api.github.com/repos/Consdata/sonarqube-companion/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Consdata/sonarqube-companion/merges","archive_url":"https://api.github.com/repos/Consdata/sonarqube-companion/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Consdata/sonarqube-companion/downloads","issues_url":"https://api.github.com/repos/Consdata/sonarqube-companion/issues{/number}","pulls_url":"https://api.github.com/repos/Consdata/sonarqube-companion/pulls{/number}","milestones_url":"https://api.github.com/repos/Consdata/sonarqube-companion/milestones{/number}","notifications_url":"https://api.github.com/repos/Consdata/sonarqube-companion/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Consdata/sonarqube-companion/labels{/name}","releases_url":"https://api.github.com/repos/Consdata/sonarqube-companion/releases{/id}","deployments_url":"https://api.github.com/repos/Consdata/sonarqube-companion/deployments","created_at":"2015-08-19T18:47:56Z","updated_at":"2018-03-09T09:53:23Z","pushed_at":"2018-05-14T20:58:20Z","git_url":"git://github.com/Consdata/sonarqube-companion.git","ssh_url":"[email protected]:Consdata/sonarqube-companion.git","clone_url":"https://github.com/Consdata/sonarqube-companion.git","svn_url":"https://github.com/Consdata/sonarqube-companion","homepage":"","size":3891,"stargazers_count":6,"watchers_count":6,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":1,"open_issues":10,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Consdata/sonarqube-companion/pulls/60"},"html":{"href":"https://github.com/Consdata/sonarqube-companion/pull/60"},"issue":{"href":"https://api.github.com/repos/Consdata/sonarqube-companion/issues/60"},"comments":{"href":"https://api.github.com/repos/Consdata/sonarqube-companion/issues/60/comments"},"review_comments":{"href":"https://api.github.com/repos/Consdata/sonarqube-companion/pulls/60/comments"},"review_comment":{"href":"https://api.github.com/repos/Consdata/sonarqube-companion/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Consdata/sonarqube-companion/pulls/60/commits"},"statuses":{"href":"https://api.github.com/repos/Consdata/sonarqube-companion/statuses/16f71a096bdac5131518cb0b6bb2e5f7e5c1e0d0"}},"author_association":"CONTRIBUTOR"}} | {
"id": 41053417,
"name": "Consdata/sonarqube-companion",
"url": "https://api.github.com/repos/Consdata/sonarqube-companion"
} | {
"id": 19940114,
"login": "codacy-bot",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/19940114?",
"url": "https://api.github.com/users/codacy-bot"
} | {
"id": 10759137,
"login": "Consdata",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/10759137?",
"url": "https://api.github.com/orgs/Consdata"
} | 2018-05-14T21:00:24 | 7673118491 | {"actor":{"display_login":"codacy-bot"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/riscv/riscv-debug-spec/pulls/comments/184820649","pull_request_review_id":116100006,"id":184820649,"diff_hunk":"@@ -289,4 +292,85 @@\n Other values are reserved for future use.\n </field>\n </register>\n+\n+ <register name=\"Exception Trigger\" short=\"etrigger\" address=\"0x7a1\">\n+ This register is accessible as \\Rtdataone when \\Ftype is 4.\n+\n+ If implemented, it allows triggering on a variety of interrupt and\n+ exception sources. If such a trigger is taken, all the usual CSRs as\n+ well as \\Rpc are updated, and the requested action is taken just before\n+ the first instruction of the interrupt/exception handler is executed.\n+\n+ <field name=\"type\" bits=\"XLEN-1:XLEN-4\" access=\"R\" reset=\"2\" />\n+ <field name=\"dmode\" bits=\"XLEN-5\" access=\"R/W\" reset=\"0\" />\n+ <field name=\"0\" bits=\"XLEN-6:24\" access=\"R\" reset=\"0\" />\n+ <field name=\"source\" bits=\"23:10\" access=\"R/W\" reset=\"0\">\n+ For each bit that is set, the corresponding interrupt/exception\n+ will cause this trigger to fire if bit corresponding to the current\n+ mode is also set.\n+\n+ 0: Software interrupt","path":"xml/hwbp_registers.xml","position":31,"original_position":31,"commit_id":"c1818125abbf26a5119d9203dda639fdf2cb700b","original_commit_id":"c1818125abbf26a5119d9203dda639fdf2cb700b","user":{"login":"mwachs5","id":17858596,"avatar_url":"https://avatars1.githubusercontent.com/u/17858596?v=4","gravatar_id":"","url":"https://api.github.com/users/mwachs5","html_url":"https://github.com/mwachs5","followers_url":"https://api.github.com/users/mwachs5/followers","following_url":"https://api.github.com/users/mwachs5/following{/other_user}","gists_url":"https://api.github.com/users/mwachs5/gists{/gist_id}","starred_url":"https://api.github.com/users/mwachs5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mwachs5/subscriptions","organizations_url":"https://api.github.com/users/mwachs5/orgs","repos_url":"https://api.github.com/users/mwachs5/repos","events_url":"https://api.github.com/users/mwachs5/events{/privacy}","received_events_url":"https://api.github.com/users/mwachs5/received_events","type":"User","site_admin":false},"body":"I think the \"mode\" in *cause are misleading, as noted by frequent questions about it on the mailing list. For example \"Supervisor software interrupt\" vs \"Machine software interrupt\" are sort of conventional naming that allow SW to route and delegate things a certain way, not something that the hardware really knows the difference between (it just knows they are different).","created_at":"2018-04-27T22:29:37Z","updated_at":"2018-04-27T22:29:37Z","html_url":"https://github.com/riscv/riscv-debug-spec/pull/266#discussion_r184820649","pull_request_url":"https://api.github.com/repos/riscv/riscv-debug-spec/pulls/266","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/riscv/riscv-debug-spec/pulls/comments/184820649"},"html":{"href":"https://github.com/riscv/riscv-debug-spec/pull/266#discussion_r184820649"},"pull_request":{"href":"https://api.github.com/repos/riscv/riscv-debug-spec/pulls/266"}},"in_reply_to_id":184807114},"pull_request":{"url":"https://api.github.com/repos/riscv/riscv-debug-spec/pulls/266","id":184727171,"html_url":"https://github.com/riscv/riscv-debug-spec/pull/266","diff_url":"https://github.com/riscv/riscv-debug-spec/pull/266.diff","patch_url":"https://github.com/riscv/riscv-debug-spec/pull/266.patch","issue_url":"https://api.github.com/repos/riscv/riscv-debug-spec/issues/266","number":266,"state":"open","locked":false,"title":"Specify an Exception Trigger","user":{"login":"timsifive","id":16123885,"avatar_url":"https://avatars1.githubusercontent.com/u/16123885?v=4","gravatar_id":"","url":"https://api.github.com/users/timsifive","html_url":"https://github.com/timsifive","followers_url":"https://api.github.com/users/timsifive/followers","following_url":"https://api.github.com/users/timsifive/following{/other_user}","gists_url":"https://api.github.com/users/timsifive/gists{/gist_id}","starred_url":"https://api.github.com/users/timsifive/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timsifive/subscriptions","organizations_url":"https://api.github.com/users/timsifive/orgs","repos_url":"https://api.github.com/users/timsifive/repos","events_url":"https://api.github.com/users/timsifive/events{/privacy}","received_events_url":"https://api.github.com/users/timsifive/received_events","type":"User","site_admin":false},"body":"I tried to get all the sources from the Syntacore proposal in, but did\r\nnot add the various timing options. We do get interrupt sources now as\r\nwell as the exception sources.","created_at":"2018-04-27T21:02:24Z","updated_at":"2018-04-27T22:29:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"513986334056056cd64f7a8d4aefb43eb3099b25","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/riscv/riscv-debug-spec/pulls/266/commits","review_comments_url":"https://api.github.com/repos/riscv/riscv-debug-spec/pulls/266/comments","review_comment_url":"https://api.github.com/repos/riscv/riscv-debug-spec/pulls/comments{/number}","comments_url":"https://api.github.com/repos/riscv/riscv-debug-spec/issues/266/comments","statuses_url":"https://api.github.com/repos/riscv/riscv-debug-spec/statuses/c1818125abbf26a5119d9203dda639fdf2cb700b","head":{"label":"riscv:redirect_trigger","ref":"redirect_trigger","sha":"c1818125abbf26a5119d9203dda639fdf2cb700b","user":{"login":"riscv","id":10872782,"avatar_url":"https://avatars0.githubusercontent.com/u/10872782?v=4","gravatar_id":"","url":"https://api.github.com/users/riscv","html_url":"https://github.com/riscv","followers_url":"https://api.github.com/users/riscv/followers","following_url":"https://api.github.com/users/riscv/following{/other_user}","gists_url":"https://api.github.com/users/riscv/gists{/gist_id}","starred_url":"https://api.github.com/users/riscv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/riscv/subscriptions","organizations_url":"https://api.github.com/users/riscv/orgs","repos_url":"https://api.github.com/users/riscv/repos","events_url":"https://api.github.com/users/riscv/events{/privacy}","received_events_url":"https://api.github.com/users/riscv/received_events","type":"Organization","site_admin":false},"repo":{"id":79597821,"name":"riscv-debug-spec","full_name":"riscv/riscv-debug-spec","owner":{"login":"riscv","id":10872782,"avatar_url":"https://avatars0.githubusercontent.com/u/10872782?v=4","gravatar_id":"","url":"https://api.github.com/users/riscv","html_url":"https://github.com/riscv","followers_url":"https://api.github.com/users/riscv/followers","following_url":"https://api.github.com/users/riscv/following{/other_user}","gists_url":"https://api.github.com/users/riscv/gists{/gist_id}","starred_url":"https://api.github.com/users/riscv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/riscv/subscriptions","organizations_url":"https://api.github.com/users/riscv/orgs","repos_url":"https://api.github.com/users/riscv/repos","events_url":"https://api.github.com/users/riscv/events{/privacy}","received_events_url":"https://api.github.com/users/riscv/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/riscv/riscv-debug-spec","description":"Working Draft of the RISC-V Debug Specification Standard","fork":false,"url":"https://api.github.com/repos/riscv/riscv-debug-spec","forks_url":"https://api.github.com/repos/riscv/riscv-debug-spec/forks","keys_url":"https://api.github.com/repos/riscv/riscv-debug-spec/keys{/key_id}","collaborators_url":"https://api.github.com/repos/riscv/riscv-debug-spec/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/riscv/riscv-debug-spec/teams","hooks_url":"https://api.github.com/repos/riscv/riscv-debug-spec/hooks","issue_events_url":"https://api.github.com/repos/riscv/riscv-debug-spec/issues/events{/number}","events_url":"https://api.github.com/repos/riscv/riscv-debug-spec/events","assignees_url":"https://api.github.com/repos/riscv/riscv-debug-spec/assignees{/user}","branches_url":"https://api.github.com/repos/riscv/riscv-debug-spec/branches{/branch}","tags_url":"https://api.github.com/repos/riscv/riscv-debug-spec/tags","blobs_url":"https://api.github.com/repos/riscv/riscv-debug-spec/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/riscv/riscv-debug-spec/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/riscv/riscv-debug-spec/git/refs{/sha}","trees_url":"https://api.github.com/repos/riscv/riscv-debug-spec/git/trees{/sha}","statuses_url":"https://api.github.com/repos/riscv/riscv-debug-spec/statuses/{sha}","languages_url":"https://api.github.com/repos/riscv/riscv-debug-spec/languages","stargazers_url":"https://api.github.com/repos/riscv/riscv-debug-spec/stargazers","contributors_url":"https://api.github.com/repos/riscv/riscv-debug-spec/contributors","subscribers_url":"https://api.github.com/repos/riscv/riscv-debug-spec/subscribers","subscription_url":"https://api.github.com/repos/riscv/riscv-debug-spec/subscription","commits_url":"https://api.github.com/repos/riscv/riscv-debug-spec/commits{/sha}","git_commits_url":"https://api.github.com/repos/riscv/riscv-debug-spec/git/commits{/sha}","comments_url":"https://api.github.com/repos/riscv/riscv-debug-spec/comments{/number}","issue_comment_url":"https://api.github.com/repos/riscv/riscv-debug-spec/issues/comments{/number}","contents_url":"https://api.github.com/repos/riscv/riscv-debug-spec/contents/{+path}","compare_url":"https://api.github.com/repos/riscv/riscv-debug-spec/compare/{base}...{head}","merges_url":"https://api.github.com/repos/riscv/riscv-debug-spec/merges","archive_url":"https://api.github.com/repos/riscv/riscv-debug-spec/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/riscv/riscv-debug-spec/downloads","issues_url":"https://api.github.com/repos/riscv/riscv-debug-spec/issues{/number}","pulls_url":"https://api.github.com/repos/riscv/riscv-debug-spec/pulls{/number}","milestones_url":"https://api.github.com/repos/riscv/riscv-debug-spec/milestones{/number}","notifications_url":"https://api.github.com/repos/riscv/riscv-debug-spec/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/riscv/riscv-debug-spec/labels{/name}","releases_url":"https://api.github.com/repos/riscv/riscv-debug-spec/releases{/id}","deployments_url":"https://api.github.com/repos/riscv/riscv-debug-spec/deployments","created_at":"2017-01-20T20:58:54Z","updated_at":"2018-04-25T15:34:18Z","pushed_at":"2018-04-27T22:10:26Z","git_url":"git://github.com/riscv/riscv-debug-spec.git","ssh_url":"[email protected]:riscv/riscv-debug-spec.git","clone_url":"https://github.com/riscv/riscv-debug-spec.git","svn_url":"https://github.com/riscv/riscv-debug-spec","homepage":null,"size":15210,"stargazers_count":29,"watchers_count":29,"language":"TeX","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":30,"license":{"key":"cc-by-4.0","name":"Creative Commons Attribution 4.0","spdx_id":"CC-BY-4.0","url":"https://api.github.com/licenses/cc-by-4.0"},"forks":10,"open_issues":30,"watchers":29,"default_branch":"master"}},"base":{"label":"riscv:master","ref":"master","sha":"a719ee6ef7535f9d5d0f843402e1cf43de155e5a","user":{"login":"riscv","id":10872782,"avatar_url":"https://avatars0.githubusercontent.com/u/10872782?v=4","gravatar_id":"","url":"https://api.github.com/users/riscv","html_url":"https://github.com/riscv","followers_url":"https://api.github.com/users/riscv/followers","following_url":"https://api.github.com/users/riscv/following{/other_user}","gists_url":"https://api.github.com/users/riscv/gists{/gist_id}","starred_url":"https://api.github.com/users/riscv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/riscv/subscriptions","organizations_url":"https://api.github.com/users/riscv/orgs","repos_url":"https://api.github.com/users/riscv/repos","events_url":"https://api.github.com/users/riscv/events{/privacy}","received_events_url":"https://api.github.com/users/riscv/received_events","type":"Organization","site_admin":false},"repo":{"id":79597821,"name":"riscv-debug-spec","full_name":"riscv/riscv-debug-spec","owner":{"login":"riscv","id":10872782,"avatar_url":"https://avatars0.githubusercontent.com/u/10872782?v=4","gravatar_id":"","url":"https://api.github.com/users/riscv","html_url":"https://github.com/riscv","followers_url":"https://api.github.com/users/riscv/followers","following_url":"https://api.github.com/users/riscv/following{/other_user}","gists_url":"https://api.github.com/users/riscv/gists{/gist_id}","starred_url":"https://api.github.com/users/riscv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/riscv/subscriptions","organizations_url":"https://api.github.com/users/riscv/orgs","repos_url":"https://api.github.com/users/riscv/repos","events_url":"https://api.github.com/users/riscv/events{/privacy}","received_events_url":"https://api.github.com/users/riscv/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/riscv/riscv-debug-spec","description":"Working Draft of the RISC-V Debug Specification Standard","fork":false,"url":"https://api.github.com/repos/riscv/riscv-debug-spec","forks_url":"https://api.github.com/repos/riscv/riscv-debug-spec/forks","keys_url":"https://api.github.com/repos/riscv/riscv-debug-spec/keys{/key_id}","collaborators_url":"https://api.github.com/repos/riscv/riscv-debug-spec/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/riscv/riscv-debug-spec/teams","hooks_url":"https://api.github.com/repos/riscv/riscv-debug-spec/hooks","issue_events_url":"https://api.github.com/repos/riscv/riscv-debug-spec/issues/events{/number}","events_url":"https://api.github.com/repos/riscv/riscv-debug-spec/events","assignees_url":"https://api.github.com/repos/riscv/riscv-debug-spec/assignees{/user}","branches_url":"https://api.github.com/repos/riscv/riscv-debug-spec/branches{/branch}","tags_url":"https://api.github.com/repos/riscv/riscv-debug-spec/tags","blobs_url":"https://api.github.com/repos/riscv/riscv-debug-spec/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/riscv/riscv-debug-spec/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/riscv/riscv-debug-spec/git/refs{/sha}","trees_url":"https://api.github.com/repos/riscv/riscv-debug-spec/git/trees{/sha}","statuses_url":"https://api.github.com/repos/riscv/riscv-debug-spec/statuses/{sha}","languages_url":"https://api.github.com/repos/riscv/riscv-debug-spec/languages","stargazers_url":"https://api.github.com/repos/riscv/riscv-debug-spec/stargazers","contributors_url":"https://api.github.com/repos/riscv/riscv-debug-spec/contributors","subscribers_url":"https://api.github.com/repos/riscv/riscv-debug-spec/subscribers","subscription_url":"https://api.github.com/repos/riscv/riscv-debug-spec/subscription","commits_url":"https://api.github.com/repos/riscv/riscv-debug-spec/commits{/sha}","git_commits_url":"https://api.github.com/repos/riscv/riscv-debug-spec/git/commits{/sha}","comments_url":"https://api.github.com/repos/riscv/riscv-debug-spec/comments{/number}","issue_comment_url":"https://api.github.com/repos/riscv/riscv-debug-spec/issues/comments{/number}","contents_url":"https://api.github.com/repos/riscv/riscv-debug-spec/contents/{+path}","compare_url":"https://api.github.com/repos/riscv/riscv-debug-spec/compare/{base}...{head}","merges_url":"https://api.github.com/repos/riscv/riscv-debug-spec/merges","archive_url":"https://api.github.com/repos/riscv/riscv-debug-spec/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/riscv/riscv-debug-spec/downloads","issues_url":"https://api.github.com/repos/riscv/riscv-debug-spec/issues{/number}","pulls_url":"https://api.github.com/repos/riscv/riscv-debug-spec/pulls{/number}","milestones_url":"https://api.github.com/repos/riscv/riscv-debug-spec/milestones{/number}","notifications_url":"https://api.github.com/repos/riscv/riscv-debug-spec/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/riscv/riscv-debug-spec/labels{/name}","releases_url":"https://api.github.com/repos/riscv/riscv-debug-spec/releases{/id}","deployments_url":"https://api.github.com/repos/riscv/riscv-debug-spec/deployments","created_at":"2017-01-20T20:58:54Z","updated_at":"2018-04-25T15:34:18Z","pushed_at":"2018-04-27T22:10:26Z","git_url":"git://github.com/riscv/riscv-debug-spec.git","ssh_url":"[email protected]:riscv/riscv-debug-spec.git","clone_url":"https://github.com/riscv/riscv-debug-spec.git","svn_url":"https://github.com/riscv/riscv-debug-spec","homepage":null,"size":15210,"stargazers_count":29,"watchers_count":29,"language":"TeX","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":30,"license":{"key":"cc-by-4.0","name":"Creative Commons Attribution 4.0","spdx_id":"CC-BY-4.0","url":"https://api.github.com/licenses/cc-by-4.0"},"forks":10,"open_issues":30,"watchers":29,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/riscv/riscv-debug-spec/pulls/266"},"html":{"href":"https://github.com/riscv/riscv-debug-spec/pull/266"},"issue":{"href":"https://api.github.com/repos/riscv/riscv-debug-spec/issues/266"},"comments":{"href":"https://api.github.com/repos/riscv/riscv-debug-spec/issues/266/comments"},"review_comments":{"href":"https://api.github.com/repos/riscv/riscv-debug-spec/pulls/266/comments"},"review_comment":{"href":"https://api.github.com/repos/riscv/riscv-debug-spec/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/riscv/riscv-debug-spec/pulls/266/commits"},"statuses":{"href":"https://api.github.com/repos/riscv/riscv-debug-spec/statuses/c1818125abbf26a5119d9203dda639fdf2cb700b"}},"author_association":"COLLABORATOR"}} | {
"id": 79597821,
"name": "riscv/riscv-debug-spec",
"url": "https://api.github.com/repos/riscv/riscv-debug-spec"
} | {
"id": 17858596,
"login": "mwachs5",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/17858596?",
"url": "https://api.github.com/users/mwachs5"
} | {
"id": 10872782,
"login": "riscv",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/10872782?",
"url": "https://api.github.com/orgs/riscv"
} | 2018-04-27T22:29:37 | 7600000203 | {"actor":{"display_login":"mwachs5"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/pulls/comments/187575417","pull_request_review_id":119384342,"id":187575417,"diff_hunk":"@@ -0,0 +1,23 @@\n+'use strict';\n+\n+(function ($) {\n+ var $dest = $('#core-standards-optout-script');\n+ // Restores the default opt-out script if textarea is empty.\n+ if (!$dest.val().trim().length) {\n+ load_default_script($dest);","path":"assets/scripts/admin-opt-out.js","position":7,"original_position":7,"commit_id":"7338b2d624a3aff194fcd67a3847d01d9b2382a6","original_commit_id":"fec68e4b9017ffeccef5cdbb3caa3e4c147c2613","user":{"login":"juanlopez4691","id":13467494,"avatar_url":"https://avatars0.githubusercontent.com/u/13467494?v=4","gravatar_id":"","url":"https://api.github.com/users/juanlopez4691","html_url":"https://github.com/juanlopez4691","followers_url":"https://api.github.com/users/juanlopez4691/followers","following_url":"https://api.github.com/users/juanlopez4691/following{/other_user}","gists_url":"https://api.github.com/users/juanlopez4691/gists{/gist_id}","starred_url":"https://api.github.com/users/juanlopez4691/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juanlopez4691/subscriptions","organizations_url":"https://api.github.com/users/juanlopez4691/orgs","repos_url":"https://api.github.com/users/juanlopez4691/repos","events_url":"https://api.github.com/users/juanlopez4691/events{/privacy}","received_events_url":"https://api.github.com/users/juanlopez4691/received_events","type":"User","site_admin":false},"body":"@sun Added a comment to the task recommending Peter about discarding this feature.","created_at":"2018-05-11T10:13:58Z","updated_at":"2018-05-11T10:13:58Z","html_url":"https://github.com/netzstrategen/wordpress-core-standards/pull/16#discussion_r187575417","pull_request_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/pulls/16","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/pulls/comments/187575417"},"html":{"href":"https://github.com/netzstrategen/wordpress-core-standards/pull/16#discussion_r187575417"},"pull_request":{"href":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/pulls/16"}},"in_reply_to_id":187293138},"pull_request":{"url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/pulls/16","id":187120087,"html_url":"https://github.com/netzstrategen/wordpress-core-standards/pull/16","diff_url":"https://github.com/netzstrategen/wordpress-core-standards/pull/16.diff","patch_url":"https://github.com/netzstrategen/wordpress-core-standards/pull/16.patch","issue_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/issues/16","number":16,"state":"open","locked":false,"title":"Added Google Analytics tracking opt-out backend settings and frontend…","user":{"login":"juanlopez4691","id":13467494,"avatar_url":"https://avatars0.githubusercontent.com/u/13467494?v=4","gravatar_id":"","url":"https://api.github.com/users/juanlopez4691","html_url":"https://github.com/juanlopez4691","followers_url":"https://api.github.com/users/juanlopez4691/followers","following_url":"https://api.github.com/users/juanlopez4691/following{/other_user}","gists_url":"https://api.github.com/users/juanlopez4691/gists{/gist_id}","starred_url":"https://api.github.com/users/juanlopez4691/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juanlopez4691/subscriptions","organizations_url":"https://api.github.com/users/juanlopez4691/orgs","repos_url":"https://api.github.com/users/juanlopez4691/repos","events_url":"https://api.github.com/users/juanlopez4691/events{/privacy}","received_events_url":"https://api.github.com/users/juanlopez4691/received_events","type":"User","site_admin":false},"body":"… script injection.\r\n\r\nRelated to task [Core standards: Add Tracking opt-out for Google Analytics](https://app.asana.com/0/inbox/383242129844222/607229343598199/607239277828768).\r\n\r\n- Added opt-out script backend admin menu entry and settings page.\r\n- Added frontend opt-out script injection.\r\n\r\nEstimated: 8h\r\nTime left: 3h","created_at":"2018-05-10T07:22:45Z","updated_at":"2018-05-11T10:13:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7f283defc91d9493296ac29bc79a5fdbd37dd603","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/pulls/16/commits","review_comments_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/pulls/16/comments","review_comment_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/pulls/comments{/number}","comments_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/issues/16/comments","statuses_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/statuses/7338b2d624a3aff194fcd67a3847d01d9b2382a6","head":{"label":"netzstrategen:feature/tracking-opt-out-607239277828768-joan","ref":"feature/tracking-opt-out-607239277828768-joan","sha":"7338b2d624a3aff194fcd67a3847d01d9b2382a6","user":{"login":"netzstrategen","id":10957709,"avatar_url":"https://avatars0.githubusercontent.com/u/10957709?v=4","gravatar_id":"","url":"https://api.github.com/users/netzstrategen","html_url":"https://github.com/netzstrategen","followers_url":"https://api.github.com/users/netzstrategen/followers","following_url":"https://api.github.com/users/netzstrategen/following{/other_user}","gists_url":"https://api.github.com/users/netzstrategen/gists{/gist_id}","starred_url":"https://api.github.com/users/netzstrategen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/netzstrategen/subscriptions","organizations_url":"https://api.github.com/users/netzstrategen/orgs","repos_url":"https://api.github.com/users/netzstrategen/repos","events_url":"https://api.github.com/users/netzstrategen/events{/privacy}","received_events_url":"https://api.github.com/users/netzstrategen/received_events","type":"Organization","site_admin":false},"repo":{"id":52965413,"name":"wordpress-core-standards","full_name":"netzstrategen/wordpress-core-standards","owner":{"login":"netzstrategen","id":10957709,"avatar_url":"https://avatars0.githubusercontent.com/u/10957709?v=4","gravatar_id":"","url":"https://api.github.com/users/netzstrategen","html_url":"https://github.com/netzstrategen","followers_url":"https://api.github.com/users/netzstrategen/followers","following_url":"https://api.github.com/users/netzstrategen/following{/other_user}","gists_url":"https://api.github.com/users/netzstrategen/gists{/gist_id}","starred_url":"https://api.github.com/users/netzstrategen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/netzstrategen/subscriptions","organizations_url":"https://api.github.com/users/netzstrategen/orgs","repos_url":"https://api.github.com/users/netzstrategen/repos","events_url":"https://api.github.com/users/netzstrategen/events{/privacy}","received_events_url":"https://api.github.com/users/netzstrategen/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/netzstrategen/wordpress-core-standards","description":"Common enhancements for WordPress Core.","fork":false,"url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards","forks_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/forks","keys_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/keys{/key_id}","collaborators_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/teams","hooks_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/hooks","issue_events_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/issues/events{/number}","events_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/events","assignees_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/assignees{/user}","branches_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/branches{/branch}","tags_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/tags","blobs_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/git/refs{/sha}","trees_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/git/trees{/sha}","statuses_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/statuses/{sha}","languages_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/languages","stargazers_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/stargazers","contributors_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/contributors","subscribers_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/subscribers","subscription_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/subscription","commits_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/commits{/sha}","git_commits_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/git/commits{/sha}","comments_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/comments{/number}","issue_comment_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/issues/comments{/number}","contents_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/contents/{+path}","compare_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/compare/{base}...{head}","merges_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/merges","archive_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/downloads","issues_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/issues{/number}","pulls_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/pulls{/number}","milestones_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/milestones{/number}","notifications_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/labels{/name}","releases_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/releases{/id}","deployments_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/deployments","created_at":"2016-03-02T13:37:49Z","updated_at":"2018-05-05T20:50:08Z","pushed_at":"2018-05-11T09:16:50Z","git_url":"git://github.com/netzstrategen/wordpress-core-standards.git","ssh_url":"[email protected]:netzstrategen/wordpress-core-standards.git","clone_url":"https://github.com/netzstrategen/wordpress-core-standards.git","svn_url":"https://github.com/netzstrategen/wordpress-core-standards","homepage":null,"size":84,"stargazers_count":2,"watchers_count":2,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":3,"license":null,"forks":1,"open_issues":3,"watchers":2,"default_branch":"master"}},"base":{"label":"netzstrategen:master","ref":"master","sha":"f03d800110589d3d842ffaab312eb72ecf5f341c","user":{"login":"netzstrategen","id":10957709,"avatar_url":"https://avatars0.githubusercontent.com/u/10957709?v=4","gravatar_id":"","url":"https://api.github.com/users/netzstrategen","html_url":"https://github.com/netzstrategen","followers_url":"https://api.github.com/users/netzstrategen/followers","following_url":"https://api.github.com/users/netzstrategen/following{/other_user}","gists_url":"https://api.github.com/users/netzstrategen/gists{/gist_id}","starred_url":"https://api.github.com/users/netzstrategen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/netzstrategen/subscriptions","organizations_url":"https://api.github.com/users/netzstrategen/orgs","repos_url":"https://api.github.com/users/netzstrategen/repos","events_url":"https://api.github.com/users/netzstrategen/events{/privacy}","received_events_url":"https://api.github.com/users/netzstrategen/received_events","type":"Organization","site_admin":false},"repo":{"id":52965413,"name":"wordpress-core-standards","full_name":"netzstrategen/wordpress-core-standards","owner":{"login":"netzstrategen","id":10957709,"avatar_url":"https://avatars0.githubusercontent.com/u/10957709?v=4","gravatar_id":"","url":"https://api.github.com/users/netzstrategen","html_url":"https://github.com/netzstrategen","followers_url":"https://api.github.com/users/netzstrategen/followers","following_url":"https://api.github.com/users/netzstrategen/following{/other_user}","gists_url":"https://api.github.com/users/netzstrategen/gists{/gist_id}","starred_url":"https://api.github.com/users/netzstrategen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/netzstrategen/subscriptions","organizations_url":"https://api.github.com/users/netzstrategen/orgs","repos_url":"https://api.github.com/users/netzstrategen/repos","events_url":"https://api.github.com/users/netzstrategen/events{/privacy}","received_events_url":"https://api.github.com/users/netzstrategen/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/netzstrategen/wordpress-core-standards","description":"Common enhancements for WordPress Core.","fork":false,"url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards","forks_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/forks","keys_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/keys{/key_id}","collaborators_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/teams","hooks_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/hooks","issue_events_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/issues/events{/number}","events_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/events","assignees_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/assignees{/user}","branches_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/branches{/branch}","tags_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/tags","blobs_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/git/refs{/sha}","trees_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/git/trees{/sha}","statuses_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/statuses/{sha}","languages_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/languages","stargazers_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/stargazers","contributors_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/contributors","subscribers_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/subscribers","subscription_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/subscription","commits_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/commits{/sha}","git_commits_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/git/commits{/sha}","comments_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/comments{/number}","issue_comment_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/issues/comments{/number}","contents_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/contents/{+path}","compare_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/compare/{base}...{head}","merges_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/merges","archive_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/downloads","issues_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/issues{/number}","pulls_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/pulls{/number}","milestones_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/milestones{/number}","notifications_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/labels{/name}","releases_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/releases{/id}","deployments_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/deployments","created_at":"2016-03-02T13:37:49Z","updated_at":"2018-05-05T20:50:08Z","pushed_at":"2018-05-11T09:16:50Z","git_url":"git://github.com/netzstrategen/wordpress-core-standards.git","ssh_url":"[email protected]:netzstrategen/wordpress-core-standards.git","clone_url":"https://github.com/netzstrategen/wordpress-core-standards.git","svn_url":"https://github.com/netzstrategen/wordpress-core-standards","homepage":null,"size":84,"stargazers_count":2,"watchers_count":2,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":3,"license":null,"forks":1,"open_issues":3,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/pulls/16"},"html":{"href":"https://github.com/netzstrategen/wordpress-core-standards/pull/16"},"issue":{"href":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/issues/16"},"comments":{"href":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/issues/16/comments"},"review_comments":{"href":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/pulls/16/comments"},"review_comment":{"href":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/pulls/16/commits"},"statuses":{"href":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/statuses/7338b2d624a3aff194fcd67a3847d01d9b2382a6"}},"author_association":"CONTRIBUTOR"}} | {
"id": 52965413,
"name": "netzstrategen/wordpress-core-standards",
"url": "https://api.github.com/repos/netzstrategen/wordpress-core-standards"
} | {
"id": 13467494,
"login": "juanlopez4691",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/13467494?",
"url": "https://api.github.com/users/juanlopez4691"
} | {
"id": 10957709,
"login": "netzstrategen",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/10957709?",
"url": "https://api.github.com/orgs/netzstrategen"
} | 2018-05-11T10:13:58 | 7660361237 | {"actor":{"display_login":"juanlopez4691"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/axibase/atsd-use-cases/pulls/comments/186398980","pull_request_review_id":117967475,"id":186398980,"diff_hunk":"@@ -68,7 +68,7 @@ Follow the quick [launch procedure](#launch-sandbox-with-automated-slack-and-ema\n \n ### Launch ATSD Sandbox\n \n-Follow this procedure to send AWS CloudWatch events into ATSD to enrich standard SNS notifications with additional resource details and AWS console links.\n+Follow this procedure to send AWS CloudWatch events into ATSD to enrich standard SNS notifications with additional resource details and AWS console links. Before launching the sandbox, add the desired variables and bind the needed volumes to the sandbox launch command below based on your preferences in [Custom Launch Preferences](#custom-launch-preferences).","path":"how-to/aws/cloud-watch-alert/README.md","position":null,"original_position":5,"commit_id":"46d4321f69beab2a0cb84f0e2f0eab64c975ab24","original_commit_id":"2db11840681b77979d84f9eb3465461ac63d01b0","user":{"login":"kghamilton89","id":29099829,"avatar_url":"https://avatars3.githubusercontent.com/u/29099829?v=4","gravatar_id":"","url":"https://api.github.com/users/kghamilton89","html_url":"https://github.com/kghamilton89","followers_url":"https://api.github.com/users/kghamilton89/followers","following_url":"https://api.github.com/users/kghamilton89/following{/other_user}","gists_url":"https://api.github.com/users/kghamilton89/gists{/gist_id}","starred_url":"https://api.github.com/users/kghamilton89/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kghamilton89/subscriptions","organizations_url":"https://api.github.com/users/kghamilton89/orgs","repos_url":"https://api.github.com/users/kghamilton89/repos","events_url":"https://api.github.com/users/kghamilton89/events{/privacy}","received_events_url":"https://api.github.com/users/kghamilton89/received_events","type":"User","site_admin":false},"body":"Removed.","created_at":"2018-05-07T11:44:09Z","updated_at":"2018-05-07T11:44:09Z","html_url":"https://github.com/axibase/atsd-use-cases/pull/234#discussion_r186398980","pull_request_url":"https://api.github.com/repos/axibase/atsd-use-cases/pulls/234","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/axibase/atsd-use-cases/pulls/comments/186398980"},"html":{"href":"https://github.com/axibase/atsd-use-cases/pull/234#discussion_r186398980"},"pull_request":{"href":"https://api.github.com/repos/axibase/atsd-use-cases/pulls/234"}},"in_reply_to_id":186070228},"pull_request":{"url":"https://api.github.com/repos/axibase/atsd-use-cases/pulls/234","id":185971341,"html_url":"https://github.com/axibase/atsd-use-cases/pull/234","diff_url":"https://github.com/axibase/atsd-use-cases/pull/234.diff","patch_url":"https://github.com/axibase/atsd-use-cases/pull/234.patch","issue_url":"https://api.github.com/repos/axibase/atsd-use-cases/issues/234","number":234,"state":"open","locked":false,"title":"procedure-clairifications","user":{"login":"kghamilton89","id":29099829,"avatar_url":"https://avatars3.githubusercontent.com/u/29099829?v=4","gravatar_id":"","url":"https://api.github.com/users/kghamilton89","html_url":"https://github.com/kghamilton89","followers_url":"https://api.github.com/users/kghamilton89/followers","following_url":"https://api.github.com/users/kghamilton89/following{/other_user}","gists_url":"https://api.github.com/users/kghamilton89/gists{/gist_id}","starred_url":"https://api.github.com/users/kghamilton89/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kghamilton89/subscriptions","organizations_url":"https://api.github.com/users/kghamilton89/orgs","repos_url":"https://api.github.com/users/kghamilton89/repos","events_url":"https://api.github.com/users/kghamilton89/events{/privacy}","received_events_url":"https://api.github.com/users/kghamilton89/received_events","type":"User","site_admin":false},"body":"Going through doing end-to-end AWS notification testing, I made a few changes to the instructions to help a user understand what they're doing if they choose to go through the \"quick\" versus \"custom\" launch.","created_at":"2018-05-04T12:36:36Z","updated_at":"2018-05-07T11:44:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"39978d64199fcbeca22bf7867c05525517d8654e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/axibase/atsd-use-cases/pulls/234/commits","review_comments_url":"https://api.github.com/repos/axibase/atsd-use-cases/pulls/234/comments","review_comment_url":"https://api.github.com/repos/axibase/atsd-use-cases/pulls/comments{/number}","comments_url":"https://api.github.com/repos/axibase/atsd-use-cases/issues/234/comments","statuses_url":"https://api.github.com/repos/axibase/atsd-use-cases/statuses/46d4321f69beab2a0cb84f0e2f0eab64c975ab24","head":{"label":"axibase:aws-updates","ref":"aws-updates","sha":"46d4321f69beab2a0cb84f0e2f0eab64c975ab24","user":{"login":"axibase","id":10971416,"avatar_url":"https://avatars0.githubusercontent.com/u/10971416?v=4","gravatar_id":"","url":"https://api.github.com/users/axibase","html_url":"https://github.com/axibase","followers_url":"https://api.github.com/users/axibase/followers","following_url":"https://api.github.com/users/axibase/following{/other_user}","gists_url":"https://api.github.com/users/axibase/gists{/gist_id}","starred_url":"https://api.github.com/users/axibase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/axibase/subscriptions","organizations_url":"https://api.github.com/users/axibase/orgs","repos_url":"https://api.github.com/users/axibase/repos","events_url":"https://api.github.com/users/axibase/events{/privacy}","received_events_url":"https://api.github.com/users/axibase/received_events","type":"Organization","site_admin":false},"repo":{"id":68802096,"name":"atsd-use-cases","full_name":"axibase/atsd-use-cases","owner":{"login":"axibase","id":10971416,"avatar_url":"https://avatars0.githubusercontent.com/u/10971416?v=4","gravatar_id":"","url":"https://api.github.com/users/axibase","html_url":"https://github.com/axibase","followers_url":"https://api.github.com/users/axibase/followers","following_url":"https://api.github.com/users/axibase/following{/other_user}","gists_url":"https://api.github.com/users/axibase/gists{/gist_id}","starred_url":"https://api.github.com/users/axibase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/axibase/subscriptions","organizations_url":"https://api.github.com/users/axibase/orgs","repos_url":"https://api.github.com/users/axibase/repos","events_url":"https://api.github.com/users/axibase/events{/privacy}","received_events_url":"https://api.github.com/users/axibase/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/axibase/atsd-use-cases","description":"Axibase Time Series Database: Usage Examples and Research Articles","fork":false,"url":"https://api.github.com/repos/axibase/atsd-use-cases","forks_url":"https://api.github.com/repos/axibase/atsd-use-cases/forks","keys_url":"https://api.github.com/repos/axibase/atsd-use-cases/keys{/key_id}","collaborators_url":"https://api.github.com/repos/axibase/atsd-use-cases/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/axibase/atsd-use-cases/teams","hooks_url":"https://api.github.com/repos/axibase/atsd-use-cases/hooks","issue_events_url":"https://api.github.com/repos/axibase/atsd-use-cases/issues/events{/number}","events_url":"https://api.github.com/repos/axibase/atsd-use-cases/events","assignees_url":"https://api.github.com/repos/axibase/atsd-use-cases/assignees{/user}","branches_url":"https://api.github.com/repos/axibase/atsd-use-cases/branches{/branch}","tags_url":"https://api.github.com/repos/axibase/atsd-use-cases/tags","blobs_url":"https://api.github.com/repos/axibase/atsd-use-cases/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/axibase/atsd-use-cases/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/axibase/atsd-use-cases/git/refs{/sha}","trees_url":"https://api.github.com/repos/axibase/atsd-use-cases/git/trees{/sha}","statuses_url":"https://api.github.com/repos/axibase/atsd-use-cases/statuses/{sha}","languages_url":"https://api.github.com/repos/axibase/atsd-use-cases/languages","stargazers_url":"https://api.github.com/repos/axibase/atsd-use-cases/stargazers","contributors_url":"https://api.github.com/repos/axibase/atsd-use-cases/contributors","subscribers_url":"https://api.github.com/repos/axibase/atsd-use-cases/subscribers","subscription_url":"https://api.github.com/repos/axibase/atsd-use-cases/subscription","commits_url":"https://api.github.com/repos/axibase/atsd-use-cases/commits{/sha}","git_commits_url":"https://api.github.com/repos/axibase/atsd-use-cases/git/commits{/sha}","comments_url":"https://api.github.com/repos/axibase/atsd-use-cases/comments{/number}","issue_comment_url":"https://api.github.com/repos/axibase/atsd-use-cases/issues/comments{/number}","contents_url":"https://api.github.com/repos/axibase/atsd-use-cases/contents/{+path}","compare_url":"https://api.github.com/repos/axibase/atsd-use-cases/compare/{base}...{head}","merges_url":"https://api.github.com/repos/axibase/atsd-use-cases/merges","archive_url":"https://api.github.com/repos/axibase/atsd-use-cases/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/axibase/atsd-use-cases/downloads","issues_url":"https://api.github.com/repos/axibase/atsd-use-cases/issues{/number}","pulls_url":"https://api.github.com/repos/axibase/atsd-use-cases/pulls{/number}","milestones_url":"https://api.github.com/repos/axibase/atsd-use-cases/milestones{/number}","notifications_url":"https://api.github.com/repos/axibase/atsd-use-cases/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/axibase/atsd-use-cases/labels{/name}","releases_url":"https://api.github.com/repos/axibase/atsd-use-cases/releases{/id}","deployments_url":"https://api.github.com/repos/axibase/atsd-use-cases/deployments","created_at":"2016-09-21T09:34:14Z","updated_at":"2018-05-05T15:55:18Z","pushed_at":"2018-05-07T11:43:45Z","git_url":"git://github.com/axibase/atsd-use-cases.git","ssh_url":"[email protected]:axibase/atsd-use-cases.git","clone_url":"https://github.com/axibase/atsd-use-cases.git","svn_url":"https://github.com/axibase/atsd-use-cases","homepage":"","size":73005,"stargazers_count":322,"watchers_count":322,"language":"HTML","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":29,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":29,"open_issues":3,"watchers":322,"default_branch":"master"}},"base":{"label":"axibase:master","ref":"master","sha":"98c8f3ac5cc95fa8303e0e82ef4ff71eccf080cc","user":{"login":"axibase","id":10971416,"avatar_url":"https://avatars0.githubusercontent.com/u/10971416?v=4","gravatar_id":"","url":"https://api.github.com/users/axibase","html_url":"https://github.com/axibase","followers_url":"https://api.github.com/users/axibase/followers","following_url":"https://api.github.com/users/axibase/following{/other_user}","gists_url":"https://api.github.com/users/axibase/gists{/gist_id}","starred_url":"https://api.github.com/users/axibase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/axibase/subscriptions","organizations_url":"https://api.github.com/users/axibase/orgs","repos_url":"https://api.github.com/users/axibase/repos","events_url":"https://api.github.com/users/axibase/events{/privacy}","received_events_url":"https://api.github.com/users/axibase/received_events","type":"Organization","site_admin":false},"repo":{"id":68802096,"name":"atsd-use-cases","full_name":"axibase/atsd-use-cases","owner":{"login":"axibase","id":10971416,"avatar_url":"https://avatars0.githubusercontent.com/u/10971416?v=4","gravatar_id":"","url":"https://api.github.com/users/axibase","html_url":"https://github.com/axibase","followers_url":"https://api.github.com/users/axibase/followers","following_url":"https://api.github.com/users/axibase/following{/other_user}","gists_url":"https://api.github.com/users/axibase/gists{/gist_id}","starred_url":"https://api.github.com/users/axibase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/axibase/subscriptions","organizations_url":"https://api.github.com/users/axibase/orgs","repos_url":"https://api.github.com/users/axibase/repos","events_url":"https://api.github.com/users/axibase/events{/privacy}","received_events_url":"https://api.github.com/users/axibase/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/axibase/atsd-use-cases","description":"Axibase Time Series Database: Usage Examples and Research Articles","fork":false,"url":"https://api.github.com/repos/axibase/atsd-use-cases","forks_url":"https://api.github.com/repos/axibase/atsd-use-cases/forks","keys_url":"https://api.github.com/repos/axibase/atsd-use-cases/keys{/key_id}","collaborators_url":"https://api.github.com/repos/axibase/atsd-use-cases/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/axibase/atsd-use-cases/teams","hooks_url":"https://api.github.com/repos/axibase/atsd-use-cases/hooks","issue_events_url":"https://api.github.com/repos/axibase/atsd-use-cases/issues/events{/number}","events_url":"https://api.github.com/repos/axibase/atsd-use-cases/events","assignees_url":"https://api.github.com/repos/axibase/atsd-use-cases/assignees{/user}","branches_url":"https://api.github.com/repos/axibase/atsd-use-cases/branches{/branch}","tags_url":"https://api.github.com/repos/axibase/atsd-use-cases/tags","blobs_url":"https://api.github.com/repos/axibase/atsd-use-cases/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/axibase/atsd-use-cases/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/axibase/atsd-use-cases/git/refs{/sha}","trees_url":"https://api.github.com/repos/axibase/atsd-use-cases/git/trees{/sha}","statuses_url":"https://api.github.com/repos/axibase/atsd-use-cases/statuses/{sha}","languages_url":"https://api.github.com/repos/axibase/atsd-use-cases/languages","stargazers_url":"https://api.github.com/repos/axibase/atsd-use-cases/stargazers","contributors_url":"https://api.github.com/repos/axibase/atsd-use-cases/contributors","subscribers_url":"https://api.github.com/repos/axibase/atsd-use-cases/subscribers","subscription_url":"https://api.github.com/repos/axibase/atsd-use-cases/subscription","commits_url":"https://api.github.com/repos/axibase/atsd-use-cases/commits{/sha}","git_commits_url":"https://api.github.com/repos/axibase/atsd-use-cases/git/commits{/sha}","comments_url":"https://api.github.com/repos/axibase/atsd-use-cases/comments{/number}","issue_comment_url":"https://api.github.com/repos/axibase/atsd-use-cases/issues/comments{/number}","contents_url":"https://api.github.com/repos/axibase/atsd-use-cases/contents/{+path}","compare_url":"https://api.github.com/repos/axibase/atsd-use-cases/compare/{base}...{head}","merges_url":"https://api.github.com/repos/axibase/atsd-use-cases/merges","archive_url":"https://api.github.com/repos/axibase/atsd-use-cases/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/axibase/atsd-use-cases/downloads","issues_url":"https://api.github.com/repos/axibase/atsd-use-cases/issues{/number}","pulls_url":"https://api.github.com/repos/axibase/atsd-use-cases/pulls{/number}","milestones_url":"https://api.github.com/repos/axibase/atsd-use-cases/milestones{/number}","notifications_url":"https://api.github.com/repos/axibase/atsd-use-cases/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/axibase/atsd-use-cases/labels{/name}","releases_url":"https://api.github.com/repos/axibase/atsd-use-cases/releases{/id}","deployments_url":"https://api.github.com/repos/axibase/atsd-use-cases/deployments","created_at":"2016-09-21T09:34:14Z","updated_at":"2018-05-05T15:55:18Z","pushed_at":"2018-05-07T11:43:45Z","git_url":"git://github.com/axibase/atsd-use-cases.git","ssh_url":"[email protected]:axibase/atsd-use-cases.git","clone_url":"https://github.com/axibase/atsd-use-cases.git","svn_url":"https://github.com/axibase/atsd-use-cases","homepage":"","size":73005,"stargazers_count":322,"watchers_count":322,"language":"HTML","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":29,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":29,"open_issues":3,"watchers":322,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/axibase/atsd-use-cases/pulls/234"},"html":{"href":"https://github.com/axibase/atsd-use-cases/pull/234"},"issue":{"href":"https://api.github.com/repos/axibase/atsd-use-cases/issues/234"},"comments":{"href":"https://api.github.com/repos/axibase/atsd-use-cases/issues/234/comments"},"review_comments":{"href":"https://api.github.com/repos/axibase/atsd-use-cases/pulls/234/comments"},"review_comment":{"href":"https://api.github.com/repos/axibase/atsd-use-cases/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/axibase/atsd-use-cases/pulls/234/commits"},"statuses":{"href":"https://api.github.com/repos/axibase/atsd-use-cases/statuses/46d4321f69beab2a0cb84f0e2f0eab64c975ab24"}},"author_association":"CONTRIBUTOR"}} | {
"id": 68802096,
"name": "axibase/atsd-use-cases",
"url": "https://api.github.com/repos/axibase/atsd-use-cases"
} | {
"id": 29099829,
"login": "kghamilton89",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/29099829?",
"url": "https://api.github.com/users/kghamilton89"
} | {
"id": 10971416,
"login": "axibase",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/10971416?",
"url": "https://api.github.com/orgs/axibase"
} | 2018-05-07T11:44:09 | 7637155277 | {"actor":{"display_login":"kghamilton89"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/solidusio/solidus/pulls/comments/243343594","pull_request_review_id":187089288,"id":243343594,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MzM0MzU5NA==","diff_hunk":"@@ -7,13 +7,13 @@ module Spree\n before(:each) do\n stub_authentication!\n Spree::Config[:track_inventory_levels] = false\n- country_zone = create(:zone, name: 'CountryZone')\n+ @country_zone = create(:zone, name: 'CountryZone')","path":"api/spec/requests/spree/api/checkouts_controller_spec.rb","position":5,"original_position":5,"commit_id":"692b9063af321097163ae7d727109cba70c5c41c","original_commit_id":"692b9063af321097163ae7d727109cba70c5c41c","user":{"login":"ericsaupe","id":5138892,"node_id":"MDQ6VXNlcjUxMzg4OTI=","avatar_url":"https://avatars0.githubusercontent.com/u/5138892?v=4","gravatar_id":"","url":"https://api.github.com/users/ericsaupe","html_url":"https://github.com/ericsaupe","followers_url":"https://api.github.com/users/ericsaupe/followers","following_url":"https://api.github.com/users/ericsaupe/following{/other_user}","gists_url":"https://api.github.com/users/ericsaupe/gists{/gist_id}","starred_url":"https://api.github.com/users/ericsaupe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericsaupe/subscriptions","organizations_url":"https://api.github.com/users/ericsaupe/orgs","repos_url":"https://api.github.com/users/ericsaupe/repos","events_url":"https://api.github.com/users/ericsaupe/events{/privacy}","received_events_url":"https://api.github.com/users/ericsaupe/received_events","type":"User","site_admin":false},"body":"Yeah, let me give it shot.","created_at":"2018-12-20T16:51:46Z","updated_at":"2018-12-20T16:51:46Z","html_url":"https://github.com/solidusio/solidus/pull/3006#discussion_r243343594","pull_request_url":"https://api.github.com/repos/solidusio/solidus/pulls/3006","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/solidusio/solidus/pulls/comments/243343594"},"html":{"href":"https://github.com/solidusio/solidus/pull/3006#discussion_r243343594"},"pull_request":{"href":"https://api.github.com/repos/solidusio/solidus/pulls/3006"}},"in_reply_to_id":243062722},"pull_request":{"url":"https://api.github.com/repos/solidusio/solidus/pulls/3006","id":239610148,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM5NjEwMTQ4","html_url":"https://github.com/solidusio/solidus/pull/3006","diff_url":"https://github.com/solidusio/solidus/pull/3006.diff","patch_url":"https://github.com/solidusio/solidus/pull/3006.patch","issue_url":"https://api.github.com/repos/solidusio/solidus/issues/3006","number":3006,"state":"open","locked":false,"title":"Allow :state to be a permitted checkout attribute","user":{"login":"ericsaupe","id":5138892,"node_id":"MDQ6VXNlcjUxMzg4OTI=","avatar_url":"https://avatars0.githubusercontent.com/u/5138892?v=4","gravatar_id":"","url":"https://api.github.com/users/ericsaupe","html_url":"https://github.com/ericsaupe","followers_url":"https://api.github.com/users/ericsaupe/followers","following_url":"https://api.github.com/users/ericsaupe/following{/other_user}","gists_url":"https://api.github.com/users/ericsaupe/gists{/gist_id}","starred_url":"https://api.github.com/users/ericsaupe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericsaupe/subscriptions","organizations_url":"https://api.github.com/users/ericsaupe/orgs","repos_url":"https://api.github.com/users/ericsaupe/repos","events_url":"https://api.github.com/users/ericsaupe/events{/privacy}","received_events_url":"https://api.github.com/users/ericsaupe/received_events","type":"User","site_admin":false},"body":"Using the API can be problematic when updating the order once it has\r\nmade it to the confirm step. This is due to calling next when\r\nupdating the order when it is in the confirm step. Passing in a new\r\nstate fixes this and flows through the state machine starting from\r\nthe passed in state.","created_at":"2018-12-18T19:49:14Z","updated_at":"2018-12-20T16:51:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c3cb212418920a668e75dc7790df8c21c6560c15","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/solidusio/solidus/pulls/3006/commits","review_comments_url":"https://api.github.com/repos/solidusio/solidus/pulls/3006/comments","review_comment_url":"https://api.github.com/repos/solidusio/solidus/pulls/comments{/number}","comments_url":"https://api.github.com/repos/solidusio/solidus/issues/3006/comments","statuses_url":"https://api.github.com/repos/solidusio/solidus/statuses/692b9063af321097163ae7d727109cba70c5c41c","head":{"label":"ericsaupe:api-state","ref":"api-state","sha":"692b9063af321097163ae7d727109cba70c5c41c","user":{"login":"ericsaupe","id":5138892,"node_id":"MDQ6VXNlcjUxMzg4OTI=","avatar_url":"https://avatars0.githubusercontent.com/u/5138892?v=4","gravatar_id":"","url":"https://api.github.com/users/ericsaupe","html_url":"https://github.com/ericsaupe","followers_url":"https://api.github.com/users/ericsaupe/followers","following_url":"https://api.github.com/users/ericsaupe/following{/other_user}","gists_url":"https://api.github.com/users/ericsaupe/gists{/gist_id}","starred_url":"https://api.github.com/users/ericsaupe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericsaupe/subscriptions","organizations_url":"https://api.github.com/users/ericsaupe/orgs","repos_url":"https://api.github.com/users/ericsaupe/repos","events_url":"https://api.github.com/users/ericsaupe/events{/privacy}","received_events_url":"https://api.github.com/users/ericsaupe/received_events","type":"User","site_admin":false},"repo":{"id":63613874,"node_id":"MDEwOlJlcG9zaXRvcnk2MzYxMzg3NA==","name":"solidus","full_name":"ericsaupe/solidus","private":false,"owner":{"login":"ericsaupe","id":5138892,"node_id":"MDQ6VXNlcjUxMzg4OTI=","avatar_url":"https://avatars0.githubusercontent.com/u/5138892?v=4","gravatar_id":"","url":"https://api.github.com/users/ericsaupe","html_url":"https://github.com/ericsaupe","followers_url":"https://api.github.com/users/ericsaupe/followers","following_url":"https://api.github.com/users/ericsaupe/following{/other_user}","gists_url":"https://api.github.com/users/ericsaupe/gists{/gist_id}","starred_url":"https://api.github.com/users/ericsaupe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericsaupe/subscriptions","organizations_url":"https://api.github.com/users/ericsaupe/orgs","repos_url":"https://api.github.com/users/ericsaupe/repos","events_url":"https://api.github.com/users/ericsaupe/events{/privacy}","received_events_url":"https://api.github.com/users/ericsaupe/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ericsaupe/solidus","description":"Solidus, Rails eCommerce System","fork":true,"url":"https://api.github.com/repos/ericsaupe/solidus","forks_url":"https://api.github.com/repos/ericsaupe/solidus/forks","keys_url":"https://api.github.com/repos/ericsaupe/solidus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ericsaupe/solidus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ericsaupe/solidus/teams","hooks_url":"https://api.github.com/repos/ericsaupe/solidus/hooks","issue_events_url":"https://api.github.com/repos/ericsaupe/solidus/issues/events{/number}","events_url":"https://api.github.com/repos/ericsaupe/solidus/events","assignees_url":"https://api.github.com/repos/ericsaupe/solidus/assignees{/user}","branches_url":"https://api.github.com/repos/ericsaupe/solidus/branches{/branch}","tags_url":"https://api.github.com/repos/ericsaupe/solidus/tags","blobs_url":"https://api.github.com/repos/ericsaupe/solidus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ericsaupe/solidus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ericsaupe/solidus/git/refs{/sha}","trees_url":"https://api.github.com/repos/ericsaupe/solidus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ericsaupe/solidus/statuses/{sha}","languages_url":"https://api.github.com/repos/ericsaupe/solidus/languages","stargazers_url":"https://api.github.com/repos/ericsaupe/solidus/stargazers","contributors_url":"https://api.github.com/repos/ericsaupe/solidus/contributors","subscribers_url":"https://api.github.com/repos/ericsaupe/solidus/subscribers","subscription_url":"https://api.github.com/repos/ericsaupe/solidus/subscription","commits_url":"https://api.github.com/repos/ericsaupe/solidus/commits{/sha}","git_commits_url":"https://api.github.com/repos/ericsaupe/solidus/git/commits{/sha}","comments_url":"https://api.github.com/repos/ericsaupe/solidus/comments{/number}","issue_comment_url":"https://api.github.com/repos/ericsaupe/solidus/issues/comments{/number}","contents_url":"https://api.github.com/repos/ericsaupe/solidus/contents/{+path}","compare_url":"https://api.github.com/repos/ericsaupe/solidus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ericsaupe/solidus/merges","archive_url":"https://api.github.com/repos/ericsaupe/solidus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ericsaupe/solidus/downloads","issues_url":"https://api.github.com/repos/ericsaupe/solidus/issues{/number}","pulls_url":"https://api.github.com/repos/ericsaupe/solidus/pulls{/number}","milestones_url":"https://api.github.com/repos/ericsaupe/solidus/milestones{/number}","notifications_url":"https://api.github.com/repos/ericsaupe/solidus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ericsaupe/solidus/labels{/name}","releases_url":"https://api.github.com/repos/ericsaupe/solidus/releases{/id}","deployments_url":"https://api.github.com/repos/ericsaupe/solidus/deployments","created_at":"2016-07-18T15:16:44Z","updated_at":"2018-12-18T19:50:07Z","pushed_at":"2018-12-19T23:46:18Z","git_url":"git://github.com/ericsaupe/solidus.git","ssh_url":"[email protected]:ericsaupe/solidus.git","clone_url":"https://github.com/ericsaupe/solidus.git","svn_url":"https://github.com/ericsaupe/solidus","homepage":"https://solidus.io/","size":70557,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"solidusio:master","ref":"master","sha":"af6a140473ab11fdc5b9847d3c3543c484142a24","user":{"login":"solidusio","id":11045486,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMDQ1NDg2","avatar_url":"https://avatars1.githubusercontent.com/u/11045486?v=4","gravatar_id":"","url":"https://api.github.com/users/solidusio","html_url":"https://github.com/solidusio","followers_url":"https://api.github.com/users/solidusio/followers","following_url":"https://api.github.com/users/solidusio/following{/other_user}","gists_url":"https://api.github.com/users/solidusio/gists{/gist_id}","starred_url":"https://api.github.com/users/solidusio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/solidusio/subscriptions","organizations_url":"https://api.github.com/users/solidusio/orgs","repos_url":"https://api.github.com/users/solidusio/repos","events_url":"https://api.github.com/users/solidusio/events{/privacy}","received_events_url":"https://api.github.com/users/solidusio/received_events","type":"Organization","site_admin":false},"repo":{"id":30985840,"node_id":"MDEwOlJlcG9zaXRvcnkzMDk4NTg0MA==","name":"solidus","full_name":"solidusio/solidus","private":false,"owner":{"login":"solidusio","id":11045486,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMDQ1NDg2","avatar_url":"https://avatars1.githubusercontent.com/u/11045486?v=4","gravatar_id":"","url":"https://api.github.com/users/solidusio","html_url":"https://github.com/solidusio","followers_url":"https://api.github.com/users/solidusio/followers","following_url":"https://api.github.com/users/solidusio/following{/other_user}","gists_url":"https://api.github.com/users/solidusio/gists{/gist_id}","starred_url":"https://api.github.com/users/solidusio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/solidusio/subscriptions","organizations_url":"https://api.github.com/users/solidusio/orgs","repos_url":"https://api.github.com/users/solidusio/repos","events_url":"https://api.github.com/users/solidusio/events{/privacy}","received_events_url":"https://api.github.com/users/solidusio/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/solidusio/solidus","description":"Solidus, Rails eCommerce System","fork":false,"url":"https://api.github.com/repos/solidusio/solidus","forks_url":"https://api.github.com/repos/solidusio/solidus/forks","keys_url":"https://api.github.com/repos/solidusio/solidus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/solidusio/solidus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/solidusio/solidus/teams","hooks_url":"https://api.github.com/repos/solidusio/solidus/hooks","issue_events_url":"https://api.github.com/repos/solidusio/solidus/issues/events{/number}","events_url":"https://api.github.com/repos/solidusio/solidus/events","assignees_url":"https://api.github.com/repos/solidusio/solidus/assignees{/user}","branches_url":"https://api.github.com/repos/solidusio/solidus/branches{/branch}","tags_url":"https://api.github.com/repos/solidusio/solidus/tags","blobs_url":"https://api.github.com/repos/solidusio/solidus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/solidusio/solidus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/solidusio/solidus/git/refs{/sha}","trees_url":"https://api.github.com/repos/solidusio/solidus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/solidusio/solidus/statuses/{sha}","languages_url":"https://api.github.com/repos/solidusio/solidus/languages","stargazers_url":"https://api.github.com/repos/solidusio/solidus/stargazers","contributors_url":"https://api.github.com/repos/solidusio/solidus/contributors","subscribers_url":"https://api.github.com/repos/solidusio/solidus/subscribers","subscription_url":"https://api.github.com/repos/solidusio/solidus/subscription","commits_url":"https://api.github.com/repos/solidusio/solidus/commits{/sha}","git_commits_url":"https://api.github.com/repos/solidusio/solidus/git/commits{/sha}","comments_url":"https://api.github.com/repos/solidusio/solidus/comments{/number}","issue_comment_url":"https://api.github.com/repos/solidusio/solidus/issues/comments{/number}","contents_url":"https://api.github.com/repos/solidusio/solidus/contents/{+path}","compare_url":"https://api.github.com/repos/solidusio/solidus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/solidusio/solidus/merges","archive_url":"https://api.github.com/repos/solidusio/solidus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/solidusio/solidus/downloads","issues_url":"https://api.github.com/repos/solidusio/solidus/issues{/number}","pulls_url":"https://api.github.com/repos/solidusio/solidus/pulls{/number}","milestones_url":"https://api.github.com/repos/solidusio/solidus/milestones{/number}","notifications_url":"https://api.github.com/repos/solidusio/solidus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/solidusio/solidus/labels{/name}","releases_url":"https://api.github.com/repos/solidusio/solidus/releases{/id}","deployments_url":"https://api.github.com/repos/solidusio/solidus/deployments","created_at":"2015-02-18T20:41:58Z","updated_at":"2018-12-20T13:24:55Z","pushed_at":"2018-12-20T15:52:48Z","git_url":"git://github.com/solidusio/solidus.git","ssh_url":"[email protected]:solidusio/solidus.git","clone_url":"https://github.com/solidusio/solidus.git","svn_url":"https://github.com/solidusio/solidus","homepage":"https://solidus.io/","size":70795,"stargazers_count":2336,"watchers_count":2336,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":696,"mirror_url":null,"archived":false,"open_issues_count":191,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":696,"open_issues":191,"watchers":2336,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/solidusio/solidus/pulls/3006"},"html":{"href":"https://github.com/solidusio/solidus/pull/3006"},"issue":{"href":"https://api.github.com/repos/solidusio/solidus/issues/3006"},"comments":{"href":"https://api.github.com/repos/solidusio/solidus/issues/3006/comments"},"review_comments":{"href":"https://api.github.com/repos/solidusio/solidus/pulls/3006/comments"},"review_comment":{"href":"https://api.github.com/repos/solidusio/solidus/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/solidusio/solidus/pulls/3006/commits"},"statuses":{"href":"https://api.github.com/repos/solidusio/solidus/statuses/692b9063af321097163ae7d727109cba70c5c41c"}},"author_association":"CONTRIBUTOR"}} | {
"id": 30985840,
"name": "solidusio/solidus",
"url": "https://api.github.com/repos/solidusio/solidus"
} | {
"id": 5138892,
"login": "ericsaupe",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5138892?",
"url": "https://api.github.com/users/ericsaupe"
} | {
"id": 11045486,
"login": "solidusio",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/11045486?",
"url": "https://api.github.com/orgs/solidusio"
} | 2018-12-20T16:51:46 | 8786866546 | {"actor":{"display_login":"ericsaupe"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/fastlane/ci/pulls/comments/175640657","pull_request_review_id":105202131,"id":175640657,"diff_hunk":"@@ -12,12 +12,15 @@ module FastlaneCI\n class ProjectService\n include FastlaneCI::Logging\n attr_accessor :project_data_source\n+ attr_accessor :clone_user_provider_credential\n+ attr_accessor :configuration_git_repo\n \n- def initialize(project_data_source: nil)\n+ def initialize(project_data_source: nil, clone_user_provider_credential:, configuration_git_repo:)\n unless project_data_source.nil?\n raise \"project_data_source must be descendant of #{ProjectDataSource.name}\" unless project_data_source.class <= ProjectDataSource\n end\n \n+ @clone_user_provider_credential = clone_user_provider_credential","path":"services/project_service.rb","position":13,"original_position":13,"commit_id":"7c64259ad540e674f94ddfda7957d3b3ecdfd873","original_commit_id":"7c64259ad540e674f94ddfda7957d3b3ecdfd873","user":{"login":"taquitos","id":1304821,"avatar_url":"https://avatars2.githubusercontent.com/u/1304821?v=4","gravatar_id":"","url":"https://api.github.com/users/taquitos","html_url":"https://github.com/taquitos","followers_url":"https://api.github.com/users/taquitos/followers","following_url":"https://api.github.com/users/taquitos/following{/other_user}","gists_url":"https://api.github.com/users/taquitos/gists{/gist_id}","starred_url":"https://api.github.com/users/taquitos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taquitos/subscriptions","organizations_url":"https://api.github.com/users/taquitos/orgs","repos_url":"https://api.github.com/users/taquitos/repos","events_url":"https://api.github.com/users/taquitos/events{/privacy}","received_events_url":"https://api.github.com/users/taquitos/received_events","type":"User","site_admin":false},"body":"`self. ___ = `","created_at":"2018-03-20T02:32:55Z","updated_at":"2018-03-20T02:32:55Z","html_url":"https://github.com/fastlane/ci/pull/324#discussion_r175640657","pull_request_url":"https://api.github.com/repos/fastlane/ci/pulls/324","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/fastlane/ci/pulls/comments/175640657"},"html":{"href":"https://github.com/fastlane/ci/pull/324#discussion_r175640657"},"pull_request":{"href":"https://api.github.com/repos/fastlane/ci/pulls/324"}}},"pull_request":{"url":"https://api.github.com/repos/fastlane/ci/pulls/324","id":175718833,"html_url":"https://github.com/fastlane/ci/pull/324","diff_url":"https://github.com/fastlane/ci/pull/324.diff","patch_url":"https://github.com/fastlane/ci/pull/324.patch","issue_url":"https://api.github.com/repos/fastlane/ci/issues/324","number":324,"state":"open","locked":false,"title":"Reduce global static method code smells and reduce responsibilities of `Launch` class.","user":{"login":"AndrewMcBurney","id":8942499,"avatar_url":"https://avatars3.githubusercontent.com/u/8942499?v=4","gravatar_id":"","url":"https://api.github.com/users/AndrewMcBurney","html_url":"https://github.com/AndrewMcBurney","followers_url":"https://api.github.com/users/AndrewMcBurney/followers","following_url":"https://api.github.com/users/AndrewMcBurney/following{/other_user}","gists_url":"https://api.github.com/users/AndrewMcBurney/gists{/gist_id}","starred_url":"https://api.github.com/users/AndrewMcBurney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndrewMcBurney/subscriptions","organizations_url":"https://api.github.com/users/AndrewMcBurney/orgs","repos_url":"https://api.github.com/users/AndrewMcBurney/repos","events_url":"https://api.github.com/users/AndrewMcBurney/events{/privacy}","received_events_url":"https://api.github.com/users/AndrewMcBurney/received_events","type":"User","site_admin":false},"body":"This introduces fairly substantial changes, but I believe they're necessary in order to reduce code smells that have accumulated over time (largely due to me).\r\n\r\n### Changes\r\n\r\nThe two main goals of this PR are to:\r\n\r\n1. Decouple business logic from the static methods in the `Launch` class, and move them to appropriate services\r\n2. Remove references to the static helper functions defined in the `Services` class, and make them `private_class_method`s. Instead of using these helpers as global static methods, inject them into the appropriate services in their constructors.","created_at":"2018-03-17T20:06:26Z","updated_at":"2018-03-20T02:32:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5c27f3266044b8e93872ac5eeb135d5fd57f38a1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/fastlane/ci/pulls/324/commits","review_comments_url":"https://api.github.com/repos/fastlane/ci/pulls/324/comments","review_comment_url":"https://api.github.com/repos/fastlane/ci/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fastlane/ci/issues/324/comments","statuses_url":"https://api.github.com/repos/fastlane/ci/statuses/7c64259ad540e674f94ddfda7957d3b3ecdfd873","head":{"label":"AndrewMcBurney:reduce_static_code_smells","ref":"reduce_static_code_smells","sha":"7c64259ad540e674f94ddfda7957d3b3ecdfd873","user":{"login":"AndrewMcBurney","id":8942499,"avatar_url":"https://avatars3.githubusercontent.com/u/8942499?v=4","gravatar_id":"","url":"https://api.github.com/users/AndrewMcBurney","html_url":"https://github.com/AndrewMcBurney","followers_url":"https://api.github.com/users/AndrewMcBurney/followers","following_url":"https://api.github.com/users/AndrewMcBurney/following{/other_user}","gists_url":"https://api.github.com/users/AndrewMcBurney/gists{/gist_id}","starred_url":"https://api.github.com/users/AndrewMcBurney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndrewMcBurney/subscriptions","organizations_url":"https://api.github.com/users/AndrewMcBurney/orgs","repos_url":"https://api.github.com/users/AndrewMcBurney/repos","events_url":"https://api.github.com/users/AndrewMcBurney/events{/privacy}","received_events_url":"https://api.github.com/users/AndrewMcBurney/received_events","type":"User","site_admin":false},"repo":{"id":121562368,"name":"ci","full_name":"AndrewMcBurney/ci","owner":{"login":"AndrewMcBurney","id":8942499,"avatar_url":"https://avatars3.githubusercontent.com/u/8942499?v=4","gravatar_id":"","url":"https://api.github.com/users/AndrewMcBurney","html_url":"https://github.com/AndrewMcBurney","followers_url":"https://api.github.com/users/AndrewMcBurney/followers","following_url":"https://api.github.com/users/AndrewMcBurney/following{/other_user}","gists_url":"https://api.github.com/users/AndrewMcBurney/gists{/gist_id}","starred_url":"https://api.github.com/users/AndrewMcBurney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndrewMcBurney/subscriptions","organizations_url":"https://api.github.com/users/AndrewMcBurney/orgs","repos_url":"https://api.github.com/users/AndrewMcBurney/repos","events_url":"https://api.github.com/users/AndrewMcBurney/events{/privacy}","received_events_url":"https://api.github.com/users/AndrewMcBurney/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/AndrewMcBurney/ci","description":"Open source, self hosted, mobile optimized CI powered by fastlane","fork":true,"url":"https://api.github.com/repos/AndrewMcBurney/ci","forks_url":"https://api.github.com/repos/AndrewMcBurney/ci/forks","keys_url":"https://api.github.com/repos/AndrewMcBurney/ci/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AndrewMcBurney/ci/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AndrewMcBurney/ci/teams","hooks_url":"https://api.github.com/repos/AndrewMcBurney/ci/hooks","issue_events_url":"https://api.github.com/repos/AndrewMcBurney/ci/issues/events{/number}","events_url":"https://api.github.com/repos/AndrewMcBurney/ci/events","assignees_url":"https://api.github.com/repos/AndrewMcBurney/ci/assignees{/user}","branches_url":"https://api.github.com/repos/AndrewMcBurney/ci/branches{/branch}","tags_url":"https://api.github.com/repos/AndrewMcBurney/ci/tags","blobs_url":"https://api.github.com/repos/AndrewMcBurney/ci/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AndrewMcBurney/ci/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AndrewMcBurney/ci/git/refs{/sha}","trees_url":"https://api.github.com/repos/AndrewMcBurney/ci/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AndrewMcBurney/ci/statuses/{sha}","languages_url":"https://api.github.com/repos/AndrewMcBurney/ci/languages","stargazers_url":"https://api.github.com/repos/AndrewMcBurney/ci/stargazers","contributors_url":"https://api.github.com/repos/AndrewMcBurney/ci/contributors","subscribers_url":"https://api.github.com/repos/AndrewMcBurney/ci/subscribers","subscription_url":"https://api.github.com/repos/AndrewMcBurney/ci/subscription","commits_url":"https://api.github.com/repos/AndrewMcBurney/ci/commits{/sha}","git_commits_url":"https://api.github.com/repos/AndrewMcBurney/ci/git/commits{/sha}","comments_url":"https://api.github.com/repos/AndrewMcBurney/ci/comments{/number}","issue_comment_url":"https://api.github.com/repos/AndrewMcBurney/ci/issues/comments{/number}","contents_url":"https://api.github.com/repos/AndrewMcBurney/ci/contents/{+path}","compare_url":"https://api.github.com/repos/AndrewMcBurney/ci/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AndrewMcBurney/ci/merges","archive_url":"https://api.github.com/repos/AndrewMcBurney/ci/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AndrewMcBurney/ci/downloads","issues_url":"https://api.github.com/repos/AndrewMcBurney/ci/issues{/number}","pulls_url":"https://api.github.com/repos/AndrewMcBurney/ci/pulls{/number}","milestones_url":"https://api.github.com/repos/AndrewMcBurney/ci/milestones{/number}","notifications_url":"https://api.github.com/repos/AndrewMcBurney/ci/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AndrewMcBurney/ci/labels{/name}","releases_url":"https://api.github.com/repos/AndrewMcBurney/ci/releases{/id}","deployments_url":"https://api.github.com/repos/AndrewMcBurney/ci/deployments","created_at":"2018-02-14T21:18:20Z","updated_at":"2018-02-14T21:18:22Z","pushed_at":"2018-03-19T23:12:51Z","git_url":"git://github.com/AndrewMcBurney/ci.git","ssh_url":"[email protected]:AndrewMcBurney/ci.git","clone_url":"https://github.com/AndrewMcBurney/ci.git","svn_url":"https://github.com/AndrewMcBurney/ci","homepage":"https://fastlane.tools","size":1631,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"fastlane:master","ref":"master","sha":"afd7dacbbcc47f800d3cd57bac2abf9c87f15f56","user":{"login":"fastlane","id":11098337,"avatar_url":"https://avatars2.githubusercontent.com/u/11098337?v=4","gravatar_id":"","url":"https://api.github.com/users/fastlane","html_url":"https://github.com/fastlane","followers_url":"https://api.github.com/users/fastlane/followers","following_url":"https://api.github.com/users/fastlane/following{/other_user}","gists_url":"https://api.github.com/users/fastlane/gists{/gist_id}","starred_url":"https://api.github.com/users/fastlane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fastlane/subscriptions","organizations_url":"https://api.github.com/users/fastlane/orgs","repos_url":"https://api.github.com/users/fastlane/repos","events_url":"https://api.github.com/users/fastlane/events{/privacy}","received_events_url":"https://api.github.com/users/fastlane/received_events","type":"Organization","site_admin":false},"repo":{"id":114287404,"name":"ci","full_name":"fastlane/ci","owner":{"login":"fastlane","id":11098337,"avatar_url":"https://avatars2.githubusercontent.com/u/11098337?v=4","gravatar_id":"","url":"https://api.github.com/users/fastlane","html_url":"https://github.com/fastlane","followers_url":"https://api.github.com/users/fastlane/followers","following_url":"https://api.github.com/users/fastlane/following{/other_user}","gists_url":"https://api.github.com/users/fastlane/gists{/gist_id}","starred_url":"https://api.github.com/users/fastlane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fastlane/subscriptions","organizations_url":"https://api.github.com/users/fastlane/orgs","repos_url":"https://api.github.com/users/fastlane/repos","events_url":"https://api.github.com/users/fastlane/events{/privacy}","received_events_url":"https://api.github.com/users/fastlane/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fastlane/ci","description":"Open source, self hosted, mobile optimized CI powered by fastlane","fork":false,"url":"https://api.github.com/repos/fastlane/ci","forks_url":"https://api.github.com/repos/fastlane/ci/forks","keys_url":"https://api.github.com/repos/fastlane/ci/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fastlane/ci/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fastlane/ci/teams","hooks_url":"https://api.github.com/repos/fastlane/ci/hooks","issue_events_url":"https://api.github.com/repos/fastlane/ci/issues/events{/number}","events_url":"https://api.github.com/repos/fastlane/ci/events","assignees_url":"https://api.github.com/repos/fastlane/ci/assignees{/user}","branches_url":"https://api.github.com/repos/fastlane/ci/branches{/branch}","tags_url":"https://api.github.com/repos/fastlane/ci/tags","blobs_url":"https://api.github.com/repos/fastlane/ci/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fastlane/ci/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fastlane/ci/git/refs{/sha}","trees_url":"https://api.github.com/repos/fastlane/ci/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fastlane/ci/statuses/{sha}","languages_url":"https://api.github.com/repos/fastlane/ci/languages","stargazers_url":"https://api.github.com/repos/fastlane/ci/stargazers","contributors_url":"https://api.github.com/repos/fastlane/ci/contributors","subscribers_url":"https://api.github.com/repos/fastlane/ci/subscribers","subscription_url":"https://api.github.com/repos/fastlane/ci/subscription","commits_url":"https://api.github.com/repos/fastlane/ci/commits{/sha}","git_commits_url":"https://api.github.com/repos/fastlane/ci/git/commits{/sha}","comments_url":"https://api.github.com/repos/fastlane/ci/comments{/number}","issue_comment_url":"https://api.github.com/repos/fastlane/ci/issues/comments{/number}","contents_url":"https://api.github.com/repos/fastlane/ci/contents/{+path}","compare_url":"https://api.github.com/repos/fastlane/ci/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fastlane/ci/merges","archive_url":"https://api.github.com/repos/fastlane/ci/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fastlane/ci/downloads","issues_url":"https://api.github.com/repos/fastlane/ci/issues{/number}","pulls_url":"https://api.github.com/repos/fastlane/ci/pulls{/number}","milestones_url":"https://api.github.com/repos/fastlane/ci/milestones{/number}","notifications_url":"https://api.github.com/repos/fastlane/ci/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fastlane/ci/labels{/name}","releases_url":"https://api.github.com/repos/fastlane/ci/releases{/id}","deployments_url":"https://api.github.com/repos/fastlane/ci/deployments","created_at":"2017-12-14T19:17:22Z","updated_at":"2018-03-20T01:11:34Z","pushed_at":"2018-03-20T00:52:02Z","git_url":"git://github.com/fastlane/ci.git","ssh_url":"[email protected]:fastlane/ci.git","clone_url":"https://github.com/fastlane/ci.git","svn_url":"https://github.com/fastlane/ci","homepage":"https://fastlane.tools","size":1796,"stargazers_count":1273,"watchers_count":1273,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":39,"mirror_url":null,"archived":false,"open_issues_count":62,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":39,"open_issues":62,"watchers":1273,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fastlane/ci/pulls/324"},"html":{"href":"https://github.com/fastlane/ci/pull/324"},"issue":{"href":"https://api.github.com/repos/fastlane/ci/issues/324"},"comments":{"href":"https://api.github.com/repos/fastlane/ci/issues/324/comments"},"review_comments":{"href":"https://api.github.com/repos/fastlane/ci/pulls/324/comments"},"review_comment":{"href":"https://api.github.com/repos/fastlane/ci/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fastlane/ci/pulls/324/commits"},"statuses":{"href":"https://api.github.com/repos/fastlane/ci/statuses/7c64259ad540e674f94ddfda7957d3b3ecdfd873"}},"author_association":"MEMBER"}} | {
"id": 114287404,
"name": "fastlane/ci",
"url": "https://api.github.com/repos/fastlane/ci"
} | {
"id": 1304821,
"login": "taquitos",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1304821?",
"url": "https://api.github.com/users/taquitos"
} | {
"id": 11098337,
"login": "fastlane",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/11098337?",
"url": "https://api.github.com/orgs/fastlane"
} | 2018-03-20T02:32:55 | 7404086668 | {"actor":{"display_login":"taquitos"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/Citadel-Station-13/Citadel-Station-13/pulls/comments/168920692","pull_request_review_id":97373035,"id":168920692,"diff_hunk":"@@ -29,6 +29,7 @@\n #define BIOGENERATOR 32 //Uses biomass\r\n #define LIMBGROWER 64 //Uses synthetic flesh\r\n #define SMELTER 128 //uses various minerals\r\n+#define\tAUTOYLATHE\t256\t//Uses glass/metal/Plastic\r","path":"code/__DEFINES/machines.dm","position":4,"original_position":4,"commit_id":"09ebc7f09814118317a1b54dfe95f10f6fa4895d","original_commit_id":"09ebc7f09814118317a1b54dfe95f10f6fa4895d","user":{"login":"kevinz000","id":2003111,"avatar_url":"https://avatars0.githubusercontent.com/u/2003111?v=4","gravatar_id":"","url":"https://api.github.com/users/kevinz000","html_url":"https://github.com/kevinz000","followers_url":"https://api.github.com/users/kevinz000/followers","following_url":"https://api.github.com/users/kevinz000/following{/other_user}","gists_url":"https://api.github.com/users/kevinz000/gists{/gist_id}","starred_url":"https://api.github.com/users/kevinz000/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevinz000/subscriptions","organizations_url":"https://api.github.com/users/kevinz000/orgs","repos_url":"https://api.github.com/users/kevinz000/repos","events_url":"https://api.github.com/users/kevinz000/events{/privacy}","received_events_url":"https://api.github.com/users/kevinz000/received_events","type":"User","site_admin":false},"body":"keep indents/spacing constant. look at the one above.","created_at":"2018-02-17T12:24:11Z","updated_at":"2018-02-17T12:24:11Z","html_url":"https://github.com/Citadel-Station-13/Citadel-Station-13/pull/5534#discussion_r168920692","pull_request_url":"https://api.github.com/repos/Citadel-Station-13/Citadel-Station-13/pulls/5534","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Citadel-Station-13/Citadel-Station-13/pulls/comments/168920692"},"html":{"href":"https://github.com/Citadel-Station-13/Citadel-Station-13/pull/5534#discussion_r168920692"},"pull_request":{"href":"https://api.github.com/repos/Citadel-Station-13/Citadel-Station-13/pulls/5534"}}},"pull_request":{"url":"https://api.github.com/repos/Citadel-Station-13/Citadel-Station-13/pulls/5534","id":169713341,"html_url":"https://github.com/Citadel-Station-13/Citadel-Station-13/pull/5534","diff_url":"https://github.com/Citadel-Station-13/Citadel-Station-13/pull/5534.diff","patch_url":"https://github.com/Citadel-Station-13/Citadel-Station-13/pull/5534.patch","issue_url":"https://api.github.com/repos/Citadel-Station-13/Citadel-Station-13/issues/5534","number":5534,"state":"open","locked":false,"title":"[Ready to merge] Au-toy-lathe","user":{"login":"Zna12","id":7254089,"avatar_url":"https://avatars0.githubusercontent.com/u/7254089?v=4","gravatar_id":"","url":"https://api.github.com/users/Zna12","html_url":"https://github.com/Zna12","followers_url":"https://api.github.com/users/Zna12/followers","following_url":"https://api.github.com/users/Zna12/following{/other_user}","gists_url":"https://api.github.com/users/Zna12/gists{/gist_id}","starred_url":"https://api.github.com/users/Zna12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zna12/subscriptions","organizations_url":"https://api.github.com/users/Zna12/orgs","repos_url":"https://api.github.com/users/Zna12/repos","events_url":"https://api.github.com/users/Zna12/events{/privacy}","received_events_url":"https://api.github.com/users/Zna12/received_events","type":"User","site_admin":false},"body":"[Changelogs]: This is an autoylathe. It makes toys using plastic, metal, and glass. It makes... a lot. of toys.\r\n\r\n:cl: Zna12\r\nadd: Autoylathe\r\n/:cl:\r\n\r\n[why]: # (Please add a short description [two lines down] of why you think these changes would benefit the game. If you can't justify it in words, it might not be worth adding.)\r\n","created_at":"2018-02-16T20:02:39Z","updated_at":"2018-02-17T12:24:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6aef6937febcf7331676754f16c7c2760303d3f0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":423868782,"url":"https://api.github.com/repos/Citadel-Station-13/Citadel-Station-13/labels/Feature","name":"Feature","color":"0052cc","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Citadel-Station-13/Citadel-Station-13/pulls/5534/commits","review_comments_url":"https://api.github.com/repos/Citadel-Station-13/Citadel-Station-13/pulls/5534/comments","review_comment_url":"https://api.github.com/repos/Citadel-Station-13/Citadel-Station-13/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Citadel-Station-13/Citadel-Station-13/issues/5534/comments","statuses_url":"https://api.github.com/repos/Citadel-Station-13/Citadel-Station-13/statuses/09ebc7f09814118317a1b54dfe95f10f6fa4895d","head":{"label":"Zna12:Toylathe","ref":"Toylathe","sha":"09ebc7f09814118317a1b54dfe95f10f6fa4895d","user":{"login":"Zna12","id":7254089,"avatar_url":"https://avatars0.githubusercontent.com/u/7254089?v=4","gravatar_id":"","url":"https://api.github.com/users/Zna12","html_url":"https://github.com/Zna12","followers_url":"https://api.github.com/users/Zna12/followers","following_url":"https://api.github.com/users/Zna12/following{/other_user}","gists_url":"https://api.github.com/users/Zna12/gists{/gist_id}","starred_url":"https://api.github.com/users/Zna12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zna12/subscriptions","organizations_url":"https://api.github.com/users/Zna12/orgs","repos_url":"https://api.github.com/users/Zna12/repos","events_url":"https://api.github.com/users/Zna12/events{/privacy}","received_events_url":"https://api.github.com/users/Zna12/received_events","type":"User","site_admin":false},"repo":{"id":119312804,"name":"Citadel-Station-13","full_name":"Zna12/Citadel-Station-13","owner":{"login":"Zna12","id":7254089,"avatar_url":"https://avatars0.githubusercontent.com/u/7254089?v=4","gravatar_id":"","url":"https://api.github.com/users/Zna12","html_url":"https://github.com/Zna12","followers_url":"https://api.github.com/users/Zna12/followers","following_url":"https://api.github.com/users/Zna12/following{/other_user}","gists_url":"https://api.github.com/users/Zna12/gists{/gist_id}","starred_url":"https://api.github.com/users/Zna12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zna12/subscriptions","organizations_url":"https://api.github.com/users/Zna12/orgs","repos_url":"https://api.github.com/users/Zna12/repos","events_url":"https://api.github.com/users/Zna12/events{/privacy}","received_events_url":"https://api.github.com/users/Zna12/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Zna12/Citadel-Station-13","description":"Active build for Citadel Station","fork":true,"url":"https://api.github.com/repos/Zna12/Citadel-Station-13","forks_url":"https://api.github.com/repos/Zna12/Citadel-Station-13/forks","keys_url":"https://api.github.com/repos/Zna12/Citadel-Station-13/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Zna12/Citadel-Station-13/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Zna12/Citadel-Station-13/teams","hooks_url":"https://api.github.com/repos/Zna12/Citadel-Station-13/hooks","issue_events_url":"https://api.github.com/repos/Zna12/Citadel-Station-13/issues/events{/number}","events_url":"https://api.github.com/repos/Zna12/Citadel-Station-13/events","assignees_url":"https://api.github.com/repos/Zna12/Citadel-Station-13/assignees{/user}","branches_url":"https://api.github.com/repos/Zna12/Citadel-Station-13/branches{/branch}","tags_url":"https://api.github.com/repos/Zna12/Citadel-Station-13/tags","blobs_url":"https://api.github.com/repos/Zna12/Citadel-Station-13/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Zna12/Citadel-Station-13/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Zna12/Citadel-Station-13/git/refs{/sha}","trees_url":"https://api.github.com/repos/Zna12/Citadel-Station-13/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Zna12/Citadel-Station-13/statuses/{sha}","languages_url":"https://api.github.com/repos/Zna12/Citadel-Station-13/languages","stargazers_url":"https://api.github.com/repos/Zna12/Citadel-Station-13/stargazers","contributors_url":"https://api.github.com/repos/Zna12/Citadel-Station-13/contributors","subscribers_url":"https://api.github.com/repos/Zna12/Citadel-Station-13/subscribers","subscription_url":"https://api.github.com/repos/Zna12/Citadel-Station-13/subscription","commits_url":"https://api.github.com/repos/Zna12/Citadel-Station-13/commits{/sha}","git_commits_url":"https://api.github.com/repos/Zna12/Citadel-Station-13/git/commits{/sha}","comments_url":"https://api.github.com/repos/Zna12/Citadel-Station-13/comments{/number}","issue_comment_url":"https://api.github.com/repos/Zna12/Citadel-Station-13/issues/comments{/number}","contents_url":"https://api.github.com/repos/Zna12/Citadel-Station-13/contents/{+path}","compare_url":"https://api.github.com/repos/Zna12/Citadel-Station-13/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Zna12/Citadel-Station-13/merges","archive_url":"https://api.github.com/repos/Zna12/Citadel-Station-13/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Zna12/Citadel-Station-13/downloads","issues_url":"https://api.github.com/repos/Zna12/Citadel-Station-13/issues{/number}","pulls_url":"https://api.github.com/repos/Zna12/Citadel-Station-13/pulls{/number}","milestones_url":"https://api.github.com/repos/Zna12/Citadel-Station-13/milestones{/number}","notifications_url":"https://api.github.com/repos/Zna12/Citadel-Station-13/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Zna12/Citadel-Station-13/labels{/name}","releases_url":"https://api.github.com/repos/Zna12/Citadel-Station-13/releases{/id}","deployments_url":"https://api.github.com/repos/Zna12/Citadel-Station-13/deployments","created_at":"2018-01-29T00:50:44Z","updated_at":"2018-01-29T00:50:58Z","pushed_at":"2018-02-17T07:21:58Z","git_url":"git://github.com/Zna12/Citadel-Station-13.git","ssh_url":"[email protected]:Zna12/Citadel-Station-13.git","clone_url":"https://github.com/Zna12/Citadel-Station-13.git","svn_url":"https://github.com/Zna12/Citadel-Station-13","homepage":"","size":398536,"stargazers_count":0,"watchers_count":0,"language":"DM","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Citadel-Station-13:master","ref":"master","sha":"1bc3908203727538c9a3023e4bf0cc8b409385a8","user":{"login":"Citadel-Station-13","id":11160241,"avatar_url":"https://avatars0.githubusercontent.com/u/11160241?v=4","gravatar_id":"","url":"https://api.github.com/users/Citadel-Station-13","html_url":"https://github.com/Citadel-Station-13","followers_url":"https://api.github.com/users/Citadel-Station-13/followers","following_url":"https://api.github.com/users/Citadel-Station-13/following{/other_user}","gists_url":"https://api.github.com/users/Citadel-Station-13/gists{/gist_id}","starred_url":"https://api.github.com/users/Citadel-Station-13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Citadel-Station-13/subscriptions","organizations_url":"https://api.github.com/users/Citadel-Station-13/orgs","repos_url":"https://api.github.com/users/Citadel-Station-13/repos","events_url":"https://api.github.com/users/Citadel-Station-13/events{/privacy}","received_events_url":"https://api.github.com/users/Citadel-Station-13/received_events","type":"Organization","site_admin":false},"repo":{"id":62485194,"name":"Citadel-Station-13","full_name":"Citadel-Station-13/Citadel-Station-13","owner":{"login":"Citadel-Station-13","id":11160241,"avatar_url":"https://avatars0.githubusercontent.com/u/11160241?v=4","gravatar_id":"","url":"https://api.github.com/users/Citadel-Station-13","html_url":"https://github.com/Citadel-Station-13","followers_url":"https://api.github.com/users/Citadel-Station-13/followers","following_url":"https://api.github.com/users/Citadel-Station-13/following{/other_user}","gists_url":"https://api.github.com/users/Citadel-Station-13/gists{/gist_id}","starred_url":"https://api.github.com/users/Citadel-Station-13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Citadel-Station-13/subscriptions","organizations_url":"https://api.github.com/users/Citadel-Station-13/orgs","repos_url":"https://api.github.com/users/Citadel-Station-13/repos","events_url":"https://api.github.com/users/Citadel-Station-13/events{/privacy}","received_events_url":"https://api.github.com/users/Citadel-Station-13/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Citadel-Station-13/Citadel-Station-13","description":"Active build for Citadel Station","fork":false,"url":"https://api.github.com/repos/Citadel-Station-13/Citadel-Station-13","forks_url":"https://api.github.com/repos/Citadel-Station-13/Citadel-Station-13/forks","keys_url":"https://api.github.com/repos/Citadel-Station-13/Citadel-Station-13/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Citadel-Station-13/Citadel-Station-13/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Citadel-Station-13/Citadel-Station-13/teams","hooks_url":"https://api.github.com/repos/Citadel-Station-13/Citadel-Station-13/hooks","issue_events_url":"https://api.github.com/repos/Citadel-Station-13/Citadel-Station-13/issues/events{/number}","events_url":"https://api.github.com/repos/Citadel-Station-13/Citadel-Station-13/events","assignees_url":"https://api.github.com/repos/Citadel-Station-13/Citadel-Station-13/assignees{/user}","branches_url":"https://api.github.com/repos/Citadel-Station-13/Citadel-Station-13/branches{/branch}","tags_url":"https://api.github.com/repos/Citadel-Station-13/Citadel-Station-13/tags","blobs_url":"https://api.github.com/repos/Citadel-Station-13/Citadel-Station-13/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Citadel-Station-13/Citadel-Station-13/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Citadel-Station-13/Citadel-Station-13/git/refs{/sha}","trees_url":"https://api.github.com/repos/Citadel-Station-13/Citadel-Station-13/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Citadel-Station-13/Citadel-Station-13/statuses/{sha}","languages_url":"https://api.github.com/repos/Citadel-Station-13/Citadel-Station-13/languages","stargazers_url":"https://api.github.com/repos/Citadel-Station-13/Citadel-Station-13/stargazers","contributors_url":"https://api.github.com/repos/Citadel-Station-13/Citadel-Station-13/contributors","subscribers_url":"https://api.github.com/repos/Citadel-Station-13/Citadel-Station-13/subscribers","subscription_url":"https://api.github.com/repos/Citadel-Station-13/Citadel-Station-13/subscription","commits_url":"https://api.github.com/repos/Citadel-Station-13/Citadel-Station-13/commits{/sha}","git_commits_url":"https://api.github.com/repos/Citadel-Station-13/Citadel-Station-13/git/commits{/sha}","comments_url":"https://api.github.com/repos/Citadel-Station-13/Citadel-Station-13/comments{/number}","issue_comment_url":"https://api.github.com/repos/Citadel-Station-13/Citadel-Station-13/issues/comments{/number}","contents_url":"https://api.github.com/repos/Citadel-Station-13/Citadel-Station-13/contents/{+path}","compare_url":"https://api.github.com/repos/Citadel-Station-13/Citadel-Station-13/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Citadel-Station-13/Citadel-Station-13/merges","archive_url":"https://api.github.com/repos/Citadel-Station-13/Citadel-Station-13/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Citadel-Station-13/Citadel-Station-13/downloads","issues_url":"https://api.github.com/repos/Citadel-Station-13/Citadel-Station-13/issues{/number}","pulls_url":"https://api.github.com/repos/Citadel-Station-13/Citadel-Station-13/pulls{/number}","milestones_url":"https://api.github.com/repos/Citadel-Station-13/Citadel-Station-13/milestones{/number}","notifications_url":"https://api.github.com/repos/Citadel-Station-13/Citadel-Station-13/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Citadel-Station-13/Citadel-Station-13/labels{/name}","releases_url":"https://api.github.com/repos/Citadel-Station-13/Citadel-Station-13/releases{/id}","deployments_url":"https://api.github.com/repos/Citadel-Station-13/Citadel-Station-13/deployments","created_at":"2016-07-03T07:00:22Z","updated_at":"2018-02-17T07:45:01Z","pushed_at":"2018-02-17T09:19:41Z","git_url":"git://github.com/Citadel-Station-13/Citadel-Station-13.git","ssh_url":"[email protected]:Citadel-Station-13/Citadel-Station-13.git","clone_url":"https://github.com/Citadel-Station-13/Citadel-Station-13.git","svn_url":"https://github.com/Citadel-Station-13/Citadel-Station-13","homepage":"","size":398443,"stargazers_count":16,"watchers_count":16,"language":"DM","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":84,"mirror_url":null,"archived":false,"open_issues_count":27,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0"},"forks":84,"open_issues":27,"watchers":16,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Citadel-Station-13/Citadel-Station-13/pulls/5534"},"html":{"href":"https://github.com/Citadel-Station-13/Citadel-Station-13/pull/5534"},"issue":{"href":"https://api.github.com/repos/Citadel-Station-13/Citadel-Station-13/issues/5534"},"comments":{"href":"https://api.github.com/repos/Citadel-Station-13/Citadel-Station-13/issues/5534/comments"},"review_comments":{"href":"https://api.github.com/repos/Citadel-Station-13/Citadel-Station-13/pulls/5534/comments"},"review_comment":{"href":"https://api.github.com/repos/Citadel-Station-13/Citadel-Station-13/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Citadel-Station-13/Citadel-Station-13/pulls/5534/commits"},"statuses":{"href":"https://api.github.com/repos/Citadel-Station-13/Citadel-Station-13/statuses/09ebc7f09814118317a1b54dfe95f10f6fa4895d"}},"author_association":"CONTRIBUTOR"}} | {
"id": 62485194,
"name": "Citadel-Station-13/Citadel-Station-13",
"url": "https://api.github.com/repos/Citadel-Station-13/Citadel-Station-13"
} | {
"id": 2003111,
"login": "kevinz000",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2003111?",
"url": "https://api.github.com/users/kevinz000"
} | {
"id": 11160241,
"login": "Citadel-Station-13",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/11160241?",
"url": "https://api.github.com/orgs/Citadel-Station-13"
} | 2018-02-17T12:24:11 | 7258769744 | {"actor":{"display_login":"kevinz000"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/open-io/ansible-role-openio-repository/pulls/comments/173624784","pull_request_review_id":102853511,"id":173624784,"diff_hunk":"@@ -1,48 +1,74 @@\n-repo-openio-sds\n-===============\n+[](https://travis-ci.org/open-io/ansible-role-openio-repository)\n+# Ansible role `repository`\n \n-Ansible role that configure OpenIO SDS repositories.\n+An Ansible role for setup OpenIO's repositories. Specifically, the responsibilities of this role are to:\n \n-Requirements\n-------------\n+- Setup key and repository for an OpenIO product and a specific distribution\n+- Manage credentials for private repositories\n \n-Only supports RedHat 7 and Ubuntu 16.04.\n+## Requirements\n \n-Role Variables\n---------------\n+- Ansible 2.4+\n \n-Available variables are listed below, along with default values (see defaults/main.yml):\n+## Role Variables\n \n- openio_sds_release: '16.04'\n-OpenIO SDS release installed. Defaults to the latest stable release.\n \n- openio_sds_repo_baseurl: http://mirror.openio.io/pub/repo/openio\n-OpenIO base mirror URL for repositories.\n+| Variable | Default | Comments (type) |\n+| :--- | :--- | :--- |\n+| `openio_repository_creds` | `\"\"` | Credentials string |\n+| `openio_repository_disable_policy_autostart` | `true` | (Ubuntu) Disable the autostart of unconfigured packages |\n+| `openio_repository_distribution` | `'17.04'` | Distribution of OpenIO |\n+| `openio_repository_manage_openstack_repository` | `true` | Allow the installation of Openstack's repository |\n+| `openio_repository_openstack_distribution` | `pike` | Openstack's distribution |\n+| `openio_repository_pass` | `\"\"` | Password for private repository |\n+| `openio_repository_product` | `'sds'` | Product of OpenIO |\n+| `openio_repository_user` | `\"\"` | User for private repository |\n+| `openio_repository_state` | `\"present\"` | The state of the repository file |\n \n- openio_sds_repo_produrl: \"{{ openio_sds_repo_baseurl }}/sds\"\n-OpenIO SDS product base URL used to install OpenIO SDS.\n+## Dependencies\n \n- openio_sds_repo_releaseurl: \"{{ openio_sds_repo_produrl }}/{{ openio_sds_release }}\"\n-OpenIO SDS product release URL used to install OpenIO SDS.\n+No dependencies.\n \n-Dependencies\n-------------\n+## Example Playbook\n \n-This role has no dependencies.\n+```yaml\n+- hosts: all\n+ gather_facts: true\n+ become: true\n+ roles:\n+ - role: openio-repository\n+ - role: openio-repository\n+ openio_repository_distribution: \"16.10\"\n+ - role: openio-repository\n+ openio_repository_distribution: \"16.10\"\n+ openio_repository_state: \"asbent\"\n+ - role: openio-repository\n+ openio_repository_product: yolo\n+ openio_repository_user: foo\n+ openio_repository_pass: bar\n \n-Example Playbook\n-----------------\n+```\n \n- - hosts: servers\n- roles:\n- - { role: openio-repo-openio-sds, openio_sds_release: '17.04' }\n \n-License\n--------\n+```ini\n+[all]\n+node1 ansible_host=192.168.1.173\n+```\n \n-Apache\n+## Contributing\n \n-OpenIO\n-------\n+Issues, feature requests, ideas are appreciated and can be posted in the Issues section.\n \n-This role was created in 2017 by OpenIO.\n+Pull requests are also very welcome.\n+The best way to submit a PR is by first creating a fork of this Github project, then creating a topic branch for the suggested change and pushing that branch to your own fork.\n+Github can then easily create a PR based on that branch.\n+\n+## License\n+\n+Apache License, Version 2.0\n+\n+## Contributors\n+\n+- [Cedric DELGEHIER](https://github.com/cdelgehier/) (maintainer)","path":"README.md","position":null,"original_position":103,"commit_id":"566b885c3f4bbcd31784238a16ebb93ea07cc25a","original_commit_id":"93f8b099907ab61a9676dfc2aa49c93fbf4b8e4d","user":{"login":"cdelgehier","id":9511687,"avatar_url":"https://avatars0.githubusercontent.com/u/9511687?v=4","gravatar_id":"","url":"https://api.github.com/users/cdelgehier","html_url":"https://github.com/cdelgehier","followers_url":"https://api.github.com/users/cdelgehier/followers","following_url":"https://api.github.com/users/cdelgehier/following{/other_user}","gists_url":"https://api.github.com/users/cdelgehier/gists{/gist_id}","starred_url":"https://api.github.com/users/cdelgehier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdelgehier/subscriptions","organizations_url":"https://api.github.com/users/cdelgehier/orgs","repos_url":"https://api.github.com/users/cdelgehier/repos","events_url":"https://api.github.com/users/cdelgehier/events{/privacy}","received_events_url":"https://api.github.com/users/cdelgehier/received_events","type":"User","site_admin":false},"body":"done\r\n","created_at":"2018-03-10T15:10:05Z","updated_at":"2018-03-10T15:10:05Z","html_url":"https://github.com/open-io/ansible-role-openio-repository/pull/15#discussion_r173624784","pull_request_url":"https://api.github.com/repos/open-io/ansible-role-openio-repository/pulls/15","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/open-io/ansible-role-openio-repository/pulls/comments/173624784"},"html":{"href":"https://github.com/open-io/ansible-role-openio-repository/pull/15#discussion_r173624784"},"pull_request":{"href":"https://api.github.com/repos/open-io/ansible-role-openio-repository/pulls/15"}},"in_reply_to_id":173621080},"pull_request":{"url":"https://api.github.com/repos/open-io/ansible-role-openio-repository/pulls/15","id":173984232,"html_url":"https://github.com/open-io/ansible-role-openio-repository/pull/15","diff_url":"https://github.com/open-io/ansible-role-openio-repository/pull/15.diff","patch_url":"https://github.com/open-io/ansible-role-openio-repository/pull/15.patch","issue_url":"https://api.github.com/repos/open-io/ansible-role-openio-repository/issues/15","number":15,"state":"open","locked":false,"title":"Manage many products, many distribution of product, and the repo state","user":{"login":"cdelgehier","id":9511687,"avatar_url":"https://avatars0.githubusercontent.com/u/9511687?v=4","gravatar_id":"","url":"https://api.github.com/users/cdelgehier","html_url":"https://github.com/cdelgehier","followers_url":"https://api.github.com/users/cdelgehier/followers","following_url":"https://api.github.com/users/cdelgehier/following{/other_user}","gists_url":"https://api.github.com/users/cdelgehier/gists{/gist_id}","starred_url":"https://api.github.com/users/cdelgehier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdelgehier/subscriptions","organizations_url":"https://api.github.com/users/cdelgehier/orgs","repos_url":"https://api.github.com/users/cdelgehier/repos","events_url":"https://api.github.com/users/cdelgehier/events{/privacy}","received_events_url":"https://api.github.com/users/cdelgehier/received_events","type":"User","site_admin":false},"body":"I tried to simplify the role:\r\n- I removed the Debian parts (this linux distribution is not supported atm)\r\n- I've harmonized RedHat & Ubuntu tasks\r\n- I added some Booleans to be a little more polite with the user\r\n- I added a state to the presence of the repo\r\n- I made it possible to have several distribution's repo of installed products\r\n- I added the continuous integration test","created_at":"2018-03-09T11:39:20Z","updated_at":"2018-03-10T15:10:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d4fef21d528fae923d5736775055834de4e2eff7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/open-io/ansible-role-openio-repository/pulls/15/commits","review_comments_url":"https://api.github.com/repos/open-io/ansible-role-openio-repository/pulls/15/comments","review_comment_url":"https://api.github.com/repos/open-io/ansible-role-openio-repository/pulls/comments{/number}","comments_url":"https://api.github.com/repos/open-io/ansible-role-openio-repository/issues/15/comments","statuses_url":"https://api.github.com/repos/open-io/ansible-role-openio-repository/statuses/566b885c3f4bbcd31784238a16ebb93ea07cc25a","head":{"label":"cdelgehier:master","ref":"master","sha":"566b885c3f4bbcd31784238a16ebb93ea07cc25a","user":{"login":"cdelgehier","id":9511687,"avatar_url":"https://avatars0.githubusercontent.com/u/9511687?v=4","gravatar_id":"","url":"https://api.github.com/users/cdelgehier","html_url":"https://github.com/cdelgehier","followers_url":"https://api.github.com/users/cdelgehier/followers","following_url":"https://api.github.com/users/cdelgehier/following{/other_user}","gists_url":"https://api.github.com/users/cdelgehier/gists{/gist_id}","starred_url":"https://api.github.com/users/cdelgehier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdelgehier/subscriptions","organizations_url":"https://api.github.com/users/cdelgehier/orgs","repos_url":"https://api.github.com/users/cdelgehier/repos","events_url":"https://api.github.com/users/cdelgehier/events{/privacy}","received_events_url":"https://api.github.com/users/cdelgehier/received_events","type":"User","site_admin":false},"repo":{"id":124404789,"name":"ansible-role-repo-openio-sds","full_name":"cdelgehier/ansible-role-repo-openio-sds","owner":{"login":"cdelgehier","id":9511687,"avatar_url":"https://avatars0.githubusercontent.com/u/9511687?v=4","gravatar_id":"","url":"https://api.github.com/users/cdelgehier","html_url":"https://github.com/cdelgehier","followers_url":"https://api.github.com/users/cdelgehier/followers","following_url":"https://api.github.com/users/cdelgehier/following{/other_user}","gists_url":"https://api.github.com/users/cdelgehier/gists{/gist_id}","starred_url":"https://api.github.com/users/cdelgehier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdelgehier/subscriptions","organizations_url":"https://api.github.com/users/cdelgehier/orgs","repos_url":"https://api.github.com/users/cdelgehier/repos","events_url":"https://api.github.com/users/cdelgehier/events{/privacy}","received_events_url":"https://api.github.com/users/cdelgehier/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cdelgehier/ansible-role-repo-openio-sds","description":null,"fork":true,"url":"https://api.github.com/repos/cdelgehier/ansible-role-repo-openio-sds","forks_url":"https://api.github.com/repos/cdelgehier/ansible-role-repo-openio-sds/forks","keys_url":"https://api.github.com/repos/cdelgehier/ansible-role-repo-openio-sds/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cdelgehier/ansible-role-repo-openio-sds/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cdelgehier/ansible-role-repo-openio-sds/teams","hooks_url":"https://api.github.com/repos/cdelgehier/ansible-role-repo-openio-sds/hooks","issue_events_url":"https://api.github.com/repos/cdelgehier/ansible-role-repo-openio-sds/issues/events{/number}","events_url":"https://api.github.com/repos/cdelgehier/ansible-role-repo-openio-sds/events","assignees_url":"https://api.github.com/repos/cdelgehier/ansible-role-repo-openio-sds/assignees{/user}","branches_url":"https://api.github.com/repos/cdelgehier/ansible-role-repo-openio-sds/branches{/branch}","tags_url":"https://api.github.com/repos/cdelgehier/ansible-role-repo-openio-sds/tags","blobs_url":"https://api.github.com/repos/cdelgehier/ansible-role-repo-openio-sds/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cdelgehier/ansible-role-repo-openio-sds/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cdelgehier/ansible-role-repo-openio-sds/git/refs{/sha}","trees_url":"https://api.github.com/repos/cdelgehier/ansible-role-repo-openio-sds/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cdelgehier/ansible-role-repo-openio-sds/statuses/{sha}","languages_url":"https://api.github.com/repos/cdelgehier/ansible-role-repo-openio-sds/languages","stargazers_url":"https://api.github.com/repos/cdelgehier/ansible-role-repo-openio-sds/stargazers","contributors_url":"https://api.github.com/repos/cdelgehier/ansible-role-repo-openio-sds/contributors","subscribers_url":"https://api.github.com/repos/cdelgehier/ansible-role-repo-openio-sds/subscribers","subscription_url":"https://api.github.com/repos/cdelgehier/ansible-role-repo-openio-sds/subscription","commits_url":"https://api.github.com/repos/cdelgehier/ansible-role-repo-openio-sds/commits{/sha}","git_commits_url":"https://api.github.com/repos/cdelgehier/ansible-role-repo-openio-sds/git/commits{/sha}","comments_url":"https://api.github.com/repos/cdelgehier/ansible-role-repo-openio-sds/comments{/number}","issue_comment_url":"https://api.github.com/repos/cdelgehier/ansible-role-repo-openio-sds/issues/comments{/number}","contents_url":"https://api.github.com/repos/cdelgehier/ansible-role-repo-openio-sds/contents/{+path}","compare_url":"https://api.github.com/repos/cdelgehier/ansible-role-repo-openio-sds/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cdelgehier/ansible-role-repo-openio-sds/merges","archive_url":"https://api.github.com/repos/cdelgehier/ansible-role-repo-openio-sds/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cdelgehier/ansible-role-repo-openio-sds/downloads","issues_url":"https://api.github.com/repos/cdelgehier/ansible-role-repo-openio-sds/issues{/number}","pulls_url":"https://api.github.com/repos/cdelgehier/ansible-role-repo-openio-sds/pulls{/number}","milestones_url":"https://api.github.com/repos/cdelgehier/ansible-role-repo-openio-sds/milestones{/number}","notifications_url":"https://api.github.com/repos/cdelgehier/ansible-role-repo-openio-sds/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cdelgehier/ansible-role-repo-openio-sds/labels{/name}","releases_url":"https://api.github.com/repos/cdelgehier/ansible-role-repo-openio-sds/releases{/id}","deployments_url":"https://api.github.com/repos/cdelgehier/ansible-role-repo-openio-sds/deployments","created_at":"2018-03-08T14:42:44Z","updated_at":"2018-03-08T14:42:46Z","pushed_at":"2018-03-10T15:09:57Z","git_url":"git://github.com/cdelgehier/ansible-role-repo-openio-sds.git","ssh_url":"[email protected]:cdelgehier/ansible-role-repo-openio-sds.git","clone_url":"https://github.com/cdelgehier/ansible-role-repo-openio-sds.git","svn_url":"https://github.com/cdelgehier/ansible-role-repo-openio-sds","homepage":null,"size":29,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"open-io:master","ref":"master","sha":"7ecabbfa4771a17b90a1bfca4601f7c7a8e39fb9","user":{"login":"open-io","id":11300184,"avatar_url":"https://avatars1.githubusercontent.com/u/11300184?v=4","gravatar_id":"","url":"https://api.github.com/users/open-io","html_url":"https://github.com/open-io","followers_url":"https://api.github.com/users/open-io/followers","following_url":"https://api.github.com/users/open-io/following{/other_user}","gists_url":"https://api.github.com/users/open-io/gists{/gist_id}","starred_url":"https://api.github.com/users/open-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/open-io/subscriptions","organizations_url":"https://api.github.com/users/open-io/orgs","repos_url":"https://api.github.com/users/open-io/repos","events_url":"https://api.github.com/users/open-io/events{/privacy}","received_events_url":"https://api.github.com/users/open-io/received_events","type":"Organization","site_admin":false},"repo":{"id":95092252,"name":"ansible-role-openio-repository","full_name":"open-io/ansible-role-openio-repository","owner":{"login":"open-io","id":11300184,"avatar_url":"https://avatars1.githubusercontent.com/u/11300184?v=4","gravatar_id":"","url":"https://api.github.com/users/open-io","html_url":"https://github.com/open-io","followers_url":"https://api.github.com/users/open-io/followers","following_url":"https://api.github.com/users/open-io/following{/other_user}","gists_url":"https://api.github.com/users/open-io/gists{/gist_id}","starred_url":"https://api.github.com/users/open-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/open-io/subscriptions","organizations_url":"https://api.github.com/users/open-io/orgs","repos_url":"https://api.github.com/users/open-io/repos","events_url":"https://api.github.com/users/open-io/events{/privacy}","received_events_url":"https://api.github.com/users/open-io/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/open-io/ansible-role-openio-repository","description":null,"fork":false,"url":"https://api.github.com/repos/open-io/ansible-role-openio-repository","forks_url":"https://api.github.com/repos/open-io/ansible-role-openio-repository/forks","keys_url":"https://api.github.com/repos/open-io/ansible-role-openio-repository/keys{/key_id}","collaborators_url":"https://api.github.com/repos/open-io/ansible-role-openio-repository/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/open-io/ansible-role-openio-repository/teams","hooks_url":"https://api.github.com/repos/open-io/ansible-role-openio-repository/hooks","issue_events_url":"https://api.github.com/repos/open-io/ansible-role-openio-repository/issues/events{/number}","events_url":"https://api.github.com/repos/open-io/ansible-role-openio-repository/events","assignees_url":"https://api.github.com/repos/open-io/ansible-role-openio-repository/assignees{/user}","branches_url":"https://api.github.com/repos/open-io/ansible-role-openio-repository/branches{/branch}","tags_url":"https://api.github.com/repos/open-io/ansible-role-openio-repository/tags","blobs_url":"https://api.github.com/repos/open-io/ansible-role-openio-repository/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/open-io/ansible-role-openio-repository/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/open-io/ansible-role-openio-repository/git/refs{/sha}","trees_url":"https://api.github.com/repos/open-io/ansible-role-openio-repository/git/trees{/sha}","statuses_url":"https://api.github.com/repos/open-io/ansible-role-openio-repository/statuses/{sha}","languages_url":"https://api.github.com/repos/open-io/ansible-role-openio-repository/languages","stargazers_url":"https://api.github.com/repos/open-io/ansible-role-openio-repository/stargazers","contributors_url":"https://api.github.com/repos/open-io/ansible-role-openio-repository/contributors","subscribers_url":"https://api.github.com/repos/open-io/ansible-role-openio-repository/subscribers","subscription_url":"https://api.github.com/repos/open-io/ansible-role-openio-repository/subscription","commits_url":"https://api.github.com/repos/open-io/ansible-role-openio-repository/commits{/sha}","git_commits_url":"https://api.github.com/repos/open-io/ansible-role-openio-repository/git/commits{/sha}","comments_url":"https://api.github.com/repos/open-io/ansible-role-openio-repository/comments{/number}","issue_comment_url":"https://api.github.com/repos/open-io/ansible-role-openio-repository/issues/comments{/number}","contents_url":"https://api.github.com/repos/open-io/ansible-role-openio-repository/contents/{+path}","compare_url":"https://api.github.com/repos/open-io/ansible-role-openio-repository/compare/{base}...{head}","merges_url":"https://api.github.com/repos/open-io/ansible-role-openio-repository/merges","archive_url":"https://api.github.com/repos/open-io/ansible-role-openio-repository/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/open-io/ansible-role-openio-repository/downloads","issues_url":"https://api.github.com/repos/open-io/ansible-role-openio-repository/issues{/number}","pulls_url":"https://api.github.com/repos/open-io/ansible-role-openio-repository/pulls{/number}","milestones_url":"https://api.github.com/repos/open-io/ansible-role-openio-repository/milestones{/number}","notifications_url":"https://api.github.com/repos/open-io/ansible-role-openio-repository/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/open-io/ansible-role-openio-repository/labels{/name}","releases_url":"https://api.github.com/repos/open-io/ansible-role-openio-repository/releases{/id}","deployments_url":"https://api.github.com/repos/open-io/ansible-role-openio-repository/deployments","created_at":"2017-06-22T08:23:40Z","updated_at":"2018-03-09T16:45:34Z","pushed_at":"2018-03-10T15:09:59Z","git_url":"git://github.com/open-io/ansible-role-openio-repository.git","ssh_url":"[email protected]:open-io/ansible-role-openio-repository.git","clone_url":"https://github.com/open-io/ansible-role-openio-repository.git","svn_url":"https://github.com/open-io/ansible-role-openio-repository","homepage":null,"size":25,"stargazers_count":1,"watchers_count":1,"language":"Shell","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":3,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/open-io/ansible-role-openio-repository/pulls/15"},"html":{"href":"https://github.com/open-io/ansible-role-openio-repository/pull/15"},"issue":{"href":"https://api.github.com/repos/open-io/ansible-role-openio-repository/issues/15"},"comments":{"href":"https://api.github.com/repos/open-io/ansible-role-openio-repository/issues/15/comments"},"review_comments":{"href":"https://api.github.com/repos/open-io/ansible-role-openio-repository/pulls/15/comments"},"review_comment":{"href":"https://api.github.com/repos/open-io/ansible-role-openio-repository/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/open-io/ansible-role-openio-repository/pulls/15/commits"},"statuses":{"href":"https://api.github.com/repos/open-io/ansible-role-openio-repository/statuses/566b885c3f4bbcd31784238a16ebb93ea07cc25a"}},"author_association":"NONE"}} | {
"id": 95092252,
"name": "open-io/ansible-role-openio-repository",
"url": "https://api.github.com/repos/open-io/ansible-role-openio-repository"
} | {
"id": 9511687,
"login": "cdelgehier",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9511687?",
"url": "https://api.github.com/users/cdelgehier"
} | {
"id": 11300184,
"login": "open-io",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/11300184?",
"url": "https://api.github.com/orgs/open-io"
} | 2018-03-10T15:10:05 | 7360106785 | {"actor":{"display_login":"cdelgehier"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/Cadasta/cadasta-test/pulls/comments/171149478","pull_request_review_id":99950646,"id":171149478,"diff_hunk":"@@ -566,6 +851,66 @@ def test_file_with_nonacceptable_mime_type_cannot_be_uploaded(\n '//*[contains(@class, \"file-well\")]'\n '//*[normalize-space()=\"File type not allowed.\"]')\n \n+ @pytest.mark.uploads\n+ def test_multiple_existing_resources_from_different_pages_can_be_attached(","path":"cadasta/test/resource_tests/test_attaching.py","position":555,"original_position":555,"commit_id":"b4a6fb502cea1742883d97e88dff67ad644c1e8f","original_commit_id":"583bd44011d18f6ff67c682cec3ddc6175cc7fe5","user":{"login":"seav","id":873653,"avatar_url":"https://avatars0.githubusercontent.com/u/873653?v=4","gravatar_id":"","url":"https://api.github.com/users/seav","html_url":"https://github.com/seav","followers_url":"https://api.github.com/users/seav/followers","following_url":"https://api.github.com/users/seav/following{/other_user}","gists_url":"https://api.github.com/users/seav/gists{/gist_id}","starred_url":"https://api.github.com/users/seav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seav/subscriptions","organizations_url":"https://api.github.com/users/seav/orgs","repos_url":"https://api.github.com/users/seav/repos","events_url":"https://api.github.com/users/seav/events{/privacy}","received_events_url":"https://api.github.com/users/seav/received_events","type":"User","site_admin":false},"body":"I've add a commit to the branch to remove the 11 dummy resources and replace them with 11 test fixture objects of model `resources.resource` and updated the test to match.","created_at":"2018-02-28T05:56:42Z","updated_at":"2018-02-28T05:56:42Z","html_url":"https://github.com/Cadasta/cadasta-test/pull/83#discussion_r171149478","pull_request_url":"https://api.github.com/repos/Cadasta/cadasta-test/pulls/83","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Cadasta/cadasta-test/pulls/comments/171149478"},"html":{"href":"https://github.com/Cadasta/cadasta-test/pull/83#discussion_r171149478"},"pull_request":{"href":"https://api.github.com/repos/Cadasta/cadasta-test/pulls/83"}},"in_reply_to_id":169388553},"pull_request":{"url":"https://api.github.com/repos/Cadasta/cadasta-test/pulls/83","id":169798599,"html_url":"https://github.com/Cadasta/cadasta-test/pull/83","diff_url":"https://github.com/Cadasta/cadasta-test/pull/83.diff","patch_url":"https://github.com/Cadasta/cadasta-test/pull/83.patch","issue_url":"https://api.github.com/repos/Cadasta/cadasta-test/issues/83","number":83,"state":"open","locked":false,"title":"Finalize second batch of Resources tests","user":{"login":"seav","id":873653,"avatar_url":"https://avatars0.githubusercontent.com/u/873653?v=4","gravatar_id":"","url":"https://api.github.com/users/seav","html_url":"https://github.com/seav","followers_url":"https://api.github.com/users/seav/followers","following_url":"https://api.github.com/users/seav/following{/other_user}","gists_url":"https://api.github.com/users/seav/gists{/gist_id}","starred_url":"https://api.github.com/users/seav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seav/subscriptions","organizations_url":"https://api.github.com/users/seav/orgs","repos_url":"https://api.github.com/users/seav/repos","events_url":"https://api.github.com/users/seav/events{/privacy}","received_events_url":"https://api.github.com/users/seav/received_events","type":"User","site_admin":false},"body":"### Proposed changes in this pull request\r\nAdd automated functional tests for the remaining Resources test cases as described in the Functional Test Cases spreadsheet:\r\n- Update package version to `0.6.0`.\r\n- Add a resources util \"mixin\" class to hold common util methods.\r\n- Add 8 tests that collectively verify 18 test cases.\r\n- Update 1 existing test to better match its test script.\r\n- Add 3 test files for spatial resources.\r\n- Add 11 test fixtures for dummy resources for test case #A26.\r\n- Delete obsolete tests and test methods from Outreachy project.\r\n\r\n### When should this PR be merged\r\nWhen convenient.\r\n\r\n### Risks\r\nNo risks foreseen. This PR should only affect QA and not the actual platform function.\r\n\r\n### Follow-up actions\r\nRelease then update **cadasta-platform**.\r\n\r\n### Checklist (for reviewing)\r\n\r\n#### General\r\n\r\n- [ ] **Is this PR explained thoroughly?** All code changes must be accounted for in the PR description. \r\n- [ ] **Is the PR labeled correctly?** It should have the `migration` label if a new migration is added. \r\n- [ ] **Is the risk level assessment sufficient?** The risks section should contain all risks that might be introduced with the PR and which actions we need to take to mitigate these risks. Possible risks are database migrations, new libraries that need to be installed or changes to deployment scripts.\r\n\r\n#### Functionality\r\n\r\n- [ ] **Are all requirements met?** Compare implemented functionality with the requirements specification.\r\n- [ ] **Does the UI work as expected?** There should be no Javascript errors in the console; all resources should load. There should be no unexpected errors. Deliberately try to break the feature to find out if there are corner cases that are not handled. \r\n\r\n#### Code\r\n\r\n- [ ] **Do you fully understand the introduced changes to the code?** If not ask for clarification, it might uncover ways to solve a problem in a more elegant and efficient way.\r\n- [ ] **Does the PR introduce any inefficient database requests?** Use the debug server to check for duplicate requests. \r\n- [ ] **Are all necessary strings marked for translation?** All strings that are exposed to users via the UI must be [marked for translation](https://docs.djangoproject.com/en/1.10/topics/i18n/translation/). \r\n\r\n#### Tests\r\n\r\n- [ ] **Are there sufficient test cases?** Ensure that all components are tested individually; models, forms, and serializers should be tested in isolation even if a test for a view covers these components. \r\n- [ ] **If this is a bug fix, are tests for the issue in place?** There must be a test case for the bug to ensure the issue won’t regress. Make sure that the tests break without the new code to fix the issue.\r\n- [ ] **If this is a new feature or a significant change to an existing feature?** has the manual testing spreadsheet been updated with instructions for manual testing?\r\n\r\n#### Security\r\n\r\n- [ ] **Confirm this PR doesn't commit any keys, passwords, tokens, usernames, or other secrets.**\r\n- [ ] **Are all UI and API inputs run through forms or serializers?** \r\n- [ ] **Are all external inputs validated and sanitized appropriately?**\r\n- [ ] **Does all branching logic have a default case?**\r\n- [ ] **Does this solution handle outliers and edge cases gracefully?**\r\n- [ ] **Are all external communications secured and restricted to SSL?**\r\n\r\n#### Documentation\r\n\r\n- [ ] **Are changes to the UI documented in the platform docs?** If this PR introduces new platform site functionality or changes existing ones, the changes must be documented in the [Cadasta Platform Documentation](https://github.com/Cadasta/cadasta-docs).\r\n- [ ] **Are changes to the API documented in the API docs?** If this PR introduces new API functionality or changes existing ones, the changes must be documented in the [API docs](https://github.com/Cadasta/api-docs).\r\n- [ ] **Are reusable components documented?** If this PR introduces components that are relevant to other developers (for instance a mixin for a view or a generic form) they should be documented in the Wiki. \r\n","created_at":"2018-02-17T19:51:04Z","updated_at":"2018-02-28T05:56:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ce2c7d88e7c9f900a5ae2188fdd5473e14b503af","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":573793718,"url":"https://api.github.com/repos/Cadasta/cadasta-test/labels/PR:%20needs%20review","name":"PR: needs review","color":"ffd966","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Cadasta/cadasta-test/pulls/83/commits","review_comments_url":"https://api.github.com/repos/Cadasta/cadasta-test/pulls/83/comments","review_comment_url":"https://api.github.com/repos/Cadasta/cadasta-test/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Cadasta/cadasta-test/issues/83/comments","statuses_url":"https://api.github.com/repos/Cadasta/cadasta-test/statuses/b4a6fb502cea1742883d97e88dff67ad644c1e8f","head":{"label":"Cadasta:resources-batch2","ref":"resources-batch2","sha":"b4a6fb502cea1742883d97e88dff67ad644c1e8f","user":{"login":"Cadasta","id":11321107,"avatar_url":"https://avatars0.githubusercontent.com/u/11321107?v=4","gravatar_id":"","url":"https://api.github.com/users/Cadasta","html_url":"https://github.com/Cadasta","followers_url":"https://api.github.com/users/Cadasta/followers","following_url":"https://api.github.com/users/Cadasta/following{/other_user}","gists_url":"https://api.github.com/users/Cadasta/gists{/gist_id}","starred_url":"https://api.github.com/users/Cadasta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cadasta/subscriptions","organizations_url":"https://api.github.com/users/Cadasta/orgs","repos_url":"https://api.github.com/users/Cadasta/repos","events_url":"https://api.github.com/users/Cadasta/events{/privacy}","received_events_url":"https://api.github.com/users/Cadasta/received_events","type":"Organization","site_admin":false},"repo":{"id":75903347,"name":"cadasta-test","full_name":"Cadasta/cadasta-test","owner":{"login":"Cadasta","id":11321107,"avatar_url":"https://avatars0.githubusercontent.com/u/11321107?v=4","gravatar_id":"","url":"https://api.github.com/users/Cadasta","html_url":"https://github.com/Cadasta","followers_url":"https://api.github.com/users/Cadasta/followers","following_url":"https://api.github.com/users/Cadasta/following{/other_user}","gists_url":"https://api.github.com/users/Cadasta/gists{/gist_id}","starred_url":"https://api.github.com/users/Cadasta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cadasta/subscriptions","organizations_url":"https://api.github.com/users/Cadasta/orgs","repos_url":"https://api.github.com/users/Cadasta/repos","events_url":"https://api.github.com/users/Cadasta/events{/privacy}","received_events_url":"https://api.github.com/users/Cadasta/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Cadasta/cadasta-test","description":"Cadasta Automated Functional Test Suite","fork":false,"url":"https://api.github.com/repos/Cadasta/cadasta-test","forks_url":"https://api.github.com/repos/Cadasta/cadasta-test/forks","keys_url":"https://api.github.com/repos/Cadasta/cadasta-test/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Cadasta/cadasta-test/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Cadasta/cadasta-test/teams","hooks_url":"https://api.github.com/repos/Cadasta/cadasta-test/hooks","issue_events_url":"https://api.github.com/repos/Cadasta/cadasta-test/issues/events{/number}","events_url":"https://api.github.com/repos/Cadasta/cadasta-test/events","assignees_url":"https://api.github.com/repos/Cadasta/cadasta-test/assignees{/user}","branches_url":"https://api.github.com/repos/Cadasta/cadasta-test/branches{/branch}","tags_url":"https://api.github.com/repos/Cadasta/cadasta-test/tags","blobs_url":"https://api.github.com/repos/Cadasta/cadasta-test/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Cadasta/cadasta-test/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Cadasta/cadasta-test/git/refs{/sha}","trees_url":"https://api.github.com/repos/Cadasta/cadasta-test/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Cadasta/cadasta-test/statuses/{sha}","languages_url":"https://api.github.com/repos/Cadasta/cadasta-test/languages","stargazers_url":"https://api.github.com/repos/Cadasta/cadasta-test/stargazers","contributors_url":"https://api.github.com/repos/Cadasta/cadasta-test/contributors","subscribers_url":"https://api.github.com/repos/Cadasta/cadasta-test/subscribers","subscription_url":"https://api.github.com/repos/Cadasta/cadasta-test/subscription","commits_url":"https://api.github.com/repos/Cadasta/cadasta-test/commits{/sha}","git_commits_url":"https://api.github.com/repos/Cadasta/cadasta-test/git/commits{/sha}","comments_url":"https://api.github.com/repos/Cadasta/cadasta-test/comments{/number}","issue_comment_url":"https://api.github.com/repos/Cadasta/cadasta-test/issues/comments{/number}","contents_url":"https://api.github.com/repos/Cadasta/cadasta-test/contents/{+path}","compare_url":"https://api.github.com/repos/Cadasta/cadasta-test/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Cadasta/cadasta-test/merges","archive_url":"https://api.github.com/repos/Cadasta/cadasta-test/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Cadasta/cadasta-test/downloads","issues_url":"https://api.github.com/repos/Cadasta/cadasta-test/issues{/number}","pulls_url":"https://api.github.com/repos/Cadasta/cadasta-test/pulls{/number}","milestones_url":"https://api.github.com/repos/Cadasta/cadasta-test/milestones{/number}","notifications_url":"https://api.github.com/repos/Cadasta/cadasta-test/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Cadasta/cadasta-test/labels{/name}","releases_url":"https://api.github.com/repos/Cadasta/cadasta-test/releases{/id}","deployments_url":"https://api.github.com/repos/Cadasta/cadasta-test/deployments","created_at":"2016-12-08T04:37:50Z","updated_at":"2017-09-20T06:02:50Z","pushed_at":"2018-02-28T05:53:06Z","git_url":"git://github.com/Cadasta/cadasta-test.git","ssh_url":"[email protected]:Cadasta/cadasta-test.git","clone_url":"https://github.com/Cadasta/cadasta-test.git","svn_url":"https://github.com/Cadasta/cadasta-test","homepage":"","size":10875,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"archived":false,"open_issues_count":16,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0"},"forks":9,"open_issues":16,"watchers":1,"default_branch":"master"}},"base":{"label":"Cadasta:master","ref":"master","sha":"427aee43f11bc49ae37c82c51ac98dd269fd8af9","user":{"login":"Cadasta","id":11321107,"avatar_url":"https://avatars0.githubusercontent.com/u/11321107?v=4","gravatar_id":"","url":"https://api.github.com/users/Cadasta","html_url":"https://github.com/Cadasta","followers_url":"https://api.github.com/users/Cadasta/followers","following_url":"https://api.github.com/users/Cadasta/following{/other_user}","gists_url":"https://api.github.com/users/Cadasta/gists{/gist_id}","starred_url":"https://api.github.com/users/Cadasta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cadasta/subscriptions","organizations_url":"https://api.github.com/users/Cadasta/orgs","repos_url":"https://api.github.com/users/Cadasta/repos","events_url":"https://api.github.com/users/Cadasta/events{/privacy}","received_events_url":"https://api.github.com/users/Cadasta/received_events","type":"Organization","site_admin":false},"repo":{"id":75903347,"name":"cadasta-test","full_name":"Cadasta/cadasta-test","owner":{"login":"Cadasta","id":11321107,"avatar_url":"https://avatars0.githubusercontent.com/u/11321107?v=4","gravatar_id":"","url":"https://api.github.com/users/Cadasta","html_url":"https://github.com/Cadasta","followers_url":"https://api.github.com/users/Cadasta/followers","following_url":"https://api.github.com/users/Cadasta/following{/other_user}","gists_url":"https://api.github.com/users/Cadasta/gists{/gist_id}","starred_url":"https://api.github.com/users/Cadasta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cadasta/subscriptions","organizations_url":"https://api.github.com/users/Cadasta/orgs","repos_url":"https://api.github.com/users/Cadasta/repos","events_url":"https://api.github.com/users/Cadasta/events{/privacy}","received_events_url":"https://api.github.com/users/Cadasta/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Cadasta/cadasta-test","description":"Cadasta Automated Functional Test Suite","fork":false,"url":"https://api.github.com/repos/Cadasta/cadasta-test","forks_url":"https://api.github.com/repos/Cadasta/cadasta-test/forks","keys_url":"https://api.github.com/repos/Cadasta/cadasta-test/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Cadasta/cadasta-test/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Cadasta/cadasta-test/teams","hooks_url":"https://api.github.com/repos/Cadasta/cadasta-test/hooks","issue_events_url":"https://api.github.com/repos/Cadasta/cadasta-test/issues/events{/number}","events_url":"https://api.github.com/repos/Cadasta/cadasta-test/events","assignees_url":"https://api.github.com/repos/Cadasta/cadasta-test/assignees{/user}","branches_url":"https://api.github.com/repos/Cadasta/cadasta-test/branches{/branch}","tags_url":"https://api.github.com/repos/Cadasta/cadasta-test/tags","blobs_url":"https://api.github.com/repos/Cadasta/cadasta-test/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Cadasta/cadasta-test/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Cadasta/cadasta-test/git/refs{/sha}","trees_url":"https://api.github.com/repos/Cadasta/cadasta-test/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Cadasta/cadasta-test/statuses/{sha}","languages_url":"https://api.github.com/repos/Cadasta/cadasta-test/languages","stargazers_url":"https://api.github.com/repos/Cadasta/cadasta-test/stargazers","contributors_url":"https://api.github.com/repos/Cadasta/cadasta-test/contributors","subscribers_url":"https://api.github.com/repos/Cadasta/cadasta-test/subscribers","subscription_url":"https://api.github.com/repos/Cadasta/cadasta-test/subscription","commits_url":"https://api.github.com/repos/Cadasta/cadasta-test/commits{/sha}","git_commits_url":"https://api.github.com/repos/Cadasta/cadasta-test/git/commits{/sha}","comments_url":"https://api.github.com/repos/Cadasta/cadasta-test/comments{/number}","issue_comment_url":"https://api.github.com/repos/Cadasta/cadasta-test/issues/comments{/number}","contents_url":"https://api.github.com/repos/Cadasta/cadasta-test/contents/{+path}","compare_url":"https://api.github.com/repos/Cadasta/cadasta-test/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Cadasta/cadasta-test/merges","archive_url":"https://api.github.com/repos/Cadasta/cadasta-test/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Cadasta/cadasta-test/downloads","issues_url":"https://api.github.com/repos/Cadasta/cadasta-test/issues{/number}","pulls_url":"https://api.github.com/repos/Cadasta/cadasta-test/pulls{/number}","milestones_url":"https://api.github.com/repos/Cadasta/cadasta-test/milestones{/number}","notifications_url":"https://api.github.com/repos/Cadasta/cadasta-test/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Cadasta/cadasta-test/labels{/name}","releases_url":"https://api.github.com/repos/Cadasta/cadasta-test/releases{/id}","deployments_url":"https://api.github.com/repos/Cadasta/cadasta-test/deployments","created_at":"2016-12-08T04:37:50Z","updated_at":"2017-09-20T06:02:50Z","pushed_at":"2018-02-28T05:53:06Z","git_url":"git://github.com/Cadasta/cadasta-test.git","ssh_url":"[email protected]:Cadasta/cadasta-test.git","clone_url":"https://github.com/Cadasta/cadasta-test.git","svn_url":"https://github.com/Cadasta/cadasta-test","homepage":"","size":10875,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"archived":false,"open_issues_count":16,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0"},"forks":9,"open_issues":16,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Cadasta/cadasta-test/pulls/83"},"html":{"href":"https://github.com/Cadasta/cadasta-test/pull/83"},"issue":{"href":"https://api.github.com/repos/Cadasta/cadasta-test/issues/83"},"comments":{"href":"https://api.github.com/repos/Cadasta/cadasta-test/issues/83/comments"},"review_comments":{"href":"https://api.github.com/repos/Cadasta/cadasta-test/pulls/83/comments"},"review_comment":{"href":"https://api.github.com/repos/Cadasta/cadasta-test/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Cadasta/cadasta-test/pulls/83/commits"},"statuses":{"href":"https://api.github.com/repos/Cadasta/cadasta-test/statuses/b4a6fb502cea1742883d97e88dff67ad644c1e8f"}},"author_association":"MEMBER"}} | {
"id": 75903347,
"name": "Cadasta/cadasta-test",
"url": "https://api.github.com/repos/Cadasta/cadasta-test"
} | {
"id": 873653,
"login": "seav",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/873653?",
"url": "https://api.github.com/users/seav"
} | {
"id": 11321107,
"login": "Cadasta",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/11321107?",
"url": "https://api.github.com/orgs/Cadasta"
} | 2018-02-28T05:56:42 | 7307955499 | {"actor":{"display_login":"seav"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/OSGP/Integration-Tests/pulls/comments/165671395","pull_request_review_id":93652184,"id":165671395,"diff_hunk":"@@ -1,548 +0,0 @@\n-/**\n- * Copyright 2016 Smart Society Services B.V.\n- *\n- * Licensed under the Apache License, Version 2.0 (the \"License\"); you may not use this file except in compliance with the License. You may obtain a copy of the License at\n- *\n- * http://www.apache.org/licenses/LICENSE-2.0\n- */\n-package com.alliander.osgp.cucumber.core;\n-\n-import java.util.Calendar;\n-import java.util.HashMap;\n-import java.util.Map;\n-import java.util.regex.Matcher;\n-import java.util.regex.Pattern;\n-\n-import org.apache.commons.codec.DecoderException;\n-import org.apache.commons.codec.binary.Hex;\n-import org.apache.commons.lang3.StringUtils;\n-import org.joda.time.DateTime;\n-import org.joda.time.DateTimeZone;\n-import org.joda.time.format.DateTimeFormat;\n-import org.joda.time.format.DateTimeFormatter;\n-import org.slf4j.Logger;\n-import org.slf4j.LoggerFactory;\n-\n-import com.luckycatlabs.sunrisesunset.SunriseSunsetCalculator;\n-import com.luckycatlabs.sunrisesunset.dto.Location;\n-\n-public class Helpers {\n-\n- private static final Logger LOGGER = LoggerFactory.getLogger(Helpers.class);\n- private static final String TIME_FORMAT = \"HH:mm\";\n- private static final String CET_TIMEZONE = \"Europe/Paris\";\n-\n- protected static final String XPATH_MATCHER_CORRELATIONUID = \"\\\\|\\\\|\\\\|\\\\S{17}\\\\|\\\\|\\\\|\\\\S{17}\";\n-\n- /**\n- * This shortcut makes a new Map from the given map with the given key value\n- * pair\n- *\n- * @param settings\n- * the input map\n- * @param key\n- * @param value\n- * @return an updated Map with the new key value pair\n- */\n- public static Map<String, String> addSetting(final Map<String, String> settings, final String key,\n- final String value) {\n- final Map<String, String> result = new HashMap<>();\n- result.putAll(settings);\n- result.put(key, value);\n- return result;\n- }\n-\n- /**\n- * @param settings\n- * @param key\n- * @return\n- */\n- public static Boolean getBoolean(final Map<String, String> settings, final String key) {\n- return Boolean.parseBoolean(settings.get(key));\n- }\n-\n- /**\n- * Get the boolean value of the given key in the settings. If it didn't\n- * exist return the defaultValue.\n- *\n- * @param settings\n- * The settings to get the value from.\n- * @param key\n- * The key to get the boolean from.\n- * @param defaultValue\n- * The default value if the key wasn't found.\n- * @return\n- */\n- public static Boolean getBoolean(final Map<String, String> settings, final String key, final Boolean defaultValue) {\n- if (!settings.containsKey(key)) {\n- return defaultValue;\n- }\n-\n- return getBoolean(settings, key);\n- }\n-\n- /**\n- * Get a date time object based on the settings if the key exists.\n- *\n- * @param settings\n- * The settings\n- * @param key\n- * The key in the settings for the date time.\n- * @return The date time.\n- */\n- public static DateTime getDate(final Map<String, String> settings, final String key) {\n- return getDate(settings, key, DateTime.now());\n- }\n-\n- /**\n- * Get a date time object based on the settings if the key exists.\n- *\n- * @param settings\n- * The settings\n- * @param key\n- * The key in the settings for the date time.\n- * @param defaultDate\n- * The default date to return.\n- * @return The date time.\n- */\n- public static DateTime getDate(final Map<String, String> settings, final String key, final DateTime defaultDate) {\n- if (!settings.containsKey(key)) {\n- return defaultDate;\n- }\n-\n- return DateTime.parse(settings.get(key));\n- }\n-\n- /**\n- * This is a generic method which will translate the given string to a\n- * datetime. Supported:\n- * <p>\n- * <ul>\n- * <li>now + 3 months\n- * <li>now + 1 minutes\n- * <li>tomorrow - 1 year\n- * <li>yesterday + 2 weeks\n- * <li>today at midday\n- * <li>yesterday at midnight\n- * <li>now at midday + 1 week\n- * </ul>\n- *\n- * @param dateString\n- * @return\n- * @throws Exception\n- */\n- public static DateTime getDateTime(final String dateString) throws Exception {\n-\n- DateTime retval;\n-\n- if (dateString.isEmpty()) {\n- return null;\n- }\n-\n- final String pattern = \"([a-z ]*)[ ]*([+-]?)[ ]*([0-9]*)[ ]*([a-z]*)\";\n- final Pattern r = Pattern.compile(pattern);\n- final Matcher m = r.matcher(dateString);\n-\n- if (m.groupCount() > 4) {\n- throw new Exception(\"Incorrect dateString [\" + dateString + \"]\");\n- }\n-\n- m.find();\n-\n- final String when = m.group(1).toLowerCase();\n- final String op = m.group(2);\n- final String offset = m.group(3);\n- final String what = m.group(4);\n-\n- Integer numberToAddOrSubstract = 0;\n- if (!offset.isEmpty()) {\n- numberToAddOrSubstract = Integer.parseInt(offset);\n- }\n-\n- final String whenPattern = \"([a-z]*)[ ]*([a-z]*)[ ]*([a-z]*)?\";\n- final Matcher whenMatcher = Pattern.compile(whenPattern).matcher(when);\n- whenMatcher.find();\n- switch (whenMatcher.group(1)) {\n- case \"tomorrow\":\n- retval = DateTime.now().plusDays(1);\n- break;\n- case \"yesterday\":\n- retval = DateTime.now().minusDays(1);\n- break;\n- case \"now\":\n- case \"today\":\n- retval = DateTime.now();\n- break;\n- default:\n- throw new Exception(\"Incorrect dateString [\" + dateString\n- + \"], expected the string to begin with tomorrow, yesterday or now or today\");\n- }\n-\n- // Normalize the seconds and milliseconds to zero\n- retval = retval.withSecondOfMinute(0);\n- retval = retval.withMillisOfSecond(0);\n-\n- if (whenMatcher.groupCount() > 1 && whenMatcher.group(2).equals(\"at\")) {\n-\n- switch (whenMatcher.group(3)) {\n- case \"midday\":\n- retval = retval.withHourOfDay(12);\n- break;\n- case \"midnight\":\n- retval = retval.withHourOfDay(0);\n- break;\n- default:\n- throw new Exception(\"Incorrect dateString [\" + dateString + \"], expected \\\"midday\\\" or \\\"midnight\\\"\");\n- }\n- retval = retval.withMinuteOfHour(0);\n- retval = retval.withSecondOfMinute(0);\n- }\n-\n- if (op.equals(\"+\")) {\n- switch (what) {\n- case \"days\":\n- retval = retval.plusDays(numberToAddOrSubstract);\n- break;\n- case \"minutes\":\n- retval = retval.plusMinutes(numberToAddOrSubstract);\n- break;\n- case \"hours\":\n- retval = retval.plusHours(numberToAddOrSubstract);\n- break;\n- case \"weeks\":\n- retval = retval.plusWeeks(numberToAddOrSubstract);\n- break;\n- case \"months\":\n- retval = retval.plusMonths(numberToAddOrSubstract);\n- break;\n- case \"years\":\n- retval = retval.plusYears(numberToAddOrSubstract);\n- break;\n- }\n- } else {\n- switch (what) {\n- case \"days\":\n- retval = retval.minusDays(numberToAddOrSubstract);\n- break;\n- case \"hours\":\n- retval = retval.minusHours(numberToAddOrSubstract);\n- break;\n- case \"minutes\":\n- retval = retval.minusMinutes(numberToAddOrSubstract);\n- break;\n- case \"weeks\":\n- retval = retval.minusWeeks(numberToAddOrSubstract);\n- break;\n- case \"months\":\n- retval = retval.minusMonths(numberToAddOrSubstract);\n- break;\n- case \"years\":\n- retval = retval.minusYears(numberToAddOrSubstract);\n- break;\n- }\n- }\n-\n- return retval;\n- }\n-\n- /**\n- *\n- * @param startDate\n- * @param defaultStartDate\n- * @return\n- * @throws Exception\n- */\n- public static DateTime getDateTime2(final String startDate, final DateTime defaultStartDate) throws Exception {\n- if (startDate == null) {\n- return defaultStartDate;\n- }\n- final DateTime dateTime = getDateTime(startDate);\n- if (dateTime == null) {\n- return defaultStartDate;\n- }\n- return dateTime;\n- }\n-\n- /**\n- * Get time of sunrise/sunset\n- *\n- * @param actionTimeType\n- * @param date\n- * @param location\n- * @return DateTime\n- * @throws Exception\n- */\n- public static DateTime getSunriseSunsetTime(final String actionTimeType, final DateTime date,\n- final Location location) {\n- final SunriseSunsetCalculator calculator = new SunriseSunsetCalculator(location, \"UTC\");\n-\n- Calendar officialTransition = null;\n-\n- final Calendar calender = Calendar.getInstance();\n-\n- if (actionTimeType.equalsIgnoreCase(\"SUNSET\")) {\n- calender.setTime(date.toDate());\n- officialTransition = calculator.getOfficialSunsetCalendarForDate(calender);\n- } else if (actionTimeType.equalsIgnoreCase(\"SUNRISE\")) {\n- calender.setTime(date.plusDays(1).toDate());\n- officialTransition = calculator.getOfficialSunriseCalendarForDate(calender);\n- }\n-\n- if (officialTransition == null) {\n- return null;\n- }\n-\n- return new DateTime(officialTransition.getTimeInMillis());\n- }\n-\n- /**\n- * Shifts a time to from the system's timezone to CET. It assumes the time\n- * is for the current date.\n- *\n- * @param time\n- * Time in system's timezone, formatted as HH:mm\n- * @return Time in CET, formatted as HH:mm\n- */\n- public static String shiftSystemZoneToCET(final String time) {\n- return Helpers.shiftTimeToOtherZone(time, true);\n- }\n-\n- /**\n- * Shifts a time to from CET to the system's timezone. It assumes the time\n- * is for the current date.\n- *\n- * @param time\n- * Time in system's timezone, formatted as HH:mm\n- * @return Time in CET, formatted as HH:mm\n- */\n- public static String shiftCETToSystemZone(final String time) {\n- return Helpers.shiftTimeToOtherZone(time, false);\n- }\n-\n- /**\n- * Shifts a time to another timezone. It assumes the time is for the current\n- * date.\n- *\n- * @param time\n- * Time in original timezone, formatted as HH:mm\n- * @param positiveShift\n- * Indicates if a positive or negative shift should be done\n- * @return Shifted time, formatted as HH:mm\n- */\n- private static String shiftTimeToOtherZone(final String time, final boolean positiveShift) {\n- // Extract hours and minutes from the time parameter\n- final DateTimeFormatter timeFormatter = DateTimeFormat.forPattern(TIME_FORMAT);\n- final DateTime parsedTime = timeFormatter.parseDateTime(time);\n-\n- // Determine current CET offset in hours for the system timezone.\n- final int UTCOffsetForCET = DateTimeZone.forID(CET_TIMEZONE).getOffset(new DateTime());\n- final int UTCOffsetForSystem = DateTimeZone.getDefault().getOffset(new DateTime());\n- final int offsetHours = (UTCOffsetForCET - UTCOffsetForSystem) / (3600 * 1000) * (positiveShift ? 1 : -1);\n-\n- // Add offset\n- final DateTime shiftedTime = new DateTime()\n- .withTime(parsedTime.getHourOfDay(), parsedTime.getMinuteOfHour(), 0, 0).plusHours(offsetHours);\n-\n- return timeFormatter.print(shiftedTime);\n- }\n-\n- public static Location getCurrentLocationByLatitudeAndLongitude(final double latitude, final double longitude) {","path":"cucumber-tests-core/src/test/java/com/alliander/osgp/cucumber/core/Helpers.java","position":349,"original_position":349,"commit_id":"71b3605b7ff35522ece3dce408b1d494b0dba358","original_commit_id":"71b3605b7ff35522ece3dce408b1d494b0dba358","user":{"login":"robindenadel","id":15684772,"avatar_url":"https://avatars2.githubusercontent.com/u/15684772?v=4","gravatar_id":"","url":"https://api.github.com/users/robindenadel","html_url":"https://github.com/robindenadel","followers_url":"https://api.github.com/users/robindenadel/followers","following_url":"https://api.github.com/users/robindenadel/following{/other_user}","gists_url":"https://api.github.com/users/robindenadel/gists{/gist_id}","starred_url":"https://api.github.com/users/robindenadel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robindenadel/subscriptions","organizations_url":"https://api.github.com/users/robindenadel/orgs","repos_url":"https://api.github.com/users/robindenadel/repos","events_url":"https://api.github.com/users/robindenadel/events{/privacy}","received_events_url":"https://api.github.com/users/robindenadel/received_events","type":"User","site_admin":false},"body":"Created a pull request for webapps (https://github.com/SmartSocietyServices/Webapps/pull/1205)","created_at":"2018-02-02T15:17:07Z","updated_at":"2018-02-02T15:17:07Z","html_url":"https://github.com/OSGP/Integration-Tests/pull/386#discussion_r165671395","pull_request_url":"https://api.github.com/repos/OSGP/Integration-Tests/pulls/386","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/OSGP/Integration-Tests/pulls/comments/165671395"},"html":{"href":"https://github.com/OSGP/Integration-Tests/pull/386#discussion_r165671395"},"pull_request":{"href":"https://api.github.com/repos/OSGP/Integration-Tests/pulls/386"}},"in_reply_to_id":165650588},"pull_request":{"url":"https://api.github.com/repos/OSGP/Integration-Tests/pulls/386","id":166757481,"html_url":"https://github.com/OSGP/Integration-Tests/pull/386","diff_url":"https://github.com/OSGP/Integration-Tests/pull/386.diff","patch_url":"https://github.com/OSGP/Integration-Tests/pull/386.patch","issue_url":"https://api.github.com/repos/OSGP/Integration-Tests/issues/386","number":386,"state":"open","locked":false,"title":"SLIM-753: Refactor Helpers","user":{"login":"robindenadel","id":15684772,"avatar_url":"https://avatars2.githubusercontent.com/u/15684772?v=4","gravatar_id":"","url":"https://api.github.com/users/robindenadel","html_url":"https://github.com/robindenadel","followers_url":"https://api.github.com/users/robindenadel/followers","following_url":"https://api.github.com/users/robindenadel/following{/other_user}","gists_url":"https://api.github.com/users/robindenadel/gists{/gist_id}","starred_url":"https://api.github.com/users/robindenadel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robindenadel/subscriptions","organizations_url":"https://api.github.com/users/robindenadel/orgs","repos_url":"https://api.github.com/users/robindenadel/repos","events_url":"https://api.github.com/users/robindenadel/events{/privacy}","received_events_url":"https://api.github.com/users/robindenadel/received_events","type":"User","site_admin":false},"body":"Splits up Helpers classes into classes with a certain purpose.\r\nSame is done for the RepositoryHelper class.","created_at":"2018-02-02T09:45:47Z","updated_at":"2018-02-02T15:17:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"10c85cc057f68feb12f0b248e3fdf17e9da0efe9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/OSGP/Integration-Tests/pulls/386/commits","review_comments_url":"https://api.github.com/repos/OSGP/Integration-Tests/pulls/386/comments","review_comment_url":"https://api.github.com/repos/OSGP/Integration-Tests/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OSGP/Integration-Tests/issues/386/comments","statuses_url":"https://api.github.com/repos/OSGP/Integration-Tests/statuses/71b3605b7ff35522ece3dce408b1d494b0dba358","head":{"label":"OSGP:SLIM-753_Refactor_Helpers_And_RepositoryHelper","ref":"SLIM-753_Refactor_Helpers_And_RepositoryHelper","sha":"71b3605b7ff35522ece3dce408b1d494b0dba358","user":{"login":"OSGP","id":11352045,"avatar_url":"https://avatars0.githubusercontent.com/u/11352045?v=4","gravatar_id":"","url":"https://api.github.com/users/OSGP","html_url":"https://github.com/OSGP","followers_url":"https://api.github.com/users/OSGP/followers","following_url":"https://api.github.com/users/OSGP/following{/other_user}","gists_url":"https://api.github.com/users/OSGP/gists{/gist_id}","starred_url":"https://api.github.com/users/OSGP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OSGP/subscriptions","organizations_url":"https://api.github.com/users/OSGP/orgs","repos_url":"https://api.github.com/users/OSGP/repos","events_url":"https://api.github.com/users/OSGP/events{/privacy}","received_events_url":"https://api.github.com/users/OSGP/received_events","type":"Organization","site_admin":false},"repo":{"id":32994878,"name":"Integration-Tests","full_name":"OSGP/Integration-Tests","owner":{"login":"OSGP","id":11352045,"avatar_url":"https://avatars0.githubusercontent.com/u/11352045?v=4","gravatar_id":"","url":"https://api.github.com/users/OSGP","html_url":"https://github.com/OSGP","followers_url":"https://api.github.com/users/OSGP/followers","following_url":"https://api.github.com/users/OSGP/following{/other_user}","gists_url":"https://api.github.com/users/OSGP/gists{/gist_id}","starred_url":"https://api.github.com/users/OSGP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OSGP/subscriptions","organizations_url":"https://api.github.com/users/OSGP/orgs","repos_url":"https://api.github.com/users/OSGP/repos","events_url":"https://api.github.com/users/OSGP/events{/privacy}","received_events_url":"https://api.github.com/users/OSGP/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OSGP/Integration-Tests","description":"Continuous integration tests for OSGP","fork":false,"url":"https://api.github.com/repos/OSGP/Integration-Tests","forks_url":"https://api.github.com/repos/OSGP/Integration-Tests/forks","keys_url":"https://api.github.com/repos/OSGP/Integration-Tests/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OSGP/Integration-Tests/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OSGP/Integration-Tests/teams","hooks_url":"https://api.github.com/repos/OSGP/Integration-Tests/hooks","issue_events_url":"https://api.github.com/repos/OSGP/Integration-Tests/issues/events{/number}","events_url":"https://api.github.com/repos/OSGP/Integration-Tests/events","assignees_url":"https://api.github.com/repos/OSGP/Integration-Tests/assignees{/user}","branches_url":"https://api.github.com/repos/OSGP/Integration-Tests/branches{/branch}","tags_url":"https://api.github.com/repos/OSGP/Integration-Tests/tags","blobs_url":"https://api.github.com/repos/OSGP/Integration-Tests/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OSGP/Integration-Tests/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OSGP/Integration-Tests/git/refs{/sha}","trees_url":"https://api.github.com/repos/OSGP/Integration-Tests/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OSGP/Integration-Tests/statuses/{sha}","languages_url":"https://api.github.com/repos/OSGP/Integration-Tests/languages","stargazers_url":"https://api.github.com/repos/OSGP/Integration-Tests/stargazers","contributors_url":"https://api.github.com/repos/OSGP/Integration-Tests/contributors","subscribers_url":"https://api.github.com/repos/OSGP/Integration-Tests/subscribers","subscription_url":"https://api.github.com/repos/OSGP/Integration-Tests/subscription","commits_url":"https://api.github.com/repos/OSGP/Integration-Tests/commits{/sha}","git_commits_url":"https://api.github.com/repos/OSGP/Integration-Tests/git/commits{/sha}","comments_url":"https://api.github.com/repos/OSGP/Integration-Tests/comments{/number}","issue_comment_url":"https://api.github.com/repos/OSGP/Integration-Tests/issues/comments{/number}","contents_url":"https://api.github.com/repos/OSGP/Integration-Tests/contents/{+path}","compare_url":"https://api.github.com/repos/OSGP/Integration-Tests/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OSGP/Integration-Tests/merges","archive_url":"https://api.github.com/repos/OSGP/Integration-Tests/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OSGP/Integration-Tests/downloads","issues_url":"https://api.github.com/repos/OSGP/Integration-Tests/issues{/number}","pulls_url":"https://api.github.com/repos/OSGP/Integration-Tests/pulls{/number}","milestones_url":"https://api.github.com/repos/OSGP/Integration-Tests/milestones{/number}","notifications_url":"https://api.github.com/repos/OSGP/Integration-Tests/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OSGP/Integration-Tests/labels{/name}","releases_url":"https://api.github.com/repos/OSGP/Integration-Tests/releases{/id}","deployments_url":"https://api.github.com/repos/OSGP/Integration-Tests/deployments","created_at":"2015-03-27T15:47:30Z","updated_at":"2017-04-14T14:40:55Z","pushed_at":"2018-02-02T14:40:13Z","git_url":"git://github.com/OSGP/Integration-Tests.git","ssh_url":"[email protected]:OSGP/Integration-Tests.git","clone_url":"https://github.com/OSGP/Integration-Tests.git","svn_url":"https://github.com/OSGP/Integration-Tests","homepage":"http://www.opensmartgridplatform.org/","size":40495,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":2,"open_issues":5,"watchers":1,"default_branch":"development"}},"base":{"label":"OSGP:development","ref":"development","sha":"b1a6d07d2891ce955375edc4f12a12bc394f95b8","user":{"login":"OSGP","id":11352045,"avatar_url":"https://avatars0.githubusercontent.com/u/11352045?v=4","gravatar_id":"","url":"https://api.github.com/users/OSGP","html_url":"https://github.com/OSGP","followers_url":"https://api.github.com/users/OSGP/followers","following_url":"https://api.github.com/users/OSGP/following{/other_user}","gists_url":"https://api.github.com/users/OSGP/gists{/gist_id}","starred_url":"https://api.github.com/users/OSGP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OSGP/subscriptions","organizations_url":"https://api.github.com/users/OSGP/orgs","repos_url":"https://api.github.com/users/OSGP/repos","events_url":"https://api.github.com/users/OSGP/events{/privacy}","received_events_url":"https://api.github.com/users/OSGP/received_events","type":"Organization","site_admin":false},"repo":{"id":32994878,"name":"Integration-Tests","full_name":"OSGP/Integration-Tests","owner":{"login":"OSGP","id":11352045,"avatar_url":"https://avatars0.githubusercontent.com/u/11352045?v=4","gravatar_id":"","url":"https://api.github.com/users/OSGP","html_url":"https://github.com/OSGP","followers_url":"https://api.github.com/users/OSGP/followers","following_url":"https://api.github.com/users/OSGP/following{/other_user}","gists_url":"https://api.github.com/users/OSGP/gists{/gist_id}","starred_url":"https://api.github.com/users/OSGP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OSGP/subscriptions","organizations_url":"https://api.github.com/users/OSGP/orgs","repos_url":"https://api.github.com/users/OSGP/repos","events_url":"https://api.github.com/users/OSGP/events{/privacy}","received_events_url":"https://api.github.com/users/OSGP/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OSGP/Integration-Tests","description":"Continuous integration tests for OSGP","fork":false,"url":"https://api.github.com/repos/OSGP/Integration-Tests","forks_url":"https://api.github.com/repos/OSGP/Integration-Tests/forks","keys_url":"https://api.github.com/repos/OSGP/Integration-Tests/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OSGP/Integration-Tests/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OSGP/Integration-Tests/teams","hooks_url":"https://api.github.com/repos/OSGP/Integration-Tests/hooks","issue_events_url":"https://api.github.com/repos/OSGP/Integration-Tests/issues/events{/number}","events_url":"https://api.github.com/repos/OSGP/Integration-Tests/events","assignees_url":"https://api.github.com/repos/OSGP/Integration-Tests/assignees{/user}","branches_url":"https://api.github.com/repos/OSGP/Integration-Tests/branches{/branch}","tags_url":"https://api.github.com/repos/OSGP/Integration-Tests/tags","blobs_url":"https://api.github.com/repos/OSGP/Integration-Tests/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OSGP/Integration-Tests/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OSGP/Integration-Tests/git/refs{/sha}","trees_url":"https://api.github.com/repos/OSGP/Integration-Tests/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OSGP/Integration-Tests/statuses/{sha}","languages_url":"https://api.github.com/repos/OSGP/Integration-Tests/languages","stargazers_url":"https://api.github.com/repos/OSGP/Integration-Tests/stargazers","contributors_url":"https://api.github.com/repos/OSGP/Integration-Tests/contributors","subscribers_url":"https://api.github.com/repos/OSGP/Integration-Tests/subscribers","subscription_url":"https://api.github.com/repos/OSGP/Integration-Tests/subscription","commits_url":"https://api.github.com/repos/OSGP/Integration-Tests/commits{/sha}","git_commits_url":"https://api.github.com/repos/OSGP/Integration-Tests/git/commits{/sha}","comments_url":"https://api.github.com/repos/OSGP/Integration-Tests/comments{/number}","issue_comment_url":"https://api.github.com/repos/OSGP/Integration-Tests/issues/comments{/number}","contents_url":"https://api.github.com/repos/OSGP/Integration-Tests/contents/{+path}","compare_url":"https://api.github.com/repos/OSGP/Integration-Tests/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OSGP/Integration-Tests/merges","archive_url":"https://api.github.com/repos/OSGP/Integration-Tests/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OSGP/Integration-Tests/downloads","issues_url":"https://api.github.com/repos/OSGP/Integration-Tests/issues{/number}","pulls_url":"https://api.github.com/repos/OSGP/Integration-Tests/pulls{/number}","milestones_url":"https://api.github.com/repos/OSGP/Integration-Tests/milestones{/number}","notifications_url":"https://api.github.com/repos/OSGP/Integration-Tests/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OSGP/Integration-Tests/labels{/name}","releases_url":"https://api.github.com/repos/OSGP/Integration-Tests/releases{/id}","deployments_url":"https://api.github.com/repos/OSGP/Integration-Tests/deployments","created_at":"2015-03-27T15:47:30Z","updated_at":"2017-04-14T14:40:55Z","pushed_at":"2018-02-02T14:40:13Z","git_url":"git://github.com/OSGP/Integration-Tests.git","ssh_url":"[email protected]:OSGP/Integration-Tests.git","clone_url":"https://github.com/OSGP/Integration-Tests.git","svn_url":"https://github.com/OSGP/Integration-Tests","homepage":"http://www.opensmartgridplatform.org/","size":40495,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":2,"open_issues":5,"watchers":1,"default_branch":"development"}},"_links":{"self":{"href":"https://api.github.com/repos/OSGP/Integration-Tests/pulls/386"},"html":{"href":"https://github.com/OSGP/Integration-Tests/pull/386"},"issue":{"href":"https://api.github.com/repos/OSGP/Integration-Tests/issues/386"},"comments":{"href":"https://api.github.com/repos/OSGP/Integration-Tests/issues/386/comments"},"review_comments":{"href":"https://api.github.com/repos/OSGP/Integration-Tests/pulls/386/comments"},"review_comment":{"href":"https://api.github.com/repos/OSGP/Integration-Tests/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OSGP/Integration-Tests/pulls/386/commits"},"statuses":{"href":"https://api.github.com/repos/OSGP/Integration-Tests/statuses/71b3605b7ff35522ece3dce408b1d494b0dba358"}},"author_association":"MEMBER"}} | {
"id": 32994878,
"name": "OSGP/Integration-Tests",
"url": "https://api.github.com/repos/OSGP/Integration-Tests"
} | {
"id": 15684772,
"login": "robindenadel",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/15684772?",
"url": "https://api.github.com/users/robindenadel"
} | {
"id": 11352045,
"login": "OSGP",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/11352045?",
"url": "https://api.github.com/orgs/OSGP"
} | 2018-02-02T15:17:07 | 7189818060 | {"actor":{"display_login":"robindenadel"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/acemod/ACE3/pulls/comments/169872998","pull_request_review_id":98468128,"id":169872998,"diff_hunk":"@@ -0,0 +1,34 @@\n+#include \"stdafx.h\"\n+#include \"windows.h\"\n+#include \"string.h\"\n+#include <stdlib.h>\n+\n+extern \"C\" {\n+ __declspec (dllexport) void __stdcall RVExtension(char *output, int outputSize, const char *function);\n+}\n+\n+void __stdcall RVExtension(char *output, int outputSize, const char *function) {\n+ INPUT ip;\n+ ip.type = INPUT_MOUSE;\n+ ip.mi.mouseData = 0;\n+ ip.mi.dwFlags = MOUSEEVENTF_MOVE;\n+ ip.mi.time = 0;\n+\n+ int x, y;\n+ if (strncmp(function, \"x\", 1)) {\n+ ip.mi.dx = atoi(&function[1]);\n+ ip.mi.dy = 0;\n+ }\n+ else if (strncmp(function, \"y\", 1)) {\n+ ip.mi.dy = atoi(&function[1]);\n+ ip.mi.dx = 0;\n+ }\n+ else {","path":"extensions/cursor_movement/cursorMovement.cpp","position":26,"original_position":26,"commit_id":"191f8cf0534f8608749c2e9ce58980ea1a019009","original_commit_id":"191f8cf0534f8608749c2e9ce58980ea1a019009","user":{"login":"dedmen","id":3768165,"avatar_url":"https://avatars1.githubusercontent.com/u/3768165?v=4","gravatar_id":"","url":"https://api.github.com/users/dedmen","html_url":"https://github.com/dedmen","followers_url":"https://api.github.com/users/dedmen/followers","following_url":"https://api.github.com/users/dedmen/following{/other_user}","gists_url":"https://api.github.com/users/dedmen/gists{/gist_id}","starred_url":"https://api.github.com/users/dedmen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dedmen/subscriptions","organizations_url":"https://api.github.com/users/dedmen/orgs","repos_url":"https://api.github.com/users/dedmen/repos","events_url":"https://api.github.com/users/dedmen/events{/privacy}","received_events_url":"https://api.github.com/users/dedmen/received_events","type":"User","site_admin":false},"body":"All other extensions use `} else {` else on same line.","created_at":"2018-02-22T07:31:49Z","updated_at":"2018-02-22T07:31:49Z","html_url":"https://github.com/acemod/ACE3/pull/6162#discussion_r169872998","pull_request_url":"https://api.github.com/repos/acemod/ACE3/pulls/6162","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/acemod/ACE3/pulls/comments/169872998"},"html":{"href":"https://github.com/acemod/ACE3/pull/6162#discussion_r169872998"},"pull_request":{"href":"https://api.github.com/repos/acemod/ACE3/pulls/6162"}}},"pull_request":{"url":"https://api.github.com/repos/acemod/ACE3/pulls/6162","id":170652313,"html_url":"https://github.com/acemod/ACE3/pull/6162","diff_url":"https://github.com/acemod/ACE3/pull/6162.diff","patch_url":"https://github.com/acemod/ACE3/pull/6162.patch","issue_url":"https://api.github.com/repos/acemod/ACE3/issues/6162","number":6162,"state":"open","locked":false,"title":"Adds cursor movement.","user":{"login":"LorenLuke","id":6456096,"avatar_url":"https://avatars2.githubusercontent.com/u/6456096?v=4","gravatar_id":"","url":"https://api.github.com/users/LorenLuke","html_url":"https://github.com/LorenLuke","followers_url":"https://api.github.com/users/LorenLuke/followers","following_url":"https://api.github.com/users/LorenLuke/following{/other_user}","gists_url":"https://api.github.com/users/LorenLuke/gists{/gist_id}","starred_url":"https://api.github.com/users/LorenLuke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LorenLuke/subscriptions","organizations_url":"https://api.github.com/users/LorenLuke/orgs","repos_url":"https://api.github.com/users/LorenLuke/repos","events_url":"https://api.github.com/users/LorenLuke/events{/privacy}","received_events_url":"https://api.github.com/users/LorenLuke/received_events","type":"User","site_admin":false},"body":"**When merged this pull request will:**\r\n- Add extensions capable of mimicking player mouse input.\r\n- Adds a function to 'common' to call the extension easily.\r\n\r\nNotes:\r\n- Cursor movement in loops persists in dialog and pause menu.\r\nBe sure to have safeguards in place before using in loops.","created_at":"2018-02-22T04:06:30Z","updated_at":"2018-02-22T07:31:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2baa2ab0fd4c7348d9341bf543798dedca37f312","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/acemod/ACE3/pulls/6162/commits","review_comments_url":"https://api.github.com/repos/acemod/ACE3/pulls/6162/comments","review_comment_url":"https://api.github.com/repos/acemod/ACE3/pulls/comments{/number}","comments_url":"https://api.github.com/repos/acemod/ACE3/issues/6162/comments","statuses_url":"https://api.github.com/repos/acemod/ACE3/statuses/191f8cf0534f8608749c2e9ce58980ea1a019009","head":{"label":"LorenLuke:Cursor-Movement","ref":"Cursor-Movement","sha":"191f8cf0534f8608749c2e9ce58980ea1a019009","user":{"login":"LorenLuke","id":6456096,"avatar_url":"https://avatars2.githubusercontent.com/u/6456096?v=4","gravatar_id":"","url":"https://api.github.com/users/LorenLuke","html_url":"https://github.com/LorenLuke","followers_url":"https://api.github.com/users/LorenLuke/followers","following_url":"https://api.github.com/users/LorenLuke/following{/other_user}","gists_url":"https://api.github.com/users/LorenLuke/gists{/gist_id}","starred_url":"https://api.github.com/users/LorenLuke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LorenLuke/subscriptions","organizations_url":"https://api.github.com/users/LorenLuke/orgs","repos_url":"https://api.github.com/users/LorenLuke/repos","events_url":"https://api.github.com/users/LorenLuke/events{/privacy}","received_events_url":"https://api.github.com/users/LorenLuke/received_events","type":"User","site_admin":false},"repo":{"id":35397459,"name":"ACE3","full_name":"LorenLuke/ACE3","owner":{"login":"LorenLuke","id":6456096,"avatar_url":"https://avatars2.githubusercontent.com/u/6456096?v=4","gravatar_id":"","url":"https://api.github.com/users/LorenLuke","html_url":"https://github.com/LorenLuke","followers_url":"https://api.github.com/users/LorenLuke/followers","following_url":"https://api.github.com/users/LorenLuke/following{/other_user}","gists_url":"https://api.github.com/users/LorenLuke/gists{/gist_id}","starred_url":"https://api.github.com/users/LorenLuke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LorenLuke/subscriptions","organizations_url":"https://api.github.com/users/LorenLuke/orgs","repos_url":"https://api.github.com/users/LorenLuke/repos","events_url":"https://api.github.com/users/LorenLuke/events{/privacy}","received_events_url":"https://api.github.com/users/LorenLuke/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/LorenLuke/ACE3","description":"Open-source realism mod for Arma 3","fork":true,"url":"https://api.github.com/repos/LorenLuke/ACE3","forks_url":"https://api.github.com/repos/LorenLuke/ACE3/forks","keys_url":"https://api.github.com/repos/LorenLuke/ACE3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LorenLuke/ACE3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LorenLuke/ACE3/teams","hooks_url":"https://api.github.com/repos/LorenLuke/ACE3/hooks","issue_events_url":"https://api.github.com/repos/LorenLuke/ACE3/issues/events{/number}","events_url":"https://api.github.com/repos/LorenLuke/ACE3/events","assignees_url":"https://api.github.com/repos/LorenLuke/ACE3/assignees{/user}","branches_url":"https://api.github.com/repos/LorenLuke/ACE3/branches{/branch}","tags_url":"https://api.github.com/repos/LorenLuke/ACE3/tags","blobs_url":"https://api.github.com/repos/LorenLuke/ACE3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LorenLuke/ACE3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LorenLuke/ACE3/git/refs{/sha}","trees_url":"https://api.github.com/repos/LorenLuke/ACE3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LorenLuke/ACE3/statuses/{sha}","languages_url":"https://api.github.com/repos/LorenLuke/ACE3/languages","stargazers_url":"https://api.github.com/repos/LorenLuke/ACE3/stargazers","contributors_url":"https://api.github.com/repos/LorenLuke/ACE3/contributors","subscribers_url":"https://api.github.com/repos/LorenLuke/ACE3/subscribers","subscription_url":"https://api.github.com/repos/LorenLuke/ACE3/subscription","commits_url":"https://api.github.com/repos/LorenLuke/ACE3/commits{/sha}","git_commits_url":"https://api.github.com/repos/LorenLuke/ACE3/git/commits{/sha}","comments_url":"https://api.github.com/repos/LorenLuke/ACE3/comments{/number}","issue_comment_url":"https://api.github.com/repos/LorenLuke/ACE3/issues/comments{/number}","contents_url":"https://api.github.com/repos/LorenLuke/ACE3/contents/{+path}","compare_url":"https://api.github.com/repos/LorenLuke/ACE3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LorenLuke/ACE3/merges","archive_url":"https://api.github.com/repos/LorenLuke/ACE3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LorenLuke/ACE3/downloads","issues_url":"https://api.github.com/repos/LorenLuke/ACE3/issues{/number}","pulls_url":"https://api.github.com/repos/LorenLuke/ACE3/pulls{/number}","milestones_url":"https://api.github.com/repos/LorenLuke/ACE3/milestones{/number}","notifications_url":"https://api.github.com/repos/LorenLuke/ACE3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LorenLuke/ACE3/labels{/name}","releases_url":"https://api.github.com/repos/LorenLuke/ACE3/releases{/id}","deployments_url":"https://api.github.com/repos/LorenLuke/ACE3/deployments","created_at":"2015-05-11T02:22:20Z","updated_at":"2015-05-15T03:04:11Z","pushed_at":"2018-02-22T04:45:13Z","git_url":"git://github.com/LorenLuke/ACE3.git","ssh_url":"[email protected]:LorenLuke/ACE3.git","clone_url":"https://github.com/LorenLuke/ACE3.git","svn_url":"https://github.com/LorenLuke/ACE3","homepage":"http://ace3mod.com/","size":354796,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"acemod:master","ref":"master","sha":"1835ccebb897e263b6de29945ebed3f617b006ea","user":{"login":"acemod","id":11369030,"avatar_url":"https://avatars3.githubusercontent.com/u/11369030?v=4","gravatar_id":"","url":"https://api.github.com/users/acemod","html_url":"https://github.com/acemod","followers_url":"https://api.github.com/users/acemod/followers","following_url":"https://api.github.com/users/acemod/following{/other_user}","gists_url":"https://api.github.com/users/acemod/gists{/gist_id}","starred_url":"https://api.github.com/users/acemod/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acemod/subscriptions","organizations_url":"https://api.github.com/users/acemod/orgs","repos_url":"https://api.github.com/users/acemod/repos","events_url":"https://api.github.com/users/acemod/events{/privacy}","received_events_url":"https://api.github.com/users/acemod/received_events","type":"Organization","site_admin":false},"repo":{"id":29069174,"name":"ACE3","full_name":"acemod/ACE3","owner":{"login":"acemod","id":11369030,"avatar_url":"https://avatars3.githubusercontent.com/u/11369030?v=4","gravatar_id":"","url":"https://api.github.com/users/acemod","html_url":"https://github.com/acemod","followers_url":"https://api.github.com/users/acemod/followers","following_url":"https://api.github.com/users/acemod/following{/other_user}","gists_url":"https://api.github.com/users/acemod/gists{/gist_id}","starred_url":"https://api.github.com/users/acemod/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acemod/subscriptions","organizations_url":"https://api.github.com/users/acemod/orgs","repos_url":"https://api.github.com/users/acemod/repos","events_url":"https://api.github.com/users/acemod/events{/privacy}","received_events_url":"https://api.github.com/users/acemod/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/acemod/ACE3","description":"Open-source realism mod for Arma 3","fork":false,"url":"https://api.github.com/repos/acemod/ACE3","forks_url":"https://api.github.com/repos/acemod/ACE3/forks","keys_url":"https://api.github.com/repos/acemod/ACE3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/acemod/ACE3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/acemod/ACE3/teams","hooks_url":"https://api.github.com/repos/acemod/ACE3/hooks","issue_events_url":"https://api.github.com/repos/acemod/ACE3/issues/events{/number}","events_url":"https://api.github.com/repos/acemod/ACE3/events","assignees_url":"https://api.github.com/repos/acemod/ACE3/assignees{/user}","branches_url":"https://api.github.com/repos/acemod/ACE3/branches{/branch}","tags_url":"https://api.github.com/repos/acemod/ACE3/tags","blobs_url":"https://api.github.com/repos/acemod/ACE3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/acemod/ACE3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/acemod/ACE3/git/refs{/sha}","trees_url":"https://api.github.com/repos/acemod/ACE3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/acemod/ACE3/statuses/{sha}","languages_url":"https://api.github.com/repos/acemod/ACE3/languages","stargazers_url":"https://api.github.com/repos/acemod/ACE3/stargazers","contributors_url":"https://api.github.com/repos/acemod/ACE3/contributors","subscribers_url":"https://api.github.com/repos/acemod/ACE3/subscribers","subscription_url":"https://api.github.com/repos/acemod/ACE3/subscription","commits_url":"https://api.github.com/repos/acemod/ACE3/commits{/sha}","git_commits_url":"https://api.github.com/repos/acemod/ACE3/git/commits{/sha}","comments_url":"https://api.github.com/repos/acemod/ACE3/comments{/number}","issue_comment_url":"https://api.github.com/repos/acemod/ACE3/issues/comments{/number}","contents_url":"https://api.github.com/repos/acemod/ACE3/contents/{+path}","compare_url":"https://api.github.com/repos/acemod/ACE3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/acemod/ACE3/merges","archive_url":"https://api.github.com/repos/acemod/ACE3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/acemod/ACE3/downloads","issues_url":"https://api.github.com/repos/acemod/ACE3/issues{/number}","pulls_url":"https://api.github.com/repos/acemod/ACE3/pulls{/number}","milestones_url":"https://api.github.com/repos/acemod/ACE3/milestones{/number}","notifications_url":"https://api.github.com/repos/acemod/ACE3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/acemod/ACE3/labels{/name}","releases_url":"https://api.github.com/repos/acemod/ACE3/releases{/id}","deployments_url":"https://api.github.com/repos/acemod/ACE3/deployments","created_at":"2015-01-10T19:59:12Z","updated_at":"2018-02-20T21:26:02Z","pushed_at":"2018-02-22T04:45:15Z","git_url":"git://github.com/acemod/ACE3.git","ssh_url":"[email protected]:acemod/ACE3.git","clone_url":"https://github.com/acemod/ACE3.git","svn_url":"https://github.com/acemod/ACE3","homepage":"https://ace3mod.com/","size":370191,"stargazers_count":565,"watchers_count":565,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":469,"mirror_url":null,"archived":false,"open_issues_count":310,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":469,"open_issues":310,"watchers":565,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/acemod/ACE3/pulls/6162"},"html":{"href":"https://github.com/acemod/ACE3/pull/6162"},"issue":{"href":"https://api.github.com/repos/acemod/ACE3/issues/6162"},"comments":{"href":"https://api.github.com/repos/acemod/ACE3/issues/6162/comments"},"review_comments":{"href":"https://api.github.com/repos/acemod/ACE3/pulls/6162/comments"},"review_comment":{"href":"https://api.github.com/repos/acemod/ACE3/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/acemod/ACE3/pulls/6162/commits"},"statuses":{"href":"https://api.github.com/repos/acemod/ACE3/statuses/191f8cf0534f8608749c2e9ce58980ea1a019009"}},"author_association":"NONE"}} | {
"id": 29069174,
"name": "acemod/ACE3",
"url": "https://api.github.com/repos/acemod/ACE3"
} | {
"id": 3768165,
"login": "dedmen",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3768165?",
"url": "https://api.github.com/users/dedmen"
} | {
"id": 11369030,
"login": "acemod",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/11369030?",
"url": "https://api.github.com/orgs/acemod"
} | 2018-02-22T07:31:49 | 7279930560 | {"actor":{"display_login":"dedmen"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/math-comp/analysis/pulls/comments/229281478","pull_request_review_id":169740766,"id":229281478,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyOTI4MTQ3OA==","diff_hunk":"@@ -447,6 +450,47 @@ Canonical prod_pointedType (T T' : pointedType) :=\n PointedType (T * T') (point, point).\n Canonical matrix_pointedType m n (T : pointedType) :=\n PointedType 'M[T]_(m, n) (\\matrix_(_, _) point)%R.\n+Canonical zmod_pointedType (V : zmodType) := PointedType V 0%R.","path":"classical_sets.v","position":23,"original_position":23,"commit_id":"909029df85097c95307922976f6aba213ae6f397","original_commit_id":"909029df85097c95307922976f6aba213ae6f397","user":{"login":"CohenCyril","id":298705,"node_id":"MDQ6VXNlcjI5ODcwNQ==","avatar_url":"https://avatars2.githubusercontent.com/u/298705?v=4","gravatar_id":"","url":"https://api.github.com/users/CohenCyril","html_url":"https://github.com/CohenCyril","followers_url":"https://api.github.com/users/CohenCyril/followers","following_url":"https://api.github.com/users/CohenCyril/following{/other_user}","gists_url":"https://api.github.com/users/CohenCyril/gists{/gist_id}","starred_url":"https://api.github.com/users/CohenCyril/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CohenCyril/subscriptions","organizations_url":"https://api.github.com/users/CohenCyril/orgs","repos_url":"https://api.github.com/users/CohenCyril/repos","events_url":"https://api.github.com/users/CohenCyril/events{/privacy}","received_events_url":"https://api.github.com/users/CohenCyril/received_events","type":"User","site_admin":false},"body":"Having a pointed type structure over something that is stable by product (and matrix) introduces a risk of inconsistency of the `point` operator. Indeed there would be two ways of getting it: as a pointed type of a product of as the product of two pointed type.\r\nIt would be ok to start with a `realField` (or `realDomain`? even though unnecessary), because the product of two `realDomain`s cannot be a `realDomain` again.","created_at":"2018-10-30T12:14:16Z","updated_at":"2018-10-30T12:14:17Z","html_url":"https://github.com/math-comp/analysis/pull/112#discussion_r229281478","pull_request_url":"https://api.github.com/repos/math-comp/analysis/pulls/112","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/math-comp/analysis/pulls/comments/229281478"},"html":{"href":"https://github.com/math-comp/analysis/pull/112#discussion_r229281478"},"pull_request":{"href":"https://api.github.com/repos/math-comp/analysis/pulls/112"}}},"pull_request":{"url":"https://api.github.com/repos/math-comp/analysis/pulls/112","id":219959026,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5OTU5MDI2","html_url":"https://github.com/math-comp/analysis/pull/112","diff_url":"https://github.com/math-comp/analysis/pull/112.diff","patch_url":"https://github.com/math-comp/analysis/pull/112.patch","issue_url":"https://api.github.com/repos/math-comp/analysis/issues/112","number":112,"state":"open","locked":false,"title":"WIP / Experiment : Remove the dependency on R","user":{"login":"drouhling","id":7912385,"node_id":"MDQ6VXNlcjc5MTIzODU=","avatar_url":"https://avatars0.githubusercontent.com/u/7912385?v=4","gravatar_id":"","url":"https://api.github.com/users/drouhling","html_url":"https://github.com/drouhling","followers_url":"https://api.github.com/users/drouhling/followers","following_url":"https://api.github.com/users/drouhling/following{/other_user}","gists_url":"https://api.github.com/users/drouhling/gists{/gist_id}","starred_url":"https://api.github.com/users/drouhling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drouhling/subscriptions","organizations_url":"https://api.github.com/users/drouhling/orgs","repos_url":"https://api.github.com/users/drouhling/repos","events_url":"https://api.github.com/users/drouhling/events{/privacy}","received_events_url":"https://api.github.com/users/drouhling/received_events","type":"User","site_admin":false},"body":"I need feedback on this branch which:\r\n\r\n- replaces `ball` with `entourages` as primitive for the definition of `uniformType`.\r\n\r\n- removes `absRingType` and uses `numDomainType` instead (related to #4).\r\n\r\n- instantiates the hierarchy on mathcomp's algebraic structures (see `classical_sets.v` and `hierarchy.v`).\r\n\r\n- replaces `R` from standard library with any `realFieldType` / `realType` and `Rbar` with `realFieldBar`.\r\n\r\n- moves non norm-related structures to `topology.v`.\r\n\r\nUsing entourages tends to lengthen proofs. In particular, I am not very satisfied with the way `entourages_split` replaces `ball_split` but I haven't found any solution yet.\r\nIn normed spaces it is less problematic since we can still use the balls defined by the norm.\r\n\r\nThis branch only use a small part of `Rstruct.v`, and this part does not depend on `R` any more. I believe this file should move to `misc/`, be extended with the structures from our hierarchy, and come with an example file on `R` containing the compatibility lemmas from Coquelicot about `continuity_pt` and `derive_pt`.\r\n\r\nThe file `derive.v` also takes a very long time to compile. I mean more than before. I don't know why yet. In particular Coq takes a long time to go through the proof script of `diffM`. I looked at the debug script for typeclasses and it seems that Coq is stuck *after* typeclass inference finds how to close all generated subgoals.\r\n\r\nTODO-list:\r\n\r\n- [x] Generalize `ereal` and merge with `realFieldBar` (related to #3).\r\n\r\n `ereal` is now generalized to any `numDomainType` and used everywhere. The `+oo` and `-oo` notations replace `\\+inf` and `\\-inf`.\r\n I suggest to delete `Rbar.v` but first we need to finish the discussion in #3: does there remain any part of the arithmetic in `Rbar.v` we want to port to `ereal` ?\r\n\r\n- [x] Move `bigmaxr` theory out of `Rstruct.v` ? Or reimplement using `bigop`, generalizing and extending [`bigRmax` theory](https://github.com/drouhling/LaSalle/blob/a8231dfeb97c99f7dd85ac4a865c455f25b6e1db/vect.v#L80-L200) ?\r\n\r\n A theory of min/max using `bigop` is now in `hierarchy.v`. This is probably not perfect and should be extended (see discussion in #114), but it is sufficient for the purpose of this PR.\r\n\r\n- [x] Move `Rstruct.v` to `misc/` and extend it with our structures.\r\n\r\n- [x] Reintroduce commented out lemmas about `R` and `Rbar`, either translating them to `realFieldType` / `realType` / `realFieldBar` or putting them in an example file in `misc/`.\r\n\r\n- [ ] Investigate `derive.v`'s compilation issue.\r\n\r\n- [ ] Clean up.\r\n\r\n - [x] Be consistent with names (sometimes `entourages` is used, sometimes it is `entourage`).\r\n\r\n - [x] Rework the existing documentation.\r\n\r\n - [ ] Rename `hierarchy.v` (and `topology.v` ?) to reflect the new organization.\r\n\r\n - [x] Make sure each lemma is in the right file and no lemma has been dropped.","created_at":"2018-10-03T08:50:20Z","updated_at":"2018-10-30T12:14:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2a606473916b947bec2df71edc291e67ab5b1e34","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/math-comp/analysis/pulls/112/commits","review_comments_url":"https://api.github.com/repos/math-comp/analysis/pulls/112/comments","review_comment_url":"https://api.github.com/repos/math-comp/analysis/pulls/comments{/number}","comments_url":"https://api.github.com/repos/math-comp/analysis/issues/112/comments","statuses_url":"https://api.github.com/repos/math-comp/analysis/statuses/909029df85097c95307922976f6aba213ae6f397","head":{"label":"math-comp:entourages","ref":"entourages","sha":"909029df85097c95307922976f6aba213ae6f397","user":{"login":"math-comp","id":11424151,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNDI0MTUx","avatar_url":"https://avatars2.githubusercontent.com/u/11424151?v=4","gravatar_id":"","url":"https://api.github.com/users/math-comp","html_url":"https://github.com/math-comp","followers_url":"https://api.github.com/users/math-comp/followers","following_url":"https://api.github.com/users/math-comp/following{/other_user}","gists_url":"https://api.github.com/users/math-comp/gists{/gist_id}","starred_url":"https://api.github.com/users/math-comp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/math-comp/subscriptions","organizations_url":"https://api.github.com/users/math-comp/orgs","repos_url":"https://api.github.com/users/math-comp/repos","events_url":"https://api.github.com/users/math-comp/events{/privacy}","received_events_url":"https://api.github.com/users/math-comp/received_events","type":"Organization","site_admin":false},"repo":{"id":112471761,"node_id":"MDEwOlJlcG9zaXRvcnkxMTI0NzE3NjE=","name":"analysis","full_name":"math-comp/analysis","private":false,"owner":{"login":"math-comp","id":11424151,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNDI0MTUx","avatar_url":"https://avatars2.githubusercontent.com/u/11424151?v=4","gravatar_id":"","url":"https://api.github.com/users/math-comp","html_url":"https://github.com/math-comp","followers_url":"https://api.github.com/users/math-comp/followers","following_url":"https://api.github.com/users/math-comp/following{/other_user}","gists_url":"https://api.github.com/users/math-comp/gists{/gist_id}","starred_url":"https://api.github.com/users/math-comp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/math-comp/subscriptions","organizations_url":"https://api.github.com/users/math-comp/orgs","repos_url":"https://api.github.com/users/math-comp/repos","events_url":"https://api.github.com/users/math-comp/events{/privacy}","received_events_url":"https://api.github.com/users/math-comp/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/math-comp/analysis","description":"Mathematical Components compliant Analysis Library","fork":false,"url":"https://api.github.com/repos/math-comp/analysis","forks_url":"https://api.github.com/repos/math-comp/analysis/forks","keys_url":"https://api.github.com/repos/math-comp/analysis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/math-comp/analysis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/math-comp/analysis/teams","hooks_url":"https://api.github.com/repos/math-comp/analysis/hooks","issue_events_url":"https://api.github.com/repos/math-comp/analysis/issues/events{/number}","events_url":"https://api.github.com/repos/math-comp/analysis/events","assignees_url":"https://api.github.com/repos/math-comp/analysis/assignees{/user}","branches_url":"https://api.github.com/repos/math-comp/analysis/branches{/branch}","tags_url":"https://api.github.com/repos/math-comp/analysis/tags","blobs_url":"https://api.github.com/repos/math-comp/analysis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/math-comp/analysis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/math-comp/analysis/git/refs{/sha}","trees_url":"https://api.github.com/repos/math-comp/analysis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/math-comp/analysis/statuses/{sha}","languages_url":"https://api.github.com/repos/math-comp/analysis/languages","stargazers_url":"https://api.github.com/repos/math-comp/analysis/stargazers","contributors_url":"https://api.github.com/repos/math-comp/analysis/contributors","subscribers_url":"https://api.github.com/repos/math-comp/analysis/subscribers","subscription_url":"https://api.github.com/repos/math-comp/analysis/subscription","commits_url":"https://api.github.com/repos/math-comp/analysis/commits{/sha}","git_commits_url":"https://api.github.com/repos/math-comp/analysis/git/commits{/sha}","comments_url":"https://api.github.com/repos/math-comp/analysis/comments{/number}","issue_comment_url":"https://api.github.com/repos/math-comp/analysis/issues/comments{/number}","contents_url":"https://api.github.com/repos/math-comp/analysis/contents/{+path}","compare_url":"https://api.github.com/repos/math-comp/analysis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/math-comp/analysis/merges","archive_url":"https://api.github.com/repos/math-comp/analysis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/math-comp/analysis/downloads","issues_url":"https://api.github.com/repos/math-comp/analysis/issues{/number}","pulls_url":"https://api.github.com/repos/math-comp/analysis/pulls{/number}","milestones_url":"https://api.github.com/repos/math-comp/analysis/milestones{/number}","notifications_url":"https://api.github.com/repos/math-comp/analysis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/math-comp/analysis/labels{/name}","releases_url":"https://api.github.com/repos/math-comp/analysis/releases{/id}","deployments_url":"https://api.github.com/repos/math-comp/analysis/deployments","created_at":"2017-11-29T12:17:44Z","updated_at":"2018-10-28T01:06:07Z","pushed_at":"2018-10-26T21:09:13Z","git_url":"git://github.com/math-comp/analysis.git","ssh_url":"[email protected]:math-comp/analysis.git","clone_url":"https://github.com/math-comp/analysis.git","svn_url":"https://github.com/math-comp/analysis","homepage":"","size":1586,"stargazers_count":21,"watchers_count":21,"language":"Coq","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":29,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":4,"open_issues":29,"watchers":21,"default_branch":"master"}},"base":{"label":"math-comp:master","ref":"master","sha":"3be18107f54445d7b40a7c734b8e49d489fa54d3","user":{"login":"math-comp","id":11424151,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNDI0MTUx","avatar_url":"https://avatars2.githubusercontent.com/u/11424151?v=4","gravatar_id":"","url":"https://api.github.com/users/math-comp","html_url":"https://github.com/math-comp","followers_url":"https://api.github.com/users/math-comp/followers","following_url":"https://api.github.com/users/math-comp/following{/other_user}","gists_url":"https://api.github.com/users/math-comp/gists{/gist_id}","starred_url":"https://api.github.com/users/math-comp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/math-comp/subscriptions","organizations_url":"https://api.github.com/users/math-comp/orgs","repos_url":"https://api.github.com/users/math-comp/repos","events_url":"https://api.github.com/users/math-comp/events{/privacy}","received_events_url":"https://api.github.com/users/math-comp/received_events","type":"Organization","site_admin":false},"repo":{"id":112471761,"node_id":"MDEwOlJlcG9zaXRvcnkxMTI0NzE3NjE=","name":"analysis","full_name":"math-comp/analysis","private":false,"owner":{"login":"math-comp","id":11424151,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNDI0MTUx","avatar_url":"https://avatars2.githubusercontent.com/u/11424151?v=4","gravatar_id":"","url":"https://api.github.com/users/math-comp","html_url":"https://github.com/math-comp","followers_url":"https://api.github.com/users/math-comp/followers","following_url":"https://api.github.com/users/math-comp/following{/other_user}","gists_url":"https://api.github.com/users/math-comp/gists{/gist_id}","starred_url":"https://api.github.com/users/math-comp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/math-comp/subscriptions","organizations_url":"https://api.github.com/users/math-comp/orgs","repos_url":"https://api.github.com/users/math-comp/repos","events_url":"https://api.github.com/users/math-comp/events{/privacy}","received_events_url":"https://api.github.com/users/math-comp/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/math-comp/analysis","description":"Mathematical Components compliant Analysis Library","fork":false,"url":"https://api.github.com/repos/math-comp/analysis","forks_url":"https://api.github.com/repos/math-comp/analysis/forks","keys_url":"https://api.github.com/repos/math-comp/analysis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/math-comp/analysis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/math-comp/analysis/teams","hooks_url":"https://api.github.com/repos/math-comp/analysis/hooks","issue_events_url":"https://api.github.com/repos/math-comp/analysis/issues/events{/number}","events_url":"https://api.github.com/repos/math-comp/analysis/events","assignees_url":"https://api.github.com/repos/math-comp/analysis/assignees{/user}","branches_url":"https://api.github.com/repos/math-comp/analysis/branches{/branch}","tags_url":"https://api.github.com/repos/math-comp/analysis/tags","blobs_url":"https://api.github.com/repos/math-comp/analysis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/math-comp/analysis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/math-comp/analysis/git/refs{/sha}","trees_url":"https://api.github.com/repos/math-comp/analysis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/math-comp/analysis/statuses/{sha}","languages_url":"https://api.github.com/repos/math-comp/analysis/languages","stargazers_url":"https://api.github.com/repos/math-comp/analysis/stargazers","contributors_url":"https://api.github.com/repos/math-comp/analysis/contributors","subscribers_url":"https://api.github.com/repos/math-comp/analysis/subscribers","subscription_url":"https://api.github.com/repos/math-comp/analysis/subscription","commits_url":"https://api.github.com/repos/math-comp/analysis/commits{/sha}","git_commits_url":"https://api.github.com/repos/math-comp/analysis/git/commits{/sha}","comments_url":"https://api.github.com/repos/math-comp/analysis/comments{/number}","issue_comment_url":"https://api.github.com/repos/math-comp/analysis/issues/comments{/number}","contents_url":"https://api.github.com/repos/math-comp/analysis/contents/{+path}","compare_url":"https://api.github.com/repos/math-comp/analysis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/math-comp/analysis/merges","archive_url":"https://api.github.com/repos/math-comp/analysis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/math-comp/analysis/downloads","issues_url":"https://api.github.com/repos/math-comp/analysis/issues{/number}","pulls_url":"https://api.github.com/repos/math-comp/analysis/pulls{/number}","milestones_url":"https://api.github.com/repos/math-comp/analysis/milestones{/number}","notifications_url":"https://api.github.com/repos/math-comp/analysis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/math-comp/analysis/labels{/name}","releases_url":"https://api.github.com/repos/math-comp/analysis/releases{/id}","deployments_url":"https://api.github.com/repos/math-comp/analysis/deployments","created_at":"2017-11-29T12:17:44Z","updated_at":"2018-10-28T01:06:07Z","pushed_at":"2018-10-26T21:09:13Z","git_url":"git://github.com/math-comp/analysis.git","ssh_url":"[email protected]:math-comp/analysis.git","clone_url":"https://github.com/math-comp/analysis.git","svn_url":"https://github.com/math-comp/analysis","homepage":"","size":1586,"stargazers_count":21,"watchers_count":21,"language":"Coq","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":29,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":4,"open_issues":29,"watchers":21,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/math-comp/analysis/pulls/112"},"html":{"href":"https://github.com/math-comp/analysis/pull/112"},"issue":{"href":"https://api.github.com/repos/math-comp/analysis/issues/112"},"comments":{"href":"https://api.github.com/repos/math-comp/analysis/issues/112/comments"},"review_comments":{"href":"https://api.github.com/repos/math-comp/analysis/pulls/112/comments"},"review_comment":{"href":"https://api.github.com/repos/math-comp/analysis/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/math-comp/analysis/pulls/112/commits"},"statuses":{"href":"https://api.github.com/repos/math-comp/analysis/statuses/909029df85097c95307922976f6aba213ae6f397"}},"author_association":"COLLABORATOR"}} | {
"id": 112471761,
"name": "math-comp/analysis",
"url": "https://api.github.com/repos/math-comp/analysis"
} | {
"id": 298705,
"login": "CohenCyril",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/298705?",
"url": "https://api.github.com/users/CohenCyril"
} | {
"id": 11424151,
"login": "math-comp",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/11424151?",
"url": "https://api.github.com/orgs/math-comp"
} | 2018-10-30T12:14:16 | 8504589120 | {"actor":{"display_login":"CohenCyril"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/PowerShell/PowerShell/pulls/comments/243770368","pull_request_review_id":187627331,"id":243770368,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0Mzc3MDM2OA==","diff_hunk":"@@ -4019,6 +4062,7 @@ internal void ImportCmdletsFromAssembly(Assembly assembly, PSModuleInfo module)\n <#options#> $options)\n }\n }\n+\n \";","path":"src/System.Management.Automation/engine/InitialSessionState.cs","position":337,"original_position":337,"commit_id":"7e7a9ccc4001f1dcf2da528f8c22f8b21196ca72","original_commit_id":"10d0bd00bda4f15fce8c4dd70e57f2a0125e597f","user":{"login":"SteveL-MSFT","id":11859881,"node_id":"MDQ6VXNlcjExODU5ODgx","avatar_url":"https://avatars1.githubusercontent.com/u/11859881?v=4","gravatar_id":"","url":"https://api.github.com/users/SteveL-MSFT","html_url":"https://github.com/SteveL-MSFT","followers_url":"https://api.github.com/users/SteveL-MSFT/followers","following_url":"https://api.github.com/users/SteveL-MSFT/following{/other_user}","gists_url":"https://api.github.com/users/SteveL-MSFT/gists{/gist_id}","starred_url":"https://api.github.com/users/SteveL-MSFT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SteveL-MSFT/subscriptions","organizations_url":"https://api.github.com/users/SteveL-MSFT/orgs","repos_url":"https://api.github.com/users/SteveL-MSFT/repos","events_url":"https://api.github.com/users/SteveL-MSFT/events{/privacy}","received_events_url":"https://api.github.com/users/SteveL-MSFT/received_events","type":"User","site_admin":false},"body":"Should also ignore if followed by a double quote","created_at":"2018-12-23T17:10:21Z","updated_at":"2018-12-23T17:10:21Z","html_url":"https://github.com/PowerShell/PowerShell/pull/8530#discussion_r243770368","pull_request_url":"https://api.github.com/repos/PowerShell/PowerShell/pulls/8530","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/PowerShell/PowerShell/pulls/comments/243770368"},"html":{"href":"https://github.com/PowerShell/PowerShell/pull/8530#discussion_r243770368"},"pull_request":{"href":"https://api.github.com/repos/PowerShell/PowerShell/pulls/8530"}},"in_reply_to_id":243760582},"pull_request":{"url":"https://api.github.com/repos/PowerShell/PowerShell/pulls/8530","id":240659393,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQwNjU5Mzkz","html_url":"https://github.com/PowerShell/PowerShell/pull/8530","diff_url":"https://github.com/PowerShell/PowerShell/pull/8530.diff","patch_url":"https://github.com/PowerShell/PowerShell/pull/8530.patch","issue_url":"https://api.github.com/repos/PowerShell/PowerShell/issues/8530","number":8530,"state":"open","locked":false,"title":"Code cleanup: Add space after closing brace where needed","user":{"login":"SteveL-MSFT","id":11859881,"node_id":"MDQ6VXNlcjExODU5ODgx","avatar_url":"https://avatars1.githubusercontent.com/u/11859881?v=4","gravatar_id":"","url":"https://api.github.com/users/SteveL-MSFT","html_url":"https://github.com/SteveL-MSFT","followers_url":"https://api.github.com/users/SteveL-MSFT/followers","following_url":"https://api.github.com/users/SteveL-MSFT/following{/other_user}","gists_url":"https://api.github.com/users/SteveL-MSFT/gists{/gist_id}","starred_url":"https://api.github.com/users/SteveL-MSFT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SteveL-MSFT/subscriptions","organizations_url":"https://api.github.com/users/SteveL-MSFT/orgs","repos_url":"https://api.github.com/users/SteveL-MSFT/repos","events_url":"https://api.github.com/users/SteveL-MSFT/events{/privacy}","received_events_url":"https://api.github.com/users/SteveL-MSFT/received_events","type":"User","site_admin":false},"body":"## PR Summary\r\n\r\nUsing this [script](https://gist.github.com/SteveL-MSFT/f4e977caa3c44be2ce35f8012b151b4c) each folder is a separate commit making it easier to review.\r\n\r\nThe regular expression looks for any closing brace not followed by:\r\n\r\n| catch, else, finally, another closing brace, newline, space, hash, slash (comment), * (comment)\r\n\r\nIn addition, because .NET RegEx doesn't support look behind, I skip any closing braces that are part of: { get; set; }\r\n\r\nSome of the Copyright notices show changed because git resaved the file without BOM.\r\n\r\nManually reviewed all the changes.\r\n\r\nRelated https://github.com/PowerShell/PowerShell/pull/8500\r\n\r\n## PR Checklist\r\n\r\n- [x] [PR has a meaningful title](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission)\r\n - Use the present tense and imperative mood when describing your changes\r\n- [x] [Summarized changes](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission)\r\n- [x] [Change is not breaking](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#making-breaking-changes)\r\n- [x] [Make sure all `.h`, `.cpp`, `.cs`, `.ps1` and `.psm1` files have the correct copyright header](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission)\r\n- [x] This PR is ready to merge and is not [Work in Progress](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---work-in-progress).\r\n - If the PR is work in progress, please add the prefix `WIP:` to the beginning of the title and remove the prefix when the PR is ready.\r\n- **User-facing changes**\r\n - [x] Not Applicable\r\n - **OR**\r\n - [ ] User-facing [Documentation needed](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission)\r\n - [ ] Issue filed - Issue link:\r\n- **Testing - New and feature**\r\n - [x] Not Applicable or can only be tested interactively\r\n - **OR**\r\n - [ ] [Make sure you've added a new test if existing tests do not effectively test the code changed](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#before-submitting)\r\n - [ ] [Add `[feature]` if the change is significant or affects feature tests](https://github.com/PowerShell/PowerShell/blob/master/docs/testing-guidelines/testing-guidelines.md#requesting-additional-tests-for-a-pr)\r\n","created_at":"2018-12-23T00:29:40Z","updated_at":"2018-12-23T17:10:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b11df286c30fef5ca3a4d698143eac57020cf493","assignee":{"login":"daxian-dbw","id":127450,"node_id":"MDQ6VXNlcjEyNzQ1MA==","avatar_url":"https://avatars2.githubusercontent.com/u/127450?v=4","gravatar_id":"","url":"https://api.github.com/users/daxian-dbw","html_url":"https://github.com/daxian-dbw","followers_url":"https://api.github.com/users/daxian-dbw/followers","following_url":"https://api.github.com/users/daxian-dbw/following{/other_user}","gists_url":"https://api.github.com/users/daxian-dbw/gists{/gist_id}","starred_url":"https://api.github.com/users/daxian-dbw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daxian-dbw/subscriptions","organizations_url":"https://api.github.com/users/daxian-dbw/orgs","repos_url":"https://api.github.com/users/daxian-dbw/repos","events_url":"https://api.github.com/users/daxian-dbw/events{/privacy}","received_events_url":"https://api.github.com/users/daxian-dbw/received_events","type":"User","site_admin":false},"assignees":[{"login":"daxian-dbw","id":127450,"node_id":"MDQ6VXNlcjEyNzQ1MA==","avatar_url":"https://avatars2.githubusercontent.com/u/127450?v=4","gravatar_id":"","url":"https://api.github.com/users/daxian-dbw","html_url":"https://github.com/daxian-dbw","followers_url":"https://api.github.com/users/daxian-dbw/followers","following_url":"https://api.github.com/users/daxian-dbw/following{/other_user}","gists_url":"https://api.github.com/users/daxian-dbw/gists{/gist_id}","starred_url":"https://api.github.com/users/daxian-dbw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daxian-dbw/subscriptions","organizations_url":"https://api.github.com/users/daxian-dbw/orgs","repos_url":"https://api.github.com/users/daxian-dbw/repos","events_url":"https://api.github.com/users/daxian-dbw/events{/privacy}","received_events_url":"https://api.github.com/users/daxian-dbw/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"daxian-dbw","id":127450,"node_id":"MDQ6VXNlcjEyNzQ1MA==","avatar_url":"https://avatars2.githubusercontent.com/u/127450?v=4","gravatar_id":"","url":"https://api.github.com/users/daxian-dbw","html_url":"https://github.com/daxian-dbw","followers_url":"https://api.github.com/users/daxian-dbw/followers","following_url":"https://api.github.com/users/daxian-dbw/following{/other_user}","gists_url":"https://api.github.com/users/daxian-dbw/gists{/gist_id}","starred_url":"https://api.github.com/users/daxian-dbw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daxian-dbw/subscriptions","organizations_url":"https://api.github.com/users/daxian-dbw/orgs","repos_url":"https://api.github.com/users/daxian-dbw/repos","events_url":"https://api.github.com/users/daxian-dbw/events{/privacy}","received_events_url":"https://api.github.com/users/daxian-dbw/received_events","type":"User","site_admin":false},{"login":"BrucePay","id":6876108,"node_id":"MDQ6VXNlcjY4NzYxMDg=","avatar_url":"https://avatars3.githubusercontent.com/u/6876108?v=4","gravatar_id":"","url":"https://api.github.com/users/BrucePay","html_url":"https://github.com/BrucePay","followers_url":"https://api.github.com/users/BrucePay/followers","following_url":"https://api.github.com/users/BrucePay/following{/other_user}","gists_url":"https://api.github.com/users/BrucePay/gists{/gist_id}","starred_url":"https://api.github.com/users/BrucePay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BrucePay/subscriptions","organizations_url":"https://api.github.com/users/BrucePay/orgs","repos_url":"https://api.github.com/users/BrucePay/repos","events_url":"https://api.github.com/users/BrucePay/events{/privacy}","received_events_url":"https://api.github.com/users/BrucePay/received_events","type":"User","site_admin":false},{"login":"JamesWTruher","id":10214008,"node_id":"MDQ6VXNlcjEwMjE0MDA4","avatar_url":"https://avatars2.githubusercontent.com/u/10214008?v=4","gravatar_id":"","url":"https://api.github.com/users/JamesWTruher","html_url":"https://github.com/JamesWTruher","followers_url":"https://api.github.com/users/JamesWTruher/followers","following_url":"https://api.github.com/users/JamesWTruher/following{/other_user}","gists_url":"https://api.github.com/users/JamesWTruher/gists{/gist_id}","starred_url":"https://api.github.com/users/JamesWTruher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JamesWTruher/subscriptions","organizations_url":"https://api.github.com/users/JamesWTruher/orgs","repos_url":"https://api.github.com/users/JamesWTruher/repos","events_url":"https://api.github.com/users/JamesWTruher/events{/privacy}","received_events_url":"https://api.github.com/users/JamesWTruher/received_events","type":"User","site_admin":false},{"login":"TravisEz13","id":10873629,"node_id":"MDQ6VXNlcjEwODczNjI5","avatar_url":"https://avatars1.githubusercontent.com/u/10873629?v=4","gravatar_id":"","url":"https://api.github.com/users/TravisEz13","html_url":"https://github.com/TravisEz13","followers_url":"https://api.github.com/users/TravisEz13/followers","following_url":"https://api.github.com/users/TravisEz13/following{/other_user}","gists_url":"https://api.github.com/users/TravisEz13/gists{/gist_id}","starred_url":"https://api.github.com/users/TravisEz13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TravisEz13/subscriptions","organizations_url":"https://api.github.com/users/TravisEz13/orgs","repos_url":"https://api.github.com/users/TravisEz13/repos","events_url":"https://api.github.com/users/TravisEz13/events{/privacy}","received_events_url":"https://api.github.com/users/TravisEz13/received_events","type":"User","site_admin":false},{"login":"anmenaga","id":11860095,"node_id":"MDQ6VXNlcjExODYwMDk1","avatar_url":"https://avatars1.githubusercontent.com/u/11860095?v=4","gravatar_id":"","url":"https://api.github.com/users/anmenaga","html_url":"https://github.com/anmenaga","followers_url":"https://api.github.com/users/anmenaga/followers","following_url":"https://api.github.com/users/anmenaga/following{/other_user}","gists_url":"https://api.github.com/users/anmenaga/gists{/gist_id}","starred_url":"https://api.github.com/users/anmenaga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anmenaga/subscriptions","organizations_url":"https://api.github.com/users/anmenaga/orgs","repos_url":"https://api.github.com/users/anmenaga/repos","events_url":"https://api.github.com/users/anmenaga/events{/privacy}","received_events_url":"https://api.github.com/users/anmenaga/received_events","type":"User","site_admin":false},{"login":"Francisco-Gamino","id":12720858,"node_id":"MDQ6VXNlcjEyNzIwODU4","avatar_url":"https://avatars0.githubusercontent.com/u/12720858?v=4","gravatar_id":"","url":"https://api.github.com/users/Francisco-Gamino","html_url":"https://github.com/Francisco-Gamino","followers_url":"https://api.github.com/users/Francisco-Gamino/followers","following_url":"https://api.github.com/users/Francisco-Gamino/following{/other_user}","gists_url":"https://api.github.com/users/Francisco-Gamino/gists{/gist_id}","starred_url":"https://api.github.com/users/Francisco-Gamino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Francisco-Gamino/subscriptions","organizations_url":"https://api.github.com/users/Francisco-Gamino/orgs","repos_url":"https://api.github.com/users/Francisco-Gamino/repos","events_url":"https://api.github.com/users/Francisco-Gamino/events{/privacy}","received_events_url":"https://api.github.com/users/Francisco-Gamino/received_events","type":"User","site_admin":false},{"login":"mirichmo","id":12738734,"node_id":"MDQ6VXNlcjEyNzM4NzM0","avatar_url":"https://avatars3.githubusercontent.com/u/12738734?v=4","gravatar_id":"","url":"https://api.github.com/users/mirichmo","html_url":"https://github.com/mirichmo","followers_url":"https://api.github.com/users/mirichmo/followers","following_url":"https://api.github.com/users/mirichmo/following{/other_user}","gists_url":"https://api.github.com/users/mirichmo/gists{/gist_id}","starred_url":"https://api.github.com/users/mirichmo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mirichmo/subscriptions","organizations_url":"https://api.github.com/users/mirichmo/orgs","repos_url":"https://api.github.com/users/mirichmo/repos","events_url":"https://api.github.com/users/mirichmo/events{/privacy}","received_events_url":"https://api.github.com/users/mirichmo/received_events","type":"User","site_admin":false},{"login":"adityapatwardhan","id":12820925,"node_id":"MDQ6VXNlcjEyODIwOTI1","avatar_url":"https://avatars0.githubusercontent.com/u/12820925?v=4","gravatar_id":"","url":"https://api.github.com/users/adityapatwardhan","html_url":"https://github.com/adityapatwardhan","followers_url":"https://api.github.com/users/adityapatwardhan/followers","following_url":"https://api.github.com/users/adityapatwardhan/following{/other_user}","gists_url":"https://api.github.com/users/adityapatwardhan/gists{/gist_id}","starred_url":"https://api.github.com/users/adityapatwardhan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adityapatwardhan/subscriptions","organizations_url":"https://api.github.com/users/adityapatwardhan/orgs","repos_url":"https://api.github.com/users/adityapatwardhan/repos","events_url":"https://api.github.com/users/adityapatwardhan/events{/privacy}","received_events_url":"https://api.github.com/users/adityapatwardhan/received_events","type":"User","site_admin":false},{"login":"PaulHigin","id":14019529,"node_id":"MDQ6VXNlcjE0MDE5NTI5","avatar_url":"https://avatars0.githubusercontent.com/u/14019529?v=4","gravatar_id":"","url":"https://api.github.com/users/PaulHigin","html_url":"https://github.com/PaulHigin","followers_url":"https://api.github.com/users/PaulHigin/followers","following_url":"https://api.github.com/users/PaulHigin/following{/other_user}","gists_url":"https://api.github.com/users/PaulHigin/gists{/gist_id}","starred_url":"https://api.github.com/users/PaulHigin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PaulHigin/subscriptions","organizations_url":"https://api.github.com/users/PaulHigin/orgs","repos_url":"https://api.github.com/users/PaulHigin/repos","events_url":"https://api.github.com/users/PaulHigin/events{/privacy}","received_events_url":"https://api.github.com/users/PaulHigin/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/PowerShell/PowerShell/pulls/8530/commits","review_comments_url":"https://api.github.com/repos/PowerShell/PowerShell/pulls/8530/comments","review_comment_url":"https://api.github.com/repos/PowerShell/PowerShell/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PowerShell/PowerShell/issues/8530/comments","statuses_url":"https://api.github.com/repos/PowerShell/PowerShell/statuses/7e7a9ccc4001f1dcf2da528f8c22f8b21196ca72","head":{"label":"SteveL-MSFT:space-after-brace","ref":"space-after-brace","sha":"7e7a9ccc4001f1dcf2da528f8c22f8b21196ca72","user":{"login":"SteveL-MSFT","id":11859881,"node_id":"MDQ6VXNlcjExODU5ODgx","avatar_url":"https://avatars1.githubusercontent.com/u/11859881?v=4","gravatar_id":"","url":"https://api.github.com/users/SteveL-MSFT","html_url":"https://github.com/SteveL-MSFT","followers_url":"https://api.github.com/users/SteveL-MSFT/followers","following_url":"https://api.github.com/users/SteveL-MSFT/following{/other_user}","gists_url":"https://api.github.com/users/SteveL-MSFT/gists{/gist_id}","starred_url":"https://api.github.com/users/SteveL-MSFT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SteveL-MSFT/subscriptions","organizations_url":"https://api.github.com/users/SteveL-MSFT/orgs","repos_url":"https://api.github.com/users/SteveL-MSFT/repos","events_url":"https://api.github.com/users/SteveL-MSFT/events{/privacy}","received_events_url":"https://api.github.com/users/SteveL-MSFT/received_events","type":"User","site_admin":false},"repo":{"id":80881740,"node_id":"MDEwOlJlcG9zaXRvcnk4MDg4MTc0MA==","name":"PowerShell","full_name":"SteveL-MSFT/PowerShell","private":false,"owner":{"login":"SteveL-MSFT","id":11859881,"node_id":"MDQ6VXNlcjExODU5ODgx","avatar_url":"https://avatars1.githubusercontent.com/u/11859881?v=4","gravatar_id":"","url":"https://api.github.com/users/SteveL-MSFT","html_url":"https://github.com/SteveL-MSFT","followers_url":"https://api.github.com/users/SteveL-MSFT/followers","following_url":"https://api.github.com/users/SteveL-MSFT/following{/other_user}","gists_url":"https://api.github.com/users/SteveL-MSFT/gists{/gist_id}","starred_url":"https://api.github.com/users/SteveL-MSFT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SteveL-MSFT/subscriptions","organizations_url":"https://api.github.com/users/SteveL-MSFT/orgs","repos_url":"https://api.github.com/users/SteveL-MSFT/repos","events_url":"https://api.github.com/users/SteveL-MSFT/events{/privacy}","received_events_url":"https://api.github.com/users/SteveL-MSFT/received_events","type":"User","site_admin":false},"html_url":"https://github.com/SteveL-MSFT/PowerShell","description":"PowerShell for every system!","fork":true,"url":"https://api.github.com/repos/SteveL-MSFT/PowerShell","forks_url":"https://api.github.com/repos/SteveL-MSFT/PowerShell/forks","keys_url":"https://api.github.com/repos/SteveL-MSFT/PowerShell/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SteveL-MSFT/PowerShell/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SteveL-MSFT/PowerShell/teams","hooks_url":"https://api.github.com/repos/SteveL-MSFT/PowerShell/hooks","issue_events_url":"https://api.github.com/repos/SteveL-MSFT/PowerShell/issues/events{/number}","events_url":"https://api.github.com/repos/SteveL-MSFT/PowerShell/events","assignees_url":"https://api.github.com/repos/SteveL-MSFT/PowerShell/assignees{/user}","branches_url":"https://api.github.com/repos/SteveL-MSFT/PowerShell/branches{/branch}","tags_url":"https://api.github.com/repos/SteveL-MSFT/PowerShell/tags","blobs_url":"https://api.github.com/repos/SteveL-MSFT/PowerShell/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SteveL-MSFT/PowerShell/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SteveL-MSFT/PowerShell/git/refs{/sha}","trees_url":"https://api.github.com/repos/SteveL-MSFT/PowerShell/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SteveL-MSFT/PowerShell/statuses/{sha}","languages_url":"https://api.github.com/repos/SteveL-MSFT/PowerShell/languages","stargazers_url":"https://api.github.com/repos/SteveL-MSFT/PowerShell/stargazers","contributors_url":"https://api.github.com/repos/SteveL-MSFT/PowerShell/contributors","subscribers_url":"https://api.github.com/repos/SteveL-MSFT/PowerShell/subscribers","subscription_url":"https://api.github.com/repos/SteveL-MSFT/PowerShell/subscription","commits_url":"https://api.github.com/repos/SteveL-MSFT/PowerShell/commits{/sha}","git_commits_url":"https://api.github.com/repos/SteveL-MSFT/PowerShell/git/commits{/sha}","comments_url":"https://api.github.com/repos/SteveL-MSFT/PowerShell/comments{/number}","issue_comment_url":"https://api.github.com/repos/SteveL-MSFT/PowerShell/issues/comments{/number}","contents_url":"https://api.github.com/repos/SteveL-MSFT/PowerShell/contents/{+path}","compare_url":"https://api.github.com/repos/SteveL-MSFT/PowerShell/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SteveL-MSFT/PowerShell/merges","archive_url":"https://api.github.com/repos/SteveL-MSFT/PowerShell/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SteveL-MSFT/PowerShell/downloads","issues_url":"https://api.github.com/repos/SteveL-MSFT/PowerShell/issues{/number}","pulls_url":"https://api.github.com/repos/SteveL-MSFT/PowerShell/pulls{/number}","milestones_url":"https://api.github.com/repos/SteveL-MSFT/PowerShell/milestones{/number}","notifications_url":"https://api.github.com/repos/SteveL-MSFT/PowerShell/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SteveL-MSFT/PowerShell/labels{/name}","releases_url":"https://api.github.com/repos/SteveL-MSFT/PowerShell/releases{/id}","deployments_url":"https://api.github.com/repos/SteveL-MSFT/PowerShell/deployments","created_at":"2017-02-04T00:41:57Z","updated_at":"2018-12-22T19:37:14Z","pushed_at":"2018-12-23T06:53:41Z","git_url":"git://github.com/SteveL-MSFT/PowerShell.git","ssh_url":"[email protected]:SteveL-MSFT/PowerShell.git","clone_url":"https://github.com/SteveL-MSFT/PowerShell.git","svn_url":"https://github.com/SteveL-MSFT/PowerShell","homepage":"https://microsoft.com/powershell","size":45271,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"PowerShell:master","ref":"master","sha":"40223881cbc9444c21245884096cc502275cb1ae","user":{"login":"PowerShell","id":11524380,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNTI0Mzgw","avatar_url":"https://avatars3.githubusercontent.com/u/11524380?v=4","gravatar_id":"","url":"https://api.github.com/users/PowerShell","html_url":"https://github.com/PowerShell","followers_url":"https://api.github.com/users/PowerShell/followers","following_url":"https://api.github.com/users/PowerShell/following{/other_user}","gists_url":"https://api.github.com/users/PowerShell/gists{/gist_id}","starred_url":"https://api.github.com/users/PowerShell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PowerShell/subscriptions","organizations_url":"https://api.github.com/users/PowerShell/orgs","repos_url":"https://api.github.com/users/PowerShell/repos","events_url":"https://api.github.com/users/PowerShell/events{/privacy}","received_events_url":"https://api.github.com/users/PowerShell/received_events","type":"Organization","site_admin":false},"repo":{"id":49609581,"node_id":"MDEwOlJlcG9zaXRvcnk0OTYwOTU4MQ==","name":"PowerShell","full_name":"PowerShell/PowerShell","private":false,"owner":{"login":"PowerShell","id":11524380,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNTI0Mzgw","avatar_url":"https://avatars3.githubusercontent.com/u/11524380?v=4","gravatar_id":"","url":"https://api.github.com/users/PowerShell","html_url":"https://github.com/PowerShell","followers_url":"https://api.github.com/users/PowerShell/followers","following_url":"https://api.github.com/users/PowerShell/following{/other_user}","gists_url":"https://api.github.com/users/PowerShell/gists{/gist_id}","starred_url":"https://api.github.com/users/PowerShell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PowerShell/subscriptions","organizations_url":"https://api.github.com/users/PowerShell/orgs","repos_url":"https://api.github.com/users/PowerShell/repos","events_url":"https://api.github.com/users/PowerShell/events{/privacy}","received_events_url":"https://api.github.com/users/PowerShell/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/PowerShell/PowerShell","description":"PowerShell for every system!","fork":false,"url":"https://api.github.com/repos/PowerShell/PowerShell","forks_url":"https://api.github.com/repos/PowerShell/PowerShell/forks","keys_url":"https://api.github.com/repos/PowerShell/PowerShell/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PowerShell/PowerShell/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PowerShell/PowerShell/teams","hooks_url":"https://api.github.com/repos/PowerShell/PowerShell/hooks","issue_events_url":"https://api.github.com/repos/PowerShell/PowerShell/issues/events{/number}","events_url":"https://api.github.com/repos/PowerShell/PowerShell/events","assignees_url":"https://api.github.com/repos/PowerShell/PowerShell/assignees{/user}","branches_url":"https://api.github.com/repos/PowerShell/PowerShell/branches{/branch}","tags_url":"https://api.github.com/repos/PowerShell/PowerShell/tags","blobs_url":"https://api.github.com/repos/PowerShell/PowerShell/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PowerShell/PowerShell/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PowerShell/PowerShell/git/refs{/sha}","trees_url":"https://api.github.com/repos/PowerShell/PowerShell/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PowerShell/PowerShell/statuses/{sha}","languages_url":"https://api.github.com/repos/PowerShell/PowerShell/languages","stargazers_url":"https://api.github.com/repos/PowerShell/PowerShell/stargazers","contributors_url":"https://api.github.com/repos/PowerShell/PowerShell/contributors","subscribers_url":"https://api.github.com/repos/PowerShell/PowerShell/subscribers","subscription_url":"https://api.github.com/repos/PowerShell/PowerShell/subscription","commits_url":"https://api.github.com/repos/PowerShell/PowerShell/commits{/sha}","git_commits_url":"https://api.github.com/repos/PowerShell/PowerShell/git/commits{/sha}","comments_url":"https://api.github.com/repos/PowerShell/PowerShell/comments{/number}","issue_comment_url":"https://api.github.com/repos/PowerShell/PowerShell/issues/comments{/number}","contents_url":"https://api.github.com/repos/PowerShell/PowerShell/contents/{+path}","compare_url":"https://api.github.com/repos/PowerShell/PowerShell/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PowerShell/PowerShell/merges","archive_url":"https://api.github.com/repos/PowerShell/PowerShell/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PowerShell/PowerShell/downloads","issues_url":"https://api.github.com/repos/PowerShell/PowerShell/issues{/number}","pulls_url":"https://api.github.com/repos/PowerShell/PowerShell/pulls{/number}","milestones_url":"https://api.github.com/repos/PowerShell/PowerShell/milestones{/number}","notifications_url":"https://api.github.com/repos/PowerShell/PowerShell/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PowerShell/PowerShell/labels{/name}","releases_url":"https://api.github.com/repos/PowerShell/PowerShell/releases{/id}","deployments_url":"https://api.github.com/repos/PowerShell/PowerShell/deployments","created_at":"2016-01-13T23:41:35Z","updated_at":"2018-12-23T15:15:56Z","pushed_at":"2018-12-23T14:33:05Z","git_url":"git://github.com/PowerShell/PowerShell.git","ssh_url":"[email protected]:PowerShell/PowerShell.git","clone_url":"https://github.com/PowerShell/PowerShell.git","svn_url":"https://github.com/PowerShell/PowerShell","homepage":"https://microsoft.com/powershell","size":46295,"stargazers_count":12019,"watchers_count":12019,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1933,"mirror_url":null,"archived":false,"open_issues_count":1771,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1933,"open_issues":1771,"watchers":12019,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PowerShell/PowerShell/pulls/8530"},"html":{"href":"https://github.com/PowerShell/PowerShell/pull/8530"},"issue":{"href":"https://api.github.com/repos/PowerShell/PowerShell/issues/8530"},"comments":{"href":"https://api.github.com/repos/PowerShell/PowerShell/issues/8530/comments"},"review_comments":{"href":"https://api.github.com/repos/PowerShell/PowerShell/pulls/8530/comments"},"review_comment":{"href":"https://api.github.com/repos/PowerShell/PowerShell/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PowerShell/PowerShell/pulls/8530/commits"},"statuses":{"href":"https://api.github.com/repos/PowerShell/PowerShell/statuses/7e7a9ccc4001f1dcf2da528f8c22f8b21196ca72"}},"author_association":"MEMBER"}} | {
"id": 49609581,
"name": "PowerShell/PowerShell",
"url": "https://api.github.com/repos/PowerShell/PowerShell"
} | {
"id": 11859881,
"login": "SteveL-MSFT",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/11859881?",
"url": "https://api.github.com/users/SteveL-MSFT"
} | {
"id": 11524380,
"login": "PowerShell",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/11524380?",
"url": "https://api.github.com/orgs/PowerShell"
} | 2018-12-23T17:10:21 | 8797242767 | {"actor":{"display_login":"SteveL-MSFT"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/pulls/comments/192011942","pull_request_review_id":124698032,"id":192011942,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5MjAxMTk0Mg==","diff_hunk":"@@ -157,7 +145,7 @@ private void createNs(HttpServletRequest request, HttpServletResponse response)\n if (failFast != null) {\n LOGGER.error(\"Cannot apply node source action: \" + failFast);\n LOGGER.error(\"Request parameters: \");\n- fileItems.forEach(fileItem -> LOGGER.error(fileItem.getFieldName() + \"=\" + fileItem.getString()));\n+ formItems.forEach(fileItem -> LOGGER.error(fileItem.getFieldName() + \"=\" + fileItem.getString()));","path":"rm-portal/src/main/java/org/ow2/proactive_grid_cloud_portal/rm/server/NSCreationServlet.java","position":93,"original_position":93,"commit_id":"0da88c8949261120538f699d96294073127973b9","original_commit_id":"0da88c8949261120538f699d96294073127973b9","user":{"login":"sonarqube-activeeon","id":14940028,"node_id":"MDQ6VXNlcjE0OTQwMDI4","avatar_url":"https://avatars1.githubusercontent.com/u/14940028?v=4","gravatar_id":"","url":"https://api.github.com/users/sonarqube-activeeon","html_url":"https://github.com/sonarqube-activeeon","followers_url":"https://api.github.com/users/sonarqube-activeeon/followers","following_url":"https://api.github.com/users/sonarqube-activeeon/following{/other_user}","gists_url":"https://api.github.com/users/sonarqube-activeeon/gists{/gist_id}","starred_url":"https://api.github.com/users/sonarqube-activeeon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sonarqube-activeeon/subscriptions","organizations_url":"https://api.github.com/users/sonarqube-activeeon/orgs","repos_url":"https://api.github.com/users/sonarqube-activeeon/repos","events_url":"https://api.github.com/users/sonarqube-activeeon/events{/privacy}","received_events_url":"https://api.github.com/users/sonarqube-activeeon/received_events","type":"User","site_admin":false},"body":" Format specifiers should be used instead of string concatenation. [](https://sonarcloud.io/coding_rules#rule_key=squid%3AS3457)\n","created_at":"2018-05-31T07:37:12Z","updated_at":"2018-05-31T07:37:12Z","html_url":"https://github.com/ow2-proactive/scheduling-portal/pull/449#discussion_r192011942","pull_request_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/pulls/449","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/ow2-proactive/scheduling-portal/pulls/comments/192011942"},"html":{"href":"https://github.com/ow2-proactive/scheduling-portal/pull/449#discussion_r192011942"},"pull_request":{"href":"https://api.github.com/repos/ow2-proactive/scheduling-portal/pulls/449"}}},"pull_request":{"url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/pulls/449","id":190536721,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkwNTM2NzIx","html_url":"https://github.com/ow2-proactive/scheduling-portal/pull/449","diff_url":"https://github.com/ow2-proactive/scheduling-portal/pull/449.diff","patch_url":"https://github.com/ow2-proactive/scheduling-portal/pull/449.patch","issue_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/issues/449","number":449,"state":"open","locked":false,"title":"Be able to export and import a node source by file","user":{"login":"jrochas","id":10711209,"node_id":"MDQ6VXNlcjEwNzExMjA5","avatar_url":"https://avatars3.githubusercontent.com/u/10711209?v=4","gravatar_id":"","url":"https://api.github.com/users/jrochas","html_url":"https://github.com/jrochas","followers_url":"https://api.github.com/users/jrochas/followers","following_url":"https://api.github.com/users/jrochas/following{/other_user}","gists_url":"https://api.github.com/users/jrochas/gists{/gist_id}","starred_url":"https://api.github.com/users/jrochas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrochas/subscriptions","organizations_url":"https://api.github.com/users/jrochas/orgs","repos_url":"https://api.github.com/users/jrochas/repos","events_url":"https://api.github.com/users/jrochas/events{/privacy}","received_events_url":"https://api.github.com/users/jrochas/received_events","type":"User","site_admin":false},"body":"In Resource Manager, we add the possibility to download a file containing a running node source configuration in JSON format. We also provide the possibility to import a node source from such a file when adding a node source.","created_at":"2018-05-25T09:51:35Z","updated_at":"2018-05-31T07:37:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a9c31ce107e8253324fb4decb29f881bf552cf3c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/pulls/449/commits","review_comments_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/pulls/449/comments","review_comment_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/issues/449/comments","statuses_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/statuses/0da88c8949261120538f699d96294073127973b9","head":{"label":"jrochas:export-node-source-json","ref":"export-node-source-json","sha":"0da88c8949261120538f699d96294073127973b9","user":{"login":"jrochas","id":10711209,"node_id":"MDQ6VXNlcjEwNzExMjA5","avatar_url":"https://avatars3.githubusercontent.com/u/10711209?v=4","gravatar_id":"","url":"https://api.github.com/users/jrochas","html_url":"https://github.com/jrochas","followers_url":"https://api.github.com/users/jrochas/followers","following_url":"https://api.github.com/users/jrochas/following{/other_user}","gists_url":"https://api.github.com/users/jrochas/gists{/gist_id}","starred_url":"https://api.github.com/users/jrochas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrochas/subscriptions","organizations_url":"https://api.github.com/users/jrochas/orgs","repos_url":"https://api.github.com/users/jrochas/repos","events_url":"https://api.github.com/users/jrochas/events{/privacy}","received_events_url":"https://api.github.com/users/jrochas/received_events","type":"User","site_admin":false},"repo":{"id":93499724,"node_id":"MDEwOlJlcG9zaXRvcnk5MzQ5OTcyNA==","name":"scheduling-portal","full_name":"jrochas/scheduling-portal","owner":{"login":"jrochas","id":10711209,"node_id":"MDQ6VXNlcjEwNzExMjA5","avatar_url":"https://avatars3.githubusercontent.com/u/10711209?v=4","gravatar_id":"","url":"https://api.github.com/users/jrochas","html_url":"https://github.com/jrochas","followers_url":"https://api.github.com/users/jrochas/followers","following_url":"https://api.github.com/users/jrochas/following{/other_user}","gists_url":"https://api.github.com/users/jrochas/gists{/gist_id}","starred_url":"https://api.github.com/users/jrochas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrochas/subscriptions","organizations_url":"https://api.github.com/users/jrochas/orgs","repos_url":"https://api.github.com/users/jrochas/repos","events_url":"https://api.github.com/users/jrochas/events{/privacy}","received_events_url":"https://api.github.com/users/jrochas/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jrochas/scheduling-portal","description":null,"fork":true,"url":"https://api.github.com/repos/jrochas/scheduling-portal","forks_url":"https://api.github.com/repos/jrochas/scheduling-portal/forks","keys_url":"https://api.github.com/repos/jrochas/scheduling-portal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jrochas/scheduling-portal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jrochas/scheduling-portal/teams","hooks_url":"https://api.github.com/repos/jrochas/scheduling-portal/hooks","issue_events_url":"https://api.github.com/repos/jrochas/scheduling-portal/issues/events{/number}","events_url":"https://api.github.com/repos/jrochas/scheduling-portal/events","assignees_url":"https://api.github.com/repos/jrochas/scheduling-portal/assignees{/user}","branches_url":"https://api.github.com/repos/jrochas/scheduling-portal/branches{/branch}","tags_url":"https://api.github.com/repos/jrochas/scheduling-portal/tags","blobs_url":"https://api.github.com/repos/jrochas/scheduling-portal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jrochas/scheduling-portal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jrochas/scheduling-portal/git/refs{/sha}","trees_url":"https://api.github.com/repos/jrochas/scheduling-portal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jrochas/scheduling-portal/statuses/{sha}","languages_url":"https://api.github.com/repos/jrochas/scheduling-portal/languages","stargazers_url":"https://api.github.com/repos/jrochas/scheduling-portal/stargazers","contributors_url":"https://api.github.com/repos/jrochas/scheduling-portal/contributors","subscribers_url":"https://api.github.com/repos/jrochas/scheduling-portal/subscribers","subscription_url":"https://api.github.com/repos/jrochas/scheduling-portal/subscription","commits_url":"https://api.github.com/repos/jrochas/scheduling-portal/commits{/sha}","git_commits_url":"https://api.github.com/repos/jrochas/scheduling-portal/git/commits{/sha}","comments_url":"https://api.github.com/repos/jrochas/scheduling-portal/comments{/number}","issue_comment_url":"https://api.github.com/repos/jrochas/scheduling-portal/issues/comments{/number}","contents_url":"https://api.github.com/repos/jrochas/scheduling-portal/contents/{+path}","compare_url":"https://api.github.com/repos/jrochas/scheduling-portal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jrochas/scheduling-portal/merges","archive_url":"https://api.github.com/repos/jrochas/scheduling-portal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jrochas/scheduling-portal/downloads","issues_url":"https://api.github.com/repos/jrochas/scheduling-portal/issues{/number}","pulls_url":"https://api.github.com/repos/jrochas/scheduling-portal/pulls{/number}","milestones_url":"https://api.github.com/repos/jrochas/scheduling-portal/milestones{/number}","notifications_url":"https://api.github.com/repos/jrochas/scheduling-portal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jrochas/scheduling-portal/labels{/name}","releases_url":"https://api.github.com/repos/jrochas/scheduling-portal/releases{/id}","deployments_url":"https://api.github.com/repos/jrochas/scheduling-portal/deployments","created_at":"2017-06-06T09:18:57Z","updated_at":"2018-05-14T08:48:49Z","pushed_at":"2018-05-31T07:26:43Z","git_url":"git://github.com/jrochas/scheduling-portal.git","ssh_url":"[email protected]:jrochas/scheduling-portal.git","clone_url":"https://github.com/jrochas/scheduling-portal.git","svn_url":"https://github.com/jrochas/scheduling-portal","homepage":"http://try.activeeon.com","size":119021,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ow2-proactive:master","ref":"master","sha":"5f0c8935b4cac208fbb4c42b5f57e3763564f809","user":{"login":"ow2-proactive","id":11553998,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNTUzOTk4","avatar_url":"https://avatars1.githubusercontent.com/u/11553998?v=4","gravatar_id":"","url":"https://api.github.com/users/ow2-proactive","html_url":"https://github.com/ow2-proactive","followers_url":"https://api.github.com/users/ow2-proactive/followers","following_url":"https://api.github.com/users/ow2-proactive/following{/other_user}","gists_url":"https://api.github.com/users/ow2-proactive/gists{/gist_id}","starred_url":"https://api.github.com/users/ow2-proactive/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ow2-proactive/subscriptions","organizations_url":"https://api.github.com/users/ow2-proactive/orgs","repos_url":"https://api.github.com/users/ow2-proactive/repos","events_url":"https://api.github.com/users/ow2-proactive/events{/privacy}","received_events_url":"https://api.github.com/users/ow2-proactive/received_events","type":"Organization","site_admin":false},"repo":{"id":35725080,"node_id":"MDEwOlJlcG9zaXRvcnkzNTcyNTA4MA==","name":"scheduling-portal","full_name":"ow2-proactive/scheduling-portal","owner":{"login":"ow2-proactive","id":11553998,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNTUzOTk4","avatar_url":"https://avatars1.githubusercontent.com/u/11553998?v=4","gravatar_id":"","url":"https://api.github.com/users/ow2-proactive","html_url":"https://github.com/ow2-proactive","followers_url":"https://api.github.com/users/ow2-proactive/followers","following_url":"https://api.github.com/users/ow2-proactive/following{/other_user}","gists_url":"https://api.github.com/users/ow2-proactive/gists{/gist_id}","starred_url":"https://api.github.com/users/ow2-proactive/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ow2-proactive/subscriptions","organizations_url":"https://api.github.com/users/ow2-proactive/orgs","repos_url":"https://api.github.com/users/ow2-proactive/repos","events_url":"https://api.github.com/users/ow2-proactive/events{/privacy}","received_events_url":"https://api.github.com/users/ow2-proactive/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ow2-proactive/scheduling-portal","description":null,"fork":false,"url":"https://api.github.com/repos/ow2-proactive/scheduling-portal","forks_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/forks","keys_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/teams","hooks_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/hooks","issue_events_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/issues/events{/number}","events_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/events","assignees_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/assignees{/user}","branches_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/branches{/branch}","tags_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/tags","blobs_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/git/refs{/sha}","trees_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/statuses/{sha}","languages_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/languages","stargazers_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/stargazers","contributors_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/contributors","subscribers_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/subscribers","subscription_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/subscription","commits_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/commits{/sha}","git_commits_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/git/commits{/sha}","comments_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/comments{/number}","issue_comment_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/issues/comments{/number}","contents_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/contents/{+path}","compare_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/merges","archive_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/downloads","issues_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/issues{/number}","pulls_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/pulls{/number}","milestones_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/milestones{/number}","notifications_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/labels{/name}","releases_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/releases{/id}","deployments_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/deployments","created_at":"2015-05-16T13:38:55Z","updated_at":"2018-05-20T20:55:18Z","pushed_at":"2018-05-31T07:26:45Z","git_url":"git://github.com/ow2-proactive/scheduling-portal.git","ssh_url":"[email protected]:ow2-proactive/scheduling-portal.git","clone_url":"https://github.com/ow2-proactive/scheduling-portal.git","svn_url":"https://github.com/ow2-proactive/scheduling-portal","homepage":"http://try.activeeon.com","size":118946,"stargazers_count":3,"watchers_count":3,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":29,"mirror_url":null,"archived":false,"open_issues_count":61,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":29,"open_issues":61,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ow2-proactive/scheduling-portal/pulls/449"},"html":{"href":"https://github.com/ow2-proactive/scheduling-portal/pull/449"},"issue":{"href":"https://api.github.com/repos/ow2-proactive/scheduling-portal/issues/449"},"comments":{"href":"https://api.github.com/repos/ow2-proactive/scheduling-portal/issues/449/comments"},"review_comments":{"href":"https://api.github.com/repos/ow2-proactive/scheduling-portal/pulls/449/comments"},"review_comment":{"href":"https://api.github.com/repos/ow2-proactive/scheduling-portal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ow2-proactive/scheduling-portal/pulls/449/commits"},"statuses":{"href":"https://api.github.com/repos/ow2-proactive/scheduling-portal/statuses/0da88c8949261120538f699d96294073127973b9"}},"author_association":"CONTRIBUTOR"}} | {
"id": 35725080,
"name": "ow2-proactive/scheduling-portal",
"url": "https://api.github.com/repos/ow2-proactive/scheduling-portal"
} | {
"id": 14940028,
"login": "sonarqube-activeeon",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/14940028?",
"url": "https://api.github.com/users/sonarqube-activeeon"
} | {
"id": 11553998,
"login": "ow2-proactive",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/11553998?",
"url": "https://api.github.com/orgs/ow2-proactive"
} | 2018-05-31T07:37:12 | 7754664077 | {"actor":{"display_login":"sonarqube-activeeon"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/oppia/oppia/pulls/comments/201462897","pull_request_review_id":135970730,"id":201462897,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMTQ2Mjg5Nw==","diff_hunk":"@@ -120,27 +120,27 @@\n \n .bottom-nav-row:before,\n .bottom-nav-row:after {\n- content:\"\";\n- display: table ;\n- clear:both;\n+ content:\"\";\n+ display: table ;\n+ clear:both;","path":"core/templates/dev/head/pages/exploration_player/conversation_skin_embed_directive.html","position":9,"original_position":9,"commit_id":"5f9e79fb51a235aa87adae3b2178f73bd8587f1e","original_commit_id":"5f9e79fb51a235aa87adae3b2178f73bd8587f1e","user":{"login":"kevinlee12","id":5758256,"node_id":"MDQ6VXNlcjU3NTgyNTY=","avatar_url":"https://avatars0.githubusercontent.com/u/5758256?v=4","gravatar_id":"","url":"https://api.github.com/users/kevinlee12","html_url":"https://github.com/kevinlee12","followers_url":"https://api.github.com/users/kevinlee12/followers","following_url":"https://api.github.com/users/kevinlee12/following{/other_user}","gists_url":"https://api.github.com/users/kevinlee12/gists{/gist_id}","starred_url":"https://api.github.com/users/kevinlee12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevinlee12/subscriptions","organizations_url":"https://api.github.com/users/kevinlee12/orgs","repos_url":"https://api.github.com/users/kevinlee12/repos","events_url":"https://api.github.com/users/kevinlee12/events{/privacy}","received_events_url":"https://api.github.com/users/kevinlee12/received_events","type":"User","site_admin":false},"body":"Ditto","created_at":"2018-07-10T19:17:09Z","updated_at":"2018-07-10T19:17:44Z","html_url":"https://github.com/oppia/oppia/pull/5242#discussion_r201462897","pull_request_url":"https://api.github.com/repos/oppia/oppia/pulls/5242","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/oppia/oppia/pulls/comments/201462897"},"html":{"href":"https://github.com/oppia/oppia/pull/5242#discussion_r201462897"},"pull_request":{"href":"https://api.github.com/repos/oppia/oppia/pulls/5242"}}},"pull_request":{"url":"https://api.github.com/repos/oppia/oppia/pulls/5242","id":200337368,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAwMzM3MzY4","html_url":"https://github.com/oppia/oppia/pull/5242","diff_url":"https://github.com/oppia/oppia/pull/5242.diff","patch_url":"https://github.com/oppia/oppia/pull/5242.patch","issue_url":"https://api.github.com/repos/oppia/oppia/issues/5242","number":5242,"state":"open","locked":false,"title":"Improving the dev workflow: Enable indent rule for CSS","user":{"login":"apb7","id":24826041,"node_id":"MDQ6VXNlcjI0ODI2MDQx","avatar_url":"https://avatars2.githubusercontent.com/u/24826041?v=4","gravatar_id":"","url":"https://api.github.com/users/apb7","html_url":"https://github.com/apb7","followers_url":"https://api.github.com/users/apb7/followers","following_url":"https://api.github.com/users/apb7/following{/other_user}","gists_url":"https://api.github.com/users/apb7/gists{/gist_id}","starred_url":"https://api.github.com/users/apb7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apb7/subscriptions","organizations_url":"https://api.github.com/users/apb7/orgs","repos_url":"https://api.github.com/users/apb7/repos","events_url":"https://api.github.com/users/apb7/events{/privacy}","received_events_url":"https://api.github.com/users/apb7/received_events","type":"User","site_admin":false},"body":"<!--\r\n - Thanks for submitting code to Oppia! Please fill out the following as part of\r\n - your pull request so we can review your code more easily.\r\n -->\r\n\r\n## Explanation\r\n<!--\r\n - Explain what your PR does. If this PR fixes an existing bug, please include \r\n - \"Fixes #bugnum:\" in the explanation so that GitHub can auto-close the issue \r\n - when this PR is merged.\r\n -->\r\nThis pull request introduces the indent rule for CSS files.\r\n\r\n## Checklist\r\n- [ ] The PR title starts with \"Fix #bugnum: \", followed by a short, clear summary of the changes.\r\n- [ ] The PR explanation includes the words \"Fixes #bugnum: ...\".\r\n- [X] The linter/Karma presubmit checks have passed.\r\n - These should run automatically, but if not, you can manually trigger them locally using `python scripts/pre_commit_linter.py` and `bash scripts/run_frontend_tests.sh`.\r\n- [X] The PR is made from a branch that's **not** called \"develop\".\r\n- [X] The PR follows the [style guide](https://github.com/oppia/oppia/wiki/Coding-style-guide).\r\n- [X] The PR is assigned to an appropriate reviewer.\r\n - If you're a new contributor, please ask on [Gitter](https://gitter.im/oppia/oppia-chat) for someone to assign a reviewer.\r\n - If you're not sure who the appropriate reviewer is, please assign to the issue's \"owner\" -- see the \"talk-to\" label on the issue.\r\n","created_at":"2018-07-10T09:40:02Z","updated_at":"2018-07-10T19:17:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8280d6326aaa67b09771174eb13e50cedc37752b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/oppia/oppia/pulls/5242/commits","review_comments_url":"https://api.github.com/repos/oppia/oppia/pulls/5242/comments","review_comment_url":"https://api.github.com/repos/oppia/oppia/pulls/comments{/number}","comments_url":"https://api.github.com/repos/oppia/oppia/issues/5242/comments","statuses_url":"https://api.github.com/repos/oppia/oppia/statuses/5f9e79fb51a235aa87adae3b2178f73bd8587f1e","head":{"label":"apb7:css-indentation","ref":"css-indentation","sha":"5f9e79fb51a235aa87adae3b2178f73bd8587f1e","user":{"login":"apb7","id":24826041,"node_id":"MDQ6VXNlcjI0ODI2MDQx","avatar_url":"https://avatars2.githubusercontent.com/u/24826041?v=4","gravatar_id":"","url":"https://api.github.com/users/apb7","html_url":"https://github.com/apb7","followers_url":"https://api.github.com/users/apb7/followers","following_url":"https://api.github.com/users/apb7/following{/other_user}","gists_url":"https://api.github.com/users/apb7/gists{/gist_id}","starred_url":"https://api.github.com/users/apb7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apb7/subscriptions","organizations_url":"https://api.github.com/users/apb7/orgs","repos_url":"https://api.github.com/users/apb7/repos","events_url":"https://api.github.com/users/apb7/events{/privacy}","received_events_url":"https://api.github.com/users/apb7/received_events","type":"User","site_admin":false},"repo":{"id":139143157,"node_id":"MDEwOlJlcG9zaXRvcnkxMzkxNDMxNTc=","name":"oppia","full_name":"apb7/oppia","owner":{"login":"apb7","id":24826041,"node_id":"MDQ6VXNlcjI0ODI2MDQx","avatar_url":"https://avatars2.githubusercontent.com/u/24826041?v=4","gravatar_id":"","url":"https://api.github.com/users/apb7","html_url":"https://github.com/apb7","followers_url":"https://api.github.com/users/apb7/followers","following_url":"https://api.github.com/users/apb7/following{/other_user}","gists_url":"https://api.github.com/users/apb7/gists{/gist_id}","starred_url":"https://api.github.com/users/apb7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apb7/subscriptions","organizations_url":"https://api.github.com/users/apb7/orgs","repos_url":"https://api.github.com/users/apb7/repos","events_url":"https://api.github.com/users/apb7/events{/privacy}","received_events_url":"https://api.github.com/users/apb7/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/apb7/oppia","description":"Tool for collaboratively building interactive lessons.","fork":true,"url":"https://api.github.com/repos/apb7/oppia","forks_url":"https://api.github.com/repos/apb7/oppia/forks","keys_url":"https://api.github.com/repos/apb7/oppia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apb7/oppia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apb7/oppia/teams","hooks_url":"https://api.github.com/repos/apb7/oppia/hooks","issue_events_url":"https://api.github.com/repos/apb7/oppia/issues/events{/number}","events_url":"https://api.github.com/repos/apb7/oppia/events","assignees_url":"https://api.github.com/repos/apb7/oppia/assignees{/user}","branches_url":"https://api.github.com/repos/apb7/oppia/branches{/branch}","tags_url":"https://api.github.com/repos/apb7/oppia/tags","blobs_url":"https://api.github.com/repos/apb7/oppia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apb7/oppia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apb7/oppia/git/refs{/sha}","trees_url":"https://api.github.com/repos/apb7/oppia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apb7/oppia/statuses/{sha}","languages_url":"https://api.github.com/repos/apb7/oppia/languages","stargazers_url":"https://api.github.com/repos/apb7/oppia/stargazers","contributors_url":"https://api.github.com/repos/apb7/oppia/contributors","subscribers_url":"https://api.github.com/repos/apb7/oppia/subscribers","subscription_url":"https://api.github.com/repos/apb7/oppia/subscription","commits_url":"https://api.github.com/repos/apb7/oppia/commits{/sha}","git_commits_url":"https://api.github.com/repos/apb7/oppia/git/commits{/sha}","comments_url":"https://api.github.com/repos/apb7/oppia/comments{/number}","issue_comment_url":"https://api.github.com/repos/apb7/oppia/issues/comments{/number}","contents_url":"https://api.github.com/repos/apb7/oppia/contents/{+path}","compare_url":"https://api.github.com/repos/apb7/oppia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apb7/oppia/merges","archive_url":"https://api.github.com/repos/apb7/oppia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apb7/oppia/downloads","issues_url":"https://api.github.com/repos/apb7/oppia/issues{/number}","pulls_url":"https://api.github.com/repos/apb7/oppia/pulls{/number}","milestones_url":"https://api.github.com/repos/apb7/oppia/milestones{/number}","notifications_url":"https://api.github.com/repos/apb7/oppia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apb7/oppia/labels{/name}","releases_url":"https://api.github.com/repos/apb7/oppia/releases{/id}","deployments_url":"https://api.github.com/repos/apb7/oppia/deployments","created_at":"2018-06-29T11:48:59Z","updated_at":"2018-06-29T11:49:06Z","pushed_at":"2018-07-10T17:23:43Z","git_url":"git://github.com/apb7/oppia.git","ssh_url":"[email protected]:apb7/oppia.git","clone_url":"https://github.com/apb7/oppia.git","svn_url":"https://github.com/apb7/oppia","homepage":"https://www.oppia.org","size":105123,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"oppia:develop","ref":"develop","sha":"555635aa23e79f81e7e7e5e70d057c60c51c2add","user":{"login":"oppia","id":11620230,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNjIwMjMw","avatar_url":"https://avatars1.githubusercontent.com/u/11620230?v=4","gravatar_id":"","url":"https://api.github.com/users/oppia","html_url":"https://github.com/oppia","followers_url":"https://api.github.com/users/oppia/followers","following_url":"https://api.github.com/users/oppia/following{/other_user}","gists_url":"https://api.github.com/users/oppia/gists{/gist_id}","starred_url":"https://api.github.com/users/oppia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oppia/subscriptions","organizations_url":"https://api.github.com/users/oppia/orgs","repos_url":"https://api.github.com/users/oppia/repos","events_url":"https://api.github.com/users/oppia/events{/privacy}","received_events_url":"https://api.github.com/users/oppia/received_events","type":"Organization","site_admin":false},"repo":{"id":40687563,"node_id":"MDEwOlJlcG9zaXRvcnk0MDY4NzU2Mw==","name":"oppia","full_name":"oppia/oppia","owner":{"login":"oppia","id":11620230,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNjIwMjMw","avatar_url":"https://avatars1.githubusercontent.com/u/11620230?v=4","gravatar_id":"","url":"https://api.github.com/users/oppia","html_url":"https://github.com/oppia","followers_url":"https://api.github.com/users/oppia/followers","following_url":"https://api.github.com/users/oppia/following{/other_user}","gists_url":"https://api.github.com/users/oppia/gists{/gist_id}","starred_url":"https://api.github.com/users/oppia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oppia/subscriptions","organizations_url":"https://api.github.com/users/oppia/orgs","repos_url":"https://api.github.com/users/oppia/repos","events_url":"https://api.github.com/users/oppia/events{/privacy}","received_events_url":"https://api.github.com/users/oppia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/oppia/oppia","description":"Tool for collaboratively building interactive lessons.","fork":false,"url":"https://api.github.com/repos/oppia/oppia","forks_url":"https://api.github.com/repos/oppia/oppia/forks","keys_url":"https://api.github.com/repos/oppia/oppia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oppia/oppia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oppia/oppia/teams","hooks_url":"https://api.github.com/repos/oppia/oppia/hooks","issue_events_url":"https://api.github.com/repos/oppia/oppia/issues/events{/number}","events_url":"https://api.github.com/repos/oppia/oppia/events","assignees_url":"https://api.github.com/repos/oppia/oppia/assignees{/user}","branches_url":"https://api.github.com/repos/oppia/oppia/branches{/branch}","tags_url":"https://api.github.com/repos/oppia/oppia/tags","blobs_url":"https://api.github.com/repos/oppia/oppia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oppia/oppia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oppia/oppia/git/refs{/sha}","trees_url":"https://api.github.com/repos/oppia/oppia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oppia/oppia/statuses/{sha}","languages_url":"https://api.github.com/repos/oppia/oppia/languages","stargazers_url":"https://api.github.com/repos/oppia/oppia/stargazers","contributors_url":"https://api.github.com/repos/oppia/oppia/contributors","subscribers_url":"https://api.github.com/repos/oppia/oppia/subscribers","subscription_url":"https://api.github.com/repos/oppia/oppia/subscription","commits_url":"https://api.github.com/repos/oppia/oppia/commits{/sha}","git_commits_url":"https://api.github.com/repos/oppia/oppia/git/commits{/sha}","comments_url":"https://api.github.com/repos/oppia/oppia/comments{/number}","issue_comment_url":"https://api.github.com/repos/oppia/oppia/issues/comments{/number}","contents_url":"https://api.github.com/repos/oppia/oppia/contents/{+path}","compare_url":"https://api.github.com/repos/oppia/oppia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oppia/oppia/merges","archive_url":"https://api.github.com/repos/oppia/oppia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oppia/oppia/downloads","issues_url":"https://api.github.com/repos/oppia/oppia/issues{/number}","pulls_url":"https://api.github.com/repos/oppia/oppia/pulls{/number}","milestones_url":"https://api.github.com/repos/oppia/oppia/milestones{/number}","notifications_url":"https://api.github.com/repos/oppia/oppia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oppia/oppia/labels{/name}","releases_url":"https://api.github.com/repos/oppia/oppia/releases{/id}","deployments_url":"https://api.github.com/repos/oppia/oppia/deployments","created_at":"2015-08-14T00:16:14Z","updated_at":"2018-07-10T18:50:12Z","pushed_at":"2018-07-10T18:50:05Z","git_url":"git://github.com/oppia/oppia.git","ssh_url":"[email protected]:oppia/oppia.git","clone_url":"https://github.com/oppia/oppia.git","svn_url":"https://github.com/oppia/oppia","homepage":"https://www.oppia.org","size":105115,"stargazers_count":683,"watchers_count":683,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":649,"mirror_url":null,"archived":false,"open_issues_count":335,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":649,"open_issues":335,"watchers":683,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/oppia/oppia/pulls/5242"},"html":{"href":"https://github.com/oppia/oppia/pull/5242"},"issue":{"href":"https://api.github.com/repos/oppia/oppia/issues/5242"},"comments":{"href":"https://api.github.com/repos/oppia/oppia/issues/5242/comments"},"review_comments":{"href":"https://api.github.com/repos/oppia/oppia/pulls/5242/comments"},"review_comment":{"href":"https://api.github.com/repos/oppia/oppia/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/oppia/oppia/pulls/5242/commits"},"statuses":{"href":"https://api.github.com/repos/oppia/oppia/statuses/5f9e79fb51a235aa87adae3b2178f73bd8587f1e"}},"author_association":"CONTRIBUTOR"}} | {
"id": 40687563,
"name": "oppia/oppia",
"url": "https://api.github.com/repos/oppia/oppia"
} | {
"id": 5758256,
"login": "kevinlee12",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5758256?",
"url": "https://api.github.com/users/kevinlee12"
} | {
"id": 11620230,
"login": "oppia",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/11620230?",
"url": "https://api.github.com/orgs/oppia"
} | 2018-07-10T19:17:09 | 7945847761 | {"actor":{"display_login":"kevinlee12"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/oppia/oppia/pulls/comments/240045634","pull_request_review_id":182987267,"id":240045634,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MDA0NTYzNA==","diff_hunk":"@@ -1,5 +1,2 @@\n-{% if not DEV_MODE %}\n- <script src=\"/third_party/generated/js/third_party.min.js\"></script>\n-{% else %}\n- <script src=\"/third_party/generated/js/third_party.js\"></script>\n-{% endif %}\n+<script src=\"/third_party/generated/js/third_party.js\" ng-if=\"inDevMode\"></script>","path":"core/templates/dev/head/pages/footer_js_libs.html","position":6,"original_position":6,"commit_id":"9fedb41ba9f35d5e405df7cc61e6c1cecb2525e9","original_commit_id":"9fedb41ba9f35d5e405df7cc61e6c1cecb2525e9","user":{"login":"vojtechjelinek","id":10142938,"node_id":"MDQ6VXNlcjEwMTQyOTM4","avatar_url":"https://avatars0.githubusercontent.com/u/10142938?v=4","gravatar_id":"","url":"https://api.github.com/users/vojtechjelinek","html_url":"https://github.com/vojtechjelinek","followers_url":"https://api.github.com/users/vojtechjelinek/followers","following_url":"https://api.github.com/users/vojtechjelinek/following{/other_user}","gists_url":"https://api.github.com/users/vojtechjelinek/gists{/gist_id}","starred_url":"https://api.github.com/users/vojtechjelinek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vojtechjelinek/subscriptions","organizations_url":"https://api.github.com/users/vojtechjelinek/orgs","repos_url":"https://api.github.com/users/vojtechjelinek/repos","events_url":"https://api.github.com/users/vojtechjelinek/events{/privacy}","received_events_url":"https://api.github.com/users/vojtechjelinek/received_events","type":"User","site_admin":false},"body":"`/core/templates/dev/head/pages/admin/Admin.js` is not used in most pages `/core/templates/dev/head/pages/Base.js` is used mostly. But I'm not sure if the variable is available in footer_js_libs.js","created_at":"2018-12-09T17:30:41Z","updated_at":"2018-12-09T17:30:42Z","html_url":"https://github.com/oppia/oppia/pull/5937#discussion_r240045634","pull_request_url":"https://api.github.com/repos/oppia/oppia/pulls/5937","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/oppia/oppia/pulls/comments/240045634"},"html":{"href":"https://github.com/oppia/oppia/pull/5937#discussion_r240045634"},"pull_request":{"href":"https://api.github.com/repos/oppia/oppia/pulls/5937"}},"in_reply_to_id":239703217},"pull_request":{"url":"https://api.github.com/repos/oppia/oppia/pulls/5937","id":235240442,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM1MjQwNDQy","html_url":"https://github.com/oppia/oppia/pull/5937","diff_url":"https://github.com/oppia/oppia/pull/5937.diff","patch_url":"https://github.com/oppia/oppia/pull/5937.patch","issue_url":"https://api.github.com/repos/oppia/oppia/issues/5937","number":5937,"state":"open","locked":false,"title":"Fix part of #3950: replace jinja templates from footer_js_libs.html","user":{"login":"gurungrahul2","id":30543444,"node_id":"MDQ6VXNlcjMwNTQzNDQ0","avatar_url":"https://avatars2.githubusercontent.com/u/30543444?v=4","gravatar_id":"","url":"https://api.github.com/users/gurungrahul2","html_url":"https://github.com/gurungrahul2","followers_url":"https://api.github.com/users/gurungrahul2/followers","following_url":"https://api.github.com/users/gurungrahul2/following{/other_user}","gists_url":"https://api.github.com/users/gurungrahul2/gists{/gist_id}","starred_url":"https://api.github.com/users/gurungrahul2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gurungrahul2/subscriptions","organizations_url":"https://api.github.com/users/gurungrahul2/orgs","repos_url":"https://api.github.com/users/gurungrahul2/repos","events_url":"https://api.github.com/users/gurungrahul2/events{/privacy}","received_events_url":"https://api.github.com/users/gurungrahul2/received_events","type":"User","site_admin":false},"body":"<!--\r\n - Thanks for submitting code to Oppia! Please fill out the following as part of\r\n - your pull request so we can review your code more easily.\r\n -->\r\n\r\n## Explanation\r\n<!--\r\n - Explain what your PR does. If this PR fixes an existing bug, please include\r\n - \"Fixes #bugnum:\" in the explanation so that GitHub can auto-close the issue\r\n - when this PR is merged.\r\n -->\r\nFix part of #3950: replace jinja templates from footer_js_libs.html\r\n## Checklist\r\n- [x] The PR title starts with \"Fix #bugnum: \", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with \"Fix part of #bugnum: ...\".)\r\n- [x] The PR explanation includes the words \"Fixes #bugnum: ...\" (or \"Fixes part of #bugnum\" if the PR only partially fixes an issue).\r\n- [x] The linter/Karma presubmit checks have passed.\r\n - These should run automatically, but if not, you can manually trigger them locally using `python scripts/pre_commit_linter.py` and `bash scripts/run_frontend_tests.sh`.\r\n- [x] The PR is made from a branch that's **not** called \"develop\".\r\n- [x] The PR follows the [style guide](https://github.com/oppia/oppia/wiki/Coding-style-guide).\r\n- [ ] The PR is assigned to an appropriate reviewer.\r\n - If you're a new contributor, please ask on [Gitter](https://gitter.im/oppia/oppia-chat) for someone to assign a reviewer.\r\n - If you're not sure who the appropriate reviewer is, please assign to the issue's \"owner\" -- see the \"talk-to\" label on the issue.\r\n","created_at":"2018-12-02T06:12:35Z","updated_at":"2018-12-09T17:30:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0ad088c33d27d0253c08dcdc8b804666551032dc","assignee":{"login":"gurungrahul2","id":30543444,"node_id":"MDQ6VXNlcjMwNTQzNDQ0","avatar_url":"https://avatars2.githubusercontent.com/u/30543444?v=4","gravatar_id":"","url":"https://api.github.com/users/gurungrahul2","html_url":"https://github.com/gurungrahul2","followers_url":"https://api.github.com/users/gurungrahul2/followers","following_url":"https://api.github.com/users/gurungrahul2/following{/other_user}","gists_url":"https://api.github.com/users/gurungrahul2/gists{/gist_id}","starred_url":"https://api.github.com/users/gurungrahul2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gurungrahul2/subscriptions","organizations_url":"https://api.github.com/users/gurungrahul2/orgs","repos_url":"https://api.github.com/users/gurungrahul2/repos","events_url":"https://api.github.com/users/gurungrahul2/events{/privacy}","received_events_url":"https://api.github.com/users/gurungrahul2/received_events","type":"User","site_admin":false},"assignees":[{"login":"gurungrahul2","id":30543444,"node_id":"MDQ6VXNlcjMwNTQzNDQ0","avatar_url":"https://avatars2.githubusercontent.com/u/30543444?v=4","gravatar_id":"","url":"https://api.github.com/users/gurungrahul2","html_url":"https://github.com/gurungrahul2","followers_url":"https://api.github.com/users/gurungrahul2/followers","following_url":"https://api.github.com/users/gurungrahul2/following{/other_user}","gists_url":"https://api.github.com/users/gurungrahul2/gists{/gist_id}","starred_url":"https://api.github.com/users/gurungrahul2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gurungrahul2/subscriptions","organizations_url":"https://api.github.com/users/gurungrahul2/orgs","repos_url":"https://api.github.com/users/gurungrahul2/repos","events_url":"https://api.github.com/users/gurungrahul2/events{/privacy}","received_events_url":"https://api.github.com/users/gurungrahul2/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"vojtechjelinek","id":10142938,"node_id":"MDQ6VXNlcjEwMTQyOTM4","avatar_url":"https://avatars0.githubusercontent.com/u/10142938?v=4","gravatar_id":"","url":"https://api.github.com/users/vojtechjelinek","html_url":"https://github.com/vojtechjelinek","followers_url":"https://api.github.com/users/vojtechjelinek/followers","following_url":"https://api.github.com/users/vojtechjelinek/following{/other_user}","gists_url":"https://api.github.com/users/vojtechjelinek/gists{/gist_id}","starred_url":"https://api.github.com/users/vojtechjelinek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vojtechjelinek/subscriptions","organizations_url":"https://api.github.com/users/vojtechjelinek/orgs","repos_url":"https://api.github.com/users/vojtechjelinek/repos","events_url":"https://api.github.com/users/vojtechjelinek/events{/privacy}","received_events_url":"https://api.github.com/users/vojtechjelinek/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/oppia/oppia/pulls/5937/commits","review_comments_url":"https://api.github.com/repos/oppia/oppia/pulls/5937/comments","review_comment_url":"https://api.github.com/repos/oppia/oppia/pulls/comments{/number}","comments_url":"https://api.github.com/repos/oppia/oppia/issues/5937/comments","statuses_url":"https://api.github.com/repos/oppia/oppia/statuses/9fedb41ba9f35d5e405df7cc61e6c1cecb2525e9","head":{"label":"gurungrahul2:footerjs","ref":"footerjs","sha":"9fedb41ba9f35d5e405df7cc61e6c1cecb2525e9","user":{"login":"gurungrahul2","id":30543444,"node_id":"MDQ6VXNlcjMwNTQzNDQ0","avatar_url":"https://avatars2.githubusercontent.com/u/30543444?v=4","gravatar_id":"","url":"https://api.github.com/users/gurungrahul2","html_url":"https://github.com/gurungrahul2","followers_url":"https://api.github.com/users/gurungrahul2/followers","following_url":"https://api.github.com/users/gurungrahul2/following{/other_user}","gists_url":"https://api.github.com/users/gurungrahul2/gists{/gist_id}","starred_url":"https://api.github.com/users/gurungrahul2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gurungrahul2/subscriptions","organizations_url":"https://api.github.com/users/gurungrahul2/orgs","repos_url":"https://api.github.com/users/gurungrahul2/repos","events_url":"https://api.github.com/users/gurungrahul2/events{/privacy}","received_events_url":"https://api.github.com/users/gurungrahul2/received_events","type":"User","site_admin":false},"repo":{"id":158961655,"node_id":"MDEwOlJlcG9zaXRvcnkxNTg5NjE2NTU=","name":"oppia","full_name":"gurungrahul2/oppia","private":false,"owner":{"login":"gurungrahul2","id":30543444,"node_id":"MDQ6VXNlcjMwNTQzNDQ0","avatar_url":"https://avatars2.githubusercontent.com/u/30543444?v=4","gravatar_id":"","url":"https://api.github.com/users/gurungrahul2","html_url":"https://github.com/gurungrahul2","followers_url":"https://api.github.com/users/gurungrahul2/followers","following_url":"https://api.github.com/users/gurungrahul2/following{/other_user}","gists_url":"https://api.github.com/users/gurungrahul2/gists{/gist_id}","starred_url":"https://api.github.com/users/gurungrahul2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gurungrahul2/subscriptions","organizations_url":"https://api.github.com/users/gurungrahul2/orgs","repos_url":"https://api.github.com/users/gurungrahul2/repos","events_url":"https://api.github.com/users/gurungrahul2/events{/privacy}","received_events_url":"https://api.github.com/users/gurungrahul2/received_events","type":"User","site_admin":false},"html_url":"https://github.com/gurungrahul2/oppia","description":"Tool for collaboratively building interactive lessons.","fork":true,"url":"https://api.github.com/repos/gurungrahul2/oppia","forks_url":"https://api.github.com/repos/gurungrahul2/oppia/forks","keys_url":"https://api.github.com/repos/gurungrahul2/oppia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gurungrahul2/oppia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gurungrahul2/oppia/teams","hooks_url":"https://api.github.com/repos/gurungrahul2/oppia/hooks","issue_events_url":"https://api.github.com/repos/gurungrahul2/oppia/issues/events{/number}","events_url":"https://api.github.com/repos/gurungrahul2/oppia/events","assignees_url":"https://api.github.com/repos/gurungrahul2/oppia/assignees{/user}","branches_url":"https://api.github.com/repos/gurungrahul2/oppia/branches{/branch}","tags_url":"https://api.github.com/repos/gurungrahul2/oppia/tags","blobs_url":"https://api.github.com/repos/gurungrahul2/oppia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gurungrahul2/oppia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gurungrahul2/oppia/git/refs{/sha}","trees_url":"https://api.github.com/repos/gurungrahul2/oppia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gurungrahul2/oppia/statuses/{sha}","languages_url":"https://api.github.com/repos/gurungrahul2/oppia/languages","stargazers_url":"https://api.github.com/repos/gurungrahul2/oppia/stargazers","contributors_url":"https://api.github.com/repos/gurungrahul2/oppia/contributors","subscribers_url":"https://api.github.com/repos/gurungrahul2/oppia/subscribers","subscription_url":"https://api.github.com/repos/gurungrahul2/oppia/subscription","commits_url":"https://api.github.com/repos/gurungrahul2/oppia/commits{/sha}","git_commits_url":"https://api.github.com/repos/gurungrahul2/oppia/git/commits{/sha}","comments_url":"https://api.github.com/repos/gurungrahul2/oppia/comments{/number}","issue_comment_url":"https://api.github.com/repos/gurungrahul2/oppia/issues/comments{/number}","contents_url":"https://api.github.com/repos/gurungrahul2/oppia/contents/{+path}","compare_url":"https://api.github.com/repos/gurungrahul2/oppia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gurungrahul2/oppia/merges","archive_url":"https://api.github.com/repos/gurungrahul2/oppia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gurungrahul2/oppia/downloads","issues_url":"https://api.github.com/repos/gurungrahul2/oppia/issues{/number}","pulls_url":"https://api.github.com/repos/gurungrahul2/oppia/pulls{/number}","milestones_url":"https://api.github.com/repos/gurungrahul2/oppia/milestones{/number}","notifications_url":"https://api.github.com/repos/gurungrahul2/oppia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gurungrahul2/oppia/labels{/name}","releases_url":"https://api.github.com/repos/gurungrahul2/oppia/releases{/id}","deployments_url":"https://api.github.com/repos/gurungrahul2/oppia/deployments","created_at":"2018-11-24T18:08:53Z","updated_at":"2018-12-02T04:34:18Z","pushed_at":"2018-12-07T03:16:33Z","git_url":"git://github.com/gurungrahul2/oppia.git","ssh_url":"[email protected]:gurungrahul2/oppia.git","clone_url":"https://github.com/gurungrahul2/oppia.git","svn_url":"https://github.com/gurungrahul2/oppia","homepage":"https://www.oppia.org","size":108634,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"oppia:develop","ref":"develop","sha":"d4a4df42befee6b95a2d23df841a429bf433de2e","user":{"login":"oppia","id":11620230,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNjIwMjMw","avatar_url":"https://avatars1.githubusercontent.com/u/11620230?v=4","gravatar_id":"","url":"https://api.github.com/users/oppia","html_url":"https://github.com/oppia","followers_url":"https://api.github.com/users/oppia/followers","following_url":"https://api.github.com/users/oppia/following{/other_user}","gists_url":"https://api.github.com/users/oppia/gists{/gist_id}","starred_url":"https://api.github.com/users/oppia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oppia/subscriptions","organizations_url":"https://api.github.com/users/oppia/orgs","repos_url":"https://api.github.com/users/oppia/repos","events_url":"https://api.github.com/users/oppia/events{/privacy}","received_events_url":"https://api.github.com/users/oppia/received_events","type":"Organization","site_admin":false},"repo":{"id":40687563,"node_id":"MDEwOlJlcG9zaXRvcnk0MDY4NzU2Mw==","name":"oppia","full_name":"oppia/oppia","private":false,"owner":{"login":"oppia","id":11620230,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNjIwMjMw","avatar_url":"https://avatars1.githubusercontent.com/u/11620230?v=4","gravatar_id":"","url":"https://api.github.com/users/oppia","html_url":"https://github.com/oppia","followers_url":"https://api.github.com/users/oppia/followers","following_url":"https://api.github.com/users/oppia/following{/other_user}","gists_url":"https://api.github.com/users/oppia/gists{/gist_id}","starred_url":"https://api.github.com/users/oppia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oppia/subscriptions","organizations_url":"https://api.github.com/users/oppia/orgs","repos_url":"https://api.github.com/users/oppia/repos","events_url":"https://api.github.com/users/oppia/events{/privacy}","received_events_url":"https://api.github.com/users/oppia/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/oppia/oppia","description":"Tool for collaboratively building interactive lessons.","fork":false,"url":"https://api.github.com/repos/oppia/oppia","forks_url":"https://api.github.com/repos/oppia/oppia/forks","keys_url":"https://api.github.com/repos/oppia/oppia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oppia/oppia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oppia/oppia/teams","hooks_url":"https://api.github.com/repos/oppia/oppia/hooks","issue_events_url":"https://api.github.com/repos/oppia/oppia/issues/events{/number}","events_url":"https://api.github.com/repos/oppia/oppia/events","assignees_url":"https://api.github.com/repos/oppia/oppia/assignees{/user}","branches_url":"https://api.github.com/repos/oppia/oppia/branches{/branch}","tags_url":"https://api.github.com/repos/oppia/oppia/tags","blobs_url":"https://api.github.com/repos/oppia/oppia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oppia/oppia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oppia/oppia/git/refs{/sha}","trees_url":"https://api.github.com/repos/oppia/oppia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oppia/oppia/statuses/{sha}","languages_url":"https://api.github.com/repos/oppia/oppia/languages","stargazers_url":"https://api.github.com/repos/oppia/oppia/stargazers","contributors_url":"https://api.github.com/repos/oppia/oppia/contributors","subscribers_url":"https://api.github.com/repos/oppia/oppia/subscribers","subscription_url":"https://api.github.com/repos/oppia/oppia/subscription","commits_url":"https://api.github.com/repos/oppia/oppia/commits{/sha}","git_commits_url":"https://api.github.com/repos/oppia/oppia/git/commits{/sha}","comments_url":"https://api.github.com/repos/oppia/oppia/comments{/number}","issue_comment_url":"https://api.github.com/repos/oppia/oppia/issues/comments{/number}","contents_url":"https://api.github.com/repos/oppia/oppia/contents/{+path}","compare_url":"https://api.github.com/repos/oppia/oppia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oppia/oppia/merges","archive_url":"https://api.github.com/repos/oppia/oppia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oppia/oppia/downloads","issues_url":"https://api.github.com/repos/oppia/oppia/issues{/number}","pulls_url":"https://api.github.com/repos/oppia/oppia/pulls{/number}","milestones_url":"https://api.github.com/repos/oppia/oppia/milestones{/number}","notifications_url":"https://api.github.com/repos/oppia/oppia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oppia/oppia/labels{/name}","releases_url":"https://api.github.com/repos/oppia/oppia/releases{/id}","deployments_url":"https://api.github.com/repos/oppia/oppia/deployments","created_at":"2015-08-14T00:16:14Z","updated_at":"2018-12-08T06:20:24Z","pushed_at":"2018-12-09T15:53:21Z","git_url":"git://github.com/oppia/oppia.git","ssh_url":"[email protected]:oppia/oppia.git","clone_url":"https://github.com/oppia/oppia.git","svn_url":"https://github.com/oppia/oppia","homepage":"https://www.oppia.org","size":108727,"stargazers_count":833,"watchers_count":833,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":822,"mirror_url":null,"archived":false,"open_issues_count":410,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":822,"open_issues":410,"watchers":833,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/oppia/oppia/pulls/5937"},"html":{"href":"https://github.com/oppia/oppia/pull/5937"},"issue":{"href":"https://api.github.com/repos/oppia/oppia/issues/5937"},"comments":{"href":"https://api.github.com/repos/oppia/oppia/issues/5937/comments"},"review_comments":{"href":"https://api.github.com/repos/oppia/oppia/pulls/5937/comments"},"review_comment":{"href":"https://api.github.com/repos/oppia/oppia/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/oppia/oppia/pulls/5937/commits"},"statuses":{"href":"https://api.github.com/repos/oppia/oppia/statuses/9fedb41ba9f35d5e405df7cc61e6c1cecb2525e9"}},"author_association":"NONE"}} | {
"id": 40687563,
"name": "oppia/oppia",
"url": "https://api.github.com/repos/oppia/oppia"
} | {
"id": 10142938,
"login": "vojtechjelinek",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/10142938?",
"url": "https://api.github.com/users/vojtechjelinek"
} | {
"id": 11620230,
"login": "oppia",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/11620230?",
"url": "https://api.github.com/orgs/oppia"
} | 2018-12-09T17:30:41 | 8722965328 | {"actor":{"display_login":"vojtechjelinek"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/status-im/status-react/pulls/comments/191169290","pull_request_review_id":123690248,"id":191169290,"diff_hunk":"@@ -18,25 +18,36 @@\n [status-im.transport.message.v1.group-chat :as v1.group-chat]\n [status-im.data-store.transport :as transport-store]))\n \n-(defn receive-message [cofx chat-id js-message]\n- (let [{:keys [payload sig]} (js->clj js-message :keywordize-keys true)\n+(defn update-last-received-from-inbox","path":"src/status_im/transport/handlers.cljs","position":6,"original_position":6,"commit_id":"a4d800ca1e03a586cb1736947c9070ca85e02434","original_commit_id":"a4d800ca1e03a586cb1736947c9070ca85e02434","user":{"login":"cammellos","id":1017008,"avatar_url":"https://avatars0.githubusercontent.com/u/1017008?v=4","gravatar_id":"","url":"https://api.github.com/users/cammellos","html_url":"https://github.com/cammellos","followers_url":"https://api.github.com/users/cammellos/followers","following_url":"https://api.github.com/users/cammellos/following{/other_user}","gists_url":"https://api.github.com/users/cammellos/gists{/gist_id}","starred_url":"https://api.github.com/users/cammellos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cammellos/subscriptions","organizations_url":"https://api.github.com/users/cammellos/orgs","repos_url":"https://api.github.com/users/cammellos/repos","events_url":"https://api.github.com/users/cammellos/events{/privacy}","received_events_url":"https://api.github.com/users/cammellos/received_events","type":"User","site_admin":false},"body":"Ah no, sorry my bad, you set it to `now`, I thought you were setting it to `timestamp`","created_at":"2018-05-28T10:13:47Z","updated_at":"2018-05-28T10:13:47Z","html_url":"https://github.com/status-im/status-react/pull/4481#discussion_r191169290","pull_request_url":"https://api.github.com/repos/status-im/status-react/pulls/4481","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/status-im/status-react/pulls/comments/191169290"},"html":{"href":"https://github.com/status-im/status-react/pull/4481#discussion_r191169290"},"pull_request":{"href":"https://api.github.com/repos/status-im/status-react/pulls/4481"}},"in_reply_to_id":191169156},"pull_request":{"url":"https://api.github.com/repos/status-im/status-react/pulls/4481","id":190885760,"html_url":"https://github.com/status-im/status-react/pull/4481","diff_url":"https://github.com/status-im/status-react/pull/4481.diff","patch_url":"https://github.com/status-im/status-react/pull/4481.patch","issue_url":"https://api.github.com/repos/status-im/status-react/issues/4481","number":4481,"state":"open","locked":false,"title":"Feature/use from param","user":{"login":"yenda","id":1181225,"avatar_url":"https://avatars1.githubusercontent.com/u/1181225?v=4","gravatar_id":"","url":"https://api.github.com/users/yenda","html_url":"https://github.com/yenda","followers_url":"https://api.github.com/users/yenda/followers","following_url":"https://api.github.com/users/yenda/following{/other_user}","gists_url":"https://api.github.com/users/yenda/gists{/gist_id}","starred_url":"https://api.github.com/users/yenda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yenda/subscriptions","organizations_url":"https://api.github.com/users/yenda/orgs","repos_url":"https://api.github.com/users/yenda/repos","events_url":"https://api.github.com/users/yenda/events{/privacy}","received_events_url":"https://api.github.com/users/yenda/received_events","type":"User","site_admin":false},"body":"The first commit in this PR can be ignored as it is alreay in #4467 \r\nThe second commit introduces a way to differentiate mailserver messages from other whisper messages to keep a timestamp of the last mailserver message received. To do that we compare current time with message time stamp + ttl, if message is expired it comes from the mailserver.\r\nFinally the third commit reimplement a similar mechanism to what was proposed in #4230 except that the :last-request is only updated 10 seconds after the latest message from mailserver has been received without a change of connection state:\r\n\r\nWhen logging in, request messages from last-request for all chats, except chats added while offline for which we request full history. Same when connectivity is re-established after connectivity loss\r\nWhen adding a chat, request full history for the chat \r\n\r\nstatus: ready\r\n","created_at":"2018-05-28T09:47:21Z","updated_at":"2018-05-28T10:13:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cd48bc6c34931ab1cf9273b00a7da9802f7ea9bf","assignee":{"login":"yenda","id":1181225,"avatar_url":"https://avatars1.githubusercontent.com/u/1181225?v=4","gravatar_id":"","url":"https://api.github.com/users/yenda","html_url":"https://github.com/yenda","followers_url":"https://api.github.com/users/yenda/followers","following_url":"https://api.github.com/users/yenda/following{/other_user}","gists_url":"https://api.github.com/users/yenda/gists{/gist_id}","starred_url":"https://api.github.com/users/yenda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yenda/subscriptions","organizations_url":"https://api.github.com/users/yenda/orgs","repos_url":"https://api.github.com/users/yenda/repos","events_url":"https://api.github.com/users/yenda/events{/privacy}","received_events_url":"https://api.github.com/users/yenda/received_events","type":"User","site_admin":false},"assignees":[{"login":"yenda","id":1181225,"avatar_url":"https://avatars1.githubusercontent.com/u/1181225?v=4","gravatar_id":"","url":"https://api.github.com/users/yenda","html_url":"https://github.com/yenda","followers_url":"https://api.github.com/users/yenda/followers","following_url":"https://api.github.com/users/yenda/following{/other_user}","gists_url":"https://api.github.com/users/yenda/gists{/gist_id}","starred_url":"https://api.github.com/users/yenda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yenda/subscriptions","organizations_url":"https://api.github.com/users/yenda/orgs","repos_url":"https://api.github.com/users/yenda/repos","events_url":"https://api.github.com/users/yenda/events{/privacy}","received_events_url":"https://api.github.com/users/yenda/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"dmitryn","id":23836,"avatar_url":"https://avatars2.githubusercontent.com/u/23836?v=4","gravatar_id":"","url":"https://api.github.com/users/dmitryn","html_url":"https://github.com/dmitryn","followers_url":"https://api.github.com/users/dmitryn/followers","following_url":"https://api.github.com/users/dmitryn/following{/other_user}","gists_url":"https://api.github.com/users/dmitryn/gists{/gist_id}","starred_url":"https://api.github.com/users/dmitryn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmitryn/subscriptions","organizations_url":"https://api.github.com/users/dmitryn/orgs","repos_url":"https://api.github.com/users/dmitryn/repos","events_url":"https://api.github.com/users/dmitryn/events{/privacy}","received_events_url":"https://api.github.com/users/dmitryn/received_events","type":"User","site_admin":false},{"login":"janherich","id":1910609,"avatar_url":"https://avatars1.githubusercontent.com/u/1910609?v=4","gravatar_id":"","url":"https://api.github.com/users/janherich","html_url":"https://github.com/janherich","followers_url":"https://api.github.com/users/janherich/followers","following_url":"https://api.github.com/users/janherich/following{/other_user}","gists_url":"https://api.github.com/users/janherich/gists{/gist_id}","starred_url":"https://api.github.com/users/janherich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janherich/subscriptions","organizations_url":"https://api.github.com/users/janherich/orgs","repos_url":"https://api.github.com/users/janherich/repos","events_url":"https://api.github.com/users/janherich/events{/privacy}","received_events_url":"https://api.github.com/users/janherich/received_events","type":"User","site_admin":false},{"login":"rasom","id":2364994,"avatar_url":"https://avatars2.githubusercontent.com/u/2364994?v=4","gravatar_id":"","url":"https://api.github.com/users/rasom","html_url":"https://github.com/rasom","followers_url":"https://api.github.com/users/rasom/followers","following_url":"https://api.github.com/users/rasom/following{/other_user}","gists_url":"https://api.github.com/users/rasom/gists{/gist_id}","starred_url":"https://api.github.com/users/rasom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rasom/subscriptions","organizations_url":"https://api.github.com/users/rasom/orgs","repos_url":"https://api.github.com/users/rasom/repos","events_url":"https://api.github.com/users/rasom/events{/privacy}","received_events_url":"https://api.github.com/users/rasom/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":795655580,"url":"https://api.github.com/repos/status-im/status-react/labels/chat","name":"chat","color":"f70cb0","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/status-im/status-react/pulls/4481/commits","review_comments_url":"https://api.github.com/repos/status-im/status-react/pulls/4481/comments","review_comment_url":"https://api.github.com/repos/status-im/status-react/pulls/comments{/number}","comments_url":"https://api.github.com/repos/status-im/status-react/issues/4481/comments","statuses_url":"https://api.github.com/repos/status-im/status-react/statuses/a4d800ca1e03a586cb1736947c9070ca85e02434","head":{"label":"status-im:feature/use-from-param","ref":"feature/use-from-param","sha":"a4d800ca1e03a586cb1736947c9070ca85e02434","user":{"login":"status-im","id":11767950,"avatar_url":"https://avatars1.githubusercontent.com/u/11767950?v=4","gravatar_id":"","url":"https://api.github.com/users/status-im","html_url":"https://github.com/status-im","followers_url":"https://api.github.com/users/status-im/followers","following_url":"https://api.github.com/users/status-im/following{/other_user}","gists_url":"https://api.github.com/users/status-im/gists{/gist_id}","starred_url":"https://api.github.com/users/status-im/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/status-im/subscriptions","organizations_url":"https://api.github.com/users/status-im/orgs","repos_url":"https://api.github.com/users/status-im/repos","events_url":"https://api.github.com/users/status-im/events{/privacy}","received_events_url":"https://api.github.com/users/status-im/received_events","type":"Organization","site_admin":false},"repo":{"id":52308441,"name":"status-react","full_name":"status-im/status-react","owner":{"login":"status-im","id":11767950,"avatar_url":"https://avatars1.githubusercontent.com/u/11767950?v=4","gravatar_id":"","url":"https://api.github.com/users/status-im","html_url":"https://github.com/status-im","followers_url":"https://api.github.com/users/status-im/followers","following_url":"https://api.github.com/users/status-im/following{/other_user}","gists_url":"https://api.github.com/users/status-im/gists{/gist_id}","starred_url":"https://api.github.com/users/status-im/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/status-im/subscriptions","organizations_url":"https://api.github.com/users/status-im/orgs","repos_url":"https://api.github.com/users/status-im/repos","events_url":"https://api.github.com/users/status-im/events{/privacy}","received_events_url":"https://api.github.com/users/status-im/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/status-im/status-react","description":"a free (libre) open source, mobile OS for Ethereum","fork":false,"url":"https://api.github.com/repos/status-im/status-react","forks_url":"https://api.github.com/repos/status-im/status-react/forks","keys_url":"https://api.github.com/repos/status-im/status-react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/status-im/status-react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/status-im/status-react/teams","hooks_url":"https://api.github.com/repos/status-im/status-react/hooks","issue_events_url":"https://api.github.com/repos/status-im/status-react/issues/events{/number}","events_url":"https://api.github.com/repos/status-im/status-react/events","assignees_url":"https://api.github.com/repos/status-im/status-react/assignees{/user}","branches_url":"https://api.github.com/repos/status-im/status-react/branches{/branch}","tags_url":"https://api.github.com/repos/status-im/status-react/tags","blobs_url":"https://api.github.com/repos/status-im/status-react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/status-im/status-react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/status-im/status-react/git/refs{/sha}","trees_url":"https://api.github.com/repos/status-im/status-react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/status-im/status-react/statuses/{sha}","languages_url":"https://api.github.com/repos/status-im/status-react/languages","stargazers_url":"https://api.github.com/repos/status-im/status-react/stargazers","contributors_url":"https://api.github.com/repos/status-im/status-react/contributors","subscribers_url":"https://api.github.com/repos/status-im/status-react/subscribers","subscription_url":"https://api.github.com/repos/status-im/status-react/subscription","commits_url":"https://api.github.com/repos/status-im/status-react/commits{/sha}","git_commits_url":"https://api.github.com/repos/status-im/status-react/git/commits{/sha}","comments_url":"https://api.github.com/repos/status-im/status-react/comments{/number}","issue_comment_url":"https://api.github.com/repos/status-im/status-react/issues/comments{/number}","contents_url":"https://api.github.com/repos/status-im/status-react/contents/{+path}","compare_url":"https://api.github.com/repos/status-im/status-react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/status-im/status-react/merges","archive_url":"https://api.github.com/repos/status-im/status-react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/status-im/status-react/downloads","issues_url":"https://api.github.com/repos/status-im/status-react/issues{/number}","pulls_url":"https://api.github.com/repos/status-im/status-react/pulls{/number}","milestones_url":"https://api.github.com/repos/status-im/status-react/milestones{/number}","notifications_url":"https://api.github.com/repos/status-im/status-react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/status-im/status-react/labels{/name}","releases_url":"https://api.github.com/repos/status-im/status-react/releases{/id}","deployments_url":"https://api.github.com/repos/status-im/status-react/deployments","created_at":"2016-02-22T21:48:48Z","updated_at":"2018-05-28T09:57:19Z","pushed_at":"2018-05-28T10:08:10Z","git_url":"git://github.com/status-im/status-react.git","ssh_url":"[email protected]:status-im/status-react.git","clone_url":"https://github.com/status-im/status-react.git","svn_url":"https://github.com/status-im/status-react","homepage":"https://status.im","size":55100,"stargazers_count":2238,"watchers_count":2238,"language":"Clojure","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":539,"mirror_url":null,"archived":false,"open_issues_count":618,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0"},"forks":539,"open_issues":618,"watchers":2238,"default_branch":"develop"}},"base":{"label":"status-im:develop","ref":"develop","sha":"686d64888d5aa3d2fdc90730da48e106342940bc","user":{"login":"status-im","id":11767950,"avatar_url":"https://avatars1.githubusercontent.com/u/11767950?v=4","gravatar_id":"","url":"https://api.github.com/users/status-im","html_url":"https://github.com/status-im","followers_url":"https://api.github.com/users/status-im/followers","following_url":"https://api.github.com/users/status-im/following{/other_user}","gists_url":"https://api.github.com/users/status-im/gists{/gist_id}","starred_url":"https://api.github.com/users/status-im/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/status-im/subscriptions","organizations_url":"https://api.github.com/users/status-im/orgs","repos_url":"https://api.github.com/users/status-im/repos","events_url":"https://api.github.com/users/status-im/events{/privacy}","received_events_url":"https://api.github.com/users/status-im/received_events","type":"Organization","site_admin":false},"repo":{"id":52308441,"name":"status-react","full_name":"status-im/status-react","owner":{"login":"status-im","id":11767950,"avatar_url":"https://avatars1.githubusercontent.com/u/11767950?v=4","gravatar_id":"","url":"https://api.github.com/users/status-im","html_url":"https://github.com/status-im","followers_url":"https://api.github.com/users/status-im/followers","following_url":"https://api.github.com/users/status-im/following{/other_user}","gists_url":"https://api.github.com/users/status-im/gists{/gist_id}","starred_url":"https://api.github.com/users/status-im/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/status-im/subscriptions","organizations_url":"https://api.github.com/users/status-im/orgs","repos_url":"https://api.github.com/users/status-im/repos","events_url":"https://api.github.com/users/status-im/events{/privacy}","received_events_url":"https://api.github.com/users/status-im/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/status-im/status-react","description":"a free (libre) open source, mobile OS for Ethereum","fork":false,"url":"https://api.github.com/repos/status-im/status-react","forks_url":"https://api.github.com/repos/status-im/status-react/forks","keys_url":"https://api.github.com/repos/status-im/status-react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/status-im/status-react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/status-im/status-react/teams","hooks_url":"https://api.github.com/repos/status-im/status-react/hooks","issue_events_url":"https://api.github.com/repos/status-im/status-react/issues/events{/number}","events_url":"https://api.github.com/repos/status-im/status-react/events","assignees_url":"https://api.github.com/repos/status-im/status-react/assignees{/user}","branches_url":"https://api.github.com/repos/status-im/status-react/branches{/branch}","tags_url":"https://api.github.com/repos/status-im/status-react/tags","blobs_url":"https://api.github.com/repos/status-im/status-react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/status-im/status-react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/status-im/status-react/git/refs{/sha}","trees_url":"https://api.github.com/repos/status-im/status-react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/status-im/status-react/statuses/{sha}","languages_url":"https://api.github.com/repos/status-im/status-react/languages","stargazers_url":"https://api.github.com/repos/status-im/status-react/stargazers","contributors_url":"https://api.github.com/repos/status-im/status-react/contributors","subscribers_url":"https://api.github.com/repos/status-im/status-react/subscribers","subscription_url":"https://api.github.com/repos/status-im/status-react/subscription","commits_url":"https://api.github.com/repos/status-im/status-react/commits{/sha}","git_commits_url":"https://api.github.com/repos/status-im/status-react/git/commits{/sha}","comments_url":"https://api.github.com/repos/status-im/status-react/comments{/number}","issue_comment_url":"https://api.github.com/repos/status-im/status-react/issues/comments{/number}","contents_url":"https://api.github.com/repos/status-im/status-react/contents/{+path}","compare_url":"https://api.github.com/repos/status-im/status-react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/status-im/status-react/merges","archive_url":"https://api.github.com/repos/status-im/status-react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/status-im/status-react/downloads","issues_url":"https://api.github.com/repos/status-im/status-react/issues{/number}","pulls_url":"https://api.github.com/repos/status-im/status-react/pulls{/number}","milestones_url":"https://api.github.com/repos/status-im/status-react/milestones{/number}","notifications_url":"https://api.github.com/repos/status-im/status-react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/status-im/status-react/labels{/name}","releases_url":"https://api.github.com/repos/status-im/status-react/releases{/id}","deployments_url":"https://api.github.com/repos/status-im/status-react/deployments","created_at":"2016-02-22T21:48:48Z","updated_at":"2018-05-28T09:57:19Z","pushed_at":"2018-05-28T10:08:10Z","git_url":"git://github.com/status-im/status-react.git","ssh_url":"[email protected]:status-im/status-react.git","clone_url":"https://github.com/status-im/status-react.git","svn_url":"https://github.com/status-im/status-react","homepage":"https://status.im","size":55100,"stargazers_count":2238,"watchers_count":2238,"language":"Clojure","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":539,"mirror_url":null,"archived":false,"open_issues_count":618,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0"},"forks":539,"open_issues":618,"watchers":2238,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/status-im/status-react/pulls/4481"},"html":{"href":"https://github.com/status-im/status-react/pull/4481"},"issue":{"href":"https://api.github.com/repos/status-im/status-react/issues/4481"},"comments":{"href":"https://api.github.com/repos/status-im/status-react/issues/4481/comments"},"review_comments":{"href":"https://api.github.com/repos/status-im/status-react/pulls/4481/comments"},"review_comment":{"href":"https://api.github.com/repos/status-im/status-react/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/status-im/status-react/pulls/4481/commits"},"statuses":{"href":"https://api.github.com/repos/status-im/status-react/statuses/a4d800ca1e03a586cb1736947c9070ca85e02434"}},"author_association":"MEMBER"}} | {
"id": 52308441,
"name": "status-im/status-react",
"url": "https://api.github.com/repos/status-im/status-react"
} | {
"id": 1017008,
"login": "cammellos",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1017008?",
"url": "https://api.github.com/users/cammellos"
} | {
"id": 11767950,
"login": "status-im",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/11767950?",
"url": "https://api.github.com/orgs/status-im"
} | 2018-05-28T10:13:47 | 7737996246 | {"actor":{"display_login":"cammellos"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/status-im/status-go/pulls/comments/180093469","pull_request_review_id":110441568,"id":180093469,"diff_hunk":"@@ -0,0 +1,243 @@\n+package peers\n+\n+import (\n+\t\"sync\"\n+\t\"sync/atomic\"\n+\t\"time\"\n+\n+\t\"github.com/ethereum/go-ethereum/common/mclock\"\n+\t\"github.com/ethereum/go-ethereum/log\"\n+\t\"github.com/ethereum/go-ethereum/p2p\"\n+\t\"github.com/ethereum/go-ethereum/p2p/discover\"\n+\t\"github.com/ethereum/go-ethereum/p2p/discv5\"\n+\t\"github.com/status-im/status-go/geth/params\"\n+)\n+\n+// NewTopicPool returns instance of TopicPool\n+func NewTopicPool(topic discv5.Topic, limits params.Limits, slowSync, fastSync time.Duration) *TopicPool {\n+\treturn &TopicPool{\n+\t\ttopic: topic,\n+\t\tlimits: limits,\n+\t\tslowSync: slowSync,\n+\t\tfastSync: fastSync,\n+\t\tpeers: map[discv5.NodeID]*peerInfo{},\n+\t}\n+}\n+\n+// TopicPool manages peers for topic.\n+type TopicPool struct {\n+\ttopic discv5.Topic\n+\tlimits params.Limits\n+\tslowSync time.Duration\n+\tfastSync time.Duration\n+\n+\tquit chan struct{}\n+\trunning int32\n+\n+\tmu sync.RWMutex\n+\tdiscWG sync.WaitGroup\n+\tconsumerWG sync.WaitGroup\n+\tconnected int\n+\tpeers map[discv5.NodeID]*peerInfo\n+\tperiod chan time.Duration\n+\n+\tcache *Cache\n+}\n+\n+// SearchRunning returns true if search is running\n+func (t *TopicPool) SearchRunning() bool {\n+\treturn atomic.LoadInt32(&t.running) == 1\n+}\n+\n+// MaxReached returns true if we connected with max number of peers.\n+func (t *TopicPool) MaxReached() bool {\n+\tt.mu.RLock()\n+\tdefer t.mu.RUnlock()\n+\treturn t.connected == t.limits[1]\n+}\n+\n+// ConfirmAdded called when peer was added by p2p Server.\n+// 1. Skip a peer if it not in our peer table\n+// 2. Add a peer to a cache.\n+// 3. Disconnect a peer if it was connected after we reached max limit of peers.\n+// (we can't know in advance if peer will be connected, thats why we allow\n+// to overflow for short duration)\n+// 4. Switch search to slow mode if it is running.\n+func (t *TopicPool) ConfirmAdded(server *p2p.Server, nodeID discover.NodeID) {\n+\tt.mu.Lock()\n+\tdefer t.mu.Unlock()\n+\t// inbound connection\n+\tpeer, exist := t.peers[discv5.NodeID(nodeID)]\n+\tif !exist {\n+\t\treturn\n+\t}\n+\t// established connection means that the node is a viable candidate for a connection and can be cached\n+\tif t.cache != nil {\n+\t\tif err := t.cache.AddPeer(peer.node, t.topic); err != nil {\n+\t\t\tlog.Error(\"failed to persist a peer\", \"error\", err)\n+\t\t}\n+\t}\n+\t// when max limit is reached drop every peer after\n+\tif t.connected == t.limits[1] {\n+\t\tlog.Debug(\"max limit is reached drop the peer\", \"ID\", nodeID, \"topic\", t.topic)\n+\t\tt.removePeer(server, peer)\n+\t\treturn\n+\t}\n+\t// don't count same peer twice\n+\tif !peer.connected {","path":"geth/peers/topicpool.go","position":87,"original_position":87,"commit_id":"a9d87892fab578d76c89c81af1704ce13a37ce4e","original_commit_id":"a9d87892fab578d76c89c81af1704ce13a37ce4e","user":{"login":"mandrigin","id":466427,"avatar_url":"https://avatars0.githubusercontent.com/u/466427?v=4","gravatar_id":"","url":"https://api.github.com/users/mandrigin","html_url":"https://github.com/mandrigin","followers_url":"https://api.github.com/users/mandrigin/followers","following_url":"https://api.github.com/users/mandrigin/following{/other_user}","gists_url":"https://api.github.com/users/mandrigin/gists{/gist_id}","starred_url":"https://api.github.com/users/mandrigin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mandrigin/subscriptions","organizations_url":"https://api.github.com/users/mandrigin/orgs","repos_url":"https://api.github.com/users/mandrigin/repos","events_url":"https://api.github.com/users/mandrigin/events{/privacy}","received_events_url":"https://api.github.com/users/mandrigin/received_events","type":"User","site_admin":false},"body":"I would keep a set of connected IDs in the topicpool instead of a field in a peer + an integer here. ","created_at":"2018-04-09T13:28:22Z","updated_at":"2018-04-09T13:31:58Z","html_url":"https://github.com/status-im/status-go/pull/736#discussion_r180093469","pull_request_url":"https://api.github.com/repos/status-im/status-go/pulls/736","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/status-im/status-go/pulls/comments/180093469"},"html":{"href":"https://github.com/status-im/status-go/pull/736#discussion_r180093469"},"pull_request":{"href":"https://api.github.com/repos/status-im/status-go/pulls/736"}}},"pull_request":{"url":"https://api.github.com/repos/status-im/status-go/pulls/736","id":175230439,"html_url":"https://github.com/status-im/status-go/pull/736","diff_url":"https://github.com/status-im/status-go/pull/736.diff","patch_url":"https://github.com/status-im/status-go/pull/736.patch","issue_url":"https://api.github.com/repos/status-im/status-go/issues/736","number":736,"state":"open","locked":false,"title":"Peer pool to manage v5 peers","user":{"login":"dshulyak","id":1964576,"avatar_url":"https://avatars2.githubusercontent.com/u/1964576?v=4","gravatar_id":"","url":"https://api.github.com/users/dshulyak","html_url":"https://github.com/dshulyak","followers_url":"https://api.github.com/users/dshulyak/followers","following_url":"https://api.github.com/users/dshulyak/following{/other_user}","gists_url":"https://api.github.com/users/dshulyak/gists{/gist_id}","starred_url":"https://api.github.com/users/dshulyak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dshulyak/subscriptions","organizations_url":"https://api.github.com/users/dshulyak/orgs","repos_url":"https://api.github.com/users/dshulyak/repos","events_url":"https://api.github.com/users/dshulyak/events{/privacy}","received_events_url":"https://api.github.com/users/dshulyak/received_events","type":"User","site_admin":false},"body":"Peer pool works in a following way:\r\n1. For each configured topic it will create discovery v5 search query.\r\nSearch query will periodically do regular kademlia lookups with bucket size 16\r\nand send a topic query to every node that is returned from kademlia lookup.\r\nEventually nodes with required topics will be found and we will pass them to p2p server.\r\n2. Additional loop will be created for every topic that will synchronize\r\nfound nodes with p2p server. This loop will follow next logic:\r\n- if node is found and max limit of peers is not reached we will add this node to\r\n server and assume that it is connected\r\n- if max limit is reached we will add peer to our peer topic table for later use\r\n- if min limit is reached - frequency will be changed to a keepalive timer, this is required cause we need\r\n frequent lookups only when we are looking for a peer\r\n3. when peer is disconnected we do 3 things:\r\n - select new peer from peers table that was updated no longer than foundTimeout (90s) and not\r\n connected at the moment\r\n - set a peer as not connected\r\n - check how many peers do we have and in case if we went below min limit - set period to fastSync\r\n\r\nMore details on how this is tested: https://github.com/status-im/status-scale/pull/4\r\nDepends on https://github.com/status-im/status-go/pull/749\r\n\r\nIn general it is quite expensive to use discovery (including v5) on mobile devices, without any tuning it generates 1-2 mb of traffic a minute if there new participants in the network, and because mobile connections are usually transient, we will be able to see this pattern.\r\nOne thing that we may explore is to persist found nodes for different topics, so that discovery can be started in slow mode every time after initial peers are discovered.","created_at":"2018-03-15T12:08:24Z","updated_at":"2018-04-09T13:31:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c7c7b56ed6a7653cc70e4dbc98c6211a3ec5e827","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/status-im/status-go/pulls/736/commits","review_comments_url":"https://api.github.com/repos/status-im/status-go/pulls/736/comments","review_comment_url":"https://api.github.com/repos/status-im/status-go/pulls/comments{/number}","comments_url":"https://api.github.com/repos/status-im/status-go/issues/736/comments","statuses_url":"https://api.github.com/repos/status-im/status-go/statuses/a9d87892fab578d76c89c81af1704ce13a37ce4e","head":{"label":"status-im:peerpool","ref":"peerpool","sha":"a9d87892fab578d76c89c81af1704ce13a37ce4e","user":{"login":"status-im","id":11767950,"avatar_url":"https://avatars1.githubusercontent.com/u/11767950?v=4","gravatar_id":"","url":"https://api.github.com/users/status-im","html_url":"https://github.com/status-im","followers_url":"https://api.github.com/users/status-im/followers","following_url":"https://api.github.com/users/status-im/following{/other_user}","gists_url":"https://api.github.com/users/status-im/gists{/gist_id}","starred_url":"https://api.github.com/users/status-im/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/status-im/subscriptions","organizations_url":"https://api.github.com/users/status-im/orgs","repos_url":"https://api.github.com/users/status-im/repos","events_url":"https://api.github.com/users/status-im/events{/privacy}","received_events_url":"https://api.github.com/users/status-im/received_events","type":"Organization","site_admin":false},"repo":{"id":61047867,"name":"status-go","full_name":"status-im/status-go","owner":{"login":"status-im","id":11767950,"avatar_url":"https://avatars1.githubusercontent.com/u/11767950?v=4","gravatar_id":"","url":"https://api.github.com/users/status-im","html_url":"https://github.com/status-im","followers_url":"https://api.github.com/users/status-im/followers","following_url":"https://api.github.com/users/status-im/following{/other_user}","gists_url":"https://api.github.com/users/status-im/gists{/gist_id}","starred_url":"https://api.github.com/users/status-im/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/status-im/subscriptions","organizations_url":"https://api.github.com/users/status-im/orgs","repos_url":"https://api.github.com/users/status-im/repos","events_url":"https://api.github.com/users/status-im/events{/privacy}","received_events_url":"https://api.github.com/users/status-im/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/status-im/status-go","description":"The Status module that consumes go-ethereum","fork":false,"url":"https://api.github.com/repos/status-im/status-go","forks_url":"https://api.github.com/repos/status-im/status-go/forks","keys_url":"https://api.github.com/repos/status-im/status-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/status-im/status-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/status-im/status-go/teams","hooks_url":"https://api.github.com/repos/status-im/status-go/hooks","issue_events_url":"https://api.github.com/repos/status-im/status-go/issues/events{/number}","events_url":"https://api.github.com/repos/status-im/status-go/events","assignees_url":"https://api.github.com/repos/status-im/status-go/assignees{/user}","branches_url":"https://api.github.com/repos/status-im/status-go/branches{/branch}","tags_url":"https://api.github.com/repos/status-im/status-go/tags","blobs_url":"https://api.github.com/repos/status-im/status-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/status-im/status-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/status-im/status-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/status-im/status-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/status-im/status-go/statuses/{sha}","languages_url":"https://api.github.com/repos/status-im/status-go/languages","stargazers_url":"https://api.github.com/repos/status-im/status-go/stargazers","contributors_url":"https://api.github.com/repos/status-im/status-go/contributors","subscribers_url":"https://api.github.com/repos/status-im/status-go/subscribers","subscription_url":"https://api.github.com/repos/status-im/status-go/subscription","commits_url":"https://api.github.com/repos/status-im/status-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/status-im/status-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/status-im/status-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/status-im/status-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/status-im/status-go/contents/{+path}","compare_url":"https://api.github.com/repos/status-im/status-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/status-im/status-go/merges","archive_url":"https://api.github.com/repos/status-im/status-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/status-im/status-go/downloads","issues_url":"https://api.github.com/repos/status-im/status-go/issues{/number}","pulls_url":"https://api.github.com/repos/status-im/status-go/pulls{/number}","milestones_url":"https://api.github.com/repos/status-im/status-go/milestones{/number}","notifications_url":"https://api.github.com/repos/status-im/status-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/status-im/status-go/labels{/name}","releases_url":"https://api.github.com/repos/status-im/status-go/releases{/id}","deployments_url":"https://api.github.com/repos/status-im/status-go/deployments","created_at":"2016-06-13T15:32:03Z","updated_at":"2018-04-09T12:14:05Z","pushed_at":"2018-04-09T12:42:14Z","git_url":"git://github.com/status-im/status-go.git","ssh_url":"[email protected]:status-im/status-go.git","clone_url":"https://github.com/status-im/status-go.git","svn_url":"https://github.com/status-im/status-go","homepage":"https://status.im","size":37614,"stargazers_count":363,"watchers_count":363,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":119,"mirror_url":null,"archived":false,"open_issues_count":63,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0"},"forks":119,"open_issues":63,"watchers":363,"default_branch":"develop"}},"base":{"label":"status-im:develop","ref":"develop","sha":"32d71da046c6c5e4b74fec2ec5f4cb4a4b494563","user":{"login":"status-im","id":11767950,"avatar_url":"https://avatars1.githubusercontent.com/u/11767950?v=4","gravatar_id":"","url":"https://api.github.com/users/status-im","html_url":"https://github.com/status-im","followers_url":"https://api.github.com/users/status-im/followers","following_url":"https://api.github.com/users/status-im/following{/other_user}","gists_url":"https://api.github.com/users/status-im/gists{/gist_id}","starred_url":"https://api.github.com/users/status-im/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/status-im/subscriptions","organizations_url":"https://api.github.com/users/status-im/orgs","repos_url":"https://api.github.com/users/status-im/repos","events_url":"https://api.github.com/users/status-im/events{/privacy}","received_events_url":"https://api.github.com/users/status-im/received_events","type":"Organization","site_admin":false},"repo":{"id":61047867,"name":"status-go","full_name":"status-im/status-go","owner":{"login":"status-im","id":11767950,"avatar_url":"https://avatars1.githubusercontent.com/u/11767950?v=4","gravatar_id":"","url":"https://api.github.com/users/status-im","html_url":"https://github.com/status-im","followers_url":"https://api.github.com/users/status-im/followers","following_url":"https://api.github.com/users/status-im/following{/other_user}","gists_url":"https://api.github.com/users/status-im/gists{/gist_id}","starred_url":"https://api.github.com/users/status-im/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/status-im/subscriptions","organizations_url":"https://api.github.com/users/status-im/orgs","repos_url":"https://api.github.com/users/status-im/repos","events_url":"https://api.github.com/users/status-im/events{/privacy}","received_events_url":"https://api.github.com/users/status-im/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/status-im/status-go","description":"The Status module that consumes go-ethereum","fork":false,"url":"https://api.github.com/repos/status-im/status-go","forks_url":"https://api.github.com/repos/status-im/status-go/forks","keys_url":"https://api.github.com/repos/status-im/status-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/status-im/status-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/status-im/status-go/teams","hooks_url":"https://api.github.com/repos/status-im/status-go/hooks","issue_events_url":"https://api.github.com/repos/status-im/status-go/issues/events{/number}","events_url":"https://api.github.com/repos/status-im/status-go/events","assignees_url":"https://api.github.com/repos/status-im/status-go/assignees{/user}","branches_url":"https://api.github.com/repos/status-im/status-go/branches{/branch}","tags_url":"https://api.github.com/repos/status-im/status-go/tags","blobs_url":"https://api.github.com/repos/status-im/status-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/status-im/status-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/status-im/status-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/status-im/status-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/status-im/status-go/statuses/{sha}","languages_url":"https://api.github.com/repos/status-im/status-go/languages","stargazers_url":"https://api.github.com/repos/status-im/status-go/stargazers","contributors_url":"https://api.github.com/repos/status-im/status-go/contributors","subscribers_url":"https://api.github.com/repos/status-im/status-go/subscribers","subscription_url":"https://api.github.com/repos/status-im/status-go/subscription","commits_url":"https://api.github.com/repos/status-im/status-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/status-im/status-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/status-im/status-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/status-im/status-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/status-im/status-go/contents/{+path}","compare_url":"https://api.github.com/repos/status-im/status-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/status-im/status-go/merges","archive_url":"https://api.github.com/repos/status-im/status-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/status-im/status-go/downloads","issues_url":"https://api.github.com/repos/status-im/status-go/issues{/number}","pulls_url":"https://api.github.com/repos/status-im/status-go/pulls{/number}","milestones_url":"https://api.github.com/repos/status-im/status-go/milestones{/number}","notifications_url":"https://api.github.com/repos/status-im/status-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/status-im/status-go/labels{/name}","releases_url":"https://api.github.com/repos/status-im/status-go/releases{/id}","deployments_url":"https://api.github.com/repos/status-im/status-go/deployments","created_at":"2016-06-13T15:32:03Z","updated_at":"2018-04-09T12:14:05Z","pushed_at":"2018-04-09T12:42:14Z","git_url":"git://github.com/status-im/status-go.git","ssh_url":"[email protected]:status-im/status-go.git","clone_url":"https://github.com/status-im/status-go.git","svn_url":"https://github.com/status-im/status-go","homepage":"https://status.im","size":37614,"stargazers_count":363,"watchers_count":363,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":119,"mirror_url":null,"archived":false,"open_issues_count":63,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0"},"forks":119,"open_issues":63,"watchers":363,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/status-im/status-go/pulls/736"},"html":{"href":"https://github.com/status-im/status-go/pull/736"},"issue":{"href":"https://api.github.com/repos/status-im/status-go/issues/736"},"comments":{"href":"https://api.github.com/repos/status-im/status-go/issues/736/comments"},"review_comments":{"href":"https://api.github.com/repos/status-im/status-go/pulls/736/comments"},"review_comment":{"href":"https://api.github.com/repos/status-im/status-go/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/status-im/status-go/pulls/736/commits"},"statuses":{"href":"https://api.github.com/repos/status-im/status-go/statuses/a9d87892fab578d76c89c81af1704ce13a37ce4e"}},"author_association":"MEMBER"}} | {
"id": 61047867,
"name": "status-im/status-go",
"url": "https://api.github.com/repos/status-im/status-go"
} | {
"id": 466427,
"login": "mandrigin",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/466427?",
"url": "https://api.github.com/users/mandrigin"
} | {
"id": 11767950,
"login": "status-im",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/11767950?",
"url": "https://api.github.com/orgs/status-im"
} | 2018-04-09T13:28:22 | 7500672856 | {"actor":{"display_login":"mandrigin"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/iocage/iocage/pulls/comments/170044863","pull_request_review_id":98670343,"id":170044863,"diff_hunk":"@@ -0,0 +1,82 @@\n+.. index:: Plugins\n+.. _Plugins:\n+\n+Plugins\n+=======\n+\n+iocage plugins are a simple and very fast method to get application\n+containers installed and configured. At its core, a plugin is a jail\n+specifically running one program. Popular programs can be installed\n+repeatedly with one line. Additionally, plugins are easily extended by\n+users, offering a high level of customizability and functionality.\n+\n+In structure, a plugin consists of :file:`.json` manifest and\n+:file:`.png` icon files.\n+\n+\n+**See what's available**\n+\n+\n+To see a list of all currently available plugins, open a command line\n+and type :command:`iocage list -PR` or\n+:command:`iocage list --plugins --remote`. The full\n+`iocage plugin list <https://raw.githubusercontent.com/freenas/iocage-ix-plugins/master/INDEX>`_\n+is also available on GitHub.\n+\n+Check which plugins are installed on the system with\n+:command:`iocage list --plugins` or :command:`iocage list -P`.\n+\n+\n+**Getting started with plugins**\n+\n+\n+.. note:: iocage needs to be `activated <Activate iocage>`_ before\n+ plugins can be installed or modified!\n+\n+\n+To get started, open a command line and type\n+:command:`iocage fetch --plugins ip4_addr=\"IF|IP\"`. This initial\n+:command:`fetch` also supports *dhcp* in the same manner as\n+:command:`iocage create`. The ip4_addr needs to conatin the host IP,\n+but with the last digits changed. The IP listed for the plugin needs to","path":"doc/source/plugins.rst","position":41,"original_position":41,"commit_id":"438b68dd1e2ea5004f1d2c1ebd475ea9c3b4d76d","original_commit_id":"438b68dd1e2ea5004f1d2c1ebd475ea9c3b4d76d","user":{"login":"skarekrow","id":1589047,"avatar_url":"https://avatars2.githubusercontent.com/u/1589047?v=4","gravatar_id":"","url":"https://api.github.com/users/skarekrow","html_url":"https://github.com/skarekrow","followers_url":"https://api.github.com/users/skarekrow/followers","following_url":"https://api.github.com/users/skarekrow/following{/other_user}","gists_url":"https://api.github.com/users/skarekrow/gists{/gist_id}","starred_url":"https://api.github.com/users/skarekrow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skarekrow/subscriptions","organizations_url":"https://api.github.com/users/skarekrow/orgs","repos_url":"https://api.github.com/users/skarekrow/repos","events_url":"https://api.github.com/users/skarekrow/events{/privacy}","received_events_url":"https://api.github.com/users/skarekrow/received_events","type":"User","site_admin":false},"body":"This is not a requirement. What's required is a valid IP address. They could have these on their own subnet, they just need to make sure there's a route and that the address can speak to the world. ","created_at":"2018-02-22T18:05:58Z","updated_at":"2018-02-22T18:06:06Z","html_url":"https://github.com/iocage/iocage/pull/492#discussion_r170044863","pull_request_url":"https://api.github.com/repos/iocage/iocage/pulls/492","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/iocage/iocage/pulls/comments/170044863"},"html":{"href":"https://github.com/iocage/iocage/pull/492#discussion_r170044863"},"pull_request":{"href":"https://api.github.com/repos/iocage/iocage/pulls/492"}}},"pull_request":{"url":"https://api.github.com/repos/iocage/iocage/pulls/492","id":170810179,"html_url":"https://github.com/iocage/iocage/pull/492","diff_url":"https://github.com/iocage/iocage/pull/492.diff","patch_url":"https://github.com/iocage/iocage/pull/492.patch","issue_url":"https://api.github.com/repos/iocage/iocage/issues/492","number":492,"state":"open","locked":false,"title":"Added chapter about fetching/managing plugins.","user":{"login":"a-stjohn","id":32651598,"avatar_url":"https://avatars1.githubusercontent.com/u/32651598?v=4","gravatar_id":"","url":"https://api.github.com/users/a-stjohn","html_url":"https://github.com/a-stjohn","followers_url":"https://api.github.com/users/a-stjohn/followers","following_url":"https://api.github.com/users/a-stjohn/following{/other_user}","gists_url":"https://api.github.com/users/a-stjohn/gists{/gist_id}","starred_url":"https://api.github.com/users/a-stjohn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/a-stjohn/subscriptions","organizations_url":"https://api.github.com/users/a-stjohn/orgs","repos_url":"https://api.github.com/users/a-stjohn/repos","events_url":"https://api.github.com/users/a-stjohn/events{/privacy}","received_events_url":"https://api.github.com/users/a-stjohn/received_events","type":"User","site_admin":false},"body":"Make sure to follow and check these boxes before submitting a PR! Thank you.\r\n\r\n- [x] Explain the feature\r\nAdded a chapter on how to fetch and manage plugins.\r\n","created_at":"2018-02-22T17:06:35Z","updated_at":"2018-02-22T18:06:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"98bd4932696bd81e9ac3b5921687a03d63ae2b87","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/iocage/iocage/pulls/492/commits","review_comments_url":"https://api.github.com/repos/iocage/iocage/pulls/492/comments","review_comment_url":"https://api.github.com/repos/iocage/iocage/pulls/comments{/number}","comments_url":"https://api.github.com/repos/iocage/iocage/issues/492/comments","statuses_url":"https://api.github.com/repos/iocage/iocage/statuses/438b68dd1e2ea5004f1d2c1ebd475ea9c3b4d76d","head":{"label":"iocage:iocage-doc-update","ref":"iocage-doc-update","sha":"438b68dd1e2ea5004f1d2c1ebd475ea9c3b4d76d","user":{"login":"iocage","id":11825280,"avatar_url":"https://avatars1.githubusercontent.com/u/11825280?v=4","gravatar_id":"","url":"https://api.github.com/users/iocage","html_url":"https://github.com/iocage","followers_url":"https://api.github.com/users/iocage/followers","following_url":"https://api.github.com/users/iocage/following{/other_user}","gists_url":"https://api.github.com/users/iocage/gists{/gist_id}","starred_url":"https://api.github.com/users/iocage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iocage/subscriptions","organizations_url":"https://api.github.com/users/iocage/orgs","repos_url":"https://api.github.com/users/iocage/repos","events_url":"https://api.github.com/users/iocage/events{/privacy}","received_events_url":"https://api.github.com/users/iocage/received_events","type":"Organization","site_admin":false},"repo":{"id":78889373,"name":"iocage","full_name":"iocage/iocage","owner":{"login":"iocage","id":11825280,"avatar_url":"https://avatars1.githubusercontent.com/u/11825280?v=4","gravatar_id":"","url":"https://api.github.com/users/iocage","html_url":"https://github.com/iocage","followers_url":"https://api.github.com/users/iocage/followers","following_url":"https://api.github.com/users/iocage/following{/other_user}","gists_url":"https://api.github.com/users/iocage/gists{/gist_id}","starred_url":"https://api.github.com/users/iocage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iocage/subscriptions","organizations_url":"https://api.github.com/users/iocage/orgs","repos_url":"https://api.github.com/users/iocage/repos","events_url":"https://api.github.com/users/iocage/events{/privacy}","received_events_url":"https://api.github.com/users/iocage/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/iocage/iocage","description":"A FreeBSD jail manager written in Python 3","fork":false,"url":"https://api.github.com/repos/iocage/iocage","forks_url":"https://api.github.com/repos/iocage/iocage/forks","keys_url":"https://api.github.com/repos/iocage/iocage/keys{/key_id}","collaborators_url":"https://api.github.com/repos/iocage/iocage/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/iocage/iocage/teams","hooks_url":"https://api.github.com/repos/iocage/iocage/hooks","issue_events_url":"https://api.github.com/repos/iocage/iocage/issues/events{/number}","events_url":"https://api.github.com/repos/iocage/iocage/events","assignees_url":"https://api.github.com/repos/iocage/iocage/assignees{/user}","branches_url":"https://api.github.com/repos/iocage/iocage/branches{/branch}","tags_url":"https://api.github.com/repos/iocage/iocage/tags","blobs_url":"https://api.github.com/repos/iocage/iocage/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/iocage/iocage/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/iocage/iocage/git/refs{/sha}","trees_url":"https://api.github.com/repos/iocage/iocage/git/trees{/sha}","statuses_url":"https://api.github.com/repos/iocage/iocage/statuses/{sha}","languages_url":"https://api.github.com/repos/iocage/iocage/languages","stargazers_url":"https://api.github.com/repos/iocage/iocage/stargazers","contributors_url":"https://api.github.com/repos/iocage/iocage/contributors","subscribers_url":"https://api.github.com/repos/iocage/iocage/subscribers","subscription_url":"https://api.github.com/repos/iocage/iocage/subscription","commits_url":"https://api.github.com/repos/iocage/iocage/commits{/sha}","git_commits_url":"https://api.github.com/repos/iocage/iocage/git/commits{/sha}","comments_url":"https://api.github.com/repos/iocage/iocage/comments{/number}","issue_comment_url":"https://api.github.com/repos/iocage/iocage/issues/comments{/number}","contents_url":"https://api.github.com/repos/iocage/iocage/contents/{+path}","compare_url":"https://api.github.com/repos/iocage/iocage/compare/{base}...{head}","merges_url":"https://api.github.com/repos/iocage/iocage/merges","archive_url":"https://api.github.com/repos/iocage/iocage/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/iocage/iocage/downloads","issues_url":"https://api.github.com/repos/iocage/iocage/issues{/number}","pulls_url":"https://api.github.com/repos/iocage/iocage/pulls{/number}","milestones_url":"https://api.github.com/repos/iocage/iocage/milestones{/number}","notifications_url":"https://api.github.com/repos/iocage/iocage/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/iocage/iocage/labels{/name}","releases_url":"https://api.github.com/repos/iocage/iocage/releases{/id}","deployments_url":"https://api.github.com/repos/iocage/iocage/deployments","created_at":"2017-01-13T21:47:59Z","updated_at":"2018-02-21T21:59:33Z","pushed_at":"2018-02-22T17:06:35Z","git_url":"git://github.com/iocage/iocage.git","ssh_url":"[email protected]:iocage/iocage.git","clone_url":"https://github.com/iocage/iocage.git","svn_url":"https://github.com/iocage/iocage","homepage":"","size":2350,"stargazers_count":189,"watchers_count":189,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":49,"mirror_url":null,"archived":false,"open_issues_count":43,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":49,"open_issues":43,"watchers":189,"default_branch":"master"}},"base":{"label":"iocage:master","ref":"master","sha":"fbbdd7314b6d4050ecd6134bfa0d10fabce9eee4","user":{"login":"iocage","id":11825280,"avatar_url":"https://avatars1.githubusercontent.com/u/11825280?v=4","gravatar_id":"","url":"https://api.github.com/users/iocage","html_url":"https://github.com/iocage","followers_url":"https://api.github.com/users/iocage/followers","following_url":"https://api.github.com/users/iocage/following{/other_user}","gists_url":"https://api.github.com/users/iocage/gists{/gist_id}","starred_url":"https://api.github.com/users/iocage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iocage/subscriptions","organizations_url":"https://api.github.com/users/iocage/orgs","repos_url":"https://api.github.com/users/iocage/repos","events_url":"https://api.github.com/users/iocage/events{/privacy}","received_events_url":"https://api.github.com/users/iocage/received_events","type":"Organization","site_admin":false},"repo":{"id":78889373,"name":"iocage","full_name":"iocage/iocage","owner":{"login":"iocage","id":11825280,"avatar_url":"https://avatars1.githubusercontent.com/u/11825280?v=4","gravatar_id":"","url":"https://api.github.com/users/iocage","html_url":"https://github.com/iocage","followers_url":"https://api.github.com/users/iocage/followers","following_url":"https://api.github.com/users/iocage/following{/other_user}","gists_url":"https://api.github.com/users/iocage/gists{/gist_id}","starred_url":"https://api.github.com/users/iocage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iocage/subscriptions","organizations_url":"https://api.github.com/users/iocage/orgs","repos_url":"https://api.github.com/users/iocage/repos","events_url":"https://api.github.com/users/iocage/events{/privacy}","received_events_url":"https://api.github.com/users/iocage/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/iocage/iocage","description":"A FreeBSD jail manager written in Python 3","fork":false,"url":"https://api.github.com/repos/iocage/iocage","forks_url":"https://api.github.com/repos/iocage/iocage/forks","keys_url":"https://api.github.com/repos/iocage/iocage/keys{/key_id}","collaborators_url":"https://api.github.com/repos/iocage/iocage/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/iocage/iocage/teams","hooks_url":"https://api.github.com/repos/iocage/iocage/hooks","issue_events_url":"https://api.github.com/repos/iocage/iocage/issues/events{/number}","events_url":"https://api.github.com/repos/iocage/iocage/events","assignees_url":"https://api.github.com/repos/iocage/iocage/assignees{/user}","branches_url":"https://api.github.com/repos/iocage/iocage/branches{/branch}","tags_url":"https://api.github.com/repos/iocage/iocage/tags","blobs_url":"https://api.github.com/repos/iocage/iocage/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/iocage/iocage/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/iocage/iocage/git/refs{/sha}","trees_url":"https://api.github.com/repos/iocage/iocage/git/trees{/sha}","statuses_url":"https://api.github.com/repos/iocage/iocage/statuses/{sha}","languages_url":"https://api.github.com/repos/iocage/iocage/languages","stargazers_url":"https://api.github.com/repos/iocage/iocage/stargazers","contributors_url":"https://api.github.com/repos/iocage/iocage/contributors","subscribers_url":"https://api.github.com/repos/iocage/iocage/subscribers","subscription_url":"https://api.github.com/repos/iocage/iocage/subscription","commits_url":"https://api.github.com/repos/iocage/iocage/commits{/sha}","git_commits_url":"https://api.github.com/repos/iocage/iocage/git/commits{/sha}","comments_url":"https://api.github.com/repos/iocage/iocage/comments{/number}","issue_comment_url":"https://api.github.com/repos/iocage/iocage/issues/comments{/number}","contents_url":"https://api.github.com/repos/iocage/iocage/contents/{+path}","compare_url":"https://api.github.com/repos/iocage/iocage/compare/{base}...{head}","merges_url":"https://api.github.com/repos/iocage/iocage/merges","archive_url":"https://api.github.com/repos/iocage/iocage/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/iocage/iocage/downloads","issues_url":"https://api.github.com/repos/iocage/iocage/issues{/number}","pulls_url":"https://api.github.com/repos/iocage/iocage/pulls{/number}","milestones_url":"https://api.github.com/repos/iocage/iocage/milestones{/number}","notifications_url":"https://api.github.com/repos/iocage/iocage/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/iocage/iocage/labels{/name}","releases_url":"https://api.github.com/repos/iocage/iocage/releases{/id}","deployments_url":"https://api.github.com/repos/iocage/iocage/deployments","created_at":"2017-01-13T21:47:59Z","updated_at":"2018-02-21T21:59:33Z","pushed_at":"2018-02-22T17:06:35Z","git_url":"git://github.com/iocage/iocage.git","ssh_url":"[email protected]:iocage/iocage.git","clone_url":"https://github.com/iocage/iocage.git","svn_url":"https://github.com/iocage/iocage","homepage":"","size":2350,"stargazers_count":189,"watchers_count":189,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":49,"mirror_url":null,"archived":false,"open_issues_count":43,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":49,"open_issues":43,"watchers":189,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/iocage/iocage/pulls/492"},"html":{"href":"https://github.com/iocage/iocage/pull/492"},"issue":{"href":"https://api.github.com/repos/iocage/iocage/issues/492"},"comments":{"href":"https://api.github.com/repos/iocage/iocage/issues/492/comments"},"review_comments":{"href":"https://api.github.com/repos/iocage/iocage/pulls/492/comments"},"review_comment":{"href":"https://api.github.com/repos/iocage/iocage/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/iocage/iocage/pulls/492/commits"},"statuses":{"href":"https://api.github.com/repos/iocage/iocage/statuses/438b68dd1e2ea5004f1d2c1ebd475ea9c3b4d76d"}},"author_association":"CONTRIBUTOR"}} | {
"id": 78889373,
"name": "iocage/iocage",
"url": "https://api.github.com/repos/iocage/iocage"
} | {
"id": 1589047,
"login": "skarekrow",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1589047?",
"url": "https://api.github.com/users/skarekrow"
} | {
"id": 11825280,
"login": "iocage",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/11825280?",
"url": "https://api.github.com/orgs/iocage"
} | 2018-02-22T18:05:58 | 7283128983 | {"actor":{"display_login":"skarekrow"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/iocage/iocage/pulls/comments/227981495","pull_request_review_id":168146588,"id":227981495,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNzk4MTQ5NQ==","diff_hunk":"@@ -86,3 +87,19 @@ an empty jail with :command:`iocage create -e`.\n \n These are ideal for experimentation with unsupported RELEASES or Linux\n jails.\n+\n+.. index:: Thickjail\n+.. _Thick:\n+\n+Thickjail\n+---------\n+\n+Thickjails jails are created with:\n+\n+:samp:`# iocage create -T -r 11.2-RELEASE`\n+\n+Thickjails are copied from the appropriate RELEASE at creation\n+time. These consume a huge amount of space, but are fully independent.","path":"doc/source/jailtypes.rst","position":24,"original_position":24,"commit_id":"83d3c6221902cb1f6505e28629eaef63e5ccd4cf","original_commit_id":"83d3c6221902cb1f6505e28629eaef63e5ccd4cf","user":{"login":"skarekrow","id":1589047,"node_id":"MDQ6VXNlcjE1ODkwNDc=","avatar_url":"https://avatars2.githubusercontent.com/u/1589047?v=4","gravatar_id":"","url":"https://api.github.com/users/skarekrow","html_url":"https://github.com/skarekrow","followers_url":"https://api.github.com/users/skarekrow/followers","following_url":"https://api.github.com/users/skarekrow/following{/other_user}","gists_url":"https://api.github.com/users/skarekrow/gists{/gist_id}","starred_url":"https://api.github.com/users/skarekrow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skarekrow/subscriptions","organizations_url":"https://api.github.com/users/skarekrow/orgs","repos_url":"https://api.github.com/users/skarekrow/repos","events_url":"https://api.github.com/users/skarekrow/events{/privacy}","received_events_url":"https://api.github.com/users/skarekrow/received_events","type":"User","site_admin":false},"body":"Let's say large","created_at":"2018-10-24T22:29:41Z","updated_at":"2018-10-24T22:29:54Z","html_url":"https://github.com/iocage/iocage/pull/666#discussion_r227981495","pull_request_url":"https://api.github.com/repos/iocage/iocage/pulls/666","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/iocage/iocage/pulls/comments/227981495"},"html":{"href":"https://github.com/iocage/iocage/pull/666#discussion_r227981495"},"pull_request":{"href":"https://api.github.com/repos/iocage/iocage/pulls/666"}}},"pull_request":{"url":"https://api.github.com/repos/iocage/iocage/pulls/666","id":225540942,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1NTQwOTQy","html_url":"https://github.com/iocage/iocage/pull/666","diff_url":"https://github.com/iocage/iocage/pull/666.diff","patch_url":"https://github.com/iocage/iocage/pull/666.patch","issue_url":"https://api.github.com/repos/iocage/iocage/issues/666","number":666,"state":"open","locked":false,"title":"adds 'thickjail' to jailtypes.rst","user":{"login":"ole-db","id":36762290,"node_id":"MDQ6VXNlcjM2NzYyMjkw","avatar_url":"https://avatars0.githubusercontent.com/u/36762290?v=4","gravatar_id":"","url":"https://api.github.com/users/ole-db","html_url":"https://github.com/ole-db","followers_url":"https://api.github.com/users/ole-db/followers","following_url":"https://api.github.com/users/ole-db/following{/other_user}","gists_url":"https://api.github.com/users/ole-db/gists{/gist_id}","starred_url":"https://api.github.com/users/ole-db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ole-db/subscriptions","organizations_url":"https://api.github.com/users/ole-db/orgs","repos_url":"https://api.github.com/users/ole-db/repos","events_url":"https://api.github.com/users/ole-db/events{/privacy}","received_events_url":"https://api.github.com/users/ole-db/received_events","type":"User","site_admin":false},"body":"adds 'thickjail' feature to doc/source/jailtypes.rst\r\n\r\nhttps://github.com/iocage/iocage/pull/516\r\nhttps://github.com/iocage/iocage/pull/604","created_at":"2018-10-24T20:31:49Z","updated_at":"2018-10-24T22:29:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"53e2f0c240896abd6c07f58fbef3d690bc55b3cf","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/iocage/iocage/pulls/666/commits","review_comments_url":"https://api.github.com/repos/iocage/iocage/pulls/666/comments","review_comment_url":"https://api.github.com/repos/iocage/iocage/pulls/comments{/number}","comments_url":"https://api.github.com/repos/iocage/iocage/issues/666/comments","statuses_url":"https://api.github.com/repos/iocage/iocage/statuses/83d3c6221902cb1f6505e28629eaef63e5ccd4cf","head":{"label":"ole-db:master","ref":"master","sha":"83d3c6221902cb1f6505e28629eaef63e5ccd4cf","user":{"login":"ole-db","id":36762290,"node_id":"MDQ6VXNlcjM2NzYyMjkw","avatar_url":"https://avatars0.githubusercontent.com/u/36762290?v=4","gravatar_id":"","url":"https://api.github.com/users/ole-db","html_url":"https://github.com/ole-db","followers_url":"https://api.github.com/users/ole-db/followers","following_url":"https://api.github.com/users/ole-db/following{/other_user}","gists_url":"https://api.github.com/users/ole-db/gists{/gist_id}","starred_url":"https://api.github.com/users/ole-db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ole-db/subscriptions","organizations_url":"https://api.github.com/users/ole-db/orgs","repos_url":"https://api.github.com/users/ole-db/repos","events_url":"https://api.github.com/users/ole-db/events{/privacy}","received_events_url":"https://api.github.com/users/ole-db/received_events","type":"User","site_admin":false},"repo":{"id":154562796,"node_id":"MDEwOlJlcG9zaXRvcnkxNTQ1NjI3OTY=","name":"iocage","full_name":"ole-db/iocage","private":false,"owner":{"login":"ole-db","id":36762290,"node_id":"MDQ6VXNlcjM2NzYyMjkw","avatar_url":"https://avatars0.githubusercontent.com/u/36762290?v=4","gravatar_id":"","url":"https://api.github.com/users/ole-db","html_url":"https://github.com/ole-db","followers_url":"https://api.github.com/users/ole-db/followers","following_url":"https://api.github.com/users/ole-db/following{/other_user}","gists_url":"https://api.github.com/users/ole-db/gists{/gist_id}","starred_url":"https://api.github.com/users/ole-db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ole-db/subscriptions","organizations_url":"https://api.github.com/users/ole-db/orgs","repos_url":"https://api.github.com/users/ole-db/repos","events_url":"https://api.github.com/users/ole-db/events{/privacy}","received_events_url":"https://api.github.com/users/ole-db/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ole-db/iocage","description":"A FreeBSD jail manager written in Python 3","fork":true,"url":"https://api.github.com/repos/ole-db/iocage","forks_url":"https://api.github.com/repos/ole-db/iocage/forks","keys_url":"https://api.github.com/repos/ole-db/iocage/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ole-db/iocage/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ole-db/iocage/teams","hooks_url":"https://api.github.com/repos/ole-db/iocage/hooks","issue_events_url":"https://api.github.com/repos/ole-db/iocage/issues/events{/number}","events_url":"https://api.github.com/repos/ole-db/iocage/events","assignees_url":"https://api.github.com/repos/ole-db/iocage/assignees{/user}","branches_url":"https://api.github.com/repos/ole-db/iocage/branches{/branch}","tags_url":"https://api.github.com/repos/ole-db/iocage/tags","blobs_url":"https://api.github.com/repos/ole-db/iocage/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ole-db/iocage/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ole-db/iocage/git/refs{/sha}","trees_url":"https://api.github.com/repos/ole-db/iocage/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ole-db/iocage/statuses/{sha}","languages_url":"https://api.github.com/repos/ole-db/iocage/languages","stargazers_url":"https://api.github.com/repos/ole-db/iocage/stargazers","contributors_url":"https://api.github.com/repos/ole-db/iocage/contributors","subscribers_url":"https://api.github.com/repos/ole-db/iocage/subscribers","subscription_url":"https://api.github.com/repos/ole-db/iocage/subscription","commits_url":"https://api.github.com/repos/ole-db/iocage/commits{/sha}","git_commits_url":"https://api.github.com/repos/ole-db/iocage/git/commits{/sha}","comments_url":"https://api.github.com/repos/ole-db/iocage/comments{/number}","issue_comment_url":"https://api.github.com/repos/ole-db/iocage/issues/comments{/number}","contents_url":"https://api.github.com/repos/ole-db/iocage/contents/{+path}","compare_url":"https://api.github.com/repos/ole-db/iocage/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ole-db/iocage/merges","archive_url":"https://api.github.com/repos/ole-db/iocage/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ole-db/iocage/downloads","issues_url":"https://api.github.com/repos/ole-db/iocage/issues{/number}","pulls_url":"https://api.github.com/repos/ole-db/iocage/pulls{/number}","milestones_url":"https://api.github.com/repos/ole-db/iocage/milestones{/number}","notifications_url":"https://api.github.com/repos/ole-db/iocage/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ole-db/iocage/labels{/name}","releases_url":"https://api.github.com/repos/ole-db/iocage/releases{/id}","deployments_url":"https://api.github.com/repos/ole-db/iocage/deployments","created_at":"2018-10-24T20:10:12Z","updated_at":"2018-10-24T20:27:32Z","pushed_at":"2018-10-24T20:27:30Z","git_url":"git://github.com/ole-db/iocage.git","ssh_url":"[email protected]:ole-db/iocage.git","clone_url":"https://github.com/ole-db/iocage.git","svn_url":"https://github.com/ole-db/iocage","homepage":"","size":3389,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"iocage:master","ref":"master","sha":"7e9034325190f3a3efd5fb86ac600128c56d347a","user":{"login":"iocage","id":11825280,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExODI1Mjgw","avatar_url":"https://avatars1.githubusercontent.com/u/11825280?v=4","gravatar_id":"","url":"https://api.github.com/users/iocage","html_url":"https://github.com/iocage","followers_url":"https://api.github.com/users/iocage/followers","following_url":"https://api.github.com/users/iocage/following{/other_user}","gists_url":"https://api.github.com/users/iocage/gists{/gist_id}","starred_url":"https://api.github.com/users/iocage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iocage/subscriptions","organizations_url":"https://api.github.com/users/iocage/orgs","repos_url":"https://api.github.com/users/iocage/repos","events_url":"https://api.github.com/users/iocage/events{/privacy}","received_events_url":"https://api.github.com/users/iocage/received_events","type":"Organization","site_admin":false},"repo":{"id":78889373,"node_id":"MDEwOlJlcG9zaXRvcnk3ODg4OTM3Mw==","name":"iocage","full_name":"iocage/iocage","private":false,"owner":{"login":"iocage","id":11825280,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExODI1Mjgw","avatar_url":"https://avatars1.githubusercontent.com/u/11825280?v=4","gravatar_id":"","url":"https://api.github.com/users/iocage","html_url":"https://github.com/iocage","followers_url":"https://api.github.com/users/iocage/followers","following_url":"https://api.github.com/users/iocage/following{/other_user}","gists_url":"https://api.github.com/users/iocage/gists{/gist_id}","starred_url":"https://api.github.com/users/iocage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iocage/subscriptions","organizations_url":"https://api.github.com/users/iocage/orgs","repos_url":"https://api.github.com/users/iocage/repos","events_url":"https://api.github.com/users/iocage/events{/privacy}","received_events_url":"https://api.github.com/users/iocage/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/iocage/iocage","description":"A FreeBSD jail manager written in Python 3","fork":false,"url":"https://api.github.com/repos/iocage/iocage","forks_url":"https://api.github.com/repos/iocage/iocage/forks","keys_url":"https://api.github.com/repos/iocage/iocage/keys{/key_id}","collaborators_url":"https://api.github.com/repos/iocage/iocage/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/iocage/iocage/teams","hooks_url":"https://api.github.com/repos/iocage/iocage/hooks","issue_events_url":"https://api.github.com/repos/iocage/iocage/issues/events{/number}","events_url":"https://api.github.com/repos/iocage/iocage/events","assignees_url":"https://api.github.com/repos/iocage/iocage/assignees{/user}","branches_url":"https://api.github.com/repos/iocage/iocage/branches{/branch}","tags_url":"https://api.github.com/repos/iocage/iocage/tags","blobs_url":"https://api.github.com/repos/iocage/iocage/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/iocage/iocage/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/iocage/iocage/git/refs{/sha}","trees_url":"https://api.github.com/repos/iocage/iocage/git/trees{/sha}","statuses_url":"https://api.github.com/repos/iocage/iocage/statuses/{sha}","languages_url":"https://api.github.com/repos/iocage/iocage/languages","stargazers_url":"https://api.github.com/repos/iocage/iocage/stargazers","contributors_url":"https://api.github.com/repos/iocage/iocage/contributors","subscribers_url":"https://api.github.com/repos/iocage/iocage/subscribers","subscription_url":"https://api.github.com/repos/iocage/iocage/subscription","commits_url":"https://api.github.com/repos/iocage/iocage/commits{/sha}","git_commits_url":"https://api.github.com/repos/iocage/iocage/git/commits{/sha}","comments_url":"https://api.github.com/repos/iocage/iocage/comments{/number}","issue_comment_url":"https://api.github.com/repos/iocage/iocage/issues/comments{/number}","contents_url":"https://api.github.com/repos/iocage/iocage/contents/{+path}","compare_url":"https://api.github.com/repos/iocage/iocage/compare/{base}...{head}","merges_url":"https://api.github.com/repos/iocage/iocage/merges","archive_url":"https://api.github.com/repos/iocage/iocage/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/iocage/iocage/downloads","issues_url":"https://api.github.com/repos/iocage/iocage/issues{/number}","pulls_url":"https://api.github.com/repos/iocage/iocage/pulls{/number}","milestones_url":"https://api.github.com/repos/iocage/iocage/milestones{/number}","notifications_url":"https://api.github.com/repos/iocage/iocage/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/iocage/iocage/labels{/name}","releases_url":"https://api.github.com/repos/iocage/iocage/releases{/id}","deployments_url":"https://api.github.com/repos/iocage/iocage/deployments","created_at":"2017-01-13T21:47:59Z","updated_at":"2018-10-24T14:05:00Z","pushed_at":"2018-10-24T20:31:50Z","git_url":"git://github.com/iocage/iocage.git","ssh_url":"[email protected]:iocage/iocage.git","clone_url":"https://github.com/iocage/iocage.git","svn_url":"https://github.com/iocage/iocage","homepage":"","size":3496,"stargazers_count":267,"watchers_count":267,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":63,"mirror_url":null,"archived":false,"open_issues_count":67,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":63,"open_issues":67,"watchers":267,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/iocage/iocage/pulls/666"},"html":{"href":"https://github.com/iocage/iocage/pull/666"},"issue":{"href":"https://api.github.com/repos/iocage/iocage/issues/666"},"comments":{"href":"https://api.github.com/repos/iocage/iocage/issues/666/comments"},"review_comments":{"href":"https://api.github.com/repos/iocage/iocage/pulls/666/comments"},"review_comment":{"href":"https://api.github.com/repos/iocage/iocage/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/iocage/iocage/pulls/666/commits"},"statuses":{"href":"https://api.github.com/repos/iocage/iocage/statuses/83d3c6221902cb1f6505e28629eaef63e5ccd4cf"}},"author_association":"CONTRIBUTOR"}} | {
"id": 78889373,
"name": "iocage/iocage",
"url": "https://api.github.com/repos/iocage/iocage"
} | {
"id": 1589047,
"login": "skarekrow",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1589047?",
"url": "https://api.github.com/users/skarekrow"
} | {
"id": 11825280,
"login": "iocage",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/11825280?",
"url": "https://api.github.com/orgs/iocage"
} | 2018-10-24T22:29:41 | 8476576199 | {"actor":{"display_login":"skarekrow"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/navikt/foreldrepengesoknad/pulls/comments/192387756","pull_request_review_id":125155616,"id":192387756,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5MjM4Nzc1Ng==","diff_hunk":"@@ -1,7 +1,7 @@\n import {\n Dekningsgrad,\n Permisjonsregler,\n- Spraak,\n+ Språkkode,","path":"src/uttaksplan/redux/types/index.ts","position":5,"original_position":5,"commit_id":"a1d1cd7597843f5bb90ec2d7810e6df4ce2a14f6","original_commit_id":"a1d1cd7597843f5bb90ec2d7810e6df4ce2a14f6","user":{"login":"erlendev","id":1488626,"node_id":"MDQ6VXNlcjE0ODg2MjY=","avatar_url":"https://avatars1.githubusercontent.com/u/1488626?v=4","gravatar_id":"","url":"https://api.github.com/users/erlendev","html_url":"https://github.com/erlendev","followers_url":"https://api.github.com/users/erlendev/followers","following_url":"https://api.github.com/users/erlendev/following{/other_user}","gists_url":"https://api.github.com/users/erlendev/gists{/gist_id}","starred_url":"https://api.github.com/users/erlendev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erlendev/subscriptions","organizations_url":"https://api.github.com/users/erlendev/orgs","repos_url":"https://api.github.com/users/erlendev/repos","events_url":"https://api.github.com/users/erlendev/events{/privacy}","received_events_url":"https://api.github.com/users/erlendev/received_events","type":"User","site_admin":false},"body":"Samme spørsmål her som kommentar på `viewReducer.ts`.","created_at":"2018-06-01T13:00:15Z","updated_at":"2018-06-01T13:01:35Z","html_url":"https://github.com/navikt/foreldrepengesoknad/pull/78#discussion_r192387756","pull_request_url":"https://api.github.com/repos/navikt/foreldrepengesoknad/pulls/78","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/navikt/foreldrepengesoknad/pulls/comments/192387756"},"html":{"href":"https://github.com/navikt/foreldrepengesoknad/pull/78#discussion_r192387756"},"pull_request":{"href":"https://api.github.com/repos/navikt/foreldrepengesoknad/pulls/78"}}},"pull_request":{"url":"https://api.github.com/repos/navikt/foreldrepengesoknad/pulls/78","id":192007608,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkyMDA3NjA4","html_url":"https://github.com/navikt/foreldrepengesoknad/pull/78","diff_url":"https://github.com/navikt/foreldrepengesoknad/pull/78.diff","patch_url":"https://github.com/navikt/foreldrepengesoknad/pull/78.patch","issue_url":"https://api.github.com/repos/navikt/foreldrepengesoknad/issues/78","number":78,"state":"open","locked":false,"title":"Move more code to common","user":{"login":"frodehansen2","id":462494,"node_id":"MDQ6VXNlcjQ2MjQ5NA==","avatar_url":"https://avatars1.githubusercontent.com/u/462494?v=4","gravatar_id":"","url":"https://api.github.com/users/frodehansen2","html_url":"https://github.com/frodehansen2","followers_url":"https://api.github.com/users/frodehansen2/followers","following_url":"https://api.github.com/users/frodehansen2/following{/other_user}","gists_url":"https://api.github.com/users/frodehansen2/gists{/gist_id}","starred_url":"https://api.github.com/users/frodehansen2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frodehansen2/subscriptions","organizations_url":"https://api.github.com/users/frodehansen2/orgs","repos_url":"https://api.github.com/users/frodehansen2/repos","events_url":"https://api.github.com/users/frodehansen2/events{/privacy}","received_events_url":"https://api.github.com/users/frodehansen2/received_events","type":"User","site_admin":false},"body":"Samling av noe felles kode, mye flytting av filer og endring av referanser til disse","created_at":"2018-06-01T11:27:31Z","updated_at":"2018-06-01T13:01:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8b8f987754e4ab6efffa775908b7f1339a4fd11b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/navikt/foreldrepengesoknad/pulls/78/commits","review_comments_url":"https://api.github.com/repos/navikt/foreldrepengesoknad/pulls/78/comments","review_comment_url":"https://api.github.com/repos/navikt/foreldrepengesoknad/pulls/comments{/number}","comments_url":"https://api.github.com/repos/navikt/foreldrepengesoknad/issues/78/comments","statuses_url":"https://api.github.com/repos/navikt/foreldrepengesoknad/statuses/a1d1cd7597843f5bb90ec2d7810e6df4ce2a14f6","head":{"label":"navikt:uttaksplan","ref":"uttaksplan","sha":"a1d1cd7597843f5bb90ec2d7810e6df4ce2a14f6","user":{"login":"navikt","id":11848947,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExODQ4OTQ3","avatar_url":"https://avatars3.githubusercontent.com/u/11848947?v=4","gravatar_id":"","url":"https://api.github.com/users/navikt","html_url":"https://github.com/navikt","followers_url":"https://api.github.com/users/navikt/followers","following_url":"https://api.github.com/users/navikt/following{/other_user}","gists_url":"https://api.github.com/users/navikt/gists{/gist_id}","starred_url":"https://api.github.com/users/navikt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/navikt/subscriptions","organizations_url":"https://api.github.com/users/navikt/orgs","repos_url":"https://api.github.com/users/navikt/repos","events_url":"https://api.github.com/users/navikt/events{/privacy}","received_events_url":"https://api.github.com/users/navikt/received_events","type":"Organization","site_admin":false},"repo":{"id":130855671,"node_id":"MDEwOlJlcG9zaXRvcnkxMzA4NTU2NzE=","name":"foreldrepengesoknad","full_name":"navikt/foreldrepengesoknad","owner":{"login":"navikt","id":11848947,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExODQ4OTQ3","avatar_url":"https://avatars3.githubusercontent.com/u/11848947?v=4","gravatar_id":"","url":"https://api.github.com/users/navikt","html_url":"https://github.com/navikt","followers_url":"https://api.github.com/users/navikt/followers","following_url":"https://api.github.com/users/navikt/following{/other_user}","gists_url":"https://api.github.com/users/navikt/gists{/gist_id}","starred_url":"https://api.github.com/users/navikt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/navikt/subscriptions","organizations_url":"https://api.github.com/users/navikt/orgs","repos_url":"https://api.github.com/users/navikt/repos","events_url":"https://api.github.com/users/navikt/events{/privacy}","received_events_url":"https://api.github.com/users/navikt/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/navikt/foreldrepengesoknad","description":"Selvbetjeningsløsning for søknad om foreldrepenger","fork":false,"url":"https://api.github.com/repos/navikt/foreldrepengesoknad","forks_url":"https://api.github.com/repos/navikt/foreldrepengesoknad/forks","keys_url":"https://api.github.com/repos/navikt/foreldrepengesoknad/keys{/key_id}","collaborators_url":"https://api.github.com/repos/navikt/foreldrepengesoknad/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/navikt/foreldrepengesoknad/teams","hooks_url":"https://api.github.com/repos/navikt/foreldrepengesoknad/hooks","issue_events_url":"https://api.github.com/repos/navikt/foreldrepengesoknad/issues/events{/number}","events_url":"https://api.github.com/repos/navikt/foreldrepengesoknad/events","assignees_url":"https://api.github.com/repos/navikt/foreldrepengesoknad/assignees{/user}","branches_url":"https://api.github.com/repos/navikt/foreldrepengesoknad/branches{/branch}","tags_url":"https://api.github.com/repos/navikt/foreldrepengesoknad/tags","blobs_url":"https://api.github.com/repos/navikt/foreldrepengesoknad/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/navikt/foreldrepengesoknad/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/navikt/foreldrepengesoknad/git/refs{/sha}","trees_url":"https://api.github.com/repos/navikt/foreldrepengesoknad/git/trees{/sha}","statuses_url":"https://api.github.com/repos/navikt/foreldrepengesoknad/statuses/{sha}","languages_url":"https://api.github.com/repos/navikt/foreldrepengesoknad/languages","stargazers_url":"https://api.github.com/repos/navikt/foreldrepengesoknad/stargazers","contributors_url":"https://api.github.com/repos/navikt/foreldrepengesoknad/contributors","subscribers_url":"https://api.github.com/repos/navikt/foreldrepengesoknad/subscribers","subscription_url":"https://api.github.com/repos/navikt/foreldrepengesoknad/subscription","commits_url":"https://api.github.com/repos/navikt/foreldrepengesoknad/commits{/sha}","git_commits_url":"https://api.github.com/repos/navikt/foreldrepengesoknad/git/commits{/sha}","comments_url":"https://api.github.com/repos/navikt/foreldrepengesoknad/comments{/number}","issue_comment_url":"https://api.github.com/repos/navikt/foreldrepengesoknad/issues/comments{/number}","contents_url":"https://api.github.com/repos/navikt/foreldrepengesoknad/contents/{+path}","compare_url":"https://api.github.com/repos/navikt/foreldrepengesoknad/compare/{base}...{head}","merges_url":"https://api.github.com/repos/navikt/foreldrepengesoknad/merges","archive_url":"https://api.github.com/repos/navikt/foreldrepengesoknad/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/navikt/foreldrepengesoknad/downloads","issues_url":"https://api.github.com/repos/navikt/foreldrepengesoknad/issues{/number}","pulls_url":"https://api.github.com/repos/navikt/foreldrepengesoknad/pulls{/number}","milestones_url":"https://api.github.com/repos/navikt/foreldrepengesoknad/milestones{/number}","notifications_url":"https://api.github.com/repos/navikt/foreldrepengesoknad/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/navikt/foreldrepengesoknad/labels{/name}","releases_url":"https://api.github.com/repos/navikt/foreldrepengesoknad/releases{/id}","deployments_url":"https://api.github.com/repos/navikt/foreldrepengesoknad/deployments","created_at":"2018-04-24T13:06:00Z","updated_at":"2018-06-01T12:27:47Z","pushed_at":"2018-06-01T12:37:21Z","git_url":"git://github.com/navikt/foreldrepengesoknad.git","ssh_url":"[email protected]:navikt/foreldrepengesoknad.git","clone_url":"https://github.com/navikt/foreldrepengesoknad.git","svn_url":"https://github.com/navikt/foreldrepengesoknad","homepage":null,"size":1164,"stargazers_count":1,"watchers_count":1,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"navikt:master","ref":"master","sha":"09dc0bb5acfb29bdaa9a6c8a5347b8149da96b09","user":{"login":"navikt","id":11848947,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExODQ4OTQ3","avatar_url":"https://avatars3.githubusercontent.com/u/11848947?v=4","gravatar_id":"","url":"https://api.github.com/users/navikt","html_url":"https://github.com/navikt","followers_url":"https://api.github.com/users/navikt/followers","following_url":"https://api.github.com/users/navikt/following{/other_user}","gists_url":"https://api.github.com/users/navikt/gists{/gist_id}","starred_url":"https://api.github.com/users/navikt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/navikt/subscriptions","organizations_url":"https://api.github.com/users/navikt/orgs","repos_url":"https://api.github.com/users/navikt/repos","events_url":"https://api.github.com/users/navikt/events{/privacy}","received_events_url":"https://api.github.com/users/navikt/received_events","type":"Organization","site_admin":false},"repo":{"id":130855671,"node_id":"MDEwOlJlcG9zaXRvcnkxMzA4NTU2NzE=","name":"foreldrepengesoknad","full_name":"navikt/foreldrepengesoknad","owner":{"login":"navikt","id":11848947,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExODQ4OTQ3","avatar_url":"https://avatars3.githubusercontent.com/u/11848947?v=4","gravatar_id":"","url":"https://api.github.com/users/navikt","html_url":"https://github.com/navikt","followers_url":"https://api.github.com/users/navikt/followers","following_url":"https://api.github.com/users/navikt/following{/other_user}","gists_url":"https://api.github.com/users/navikt/gists{/gist_id}","starred_url":"https://api.github.com/users/navikt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/navikt/subscriptions","organizations_url":"https://api.github.com/users/navikt/orgs","repos_url":"https://api.github.com/users/navikt/repos","events_url":"https://api.github.com/users/navikt/events{/privacy}","received_events_url":"https://api.github.com/users/navikt/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/navikt/foreldrepengesoknad","description":"Selvbetjeningsløsning for søknad om foreldrepenger","fork":false,"url":"https://api.github.com/repos/navikt/foreldrepengesoknad","forks_url":"https://api.github.com/repos/navikt/foreldrepengesoknad/forks","keys_url":"https://api.github.com/repos/navikt/foreldrepengesoknad/keys{/key_id}","collaborators_url":"https://api.github.com/repos/navikt/foreldrepengesoknad/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/navikt/foreldrepengesoknad/teams","hooks_url":"https://api.github.com/repos/navikt/foreldrepengesoknad/hooks","issue_events_url":"https://api.github.com/repos/navikt/foreldrepengesoknad/issues/events{/number}","events_url":"https://api.github.com/repos/navikt/foreldrepengesoknad/events","assignees_url":"https://api.github.com/repos/navikt/foreldrepengesoknad/assignees{/user}","branches_url":"https://api.github.com/repos/navikt/foreldrepengesoknad/branches{/branch}","tags_url":"https://api.github.com/repos/navikt/foreldrepengesoknad/tags","blobs_url":"https://api.github.com/repos/navikt/foreldrepengesoknad/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/navikt/foreldrepengesoknad/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/navikt/foreldrepengesoknad/git/refs{/sha}","trees_url":"https://api.github.com/repos/navikt/foreldrepengesoknad/git/trees{/sha}","statuses_url":"https://api.github.com/repos/navikt/foreldrepengesoknad/statuses/{sha}","languages_url":"https://api.github.com/repos/navikt/foreldrepengesoknad/languages","stargazers_url":"https://api.github.com/repos/navikt/foreldrepengesoknad/stargazers","contributors_url":"https://api.github.com/repos/navikt/foreldrepengesoknad/contributors","subscribers_url":"https://api.github.com/repos/navikt/foreldrepengesoknad/subscribers","subscription_url":"https://api.github.com/repos/navikt/foreldrepengesoknad/subscription","commits_url":"https://api.github.com/repos/navikt/foreldrepengesoknad/commits{/sha}","git_commits_url":"https://api.github.com/repos/navikt/foreldrepengesoknad/git/commits{/sha}","comments_url":"https://api.github.com/repos/navikt/foreldrepengesoknad/comments{/number}","issue_comment_url":"https://api.github.com/repos/navikt/foreldrepengesoknad/issues/comments{/number}","contents_url":"https://api.github.com/repos/navikt/foreldrepengesoknad/contents/{+path}","compare_url":"https://api.github.com/repos/navikt/foreldrepengesoknad/compare/{base}...{head}","merges_url":"https://api.github.com/repos/navikt/foreldrepengesoknad/merges","archive_url":"https://api.github.com/repos/navikt/foreldrepengesoknad/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/navikt/foreldrepengesoknad/downloads","issues_url":"https://api.github.com/repos/navikt/foreldrepengesoknad/issues{/number}","pulls_url":"https://api.github.com/repos/navikt/foreldrepengesoknad/pulls{/number}","milestones_url":"https://api.github.com/repos/navikt/foreldrepengesoknad/milestones{/number}","notifications_url":"https://api.github.com/repos/navikt/foreldrepengesoknad/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/navikt/foreldrepengesoknad/labels{/name}","releases_url":"https://api.github.com/repos/navikt/foreldrepengesoknad/releases{/id}","deployments_url":"https://api.github.com/repos/navikt/foreldrepengesoknad/deployments","created_at":"2018-04-24T13:06:00Z","updated_at":"2018-06-01T12:27:47Z","pushed_at":"2018-06-01T12:37:21Z","git_url":"git://github.com/navikt/foreldrepengesoknad.git","ssh_url":"[email protected]:navikt/foreldrepengesoknad.git","clone_url":"https://github.com/navikt/foreldrepengesoknad.git","svn_url":"https://github.com/navikt/foreldrepengesoknad","homepage":null,"size":1164,"stargazers_count":1,"watchers_count":1,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/navikt/foreldrepengesoknad/pulls/78"},"html":{"href":"https://github.com/navikt/foreldrepengesoknad/pull/78"},"issue":{"href":"https://api.github.com/repos/navikt/foreldrepengesoknad/issues/78"},"comments":{"href":"https://api.github.com/repos/navikt/foreldrepengesoknad/issues/78/comments"},"review_comments":{"href":"https://api.github.com/repos/navikt/foreldrepengesoknad/pulls/78/comments"},"review_comment":{"href":"https://api.github.com/repos/navikt/foreldrepengesoknad/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/navikt/foreldrepengesoknad/pulls/78/commits"},"statuses":{"href":"https://api.github.com/repos/navikt/foreldrepengesoknad/statuses/a1d1cd7597843f5bb90ec2d7810e6df4ce2a14f6"}},"author_association":"CONTRIBUTOR"}} | {
"id": 130855671,
"name": "navikt/foreldrepengesoknad",
"url": "https://api.github.com/repos/navikt/foreldrepengesoknad"
} | {
"id": 1488626,
"login": "erlendev",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1488626?",
"url": "https://api.github.com/users/erlendev"
} | {
"id": 11848947,
"login": "navikt",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/11848947?",
"url": "https://api.github.com/orgs/navikt"
} | 2018-06-01T13:00:15 | 7762275209 | {"actor":{"display_login":"erlendev"}} |
Subsets and Splits