type
stringclasses 14
values | public
bool 1
class | payload
stringlengths 2
363k
| repo
dict | actor
dict | org
dict | created_at
timestamp[us] | id
stringlengths 10
10
| other
stringlengths 31
69
|
|---|---|---|---|---|---|---|---|---|
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/thecartercenter/elmo/pulls/comments/197126076","pull_request_review_id":130807026,"id":197126076,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NzEyNjA3Ng==","diff_hunk":"@@ -0,0 +1,270 @@\n+require \"spec_helper\"\n+\n+describe Odk::ResponseParser do\n+ include_context \"response tree\"\n+\n+ let(:save_fixtures) { true }\n+ let(:form) { create(:form, :published, :with_version, question_types: question_types) }\n+ let(:files) { {xml_submission_file: StringIO.new(xml)} }\n+ let(:response) { Response.new(form: form, mission: form.mission, user: create(:user)) }\n+ let(:xml) { prepare_odk_response_fixture(filename, form, values: xml_values) }\n+\n+ context \"simple form\" do\n+ let(:filename) { \"simple_response.xml\" }\n+\n+ context \"text questions only\" do\n+ let(:question_types) { %w[text text text] }\n+ let(:xml_values) { %w[A B C] }\n+ let(:expected_values) { xml_values }\n+\n+ context \"valid input\" do\n+ it \"should produce a simple tree from a form with three children\" do\n+ Odk::ResponseParser.new(response: response, files: files).populate_response\n+\n+ expect_children(response.root_node, %w[Answer Answer Answer], form.c.map(&:id), expected_values)\n+ end\n+ end\n+\n+ context \"with earlier odk code style for questionings\" do\n+ xit \"should parse the response\" do\n+","path":"spec/models/odk/response_parser_spec.rb","position":30,"original_position":30,"commit_id":"aecd209d8e158b9ed00e582f98e2b701ce92dd58","original_commit_id":"aecd209d8e158b9ed00e582f98e2b701ce92dd58","user":{"login":"houndci-bot","id":6697940,"node_id":"MDQ6VXNlcjY2OTc5NDA=","avatar_url":"https://avatars0.githubusercontent.com/u/6697940?v=4","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"Layout/EmptyLinesAroundBlockBody: Extra empty line detected at block body beginning.","created_at":"2018-06-21T13:10:06Z","updated_at":"2018-06-21T13:10:07Z","html_url":"https://github.com/thecartercenter/elmo/pull/452#discussion_r197126076","pull_request_url":"https://api.github.com/repos/thecartercenter/elmo/pulls/452","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/thecartercenter/elmo/pulls/comments/197126076"},"html":{"href":"https://github.com/thecartercenter/elmo/pull/452#discussion_r197126076"},"pull_request":{"href":"https://api.github.com/repos/thecartercenter/elmo/pulls/452"}}},"pull_request":{"url":"https://api.github.com/repos/thecartercenter/elmo/pulls/452","id":194000749,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0MDAwNzQ5","html_url":"https://github.com/thecartercenter/elmo/pull/452","diff_url":"https://github.com/thecartercenter/elmo/pull/452.diff","patch_url":"https://github.com/thecartercenter/elmo/pull/452.patch","issue_url":"https://api.github.com/repos/thecartercenter/elmo/issues/452","number":452,"state":"open","locked":false,"title":"6441 v2 nested groups odk submission","user":{"login":"DevneyHamilton","id":4730344,"node_id":"MDQ6VXNlcjQ3MzAzNDQ=","avatar_url":"https://avatars2.githubusercontent.com/u/4730344?v=4","gravatar_id":"","url":"https://api.github.com/users/DevneyHamilton","html_url":"https://github.com/DevneyHamilton","followers_url":"https://api.github.com/users/DevneyHamilton/followers","following_url":"https://api.github.com/users/DevneyHamilton/following{/other_user}","gists_url":"https://api.github.com/users/DevneyHamilton/gists{/gist_id}","starred_url":"https://api.github.com/users/DevneyHamilton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DevneyHamilton/subscriptions","organizations_url":"https://api.github.com/users/DevneyHamilton/orgs","repos_url":"https://api.github.com/users/DevneyHamilton/repos","events_url":"https://api.github.com/users/DevneyHamilton/events{/privacy}","received_events_url":"https://api.github.com/users/DevneyHamilton/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-06-11T14:31:43Z","updated_at":"2018-06-21T13:10:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e33e91272b3833fb8d9fe6456812ba3589faad7f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":558032990,"node_id":"MDU6TGFiZWw1NTgwMzI5OTA=","url":"https://api.github.com/repos/thecartercenter/elmo/labels/in%20progress","name":"in progress","color":"5319e7","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/thecartercenter/elmo/pulls/452/commits","review_comments_url":"https://api.github.com/repos/thecartercenter/elmo/pulls/452/comments","review_comment_url":"https://api.github.com/repos/thecartercenter/elmo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/thecartercenter/elmo/issues/452/comments","statuses_url":"https://api.github.com/repos/thecartercenter/elmo/statuses/aecd209d8e158b9ed00e582f98e2b701ce92dd58","head":{"label":"thecartercenter:6441_v2_nested_groups_odk_submission","ref":"6441_v2_nested_groups_odk_submission","sha":"aecd209d8e158b9ed00e582f98e2b701ce92dd58","user":{"login":"thecartercenter","id":5075178,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUwNzUxNzg=","avatar_url":"https://avatars1.githubusercontent.com/u/5075178?v=4","gravatar_id":"","url":"https://api.github.com/users/thecartercenter","html_url":"https://github.com/thecartercenter","followers_url":"https://api.github.com/users/thecartercenter/followers","following_url":"https://api.github.com/users/thecartercenter/following{/other_user}","gists_url":"https://api.github.com/users/thecartercenter/gists{/gist_id}","starred_url":"https://api.github.com/users/thecartercenter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thecartercenter/subscriptions","organizations_url":"https://api.github.com/users/thecartercenter/orgs","repos_url":"https://api.github.com/users/thecartercenter/repos","events_url":"https://api.github.com/users/thecartercenter/events{/privacy}","received_events_url":"https://api.github.com/users/thecartercenter/received_events","type":"Organization","site_admin":false},"repo":{"id":11615188,"node_id":"MDEwOlJlcG9zaXRvcnkxMTYxNTE4OA==","name":"elmo","full_name":"thecartercenter/elmo","owner":{"login":"thecartercenter","id":5075178,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUwNzUxNzg=","avatar_url":"https://avatars1.githubusercontent.com/u/5075178?v=4","gravatar_id":"","url":"https://api.github.com/users/thecartercenter","html_url":"https://github.com/thecartercenter","followers_url":"https://api.github.com/users/thecartercenter/followers","following_url":"https://api.github.com/users/thecartercenter/following{/other_user}","gists_url":"https://api.github.com/users/thecartercenter/gists{/gist_id}","starred_url":"https://api.github.com/users/thecartercenter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thecartercenter/subscriptions","organizations_url":"https://api.github.com/users/thecartercenter/orgs","repos_url":"https://api.github.com/users/thecartercenter/repos","events_url":"https://api.github.com/users/thecartercenter/events{/privacy}","received_events_url":"https://api.github.com/users/thecartercenter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/thecartercenter/elmo","description":" ELMO is a mobile data collection and analysis web application.","fork":false,"url":"https://api.github.com/repos/thecartercenter/elmo","forks_url":"https://api.github.com/repos/thecartercenter/elmo/forks","keys_url":"https://api.github.com/repos/thecartercenter/elmo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thecartercenter/elmo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thecartercenter/elmo/teams","hooks_url":"https://api.github.com/repos/thecartercenter/elmo/hooks","issue_events_url":"https://api.github.com/repos/thecartercenter/elmo/issues/events{/number}","events_url":"https://api.github.com/repos/thecartercenter/elmo/events","assignees_url":"https://api.github.com/repos/thecartercenter/elmo/assignees{/user}","branches_url":"https://api.github.com/repos/thecartercenter/elmo/branches{/branch}","tags_url":"https://api.github.com/repos/thecartercenter/elmo/tags","blobs_url":"https://api.github.com/repos/thecartercenter/elmo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thecartercenter/elmo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thecartercenter/elmo/git/refs{/sha}","trees_url":"https://api.github.com/repos/thecartercenter/elmo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thecartercenter/elmo/statuses/{sha}","languages_url":"https://api.github.com/repos/thecartercenter/elmo/languages","stargazers_url":"https://api.github.com/repos/thecartercenter/elmo/stargazers","contributors_url":"https://api.github.com/repos/thecartercenter/elmo/contributors","subscribers_url":"https://api.github.com/repos/thecartercenter/elmo/subscribers","subscription_url":"https://api.github.com/repos/thecartercenter/elmo/subscription","commits_url":"https://api.github.com/repos/thecartercenter/elmo/commits{/sha}","git_commits_url":"https://api.github.com/repos/thecartercenter/elmo/git/commits{/sha}","comments_url":"https://api.github.com/repos/thecartercenter/elmo/comments{/number}","issue_comment_url":"https://api.github.com/repos/thecartercenter/elmo/issues/comments{/number}","contents_url":"https://api.github.com/repos/thecartercenter/elmo/contents/{+path}","compare_url":"https://api.github.com/repos/thecartercenter/elmo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thecartercenter/elmo/merges","archive_url":"https://api.github.com/repos/thecartercenter/elmo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thecartercenter/elmo/downloads","issues_url":"https://api.github.com/repos/thecartercenter/elmo/issues{/number}","pulls_url":"https://api.github.com/repos/thecartercenter/elmo/pulls{/number}","milestones_url":"https://api.github.com/repos/thecartercenter/elmo/milestones{/number}","notifications_url":"https://api.github.com/repos/thecartercenter/elmo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thecartercenter/elmo/labels{/name}","releases_url":"https://api.github.com/repos/thecartercenter/elmo/releases{/id}","deployments_url":"https://api.github.com/repos/thecartercenter/elmo/deployments","created_at":"2013-07-23T17:56:04Z","updated_at":"2018-06-21T10:33:41Z","pushed_at":"2018-06-21T13:09:44Z","git_url":"git://github.com/thecartercenter/elmo.git","ssh_url":"[email protected]:thecartercenter/elmo.git","clone_url":"https://github.com/thecartercenter/elmo.git","svn_url":"https://github.com/thecartercenter/elmo","homepage":"https://getelmo.org","size":73491,"stargazers_count":35,"watchers_count":35,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":38,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":38,"open_issues":3,"watchers":35,"default_branch":"develop"}},"base":{"label":"thecartercenter:develop","ref":"develop","sha":"0451aa765f0682c4d9c117e448b0e11a9a999b54","user":{"login":"thecartercenter","id":5075178,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUwNzUxNzg=","avatar_url":"https://avatars1.githubusercontent.com/u/5075178?v=4","gravatar_id":"","url":"https://api.github.com/users/thecartercenter","html_url":"https://github.com/thecartercenter","followers_url":"https://api.github.com/users/thecartercenter/followers","following_url":"https://api.github.com/users/thecartercenter/following{/other_user}","gists_url":"https://api.github.com/users/thecartercenter/gists{/gist_id}","starred_url":"https://api.github.com/users/thecartercenter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thecartercenter/subscriptions","organizations_url":"https://api.github.com/users/thecartercenter/orgs","repos_url":"https://api.github.com/users/thecartercenter/repos","events_url":"https://api.github.com/users/thecartercenter/events{/privacy}","received_events_url":"https://api.github.com/users/thecartercenter/received_events","type":"Organization","site_admin":false},"repo":{"id":11615188,"node_id":"MDEwOlJlcG9zaXRvcnkxMTYxNTE4OA==","name":"elmo","full_name":"thecartercenter/elmo","owner":{"login":"thecartercenter","id":5075178,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUwNzUxNzg=","avatar_url":"https://avatars1.githubusercontent.com/u/5075178?v=4","gravatar_id":"","url":"https://api.github.com/users/thecartercenter","html_url":"https://github.com/thecartercenter","followers_url":"https://api.github.com/users/thecartercenter/followers","following_url":"https://api.github.com/users/thecartercenter/following{/other_user}","gists_url":"https://api.github.com/users/thecartercenter/gists{/gist_id}","starred_url":"https://api.github.com/users/thecartercenter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thecartercenter/subscriptions","organizations_url":"https://api.github.com/users/thecartercenter/orgs","repos_url":"https://api.github.com/users/thecartercenter/repos","events_url":"https://api.github.com/users/thecartercenter/events{/privacy}","received_events_url":"https://api.github.com/users/thecartercenter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/thecartercenter/elmo","description":" ELMO is a mobile data collection and analysis web application.","fork":false,"url":"https://api.github.com/repos/thecartercenter/elmo","forks_url":"https://api.github.com/repos/thecartercenter/elmo/forks","keys_url":"https://api.github.com/repos/thecartercenter/elmo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thecartercenter/elmo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thecartercenter/elmo/teams","hooks_url":"https://api.github.com/repos/thecartercenter/elmo/hooks","issue_events_url":"https://api.github.com/repos/thecartercenter/elmo/issues/events{/number}","events_url":"https://api.github.com/repos/thecartercenter/elmo/events","assignees_url":"https://api.github.com/repos/thecartercenter/elmo/assignees{/user}","branches_url":"https://api.github.com/repos/thecartercenter/elmo/branches{/branch}","tags_url":"https://api.github.com/repos/thecartercenter/elmo/tags","blobs_url":"https://api.github.com/repos/thecartercenter/elmo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thecartercenter/elmo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thecartercenter/elmo/git/refs{/sha}","trees_url":"https://api.github.com/repos/thecartercenter/elmo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thecartercenter/elmo/statuses/{sha}","languages_url":"https://api.github.com/repos/thecartercenter/elmo/languages","stargazers_url":"https://api.github.com/repos/thecartercenter/elmo/stargazers","contributors_url":"https://api.github.com/repos/thecartercenter/elmo/contributors","subscribers_url":"https://api.github.com/repos/thecartercenter/elmo/subscribers","subscription_url":"https://api.github.com/repos/thecartercenter/elmo/subscription","commits_url":"https://api.github.com/repos/thecartercenter/elmo/commits{/sha}","git_commits_url":"https://api.github.com/repos/thecartercenter/elmo/git/commits{/sha}","comments_url":"https://api.github.com/repos/thecartercenter/elmo/comments{/number}","issue_comment_url":"https://api.github.com/repos/thecartercenter/elmo/issues/comments{/number}","contents_url":"https://api.github.com/repos/thecartercenter/elmo/contents/{+path}","compare_url":"https://api.github.com/repos/thecartercenter/elmo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thecartercenter/elmo/merges","archive_url":"https://api.github.com/repos/thecartercenter/elmo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thecartercenter/elmo/downloads","issues_url":"https://api.github.com/repos/thecartercenter/elmo/issues{/number}","pulls_url":"https://api.github.com/repos/thecartercenter/elmo/pulls{/number}","milestones_url":"https://api.github.com/repos/thecartercenter/elmo/milestones{/number}","notifications_url":"https://api.github.com/repos/thecartercenter/elmo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thecartercenter/elmo/labels{/name}","releases_url":"https://api.github.com/repos/thecartercenter/elmo/releases{/id}","deployments_url":"https://api.github.com/repos/thecartercenter/elmo/deployments","created_at":"2013-07-23T17:56:04Z","updated_at":"2018-06-21T10:33:41Z","pushed_at":"2018-06-21T13:09:44Z","git_url":"git://github.com/thecartercenter/elmo.git","ssh_url":"[email protected]:thecartercenter/elmo.git","clone_url":"https://github.com/thecartercenter/elmo.git","svn_url":"https://github.com/thecartercenter/elmo","homepage":"https://getelmo.org","size":73491,"stargazers_count":35,"watchers_count":35,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":38,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":38,"open_issues":3,"watchers":35,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/thecartercenter/elmo/pulls/452"},"html":{"href":"https://github.com/thecartercenter/elmo/pull/452"},"issue":{"href":"https://api.github.com/repos/thecartercenter/elmo/issues/452"},"comments":{"href":"https://api.github.com/repos/thecartercenter/elmo/issues/452/comments"},"review_comments":{"href":"https://api.github.com/repos/thecartercenter/elmo/pulls/452/comments"},"review_comment":{"href":"https://api.github.com/repos/thecartercenter/elmo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/thecartercenter/elmo/pulls/452/commits"},"statuses":{"href":"https://api.github.com/repos/thecartercenter/elmo/statuses/aecd209d8e158b9ed00e582f98e2b701ce92dd58"}},"author_association":"CONTRIBUTOR"}} | {
"id": 11615188,
"name": "thecartercenter/elmo",
"url": "https://api.github.com/repos/thecartercenter/elmo"
} | {
"id": 6697940,
"login": "houndci-bot",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6697940?",
"url": "https://api.github.com/users/houndci-bot"
} | {
"id": 5075178,
"login": "thecartercenter",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5075178?",
"url": "https://api.github.com/orgs/thecartercenter"
} | 2018-06-21T13:10:06 | 7858153798 | {"actor":{"display_login":"houndci-bot"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/kframework/kore/pulls/comments/224926962","pull_request_review_id":164423888,"id":224926962,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNDkyNjk2Mg==","diff_hunk":"@@ -52,6 +54,31 @@ import Kore.Unification.UnifierImpl\n ( normalizeSubstitutionDuplication )\n import Kore.Variables.Fresh\n \n+\n+-- | Normalize the substitution of 'expanded', or return 'bottom' if\n+-- normalization fails.\n+normalize \n+ :: forall level variable m . \n+ ( level ~ Object\n+ , Monad m\n+ , MonadCounter m\n+ , MetaOrObject level\n+ , Hashable variable\n+ , FreshVariable variable\n+ , SortedVariable variable\n+ , OrdMetaOrObject variable\n+ , ShowMetaOrObject variable\n+ ) \n+ => MetadataTools level StepperAttributes \n+ -> ExpandedPattern level variable \n+ -> m (ExpandedPattern level variable)\n+normalize tools r =\n+ runExceptT (normalizePredicatedSubstitution tools r)\n+ >>= \\case\n+ Left _ -> return ExpandedPattern.bottom","path":"src/main/haskell/kore/src/Kore/Step/Substitution.hs","position":44,"original_position":44,"commit_id":"5180e8d6f06b0065ffbae124120307907f3679c4","original_commit_id":"903965912ed847ddc5ef60a0111213dfbeb2daf3","user":{"login":"u--","id":2020439,"node_id":"MDQ6VXNlcjIwMjA0Mzk=","avatar_url":"https://avatars0.githubusercontent.com/u/2020439?v=4","gravatar_id":"","url":"https://api.github.com/users/u--","html_url":"https://github.com/u--","followers_url":"https://api.github.com/users/u--/followers","following_url":"https://api.github.com/users/u--/following{/other_user}","gists_url":"https://api.github.com/users/u--/gists{/gist_id}","starred_url":"https://api.github.com/users/u--/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/u--/subscriptions","organizations_url":"https://api.github.com/users/u--/orgs","repos_url":"https://api.github.com/users/u--/repos","events_url":"https://api.github.com/users/u--/events{/privacy}","received_events_url":"https://api.github.com/users/u--/received_events","type":"User","site_admin":false},"body":"I'm not sure I understand what the issue is. `normalizePredicatedSubstitution` returns `Left` if it doesn't know how to normalize a list of substitutions. That list of substitutions is itself correct and unique for a given unification (sub-) problem.","created_at":"2018-10-12T22:06:22Z","updated_at":"2018-10-12T22:06:22Z","html_url":"https://github.com/kframework/kore/pull/269#discussion_r224926962","pull_request_url":"https://api.github.com/repos/kframework/kore/pulls/269","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/kframework/kore/pulls/comments/224926962"},"html":{"href":"https://github.com/kframework/kore/pull/269#discussion_r224926962"},"pull_request":{"href":"https://api.github.com/repos/kframework/kore/pulls/269"}},"in_reply_to_id":224891715},"pull_request":{"url":"https://api.github.com/repos/kframework/kore/pulls/269","id":222556582,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyNTU2NTgy","html_url":"https://github.com/kframework/kore/pull/269","diff_url":"https://github.com/kframework/kore/pull/269.diff","patch_url":"https://github.com/kframework/kore/pull/269.patch","issue_url":"https://api.github.com/repos/kframework/kore/issues/269","number":269,"state":"open","locked":false,"title":"Unify builtin lists","user":{"login":"u--","id":2020439,"node_id":"MDQ6VXNlcjIwMjA0Mzk=","avatar_url":"https://avatars0.githubusercontent.com/u/2020439?v=4","gravatar_id":"","url":"https://api.github.com/users/u--","html_url":"https://github.com/u--","followers_url":"https://api.github.com/users/u--/followers","following_url":"https://api.github.com/users/u--/following{/other_user}","gists_url":"https://api.github.com/users/u--/gists{/gist_id}","starred_url":"https://api.github.com/users/u--/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/u--/subscriptions","organizations_url":"https://api.github.com/users/u--/orgs","repos_url":"https://api.github.com/users/u--/repos","events_url":"https://api.github.com/users/u--/events{/privacy}","received_events_url":"https://api.github.com/users/u--/received_events","type":"User","site_admin":false},"body":"###### Reviewer checklist\r\n\r\n- [ ] Test coverage: `stack test --coverage`\r\n- [ ] Public API documentation: `stack haddock`\r\n- [ ] Style conformance: `stylish-haskell`\r\n\r\n---\r\n\r\n","created_at":"2018-10-12T18:56:36Z","updated_at":"2018-10-12T22:06:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4a8784b19005e23ee96f7753784c0dbea79d8670","assignee":null,"assignees":[],"requested_reviewers":[{"login":"ttuegel","id":563054,"node_id":"MDQ6VXNlcjU2MzA1NA==","avatar_url":"https://avatars1.githubusercontent.com/u/563054?v=4","gravatar_id":"","url":"https://api.github.com/users/ttuegel","html_url":"https://github.com/ttuegel","followers_url":"https://api.github.com/users/ttuegel/followers","following_url":"https://api.github.com/users/ttuegel/following{/other_user}","gists_url":"https://api.github.com/users/ttuegel/gists{/gist_id}","starred_url":"https://api.github.com/users/ttuegel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ttuegel/subscriptions","organizations_url":"https://api.github.com/users/ttuegel/orgs","repos_url":"https://api.github.com/users/ttuegel/repos","events_url":"https://api.github.com/users/ttuegel/events{/privacy}","received_events_url":"https://api.github.com/users/ttuegel/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/kframework/kore/pulls/269/commits","review_comments_url":"https://api.github.com/repos/kframework/kore/pulls/269/comments","review_comment_url":"https://api.github.com/repos/kframework/kore/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kframework/kore/issues/269/comments","statuses_url":"https://api.github.com/repos/kframework/kore/statuses/5180e8d6f06b0065ffbae124120307907f3679c4","head":{"label":"u--:unify-builtin-list","ref":"unify-builtin-list","sha":"5180e8d6f06b0065ffbae124120307907f3679c4","user":{"login":"u--","id":2020439,"node_id":"MDQ6VXNlcjIwMjA0Mzk=","avatar_url":"https://avatars0.githubusercontent.com/u/2020439?v=4","gravatar_id":"","url":"https://api.github.com/users/u--","html_url":"https://github.com/u--","followers_url":"https://api.github.com/users/u--/followers","following_url":"https://api.github.com/users/u--/following{/other_user}","gists_url":"https://api.github.com/users/u--/gists{/gist_id}","starred_url":"https://api.github.com/users/u--/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/u--/subscriptions","organizations_url":"https://api.github.com/users/u--/orgs","repos_url":"https://api.github.com/users/u--/repos","events_url":"https://api.github.com/users/u--/events{/privacy}","received_events_url":"https://api.github.com/users/u--/received_events","type":"User","site_admin":false},"repo":{"id":135204047,"node_id":"MDEwOlJlcG9zaXRvcnkxMzUyMDQwNDc=","name":"kore","full_name":"u--/kore","private":false,"owner":{"login":"u--","id":2020439,"node_id":"MDQ6VXNlcjIwMjA0Mzk=","avatar_url":"https://avatars0.githubusercontent.com/u/2020439?v=4","gravatar_id":"","url":"https://api.github.com/users/u--","html_url":"https://github.com/u--","followers_url":"https://api.github.com/users/u--/followers","following_url":"https://api.github.com/users/u--/following{/other_user}","gists_url":"https://api.github.com/users/u--/gists{/gist_id}","starred_url":"https://api.github.com/users/u--/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/u--/subscriptions","organizations_url":"https://api.github.com/users/u--/orgs","repos_url":"https://api.github.com/users/u--/repos","events_url":"https://api.github.com/users/u--/events{/privacy}","received_events_url":"https://api.github.com/users/u--/received_events","type":"User","site_admin":false},"html_url":"https://github.com/u--/kore","description":null,"fork":true,"url":"https://api.github.com/repos/u--/kore","forks_url":"https://api.github.com/repos/u--/kore/forks","keys_url":"https://api.github.com/repos/u--/kore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/u--/kore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/u--/kore/teams","hooks_url":"https://api.github.com/repos/u--/kore/hooks","issue_events_url":"https://api.github.com/repos/u--/kore/issues/events{/number}","events_url":"https://api.github.com/repos/u--/kore/events","assignees_url":"https://api.github.com/repos/u--/kore/assignees{/user}","branches_url":"https://api.github.com/repos/u--/kore/branches{/branch}","tags_url":"https://api.github.com/repos/u--/kore/tags","blobs_url":"https://api.github.com/repos/u--/kore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/u--/kore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/u--/kore/git/refs{/sha}","trees_url":"https://api.github.com/repos/u--/kore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/u--/kore/statuses/{sha}","languages_url":"https://api.github.com/repos/u--/kore/languages","stargazers_url":"https://api.github.com/repos/u--/kore/stargazers","contributors_url":"https://api.github.com/repos/u--/kore/contributors","subscribers_url":"https://api.github.com/repos/u--/kore/subscribers","subscription_url":"https://api.github.com/repos/u--/kore/subscription","commits_url":"https://api.github.com/repos/u--/kore/commits{/sha}","git_commits_url":"https://api.github.com/repos/u--/kore/git/commits{/sha}","comments_url":"https://api.github.com/repos/u--/kore/comments{/number}","issue_comment_url":"https://api.github.com/repos/u--/kore/issues/comments{/number}","contents_url":"https://api.github.com/repos/u--/kore/contents/{+path}","compare_url":"https://api.github.com/repos/u--/kore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/u--/kore/merges","archive_url":"https://api.github.com/repos/u--/kore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/u--/kore/downloads","issues_url":"https://api.github.com/repos/u--/kore/issues{/number}","pulls_url":"https://api.github.com/repos/u--/kore/pulls{/number}","milestones_url":"https://api.github.com/repos/u--/kore/milestones{/number}","notifications_url":"https://api.github.com/repos/u--/kore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/u--/kore/labels{/name}","releases_url":"https://api.github.com/repos/u--/kore/releases{/id}","deployments_url":"https://api.github.com/repos/u--/kore/deployments","created_at":"2018-05-28T20:01:51Z","updated_at":"2018-10-11T15:46:41Z","pushed_at":"2018-10-12T20:14:39Z","git_url":"git://github.com/u--/kore.git","ssh_url":"[email protected]:u--/kore.git","clone_url":"https://github.com/u--/kore.git","svn_url":"https://github.com/u--/kore","homepage":null,"size":29280,"stargazers_count":0,"watchers_count":0,"language":"Haskell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kframework:master","ref":"master","sha":"a4c1799ac90f48d10042dc760992555b4f2c6586","user":{"login":"kframework","id":5104335,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUxMDQzMzU=","avatar_url":"https://avatars2.githubusercontent.com/u/5104335?v=4","gravatar_id":"","url":"https://api.github.com/users/kframework","html_url":"https://github.com/kframework","followers_url":"https://api.github.com/users/kframework/followers","following_url":"https://api.github.com/users/kframework/following{/other_user}","gists_url":"https://api.github.com/users/kframework/gists{/gist_id}","starred_url":"https://api.github.com/users/kframework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kframework/subscriptions","organizations_url":"https://api.github.com/users/kframework/orgs","repos_url":"https://api.github.com/users/kframework/repos","events_url":"https://api.github.com/users/kframework/events{/privacy}","received_events_url":"https://api.github.com/users/kframework/received_events","type":"Organization","site_admin":false},"repo":{"id":78608190,"node_id":"MDEwOlJlcG9zaXRvcnk3ODYwODE5MA==","name":"kore","full_name":"kframework/kore","private":false,"owner":{"login":"kframework","id":5104335,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUxMDQzMzU=","avatar_url":"https://avatars2.githubusercontent.com/u/5104335?v=4","gravatar_id":"","url":"https://api.github.com/users/kframework","html_url":"https://github.com/kframework","followers_url":"https://api.github.com/users/kframework/followers","following_url":"https://api.github.com/users/kframework/following{/other_user}","gists_url":"https://api.github.com/users/kframework/gists{/gist_id}","starred_url":"https://api.github.com/users/kframework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kframework/subscriptions","organizations_url":"https://api.github.com/users/kframework/orgs","repos_url":"https://api.github.com/users/kframework/repos","events_url":"https://api.github.com/users/kframework/events{/privacy}","received_events_url":"https://api.github.com/users/kframework/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/kframework/kore","description":null,"fork":false,"url":"https://api.github.com/repos/kframework/kore","forks_url":"https://api.github.com/repos/kframework/kore/forks","keys_url":"https://api.github.com/repos/kframework/kore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kframework/kore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kframework/kore/teams","hooks_url":"https://api.github.com/repos/kframework/kore/hooks","issue_events_url":"https://api.github.com/repos/kframework/kore/issues/events{/number}","events_url":"https://api.github.com/repos/kframework/kore/events","assignees_url":"https://api.github.com/repos/kframework/kore/assignees{/user}","branches_url":"https://api.github.com/repos/kframework/kore/branches{/branch}","tags_url":"https://api.github.com/repos/kframework/kore/tags","blobs_url":"https://api.github.com/repos/kframework/kore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kframework/kore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kframework/kore/git/refs{/sha}","trees_url":"https://api.github.com/repos/kframework/kore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kframework/kore/statuses/{sha}","languages_url":"https://api.github.com/repos/kframework/kore/languages","stargazers_url":"https://api.github.com/repos/kframework/kore/stargazers","contributors_url":"https://api.github.com/repos/kframework/kore/contributors","subscribers_url":"https://api.github.com/repos/kframework/kore/subscribers","subscription_url":"https://api.github.com/repos/kframework/kore/subscription","commits_url":"https://api.github.com/repos/kframework/kore/commits{/sha}","git_commits_url":"https://api.github.com/repos/kframework/kore/git/commits{/sha}","comments_url":"https://api.github.com/repos/kframework/kore/comments{/number}","issue_comment_url":"https://api.github.com/repos/kframework/kore/issues/comments{/number}","contents_url":"https://api.github.com/repos/kframework/kore/contents/{+path}","compare_url":"https://api.github.com/repos/kframework/kore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kframework/kore/merges","archive_url":"https://api.github.com/repos/kframework/kore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kframework/kore/downloads","issues_url":"https://api.github.com/repos/kframework/kore/issues{/number}","pulls_url":"https://api.github.com/repos/kframework/kore/pulls{/number}","milestones_url":"https://api.github.com/repos/kframework/kore/milestones{/number}","notifications_url":"https://api.github.com/repos/kframework/kore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kframework/kore/labels{/name}","releases_url":"https://api.github.com/repos/kframework/kore/releases{/id}","deployments_url":"https://api.github.com/repos/kframework/kore/deployments","created_at":"2017-01-11T06:07:30Z","updated_at":"2018-10-12T20:02:37Z","pushed_at":"2018-10-12T20:14:40Z","git_url":"git://github.com/kframework/kore.git","ssh_url":"[email protected]:kframework/kore.git","clone_url":"https://github.com/kframework/kore.git","svn_url":"https://github.com/kframework/kore","homepage":null,"size":29285,"stargazers_count":50,"watchers_count":50,"language":"Haskell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":20,"mirror_url":null,"archived":false,"open_issues_count":15,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":20,"open_issues":15,"watchers":50,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kframework/kore/pulls/269"},"html":{"href":"https://github.com/kframework/kore/pull/269"},"issue":{"href":"https://api.github.com/repos/kframework/kore/issues/269"},"comments":{"href":"https://api.github.com/repos/kframework/kore/issues/269/comments"},"review_comments":{"href":"https://api.github.com/repos/kframework/kore/pulls/269/comments"},"review_comment":{"href":"https://api.github.com/repos/kframework/kore/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kframework/kore/pulls/269/commits"},"statuses":{"href":"https://api.github.com/repos/kframework/kore/statuses/5180e8d6f06b0065ffbae124120307907f3679c4"}},"author_association":"COLLABORATOR"}} | {
"id": 78608190,
"name": "kframework/kore",
"url": "https://api.github.com/repos/kframework/kore"
} | {
"id": 2020439,
"login": "u--",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2020439?",
"url": "https://api.github.com/users/u--"
} | {
"id": 5104335,
"login": "kframework",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5104335?",
"url": "https://api.github.com/orgs/kframework"
} | 2018-10-12T22:06:22 | 8413902379 | {"actor":{"display_login":"u--"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/Minecolonies/minecolonies/pulls/comments/179925492","pull_request_review_id":110264597,"id":179925492,"diff_hunk":"@@ -64,14 +63,13 @@ public void renderWorldLastEvent(@NotNull final RenderWorldLastEvent event)\n \n if (structure != null)\n {\n- final BlockPos position = Settings.instance.getPosition();\n if (Settings.instance.getStructureName().contains(AbstractEntityAIStructure.WAYPOINT_STRING))\n {\n- RenderUtils.renderWayPoints(position, world, event.getPartialTicks());\n+ //TODO: Implement waypoint rendering.\n }\n else\n {\n- RenderUtils.renderColonyBorder(position, world, event.getPartialTicks(), player, colonyBorder);\n+ //TODO: Implement rendering of the colony border.\n }\n return;\n }","path":"src/main/java/com/minecolonies/coremod/event/ClientEventHandler.java","position":24,"original_position":24,"commit_id":"4be75da5658970180d94cfd4bbf52481abee2032","original_commit_id":"4be75da5658970180d94cfd4bbf52481abee2032","user":{"login":"BuildTeamLinter","id":30551110,"avatar_url":"https://avatars0.githubusercontent.com/u/30551110?v=4","gravatar_id":"","url":"https://api.github.com/users/BuildTeamLinter","html_url":"https://github.com/BuildTeamLinter","followers_url":"https://api.github.com/users/BuildTeamLinter/followers","following_url":"https://api.github.com/users/BuildTeamLinter/following{/other_user}","gists_url":"https://api.github.com/users/BuildTeamLinter/gists{/gist_id}","starred_url":"https://api.github.com/users/BuildTeamLinter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BuildTeamLinter/subscriptions","organizations_url":"https://api.github.com/users/BuildTeamLinter/orgs","repos_url":"https://api.github.com/users/BuildTeamLinter/repos","events_url":"https://api.github.com/users/BuildTeamLinter/events{/privacy}","received_events_url":"https://api.github.com/users/BuildTeamLinter/received_events","type":"User","site_admin":false},"body":" This block of commented-out lines of code should be removed. [](https://sonar.minecolonies.com/coding_rules#rule_key=squid%3ACommentedOutCodeLine)\n","created_at":"2018-04-07T19:15:09Z","updated_at":"2018-04-07T19:15:09Z","html_url":"https://github.com/Minecolonies/minecolonies/pull/2363#discussion_r179925492","pull_request_url":"https://api.github.com/repos/Minecolonies/minecolonies/pulls/2363","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/Minecolonies/minecolonies/pulls/comments/179925492"},"html":{"href":"https://github.com/Minecolonies/minecolonies/pull/2363#discussion_r179925492"},"pull_request":{"href":"https://api.github.com/repos/Minecolonies/minecolonies/pulls/2363"}}},"pull_request":{"url":"https://api.github.com/repos/Minecolonies/minecolonies/pulls/2363","id":180018829,"html_url":"https://github.com/Minecolonies/minecolonies/pull/2363","diff_url":"https://github.com/Minecolonies/minecolonies/pull/2363.diff","patch_url":"https://github.com/Minecolonies/minecolonies/pull/2363.patch","issue_url":"https://api.github.com/repos/Minecolonies/minecolonies/issues/2363","number":2363,"state":"open","locked":false,"title":"Feature/fast render","user":{"login":"OrionDevelopment","id":5585406,"avatar_url":"https://avatars2.githubusercontent.com/u/5585406?v=4","gravatar_id":"","url":"https://api.github.com/users/OrionDevelopment","html_url":"https://github.com/OrionDevelopment","followers_url":"https://api.github.com/users/OrionDevelopment/followers","following_url":"https://api.github.com/users/OrionDevelopment/following{/other_user}","gists_url":"https://api.github.com/users/OrionDevelopment/gists{/gist_id}","starred_url":"https://api.github.com/users/OrionDevelopment/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OrionDevelopment/subscriptions","organizations_url":"https://api.github.com/users/OrionDevelopment/orgs","repos_url":"https://api.github.com/users/OrionDevelopment/repos","events_url":"https://api.github.com/users/OrionDevelopment/events{/privacy}","received_events_url":"https://api.github.com/users/OrionDevelopment/received_events","type":"User","site_admin":false},"body":"## Improvement to the WindowBuildTool and Structure rendering.\r\n\r\n### VBO Based Rendering\r\nThis introduces VBO based rendering of structures. VBO Based rendering sends the Vertex Data only once to the GPU, instead it copies the vertex data once (before rendering) into the GPU's memory using a BufferObject, and then renders the data directly from the GPU's memory every time. As you can see this improves performance a lot since the obvious bottleneck that exists between the CPU and GPU only needs to be passed once.\r\n\r\n\r\n### Advantages and new Features\r\n- Much faster rendering (see screenshots below).\r\n- A lot less artifacts due to all Blocks being rendered in one go instead of individual passes over the Shader pipeline.\r\n- Disabled culling allows for faster shader processing, due to a relatively low amount of vertices disabling culling does not decrease performance but increases it. It also makes mirroring possible.\r\n\r\n### Disadvantages and disabled Features:\r\n- Disabled rendering of anything that renders with a `TileEntitySpecialRenderer`. Sadly this makes it so that Chests, Beds and other Modblocks might not be visible.\r\n- Colony border is not being rendered.\r\nFor most of these problems I have solutions, but I think this is a good compromise for now.\r\n\r\n### Some screenshots of before and after:\r\n \r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n","created_at":"2018-04-06T18:16:34Z","updated_at":"2018-04-07T19:15:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"916ffa18605e119ac9e1675bdf97fb13bd7fcd52","assignee":{"login":"OrionDevelopment","id":5585406,"avatar_url":"https://avatars2.githubusercontent.com/u/5585406?v=4","gravatar_id":"","url":"https://api.github.com/users/OrionDevelopment","html_url":"https://github.com/OrionDevelopment","followers_url":"https://api.github.com/users/OrionDevelopment/followers","following_url":"https://api.github.com/users/OrionDevelopment/following{/other_user}","gists_url":"https://api.github.com/users/OrionDevelopment/gists{/gist_id}","starred_url":"https://api.github.com/users/OrionDevelopment/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OrionDevelopment/subscriptions","organizations_url":"https://api.github.com/users/OrionDevelopment/orgs","repos_url":"https://api.github.com/users/OrionDevelopment/repos","events_url":"https://api.github.com/users/OrionDevelopment/events{/privacy}","received_events_url":"https://api.github.com/users/OrionDevelopment/received_events","type":"User","site_admin":false},"assignees":[{"login":"OrionDevelopment","id":5585406,"avatar_url":"https://avatars2.githubusercontent.com/u/5585406?v=4","gravatar_id":"","url":"https://api.github.com/users/OrionDevelopment","html_url":"https://github.com/OrionDevelopment","followers_url":"https://api.github.com/users/OrionDevelopment/followers","following_url":"https://api.github.com/users/OrionDevelopment/following{/other_user}","gists_url":"https://api.github.com/users/OrionDevelopment/gists{/gist_id}","starred_url":"https://api.github.com/users/OrionDevelopment/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OrionDevelopment/subscriptions","organizations_url":"https://api.github.com/users/OrionDevelopment/orgs","repos_url":"https://api.github.com/users/OrionDevelopment/repos","events_url":"https://api.github.com/users/OrionDevelopment/events{/privacy}","received_events_url":"https://api.github.com/users/OrionDevelopment/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"Kostronor","id":644950,"avatar_url":"https://avatars2.githubusercontent.com/u/644950?v=4","gravatar_id":"","url":"https://api.github.com/users/Kostronor","html_url":"https://github.com/Kostronor","followers_url":"https://api.github.com/users/Kostronor/followers","following_url":"https://api.github.com/users/Kostronor/following{/other_user}","gists_url":"https://api.github.com/users/Kostronor/gists{/gist_id}","starred_url":"https://api.github.com/users/Kostronor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kostronor/subscriptions","organizations_url":"https://api.github.com/users/Kostronor/orgs","repos_url":"https://api.github.com/users/Kostronor/repos","events_url":"https://api.github.com/users/Kostronor/events{/privacy}","received_events_url":"https://api.github.com/users/Kostronor/received_events","type":"User","site_admin":false},{"login":"xavierh","id":2778556,"avatar_url":"https://avatars3.githubusercontent.com/u/2778556?v=4","gravatar_id":"","url":"https://api.github.com/users/xavierh","html_url":"https://github.com/xavierh","followers_url":"https://api.github.com/users/xavierh/followers","following_url":"https://api.github.com/users/xavierh/following{/other_user}","gists_url":"https://api.github.com/users/xavierh/gists{/gist_id}","starred_url":"https://api.github.com/users/xavierh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xavierh/subscriptions","organizations_url":"https://api.github.com/users/xavierh/orgs","repos_url":"https://api.github.com/users/xavierh/repos","events_url":"https://api.github.com/users/xavierh/events{/privacy}","received_events_url":"https://api.github.com/users/xavierh/received_events","type":"User","site_admin":false},{"login":"Raycoms","id":6438347,"avatar_url":"https://avatars1.githubusercontent.com/u/6438347?v=4","gravatar_id":"","url":"https://api.github.com/users/Raycoms","html_url":"https://github.com/Raycoms","followers_url":"https://api.github.com/users/Raycoms/followers","following_url":"https://api.github.com/users/Raycoms/following{/other_user}","gists_url":"https://api.github.com/users/Raycoms/gists{/gist_id}","starred_url":"https://api.github.com/users/Raycoms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Raycoms/subscriptions","organizations_url":"https://api.github.com/users/Raycoms/orgs","repos_url":"https://api.github.com/users/Raycoms/repos","events_url":"https://api.github.com/users/Raycoms/events{/privacy}","received_events_url":"https://api.github.com/users/Raycoms/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":424242649,"url":"https://api.github.com/repos/Minecolonies/minecolonies/labels/enhancement","name":"enhancement","color":"84b6eb","default":true},{"id":424332865,"url":"https://api.github.com/repos/Minecolonies/minecolonies/labels/ready","name":"ready","color":"c5def5","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Minecolonies/minecolonies/pulls/2363/commits","review_comments_url":"https://api.github.com/repos/Minecolonies/minecolonies/pulls/2363/comments","review_comment_url":"https://api.github.com/repos/Minecolonies/minecolonies/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Minecolonies/minecolonies/issues/2363/comments","statuses_url":"https://api.github.com/repos/Minecolonies/minecolonies/statuses/4be75da5658970180d94cfd4bbf52481abee2032","head":{"label":"Minecolonies:feature/fast-render","ref":"feature/fast-render","sha":"4be75da5658970180d94cfd4bbf52481abee2032","user":{"login":"Minecolonies","id":5167336,"avatar_url":"https://avatars3.githubusercontent.com/u/5167336?v=4","gravatar_id":"","url":"https://api.github.com/users/Minecolonies","html_url":"https://github.com/Minecolonies","followers_url":"https://api.github.com/users/Minecolonies/followers","following_url":"https://api.github.com/users/Minecolonies/following{/other_user}","gists_url":"https://api.github.com/users/Minecolonies/gists{/gist_id}","starred_url":"https://api.github.com/users/Minecolonies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Minecolonies/subscriptions","organizations_url":"https://api.github.com/users/Minecolonies/orgs","repos_url":"https://api.github.com/users/Minecolonies/repos","events_url":"https://api.github.com/users/Minecolonies/events{/privacy}","received_events_url":"https://api.github.com/users/Minecolonies/received_events","type":"Organization","site_admin":false},"repo":{"id":65616760,"name":"minecolonies","full_name":"Minecolonies/minecolonies","owner":{"login":"Minecolonies","id":5167336,"avatar_url":"https://avatars3.githubusercontent.com/u/5167336?v=4","gravatar_id":"","url":"https://api.github.com/users/Minecolonies","html_url":"https://github.com/Minecolonies","followers_url":"https://api.github.com/users/Minecolonies/followers","following_url":"https://api.github.com/users/Minecolonies/following{/other_user}","gists_url":"https://api.github.com/users/Minecolonies/gists{/gist_id}","starred_url":"https://api.github.com/users/Minecolonies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Minecolonies/subscriptions","organizations_url":"https://api.github.com/users/Minecolonies/orgs","repos_url":"https://api.github.com/users/Minecolonies/repos","events_url":"https://api.github.com/users/Minecolonies/events{/privacy}","received_events_url":"https://api.github.com/users/Minecolonies/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Minecolonies/minecolonies","description":"Minecolonies minecraft mod","fork":false,"url":"https://api.github.com/repos/Minecolonies/minecolonies","forks_url":"https://api.github.com/repos/Minecolonies/minecolonies/forks","keys_url":"https://api.github.com/repos/Minecolonies/minecolonies/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Minecolonies/minecolonies/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Minecolonies/minecolonies/teams","hooks_url":"https://api.github.com/repos/Minecolonies/minecolonies/hooks","issue_events_url":"https://api.github.com/repos/Minecolonies/minecolonies/issues/events{/number}","events_url":"https://api.github.com/repos/Minecolonies/minecolonies/events","assignees_url":"https://api.github.com/repos/Minecolonies/minecolonies/assignees{/user}","branches_url":"https://api.github.com/repos/Minecolonies/minecolonies/branches{/branch}","tags_url":"https://api.github.com/repos/Minecolonies/minecolonies/tags","blobs_url":"https://api.github.com/repos/Minecolonies/minecolonies/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Minecolonies/minecolonies/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Minecolonies/minecolonies/git/refs{/sha}","trees_url":"https://api.github.com/repos/Minecolonies/minecolonies/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Minecolonies/minecolonies/statuses/{sha}","languages_url":"https://api.github.com/repos/Minecolonies/minecolonies/languages","stargazers_url":"https://api.github.com/repos/Minecolonies/minecolonies/stargazers","contributors_url":"https://api.github.com/repos/Minecolonies/minecolonies/contributors","subscribers_url":"https://api.github.com/repos/Minecolonies/minecolonies/subscribers","subscription_url":"https://api.github.com/repos/Minecolonies/minecolonies/subscription","commits_url":"https://api.github.com/repos/Minecolonies/minecolonies/commits{/sha}","git_commits_url":"https://api.github.com/repos/Minecolonies/minecolonies/git/commits{/sha}","comments_url":"https://api.github.com/repos/Minecolonies/minecolonies/comments{/number}","issue_comment_url":"https://api.github.com/repos/Minecolonies/minecolonies/issues/comments{/number}","contents_url":"https://api.github.com/repos/Minecolonies/minecolonies/contents/{+path}","compare_url":"https://api.github.com/repos/Minecolonies/minecolonies/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Minecolonies/minecolonies/merges","archive_url":"https://api.github.com/repos/Minecolonies/minecolonies/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Minecolonies/minecolonies/downloads","issues_url":"https://api.github.com/repos/Minecolonies/minecolonies/issues{/number}","pulls_url":"https://api.github.com/repos/Minecolonies/minecolonies/pulls{/number}","milestones_url":"https://api.github.com/repos/Minecolonies/minecolonies/milestones{/number}","notifications_url":"https://api.github.com/repos/Minecolonies/minecolonies/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Minecolonies/minecolonies/labels{/name}","releases_url":"https://api.github.com/repos/Minecolonies/minecolonies/releases{/id}","deployments_url":"https://api.github.com/repos/Minecolonies/minecolonies/deployments","created_at":"2016-08-13T12:45:38Z","updated_at":"2018-04-06T02:52:05Z","pushed_at":"2018-04-07T18:49:29Z","git_url":"git://github.com/Minecolonies/minecolonies.git","ssh_url":"[email protected]:Minecolonies/minecolonies.git","clone_url":"https://github.com/Minecolonies/minecolonies.git","svn_url":"https://github.com/Minecolonies/minecolonies","homepage":"http://minecolonies.com/","size":47670,"stargazers_count":87,"watchers_count":87,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":76,"mirror_url":null,"archived":false,"open_issues_count":166,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":76,"open_issues":166,"watchers":87,"default_branch":"version/1.12"}},"base":{"label":"Minecolonies:version/1.12","ref":"version/1.12","sha":"c0f3c0eee81d4424ee808aed5d23dee8e7ba8eaa","user":{"login":"Minecolonies","id":5167336,"avatar_url":"https://avatars3.githubusercontent.com/u/5167336?v=4","gravatar_id":"","url":"https://api.github.com/users/Minecolonies","html_url":"https://github.com/Minecolonies","followers_url":"https://api.github.com/users/Minecolonies/followers","following_url":"https://api.github.com/users/Minecolonies/following{/other_user}","gists_url":"https://api.github.com/users/Minecolonies/gists{/gist_id}","starred_url":"https://api.github.com/users/Minecolonies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Minecolonies/subscriptions","organizations_url":"https://api.github.com/users/Minecolonies/orgs","repos_url":"https://api.github.com/users/Minecolonies/repos","events_url":"https://api.github.com/users/Minecolonies/events{/privacy}","received_events_url":"https://api.github.com/users/Minecolonies/received_events","type":"Organization","site_admin":false},"repo":{"id":65616760,"name":"minecolonies","full_name":"Minecolonies/minecolonies","owner":{"login":"Minecolonies","id":5167336,"avatar_url":"https://avatars3.githubusercontent.com/u/5167336?v=4","gravatar_id":"","url":"https://api.github.com/users/Minecolonies","html_url":"https://github.com/Minecolonies","followers_url":"https://api.github.com/users/Minecolonies/followers","following_url":"https://api.github.com/users/Minecolonies/following{/other_user}","gists_url":"https://api.github.com/users/Minecolonies/gists{/gist_id}","starred_url":"https://api.github.com/users/Minecolonies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Minecolonies/subscriptions","organizations_url":"https://api.github.com/users/Minecolonies/orgs","repos_url":"https://api.github.com/users/Minecolonies/repos","events_url":"https://api.github.com/users/Minecolonies/events{/privacy}","received_events_url":"https://api.github.com/users/Minecolonies/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Minecolonies/minecolonies","description":"Minecolonies minecraft mod","fork":false,"url":"https://api.github.com/repos/Minecolonies/minecolonies","forks_url":"https://api.github.com/repos/Minecolonies/minecolonies/forks","keys_url":"https://api.github.com/repos/Minecolonies/minecolonies/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Minecolonies/minecolonies/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Minecolonies/minecolonies/teams","hooks_url":"https://api.github.com/repos/Minecolonies/minecolonies/hooks","issue_events_url":"https://api.github.com/repos/Minecolonies/minecolonies/issues/events{/number}","events_url":"https://api.github.com/repos/Minecolonies/minecolonies/events","assignees_url":"https://api.github.com/repos/Minecolonies/minecolonies/assignees{/user}","branches_url":"https://api.github.com/repos/Minecolonies/minecolonies/branches{/branch}","tags_url":"https://api.github.com/repos/Minecolonies/minecolonies/tags","blobs_url":"https://api.github.com/repos/Minecolonies/minecolonies/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Minecolonies/minecolonies/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Minecolonies/minecolonies/git/refs{/sha}","trees_url":"https://api.github.com/repos/Minecolonies/minecolonies/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Minecolonies/minecolonies/statuses/{sha}","languages_url":"https://api.github.com/repos/Minecolonies/minecolonies/languages","stargazers_url":"https://api.github.com/repos/Minecolonies/minecolonies/stargazers","contributors_url":"https://api.github.com/repos/Minecolonies/minecolonies/contributors","subscribers_url":"https://api.github.com/repos/Minecolonies/minecolonies/subscribers","subscription_url":"https://api.github.com/repos/Minecolonies/minecolonies/subscription","commits_url":"https://api.github.com/repos/Minecolonies/minecolonies/commits{/sha}","git_commits_url":"https://api.github.com/repos/Minecolonies/minecolonies/git/commits{/sha}","comments_url":"https://api.github.com/repos/Minecolonies/minecolonies/comments{/number}","issue_comment_url":"https://api.github.com/repos/Minecolonies/minecolonies/issues/comments{/number}","contents_url":"https://api.github.com/repos/Minecolonies/minecolonies/contents/{+path}","compare_url":"https://api.github.com/repos/Minecolonies/minecolonies/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Minecolonies/minecolonies/merges","archive_url":"https://api.github.com/repos/Minecolonies/minecolonies/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Minecolonies/minecolonies/downloads","issues_url":"https://api.github.com/repos/Minecolonies/minecolonies/issues{/number}","pulls_url":"https://api.github.com/repos/Minecolonies/minecolonies/pulls{/number}","milestones_url":"https://api.github.com/repos/Minecolonies/minecolonies/milestones{/number}","notifications_url":"https://api.github.com/repos/Minecolonies/minecolonies/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Minecolonies/minecolonies/labels{/name}","releases_url":"https://api.github.com/repos/Minecolonies/minecolonies/releases{/id}","deployments_url":"https://api.github.com/repos/Minecolonies/minecolonies/deployments","created_at":"2016-08-13T12:45:38Z","updated_at":"2018-04-06T02:52:05Z","pushed_at":"2018-04-07T18:49:29Z","git_url":"git://github.com/Minecolonies/minecolonies.git","ssh_url":"[email protected]:Minecolonies/minecolonies.git","clone_url":"https://github.com/Minecolonies/minecolonies.git","svn_url":"https://github.com/Minecolonies/minecolonies","homepage":"http://minecolonies.com/","size":47670,"stargazers_count":87,"watchers_count":87,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":76,"mirror_url":null,"archived":false,"open_issues_count":166,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":76,"open_issues":166,"watchers":87,"default_branch":"version/1.12"}},"_links":{"self":{"href":"https://api.github.com/repos/Minecolonies/minecolonies/pulls/2363"},"html":{"href":"https://github.com/Minecolonies/minecolonies/pull/2363"},"issue":{"href":"https://api.github.com/repos/Minecolonies/minecolonies/issues/2363"},"comments":{"href":"https://api.github.com/repos/Minecolonies/minecolonies/issues/2363/comments"},"review_comments":{"href":"https://api.github.com/repos/Minecolonies/minecolonies/pulls/2363/comments"},"review_comment":{"href":"https://api.github.com/repos/Minecolonies/minecolonies/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Minecolonies/minecolonies/pulls/2363/commits"},"statuses":{"href":"https://api.github.com/repos/Minecolonies/minecolonies/statuses/4be75da5658970180d94cfd4bbf52481abee2032"}},"author_association":"CONTRIBUTOR"}} | {
"id": 65616760,
"name": "Minecolonies/minecolonies",
"url": "https://api.github.com/repos/Minecolonies/minecolonies"
} | {
"id": 30551110,
"login": "BuildTeamLinter",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/30551110?",
"url": "https://api.github.com/users/BuildTeamLinter"
} | {
"id": 5167336,
"login": "Minecolonies",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5167336?",
"url": "https://api.github.com/orgs/Minecolonies"
} | 2018-04-07T19:15:09 | 7495291367 | {"actor":{"display_login":"BuildTeamLinter"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/ebanx/doraemon/pulls/comments/167213901","pull_request_review_id":95402622,"id":167213901,"diff_hunk":"@@ -340,6 +340,9 @@ export default class Checkout {\n [choosePaymentMethod] (data) {\n const resolveMethod = (method, country) => {\n const elmMethods = {\n+ ar: {\n+ creditcard: 'credit-card-ar',","path":"woocommerce/lib/pages/checkout.js","position":21,"original_position":5,"commit_id":"bfcfde9586e15870c88ed1786d22e8186bc8b45c","original_commit_id":"bfcfde9586e15870c88ed1786d22e8186bc8b45c","user":{"login":"andercampanha","id":25743015,"avatar_url":"https://avatars2.githubusercontent.com/u/25743015?v=4","gravatar_id":"","url":"https://api.github.com/users/andercampanha","html_url":"https://github.com/andercampanha","followers_url":"https://api.github.com/users/andercampanha/followers","following_url":"https://api.github.com/users/andercampanha/following{/other_user}","gists_url":"https://api.github.com/users/andercampanha/gists{/gist_id}","starred_url":"https://api.github.com/users/andercampanha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andercampanha/subscriptions","organizations_url":"https://api.github.com/users/andercampanha/orgs","repos_url":"https://api.github.com/users/andercampanha/repos","events_url":"https://api.github.com/users/andercampanha/events{/privacy}","received_events_url":"https://api.github.com/users/andercampanha/received_events","type":"User","site_admin":false},"body":"I think it's the best way we have to reutilising defaults.js across all our projects and keep us from duplicating that file over and over again. It's very good. ","created_at":"2018-02-09T12:21:41Z","updated_at":"2018-02-09T12:21:41Z","html_url":"https://github.com/ebanx/doraemon/pull/6#discussion_r167213901","pull_request_url":"https://api.github.com/repos/ebanx/doraemon/pulls/6","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ebanx/doraemon/pulls/comments/167213901"},"html":{"href":"https://github.com/ebanx/doraemon/pull/6#discussion_r167213901"},"pull_request":{"href":"https://api.github.com/repos/ebanx/doraemon/pulls/6"}},"in_reply_to_id":167203992},"pull_request":{"url":"https://api.github.com/repos/ebanx/doraemon/pulls/6","id":168098130,"html_url":"https://github.com/ebanx/doraemon/pull/6","diff_url":"https://github.com/ebanx/doraemon/pull/6.diff","patch_url":"https://github.com/ebanx/doraemon/pull/6.patch","issue_url":"https://api.github.com/repos/ebanx/doraemon/issues/6","number":6,"state":"open","locked":false,"title":"Feature/argentina cc","user":{"login":"andercampanha","id":25743015,"avatar_url":"https://avatars2.githubusercontent.com/u/25743015?v=4","gravatar_id":"","url":"https://api.github.com/users/andercampanha","html_url":"https://github.com/andercampanha","followers_url":"https://api.github.com/users/andercampanha/followers","following_url":"https://api.github.com/users/andercampanha/following{/other_user}","gists_url":"https://api.github.com/users/andercampanha/gists{/gist_id}","starred_url":"https://api.github.com/users/andercampanha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andercampanha/subscriptions","organizations_url":"https://api.github.com/users/andercampanha/orgs","repos_url":"https://api.github.com/users/andercampanha/repos","events_url":"https://api.github.com/users/andercampanha/events{/privacy}","received_events_url":"https://api.github.com/users/andercampanha/received_events","type":"User","site_admin":false},"body":"ON HOLD, waiting for #3 and #5 to be merged","created_at":"2018-02-08T21:57:28Z","updated_at":"2018-02-09T12:21:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"52c0910ceab580e5673ed4e6c08ff1f690287dda","assignee":{"login":"andercampanha","id":25743015,"avatar_url":"https://avatars2.githubusercontent.com/u/25743015?v=4","gravatar_id":"","url":"https://api.github.com/users/andercampanha","html_url":"https://github.com/andercampanha","followers_url":"https://api.github.com/users/andercampanha/followers","following_url":"https://api.github.com/users/andercampanha/following{/other_user}","gists_url":"https://api.github.com/users/andercampanha/gists{/gist_id}","starred_url":"https://api.github.com/users/andercampanha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andercampanha/subscriptions","organizations_url":"https://api.github.com/users/andercampanha/orgs","repos_url":"https://api.github.com/users/andercampanha/repos","events_url":"https://api.github.com/users/andercampanha/events{/privacy}","received_events_url":"https://api.github.com/users/andercampanha/received_events","type":"User","site_admin":false},"assignees":[{"login":"andercampanha","id":25743015,"avatar_url":"https://avatars2.githubusercontent.com/u/25743015?v=4","gravatar_id":"","url":"https://api.github.com/users/andercampanha","html_url":"https://github.com/andercampanha","followers_url":"https://api.github.com/users/andercampanha/followers","following_url":"https://api.github.com/users/andercampanha/following{/other_user}","gists_url":"https://api.github.com/users/andercampanha/gists{/gist_id}","starred_url":"https://api.github.com/users/andercampanha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andercampanha/subscriptions","organizations_url":"https://api.github.com/users/andercampanha/orgs","repos_url":"https://api.github.com/users/andercampanha/repos","events_url":"https://api.github.com/users/andercampanha/events{/privacy}","received_events_url":"https://api.github.com/users/andercampanha/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/ebanx/doraemon/pulls/6/commits","review_comments_url":"https://api.github.com/repos/ebanx/doraemon/pulls/6/comments","review_comment_url":"https://api.github.com/repos/ebanx/doraemon/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ebanx/doraemon/issues/6/comments","statuses_url":"https://api.github.com/repos/ebanx/doraemon/statuses/bfcfde9586e15870c88ed1786d22e8186bc8b45c","head":{"label":"ebanx:feature/argentina-cc","ref":"feature/argentina-cc","sha":"bfcfde9586e15870c88ed1786d22e8186bc8b45c","user":{"login":"ebanx","id":5168667,"avatar_url":"https://avatars3.githubusercontent.com/u/5168667?v=4","gravatar_id":"","url":"https://api.github.com/users/ebanx","html_url":"https://github.com/ebanx","followers_url":"https://api.github.com/users/ebanx/followers","following_url":"https://api.github.com/users/ebanx/following{/other_user}","gists_url":"https://api.github.com/users/ebanx/gists{/gist_id}","starred_url":"https://api.github.com/users/ebanx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ebanx/subscriptions","organizations_url":"https://api.github.com/users/ebanx/orgs","repos_url":"https://api.github.com/users/ebanx/repos","events_url":"https://api.github.com/users/ebanx/events{/privacy}","received_events_url":"https://api.github.com/users/ebanx/received_events","type":"Organization","site_admin":false},"repo":{"id":120349787,"name":"doraemon","full_name":"ebanx/doraemon","owner":{"login":"ebanx","id":5168667,"avatar_url":"https://avatars3.githubusercontent.com/u/5168667?v=4","gravatar_id":"","url":"https://api.github.com/users/ebanx","html_url":"https://github.com/ebanx","followers_url":"https://api.github.com/users/ebanx/followers","following_url":"https://api.github.com/users/ebanx/following{/other_user}","gists_url":"https://api.github.com/users/ebanx/gists{/gist_id}","starred_url":"https://api.github.com/users/ebanx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ebanx/subscriptions","organizations_url":"https://api.github.com/users/ebanx/orgs","repos_url":"https://api.github.com/users/ebanx/repos","events_url":"https://api.github.com/users/ebanx/events{/privacy}","received_events_url":"https://api.github.com/users/ebanx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ebanx/doraemon","description":"Tests that run aginst diverses Journeys for EBANX Plugins","fork":false,"url":"https://api.github.com/repos/ebanx/doraemon","forks_url":"https://api.github.com/repos/ebanx/doraemon/forks","keys_url":"https://api.github.com/repos/ebanx/doraemon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ebanx/doraemon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ebanx/doraemon/teams","hooks_url":"https://api.github.com/repos/ebanx/doraemon/hooks","issue_events_url":"https://api.github.com/repos/ebanx/doraemon/issues/events{/number}","events_url":"https://api.github.com/repos/ebanx/doraemon/events","assignees_url":"https://api.github.com/repos/ebanx/doraemon/assignees{/user}","branches_url":"https://api.github.com/repos/ebanx/doraemon/branches{/branch}","tags_url":"https://api.github.com/repos/ebanx/doraemon/tags","blobs_url":"https://api.github.com/repos/ebanx/doraemon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ebanx/doraemon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ebanx/doraemon/git/refs{/sha}","trees_url":"https://api.github.com/repos/ebanx/doraemon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ebanx/doraemon/statuses/{sha}","languages_url":"https://api.github.com/repos/ebanx/doraemon/languages","stargazers_url":"https://api.github.com/repos/ebanx/doraemon/stargazers","contributors_url":"https://api.github.com/repos/ebanx/doraemon/contributors","subscribers_url":"https://api.github.com/repos/ebanx/doraemon/subscribers","subscription_url":"https://api.github.com/repos/ebanx/doraemon/subscription","commits_url":"https://api.github.com/repos/ebanx/doraemon/commits{/sha}","git_commits_url":"https://api.github.com/repos/ebanx/doraemon/git/commits{/sha}","comments_url":"https://api.github.com/repos/ebanx/doraemon/comments{/number}","issue_comment_url":"https://api.github.com/repos/ebanx/doraemon/issues/comments{/number}","contents_url":"https://api.github.com/repos/ebanx/doraemon/contents/{+path}","compare_url":"https://api.github.com/repos/ebanx/doraemon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ebanx/doraemon/merges","archive_url":"https://api.github.com/repos/ebanx/doraemon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ebanx/doraemon/downloads","issues_url":"https://api.github.com/repos/ebanx/doraemon/issues{/number}","pulls_url":"https://api.github.com/repos/ebanx/doraemon/pulls{/number}","milestones_url":"https://api.github.com/repos/ebanx/doraemon/milestones{/number}","notifications_url":"https://api.github.com/repos/ebanx/doraemon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ebanx/doraemon/labels{/name}","releases_url":"https://api.github.com/repos/ebanx/doraemon/releases{/id}","deployments_url":"https://api.github.com/repos/ebanx/doraemon/deployments","created_at":"2018-02-05T19:16:20Z","updated_at":"2018-02-08T00:24:29Z","pushed_at":"2018-02-09T12:13:37Z","git_url":"git://github.com/ebanx/doraemon.git","ssh_url":"[email protected]:ebanx/doraemon.git","clone_url":"https://github.com/ebanx/doraemon.git","svn_url":"https://github.com/ebanx/doraemon","homepage":"","size":107,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":3,"license":null,"forks":0,"open_issues":3,"watchers":2,"default_branch":"master"}},"base":{"label":"ebanx:master","ref":"master","sha":"e05948e9167668146d7eb01a8b91940b5b9f7c9b","user":{"login":"ebanx","id":5168667,"avatar_url":"https://avatars3.githubusercontent.com/u/5168667?v=4","gravatar_id":"","url":"https://api.github.com/users/ebanx","html_url":"https://github.com/ebanx","followers_url":"https://api.github.com/users/ebanx/followers","following_url":"https://api.github.com/users/ebanx/following{/other_user}","gists_url":"https://api.github.com/users/ebanx/gists{/gist_id}","starred_url":"https://api.github.com/users/ebanx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ebanx/subscriptions","organizations_url":"https://api.github.com/users/ebanx/orgs","repos_url":"https://api.github.com/users/ebanx/repos","events_url":"https://api.github.com/users/ebanx/events{/privacy}","received_events_url":"https://api.github.com/users/ebanx/received_events","type":"Organization","site_admin":false},"repo":{"id":120349787,"name":"doraemon","full_name":"ebanx/doraemon","owner":{"login":"ebanx","id":5168667,"avatar_url":"https://avatars3.githubusercontent.com/u/5168667?v=4","gravatar_id":"","url":"https://api.github.com/users/ebanx","html_url":"https://github.com/ebanx","followers_url":"https://api.github.com/users/ebanx/followers","following_url":"https://api.github.com/users/ebanx/following{/other_user}","gists_url":"https://api.github.com/users/ebanx/gists{/gist_id}","starred_url":"https://api.github.com/users/ebanx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ebanx/subscriptions","organizations_url":"https://api.github.com/users/ebanx/orgs","repos_url":"https://api.github.com/users/ebanx/repos","events_url":"https://api.github.com/users/ebanx/events{/privacy}","received_events_url":"https://api.github.com/users/ebanx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ebanx/doraemon","description":"Tests that run aginst diverses Journeys for EBANX Plugins","fork":false,"url":"https://api.github.com/repos/ebanx/doraemon","forks_url":"https://api.github.com/repos/ebanx/doraemon/forks","keys_url":"https://api.github.com/repos/ebanx/doraemon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ebanx/doraemon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ebanx/doraemon/teams","hooks_url":"https://api.github.com/repos/ebanx/doraemon/hooks","issue_events_url":"https://api.github.com/repos/ebanx/doraemon/issues/events{/number}","events_url":"https://api.github.com/repos/ebanx/doraemon/events","assignees_url":"https://api.github.com/repos/ebanx/doraemon/assignees{/user}","branches_url":"https://api.github.com/repos/ebanx/doraemon/branches{/branch}","tags_url":"https://api.github.com/repos/ebanx/doraemon/tags","blobs_url":"https://api.github.com/repos/ebanx/doraemon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ebanx/doraemon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ebanx/doraemon/git/refs{/sha}","trees_url":"https://api.github.com/repos/ebanx/doraemon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ebanx/doraemon/statuses/{sha}","languages_url":"https://api.github.com/repos/ebanx/doraemon/languages","stargazers_url":"https://api.github.com/repos/ebanx/doraemon/stargazers","contributors_url":"https://api.github.com/repos/ebanx/doraemon/contributors","subscribers_url":"https://api.github.com/repos/ebanx/doraemon/subscribers","subscription_url":"https://api.github.com/repos/ebanx/doraemon/subscription","commits_url":"https://api.github.com/repos/ebanx/doraemon/commits{/sha}","git_commits_url":"https://api.github.com/repos/ebanx/doraemon/git/commits{/sha}","comments_url":"https://api.github.com/repos/ebanx/doraemon/comments{/number}","issue_comment_url":"https://api.github.com/repos/ebanx/doraemon/issues/comments{/number}","contents_url":"https://api.github.com/repos/ebanx/doraemon/contents/{+path}","compare_url":"https://api.github.com/repos/ebanx/doraemon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ebanx/doraemon/merges","archive_url":"https://api.github.com/repos/ebanx/doraemon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ebanx/doraemon/downloads","issues_url":"https://api.github.com/repos/ebanx/doraemon/issues{/number}","pulls_url":"https://api.github.com/repos/ebanx/doraemon/pulls{/number}","milestones_url":"https://api.github.com/repos/ebanx/doraemon/milestones{/number}","notifications_url":"https://api.github.com/repos/ebanx/doraemon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ebanx/doraemon/labels{/name}","releases_url":"https://api.github.com/repos/ebanx/doraemon/releases{/id}","deployments_url":"https://api.github.com/repos/ebanx/doraemon/deployments","created_at":"2018-02-05T19:16:20Z","updated_at":"2018-02-08T00:24:29Z","pushed_at":"2018-02-09T12:13:37Z","git_url":"git://github.com/ebanx/doraemon.git","ssh_url":"[email protected]:ebanx/doraemon.git","clone_url":"https://github.com/ebanx/doraemon.git","svn_url":"https://github.com/ebanx/doraemon","homepage":"","size":107,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":3,"license":null,"forks":0,"open_issues":3,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ebanx/doraemon/pulls/6"},"html":{"href":"https://github.com/ebanx/doraemon/pull/6"},"issue":{"href":"https://api.github.com/repos/ebanx/doraemon/issues/6"},"comments":{"href":"https://api.github.com/repos/ebanx/doraemon/issues/6/comments"},"review_comments":{"href":"https://api.github.com/repos/ebanx/doraemon/pulls/6/comments"},"review_comment":{"href":"https://api.github.com/repos/ebanx/doraemon/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ebanx/doraemon/pulls/6/commits"},"statuses":{"href":"https://api.github.com/repos/ebanx/doraemon/statuses/bfcfde9586e15870c88ed1786d22e8186bc8b45c"}},"author_association":"CONTRIBUTOR"}} | {
"id": 120349787,
"name": "ebanx/doraemon",
"url": "https://api.github.com/repos/ebanx/doraemon"
} | {
"id": 25743015,
"login": "andercampanha",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/25743015?",
"url": "https://api.github.com/users/andercampanha"
} | {
"id": 5168667,
"login": "ebanx",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5168667?",
"url": "https://api.github.com/orgs/ebanx"
} | 2018-02-09T12:21:41 | 7222513468 | {"actor":{"display_login":"andercampanha"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/mailwatch/mailwatch-install-script/pulls/comments/202962087","pull_request_review_id":137755544,"id":202962087,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMjk2MjA4Nw==","diff_hunk":"@@ -0,0 +1,4 @@\n+#Default config provided by mailwatch-install-script\n+#Do NOT edit this file. It is auto generated.\n+#Instead create your own config that arranged after this file in alphabetical order.\n+Virus Scanners = clamav","path":"setup.scripts/mailscanner/00_mw-install-script.conf","position":4,"original_position":4,"commit_id":"8826b67c49c1b3632e59acb32378e7e238a830ed","original_commit_id":"5dff7e5bd8b495338f80b2eddaa8dbda870c13fc","user":{"login":"stefaweb","id":12907102,"node_id":"MDQ6VXNlcjEyOTA3MTAy","avatar_url":"https://avatars1.githubusercontent.com/u/12907102?v=4","gravatar_id":"","url":"https://api.github.com/users/stefaweb","html_url":"https://github.com/stefaweb","followers_url":"https://api.github.com/users/stefaweb/followers","following_url":"https://api.github.com/users/stefaweb/following{/other_user}","gists_url":"https://api.github.com/users/stefaweb/gists{/gist_id}","starred_url":"https://api.github.com/users/stefaweb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stefaweb/subscriptions","organizations_url":"https://api.github.com/users/stefaweb/orgs","repos_url":"https://api.github.com/users/stefaweb/repos","events_url":"https://api.github.com/users/stefaweb/events{/privacy}","received_events_url":"https://api.github.com/users/stefaweb/received_events","type":"User","site_admin":false},"body":"Was running during ms_lint.php\r\n\r\nwww-data 27735 26303 0 11:54 ? 00:00:00 sh -c sudo /usr/sbin/MailScanner --lint 2>&1\r\npostfix 27780 27737 0 11:54 ? 00:00:00 /bin/sh /usr/lib/MailScanner/wrapper/clamav-wrapper /usr -r --infected --stdout .\r\npostfix 27791 27780 99 11:54 ? 00:00:18 /usr/bin/clamscan --tempdir=/var/spool/MailScanner/incoming/clamav-tmp/tmp.y3FUMlcaE0 -r --infected --stdout .\r\n","created_at":"2018-07-17T09:55:49Z","updated_at":"2018-07-17T09:55:49Z","html_url":"https://github.com/mailwatch/mailwatch-install-script/pull/50#discussion_r202962087","pull_request_url":"https://api.github.com/repos/mailwatch/mailwatch-install-script/pulls/50","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/mailwatch/mailwatch-install-script/pulls/comments/202962087"},"html":{"href":"https://github.com/mailwatch/mailwatch-install-script/pull/50#discussion_r202962087"},"pull_request":{"href":"https://api.github.com/repos/mailwatch/mailwatch-install-script/pulls/50"}},"in_reply_to_id":202942109},"pull_request":{"url":"https://api.github.com/repos/mailwatch/mailwatch-install-script/pulls/50","id":201686581,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxNjg2NTgx","html_url":"https://github.com/mailwatch/mailwatch-install-script/pull/50","diff_url":"https://github.com/mailwatch/mailwatch-install-script/pull/50.diff","patch_url":"https://github.com/mailwatch/mailwatch-install-script/pull/50.patch","issue_url":"https://api.github.com/repos/mailwatch/mailwatch-install-script/issues/50","number":50,"state":"open","locked":false,"title":"Fixes + Features","user":{"login":"Skywalker-11","id":11180862,"node_id":"MDQ6VXNlcjExMTgwODYy","avatar_url":"https://avatars3.githubusercontent.com/u/11180862?v=4","gravatar_id":"","url":"https://api.github.com/users/Skywalker-11","html_url":"https://github.com/Skywalker-11","followers_url":"https://api.github.com/users/Skywalker-11/followers","following_url":"https://api.github.com/users/Skywalker-11/following{/other_user}","gists_url":"https://api.github.com/users/Skywalker-11/gists{/gist_id}","starred_url":"https://api.github.com/users/Skywalker-11/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Skywalker-11/subscriptions","organizations_url":"https://api.github.com/users/Skywalker-11/orgs","repos_url":"https://api.github.com/users/Skywalker-11/repos","events_url":"https://api.github.com/users/Skywalker-11/events{/privacy}","received_events_url":"https://api.github.com/users/Skywalker-11/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-07-16T16:09:17Z","updated_at":"2018-07-17T09:55:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"553939cd15befab945e16bd0966ccc9231d8b4dc","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mailwatch/mailwatch-install-script/pulls/50/commits","review_comments_url":"https://api.github.com/repos/mailwatch/mailwatch-install-script/pulls/50/comments","review_comment_url":"https://api.github.com/repos/mailwatch/mailwatch-install-script/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mailwatch/mailwatch-install-script/issues/50/comments","statuses_url":"https://api.github.com/repos/mailwatch/mailwatch-install-script/statuses/8826b67c49c1b3632e59acb32378e7e238a830ed","head":{"label":"mailwatch:morefixes","ref":"morefixes","sha":"8826b67c49c1b3632e59acb32378e7e238a830ed","user":{"login":"mailwatch","id":5224973,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyMjQ5NzM=","avatar_url":"https://avatars3.githubusercontent.com/u/5224973?v=4","gravatar_id":"","url":"https://api.github.com/users/mailwatch","html_url":"https://github.com/mailwatch","followers_url":"https://api.github.com/users/mailwatch/followers","following_url":"https://api.github.com/users/mailwatch/following{/other_user}","gists_url":"https://api.github.com/users/mailwatch/gists{/gist_id}","starred_url":"https://api.github.com/users/mailwatch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mailwatch/subscriptions","organizations_url":"https://api.github.com/users/mailwatch/orgs","repos_url":"https://api.github.com/users/mailwatch/repos","events_url":"https://api.github.com/users/mailwatch/events{/privacy}","received_events_url":"https://api.github.com/users/mailwatch/received_events","type":"Organization","site_admin":false},"repo":{"id":81860895,"node_id":"MDEwOlJlcG9zaXRvcnk4MTg2MDg5NQ==","name":"mailwatch-install-script","full_name":"mailwatch/mailwatch-install-script","owner":{"login":"mailwatch","id":5224973,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyMjQ5NzM=","avatar_url":"https://avatars3.githubusercontent.com/u/5224973?v=4","gravatar_id":"","url":"https://api.github.com/users/mailwatch","html_url":"https://github.com/mailwatch","followers_url":"https://api.github.com/users/mailwatch/followers","following_url":"https://api.github.com/users/mailwatch/following{/other_user}","gists_url":"https://api.github.com/users/mailwatch/gists{/gist_id}","starred_url":"https://api.github.com/users/mailwatch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mailwatch/subscriptions","organizations_url":"https://api.github.com/users/mailwatch/orgs","repos_url":"https://api.github.com/users/mailwatch/repos","events_url":"https://api.github.com/users/mailwatch/events{/privacy}","received_events_url":"https://api.github.com/users/mailwatch/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mailwatch/mailwatch-install-script","description":"Install script for automated MailWatch install","fork":false,"url":"https://api.github.com/repos/mailwatch/mailwatch-install-script","forks_url":"https://api.github.com/repos/mailwatch/mailwatch-install-script/forks","keys_url":"https://api.github.com/repos/mailwatch/mailwatch-install-script/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mailwatch/mailwatch-install-script/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mailwatch/mailwatch-install-script/teams","hooks_url":"https://api.github.com/repos/mailwatch/mailwatch-install-script/hooks","issue_events_url":"https://api.github.com/repos/mailwatch/mailwatch-install-script/issues/events{/number}","events_url":"https://api.github.com/repos/mailwatch/mailwatch-install-script/events","assignees_url":"https://api.github.com/repos/mailwatch/mailwatch-install-script/assignees{/user}","branches_url":"https://api.github.com/repos/mailwatch/mailwatch-install-script/branches{/branch}","tags_url":"https://api.github.com/repos/mailwatch/mailwatch-install-script/tags","blobs_url":"https://api.github.com/repos/mailwatch/mailwatch-install-script/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mailwatch/mailwatch-install-script/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mailwatch/mailwatch-install-script/git/refs{/sha}","trees_url":"https://api.github.com/repos/mailwatch/mailwatch-install-script/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mailwatch/mailwatch-install-script/statuses/{sha}","languages_url":"https://api.github.com/repos/mailwatch/mailwatch-install-script/languages","stargazers_url":"https://api.github.com/repos/mailwatch/mailwatch-install-script/stargazers","contributors_url":"https://api.github.com/repos/mailwatch/mailwatch-install-script/contributors","subscribers_url":"https://api.github.com/repos/mailwatch/mailwatch-install-script/subscribers","subscription_url":"https://api.github.com/repos/mailwatch/mailwatch-install-script/subscription","commits_url":"https://api.github.com/repos/mailwatch/mailwatch-install-script/commits{/sha}","git_commits_url":"https://api.github.com/repos/mailwatch/mailwatch-install-script/git/commits{/sha}","comments_url":"https://api.github.com/repos/mailwatch/mailwatch-install-script/comments{/number}","issue_comment_url":"https://api.github.com/repos/mailwatch/mailwatch-install-script/issues/comments{/number}","contents_url":"https://api.github.com/repos/mailwatch/mailwatch-install-script/contents/{+path}","compare_url":"https://api.github.com/repos/mailwatch/mailwatch-install-script/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mailwatch/mailwatch-install-script/merges","archive_url":"https://api.github.com/repos/mailwatch/mailwatch-install-script/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mailwatch/mailwatch-install-script/downloads","issues_url":"https://api.github.com/repos/mailwatch/mailwatch-install-script/issues{/number}","pulls_url":"https://api.github.com/repos/mailwatch/mailwatch-install-script/pulls{/number}","milestones_url":"https://api.github.com/repos/mailwatch/mailwatch-install-script/milestones{/number}","notifications_url":"https://api.github.com/repos/mailwatch/mailwatch-install-script/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mailwatch/mailwatch-install-script/labels{/name}","releases_url":"https://api.github.com/repos/mailwatch/mailwatch-install-script/releases{/id}","deployments_url":"https://api.github.com/repos/mailwatch/mailwatch-install-script/deployments","created_at":"2017-02-13T19:09:34Z","updated_at":"2018-07-15T11:40:24Z","pushed_at":"2018-07-17T08:59:17Z","git_url":"git://github.com/mailwatch/mailwatch-install-script.git","ssh_url":"[email protected]:mailwatch/mailwatch-install-script.git","clone_url":"https://github.com/mailwatch/mailwatch-install-script.git","svn_url":"https://github.com/mailwatch/mailwatch-install-script","homepage":null,"size":8115,"stargazers_count":2,"watchers_count":2,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":12,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":5,"open_issues":12,"watchers":2,"default_branch":"master"}},"base":{"label":"mailwatch:develop","ref":"develop","sha":"a417e989f5fadac80c1d4d2bab0dc323101e2531","user":{"login":"mailwatch","id":5224973,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyMjQ5NzM=","avatar_url":"https://avatars3.githubusercontent.com/u/5224973?v=4","gravatar_id":"","url":"https://api.github.com/users/mailwatch","html_url":"https://github.com/mailwatch","followers_url":"https://api.github.com/users/mailwatch/followers","following_url":"https://api.github.com/users/mailwatch/following{/other_user}","gists_url":"https://api.github.com/users/mailwatch/gists{/gist_id}","starred_url":"https://api.github.com/users/mailwatch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mailwatch/subscriptions","organizations_url":"https://api.github.com/users/mailwatch/orgs","repos_url":"https://api.github.com/users/mailwatch/repos","events_url":"https://api.github.com/users/mailwatch/events{/privacy}","received_events_url":"https://api.github.com/users/mailwatch/received_events","type":"Organization","site_admin":false},"repo":{"id":81860895,"node_id":"MDEwOlJlcG9zaXRvcnk4MTg2MDg5NQ==","name":"mailwatch-install-script","full_name":"mailwatch/mailwatch-install-script","owner":{"login":"mailwatch","id":5224973,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyMjQ5NzM=","avatar_url":"https://avatars3.githubusercontent.com/u/5224973?v=4","gravatar_id":"","url":"https://api.github.com/users/mailwatch","html_url":"https://github.com/mailwatch","followers_url":"https://api.github.com/users/mailwatch/followers","following_url":"https://api.github.com/users/mailwatch/following{/other_user}","gists_url":"https://api.github.com/users/mailwatch/gists{/gist_id}","starred_url":"https://api.github.com/users/mailwatch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mailwatch/subscriptions","organizations_url":"https://api.github.com/users/mailwatch/orgs","repos_url":"https://api.github.com/users/mailwatch/repos","events_url":"https://api.github.com/users/mailwatch/events{/privacy}","received_events_url":"https://api.github.com/users/mailwatch/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mailwatch/mailwatch-install-script","description":"Install script for automated MailWatch install","fork":false,"url":"https://api.github.com/repos/mailwatch/mailwatch-install-script","forks_url":"https://api.github.com/repos/mailwatch/mailwatch-install-script/forks","keys_url":"https://api.github.com/repos/mailwatch/mailwatch-install-script/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mailwatch/mailwatch-install-script/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mailwatch/mailwatch-install-script/teams","hooks_url":"https://api.github.com/repos/mailwatch/mailwatch-install-script/hooks","issue_events_url":"https://api.github.com/repos/mailwatch/mailwatch-install-script/issues/events{/number}","events_url":"https://api.github.com/repos/mailwatch/mailwatch-install-script/events","assignees_url":"https://api.github.com/repos/mailwatch/mailwatch-install-script/assignees{/user}","branches_url":"https://api.github.com/repos/mailwatch/mailwatch-install-script/branches{/branch}","tags_url":"https://api.github.com/repos/mailwatch/mailwatch-install-script/tags","blobs_url":"https://api.github.com/repos/mailwatch/mailwatch-install-script/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mailwatch/mailwatch-install-script/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mailwatch/mailwatch-install-script/git/refs{/sha}","trees_url":"https://api.github.com/repos/mailwatch/mailwatch-install-script/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mailwatch/mailwatch-install-script/statuses/{sha}","languages_url":"https://api.github.com/repos/mailwatch/mailwatch-install-script/languages","stargazers_url":"https://api.github.com/repos/mailwatch/mailwatch-install-script/stargazers","contributors_url":"https://api.github.com/repos/mailwatch/mailwatch-install-script/contributors","subscribers_url":"https://api.github.com/repos/mailwatch/mailwatch-install-script/subscribers","subscription_url":"https://api.github.com/repos/mailwatch/mailwatch-install-script/subscription","commits_url":"https://api.github.com/repos/mailwatch/mailwatch-install-script/commits{/sha}","git_commits_url":"https://api.github.com/repos/mailwatch/mailwatch-install-script/git/commits{/sha}","comments_url":"https://api.github.com/repos/mailwatch/mailwatch-install-script/comments{/number}","issue_comment_url":"https://api.github.com/repos/mailwatch/mailwatch-install-script/issues/comments{/number}","contents_url":"https://api.github.com/repos/mailwatch/mailwatch-install-script/contents/{+path}","compare_url":"https://api.github.com/repos/mailwatch/mailwatch-install-script/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mailwatch/mailwatch-install-script/merges","archive_url":"https://api.github.com/repos/mailwatch/mailwatch-install-script/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mailwatch/mailwatch-install-script/downloads","issues_url":"https://api.github.com/repos/mailwatch/mailwatch-install-script/issues{/number}","pulls_url":"https://api.github.com/repos/mailwatch/mailwatch-install-script/pulls{/number}","milestones_url":"https://api.github.com/repos/mailwatch/mailwatch-install-script/milestones{/number}","notifications_url":"https://api.github.com/repos/mailwatch/mailwatch-install-script/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mailwatch/mailwatch-install-script/labels{/name}","releases_url":"https://api.github.com/repos/mailwatch/mailwatch-install-script/releases{/id}","deployments_url":"https://api.github.com/repos/mailwatch/mailwatch-install-script/deployments","created_at":"2017-02-13T19:09:34Z","updated_at":"2018-07-15T11:40:24Z","pushed_at":"2018-07-17T08:59:17Z","git_url":"git://github.com/mailwatch/mailwatch-install-script.git","ssh_url":"[email protected]:mailwatch/mailwatch-install-script.git","clone_url":"https://github.com/mailwatch/mailwatch-install-script.git","svn_url":"https://github.com/mailwatch/mailwatch-install-script","homepage":null,"size":8115,"stargazers_count":2,"watchers_count":2,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":12,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":5,"open_issues":12,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mailwatch/mailwatch-install-script/pulls/50"},"html":{"href":"https://github.com/mailwatch/mailwatch-install-script/pull/50"},"issue":{"href":"https://api.github.com/repos/mailwatch/mailwatch-install-script/issues/50"},"comments":{"href":"https://api.github.com/repos/mailwatch/mailwatch-install-script/issues/50/comments"},"review_comments":{"href":"https://api.github.com/repos/mailwatch/mailwatch-install-script/pulls/50/comments"},"review_comment":{"href":"https://api.github.com/repos/mailwatch/mailwatch-install-script/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mailwatch/mailwatch-install-script/pulls/50/commits"},"statuses":{"href":"https://api.github.com/repos/mailwatch/mailwatch-install-script/statuses/8826b67c49c1b3632e59acb32378e7e238a830ed"}},"author_association":"MEMBER"}} | {
"id": 81860895,
"name": "mailwatch/mailwatch-install-script",
"url": "https://api.github.com/repos/mailwatch/mailwatch-install-script"
} | {
"id": 12907102,
"login": "stefaweb",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/12907102?",
"url": "https://api.github.com/users/stefaweb"
} | {
"id": 5224973,
"login": "mailwatch",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5224973?",
"url": "https://api.github.com/orgs/mailwatch"
} | 2018-07-17T09:55:49 | 7975626120 | {"actor":{"display_login":"stefaweb"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/invenia/XLSX.jl/pulls/comments/198624018","pull_request_review_id":132578379,"id":198624018,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5ODYyNDAxOA==","diff_hunk":"@@ -165,3 +165,181 @@ function writetable(filename::AbstractString; rewrite::Bool=false, kw...)\n writexlsx(filename, xf, rewrite=rewrite)\n nothing\n end\n+\n+\"\"\"\n+ emptyfile(sheetname::AbstractString=\"\")\n+\n+Returns an empty, writable `XLSXFile` with 1 worksheet.\n+\n+`sheetname` is the name of the worksheet, defaults to `Sheet1`.\n+\"\"\"\n+function emptyfile(sheetname::AbstractString=\"\")\n+ xf = open_default_template()\n+\n+ if sheetname != \"\"\n+ rename!(xf[1], sheetname)\n+ end\n+\n+ return xf\n+end\n+\n+function Base.open(f::Function, filename::AbstractString, sheetname::AbstractString=\"\")\n+ xf = open_default_template()\n+\n+ if sheetname != \"\"\n+ rename!(xf[1], sheetname)\n+ end\n+\n+ try\n+ f(xf)\n+ finally\n+ closefile(xf, filename)\n+ end\n+end\n+\n+\"\"\"\n+ writerow(xf::XLSXFile, data, row, start_column::String, sheet_num::Int=1)\n+\n+Write one row to `XLSXFile`.\n+\n+`data` is a vector.\n+`row` is the row index.\n+`start_column` is the `String` representation of the first column index to write.\n+`sheet_num` is the `Integer` representation of the target worksheet.\n+\n+Example:\n+\n+```julia\n+using XLSX\n+\n+data = 1, 2, 3]\n+xf = XLSX.emptyfile()\n+\n+XLSX.writerow(xf, data, 1, \"A\", 1)\n+```\n+\"\"\"\n+function writerow(xf::XLSXFile, data, row, start_column::String, sheet_num::Int=1)\n+ @assert sheetcount(xf) >= sheet_num \"Sheet number $sheet_num not found.\"\n+\n+ sheet = xf[sheet_num]\n+ anchor_cell = \"$start_column$row\"\n+\n+ writerow(sheet, data; anchor_cell=CellRef(anchor_cell))\n+end\n+\n+\"\"\"\n+ writerow(xf::XLSXFile, data, row, start_column::Int, sheet_num::Int=1)\n+\n+Write one row to `XLSXFile`.\n+\n+`data` is a vector.\n+`row` is the row index.\n+`start_column` is the `Integer` representation of the first column index to write.\n+`sheet_num` is the `Integer` representation of the target worksheet.\n+\n+Example:\n+\n+```julia\n+using XLSX\n+\n+data = [1, 2, 3]\n+xf = XLSX.emptyfile()\n+\n+XLSX.writerow(xf, data, 1, 1, 1)\n+```\n+\"\"\"\n+function writerow(xf::XLSXFile, data, row, start_column::Int, sheet_num::Int=1)\n+ writerow(xf, data, row, encode_column_number(start_column), sheet_num)\n+end\n+\n+\"\"\"\n+ writerow(xf::XLSXFile, data, row, start_column::String, sheetname::String)\n+\n+Write one row to `XLSXFile`.\n+\n+`data` is a vector.\n+`row` is the row index.\n+`start_column` is the `String` representation of the first column index to write.\n+`sheetname` is the name of the target worksheet.\n+\n+Example:\n+\n+```julia\n+using XLSX\n+\n+data = [1, 2, 3]\n+xf = XLSX.emptyfile(\"New Sheet\")\n+\n+XLSX.writerow(xf, data, 1, \"A\", \"New Sheet\")\n+```\n+\"\"\"\n+function writerow(xf::XLSXFile, data, row, start_column::String, sheetname::String)\n+ @assert hassheet(xf, sheetname) \"Sheet name \\\"$sheetname\\\" not found.\"\n+\n+ sheet = xf[sheetname]\n+ anchor_cell = \"$start_column$row\"\n+\n+ writerow(sheet, data; anchor_cell=CellRef(anchor_cell))\n+end\n+\n+\"\"\"\n+ writerow(xf::XLSXFile, data, row, start_column::Int, sheetname::String)\n+\n+Write one row to `XLSXFile`.\n+\n+`data` is a vector.\n+`row` is the row index.\n+`start_column` is the `Integer` representation of the first column index to write.\n+`sheetname` is the name of the target worksheet.\n+\n+Example:\n+\n+```julia\n+using XLSX\n+\n+data = [1, 2, 3]\n+xf = XLSX.emptyfile(\"New Sheet\")\n+\n+XLSX.writerow(xf, data, 1, 1, \"New Sheet\")\n+```\n+\"\"\"\n+function writerow(xf::XLSXFile, data, row, start_column::Int, sheetname::String,)\n+ writerow(xf, data, row, encode_column_number(start_column), sheetname)\n+end\n+\n+\"\"\"\n+ writerow(sheet::Worksheet, data; anchor_cell::CellRef=CellRef(\"A1\"))\n+\n+Write one row to `Worksheet`.\n+\n+`data` is a vector.\n+`anchor_cell` is the first cell of the row to write, defaults to \"A1\".\n+\n+Example:\n+\n+```julia\n+using XLSX\n+\n+data = [1, 2, 3]\n+xf = XLSX.emptyfile(\"New Sheet\")\n+sheet = xf[\"New Sheet\"]\n+\n+# write the second row starting at the second column\n+XLSX.writerow(sheet, data, anchor_cell=XLSX(CellRef(\"B2\")))\n+```\n+\"\"\"\n+function writerow(sheet::Worksheet, data; anchor_cell::CellRef=CellRef(\"A1\"))\n+ @assert is_writable(get_xlsxfile(sheet)) \"XLSXFile instance is not writable.\"\n+ writerow!(sheet, data; anchor_cell=CellRef(anchor_cell))\n+\n+end\n+\n+\"\"\"\n+ closefile(xf::XLSXFile, filepath::AbstractString; rewrite::Bool=false)\n+\n+Writes content and closes `XLSXFile`.\n+\"\"\"\n+function closefile(xf::XLSXFile, filepath::AbstractString; rewrite::Bool=false)\n+ writexlsx(filepath, xf, rewrite=rewrite)\n+ nothing\n+end","path":"src/helper.jl","position":230,"original_position":181,"commit_id":"c2c9fba4e05b0d1e446e5e1007d166fcee770d0a","original_commit_id":"5f2f7ba5d82883d04e7c6de784046015cbf2fda3","user":{"login":"omus","id":1675958,"node_id":"MDQ6VXNlcjE2NzU5NTg=","avatar_url":"https://avatars0.githubusercontent.com/u/1675958?v=4","gravatar_id":"","url":"https://api.github.com/users/omus","html_url":"https://github.com/omus","followers_url":"https://api.github.com/users/omus/followers","following_url":"https://api.github.com/users/omus/following{/other_user}","gists_url":"https://api.github.com/users/omus/gists{/gist_id}","starred_url":"https://api.github.com/users/omus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/omus/subscriptions","organizations_url":"https://api.github.com/users/omus/orgs","repos_url":"https://api.github.com/users/omus/repos","events_url":"https://api.github.com/users/omus/events{/privacy}","received_events_url":"https://api.github.com/users/omus/received_events","type":"User","site_admin":false},"body":"Should `writerow` and `closefile` be removed?","created_at":"2018-06-27T20:06:39Z","updated_at":"2018-06-27T20:06:46Z","html_url":"https://github.com/invenia/XLSX.jl/pull/1#discussion_r198624018","pull_request_url":"https://api.github.com/repos/invenia/XLSX.jl/pulls/1","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/invenia/XLSX.jl/pulls/comments/198624018"},"html":{"href":"https://github.com/invenia/XLSX.jl/pull/1#discussion_r198624018"},"pull_request":{"href":"https://api.github.com/repos/invenia/XLSX.jl/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/invenia/XLSX.jl/pulls/1","id":196792611,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk2NzkyNjEx","html_url":"https://github.com/invenia/XLSX.jl/pull/1","diff_url":"https://github.com/invenia/XLSX.jl/pull/1.diff","patch_url":"https://github.com/invenia/XLSX.jl/pull/1.patch","issue_url":"https://api.github.com/repos/invenia/XLSX.jl/issues/1","number":1,"state":"open","locked":false,"title":"Write one row at a time.","user":{"login":"kano31","id":12241921,"node_id":"MDQ6VXNlcjEyMjQxOTIx","avatar_url":"https://avatars1.githubusercontent.com/u/12241921?v=4","gravatar_id":"","url":"https://api.github.com/users/kano31","html_url":"https://github.com/kano31","followers_url":"https://api.github.com/users/kano31/followers","following_url":"https://api.github.com/users/kano31/following{/other_user}","gists_url":"https://api.github.com/users/kano31/gists{/gist_id}","starred_url":"https://api.github.com/users/kano31/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kano31/subscriptions","organizations_url":"https://api.github.com/users/kano31/orgs","repos_url":"https://api.github.com/users/kano31/repos","events_url":"https://api.github.com/users/kano31/events{/privacy}","received_events_url":"https://api.github.com/users/kano31/received_events","type":"User","site_admin":false},"body":"Functions to open empty file, write one row at a time, and close files.","created_at":"2018-06-22T16:57:12Z","updated_at":"2018-06-27T20:06:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9f873a850eb2d5f6dc7ff8cb20fc0a5ea70a7265","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/invenia/XLSX.jl/pulls/1/commits","review_comments_url":"https://api.github.com/repos/invenia/XLSX.jl/pulls/1/comments","review_comment_url":"https://api.github.com/repos/invenia/XLSX.jl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/invenia/XLSX.jl/issues/1/comments","statuses_url":"https://api.github.com/repos/invenia/XLSX.jl/statuses/c2c9fba4e05b0d1e446e5e1007d166fcee770d0a","head":{"label":"invenia:writerow","ref":"writerow","sha":"c2c9fba4e05b0d1e446e5e1007d166fcee770d0a","user":{"login":"invenia","id":5262440,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyNjI0NDA=","avatar_url":"https://avatars2.githubusercontent.com/u/5262440?v=4","gravatar_id":"","url":"https://api.github.com/users/invenia","html_url":"https://github.com/invenia","followers_url":"https://api.github.com/users/invenia/followers","following_url":"https://api.github.com/users/invenia/following{/other_user}","gists_url":"https://api.github.com/users/invenia/gists{/gist_id}","starred_url":"https://api.github.com/users/invenia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/invenia/subscriptions","organizations_url":"https://api.github.com/users/invenia/orgs","repos_url":"https://api.github.com/users/invenia/repos","events_url":"https://api.github.com/users/invenia/events{/privacy}","received_events_url":"https://api.github.com/users/invenia/received_events","type":"Organization","site_admin":false},"repo":{"id":137267620,"node_id":"MDEwOlJlcG9zaXRvcnkxMzcyNjc2MjA=","name":"XLSX.jl","full_name":"invenia/XLSX.jl","owner":{"login":"invenia","id":5262440,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyNjI0NDA=","avatar_url":"https://avatars2.githubusercontent.com/u/5262440?v=4","gravatar_id":"","url":"https://api.github.com/users/invenia","html_url":"https://github.com/invenia","followers_url":"https://api.github.com/users/invenia/followers","following_url":"https://api.github.com/users/invenia/following{/other_user}","gists_url":"https://api.github.com/users/invenia/gists{/gist_id}","starred_url":"https://api.github.com/users/invenia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/invenia/subscriptions","organizations_url":"https://api.github.com/users/invenia/orgs","repos_url":"https://api.github.com/users/invenia/repos","events_url":"https://api.github.com/users/invenia/events{/privacy}","received_events_url":"https://api.github.com/users/invenia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/invenia/XLSX.jl","description":"Excel file reader and writer coded in pure Julia.","fork":true,"url":"https://api.github.com/repos/invenia/XLSX.jl","forks_url":"https://api.github.com/repos/invenia/XLSX.jl/forks","keys_url":"https://api.github.com/repos/invenia/XLSX.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/invenia/XLSX.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/invenia/XLSX.jl/teams","hooks_url":"https://api.github.com/repos/invenia/XLSX.jl/hooks","issue_events_url":"https://api.github.com/repos/invenia/XLSX.jl/issues/events{/number}","events_url":"https://api.github.com/repos/invenia/XLSX.jl/events","assignees_url":"https://api.github.com/repos/invenia/XLSX.jl/assignees{/user}","branches_url":"https://api.github.com/repos/invenia/XLSX.jl/branches{/branch}","tags_url":"https://api.github.com/repos/invenia/XLSX.jl/tags","blobs_url":"https://api.github.com/repos/invenia/XLSX.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/invenia/XLSX.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/invenia/XLSX.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/invenia/XLSX.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/invenia/XLSX.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/invenia/XLSX.jl/languages","stargazers_url":"https://api.github.com/repos/invenia/XLSX.jl/stargazers","contributors_url":"https://api.github.com/repos/invenia/XLSX.jl/contributors","subscribers_url":"https://api.github.com/repos/invenia/XLSX.jl/subscribers","subscription_url":"https://api.github.com/repos/invenia/XLSX.jl/subscription","commits_url":"https://api.github.com/repos/invenia/XLSX.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/invenia/XLSX.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/invenia/XLSX.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/invenia/XLSX.jl/issues/comments{/number}","contents_url":"https://api.github.com/repos/invenia/XLSX.jl/contents/{+path}","compare_url":"https://api.github.com/repos/invenia/XLSX.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/invenia/XLSX.jl/merges","archive_url":"https://api.github.com/repos/invenia/XLSX.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/invenia/XLSX.jl/downloads","issues_url":"https://api.github.com/repos/invenia/XLSX.jl/issues{/number}","pulls_url":"https://api.github.com/repos/invenia/XLSX.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/invenia/XLSX.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/invenia/XLSX.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/invenia/XLSX.jl/labels{/name}","releases_url":"https://api.github.com/repos/invenia/XLSX.jl/releases{/id}","deployments_url":"https://api.github.com/repos/invenia/XLSX.jl/deployments","created_at":"2018-06-13T20:34:36Z","updated_at":"2018-06-13T20:34:38Z","pushed_at":"2018-06-27T19:42:39Z","git_url":"git://github.com/invenia/XLSX.jl.git","ssh_url":"[email protected]:invenia/XLSX.jl.git","clone_url":"https://github.com/invenia/XLSX.jl.git","svn_url":"https://github.com/invenia/XLSX.jl","homepage":"","size":410,"stargazers_count":0,"watchers_count":0,"language":"Julia","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"invenia:master","ref":"master","sha":"c17a376be6580720ca31a2ff3df739ed008fa912","user":{"login":"invenia","id":5262440,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyNjI0NDA=","avatar_url":"https://avatars2.githubusercontent.com/u/5262440?v=4","gravatar_id":"","url":"https://api.github.com/users/invenia","html_url":"https://github.com/invenia","followers_url":"https://api.github.com/users/invenia/followers","following_url":"https://api.github.com/users/invenia/following{/other_user}","gists_url":"https://api.github.com/users/invenia/gists{/gist_id}","starred_url":"https://api.github.com/users/invenia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/invenia/subscriptions","organizations_url":"https://api.github.com/users/invenia/orgs","repos_url":"https://api.github.com/users/invenia/repos","events_url":"https://api.github.com/users/invenia/events{/privacy}","received_events_url":"https://api.github.com/users/invenia/received_events","type":"Organization","site_admin":false},"repo":{"id":137267620,"node_id":"MDEwOlJlcG9zaXRvcnkxMzcyNjc2MjA=","name":"XLSX.jl","full_name":"invenia/XLSX.jl","owner":{"login":"invenia","id":5262440,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyNjI0NDA=","avatar_url":"https://avatars2.githubusercontent.com/u/5262440?v=4","gravatar_id":"","url":"https://api.github.com/users/invenia","html_url":"https://github.com/invenia","followers_url":"https://api.github.com/users/invenia/followers","following_url":"https://api.github.com/users/invenia/following{/other_user}","gists_url":"https://api.github.com/users/invenia/gists{/gist_id}","starred_url":"https://api.github.com/users/invenia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/invenia/subscriptions","organizations_url":"https://api.github.com/users/invenia/orgs","repos_url":"https://api.github.com/users/invenia/repos","events_url":"https://api.github.com/users/invenia/events{/privacy}","received_events_url":"https://api.github.com/users/invenia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/invenia/XLSX.jl","description":"Excel file reader and writer coded in pure Julia.","fork":true,"url":"https://api.github.com/repos/invenia/XLSX.jl","forks_url":"https://api.github.com/repos/invenia/XLSX.jl/forks","keys_url":"https://api.github.com/repos/invenia/XLSX.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/invenia/XLSX.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/invenia/XLSX.jl/teams","hooks_url":"https://api.github.com/repos/invenia/XLSX.jl/hooks","issue_events_url":"https://api.github.com/repos/invenia/XLSX.jl/issues/events{/number}","events_url":"https://api.github.com/repos/invenia/XLSX.jl/events","assignees_url":"https://api.github.com/repos/invenia/XLSX.jl/assignees{/user}","branches_url":"https://api.github.com/repos/invenia/XLSX.jl/branches{/branch}","tags_url":"https://api.github.com/repos/invenia/XLSX.jl/tags","blobs_url":"https://api.github.com/repos/invenia/XLSX.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/invenia/XLSX.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/invenia/XLSX.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/invenia/XLSX.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/invenia/XLSX.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/invenia/XLSX.jl/languages","stargazers_url":"https://api.github.com/repos/invenia/XLSX.jl/stargazers","contributors_url":"https://api.github.com/repos/invenia/XLSX.jl/contributors","subscribers_url":"https://api.github.com/repos/invenia/XLSX.jl/subscribers","subscription_url":"https://api.github.com/repos/invenia/XLSX.jl/subscription","commits_url":"https://api.github.com/repos/invenia/XLSX.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/invenia/XLSX.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/invenia/XLSX.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/invenia/XLSX.jl/issues/comments{/number}","contents_url":"https://api.github.com/repos/invenia/XLSX.jl/contents/{+path}","compare_url":"https://api.github.com/repos/invenia/XLSX.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/invenia/XLSX.jl/merges","archive_url":"https://api.github.com/repos/invenia/XLSX.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/invenia/XLSX.jl/downloads","issues_url":"https://api.github.com/repos/invenia/XLSX.jl/issues{/number}","pulls_url":"https://api.github.com/repos/invenia/XLSX.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/invenia/XLSX.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/invenia/XLSX.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/invenia/XLSX.jl/labels{/name}","releases_url":"https://api.github.com/repos/invenia/XLSX.jl/releases{/id}","deployments_url":"https://api.github.com/repos/invenia/XLSX.jl/deployments","created_at":"2018-06-13T20:34:36Z","updated_at":"2018-06-13T20:34:38Z","pushed_at":"2018-06-27T19:42:39Z","git_url":"git://github.com/invenia/XLSX.jl.git","ssh_url":"[email protected]:invenia/XLSX.jl.git","clone_url":"https://github.com/invenia/XLSX.jl.git","svn_url":"https://github.com/invenia/XLSX.jl","homepage":"","size":410,"stargazers_count":0,"watchers_count":0,"language":"Julia","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/invenia/XLSX.jl/pulls/1"},"html":{"href":"https://github.com/invenia/XLSX.jl/pull/1"},"issue":{"href":"https://api.github.com/repos/invenia/XLSX.jl/issues/1"},"comments":{"href":"https://api.github.com/repos/invenia/XLSX.jl/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/invenia/XLSX.jl/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/invenia/XLSX.jl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/invenia/XLSX.jl/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/invenia/XLSX.jl/statuses/c2c9fba4e05b0d1e446e5e1007d166fcee770d0a"}},"author_association":"COLLABORATOR"}} | {
"id": 137267620,
"name": "invenia/XLSX.jl",
"url": "https://api.github.com/repos/invenia/XLSX.jl"
} | {
"id": 1675958,
"login": "omus",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1675958?",
"url": "https://api.github.com/users/omus"
} | {
"id": 5262440,
"login": "invenia",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5262440?",
"url": "https://api.github.com/orgs/invenia"
} | 2018-06-27T20:06:39 | 7887899457 | {"actor":{"display_login":"omus"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/backdrop/backdrop/pulls/comments/178105945","pull_request_review_id":108110125,"id":178105945,"diff_hunk":"@@ -2446,7 +2446,9 @@ function theme_head_tag($variables) {\n $element = $variables['element'];\n $attributes = isset($element['#attributes']) ? backdrop_attributes($element['#attributes']) : '';\n if (!isset($element['#value'])) {\n- return '<' . $element['#tag'] . $attributes . \" />\\n\";\n+ if (isset($element['#tag'])) {","path":"core/includes/theme.inc","position":5,"original_position":5,"commit_id":"2b1e032774663e07e178fbbfd4ab1a190c9ce6f7","original_commit_id":"2b1e032774663e07e178fbbfd4ab1a190c9ce6f7","user":{"login":"laryn","id":871421,"avatar_url":"https://avatars0.githubusercontent.com/u/871421?v=4","gravatar_id":"","url":"https://api.github.com/users/laryn","html_url":"https://github.com/laryn","followers_url":"https://api.github.com/users/laryn/followers","following_url":"https://api.github.com/users/laryn/following{/other_user}","gists_url":"https://api.github.com/users/laryn/gists{/gist_id}","starred_url":"https://api.github.com/users/laryn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laryn/subscriptions","organizations_url":"https://api.github.com/users/laryn/orgs","repos_url":"https://api.github.com/users/laryn/repos","events_url":"https://api.github.com/users/laryn/events{/privacy}","received_events_url":"https://api.github.com/users/laryn/received_events","type":"User","site_admin":false},"body":"`!empty` sounds like a good idea then.","created_at":"2018-03-29T16:07:55Z","updated_at":"2018-03-29T16:07:55Z","html_url":"https://github.com/backdrop/backdrop/pull/2116#discussion_r178105945","pull_request_url":"https://api.github.com/repos/backdrop/backdrop/pulls/2116","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/backdrop/backdrop/pulls/comments/178105945"},"html":{"href":"https://github.com/backdrop/backdrop/pull/2116#discussion_r178105945"},"pull_request":{"href":"https://api.github.com/repos/backdrop/backdrop/pulls/2116"}},"in_reply_to_id":178103327},"pull_request":{"url":"https://api.github.com/repos/backdrop/backdrop/pulls/2116","id":178367711,"html_url":"https://github.com/backdrop/backdrop/pull/2116","diff_url":"https://github.com/backdrop/backdrop/pull/2116.diff","patch_url":"https://github.com/backdrop/backdrop/pull/2116.patch","issue_url":"https://api.github.com/repos/backdrop/backdrop/issues/2116","number":2116,"state":"open","locked":false,"title":"#3010: Empty elements being inserted in head","user":{"login":"laryn","id":871421,"avatar_url":"https://avatars0.githubusercontent.com/u/871421?v=4","gravatar_id":"","url":"https://api.github.com/users/laryn","html_url":"https://github.com/laryn","followers_url":"https://api.github.com/users/laryn/followers","following_url":"https://api.github.com/users/laryn/following{/other_user}","gists_url":"https://api.github.com/users/laryn/gists{/gist_id}","starred_url":"https://api.github.com/users/laryn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laryn/subscriptions","organizations_url":"https://api.github.com/users/laryn/orgs","repos_url":"https://api.github.com/users/laryn/repos","events_url":"https://api.github.com/users/laryn/events{/privacy}","received_events_url":"https://api.github.com/users/laryn/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-03-29T15:43:57Z","updated_at":"2018-03-29T16:07:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e1da96a328f55c7575727dd32d427c171254a6c9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/backdrop/backdrop/pulls/2116/commits","review_comments_url":"https://api.github.com/repos/backdrop/backdrop/pulls/2116/comments","review_comment_url":"https://api.github.com/repos/backdrop/backdrop/pulls/comments{/number}","comments_url":"https://api.github.com/repos/backdrop/backdrop/issues/2116/comments","statuses_url":"https://api.github.com/repos/backdrop/backdrop/statuses/2b1e032774663e07e178fbbfd4ab1a190c9ce6f7","head":{"label":"laryn:patch-1","ref":"patch-1","sha":"2b1e032774663e07e178fbbfd4ab1a190c9ce6f7","user":{"login":"laryn","id":871421,"avatar_url":"https://avatars0.githubusercontent.com/u/871421?v=4","gravatar_id":"","url":"https://api.github.com/users/laryn","html_url":"https://github.com/laryn","followers_url":"https://api.github.com/users/laryn/followers","following_url":"https://api.github.com/users/laryn/following{/other_user}","gists_url":"https://api.github.com/users/laryn/gists{/gist_id}","starred_url":"https://api.github.com/users/laryn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laryn/subscriptions","organizations_url":"https://api.github.com/users/laryn/orgs","repos_url":"https://api.github.com/users/laryn/repos","events_url":"https://api.github.com/users/laryn/events{/privacy}","received_events_url":"https://api.github.com/users/laryn/received_events","type":"User","site_admin":false},"repo":{"id":121543936,"name":"backdrop","full_name":"laryn/backdrop","owner":{"login":"laryn","id":871421,"avatar_url":"https://avatars0.githubusercontent.com/u/871421?v=4","gravatar_id":"","url":"https://api.github.com/users/laryn","html_url":"https://github.com/laryn","followers_url":"https://api.github.com/users/laryn/followers","following_url":"https://api.github.com/users/laryn/following{/other_user}","gists_url":"https://api.github.com/users/laryn/gists{/gist_id}","starred_url":"https://api.github.com/users/laryn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laryn/subscriptions","organizations_url":"https://api.github.com/users/laryn/orgs","repos_url":"https://api.github.com/users/laryn/repos","events_url":"https://api.github.com/users/laryn/events{/privacy}","received_events_url":"https://api.github.com/users/laryn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/laryn/backdrop","description":"Backdrop core code repository.","fork":true,"url":"https://api.github.com/repos/laryn/backdrop","forks_url":"https://api.github.com/repos/laryn/backdrop/forks","keys_url":"https://api.github.com/repos/laryn/backdrop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/laryn/backdrop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/laryn/backdrop/teams","hooks_url":"https://api.github.com/repos/laryn/backdrop/hooks","issue_events_url":"https://api.github.com/repos/laryn/backdrop/issues/events{/number}","events_url":"https://api.github.com/repos/laryn/backdrop/events","assignees_url":"https://api.github.com/repos/laryn/backdrop/assignees{/user}","branches_url":"https://api.github.com/repos/laryn/backdrop/branches{/branch}","tags_url":"https://api.github.com/repos/laryn/backdrop/tags","blobs_url":"https://api.github.com/repos/laryn/backdrop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/laryn/backdrop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/laryn/backdrop/git/refs{/sha}","trees_url":"https://api.github.com/repos/laryn/backdrop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/laryn/backdrop/statuses/{sha}","languages_url":"https://api.github.com/repos/laryn/backdrop/languages","stargazers_url":"https://api.github.com/repos/laryn/backdrop/stargazers","contributors_url":"https://api.github.com/repos/laryn/backdrop/contributors","subscribers_url":"https://api.github.com/repos/laryn/backdrop/subscribers","subscription_url":"https://api.github.com/repos/laryn/backdrop/subscription","commits_url":"https://api.github.com/repos/laryn/backdrop/commits{/sha}","git_commits_url":"https://api.github.com/repos/laryn/backdrop/git/commits{/sha}","comments_url":"https://api.github.com/repos/laryn/backdrop/comments{/number}","issue_comment_url":"https://api.github.com/repos/laryn/backdrop/issues/comments{/number}","contents_url":"https://api.github.com/repos/laryn/backdrop/contents/{+path}","compare_url":"https://api.github.com/repos/laryn/backdrop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/laryn/backdrop/merges","archive_url":"https://api.github.com/repos/laryn/backdrop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/laryn/backdrop/downloads","issues_url":"https://api.github.com/repos/laryn/backdrop/issues{/number}","pulls_url":"https://api.github.com/repos/laryn/backdrop/pulls{/number}","milestones_url":"https://api.github.com/repos/laryn/backdrop/milestones{/number}","notifications_url":"https://api.github.com/repos/laryn/backdrop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/laryn/backdrop/labels{/name}","releases_url":"https://api.github.com/repos/laryn/backdrop/releases{/id}","deployments_url":"https://api.github.com/repos/laryn/backdrop/deployments","created_at":"2018-02-14T18:09:57Z","updated_at":"2018-02-14T18:10:04Z","pushed_at":"2018-03-29T15:43:48Z","git_url":"git://github.com/laryn/backdrop.git","ssh_url":"[email protected]:laryn/backdrop.git","clone_url":"https://github.com/laryn/backdrop.git","svn_url":"https://github.com/laryn/backdrop","homepage":"https://backdropcms.org","size":56372,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"1.x"}},"base":{"label":"backdrop:1.x","ref":"1.x","sha":"3e9f57106ba307804a38f4dad79f0c2b3cb8c24d","user":{"login":"backdrop","id":5283039,"avatar_url":"https://avatars0.githubusercontent.com/u/5283039?v=4","gravatar_id":"","url":"https://api.github.com/users/backdrop","html_url":"https://github.com/backdrop","followers_url":"https://api.github.com/users/backdrop/followers","following_url":"https://api.github.com/users/backdrop/following{/other_user}","gists_url":"https://api.github.com/users/backdrop/gists{/gist_id}","starred_url":"https://api.github.com/users/backdrop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/backdrop/subscriptions","organizations_url":"https://api.github.com/users/backdrop/orgs","repos_url":"https://api.github.com/users/backdrop/repos","events_url":"https://api.github.com/users/backdrop/events{/privacy}","received_events_url":"https://api.github.com/users/backdrop/received_events","type":"Organization","site_admin":false},"repo":{"id":12285928,"name":"backdrop","full_name":"backdrop/backdrop","owner":{"login":"backdrop","id":5283039,"avatar_url":"https://avatars0.githubusercontent.com/u/5283039?v=4","gravatar_id":"","url":"https://api.github.com/users/backdrop","html_url":"https://github.com/backdrop","followers_url":"https://api.github.com/users/backdrop/followers","following_url":"https://api.github.com/users/backdrop/following{/other_user}","gists_url":"https://api.github.com/users/backdrop/gists{/gist_id}","starred_url":"https://api.github.com/users/backdrop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/backdrop/subscriptions","organizations_url":"https://api.github.com/users/backdrop/orgs","repos_url":"https://api.github.com/users/backdrop/repos","events_url":"https://api.github.com/users/backdrop/events{/privacy}","received_events_url":"https://api.github.com/users/backdrop/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/backdrop/backdrop","description":"Backdrop core code repository.","fork":false,"url":"https://api.github.com/repos/backdrop/backdrop","forks_url":"https://api.github.com/repos/backdrop/backdrop/forks","keys_url":"https://api.github.com/repos/backdrop/backdrop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/backdrop/backdrop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/backdrop/backdrop/teams","hooks_url":"https://api.github.com/repos/backdrop/backdrop/hooks","issue_events_url":"https://api.github.com/repos/backdrop/backdrop/issues/events{/number}","events_url":"https://api.github.com/repos/backdrop/backdrop/events","assignees_url":"https://api.github.com/repos/backdrop/backdrop/assignees{/user}","branches_url":"https://api.github.com/repos/backdrop/backdrop/branches{/branch}","tags_url":"https://api.github.com/repos/backdrop/backdrop/tags","blobs_url":"https://api.github.com/repos/backdrop/backdrop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/backdrop/backdrop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/backdrop/backdrop/git/refs{/sha}","trees_url":"https://api.github.com/repos/backdrop/backdrop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/backdrop/backdrop/statuses/{sha}","languages_url":"https://api.github.com/repos/backdrop/backdrop/languages","stargazers_url":"https://api.github.com/repos/backdrop/backdrop/stargazers","contributors_url":"https://api.github.com/repos/backdrop/backdrop/contributors","subscribers_url":"https://api.github.com/repos/backdrop/backdrop/subscribers","subscription_url":"https://api.github.com/repos/backdrop/backdrop/subscription","commits_url":"https://api.github.com/repos/backdrop/backdrop/commits{/sha}","git_commits_url":"https://api.github.com/repos/backdrop/backdrop/git/commits{/sha}","comments_url":"https://api.github.com/repos/backdrop/backdrop/comments{/number}","issue_comment_url":"https://api.github.com/repos/backdrop/backdrop/issues/comments{/number}","contents_url":"https://api.github.com/repos/backdrop/backdrop/contents/{+path}","compare_url":"https://api.github.com/repos/backdrop/backdrop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/backdrop/backdrop/merges","archive_url":"https://api.github.com/repos/backdrop/backdrop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/backdrop/backdrop/downloads","issues_url":"https://api.github.com/repos/backdrop/backdrop/issues{/number}","pulls_url":"https://api.github.com/repos/backdrop/backdrop/pulls{/number}","milestones_url":"https://api.github.com/repos/backdrop/backdrop/milestones{/number}","notifications_url":"https://api.github.com/repos/backdrop/backdrop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/backdrop/backdrop/labels{/name}","releases_url":"https://api.github.com/repos/backdrop/backdrop/releases{/id}","deployments_url":"https://api.github.com/repos/backdrop/backdrop/deployments","created_at":"2013-08-22T01:50:58Z","updated_at":"2018-03-29T09:41:45Z","pushed_at":"2018-03-29T15:43:58Z","git_url":"git://github.com/backdrop/backdrop.git","ssh_url":"[email protected]:backdrop/backdrop.git","clone_url":"https://github.com/backdrop/backdrop.git","svn_url":"https://github.com/backdrop/backdrop","homepage":"https://backdropcms.org","size":56501,"stargazers_count":644,"watchers_count":644,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":226,"mirror_url":null,"archived":false,"open_issues_count":202,"license":null,"forks":226,"open_issues":202,"watchers":644,"default_branch":"1.x"}},"_links":{"self":{"href":"https://api.github.com/repos/backdrop/backdrop/pulls/2116"},"html":{"href":"https://github.com/backdrop/backdrop/pull/2116"},"issue":{"href":"https://api.github.com/repos/backdrop/backdrop/issues/2116"},"comments":{"href":"https://api.github.com/repos/backdrop/backdrop/issues/2116/comments"},"review_comments":{"href":"https://api.github.com/repos/backdrop/backdrop/pulls/2116/comments"},"review_comment":{"href":"https://api.github.com/repos/backdrop/backdrop/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/backdrop/backdrop/pulls/2116/commits"},"statuses":{"href":"https://api.github.com/repos/backdrop/backdrop/statuses/2b1e032774663e07e178fbbfd4ab1a190c9ce6f7"}},"author_association":"CONTRIBUTOR"}} | {
"id": 12285928,
"name": "backdrop/backdrop",
"url": "https://api.github.com/repos/backdrop/backdrop"
} | {
"id": 871421,
"login": "laryn",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/871421?",
"url": "https://api.github.com/users/laryn"
} | {
"id": 5283039,
"login": "backdrop",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5283039?",
"url": "https://api.github.com/orgs/backdrop"
} | 2018-03-29T16:07:55 | 7454832530 | {"actor":{"display_login":"laryn"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/ForwardFinancing/forwardfinancing.github.io/pulls/comments/224525642","pull_request_review_id":163910857,"id":224525642,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNDUyNTY0Mg==","diff_hunk":"@@ -0,0 +1,293 @@\n+---\n+layout: post\n+title: \"A macroscopic take on metaprogramming\"\n+date: 2018-10-05 17:00:00 +0100\n+categories: elixir ruby javascript\n+author: Natacha Segala\n+---\n+If you are as keen on DIY as I am and equally as helpless, the first time you're presented with some sort of power tool you may think 'This is scary, how could I possibly use this?'.\n+\n+In some respects, metaprogramming can feel just like this.\n+\n+A quick look at [wikipedia's definition](https://en.wikipedia.org/wiki/Metaprogramming){:target= \"_blank\"} gives us:\n+\"Metaprogramming is a programming technique in which computer programs have the ability to treat programs as their data.\"\n+\n+Another common definition is \"writing code that writes code\".\n+\n+One of the main unknowns when coding is user data.\n+Everyday code does not necessarily solve unique problems.\n+As developers, we use well defined conventions and set of functions we are familiar with to process this data and return whatever is defined in the product specifications.\n+\n+There should be room for abstraction and generalization and yet, the consensus is to try and avoid metaprogramming as much as possible.\n+\n+The prefix \"meta\" is self-referential which tends to indicate linguistically that metaprogramming encompasses all of programming including \"normal\" programming.\n+We could think of \"normal\" programming as our ability to solve unique problems.\n+All of the other kinds of general problems could – in theory – be handled by metaprogramming.\n+\n+Getting to know the reflective methods and tools every language we use offers is a way of refining one's craft.\n+It also offers a glimpse into and a better understanding of the internals of the language.\n+\n+## Ruby\n+\n+When working with Ruby, chances are you will come across the DRY (don't repeat yourself) paradigm.\n+\n+The idea of avoiding duplication seems like a sound one in a more general context too.\n+It will make any refactoring (or change) easier.\n+\n+Not a cure-all but definitely a tool to keep handy in one's dev belt.\n+\n+### Example\n+\n+We have a test suite responsible for checking the index page of our website includes the content we expect:\n+\n+```\n+class IndexTest < TestCase\n+ test_homepage_has_about_content do\n+ visit '/'\n+ assert page.has_content?(about)\n+ end\n+\n+ test_homepage_has_news_content do\n+ visit '/'\n+ assert page.has_content?(news)\n+ end\n+\n+ ...\n+end\n+```\n+\n+A quick online search or pairing could lead to reducing the code to:\n+\n+```\n+class IndexTest < TestCase\n+ HOMEPAGE_CONTENT = ['About', 'Meetups', 'Tweets', 'News'].freeze\n+\n+ HOMEPAGE_CONTENT.each do |content|\n+ define_method(\"test_homepage_has_#{content}_content\") do\n+ visit '/'\n+ assert page.has_content?(content)\n+ end\n+ end\n+end\n+```\n+\n+What does define_method do exactly and where does it come from?\n+\n+Running `IndexTest.methods` returns a lot of methods we have not defined ourselves.\n+This is where the concept of inheritance starts to be visible.\n+\n+This call returns a list which includes all the methods accessible in the object's ancestors.\n+\n+If we want to know how many ancestors the IndexTest class has, we can run:\n+```\n+IndexTest.ancestors\n+=> [IndexTest, Object, Kernel, BasicObject]\n+```\n+\n+If you check each ancestor individually, `define_method` or even `ancestors` are nowhere to be found.\n+\n+This is because inheritance is not limited to direct \"vertical\" precedence.\n+`BasicObject`, `Object`, and `IndexText` are all classes and they have Class as their class.\n+All of them are instances of Class. Class ancestors are:\n+\n+```\n+Class.ancestors\n+=> [Class, Module, Object, Kernel, BasicObject]\n+```\n+\n+Module is where `define_methods` and `ancestors` are defined.\n+Understanding inheritance in Ruby is key to using the language itself better.\n+\n+A lot of Ruby's so-called \"magic\" exists in fact due to metaprogramming.\n+\n+## Javascript\n+\n+es6 has introduced a new feature called Proxy – which lo and behold – is an application of the [proxy pattern](https://en.wikipedia.org/wiki/Proxy_pattern){:target= \"_blank\"}\n+\n+In short, it acts as an interface to either just forward to the original recipient or apply additional logic.\n+\n+### Example\n+\n+We're writing a library to use with our frontend applications.\n+It will offer functions to report a set of events to a couple of external apis.\n+These APIs are in turn responsible for dispatching these to our internal messaging systems.\n+\n+We have an object responsible for dispatching the event to the first external API.\n+\n+```\n+import externalApi from 'external-api';\n+let isInitialized;\n+\n+const FirstExternalApi = {\n+ _getDispatcher: () => {\n+ return (method, ...args) => {\n+ return externalApi.push([ method, ...args]);\n+};\n+},\n+\n+dispatch: function(event) {\n+ if (isInitialized) {\n+ const { dispatchMethodName } = event;\n+\n+ this[dispatchMethodName](event);\n+ }\n+},\n+\n+_dispatchEvent: function({ method, eventAttributes={ } }) {\n+ this._getDispatcher()(method, eventAttributes);\n+},\n+\n+_dispatchException: function({eventAttributes}) {\n+ this._dispatchEvent({ method: 'SHOUT', eventAttributes });\n+},\n+\n+[...]\n+}\n+```\n+\n+In a development or staging environment, we want to be able to view the output of _getDispatcher in real time.\n+We think it would avoid context switching and help speed up things a bit.\n+\n+We implement a mock object to output the event to the console.\n+We deep clone the FirstExternalApi object and set the '_getDispatcher' to output to the console.\n+\n+```\n+function clone() {\n+ // deep clone logic\n+}\n+\n+const FirstExternalApiMock = clone(FirstExternalApi);\n+\n+FirstExternalApiMock._getDispatcher = function() {\n+ return (method, ...args) => {\n+ const argsString = args.map(arg => {\n+ return JSON.stringify(arg, null, 4);\n+ }).join(', ');\n+\n+ console.log(`externalApi('${method}', ${argsString})`);\n+ };\n+};\n+```\n+\n+Based on the node environment, we have an object responsible for trickling our events down to:\n+- either the real FirstExternalApi object responsible for communicating with the external api","path":"_posts/2018-10-05-a-macroscopic-take-on-metaprogramming.md","position":173,"original_position":173,"commit_id":"906032a1c45b18352cf98067e2e35d12cbf4d7f6","original_commit_id":"906032a1c45b18352cf98067e2e35d12cbf4d7f6","user":{"login":"kelvinma","id":13605855,"node_id":"MDQ6VXNlcjEzNjA1ODU1","avatar_url":"https://avatars1.githubusercontent.com/u/13605855?v=4","gravatar_id":"","url":"https://api.github.com/users/kelvinma","html_url":"https://github.com/kelvinma","followers_url":"https://api.github.com/users/kelvinma/followers","following_url":"https://api.github.com/users/kelvinma/following{/other_user}","gists_url":"https://api.github.com/users/kelvinma/gists{/gist_id}","starred_url":"https://api.github.com/users/kelvinma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kelvinma/subscriptions","organizations_url":"https://api.github.com/users/kelvinma/orgs","repos_url":"https://api.github.com/users/kelvinma/repos","events_url":"https://api.github.com/users/kelvinma/events{/privacy}","received_events_url":"https://api.github.com/users/kelvinma/received_events","type":"User","site_admin":false},"body":"capitalize API","created_at":"2018-10-11T16:56:31Z","updated_at":"2018-10-11T16:58:31Z","html_url":"https://github.com/ForwardFinancing/forwardfinancing.github.io/pull/27#discussion_r224525642","pull_request_url":"https://api.github.com/repos/ForwardFinancing/forwardfinancing.github.io/pulls/27","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ForwardFinancing/forwardfinancing.github.io/pulls/comments/224525642"},"html":{"href":"https://github.com/ForwardFinancing/forwardfinancing.github.io/pull/27#discussion_r224525642"},"pull_request":{"href":"https://api.github.com/repos/ForwardFinancing/forwardfinancing.github.io/pulls/27"}}},"pull_request":{"url":"https://api.github.com/repos/ForwardFinancing/forwardfinancing.github.io/pulls/27","id":221511718,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIxNTExNzE4","html_url":"https://github.com/ForwardFinancing/forwardfinancing.github.io/pull/27","diff_url":"https://github.com/ForwardFinancing/forwardfinancing.github.io/pull/27.diff","patch_url":"https://github.com/ForwardFinancing/forwardfinancing.github.io/pull/27.patch","issue_url":"https://api.github.com/repos/ForwardFinancing/forwardfinancing.github.io/issues/27","number":27,"state":"open","locked":false,"title":"[TB-26]: Metaprogramming, generalise your code","user":{"login":"natseg","id":6449818,"node_id":"MDQ6VXNlcjY0NDk4MTg=","avatar_url":"https://avatars2.githubusercontent.com/u/6449818?v=4","gravatar_id":"","url":"https://api.github.com/users/natseg","html_url":"https://github.com/natseg","followers_url":"https://api.github.com/users/natseg/followers","following_url":"https://api.github.com/users/natseg/following{/other_user}","gists_url":"https://api.github.com/users/natseg/gists{/gist_id}","starred_url":"https://api.github.com/users/natseg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/natseg/subscriptions","organizations_url":"https://api.github.com/users/natseg/orgs","repos_url":"https://api.github.com/users/natseg/repos","events_url":"https://api.github.com/users/natseg/events{/privacy}","received_events_url":"https://api.github.com/users/natseg/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-10-09T16:49:12Z","updated_at":"2018-10-11T16:58:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0797e9f3b5ef4efcc493c23862657bd16d271d33","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ForwardFinancing/forwardfinancing.github.io/pulls/27/commits","review_comments_url":"https://api.github.com/repos/ForwardFinancing/forwardfinancing.github.io/pulls/27/comments","review_comment_url":"https://api.github.com/repos/ForwardFinancing/forwardfinancing.github.io/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ForwardFinancing/forwardfinancing.github.io/issues/27/comments","statuses_url":"https://api.github.com/repos/ForwardFinancing/forwardfinancing.github.io/statuses/906032a1c45b18352cf98067e2e35d12cbf4d7f6","head":{"label":"ForwardFinancing:ns-metaprogramming-generalisation","ref":"ns-metaprogramming-generalisation","sha":"906032a1c45b18352cf98067e2e35d12cbf4d7f6","user":{"login":"ForwardFinancing","id":5340010,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUzNDAwMTA=","avatar_url":"https://avatars3.githubusercontent.com/u/5340010?v=4","gravatar_id":"","url":"https://api.github.com/users/ForwardFinancing","html_url":"https://github.com/ForwardFinancing","followers_url":"https://api.github.com/users/ForwardFinancing/followers","following_url":"https://api.github.com/users/ForwardFinancing/following{/other_user}","gists_url":"https://api.github.com/users/ForwardFinancing/gists{/gist_id}","starred_url":"https://api.github.com/users/ForwardFinancing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ForwardFinancing/subscriptions","organizations_url":"https://api.github.com/users/ForwardFinancing/orgs","repos_url":"https://api.github.com/users/ForwardFinancing/repos","events_url":"https://api.github.com/users/ForwardFinancing/events{/privacy}","received_events_url":"https://api.github.com/users/ForwardFinancing/received_events","type":"Organization","site_admin":false},"repo":{"id":69690266,"node_id":"MDEwOlJlcG9zaXRvcnk2OTY5MDI2Ng==","name":"forwardfinancing.github.io","full_name":"ForwardFinancing/forwardfinancing.github.io","private":false,"owner":{"login":"ForwardFinancing","id":5340010,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUzNDAwMTA=","avatar_url":"https://avatars3.githubusercontent.com/u/5340010?v=4","gravatar_id":"","url":"https://api.github.com/users/ForwardFinancing","html_url":"https://github.com/ForwardFinancing","followers_url":"https://api.github.com/users/ForwardFinancing/followers","following_url":"https://api.github.com/users/ForwardFinancing/following{/other_user}","gists_url":"https://api.github.com/users/ForwardFinancing/gists{/gist_id}","starred_url":"https://api.github.com/users/ForwardFinancing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ForwardFinancing/subscriptions","organizations_url":"https://api.github.com/users/ForwardFinancing/orgs","repos_url":"https://api.github.com/users/ForwardFinancing/repos","events_url":"https://api.github.com/users/ForwardFinancing/events{/privacy}","received_events_url":"https://api.github.com/users/ForwardFinancing/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ForwardFinancing/forwardfinancing.github.io","description":null,"fork":false,"url":"https://api.github.com/repos/ForwardFinancing/forwardfinancing.github.io","forks_url":"https://api.github.com/repos/ForwardFinancing/forwardfinancing.github.io/forks","keys_url":"https://api.github.com/repos/ForwardFinancing/forwardfinancing.github.io/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ForwardFinancing/forwardfinancing.github.io/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ForwardFinancing/forwardfinancing.github.io/teams","hooks_url":"https://api.github.com/repos/ForwardFinancing/forwardfinancing.github.io/hooks","issue_events_url":"https://api.github.com/repos/ForwardFinancing/forwardfinancing.github.io/issues/events{/number}","events_url":"https://api.github.com/repos/ForwardFinancing/forwardfinancing.github.io/events","assignees_url":"https://api.github.com/repos/ForwardFinancing/forwardfinancing.github.io/assignees{/user}","branches_url":"https://api.github.com/repos/ForwardFinancing/forwardfinancing.github.io/branches{/branch}","tags_url":"https://api.github.com/repos/ForwardFinancing/forwardfinancing.github.io/tags","blobs_url":"https://api.github.com/repos/ForwardFinancing/forwardfinancing.github.io/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ForwardFinancing/forwardfinancing.github.io/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ForwardFinancing/forwardfinancing.github.io/git/refs{/sha}","trees_url":"https://api.github.com/repos/ForwardFinancing/forwardfinancing.github.io/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ForwardFinancing/forwardfinancing.github.io/statuses/{sha}","languages_url":"https://api.github.com/repos/ForwardFinancing/forwardfinancing.github.io/languages","stargazers_url":"https://api.github.com/repos/ForwardFinancing/forwardfinancing.github.io/stargazers","contributors_url":"https://api.github.com/repos/ForwardFinancing/forwardfinancing.github.io/contributors","subscribers_url":"https://api.github.com/repos/ForwardFinancing/forwardfinancing.github.io/subscribers","subscription_url":"https://api.github.com/repos/ForwardFinancing/forwardfinancing.github.io/subscription","commits_url":"https://api.github.com/repos/ForwardFinancing/forwardfinancing.github.io/commits{/sha}","git_commits_url":"https://api.github.com/repos/ForwardFinancing/forwardfinancing.github.io/git/commits{/sha}","comments_url":"https://api.github.com/repos/ForwardFinancing/forwardfinancing.github.io/comments{/number}","issue_comment_url":"https://api.github.com/repos/ForwardFinancing/forwardfinancing.github.io/issues/comments{/number}","contents_url":"https://api.github.com/repos/ForwardFinancing/forwardfinancing.github.io/contents/{+path}","compare_url":"https://api.github.com/repos/ForwardFinancing/forwardfinancing.github.io/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ForwardFinancing/forwardfinancing.github.io/merges","archive_url":"https://api.github.com/repos/ForwardFinancing/forwardfinancing.github.io/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ForwardFinancing/forwardfinancing.github.io/downloads","issues_url":"https://api.github.com/repos/ForwardFinancing/forwardfinancing.github.io/issues{/number}","pulls_url":"https://api.github.com/repos/ForwardFinancing/forwardfinancing.github.io/pulls{/number}","milestones_url":"https://api.github.com/repos/ForwardFinancing/forwardfinancing.github.io/milestones{/number}","notifications_url":"https://api.github.com/repos/ForwardFinancing/forwardfinancing.github.io/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ForwardFinancing/forwardfinancing.github.io/labels{/name}","releases_url":"https://api.github.com/repos/ForwardFinancing/forwardfinancing.github.io/releases{/id}","deployments_url":"https://api.github.com/repos/ForwardFinancing/forwardfinancing.github.io/deployments","created_at":"2016-09-30T18:11:02Z","updated_at":"2018-10-10T14:49:48Z","pushed_at":"2018-10-11T15:14:41Z","git_url":"git://github.com/ForwardFinancing/forwardfinancing.github.io.git","ssh_url":"[email protected]:ForwardFinancing/forwardfinancing.github.io.git","clone_url":"https://github.com/ForwardFinancing/forwardfinancing.github.io.git","svn_url":"https://github.com/ForwardFinancing/forwardfinancing.github.io","homepage":null,"size":873,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":2,"license":null,"forks":1,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"ForwardFinancing:master","ref":"master","sha":"ebf076429cc9a831e497a2df3d5ae44f3b29acd5","user":{"login":"ForwardFinancing","id":5340010,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUzNDAwMTA=","avatar_url":"https://avatars3.githubusercontent.com/u/5340010?v=4","gravatar_id":"","url":"https://api.github.com/users/ForwardFinancing","html_url":"https://github.com/ForwardFinancing","followers_url":"https://api.github.com/users/ForwardFinancing/followers","following_url":"https://api.github.com/users/ForwardFinancing/following{/other_user}","gists_url":"https://api.github.com/users/ForwardFinancing/gists{/gist_id}","starred_url":"https://api.github.com/users/ForwardFinancing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ForwardFinancing/subscriptions","organizations_url":"https://api.github.com/users/ForwardFinancing/orgs","repos_url":"https://api.github.com/users/ForwardFinancing/repos","events_url":"https://api.github.com/users/ForwardFinancing/events{/privacy}","received_events_url":"https://api.github.com/users/ForwardFinancing/received_events","type":"Organization","site_admin":false},"repo":{"id":69690266,"node_id":"MDEwOlJlcG9zaXRvcnk2OTY5MDI2Ng==","name":"forwardfinancing.github.io","full_name":"ForwardFinancing/forwardfinancing.github.io","private":false,"owner":{"login":"ForwardFinancing","id":5340010,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUzNDAwMTA=","avatar_url":"https://avatars3.githubusercontent.com/u/5340010?v=4","gravatar_id":"","url":"https://api.github.com/users/ForwardFinancing","html_url":"https://github.com/ForwardFinancing","followers_url":"https://api.github.com/users/ForwardFinancing/followers","following_url":"https://api.github.com/users/ForwardFinancing/following{/other_user}","gists_url":"https://api.github.com/users/ForwardFinancing/gists{/gist_id}","starred_url":"https://api.github.com/users/ForwardFinancing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ForwardFinancing/subscriptions","organizations_url":"https://api.github.com/users/ForwardFinancing/orgs","repos_url":"https://api.github.com/users/ForwardFinancing/repos","events_url":"https://api.github.com/users/ForwardFinancing/events{/privacy}","received_events_url":"https://api.github.com/users/ForwardFinancing/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ForwardFinancing/forwardfinancing.github.io","description":null,"fork":false,"url":"https://api.github.com/repos/ForwardFinancing/forwardfinancing.github.io","forks_url":"https://api.github.com/repos/ForwardFinancing/forwardfinancing.github.io/forks","keys_url":"https://api.github.com/repos/ForwardFinancing/forwardfinancing.github.io/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ForwardFinancing/forwardfinancing.github.io/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ForwardFinancing/forwardfinancing.github.io/teams","hooks_url":"https://api.github.com/repos/ForwardFinancing/forwardfinancing.github.io/hooks","issue_events_url":"https://api.github.com/repos/ForwardFinancing/forwardfinancing.github.io/issues/events{/number}","events_url":"https://api.github.com/repos/ForwardFinancing/forwardfinancing.github.io/events","assignees_url":"https://api.github.com/repos/ForwardFinancing/forwardfinancing.github.io/assignees{/user}","branches_url":"https://api.github.com/repos/ForwardFinancing/forwardfinancing.github.io/branches{/branch}","tags_url":"https://api.github.com/repos/ForwardFinancing/forwardfinancing.github.io/tags","blobs_url":"https://api.github.com/repos/ForwardFinancing/forwardfinancing.github.io/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ForwardFinancing/forwardfinancing.github.io/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ForwardFinancing/forwardfinancing.github.io/git/refs{/sha}","trees_url":"https://api.github.com/repos/ForwardFinancing/forwardfinancing.github.io/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ForwardFinancing/forwardfinancing.github.io/statuses/{sha}","languages_url":"https://api.github.com/repos/ForwardFinancing/forwardfinancing.github.io/languages","stargazers_url":"https://api.github.com/repos/ForwardFinancing/forwardfinancing.github.io/stargazers","contributors_url":"https://api.github.com/repos/ForwardFinancing/forwardfinancing.github.io/contributors","subscribers_url":"https://api.github.com/repos/ForwardFinancing/forwardfinancing.github.io/subscribers","subscription_url":"https://api.github.com/repos/ForwardFinancing/forwardfinancing.github.io/subscription","commits_url":"https://api.github.com/repos/ForwardFinancing/forwardfinancing.github.io/commits{/sha}","git_commits_url":"https://api.github.com/repos/ForwardFinancing/forwardfinancing.github.io/git/commits{/sha}","comments_url":"https://api.github.com/repos/ForwardFinancing/forwardfinancing.github.io/comments{/number}","issue_comment_url":"https://api.github.com/repos/ForwardFinancing/forwardfinancing.github.io/issues/comments{/number}","contents_url":"https://api.github.com/repos/ForwardFinancing/forwardfinancing.github.io/contents/{+path}","compare_url":"https://api.github.com/repos/ForwardFinancing/forwardfinancing.github.io/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ForwardFinancing/forwardfinancing.github.io/merges","archive_url":"https://api.github.com/repos/ForwardFinancing/forwardfinancing.github.io/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ForwardFinancing/forwardfinancing.github.io/downloads","issues_url":"https://api.github.com/repos/ForwardFinancing/forwardfinancing.github.io/issues{/number}","pulls_url":"https://api.github.com/repos/ForwardFinancing/forwardfinancing.github.io/pulls{/number}","milestones_url":"https://api.github.com/repos/ForwardFinancing/forwardfinancing.github.io/milestones{/number}","notifications_url":"https://api.github.com/repos/ForwardFinancing/forwardfinancing.github.io/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ForwardFinancing/forwardfinancing.github.io/labels{/name}","releases_url":"https://api.github.com/repos/ForwardFinancing/forwardfinancing.github.io/releases{/id}","deployments_url":"https://api.github.com/repos/ForwardFinancing/forwardfinancing.github.io/deployments","created_at":"2016-09-30T18:11:02Z","updated_at":"2018-10-10T14:49:48Z","pushed_at":"2018-10-11T15:14:41Z","git_url":"git://github.com/ForwardFinancing/forwardfinancing.github.io.git","ssh_url":"[email protected]:ForwardFinancing/forwardfinancing.github.io.git","clone_url":"https://github.com/ForwardFinancing/forwardfinancing.github.io.git","svn_url":"https://github.com/ForwardFinancing/forwardfinancing.github.io","homepage":null,"size":873,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":2,"license":null,"forks":1,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ForwardFinancing/forwardfinancing.github.io/pulls/27"},"html":{"href":"https://github.com/ForwardFinancing/forwardfinancing.github.io/pull/27"},"issue":{"href":"https://api.github.com/repos/ForwardFinancing/forwardfinancing.github.io/issues/27"},"comments":{"href":"https://api.github.com/repos/ForwardFinancing/forwardfinancing.github.io/issues/27/comments"},"review_comments":{"href":"https://api.github.com/repos/ForwardFinancing/forwardfinancing.github.io/pulls/27/comments"},"review_comment":{"href":"https://api.github.com/repos/ForwardFinancing/forwardfinancing.github.io/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ForwardFinancing/forwardfinancing.github.io/pulls/27/commits"},"statuses":{"href":"https://api.github.com/repos/ForwardFinancing/forwardfinancing.github.io/statuses/906032a1c45b18352cf98067e2e35d12cbf4d7f6"}},"author_association":"NONE"}} | {
"id": 69690266,
"name": "ForwardFinancing/forwardfinancing.github.io",
"url": "https://api.github.com/repos/ForwardFinancing/forwardfinancing.github.io"
} | {
"id": 13605855,
"login": "kelvinma",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/13605855?",
"url": "https://api.github.com/users/kelvinma"
} | {
"id": 5340010,
"login": "ForwardFinancing",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5340010?",
"url": "https://api.github.com/orgs/ForwardFinancing"
} | 2018-10-11T16:56:31 | 8406106061 | {"actor":{"display_login":"kelvinma"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/IgniteUI/igniteui-angular/pulls/comments/237786731","pull_request_review_id":180170507,"id":237786731,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNzc4NjczMQ==","diff_hunk":"@@ -0,0 +1,165 @@\n+import { Component, NgModule, EventEmitter, Output, Input, ViewChild, ElementRef, ContentChild } from '@angular/core';\n+import { IgxExpansionPanelModule } from '../expansion-panel/expansion-panel.module';\n+import { AnimationSettings } from '../expansion-panel/expansion-panel.component';\n+import { IgxExpansionPanelComponent } from '../expansion-panel';\n+import { IgxIconModule, IgxIconComponent } from '../icon/index';\n+import { IToggleView } from '../core/navigation';\n+import { IgxButtonModule } from '../directives/button/button.directive';\n+import { IgxRippleModule } from '../directives/ripple/ripple.directive';\n+import { IgxBannerActionsDirective } from './banner.directives';\n+import { CommonModule } from '@angular/common';\n+import { CancelableEventArgs } from '../core/utils';\n+\n+export interface BannerEventArgs {\n+ banner: IgxBannerComponent;\n+ event?: Event;\n+}\n+\n+export interface BannerCancelEventArgs extends BannerEventArgs, CancelableEventArgs {\n+}\n+@Component({\n+ selector: 'igx-banner',\n+ templateUrl: 'banner.component.html'\n+})\n+export class IgxBannerComponent implements IToggleView {","path":"projects/igniteui-angular/src/lib/banner/banner.component.ts","position":42,"original_position":24,"commit_id":"e614c93439d66c7c0a65ad77a8c88319972ee146","original_commit_id":"9024d6a6780b94eb49bab3117469b0fd75ccf2b2","user":{"login":"ViktorSlavov","id":24314672,"node_id":"MDQ6VXNlcjI0MzE0Njcy","avatar_url":"https://avatars1.githubusercontent.com/u/24314672?v=4","gravatar_id":"","url":"https://api.github.com/users/ViktorSlavov","html_url":"https://github.com/ViktorSlavov","followers_url":"https://api.github.com/users/ViktorSlavov/followers","following_url":"https://api.github.com/users/ViktorSlavov/following{/other_user}","gists_url":"https://api.github.com/users/ViktorSlavov/gists{/gist_id}","starred_url":"https://api.github.com/users/ViktorSlavov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ViktorSlavov/subscriptions","organizations_url":"https://api.github.com/users/ViktorSlavov/orgs","repos_url":"https://api.github.com/users/ViktorSlavov/repos","events_url":"https://api.github.com/users/ViktorSlavov/events{/privacy}","received_events_url":"https://api.github.com/users/ViktorSlavov/received_events","type":"User","site_admin":false},"body":"Thanks for pointing that out! I've added a top comment to the component. All of the public properties already had one (or were @hidden)","created_at":"2018-11-30T09:01:42Z","updated_at":"2018-11-30T09:01:43Z","html_url":"https://github.com/IgniteUI/igniteui-angular/pull/2978#discussion_r237786731","pull_request_url":"https://api.github.com/repos/IgniteUI/igniteui-angular/pulls/2978","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/IgniteUI/igniteui-angular/pulls/comments/237786731"},"html":{"href":"https://github.com/IgniteUI/igniteui-angular/pull/2978#discussion_r237786731"},"pull_request":{"href":"https://api.github.com/repos/IgniteUI/igniteui-angular/pulls/2978"}},"in_reply_to_id":237760167},"pull_request":{"url":"https://api.github.com/repos/IgniteUI/igniteui-angular/pulls/2978","id":229635613,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5NjM1NjEz","html_url":"https://github.com/IgniteUI/igniteui-angular/pull/2978","diff_url":"https://github.com/IgniteUI/igniteui-angular/pull/2978.diff","patch_url":"https://github.com/IgniteUI/igniteui-angular/pull/2978.patch","issue_url":"https://api.github.com/repos/IgniteUI/igniteui-angular/issues/2978","number":2978,"state":"open","locked":false,"title":"Banner component implementation, #2672","user":{"login":"wnvko","id":5990334,"node_id":"MDQ6VXNlcjU5OTAzMzQ=","avatar_url":"https://avatars3.githubusercontent.com/u/5990334?v=4","gravatar_id":"","url":"https://api.github.com/users/wnvko","html_url":"https://github.com/wnvko","followers_url":"https://api.github.com/users/wnvko/followers","following_url":"https://api.github.com/users/wnvko/following{/other_user}","gists_url":"https://api.github.com/users/wnvko/gists{/gist_id}","starred_url":"https://api.github.com/users/wnvko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wnvko/subscriptions","organizations_url":"https://api.github.com/users/wnvko/orgs","repos_url":"https://api.github.com/users/wnvko/repos","events_url":"https://api.github.com/users/wnvko/events{/privacy}","received_events_url":"https://api.github.com/users/wnvko/received_events","type":"User","site_admin":false},"body":"Closes #2672","created_at":"2018-11-09T09:34:56Z","updated_at":"2018-11-30T09:01:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cba7c7948644669dbaa79cc30821c404e82da1ce","assignee":{"login":"PlamenaMiteva","id":10612538,"node_id":"MDQ6VXNlcjEwNjEyNTM4","avatar_url":"https://avatars2.githubusercontent.com/u/10612538?v=4","gravatar_id":"","url":"https://api.github.com/users/PlamenaMiteva","html_url":"https://github.com/PlamenaMiteva","followers_url":"https://api.github.com/users/PlamenaMiteva/followers","following_url":"https://api.github.com/users/PlamenaMiteva/following{/other_user}","gists_url":"https://api.github.com/users/PlamenaMiteva/gists{/gist_id}","starred_url":"https://api.github.com/users/PlamenaMiteva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PlamenaMiteva/subscriptions","organizations_url":"https://api.github.com/users/PlamenaMiteva/orgs","repos_url":"https://api.github.com/users/PlamenaMiteva/repos","events_url":"https://api.github.com/users/PlamenaMiteva/events{/privacy}","received_events_url":"https://api.github.com/users/PlamenaMiteva/received_events","type":"User","site_admin":false},"assignees":[{"login":"PlamenaMiteva","id":10612538,"node_id":"MDQ6VXNlcjEwNjEyNTM4","avatar_url":"https://avatars2.githubusercontent.com/u/10612538?v=4","gravatar_id":"","url":"https://api.github.com/users/PlamenaMiteva","html_url":"https://github.com/PlamenaMiteva","followers_url":"https://api.github.com/users/PlamenaMiteva/followers","following_url":"https://api.github.com/users/PlamenaMiteva/following{/other_user}","gists_url":"https://api.github.com/users/PlamenaMiteva/gists{/gist_id}","starred_url":"https://api.github.com/users/PlamenaMiteva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PlamenaMiteva/subscriptions","organizations_url":"https://api.github.com/users/PlamenaMiteva/orgs","repos_url":"https://api.github.com/users/PlamenaMiteva/repos","events_url":"https://api.github.com/users/PlamenaMiteva/events{/privacy}","received_events_url":"https://api.github.com/users/PlamenaMiteva/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"bazal4o","id":4228115,"node_id":"MDQ6VXNlcjQyMjgxMTU=","avatar_url":"https://avatars2.githubusercontent.com/u/4228115?v=4","gravatar_id":"","url":"https://api.github.com/users/bazal4o","html_url":"https://github.com/bazal4o","followers_url":"https://api.github.com/users/bazal4o/followers","following_url":"https://api.github.com/users/bazal4o/following{/other_user}","gists_url":"https://api.github.com/users/bazal4o/gists{/gist_id}","starred_url":"https://api.github.com/users/bazal4o/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bazal4o/subscriptions","organizations_url":"https://api.github.com/users/bazal4o/orgs","repos_url":"https://api.github.com/users/bazal4o/repos","events_url":"https://api.github.com/users/bazal4o/events{/privacy}","received_events_url":"https://api.github.com/users/bazal4o/received_events","type":"User","site_admin":false},{"login":"desig9stein","id":21260963,"node_id":"MDQ6VXNlcjIxMjYwOTYz","avatar_url":"https://avatars2.githubusercontent.com/u/21260963?v=4","gravatar_id":"","url":"https://api.github.com/users/desig9stein","html_url":"https://github.com/desig9stein","followers_url":"https://api.github.com/users/desig9stein/followers","following_url":"https://api.github.com/users/desig9stein/following{/other_user}","gists_url":"https://api.github.com/users/desig9stein/gists{/gist_id}","starred_url":"https://api.github.com/users/desig9stein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/desig9stein/subscriptions","organizations_url":"https://api.github.com/users/desig9stein/orgs","repos_url":"https://api.github.com/users/desig9stein/repos","events_url":"https://api.github.com/users/desig9stein/events{/privacy}","received_events_url":"https://api.github.com/users/desig9stein/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1083107576,"node_id":"MDU6TGFiZWwxMDgzMTA3NTc2","url":"https://api.github.com/repos/IgniteUI/igniteui-angular/labels/squash-merge","name":"squash-merge","color":"f2911a","default":false},{"id":531440195,"node_id":"MDU6TGFiZWw1MzE0NDAxOTU=","url":"https://api.github.com/repos/IgniteUI/igniteui-angular/labels/status:%20verified","name":"status: verified","color":"0e8a16","default":false},{"id":1141709911,"node_id":"MDU6TGFiZWwxMTQxNzA5OTEx","url":"https://api.github.com/repos/IgniteUI/igniteui-angular/labels/version:%207.1.x","name":"version: 7.1.x","color":"ed8e74","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/IgniteUI/igniteui-angular/pulls/2978/commits","review_comments_url":"https://api.github.com/repos/IgniteUI/igniteui-angular/pulls/2978/comments","review_comment_url":"https://api.github.com/repos/IgniteUI/igniteui-angular/pulls/comments{/number}","comments_url":"https://api.github.com/repos/IgniteUI/igniteui-angular/issues/2978/comments","statuses_url":"https://api.github.com/repos/IgniteUI/igniteui-angular/statuses/e614c93439d66c7c0a65ad77a8c88319972ee146","head":{"label":"IgniteUI:mvenkov/banner-component-implementation","ref":"mvenkov/banner-component-implementation","sha":"e614c93439d66c7c0a65ad77a8c88319972ee146","user":{"login":"IgniteUI","id":5366066,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUzNjYwNjY=","avatar_url":"https://avatars2.githubusercontent.com/u/5366066?v=4","gravatar_id":"","url":"https://api.github.com/users/IgniteUI","html_url":"https://github.com/IgniteUI","followers_url":"https://api.github.com/users/IgniteUI/followers","following_url":"https://api.github.com/users/IgniteUI/following{/other_user}","gists_url":"https://api.github.com/users/IgniteUI/gists{/gist_id}","starred_url":"https://api.github.com/users/IgniteUI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IgniteUI/subscriptions","organizations_url":"https://api.github.com/users/IgniteUI/orgs","repos_url":"https://api.github.com/users/IgniteUI/repos","events_url":"https://api.github.com/users/IgniteUI/events{/privacy}","received_events_url":"https://api.github.com/users/IgniteUI/received_events","type":"Organization","site_admin":false},"repo":{"id":51516387,"node_id":"MDEwOlJlcG9zaXRvcnk1MTUxNjM4Nw==","name":"igniteui-angular","full_name":"IgniteUI/igniteui-angular","private":false,"owner":{"login":"IgniteUI","id":5366066,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUzNjYwNjY=","avatar_url":"https://avatars2.githubusercontent.com/u/5366066?v=4","gravatar_id":"","url":"https://api.github.com/users/IgniteUI","html_url":"https://github.com/IgniteUI","followers_url":"https://api.github.com/users/IgniteUI/followers","following_url":"https://api.github.com/users/IgniteUI/following{/other_user}","gists_url":"https://api.github.com/users/IgniteUI/gists{/gist_id}","starred_url":"https://api.github.com/users/IgniteUI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IgniteUI/subscriptions","organizations_url":"https://api.github.com/users/IgniteUI/orgs","repos_url":"https://api.github.com/users/IgniteUI/repos","events_url":"https://api.github.com/users/IgniteUI/events{/privacy}","received_events_url":"https://api.github.com/users/IgniteUI/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/IgniteUI/igniteui-angular","description":"Ignite UI for Angular is a dependency-free Angular toolkit for building modern web apps.","fork":false,"url":"https://api.github.com/repos/IgniteUI/igniteui-angular","forks_url":"https://api.github.com/repos/IgniteUI/igniteui-angular/forks","keys_url":"https://api.github.com/repos/IgniteUI/igniteui-angular/keys{/key_id}","collaborators_url":"https://api.github.com/repos/IgniteUI/igniteui-angular/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/IgniteUI/igniteui-angular/teams","hooks_url":"https://api.github.com/repos/IgniteUI/igniteui-angular/hooks","issue_events_url":"https://api.github.com/repos/IgniteUI/igniteui-angular/issues/events{/number}","events_url":"https://api.github.com/repos/IgniteUI/igniteui-angular/events","assignees_url":"https://api.github.com/repos/IgniteUI/igniteui-angular/assignees{/user}","branches_url":"https://api.github.com/repos/IgniteUI/igniteui-angular/branches{/branch}","tags_url":"https://api.github.com/repos/IgniteUI/igniteui-angular/tags","blobs_url":"https://api.github.com/repos/IgniteUI/igniteui-angular/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/IgniteUI/igniteui-angular/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/IgniteUI/igniteui-angular/git/refs{/sha}","trees_url":"https://api.github.com/repos/IgniteUI/igniteui-angular/git/trees{/sha}","statuses_url":"https://api.github.com/repos/IgniteUI/igniteui-angular/statuses/{sha}","languages_url":"https://api.github.com/repos/IgniteUI/igniteui-angular/languages","stargazers_url":"https://api.github.com/repos/IgniteUI/igniteui-angular/stargazers","contributors_url":"https://api.github.com/repos/IgniteUI/igniteui-angular/contributors","subscribers_url":"https://api.github.com/repos/IgniteUI/igniteui-angular/subscribers","subscription_url":"https://api.github.com/repos/IgniteUI/igniteui-angular/subscription","commits_url":"https://api.github.com/repos/IgniteUI/igniteui-angular/commits{/sha}","git_commits_url":"https://api.github.com/repos/IgniteUI/igniteui-angular/git/commits{/sha}","comments_url":"https://api.github.com/repos/IgniteUI/igniteui-angular/comments{/number}","issue_comment_url":"https://api.github.com/repos/IgniteUI/igniteui-angular/issues/comments{/number}","contents_url":"https://api.github.com/repos/IgniteUI/igniteui-angular/contents/{+path}","compare_url":"https://api.github.com/repos/IgniteUI/igniteui-angular/compare/{base}...{head}","merges_url":"https://api.github.com/repos/IgniteUI/igniteui-angular/merges","archive_url":"https://api.github.com/repos/IgniteUI/igniteui-angular/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/IgniteUI/igniteui-angular/downloads","issues_url":"https://api.github.com/repos/IgniteUI/igniteui-angular/issues{/number}","pulls_url":"https://api.github.com/repos/IgniteUI/igniteui-angular/pulls{/number}","milestones_url":"https://api.github.com/repos/IgniteUI/igniteui-angular/milestones{/number}","notifications_url":"https://api.github.com/repos/IgniteUI/igniteui-angular/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/IgniteUI/igniteui-angular/labels{/name}","releases_url":"https://api.github.com/repos/IgniteUI/igniteui-angular/releases{/id}","deployments_url":"https://api.github.com/repos/IgniteUI/igniteui-angular/deployments","created_at":"2016-02-11T13:28:16Z","updated_at":"2018-11-28T19:46:20Z","pushed_at":"2018-11-30T09:00:58Z","git_url":"git://github.com/IgniteUI/igniteui-angular.git","ssh_url":"[email protected]:IgniteUI/igniteui-angular.git","clone_url":"https://github.com/IgniteUI/igniteui-angular.git","svn_url":"https://github.com/IgniteUI/igniteui-angular","homepage":"https://www.infragistics.com/products/ignite-ui-angular","size":78064,"stargazers_count":237,"watchers_count":237,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":58,"mirror_url":null,"archived":false,"open_issues_count":160,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":58,"open_issues":160,"watchers":237,"default_branch":"master"}},"base":{"label":"IgniteUI:master","ref":"master","sha":"8ffd463579fd9f7f0a88f6bc8af0e7ac779f950c","user":{"login":"IgniteUI","id":5366066,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUzNjYwNjY=","avatar_url":"https://avatars2.githubusercontent.com/u/5366066?v=4","gravatar_id":"","url":"https://api.github.com/users/IgniteUI","html_url":"https://github.com/IgniteUI","followers_url":"https://api.github.com/users/IgniteUI/followers","following_url":"https://api.github.com/users/IgniteUI/following{/other_user}","gists_url":"https://api.github.com/users/IgniteUI/gists{/gist_id}","starred_url":"https://api.github.com/users/IgniteUI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IgniteUI/subscriptions","organizations_url":"https://api.github.com/users/IgniteUI/orgs","repos_url":"https://api.github.com/users/IgniteUI/repos","events_url":"https://api.github.com/users/IgniteUI/events{/privacy}","received_events_url":"https://api.github.com/users/IgniteUI/received_events","type":"Organization","site_admin":false},"repo":{"id":51516387,"node_id":"MDEwOlJlcG9zaXRvcnk1MTUxNjM4Nw==","name":"igniteui-angular","full_name":"IgniteUI/igniteui-angular","private":false,"owner":{"login":"IgniteUI","id":5366066,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUzNjYwNjY=","avatar_url":"https://avatars2.githubusercontent.com/u/5366066?v=4","gravatar_id":"","url":"https://api.github.com/users/IgniteUI","html_url":"https://github.com/IgniteUI","followers_url":"https://api.github.com/users/IgniteUI/followers","following_url":"https://api.github.com/users/IgniteUI/following{/other_user}","gists_url":"https://api.github.com/users/IgniteUI/gists{/gist_id}","starred_url":"https://api.github.com/users/IgniteUI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IgniteUI/subscriptions","organizations_url":"https://api.github.com/users/IgniteUI/orgs","repos_url":"https://api.github.com/users/IgniteUI/repos","events_url":"https://api.github.com/users/IgniteUI/events{/privacy}","received_events_url":"https://api.github.com/users/IgniteUI/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/IgniteUI/igniteui-angular","description":"Ignite UI for Angular is a dependency-free Angular toolkit for building modern web apps.","fork":false,"url":"https://api.github.com/repos/IgniteUI/igniteui-angular","forks_url":"https://api.github.com/repos/IgniteUI/igniteui-angular/forks","keys_url":"https://api.github.com/repos/IgniteUI/igniteui-angular/keys{/key_id}","collaborators_url":"https://api.github.com/repos/IgniteUI/igniteui-angular/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/IgniteUI/igniteui-angular/teams","hooks_url":"https://api.github.com/repos/IgniteUI/igniteui-angular/hooks","issue_events_url":"https://api.github.com/repos/IgniteUI/igniteui-angular/issues/events{/number}","events_url":"https://api.github.com/repos/IgniteUI/igniteui-angular/events","assignees_url":"https://api.github.com/repos/IgniteUI/igniteui-angular/assignees{/user}","branches_url":"https://api.github.com/repos/IgniteUI/igniteui-angular/branches{/branch}","tags_url":"https://api.github.com/repos/IgniteUI/igniteui-angular/tags","blobs_url":"https://api.github.com/repos/IgniteUI/igniteui-angular/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/IgniteUI/igniteui-angular/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/IgniteUI/igniteui-angular/git/refs{/sha}","trees_url":"https://api.github.com/repos/IgniteUI/igniteui-angular/git/trees{/sha}","statuses_url":"https://api.github.com/repos/IgniteUI/igniteui-angular/statuses/{sha}","languages_url":"https://api.github.com/repos/IgniteUI/igniteui-angular/languages","stargazers_url":"https://api.github.com/repos/IgniteUI/igniteui-angular/stargazers","contributors_url":"https://api.github.com/repos/IgniteUI/igniteui-angular/contributors","subscribers_url":"https://api.github.com/repos/IgniteUI/igniteui-angular/subscribers","subscription_url":"https://api.github.com/repos/IgniteUI/igniteui-angular/subscription","commits_url":"https://api.github.com/repos/IgniteUI/igniteui-angular/commits{/sha}","git_commits_url":"https://api.github.com/repos/IgniteUI/igniteui-angular/git/commits{/sha}","comments_url":"https://api.github.com/repos/IgniteUI/igniteui-angular/comments{/number}","issue_comment_url":"https://api.github.com/repos/IgniteUI/igniteui-angular/issues/comments{/number}","contents_url":"https://api.github.com/repos/IgniteUI/igniteui-angular/contents/{+path}","compare_url":"https://api.github.com/repos/IgniteUI/igniteui-angular/compare/{base}...{head}","merges_url":"https://api.github.com/repos/IgniteUI/igniteui-angular/merges","archive_url":"https://api.github.com/repos/IgniteUI/igniteui-angular/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/IgniteUI/igniteui-angular/downloads","issues_url":"https://api.github.com/repos/IgniteUI/igniteui-angular/issues{/number}","pulls_url":"https://api.github.com/repos/IgniteUI/igniteui-angular/pulls{/number}","milestones_url":"https://api.github.com/repos/IgniteUI/igniteui-angular/milestones{/number}","notifications_url":"https://api.github.com/repos/IgniteUI/igniteui-angular/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/IgniteUI/igniteui-angular/labels{/name}","releases_url":"https://api.github.com/repos/IgniteUI/igniteui-angular/releases{/id}","deployments_url":"https://api.github.com/repos/IgniteUI/igniteui-angular/deployments","created_at":"2016-02-11T13:28:16Z","updated_at":"2018-11-28T19:46:20Z","pushed_at":"2018-11-30T09:00:58Z","git_url":"git://github.com/IgniteUI/igniteui-angular.git","ssh_url":"[email protected]:IgniteUI/igniteui-angular.git","clone_url":"https://github.com/IgniteUI/igniteui-angular.git","svn_url":"https://github.com/IgniteUI/igniteui-angular","homepage":"https://www.infragistics.com/products/ignite-ui-angular","size":78064,"stargazers_count":237,"watchers_count":237,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":58,"mirror_url":null,"archived":false,"open_issues_count":160,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":58,"open_issues":160,"watchers":237,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/IgniteUI/igniteui-angular/pulls/2978"},"html":{"href":"https://github.com/IgniteUI/igniteui-angular/pull/2978"},"issue":{"href":"https://api.github.com/repos/IgniteUI/igniteui-angular/issues/2978"},"comments":{"href":"https://api.github.com/repos/IgniteUI/igniteui-angular/issues/2978/comments"},"review_comments":{"href":"https://api.github.com/repos/IgniteUI/igniteui-angular/pulls/2978/comments"},"review_comment":{"href":"https://api.github.com/repos/IgniteUI/igniteui-angular/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/IgniteUI/igniteui-angular/pulls/2978/commits"},"statuses":{"href":"https://api.github.com/repos/IgniteUI/igniteui-angular/statuses/e614c93439d66c7c0a65ad77a8c88319972ee146"}},"author_association":"CONTRIBUTOR"}} | {
"id": 51516387,
"name": "IgniteUI/igniteui-angular",
"url": "https://api.github.com/repos/IgniteUI/igniteui-angular"
} | {
"id": 24314672,
"login": "ViktorSlavov",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/24314672?",
"url": "https://api.github.com/users/ViktorSlavov"
} | {
"id": 5366066,
"login": "IgniteUI",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5366066?",
"url": "https://api.github.com/orgs/IgniteUI"
} | 2018-11-30T09:01:42 | 8674814850 | {"actor":{"display_login":"ViktorSlavov"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/keybase/client/pulls/comments/241057096","pull_request_review_id":184232554,"id":241057096,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MTA1NzA5Ng==","diff_hunk":"@@ -1115,15 +1115,19 @@ func IsAccountMobileOnly(ctx context.Context, g *libkb.GlobalContext, accountID\n \n // SetAccountMobileOnly will fetch the account bundle and flip the mobile-only switch,\n // then send the new account bundle revision to the server.\n-func SetAccountMobileOnly(ctx context.Context, g *libkb.GlobalContext, accountID stellar1.AccountID) error {\n+func SetAccountMobileOnly(ctx context.Context, g *libkb.GlobalContext, accountID stellar1.AccountID, enabled bool) error {\n \tbundle, version, _, err := FetchAccountBundle(ctx, g, accountID)\n \tif err != nil {\n \t\treturn err\n \t}\n \tif version == stellar1.BundleVersion_V1 {\n \t\treturn fmt.Errorf(\"mobile-only feature requires migration to v2 bundles\")\n \t}\n-\terr = acctbundle.MakeMobileOnly(bundle, accountID)\n+\tif enabled {\n+\t\terr = acctbundle.MakeMobileOnly(bundle, accountID)\n+\t} else {\n+\t\terr = acctbundle.MakeAllDevices(bundle, accountID)","path":"go/stellar/remote/remote.go","position":17,"original_position":17,"commit_id":"1a578ffc62f610bc363f653292a0ebfc27ccc7ef","original_commit_id":"4296ea1844506a591a40e766e60f58ddf56b2435","user":{"login":"patrickxb","id":2508,"node_id":"MDQ6VXNlcjI1MDg=","avatar_url":"https://avatars2.githubusercontent.com/u/2508?v=4","gravatar_id":"","url":"https://api.github.com/users/patrickxb","html_url":"https://github.com/patrickxb","followers_url":"https://api.github.com/users/patrickxb/followers","following_url":"https://api.github.com/users/patrickxb/following{/other_user}","gists_url":"https://api.github.com/users/patrickxb/gists{/gist_id}","starred_url":"https://api.github.com/users/patrickxb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patrickxb/subscriptions","organizations_url":"https://api.github.com/users/patrickxb/orgs","repos_url":"https://api.github.com/users/patrickxb/repos","events_url":"https://api.github.com/users/patrickxb/events{/privacy}","received_events_url":"https://api.github.com/users/patrickxb/received_events","type":"User","site_admin":false},"body":"So is this function changing? I'd prefer SetAccountMobileOnly does the MakeMobileOnly. And another function does MakeAllDevices instead of using a bool flag.","created_at":"2018-12-12T15:21:10Z","updated_at":"2018-12-12T15:21:10Z","html_url":"https://github.com/keybase/client/pull/15030#discussion_r241057096","pull_request_url":"https://api.github.com/repos/keybase/client/pulls/15030","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/keybase/client/pulls/comments/241057096"},"html":{"href":"https://github.com/keybase/client/pull/15030#discussion_r241057096"},"pull_request":{"href":"https://api.github.com/repos/keybase/client/pulls/15030"}},"in_reply_to_id":240763073},"pull_request":{"url":"https://api.github.com/repos/keybase/client/pulls/15030","id":237798254,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM3Nzk4MjU0","html_url":"https://github.com/keybase/client/pull/15030","diff_url":"https://github.com/keybase/client/pull/15030.diff","patch_url":"https://github.com/keybase/client/pull/15030.patch","issue_url":"https://api.github.com/repos/keybase/client/issues/15030","number":15030,"state":"open","locked":false,"title":"Mobile only checkbox in GUI","user":{"login":"zapu","id":451974,"node_id":"MDQ6VXNlcjQ1MTk3NA==","avatar_url":"https://avatars3.githubusercontent.com/u/451974?v=4","gravatar_id":"","url":"https://api.github.com/users/zapu","html_url":"https://github.com/zapu","followers_url":"https://api.github.com/users/zapu/followers","following_url":"https://api.github.com/users/zapu/following{/other_user}","gists_url":"https://api.github.com/users/zapu/gists{/gist_id}","starred_url":"https://api.github.com/users/zapu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zapu/subscriptions","organizations_url":"https://api.github.com/users/zapu/orgs","repos_url":"https://api.github.com/users/zapu/repos","events_url":"https://api.github.com/users/zapu/events{/privacy}","received_events_url":"https://api.github.com/users/zapu/received_events","type":"User","site_admin":false},"body":"Add a checkbox to enable/disable mobile only mode for an account.\r\n\r\n\r\n","created_at":"2018-12-11T19:23:04Z","updated_at":"2018-12-12T15:21:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"08e82866ee0e8bdaed98295951b9da3cfbb68ecc","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/keybase/client/pulls/15030/commits","review_comments_url":"https://api.github.com/repos/keybase/client/pulls/15030/comments","review_comment_url":"https://api.github.com/repos/keybase/client/pulls/comments{/number}","comments_url":"https://api.github.com/repos/keybase/client/issues/15030/comments","statuses_url":"https://api.github.com/repos/keybase/client/statuses/1a578ffc62f610bc363f653292a0ebfc27ccc7ef","head":{"label":"keybase:zapu/CORE-9619-mobile-only-gui","ref":"zapu/CORE-9619-mobile-only-gui","sha":"1a578ffc62f610bc363f653292a0ebfc27ccc7ef","user":{"login":"keybase","id":5400834,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0MDA4MzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/5400834?v=4","gravatar_id":"","url":"https://api.github.com/users/keybase","html_url":"https://github.com/keybase","followers_url":"https://api.github.com/users/keybase/followers","following_url":"https://api.github.com/users/keybase/following{/other_user}","gists_url":"https://api.github.com/users/keybase/gists{/gist_id}","starred_url":"https://api.github.com/users/keybase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keybase/subscriptions","organizations_url":"https://api.github.com/users/keybase/orgs","repos_url":"https://api.github.com/users/keybase/repos","events_url":"https://api.github.com/users/keybase/events{/privacy}","received_events_url":"https://api.github.com/users/keybase/received_events","type":"Organization","site_admin":false},"repo":{"id":29099181,"node_id":"MDEwOlJlcG9zaXRvcnkyOTA5OTE4MQ==","name":"client","full_name":"keybase/client","private":false,"owner":{"login":"keybase","id":5400834,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0MDA4MzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/5400834?v=4","gravatar_id":"","url":"https://api.github.com/users/keybase","html_url":"https://github.com/keybase","followers_url":"https://api.github.com/users/keybase/followers","following_url":"https://api.github.com/users/keybase/following{/other_user}","gists_url":"https://api.github.com/users/keybase/gists{/gist_id}","starred_url":"https://api.github.com/users/keybase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keybase/subscriptions","organizations_url":"https://api.github.com/users/keybase/orgs","repos_url":"https://api.github.com/users/keybase/repos","events_url":"https://api.github.com/users/keybase/events{/privacy}","received_events_url":"https://api.github.com/users/keybase/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/keybase/client","description":"Keybase Go Library, Client, Service, OS X, iOS, Android, Electron","fork":false,"url":"https://api.github.com/repos/keybase/client","forks_url":"https://api.github.com/repos/keybase/client/forks","keys_url":"https://api.github.com/repos/keybase/client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/keybase/client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/keybase/client/teams","hooks_url":"https://api.github.com/repos/keybase/client/hooks","issue_events_url":"https://api.github.com/repos/keybase/client/issues/events{/number}","events_url":"https://api.github.com/repos/keybase/client/events","assignees_url":"https://api.github.com/repos/keybase/client/assignees{/user}","branches_url":"https://api.github.com/repos/keybase/client/branches{/branch}","tags_url":"https://api.github.com/repos/keybase/client/tags","blobs_url":"https://api.github.com/repos/keybase/client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/keybase/client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/keybase/client/git/refs{/sha}","trees_url":"https://api.github.com/repos/keybase/client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/keybase/client/statuses/{sha}","languages_url":"https://api.github.com/repos/keybase/client/languages","stargazers_url":"https://api.github.com/repos/keybase/client/stargazers","contributors_url":"https://api.github.com/repos/keybase/client/contributors","subscribers_url":"https://api.github.com/repos/keybase/client/subscribers","subscription_url":"https://api.github.com/repos/keybase/client/subscription","commits_url":"https://api.github.com/repos/keybase/client/commits{/sha}","git_commits_url":"https://api.github.com/repos/keybase/client/git/commits{/sha}","comments_url":"https://api.github.com/repos/keybase/client/comments{/number}","issue_comment_url":"https://api.github.com/repos/keybase/client/issues/comments{/number}","contents_url":"https://api.github.com/repos/keybase/client/contents/{+path}","compare_url":"https://api.github.com/repos/keybase/client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/keybase/client/merges","archive_url":"https://api.github.com/repos/keybase/client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/keybase/client/downloads","issues_url":"https://api.github.com/repos/keybase/client/issues{/number}","pulls_url":"https://api.github.com/repos/keybase/client/pulls{/number}","milestones_url":"https://api.github.com/repos/keybase/client/milestones{/number}","notifications_url":"https://api.github.com/repos/keybase/client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/keybase/client/labels{/name}","releases_url":"https://api.github.com/repos/keybase/client/releases{/id}","deployments_url":"https://api.github.com/repos/keybase/client/deployments","created_at":"2015-01-11T17:17:12Z","updated_at":"2018-12-12T14:42:30Z","pushed_at":"2018-12-12T15:19:51Z","git_url":"git://github.com/keybase/client.git","ssh_url":"[email protected]:keybase/client.git","clone_url":"https://github.com/keybase/client.git","svn_url":"https://github.com/keybase/client","homepage":"","size":340475,"stargazers_count":4355,"watchers_count":4355,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":440,"mirror_url":null,"archived":false,"open_issues_count":2483,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":440,"open_issues":2483,"watchers":4355,"default_branch":"master"}},"base":{"label":"keybase:master","ref":"master","sha":"1475529542e01f2ac0354b413a6a65266502512e","user":{"login":"keybase","id":5400834,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0MDA4MzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/5400834?v=4","gravatar_id":"","url":"https://api.github.com/users/keybase","html_url":"https://github.com/keybase","followers_url":"https://api.github.com/users/keybase/followers","following_url":"https://api.github.com/users/keybase/following{/other_user}","gists_url":"https://api.github.com/users/keybase/gists{/gist_id}","starred_url":"https://api.github.com/users/keybase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keybase/subscriptions","organizations_url":"https://api.github.com/users/keybase/orgs","repos_url":"https://api.github.com/users/keybase/repos","events_url":"https://api.github.com/users/keybase/events{/privacy}","received_events_url":"https://api.github.com/users/keybase/received_events","type":"Organization","site_admin":false},"repo":{"id":29099181,"node_id":"MDEwOlJlcG9zaXRvcnkyOTA5OTE4MQ==","name":"client","full_name":"keybase/client","private":false,"owner":{"login":"keybase","id":5400834,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0MDA4MzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/5400834?v=4","gravatar_id":"","url":"https://api.github.com/users/keybase","html_url":"https://github.com/keybase","followers_url":"https://api.github.com/users/keybase/followers","following_url":"https://api.github.com/users/keybase/following{/other_user}","gists_url":"https://api.github.com/users/keybase/gists{/gist_id}","starred_url":"https://api.github.com/users/keybase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keybase/subscriptions","organizations_url":"https://api.github.com/users/keybase/orgs","repos_url":"https://api.github.com/users/keybase/repos","events_url":"https://api.github.com/users/keybase/events{/privacy}","received_events_url":"https://api.github.com/users/keybase/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/keybase/client","description":"Keybase Go Library, Client, Service, OS X, iOS, Android, Electron","fork":false,"url":"https://api.github.com/repos/keybase/client","forks_url":"https://api.github.com/repos/keybase/client/forks","keys_url":"https://api.github.com/repos/keybase/client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/keybase/client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/keybase/client/teams","hooks_url":"https://api.github.com/repos/keybase/client/hooks","issue_events_url":"https://api.github.com/repos/keybase/client/issues/events{/number}","events_url":"https://api.github.com/repos/keybase/client/events","assignees_url":"https://api.github.com/repos/keybase/client/assignees{/user}","branches_url":"https://api.github.com/repos/keybase/client/branches{/branch}","tags_url":"https://api.github.com/repos/keybase/client/tags","blobs_url":"https://api.github.com/repos/keybase/client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/keybase/client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/keybase/client/git/refs{/sha}","trees_url":"https://api.github.com/repos/keybase/client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/keybase/client/statuses/{sha}","languages_url":"https://api.github.com/repos/keybase/client/languages","stargazers_url":"https://api.github.com/repos/keybase/client/stargazers","contributors_url":"https://api.github.com/repos/keybase/client/contributors","subscribers_url":"https://api.github.com/repos/keybase/client/subscribers","subscription_url":"https://api.github.com/repos/keybase/client/subscription","commits_url":"https://api.github.com/repos/keybase/client/commits{/sha}","git_commits_url":"https://api.github.com/repos/keybase/client/git/commits{/sha}","comments_url":"https://api.github.com/repos/keybase/client/comments{/number}","issue_comment_url":"https://api.github.com/repos/keybase/client/issues/comments{/number}","contents_url":"https://api.github.com/repos/keybase/client/contents/{+path}","compare_url":"https://api.github.com/repos/keybase/client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/keybase/client/merges","archive_url":"https://api.github.com/repos/keybase/client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/keybase/client/downloads","issues_url":"https://api.github.com/repos/keybase/client/issues{/number}","pulls_url":"https://api.github.com/repos/keybase/client/pulls{/number}","milestones_url":"https://api.github.com/repos/keybase/client/milestones{/number}","notifications_url":"https://api.github.com/repos/keybase/client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/keybase/client/labels{/name}","releases_url":"https://api.github.com/repos/keybase/client/releases{/id}","deployments_url":"https://api.github.com/repos/keybase/client/deployments","created_at":"2015-01-11T17:17:12Z","updated_at":"2018-12-12T14:42:30Z","pushed_at":"2018-12-12T15:19:51Z","git_url":"git://github.com/keybase/client.git","ssh_url":"[email protected]:keybase/client.git","clone_url":"https://github.com/keybase/client.git","svn_url":"https://github.com/keybase/client","homepage":"","size":340475,"stargazers_count":4355,"watchers_count":4355,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":440,"mirror_url":null,"archived":false,"open_issues_count":2483,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":440,"open_issues":2483,"watchers":4355,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/keybase/client/pulls/15030"},"html":{"href":"https://github.com/keybase/client/pull/15030"},"issue":{"href":"https://api.github.com/repos/keybase/client/issues/15030"},"comments":{"href":"https://api.github.com/repos/keybase/client/issues/15030/comments"},"review_comments":{"href":"https://api.github.com/repos/keybase/client/pulls/15030/comments"},"review_comment":{"href":"https://api.github.com/repos/keybase/client/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/keybase/client/pulls/15030/commits"},"statuses":{"href":"https://api.github.com/repos/keybase/client/statuses/1a578ffc62f610bc363f653292a0ebfc27ccc7ef"}},"author_association":"CONTRIBUTOR"}} | {
"id": 29099181,
"name": "keybase/client",
"url": "https://api.github.com/repos/keybase/client"
} | {
"id": 2508,
"login": "patrickxb",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2508?",
"url": "https://api.github.com/users/patrickxb"
} | {
"id": 5400834,
"login": "keybase",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5400834?",
"url": "https://api.github.com/orgs/keybase"
} | 2018-12-12T15:21:10 | 8741966661 | {"actor":{"display_login":"patrickxb"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/pulls/comments/166982020","pull_request_review_id":95130287,"id":166982020,"diff_hunk":"@@ -19,24 +19,24 @@\n \t\t\t'unpinActionResult': 'L\\'épinglage du cours {course} a été annulé',\n \t\t\t'noCoursesMessage': 'Vous n’avez aucun cours à afficher. Si vous croyez qu’il s’agit d’une erreur, veuillez contacter votre administrateur.',\n \t\t\t'noPinnedCoursesWidgetMessage': 'Vous n\\'avez aucun cours épinglé. Afficher tous les cours pour parcourir tous les cours disponibles.',\n-\t\t\t'onlyPastCoursesMessage': 'Vous n\\'avez aucun cours épinglé. Afficher tous les cours pour parcourir votre cours antérieurs.',\n-\t\t\t'noPinnedCoursesMessage': 'Vous n\\'avez aucun cours épinglé. Épinglez votre cours préféré afin qu\\'il soit plus facile à retrouver.',\n+\t\t\t'onlyPastCoursesMessage': 'Vous n\\'avez aucun cours actuel ou futur. Afficher tous les cours pour parcourir votre cours antérieur.',","path":"lang/fr.html","position":6,"original_position":6,"commit_id":"f4dc72322579642fe134245528b6e01813b57b99","original_commit_id":"f4dc72322579642fe134245528b6e01813b57b99","user":{"login":"ryantmer","id":6231623,"avatar_url":"https://avatars3.githubusercontent.com/u/6231623?v=4","gravatar_id":"","url":"https://api.github.com/users/ryantmer","html_url":"https://github.com/ryantmer","followers_url":"https://api.github.com/users/ryantmer/followers","following_url":"https://api.github.com/users/ryantmer/following{/other_user}","gists_url":"https://api.github.com/users/ryantmer/gists{/gist_id}","starred_url":"https://api.github.com/users/ryantmer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryantmer/subscriptions","organizations_url":"https://api.github.com/users/ryantmer/orgs","repos_url":"https://api.github.com/users/ryantmer/repos","events_url":"https://api.github.com/users/ryantmer/events{/privacy}","received_events_url":"https://api.github.com/users/ryantmer/received_events","type":"User","site_admin":false},"body":"Yay, this was fixed :D","created_at":"2018-02-08T16:03:57Z","updated_at":"2018-02-08T16:03:57Z","html_url":"https://github.com/Brightspace/d2l-my-courses-ui/pull/501#discussion_r166982020","pull_request_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/pulls/501","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/pulls/comments/166982020"},"html":{"href":"https://github.com/Brightspace/d2l-my-courses-ui/pull/501#discussion_r166982020"},"pull_request":{"href":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/pulls/501"}}},"pull_request":{"url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/pulls/501","id":168012861,"html_url":"https://github.com/Brightspace/d2l-my-courses-ui/pull/501","diff_url":"https://github.com/Brightspace/d2l-my-courses-ui/pull/501.diff","patch_url":"https://github.com/Brightspace/d2l-my-courses-ui/pull/501.patch","issue_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/issues/501","number":501,"state":"open","locked":false,"title":"Updated lang terms for the new empty states when filtering by departm…","user":{"login":"trevorjonesd2l","id":8656538,"avatar_url":"https://avatars1.githubusercontent.com/u/8656538?v=4","gravatar_id":"","url":"https://api.github.com/users/trevorjonesd2l","html_url":"https://github.com/trevorjonesd2l","followers_url":"https://api.github.com/users/trevorjonesd2l/followers","following_url":"https://api.github.com/users/trevorjonesd2l/following{/other_user}","gists_url":"https://api.github.com/users/trevorjonesd2l/gists{/gist_id}","starred_url":"https://api.github.com/users/trevorjonesd2l/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trevorjonesd2l/subscriptions","organizations_url":"https://api.github.com/users/trevorjonesd2l/orgs","repos_url":"https://api.github.com/users/trevorjonesd2l/repos","events_url":"https://api.github.com/users/trevorjonesd2l/events{/privacy}","received_events_url":"https://api.github.com/users/trevorjonesd2l/received_events","type":"User","site_admin":false},"body":"…ent or semester","created_at":"2018-02-08T15:59:53Z","updated_at":"2018-02-08T16:03:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"43d7492f083c13e5a4836f9cd7bb94b854b29226","assignee":null,"assignees":[],"requested_reviewers":[{"login":"CodeBaboon","id":2243995,"avatar_url":"https://avatars3.githubusercontent.com/u/2243995?v=4","gravatar_id":"","url":"https://api.github.com/users/CodeBaboon","html_url":"https://github.com/CodeBaboon","followers_url":"https://api.github.com/users/CodeBaboon/followers","following_url":"https://api.github.com/users/CodeBaboon/following{/other_user}","gists_url":"https://api.github.com/users/CodeBaboon/gists{/gist_id}","starred_url":"https://api.github.com/users/CodeBaboon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CodeBaboon/subscriptions","organizations_url":"https://api.github.com/users/CodeBaboon/orgs","repos_url":"https://api.github.com/users/CodeBaboon/repos","events_url":"https://api.github.com/users/CodeBaboon/events{/privacy}","received_events_url":"https://api.github.com/users/CodeBaboon/received_events","type":"User","site_admin":false},{"login":"jstefaniuk-d2l","id":14077760,"avatar_url":"https://avatars2.githubusercontent.com/u/14077760?v=4","gravatar_id":"","url":"https://api.github.com/users/jstefaniuk-d2l","html_url":"https://github.com/jstefaniuk-d2l","followers_url":"https://api.github.com/users/jstefaniuk-d2l/followers","following_url":"https://api.github.com/users/jstefaniuk-d2l/following{/other_user}","gists_url":"https://api.github.com/users/jstefaniuk-d2l/gists{/gist_id}","starred_url":"https://api.github.com/users/jstefaniuk-d2l/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jstefaniuk-d2l/subscriptions","organizations_url":"https://api.github.com/users/jstefaniuk-d2l/orgs","repos_url":"https://api.github.com/users/jstefaniuk-d2l/repos","events_url":"https://api.github.com/users/jstefaniuk-d2l/events{/privacy}","received_events_url":"https://api.github.com/users/jstefaniuk-d2l/received_events","type":"User","site_admin":false},{"login":"apalaniuk","id":17710124,"avatar_url":"https://avatars1.githubusercontent.com/u/17710124?v=4","gravatar_id":"","url":"https://api.github.com/users/apalaniuk","html_url":"https://github.com/apalaniuk","followers_url":"https://api.github.com/users/apalaniuk/followers","following_url":"https://api.github.com/users/apalaniuk/following{/other_user}","gists_url":"https://api.github.com/users/apalaniuk/gists{/gist_id}","starred_url":"https://api.github.com/users/apalaniuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apalaniuk/subscriptions","organizations_url":"https://api.github.com/users/apalaniuk/orgs","repos_url":"https://api.github.com/users/apalaniuk/repos","events_url":"https://api.github.com/users/apalaniuk/events{/privacy}","received_events_url":"https://api.github.com/users/apalaniuk/received_events","type":"User","site_admin":false}],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/pulls/501/commits","review_comments_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/pulls/501/comments","review_comment_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/issues/501/comments","statuses_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/statuses/f4dc72322579642fe134245528b6e01813b57b99","head":{"label":"Brightspace:update_langterms_feb08_2018","ref":"update_langterms_feb08_2018","sha":"f4dc72322579642fe134245528b6e01813b57b99","user":{"login":"Brightspace","id":5429170,"avatar_url":"https://avatars2.githubusercontent.com/u/5429170?v=4","gravatar_id":"","url":"https://api.github.com/users/Brightspace","html_url":"https://github.com/Brightspace","followers_url":"https://api.github.com/users/Brightspace/followers","following_url":"https://api.github.com/users/Brightspace/following{/other_user}","gists_url":"https://api.github.com/users/Brightspace/gists{/gist_id}","starred_url":"https://api.github.com/users/Brightspace/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Brightspace/subscriptions","organizations_url":"https://api.github.com/users/Brightspace/orgs","repos_url":"https://api.github.com/users/Brightspace/repos","events_url":"https://api.github.com/users/Brightspace/events{/privacy}","received_events_url":"https://api.github.com/users/Brightspace/received_events","type":"Organization","site_admin":false},"repo":{"id":54492398,"name":"d2l-my-courses-ui","full_name":"Brightspace/d2l-my-courses-ui","owner":{"login":"Brightspace","id":5429170,"avatar_url":"https://avatars2.githubusercontent.com/u/5429170?v=4","gravatar_id":"","url":"https://api.github.com/users/Brightspace","html_url":"https://github.com/Brightspace","followers_url":"https://api.github.com/users/Brightspace/followers","following_url":"https://api.github.com/users/Brightspace/following{/other_user}","gists_url":"https://api.github.com/users/Brightspace/gists{/gist_id}","starred_url":"https://api.github.com/users/Brightspace/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Brightspace/subscriptions","organizations_url":"https://api.github.com/users/Brightspace/orgs","repos_url":"https://api.github.com/users/Brightspace/repos","events_url":"https://api.github.com/users/Brightspace/events{/privacy}","received_events_url":"https://api.github.com/users/Brightspace/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Brightspace/d2l-my-courses-ui","description":null,"fork":false,"url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui","forks_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/forks","keys_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/teams","hooks_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/hooks","issue_events_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/issues/events{/number}","events_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/events","assignees_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/assignees{/user}","branches_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/branches{/branch}","tags_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/tags","blobs_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/languages","stargazers_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/stargazers","contributors_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/contributors","subscribers_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/subscribers","subscription_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/subscription","commits_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/contents/{+path}","compare_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/merges","archive_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/downloads","issues_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/issues{/number}","pulls_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/labels{/name}","releases_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/releases{/id}","deployments_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/deployments","created_at":"2016-03-22T16:48:09Z","updated_at":"2018-02-01T19:53:45Z","pushed_at":"2018-02-08T15:59:53Z","git_url":"git://github.com/Brightspace/d2l-my-courses-ui.git","ssh_url":"[email protected]:Brightspace/d2l-my-courses-ui.git","clone_url":"https://github.com/Brightspace/d2l-my-courses-ui.git","svn_url":"https://github.com/Brightspace/d2l-my-courses-ui","homepage":null,"size":1876,"stargazers_count":2,"watchers_count":2,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":4,"open_issues":7,"watchers":2,"default_branch":"master"}},"base":{"label":"Brightspace:master","ref":"master","sha":"b9d768a79d2886ce43f71172be5834a759cd0304","user":{"login":"Brightspace","id":5429170,"avatar_url":"https://avatars2.githubusercontent.com/u/5429170?v=4","gravatar_id":"","url":"https://api.github.com/users/Brightspace","html_url":"https://github.com/Brightspace","followers_url":"https://api.github.com/users/Brightspace/followers","following_url":"https://api.github.com/users/Brightspace/following{/other_user}","gists_url":"https://api.github.com/users/Brightspace/gists{/gist_id}","starred_url":"https://api.github.com/users/Brightspace/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Brightspace/subscriptions","organizations_url":"https://api.github.com/users/Brightspace/orgs","repos_url":"https://api.github.com/users/Brightspace/repos","events_url":"https://api.github.com/users/Brightspace/events{/privacy}","received_events_url":"https://api.github.com/users/Brightspace/received_events","type":"Organization","site_admin":false},"repo":{"id":54492398,"name":"d2l-my-courses-ui","full_name":"Brightspace/d2l-my-courses-ui","owner":{"login":"Brightspace","id":5429170,"avatar_url":"https://avatars2.githubusercontent.com/u/5429170?v=4","gravatar_id":"","url":"https://api.github.com/users/Brightspace","html_url":"https://github.com/Brightspace","followers_url":"https://api.github.com/users/Brightspace/followers","following_url":"https://api.github.com/users/Brightspace/following{/other_user}","gists_url":"https://api.github.com/users/Brightspace/gists{/gist_id}","starred_url":"https://api.github.com/users/Brightspace/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Brightspace/subscriptions","organizations_url":"https://api.github.com/users/Brightspace/orgs","repos_url":"https://api.github.com/users/Brightspace/repos","events_url":"https://api.github.com/users/Brightspace/events{/privacy}","received_events_url":"https://api.github.com/users/Brightspace/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Brightspace/d2l-my-courses-ui","description":null,"fork":false,"url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui","forks_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/forks","keys_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/teams","hooks_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/hooks","issue_events_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/issues/events{/number}","events_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/events","assignees_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/assignees{/user}","branches_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/branches{/branch}","tags_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/tags","blobs_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/languages","stargazers_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/stargazers","contributors_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/contributors","subscribers_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/subscribers","subscription_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/subscription","commits_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/contents/{+path}","compare_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/merges","archive_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/downloads","issues_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/issues{/number}","pulls_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/labels{/name}","releases_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/releases{/id}","deployments_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/deployments","created_at":"2016-03-22T16:48:09Z","updated_at":"2018-02-01T19:53:45Z","pushed_at":"2018-02-08T15:59:53Z","git_url":"git://github.com/Brightspace/d2l-my-courses-ui.git","ssh_url":"[email protected]:Brightspace/d2l-my-courses-ui.git","clone_url":"https://github.com/Brightspace/d2l-my-courses-ui.git","svn_url":"https://github.com/Brightspace/d2l-my-courses-ui","homepage":null,"size":1876,"stargazers_count":2,"watchers_count":2,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":4,"open_issues":7,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/pulls/501"},"html":{"href":"https://github.com/Brightspace/d2l-my-courses-ui/pull/501"},"issue":{"href":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/issues/501"},"comments":{"href":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/issues/501/comments"},"review_comments":{"href":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/pulls/501/comments"},"review_comment":{"href":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/pulls/501/commits"},"statuses":{"href":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/statuses/f4dc72322579642fe134245528b6e01813b57b99"}},"author_association":"CONTRIBUTOR"}} | {
"id": 54492398,
"name": "Brightspace/d2l-my-courses-ui",
"url": "https://api.github.com/repos/Brightspace/d2l-my-courses-ui"
} | {
"id": 6231623,
"login": "ryantmer",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6231623?",
"url": "https://api.github.com/users/ryantmer"
} | {
"id": 5429170,
"login": "Brightspace",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5429170?",
"url": "https://api.github.com/orgs/Brightspace"
} | 2018-02-08T16:03:57 | 7217798218 | {"actor":{"display_login":"ryantmer"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/projecttacoma/bonnie/pulls/comments/202403698","pull_request_review_id":137102798,"id":202403698,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMjQwMzY5OA==","diff_hunk":"@@ -175,8 +175,12 @@ class CQLResultsHelpers\n statementResults[lib][statementName].final = 'NA'\n statementResults[lib][statementName].pretty = 'NA' if doPretty\n else if statementRelevance[lib][statementName] == 'FALSE' || !rawClauseResults[lib]?\n- statementResults[lib][statementName].final = 'UNHIT'\n- statementResults[lib][statementName].pretty = 'UNHIT' if doPretty\n+ # even if the statement wasn't hit, we want the pretty result to just be FUNCTION for functions\n+ if CQLMeasureHelpers.isStatementFunction(measure, lib, statementName)\n+ statementResults[lib][statementName].pretty = \"FUNCTION\" if doPretty","path":"app/assets/javascripts/helpers/cql_results_helpers.js.coffee","position":null,"original_position":8,"commit_id":"daaa97d5ebecb13367ae0c393ceb59189a616f74","original_commit_id":"a8b21c924e9784e453cb20d347d37236819125cd","user":{"login":"c-monkey","id":22219041,"node_id":"MDQ6VXNlcjIyMjE5MDQx","avatar_url":"https://avatars1.githubusercontent.com/u/22219041?v=4","gravatar_id":"","url":"https://api.github.com/users/c-monkey","html_url":"https://github.com/c-monkey","followers_url":"https://api.github.com/users/c-monkey/followers","following_url":"https://api.github.com/users/c-monkey/following{/other_user}","gists_url":"https://api.github.com/users/c-monkey/gists{/gist_id}","starred_url":"https://api.github.com/users/c-monkey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/c-monkey/subscriptions","organizations_url":"https://api.github.com/users/c-monkey/orgs","repos_url":"https://api.github.com/users/c-monkey/repos","events_url":"https://api.github.com/users/c-monkey/events{/privacy}","received_events_url":"https://api.github.com/users/c-monkey/received_events","type":"User","site_admin":false},"body":"I agree that the JIRA test covers this line. And for time considerations I'll consent to us not adding a unit test.","created_at":"2018-07-13T16:20:56Z","updated_at":"2018-07-13T16:20:57Z","html_url":"https://github.com/projecttacoma/bonnie/pull/1031#discussion_r202403698","pull_request_url":"https://api.github.com/repos/projecttacoma/bonnie/pulls/1031","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/projecttacoma/bonnie/pulls/comments/202403698"},"html":{"href":"https://github.com/projecttacoma/bonnie/pull/1031#discussion_r202403698"},"pull_request":{"href":"https://api.github.com/repos/projecttacoma/bonnie/pulls/1031"}},"in_reply_to_id":202164530},"pull_request":{"url":"https://api.github.com/repos/projecttacoma/bonnie/pulls/1031","id":200724542,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAwNzI0NTQy","html_url":"https://github.com/projecttacoma/bonnie/pull/1031","diff_url":"https://github.com/projecttacoma/bonnie/pull/1031.diff","patch_url":"https://github.com/projecttacoma/bonnie/pull/1031.patch","issue_url":"https://api.github.com/repos/projecttacoma/bonnie/issues/1031","number":1031,"state":"open","locked":false,"title":"Excel key fix","user":{"login":"daco101","id":40396363,"node_id":"MDQ6VXNlcjQwMzk2MzYz","avatar_url":"https://avatars0.githubusercontent.com/u/40396363?v=4","gravatar_id":"","url":"https://api.github.com/users/daco101","html_url":"https://github.com/daco101","followers_url":"https://api.github.com/users/daco101/followers","following_url":"https://api.github.com/users/daco101/following{/other_user}","gists_url":"https://api.github.com/users/daco101/gists{/gist_id}","starred_url":"https://api.github.com/users/daco101/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daco101/subscriptions","organizations_url":"https://api.github.com/users/daco101/orgs","repos_url":"https://api.github.com/users/daco101/repos","events_url":"https://api.github.com/users/daco101/events{/privacy}","received_events_url":"https://api.github.com/users/daco101/received_events","type":"User","site_admin":false},"body":"This PR slightly modifies the \"pretty result\" function to match the style from the qdm_patientapi, improves the excel \"key\" sheet, and adds a maximum column width to the excel export.\r\n\r\nPull requests into Bonnie require the following. Submitter and reviewer should :white_check_mark: when done. For items that are not-applicable, note it's not-applicable (\"N/A\") and :white_check_mark:.\r\n\r\n**Submitter:**\r\n- [x] This pull request describes why these changes were made.\r\n- [x] This PR is into the correct branch.\r\n- [x] JIRA ticket for this PR: https://jira.mitre.org/browse/BONNIE-1584\r\n- [x] JIRA ticket links to this PR\r\n- [x] Code diff has been done and been reviewed (it **does not** contain: additional white space, not applicable code changes, debug statements, etc.)\r\n- [x] If UI changes have been made, google WAVE plug-in has been executed to ensure no 508 issues were introduced. N/A\r\n- [x] Tests are included and test edge cases\r\n- [x] Tests have been run locally and pass (remember to update Gemfile when applicable)\r\n- [x] Test fixtures updated and documented as necessary ( see [internal wiki](https://gitlab.mitre.org/bonnie/internal-documentation/wikis/testing#test-fixtures) )\r\n- [x] Code coverage has not gone down and all code touched or added is covered. \r\n * In rare situations, this may not be possible or applicable to a PR. In those situations:\r\n 1. Note why this could not be done or is not applicable here: \r\n 2. Add TODOs in the code noting that it requires a test\r\n 3. Add a JIRA task to add the test and link it here: \r\n\r\nBranch | Back End Coverage | Front End Coverage\r\n-- | -- | --\r\nmaster | 1753 / 1965 LOC (89.21%) covered | Statements : 59.44% ( 7280/12247 )<br>Branches : 43.43% ( 1979/4557 )<br>Functions : 49.81% ( 1207/2423 )<br>Lines : 57.31% ( 6536/11404 )\r\nexcel_key_fix | 1759 / 1971 LOC (89.24%) covered | Statements : 59.44% ( 7280/12247 )<br>Branches: 43.46% ( 1982/4561 )<br>Functions : 49.81% ( 1207/2423 )<br>Lines: 57.32% ( 6538/11407 )\r\n\r\n- [x] Automated regression test(s) pass\r\n\r\nIf JIRA tests were used to supplement or replace automated tests:\r\n- [x] JIRA test links: https://jira.mitre.org/browse/BONNIE-1588\r\n- [x] Justification for using JIRA tests: Automatic testing of excel exports not yet in place - due to time constraints JIRA testing makes more sense at this time.\r\n- [x] JIRA tests have been added to sprint: Yes\r\n\r\n\r\n**Reviewer 1:**\r\n\r\nName: Chris\r\n- [ ] Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose\r\n- [ ] The tests appropriately test the new code, including edge cases\r\n- [ ] You have tried to break the code\r\n\r\nIf JIRA tests were used to supplement or replace automated tests:\r\n- [ ] JIRA tests have been run and pass\r\n- [ ] You agree with the justification for use of JIRA tests or have provided input on why you disagree\r\n\r\n\r\n**Reviewer 2:**\r\n\r\nName: Lizzie\r\n- [x] Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose\r\n- [ ] The tests appropriately test the new code, including edge cases\r\n- [x] You have tried to break the code\r\n\r\nIf JIRA tests were used to supplement or replace automated tests:\r\n- [ ] JIRA tests have been run and pass\r\n- [ ] You agree with the justification for use of JIRA tests or have provided input on why you disagree\r\n","created_at":"2018-07-11T14:41:57Z","updated_at":"2018-07-13T16:20:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"706515c1d68e4a277aeea0010a66e00078718411","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/projecttacoma/bonnie/pulls/1031/commits","review_comments_url":"https://api.github.com/repos/projecttacoma/bonnie/pulls/1031/comments","review_comment_url":"https://api.github.com/repos/projecttacoma/bonnie/pulls/comments{/number}","comments_url":"https://api.github.com/repos/projecttacoma/bonnie/issues/1031/comments","statuses_url":"https://api.github.com/repos/projecttacoma/bonnie/statuses/daaa97d5ebecb13367ae0c393ceb59189a616f74","head":{"label":"projecttacoma:excel_key_fix","ref":"excel_key_fix","sha":"daaa97d5ebecb13367ae0c393ceb59189a616f74","user":{"login":"projecttacoma","id":5497023,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0OTcwMjM=","avatar_url":"https://avatars2.githubusercontent.com/u/5497023?v=4","gravatar_id":"","url":"https://api.github.com/users/projecttacoma","html_url":"https://github.com/projecttacoma","followers_url":"https://api.github.com/users/projecttacoma/followers","following_url":"https://api.github.com/users/projecttacoma/following{/other_user}","gists_url":"https://api.github.com/users/projecttacoma/gists{/gist_id}","starred_url":"https://api.github.com/users/projecttacoma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projecttacoma/subscriptions","organizations_url":"https://api.github.com/users/projecttacoma/orgs","repos_url":"https://api.github.com/users/projecttacoma/repos","events_url":"https://api.github.com/users/projecttacoma/events{/privacy}","received_events_url":"https://api.github.com/users/projecttacoma/received_events","type":"Organization","site_admin":false},"repo":{"id":12958279,"node_id":"MDEwOlJlcG9zaXRvcnkxMjk1ODI3OQ==","name":"bonnie","full_name":"projecttacoma/bonnie","owner":{"login":"projecttacoma","id":5497023,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0OTcwMjM=","avatar_url":"https://avatars2.githubusercontent.com/u/5497023?v=4","gravatar_id":"","url":"https://api.github.com/users/projecttacoma","html_url":"https://github.com/projecttacoma","followers_url":"https://api.github.com/users/projecttacoma/followers","following_url":"https://api.github.com/users/projecttacoma/following{/other_user}","gists_url":"https://api.github.com/users/projecttacoma/gists{/gist_id}","starred_url":"https://api.github.com/users/projecttacoma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projecttacoma/subscriptions","organizations_url":"https://api.github.com/users/projecttacoma/orgs","repos_url":"https://api.github.com/users/projecttacoma/repos","events_url":"https://api.github.com/users/projecttacoma/events{/privacy}","received_events_url":"https://api.github.com/users/projecttacoma/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/projecttacoma/bonnie","description":"Clinical Quality Measure Testing Tool","fork":false,"url":"https://api.github.com/repos/projecttacoma/bonnie","forks_url":"https://api.github.com/repos/projecttacoma/bonnie/forks","keys_url":"https://api.github.com/repos/projecttacoma/bonnie/keys{/key_id}","collaborators_url":"https://api.github.com/repos/projecttacoma/bonnie/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/projecttacoma/bonnie/teams","hooks_url":"https://api.github.com/repos/projecttacoma/bonnie/hooks","issue_events_url":"https://api.github.com/repos/projecttacoma/bonnie/issues/events{/number}","events_url":"https://api.github.com/repos/projecttacoma/bonnie/events","assignees_url":"https://api.github.com/repos/projecttacoma/bonnie/assignees{/user}","branches_url":"https://api.github.com/repos/projecttacoma/bonnie/branches{/branch}","tags_url":"https://api.github.com/repos/projecttacoma/bonnie/tags","blobs_url":"https://api.github.com/repos/projecttacoma/bonnie/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/projecttacoma/bonnie/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/projecttacoma/bonnie/git/refs{/sha}","trees_url":"https://api.github.com/repos/projecttacoma/bonnie/git/trees{/sha}","statuses_url":"https://api.github.com/repos/projecttacoma/bonnie/statuses/{sha}","languages_url":"https://api.github.com/repos/projecttacoma/bonnie/languages","stargazers_url":"https://api.github.com/repos/projecttacoma/bonnie/stargazers","contributors_url":"https://api.github.com/repos/projecttacoma/bonnie/contributors","subscribers_url":"https://api.github.com/repos/projecttacoma/bonnie/subscribers","subscription_url":"https://api.github.com/repos/projecttacoma/bonnie/subscription","commits_url":"https://api.github.com/repos/projecttacoma/bonnie/commits{/sha}","git_commits_url":"https://api.github.com/repos/projecttacoma/bonnie/git/commits{/sha}","comments_url":"https://api.github.com/repos/projecttacoma/bonnie/comments{/number}","issue_comment_url":"https://api.github.com/repos/projecttacoma/bonnie/issues/comments{/number}","contents_url":"https://api.github.com/repos/projecttacoma/bonnie/contents/{+path}","compare_url":"https://api.github.com/repos/projecttacoma/bonnie/compare/{base}...{head}","merges_url":"https://api.github.com/repos/projecttacoma/bonnie/merges","archive_url":"https://api.github.com/repos/projecttacoma/bonnie/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/projecttacoma/bonnie/downloads","issues_url":"https://api.github.com/repos/projecttacoma/bonnie/issues{/number}","pulls_url":"https://api.github.com/repos/projecttacoma/bonnie/pulls{/number}","milestones_url":"https://api.github.com/repos/projecttacoma/bonnie/milestones{/number}","notifications_url":"https://api.github.com/repos/projecttacoma/bonnie/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/projecttacoma/bonnie/labels{/name}","releases_url":"https://api.github.com/repos/projecttacoma/bonnie/releases{/id}","deployments_url":"https://api.github.com/repos/projecttacoma/bonnie/deployments","created_at":"2013-09-19T20:11:14Z","updated_at":"2018-06-20T19:11:18Z","pushed_at":"2018-07-13T15:01:04Z","git_url":"git://github.com/projecttacoma/bonnie.git","ssh_url":"[email protected]:projecttacoma/bonnie.git","clone_url":"https://github.com/projecttacoma/bonnie.git","svn_url":"https://github.com/projecttacoma/bonnie","homepage":null,"size":112129,"stargazers_count":21,"watchers_count":21,"language":"CoffeeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":19,"mirror_url":null,"archived":false,"open_issues_count":8,"license":null,"forks":19,"open_issues":8,"watchers":21,"default_branch":"master"}},"base":{"label":"projecttacoma:bonnie-v2.2","ref":"bonnie-v2.2","sha":"4a134c9543e5e833c34c1a83d265ae0c532ce523","user":{"login":"projecttacoma","id":5497023,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0OTcwMjM=","avatar_url":"https://avatars2.githubusercontent.com/u/5497023?v=4","gravatar_id":"","url":"https://api.github.com/users/projecttacoma","html_url":"https://github.com/projecttacoma","followers_url":"https://api.github.com/users/projecttacoma/followers","following_url":"https://api.github.com/users/projecttacoma/following{/other_user}","gists_url":"https://api.github.com/users/projecttacoma/gists{/gist_id}","starred_url":"https://api.github.com/users/projecttacoma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projecttacoma/subscriptions","organizations_url":"https://api.github.com/users/projecttacoma/orgs","repos_url":"https://api.github.com/users/projecttacoma/repos","events_url":"https://api.github.com/users/projecttacoma/events{/privacy}","received_events_url":"https://api.github.com/users/projecttacoma/received_events","type":"Organization","site_admin":false},"repo":{"id":12958279,"node_id":"MDEwOlJlcG9zaXRvcnkxMjk1ODI3OQ==","name":"bonnie","full_name":"projecttacoma/bonnie","owner":{"login":"projecttacoma","id":5497023,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0OTcwMjM=","avatar_url":"https://avatars2.githubusercontent.com/u/5497023?v=4","gravatar_id":"","url":"https://api.github.com/users/projecttacoma","html_url":"https://github.com/projecttacoma","followers_url":"https://api.github.com/users/projecttacoma/followers","following_url":"https://api.github.com/users/projecttacoma/following{/other_user}","gists_url":"https://api.github.com/users/projecttacoma/gists{/gist_id}","starred_url":"https://api.github.com/users/projecttacoma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projecttacoma/subscriptions","organizations_url":"https://api.github.com/users/projecttacoma/orgs","repos_url":"https://api.github.com/users/projecttacoma/repos","events_url":"https://api.github.com/users/projecttacoma/events{/privacy}","received_events_url":"https://api.github.com/users/projecttacoma/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/projecttacoma/bonnie","description":"Clinical Quality Measure Testing Tool","fork":false,"url":"https://api.github.com/repos/projecttacoma/bonnie","forks_url":"https://api.github.com/repos/projecttacoma/bonnie/forks","keys_url":"https://api.github.com/repos/projecttacoma/bonnie/keys{/key_id}","collaborators_url":"https://api.github.com/repos/projecttacoma/bonnie/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/projecttacoma/bonnie/teams","hooks_url":"https://api.github.com/repos/projecttacoma/bonnie/hooks","issue_events_url":"https://api.github.com/repos/projecttacoma/bonnie/issues/events{/number}","events_url":"https://api.github.com/repos/projecttacoma/bonnie/events","assignees_url":"https://api.github.com/repos/projecttacoma/bonnie/assignees{/user}","branches_url":"https://api.github.com/repos/projecttacoma/bonnie/branches{/branch}","tags_url":"https://api.github.com/repos/projecttacoma/bonnie/tags","blobs_url":"https://api.github.com/repos/projecttacoma/bonnie/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/projecttacoma/bonnie/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/projecttacoma/bonnie/git/refs{/sha}","trees_url":"https://api.github.com/repos/projecttacoma/bonnie/git/trees{/sha}","statuses_url":"https://api.github.com/repos/projecttacoma/bonnie/statuses/{sha}","languages_url":"https://api.github.com/repos/projecttacoma/bonnie/languages","stargazers_url":"https://api.github.com/repos/projecttacoma/bonnie/stargazers","contributors_url":"https://api.github.com/repos/projecttacoma/bonnie/contributors","subscribers_url":"https://api.github.com/repos/projecttacoma/bonnie/subscribers","subscription_url":"https://api.github.com/repos/projecttacoma/bonnie/subscription","commits_url":"https://api.github.com/repos/projecttacoma/bonnie/commits{/sha}","git_commits_url":"https://api.github.com/repos/projecttacoma/bonnie/git/commits{/sha}","comments_url":"https://api.github.com/repos/projecttacoma/bonnie/comments{/number}","issue_comment_url":"https://api.github.com/repos/projecttacoma/bonnie/issues/comments{/number}","contents_url":"https://api.github.com/repos/projecttacoma/bonnie/contents/{+path}","compare_url":"https://api.github.com/repos/projecttacoma/bonnie/compare/{base}...{head}","merges_url":"https://api.github.com/repos/projecttacoma/bonnie/merges","archive_url":"https://api.github.com/repos/projecttacoma/bonnie/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/projecttacoma/bonnie/downloads","issues_url":"https://api.github.com/repos/projecttacoma/bonnie/issues{/number}","pulls_url":"https://api.github.com/repos/projecttacoma/bonnie/pulls{/number}","milestones_url":"https://api.github.com/repos/projecttacoma/bonnie/milestones{/number}","notifications_url":"https://api.github.com/repos/projecttacoma/bonnie/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/projecttacoma/bonnie/labels{/name}","releases_url":"https://api.github.com/repos/projecttacoma/bonnie/releases{/id}","deployments_url":"https://api.github.com/repos/projecttacoma/bonnie/deployments","created_at":"2013-09-19T20:11:14Z","updated_at":"2018-06-20T19:11:18Z","pushed_at":"2018-07-13T15:01:04Z","git_url":"git://github.com/projecttacoma/bonnie.git","ssh_url":"[email protected]:projecttacoma/bonnie.git","clone_url":"https://github.com/projecttacoma/bonnie.git","svn_url":"https://github.com/projecttacoma/bonnie","homepage":null,"size":112129,"stargazers_count":21,"watchers_count":21,"language":"CoffeeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":19,"mirror_url":null,"archived":false,"open_issues_count":8,"license":null,"forks":19,"open_issues":8,"watchers":21,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/projecttacoma/bonnie/pulls/1031"},"html":{"href":"https://github.com/projecttacoma/bonnie/pull/1031"},"issue":{"href":"https://api.github.com/repos/projecttacoma/bonnie/issues/1031"},"comments":{"href":"https://api.github.com/repos/projecttacoma/bonnie/issues/1031/comments"},"review_comments":{"href":"https://api.github.com/repos/projecttacoma/bonnie/pulls/1031/comments"},"review_comment":{"href":"https://api.github.com/repos/projecttacoma/bonnie/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/projecttacoma/bonnie/pulls/1031/commits"},"statuses":{"href":"https://api.github.com/repos/projecttacoma/bonnie/statuses/daaa97d5ebecb13367ae0c393ceb59189a616f74"}},"author_association":"NONE"}} | {
"id": 12958279,
"name": "projecttacoma/bonnie",
"url": "https://api.github.com/repos/projecttacoma/bonnie"
} | {
"id": 22219041,
"login": "c-monkey",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/22219041?",
"url": "https://api.github.com/users/c-monkey"
} | {
"id": 5497023,
"login": "projecttacoma",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5497023?",
"url": "https://api.github.com/orgs/projecttacoma"
} | 2018-07-13T16:20:56 | 7963105613 | {"actor":{"display_login":"c-monkey"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/MyOnlineStore/bricks/pulls/comments/194006038","pull_request_review_id":127090382,"id":194006038,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NDAwNjAzOA==","diff_hunk":"@@ -0,0 +1,41 @@\n+import _R from 'react';\n+import { StyledComponentClass as _S } from 'styled-components';\n+import _T from '../../types/ThemeType';\n+import styled, { withProps } from '../../utility/styled';\n+\n+type RadioButtonPropsType = {\n+ checked: boolean;\n+}\n+\n+type RadioButtonThemeType = {\n+ common: {\n+ boxShadow: string;\n+ border: string;\n+ };\n+}\n+\n+const StyledRadioWrapper = styled.div`\n+display: flex;\n+`\n+\n+const StyledRadioButton = withProps<RadioButtonPropsType, HTMLInputElement>(styled.input) `\n+position: relative;","path":"src/components/RadioButton/style.tsx","position":22,"original_position":22,"commit_id":"da1040c6b1c47ba23181708166b617e4f0b08720","original_commit_id":"da1040c6b1c47ba23181708166b617e4f0b08720","user":{"login":"CarloPalinckx","id":6347900,"node_id":"MDQ6VXNlcjYzNDc5MDA=","avatar_url":"https://avatars1.githubusercontent.com/u/6347900?v=4","gravatar_id":"","url":"https://api.github.com/users/CarloPalinckx","html_url":"https://github.com/CarloPalinckx","followers_url":"https://api.github.com/users/CarloPalinckx/followers","following_url":"https://api.github.com/users/CarloPalinckx/following{/other_user}","gists_url":"https://api.github.com/users/CarloPalinckx/gists{/gist_id}","starred_url":"https://api.github.com/users/CarloPalinckx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CarloPalinckx/subscriptions","organizations_url":"https://api.github.com/users/CarloPalinckx/orgs","repos_url":"https://api.github.com/users/CarloPalinckx/repos","events_url":"https://api.github.com/users/CarloPalinckx/events{/privacy}","received_events_url":"https://api.github.com/users/CarloPalinckx/received_events","type":"User","site_admin":false},"body":"idem","created_at":"2018-06-08T09:44:00Z","updated_at":"2018-06-08T09:58:23Z","html_url":"https://github.com/MyOnlineStore/bricks/pull/78#discussion_r194006038","pull_request_url":"https://api.github.com/repos/MyOnlineStore/bricks/pulls/78","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/MyOnlineStore/bricks/pulls/comments/194006038"},"html":{"href":"https://github.com/MyOnlineStore/bricks/pull/78#discussion_r194006038"},"pull_request":{"href":"https://api.github.com/repos/MyOnlineStore/bricks/pulls/78"}}},"pull_request":{"url":"https://api.github.com/repos/MyOnlineStore/bricks/pulls/78","id":193538469,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzNTM4NDY5","html_url":"https://github.com/MyOnlineStore/bricks/pull/78","diff_url":"https://github.com/MyOnlineStore/bricks/pull/78.diff","patch_url":"https://github.com/MyOnlineStore/bricks/pull/78.patch","issue_url":"https://api.github.com/repos/MyOnlineStore/bricks/issues/78","number":78,"state":"open","locked":false,"title":"Radiobutton","user":{"login":"nicokoelewijn","id":4093202,"node_id":"MDQ6VXNlcjQwOTMyMDI=","avatar_url":"https://avatars0.githubusercontent.com/u/4093202?v=4","gravatar_id":"","url":"https://api.github.com/users/nicokoelewijn","html_url":"https://github.com/nicokoelewijn","followers_url":"https://api.github.com/users/nicokoelewijn/followers","following_url":"https://api.github.com/users/nicokoelewijn/following{/other_user}","gists_url":"https://api.github.com/users/nicokoelewijn/gists{/gist_id}","starred_url":"https://api.github.com/users/nicokoelewijn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicokoelewijn/subscriptions","organizations_url":"https://api.github.com/users/nicokoelewijn/orgs","repos_url":"https://api.github.com/users/nicokoelewijn/repos","events_url":"https://api.github.com/users/nicokoelewijn/events{/privacy}","received_events_url":"https://api.github.com/users/nicokoelewijn/received_events","type":"User","site_admin":false},"body":"### This PR:\r\n\r\nresolves #31 \r\n\r\n**Adds** ✨\r\n- RadioButton\r\n- RadioButtonGroup\r\n\r\n**Changes** 🌀\r\n\r\n**Removes** 👋\r\n","created_at":"2018-06-08T08:09:14Z","updated_at":"2018-06-08T09:58:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"08c255f2e77c3eb808c07b9ac5e41ae709cad938","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/MyOnlineStore/bricks/pulls/78/commits","review_comments_url":"https://api.github.com/repos/MyOnlineStore/bricks/pulls/78/comments","review_comment_url":"https://api.github.com/repos/MyOnlineStore/bricks/pulls/comments{/number}","comments_url":"https://api.github.com/repos/MyOnlineStore/bricks/issues/78/comments","statuses_url":"https://api.github.com/repos/MyOnlineStore/bricks/statuses/da1040c6b1c47ba23181708166b617e4f0b08720","head":{"label":"MyOnlineStore:radiobutton","ref":"radiobutton","sha":"da1040c6b1c47ba23181708166b617e4f0b08720","user":{"login":"MyOnlineStore","id":5500273,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU1MDAyNzM=","avatar_url":"https://avatars0.githubusercontent.com/u/5500273?v=4","gravatar_id":"","url":"https://api.github.com/users/MyOnlineStore","html_url":"https://github.com/MyOnlineStore","followers_url":"https://api.github.com/users/MyOnlineStore/followers","following_url":"https://api.github.com/users/MyOnlineStore/following{/other_user}","gists_url":"https://api.github.com/users/MyOnlineStore/gists{/gist_id}","starred_url":"https://api.github.com/users/MyOnlineStore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MyOnlineStore/subscriptions","organizations_url":"https://api.github.com/users/MyOnlineStore/orgs","repos_url":"https://api.github.com/users/MyOnlineStore/repos","events_url":"https://api.github.com/users/MyOnlineStore/events{/privacy}","received_events_url":"https://api.github.com/users/MyOnlineStore/received_events","type":"Organization","site_admin":false},"repo":{"id":125216905,"node_id":"MDEwOlJlcG9zaXRvcnkxMjUyMTY5MDU=","name":"bricks","full_name":"MyOnlineStore/bricks","owner":{"login":"MyOnlineStore","id":5500273,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU1MDAyNzM=","avatar_url":"https://avatars0.githubusercontent.com/u/5500273?v=4","gravatar_id":"","url":"https://api.github.com/users/MyOnlineStore","html_url":"https://github.com/MyOnlineStore","followers_url":"https://api.github.com/users/MyOnlineStore/followers","following_url":"https://api.github.com/users/MyOnlineStore/following{/other_user}","gists_url":"https://api.github.com/users/MyOnlineStore/gists{/gist_id}","starred_url":"https://api.github.com/users/MyOnlineStore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MyOnlineStore/subscriptions","organizations_url":"https://api.github.com/users/MyOnlineStore/orgs","repos_url":"https://api.github.com/users/MyOnlineStore/repos","events_url":"https://api.github.com/users/MyOnlineStore/events{/privacy}","received_events_url":"https://api.github.com/users/MyOnlineStore/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MyOnlineStore/bricks","description":"MyOnlineStore's component library 🌳","fork":false,"url":"https://api.github.com/repos/MyOnlineStore/bricks","forks_url":"https://api.github.com/repos/MyOnlineStore/bricks/forks","keys_url":"https://api.github.com/repos/MyOnlineStore/bricks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MyOnlineStore/bricks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MyOnlineStore/bricks/teams","hooks_url":"https://api.github.com/repos/MyOnlineStore/bricks/hooks","issue_events_url":"https://api.github.com/repos/MyOnlineStore/bricks/issues/events{/number}","events_url":"https://api.github.com/repos/MyOnlineStore/bricks/events","assignees_url":"https://api.github.com/repos/MyOnlineStore/bricks/assignees{/user}","branches_url":"https://api.github.com/repos/MyOnlineStore/bricks/branches{/branch}","tags_url":"https://api.github.com/repos/MyOnlineStore/bricks/tags","blobs_url":"https://api.github.com/repos/MyOnlineStore/bricks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MyOnlineStore/bricks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MyOnlineStore/bricks/git/refs{/sha}","trees_url":"https://api.github.com/repos/MyOnlineStore/bricks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MyOnlineStore/bricks/statuses/{sha}","languages_url":"https://api.github.com/repos/MyOnlineStore/bricks/languages","stargazers_url":"https://api.github.com/repos/MyOnlineStore/bricks/stargazers","contributors_url":"https://api.github.com/repos/MyOnlineStore/bricks/contributors","subscribers_url":"https://api.github.com/repos/MyOnlineStore/bricks/subscribers","subscription_url":"https://api.github.com/repos/MyOnlineStore/bricks/subscription","commits_url":"https://api.github.com/repos/MyOnlineStore/bricks/commits{/sha}","git_commits_url":"https://api.github.com/repos/MyOnlineStore/bricks/git/commits{/sha}","comments_url":"https://api.github.com/repos/MyOnlineStore/bricks/comments{/number}","issue_comment_url":"https://api.github.com/repos/MyOnlineStore/bricks/issues/comments{/number}","contents_url":"https://api.github.com/repos/MyOnlineStore/bricks/contents/{+path}","compare_url":"https://api.github.com/repos/MyOnlineStore/bricks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MyOnlineStore/bricks/merges","archive_url":"https://api.github.com/repos/MyOnlineStore/bricks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MyOnlineStore/bricks/downloads","issues_url":"https://api.github.com/repos/MyOnlineStore/bricks/issues{/number}","pulls_url":"https://api.github.com/repos/MyOnlineStore/bricks/pulls{/number}","milestones_url":"https://api.github.com/repos/MyOnlineStore/bricks/milestones{/number}","notifications_url":"https://api.github.com/repos/MyOnlineStore/bricks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MyOnlineStore/bricks/labels{/name}","releases_url":"https://api.github.com/repos/MyOnlineStore/bricks/releases{/id}","deployments_url":"https://api.github.com/repos/MyOnlineStore/bricks/deployments","created_at":"2018-03-14T13:29:51Z","updated_at":"2018-06-08T07:45:11Z","pushed_at":"2018-06-08T09:28:37Z","git_url":"git://github.com/MyOnlineStore/bricks.git","ssh_url":"[email protected]:MyOnlineStore/bricks.git","clone_url":"https://github.com/MyOnlineStore/bricks.git","svn_url":"https://github.com/MyOnlineStore/bricks","homepage":"https://www.myonlinestore.com/","size":1641,"stargazers_count":3,"watchers_count":3,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":16,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":16,"watchers":3,"default_branch":"master"}},"base":{"label":"MyOnlineStore:master","ref":"master","sha":"7b284f0a8ac1ba8fcc06a8b43a094f69a9579755","user":{"login":"MyOnlineStore","id":5500273,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU1MDAyNzM=","avatar_url":"https://avatars0.githubusercontent.com/u/5500273?v=4","gravatar_id":"","url":"https://api.github.com/users/MyOnlineStore","html_url":"https://github.com/MyOnlineStore","followers_url":"https://api.github.com/users/MyOnlineStore/followers","following_url":"https://api.github.com/users/MyOnlineStore/following{/other_user}","gists_url":"https://api.github.com/users/MyOnlineStore/gists{/gist_id}","starred_url":"https://api.github.com/users/MyOnlineStore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MyOnlineStore/subscriptions","organizations_url":"https://api.github.com/users/MyOnlineStore/orgs","repos_url":"https://api.github.com/users/MyOnlineStore/repos","events_url":"https://api.github.com/users/MyOnlineStore/events{/privacy}","received_events_url":"https://api.github.com/users/MyOnlineStore/received_events","type":"Organization","site_admin":false},"repo":{"id":125216905,"node_id":"MDEwOlJlcG9zaXRvcnkxMjUyMTY5MDU=","name":"bricks","full_name":"MyOnlineStore/bricks","owner":{"login":"MyOnlineStore","id":5500273,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU1MDAyNzM=","avatar_url":"https://avatars0.githubusercontent.com/u/5500273?v=4","gravatar_id":"","url":"https://api.github.com/users/MyOnlineStore","html_url":"https://github.com/MyOnlineStore","followers_url":"https://api.github.com/users/MyOnlineStore/followers","following_url":"https://api.github.com/users/MyOnlineStore/following{/other_user}","gists_url":"https://api.github.com/users/MyOnlineStore/gists{/gist_id}","starred_url":"https://api.github.com/users/MyOnlineStore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MyOnlineStore/subscriptions","organizations_url":"https://api.github.com/users/MyOnlineStore/orgs","repos_url":"https://api.github.com/users/MyOnlineStore/repos","events_url":"https://api.github.com/users/MyOnlineStore/events{/privacy}","received_events_url":"https://api.github.com/users/MyOnlineStore/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MyOnlineStore/bricks","description":"MyOnlineStore's component library 🌳","fork":false,"url":"https://api.github.com/repos/MyOnlineStore/bricks","forks_url":"https://api.github.com/repos/MyOnlineStore/bricks/forks","keys_url":"https://api.github.com/repos/MyOnlineStore/bricks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MyOnlineStore/bricks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MyOnlineStore/bricks/teams","hooks_url":"https://api.github.com/repos/MyOnlineStore/bricks/hooks","issue_events_url":"https://api.github.com/repos/MyOnlineStore/bricks/issues/events{/number}","events_url":"https://api.github.com/repos/MyOnlineStore/bricks/events","assignees_url":"https://api.github.com/repos/MyOnlineStore/bricks/assignees{/user}","branches_url":"https://api.github.com/repos/MyOnlineStore/bricks/branches{/branch}","tags_url":"https://api.github.com/repos/MyOnlineStore/bricks/tags","blobs_url":"https://api.github.com/repos/MyOnlineStore/bricks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MyOnlineStore/bricks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MyOnlineStore/bricks/git/refs{/sha}","trees_url":"https://api.github.com/repos/MyOnlineStore/bricks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MyOnlineStore/bricks/statuses/{sha}","languages_url":"https://api.github.com/repos/MyOnlineStore/bricks/languages","stargazers_url":"https://api.github.com/repos/MyOnlineStore/bricks/stargazers","contributors_url":"https://api.github.com/repos/MyOnlineStore/bricks/contributors","subscribers_url":"https://api.github.com/repos/MyOnlineStore/bricks/subscribers","subscription_url":"https://api.github.com/repos/MyOnlineStore/bricks/subscription","commits_url":"https://api.github.com/repos/MyOnlineStore/bricks/commits{/sha}","git_commits_url":"https://api.github.com/repos/MyOnlineStore/bricks/git/commits{/sha}","comments_url":"https://api.github.com/repos/MyOnlineStore/bricks/comments{/number}","issue_comment_url":"https://api.github.com/repos/MyOnlineStore/bricks/issues/comments{/number}","contents_url":"https://api.github.com/repos/MyOnlineStore/bricks/contents/{+path}","compare_url":"https://api.github.com/repos/MyOnlineStore/bricks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MyOnlineStore/bricks/merges","archive_url":"https://api.github.com/repos/MyOnlineStore/bricks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MyOnlineStore/bricks/downloads","issues_url":"https://api.github.com/repos/MyOnlineStore/bricks/issues{/number}","pulls_url":"https://api.github.com/repos/MyOnlineStore/bricks/pulls{/number}","milestones_url":"https://api.github.com/repos/MyOnlineStore/bricks/milestones{/number}","notifications_url":"https://api.github.com/repos/MyOnlineStore/bricks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MyOnlineStore/bricks/labels{/name}","releases_url":"https://api.github.com/repos/MyOnlineStore/bricks/releases{/id}","deployments_url":"https://api.github.com/repos/MyOnlineStore/bricks/deployments","created_at":"2018-03-14T13:29:51Z","updated_at":"2018-06-08T07:45:11Z","pushed_at":"2018-06-08T09:28:37Z","git_url":"git://github.com/MyOnlineStore/bricks.git","ssh_url":"[email protected]:MyOnlineStore/bricks.git","clone_url":"https://github.com/MyOnlineStore/bricks.git","svn_url":"https://github.com/MyOnlineStore/bricks","homepage":"https://www.myonlinestore.com/","size":1641,"stargazers_count":3,"watchers_count":3,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":16,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":16,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/MyOnlineStore/bricks/pulls/78"},"html":{"href":"https://github.com/MyOnlineStore/bricks/pull/78"},"issue":{"href":"https://api.github.com/repos/MyOnlineStore/bricks/issues/78"},"comments":{"href":"https://api.github.com/repos/MyOnlineStore/bricks/issues/78/comments"},"review_comments":{"href":"https://api.github.com/repos/MyOnlineStore/bricks/pulls/78/comments"},"review_comment":{"href":"https://api.github.com/repos/MyOnlineStore/bricks/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/MyOnlineStore/bricks/pulls/78/commits"},"statuses":{"href":"https://api.github.com/repos/MyOnlineStore/bricks/statuses/da1040c6b1c47ba23181708166b617e4f0b08720"}},"author_association":"COLLABORATOR"}} | {
"id": 125216905,
"name": "MyOnlineStore/bricks",
"url": "https://api.github.com/repos/MyOnlineStore/bricks"
} | {
"id": 6347900,
"login": "CarloPalinckx",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6347900?",
"url": "https://api.github.com/users/CarloPalinckx"
} | {
"id": 5500273,
"login": "MyOnlineStore",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5500273?",
"url": "https://api.github.com/orgs/MyOnlineStore"
} | 2018-06-08T09:44:00 | 7795993641 | {"actor":{"display_login":"CarloPalinckx"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/pulls/comments/197263083","pull_request_review_id":130974923,"id":197263083,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NzI2MzA4Mw==","diff_hunk":"@@ -0,0 +1,53 @@\n+import React, { Component, Fragment } from \"react\";\n+import PropTypes from \"prop-types\";\n+import styled from \"styled-components\";\n+import { applyTheme } from \"../../../utils\";\n+\n+const EmptyButton = styled.div`\n+ display: flex;\n+ justify-content: center;\n+`;\n+\n+const EmptyMessage = styled.div`\n+ color: ${applyTheme(\"color_coolGrey500\")};\n+ display: flex;\n+ font-size: ${applyTheme(\"cartEmptyMessageFontSize\")};\n+ justify-content: center;\n+ letter-spacing: ${applyTheme(\"cartEmptyMessageLetterSpacing\")};\n+ margin-bottom: ${applyTheme(\"cartEmptyMessageMarginBottom\")};\n+`;\n+\n+class CartEmptyMessage extends Component {\n+ static propTypes = {\n+ /**\n+ * On object of component children to pass into this component\n+ */\n+ components: PropTypes.shape({\n+ ContinueShoppingButton: PropTypes.oneOfType([PropTypes.string, PropTypes.func])\n+ }),\n+ /**\n+ * Onclick function to pass to the Button component. Not handled internally, directly passed\n+ */\n+ onClick: PropTypes.func\n+ }\n+\n+ static defaultProps = {\n+ onClick() {}\n+ };\n+\n+ render() {\n+ const { onClick } = this.props;\n+ const { ContinueShoppingButton } = this.props.components;\n+\n+ return (\n+ <Fragment>\n+ <EmptyMessage>Your shopping cart is empty.</EmptyMessage>\n+ <EmptyButton>\n+ <ContinueShoppingButton className=\"emptyCartBtn\" actionType=\"important\" onClick={onClick}>Continue shopping</ContinueShoppingButton>","path":"package/src/components/CartEmptyMessage/v1/CartEmptyMessage.js","position":46,"original_position":46,"commit_id":"6ad8895ad3152b4cae820e5983ecde46047084f5","original_commit_id":"6ad8895ad3152b4cae820e5983ecde46047084f5","user":{"login":"willopez","id":486340,"node_id":"MDQ6VXNlcjQ4NjM0MA==","avatar_url":"https://avatars1.githubusercontent.com/u/486340?v=4","gravatar_id":"","url":"https://api.github.com/users/willopez","html_url":"https://github.com/willopez","followers_url":"https://api.github.com/users/willopez/followers","following_url":"https://api.github.com/users/willopez/following{/other_user}","gists_url":"https://api.github.com/users/willopez/gists{/gist_id}","starred_url":"https://api.github.com/users/willopez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/willopez/subscriptions","organizations_url":"https://api.github.com/users/willopez/orgs","repos_url":"https://api.github.com/users/willopez/repos","events_url":"https://api.github.com/users/willopez/events{/privacy}","received_events_url":"https://api.github.com/users/willopez/received_events","type":"User","site_admin":false},"body":"The button text should be a prop, and default it to \"Continue shopping\"","created_at":"2018-06-21T20:15:29Z","updated_at":"2018-06-21T20:24:33Z","html_url":"https://github.com/reactioncommerce/reaction-component-library/pull/90#discussion_r197263083","pull_request_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/pulls/90","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/reactioncommerce/reaction-component-library/pulls/comments/197263083"},"html":{"href":"https://github.com/reactioncommerce/reaction-component-library/pull/90#discussion_r197263083"},"pull_request":{"href":"https://api.github.com/repos/reactioncommerce/reaction-component-library/pulls/90"}}},"pull_request":{"url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/pulls/90","id":196228681,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk2MjI4Njgx","html_url":"https://github.com/reactioncommerce/reaction-component-library/pull/90","diff_url":"https://github.com/reactioncommerce/reaction-component-library/pull/90.diff","patch_url":"https://github.com/reactioncommerce/reaction-component-library/pull/90.patch","issue_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/issues/90","number":90,"state":"open","locked":false,"title":"feat: Cart Empty Message component","user":{"login":"kieckhafer","id":4482263,"node_id":"MDQ6VXNlcjQ0ODIyNjM=","avatar_url":"https://avatars2.githubusercontent.com/u/4482263?v=4","gravatar_id":"","url":"https://api.github.com/users/kieckhafer","html_url":"https://github.com/kieckhafer","followers_url":"https://api.github.com/users/kieckhafer/followers","following_url":"https://api.github.com/users/kieckhafer/following{/other_user}","gists_url":"https://api.github.com/users/kieckhafer/gists{/gist_id}","starred_url":"https://api.github.com/users/kieckhafer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kieckhafer/subscriptions","organizations_url":"https://api.github.com/users/kieckhafer/orgs","repos_url":"https://api.github.com/users/kieckhafer/repos","events_url":"https://api.github.com/users/kieckhafer/events{/privacy}","received_events_url":"https://api.github.com/users/kieckhafer/received_events","type":"User","site_admin":false},"body":"This PR adds a `CartEmptyMessage` component.\r\n\r\nIt will render a Cart Empty message, with a button to `Continue Shopping`, when a user is viewing their cart with nothing in it.\r\n\r\nIssue in the starterkit: https://github.com/reactioncommerce/reaction-next-starterkit/issues/138","created_at":"2018-06-20T18:08:39Z","updated_at":"2018-06-21T20:24:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3c6f41b5b39975cd41af36f3f9674f82c0c29a53","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/pulls/90/commits","review_comments_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/pulls/90/comments","review_comment_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/pulls/comments{/number}","comments_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/issues/90/comments","statuses_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/statuses/6ad8895ad3152b4cae820e5983ecde46047084f5","head":{"label":"reactioncommerce:feat-138-cartEmptyMessage","ref":"feat-138-cartEmptyMessage","sha":"6ad8895ad3152b4cae820e5983ecde46047084f5","user":{"login":"reactioncommerce","id":5605462,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2MDU0NjI=","avatar_url":"https://avatars0.githubusercontent.com/u/5605462?v=4","gravatar_id":"","url":"https://api.github.com/users/reactioncommerce","html_url":"https://github.com/reactioncommerce","followers_url":"https://api.github.com/users/reactioncommerce/followers","following_url":"https://api.github.com/users/reactioncommerce/following{/other_user}","gists_url":"https://api.github.com/users/reactioncommerce/gists{/gist_id}","starred_url":"https://api.github.com/users/reactioncommerce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reactioncommerce/subscriptions","organizations_url":"https://api.github.com/users/reactioncommerce/orgs","repos_url":"https://api.github.com/users/reactioncommerce/repos","events_url":"https://api.github.com/users/reactioncommerce/events{/privacy}","received_events_url":"https://api.github.com/users/reactioncommerce/received_events","type":"Organization","site_admin":false},"repo":{"id":114694142,"node_id":"MDEwOlJlcG9zaXRvcnkxMTQ2OTQxNDI=","name":"reaction-component-library","full_name":"reactioncommerce/reaction-component-library","owner":{"login":"reactioncommerce","id":5605462,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2MDU0NjI=","avatar_url":"https://avatars0.githubusercontent.com/u/5605462?v=4","gravatar_id":"","url":"https://api.github.com/users/reactioncommerce","html_url":"https://github.com/reactioncommerce","followers_url":"https://api.github.com/users/reactioncommerce/followers","following_url":"https://api.github.com/users/reactioncommerce/following{/other_user}","gists_url":"https://api.github.com/users/reactioncommerce/gists{/gist_id}","starred_url":"https://api.github.com/users/reactioncommerce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reactioncommerce/subscriptions","organizations_url":"https://api.github.com/users/reactioncommerce/orgs","repos_url":"https://api.github.com/users/reactioncommerce/repos","events_url":"https://api.github.com/users/reactioncommerce/events{/privacy}","received_events_url":"https://api.github.com/users/reactioncommerce/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/reactioncommerce/reaction-component-library","description":"An ecommerce-focused set of React components","fork":false,"url":"https://api.github.com/repos/reactioncommerce/reaction-component-library","forks_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/forks","keys_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/keys{/key_id}","collaborators_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/teams","hooks_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/hooks","issue_events_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/issues/events{/number}","events_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/events","assignees_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/assignees{/user}","branches_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/branches{/branch}","tags_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/tags","blobs_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/git/refs{/sha}","trees_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/git/trees{/sha}","statuses_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/statuses/{sha}","languages_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/languages","stargazers_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/stargazers","contributors_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/contributors","subscribers_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/subscribers","subscription_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/subscription","commits_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/commits{/sha}","git_commits_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/git/commits{/sha}","comments_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/comments{/number}","issue_comment_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/issues/comments{/number}","contents_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/contents/{+path}","compare_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/compare/{base}...{head}","merges_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/merges","archive_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/downloads","issues_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/issues{/number}","pulls_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/pulls{/number}","milestones_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/milestones{/number}","notifications_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/labels{/name}","releases_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/releases{/id}","deployments_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/deployments","created_at":"2017-12-18T22:31:00Z","updated_at":"2018-06-20T22:57:05Z","pushed_at":"2018-06-21T20:23:35Z","git_url":"git://github.com/reactioncommerce/reaction-component-library.git","ssh_url":"[email protected]:reactioncommerce/reaction-component-library.git","clone_url":"https://github.com/reactioncommerce/reaction-component-library.git","svn_url":"https://github.com/reactioncommerce/reaction-component-library","homepage":"","size":2940,"stargazers_count":9,"watchers_count":9,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":62,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":62,"watchers":9,"default_branch":"master"}},"base":{"label":"reactioncommerce:master","ref":"master","sha":"33143fcda3eb690fd5481dfb8a395f1469cae9d4","user":{"login":"reactioncommerce","id":5605462,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2MDU0NjI=","avatar_url":"https://avatars0.githubusercontent.com/u/5605462?v=4","gravatar_id":"","url":"https://api.github.com/users/reactioncommerce","html_url":"https://github.com/reactioncommerce","followers_url":"https://api.github.com/users/reactioncommerce/followers","following_url":"https://api.github.com/users/reactioncommerce/following{/other_user}","gists_url":"https://api.github.com/users/reactioncommerce/gists{/gist_id}","starred_url":"https://api.github.com/users/reactioncommerce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reactioncommerce/subscriptions","organizations_url":"https://api.github.com/users/reactioncommerce/orgs","repos_url":"https://api.github.com/users/reactioncommerce/repos","events_url":"https://api.github.com/users/reactioncommerce/events{/privacy}","received_events_url":"https://api.github.com/users/reactioncommerce/received_events","type":"Organization","site_admin":false},"repo":{"id":114694142,"node_id":"MDEwOlJlcG9zaXRvcnkxMTQ2OTQxNDI=","name":"reaction-component-library","full_name":"reactioncommerce/reaction-component-library","owner":{"login":"reactioncommerce","id":5605462,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2MDU0NjI=","avatar_url":"https://avatars0.githubusercontent.com/u/5605462?v=4","gravatar_id":"","url":"https://api.github.com/users/reactioncommerce","html_url":"https://github.com/reactioncommerce","followers_url":"https://api.github.com/users/reactioncommerce/followers","following_url":"https://api.github.com/users/reactioncommerce/following{/other_user}","gists_url":"https://api.github.com/users/reactioncommerce/gists{/gist_id}","starred_url":"https://api.github.com/users/reactioncommerce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reactioncommerce/subscriptions","organizations_url":"https://api.github.com/users/reactioncommerce/orgs","repos_url":"https://api.github.com/users/reactioncommerce/repos","events_url":"https://api.github.com/users/reactioncommerce/events{/privacy}","received_events_url":"https://api.github.com/users/reactioncommerce/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/reactioncommerce/reaction-component-library","description":"An ecommerce-focused set of React components","fork":false,"url":"https://api.github.com/repos/reactioncommerce/reaction-component-library","forks_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/forks","keys_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/keys{/key_id}","collaborators_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/teams","hooks_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/hooks","issue_events_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/issues/events{/number}","events_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/events","assignees_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/assignees{/user}","branches_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/branches{/branch}","tags_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/tags","blobs_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/git/refs{/sha}","trees_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/git/trees{/sha}","statuses_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/statuses/{sha}","languages_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/languages","stargazers_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/stargazers","contributors_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/contributors","subscribers_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/subscribers","subscription_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/subscription","commits_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/commits{/sha}","git_commits_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/git/commits{/sha}","comments_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/comments{/number}","issue_comment_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/issues/comments{/number}","contents_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/contents/{+path}","compare_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/compare/{base}...{head}","merges_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/merges","archive_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/downloads","issues_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/issues{/number}","pulls_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/pulls{/number}","milestones_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/milestones{/number}","notifications_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/labels{/name}","releases_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/releases{/id}","deployments_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/deployments","created_at":"2017-12-18T22:31:00Z","updated_at":"2018-06-20T22:57:05Z","pushed_at":"2018-06-21T20:23:35Z","git_url":"git://github.com/reactioncommerce/reaction-component-library.git","ssh_url":"[email protected]:reactioncommerce/reaction-component-library.git","clone_url":"https://github.com/reactioncommerce/reaction-component-library.git","svn_url":"https://github.com/reactioncommerce/reaction-component-library","homepage":"","size":2940,"stargazers_count":9,"watchers_count":9,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":62,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":62,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/reactioncommerce/reaction-component-library/pulls/90"},"html":{"href":"https://github.com/reactioncommerce/reaction-component-library/pull/90"},"issue":{"href":"https://api.github.com/repos/reactioncommerce/reaction-component-library/issues/90"},"comments":{"href":"https://api.github.com/repos/reactioncommerce/reaction-component-library/issues/90/comments"},"review_comments":{"href":"https://api.github.com/repos/reactioncommerce/reaction-component-library/pulls/90/comments"},"review_comment":{"href":"https://api.github.com/repos/reactioncommerce/reaction-component-library/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/reactioncommerce/reaction-component-library/pulls/90/commits"},"statuses":{"href":"https://api.github.com/repos/reactioncommerce/reaction-component-library/statuses/6ad8895ad3152b4cae820e5983ecde46047084f5"}},"author_association":"MEMBER"}} | {
"id": 114694142,
"name": "reactioncommerce/reaction-component-library",
"url": "https://api.github.com/repos/reactioncommerce/reaction-component-library"
} | {
"id": 486340,
"login": "willopez",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/486340?",
"url": "https://api.github.com/users/willopez"
} | {
"id": 5605462,
"login": "reactioncommerce",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5605462?",
"url": "https://api.github.com/orgs/reactioncommerce"
} | 2018-06-21T20:15:29 | 7860560782 | {"actor":{"display_login":"willopez"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/Lightmatter/Maco/pulls/comments/224294292","pull_request_review_id":163622671,"id":224294292,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNDI5NDI5Mg==","diff_hunk":"@@ -0,0 +1,100 @@\n+from collections import defaultdict\n+from django.conf import settings\n+from django.contrib import messages\n+from django.shortcuts import get_object_or_404, redirect\n+from django.urls import reverse\n+from django.utils.http import is_safe_url\n+\n+from oscar.apps.wishlists.models import Line\n+\n+from Maco.accounts.functions import make_default_wishlist # NOQA\n+\n+from .constants import (DECREASE_EXISTING_LINE_MESSAGE,\n+ INVALID_PRODUCT_MESSAGE, INVALID_QUANTITY_MESSAGE)\n+from .models import Product, ProductAttributeValue\n+\n+\n+def get_product_attributes_dict(product):\n+ attribute_dict = defaultdict(set)\n+ if product:\n+ if product.is_child:\n+ product = product.parent\n+ attributes = ProductAttributeValue.objects.filter(product__in=product.children.all())\n+ for attribute in attributes:\n+ attribute_dict[attribute.attribute.name].add(attribute.value)\n+ return attribute_dict\n+\n+\n+def process_add_product_to_wishlist(request): # NOQA\n+ wishlist = request.user.wishlists.first()\n+ product_id = request.POST.get('id', None)\n+ quantity = request.POST.get('quantity', None)\n+ if not wishlist:\n+ make_default_wishlist(request.user)\n+ product = get_object_or_404(Product, id=product_id)\n+ try:\n+ quantity = int(quantity)\n+ except ValueError:\n+ messages.error(request, INVALID_QUANTITY_MESSAGE)\n+ return redirect(reverse('catalogue:detail', kwargs={'product_slug': product.slug, 'pk': product.pk}))\n+ if not quantity:\n+ messages.error(request, INVALID_QUANTITY_MESSAGE)\n+ return redirect(reverse('catalogue:detail', kwargs={'product_slug': product.slug, 'pk': product.pk}))\n+ line, created = Line.objects.get_or_create(product=product, wishlist=wishlist)\n+ if created:\n+ line.quantity = quantity\n+ line.save()\n+ else:\n+ if quantity < line.quantity:\n+ messages.error(request, DECREASE_EXISTING_LINE_MESSAGE)\n+ else:\n+ line.quantity = quantity\n+ line.save()\n+ return redirect(reverse('catalogue:detail', kwargs={'product_slug': product.slug, 'pk': product.pk}))\n+\n+\n+def fetch_product_id_by_attribute_values(product, query_args):\n+ possible_ids = []\n+ for arg in query_args:\n+ ids_set = set()\n+ attribute_values = ProductAttributeValue.objects.filter(attribute__name=arg, product__in=product.children.all())\n+ for attribute_value in attribute_values:\n+ if str(attribute_value.value) == query_args[arg]:\n+ ids_set.add(attribute_value.product_id)\n+ possible_ids.append(ids_set)\n+ id_intersect = set.intersection(*possible_ids)\n+ if id_intersect and len(id_intersect) == 1:\n+ return id_intersect.pop()\n+ return None\n+\n+\n+def process_redirect_to_product_from_id_attributes(request): # NOQA\n+ query = request.GET.dict()\n+ product_id = query.pop('product_id', None)\n+ return_url = query.pop('return_url', '/')\n+ try:\n+ product_id = int(product_id)\n+ except ValueError:","path":"Maco/catalogue/functions.py","position":77,"original_position":77,"commit_id":"0437f27e54c3d1fbf487732b0a4ef4669f7ad407","original_commit_id":"0437f27e54c3d1fbf487732b0a4ef4669f7ad407","user":{"login":"gone","id":120373,"node_id":"MDQ6VXNlcjEyMDM3Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/120373?v=4","gravatar_id":"","url":"https://api.github.com/users/gone","html_url":"https://github.com/gone","followers_url":"https://api.github.com/users/gone/followers","following_url":"https://api.github.com/users/gone/following{/other_user}","gists_url":"https://api.github.com/users/gone/gists{/gist_id}","starred_url":"https://api.github.com/users/gone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gone/subscriptions","organizations_url":"https://api.github.com/users/gone/orgs","repos_url":"https://api.github.com/users/gone/repos","events_url":"https://api.github.com/users/gone/events{/privacy}","received_events_url":"https://api.github.com/users/gone/received_events","type":"User","site_admin":false},"body":"Would def move this to form validation logic","created_at":"2018-10-11T02:04:34Z","updated_at":"2018-10-11T02:32:17Z","html_url":"https://github.com/Lightmatter/Maco/pull/18#discussion_r224294292","pull_request_url":"https://api.github.com/repos/Lightmatter/Maco/pulls/18","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Lightmatter/Maco/pulls/comments/224294292"},"html":{"href":"https://github.com/Lightmatter/Maco/pull/18#discussion_r224294292"},"pull_request":{"href":"https://api.github.com/repos/Lightmatter/Maco/pulls/18"}}},"pull_request":{"url":"https://api.github.com/repos/Lightmatter/Maco/pulls/18","id":220828064,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwODI4MDY0","html_url":"https://github.com/Lightmatter/Maco/pull/18","diff_url":"https://github.com/Lightmatter/Maco/pull/18.diff","patch_url":"https://github.com/Lightmatter/Maco/pull/18.patch","issue_url":"https://api.github.com/repos/Lightmatter/Maco/issues/18","number":18,"state":"open","locked":false,"title":"first structural pass as product detail page, still needs redirect lo…","user":{"login":"jake-kent","id":11411119,"node_id":"MDQ6VXNlcjExNDExMTE5","avatar_url":"https://avatars0.githubusercontent.com/u/11411119?v=4","gravatar_id":"","url":"https://api.github.com/users/jake-kent","html_url":"https://github.com/jake-kent","followers_url":"https://api.github.com/users/jake-kent/followers","following_url":"https://api.github.com/users/jake-kent/following{/other_user}","gists_url":"https://api.github.com/users/jake-kent/gists{/gist_id}","starred_url":"https://api.github.com/users/jake-kent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jake-kent/subscriptions","organizations_url":"https://api.github.com/users/jake-kent/orgs","repos_url":"https://api.github.com/users/jake-kent/repos","events_url":"https://api.github.com/users/jake-kent/events{/privacy}","received_events_url":"https://api.github.com/users/jake-kent/received_events","type":"User","site_admin":false},"body":"…gic and form handling","created_at":"2018-10-05T21:23:25Z","updated_at":"2018-10-11T02:32:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"160922e1813b1e2902b7a86bd2c81154d125f7b5","assignee":{"login":"gone","id":120373,"node_id":"MDQ6VXNlcjEyMDM3Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/120373?v=4","gravatar_id":"","url":"https://api.github.com/users/gone","html_url":"https://github.com/gone","followers_url":"https://api.github.com/users/gone/followers","following_url":"https://api.github.com/users/gone/following{/other_user}","gists_url":"https://api.github.com/users/gone/gists{/gist_id}","starred_url":"https://api.github.com/users/gone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gone/subscriptions","organizations_url":"https://api.github.com/users/gone/orgs","repos_url":"https://api.github.com/users/gone/repos","events_url":"https://api.github.com/users/gone/events{/privacy}","received_events_url":"https://api.github.com/users/gone/received_events","type":"User","site_admin":false},"assignees":[{"login":"gone","id":120373,"node_id":"MDQ6VXNlcjEyMDM3Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/120373?v=4","gravatar_id":"","url":"https://api.github.com/users/gone","html_url":"https://github.com/gone","followers_url":"https://api.github.com/users/gone/followers","following_url":"https://api.github.com/users/gone/following{/other_user}","gists_url":"https://api.github.com/users/gone/gists{/gist_id}","starred_url":"https://api.github.com/users/gone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gone/subscriptions","organizations_url":"https://api.github.com/users/gone/orgs","repos_url":"https://api.github.com/users/gone/repos","events_url":"https://api.github.com/users/gone/events{/privacy}","received_events_url":"https://api.github.com/users/gone/received_events","type":"User","site_admin":false},{"login":"jake-kent","id":11411119,"node_id":"MDQ6VXNlcjExNDExMTE5","avatar_url":"https://avatars0.githubusercontent.com/u/11411119?v=4","gravatar_id":"","url":"https://api.github.com/users/jake-kent","html_url":"https://github.com/jake-kent","followers_url":"https://api.github.com/users/jake-kent/followers","following_url":"https://api.github.com/users/jake-kent/following{/other_user}","gists_url":"https://api.github.com/users/jake-kent/gists{/gist_id}","starred_url":"https://api.github.com/users/jake-kent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jake-kent/subscriptions","organizations_url":"https://api.github.com/users/jake-kent/orgs","repos_url":"https://api.github.com/users/jake-kent/repos","events_url":"https://api.github.com/users/jake-kent/events{/privacy}","received_events_url":"https://api.github.com/users/jake-kent/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Lightmatter/Maco/pulls/18/commits","review_comments_url":"https://api.github.com/repos/Lightmatter/Maco/pulls/18/comments","review_comment_url":"https://api.github.com/repos/Lightmatter/Maco/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Lightmatter/Maco/issues/18/comments","statuses_url":"https://api.github.com/repos/Lightmatter/Maco/statuses/0437f27e54c3d1fbf487732b0a4ef4669f7ad407","head":{"label":"Lightmatter:feature/product_detail_page","ref":"feature/product_detail_page","sha":"0437f27e54c3d1fbf487732b0a4ef4669f7ad407","user":{"login":"Lightmatter","id":5615257,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2MTUyNTc=","avatar_url":"https://avatars3.githubusercontent.com/u/5615257?v=4","gravatar_id":"","url":"https://api.github.com/users/Lightmatter","html_url":"https://github.com/Lightmatter","followers_url":"https://api.github.com/users/Lightmatter/followers","following_url":"https://api.github.com/users/Lightmatter/following{/other_user}","gists_url":"https://api.github.com/users/Lightmatter/gists{/gist_id}","starred_url":"https://api.github.com/users/Lightmatter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lightmatter/subscriptions","organizations_url":"https://api.github.com/users/Lightmatter/orgs","repos_url":"https://api.github.com/users/Lightmatter/repos","events_url":"https://api.github.com/users/Lightmatter/events{/privacy}","received_events_url":"https://api.github.com/users/Lightmatter/received_events","type":"Organization","site_admin":false},"repo":{"id":146802586,"node_id":"MDEwOlJlcG9zaXRvcnkxNDY4MDI1ODY=","name":"Maco","full_name":"Lightmatter/Maco","private":false,"owner":{"login":"Lightmatter","id":5615257,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2MTUyNTc=","avatar_url":"https://avatars3.githubusercontent.com/u/5615257?v=4","gravatar_id":"","url":"https://api.github.com/users/Lightmatter","html_url":"https://github.com/Lightmatter","followers_url":"https://api.github.com/users/Lightmatter/followers","following_url":"https://api.github.com/users/Lightmatter/following{/other_user}","gists_url":"https://api.github.com/users/Lightmatter/gists{/gist_id}","starred_url":"https://api.github.com/users/Lightmatter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lightmatter/subscriptions","organizations_url":"https://api.github.com/users/Lightmatter/orgs","repos_url":"https://api.github.com/users/Lightmatter/repos","events_url":"https://api.github.com/users/Lightmatter/events{/privacy}","received_events_url":"https://api.github.com/users/Lightmatter/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Lightmatter/Maco","description":"Website for Maco","fork":false,"url":"https://api.github.com/repos/Lightmatter/Maco","forks_url":"https://api.github.com/repos/Lightmatter/Maco/forks","keys_url":"https://api.github.com/repos/Lightmatter/Maco/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Lightmatter/Maco/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Lightmatter/Maco/teams","hooks_url":"https://api.github.com/repos/Lightmatter/Maco/hooks","issue_events_url":"https://api.github.com/repos/Lightmatter/Maco/issues/events{/number}","events_url":"https://api.github.com/repos/Lightmatter/Maco/events","assignees_url":"https://api.github.com/repos/Lightmatter/Maco/assignees{/user}","branches_url":"https://api.github.com/repos/Lightmatter/Maco/branches{/branch}","tags_url":"https://api.github.com/repos/Lightmatter/Maco/tags","blobs_url":"https://api.github.com/repos/Lightmatter/Maco/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Lightmatter/Maco/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Lightmatter/Maco/git/refs{/sha}","trees_url":"https://api.github.com/repos/Lightmatter/Maco/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Lightmatter/Maco/statuses/{sha}","languages_url":"https://api.github.com/repos/Lightmatter/Maco/languages","stargazers_url":"https://api.github.com/repos/Lightmatter/Maco/stargazers","contributors_url":"https://api.github.com/repos/Lightmatter/Maco/contributors","subscribers_url":"https://api.github.com/repos/Lightmatter/Maco/subscribers","subscription_url":"https://api.github.com/repos/Lightmatter/Maco/subscription","commits_url":"https://api.github.com/repos/Lightmatter/Maco/commits{/sha}","git_commits_url":"https://api.github.com/repos/Lightmatter/Maco/git/commits{/sha}","comments_url":"https://api.github.com/repos/Lightmatter/Maco/comments{/number}","issue_comment_url":"https://api.github.com/repos/Lightmatter/Maco/issues/comments{/number}","contents_url":"https://api.github.com/repos/Lightmatter/Maco/contents/{+path}","compare_url":"https://api.github.com/repos/Lightmatter/Maco/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Lightmatter/Maco/merges","archive_url":"https://api.github.com/repos/Lightmatter/Maco/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Lightmatter/Maco/downloads","issues_url":"https://api.github.com/repos/Lightmatter/Maco/issues{/number}","pulls_url":"https://api.github.com/repos/Lightmatter/Maco/pulls{/number}","milestones_url":"https://api.github.com/repos/Lightmatter/Maco/milestones{/number}","notifications_url":"https://api.github.com/repos/Lightmatter/Maco/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Lightmatter/Maco/labels{/name}","releases_url":"https://api.github.com/repos/Lightmatter/Maco/releases{/id}","deployments_url":"https://api.github.com/repos/Lightmatter/Maco/deployments","created_at":"2018-08-30T20:22:13Z","updated_at":"2018-10-10T21:19:38Z","pushed_at":"2018-10-10T22:00:50Z","git_url":"git://github.com/Lightmatter/Maco.git","ssh_url":"[email protected]:Lightmatter/Maco.git","clone_url":"https://github.com/Lightmatter/Maco.git","svn_url":"https://github.com/Lightmatter/Maco","homepage":"https://maco-prod.herokuapp.com","size":29819,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":7,"license":null,"forks":0,"open_issues":7,"watchers":0,"default_branch":"develop"}},"base":{"label":"Lightmatter:develop","ref":"develop","sha":"59cc849cf939bebd87704e5b9dad876d0e35d989","user":{"login":"Lightmatter","id":5615257,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2MTUyNTc=","avatar_url":"https://avatars3.githubusercontent.com/u/5615257?v=4","gravatar_id":"","url":"https://api.github.com/users/Lightmatter","html_url":"https://github.com/Lightmatter","followers_url":"https://api.github.com/users/Lightmatter/followers","following_url":"https://api.github.com/users/Lightmatter/following{/other_user}","gists_url":"https://api.github.com/users/Lightmatter/gists{/gist_id}","starred_url":"https://api.github.com/users/Lightmatter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lightmatter/subscriptions","organizations_url":"https://api.github.com/users/Lightmatter/orgs","repos_url":"https://api.github.com/users/Lightmatter/repos","events_url":"https://api.github.com/users/Lightmatter/events{/privacy}","received_events_url":"https://api.github.com/users/Lightmatter/received_events","type":"Organization","site_admin":false},"repo":{"id":146802586,"node_id":"MDEwOlJlcG9zaXRvcnkxNDY4MDI1ODY=","name":"Maco","full_name":"Lightmatter/Maco","private":false,"owner":{"login":"Lightmatter","id":5615257,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2MTUyNTc=","avatar_url":"https://avatars3.githubusercontent.com/u/5615257?v=4","gravatar_id":"","url":"https://api.github.com/users/Lightmatter","html_url":"https://github.com/Lightmatter","followers_url":"https://api.github.com/users/Lightmatter/followers","following_url":"https://api.github.com/users/Lightmatter/following{/other_user}","gists_url":"https://api.github.com/users/Lightmatter/gists{/gist_id}","starred_url":"https://api.github.com/users/Lightmatter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lightmatter/subscriptions","organizations_url":"https://api.github.com/users/Lightmatter/orgs","repos_url":"https://api.github.com/users/Lightmatter/repos","events_url":"https://api.github.com/users/Lightmatter/events{/privacy}","received_events_url":"https://api.github.com/users/Lightmatter/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Lightmatter/Maco","description":"Website for Maco","fork":false,"url":"https://api.github.com/repos/Lightmatter/Maco","forks_url":"https://api.github.com/repos/Lightmatter/Maco/forks","keys_url":"https://api.github.com/repos/Lightmatter/Maco/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Lightmatter/Maco/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Lightmatter/Maco/teams","hooks_url":"https://api.github.com/repos/Lightmatter/Maco/hooks","issue_events_url":"https://api.github.com/repos/Lightmatter/Maco/issues/events{/number}","events_url":"https://api.github.com/repos/Lightmatter/Maco/events","assignees_url":"https://api.github.com/repos/Lightmatter/Maco/assignees{/user}","branches_url":"https://api.github.com/repos/Lightmatter/Maco/branches{/branch}","tags_url":"https://api.github.com/repos/Lightmatter/Maco/tags","blobs_url":"https://api.github.com/repos/Lightmatter/Maco/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Lightmatter/Maco/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Lightmatter/Maco/git/refs{/sha}","trees_url":"https://api.github.com/repos/Lightmatter/Maco/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Lightmatter/Maco/statuses/{sha}","languages_url":"https://api.github.com/repos/Lightmatter/Maco/languages","stargazers_url":"https://api.github.com/repos/Lightmatter/Maco/stargazers","contributors_url":"https://api.github.com/repos/Lightmatter/Maco/contributors","subscribers_url":"https://api.github.com/repos/Lightmatter/Maco/subscribers","subscription_url":"https://api.github.com/repos/Lightmatter/Maco/subscription","commits_url":"https://api.github.com/repos/Lightmatter/Maco/commits{/sha}","git_commits_url":"https://api.github.com/repos/Lightmatter/Maco/git/commits{/sha}","comments_url":"https://api.github.com/repos/Lightmatter/Maco/comments{/number}","issue_comment_url":"https://api.github.com/repos/Lightmatter/Maco/issues/comments{/number}","contents_url":"https://api.github.com/repos/Lightmatter/Maco/contents/{+path}","compare_url":"https://api.github.com/repos/Lightmatter/Maco/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Lightmatter/Maco/merges","archive_url":"https://api.github.com/repos/Lightmatter/Maco/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Lightmatter/Maco/downloads","issues_url":"https://api.github.com/repos/Lightmatter/Maco/issues{/number}","pulls_url":"https://api.github.com/repos/Lightmatter/Maco/pulls{/number}","milestones_url":"https://api.github.com/repos/Lightmatter/Maco/milestones{/number}","notifications_url":"https://api.github.com/repos/Lightmatter/Maco/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Lightmatter/Maco/labels{/name}","releases_url":"https://api.github.com/repos/Lightmatter/Maco/releases{/id}","deployments_url":"https://api.github.com/repos/Lightmatter/Maco/deployments","created_at":"2018-08-30T20:22:13Z","updated_at":"2018-10-10T21:19:38Z","pushed_at":"2018-10-10T22:00:50Z","git_url":"git://github.com/Lightmatter/Maco.git","ssh_url":"[email protected]:Lightmatter/Maco.git","clone_url":"https://github.com/Lightmatter/Maco.git","svn_url":"https://github.com/Lightmatter/Maco","homepage":"https://maco-prod.herokuapp.com","size":29819,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":7,"license":null,"forks":0,"open_issues":7,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/Lightmatter/Maco/pulls/18"},"html":{"href":"https://github.com/Lightmatter/Maco/pull/18"},"issue":{"href":"https://api.github.com/repos/Lightmatter/Maco/issues/18"},"comments":{"href":"https://api.github.com/repos/Lightmatter/Maco/issues/18/comments"},"review_comments":{"href":"https://api.github.com/repos/Lightmatter/Maco/pulls/18/comments"},"review_comment":{"href":"https://api.github.com/repos/Lightmatter/Maco/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Lightmatter/Maco/pulls/18/commits"},"statuses":{"href":"https://api.github.com/repos/Lightmatter/Maco/statuses/0437f27e54c3d1fbf487732b0a4ef4669f7ad407"}},"author_association":"MEMBER"}} | {
"id": 146802586,
"name": "Lightmatter/Maco",
"url": "https://api.github.com/repos/Lightmatter/Maco"
} | {
"id": 120373,
"login": "gone",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/120373?",
"url": "https://api.github.com/users/gone"
} | {
"id": 5615257,
"login": "Lightmatter",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5615257?",
"url": "https://api.github.com/orgs/Lightmatter"
} | 2018-10-11T02:04:34 | 8401705113 | {"actor":{"display_login":"gone"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/workato/connector_sdk/pulls/comments/198386353","pull_request_review_id":132307020,"id":198386353,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5ODM4NjM1Mw==","diff_hunk":"@@ -0,0 +1,297 @@\n+{\n+ title: \"Google Calendar\",\n+\n+ connection: {\n+ fields: [\n+ {\n+ name: \"client_id\",\n+ hint: \"Find client ID \" \\\n+ \"<a href='https://console.cloud.google.com/apis/credentials' \" \\\n+ \"target='_blank'>here</a>\",\n+ optional: false\n+ },\n+ {\n+ name: \"client_secret\",\n+ hint: \"Find client secret \" \\\n+ \"<a href='https://console.cloud.google.com/apis/credentials' \" \\\n+ \"target='_blank'>here</a>\",\n+ optional: false,\n+ control_type: \"password\"\n+ }\n+ ],\n+\n+ authorization: {\n+ type: \"oauth2\",\n+\n+ authorization_url: lambda do |connection|\n+ scopes = [\n+ \"https://www.googleapis.com/auth/calendar\",\n+ \"https://www.googleapis.com/auth/calendar.readonly\"\n+ ].join(\" \")\n+ \"https://accounts.google.com/o/oauth2/auth?client_id=\" \\\n+ \"#{connection['client_id']}&response_type=code&scope=#{scopes}\" \\\n+ \"&access_type=offline&include_granted_scopes=true&prompt=consent\"\n+ end,\n+\n+ acquire: lambda do |connection, auth_code, redirect_uri|\n+ response = post(\"https://accounts.google.com/o/oauth2/token\").\n+ payload(client_id: connection[\"client_id\"],\n+ client_secret: connection[\"client_secret\"],\n+ grant_type: \"authorization_code\",\n+ code: auth_code,\n+ redirect_uri: redirect_uri).\n+ request_format_www_form_urlencoded\n+\n+ [response, nil, nil]\n+ end,\n+\n+ refresh: lambda do |connection, refresh_token|\n+ post(\"https://accounts.google.com/o/oauth2/token\").\n+ payload(client_id: connection[\"client_id\"],\n+ client_secret: connection[\"client_secret\"],\n+ grant_type: \"refresh_token\",\n+ refresh_token: refresh_token).\n+ request_format_www_form_urlencoded\n+ end,\n+\n+ refresh_on: [401],\n+\n+ detect_on: [/\"errors\"\\:\\s*\\[/],\n+\n+ apply: lambda do |_connection, access_token|\n+ headers(\"Authorization\" => \"Bearer #{access_token}\")\n+ end,\n+ }\n+\n+ },\n+\n+ object_definitions: {\n+ event: {\n+ fields: lambda do\n+ [\n+ { name: \"id\" },\n+ { name: \"status\" },\n+ { name: \"htmlLink\", type: \"string\", control_type: \"url\" },\n+ { name: \"created\", type: \"date_time\", control_type: \"date_time\" },\n+ { name: \"updated\", type: \"date_time\", control_type: \"date_time\" },\n+ { name: \"summary\" },\n+ { name: \"description\" },\n+ { name: \"location\" },\n+ {\n+ name: \"creator\", type: \"object\", properties: [\n+ { name: \"id\" },\n+ { name: \"email\" },\n+ { name: \"displayName\" },\n+ { name: \"self\", type: \"boolean\" }\n+ ]\n+ },\n+ {\n+ name: \"organizer\", type: \"object\", properties: [\n+ { name: \"id\" },\n+ { name: \"email\" },\n+ { name: \"displayName\" },\n+ { name: \"self\", type: \"boolean\" }\n+ ]\n+ },\n+ {\n+ name: \"start\", type: \"object\", properties: [\n+ { name: \"dateTime\", type: \"date_time\", control_type: \"date_time\" }\n+ ]\n+ },\n+ {\n+ name: \"end\", type: \"object\", properties: [\n+ { name: \"dateTime\", type: \"date_time\", control_type: \"date_time\" }\n+ ]\n+ },\n+ { name: \"endTimeUnspecified\", type: \"boolean\" },\n+ { name: \"recurrence\", type: \"array\", properties: [] },\n+ { name: \"recurringEventId\" },\n+ {\n+ name: \"originalStartTime\", type: \"object\", properties: [\n+ { name: \"dateTime\", type: \"date_time\", control_type: \"date_time\" }\n+ ]\n+ },\n+ {\n+ name: \"attendees\", type: \"array\", of: \"object\", properties: [\n+ { name: \"id\" },\n+ { name: \"email\" },\n+ { name: \"displayName\" },\n+ { name: \"self\", type: \"boolean\" },\n+ { name: \"organizer\", type: \"boolean\" },\n+ { name: \"resource\", type: \"boolean\" },\n+ { name: \"optional\", type: \"boolean\" },\n+ { name: \"responseStatus\" },\n+ { name: \"comment\" },\n+ { name: \"additionalGuests\", type: \"integer\" }\n+ ]\n+ }\n+ ]\n+ end\n+ }\n+ },\n+\n+ test: lambda do |_connection|\n+ get(\"https://www.googleapis.com/calendar/v3/users/me/settings?maxResults=1\")\n+ end,\n+\n+ actions: {\n+ },\n+\n+ triggers: {\n+ calendar_event_ended: {\n+ help: \"Continuously checks for updates when possible.\",\n+ input_fields: lambda do\n+ [\n+ {\n+ name: \"calendarId\",\n+ label: \"Calendar\",\n+ hint: \"Choose a calendar\",\n+ type: \"string\",\n+ control_type: \"select\",\n+ pick_list: \"calendars\",\n+ optional: false,\n+ toggle_hint: \"Select from list\",\n+ toggle_field: {\n+ name: \"calendarId\",\n+ label: \"Calendar ID\",\n+ hint: \"Input ID of calendar to monitor for events\",\n+ type: \"string\",\n+ control_type: \"text\",\n+ toggle_hint: \"Enter custom value\",\n+ optional: false\n+ }\n+ },\n+ {\n+ name: \"timeMin\",\n+ label: \"Starting After\",\n+ type: \"date_time\",\n+ control_type: \"date_time\",\n+ hint: \"Fetch events starting on or after this datetime.\"\\\n+ \"Defaults to recipe start if not entered.\",\n+ optional: true\n+ }\n+ ]\n+ end,\n+\n+ poll: lambda do |_connection, input, next_page|\n+ input[\"timeMin\"] = (input[\"timeMin\"] || Time.now).utc.strftime(\"%FT%TZ\")\n+\n+ page = next_page || nil\n+\n+ if page.present?\n+ response = get(\"https://www.googleapis.com/calendar/v3/calendars/\" \\\n+ \"#{input['calendarId']}/events?singleEvents=true\" \\\n+ \"&orderBy=startTime&pageToken=#{page}&\" \\\n+ \"timeMin=#{input['timeMin']}\")\n+ else\n+ param = input.reject { |k, _v| k == \"calendarId\" }\n+ response = get(\"https://www.googleapis.com/calendar/v3/calendars/\" \\\n+ \"#{input['calendarId']}/events?singleEvents=true&\" \\\n+ \"orderBy=startTime&timeMin=#{input['timeMin']}\")\n+ end\n+\n+ events = []\n+\n+ response[\"items\"].each do |event|\n+ if event[\"end\"].present? &&\n+ event[\"end\"][\"dateTime\"].present? &&\n+ event[\"end\"][\"dateTime\"].to_time <= Time.now\n+ events << event\n+ end\n+ end\n+ {\n+ events: events,\n+ next_page: response[\"nextPageToken\"],\n+ can_poll_more: response[\"nextPageToken\"].present?\n+ }\n+ end,\n+\n+ dedup: lambda do |event|\n+ event[\"id\"] + \"@\" + event[\"end\"][\"dateTime\"]\n+ end,\n+\n+ output_fields: lambda do |object_definitions|\n+ object_definitions[\"event\"]\n+ end\n+ },\n+\n+ cancelled_event: {\n+ help: \"Checks for updates every 5 minutes.\",\n+ description: \"Cancelled <span class=\\\"provider\\\">event</span> in\n+ <span class=\\\"provider\\\">Google Calendar</span>\",\n+ input_fields: lambda do","path":"oauth2/{GoogleCalendarSDK.rb","position":222,"original_position":222,"commit_id":"2e0b7810971943b9ea56427f8b2261069b072fa1","original_commit_id":"2e0b7810971943b9ea56427f8b2261069b072fa1","user":{"login":"houndci-bot","id":6697940,"node_id":"MDQ6VXNlcjY2OTc5NDA=","avatar_url":"https://avatars0.githubusercontent.com/u/6697940?v=4","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"Metrics/BlockLength: Block has too many lines. [30/25]","created_at":"2018-06-27T07:07:11Z","updated_at":"2018-06-27T07:07:12Z","html_url":"https://github.com/workato/connector_sdk/pull/124#discussion_r198386353","pull_request_url":"https://api.github.com/repos/workato/connector_sdk/pulls/124","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/workato/connector_sdk/pulls/comments/198386353"},"html":{"href":"https://github.com/workato/connector_sdk/pull/124#discussion_r198386353"},"pull_request":{"href":"https://api.github.com/repos/workato/connector_sdk/pulls/124"}}},"pull_request":{"url":"https://api.github.com/repos/workato/connector_sdk/pulls/124","id":197372743,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3MzcyNzQz","html_url":"https://github.com/workato/connector_sdk/pull/124","diff_url":"https://github.com/workato/connector_sdk/pull/124.diff","patch_url":"https://github.com/workato/connector_sdk/pull/124.patch","issue_url":"https://api.github.com/repos/workato/connector_sdk/issues/124","number":124,"state":"open","locked":false,"title":"Google Calendar SDK","user":{"login":"kohroshimizu","id":39761424,"node_id":"MDQ6VXNlcjM5NzYxNDI0","avatar_url":"https://avatars0.githubusercontent.com/u/39761424?v=4","gravatar_id":"","url":"https://api.github.com/users/kohroshimizu","html_url":"https://github.com/kohroshimizu","followers_url":"https://api.github.com/users/kohroshimizu/followers","following_url":"https://api.github.com/users/kohroshimizu/following{/other_user}","gists_url":"https://api.github.com/users/kohroshimizu/gists{/gist_id}","starred_url":"https://api.github.com/users/kohroshimizu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kohroshimizu/subscriptions","organizations_url":"https://api.github.com/users/kohroshimizu/orgs","repos_url":"https://api.github.com/users/kohroshimizu/repos","events_url":"https://api.github.com/users/kohroshimizu/events{/privacy}","received_events_url":"https://api.github.com/users/kohroshimizu/received_events","type":"User","site_admin":false},"body":"Triggers:\r\n- [ ] Calendar Event ended in Google Calendar\r\n- [ ] Cancelled Event in Google Calendar","created_at":"2018-06-26T10:21:26Z","updated_at":"2018-06-27T07:07:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bfe750e7cd7716cf14c2875b01e8081113a87a0f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/workato/connector_sdk/pulls/124/commits","review_comments_url":"https://api.github.com/repos/workato/connector_sdk/pulls/124/comments","review_comment_url":"https://api.github.com/repos/workato/connector_sdk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/workato/connector_sdk/issues/124/comments","statuses_url":"https://api.github.com/repos/workato/connector_sdk/statuses/2e0b7810971943b9ea56427f8b2261069b072fa1","head":{"label":"kohroshimizu:GoogleCalendarSDK","ref":"GoogleCalendarSDK","sha":"2e0b7810971943b9ea56427f8b2261069b072fa1","user":{"login":"kohroshimizu","id":39761424,"node_id":"MDQ6VXNlcjM5NzYxNDI0","avatar_url":"https://avatars0.githubusercontent.com/u/39761424?v=4","gravatar_id":"","url":"https://api.github.com/users/kohroshimizu","html_url":"https://github.com/kohroshimizu","followers_url":"https://api.github.com/users/kohroshimizu/followers","following_url":"https://api.github.com/users/kohroshimizu/following{/other_user}","gists_url":"https://api.github.com/users/kohroshimizu/gists{/gist_id}","starred_url":"https://api.github.com/users/kohroshimizu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kohroshimizu/subscriptions","organizations_url":"https://api.github.com/users/kohroshimizu/orgs","repos_url":"https://api.github.com/users/kohroshimizu/repos","events_url":"https://api.github.com/users/kohroshimizu/events{/privacy}","received_events_url":"https://api.github.com/users/kohroshimizu/received_events","type":"User","site_admin":false},"repo":{"id":138720855,"node_id":"MDEwOlJlcG9zaXRvcnkxMzg3MjA4NTU=","name":"connector_sdk","full_name":"kohroshimizu/connector_sdk","owner":{"login":"kohroshimizu","id":39761424,"node_id":"MDQ6VXNlcjM5NzYxNDI0","avatar_url":"https://avatars0.githubusercontent.com/u/39761424?v=4","gravatar_id":"","url":"https://api.github.com/users/kohroshimizu","html_url":"https://github.com/kohroshimizu","followers_url":"https://api.github.com/users/kohroshimizu/followers","following_url":"https://api.github.com/users/kohroshimizu/following{/other_user}","gists_url":"https://api.github.com/users/kohroshimizu/gists{/gist_id}","starred_url":"https://api.github.com/users/kohroshimizu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kohroshimizu/subscriptions","organizations_url":"https://api.github.com/users/kohroshimizu/orgs","repos_url":"https://api.github.com/users/kohroshimizu/repos","events_url":"https://api.github.com/users/kohroshimizu/events{/privacy}","received_events_url":"https://api.github.com/users/kohroshimizu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kohroshimizu/connector_sdk","description":"Connector SDK samples and documentation","fork":true,"url":"https://api.github.com/repos/kohroshimizu/connector_sdk","forks_url":"https://api.github.com/repos/kohroshimizu/connector_sdk/forks","keys_url":"https://api.github.com/repos/kohroshimizu/connector_sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kohroshimizu/connector_sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kohroshimizu/connector_sdk/teams","hooks_url":"https://api.github.com/repos/kohroshimizu/connector_sdk/hooks","issue_events_url":"https://api.github.com/repos/kohroshimizu/connector_sdk/issues/events{/number}","events_url":"https://api.github.com/repos/kohroshimizu/connector_sdk/events","assignees_url":"https://api.github.com/repos/kohroshimizu/connector_sdk/assignees{/user}","branches_url":"https://api.github.com/repos/kohroshimizu/connector_sdk/branches{/branch}","tags_url":"https://api.github.com/repos/kohroshimizu/connector_sdk/tags","blobs_url":"https://api.github.com/repos/kohroshimizu/connector_sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kohroshimizu/connector_sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kohroshimizu/connector_sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/kohroshimizu/connector_sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kohroshimizu/connector_sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/kohroshimizu/connector_sdk/languages","stargazers_url":"https://api.github.com/repos/kohroshimizu/connector_sdk/stargazers","contributors_url":"https://api.github.com/repos/kohroshimizu/connector_sdk/contributors","subscribers_url":"https://api.github.com/repos/kohroshimizu/connector_sdk/subscribers","subscription_url":"https://api.github.com/repos/kohroshimizu/connector_sdk/subscription","commits_url":"https://api.github.com/repos/kohroshimizu/connector_sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/kohroshimizu/connector_sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/kohroshimizu/connector_sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/kohroshimizu/connector_sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/kohroshimizu/connector_sdk/contents/{+path}","compare_url":"https://api.github.com/repos/kohroshimizu/connector_sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kohroshimizu/connector_sdk/merges","archive_url":"https://api.github.com/repos/kohroshimizu/connector_sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kohroshimizu/connector_sdk/downloads","issues_url":"https://api.github.com/repos/kohroshimizu/connector_sdk/issues{/number}","pulls_url":"https://api.github.com/repos/kohroshimizu/connector_sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/kohroshimizu/connector_sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/kohroshimizu/connector_sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kohroshimizu/connector_sdk/labels{/name}","releases_url":"https://api.github.com/repos/kohroshimizu/connector_sdk/releases{/id}","deployments_url":"https://api.github.com/repos/kohroshimizu/connector_sdk/deployments","created_at":"2018-06-26T10:12:31Z","updated_at":"2018-06-26T10:12:33Z","pushed_at":"2018-06-27T07:07:03Z","git_url":"git://github.com/kohroshimizu/connector_sdk.git","ssh_url":"[email protected]:kohroshimizu/connector_sdk.git","clone_url":"https://github.com/kohroshimizu/connector_sdk.git","svn_url":"https://github.com/kohroshimizu/connector_sdk","homepage":"","size":1925,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"workato:master","ref":"master","sha":"8c91a3e4803921d7e01ce0cda8be768db6df770d","user":{"login":"workato","id":5629924,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2Mjk5MjQ=","avatar_url":"https://avatars3.githubusercontent.com/u/5629924?v=4","gravatar_id":"","url":"https://api.github.com/users/workato","html_url":"https://github.com/workato","followers_url":"https://api.github.com/users/workato/followers","following_url":"https://api.github.com/users/workato/following{/other_user}","gists_url":"https://api.github.com/users/workato/gists{/gist_id}","starred_url":"https://api.github.com/users/workato/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/workato/subscriptions","organizations_url":"https://api.github.com/users/workato/orgs","repos_url":"https://api.github.com/users/workato/repos","events_url":"https://api.github.com/users/workato/events{/privacy}","received_events_url":"https://api.github.com/users/workato/received_events","type":"Organization","site_admin":false},"repo":{"id":54221993,"node_id":"MDEwOlJlcG9zaXRvcnk1NDIyMTk5Mw==","name":"connector_sdk","full_name":"workato/connector_sdk","owner":{"login":"workato","id":5629924,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2Mjk5MjQ=","avatar_url":"https://avatars3.githubusercontent.com/u/5629924?v=4","gravatar_id":"","url":"https://api.github.com/users/workato","html_url":"https://github.com/workato","followers_url":"https://api.github.com/users/workato/followers","following_url":"https://api.github.com/users/workato/following{/other_user}","gists_url":"https://api.github.com/users/workato/gists{/gist_id}","starred_url":"https://api.github.com/users/workato/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/workato/subscriptions","organizations_url":"https://api.github.com/users/workato/orgs","repos_url":"https://api.github.com/users/workato/repos","events_url":"https://api.github.com/users/workato/events{/privacy}","received_events_url":"https://api.github.com/users/workato/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/workato/connector_sdk","description":"Connector SDK samples and documentation","fork":false,"url":"https://api.github.com/repos/workato/connector_sdk","forks_url":"https://api.github.com/repos/workato/connector_sdk/forks","keys_url":"https://api.github.com/repos/workato/connector_sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/workato/connector_sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/workato/connector_sdk/teams","hooks_url":"https://api.github.com/repos/workato/connector_sdk/hooks","issue_events_url":"https://api.github.com/repos/workato/connector_sdk/issues/events{/number}","events_url":"https://api.github.com/repos/workato/connector_sdk/events","assignees_url":"https://api.github.com/repos/workato/connector_sdk/assignees{/user}","branches_url":"https://api.github.com/repos/workato/connector_sdk/branches{/branch}","tags_url":"https://api.github.com/repos/workato/connector_sdk/tags","blobs_url":"https://api.github.com/repos/workato/connector_sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/workato/connector_sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/workato/connector_sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/workato/connector_sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/workato/connector_sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/workato/connector_sdk/languages","stargazers_url":"https://api.github.com/repos/workato/connector_sdk/stargazers","contributors_url":"https://api.github.com/repos/workato/connector_sdk/contributors","subscribers_url":"https://api.github.com/repos/workato/connector_sdk/subscribers","subscription_url":"https://api.github.com/repos/workato/connector_sdk/subscription","commits_url":"https://api.github.com/repos/workato/connector_sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/workato/connector_sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/workato/connector_sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/workato/connector_sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/workato/connector_sdk/contents/{+path}","compare_url":"https://api.github.com/repos/workato/connector_sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/workato/connector_sdk/merges","archive_url":"https://api.github.com/repos/workato/connector_sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/workato/connector_sdk/downloads","issues_url":"https://api.github.com/repos/workato/connector_sdk/issues{/number}","pulls_url":"https://api.github.com/repos/workato/connector_sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/workato/connector_sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/workato/connector_sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/workato/connector_sdk/labels{/name}","releases_url":"https://api.github.com/repos/workato/connector_sdk/releases{/id}","deployments_url":"https://api.github.com/repos/workato/connector_sdk/deployments","created_at":"2016-03-18T18:08:56Z","updated_at":"2018-06-18T15:00:59Z","pushed_at":"2018-06-27T07:07:04Z","git_url":"git://github.com/workato/connector_sdk.git","ssh_url":"[email protected]:workato/connector_sdk.git","clone_url":"https://github.com/workato/connector_sdk.git","svn_url":"https://github.com/workato/connector_sdk","homepage":"","size":1896,"stargazers_count":14,"watchers_count":14,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":38,"mirror_url":null,"archived":false,"open_issues_count":39,"license":null,"forks":38,"open_issues":39,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/workato/connector_sdk/pulls/124"},"html":{"href":"https://github.com/workato/connector_sdk/pull/124"},"issue":{"href":"https://api.github.com/repos/workato/connector_sdk/issues/124"},"comments":{"href":"https://api.github.com/repos/workato/connector_sdk/issues/124/comments"},"review_comments":{"href":"https://api.github.com/repos/workato/connector_sdk/pulls/124/comments"},"review_comment":{"href":"https://api.github.com/repos/workato/connector_sdk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/workato/connector_sdk/pulls/124/commits"},"statuses":{"href":"https://api.github.com/repos/workato/connector_sdk/statuses/2e0b7810971943b9ea56427f8b2261069b072fa1"}},"author_association":"NONE"}} | {
"id": 54221993,
"name": "workato/connector_sdk",
"url": "https://api.github.com/repos/workato/connector_sdk"
} | {
"id": 6697940,
"login": "houndci-bot",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6697940?",
"url": "https://api.github.com/users/houndci-bot"
} | {
"id": 5629924,
"login": "workato",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5629924?",
"url": "https://api.github.com/orgs/workato"
} | 2018-06-27T07:07:11 | 7883826201 | {"actor":{"display_login":"houndci-bot"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/ticketmaster/aurora/pulls/comments/223899095","pull_request_review_id":163137708,"id":223899095,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMzg5OTA5NQ==","diff_hunk":"@@ -0,0 +1,37 @@\n+/* eslint-disable import/prefer-default-export */\n+import React from \"react\";\n+import PropTypes from \"prop-types\";\n+\n+import { colors } from \"../../theme/index\";\n+\n+import CrossIcon from \"../Icons/Cross\";\n+import IconButton from \"../Button/IconButton\";\n+\n+import { withModal } from \"./context\";\n+\n+import { CloseButtonContainer } from \"./DefaultActionBar.styles\";\n+\n+export const ModalActionBar = ({ closeModal }) => (\n+ <CloseButtonContainer>\n+ <IconButton\n+ className=\"button--close\"\n+ size={45}\n+ aria-label=\"Close Modal\"\n+ role=\"button\"\n+ data-testid=\"close-button\"","path":"src/components/Modal/DefaultActionBar.js","position":21,"original_position":21,"commit_id":"461dc1d9c9555c21e4a0521a37d3676e0f437eaf","original_commit_id":"461dc1d9c9555c21e4a0521a37d3676e0f437eaf","user":{"login":"mlampedx","id":20174565,"node_id":"MDQ6VXNlcjIwMTc0NTY1","avatar_url":"https://avatars0.githubusercontent.com/u/20174565?v=4","gravatar_id":"","url":"https://api.github.com/users/mlampedx","html_url":"https://github.com/mlampedx","followers_url":"https://api.github.com/users/mlampedx/followers","following_url":"https://api.github.com/users/mlampedx/following{/other_user}","gists_url":"https://api.github.com/users/mlampedx/gists{/gist_id}","starred_url":"https://api.github.com/users/mlampedx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlampedx/subscriptions","organizations_url":"https://api.github.com/users/mlampedx/orgs","repos_url":"https://api.github.com/users/mlampedx/repos","events_url":"https://api.github.com/users/mlampedx/events{/privacy}","received_events_url":"https://api.github.com/users/mlampedx/received_events","type":"User","site_admin":false},"body":"Please remove all `data-testid` attributes","created_at":"2018-10-09T23:47:37Z","updated_at":"2018-10-09T23:58:06Z","html_url":"https://github.com/ticketmaster/aurora/pull/228#discussion_r223899095","pull_request_url":"https://api.github.com/repos/ticketmaster/aurora/pulls/228","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/ticketmaster/aurora/pulls/comments/223899095"},"html":{"href":"https://github.com/ticketmaster/aurora/pull/228#discussion_r223899095"},"pull_request":{"href":"https://api.github.com/repos/ticketmaster/aurora/pulls/228"}}},"pull_request":{"url":"https://api.github.com/repos/ticketmaster/aurora/pulls/228","id":220026942,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwMDI2OTQy","html_url":"https://github.com/ticketmaster/aurora/pull/228","diff_url":"https://github.com/ticketmaster/aurora/pull/228.diff","patch_url":"https://github.com/ticketmaster/aurora/pull/228.patch","issue_url":"https://api.github.com/repos/ticketmaster/aurora/issues/228","number":228,"state":"open","locked":false,"title":"[WIP] New Modal Preview","user":{"login":"bohdan-shulha","id":533048,"node_id":"MDQ6VXNlcjUzMzA0OA==","avatar_url":"https://avatars2.githubusercontent.com/u/533048?v=4","gravatar_id":"","url":"https://api.github.com/users/bohdan-shulha","html_url":"https://github.com/bohdan-shulha","followers_url":"https://api.github.com/users/bohdan-shulha/followers","following_url":"https://api.github.com/users/bohdan-shulha/following{/other_user}","gists_url":"https://api.github.com/users/bohdan-shulha/gists{/gist_id}","starred_url":"https://api.github.com/users/bohdan-shulha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bohdan-shulha/subscriptions","organizations_url":"https://api.github.com/users/bohdan-shulha/orgs","repos_url":"https://api.github.com/users/bohdan-shulha/repos","events_url":"https://api.github.com/users/bohdan-shulha/events{/privacy}","received_events_url":"https://api.github.com/users/bohdan-shulha/received_events","type":"User","site_admin":false},"body":"<!--\r\nThanks for your interest in the project. Bugs filed and PRs submitted are appreciated!\r\n\r\nPlease make sure that you are familiar with and follow the Code of Conduct for\r\nthis project (found in the CODE_OF_CONDUCT.md file).\r\n\r\nAlso, please make sure you're familiar with and follow the instructions in the\r\ncontributing guidelines (found in the CONTRIBUTING.md file).\r\n\r\nPlease fill out the information below to expedite the review and (hopefully)\r\nmerge of your pull request!\r\n-->\r\n\r\n<!-- What changes are being made? (What feature/bug is being fixed here?) -->\r\n\r\n**What**:\r\n\r\nCreated a new Modal component (for now, so I am not bothered with backward compatibility with ListRow)\r\n\r\n**Why**:\r\n\r\nWe need to have a reusable Modal component which fits not only ListRow needs but other parts of the project as well.\r\n\r\n**How**:\r\n\r\n<!-- Have you done all of these things? -->\r\n\r\n**Checklist**:\r\n\r\n<!-- add \"N/A\" to the end of each line that's irrelevant to your changes -->\r\n\r\n<!-- to check an item, place an \"x\" in the box like so: \"- [x] Documentation\" -->\r\n\r\n* [ ] Documentation\r\n* [ ] Tests\r\n* [ ] Ready to be merged <!-- In your opinion, is this ready to be merged as soon as it's reviewed? -->\r\n\r\n<!-- feel free to add additional comments -->\r\n","created_at":"2018-10-03T12:57:20Z","updated_at":"2018-10-09T23:58:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0d23e2ca5c53d2fd290f36c64ae503020d1edba8","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ticketmaster/aurora/pulls/228/commits","review_comments_url":"https://api.github.com/repos/ticketmaster/aurora/pulls/228/comments","review_comment_url":"https://api.github.com/repos/ticketmaster/aurora/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ticketmaster/aurora/issues/228/comments","statuses_url":"https://api.github.com/repos/ticketmaster/aurora/statuses/461dc1d9c9555c21e4a0521a37d3676e0f437eaf","head":{"label":"bohdan-shulha:advanced-modal","ref":"advanced-modal","sha":"461dc1d9c9555c21e4a0521a37d3676e0f437eaf","user":{"login":"bohdan-shulha","id":533048,"node_id":"MDQ6VXNlcjUzMzA0OA==","avatar_url":"https://avatars2.githubusercontent.com/u/533048?v=4","gravatar_id":"","url":"https://api.github.com/users/bohdan-shulha","html_url":"https://github.com/bohdan-shulha","followers_url":"https://api.github.com/users/bohdan-shulha/followers","following_url":"https://api.github.com/users/bohdan-shulha/following{/other_user}","gists_url":"https://api.github.com/users/bohdan-shulha/gists{/gist_id}","starred_url":"https://api.github.com/users/bohdan-shulha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bohdan-shulha/subscriptions","organizations_url":"https://api.github.com/users/bohdan-shulha/orgs","repos_url":"https://api.github.com/users/bohdan-shulha/repos","events_url":"https://api.github.com/users/bohdan-shulha/events{/privacy}","received_events_url":"https://api.github.com/users/bohdan-shulha/received_events","type":"User","site_admin":false},"repo":{"id":145000955,"node_id":"MDEwOlJlcG9zaXRvcnkxNDUwMDA5NTU=","name":"prism","full_name":"bohdan-shulha/prism","private":false,"owner":{"login":"bohdan-shulha","id":533048,"node_id":"MDQ6VXNlcjUzMzA0OA==","avatar_url":"https://avatars2.githubusercontent.com/u/533048?v=4","gravatar_id":"","url":"https://api.github.com/users/bohdan-shulha","html_url":"https://github.com/bohdan-shulha","followers_url":"https://api.github.com/users/bohdan-shulha/followers","following_url":"https://api.github.com/users/bohdan-shulha/following{/other_user}","gists_url":"https://api.github.com/users/bohdan-shulha/gists{/gist_id}","starred_url":"https://api.github.com/users/bohdan-shulha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bohdan-shulha/subscriptions","organizations_url":"https://api.github.com/users/bohdan-shulha/orgs","repos_url":"https://api.github.com/users/bohdan-shulha/repos","events_url":"https://api.github.com/users/bohdan-shulha/events{/privacy}","received_events_url":"https://api.github.com/users/bohdan-shulha/received_events","type":"User","site_admin":false},"html_url":"https://github.com/bohdan-shulha/prism","description":"Shared UI Library for Ticketmaster","fork":true,"url":"https://api.github.com/repos/bohdan-shulha/prism","forks_url":"https://api.github.com/repos/bohdan-shulha/prism/forks","keys_url":"https://api.github.com/repos/bohdan-shulha/prism/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bohdan-shulha/prism/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bohdan-shulha/prism/teams","hooks_url":"https://api.github.com/repos/bohdan-shulha/prism/hooks","issue_events_url":"https://api.github.com/repos/bohdan-shulha/prism/issues/events{/number}","events_url":"https://api.github.com/repos/bohdan-shulha/prism/events","assignees_url":"https://api.github.com/repos/bohdan-shulha/prism/assignees{/user}","branches_url":"https://api.github.com/repos/bohdan-shulha/prism/branches{/branch}","tags_url":"https://api.github.com/repos/bohdan-shulha/prism/tags","blobs_url":"https://api.github.com/repos/bohdan-shulha/prism/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bohdan-shulha/prism/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bohdan-shulha/prism/git/refs{/sha}","trees_url":"https://api.github.com/repos/bohdan-shulha/prism/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bohdan-shulha/prism/statuses/{sha}","languages_url":"https://api.github.com/repos/bohdan-shulha/prism/languages","stargazers_url":"https://api.github.com/repos/bohdan-shulha/prism/stargazers","contributors_url":"https://api.github.com/repos/bohdan-shulha/prism/contributors","subscribers_url":"https://api.github.com/repos/bohdan-shulha/prism/subscribers","subscription_url":"https://api.github.com/repos/bohdan-shulha/prism/subscription","commits_url":"https://api.github.com/repos/bohdan-shulha/prism/commits{/sha}","git_commits_url":"https://api.github.com/repos/bohdan-shulha/prism/git/commits{/sha}","comments_url":"https://api.github.com/repos/bohdan-shulha/prism/comments{/number}","issue_comment_url":"https://api.github.com/repos/bohdan-shulha/prism/issues/comments{/number}","contents_url":"https://api.github.com/repos/bohdan-shulha/prism/contents/{+path}","compare_url":"https://api.github.com/repos/bohdan-shulha/prism/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bohdan-shulha/prism/merges","archive_url":"https://api.github.com/repos/bohdan-shulha/prism/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bohdan-shulha/prism/downloads","issues_url":"https://api.github.com/repos/bohdan-shulha/prism/issues{/number}","pulls_url":"https://api.github.com/repos/bohdan-shulha/prism/pulls{/number}","milestones_url":"https://api.github.com/repos/bohdan-shulha/prism/milestones{/number}","notifications_url":"https://api.github.com/repos/bohdan-shulha/prism/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bohdan-shulha/prism/labels{/name}","releases_url":"https://api.github.com/repos/bohdan-shulha/prism/releases{/id}","deployments_url":"https://api.github.com/repos/bohdan-shulha/prism/deployments","created_at":"2018-08-16T14:41:13Z","updated_at":"2018-08-16T14:41:16Z","pushed_at":"2018-10-09T15:20:55Z","git_url":"git://github.com/bohdan-shulha/prism.git","ssh_url":"[email protected]:bohdan-shulha/prism.git","clone_url":"https://github.com/bohdan-shulha/prism.git","svn_url":"https://github.com/bohdan-shulha/prism","homepage":"https://code.ticketmaster.com/prism/","size":14361,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ticketmaster:master","ref":"master","sha":"c0dfafc6cc3564b50a47709f3c8052972dbafe3c","user":{"login":"ticketmaster","id":5680728,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2ODA3Mjg=","avatar_url":"https://avatars2.githubusercontent.com/u/5680728?v=4","gravatar_id":"","url":"https://api.github.com/users/ticketmaster","html_url":"https://github.com/ticketmaster","followers_url":"https://api.github.com/users/ticketmaster/followers","following_url":"https://api.github.com/users/ticketmaster/following{/other_user}","gists_url":"https://api.github.com/users/ticketmaster/gists{/gist_id}","starred_url":"https://api.github.com/users/ticketmaster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ticketmaster/subscriptions","organizations_url":"https://api.github.com/users/ticketmaster/orgs","repos_url":"https://api.github.com/users/ticketmaster/repos","events_url":"https://api.github.com/users/ticketmaster/events{/privacy}","received_events_url":"https://api.github.com/users/ticketmaster/received_events","type":"Organization","site_admin":false},"repo":{"id":131040509,"node_id":"MDEwOlJlcG9zaXRvcnkxMzEwNDA1MDk=","name":"aurora","full_name":"ticketmaster/aurora","private":false,"owner":{"login":"ticketmaster","id":5680728,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2ODA3Mjg=","avatar_url":"https://avatars2.githubusercontent.com/u/5680728?v=4","gravatar_id":"","url":"https://api.github.com/users/ticketmaster","html_url":"https://github.com/ticketmaster","followers_url":"https://api.github.com/users/ticketmaster/followers","following_url":"https://api.github.com/users/ticketmaster/following{/other_user}","gists_url":"https://api.github.com/users/ticketmaster/gists{/gist_id}","starred_url":"https://api.github.com/users/ticketmaster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ticketmaster/subscriptions","organizations_url":"https://api.github.com/users/ticketmaster/orgs","repos_url":"https://api.github.com/users/ticketmaster/repos","events_url":"https://api.github.com/users/ticketmaster/events{/privacy}","received_events_url":"https://api.github.com/users/ticketmaster/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ticketmaster/aurora","description":"Shared UI Library for Ticketmaster","fork":false,"url":"https://api.github.com/repos/ticketmaster/aurora","forks_url":"https://api.github.com/repos/ticketmaster/aurora/forks","keys_url":"https://api.github.com/repos/ticketmaster/aurora/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ticketmaster/aurora/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ticketmaster/aurora/teams","hooks_url":"https://api.github.com/repos/ticketmaster/aurora/hooks","issue_events_url":"https://api.github.com/repos/ticketmaster/aurora/issues/events{/number}","events_url":"https://api.github.com/repos/ticketmaster/aurora/events","assignees_url":"https://api.github.com/repos/ticketmaster/aurora/assignees{/user}","branches_url":"https://api.github.com/repos/ticketmaster/aurora/branches{/branch}","tags_url":"https://api.github.com/repos/ticketmaster/aurora/tags","blobs_url":"https://api.github.com/repos/ticketmaster/aurora/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ticketmaster/aurora/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ticketmaster/aurora/git/refs{/sha}","trees_url":"https://api.github.com/repos/ticketmaster/aurora/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ticketmaster/aurora/statuses/{sha}","languages_url":"https://api.github.com/repos/ticketmaster/aurora/languages","stargazers_url":"https://api.github.com/repos/ticketmaster/aurora/stargazers","contributors_url":"https://api.github.com/repos/ticketmaster/aurora/contributors","subscribers_url":"https://api.github.com/repos/ticketmaster/aurora/subscribers","subscription_url":"https://api.github.com/repos/ticketmaster/aurora/subscription","commits_url":"https://api.github.com/repos/ticketmaster/aurora/commits{/sha}","git_commits_url":"https://api.github.com/repos/ticketmaster/aurora/git/commits{/sha}","comments_url":"https://api.github.com/repos/ticketmaster/aurora/comments{/number}","issue_comment_url":"https://api.github.com/repos/ticketmaster/aurora/issues/comments{/number}","contents_url":"https://api.github.com/repos/ticketmaster/aurora/contents/{+path}","compare_url":"https://api.github.com/repos/ticketmaster/aurora/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ticketmaster/aurora/merges","archive_url":"https://api.github.com/repos/ticketmaster/aurora/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ticketmaster/aurora/downloads","issues_url":"https://api.github.com/repos/ticketmaster/aurora/issues{/number}","pulls_url":"https://api.github.com/repos/ticketmaster/aurora/pulls{/number}","milestones_url":"https://api.github.com/repos/ticketmaster/aurora/milestones{/number}","notifications_url":"https://api.github.com/repos/ticketmaster/aurora/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ticketmaster/aurora/labels{/name}","releases_url":"https://api.github.com/repos/ticketmaster/aurora/releases{/id}","deployments_url":"https://api.github.com/repos/ticketmaster/aurora/deployments","created_at":"2018-04-25T17:21:56Z","updated_at":"2018-10-08T23:46:45Z","pushed_at":"2018-10-09T23:16:48Z","git_url":"git://github.com/ticketmaster/aurora.git","ssh_url":"[email protected]:ticketmaster/aurora.git","clone_url":"https://github.com/ticketmaster/aurora.git","svn_url":"https://github.com/ticketmaster/aurora","homepage":"","size":35482,"stargazers_count":31,"watchers_count":31,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":17,"mirror_url":null,"archived":false,"open_issues_count":15,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":17,"open_issues":15,"watchers":31,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ticketmaster/aurora/pulls/228"},"html":{"href":"https://github.com/ticketmaster/aurora/pull/228"},"issue":{"href":"https://api.github.com/repos/ticketmaster/aurora/issues/228"},"comments":{"href":"https://api.github.com/repos/ticketmaster/aurora/issues/228/comments"},"review_comments":{"href":"https://api.github.com/repos/ticketmaster/aurora/pulls/228/comments"},"review_comment":{"href":"https://api.github.com/repos/ticketmaster/aurora/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ticketmaster/aurora/pulls/228/commits"},"statuses":{"href":"https://api.github.com/repos/ticketmaster/aurora/statuses/461dc1d9c9555c21e4a0521a37d3676e0f437eaf"}},"author_association":"CONTRIBUTOR"}} | {
"id": 131040509,
"name": "ticketmaster/aurora",
"url": "https://api.github.com/repos/ticketmaster/aurora"
} | {
"id": 20174565,
"login": "mlampedx",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/20174565?",
"url": "https://api.github.com/users/mlampedx"
} | {
"id": 5680728,
"login": "ticketmaster",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5680728?",
"url": "https://api.github.com/orgs/ticketmaster"
} | 2018-10-09T23:47:37 | 8394311490 | {"actor":{"display_login":"mlampedx"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/hmrc/help-to-save/pulls/comments/197474809","pull_request_review_id":131230932,"id":197474809,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NzQ3NDgwOQ==","diff_hunk":"@@ -0,0 +1,148 @@\n+/*\n+ * Copyright 2018 HM Revenue & Customs\n+ *\n+ * Licensed under the Apache License, Version 2.0 (the \"License\");\n+ * you may not use this file except in compliance with the License.\n+ * You may obtain a copy of the License at\n+ *\n+ * http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+\n+package uk.gov.hmrc.helptosave.actors\n+\n+import cats.instances.string._\n+import cats.syntax.eq._\n+import com.google.inject.{ImplementedBy, Singleton}\n+import uk.gov.hmrc.helptosave.repo.MongoEligibilityStatsStore.EligibilityStats\n+import uk.gov.hmrc.helptosave.util.Logging\n+\n+@ImplementedBy(classOf[EligibilityStatsHandlerImpl])\n+trait EligibilityStatsHandler {\n+ def handleStats(result: List[EligibilityStats]): String\n+}\n+\n+@Singleton\n+class EligibilityStatsHandlerImpl extends EligibilityStatsHandler with Logging {\n+\n+ type Table = List[(String, List[(String, Int)])]\n+\n+ private val emptyTable = List.empty[(String, List[(String, Int)])]\n+\n+ override def handleStats(stats: List[EligibilityStats]): String = {\n+\n+ val report = prettyFormatTable(createTable(stats))\n+\n+ logger.info(s\"report is $report\")\n+ //for unit testing\n+ report\n+ }\n+\n+ def createTable(stats: List[EligibilityStats]): Table = {\n+\n+ val groupedByEligibilityReason: Map[Option[Int], List[EligibilityStats]] = stats.groupBy(_.eligibilityReason)\n+\n+ val groupedByEligibilityReasonThenSource: Table =\n+ groupedByEligibilityReason.map {\n+ case (k, v) ⇒\n+ k.map(_.toString).getOrElse(\"Unknown\") -> {\n+ v.groupBy(_.source).map(x ⇒ x._1.getOrElse(\"Unknown\") → x._2.map(_.total).sum).toList.sortBy(_._1)\n+ }\n+ }.toList.sortBy(_._1)\n+\n+ val tableWithMissingSources = addMissingSourceTotals(groupedByEligibilityReasonThenSource)\n+\n+ mapIntToReasonString(tableWithMissingSources)\n+ }\n+\n+ private def addMissingSourceTotals(table: Table) = {\n+ //add missing sources with total 0 for each reason\n+ val sources = allSourcesFromMongo(table)\n+ table.foldLeft[Table](emptyTable) {\n+ case (a, b) ⇒\n+\n+ val x = sources.foldLeft[List[(String, Int)]](List.empty[(String, Int)]) {\n+ case (c, d) ⇒\n+ if (!b._2.map(_._1).contains(d)) {\n+ (d, 0) :: c\n+ } else {\n+ c\n+ }\n+ }\n+ (b._1, x ::: b._2) :: a\n+ }\n+ }\n+\n+ private def mapIntToReasonString(table: Table) = {\n+ table\n+ .foldLeft[Table](emptyTable) {\n+ case (modified, original) ⇒\n+ if (original._1 === \"6\") {\n+ val t: (String, List[(String, Int)]) = (\"UC\", original._2)\n+ t :: modified\n+ } else if (original._1 === \"7\") {\n+ val t: (String, List[(String, Int)]) = (\"WTC\", original._2)\n+ t :: modified\n+ } else if (original._1 === \"8\") {\n+ val t: (String, List[(String, Int)]) = (\"UC&WTC\", original._2)\n+ t :: modified\n+ } else {\n+ val t: (String, List[(String, Int)]) = original\n+ t :: modified\n+ }\n+ }\n+ }\n+\n+ def prettyFormatTable(table: Table): String = {\n+ val f = \"|%8s|%10s|%10s|\\n\"","path":"app/uk/gov/hmrc/helptosave/actors/EligibilityStatsHandler.scala","position":102,"original_position":102,"commit_id":"2246af1af22f7bb144cf7e7eef800fce702b1221","original_commit_id":"2246af1af22f7bb144cf7e7eef800fce702b1221","user":{"login":"sureshhmrc","id":27204388,"node_id":"MDQ6VXNlcjI3MjA0Mzg4","avatar_url":"https://avatars2.githubusercontent.com/u/27204388?v=4","gravatar_id":"","url":"https://api.github.com/users/sureshhmrc","html_url":"https://github.com/sureshhmrc","followers_url":"https://api.github.com/users/sureshhmrc/followers","following_url":"https://api.github.com/users/sureshhmrc/following{/other_user}","gists_url":"https://api.github.com/users/sureshhmrc/gists{/gist_id}","starred_url":"https://api.github.com/users/sureshhmrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sureshhmrc/subscriptions","organizations_url":"https://api.github.com/users/sureshhmrc/orgs","repos_url":"https://api.github.com/users/sureshhmrc/repos","events_url":"https://api.github.com/users/sureshhmrc/events{/privacy}","received_events_url":"https://api.github.com/users/sureshhmrc/received_events","type":"User","site_admin":false},"body":"wouldn't those strings be accommodated the specified length `%10s` ? \r\n\r\nif any string has more than 10 then we can adjust the table ","created_at":"2018-06-22T15:04:18Z","updated_at":"2018-06-22T15:04:18Z","html_url":"https://github.com/hmrc/help-to-save/pull/149#discussion_r197474809","pull_request_url":"https://api.github.com/repos/hmrc/help-to-save/pulls/149","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/hmrc/help-to-save/pulls/comments/197474809"},"html":{"href":"https://github.com/hmrc/help-to-save/pull/149#discussion_r197474809"},"pull_request":{"href":"https://api.github.com/repos/hmrc/help-to-save/pulls/149"}},"in_reply_to_id":197462686},"pull_request":{"url":"https://api.github.com/repos/hmrc/help-to-save/pulls/149","id":195770555,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1NzcwNTU1","html_url":"https://github.com/hmrc/help-to-save/pull/149","diff_url":"https://github.com/hmrc/help-to-save/pull/149.diff","patch_url":"https://github.com/hmrc/help-to-save/pull/149.patch","issue_url":"https://api.github.com/repos/hmrc/help-to-save/issues/149","number":149,"state":"open","locked":false,"title":" HTS-1093: Read stats from mongo for channel and eligibilityReason and log in kibana","user":{"login":"sureshhmrc","id":27204388,"node_id":"MDQ6VXNlcjI3MjA0Mzg4","avatar_url":"https://avatars2.githubusercontent.com/u/27204388?v=4","gravatar_id":"","url":"https://api.github.com/users/sureshhmrc","html_url":"https://github.com/sureshhmrc","followers_url":"https://api.github.com/users/sureshhmrc/followers","following_url":"https://api.github.com/users/sureshhmrc/following{/other_user}","gists_url":"https://api.github.com/users/sureshhmrc/gists{/gist_id}","starred_url":"https://api.github.com/users/sureshhmrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sureshhmrc/subscriptions","organizations_url":"https://api.github.com/users/sureshhmrc/orgs","repos_url":"https://api.github.com/users/sureshhmrc/repos","events_url":"https://api.github.com/users/sureshhmrc/events{/privacy}","received_events_url":"https://api.github.com/users/sureshhmrc/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-06-19T09:51:39Z","updated_at":"2018-06-22T15:04:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fb413f2cc59904be3eb850c3d945c5632d10e1c4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/hmrc/help-to-save/pulls/149/commits","review_comments_url":"https://api.github.com/repos/hmrc/help-to-save/pulls/149/comments","review_comment_url":"https://api.github.com/repos/hmrc/help-to-save/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hmrc/help-to-save/issues/149/comments","statuses_url":"https://api.github.com/repos/hmrc/help-to-save/statuses/2246af1af22f7bb144cf7e7eef800fce702b1221","head":{"label":"hmrc:hts-1093","ref":"hts-1093","sha":"2246af1af22f7bb144cf7e7eef800fce702b1221","user":{"login":"hmrc","id":5755339,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU3NTUzMzk=","avatar_url":"https://avatars1.githubusercontent.com/u/5755339?v=4","gravatar_id":"","url":"https://api.github.com/users/hmrc","html_url":"https://github.com/hmrc","followers_url":"https://api.github.com/users/hmrc/followers","following_url":"https://api.github.com/users/hmrc/following{/other_user}","gists_url":"https://api.github.com/users/hmrc/gists{/gist_id}","starred_url":"https://api.github.com/users/hmrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmrc/subscriptions","organizations_url":"https://api.github.com/users/hmrc/orgs","repos_url":"https://api.github.com/users/hmrc/repos","events_url":"https://api.github.com/users/hmrc/events{/privacy}","received_events_url":"https://api.github.com/users/hmrc/received_events","type":"Organization","site_admin":false},"repo":{"id":91348868,"node_id":"MDEwOlJlcG9zaXRvcnk5MTM0ODg2OA==","name":"help-to-save","full_name":"hmrc/help-to-save","owner":{"login":"hmrc","id":5755339,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU3NTUzMzk=","avatar_url":"https://avatars1.githubusercontent.com/u/5755339?v=4","gravatar_id":"","url":"https://api.github.com/users/hmrc","html_url":"https://github.com/hmrc","followers_url":"https://api.github.com/users/hmrc/followers","following_url":"https://api.github.com/users/hmrc/following{/other_user}","gists_url":"https://api.github.com/users/hmrc/gists{/gist_id}","starred_url":"https://api.github.com/users/hmrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmrc/subscriptions","organizations_url":"https://api.github.com/users/hmrc/orgs","repos_url":"https://api.github.com/users/hmrc/repos","events_url":"https://api.github.com/users/hmrc/events{/privacy}","received_events_url":"https://api.github.com/users/hmrc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hmrc/help-to-save","description":null,"fork":false,"url":"https://api.github.com/repos/hmrc/help-to-save","forks_url":"https://api.github.com/repos/hmrc/help-to-save/forks","keys_url":"https://api.github.com/repos/hmrc/help-to-save/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hmrc/help-to-save/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hmrc/help-to-save/teams","hooks_url":"https://api.github.com/repos/hmrc/help-to-save/hooks","issue_events_url":"https://api.github.com/repos/hmrc/help-to-save/issues/events{/number}","events_url":"https://api.github.com/repos/hmrc/help-to-save/events","assignees_url":"https://api.github.com/repos/hmrc/help-to-save/assignees{/user}","branches_url":"https://api.github.com/repos/hmrc/help-to-save/branches{/branch}","tags_url":"https://api.github.com/repos/hmrc/help-to-save/tags","blobs_url":"https://api.github.com/repos/hmrc/help-to-save/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hmrc/help-to-save/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hmrc/help-to-save/git/refs{/sha}","trees_url":"https://api.github.com/repos/hmrc/help-to-save/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hmrc/help-to-save/statuses/{sha}","languages_url":"https://api.github.com/repos/hmrc/help-to-save/languages","stargazers_url":"https://api.github.com/repos/hmrc/help-to-save/stargazers","contributors_url":"https://api.github.com/repos/hmrc/help-to-save/contributors","subscribers_url":"https://api.github.com/repos/hmrc/help-to-save/subscribers","subscription_url":"https://api.github.com/repos/hmrc/help-to-save/subscription","commits_url":"https://api.github.com/repos/hmrc/help-to-save/commits{/sha}","git_commits_url":"https://api.github.com/repos/hmrc/help-to-save/git/commits{/sha}","comments_url":"https://api.github.com/repos/hmrc/help-to-save/comments{/number}","issue_comment_url":"https://api.github.com/repos/hmrc/help-to-save/issues/comments{/number}","contents_url":"https://api.github.com/repos/hmrc/help-to-save/contents/{+path}","compare_url":"https://api.github.com/repos/hmrc/help-to-save/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hmrc/help-to-save/merges","archive_url":"https://api.github.com/repos/hmrc/help-to-save/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hmrc/help-to-save/downloads","issues_url":"https://api.github.com/repos/hmrc/help-to-save/issues{/number}","pulls_url":"https://api.github.com/repos/hmrc/help-to-save/pulls{/number}","milestones_url":"https://api.github.com/repos/hmrc/help-to-save/milestones{/number}","notifications_url":"https://api.github.com/repos/hmrc/help-to-save/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hmrc/help-to-save/labels{/name}","releases_url":"https://api.github.com/repos/hmrc/help-to-save/releases{/id}","deployments_url":"https://api.github.com/repos/hmrc/help-to-save/deployments","created_at":"2017-05-15T14:41:39Z","updated_at":"2018-06-22T14:24:33Z","pushed_at":"2018-06-22T14:24:35Z","git_url":"git://github.com/hmrc/help-to-save.git","ssh_url":"[email protected]:hmrc/help-to-save.git","clone_url":"https://github.com/hmrc/help-to-save.git","svn_url":"https://github.com/hmrc/help-to-save","homepage":"","size":633,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"hmrc:master","ref":"master","sha":"1834fca39b291d67fcb5f41227346ec9efd40d01","user":{"login":"hmrc","id":5755339,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU3NTUzMzk=","avatar_url":"https://avatars1.githubusercontent.com/u/5755339?v=4","gravatar_id":"","url":"https://api.github.com/users/hmrc","html_url":"https://github.com/hmrc","followers_url":"https://api.github.com/users/hmrc/followers","following_url":"https://api.github.com/users/hmrc/following{/other_user}","gists_url":"https://api.github.com/users/hmrc/gists{/gist_id}","starred_url":"https://api.github.com/users/hmrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmrc/subscriptions","organizations_url":"https://api.github.com/users/hmrc/orgs","repos_url":"https://api.github.com/users/hmrc/repos","events_url":"https://api.github.com/users/hmrc/events{/privacy}","received_events_url":"https://api.github.com/users/hmrc/received_events","type":"Organization","site_admin":false},"repo":{"id":91348868,"node_id":"MDEwOlJlcG9zaXRvcnk5MTM0ODg2OA==","name":"help-to-save","full_name":"hmrc/help-to-save","owner":{"login":"hmrc","id":5755339,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU3NTUzMzk=","avatar_url":"https://avatars1.githubusercontent.com/u/5755339?v=4","gravatar_id":"","url":"https://api.github.com/users/hmrc","html_url":"https://github.com/hmrc","followers_url":"https://api.github.com/users/hmrc/followers","following_url":"https://api.github.com/users/hmrc/following{/other_user}","gists_url":"https://api.github.com/users/hmrc/gists{/gist_id}","starred_url":"https://api.github.com/users/hmrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmrc/subscriptions","organizations_url":"https://api.github.com/users/hmrc/orgs","repos_url":"https://api.github.com/users/hmrc/repos","events_url":"https://api.github.com/users/hmrc/events{/privacy}","received_events_url":"https://api.github.com/users/hmrc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hmrc/help-to-save","description":null,"fork":false,"url":"https://api.github.com/repos/hmrc/help-to-save","forks_url":"https://api.github.com/repos/hmrc/help-to-save/forks","keys_url":"https://api.github.com/repos/hmrc/help-to-save/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hmrc/help-to-save/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hmrc/help-to-save/teams","hooks_url":"https://api.github.com/repos/hmrc/help-to-save/hooks","issue_events_url":"https://api.github.com/repos/hmrc/help-to-save/issues/events{/number}","events_url":"https://api.github.com/repos/hmrc/help-to-save/events","assignees_url":"https://api.github.com/repos/hmrc/help-to-save/assignees{/user}","branches_url":"https://api.github.com/repos/hmrc/help-to-save/branches{/branch}","tags_url":"https://api.github.com/repos/hmrc/help-to-save/tags","blobs_url":"https://api.github.com/repos/hmrc/help-to-save/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hmrc/help-to-save/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hmrc/help-to-save/git/refs{/sha}","trees_url":"https://api.github.com/repos/hmrc/help-to-save/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hmrc/help-to-save/statuses/{sha}","languages_url":"https://api.github.com/repos/hmrc/help-to-save/languages","stargazers_url":"https://api.github.com/repos/hmrc/help-to-save/stargazers","contributors_url":"https://api.github.com/repos/hmrc/help-to-save/contributors","subscribers_url":"https://api.github.com/repos/hmrc/help-to-save/subscribers","subscription_url":"https://api.github.com/repos/hmrc/help-to-save/subscription","commits_url":"https://api.github.com/repos/hmrc/help-to-save/commits{/sha}","git_commits_url":"https://api.github.com/repos/hmrc/help-to-save/git/commits{/sha}","comments_url":"https://api.github.com/repos/hmrc/help-to-save/comments{/number}","issue_comment_url":"https://api.github.com/repos/hmrc/help-to-save/issues/comments{/number}","contents_url":"https://api.github.com/repos/hmrc/help-to-save/contents/{+path}","compare_url":"https://api.github.com/repos/hmrc/help-to-save/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hmrc/help-to-save/merges","archive_url":"https://api.github.com/repos/hmrc/help-to-save/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hmrc/help-to-save/downloads","issues_url":"https://api.github.com/repos/hmrc/help-to-save/issues{/number}","pulls_url":"https://api.github.com/repos/hmrc/help-to-save/pulls{/number}","milestones_url":"https://api.github.com/repos/hmrc/help-to-save/milestones{/number}","notifications_url":"https://api.github.com/repos/hmrc/help-to-save/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hmrc/help-to-save/labels{/name}","releases_url":"https://api.github.com/repos/hmrc/help-to-save/releases{/id}","deployments_url":"https://api.github.com/repos/hmrc/help-to-save/deployments","created_at":"2017-05-15T14:41:39Z","updated_at":"2018-06-22T14:24:33Z","pushed_at":"2018-06-22T14:24:35Z","git_url":"git://github.com/hmrc/help-to-save.git","ssh_url":"[email protected]:hmrc/help-to-save.git","clone_url":"https://github.com/hmrc/help-to-save.git","svn_url":"https://github.com/hmrc/help-to-save","homepage":"","size":633,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hmrc/help-to-save/pulls/149"},"html":{"href":"https://github.com/hmrc/help-to-save/pull/149"},"issue":{"href":"https://api.github.com/repos/hmrc/help-to-save/issues/149"},"comments":{"href":"https://api.github.com/repos/hmrc/help-to-save/issues/149/comments"},"review_comments":{"href":"https://api.github.com/repos/hmrc/help-to-save/pulls/149/comments"},"review_comment":{"href":"https://api.github.com/repos/hmrc/help-to-save/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hmrc/help-to-save/pulls/149/commits"},"statuses":{"href":"https://api.github.com/repos/hmrc/help-to-save/statuses/2246af1af22f7bb144cf7e7eef800fce702b1221"}},"author_association":"CONTRIBUTOR"}} | {
"id": 91348868,
"name": "hmrc/help-to-save",
"url": "https://api.github.com/repos/hmrc/help-to-save"
} | {
"id": 27204388,
"login": "sureshhmrc",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/27204388?",
"url": "https://api.github.com/users/sureshhmrc"
} | {
"id": 5755339,
"login": "hmrc",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5755339?",
"url": "https://api.github.com/orgs/hmrc"
} | 2018-06-22T15:04:18 | 7864685279 | {"actor":{"display_login":"sureshhmrc"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/hmrc/self-assessment-api/pulls/comments/186119974","pull_request_review_id":117651982,"id":186119974,"diff_hunk":"@@ -0,0 +1,130 @@\n+/*\n+ * Copyright 2018 HM Revenue & Customs\n+ *\n+ * Licensed under the Apache License, Version 2.0 (the \"License\");\n+ * you may not use this file except in compliance with the License.\n+ * You may obtain a copy of the License at\n+ *\n+ * http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+\n+package uk.gov.hmrc.selfassessmentapi.resources\n+\n+import org.scalatestplus.play.OneAppPerSuite\n+import play.api.libs.json.{JsValue, Json}\n+import play.api.test.FakeRequest\n+import play.mvc.Http.MimeTypes\n+import uk.gov.hmrc.selfassessmentapi.mocks.services.MockBanksAnnualSummaryService\n+import uk.gov.hmrc.selfassessmentapi.models.banks.BankAnnualSummary\n+import uk.gov.hmrc.selfassessmentapi.models.{Errors, SourceType}\n+\n+import scala.concurrent.Future\n+\n+class BanksAnnualSummaryResourceSpec extends ResourceSpec with OneAppPerSuite\n+ with MockBanksAnnualSummaryService {\n+\n+ class Setup {\n+ val resource = new BanksAnnualSummaryResource {\n+ val annualSummaryService = mockBanksAnnualSummaryService\n+ val appContext = mockAppContext\n+ val authService = mockAuthorisationService\n+ }\n+ mockAPIAction(SourceType.Banks)\n+ }\n+\n+ class SetupWithAuthEnabled extends Setup {\n+ mockAPIAction(SourceType.Banks, authEnabled = true)\n+ }\n+\n+ val nino = generateNino\n+ val sourceId = \"test-sourceId\"\n+ val taxedUkInterest = Some(BigDecimal(50.30))\n+ val untaxedUkInterest = Some(BigDecimal(70.15))\n+\n+ val emptyBankSummary = BankAnnualSummary(None, None)\n+\n+ val bankAnnualSummary = BankAnnualSummary(taxedUkInterest, untaxedUkInterest)\n+ val bankAnnualSummaryJson = Jsons.Banks.annualSummary(taxedUkInterest, untaxedUkInterest)\n+\n+ \"updateAnnualSummary\" should {\n+ \"return a 204\" when {\n+ \"the request contains an empty body\" in new Setup {\n+ val request: FakeRequest[JsValue] = FakeRequest().withBody[JsValue](Json.obj())\n+\n+ MockBanksAnnualSummaryService\n+ .updateAnnualSummary(nino, sourceId, taxYear, emptyBankSummary)\n+ .returns(Future.successful(true))\n+\n+ val result = resource.updateAnnualSummary(nino, sourceId, taxYear)(request)\n+ status(result) shouldBe NO_CONTENT\n+ contentType(result) shouldBe None\n+ }\n+\n+ \"the request contains the correct body\" in new Setup {\n+ val request: FakeRequest[JsValue] = FakeRequest().withBody[JsValue](bankAnnualSummaryJson)\n+\n+ MockBanksAnnualSummaryService\n+ .updateAnnualSummary(nino, sourceId, taxYear, bankAnnualSummary)\n+ .returns(Future.successful(true))\n+\n+ val result = resource.updateAnnualSummary(nino, sourceId, taxYear)(request)\n+ status(result) shouldBe NO_CONTENT\n+ contentType(result) shouldBe None\n+ }\n+ }\n+\n+ \"return a 400\" when {\n+ \"the request contains a incorrect value for taxedUkInterest\" in new Setup {\n+ val incorrectBankAnnualSummaryJson = Json.obj(\"taxedUkInterest\" -> \"body\")\n+ val request: FakeRequest[JsValue] = FakeRequest().withBody[JsValue](incorrectBankAnnualSummaryJson)\n+\n+ MockBanksAnnualSummaryService\n+ .updateAnnualSummary(nino, sourceId, taxYear, emptyBankSummary)\n+ .returns(Future.successful(true))\n+\n+ val result = resource.updateAnnualSummary(nino, sourceId, taxYear)(request)\n+ status(result) shouldBe BAD_REQUEST\n+ contentType(result) shouldBe Some(MimeTypes.JSON)\n+\n+ val error = Errors.numberFormatExceptionError(\"/taxedUkInterest\")\n+ contentAsJson(result) shouldBe Json.toJson(Errors.badRequest(error))","path":"test/uk/gov/hmrc/selfassessmentapi/resources/BanksAnnualSummaryResourceSpec.scala","position":96,"original_position":96,"commit_id":"d6633b8490daa1d3dd88f2b0d5907ca2c3c75362","original_commit_id":"d6633b8490daa1d3dd88f2b0d5907ca2c3c75362","user":{"login":"westwater","id":14073782,"avatar_url":"https://avatars0.githubusercontent.com/u/14073782?v=4","gravatar_id":"","url":"https://api.github.com/users/westwater","html_url":"https://github.com/westwater","followers_url":"https://api.github.com/users/westwater/followers","following_url":"https://api.github.com/users/westwater/following{/other_user}","gists_url":"https://api.github.com/users/westwater/gists{/gist_id}","starred_url":"https://api.github.com/users/westwater/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/westwater/subscriptions","organizations_url":"https://api.github.com/users/westwater/orgs","repos_url":"https://api.github.com/users/westwater/repos","events_url":"https://api.github.com/users/westwater/events{/privacy}","received_events_url":"https://api.github.com/users/westwater/received_events","type":"User","site_admin":false},"body":"@scottylace Added check on the response body + asserted absence of a body on other tests in this spec","created_at":"2018-05-04T15:33:34Z","updated_at":"2018-05-04T15:33:35Z","html_url":"https://github.com/hmrc/self-assessment-api/pull/601#discussion_r186119974","pull_request_url":"https://api.github.com/repos/hmrc/self-assessment-api/pulls/601","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/hmrc/self-assessment-api/pulls/comments/186119974"},"html":{"href":"https://github.com/hmrc/self-assessment-api/pull/601#discussion_r186119974"},"pull_request":{"href":"https://api.github.com/repos/hmrc/self-assessment-api/pulls/601"}}},"pull_request":{"url":"https://api.github.com/repos/hmrc/self-assessment-api/pulls/601","id":185994693,"html_url":"https://github.com/hmrc/self-assessment-api/pull/601","diff_url":"https://github.com/hmrc/self-assessment-api/pull/601.diff","patch_url":"https://github.com/hmrc/self-assessment-api/pull/601.patch","issue_url":"https://api.github.com/repos/hmrc/self-assessment-api/issues/601","number":601,"state":"open","locked":false,"title":"MTDSA-1635 Added unit test framework + added unit tests for Banks annual summary","user":{"login":"westwater","id":14073782,"avatar_url":"https://avatars0.githubusercontent.com/u/14073782?v=4","gravatar_id":"","url":"https://api.github.com/users/westwater","html_url":"https://github.com/westwater","followers_url":"https://api.github.com/users/westwater/followers","following_url":"https://api.github.com/users/westwater/following{/other_user}","gists_url":"https://api.github.com/users/westwater/gists{/gist_id}","starred_url":"https://api.github.com/users/westwater/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/westwater/subscriptions","organizations_url":"https://api.github.com/users/westwater/orgs","repos_url":"https://api.github.com/users/westwater/repos","events_url":"https://api.github.com/users/westwater/events{/privacy}","received_events_url":"https://api.github.com/users/westwater/received_events","type":"User","site_admin":false},"body":"…ual summary\r\n\r\nPlease check if this change includes (or even requires) the following:\r\n\r\n - [x] unit tests\r\n - [ ] functional tests\r\n - [ ] audit events\r\n - [ ] RAML documentation\r\n - [ ] logging\r\n","created_at":"2018-05-04T14:08:04Z","updated_at":"2018-05-04T15:33:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"67e75650f6c6a172f01c1982616f7bd8d0619166","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/hmrc/self-assessment-api/pulls/601/commits","review_comments_url":"https://api.github.com/repos/hmrc/self-assessment-api/pulls/601/comments","review_comment_url":"https://api.github.com/repos/hmrc/self-assessment-api/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hmrc/self-assessment-api/issues/601/comments","statuses_url":"https://api.github.com/repos/hmrc/self-assessment-api/statuses/d6633b8490daa1d3dd88f2b0d5907ca2c3c75362","head":{"label":"hmrc:MTDSA-1635","ref":"MTDSA-1635","sha":"d6633b8490daa1d3dd88f2b0d5907ca2c3c75362","user":{"login":"hmrc","id":5755339,"avatar_url":"https://avatars1.githubusercontent.com/u/5755339?v=4","gravatar_id":"","url":"https://api.github.com/users/hmrc","html_url":"https://github.com/hmrc","followers_url":"https://api.github.com/users/hmrc/followers","following_url":"https://api.github.com/users/hmrc/following{/other_user}","gists_url":"https://api.github.com/users/hmrc/gists{/gist_id}","starred_url":"https://api.github.com/users/hmrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmrc/subscriptions","organizations_url":"https://api.github.com/users/hmrc/orgs","repos_url":"https://api.github.com/users/hmrc/repos","events_url":"https://api.github.com/users/hmrc/events{/privacy}","received_events_url":"https://api.github.com/users/hmrc/received_events","type":"Organization","site_admin":false},"repo":{"id":56500706,"name":"self-assessment-api","full_name":"hmrc/self-assessment-api","owner":{"login":"hmrc","id":5755339,"avatar_url":"https://avatars1.githubusercontent.com/u/5755339?v=4","gravatar_id":"","url":"https://api.github.com/users/hmrc","html_url":"https://github.com/hmrc","followers_url":"https://api.github.com/users/hmrc/followers","following_url":"https://api.github.com/users/hmrc/following{/other_user}","gists_url":"https://api.github.com/users/hmrc/gists{/gist_id}","starred_url":"https://api.github.com/users/hmrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmrc/subscriptions","organizations_url":"https://api.github.com/users/hmrc/orgs","repos_url":"https://api.github.com/users/hmrc/repos","events_url":"https://api.github.com/users/hmrc/events{/privacy}","received_events_url":"https://api.github.com/users/hmrc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hmrc/self-assessment-api","description":null,"fork":false,"url":"https://api.github.com/repos/hmrc/self-assessment-api","forks_url":"https://api.github.com/repos/hmrc/self-assessment-api/forks","keys_url":"https://api.github.com/repos/hmrc/self-assessment-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hmrc/self-assessment-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hmrc/self-assessment-api/teams","hooks_url":"https://api.github.com/repos/hmrc/self-assessment-api/hooks","issue_events_url":"https://api.github.com/repos/hmrc/self-assessment-api/issues/events{/number}","events_url":"https://api.github.com/repos/hmrc/self-assessment-api/events","assignees_url":"https://api.github.com/repos/hmrc/self-assessment-api/assignees{/user}","branches_url":"https://api.github.com/repos/hmrc/self-assessment-api/branches{/branch}","tags_url":"https://api.github.com/repos/hmrc/self-assessment-api/tags","blobs_url":"https://api.github.com/repos/hmrc/self-assessment-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hmrc/self-assessment-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hmrc/self-assessment-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/hmrc/self-assessment-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hmrc/self-assessment-api/statuses/{sha}","languages_url":"https://api.github.com/repos/hmrc/self-assessment-api/languages","stargazers_url":"https://api.github.com/repos/hmrc/self-assessment-api/stargazers","contributors_url":"https://api.github.com/repos/hmrc/self-assessment-api/contributors","subscribers_url":"https://api.github.com/repos/hmrc/self-assessment-api/subscribers","subscription_url":"https://api.github.com/repos/hmrc/self-assessment-api/subscription","commits_url":"https://api.github.com/repos/hmrc/self-assessment-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/hmrc/self-assessment-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/hmrc/self-assessment-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/hmrc/self-assessment-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/hmrc/self-assessment-api/contents/{+path}","compare_url":"https://api.github.com/repos/hmrc/self-assessment-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hmrc/self-assessment-api/merges","archive_url":"https://api.github.com/repos/hmrc/self-assessment-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hmrc/self-assessment-api/downloads","issues_url":"https://api.github.com/repos/hmrc/self-assessment-api/issues{/number}","pulls_url":"https://api.github.com/repos/hmrc/self-assessment-api/pulls{/number}","milestones_url":"https://api.github.com/repos/hmrc/self-assessment-api/milestones{/number}","notifications_url":"https://api.github.com/repos/hmrc/self-assessment-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hmrc/self-assessment-api/labels{/name}","releases_url":"https://api.github.com/repos/hmrc/self-assessment-api/releases{/id}","deployments_url":"https://api.github.com/repos/hmrc/self-assessment-api/deployments","created_at":"2016-04-18T11:01:56Z","updated_at":"2018-05-04T15:10:11Z","pushed_at":"2018-05-04T15:31:18Z","git_url":"git://github.com/hmrc/self-assessment-api.git","ssh_url":"[email protected]:hmrc/self-assessment-api.git","clone_url":"https://github.com/hmrc/self-assessment-api.git","svn_url":"https://github.com/hmrc/self-assessment-api","homepage":"","size":4887,"stargazers_count":11,"watchers_count":11,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":16,"open_issues":4,"watchers":11,"default_branch":"master"}},"base":{"label":"hmrc:master","ref":"master","sha":"15ec96275e9bb5aee707c37e4b5ba3b5207e19a1","user":{"login":"hmrc","id":5755339,"avatar_url":"https://avatars1.githubusercontent.com/u/5755339?v=4","gravatar_id":"","url":"https://api.github.com/users/hmrc","html_url":"https://github.com/hmrc","followers_url":"https://api.github.com/users/hmrc/followers","following_url":"https://api.github.com/users/hmrc/following{/other_user}","gists_url":"https://api.github.com/users/hmrc/gists{/gist_id}","starred_url":"https://api.github.com/users/hmrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmrc/subscriptions","organizations_url":"https://api.github.com/users/hmrc/orgs","repos_url":"https://api.github.com/users/hmrc/repos","events_url":"https://api.github.com/users/hmrc/events{/privacy}","received_events_url":"https://api.github.com/users/hmrc/received_events","type":"Organization","site_admin":false},"repo":{"id":56500706,"name":"self-assessment-api","full_name":"hmrc/self-assessment-api","owner":{"login":"hmrc","id":5755339,"avatar_url":"https://avatars1.githubusercontent.com/u/5755339?v=4","gravatar_id":"","url":"https://api.github.com/users/hmrc","html_url":"https://github.com/hmrc","followers_url":"https://api.github.com/users/hmrc/followers","following_url":"https://api.github.com/users/hmrc/following{/other_user}","gists_url":"https://api.github.com/users/hmrc/gists{/gist_id}","starred_url":"https://api.github.com/users/hmrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmrc/subscriptions","organizations_url":"https://api.github.com/users/hmrc/orgs","repos_url":"https://api.github.com/users/hmrc/repos","events_url":"https://api.github.com/users/hmrc/events{/privacy}","received_events_url":"https://api.github.com/users/hmrc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hmrc/self-assessment-api","description":null,"fork":false,"url":"https://api.github.com/repos/hmrc/self-assessment-api","forks_url":"https://api.github.com/repos/hmrc/self-assessment-api/forks","keys_url":"https://api.github.com/repos/hmrc/self-assessment-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hmrc/self-assessment-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hmrc/self-assessment-api/teams","hooks_url":"https://api.github.com/repos/hmrc/self-assessment-api/hooks","issue_events_url":"https://api.github.com/repos/hmrc/self-assessment-api/issues/events{/number}","events_url":"https://api.github.com/repos/hmrc/self-assessment-api/events","assignees_url":"https://api.github.com/repos/hmrc/self-assessment-api/assignees{/user}","branches_url":"https://api.github.com/repos/hmrc/self-assessment-api/branches{/branch}","tags_url":"https://api.github.com/repos/hmrc/self-assessment-api/tags","blobs_url":"https://api.github.com/repos/hmrc/self-assessment-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hmrc/self-assessment-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hmrc/self-assessment-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/hmrc/self-assessment-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hmrc/self-assessment-api/statuses/{sha}","languages_url":"https://api.github.com/repos/hmrc/self-assessment-api/languages","stargazers_url":"https://api.github.com/repos/hmrc/self-assessment-api/stargazers","contributors_url":"https://api.github.com/repos/hmrc/self-assessment-api/contributors","subscribers_url":"https://api.github.com/repos/hmrc/self-assessment-api/subscribers","subscription_url":"https://api.github.com/repos/hmrc/self-assessment-api/subscription","commits_url":"https://api.github.com/repos/hmrc/self-assessment-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/hmrc/self-assessment-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/hmrc/self-assessment-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/hmrc/self-assessment-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/hmrc/self-assessment-api/contents/{+path}","compare_url":"https://api.github.com/repos/hmrc/self-assessment-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hmrc/self-assessment-api/merges","archive_url":"https://api.github.com/repos/hmrc/self-assessment-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hmrc/self-assessment-api/downloads","issues_url":"https://api.github.com/repos/hmrc/self-assessment-api/issues{/number}","pulls_url":"https://api.github.com/repos/hmrc/self-assessment-api/pulls{/number}","milestones_url":"https://api.github.com/repos/hmrc/self-assessment-api/milestones{/number}","notifications_url":"https://api.github.com/repos/hmrc/self-assessment-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hmrc/self-assessment-api/labels{/name}","releases_url":"https://api.github.com/repos/hmrc/self-assessment-api/releases{/id}","deployments_url":"https://api.github.com/repos/hmrc/self-assessment-api/deployments","created_at":"2016-04-18T11:01:56Z","updated_at":"2018-05-04T15:10:11Z","pushed_at":"2018-05-04T15:31:18Z","git_url":"git://github.com/hmrc/self-assessment-api.git","ssh_url":"[email protected]:hmrc/self-assessment-api.git","clone_url":"https://github.com/hmrc/self-assessment-api.git","svn_url":"https://github.com/hmrc/self-assessment-api","homepage":"","size":4887,"stargazers_count":11,"watchers_count":11,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":16,"open_issues":4,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hmrc/self-assessment-api/pulls/601"},"html":{"href":"https://github.com/hmrc/self-assessment-api/pull/601"},"issue":{"href":"https://api.github.com/repos/hmrc/self-assessment-api/issues/601"},"comments":{"href":"https://api.github.com/repos/hmrc/self-assessment-api/issues/601/comments"},"review_comments":{"href":"https://api.github.com/repos/hmrc/self-assessment-api/pulls/601/comments"},"review_comment":{"href":"https://api.github.com/repos/hmrc/self-assessment-api/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hmrc/self-assessment-api/pulls/601/commits"},"statuses":{"href":"https://api.github.com/repos/hmrc/self-assessment-api/statuses/d6633b8490daa1d3dd88f2b0d5907ca2c3c75362"}},"author_association":"CONTRIBUTOR"}} | {
"id": 56500706,
"name": "hmrc/self-assessment-api",
"url": "https://api.github.com/repos/hmrc/self-assessment-api"
} | {
"id": 14073782,
"login": "westwater",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/14073782?",
"url": "https://api.github.com/users/westwater"
} | {
"id": 5755339,
"login": "hmrc",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5755339?",
"url": "https://api.github.com/orgs/hmrc"
} | 2018-05-04T15:33:34 | 7629280380 | {"actor":{"display_login":"westwater"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/hmrc/self-assessment-api/pulls/comments/182432144","pull_request_review_id":113224779,"id":182432144,"diff_hunk":"@@ -37,8 +37,13 @@ case class SelfEmploymentStatementResponse(underlying: HttpResponse) extends Res\n errorMessage = \"Obligation for source id and/or business type was not found.\"\n val result = for {\n obl <- obligation.obligations\n- if obl.id.contains(id) && obl.`type` == incomeSourceType\n- details <- obl.details\n+ if (obl.identification.referenceNumber == refNumber) && obl.identification.incomeSourceType.contains(incomeSourceType)","path":"app/uk/gov/hmrc/selfassessmentapi/resources/wrappers/SelfEmploymentStatementResponse.scala","position":15,"original_position":15,"commit_id":"4c18f9b92924fab1dca135a47865e7c3d73c7dfb","original_commit_id":"47cc250adb13826656b00b6131fe04304bec3fcb","user":{"login":"narendravijayarao","id":26090262,"avatar_url":"https://avatars3.githubusercontent.com/u/26090262?v=4","gravatar_id":"","url":"https://api.github.com/users/narendravijayarao","html_url":"https://github.com/narendravijayarao","followers_url":"https://api.github.com/users/narendravijayarao/followers","following_url":"https://api.github.com/users/narendravijayarao/following{/other_user}","gists_url":"https://api.github.com/users/narendravijayarao/gists{/gist_id}","starred_url":"https://api.github.com/users/narendravijayarao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/narendravijayarao/subscriptions","organizations_url":"https://api.github.com/users/narendravijayarao/orgs","repos_url":"https://api.github.com/users/narendravijayarao/repos","events_url":"https://api.github.com/users/narendravijayarao/events{/privacy}","received_events_url":"https://api.github.com/users/narendravijayarao/received_events","type":"User","site_admin":false},"body":"same as above--- this condition needs to be modified, bcoz identification is optional as per the DES spec and we are populating ObligationDetails based on the identification. Better check if the ObligationDetails is nonEmpty","created_at":"2018-04-18T13:47:49Z","updated_at":"2018-04-18T14:02:43Z","html_url":"https://github.com/hmrc/self-assessment-api/pull/593#discussion_r182432144","pull_request_url":"https://api.github.com/repos/hmrc/self-assessment-api/pulls/593","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/hmrc/self-assessment-api/pulls/comments/182432144"},"html":{"href":"https://github.com/hmrc/self-assessment-api/pull/593#discussion_r182432144"},"pull_request":{"href":"https://api.github.com/repos/hmrc/self-assessment-api/pulls/593"}}},"pull_request":{"url":"https://api.github.com/repos/hmrc/self-assessment-api/pulls/593","id":180535731,"html_url":"https://github.com/hmrc/self-assessment-api/pull/593","diff_url":"https://github.com/hmrc/self-assessment-api/pull/593.diff","patch_url":"https://github.com/hmrc/self-assessment-api/pull/593.patch","issue_url":"https://api.github.com/repos/hmrc/self-assessment-api/issues/593","number":593,"state":"open","locked":false,"title":"[MTDSA-1440] make obligations endpoints generic","user":{"login":"MarkAKelly","id":21219364,"avatar_url":"https://avatars2.githubusercontent.com/u/21219364?v=4","gravatar_id":"","url":"https://api.github.com/users/MarkAKelly","html_url":"https://github.com/MarkAKelly","followers_url":"https://api.github.com/users/MarkAKelly/followers","following_url":"https://api.github.com/users/MarkAKelly/following{/other_user}","gists_url":"https://api.github.com/users/MarkAKelly/gists{/gist_id}","starred_url":"https://api.github.com/users/MarkAKelly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarkAKelly/subscriptions","organizations_url":"https://api.github.com/users/MarkAKelly/orgs","repos_url":"https://api.github.com/users/MarkAKelly/repos","events_url":"https://api.github.com/users/MarkAKelly/events{/privacy}","received_events_url":"https://api.github.com/users/MarkAKelly/received_events","type":"User","site_admin":false},"body":"Please check if this change includes (or even requires) the following:\r\n\r\n - [ ] unit tests\r\n - [ ] functional tests\r\n - [ ] audit events\r\n - [ ] RAML documentation\r\n - [ ] logging\r\n","created_at":"2018-04-10T09:10:09Z","updated_at":"2018-04-18T14:02:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a70ff2aea79c5783ed25d3ac9c7bd5ccf4e388ce","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/hmrc/self-assessment-api/pulls/593/commits","review_comments_url":"https://api.github.com/repos/hmrc/self-assessment-api/pulls/593/comments","review_comment_url":"https://api.github.com/repos/hmrc/self-assessment-api/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hmrc/self-assessment-api/issues/593/comments","statuses_url":"https://api.github.com/repos/hmrc/self-assessment-api/statuses/4c18f9b92924fab1dca135a47865e7c3d73c7dfb","head":{"label":"hmrc:MTDSA-1440","ref":"MTDSA-1440","sha":"4c18f9b92924fab1dca135a47865e7c3d73c7dfb","user":{"login":"hmrc","id":5755339,"avatar_url":"https://avatars1.githubusercontent.com/u/5755339?v=4","gravatar_id":"","url":"https://api.github.com/users/hmrc","html_url":"https://github.com/hmrc","followers_url":"https://api.github.com/users/hmrc/followers","following_url":"https://api.github.com/users/hmrc/following{/other_user}","gists_url":"https://api.github.com/users/hmrc/gists{/gist_id}","starred_url":"https://api.github.com/users/hmrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmrc/subscriptions","organizations_url":"https://api.github.com/users/hmrc/orgs","repos_url":"https://api.github.com/users/hmrc/repos","events_url":"https://api.github.com/users/hmrc/events{/privacy}","received_events_url":"https://api.github.com/users/hmrc/received_events","type":"Organization","site_admin":false},"repo":{"id":56500706,"name":"self-assessment-api","full_name":"hmrc/self-assessment-api","owner":{"login":"hmrc","id":5755339,"avatar_url":"https://avatars1.githubusercontent.com/u/5755339?v=4","gravatar_id":"","url":"https://api.github.com/users/hmrc","html_url":"https://github.com/hmrc","followers_url":"https://api.github.com/users/hmrc/followers","following_url":"https://api.github.com/users/hmrc/following{/other_user}","gists_url":"https://api.github.com/users/hmrc/gists{/gist_id}","starred_url":"https://api.github.com/users/hmrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmrc/subscriptions","organizations_url":"https://api.github.com/users/hmrc/orgs","repos_url":"https://api.github.com/users/hmrc/repos","events_url":"https://api.github.com/users/hmrc/events{/privacy}","received_events_url":"https://api.github.com/users/hmrc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hmrc/self-assessment-api","description":null,"fork":false,"url":"https://api.github.com/repos/hmrc/self-assessment-api","forks_url":"https://api.github.com/repos/hmrc/self-assessment-api/forks","keys_url":"https://api.github.com/repos/hmrc/self-assessment-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hmrc/self-assessment-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hmrc/self-assessment-api/teams","hooks_url":"https://api.github.com/repos/hmrc/self-assessment-api/hooks","issue_events_url":"https://api.github.com/repos/hmrc/self-assessment-api/issues/events{/number}","events_url":"https://api.github.com/repos/hmrc/self-assessment-api/events","assignees_url":"https://api.github.com/repos/hmrc/self-assessment-api/assignees{/user}","branches_url":"https://api.github.com/repos/hmrc/self-assessment-api/branches{/branch}","tags_url":"https://api.github.com/repos/hmrc/self-assessment-api/tags","blobs_url":"https://api.github.com/repos/hmrc/self-assessment-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hmrc/self-assessment-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hmrc/self-assessment-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/hmrc/self-assessment-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hmrc/self-assessment-api/statuses/{sha}","languages_url":"https://api.github.com/repos/hmrc/self-assessment-api/languages","stargazers_url":"https://api.github.com/repos/hmrc/self-assessment-api/stargazers","contributors_url":"https://api.github.com/repos/hmrc/self-assessment-api/contributors","subscribers_url":"https://api.github.com/repos/hmrc/self-assessment-api/subscribers","subscription_url":"https://api.github.com/repos/hmrc/self-assessment-api/subscription","commits_url":"https://api.github.com/repos/hmrc/self-assessment-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/hmrc/self-assessment-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/hmrc/self-assessment-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/hmrc/self-assessment-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/hmrc/self-assessment-api/contents/{+path}","compare_url":"https://api.github.com/repos/hmrc/self-assessment-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hmrc/self-assessment-api/merges","archive_url":"https://api.github.com/repos/hmrc/self-assessment-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hmrc/self-assessment-api/downloads","issues_url":"https://api.github.com/repos/hmrc/self-assessment-api/issues{/number}","pulls_url":"https://api.github.com/repos/hmrc/self-assessment-api/pulls{/number}","milestones_url":"https://api.github.com/repos/hmrc/self-assessment-api/milestones{/number}","notifications_url":"https://api.github.com/repos/hmrc/self-assessment-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hmrc/self-assessment-api/labels{/name}","releases_url":"https://api.github.com/repos/hmrc/self-assessment-api/releases{/id}","deployments_url":"https://api.github.com/repos/hmrc/self-assessment-api/deployments","created_at":"2016-04-18T11:01:56Z","updated_at":"2018-04-10T11:12:18Z","pushed_at":"2018-04-18T12:59:50Z","git_url":"git://github.com/hmrc/self-assessment-api.git","ssh_url":"[email protected]:hmrc/self-assessment-api.git","clone_url":"https://github.com/hmrc/self-assessment-api.git","svn_url":"https://github.com/hmrc/self-assessment-api","homepage":"","size":4918,"stargazers_count":11,"watchers_count":11,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":17,"open_issues":4,"watchers":11,"default_branch":"master"}},"base":{"label":"hmrc:master","ref":"master","sha":"e2b2aef437220a32273fe3f7a9e4907d2d96fdcc","user":{"login":"hmrc","id":5755339,"avatar_url":"https://avatars1.githubusercontent.com/u/5755339?v=4","gravatar_id":"","url":"https://api.github.com/users/hmrc","html_url":"https://github.com/hmrc","followers_url":"https://api.github.com/users/hmrc/followers","following_url":"https://api.github.com/users/hmrc/following{/other_user}","gists_url":"https://api.github.com/users/hmrc/gists{/gist_id}","starred_url":"https://api.github.com/users/hmrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmrc/subscriptions","organizations_url":"https://api.github.com/users/hmrc/orgs","repos_url":"https://api.github.com/users/hmrc/repos","events_url":"https://api.github.com/users/hmrc/events{/privacy}","received_events_url":"https://api.github.com/users/hmrc/received_events","type":"Organization","site_admin":false},"repo":{"id":56500706,"name":"self-assessment-api","full_name":"hmrc/self-assessment-api","owner":{"login":"hmrc","id":5755339,"avatar_url":"https://avatars1.githubusercontent.com/u/5755339?v=4","gravatar_id":"","url":"https://api.github.com/users/hmrc","html_url":"https://github.com/hmrc","followers_url":"https://api.github.com/users/hmrc/followers","following_url":"https://api.github.com/users/hmrc/following{/other_user}","gists_url":"https://api.github.com/users/hmrc/gists{/gist_id}","starred_url":"https://api.github.com/users/hmrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmrc/subscriptions","organizations_url":"https://api.github.com/users/hmrc/orgs","repos_url":"https://api.github.com/users/hmrc/repos","events_url":"https://api.github.com/users/hmrc/events{/privacy}","received_events_url":"https://api.github.com/users/hmrc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hmrc/self-assessment-api","description":null,"fork":false,"url":"https://api.github.com/repos/hmrc/self-assessment-api","forks_url":"https://api.github.com/repos/hmrc/self-assessment-api/forks","keys_url":"https://api.github.com/repos/hmrc/self-assessment-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hmrc/self-assessment-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hmrc/self-assessment-api/teams","hooks_url":"https://api.github.com/repos/hmrc/self-assessment-api/hooks","issue_events_url":"https://api.github.com/repos/hmrc/self-assessment-api/issues/events{/number}","events_url":"https://api.github.com/repos/hmrc/self-assessment-api/events","assignees_url":"https://api.github.com/repos/hmrc/self-assessment-api/assignees{/user}","branches_url":"https://api.github.com/repos/hmrc/self-assessment-api/branches{/branch}","tags_url":"https://api.github.com/repos/hmrc/self-assessment-api/tags","blobs_url":"https://api.github.com/repos/hmrc/self-assessment-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hmrc/self-assessment-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hmrc/self-assessment-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/hmrc/self-assessment-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hmrc/self-assessment-api/statuses/{sha}","languages_url":"https://api.github.com/repos/hmrc/self-assessment-api/languages","stargazers_url":"https://api.github.com/repos/hmrc/self-assessment-api/stargazers","contributors_url":"https://api.github.com/repos/hmrc/self-assessment-api/contributors","subscribers_url":"https://api.github.com/repos/hmrc/self-assessment-api/subscribers","subscription_url":"https://api.github.com/repos/hmrc/self-assessment-api/subscription","commits_url":"https://api.github.com/repos/hmrc/self-assessment-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/hmrc/self-assessment-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/hmrc/self-assessment-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/hmrc/self-assessment-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/hmrc/self-assessment-api/contents/{+path}","compare_url":"https://api.github.com/repos/hmrc/self-assessment-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hmrc/self-assessment-api/merges","archive_url":"https://api.github.com/repos/hmrc/self-assessment-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hmrc/self-assessment-api/downloads","issues_url":"https://api.github.com/repos/hmrc/self-assessment-api/issues{/number}","pulls_url":"https://api.github.com/repos/hmrc/self-assessment-api/pulls{/number}","milestones_url":"https://api.github.com/repos/hmrc/self-assessment-api/milestones{/number}","notifications_url":"https://api.github.com/repos/hmrc/self-assessment-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hmrc/self-assessment-api/labels{/name}","releases_url":"https://api.github.com/repos/hmrc/self-assessment-api/releases{/id}","deployments_url":"https://api.github.com/repos/hmrc/self-assessment-api/deployments","created_at":"2016-04-18T11:01:56Z","updated_at":"2018-04-10T11:12:18Z","pushed_at":"2018-04-18T12:59:50Z","git_url":"git://github.com/hmrc/self-assessment-api.git","ssh_url":"[email protected]:hmrc/self-assessment-api.git","clone_url":"https://github.com/hmrc/self-assessment-api.git","svn_url":"https://github.com/hmrc/self-assessment-api","homepage":"","size":4918,"stargazers_count":11,"watchers_count":11,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":17,"open_issues":4,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hmrc/self-assessment-api/pulls/593"},"html":{"href":"https://github.com/hmrc/self-assessment-api/pull/593"},"issue":{"href":"https://api.github.com/repos/hmrc/self-assessment-api/issues/593"},"comments":{"href":"https://api.github.com/repos/hmrc/self-assessment-api/issues/593/comments"},"review_comments":{"href":"https://api.github.com/repos/hmrc/self-assessment-api/pulls/593/comments"},"review_comment":{"href":"https://api.github.com/repos/hmrc/self-assessment-api/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hmrc/self-assessment-api/pulls/593/commits"},"statuses":{"href":"https://api.github.com/repos/hmrc/self-assessment-api/statuses/4c18f9b92924fab1dca135a47865e7c3d73c7dfb"}},"author_association":"CONTRIBUTOR"}} | {
"id": 56500706,
"name": "hmrc/self-assessment-api",
"url": "https://api.github.com/repos/hmrc/self-assessment-api"
} | {
"id": 26090262,
"login": "narendravijayarao",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/26090262?",
"url": "https://api.github.com/users/narendravijayarao"
} | {
"id": 5755339,
"login": "hmrc",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5755339?",
"url": "https://api.github.com/orgs/hmrc"
} | 2018-04-18T13:47:49 | 7549354782 | {"actor":{"display_login":"narendravijayarao"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/DFHack/dfhack/pulls/comments/196157743","pull_request_review_id":129657917,"id":196157743,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NjE1Nzc0Mw==","diff_hunk":"@@ -232,4 +234,299 @@ namespace DFHack\n m_data[idx] = item;\n }\n };\n+\n+ template <typename L, typename I>\n+ struct DfLinkedList\n+ {\n+ class iterator;\n+ class const_iterator;\n+\n+ class proxy\n+ {\n+ L *root;\n+ L *prev;\n+ friend class iterator;\n+ proxy(L *root, L *prev) : root(root), prev(prev)\n+ {\n+ CHECK_NULL_POINTER(root);\n+ CHECK_NULL_POINTER(prev);\n+ }\n+\n+ public:\n+ operator I * & ()\n+ {\n+ CHECK_NULL_POINTER(prev->next);\n+ return prev->next->item;\n+ }\n+ operator I *() const\n+ {\n+ CHECK_NULL_POINTER(prev->next);\n+ return prev->next->item;\n+ }\n+ I *operator->() const\n+ {\n+ CHECK_NULL_POINTER(prev->next);\n+ return prev->next->item;\n+ }\n+ proxy & operator=(I *item)\n+ {\n+ if (!prev->next)\n+ {\n+ prev->next = df::allocate<L>();\n+ if (prev != root)\n+ prev->next->prev = prev;\n+ }\n+ prev->next->item = item;\n+ return *this;\n+ }\n+ };\n+\n+ class iterator\n+ {\n+ L *root;\n+ L *prev;\n+ bool next;\n+ friend struct DfLinkedList<L, I>;\n+ friend class const_iterator;\n+ iterator() : root(nullptr), prev(nullptr), next(false) {}\n+ public:\n+ using difference_type = void;\n+ using value_type = I *;\n+ using pointer = I **;\n+ using reference = proxy;\n+ using iterator_category = std::output_iterator_tag;\n+\n+ iterator(L *root, L *prev, bool next = false) : root(root), prev(prev), next(next) {}\n+ iterator(const iterator & other) : root(other.root), prev(other.prev), next(other.next) {}\n+\n+ iterator & operator++()\n+ {\n+ CHECK_NULL_POINTER(root);\n+\n+ CHECK_NULL_POINTER(prev);\n+ CHECK_NULL_POINTER(prev->next);\n+\n+ if (!next && !prev->next->next)\n+ {\n+ next = true;\n+ return *this;\n+ }\n+\n+ CHECK_NULL_POINTER(prev->next->next);\n+\n+ prev = prev->next;\n+ return *this;\n+ }\n+ iterator & operator--()\n+ {\n+ CHECK_NULL_POINTER(root);\n+\n+ if (next)\n+ {\n+ next = false;\n+ return *this;\n+ }\n+\n+ CHECK_NULL_POINTER(prev);\n+ if (prev == root)\n+ {\n+ throw DFHack::Error::NullPointer(\"prev->prev\", DFHACK_FUNCTION_SIG);\n+ }\n+\n+ if (root->next == prev)\n+ {\n+ prev = root;\n+ return *this;\n+ }\n+\n+ if (prev->prev)\n+ {\n+ prev = prev->prev;\n+ return *this;\n+ }\n+\n+ for (L *it = root; it->next; it = it->next)\n+ {\n+ if (it->next == prev)\n+ {\n+ prev = it;\n+ return *this;\n+ }\n+ }\n+\n+ throw DFHack::Error::NullPointer(\"prev->prev\", DFHACK_FUNCTION_SIG);\n+ }\n+ iterator operator++(int)\n+ {\n+ iterator copy(*this);\n+ ++*this;\n+ return copy;\n+ }\n+ iterator operator--(int)\n+ {\n+ iterator copy(*this);\n+ --*this;\n+ return copy;\n+ }\n+ iterator & operator=(const iterator & other)\n+ {\n+ root = other.root;\n+ prev = other.prev;\n+ next = other.next;\n+ return *this;\n+ }\n+\n+ proxy operator*()\n+ {\n+ CHECK_NULL_POINTER(prev);\n+ CHECK_NULL_POINTER(prev->next);\n+\n+ if (next)\n+ return proxy(root, prev->next);\n+\n+ return proxy(root, prev);\n+ }\n+\n+ const proxy operator*() const\n+ {\n+ CHECK_NULL_POINTER(prev);\n+ CHECK_NULL_POINTER(prev->next);\n+\n+ if (next)\n+ return proxy(root, prev->next);\n+\n+ return proxy(root, prev);\n+ }\n+\n+ I * operator->() const\n+ {\n+ return **this;\n+ }\n+\n+ operator const_iterator() const\n+ {\n+ return const_iterator(*this);\n+ }\n+ bool operator==(const iterator & other) const\n+ {\n+ if (root != other.root)\n+ return false;\n+\n+ if (other.next && !next)\n+ return prev && other.prev && prev->next == other.prev;\n+ if (next && !other.next)\n+ return prev && other.prev && other.prev->next == prev;\n+ return other.prev == prev;\n+ }\n+ bool operator!=(const iterator & other) const\n+ {\n+ return !(*this == other);\n+ }\n+ };\n+ class const_iterator\n+ {\n+ iterator iter;\n+ friend struct DfLinkedList<L, I>;\n+ public:\n+ using difference_type = void;\n+ using value_type = I * ;\n+ using pointer = I * const *;\n+ using reference = const proxy;\n+ using iterator_category = std::bidirectional_iterator_tag;\n+\n+ const_iterator(const iterator & iter) : iter(iter) {}\n+ const_iterator(const const_iterator & other) : iter(other.iter) {}\n+\n+ const_iterator & operator++()\n+ {\n+ ++iter;\n+ return *this;\n+ }\n+ const_iterator & operator--()\n+ {\n+ --iter;\n+ return *this;\n+ }\n+ const_iterator operator++(int)\n+ {\n+ const_iterator copy(*this);\n+ ++*this;\n+ return copy;\n+ }\n+ const_iterator operator--(int)\n+ {\n+ const_iterator copy(*this);\n+ --*this;\n+ return copy;\n+ }\n+ const_iterator & operator=(const const_iterator & other)\n+ {\n+ iter = other.iter;\n+ return *this;\n+ }\n+ const proxy operator*() const\n+ {\n+ return *iter;\n+ }\n+ I *operator->() const\n+ {\n+ return *iter;\n+ }\n+ bool operator==(const const_iterator & other) const\n+ {\n+ return iter == other.iter;\n+ }\n+ bool operator!=(const const_iterator & other) const\n+ {\n+ return iter != other.iter;\n+ }\n+ };\n+\n+ typedef I *value_type;\n+ typedef I * & reference_type;\n+ typedef void difference_type;\n+ typedef size_t size_type;\n+\n+ bool empty() const\n+ {\n+ return static_cast<const L *>(this)->next == nullptr;\n+ }\n+ size_t size() const\n+ {\n+ size_t n = 0;\n+ for (I *i : *this)\n+ n++;\n+ return n;\n+ }\n+\n+ iterator begin()\n+ {\n+ return iterator(static_cast<L *>(this), static_cast<L *>(this));\n+ }\n+ const_iterator begin() const\n+ {\n+ return const_iterator(const_cast<DfLinkedList<L, I> *>(this)->begin());\n+ }\n+ const_iterator cbegin() const\n+ {\n+ return begin();\n+ }\n+ iterator end()\n+ {\n+ L *it = static_cast<L *>(this);\n+ while (it->next && it->next->next)\n+ {\n+ it = it->next;\n+ }\n+ return iterator(static_cast<L *>(this), it, true);\n+ }","path":"library/include/BitArray.h","position":305,"original_position":305,"commit_id":"e8535b6686f9e020fc0e71163fad19a2e46d5794","original_commit_id":"e8535b6686f9e020fc0e71163fad19a2e46d5794","user":{"login":"suokko","id":113864,"node_id":"MDQ6VXNlcjExMzg2NA==","avatar_url":"https://avatars3.githubusercontent.com/u/113864?v=4","gravatar_id":"","url":"https://api.github.com/users/suokko","html_url":"https://github.com/suokko","followers_url":"https://api.github.com/users/suokko/followers","following_url":"https://api.github.com/users/suokko/following{/other_user}","gists_url":"https://api.github.com/users/suokko/gists{/gist_id}","starred_url":"https://api.github.com/users/suokko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/suokko/subscriptions","organizations_url":"https://api.github.com/users/suokko/orgs","repos_url":"https://api.github.com/users/suokko/repos","events_url":"https://api.github.com/users/suokko/events{/privacy}","received_events_url":"https://api.github.com/users/suokko/received_events","type":"User","site_admin":false},"body":"dflist is double linked list expect its root isn't correctly linked to end and begin. But if we would provide only forward iterator and simple implement `begin() { return iterator(root->next)}` and `end() {return iterator(nullptr);}` and adapt iterator to simple keep pointer to df::list_link. Then end iterator would compare equal only when iterator has been increment one past the end.","created_at":"2018-06-18T17:18:06Z","updated_at":"2018-06-18T17:18:06Z","html_url":"https://github.com/DFHack/dfhack/pull/1312#discussion_r196157743","pull_request_url":"https://api.github.com/repos/DFHack/dfhack/pulls/1312","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/DFHack/dfhack/pulls/comments/196157743"},"html":{"href":"https://github.com/DFHack/dfhack/pull/1312#discussion_r196157743"},"pull_request":{"href":"https://api.github.com/repos/DFHack/dfhack/pulls/1312"}},"in_reply_to_id":196153964},"pull_request":{"url":"https://api.github.com/repos/DFHack/dfhack/pulls/1312","id":195351864,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1MzUxODY0","html_url":"https://github.com/DFHack/dfhack/pull/1312","diff_url":"https://github.com/DFHack/dfhack/pull/1312.diff","patch_url":"https://github.com/DFHack/dfhack/pull/1312.patch","issue_url":"https://api.github.com/repos/DFHack/dfhack/issues/1312","number":1312,"state":"open","locked":false,"title":"Linked list","user":{"login":"BenLubar","id":4257305,"node_id":"MDQ6VXNlcjQyNTczMDU=","avatar_url":"https://avatars3.githubusercontent.com/u/4257305?v=4","gravatar_id":"","url":"https://api.github.com/users/BenLubar","html_url":"https://github.com/BenLubar","followers_url":"https://api.github.com/users/BenLubar/followers","following_url":"https://api.github.com/users/BenLubar/following{/other_user}","gists_url":"https://api.github.com/users/BenLubar/gists{/gist_id}","starred_url":"https://api.github.com/users/BenLubar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BenLubar/subscriptions","organizations_url":"https://api.github.com/users/BenLubar/orgs","repos_url":"https://api.github.com/users/BenLubar/repos","events_url":"https://api.github.com/users/BenLubar/events{/privacy}","received_events_url":"https://api.github.com/users/BenLubar/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-06-16T22:30:49Z","updated_at":"2018-06-18T17:18:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"de05493b0273106e83d4da9d997c46b880334519","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/DFHack/dfhack/pulls/1312/commits","review_comments_url":"https://api.github.com/repos/DFHack/dfhack/pulls/1312/comments","review_comment_url":"https://api.github.com/repos/DFHack/dfhack/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DFHack/dfhack/issues/1312/comments","statuses_url":"https://api.github.com/repos/DFHack/dfhack/statuses/e8535b6686f9e020fc0e71163fad19a2e46d5794","head":{"label":"BenLubar:linked-list","ref":"linked-list","sha":"e8535b6686f9e020fc0e71163fad19a2e46d5794","user":{"login":"BenLubar","id":4257305,"node_id":"MDQ6VXNlcjQyNTczMDU=","avatar_url":"https://avatars3.githubusercontent.com/u/4257305?v=4","gravatar_id":"","url":"https://api.github.com/users/BenLubar","html_url":"https://github.com/BenLubar","followers_url":"https://api.github.com/users/BenLubar/followers","following_url":"https://api.github.com/users/BenLubar/following{/other_user}","gists_url":"https://api.github.com/users/BenLubar/gists{/gist_id}","starred_url":"https://api.github.com/users/BenLubar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BenLubar/subscriptions","organizations_url":"https://api.github.com/users/BenLubar/orgs","repos_url":"https://api.github.com/users/BenLubar/repos","events_url":"https://api.github.com/users/BenLubar/events{/privacy}","received_events_url":"https://api.github.com/users/BenLubar/received_events","type":"User","site_admin":false},"repo":{"id":19898758,"node_id":"MDEwOlJlcG9zaXRvcnkxOTg5ODc1OA==","name":"dfhack","full_name":"BenLubar/dfhack","owner":{"login":"BenLubar","id":4257305,"node_id":"MDQ6VXNlcjQyNTczMDU=","avatar_url":"https://avatars3.githubusercontent.com/u/4257305?v=4","gravatar_id":"","url":"https://api.github.com/users/BenLubar","html_url":"https://github.com/BenLubar","followers_url":"https://api.github.com/users/BenLubar/followers","following_url":"https://api.github.com/users/BenLubar/following{/other_user}","gists_url":"https://api.github.com/users/BenLubar/gists{/gist_id}","starred_url":"https://api.github.com/users/BenLubar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BenLubar/subscriptions","organizations_url":"https://api.github.com/users/BenLubar/orgs","repos_url":"https://api.github.com/users/BenLubar/repos","events_url":"https://api.github.com/users/BenLubar/events{/privacy}","received_events_url":"https://api.github.com/users/BenLubar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/BenLubar/dfhack","description":"Memory hacking library for Dwarf Fortress and a set of tools that use it","fork":true,"url":"https://api.github.com/repos/BenLubar/dfhack","forks_url":"https://api.github.com/repos/BenLubar/dfhack/forks","keys_url":"https://api.github.com/repos/BenLubar/dfhack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BenLubar/dfhack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BenLubar/dfhack/teams","hooks_url":"https://api.github.com/repos/BenLubar/dfhack/hooks","issue_events_url":"https://api.github.com/repos/BenLubar/dfhack/issues/events{/number}","events_url":"https://api.github.com/repos/BenLubar/dfhack/events","assignees_url":"https://api.github.com/repos/BenLubar/dfhack/assignees{/user}","branches_url":"https://api.github.com/repos/BenLubar/dfhack/branches{/branch}","tags_url":"https://api.github.com/repos/BenLubar/dfhack/tags","blobs_url":"https://api.github.com/repos/BenLubar/dfhack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BenLubar/dfhack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BenLubar/dfhack/git/refs{/sha}","trees_url":"https://api.github.com/repos/BenLubar/dfhack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BenLubar/dfhack/statuses/{sha}","languages_url":"https://api.github.com/repos/BenLubar/dfhack/languages","stargazers_url":"https://api.github.com/repos/BenLubar/dfhack/stargazers","contributors_url":"https://api.github.com/repos/BenLubar/dfhack/contributors","subscribers_url":"https://api.github.com/repos/BenLubar/dfhack/subscribers","subscription_url":"https://api.github.com/repos/BenLubar/dfhack/subscription","commits_url":"https://api.github.com/repos/BenLubar/dfhack/commits{/sha}","git_commits_url":"https://api.github.com/repos/BenLubar/dfhack/git/commits{/sha}","comments_url":"https://api.github.com/repos/BenLubar/dfhack/comments{/number}","issue_comment_url":"https://api.github.com/repos/BenLubar/dfhack/issues/comments{/number}","contents_url":"https://api.github.com/repos/BenLubar/dfhack/contents/{+path}","compare_url":"https://api.github.com/repos/BenLubar/dfhack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BenLubar/dfhack/merges","archive_url":"https://api.github.com/repos/BenLubar/dfhack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BenLubar/dfhack/downloads","issues_url":"https://api.github.com/repos/BenLubar/dfhack/issues{/number}","pulls_url":"https://api.github.com/repos/BenLubar/dfhack/pulls{/number}","milestones_url":"https://api.github.com/repos/BenLubar/dfhack/milestones{/number}","notifications_url":"https://api.github.com/repos/BenLubar/dfhack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BenLubar/dfhack/labels{/name}","releases_url":"https://api.github.com/repos/BenLubar/dfhack/releases{/id}","deployments_url":"https://api.github.com/repos/BenLubar/dfhack/deployments","created_at":"2014-05-17T23:38:10Z","updated_at":"2015-03-28T18:08:39Z","pushed_at":"2018-06-18T13:47:41Z","git_url":"git://github.com/BenLubar/dfhack.git","ssh_url":"[email protected]:BenLubar/dfhack.git","clone_url":"https://github.com/BenLubar/dfhack.git","svn_url":"https://github.com/BenLubar/dfhack","homepage":"","size":22027,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"DFHack:develop","ref":"develop","sha":"ca744139f065873b308a5e0c3f46753bcf039842","user":{"login":"DFHack","id":5777323,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU3NzczMjM=","avatar_url":"https://avatars2.githubusercontent.com/u/5777323?v=4","gravatar_id":"","url":"https://api.github.com/users/DFHack","html_url":"https://github.com/DFHack","followers_url":"https://api.github.com/users/DFHack/followers","following_url":"https://api.github.com/users/DFHack/following{/other_user}","gists_url":"https://api.github.com/users/DFHack/gists{/gist_id}","starred_url":"https://api.github.com/users/DFHack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DFHack/subscriptions","organizations_url":"https://api.github.com/users/DFHack/orgs","repos_url":"https://api.github.com/users/DFHack/repos","events_url":"https://api.github.com/users/DFHack/events{/privacy}","received_events_url":"https://api.github.com/users/DFHack/received_events","type":"Organization","site_admin":false},"repo":{"id":517990,"node_id":"MDEwOlJlcG9zaXRvcnk1MTc5OTA=","name":"dfhack","full_name":"DFHack/dfhack","owner":{"login":"DFHack","id":5777323,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU3NzczMjM=","avatar_url":"https://avatars2.githubusercontent.com/u/5777323?v=4","gravatar_id":"","url":"https://api.github.com/users/DFHack","html_url":"https://github.com/DFHack","followers_url":"https://api.github.com/users/DFHack/followers","following_url":"https://api.github.com/users/DFHack/following{/other_user}","gists_url":"https://api.github.com/users/DFHack/gists{/gist_id}","starred_url":"https://api.github.com/users/DFHack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DFHack/subscriptions","organizations_url":"https://api.github.com/users/DFHack/orgs","repos_url":"https://api.github.com/users/DFHack/repos","events_url":"https://api.github.com/users/DFHack/events{/privacy}","received_events_url":"https://api.github.com/users/DFHack/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DFHack/dfhack","description":"Memory hacking library for Dwarf Fortress and a set of tools that use it","fork":false,"url":"https://api.github.com/repos/DFHack/dfhack","forks_url":"https://api.github.com/repos/DFHack/dfhack/forks","keys_url":"https://api.github.com/repos/DFHack/dfhack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DFHack/dfhack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DFHack/dfhack/teams","hooks_url":"https://api.github.com/repos/DFHack/dfhack/hooks","issue_events_url":"https://api.github.com/repos/DFHack/dfhack/issues/events{/number}","events_url":"https://api.github.com/repos/DFHack/dfhack/events","assignees_url":"https://api.github.com/repos/DFHack/dfhack/assignees{/user}","branches_url":"https://api.github.com/repos/DFHack/dfhack/branches{/branch}","tags_url":"https://api.github.com/repos/DFHack/dfhack/tags","blobs_url":"https://api.github.com/repos/DFHack/dfhack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DFHack/dfhack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DFHack/dfhack/git/refs{/sha}","trees_url":"https://api.github.com/repos/DFHack/dfhack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DFHack/dfhack/statuses/{sha}","languages_url":"https://api.github.com/repos/DFHack/dfhack/languages","stargazers_url":"https://api.github.com/repos/DFHack/dfhack/stargazers","contributors_url":"https://api.github.com/repos/DFHack/dfhack/contributors","subscribers_url":"https://api.github.com/repos/DFHack/dfhack/subscribers","subscription_url":"https://api.github.com/repos/DFHack/dfhack/subscription","commits_url":"https://api.github.com/repos/DFHack/dfhack/commits{/sha}","git_commits_url":"https://api.github.com/repos/DFHack/dfhack/git/commits{/sha}","comments_url":"https://api.github.com/repos/DFHack/dfhack/comments{/number}","issue_comment_url":"https://api.github.com/repos/DFHack/dfhack/issues/comments{/number}","contents_url":"https://api.github.com/repos/DFHack/dfhack/contents/{+path}","compare_url":"https://api.github.com/repos/DFHack/dfhack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DFHack/dfhack/merges","archive_url":"https://api.github.com/repos/DFHack/dfhack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DFHack/dfhack/downloads","issues_url":"https://api.github.com/repos/DFHack/dfhack/issues{/number}","pulls_url":"https://api.github.com/repos/DFHack/dfhack/pulls{/number}","milestones_url":"https://api.github.com/repos/DFHack/dfhack/milestones{/number}","notifications_url":"https://api.github.com/repos/DFHack/dfhack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DFHack/dfhack/labels{/name}","releases_url":"https://api.github.com/repos/DFHack/dfhack/releases{/id}","deployments_url":"https://api.github.com/repos/DFHack/dfhack/deployments","created_at":"2010-02-14T21:09:49Z","updated_at":"2018-06-12T15:37:05Z","pushed_at":"2018-06-18T17:02:28Z","git_url":"git://github.com/DFHack/dfhack.git","ssh_url":"[email protected]:DFHack/dfhack.git","clone_url":"https://github.com/DFHack/dfhack.git","svn_url":"https://github.com/DFHack/dfhack","homepage":"","size":22016,"stargazers_count":793,"watchers_count":793,"language":"C++","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":276,"mirror_url":null,"archived":false,"open_issues_count":190,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":276,"open_issues":190,"watchers":793,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DFHack/dfhack/pulls/1312"},"html":{"href":"https://github.com/DFHack/dfhack/pull/1312"},"issue":{"href":"https://api.github.com/repos/DFHack/dfhack/issues/1312"},"comments":{"href":"https://api.github.com/repos/DFHack/dfhack/issues/1312/comments"},"review_comments":{"href":"https://api.github.com/repos/DFHack/dfhack/pulls/1312/comments"},"review_comment":{"href":"https://api.github.com/repos/DFHack/dfhack/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DFHack/dfhack/pulls/1312/commits"},"statuses":{"href":"https://api.github.com/repos/DFHack/dfhack/statuses/e8535b6686f9e020fc0e71163fad19a2e46d5794"}},"author_association":"MEMBER"}} | {
"id": 517990,
"name": "DFHack/dfhack",
"url": "https://api.github.com/repos/DFHack/dfhack"
} | {
"id": 113864,
"login": "suokko",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/113864?",
"url": "https://api.github.com/users/suokko"
} | {
"id": 5777323,
"login": "DFHack",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5777323?",
"url": "https://api.github.com/orgs/DFHack"
} | 2018-06-18T17:18:06 | 7840732799 | {"actor":{"display_login":"suokko"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/codecombat/codecombat/pulls/comments/204581098","pull_request_review_id":139685890,"id":204581098,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNDU4MTA5OA==","diff_hunk":"@@ -2467,7 +2470,7 @@ module.exports = nativeDescription: \"français\", englishDescription: \"French\", t\n # target_a_unit: \"Target a unit.\"\n # attack_capitalization: \"Attack $1, not $2. (Capital letters are important.)\"\n # empty_while: \"Empty while statement. Put 4 spaces in front of statements inside the while statement.\"\n- line_of_site: \"`$1`er argument `$2` a un problème. Y-a-t-il encore un ennemi dans votre ligne de mire?\"\n+# line_of_site: \"`$1`'s argument `$2` has a problem. Is there an enemy within your line-of-sight yet?\"","path":"app/locale/fr.coffee","position":143,"original_position":143,"commit_id":"69bcea5aa44e5a4e34af8caca71e105cd1fa3ca4","original_commit_id":"69bcea5aa44e5a4e34af8caca71e105cd1fa3ca4","user":{"login":"nwinter","id":99704,"node_id":"MDQ6VXNlcjk5NzA0","avatar_url":"https://avatars0.githubusercontent.com/u/99704?v=4","gravatar_id":"","url":"https://api.github.com/users/nwinter","html_url":"https://github.com/nwinter","followers_url":"https://api.github.com/users/nwinter/followers","following_url":"https://api.github.com/users/nwinter/following{/other_user}","gists_url":"https://api.github.com/users/nwinter/gists{/gist_id}","starred_url":"https://api.github.com/users/nwinter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nwinter/subscriptions","organizations_url":"https://api.github.com/users/nwinter/orgs","repos_url":"https://api.github.com/users/nwinter/repos","events_url":"https://api.github.com/users/nwinter/events{/privacy}","received_events_url":"https://api.github.com/users/nwinter/received_events","type":"User","site_admin":false},"body":"These two errors, also (section header still commented).","created_at":"2018-07-23T23:12:06Z","updated_at":"2018-07-23T23:12:52Z","html_url":"https://github.com/codecombat/codecombat/pull/4793#discussion_r204581098","pull_request_url":"https://api.github.com/repos/codecombat/codecombat/pulls/4793","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/codecombat/codecombat/pulls/comments/204581098"},"html":{"href":"https://github.com/codecombat/codecombat/pull/4793#discussion_r204581098"},"pull_request":{"href":"https://api.github.com/repos/codecombat/codecombat/pulls/4793"}}},"pull_request":{"url":"https://api.github.com/repos/codecombat/codecombat/pulls/4793","id":203367848,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzMzY3ODQ4","html_url":"https://github.com/codecombat/codecombat/pull/4793","diff_url":"https://github.com/codecombat/codecombat/pull/4793.diff","patch_url":"https://github.com/codecombat/codecombat/pull/4793.patch","issue_url":"https://api.github.com/repos/codecombat/codecombat/issues/4793","number":4793,"state":"open","locked":false,"title":"Propagate i18n","user":{"login":"chethana-sastry","id":40609596,"node_id":"MDQ6VXNlcjQwNjA5NTk2","avatar_url":"https://avatars0.githubusercontent.com/u/40609596?v=4","gravatar_id":"","url":"https://api.github.com/users/chethana-sastry","html_url":"https://github.com/chethana-sastry","followers_url":"https://api.github.com/users/chethana-sastry/followers","following_url":"https://api.github.com/users/chethana-sastry/following{/other_user}","gists_url":"https://api.github.com/users/chethana-sastry/gists{/gist_id}","starred_url":"https://api.github.com/users/chethana-sastry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chethana-sastry/subscriptions","organizations_url":"https://api.github.com/users/chethana-sastry/orgs","repos_url":"https://api.github.com/users/chethana-sastry/repos","events_url":"https://api.github.com/users/chethana-sastry/events{/privacy}","received_events_url":"https://api.github.com/users/chethana-sastry/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-07-23T23:06:46Z","updated_at":"2018-07-23T23:12:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7b2baf8893a014ea0cbb98dba6de61a519a2d1b5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/codecombat/codecombat/pulls/4793/commits","review_comments_url":"https://api.github.com/repos/codecombat/codecombat/pulls/4793/comments","review_comment_url":"https://api.github.com/repos/codecombat/codecombat/pulls/comments{/number}","comments_url":"https://api.github.com/repos/codecombat/codecombat/issues/4793/comments","statuses_url":"https://api.github.com/repos/codecombat/codecombat/statuses/69bcea5aa44e5a4e34af8caca71e105cd1fa3ca4","head":{"label":"codecombat:propagate-i18n","ref":"propagate-i18n","sha":"69bcea5aa44e5a4e34af8caca71e105cd1fa3ca4","user":{"login":"codecombat","id":5795842,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU3OTU4NDI=","avatar_url":"https://avatars2.githubusercontent.com/u/5795842?v=4","gravatar_id":"","url":"https://api.github.com/users/codecombat","html_url":"https://github.com/codecombat","followers_url":"https://api.github.com/users/codecombat/followers","following_url":"https://api.github.com/users/codecombat/following{/other_user}","gists_url":"https://api.github.com/users/codecombat/gists{/gist_id}","starred_url":"https://api.github.com/users/codecombat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecombat/subscriptions","organizations_url":"https://api.github.com/users/codecombat/orgs","repos_url":"https://api.github.com/users/codecombat/repos","events_url":"https://api.github.com/users/codecombat/events{/privacy}","received_events_url":"https://api.github.com/users/codecombat/received_events","type":"Organization","site_admin":false},"repo":{"id":15193430,"node_id":"MDEwOlJlcG9zaXRvcnkxNTE5MzQzMA==","name":"codecombat","full_name":"codecombat/codecombat","owner":{"login":"codecombat","id":5795842,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU3OTU4NDI=","avatar_url":"https://avatars2.githubusercontent.com/u/5795842?v=4","gravatar_id":"","url":"https://api.github.com/users/codecombat","html_url":"https://github.com/codecombat","followers_url":"https://api.github.com/users/codecombat/followers","following_url":"https://api.github.com/users/codecombat/following{/other_user}","gists_url":"https://api.github.com/users/codecombat/gists{/gist_id}","starred_url":"https://api.github.com/users/codecombat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecombat/subscriptions","organizations_url":"https://api.github.com/users/codecombat/orgs","repos_url":"https://api.github.com/users/codecombat/repos","events_url":"https://api.github.com/users/codecombat/events{/privacy}","received_events_url":"https://api.github.com/users/codecombat/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/codecombat/codecombat","description":"Game for learning how to code.","fork":false,"url":"https://api.github.com/repos/codecombat/codecombat","forks_url":"https://api.github.com/repos/codecombat/codecombat/forks","keys_url":"https://api.github.com/repos/codecombat/codecombat/keys{/key_id}","collaborators_url":"https://api.github.com/repos/codecombat/codecombat/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/codecombat/codecombat/teams","hooks_url":"https://api.github.com/repos/codecombat/codecombat/hooks","issue_events_url":"https://api.github.com/repos/codecombat/codecombat/issues/events{/number}","events_url":"https://api.github.com/repos/codecombat/codecombat/events","assignees_url":"https://api.github.com/repos/codecombat/codecombat/assignees{/user}","branches_url":"https://api.github.com/repos/codecombat/codecombat/branches{/branch}","tags_url":"https://api.github.com/repos/codecombat/codecombat/tags","blobs_url":"https://api.github.com/repos/codecombat/codecombat/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/codecombat/codecombat/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/codecombat/codecombat/git/refs{/sha}","trees_url":"https://api.github.com/repos/codecombat/codecombat/git/trees{/sha}","statuses_url":"https://api.github.com/repos/codecombat/codecombat/statuses/{sha}","languages_url":"https://api.github.com/repos/codecombat/codecombat/languages","stargazers_url":"https://api.github.com/repos/codecombat/codecombat/stargazers","contributors_url":"https://api.github.com/repos/codecombat/codecombat/contributors","subscribers_url":"https://api.github.com/repos/codecombat/codecombat/subscribers","subscription_url":"https://api.github.com/repos/codecombat/codecombat/subscription","commits_url":"https://api.github.com/repos/codecombat/codecombat/commits{/sha}","git_commits_url":"https://api.github.com/repos/codecombat/codecombat/git/commits{/sha}","comments_url":"https://api.github.com/repos/codecombat/codecombat/comments{/number}","issue_comment_url":"https://api.github.com/repos/codecombat/codecombat/issues/comments{/number}","contents_url":"https://api.github.com/repos/codecombat/codecombat/contents/{+path}","compare_url":"https://api.github.com/repos/codecombat/codecombat/compare/{base}...{head}","merges_url":"https://api.github.com/repos/codecombat/codecombat/merges","archive_url":"https://api.github.com/repos/codecombat/codecombat/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/codecombat/codecombat/downloads","issues_url":"https://api.github.com/repos/codecombat/codecombat/issues{/number}","pulls_url":"https://api.github.com/repos/codecombat/codecombat/pulls{/number}","milestones_url":"https://api.github.com/repos/codecombat/codecombat/milestones{/number}","notifications_url":"https://api.github.com/repos/codecombat/codecombat/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/codecombat/codecombat/labels{/name}","releases_url":"https://api.github.com/repos/codecombat/codecombat/releases{/id}","deployments_url":"https://api.github.com/repos/codecombat/codecombat/deployments","created_at":"2013-12-14T21:47:37Z","updated_at":"2018-07-23T18:59:46Z","pushed_at":"2018-07-23T23:06:47Z","git_url":"git://github.com/codecombat/codecombat.git","ssh_url":"[email protected]:codecombat/codecombat.git","clone_url":"https://github.com/codecombat/codecombat.git","svn_url":"https://github.com/codecombat/codecombat","homepage":"http://codecombat.com","size":209832,"stargazers_count":6344,"watchers_count":6344,"language":"CoffeeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3204,"mirror_url":null,"archived":false,"open_issues_count":354,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":3204,"open_issues":354,"watchers":6344,"default_branch":"master"}},"base":{"label":"codecombat:master","ref":"master","sha":"53a7d67d6d6e731d42961bf9c09d62452c103942","user":{"login":"codecombat","id":5795842,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU3OTU4NDI=","avatar_url":"https://avatars2.githubusercontent.com/u/5795842?v=4","gravatar_id":"","url":"https://api.github.com/users/codecombat","html_url":"https://github.com/codecombat","followers_url":"https://api.github.com/users/codecombat/followers","following_url":"https://api.github.com/users/codecombat/following{/other_user}","gists_url":"https://api.github.com/users/codecombat/gists{/gist_id}","starred_url":"https://api.github.com/users/codecombat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecombat/subscriptions","organizations_url":"https://api.github.com/users/codecombat/orgs","repos_url":"https://api.github.com/users/codecombat/repos","events_url":"https://api.github.com/users/codecombat/events{/privacy}","received_events_url":"https://api.github.com/users/codecombat/received_events","type":"Organization","site_admin":false},"repo":{"id":15193430,"node_id":"MDEwOlJlcG9zaXRvcnkxNTE5MzQzMA==","name":"codecombat","full_name":"codecombat/codecombat","owner":{"login":"codecombat","id":5795842,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU3OTU4NDI=","avatar_url":"https://avatars2.githubusercontent.com/u/5795842?v=4","gravatar_id":"","url":"https://api.github.com/users/codecombat","html_url":"https://github.com/codecombat","followers_url":"https://api.github.com/users/codecombat/followers","following_url":"https://api.github.com/users/codecombat/following{/other_user}","gists_url":"https://api.github.com/users/codecombat/gists{/gist_id}","starred_url":"https://api.github.com/users/codecombat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecombat/subscriptions","organizations_url":"https://api.github.com/users/codecombat/orgs","repos_url":"https://api.github.com/users/codecombat/repos","events_url":"https://api.github.com/users/codecombat/events{/privacy}","received_events_url":"https://api.github.com/users/codecombat/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/codecombat/codecombat","description":"Game for learning how to code.","fork":false,"url":"https://api.github.com/repos/codecombat/codecombat","forks_url":"https://api.github.com/repos/codecombat/codecombat/forks","keys_url":"https://api.github.com/repos/codecombat/codecombat/keys{/key_id}","collaborators_url":"https://api.github.com/repos/codecombat/codecombat/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/codecombat/codecombat/teams","hooks_url":"https://api.github.com/repos/codecombat/codecombat/hooks","issue_events_url":"https://api.github.com/repos/codecombat/codecombat/issues/events{/number}","events_url":"https://api.github.com/repos/codecombat/codecombat/events","assignees_url":"https://api.github.com/repos/codecombat/codecombat/assignees{/user}","branches_url":"https://api.github.com/repos/codecombat/codecombat/branches{/branch}","tags_url":"https://api.github.com/repos/codecombat/codecombat/tags","blobs_url":"https://api.github.com/repos/codecombat/codecombat/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/codecombat/codecombat/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/codecombat/codecombat/git/refs{/sha}","trees_url":"https://api.github.com/repos/codecombat/codecombat/git/trees{/sha}","statuses_url":"https://api.github.com/repos/codecombat/codecombat/statuses/{sha}","languages_url":"https://api.github.com/repos/codecombat/codecombat/languages","stargazers_url":"https://api.github.com/repos/codecombat/codecombat/stargazers","contributors_url":"https://api.github.com/repos/codecombat/codecombat/contributors","subscribers_url":"https://api.github.com/repos/codecombat/codecombat/subscribers","subscription_url":"https://api.github.com/repos/codecombat/codecombat/subscription","commits_url":"https://api.github.com/repos/codecombat/codecombat/commits{/sha}","git_commits_url":"https://api.github.com/repos/codecombat/codecombat/git/commits{/sha}","comments_url":"https://api.github.com/repos/codecombat/codecombat/comments{/number}","issue_comment_url":"https://api.github.com/repos/codecombat/codecombat/issues/comments{/number}","contents_url":"https://api.github.com/repos/codecombat/codecombat/contents/{+path}","compare_url":"https://api.github.com/repos/codecombat/codecombat/compare/{base}...{head}","merges_url":"https://api.github.com/repos/codecombat/codecombat/merges","archive_url":"https://api.github.com/repos/codecombat/codecombat/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/codecombat/codecombat/downloads","issues_url":"https://api.github.com/repos/codecombat/codecombat/issues{/number}","pulls_url":"https://api.github.com/repos/codecombat/codecombat/pulls{/number}","milestones_url":"https://api.github.com/repos/codecombat/codecombat/milestones{/number}","notifications_url":"https://api.github.com/repos/codecombat/codecombat/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/codecombat/codecombat/labels{/name}","releases_url":"https://api.github.com/repos/codecombat/codecombat/releases{/id}","deployments_url":"https://api.github.com/repos/codecombat/codecombat/deployments","created_at":"2013-12-14T21:47:37Z","updated_at":"2018-07-23T18:59:46Z","pushed_at":"2018-07-23T23:06:47Z","git_url":"git://github.com/codecombat/codecombat.git","ssh_url":"[email protected]:codecombat/codecombat.git","clone_url":"https://github.com/codecombat/codecombat.git","svn_url":"https://github.com/codecombat/codecombat","homepage":"http://codecombat.com","size":209832,"stargazers_count":6344,"watchers_count":6344,"language":"CoffeeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3204,"mirror_url":null,"archived":false,"open_issues_count":354,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":3204,"open_issues":354,"watchers":6344,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/codecombat/codecombat/pulls/4793"},"html":{"href":"https://github.com/codecombat/codecombat/pull/4793"},"issue":{"href":"https://api.github.com/repos/codecombat/codecombat/issues/4793"},"comments":{"href":"https://api.github.com/repos/codecombat/codecombat/issues/4793/comments"},"review_comments":{"href":"https://api.github.com/repos/codecombat/codecombat/pulls/4793/comments"},"review_comment":{"href":"https://api.github.com/repos/codecombat/codecombat/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/codecombat/codecombat/pulls/4793/commits"},"statuses":{"href":"https://api.github.com/repos/codecombat/codecombat/statuses/69bcea5aa44e5a4e34af8caca71e105cd1fa3ca4"}},"author_association":"CONTRIBUTOR"}} | {
"id": 15193430,
"name": "codecombat/codecombat",
"url": "https://api.github.com/repos/codecombat/codecombat"
} | {
"id": 99704,
"login": "nwinter",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/99704?",
"url": "https://api.github.com/users/nwinter"
} | {
"id": 5795842,
"login": "codecombat",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5795842?",
"url": "https://api.github.com/orgs/codecombat"
} | 2018-07-23T23:12:06 | 8006917435 | {"actor":{"display_login":"nwinter"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/inexorgame/inexor-core/pulls/comments/212138393","pull_request_review_id":148707136,"id":212138393,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMjEzODM5Mw==","diff_hunk":"@@ -72,5 +72,5 @@ set(CPACK_PACKAGE_FILE_NAME \"inexor-core-${CPACK_PACKAGE_VERSION}-${CMAKE_SYSTEM\n include(CPack)\n \n add_custom_target(package_debug\n- COMMAND ${CMAKE_CPACK_COMMAND} --debug --verbose --config CPackConfig.cmake\n+ COMMAND ${CMAKE_CPACK_COMMAND} --config CPackConfig.cmake","path":"cmake/create_package.cmake","position":5,"original_position":5,"commit_id":"c0438e26b1e952cfd8c6893c05f4e1d88f7fbcc6","original_commit_id":"c0438e26b1e952cfd8c6893c05f4e1d88f7fbcc6","user":{"login":"Croydon","id":1593194,"node_id":"MDQ6VXNlcjE1OTMxOTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/1593194?v=4","gravatar_id":"","url":"https://api.github.com/users/Croydon","html_url":"https://github.com/Croydon","followers_url":"https://api.github.com/users/Croydon/followers","following_url":"https://api.github.com/users/Croydon/following{/other_user}","gists_url":"https://api.github.com/users/Croydon/gists{/gist_id}","starred_url":"https://api.github.com/users/Croydon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Croydon/subscriptions","organizations_url":"https://api.github.com/users/Croydon/orgs","repos_url":"https://api.github.com/users/Croydon/repos","events_url":"https://api.github.com/users/Croydon/events{/privacy}","received_events_url":"https://api.github.com/users/Croydon/received_events","type":"User","site_admin":false},"body":"I agree with verbose, but I have my doubts about debug:\r\n\r\n> Run cpack with debug output. This option is intended mainly for the developers of cpack itself and is not normally needed by project developers.\r\n\r\nhttps://cmake.org/cmake/help/v3.12/manual/cpack.1.html","created_at":"2018-08-22T23:09:35Z","updated_at":"2018-08-22T23:09:35Z","html_url":"https://github.com/inexorgame/inexor-core/pull/606#discussion_r212138393","pull_request_url":"https://api.github.com/repos/inexorgame/inexor-core/pulls/606","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/inexorgame/inexor-core/pulls/comments/212138393"},"html":{"href":"https://github.com/inexorgame/inexor-core/pull/606#discussion_r212138393"},"pull_request":{"href":"https://api.github.com/repos/inexorgame/inexor-core/pulls/606"}},"in_reply_to_id":210131313},"pull_request":{"url":"https://api.github.com/repos/inexorgame/inexor-core/pulls/606","id":207849245,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3ODQ5MjQ1","html_url":"https://github.com/inexorgame/inexor-core/pull/606","diff_url":"https://github.com/inexorgame/inexor-core/pull/606.diff","patch_url":"https://github.com/inexorgame/inexor-core/pull/606.patch","issue_url":"https://api.github.com/repos/inexorgame/inexor-core/issues/606","number":606,"state":"open","locked":false,"title":"Streamline building III","user":{"login":"Croydon","id":1593194,"node_id":"MDQ6VXNlcjE1OTMxOTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/1593194?v=4","gravatar_id":"","url":"https://api.github.com/users/Croydon","html_url":"https://github.com/Croydon","followers_url":"https://api.github.com/users/Croydon/followers","following_url":"https://api.github.com/users/Croydon/following{/other_user}","gists_url":"https://api.github.com/users/Croydon/gists{/gist_id}","starred_url":"https://api.github.com/users/Croydon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Croydon/subscriptions","organizations_url":"https://api.github.com/users/Croydon/orgs","repos_url":"https://api.github.com/users/Croydon/repos","events_url":"https://api.github.com/users/Croydon/events{/privacy}","received_events_url":"https://api.github.com/users/Croydon/received_events","type":"User","site_admin":false},"body":"This\r\n * migrates the Docker containers to use Conan's official ones\r\n * simplifies .travis.yml further\r\n * adds initial, very basic support for clang-cl (Clang on Windows)\r\n * doesn't actually work yet, but opens the door\r\n * remove outdated code all over the place\r\n * update copyright years\r\n * when tagging a new version of inexor-core mention current flex-version/media-essential/media-additional (#489)\r\n * this is hard to test before, so there might be follow up fixes after merging :)\r\n * reflects recent changes in how we manage our Conan packages on Bintray (e.g #599)\r\n * https://github.com/inexorgame/inexor-core/wiki/Continuous-Integration#how-to-add-new-third-party-conan-recipes\r\n * removes Bincrafters and conan-community repositories in CI (DON'T READD THEM)\r\n * updates\r\n * grpc to 1.14.1\r\n * fixes: gRPC might accidently build csharp-ext (#600)\r\n * protobuf to 3.5.2\r\n * enet to the Bincrafters recipe\r\n * boost to the lower case new recipe revision\r\n * sdl2 to the stable recipe channel\r\n ","created_at":"2018-08-13T00:38:17Z","updated_at":"2018-08-22T23:09:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3c40a6527410a0d14c75bddcb62f34e4b6795d28","assignee":{"login":"Croydon","id":1593194,"node_id":"MDQ6VXNlcjE1OTMxOTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/1593194?v=4","gravatar_id":"","url":"https://api.github.com/users/Croydon","html_url":"https://github.com/Croydon","followers_url":"https://api.github.com/users/Croydon/followers","following_url":"https://api.github.com/users/Croydon/following{/other_user}","gists_url":"https://api.github.com/users/Croydon/gists{/gist_id}","starred_url":"https://api.github.com/users/Croydon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Croydon/subscriptions","organizations_url":"https://api.github.com/users/Croydon/orgs","repos_url":"https://api.github.com/users/Croydon/repos","events_url":"https://api.github.com/users/Croydon/events{/privacy}","received_events_url":"https://api.github.com/users/Croydon/received_events","type":"User","site_admin":false},"assignees":[{"login":"Croydon","id":1593194,"node_id":"MDQ6VXNlcjE1OTMxOTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/1593194?v=4","gravatar_id":"","url":"https://api.github.com/users/Croydon","html_url":"https://github.com/Croydon","followers_url":"https://api.github.com/users/Croydon/followers","following_url":"https://api.github.com/users/Croydon/following{/other_user}","gists_url":"https://api.github.com/users/Croydon/gists{/gist_id}","starred_url":"https://api.github.com/users/Croydon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Croydon/subscriptions","organizations_url":"https://api.github.com/users/Croydon/orgs","repos_url":"https://api.github.com/users/Croydon/repos","events_url":"https://api.github.com/users/Croydon/events{/privacy}","received_events_url":"https://api.github.com/users/Croydon/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"aschaeffer","id":2207279,"node_id":"MDQ6VXNlcjIyMDcyNzk=","avatar_url":"https://avatars2.githubusercontent.com/u/2207279?v=4","gravatar_id":"","url":"https://api.github.com/users/aschaeffer","html_url":"https://github.com/aschaeffer","followers_url":"https://api.github.com/users/aschaeffer/followers","following_url":"https://api.github.com/users/aschaeffer/following{/other_user}","gists_url":"https://api.github.com/users/aschaeffer/gists{/gist_id}","starred_url":"https://api.github.com/users/aschaeffer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aschaeffer/subscriptions","organizations_url":"https://api.github.com/users/aschaeffer/orgs","repos_url":"https://api.github.com/users/aschaeffer/repos","events_url":"https://api.github.com/users/aschaeffer/events{/privacy}","received_events_url":"https://api.github.com/users/aschaeffer/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":113318777,"node_id":"MDU6TGFiZWwxMTMzMTg3Nzc=","url":"https://api.github.com/repos/inexorgame/inexor-core/labels/feat:build%20environment","name":"feat:build environment","color":"bfe5bf","default":false},{"id":165814398,"node_id":"MDU6TGFiZWwxNjU4MTQzOTg=","url":"https://api.github.com/repos/inexorgame/inexor-core/labels/org:in%20progress","name":"org:in progress","color":"fafafa","default":false}],"milestone":{"url":"https://api.github.com/repos/inexorgame/inexor-core/milestones/11","html_url":"https://github.com/inexorgame/inexor-core/milestone/11","labels_url":"https://api.github.com/repos/inexorgame/inexor-core/milestones/11/labels","id":1727303,"node_id":"MDk6TWlsZXN0b25lMTcyNzMwMw==","number":11,"title":"0.10.0-alpha - Make development simple and fast","description":"","creator":{"login":"Croydon","id":1593194,"node_id":"MDQ6VXNlcjE1OTMxOTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/1593194?v=4","gravatar_id":"","url":"https://api.github.com/users/Croydon","html_url":"https://github.com/Croydon","followers_url":"https://api.github.com/users/Croydon/followers","following_url":"https://api.github.com/users/Croydon/following{/other_user}","gists_url":"https://api.github.com/users/Croydon/gists{/gist_id}","starred_url":"https://api.github.com/users/Croydon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Croydon/subscriptions","organizations_url":"https://api.github.com/users/Croydon/orgs","repos_url":"https://api.github.com/users/Croydon/repos","events_url":"https://api.github.com/users/Croydon/events{/privacy}","received_events_url":"https://api.github.com/users/Croydon/received_events","type":"User","site_admin":false},"open_issues":34,"closed_issues":42,"state":"open","created_at":"2016-04-24T14:24:16Z","updated_at":"2018-08-13T00:38:17Z","due_on":"2018-09-15T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/inexorgame/inexor-core/pulls/606/commits","review_comments_url":"https://api.github.com/repos/inexorgame/inexor-core/pulls/606/comments","review_comment_url":"https://api.github.com/repos/inexorgame/inexor-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/inexorgame/inexor-core/issues/606/comments","statuses_url":"https://api.github.com/repos/inexorgame/inexor-core/statuses/c0438e26b1e952cfd8c6893c05f4e1d88f7fbcc6","head":{"label":"inexorgame:croydon/streamline_building3","ref":"croydon/streamline_building3","sha":"c0438e26b1e952cfd8c6893c05f4e1d88f7fbcc6","user":{"login":"inexorgame","id":5883878,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU4ODM4Nzg=","avatar_url":"https://avatars0.githubusercontent.com/u/5883878?v=4","gravatar_id":"","url":"https://api.github.com/users/inexorgame","html_url":"https://github.com/inexorgame","followers_url":"https://api.github.com/users/inexorgame/followers","following_url":"https://api.github.com/users/inexorgame/following{/other_user}","gists_url":"https://api.github.com/users/inexorgame/gists{/gist_id}","starred_url":"https://api.github.com/users/inexorgame/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inexorgame/subscriptions","organizations_url":"https://api.github.com/users/inexorgame/orgs","repos_url":"https://api.github.com/users/inexorgame/repos","events_url":"https://api.github.com/users/inexorgame/events{/privacy}","received_events_url":"https://api.github.com/users/inexorgame/received_events","type":"Organization","site_admin":false},"repo":{"id":20705344,"node_id":"MDEwOlJlcG9zaXRvcnkyMDcwNTM0NA==","name":"inexor-core","full_name":"inexorgame/inexor-core","owner":{"login":"inexorgame","id":5883878,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU4ODM4Nzg=","avatar_url":"https://avatars0.githubusercontent.com/u/5883878?v=4","gravatar_id":"","url":"https://api.github.com/users/inexorgame","html_url":"https://github.com/inexorgame","followers_url":"https://api.github.com/users/inexorgame/followers","following_url":"https://api.github.com/users/inexorgame/following{/other_user}","gists_url":"https://api.github.com/users/inexorgame/gists{/gist_id}","starred_url":"https://api.github.com/users/inexorgame/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inexorgame/subscriptions","organizations_url":"https://api.github.com/users/inexorgame/orgs","repos_url":"https://api.github.com/users/inexorgame/repos","events_url":"https://api.github.com/users/inexorgame/events{/privacy}","received_events_url":"https://api.github.com/users/inexorgame/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/inexorgame/inexor-core","description":"Inexor - Community fork of the Cube 2: Sauerbraten game.","fork":false,"url":"https://api.github.com/repos/inexorgame/inexor-core","forks_url":"https://api.github.com/repos/inexorgame/inexor-core/forks","keys_url":"https://api.github.com/repos/inexorgame/inexor-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/inexorgame/inexor-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/inexorgame/inexor-core/teams","hooks_url":"https://api.github.com/repos/inexorgame/inexor-core/hooks","issue_events_url":"https://api.github.com/repos/inexorgame/inexor-core/issues/events{/number}","events_url":"https://api.github.com/repos/inexorgame/inexor-core/events","assignees_url":"https://api.github.com/repos/inexorgame/inexor-core/assignees{/user}","branches_url":"https://api.github.com/repos/inexorgame/inexor-core/branches{/branch}","tags_url":"https://api.github.com/repos/inexorgame/inexor-core/tags","blobs_url":"https://api.github.com/repos/inexorgame/inexor-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/inexorgame/inexor-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/inexorgame/inexor-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/inexorgame/inexor-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/inexorgame/inexor-core/statuses/{sha}","languages_url":"https://api.github.com/repos/inexorgame/inexor-core/languages","stargazers_url":"https://api.github.com/repos/inexorgame/inexor-core/stargazers","contributors_url":"https://api.github.com/repos/inexorgame/inexor-core/contributors","subscribers_url":"https://api.github.com/repos/inexorgame/inexor-core/subscribers","subscription_url":"https://api.github.com/repos/inexorgame/inexor-core/subscription","commits_url":"https://api.github.com/repos/inexorgame/inexor-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/inexorgame/inexor-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/inexorgame/inexor-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/inexorgame/inexor-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/inexorgame/inexor-core/contents/{+path}","compare_url":"https://api.github.com/repos/inexorgame/inexor-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/inexorgame/inexor-core/merges","archive_url":"https://api.github.com/repos/inexorgame/inexor-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/inexorgame/inexor-core/downloads","issues_url":"https://api.github.com/repos/inexorgame/inexor-core/issues{/number}","pulls_url":"https://api.github.com/repos/inexorgame/inexor-core/pulls{/number}","milestones_url":"https://api.github.com/repos/inexorgame/inexor-core/milestones{/number}","notifications_url":"https://api.github.com/repos/inexorgame/inexor-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/inexorgame/inexor-core/labels{/name}","releases_url":"https://api.github.com/repos/inexorgame/inexor-core/releases{/id}","deployments_url":"https://api.github.com/repos/inexorgame/inexor-core/deployments","created_at":"2014-06-10T23:27:51Z","updated_at":"2018-08-18T14:06:59Z","pushed_at":"2018-08-13T00:38:18Z","git_url":"git://github.com/inexorgame/inexor-core.git","ssh_url":"[email protected]:inexorgame/inexor-core.git","clone_url":"https://github.com/inexorgame/inexor-core.git","svn_url":"https://github.com/inexorgame/inexor-core","homepage":"https://inexor.org","size":9373,"stargazers_count":144,"watchers_count":144,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":41,"mirror_url":null,"archived":false,"open_issues_count":194,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":41,"open_issues":194,"watchers":144,"default_branch":"master"}},"base":{"label":"inexorgame:master","ref":"master","sha":"75fd55effd3cbdd84e2a9c369741fc8067e5b481","user":{"login":"inexorgame","id":5883878,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU4ODM4Nzg=","avatar_url":"https://avatars0.githubusercontent.com/u/5883878?v=4","gravatar_id":"","url":"https://api.github.com/users/inexorgame","html_url":"https://github.com/inexorgame","followers_url":"https://api.github.com/users/inexorgame/followers","following_url":"https://api.github.com/users/inexorgame/following{/other_user}","gists_url":"https://api.github.com/users/inexorgame/gists{/gist_id}","starred_url":"https://api.github.com/users/inexorgame/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inexorgame/subscriptions","organizations_url":"https://api.github.com/users/inexorgame/orgs","repos_url":"https://api.github.com/users/inexorgame/repos","events_url":"https://api.github.com/users/inexorgame/events{/privacy}","received_events_url":"https://api.github.com/users/inexorgame/received_events","type":"Organization","site_admin":false},"repo":{"id":20705344,"node_id":"MDEwOlJlcG9zaXRvcnkyMDcwNTM0NA==","name":"inexor-core","full_name":"inexorgame/inexor-core","owner":{"login":"inexorgame","id":5883878,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU4ODM4Nzg=","avatar_url":"https://avatars0.githubusercontent.com/u/5883878?v=4","gravatar_id":"","url":"https://api.github.com/users/inexorgame","html_url":"https://github.com/inexorgame","followers_url":"https://api.github.com/users/inexorgame/followers","following_url":"https://api.github.com/users/inexorgame/following{/other_user}","gists_url":"https://api.github.com/users/inexorgame/gists{/gist_id}","starred_url":"https://api.github.com/users/inexorgame/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inexorgame/subscriptions","organizations_url":"https://api.github.com/users/inexorgame/orgs","repos_url":"https://api.github.com/users/inexorgame/repos","events_url":"https://api.github.com/users/inexorgame/events{/privacy}","received_events_url":"https://api.github.com/users/inexorgame/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/inexorgame/inexor-core","description":"Inexor - Community fork of the Cube 2: Sauerbraten game.","fork":false,"url":"https://api.github.com/repos/inexorgame/inexor-core","forks_url":"https://api.github.com/repos/inexorgame/inexor-core/forks","keys_url":"https://api.github.com/repos/inexorgame/inexor-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/inexorgame/inexor-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/inexorgame/inexor-core/teams","hooks_url":"https://api.github.com/repos/inexorgame/inexor-core/hooks","issue_events_url":"https://api.github.com/repos/inexorgame/inexor-core/issues/events{/number}","events_url":"https://api.github.com/repos/inexorgame/inexor-core/events","assignees_url":"https://api.github.com/repos/inexorgame/inexor-core/assignees{/user}","branches_url":"https://api.github.com/repos/inexorgame/inexor-core/branches{/branch}","tags_url":"https://api.github.com/repos/inexorgame/inexor-core/tags","blobs_url":"https://api.github.com/repos/inexorgame/inexor-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/inexorgame/inexor-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/inexorgame/inexor-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/inexorgame/inexor-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/inexorgame/inexor-core/statuses/{sha}","languages_url":"https://api.github.com/repos/inexorgame/inexor-core/languages","stargazers_url":"https://api.github.com/repos/inexorgame/inexor-core/stargazers","contributors_url":"https://api.github.com/repos/inexorgame/inexor-core/contributors","subscribers_url":"https://api.github.com/repos/inexorgame/inexor-core/subscribers","subscription_url":"https://api.github.com/repos/inexorgame/inexor-core/subscription","commits_url":"https://api.github.com/repos/inexorgame/inexor-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/inexorgame/inexor-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/inexorgame/inexor-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/inexorgame/inexor-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/inexorgame/inexor-core/contents/{+path}","compare_url":"https://api.github.com/repos/inexorgame/inexor-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/inexorgame/inexor-core/merges","archive_url":"https://api.github.com/repos/inexorgame/inexor-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/inexorgame/inexor-core/downloads","issues_url":"https://api.github.com/repos/inexorgame/inexor-core/issues{/number}","pulls_url":"https://api.github.com/repos/inexorgame/inexor-core/pulls{/number}","milestones_url":"https://api.github.com/repos/inexorgame/inexor-core/milestones{/number}","notifications_url":"https://api.github.com/repos/inexorgame/inexor-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/inexorgame/inexor-core/labels{/name}","releases_url":"https://api.github.com/repos/inexorgame/inexor-core/releases{/id}","deployments_url":"https://api.github.com/repos/inexorgame/inexor-core/deployments","created_at":"2014-06-10T23:27:51Z","updated_at":"2018-08-18T14:06:59Z","pushed_at":"2018-08-13T00:38:18Z","git_url":"git://github.com/inexorgame/inexor-core.git","ssh_url":"[email protected]:inexorgame/inexor-core.git","clone_url":"https://github.com/inexorgame/inexor-core.git","svn_url":"https://github.com/inexorgame/inexor-core","homepage":"https://inexor.org","size":9373,"stargazers_count":144,"watchers_count":144,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":41,"mirror_url":null,"archived":false,"open_issues_count":194,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":41,"open_issues":194,"watchers":144,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/inexorgame/inexor-core/pulls/606"},"html":{"href":"https://github.com/inexorgame/inexor-core/pull/606"},"issue":{"href":"https://api.github.com/repos/inexorgame/inexor-core/issues/606"},"comments":{"href":"https://api.github.com/repos/inexorgame/inexor-core/issues/606/comments"},"review_comments":{"href":"https://api.github.com/repos/inexorgame/inexor-core/pulls/606/comments"},"review_comment":{"href":"https://api.github.com/repos/inexorgame/inexor-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/inexorgame/inexor-core/pulls/606/commits"},"statuses":{"href":"https://api.github.com/repos/inexorgame/inexor-core/statuses/c0438e26b1e952cfd8c6893c05f4e1d88f7fbcc6"}},"author_association":"MEMBER"}} | {
"id": 20705344,
"name": "inexorgame/inexor-core",
"url": "https://api.github.com/repos/inexorgame/inexor-core"
} | {
"id": 1593194,
"login": "Croydon",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1593194?",
"url": "https://api.github.com/users/Croydon"
} | {
"id": 5883878,
"login": "inexorgame",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5883878?",
"url": "https://api.github.com/orgs/inexorgame"
} | 2018-08-22T23:09:35 | 8153719813 | {"actor":{"display_login":"Croydon"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/PolymerLabs/arcs/pulls/comments/207788998","pull_request_review_id":143469737,"id":207788998,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNzc4ODk5OA==","diff_hunk":"@@ -241,21 +270,34 @@ class InMemoryVariable extends InMemoryStorageProvider {\n let value = this._stored;\n let referredType = this.type.referenceReferredType;\n // TODO: string version of ReferredTyped as ID?\n- // TODO: remember to use/check the ID of the reference too.\n- let store = await this._storageEngine.connect(referredType.toString(), referredType, value.storageKey);\n- let result = await store.get();\n+ if (this._backingStore == null)\n+ this._backingStore = await this._storageEngine.share(referredType.toString(), referredType.collectionOf(), value.storageKey);\n+ let result = await this._backingStore.get(value.id);\n return result;\n }\n return this._stored;\n }\n \n async set(value, originatorId=null, barrier=null) {\n assert(value !== undefined);\n- // If there's a barrier set, then the originating storage-proxy is expecting\n- // a result so we cannot suppress the event here.\n- if (JSON.stringify(this._stored) == JSON.stringify(value) && barrier == null)\n- return;\n- this._stored = value;\n+ if (this.type.isReference) {\n+ // If there's a barrier set, then the originating storage-proxy is expecting\n+ // a result so we cannot suppress the event here.\n+ if (this.__stored && this.__stored.id == value.id && barrier == null)\n+ return;\n+ \n+ let referredType = this.type.referenceReferredType;\n+ if (this._backingStore == null)\n+ this._backingStore = await this._storageEngine.baseStorageFor(referredType);","path":"runtime/storage/in-memory-storage.js","position":114,"original_position":114,"commit_id":"27750045695a36f77490e0b5b8b6f35d00c1ed06","original_commit_id":"27750045695a36f77490e0b5b8b6f35d00c1ed06","user":{"login":"shans","id":329053,"node_id":"MDQ6VXNlcjMyOTA1Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/329053?v=4","gravatar_id":"","url":"https://api.github.com/users/shans","html_url":"https://github.com/shans","followers_url":"https://api.github.com/users/shans/followers","following_url":"https://api.github.com/users/shans/following{/other_user}","gists_url":"https://api.github.com/users/shans/gists{/gist_id}","starred_url":"https://api.github.com/users/shans/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shans/subscriptions","organizations_url":"https://api.github.com/users/shans/orgs","repos_url":"https://api.github.com/users/shans/repos","events_url":"https://api.github.com/users/shans/events{/privacy}","received_events_url":"https://api.github.com/users/shans/received_events","type":"User","site_admin":false},"body":"Yields will be mainly observable as latency, I think, so it's probably better not to yield when not required.","created_at":"2018-08-06T06:54:53Z","updated_at":"2018-08-06T06:54:53Z","html_url":"https://github.com/PolymerLabs/arcs/pull/1728#discussion_r207788998","pull_request_url":"https://api.github.com/repos/PolymerLabs/arcs/pulls/1728","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/PolymerLabs/arcs/pulls/comments/207788998"},"html":{"href":"https://github.com/PolymerLabs/arcs/pull/1728#discussion_r207788998"},"pull_request":{"href":"https://api.github.com/repos/PolymerLabs/arcs/pulls/1728"}},"in_reply_to_id":207775609},"pull_request":{"url":"https://api.github.com/repos/PolymerLabs/arcs/pulls/1728","id":206287157,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2Mjg3MTU3","html_url":"https://github.com/PolymerLabs/arcs/pull/1728","diff_url":"https://github.com/PolymerLabs/arcs/pull/1728.diff","patch_url":"https://github.com/PolymerLabs/arcs/pull/1728.patch","issue_url":"https://api.github.com/repos/PolymerLabs/arcs/issues/1728","number":1728,"state":"open","locked":false,"title":"Implement writing to the backing store for in-memory ref stores.","user":{"login":"shans","id":329053,"node_id":"MDQ6VXNlcjMyOTA1Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/329053?v=4","gravatar_id":"","url":"https://api.github.com/users/shans","html_url":"https://github.com/shans","followers_url":"https://api.github.com/users/shans/followers","following_url":"https://api.github.com/users/shans/following{/other_user}","gists_url":"https://api.github.com/users/shans/gists{/gist_id}","starred_url":"https://api.github.com/users/shans/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shans/subscriptions","organizations_url":"https://api.github.com/users/shans/orgs","repos_url":"https://api.github.com/users/shans/repos","events_url":"https://api.github.com/users/shans/events{/privacy}","received_events_url":"https://api.github.com/users/shans/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-08-06T04:37:33Z","updated_at":"2018-08-06T06:54:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"665e00e894a109a0e50b3ee34ddc7f8e99e7cdd1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/PolymerLabs/arcs/pulls/1728/commits","review_comments_url":"https://api.github.com/repos/PolymerLabs/arcs/pulls/1728/comments","review_comment_url":"https://api.github.com/repos/PolymerLabs/arcs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PolymerLabs/arcs/issues/1728/comments","statuses_url":"https://api.github.com/repos/PolymerLabs/arcs/statuses/27750045695a36f77490e0b5b8b6f35d00c1ed06","head":{"label":"shans:writeToBackingStore","ref":"writeToBackingStore","sha":"27750045695a36f77490e0b5b8b6f35d00c1ed06","user":{"login":"shans","id":329053,"node_id":"MDQ6VXNlcjMyOTA1Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/329053?v=4","gravatar_id":"","url":"https://api.github.com/users/shans","html_url":"https://github.com/shans","followers_url":"https://api.github.com/users/shans/followers","following_url":"https://api.github.com/users/shans/following{/other_user}","gists_url":"https://api.github.com/users/shans/gists{/gist_id}","starred_url":"https://api.github.com/users/shans/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shans/subscriptions","organizations_url":"https://api.github.com/users/shans/orgs","repos_url":"https://api.github.com/users/shans/repos","events_url":"https://api.github.com/users/shans/events{/privacy}","received_events_url":"https://api.github.com/users/shans/received_events","type":"User","site_admin":false},"repo":{"id":89650587,"node_id":"MDEwOlJlcG9zaXRvcnk4OTY1MDU4Nw==","name":"arcs","full_name":"shans/arcs","owner":{"login":"shans","id":329053,"node_id":"MDQ6VXNlcjMyOTA1Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/329053?v=4","gravatar_id":"","url":"https://api.github.com/users/shans","html_url":"https://github.com/shans","followers_url":"https://api.github.com/users/shans/followers","following_url":"https://api.github.com/users/shans/following{/other_user}","gists_url":"https://api.github.com/users/shans/gists{/gist_id}","starred_url":"https://api.github.com/users/shans/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shans/subscriptions","organizations_url":"https://api.github.com/users/shans/orgs","repos_url":"https://api.github.com/users/shans/repos","events_url":"https://api.github.com/users/shans/events{/privacy}","received_events_url":"https://api.github.com/users/shans/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/shans/arcs","description":null,"fork":true,"url":"https://api.github.com/repos/shans/arcs","forks_url":"https://api.github.com/repos/shans/arcs/forks","keys_url":"https://api.github.com/repos/shans/arcs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shans/arcs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shans/arcs/teams","hooks_url":"https://api.github.com/repos/shans/arcs/hooks","issue_events_url":"https://api.github.com/repos/shans/arcs/issues/events{/number}","events_url":"https://api.github.com/repos/shans/arcs/events","assignees_url":"https://api.github.com/repos/shans/arcs/assignees{/user}","branches_url":"https://api.github.com/repos/shans/arcs/branches{/branch}","tags_url":"https://api.github.com/repos/shans/arcs/tags","blobs_url":"https://api.github.com/repos/shans/arcs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shans/arcs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shans/arcs/git/refs{/sha}","trees_url":"https://api.github.com/repos/shans/arcs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shans/arcs/statuses/{sha}","languages_url":"https://api.github.com/repos/shans/arcs/languages","stargazers_url":"https://api.github.com/repos/shans/arcs/stargazers","contributors_url":"https://api.github.com/repos/shans/arcs/contributors","subscribers_url":"https://api.github.com/repos/shans/arcs/subscribers","subscription_url":"https://api.github.com/repos/shans/arcs/subscription","commits_url":"https://api.github.com/repos/shans/arcs/commits{/sha}","git_commits_url":"https://api.github.com/repos/shans/arcs/git/commits{/sha}","comments_url":"https://api.github.com/repos/shans/arcs/comments{/number}","issue_comment_url":"https://api.github.com/repos/shans/arcs/issues/comments{/number}","contents_url":"https://api.github.com/repos/shans/arcs/contents/{+path}","compare_url":"https://api.github.com/repos/shans/arcs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shans/arcs/merges","archive_url":"https://api.github.com/repos/shans/arcs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shans/arcs/downloads","issues_url":"https://api.github.com/repos/shans/arcs/issues{/number}","pulls_url":"https://api.github.com/repos/shans/arcs/pulls{/number}","milestones_url":"https://api.github.com/repos/shans/arcs/milestones{/number}","notifications_url":"https://api.github.com/repos/shans/arcs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shans/arcs/labels{/name}","releases_url":"https://api.github.com/repos/shans/arcs/releases{/id}","deployments_url":"https://api.github.com/repos/shans/arcs/deployments","created_at":"2017-04-28T00:06:50Z","updated_at":"2017-04-28T00:07:36Z","pushed_at":"2018-08-06T04:37:14Z","git_url":"git://github.com/shans/arcs.git","ssh_url":"[email protected]:shans/arcs.git","clone_url":"https://github.com/shans/arcs.git","svn_url":"https://github.com/shans/arcs","homepage":null,"size":25943,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"PolymerLabs:master","ref":"master","sha":"f7caec04284e140b37be36f036ea6927dbcc06e6","user":{"login":"PolymerLabs","id":5912903,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5MTI5MDM=","avatar_url":"https://avatars2.githubusercontent.com/u/5912903?v=4","gravatar_id":"","url":"https://api.github.com/users/PolymerLabs","html_url":"https://github.com/PolymerLabs","followers_url":"https://api.github.com/users/PolymerLabs/followers","following_url":"https://api.github.com/users/PolymerLabs/following{/other_user}","gists_url":"https://api.github.com/users/PolymerLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/PolymerLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PolymerLabs/subscriptions","organizations_url":"https://api.github.com/users/PolymerLabs/orgs","repos_url":"https://api.github.com/users/PolymerLabs/repos","events_url":"https://api.github.com/users/PolymerLabs/events{/privacy}","received_events_url":"https://api.github.com/users/PolymerLabs/received_events","type":"Organization","site_admin":false},"repo":{"id":80783122,"node_id":"MDEwOlJlcG9zaXRvcnk4MDc4MzEyMg==","name":"arcs","full_name":"PolymerLabs/arcs","owner":{"login":"PolymerLabs","id":5912903,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5MTI5MDM=","avatar_url":"https://avatars2.githubusercontent.com/u/5912903?v=4","gravatar_id":"","url":"https://api.github.com/users/PolymerLabs","html_url":"https://github.com/PolymerLabs","followers_url":"https://api.github.com/users/PolymerLabs/followers","following_url":"https://api.github.com/users/PolymerLabs/following{/other_user}","gists_url":"https://api.github.com/users/PolymerLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/PolymerLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PolymerLabs/subscriptions","organizations_url":"https://api.github.com/users/PolymerLabs/orgs","repos_url":"https://api.github.com/users/PolymerLabs/repos","events_url":"https://api.github.com/users/PolymerLabs/events{/privacy}","received_events_url":"https://api.github.com/users/PolymerLabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PolymerLabs/arcs","description":"Arcs aims to create an open ecosystem for privacy-preserving, AI-first computing.","fork":false,"url":"https://api.github.com/repos/PolymerLabs/arcs","forks_url":"https://api.github.com/repos/PolymerLabs/arcs/forks","keys_url":"https://api.github.com/repos/PolymerLabs/arcs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PolymerLabs/arcs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PolymerLabs/arcs/teams","hooks_url":"https://api.github.com/repos/PolymerLabs/arcs/hooks","issue_events_url":"https://api.github.com/repos/PolymerLabs/arcs/issues/events{/number}","events_url":"https://api.github.com/repos/PolymerLabs/arcs/events","assignees_url":"https://api.github.com/repos/PolymerLabs/arcs/assignees{/user}","branches_url":"https://api.github.com/repos/PolymerLabs/arcs/branches{/branch}","tags_url":"https://api.github.com/repos/PolymerLabs/arcs/tags","blobs_url":"https://api.github.com/repos/PolymerLabs/arcs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PolymerLabs/arcs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PolymerLabs/arcs/git/refs{/sha}","trees_url":"https://api.github.com/repos/PolymerLabs/arcs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PolymerLabs/arcs/statuses/{sha}","languages_url":"https://api.github.com/repos/PolymerLabs/arcs/languages","stargazers_url":"https://api.github.com/repos/PolymerLabs/arcs/stargazers","contributors_url":"https://api.github.com/repos/PolymerLabs/arcs/contributors","subscribers_url":"https://api.github.com/repos/PolymerLabs/arcs/subscribers","subscription_url":"https://api.github.com/repos/PolymerLabs/arcs/subscription","commits_url":"https://api.github.com/repos/PolymerLabs/arcs/commits{/sha}","git_commits_url":"https://api.github.com/repos/PolymerLabs/arcs/git/commits{/sha}","comments_url":"https://api.github.com/repos/PolymerLabs/arcs/comments{/number}","issue_comment_url":"https://api.github.com/repos/PolymerLabs/arcs/issues/comments{/number}","contents_url":"https://api.github.com/repos/PolymerLabs/arcs/contents/{+path}","compare_url":"https://api.github.com/repos/PolymerLabs/arcs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PolymerLabs/arcs/merges","archive_url":"https://api.github.com/repos/PolymerLabs/arcs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PolymerLabs/arcs/downloads","issues_url":"https://api.github.com/repos/PolymerLabs/arcs/issues{/number}","pulls_url":"https://api.github.com/repos/PolymerLabs/arcs/pulls{/number}","milestones_url":"https://api.github.com/repos/PolymerLabs/arcs/milestones{/number}","notifications_url":"https://api.github.com/repos/PolymerLabs/arcs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PolymerLabs/arcs/labels{/name}","releases_url":"https://api.github.com/repos/PolymerLabs/arcs/releases{/id}","deployments_url":"https://api.github.com/repos/PolymerLabs/arcs/deployments","created_at":"2017-02-03T00:32:19Z","updated_at":"2018-08-04T04:43:51Z","pushed_at":"2018-08-06T04:37:34Z","git_url":"git://github.com/PolymerLabs/arcs.git","ssh_url":"[email protected]:PolymerLabs/arcs.git","clone_url":"https://github.com/PolymerLabs/arcs.git","svn_url":"https://github.com/PolymerLabs/arcs","homepage":"","size":25772,"stargazers_count":28,"watchers_count":28,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":17,"mirror_url":null,"archived":false,"open_issues_count":146,"license":null,"forks":17,"open_issues":146,"watchers":28,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PolymerLabs/arcs/pulls/1728"},"html":{"href":"https://github.com/PolymerLabs/arcs/pull/1728"},"issue":{"href":"https://api.github.com/repos/PolymerLabs/arcs/issues/1728"},"comments":{"href":"https://api.github.com/repos/PolymerLabs/arcs/issues/1728/comments"},"review_comments":{"href":"https://api.github.com/repos/PolymerLabs/arcs/pulls/1728/comments"},"review_comment":{"href":"https://api.github.com/repos/PolymerLabs/arcs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PolymerLabs/arcs/pulls/1728/commits"},"statuses":{"href":"https://api.github.com/repos/PolymerLabs/arcs/statuses/27750045695a36f77490e0b5b8b6f35d00c1ed06"}},"author_association":"COLLABORATOR"}} | {
"id": 80783122,
"name": "PolymerLabs/arcs",
"url": "https://api.github.com/repos/PolymerLabs/arcs"
} | {
"id": 329053,
"login": "shans",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/329053?",
"url": "https://api.github.com/users/shans"
} | {
"id": 5912903,
"login": "PolymerLabs",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5912903?",
"url": "https://api.github.com/orgs/PolymerLabs"
} | 2018-08-06T06:54:53 | 8069647397 | {"actor":{"display_login":"shans"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/ICTU/quality-report/pulls/comments/195311415","pull_request_review_id":128652458,"id":195311415,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NTMxMTQxNQ==","diff_hunk":"@@ -25,24 +23,48 @@ class FileSystem(object):\n @staticmethod\n def write_file(contents: str, filename: str, mode: str, encoding: str = None) -> None:\n \"\"\" Write the contents to the specified file. \"\"\"\n- if os.path.exists(filename):\n- FileSystem.make_file_readable(filename)\n- output_file = codecs.open(filename, mode, encoding)\n- output_file.write(contents)\n- output_file.close()\n- FileSystem.make_file_readable(filename)\n+ path = pathlib.Path(filename)\n+ if path.exists():\n+ FileSystem.make_file_readable(path)\n+ if 'b' in mode:\n+ path.write_bytes(contents.encode())\n+ else:\n+ path.write_text(contents, encoding=encoding)\n+ FileSystem.make_file_readable(path)\n \n+ @typing.overload\n @staticmethod\n def create_dir(dir_name: str) -> None:\n+ pass\n+\n+ @typing.overload\n+ @staticmethod\n+ def create_dir(dir_name: pathlib.Path) -> None:","path":"backend/hqlib/filesystem.py","position":39,"original_position":39,"commit_id":"a4d058674a0f7e568cd130d9b6c3b245b204634c","original_commit_id":"a4d058674a0f7e568cd130d9b6c3b245b204634c","user":{"login":"codacy-bot","id":19940114,"node_id":"MDQ6VXNlcjE5OTQwMTE0","avatar_url":"https://avatars1.githubusercontent.com/u/19940114?v=4","gravatar_id":"","url":"https://api.github.com/users/codacy-bot","html_url":"https://github.com/codacy-bot","followers_url":"https://api.github.com/users/codacy-bot/followers","following_url":"https://api.github.com/users/codacy-bot/following{/other_user}","gists_url":"https://api.github.com/users/codacy-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/codacy-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codacy-bot/subscriptions","organizations_url":"https://api.github.com/users/codacy-bot/orgs","repos_url":"https://api.github.com/users/codacy-bot/repos","events_url":"https://api.github.com/users/codacy-bot/events{/privacy}","received_events_url":"https://api.github.com/users/codacy-bot/received_events","type":"User","site_admin":false},"body":" Issue found: [Missing method docstring](https://app.codacy.com/app/frank_10/quality-report/pullRequest?prid=1768309)","created_at":"2018-06-14T06:15:46Z","updated_at":"2018-06-14T06:15:46Z","html_url":"https://github.com/ICTU/quality-report/pull/426#discussion_r195311415","pull_request_url":"https://api.github.com/repos/ICTU/quality-report/pulls/426","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/ICTU/quality-report/pulls/comments/195311415"},"html":{"href":"https://github.com/ICTU/quality-report/pull/426#discussion_r195311415"},"pull_request":{"href":"https://api.github.com/repos/ICTU/quality-report/pulls/426"}}},"pull_request":{"url":"https://api.github.com/repos/ICTU/quality-report/pulls/426","id":194269504,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0MjY5NTA0","html_url":"https://github.com/ICTU/quality-report/pull/426","diff_url":"https://github.com/ICTU/quality-report/pull/426.diff","patch_url":"https://github.com/ICTU/quality-report/pull/426.patch","issue_url":"https://api.github.com/repos/ICTU/quality-report/issues/426","number":426,"state":"open","locked":false,"title":"Switch to pathlib","user":{"login":"eric-nieuwland","id":10603975,"node_id":"MDQ6VXNlcjEwNjAzOTc1","avatar_url":"https://avatars0.githubusercontent.com/u/10603975?v=4","gravatar_id":"","url":"https://api.github.com/users/eric-nieuwland","html_url":"https://github.com/eric-nieuwland","followers_url":"https://api.github.com/users/eric-nieuwland/followers","following_url":"https://api.github.com/users/eric-nieuwland/following{/other_user}","gists_url":"https://api.github.com/users/eric-nieuwland/gists{/gist_id}","starred_url":"https://api.github.com/users/eric-nieuwland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eric-nieuwland/subscriptions","organizations_url":"https://api.github.com/users/eric-nieuwland/orgs","repos_url":"https://api.github.com/users/eric-nieuwland/repos","events_url":"https://api.github.com/users/eric-nieuwland/events{/privacy}","received_events_url":"https://api.github.com/users/eric-nieuwland/received_events","type":"User","site_admin":false},"body":"Use pathlib instead of os.path and open().\r\nSome additional testing required as I don't have all the tools.","created_at":"2018-06-12T12:52:14Z","updated_at":"2018-06-14T06:15:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e75153e0415612eb55d4f90c6f971253f01c11ca","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ICTU/quality-report/pulls/426/commits","review_comments_url":"https://api.github.com/repos/ICTU/quality-report/pulls/426/comments","review_comment_url":"https://api.github.com/repos/ICTU/quality-report/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ICTU/quality-report/issues/426/comments","statuses_url":"https://api.github.com/repos/ICTU/quality-report/statuses/a4d058674a0f7e568cd130d9b6c3b245b204634c","head":{"label":"ICTU:switch-to-pathlib","ref":"switch-to-pathlib","sha":"a4d058674a0f7e568cd130d9b6c3b245b204634c","user":{"login":"ICTU","id":6009701,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYwMDk3MDE=","avatar_url":"https://avatars1.githubusercontent.com/u/6009701?v=4","gravatar_id":"","url":"https://api.github.com/users/ICTU","html_url":"https://github.com/ICTU","followers_url":"https://api.github.com/users/ICTU/followers","following_url":"https://api.github.com/users/ICTU/following{/other_user}","gists_url":"https://api.github.com/users/ICTU/gists{/gist_id}","starred_url":"https://api.github.com/users/ICTU/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ICTU/subscriptions","organizations_url":"https://api.github.com/users/ICTU/orgs","repos_url":"https://api.github.com/users/ICTU/repos","events_url":"https://api.github.com/users/ICTU/events{/privacy}","received_events_url":"https://api.github.com/users/ICTU/received_events","type":"Organization","site_admin":false},"repo":{"id":16836834,"node_id":"MDEwOlJlcG9zaXRvcnkxNjgzNjgzNA==","name":"quality-report","full_name":"ICTU/quality-report","owner":{"login":"ICTU","id":6009701,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYwMDk3MDE=","avatar_url":"https://avatars1.githubusercontent.com/u/6009701?v=4","gravatar_id":"","url":"https://api.github.com/users/ICTU","html_url":"https://github.com/ICTU","followers_url":"https://api.github.com/users/ICTU/followers","following_url":"https://api.github.com/users/ICTU/following{/other_user}","gists_url":"https://api.github.com/users/ICTU/gists{/gist_id}","starred_url":"https://api.github.com/users/ICTU/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ICTU/subscriptions","organizations_url":"https://api.github.com/users/ICTU/orgs","repos_url":"https://api.github.com/users/ICTU/repos","events_url":"https://api.github.com/users/ICTU/events{/privacy}","received_events_url":"https://api.github.com/users/ICTU/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ICTU/quality-report","description":"HQ - Holistic Software Quality Reporting","fork":false,"url":"https://api.github.com/repos/ICTU/quality-report","forks_url":"https://api.github.com/repos/ICTU/quality-report/forks","keys_url":"https://api.github.com/repos/ICTU/quality-report/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ICTU/quality-report/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ICTU/quality-report/teams","hooks_url":"https://api.github.com/repos/ICTU/quality-report/hooks","issue_events_url":"https://api.github.com/repos/ICTU/quality-report/issues/events{/number}","events_url":"https://api.github.com/repos/ICTU/quality-report/events","assignees_url":"https://api.github.com/repos/ICTU/quality-report/assignees{/user}","branches_url":"https://api.github.com/repos/ICTU/quality-report/branches{/branch}","tags_url":"https://api.github.com/repos/ICTU/quality-report/tags","blobs_url":"https://api.github.com/repos/ICTU/quality-report/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ICTU/quality-report/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ICTU/quality-report/git/refs{/sha}","trees_url":"https://api.github.com/repos/ICTU/quality-report/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ICTU/quality-report/statuses/{sha}","languages_url":"https://api.github.com/repos/ICTU/quality-report/languages","stargazers_url":"https://api.github.com/repos/ICTU/quality-report/stargazers","contributors_url":"https://api.github.com/repos/ICTU/quality-report/contributors","subscribers_url":"https://api.github.com/repos/ICTU/quality-report/subscribers","subscription_url":"https://api.github.com/repos/ICTU/quality-report/subscription","commits_url":"https://api.github.com/repos/ICTU/quality-report/commits{/sha}","git_commits_url":"https://api.github.com/repos/ICTU/quality-report/git/commits{/sha}","comments_url":"https://api.github.com/repos/ICTU/quality-report/comments{/number}","issue_comment_url":"https://api.github.com/repos/ICTU/quality-report/issues/comments{/number}","contents_url":"https://api.github.com/repos/ICTU/quality-report/contents/{+path}","compare_url":"https://api.github.com/repos/ICTU/quality-report/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ICTU/quality-report/merges","archive_url":"https://api.github.com/repos/ICTU/quality-report/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ICTU/quality-report/downloads","issues_url":"https://api.github.com/repos/ICTU/quality-report/issues{/number}","pulls_url":"https://api.github.com/repos/ICTU/quality-report/pulls{/number}","milestones_url":"https://api.github.com/repos/ICTU/quality-report/milestones{/number}","notifications_url":"https://api.github.com/repos/ICTU/quality-report/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ICTU/quality-report/labels{/name}","releases_url":"https://api.github.com/repos/ICTU/quality-report/releases{/id}","deployments_url":"https://api.github.com/repos/ICTU/quality-report/deployments","created_at":"2014-02-14T12:39:18Z","updated_at":"2018-06-13T13:43:28Z","pushed_at":"2018-06-14T06:13:48Z","git_url":"git://github.com/ICTU/quality-report.git","ssh_url":"[email protected]:ICTU/quality-report.git","clone_url":"https://github.com/ICTU/quality-report.git","svn_url":"https://github.com/ICTU/quality-report","homepage":"http://ictu.github.io/quality-report/","size":8698,"stargazers_count":15,"watchers_count":15,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":59,"license":null,"forks":5,"open_issues":59,"watchers":15,"default_branch":"master"}},"base":{"label":"ICTU:master","ref":"master","sha":"92efc6adc5a3bf584d3846ea99815046e80ff8a5","user":{"login":"ICTU","id":6009701,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYwMDk3MDE=","avatar_url":"https://avatars1.githubusercontent.com/u/6009701?v=4","gravatar_id":"","url":"https://api.github.com/users/ICTU","html_url":"https://github.com/ICTU","followers_url":"https://api.github.com/users/ICTU/followers","following_url":"https://api.github.com/users/ICTU/following{/other_user}","gists_url":"https://api.github.com/users/ICTU/gists{/gist_id}","starred_url":"https://api.github.com/users/ICTU/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ICTU/subscriptions","organizations_url":"https://api.github.com/users/ICTU/orgs","repos_url":"https://api.github.com/users/ICTU/repos","events_url":"https://api.github.com/users/ICTU/events{/privacy}","received_events_url":"https://api.github.com/users/ICTU/received_events","type":"Organization","site_admin":false},"repo":{"id":16836834,"node_id":"MDEwOlJlcG9zaXRvcnkxNjgzNjgzNA==","name":"quality-report","full_name":"ICTU/quality-report","owner":{"login":"ICTU","id":6009701,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYwMDk3MDE=","avatar_url":"https://avatars1.githubusercontent.com/u/6009701?v=4","gravatar_id":"","url":"https://api.github.com/users/ICTU","html_url":"https://github.com/ICTU","followers_url":"https://api.github.com/users/ICTU/followers","following_url":"https://api.github.com/users/ICTU/following{/other_user}","gists_url":"https://api.github.com/users/ICTU/gists{/gist_id}","starred_url":"https://api.github.com/users/ICTU/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ICTU/subscriptions","organizations_url":"https://api.github.com/users/ICTU/orgs","repos_url":"https://api.github.com/users/ICTU/repos","events_url":"https://api.github.com/users/ICTU/events{/privacy}","received_events_url":"https://api.github.com/users/ICTU/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ICTU/quality-report","description":"HQ - Holistic Software Quality Reporting","fork":false,"url":"https://api.github.com/repos/ICTU/quality-report","forks_url":"https://api.github.com/repos/ICTU/quality-report/forks","keys_url":"https://api.github.com/repos/ICTU/quality-report/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ICTU/quality-report/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ICTU/quality-report/teams","hooks_url":"https://api.github.com/repos/ICTU/quality-report/hooks","issue_events_url":"https://api.github.com/repos/ICTU/quality-report/issues/events{/number}","events_url":"https://api.github.com/repos/ICTU/quality-report/events","assignees_url":"https://api.github.com/repos/ICTU/quality-report/assignees{/user}","branches_url":"https://api.github.com/repos/ICTU/quality-report/branches{/branch}","tags_url":"https://api.github.com/repos/ICTU/quality-report/tags","blobs_url":"https://api.github.com/repos/ICTU/quality-report/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ICTU/quality-report/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ICTU/quality-report/git/refs{/sha}","trees_url":"https://api.github.com/repos/ICTU/quality-report/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ICTU/quality-report/statuses/{sha}","languages_url":"https://api.github.com/repos/ICTU/quality-report/languages","stargazers_url":"https://api.github.com/repos/ICTU/quality-report/stargazers","contributors_url":"https://api.github.com/repos/ICTU/quality-report/contributors","subscribers_url":"https://api.github.com/repos/ICTU/quality-report/subscribers","subscription_url":"https://api.github.com/repos/ICTU/quality-report/subscription","commits_url":"https://api.github.com/repos/ICTU/quality-report/commits{/sha}","git_commits_url":"https://api.github.com/repos/ICTU/quality-report/git/commits{/sha}","comments_url":"https://api.github.com/repos/ICTU/quality-report/comments{/number}","issue_comment_url":"https://api.github.com/repos/ICTU/quality-report/issues/comments{/number}","contents_url":"https://api.github.com/repos/ICTU/quality-report/contents/{+path}","compare_url":"https://api.github.com/repos/ICTU/quality-report/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ICTU/quality-report/merges","archive_url":"https://api.github.com/repos/ICTU/quality-report/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ICTU/quality-report/downloads","issues_url":"https://api.github.com/repos/ICTU/quality-report/issues{/number}","pulls_url":"https://api.github.com/repos/ICTU/quality-report/pulls{/number}","milestones_url":"https://api.github.com/repos/ICTU/quality-report/milestones{/number}","notifications_url":"https://api.github.com/repos/ICTU/quality-report/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ICTU/quality-report/labels{/name}","releases_url":"https://api.github.com/repos/ICTU/quality-report/releases{/id}","deployments_url":"https://api.github.com/repos/ICTU/quality-report/deployments","created_at":"2014-02-14T12:39:18Z","updated_at":"2018-06-13T13:43:28Z","pushed_at":"2018-06-14T06:13:48Z","git_url":"git://github.com/ICTU/quality-report.git","ssh_url":"[email protected]:ICTU/quality-report.git","clone_url":"https://github.com/ICTU/quality-report.git","svn_url":"https://github.com/ICTU/quality-report","homepage":"http://ictu.github.io/quality-report/","size":8698,"stargazers_count":15,"watchers_count":15,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":59,"license":null,"forks":5,"open_issues":59,"watchers":15,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ICTU/quality-report/pulls/426"},"html":{"href":"https://github.com/ICTU/quality-report/pull/426"},"issue":{"href":"https://api.github.com/repos/ICTU/quality-report/issues/426"},"comments":{"href":"https://api.github.com/repos/ICTU/quality-report/issues/426/comments"},"review_comments":{"href":"https://api.github.com/repos/ICTU/quality-report/pulls/426/comments"},"review_comment":{"href":"https://api.github.com/repos/ICTU/quality-report/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ICTU/quality-report/pulls/426/commits"},"statuses":{"href":"https://api.github.com/repos/ICTU/quality-report/statuses/a4d058674a0f7e568cd130d9b6c3b245b204634c"}},"author_association":"NONE"}} | {
"id": 16836834,
"name": "ICTU/quality-report",
"url": "https://api.github.com/repos/ICTU/quality-report"
} | {
"id": 19940114,
"login": "codacy-bot",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/19940114?",
"url": "https://api.github.com/users/codacy-bot"
} | {
"id": 6009701,
"login": "ICTU",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6009701?",
"url": "https://api.github.com/orgs/ICTU"
} | 2018-06-14T06:15:46 | 7823015861 | {"actor":{"display_login":"codacy-bot"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/norcams/himlar/pulls/comments/167852011","pull_request_review_id":96127290,"id":167852011,"diff_hunk":"@@ -46,8 +46,11 @@ netcfg_trp_rr:\n #\n service__address__mysql: \"db01.%{hiera('domain_trp')}\" #FIXME\n \n-# DNS server\n-public__address__ns_01: \"%{hiera('netcfg_public_netpart')}.16\"\n+# DNS servers\n+public__address__ns: \"%{hiera('netcfg_public_netpart')}.251\"\n+public6__address__ns: \"%{hiera('netcfg_public_netpart6')}::251\"\n+public__address__resolver_01: \"%{hiera('netcfg_public_netpart')}.252\"\n+public6__address__resolver_01: \"%{hiera('netcfg_public_netpart6')}::252\"","path":"hieradata/vagrant/common.yaml","position":10,"original_position":10,"commit_id":"e574aabe241dcf89e245b1781a88d031b9faf093","original_commit_id":"b0857b9ce802f813b62f702741ce3130a38c27b5","user":{"login":"trondham","id":3844865,"avatar_url":"https://avatars2.githubusercontent.com/u/3844865?v=4","gravatar_id":"","url":"https://api.github.com/users/trondham","html_url":"https://github.com/trondham","followers_url":"https://api.github.com/users/trondham/followers","following_url":"https://api.github.com/users/trondham/following{/other_user}","gists_url":"https://api.github.com/users/trondham/gists{/gist_id}","starred_url":"https://api.github.com/users/trondham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trondham/subscriptions","organizations_url":"https://api.github.com/users/trondham/orgs","repos_url":"https://api.github.com/users/trondham/repos","events_url":"https://api.github.com/users/trondham/events{/privacy}","received_events_url":"https://api.github.com/users/trondham/received_events","type":"User","site_admin":false},"body":"Ikke mulig å unngå hvis vi vil teste at AAAA records og slikt fungerer i vagrant, jeg vil beholde det","created_at":"2018-02-13T12:42:55Z","updated_at":"2018-02-13T12:42:56Z","html_url":"https://github.com/norcams/himlar/pull/387#discussion_r167852011","pull_request_url":"https://api.github.com/repos/norcams/himlar/pulls/387","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/norcams/himlar/pulls/comments/167852011"},"html":{"href":"https://github.com/norcams/himlar/pull/387#discussion_r167852011"},"pull_request":{"href":"https://api.github.com/repos/norcams/himlar/pulls/387"}},"in_reply_to_id":167844474},"pull_request":{"url":"https://api.github.com/repos/norcams/himlar/pulls/387","id":168467203,"html_url":"https://github.com/norcams/himlar/pull/387","diff_url":"https://github.com/norcams/himlar/pull/387.diff","patch_url":"https://github.com/norcams/himlar/pull/387.patch","issue_url":"https://api.github.com/repos/norcams/himlar/issues/387","number":387,"state":"open","locked":false,"title":"add authoritative dns server and resolvers","user":{"login":"trondham","id":3844865,"avatar_url":"https://avatars2.githubusercontent.com/u/3844865?v=4","gravatar_id":"","url":"https://api.github.com/users/trondham","html_url":"https://github.com/trondham","followers_url":"https://api.github.com/users/trondham/followers","following_url":"https://api.github.com/users/trondham/following{/other_user}","gists_url":"https://api.github.com/users/trondham/gists{/gist_id}","starred_url":"https://api.github.com/users/trondham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trondham/subscriptions","organizations_url":"https://api.github.com/users/trondham/orgs","repos_url":"https://api.github.com/users/trondham/repos","events_url":"https://api.github.com/users/trondham/events{/privacy}","received_events_url":"https://api.github.com/users/trondham/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-02-11T18:39:34Z","updated_at":"2018-02-13T12:42:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"44235121d478b7f21f3730e90d28bb057c86adca","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/norcams/himlar/pulls/387/commits","review_comments_url":"https://api.github.com/repos/norcams/himlar/pulls/387/comments","review_comment_url":"https://api.github.com/repos/norcams/himlar/pulls/comments{/number}","comments_url":"https://api.github.com/repos/norcams/himlar/issues/387/comments","statuses_url":"https://api.github.com/repos/norcams/himlar/statuses/e574aabe241dcf89e245b1781a88d031b9faf093","head":{"label":"trondham:dns-noder","ref":"dns-noder","sha":"e574aabe241dcf89e245b1781a88d031b9faf093","user":{"login":"trondham","id":3844865,"avatar_url":"https://avatars2.githubusercontent.com/u/3844865?v=4","gravatar_id":"","url":"https://api.github.com/users/trondham","html_url":"https://github.com/trondham","followers_url":"https://api.github.com/users/trondham/followers","following_url":"https://api.github.com/users/trondham/following{/other_user}","gists_url":"https://api.github.com/users/trondham/gists{/gist_id}","starred_url":"https://api.github.com/users/trondham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trondham/subscriptions","organizations_url":"https://api.github.com/users/trondham/orgs","repos_url":"https://api.github.com/users/trondham/repos","events_url":"https://api.github.com/users/trondham/events{/privacy}","received_events_url":"https://api.github.com/users/trondham/received_events","type":"User","site_admin":false},"repo":{"id":59831945,"name":"himlar","full_name":"trondham/himlar","owner":{"login":"trondham","id":3844865,"avatar_url":"https://avatars2.githubusercontent.com/u/3844865?v=4","gravatar_id":"","url":"https://api.github.com/users/trondham","html_url":"https://github.com/trondham","followers_url":"https://api.github.com/users/trondham/followers","following_url":"https://api.github.com/users/trondham/following{/other_user}","gists_url":"https://api.github.com/users/trondham/gists{/gist_id}","starred_url":"https://api.github.com/users/trondham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trondham/subscriptions","organizations_url":"https://api.github.com/users/trondham/orgs","repos_url":"https://api.github.com/users/trondham/repos","events_url":"https://api.github.com/users/trondham/events{/privacy}","received_events_url":"https://api.github.com/users/trondham/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/trondham/himlar","description":"himlar m. plural indefinite of himmel","fork":true,"url":"https://api.github.com/repos/trondham/himlar","forks_url":"https://api.github.com/repos/trondham/himlar/forks","keys_url":"https://api.github.com/repos/trondham/himlar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/trondham/himlar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/trondham/himlar/teams","hooks_url":"https://api.github.com/repos/trondham/himlar/hooks","issue_events_url":"https://api.github.com/repos/trondham/himlar/issues/events{/number}","events_url":"https://api.github.com/repos/trondham/himlar/events","assignees_url":"https://api.github.com/repos/trondham/himlar/assignees{/user}","branches_url":"https://api.github.com/repos/trondham/himlar/branches{/branch}","tags_url":"https://api.github.com/repos/trondham/himlar/tags","blobs_url":"https://api.github.com/repos/trondham/himlar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/trondham/himlar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/trondham/himlar/git/refs{/sha}","trees_url":"https://api.github.com/repos/trondham/himlar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/trondham/himlar/statuses/{sha}","languages_url":"https://api.github.com/repos/trondham/himlar/languages","stargazers_url":"https://api.github.com/repos/trondham/himlar/stargazers","contributors_url":"https://api.github.com/repos/trondham/himlar/contributors","subscribers_url":"https://api.github.com/repos/trondham/himlar/subscribers","subscription_url":"https://api.github.com/repos/trondham/himlar/subscription","commits_url":"https://api.github.com/repos/trondham/himlar/commits{/sha}","git_commits_url":"https://api.github.com/repos/trondham/himlar/git/commits{/sha}","comments_url":"https://api.github.com/repos/trondham/himlar/comments{/number}","issue_comment_url":"https://api.github.com/repos/trondham/himlar/issues/comments{/number}","contents_url":"https://api.github.com/repos/trondham/himlar/contents/{+path}","compare_url":"https://api.github.com/repos/trondham/himlar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/trondham/himlar/merges","archive_url":"https://api.github.com/repos/trondham/himlar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/trondham/himlar/downloads","issues_url":"https://api.github.com/repos/trondham/himlar/issues{/number}","pulls_url":"https://api.github.com/repos/trondham/himlar/pulls{/number}","milestones_url":"https://api.github.com/repos/trondham/himlar/milestones{/number}","notifications_url":"https://api.github.com/repos/trondham/himlar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/trondham/himlar/labels{/name}","releases_url":"https://api.github.com/repos/trondham/himlar/releases{/id}","deployments_url":"https://api.github.com/repos/trondham/himlar/deployments","created_at":"2016-05-27T12:11:31Z","updated_at":"2016-05-27T12:11:33Z","pushed_at":"2018-02-13T12:42:10Z","git_url":"git://github.com/trondham/himlar.git","ssh_url":"[email protected]:trondham/himlar.git","clone_url":"https://github.com/trondham/himlar.git","svn_url":"https://github.com/trondham/himlar","homepage":null,"size":3328,"stargazers_count":0,"watchers_count":0,"language":"Puppet","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"norcams:master","ref":"master","sha":"48ef20c6aa8e6c350096c608980123c8608680fa","user":{"login":"norcams","id":6114661,"avatar_url":"https://avatars0.githubusercontent.com/u/6114661?v=4","gravatar_id":"","url":"https://api.github.com/users/norcams","html_url":"https://github.com/norcams","followers_url":"https://api.github.com/users/norcams/followers","following_url":"https://api.github.com/users/norcams/following{/other_user}","gists_url":"https://api.github.com/users/norcams/gists{/gist_id}","starred_url":"https://api.github.com/users/norcams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/norcams/subscriptions","organizations_url":"https://api.github.com/users/norcams/orgs","repos_url":"https://api.github.com/users/norcams/repos","events_url":"https://api.github.com/users/norcams/events{/privacy}","received_events_url":"https://api.github.com/users/norcams/received_events","type":"Organization","site_admin":false},"repo":{"id":26901774,"name":"himlar","full_name":"norcams/himlar","owner":{"login":"norcams","id":6114661,"avatar_url":"https://avatars0.githubusercontent.com/u/6114661?v=4","gravatar_id":"","url":"https://api.github.com/users/norcams","html_url":"https://github.com/norcams","followers_url":"https://api.github.com/users/norcams/followers","following_url":"https://api.github.com/users/norcams/following{/other_user}","gists_url":"https://api.github.com/users/norcams/gists{/gist_id}","starred_url":"https://api.github.com/users/norcams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/norcams/subscriptions","organizations_url":"https://api.github.com/users/norcams/orgs","repos_url":"https://api.github.com/users/norcams/repos","events_url":"https://api.github.com/users/norcams/events{/privacy}","received_events_url":"https://api.github.com/users/norcams/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/norcams/himlar","description":"himlar m. plural indefinite of himmel","fork":false,"url":"https://api.github.com/repos/norcams/himlar","forks_url":"https://api.github.com/repos/norcams/himlar/forks","keys_url":"https://api.github.com/repos/norcams/himlar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/norcams/himlar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/norcams/himlar/teams","hooks_url":"https://api.github.com/repos/norcams/himlar/hooks","issue_events_url":"https://api.github.com/repos/norcams/himlar/issues/events{/number}","events_url":"https://api.github.com/repos/norcams/himlar/events","assignees_url":"https://api.github.com/repos/norcams/himlar/assignees{/user}","branches_url":"https://api.github.com/repos/norcams/himlar/branches{/branch}","tags_url":"https://api.github.com/repos/norcams/himlar/tags","blobs_url":"https://api.github.com/repos/norcams/himlar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/norcams/himlar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/norcams/himlar/git/refs{/sha}","trees_url":"https://api.github.com/repos/norcams/himlar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/norcams/himlar/statuses/{sha}","languages_url":"https://api.github.com/repos/norcams/himlar/languages","stargazers_url":"https://api.github.com/repos/norcams/himlar/stargazers","contributors_url":"https://api.github.com/repos/norcams/himlar/contributors","subscribers_url":"https://api.github.com/repos/norcams/himlar/subscribers","subscription_url":"https://api.github.com/repos/norcams/himlar/subscription","commits_url":"https://api.github.com/repos/norcams/himlar/commits{/sha}","git_commits_url":"https://api.github.com/repos/norcams/himlar/git/commits{/sha}","comments_url":"https://api.github.com/repos/norcams/himlar/comments{/number}","issue_comment_url":"https://api.github.com/repos/norcams/himlar/issues/comments{/number}","contents_url":"https://api.github.com/repos/norcams/himlar/contents/{+path}","compare_url":"https://api.github.com/repos/norcams/himlar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/norcams/himlar/merges","archive_url":"https://api.github.com/repos/norcams/himlar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/norcams/himlar/downloads","issues_url":"https://api.github.com/repos/norcams/himlar/issues{/number}","pulls_url":"https://api.github.com/repos/norcams/himlar/pulls{/number}","milestones_url":"https://api.github.com/repos/norcams/himlar/milestones{/number}","notifications_url":"https://api.github.com/repos/norcams/himlar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/norcams/himlar/labels{/name}","releases_url":"https://api.github.com/repos/norcams/himlar/releases{/id}","deployments_url":"https://api.github.com/repos/norcams/himlar/deployments","created_at":"2014-11-20T07:53:48Z","updated_at":"2016-10-24T09:29:17Z","pushed_at":"2018-02-13T12:42:11Z","git_url":"git://github.com/norcams/himlar.git","ssh_url":"[email protected]:norcams/himlar.git","clone_url":"https://github.com/norcams/himlar.git","svn_url":"https://github.com/norcams/himlar","homepage":null,"size":3121,"stargazers_count":3,"watchers_count":3,"language":"Puppet","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":12,"mirror_url":null,"archived":false,"open_issues_count":9,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":12,"open_issues":9,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/norcams/himlar/pulls/387"},"html":{"href":"https://github.com/norcams/himlar/pull/387"},"issue":{"href":"https://api.github.com/repos/norcams/himlar/issues/387"},"comments":{"href":"https://api.github.com/repos/norcams/himlar/issues/387/comments"},"review_comments":{"href":"https://api.github.com/repos/norcams/himlar/pulls/387/comments"},"review_comment":{"href":"https://api.github.com/repos/norcams/himlar/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/norcams/himlar/pulls/387/commits"},"statuses":{"href":"https://api.github.com/repos/norcams/himlar/statuses/e574aabe241dcf89e245b1781a88d031b9faf093"}},"author_association":"CONTRIBUTOR"}} | {
"id": 26901774,
"name": "norcams/himlar",
"url": "https://api.github.com/repos/norcams/himlar"
} | {
"id": 3844865,
"login": "trondham",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3844865?",
"url": "https://api.github.com/users/trondham"
} | {
"id": 6114661,
"login": "norcams",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6114661?",
"url": "https://api.github.com/orgs/norcams"
} | 2018-02-13T12:42:55 | 7237874330 | {"actor":{"display_login":"trondham"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/Opentrons/Protocols/pulls/comments/184188975","pull_request_review_id":115333748,"id":184188975,"diff_hunk":"@@ -50,7 +52,7 @@ def run_custom_protocol(\n labware.load(destination_container, slotName)\n for slotName in dest_slots]\n \n- source_plate = labware.load(source_container, 'C2')","path":"protocols/plate_copying/plate_copying.ot2.py","position":17,"original_position":17,"commit_id":"7ed162bbd605023987f5868d183d0e0241f94c45","original_commit_id":"7ed162bbd605023987f5868d183d0e0241f94c45","user":{"login":"IanLondon","id":11590381,"avatar_url":"https://avatars0.githubusercontent.com/u/11590381?v=4","gravatar_id":"","url":"https://api.github.com/users/IanLondon","html_url":"https://github.com/IanLondon","followers_url":"https://api.github.com/users/IanLondon/followers","following_url":"https://api.github.com/users/IanLondon/following{/other_user}","gists_url":"https://api.github.com/users/IanLondon/gists{/gist_id}","starred_url":"https://api.github.com/users/IanLondon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IanLondon/subscriptions","organizations_url":"https://api.github.com/users/IanLondon/orgs","repos_url":"https://api.github.com/users/IanLondon/repos","events_url":"https://api.github.com/users/IanLondon/events{/privacy}","received_events_url":"https://api.github.com/users/IanLondon/received_events","type":"User","site_admin":false},"body":"C2 is automatically set to 6, and there was already a destination container in slot 6","created_at":"2018-04-25T20:03:43Z","updated_at":"2018-04-25T20:03:44Z","html_url":"https://github.com/Opentrons/Protocols/pull/190#discussion_r184188975","pull_request_url":"https://api.github.com/repos/Opentrons/Protocols/pulls/190","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Opentrons/Protocols/pulls/comments/184188975"},"html":{"href":"https://github.com/Opentrons/Protocols/pull/190#discussion_r184188975"},"pull_request":{"href":"https://api.github.com/repos/Opentrons/Protocols/pulls/190"}}},"pull_request":{"url":"https://api.github.com/repos/Opentrons/Protocols/pulls/190","id":184147718,"html_url":"https://github.com/Opentrons/Protocols/pull/190","diff_url":"https://github.com/Opentrons/Protocols/pull/190.diff","patch_url":"https://github.com/Opentrons/Protocols/pull/190.patch","issue_url":"https://api.github.com/repos/Opentrons/Protocols/issues/190","number":190,"state":"open","locked":false,"title":"update smoketest to run manually; fix 3 OT2 protocols","user":{"login":"IanLondon","id":11590381,"avatar_url":"https://avatars0.githubusercontent.com/u/11590381?v=4","gravatar_id":"","url":"https://api.github.com/users/IanLondon","html_url":"https://github.com/IanLondon","followers_url":"https://api.github.com/users/IanLondon/followers","following_url":"https://api.github.com/users/IanLondon/following{/other_user}","gists_url":"https://api.github.com/users/IanLondon/gists{/gist_id}","starred_url":"https://api.github.com/users/IanLondon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IanLondon/subscriptions","organizations_url":"https://api.github.com/users/IanLondon/orgs","repos_url":"https://api.github.com/users/IanLondon/repos","events_url":"https://api.github.com/users/IanLondon/events{/privacy}","received_events_url":"https://api.github.com/users/IanLondon/received_events","type":"User","site_admin":false},"body":"# Overview\r\n\r\nAmends `smoke-test.sh` to be used manually to check that OT2 protocols at least run under whatever version of `opentrons` python API you have installed.\r\n\r\nI found 3 protocols that didn't run and attempted to fix them. Please check my updates.\r\n\r\n# To manually smoke-test OT2 protocols:\r\n\r\nInstall opentrons python API (eg `make dev` in opentrons monorepo), then:\r\n\r\n```\r\npip install -e otcustomizers\r\n./scripts/smoke-test.sh\r\n```\r\n\r\n# Known issues with `smoke-test.sh`\r\n\r\n* Probably won't work on Windows?\r\n* OT2 protocols using delay or time.sleep must only do it `if not os.environ.get('OT_TESTING'):`, or else that protocol will make the smoke tests delay/sleep for whatever interval\r\n* `smoke-test.sh` does not ignore dirs with `.ignore` in them. To ignore a `*.ot2.py` file, rename it temporarily to something like `*ot2.py.ignore` or whatever -- just need to change the suffix so `smoke-test.sh` won't pick it up\r\n\r\nAlso, customizable protocols are only run with default arguments. There may easily be other arguments that cause it not to complete.","created_at":"2018-04-25T20:02:58Z","updated_at":"2018-04-25T20:03:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1cb8840066f606be6071ba30396515cdd02b480f","assignee":null,"assignees":[],"requested_reviewers":[{"login":"Laura-Danielle","id":31892318,"avatar_url":"https://avatars3.githubusercontent.com/u/31892318?v=4","gravatar_id":"","url":"https://api.github.com/users/Laura-Danielle","html_url":"https://github.com/Laura-Danielle","followers_url":"https://api.github.com/users/Laura-Danielle/followers","following_url":"https://api.github.com/users/Laura-Danielle/following{/other_user}","gists_url":"https://api.github.com/users/Laura-Danielle/gists{/gist_id}","starred_url":"https://api.github.com/users/Laura-Danielle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Laura-Danielle/subscriptions","organizations_url":"https://api.github.com/users/Laura-Danielle/orgs","repos_url":"https://api.github.com/users/Laura-Danielle/repos","events_url":"https://api.github.com/users/Laura-Danielle/events{/privacy}","received_events_url":"https://api.github.com/users/Laura-Danielle/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Opentrons/Protocols/pulls/190/commits","review_comments_url":"https://api.github.com/repos/Opentrons/Protocols/pulls/190/comments","review_comment_url":"https://api.github.com/repos/Opentrons/Protocols/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Opentrons/Protocols/issues/190/comments","statuses_url":"https://api.github.com/repos/Opentrons/Protocols/statuses/7ed162bbd605023987f5868d183d0e0241f94c45","head":{"label":"Opentrons:manual-ot2-check-script","ref":"manual-ot2-check-script","sha":"7ed162bbd605023987f5868d183d0e0241f94c45","user":{"login":"Opentrons","id":6139147,"avatar_url":"https://avatars2.githubusercontent.com/u/6139147?v=4","gravatar_id":"","url":"https://api.github.com/users/Opentrons","html_url":"https://github.com/Opentrons","followers_url":"https://api.github.com/users/Opentrons/followers","following_url":"https://api.github.com/users/Opentrons/following{/other_user}","gists_url":"https://api.github.com/users/Opentrons/gists{/gist_id}","starred_url":"https://api.github.com/users/Opentrons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Opentrons/subscriptions","organizations_url":"https://api.github.com/users/Opentrons/orgs","repos_url":"https://api.github.com/users/Opentrons/repos","events_url":"https://api.github.com/users/Opentrons/events{/privacy}","received_events_url":"https://api.github.com/users/Opentrons/received_events","type":"Organization","site_admin":false},"repo":{"id":75848965,"name":"Protocols","full_name":"Opentrons/Protocols","owner":{"login":"Opentrons","id":6139147,"avatar_url":"https://avatars2.githubusercontent.com/u/6139147?v=4","gravatar_id":"","url":"https://api.github.com/users/Opentrons","html_url":"https://github.com/Opentrons","followers_url":"https://api.github.com/users/Opentrons/followers","following_url":"https://api.github.com/users/Opentrons/following{/other_user}","gists_url":"https://api.github.com/users/Opentrons/gists{/gist_id}","starred_url":"https://api.github.com/users/Opentrons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Opentrons/subscriptions","organizations_url":"https://api.github.com/users/Opentrons/orgs","repos_url":"https://api.github.com/users/Opentrons/repos","events_url":"https://api.github.com/users/Opentrons/events{/privacy}","received_events_url":"https://api.github.com/users/Opentrons/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Opentrons/Protocols","description":"Repository for Public Protocols","fork":false,"url":"https://api.github.com/repos/Opentrons/Protocols","forks_url":"https://api.github.com/repos/Opentrons/Protocols/forks","keys_url":"https://api.github.com/repos/Opentrons/Protocols/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Opentrons/Protocols/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Opentrons/Protocols/teams","hooks_url":"https://api.github.com/repos/Opentrons/Protocols/hooks","issue_events_url":"https://api.github.com/repos/Opentrons/Protocols/issues/events{/number}","events_url":"https://api.github.com/repos/Opentrons/Protocols/events","assignees_url":"https://api.github.com/repos/Opentrons/Protocols/assignees{/user}","branches_url":"https://api.github.com/repos/Opentrons/Protocols/branches{/branch}","tags_url":"https://api.github.com/repos/Opentrons/Protocols/tags","blobs_url":"https://api.github.com/repos/Opentrons/Protocols/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Opentrons/Protocols/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Opentrons/Protocols/git/refs{/sha}","trees_url":"https://api.github.com/repos/Opentrons/Protocols/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Opentrons/Protocols/statuses/{sha}","languages_url":"https://api.github.com/repos/Opentrons/Protocols/languages","stargazers_url":"https://api.github.com/repos/Opentrons/Protocols/stargazers","contributors_url":"https://api.github.com/repos/Opentrons/Protocols/contributors","subscribers_url":"https://api.github.com/repos/Opentrons/Protocols/subscribers","subscription_url":"https://api.github.com/repos/Opentrons/Protocols/subscription","commits_url":"https://api.github.com/repos/Opentrons/Protocols/commits{/sha}","git_commits_url":"https://api.github.com/repos/Opentrons/Protocols/git/commits{/sha}","comments_url":"https://api.github.com/repos/Opentrons/Protocols/comments{/number}","issue_comment_url":"https://api.github.com/repos/Opentrons/Protocols/issues/comments{/number}","contents_url":"https://api.github.com/repos/Opentrons/Protocols/contents/{+path}","compare_url":"https://api.github.com/repos/Opentrons/Protocols/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Opentrons/Protocols/merges","archive_url":"https://api.github.com/repos/Opentrons/Protocols/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Opentrons/Protocols/downloads","issues_url":"https://api.github.com/repos/Opentrons/Protocols/issues{/number}","pulls_url":"https://api.github.com/repos/Opentrons/Protocols/pulls{/number}","milestones_url":"https://api.github.com/repos/Opentrons/Protocols/milestones{/number}","notifications_url":"https://api.github.com/repos/Opentrons/Protocols/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Opentrons/Protocols/labels{/name}","releases_url":"https://api.github.com/repos/Opentrons/Protocols/releases{/id}","deployments_url":"https://api.github.com/repos/Opentrons/Protocols/deployments","created_at":"2016-12-07T15:26:34Z","updated_at":"2018-04-25T19:10:19Z","pushed_at":"2018-04-25T20:02:59Z","git_url":"git://github.com/Opentrons/Protocols.git","ssh_url":"[email protected]:Opentrons/Protocols.git","clone_url":"https://github.com/Opentrons/Protocols.git","svn_url":"https://github.com/Opentrons/Protocols","homepage":"http://protocols.opentrons.com","size":660,"stargazers_count":11,"watchers_count":11,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":17,"license":null,"forks":5,"open_issues":17,"watchers":11,"default_branch":"develop"}},"base":{"label":"Opentrons:develop","ref":"develop","sha":"7113e0f7cc6c25345bc864b901b3f6df91124e18","user":{"login":"Opentrons","id":6139147,"avatar_url":"https://avatars2.githubusercontent.com/u/6139147?v=4","gravatar_id":"","url":"https://api.github.com/users/Opentrons","html_url":"https://github.com/Opentrons","followers_url":"https://api.github.com/users/Opentrons/followers","following_url":"https://api.github.com/users/Opentrons/following{/other_user}","gists_url":"https://api.github.com/users/Opentrons/gists{/gist_id}","starred_url":"https://api.github.com/users/Opentrons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Opentrons/subscriptions","organizations_url":"https://api.github.com/users/Opentrons/orgs","repos_url":"https://api.github.com/users/Opentrons/repos","events_url":"https://api.github.com/users/Opentrons/events{/privacy}","received_events_url":"https://api.github.com/users/Opentrons/received_events","type":"Organization","site_admin":false},"repo":{"id":75848965,"name":"Protocols","full_name":"Opentrons/Protocols","owner":{"login":"Opentrons","id":6139147,"avatar_url":"https://avatars2.githubusercontent.com/u/6139147?v=4","gravatar_id":"","url":"https://api.github.com/users/Opentrons","html_url":"https://github.com/Opentrons","followers_url":"https://api.github.com/users/Opentrons/followers","following_url":"https://api.github.com/users/Opentrons/following{/other_user}","gists_url":"https://api.github.com/users/Opentrons/gists{/gist_id}","starred_url":"https://api.github.com/users/Opentrons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Opentrons/subscriptions","organizations_url":"https://api.github.com/users/Opentrons/orgs","repos_url":"https://api.github.com/users/Opentrons/repos","events_url":"https://api.github.com/users/Opentrons/events{/privacy}","received_events_url":"https://api.github.com/users/Opentrons/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Opentrons/Protocols","description":"Repository for Public Protocols","fork":false,"url":"https://api.github.com/repos/Opentrons/Protocols","forks_url":"https://api.github.com/repos/Opentrons/Protocols/forks","keys_url":"https://api.github.com/repos/Opentrons/Protocols/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Opentrons/Protocols/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Opentrons/Protocols/teams","hooks_url":"https://api.github.com/repos/Opentrons/Protocols/hooks","issue_events_url":"https://api.github.com/repos/Opentrons/Protocols/issues/events{/number}","events_url":"https://api.github.com/repos/Opentrons/Protocols/events","assignees_url":"https://api.github.com/repos/Opentrons/Protocols/assignees{/user}","branches_url":"https://api.github.com/repos/Opentrons/Protocols/branches{/branch}","tags_url":"https://api.github.com/repos/Opentrons/Protocols/tags","blobs_url":"https://api.github.com/repos/Opentrons/Protocols/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Opentrons/Protocols/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Opentrons/Protocols/git/refs{/sha}","trees_url":"https://api.github.com/repos/Opentrons/Protocols/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Opentrons/Protocols/statuses/{sha}","languages_url":"https://api.github.com/repos/Opentrons/Protocols/languages","stargazers_url":"https://api.github.com/repos/Opentrons/Protocols/stargazers","contributors_url":"https://api.github.com/repos/Opentrons/Protocols/contributors","subscribers_url":"https://api.github.com/repos/Opentrons/Protocols/subscribers","subscription_url":"https://api.github.com/repos/Opentrons/Protocols/subscription","commits_url":"https://api.github.com/repos/Opentrons/Protocols/commits{/sha}","git_commits_url":"https://api.github.com/repos/Opentrons/Protocols/git/commits{/sha}","comments_url":"https://api.github.com/repos/Opentrons/Protocols/comments{/number}","issue_comment_url":"https://api.github.com/repos/Opentrons/Protocols/issues/comments{/number}","contents_url":"https://api.github.com/repos/Opentrons/Protocols/contents/{+path}","compare_url":"https://api.github.com/repos/Opentrons/Protocols/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Opentrons/Protocols/merges","archive_url":"https://api.github.com/repos/Opentrons/Protocols/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Opentrons/Protocols/downloads","issues_url":"https://api.github.com/repos/Opentrons/Protocols/issues{/number}","pulls_url":"https://api.github.com/repos/Opentrons/Protocols/pulls{/number}","milestones_url":"https://api.github.com/repos/Opentrons/Protocols/milestones{/number}","notifications_url":"https://api.github.com/repos/Opentrons/Protocols/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Opentrons/Protocols/labels{/name}","releases_url":"https://api.github.com/repos/Opentrons/Protocols/releases{/id}","deployments_url":"https://api.github.com/repos/Opentrons/Protocols/deployments","created_at":"2016-12-07T15:26:34Z","updated_at":"2018-04-25T19:10:19Z","pushed_at":"2018-04-25T20:02:59Z","git_url":"git://github.com/Opentrons/Protocols.git","ssh_url":"[email protected]:Opentrons/Protocols.git","clone_url":"https://github.com/Opentrons/Protocols.git","svn_url":"https://github.com/Opentrons/Protocols","homepage":"http://protocols.opentrons.com","size":660,"stargazers_count":11,"watchers_count":11,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":17,"license":null,"forks":5,"open_issues":17,"watchers":11,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/Opentrons/Protocols/pulls/190"},"html":{"href":"https://github.com/Opentrons/Protocols/pull/190"},"issue":{"href":"https://api.github.com/repos/Opentrons/Protocols/issues/190"},"comments":{"href":"https://api.github.com/repos/Opentrons/Protocols/issues/190/comments"},"review_comments":{"href":"https://api.github.com/repos/Opentrons/Protocols/pulls/190/comments"},"review_comment":{"href":"https://api.github.com/repos/Opentrons/Protocols/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Opentrons/Protocols/pulls/190/commits"},"statuses":{"href":"https://api.github.com/repos/Opentrons/Protocols/statuses/7ed162bbd605023987f5868d183d0e0241f94c45"}},"author_association":"MEMBER"}} | {
"id": 75848965,
"name": "Opentrons/Protocols",
"url": "https://api.github.com/repos/Opentrons/Protocols"
} | {
"id": 11590381,
"login": "IanLondon",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/11590381?",
"url": "https://api.github.com/users/IanLondon"
} | {
"id": 6139147,
"login": "Opentrons",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6139147?",
"url": "https://api.github.com/orgs/Opentrons"
} | 2018-04-25T20:03:43 | 7587210340 | {"actor":{"display_login":"IanLondon"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/pai/pulls/comments/226819693","pull_request_review_id":166741882,"id":226819693,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNjgxOTY5Mw==","diff_hunk":"@@ -0,0 +1,97 @@\n+#coding=utf-8\n+\n+import os\n+import time\n+import random\n+import logging\n+import argparse\n+from flask import Flask, render_template, request, redirect, send_from_directory\n+\n+from ocrLibrary.OcrHandle import getOcrMethod\n+from ocrLibrary.Imgtools import drawResults\n+\n+\n+def getRandomStr(length=8):\n+ seed = \"1234567890abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ\"\n+ return ''.join(random.sample(seed, length))\n+\n+\n+app = Flask(__name__)\n+\n+\n+def setLoggerFormat(logFile=\"flask.log\", logLevel=\"INFO\"):\n+\n+ fh = logging.FileHandler(logFile, 'w')\n+ fh.setLevel(logLevel)\n+\n+ formatter = logging.Formatter('[%(asctime)s] %(name)s:%(levelname)s: %(message)s')\n+ fh.setFormatter(formatter)\n+\n+ app.logger.addHandler(fh)\n+ app.logger.setLevel(logLevel)\n+\n+\[email protected](\"/\", methods=[\"GET\"])\n+def index():\n+ context = {\"imgPath\": \"../static/upload.png\",\n+ \"info\": \"Click for select, only support English\"\n+ }\n+ return render_template(\"index.html\", **context)\n+\n+\[email protected](\"/\", methods=[\"POST\"])\n+def uploadimage():\n+ try:\n+ img = request.files[\"filechoose\"]\n+ base, ext = os.path.splitext(img.filename)\n+ base += time.strftime(\"_%Y%m%d%H%M%S_\", time.localtime(time.time())) + getRandomStr(8)","path":"examples/ocr-serving/copied_file/request_ocr/app.py","position":47,"original_position":47,"commit_id":"f26b6ca8dd852f3dff55c611d610a6eaef04a89d","original_commit_id":"f26b6ca8dd852f3dff55c611d610a6eaef04a89d","user":{"login":"mzmssg","id":11887940,"node_id":"MDQ6VXNlcjExODg3OTQw","avatar_url":"https://avatars3.githubusercontent.com/u/11887940?v=4","gravatar_id":"","url":"https://api.github.com/users/mzmssg","html_url":"https://github.com/mzmssg","followers_url":"https://api.github.com/users/mzmssg/followers","following_url":"https://api.github.com/users/mzmssg/following{/other_user}","gists_url":"https://api.github.com/users/mzmssg/gists{/gist_id}","starred_url":"https://api.github.com/users/mzmssg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mzmssg/subscriptions","organizations_url":"https://api.github.com/users/mzmssg/orgs","repos_url":"https://api.github.com/users/mzmssg/repos","events_url":"https://api.github.com/users/mzmssg/events{/privacy}","received_events_url":"https://api.github.com/users/mzmssg/received_events","type":"User","site_admin":false},"body":"A request may be sent multi times, second level filename isn't enough to distinguish them. There might be a writing race condition.","created_at":"2018-10-20T07:50:11Z","updated_at":"2018-10-20T07:50:11Z","html_url":"https://github.com/Microsoft/pai/pull/1549#discussion_r226819693","pull_request_url":"https://api.github.com/repos/Microsoft/pai/pulls/1549","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/pai/pulls/comments/226819693"},"html":{"href":"https://github.com/Microsoft/pai/pull/1549#discussion_r226819693"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/pai/pulls/1549"}},"in_reply_to_id":226614429},"pull_request":{"url":"https://api.github.com/repos/Microsoft/pai/pulls/1549","id":223818672,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIzODE4Njcy","html_url":"https://github.com/Microsoft/pai/pull/1549","diff_url":"https://github.com/Microsoft/pai/pull/1549.diff","patch_url":"https://github.com/Microsoft/pai/pull/1549.patch","issue_url":"https://api.github.com/repos/Microsoft/pai/issues/1549","number":1549,"state":"open","locked":false,"title":"OCR opensource example","user":{"login":"mzmssg","id":11887940,"node_id":"MDQ6VXNlcjExODg3OTQw","avatar_url":"https://avatars3.githubusercontent.com/u/11887940?v=4","gravatar_id":"","url":"https://api.github.com/users/mzmssg","html_url":"https://github.com/mzmssg","followers_url":"https://api.github.com/users/mzmssg/followers","following_url":"https://api.github.com/users/mzmssg/following{/other_user}","gists_url":"https://api.github.com/users/mzmssg/gists{/gist_id}","starred_url":"https://api.github.com/users/mzmssg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mzmssg/subscriptions","organizations_url":"https://api.github.com/users/mzmssg/orgs","repos_url":"https://api.github.com/users/mzmssg/repos","events_url":"https://api.github.com/users/mzmssg/events{/privacy}","received_events_url":"https://api.github.com/users/mzmssg/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-10-18T03:58:55Z","updated_at":"2018-10-20T07:50:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"083cea7021c55f13af2aabc3dd990b8c292902ac","assignee":null,"assignees":[],"requested_reviewers":[{"login":"wangcan0329","id":10072620,"node_id":"MDQ6VXNlcjEwMDcyNjIw","avatar_url":"https://avatars2.githubusercontent.com/u/10072620?v=4","gravatar_id":"","url":"https://api.github.com/users/wangcan0329","html_url":"https://github.com/wangcan0329","followers_url":"https://api.github.com/users/wangcan0329/followers","following_url":"https://api.github.com/users/wangcan0329/following{/other_user}","gists_url":"https://api.github.com/users/wangcan0329/gists{/gist_id}","starred_url":"https://api.github.com/users/wangcan0329/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wangcan0329/subscriptions","organizations_url":"https://api.github.com/users/wangcan0329/orgs","repos_url":"https://api.github.com/users/wangcan0329/repos","events_url":"https://api.github.com/users/wangcan0329/events{/privacy}","received_events_url":"https://api.github.com/users/wangcan0329/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/pai/pulls/1549/commits","review_comments_url":"https://api.github.com/repos/Microsoft/pai/pulls/1549/comments","review_comment_url":"https://api.github.com/repos/Microsoft/pai/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/pai/issues/1549/comments","statuses_url":"https://api.github.com/repos/Microsoft/pai/statuses/f26b6ca8dd852f3dff55c611d610a6eaef04a89d","head":{"label":"Microsoft:zimiao/ocr","ref":"zimiao/ocr","sha":"f26b6ca8dd852f3dff55c611d610a6eaef04a89d","user":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":104741169,"node_id":"MDEwOlJlcG9zaXRvcnkxMDQ3NDExNjk=","name":"pai","full_name":"Microsoft/pai","private":false,"owner":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Microsoft/pai","description":"Resource scheduling and cluster management for AI","fork":false,"url":"https://api.github.com/repos/Microsoft/pai","forks_url":"https://api.github.com/repos/Microsoft/pai/forks","keys_url":"https://api.github.com/repos/Microsoft/pai/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/pai/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/pai/teams","hooks_url":"https://api.github.com/repos/Microsoft/pai/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/pai/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/pai/events","assignees_url":"https://api.github.com/repos/Microsoft/pai/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/pai/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/pai/tags","blobs_url":"https://api.github.com/repos/Microsoft/pai/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/pai/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/pai/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/pai/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/pai/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/pai/languages","stargazers_url":"https://api.github.com/repos/Microsoft/pai/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/pai/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/pai/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/pai/subscription","commits_url":"https://api.github.com/repos/Microsoft/pai/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/pai/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/pai/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/pai/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/pai/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/pai/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/pai/merges","archive_url":"https://api.github.com/repos/Microsoft/pai/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/pai/downloads","issues_url":"https://api.github.com/repos/Microsoft/pai/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/pai/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/pai/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/pai/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/pai/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/pai/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/pai/deployments","created_at":"2017-09-25T11:24:51Z","updated_at":"2018-10-19T10:02:04Z","pushed_at":"2018-10-19T12:18:53Z","git_url":"git://github.com/Microsoft/pai.git","ssh_url":"[email protected]:Microsoft/pai.git","clone_url":"https://github.com/Microsoft/pai.git","svn_url":"https://github.com/Microsoft/pai","homepage":"","size":11221,"stargazers_count":524,"watchers_count":524,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":133,"mirror_url":null,"archived":false,"open_issues_count":99,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":133,"open_issues":99,"watchers":524,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"0b9f0083bdfe0433581cbf6cf213d07d85616b74","user":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":104741169,"node_id":"MDEwOlJlcG9zaXRvcnkxMDQ3NDExNjk=","name":"pai","full_name":"Microsoft/pai","private":false,"owner":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Microsoft/pai","description":"Resource scheduling and cluster management for AI","fork":false,"url":"https://api.github.com/repos/Microsoft/pai","forks_url":"https://api.github.com/repos/Microsoft/pai/forks","keys_url":"https://api.github.com/repos/Microsoft/pai/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/pai/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/pai/teams","hooks_url":"https://api.github.com/repos/Microsoft/pai/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/pai/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/pai/events","assignees_url":"https://api.github.com/repos/Microsoft/pai/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/pai/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/pai/tags","blobs_url":"https://api.github.com/repos/Microsoft/pai/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/pai/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/pai/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/pai/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/pai/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/pai/languages","stargazers_url":"https://api.github.com/repos/Microsoft/pai/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/pai/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/pai/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/pai/subscription","commits_url":"https://api.github.com/repos/Microsoft/pai/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/pai/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/pai/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/pai/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/pai/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/pai/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/pai/merges","archive_url":"https://api.github.com/repos/Microsoft/pai/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/pai/downloads","issues_url":"https://api.github.com/repos/Microsoft/pai/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/pai/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/pai/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/pai/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/pai/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/pai/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/pai/deployments","created_at":"2017-09-25T11:24:51Z","updated_at":"2018-10-19T10:02:04Z","pushed_at":"2018-10-19T12:18:53Z","git_url":"git://github.com/Microsoft/pai.git","ssh_url":"[email protected]:Microsoft/pai.git","clone_url":"https://github.com/Microsoft/pai.git","svn_url":"https://github.com/Microsoft/pai","homepage":"","size":11221,"stargazers_count":524,"watchers_count":524,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":133,"mirror_url":null,"archived":false,"open_issues_count":99,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":133,"open_issues":99,"watchers":524,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/pai/pulls/1549"},"html":{"href":"https://github.com/Microsoft/pai/pull/1549"},"issue":{"href":"https://api.github.com/repos/Microsoft/pai/issues/1549"},"comments":{"href":"https://api.github.com/repos/Microsoft/pai/issues/1549/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/pai/pulls/1549/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/pai/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/pai/pulls/1549/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/pai/statuses/f26b6ca8dd852f3dff55c611d610a6eaef04a89d"}},"author_association":"MEMBER"}} | {
"id": 104741169,
"name": "Microsoft/pai",
"url": "https://api.github.com/repos/Microsoft/pai"
} | {
"id": 11887940,
"login": "mzmssg",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/11887940?",
"url": "https://api.github.com/users/mzmssg"
} | {
"id": 6154722,
"login": "Microsoft",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6154722?",
"url": "https://api.github.com/orgs/Microsoft"
} | 2018-10-20T07:50:11 | 8452739010 | {"actor":{"display_login":"mzmssg"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/YamUI/pulls/comments/198587773","pull_request_review_id":132543944,"id":198587773,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5ODU4Nzc3Mw==","diff_hunk":"@@ -15,19 +17,38 @@ const getMarginTop = (topSpacing?: GutterSize, push?: number) => {\n }\n };\n \n+const iconSizeForTextSize = {\n+ [TextSize.XXLARGE]: '2.4rem',\n+ [TextSize.XLARGE]: '2.2rem',\n+ [TextSize.LARGE]: '1.5rem',\n+ [TextSize.MEDIUM]: '1.4rem',\n+ [TextSize.MEDIUM_SUB]: '1.4rem',\n+ [TextSize.SMALL]: '1.2rem',\n+ [TextSize.XSMALL]: '1.0rem',\n+};\n+\n export const getStyles = (props: BlockProps): IRawStyle => {\n const { push, textSize, topSpacing, bottomSpacing, textAlign, textColor } = props;\n+ const theme = getTheme();","path":"src/components/Block/Block.styles.ts","position":27,"original_position":27,"commit_id":"b6394c469759547d3150b9e8eb3f4424557c71c8","original_commit_id":"78c022d22bd26fe3a57e8d237f5c5e4abf0514a2","user":{"login":"unindented","id":69485,"node_id":"MDQ6VXNlcjY5NDg1","avatar_url":"https://avatars1.githubusercontent.com/u/69485?v=4","gravatar_id":"","url":"https://api.github.com/users/unindented","html_url":"https://github.com/unindented","followers_url":"https://api.github.com/users/unindented/followers","following_url":"https://api.github.com/users/unindented/following{/other_user}","gists_url":"https://api.github.com/users/unindented/gists{/gist_id}","starred_url":"https://api.github.com/users/unindented/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unindented/subscriptions","organizations_url":"https://api.github.com/users/unindented/orgs","repos_url":"https://api.github.com/users/unindented/repos","events_url":"https://api.github.com/users/unindented/events{/privacy}","received_events_url":"https://api.github.com/users/unindented/received_events","type":"User","site_admin":false},"body":"Should we try adding a `Customizer` in one of our consumer apps? I'm kind of excited to see this working.","created_at":"2018-06-27T17:58:41Z","updated_at":"2018-06-27T17:58:41Z","html_url":"https://github.com/Microsoft/YamUI/pull/403#discussion_r198587773","pull_request_url":"https://api.github.com/repos/Microsoft/YamUI/pulls/403","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/YamUI/pulls/comments/198587773"},"html":{"href":"https://github.com/Microsoft/YamUI/pull/403#discussion_r198587773"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/YamUI/pulls/403"}},"in_reply_to_id":198582733},"pull_request":{"url":"https://api.github.com/repos/Microsoft/YamUI/pulls/403","id":194644213,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0NjQ0MjEz","html_url":"https://github.com/Microsoft/YamUI/pull/403","diff_url":"https://github.com/Microsoft/YamUI/pull/403.diff","patch_url":"https://github.com/Microsoft/YamUI/pull/403.patch","issue_url":"https://api.github.com/repos/Microsoft/YamUI/issues/403","number":403,"state":"open","locked":false,"title":"js styles for Icon","user":{"login":"chrismohr","id":601657,"node_id":"MDQ6VXNlcjYwMTY1Nw==","avatar_url":"https://avatars3.githubusercontent.com/u/601657?v=4","gravatar_id":"","url":"https://api.github.com/users/chrismohr","html_url":"https://github.com/chrismohr","followers_url":"https://api.github.com/users/chrismohr/followers","following_url":"https://api.github.com/users/chrismohr/following{/other_user}","gists_url":"https://api.github.com/users/chrismohr/gists{/gist_id}","starred_url":"https://api.github.com/users/chrismohr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrismohr/subscriptions","organizations_url":"https://api.github.com/users/chrismohr/orgs","repos_url":"https://api.github.com/users/chrismohr/repos","events_url":"https://api.github.com/users/chrismohr/events{/privacy}","received_events_url":"https://api.github.com/users/chrismohr/received_events","type":"User","site_admin":false},"body":"Possibly too much for one PR:\r\n- convert styles from css\r\n- always get fontSizes and lineHeights from theme object","created_at":"2018-06-13T16:25:13Z","updated_at":"2018-06-27T17:58:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2cd259899b1329c5b77a10556a2bcc7e17b1ec17","assignee":null,"assignees":[],"requested_reviewers":[{"login":"unindented","id":69485,"node_id":"MDQ6VXNlcjY5NDg1","avatar_url":"https://avatars1.githubusercontent.com/u/69485?v=4","gravatar_id":"","url":"https://api.github.com/users/unindented","html_url":"https://github.com/unindented","followers_url":"https://api.github.com/users/unindented/followers","following_url":"https://api.github.com/users/unindented/following{/other_user}","gists_url":"https://api.github.com/users/unindented/gists{/gist_id}","starred_url":"https://api.github.com/users/unindented/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unindented/subscriptions","organizations_url":"https://api.github.com/users/unindented/orgs","repos_url":"https://api.github.com/users/unindented/repos","events_url":"https://api.github.com/users/unindented/events{/privacy}","received_events_url":"https://api.github.com/users/unindented/received_events","type":"User","site_admin":false},{"login":"richardtagger","id":692240,"node_id":"MDQ6VXNlcjY5MjI0MA==","avatar_url":"https://avatars1.githubusercontent.com/u/692240?v=4","gravatar_id":"","url":"https://api.github.com/users/richardtagger","html_url":"https://github.com/richardtagger","followers_url":"https://api.github.com/users/richardtagger/followers","following_url":"https://api.github.com/users/richardtagger/following{/other_user}","gists_url":"https://api.github.com/users/richardtagger/gists{/gist_id}","starred_url":"https://api.github.com/users/richardtagger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richardtagger/subscriptions","organizations_url":"https://api.github.com/users/richardtagger/orgs","repos_url":"https://api.github.com/users/richardtagger/repos","events_url":"https://api.github.com/users/richardtagger/events{/privacy}","received_events_url":"https://api.github.com/users/richardtagger/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/YamUI/pulls/403/commits","review_comments_url":"https://api.github.com/repos/Microsoft/YamUI/pulls/403/comments","review_comment_url":"https://api.github.com/repos/Microsoft/YamUI/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/YamUI/issues/403/comments","statuses_url":"https://api.github.com/repos/Microsoft/YamUI/statuses/b6394c469759547d3150b9e8eb3f4424557c71c8","head":{"label":"Microsoft:icon_styles","ref":"icon_styles","sha":"b6394c469759547d3150b9e8eb3f4424557c71c8","user":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":97036342,"node_id":"MDEwOlJlcG9zaXRvcnk5NzAzNjM0Mg==","name":"YamUI","full_name":"Microsoft/YamUI","owner":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/YamUI","description":"Reusable component framework for Yammer.com","fork":false,"url":"https://api.github.com/repos/Microsoft/YamUI","forks_url":"https://api.github.com/repos/Microsoft/YamUI/forks","keys_url":"https://api.github.com/repos/Microsoft/YamUI/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/YamUI/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/YamUI/teams","hooks_url":"https://api.github.com/repos/Microsoft/YamUI/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/YamUI/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/YamUI/events","assignees_url":"https://api.github.com/repos/Microsoft/YamUI/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/YamUI/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/YamUI/tags","blobs_url":"https://api.github.com/repos/Microsoft/YamUI/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/YamUI/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/YamUI/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/YamUI/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/YamUI/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/YamUI/languages","stargazers_url":"https://api.github.com/repos/Microsoft/YamUI/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/YamUI/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/YamUI/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/YamUI/subscription","commits_url":"https://api.github.com/repos/Microsoft/YamUI/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/YamUI/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/YamUI/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/YamUI/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/YamUI/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/YamUI/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/YamUI/merges","archive_url":"https://api.github.com/repos/Microsoft/YamUI/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/YamUI/downloads","issues_url":"https://api.github.com/repos/Microsoft/YamUI/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/YamUI/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/YamUI/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/YamUI/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/YamUI/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/YamUI/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/YamUI/deployments","created_at":"2017-07-12T17:43:12Z","updated_at":"2018-06-26T23:27:29Z","pushed_at":"2018-06-27T17:56:28Z","git_url":"git://github.com/Microsoft/YamUI.git","ssh_url":"[email protected]:Microsoft/YamUI.git","clone_url":"https://github.com/Microsoft/YamUI.git","svn_url":"https://github.com/Microsoft/YamUI","homepage":"https://microsoft.github.io/YamUI/","size":60779,"stargazers_count":376,"watchers_count":376,"language":"TypeScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":32,"mirror_url":null,"archived":false,"open_issues_count":52,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":32,"open_issues":52,"watchers":376,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"4a0e3be691f58e4e71b3a1e309ae2f9e50273c32","user":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":97036342,"node_id":"MDEwOlJlcG9zaXRvcnk5NzAzNjM0Mg==","name":"YamUI","full_name":"Microsoft/YamUI","owner":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/YamUI","description":"Reusable component framework for Yammer.com","fork":false,"url":"https://api.github.com/repos/Microsoft/YamUI","forks_url":"https://api.github.com/repos/Microsoft/YamUI/forks","keys_url":"https://api.github.com/repos/Microsoft/YamUI/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/YamUI/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/YamUI/teams","hooks_url":"https://api.github.com/repos/Microsoft/YamUI/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/YamUI/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/YamUI/events","assignees_url":"https://api.github.com/repos/Microsoft/YamUI/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/YamUI/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/YamUI/tags","blobs_url":"https://api.github.com/repos/Microsoft/YamUI/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/YamUI/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/YamUI/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/YamUI/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/YamUI/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/YamUI/languages","stargazers_url":"https://api.github.com/repos/Microsoft/YamUI/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/YamUI/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/YamUI/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/YamUI/subscription","commits_url":"https://api.github.com/repos/Microsoft/YamUI/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/YamUI/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/YamUI/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/YamUI/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/YamUI/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/YamUI/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/YamUI/merges","archive_url":"https://api.github.com/repos/Microsoft/YamUI/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/YamUI/downloads","issues_url":"https://api.github.com/repos/Microsoft/YamUI/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/YamUI/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/YamUI/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/YamUI/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/YamUI/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/YamUI/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/YamUI/deployments","created_at":"2017-07-12T17:43:12Z","updated_at":"2018-06-26T23:27:29Z","pushed_at":"2018-06-27T17:56:28Z","git_url":"git://github.com/Microsoft/YamUI.git","ssh_url":"[email protected]:Microsoft/YamUI.git","clone_url":"https://github.com/Microsoft/YamUI.git","svn_url":"https://github.com/Microsoft/YamUI","homepage":"https://microsoft.github.io/YamUI/","size":60779,"stargazers_count":376,"watchers_count":376,"language":"TypeScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":32,"mirror_url":null,"archived":false,"open_issues_count":52,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":32,"open_issues":52,"watchers":376,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/YamUI/pulls/403"},"html":{"href":"https://github.com/Microsoft/YamUI/pull/403"},"issue":{"href":"https://api.github.com/repos/Microsoft/YamUI/issues/403"},"comments":{"href":"https://api.github.com/repos/Microsoft/YamUI/issues/403/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/YamUI/pulls/403/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/YamUI/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/YamUI/pulls/403/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/YamUI/statuses/b6394c469759547d3150b9e8eb3f4424557c71c8"}},"author_association":"MEMBER"}} | {
"id": 97036342,
"name": "Microsoft/YamUI",
"url": "https://api.github.com/repos/Microsoft/YamUI"
} | {
"id": 69485,
"login": "unindented",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/69485?",
"url": "https://api.github.com/users/unindented"
} | {
"id": 6154722,
"login": "Microsoft",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6154722?",
"url": "https://api.github.com/orgs/Microsoft"
} | 2018-06-27T17:58:41 | 7887289662 | {"actor":{"display_login":"unindented"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/powerbi-powershell/pulls/comments/193230461","pull_request_review_id":126154951,"id":193230461,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5MzIzMDQ2MQ==","diff_hunk":"@@ -0,0 +1,108 @@\n+using System;\n+using System.Collections.Generic;\n+using System.Management.Automation;\n+using System.Net.Http;\n+using System.Runtime.Serialization.Json;\n+using System.Text;\n+using System.Threading.Tasks;\n+using Microsoft.PowerBI.Commands.Common;\n+using Microsoft.PowerBI.Common.Abstractions.Interfaces;\n+\n+namespace Microsoft.PowerBI.Commands.Profile\n+{\n+ [Cmdlet(CmdletVerb, CmdletName)]\n+ [OutputType(typeof(string))]\n+ public class InvokePowerBIRestMethod : PowerBICmdlet","path":"src/Modules/Profile/Commands.Profile/InvokePowerBIRestMethod.cs","position":15,"original_position":15,"commit_id":"cabe1cd89f9d3844f1ffe311748fd7f84c027508","original_commit_id":"cabe1cd89f9d3844f1ffe311748fd7f84c027508","user":{"login":"nandemoii","id":27929183,"node_id":"MDQ6VXNlcjI3OTI5MTgz","avatar_url":"https://avatars2.githubusercontent.com/u/27929183?v=4","gravatar_id":"","url":"https://api.github.com/users/nandemoii","html_url":"https://github.com/nandemoii","followers_url":"https://api.github.com/users/nandemoii/followers","following_url":"https://api.github.com/users/nandemoii/following{/other_user}","gists_url":"https://api.github.com/users/nandemoii/gists{/gist_id}","starred_url":"https://api.github.com/users/nandemoii/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nandemoii/subscriptions","organizations_url":"https://api.github.com/users/nandemoii/orgs","repos_url":"https://api.github.com/users/nandemoii/repos","events_url":"https://api.github.com/users/nandemoii/events{/privacy}","received_events_url":"https://api.github.com/users/nandemoii/received_events","type":"User","site_admin":false},"body":"Are we able to relatively easily add E2E tests for this cmdlet?","created_at":"2018-06-05T21:37:02Z","updated_at":"2018-06-05T21:37:15Z","html_url":"https://github.com/Microsoft/powerbi-powershell/pull/29#discussion_r193230461","pull_request_url":"https://api.github.com/repos/Microsoft/powerbi-powershell/pulls/29","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/powerbi-powershell/pulls/comments/193230461"},"html":{"href":"https://github.com/Microsoft/powerbi-powershell/pull/29#discussion_r193230461"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/powerbi-powershell/pulls/29"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/powerbi-powershell/pulls/29","id":192828983,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkyODI4OTgz","html_url":"https://github.com/Microsoft/powerbi-powershell/pull/29","diff_url":"https://github.com/Microsoft/powerbi-powershell/pull/29.diff","patch_url":"https://github.com/Microsoft/powerbi-powershell/pull/29.patch","issue_url":"https://api.github.com/repos/Microsoft/powerbi-powershell/issues/29","number":29,"state":"open","locked":false,"title":"Cyclone/invoke rest cmdlet","user":{"login":"CodeCyclone","id":9702314,"node_id":"MDQ6VXNlcjk3MDIzMTQ=","avatar_url":"https://avatars2.githubusercontent.com/u/9702314?v=4","gravatar_id":"","url":"https://api.github.com/users/CodeCyclone","html_url":"https://github.com/CodeCyclone","followers_url":"https://api.github.com/users/CodeCyclone/followers","following_url":"https://api.github.com/users/CodeCyclone/following{/other_user}","gists_url":"https://api.github.com/users/CodeCyclone/gists{/gist_id}","starred_url":"https://api.github.com/users/CodeCyclone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CodeCyclone/subscriptions","organizations_url":"https://api.github.com/users/CodeCyclone/orgs","repos_url":"https://api.github.com/users/CodeCyclone/repos","events_url":"https://api.github.com/users/CodeCyclone/events{/privacy}","received_events_url":"https://api.github.com/users/CodeCyclone/received_events","type":"User","site_admin":false},"body":"* Added cmdlet Invoke-PowerBIRestMethod\r\n* Added cmdlet Get-PowerBIAccessToken\r\n* Added links for help documentation\r\n* Added aliases Login-PowerBI and Logout-PowerBI\r\n","created_at":"2018-06-05T20:37:11Z","updated_at":"2018-06-05T21:37:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"248dac05e7eee8bdd43245518177bcae65bc5edc","assignee":null,"assignees":[],"requested_reviewers":[{"login":"gabehall","id":9691044,"node_id":"MDQ6VXNlcjk2OTEwNDQ=","avatar_url":"https://avatars2.githubusercontent.com/u/9691044?v=4","gravatar_id":"","url":"https://api.github.com/users/gabehall","html_url":"https://github.com/gabehall","followers_url":"https://api.github.com/users/gabehall/followers","following_url":"https://api.github.com/users/gabehall/following{/other_user}","gists_url":"https://api.github.com/users/gabehall/gists{/gist_id}","starred_url":"https://api.github.com/users/gabehall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gabehall/subscriptions","organizations_url":"https://api.github.com/users/gabehall/orgs","repos_url":"https://api.github.com/users/gabehall/repos","events_url":"https://api.github.com/users/gabehall/events{/privacy}","received_events_url":"https://api.github.com/users/gabehall/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":849331762,"node_id":"MDU6TGFiZWw4NDkzMzE3NjI=","url":"https://api.github.com/repos/Microsoft/powerbi-powershell/labels/enhancement","name":"enhancement","color":"a2eeef","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/powerbi-powershell/pulls/29/commits","review_comments_url":"https://api.github.com/repos/Microsoft/powerbi-powershell/pulls/29/comments","review_comment_url":"https://api.github.com/repos/Microsoft/powerbi-powershell/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/powerbi-powershell/issues/29/comments","statuses_url":"https://api.github.com/repos/Microsoft/powerbi-powershell/statuses/cabe1cd89f9d3844f1ffe311748fd7f84c027508","head":{"label":"Microsoft:cyclone/InvokeRestCmdlet","ref":"cyclone/InvokeRestCmdlet","sha":"cabe1cd89f9d3844f1ffe311748fd7f84c027508","user":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":123018180,"node_id":"MDEwOlJlcG9zaXRvcnkxMjMwMTgxODA=","name":"powerbi-powershell","full_name":"Microsoft/powerbi-powershell","owner":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/powerbi-powershell","description":"PowerShell community for Microsoft PowerBI. Here you will find resources and source for PowerShell modules targeting PowerBI.","fork":false,"url":"https://api.github.com/repos/Microsoft/powerbi-powershell","forks_url":"https://api.github.com/repos/Microsoft/powerbi-powershell/forks","keys_url":"https://api.github.com/repos/Microsoft/powerbi-powershell/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/powerbi-powershell/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/powerbi-powershell/teams","hooks_url":"https://api.github.com/repos/Microsoft/powerbi-powershell/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/powerbi-powershell/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/powerbi-powershell/events","assignees_url":"https://api.github.com/repos/Microsoft/powerbi-powershell/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/powerbi-powershell/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/powerbi-powershell/tags","blobs_url":"https://api.github.com/repos/Microsoft/powerbi-powershell/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/powerbi-powershell/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/powerbi-powershell/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/powerbi-powershell/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/powerbi-powershell/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/powerbi-powershell/languages","stargazers_url":"https://api.github.com/repos/Microsoft/powerbi-powershell/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/powerbi-powershell/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/powerbi-powershell/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/powerbi-powershell/subscription","commits_url":"https://api.github.com/repos/Microsoft/powerbi-powershell/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/powerbi-powershell/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/powerbi-powershell/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/powerbi-powershell/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/powerbi-powershell/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/powerbi-powershell/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/powerbi-powershell/merges","archive_url":"https://api.github.com/repos/Microsoft/powerbi-powershell/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/powerbi-powershell/downloads","issues_url":"https://api.github.com/repos/Microsoft/powerbi-powershell/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/powerbi-powershell/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/powerbi-powershell/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/powerbi-powershell/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/powerbi-powershell/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/powerbi-powershell/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/powerbi-powershell/deployments","created_at":"2018-02-26T19:16:45Z","updated_at":"2018-05-31T23:25:10Z","pushed_at":"2018-06-05T20:37:11Z","git_url":"git://github.com/Microsoft/powerbi-powershell.git","ssh_url":"[email protected]:Microsoft/powerbi-powershell.git","clone_url":"https://github.com/Microsoft/powerbi-powershell.git","svn_url":"https://github.com/Microsoft/powerbi-powershell","homepage":null,"size":259,"stargazers_count":8,"watchers_count":8,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":1,"watchers":8,"default_branch":"master"}},"base":{"label":"Microsoft:dev","ref":"dev","sha":"aa58204c8599de184826257f5b171ec2c5913028","user":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":123018180,"node_id":"MDEwOlJlcG9zaXRvcnkxMjMwMTgxODA=","name":"powerbi-powershell","full_name":"Microsoft/powerbi-powershell","owner":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/powerbi-powershell","description":"PowerShell community for Microsoft PowerBI. Here you will find resources and source for PowerShell modules targeting PowerBI.","fork":false,"url":"https://api.github.com/repos/Microsoft/powerbi-powershell","forks_url":"https://api.github.com/repos/Microsoft/powerbi-powershell/forks","keys_url":"https://api.github.com/repos/Microsoft/powerbi-powershell/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/powerbi-powershell/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/powerbi-powershell/teams","hooks_url":"https://api.github.com/repos/Microsoft/powerbi-powershell/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/powerbi-powershell/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/powerbi-powershell/events","assignees_url":"https://api.github.com/repos/Microsoft/powerbi-powershell/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/powerbi-powershell/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/powerbi-powershell/tags","blobs_url":"https://api.github.com/repos/Microsoft/powerbi-powershell/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/powerbi-powershell/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/powerbi-powershell/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/powerbi-powershell/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/powerbi-powershell/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/powerbi-powershell/languages","stargazers_url":"https://api.github.com/repos/Microsoft/powerbi-powershell/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/powerbi-powershell/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/powerbi-powershell/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/powerbi-powershell/subscription","commits_url":"https://api.github.com/repos/Microsoft/powerbi-powershell/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/powerbi-powershell/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/powerbi-powershell/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/powerbi-powershell/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/powerbi-powershell/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/powerbi-powershell/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/powerbi-powershell/merges","archive_url":"https://api.github.com/repos/Microsoft/powerbi-powershell/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/powerbi-powershell/downloads","issues_url":"https://api.github.com/repos/Microsoft/powerbi-powershell/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/powerbi-powershell/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/powerbi-powershell/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/powerbi-powershell/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/powerbi-powershell/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/powerbi-powershell/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/powerbi-powershell/deployments","created_at":"2018-02-26T19:16:45Z","updated_at":"2018-05-31T23:25:10Z","pushed_at":"2018-06-05T20:37:11Z","git_url":"git://github.com/Microsoft/powerbi-powershell.git","ssh_url":"[email protected]:Microsoft/powerbi-powershell.git","clone_url":"https://github.com/Microsoft/powerbi-powershell.git","svn_url":"https://github.com/Microsoft/powerbi-powershell","homepage":null,"size":259,"stargazers_count":8,"watchers_count":8,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":1,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/powerbi-powershell/pulls/29"},"html":{"href":"https://github.com/Microsoft/powerbi-powershell/pull/29"},"issue":{"href":"https://api.github.com/repos/Microsoft/powerbi-powershell/issues/29"},"comments":{"href":"https://api.github.com/repos/Microsoft/powerbi-powershell/issues/29/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/powerbi-powershell/pulls/29/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/powerbi-powershell/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/powerbi-powershell/pulls/29/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/powerbi-powershell/statuses/cabe1cd89f9d3844f1ffe311748fd7f84c027508"}},"author_association":"CONTRIBUTOR"}} | {
"id": 123018180,
"name": "Microsoft/powerbi-powershell",
"url": "https://api.github.com/repos/Microsoft/powerbi-powershell"
} | {
"id": 27929183,
"login": "nandemoii",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/27929183?",
"url": "https://api.github.com/users/nandemoii"
} | {
"id": 6154722,
"login": "Microsoft",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6154722?",
"url": "https://api.github.com/orgs/Microsoft"
} | 2018-06-05T21:37:02 | 7780904697 | {"actor":{"display_login":"nandemoii"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/pulls/comments/216051535","pull_request_review_id":153457909,"id":216051535,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNjA1MTUzNQ==","diff_hunk":"@@ -122,3 +132,7 @@ interface IProcessTreeNode {\n interface IWindowsProcessTree {\n getProcessTree(rootPid: number, callback: (tree: IProcessTreeNode | undefined) => void): void;\n }\n+\n+async function delay(ms: number): Promise<void> {","path":"src/commands/pickFuncProcess.ts","position":97,"original_position":97,"commit_id":"89bddfe0c3e14b8055600f1e56340eca0f48e512","original_commit_id":"ad71c35c2c52d7f3e7037bc309172f19bbe83a62","user":{"login":"nturinski","id":5290572,"node_id":"MDQ6VXNlcjUyOTA1NzI=","avatar_url":"https://avatars0.githubusercontent.com/u/5290572?v=4","gravatar_id":"","url":"https://api.github.com/users/nturinski","html_url":"https://github.com/nturinski","followers_url":"https://api.github.com/users/nturinski/followers","following_url":"https://api.github.com/users/nturinski/following{/other_user}","gists_url":"https://api.github.com/users/nturinski/gists{/gist_id}","starred_url":"https://api.github.com/users/nturinski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nturinski/subscriptions","organizations_url":"https://api.github.com/users/nturinski/orgs","repos_url":"https://api.github.com/users/nturinski/repos","events_url":"https://api.github.com/users/nturinski/events{/privacy}","received_events_url":"https://api.github.com/users/nturinski/received_events","type":"User","site_admin":false},"body":"Always could wait until someone accidentally duplicates it and move it then. I agree it's less discoverable, but I'm sure one of us will remember come PR time... 😅 ","created_at":"2018-09-07T18:36:34Z","updated_at":"2018-09-07T18:36:34Z","html_url":"https://github.com/Microsoft/vscode-azurefunctions/pull/573#discussion_r216051535","pull_request_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/pulls/573","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/pulls/comments/216051535"},"html":{"href":"https://github.com/Microsoft/vscode-azurefunctions/pull/573#discussion_r216051535"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/pulls/573"}},"in_reply_to_id":216048683},"pull_request":{"url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/pulls/573","id":213999115,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEzOTk5MTE1","html_url":"https://github.com/Microsoft/vscode-azurefunctions/pull/573","diff_url":"https://github.com/Microsoft/vscode-azurefunctions/pull/573.diff","patch_url":"https://github.com/Microsoft/vscode-azurefunctions/pull/573.patch","issue_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/issues/573","number":573,"state":"open","locked":false,"title":"Make pickFuncProcess more robust to timing issues","user":{"login":"EricJizbaMSFT","id":11282622,"node_id":"MDQ6VXNlcjExMjgyNjIy","avatar_url":"https://avatars2.githubusercontent.com/u/11282622?v=4","gravatar_id":"","url":"https://api.github.com/users/EricJizbaMSFT","html_url":"https://github.com/EricJizbaMSFT","followers_url":"https://api.github.com/users/EricJizbaMSFT/followers","following_url":"https://api.github.com/users/EricJizbaMSFT/following{/other_user}","gists_url":"https://api.github.com/users/EricJizbaMSFT/gists{/gist_id}","starred_url":"https://api.github.com/users/EricJizbaMSFT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EricJizbaMSFT/subscriptions","organizations_url":"https://api.github.com/users/EricJizbaMSFT/orgs","repos_url":"https://api.github.com/users/EricJizbaMSFT/repos","events_url":"https://api.github.com/users/EricJizbaMSFT/events{/privacy}","received_events_url":"https://api.github.com/users/EricJizbaMSFT/received_events","type":"User","site_admin":false},"body":"As described in this PR: https://github.com/Microsoft/vscode-azurefunctions/pull/558, we have to get the inner 'func' process on Windows instead of attaching to the parent PowerShell process. Well it turns out there's a delay between when the PowerShell process is created and when it has the child process running the func cli. This change prevents us from attaching to the PowerShell process and getting \"unverified\" breakpoints.","created_at":"2018-09-07T17:58:14Z","updated_at":"2018-09-07T18:36:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"674fc384c86e670c5ab165fc71b09c32e6187361","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/pulls/573/commits","review_comments_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/pulls/573/comments","review_comment_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/issues/573/comments","statuses_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/statuses/89bddfe0c3e14b8055600f1e56340eca0f48e512","head":{"label":"Microsoft:ej/proc","ref":"ej/proc","sha":"89bddfe0c3e14b8055600f1e56340eca0f48e512","user":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":104400765,"node_id":"MDEwOlJlcG9zaXRvcnkxMDQ0MDA3NjU=","name":"vscode-azurefunctions","full_name":"Microsoft/vscode-azurefunctions","owner":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/vscode-azurefunctions","description":"Azure Functions extension for VS Code","fork":false,"url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions","forks_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/forks","keys_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/teams","hooks_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/events","assignees_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/tags","blobs_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/languages","stargazers_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/subscription","commits_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/merges","archive_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/downloads","issues_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/deployments","created_at":"2017-09-21T21:28:44Z","updated_at":"2018-09-07T15:51:05Z","pushed_at":"2018-09-07T18:26:00Z","git_url":"git://github.com/Microsoft/vscode-azurefunctions.git","ssh_url":"[email protected]:Microsoft/vscode-azurefunctions.git","clone_url":"https://github.com/Microsoft/vscode-azurefunctions.git","svn_url":"https://github.com/Microsoft/vscode-azurefunctions","homepage":"https://marketplace.visualstudio.com/items?itemName=ms-azuretools.vscode-azurefunctions","size":17352,"stargazers_count":65,"watchers_count":65,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"archived":false,"open_issues_count":71,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":16,"open_issues":71,"watchers":65,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"aa5a99b4cb20a61351da2a283b0db8d24d7fb6a0","user":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":104400765,"node_id":"MDEwOlJlcG9zaXRvcnkxMDQ0MDA3NjU=","name":"vscode-azurefunctions","full_name":"Microsoft/vscode-azurefunctions","owner":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/vscode-azurefunctions","description":"Azure Functions extension for VS Code","fork":false,"url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions","forks_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/forks","keys_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/teams","hooks_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/events","assignees_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/tags","blobs_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/languages","stargazers_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/subscription","commits_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/merges","archive_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/downloads","issues_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/deployments","created_at":"2017-09-21T21:28:44Z","updated_at":"2018-09-07T15:51:05Z","pushed_at":"2018-09-07T18:26:00Z","git_url":"git://github.com/Microsoft/vscode-azurefunctions.git","ssh_url":"[email protected]:Microsoft/vscode-azurefunctions.git","clone_url":"https://github.com/Microsoft/vscode-azurefunctions.git","svn_url":"https://github.com/Microsoft/vscode-azurefunctions","homepage":"https://marketplace.visualstudio.com/items?itemName=ms-azuretools.vscode-azurefunctions","size":17352,"stargazers_count":65,"watchers_count":65,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"archived":false,"open_issues_count":71,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":16,"open_issues":71,"watchers":65,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/pulls/573"},"html":{"href":"https://github.com/Microsoft/vscode-azurefunctions/pull/573"},"issue":{"href":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/issues/573"},"comments":{"href":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/issues/573/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/pulls/573/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/pulls/573/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/statuses/89bddfe0c3e14b8055600f1e56340eca0f48e512"}},"author_association":"MEMBER"}} | {
"id": 104400765,
"name": "Microsoft/vscode-azurefunctions",
"url": "https://api.github.com/repos/Microsoft/vscode-azurefunctions"
} | {
"id": 5290572,
"login": "nturinski",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5290572?",
"url": "https://api.github.com/users/nturinski"
} | {
"id": 6154722,
"login": "Microsoft",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6154722?",
"url": "https://api.github.com/orgs/Microsoft"
} | 2018-09-07T18:36:34 | 8232196931 | {"actor":{"display_login":"nturinski"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/PTVS/pulls/comments/165260836","pull_request_review_id":93168326,"id":165260836,"diff_hunk":"@@ -26,124 +27,89 @@ namespace Microsoft.PythonTools.Intellisense {\n /// and doing so in a single edit.\n /// </summary>\n class LinePreservingCodeReplacer {\n- private readonly string _newLine, _oldCode, _newCode;\n- private readonly IReadOnlyList<LineInfo> _newLines, _oldLines;\n-\n+ private readonly string _newLine;\n+ private readonly Line[] _newLines, _oldLines;\n+ \n private LinePreservingCodeReplacer(int startLine, string oldCode, string newCode, string newLine) {\n _newLine = newLine;\n- _oldCode = oldCode;\n- _newCode = newCode;\n- _oldLines = LineInfo.SplitLines(oldCode, startLine - 1).ToArray();\n- _newLines = LineInfo.SplitLines(newCode, startLine - 1).ToArray();\n- }\n-\n- private string GetOldText(int line) {\n- return _oldCode.Substring(_oldLines[line].Start, _oldLines[line].Length);\n- }\n-\n- private string GetNewText(int line) {\n- return _newCode.Substring(_newLines[line].Start, _newLines[line].Length);\n+ _oldLines = GetLines(oldCode, startLine);\n+ _newLines = GetLines(newCode, startLine);\n }\n \n public static IReadOnlyList<DocumentChange> Replace(int startLine, string oldCode, string newCode, string newLine = \"\\r\\n\") {\n return new LinePreservingCodeReplacer(startLine, oldCode, newCode, newLine).ReplaceCode();\n }\n \n+ private static Line[] GetLines(string source, int startLine) \n+ => LineInfo.SplitLines(source, startLine - 1).Select(l => new Line(l, source)).ToArray();\n+\n+ private static bool LcsEqualityComparer(Line column, Line row) \n+ => column.Info.Length == row.Info.Length && \n+ string.CompareOrdinal(column.Source, column.Info.Start, row.Source, row.Info.Start, column.Info.Length) == 0;\n+\n+\n public IReadOnlyList<DocumentChange> ReplaceCode() {\n+ var lcs = LongestCommonSequence<Line>.Find(_oldLines, _newLines, LcsEqualityComparer);\n var edits = new List<DocumentChange>();\n- var oldLineMapping = new Dictionary<string, List<int>>(); // line to line #\n- for (int i = 0; i < _oldLines.Count; i++) {\n- List<int> lineInfo;\n- if (!oldLineMapping.TryGetValue(GetOldText(i), out lineInfo)) {\n- oldLineMapping[GetOldText(i)] = lineInfo = new List<int>();\n- }\n- lineInfo.Add(i);\n- }\n \n- int curOldLine = 0;\n- for (int curNewLine = 0; curOldLine < _oldLines.Count && curNewLine < _newLines.Count; curOldLine++) {\n- if (GetOldText(curOldLine) == GetNewText(curNewLine)) {\n- curNewLine++;\n- continue;\n- }\n-\n- bool replaced = false;\n- // replace starts on this line, figure out where it ends...\n- int startNewLine = curNewLine;\n- for (curNewLine += 1; curNewLine < _newLines.Count; curNewLine++) {\n- List<int> lines;\n- if (oldLineMapping.TryGetValue(GetNewText(curNewLine), out lines)) {\n- foreach (var matchingLineNo in lines) {\n- if (matchingLineNo > curOldLine) {\n- // Replace the lines from curOldLine to matchingLineNo-1 with the text\n- // from startNewLine - curNewLine - 1.\n- ReplaceLines(edits, curOldLine, matchingLineNo, startNewLine, curNewLine);\n- replaced = true;\n- curOldLine = matchingLineNo - 1;\n- break;\n- }\n- }\n+ foreach (var diff in lcs) {\n+ if (diff.NewLength == 0) {\n+ edits.Add(Delete(diff.OldStart, diff.OldEnd));\n+ } else if (diff.OldLength == 0) {\n+ edits.Add(Insert(diff.OldStart, diff.NewStart, diff.NewEnd));\n+ } else {\n+ var length = Math.Min(diff.NewLength, diff.OldLength);\n+ for (var i = 0; i < length; i++) {\n+ edits.Add(Replace(diff.OldStart + i, diff.NewStart + i));\n }\n \n- if (replaced) {\n- break;\n+ if (diff.OldLength > length) {\n+ edits.Add(Delete(diff.OldStart + length, diff.OldEnd));\n+ } else if (diff.NewLength > length) {\n+ edits.Add(Insert(diff.OldStart + length, diff.NewStart + length, diff.NewEnd));\n }\n }\n-\n- if (!replaced) {\n- ReplaceLines(edits, curOldLine, _oldLines.Count, startNewLine, _newLines.Count);\n- curOldLine = _oldLines.Count;\n- break;\n- }\n }\n \n- if (curOldLine < _oldLines.Count) {\n- // remove the remaining new lines\n- edits.Add(\n- DocumentChange.Delete(new SourceSpan(\n- _oldLines[curOldLine].SourceStart,\n- _oldLines[_oldLines.Count - 1].SourceEnd\n- ))\n- );\n- }\n- return edits.ToArray();\n+ return edits.AsReadOnly();\n }\n \n- private void ReplaceLines(List<DocumentChange> edits, int startOldLine, int endOldLine, int startNewLine, int endNewLine) {\n- int oldLineCount = endOldLine - startOldLine;\n- int newLineCount = endNewLine - startNewLine;\n-\n- // replace one line at a time instead of all of the lines at once so that we preserve breakpoints\n- int excessNewLineStart = startNewLine - startOldLine;\n- for (int i = startOldLine; i < endOldLine && i < (endNewLine - startNewLine + startOldLine); i++) {\n- edits.Add(\n- DocumentChange.Replace(\n- _oldLines[i].SourceExtent,\n- GetNewText(startNewLine + i - startOldLine)\n- )\n- );\n- excessNewLineStart = startNewLine + i - startOldLine + 1;\n- }\n+ private DocumentChange Replace(int oldLineIndex, int newLineIndex) {\n+ var oldLineInfo = _oldLines[oldLineIndex].Info;\n+ var newLineInfo = _newLines[newLineIndex].Info;\n+ var newSource = _newLines[newLineIndex].Source;\n+ var text = newSource.Substring(newLineInfo.Start, newLineInfo.Length);\n+ return DocumentChange.Replace(oldLineInfo.SourceStart, oldLineInfo.SourceEnd, text);\n+ }\n+\n+ private DocumentChange Insert(int oldStart, int newStart, int newEnd) {\n+ var startIndex = _newLines[newStart].Info.Start;\n+ var length = _newLines[newEnd].Info.EndIncludingLineBreak - startIndex;\n+ var newSource = _newLines[newStart].Source;\n+ var insertText = new StringBuilder(newSource, startIndex, length, length)\n+ .Replace(NewLineKind.LineFeed.GetString(), _newLine)\n+ .Replace(NewLineKind.CarriageReturn.GetString(), _newLine)\n+ .Replace(NewLineKind.CarriageReturnLineFeed.GetString(), _newLine)","path":"Python/Product/Analysis/Intellisense/LinePreservingCodeReplacer.cs","position":157,"original_position":157,"commit_id":"d9e013db47a8f114553fbb50b500bf26b122a6e4","original_commit_id":"d9e013db47a8f114553fbb50b500bf26b122a6e4","user":{"login":"AlexanderSher","id":8933858,"avatar_url":"https://avatars3.githubusercontent.com/u/8933858?v=4","gravatar_id":"","url":"https://api.github.com/users/AlexanderSher","html_url":"https://github.com/AlexanderSher","followers_url":"https://api.github.com/users/AlexanderSher/followers","following_url":"https://api.github.com/users/AlexanderSher/following{/other_user}","gists_url":"https://api.github.com/users/AlexanderSher/gists{/gist_id}","starred_url":"https://api.github.com/users/AlexanderSher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlexanderSher/subscriptions","organizations_url":"https://api.github.com/users/AlexanderSher/orgs","repos_url":"https://api.github.com/users/AlexanderSher/repos","events_url":"https://api.github.com/users/AlexanderSher/events{/privacy}","received_events_url":"https://api.github.com/users/AlexanderSher/received_events","type":"User","site_admin":false},"body":"Nice catch","created_at":"2018-02-01T05:06:44Z","updated_at":"2018-02-01T05:06:44Z","html_url":"https://github.com/Microsoft/PTVS/pull/3678#discussion_r165260836","pull_request_url":"https://api.github.com/repos/Microsoft/PTVS/pulls/3678","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/PTVS/pulls/comments/165260836"},"html":{"href":"https://github.com/Microsoft/PTVS/pull/3678#discussion_r165260836"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/PTVS/pulls/3678"}},"in_reply_to_id":165259886},"pull_request":{"url":"https://api.github.com/repos/Microsoft/PTVS/pulls/3678","id":166377824,"html_url":"https://github.com/Microsoft/PTVS/pull/3678","diff_url":"https://github.com/Microsoft/PTVS/pull/3678.diff","patch_url":"https://github.com/Microsoft/PTVS/pull/3678.patch","issue_url":"https://api.github.com/repos/Microsoft/PTVS/issues/3678","number":3678,"state":"open","locked":false,"title":"Fix #3566: Improve LinePreservingCodeReplacer.ReplaceCode","user":{"login":"AlexanderSher","id":8933858,"avatar_url":"https://avatars3.githubusercontent.com/u/8933858?v=4","gravatar_id":"","url":"https://api.github.com/users/AlexanderSher","html_url":"https://github.com/AlexanderSher","followers_url":"https://api.github.com/users/AlexanderSher/followers","following_url":"https://api.github.com/users/AlexanderSher/following{/other_user}","gists_url":"https://api.github.com/users/AlexanderSher/gists{/gist_id}","starred_url":"https://api.github.com/users/AlexanderSher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlexanderSher/subscriptions","organizations_url":"https://api.github.com/users/AlexanderSher/orgs","repos_url":"https://api.github.com/users/AlexanderSher/repos","events_url":"https://api.github.com/users/AlexanderSher/events{/privacy}","received_events_url":"https://api.github.com/users/AlexanderSher/received_events","type":"User","site_admin":false},"body":"This also fixes https://github.com/Microsoft/PTVS/issues/3662 (at least it correctly works with repro sample), but I'm not sure if we should merge this into 15.6 or into master.","created_at":"2018-01-31T21:15:01Z","updated_at":"2018-02-01T05:06:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"02f8a5d571c589f896d4b6c8b4726bcc9bc94327","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/PTVS/pulls/3678/commits","review_comments_url":"https://api.github.com/repos/Microsoft/PTVS/pulls/3678/comments","review_comment_url":"https://api.github.com/repos/Microsoft/PTVS/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/PTVS/issues/3678/comments","statuses_url":"https://api.github.com/repos/Microsoft/PTVS/statuses/d9e013db47a8f114553fbb50b500bf26b122a6e4","head":{"label":"AlexanderSher:issue3566_15.6","ref":"issue3566_15.6","sha":"d9e013db47a8f114553fbb50b500bf26b122a6e4","user":{"login":"AlexanderSher","id":8933858,"avatar_url":"https://avatars3.githubusercontent.com/u/8933858?v=4","gravatar_id":"","url":"https://api.github.com/users/AlexanderSher","html_url":"https://github.com/AlexanderSher","followers_url":"https://api.github.com/users/AlexanderSher/followers","following_url":"https://api.github.com/users/AlexanderSher/following{/other_user}","gists_url":"https://api.github.com/users/AlexanderSher/gists{/gist_id}","starred_url":"https://api.github.com/users/AlexanderSher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlexanderSher/subscriptions","organizations_url":"https://api.github.com/users/AlexanderSher/orgs","repos_url":"https://api.github.com/users/AlexanderSher/repos","events_url":"https://api.github.com/users/AlexanderSher/events{/privacy}","received_events_url":"https://api.github.com/users/AlexanderSher/received_events","type":"User","site_admin":false},"repo":{"id":116306417,"name":"PTVS","full_name":"AlexanderSher/PTVS","owner":{"login":"AlexanderSher","id":8933858,"avatar_url":"https://avatars3.githubusercontent.com/u/8933858?v=4","gravatar_id":"","url":"https://api.github.com/users/AlexanderSher","html_url":"https://github.com/AlexanderSher","followers_url":"https://api.github.com/users/AlexanderSher/followers","following_url":"https://api.github.com/users/AlexanderSher/following{/other_user}","gists_url":"https://api.github.com/users/AlexanderSher/gists{/gist_id}","starred_url":"https://api.github.com/users/AlexanderSher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlexanderSher/subscriptions","organizations_url":"https://api.github.com/users/AlexanderSher/orgs","repos_url":"https://api.github.com/users/AlexanderSher/repos","events_url":"https://api.github.com/users/AlexanderSher/events{/privacy}","received_events_url":"https://api.github.com/users/AlexanderSher/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/AlexanderSher/PTVS","description":"Python Tools for Visual Studio","fork":true,"url":"https://api.github.com/repos/AlexanderSher/PTVS","forks_url":"https://api.github.com/repos/AlexanderSher/PTVS/forks","keys_url":"https://api.github.com/repos/AlexanderSher/PTVS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AlexanderSher/PTVS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AlexanderSher/PTVS/teams","hooks_url":"https://api.github.com/repos/AlexanderSher/PTVS/hooks","issue_events_url":"https://api.github.com/repos/AlexanderSher/PTVS/issues/events{/number}","events_url":"https://api.github.com/repos/AlexanderSher/PTVS/events","assignees_url":"https://api.github.com/repos/AlexanderSher/PTVS/assignees{/user}","branches_url":"https://api.github.com/repos/AlexanderSher/PTVS/branches{/branch}","tags_url":"https://api.github.com/repos/AlexanderSher/PTVS/tags","blobs_url":"https://api.github.com/repos/AlexanderSher/PTVS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AlexanderSher/PTVS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AlexanderSher/PTVS/git/refs{/sha}","trees_url":"https://api.github.com/repos/AlexanderSher/PTVS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AlexanderSher/PTVS/statuses/{sha}","languages_url":"https://api.github.com/repos/AlexanderSher/PTVS/languages","stargazers_url":"https://api.github.com/repos/AlexanderSher/PTVS/stargazers","contributors_url":"https://api.github.com/repos/AlexanderSher/PTVS/contributors","subscribers_url":"https://api.github.com/repos/AlexanderSher/PTVS/subscribers","subscription_url":"https://api.github.com/repos/AlexanderSher/PTVS/subscription","commits_url":"https://api.github.com/repos/AlexanderSher/PTVS/commits{/sha}","git_commits_url":"https://api.github.com/repos/AlexanderSher/PTVS/git/commits{/sha}","comments_url":"https://api.github.com/repos/AlexanderSher/PTVS/comments{/number}","issue_comment_url":"https://api.github.com/repos/AlexanderSher/PTVS/issues/comments{/number}","contents_url":"https://api.github.com/repos/AlexanderSher/PTVS/contents/{+path}","compare_url":"https://api.github.com/repos/AlexanderSher/PTVS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AlexanderSher/PTVS/merges","archive_url":"https://api.github.com/repos/AlexanderSher/PTVS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AlexanderSher/PTVS/downloads","issues_url":"https://api.github.com/repos/AlexanderSher/PTVS/issues{/number}","pulls_url":"https://api.github.com/repos/AlexanderSher/PTVS/pulls{/number}","milestones_url":"https://api.github.com/repos/AlexanderSher/PTVS/milestones{/number}","notifications_url":"https://api.github.com/repos/AlexanderSher/PTVS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AlexanderSher/PTVS/labels{/name}","releases_url":"https://api.github.com/repos/AlexanderSher/PTVS/releases{/id}","deployments_url":"https://api.github.com/repos/AlexanderSher/PTVS/deployments","created_at":"2018-01-04T20:52:08Z","updated_at":"2018-01-04T20:52:22Z","pushed_at":"2018-02-01T02:52:15Z","git_url":"git://github.com/AlexanderSher/PTVS.git","ssh_url":"[email protected]:AlexanderSher/PTVS.git","clone_url":"https://github.com/AlexanderSher/PTVS.git","svn_url":"https://github.com/AlexanderSher/PTVS","homepage":"https://aka.ms/PTVS","size":179709,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Microsoft:15.6rel","ref":"15.6rel","sha":"3f7c7e4bcd8fe83d238961d22cfe8790419e14e7","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":32487763,"name":"PTVS","full_name":"Microsoft/PTVS","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/PTVS","description":"Python Tools for Visual Studio","fork":false,"url":"https://api.github.com/repos/Microsoft/PTVS","forks_url":"https://api.github.com/repos/Microsoft/PTVS/forks","keys_url":"https://api.github.com/repos/Microsoft/PTVS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/PTVS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/PTVS/teams","hooks_url":"https://api.github.com/repos/Microsoft/PTVS/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/PTVS/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/PTVS/events","assignees_url":"https://api.github.com/repos/Microsoft/PTVS/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/PTVS/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/PTVS/tags","blobs_url":"https://api.github.com/repos/Microsoft/PTVS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/PTVS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/PTVS/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/PTVS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/PTVS/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/PTVS/languages","stargazers_url":"https://api.github.com/repos/Microsoft/PTVS/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/PTVS/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/PTVS/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/PTVS/subscription","commits_url":"https://api.github.com/repos/Microsoft/PTVS/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/PTVS/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/PTVS/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/PTVS/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/PTVS/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/PTVS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/PTVS/merges","archive_url":"https://api.github.com/repos/Microsoft/PTVS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/PTVS/downloads","issues_url":"https://api.github.com/repos/Microsoft/PTVS/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/PTVS/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/PTVS/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/PTVS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/PTVS/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/PTVS/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/PTVS/deployments","created_at":"2015-03-18T22:30:53Z","updated_at":"2018-01-31T16:17:17Z","pushed_at":"2018-02-01T05:04:19Z","git_url":"git://github.com/Microsoft/PTVS.git","ssh_url":"[email protected]:Microsoft/PTVS.git","clone_url":"https://github.com/Microsoft/PTVS.git","svn_url":"https://github.com/Microsoft/PTVS","homepage":"https://aka.ms/PTVS","size":180021,"stargazers_count":1863,"watchers_count":1863,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":481,"mirror_url":null,"archived":false,"open_issues_count":491,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":481,"open_issues":491,"watchers":1863,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/PTVS/pulls/3678"},"html":{"href":"https://github.com/Microsoft/PTVS/pull/3678"},"issue":{"href":"https://api.github.com/repos/Microsoft/PTVS/issues/3678"},"comments":{"href":"https://api.github.com/repos/Microsoft/PTVS/issues/3678/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/PTVS/pulls/3678/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/PTVS/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/PTVS/pulls/3678/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/PTVS/statuses/d9e013db47a8f114553fbb50b500bf26b122a6e4"}},"author_association":"CONTRIBUTOR"}} | {
"id": 32487763,
"name": "Microsoft/PTVS",
"url": "https://api.github.com/repos/Microsoft/PTVS"
} | {
"id": 8933858,
"login": "AlexanderSher",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/8933858?",
"url": "https://api.github.com/users/AlexanderSher"
} | {
"id": 6154722,
"login": "Microsoft",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6154722?",
"url": "https://api.github.com/orgs/Microsoft"
} | 2018-02-01T05:06:44 | 7181450710 | {"actor":{"display_login":"AlexanderSher"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/VFSForGit/pulls/comments/239237150","pull_request_review_id":181972943,"id":239237150,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzOTIzNzE1MA==","diff_hunk":"@@ -11,13 +11,51 @@ struct DarwinVersion\n unsigned long major, minor, revision;\n };\n \n+struct PrjFSService_WatchContext\n+{\n+ std::function<void(io_service_t, io_connect_t, PrjFSService_WatchContext*)> discoveryCallback;\n+ io_iterator_t notificationIterator;\n+ PrjFSServiceUserClientType clientType;\n+};\n+\n+\n typedef decltype(IODataQueueDequeue)* ioDataQueueDequeueFunctionPtr;\n static ioDataQueueDequeueFunctionPtr ioDataQueueDequeueFunction = nullptr;\n typedef decltype(IODataQueuePeek)* ioDataQueuePeekFunctionPtr;\n static ioDataQueuePeekFunctionPtr ioDataQueuePeekFunction = nullptr;\n \n static void InitDataQueueFunctions();\n \n+bool PrjFSService_ValidateVersion(io_service_t prjfsService)\n+{\n+ CFTypeRef kextVersionObj = IORegistryEntryCreateCFProperty(prjfsService, CFSTR(PrjFSKextVersionKey), kCFAllocatorDefault, 0);\n+ CFStringRef kextVersionString;\n+ if (nullptr == kextVersionObj || CFStringGetTypeID() != CFGetTypeID(kextVersionObj))\n+ {\n+ std::cerr << \"PrjFS kernel service does not advertise valid kext version property\\n\";\n+ goto CleanupAndFail;\n+ }\n+ \n+ kextVersionString = static_cast<CFStringRef>(kextVersionObj);\n+ if (kCFCompareEqualTo != CFStringCompare(kextVersionString, CFSTR(PrjFSKextVersion), 0 /* options: case sensitive */))","path":"ProjFS.Mac/PrjFSLib/PrjFSUser.cpp","position":30,"original_position":30,"commit_id":"9ce16a2f0c4afd1d264448bf8ed84dfc9b857165","original_commit_id":"9ce16a2f0c4afd1d264448bf8ed84dfc9b857165","user":{"login":"pmj","id":42341,"node_id":"MDQ6VXNlcjQyMzQx","avatar_url":"https://avatars0.githubusercontent.com/u/42341?v=4","gravatar_id":"","url":"https://api.github.com/users/pmj","html_url":"https://github.com/pmj","followers_url":"https://api.github.com/users/pmj/followers","following_url":"https://api.github.com/users/pmj/following{/other_user}","gists_url":"https://api.github.com/users/pmj/gists{/gist_id}","starred_url":"https://api.github.com/users/pmj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmj/subscriptions","organizations_url":"https://api.github.com/users/pmj/orgs","repos_url":"https://api.github.com/users/pmj/repos","events_url":"https://api.github.com/users/pmj/events{/privacy}","received_events_url":"https://api.github.com/users/pmj/received_events","type":"User","site_admin":false},"body":"Regarding case sensitivity: I guess so, though I'm not sure what the point would be. At the moment, the version is [hardcoded as `\"0.1\"`](https://github.com/Microsoft/VFSForGit/blob/982bdc5697f6c7c04809dc06b216b30db5018755/ProjFS.Mac/PrjFSKext/public/PrjFSCommon.h#L14) so there aren't any letters to treat as case sensitive. We should definitely change the versioning, preferably before the first release, but that's kind of out of scope in this PR. The version checking code itself hasn't changed, I just moved it to a helper function.","created_at":"2018-12-05T21:06:17Z","updated_at":"2018-12-05T21:06:18Z","html_url":"https://github.com/Microsoft/VFSForGit/pull/566#discussion_r239237150","pull_request_url":"https://api.github.com/repos/Microsoft/VFSForGit/pulls/566","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/VFSForGit/pulls/comments/239237150"},"html":{"href":"https://github.com/Microsoft/VFSForGit/pull/566#discussion_r239237150"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/VFSForGit/pulls/566"}},"in_reply_to_id":239177875},"pull_request":{"url":"https://api.github.com/repos/Microsoft/VFSForGit/pulls/566","id":235040358,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM1MDQwMzU4","html_url":"https://github.com/Microsoft/VFSForGit/pull/566","diff_url":"https://github.com/Microsoft/VFSForGit/pull/566.diff","patch_url":"https://github.com/Microsoft/VFSForGit/pull/566.patch","issue_url":"https://api.github.com/repos/Microsoft/VFSForGit/issues/566","number":566,"state":"open","locked":false,"title":"Mac: Prjfs log reconnect","user":{"login":"pmj","id":42341,"node_id":"MDQ6VXNlcjQyMzQx","avatar_url":"https://avatars0.githubusercontent.com/u/42341?v=4","gravatar_id":"","url":"https://api.github.com/users/pmj","html_url":"https://github.com/pmj","followers_url":"https://api.github.com/users/pmj/followers","following_url":"https://api.github.com/users/pmj/following{/other_user}","gists_url":"https://api.github.com/users/pmj/gists{/gist_id}","starred_url":"https://api.github.com/users/pmj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmj/subscriptions","organizations_url":"https://api.github.com/users/pmj/orgs","repos_url":"https://api.github.com/users/pmj/repos","events_url":"https://api.github.com/users/pmj/events{/privacy}","received_events_url":"https://api.github.com/users/pmj/received_events","type":"User","site_admin":false},"body":"This implements #564. \r\n\r\nInstead of searching for the PrjFS IOKit service once on startup, `prjfs-log` now registers for matching notifications. This means that if there is no PrjFS service running (the kext isn't loaded), it will sit and wait for it to turn up. Likewise, if the kext is unloaded, the logging infrastructure for that instance is cleanly torn down. The notification system continues to look out for new instances of the service, so when the kext is reloaded, logging immediately resumes.\r\n\r\nI've also added new log entries for when prjfs starts and stops logging for a particular kext service instance.\r\n\r\nFinally, I've added `fflush(stdout)` calls to avoid dropping buffered messages when prjfs-log output is redirected to a file.","created_at":"2018-11-30T16:18:08Z","updated_at":"2018-12-05T21:06:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e435010bd540a10ad8d5a54e5bf542c7b4603738","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/VFSForGit/pulls/566/commits","review_comments_url":"https://api.github.com/repos/Microsoft/VFSForGit/pulls/566/comments","review_comment_url":"https://api.github.com/repos/Microsoft/VFSForGit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/VFSForGit/issues/566/comments","statuses_url":"https://api.github.com/repos/Microsoft/VFSForGit/statuses/9ce16a2f0c4afd1d264448bf8ed84dfc9b857165","head":{"label":"pmj:prjfs-log-reconnect","ref":"prjfs-log-reconnect","sha":"9ce16a2f0c4afd1d264448bf8ed84dfc9b857165","user":{"login":"pmj","id":42341,"node_id":"MDQ6VXNlcjQyMzQx","avatar_url":"https://avatars0.githubusercontent.com/u/42341?v=4","gravatar_id":"","url":"https://api.github.com/users/pmj","html_url":"https://github.com/pmj","followers_url":"https://api.github.com/users/pmj/followers","following_url":"https://api.github.com/users/pmj/following{/other_user}","gists_url":"https://api.github.com/users/pmj/gists{/gist_id}","starred_url":"https://api.github.com/users/pmj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmj/subscriptions","organizations_url":"https://api.github.com/users/pmj/orgs","repos_url":"https://api.github.com/users/pmj/repos","events_url":"https://api.github.com/users/pmj/events{/privacy}","received_events_url":"https://api.github.com/users/pmj/received_events","type":"User","site_admin":false},"repo":{"id":144459282,"node_id":"MDEwOlJlcG9zaXRvcnkxNDQ0NTkyODI=","name":"VFSForGit","full_name":"pmj/VFSForGit","private":false,"owner":{"login":"pmj","id":42341,"node_id":"MDQ6VXNlcjQyMzQx","avatar_url":"https://avatars0.githubusercontent.com/u/42341?v=4","gravatar_id":"","url":"https://api.github.com/users/pmj","html_url":"https://github.com/pmj","followers_url":"https://api.github.com/users/pmj/followers","following_url":"https://api.github.com/users/pmj/following{/other_user}","gists_url":"https://api.github.com/users/pmj/gists{/gist_id}","starred_url":"https://api.github.com/users/pmj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmj/subscriptions","organizations_url":"https://api.github.com/users/pmj/orgs","repos_url":"https://api.github.com/users/pmj/repos","events_url":"https://api.github.com/users/pmj/events{/privacy}","received_events_url":"https://api.github.com/users/pmj/received_events","type":"User","site_admin":false},"html_url":"https://github.com/pmj/VFSForGit","description":"Virtual File System for Git: Enable Git at Enterprise Scale","fork":true,"url":"https://api.github.com/repos/pmj/VFSForGit","forks_url":"https://api.github.com/repos/pmj/VFSForGit/forks","keys_url":"https://api.github.com/repos/pmj/VFSForGit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pmj/VFSForGit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pmj/VFSForGit/teams","hooks_url":"https://api.github.com/repos/pmj/VFSForGit/hooks","issue_events_url":"https://api.github.com/repos/pmj/VFSForGit/issues/events{/number}","events_url":"https://api.github.com/repos/pmj/VFSForGit/events","assignees_url":"https://api.github.com/repos/pmj/VFSForGit/assignees{/user}","branches_url":"https://api.github.com/repos/pmj/VFSForGit/branches{/branch}","tags_url":"https://api.github.com/repos/pmj/VFSForGit/tags","blobs_url":"https://api.github.com/repos/pmj/VFSForGit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pmj/VFSForGit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pmj/VFSForGit/git/refs{/sha}","trees_url":"https://api.github.com/repos/pmj/VFSForGit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pmj/VFSForGit/statuses/{sha}","languages_url":"https://api.github.com/repos/pmj/VFSForGit/languages","stargazers_url":"https://api.github.com/repos/pmj/VFSForGit/stargazers","contributors_url":"https://api.github.com/repos/pmj/VFSForGit/contributors","subscribers_url":"https://api.github.com/repos/pmj/VFSForGit/subscribers","subscription_url":"https://api.github.com/repos/pmj/VFSForGit/subscription","commits_url":"https://api.github.com/repos/pmj/VFSForGit/commits{/sha}","git_commits_url":"https://api.github.com/repos/pmj/VFSForGit/git/commits{/sha}","comments_url":"https://api.github.com/repos/pmj/VFSForGit/comments{/number}","issue_comment_url":"https://api.github.com/repos/pmj/VFSForGit/issues/comments{/number}","contents_url":"https://api.github.com/repos/pmj/VFSForGit/contents/{+path}","compare_url":"https://api.github.com/repos/pmj/VFSForGit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pmj/VFSForGit/merges","archive_url":"https://api.github.com/repos/pmj/VFSForGit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pmj/VFSForGit/downloads","issues_url":"https://api.github.com/repos/pmj/VFSForGit/issues{/number}","pulls_url":"https://api.github.com/repos/pmj/VFSForGit/pulls{/number}","milestones_url":"https://api.github.com/repos/pmj/VFSForGit/milestones{/number}","notifications_url":"https://api.github.com/repos/pmj/VFSForGit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pmj/VFSForGit/labels{/name}","releases_url":"https://api.github.com/repos/pmj/VFSForGit/releases{/id}","deployments_url":"https://api.github.com/repos/pmj/VFSForGit/deployments","created_at":"2018-08-12T10:59:08Z","updated_at":"2018-12-05T13:22:11Z","pushed_at":"2018-12-05T17:41:30Z","git_url":"git://github.com/pmj/VFSForGit.git","ssh_url":"[email protected]:pmj/VFSForGit.git","clone_url":"https://github.com/pmj/VFSForGit.git","svn_url":"https://github.com/pmj/VFSForGit","homepage":"https://gvfs.io/","size":3709,"stargazers_count":1,"watchers_count":1,"language":"C#","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"8ccd498828e9781aba52f0b7a5fd493e9dacda82","user":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":80058269,"node_id":"MDEwOlJlcG9zaXRvcnk4MDA1ODI2OQ==","name":"VFSForGit","full_name":"Microsoft/VFSForGit","private":false,"owner":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Microsoft/VFSForGit","description":"Virtual File System for Git: Enable Git at Enterprise Scale","fork":false,"url":"https://api.github.com/repos/Microsoft/VFSForGit","forks_url":"https://api.github.com/repos/Microsoft/VFSForGit/forks","keys_url":"https://api.github.com/repos/Microsoft/VFSForGit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/VFSForGit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/VFSForGit/teams","hooks_url":"https://api.github.com/repos/Microsoft/VFSForGit/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/VFSForGit/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/VFSForGit/events","assignees_url":"https://api.github.com/repos/Microsoft/VFSForGit/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/VFSForGit/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/VFSForGit/tags","blobs_url":"https://api.github.com/repos/Microsoft/VFSForGit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/VFSForGit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/VFSForGit/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/VFSForGit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/VFSForGit/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/VFSForGit/languages","stargazers_url":"https://api.github.com/repos/Microsoft/VFSForGit/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/VFSForGit/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/VFSForGit/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/VFSForGit/subscription","commits_url":"https://api.github.com/repos/Microsoft/VFSForGit/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/VFSForGit/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/VFSForGit/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/VFSForGit/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/VFSForGit/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/VFSForGit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/VFSForGit/merges","archive_url":"https://api.github.com/repos/Microsoft/VFSForGit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/VFSForGit/downloads","issues_url":"https://api.github.com/repos/Microsoft/VFSForGit/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/VFSForGit/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/VFSForGit/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/VFSForGit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/VFSForGit/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/VFSForGit/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/VFSForGit/deployments","created_at":"2017-01-25T21:10:29Z","updated_at":"2018-12-05T17:41:21Z","pushed_at":"2018-12-05T20:39:13Z","git_url":"git://github.com/Microsoft/VFSForGit.git","ssh_url":"[email protected]:Microsoft/VFSForGit.git","clone_url":"https://github.com/Microsoft/VFSForGit.git","svn_url":"https://github.com/Microsoft/VFSForGit","homepage":"https://vfsforgit.org/","size":3670,"stargazers_count":4415,"watchers_count":4415,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":298,"mirror_url":null,"archived":false,"open_issues_count":155,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":298,"open_issues":155,"watchers":4415,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/VFSForGit/pulls/566"},"html":{"href":"https://github.com/Microsoft/VFSForGit/pull/566"},"issue":{"href":"https://api.github.com/repos/Microsoft/VFSForGit/issues/566"},"comments":{"href":"https://api.github.com/repos/Microsoft/VFSForGit/issues/566/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/VFSForGit/pulls/566/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/VFSForGit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/VFSForGit/pulls/566/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/VFSForGit/statuses/9ce16a2f0c4afd1d264448bf8ed84dfc9b857165"}},"author_association":"CONTRIBUTOR"}} | {
"id": 80058269,
"name": "Microsoft/VFSForGit",
"url": "https://api.github.com/repos/Microsoft/VFSForGit"
} | {
"id": 42341,
"login": "pmj",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/42341?",
"url": "https://api.github.com/users/pmj"
} | {
"id": 6154722,
"login": "Microsoft",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6154722?",
"url": "https://api.github.com/orgs/Microsoft"
} | 2018-12-05T21:06:17 | 8705012473 | {"actor":{"display_login":"pmj"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/PTVS/pulls/comments/175172690","pull_request_review_id":104666861,"id":175172690,"diff_hunk":"@@ -134,7 +134,14 @@ internal class PythonDebugReplEvaluator :\n \n if (_activeEvaluator != null) {\n return _activeEvaluator.ExecuteCodeAsync(text);\n+ } else {\n+ // TODO: Move this to DebugReplEvaluator for Experimental Debugger\n+ if (CustomDebugAdapterProtocolExtension.CanUseExperimental()) {","path":"Python/Product/PythonTools/PythonTools/Repl/PythonDebugReplEvaluator.cs","position":6,"original_position":6,"commit_id":"a9cc86cee619fba92a09057fa1f222fd16366622","original_commit_id":"a9cc86cee619fba92a09057fa1f222fd16366622","user":{"login":"karthiknadig","id":3840081,"avatar_url":"https://avatars3.githubusercontent.com/u/3840081?v=4","gravatar_id":"","url":"https://api.github.com/users/karthiknadig","html_url":"https://github.com/karthiknadig","followers_url":"https://api.github.com/users/karthiknadig/followers","following_url":"https://api.github.com/users/karthiknadig/following{/other_user}","gists_url":"https://api.github.com/users/karthiknadig/gists{/gist_id}","starred_url":"https://api.github.com/users/karthiknadig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karthiknadig/subscriptions","organizations_url":"https://api.github.com/users/karthiknadig/orgs","repos_url":"https://api.github.com/users/karthiknadig/repos","events_url":"https://api.github.com/users/karthiknadig/events{/privacy}","received_events_url":"https://api.github.com/users/karthiknadig/received_events","type":"User","site_admin":false},"body":"This is just a sample showing how we can send requests and get responses from the experimental debugger. We can moves this to the clone of Debug process repl evaluator which understands how to talk to the experimental debugger. ","created_at":"2018-03-16T18:06:55Z","updated_at":"2018-03-16T18:06:55Z","html_url":"https://github.com/Microsoft/PTVS/pull/3895#discussion_r175172690","pull_request_url":"https://api.github.com/repos/Microsoft/PTVS/pulls/3895","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/PTVS/pulls/comments/175172690"},"html":{"href":"https://github.com/Microsoft/PTVS/pull/3895#discussion_r175172690"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/PTVS/pulls/3895"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/PTVS/pulls/3895","id":175607092,"html_url":"https://github.com/Microsoft/PTVS/pull/3895","diff_url":"https://github.com/Microsoft/PTVS/pull/3895.diff","patch_url":"https://github.com/Microsoft/PTVS/pull/3895.patch","issue_url":"https://api.github.com/repos/Microsoft/PTVS/issues/3895","number":3895,"state":"open","locked":false,"title":"[WIP] Use experimental debugger with Debug Repl","user":{"login":"karthiknadig","id":3840081,"avatar_url":"https://avatars3.githubusercontent.com/u/3840081?v=4","gravatar_id":"","url":"https://api.github.com/users/karthiknadig","html_url":"https://github.com/karthiknadig","followers_url":"https://api.github.com/users/karthiknadig/followers","following_url":"https://api.github.com/users/karthiknadig/following{/other_user}","gists_url":"https://api.github.com/users/karthiknadig/gists{/gist_id}","starred_url":"https://api.github.com/users/karthiknadig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karthiknadig/subscriptions","organizations_url":"https://api.github.com/users/karthiknadig/orgs","repos_url":"https://api.github.com/users/karthiknadig/repos","events_url":"https://api.github.com/users/karthiknadig/events{/privacy}","received_events_url":"https://api.github.com/users/karthiknadig/received_events","type":"User","site_admin":false},"body":"Created this PR to discuss how we want to do the Debug Repl evaluator.","created_at":"2018-03-16T18:03:55Z","updated_at":"2018-03-16T18:06:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6e214ed25efdd791cc01db54a368d51721c455c8","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/PTVS/pulls/3895/commits","review_comments_url":"https://api.github.com/repos/Microsoft/PTVS/pulls/3895/comments","review_comment_url":"https://api.github.com/repos/Microsoft/PTVS/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/PTVS/issues/3895/comments","statuses_url":"https://api.github.com/repos/Microsoft/PTVS/statuses/a9cc86cee619fba92a09057fa1f222fd16366622","head":{"label":"karthiknadig:bugs2","ref":"bugs2","sha":"a9cc86cee619fba92a09057fa1f222fd16366622","user":{"login":"karthiknadig","id":3840081,"avatar_url":"https://avatars3.githubusercontent.com/u/3840081?v=4","gravatar_id":"","url":"https://api.github.com/users/karthiknadig","html_url":"https://github.com/karthiknadig","followers_url":"https://api.github.com/users/karthiknadig/followers","following_url":"https://api.github.com/users/karthiknadig/following{/other_user}","gists_url":"https://api.github.com/users/karthiknadig/gists{/gist_id}","starred_url":"https://api.github.com/users/karthiknadig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karthiknadig/subscriptions","organizations_url":"https://api.github.com/users/karthiknadig/orgs","repos_url":"https://api.github.com/users/karthiknadig/repos","events_url":"https://api.github.com/users/karthiknadig/events{/privacy}","received_events_url":"https://api.github.com/users/karthiknadig/received_events","type":"User","site_admin":false},"repo":{"id":58780958,"name":"PTVS","full_name":"karthiknadig/PTVS","owner":{"login":"karthiknadig","id":3840081,"avatar_url":"https://avatars3.githubusercontent.com/u/3840081?v=4","gravatar_id":"","url":"https://api.github.com/users/karthiknadig","html_url":"https://github.com/karthiknadig","followers_url":"https://api.github.com/users/karthiknadig/followers","following_url":"https://api.github.com/users/karthiknadig/following{/other_user}","gists_url":"https://api.github.com/users/karthiknadig/gists{/gist_id}","starred_url":"https://api.github.com/users/karthiknadig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karthiknadig/subscriptions","organizations_url":"https://api.github.com/users/karthiknadig/orgs","repos_url":"https://api.github.com/users/karthiknadig/repos","events_url":"https://api.github.com/users/karthiknadig/events{/privacy}","received_events_url":"https://api.github.com/users/karthiknadig/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/karthiknadig/PTVS","description":"Python Tools for Visual Studio","fork":true,"url":"https://api.github.com/repos/karthiknadig/PTVS","forks_url":"https://api.github.com/repos/karthiknadig/PTVS/forks","keys_url":"https://api.github.com/repos/karthiknadig/PTVS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/karthiknadig/PTVS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/karthiknadig/PTVS/teams","hooks_url":"https://api.github.com/repos/karthiknadig/PTVS/hooks","issue_events_url":"https://api.github.com/repos/karthiknadig/PTVS/issues/events{/number}","events_url":"https://api.github.com/repos/karthiknadig/PTVS/events","assignees_url":"https://api.github.com/repos/karthiknadig/PTVS/assignees{/user}","branches_url":"https://api.github.com/repos/karthiknadig/PTVS/branches{/branch}","tags_url":"https://api.github.com/repos/karthiknadig/PTVS/tags","blobs_url":"https://api.github.com/repos/karthiknadig/PTVS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/karthiknadig/PTVS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/karthiknadig/PTVS/git/refs{/sha}","trees_url":"https://api.github.com/repos/karthiknadig/PTVS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/karthiknadig/PTVS/statuses/{sha}","languages_url":"https://api.github.com/repos/karthiknadig/PTVS/languages","stargazers_url":"https://api.github.com/repos/karthiknadig/PTVS/stargazers","contributors_url":"https://api.github.com/repos/karthiknadig/PTVS/contributors","subscribers_url":"https://api.github.com/repos/karthiknadig/PTVS/subscribers","subscription_url":"https://api.github.com/repos/karthiknadig/PTVS/subscription","commits_url":"https://api.github.com/repos/karthiknadig/PTVS/commits{/sha}","git_commits_url":"https://api.github.com/repos/karthiknadig/PTVS/git/commits{/sha}","comments_url":"https://api.github.com/repos/karthiknadig/PTVS/comments{/number}","issue_comment_url":"https://api.github.com/repos/karthiknadig/PTVS/issues/comments{/number}","contents_url":"https://api.github.com/repos/karthiknadig/PTVS/contents/{+path}","compare_url":"https://api.github.com/repos/karthiknadig/PTVS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/karthiknadig/PTVS/merges","archive_url":"https://api.github.com/repos/karthiknadig/PTVS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/karthiknadig/PTVS/downloads","issues_url":"https://api.github.com/repos/karthiknadig/PTVS/issues{/number}","pulls_url":"https://api.github.com/repos/karthiknadig/PTVS/pulls{/number}","milestones_url":"https://api.github.com/repos/karthiknadig/PTVS/milestones{/number}","notifications_url":"https://api.github.com/repos/karthiknadig/PTVS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/karthiknadig/PTVS/labels{/name}","releases_url":"https://api.github.com/repos/karthiknadig/PTVS/releases{/id}","deployments_url":"https://api.github.com/repos/karthiknadig/PTVS/deployments","created_at":"2016-05-14T00:12:01Z","updated_at":"2018-03-13T18:23:43Z","pushed_at":"2018-03-16T18:01:49Z","git_url":"git://github.com/karthiknadig/PTVS.git","ssh_url":"[email protected]:karthiknadig/PTVS.git","clone_url":"https://github.com/karthiknadig/PTVS.git","svn_url":"https://github.com/karthiknadig/PTVS","homepage":"https://microsoft.github.io/PTVS","size":181107,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"0cb6ea3e6f7771c5cd40559ea69ea4853a6c6771","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":32487763,"name":"PTVS","full_name":"Microsoft/PTVS","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/PTVS","description":"Python Tools for Visual Studio","fork":false,"url":"https://api.github.com/repos/Microsoft/PTVS","forks_url":"https://api.github.com/repos/Microsoft/PTVS/forks","keys_url":"https://api.github.com/repos/Microsoft/PTVS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/PTVS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/PTVS/teams","hooks_url":"https://api.github.com/repos/Microsoft/PTVS/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/PTVS/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/PTVS/events","assignees_url":"https://api.github.com/repos/Microsoft/PTVS/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/PTVS/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/PTVS/tags","blobs_url":"https://api.github.com/repos/Microsoft/PTVS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/PTVS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/PTVS/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/PTVS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/PTVS/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/PTVS/languages","stargazers_url":"https://api.github.com/repos/Microsoft/PTVS/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/PTVS/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/PTVS/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/PTVS/subscription","commits_url":"https://api.github.com/repos/Microsoft/PTVS/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/PTVS/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/PTVS/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/PTVS/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/PTVS/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/PTVS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/PTVS/merges","archive_url":"https://api.github.com/repos/Microsoft/PTVS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/PTVS/downloads","issues_url":"https://api.github.com/repos/Microsoft/PTVS/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/PTVS/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/PTVS/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/PTVS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/PTVS/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/PTVS/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/PTVS/deployments","created_at":"2015-03-18T22:30:53Z","updated_at":"2018-03-16T17:09:43Z","pushed_at":"2018-03-16T18:03:56Z","git_url":"git://github.com/Microsoft/PTVS.git","ssh_url":"[email protected]:Microsoft/PTVS.git","clone_url":"https://github.com/Microsoft/PTVS.git","svn_url":"https://github.com/Microsoft/PTVS","homepage":"https://aka.ms/PTVS","size":183036,"stargazers_count":1900,"watchers_count":1900,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":496,"mirror_url":null,"archived":false,"open_issues_count":519,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":496,"open_issues":519,"watchers":1900,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/PTVS/pulls/3895"},"html":{"href":"https://github.com/Microsoft/PTVS/pull/3895"},"issue":{"href":"https://api.github.com/repos/Microsoft/PTVS/issues/3895"},"comments":{"href":"https://api.github.com/repos/Microsoft/PTVS/issues/3895/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/PTVS/pulls/3895/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/PTVS/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/PTVS/pulls/3895/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/PTVS/statuses/a9cc86cee619fba92a09057fa1f222fd16366622"}},"author_association":"MEMBER"}} | {
"id": 32487763,
"name": "Microsoft/PTVS",
"url": "https://api.github.com/repos/Microsoft/PTVS"
} | {
"id": 3840081,
"login": "karthiknadig",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3840081?",
"url": "https://api.github.com/users/karthiknadig"
} | {
"id": 6154722,
"login": "Microsoft",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6154722?",
"url": "https://api.github.com/orgs/Microsoft"
} | 2018-03-16T18:06:55 | 7392278976 | {"actor":{"display_login":"karthiknadig"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/pulls/comments/179900154","pull_request_review_id":110237670,"id":179900154,"diff_hunk":"@@ -222,6 +222,19 @@ public static IServiceCollection AddApplicationInsightsTelemetryProcessor(this I\n return services.AddSingleton<ITelemetryProcessorFactory>(serviceProvider => new TelemetryProcessorFactory(serviceProvider, telemetryProcessorType));\n }\n \n+ /// <summary>\n+ /// Extension method to provide configuration logic for application insights telemetry module.\n+ /// </summary>\n+ /// <param name=\"services\">The <see cref=\"IServiceCollection\"/> instance.</param>\n+ /// <param name=\"configModule\">Action used to configure the module.</param>\n+ /// <returns>\n+ /// The <see cref=\"IServiceCollection\"/>.\n+ /// </returns> \n+ public static IServiceCollection ConfigureTelemetryModule<T>(this IServiceCollection services, Action<T> configModule) where T : ITelemetryModule\n+ {","path":"src/Microsoft.ApplicationInsights.AspNetCore/Extensions/ApplicationInsightsExtensions.cs","position":13,"original_position":13,"commit_id":"ef2c2b52e6ffc287272d93ad123033d04efb08a8","original_commit_id":"ef2c2b52e6ffc287272d93ad123033d04efb08a8","user":{"login":"pharring","id":9952654,"avatar_url":"https://avatars3.githubusercontent.com/u/9952654?v=4","gravatar_id":"","url":"https://api.github.com/users/pharring","html_url":"https://github.com/pharring","followers_url":"https://api.github.com/users/pharring/followers","following_url":"https://api.github.com/users/pharring/following{/other_user}","gists_url":"https://api.github.com/users/pharring/gists{/gist_id}","starred_url":"https://api.github.com/users/pharring/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pharring/subscriptions","organizations_url":"https://api.github.com/users/pharring/orgs","repos_url":"https://api.github.com/users/pharring/repos","events_url":"https://api.github.com/users/pharring/events{/privacy}","received_events_url":"https://api.github.com/users/pharring/received_events","type":"User","site_admin":false},"body":"Throw `ArgumentNullException` if configModule is null.","created_at":"2018-04-07T00:06:53Z","updated_at":"2018-04-07T00:06:53Z","html_url":"https://github.com/Microsoft/ApplicationInsights-aspnetcore/pull/632#discussion_r179900154","pull_request_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/pulls/632","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/pulls/comments/179900154"},"html":{"href":"https://github.com/Microsoft/ApplicationInsights-aspnetcore/pull/632#discussion_r179900154"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/pulls/632"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/pulls/632","id":180074933,"html_url":"https://github.com/Microsoft/ApplicationInsights-aspnetcore/pull/632","diff_url":"https://github.com/Microsoft/ApplicationInsights-aspnetcore/pull/632.diff","patch_url":"https://github.com/Microsoft/ApplicationInsights-aspnetcore/pull/632.patch","issue_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/issues/632","number":632,"state":"open","locked":false,"title":"Added extension method to allow configure any TelemetryModule.","user":{"login":"cijothomas","id":5232798,"avatar_url":"https://avatars3.githubusercontent.com/u/5232798?v=4","gravatar_id":"","url":"https://api.github.com/users/cijothomas","html_url":"https://github.com/cijothomas","followers_url":"https://api.github.com/users/cijothomas/followers","following_url":"https://api.github.com/users/cijothomas/following{/other_user}","gists_url":"https://api.github.com/users/cijothomas/gists{/gist_id}","starred_url":"https://api.github.com/users/cijothomas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cijothomas/subscriptions","organizations_url":"https://api.github.com/users/cijothomas/orgs","repos_url":"https://api.github.com/users/cijothomas/repos","events_url":"https://api.github.com/users/cijothomas/events{/privacy}","received_events_url":"https://api.github.com/users/cijothomas/received_events","type":"User","site_admin":false},"body":"More tests are needed. Submitting a PR to get early feedback before I spend too much time.\r\n\r\nPending: \r\nDocument how to use this in Wiki.\r\nDetermine what to do if the Module is not found. Throw? Or just log and move on? \r\nMake SDK also use this extension to configure DependencyCollector.\r\n\r\nFix Issue # .\r\n<Short description of the fix.>\r\n\r\n- [ ] I ran Unit Tests locally.\r\n\r\nFor significant contributions please make sure you have completed the following items:\r\n\r\n- [ ] Changes in public surface reviewed\r\n- [ ] Design discussion issue #\r\n- [ ] CHANGELOG.md updated with one line description of the fix, and a link to the original issue.\r\n- [ ] The PR will trigger build, unit tests, and functional tests automatically. If your PR was submitted from fork - mention one of committers to initiate the build for you.\r\n\t If you want to to re-run the build/tests, the easiest way is to simply Close and Re-Open this same PR. (Just click 'close pull request' followed by 'open pull request' buttons at the bottom of the PR)\r\n\r\n- Please follow [these] (https://github.com/Microsoft/ApplicationInsights-aspnetcore/blob/develop/Readme.md) instructions to build and test locally.\r\n","created_at":"2018-04-06T23:30:50Z","updated_at":"2018-04-07T00:06:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"948a47b88733b6c6f5cacfb87b24d6fcbde3eda1","assignee":null,"assignees":[],"requested_reviewers":[{"login":"SergeyKanzhelev","id":9950081,"avatar_url":"https://avatars2.githubusercontent.com/u/9950081?v=4","gravatar_id":"","url":"https://api.github.com/users/SergeyKanzhelev","html_url":"https://github.com/SergeyKanzhelev","followers_url":"https://api.github.com/users/SergeyKanzhelev/followers","following_url":"https://api.github.com/users/SergeyKanzhelev/following{/other_user}","gists_url":"https://api.github.com/users/SergeyKanzhelev/gists{/gist_id}","starred_url":"https://api.github.com/users/SergeyKanzhelev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SergeyKanzhelev/subscriptions","organizations_url":"https://api.github.com/users/SergeyKanzhelev/orgs","repos_url":"https://api.github.com/users/SergeyKanzhelev/repos","events_url":"https://api.github.com/users/SergeyKanzhelev/events{/privacy}","received_events_url":"https://api.github.com/users/SergeyKanzhelev/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/milestones/31","html_url":"https://github.com/Microsoft/ApplicationInsights-aspnetcore/milestone/31","labels_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/milestones/31/labels","id":3084401,"number":31,"title":"2.3.0","description":"","creator":{"login":"cijothomas","id":5232798,"avatar_url":"https://avatars3.githubusercontent.com/u/5232798?v=4","gravatar_id":"","url":"https://api.github.com/users/cijothomas","html_url":"https://github.com/cijothomas","followers_url":"https://api.github.com/users/cijothomas/followers","following_url":"https://api.github.com/users/cijothomas/following{/other_user}","gists_url":"https://api.github.com/users/cijothomas/gists{/gist_id}","starred_url":"https://api.github.com/users/cijothomas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cijothomas/subscriptions","organizations_url":"https://api.github.com/users/cijothomas/orgs","repos_url":"https://api.github.com/users/cijothomas/repos","events_url":"https://api.github.com/users/cijothomas/events{/privacy}","received_events_url":"https://api.github.com/users/cijothomas/received_events","type":"User","site_admin":false},"open_issues":12,"closed_issues":1,"state":"open","created_at":"2018-02-02T17:14:58Z","updated_at":"2018-04-07T00:06:14Z","due_on":"2018-05-01T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/pulls/632/commits","review_comments_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/pulls/632/comments","review_comment_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/issues/632/comments","statuses_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/statuses/ef2c2b52e6ffc287272d93ad123033d04efb08a8","head":{"label":"Microsoft:cithomas/fixconfig","ref":"cithomas/fixconfig","sha":"ef2c2b52e6ffc287272d93ad123033d04efb08a8","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":32415843,"name":"ApplicationInsights-aspnetcore","full_name":"Microsoft/ApplicationInsights-aspnetcore","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/ApplicationInsights-aspnetcore","description":"ASP.NET Core web applications monitoring","fork":false,"url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore","forks_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/forks","keys_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/teams","hooks_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/events","assignees_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/tags","blobs_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/languages","stargazers_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/subscription","commits_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/merges","archive_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/downloads","issues_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/deployments","created_at":"2015-03-17T19:39:40Z","updated_at":"2018-04-06T23:38:19Z","pushed_at":"2018-04-06T23:37:31Z","git_url":"git://github.com/Microsoft/ApplicationInsights-aspnetcore.git","ssh_url":"[email protected]:Microsoft/ApplicationInsights-aspnetcore.git","clone_url":"https://github.com/Microsoft/ApplicationInsights-aspnetcore.git","svn_url":"https://github.com/Microsoft/ApplicationInsights-aspnetcore","homepage":"","size":6202,"stargazers_count":157,"watchers_count":157,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":87,"mirror_url":null,"archived":false,"open_issues_count":87,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":87,"open_issues":87,"watchers":157,"default_branch":"develop"}},"base":{"label":"Microsoft:develop","ref":"develop","sha":"b3fb46d59c08e6d0219b735bfb3218999c76d549","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":32415843,"name":"ApplicationInsights-aspnetcore","full_name":"Microsoft/ApplicationInsights-aspnetcore","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/ApplicationInsights-aspnetcore","description":"ASP.NET Core web applications monitoring","fork":false,"url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore","forks_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/forks","keys_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/teams","hooks_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/events","assignees_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/tags","blobs_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/languages","stargazers_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/subscription","commits_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/merges","archive_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/downloads","issues_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/deployments","created_at":"2015-03-17T19:39:40Z","updated_at":"2018-04-06T23:38:19Z","pushed_at":"2018-04-06T23:37:31Z","git_url":"git://github.com/Microsoft/ApplicationInsights-aspnetcore.git","ssh_url":"[email protected]:Microsoft/ApplicationInsights-aspnetcore.git","clone_url":"https://github.com/Microsoft/ApplicationInsights-aspnetcore.git","svn_url":"https://github.com/Microsoft/ApplicationInsights-aspnetcore","homepage":"","size":6202,"stargazers_count":157,"watchers_count":157,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":87,"mirror_url":null,"archived":false,"open_issues_count":87,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":87,"open_issues":87,"watchers":157,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/pulls/632"},"html":{"href":"https://github.com/Microsoft/ApplicationInsights-aspnetcore/pull/632"},"issue":{"href":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/issues/632"},"comments":{"href":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/issues/632/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/pulls/632/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/pulls/632/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/statuses/ef2c2b52e6ffc287272d93ad123033d04efb08a8"}},"author_association":"CONTRIBUTOR"}} | {
"id": 32415843,
"name": "Microsoft/ApplicationInsights-aspnetcore",
"url": "https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore"
} | {
"id": 9952654,
"login": "pharring",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9952654?",
"url": "https://api.github.com/users/pharring"
} | {
"id": 6154722,
"login": "Microsoft",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6154722?",
"url": "https://api.github.com/orgs/Microsoft"
} | 2018-04-07T00:06:53 | 7493710751 | {"actor":{"display_login":"pharring"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/pulls/comments/229524981","pull_request_review_id":170046300,"id":229524981,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyOTUyNDk4MQ==","diff_hunk":"@@ -0,0 +1,76 @@\n+# Contributing\n+\n+Thanks for your interest in contributing to tslint-microsoft-contrib!\n+Be sure to read our [code of conduct](./CODE_OF_CONDUCT.md) first.\n+\n+To develop `tslint-microsoft-contrib`, clone the repository, install dependencies, and run `npm test`:\n+\n+```shell\n+git clone [email protected]:Microsoft/tslint-microsoft-contrib.git --config core.autocrlf=input --config core.eol=lf\n+cd tslint-microsoft-contrib\n+npm install\n+npm test\n+```\n+\n+You can create new rule from template with `create-rule` script:\n+\n+```shell\n+npm run create-rule -- --rule-name=no-something-or-other\n+```\n+\n+> NOTE: `--` is required before script arguments.\n+\n+This script will create file for rule implementation (inside `src`) as well as folder with rule tests (inside `test`).\n+\n+More information about writing rule tests can be found in [TSLint documentation](https://palantir.github.io/tslint/develop/testing-rules/).\n+\n+Please also see our [Code of Conduct](CODE_OF_CONDUCT.md).","path":"CONTRIBUTING.md","position":27,"original_position":27,"commit_id":"3cf8e9f911b7bcd99a43931ecd426b3f09d853f6","original_commit_id":"3cf8e9f911b7bcd99a43931ecd426b3f09d853f6","user":{"login":"IllusionMH","id":1312662,"node_id":"MDQ6VXNlcjEzMTI2NjI=","avatar_url":"https://avatars1.githubusercontent.com/u/1312662?v=4","gravatar_id":"","url":"https://api.github.com/users/IllusionMH","html_url":"https://github.com/IllusionMH","followers_url":"https://api.github.com/users/IllusionMH/followers","following_url":"https://api.github.com/users/IllusionMH/following{/other_user}","gists_url":"https://api.github.com/users/IllusionMH/gists{/gist_id}","starred_url":"https://api.github.com/users/IllusionMH/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IllusionMH/subscriptions","organizations_url":"https://api.github.com/users/IllusionMH/orgs","repos_url":"https://api.github.com/users/IllusionMH/repos","events_url":"https://api.github.com/users/IllusionMH/events{/privacy}","received_events_url":"https://api.github.com/users/IllusionMH/received_events","type":"User","site_admin":false},"body":"There is already a link to CoC in the first sentence.","created_at":"2018-10-30T23:44:48Z","updated_at":"2018-10-30T23:44:48Z","html_url":"https://github.com/Microsoft/tslint-microsoft-contrib/pull/617#discussion_r229524981","pull_request_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/pulls/617","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/pulls/comments/229524981"},"html":{"href":"https://github.com/Microsoft/tslint-microsoft-contrib/pull/617#discussion_r229524981"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/pulls/617"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/pulls/617","id":227057398,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3MDU3Mzk4","html_url":"https://github.com/Microsoft/tslint-microsoft-contrib/pull/617","diff_url":"https://github.com/Microsoft/tslint-microsoft-contrib/pull/617.diff","patch_url":"https://github.com/Microsoft/tslint-microsoft-contrib/pull/617.patch","issue_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/issues/617","number":617,"state":"open","locked":false,"title":"Separated development docs into a CONTRIBUTING.md","user":{"login":"JoshuaKGoldberg","id":3335181,"node_id":"MDQ6VXNlcjMzMzUxODE=","avatar_url":"https://avatars1.githubusercontent.com/u/3335181?v=4","gravatar_id":"","url":"https://api.github.com/users/JoshuaKGoldberg","html_url":"https://github.com/JoshuaKGoldberg","followers_url":"https://api.github.com/users/JoshuaKGoldberg/followers","following_url":"https://api.github.com/users/JoshuaKGoldberg/following{/other_user}","gists_url":"https://api.github.com/users/JoshuaKGoldberg/gists{/gist_id}","starred_url":"https://api.github.com/users/JoshuaKGoldberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JoshuaKGoldberg/subscriptions","organizations_url":"https://api.github.com/users/JoshuaKGoldberg/orgs","repos_url":"https://api.github.com/users/JoshuaKGoldberg/repos","events_url":"https://api.github.com/users/JoshuaKGoldberg/events{/privacy}","received_events_url":"https://api.github.com/users/JoshuaKGoldberg/received_events","type":"User","site_admin":false},"body":"Fixes #589.","created_at":"2018-10-30T19:46:28Z","updated_at":"2018-10-30T23:44:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e92dd86042714e7e9da24c6ff794dd3363fe6c95","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1108941348,"node_id":"MDU6TGFiZWwxMTA4OTQxMzQ4","url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/labels/PR:%20Waiting%20for%20Feedback","name":"PR: Waiting for Feedback","color":"d4c5f9","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/pulls/617/commits","review_comments_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/pulls/617/comments","review_comment_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/issues/617/comments","statuses_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/statuses/3cf8e9f911b7bcd99a43931ecd426b3f09d853f6","head":{"label":"Microsoft:contributing-md","ref":"contributing-md","sha":"3cf8e9f911b7bcd99a43931ecd426b3f09d853f6","user":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":41095157,"node_id":"MDEwOlJlcG9zaXRvcnk0MTA5NTE1Nw==","name":"tslint-microsoft-contrib","full_name":"Microsoft/tslint-microsoft-contrib","private":false,"owner":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Microsoft/tslint-microsoft-contrib","description":"A set of TSLint rules used on some Microsoft projects.","fork":false,"url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib","forks_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/forks","keys_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/teams","hooks_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/events","assignees_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/tags","blobs_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/languages","stargazers_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/subscription","commits_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/merges","archive_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/downloads","issues_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/deployments","created_at":"2015-08-20T12:44:29Z","updated_at":"2018-10-30T19:15:31Z","pushed_at":"2018-10-30T23:22:58Z","git_url":"git://github.com/Microsoft/tslint-microsoft-contrib.git","ssh_url":"[email protected]:Microsoft/tslint-microsoft-contrib.git","clone_url":"https://github.com/Microsoft/tslint-microsoft-contrib.git","svn_url":"https://github.com/Microsoft/tslint-microsoft-contrib","homepage":null,"size":2601,"stargazers_count":443,"watchers_count":443,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":164,"mirror_url":null,"archived":false,"open_issues_count":99,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":164,"open_issues":99,"watchers":443,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"ea3f12bb06aef366f71b0e09d74ee566214bb45c","user":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":41095157,"node_id":"MDEwOlJlcG9zaXRvcnk0MTA5NTE1Nw==","name":"tslint-microsoft-contrib","full_name":"Microsoft/tslint-microsoft-contrib","private":false,"owner":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Microsoft/tslint-microsoft-contrib","description":"A set of TSLint rules used on some Microsoft projects.","fork":false,"url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib","forks_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/forks","keys_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/teams","hooks_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/events","assignees_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/tags","blobs_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/languages","stargazers_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/subscription","commits_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/merges","archive_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/downloads","issues_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/deployments","created_at":"2015-08-20T12:44:29Z","updated_at":"2018-10-30T19:15:31Z","pushed_at":"2018-10-30T23:22:58Z","git_url":"git://github.com/Microsoft/tslint-microsoft-contrib.git","ssh_url":"[email protected]:Microsoft/tslint-microsoft-contrib.git","clone_url":"https://github.com/Microsoft/tslint-microsoft-contrib.git","svn_url":"https://github.com/Microsoft/tslint-microsoft-contrib","homepage":null,"size":2601,"stargazers_count":443,"watchers_count":443,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":164,"mirror_url":null,"archived":false,"open_issues_count":99,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":164,"open_issues":99,"watchers":443,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/pulls/617"},"html":{"href":"https://github.com/Microsoft/tslint-microsoft-contrib/pull/617"},"issue":{"href":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/issues/617"},"comments":{"href":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/issues/617/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/pulls/617/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/pulls/617/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/statuses/3cf8e9f911b7bcd99a43931ecd426b3f09d853f6"}},"author_association":"MEMBER"}} | {
"id": 41095157,
"name": "Microsoft/tslint-microsoft-contrib",
"url": "https://api.github.com/repos/Microsoft/tslint-microsoft-contrib"
} | {
"id": 1312662,
"login": "IllusionMH",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1312662?",
"url": "https://api.github.com/users/IllusionMH"
} | {
"id": 6154722,
"login": "Microsoft",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6154722?",
"url": "https://api.github.com/orgs/Microsoft"
} | 2018-10-30T23:44:48 | 8508866144 | {"actor":{"display_login":"IllusionMH"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/vscode-docs/pulls/comments/216143586","pull_request_review_id":153567749,"id":216143586,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNjE0MzU4Ng==","diff_hunk":"@@ -0,0 +1,118 @@\n+# Editing PowerShell in Visual Studio Code\n+\n+PowerShell is a task-based command line shell and scripting language built on the .NET framework.\n+Powershell provides a powerfull toolset for administrators on any platform.\n+\n+The PowerShell extension provides rich [PowerShell Language Support](https://github.com/PowerShell/vscode-powershell)\n+\n+## Install the PowerShell extension on Visual Studio Code\n+\n+ Install-Script Install-VSCode -Scope CurrentUser: Install-VSCode.ps1\n+You will need to accept the prompts that appear if this is your first time running the ```Install-Script``` command\n+\n+### Installing the Extension\n+\n+The official extension can be installed by following the steps in the\n+[Visual Studio Code Docs](https://code.visualstudio.com/docs/editor/extension-gallery)\n+or by going directly to the Marketplace and clicking the [Install Button](vscode:extension/ms-vscode.PowerShell)\n+\n+You can also install the Extension from within Visual Studio code by\n+browsing\n+\n+\n+\n+ for extensions `(ctl+Shift+x)` and searching for PowerShell. Select the PowerShell extension for details\n+\n+ \n+\n+## Example Scripts\n+\n+Example scripts are included with the extension and can be found at the following Path.\n+\n+ C:\\Users\\<yourusername>\\.vscode\\extensions\\ms-vscode.PowerShell-<version>\\examples\n+\n+To open or view the examples in Visual Studio Code run the following from your PowerShell command prompt\n+\n+ code (Get-ChildItem $Home\\.vscode\\extensions\\ms-vscode.PowerShell-*\\examples)[-1]","path":"docs/languages/powershell.md","position":36,"original_position":36,"commit_id":"5469876b90104d3675ffff6800906f7671ac2083","original_commit_id":"5469876b90104d3675ffff6800906f7671ac2083","user":{"login":"DareDevelOps","id":24717094,"node_id":"MDQ6VXNlcjI0NzE3MDk0","avatar_url":"https://avatars2.githubusercontent.com/u/24717094?v=4","gravatar_id":"","url":"https://api.github.com/users/DareDevelOps","html_url":"https://github.com/DareDevelOps","followers_url":"https://api.github.com/users/DareDevelOps/followers","following_url":"https://api.github.com/users/DareDevelOps/following{/other_user}","gists_url":"https://api.github.com/users/DareDevelOps/gists{/gist_id}","starred_url":"https://api.github.com/users/DareDevelOps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DareDevelOps/subscriptions","organizations_url":"https://api.github.com/users/DareDevelOps/orgs","repos_url":"https://api.github.com/users/DareDevelOps/repos","events_url":"https://api.github.com/users/DareDevelOps/events{/privacy}","received_events_url":"https://api.github.com/users/DareDevelOps/received_events","type":"User","site_admin":false},"body":"After testing without using the Get-ChildItem it only brings up a blank examples file rather than opening the examples folder.","created_at":"2018-09-09T00:04:04Z","updated_at":"2018-09-09T00:04:04Z","html_url":"https://github.com/Microsoft/vscode-docs/pull/1838#discussion_r216143586","pull_request_url":"https://api.github.com/repos/Microsoft/vscode-docs/pulls/1838","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/vscode-docs/pulls/comments/216143586"},"html":{"href":"https://github.com/Microsoft/vscode-docs/pull/1838#discussion_r216143586"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/vscode-docs/pulls/1838"}},"in_reply_to_id":216140793},"pull_request":{"url":"https://api.github.com/repos/Microsoft/vscode-docs/pulls/1838","id":214107656,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE0MTA3NjU2","html_url":"https://github.com/Microsoft/vscode-docs/pull/1838","diff_url":"https://github.com/Microsoft/vscode-docs/pull/1838.diff","patch_url":"https://github.com/Microsoft/vscode-docs/pull/1838.patch","issue_url":"https://api.github.com/repos/Microsoft/vscode-docs/issues/1838","number":1838,"state":"open","locked":false,"title":"Lang power shell","user":{"login":"DareDevelOps","id":24717094,"node_id":"MDQ6VXNlcjI0NzE3MDk0","avatar_url":"https://avatars2.githubusercontent.com/u/24717094?v=4","gravatar_id":"","url":"https://api.github.com/users/DareDevelOps","html_url":"https://github.com/DareDevelOps","followers_url":"https://api.github.com/users/DareDevelOps/followers","following_url":"https://api.github.com/users/DareDevelOps/following{/other_user}","gists_url":"https://api.github.com/users/DareDevelOps/gists{/gist_id}","starred_url":"https://api.github.com/users/DareDevelOps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DareDevelOps/subscriptions","organizations_url":"https://api.github.com/users/DareDevelOps/orgs","repos_url":"https://api.github.com/users/DareDevelOps/repos","events_url":"https://api.github.com/users/DareDevelOps/events{/privacy}","received_events_url":"https://api.github.com/users/DareDevelOps/received_events","type":"User","site_admin":false},"body":"Merging lang-powershell branch into master for review of content.\r\n@tylerl0706\r\n@joeyaiello\r\nHave a look and let me know what needs attention.","created_at":"2018-09-08T18:09:42Z","updated_at":"2018-09-09T00:04:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f03f7ff6f79281a627adc39e753e5b2e71e2a434","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/vscode-docs/pulls/1838/commits","review_comments_url":"https://api.github.com/repos/Microsoft/vscode-docs/pulls/1838/comments","review_comment_url":"https://api.github.com/repos/Microsoft/vscode-docs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/vscode-docs/issues/1838/comments","statuses_url":"https://api.github.com/repos/Microsoft/vscode-docs/statuses/5469876b90104d3675ffff6800906f7671ac2083","head":{"label":"DareDevelOps:lang-PowerShell","ref":"lang-PowerShell","sha":"5469876b90104d3675ffff6800906f7671ac2083","user":{"login":"DareDevelOps","id":24717094,"node_id":"MDQ6VXNlcjI0NzE3MDk0","avatar_url":"https://avatars2.githubusercontent.com/u/24717094?v=4","gravatar_id":"","url":"https://api.github.com/users/DareDevelOps","html_url":"https://github.com/DareDevelOps","followers_url":"https://api.github.com/users/DareDevelOps/followers","following_url":"https://api.github.com/users/DareDevelOps/following{/other_user}","gists_url":"https://api.github.com/users/DareDevelOps/gists{/gist_id}","starred_url":"https://api.github.com/users/DareDevelOps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DareDevelOps/subscriptions","organizations_url":"https://api.github.com/users/DareDevelOps/orgs","repos_url":"https://api.github.com/users/DareDevelOps/repos","events_url":"https://api.github.com/users/DareDevelOps/events{/privacy}","received_events_url":"https://api.github.com/users/DareDevelOps/received_events","type":"User","site_admin":false},"repo":{"id":147127027,"node_id":"MDEwOlJlcG9zaXRvcnkxNDcxMjcwMjc=","name":"vscode-docs","full_name":"DareDevelOps/vscode-docs","owner":{"login":"DareDevelOps","id":24717094,"node_id":"MDQ6VXNlcjI0NzE3MDk0","avatar_url":"https://avatars2.githubusercontent.com/u/24717094?v=4","gravatar_id":"","url":"https://api.github.com/users/DareDevelOps","html_url":"https://github.com/DareDevelOps","followers_url":"https://api.github.com/users/DareDevelOps/followers","following_url":"https://api.github.com/users/DareDevelOps/following{/other_user}","gists_url":"https://api.github.com/users/DareDevelOps/gists{/gist_id}","starred_url":"https://api.github.com/users/DareDevelOps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DareDevelOps/subscriptions","organizations_url":"https://api.github.com/users/DareDevelOps/orgs","repos_url":"https://api.github.com/users/DareDevelOps/repos","events_url":"https://api.github.com/users/DareDevelOps/events{/privacy}","received_events_url":"https://api.github.com/users/DareDevelOps/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/DareDevelOps/vscode-docs","description":"Public documentation for Visual Studio Code","fork":true,"url":"https://api.github.com/repos/DareDevelOps/vscode-docs","forks_url":"https://api.github.com/repos/DareDevelOps/vscode-docs/forks","keys_url":"https://api.github.com/repos/DareDevelOps/vscode-docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DareDevelOps/vscode-docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DareDevelOps/vscode-docs/teams","hooks_url":"https://api.github.com/repos/DareDevelOps/vscode-docs/hooks","issue_events_url":"https://api.github.com/repos/DareDevelOps/vscode-docs/issues/events{/number}","events_url":"https://api.github.com/repos/DareDevelOps/vscode-docs/events","assignees_url":"https://api.github.com/repos/DareDevelOps/vscode-docs/assignees{/user}","branches_url":"https://api.github.com/repos/DareDevelOps/vscode-docs/branches{/branch}","tags_url":"https://api.github.com/repos/DareDevelOps/vscode-docs/tags","blobs_url":"https://api.github.com/repos/DareDevelOps/vscode-docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DareDevelOps/vscode-docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DareDevelOps/vscode-docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/DareDevelOps/vscode-docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DareDevelOps/vscode-docs/statuses/{sha}","languages_url":"https://api.github.com/repos/DareDevelOps/vscode-docs/languages","stargazers_url":"https://api.github.com/repos/DareDevelOps/vscode-docs/stargazers","contributors_url":"https://api.github.com/repos/DareDevelOps/vscode-docs/contributors","subscribers_url":"https://api.github.com/repos/DareDevelOps/vscode-docs/subscribers","subscription_url":"https://api.github.com/repos/DareDevelOps/vscode-docs/subscription","commits_url":"https://api.github.com/repos/DareDevelOps/vscode-docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/DareDevelOps/vscode-docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/DareDevelOps/vscode-docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/DareDevelOps/vscode-docs/issues/comments{/number}","contents_url":"https://api.github.com/repos/DareDevelOps/vscode-docs/contents/{+path}","compare_url":"https://api.github.com/repos/DareDevelOps/vscode-docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DareDevelOps/vscode-docs/merges","archive_url":"https://api.github.com/repos/DareDevelOps/vscode-docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DareDevelOps/vscode-docs/downloads","issues_url":"https://api.github.com/repos/DareDevelOps/vscode-docs/issues{/number}","pulls_url":"https://api.github.com/repos/DareDevelOps/vscode-docs/pulls{/number}","milestones_url":"https://api.github.com/repos/DareDevelOps/vscode-docs/milestones{/number}","notifications_url":"https://api.github.com/repos/DareDevelOps/vscode-docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DareDevelOps/vscode-docs/labels{/name}","releases_url":"https://api.github.com/repos/DareDevelOps/vscode-docs/releases{/id}","deployments_url":"https://api.github.com/repos/DareDevelOps/vscode-docs/deployments","created_at":"2018-09-02T22:41:01Z","updated_at":"2018-09-02T22:41:09Z","pushed_at":"2018-09-08T17:53:06Z","git_url":"git://github.com/DareDevelOps/vscode-docs.git","ssh_url":"[email protected]:DareDevelOps/vscode-docs.git","clone_url":"https://github.com/DareDevelOps/vscode-docs.git","svn_url":"https://github.com/DareDevelOps/vscode-docs","homepage":"http://code.visualstudio.com/docs","size":1007030,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"54626023c94c95f11449b38bd05eb0f9a7283e87","user":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":41443539,"node_id":"MDEwOlJlcG9zaXRvcnk0MTQ0MzUzOQ==","name":"vscode-docs","full_name":"Microsoft/vscode-docs","owner":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/vscode-docs","description":"Public documentation for Visual Studio Code","fork":false,"url":"https://api.github.com/repos/Microsoft/vscode-docs","forks_url":"https://api.github.com/repos/Microsoft/vscode-docs/forks","keys_url":"https://api.github.com/repos/Microsoft/vscode-docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/vscode-docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/vscode-docs/teams","hooks_url":"https://api.github.com/repos/Microsoft/vscode-docs/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/vscode-docs/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/vscode-docs/events","assignees_url":"https://api.github.com/repos/Microsoft/vscode-docs/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/vscode-docs/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/vscode-docs/tags","blobs_url":"https://api.github.com/repos/Microsoft/vscode-docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/vscode-docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/vscode-docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/vscode-docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/vscode-docs/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/vscode-docs/languages","stargazers_url":"https://api.github.com/repos/Microsoft/vscode-docs/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/vscode-docs/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/vscode-docs/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/vscode-docs/subscription","commits_url":"https://api.github.com/repos/Microsoft/vscode-docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/vscode-docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/vscode-docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/vscode-docs/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/vscode-docs/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/vscode-docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/vscode-docs/merges","archive_url":"https://api.github.com/repos/Microsoft/vscode-docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/vscode-docs/downloads","issues_url":"https://api.github.com/repos/Microsoft/vscode-docs/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/vscode-docs/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/vscode-docs/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/vscode-docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/vscode-docs/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/vscode-docs/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/vscode-docs/deployments","created_at":"2015-08-26T18:45:33Z","updated_at":"2018-09-08T21:44:18Z","pushed_at":"2018-09-08T19:55:37Z","git_url":"git://github.com/Microsoft/vscode-docs.git","ssh_url":"[email protected]:Microsoft/vscode-docs.git","clone_url":"https://github.com/Microsoft/vscode-docs.git","svn_url":"https://github.com/Microsoft/vscode-docs","homepage":"http://code.visualstudio.com/docs","size":1044261,"stargazers_count":1508,"watchers_count":1508,"language":"CSS","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1225,"mirror_url":null,"archived":false,"open_issues_count":66,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1225,"open_issues":66,"watchers":1508,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/vscode-docs/pulls/1838"},"html":{"href":"https://github.com/Microsoft/vscode-docs/pull/1838"},"issue":{"href":"https://api.github.com/repos/Microsoft/vscode-docs/issues/1838"},"comments":{"href":"https://api.github.com/repos/Microsoft/vscode-docs/issues/1838/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/vscode-docs/pulls/1838/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/vscode-docs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/vscode-docs/pulls/1838/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/vscode-docs/statuses/5469876b90104d3675ffff6800906f7671ac2083"}},"author_association":"NONE"}} | {
"id": 41443539,
"name": "Microsoft/vscode-docs",
"url": "https://api.github.com/repos/Microsoft/vscode-docs"
} | {
"id": 24717094,
"login": "DareDevelOps",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/24717094?",
"url": "https://api.github.com/users/DareDevelOps"
} | {
"id": 6154722,
"login": "Microsoft",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6154722?",
"url": "https://api.github.com/orgs/Microsoft"
} | 2018-09-09T00:04:04 | 8235185886 | {"actor":{"display_login":"DareDevelOps"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/vscode-azuretools/pulls/comments/172667112","pull_request_review_id":101724594,"id":172667112,"diff_hunk":"@@ -529,32 +521,86 @@ export class SiteWrapper {\n }\n }\n \n- private async waitForDeploymentToComplete(kuduClient: KuduClient, outputChannel: vscode.OutputChannel, previousDeploymentId?: string, pollingInterval: number = 5000): Promise<DeployResult> {\n- // Unfortunately, Kudu doesn't provide a unique id for a deployment right after it's started\n- // However, Kudu only supports one deployment at a time, so 'latest' will work in most cases\n- let deploymentId: string = 'latest';\n- let deployment: DeployResult = await kuduClient.deployment.getResult(deploymentId);\n- while (!deployment.complete) {\n- if (!deployment.isTemp && deployment.id) {\n- // Switch from 'latest' to the permanent/unique id as soon as it's available\n- deploymentId = deployment.id;\n+ private async waitForDeploymentToComplete(kuduClient: KuduClient, outputChannel: vscode.OutputChannel, deploySendTime: Date, pollingInterval: number = 5000): Promise<void> {\n+ const alreadyDisplayedLogs: string[] = [];\n+ let nextTimeToDisplayWaitingLog: number = Date.now();\n+ let permanentId: string | undefined;\n+ let deployment: DeployResult | undefined;\n+\n+ // tslint:disable-next-line:no-constant-condition\n+ while (true) {\n+ if (permanentId) {\n+ deployment = await kuduClient.deployment.getResult(permanentId);\n+ } else {\n+ // Unfortunately, Kudu doesn't provide a unique/permanent id for a deployment right after it's started\n+ // Instead, search for the deployment that was received just after we started the deployment\n+ deployment = (await kuduClient.deployment.getDeployResults())\n+ .filter((deployResult: DeployResult) => deployResult.receivedTime && deployResult.receivedTime > deploySendTime)\n+ .sort((a: DeployResult, b: DeployResult) => b.receivedTime.valueOf() - a.receivedTime.valueOf())\n+ .shift();\n+ if (!deployment.isTemp) {\n+ // Once the deployment is permanent, we can use use that id rather than searching based on received time\n+ permanentId = deployment.id;\n+ }\n }\n \n- if (deployment.progress) {\n- this.log(outputChannel, deployment.progress);\n+ if (deployment === undefined || !deployment.id) {\n+ throw new Error(localize('failedToFindDeployment', 'Failed to get status of deployment.'));\n }\n \n- await new Promise((resolve: () => void): void => { setTimeout(resolve, pollingInterval); });\n- deployment = await kuduClient.deployment.getResult(deploymentId);\n- }\n- if (previousDeploymentId !== undefined && deployment.id === previousDeploymentId) {\n- throw new Error(localize('unsuccessfulDeployment', 'The deployment was unsuccessful. If this is a Local Git deployment, this could be a duplicate deployment.'));\n+ let logEntries: LogEntry[] = [];\n+ try {\n+ logEntries = <LogEntry[]>await kuduClient.deployment.getLogEntry(deployment.id);\n+ } catch (error) {\n+ // Swallow 404 errors for temp deployments\n+ // (it's expected that the temp logs don't exist once the deployment switches to permanent)\n+ // tslint:disable-next-line:no-unsafe-any\n+ if (!deployment.isTemp || !error || error.statusCode !== 404) {\n+ throw error;\n+ }\n+ }\n+\n+ const newLogEntries: LogEntry[] = logEntries.filter((newEntry: LogEntry) => !alreadyDisplayedLogs.some((oldId: string) => newEntry.id === oldId));\n+ if (newLogEntries.length === 0) {\n+ if (Date.now() > nextTimeToDisplayWaitingLog) {\n+ this.log(outputChannel, localize('waitingForComand', 'Waiting for long running command to finish...'));\n+ nextTimeToDisplayWaitingLog = Date.now() + 60 * 1000;\n+ }\n+ } else {\n+ for (const newEntry of newLogEntries) {\n+ if (newEntry.id) {\n+ alreadyDisplayedLogs.push(newEntry.id);\n+ if (newEntry.message) {\n+ this.log(outputChannel, newEntry.message, newEntry.logTime);\n+ }\n+\n+ if (newEntry.detailsUrl) {\n+ const entryDetails: LogEntry[] = await kuduClient.deployment.getLogEntryDetails(deployment.id, newEntry.id);\n+ for (const entryDetail of entryDetails) {\n+ if (entryDetail.message) {\n+ this.log(outputChannel, entryDetail.message, entryDetail.logTime);\n+ }\n+ }\n+ }\n+ }\n+ }\n+ }\n+\n+ if (deployment.complete) {\n+ if (deployment.isTemp) {","path":"appservice/src/SiteWrapper.ts","position":159,"original_position":159,"commit_id":"38ba582989fed01001305a8e747ec7943414410e","original_commit_id":"38ba582989fed01001305a8e747ec7943414410e","user":{"login":"StephenWeatherford","id":6913354,"avatar_url":"https://avatars0.githubusercontent.com/u/6913354?v=4","gravatar_id":"","url":"https://api.github.com/users/StephenWeatherford","html_url":"https://github.com/StephenWeatherford","followers_url":"https://api.github.com/users/StephenWeatherford/followers","following_url":"https://api.github.com/users/StephenWeatherford/following{/other_user}","gists_url":"https://api.github.com/users/StephenWeatherford/gists{/gist_id}","starred_url":"https://api.github.com/users/StephenWeatherford/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StephenWeatherford/subscriptions","organizations_url":"https://api.github.com/users/StephenWeatherford/orgs","repos_url":"https://api.github.com/users/StephenWeatherford/repos","events_url":"https://api.github.com/users/StephenWeatherford/events{/privacy}","received_events_url":"https://api.github.com/users/StephenWeatherford/received_events","type":"User","site_admin":false},"body":"complete means failure for temp deployments?","created_at":"2018-03-06T21:32:56Z","updated_at":"2018-03-06T21:32:56Z","html_url":"https://github.com/Microsoft/vscode-azuretools/pull/106#discussion_r172667112","pull_request_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/pulls/106","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/vscode-azuretools/pulls/comments/172667112"},"html":{"href":"https://github.com/Microsoft/vscode-azuretools/pull/106#discussion_r172667112"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/vscode-azuretools/pulls/106"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/vscode-azuretools/pulls/106","id":173025973,"html_url":"https://github.com/Microsoft/vscode-azuretools/pull/106","diff_url":"https://github.com/Microsoft/vscode-azuretools/pull/106.diff","patch_url":"https://github.com/Microsoft/vscode-azuretools/pull/106.patch","issue_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/issues/106","number":106,"state":"open","locked":false,"title":" Show detailed deployment logs","user":{"login":"EricJizbaMSFT","id":11282622,"avatar_url":"https://avatars2.githubusercontent.com/u/11282622?v=4","gravatar_id":"","url":"https://api.github.com/users/EricJizbaMSFT","html_url":"https://github.com/EricJizbaMSFT","followers_url":"https://api.github.com/users/EricJizbaMSFT/followers","following_url":"https://api.github.com/users/EricJizbaMSFT/following{/other_user}","gists_url":"https://api.github.com/users/EricJizbaMSFT/gists{/gist_id}","starred_url":"https://api.github.com/users/EricJizbaMSFT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EricJizbaMSFT/subscriptions","organizations_url":"https://api.github.com/users/EricJizbaMSFT/orgs","repos_url":"https://api.github.com/users/EricJizbaMSFT/repos","events_url":"https://api.github.com/users/EricJizbaMSFT/events{/privacy}","received_events_url":"https://api.github.com/users/EricJizbaMSFT/received_events","type":"User","site_admin":false},"body":"Dependent on this kudu PR: https://github.com/Microsoft/vscode-azuretools/pull/105\r\n\r\nIn addition to more detailed logs, I refactored the 'previousDeploymentId' logic for two reasons:\r\n1. After testing for a bit, I noticed that sometimes I would have to wait several seconds before the \"Are you sure you want to deploy...\" message popped up. I narrowed the delay down to fetching the 'previousDeploymentId' and I'm guessing its because it has to spin up the de-allocated resources if you haven't accessed your site in a while\r\n1. Using a time-based approach should be more widely-applicable than checking the id, which has several special cases (i.e. if you've never deployed before and one if you are deploying using git)\r\n\r\nHere are the \"before\" and \"after\" versions of the logs in several cases:\r\n\r\n# Successful App Service deploy Before\r\n```\r\n4:02:08 PM emj305: Creating zip package...\r\n4:02:28 PM emj305: Starting deployment...\r\n4:02:38 PM emj305: Fetching changes.\r\n4:02:46 PM emj305: Fetching changes.\r\n4:02:53 PM emj305: Fetching changes.\r\n4:03:01 PM emj305: Fetching changes.\r\n4:03:07 PM emj305: Fetching changes.\r\n4:03:15 PM emj305: Fetching changes.\r\n4:03:22 PM emj305: Fetching changes.\r\n4:03:29 PM emj305: Fetching changes.\r\n4:03:36 PM emj305: Fetching changes.\r\n4:03:44 PM emj305: Fetching changes.\r\n4:03:50 PM emj305: Fetching changes.\r\n4:03:58 PM emj305: Fetching changes.\r\n4:04:05 PM emj305: Fetching changes.\r\n4:04:11 PM emj305: Running deployment command...\r\n4:04:17 PM emj305: Running deployment command...\r\n4:04:23 PM emj305: Running deployment command...\r\n>>>>>> Deployment to \"emj305\" completed. <<<<<<\r\n```\r\n\r\n# Successful App Service deploy After\r\n```\r\n3:49:04 PM emj305: Creating zip package...\r\n3:49:28 PM emj305: Starting deployment...\r\n3:50:08 PM emj305: Fetching changes.\r\n3:50:08 PM emj305: Cleaning up temp folders from previous zip deployments and extracting pushed zip file /tmp/zipdeploy/361jmswv.zip (30.84 MB) to /tmp/zipdeploy/extracted\r\n3:50:20 PM emj305: Waiting for long running command to finish...\r\n3:51:26 PM emj305: Waiting for long running command to finish...\r\n3:51:39 PM emj305: Updating submodules.\r\n3:51:40 PM emj305: Preparing deployment for commit id 'be833a6b8c'.\r\n3:51:40 PM emj305: Generating deployment script.\r\n3:51:40 PM emj305: Using cached version of deployment script (command: 'azure -y --no-dot-deployment -r \"/tmp/zipdeploy/extracted\" -o \"/home/site/deployments/tools\" --basic --sitePath \"/tmp/zipdeploy/extracted\"').\r\n3:51:40 PM emj305: Running deployment command...\r\n3:51:40 PM emj305: Command: \"/home/site/deployments/tools/deploy.sh\"\r\n3:51:43 PM emj305: Handling Basic Web Site deployment.\r\n3:51:44 PM emj305: Kudu sync from: '/tmp/zipdeploy/extracted' to: '/home/site/wwwroot'\r\n3:51:44 PM emj305: Copying file: '.DS_Store'\r\n3:51:44 PM emj305: Ignoring: .git\r\n3:51:44 PM emj305: Copying file: 'test/mods/vscode-azureappservice'\r\n3:51:44 PM emj305: Copying file: 'test/mods/.bin/_mocha'\r\n3:51:44 PM emj305: Copying file: 'test/mods/.bin/color-support'\r\n3:51:44 PM emj305: Copying file: 'test/mods/.bin/esparse'\r\n3:51:44 PM emj305: Copying file: 'test/mods/.bin/esvalidate'\r\n3:51:44 PM emj305: Copying file: 'test/mods/.bin/he'\r\n3:51:44 PM emj305: Copying file: 'test/mods/.bin/jade'\r\n3:51:44 PM emj305: Copying file: 'test/mods/.bin/js-yaml'\r\n3:51:44 PM emj305: Copying file: 'test/mods/.bin/mkdirp'\r\n3:51:44 PM emj305: Copying file: 'test/mods/.bin/mocha'\r\n3:51:44 PM emj305: Copying file: 'test/mods/.bin/rimraf'\r\n3:51:44 PM emj305: Copying file: 'test/mods/.bin/semver'\r\n3:51:44 PM emj305: Copying file: 'test/mods/.bin/sshpk-conv'\r\n3:51:44 PM emj305: Copying file: 'test/mods/.bin/sshpk-sign'\r\n3:51:44 PM emj305: Copying file: 'test/mods/.bin/sshpk-verify'\r\n3:51:44 PM emj305: Copying file: 'test/mods/.bin/supports-color'\r\n3:51:44 PM emj305: Copying file: 'test/mods/.bin/tsc'\r\n3:51:44 PM emj305: Copying file: 'test/mods/.bin/tslint'\r\n3:51:44 PM emj305: Copying file: 'test/mods/.bin/tsserver'\r\n3:51:44 PM emj305: Copying file: 'test/mods/.bin/uuid'\r\n3:51:44 PM emj305: Copying file: 'test/mods/.bin/vscode-install'\r\n3:51:44 PM emj305: Copying file: 'test/mods/@types/bluebird/LICENSE'\r\n3:51:45 PM emj305: Copying file: 'test/mods/@types/bluebird/README.md'\r\n3:51:45 PM emj305: Copying file: 'test/mods/@types/bluebird/index.d.ts'\r\n3:51:45 PM emj305: Copying file: 'test/mods/@types/bluebird/package.json'\r\n3:51:45 PM emj305: Copying file: 'test/mods/@types/caseless/LICENSE'\r\n3:51:45 PM emj305: Copying file: 'test/mods/@types/caseless/README.md'\r\n3:51:45 PM emj305: Copying file: 'test/mods/@types/caseless/index.d.ts'\r\n3:51:45 PM emj305: Copying file: 'test/mods/@types/caseless/package.json'\r\n3:51:45 PM emj305: Copying file: 'test/mods/@types/form-data/LICENSE'\r\n3:51:45 PM emj305: Copying file: 'test/mods/@types/form-data/README.md'\r\n3:51:45 PM emj305: Copying file: 'test/mods/@types/form-data/index.d.ts'\r\n3:51:45 PM emj305: Copying file: 'test/mods/@types/form-data/package.json'\r\n3:51:45 PM emj305: Copying file: 'test/mods/@types/fs-extra/LICENSE'\r\n3:51:45 PM emj305: Copying file: 'test/mods/@types/fs-extra/README.md'\r\n3:51:45 PM emj305: Copying file: 'test/mods/@types/fs-extra/index.d.ts'\r\n3:51:45 PM emj305: Copying file: 'test/mods/@types/fs-extra/package.json'\r\n3:51:45 PM emj305: Copying file: 'test/mods/@types/mocha/LICENSE'\r\n3:51:45 PM emj305: Copying file: 'test/mods/@types/mocha/README.md'\r\n3:51:45 PM emj305: Copying file: 'test/mods/@types/mocha/index.d.ts'\r\n3:51:45 PM emj305: Copying file: 'test/mods/@types/mocha/package.json'\r\n3:51:45 PM emj305: Copying file: 'test/mods/@types/node/LICENSE'\r\n3:51:45 PM emj305: Copying file: 'test/mods/@types/node/README.md'\r\n3:51:45 PM emj305: Copying file: 'test/mods/@types/node/index.d.ts'\r\n3:51:45 PM emj305: Copying file: 'test/mods/@types/node/inspector.d.ts'\r\n3:51:45 PM emj305: Copying file: 'test/mods/@types/node/package.json'\r\n3:51:45 PM emj305: Copying file: 'test/mods/@types/request/LICENSE'\r\n3:51:45 PM emj305: Omitting next output lines...\r\n3:52:27 PM emj305: Waiting for long running command to finish...\r\n3:53:23 PM emj305: Running post deployment command(s)...\r\n3:53:24 PM emj305: Deployment successful.\r\n3:53:24 PM emj305: App container will begin restart within 10 seconds.\r\n>>>>>> Deployment to \"emj305\" completed. <<<<<<\r\n```\r\n\r\n# Successful Functions deploy Before\r\n```\r\n4:00:54 PM emj299: Creating zip package...\r\n4:00:54 PM emj299: Starting deployment...\r\n4:00:58 PM emj299: Running deployment command...\r\n>>>>>> Deployment to \"emj299\" completed. <<<<<<\r\n```\r\n\r\n# Successful Functions deploy After\r\n```\r\n3:56:39 PM emj299: Creating zip package...\r\n3:56:39 PM emj299: Starting deployment...\r\n3:56:41 PM emj299: Updating submodules.\r\n3:56:42 PM emj299: Preparing deployment for commit id '8a4ff6d794'.\r\n3:56:42 PM emj299: Generating deployment script.\r\n3:56:43 PM emj299: Using cached version of deployment script (command: 'azure -y --no-dot-deployment -r \"D:\\local\\Temp\\zipdeploy\\extracted\" -o \"D:\\home\\site\\deployments\\tools\" --basic --sitePath \"D:\\local\\Temp\\zipdeploy\\extracted\"').\r\n3:56:43 PM emj299: Running deployment command...\r\n3:56:43 PM emj299: Command: \"D:\\home\\site\\deployments\\tools\\deploy.cmd\"\r\n3:56:44 PM emj299: Handling Basic Web Site deployment.\r\n3:56:44 PM emj299: KuduSync.NET from: 'D:\\local\\Temp\\zipdeploy\\extracted' to: 'D:\\home\\site\\wwwroot'\r\n3:56:44 PM emj299: Finished successfully.\r\n3:56:45 PM emj299: Running post deployment command(s)...\r\n3:56:46 PM emj299: Syncing 1 function triggers with payload size 108 bytes successful.\r\n3:56:46 PM emj299: Deployment successful.\r\n>>>>>> Deployment to \"emj299\" completed. <<<<<<\r\n```\r\n\r\n# Failed Functions deploy Before\r\n```\r\n4:00:00 PM emj299: Creating zip package...\r\n4:00:00 PM emj299: Starting deployment...\r\n>>>>>> Deployment to \"emj299\" completed. <<<<<<\r\n```\r\n\r\n# Failed Functions deploy After\r\n```\r\n3:58:18 PM emj299: Creating zip package...\r\n3:58:18 PM emj299: Starting deployment...\r\n3:58:19 PM emj299: Fetching changes.\r\n3:58:19 PM emj299: Cleaning up temp folders from previous zip deployments and extracting pushed zip file D:\\local\\Temp\\zipdeploy\\trhdachw.zip (0.00 MB) to D:\\local\\Temp\\zipdeploy\\extracted\r\n3:58:19 PM emj299: Central Directory corrupt.\r\nError: Deployment to \"emj299\" failed. See output channel for more details.\r\n```","created_at":"2018-03-06T00:27:00Z","updated_at":"2018-03-06T21:32:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"051b79ac476b45119d4532a796ebfc67a2857b95","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/pulls/106/commits","review_comments_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/pulls/106/comments","review_comment_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/issues/106/comments","statuses_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/statuses/38ba582989fed01001305a8e747ec7943414410e","head":{"label":"Microsoft:ej/log","ref":"ej/log","sha":"38ba582989fed01001305a8e747ec7943414410e","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":106758861,"name":"vscode-azuretools","full_name":"Microsoft/vscode-azuretools","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/vscode-azuretools","description":"Common packages for building Azure extensions for VS Code","fork":false,"url":"https://api.github.com/repos/Microsoft/vscode-azuretools","forks_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/forks","keys_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/teams","hooks_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/events","assignees_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/tags","blobs_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/languages","stargazers_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/subscription","commits_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/merges","archive_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/downloads","issues_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/deployments","created_at":"2017-10-13T00:27:20Z","updated_at":"2018-02-20T08:12:48Z","pushed_at":"2018-03-06T19:49:29Z","git_url":"git://github.com/Microsoft/vscode-azuretools.git","ssh_url":"[email protected]:Microsoft/vscode-azuretools.git","clone_url":"https://github.com/Microsoft/vscode-azuretools.git","svn_url":"https://github.com/Microsoft/vscode-azuretools","homepage":null,"size":291,"stargazers_count":7,"watchers_count":7,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":18,"license":null,"forks":4,"open_issues":18,"watchers":7,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"f4ee08acd0f1c4627da24acd5340a833d6243aa6","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":106758861,"name":"vscode-azuretools","full_name":"Microsoft/vscode-azuretools","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/vscode-azuretools","description":"Common packages for building Azure extensions for VS Code","fork":false,"url":"https://api.github.com/repos/Microsoft/vscode-azuretools","forks_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/forks","keys_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/teams","hooks_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/events","assignees_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/tags","blobs_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/languages","stargazers_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/subscription","commits_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/merges","archive_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/downloads","issues_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/deployments","created_at":"2017-10-13T00:27:20Z","updated_at":"2018-02-20T08:12:48Z","pushed_at":"2018-03-06T19:49:29Z","git_url":"git://github.com/Microsoft/vscode-azuretools.git","ssh_url":"[email protected]:Microsoft/vscode-azuretools.git","clone_url":"https://github.com/Microsoft/vscode-azuretools.git","svn_url":"https://github.com/Microsoft/vscode-azuretools","homepage":null,"size":291,"stargazers_count":7,"watchers_count":7,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":18,"license":null,"forks":4,"open_issues":18,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/vscode-azuretools/pulls/106"},"html":{"href":"https://github.com/Microsoft/vscode-azuretools/pull/106"},"issue":{"href":"https://api.github.com/repos/Microsoft/vscode-azuretools/issues/106"},"comments":{"href":"https://api.github.com/repos/Microsoft/vscode-azuretools/issues/106/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/vscode-azuretools/pulls/106/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/vscode-azuretools/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/vscode-azuretools/pulls/106/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/vscode-azuretools/statuses/38ba582989fed01001305a8e747ec7943414410e"}},"author_association":"MEMBER"}} | {
"id": 106758861,
"name": "Microsoft/vscode-azuretools",
"url": "https://api.github.com/repos/Microsoft/vscode-azuretools"
} | {
"id": 6913354,
"login": "StephenWeatherford",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6913354?",
"url": "https://api.github.com/users/StephenWeatherford"
} | {
"id": 6154722,
"login": "Microsoft",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6154722?",
"url": "https://api.github.com/orgs/Microsoft"
} | 2018-03-06T21:32:56 | 7340427119 | {"actor":{"display_login":"StephenWeatherford"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/VFSForGit/pulls/comments/239244860","pull_request_review_id":181982842,"id":239244860,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzOTI0NDg2MA==","diff_hunk":"@@ -10,41 +10,115 @@\n static const char* KextLogLevelAsString(KextLog_Level level);\n static uint64_t NanosecondsFromAbsoluteTime(uint64_t machAbsoluteTime);\n static dispatch_source_t StartKextProfilingDataPolling(io_connect_t connection);\n+static void ProcessLogMessagesOnConnection(io_connect_t connection, io_service_t prjfsService);\n \n static mach_timebase_info_data_t s_machTimebase;\n-\n+static uint64_t s_machStartTime;\n+static IONotificationPortRef s_notificationPort;\n \n int main(int argc, const char * argv[])\n {\n mach_timebase_info(&s_machTimebase);\n- const uint64_t machStartTime = mach_absolute_time();\n+ s_machStartTime = mach_absolute_time();\n+\n+\n+ s_notificationPort = IONotificationPortCreate(kIOMasterPortDefault);\n+ IONotificationPortSetDispatchQueue(s_notificationPort, dispatch_get_main_queue());\n \n- io_connect_t connection = PrjFSService_ConnectToDriver(UserClientType_Log);\n- if (connection == IO_OBJECT_NULL)\n+ PrjFSService_WatchContext* watchContext = PrjFSService_WatchForServiceAndConnect(\n+ s_notificationPort, UserClientType_Log,\n+ [](io_service_t service, io_connect_t connection, PrjFSService_WatchContext* context)\n+ {\n+ if (connection != IO_OBJECT_NULL)\n+ {\n+ ProcessLogMessagesOnConnection(connection, service);\n+ }\n+ });\n+ if (nullptr == watchContext)\n {\n- std::cerr << \"Failed to connect to kernel service.\\n\";\n+ std::cerr << \"Failed to register for IOService notifications.\\n\";\n return 1;\n }\n \n- DataQueueResources dataQueue = {};\n- if (!PrjFSService_DataQueueInit(&dataQueue, connection, LogPortType_MessageQueue, LogMemoryType_MessageQueue, dispatch_get_main_queue()))\n+\n+ CFRunLoopRun();","path":"ProjFS.Mac/PrjFSLib/prjfs-log/prjfs-log.cpp","position":42,"original_position":42,"commit_id":"9ce16a2f0c4afd1d264448bf8ed84dfc9b857165","original_commit_id":"9ce16a2f0c4afd1d264448bf8ed84dfc9b857165","user":{"login":"pmj","id":42341,"node_id":"MDQ6VXNlcjQyMzQx","avatar_url":"https://avatars0.githubusercontent.com/u/42341?v=4","gravatar_id":"","url":"https://api.github.com/users/pmj","html_url":"https://github.com/pmj","followers_url":"https://api.github.com/users/pmj/followers","following_url":"https://api.github.com/users/pmj/following{/other_user}","gists_url":"https://api.github.com/users/pmj/gists{/gist_id}","starred_url":"https://api.github.com/users/pmj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmj/subscriptions","organizations_url":"https://api.github.com/users/pmj/orgs","repos_url":"https://api.github.com/users/pmj/repos","events_url":"https://api.github.com/users/pmj/events{/privacy}","received_events_url":"https://api.github.com/users/pmj/received_events","type":"User","site_admin":false},"body":"> Will `PrjFSService_StopWatching` (the call after `CFRunLoopRun`) get hit? (e.g. if the logger gets a `SIGTERM`)\r\n\r\nThe default SIGTERM handler doesn't call `CFRunLoopStop()`, no. Since all resources we currently use are of the kind that clean themselves up when the process dies, this isn't a problem, but if that changes, we'll want that `PrjFSService_StopWatching()` there, and having it there now is a good reminder.","created_at":"2018-12-05T21:30:47Z","updated_at":"2018-12-05T21:30:48Z","html_url":"https://github.com/Microsoft/VFSForGit/pull/566#discussion_r239244860","pull_request_url":"https://api.github.com/repos/Microsoft/VFSForGit/pulls/566","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/VFSForGit/pulls/comments/239244860"},"html":{"href":"https://github.com/Microsoft/VFSForGit/pull/566#discussion_r239244860"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/VFSForGit/pulls/566"}},"in_reply_to_id":239175557},"pull_request":{"url":"https://api.github.com/repos/Microsoft/VFSForGit/pulls/566","id":235040358,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM1MDQwMzU4","html_url":"https://github.com/Microsoft/VFSForGit/pull/566","diff_url":"https://github.com/Microsoft/VFSForGit/pull/566.diff","patch_url":"https://github.com/Microsoft/VFSForGit/pull/566.patch","issue_url":"https://api.github.com/repos/Microsoft/VFSForGit/issues/566","number":566,"state":"open","locked":false,"title":"Mac: Prjfs log reconnect","user":{"login":"pmj","id":42341,"node_id":"MDQ6VXNlcjQyMzQx","avatar_url":"https://avatars0.githubusercontent.com/u/42341?v=4","gravatar_id":"","url":"https://api.github.com/users/pmj","html_url":"https://github.com/pmj","followers_url":"https://api.github.com/users/pmj/followers","following_url":"https://api.github.com/users/pmj/following{/other_user}","gists_url":"https://api.github.com/users/pmj/gists{/gist_id}","starred_url":"https://api.github.com/users/pmj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmj/subscriptions","organizations_url":"https://api.github.com/users/pmj/orgs","repos_url":"https://api.github.com/users/pmj/repos","events_url":"https://api.github.com/users/pmj/events{/privacy}","received_events_url":"https://api.github.com/users/pmj/received_events","type":"User","site_admin":false},"body":"This implements #564. \r\n\r\nInstead of searching for the PrjFS IOKit service once on startup, `prjfs-log` now registers for matching notifications. This means that if there is no PrjFS service running (the kext isn't loaded), it will sit and wait for it to turn up. Likewise, if the kext is unloaded, the logging infrastructure for that instance is cleanly torn down. The notification system continues to look out for new instances of the service, so when the kext is reloaded, logging immediately resumes.\r\n\r\nI've also added new log entries for when prjfs starts and stops logging for a particular kext service instance.\r\n\r\nFinally, I've added `fflush(stdout)` calls to avoid dropping buffered messages when prjfs-log output is redirected to a file.","created_at":"2018-11-30T16:18:08Z","updated_at":"2018-12-05T21:30:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e435010bd540a10ad8d5a54e5bf542c7b4603738","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/VFSForGit/pulls/566/commits","review_comments_url":"https://api.github.com/repos/Microsoft/VFSForGit/pulls/566/comments","review_comment_url":"https://api.github.com/repos/Microsoft/VFSForGit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/VFSForGit/issues/566/comments","statuses_url":"https://api.github.com/repos/Microsoft/VFSForGit/statuses/9ce16a2f0c4afd1d264448bf8ed84dfc9b857165","head":{"label":"pmj:prjfs-log-reconnect","ref":"prjfs-log-reconnect","sha":"9ce16a2f0c4afd1d264448bf8ed84dfc9b857165","user":{"login":"pmj","id":42341,"node_id":"MDQ6VXNlcjQyMzQx","avatar_url":"https://avatars0.githubusercontent.com/u/42341?v=4","gravatar_id":"","url":"https://api.github.com/users/pmj","html_url":"https://github.com/pmj","followers_url":"https://api.github.com/users/pmj/followers","following_url":"https://api.github.com/users/pmj/following{/other_user}","gists_url":"https://api.github.com/users/pmj/gists{/gist_id}","starred_url":"https://api.github.com/users/pmj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmj/subscriptions","organizations_url":"https://api.github.com/users/pmj/orgs","repos_url":"https://api.github.com/users/pmj/repos","events_url":"https://api.github.com/users/pmj/events{/privacy}","received_events_url":"https://api.github.com/users/pmj/received_events","type":"User","site_admin":false},"repo":{"id":144459282,"node_id":"MDEwOlJlcG9zaXRvcnkxNDQ0NTkyODI=","name":"VFSForGit","full_name":"pmj/VFSForGit","private":false,"owner":{"login":"pmj","id":42341,"node_id":"MDQ6VXNlcjQyMzQx","avatar_url":"https://avatars0.githubusercontent.com/u/42341?v=4","gravatar_id":"","url":"https://api.github.com/users/pmj","html_url":"https://github.com/pmj","followers_url":"https://api.github.com/users/pmj/followers","following_url":"https://api.github.com/users/pmj/following{/other_user}","gists_url":"https://api.github.com/users/pmj/gists{/gist_id}","starred_url":"https://api.github.com/users/pmj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmj/subscriptions","organizations_url":"https://api.github.com/users/pmj/orgs","repos_url":"https://api.github.com/users/pmj/repos","events_url":"https://api.github.com/users/pmj/events{/privacy}","received_events_url":"https://api.github.com/users/pmj/received_events","type":"User","site_admin":false},"html_url":"https://github.com/pmj/VFSForGit","description":"Virtual File System for Git: Enable Git at Enterprise Scale","fork":true,"url":"https://api.github.com/repos/pmj/VFSForGit","forks_url":"https://api.github.com/repos/pmj/VFSForGit/forks","keys_url":"https://api.github.com/repos/pmj/VFSForGit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pmj/VFSForGit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pmj/VFSForGit/teams","hooks_url":"https://api.github.com/repos/pmj/VFSForGit/hooks","issue_events_url":"https://api.github.com/repos/pmj/VFSForGit/issues/events{/number}","events_url":"https://api.github.com/repos/pmj/VFSForGit/events","assignees_url":"https://api.github.com/repos/pmj/VFSForGit/assignees{/user}","branches_url":"https://api.github.com/repos/pmj/VFSForGit/branches{/branch}","tags_url":"https://api.github.com/repos/pmj/VFSForGit/tags","blobs_url":"https://api.github.com/repos/pmj/VFSForGit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pmj/VFSForGit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pmj/VFSForGit/git/refs{/sha}","trees_url":"https://api.github.com/repos/pmj/VFSForGit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pmj/VFSForGit/statuses/{sha}","languages_url":"https://api.github.com/repos/pmj/VFSForGit/languages","stargazers_url":"https://api.github.com/repos/pmj/VFSForGit/stargazers","contributors_url":"https://api.github.com/repos/pmj/VFSForGit/contributors","subscribers_url":"https://api.github.com/repos/pmj/VFSForGit/subscribers","subscription_url":"https://api.github.com/repos/pmj/VFSForGit/subscription","commits_url":"https://api.github.com/repos/pmj/VFSForGit/commits{/sha}","git_commits_url":"https://api.github.com/repos/pmj/VFSForGit/git/commits{/sha}","comments_url":"https://api.github.com/repos/pmj/VFSForGit/comments{/number}","issue_comment_url":"https://api.github.com/repos/pmj/VFSForGit/issues/comments{/number}","contents_url":"https://api.github.com/repos/pmj/VFSForGit/contents/{+path}","compare_url":"https://api.github.com/repos/pmj/VFSForGit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pmj/VFSForGit/merges","archive_url":"https://api.github.com/repos/pmj/VFSForGit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pmj/VFSForGit/downloads","issues_url":"https://api.github.com/repos/pmj/VFSForGit/issues{/number}","pulls_url":"https://api.github.com/repos/pmj/VFSForGit/pulls{/number}","milestones_url":"https://api.github.com/repos/pmj/VFSForGit/milestones{/number}","notifications_url":"https://api.github.com/repos/pmj/VFSForGit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pmj/VFSForGit/labels{/name}","releases_url":"https://api.github.com/repos/pmj/VFSForGit/releases{/id}","deployments_url":"https://api.github.com/repos/pmj/VFSForGit/deployments","created_at":"2018-08-12T10:59:08Z","updated_at":"2018-12-05T13:22:11Z","pushed_at":"2018-12-05T17:41:30Z","git_url":"git://github.com/pmj/VFSForGit.git","ssh_url":"[email protected]:pmj/VFSForGit.git","clone_url":"https://github.com/pmj/VFSForGit.git","svn_url":"https://github.com/pmj/VFSForGit","homepage":"https://gvfs.io/","size":3709,"stargazers_count":1,"watchers_count":1,"language":"C#","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"8ccd498828e9781aba52f0b7a5fd493e9dacda82","user":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":80058269,"node_id":"MDEwOlJlcG9zaXRvcnk4MDA1ODI2OQ==","name":"VFSForGit","full_name":"Microsoft/VFSForGit","private":false,"owner":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Microsoft/VFSForGit","description":"Virtual File System for Git: Enable Git at Enterprise Scale","fork":false,"url":"https://api.github.com/repos/Microsoft/VFSForGit","forks_url":"https://api.github.com/repos/Microsoft/VFSForGit/forks","keys_url":"https://api.github.com/repos/Microsoft/VFSForGit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/VFSForGit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/VFSForGit/teams","hooks_url":"https://api.github.com/repos/Microsoft/VFSForGit/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/VFSForGit/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/VFSForGit/events","assignees_url":"https://api.github.com/repos/Microsoft/VFSForGit/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/VFSForGit/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/VFSForGit/tags","blobs_url":"https://api.github.com/repos/Microsoft/VFSForGit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/VFSForGit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/VFSForGit/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/VFSForGit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/VFSForGit/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/VFSForGit/languages","stargazers_url":"https://api.github.com/repos/Microsoft/VFSForGit/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/VFSForGit/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/VFSForGit/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/VFSForGit/subscription","commits_url":"https://api.github.com/repos/Microsoft/VFSForGit/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/VFSForGit/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/VFSForGit/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/VFSForGit/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/VFSForGit/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/VFSForGit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/VFSForGit/merges","archive_url":"https://api.github.com/repos/Microsoft/VFSForGit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/VFSForGit/downloads","issues_url":"https://api.github.com/repos/Microsoft/VFSForGit/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/VFSForGit/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/VFSForGit/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/VFSForGit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/VFSForGit/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/VFSForGit/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/VFSForGit/deployments","created_at":"2017-01-25T21:10:29Z","updated_at":"2018-12-05T17:41:21Z","pushed_at":"2018-12-05T21:24:44Z","git_url":"git://github.com/Microsoft/VFSForGit.git","ssh_url":"[email protected]:Microsoft/VFSForGit.git","clone_url":"https://github.com/Microsoft/VFSForGit.git","svn_url":"https://github.com/Microsoft/VFSForGit","homepage":"https://vfsforgit.org/","size":3670,"stargazers_count":4415,"watchers_count":4415,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":298,"mirror_url":null,"archived":false,"open_issues_count":155,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":298,"open_issues":155,"watchers":4415,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/VFSForGit/pulls/566"},"html":{"href":"https://github.com/Microsoft/VFSForGit/pull/566"},"issue":{"href":"https://api.github.com/repos/Microsoft/VFSForGit/issues/566"},"comments":{"href":"https://api.github.com/repos/Microsoft/VFSForGit/issues/566/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/VFSForGit/pulls/566/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/VFSForGit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/VFSForGit/pulls/566/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/VFSForGit/statuses/9ce16a2f0c4afd1d264448bf8ed84dfc9b857165"}},"author_association":"CONTRIBUTOR"}} | {
"id": 80058269,
"name": "Microsoft/VFSForGit",
"url": "https://api.github.com/repos/Microsoft/VFSForGit"
} | {
"id": 42341,
"login": "pmj",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/42341?",
"url": "https://api.github.com/users/pmj"
} | {
"id": 6154722,
"login": "Microsoft",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6154722?",
"url": "https://api.github.com/orgs/Microsoft"
} | 2018-12-05T21:30:47 | 8705148195 | {"actor":{"display_login":"pmj"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/vsts-tasks/pulls/comments/167028720","pull_request_review_id":95186164,"id":167028720,"diff_hunk":"@@ -0,0 +1,27 @@\n+# Ant\n+# Build your Java projects and run tests with Apache Ant.\n+# https://aka.ms/yaml\n+\n+queue: 'Hosted VS2017'\n+\n+#variables:\n+# system.debug: 'true'\n+\n+steps:\n+- task: Ant@1\n+ displayName: 'Build with Ant'\n+ inputs:\n+ buildFile: 'build.xml'\n+\n+- task: CopyFiles@2\n+ displayName: 'Copy artifacts'\n+ inputs:\n+ contents: '**/*.jar'\n+ targetFolder: '$(build.artifactStagingDirectory)'\n+\n+- task: PublishBuildArtifacts@1","path":"templates/ci/ant.yml","position":22,"original_position":22,"commit_id":"a92992f921e42ff2db4c910dd0e3387886d18588","original_commit_id":"a92992f921e42ff2db4c910dd0e3387886d18588","user":{"login":"ericsciple","id":12102068,"avatar_url":"https://avatars1.githubusercontent.com/u/12102068?v=4","gravatar_id":"","url":"https://api.github.com/users/ericsciple","html_url":"https://github.com/ericsciple","followers_url":"https://api.github.com/users/ericsciple/followers","following_url":"https://api.github.com/users/ericsciple/following{/other_user}","gists_url":"https://api.github.com/users/ericsciple/gists{/gist_id}","starred_url":"https://api.github.com/users/ericsciple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericsciple/subscriptions","organizations_url":"https://api.github.com/users/ericsciple/orgs","repos_url":"https://api.github.com/users/ericsciple/repos","events_url":"https://api.github.com/users/ericsciple/events{/privacy}","received_events_url":"https://api.github.com/users/ericsciple/received_events","type":"User","site_admin":false},"body":"definitely, i'll keep this in mind. we're working with RM to define the syntax for modeling releases and artifacts. I think we'll use something like `download`, so maybe the reverse `upload` would make sense. or maybe `publish` would just be more intuitive...","created_at":"2018-02-08T18:38:32Z","updated_at":"2018-02-08T18:38:32Z","html_url":"https://github.com/Microsoft/vsts-tasks/pull/6385#discussion_r167028720","pull_request_url":"https://api.github.com/repos/Microsoft/vsts-tasks/pulls/6385","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/vsts-tasks/pulls/comments/167028720"},"html":{"href":"https://github.com/Microsoft/vsts-tasks/pull/6385#discussion_r167028720"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/vsts-tasks/pulls/6385"}},"in_reply_to_id":167026060},"pull_request":{"url":"https://api.github.com/repos/Microsoft/vsts-tasks/pulls/6385","id":168042489,"html_url":"https://github.com/Microsoft/vsts-tasks/pull/6385","diff_url":"https://github.com/Microsoft/vsts-tasks/pull/6385.diff","patch_url":"https://github.com/Microsoft/vsts-tasks/pull/6385.patch","issue_url":"https://api.github.com/repos/Microsoft/vsts-tasks/issues/6385","number":6385,"state":"open","locked":false,"title":"Initial YAML templates for CI","user":{"login":"DavidStaheli","id":1767415,"avatar_url":"https://avatars3.githubusercontent.com/u/1767415?v=4","gravatar_id":"","url":"https://api.github.com/users/DavidStaheli","html_url":"https://github.com/DavidStaheli","followers_url":"https://api.github.com/users/DavidStaheli/followers","following_url":"https://api.github.com/users/DavidStaheli/following{/other_user}","gists_url":"https://api.github.com/users/DavidStaheli/gists{/gist_id}","starred_url":"https://api.github.com/users/DavidStaheli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DavidStaheli/subscriptions","organizations_url":"https://api.github.com/users/DavidStaheli/orgs","repos_url":"https://api.github.com/users/DavidStaheli/repos","events_url":"https://api.github.com/users/DavidStaheli/events{/privacy}","received_events_url":"https://api.github.com/users/DavidStaheli/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-02-08T17:48:32Z","updated_at":"2018-02-08T18:38:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"208867c09b29feeccf8ab4c6a4640581e85733f6","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/vsts-tasks/pulls/6385/commits","review_comments_url":"https://api.github.com/repos/Microsoft/vsts-tasks/pulls/6385/comments","review_comment_url":"https://api.github.com/repos/Microsoft/vsts-tasks/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/vsts-tasks/issues/6385/comments","statuses_url":"https://api.github.com/repos/Microsoft/vsts-tasks/statuses/a92992f921e42ff2db4c910dd0e3387886d18588","head":{"label":"Microsoft:users/davidstaheli/yaml","ref":"users/davidstaheli/yaml","sha":"a92992f921e42ff2db4c910dd0e3387886d18588","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":27631673,"name":"vsts-tasks","full_name":"Microsoft/vsts-tasks","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/vsts-tasks","description":"Build and Release Tasks for Visual Studio Team Services and Team Foundation Server","fork":false,"url":"https://api.github.com/repos/Microsoft/vsts-tasks","forks_url":"https://api.github.com/repos/Microsoft/vsts-tasks/forks","keys_url":"https://api.github.com/repos/Microsoft/vsts-tasks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/vsts-tasks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/vsts-tasks/teams","hooks_url":"https://api.github.com/repos/Microsoft/vsts-tasks/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/vsts-tasks/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/vsts-tasks/events","assignees_url":"https://api.github.com/repos/Microsoft/vsts-tasks/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/vsts-tasks/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/vsts-tasks/tags","blobs_url":"https://api.github.com/repos/Microsoft/vsts-tasks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/vsts-tasks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/vsts-tasks/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/vsts-tasks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/vsts-tasks/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/vsts-tasks/languages","stargazers_url":"https://api.github.com/repos/Microsoft/vsts-tasks/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/vsts-tasks/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/vsts-tasks/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/vsts-tasks/subscription","commits_url":"https://api.github.com/repos/Microsoft/vsts-tasks/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/vsts-tasks/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/vsts-tasks/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/vsts-tasks/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/vsts-tasks/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/vsts-tasks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/vsts-tasks/merges","archive_url":"https://api.github.com/repos/Microsoft/vsts-tasks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/vsts-tasks/downloads","issues_url":"https://api.github.com/repos/Microsoft/vsts-tasks/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/vsts-tasks/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/vsts-tasks/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/vsts-tasks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/vsts-tasks/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/vsts-tasks/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/vsts-tasks/deployments","created_at":"2014-12-06T11:11:46Z","updated_at":"2018-02-08T16:14:11Z","pushed_at":"2018-02-08T18:20:28Z","git_url":"git://github.com/Microsoft/vsts-tasks.git","ssh_url":"[email protected]:Microsoft/vsts-tasks.git","clone_url":"https://github.com/Microsoft/vsts-tasks.git","svn_url":"https://github.com/Microsoft/vsts-tasks","homepage":"https://aka.ms/tfbuild","size":34876,"stargazers_count":773,"watchers_count":773,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":714,"mirror_url":null,"archived":false,"open_issues_count":249,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":714,"open_issues":249,"watchers":773,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"008a81d201ffd23f898faea859ca812fa69822db","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":27631673,"name":"vsts-tasks","full_name":"Microsoft/vsts-tasks","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/vsts-tasks","description":"Build and Release Tasks for Visual Studio Team Services and Team Foundation Server","fork":false,"url":"https://api.github.com/repos/Microsoft/vsts-tasks","forks_url":"https://api.github.com/repos/Microsoft/vsts-tasks/forks","keys_url":"https://api.github.com/repos/Microsoft/vsts-tasks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/vsts-tasks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/vsts-tasks/teams","hooks_url":"https://api.github.com/repos/Microsoft/vsts-tasks/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/vsts-tasks/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/vsts-tasks/events","assignees_url":"https://api.github.com/repos/Microsoft/vsts-tasks/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/vsts-tasks/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/vsts-tasks/tags","blobs_url":"https://api.github.com/repos/Microsoft/vsts-tasks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/vsts-tasks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/vsts-tasks/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/vsts-tasks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/vsts-tasks/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/vsts-tasks/languages","stargazers_url":"https://api.github.com/repos/Microsoft/vsts-tasks/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/vsts-tasks/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/vsts-tasks/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/vsts-tasks/subscription","commits_url":"https://api.github.com/repos/Microsoft/vsts-tasks/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/vsts-tasks/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/vsts-tasks/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/vsts-tasks/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/vsts-tasks/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/vsts-tasks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/vsts-tasks/merges","archive_url":"https://api.github.com/repos/Microsoft/vsts-tasks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/vsts-tasks/downloads","issues_url":"https://api.github.com/repos/Microsoft/vsts-tasks/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/vsts-tasks/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/vsts-tasks/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/vsts-tasks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/vsts-tasks/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/vsts-tasks/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/vsts-tasks/deployments","created_at":"2014-12-06T11:11:46Z","updated_at":"2018-02-08T16:14:11Z","pushed_at":"2018-02-08T18:20:28Z","git_url":"git://github.com/Microsoft/vsts-tasks.git","ssh_url":"[email protected]:Microsoft/vsts-tasks.git","clone_url":"https://github.com/Microsoft/vsts-tasks.git","svn_url":"https://github.com/Microsoft/vsts-tasks","homepage":"https://aka.ms/tfbuild","size":34876,"stargazers_count":773,"watchers_count":773,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":714,"mirror_url":null,"archived":false,"open_issues_count":249,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":714,"open_issues":249,"watchers":773,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/vsts-tasks/pulls/6385"},"html":{"href":"https://github.com/Microsoft/vsts-tasks/pull/6385"},"issue":{"href":"https://api.github.com/repos/Microsoft/vsts-tasks/issues/6385"},"comments":{"href":"https://api.github.com/repos/Microsoft/vsts-tasks/issues/6385/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/vsts-tasks/pulls/6385/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/vsts-tasks/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/vsts-tasks/pulls/6385/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/vsts-tasks/statuses/a92992f921e42ff2db4c910dd0e3387886d18588"}},"author_association":"MEMBER"}} | {
"id": 27631673,
"name": "Microsoft/vsts-tasks",
"url": "https://api.github.com/repos/Microsoft/vsts-tasks"
} | {
"id": 12102068,
"login": "ericsciple",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/12102068?",
"url": "https://api.github.com/users/ericsciple"
} | {
"id": 6154722,
"login": "Microsoft",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6154722?",
"url": "https://api.github.com/orgs/Microsoft"
} | 2018-02-08T18:38:32 | 7218643285 | {"actor":{"display_login":"ericsciple"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/fast-dna/pulls/comments/217785173","pull_request_review_id":155588478,"id":217785173,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNzc4NTE3Mw==","diff_hunk":"@@ -2,9 +2,28 @@\n * The class name contract for the checkbox component\n */\n export interface ICheckboxClassNameContract {\n+ /**\n+ * The root checkbox component\n+ */\n checkbox: string;\n- checkbox_disabled: string;\n+\n+ /**\n+ * The disabled state modifier\n+ */\n+ checkbox__disabled: string;\n+\n+ /**\n+ * The checkbox input element\n+ */\n checkbox_input: string;\n+\n+ /**\n+ * The label associated with the checkbox\n+ */\n checkbox_label: string;\n- checkbox_span: string;\n+\n+ /**\n+ * The checkbox state indicator (e.g. checked, inditerminant, or not checked)","path":"packages/fast-components-class-name-contracts-base/src/checkbox/index.ts","position":27,"original_position":27,"commit_id":"a15515027fa4be97831b404bea15d0c17a0de00a","original_commit_id":"a15515027fa4be97831b404bea15d0c17a0de00a","user":{"login":"nicholasrice","id":3213292,"node_id":"MDQ6VXNlcjMyMTMyOTI=","avatar_url":"https://avatars2.githubusercontent.com/u/3213292?v=4","gravatar_id":"","url":"https://api.github.com/users/nicholasrice","html_url":"https://github.com/nicholasrice","followers_url":"https://api.github.com/users/nicholasrice/followers","following_url":"https://api.github.com/users/nicholasrice/following{/other_user}","gists_url":"https://api.github.com/users/nicholasrice/gists{/gist_id}","starred_url":"https://api.github.com/users/nicholasrice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicholasrice/subscriptions","organizations_url":"https://api.github.com/users/nicholasrice/orgs","repos_url":"https://api.github.com/users/nicholasrice/repos","events_url":"https://api.github.com/users/nicholasrice/events{/privacy}","received_events_url":"https://api.github.com/users/nicholasrice/received_events","type":"User","site_admin":false},"body":"I'd omit the \"eg\" here - to me that is more confusing because it speaks to the *state* while the sentence speaks to the *element*","created_at":"2018-09-14T17:24:02Z","updated_at":"2018-09-14T17:43:15Z","html_url":"https://github.com/Microsoft/fast-dna/pull/893#discussion_r217785173","pull_request_url":"https://api.github.com/repos/Microsoft/fast-dna/pulls/893","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/fast-dna/pulls/comments/217785173"},"html":{"href":"https://github.com/Microsoft/fast-dna/pull/893#discussion_r217785173"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/fast-dna/pulls/893"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/fast-dna/pulls/893","id":215477145,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1NDc3MTQ1","html_url":"https://github.com/Microsoft/fast-dna/pull/893","diff_url":"https://github.com/Microsoft/fast-dna/pull/893.diff","patch_url":"https://github.com/Microsoft/fast-dna/pull/893.patch","issue_url":"https://api.github.com/repos/Microsoft/fast-dna/issues/893","number":893,"state":"open","locked":false,"title":"feat(class names): update all class names across base and MSFT to align with naming standards","user":{"login":"nalogiudice","id":22480660,"node_id":"MDQ6VXNlcjIyNDgwNjYw","avatar_url":"https://avatars3.githubusercontent.com/u/22480660?v=4","gravatar_id":"","url":"https://api.github.com/users/nalogiudice","html_url":"https://github.com/nalogiudice","followers_url":"https://api.github.com/users/nalogiudice/followers","following_url":"https://api.github.com/users/nalogiudice/following{/other_user}","gists_url":"https://api.github.com/users/nalogiudice/gists{/gist_id}","starred_url":"https://api.github.com/users/nalogiudice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nalogiudice/subscriptions","organizations_url":"https://api.github.com/users/nalogiudice/orgs","repos_url":"https://api.github.com/users/nalogiudice/repos","events_url":"https://api.github.com/users/nalogiudice/events{/privacy}","received_events_url":"https://api.github.com/users/nalogiudice/received_events","type":"User","site_admin":false},"body":"Closes [#892](https://github.com/Microsoft/fast-dna/issues/892)\r\n<body>\r\n\r\n<footer>\r\n \r\n\r\nFor [details on formatting](https://github.com/Microsoft/fast-dna/wiki/pull-request-guidance) pull requests.\r\n","created_at":"2018-09-14T04:17:05Z","updated_at":"2018-09-14T17:43:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9575115cafd0e8b8bfc337f6752dac7035801fe2","assignee":{"login":"nalogiudice","id":22480660,"node_id":"MDQ6VXNlcjIyNDgwNjYw","avatar_url":"https://avatars3.githubusercontent.com/u/22480660?v=4","gravatar_id":"","url":"https://api.github.com/users/nalogiudice","html_url":"https://github.com/nalogiudice","followers_url":"https://api.github.com/users/nalogiudice/followers","following_url":"https://api.github.com/users/nalogiudice/following{/other_user}","gists_url":"https://api.github.com/users/nalogiudice/gists{/gist_id}","starred_url":"https://api.github.com/users/nalogiudice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nalogiudice/subscriptions","organizations_url":"https://api.github.com/users/nalogiudice/orgs","repos_url":"https://api.github.com/users/nalogiudice/repos","events_url":"https://api.github.com/users/nalogiudice/events{/privacy}","received_events_url":"https://api.github.com/users/nalogiudice/received_events","type":"User","site_admin":false},"assignees":[{"login":"nalogiudice","id":22480660,"node_id":"MDQ6VXNlcjIyNDgwNjYw","avatar_url":"https://avatars3.githubusercontent.com/u/22480660?v=4","gravatar_id":"","url":"https://api.github.com/users/nalogiudice","html_url":"https://github.com/nalogiudice","followers_url":"https://api.github.com/users/nalogiudice/followers","following_url":"https://api.github.com/users/nalogiudice/following{/other_user}","gists_url":"https://api.github.com/users/nalogiudice/gists{/gist_id}","starred_url":"https://api.github.com/users/nalogiudice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nalogiudice/subscriptions","organizations_url":"https://api.github.com/users/nalogiudice/orgs","repos_url":"https://api.github.com/users/nalogiudice/repos","events_url":"https://api.github.com/users/nalogiudice/events{/privacy}","received_events_url":"https://api.github.com/users/nalogiudice/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"janechu","id":7559015,"node_id":"MDQ6VXNlcjc1NTkwMTU=","avatar_url":"https://avatars1.githubusercontent.com/u/7559015?v=4","gravatar_id":"","url":"https://api.github.com/users/janechu","html_url":"https://github.com/janechu","followers_url":"https://api.github.com/users/janechu/followers","following_url":"https://api.github.com/users/janechu/following{/other_user}","gists_url":"https://api.github.com/users/janechu/gists{/gist_id}","starred_url":"https://api.github.com/users/janechu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janechu/subscriptions","organizations_url":"https://api.github.com/users/janechu/orgs","repos_url":"https://api.github.com/users/janechu/repos","events_url":"https://api.github.com/users/janechu/events{/privacy}","received_events_url":"https://api.github.com/users/janechu/received_events","type":"User","site_admin":false},{"login":"chrisdholt","id":13071055,"node_id":"MDQ6VXNlcjEzMDcxMDU1","avatar_url":"https://avatars2.githubusercontent.com/u/13071055?v=4","gravatar_id":"","url":"https://api.github.com/users/chrisdholt","html_url":"https://github.com/chrisdholt","followers_url":"https://api.github.com/users/chrisdholt/followers","following_url":"https://api.github.com/users/chrisdholt/following{/other_user}","gists_url":"https://api.github.com/users/chrisdholt/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisdholt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisdholt/subscriptions","organizations_url":"https://api.github.com/users/chrisdholt/orgs","repos_url":"https://api.github.com/users/chrisdholt/repos","events_url":"https://api.github.com/users/chrisdholt/events{/privacy}","received_events_url":"https://api.github.com/users/chrisdholt/received_events","type":"User","site_admin":false},{"login":"awentzel","id":16669785,"node_id":"MDQ6VXNlcjE2NjY5Nzg1","avatar_url":"https://avatars1.githubusercontent.com/u/16669785?v=4","gravatar_id":"","url":"https://api.github.com/users/awentzel","html_url":"https://github.com/awentzel","followers_url":"https://api.github.com/users/awentzel/followers","following_url":"https://api.github.com/users/awentzel/following{/other_user}","gists_url":"https://api.github.com/users/awentzel/gists{/gist_id}","starred_url":"https://api.github.com/users/awentzel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awentzel/subscriptions","organizations_url":"https://api.github.com/users/awentzel/orgs","repos_url":"https://api.github.com/users/awentzel/repos","events_url":"https://api.github.com/users/awentzel/events{/privacy}","received_events_url":"https://api.github.com/users/awentzel/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":922063143,"node_id":"MDU6TGFiZWw5MjIwNjMxNDM=","url":"https://api.github.com/repos/Microsoft/fast-dna/labels/pr%20:%20breaking%20change%20:boom:","name":"pr : breaking change :boom:","color":"5319e7","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/fast-dna/pulls/893/commits","review_comments_url":"https://api.github.com/repos/Microsoft/fast-dna/pulls/893/comments","review_comment_url":"https://api.github.com/repos/Microsoft/fast-dna/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/fast-dna/issues/893/comments","statuses_url":"https://api.github.com/repos/Microsoft/fast-dna/statuses/a15515027fa4be97831b404bea15d0c17a0de00a","head":{"label":"Microsoft:users/nalogiudice/update-classnames","ref":"users/nalogiudice/update-classnames","sha":"a15515027fa4be97831b404bea15d0c17a0de00a","user":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":123625732,"node_id":"MDEwOlJlcG9zaXRvcnkxMjM2MjU3MzI=","name":"fast-dna","full_name":"Microsoft/fast-dna","owner":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/fast-dna","description":"A set of tooling, resources, and components used to accelerate building Web sites and applications.","fork":false,"url":"https://api.github.com/repos/Microsoft/fast-dna","forks_url":"https://api.github.com/repos/Microsoft/fast-dna/forks","keys_url":"https://api.github.com/repos/Microsoft/fast-dna/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/fast-dna/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/fast-dna/teams","hooks_url":"https://api.github.com/repos/Microsoft/fast-dna/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/fast-dna/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/fast-dna/events","assignees_url":"https://api.github.com/repos/Microsoft/fast-dna/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/fast-dna/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/fast-dna/tags","blobs_url":"https://api.github.com/repos/Microsoft/fast-dna/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/fast-dna/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/fast-dna/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/fast-dna/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/fast-dna/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/fast-dna/languages","stargazers_url":"https://api.github.com/repos/Microsoft/fast-dna/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/fast-dna/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/fast-dna/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/fast-dna/subscription","commits_url":"https://api.github.com/repos/Microsoft/fast-dna/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/fast-dna/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/fast-dna/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/fast-dna/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/fast-dna/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/fast-dna/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/fast-dna/merges","archive_url":"https://api.github.com/repos/Microsoft/fast-dna/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/fast-dna/downloads","issues_url":"https://api.github.com/repos/Microsoft/fast-dna/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/fast-dna/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/fast-dna/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/fast-dna/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/fast-dna/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/fast-dna/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/fast-dna/deployments","created_at":"2018-03-02T20:10:30Z","updated_at":"2018-09-14T07:52:46Z","pushed_at":"2018-09-14T17:26:18Z","git_url":"git://github.com/Microsoft/fast-dna.git","ssh_url":"[email protected]:Microsoft/fast-dna.git","clone_url":"https://github.com/Microsoft/fast-dna.git","svn_url":"https://github.com/Microsoft/fast-dna","homepage":"","size":6611,"stargazers_count":116,"watchers_count":116,"language":"TypeScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"archived":false,"open_issues_count":142,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":15,"open_issues":142,"watchers":116,"default_branch":"master"}},"base":{"label":"Microsoft:releases/components-v3.0.0","ref":"releases/components-v3.0.0","sha":"a03d4125fcf952d34733715741f5abcd334d75fa","user":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":123625732,"node_id":"MDEwOlJlcG9zaXRvcnkxMjM2MjU3MzI=","name":"fast-dna","full_name":"Microsoft/fast-dna","owner":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/fast-dna","description":"A set of tooling, resources, and components used to accelerate building Web sites and applications.","fork":false,"url":"https://api.github.com/repos/Microsoft/fast-dna","forks_url":"https://api.github.com/repos/Microsoft/fast-dna/forks","keys_url":"https://api.github.com/repos/Microsoft/fast-dna/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/fast-dna/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/fast-dna/teams","hooks_url":"https://api.github.com/repos/Microsoft/fast-dna/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/fast-dna/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/fast-dna/events","assignees_url":"https://api.github.com/repos/Microsoft/fast-dna/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/fast-dna/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/fast-dna/tags","blobs_url":"https://api.github.com/repos/Microsoft/fast-dna/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/fast-dna/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/fast-dna/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/fast-dna/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/fast-dna/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/fast-dna/languages","stargazers_url":"https://api.github.com/repos/Microsoft/fast-dna/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/fast-dna/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/fast-dna/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/fast-dna/subscription","commits_url":"https://api.github.com/repos/Microsoft/fast-dna/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/fast-dna/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/fast-dna/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/fast-dna/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/fast-dna/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/fast-dna/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/fast-dna/merges","archive_url":"https://api.github.com/repos/Microsoft/fast-dna/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/fast-dna/downloads","issues_url":"https://api.github.com/repos/Microsoft/fast-dna/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/fast-dna/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/fast-dna/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/fast-dna/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/fast-dna/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/fast-dna/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/fast-dna/deployments","created_at":"2018-03-02T20:10:30Z","updated_at":"2018-09-14T07:52:46Z","pushed_at":"2018-09-14T17:26:18Z","git_url":"git://github.com/Microsoft/fast-dna.git","ssh_url":"[email protected]:Microsoft/fast-dna.git","clone_url":"https://github.com/Microsoft/fast-dna.git","svn_url":"https://github.com/Microsoft/fast-dna","homepage":"","size":6611,"stargazers_count":116,"watchers_count":116,"language":"TypeScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"archived":false,"open_issues_count":142,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":15,"open_issues":142,"watchers":116,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/fast-dna/pulls/893"},"html":{"href":"https://github.com/Microsoft/fast-dna/pull/893"},"issue":{"href":"https://api.github.com/repos/Microsoft/fast-dna/issues/893"},"comments":{"href":"https://api.github.com/repos/Microsoft/fast-dna/issues/893/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/fast-dna/pulls/893/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/fast-dna/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/fast-dna/pulls/893/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/fast-dna/statuses/a15515027fa4be97831b404bea15d0c17a0de00a"}},"author_association":"MEMBER"}} | {
"id": 123625732,
"name": "Microsoft/fast-dna",
"url": "https://api.github.com/repos/Microsoft/fast-dna"
} | {
"id": 3213292,
"login": "nicholasrice",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3213292?",
"url": "https://api.github.com/users/nicholasrice"
} | {
"id": 6154722,
"login": "Microsoft",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6154722?",
"url": "https://api.github.com/orgs/Microsoft"
} | 2018-09-14T17:24:02 | 8267519989 | {"actor":{"display_login":"nicholasrice"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/service-fabric-explorer/pulls/comments/195660549","pull_request_review_id":129073576,"id":195660549,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NTY2MDU0OQ==","diff_hunk":"@@ -7,6 +7,7 @@ var plugins = require(\"gulp-load-plugins\")({\n camelize: true,\r\n lazy: true\r\n });\r\n+var libConfiguration = require(\"./build/lib.json\");\r","path":"src/Sfx/gulpfile.js","position":4,"original_position":4,"commit_id":"10d58240d964019946c9011336f0c22f917980a2","original_commit_id":"10d58240d964019946c9011336f0c22f917980a2","user":{"login":"stevshan","id":34558962,"node_id":"MDQ6VXNlcjM0NTU4OTYy","avatar_url":"https://avatars2.githubusercontent.com/u/34558962?v=4","gravatar_id":"","url":"https://api.github.com/users/stevshan","html_url":"https://github.com/stevshan","followers_url":"https://api.github.com/users/stevshan/followers","following_url":"https://api.github.com/users/stevshan/following{/other_user}","gists_url":"https://api.github.com/users/stevshan/gists{/gist_id}","starred_url":"https://api.github.com/users/stevshan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevshan/subscriptions","organizations_url":"https://api.github.com/users/stevshan/orgs","repos_url":"https://api.github.com/users/stevshan/repos","events_url":"https://api.github.com/users/stevshan/events{/privacy}","received_events_url":"https://api.github.com/users/stevshan/received_events","type":"User","site_admin":false},"body":"please use const instead. Can we also change other \"var\" to const if necessary?","created_at":"2018-06-15T08:10:15Z","updated_at":"2018-06-15T08:13:43Z","html_url":"https://github.com/Microsoft/service-fabric-explorer/pull/66#discussion_r195660549","pull_request_url":"https://api.github.com/repos/Microsoft/service-fabric-explorer/pulls/66","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/service-fabric-explorer/pulls/comments/195660549"},"html":{"href":"https://github.com/Microsoft/service-fabric-explorer/pull/66#discussion_r195660549"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/service-fabric-explorer/pulls/66"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/service-fabric-explorer/pulls/66","id":195102448,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1MTAyNDQ4","html_url":"https://github.com/Microsoft/service-fabric-explorer/pull/66","diff_url":"https://github.com/Microsoft/service-fabric-explorer/pull/66.diff","patch_url":"https://github.com/Microsoft/service-fabric-explorer/pull/66.patch","issue_url":"https://api.github.com/repos/Microsoft/service-fabric-explorer/issues/66","number":66,"state":"open","locked":false,"title":"retire bower","user":{"login":"tonglingchen","id":22808540,"node_id":"MDQ6VXNlcjIyODA4NTQw","avatar_url":"https://avatars2.githubusercontent.com/u/22808540?v=4","gravatar_id":"","url":"https://api.github.com/users/tonglingchen","html_url":"https://github.com/tonglingchen","followers_url":"https://api.github.com/users/tonglingchen/followers","following_url":"https://api.github.com/users/tonglingchen/following{/other_user}","gists_url":"https://api.github.com/users/tonglingchen/gists{/gist_id}","starred_url":"https://api.github.com/users/tonglingchen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tonglingchen/subscriptions","organizations_url":"https://api.github.com/users/tonglingchen/orgs","repos_url":"https://api.github.com/users/tonglingchen/repos","events_url":"https://api.github.com/users/tonglingchen/events{/privacy}","received_events_url":"https://api.github.com/users/tonglingchen/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-06-15T07:59:14Z","updated_at":"2018-06-15T08:13:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"048c0e86bfe558ddeea17e598eff4d9a8e8f94a8","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/service-fabric-explorer/pulls/66/commits","review_comments_url":"https://api.github.com/repos/Microsoft/service-fabric-explorer/pulls/66/comments","review_comment_url":"https://api.github.com/repos/Microsoft/service-fabric-explorer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/service-fabric-explorer/issues/66/comments","statuses_url":"https://api.github.com/repos/Microsoft/service-fabric-explorer/statuses/10d58240d964019946c9011336f0c22f917980a2","head":{"label":"Microsoft:u/tomchen/nobower","ref":"u/tomchen/nobower","sha":"10d58240d964019946c9011336f0c22f917980a2","user":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":112569817,"node_id":"MDEwOlJlcG9zaXRvcnkxMTI1Njk4MTc=","name":"service-fabric-explorer","full_name":"Microsoft/service-fabric-explorer","owner":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/service-fabric-explorer","description":"Service Fabric Explorer","fork":false,"url":"https://api.github.com/repos/Microsoft/service-fabric-explorer","forks_url":"https://api.github.com/repos/Microsoft/service-fabric-explorer/forks","keys_url":"https://api.github.com/repos/Microsoft/service-fabric-explorer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/service-fabric-explorer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/service-fabric-explorer/teams","hooks_url":"https://api.github.com/repos/Microsoft/service-fabric-explorer/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/service-fabric-explorer/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/service-fabric-explorer/events","assignees_url":"https://api.github.com/repos/Microsoft/service-fabric-explorer/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/service-fabric-explorer/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/service-fabric-explorer/tags","blobs_url":"https://api.github.com/repos/Microsoft/service-fabric-explorer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/service-fabric-explorer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/service-fabric-explorer/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/service-fabric-explorer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/service-fabric-explorer/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/service-fabric-explorer/languages","stargazers_url":"https://api.github.com/repos/Microsoft/service-fabric-explorer/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/service-fabric-explorer/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/service-fabric-explorer/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/service-fabric-explorer/subscription","commits_url":"https://api.github.com/repos/Microsoft/service-fabric-explorer/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/service-fabric-explorer/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/service-fabric-explorer/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/service-fabric-explorer/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/service-fabric-explorer/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/service-fabric-explorer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/service-fabric-explorer/merges","archive_url":"https://api.github.com/repos/Microsoft/service-fabric-explorer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/service-fabric-explorer/downloads","issues_url":"https://api.github.com/repos/Microsoft/service-fabric-explorer/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/service-fabric-explorer/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/service-fabric-explorer/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/service-fabric-explorer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/service-fabric-explorer/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/service-fabric-explorer/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/service-fabric-explorer/deployments","created_at":"2017-11-30T05:43:37Z","updated_at":"2018-06-13T22:20:48Z","pushed_at":"2018-06-15T07:59:14Z","git_url":"git://github.com/Microsoft/service-fabric-explorer.git","ssh_url":"[email protected]:Microsoft/service-fabric-explorer.git","clone_url":"https://github.com/Microsoft/service-fabric-explorer.git","svn_url":"https://github.com/Microsoft/service-fabric-explorer","homepage":null,"size":6896,"stargazers_count":35,"watchers_count":35,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"archived":false,"open_issues_count":18,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":16,"open_issues":18,"watchers":35,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"0951daf106e7861a14062093384cf9bb6522b741","user":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":112569817,"node_id":"MDEwOlJlcG9zaXRvcnkxMTI1Njk4MTc=","name":"service-fabric-explorer","full_name":"Microsoft/service-fabric-explorer","owner":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/service-fabric-explorer","description":"Service Fabric Explorer","fork":false,"url":"https://api.github.com/repos/Microsoft/service-fabric-explorer","forks_url":"https://api.github.com/repos/Microsoft/service-fabric-explorer/forks","keys_url":"https://api.github.com/repos/Microsoft/service-fabric-explorer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/service-fabric-explorer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/service-fabric-explorer/teams","hooks_url":"https://api.github.com/repos/Microsoft/service-fabric-explorer/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/service-fabric-explorer/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/service-fabric-explorer/events","assignees_url":"https://api.github.com/repos/Microsoft/service-fabric-explorer/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/service-fabric-explorer/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/service-fabric-explorer/tags","blobs_url":"https://api.github.com/repos/Microsoft/service-fabric-explorer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/service-fabric-explorer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/service-fabric-explorer/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/service-fabric-explorer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/service-fabric-explorer/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/service-fabric-explorer/languages","stargazers_url":"https://api.github.com/repos/Microsoft/service-fabric-explorer/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/service-fabric-explorer/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/service-fabric-explorer/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/service-fabric-explorer/subscription","commits_url":"https://api.github.com/repos/Microsoft/service-fabric-explorer/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/service-fabric-explorer/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/service-fabric-explorer/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/service-fabric-explorer/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/service-fabric-explorer/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/service-fabric-explorer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/service-fabric-explorer/merges","archive_url":"https://api.github.com/repos/Microsoft/service-fabric-explorer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/service-fabric-explorer/downloads","issues_url":"https://api.github.com/repos/Microsoft/service-fabric-explorer/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/service-fabric-explorer/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/service-fabric-explorer/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/service-fabric-explorer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/service-fabric-explorer/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/service-fabric-explorer/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/service-fabric-explorer/deployments","created_at":"2017-11-30T05:43:37Z","updated_at":"2018-06-13T22:20:48Z","pushed_at":"2018-06-15T07:59:14Z","git_url":"git://github.com/Microsoft/service-fabric-explorer.git","ssh_url":"[email protected]:Microsoft/service-fabric-explorer.git","clone_url":"https://github.com/Microsoft/service-fabric-explorer.git","svn_url":"https://github.com/Microsoft/service-fabric-explorer","homepage":null,"size":6896,"stargazers_count":35,"watchers_count":35,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"archived":false,"open_issues_count":18,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":16,"open_issues":18,"watchers":35,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/service-fabric-explorer/pulls/66"},"html":{"href":"https://github.com/Microsoft/service-fabric-explorer/pull/66"},"issue":{"href":"https://api.github.com/repos/Microsoft/service-fabric-explorer/issues/66"},"comments":{"href":"https://api.github.com/repos/Microsoft/service-fabric-explorer/issues/66/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/service-fabric-explorer/pulls/66/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/service-fabric-explorer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/service-fabric-explorer/pulls/66/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/service-fabric-explorer/statuses/10d58240d964019946c9011336f0c22f917980a2"}},"author_association":"CONTRIBUTOR"}} | {
"id": 112569817,
"name": "Microsoft/service-fabric-explorer",
"url": "https://api.github.com/repos/Microsoft/service-fabric-explorer"
} | {
"id": 34558962,
"login": "stevshan",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/34558962?",
"url": "https://api.github.com/users/stevshan"
} | {
"id": 6154722,
"login": "Microsoft",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6154722?",
"url": "https://api.github.com/orgs/Microsoft"
} | 2018-06-15T08:10:15 | 7829528381 | {"actor":{"display_login":"stevshan"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/pulls/comments/230826564","pull_request_review_id":171652138,"id":230826564,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMDgyNjU2NA==","diff_hunk":"@@ -144,7 +144,11 @@ export async function ensureFolderIsOpen(fsPath: string, actionContext: IActionC\n \n const uri: vscode.Uri = vscode.Uri.file(fsPath);\n if (openBehavior === OpenBehavior.AddToWorkspace) {\n- vscode.workspace.updateWorkspaceFolders(openFolders.length, 0, { uri: uri });\n+ if (openFolders.length) {","path":"src/utils/workspace.ts","position":5,"original_position":5,"commit_id":"00713469fa056af30695cd872a036f4f2523256b","original_commit_id":"00713469fa056af30695cd872a036f4f2523256b","user":{"login":"EricJizbaMSFT","id":11282622,"node_id":"MDQ6VXNlcjExMjgyNjIy","avatar_url":"https://avatars2.githubusercontent.com/u/11282622?v=4","gravatar_id":"","url":"https://api.github.com/users/EricJizbaMSFT","html_url":"https://github.com/EricJizbaMSFT","followers_url":"https://api.github.com/users/EricJizbaMSFT/followers","following_url":"https://api.github.com/users/EricJizbaMSFT/following{/other_user}","gists_url":"https://api.github.com/users/EricJizbaMSFT/gists{/gist_id}","starred_url":"https://api.github.com/users/EricJizbaMSFT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EricJizbaMSFT/subscriptions","organizations_url":"https://api.github.com/users/EricJizbaMSFT/orgs","repos_url":"https://api.github.com/users/EricJizbaMSFT/repos","events_url":"https://api.github.com/users/EricJizbaMSFT/events{/privacy}","received_events_url":"https://api.github.com/users/EricJizbaMSFT/received_events","type":"User","site_admin":false},"body":"Yeah `if (openFolders.length)` is fine","created_at":"2018-11-05T16:50:16Z","updated_at":"2018-11-05T16:53:39Z","html_url":"https://github.com/Microsoft/vscode-azurefunctions/pull/779#discussion_r230826564","pull_request_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/pulls/779","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/pulls/comments/230826564"},"html":{"href":"https://github.com/Microsoft/vscode-azurefunctions/pull/779#discussion_r230826564"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/pulls/779"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/pulls/779","id":228096662,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4MDk2NjYy","html_url":"https://github.com/Microsoft/vscode-azurefunctions/pull/779","diff_url":"https://github.com/Microsoft/vscode-azurefunctions/pull/779.diff","patch_url":"https://github.com/Microsoft/vscode-azurefunctions/pull/779.patch","issue_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/issues/779","number":779,"state":"open","locked":false,"title":"\"Add to workspace\" with no folders opens in current window","user":{"login":"alexweininger","id":12476526,"node_id":"MDQ6VXNlcjEyNDc2NTI2","avatar_url":"https://avatars2.githubusercontent.com/u/12476526?v=4","gravatar_id":"","url":"https://api.github.com/users/alexweininger","html_url":"https://github.com/alexweininger","followers_url":"https://api.github.com/users/alexweininger/followers","following_url":"https://api.github.com/users/alexweininger/following{/other_user}","gists_url":"https://api.github.com/users/alexweininger/gists{/gist_id}","starred_url":"https://api.github.com/users/alexweininger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexweininger/subscriptions","organizations_url":"https://api.github.com/users/alexweininger/orgs","repos_url":"https://api.github.com/users/alexweininger/repos","events_url":"https://api.github.com/users/alexweininger/events{/privacy}","received_events_url":"https://api.github.com/users/alexweininger/received_events","type":"User","site_admin":false},"body":"Fixes #752 \r\n\r\n\r\nCreate new project -> language -> **add to workspace**\r\n\r\nNow it opens the project folder in the current window instead of adding it as a workspace folder in an untitled workspace.\r\n\r\n\r\n\r\n`if (openFolders.length)` is what I used to check if no folders are open. Is this implicit coercion good practice? I didn't see any issues with using it since I think `openFolders` will always be an array based on its declaration:\r\n\r\n```typescript\r\nconst openFolders: vscode.WorkspaceFolder[] = vscode.workspace.workspaceFolders || [];\r\n```\r\n\r\nThanks!\r\n\r\n","created_at":"2018-11-03T03:25:43Z","updated_at":"2018-11-05T16:53:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"987da9ae166eb7b00df0201889107b48236fc6ed","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/pulls/779/commits","review_comments_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/pulls/779/comments","review_comment_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/issues/779/comments","statuses_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/statuses/00713469fa056af30695cd872a036f4f2523256b","head":{"label":"alexweininger:addToWorkspaceNoFolders","ref":"addToWorkspaceNoFolders","sha":"00713469fa056af30695cd872a036f4f2523256b","user":{"login":"alexweininger","id":12476526,"node_id":"MDQ6VXNlcjEyNDc2NTI2","avatar_url":"https://avatars2.githubusercontent.com/u/12476526?v=4","gravatar_id":"","url":"https://api.github.com/users/alexweininger","html_url":"https://github.com/alexweininger","followers_url":"https://api.github.com/users/alexweininger/followers","following_url":"https://api.github.com/users/alexweininger/following{/other_user}","gists_url":"https://api.github.com/users/alexweininger/gists{/gist_id}","starred_url":"https://api.github.com/users/alexweininger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexweininger/subscriptions","organizations_url":"https://api.github.com/users/alexweininger/orgs","repos_url":"https://api.github.com/users/alexweininger/repos","events_url":"https://api.github.com/users/alexweininger/events{/privacy}","received_events_url":"https://api.github.com/users/alexweininger/received_events","type":"User","site_admin":false},"repo":{"id":153730008,"node_id":"MDEwOlJlcG9zaXRvcnkxNTM3MzAwMDg=","name":"vscode-azurefunctions","full_name":"alexweininger/vscode-azurefunctions","private":false,"owner":{"login":"alexweininger","id":12476526,"node_id":"MDQ6VXNlcjEyNDc2NTI2","avatar_url":"https://avatars2.githubusercontent.com/u/12476526?v=4","gravatar_id":"","url":"https://api.github.com/users/alexweininger","html_url":"https://github.com/alexweininger","followers_url":"https://api.github.com/users/alexweininger/followers","following_url":"https://api.github.com/users/alexweininger/following{/other_user}","gists_url":"https://api.github.com/users/alexweininger/gists{/gist_id}","starred_url":"https://api.github.com/users/alexweininger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexweininger/subscriptions","organizations_url":"https://api.github.com/users/alexweininger/orgs","repos_url":"https://api.github.com/users/alexweininger/repos","events_url":"https://api.github.com/users/alexweininger/events{/privacy}","received_events_url":"https://api.github.com/users/alexweininger/received_events","type":"User","site_admin":false},"html_url":"https://github.com/alexweininger/vscode-azurefunctions","description":"Azure Functions extension for VS Code","fork":true,"url":"https://api.github.com/repos/alexweininger/vscode-azurefunctions","forks_url":"https://api.github.com/repos/alexweininger/vscode-azurefunctions/forks","keys_url":"https://api.github.com/repos/alexweininger/vscode-azurefunctions/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alexweininger/vscode-azurefunctions/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alexweininger/vscode-azurefunctions/teams","hooks_url":"https://api.github.com/repos/alexweininger/vscode-azurefunctions/hooks","issue_events_url":"https://api.github.com/repos/alexweininger/vscode-azurefunctions/issues/events{/number}","events_url":"https://api.github.com/repos/alexweininger/vscode-azurefunctions/events","assignees_url":"https://api.github.com/repos/alexweininger/vscode-azurefunctions/assignees{/user}","branches_url":"https://api.github.com/repos/alexweininger/vscode-azurefunctions/branches{/branch}","tags_url":"https://api.github.com/repos/alexweininger/vscode-azurefunctions/tags","blobs_url":"https://api.github.com/repos/alexweininger/vscode-azurefunctions/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alexweininger/vscode-azurefunctions/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alexweininger/vscode-azurefunctions/git/refs{/sha}","trees_url":"https://api.github.com/repos/alexweininger/vscode-azurefunctions/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alexweininger/vscode-azurefunctions/statuses/{sha}","languages_url":"https://api.github.com/repos/alexweininger/vscode-azurefunctions/languages","stargazers_url":"https://api.github.com/repos/alexweininger/vscode-azurefunctions/stargazers","contributors_url":"https://api.github.com/repos/alexweininger/vscode-azurefunctions/contributors","subscribers_url":"https://api.github.com/repos/alexweininger/vscode-azurefunctions/subscribers","subscription_url":"https://api.github.com/repos/alexweininger/vscode-azurefunctions/subscription","commits_url":"https://api.github.com/repos/alexweininger/vscode-azurefunctions/commits{/sha}","git_commits_url":"https://api.github.com/repos/alexweininger/vscode-azurefunctions/git/commits{/sha}","comments_url":"https://api.github.com/repos/alexweininger/vscode-azurefunctions/comments{/number}","issue_comment_url":"https://api.github.com/repos/alexweininger/vscode-azurefunctions/issues/comments{/number}","contents_url":"https://api.github.com/repos/alexweininger/vscode-azurefunctions/contents/{+path}","compare_url":"https://api.github.com/repos/alexweininger/vscode-azurefunctions/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alexweininger/vscode-azurefunctions/merges","archive_url":"https://api.github.com/repos/alexweininger/vscode-azurefunctions/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alexweininger/vscode-azurefunctions/downloads","issues_url":"https://api.github.com/repos/alexweininger/vscode-azurefunctions/issues{/number}","pulls_url":"https://api.github.com/repos/alexweininger/vscode-azurefunctions/pulls{/number}","milestones_url":"https://api.github.com/repos/alexweininger/vscode-azurefunctions/milestones{/number}","notifications_url":"https://api.github.com/repos/alexweininger/vscode-azurefunctions/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alexweininger/vscode-azurefunctions/labels{/name}","releases_url":"https://api.github.com/repos/alexweininger/vscode-azurefunctions/releases{/id}","deployments_url":"https://api.github.com/repos/alexweininger/vscode-azurefunctions/deployments","created_at":"2018-10-19T05:16:57Z","updated_at":"2018-10-19T05:17:00Z","pushed_at":"2018-11-03T03:07:26Z","git_url":"git://github.com/alexweininger/vscode-azurefunctions.git","ssh_url":"[email protected]:alexweininger/vscode-azurefunctions.git","clone_url":"https://github.com/alexweininger/vscode-azurefunctions.git","svn_url":"https://github.com/alexweininger/vscode-azurefunctions","homepage":"https://marketplace.visualstudio.com/items?itemName=ms-azuretools.vscode-azurefunctions","size":17626,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"78d435c0d47027cb22b69f4270654488f29ef62c","user":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":104400765,"node_id":"MDEwOlJlcG9zaXRvcnkxMDQ0MDA3NjU=","name":"vscode-azurefunctions","full_name":"Microsoft/vscode-azurefunctions","private":false,"owner":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Microsoft/vscode-azurefunctions","description":"Azure Functions extension for VS Code","fork":false,"url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions","forks_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/forks","keys_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/teams","hooks_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/events","assignees_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/tags","blobs_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/languages","stargazers_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/subscription","commits_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/merges","archive_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/downloads","issues_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/deployments","created_at":"2017-09-21T21:28:44Z","updated_at":"2018-11-01T18:17:19Z","pushed_at":"2018-11-03T03:25:44Z","git_url":"git://github.com/Microsoft/vscode-azurefunctions.git","ssh_url":"[email protected]:Microsoft/vscode-azurefunctions.git","clone_url":"https://github.com/Microsoft/vscode-azurefunctions.git","svn_url":"https://github.com/Microsoft/vscode-azurefunctions","homepage":"https://marketplace.visualstudio.com/items?itemName=ms-azuretools.vscode-azurefunctions","size":17641,"stargazers_count":89,"watchers_count":89,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":27,"mirror_url":null,"archived":false,"open_issues_count":85,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":27,"open_issues":85,"watchers":89,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/pulls/779"},"html":{"href":"https://github.com/Microsoft/vscode-azurefunctions/pull/779"},"issue":{"href":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/issues/779"},"comments":{"href":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/issues/779/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/pulls/779/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/pulls/779/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/statuses/00713469fa056af30695cd872a036f4f2523256b"}},"author_association":"CONTRIBUTOR"}} | {
"id": 104400765,
"name": "Microsoft/vscode-azurefunctions",
"url": "https://api.github.com/repos/Microsoft/vscode-azurefunctions"
} | {
"id": 11282622,
"login": "EricJizbaMSFT",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/11282622?",
"url": "https://api.github.com/users/EricJizbaMSFT"
} | {
"id": 6154722,
"login": "Microsoft",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6154722?",
"url": "https://api.github.com/orgs/Microsoft"
} | 2018-11-05T16:50:16 | 8537054957 | {"actor":{"display_login":"EricJizbaMSFT"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/xbox-live-trace-analyzer/pulls/comments/174908611","pull_request_review_id":104353031,"id":174908611,"diff_hunk":"@@ -58,10 +58,10 @@\n \"GET https://sessiondirectory.xboxlive.com/handles/{handleId}/session\",\"multiplayer_service::get_current_session_by_handle\",\"MultiplayerService::GetCurrentSessionByHandle\"\n \"GET https://sessiondirectory.xboxlive.com/serviceconfigs/{scid}/sessiontemplates/{session-template-name}/sessions\",\"multiplayer_service::get_sessions\",\"MultiplayerService::GetSessions\"\n \"GET https://sessiondirectory.xboxlive.com/serviceconfigs/{scid}/sessions\",\"multiplayer_service::get_sessions\",\"MultiplayerService::GetSessions\"\n-\"POST https://sessiondirectory.xboxlive.com/handles\",\"multiplayer_service::set_activity, set_transfer_handle, send_invites or set_search_handle\",\"MultiplayerService::SetActivity, SetTransferHandle, SendInvites or SetSearchHandle\"\n-\"DELETE https://sessiondirectory.xboxlive.com/handles/{handlId}\",\"multiplayer_service::clear_activity or clear_search_handle\",\"MultiplayerService::ClearActivity or ClearSearchHandle\"\n-\"POST https://sessiondirectory.xboxlive.com/handles/query?include=relatedinfo,customProperties\",\"multiplayer_service::get_activities_for_social_group or get_activities_for_users\",\"MultiplayerService::GetActivitiesForSocialGroup or GetActivitiesForUsers\"\n+\"POST https://sessiondirectory.xboxlive.com/handles/query?include=relatedInfo,customProperties\",\"multiplayer_service::get_activities_for_social_group or get_activities_for_users\",\"MultiplayerService::GetActivitiesForSocialGroup or GetActivitiesForUsers\"\n \"POST https://sessiondirectory.xboxlive.com/handles/query?include=relatedInfo,roleInfo,customProperties\",\"multiplayer_service::get_search_handles\",\"MultiplayerService::GetSearchHandles\"\n+\"DELETE https://sessiondirectory.xboxlive.com/handles/{handlId}\",\"multiplayer_service::clear_activity or clear_search_handle\",\"MultiplayerService::ClearActivity or ClearSearchHandle\"\n+\"POST https://sessiondirectory.xboxlive.com/handles\",\"multiplayer_service::set_activity, set_transfer_handle, send_invites or set_search_handle\",\"MultiplayerService::SetActivity, SetTransferHandle, SendInvites or SetSearchHandle\"","path":"Source/XboxLiveTraceAnalyzer.APIMap.csv","position":10,"original_position":10,"commit_id":"35b2a43de3a04997be5f456195decbee6752db63","original_commit_id":"35b2a43de3a04997be5f456195decbee6752db63","user":{"login":"jicailiu","id":14947225,"avatar_url":"https://avatars0.githubusercontent.com/u/14947225?v=4","gravatar_id":"","url":"https://api.github.com/users/jicailiu","html_url":"https://github.com/jicailiu","followers_url":"https://api.github.com/users/jicailiu/followers","following_url":"https://api.github.com/users/jicailiu/following{/other_user}","gists_url":"https://api.github.com/users/jicailiu/gists{/gist_id}","starred_url":"https://api.github.com/users/jicailiu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jicailiu/subscriptions","organizations_url":"https://api.github.com/users/jicailiu/orgs","repos_url":"https://api.github.com/users/jicailiu/repos","events_url":"https://api.github.com/users/jicailiu/events{/privacy}","received_events_url":"https://api.github.com/users/jicailiu/received_events","type":"User","site_admin":false},"body":"The zip file contains the template for final report, it is embedded in the .exe binary. ","created_at":"2018-03-15T19:43:02Z","updated_at":"2018-03-15T19:43:02Z","html_url":"https://github.com/Microsoft/xbox-live-trace-analyzer/pull/17#discussion_r174908611","pull_request_url":"https://api.github.com/repos/Microsoft/xbox-live-trace-analyzer/pulls/17","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/xbox-live-trace-analyzer/pulls/comments/174908611"},"html":{"href":"https://github.com/Microsoft/xbox-live-trace-analyzer/pull/17#discussion_r174908611"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/xbox-live-trace-analyzer/pulls/17"}},"in_reply_to_id":174895793},"pull_request":{"url":"https://api.github.com/repos/Microsoft/xbox-live-trace-analyzer/pulls/17","id":175052182,"html_url":"https://github.com/Microsoft/xbox-live-trace-analyzer/pull/17","diff_url":"https://github.com/Microsoft/xbox-live-trace-analyzer/pull/17.diff","patch_url":"https://github.com/Microsoft/xbox-live-trace-analyzer/pull/17.patch","issue_url":"https://api.github.com/repos/Microsoft/xbox-live-trace-analyzer/issues/17","number":17,"state":"open","locked":false,"title":"Perf improvment on filtering out unrelated fiddler trace.","user":{"login":"jicailiu","id":14947225,"avatar_url":"https://avatars0.githubusercontent.com/u/14947225?v=4","gravatar_id":"","url":"https://api.github.com/users/jicailiu","html_url":"https://github.com/jicailiu","followers_url":"https://api.github.com/users/jicailiu/followers","following_url":"https://api.github.com/users/jicailiu/following{/other_user}","gists_url":"https://api.github.com/users/jicailiu/gists{/gist_id}","starred_url":"https://api.github.com/users/jicailiu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jicailiu/subscriptions","organizations_url":"https://api.github.com/users/jicailiu/orgs","repos_url":"https://api.github.com/users/jicailiu/repos","events_url":"https://api.github.com/users/jicailiu/events{/privacy}","received_events_url":"https://api.github.com/users/jicailiu/received_events","type":"User","site_admin":false},"body":"Bug fixes","created_at":"2018-03-14T18:50:13Z","updated_at":"2018-03-15T19:43:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a5865cc7e552cae89b6d2e0c9deebd58093b6907","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/xbox-live-trace-analyzer/pulls/17/commits","review_comments_url":"https://api.github.com/repos/Microsoft/xbox-live-trace-analyzer/pulls/17/comments","review_comment_url":"https://api.github.com/repos/Microsoft/xbox-live-trace-analyzer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/xbox-live-trace-analyzer/issues/17/comments","statuses_url":"https://api.github.com/repos/Microsoft/xbox-live-trace-analyzer/statuses/35b2a43de3a04997be5f456195decbee6752db63","head":{"label":"jicailiu:staging","ref":"staging","sha":"35b2a43de3a04997be5f456195decbee6752db63","user":{"login":"jicailiu","id":14947225,"avatar_url":"https://avatars0.githubusercontent.com/u/14947225?v=4","gravatar_id":"","url":"https://api.github.com/users/jicailiu","html_url":"https://github.com/jicailiu","followers_url":"https://api.github.com/users/jicailiu/followers","following_url":"https://api.github.com/users/jicailiu/following{/other_user}","gists_url":"https://api.github.com/users/jicailiu/gists{/gist_id}","starred_url":"https://api.github.com/users/jicailiu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jicailiu/subscriptions","organizations_url":"https://api.github.com/users/jicailiu/orgs","repos_url":"https://api.github.com/users/jicailiu/repos","events_url":"https://api.github.com/users/jicailiu/events{/privacy}","received_events_url":"https://api.github.com/users/jicailiu/received_events","type":"User","site_admin":false},"repo":{"id":100539731,"name":"xbox-live-trace-analyzer","full_name":"jicailiu/xbox-live-trace-analyzer","owner":{"login":"jicailiu","id":14947225,"avatar_url":"https://avatars0.githubusercontent.com/u/14947225?v=4","gravatar_id":"","url":"https://api.github.com/users/jicailiu","html_url":"https://github.com/jicailiu","followers_url":"https://api.github.com/users/jicailiu/followers","following_url":"https://api.github.com/users/jicailiu/following{/other_user}","gists_url":"https://api.github.com/users/jicailiu/gists{/gist_id}","starred_url":"https://api.github.com/users/jicailiu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jicailiu/subscriptions","organizations_url":"https://api.github.com/users/jicailiu/orgs","repos_url":"https://api.github.com/users/jicailiu/repos","events_url":"https://api.github.com/users/jicailiu/events{/privacy}","received_events_url":"https://api.github.com/users/jicailiu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jicailiu/xbox-live-trace-analyzer","description":"The Xbox Live Trace Analyzer tool ensures your title is using Xbox Live Services in an optimal fashion. Generate usage logs for your title as described in the Analyze Calls to Xbox Live Services article, and then run this tool to view statistics about repeated calls, burst calls, and more. ","fork":true,"url":"https://api.github.com/repos/jicailiu/xbox-live-trace-analyzer","forks_url":"https://api.github.com/repos/jicailiu/xbox-live-trace-analyzer/forks","keys_url":"https://api.github.com/repos/jicailiu/xbox-live-trace-analyzer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jicailiu/xbox-live-trace-analyzer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jicailiu/xbox-live-trace-analyzer/teams","hooks_url":"https://api.github.com/repos/jicailiu/xbox-live-trace-analyzer/hooks","issue_events_url":"https://api.github.com/repos/jicailiu/xbox-live-trace-analyzer/issues/events{/number}","events_url":"https://api.github.com/repos/jicailiu/xbox-live-trace-analyzer/events","assignees_url":"https://api.github.com/repos/jicailiu/xbox-live-trace-analyzer/assignees{/user}","branches_url":"https://api.github.com/repos/jicailiu/xbox-live-trace-analyzer/branches{/branch}","tags_url":"https://api.github.com/repos/jicailiu/xbox-live-trace-analyzer/tags","blobs_url":"https://api.github.com/repos/jicailiu/xbox-live-trace-analyzer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jicailiu/xbox-live-trace-analyzer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jicailiu/xbox-live-trace-analyzer/git/refs{/sha}","trees_url":"https://api.github.com/repos/jicailiu/xbox-live-trace-analyzer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jicailiu/xbox-live-trace-analyzer/statuses/{sha}","languages_url":"https://api.github.com/repos/jicailiu/xbox-live-trace-analyzer/languages","stargazers_url":"https://api.github.com/repos/jicailiu/xbox-live-trace-analyzer/stargazers","contributors_url":"https://api.github.com/repos/jicailiu/xbox-live-trace-analyzer/contributors","subscribers_url":"https://api.github.com/repos/jicailiu/xbox-live-trace-analyzer/subscribers","subscription_url":"https://api.github.com/repos/jicailiu/xbox-live-trace-analyzer/subscription","commits_url":"https://api.github.com/repos/jicailiu/xbox-live-trace-analyzer/commits{/sha}","git_commits_url":"https://api.github.com/repos/jicailiu/xbox-live-trace-analyzer/git/commits{/sha}","comments_url":"https://api.github.com/repos/jicailiu/xbox-live-trace-analyzer/comments{/number}","issue_comment_url":"https://api.github.com/repos/jicailiu/xbox-live-trace-analyzer/issues/comments{/number}","contents_url":"https://api.github.com/repos/jicailiu/xbox-live-trace-analyzer/contents/{+path}","compare_url":"https://api.github.com/repos/jicailiu/xbox-live-trace-analyzer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jicailiu/xbox-live-trace-analyzer/merges","archive_url":"https://api.github.com/repos/jicailiu/xbox-live-trace-analyzer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jicailiu/xbox-live-trace-analyzer/downloads","issues_url":"https://api.github.com/repos/jicailiu/xbox-live-trace-analyzer/issues{/number}","pulls_url":"https://api.github.com/repos/jicailiu/xbox-live-trace-analyzer/pulls{/number}","milestones_url":"https://api.github.com/repos/jicailiu/xbox-live-trace-analyzer/milestones{/number}","notifications_url":"https://api.github.com/repos/jicailiu/xbox-live-trace-analyzer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jicailiu/xbox-live-trace-analyzer/labels{/name}","releases_url":"https://api.github.com/repos/jicailiu/xbox-live-trace-analyzer/releases{/id}","deployments_url":"https://api.github.com/repos/jicailiu/xbox-live-trace-analyzer/deployments","created_at":"2017-08-16T23:02:36Z","updated_at":"2017-08-16T23:02:37Z","pushed_at":"2018-03-14T18:49:49Z","git_url":"git://github.com/jicailiu/xbox-live-trace-analyzer.git","ssh_url":"[email protected]:jicailiu/xbox-live-trace-analyzer.git","clone_url":"https://github.com/jicailiu/xbox-live-trace-analyzer.git","svn_url":"https://github.com/jicailiu/xbox-live-trace-analyzer","homepage":"","size":5857,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"7291da8ffbd6d5c887f7e2efac190e0651ee9b92","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":74621487,"name":"xbox-live-trace-analyzer","full_name":"Microsoft/xbox-live-trace-analyzer","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/xbox-live-trace-analyzer","description":"The Xbox Live Trace Analyzer tool ensures your title is using Xbox Live Services in an optimal fashion. Generate usage logs for your title as described in the Analyze Calls to Xbox Live Services article, and then run this tool to view statistics about repeated calls, burst calls, and more. ","fork":false,"url":"https://api.github.com/repos/Microsoft/xbox-live-trace-analyzer","forks_url":"https://api.github.com/repos/Microsoft/xbox-live-trace-analyzer/forks","keys_url":"https://api.github.com/repos/Microsoft/xbox-live-trace-analyzer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/xbox-live-trace-analyzer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/xbox-live-trace-analyzer/teams","hooks_url":"https://api.github.com/repos/Microsoft/xbox-live-trace-analyzer/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/xbox-live-trace-analyzer/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/xbox-live-trace-analyzer/events","assignees_url":"https://api.github.com/repos/Microsoft/xbox-live-trace-analyzer/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/xbox-live-trace-analyzer/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/xbox-live-trace-analyzer/tags","blobs_url":"https://api.github.com/repos/Microsoft/xbox-live-trace-analyzer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/xbox-live-trace-analyzer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/xbox-live-trace-analyzer/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/xbox-live-trace-analyzer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/xbox-live-trace-analyzer/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/xbox-live-trace-analyzer/languages","stargazers_url":"https://api.github.com/repos/Microsoft/xbox-live-trace-analyzer/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/xbox-live-trace-analyzer/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/xbox-live-trace-analyzer/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/xbox-live-trace-analyzer/subscription","commits_url":"https://api.github.com/repos/Microsoft/xbox-live-trace-analyzer/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/xbox-live-trace-analyzer/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/xbox-live-trace-analyzer/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/xbox-live-trace-analyzer/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/xbox-live-trace-analyzer/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/xbox-live-trace-analyzer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/xbox-live-trace-analyzer/merges","archive_url":"https://api.github.com/repos/Microsoft/xbox-live-trace-analyzer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/xbox-live-trace-analyzer/downloads","issues_url":"https://api.github.com/repos/Microsoft/xbox-live-trace-analyzer/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/xbox-live-trace-analyzer/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/xbox-live-trace-analyzer/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/xbox-live-trace-analyzer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/xbox-live-trace-analyzer/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/xbox-live-trace-analyzer/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/xbox-live-trace-analyzer/deployments","created_at":"2016-11-23T23:21:08Z","updated_at":"2017-07-21T21:24:01Z","pushed_at":"2018-03-14T18:50:14Z","git_url":"git://github.com/Microsoft/xbox-live-trace-analyzer.git","ssh_url":"[email protected]:Microsoft/xbox-live-trace-analyzer.git","clone_url":"https://github.com/Microsoft/xbox-live-trace-analyzer.git","svn_url":"https://github.com/Microsoft/xbox-live-trace-analyzer","homepage":"","size":5678,"stargazers_count":6,"watchers_count":6,"language":"C#","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":9,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":9,"open_issues":1,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/xbox-live-trace-analyzer/pulls/17"},"html":{"href":"https://github.com/Microsoft/xbox-live-trace-analyzer/pull/17"},"issue":{"href":"https://api.github.com/repos/Microsoft/xbox-live-trace-analyzer/issues/17"},"comments":{"href":"https://api.github.com/repos/Microsoft/xbox-live-trace-analyzer/issues/17/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/xbox-live-trace-analyzer/pulls/17/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/xbox-live-trace-analyzer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/xbox-live-trace-analyzer/pulls/17/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/xbox-live-trace-analyzer/statuses/35b2a43de3a04997be5f456195decbee6752db63"}},"author_association":"CONTRIBUTOR"}} | {
"id": 74621487,
"name": "Microsoft/xbox-live-trace-analyzer",
"url": "https://api.github.com/repos/Microsoft/xbox-live-trace-analyzer"
} | {
"id": 14947225,
"login": "jicailiu",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/14947225?",
"url": "https://api.github.com/users/jicailiu"
} | {
"id": 6154722,
"login": "Microsoft",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6154722?",
"url": "https://api.github.com/orgs/Microsoft"
} | 2018-03-15T19:43:02 | 7386947904 | {"actor":{"display_login":"jicailiu"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/react-native-windows/pulls/comments/182911740","pull_request_review_id":113809650,"id":182911740,"diff_hunk":"@@ -0,0 +1,424 @@\n+//\n+// This file is generated by ReactPackageGenerator.tt\n+//\n+// Copyright (c) Microsoft Corporation. All rights reserved.\n+// Licensed under the MIT License.\n+//\n+\n+using ReactNative.Bridge;\n+using ReactNative.Modules.Core;\n+using ReactNative.UIManager;\n+using System.Collections.Generic;\n+\n+namespace ReactNative\n+{\n+ class CoreModulesPackageWrapper : IReactPackage\n+ {\n+ private readonly IReactPackage _reactPackage;\n+\n+ public CoreModulesPackageWrapper(CoreModulesPackage reactPackage)\n+ {\n+ _reactPackage = reactPackage;\n+ }\n+\n+ public IReadOnlyList<INativeModule> CreateNativeModules(ReactContext reactContext)\n+ {\n+ var nativeModules = _reactPackage.CreateNativeModules(reactContext);\n+ return new List<INativeModule>\n+ {\n+ new DeviceEventManagerModuleWrapper((ReactNative.Modules.Core.DeviceEventManagerModule)nativeModules[0]),\n+ new DeviceInfoModuleWrapper((ReactNative.Modules.DeviceInfo.DeviceInfoModule)nativeModules[1]),\n+ new ExceptionsManagerModuleWrapper((ReactNative.Modules.Core.ExceptionsManagerModule)nativeModules[2]),\n+ new PlatformConstantsModuleWrapper((ReactNative.Modules.SystemInfo.PlatformConstantsModule)nativeModules[3]),\n+ new SourceCodeModuleWrapper((ReactNative.Modules.DevSupport.SourceCodeModule)nativeModules[4]),\n+ new TimingWrapper((ReactNative.Modules.Core.Timing)nativeModules[5]),\n+ new UIManagerModuleWrapper((ReactNative.UIManager.UIManagerModule)nativeModules[6]),\n+ };\n+ }\n+\n+ public IReadOnlyList<IViewManager> CreateViewManagers(ReactContext reactContext)\n+ {\n+ return _reactPackage.CreateViewManagers(reactContext);\n+ }\n+ class DeviceEventManagerModuleWrapper : NativeModuleWrapperBase<ReactNative.Modules.Core.DeviceEventManagerModule>\n+ {\n+ public DeviceEventManagerModuleWrapper(ReactNative.Modules.Core.DeviceEventManagerModule nativeModule)\n+ : base(nativeModule)\n+ {\n+ }\n+\n+ public override IReadOnlyDictionary<string, INativeMethod> Methods\n+ {\n+ get\n+ {\n+ return new Dictionary<string, INativeMethod>\n+ {\n+ {\n+ nameof(ReactNative.Modules.Core.DeviceEventManagerModule.invokeDefaultBackPressHandler),\n+ new NativeMethod(\"async\", (instance, args) =>\n+ Module.invokeDefaultBackPressHandler(\n+ )\n+ )\n+ },\n+ };\n+ }\n+ }\n+ }\n+ class DeviceInfoModuleWrapper : NativeModuleWrapperBase<ReactNative.Modules.DeviceInfo.DeviceInfoModule>\n+ {\n+ public DeviceInfoModuleWrapper(ReactNative.Modules.DeviceInfo.DeviceInfoModule nativeModule)\n+ : base(nativeModule)\n+ {\n+ }\n+\n+ public override IReadOnlyDictionary<string, INativeMethod> Methods\n+ {\n+ get\n+ {\n+ return new Dictionary<string, INativeMethod>\n+ {\n+ };\n+ }\n+ }\n+ }\n+ class ExceptionsManagerModuleWrapper : NativeModuleWrapperBase<ReactNative.Modules.Core.ExceptionsManagerModule>\n+ {\n+ public ExceptionsManagerModuleWrapper(ReactNative.Modules.Core.ExceptionsManagerModule nativeModule)\n+ : base(nativeModule)\n+ {\n+ }\n+\n+ public override IReadOnlyDictionary<string, INativeMethod> Methods\n+ {\n+ get\n+ {\n+ return new Dictionary<string, INativeMethod>\n+ {\n+ {\n+ nameof(ReactNative.Modules.Core.ExceptionsManagerModule.reportFatalException),\n+ new NativeMethod(\"async\", (instance, args) =>\n+ Module.reportFatalException(\n+ args[0].ToObject<System.String>(),\n+ (Newtonsoft.Json.Linq.JArray)args[1],\n+ args[2].ToObject<System.Int32>()\n+ )\n+ )\n+ },\n+ {\n+ nameof(ReactNative.Modules.Core.ExceptionsManagerModule.reportSoftException),\n+ new NativeMethod(\"async\", (instance, args) =>\n+ Module.reportSoftException(\n+ args[0].ToObject<System.String>(),\n+ (Newtonsoft.Json.Linq.JArray)args[1],\n+ args[2].ToObject<System.Int32>()\n+ )\n+ )\n+ },\n+ {\n+ nameof(ReactNative.Modules.Core.ExceptionsManagerModule.updateExceptionMessage),\n+ new NativeMethod(\"async\", (instance, args) =>\n+ Module.updateExceptionMessage(\n+ args[0].ToObject<System.String>(),\n+ (Newtonsoft.Json.Linq.JArray)args[1],\n+ args[2].ToObject<System.Int32>()\n+ )\n+ )\n+ },\n+ {\n+ nameof(ReactNative.Modules.Core.ExceptionsManagerModule.dismissRedbox),\n+ new NativeMethod(\"async\", (instance, args) =>\n+ Module.dismissRedbox(\n+ )\n+ )\n+ },\n+ };\n+ }\n+ }\n+ }\n+ class PlatformConstantsModuleWrapper : NativeModuleWrapperBase<ReactNative.Modules.SystemInfo.PlatformConstantsModule>\n+ {\n+ public PlatformConstantsModuleWrapper(ReactNative.Modules.SystemInfo.PlatformConstantsModule nativeModule)\n+ : base(nativeModule)\n+ {\n+ }\n+\n+ public override IReadOnlyDictionary<string, INativeMethod> Methods\n+ {\n+ get\n+ {\n+ return new Dictionary<string, INativeMethod>\n+ {\n+ };\n+ }\n+ }\n+ }\n+ class SourceCodeModuleWrapper : NativeModuleWrapperBase<ReactNative.Modules.DevSupport.SourceCodeModule>\n+ {\n+ public SourceCodeModuleWrapper(ReactNative.Modules.DevSupport.SourceCodeModule nativeModule)\n+ : base(nativeModule)\n+ {\n+ }\n+\n+ public override IReadOnlyDictionary<string, INativeMethod> Methods\n+ {\n+ get\n+ {\n+ return new Dictionary<string, INativeMethod>\n+ {\n+ {\n+ nameof(ReactNative.Modules.DevSupport.SourceCodeModule.getScriptText),\n+ new NativeMethod(\"promise\", (instance, args) =>\n+ Module.getScriptText(\n+ new Promise(\n+ new Callback(args[0].ToObject<int>(), instance),\n+ new Callback(args[1].ToObject<int>(), instance)\n+ )\n+ )\n+ )\n+ },\n+ };\n+ }\n+ }\n+ }\n+ class TimingWrapper : NativeModuleWrapperBase<ReactNative.Modules.Core.Timing>\n+ {\n+ public TimingWrapper(ReactNative.Modules.Core.Timing nativeModule)\n+ : base(nativeModule)\n+ {\n+ }\n+\n+ public override IReadOnlyDictionary<string, INativeMethod> Methods\n+ {\n+ get\n+ {\n+ return new Dictionary<string, INativeMethod>\n+ {\n+ {\n+ nameof(ReactNative.Modules.Core.Timing.createTimer),\n+ new NativeMethod(\"async\", (instance, args) =>\n+ Module.createTimer(\n+ args[0].ToObject<System.Int32>(),\n+ args[1].ToObject<System.Int32>(),\n+ args[2].ToObject<System.Double>(),\n+ args[3].ToObject<System.Boolean>()\n+ )\n+ )\n+ },\n+ {\n+ nameof(ReactNative.Modules.Core.Timing.deleteTimer),\n+ new NativeMethod(\"async\", (instance, args) =>\n+ Module.deleteTimer(\n+ args[0].ToObject<System.Int32>()\n+ )\n+ )\n+ },\n+ {\n+ nameof(ReactNative.Modules.Core.Timing.setSendIdleEvents),\n+ new NativeMethod(\"async\", (instance, args) =>\n+ Module.setSendIdleEvents(\n+ args[0].ToObject<System.Boolean>()\n+ )\n+ )\n+ },\n+ };\n+ }\n+ }\n+ }\n+ class UIManagerModuleWrapper : NativeModuleWrapperBase<ReactNative.UIManager.UIManagerModule>\n+ {\n+ public UIManagerModuleWrapper(ReactNative.UIManager.UIManagerModule nativeModule)\n+ : base(nativeModule)\n+ {\n+ }\n+\n+ public override IReadOnlyDictionary<string, INativeMethod> Methods\n+ {\n+ get\n+ {\n+ return new Dictionary<string, INativeMethod>\n+ {\n+ {\n+ nameof(ReactNative.UIManager.UIManagerModule.removeRootView),\n+ new NativeMethod(\"async\", (instance, args) =>\n+ Module.removeRootView(\n+ args[0].ToObject<System.Int32>()\n+ )\n+ )\n+ },\n+ {\n+ nameof(ReactNative.UIManager.UIManagerModule.createView),\n+ new NativeMethod(\"async\", (instance, args) =>\n+ Module.createView(\n+ args[0].ToObject<System.Int32>(),\n+ args[1].ToObject<System.String>(),\n+ args[2].ToObject<System.Int32>(),\n+ (Newtonsoft.Json.Linq.JObject)args[3]\n+ )\n+ )\n+ },\n+ {\n+ nameof(ReactNative.UIManager.UIManagerModule.updateView),\n+ new NativeMethod(\"async\", (instance, args) =>\n+ Module.updateView(\n+ args[0].ToObject<System.Int32>(),\n+ args[1].ToObject<System.String>(),\n+ (Newtonsoft.Json.Linq.JObject)args[2]\n+ )\n+ )\n+ },\n+ {\n+ nameof(ReactNative.UIManager.UIManagerModule.manageChildren),\n+ new NativeMethod(\"async\", (instance, args) =>\n+ Module.manageChildren(\n+ args[0].ToObject<System.Int32>(),\n+ args[1].ToObject<System.Int32[]>(),\n+ args[2].ToObject<System.Int32[]>(),\n+ args[3].ToObject<System.Int32[]>(),\n+ args[4].ToObject<System.Int32[]>(),\n+ args[5].ToObject<System.Int32[]>()\n+ )\n+ )\n+ },\n+ {\n+ nameof(ReactNative.UIManager.UIManagerModule.setChildren),\n+ new NativeMethod(\"async\", (instance, args) =>\n+ Module.setChildren(\n+ args[0].ToObject<System.Int32>(),\n+ args[1].ToObject<System.Int32[]>()\n+ )\n+ )\n+ },\n+ {\n+ nameof(ReactNative.UIManager.UIManagerModule.replaceExistingNonRootView),\n+ new NativeMethod(\"async\", (instance, args) =>\n+ Module.replaceExistingNonRootView(\n+ args[0].ToObject<System.Int32>(),\n+ args[1].ToObject<System.Int32>()\n+ )\n+ )\n+ },\n+ {\n+ nameof(ReactNative.UIManager.UIManagerModule.removeSubviewsFromContainerWithID),\n+ new NativeMethod(\"async\", (instance, args) =>\n+ Module.removeSubviewsFromContainerWithID(\n+ args[0].ToObject<System.Int32>()\n+ )\n+ )\n+ },\n+ {\n+ nameof(ReactNative.UIManager.UIManagerModule.measure),\n+ new NativeMethod(\"async\", (instance, args) =>\n+ Module.measure(\n+ args[0].ToObject<System.Int32>(),\n+ new Callback(args[1].ToObject<int>(), instance)\n+ )\n+ )\n+ },\n+ {\n+ nameof(ReactNative.UIManager.UIManagerModule.measureInWindow),\n+ new NativeMethod(\"async\", (instance, args) =>\n+ Module.measureInWindow(\n+ args[0].ToObject<System.Int32>(),\n+ new Callback(args[1].ToObject<int>(), instance)\n+ )\n+ )\n+ },\n+ {\n+ nameof(ReactNative.UIManager.UIManagerModule.measureLayout),\n+ new NativeMethod(\"async\", (instance, args) =>\n+ Module.measureLayout(\n+ args[0].ToObject<System.Int32>(),\n+ args[1].ToObject<System.Int32>(),\n+ new Callback(args[2].ToObject<int>(), instance),\n+ new Callback(args[3].ToObject<int>(), instance)\n+ )\n+ )\n+ },\n+ {\n+ nameof(ReactNative.UIManager.UIManagerModule.measureLayoutRelativeToParent),\n+ new NativeMethod(\"async\", (instance, args) =>\n+ Module.measureLayoutRelativeToParent(\n+ args[0].ToObject<System.Int32>(),\n+ new Callback(args[1].ToObject<int>(), instance),\n+ new Callback(args[2].ToObject<int>(), instance)\n+ )\n+ )\n+ },\n+ {\n+ nameof(ReactNative.UIManager.UIManagerModule.findSubviewIn),\n+ new NativeMethod(\"async\", (instance, args) =>\n+ Module.findSubviewIn(\n+ args[0].ToObject<System.Int32>(),\n+ (Newtonsoft.Json.Linq.JArray)args[1],\n+ new Callback(args[2].ToObject<int>(), instance)\n+ )\n+ )\n+ },\n+ {\n+ nameof(ReactNative.UIManager.UIManagerModule.setJSResponder),\n+ new NativeMethod(\"async\", (instance, args) =>\n+ Module.setJSResponder(\n+ args[0].ToObject<System.Int32>(),\n+ args[1].ToObject<System.Boolean>()\n+ )\n+ )\n+ },\n+ {\n+ nameof(ReactNative.UIManager.UIManagerModule.clearJSResponder),\n+ new NativeMethod(\"async\", (instance, args) =>\n+ Module.clearJSResponder(\n+ )\n+ )\n+ },\n+ {\n+ nameof(ReactNative.UIManager.UIManagerModule.dispatchViewManagerCommand),\n+ new NativeMethod(\"async\", (instance, args) =>\n+ Module.dispatchViewManagerCommand(\n+ args[0].ToObject<System.Int32>(),\n+ args[1].ToObject<System.Int32>(),\n+ (Newtonsoft.Json.Linq.JArray)args[2]","path":"ReactWindows/ReactNative.Shared/CoreModulesPackageWrapper.cs","position":379,"original_position":379,"commit_id":"38f10665e1d54ffc5fea22ca63488aced7219302","original_commit_id":"38f10665e1d54ffc5fea22ca63488aced7219302","user":{"login":"antonkh","id":17773180,"avatar_url":"https://avatars2.githubusercontent.com/u/17773180?v=4","gravatar_id":"","url":"https://api.github.com/users/antonkh","html_url":"https://github.com/antonkh","followers_url":"https://api.github.com/users/antonkh/followers","following_url":"https://api.github.com/users/antonkh/following{/other_user}","gists_url":"https://api.github.com/users/antonkh/gists{/gist_id}","starred_url":"https://api.github.com/users/antonkh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antonkh/subscriptions","organizations_url":"https://api.github.com/users/antonkh/orgs","repos_url":"https://api.github.com/users/antonkh/repos","events_url":"https://api.github.com/users/antonkh/events{/privacy}","received_events_url":"https://api.github.com/users/antonkh/received_events","type":"User","site_admin":false},"body":"`args[2]` can be null","created_at":"2018-04-19T23:24:32Z","updated_at":"2018-04-19T23:26:56Z","html_url":"https://github.com/Microsoft/react-native-windows/pull/1788#discussion_r182911740","pull_request_url":"https://api.github.com/repos/Microsoft/react-native-windows/pulls/1788","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/react-native-windows/pulls/comments/182911740"},"html":{"href":"https://github.com/Microsoft/react-native-windows/pull/1788#discussion_r182911740"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/react-native-windows/pulls/1788"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/react-native-windows/pulls/1788","id":182656832,"html_url":"https://github.com/Microsoft/react-native-windows/pull/1788","diff_url":"https://github.com/Microsoft/react-native-windows/pull/1788.diff","patch_url":"https://github.com/Microsoft/react-native-windows/pull/1788.patch","issue_url":"https://api.github.com/repos/Microsoft/react-native-windows/issues/1788","number":1788,"state":"open","locked":false,"title":"Core wrapper","user":{"login":"rozele","id":1106239,"avatar_url":"https://avatars0.githubusercontent.com/u/1106239?v=4","gravatar_id":"","url":"https://api.github.com/users/rozele","html_url":"https://github.com/rozele","followers_url":"https://api.github.com/users/rozele/followers","following_url":"https://api.github.com/users/rozele/following{/other_user}","gists_url":"https://api.github.com/users/rozele/gists{/gist_id}","starred_url":"https://api.github.com/users/rozele/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rozele/subscriptions","organizations_url":"https://api.github.com/users/rozele/orgs","repos_url":"https://api.github.com/users/rozele/repos","events_url":"https://api.github.com/users/rozele/events{/privacy}","received_events_url":"https://api.github.com/users/rozele/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-04-19T03:27:33Z","updated_at":"2018-04-19T23:26:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7585283cc467faa96c61f25ab705bb60d5959e98","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/react-native-windows/pulls/1788/commits","review_comments_url":"https://api.github.com/repos/Microsoft/react-native-windows/pulls/1788/comments","review_comment_url":"https://api.github.com/repos/Microsoft/react-native-windows/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/react-native-windows/issues/1788/comments","statuses_url":"https://api.github.com/repos/Microsoft/react-native-windows/statuses/38f10665e1d54ffc5fea22ca63488aced7219302","head":{"label":"rozele:coreWrapper","ref":"coreWrapper","sha":"38f10665e1d54ffc5fea22ca63488aced7219302","user":{"login":"rozele","id":1106239,"avatar_url":"https://avatars0.githubusercontent.com/u/1106239?v=4","gravatar_id":"","url":"https://api.github.com/users/rozele","html_url":"https://github.com/rozele","followers_url":"https://api.github.com/users/rozele/followers","following_url":"https://api.github.com/users/rozele/following{/other_user}","gists_url":"https://api.github.com/users/rozele/gists{/gist_id}","starred_url":"https://api.github.com/users/rozele/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rozele/subscriptions","organizations_url":"https://api.github.com/users/rozele/orgs","repos_url":"https://api.github.com/users/rozele/repos","events_url":"https://api.github.com/users/rozele/events{/privacy}","received_events_url":"https://api.github.com/users/rozele/received_events","type":"User","site_admin":false},"repo":{"id":59683079,"name":"react-native-windows","full_name":"rozele/react-native-windows","owner":{"login":"rozele","id":1106239,"avatar_url":"https://avatars0.githubusercontent.com/u/1106239?v=4","gravatar_id":"","url":"https://api.github.com/users/rozele","html_url":"https://github.com/rozele","followers_url":"https://api.github.com/users/rozele/followers","following_url":"https://api.github.com/users/rozele/following{/other_user}","gists_url":"https://api.github.com/users/rozele/gists{/gist_id}","starred_url":"https://api.github.com/users/rozele/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rozele/subscriptions","organizations_url":"https://api.github.com/users/rozele/orgs","repos_url":"https://api.github.com/users/rozele/repos","events_url":"https://api.github.com/users/rozele/events{/privacy}","received_events_url":"https://api.github.com/users/rozele/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rozele/react-native-windows","description":"A framework for building native apps with React.","fork":true,"url":"https://api.github.com/repos/rozele/react-native-windows","forks_url":"https://api.github.com/repos/rozele/react-native-windows/forks","keys_url":"https://api.github.com/repos/rozele/react-native-windows/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rozele/react-native-windows/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rozele/react-native-windows/teams","hooks_url":"https://api.github.com/repos/rozele/react-native-windows/hooks","issue_events_url":"https://api.github.com/repos/rozele/react-native-windows/issues/events{/number}","events_url":"https://api.github.com/repos/rozele/react-native-windows/events","assignees_url":"https://api.github.com/repos/rozele/react-native-windows/assignees{/user}","branches_url":"https://api.github.com/repos/rozele/react-native-windows/branches{/branch}","tags_url":"https://api.github.com/repos/rozele/react-native-windows/tags","blobs_url":"https://api.github.com/repos/rozele/react-native-windows/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rozele/react-native-windows/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rozele/react-native-windows/git/refs{/sha}","trees_url":"https://api.github.com/repos/rozele/react-native-windows/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rozele/react-native-windows/statuses/{sha}","languages_url":"https://api.github.com/repos/rozele/react-native-windows/languages","stargazers_url":"https://api.github.com/repos/rozele/react-native-windows/stargazers","contributors_url":"https://api.github.com/repos/rozele/react-native-windows/contributors","subscribers_url":"https://api.github.com/repos/rozele/react-native-windows/subscribers","subscription_url":"https://api.github.com/repos/rozele/react-native-windows/subscription","commits_url":"https://api.github.com/repos/rozele/react-native-windows/commits{/sha}","git_commits_url":"https://api.github.com/repos/rozele/react-native-windows/git/commits{/sha}","comments_url":"https://api.github.com/repos/rozele/react-native-windows/comments{/number}","issue_comment_url":"https://api.github.com/repos/rozele/react-native-windows/issues/comments{/number}","contents_url":"https://api.github.com/repos/rozele/react-native-windows/contents/{+path}","compare_url":"https://api.github.com/repos/rozele/react-native-windows/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rozele/react-native-windows/merges","archive_url":"https://api.github.com/repos/rozele/react-native-windows/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rozele/react-native-windows/downloads","issues_url":"https://api.github.com/repos/rozele/react-native-windows/issues{/number}","pulls_url":"https://api.github.com/repos/rozele/react-native-windows/pulls{/number}","milestones_url":"https://api.github.com/repos/rozele/react-native-windows/milestones{/number}","notifications_url":"https://api.github.com/repos/rozele/react-native-windows/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rozele/react-native-windows/labels{/name}","releases_url":"https://api.github.com/repos/rozele/react-native-windows/releases{/id}","deployments_url":"https://api.github.com/repos/rozele/react-native-windows/deployments","created_at":"2016-05-25T17:20:35Z","updated_at":"2017-05-30T23:06:27Z","pushed_at":"2018-04-19T03:27:09Z","git_url":"git://github.com/rozele/react-native-windows.git","ssh_url":"[email protected]:rozele/react-native-windows.git","clone_url":"https://github.com/rozele/react-native-windows.git","svn_url":"https://github.com/rozele/react-native-windows","homepage":"http://facebook.github.io/react-native/","size":147832,"stargazers_count":2,"watchers_count":2,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":2,"watchers":2,"default_branch":"ReactWindows"}},"base":{"label":"Microsoft:master","ref":"master","sha":"179f6f6dac04cc7b4a31538445d43340da557903","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":48009214,"name":"react-native-windows","full_name":"Microsoft/react-native-windows","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/react-native-windows","description":"A framework for building native UWP and WPF apps with React.","fork":false,"url":"https://api.github.com/repos/Microsoft/react-native-windows","forks_url":"https://api.github.com/repos/Microsoft/react-native-windows/forks","keys_url":"https://api.github.com/repos/Microsoft/react-native-windows/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/react-native-windows/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/react-native-windows/teams","hooks_url":"https://api.github.com/repos/Microsoft/react-native-windows/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/react-native-windows/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/react-native-windows/events","assignees_url":"https://api.github.com/repos/Microsoft/react-native-windows/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/react-native-windows/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/react-native-windows/tags","blobs_url":"https://api.github.com/repos/Microsoft/react-native-windows/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/react-native-windows/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/react-native-windows/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/react-native-windows/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/react-native-windows/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/react-native-windows/languages","stargazers_url":"https://api.github.com/repos/Microsoft/react-native-windows/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/react-native-windows/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/react-native-windows/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/react-native-windows/subscription","commits_url":"https://api.github.com/repos/Microsoft/react-native-windows/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/react-native-windows/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/react-native-windows/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/react-native-windows/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/react-native-windows/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/react-native-windows/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/react-native-windows/merges","archive_url":"https://api.github.com/repos/Microsoft/react-native-windows/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/react-native-windows/downloads","issues_url":"https://api.github.com/repos/Microsoft/react-native-windows/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/react-native-windows/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/react-native-windows/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/react-native-windows/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/react-native-windows/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/react-native-windows/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/react-native-windows/deployments","created_at":"2015-12-15T00:16:54Z","updated_at":"2018-04-19T19:50:28Z","pushed_at":"2018-04-19T23:24:34Z","git_url":"git://github.com/Microsoft/react-native-windows.git","ssh_url":"[email protected]:Microsoft/react-native-windows.git","clone_url":"https://github.com/Microsoft/react-native-windows.git","svn_url":"https://github.com/Microsoft/react-native-windows","homepage":"http://facebook.github.io/react-native/","size":160318,"stargazers_count":3838,"watchers_count":3838,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":330,"mirror_url":null,"archived":false,"open_issues_count":282,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":330,"open_issues":282,"watchers":3838,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/react-native-windows/pulls/1788"},"html":{"href":"https://github.com/Microsoft/react-native-windows/pull/1788"},"issue":{"href":"https://api.github.com/repos/Microsoft/react-native-windows/issues/1788"},"comments":{"href":"https://api.github.com/repos/Microsoft/react-native-windows/issues/1788/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/react-native-windows/pulls/1788/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/react-native-windows/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/react-native-windows/pulls/1788/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/react-native-windows/statuses/38f10665e1d54ffc5fea22ca63488aced7219302"}},"author_association":"MEMBER"}} | {
"id": 48009214,
"name": "Microsoft/react-native-windows",
"url": "https://api.github.com/repos/Microsoft/react-native-windows"
} | {
"id": 17773180,
"login": "antonkh",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/17773180?",
"url": "https://api.github.com/users/antonkh"
} | {
"id": 6154722,
"login": "Microsoft",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6154722?",
"url": "https://api.github.com/orgs/Microsoft"
} | 2018-04-19T23:24:32 | 7558687678 | {"actor":{"display_login":"antonkh"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/resin-io/resin-sdk/pulls/comments/188295917","pull_request_review_id":120223809,"id":188295917,"diff_hunk":"@@ -971,6 +985,159 @@ getDeviceModel = (deps, opts) ->\n \t\t.catch(notFoundResponse, treatAsMissingDevice(uuidOrId))\n \t\t.asCallback(callback)\n \n+\t###*\n+\t# @summary Start service on device","path":"lib/models/device.coffee","position":47,"original_position":47,"commit_id":"cae1f68d73a31e9cf76c2d7f933fae737d5f0982","original_commit_id":"cae1f68d73a31e9cf76c2d7f933fae737d5f0982","user":{"login":"thgreasi","id":1295829,"avatar_url":"https://avatars0.githubusercontent.com/u/1295829?v=4","gravatar_id":"","url":"https://api.github.com/users/thgreasi","html_url":"https://github.com/thgreasi","followers_url":"https://api.github.com/users/thgreasi/followers","following_url":"https://api.github.com/users/thgreasi/following{/other_user}","gists_url":"https://api.github.com/users/thgreasi/gists{/gist_id}","starred_url":"https://api.github.com/users/thgreasi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thgreasi/subscriptions","organizations_url":"https://api.github.com/users/thgreasi/orgs","repos_url":"https://api.github.com/users/thgreasi/repos","events_url":"https://api.github.com/users/thgreasi/events{/privacy}","received_events_url":"https://api.github.com/users/thgreasi/received_events","type":"User","site_admin":false},"body":"NIT: How about `Start a service on a device`?","created_at":"2018-05-15T13:55:03Z","updated_at":"2018-05-15T14:03:07Z","html_url":"https://github.com/resin-io/resin-sdk/pull/509#discussion_r188295917","pull_request_url":"https://api.github.com/repos/resin-io/resin-sdk/pulls/509","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/resin-io/resin-sdk/pulls/comments/188295917"},"html":{"href":"https://github.com/resin-io/resin-sdk/pull/509#discussion_r188295917"},"pull_request":{"href":"https://api.github.com/repos/resin-io/resin-sdk/pulls/509"}}},"pull_request":{"url":"https://api.github.com/repos/resin-io/resin-sdk/pulls/509","id":187521966,"html_url":"https://github.com/resin-io/resin-sdk/pull/509","diff_url":"https://github.com/resin-io/resin-sdk/pull/509.diff","patch_url":"https://github.com/resin-io/resin-sdk/pull/509.patch","issue_url":"https://api.github.com/repos/resin-io/resin-sdk/issues/509","number":509,"state":"open","locked":false,"title":"Update supervisor methods to handle MC supervisor changes","user":{"login":"pimterry","id":1526883,"avatar_url":"https://avatars0.githubusercontent.com/u/1526883?v=4","gravatar_id":"","url":"https://api.github.com/users/pimterry","html_url":"https://github.com/pimterry","followers_url":"https://api.github.com/users/pimterry/followers","following_url":"https://api.github.com/users/pimterry/following{/other_user}","gists_url":"https://api.github.com/users/pimterry/gists{/gist_id}","starred_url":"https://api.github.com/users/pimterry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pimterry/subscriptions","organizations_url":"https://api.github.com/users/pimterry/orgs","repos_url":"https://api.github.com/users/pimterry/repos","events_url":"https://api.github.com/users/pimterry/events{/privacy}","received_events_url":"https://api.github.com/users/pimterry/received_events","type":"User","site_admin":false},"body":"Also removed an existing deprecated method - if we're breaking things, might as well clean up a bit.","created_at":"2018-05-11T17:19:02Z","updated_at":"2018-05-15T14:03:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1998303447534921c3807d4f9e9a4b5acdb201f4","assignee":null,"assignees":[],"requested_reviewers":[{"login":"dimitrisnl","id":4951004,"avatar_url":"https://avatars2.githubusercontent.com/u/4951004?v=4","gravatar_id":"","url":"https://api.github.com/users/dimitrisnl","html_url":"https://github.com/dimitrisnl","followers_url":"https://api.github.com/users/dimitrisnl/followers","following_url":"https://api.github.com/users/dimitrisnl/following{/other_user}","gists_url":"https://api.github.com/users/dimitrisnl/gists{/gist_id}","starred_url":"https://api.github.com/users/dimitrisnl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dimitrisnl/subscriptions","organizations_url":"https://api.github.com/users/dimitrisnl/orgs","repos_url":"https://api.github.com/users/dimitrisnl/repos","events_url":"https://api.github.com/users/dimitrisnl/events{/privacy}","received_events_url":"https://api.github.com/users/dimitrisnl/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/resin-io/resin-sdk/pulls/509/commits","review_comments_url":"https://api.github.com/repos/resin-io/resin-sdk/pulls/509/comments","review_comment_url":"https://api.github.com/repos/resin-io/resin-sdk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/resin-io/resin-sdk/issues/509/comments","statuses_url":"https://api.github.com/repos/resin-io/resin-sdk/statuses/cae1f68d73a31e9cf76c2d7f933fae737d5f0982","head":{"label":"resin-io:mc-supervisor","ref":"mc-supervisor","sha":"cae1f68d73a31e9cf76c2d7f933fae737d5f0982","user":{"login":"resin-io","id":6157842,"avatar_url":"https://avatars1.githubusercontent.com/u/6157842?v=4","gravatar_id":"","url":"https://api.github.com/users/resin-io","html_url":"https://github.com/resin-io","followers_url":"https://api.github.com/users/resin-io/followers","following_url":"https://api.github.com/users/resin-io/following{/other_user}","gists_url":"https://api.github.com/users/resin-io/gists{/gist_id}","starred_url":"https://api.github.com/users/resin-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/resin-io/subscriptions","organizations_url":"https://api.github.com/users/resin-io/orgs","repos_url":"https://api.github.com/users/resin-io/repos","events_url":"https://api.github.com/users/resin-io/events{/privacy}","received_events_url":"https://api.github.com/users/resin-io/received_events","type":"Organization","site_admin":false},"repo":{"id":29677279,"name":"resin-sdk","full_name":"resin-io/resin-sdk","owner":{"login":"resin-io","id":6157842,"avatar_url":"https://avatars1.githubusercontent.com/u/6157842?v=4","gravatar_id":"","url":"https://api.github.com/users/resin-io","html_url":"https://github.com/resin-io","followers_url":"https://api.github.com/users/resin-io/followers","following_url":"https://api.github.com/users/resin-io/following{/other_user}","gists_url":"https://api.github.com/users/resin-io/gists{/gist_id}","starred_url":"https://api.github.com/users/resin-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/resin-io/subscriptions","organizations_url":"https://api.github.com/users/resin-io/orgs","repos_url":"https://api.github.com/users/resin-io/repos","events_url":"https://api.github.com/users/resin-io/events{/privacy}","received_events_url":"https://api.github.com/users/resin-io/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/resin-io/resin-sdk","description":"The SDK to make Resin.io powered JavaScript applications.","fork":false,"url":"https://api.github.com/repos/resin-io/resin-sdk","forks_url":"https://api.github.com/repos/resin-io/resin-sdk/forks","keys_url":"https://api.github.com/repos/resin-io/resin-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/resin-io/resin-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/resin-io/resin-sdk/teams","hooks_url":"https://api.github.com/repos/resin-io/resin-sdk/hooks","issue_events_url":"https://api.github.com/repos/resin-io/resin-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/resin-io/resin-sdk/events","assignees_url":"https://api.github.com/repos/resin-io/resin-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/resin-io/resin-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/resin-io/resin-sdk/tags","blobs_url":"https://api.github.com/repos/resin-io/resin-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/resin-io/resin-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/resin-io/resin-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/resin-io/resin-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/resin-io/resin-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/resin-io/resin-sdk/languages","stargazers_url":"https://api.github.com/repos/resin-io/resin-sdk/stargazers","contributors_url":"https://api.github.com/repos/resin-io/resin-sdk/contributors","subscribers_url":"https://api.github.com/repos/resin-io/resin-sdk/subscribers","subscription_url":"https://api.github.com/repos/resin-io/resin-sdk/subscription","commits_url":"https://api.github.com/repos/resin-io/resin-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/resin-io/resin-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/resin-io/resin-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/resin-io/resin-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/resin-io/resin-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/resin-io/resin-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/resin-io/resin-sdk/merges","archive_url":"https://api.github.com/repos/resin-io/resin-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/resin-io/resin-sdk/downloads","issues_url":"https://api.github.com/repos/resin-io/resin-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/resin-io/resin-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/resin-io/resin-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/resin-io/resin-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/resin-io/resin-sdk/labels{/name}","releases_url":"https://api.github.com/repos/resin-io/resin-sdk/releases{/id}","deployments_url":"https://api.github.com/repos/resin-io/resin-sdk/deployments","created_at":"2015-01-22T12:15:25Z","updated_at":"2018-05-09T14:53:08Z","pushed_at":"2018-05-15T13:31:10Z","git_url":"git://github.com/resin-io/resin-sdk.git","ssh_url":"[email protected]:resin-io/resin-sdk.git","clone_url":"https://github.com/resin-io/resin-sdk.git","svn_url":"https://github.com/resin-io/resin-sdk","homepage":"https://resin.io","size":8208,"stargazers_count":59,"watchers_count":59,"language":"CoffeeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"archived":false,"open_issues_count":56,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":16,"open_issues":56,"watchers":59,"default_branch":"master"}},"base":{"label":"resin-io:multicontainer","ref":"multicontainer","sha":"2968686acb72b83367f983513fd07f1ce80a7f28","user":{"login":"resin-io","id":6157842,"avatar_url":"https://avatars1.githubusercontent.com/u/6157842?v=4","gravatar_id":"","url":"https://api.github.com/users/resin-io","html_url":"https://github.com/resin-io","followers_url":"https://api.github.com/users/resin-io/followers","following_url":"https://api.github.com/users/resin-io/following{/other_user}","gists_url":"https://api.github.com/users/resin-io/gists{/gist_id}","starred_url":"https://api.github.com/users/resin-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/resin-io/subscriptions","organizations_url":"https://api.github.com/users/resin-io/orgs","repos_url":"https://api.github.com/users/resin-io/repos","events_url":"https://api.github.com/users/resin-io/events{/privacy}","received_events_url":"https://api.github.com/users/resin-io/received_events","type":"Organization","site_admin":false},"repo":{"id":29677279,"name":"resin-sdk","full_name":"resin-io/resin-sdk","owner":{"login":"resin-io","id":6157842,"avatar_url":"https://avatars1.githubusercontent.com/u/6157842?v=4","gravatar_id":"","url":"https://api.github.com/users/resin-io","html_url":"https://github.com/resin-io","followers_url":"https://api.github.com/users/resin-io/followers","following_url":"https://api.github.com/users/resin-io/following{/other_user}","gists_url":"https://api.github.com/users/resin-io/gists{/gist_id}","starred_url":"https://api.github.com/users/resin-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/resin-io/subscriptions","organizations_url":"https://api.github.com/users/resin-io/orgs","repos_url":"https://api.github.com/users/resin-io/repos","events_url":"https://api.github.com/users/resin-io/events{/privacy}","received_events_url":"https://api.github.com/users/resin-io/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/resin-io/resin-sdk","description":"The SDK to make Resin.io powered JavaScript applications.","fork":false,"url":"https://api.github.com/repos/resin-io/resin-sdk","forks_url":"https://api.github.com/repos/resin-io/resin-sdk/forks","keys_url":"https://api.github.com/repos/resin-io/resin-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/resin-io/resin-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/resin-io/resin-sdk/teams","hooks_url":"https://api.github.com/repos/resin-io/resin-sdk/hooks","issue_events_url":"https://api.github.com/repos/resin-io/resin-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/resin-io/resin-sdk/events","assignees_url":"https://api.github.com/repos/resin-io/resin-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/resin-io/resin-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/resin-io/resin-sdk/tags","blobs_url":"https://api.github.com/repos/resin-io/resin-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/resin-io/resin-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/resin-io/resin-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/resin-io/resin-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/resin-io/resin-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/resin-io/resin-sdk/languages","stargazers_url":"https://api.github.com/repos/resin-io/resin-sdk/stargazers","contributors_url":"https://api.github.com/repos/resin-io/resin-sdk/contributors","subscribers_url":"https://api.github.com/repos/resin-io/resin-sdk/subscribers","subscription_url":"https://api.github.com/repos/resin-io/resin-sdk/subscription","commits_url":"https://api.github.com/repos/resin-io/resin-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/resin-io/resin-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/resin-io/resin-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/resin-io/resin-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/resin-io/resin-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/resin-io/resin-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/resin-io/resin-sdk/merges","archive_url":"https://api.github.com/repos/resin-io/resin-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/resin-io/resin-sdk/downloads","issues_url":"https://api.github.com/repos/resin-io/resin-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/resin-io/resin-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/resin-io/resin-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/resin-io/resin-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/resin-io/resin-sdk/labels{/name}","releases_url":"https://api.github.com/repos/resin-io/resin-sdk/releases{/id}","deployments_url":"https://api.github.com/repos/resin-io/resin-sdk/deployments","created_at":"2015-01-22T12:15:25Z","updated_at":"2018-05-09T14:53:08Z","pushed_at":"2018-05-15T13:31:10Z","git_url":"git://github.com/resin-io/resin-sdk.git","ssh_url":"[email protected]:resin-io/resin-sdk.git","clone_url":"https://github.com/resin-io/resin-sdk.git","svn_url":"https://github.com/resin-io/resin-sdk","homepage":"https://resin.io","size":8208,"stargazers_count":59,"watchers_count":59,"language":"CoffeeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"archived":false,"open_issues_count":56,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":16,"open_issues":56,"watchers":59,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/resin-io/resin-sdk/pulls/509"},"html":{"href":"https://github.com/resin-io/resin-sdk/pull/509"},"issue":{"href":"https://api.github.com/repos/resin-io/resin-sdk/issues/509"},"comments":{"href":"https://api.github.com/repos/resin-io/resin-sdk/issues/509/comments"},"review_comments":{"href":"https://api.github.com/repos/resin-io/resin-sdk/pulls/509/comments"},"review_comment":{"href":"https://api.github.com/repos/resin-io/resin-sdk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/resin-io/resin-sdk/pulls/509/commits"},"statuses":{"href":"https://api.github.com/repos/resin-io/resin-sdk/statuses/cae1f68d73a31e9cf76c2d7f933fae737d5f0982"}},"author_association":"MEMBER"}} | {
"id": 29677279,
"name": "resin-io/resin-sdk",
"url": "https://api.github.com/repos/resin-io/resin-sdk"
} | {
"id": 1295829,
"login": "thgreasi",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1295829?",
"url": "https://api.github.com/users/thgreasi"
} | {
"id": 6157842,
"login": "resin-io",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6157842?",
"url": "https://api.github.com/orgs/resin-io"
} | 2018-05-15T13:55:03 | 7677168398 | {"actor":{"display_login":"thgreasi"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/Mudlet/Mudlet/pulls/comments/241533353","pull_request_review_id":184831779,"id":241533353,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MTUzMzM1Mw==","diff_hunk":"@@ -1784,6 +1805,433 @@ int TTextEdit::getRowCount()\n return height() / rowHeight;\n }\n \n+inline QString TTextEdit::htmlCenter(const QString& text)\n+{\n+ return QStringLiteral(\"<center>%1</center>\").arg(text);\n+}\n+\n+// Not just whitespace but also some formatting and other things - it may be\n+// that some entries do not work like this and we cannot just display a short\n+// bit of text to indicate them in the analysis of the on-screen content- the\n+// language directional controls may be like that:\n+inline QString TTextEdit::convertWhiteSpaceToVisual(const QChar& first, const QChar& second)\n+{\n+ // clang-format off\n+ if (second.isNull()) {\n+ // The code point is on the BMP\n+ switch (first.unicode()) {\n+ case QChar::Tabulation: return htmlCenter(tr(\"{tab}\")); break;\n+ case QChar::LineFeed: return htmlCenter(tr(\"{lf}\")); break; // Not likely to be seen as it gets filtered out\n+ case QChar::CarriageReturn: return htmlCenter(tr(\"{cr}\")); break; // Not likely to be seen as it gets filtered out\n+ case QChar::Space: return htmlCenter(tr(\"{sp}\")); break;\n+ case QChar::Nbsp: return htmlCenter(tr(\"{nbsp}\")); break;\n+ case QChar::SoftHyphen: return htmlCenter(tr(\"{shyp}\")); break;\n+ case 0x034F: return htmlCenter(tr(\"{cgj}\")); break; // Combining Grapheme Joiner (badly named apparently)\n+ case 0x1680: return htmlCenter(tr(\"{osp}\")); break; // Ogham space mark\n+ case 0x2000: return htmlCenter(tr(\"{enqd}\")); break; // En quad\n+ case 0x2001: return htmlCenter(tr(\"{emqd}\")); break; // Em quad\n+ case 0x2002: return htmlCenter(tr(\"{ensp}\")); break; // En space\n+ case 0x2003: return htmlCenter(tr(\"{emsp}\")); break; // Em space\n+ case 0x2004: return htmlCenter(tr(\"{m3sp}\")); break; // Three-per-em (Thick) space","path":"src/TTextEdit.cpp","position":null,"original_position":66,"commit_id":"f613daa4785d9cdbd933dcb6a7d48cdd6aa2ef24","original_commit_id":"17bbc511a20933a4acfcbe6eb7ea11de620e98aa","user":{"login":"vadi2","id":110988,"node_id":"MDQ6VXNlcjExMDk4OA==","avatar_url":"https://avatars1.githubusercontent.com/u/110988?v=4","gravatar_id":"","url":"https://api.github.com/users/vadi2","html_url":"https://github.com/vadi2","followers_url":"https://api.github.com/users/vadi2/followers","following_url":"https://api.github.com/users/vadi2/following{/other_user}","gists_url":"https://api.github.com/users/vadi2/gists{/gist_id}","starred_url":"https://api.github.com/users/vadi2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vadi2/subscriptions","organizations_url":"https://api.github.com/users/vadi2/orgs","repos_url":"https://api.github.com/users/vadi2/repos","events_url":"https://api.github.com/users/vadi2/events{/privacy}","received_events_url":"https://api.github.com/users/vadi2/received_events","type":"User","site_admin":false},"body":"Okay!","created_at":"2018-12-13T19:32:26Z","updated_at":"2018-12-13T19:32:26Z","html_url":"https://github.com/Mudlet/Mudlet/pull/1579#discussion_r241533353","pull_request_url":"https://api.github.com/repos/Mudlet/Mudlet/pulls/1579","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Mudlet/Mudlet/pulls/comments/241533353"},"html":{"href":"https://github.com/Mudlet/Mudlet/pull/1579#discussion_r241533353"},"pull_request":{"href":"https://api.github.com/repos/Mudlet/Mudlet/pulls/1579"}},"in_reply_to_id":228408092},"pull_request":{"url":"https://api.github.com/repos/Mudlet/Mudlet/pulls/1579","id":174101577,"node_id":"MDExOlB1bGxSZXF1ZXN0MTc0MTAxNTc3","html_url":"https://github.com/Mudlet/Mudlet/pull/1579","diff_url":"https://github.com/Mudlet/Mudlet/pull/1579.diff","patch_url":"https://github.com/Mudlet/Mudlet/pull/1579.patch","issue_url":"https://api.github.com/repos/Mudlet/Mudlet/issues/1579","number":1579,"state":"open","locked":false,"title":"Add text analyser to consoles","user":{"login":"SlySven","id":6163092,"node_id":"MDQ6VXNlcjYxNjMwOTI=","avatar_url":"https://avatars3.githubusercontent.com/u/6163092?v=4","gravatar_id":"","url":"https://api.github.com/users/SlySven","html_url":"https://github.com/SlySven","followers_url":"https://api.github.com/users/SlySven/followers","following_url":"https://api.github.com/users/SlySven/following{/other_user}","gists_url":"https://api.github.com/users/SlySven/gists{/gist_id}","starred_url":"https://api.github.com/users/SlySven/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SlySven/subscriptions","organizations_url":"https://api.github.com/users/SlySven/orgs","repos_url":"https://api.github.com/users/SlySven/repos","events_url":"https://api.github.com/users/SlySven/events{/privacy}","received_events_url":"https://api.github.com/users/SlySven/received_events","type":"User","site_admin":false},"body":"This will allow the user to determine the exact characters present in a line of MUD (or locally generated) text which could be useful in working out what to use to construct triggers and also how the displayed characters are constructed in UTF-8 bytes. To use it the user should control click on a line of text in a console and then right click to bring up the context menu. By moving the cursor over the \"analyse characters\" action and hovering there a generated tool-tip will be brought up that contains HTML tables with the break down of Unicode code-points which is then broken down into the corresponding UTF-16 (which Qt uses internally to store all text in `QString`s) and UTF-8 which is what the Lua sub-system gets as its form of strings. For characters that are not on the Basic Multi-Plane and which thus need two `QChar`s (and thus UTF-16 surrogate pairs) to represent the pairs of UTF-16 values (in the range 0xD800 to 0xDBFF for the first, high surrogate followed by one in the range 0xDC00 to 0xDFFF for the second, low surrogate) those numbers are also displayed.\r\n\r\nNote: this works on (only) the whole first line of the selected text even if more than one line is selected - or only a fraction of that first line is selected. The context menu entry is NOT shown if there is no selection.\r\n\r\nSigned-off-by: Stephen Lyons <[email protected]>","created_at":"2018-03-09T20:31:31Z","updated_at":"2018-12-13T19:32:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"536000df30a3cb51f9f1eb50dbf1b768bf68e6a9","assignee":{"login":"SlySven","id":6163092,"node_id":"MDQ6VXNlcjYxNjMwOTI=","avatar_url":"https://avatars3.githubusercontent.com/u/6163092?v=4","gravatar_id":"","url":"https://api.github.com/users/SlySven","html_url":"https://github.com/SlySven","followers_url":"https://api.github.com/users/SlySven/followers","following_url":"https://api.github.com/users/SlySven/following{/other_user}","gists_url":"https://api.github.com/users/SlySven/gists{/gist_id}","starred_url":"https://api.github.com/users/SlySven/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SlySven/subscriptions","organizations_url":"https://api.github.com/users/SlySven/orgs","repos_url":"https://api.github.com/users/SlySven/repos","events_url":"https://api.github.com/users/SlySven/events{/privacy}","received_events_url":"https://api.github.com/users/SlySven/received_events","type":"User","site_admin":false},"assignees":[{"login":"SlySven","id":6163092,"node_id":"MDQ6VXNlcjYxNjMwOTI=","avatar_url":"https://avatars3.githubusercontent.com/u/6163092?v=4","gravatar_id":"","url":"https://api.github.com/users/SlySven","html_url":"https://github.com/SlySven","followers_url":"https://api.github.com/users/SlySven/followers","following_url":"https://api.github.com/users/SlySven/following{/other_user}","gists_url":"https://api.github.com/users/SlySven/gists{/gist_id}","starred_url":"https://api.github.com/users/SlySven/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SlySven/subscriptions","organizations_url":"https://api.github.com/users/SlySven/orgs","repos_url":"https://api.github.com/users/SlySven/repos","events_url":"https://api.github.com/users/SlySven/events{/privacy}","received_events_url":"https://api.github.com/users/SlySven/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":366697194,"node_id":"MDU6TGFiZWwzNjY2OTcxOTQ=","url":"https://api.github.com/repos/Mudlet/Mudlet/labels/0%20-%20Work%20in%20progress","name":"0 - Work in progress","color":"88ff44","default":false}],"milestone":{"url":"https://api.github.com/repos/Mudlet/Mudlet/milestones/21","html_url":"https://github.com/Mudlet/Mudlet/milestone/21","labels_url":"https://api.github.com/repos/Mudlet/Mudlet/milestones/21/labels","id":3717271,"node_id":"MDk6TWlsZXN0b25lMzcxNzI3MQ==","number":21,"title":"3.15","description":"","creator":{"login":"vadi2","id":110988,"node_id":"MDQ6VXNlcjExMDk4OA==","avatar_url":"https://avatars1.githubusercontent.com/u/110988?v=4","gravatar_id":"","url":"https://api.github.com/users/vadi2","html_url":"https://github.com/vadi2","followers_url":"https://api.github.com/users/vadi2/followers","following_url":"https://api.github.com/users/vadi2/following{/other_user}","gists_url":"https://api.github.com/users/vadi2/gists{/gist_id}","starred_url":"https://api.github.com/users/vadi2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vadi2/subscriptions","organizations_url":"https://api.github.com/users/vadi2/orgs","repos_url":"https://api.github.com/users/vadi2/repos","events_url":"https://api.github.com/users/vadi2/events{/privacy}","received_events_url":"https://api.github.com/users/vadi2/received_events","type":"User","site_admin":false},"open_issues":4,"closed_issues":15,"state":"closed","created_at":"2018-10-07T05:06:34Z","updated_at":"2018-11-09T08:02:03Z","due_on":"2018-11-04T07:00:00Z","closed_at":"2018-11-05T15:27:32Z"},"commits_url":"https://api.github.com/repos/Mudlet/Mudlet/pulls/1579/commits","review_comments_url":"https://api.github.com/repos/Mudlet/Mudlet/pulls/1579/comments","review_comment_url":"https://api.github.com/repos/Mudlet/Mudlet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Mudlet/Mudlet/issues/1579/comments","statuses_url":"https://api.github.com/repos/Mudlet/Mudlet/statuses/f613daa4785d9cdbd933dcb6a7d48cdd6aa2ef24","head":{"label":"SlySven:Enhance_addMudTextLineGraphemeAnalyser","ref":"Enhance_addMudTextLineGraphemeAnalyser","sha":"f613daa4785d9cdbd933dcb6a7d48cdd6aa2ef24","user":{"login":"SlySven","id":6163092,"node_id":"MDQ6VXNlcjYxNjMwOTI=","avatar_url":"https://avatars3.githubusercontent.com/u/6163092?v=4","gravatar_id":"","url":"https://api.github.com/users/SlySven","html_url":"https://github.com/SlySven","followers_url":"https://api.github.com/users/SlySven/followers","following_url":"https://api.github.com/users/SlySven/following{/other_user}","gists_url":"https://api.github.com/users/SlySven/gists{/gist_id}","starred_url":"https://api.github.com/users/SlySven/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SlySven/subscriptions","organizations_url":"https://api.github.com/users/SlySven/orgs","repos_url":"https://api.github.com/users/SlySven/repos","events_url":"https://api.github.com/users/SlySven/events{/privacy}","received_events_url":"https://api.github.com/users/SlySven/received_events","type":"User","site_admin":false},"repo":{"id":22490921,"node_id":"MDEwOlJlcG9zaXRvcnkyMjQ5MDkyMQ==","name":"Mudlet","full_name":"SlySven/Mudlet","private":false,"owner":{"login":"SlySven","id":6163092,"node_id":"MDQ6VXNlcjYxNjMwOTI=","avatar_url":"https://avatars3.githubusercontent.com/u/6163092?v=4","gravatar_id":"","url":"https://api.github.com/users/SlySven","html_url":"https://github.com/SlySven","followers_url":"https://api.github.com/users/SlySven/followers","following_url":"https://api.github.com/users/SlySven/following{/other_user}","gists_url":"https://api.github.com/users/SlySven/gists{/gist_id}","starred_url":"https://api.github.com/users/SlySven/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SlySven/subscriptions","organizations_url":"https://api.github.com/users/SlySven/orgs","repos_url":"https://api.github.com/users/SlySven/repos","events_url":"https://api.github.com/users/SlySven/events{/privacy}","received_events_url":"https://api.github.com/users/SlySven/received_events","type":"User","site_admin":false},"html_url":"https://github.com/SlySven/Mudlet","description":"A modern open source MUD client with a graphical user inteface and full built in Lua scripting support for all major platforms.","fork":true,"url":"https://api.github.com/repos/SlySven/Mudlet","forks_url":"https://api.github.com/repos/SlySven/Mudlet/forks","keys_url":"https://api.github.com/repos/SlySven/Mudlet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SlySven/Mudlet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SlySven/Mudlet/teams","hooks_url":"https://api.github.com/repos/SlySven/Mudlet/hooks","issue_events_url":"https://api.github.com/repos/SlySven/Mudlet/issues/events{/number}","events_url":"https://api.github.com/repos/SlySven/Mudlet/events","assignees_url":"https://api.github.com/repos/SlySven/Mudlet/assignees{/user}","branches_url":"https://api.github.com/repos/SlySven/Mudlet/branches{/branch}","tags_url":"https://api.github.com/repos/SlySven/Mudlet/tags","blobs_url":"https://api.github.com/repos/SlySven/Mudlet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SlySven/Mudlet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SlySven/Mudlet/git/refs{/sha}","trees_url":"https://api.github.com/repos/SlySven/Mudlet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SlySven/Mudlet/statuses/{sha}","languages_url":"https://api.github.com/repos/SlySven/Mudlet/languages","stargazers_url":"https://api.github.com/repos/SlySven/Mudlet/stargazers","contributors_url":"https://api.github.com/repos/SlySven/Mudlet/contributors","subscribers_url":"https://api.github.com/repos/SlySven/Mudlet/subscribers","subscription_url":"https://api.github.com/repos/SlySven/Mudlet/subscription","commits_url":"https://api.github.com/repos/SlySven/Mudlet/commits{/sha}","git_commits_url":"https://api.github.com/repos/SlySven/Mudlet/git/commits{/sha}","comments_url":"https://api.github.com/repos/SlySven/Mudlet/comments{/number}","issue_comment_url":"https://api.github.com/repos/SlySven/Mudlet/issues/comments{/number}","contents_url":"https://api.github.com/repos/SlySven/Mudlet/contents/{+path}","compare_url":"https://api.github.com/repos/SlySven/Mudlet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SlySven/Mudlet/merges","archive_url":"https://api.github.com/repos/SlySven/Mudlet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SlySven/Mudlet/downloads","issues_url":"https://api.github.com/repos/SlySven/Mudlet/issues{/number}","pulls_url":"https://api.github.com/repos/SlySven/Mudlet/pulls{/number}","milestones_url":"https://api.github.com/repos/SlySven/Mudlet/milestones{/number}","notifications_url":"https://api.github.com/repos/SlySven/Mudlet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SlySven/Mudlet/labels{/name}","releases_url":"https://api.github.com/repos/SlySven/Mudlet/releases{/id}","deployments_url":"https://api.github.com/repos/SlySven/Mudlet/deployments","created_at":"2014-08-01T01:05:26Z","updated_at":"2018-11-08T22:36:27Z","pushed_at":"2018-12-12T22:21:50Z","git_url":"git://github.com/SlySven/Mudlet.git","ssh_url":"[email protected]:SlySven/Mudlet.git","clone_url":"https://github.com/SlySven/Mudlet.git","svn_url":"https://github.com/SlySven/Mudlet","homepage":null,"size":37508,"stargazers_count":2,"watchers_count":2,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":1,"open_issues":2,"watchers":2,"default_branch":"development"}},"base":{"label":"Mudlet:development","ref":"development","sha":"62e970540e37248b1333bdaf14badb1dc47f5c2e","user":{"login":"Mudlet","id":6158612,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTg2MTI=","avatar_url":"https://avatars3.githubusercontent.com/u/6158612?v=4","gravatar_id":"","url":"https://api.github.com/users/Mudlet","html_url":"https://github.com/Mudlet","followers_url":"https://api.github.com/users/Mudlet/followers","following_url":"https://api.github.com/users/Mudlet/following{/other_user}","gists_url":"https://api.github.com/users/Mudlet/gists{/gist_id}","starred_url":"https://api.github.com/users/Mudlet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mudlet/subscriptions","organizations_url":"https://api.github.com/users/Mudlet/orgs","repos_url":"https://api.github.com/users/Mudlet/repos","events_url":"https://api.github.com/users/Mudlet/events{/privacy}","received_events_url":"https://api.github.com/users/Mudlet/received_events","type":"Organization","site_admin":false},"repo":{"id":15108812,"node_id":"MDEwOlJlcG9zaXRvcnkxNTEwODgxMg==","name":"Mudlet","full_name":"Mudlet/Mudlet","private":false,"owner":{"login":"Mudlet","id":6158612,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTg2MTI=","avatar_url":"https://avatars3.githubusercontent.com/u/6158612?v=4","gravatar_id":"","url":"https://api.github.com/users/Mudlet","html_url":"https://github.com/Mudlet","followers_url":"https://api.github.com/users/Mudlet/followers","following_url":"https://api.github.com/users/Mudlet/following{/other_user}","gists_url":"https://api.github.com/users/Mudlet/gists{/gist_id}","starred_url":"https://api.github.com/users/Mudlet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mudlet/subscriptions","organizations_url":"https://api.github.com/users/Mudlet/orgs","repos_url":"https://api.github.com/users/Mudlet/repos","events_url":"https://api.github.com/users/Mudlet/events{/privacy}","received_events_url":"https://api.github.com/users/Mudlet/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Mudlet/Mudlet","description":"A cross-platform, open source, and super fast MUD client with scripting in Lua","fork":false,"url":"https://api.github.com/repos/Mudlet/Mudlet","forks_url":"https://api.github.com/repos/Mudlet/Mudlet/forks","keys_url":"https://api.github.com/repos/Mudlet/Mudlet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Mudlet/Mudlet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Mudlet/Mudlet/teams","hooks_url":"https://api.github.com/repos/Mudlet/Mudlet/hooks","issue_events_url":"https://api.github.com/repos/Mudlet/Mudlet/issues/events{/number}","events_url":"https://api.github.com/repos/Mudlet/Mudlet/events","assignees_url":"https://api.github.com/repos/Mudlet/Mudlet/assignees{/user}","branches_url":"https://api.github.com/repos/Mudlet/Mudlet/branches{/branch}","tags_url":"https://api.github.com/repos/Mudlet/Mudlet/tags","blobs_url":"https://api.github.com/repos/Mudlet/Mudlet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Mudlet/Mudlet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Mudlet/Mudlet/git/refs{/sha}","trees_url":"https://api.github.com/repos/Mudlet/Mudlet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Mudlet/Mudlet/statuses/{sha}","languages_url":"https://api.github.com/repos/Mudlet/Mudlet/languages","stargazers_url":"https://api.github.com/repos/Mudlet/Mudlet/stargazers","contributors_url":"https://api.github.com/repos/Mudlet/Mudlet/contributors","subscribers_url":"https://api.github.com/repos/Mudlet/Mudlet/subscribers","subscription_url":"https://api.github.com/repos/Mudlet/Mudlet/subscription","commits_url":"https://api.github.com/repos/Mudlet/Mudlet/commits{/sha}","git_commits_url":"https://api.github.com/repos/Mudlet/Mudlet/git/commits{/sha}","comments_url":"https://api.github.com/repos/Mudlet/Mudlet/comments{/number}","issue_comment_url":"https://api.github.com/repos/Mudlet/Mudlet/issues/comments{/number}","contents_url":"https://api.github.com/repos/Mudlet/Mudlet/contents/{+path}","compare_url":"https://api.github.com/repos/Mudlet/Mudlet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Mudlet/Mudlet/merges","archive_url":"https://api.github.com/repos/Mudlet/Mudlet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Mudlet/Mudlet/downloads","issues_url":"https://api.github.com/repos/Mudlet/Mudlet/issues{/number}","pulls_url":"https://api.github.com/repos/Mudlet/Mudlet/pulls{/number}","milestones_url":"https://api.github.com/repos/Mudlet/Mudlet/milestones{/number}","notifications_url":"https://api.github.com/repos/Mudlet/Mudlet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Mudlet/Mudlet/labels{/name}","releases_url":"https://api.github.com/repos/Mudlet/Mudlet/releases{/id}","deployments_url":"https://api.github.com/repos/Mudlet/Mudlet/deployments","created_at":"2013-12-11T14:04:21Z","updated_at":"2018-12-12T22:21:52Z","pushed_at":"2018-12-13T18:52:56Z","git_url":"git://github.com/Mudlet/Mudlet.git","ssh_url":"[email protected]:Mudlet/Mudlet.git","clone_url":"https://github.com/Mudlet/Mudlet.git","svn_url":"https://github.com/Mudlet/Mudlet","homepage":"https://mudlet.org","size":33348,"stargazers_count":219,"watchers_count":219,"language":"C++","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":98,"mirror_url":null,"archived":false,"open_issues_count":523,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":98,"open_issues":523,"watchers":219,"default_branch":"development"}},"_links":{"self":{"href":"https://api.github.com/repos/Mudlet/Mudlet/pulls/1579"},"html":{"href":"https://github.com/Mudlet/Mudlet/pull/1579"},"issue":{"href":"https://api.github.com/repos/Mudlet/Mudlet/issues/1579"},"comments":{"href":"https://api.github.com/repos/Mudlet/Mudlet/issues/1579/comments"},"review_comments":{"href":"https://api.github.com/repos/Mudlet/Mudlet/pulls/1579/comments"},"review_comment":{"href":"https://api.github.com/repos/Mudlet/Mudlet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Mudlet/Mudlet/pulls/1579/commits"},"statuses":{"href":"https://api.github.com/repos/Mudlet/Mudlet/statuses/f613daa4785d9cdbd933dcb6a7d48cdd6aa2ef24"}},"author_association":"MEMBER"}} | {
"id": 15108812,
"name": "Mudlet/Mudlet",
"url": "https://api.github.com/repos/Mudlet/Mudlet"
} | {
"id": 110988,
"login": "vadi2",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/110988?",
"url": "https://api.github.com/users/vadi2"
} | {
"id": 6158612,
"login": "Mudlet",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6158612?",
"url": "https://api.github.com/orgs/Mudlet"
} | 2018-12-13T19:32:26 | 8750545992 | {"actor":{"display_login":"vadi2"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/Samsung/tizen-docs/pulls/comments/224423479","pull_request_review_id":163783531,"id":224423479,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNDQyMzQ3OQ==","diff_hunk":"@@ -227,6 +227,32 @@ To check whether an application has permission to use a privilege, and to reques\n }","path":"docs/application/native/guides/security/privacy-related-permissions.md","position":1,"original_position":1,"commit_id":"b937171dd89719bde6511c4acd8b7e41c4cd7e0b","original_commit_id":"b937171dd89719bde6511c4acd8b7e41c4cd7e0b","user":{"login":"flukson","id":2046271,"node_id":"MDQ6VXNlcjIwNDYyNzE=","avatar_url":"https://avatars0.githubusercontent.com/u/2046271?v=4","gravatar_id":"","url":"https://api.github.com/users/flukson","html_url":"https://github.com/flukson","followers_url":"https://api.github.com/users/flukson/followers","following_url":"https://api.github.com/users/flukson/following{/other_user}","gists_url":"https://api.github.com/users/flukson/gists{/gist_id}","starred_url":"https://api.github.com/users/flukson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flukson/subscriptions","organizations_url":"https://api.github.com/users/flukson/orgs","repos_url":"https://api.github.com/users/flukson/repos","events_url":"https://api.github.com/users/flukson/events{/privacy}","received_events_url":"https://api.github.com/users/flukson/received_events","type":"User","site_admin":false},"body":"These remarks are not related to my changes so I cannot fix them in this pull request.","created_at":"2018-10-11T12:14:24Z","updated_at":"2018-10-11T12:14:24Z","html_url":"https://github.com/Samsung/tizen-docs/pull/411#discussion_r224423479","pull_request_url":"https://api.github.com/repos/Samsung/tizen-docs/pulls/411","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/Samsung/tizen-docs/pulls/comments/224423479"},"html":{"href":"https://github.com/Samsung/tizen-docs/pull/411#discussion_r224423479"},"pull_request":{"href":"https://api.github.com/repos/Samsung/tizen-docs/pulls/411"}},"in_reply_to_id":223993370},"pull_request":{"url":"https://api.github.com/repos/Samsung/tizen-docs/pulls/411","id":221150894,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIxMTUwODk0","html_url":"https://github.com/Samsung/tizen-docs/pull/411","diff_url":"https://github.com/Samsung/tizen-docs/pull/411.diff","patch_url":"https://github.com/Samsung/tizen-docs/pull/411.patch","issue_url":"https://api.github.com/repos/Samsung/tizen-docs/issues/411","number":411,"state":"open","locked":false,"title":"[Native/guide] Add info about checking app permission(s)","user":{"login":"flukson","id":2046271,"node_id":"MDQ6VXNlcjIwNDYyNzE=","avatar_url":"https://avatars0.githubusercontent.com/u/2046271?v=4","gravatar_id":"","url":"https://api.github.com/users/flukson","html_url":"https://github.com/flukson","followers_url":"https://api.github.com/users/flukson/followers","following_url":"https://api.github.com/users/flukson/following{/other_user}","gists_url":"https://api.github.com/users/flukson/gists{/gist_id}","starred_url":"https://api.github.com/users/flukson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flukson/subscriptions","organizations_url":"https://api.github.com/users/flukson/orgs","repos_url":"https://api.github.com/users/flukson/repos","events_url":"https://api.github.com/users/flukson/events{/privacy}","received_events_url":"https://api.github.com/users/flukson/received_events","type":"User","site_admin":false},"body":"### Change Description ###\r\n\r\nAdd information about checking the permission(s) of the application\r\nwith the specified app_id.\r\n\r\n### API Changes ###\r\n\r\nACR: ACR-1296\r\nhttp://suprem.sec.samsung.net/jira/browse/ACR-1296\r\n\r\n","created_at":"2018-10-08T15:05:49Z","updated_at":"2018-10-11T12:14:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fe0a7324f3627d64270e634b711263b566d110a8","assignee":null,"assignees":[],"requested_reviewers":[{"login":"annie-samsung","id":34763817,"node_id":"MDQ6VXNlcjM0NzYzODE3","avatar_url":"https://avatars0.githubusercontent.com/u/34763817?v=4","gravatar_id":"","url":"https://api.github.com/users/annie-samsung","html_url":"https://github.com/annie-samsung","followers_url":"https://api.github.com/users/annie-samsung/followers","following_url":"https://api.github.com/users/annie-samsung/following{/other_user}","gists_url":"https://api.github.com/users/annie-samsung/gists{/gist_id}","starred_url":"https://api.github.com/users/annie-samsung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/annie-samsung/subscriptions","organizations_url":"https://api.github.com/users/annie-samsung/orgs","repos_url":"https://api.github.com/users/annie-samsung/repos","events_url":"https://api.github.com/users/annie-samsung/events{/privacy}","received_events_url":"https://api.github.com/users/annie-samsung/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Samsung/tizen-docs/pulls/411/commits","review_comments_url":"https://api.github.com/repos/Samsung/tizen-docs/pulls/411/comments","review_comment_url":"https://api.github.com/repos/Samsung/tizen-docs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Samsung/tizen-docs/issues/411/comments","statuses_url":"https://api.github.com/repos/Samsung/tizen-docs/statuses/b937171dd89719bde6511c4acd8b7e41c4cd7e0b","head":{"label":"flukson:tizen_5.0_prepare","ref":"tizen_5.0_prepare","sha":"b937171dd89719bde6511c4acd8b7e41c4cd7e0b","user":{"login":"flukson","id":2046271,"node_id":"MDQ6VXNlcjIwNDYyNzE=","avatar_url":"https://avatars0.githubusercontent.com/u/2046271?v=4","gravatar_id":"","url":"https://api.github.com/users/flukson","html_url":"https://github.com/flukson","followers_url":"https://api.github.com/users/flukson/followers","following_url":"https://api.github.com/users/flukson/following{/other_user}","gists_url":"https://api.github.com/users/flukson/gists{/gist_id}","starred_url":"https://api.github.com/users/flukson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flukson/subscriptions","organizations_url":"https://api.github.com/users/flukson/orgs","repos_url":"https://api.github.com/users/flukson/repos","events_url":"https://api.github.com/users/flukson/events{/privacy}","received_events_url":"https://api.github.com/users/flukson/received_events","type":"User","site_admin":false},"repo":{"id":152053601,"node_id":"MDEwOlJlcG9zaXRvcnkxNTIwNTM2MDE=","name":"tizen-docs","full_name":"flukson/tizen-docs","private":false,"owner":{"login":"flukson","id":2046271,"node_id":"MDQ6VXNlcjIwNDYyNzE=","avatar_url":"https://avatars0.githubusercontent.com/u/2046271?v=4","gravatar_id":"","url":"https://api.github.com/users/flukson","html_url":"https://github.com/flukson","followers_url":"https://api.github.com/users/flukson/followers","following_url":"https://api.github.com/users/flukson/following{/other_user}","gists_url":"https://api.github.com/users/flukson/gists{/gist_id}","starred_url":"https://api.github.com/users/flukson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flukson/subscriptions","organizations_url":"https://api.github.com/users/flukson/orgs","repos_url":"https://api.github.com/users/flukson/repos","events_url":"https://api.github.com/users/flukson/events{/privacy}","received_events_url":"https://api.github.com/users/flukson/received_events","type":"User","site_admin":false},"html_url":"https://github.com/flukson/tizen-docs","description":"This project is for writing Tizen documents for platform and application developers. The documents will be published to the new Tizen portal site.","fork":true,"url":"https://api.github.com/repos/flukson/tizen-docs","forks_url":"https://api.github.com/repos/flukson/tizen-docs/forks","keys_url":"https://api.github.com/repos/flukson/tizen-docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/flukson/tizen-docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/flukson/tizen-docs/teams","hooks_url":"https://api.github.com/repos/flukson/tizen-docs/hooks","issue_events_url":"https://api.github.com/repos/flukson/tizen-docs/issues/events{/number}","events_url":"https://api.github.com/repos/flukson/tizen-docs/events","assignees_url":"https://api.github.com/repos/flukson/tizen-docs/assignees{/user}","branches_url":"https://api.github.com/repos/flukson/tizen-docs/branches{/branch}","tags_url":"https://api.github.com/repos/flukson/tizen-docs/tags","blobs_url":"https://api.github.com/repos/flukson/tizen-docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/flukson/tizen-docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/flukson/tizen-docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/flukson/tizen-docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/flukson/tizen-docs/statuses/{sha}","languages_url":"https://api.github.com/repos/flukson/tizen-docs/languages","stargazers_url":"https://api.github.com/repos/flukson/tizen-docs/stargazers","contributors_url":"https://api.github.com/repos/flukson/tizen-docs/contributors","subscribers_url":"https://api.github.com/repos/flukson/tizen-docs/subscribers","subscription_url":"https://api.github.com/repos/flukson/tizen-docs/subscription","commits_url":"https://api.github.com/repos/flukson/tizen-docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/flukson/tizen-docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/flukson/tizen-docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/flukson/tizen-docs/issues/comments{/number}","contents_url":"https://api.github.com/repos/flukson/tizen-docs/contents/{+path}","compare_url":"https://api.github.com/repos/flukson/tizen-docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/flukson/tizen-docs/merges","archive_url":"https://api.github.com/repos/flukson/tizen-docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/flukson/tizen-docs/downloads","issues_url":"https://api.github.com/repos/flukson/tizen-docs/issues{/number}","pulls_url":"https://api.github.com/repos/flukson/tizen-docs/pulls{/number}","milestones_url":"https://api.github.com/repos/flukson/tizen-docs/milestones{/number}","notifications_url":"https://api.github.com/repos/flukson/tizen-docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/flukson/tizen-docs/labels{/name}","releases_url":"https://api.github.com/repos/flukson/tizen-docs/releases{/id}","deployments_url":"https://api.github.com/repos/flukson/tizen-docs/deployments","created_at":"2018-10-08T09:31:07Z","updated_at":"2018-10-08T09:31:17Z","pushed_at":"2018-10-08T15:03:18Z","git_url":"git://github.com/flukson/tizen-docs.git","ssh_url":"[email protected]:flukson/tizen-docs.git","clone_url":"https://github.com/flukson/tizen-docs.git","svn_url":"https://github.com/flukson/tizen-docs","homepage":"","size":577436,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Samsung:tizen_5.0_prepare","ref":"tizen_5.0_prepare","sha":"e16b72e10fbc1bb7d5a8adca629b5271d408f002","user":{"login":"Samsung","id":6210390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyMTAzOTA=","avatar_url":"https://avatars3.githubusercontent.com/u/6210390?v=4","gravatar_id":"","url":"https://api.github.com/users/Samsung","html_url":"https://github.com/Samsung","followers_url":"https://api.github.com/users/Samsung/followers","following_url":"https://api.github.com/users/Samsung/following{/other_user}","gists_url":"https://api.github.com/users/Samsung/gists{/gist_id}","starred_url":"https://api.github.com/users/Samsung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Samsung/subscriptions","organizations_url":"https://api.github.com/users/Samsung/orgs","repos_url":"https://api.github.com/users/Samsung/repos","events_url":"https://api.github.com/users/Samsung/events{/privacy}","received_events_url":"https://api.github.com/users/Samsung/received_events","type":"Organization","site_admin":false},"repo":{"id":97676565,"node_id":"MDEwOlJlcG9zaXRvcnk5NzY3NjU2NQ==","name":"tizen-docs","full_name":"Samsung/tizen-docs","private":false,"owner":{"login":"Samsung","id":6210390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyMTAzOTA=","avatar_url":"https://avatars3.githubusercontent.com/u/6210390?v=4","gravatar_id":"","url":"https://api.github.com/users/Samsung","html_url":"https://github.com/Samsung","followers_url":"https://api.github.com/users/Samsung/followers","following_url":"https://api.github.com/users/Samsung/following{/other_user}","gists_url":"https://api.github.com/users/Samsung/gists{/gist_id}","starred_url":"https://api.github.com/users/Samsung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Samsung/subscriptions","organizations_url":"https://api.github.com/users/Samsung/orgs","repos_url":"https://api.github.com/users/Samsung/repos","events_url":"https://api.github.com/users/Samsung/events{/privacy}","received_events_url":"https://api.github.com/users/Samsung/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Samsung/tizen-docs","description":"This project is for writing Tizen documents for platform and application developers. The documents will be published to the new Tizen portal site.","fork":false,"url":"https://api.github.com/repos/Samsung/tizen-docs","forks_url":"https://api.github.com/repos/Samsung/tizen-docs/forks","keys_url":"https://api.github.com/repos/Samsung/tizen-docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Samsung/tizen-docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Samsung/tizen-docs/teams","hooks_url":"https://api.github.com/repos/Samsung/tizen-docs/hooks","issue_events_url":"https://api.github.com/repos/Samsung/tizen-docs/issues/events{/number}","events_url":"https://api.github.com/repos/Samsung/tizen-docs/events","assignees_url":"https://api.github.com/repos/Samsung/tizen-docs/assignees{/user}","branches_url":"https://api.github.com/repos/Samsung/tizen-docs/branches{/branch}","tags_url":"https://api.github.com/repos/Samsung/tizen-docs/tags","blobs_url":"https://api.github.com/repos/Samsung/tizen-docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Samsung/tizen-docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Samsung/tizen-docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/Samsung/tizen-docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Samsung/tizen-docs/statuses/{sha}","languages_url":"https://api.github.com/repos/Samsung/tizen-docs/languages","stargazers_url":"https://api.github.com/repos/Samsung/tizen-docs/stargazers","contributors_url":"https://api.github.com/repos/Samsung/tizen-docs/contributors","subscribers_url":"https://api.github.com/repos/Samsung/tizen-docs/subscribers","subscription_url":"https://api.github.com/repos/Samsung/tizen-docs/subscription","commits_url":"https://api.github.com/repos/Samsung/tizen-docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/Samsung/tizen-docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/Samsung/tizen-docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/Samsung/tizen-docs/issues/comments{/number}","contents_url":"https://api.github.com/repos/Samsung/tizen-docs/contents/{+path}","compare_url":"https://api.github.com/repos/Samsung/tizen-docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Samsung/tizen-docs/merges","archive_url":"https://api.github.com/repos/Samsung/tizen-docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Samsung/tizen-docs/downloads","issues_url":"https://api.github.com/repos/Samsung/tizen-docs/issues{/number}","pulls_url":"https://api.github.com/repos/Samsung/tizen-docs/pulls{/number}","milestones_url":"https://api.github.com/repos/Samsung/tizen-docs/milestones{/number}","notifications_url":"https://api.github.com/repos/Samsung/tizen-docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Samsung/tizen-docs/labels{/name}","releases_url":"https://api.github.com/repos/Samsung/tizen-docs/releases{/id}","deployments_url":"https://api.github.com/repos/Samsung/tizen-docs/deployments","created_at":"2017-07-19T05:35:09Z","updated_at":"2018-10-09T04:18:32Z","pushed_at":"2018-10-11T09:25:36Z","git_url":"git://github.com/Samsung/tizen-docs.git","ssh_url":"[email protected]:Samsung/tizen-docs.git","clone_url":"https://github.com/Samsung/tizen-docs.git","svn_url":"https://github.com/Samsung/tizen-docs","homepage":"","size":577444,"stargazers_count":25,"watchers_count":25,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":107,"mirror_url":null,"archived":false,"open_issues_count":25,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":107,"open_issues":25,"watchers":25,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Samsung/tizen-docs/pulls/411"},"html":{"href":"https://github.com/Samsung/tizen-docs/pull/411"},"issue":{"href":"https://api.github.com/repos/Samsung/tizen-docs/issues/411"},"comments":{"href":"https://api.github.com/repos/Samsung/tizen-docs/issues/411/comments"},"review_comments":{"href":"https://api.github.com/repos/Samsung/tizen-docs/pulls/411/comments"},"review_comment":{"href":"https://api.github.com/repos/Samsung/tizen-docs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Samsung/tizen-docs/pulls/411/commits"},"statuses":{"href":"https://api.github.com/repos/Samsung/tizen-docs/statuses/b937171dd89719bde6511c4acd8b7e41c4cd7e0b"}},"author_association":"NONE"}} | {
"id": 97676565,
"name": "Samsung/tizen-docs",
"url": "https://api.github.com/repos/Samsung/tizen-docs"
} | {
"id": 2046271,
"login": "flukson",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2046271?",
"url": "https://api.github.com/users/flukson"
} | {
"id": 6210390,
"login": "Samsung",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6210390?",
"url": "https://api.github.com/orgs/Samsung"
} | 2018-10-11T12:14:24 | 8404229030 | {"actor":{"display_login":"flukson"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/18F/eng-hiring/pulls/comments/209028089","pull_request_review_id":144961361,"id":209028089,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwOTAyODA4OQ==","diff_hunk":"@@ -119,8 +121,9 @@ Regardless of whether or not the candidate is applying for a software developmen\n - If applicable: Were you successful in doing so, and why or why not?\n \n - [What is your comfort level with peer-reviewed work?](https://docs.google.com/document/d/1oYmx_93-mq2QrqICCo8SNk8hHmnPPonPA1kg0vhy540/edit#heading=h.3qcfg9pfhobk)\n+ - If applicable: Have you pro-actively sought additional training and/or peer review?","path":"_pages/interviews/core-values.md","position":13,"original_position":13,"commit_id":"6b14a65da3290261c3b1ee006a0e0cdb79515e76","original_commit_id":"6b14a65da3290261c3b1ee006a0e0cdb79515e76","user":{"login":"fureigh","id":1244599,"node_id":"MDQ6VXNlcjEyNDQ1OTk=","avatar_url":"https://avatars2.githubusercontent.com/u/1244599?v=4","gravatar_id":"","url":"https://api.github.com/users/fureigh","html_url":"https://github.com/fureigh","followers_url":"https://api.github.com/users/fureigh/followers","following_url":"https://api.github.com/users/fureigh/following{/other_user}","gists_url":"https://api.github.com/users/fureigh/gists{/gist_id}","starred_url":"https://api.github.com/users/fureigh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fureigh/subscriptions","organizations_url":"https://api.github.com/users/fureigh/orgs","repos_url":"https://api.github.com/users/fureigh/repos","events_url":"https://api.github.com/users/fureigh/events{/privacy}","received_events_url":"https://api.github.com/users/fureigh/received_events","type":"User","site_admin":false},"body":"Minor copy edit: `pro-actively` --> `proactively`","created_at":"2018-08-09T18:10:10Z","updated_at":"2018-08-09T18:15:28Z","html_url":"https://github.com/18F/eng-hiring/pull/27#discussion_r209028089","pull_request_url":"https://api.github.com/repos/18F/eng-hiring/pulls/27","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/18F/eng-hiring/pulls/comments/209028089"},"html":{"href":"https://github.com/18F/eng-hiring/pull/27#discussion_r209028089"},"pull_request":{"href":"https://api.github.com/repos/18F/eng-hiring/pulls/27"}}},"pull_request":{"url":"https://api.github.com/repos/18F/eng-hiring/pulls/27","id":206824878,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2ODI0ODc4","html_url":"https://github.com/18F/eng-hiring/pull/27","diff_url":"https://github.com/18F/eng-hiring/pull/27.diff","patch_url":"https://github.com/18F/eng-hiring/pull/27.patch","issue_url":"https://api.github.com/repos/18F/eng-hiring/issues/27","number":27,"state":"open","locked":false,"title":"Hiring site updates","user":{"login":"ctro","id":11878,"node_id":"MDQ6VXNlcjExODc4","avatar_url":"https://avatars1.githubusercontent.com/u/11878?v=4","gravatar_id":"","url":"https://api.github.com/users/ctro","html_url":"https://github.com/ctro","followers_url":"https://api.github.com/users/ctro/followers","following_url":"https://api.github.com/users/ctro/following{/other_user}","gists_url":"https://api.github.com/users/ctro/gists{/gist_id}","starred_url":"https://api.github.com/users/ctro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ctro/subscriptions","organizations_url":"https://api.github.com/users/ctro/orgs","repos_url":"https://api.github.com/users/ctro/repos","events_url":"https://api.github.com/users/ctro/events{/privacy}","received_events_url":"https://api.github.com/users/ctro/received_events","type":"User","site_admin":false},"body":"1. Add a consulting engineer section and initial question\r\n2. Add a couple questions that had been suggested and added in the master GDoc\r\n3. Fix some broken links reported in #23 ","created_at":"2018-08-07T20:58:23Z","updated_at":"2018-08-09T18:15:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5b9f26d183189c82bfa9558eeafef890145bc5ec","assignee":{"login":"ertzeid","id":6598247,"node_id":"MDQ6VXNlcjY1OTgyNDc=","avatar_url":"https://avatars1.githubusercontent.com/u/6598247?v=4","gravatar_id":"","url":"https://api.github.com/users/ertzeid","html_url":"https://github.com/ertzeid","followers_url":"https://api.github.com/users/ertzeid/followers","following_url":"https://api.github.com/users/ertzeid/following{/other_user}","gists_url":"https://api.github.com/users/ertzeid/gists{/gist_id}","starred_url":"https://api.github.com/users/ertzeid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ertzeid/subscriptions","organizations_url":"https://api.github.com/users/ertzeid/orgs","repos_url":"https://api.github.com/users/ertzeid/repos","events_url":"https://api.github.com/users/ertzeid/events{/privacy}","received_events_url":"https://api.github.com/users/ertzeid/received_events","type":"User","site_admin":false},"assignees":[{"login":"ertzeid","id":6598247,"node_id":"MDQ6VXNlcjY1OTgyNDc=","avatar_url":"https://avatars1.githubusercontent.com/u/6598247?v=4","gravatar_id":"","url":"https://api.github.com/users/ertzeid","html_url":"https://github.com/ertzeid","followers_url":"https://api.github.com/users/ertzeid/followers","following_url":"https://api.github.com/users/ertzeid/following{/other_user}","gists_url":"https://api.github.com/users/ertzeid/gists{/gist_id}","starred_url":"https://api.github.com/users/ertzeid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ertzeid/subscriptions","organizations_url":"https://api.github.com/users/ertzeid/orgs","repos_url":"https://api.github.com/users/ertzeid/repos","events_url":"https://api.github.com/users/ertzeid/events{/privacy}","received_events_url":"https://api.github.com/users/ertzeid/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/18F/eng-hiring/pulls/27/commits","review_comments_url":"https://api.github.com/repos/18F/eng-hiring/pulls/27/comments","review_comment_url":"https://api.github.com/repos/18F/eng-hiring/pulls/comments{/number}","comments_url":"https://api.github.com/repos/18F/eng-hiring/issues/27/comments","statuses_url":"https://api.github.com/repos/18F/eng-hiring/statuses/6b14a65da3290261c3b1ee006a0e0cdb79515e76","head":{"label":"18F:consulting-engineer","ref":"consulting-engineer","sha":"6b14a65da3290261c3b1ee006a0e0cdb79515e76","user":{"login":"18F","id":6233994,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyMzM5OTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/6233994?v=4","gravatar_id":"","url":"https://api.github.com/users/18F","html_url":"https://github.com/18F","followers_url":"https://api.github.com/users/18F/followers","following_url":"https://api.github.com/users/18F/following{/other_user}","gists_url":"https://api.github.com/users/18F/gists{/gist_id}","starred_url":"https://api.github.com/users/18F/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/18F/subscriptions","organizations_url":"https://api.github.com/users/18F/orgs","repos_url":"https://api.github.com/users/18F/repos","events_url":"https://api.github.com/users/18F/events{/privacy}","received_events_url":"https://api.github.com/users/18F/received_events","type":"Organization","site_admin":false},"repo":{"id":68395561,"node_id":"MDEwOlJlcG9zaXRvcnk2ODM5NTU2MQ==","name":"eng-hiring","full_name":"18F/eng-hiring","owner":{"login":"18F","id":6233994,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyMzM5OTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/6233994?v=4","gravatar_id":"","url":"https://api.github.com/users/18F","html_url":"https://github.com/18F","followers_url":"https://api.github.com/users/18F/followers","following_url":"https://api.github.com/users/18F/following{/other_user}","gists_url":"https://api.github.com/users/18F/gists{/gist_id}","starred_url":"https://api.github.com/users/18F/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/18F/subscriptions","organizations_url":"https://api.github.com/users/18F/orgs","repos_url":"https://api.github.com/users/18F/repos","events_url":"https://api.github.com/users/18F/events{/privacy}","received_events_url":"https://api.github.com/users/18F/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/18F/eng-hiring","description":"18F Engineering's guide to candidate selection, from resume screen to offer.","fork":false,"url":"https://api.github.com/repos/18F/eng-hiring","forks_url":"https://api.github.com/repos/18F/eng-hiring/forks","keys_url":"https://api.github.com/repos/18F/eng-hiring/keys{/key_id}","collaborators_url":"https://api.github.com/repos/18F/eng-hiring/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/18F/eng-hiring/teams","hooks_url":"https://api.github.com/repos/18F/eng-hiring/hooks","issue_events_url":"https://api.github.com/repos/18F/eng-hiring/issues/events{/number}","events_url":"https://api.github.com/repos/18F/eng-hiring/events","assignees_url":"https://api.github.com/repos/18F/eng-hiring/assignees{/user}","branches_url":"https://api.github.com/repos/18F/eng-hiring/branches{/branch}","tags_url":"https://api.github.com/repos/18F/eng-hiring/tags","blobs_url":"https://api.github.com/repos/18F/eng-hiring/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/18F/eng-hiring/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/18F/eng-hiring/git/refs{/sha}","trees_url":"https://api.github.com/repos/18F/eng-hiring/git/trees{/sha}","statuses_url":"https://api.github.com/repos/18F/eng-hiring/statuses/{sha}","languages_url":"https://api.github.com/repos/18F/eng-hiring/languages","stargazers_url":"https://api.github.com/repos/18F/eng-hiring/stargazers","contributors_url":"https://api.github.com/repos/18F/eng-hiring/contributors","subscribers_url":"https://api.github.com/repos/18F/eng-hiring/subscribers","subscription_url":"https://api.github.com/repos/18F/eng-hiring/subscription","commits_url":"https://api.github.com/repos/18F/eng-hiring/commits{/sha}","git_commits_url":"https://api.github.com/repos/18F/eng-hiring/git/commits{/sha}","comments_url":"https://api.github.com/repos/18F/eng-hiring/comments{/number}","issue_comment_url":"https://api.github.com/repos/18F/eng-hiring/issues/comments{/number}","contents_url":"https://api.github.com/repos/18F/eng-hiring/contents/{+path}","compare_url":"https://api.github.com/repos/18F/eng-hiring/compare/{base}...{head}","merges_url":"https://api.github.com/repos/18F/eng-hiring/merges","archive_url":"https://api.github.com/repos/18F/eng-hiring/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/18F/eng-hiring/downloads","issues_url":"https://api.github.com/repos/18F/eng-hiring/issues{/number}","pulls_url":"https://api.github.com/repos/18F/eng-hiring/pulls{/number}","milestones_url":"https://api.github.com/repos/18F/eng-hiring/milestones{/number}","notifications_url":"https://api.github.com/repos/18F/eng-hiring/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/18F/eng-hiring/labels{/name}","releases_url":"https://api.github.com/repos/18F/eng-hiring/releases{/id}","deployments_url":"https://api.github.com/repos/18F/eng-hiring/deployments","created_at":"2016-09-16T16:19:29Z","updated_at":"2018-07-25T19:54:51Z","pushed_at":"2018-08-07T20:58:23Z","git_url":"git://github.com/18F/eng-hiring.git","ssh_url":"[email protected]:18F/eng-hiring.git","clone_url":"https://github.com/18F/eng-hiring.git","svn_url":"https://github.com/18F/eng-hiring","homepage":"https://eng-hiring.18f.gov/","size":56,"stargazers_count":17,"watchers_count":17,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":6,"open_issues":4,"watchers":17,"default_branch":"master"}},"base":{"label":"18F:master","ref":"master","sha":"66270edf0f4a842c4be8cbdf63f10aae973e7ac6","user":{"login":"18F","id":6233994,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyMzM5OTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/6233994?v=4","gravatar_id":"","url":"https://api.github.com/users/18F","html_url":"https://github.com/18F","followers_url":"https://api.github.com/users/18F/followers","following_url":"https://api.github.com/users/18F/following{/other_user}","gists_url":"https://api.github.com/users/18F/gists{/gist_id}","starred_url":"https://api.github.com/users/18F/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/18F/subscriptions","organizations_url":"https://api.github.com/users/18F/orgs","repos_url":"https://api.github.com/users/18F/repos","events_url":"https://api.github.com/users/18F/events{/privacy}","received_events_url":"https://api.github.com/users/18F/received_events","type":"Organization","site_admin":false},"repo":{"id":68395561,"node_id":"MDEwOlJlcG9zaXRvcnk2ODM5NTU2MQ==","name":"eng-hiring","full_name":"18F/eng-hiring","owner":{"login":"18F","id":6233994,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyMzM5OTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/6233994?v=4","gravatar_id":"","url":"https://api.github.com/users/18F","html_url":"https://github.com/18F","followers_url":"https://api.github.com/users/18F/followers","following_url":"https://api.github.com/users/18F/following{/other_user}","gists_url":"https://api.github.com/users/18F/gists{/gist_id}","starred_url":"https://api.github.com/users/18F/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/18F/subscriptions","organizations_url":"https://api.github.com/users/18F/orgs","repos_url":"https://api.github.com/users/18F/repos","events_url":"https://api.github.com/users/18F/events{/privacy}","received_events_url":"https://api.github.com/users/18F/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/18F/eng-hiring","description":"18F Engineering's guide to candidate selection, from resume screen to offer.","fork":false,"url":"https://api.github.com/repos/18F/eng-hiring","forks_url":"https://api.github.com/repos/18F/eng-hiring/forks","keys_url":"https://api.github.com/repos/18F/eng-hiring/keys{/key_id}","collaborators_url":"https://api.github.com/repos/18F/eng-hiring/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/18F/eng-hiring/teams","hooks_url":"https://api.github.com/repos/18F/eng-hiring/hooks","issue_events_url":"https://api.github.com/repos/18F/eng-hiring/issues/events{/number}","events_url":"https://api.github.com/repos/18F/eng-hiring/events","assignees_url":"https://api.github.com/repos/18F/eng-hiring/assignees{/user}","branches_url":"https://api.github.com/repos/18F/eng-hiring/branches{/branch}","tags_url":"https://api.github.com/repos/18F/eng-hiring/tags","blobs_url":"https://api.github.com/repos/18F/eng-hiring/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/18F/eng-hiring/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/18F/eng-hiring/git/refs{/sha}","trees_url":"https://api.github.com/repos/18F/eng-hiring/git/trees{/sha}","statuses_url":"https://api.github.com/repos/18F/eng-hiring/statuses/{sha}","languages_url":"https://api.github.com/repos/18F/eng-hiring/languages","stargazers_url":"https://api.github.com/repos/18F/eng-hiring/stargazers","contributors_url":"https://api.github.com/repos/18F/eng-hiring/contributors","subscribers_url":"https://api.github.com/repos/18F/eng-hiring/subscribers","subscription_url":"https://api.github.com/repos/18F/eng-hiring/subscription","commits_url":"https://api.github.com/repos/18F/eng-hiring/commits{/sha}","git_commits_url":"https://api.github.com/repos/18F/eng-hiring/git/commits{/sha}","comments_url":"https://api.github.com/repos/18F/eng-hiring/comments{/number}","issue_comment_url":"https://api.github.com/repos/18F/eng-hiring/issues/comments{/number}","contents_url":"https://api.github.com/repos/18F/eng-hiring/contents/{+path}","compare_url":"https://api.github.com/repos/18F/eng-hiring/compare/{base}...{head}","merges_url":"https://api.github.com/repos/18F/eng-hiring/merges","archive_url":"https://api.github.com/repos/18F/eng-hiring/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/18F/eng-hiring/downloads","issues_url":"https://api.github.com/repos/18F/eng-hiring/issues{/number}","pulls_url":"https://api.github.com/repos/18F/eng-hiring/pulls{/number}","milestones_url":"https://api.github.com/repos/18F/eng-hiring/milestones{/number}","notifications_url":"https://api.github.com/repos/18F/eng-hiring/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/18F/eng-hiring/labels{/name}","releases_url":"https://api.github.com/repos/18F/eng-hiring/releases{/id}","deployments_url":"https://api.github.com/repos/18F/eng-hiring/deployments","created_at":"2016-09-16T16:19:29Z","updated_at":"2018-07-25T19:54:51Z","pushed_at":"2018-08-07T20:58:23Z","git_url":"git://github.com/18F/eng-hiring.git","ssh_url":"[email protected]:18F/eng-hiring.git","clone_url":"https://github.com/18F/eng-hiring.git","svn_url":"https://github.com/18F/eng-hiring","homepage":"https://eng-hiring.18f.gov/","size":56,"stargazers_count":17,"watchers_count":17,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":6,"open_issues":4,"watchers":17,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/18F/eng-hiring/pulls/27"},"html":{"href":"https://github.com/18F/eng-hiring/pull/27"},"issue":{"href":"https://api.github.com/repos/18F/eng-hiring/issues/27"},"comments":{"href":"https://api.github.com/repos/18F/eng-hiring/issues/27/comments"},"review_comments":{"href":"https://api.github.com/repos/18F/eng-hiring/pulls/27/comments"},"review_comment":{"href":"https://api.github.com/repos/18F/eng-hiring/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/18F/eng-hiring/pulls/27/commits"},"statuses":{"href":"https://api.github.com/repos/18F/eng-hiring/statuses/6b14a65da3290261c3b1ee006a0e0cdb79515e76"}},"author_association":"MEMBER"}} | {
"id": 68395561,
"name": "18F/eng-hiring",
"url": "https://api.github.com/repos/18F/eng-hiring"
} | {
"id": 1244599,
"login": "fureigh",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1244599?",
"url": "https://api.github.com/users/fureigh"
} | {
"id": 6233994,
"login": "18F",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6233994?",
"url": "https://api.github.com/orgs/18F"
} | 2018-08-09T18:10:10 | 8091847342 | {"actor":{"display_login":"fureigh"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/18F/State-TalentMAP/pulls/comments/180088835","pull_request_review_id":110447320,"id":180088835,"diff_hunk":"@@ -49,7 +49,7 @@ const CompareList = ({ compare, isLoading, goBackLink }) => {\n <th key={shortId.generate()}>\n <div className=\"column-title-main\">{c.title}</div>\n <div className=\"column-title-link\">\n- <Link to={`/details/${c.position_number}`}>Learn more</Link>\n+ <Link to={`/details/${c.position_number}`}>View Position Details</Link>","path":"src/Components/CompareList/CompareList.jsx","position":5,"original_position":5,"commit_id":"e17db74acffa6cfa870ca9b98dbda0306795f66a","original_commit_id":"e17db74acffa6cfa870ca9b98dbda0306795f66a","user":{"login":"mjoyce91","id":11576347,"avatar_url":"https://avatars2.githubusercontent.com/u/11576347?v=4","gravatar_id":"","url":"https://api.github.com/users/mjoyce91","html_url":"https://github.com/mjoyce91","followers_url":"https://api.github.com/users/mjoyce91/followers","following_url":"https://api.github.com/users/mjoyce91/following{/other_user}","gists_url":"https://api.github.com/users/mjoyce91/gists{/gist_id}","starred_url":"https://api.github.com/users/mjoyce91/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjoyce91/subscriptions","organizations_url":"https://api.github.com/users/mjoyce91/orgs","repos_url":"https://api.github.com/users/mjoyce91/repos","events_url":"https://api.github.com/users/mjoyce91/events{/privacy}","received_events_url":"https://api.github.com/users/mjoyce91/received_events","type":"User","site_admin":false},"body":"I just followed up with the Design team, and links should be sentence casing, while buttons should be capitalized.","created_at":"2018-04-09T13:12:05Z","updated_at":"2018-04-09T13:12:05Z","html_url":"https://github.com/18F/State-TalentMAP/pull/1725#discussion_r180088835","pull_request_url":"https://api.github.com/repos/18F/State-TalentMAP/pulls/1725","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/18F/State-TalentMAP/pulls/comments/180088835"},"html":{"href":"https://github.com/18F/State-TalentMAP/pull/1725#discussion_r180088835"},"pull_request":{"href":"https://api.github.com/repos/18F/State-TalentMAP/pulls/1725"}},"in_reply_to_id":180087800},"pull_request":{"url":"https://api.github.com/repos/18F/State-TalentMAP/pulls/1725","id":180209504,"html_url":"https://github.com/18F/State-TalentMAP/pull/1725","diff_url":"https://github.com/18F/State-TalentMAP/pull/1725.diff","patch_url":"https://github.com/18F/State-TalentMAP/pull/1725.patch","issue_url":"https://api.github.com/repos/18F/State-TalentMAP/issues/1725","number":1725,"state":"open","locked":false,"title":"Final Designs (04-04-2018) - Compare Lists","user":{"login":"Icemanbeta","id":1786875,"avatar_url":"https://avatars2.githubusercontent.com/u/1786875?v=4","gravatar_id":"","url":"https://api.github.com/users/Icemanbeta","html_url":"https://github.com/Icemanbeta","followers_url":"https://api.github.com/users/Icemanbeta/followers","following_url":"https://api.github.com/users/Icemanbeta/following{/other_user}","gists_url":"https://api.github.com/users/Icemanbeta/gists{/gist_id}","starred_url":"https://api.github.com/users/Icemanbeta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Icemanbeta/subscriptions","organizations_url":"https://api.github.com/users/Icemanbeta/orgs","repos_url":"https://api.github.com/users/Icemanbeta/repos","events_url":"https://api.github.com/users/Icemanbeta/events{/privacy}","received_events_url":"https://api.github.com/users/Icemanbeta/received_events","type":"User","site_admin":false},"body":"- Update styles for `CompareList` tree","created_at":"2018-04-09T04:40:59Z","updated_at":"2018-04-09T13:12:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"07421050e25d8e0b06b6d343f6472f7ca0616c9d","assignee":null,"assignees":[],"requested_reviewers":[{"login":"burgwyn","id":661204,"avatar_url":"https://avatars1.githubusercontent.com/u/661204?v=4","gravatar_id":"","url":"https://api.github.com/users/burgwyn","html_url":"https://github.com/burgwyn","followers_url":"https://api.github.com/users/burgwyn/followers","following_url":"https://api.github.com/users/burgwyn/following{/other_user}","gists_url":"https://api.github.com/users/burgwyn/gists{/gist_id}","starred_url":"https://api.github.com/users/burgwyn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/burgwyn/subscriptions","organizations_url":"https://api.github.com/users/burgwyn/orgs","repos_url":"https://api.github.com/users/burgwyn/repos","events_url":"https://api.github.com/users/burgwyn/events{/privacy}","received_events_url":"https://api.github.com/users/burgwyn/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/18F/State-TalentMAP/pulls/1725/commits","review_comments_url":"https://api.github.com/repos/18F/State-TalentMAP/pulls/1725/comments","review_comment_url":"https://api.github.com/repos/18F/State-TalentMAP/pulls/comments{/number}","comments_url":"https://api.github.com/repos/18F/State-TalentMAP/issues/1725/comments","statuses_url":"https://api.github.com/repos/18F/State-TalentMAP/statuses/e17db74acffa6cfa870ca9b98dbda0306795f66a","head":{"label":"18F:rc1-20180404-compare","ref":"rc1-20180404-compare","sha":"e17db74acffa6cfa870ca9b98dbda0306795f66a","user":{"login":"18F","id":6233994,"avatar_url":"https://avatars0.githubusercontent.com/u/6233994?v=4","gravatar_id":"","url":"https://api.github.com/users/18F","html_url":"https://github.com/18F","followers_url":"https://api.github.com/users/18F/followers","following_url":"https://api.github.com/users/18F/following{/other_user}","gists_url":"https://api.github.com/users/18F/gists{/gist_id}","starred_url":"https://api.github.com/users/18F/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/18F/subscriptions","organizations_url":"https://api.github.com/users/18F/orgs","repos_url":"https://api.github.com/users/18F/repos","events_url":"https://api.github.com/users/18F/events{/privacy}","received_events_url":"https://api.github.com/users/18F/received_events","type":"Organization","site_admin":false},"repo":{"id":91723512,"name":"State-TalentMAP","full_name":"18F/State-TalentMAP","owner":{"login":"18F","id":6233994,"avatar_url":"https://avatars0.githubusercontent.com/u/6233994?v=4","gravatar_id":"","url":"https://api.github.com/users/18F","html_url":"https://github.com/18F","followers_url":"https://api.github.com/users/18F/followers","following_url":"https://api.github.com/users/18F/following{/other_user}","gists_url":"https://api.github.com/users/18F/gists{/gist_id}","starred_url":"https://api.github.com/users/18F/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/18F/subscriptions","organizations_url":"https://api.github.com/users/18F/orgs","repos_url":"https://api.github.com/users/18F/repos","events_url":"https://api.github.com/users/18F/events{/privacy}","received_events_url":"https://api.github.com/users/18F/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/18F/State-TalentMAP","description":"A comprehensive research, bidding, and matching system to match Foreign Service employees with the right skills to available posts and positions.","fork":false,"url":"https://api.github.com/repos/18F/State-TalentMAP","forks_url":"https://api.github.com/repos/18F/State-TalentMAP/forks","keys_url":"https://api.github.com/repos/18F/State-TalentMAP/keys{/key_id}","collaborators_url":"https://api.github.com/repos/18F/State-TalentMAP/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/18F/State-TalentMAP/teams","hooks_url":"https://api.github.com/repos/18F/State-TalentMAP/hooks","issue_events_url":"https://api.github.com/repos/18F/State-TalentMAP/issues/events{/number}","events_url":"https://api.github.com/repos/18F/State-TalentMAP/events","assignees_url":"https://api.github.com/repos/18F/State-TalentMAP/assignees{/user}","branches_url":"https://api.github.com/repos/18F/State-TalentMAP/branches{/branch}","tags_url":"https://api.github.com/repos/18F/State-TalentMAP/tags","blobs_url":"https://api.github.com/repos/18F/State-TalentMAP/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/18F/State-TalentMAP/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/18F/State-TalentMAP/git/refs{/sha}","trees_url":"https://api.github.com/repos/18F/State-TalentMAP/git/trees{/sha}","statuses_url":"https://api.github.com/repos/18F/State-TalentMAP/statuses/{sha}","languages_url":"https://api.github.com/repos/18F/State-TalentMAP/languages","stargazers_url":"https://api.github.com/repos/18F/State-TalentMAP/stargazers","contributors_url":"https://api.github.com/repos/18F/State-TalentMAP/contributors","subscribers_url":"https://api.github.com/repos/18F/State-TalentMAP/subscribers","subscription_url":"https://api.github.com/repos/18F/State-TalentMAP/subscription","commits_url":"https://api.github.com/repos/18F/State-TalentMAP/commits{/sha}","git_commits_url":"https://api.github.com/repos/18F/State-TalentMAP/git/commits{/sha}","comments_url":"https://api.github.com/repos/18F/State-TalentMAP/comments{/number}","issue_comment_url":"https://api.github.com/repos/18F/State-TalentMAP/issues/comments{/number}","contents_url":"https://api.github.com/repos/18F/State-TalentMAP/contents/{+path}","compare_url":"https://api.github.com/repos/18F/State-TalentMAP/compare/{base}...{head}","merges_url":"https://api.github.com/repos/18F/State-TalentMAP/merges","archive_url":"https://api.github.com/repos/18F/State-TalentMAP/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/18F/State-TalentMAP/downloads","issues_url":"https://api.github.com/repos/18F/State-TalentMAP/issues{/number}","pulls_url":"https://api.github.com/repos/18F/State-TalentMAP/pulls{/number}","milestones_url":"https://api.github.com/repos/18F/State-TalentMAP/milestones{/number}","notifications_url":"https://api.github.com/repos/18F/State-TalentMAP/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/18F/State-TalentMAP/labels{/name}","releases_url":"https://api.github.com/repos/18F/State-TalentMAP/releases{/id}","deployments_url":"https://api.github.com/repos/18F/State-TalentMAP/deployments","created_at":"2017-05-18T18:04:17Z","updated_at":"2018-03-13T19:15:58Z","pushed_at":"2018-04-09T12:52:08Z","git_url":"git://github.com/18F/State-TalentMAP.git","ssh_url":"[email protected]:18F/State-TalentMAP.git","clone_url":"https://github.com/18F/State-TalentMAP.git","svn_url":"https://github.com/18F/State-TalentMAP","homepage":null,"size":16886,"stargazers_count":16,"watchers_count":16,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":403,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":6,"open_issues":403,"watchers":16,"default_branch":"dev"}},"base":{"label":"18F:release-candidate-1","ref":"release-candidate-1","sha":"705e8586c7eaa8ff5b44a6d2b597d6d223718e2d","user":{"login":"18F","id":6233994,"avatar_url":"https://avatars0.githubusercontent.com/u/6233994?v=4","gravatar_id":"","url":"https://api.github.com/users/18F","html_url":"https://github.com/18F","followers_url":"https://api.github.com/users/18F/followers","following_url":"https://api.github.com/users/18F/following{/other_user}","gists_url":"https://api.github.com/users/18F/gists{/gist_id}","starred_url":"https://api.github.com/users/18F/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/18F/subscriptions","organizations_url":"https://api.github.com/users/18F/orgs","repos_url":"https://api.github.com/users/18F/repos","events_url":"https://api.github.com/users/18F/events{/privacy}","received_events_url":"https://api.github.com/users/18F/received_events","type":"Organization","site_admin":false},"repo":{"id":91723512,"name":"State-TalentMAP","full_name":"18F/State-TalentMAP","owner":{"login":"18F","id":6233994,"avatar_url":"https://avatars0.githubusercontent.com/u/6233994?v=4","gravatar_id":"","url":"https://api.github.com/users/18F","html_url":"https://github.com/18F","followers_url":"https://api.github.com/users/18F/followers","following_url":"https://api.github.com/users/18F/following{/other_user}","gists_url":"https://api.github.com/users/18F/gists{/gist_id}","starred_url":"https://api.github.com/users/18F/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/18F/subscriptions","organizations_url":"https://api.github.com/users/18F/orgs","repos_url":"https://api.github.com/users/18F/repos","events_url":"https://api.github.com/users/18F/events{/privacy}","received_events_url":"https://api.github.com/users/18F/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/18F/State-TalentMAP","description":"A comprehensive research, bidding, and matching system to match Foreign Service employees with the right skills to available posts and positions.","fork":false,"url":"https://api.github.com/repos/18F/State-TalentMAP","forks_url":"https://api.github.com/repos/18F/State-TalentMAP/forks","keys_url":"https://api.github.com/repos/18F/State-TalentMAP/keys{/key_id}","collaborators_url":"https://api.github.com/repos/18F/State-TalentMAP/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/18F/State-TalentMAP/teams","hooks_url":"https://api.github.com/repos/18F/State-TalentMAP/hooks","issue_events_url":"https://api.github.com/repos/18F/State-TalentMAP/issues/events{/number}","events_url":"https://api.github.com/repos/18F/State-TalentMAP/events","assignees_url":"https://api.github.com/repos/18F/State-TalentMAP/assignees{/user}","branches_url":"https://api.github.com/repos/18F/State-TalentMAP/branches{/branch}","tags_url":"https://api.github.com/repos/18F/State-TalentMAP/tags","blobs_url":"https://api.github.com/repos/18F/State-TalentMAP/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/18F/State-TalentMAP/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/18F/State-TalentMAP/git/refs{/sha}","trees_url":"https://api.github.com/repos/18F/State-TalentMAP/git/trees{/sha}","statuses_url":"https://api.github.com/repos/18F/State-TalentMAP/statuses/{sha}","languages_url":"https://api.github.com/repos/18F/State-TalentMAP/languages","stargazers_url":"https://api.github.com/repos/18F/State-TalentMAP/stargazers","contributors_url":"https://api.github.com/repos/18F/State-TalentMAP/contributors","subscribers_url":"https://api.github.com/repos/18F/State-TalentMAP/subscribers","subscription_url":"https://api.github.com/repos/18F/State-TalentMAP/subscription","commits_url":"https://api.github.com/repos/18F/State-TalentMAP/commits{/sha}","git_commits_url":"https://api.github.com/repos/18F/State-TalentMAP/git/commits{/sha}","comments_url":"https://api.github.com/repos/18F/State-TalentMAP/comments{/number}","issue_comment_url":"https://api.github.com/repos/18F/State-TalentMAP/issues/comments{/number}","contents_url":"https://api.github.com/repos/18F/State-TalentMAP/contents/{+path}","compare_url":"https://api.github.com/repos/18F/State-TalentMAP/compare/{base}...{head}","merges_url":"https://api.github.com/repos/18F/State-TalentMAP/merges","archive_url":"https://api.github.com/repos/18F/State-TalentMAP/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/18F/State-TalentMAP/downloads","issues_url":"https://api.github.com/repos/18F/State-TalentMAP/issues{/number}","pulls_url":"https://api.github.com/repos/18F/State-TalentMAP/pulls{/number}","milestones_url":"https://api.github.com/repos/18F/State-TalentMAP/milestones{/number}","notifications_url":"https://api.github.com/repos/18F/State-TalentMAP/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/18F/State-TalentMAP/labels{/name}","releases_url":"https://api.github.com/repos/18F/State-TalentMAP/releases{/id}","deployments_url":"https://api.github.com/repos/18F/State-TalentMAP/deployments","created_at":"2017-05-18T18:04:17Z","updated_at":"2018-03-13T19:15:58Z","pushed_at":"2018-04-09T12:52:08Z","git_url":"git://github.com/18F/State-TalentMAP.git","ssh_url":"[email protected]:18F/State-TalentMAP.git","clone_url":"https://github.com/18F/State-TalentMAP.git","svn_url":"https://github.com/18F/State-TalentMAP","homepage":null,"size":16886,"stargazers_count":16,"watchers_count":16,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":403,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":6,"open_issues":403,"watchers":16,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/18F/State-TalentMAP/pulls/1725"},"html":{"href":"https://github.com/18F/State-TalentMAP/pull/1725"},"issue":{"href":"https://api.github.com/repos/18F/State-TalentMAP/issues/1725"},"comments":{"href":"https://api.github.com/repos/18F/State-TalentMAP/issues/1725/comments"},"review_comments":{"href":"https://api.github.com/repos/18F/State-TalentMAP/pulls/1725/comments"},"review_comment":{"href":"https://api.github.com/repos/18F/State-TalentMAP/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/18F/State-TalentMAP/pulls/1725/commits"},"statuses":{"href":"https://api.github.com/repos/18F/State-TalentMAP/statuses/e17db74acffa6cfa870ca9b98dbda0306795f66a"}},"author_association":"COLLABORATOR"}} | {
"id": 91723512,
"name": "18F/State-TalentMAP",
"url": "https://api.github.com/repos/18F/State-TalentMAP"
} | {
"id": 11576347,
"login": "mjoyce91",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/11576347?",
"url": "https://api.github.com/users/mjoyce91"
} | {
"id": 6233994,
"login": "18F",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6233994?",
"url": "https://api.github.com/orgs/18F"
} | 2018-04-09T13:12:05 | 7500560316 | {"actor":{"display_login":"mjoyce91"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/ethereum/solidity/pulls/comments/208879763","pull_request_review_id":144778663,"id":208879763,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwODg3OTc2Mw==","diff_hunk":"@@ -1180,9 +1181,32 @@ void CompilerUtils::computeHashStatic()\n \n void CompilerUtils::storeStringData(bytesConstRef _data)\n {\n-\t//@todo provide both alternatives to the optimiser\n+\t// @todo provide both alternatives to the optimiser\n \t// stack: mempos\n-\tif (_data.size() <= 128)\n+\tbool storeAsData = false;\n+\tif (_data.size() > 32)\n+\t{\n+\t\tunsigned numWords = (_data.size() + 31) / 32;\n+\t\t// @todo this does take the constant optimiser into account,\n+\t\t// which could reduce the costs of individual PUSHes\n+\t\t// NOTE: assumes the C++ compiler will optimise these statements\n+\t\tunsigned pushCost =\n+\t\t\t(eth::GasCosts::tier2Gas * numWords) + // PUSH value","path":"libsolidity/codegen/CompilerUtils.cpp","position":24,"original_position":24,"commit_id":"67eca29a9edaba94f698544b585d8cd32583beb1","original_commit_id":"67eca29a9edaba94f698544b585d8cd32583beb1","user":{"login":"chriseth","id":9073706,"node_id":"MDQ6VXNlcjkwNzM3MDY=","avatar_url":"https://avatars2.githubusercontent.com/u/9073706?v=4","gravatar_id":"","url":"https://api.github.com/users/chriseth","html_url":"https://github.com/chriseth","followers_url":"https://api.github.com/users/chriseth/followers","following_url":"https://api.github.com/users/chriseth/following{/other_user}","gists_url":"https://api.github.com/users/chriseth/gists{/gist_id}","starred_url":"https://api.github.com/users/chriseth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chriseth/subscriptions","organizations_url":"https://api.github.com/users/chriseth/orgs","repos_url":"https://api.github.com/users/chriseth/repos","events_url":"https://api.github.com/users/chriseth/events{/privacy}","received_events_url":"https://api.github.com/users/chriseth/received_events","type":"User","site_admin":false},"body":"Please use the gas meter in conjunction with a sequence of assembly items.","created_at":"2018-08-09T10:25:10Z","updated_at":"2018-08-09T10:25:10Z","html_url":"https://github.com/ethereum/solidity/pull/4779#discussion_r208879763","pull_request_url":"https://api.github.com/repos/ethereum/solidity/pulls/4779","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ethereum/solidity/pulls/comments/208879763"},"html":{"href":"https://github.com/ethereum/solidity/pull/4779#discussion_r208879763"},"pull_request":{"href":"https://api.github.com/repos/ethereum/solidity/pulls/4779"}}},"pull_request":{"url":"https://api.github.com/repos/ethereum/solidity/pulls/4779","id":207160513,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3MTYwNTEz","html_url":"https://github.com/ethereum/solidity/pull/4779","diff_url":"https://github.com/ethereum/solidity/pull/4779.diff","patch_url":"https://github.com/ethereum/solidity/pull/4779.patch","issue_url":"https://api.github.com/repos/ethereum/solidity/issues/4779","number":4779,"state":"open","locked":false,"title":"[WIP] Decide better in storing string literals as data","user":{"login":"axic","id":20340,"node_id":"MDQ6VXNlcjIwMzQw","avatar_url":"https://avatars3.githubusercontent.com/u/20340?v=4","gravatar_id":"","url":"https://api.github.com/users/axic","html_url":"https://github.com/axic","followers_url":"https://api.github.com/users/axic/followers","following_url":"https://api.github.com/users/axic/following{/other_user}","gists_url":"https://api.github.com/users/axic/gists{/gist_id}","starred_url":"https://api.github.com/users/axic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/axic/subscriptions","organizations_url":"https://api.github.com/users/axic/orgs","repos_url":"https://api.github.com/users/axic/repos","events_url":"https://api.github.com/users/axic/events{/privacy}","received_events_url":"https://api.github.com/users/axic/received_events","type":"User","site_admin":false},"body":"Fixes #4774.\r\n\r\n```\r\ncontract C {\r\n function f() pure public {\r\n require(false, \"This is a short text.\");\r\n require(true, \"This is a very long text likely to exceed the limit of 32 bytes per push. And more. Really this should exceed it now, finally.\");\r\n require(true, \"This is a very long text likely to exceed the limit of 32 bytes per push. And more. Really this should exceed it now, finally.\");\r\n require(true, \"This is a very long text likely to exceed the limit of 32 bytes per push. And more. Really this should exceed it now, finally.\");\r\n require(true, \"This is a very long text likely to exceed the limit of 32 bytes per push. And more. Really this should exceed it now, finally.\");\r\n require(true, \"This is a very long text likely to exceed the limit of 32 bytes per push. And more. Really this should exceed it now, finally.\");\r\n require(true, \"This is a very long text likely to exceed the limit of 32 bytes per push. And more. Really this should exceed it now, finally.\");\r\n require(true, \"This is a very long text likely to exceed the limit of 32 bytes per push. And more. Really this should exceed it now, finally.\");\r\n require(true, \"This is a very long text likely to exceed the limit of 32 bytes per push. And more. Really this should exceed it now, finally.\");\r\n require(true, \"This is a very long text likely to exceed the limit of 32 bytes per push. And more. Really this should exceed it now, finally.\");\r\n require(true, \"This is a very long text likely to exceed the limit of 32 bytes per push. And more. Really this should exceed it now, finally.\");\r\n require(true, \"This is a very long text likely to exceed the limit of 32 bytes per push. And more. Really this should exceed it now, finally.\");\r\n require(true, \"This is a very long text likely to exceed the limit of 32 bytes per push. And more. Really this should exceed it now, finally.\");\r\n require(true, \"This is a very long text likely to exceed the limit of 32 bytes per push. And more. Really this should exceed it now, finally.\");\r\n require(true, \"This is a very long text likely to exceed the limit of 32 bytes per push. And more. Really this should exceed it now, finally.\");\r\n require(true, \"This is a very long text likely to exceed the limit of 32 bytes per push. And more. Really this should exceed it now, finally.\");\r\n require(true, \"This is a very long text likely to exceed the limit of 32 bytes per push. And more. Really this should exceed it now, finally.\");\r\n }\r\n}\r\n```\r\n\r\nBefore:\r\n```\r\nGas estimation:\r\nconstruction:\r\n 831 + 793800 = 794631\r\nexternal:\r\n f():\t269\r\n```\r\n\r\nAfter:\r\n```\r\nGas estimation:\r\nconstruction:\r\n 399 + 361400 = 361799\r\nexternal:\r\n f():\t269\r\n```\r\n\r\nOne must add that storing string literal as data means it can be deduplicated, which is not the case with pushes.","created_at":"2018-08-08T22:58:57Z","updated_at":"2018-08-09T10:25:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9549523cf23c2f86fc1c79ca3b43d1c56e994fba","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ethereum/solidity/pulls/4779/commits","review_comments_url":"https://api.github.com/repos/ethereum/solidity/pulls/4779/comments","review_comment_url":"https://api.github.com/repos/ethereum/solidity/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ethereum/solidity/issues/4779/comments","statuses_url":"https://api.github.com/repos/ethereum/solidity/statuses/67eca29a9edaba94f698544b585d8cd32583beb1","head":{"label":"ethereum:optimise-string-literals","ref":"optimise-string-literals","sha":"67eca29a9edaba94f698544b585d8cd32583beb1","user":{"login":"ethereum","id":6250754,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyNTA3NTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/6250754?v=4","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"repo":{"id":40892817,"node_id":"MDEwOlJlcG9zaXRvcnk0MDg5MjgxNw==","name":"solidity","full_name":"ethereum/solidity","owner":{"login":"ethereum","id":6250754,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyNTA3NTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/6250754?v=4","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ethereum/solidity","description":"Solidity, the Contract-Oriented Programming Language","fork":false,"url":"https://api.github.com/repos/ethereum/solidity","forks_url":"https://api.github.com/repos/ethereum/solidity/forks","keys_url":"https://api.github.com/repos/ethereum/solidity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ethereum/solidity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ethereum/solidity/teams","hooks_url":"https://api.github.com/repos/ethereum/solidity/hooks","issue_events_url":"https://api.github.com/repos/ethereum/solidity/issues/events{/number}","events_url":"https://api.github.com/repos/ethereum/solidity/events","assignees_url":"https://api.github.com/repos/ethereum/solidity/assignees{/user}","branches_url":"https://api.github.com/repos/ethereum/solidity/branches{/branch}","tags_url":"https://api.github.com/repos/ethereum/solidity/tags","blobs_url":"https://api.github.com/repos/ethereum/solidity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ethereum/solidity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ethereum/solidity/git/refs{/sha}","trees_url":"https://api.github.com/repos/ethereum/solidity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ethereum/solidity/statuses/{sha}","languages_url":"https://api.github.com/repos/ethereum/solidity/languages","stargazers_url":"https://api.github.com/repos/ethereum/solidity/stargazers","contributors_url":"https://api.github.com/repos/ethereum/solidity/contributors","subscribers_url":"https://api.github.com/repos/ethereum/solidity/subscribers","subscription_url":"https://api.github.com/repos/ethereum/solidity/subscription","commits_url":"https://api.github.com/repos/ethereum/solidity/commits{/sha}","git_commits_url":"https://api.github.com/repos/ethereum/solidity/git/commits{/sha}","comments_url":"https://api.github.com/repos/ethereum/solidity/comments{/number}","issue_comment_url":"https://api.github.com/repos/ethereum/solidity/issues/comments{/number}","contents_url":"https://api.github.com/repos/ethereum/solidity/contents/{+path}","compare_url":"https://api.github.com/repos/ethereum/solidity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ethereum/solidity/merges","archive_url":"https://api.github.com/repos/ethereum/solidity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ethereum/solidity/downloads","issues_url":"https://api.github.com/repos/ethereum/solidity/issues{/number}","pulls_url":"https://api.github.com/repos/ethereum/solidity/pulls{/number}","milestones_url":"https://api.github.com/repos/ethereum/solidity/milestones{/number}","notifications_url":"https://api.github.com/repos/ethereum/solidity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ethereum/solidity/labels{/name}","releases_url":"https://api.github.com/repos/ethereum/solidity/releases{/id}","deployments_url":"https://api.github.com/repos/ethereum/solidity/deployments","created_at":"2015-08-17T12:27:26Z","updated_at":"2018-08-09T10:09:06Z","pushed_at":"2018-08-09T10:09:14Z","git_url":"git://github.com/ethereum/solidity.git","ssh_url":"[email protected]:ethereum/solidity.git","clone_url":"https://github.com/ethereum/solidity.git","svn_url":"https://github.com/ethereum/solidity","homepage":"https://solidity.readthedocs.io","size":22083,"stargazers_count":5673,"watchers_count":5673,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1513,"mirror_url":null,"archived":false,"open_issues_count":609,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":1513,"open_issues":609,"watchers":5673,"default_branch":"develop"}},"base":{"label":"ethereum:develop","ref":"develop","sha":"b4e33ec25ceb35b53876ad6af58148079dcbeeb7","user":{"login":"ethereum","id":6250754,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyNTA3NTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/6250754?v=4","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"repo":{"id":40892817,"node_id":"MDEwOlJlcG9zaXRvcnk0MDg5MjgxNw==","name":"solidity","full_name":"ethereum/solidity","owner":{"login":"ethereum","id":6250754,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyNTA3NTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/6250754?v=4","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ethereum/solidity","description":"Solidity, the Contract-Oriented Programming Language","fork":false,"url":"https://api.github.com/repos/ethereum/solidity","forks_url":"https://api.github.com/repos/ethereum/solidity/forks","keys_url":"https://api.github.com/repos/ethereum/solidity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ethereum/solidity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ethereum/solidity/teams","hooks_url":"https://api.github.com/repos/ethereum/solidity/hooks","issue_events_url":"https://api.github.com/repos/ethereum/solidity/issues/events{/number}","events_url":"https://api.github.com/repos/ethereum/solidity/events","assignees_url":"https://api.github.com/repos/ethereum/solidity/assignees{/user}","branches_url":"https://api.github.com/repos/ethereum/solidity/branches{/branch}","tags_url":"https://api.github.com/repos/ethereum/solidity/tags","blobs_url":"https://api.github.com/repos/ethereum/solidity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ethereum/solidity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ethereum/solidity/git/refs{/sha}","trees_url":"https://api.github.com/repos/ethereum/solidity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ethereum/solidity/statuses/{sha}","languages_url":"https://api.github.com/repos/ethereum/solidity/languages","stargazers_url":"https://api.github.com/repos/ethereum/solidity/stargazers","contributors_url":"https://api.github.com/repos/ethereum/solidity/contributors","subscribers_url":"https://api.github.com/repos/ethereum/solidity/subscribers","subscription_url":"https://api.github.com/repos/ethereum/solidity/subscription","commits_url":"https://api.github.com/repos/ethereum/solidity/commits{/sha}","git_commits_url":"https://api.github.com/repos/ethereum/solidity/git/commits{/sha}","comments_url":"https://api.github.com/repos/ethereum/solidity/comments{/number}","issue_comment_url":"https://api.github.com/repos/ethereum/solidity/issues/comments{/number}","contents_url":"https://api.github.com/repos/ethereum/solidity/contents/{+path}","compare_url":"https://api.github.com/repos/ethereum/solidity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ethereum/solidity/merges","archive_url":"https://api.github.com/repos/ethereum/solidity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ethereum/solidity/downloads","issues_url":"https://api.github.com/repos/ethereum/solidity/issues{/number}","pulls_url":"https://api.github.com/repos/ethereum/solidity/pulls{/number}","milestones_url":"https://api.github.com/repos/ethereum/solidity/milestones{/number}","notifications_url":"https://api.github.com/repos/ethereum/solidity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ethereum/solidity/labels{/name}","releases_url":"https://api.github.com/repos/ethereum/solidity/releases{/id}","deployments_url":"https://api.github.com/repos/ethereum/solidity/deployments","created_at":"2015-08-17T12:27:26Z","updated_at":"2018-08-09T10:09:06Z","pushed_at":"2018-08-09T10:09:14Z","git_url":"git://github.com/ethereum/solidity.git","ssh_url":"[email protected]:ethereum/solidity.git","clone_url":"https://github.com/ethereum/solidity.git","svn_url":"https://github.com/ethereum/solidity","homepage":"https://solidity.readthedocs.io","size":22083,"stargazers_count":5673,"watchers_count":5673,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1513,"mirror_url":null,"archived":false,"open_issues_count":609,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":1513,"open_issues":609,"watchers":5673,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/ethereum/solidity/pulls/4779"},"html":{"href":"https://github.com/ethereum/solidity/pull/4779"},"issue":{"href":"https://api.github.com/repos/ethereum/solidity/issues/4779"},"comments":{"href":"https://api.github.com/repos/ethereum/solidity/issues/4779/comments"},"review_comments":{"href":"https://api.github.com/repos/ethereum/solidity/pulls/4779/comments"},"review_comment":{"href":"https://api.github.com/repos/ethereum/solidity/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ethereum/solidity/pulls/4779/commits"},"statuses":{"href":"https://api.github.com/repos/ethereum/solidity/statuses/67eca29a9edaba94f698544b585d8cd32583beb1"}},"author_association":"MEMBER"}} | {
"id": 40892817,
"name": "ethereum/solidity",
"url": "https://api.github.com/repos/ethereum/solidity"
} | {
"id": 9073706,
"login": "chriseth",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9073706?",
"url": "https://api.github.com/users/chriseth"
} | {
"id": 6250754,
"login": "ethereum",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6250754?",
"url": "https://api.github.com/orgs/ethereum"
} | 2018-08-09T10:25:10 | 8089294627 | {"actor":{"display_login":"chriseth"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/ethereum/web3.js/pulls/comments/237898950","pull_request_review_id":180315835,"id":237898950,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNzg5ODk1MA==","diff_hunk":"@@ -0,0 +1,23 @@\n+/*\n+ This file is part of web3.js.\n+ web3.js is free software: you can redistribute it and/or modify\n+ it under the terms of the GNU Lesser General Public License as published by\n+ the Free Software Foundation, either version 3 of the License, or\n+ (at your option) any later version.\n+ web3.js is distributed in the hope that it will be useful,\n+ but WITHOUT ANY WARRANTY; without even the implied warranty of\n+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the\n+ GNU Lesser General Public License for more details.\n+ You should have received a copy of the GNU Lesser General Public License\n+ along with web3.js. If not, see <http://www.gnu.org/licenses/>.\n+*/\n+/**\n+ * @file index.d.ts\n+ * @author Josh Stevens <[email protected]>\n+ * @date 2018\n+ */\n+\n+export declare class PromiEvent {\n+ proxyHandler(target: PromiEvent, name: string): Function;\n+ }\n+ ","path":"packages/web3-core-promievent/index.d.ts","position":23,"original_position":23,"commit_id":"1de069e787da97f7dc3d6a72e43cc68cffe9502f","original_commit_id":"1de069e787da97f7dc3d6a72e43cc68cffe9502f","user":{"login":"joshstevens19","id":18472422,"node_id":"MDQ6VXNlcjE4NDcyNDIy","avatar_url":"https://avatars0.githubusercontent.com/u/18472422?v=4","gravatar_id":"","url":"https://api.github.com/users/joshstevens19","html_url":"https://github.com/joshstevens19","followers_url":"https://api.github.com/users/joshstevens19/followers","following_url":"https://api.github.com/users/joshstevens19/following{/other_user}","gists_url":"https://api.github.com/users/joshstevens19/gists{/gist_id}","starred_url":"https://api.github.com/users/joshstevens19/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshstevens19/subscriptions","organizations_url":"https://api.github.com/users/joshstevens19/orgs","repos_url":"https://api.github.com/users/joshstevens19/repos","events_url":"https://api.github.com/users/joshstevens19/events{/privacy}","received_events_url":"https://api.github.com/users/joshstevens19/received_events","type":"User","site_admin":false},"body":"ahh ok so we probably don't need types for this then? ","created_at":"2018-11-30T15:29:43Z","updated_at":"2018-11-30T15:29:43Z","html_url":"https://github.com/ethereum/web3.js/pull/2082#discussion_r237898950","pull_request_url":"https://api.github.com/repos/ethereum/web3.js/pulls/2082","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ethereum/web3.js/pulls/comments/237898950"},"html":{"href":"https://github.com/ethereum/web3.js/pull/2082#discussion_r237898950"},"pull_request":{"href":"https://api.github.com/repos/ethereum/web3.js/pulls/2082"}},"in_reply_to_id":237891621},"pull_request":{"url":"https://api.github.com/repos/ethereum/web3.js/pulls/2082","id":234901896,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM0OTAxODk2","html_url":"https://github.com/ethereum/web3.js/pull/2082","diff_url":"https://github.com/ethereum/web3.js/pull/2082.diff","patch_url":"https://github.com/ethereum/web3.js/pull/2082.patch","issue_url":"https://api.github.com/repos/ethereum/web3.js/issues/2082","number":2082,"state":"open","locked":false,"title":"Web3 core promievent types","user":{"login":"joshstevens19","id":18472422,"node_id":"MDQ6VXNlcjE4NDcyNDIy","avatar_url":"https://avatars0.githubusercontent.com/u/18472422?v=4","gravatar_id":"","url":"https://api.github.com/users/joshstevens19","html_url":"https://github.com/joshstevens19","followers_url":"https://api.github.com/users/joshstevens19/followers","following_url":"https://api.github.com/users/joshstevens19/following{/other_user}","gists_url":"https://api.github.com/users/joshstevens19/gists{/gist_id}","starred_url":"https://api.github.com/users/joshstevens19/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshstevens19/subscriptions","organizations_url":"https://api.github.com/users/joshstevens19/orgs","repos_url":"https://api.github.com/users/joshstevens19/repos","events_url":"https://api.github.com/users/joshstevens19/events{/privacy}","received_events_url":"https://api.github.com/users/joshstevens19/received_events","type":"User","site_admin":false},"body":"Types for `web3-core-promievent` 👍 ","created_at":"2018-11-30T07:59:57Z","updated_at":"2018-11-30T15:29:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"486bd8c8e269d3c53bb6d71e6d202c7cd6669a9d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ethereum/web3.js/pulls/2082/commits","review_comments_url":"https://api.github.com/repos/ethereum/web3.js/pulls/2082/comments","review_comment_url":"https://api.github.com/repos/ethereum/web3.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ethereum/web3.js/issues/2082/comments","statuses_url":"https://api.github.com/repos/ethereum/web3.js/statuses/1de069e787da97f7dc3d6a72e43cc68cffe9502f","head":{"label":"joshstevens19:web3-core-promievent-types","ref":"web3-core-promievent-types","sha":"1de069e787da97f7dc3d6a72e43cc68cffe9502f","user":{"login":"joshstevens19","id":18472422,"node_id":"MDQ6VXNlcjE4NDcyNDIy","avatar_url":"https://avatars0.githubusercontent.com/u/18472422?v=4","gravatar_id":"","url":"https://api.github.com/users/joshstevens19","html_url":"https://github.com/joshstevens19","followers_url":"https://api.github.com/users/joshstevens19/followers","following_url":"https://api.github.com/users/joshstevens19/following{/other_user}","gists_url":"https://api.github.com/users/joshstevens19/gists{/gist_id}","starred_url":"https://api.github.com/users/joshstevens19/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshstevens19/subscriptions","organizations_url":"https://api.github.com/users/joshstevens19/orgs","repos_url":"https://api.github.com/users/joshstevens19/repos","events_url":"https://api.github.com/users/joshstevens19/events{/privacy}","received_events_url":"https://api.github.com/users/joshstevens19/received_events","type":"User","site_admin":false},"repo":{"id":156678793,"node_id":"MDEwOlJlcG9zaXRvcnkxNTY2Nzg3OTM=","name":"web3.js","full_name":"joshstevens19/web3.js","private":false,"owner":{"login":"joshstevens19","id":18472422,"node_id":"MDQ6VXNlcjE4NDcyNDIy","avatar_url":"https://avatars0.githubusercontent.com/u/18472422?v=4","gravatar_id":"","url":"https://api.github.com/users/joshstevens19","html_url":"https://github.com/joshstevens19","followers_url":"https://api.github.com/users/joshstevens19/followers","following_url":"https://api.github.com/users/joshstevens19/following{/other_user}","gists_url":"https://api.github.com/users/joshstevens19/gists{/gist_id}","starred_url":"https://api.github.com/users/joshstevens19/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshstevens19/subscriptions","organizations_url":"https://api.github.com/users/joshstevens19/orgs","repos_url":"https://api.github.com/users/joshstevens19/repos","events_url":"https://api.github.com/users/joshstevens19/events{/privacy}","received_events_url":"https://api.github.com/users/joshstevens19/received_events","type":"User","site_admin":false},"html_url":"https://github.com/joshstevens19/web3.js","description":"Ethereum JavaScript API","fork":true,"url":"https://api.github.com/repos/joshstevens19/web3.js","forks_url":"https://api.github.com/repos/joshstevens19/web3.js/forks","keys_url":"https://api.github.com/repos/joshstevens19/web3.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joshstevens19/web3.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joshstevens19/web3.js/teams","hooks_url":"https://api.github.com/repos/joshstevens19/web3.js/hooks","issue_events_url":"https://api.github.com/repos/joshstevens19/web3.js/issues/events{/number}","events_url":"https://api.github.com/repos/joshstevens19/web3.js/events","assignees_url":"https://api.github.com/repos/joshstevens19/web3.js/assignees{/user}","branches_url":"https://api.github.com/repos/joshstevens19/web3.js/branches{/branch}","tags_url":"https://api.github.com/repos/joshstevens19/web3.js/tags","blobs_url":"https://api.github.com/repos/joshstevens19/web3.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joshstevens19/web3.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joshstevens19/web3.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/joshstevens19/web3.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joshstevens19/web3.js/statuses/{sha}","languages_url":"https://api.github.com/repos/joshstevens19/web3.js/languages","stargazers_url":"https://api.github.com/repos/joshstevens19/web3.js/stargazers","contributors_url":"https://api.github.com/repos/joshstevens19/web3.js/contributors","subscribers_url":"https://api.github.com/repos/joshstevens19/web3.js/subscribers","subscription_url":"https://api.github.com/repos/joshstevens19/web3.js/subscription","commits_url":"https://api.github.com/repos/joshstevens19/web3.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/joshstevens19/web3.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/joshstevens19/web3.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/joshstevens19/web3.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/joshstevens19/web3.js/contents/{+path}","compare_url":"https://api.github.com/repos/joshstevens19/web3.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joshstevens19/web3.js/merges","archive_url":"https://api.github.com/repos/joshstevens19/web3.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joshstevens19/web3.js/downloads","issues_url":"https://api.github.com/repos/joshstevens19/web3.js/issues{/number}","pulls_url":"https://api.github.com/repos/joshstevens19/web3.js/pulls{/number}","milestones_url":"https://api.github.com/repos/joshstevens19/web3.js/milestones{/number}","notifications_url":"https://api.github.com/repos/joshstevens19/web3.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joshstevens19/web3.js/labels{/name}","releases_url":"https://api.github.com/repos/joshstevens19/web3.js/releases{/id}","deployments_url":"https://api.github.com/repos/joshstevens19/web3.js/deployments","created_at":"2018-11-08T09:02:56Z","updated_at":"2018-11-17T23:52:35Z","pushed_at":"2018-11-30T11:23:32Z","git_url":"git://github.com/joshstevens19/web3.js.git","ssh_url":"[email protected]:joshstevens19/web3.js.git","clone_url":"https://github.com/joshstevens19/web3.js.git","svn_url":"https://github.com/joshstevens19/web3.js","homepage":"","size":35970,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"ethereum:ethereumProvider","ref":"ethereumProvider","sha":"441f46a519c9e2acacac4ddcf2cc4cb0634cbf52","user":{"login":"ethereum","id":6250754,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyNTA3NTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/6250754?v=4","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"repo":{"id":24655114,"node_id":"MDEwOlJlcG9zaXRvcnkyNDY1NTExNA==","name":"web3.js","full_name":"ethereum/web3.js","private":false,"owner":{"login":"ethereum","id":6250754,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyNTA3NTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/6250754?v=4","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ethereum/web3.js","description":"Ethereum JavaScript API","fork":false,"url":"https://api.github.com/repos/ethereum/web3.js","forks_url":"https://api.github.com/repos/ethereum/web3.js/forks","keys_url":"https://api.github.com/repos/ethereum/web3.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ethereum/web3.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ethereum/web3.js/teams","hooks_url":"https://api.github.com/repos/ethereum/web3.js/hooks","issue_events_url":"https://api.github.com/repos/ethereum/web3.js/issues/events{/number}","events_url":"https://api.github.com/repos/ethereum/web3.js/events","assignees_url":"https://api.github.com/repos/ethereum/web3.js/assignees{/user}","branches_url":"https://api.github.com/repos/ethereum/web3.js/branches{/branch}","tags_url":"https://api.github.com/repos/ethereum/web3.js/tags","blobs_url":"https://api.github.com/repos/ethereum/web3.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ethereum/web3.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ethereum/web3.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/ethereum/web3.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ethereum/web3.js/statuses/{sha}","languages_url":"https://api.github.com/repos/ethereum/web3.js/languages","stargazers_url":"https://api.github.com/repos/ethereum/web3.js/stargazers","contributors_url":"https://api.github.com/repos/ethereum/web3.js/contributors","subscribers_url":"https://api.github.com/repos/ethereum/web3.js/subscribers","subscription_url":"https://api.github.com/repos/ethereum/web3.js/subscription","commits_url":"https://api.github.com/repos/ethereum/web3.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/ethereum/web3.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/ethereum/web3.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/ethereum/web3.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/ethereum/web3.js/contents/{+path}","compare_url":"https://api.github.com/repos/ethereum/web3.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ethereum/web3.js/merges","archive_url":"https://api.github.com/repos/ethereum/web3.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ethereum/web3.js/downloads","issues_url":"https://api.github.com/repos/ethereum/web3.js/issues{/number}","pulls_url":"https://api.github.com/repos/ethereum/web3.js/pulls{/number}","milestones_url":"https://api.github.com/repos/ethereum/web3.js/milestones{/number}","notifications_url":"https://api.github.com/repos/ethereum/web3.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ethereum/web3.js/labels{/name}","releases_url":"https://api.github.com/repos/ethereum/web3.js/releases{/id}","deployments_url":"https://api.github.com/repos/ethereum/web3.js/deployments","created_at":"2014-09-30T20:50:37Z","updated_at":"2018-11-30T13:06:12Z","pushed_at":"2018-11-30T11:23:34Z","git_url":"git://github.com/ethereum/web3.js.git","ssh_url":"[email protected]:ethereum/web3.js.git","clone_url":"https://github.com/ethereum/web3.js.git","svn_url":"https://github.com/ethereum/web3.js","homepage":"","size":35174,"stargazers_count":7236,"watchers_count":7236,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2142,"mirror_url":null,"archived":false,"open_issues_count":375,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2142,"open_issues":375,"watchers":7236,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/ethereum/web3.js/pulls/2082"},"html":{"href":"https://github.com/ethereum/web3.js/pull/2082"},"issue":{"href":"https://api.github.com/repos/ethereum/web3.js/issues/2082"},"comments":{"href":"https://api.github.com/repos/ethereum/web3.js/issues/2082/comments"},"review_comments":{"href":"https://api.github.com/repos/ethereum/web3.js/pulls/2082/comments"},"review_comment":{"href":"https://api.github.com/repos/ethereum/web3.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ethereum/web3.js/pulls/2082/commits"},"statuses":{"href":"https://api.github.com/repos/ethereum/web3.js/statuses/1de069e787da97f7dc3d6a72e43cc68cffe9502f"}},"author_association":"CONTRIBUTOR"}} | {
"id": 24655114,
"name": "ethereum/web3.js",
"url": "https://api.github.com/repos/ethereum/web3.js"
} | {
"id": 18472422,
"login": "joshstevens19",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/18472422?",
"url": "https://api.github.com/users/joshstevens19"
} | {
"id": 6250754,
"login": "ethereum",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6250754?",
"url": "https://api.github.com/orgs/ethereum"
} | 2018-11-30T15:29:43 | 8676945579 | {"actor":{"display_login":"joshstevens19"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/ethereum/remix/pulls/comments/188926758","pull_request_review_id":121001515,"id":188926758,"diff_hunk":"@@ -187,6 +187,11 @@ module.exports = {\n if (code1 === code2) return true\n if (code2 === '0x') return false // abstract contract. see comment\n \n+ if (code2.substr(4, 40) === '0000000000000000000000000000000000000000') {\n+ // in the context of a library, that slot contains the address of the library (pushed by the compiler to avoid calling library other than with a DELEGATECALL)\n+ // if code2 is not a library, well we still suppose that the comparison remain relevant even if we remove some information from `code1`\n+ code1 = replaceLibReference(code1, 4)","path":"remix-lib/src/util.js","position":null,"original_position":7,"commit_id":"b358155425cc86f5b72b568f4c76ead5de2ed6a2","original_commit_id":"0cbfb3b8e1cfac2f26f38782549ab72c56632ec0","user":{"login":"axic","id":20340,"avatar_url":"https://avatars3.githubusercontent.com/u/20340?v=4","gravatar_id":"","url":"https://api.github.com/users/axic","html_url":"https://github.com/axic","followers_url":"https://api.github.com/users/axic/followers","following_url":"https://api.github.com/users/axic/following{/other_user}","gists_url":"https://api.github.com/users/axic/gists{/gist_id}","starred_url":"https://api.github.com/users/axic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/axic/subscriptions","organizations_url":"https://api.github.com/users/axic/orgs","repos_url":"https://api.github.com/users/axic/repos","events_url":"https://api.github.com/users/axic/events{/privacy}","received_events_url":"https://api.github.com/users/axic/received_events","type":"User","site_admin":false},"body":"`replaceLibReference` seems to have a lot of zero padding","created_at":"2018-05-17T11:36:15Z","updated_at":"2018-05-17T11:36:15Z","html_url":"https://github.com/ethereum/remix/pull/790#discussion_r188926758","pull_request_url":"https://api.github.com/repos/ethereum/remix/pulls/790","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ethereum/remix/pulls/comments/188926758"},"html":{"href":"https://github.com/ethereum/remix/pull/790#discussion_r188926758"},"pull_request":{"href":"https://api.github.com/repos/ethereum/remix/pulls/790"}},"in_reply_to_id":186996110},"pull_request":{"url":"https://api.github.com/repos/ethereum/remix/pulls/790","id":186863938,"html_url":"https://github.com/ethereum/remix/pull/790","diff_url":"https://github.com/ethereum/remix/pull/790.diff","patch_url":"https://github.com/ethereum/remix/pull/790.patch","issue_url":"https://api.github.com/repos/ethereum/remix/issues/790","number":790,"state":"open","locked":false,"title":"Fix library bytecode comparison","user":{"login":"yann300","id":6940742,"avatar_url":"https://avatars2.githubusercontent.com/u/6940742?v=4","gravatar_id":"","url":"https://api.github.com/users/yann300","html_url":"https://github.com/yann300","followers_url":"https://api.github.com/users/yann300/followers","following_url":"https://api.github.com/users/yann300/following{/other_user}","gists_url":"https://api.github.com/users/yann300/gists{/gist_id}","starred_url":"https://api.github.com/users/yann300/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yann300/subscriptions","organizations_url":"https://api.github.com/users/yann300/orgs","repos_url":"https://api.github.com/users/yann300/repos","events_url":"https://api.github.com/users/yann300/events{/privacy}","received_events_url":"https://api.github.com/users/yann300/received_events","type":"User","site_admin":false},"body":"In the context of a library, deployed bytecode contains the address of the library (pushed by the compiler to avoid calling library other than with a DELEGATECALL)\r\n\r\nIf code2 is not a library, we still suppose that the comparison remains relevant even if we remove some information from `code1`","created_at":"2018-05-09T09:22:01Z","updated_at":"2018-05-17T11:36:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"50af707689142008e3159a160b5c84f4a37e2ce3","assignee":{"login":"yann300","id":6940742,"avatar_url":"https://avatars2.githubusercontent.com/u/6940742?v=4","gravatar_id":"","url":"https://api.github.com/users/yann300","html_url":"https://github.com/yann300","followers_url":"https://api.github.com/users/yann300/followers","following_url":"https://api.github.com/users/yann300/following{/other_user}","gists_url":"https://api.github.com/users/yann300/gists{/gist_id}","starred_url":"https://api.github.com/users/yann300/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yann300/subscriptions","organizations_url":"https://api.github.com/users/yann300/orgs","repos_url":"https://api.github.com/users/yann300/repos","events_url":"https://api.github.com/users/yann300/events{/privacy}","received_events_url":"https://api.github.com/users/yann300/received_events","type":"User","site_admin":false},"assignees":[{"login":"yann300","id":6940742,"avatar_url":"https://avatars2.githubusercontent.com/u/6940742?v=4","gravatar_id":"","url":"https://api.github.com/users/yann300","html_url":"https://github.com/yann300","followers_url":"https://api.github.com/users/yann300/followers","following_url":"https://api.github.com/users/yann300/following{/other_user}","gists_url":"https://api.github.com/users/yann300/gists{/gist_id}","starred_url":"https://api.github.com/users/yann300/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yann300/subscriptions","organizations_url":"https://api.github.com/users/yann300/orgs","repos_url":"https://api.github.com/users/yann300/repos","events_url":"https://api.github.com/users/yann300/events{/privacy}","received_events_url":"https://api.github.com/users/yann300/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"iurimatias","id":176720,"avatar_url":"https://avatars2.githubusercontent.com/u/176720?v=4","gravatar_id":"","url":"https://api.github.com/users/iurimatias","html_url":"https://github.com/iurimatias","followers_url":"https://api.github.com/users/iurimatias/followers","following_url":"https://api.github.com/users/iurimatias/following{/other_user}","gists_url":"https://api.github.com/users/iurimatias/gists{/gist_id}","starred_url":"https://api.github.com/users/iurimatias/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iurimatias/subscriptions","organizations_url":"https://api.github.com/users/iurimatias/orgs","repos_url":"https://api.github.com/users/iurimatias/repos","events_url":"https://api.github.com/users/iurimatias/events{/privacy}","received_events_url":"https://api.github.com/users/iurimatias/received_events","type":"User","site_admin":false},{"login":"chriseth","id":9073706,"avatar_url":"https://avatars2.githubusercontent.com/u/9073706?v=4","gravatar_id":"","url":"https://api.github.com/users/chriseth","html_url":"https://github.com/chriseth","followers_url":"https://api.github.com/users/chriseth/followers","following_url":"https://api.github.com/users/chriseth/following{/other_user}","gists_url":"https://api.github.com/users/chriseth/gists{/gist_id}","starred_url":"https://api.github.com/users/chriseth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chriseth/subscriptions","organizations_url":"https://api.github.com/users/chriseth/orgs","repos_url":"https://api.github.com/users/chriseth/repos","events_url":"https://api.github.com/users/chriseth/events{/privacy}","received_events_url":"https://api.github.com/users/chriseth/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":890918811,"url":"https://api.github.com/repos/ethereum/remix/labels/3%20-%20Review","name":"3 - Review","color":"CCCCCC","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ethereum/remix/pulls/790/commits","review_comments_url":"https://api.github.com/repos/ethereum/remix/pulls/790/comments","review_comment_url":"https://api.github.com/repos/ethereum/remix/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ethereum/remix/issues/790/comments","statuses_url":"https://api.github.com/repos/ethereum/remix/statuses/b358155425cc86f5b72b568f4c76ead5de2ed6a2","head":{"label":"ethereum:fixLibraryComparison","ref":"fixLibraryComparison","sha":"b358155425cc86f5b72b568f4c76ead5de2ed6a2","user":{"login":"ethereum","id":6250754,"avatar_url":"https://avatars3.githubusercontent.com/u/6250754?v=4","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"repo":{"id":55957418,"name":"remix","full_name":"ethereum/remix","owner":{"login":"ethereum","id":6250754,"avatar_url":"https://avatars3.githubusercontent.com/u/6250754?v=4","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ethereum/remix","description":"Ethereum IDE and tools for the web","fork":false,"url":"https://api.github.com/repos/ethereum/remix","forks_url":"https://api.github.com/repos/ethereum/remix/forks","keys_url":"https://api.github.com/repos/ethereum/remix/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ethereum/remix/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ethereum/remix/teams","hooks_url":"https://api.github.com/repos/ethereum/remix/hooks","issue_events_url":"https://api.github.com/repos/ethereum/remix/issues/events{/number}","events_url":"https://api.github.com/repos/ethereum/remix/events","assignees_url":"https://api.github.com/repos/ethereum/remix/assignees{/user}","branches_url":"https://api.github.com/repos/ethereum/remix/branches{/branch}","tags_url":"https://api.github.com/repos/ethereum/remix/tags","blobs_url":"https://api.github.com/repos/ethereum/remix/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ethereum/remix/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ethereum/remix/git/refs{/sha}","trees_url":"https://api.github.com/repos/ethereum/remix/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ethereum/remix/statuses/{sha}","languages_url":"https://api.github.com/repos/ethereum/remix/languages","stargazers_url":"https://api.github.com/repos/ethereum/remix/stargazers","contributors_url":"https://api.github.com/repos/ethereum/remix/contributors","subscribers_url":"https://api.github.com/repos/ethereum/remix/subscribers","subscription_url":"https://api.github.com/repos/ethereum/remix/subscription","commits_url":"https://api.github.com/repos/ethereum/remix/commits{/sha}","git_commits_url":"https://api.github.com/repos/ethereum/remix/git/commits{/sha}","comments_url":"https://api.github.com/repos/ethereum/remix/comments{/number}","issue_comment_url":"https://api.github.com/repos/ethereum/remix/issues/comments{/number}","contents_url":"https://api.github.com/repos/ethereum/remix/contents/{+path}","compare_url":"https://api.github.com/repos/ethereum/remix/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ethereum/remix/merges","archive_url":"https://api.github.com/repos/ethereum/remix/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ethereum/remix/downloads","issues_url":"https://api.github.com/repos/ethereum/remix/issues{/number}","pulls_url":"https://api.github.com/repos/ethereum/remix/pulls{/number}","milestones_url":"https://api.github.com/repos/ethereum/remix/milestones{/number}","notifications_url":"https://api.github.com/repos/ethereum/remix/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ethereum/remix/labels{/name}","releases_url":"https://api.github.com/repos/ethereum/remix/releases{/id}","deployments_url":"https://api.github.com/repos/ethereum/remix/deployments","created_at":"2016-04-11T09:05:03Z","updated_at":"2018-05-17T09:12:43Z","pushed_at":"2018-05-17T08:46:21Z","git_url":"git://github.com/ethereum/remix.git","ssh_url":"[email protected]:ethereum/remix.git","clone_url":"https://github.com/ethereum/remix.git","svn_url":"https://github.com/ethereum/remix","homepage":null,"size":8950,"stargazers_count":501,"watchers_count":501,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":174,"mirror_url":null,"archived":false,"open_issues_count":60,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":174,"open_issues":60,"watchers":501,"default_branch":"master"}},"base":{"label":"ethereum:master","ref":"master","sha":"4f664fc7fb75bc938c4be8ef090054c7ea52e163","user":{"login":"ethereum","id":6250754,"avatar_url":"https://avatars3.githubusercontent.com/u/6250754?v=4","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"repo":{"id":55957418,"name":"remix","full_name":"ethereum/remix","owner":{"login":"ethereum","id":6250754,"avatar_url":"https://avatars3.githubusercontent.com/u/6250754?v=4","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ethereum/remix","description":"Ethereum IDE and tools for the web","fork":false,"url":"https://api.github.com/repos/ethereum/remix","forks_url":"https://api.github.com/repos/ethereum/remix/forks","keys_url":"https://api.github.com/repos/ethereum/remix/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ethereum/remix/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ethereum/remix/teams","hooks_url":"https://api.github.com/repos/ethereum/remix/hooks","issue_events_url":"https://api.github.com/repos/ethereum/remix/issues/events{/number}","events_url":"https://api.github.com/repos/ethereum/remix/events","assignees_url":"https://api.github.com/repos/ethereum/remix/assignees{/user}","branches_url":"https://api.github.com/repos/ethereum/remix/branches{/branch}","tags_url":"https://api.github.com/repos/ethereum/remix/tags","blobs_url":"https://api.github.com/repos/ethereum/remix/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ethereum/remix/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ethereum/remix/git/refs{/sha}","trees_url":"https://api.github.com/repos/ethereum/remix/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ethereum/remix/statuses/{sha}","languages_url":"https://api.github.com/repos/ethereum/remix/languages","stargazers_url":"https://api.github.com/repos/ethereum/remix/stargazers","contributors_url":"https://api.github.com/repos/ethereum/remix/contributors","subscribers_url":"https://api.github.com/repos/ethereum/remix/subscribers","subscription_url":"https://api.github.com/repos/ethereum/remix/subscription","commits_url":"https://api.github.com/repos/ethereum/remix/commits{/sha}","git_commits_url":"https://api.github.com/repos/ethereum/remix/git/commits{/sha}","comments_url":"https://api.github.com/repos/ethereum/remix/comments{/number}","issue_comment_url":"https://api.github.com/repos/ethereum/remix/issues/comments{/number}","contents_url":"https://api.github.com/repos/ethereum/remix/contents/{+path}","compare_url":"https://api.github.com/repos/ethereum/remix/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ethereum/remix/merges","archive_url":"https://api.github.com/repos/ethereum/remix/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ethereum/remix/downloads","issues_url":"https://api.github.com/repos/ethereum/remix/issues{/number}","pulls_url":"https://api.github.com/repos/ethereum/remix/pulls{/number}","milestones_url":"https://api.github.com/repos/ethereum/remix/milestones{/number}","notifications_url":"https://api.github.com/repos/ethereum/remix/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ethereum/remix/labels{/name}","releases_url":"https://api.github.com/repos/ethereum/remix/releases{/id}","deployments_url":"https://api.github.com/repos/ethereum/remix/deployments","created_at":"2016-04-11T09:05:03Z","updated_at":"2018-05-17T09:12:43Z","pushed_at":"2018-05-17T08:46:21Z","git_url":"git://github.com/ethereum/remix.git","ssh_url":"[email protected]:ethereum/remix.git","clone_url":"https://github.com/ethereum/remix.git","svn_url":"https://github.com/ethereum/remix","homepage":null,"size":8950,"stargazers_count":501,"watchers_count":501,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":174,"mirror_url":null,"archived":false,"open_issues_count":60,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":174,"open_issues":60,"watchers":501,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ethereum/remix/pulls/790"},"html":{"href":"https://github.com/ethereum/remix/pull/790"},"issue":{"href":"https://api.github.com/repos/ethereum/remix/issues/790"},"comments":{"href":"https://api.github.com/repos/ethereum/remix/issues/790/comments"},"review_comments":{"href":"https://api.github.com/repos/ethereum/remix/pulls/790/comments"},"review_comment":{"href":"https://api.github.com/repos/ethereum/remix/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ethereum/remix/pulls/790/commits"},"statuses":{"href":"https://api.github.com/repos/ethereum/remix/statuses/b358155425cc86f5b72b568f4c76ead5de2ed6a2"}},"author_association":"COLLABORATOR"}} | {
"id": 55957418,
"name": "ethereum/remix",
"url": "https://api.github.com/repos/ethereum/remix"
} | {
"id": 20340,
"login": "axic",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/20340?",
"url": "https://api.github.com/users/axic"
} | {
"id": 6250754,
"login": "ethereum",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6250754?",
"url": "https://api.github.com/orgs/ethereum"
} | 2018-05-17T11:36:15 | 7689090195 | {"actor":{"display_login":"axic"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/godotengine/godot-docs/pulls/comments/208095135","pull_request_review_id":143835670,"id":208095135,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwODA5NTEzNQ==","diff_hunk":"@@ -0,0 +1,226 @@\n+.. _doc_2d_lights_and_shadows:\n+\n+Working with lights and shadows in 2D\n+=====================================\n+\n+Introduction\n+------------\n+\n+This tutorial will explain how the 2D lighting works in the \n+`lights and shadows <https://github.com/godotengine/godot-demo-projects/tree/master/2d/lights_and_shadows>`_ demo project.\n+It begins with a brief description of the resources used final demo and then describes how\n+to make a scene like the demo step by step.\n+\n+.. image:: img/light_shadow_main.png\n+\n+All the resources for this tutorial can be found in the `official demo repository <https://github.com/godotengine/godot-demo-projects>`_\n+on github. I suggest you download it before starting. Alternatively, \n+it can be downloaded from the project manager. Just launch Godot and in the top \n+bar select \"Templates\" and search for \"2D Lights and Shadows Demo\".\n+\n+Setup\n+-----\n+\n+For this demo we use four textures: two for the lights, one for the shadow casters, \n+and one for the background. I've included links to them all here if you want to download them\n+separate from the demo.\n+\n+The first is the background image (`bg.png <https://raw.githubusercontent.com/godotengine/godot-demo-projects/master/2d/lights_and_shadows/bg.png>`_) \n+used in the demo. You do not necessarily need a background, but we use one for the demo.\n+\n+The second is a plain black image (`caster.png <https://raw.githubusercontent.com/godotengine/godot-demo-projects/master/2d/lights_and_shadows/caster.png>`_) \n+to use as our shadow caster object. For a top down game this could be a wall or any \n+other object that casts a shadow.\n+\n+Next is the light itself (`light.png <https://raw.githubusercontent.com/godotengine/godot-demo-projects/master/2d/lights_and_shadows/light.png>`_). \n+If you click the link you will notice how large it is. The image you use \n+for a light should cover the area you want your light to cover. This image is \n+1024x1024 pixels, so you should use it to cover 1024x1024 pixels in your game.\n+\n+Lastly, we have the spotlight image (`spot.png <https://raw.githubusercontent.com/godotengine/godot-demo-projects/master/2d/lights_and_shadows/spot.png>`_). \n+The demo uses a blob to show where the light is and the larger light \n+image to show the effect of the light upon the rest of the scene.\n+\n+\n+Nodes\n+-----\n+\n+The demo uses four different nodes:\n+ * :ref:`CanvasModulate <class_CanvasModulate>`\n+ * :ref:`Sprite <class_Sprite>`\n+ * :ref:`Light2D <class_Light2D>`\n+ * :ref:`LightOccluder2D <class_LightOccluder2D>`\n+\n+:ref:`CanvasModulate<class_CanvasModulate>` is used to add ambient light to the scene. Ambient \n+light is not actually necessary, it just darkens the scene. ","path":"tutorials/2d/2d_lights_and_shadows.rst","position":55,"original_position":55,"commit_id":"45d6be0bd26bc5c5540026b2fea92bf5c4cedd7e","original_commit_id":"45d6be0bd26bc5c5540026b2fea92bf5c4cedd7e","user":{"login":"cbscribe","id":3812514,"node_id":"MDQ6VXNlcjM4MTI1MTQ=","avatar_url":"https://avatars2.githubusercontent.com/u/3812514?v=4","gravatar_id":"","url":"https://api.github.com/users/cbscribe","html_url":"https://github.com/cbscribe","followers_url":"https://api.github.com/users/cbscribe/followers","following_url":"https://api.github.com/users/cbscribe/following{/other_user}","gists_url":"https://api.github.com/users/cbscribe/gists{/gist_id}","starred_url":"https://api.github.com/users/cbscribe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cbscribe/subscriptions","organizations_url":"https://api.github.com/users/cbscribe/orgs","repos_url":"https://api.github.com/users/cbscribe/repos","events_url":"https://api.github.com/users/cbscribe/events{/privacy}","received_events_url":"https://api.github.com/users/cbscribe/received_events","type":"User","site_admin":false},"body":"Need some clarification here. Saying \"ambient light darkens the scene\" seems counter-intuitive.","created_at":"2018-08-07T04:22:36Z","updated_at":"2018-08-07T04:50:38Z","html_url":"https://github.com/godotengine/godot-docs/pull/1648#discussion_r208095135","pull_request_url":"https://api.github.com/repos/godotengine/godot-docs/pulls/1648","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/godotengine/godot-docs/pulls/comments/208095135"},"html":{"href":"https://github.com/godotengine/godot-docs/pull/1648#discussion_r208095135"},"pull_request":{"href":"https://api.github.com/repos/godotengine/godot-docs/pulls/1648"}}},"pull_request":{"url":"https://api.github.com/repos/godotengine/godot-docs/pulls/1648","id":206224036,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2MjI0MDM2","html_url":"https://github.com/godotengine/godot-docs/pull/1648","diff_url":"https://github.com/godotengine/godot-docs/pull/1648.diff","patch_url":"https://github.com/godotengine/godot-docs/pull/1648.patch","issue_url":"https://api.github.com/repos/godotengine/godot-docs/issues/1648","number":1648,"state":"open","locked":false,"title":"Added lights and shadows tutorial","user":{"login":"clayjohn","id":16521339,"node_id":"MDQ6VXNlcjE2NTIxMzM5","avatar_url":"https://avatars2.githubusercontent.com/u/16521339?v=4","gravatar_id":"","url":"https://api.github.com/users/clayjohn","html_url":"https://github.com/clayjohn","followers_url":"https://api.github.com/users/clayjohn/followers","following_url":"https://api.github.com/users/clayjohn/following{/other_user}","gists_url":"https://api.github.com/users/clayjohn/gists{/gist_id}","starred_url":"https://api.github.com/users/clayjohn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clayjohn/subscriptions","organizations_url":"https://api.github.com/users/clayjohn/orgs","repos_url":"https://api.github.com/users/clayjohn/repos","events_url":"https://api.github.com/users/clayjohn/events{/privacy}","received_events_url":"https://api.github.com/users/clayjohn/received_events","type":"User","site_admin":false},"body":"As per #1553 I have added a tutorial explaining how the lights and shadows demo project works. \r\n\r\nMany newbies seem to be confused how lighting works in 2d. So hopefully this will help.\r\n\r\nComments welcome!","created_at":"2018-08-05T06:11:45Z","updated_at":"2018-08-07T04:50:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b72e941780fc6e8f50a30337515925675bdf6f67","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/godotengine/godot-docs/pulls/1648/commits","review_comments_url":"https://api.github.com/repos/godotengine/godot-docs/pulls/1648/comments","review_comment_url":"https://api.github.com/repos/godotengine/godot-docs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/godotengine/godot-docs/issues/1648/comments","statuses_url":"https://api.github.com/repos/godotengine/godot-docs/statuses/45d6be0bd26bc5c5540026b2fea92bf5c4cedd7e","head":{"label":"clayjohn:2d_light_and_shadows","ref":"2d_light_and_shadows","sha":"45d6be0bd26bc5c5540026b2fea92bf5c4cedd7e","user":{"login":"clayjohn","id":16521339,"node_id":"MDQ6VXNlcjE2NTIxMzM5","avatar_url":"https://avatars2.githubusercontent.com/u/16521339?v=4","gravatar_id":"","url":"https://api.github.com/users/clayjohn","html_url":"https://github.com/clayjohn","followers_url":"https://api.github.com/users/clayjohn/followers","following_url":"https://api.github.com/users/clayjohn/following{/other_user}","gists_url":"https://api.github.com/users/clayjohn/gists{/gist_id}","starred_url":"https://api.github.com/users/clayjohn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clayjohn/subscriptions","organizations_url":"https://api.github.com/users/clayjohn/orgs","repos_url":"https://api.github.com/users/clayjohn/repos","events_url":"https://api.github.com/users/clayjohn/events{/privacy}","received_events_url":"https://api.github.com/users/clayjohn/received_events","type":"User","site_admin":false},"repo":{"id":133194066,"node_id":"MDEwOlJlcG9zaXRvcnkxMzMxOTQwNjY=","name":"godot-docs","full_name":"clayjohn/godot-docs","owner":{"login":"clayjohn","id":16521339,"node_id":"MDQ6VXNlcjE2NTIxMzM5","avatar_url":"https://avatars2.githubusercontent.com/u/16521339?v=4","gravatar_id":"","url":"https://api.github.com/users/clayjohn","html_url":"https://github.com/clayjohn","followers_url":"https://api.github.com/users/clayjohn/followers","following_url":"https://api.github.com/users/clayjohn/following{/other_user}","gists_url":"https://api.github.com/users/clayjohn/gists{/gist_id}","starred_url":"https://api.github.com/users/clayjohn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clayjohn/subscriptions","organizations_url":"https://api.github.com/users/clayjohn/orgs","repos_url":"https://api.github.com/users/clayjohn/repos","events_url":"https://api.github.com/users/clayjohn/events{/privacy}","received_events_url":"https://api.github.com/users/clayjohn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/clayjohn/godot-docs","description":"Godot Engine official documentation","fork":true,"url":"https://api.github.com/repos/clayjohn/godot-docs","forks_url":"https://api.github.com/repos/clayjohn/godot-docs/forks","keys_url":"https://api.github.com/repos/clayjohn/godot-docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/clayjohn/godot-docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/clayjohn/godot-docs/teams","hooks_url":"https://api.github.com/repos/clayjohn/godot-docs/hooks","issue_events_url":"https://api.github.com/repos/clayjohn/godot-docs/issues/events{/number}","events_url":"https://api.github.com/repos/clayjohn/godot-docs/events","assignees_url":"https://api.github.com/repos/clayjohn/godot-docs/assignees{/user}","branches_url":"https://api.github.com/repos/clayjohn/godot-docs/branches{/branch}","tags_url":"https://api.github.com/repos/clayjohn/godot-docs/tags","blobs_url":"https://api.github.com/repos/clayjohn/godot-docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/clayjohn/godot-docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/clayjohn/godot-docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/clayjohn/godot-docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/clayjohn/godot-docs/statuses/{sha}","languages_url":"https://api.github.com/repos/clayjohn/godot-docs/languages","stargazers_url":"https://api.github.com/repos/clayjohn/godot-docs/stargazers","contributors_url":"https://api.github.com/repos/clayjohn/godot-docs/contributors","subscribers_url":"https://api.github.com/repos/clayjohn/godot-docs/subscribers","subscription_url":"https://api.github.com/repos/clayjohn/godot-docs/subscription","commits_url":"https://api.github.com/repos/clayjohn/godot-docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/clayjohn/godot-docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/clayjohn/godot-docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/clayjohn/godot-docs/issues/comments{/number}","contents_url":"https://api.github.com/repos/clayjohn/godot-docs/contents/{+path}","compare_url":"https://api.github.com/repos/clayjohn/godot-docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/clayjohn/godot-docs/merges","archive_url":"https://api.github.com/repos/clayjohn/godot-docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/clayjohn/godot-docs/downloads","issues_url":"https://api.github.com/repos/clayjohn/godot-docs/issues{/number}","pulls_url":"https://api.github.com/repos/clayjohn/godot-docs/pulls{/number}","milestones_url":"https://api.github.com/repos/clayjohn/godot-docs/milestones{/number}","notifications_url":"https://api.github.com/repos/clayjohn/godot-docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/clayjohn/godot-docs/labels{/name}","releases_url":"https://api.github.com/repos/clayjohn/godot-docs/releases{/id}","deployments_url":"https://api.github.com/repos/clayjohn/godot-docs/deployments","created_at":"2018-05-13T00:40:37Z","updated_at":"2018-07-30T23:53:24Z","pushed_at":"2018-08-05T07:53:22Z","git_url":"git://github.com/clayjohn/godot-docs.git","ssh_url":"[email protected]:clayjohn/godot-docs.git","clone_url":"https://github.com/clayjohn/godot-docs.git","svn_url":"https://github.com/clayjohn/godot-docs","homepage":"http://docs.godotengine.org","size":290552,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"godotengine:master","ref":"master","sha":"72e4322148c7e9b9b6cf6a75cf3d4bb57b8d7b6c","user":{"login":"godotengine","id":6318500,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYzMTg1MDA=","avatar_url":"https://avatars2.githubusercontent.com/u/6318500?v=4","gravatar_id":"","url":"https://api.github.com/users/godotengine","html_url":"https://github.com/godotengine","followers_url":"https://api.github.com/users/godotengine/followers","following_url":"https://api.github.com/users/godotengine/following{/other_user}","gists_url":"https://api.github.com/users/godotengine/gists{/gist_id}","starred_url":"https://api.github.com/users/godotengine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/godotengine/subscriptions","organizations_url":"https://api.github.com/users/godotengine/orgs","repos_url":"https://api.github.com/users/godotengine/repos","events_url":"https://api.github.com/users/godotengine/events{/privacy}","received_events_url":"https://api.github.com/users/godotengine/received_events","type":"Organization","site_admin":false},"repo":{"id":47882383,"node_id":"MDEwOlJlcG9zaXRvcnk0Nzg4MjM4Mw==","name":"godot-docs","full_name":"godotengine/godot-docs","owner":{"login":"godotengine","id":6318500,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYzMTg1MDA=","avatar_url":"https://avatars2.githubusercontent.com/u/6318500?v=4","gravatar_id":"","url":"https://api.github.com/users/godotengine","html_url":"https://github.com/godotengine","followers_url":"https://api.github.com/users/godotengine/followers","following_url":"https://api.github.com/users/godotengine/following{/other_user}","gists_url":"https://api.github.com/users/godotengine/gists{/gist_id}","starred_url":"https://api.github.com/users/godotengine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/godotengine/subscriptions","organizations_url":"https://api.github.com/users/godotengine/orgs","repos_url":"https://api.github.com/users/godotengine/repos","events_url":"https://api.github.com/users/godotengine/events{/privacy}","received_events_url":"https://api.github.com/users/godotengine/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/godotengine/godot-docs","description":"Godot Engine official documentation","fork":false,"url":"https://api.github.com/repos/godotengine/godot-docs","forks_url":"https://api.github.com/repos/godotengine/godot-docs/forks","keys_url":"https://api.github.com/repos/godotengine/godot-docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/godotengine/godot-docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/godotengine/godot-docs/teams","hooks_url":"https://api.github.com/repos/godotengine/godot-docs/hooks","issue_events_url":"https://api.github.com/repos/godotengine/godot-docs/issues/events{/number}","events_url":"https://api.github.com/repos/godotengine/godot-docs/events","assignees_url":"https://api.github.com/repos/godotengine/godot-docs/assignees{/user}","branches_url":"https://api.github.com/repos/godotengine/godot-docs/branches{/branch}","tags_url":"https://api.github.com/repos/godotengine/godot-docs/tags","blobs_url":"https://api.github.com/repos/godotengine/godot-docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/godotengine/godot-docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/godotengine/godot-docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/godotengine/godot-docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/godotengine/godot-docs/statuses/{sha}","languages_url":"https://api.github.com/repos/godotengine/godot-docs/languages","stargazers_url":"https://api.github.com/repos/godotengine/godot-docs/stargazers","contributors_url":"https://api.github.com/repos/godotengine/godot-docs/contributors","subscribers_url":"https://api.github.com/repos/godotengine/godot-docs/subscribers","subscription_url":"https://api.github.com/repos/godotengine/godot-docs/subscription","commits_url":"https://api.github.com/repos/godotengine/godot-docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/godotengine/godot-docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/godotengine/godot-docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/godotengine/godot-docs/issues/comments{/number}","contents_url":"https://api.github.com/repos/godotengine/godot-docs/contents/{+path}","compare_url":"https://api.github.com/repos/godotengine/godot-docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/godotengine/godot-docs/merges","archive_url":"https://api.github.com/repos/godotengine/godot-docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/godotengine/godot-docs/downloads","issues_url":"https://api.github.com/repos/godotengine/godot-docs/issues{/number}","pulls_url":"https://api.github.com/repos/godotengine/godot-docs/pulls{/number}","milestones_url":"https://api.github.com/repos/godotengine/godot-docs/milestones{/number}","notifications_url":"https://api.github.com/repos/godotengine/godot-docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/godotengine/godot-docs/labels{/name}","releases_url":"https://api.github.com/repos/godotengine/godot-docs/releases{/id}","deployments_url":"https://api.github.com/repos/godotengine/godot-docs/deployments","created_at":"2015-12-12T15:02:06Z","updated_at":"2018-08-07T01:43:06Z","pushed_at":"2018-08-07T03:06:45Z","git_url":"git://github.com/godotengine/godot-docs.git","ssh_url":"[email protected]:godotengine/godot-docs.git","clone_url":"https://github.com/godotengine/godot-docs.git","svn_url":"https://github.com/godotengine/godot-docs","homepage":"http://docs.godotengine.org","size":289609,"stargazers_count":360,"watchers_count":360,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":624,"mirror_url":null,"archived":false,"open_issues_count":189,"license":null,"forks":624,"open_issues":189,"watchers":360,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/godotengine/godot-docs/pulls/1648"},"html":{"href":"https://github.com/godotengine/godot-docs/pull/1648"},"issue":{"href":"https://api.github.com/repos/godotengine/godot-docs/issues/1648"},"comments":{"href":"https://api.github.com/repos/godotengine/godot-docs/issues/1648/comments"},"review_comments":{"href":"https://api.github.com/repos/godotengine/godot-docs/pulls/1648/comments"},"review_comment":{"href":"https://api.github.com/repos/godotengine/godot-docs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/godotengine/godot-docs/pulls/1648/commits"},"statuses":{"href":"https://api.github.com/repos/godotengine/godot-docs/statuses/45d6be0bd26bc5c5540026b2fea92bf5c4cedd7e"}},"author_association":"CONTRIBUTOR"}} | {
"id": 47882383,
"name": "godotengine/godot-docs",
"url": "https://api.github.com/repos/godotengine/godot-docs"
} | {
"id": 3812514,
"login": "cbscribe",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3812514?",
"url": "https://api.github.com/users/cbscribe"
} | {
"id": 6318500,
"login": "godotengine",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6318500?",
"url": "https://api.github.com/orgs/godotengine"
} | 2018-08-07T04:22:36 | 8075305892 | {"actor":{"display_login":"cbscribe"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/overleaf/writelatex-git-bridge/pulls/comments/239380737","pull_request_review_id":182147606,"id":239380737,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzOTM4MDczNw==","diff_hunk":"@@ -74,6 +75,32 @@ public ProjectRepo initRepo(String project) throws IOException {\n ret, Optional.of(maxFileSize), Optional.empty());\n }\n \n+ @Override\n+ public ProjectRepo initRepoFromExisting(\n+ String project, String fromProject\n+ ) throws IOException {\n+ String repoRoot = getRepoStorePath();\n+ String sourcePath = repoRoot + \"/\" + fromProject;\n+ String destinationPath = repoRoot + \"/\" + project;\n+ Log.info(\"[{}] Init repo by copying data from: {}, to: {}\",\n+ project,\n+ sourcePath,\n+ destinationPath\n+ );\n+ try {\n+ File source = new File(sourcePath);\n+ File destination = new File(destinationPath);\n+ FileUtils.copyDirectory(source, destination);\n+ } catch (Exception e) {","path":"src/main/java/uk/ac/ic/wlgitbridge/bridge/repo/FSGitRepoStore.java","position":28,"original_position":28,"commit_id":"1b5db4edb0dcbae5d02fd3260829adc683aa4ba0","original_commit_id":"1b5db4edb0dcbae5d02fd3260829adc683aa4ba0","user":{"login":"ShaneKilkelly","id":1540054,"node_id":"MDQ6VXNlcjE1NDAwNTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1540054?v=4","gravatar_id":"","url":"https://api.github.com/users/ShaneKilkelly","html_url":"https://github.com/ShaneKilkelly","followers_url":"https://api.github.com/users/ShaneKilkelly/followers","following_url":"https://api.github.com/users/ShaneKilkelly/following{/other_user}","gists_url":"https://api.github.com/users/ShaneKilkelly/gists{/gist_id}","starred_url":"https://api.github.com/users/ShaneKilkelly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ShaneKilkelly/subscriptions","organizations_url":"https://api.github.com/users/ShaneKilkelly/orgs","repos_url":"https://api.github.com/users/ShaneKilkelly/repos","events_url":"https://api.github.com/users/ShaneKilkelly/events{/privacy}","received_events_url":"https://api.github.com/users/ShaneKilkelly/received_events","type":"User","site_admin":false},"body":"Sure :+1: ","created_at":"2018-12-06T09:30:57Z","updated_at":"2018-12-06T09:30:57Z","html_url":"https://github.com/overleaf/writelatex-git-bridge/pull/45#discussion_r239380737","pull_request_url":"https://api.github.com/repos/overleaf/writelatex-git-bridge/pulls/45","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/overleaf/writelatex-git-bridge/pulls/comments/239380737"},"html":{"href":"https://github.com/overleaf/writelatex-git-bridge/pull/45#discussion_r239380737"},"pull_request":{"href":"https://api.github.com/repos/overleaf/writelatex-git-bridge/pulls/45"}},"in_reply_to_id":239157146},"pull_request":{"url":"https://api.github.com/repos/overleaf/writelatex-git-bridge/pulls/45","id":233877712,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzODc3NzEy","html_url":"https://github.com/overleaf/writelatex-git-bridge/pull/45","diff_url":"https://github.com/overleaf/writelatex-git-bridge/pull/45.diff","patch_url":"https://github.com/overleaf/writelatex-git-bridge/pull/45.patch","issue_url":"https://api.github.com/repos/overleaf/writelatex-git-bridge/issues/45","number":45,"state":"open","locked":false,"title":"Migrate repos from v1 to v2","user":{"login":"ShaneKilkelly","id":1540054,"node_id":"MDQ6VXNlcjE1NDAwNTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1540054?v=4","gravatar_id":"","url":"https://api.github.com/users/ShaneKilkelly","html_url":"https://github.com/ShaneKilkelly","followers_url":"https://api.github.com/users/ShaneKilkelly/followers","following_url":"https://api.github.com/users/ShaneKilkelly/following{/other_user}","gists_url":"https://api.github.com/users/ShaneKilkelly/gists{/gist_id}","starred_url":"https://api.github.com/users/ShaneKilkelly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ShaneKilkelly/subscriptions","organizations_url":"https://api.github.com/users/ShaneKilkelly/orgs","repos_url":"https://api.github.com/users/ShaneKilkelly/repos","events_url":"https://api.github.com/users/ShaneKilkelly/events{/privacy}","received_events_url":"https://api.github.com/users/ShaneKilkelly/received_events","type":"User","site_admin":false},"body":"Child of https://github.com/overleaf/sharelatex/issues/1247\r\n\r\nAllows git-bridge to handle projects which have migrated from v1 to v2.","created_at":"2018-11-27T11:36:36Z","updated_at":"2018-12-06T09:30:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ee3c7cf3ff31a3371e5d411b0d5ec23e24ffda96","assignee":{"login":"ShaneKilkelly","id":1540054,"node_id":"MDQ6VXNlcjE1NDAwNTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1540054?v=4","gravatar_id":"","url":"https://api.github.com/users/ShaneKilkelly","html_url":"https://github.com/ShaneKilkelly","followers_url":"https://api.github.com/users/ShaneKilkelly/followers","following_url":"https://api.github.com/users/ShaneKilkelly/following{/other_user}","gists_url":"https://api.github.com/users/ShaneKilkelly/gists{/gist_id}","starred_url":"https://api.github.com/users/ShaneKilkelly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ShaneKilkelly/subscriptions","organizations_url":"https://api.github.com/users/ShaneKilkelly/orgs","repos_url":"https://api.github.com/users/ShaneKilkelly/repos","events_url":"https://api.github.com/users/ShaneKilkelly/events{/privacy}","received_events_url":"https://api.github.com/users/ShaneKilkelly/received_events","type":"User","site_admin":false},"assignees":[{"login":"ShaneKilkelly","id":1540054,"node_id":"MDQ6VXNlcjE1NDAwNTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1540054?v=4","gravatar_id":"","url":"https://api.github.com/users/ShaneKilkelly","html_url":"https://github.com/ShaneKilkelly","followers_url":"https://api.github.com/users/ShaneKilkelly/followers","following_url":"https://api.github.com/users/ShaneKilkelly/following{/other_user}","gists_url":"https://api.github.com/users/ShaneKilkelly/gists{/gist_id}","starred_url":"https://api.github.com/users/ShaneKilkelly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ShaneKilkelly/subscriptions","organizations_url":"https://api.github.com/users/ShaneKilkelly/orgs","repos_url":"https://api.github.com/users/ShaneKilkelly/repos","events_url":"https://api.github.com/users/ShaneKilkelly/events{/privacy}","received_events_url":"https://api.github.com/users/ShaneKilkelly/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":320478112,"node_id":"MDU6TGFiZWwzMjA0NzgxMTI=","url":"https://api.github.com/repos/overleaf/writelatex-git-bridge/labels/Review","name":"Review","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/overleaf/writelatex-git-bridge/pulls/45/commits","review_comments_url":"https://api.github.com/repos/overleaf/writelatex-git-bridge/pulls/45/comments","review_comment_url":"https://api.github.com/repos/overleaf/writelatex-git-bridge/pulls/comments{/number}","comments_url":"https://api.github.com/repos/overleaf/writelatex-git-bridge/issues/45/comments","statuses_url":"https://api.github.com/repos/overleaf/writelatex-git-bridge/statuses/1b5db4edb0dcbae5d02fd3260829adc683aa4ba0","head":{"label":"overleaf:sk-migrate-repos-v1-v2","ref":"sk-migrate-repos-v1-v2","sha":"1b5db4edb0dcbae5d02fd3260829adc683aa4ba0","user":{"login":"overleaf","id":6359919,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYzNTk5MTk=","avatar_url":"https://avatars0.githubusercontent.com/u/6359919?v=4","gravatar_id":"","url":"https://api.github.com/users/overleaf","html_url":"https://github.com/overleaf","followers_url":"https://api.github.com/users/overleaf/followers","following_url":"https://api.github.com/users/overleaf/following{/other_user}","gists_url":"https://api.github.com/users/overleaf/gists{/gist_id}","starred_url":"https://api.github.com/users/overleaf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/overleaf/subscriptions","organizations_url":"https://api.github.com/users/overleaf/orgs","repos_url":"https://api.github.com/users/overleaf/repos","events_url":"https://api.github.com/users/overleaf/events{/privacy}","received_events_url":"https://api.github.com/users/overleaf/received_events","type":"Organization","site_admin":false},"repo":{"id":28834984,"node_id":"MDEwOlJlcG9zaXRvcnkyODgzNDk4NA==","name":"writelatex-git-bridge","full_name":"overleaf/writelatex-git-bridge","private":false,"owner":{"login":"overleaf","id":6359919,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYzNTk5MTk=","avatar_url":"https://avatars0.githubusercontent.com/u/6359919?v=4","gravatar_id":"","url":"https://api.github.com/users/overleaf","html_url":"https://github.com/overleaf","followers_url":"https://api.github.com/users/overleaf/followers","following_url":"https://api.github.com/users/overleaf/following{/other_user}","gists_url":"https://api.github.com/users/overleaf/gists{/gist_id}","starred_url":"https://api.github.com/users/overleaf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/overleaf/subscriptions","organizations_url":"https://api.github.com/users/overleaf/orgs","repos_url":"https://api.github.com/users/overleaf/repos","events_url":"https://api.github.com/users/overleaf/events{/privacy}","received_events_url":"https://api.github.com/users/overleaf/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/overleaf/writelatex-git-bridge","description":"Bridge between WriteLatex and Git.","fork":true,"url":"https://api.github.com/repos/overleaf/writelatex-git-bridge","forks_url":"https://api.github.com/repos/overleaf/writelatex-git-bridge/forks","keys_url":"https://api.github.com/repos/overleaf/writelatex-git-bridge/keys{/key_id}","collaborators_url":"https://api.github.com/repos/overleaf/writelatex-git-bridge/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/overleaf/writelatex-git-bridge/teams","hooks_url":"https://api.github.com/repos/overleaf/writelatex-git-bridge/hooks","issue_events_url":"https://api.github.com/repos/overleaf/writelatex-git-bridge/issues/events{/number}","events_url":"https://api.github.com/repos/overleaf/writelatex-git-bridge/events","assignees_url":"https://api.github.com/repos/overleaf/writelatex-git-bridge/assignees{/user}","branches_url":"https://api.github.com/repos/overleaf/writelatex-git-bridge/branches{/branch}","tags_url":"https://api.github.com/repos/overleaf/writelatex-git-bridge/tags","blobs_url":"https://api.github.com/repos/overleaf/writelatex-git-bridge/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/overleaf/writelatex-git-bridge/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/overleaf/writelatex-git-bridge/git/refs{/sha}","trees_url":"https://api.github.com/repos/overleaf/writelatex-git-bridge/git/trees{/sha}","statuses_url":"https://api.github.com/repos/overleaf/writelatex-git-bridge/statuses/{sha}","languages_url":"https://api.github.com/repos/overleaf/writelatex-git-bridge/languages","stargazers_url":"https://api.github.com/repos/overleaf/writelatex-git-bridge/stargazers","contributors_url":"https://api.github.com/repos/overleaf/writelatex-git-bridge/contributors","subscribers_url":"https://api.github.com/repos/overleaf/writelatex-git-bridge/subscribers","subscription_url":"https://api.github.com/repos/overleaf/writelatex-git-bridge/subscription","commits_url":"https://api.github.com/repos/overleaf/writelatex-git-bridge/commits{/sha}","git_commits_url":"https://api.github.com/repos/overleaf/writelatex-git-bridge/git/commits{/sha}","comments_url":"https://api.github.com/repos/overleaf/writelatex-git-bridge/comments{/number}","issue_comment_url":"https://api.github.com/repos/overleaf/writelatex-git-bridge/issues/comments{/number}","contents_url":"https://api.github.com/repos/overleaf/writelatex-git-bridge/contents/{+path}","compare_url":"https://api.github.com/repos/overleaf/writelatex-git-bridge/compare/{base}...{head}","merges_url":"https://api.github.com/repos/overleaf/writelatex-git-bridge/merges","archive_url":"https://api.github.com/repos/overleaf/writelatex-git-bridge/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/overleaf/writelatex-git-bridge/downloads","issues_url":"https://api.github.com/repos/overleaf/writelatex-git-bridge/issues{/number}","pulls_url":"https://api.github.com/repos/overleaf/writelatex-git-bridge/pulls{/number}","milestones_url":"https://api.github.com/repos/overleaf/writelatex-git-bridge/milestones{/number}","notifications_url":"https://api.github.com/repos/overleaf/writelatex-git-bridge/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/overleaf/writelatex-git-bridge/labels{/name}","releases_url":"https://api.github.com/repos/overleaf/writelatex-git-bridge/releases{/id}","deployments_url":"https://api.github.com/repos/overleaf/writelatex-git-bridge/deployments","created_at":"2015-01-05T22:29:08Z","updated_at":"2018-11-15T09:53:05Z","pushed_at":"2018-12-05T16:55:28Z","git_url":"git://github.com/overleaf/writelatex-git-bridge.git","ssh_url":"[email protected]:overleaf/writelatex-git-bridge.git","clone_url":"https://github.com/overleaf/writelatex-git-bridge.git","svn_url":"https://github.com/overleaf/writelatex-git-bridge","homepage":"","size":23309,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":1,"watchers":2,"default_branch":"master"}},"base":{"label":"overleaf:master","ref":"master","sha":"1bc9d83131b13a5fcb0ad927aab13993d98b80e4","user":{"login":"overleaf","id":6359919,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYzNTk5MTk=","avatar_url":"https://avatars0.githubusercontent.com/u/6359919?v=4","gravatar_id":"","url":"https://api.github.com/users/overleaf","html_url":"https://github.com/overleaf","followers_url":"https://api.github.com/users/overleaf/followers","following_url":"https://api.github.com/users/overleaf/following{/other_user}","gists_url":"https://api.github.com/users/overleaf/gists{/gist_id}","starred_url":"https://api.github.com/users/overleaf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/overleaf/subscriptions","organizations_url":"https://api.github.com/users/overleaf/orgs","repos_url":"https://api.github.com/users/overleaf/repos","events_url":"https://api.github.com/users/overleaf/events{/privacy}","received_events_url":"https://api.github.com/users/overleaf/received_events","type":"Organization","site_admin":false},"repo":{"id":28834984,"node_id":"MDEwOlJlcG9zaXRvcnkyODgzNDk4NA==","name":"writelatex-git-bridge","full_name":"overleaf/writelatex-git-bridge","private":false,"owner":{"login":"overleaf","id":6359919,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYzNTk5MTk=","avatar_url":"https://avatars0.githubusercontent.com/u/6359919?v=4","gravatar_id":"","url":"https://api.github.com/users/overleaf","html_url":"https://github.com/overleaf","followers_url":"https://api.github.com/users/overleaf/followers","following_url":"https://api.github.com/users/overleaf/following{/other_user}","gists_url":"https://api.github.com/users/overleaf/gists{/gist_id}","starred_url":"https://api.github.com/users/overleaf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/overleaf/subscriptions","organizations_url":"https://api.github.com/users/overleaf/orgs","repos_url":"https://api.github.com/users/overleaf/repos","events_url":"https://api.github.com/users/overleaf/events{/privacy}","received_events_url":"https://api.github.com/users/overleaf/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/overleaf/writelatex-git-bridge","description":"Bridge between WriteLatex and Git.","fork":true,"url":"https://api.github.com/repos/overleaf/writelatex-git-bridge","forks_url":"https://api.github.com/repos/overleaf/writelatex-git-bridge/forks","keys_url":"https://api.github.com/repos/overleaf/writelatex-git-bridge/keys{/key_id}","collaborators_url":"https://api.github.com/repos/overleaf/writelatex-git-bridge/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/overleaf/writelatex-git-bridge/teams","hooks_url":"https://api.github.com/repos/overleaf/writelatex-git-bridge/hooks","issue_events_url":"https://api.github.com/repos/overleaf/writelatex-git-bridge/issues/events{/number}","events_url":"https://api.github.com/repos/overleaf/writelatex-git-bridge/events","assignees_url":"https://api.github.com/repos/overleaf/writelatex-git-bridge/assignees{/user}","branches_url":"https://api.github.com/repos/overleaf/writelatex-git-bridge/branches{/branch}","tags_url":"https://api.github.com/repos/overleaf/writelatex-git-bridge/tags","blobs_url":"https://api.github.com/repos/overleaf/writelatex-git-bridge/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/overleaf/writelatex-git-bridge/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/overleaf/writelatex-git-bridge/git/refs{/sha}","trees_url":"https://api.github.com/repos/overleaf/writelatex-git-bridge/git/trees{/sha}","statuses_url":"https://api.github.com/repos/overleaf/writelatex-git-bridge/statuses/{sha}","languages_url":"https://api.github.com/repos/overleaf/writelatex-git-bridge/languages","stargazers_url":"https://api.github.com/repos/overleaf/writelatex-git-bridge/stargazers","contributors_url":"https://api.github.com/repos/overleaf/writelatex-git-bridge/contributors","subscribers_url":"https://api.github.com/repos/overleaf/writelatex-git-bridge/subscribers","subscription_url":"https://api.github.com/repos/overleaf/writelatex-git-bridge/subscription","commits_url":"https://api.github.com/repos/overleaf/writelatex-git-bridge/commits{/sha}","git_commits_url":"https://api.github.com/repos/overleaf/writelatex-git-bridge/git/commits{/sha}","comments_url":"https://api.github.com/repos/overleaf/writelatex-git-bridge/comments{/number}","issue_comment_url":"https://api.github.com/repos/overleaf/writelatex-git-bridge/issues/comments{/number}","contents_url":"https://api.github.com/repos/overleaf/writelatex-git-bridge/contents/{+path}","compare_url":"https://api.github.com/repos/overleaf/writelatex-git-bridge/compare/{base}...{head}","merges_url":"https://api.github.com/repos/overleaf/writelatex-git-bridge/merges","archive_url":"https://api.github.com/repos/overleaf/writelatex-git-bridge/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/overleaf/writelatex-git-bridge/downloads","issues_url":"https://api.github.com/repos/overleaf/writelatex-git-bridge/issues{/number}","pulls_url":"https://api.github.com/repos/overleaf/writelatex-git-bridge/pulls{/number}","milestones_url":"https://api.github.com/repos/overleaf/writelatex-git-bridge/milestones{/number}","notifications_url":"https://api.github.com/repos/overleaf/writelatex-git-bridge/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/overleaf/writelatex-git-bridge/labels{/name}","releases_url":"https://api.github.com/repos/overleaf/writelatex-git-bridge/releases{/id}","deployments_url":"https://api.github.com/repos/overleaf/writelatex-git-bridge/deployments","created_at":"2015-01-05T22:29:08Z","updated_at":"2018-11-15T09:53:05Z","pushed_at":"2018-12-05T16:55:28Z","git_url":"git://github.com/overleaf/writelatex-git-bridge.git","ssh_url":"[email protected]:overleaf/writelatex-git-bridge.git","clone_url":"https://github.com/overleaf/writelatex-git-bridge.git","svn_url":"https://github.com/overleaf/writelatex-git-bridge","homepage":"","size":23309,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":1,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/overleaf/writelatex-git-bridge/pulls/45"},"html":{"href":"https://github.com/overleaf/writelatex-git-bridge/pull/45"},"issue":{"href":"https://api.github.com/repos/overleaf/writelatex-git-bridge/issues/45"},"comments":{"href":"https://api.github.com/repos/overleaf/writelatex-git-bridge/issues/45/comments"},"review_comments":{"href":"https://api.github.com/repos/overleaf/writelatex-git-bridge/pulls/45/comments"},"review_comment":{"href":"https://api.github.com/repos/overleaf/writelatex-git-bridge/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/overleaf/writelatex-git-bridge/pulls/45/commits"},"statuses":{"href":"https://api.github.com/repos/overleaf/writelatex-git-bridge/statuses/1b5db4edb0dcbae5d02fd3260829adc683aa4ba0"}},"author_association":"NONE"}} | {
"id": 28834984,
"name": "overleaf/writelatex-git-bridge",
"url": "https://api.github.com/repos/overleaf/writelatex-git-bridge"
} | {
"id": 1540054,
"login": "ShaneKilkelly",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1540054?",
"url": "https://api.github.com/users/ShaneKilkelly"
} | {
"id": 6359919,
"login": "overleaf",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6359919?",
"url": "https://api.github.com/orgs/overleaf"
} | 2018-12-06T09:30:57 | 8707946835 | {"actor":{"display_login":"ShaneKilkelly"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/Clinical-Genomics/scout/pulls/comments/226962691","pull_request_review_id":166889789,"id":226962691,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNjk2MjY5MQ==","diff_hunk":"@@ -833,120 +833,154 @@ def callers(variant_obj, category='snv'):\n return calls\n \n \n-def sanger(store, mail, institute_obj, case_obj, user_obj, variant_obj, sender, \n- url_builder=url_for):\n- \"\"\"Send Sanger email.\"\"\"\n- variant_link = url_builder('variants.variant', institute_id=institute_obj['_id'],\n- case_name=case_obj['display_name'],\n- variant_id=variant_obj['_id'])\n- if 'suspects' in case_obj and variant_obj['_id'] not in case_obj['suspects']:\n- store.pin_variant(institute_obj, case_obj, user_obj, variant_link, variant_obj)\n+def variant_verification(store, mail, institute_obj, case_obj, user_obj, variant_obj, sender, variant_url, order, url_builder=url_for):\n+ \"\"\"Sand a verification email and register the verification in the database\n+\n+ Args:\n+ store(scout.adapter.MongoAdapter)\n+ mail(scout.server.extensions.mail): an instance of flask_mail.Mail\n+ institute_obj(dict): an institute object\n+ case_obj(dict): a case object\n+ user_obj(dict): a user object\n+ variant_obj(dict): a variant object (snv or sv)\n+ sender(str): current_app.config['MAIL_USERNAME']\n+ variant_url(str): the complete url to the variant (snv or sv), a link that works from outside scout domain.\n+ order(str): False == cancel order, True==order verification\n+ url_builder(flask.url_for): for testing purposes, otherwise test verification email fails because out of context\n+ \"\"\"\n \n recipients = institute_obj['sanger_recipients']\n if len(recipients) == 0:\n raise MissingSangerRecipientError()\n \n+ view_type = None\n+ email_subject = None\n+ category = variant_obj.get('category')\n+ display_name = None\n+ breakpoint_1 = str(variant_obj.get('chromosome'))+':'+str(variant_obj.get('position'))\n+ breakpoint_2 = None\n+ if variant_obj.get('end_chrom'):\n+ breakpoint_2 = str(variant_obj.get('end_chrom'))+':'+str(variant_obj.get('end'))\n+ else:\n+ breakpoint_2 = str(variant_obj.get('chromosome'))+':'+str(variant_obj.get('end'))\n+\n+ variant_size = variant_obj.get('length')\n+ panels = ', '.join(variant_obj['panels'])\n hgnc_symbol = ', '.join(variant_obj['hgnc_symbols'])\n gtcalls = [\"<li>{}: {}</li>\".format(sample_obj['display_name'],\n sample_obj['genotype_call'])\n for sample_obj in variant_obj['samples']]\n- tx_changes = []\n- for gene_obj in variant_obj.get('genes', []):\n- for transcript_obj in gene_obj['transcripts']:\n- parse_transcript(gene_obj, transcript_obj)\n- if transcript_obj.get('change_str'):\n- tx_changes.append(\"<li>{}</li>\".format(transcript_obj['change_str']))\n-\n- html = \"\"\"\n- <ul\">\n- <li>\n- <strong>Case {case_name}</strong>: <a href=\"{url}\">{variant_id}</a>\n- </li>\n- <li><strong>HGNC symbols</strong>: {hgnc_symbol}</li>\n- <li><strong>Gene panels</strong>: {panels}</li>\n- <li><strong>GT call</strong></li>\n- {gtcalls}\n- <li><strong>Amino acid changes</strong></li>\n- {tx_changes}\n- <li><strong>Ordered by</strong>: {name}</li>\n- </ul>\n- \"\"\".format(case_name=case_obj['display_name'],\n- url=variant_link,\n- variant_id=variant_obj['display_name'],\n- hgnc_symbol=hgnc_symbol,\n- panels=', '.format(variant_obj['panels']),\n- gtcalls=''.join(gtcalls),\n- tx_changes=''.join(tx_changes),\n- name=user_obj['name'].encode('utf-8'))\n-\n- kwargs = dict(subject=\"SCOUT: Sanger sequencing of {}\".format(hgnc_symbol),\n- html=html, sender=sender, recipients=recipients,\n- # cc the sender of the email for confirmation\n- cc=[user_obj['email']])\n-\n- # compose and send the email message\n- message = Message(**kwargs)\n- mail.send(message)\n-\n- store.order_sanger(institute_obj, case_obj, user_obj, variant_link, variant_obj)\n-\n+ tx_changes = 'Not available'\n+\n+ if category == 'snv': #SNV\n+ view_type = 'variants.variant'\n+ display_name = variant_obj.get('display_name')\n+ tx_changes = []\n+ for gene_obj in variant_obj.get('genes', []):\n+ for transcript_obj in gene_obj['transcripts']:\n+ parse_transcript(gene_obj, transcript_obj)\n+ if transcript_obj.get('change_str'):\n+ tx_changes.append(\"<li>{}</li>\".format(transcript_obj['change_str']))\n+ tx_changes=''.join(tx_changes)\n+\n+ else: #SV\n+ view_type = 'variants.sv_variant'\n+ display_name = breakpoint_1+'_'+variant_obj.get('sub_category').upper()\n+\n+ # body of the email\n+ html = verification_email_body(\n+ case_obj['display_name'],\n+ variant_url, #this is the complete url to the variant, accessible when clicking on the email link\n+ display_name,\n+ category.upper(),\n+ variant_obj.get('sub_category').upper(),\n+ breakpoint_1,\n+ breakpoint_2,\n+ hgnc_symbol,\n+ panels,\n+ ''.join(gtcalls),\n+ tx_changes,\n+ user_obj['name'].encode('utf-8')\n+ )\n \n-def cancel_sanger(store, mail, institute_obj, case_obj, user_obj, variant_obj, sender,\n- url_builder=url_for):\n- \"\"\"Send Sanger cancellation email.\"\"\"\n- variant_link = url_builder('variants.variant', institute_id=institute_obj['_id'],\n+ # build a local the link to the variant to be included in the events objects (variant and case) created in the event collection.\n+ local_link = url_builder(view_type, institute_id=institute_obj['_id'],\n case_name=case_obj['display_name'],\n variant_id=variant_obj['_id'])\n- # if 'suspects' in case_obj and variant_obj['_id'] not in case_obj['suspects']:\n- # store.pin_variant(institute_obj, case_obj, user_obj, variant_link, variant_obj)\n+ if order == 'True': # variant verification should be ordered\n+ # pin variant if it's not already pinned\n+ if case_obj.get('suspects') is None or variant_obj['_id'] not in case_obj['suspects']:\n+ store.pin_variant(institute_obj, case_obj, user_obj, local_link, variant_obj)\n \n- recipients = institute_obj['sanger_recipients']\n- if len(recipients) == 0:\n- raise MissingSangerRecipientError()\n+ email_subject = \"SCOUT: validation of {} variant {}\".format(category.upper(), display_name)\n+ store.order_verification(institute=institute_obj, case=case_obj, user=user_obj, link=local_link, variant=variant_obj)\n \n- hgnc_symbol = ', '.join(variant_obj['hgnc_symbols'])\n- gtcalls = [\"<li>{}: {}</li>\".format(sample_obj['display_name'],\n- sample_obj['genotype_call'])\n- for sample_obj in variant_obj['samples']]\n- tx_changes = []\n- for gene_obj in variant_obj.get('genes', []):\n- for transcript_obj in gene_obj['transcripts']:\n- parse_transcript(gene_obj, transcript_obj)\n- if transcript_obj.get('change_str'):\n- tx_changes.append(\"<li>{}</li>\".format(transcript_obj['change_str']))\n+ else: # variant verification should be cancelled\n+ email_subject = \"SCOUT: validation of {} variant {} was CANCELLED!\".format(category.upper(), display_name)\n+ store.cancel_verification(institute=institute_obj, case=case_obj, user=user_obj, link=local_link, variant=variant_obj)\n+\n+ kwargs = dict(subject=email_subject, html=html, sender=sender, recipients=recipients,\n+ # cc the sender of the email for confirmation\n+ cc=[user_obj['email']])\n \n- html = \"\"\"\n- <ul\">\n- <li>\n- <strong>Case {case_name}</strong>: <a href=\"{url}\">{variant_id}</a>\n- </li>\n- <li><strong>HGNC symbols</strong>: {hgnc_symbol}</li>\n- <li><strong>Gene panels</strong>: {panels}</li>\n- <li><strong>GT call</strong></li>\n- {gtcalls}\n- <li><strong>Amino acid changes</strong></li>\n- {tx_changes}\n- <li><strong>Order cancelled by</strong>: {name}</li>\n- </ul>\n- \"\"\".format(case_name=case_obj['display_name'],\n- url=variant_link,\n- variant_id=variant_obj['display_name'],\n- hgnc_symbol=hgnc_symbol,\n- panels=', '.format(variant_obj['panels']),\n- gtcalls=''.join(gtcalls),\n- tx_changes=''.join(tx_changes),\n- name=user_obj['name'].encode('utf-8'))\n-\n- kwargs = dict(subject=\"SCOUT: Sanger sequencing of {} CANCELLED!\".format(hgnc_symbol),\n- html=html, sender=sender, recipients=recipients,\n- # cc the sender of the email for confirmation\n- cc=[user_obj['email']])\n-\n- # compose and send the email message\n message = Message(**kwargs)\n+ # send email using flask_mail\n mail.send(message)\n \n- store.cancel_sanger(institute_obj, case_obj, user_obj, variant_link, variant_obj)\n+\n+def verification_email_body(case_name, url, display_name, category, subcategory, breakpoint_1, breakpoint_2, hgnc_symbol, panels, gtcalls, tx_changes, name):","path":"scout/server/blueprints/variants/controllers.py","position":282,"original_position":282,"commit_id":"f9cb9b251b171a9a0b2939fceae071ef6f8eb3c6","original_commit_id":"f9cb9b251b171a9a0b2939fceae071ef6f8eb3c6","user":{"login":"moonso","id":405278,"node_id":"MDQ6VXNlcjQwNTI3OA==","avatar_url":"https://avatars1.githubusercontent.com/u/405278?v=4","gravatar_id":"","url":"https://api.github.com/users/moonso","html_url":"https://github.com/moonso","followers_url":"https://api.github.com/users/moonso/followers","following_url":"https://api.github.com/users/moonso/following{/other_user}","gists_url":"https://api.github.com/users/moonso/gists{/gist_id}","starred_url":"https://api.github.com/users/moonso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moonso/subscriptions","organizations_url":"https://api.github.com/users/moonso/orgs","repos_url":"https://api.github.com/users/moonso/repos","events_url":"https://api.github.com/users/moonso/events{/privacy}","received_events_url":"https://api.github.com/users/moonso/received_events","type":"User","site_admin":false},"body":"👍 for putting this in own function","created_at":"2018-10-22T11:40:50Z","updated_at":"2018-10-22T11:41:51Z","html_url":"https://github.com/Clinical-Genomics/scout/pull/1020#discussion_r226962691","pull_request_url":"https://api.github.com/repos/Clinical-Genomics/scout/pulls/1020","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Clinical-Genomics/scout/pulls/comments/226962691"},"html":{"href":"https://github.com/Clinical-Genomics/scout/pull/1020#discussion_r226962691"},"pull_request":{"href":"https://api.github.com/repos/Clinical-Genomics/scout/pulls/1020"}}},"pull_request":{"url":"https://api.github.com/repos/Clinical-Genomics/scout/pulls/1020","id":223619877,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIzNjE5ODc3","html_url":"https://github.com/Clinical-Genomics/scout/pull/1020","diff_url":"https://github.com/Clinical-Genomics/scout/pull/1020.diff","patch_url":"https://github.com/Clinical-Genomics/scout/pull/1020.patch","issue_url":"https://api.github.com/repos/Clinical-Genomics/scout/issues/1020","number":1020,"state":"open","locked":false,"title":"Generalise validation to include SVs","user":{"login":"northwestwitch","id":28093618,"node_id":"MDQ6VXNlcjI4MDkzNjE4","avatar_url":"https://avatars0.githubusercontent.com/u/28093618?v=4","gravatar_id":"","url":"https://api.github.com/users/northwestwitch","html_url":"https://github.com/northwestwitch","followers_url":"https://api.github.com/users/northwestwitch/followers","following_url":"https://api.github.com/users/northwestwitch/following{/other_user}","gists_url":"https://api.github.com/users/northwestwitch/gists{/gist_id}","starred_url":"https://api.github.com/users/northwestwitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/northwestwitch/subscriptions","organizations_url":"https://api.github.com/users/northwestwitch/orgs","repos_url":"https://api.github.com/users/northwestwitch/repos","events_url":"https://api.github.com/users/northwestwitch/events{/privacy}","received_events_url":"https://api.github.com/users/northwestwitch/received_events","type":"User","site_admin":false},"body":"- Structural variants can now be verified\r\n- Generalized the email sent for validations\r\n- Fixed the link to the variants in the sent email so it actually works from outside scout.\r\n- template for SNVs is unchanged while for SVs sanger is named \"verify\"\r\n- Removed redundant code in variant controllers so that order and cancel a validation is done by the same function\r\n- Keeping for now the \"sanger_ordered\" key in variant objects (even for SVs), because changing it would require a restructuring of the database and the depending functions. \r\n- Updated tests to reflect the changes in the rest of the code","created_at":"2018-10-17T14:10:25Z","updated_at":"2018-10-22T11:41:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"84c99f559048b4744d7e31d16a63a7ab27c385c5","assignee":null,"assignees":[],"requested_reviewers":[{"login":"dnil","id":758570,"node_id":"MDQ6VXNlcjc1ODU3MA==","avatar_url":"https://avatars3.githubusercontent.com/u/758570?v=4","gravatar_id":"","url":"https://api.github.com/users/dnil","html_url":"https://github.com/dnil","followers_url":"https://api.github.com/users/dnil/followers","following_url":"https://api.github.com/users/dnil/following{/other_user}","gists_url":"https://api.github.com/users/dnil/gists{/gist_id}","starred_url":"https://api.github.com/users/dnil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dnil/subscriptions","organizations_url":"https://api.github.com/users/dnil/orgs","repos_url":"https://api.github.com/users/dnil/repos","events_url":"https://api.github.com/users/dnil/events{/privacy}","received_events_url":"https://api.github.com/users/dnil/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Clinical-Genomics/scout/pulls/1020/commits","review_comments_url":"https://api.github.com/repos/Clinical-Genomics/scout/pulls/1020/comments","review_comment_url":"https://api.github.com/repos/Clinical-Genomics/scout/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Clinical-Genomics/scout/issues/1020/comments","statuses_url":"https://api.github.com/repos/Clinical-Genomics/scout/statuses/f9cb9b251b171a9a0b2939fceae071ef6f8eb3c6","head":{"label":"Clinical-Genomics:generalise_sanger","ref":"generalise_sanger","sha":"f9cb9b251b171a9a0b2939fceae071ef6f8eb3c6","user":{"login":"Clinical-Genomics","id":6412433,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY0MTI0MzM=","avatar_url":"https://avatars1.githubusercontent.com/u/6412433?v=4","gravatar_id":"","url":"https://api.github.com/users/Clinical-Genomics","html_url":"https://github.com/Clinical-Genomics","followers_url":"https://api.github.com/users/Clinical-Genomics/followers","following_url":"https://api.github.com/users/Clinical-Genomics/following{/other_user}","gists_url":"https://api.github.com/users/Clinical-Genomics/gists{/gist_id}","starred_url":"https://api.github.com/users/Clinical-Genomics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Clinical-Genomics/subscriptions","organizations_url":"https://api.github.com/users/Clinical-Genomics/orgs","repos_url":"https://api.github.com/users/Clinical-Genomics/repos","events_url":"https://api.github.com/users/Clinical-Genomics/events{/privacy}","received_events_url":"https://api.github.com/users/Clinical-Genomics/received_events","type":"Organization","site_admin":false},"repo":{"id":25027539,"node_id":"MDEwOlJlcG9zaXRvcnkyNTAyNzUzOQ==","name":"scout","full_name":"Clinical-Genomics/scout","private":false,"owner":{"login":"Clinical-Genomics","id":6412433,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY0MTI0MzM=","avatar_url":"https://avatars1.githubusercontent.com/u/6412433?v=4","gravatar_id":"","url":"https://api.github.com/users/Clinical-Genomics","html_url":"https://github.com/Clinical-Genomics","followers_url":"https://api.github.com/users/Clinical-Genomics/followers","following_url":"https://api.github.com/users/Clinical-Genomics/following{/other_user}","gists_url":"https://api.github.com/users/Clinical-Genomics/gists{/gist_id}","starred_url":"https://api.github.com/users/Clinical-Genomics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Clinical-Genomics/subscriptions","organizations_url":"https://api.github.com/users/Clinical-Genomics/orgs","repos_url":"https://api.github.com/users/Clinical-Genomics/repos","events_url":"https://api.github.com/users/Clinical-Genomics/events{/privacy}","received_events_url":"https://api.github.com/users/Clinical-Genomics/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Clinical-Genomics/scout","description":"VCF visualization interface","fork":false,"url":"https://api.github.com/repos/Clinical-Genomics/scout","forks_url":"https://api.github.com/repos/Clinical-Genomics/scout/forks","keys_url":"https://api.github.com/repos/Clinical-Genomics/scout/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Clinical-Genomics/scout/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Clinical-Genomics/scout/teams","hooks_url":"https://api.github.com/repos/Clinical-Genomics/scout/hooks","issue_events_url":"https://api.github.com/repos/Clinical-Genomics/scout/issues/events{/number}","events_url":"https://api.github.com/repos/Clinical-Genomics/scout/events","assignees_url":"https://api.github.com/repos/Clinical-Genomics/scout/assignees{/user}","branches_url":"https://api.github.com/repos/Clinical-Genomics/scout/branches{/branch}","tags_url":"https://api.github.com/repos/Clinical-Genomics/scout/tags","blobs_url":"https://api.github.com/repos/Clinical-Genomics/scout/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Clinical-Genomics/scout/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Clinical-Genomics/scout/git/refs{/sha}","trees_url":"https://api.github.com/repos/Clinical-Genomics/scout/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Clinical-Genomics/scout/statuses/{sha}","languages_url":"https://api.github.com/repos/Clinical-Genomics/scout/languages","stargazers_url":"https://api.github.com/repos/Clinical-Genomics/scout/stargazers","contributors_url":"https://api.github.com/repos/Clinical-Genomics/scout/contributors","subscribers_url":"https://api.github.com/repos/Clinical-Genomics/scout/subscribers","subscription_url":"https://api.github.com/repos/Clinical-Genomics/scout/subscription","commits_url":"https://api.github.com/repos/Clinical-Genomics/scout/commits{/sha}","git_commits_url":"https://api.github.com/repos/Clinical-Genomics/scout/git/commits{/sha}","comments_url":"https://api.github.com/repos/Clinical-Genomics/scout/comments{/number}","issue_comment_url":"https://api.github.com/repos/Clinical-Genomics/scout/issues/comments{/number}","contents_url":"https://api.github.com/repos/Clinical-Genomics/scout/contents/{+path}","compare_url":"https://api.github.com/repos/Clinical-Genomics/scout/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Clinical-Genomics/scout/merges","archive_url":"https://api.github.com/repos/Clinical-Genomics/scout/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Clinical-Genomics/scout/downloads","issues_url":"https://api.github.com/repos/Clinical-Genomics/scout/issues{/number}","pulls_url":"https://api.github.com/repos/Clinical-Genomics/scout/pulls{/number}","milestones_url":"https://api.github.com/repos/Clinical-Genomics/scout/milestones{/number}","notifications_url":"https://api.github.com/repos/Clinical-Genomics/scout/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Clinical-Genomics/scout/labels{/name}","releases_url":"https://api.github.com/repos/Clinical-Genomics/scout/releases{/id}","deployments_url":"https://api.github.com/repos/Clinical-Genomics/scout/deployments","created_at":"2014-10-10T08:44:01Z","updated_at":"2018-10-20T07:54:18Z","pushed_at":"2018-10-22T09:24:46Z","git_url":"git://github.com/Clinical-Genomics/scout.git","ssh_url":"[email protected]:Clinical-Genomics/scout.git","clone_url":"https://github.com/Clinical-Genomics/scout.git","svn_url":"https://github.com/Clinical-Genomics/scout","homepage":"http://www.clinicalgenomics.se/scout/","size":49437,"stargazers_count":57,"watchers_count":57,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":17,"mirror_url":null,"archived":false,"open_issues_count":61,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":17,"open_issues":61,"watchers":57,"default_branch":"master"}},"base":{"label":"Clinical-Genomics:master","ref":"master","sha":"fba5c14a45bfa0d677de7cc527a0304adb51e96b","user":{"login":"Clinical-Genomics","id":6412433,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY0MTI0MzM=","avatar_url":"https://avatars1.githubusercontent.com/u/6412433?v=4","gravatar_id":"","url":"https://api.github.com/users/Clinical-Genomics","html_url":"https://github.com/Clinical-Genomics","followers_url":"https://api.github.com/users/Clinical-Genomics/followers","following_url":"https://api.github.com/users/Clinical-Genomics/following{/other_user}","gists_url":"https://api.github.com/users/Clinical-Genomics/gists{/gist_id}","starred_url":"https://api.github.com/users/Clinical-Genomics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Clinical-Genomics/subscriptions","organizations_url":"https://api.github.com/users/Clinical-Genomics/orgs","repos_url":"https://api.github.com/users/Clinical-Genomics/repos","events_url":"https://api.github.com/users/Clinical-Genomics/events{/privacy}","received_events_url":"https://api.github.com/users/Clinical-Genomics/received_events","type":"Organization","site_admin":false},"repo":{"id":25027539,"node_id":"MDEwOlJlcG9zaXRvcnkyNTAyNzUzOQ==","name":"scout","full_name":"Clinical-Genomics/scout","private":false,"owner":{"login":"Clinical-Genomics","id":6412433,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY0MTI0MzM=","avatar_url":"https://avatars1.githubusercontent.com/u/6412433?v=4","gravatar_id":"","url":"https://api.github.com/users/Clinical-Genomics","html_url":"https://github.com/Clinical-Genomics","followers_url":"https://api.github.com/users/Clinical-Genomics/followers","following_url":"https://api.github.com/users/Clinical-Genomics/following{/other_user}","gists_url":"https://api.github.com/users/Clinical-Genomics/gists{/gist_id}","starred_url":"https://api.github.com/users/Clinical-Genomics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Clinical-Genomics/subscriptions","organizations_url":"https://api.github.com/users/Clinical-Genomics/orgs","repos_url":"https://api.github.com/users/Clinical-Genomics/repos","events_url":"https://api.github.com/users/Clinical-Genomics/events{/privacy}","received_events_url":"https://api.github.com/users/Clinical-Genomics/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Clinical-Genomics/scout","description":"VCF visualization interface","fork":false,"url":"https://api.github.com/repos/Clinical-Genomics/scout","forks_url":"https://api.github.com/repos/Clinical-Genomics/scout/forks","keys_url":"https://api.github.com/repos/Clinical-Genomics/scout/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Clinical-Genomics/scout/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Clinical-Genomics/scout/teams","hooks_url":"https://api.github.com/repos/Clinical-Genomics/scout/hooks","issue_events_url":"https://api.github.com/repos/Clinical-Genomics/scout/issues/events{/number}","events_url":"https://api.github.com/repos/Clinical-Genomics/scout/events","assignees_url":"https://api.github.com/repos/Clinical-Genomics/scout/assignees{/user}","branches_url":"https://api.github.com/repos/Clinical-Genomics/scout/branches{/branch}","tags_url":"https://api.github.com/repos/Clinical-Genomics/scout/tags","blobs_url":"https://api.github.com/repos/Clinical-Genomics/scout/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Clinical-Genomics/scout/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Clinical-Genomics/scout/git/refs{/sha}","trees_url":"https://api.github.com/repos/Clinical-Genomics/scout/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Clinical-Genomics/scout/statuses/{sha}","languages_url":"https://api.github.com/repos/Clinical-Genomics/scout/languages","stargazers_url":"https://api.github.com/repos/Clinical-Genomics/scout/stargazers","contributors_url":"https://api.github.com/repos/Clinical-Genomics/scout/contributors","subscribers_url":"https://api.github.com/repos/Clinical-Genomics/scout/subscribers","subscription_url":"https://api.github.com/repos/Clinical-Genomics/scout/subscription","commits_url":"https://api.github.com/repos/Clinical-Genomics/scout/commits{/sha}","git_commits_url":"https://api.github.com/repos/Clinical-Genomics/scout/git/commits{/sha}","comments_url":"https://api.github.com/repos/Clinical-Genomics/scout/comments{/number}","issue_comment_url":"https://api.github.com/repos/Clinical-Genomics/scout/issues/comments{/number}","contents_url":"https://api.github.com/repos/Clinical-Genomics/scout/contents/{+path}","compare_url":"https://api.github.com/repos/Clinical-Genomics/scout/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Clinical-Genomics/scout/merges","archive_url":"https://api.github.com/repos/Clinical-Genomics/scout/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Clinical-Genomics/scout/downloads","issues_url":"https://api.github.com/repos/Clinical-Genomics/scout/issues{/number}","pulls_url":"https://api.github.com/repos/Clinical-Genomics/scout/pulls{/number}","milestones_url":"https://api.github.com/repos/Clinical-Genomics/scout/milestones{/number}","notifications_url":"https://api.github.com/repos/Clinical-Genomics/scout/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Clinical-Genomics/scout/labels{/name}","releases_url":"https://api.github.com/repos/Clinical-Genomics/scout/releases{/id}","deployments_url":"https://api.github.com/repos/Clinical-Genomics/scout/deployments","created_at":"2014-10-10T08:44:01Z","updated_at":"2018-10-20T07:54:18Z","pushed_at":"2018-10-22T09:24:46Z","git_url":"git://github.com/Clinical-Genomics/scout.git","ssh_url":"[email protected]:Clinical-Genomics/scout.git","clone_url":"https://github.com/Clinical-Genomics/scout.git","svn_url":"https://github.com/Clinical-Genomics/scout","homepage":"http://www.clinicalgenomics.se/scout/","size":49437,"stargazers_count":57,"watchers_count":57,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":17,"mirror_url":null,"archived":false,"open_issues_count":61,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":17,"open_issues":61,"watchers":57,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Clinical-Genomics/scout/pulls/1020"},"html":{"href":"https://github.com/Clinical-Genomics/scout/pull/1020"},"issue":{"href":"https://api.github.com/repos/Clinical-Genomics/scout/issues/1020"},"comments":{"href":"https://api.github.com/repos/Clinical-Genomics/scout/issues/1020/comments"},"review_comments":{"href":"https://api.github.com/repos/Clinical-Genomics/scout/pulls/1020/comments"},"review_comment":{"href":"https://api.github.com/repos/Clinical-Genomics/scout/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Clinical-Genomics/scout/pulls/1020/commits"},"statuses":{"href":"https://api.github.com/repos/Clinical-Genomics/scout/statuses/f9cb9b251b171a9a0b2939fceae071ef6f8eb3c6"}},"author_association":"MEMBER"}} | {
"id": 25027539,
"name": "Clinical-Genomics/scout",
"url": "https://api.github.com/repos/Clinical-Genomics/scout"
} | {
"id": 405278,
"login": "moonso",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/405278?",
"url": "https://api.github.com/users/moonso"
} | {
"id": 6412433,
"login": "Clinical-Genomics",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6412433?",
"url": "https://api.github.com/orgs/Clinical-Genomics"
} | 2018-10-22T11:40:50 | 8458052155 | {"actor":{"display_login":"moonso"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/vehikl/trivia/pulls/comments/182103496","pull_request_review_id":112848668,"id":182103496,"diff_hunk":"@@ -13,22 +13,10 @@ describe(\"The test environment\", function() {\n });\n \n describe(\"The game\", function() {\n- let log = [];\n-\n- beforeAll(function () {\n- console.log = function (message) {\n- log.push(message);\n- }\n- })\n-\n- afterEach(function () {\n- log = [];\n- })\n-\n using(\"seeds 1 to 1000\", new Array(1000).fill('').map((_, index) => [index + 1]), function (seed) {\n it(`should produce the expected output when seeded with ${seed}`, function () {\n- runner.play(seed);\n- expect(log.join(\"\\n\")).toEqual(fs.readFileSync(`./spec/fixtures/output-seeded-with-${seed}.txt`).toString());\n+ const game = runner.play(seed);\n+ expect(game.logs.join(\"\\n\")).toEqual(fs.readFileSync(`./spec/fixtures/output-seeded-with-${seed}.txt`).toString());","path":"javascript/spec/game.spec.js","position":21,"original_position":21,"commit_id":"0a6119b210bfafe8e6d8dd647830bffc12c902b9","original_commit_id":"0a6119b210bfafe8e6d8dd647830bffc12c902b9","user":{"login":"mrozbarry","id":566486,"avatar_url":"https://avatars0.githubusercontent.com/u/566486?v=4","gravatar_id":"","url":"https://api.github.com/users/mrozbarry","html_url":"https://github.com/mrozbarry","followers_url":"https://api.github.com/users/mrozbarry/followers","following_url":"https://api.github.com/users/mrozbarry/following{/other_user}","gists_url":"https://api.github.com/users/mrozbarry/gists{/gist_id}","starred_url":"https://api.github.com/users/mrozbarry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrozbarry/subscriptions","organizations_url":"https://api.github.com/users/mrozbarry/orgs","repos_url":"https://api.github.com/users/mrozbarry/repos","events_url":"https://api.github.com/users/mrozbarry/events{/privacy}","received_events_url":"https://api.github.com/users/mrozbarry/received_events","type":"User","site_admin":false},"body":"I really hated monkey-patching `console.log`, since that could potentially have unwanted consequences in the future (ie async nature of console.log), so I changed how the game from using console.log to this.log, which keeps track of it's own logs, as well as using `console.log`. Seemed cleaner to me, but it did required changing the tests slightly.","created_at":"2018-04-17T14:56:24Z","updated_at":"2018-04-17T14:56:24Z","html_url":"https://github.com/vehikl/trivia/pull/3#discussion_r182103496","pull_request_url":"https://api.github.com/repos/vehikl/trivia/pulls/3","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/vehikl/trivia/pulls/comments/182103496"},"html":{"href":"https://github.com/vehikl/trivia/pull/3#discussion_r182103496"},"pull_request":{"href":"https://api.github.com/repos/vehikl/trivia/pulls/3"}}},"pull_request":{"url":"https://api.github.com/repos/vehikl/trivia/pulls/3","id":182170993,"html_url":"https://github.com/vehikl/trivia/pull/3","diff_url":"https://github.com/vehikl/trivia/pull/3.diff","patch_url":"https://github.com/vehikl/trivia/pull/3.patch","issue_url":"https://api.github.com/repos/vehikl/trivia/issues/3","number":3,"state":"open","locked":false,"title":"Attila and alex","user":{"login":"mrozbarry","id":566486,"avatar_url":"https://avatars0.githubusercontent.com/u/566486?v=4","gravatar_id":"","url":"https://api.github.com/users/mrozbarry","html_url":"https://github.com/mrozbarry","followers_url":"https://api.github.com/users/mrozbarry/followers","following_url":"https://api.github.com/users/mrozbarry/following{/other_user}","gists_url":"https://api.github.com/users/mrozbarry/gists{/gist_id}","starred_url":"https://api.github.com/users/mrozbarry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrozbarry/subscriptions","organizations_url":"https://api.github.com/users/mrozbarry/orgs","repos_url":"https://api.github.com/users/mrozbarry/repos","events_url":"https://api.github.com/users/mrozbarry/events{/privacy}","received_events_url":"https://api.github.com/users/mrozbarry/received_events","type":"User","site_admin":false},"body":"This is how far myself and Attila got. I will be adding notes in this PR to describe why we chose certain things to refactor.","created_at":"2018-04-17T13:44:16Z","updated_at":"2018-04-17T14:56:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e4d78c739f5ed9ccf6402e7a7caa581abd5f6819","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/vehikl/trivia/pulls/3/commits","review_comments_url":"https://api.github.com/repos/vehikl/trivia/pulls/3/comments","review_comment_url":"https://api.github.com/repos/vehikl/trivia/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vehikl/trivia/issues/3/comments","statuses_url":"https://api.github.com/repos/vehikl/trivia/statuses/0a6119b210bfafe8e6d8dd647830bffc12c902b9","head":{"label":"vehikl:attila-and-alex","ref":"attila-and-alex","sha":"0a6119b210bfafe8e6d8dd647830bffc12c902b9","user":{"login":"vehikl","id":6425636,"avatar_url":"https://avatars0.githubusercontent.com/u/6425636?v=4","gravatar_id":"","url":"https://api.github.com/users/vehikl","html_url":"https://github.com/vehikl","followers_url":"https://api.github.com/users/vehikl/followers","following_url":"https://api.github.com/users/vehikl/following{/other_user}","gists_url":"https://api.github.com/users/vehikl/gists{/gist_id}","starred_url":"https://api.github.com/users/vehikl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vehikl/subscriptions","organizations_url":"https://api.github.com/users/vehikl/orgs","repos_url":"https://api.github.com/users/vehikl/repos","events_url":"https://api.github.com/users/vehikl/events{/privacy}","received_events_url":"https://api.github.com/users/vehikl/received_events","type":"Organization","site_admin":false},"repo":{"id":129268025,"name":"trivia","full_name":"vehikl/trivia","owner":{"login":"vehikl","id":6425636,"avatar_url":"https://avatars0.githubusercontent.com/u/6425636?v=4","gravatar_id":"","url":"https://api.github.com/users/vehikl","html_url":"https://github.com/vehikl","followers_url":"https://api.github.com/users/vehikl/followers","following_url":"https://api.github.com/users/vehikl/following{/other_user}","gists_url":"https://api.github.com/users/vehikl/gists{/gist_id}","starred_url":"https://api.github.com/users/vehikl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vehikl/subscriptions","organizations_url":"https://api.github.com/users/vehikl/orgs","repos_url":"https://api.github.com/users/vehikl/repos","events_url":"https://api.github.com/users/vehikl/events{/privacy}","received_events_url":"https://api.github.com/users/vehikl/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vehikl/trivia","description":"Legacy Code Retreat - Trivia Game codebase","fork":true,"url":"https://api.github.com/repos/vehikl/trivia","forks_url":"https://api.github.com/repos/vehikl/trivia/forks","keys_url":"https://api.github.com/repos/vehikl/trivia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vehikl/trivia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vehikl/trivia/teams","hooks_url":"https://api.github.com/repos/vehikl/trivia/hooks","issue_events_url":"https://api.github.com/repos/vehikl/trivia/issues/events{/number}","events_url":"https://api.github.com/repos/vehikl/trivia/events","assignees_url":"https://api.github.com/repos/vehikl/trivia/assignees{/user}","branches_url":"https://api.github.com/repos/vehikl/trivia/branches{/branch}","tags_url":"https://api.github.com/repos/vehikl/trivia/tags","blobs_url":"https://api.github.com/repos/vehikl/trivia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vehikl/trivia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vehikl/trivia/git/refs{/sha}","trees_url":"https://api.github.com/repos/vehikl/trivia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vehikl/trivia/statuses/{sha}","languages_url":"https://api.github.com/repos/vehikl/trivia/languages","stargazers_url":"https://api.github.com/repos/vehikl/trivia/stargazers","contributors_url":"https://api.github.com/repos/vehikl/trivia/contributors","subscribers_url":"https://api.github.com/repos/vehikl/trivia/subscribers","subscription_url":"https://api.github.com/repos/vehikl/trivia/subscription","commits_url":"https://api.github.com/repos/vehikl/trivia/commits{/sha}","git_commits_url":"https://api.github.com/repos/vehikl/trivia/git/commits{/sha}","comments_url":"https://api.github.com/repos/vehikl/trivia/comments{/number}","issue_comment_url":"https://api.github.com/repos/vehikl/trivia/issues/comments{/number}","contents_url":"https://api.github.com/repos/vehikl/trivia/contents/{+path}","compare_url":"https://api.github.com/repos/vehikl/trivia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vehikl/trivia/merges","archive_url":"https://api.github.com/repos/vehikl/trivia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vehikl/trivia/downloads","issues_url":"https://api.github.com/repos/vehikl/trivia/issues{/number}","pulls_url":"https://api.github.com/repos/vehikl/trivia/pulls{/number}","milestones_url":"https://api.github.com/repos/vehikl/trivia/milestones{/number}","notifications_url":"https://api.github.com/repos/vehikl/trivia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vehikl/trivia/labels{/name}","releases_url":"https://api.github.com/repos/vehikl/trivia/releases{/id}","deployments_url":"https://api.github.com/repos/vehikl/trivia/deployments","created_at":"2018-04-12T14:55:59Z","updated_at":"2018-04-13T17:42:51Z","pushed_at":"2018-04-17T13:44:17Z","git_url":"git://github.com/vehikl/trivia.git","ssh_url":"[email protected]:vehikl/trivia.git","clone_url":"https://github.com/vehikl/trivia.git","svn_url":"https://github.com/vehikl/trivia","homepage":"http://legacycoderetreat.typepad.com","size":1502,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"base":{"label":"vehikl:master","ref":"master","sha":"8b5d8eba03279cc9ea95b7b18b75fe14c27d286d","user":{"login":"vehikl","id":6425636,"avatar_url":"https://avatars0.githubusercontent.com/u/6425636?v=4","gravatar_id":"","url":"https://api.github.com/users/vehikl","html_url":"https://github.com/vehikl","followers_url":"https://api.github.com/users/vehikl/followers","following_url":"https://api.github.com/users/vehikl/following{/other_user}","gists_url":"https://api.github.com/users/vehikl/gists{/gist_id}","starred_url":"https://api.github.com/users/vehikl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vehikl/subscriptions","organizations_url":"https://api.github.com/users/vehikl/orgs","repos_url":"https://api.github.com/users/vehikl/repos","events_url":"https://api.github.com/users/vehikl/events{/privacy}","received_events_url":"https://api.github.com/users/vehikl/received_events","type":"Organization","site_admin":false},"repo":{"id":129268025,"name":"trivia","full_name":"vehikl/trivia","owner":{"login":"vehikl","id":6425636,"avatar_url":"https://avatars0.githubusercontent.com/u/6425636?v=4","gravatar_id":"","url":"https://api.github.com/users/vehikl","html_url":"https://github.com/vehikl","followers_url":"https://api.github.com/users/vehikl/followers","following_url":"https://api.github.com/users/vehikl/following{/other_user}","gists_url":"https://api.github.com/users/vehikl/gists{/gist_id}","starred_url":"https://api.github.com/users/vehikl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vehikl/subscriptions","organizations_url":"https://api.github.com/users/vehikl/orgs","repos_url":"https://api.github.com/users/vehikl/repos","events_url":"https://api.github.com/users/vehikl/events{/privacy}","received_events_url":"https://api.github.com/users/vehikl/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vehikl/trivia","description":"Legacy Code Retreat - Trivia Game codebase","fork":true,"url":"https://api.github.com/repos/vehikl/trivia","forks_url":"https://api.github.com/repos/vehikl/trivia/forks","keys_url":"https://api.github.com/repos/vehikl/trivia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vehikl/trivia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vehikl/trivia/teams","hooks_url":"https://api.github.com/repos/vehikl/trivia/hooks","issue_events_url":"https://api.github.com/repos/vehikl/trivia/issues/events{/number}","events_url":"https://api.github.com/repos/vehikl/trivia/events","assignees_url":"https://api.github.com/repos/vehikl/trivia/assignees{/user}","branches_url":"https://api.github.com/repos/vehikl/trivia/branches{/branch}","tags_url":"https://api.github.com/repos/vehikl/trivia/tags","blobs_url":"https://api.github.com/repos/vehikl/trivia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vehikl/trivia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vehikl/trivia/git/refs{/sha}","trees_url":"https://api.github.com/repos/vehikl/trivia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vehikl/trivia/statuses/{sha}","languages_url":"https://api.github.com/repos/vehikl/trivia/languages","stargazers_url":"https://api.github.com/repos/vehikl/trivia/stargazers","contributors_url":"https://api.github.com/repos/vehikl/trivia/contributors","subscribers_url":"https://api.github.com/repos/vehikl/trivia/subscribers","subscription_url":"https://api.github.com/repos/vehikl/trivia/subscription","commits_url":"https://api.github.com/repos/vehikl/trivia/commits{/sha}","git_commits_url":"https://api.github.com/repos/vehikl/trivia/git/commits{/sha}","comments_url":"https://api.github.com/repos/vehikl/trivia/comments{/number}","issue_comment_url":"https://api.github.com/repos/vehikl/trivia/issues/comments{/number}","contents_url":"https://api.github.com/repos/vehikl/trivia/contents/{+path}","compare_url":"https://api.github.com/repos/vehikl/trivia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vehikl/trivia/merges","archive_url":"https://api.github.com/repos/vehikl/trivia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vehikl/trivia/downloads","issues_url":"https://api.github.com/repos/vehikl/trivia/issues{/number}","pulls_url":"https://api.github.com/repos/vehikl/trivia/pulls{/number}","milestones_url":"https://api.github.com/repos/vehikl/trivia/milestones{/number}","notifications_url":"https://api.github.com/repos/vehikl/trivia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vehikl/trivia/labels{/name}","releases_url":"https://api.github.com/repos/vehikl/trivia/releases{/id}","deployments_url":"https://api.github.com/repos/vehikl/trivia/deployments","created_at":"2018-04-12T14:55:59Z","updated_at":"2018-04-13T17:42:51Z","pushed_at":"2018-04-17T13:44:17Z","git_url":"git://github.com/vehikl/trivia.git","ssh_url":"[email protected]:vehikl/trivia.git","clone_url":"https://github.com/vehikl/trivia.git","svn_url":"https://github.com/vehikl/trivia","homepage":"http://legacycoderetreat.typepad.com","size":1502,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vehikl/trivia/pulls/3"},"html":{"href":"https://github.com/vehikl/trivia/pull/3"},"issue":{"href":"https://api.github.com/repos/vehikl/trivia/issues/3"},"comments":{"href":"https://api.github.com/repos/vehikl/trivia/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/vehikl/trivia/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/vehikl/trivia/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vehikl/trivia/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/vehikl/trivia/statuses/0a6119b210bfafe8e6d8dd647830bffc12c902b9"}},"author_association":"NONE"}} | {
"id": 129268025,
"name": "vehikl/trivia",
"url": "https://api.github.com/repos/vehikl/trivia"
} | {
"id": 566486,
"login": "mrozbarry",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/566486?",
"url": "https://api.github.com/users/mrozbarry"
} | {
"id": 6425636,
"login": "vehikl",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6425636?",
"url": "https://api.github.com/orgs/vehikl"
} | 2018-04-17T14:56:24 | 7543204629 | {"actor":{"display_login":"mrozbarry"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/aspnet/Docs/pulls/comments/168541462","pull_request_review_id":96923080,"id":168541462,"diff_hunk":"@@ -0,0 +1,241 @@\n+---\n+title: Making HTTP Requests\n+author: stevejgordon\n+description: Learn about using the HttpClientFactory features to \n+manager: wpickett\n+ms.author: riande\n+ms.date: 02/15/2018\n+ms.prod: asp.net-core\n+ms.technology: aspnet\n+ms.topic: article\n+uid: fundamentals/http-requests\n+---\n+# Making HTTP Requests\n+\n+By [Glenn Condron](https://github.com/glennc), [Ryan Nowak](https://github.com/rynowak) and [Steve Gordon](https://github.com/stevejgordon) \n+\n+A `HttpClientFactory` can be registered and used to configure and consume `HttpClient` instances in your application. It provides several benefits:\n+\n+1. Provides a central location for naming and configuring logical HttpClients. For example, you may configure a “github” client that is pre-configured to access github and a default client for other purposes.\n+2. Codifies the concept of outgoing middleware via delegating handlers in HttpClient and implementing Polly based middleware to take advantage of that. HttpClient already has the concept of delegating handlers that could be linked together for outgoing HTTP requests. The factory will make registering of these per named client more intuitive as well as implement a Polly handler that allows Polly policies to be used for Retry, CircuitBreakers, etc.\n+3. Manage the lifetime of HttpClientMessageHandlers to avoid common DNS problems that can be hit when managing HttpClient lifetimes yourself.\n+\n+## Consumption patterns\n+\n+There are several ways that `HttpClientFactory` can be used in your application. None of them are strictly superior to another, it really depends on your application and the constraints you are working under.\n+\n+## Basic usage\n+\n+The `HttpClientFactory` can be used directly in your code to access `HttpClient` instances. First the services must be registered with the ServiceProvider.\n+\n+```csharp\n+public void ConfigureServices(IServiceCollection services)\n+{\n+ services.AddHttpClient();\n+ services.AddMvc();\n+}\n+```\n+\n+Once registered, you can accept a `IHttpClientFactory` in your constructor which can then be used to create a `HttpClient`.\n+\n+```csharp\n+public class MyController : Controller\n+{\n+ IHttpClientFactory _httpClientFactory;\n+\n+ public MyController(IHttpClientFactory httpClientFactory)\n+ {\n+ _httpClientFactory = httpClientFactory;\n+ }\n+\n+ public IActionResult Index()\n+ {\n+ var client = _httpClientFactory.CreateClient();\n+ var result = client.GetStringAsync(\"http://myurl/\");\n+ return View();\n+ }\n+}\n+```\n+\n+Using `HttpClientFactory` like this is a good way to start refactoring an existing application, as it has no impact on the way you use HttpClient. In places where you create HttpClients, replace those with a call to `CreateClient()`.\n+\n+## Named clients\n+\n+ If you have multiple distinct uses of HttpClient, each with different configurations, then you may want to use **named clients**. The common configuration for the use of that named HttpClient can be specified during registration.\n+\n+```csharp\n+ public void ConfigureServices(IServiceCollection services)\n+{\n+ services.AddHttpClient(\"github\", c =>\n+ {\n+ c.BaseAddress = new Uri(\"https://api.github.com/\");\n+\n+ c.DefaultRequestHeaders.Add(\"Accept\", \"application/vnd.github.v3+json\"); // Github API versioning\n+ c.DefaultRequestHeaders.Add(\"User-Agent\", \"HttpClientFactory-Sample\"); // Github requires a user-agent\n+ });\n+ services.AddHttpClient();\n+}\n+```\n+\n+Here `AddHttpClient` has been called twice; once with the name 'github' and once without. The github specific client has some default configuration applied, namely the base address and two headers required to work with the GitHub API.\n+\n+The configuration function here will get called every time CreateClient is called, as a new instance of HttpClient is created each time.\n+\n+To consume a named client in your code you can pass the name of the client to `CreateClient`.\n+\n+```csharp\n+public class MyController : Controller\n+{\n+ IHttpClientFactory _httpClientFactory;\n+\n+ public MyController(IHttpClientFactory httpClientFactory)\n+ {\n+ _httpClientFactory = httpClientFactory;\n+ }\n+\n+ public IActionResult Index()\n+ {\n+ var defaultClient = _httpClientFactory.CreateClient();\n+ var gitHubClient = _httpClientFactory.CreateClient(\"github\");\n+ return View();\n+ }\n+}\n+```\n+\n+In the above code the gitHubClient will have the BaseAddress and headers set whereas the defaultClient does not. This provides you the with the ability to have different configurations for different purposes. This may mean different configurations per endpoint/API for example.\n+\n+HttpClientFactory will create, and cache, a single HttpMessageHandler per named client. Meaning that if you were to use netstat or some other tool to view connections on the host machine you would generally see a single TCP connection for each named client, rather than one per instance when you new-up and dispose of a HttpClient manually.\n+\n+## Typed clients\n+\n+Typed Clients give you the same capabilities as named clients without the need for using strings as keys. This provides intellisense and compiler help when consuming clients. They also provide a single location to configure and interact with a particular HttpClient. For example, a single typed client might be used for a single backend endpoint and encapsulate all logic which deals with that endpoint. ","path":"aspnetcore/fundamentals/http-requests.md","position":111,"original_position":111,"commit_id":"37a56fb1979bd439e18acc33e8e5c57704e34cde","original_commit_id":"37a56fb1979bd439e18acc33e8e5c57704e34cde","user":{"login":"scottaddie","id":10702007,"avatar_url":"https://avatars3.githubusercontent.com/u/10702007?v=4","gravatar_id":"","url":"https://api.github.com/users/scottaddie","html_url":"https://github.com/scottaddie","followers_url":"https://api.github.com/users/scottaddie/followers","following_url":"https://api.github.com/users/scottaddie/following{/other_user}","gists_url":"https://api.github.com/users/scottaddie/gists{/gist_id}","starred_url":"https://api.github.com/users/scottaddie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scottaddie/subscriptions","organizations_url":"https://api.github.com/users/scottaddie/orgs","repos_url":"https://api.github.com/users/scottaddie/repos","events_url":"https://api.github.com/users/scottaddie/events{/privacy}","received_events_url":"https://api.github.com/users/scottaddie/received_events","type":"User","site_admin":false},"body":"- Typed Clients --> Typed clients\r\n- intellisense --> IntelliSense","created_at":"2018-02-15T17:01:39Z","updated_at":"2018-02-15T17:08:56Z","html_url":"https://github.com/aspnet/Docs/pull/5483#discussion_r168541462","pull_request_url":"https://api.github.com/repos/aspnet/Docs/pulls/5483","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/aspnet/Docs/pulls/comments/168541462"},"html":{"href":"https://github.com/aspnet/Docs/pull/5483#discussion_r168541462"},"pull_request":{"href":"https://api.github.com/repos/aspnet/Docs/pulls/5483"}}},"pull_request":{"url":"https://api.github.com/repos/aspnet/Docs/pulls/5483","id":169376420,"html_url":"https://github.com/aspnet/Docs/pull/5483","diff_url":"https://github.com/aspnet/Docs/pull/5483.diff","patch_url":"https://github.com/aspnet/Docs/pull/5483.patch","issue_url":"https://api.github.com/repos/aspnet/Docs/issues/5483","number":5483,"state":"open","locked":false,"title":"[WIP] Starting work on HttpClientFactory documentation ","user":{"login":"stevejgordon","id":3669103,"avatar_url":"https://avatars0.githubusercontent.com/u/3669103?v=4","gravatar_id":"","url":"https://api.github.com/users/stevejgordon","html_url":"https://github.com/stevejgordon","followers_url":"https://api.github.com/users/stevejgordon/followers","following_url":"https://api.github.com/users/stevejgordon/following{/other_user}","gists_url":"https://api.github.com/users/stevejgordon/gists{/gist_id}","starred_url":"https://api.github.com/users/stevejgordon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevejgordon/subscriptions","organizations_url":"https://api.github.com/users/stevejgordon/orgs","repos_url":"https://api.github.com/users/stevejgordon/repos","events_url":"https://api.github.com/users/stevejgordon/events{/privacy}","received_events_url":"https://api.github.com/users/stevejgordon/received_events","type":"User","site_admin":false},"body":"Fixes #5402\r\n\r\nThis is an early WIP PR to share the initial hour of work on this piece of documentation. A majority of it is brought across from the [HttpClientFactory Wiki](https://github.com/aspnet/HttpClientFactory/wiki) by @glennc and @rynowak \r\n\r\nI have not proof read this / finished working on the actual wording yet. It's here purely to get early feedback that I'm heading in the right direction at this stage and structuring things correctly. \r\n\r\nThoughts very much welcomed from @scottaddie and the product team.\r\n","created_at":"2018-02-15T13:51:10Z","updated_at":"2018-02-15T17:08:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3d4874621b4e9f709d634a2ac3ded6ec45ccb00b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/aspnet/Docs/pulls/5483/commits","review_comments_url":"https://api.github.com/repos/aspnet/Docs/pulls/5483/comments","review_comment_url":"https://api.github.com/repos/aspnet/Docs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aspnet/Docs/issues/5483/comments","statuses_url":"https://api.github.com/repos/aspnet/Docs/statuses/37a56fb1979bd439e18acc33e8e5c57704e34cde","head":{"label":"stevejgordon:stevejgordon/httpclientfactory","ref":"stevejgordon/httpclientfactory","sha":"37a56fb1979bd439e18acc33e8e5c57704e34cde","user":{"login":"stevejgordon","id":3669103,"avatar_url":"https://avatars0.githubusercontent.com/u/3669103?v=4","gravatar_id":"","url":"https://api.github.com/users/stevejgordon","html_url":"https://github.com/stevejgordon","followers_url":"https://api.github.com/users/stevejgordon/followers","following_url":"https://api.github.com/users/stevejgordon/following{/other_user}","gists_url":"https://api.github.com/users/stevejgordon/gists{/gist_id}","starred_url":"https://api.github.com/users/stevejgordon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevejgordon/subscriptions","organizations_url":"https://api.github.com/users/stevejgordon/orgs","repos_url":"https://api.github.com/users/stevejgordon/repos","events_url":"https://api.github.com/users/stevejgordon/events{/privacy}","received_events_url":"https://api.github.com/users/stevejgordon/received_events","type":"User","site_admin":false},"repo":{"id":121606562,"name":"Docs","full_name":"stevejgordon/Docs","owner":{"login":"stevejgordon","id":3669103,"avatar_url":"https://avatars0.githubusercontent.com/u/3669103?v=4","gravatar_id":"","url":"https://api.github.com/users/stevejgordon","html_url":"https://github.com/stevejgordon","followers_url":"https://api.github.com/users/stevejgordon/followers","following_url":"https://api.github.com/users/stevejgordon/following{/other_user}","gists_url":"https://api.github.com/users/stevejgordon/gists{/gist_id}","starred_url":"https://api.github.com/users/stevejgordon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevejgordon/subscriptions","organizations_url":"https://api.github.com/users/stevejgordon/orgs","repos_url":"https://api.github.com/users/stevejgordon/repos","events_url":"https://api.github.com/users/stevejgordon/events{/privacy}","received_events_url":"https://api.github.com/users/stevejgordon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/stevejgordon/Docs","description":"Documentation for ASP.NET and ASP.NET Core","fork":true,"url":"https://api.github.com/repos/stevejgordon/Docs","forks_url":"https://api.github.com/repos/stevejgordon/Docs/forks","keys_url":"https://api.github.com/repos/stevejgordon/Docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stevejgordon/Docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stevejgordon/Docs/teams","hooks_url":"https://api.github.com/repos/stevejgordon/Docs/hooks","issue_events_url":"https://api.github.com/repos/stevejgordon/Docs/issues/events{/number}","events_url":"https://api.github.com/repos/stevejgordon/Docs/events","assignees_url":"https://api.github.com/repos/stevejgordon/Docs/assignees{/user}","branches_url":"https://api.github.com/repos/stevejgordon/Docs/branches{/branch}","tags_url":"https://api.github.com/repos/stevejgordon/Docs/tags","blobs_url":"https://api.github.com/repos/stevejgordon/Docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stevejgordon/Docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stevejgordon/Docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/stevejgordon/Docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stevejgordon/Docs/statuses/{sha}","languages_url":"https://api.github.com/repos/stevejgordon/Docs/languages","stargazers_url":"https://api.github.com/repos/stevejgordon/Docs/stargazers","contributors_url":"https://api.github.com/repos/stevejgordon/Docs/contributors","subscribers_url":"https://api.github.com/repos/stevejgordon/Docs/subscribers","subscription_url":"https://api.github.com/repos/stevejgordon/Docs/subscription","commits_url":"https://api.github.com/repos/stevejgordon/Docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/stevejgordon/Docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/stevejgordon/Docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/stevejgordon/Docs/issues/comments{/number}","contents_url":"https://api.github.com/repos/stevejgordon/Docs/contents/{+path}","compare_url":"https://api.github.com/repos/stevejgordon/Docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stevejgordon/Docs/merges","archive_url":"https://api.github.com/repos/stevejgordon/Docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stevejgordon/Docs/downloads","issues_url":"https://api.github.com/repos/stevejgordon/Docs/issues{/number}","pulls_url":"https://api.github.com/repos/stevejgordon/Docs/pulls{/number}","milestones_url":"https://api.github.com/repos/stevejgordon/Docs/milestones{/number}","notifications_url":"https://api.github.com/repos/stevejgordon/Docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stevejgordon/Docs/labels{/name}","releases_url":"https://api.github.com/repos/stevejgordon/Docs/releases{/id}","deployments_url":"https://api.github.com/repos/stevejgordon/Docs/deployments","created_at":"2018-02-15T08:34:29Z","updated_at":"2018-02-15T08:35:14Z","pushed_at":"2018-02-15T14:01:54Z","git_url":"git://github.com/stevejgordon/Docs.git","ssh_url":"[email protected]:stevejgordon/Docs.git","clone_url":"https://github.com/stevejgordon/Docs.git","svn_url":"https://github.com/stevejgordon/Docs","homepage":"https://docs.microsoft.com/aspnet","size":611198,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"aspnet:master","ref":"master","sha":"025b58d239d4e07a2cd33899cbbed42744d26953","user":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars3.githubusercontent.com/u/6476660?v=4","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":28239455,"name":"Docs","full_name":"aspnet/Docs","owner":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars3.githubusercontent.com/u/6476660?v=4","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aspnet/Docs","description":"Documentation for ASP.NET and ASP.NET Core","fork":false,"url":"https://api.github.com/repos/aspnet/Docs","forks_url":"https://api.github.com/repos/aspnet/Docs/forks","keys_url":"https://api.github.com/repos/aspnet/Docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/Docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/Docs/teams","hooks_url":"https://api.github.com/repos/aspnet/Docs/hooks","issue_events_url":"https://api.github.com/repos/aspnet/Docs/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/Docs/events","assignees_url":"https://api.github.com/repos/aspnet/Docs/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/Docs/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/Docs/tags","blobs_url":"https://api.github.com/repos/aspnet/Docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/Docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/Docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/Docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/Docs/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/Docs/languages","stargazers_url":"https://api.github.com/repos/aspnet/Docs/stargazers","contributors_url":"https://api.github.com/repos/aspnet/Docs/contributors","subscribers_url":"https://api.github.com/repos/aspnet/Docs/subscribers","subscription_url":"https://api.github.com/repos/aspnet/Docs/subscription","commits_url":"https://api.github.com/repos/aspnet/Docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/Docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/Docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/Docs/issues/comments{/number}","contents_url":"https://api.github.com/repos/aspnet/Docs/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/Docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/Docs/merges","archive_url":"https://api.github.com/repos/aspnet/Docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/Docs/downloads","issues_url":"https://api.github.com/repos/aspnet/Docs/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/Docs/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/Docs/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/Docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/Docs/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/Docs/releases{/id}","deployments_url":"https://api.github.com/repos/aspnet/Docs/deployments","created_at":"2014-12-19T17:38:02Z","updated_at":"2018-02-15T14:12:35Z","pushed_at":"2018-02-15T16:50:54Z","git_url":"git://github.com/aspnet/Docs.git","ssh_url":"[email protected]:aspnet/Docs.git","clone_url":"https://github.com/aspnet/Docs.git","svn_url":"https://github.com/aspnet/Docs","homepage":"https://docs.microsoft.com/aspnet","size":611208,"stargazers_count":2258,"watchers_count":2258,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5494,"mirror_url":null,"archived":false,"open_issues_count":202,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":5494,"open_issues":202,"watchers":2258,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/aspnet/Docs/pulls/5483"},"html":{"href":"https://github.com/aspnet/Docs/pull/5483"},"issue":{"href":"https://api.github.com/repos/aspnet/Docs/issues/5483"},"comments":{"href":"https://api.github.com/repos/aspnet/Docs/issues/5483/comments"},"review_comments":{"href":"https://api.github.com/repos/aspnet/Docs/pulls/5483/comments"},"review_comment":{"href":"https://api.github.com/repos/aspnet/Docs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aspnet/Docs/pulls/5483/commits"},"statuses":{"href":"https://api.github.com/repos/aspnet/Docs/statuses/37a56fb1979bd439e18acc33e8e5c57704e34cde"}},"author_association":"NONE"}} | {
"id": 28239455,
"name": "aspnet/Docs",
"url": "https://api.github.com/repos/aspnet/Docs"
} | {
"id": 10702007,
"login": "scottaddie",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/10702007?",
"url": "https://api.github.com/users/scottaddie"
} | {
"id": 6476660,
"login": "aspnet",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6476660?",
"url": "https://api.github.com/orgs/aspnet"
} | 2018-02-15T17:01:39 | 7250772678 | {"actor":{"display_login":"scottaddie"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/aspnet/SignalR/pulls/comments/185317158","pull_request_review_id":116681284,"id":185317158,"diff_hunk":"@@ -282,7 +282,7 @@ export class HttpConnection implements IConnection {\n }\n \n private isITransport(transport: any): transport is ITransport {\n- return typeof (transport) === \"object\" && \"connect\" in transport;\n+ return transport && typeof (transport) === \"object\" && \"connect\" in transport;","path":"clients/ts/signalr/src/HttpConnection.ts","position":14,"original_position":14,"commit_id":"66f3de3a93973558e2b1daf12c9b259fabfb7ae0","original_commit_id":"66f3de3a93973558e2b1daf12c9b259fabfb7ae0","user":{"login":"anurse","id":7574,"avatar_url":"https://avatars3.githubusercontent.com/u/7574?v=4","gravatar_id":"","url":"https://api.github.com/users/anurse","html_url":"https://github.com/anurse","followers_url":"https://api.github.com/users/anurse/followers","following_url":"https://api.github.com/users/anurse/following{/other_user}","gists_url":"https://api.github.com/users/anurse/gists{/gist_id}","starred_url":"https://api.github.com/users/anurse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anurse/subscriptions","organizations_url":"https://api.github.com/users/anurse/orgs","repos_url":"https://api.github.com/users/anurse/repos","events_url":"https://api.github.com/users/anurse/events{/privacy}","received_events_url":"https://api.github.com/users/anurse/received_events","type":"User","site_admin":false},"body":"This was needed because it fails if `transport` is `null`. That was true before my change too. `typeof null` is `object` (see below) but you can't use `in` with `null`, nor can you check for a method. There's a similar place we do this with `ILogger` that I'll fix as well.\r\n\r\n\r\n\r\n\r\n\r\n\r\n","created_at":"2018-05-01T19:55:24Z","updated_at":"2018-05-01T19:55:29Z","html_url":"https://github.com/aspnet/SignalR/pull/2179#discussion_r185317158","pull_request_url":"https://api.github.com/repos/aspnet/SignalR/pulls/2179","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/aspnet/SignalR/pulls/comments/185317158"},"html":{"href":"https://github.com/aspnet/SignalR/pull/2179#discussion_r185317158"},"pull_request":{"href":"https://api.github.com/repos/aspnet/SignalR/pulls/2179"}}},"pull_request":{"url":"https://api.github.com/repos/aspnet/SignalR/pulls/2179","id":185259795,"html_url":"https://github.com/aspnet/SignalR/pull/2179","diff_url":"https://github.com/aspnet/SignalR/pull/2179.diff","patch_url":"https://github.com/aspnet/SignalR/pull/2179.patch","issue_url":"https://api.github.com/repos/aspnet/SignalR/issues/2179","number":2179,"state":"open","locked":false,"title":"Make HttpTransportType a flags enum in TypeScript","user":{"login":"anurse","id":7574,"avatar_url":"https://avatars3.githubusercontent.com/u/7574?v=4","gravatar_id":"","url":"https://api.github.com/users/anurse","html_url":"https://github.com/anurse","followers_url":"https://api.github.com/users/anurse/followers","following_url":"https://api.github.com/users/anurse/following{/other_user}","gists_url":"https://api.github.com/users/anurse/gists{/gist_id}","starred_url":"https://api.github.com/users/anurse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anurse/subscriptions","organizations_url":"https://api.github.com/users/anurse/orgs","repos_url":"https://api.github.com/users/anurse/repos","events_url":"https://api.github.com/users/anurse/events{/privacy}","received_events_url":"https://api.github.com/users/anurse/received_events","type":"User","site_admin":false},"body":"This is based on #2172 because it builds on that code and I didn't want to add this straight to that branch yet. I'll rebase on `release/2.1`.\r\n\r\nIt was pointed out in #2172 that we should make the `HttpTransportType` enum use powers of two so it could be made a flags enum in future (#1961 was initially punted). That got me thinking that this is kinda trivial, so what if we just do it now.","created_at":"2018-05-01T19:51:30Z","updated_at":"2018-05-01T19:55:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"540fb92fc33ebd6815331d48aaa3804fad2d7712","assignee":null,"assignees":[],"requested_reviewers":[{"login":"davidfowl","id":95136,"avatar_url":"https://avatars3.githubusercontent.com/u/95136?v=4","gravatar_id":"","url":"https://api.github.com/users/davidfowl","html_url":"https://github.com/davidfowl","followers_url":"https://api.github.com/users/davidfowl/followers","following_url":"https://api.github.com/users/davidfowl/following{/other_user}","gists_url":"https://api.github.com/users/davidfowl/gists{/gist_id}","starred_url":"https://api.github.com/users/davidfowl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidfowl/subscriptions","organizations_url":"https://api.github.com/users/davidfowl/orgs","repos_url":"https://api.github.com/users/davidfowl/repos","events_url":"https://api.github.com/users/davidfowl/events{/privacy}","received_events_url":"https://api.github.com/users/davidfowl/received_events","type":"User","site_admin":false},{"login":"JamesNK","id":303201,"avatar_url":"https://avatars2.githubusercontent.com/u/303201?v=4","gravatar_id":"","url":"https://api.github.com/users/JamesNK","html_url":"https://github.com/JamesNK","followers_url":"https://api.github.com/users/JamesNK/followers","following_url":"https://api.github.com/users/JamesNK/following{/other_user}","gists_url":"https://api.github.com/users/JamesNK/gists{/gist_id}","starred_url":"https://api.github.com/users/JamesNK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JamesNK/subscriptions","organizations_url":"https://api.github.com/users/JamesNK/orgs","repos_url":"https://api.github.com/users/JamesNK/repos","events_url":"https://api.github.com/users/JamesNK/events{/privacy}","received_events_url":"https://api.github.com/users/JamesNK/received_events","type":"User","site_admin":false},{"login":"mikaelm12","id":4809660,"avatar_url":"https://avatars1.githubusercontent.com/u/4809660?v=4","gravatar_id":"","url":"https://api.github.com/users/mikaelm12","html_url":"https://github.com/mikaelm12","followers_url":"https://api.github.com/users/mikaelm12/followers","following_url":"https://api.github.com/users/mikaelm12/following{/other_user}","gists_url":"https://api.github.com/users/mikaelm12/gists{/gist_id}","starred_url":"https://api.github.com/users/mikaelm12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikaelm12/subscriptions","organizations_url":"https://api.github.com/users/mikaelm12/orgs","repos_url":"https://api.github.com/users/mikaelm12/repos","events_url":"https://api.github.com/users/mikaelm12/events{/privacy}","received_events_url":"https://api.github.com/users/mikaelm12/received_events","type":"User","site_admin":false},{"login":"BrennanConroy","id":7574801,"avatar_url":"https://avatars0.githubusercontent.com/u/7574801?v=4","gravatar_id":"","url":"https://api.github.com/users/BrennanConroy","html_url":"https://github.com/BrennanConroy","followers_url":"https://api.github.com/users/BrennanConroy/followers","following_url":"https://api.github.com/users/BrennanConroy/following{/other_user}","gists_url":"https://api.github.com/users/BrennanConroy/gists{/gist_id}","starred_url":"https://api.github.com/users/BrennanConroy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BrennanConroy/subscriptions","organizations_url":"https://api.github.com/users/BrennanConroy/orgs","repos_url":"https://api.github.com/users/BrennanConroy/repos","events_url":"https://api.github.com/users/BrennanConroy/events{/privacy}","received_events_url":"https://api.github.com/users/BrennanConroy/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/aspnet/SignalR/pulls/2179/commits","review_comments_url":"https://api.github.com/repos/aspnet/SignalR/pulls/2179/comments","review_comment_url":"https://api.github.com/repos/aspnet/SignalR/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aspnet/SignalR/issues/2179/comments","statuses_url":"https://api.github.com/repos/aspnet/SignalR/statuses/66f3de3a93973558e2b1daf12c9b259fabfb7ae0","head":{"label":"aspnet:anurse/flags-enum-ts","ref":"anurse/flags-enum-ts","sha":"66f3de3a93973558e2b1daf12c9b259fabfb7ae0","user":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars3.githubusercontent.com/u/6476660?v=4","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":71159589,"name":"SignalR","full_name":"aspnet/SignalR","owner":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars3.githubusercontent.com/u/6476660?v=4","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aspnet/SignalR","description":"Incredibly simple real-time web for ASP.NET Core","fork":false,"url":"https://api.github.com/repos/aspnet/SignalR","forks_url":"https://api.github.com/repos/aspnet/SignalR/forks","keys_url":"https://api.github.com/repos/aspnet/SignalR/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/SignalR/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/SignalR/teams","hooks_url":"https://api.github.com/repos/aspnet/SignalR/hooks","issue_events_url":"https://api.github.com/repos/aspnet/SignalR/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/SignalR/events","assignees_url":"https://api.github.com/repos/aspnet/SignalR/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/SignalR/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/SignalR/tags","blobs_url":"https://api.github.com/repos/aspnet/SignalR/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/SignalR/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/SignalR/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/SignalR/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/SignalR/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/SignalR/languages","stargazers_url":"https://api.github.com/repos/aspnet/SignalR/stargazers","contributors_url":"https://api.github.com/repos/aspnet/SignalR/contributors","subscribers_url":"https://api.github.com/repos/aspnet/SignalR/subscribers","subscription_url":"https://api.github.com/repos/aspnet/SignalR/subscription","commits_url":"https://api.github.com/repos/aspnet/SignalR/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/SignalR/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/SignalR/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/SignalR/issues/comments{/number}","contents_url":"https://api.github.com/repos/aspnet/SignalR/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/SignalR/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/SignalR/merges","archive_url":"https://api.github.com/repos/aspnet/SignalR/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/SignalR/downloads","issues_url":"https://api.github.com/repos/aspnet/SignalR/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/SignalR/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/SignalR/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/SignalR/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/SignalR/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/SignalR/releases{/id}","deployments_url":"https://api.github.com/repos/aspnet/SignalR/deployments","created_at":"2016-10-17T16:39:15Z","updated_at":"2018-05-01T17:06:52Z","pushed_at":"2018-05-01T19:55:12Z","git_url":"git://github.com/aspnet/SignalR.git","ssh_url":"[email protected]:aspnet/SignalR.git","clone_url":"https://github.com/aspnet/SignalR.git","svn_url":"https://github.com/aspnet/SignalR","homepage":null,"size":8759,"stargazers_count":1715,"watchers_count":1715,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":287,"mirror_url":null,"archived":false,"open_issues_count":120,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":287,"open_issues":120,"watchers":1715,"default_branch":"dev"}},"base":{"label":"aspnet:anurse/2171-httptransporttype-none","ref":"anurse/2171-httptransporttype-none","sha":"84a233b44132823c2f0b191751b0c339ef7d21de","user":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars3.githubusercontent.com/u/6476660?v=4","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":71159589,"name":"SignalR","full_name":"aspnet/SignalR","owner":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars3.githubusercontent.com/u/6476660?v=4","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aspnet/SignalR","description":"Incredibly simple real-time web for ASP.NET Core","fork":false,"url":"https://api.github.com/repos/aspnet/SignalR","forks_url":"https://api.github.com/repos/aspnet/SignalR/forks","keys_url":"https://api.github.com/repos/aspnet/SignalR/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/SignalR/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/SignalR/teams","hooks_url":"https://api.github.com/repos/aspnet/SignalR/hooks","issue_events_url":"https://api.github.com/repos/aspnet/SignalR/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/SignalR/events","assignees_url":"https://api.github.com/repos/aspnet/SignalR/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/SignalR/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/SignalR/tags","blobs_url":"https://api.github.com/repos/aspnet/SignalR/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/SignalR/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/SignalR/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/SignalR/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/SignalR/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/SignalR/languages","stargazers_url":"https://api.github.com/repos/aspnet/SignalR/stargazers","contributors_url":"https://api.github.com/repos/aspnet/SignalR/contributors","subscribers_url":"https://api.github.com/repos/aspnet/SignalR/subscribers","subscription_url":"https://api.github.com/repos/aspnet/SignalR/subscription","commits_url":"https://api.github.com/repos/aspnet/SignalR/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/SignalR/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/SignalR/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/SignalR/issues/comments{/number}","contents_url":"https://api.github.com/repos/aspnet/SignalR/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/SignalR/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/SignalR/merges","archive_url":"https://api.github.com/repos/aspnet/SignalR/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/SignalR/downloads","issues_url":"https://api.github.com/repos/aspnet/SignalR/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/SignalR/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/SignalR/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/SignalR/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/SignalR/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/SignalR/releases{/id}","deployments_url":"https://api.github.com/repos/aspnet/SignalR/deployments","created_at":"2016-10-17T16:39:15Z","updated_at":"2018-05-01T17:06:52Z","pushed_at":"2018-05-01T19:55:12Z","git_url":"git://github.com/aspnet/SignalR.git","ssh_url":"[email protected]:aspnet/SignalR.git","clone_url":"https://github.com/aspnet/SignalR.git","svn_url":"https://github.com/aspnet/SignalR","homepage":null,"size":8759,"stargazers_count":1715,"watchers_count":1715,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":287,"mirror_url":null,"archived":false,"open_issues_count":120,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":287,"open_issues":120,"watchers":1715,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/aspnet/SignalR/pulls/2179"},"html":{"href":"https://github.com/aspnet/SignalR/pull/2179"},"issue":{"href":"https://api.github.com/repos/aspnet/SignalR/issues/2179"},"comments":{"href":"https://api.github.com/repos/aspnet/SignalR/issues/2179/comments"},"review_comments":{"href":"https://api.github.com/repos/aspnet/SignalR/pulls/2179/comments"},"review_comment":{"href":"https://api.github.com/repos/aspnet/SignalR/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aspnet/SignalR/pulls/2179/commits"},"statuses":{"href":"https://api.github.com/repos/aspnet/SignalR/statuses/66f3de3a93973558e2b1daf12c9b259fabfb7ae0"}},"author_association":"MEMBER"}} | {
"id": 71159589,
"name": "aspnet/SignalR",
"url": "https://api.github.com/repos/aspnet/SignalR"
} | {
"id": 7574,
"login": "anurse",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7574?",
"url": "https://api.github.com/users/anurse"
} | {
"id": 6476660,
"login": "aspnet",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6476660?",
"url": "https://api.github.com/orgs/aspnet"
} | 2018-05-01T19:55:24 | 7613087591 | {"actor":{"display_login":"anurse"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/legatoproject/legato-af/pulls/comments/169820325","pull_request_review_id":98409678,"id":169820325,"diff_hunk":"@@ -31,7 +31,23 @@ requires:\n {\n device:\n {\n+#if ${LEGATO_TARGET} = wp85\n [rw] /dev/spidev0.0 /dev/\n+#elif ${LEGATO_TARGET} = wp750x\n+ [rw] /dev/spidev0.0 /dev/\n+#elif ${LEGATO_TARGET} = wp76xx\n+ [rw] /dev/spidev1.0 /dev/\n+#elif ${LEGATO_TARGET} = wp77xx\n+ [rw] /dev/spidev1.0 /dev/\n+#elif ${LEGATO_TARGET} = ar7\n+ // TODO: ar7 device path\n+#elif ${LEGATO_TARGET} = ar758x\n+ // TODO: ar758x device path\n+#elif ${LEGATO_TARGET} = ar86\n+ // TODO: ar86 device path\n+#elif ${LEGATO_TARGET} = em75xx\n+ // TODO: em75xx device path","path":"apps/platformServices/spiService.adef","position":19,"original_position":19,"commit_id":"cc33db5a8e24cdafb8b9c9bc3a42a27f33bcca90","original_commit_id":"cc33db5a8e24cdafb8b9c9bc3a42a27f33bcca90","user":{"login":"dpfrey","id":742786,"avatar_url":"https://avatars0.githubusercontent.com/u/742786?v=4","gravatar_id":"","url":"https://api.github.com/users/dpfrey","html_url":"https://github.com/dpfrey","followers_url":"https://api.github.com/users/dpfrey/followers","following_url":"https://api.github.com/users/dpfrey/following{/other_user}","gists_url":"https://api.github.com/users/dpfrey/gists{/gist_id}","starred_url":"https://api.github.com/users/dpfrey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dpfrey/subscriptions","organizations_url":"https://api.github.com/users/dpfrey/orgs","repos_url":"https://api.github.com/users/dpfrey/repos","events_url":"https://api.github.com/users/dpfrey/events{/privacy}","received_events_url":"https://api.github.com/users/dpfrey/received_events","type":"User","site_admin":false},"body":"Do you mean something like this?\r\n\r\n*target/mdm9x07.sinc*\r\n```\r\nbuildVars:\r\n{\r\n...\r\n PRIMARY_SPI_DEVICE = '/dev/spidev1.0'\r\n...\r\n}\r\n```\r\n\r\n*target/mdm9x15.sinc*\r\n```\r\nbuildVars:\r\n{\r\n...\r\n PRIMARY_SPI_DEVICE = '/dev/spidev0.0'\r\n...\r\n}\r\n```","created_at":"2018-02-22T00:13:32Z","updated_at":"2018-02-22T00:13:32Z","html_url":"https://github.com/legatoproject/legato-af/pull/24#discussion_r169820325","pull_request_url":"https://api.github.com/repos/legatoproject/legato-af/pulls/24","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/legatoproject/legato-af/pulls/comments/169820325"},"html":{"href":"https://github.com/legatoproject/legato-af/pull/24#discussion_r169820325"},"pull_request":{"href":"https://api.github.com/repos/legatoproject/legato-af/pulls/24"}},"in_reply_to_id":169818162},"pull_request":{"url":"https://api.github.com/repos/legatoproject/legato-af/pulls/24","id":170564918,"html_url":"https://github.com/legatoproject/legato-af/pull/24","diff_url":"https://github.com/legatoproject/legato-af/pull/24.diff","patch_url":"https://github.com/legatoproject/legato-af/pull/24.patch","issue_url":"https://api.github.com/repos/legatoproject/legato-af/issues/24","number":24,"state":"open","locked":false,"title":"spiService: Use #if in adef to support wp76, wp77","user":{"login":"dpfrey","id":742786,"avatar_url":"https://avatars0.githubusercontent.com/u/742786?v=4","gravatar_id":"","url":"https://api.github.com/users/dpfrey","html_url":"https://github.com/dpfrey","followers_url":"https://api.github.com/users/dpfrey/followers","following_url":"https://api.github.com/users/dpfrey/following{/other_user}","gists_url":"https://api.github.com/users/dpfrey/gists{/gist_id}","starred_url":"https://api.github.com/users/dpfrey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dpfrey/subscriptions","organizations_url":"https://api.github.com/users/dpfrey/orgs","repos_url":"https://api.github.com/users/dpfrey/repos","events_url":"https://api.github.com/users/dpfrey/events{/privacy}","received_events_url":"https://api.github.com/users/dpfrey/received_events","type":"User","site_admin":false},"body":"Resolves: #23","created_at":"2018-02-21T19:26:18Z","updated_at":"2018-02-22T00:13:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3d3ca7be76c6eb9b9e87e10c000f4a46d4b56fa4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/legatoproject/legato-af/pulls/24/commits","review_comments_url":"https://api.github.com/repos/legatoproject/legato-af/pulls/24/comments","review_comment_url":"https://api.github.com/repos/legatoproject/legato-af/pulls/comments{/number}","comments_url":"https://api.github.com/repos/legatoproject/legato-af/issues/24/comments","statuses_url":"https://api.github.com/repos/legatoproject/legato-af/statuses/cc33db5a8e24cdafb8b9c9bc3a42a27f33bcca90","head":{"label":"dpfrey:spiService_on_wp76xx_wp77xx","ref":"spiService_on_wp76xx_wp77xx","sha":"cc33db5a8e24cdafb8b9c9bc3a42a27f33bcca90","user":{"login":"dpfrey","id":742786,"avatar_url":"https://avatars0.githubusercontent.com/u/742786?v=4","gravatar_id":"","url":"https://api.github.com/users/dpfrey","html_url":"https://github.com/dpfrey","followers_url":"https://api.github.com/users/dpfrey/followers","following_url":"https://api.github.com/users/dpfrey/following{/other_user}","gists_url":"https://api.github.com/users/dpfrey/gists{/gist_id}","starred_url":"https://api.github.com/users/dpfrey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dpfrey/subscriptions","organizations_url":"https://api.github.com/users/dpfrey/orgs","repos_url":"https://api.github.com/users/dpfrey/repos","events_url":"https://api.github.com/users/dpfrey/events{/privacy}","received_events_url":"https://api.github.com/users/dpfrey/received_events","type":"User","site_admin":false},"repo":{"id":122382432,"name":"legato-af","full_name":"dpfrey/legato-af","owner":{"login":"dpfrey","id":742786,"avatar_url":"https://avatars0.githubusercontent.com/u/742786?v=4","gravatar_id":"","url":"https://api.github.com/users/dpfrey","html_url":"https://github.com/dpfrey","followers_url":"https://api.github.com/users/dpfrey/followers","following_url":"https://api.github.com/users/dpfrey/following{/other_user}","gists_url":"https://api.github.com/users/dpfrey/gists{/gist_id}","starred_url":"https://api.github.com/users/dpfrey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dpfrey/subscriptions","organizations_url":"https://api.github.com/users/dpfrey/orgs","repos_url":"https://api.github.com/users/dpfrey/repos","events_url":"https://api.github.com/users/dpfrey/events{/privacy}","received_events_url":"https://api.github.com/users/dpfrey/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dpfrey/legato-af","description":"Legato Application Framework","fork":true,"url":"https://api.github.com/repos/dpfrey/legato-af","forks_url":"https://api.github.com/repos/dpfrey/legato-af/forks","keys_url":"https://api.github.com/repos/dpfrey/legato-af/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dpfrey/legato-af/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dpfrey/legato-af/teams","hooks_url":"https://api.github.com/repos/dpfrey/legato-af/hooks","issue_events_url":"https://api.github.com/repos/dpfrey/legato-af/issues/events{/number}","events_url":"https://api.github.com/repos/dpfrey/legato-af/events","assignees_url":"https://api.github.com/repos/dpfrey/legato-af/assignees{/user}","branches_url":"https://api.github.com/repos/dpfrey/legato-af/branches{/branch}","tags_url":"https://api.github.com/repos/dpfrey/legato-af/tags","blobs_url":"https://api.github.com/repos/dpfrey/legato-af/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dpfrey/legato-af/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dpfrey/legato-af/git/refs{/sha}","trees_url":"https://api.github.com/repos/dpfrey/legato-af/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dpfrey/legato-af/statuses/{sha}","languages_url":"https://api.github.com/repos/dpfrey/legato-af/languages","stargazers_url":"https://api.github.com/repos/dpfrey/legato-af/stargazers","contributors_url":"https://api.github.com/repos/dpfrey/legato-af/contributors","subscribers_url":"https://api.github.com/repos/dpfrey/legato-af/subscribers","subscription_url":"https://api.github.com/repos/dpfrey/legato-af/subscription","commits_url":"https://api.github.com/repos/dpfrey/legato-af/commits{/sha}","git_commits_url":"https://api.github.com/repos/dpfrey/legato-af/git/commits{/sha}","comments_url":"https://api.github.com/repos/dpfrey/legato-af/comments{/number}","issue_comment_url":"https://api.github.com/repos/dpfrey/legato-af/issues/comments{/number}","contents_url":"https://api.github.com/repos/dpfrey/legato-af/contents/{+path}","compare_url":"https://api.github.com/repos/dpfrey/legato-af/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dpfrey/legato-af/merges","archive_url":"https://api.github.com/repos/dpfrey/legato-af/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dpfrey/legato-af/downloads","issues_url":"https://api.github.com/repos/dpfrey/legato-af/issues{/number}","pulls_url":"https://api.github.com/repos/dpfrey/legato-af/pulls{/number}","milestones_url":"https://api.github.com/repos/dpfrey/legato-af/milestones{/number}","notifications_url":"https://api.github.com/repos/dpfrey/legato-af/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dpfrey/legato-af/labels{/name}","releases_url":"https://api.github.com/repos/dpfrey/legato-af/releases{/id}","deployments_url":"https://api.github.com/repos/dpfrey/legato-af/deployments","created_at":"2018-02-21T19:24:41Z","updated_at":"2018-02-21T19:24:48Z","pushed_at":"2018-02-21T19:25:56Z","git_url":"git://github.com/dpfrey/legato-af.git","ssh_url":"[email protected]:dpfrey/legato-af.git","clone_url":"https://github.com/dpfrey/legato-af.git","svn_url":"https://github.com/dpfrey/legato-af","homepage":null,"size":31120,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"legatoproject:master","ref":"master","sha":"2ba58c3a9ce4f2a8ec354dd87d0abe3388a5ae61","user":{"login":"legatoproject","id":6480915,"avatar_url":"https://avatars0.githubusercontent.com/u/6480915?v=4","gravatar_id":"","url":"https://api.github.com/users/legatoproject","html_url":"https://github.com/legatoproject","followers_url":"https://api.github.com/users/legatoproject/followers","following_url":"https://api.github.com/users/legatoproject/following{/other_user}","gists_url":"https://api.github.com/users/legatoproject/gists{/gist_id}","starred_url":"https://api.github.com/users/legatoproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/legatoproject/subscriptions","organizations_url":"https://api.github.com/users/legatoproject/orgs","repos_url":"https://api.github.com/users/legatoproject/repos","events_url":"https://api.github.com/users/legatoproject/events{/privacy}","received_events_url":"https://api.github.com/users/legatoproject/received_events","type":"Organization","site_admin":false},"repo":{"id":17834260,"name":"legato-af","full_name":"legatoproject/legato-af","owner":{"login":"legatoproject","id":6480915,"avatar_url":"https://avatars0.githubusercontent.com/u/6480915?v=4","gravatar_id":"","url":"https://api.github.com/users/legatoproject","html_url":"https://github.com/legatoproject","followers_url":"https://api.github.com/users/legatoproject/followers","following_url":"https://api.github.com/users/legatoproject/following{/other_user}","gists_url":"https://api.github.com/users/legatoproject/gists{/gist_id}","starred_url":"https://api.github.com/users/legatoproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/legatoproject/subscriptions","organizations_url":"https://api.github.com/users/legatoproject/orgs","repos_url":"https://api.github.com/users/legatoproject/repos","events_url":"https://api.github.com/users/legatoproject/events{/privacy}","received_events_url":"https://api.github.com/users/legatoproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/legatoproject/legato-af","description":"Legato Application Framework","fork":false,"url":"https://api.github.com/repos/legatoproject/legato-af","forks_url":"https://api.github.com/repos/legatoproject/legato-af/forks","keys_url":"https://api.github.com/repos/legatoproject/legato-af/keys{/key_id}","collaborators_url":"https://api.github.com/repos/legatoproject/legato-af/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/legatoproject/legato-af/teams","hooks_url":"https://api.github.com/repos/legatoproject/legato-af/hooks","issue_events_url":"https://api.github.com/repos/legatoproject/legato-af/issues/events{/number}","events_url":"https://api.github.com/repos/legatoproject/legato-af/events","assignees_url":"https://api.github.com/repos/legatoproject/legato-af/assignees{/user}","branches_url":"https://api.github.com/repos/legatoproject/legato-af/branches{/branch}","tags_url":"https://api.github.com/repos/legatoproject/legato-af/tags","blobs_url":"https://api.github.com/repos/legatoproject/legato-af/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/legatoproject/legato-af/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/legatoproject/legato-af/git/refs{/sha}","trees_url":"https://api.github.com/repos/legatoproject/legato-af/git/trees{/sha}","statuses_url":"https://api.github.com/repos/legatoproject/legato-af/statuses/{sha}","languages_url":"https://api.github.com/repos/legatoproject/legato-af/languages","stargazers_url":"https://api.github.com/repos/legatoproject/legato-af/stargazers","contributors_url":"https://api.github.com/repos/legatoproject/legato-af/contributors","subscribers_url":"https://api.github.com/repos/legatoproject/legato-af/subscribers","subscription_url":"https://api.github.com/repos/legatoproject/legato-af/subscription","commits_url":"https://api.github.com/repos/legatoproject/legato-af/commits{/sha}","git_commits_url":"https://api.github.com/repos/legatoproject/legato-af/git/commits{/sha}","comments_url":"https://api.github.com/repos/legatoproject/legato-af/comments{/number}","issue_comment_url":"https://api.github.com/repos/legatoproject/legato-af/issues/comments{/number}","contents_url":"https://api.github.com/repos/legatoproject/legato-af/contents/{+path}","compare_url":"https://api.github.com/repos/legatoproject/legato-af/compare/{base}...{head}","merges_url":"https://api.github.com/repos/legatoproject/legato-af/merges","archive_url":"https://api.github.com/repos/legatoproject/legato-af/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/legatoproject/legato-af/downloads","issues_url":"https://api.github.com/repos/legatoproject/legato-af/issues{/number}","pulls_url":"https://api.github.com/repos/legatoproject/legato-af/pulls{/number}","milestones_url":"https://api.github.com/repos/legatoproject/legato-af/milestones{/number}","notifications_url":"https://api.github.com/repos/legatoproject/legato-af/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/legatoproject/legato-af/labels{/name}","releases_url":"https://api.github.com/repos/legatoproject/legato-af/releases{/id}","deployments_url":"https://api.github.com/repos/legatoproject/legato-af/deployments","created_at":"2014-03-17T16:06:49Z","updated_at":"2018-02-02T05:51:50Z","pushed_at":"2018-02-21T23:42:38Z","git_url":"git://github.com/legatoproject/legato-af.git","ssh_url":"[email protected]:legatoproject/legato-af.git","clone_url":"https://github.com/legatoproject/legato-af.git","svn_url":"https://github.com/legatoproject/legato-af","homepage":null,"size":31120,"stargazers_count":62,"watchers_count":62,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":48,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0"},"forks":48,"open_issues":10,"watchers":62,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/legatoproject/legato-af/pulls/24"},"html":{"href":"https://github.com/legatoproject/legato-af/pull/24"},"issue":{"href":"https://api.github.com/repos/legatoproject/legato-af/issues/24"},"comments":{"href":"https://api.github.com/repos/legatoproject/legato-af/issues/24/comments"},"review_comments":{"href":"https://api.github.com/repos/legatoproject/legato-af/pulls/24/comments"},"review_comment":{"href":"https://api.github.com/repos/legatoproject/legato-af/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/legatoproject/legato-af/pulls/24/commits"},"statuses":{"href":"https://api.github.com/repos/legatoproject/legato-af/statuses/cc33db5a8e24cdafb8b9c9bc3a42a27f33bcca90"}},"author_association":"CONTRIBUTOR"}} | {
"id": 17834260,
"name": "legatoproject/legato-af",
"url": "https://api.github.com/repos/legatoproject/legato-af"
} | {
"id": 742786,
"login": "dpfrey",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/742786?",
"url": "https://api.github.com/users/dpfrey"
} | {
"id": 6480915,
"login": "legatoproject",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6480915?",
"url": "https://api.github.com/orgs/legatoproject"
} | 2018-02-22T00:13:32 | 7278713674 | {"actor":{"display_login":"dpfrey"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/systers/vms/pulls/comments/202507192","pull_request_review_id":137230011,"id":202507192,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMjUwNzE5Mg==","diff_hunk":"@@ -470,17 +512,13 @@ def test_field_value_retention(self):\n page.fill_registration_form(entry)\n \n # verify that user wasn't registered and that field values are not erased\n- self.assertEqual(self.driver.current_url,\n+ self.assertEqual(page.remove_i18n(self.driver.current_url),\n self.live_server_url + page.admin_registration_page)\n details = [\n 'admin-username', 'admin-first-name', 'admin-last-name-3',\n '[email protected]', 'admin-address$@!', 'admin-city#$',\n 'admin-state', 'admin-country 15', '99999.!9999', '@#admin-org'\n ]\n+ self.wait.until(EC.presence_of_element_located((By.ID, \"id_username\")))\n self.verify_field_values(details)\n-\n- # database check to verify that no user, administrator is created\n- self.assertEqual(len(User.objects.all()),0)\n- self.assertEqual(len(Administrator.objects.all()),0)\n-\"\"\"\n-\n+'''","path":"vms/registration/tests/test_functional_admin.py","position":578,"original_position":578,"commit_id":"12e7d2464e29f325665017e241332f91b8e614be","original_commit_id":"12e7d2464e29f325665017e241332f91b8e614be","user":{"login":"codacy-bot","id":19940114,"node_id":"MDQ6VXNlcjE5OTQwMTE0","avatar_url":"https://avatars1.githubusercontent.com/u/19940114?v=4","gravatar_id":"","url":"https://api.github.com/users/codacy-bot","html_url":"https://github.com/codacy-bot","followers_url":"https://api.github.com/users/codacy-bot/followers","following_url":"https://api.github.com/users/codacy-bot/following{/other_user}","gists_url":"https://api.github.com/users/codacy-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/codacy-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codacy-bot/subscriptions","organizations_url":"https://api.github.com/users/codacy-bot/orgs","repos_url":"https://api.github.com/users/codacy-bot/repos","events_url":"https://api.github.com/users/codacy-bot/events{/privacy}","received_events_url":"https://api.github.com/users/codacy-bot/received_events","type":"User","site_admin":false},"body":" Issue found: [String statement has no effect](https://app.codacy.com/app/Systers/vms/pullRequest?prid=1885585)","created_at":"2018-07-14T05:58:03Z","updated_at":"2018-07-14T05:58:03Z","html_url":"https://github.com/systers/vms/pull/790#discussion_r202507192","pull_request_url":"https://api.github.com/repos/systers/vms/pulls/790","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/systers/vms/pulls/comments/202507192"},"html":{"href":"https://github.com/systers/vms/pull/790#discussion_r202507192"},"pull_request":{"href":"https://api.github.com/repos/systers/vms/pulls/790"}}},"pull_request":{"url":"https://api.github.com/repos/systers/vms/pulls/790","id":200499056,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAwNDk5MDU2","html_url":"https://github.com/systers/vms/pull/790","diff_url":"https://github.com/systers/vms/pull/790.diff","patch_url":"https://github.com/systers/vms/pull/790.patch","issue_url":"https://api.github.com/repos/systers/vms/issues/790","number":790,"state":"open","locked":false,"title":"Upcoming shifts filtered out","user":{"login":"anjali-dhanuka","id":22369767,"node_id":"MDQ6VXNlcjIyMzY5NzY3","avatar_url":"https://avatars3.githubusercontent.com/u/22369767?v=4","gravatar_id":"","url":"https://api.github.com/users/anjali-dhanuka","html_url":"https://github.com/anjali-dhanuka","followers_url":"https://api.github.com/users/anjali-dhanuka/followers","following_url":"https://api.github.com/users/anjali-dhanuka/following{/other_user}","gists_url":"https://api.github.com/users/anjali-dhanuka/gists{/gist_id}","starred_url":"https://api.github.com/users/anjali-dhanuka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anjali-dhanuka/subscriptions","organizations_url":"https://api.github.com/users/anjali-dhanuka/orgs","repos_url":"https://api.github.com/users/anjali-dhanuka/repos","events_url":"https://api.github.com/users/anjali-dhanuka/events{/privacy}","received_events_url":"https://api.github.com/users/anjali-dhanuka/received_events","type":"User","site_admin":false},"body":"# Description\r\nThe upcoming shifts page only shows the present or going shifts.\r\n\r\nFixes #759 \r\n\r\n# Type of Change:\r\n- Code\r\n\r\n**Code/Quality Assurance Only**\r\n- Bug fix (non-breaking change which fixes an issue)\r\n\r\n# How Has This Been Tested?\r\n\r\n\r\n\r\n# Checklist:\r\n- [x] My PR follows the style guidelines of this project\r\n- [x] I have performed a self-review of my own code or materials\r\n- [x] I have commented my code or provided relevant documentation, particularly in hard-to-understand areas\r\n- [x] I have made corresponding changes to the documentation\r\n- [x] Any dependent changes have been merged \r\n\r\n**Code/Quality Assurance Only**\r\n- [x] My changes generate no new warnings \r\n- [x] I have added tests that prove my fix is effective or that my feature works\r\n- [x] New and existing unit tests pass locally with my changes\r\n- [x] Any dependent changes have been published in downstream modules\r\n","created_at":"2018-07-10T19:24:38Z","updated_at":"2018-07-14T05:58:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"27a38bbeae0ea47f50d657728afbab71266ffc85","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/systers/vms/pulls/790/commits","review_comments_url":"https://api.github.com/repos/systers/vms/pulls/790/comments","review_comment_url":"https://api.github.com/repos/systers/vms/pulls/comments{/number}","comments_url":"https://api.github.com/repos/systers/vms/issues/790/comments","statuses_url":"https://api.github.com/repos/systers/vms/statuses/12e7d2464e29f325665017e241332f91b8e614be","head":{"label":"anjali-dhanuka:upcoming_shifts","ref":"upcoming_shifts","sha":"12e7d2464e29f325665017e241332f91b8e614be","user":{"login":"anjali-dhanuka","id":22369767,"node_id":"MDQ6VXNlcjIyMzY5NzY3","avatar_url":"https://avatars3.githubusercontent.com/u/22369767?v=4","gravatar_id":"","url":"https://api.github.com/users/anjali-dhanuka","html_url":"https://github.com/anjali-dhanuka","followers_url":"https://api.github.com/users/anjali-dhanuka/followers","following_url":"https://api.github.com/users/anjali-dhanuka/following{/other_user}","gists_url":"https://api.github.com/users/anjali-dhanuka/gists{/gist_id}","starred_url":"https://api.github.com/users/anjali-dhanuka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anjali-dhanuka/subscriptions","organizations_url":"https://api.github.com/users/anjali-dhanuka/orgs","repos_url":"https://api.github.com/users/anjali-dhanuka/repos","events_url":"https://api.github.com/users/anjali-dhanuka/events{/privacy}","received_events_url":"https://api.github.com/users/anjali-dhanuka/received_events","type":"User","site_admin":false},"repo":{"id":113863490,"node_id":"MDEwOlJlcG9zaXRvcnkxMTM4NjM0OTA=","name":"vms","full_name":"anjali-dhanuka/vms","owner":{"login":"anjali-dhanuka","id":22369767,"node_id":"MDQ6VXNlcjIyMzY5NzY3","avatar_url":"https://avatars3.githubusercontent.com/u/22369767?v=4","gravatar_id":"","url":"https://api.github.com/users/anjali-dhanuka","html_url":"https://github.com/anjali-dhanuka","followers_url":"https://api.github.com/users/anjali-dhanuka/followers","following_url":"https://api.github.com/users/anjali-dhanuka/following{/other_user}","gists_url":"https://api.github.com/users/anjali-dhanuka/gists{/gist_id}","starred_url":"https://api.github.com/users/anjali-dhanuka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anjali-dhanuka/subscriptions","organizations_url":"https://api.github.com/users/anjali-dhanuka/orgs","repos_url":"https://api.github.com/users/anjali-dhanuka/repos","events_url":"https://api.github.com/users/anjali-dhanuka/events{/privacy}","received_events_url":"https://api.github.com/users/anjali-dhanuka/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/anjali-dhanuka/vms","description":"Volunteer Management System","fork":true,"url":"https://api.github.com/repos/anjali-dhanuka/vms","forks_url":"https://api.github.com/repos/anjali-dhanuka/vms/forks","keys_url":"https://api.github.com/repos/anjali-dhanuka/vms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/anjali-dhanuka/vms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/anjali-dhanuka/vms/teams","hooks_url":"https://api.github.com/repos/anjali-dhanuka/vms/hooks","issue_events_url":"https://api.github.com/repos/anjali-dhanuka/vms/issues/events{/number}","events_url":"https://api.github.com/repos/anjali-dhanuka/vms/events","assignees_url":"https://api.github.com/repos/anjali-dhanuka/vms/assignees{/user}","branches_url":"https://api.github.com/repos/anjali-dhanuka/vms/branches{/branch}","tags_url":"https://api.github.com/repos/anjali-dhanuka/vms/tags","blobs_url":"https://api.github.com/repos/anjali-dhanuka/vms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/anjali-dhanuka/vms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/anjali-dhanuka/vms/git/refs{/sha}","trees_url":"https://api.github.com/repos/anjali-dhanuka/vms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/anjali-dhanuka/vms/statuses/{sha}","languages_url":"https://api.github.com/repos/anjali-dhanuka/vms/languages","stargazers_url":"https://api.github.com/repos/anjali-dhanuka/vms/stargazers","contributors_url":"https://api.github.com/repos/anjali-dhanuka/vms/contributors","subscribers_url":"https://api.github.com/repos/anjali-dhanuka/vms/subscribers","subscription_url":"https://api.github.com/repos/anjali-dhanuka/vms/subscription","commits_url":"https://api.github.com/repos/anjali-dhanuka/vms/commits{/sha}","git_commits_url":"https://api.github.com/repos/anjali-dhanuka/vms/git/commits{/sha}","comments_url":"https://api.github.com/repos/anjali-dhanuka/vms/comments{/number}","issue_comment_url":"https://api.github.com/repos/anjali-dhanuka/vms/issues/comments{/number}","contents_url":"https://api.github.com/repos/anjali-dhanuka/vms/contents/{+path}","compare_url":"https://api.github.com/repos/anjali-dhanuka/vms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/anjali-dhanuka/vms/merges","archive_url":"https://api.github.com/repos/anjali-dhanuka/vms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/anjali-dhanuka/vms/downloads","issues_url":"https://api.github.com/repos/anjali-dhanuka/vms/issues{/number}","pulls_url":"https://api.github.com/repos/anjali-dhanuka/vms/pulls{/number}","milestones_url":"https://api.github.com/repos/anjali-dhanuka/vms/milestones{/number}","notifications_url":"https://api.github.com/repos/anjali-dhanuka/vms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/anjali-dhanuka/vms/labels{/name}","releases_url":"https://api.github.com/repos/anjali-dhanuka/vms/releases{/id}","deployments_url":"https://api.github.com/repos/anjali-dhanuka/vms/deployments","created_at":"2017-12-11T13:39:21Z","updated_at":"2018-04-07T17:17:20Z","pushed_at":"2018-07-14T05:55:24Z","git_url":"git://github.com/anjali-dhanuka/vms.git","ssh_url":"[email protected]:anjali-dhanuka/vms.git","clone_url":"https://github.com/anjali-dhanuka/vms.git","svn_url":"https://github.com/anjali-dhanuka/vms","homepage":null,"size":3095,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"systers:gsoc18-code","ref":"gsoc18-code","sha":"1705854e2b284a39ea9e2bcef2d264892edac471","user":{"login":"systers","id":6520415,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY1MjA0MTU=","avatar_url":"https://avatars0.githubusercontent.com/u/6520415?v=4","gravatar_id":"","url":"https://api.github.com/users/systers","html_url":"https://github.com/systers","followers_url":"https://api.github.com/users/systers/followers","following_url":"https://api.github.com/users/systers/following{/other_user}","gists_url":"https://api.github.com/users/systers/gists{/gist_id}","starred_url":"https://api.github.com/users/systers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/systers/subscriptions","organizations_url":"https://api.github.com/users/systers/orgs","repos_url":"https://api.github.com/users/systers/repos","events_url":"https://api.github.com/users/systers/events{/privacy}","received_events_url":"https://api.github.com/users/systers/received_events","type":"Organization","site_admin":false},"repo":{"id":19032264,"node_id":"MDEwOlJlcG9zaXRvcnkxOTAzMjI2NA==","name":"vms","full_name":"systers/vms","owner":{"login":"systers","id":6520415,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY1MjA0MTU=","avatar_url":"https://avatars0.githubusercontent.com/u/6520415?v=4","gravatar_id":"","url":"https://api.github.com/users/systers","html_url":"https://github.com/systers","followers_url":"https://api.github.com/users/systers/followers","following_url":"https://api.github.com/users/systers/following{/other_user}","gists_url":"https://api.github.com/users/systers/gists{/gist_id}","starred_url":"https://api.github.com/users/systers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/systers/subscriptions","organizations_url":"https://api.github.com/users/systers/orgs","repos_url":"https://api.github.com/users/systers/repos","events_url":"https://api.github.com/users/systers/events{/privacy}","received_events_url":"https://api.github.com/users/systers/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/systers/vms","description":"Volunteer Management System","fork":false,"url":"https://api.github.com/repos/systers/vms","forks_url":"https://api.github.com/repos/systers/vms/forks","keys_url":"https://api.github.com/repos/systers/vms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/systers/vms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/systers/vms/teams","hooks_url":"https://api.github.com/repos/systers/vms/hooks","issue_events_url":"https://api.github.com/repos/systers/vms/issues/events{/number}","events_url":"https://api.github.com/repos/systers/vms/events","assignees_url":"https://api.github.com/repos/systers/vms/assignees{/user}","branches_url":"https://api.github.com/repos/systers/vms/branches{/branch}","tags_url":"https://api.github.com/repos/systers/vms/tags","blobs_url":"https://api.github.com/repos/systers/vms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/systers/vms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/systers/vms/git/refs{/sha}","trees_url":"https://api.github.com/repos/systers/vms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/systers/vms/statuses/{sha}","languages_url":"https://api.github.com/repos/systers/vms/languages","stargazers_url":"https://api.github.com/repos/systers/vms/stargazers","contributors_url":"https://api.github.com/repos/systers/vms/contributors","subscribers_url":"https://api.github.com/repos/systers/vms/subscribers","subscription_url":"https://api.github.com/repos/systers/vms/subscription","commits_url":"https://api.github.com/repos/systers/vms/commits{/sha}","git_commits_url":"https://api.github.com/repos/systers/vms/git/commits{/sha}","comments_url":"https://api.github.com/repos/systers/vms/comments{/number}","issue_comment_url":"https://api.github.com/repos/systers/vms/issues/comments{/number}","contents_url":"https://api.github.com/repos/systers/vms/contents/{+path}","compare_url":"https://api.github.com/repos/systers/vms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/systers/vms/merges","archive_url":"https://api.github.com/repos/systers/vms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/systers/vms/downloads","issues_url":"https://api.github.com/repos/systers/vms/issues{/number}","pulls_url":"https://api.github.com/repos/systers/vms/pulls{/number}","milestones_url":"https://api.github.com/repos/systers/vms/milestones{/number}","notifications_url":"https://api.github.com/repos/systers/vms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/systers/vms/labels{/name}","releases_url":"https://api.github.com/repos/systers/vms/releases{/id}","deployments_url":"https://api.github.com/repos/systers/vms/deployments","created_at":"2014-04-22T14:13:57Z","updated_at":"2018-07-10T09:34:44Z","pushed_at":"2018-07-14T05:55:26Z","git_url":"git://github.com/systers/vms.git","ssh_url":"[email protected]:systers/vms.git","clone_url":"https://github.com/systers/vms.git","svn_url":"https://github.com/systers/vms","homepage":"http://52.8.110.63/","size":2906,"stargazers_count":56,"watchers_count":56,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":149,"mirror_url":null,"archived":false,"open_issues_count":121,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":149,"open_issues":121,"watchers":56,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/systers/vms/pulls/790"},"html":{"href":"https://github.com/systers/vms/pull/790"},"issue":{"href":"https://api.github.com/repos/systers/vms/issues/790"},"comments":{"href":"https://api.github.com/repos/systers/vms/issues/790/comments"},"review_comments":{"href":"https://api.github.com/repos/systers/vms/pulls/790/comments"},"review_comment":{"href":"https://api.github.com/repos/systers/vms/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/systers/vms/pulls/790/commits"},"statuses":{"href":"https://api.github.com/repos/systers/vms/statuses/12e7d2464e29f325665017e241332f91b8e614be"}},"author_association":"COLLABORATOR"}} | {
"id": 19032264,
"name": "systers/vms",
"url": "https://api.github.com/repos/systers/vms"
} | {
"id": 19940114,
"login": "codacy-bot",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/19940114?",
"url": "https://api.github.com/users/codacy-bot"
} | {
"id": 6520415,
"login": "systers",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6520415?",
"url": "https://api.github.com/orgs/systers"
} | 2018-07-14T05:58:03 | 7965281741 | {"actor":{"display_login":"codacy-bot"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/systers/vms/pulls/comments/201634221","pull_request_review_id":136171869,"id":201634221,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMTYzNDIyMQ==","diff_hunk":"@@ -0,0 +1,132 @@\n+# third party\n+\n+# Django\n+from django.core.exceptions import ValidationError\n+from django.db.models import Q\n+from django.test.testcases import TestCase\n+\n+# local Django\n+from job.models import Job\n+from event.models import Event\n+from pom.pages.jobDetailsPage import JobDetailsPage\n+from shift.utils import create_job_with_details, create_event_with_details\n+\n+\n+class JobModelTests(TestCase):\n+\n+ def setUp(self):\n+ self.event = self.create_event()\n+\n+ def tearDown(self):\n+ pass\n+\n+ @staticmethod\n+ def create_event():\n+ event = ['event-name', '2050-05-24', '2050-05-28']\n+ created_event = create_event_with_details(event)\n+ return created_event\n+\n+ def create_job(self):\n+ job = ['job-name', '2050-05-25', '2050-05-26', 'job-description', self.event]\n+ created_job = create_job_with_details(job)\n+ return created_job\n+\n+ def test_valid_model_create(self):\n+ job = ['job-name', '2050-05-25', '2050-05-26', 'job-description', self.event]\n+ created_job = create_job_with_details(job)","path":"vms/job/tests/test_model.py","position":36,"original_position":36,"commit_id":"64f7f03dc378e2e63891541f5a61fac97a383f06","original_commit_id":"64f7f03dc378e2e63891541f5a61fac97a383f06","user":{"login":"codacy-bot","id":19940114,"node_id":"MDQ6VXNlcjE5OTQwMTE0","avatar_url":"https://avatars1.githubusercontent.com/u/19940114?v=4","gravatar_id":"","url":"https://api.github.com/users/codacy-bot","html_url":"https://github.com/codacy-bot","followers_url":"https://api.github.com/users/codacy-bot/followers","following_url":"https://api.github.com/users/codacy-bot/following{/other_user}","gists_url":"https://api.github.com/users/codacy-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/codacy-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codacy-bot/subscriptions","organizations_url":"https://api.github.com/users/codacy-bot/orgs","repos_url":"https://api.github.com/users/codacy-bot/repos","events_url":"https://api.github.com/users/codacy-bot/events{/privacy}","received_events_url":"https://api.github.com/users/codacy-bot/received_events","type":"User","site_admin":false},"body":" Issue found: [Unused variable 'created_job'](https://app.codacy.com/app/Systers/vms/pullRequest?prid=1810749)","created_at":"2018-07-11T10:05:10Z","updated_at":"2018-07-11T10:05:10Z","html_url":"https://github.com/systers/vms/pull/739#discussion_r201634221","pull_request_url":"https://api.github.com/repos/systers/vms/pulls/739","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/systers/vms/pulls/comments/201634221"},"html":{"href":"https://github.com/systers/vms/pull/739#discussion_r201634221"},"pull_request":{"href":"https://api.github.com/repos/systers/vms/pulls/739"}}},"pull_request":{"url":"https://api.github.com/repos/systers/vms/pulls/739","id":196517567,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk2NTE3NTY3","html_url":"https://github.com/systers/vms/pull/739","diff_url":"https://github.com/systers/vms/pull/739.diff","patch_url":"https://github.com/systers/vms/pull/739.patch","issue_url":"https://api.github.com/repos/systers/vms/issues/739","number":739,"state":"open","locked":false,"title":"Reporting Functionality added","user":{"login":"anjali-dhanuka","id":22369767,"node_id":"MDQ6VXNlcjIyMzY5NzY3","avatar_url":"https://avatars3.githubusercontent.com/u/22369767?v=4","gravatar_id":"","url":"https://api.github.com/users/anjali-dhanuka","html_url":"https://github.com/anjali-dhanuka","followers_url":"https://api.github.com/users/anjali-dhanuka/followers","following_url":"https://api.github.com/users/anjali-dhanuka/following{/other_user}","gists_url":"https://api.github.com/users/anjali-dhanuka/gists{/gist_id}","starred_url":"https://api.github.com/users/anjali-dhanuka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anjali-dhanuka/subscriptions","organizations_url":"https://api.github.com/users/anjali-dhanuka/orgs","repos_url":"https://api.github.com/users/anjali-dhanuka/repos","events_url":"https://api.github.com/users/anjali-dhanuka/events{/privacy}","received_events_url":"https://api.github.com/users/anjali-dhanuka/received_events","type":"User","site_admin":false},"body":"# Description\r\nThe volunteers can create their reports, administrators can confirm them and also they can view the past reports of the volunteers\r\n\r\nFixes #658 \r\n\r\n# Type of Change: \r\n- Code\r\n\r\n**Code/Quality Assurance Only**\r\n- New feature (non-breaking change which adds functionality pre-approved by mentors)\r\n\r\n# How Has This Been Tested?\r\nVolunteer side(volunteer can generate his report):\r\n\r\n\r\nif the report has already been generated:\r\n\r\n\r\nUnconfirmed reports(admin can confirm them):\r\n\r\n\r\n\r\nPast reports volunteerwise:\r\n\r\n\r\n\r\n\r\n# Checklist:\r\n- [x] My PR follows the style guidelines of this project\r\n- [x] I have performed a self-review of my own code or materials\r\n- [x] I have commented my code or provided relevant documentation, particularly in hard-to-understand areas\r\n- [x] I have made corresponding changes to the documentation\r\n- [x] Any dependent changes have been merged \r\n\r\n**Code/Quality Assurance Only**\r\n- [x] My changes generate no new warnings \r\n- [x] New and existing unit tests pass locally with my changes\r\n- [x] Any dependent changes have been published in downstream modules\r\n","created_at":"2018-06-21T17:03:53Z","updated_at":"2018-07-11T10:05:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0ba4fe550e0388bf02f12cca5f1bc2742394c718","assignee":{"login":"anjali-dhanuka","id":22369767,"node_id":"MDQ6VXNlcjIyMzY5NzY3","avatar_url":"https://avatars3.githubusercontent.com/u/22369767?v=4","gravatar_id":"","url":"https://api.github.com/users/anjali-dhanuka","html_url":"https://github.com/anjali-dhanuka","followers_url":"https://api.github.com/users/anjali-dhanuka/followers","following_url":"https://api.github.com/users/anjali-dhanuka/following{/other_user}","gists_url":"https://api.github.com/users/anjali-dhanuka/gists{/gist_id}","starred_url":"https://api.github.com/users/anjali-dhanuka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anjali-dhanuka/subscriptions","organizations_url":"https://api.github.com/users/anjali-dhanuka/orgs","repos_url":"https://api.github.com/users/anjali-dhanuka/repos","events_url":"https://api.github.com/users/anjali-dhanuka/events{/privacy}","received_events_url":"https://api.github.com/users/anjali-dhanuka/received_events","type":"User","site_admin":false},"assignees":[{"login":"anjali-dhanuka","id":22369767,"node_id":"MDQ6VXNlcjIyMzY5NzY3","avatar_url":"https://avatars3.githubusercontent.com/u/22369767?v=4","gravatar_id":"","url":"https://api.github.com/users/anjali-dhanuka","html_url":"https://github.com/anjali-dhanuka","followers_url":"https://api.github.com/users/anjali-dhanuka/followers","following_url":"https://api.github.com/users/anjali-dhanuka/following{/other_user}","gists_url":"https://api.github.com/users/anjali-dhanuka/gists{/gist_id}","starred_url":"https://api.github.com/users/anjali-dhanuka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anjali-dhanuka/subscriptions","organizations_url":"https://api.github.com/users/anjali-dhanuka/orgs","repos_url":"https://api.github.com/users/anjali-dhanuka/repos","events_url":"https://api.github.com/users/anjali-dhanuka/events{/privacy}","received_events_url":"https://api.github.com/users/anjali-dhanuka/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":779157433,"node_id":"MDU6TGFiZWw3NzkxNTc0MzM=","url":"https://api.github.com/repos/systers/vms/labels/Category:%20Coding","name":"Category: Coding","color":"005c88","default":false},{"id":779159474,"node_id":"MDU6TGFiZWw3NzkxNTk0NzQ=","url":"https://api.github.com/repos/systers/vms/labels/Program:%20GSoC","name":"Program: GSoC","color":"fac07e","default":false},{"id":94268591,"node_id":"MDU6TGFiZWw5NDI2ODU5MQ==","url":"https://api.github.com/repos/systers/vms/labels/Type:%20Enhancement","name":"Type: Enhancement","color":"f6b2cf","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/systers/vms/pulls/739/commits","review_comments_url":"https://api.github.com/repos/systers/vms/pulls/739/comments","review_comment_url":"https://api.github.com/repos/systers/vms/pulls/comments{/number}","comments_url":"https://api.github.com/repos/systers/vms/issues/739/comments","statuses_url":"https://api.github.com/repos/systers/vms/statuses/64f7f03dc378e2e63891541f5a61fac97a383f06","head":{"label":"anjali-dhanuka:reports","ref":"reports","sha":"64f7f03dc378e2e63891541f5a61fac97a383f06","user":{"login":"anjali-dhanuka","id":22369767,"node_id":"MDQ6VXNlcjIyMzY5NzY3","avatar_url":"https://avatars3.githubusercontent.com/u/22369767?v=4","gravatar_id":"","url":"https://api.github.com/users/anjali-dhanuka","html_url":"https://github.com/anjali-dhanuka","followers_url":"https://api.github.com/users/anjali-dhanuka/followers","following_url":"https://api.github.com/users/anjali-dhanuka/following{/other_user}","gists_url":"https://api.github.com/users/anjali-dhanuka/gists{/gist_id}","starred_url":"https://api.github.com/users/anjali-dhanuka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anjali-dhanuka/subscriptions","organizations_url":"https://api.github.com/users/anjali-dhanuka/orgs","repos_url":"https://api.github.com/users/anjali-dhanuka/repos","events_url":"https://api.github.com/users/anjali-dhanuka/events{/privacy}","received_events_url":"https://api.github.com/users/anjali-dhanuka/received_events","type":"User","site_admin":false},"repo":{"id":113863490,"node_id":"MDEwOlJlcG9zaXRvcnkxMTM4NjM0OTA=","name":"vms","full_name":"anjali-dhanuka/vms","owner":{"login":"anjali-dhanuka","id":22369767,"node_id":"MDQ6VXNlcjIyMzY5NzY3","avatar_url":"https://avatars3.githubusercontent.com/u/22369767?v=4","gravatar_id":"","url":"https://api.github.com/users/anjali-dhanuka","html_url":"https://github.com/anjali-dhanuka","followers_url":"https://api.github.com/users/anjali-dhanuka/followers","following_url":"https://api.github.com/users/anjali-dhanuka/following{/other_user}","gists_url":"https://api.github.com/users/anjali-dhanuka/gists{/gist_id}","starred_url":"https://api.github.com/users/anjali-dhanuka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anjali-dhanuka/subscriptions","organizations_url":"https://api.github.com/users/anjali-dhanuka/orgs","repos_url":"https://api.github.com/users/anjali-dhanuka/repos","events_url":"https://api.github.com/users/anjali-dhanuka/events{/privacy}","received_events_url":"https://api.github.com/users/anjali-dhanuka/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/anjali-dhanuka/vms","description":"Volunteer Management System","fork":true,"url":"https://api.github.com/repos/anjali-dhanuka/vms","forks_url":"https://api.github.com/repos/anjali-dhanuka/vms/forks","keys_url":"https://api.github.com/repos/anjali-dhanuka/vms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/anjali-dhanuka/vms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/anjali-dhanuka/vms/teams","hooks_url":"https://api.github.com/repos/anjali-dhanuka/vms/hooks","issue_events_url":"https://api.github.com/repos/anjali-dhanuka/vms/issues/events{/number}","events_url":"https://api.github.com/repos/anjali-dhanuka/vms/events","assignees_url":"https://api.github.com/repos/anjali-dhanuka/vms/assignees{/user}","branches_url":"https://api.github.com/repos/anjali-dhanuka/vms/branches{/branch}","tags_url":"https://api.github.com/repos/anjali-dhanuka/vms/tags","blobs_url":"https://api.github.com/repos/anjali-dhanuka/vms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/anjali-dhanuka/vms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/anjali-dhanuka/vms/git/refs{/sha}","trees_url":"https://api.github.com/repos/anjali-dhanuka/vms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/anjali-dhanuka/vms/statuses/{sha}","languages_url":"https://api.github.com/repos/anjali-dhanuka/vms/languages","stargazers_url":"https://api.github.com/repos/anjali-dhanuka/vms/stargazers","contributors_url":"https://api.github.com/repos/anjali-dhanuka/vms/contributors","subscribers_url":"https://api.github.com/repos/anjali-dhanuka/vms/subscribers","subscription_url":"https://api.github.com/repos/anjali-dhanuka/vms/subscription","commits_url":"https://api.github.com/repos/anjali-dhanuka/vms/commits{/sha}","git_commits_url":"https://api.github.com/repos/anjali-dhanuka/vms/git/commits{/sha}","comments_url":"https://api.github.com/repos/anjali-dhanuka/vms/comments{/number}","issue_comment_url":"https://api.github.com/repos/anjali-dhanuka/vms/issues/comments{/number}","contents_url":"https://api.github.com/repos/anjali-dhanuka/vms/contents/{+path}","compare_url":"https://api.github.com/repos/anjali-dhanuka/vms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/anjali-dhanuka/vms/merges","archive_url":"https://api.github.com/repos/anjali-dhanuka/vms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/anjali-dhanuka/vms/downloads","issues_url":"https://api.github.com/repos/anjali-dhanuka/vms/issues{/number}","pulls_url":"https://api.github.com/repos/anjali-dhanuka/vms/pulls{/number}","milestones_url":"https://api.github.com/repos/anjali-dhanuka/vms/milestones{/number}","notifications_url":"https://api.github.com/repos/anjali-dhanuka/vms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/anjali-dhanuka/vms/labels{/name}","releases_url":"https://api.github.com/repos/anjali-dhanuka/vms/releases{/id}","deployments_url":"https://api.github.com/repos/anjali-dhanuka/vms/deployments","created_at":"2017-12-11T13:39:21Z","updated_at":"2018-04-07T17:17:20Z","pushed_at":"2018-07-11T10:02:12Z","git_url":"git://github.com/anjali-dhanuka/vms.git","ssh_url":"[email protected]:anjali-dhanuka/vms.git","clone_url":"https://github.com/anjali-dhanuka/vms.git","svn_url":"https://github.com/anjali-dhanuka/vms","homepage":null,"size":3130,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"systers:gsoc18-code","ref":"gsoc18-code","sha":"1705854e2b284a39ea9e2bcef2d264892edac471","user":{"login":"systers","id":6520415,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY1MjA0MTU=","avatar_url":"https://avatars0.githubusercontent.com/u/6520415?v=4","gravatar_id":"","url":"https://api.github.com/users/systers","html_url":"https://github.com/systers","followers_url":"https://api.github.com/users/systers/followers","following_url":"https://api.github.com/users/systers/following{/other_user}","gists_url":"https://api.github.com/users/systers/gists{/gist_id}","starred_url":"https://api.github.com/users/systers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/systers/subscriptions","organizations_url":"https://api.github.com/users/systers/orgs","repos_url":"https://api.github.com/users/systers/repos","events_url":"https://api.github.com/users/systers/events{/privacy}","received_events_url":"https://api.github.com/users/systers/received_events","type":"Organization","site_admin":false},"repo":{"id":19032264,"node_id":"MDEwOlJlcG9zaXRvcnkxOTAzMjI2NA==","name":"vms","full_name":"systers/vms","owner":{"login":"systers","id":6520415,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY1MjA0MTU=","avatar_url":"https://avatars0.githubusercontent.com/u/6520415?v=4","gravatar_id":"","url":"https://api.github.com/users/systers","html_url":"https://github.com/systers","followers_url":"https://api.github.com/users/systers/followers","following_url":"https://api.github.com/users/systers/following{/other_user}","gists_url":"https://api.github.com/users/systers/gists{/gist_id}","starred_url":"https://api.github.com/users/systers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/systers/subscriptions","organizations_url":"https://api.github.com/users/systers/orgs","repos_url":"https://api.github.com/users/systers/repos","events_url":"https://api.github.com/users/systers/events{/privacy}","received_events_url":"https://api.github.com/users/systers/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/systers/vms","description":"Volunteer Management System","fork":false,"url":"https://api.github.com/repos/systers/vms","forks_url":"https://api.github.com/repos/systers/vms/forks","keys_url":"https://api.github.com/repos/systers/vms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/systers/vms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/systers/vms/teams","hooks_url":"https://api.github.com/repos/systers/vms/hooks","issue_events_url":"https://api.github.com/repos/systers/vms/issues/events{/number}","events_url":"https://api.github.com/repos/systers/vms/events","assignees_url":"https://api.github.com/repos/systers/vms/assignees{/user}","branches_url":"https://api.github.com/repos/systers/vms/branches{/branch}","tags_url":"https://api.github.com/repos/systers/vms/tags","blobs_url":"https://api.github.com/repos/systers/vms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/systers/vms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/systers/vms/git/refs{/sha}","trees_url":"https://api.github.com/repos/systers/vms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/systers/vms/statuses/{sha}","languages_url":"https://api.github.com/repos/systers/vms/languages","stargazers_url":"https://api.github.com/repos/systers/vms/stargazers","contributors_url":"https://api.github.com/repos/systers/vms/contributors","subscribers_url":"https://api.github.com/repos/systers/vms/subscribers","subscription_url":"https://api.github.com/repos/systers/vms/subscription","commits_url":"https://api.github.com/repos/systers/vms/commits{/sha}","git_commits_url":"https://api.github.com/repos/systers/vms/git/commits{/sha}","comments_url":"https://api.github.com/repos/systers/vms/comments{/number}","issue_comment_url":"https://api.github.com/repos/systers/vms/issues/comments{/number}","contents_url":"https://api.github.com/repos/systers/vms/contents/{+path}","compare_url":"https://api.github.com/repos/systers/vms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/systers/vms/merges","archive_url":"https://api.github.com/repos/systers/vms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/systers/vms/downloads","issues_url":"https://api.github.com/repos/systers/vms/issues{/number}","pulls_url":"https://api.github.com/repos/systers/vms/pulls{/number}","milestones_url":"https://api.github.com/repos/systers/vms/milestones{/number}","notifications_url":"https://api.github.com/repos/systers/vms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/systers/vms/labels{/name}","releases_url":"https://api.github.com/repos/systers/vms/releases{/id}","deployments_url":"https://api.github.com/repos/systers/vms/deployments","created_at":"2014-04-22T14:13:57Z","updated_at":"2018-07-10T09:34:44Z","pushed_at":"2018-07-11T10:02:14Z","git_url":"git://github.com/systers/vms.git","ssh_url":"[email protected]:systers/vms.git","clone_url":"https://github.com/systers/vms.git","svn_url":"https://github.com/systers/vms","homepage":"http://52.8.110.63/","size":2905,"stargazers_count":56,"watchers_count":56,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":150,"mirror_url":null,"archived":false,"open_issues_count":115,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":150,"open_issues":115,"watchers":56,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/systers/vms/pulls/739"},"html":{"href":"https://github.com/systers/vms/pull/739"},"issue":{"href":"https://api.github.com/repos/systers/vms/issues/739"},"comments":{"href":"https://api.github.com/repos/systers/vms/issues/739/comments"},"review_comments":{"href":"https://api.github.com/repos/systers/vms/pulls/739/comments"},"review_comment":{"href":"https://api.github.com/repos/systers/vms/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/systers/vms/pulls/739/commits"},"statuses":{"href":"https://api.github.com/repos/systers/vms/statuses/64f7f03dc378e2e63891541f5a61fac97a383f06"}},"author_association":"COLLABORATOR"}} | {
"id": 19032264,
"name": "systers/vms",
"url": "https://api.github.com/repos/systers/vms"
} | {
"id": 19940114,
"login": "codacy-bot",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/19940114?",
"url": "https://api.github.com/users/codacy-bot"
} | {
"id": 6520415,
"login": "systers",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6520415?",
"url": "https://api.github.com/orgs/systers"
} | 2018-07-11T10:05:10 | 7949060534 | {"actor":{"display_login":"codacy-bot"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/systers/systers.github.io/pulls/comments/233894255","pull_request_review_id":175413778,"id":233894255,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMzg5NDI1NQ==","diff_hunk":"@@ -1,12 +1,29 @@\n <!doctype html>\n <html lang=\"en\">\n <head>\n- <meta charset=\"utf-8\">\n+ <meta charset=\"UTF-8\" />\n <title>Systers Open Source</title>\n <base href=\"/\">\n-\n- <meta name=\"viewport\" content=\"width=device-width, initial-scale=1\">\n <link rel=\"icon\" type=\"image/x-icon\" href=\"favicon.ico\">\n+ <meta charset=\"UTF-8\" />\n+ <meta content=\"IE=edge\" http-equiv=\"X-UA-Compatible\" />\n+ <meta name=\"keywords\" content=\"slack, slack-ghc, AnitaB.org, systers, code,","path":"src/index.html","position":13,"original_position":13,"commit_id":"aa7cfa5ad382c8fb7e556a254a28ed12f8a7f59b","original_commit_id":"aa7cfa5ad382c8fb7e556a254a28ed12f8a7f59b","user":{"login":"sarnava1","id":25319565,"node_id":"MDQ6VXNlcjI1MzE5NTY1","avatar_url":"https://avatars0.githubusercontent.com/u/25319565?v=4","gravatar_id":"","url":"https://api.github.com/users/sarnava1","html_url":"https://github.com/sarnava1","followers_url":"https://api.github.com/users/sarnava1/followers","following_url":"https://api.github.com/users/sarnava1/following{/other_user}","gists_url":"https://api.github.com/users/sarnava1/gists{/gist_id}","starred_url":"https://api.github.com/users/sarnava1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sarnava1/subscriptions","organizations_url":"https://api.github.com/users/sarnava1/orgs","repos_url":"https://api.github.com/users/sarnava1/repos","events_url":"https://api.github.com/users/sarnava1/events{/privacy}","received_events_url":"https://api.github.com/users/sarnava1/received_events","type":"User","site_admin":false},"body":"Yes if there any such guidelines please do let me know.","created_at":"2018-11-15T15:41:31Z","updated_at":"2018-11-15T15:41:31Z","html_url":"https://github.com/systers/systers.github.io/pull/320#discussion_r233894255","pull_request_url":"https://api.github.com/repos/systers/systers.github.io/pulls/320","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/systers/systers.github.io/pulls/comments/233894255"},"html":{"href":"https://github.com/systers/systers.github.io/pull/320#discussion_r233894255"},"pull_request":{"href":"https://api.github.com/repos/systers/systers.github.io/pulls/320"}},"in_reply_to_id":233845915},"pull_request":{"url":"https://api.github.com/repos/systers/systers.github.io/pulls/320","id":227771881,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3NzcxODgx","html_url":"https://github.com/systers/systers.github.io/pull/320","diff_url":"https://github.com/systers/systers.github.io/pull/320.diff","patch_url":"https://github.com/systers/systers.github.io/pull/320.patch","issue_url":"https://api.github.com/repos/systers/systers.github.io/issues/320","number":320,"state":"open","locked":false,"title":"fixes #124 (added meta tags for better SEO)","user":{"login":"sarnava1","id":25319565,"node_id":"MDQ6VXNlcjI1MzE5NTY1","avatar_url":"https://avatars0.githubusercontent.com/u/25319565?v=4","gravatar_id":"","url":"https://api.github.com/users/sarnava1","html_url":"https://github.com/sarnava1","followers_url":"https://api.github.com/users/sarnava1/followers","following_url":"https://api.github.com/users/sarnava1/following{/other_user}","gists_url":"https://api.github.com/users/sarnava1/gists{/gist_id}","starred_url":"https://api.github.com/users/sarnava1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sarnava1/subscriptions","organizations_url":"https://api.github.com/users/sarnava1/orgs","repos_url":"https://api.github.com/users/sarnava1/repos","events_url":"https://api.github.com/users/sarnava1/events{/privacy}","received_events_url":"https://api.github.com/users/sarnava1/received_events","type":"User","site_admin":false},"body":"### Description\r\nThis PR solves a long standing issue on meta tags. This PR not only adds meta keywords but also adds all other tags and ogp tags for better SEO.\r\nFixes #124 \r\n\r\n### Type of Change:\r\n**Delete irrelevant options.**\r\n\r\n- Code\r\n- Quality Assurance\r\n- Outreach\r\n- Documentation\r\n \r\n\r\n**Code/Quality Assurance Only**\r\n- Bug fix (non-breaking change which fixes an issue)\r\n\r\n\r\n\r\n### Checklist:\r\n\r\n**Delete irrelevant options.**\r\n\r\n- [x] My PR follows the style guidelines of this project\r\n- [x] I have performed a self-review of my own code or materials\r\n- [x] I have commented my code or provided relevant documentation, particularly in hard-to-understand areas\r\n- [x] I have made corresponding changes to the documentation\r\n- [x] Any dependent changes have been merged \r\n \r\n\r\n**Code/Quality Assurance Only**\r\n- [x] My changes generate no new warnings \r\n- [ ] My PR currently breaks something (fix or feature that would cause existing functionality to not work as expected)\r\n- [ ] I have added tests that prove my fix is effective or that my feature works\r\n- [ ] New and existing unit tests pass locally with my changes\r\n- [ ] Any dependent changes have been published in downstream modules\r\n\r\n","created_at":"2018-11-01T21:54:44Z","updated_at":"2018-11-15T15:41:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d643fe2900873f26e65008a6dd55418b4fd9b3ce","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/systers/systers.github.io/pulls/320/commits","review_comments_url":"https://api.github.com/repos/systers/systers.github.io/pulls/320/comments","review_comment_url":"https://api.github.com/repos/systers/systers.github.io/pulls/comments{/number}","comments_url":"https://api.github.com/repos/systers/systers.github.io/issues/320/comments","statuses_url":"https://api.github.com/repos/systers/systers.github.io/statuses/aa7cfa5ad382c8fb7e556a254a28ed12f8a7f59b","head":{"label":"sarnava1:develop","ref":"develop","sha":"aa7cfa5ad382c8fb7e556a254a28ed12f8a7f59b","user":{"login":"sarnava1","id":25319565,"node_id":"MDQ6VXNlcjI1MzE5NTY1","avatar_url":"https://avatars0.githubusercontent.com/u/25319565?v=4","gravatar_id":"","url":"https://api.github.com/users/sarnava1","html_url":"https://github.com/sarnava1","followers_url":"https://api.github.com/users/sarnava1/followers","following_url":"https://api.github.com/users/sarnava1/following{/other_user}","gists_url":"https://api.github.com/users/sarnava1/gists{/gist_id}","starred_url":"https://api.github.com/users/sarnava1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sarnava1/subscriptions","organizations_url":"https://api.github.com/users/sarnava1/orgs","repos_url":"https://api.github.com/users/sarnava1/repos","events_url":"https://api.github.com/users/sarnava1/events{/privacy}","received_events_url":"https://api.github.com/users/sarnava1/received_events","type":"User","site_admin":false},"repo":{"id":153361518,"node_id":"MDEwOlJlcG9zaXRvcnkxNTMzNjE1MTg=","name":"systers.github.io","full_name":"sarnava1/systers.github.io","private":false,"owner":{"login":"sarnava1","id":25319565,"node_id":"MDQ6VXNlcjI1MzE5NTY1","avatar_url":"https://avatars0.githubusercontent.com/u/25319565?v=4","gravatar_id":"","url":"https://api.github.com/users/sarnava1","html_url":"https://github.com/sarnava1","followers_url":"https://api.github.com/users/sarnava1/followers","following_url":"https://api.github.com/users/sarnava1/following{/other_user}","gists_url":"https://api.github.com/users/sarnava1/gists{/gist_id}","starred_url":"https://api.github.com/users/sarnava1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sarnava1/subscriptions","organizations_url":"https://api.github.com/users/sarnava1/orgs","repos_url":"https://api.github.com/users/sarnava1/repos","events_url":"https://api.github.com/users/sarnava1/events{/privacy}","received_events_url":"https://api.github.com/users/sarnava1/received_events","type":"User","site_admin":false},"html_url":"https://github.com/sarnava1/systers.github.io","description":"Main GitHub web page for Systers at http://www.systers.io","fork":true,"url":"https://api.github.com/repos/sarnava1/systers.github.io","forks_url":"https://api.github.com/repos/sarnava1/systers.github.io/forks","keys_url":"https://api.github.com/repos/sarnava1/systers.github.io/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sarnava1/systers.github.io/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sarnava1/systers.github.io/teams","hooks_url":"https://api.github.com/repos/sarnava1/systers.github.io/hooks","issue_events_url":"https://api.github.com/repos/sarnava1/systers.github.io/issues/events{/number}","events_url":"https://api.github.com/repos/sarnava1/systers.github.io/events","assignees_url":"https://api.github.com/repos/sarnava1/systers.github.io/assignees{/user}","branches_url":"https://api.github.com/repos/sarnava1/systers.github.io/branches{/branch}","tags_url":"https://api.github.com/repos/sarnava1/systers.github.io/tags","blobs_url":"https://api.github.com/repos/sarnava1/systers.github.io/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sarnava1/systers.github.io/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sarnava1/systers.github.io/git/refs{/sha}","trees_url":"https://api.github.com/repos/sarnava1/systers.github.io/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sarnava1/systers.github.io/statuses/{sha}","languages_url":"https://api.github.com/repos/sarnava1/systers.github.io/languages","stargazers_url":"https://api.github.com/repos/sarnava1/systers.github.io/stargazers","contributors_url":"https://api.github.com/repos/sarnava1/systers.github.io/contributors","subscribers_url":"https://api.github.com/repos/sarnava1/systers.github.io/subscribers","subscription_url":"https://api.github.com/repos/sarnava1/systers.github.io/subscription","commits_url":"https://api.github.com/repos/sarnava1/systers.github.io/commits{/sha}","git_commits_url":"https://api.github.com/repos/sarnava1/systers.github.io/git/commits{/sha}","comments_url":"https://api.github.com/repos/sarnava1/systers.github.io/comments{/number}","issue_comment_url":"https://api.github.com/repos/sarnava1/systers.github.io/issues/comments{/number}","contents_url":"https://api.github.com/repos/sarnava1/systers.github.io/contents/{+path}","compare_url":"https://api.github.com/repos/sarnava1/systers.github.io/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sarnava1/systers.github.io/merges","archive_url":"https://api.github.com/repos/sarnava1/systers.github.io/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sarnava1/systers.github.io/downloads","issues_url":"https://api.github.com/repos/sarnava1/systers.github.io/issues{/number}","pulls_url":"https://api.github.com/repos/sarnava1/systers.github.io/pulls{/number}","milestones_url":"https://api.github.com/repos/sarnava1/systers.github.io/milestones{/number}","notifications_url":"https://api.github.com/repos/sarnava1/systers.github.io/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sarnava1/systers.github.io/labels{/name}","releases_url":"https://api.github.com/repos/sarnava1/systers.github.io/releases{/id}","deployments_url":"https://api.github.com/repos/sarnava1/systers.github.io/deployments","created_at":"2018-10-16T22:17:39Z","updated_at":"2018-11-01T21:51:30Z","pushed_at":"2018-11-01T21:51:29Z","git_url":"git://github.com/sarnava1/systers.github.io.git","ssh_url":"[email protected]:sarnava1/systers.github.io.git","clone_url":"https://github.com/sarnava1/systers.github.io.git","svn_url":"https://github.com/sarnava1/systers.github.io","homepage":"","size":9612,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"systers:develop","ref":"develop","sha":"5fa20dd5598235ac1cb2ae2c54e4aca6c4963743","user":{"login":"systers","id":6520415,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY1MjA0MTU=","avatar_url":"https://avatars0.githubusercontent.com/u/6520415?v=4","gravatar_id":"","url":"https://api.github.com/users/systers","html_url":"https://github.com/systers","followers_url":"https://api.github.com/users/systers/followers","following_url":"https://api.github.com/users/systers/following{/other_user}","gists_url":"https://api.github.com/users/systers/gists{/gist_id}","starred_url":"https://api.github.com/users/systers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/systers/subscriptions","organizations_url":"https://api.github.com/users/systers/orgs","repos_url":"https://api.github.com/users/systers/repos","events_url":"https://api.github.com/users/systers/events{/privacy}","received_events_url":"https://api.github.com/users/systers/received_events","type":"Organization","site_admin":false},"repo":{"id":21989834,"node_id":"MDEwOlJlcG9zaXRvcnkyMTk4OTgzNA==","name":"systers.github.io","full_name":"systers/systers.github.io","private":false,"owner":{"login":"systers","id":6520415,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY1MjA0MTU=","avatar_url":"https://avatars0.githubusercontent.com/u/6520415?v=4","gravatar_id":"","url":"https://api.github.com/users/systers","html_url":"https://github.com/systers","followers_url":"https://api.github.com/users/systers/followers","following_url":"https://api.github.com/users/systers/following{/other_user}","gists_url":"https://api.github.com/users/systers/gists{/gist_id}","starred_url":"https://api.github.com/users/systers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/systers/subscriptions","organizations_url":"https://api.github.com/users/systers/orgs","repos_url":"https://api.github.com/users/systers/repos","events_url":"https://api.github.com/users/systers/events{/privacy}","received_events_url":"https://api.github.com/users/systers/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/systers/systers.github.io","description":"Main GitHub web page for Systers at http://www.systers.io","fork":false,"url":"https://api.github.com/repos/systers/systers.github.io","forks_url":"https://api.github.com/repos/systers/systers.github.io/forks","keys_url":"https://api.github.com/repos/systers/systers.github.io/keys{/key_id}","collaborators_url":"https://api.github.com/repos/systers/systers.github.io/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/systers/systers.github.io/teams","hooks_url":"https://api.github.com/repos/systers/systers.github.io/hooks","issue_events_url":"https://api.github.com/repos/systers/systers.github.io/issues/events{/number}","events_url":"https://api.github.com/repos/systers/systers.github.io/events","assignees_url":"https://api.github.com/repos/systers/systers.github.io/assignees{/user}","branches_url":"https://api.github.com/repos/systers/systers.github.io/branches{/branch}","tags_url":"https://api.github.com/repos/systers/systers.github.io/tags","blobs_url":"https://api.github.com/repos/systers/systers.github.io/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/systers/systers.github.io/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/systers/systers.github.io/git/refs{/sha}","trees_url":"https://api.github.com/repos/systers/systers.github.io/git/trees{/sha}","statuses_url":"https://api.github.com/repos/systers/systers.github.io/statuses/{sha}","languages_url":"https://api.github.com/repos/systers/systers.github.io/languages","stargazers_url":"https://api.github.com/repos/systers/systers.github.io/stargazers","contributors_url":"https://api.github.com/repos/systers/systers.github.io/contributors","subscribers_url":"https://api.github.com/repos/systers/systers.github.io/subscribers","subscription_url":"https://api.github.com/repos/systers/systers.github.io/subscription","commits_url":"https://api.github.com/repos/systers/systers.github.io/commits{/sha}","git_commits_url":"https://api.github.com/repos/systers/systers.github.io/git/commits{/sha}","comments_url":"https://api.github.com/repos/systers/systers.github.io/comments{/number}","issue_comment_url":"https://api.github.com/repos/systers/systers.github.io/issues/comments{/number}","contents_url":"https://api.github.com/repos/systers/systers.github.io/contents/{+path}","compare_url":"https://api.github.com/repos/systers/systers.github.io/compare/{base}...{head}","merges_url":"https://api.github.com/repos/systers/systers.github.io/merges","archive_url":"https://api.github.com/repos/systers/systers.github.io/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/systers/systers.github.io/downloads","issues_url":"https://api.github.com/repos/systers/systers.github.io/issues{/number}","pulls_url":"https://api.github.com/repos/systers/systers.github.io/pulls{/number}","milestones_url":"https://api.github.com/repos/systers/systers.github.io/milestones{/number}","notifications_url":"https://api.github.com/repos/systers/systers.github.io/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/systers/systers.github.io/labels{/name}","releases_url":"https://api.github.com/repos/systers/systers.github.io/releases{/id}","deployments_url":"https://api.github.com/repos/systers/systers.github.io/deployments","created_at":"2014-07-18T18:15:27Z","updated_at":"2018-11-15T14:09:04Z","pushed_at":"2018-11-15T14:09:03Z","git_url":"git://github.com/systers/systers.github.io.git","ssh_url":"[email protected]:systers/systers.github.io.git","clone_url":"https://github.com/systers/systers.github.io.git","svn_url":"https://github.com/systers/systers.github.io","homepage":"","size":9733,"stargazers_count":30,"watchers_count":30,"language":"TypeScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":65,"mirror_url":null,"archived":false,"open_issues_count":17,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":65,"open_issues":17,"watchers":30,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/systers/systers.github.io/pulls/320"},"html":{"href":"https://github.com/systers/systers.github.io/pull/320"},"issue":{"href":"https://api.github.com/repos/systers/systers.github.io/issues/320"},"comments":{"href":"https://api.github.com/repos/systers/systers.github.io/issues/320/comments"},"review_comments":{"href":"https://api.github.com/repos/systers/systers.github.io/pulls/320/comments"},"review_comment":{"href":"https://api.github.com/repos/systers/systers.github.io/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/systers/systers.github.io/pulls/320/commits"},"statuses":{"href":"https://api.github.com/repos/systers/systers.github.io/statuses/aa7cfa5ad382c8fb7e556a254a28ed12f8a7f59b"}},"author_association":"NONE"}} | {
"id": 21989834,
"name": "systers/systers.github.io",
"url": "https://api.github.com/repos/systers/systers.github.io"
} | {
"id": 25319565,
"login": "sarnava1",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/25319565?",
"url": "https://api.github.com/users/sarnava1"
} | {
"id": 6520415,
"login": "systers",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6520415?",
"url": "https://api.github.com/orgs/systers"
} | 2018-11-15T15:41:31 | 8596306657 | {"actor":{"display_login":"sarnava1"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/crystal-lang/crystal/pulls/comments/243308041","pull_request_review_id":187043160,"id":243308041,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MzMwODA0MQ==","diff_hunk":"@@ -1,71 +1,302 @@\n # -*- mode: ruby -*-\n # vi: set ft=ruby :\n \n-clone_crystal_from_vagrant = lambda do |config|\n+# Usage\n+#\n+# ```\n+# $ vagrant up xenial64\n+# $ vagrant ssh xenial64\n+# vagrant@ubuntu-xenial:~$ cd ~/crystal/\n+# vagrant@ubuntu-xenial:~$ make std_spec\n+# ```\n+#\n+# The working directory is also available at /vagrant\n+# but using the clone in ~/crystal helps isolating the binaries\n+# from each platform and it can be faster on some circumstances\n+# where files are shared with host since the clone is in the\n+# native fs.\n+#\n+# The vagrant machines will be provisined with a native crystal\n+# package or with the targz version downloaded from github.\n+# Change INSTALL_GITHUB_TARGZ to choose the installation method.\n+#\n+# To use Makefile targets on some machines the `FLAGS=--no-debug`\n+# might be needed to reduce the memory footprint.\n+#\n+# Notes:\n+# * Running specs from /vagrant directly might cause some failures in\n+# specs related to permissions.\n+# * bionic64 std_spec fails #6577\n+# * xenial32 FLAGS=--no-debug is unable to run compiler_spec.\n+# * trusty64 FLAGS=--no-debug is unable to build the compiler.\n+# * precise32 is unable to build std_spec due to outdated libxml2. ~> 2.9.0 is required.\n+# * precise32 will fail running std_spec related to reuse_port & ipv6.\n+# * freebsd needs post install manual scripts in order to install crystal.\n+# * alpine provisionning is failing due to openssl libressl issues.\n+# * alpine is unable to to use the github .tar.gz compiler\n+#\n+\n+INSTALL_GITHUB_TARGZ = false\n+GITHUB_URL = \"https://github.com/crystal-lang/crystal/releases/download/0.27.0/crystal-0.27.0-1\"\n+CRYSTAL_LINUX64_TARGZ = \"#{GITHUB_URL}-linux-x86_64.tar.gz\"\n+CRYSTAL_LINUX32_TARGZ = \"#{GITHUB_URL}-linux-i686.tar.gz\"\n+\n+Vagrant.configure(\"2\") do |config|\n+ define_ubuntu config, name: 'bionic64', dist: 'bionic', bits: 64\n+ define_ubuntu config, name: 'xenial64', dist: 'xenial', bits: 64\n+ define_ubuntu config, name: 'xenial32', dist: 'xenial', bits: 32\n+ # llvm packages > 3.8 are not available for precise/trusty. Using pre built packages\n+ define_ubuntu config, name: 'trusty64', dist: 'trusty', bits: 64, llvm: { url: \"http://crystal-lang.s3.amazonaws.com/llvm/llvm-3.9.1-1-linux-x86_64.tar.gz\", path: \"llvm-3.9.1-1\" }\n+ define_ubuntu config, name: 'trusty32', dist: 'trusty', bits: 32, llvm: { url: \"http://crystal-lang.s3.amazonaws.com/llvm/llvm-3.9.1-1-linux-i686.tar.gz\", path: \"llvm-3.9.1-1\" }\n+ define_ubuntu config, name: 'precise64', dist: 'precise', bits: 64, llvm: { url: \"http://crystal-lang.s3.amazonaws.com/llvm/llvm-3.9.1-1-linux-x86_64.tar.gz\", path: \"llvm-3.9.1-1\" }\n+ define_ubuntu config, name: 'precise32', dist: 'precise', bits: 32, llvm: { url: \"http://crystal-lang.s3.amazonaws.com/llvm/llvm-3.9.1-1-linux-i686.tar.gz\", path: \"llvm-3.9.1-1\" }\n+\n+ define_debian config, name: 'stretch64', dist: 'stretch', bits: 64\n+ define_debian config, name: 'jessie64', dist: 'jessie', bits: 64\n+\n+ define_freebsd config, name: 'freebsd11', box: '11.2-STABLE'\n+\n+ define_alpine config, name: 'alpine64', bits: 64\n+\n+ config.vm.provider \"virtualbox\" do |vb|\n+ vb.memory = 6*1024","path":"Vagrantfile","position":63,"original_position":63,"commit_id":"a213fe903fe72a94b997f750b029d5c412e3403d","original_commit_id":"a213fe903fe72a94b997f750b029d5c412e3403d","user":{"login":"straight-shoota","id":466378,"node_id":"MDQ6VXNlcjQ2NjM3OA==","avatar_url":"https://avatars0.githubusercontent.com/u/466378?v=4","gravatar_id":"","url":"https://api.github.com/users/straight-shoota","html_url":"https://github.com/straight-shoota","followers_url":"https://api.github.com/users/straight-shoota/followers","following_url":"https://api.github.com/users/straight-shoota/following{/other_user}","gists_url":"https://api.github.com/users/straight-shoota/gists{/gist_id}","starred_url":"https://api.github.com/users/straight-shoota/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/straight-shoota/subscriptions","organizations_url":"https://api.github.com/users/straight-shoota/orgs","repos_url":"https://api.github.com/users/straight-shoota/repos","events_url":"https://api.github.com/users/straight-shoota/events{/privacy}","received_events_url":"https://api.github.com/users/straight-shoota/received_events","type":"User","site_admin":false},"body":"Could we make this setting configurable? Allotting 6GB is quite a lot, especially if you're running multiple VMs in parallel (or don't have much memory available anyway).\r\nSo much space is only necessary for compiling the compiler, but you can safely go with much less when working only on the stdlib.","created_at":"2018-12-20T15:17:40Z","updated_at":"2018-12-20T15:17:41Z","html_url":"https://github.com/crystal-lang/crystal/pull/7066#discussion_r243308041","pull_request_url":"https://api.github.com/repos/crystal-lang/crystal/pulls/7066","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/crystal-lang/crystal/pulls/comments/243308041"},"html":{"href":"https://github.com/crystal-lang/crystal/pull/7066#discussion_r243308041"},"pull_request":{"href":"https://api.github.com/repos/crystal-lang/crystal/pulls/7066"}}},"pull_request":{"url":"https://api.github.com/repos/crystal-lang/crystal/pulls/7066","id":230261716,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMwMjYxNzE2","html_url":"https://github.com/crystal-lang/crystal/pull/7066","diff_url":"https://github.com/crystal-lang/crystal/pull/7066.diff","patch_url":"https://github.com/crystal-lang/crystal/pull/7066.patch","issue_url":"https://api.github.com/repos/crystal-lang/crystal/issues/7066","number":7066,"state":"open","locked":false,"title":"Update Vagrantfile","user":{"login":"bcardiff","id":459923,"node_id":"MDQ6VXNlcjQ1OTkyMw==","avatar_url":"https://avatars1.githubusercontent.com/u/459923?v=4","gravatar_id":"","url":"https://api.github.com/users/bcardiff","html_url":"https://github.com/bcardiff","followers_url":"https://api.github.com/users/bcardiff/followers","following_url":"https://api.github.com/users/bcardiff/following{/other_user}","gists_url":"https://api.github.com/users/bcardiff/gists{/gist_id}","starred_url":"https://api.github.com/users/bcardiff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bcardiff/subscriptions","organizations_url":"https://api.github.com/users/bcardiff/orgs","repos_url":"https://api.github.com/users/bcardiff/repos","events_url":"https://api.github.com/users/bcardiff/events{/privacy}","received_events_url":"https://api.github.com/users/bcardiff/received_events","type":"User","site_admin":false},"body":"I'm was trying to bring up to date the Vagrantfile.\r\n\r\nDespite which distros/versions are included I wanted to be able to:\r\n\r\n**a.** Install a crystal compiler using each distro package management (even if they are not maintained by crystal-lang) and reproduce better the end use experience.\r\n\r\n**b.** Install a crystal compiler from a .tar.gz hosted in github. This will allow up to date test without waiting for each platform and compile master easily without non crystal-lang resource.\r\n\r\nI am not sure how to achieve (b) for freebsd and alpine. Or if we need to port the compiler in other platform before using it in the target ones. Help is apreciated here :-)\r\n\r\nAiming for (b) helps to have a porting instructions written that depends only in crystal-lang resources. It's a great reference for the future IMO.\r\n\r\nSupporting (b) means that dependencies needs to be installed explictly. Whether for (a) that is not needed. This is the reason why lots of dependencies appears.\r\n\r\nI'm also refactored the configurate to have an explicit list of machines defined, easier to follow and probably to tweak.\r\n\r\nI also added some docs and notes, but before going further I would apprecite input to this a resource we can all feel comfortable using it.\r\n\r\nCloses #4802, Closes #4803, Closes #6722.\r\n\r\ncc: @j8r, @jirutka, @myfreeweb","created_at":"2018-11-12T20:39:43Z","updated_at":"2018-12-20T15:17:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"19b4f39c8195aa70bb7569e8895f80392d8c063e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":274569036,"node_id":"MDU6TGFiZWwyNzQ1NjkwMzY=","url":"https://api.github.com/repos/crystal-lang/crystal/labels/topic:infrastructure","name":"topic:infrastructure","color":"000000","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/crystal-lang/crystal/pulls/7066/commits","review_comments_url":"https://api.github.com/repos/crystal-lang/crystal/pulls/7066/comments","review_comment_url":"https://api.github.com/repos/crystal-lang/crystal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/crystal-lang/crystal/issues/7066/comments","statuses_url":"https://api.github.com/repos/crystal-lang/crystal/statuses/a213fe903fe72a94b997f750b029d5c412e3403d","head":{"label":"bcardiff:vagrant","ref":"vagrant","sha":"a213fe903fe72a94b997f750b029d5c412e3403d","user":{"login":"bcardiff","id":459923,"node_id":"MDQ6VXNlcjQ1OTkyMw==","avatar_url":"https://avatars1.githubusercontent.com/u/459923?v=4","gravatar_id":"","url":"https://api.github.com/users/bcardiff","html_url":"https://github.com/bcardiff","followers_url":"https://api.github.com/users/bcardiff/followers","following_url":"https://api.github.com/users/bcardiff/following{/other_user}","gists_url":"https://api.github.com/users/bcardiff/gists{/gist_id}","starred_url":"https://api.github.com/users/bcardiff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bcardiff/subscriptions","organizations_url":"https://api.github.com/users/bcardiff/orgs","repos_url":"https://api.github.com/users/bcardiff/repos","events_url":"https://api.github.com/users/bcardiff/events{/privacy}","received_events_url":"https://api.github.com/users/bcardiff/received_events","type":"User","site_admin":false},"repo":{"id":39784153,"node_id":"MDEwOlJlcG9zaXRvcnkzOTc4NDE1Mw==","name":"crystal","full_name":"bcardiff/crystal","private":false,"owner":{"login":"bcardiff","id":459923,"node_id":"MDQ6VXNlcjQ1OTkyMw==","avatar_url":"https://avatars1.githubusercontent.com/u/459923?v=4","gravatar_id":"","url":"https://api.github.com/users/bcardiff","html_url":"https://github.com/bcardiff","followers_url":"https://api.github.com/users/bcardiff/followers","following_url":"https://api.github.com/users/bcardiff/following{/other_user}","gists_url":"https://api.github.com/users/bcardiff/gists{/gist_id}","starred_url":"https://api.github.com/users/bcardiff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bcardiff/subscriptions","organizations_url":"https://api.github.com/users/bcardiff/orgs","repos_url":"https://api.github.com/users/bcardiff/repos","events_url":"https://api.github.com/users/bcardiff/events{/privacy}","received_events_url":"https://api.github.com/users/bcardiff/received_events","type":"User","site_admin":false},"html_url":"https://github.com/bcardiff/crystal","description":"The Crystal Programming Language","fork":true,"url":"https://api.github.com/repos/bcardiff/crystal","forks_url":"https://api.github.com/repos/bcardiff/crystal/forks","keys_url":"https://api.github.com/repos/bcardiff/crystal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bcardiff/crystal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bcardiff/crystal/teams","hooks_url":"https://api.github.com/repos/bcardiff/crystal/hooks","issue_events_url":"https://api.github.com/repos/bcardiff/crystal/issues/events{/number}","events_url":"https://api.github.com/repos/bcardiff/crystal/events","assignees_url":"https://api.github.com/repos/bcardiff/crystal/assignees{/user}","branches_url":"https://api.github.com/repos/bcardiff/crystal/branches{/branch}","tags_url":"https://api.github.com/repos/bcardiff/crystal/tags","blobs_url":"https://api.github.com/repos/bcardiff/crystal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bcardiff/crystal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bcardiff/crystal/git/refs{/sha}","trees_url":"https://api.github.com/repos/bcardiff/crystal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bcardiff/crystal/statuses/{sha}","languages_url":"https://api.github.com/repos/bcardiff/crystal/languages","stargazers_url":"https://api.github.com/repos/bcardiff/crystal/stargazers","contributors_url":"https://api.github.com/repos/bcardiff/crystal/contributors","subscribers_url":"https://api.github.com/repos/bcardiff/crystal/subscribers","subscription_url":"https://api.github.com/repos/bcardiff/crystal/subscription","commits_url":"https://api.github.com/repos/bcardiff/crystal/commits{/sha}","git_commits_url":"https://api.github.com/repos/bcardiff/crystal/git/commits{/sha}","comments_url":"https://api.github.com/repos/bcardiff/crystal/comments{/number}","issue_comment_url":"https://api.github.com/repos/bcardiff/crystal/issues/comments{/number}","contents_url":"https://api.github.com/repos/bcardiff/crystal/contents/{+path}","compare_url":"https://api.github.com/repos/bcardiff/crystal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bcardiff/crystal/merges","archive_url":"https://api.github.com/repos/bcardiff/crystal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bcardiff/crystal/downloads","issues_url":"https://api.github.com/repos/bcardiff/crystal/issues{/number}","pulls_url":"https://api.github.com/repos/bcardiff/crystal/pulls{/number}","milestones_url":"https://api.github.com/repos/bcardiff/crystal/milestones{/number}","notifications_url":"https://api.github.com/repos/bcardiff/crystal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bcardiff/crystal/labels{/name}","releases_url":"https://api.github.com/repos/bcardiff/crystal/releases{/id}","deployments_url":"https://api.github.com/repos/bcardiff/crystal/deployments","created_at":"2015-07-27T16:05:38Z","updated_at":"2018-06-12T11:49:52Z","pushed_at":"2018-12-20T05:40:01Z","git_url":"git://github.com/bcardiff/crystal.git","ssh_url":"[email protected]:bcardiff/crystal.git","clone_url":"https://github.com/bcardiff/crystal.git","svn_url":"https://github.com/bcardiff/crystal","homepage":"http://crystal-lang.org","size":46494,"stargazers_count":0,"watchers_count":0,"language":"Crystal","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"crystal-lang:master","ref":"master","sha":"c0a6716a343fb50ae3e389edee4e09e550f4df54","user":{"login":"crystal-lang","id":6539796,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY1Mzk3OTY=","avatar_url":"https://avatars0.githubusercontent.com/u/6539796?v=4","gravatar_id":"","url":"https://api.github.com/users/crystal-lang","html_url":"https://github.com/crystal-lang","followers_url":"https://api.github.com/users/crystal-lang/followers","following_url":"https://api.github.com/users/crystal-lang/following{/other_user}","gists_url":"https://api.github.com/users/crystal-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/crystal-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crystal-lang/subscriptions","organizations_url":"https://api.github.com/users/crystal-lang/orgs","repos_url":"https://api.github.com/users/crystal-lang/repos","events_url":"https://api.github.com/users/crystal-lang/events{/privacy}","received_events_url":"https://api.github.com/users/crystal-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":6887813,"node_id":"MDEwOlJlcG9zaXRvcnk2ODg3ODEz","name":"crystal","full_name":"crystal-lang/crystal","private":false,"owner":{"login":"crystal-lang","id":6539796,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY1Mzk3OTY=","avatar_url":"https://avatars0.githubusercontent.com/u/6539796?v=4","gravatar_id":"","url":"https://api.github.com/users/crystal-lang","html_url":"https://github.com/crystal-lang","followers_url":"https://api.github.com/users/crystal-lang/followers","following_url":"https://api.github.com/users/crystal-lang/following{/other_user}","gists_url":"https://api.github.com/users/crystal-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/crystal-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crystal-lang/subscriptions","organizations_url":"https://api.github.com/users/crystal-lang/orgs","repos_url":"https://api.github.com/users/crystal-lang/repos","events_url":"https://api.github.com/users/crystal-lang/events{/privacy}","received_events_url":"https://api.github.com/users/crystal-lang/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/crystal-lang/crystal","description":"The Crystal Programming Language","fork":false,"url":"https://api.github.com/repos/crystal-lang/crystal","forks_url":"https://api.github.com/repos/crystal-lang/crystal/forks","keys_url":"https://api.github.com/repos/crystal-lang/crystal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crystal-lang/crystal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crystal-lang/crystal/teams","hooks_url":"https://api.github.com/repos/crystal-lang/crystal/hooks","issue_events_url":"https://api.github.com/repos/crystal-lang/crystal/issues/events{/number}","events_url":"https://api.github.com/repos/crystal-lang/crystal/events","assignees_url":"https://api.github.com/repos/crystal-lang/crystal/assignees{/user}","branches_url":"https://api.github.com/repos/crystal-lang/crystal/branches{/branch}","tags_url":"https://api.github.com/repos/crystal-lang/crystal/tags","blobs_url":"https://api.github.com/repos/crystal-lang/crystal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crystal-lang/crystal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crystal-lang/crystal/git/refs{/sha}","trees_url":"https://api.github.com/repos/crystal-lang/crystal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crystal-lang/crystal/statuses/{sha}","languages_url":"https://api.github.com/repos/crystal-lang/crystal/languages","stargazers_url":"https://api.github.com/repos/crystal-lang/crystal/stargazers","contributors_url":"https://api.github.com/repos/crystal-lang/crystal/contributors","subscribers_url":"https://api.github.com/repos/crystal-lang/crystal/subscribers","subscription_url":"https://api.github.com/repos/crystal-lang/crystal/subscription","commits_url":"https://api.github.com/repos/crystal-lang/crystal/commits{/sha}","git_commits_url":"https://api.github.com/repos/crystal-lang/crystal/git/commits{/sha}","comments_url":"https://api.github.com/repos/crystal-lang/crystal/comments{/number}","issue_comment_url":"https://api.github.com/repos/crystal-lang/crystal/issues/comments{/number}","contents_url":"https://api.github.com/repos/crystal-lang/crystal/contents/{+path}","compare_url":"https://api.github.com/repos/crystal-lang/crystal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crystal-lang/crystal/merges","archive_url":"https://api.github.com/repos/crystal-lang/crystal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crystal-lang/crystal/downloads","issues_url":"https://api.github.com/repos/crystal-lang/crystal/issues{/number}","pulls_url":"https://api.github.com/repos/crystal-lang/crystal/pulls{/number}","milestones_url":"https://api.github.com/repos/crystal-lang/crystal/milestones{/number}","notifications_url":"https://api.github.com/repos/crystal-lang/crystal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crystal-lang/crystal/labels{/name}","releases_url":"https://api.github.com/repos/crystal-lang/crystal/releases{/id}","deployments_url":"https://api.github.com/repos/crystal-lang/crystal/deployments","created_at":"2012-11-27T17:32:32Z","updated_at":"2018-12-20T14:39:47Z","pushed_at":"2018-12-20T14:39:22Z","git_url":"git://github.com/crystal-lang/crystal.git","ssh_url":"[email protected]:crystal-lang/crystal.git","clone_url":"https://github.com/crystal-lang/crystal.git","svn_url":"https://github.com/crystal-lang/crystal","homepage":"https://crystal-lang.org","size":38028,"stargazers_count":12372,"watchers_count":12372,"language":"Crystal","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":957,"mirror_url":null,"archived":false,"open_issues_count":798,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":957,"open_issues":798,"watchers":12372,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/crystal-lang/crystal/pulls/7066"},"html":{"href":"https://github.com/crystal-lang/crystal/pull/7066"},"issue":{"href":"https://api.github.com/repos/crystal-lang/crystal/issues/7066"},"comments":{"href":"https://api.github.com/repos/crystal-lang/crystal/issues/7066/comments"},"review_comments":{"href":"https://api.github.com/repos/crystal-lang/crystal/pulls/7066/comments"},"review_comment":{"href":"https://api.github.com/repos/crystal-lang/crystal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/crystal-lang/crystal/pulls/7066/commits"},"statuses":{"href":"https://api.github.com/repos/crystal-lang/crystal/statuses/a213fe903fe72a94b997f750b029d5c412e3403d"}},"author_association":"MEMBER"}} | {
"id": 6887813,
"name": "crystal-lang/crystal",
"url": "https://api.github.com/repos/crystal-lang/crystal"
} | {
"id": 466378,
"login": "straight-shoota",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/466378?",
"url": "https://api.github.com/users/straight-shoota"
} | {
"id": 6539796,
"login": "crystal-lang",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6539796?",
"url": "https://api.github.com/orgs/crystal-lang"
} | 2018-12-20T15:17:40 | 8786258596 | {"actor":{"display_login":"straight-shoota"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/sinonjs/sinon/pulls/comments/186293210","pull_request_review_id":117845851,"id":186293210,"diff_hunk":"@@ -161,9 +161,21 @@ function Sandbox() {\n function getFakeRestorer(object, property) {\n var descriptor = getPropertyDescriptor(object, property);\n \n- return function restorer() {\n+ function restorer() {\n Object.defineProperty(object, property, descriptor);\n- };\n+ }\n+ restorer.object = object;\n+ restorer.property = property;\n+ return restorer;\n+ }\n+\n+ function verifyNotReplaced(object, property) {\n+ for (var i = 0; i < fakeRestorers.length; i++) {","path":"lib/sinon/sandbox.js","position":15,"original_position":15,"commit_id":"ebabc59540c66d7dcea9b4d15f17cb82a148cb10","original_commit_id":"ebabc59540c66d7dcea9b4d15f17cb82a148cb10","user":{"login":"mantoni","id":332271,"avatar_url":"https://avatars1.githubusercontent.com/u/332271?v=4","gravatar_id":"","url":"https://api.github.com/users/mantoni","html_url":"https://github.com/mantoni","followers_url":"https://api.github.com/users/mantoni/followers","following_url":"https://api.github.com/users/mantoni/following{/other_user}","gists_url":"https://api.github.com/users/mantoni/gists{/gist_id}","starred_url":"https://api.github.com/users/mantoni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mantoni/subscriptions","organizations_url":"https://api.github.com/users/mantoni/orgs","repos_url":"https://api.github.com/users/mantoni/repos","events_url":"https://api.github.com/users/mantoni/events{/privacy}","received_events_url":"https://api.github.com/users/mantoni/received_events","type":"User","site_admin":false},"body":"Yeah, you're right. And even `forEach` would give us an index as the second argument, if needed.","created_at":"2018-05-06T14:49:48Z","updated_at":"2018-05-06T14:49:48Z","html_url":"https://github.com/sinonjs/sinon/pull/1785#discussion_r186293210","pull_request_url":"https://api.github.com/repos/sinonjs/sinon/pulls/1785","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/sinonjs/sinon/pulls/comments/186293210"},"html":{"href":"https://github.com/sinonjs/sinon/pull/1785#discussion_r186293210"},"pull_request":{"href":"https://api.github.com/repos/sinonjs/sinon/pulls/1785"}},"in_reply_to_id":186292810},"pull_request":{"url":"https://api.github.com/repos/sinonjs/sinon/pulls/1785","id":186205773,"html_url":"https://github.com/sinonjs/sinon/pull/1785","diff_url":"https://github.com/sinonjs/sinon/pull/1785.diff","patch_url":"https://github.com/sinonjs/sinon/pull/1785.patch","issue_url":"https://api.github.com/repos/sinonjs/sinon/issues/1785","number":1785,"state":"open","locked":false,"title":"Refuse to replace already replaced values","user":{"login":"mantoni","id":332271,"avatar_url":"https://avatars1.githubusercontent.com/u/332271?v=4","gravatar_id":"","url":"https://api.github.com/users/mantoni","html_url":"https://github.com/mantoni","followers_url":"https://api.github.com/users/mantoni/followers","following_url":"https://api.github.com/users/mantoni/following{/other_user}","gists_url":"https://api.github.com/users/mantoni/gists{/gist_id}","starred_url":"https://api.github.com/users/mantoni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mantoni/subscriptions","organizations_url":"https://api.github.com/users/mantoni/orgs","repos_url":"https://api.github.com/users/mantoni/repos","events_url":"https://api.github.com/users/mantoni/events{/privacy}","received_events_url":"https://api.github.com/users/mantoni/received_events","type":"User","site_admin":false},"body":"Fix for issue #1779\r\n\r\nWhen values where replaced multiple times, `restore` didn't restore the original value. This change causes `sandbox.replace` to throw if the given object / property combination was already used.\r\n\r\n#### How to verify - mandatory\r\n1. Check out this branch\r\n2. `npm install`\r\n3. `npm test`\r\n\r\nor\r\n\r\n```js\r\nsinon.replace(console, \"log\", sinon.fake());\r\nsinon.replace(console, \"log\", sinon.fake()); // now throws\r\n```\r\n\r\n## Versioning\r\n\r\nWhile this fixes an issue where `sandbox.restore()` fails to restore values that where replaced multiple times, this might also cause existing tests to fail. However, I would argue that we're fixing a broken behavior in the new `sandbox.replace` API to bring it in line with `sandbox.stub` which also throws in this case. Therefore I'd vote for semver patch.\r\n\r\n#### Checklist for author\r\n\r\n- [x] `npm run lint` passes\r\n- [x] References to standard library functions are [cached](https://github.com/sinonjs/sinon/pull/1523).","created_at":"2018-05-06T13:30:39Z","updated_at":"2018-05-06T14:49:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d089843440f3d76962e96e2626b14f7665d15e85","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":543765630,"url":"https://api.github.com/repos/sinonjs/sinon/labels/semver:patch","name":"semver:patch","color":"c2e0c6","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/sinonjs/sinon/pulls/1785/commits","review_comments_url":"https://api.github.com/repos/sinonjs/sinon/pulls/1785/comments","review_comment_url":"https://api.github.com/repos/sinonjs/sinon/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sinonjs/sinon/issues/1785/comments","statuses_url":"https://api.github.com/repos/sinonjs/sinon/statuses/ebabc59540c66d7dcea9b4d15f17cb82a148cb10","head":{"label":"sinonjs:sandbox-replace-only-once","ref":"sandbox-replace-only-once","sha":"ebabc59540c66d7dcea9b4d15f17cb82a148cb10","user":{"login":"sinonjs","id":6570253,"avatar_url":"https://avatars3.githubusercontent.com/u/6570253?v=4","gravatar_id":"","url":"https://api.github.com/users/sinonjs","html_url":"https://github.com/sinonjs","followers_url":"https://api.github.com/users/sinonjs/followers","following_url":"https://api.github.com/users/sinonjs/following{/other_user}","gists_url":"https://api.github.com/users/sinonjs/gists{/gist_id}","starred_url":"https://api.github.com/users/sinonjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sinonjs/subscriptions","organizations_url":"https://api.github.com/users/sinonjs/orgs","repos_url":"https://api.github.com/users/sinonjs/repos","events_url":"https://api.github.com/users/sinonjs/events{/privacy}","received_events_url":"https://api.github.com/users/sinonjs/received_events","type":"Organization","site_admin":false},"repo":{"id":747698,"name":"sinon","full_name":"sinonjs/sinon","owner":{"login":"sinonjs","id":6570253,"avatar_url":"https://avatars3.githubusercontent.com/u/6570253?v=4","gravatar_id":"","url":"https://api.github.com/users/sinonjs","html_url":"https://github.com/sinonjs","followers_url":"https://api.github.com/users/sinonjs/followers","following_url":"https://api.github.com/users/sinonjs/following{/other_user}","gists_url":"https://api.github.com/users/sinonjs/gists{/gist_id}","starred_url":"https://api.github.com/users/sinonjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sinonjs/subscriptions","organizations_url":"https://api.github.com/users/sinonjs/orgs","repos_url":"https://api.github.com/users/sinonjs/repos","events_url":"https://api.github.com/users/sinonjs/events{/privacy}","received_events_url":"https://api.github.com/users/sinonjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sinonjs/sinon","description":"Test spies, stubs and mocks for JavaScript.","fork":false,"url":"https://api.github.com/repos/sinonjs/sinon","forks_url":"https://api.github.com/repos/sinonjs/sinon/forks","keys_url":"https://api.github.com/repos/sinonjs/sinon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sinonjs/sinon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sinonjs/sinon/teams","hooks_url":"https://api.github.com/repos/sinonjs/sinon/hooks","issue_events_url":"https://api.github.com/repos/sinonjs/sinon/issues/events{/number}","events_url":"https://api.github.com/repos/sinonjs/sinon/events","assignees_url":"https://api.github.com/repos/sinonjs/sinon/assignees{/user}","branches_url":"https://api.github.com/repos/sinonjs/sinon/branches{/branch}","tags_url":"https://api.github.com/repos/sinonjs/sinon/tags","blobs_url":"https://api.github.com/repos/sinonjs/sinon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sinonjs/sinon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sinonjs/sinon/git/refs{/sha}","trees_url":"https://api.github.com/repos/sinonjs/sinon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sinonjs/sinon/statuses/{sha}","languages_url":"https://api.github.com/repos/sinonjs/sinon/languages","stargazers_url":"https://api.github.com/repos/sinonjs/sinon/stargazers","contributors_url":"https://api.github.com/repos/sinonjs/sinon/contributors","subscribers_url":"https://api.github.com/repos/sinonjs/sinon/subscribers","subscription_url":"https://api.github.com/repos/sinonjs/sinon/subscription","commits_url":"https://api.github.com/repos/sinonjs/sinon/commits{/sha}","git_commits_url":"https://api.github.com/repos/sinonjs/sinon/git/commits{/sha}","comments_url":"https://api.github.com/repos/sinonjs/sinon/comments{/number}","issue_comment_url":"https://api.github.com/repos/sinonjs/sinon/issues/comments{/number}","contents_url":"https://api.github.com/repos/sinonjs/sinon/contents/{+path}","compare_url":"https://api.github.com/repos/sinonjs/sinon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sinonjs/sinon/merges","archive_url":"https://api.github.com/repos/sinonjs/sinon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sinonjs/sinon/downloads","issues_url":"https://api.github.com/repos/sinonjs/sinon/issues{/number}","pulls_url":"https://api.github.com/repos/sinonjs/sinon/pulls{/number}","milestones_url":"https://api.github.com/repos/sinonjs/sinon/milestones{/number}","notifications_url":"https://api.github.com/repos/sinonjs/sinon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sinonjs/sinon/labels{/name}","releases_url":"https://api.github.com/repos/sinonjs/sinon/releases{/id}","deployments_url":"https://api.github.com/repos/sinonjs/sinon/deployments","created_at":"2010-06-29T21:15:32Z","updated_at":"2018-05-06T14:22:28Z","pushed_at":"2018-05-06T13:30:40Z","git_url":"git://github.com/sinonjs/sinon.git","ssh_url":"[email protected]:sinonjs/sinon.git","clone_url":"https://github.com/sinonjs/sinon.git","svn_url":"https://github.com/sinonjs/sinon","homepage":"http://sinonjs.org/","size":17826,"stargazers_count":5819,"watchers_count":5819,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":634,"mirror_url":null,"archived":false,"open_issues_count":33,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":634,"open_issues":33,"watchers":5819,"default_branch":"master"}},"base":{"label":"sinonjs:master","ref":"master","sha":"d4467e70a32d08a81180cc898757e2500a29c815","user":{"login":"sinonjs","id":6570253,"avatar_url":"https://avatars3.githubusercontent.com/u/6570253?v=4","gravatar_id":"","url":"https://api.github.com/users/sinonjs","html_url":"https://github.com/sinonjs","followers_url":"https://api.github.com/users/sinonjs/followers","following_url":"https://api.github.com/users/sinonjs/following{/other_user}","gists_url":"https://api.github.com/users/sinonjs/gists{/gist_id}","starred_url":"https://api.github.com/users/sinonjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sinonjs/subscriptions","organizations_url":"https://api.github.com/users/sinonjs/orgs","repos_url":"https://api.github.com/users/sinonjs/repos","events_url":"https://api.github.com/users/sinonjs/events{/privacy}","received_events_url":"https://api.github.com/users/sinonjs/received_events","type":"Organization","site_admin":false},"repo":{"id":747698,"name":"sinon","full_name":"sinonjs/sinon","owner":{"login":"sinonjs","id":6570253,"avatar_url":"https://avatars3.githubusercontent.com/u/6570253?v=4","gravatar_id":"","url":"https://api.github.com/users/sinonjs","html_url":"https://github.com/sinonjs","followers_url":"https://api.github.com/users/sinonjs/followers","following_url":"https://api.github.com/users/sinonjs/following{/other_user}","gists_url":"https://api.github.com/users/sinonjs/gists{/gist_id}","starred_url":"https://api.github.com/users/sinonjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sinonjs/subscriptions","organizations_url":"https://api.github.com/users/sinonjs/orgs","repos_url":"https://api.github.com/users/sinonjs/repos","events_url":"https://api.github.com/users/sinonjs/events{/privacy}","received_events_url":"https://api.github.com/users/sinonjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sinonjs/sinon","description":"Test spies, stubs and mocks for JavaScript.","fork":false,"url":"https://api.github.com/repos/sinonjs/sinon","forks_url":"https://api.github.com/repos/sinonjs/sinon/forks","keys_url":"https://api.github.com/repos/sinonjs/sinon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sinonjs/sinon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sinonjs/sinon/teams","hooks_url":"https://api.github.com/repos/sinonjs/sinon/hooks","issue_events_url":"https://api.github.com/repos/sinonjs/sinon/issues/events{/number}","events_url":"https://api.github.com/repos/sinonjs/sinon/events","assignees_url":"https://api.github.com/repos/sinonjs/sinon/assignees{/user}","branches_url":"https://api.github.com/repos/sinonjs/sinon/branches{/branch}","tags_url":"https://api.github.com/repos/sinonjs/sinon/tags","blobs_url":"https://api.github.com/repos/sinonjs/sinon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sinonjs/sinon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sinonjs/sinon/git/refs{/sha}","trees_url":"https://api.github.com/repos/sinonjs/sinon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sinonjs/sinon/statuses/{sha}","languages_url":"https://api.github.com/repos/sinonjs/sinon/languages","stargazers_url":"https://api.github.com/repos/sinonjs/sinon/stargazers","contributors_url":"https://api.github.com/repos/sinonjs/sinon/contributors","subscribers_url":"https://api.github.com/repos/sinonjs/sinon/subscribers","subscription_url":"https://api.github.com/repos/sinonjs/sinon/subscription","commits_url":"https://api.github.com/repos/sinonjs/sinon/commits{/sha}","git_commits_url":"https://api.github.com/repos/sinonjs/sinon/git/commits{/sha}","comments_url":"https://api.github.com/repos/sinonjs/sinon/comments{/number}","issue_comment_url":"https://api.github.com/repos/sinonjs/sinon/issues/comments{/number}","contents_url":"https://api.github.com/repos/sinonjs/sinon/contents/{+path}","compare_url":"https://api.github.com/repos/sinonjs/sinon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sinonjs/sinon/merges","archive_url":"https://api.github.com/repos/sinonjs/sinon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sinonjs/sinon/downloads","issues_url":"https://api.github.com/repos/sinonjs/sinon/issues{/number}","pulls_url":"https://api.github.com/repos/sinonjs/sinon/pulls{/number}","milestones_url":"https://api.github.com/repos/sinonjs/sinon/milestones{/number}","notifications_url":"https://api.github.com/repos/sinonjs/sinon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sinonjs/sinon/labels{/name}","releases_url":"https://api.github.com/repos/sinonjs/sinon/releases{/id}","deployments_url":"https://api.github.com/repos/sinonjs/sinon/deployments","created_at":"2010-06-29T21:15:32Z","updated_at":"2018-05-06T14:22:28Z","pushed_at":"2018-05-06T13:30:40Z","git_url":"git://github.com/sinonjs/sinon.git","ssh_url":"[email protected]:sinonjs/sinon.git","clone_url":"https://github.com/sinonjs/sinon.git","svn_url":"https://github.com/sinonjs/sinon","homepage":"http://sinonjs.org/","size":17826,"stargazers_count":5819,"watchers_count":5819,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":634,"mirror_url":null,"archived":false,"open_issues_count":33,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":634,"open_issues":33,"watchers":5819,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sinonjs/sinon/pulls/1785"},"html":{"href":"https://github.com/sinonjs/sinon/pull/1785"},"issue":{"href":"https://api.github.com/repos/sinonjs/sinon/issues/1785"},"comments":{"href":"https://api.github.com/repos/sinonjs/sinon/issues/1785/comments"},"review_comments":{"href":"https://api.github.com/repos/sinonjs/sinon/pulls/1785/comments"},"review_comment":{"href":"https://api.github.com/repos/sinonjs/sinon/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sinonjs/sinon/pulls/1785/commits"},"statuses":{"href":"https://api.github.com/repos/sinonjs/sinon/statuses/ebabc59540c66d7dcea9b4d15f17cb82a148cb10"}},"author_association":"OWNER"}} | {
"id": 747698,
"name": "sinonjs/sinon",
"url": "https://api.github.com/repos/sinonjs/sinon"
} | {
"id": 332271,
"login": "mantoni",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/332271?",
"url": "https://api.github.com/users/mantoni"
} | {
"id": 6570253,
"login": "sinonjs",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6570253?",
"url": "https://api.github.com/orgs/sinonjs"
} | 2018-05-06T14:49:48 | 7634186524 | {"actor":{"display_login":"mantoni"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/sinonjs/lolex/pulls/comments/223217035","pull_request_review_id":162293666,"id":223217035,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMzIxNzAzNQ==","diff_hunk":"@@ -531,6 +534,30 @@ function withGlobal(_global) {\n return 16 - ((clock.now - start) % 16);\n }\n \n+ function hrtime(prev) {\n+ var millisSinceStart = clock.now - adjustedSystemTime[0] - start;\n+ var secsSinceStart = Math.floor( millisSinceStart / 1000);\n+ var remainderInNanos = (millisSinceStart - secsSinceStart * 1e3 ) * 1e6 + nanos - adjustedSystemTime[1];\n+\n+ if (Array.isArray(prev)) {\n+ if ( prev[1] > 1e9 ) {\n+ throw new TypeError(\"Number of nanoseconds can't exceed a billion\");\n+ }\n+\n+ var oldSecs = prev[0];\n+ var nanoDiff = remainderInNanos - prev[1];\n+ var secDiff = secsSinceStart - oldSecs;\n+\n+ if (nanoDiff < 0) {\n+ nanoDiff += 1 * 1e9;","path":"src/lolex-src.js","position":null,"original_position":75,"commit_id":"afd5f5803a501946428e7992cb40da7373bc4c47","original_commit_id":"31f6c27cfe3678dad312d3bef8fe83110a0cfb55","user":{"login":"SimenB","id":1404810,"node_id":"MDQ6VXNlcjE0MDQ4MTA=","avatar_url":"https://avatars1.githubusercontent.com/u/1404810?v=4","gravatar_id":"","url":"https://api.github.com/users/SimenB","html_url":"https://github.com/SimenB","followers_url":"https://api.github.com/users/SimenB/followers","following_url":"https://api.github.com/users/SimenB/following{/other_user}","gists_url":"https://api.github.com/users/SimenB/gists{/gist_id}","starred_url":"https://api.github.com/users/SimenB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SimenB/subscriptions","organizations_url":"https://api.github.com/users/SimenB/orgs","repos_url":"https://api.github.com/users/SimenB/repos","events_url":"https://api.github.com/users/SimenB/events{/privacy}","received_events_url":"https://api.github.com/users/SimenB/received_events","type":"User","site_admin":false},"body":"The latter 🙂 ","created_at":"2018-10-07T15:11:14Z","updated_at":"2018-10-07T15:11:14Z","html_url":"https://github.com/sinonjs/lolex/pull/214#discussion_r223217035","pull_request_url":"https://api.github.com/repos/sinonjs/lolex/pulls/214","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/sinonjs/lolex/pulls/comments/223217035"},"html":{"href":"https://github.com/sinonjs/lolex/pull/214#discussion_r223217035"},"pull_request":{"href":"https://api.github.com/repos/sinonjs/lolex/pulls/214"}},"in_reply_to_id":223183983},"pull_request":{"url":"https://api.github.com/repos/sinonjs/lolex/pulls/214","id":220888083,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwODg4MDgz","html_url":"https://github.com/sinonjs/lolex/pull/214","diff_url":"https://github.com/sinonjs/lolex/pull/214.diff","patch_url":"https://github.com/sinonjs/lolex/pull/214.patch","issue_url":"https://api.github.com/repos/sinonjs/lolex/issues/214","number":214,"state":"open","locked":false,"title":"Introduce nanosecond precision ticks","user":{"login":"fatso83","id":618076,"node_id":"MDQ6VXNlcjYxODA3Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/618076?v=4","gravatar_id":"","url":"https://api.github.com/users/fatso83","html_url":"https://github.com/fatso83","followers_url":"https://api.github.com/users/fatso83/followers","following_url":"https://api.github.com/users/fatso83/following{/other_user}","gists_url":"https://api.github.com/users/fatso83/gists{/gist_id}","starred_url":"https://api.github.com/users/fatso83/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fatso83/subscriptions","organizations_url":"https://api.github.com/users/fatso83/orgs","repos_url":"https://api.github.com/users/fatso83/repos","events_url":"https://api.github.com/users/fatso83/events{/privacy}","received_events_url":"https://api.github.com/users/fatso83/received_events","type":"User","site_admin":false},"body":"#### Purpose \r\nThis is a fix for #207, which dealt in round-off errors. \r\n\r\nOther notable changes are:\r\n- removes `clock.hrNow`. Should not be an issue as it's an internal detail not documented in our API\r\n- throws on negative ticks. This is a breaking API change, but I would be very surprised if it affected anyone, as this essentially means backwards time travel.\r\n- change some test structure, replacing `if()` blocks with conditional `this.skip()`\r\n\r\n#### Background\r\nThis PR fixes #207 by doing away with floats for representing time; opting to store milliseconds and millisecond decimals separately. We could have avoided the complications of storing two parts by opting to store all ticks as nanoseconds, but that would pose other round-off issues when adding/subtracting high-value milliseconds. Javascript is unable to represent the epoch as nanos due to too few bits for the `Number` type. See discussion in #207 for more background. The test cases found through that issue is included in the test suite.\r\n\r\nI tried a few approaches, but this approach was the simplest one to follow and allowed me to do away with a bit of code. For a while I had problems with the behaviour that setting system time should not affect the hrtime, and I tried recreating the approach of using a separate clock for `hrtime` (which was the purpose `hrNow` served), but keeping the two clocks in sync, including the nanosecond offsets, with all the existing `updateHrTime()` callsites was just too much for my simple mind to fathom :boom: Instead I found a simpler solution which was just to record the delta between the new and old time when a new system clock is set and use that to compensate in the `hrtime()` function (see ae83b27).\r\n\r\ncloses #207\r\n\r\n#### Verifying\r\n1. clone the repo and checkout the branch\r\n1. `npm install && npm test`\r\n1. `npm run test-cloud` (if you have sauce labs credentials)\r\n1. `npm link` - will install this as your local `lolex`\r\n1. Require `lolex` in your repo and run against your own code/tests","created_at":"2018-10-06T14:00:39Z","updated_at":"2018-10-07T15:11:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fa9df6b8c0f2086bc59e2ba91b9d52a6ee29a7c5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":644636907,"node_id":"MDU6TGFiZWw2NDQ2MzY5MDc=","url":"https://api.github.com/repos/sinonjs/lolex/labels/major/breaking","name":"major/breaking","color":"0052cc","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/sinonjs/lolex/pulls/214/commits","review_comments_url":"https://api.github.com/repos/sinonjs/lolex/pulls/214/comments","review_comment_url":"https://api.github.com/repos/sinonjs/lolex/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sinonjs/lolex/issues/214/comments","statuses_url":"https://api.github.com/repos/sinonjs/lolex/statuses/afd5f5803a501946428e7992cb40da7373bc4c47","head":{"label":"fatso83:207-high-res","ref":"207-high-res","sha":"afd5f5803a501946428e7992cb40da7373bc4c47","user":{"login":"fatso83","id":618076,"node_id":"MDQ6VXNlcjYxODA3Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/618076?v=4","gravatar_id":"","url":"https://api.github.com/users/fatso83","html_url":"https://github.com/fatso83","followers_url":"https://api.github.com/users/fatso83/followers","following_url":"https://api.github.com/users/fatso83/following{/other_user}","gists_url":"https://api.github.com/users/fatso83/gists{/gist_id}","starred_url":"https://api.github.com/users/fatso83/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fatso83/subscriptions","organizations_url":"https://api.github.com/users/fatso83/orgs","repos_url":"https://api.github.com/users/fatso83/repos","events_url":"https://api.github.com/users/fatso83/events{/privacy}","received_events_url":"https://api.github.com/users/fatso83/received_events","type":"User","site_admin":false},"repo":{"id":42253609,"node_id":"MDEwOlJlcG9zaXRvcnk0MjI1MzYwOQ==","name":"lolex","full_name":"fatso83/lolex","private":false,"owner":{"login":"fatso83","id":618076,"node_id":"MDQ6VXNlcjYxODA3Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/618076?v=4","gravatar_id":"","url":"https://api.github.com/users/fatso83","html_url":"https://github.com/fatso83","followers_url":"https://api.github.com/users/fatso83/followers","following_url":"https://api.github.com/users/fatso83/following{/other_user}","gists_url":"https://api.github.com/users/fatso83/gists{/gist_id}","starred_url":"https://api.github.com/users/fatso83/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fatso83/subscriptions","organizations_url":"https://api.github.com/users/fatso83/orgs","repos_url":"https://api.github.com/users/fatso83/repos","events_url":"https://api.github.com/users/fatso83/events{/privacy}","received_events_url":"https://api.github.com/users/fatso83/received_events","type":"User","site_admin":false},"html_url":"https://github.com/fatso83/lolex","description":"Fake setTimeout and friends (collectively known as \"timers\"). Useful in your JavaScript tests. Extracted from Sinon.JS","fork":true,"url":"https://api.github.com/repos/fatso83/lolex","forks_url":"https://api.github.com/repos/fatso83/lolex/forks","keys_url":"https://api.github.com/repos/fatso83/lolex/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fatso83/lolex/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fatso83/lolex/teams","hooks_url":"https://api.github.com/repos/fatso83/lolex/hooks","issue_events_url":"https://api.github.com/repos/fatso83/lolex/issues/events{/number}","events_url":"https://api.github.com/repos/fatso83/lolex/events","assignees_url":"https://api.github.com/repos/fatso83/lolex/assignees{/user}","branches_url":"https://api.github.com/repos/fatso83/lolex/branches{/branch}","tags_url":"https://api.github.com/repos/fatso83/lolex/tags","blobs_url":"https://api.github.com/repos/fatso83/lolex/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fatso83/lolex/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fatso83/lolex/git/refs{/sha}","trees_url":"https://api.github.com/repos/fatso83/lolex/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fatso83/lolex/statuses/{sha}","languages_url":"https://api.github.com/repos/fatso83/lolex/languages","stargazers_url":"https://api.github.com/repos/fatso83/lolex/stargazers","contributors_url":"https://api.github.com/repos/fatso83/lolex/contributors","subscribers_url":"https://api.github.com/repos/fatso83/lolex/subscribers","subscription_url":"https://api.github.com/repos/fatso83/lolex/subscription","commits_url":"https://api.github.com/repos/fatso83/lolex/commits{/sha}","git_commits_url":"https://api.github.com/repos/fatso83/lolex/git/commits{/sha}","comments_url":"https://api.github.com/repos/fatso83/lolex/comments{/number}","issue_comment_url":"https://api.github.com/repos/fatso83/lolex/issues/comments{/number}","contents_url":"https://api.github.com/repos/fatso83/lolex/contents/{+path}","compare_url":"https://api.github.com/repos/fatso83/lolex/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fatso83/lolex/merges","archive_url":"https://api.github.com/repos/fatso83/lolex/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fatso83/lolex/downloads","issues_url":"https://api.github.com/repos/fatso83/lolex/issues{/number}","pulls_url":"https://api.github.com/repos/fatso83/lolex/pulls{/number}","milestones_url":"https://api.github.com/repos/fatso83/lolex/milestones{/number}","notifications_url":"https://api.github.com/repos/fatso83/lolex/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fatso83/lolex/labels{/name}","releases_url":"https://api.github.com/repos/fatso83/lolex/releases{/id}","deployments_url":"https://api.github.com/repos/fatso83/lolex/deployments","created_at":"2015-09-10T15:35:18Z","updated_at":"2016-05-26T18:20:30Z","pushed_at":"2018-10-06T15:17:51Z","git_url":"git://github.com/fatso83/lolex.git","ssh_url":"[email protected]:fatso83/lolex.git","clone_url":"https://github.com/fatso83/lolex.git","svn_url":"https://github.com/fatso83/lolex","homepage":null,"size":575,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sinonjs:master","ref":"master","sha":"d4c2c053c8dce7d8b9e6727ac75275e5e32bae2b","user":{"login":"sinonjs","id":6570253,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY1NzAyNTM=","avatar_url":"https://avatars3.githubusercontent.com/u/6570253?v=4","gravatar_id":"","url":"https://api.github.com/users/sinonjs","html_url":"https://github.com/sinonjs","followers_url":"https://api.github.com/users/sinonjs/followers","following_url":"https://api.github.com/users/sinonjs/following{/other_user}","gists_url":"https://api.github.com/users/sinonjs/gists{/gist_id}","starred_url":"https://api.github.com/users/sinonjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sinonjs/subscriptions","organizations_url":"https://api.github.com/users/sinonjs/orgs","repos_url":"https://api.github.com/users/sinonjs/repos","events_url":"https://api.github.com/users/sinonjs/events{/privacy}","received_events_url":"https://api.github.com/users/sinonjs/received_events","type":"Organization","site_admin":false},"repo":{"id":16523712,"node_id":"MDEwOlJlcG9zaXRvcnkxNjUyMzcxMg==","name":"lolex","full_name":"sinonjs/lolex","private":false,"owner":{"login":"sinonjs","id":6570253,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY1NzAyNTM=","avatar_url":"https://avatars3.githubusercontent.com/u/6570253?v=4","gravatar_id":"","url":"https://api.github.com/users/sinonjs","html_url":"https://github.com/sinonjs","followers_url":"https://api.github.com/users/sinonjs/followers","following_url":"https://api.github.com/users/sinonjs/following{/other_user}","gists_url":"https://api.github.com/users/sinonjs/gists{/gist_id}","starred_url":"https://api.github.com/users/sinonjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sinonjs/subscriptions","organizations_url":"https://api.github.com/users/sinonjs/orgs","repos_url":"https://api.github.com/users/sinonjs/repos","events_url":"https://api.github.com/users/sinonjs/events{/privacy}","received_events_url":"https://api.github.com/users/sinonjs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/sinonjs/lolex","description":"Fake setTimeout and friends (collectively known as \"timers\"). Useful in your JavaScript tests. Extracted from Sinon.JS","fork":false,"url":"https://api.github.com/repos/sinonjs/lolex","forks_url":"https://api.github.com/repos/sinonjs/lolex/forks","keys_url":"https://api.github.com/repos/sinonjs/lolex/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sinonjs/lolex/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sinonjs/lolex/teams","hooks_url":"https://api.github.com/repos/sinonjs/lolex/hooks","issue_events_url":"https://api.github.com/repos/sinonjs/lolex/issues/events{/number}","events_url":"https://api.github.com/repos/sinonjs/lolex/events","assignees_url":"https://api.github.com/repos/sinonjs/lolex/assignees{/user}","branches_url":"https://api.github.com/repos/sinonjs/lolex/branches{/branch}","tags_url":"https://api.github.com/repos/sinonjs/lolex/tags","blobs_url":"https://api.github.com/repos/sinonjs/lolex/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sinonjs/lolex/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sinonjs/lolex/git/refs{/sha}","trees_url":"https://api.github.com/repos/sinonjs/lolex/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sinonjs/lolex/statuses/{sha}","languages_url":"https://api.github.com/repos/sinonjs/lolex/languages","stargazers_url":"https://api.github.com/repos/sinonjs/lolex/stargazers","contributors_url":"https://api.github.com/repos/sinonjs/lolex/contributors","subscribers_url":"https://api.github.com/repos/sinonjs/lolex/subscribers","subscription_url":"https://api.github.com/repos/sinonjs/lolex/subscription","commits_url":"https://api.github.com/repos/sinonjs/lolex/commits{/sha}","git_commits_url":"https://api.github.com/repos/sinonjs/lolex/git/commits{/sha}","comments_url":"https://api.github.com/repos/sinonjs/lolex/comments{/number}","issue_comment_url":"https://api.github.com/repos/sinonjs/lolex/issues/comments{/number}","contents_url":"https://api.github.com/repos/sinonjs/lolex/contents/{+path}","compare_url":"https://api.github.com/repos/sinonjs/lolex/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sinonjs/lolex/merges","archive_url":"https://api.github.com/repos/sinonjs/lolex/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sinonjs/lolex/downloads","issues_url":"https://api.github.com/repos/sinonjs/lolex/issues{/number}","pulls_url":"https://api.github.com/repos/sinonjs/lolex/pulls{/number}","milestones_url":"https://api.github.com/repos/sinonjs/lolex/milestones{/number}","notifications_url":"https://api.github.com/repos/sinonjs/lolex/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sinonjs/lolex/labels{/name}","releases_url":"https://api.github.com/repos/sinonjs/lolex/releases{/id}","deployments_url":"https://api.github.com/repos/sinonjs/lolex/deployments","created_at":"2014-02-04T19:57:17Z","updated_at":"2018-10-05T20:34:25Z","pushed_at":"2018-10-06T15:17:52Z","git_url":"git://github.com/sinonjs/lolex.git","ssh_url":"[email protected]:sinonjs/lolex.git","clone_url":"https://github.com/sinonjs/lolex.git","svn_url":"https://github.com/sinonjs/lolex","homepage":null,"size":589,"stargazers_count":337,"watchers_count":337,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":51,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":51,"open_issues":6,"watchers":337,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sinonjs/lolex/pulls/214"},"html":{"href":"https://github.com/sinonjs/lolex/pull/214"},"issue":{"href":"https://api.github.com/repos/sinonjs/lolex/issues/214"},"comments":{"href":"https://api.github.com/repos/sinonjs/lolex/issues/214/comments"},"review_comments":{"href":"https://api.github.com/repos/sinonjs/lolex/pulls/214/comments"},"review_comment":{"href":"https://api.github.com/repos/sinonjs/lolex/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sinonjs/lolex/pulls/214/commits"},"statuses":{"href":"https://api.github.com/repos/sinonjs/lolex/statuses/afd5f5803a501946428e7992cb40da7373bc4c47"}},"author_association":"CONTRIBUTOR"}} | {
"id": 16523712,
"name": "sinonjs/lolex",
"url": "https://api.github.com/repos/sinonjs/lolex"
} | {
"id": 1404810,
"login": "SimenB",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1404810?",
"url": "https://api.github.com/users/SimenB"
} | {
"id": 6570253,
"login": "sinonjs",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6570253?",
"url": "https://api.github.com/orgs/sinonjs"
} | 2018-10-07T15:11:14 | 8380481651 | {"actor":{"display_login":"SimenB"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/Apipie/apipie-rails/pulls/comments/170665102","pull_request_review_id":99385311,"id":170665102,"diff_hunk":"@@ -354,6 +363,65 @@ def param_group(name, scope_or_options = nil, options = {})\n @_current_param_group = nil\n end\n \n+ # Describe possible responses\n+ #\n+ # Example:\n+ # def_param_group :user do\n+ # param :user, Hash do\n+ # param :name, String\n+ # end\n+ # end\n+ #\n+ # returns :user, \"the speaker\"\n+ # returns \"the speaker\" do\n+ # param_group: :user\n+ # end\n+ # returns :param_group => :user, \"the speaker\"\n+ # returns :user, :code => 201, :desc => \"the created speaker record\"\n+ # [NOT IMPLEMENTED YET] returns :array_of => :user, \"many speakers\"\n+ # def hello_world\n+ # render json: {user: {name: \"Alfred\"}}\n+ # end\n+ #\n+ def returns(pgroup_or_options, desc_or_options=nil, options={}, &block) #:doc:\n+ return unless Apipie.active_dsl?\n+\n+\n+ if desc_or_options.is_a? Hash\n+ options.merge!(desc_or_options)\n+ elsif !desc_or_options.nil?\n+ options[:desc] = desc_or_options\n+ end\n+\n+ if pgroup_or_options.is_a? Hash\n+ options.merge!(pgroup_or_options)\n+ else\n+ options[:param_group] = pgroup_or_options\n+ end\n+\n+ code = options[:code] || 200\n+ scope = options[:scope] || _default_param_group_scope\n+ descriptor = options[:param_group] || options[:array_of]\n+\n+ if block.nil?\n+ if descriptor.is_a? ResponseDescriptionAdapter\n+ adapter = descriptor\n+ elsif descriptor.respond_to? :describe_own_properties\n+ adapter = ResponseDescriptionAdapter.from_self_describing_class(descriptor)\n+ else\n+ begin\n+ block = Apipie.get_param_group(scope, descriptor) if descriptor\n+ rescue\n+ raise \"No param_group or self-describing class named #{descriptor}\"","path":"lib/apipie/dsl_definition.rb","position":92,"original_position":92,"commit_id":"4abff6754a555aeb9f6212c6f15c57b0611dba1c","original_commit_id":"4abff6754a555aeb9f6212c6f15c57b0611dba1c","user":{"login":"iNecas","id":190443,"avatar_url":"https://avatars3.githubusercontent.com/u/190443?v=4","gravatar_id":"","url":"https://api.github.com/users/iNecas","html_url":"https://github.com/iNecas","followers_url":"https://api.github.com/users/iNecas/followers","following_url":"https://api.github.com/users/iNecas/following{/other_user}","gists_url":"https://api.github.com/users/iNecas/gists{/gist_id}","starred_url":"https://api.github.com/users/iNecas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iNecas/subscriptions","organizations_url":"https://api.github.com/users/iNecas/orgs","repos_url":"https://api.github.com/users/iNecas/repos","events_url":"https://api.github.com/users/iNecas/events{/privacy}","received_events_url":"https://api.github.com/users/iNecas/received_events","type":"User","site_admin":false},"body":"What kind of exceptions do we expect here?","created_at":"2018-02-26T17:08:08Z","updated_at":"2018-02-26T17:08:08Z","html_url":"https://github.com/Apipie/apipie-rails/pull/588#discussion_r170665102","pull_request_url":"https://api.github.com/repos/Apipie/apipie-rails/pulls/588","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/Apipie/apipie-rails/pulls/comments/170665102"},"html":{"href":"https://github.com/Apipie/apipie-rails/pull/588#discussion_r170665102"},"pull_request":{"href":"https://api.github.com/repos/Apipie/apipie-rails/pulls/588"}}},"pull_request":{"url":"https://api.github.com/repos/Apipie/apipie-rails/pulls/588","id":160755614,"html_url":"https://github.com/Apipie/apipie-rails/pull/588","diff_url":"https://github.com/Apipie/apipie-rails/pull/588.diff","patch_url":"https://github.com/Apipie/apipie-rails/pull/588.patch","issue_url":"https://api.github.com/repos/Apipie/apipie-rails/issues/588","number":588,"state":"open","locked":false,"title":"For discussion: proposal for describing responses","user":{"login":"elasti-ron","id":23432602,"avatar_url":"https://avatars2.githubusercontent.com/u/23432602?v=4","gravatar_id":"","url":"https://api.github.com/users/elasti-ron","html_url":"https://github.com/elasti-ron","followers_url":"https://api.github.com/users/elasti-ron/followers","following_url":"https://api.github.com/users/elasti-ron/following{/other_user}","gists_url":"https://api.github.com/users/elasti-ron/gists{/gist_id}","starred_url":"https://api.github.com/users/elasti-ron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elasti-ron/subscriptions","organizations_url":"https://api.github.com/users/elasti-ron/orgs","repos_url":"https://api.github.com/users/elasti-ron/repos","events_url":"https://api.github.com/users/elasti-ron/events{/privacy}","received_events_url":"https://api.github.com/users/elasti-ron/received_events","type":"User","site_admin":false},"body":"This pull request is for supporting a discussion, not for merging into the codebase (as per [request](https://github.com/Apipie/apipie-rails/pull/569#issuecomment-354745916) from @iNecas).\r\n\r\nAlso relevant to #273","created_at":"2018-01-02T16:16:54Z","updated_at":"2018-02-26T17:14:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"11e88afb4cd968e3d7ca9165c0a247235caddb6d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Apipie/apipie-rails/pulls/588/commits","review_comments_url":"https://api.github.com/repos/Apipie/apipie-rails/pulls/588/comments","review_comment_url":"https://api.github.com/repos/Apipie/apipie-rails/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Apipie/apipie-rails/issues/588/comments","statuses_url":"https://api.github.com/repos/Apipie/apipie-rails/statuses/4abff6754a555aeb9f6212c6f15c57b0611dba1c","head":{"label":"elasti-ron:describe_responses","ref":"describe_responses","sha":"4abff6754a555aeb9f6212c6f15c57b0611dba1c","user":{"login":"elasti-ron","id":23432602,"avatar_url":"https://avatars2.githubusercontent.com/u/23432602?v=4","gravatar_id":"","url":"https://api.github.com/users/elasti-ron","html_url":"https://github.com/elasti-ron","followers_url":"https://api.github.com/users/elasti-ron/followers","following_url":"https://api.github.com/users/elasti-ron/following{/other_user}","gists_url":"https://api.github.com/users/elasti-ron/gists{/gist_id}","starred_url":"https://api.github.com/users/elasti-ron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elasti-ron/subscriptions","organizations_url":"https://api.github.com/users/elasti-ron/orgs","repos_url":"https://api.github.com/users/elasti-ron/repos","events_url":"https://api.github.com/users/elasti-ron/events{/privacy}","received_events_url":"https://api.github.com/users/elasti-ron/received_events","type":"User","site_admin":false},"repo":{"id":108974721,"name":"apipie-rails","full_name":"elasti-ron/apipie-rails","owner":{"login":"elasti-ron","id":23432602,"avatar_url":"https://avatars2.githubusercontent.com/u/23432602?v=4","gravatar_id":"","url":"https://api.github.com/users/elasti-ron","html_url":"https://github.com/elasti-ron","followers_url":"https://api.github.com/users/elasti-ron/followers","following_url":"https://api.github.com/users/elasti-ron/following{/other_user}","gists_url":"https://api.github.com/users/elasti-ron/gists{/gist_id}","starred_url":"https://api.github.com/users/elasti-ron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elasti-ron/subscriptions","organizations_url":"https://api.github.com/users/elasti-ron/orgs","repos_url":"https://api.github.com/users/elasti-ron/repos","events_url":"https://api.github.com/users/elasti-ron/events{/privacy}","received_events_url":"https://api.github.com/users/elasti-ron/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/elasti-ron/apipie-rails","description":"Ruby on Rails API documentation tool","fork":true,"url":"https://api.github.com/repos/elasti-ron/apipie-rails","forks_url":"https://api.github.com/repos/elasti-ron/apipie-rails/forks","keys_url":"https://api.github.com/repos/elasti-ron/apipie-rails/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elasti-ron/apipie-rails/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elasti-ron/apipie-rails/teams","hooks_url":"https://api.github.com/repos/elasti-ron/apipie-rails/hooks","issue_events_url":"https://api.github.com/repos/elasti-ron/apipie-rails/issues/events{/number}","events_url":"https://api.github.com/repos/elasti-ron/apipie-rails/events","assignees_url":"https://api.github.com/repos/elasti-ron/apipie-rails/assignees{/user}","branches_url":"https://api.github.com/repos/elasti-ron/apipie-rails/branches{/branch}","tags_url":"https://api.github.com/repos/elasti-ron/apipie-rails/tags","blobs_url":"https://api.github.com/repos/elasti-ron/apipie-rails/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elasti-ron/apipie-rails/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elasti-ron/apipie-rails/git/refs{/sha}","trees_url":"https://api.github.com/repos/elasti-ron/apipie-rails/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elasti-ron/apipie-rails/statuses/{sha}","languages_url":"https://api.github.com/repos/elasti-ron/apipie-rails/languages","stargazers_url":"https://api.github.com/repos/elasti-ron/apipie-rails/stargazers","contributors_url":"https://api.github.com/repos/elasti-ron/apipie-rails/contributors","subscribers_url":"https://api.github.com/repos/elasti-ron/apipie-rails/subscribers","subscription_url":"https://api.github.com/repos/elasti-ron/apipie-rails/subscription","commits_url":"https://api.github.com/repos/elasti-ron/apipie-rails/commits{/sha}","git_commits_url":"https://api.github.com/repos/elasti-ron/apipie-rails/git/commits{/sha}","comments_url":"https://api.github.com/repos/elasti-ron/apipie-rails/comments{/number}","issue_comment_url":"https://api.github.com/repos/elasti-ron/apipie-rails/issues/comments{/number}","contents_url":"https://api.github.com/repos/elasti-ron/apipie-rails/contents/{+path}","compare_url":"https://api.github.com/repos/elasti-ron/apipie-rails/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elasti-ron/apipie-rails/merges","archive_url":"https://api.github.com/repos/elasti-ron/apipie-rails/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elasti-ron/apipie-rails/downloads","issues_url":"https://api.github.com/repos/elasti-ron/apipie-rails/issues{/number}","pulls_url":"https://api.github.com/repos/elasti-ron/apipie-rails/pulls{/number}","milestones_url":"https://api.github.com/repos/elasti-ron/apipie-rails/milestones{/number}","notifications_url":"https://api.github.com/repos/elasti-ron/apipie-rails/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elasti-ron/apipie-rails/labels{/name}","releases_url":"https://api.github.com/repos/elasti-ron/apipie-rails/releases{/id}","deployments_url":"https://api.github.com/repos/elasti-ron/apipie-rails/deployments","created_at":"2017-10-31T09:37:49Z","updated_at":"2017-10-31T09:37:52Z","pushed_at":"2018-02-26T15:16:11Z","git_url":"git://github.com/elasti-ron/apipie-rails.git","ssh_url":"[email protected]:elasti-ron/apipie-rails.git","clone_url":"https://github.com/elasti-ron/apipie-rails.git","svn_url":"https://github.com/elasti-ron/apipie-rails","homepage":"","size":2102,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Apipie:master","ref":"master","sha":"75a16bdcef364b5ac76b10fc353f91f86a3b083d","user":{"login":"Apipie","id":6650720,"avatar_url":"https://avatars1.githubusercontent.com/u/6650720?v=4","gravatar_id":"","url":"https://api.github.com/users/Apipie","html_url":"https://github.com/Apipie","followers_url":"https://api.github.com/users/Apipie/followers","following_url":"https://api.github.com/users/Apipie/following{/other_user}","gists_url":"https://api.github.com/users/Apipie/gists{/gist_id}","starred_url":"https://api.github.com/users/Apipie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Apipie/subscriptions","organizations_url":"https://api.github.com/users/Apipie/orgs","repos_url":"https://api.github.com/users/Apipie/repos","events_url":"https://api.github.com/users/Apipie/events{/privacy}","received_events_url":"https://api.github.com/users/Apipie/received_events","type":"Organization","site_admin":false},"repo":{"id":2642653,"name":"apipie-rails","full_name":"Apipie/apipie-rails","owner":{"login":"Apipie","id":6650720,"avatar_url":"https://avatars1.githubusercontent.com/u/6650720?v=4","gravatar_id":"","url":"https://api.github.com/users/Apipie","html_url":"https://github.com/Apipie","followers_url":"https://api.github.com/users/Apipie/followers","following_url":"https://api.github.com/users/Apipie/following{/other_user}","gists_url":"https://api.github.com/users/Apipie/gists{/gist_id}","starred_url":"https://api.github.com/users/Apipie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Apipie/subscriptions","organizations_url":"https://api.github.com/users/Apipie/orgs","repos_url":"https://api.github.com/users/Apipie/repos","events_url":"https://api.github.com/users/Apipie/events{/privacy}","received_events_url":"https://api.github.com/users/Apipie/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Apipie/apipie-rails","description":"Ruby on Rails API documentation tool","fork":false,"url":"https://api.github.com/repos/Apipie/apipie-rails","forks_url":"https://api.github.com/repos/Apipie/apipie-rails/forks","keys_url":"https://api.github.com/repos/Apipie/apipie-rails/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Apipie/apipie-rails/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Apipie/apipie-rails/teams","hooks_url":"https://api.github.com/repos/Apipie/apipie-rails/hooks","issue_events_url":"https://api.github.com/repos/Apipie/apipie-rails/issues/events{/number}","events_url":"https://api.github.com/repos/Apipie/apipie-rails/events","assignees_url":"https://api.github.com/repos/Apipie/apipie-rails/assignees{/user}","branches_url":"https://api.github.com/repos/Apipie/apipie-rails/branches{/branch}","tags_url":"https://api.github.com/repos/Apipie/apipie-rails/tags","blobs_url":"https://api.github.com/repos/Apipie/apipie-rails/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Apipie/apipie-rails/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Apipie/apipie-rails/git/refs{/sha}","trees_url":"https://api.github.com/repos/Apipie/apipie-rails/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Apipie/apipie-rails/statuses/{sha}","languages_url":"https://api.github.com/repos/Apipie/apipie-rails/languages","stargazers_url":"https://api.github.com/repos/Apipie/apipie-rails/stargazers","contributors_url":"https://api.github.com/repos/Apipie/apipie-rails/contributors","subscribers_url":"https://api.github.com/repos/Apipie/apipie-rails/subscribers","subscription_url":"https://api.github.com/repos/Apipie/apipie-rails/subscription","commits_url":"https://api.github.com/repos/Apipie/apipie-rails/commits{/sha}","git_commits_url":"https://api.github.com/repos/Apipie/apipie-rails/git/commits{/sha}","comments_url":"https://api.github.com/repos/Apipie/apipie-rails/comments{/number}","issue_comment_url":"https://api.github.com/repos/Apipie/apipie-rails/issues/comments{/number}","contents_url":"https://api.github.com/repos/Apipie/apipie-rails/contents/{+path}","compare_url":"https://api.github.com/repos/Apipie/apipie-rails/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Apipie/apipie-rails/merges","archive_url":"https://api.github.com/repos/Apipie/apipie-rails/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Apipie/apipie-rails/downloads","issues_url":"https://api.github.com/repos/Apipie/apipie-rails/issues{/number}","pulls_url":"https://api.github.com/repos/Apipie/apipie-rails/pulls{/number}","milestones_url":"https://api.github.com/repos/Apipie/apipie-rails/milestones{/number}","notifications_url":"https://api.github.com/repos/Apipie/apipie-rails/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Apipie/apipie-rails/labels{/name}","releases_url":"https://api.github.com/repos/Apipie/apipie-rails/releases{/id}","deployments_url":"https://api.github.com/repos/Apipie/apipie-rails/deployments","created_at":"2011-10-25T10:31:02Z","updated_at":"2018-02-26T04:30:54Z","pushed_at":"2018-02-26T15:16:13Z","git_url":"git://github.com/Apipie/apipie-rails.git","ssh_url":"[email protected]:Apipie/apipie-rails.git","clone_url":"https://github.com/Apipie/apipie-rails.git","svn_url":"https://github.com/Apipie/apipie-rails","homepage":"","size":1978,"stargazers_count":1737,"watchers_count":1737,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":330,"mirror_url":null,"archived":false,"open_issues_count":199,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":330,"open_issues":199,"watchers":1737,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Apipie/apipie-rails/pulls/588"},"html":{"href":"https://github.com/Apipie/apipie-rails/pull/588"},"issue":{"href":"https://api.github.com/repos/Apipie/apipie-rails/issues/588"},"comments":{"href":"https://api.github.com/repos/Apipie/apipie-rails/issues/588/comments"},"review_comments":{"href":"https://api.github.com/repos/Apipie/apipie-rails/pulls/588/comments"},"review_comment":{"href":"https://api.github.com/repos/Apipie/apipie-rails/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Apipie/apipie-rails/pulls/588/commits"},"statuses":{"href":"https://api.github.com/repos/Apipie/apipie-rails/statuses/4abff6754a555aeb9f6212c6f15c57b0611dba1c"}},"author_association":"CONTRIBUTOR"}} | {
"id": 2642653,
"name": "Apipie/apipie-rails",
"url": "https://api.github.com/repos/Apipie/apipie-rails"
} | {
"id": 190443,
"login": "iNecas",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/190443?",
"url": "https://api.github.com/users/iNecas"
} | {
"id": 6650720,
"login": "Apipie",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6650720?",
"url": "https://api.github.com/orgs/Apipie"
} | 2018-02-26T17:08:08 | 7298503676 | {"actor":{"display_login":"iNecas"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/vindi/vindi-magento/pulls/comments/222485933","pull_request_review_id":161385026,"id":222485933,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMjQ4NTkzMw==","diff_hunk":"@@ -0,0 +1,64 @@\n+<?php\n+\n+namespace Magium\\Magento\\Extractors\\Admin\\Widget;\n+\n+use Facebook\\WebDriver\\WebDriverBy;\n+use Facebook\\WebDriver\\WebDriverElement;\n+use Magium\\AbstractTestCase;\n+use Magium\\Extractors\\AbstractExtractor;\n+use Magium\\Magento\\InvalidFormatException;\n+use Magium\\Magento\\Navigators\\Admin\\Widget\\Tab;\n+use Magium\\Magento\\Themes\\Admin\\ThemeConfiguration;\n+use Magium\\WebDriver\\WebDriver;\n+\n+class Attribute extends AbstractExtractor\n+{\n+ const EXTRACTOR = 'Admin\\Widget\\Attribute';\n+\n+ protected $element;\n+ protected $label;\n+ protected $navigator;\n+\n+ public function __construct(\n+ WebDriver $webDriver,\n+ AbstractTestCase $testCase,\n+ ThemeConfiguration $theme,\n+ Tab $navigator\n+ )\n+ {\n+ parent::__construct($webDriver, $testCase, $theme);\n+ $this->navigator = $navigator;\n+ }\n+\n+ /**\n+ * @param $label\n+ * @return WebDriverElement\n+ */\n+\n+ public function getElementByLabel($label)\n+ {\n+ $label = explode('::', $label);\n+ if (count($label) > 2) {\n+ throw new InvalidFormatException('The label must have two or fewer components');\n+ } else if (count($label) == 2) {\n+ $this->navigator->navigateTo(array_shift($label));\n+ }\n+ $this->label = array_shift($label);\n+ $this->extract();\n+ return $this->element;\n+ }\n+\n+ public function extract()\n+ {\n+ $xpath = $this->theme->getWidgetAttributeByLabelXpath($this->label);\n+ $elements = $this->webDriver->findElements(WebDriverBy::xpath($xpath));","path":"app/code/community/Vindi/Subscription/tests/lib/Magento/Extractors/Admin/Widget/Attribute.php","position":54,"original_position":54,"commit_id":"7a56dc0f3465f7769aea4653931bd904cb180893","original_commit_id":"7a56dc0f3465f7769aea4653931bd904cb180893","user":{"login":"codacy-bot","id":19940114,"node_id":"MDQ6VXNlcjE5OTQwMTE0","avatar_url":"https://avatars1.githubusercontent.com/u/19940114?v=4","gravatar_id":"","url":"https://api.github.com/users/codacy-bot","html_url":"https://github.com/codacy-bot","followers_url":"https://api.github.com/users/codacy-bot/followers","following_url":"https://api.github.com/users/codacy-bot/following{/other_user}","gists_url":"https://api.github.com/users/codacy-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/codacy-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codacy-bot/subscriptions","organizations_url":"https://api.github.com/users/codacy-bot/orgs","repos_url":"https://api.github.com/users/codacy-bot/repos","events_url":"https://api.github.com/users/codacy-bot/events{/privacy}","received_events_url":"https://api.github.com/users/codacy-bot/received_events","type":"User","site_admin":false},"body":" Issue found: [Avoid using static access to class '\\Facebook\\WebDriver\\WebDriverBy' in method 'extract'.](https://app.codacy.com/app/rtakauti/vindi-magento/pullRequest?prid=2283024)","created_at":"2018-10-03T22:18:48Z","updated_at":"2018-10-03T22:18:48Z","html_url":"https://github.com/vindi/vindi-magento/pull/80#discussion_r222485933","pull_request_url":"https://api.github.com/repos/vindi/vindi-magento/pulls/80","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/vindi/vindi-magento/pulls/comments/222485933"},"html":{"href":"https://github.com/vindi/vindi-magento/pull/80#discussion_r222485933"},"pull_request":{"href":"https://api.github.com/repos/vindi/vindi-magento/pulls/80"}}},"pull_request":{"url":"https://api.github.com/repos/vindi/vindi-magento/pulls/80","id":219487220,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5NDg3MjIw","html_url":"https://github.com/vindi/vindi-magento/pull/80","diff_url":"https://github.com/vindi/vindi-magento/pull/80.diff","patch_url":"https://github.com/vindi/vindi-magento/pull/80.patch","issue_url":"https://api.github.com/repos/vindi/vindi-magento/issues/80","number":80,"state":"open","locked":false,"title":"Ajusta infraestrutura de teste","user":{"login":"rtakauti","id":5501740,"node_id":"MDQ6VXNlcjU1MDE3NDA=","avatar_url":"https://avatars3.githubusercontent.com/u/5501740?v=4","gravatar_id":"","url":"https://api.github.com/users/rtakauti","html_url":"https://github.com/rtakauti","followers_url":"https://api.github.com/users/rtakauti/followers","following_url":"https://api.github.com/users/rtakauti/following{/other_user}","gists_url":"https://api.github.com/users/rtakauti/gists{/gist_id}","starred_url":"https://api.github.com/users/rtakauti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rtakauti/subscriptions","organizations_url":"https://api.github.com/users/rtakauti/orgs","repos_url":"https://api.github.com/users/rtakauti/repos","events_url":"https://api.github.com/users/rtakauti/events{/privacy}","received_events_url":"https://api.github.com/users/rtakauti/received_events","type":"User","site_admin":false},"body":"# Motivação\nAjustar infraestrutura de teste para rodar em ambiente SemaphoreCI\n\n# Solução proposta\nMudanças no phpunit para estabelecer uma estrutura estável","created_at":"2018-10-01T19:23:46Z","updated_at":"2018-10-03T22:18:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9f38326933c21255f6a1649ddea83ca086e0634e","assignee":{"login":"rtakauti","id":5501740,"node_id":"MDQ6VXNlcjU1MDE3NDA=","avatar_url":"https://avatars3.githubusercontent.com/u/5501740?v=4","gravatar_id":"","url":"https://api.github.com/users/rtakauti","html_url":"https://github.com/rtakauti","followers_url":"https://api.github.com/users/rtakauti/followers","following_url":"https://api.github.com/users/rtakauti/following{/other_user}","gists_url":"https://api.github.com/users/rtakauti/gists{/gist_id}","starred_url":"https://api.github.com/users/rtakauti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rtakauti/subscriptions","organizations_url":"https://api.github.com/users/rtakauti/orgs","repos_url":"https://api.github.com/users/rtakauti/repos","events_url":"https://api.github.com/users/rtakauti/events{/privacy}","received_events_url":"https://api.github.com/users/rtakauti/received_events","type":"User","site_admin":false},"assignees":[{"login":"rtakauti","id":5501740,"node_id":"MDQ6VXNlcjU1MDE3NDA=","avatar_url":"https://avatars3.githubusercontent.com/u/5501740?v=4","gravatar_id":"","url":"https://api.github.com/users/rtakauti","html_url":"https://github.com/rtakauti","followers_url":"https://api.github.com/users/rtakauti/followers","following_url":"https://api.github.com/users/rtakauti/following{/other_user}","gists_url":"https://api.github.com/users/rtakauti/gists{/gist_id}","starred_url":"https://api.github.com/users/rtakauti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rtakauti/subscriptions","organizations_url":"https://api.github.com/users/rtakauti/orgs","repos_url":"https://api.github.com/users/rtakauti/repos","events_url":"https://api.github.com/users/rtakauti/events{/privacy}","received_events_url":"https://api.github.com/users/rtakauti/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"lyoncesar","id":15332442,"node_id":"MDQ6VXNlcjE1MzMyNDQy","avatar_url":"https://avatars3.githubusercontent.com/u/15332442?v=4","gravatar_id":"","url":"https://api.github.com/users/lyoncesar","html_url":"https://github.com/lyoncesar","followers_url":"https://api.github.com/users/lyoncesar/followers","following_url":"https://api.github.com/users/lyoncesar/following{/other_user}","gists_url":"https://api.github.com/users/lyoncesar/gists{/gist_id}","starred_url":"https://api.github.com/users/lyoncesar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lyoncesar/subscriptions","organizations_url":"https://api.github.com/users/lyoncesar/orgs","repos_url":"https://api.github.com/users/lyoncesar/repos","events_url":"https://api.github.com/users/lyoncesar/events{/privacy}","received_events_url":"https://api.github.com/users/lyoncesar/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":226637310,"node_id":"MDU6TGFiZWwyMjY2MzczMTA=","url":"https://api.github.com/repos/vindi/vindi-magento/labels/melhoria%20:wrench:","name":"melhoria :wrench:","color":"add0f4","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/vindi/vindi-magento/pulls/80/commits","review_comments_url":"https://api.github.com/repos/vindi/vindi-magento/pulls/80/comments","review_comment_url":"https://api.github.com/repos/vindi/vindi-magento/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vindi/vindi-magento/issues/80/comments","statuses_url":"https://api.github.com/repos/vindi/vindi-magento/statuses/7a56dc0f3465f7769aea4653931bd904cb180893","head":{"label":"vindi:develop","ref":"develop","sha":"7a56dc0f3465f7769aea4653931bd904cb180893","user":{"login":"vindi","id":6664923,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY2NjQ5MjM=","avatar_url":"https://avatars3.githubusercontent.com/u/6664923?v=4","gravatar_id":"","url":"https://api.github.com/users/vindi","html_url":"https://github.com/vindi","followers_url":"https://api.github.com/users/vindi/followers","following_url":"https://api.github.com/users/vindi/following{/other_user}","gists_url":"https://api.github.com/users/vindi/gists{/gist_id}","starred_url":"https://api.github.com/users/vindi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vindi/subscriptions","organizations_url":"https://api.github.com/users/vindi/orgs","repos_url":"https://api.github.com/users/vindi/repos","events_url":"https://api.github.com/users/vindi/events{/privacy}","received_events_url":"https://api.github.com/users/vindi/received_events","type":"Organization","site_admin":false},"repo":{"id":37740683,"node_id":"MDEwOlJlcG9zaXRvcnkzNzc0MDY4Mw==","name":"vindi-magento","full_name":"vindi/vindi-magento","private":false,"owner":{"login":"vindi","id":6664923,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY2NjQ5MjM=","avatar_url":"https://avatars3.githubusercontent.com/u/6664923?v=4","gravatar_id":"","url":"https://api.github.com/users/vindi","html_url":"https://github.com/vindi","followers_url":"https://api.github.com/users/vindi/followers","following_url":"https://api.github.com/users/vindi/following{/other_user}","gists_url":"https://api.github.com/users/vindi/gists{/gist_id}","starred_url":"https://api.github.com/users/vindi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vindi/subscriptions","organizations_url":"https://api.github.com/users/vindi/orgs","repos_url":"https://api.github.com/users/vindi/repos","events_url":"https://api.github.com/users/vindi/events{/privacy}","received_events_url":"https://api.github.com/users/vindi/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/vindi/vindi-magento","description":"Módulo de cobrança recorrente para Magento","fork":false,"url":"https://api.github.com/repos/vindi/vindi-magento","forks_url":"https://api.github.com/repos/vindi/vindi-magento/forks","keys_url":"https://api.github.com/repos/vindi/vindi-magento/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vindi/vindi-magento/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vindi/vindi-magento/teams","hooks_url":"https://api.github.com/repos/vindi/vindi-magento/hooks","issue_events_url":"https://api.github.com/repos/vindi/vindi-magento/issues/events{/number}","events_url":"https://api.github.com/repos/vindi/vindi-magento/events","assignees_url":"https://api.github.com/repos/vindi/vindi-magento/assignees{/user}","branches_url":"https://api.github.com/repos/vindi/vindi-magento/branches{/branch}","tags_url":"https://api.github.com/repos/vindi/vindi-magento/tags","blobs_url":"https://api.github.com/repos/vindi/vindi-magento/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vindi/vindi-magento/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vindi/vindi-magento/git/refs{/sha}","trees_url":"https://api.github.com/repos/vindi/vindi-magento/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vindi/vindi-magento/statuses/{sha}","languages_url":"https://api.github.com/repos/vindi/vindi-magento/languages","stargazers_url":"https://api.github.com/repos/vindi/vindi-magento/stargazers","contributors_url":"https://api.github.com/repos/vindi/vindi-magento/contributors","subscribers_url":"https://api.github.com/repos/vindi/vindi-magento/subscribers","subscription_url":"https://api.github.com/repos/vindi/vindi-magento/subscription","commits_url":"https://api.github.com/repos/vindi/vindi-magento/commits{/sha}","git_commits_url":"https://api.github.com/repos/vindi/vindi-magento/git/commits{/sha}","comments_url":"https://api.github.com/repos/vindi/vindi-magento/comments{/number}","issue_comment_url":"https://api.github.com/repos/vindi/vindi-magento/issues/comments{/number}","contents_url":"https://api.github.com/repos/vindi/vindi-magento/contents/{+path}","compare_url":"https://api.github.com/repos/vindi/vindi-magento/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vindi/vindi-magento/merges","archive_url":"https://api.github.com/repos/vindi/vindi-magento/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vindi/vindi-magento/downloads","issues_url":"https://api.github.com/repos/vindi/vindi-magento/issues{/number}","pulls_url":"https://api.github.com/repos/vindi/vindi-magento/pulls{/number}","milestones_url":"https://api.github.com/repos/vindi/vindi-magento/milestones{/number}","notifications_url":"https://api.github.com/repos/vindi/vindi-magento/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vindi/vindi-magento/labels{/name}","releases_url":"https://api.github.com/repos/vindi/vindi-magento/releases{/id}","deployments_url":"https://api.github.com/repos/vindi/vindi-magento/deployments","created_at":"2015-06-19T19:05:36Z","updated_at":"2018-10-03T16:53:28Z","pushed_at":"2018-10-03T20:38:17Z","git_url":"git://github.com/vindi/vindi-magento.git","ssh_url":"[email protected]:vindi/vindi-magento.git","clone_url":"https://github.com/vindi/vindi-magento.git","svn_url":"https://github.com/vindi/vindi-magento","homepage":"https://www.vindi.com.br","size":461,"stargazers_count":9,"watchers_count":9,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":13,"open_issues":2,"watchers":9,"default_branch":"master"}},"base":{"label":"vindi:master","ref":"master","sha":"2af8502e3addc8cb4c2146245c2a636f91787762","user":{"login":"vindi","id":6664923,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY2NjQ5MjM=","avatar_url":"https://avatars3.githubusercontent.com/u/6664923?v=4","gravatar_id":"","url":"https://api.github.com/users/vindi","html_url":"https://github.com/vindi","followers_url":"https://api.github.com/users/vindi/followers","following_url":"https://api.github.com/users/vindi/following{/other_user}","gists_url":"https://api.github.com/users/vindi/gists{/gist_id}","starred_url":"https://api.github.com/users/vindi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vindi/subscriptions","organizations_url":"https://api.github.com/users/vindi/orgs","repos_url":"https://api.github.com/users/vindi/repos","events_url":"https://api.github.com/users/vindi/events{/privacy}","received_events_url":"https://api.github.com/users/vindi/received_events","type":"Organization","site_admin":false},"repo":{"id":37740683,"node_id":"MDEwOlJlcG9zaXRvcnkzNzc0MDY4Mw==","name":"vindi-magento","full_name":"vindi/vindi-magento","private":false,"owner":{"login":"vindi","id":6664923,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY2NjQ5MjM=","avatar_url":"https://avatars3.githubusercontent.com/u/6664923?v=4","gravatar_id":"","url":"https://api.github.com/users/vindi","html_url":"https://github.com/vindi","followers_url":"https://api.github.com/users/vindi/followers","following_url":"https://api.github.com/users/vindi/following{/other_user}","gists_url":"https://api.github.com/users/vindi/gists{/gist_id}","starred_url":"https://api.github.com/users/vindi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vindi/subscriptions","organizations_url":"https://api.github.com/users/vindi/orgs","repos_url":"https://api.github.com/users/vindi/repos","events_url":"https://api.github.com/users/vindi/events{/privacy}","received_events_url":"https://api.github.com/users/vindi/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/vindi/vindi-magento","description":"Módulo de cobrança recorrente para Magento","fork":false,"url":"https://api.github.com/repos/vindi/vindi-magento","forks_url":"https://api.github.com/repos/vindi/vindi-magento/forks","keys_url":"https://api.github.com/repos/vindi/vindi-magento/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vindi/vindi-magento/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vindi/vindi-magento/teams","hooks_url":"https://api.github.com/repos/vindi/vindi-magento/hooks","issue_events_url":"https://api.github.com/repos/vindi/vindi-magento/issues/events{/number}","events_url":"https://api.github.com/repos/vindi/vindi-magento/events","assignees_url":"https://api.github.com/repos/vindi/vindi-magento/assignees{/user}","branches_url":"https://api.github.com/repos/vindi/vindi-magento/branches{/branch}","tags_url":"https://api.github.com/repos/vindi/vindi-magento/tags","blobs_url":"https://api.github.com/repos/vindi/vindi-magento/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vindi/vindi-magento/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vindi/vindi-magento/git/refs{/sha}","trees_url":"https://api.github.com/repos/vindi/vindi-magento/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vindi/vindi-magento/statuses/{sha}","languages_url":"https://api.github.com/repos/vindi/vindi-magento/languages","stargazers_url":"https://api.github.com/repos/vindi/vindi-magento/stargazers","contributors_url":"https://api.github.com/repos/vindi/vindi-magento/contributors","subscribers_url":"https://api.github.com/repos/vindi/vindi-magento/subscribers","subscription_url":"https://api.github.com/repos/vindi/vindi-magento/subscription","commits_url":"https://api.github.com/repos/vindi/vindi-magento/commits{/sha}","git_commits_url":"https://api.github.com/repos/vindi/vindi-magento/git/commits{/sha}","comments_url":"https://api.github.com/repos/vindi/vindi-magento/comments{/number}","issue_comment_url":"https://api.github.com/repos/vindi/vindi-magento/issues/comments{/number}","contents_url":"https://api.github.com/repos/vindi/vindi-magento/contents/{+path}","compare_url":"https://api.github.com/repos/vindi/vindi-magento/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vindi/vindi-magento/merges","archive_url":"https://api.github.com/repos/vindi/vindi-magento/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vindi/vindi-magento/downloads","issues_url":"https://api.github.com/repos/vindi/vindi-magento/issues{/number}","pulls_url":"https://api.github.com/repos/vindi/vindi-magento/pulls{/number}","milestones_url":"https://api.github.com/repos/vindi/vindi-magento/milestones{/number}","notifications_url":"https://api.github.com/repos/vindi/vindi-magento/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vindi/vindi-magento/labels{/name}","releases_url":"https://api.github.com/repos/vindi/vindi-magento/releases{/id}","deployments_url":"https://api.github.com/repos/vindi/vindi-magento/deployments","created_at":"2015-06-19T19:05:36Z","updated_at":"2018-10-03T16:53:28Z","pushed_at":"2018-10-03T20:38:17Z","git_url":"git://github.com/vindi/vindi-magento.git","ssh_url":"[email protected]:vindi/vindi-magento.git","clone_url":"https://github.com/vindi/vindi-magento.git","svn_url":"https://github.com/vindi/vindi-magento","homepage":"https://www.vindi.com.br","size":461,"stargazers_count":9,"watchers_count":9,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":13,"open_issues":2,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vindi/vindi-magento/pulls/80"},"html":{"href":"https://github.com/vindi/vindi-magento/pull/80"},"issue":{"href":"https://api.github.com/repos/vindi/vindi-magento/issues/80"},"comments":{"href":"https://api.github.com/repos/vindi/vindi-magento/issues/80/comments"},"review_comments":{"href":"https://api.github.com/repos/vindi/vindi-magento/pulls/80/comments"},"review_comment":{"href":"https://api.github.com/repos/vindi/vindi-magento/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vindi/vindi-magento/pulls/80/commits"},"statuses":{"href":"https://api.github.com/repos/vindi/vindi-magento/statuses/7a56dc0f3465f7769aea4653931bd904cb180893"}},"author_association":"COLLABORATOR"}} | {
"id": 37740683,
"name": "vindi/vindi-magento",
"url": "https://api.github.com/repos/vindi/vindi-magento"
} | {
"id": 19940114,
"login": "codacy-bot",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/19940114?",
"url": "https://api.github.com/users/codacy-bot"
} | {
"id": 6664923,
"login": "vindi",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6664923?",
"url": "https://api.github.com/orgs/vindi"
} | 2018-10-03T22:18:48 | 8364274674 | {"actor":{"display_login":"codacy-bot"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/connexta/saml-conformance/pulls/comments/177133548","pull_request_review_id":106953946,"id":177133548,"diff_hunk":"@@ -30,17 +30,24 @@ import org.codice.compliance.utils.TestCommon.Companion.ID\n import org.codice.compliance.utils.TestCommon.Companion.SP_ISSUER\n import org.codice.compliance.utils.TestCommon.Companion.idpMetadata\n import org.opensaml.saml.saml2.metadata.impl.EntityDescriptorImpl\n+import org.slf4j.LoggerFactory\n import org.w3c.dom.Node\n \n class SingleSignOnProfileVerifier(private val response: Node, private val acsUrl: String?) {\n+ companion object {\n+ private val logger = LoggerFactory.getLogger(SingleSignOnProfileVerifier::class.java)\n+ }","path":"test/common/src/main/kotlin/org/codice/compliance/verification/profile/SingleSignOnProfileVerifier.kt","position":10,"original_position":10,"commit_id":"5a924f0619f38e2576e1ea4201e59b25f598b5fe","original_commit_id":"5a924f0619f38e2576e1ea4201e59b25f598b5fe","user":{"login":"blen-desta","id":29550062,"avatar_url":"https://avatars0.githubusercontent.com/u/29550062?v=4","gravatar_id":"","url":"https://api.github.com/users/blen-desta","html_url":"https://github.com/blen-desta","followers_url":"https://api.github.com/users/blen-desta/followers","following_url":"https://api.github.com/users/blen-desta/following{/other_user}","gists_url":"https://api.github.com/users/blen-desta/gists{/gist_id}","starred_url":"https://api.github.com/users/blen-desta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blen-desta/subscriptions","organizations_url":"https://api.github.com/users/blen-desta/orgs","repos_url":"https://api.github.com/users/blen-desta/repos","events_url":"https://api.github.com/users/blen-desta/events{/privacy}","received_events_url":"https://api.github.com/users/blen-desta/received_events","type":"User","site_admin":false},"body":"😞 My bad that's leftover code from my many attempts at using other debuggers.","created_at":"2018-03-26T15:28:39Z","updated_at":"2018-03-26T15:28:39Z","html_url":"https://github.com/connexta/saml-conformance/pull/31#discussion_r177133548","pull_request_url":"https://api.github.com/repos/connexta/saml-conformance/pulls/31","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/connexta/saml-conformance/pulls/comments/177133548"},"html":{"href":"https://github.com/connexta/saml-conformance/pull/31#discussion_r177133548"},"pull_request":{"href":"https://api.github.com/repos/connexta/saml-conformance/pulls/31"}},"in_reply_to_id":177121538},"pull_request":{"url":"https://api.github.com/repos/connexta/saml-conformance/pulls/31","id":176940052,"html_url":"https://github.com/connexta/saml-conformance/pull/31","diff_url":"https://github.com/connexta/saml-conformance/pull/31.diff","patch_url":"https://github.com/connexta/saml-conformance/pull/31.patch","issue_url":"https://api.github.com/repos/connexta/saml-conformance/issues/31","number":31,"state":"open","locked":false,"title":"Added debug logging","user":{"login":"blen-desta","id":29550062,"avatar_url":"https://avatars0.githubusercontent.com/u/29550062?v=4","gravatar_id":"","url":"https://api.github.com/users/blen-desta","html_url":"https://github.com/blen-desta","followers_url":"https://api.github.com/users/blen-desta/followers","following_url":"https://api.github.com/users/blen-desta/following{/other_user}","gists_url":"https://api.github.com/users/blen-desta/gists{/gist_id}","starred_url":"https://api.github.com/users/blen-desta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blen-desta/subscriptions","organizations_url":"https://api.github.com/users/blen-desta/orgs","repos_url":"https://api.github.com/users/blen-desta/repos","events_url":"https://api.github.com/users/blen-desta/events{/privacy}","received_events_url":"https://api.github.com/users/blen-desta/received_events","type":"User","site_admin":false},"body":"I am using [StaticLog](https://github.com/jupf/staticlog#logging-in-kotlin) which I found on [awsom-kotlin](https://github.com/KotlinBy/awesome-kotlin).","created_at":"2018-03-22T23:51:12Z","updated_at":"2018-03-26T15:28:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2eedecbd76ec55cb422c5f7082ae7b69aedff473","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/connexta/saml-conformance/pulls/31/commits","review_comments_url":"https://api.github.com/repos/connexta/saml-conformance/pulls/31/comments","review_comment_url":"https://api.github.com/repos/connexta/saml-conformance/pulls/comments{/number}","comments_url":"https://api.github.com/repos/connexta/saml-conformance/issues/31/comments","statuses_url":"https://api.github.com/repos/connexta/saml-conformance/statuses/5a924f0619f38e2576e1ea4201e59b25f598b5fe","head":{"label":"blen-desta:logging","ref":"logging","sha":"5a924f0619f38e2576e1ea4201e59b25f598b5fe","user":{"login":"blen-desta","id":29550062,"avatar_url":"https://avatars0.githubusercontent.com/u/29550062?v=4","gravatar_id":"","url":"https://api.github.com/users/blen-desta","html_url":"https://github.com/blen-desta","followers_url":"https://api.github.com/users/blen-desta/followers","following_url":"https://api.github.com/users/blen-desta/following{/other_user}","gists_url":"https://api.github.com/users/blen-desta/gists{/gist_id}","starred_url":"https://api.github.com/users/blen-desta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blen-desta/subscriptions","organizations_url":"https://api.github.com/users/blen-desta/orgs","repos_url":"https://api.github.com/users/blen-desta/repos","events_url":"https://api.github.com/users/blen-desta/events{/privacy}","received_events_url":"https://api.github.com/users/blen-desta/received_events","type":"User","site_admin":false},"repo":{"id":126052431,"name":"saml-conformance","full_name":"blen-desta/saml-conformance","owner":{"login":"blen-desta","id":29550062,"avatar_url":"https://avatars0.githubusercontent.com/u/29550062?v=4","gravatar_id":"","url":"https://api.github.com/users/blen-desta","html_url":"https://github.com/blen-desta","followers_url":"https://api.github.com/users/blen-desta/followers","following_url":"https://api.github.com/users/blen-desta/following{/other_user}","gists_url":"https://api.github.com/users/blen-desta/gists{/gist_id}","starred_url":"https://api.github.com/users/blen-desta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blen-desta/subscriptions","organizations_url":"https://api.github.com/users/blen-desta/orgs","repos_url":"https://api.github.com/users/blen-desta/repos","events_url":"https://api.github.com/users/blen-desta/events{/privacy}","received_events_url":"https://api.github.com/users/blen-desta/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/blen-desta/saml-conformance","description":null,"fork":true,"url":"https://api.github.com/repos/blen-desta/saml-conformance","forks_url":"https://api.github.com/repos/blen-desta/saml-conformance/forks","keys_url":"https://api.github.com/repos/blen-desta/saml-conformance/keys{/key_id}","collaborators_url":"https://api.github.com/repos/blen-desta/saml-conformance/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/blen-desta/saml-conformance/teams","hooks_url":"https://api.github.com/repos/blen-desta/saml-conformance/hooks","issue_events_url":"https://api.github.com/repos/blen-desta/saml-conformance/issues/events{/number}","events_url":"https://api.github.com/repos/blen-desta/saml-conformance/events","assignees_url":"https://api.github.com/repos/blen-desta/saml-conformance/assignees{/user}","branches_url":"https://api.github.com/repos/blen-desta/saml-conformance/branches{/branch}","tags_url":"https://api.github.com/repos/blen-desta/saml-conformance/tags","blobs_url":"https://api.github.com/repos/blen-desta/saml-conformance/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/blen-desta/saml-conformance/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/blen-desta/saml-conformance/git/refs{/sha}","trees_url":"https://api.github.com/repos/blen-desta/saml-conformance/git/trees{/sha}","statuses_url":"https://api.github.com/repos/blen-desta/saml-conformance/statuses/{sha}","languages_url":"https://api.github.com/repos/blen-desta/saml-conformance/languages","stargazers_url":"https://api.github.com/repos/blen-desta/saml-conformance/stargazers","contributors_url":"https://api.github.com/repos/blen-desta/saml-conformance/contributors","subscribers_url":"https://api.github.com/repos/blen-desta/saml-conformance/subscribers","subscription_url":"https://api.github.com/repos/blen-desta/saml-conformance/subscription","commits_url":"https://api.github.com/repos/blen-desta/saml-conformance/commits{/sha}","git_commits_url":"https://api.github.com/repos/blen-desta/saml-conformance/git/commits{/sha}","comments_url":"https://api.github.com/repos/blen-desta/saml-conformance/comments{/number}","issue_comment_url":"https://api.github.com/repos/blen-desta/saml-conformance/issues/comments{/number}","contents_url":"https://api.github.com/repos/blen-desta/saml-conformance/contents/{+path}","compare_url":"https://api.github.com/repos/blen-desta/saml-conformance/compare/{base}...{head}","merges_url":"https://api.github.com/repos/blen-desta/saml-conformance/merges","archive_url":"https://api.github.com/repos/blen-desta/saml-conformance/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/blen-desta/saml-conformance/downloads","issues_url":"https://api.github.com/repos/blen-desta/saml-conformance/issues{/number}","pulls_url":"https://api.github.com/repos/blen-desta/saml-conformance/pulls{/number}","milestones_url":"https://api.github.com/repos/blen-desta/saml-conformance/milestones{/number}","notifications_url":"https://api.github.com/repos/blen-desta/saml-conformance/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/blen-desta/saml-conformance/labels{/name}","releases_url":"https://api.github.com/repos/blen-desta/saml-conformance/releases{/id}","deployments_url":"https://api.github.com/repos/blen-desta/saml-conformance/deployments","created_at":"2018-03-20T16:57:12Z","updated_at":"2018-03-20T16:57:14Z","pushed_at":"2018-03-22T23:48:38Z","git_url":"git://github.com/blen-desta/saml-conformance.git","ssh_url":"[email protected]:blen-desta/saml-conformance.git","clone_url":"https://github.com/blen-desta/saml-conformance.git","svn_url":"https://github.com/blen-desta/saml-conformance","homepage":null,"size":501,"stargazers_count":0,"watchers_count":0,"language":"Kotlin","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"connexta:master","ref":"master","sha":"d1e6327764a4db094a4a70f10bab799c7440e895","user":{"login":"connexta","id":6706726,"avatar_url":"https://avatars3.githubusercontent.com/u/6706726?v=4","gravatar_id":"","url":"https://api.github.com/users/connexta","html_url":"https://github.com/connexta","followers_url":"https://api.github.com/users/connexta/followers","following_url":"https://api.github.com/users/connexta/following{/other_user}","gists_url":"https://api.github.com/users/connexta/gists{/gist_id}","starred_url":"https://api.github.com/users/connexta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/connexta/subscriptions","organizations_url":"https://api.github.com/users/connexta/orgs","repos_url":"https://api.github.com/users/connexta/repos","events_url":"https://api.github.com/users/connexta/events{/privacy}","received_events_url":"https://api.github.com/users/connexta/received_events","type":"Organization","site_admin":false},"repo":{"id":121804316,"name":"saml-conformance","full_name":"connexta/saml-conformance","owner":{"login":"connexta","id":6706726,"avatar_url":"https://avatars3.githubusercontent.com/u/6706726?v=4","gravatar_id":"","url":"https://api.github.com/users/connexta","html_url":"https://github.com/connexta","followers_url":"https://api.github.com/users/connexta/followers","following_url":"https://api.github.com/users/connexta/following{/other_user}","gists_url":"https://api.github.com/users/connexta/gists{/gist_id}","starred_url":"https://api.github.com/users/connexta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/connexta/subscriptions","organizations_url":"https://api.github.com/users/connexta/orgs","repos_url":"https://api.github.com/users/connexta/repos","events_url":"https://api.github.com/users/connexta/events{/privacy}","received_events_url":"https://api.github.com/users/connexta/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/connexta/saml-conformance","description":null,"fork":false,"url":"https://api.github.com/repos/connexta/saml-conformance","forks_url":"https://api.github.com/repos/connexta/saml-conformance/forks","keys_url":"https://api.github.com/repos/connexta/saml-conformance/keys{/key_id}","collaborators_url":"https://api.github.com/repos/connexta/saml-conformance/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/connexta/saml-conformance/teams","hooks_url":"https://api.github.com/repos/connexta/saml-conformance/hooks","issue_events_url":"https://api.github.com/repos/connexta/saml-conformance/issues/events{/number}","events_url":"https://api.github.com/repos/connexta/saml-conformance/events","assignees_url":"https://api.github.com/repos/connexta/saml-conformance/assignees{/user}","branches_url":"https://api.github.com/repos/connexta/saml-conformance/branches{/branch}","tags_url":"https://api.github.com/repos/connexta/saml-conformance/tags","blobs_url":"https://api.github.com/repos/connexta/saml-conformance/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/connexta/saml-conformance/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/connexta/saml-conformance/git/refs{/sha}","trees_url":"https://api.github.com/repos/connexta/saml-conformance/git/trees{/sha}","statuses_url":"https://api.github.com/repos/connexta/saml-conformance/statuses/{sha}","languages_url":"https://api.github.com/repos/connexta/saml-conformance/languages","stargazers_url":"https://api.github.com/repos/connexta/saml-conformance/stargazers","contributors_url":"https://api.github.com/repos/connexta/saml-conformance/contributors","subscribers_url":"https://api.github.com/repos/connexta/saml-conformance/subscribers","subscription_url":"https://api.github.com/repos/connexta/saml-conformance/subscription","commits_url":"https://api.github.com/repos/connexta/saml-conformance/commits{/sha}","git_commits_url":"https://api.github.com/repos/connexta/saml-conformance/git/commits{/sha}","comments_url":"https://api.github.com/repos/connexta/saml-conformance/comments{/number}","issue_comment_url":"https://api.github.com/repos/connexta/saml-conformance/issues/comments{/number}","contents_url":"https://api.github.com/repos/connexta/saml-conformance/contents/{+path}","compare_url":"https://api.github.com/repos/connexta/saml-conformance/compare/{base}...{head}","merges_url":"https://api.github.com/repos/connexta/saml-conformance/merges","archive_url":"https://api.github.com/repos/connexta/saml-conformance/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/connexta/saml-conformance/downloads","issues_url":"https://api.github.com/repos/connexta/saml-conformance/issues{/number}","pulls_url":"https://api.github.com/repos/connexta/saml-conformance/pulls{/number}","milestones_url":"https://api.github.com/repos/connexta/saml-conformance/milestones{/number}","notifications_url":"https://api.github.com/repos/connexta/saml-conformance/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/connexta/saml-conformance/labels{/name}","releases_url":"https://api.github.com/repos/connexta/saml-conformance/releases{/id}","deployments_url":"https://api.github.com/repos/connexta/saml-conformance/deployments","created_at":"2018-02-16T21:48:23Z","updated_at":"2018-03-22T19:37:10Z","pushed_at":"2018-03-23T00:39:44Z","git_url":"git://github.com/connexta/saml-conformance.git","ssh_url":"[email protected]:connexta/saml-conformance.git","clone_url":"https://github.com/connexta/saml-conformance.git","svn_url":"https://github.com/connexta/saml-conformance","homepage":null,"size":496,"stargazers_count":1,"watchers_count":1,"language":"Kotlin","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":3,"license":null,"forks":5,"open_issues":3,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/connexta/saml-conformance/pulls/31"},"html":{"href":"https://github.com/connexta/saml-conformance/pull/31"},"issue":{"href":"https://api.github.com/repos/connexta/saml-conformance/issues/31"},"comments":{"href":"https://api.github.com/repos/connexta/saml-conformance/issues/31/comments"},"review_comments":{"href":"https://api.github.com/repos/connexta/saml-conformance/pulls/31/comments"},"review_comment":{"href":"https://api.github.com/repos/connexta/saml-conformance/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/connexta/saml-conformance/pulls/31/commits"},"statuses":{"href":"https://api.github.com/repos/connexta/saml-conformance/statuses/5a924f0619f38e2576e1ea4201e59b25f598b5fe"}},"author_association":"COLLABORATOR"}} | {
"id": 121804316,
"name": "connexta/saml-conformance",
"url": "https://api.github.com/repos/connexta/saml-conformance"
} | {
"id": 29550062,
"login": "blen-desta",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/29550062?",
"url": "https://api.github.com/users/blen-desta"
} | {
"id": 6706726,
"login": "connexta",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6706726?",
"url": "https://api.github.com/orgs/connexta"
} | 2018-03-26T15:28:39 | 7435940617 | {"actor":{"display_login":"blen-desta"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/zaproxy/zap-extensions/pulls/comments/167600680","pull_request_review_id":95842021,"id":167600680,"diff_hunk":"@@ -1,6 +1,11 @@\n # This file defines the default (English) variants of all of the internationalised messages\n pscanalpha.desc = Passive Scan Rules - alpha\n \n+pscanalpha.blanktarget.name=Link uses _blank target\n+pscanalpha.blanktarget.desc=At least one link on this page uses a target of \"_blank\" without using rel=\"noopener\" which allows the target page to take control of this page.","path":"src/org/zaproxy/zap/extension/pscanrulesAlpha/resources/Messages.properties","position":5,"original_position":5,"commit_id":"08968cdccc3988a9dcbf2bdd71ac183ff5eb4641","original_commit_id":"08968cdccc3988a9dcbf2bdd71ac183ff5eb4641","user":{"login":"kingthorin","id":7570458,"avatar_url":"https://avatars0.githubusercontent.com/u/7570458?v=4","gravatar_id":"","url":"https://api.github.com/users/kingthorin","html_url":"https://github.com/kingthorin","followers_url":"https://api.github.com/users/kingthorin/followers","following_url":"https://api.github.com/users/kingthorin/following{/other_user}","gists_url":"https://api.github.com/users/kingthorin/gists{/gist_id}","starred_url":"https://api.github.com/users/kingthorin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kingthorin/subscriptions","organizations_url":"https://api.github.com/users/kingthorin/orgs","repos_url":"https://api.github.com/users/kingthorin/repos","events_url":"https://api.github.com/users/kingthorin/events{/privacy}","received_events_url":"https://api.github.com/users/kingthorin/received_events","type":"User","site_admin":false},"body":"Ya that probably makes more sense. Then the user isn't left wondering if the quotes demark what's important and also doesn't limit the values of \"rel\".","created_at":"2018-02-12T16:02:24Z","updated_at":"2018-02-12T16:02:24Z","html_url":"https://github.com/zaproxy/zap-extensions/pull/1365#discussion_r167600680","pull_request_url":"https://api.github.com/repos/zaproxy/zap-extensions/pulls/1365","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/zaproxy/zap-extensions/pulls/comments/167600680"},"html":{"href":"https://github.com/zaproxy/zap-extensions/pull/1365#discussion_r167600680"},"pull_request":{"href":"https://api.github.com/repos/zaproxy/zap-extensions/pulls/1365"}},"in_reply_to_id":167594511},"pull_request":{"url":"https://api.github.com/repos/zaproxy/zap-extensions/pulls/1365","id":168596766,"html_url":"https://github.com/zaproxy/zap-extensions/pull/1365","diff_url":"https://github.com/zaproxy/zap-extensions/pull/1365.diff","patch_url":"https://github.com/zaproxy/zap-extensions/pull/1365.patch","issue_url":"https://api.github.com/repos/zaproxy/zap-extensions/issues/1365","number":1365,"state":"open","locked":false,"title":"Added blank link target scanner","user":{"login":"psiinon","id":1081115,"avatar_url":"https://avatars0.githubusercontent.com/u/1081115?v=4","gravatar_id":"","url":"https://api.github.com/users/psiinon","html_url":"https://github.com/psiinon","followers_url":"https://api.github.com/users/psiinon/followers","following_url":"https://api.github.com/users/psiinon/following{/other_user}","gists_url":"https://api.github.com/users/psiinon/gists{/gist_id}","starred_url":"https://api.github.com/users/psiinon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/psiinon/subscriptions","organizations_url":"https://api.github.com/users/psiinon/orgs","repos_url":"https://api.github.com/users/psiinon/repos","events_url":"https://api.github.com/users/psiinon/events{/privacy}","received_events_url":"https://api.github.com/users/psiinon/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-02-12T14:44:41Z","updated_at":"2018-02-12T16:02:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a4c5f2be28b23cc187fd27b91eb63ae0a1d3feda","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/zaproxy/zap-extensions/pulls/1365/commits","review_comments_url":"https://api.github.com/repos/zaproxy/zap-extensions/pulls/1365/comments","review_comment_url":"https://api.github.com/repos/zaproxy/zap-extensions/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zaproxy/zap-extensions/issues/1365/comments","statuses_url":"https://api.github.com/repos/zaproxy/zap-extensions/statuses/08968cdccc3988a9dcbf2bdd71ac183ff5eb4641","head":{"label":"psiinon:alpha","ref":"alpha","sha":"08968cdccc3988a9dcbf2bdd71ac183ff5eb4641","user":{"login":"psiinon","id":1081115,"avatar_url":"https://avatars0.githubusercontent.com/u/1081115?v=4","gravatar_id":"","url":"https://api.github.com/users/psiinon","html_url":"https://github.com/psiinon","followers_url":"https://api.github.com/users/psiinon/followers","following_url":"https://api.github.com/users/psiinon/following{/other_user}","gists_url":"https://api.github.com/users/psiinon/gists{/gist_id}","starred_url":"https://api.github.com/users/psiinon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/psiinon/subscriptions","organizations_url":"https://api.github.com/users/psiinon/orgs","repos_url":"https://api.github.com/users/psiinon/repos","events_url":"https://api.github.com/users/psiinon/events{/privacy}","received_events_url":"https://api.github.com/users/psiinon/received_events","type":"User","site_admin":false},"repo":{"id":36720860,"name":"zap-extensions","full_name":"psiinon/zap-extensions","owner":{"login":"psiinon","id":1081115,"avatar_url":"https://avatars0.githubusercontent.com/u/1081115?v=4","gravatar_id":"","url":"https://api.github.com/users/psiinon","html_url":"https://github.com/psiinon","followers_url":"https://api.github.com/users/psiinon/followers","following_url":"https://api.github.com/users/psiinon/following{/other_user}","gists_url":"https://api.github.com/users/psiinon/gists{/gist_id}","starred_url":"https://api.github.com/users/psiinon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/psiinon/subscriptions","organizations_url":"https://api.github.com/users/psiinon/orgs","repos_url":"https://api.github.com/users/psiinon/repos","events_url":"https://api.github.com/users/psiinon/events{/privacy}","received_events_url":"https://api.github.com/users/psiinon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/psiinon/zap-extensions","description":"OWASP ZAP Add-ons","fork":true,"url":"https://api.github.com/repos/psiinon/zap-extensions","forks_url":"https://api.github.com/repos/psiinon/zap-extensions/forks","keys_url":"https://api.github.com/repos/psiinon/zap-extensions/keys{/key_id}","collaborators_url":"https://api.github.com/repos/psiinon/zap-extensions/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/psiinon/zap-extensions/teams","hooks_url":"https://api.github.com/repos/psiinon/zap-extensions/hooks","issue_events_url":"https://api.github.com/repos/psiinon/zap-extensions/issues/events{/number}","events_url":"https://api.github.com/repos/psiinon/zap-extensions/events","assignees_url":"https://api.github.com/repos/psiinon/zap-extensions/assignees{/user}","branches_url":"https://api.github.com/repos/psiinon/zap-extensions/branches{/branch}","tags_url":"https://api.github.com/repos/psiinon/zap-extensions/tags","blobs_url":"https://api.github.com/repos/psiinon/zap-extensions/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/psiinon/zap-extensions/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/psiinon/zap-extensions/git/refs{/sha}","trees_url":"https://api.github.com/repos/psiinon/zap-extensions/git/trees{/sha}","statuses_url":"https://api.github.com/repos/psiinon/zap-extensions/statuses/{sha}","languages_url":"https://api.github.com/repos/psiinon/zap-extensions/languages","stargazers_url":"https://api.github.com/repos/psiinon/zap-extensions/stargazers","contributors_url":"https://api.github.com/repos/psiinon/zap-extensions/contributors","subscribers_url":"https://api.github.com/repos/psiinon/zap-extensions/subscribers","subscription_url":"https://api.github.com/repos/psiinon/zap-extensions/subscription","commits_url":"https://api.github.com/repos/psiinon/zap-extensions/commits{/sha}","git_commits_url":"https://api.github.com/repos/psiinon/zap-extensions/git/commits{/sha}","comments_url":"https://api.github.com/repos/psiinon/zap-extensions/comments{/number}","issue_comment_url":"https://api.github.com/repos/psiinon/zap-extensions/issues/comments{/number}","contents_url":"https://api.github.com/repos/psiinon/zap-extensions/contents/{+path}","compare_url":"https://api.github.com/repos/psiinon/zap-extensions/compare/{base}...{head}","merges_url":"https://api.github.com/repos/psiinon/zap-extensions/merges","archive_url":"https://api.github.com/repos/psiinon/zap-extensions/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/psiinon/zap-extensions/downloads","issues_url":"https://api.github.com/repos/psiinon/zap-extensions/issues{/number}","pulls_url":"https://api.github.com/repos/psiinon/zap-extensions/pulls{/number}","milestones_url":"https://api.github.com/repos/psiinon/zap-extensions/milestones{/number}","notifications_url":"https://api.github.com/repos/psiinon/zap-extensions/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/psiinon/zap-extensions/labels{/name}","releases_url":"https://api.github.com/repos/psiinon/zap-extensions/releases{/id}","deployments_url":"https://api.github.com/repos/psiinon/zap-extensions/deployments","created_at":"2015-06-02T08:57:37Z","updated_at":"2017-11-28T18:11:54Z","pushed_at":"2018-02-12T14:44:08Z","git_url":"git://github.com/psiinon/zap-extensions.git","ssh_url":"[email protected]:psiinon/zap-extensions.git","clone_url":"https://github.com/psiinon/zap-extensions.git","svn_url":"https://github.com/psiinon/zap-extensions","homepage":"","size":894635,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"zaproxy:alpha","ref":"alpha","sha":"406ebc9500a7d3139f4e895c96ff98881c9acdb2","user":{"login":"zaproxy","id":6716868,"avatar_url":"https://avatars2.githubusercontent.com/u/6716868?v=4","gravatar_id":"","url":"https://api.github.com/users/zaproxy","html_url":"https://github.com/zaproxy","followers_url":"https://api.github.com/users/zaproxy/followers","following_url":"https://api.github.com/users/zaproxy/following{/other_user}","gists_url":"https://api.github.com/users/zaproxy/gists{/gist_id}","starred_url":"https://api.github.com/users/zaproxy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zaproxy/subscriptions","organizations_url":"https://api.github.com/users/zaproxy/orgs","repos_url":"https://api.github.com/users/zaproxy/repos","events_url":"https://api.github.com/users/zaproxy/events{/privacy}","received_events_url":"https://api.github.com/users/zaproxy/received_events","type":"Organization","site_admin":false},"repo":{"id":35210580,"name":"zap-extensions","full_name":"zaproxy/zap-extensions","owner":{"login":"zaproxy","id":6716868,"avatar_url":"https://avatars2.githubusercontent.com/u/6716868?v=4","gravatar_id":"","url":"https://api.github.com/users/zaproxy","html_url":"https://github.com/zaproxy","followers_url":"https://api.github.com/users/zaproxy/followers","following_url":"https://api.github.com/users/zaproxy/following{/other_user}","gists_url":"https://api.github.com/users/zaproxy/gists{/gist_id}","starred_url":"https://api.github.com/users/zaproxy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zaproxy/subscriptions","organizations_url":"https://api.github.com/users/zaproxy/orgs","repos_url":"https://api.github.com/users/zaproxy/repos","events_url":"https://api.github.com/users/zaproxy/events{/privacy}","received_events_url":"https://api.github.com/users/zaproxy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zaproxy/zap-extensions","description":"OWASP ZAP Add-ons","fork":false,"url":"https://api.github.com/repos/zaproxy/zap-extensions","forks_url":"https://api.github.com/repos/zaproxy/zap-extensions/forks","keys_url":"https://api.github.com/repos/zaproxy/zap-extensions/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zaproxy/zap-extensions/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zaproxy/zap-extensions/teams","hooks_url":"https://api.github.com/repos/zaproxy/zap-extensions/hooks","issue_events_url":"https://api.github.com/repos/zaproxy/zap-extensions/issues/events{/number}","events_url":"https://api.github.com/repos/zaproxy/zap-extensions/events","assignees_url":"https://api.github.com/repos/zaproxy/zap-extensions/assignees{/user}","branches_url":"https://api.github.com/repos/zaproxy/zap-extensions/branches{/branch}","tags_url":"https://api.github.com/repos/zaproxy/zap-extensions/tags","blobs_url":"https://api.github.com/repos/zaproxy/zap-extensions/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zaproxy/zap-extensions/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zaproxy/zap-extensions/git/refs{/sha}","trees_url":"https://api.github.com/repos/zaproxy/zap-extensions/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zaproxy/zap-extensions/statuses/{sha}","languages_url":"https://api.github.com/repos/zaproxy/zap-extensions/languages","stargazers_url":"https://api.github.com/repos/zaproxy/zap-extensions/stargazers","contributors_url":"https://api.github.com/repos/zaproxy/zap-extensions/contributors","subscribers_url":"https://api.github.com/repos/zaproxy/zap-extensions/subscribers","subscription_url":"https://api.github.com/repos/zaproxy/zap-extensions/subscription","commits_url":"https://api.github.com/repos/zaproxy/zap-extensions/commits{/sha}","git_commits_url":"https://api.github.com/repos/zaproxy/zap-extensions/git/commits{/sha}","comments_url":"https://api.github.com/repos/zaproxy/zap-extensions/comments{/number}","issue_comment_url":"https://api.github.com/repos/zaproxy/zap-extensions/issues/comments{/number}","contents_url":"https://api.github.com/repos/zaproxy/zap-extensions/contents/{+path}","compare_url":"https://api.github.com/repos/zaproxy/zap-extensions/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zaproxy/zap-extensions/merges","archive_url":"https://api.github.com/repos/zaproxy/zap-extensions/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zaproxy/zap-extensions/downloads","issues_url":"https://api.github.com/repos/zaproxy/zap-extensions/issues{/number}","pulls_url":"https://api.github.com/repos/zaproxy/zap-extensions/pulls{/number}","milestones_url":"https://api.github.com/repos/zaproxy/zap-extensions/milestones{/number}","notifications_url":"https://api.github.com/repos/zaproxy/zap-extensions/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zaproxy/zap-extensions/labels{/name}","releases_url":"https://api.github.com/repos/zaproxy/zap-extensions/releases{/id}","deployments_url":"https://api.github.com/repos/zaproxy/zap-extensions/deployments","created_at":"2015-05-07T09:17:13Z","updated_at":"2018-02-12T15:28:21Z","pushed_at":"2018-02-12T14:44:42Z","git_url":"git://github.com/zaproxy/zap-extensions.git","ssh_url":"[email protected]:zaproxy/zap-extensions.git","clone_url":"https://github.com/zaproxy/zap-extensions.git","svn_url":"https://github.com/zaproxy/zap-extensions","homepage":"","size":883987,"stargazers_count":198,"watchers_count":198,"language":"HTML","has_issues":false,"has_projects":false,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":220,"mirror_url":null,"archived":false,"open_issues_count":17,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":220,"open_issues":17,"watchers":198,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zaproxy/zap-extensions/pulls/1365"},"html":{"href":"https://github.com/zaproxy/zap-extensions/pull/1365"},"issue":{"href":"https://api.github.com/repos/zaproxy/zap-extensions/issues/1365"},"comments":{"href":"https://api.github.com/repos/zaproxy/zap-extensions/issues/1365/comments"},"review_comments":{"href":"https://api.github.com/repos/zaproxy/zap-extensions/pulls/1365/comments"},"review_comment":{"href":"https://api.github.com/repos/zaproxy/zap-extensions/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zaproxy/zap-extensions/pulls/1365/commits"},"statuses":{"href":"https://api.github.com/repos/zaproxy/zap-extensions/statuses/08968cdccc3988a9dcbf2bdd71ac183ff5eb4641"}},"author_association":"OWNER"}} | {
"id": 35210580,
"name": "zaproxy/zap-extensions",
"url": "https://api.github.com/repos/zaproxy/zap-extensions"
} | {
"id": 7570458,
"login": "kingthorin",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7570458?",
"url": "https://api.github.com/users/kingthorin"
} | {
"id": 6716868,
"login": "zaproxy",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6716868?",
"url": "https://api.github.com/orgs/zaproxy"
} | 2018-02-12T16:02:24 | 7233058330 | {"actor":{"display_login":"kingthorin"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/zaproxy/zaproxy/pulls/comments/213618323","pull_request_review_id":150489909,"id":213618323,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMzYxODMyMw==","diff_hunk":"@@ -0,0 +1,83 @@\n+import unittest\n+from datetime import datetime\n+from contextlib import contextmanager\n+import zap_common\n+\n+\n+class _MockHooks(object):\n+\n+ def __init__(self):\n+ self.called = 0\n+ \n+\n+ def zap_started(self, zap, target):\n+ self.called += 1\n+ return zap,\n+\n+\n+class TestZapHooks(unittest.TestCase):\n+\n+ @contextmanager\n+ def assertNotRaises(self, exc_type=Exception):\n+ try:\n+ yield None\n+ except exc_type:\n+ raise self.failureException('{} raised'.format(exc_type.__name__))\n+\n+\n+ def test_trigger_hook_arg_length(self):\n+ \"\"\" Triggering hook should return same args if no hook to trigger \"\"\"\n+ self.assertEqual(zap_common.zap_hooks, None)\n+ args = [1, 2, 3, 4]\n+ return_args = zap_common.trigger_hook('print_rules_wrap', *args)\n+ self.assertEqual(len(args), len(return_args))\n+\n+\n+ def test_trigger_hook_mismatch_no_exception(self):\n+ \"\"\" If the hook signature doesn't match the hook, no exception is raised \"\"\"\n+ zap_common.zap_hooks = _MockHooks()\n+ with self.assertNotRaises():\n+ zap_common.trigger_hook('zap_started')\n+ self.assertEqual(zap_common.zap_hooks.called, 0)\n+\n+\n+ def test_trigger_hook_ignore_exception(self):\n+ \"\"\" Hooks that raise exceptions are ignored when triggered \"\"\"\n+ zap_common.zap_hooks = _MockHooks()\n+ zap_common.zap_hooks.bad_hook = lambda x: 1/0.0\n+ # Prove the hook is bad\n+ with self.assertRaises(Exception):\n+ zap_common.zap_hooks.bad_hook(1)\n+ # Hook triggering goes on despite bad hook\n+ with self.assertNotRaises():\n+ zap_common.trigger_hook('bad_hook', 1)\n+ self.assertEqual(zap_common.zap_hooks.called, 0)\n+\n+\n+ def test_trigger_hook_verify_calls(self):\n+ \"\"\" Should return same args if no hook to trigger \"\"\"\n+ zap_common.zap_hooks = _MockHooks()\n+ args = ['zap', 'http://127.0.0.1']\n+ zap_common.trigger_hook('zap_started', *args)\n+ zap_common.trigger_hook('zap_started', *args)\n+ zap_common.trigger_hook('zap_started', *args)\n+ zap_common.trigger_hook('zap_started', *args)\n+ zap_common.trigger_hook('zap_started', *args)\n+ self.assertEqual(zap_common.zap_hooks.called, 5)\n+\n+\n+ def test_trigger_hook_maintain_signature(self):\n+ \"\"\"Should return same args if no hook to trigger \"\"\"","path":"docker/tests/test_zap_hooks.py","position":49,"original_position":70,"commit_id":"2a73c02b5cb2a0655a15f5a8b9eec4310303d553","original_commit_id":"a401aa12bfc02e2d37c9c522b07d4993c2eed19e","user":{"login":"thc202","id":4639210,"node_id":"MDQ6VXNlcjQ2MzkyMTA=","avatar_url":"https://avatars0.githubusercontent.com/u/4639210?v=4","gravatar_id":"","url":"https://api.github.com/users/thc202","html_url":"https://github.com/thc202","followers_url":"https://api.github.com/users/thc202/followers","following_url":"https://api.github.com/users/thc202/following{/other_user}","gists_url":"https://api.github.com/users/thc202/gists{/gist_id}","starred_url":"https://api.github.com/users/thc202/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thc202/subscriptions","organizations_url":"https://api.github.com/users/thc202/orgs","repos_url":"https://api.github.com/users/thc202/repos","events_url":"https://api.github.com/users/thc202/events{/privacy}","received_events_url":"https://api.github.com/users/thc202/received_events","type":"User","site_admin":false},"body":"Bump, the description does not match the test (I think).","created_at":"2018-08-29T10:05:19Z","updated_at":"2018-08-29T10:05:20Z","html_url":"https://github.com/zaproxy/zaproxy/pull/4937#discussion_r213618323","pull_request_url":"https://api.github.com/repos/zaproxy/zaproxy/pulls/4937","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/zaproxy/zaproxy/pulls/comments/213618323"},"html":{"href":"https://github.com/zaproxy/zaproxy/pull/4937#discussion_r213618323"},"pull_request":{"href":"https://api.github.com/repos/zaproxy/zaproxy/pulls/4937"}},"in_reply_to_id":211124227},"pull_request":{"url":"https://api.github.com/repos/zaproxy/zaproxy/pulls/4937","id":208977573,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4OTc3NTcz","html_url":"https://github.com/zaproxy/zaproxy/pull/4937","diff_url":"https://github.com/zaproxy/zaproxy/pull/4937.diff","patch_url":"https://github.com/zaproxy/zaproxy/pull/4937.patch","issue_url":"https://api.github.com/repos/zaproxy/zaproxy/issues/4937","number":4937,"state":"open","locked":false,"title":"Feature - Added a hook system into the baseline scripts & scans #4925","user":{"login":"rezen","id":465024,"node_id":"MDQ6VXNlcjQ2NTAyNA==","avatar_url":"https://avatars0.githubusercontent.com/u/465024?v=4","gravatar_id":"","url":"https://api.github.com/users/rezen","html_url":"https://github.com/rezen","followers_url":"https://api.github.com/users/rezen/followers","following_url":"https://api.github.com/users/rezen/following{/other_user}","gists_url":"https://api.github.com/users/rezen/gists{/gist_id}","starred_url":"https://api.github.com/users/rezen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rezen/subscriptions","organizations_url":"https://api.github.com/users/rezen/orgs","repos_url":"https://api.github.com/users/rezen/repos","events_url":"https://api.github.com/users/rezen/events{/privacy}","received_events_url":"https://api.github.com/users/rezen/received_events","type":"User","site_admin":false},"body":"As per the feature #4925 created a hook system to enable users to augment or add to the baseline/full/api scans. By default, the scripts will look for `~/.zap_hooks.py` but you can supply a `--hook=path-to-custom/hooks.py`\r\n\r\nFor each hook you want to plugin in to, you create a method with the same name as the hook and then there you can add to or change what zap is doing. Every hook that has the `zap_` prefix will pass the zap api object which you can interact with. Any hook defined in `zap_common.py` that uses the `@hook` decorator, you are intercepting the arguments that are passed to the method (the hook is the same name as the method) and you can modify the arguments. Every hook that ends with `_wrap` allows you to wrap the results/return value of the method of the same name.\r\n\r\n**Example** \r\n```python\r\ndef start_docker_zap_wrap(container_id):\r\n return container_id\r\n\r\ndef zap_started(zap, target):\r\n print(zap)\r\n\r\ndef zap_access_target(zap, target):\r\n print(\"Access target %s\" % target)\r\n\r\ndef zap_spider(zap, target):\r\n pass\r\n\r\ndef zap_get_alerts(zap, baseurl, blacklist, out_of_scope):\r\n blacklist.append('20001')\r\n return zap, baseurl, blacklist, out_of_scope\r\n\r\ndef zap_get_alerts_wrap(results):\r\n return results\r\n\r\ndef zap_spider_wrap(zap=None):\r\n print(\"Post\", zap)\r\n raise Exception(\"test\")\r\n\r\ndef zap_pre_shutdown(zap=None):\r\n pass\r\n```\r\n\r\n","created_at":"2018-08-16T20:38:02Z","updated_at":"2018-08-29T10:05:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1aebec7632e63226e53a7db6e13a7a234a972ba2","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":220536002,"node_id":"MDU6TGFiZWwyMjA1MzYwMDI=","url":"https://api.github.com/repos/zaproxy/zaproxy/labels/Type-Task","name":"Type-Task","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/zaproxy/zaproxy/pulls/4937/commits","review_comments_url":"https://api.github.com/repos/zaproxy/zaproxy/pulls/4937/comments","review_comment_url":"https://api.github.com/repos/zaproxy/zaproxy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zaproxy/zaproxy/issues/4937/comments","statuses_url":"https://api.github.com/repos/zaproxy/zaproxy/statuses/2a73c02b5cb2a0655a15f5a8b9eec4310303d553","head":{"label":"rezen:develop","ref":"develop","sha":"2a73c02b5cb2a0655a15f5a8b9eec4310303d553","user":{"login":"rezen","id":465024,"node_id":"MDQ6VXNlcjQ2NTAyNA==","avatar_url":"https://avatars0.githubusercontent.com/u/465024?v=4","gravatar_id":"","url":"https://api.github.com/users/rezen","html_url":"https://github.com/rezen","followers_url":"https://api.github.com/users/rezen/followers","following_url":"https://api.github.com/users/rezen/following{/other_user}","gists_url":"https://api.github.com/users/rezen/gists{/gist_id}","starred_url":"https://api.github.com/users/rezen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rezen/subscriptions","organizations_url":"https://api.github.com/users/rezen/orgs","repos_url":"https://api.github.com/users/rezen/repos","events_url":"https://api.github.com/users/rezen/events{/privacy}","received_events_url":"https://api.github.com/users/rezen/received_events","type":"User","site_admin":false},"repo":{"id":145034001,"node_id":"MDEwOlJlcG9zaXRvcnkxNDUwMzQwMDE=","name":"zaproxy","full_name":"rezen/zaproxy","owner":{"login":"rezen","id":465024,"node_id":"MDQ6VXNlcjQ2NTAyNA==","avatar_url":"https://avatars0.githubusercontent.com/u/465024?v=4","gravatar_id":"","url":"https://api.github.com/users/rezen","html_url":"https://github.com/rezen","followers_url":"https://api.github.com/users/rezen/followers","following_url":"https://api.github.com/users/rezen/following{/other_user}","gists_url":"https://api.github.com/users/rezen/gists{/gist_id}","starred_url":"https://api.github.com/users/rezen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rezen/subscriptions","organizations_url":"https://api.github.com/users/rezen/orgs","repos_url":"https://api.github.com/users/rezen/repos","events_url":"https://api.github.com/users/rezen/events{/privacy}","received_events_url":"https://api.github.com/users/rezen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rezen/zaproxy","description":"The OWASP ZAP core project","fork":true,"url":"https://api.github.com/repos/rezen/zaproxy","forks_url":"https://api.github.com/repos/rezen/zaproxy/forks","keys_url":"https://api.github.com/repos/rezen/zaproxy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rezen/zaproxy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rezen/zaproxy/teams","hooks_url":"https://api.github.com/repos/rezen/zaproxy/hooks","issue_events_url":"https://api.github.com/repos/rezen/zaproxy/issues/events{/number}","events_url":"https://api.github.com/repos/rezen/zaproxy/events","assignees_url":"https://api.github.com/repos/rezen/zaproxy/assignees{/user}","branches_url":"https://api.github.com/repos/rezen/zaproxy/branches{/branch}","tags_url":"https://api.github.com/repos/rezen/zaproxy/tags","blobs_url":"https://api.github.com/repos/rezen/zaproxy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rezen/zaproxy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rezen/zaproxy/git/refs{/sha}","trees_url":"https://api.github.com/repos/rezen/zaproxy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rezen/zaproxy/statuses/{sha}","languages_url":"https://api.github.com/repos/rezen/zaproxy/languages","stargazers_url":"https://api.github.com/repos/rezen/zaproxy/stargazers","contributors_url":"https://api.github.com/repos/rezen/zaproxy/contributors","subscribers_url":"https://api.github.com/repos/rezen/zaproxy/subscribers","subscription_url":"https://api.github.com/repos/rezen/zaproxy/subscription","commits_url":"https://api.github.com/repos/rezen/zaproxy/commits{/sha}","git_commits_url":"https://api.github.com/repos/rezen/zaproxy/git/commits{/sha}","comments_url":"https://api.github.com/repos/rezen/zaproxy/comments{/number}","issue_comment_url":"https://api.github.com/repos/rezen/zaproxy/issues/comments{/number}","contents_url":"https://api.github.com/repos/rezen/zaproxy/contents/{+path}","compare_url":"https://api.github.com/repos/rezen/zaproxy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rezen/zaproxy/merges","archive_url":"https://api.github.com/repos/rezen/zaproxy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rezen/zaproxy/downloads","issues_url":"https://api.github.com/repos/rezen/zaproxy/issues{/number}","pulls_url":"https://api.github.com/repos/rezen/zaproxy/pulls{/number}","milestones_url":"https://api.github.com/repos/rezen/zaproxy/milestones{/number}","notifications_url":"https://api.github.com/repos/rezen/zaproxy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rezen/zaproxy/labels{/name}","releases_url":"https://api.github.com/repos/rezen/zaproxy/releases{/id}","deployments_url":"https://api.github.com/repos/rezen/zaproxy/deployments","created_at":"2018-08-16T20:04:46Z","updated_at":"2018-08-22T21:51:36Z","pushed_at":"2018-08-22T21:51:34Z","git_url":"git://github.com/rezen/zaproxy.git","ssh_url":"[email protected]:rezen/zaproxy.git","clone_url":"https://github.com/rezen/zaproxy.git","svn_url":"https://github.com/rezen/zaproxy","homepage":null,"size":177010,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"zaproxy:develop","ref":"develop","sha":"17e56fa525b3d6a359f2d95544c1fe1e38d6e003","user":{"login":"zaproxy","id":6716868,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3MTY4Njg=","avatar_url":"https://avatars2.githubusercontent.com/u/6716868?v=4","gravatar_id":"","url":"https://api.github.com/users/zaproxy","html_url":"https://github.com/zaproxy","followers_url":"https://api.github.com/users/zaproxy/followers","following_url":"https://api.github.com/users/zaproxy/following{/other_user}","gists_url":"https://api.github.com/users/zaproxy/gists{/gist_id}","starred_url":"https://api.github.com/users/zaproxy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zaproxy/subscriptions","organizations_url":"https://api.github.com/users/zaproxy/orgs","repos_url":"https://api.github.com/users/zaproxy/repos","events_url":"https://api.github.com/users/zaproxy/events{/privacy}","received_events_url":"https://api.github.com/users/zaproxy/received_events","type":"Organization","site_admin":false},"repo":{"id":36817565,"node_id":"MDEwOlJlcG9zaXRvcnkzNjgxNzU2NQ==","name":"zaproxy","full_name":"zaproxy/zaproxy","owner":{"login":"zaproxy","id":6716868,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3MTY4Njg=","avatar_url":"https://avatars2.githubusercontent.com/u/6716868?v=4","gravatar_id":"","url":"https://api.github.com/users/zaproxy","html_url":"https://github.com/zaproxy","followers_url":"https://api.github.com/users/zaproxy/followers","following_url":"https://api.github.com/users/zaproxy/following{/other_user}","gists_url":"https://api.github.com/users/zaproxy/gists{/gist_id}","starred_url":"https://api.github.com/users/zaproxy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zaproxy/subscriptions","organizations_url":"https://api.github.com/users/zaproxy/orgs","repos_url":"https://api.github.com/users/zaproxy/repos","events_url":"https://api.github.com/users/zaproxy/events{/privacy}","received_events_url":"https://api.github.com/users/zaproxy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zaproxy/zaproxy","description":"The OWASP ZAP core project","fork":false,"url":"https://api.github.com/repos/zaproxy/zaproxy","forks_url":"https://api.github.com/repos/zaproxy/zaproxy/forks","keys_url":"https://api.github.com/repos/zaproxy/zaproxy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zaproxy/zaproxy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zaproxy/zaproxy/teams","hooks_url":"https://api.github.com/repos/zaproxy/zaproxy/hooks","issue_events_url":"https://api.github.com/repos/zaproxy/zaproxy/issues/events{/number}","events_url":"https://api.github.com/repos/zaproxy/zaproxy/events","assignees_url":"https://api.github.com/repos/zaproxy/zaproxy/assignees{/user}","branches_url":"https://api.github.com/repos/zaproxy/zaproxy/branches{/branch}","tags_url":"https://api.github.com/repos/zaproxy/zaproxy/tags","blobs_url":"https://api.github.com/repos/zaproxy/zaproxy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zaproxy/zaproxy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zaproxy/zaproxy/git/refs{/sha}","trees_url":"https://api.github.com/repos/zaproxy/zaproxy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zaproxy/zaproxy/statuses/{sha}","languages_url":"https://api.github.com/repos/zaproxy/zaproxy/languages","stargazers_url":"https://api.github.com/repos/zaproxy/zaproxy/stargazers","contributors_url":"https://api.github.com/repos/zaproxy/zaproxy/contributors","subscribers_url":"https://api.github.com/repos/zaproxy/zaproxy/subscribers","subscription_url":"https://api.github.com/repos/zaproxy/zaproxy/subscription","commits_url":"https://api.github.com/repos/zaproxy/zaproxy/commits{/sha}","git_commits_url":"https://api.github.com/repos/zaproxy/zaproxy/git/commits{/sha}","comments_url":"https://api.github.com/repos/zaproxy/zaproxy/comments{/number}","issue_comment_url":"https://api.github.com/repos/zaproxy/zaproxy/issues/comments{/number}","contents_url":"https://api.github.com/repos/zaproxy/zaproxy/contents/{+path}","compare_url":"https://api.github.com/repos/zaproxy/zaproxy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zaproxy/zaproxy/merges","archive_url":"https://api.github.com/repos/zaproxy/zaproxy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zaproxy/zaproxy/downloads","issues_url":"https://api.github.com/repos/zaproxy/zaproxy/issues{/number}","pulls_url":"https://api.github.com/repos/zaproxy/zaproxy/pulls{/number}","milestones_url":"https://api.github.com/repos/zaproxy/zaproxy/milestones{/number}","notifications_url":"https://api.github.com/repos/zaproxy/zaproxy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zaproxy/zaproxy/labels{/name}","releases_url":"https://api.github.com/repos/zaproxy/zaproxy/releases{/id}","deployments_url":"https://api.github.com/repos/zaproxy/zaproxy/deployments","created_at":"2015-06-03T16:55:01Z","updated_at":"2018-08-29T09:22:53Z","pushed_at":"2018-08-29T00:11:30Z","git_url":"git://github.com/zaproxy/zaproxy.git","ssh_url":"[email protected]:zaproxy/zaproxy.git","clone_url":"https://github.com/zaproxy/zaproxy.git","svn_url":"https://github.com/zaproxy/zaproxy","homepage":null,"size":177089,"stargazers_count":4381,"watchers_count":4381,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":822,"mirror_url":null,"archived":false,"open_issues_count":633,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":822,"open_issues":633,"watchers":4381,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/zaproxy/zaproxy/pulls/4937"},"html":{"href":"https://github.com/zaproxy/zaproxy/pull/4937"},"issue":{"href":"https://api.github.com/repos/zaproxy/zaproxy/issues/4937"},"comments":{"href":"https://api.github.com/repos/zaproxy/zaproxy/issues/4937/comments"},"review_comments":{"href":"https://api.github.com/repos/zaproxy/zaproxy/pulls/4937/comments"},"review_comment":{"href":"https://api.github.com/repos/zaproxy/zaproxy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zaproxy/zaproxy/pulls/4937/commits"},"statuses":{"href":"https://api.github.com/repos/zaproxy/zaproxy/statuses/2a73c02b5cb2a0655a15f5a8b9eec4310303d553"}},"author_association":"NONE"}} | {
"id": 36817565,
"name": "zaproxy/zaproxy",
"url": "https://api.github.com/repos/zaproxy/zaproxy"
} | {
"id": 4639210,
"login": "thc202",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4639210?",
"url": "https://api.github.com/users/thc202"
} | {
"id": 6716868,
"login": "zaproxy",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6716868?",
"url": "https://api.github.com/orgs/zaproxy"
} | 2018-08-29T10:05:19 | 8183787607 | {"actor":{"display_login":"thc202"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/OpenMW/openmw/pulls/comments/231266316","pull_request_review_id":172200229,"id":231266316,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMTI2NjMxNg==","diff_hunk":"@@ -0,0 +1,102 @@\n+#ifndef OPENMW_COMPONENTS_DETOURNAVIGATOR_RECASTALLOCUTILS_H\n+#define OPENMW_COMPONENTS_DETOURNAVIGATOR_RECASTALLOCUTILS_H\n+\n+#include <RecastAlloc.h>\n+\n+#include <cstdint>\n+\n+namespace DetourNavigator\n+{\n+ static_assert(sizeof(std::size_t) == sizeof(void*), \"\");\n+\n+ enum BufferType : std::size_t\n+ {\n+ BufferType_perm,\n+ BufferType_temp,\n+ BufferType_unused,\n+ };\n+\n+ inline BufferType* tempPtrBufferType(void* ptr)\n+ {\n+ return reinterpret_cast<BufferType*>(static_cast<std::size_t*>(ptr) + 1);\n+ }\n+\n+ inline BufferType getTempPtrBufferType(void* ptr)\n+ {\n+ return *tempPtrBufferType(ptr);\n+ }\n+\n+ inline void setTempPtrBufferType(void* ptr, BufferType value)\n+ {\n+ *tempPtrBufferType(ptr) = value;\n+ }\n+\n+ inline void** tempPtrPrev(void* ptr)\n+ {\n+ return static_cast<void**>(ptr);\n+ }\n+\n+ inline void* getTempPtrPrev(void* ptr)\n+ {\n+ return *tempPtrPrev(ptr);\n+ }\n+\n+ inline void setTempPtrPrev(void* ptr, void* value)\n+ {\n+ *tempPtrPrev(ptr) = value;\n+ }\n+\n+ inline void* getTempPtrDataPtr(void* ptr)\n+ {\n+ return reinterpret_cast<void*>(static_cast<std::size_t*>(ptr) + 2);\n+ }\n+\n+ inline BufferType* dataPtrBufferType(void* dataPtr)\n+ {\n+ return reinterpret_cast<BufferType*>(static_cast<std::size_t*>(dataPtr) - 1);\n+ }\n+\n+ inline BufferType getDataPtrBufferType(void* dataPtr)\n+ {\n+ return *dataPtrBufferType(dataPtr);\n+ }\n+\n+ inline void setDataPtrBufferType(void* dataPtr, BufferType value)\n+ {\n+ *dataPtrBufferType(dataPtr) = value;\n+ }\n+\n+ inline void* getTempDataPtrStackPtr(void* dataPtr)\n+ {\n+ return static_cast<std::size_t*>(dataPtr) - 2;\n+ }\n+\n+ inline void* getPermDataPtrHeapPtr(void* dataPtr)\n+ {\n+ return static_cast<std::size_t*>(dataPtr) - 1;\n+ }\n+\n+ inline void setPermPtrBufferType(void* ptr, BufferType value)\n+ {\n+ *static_cast<BufferType*>(ptr) = value;\n+ }\n+\n+ inline void* getPermPtrDataPtr(void* ptr)\n+ {\n+ return static_cast<std::size_t*>(ptr) + 1;\n+ }\n+\n+ // TODO: use std::align\n+ inline void* align(std::size_t align, std::size_t size, void*& ptr, std::size_t& space) noexcept\n+ {\n+ const auto intptr = reinterpret_cast<std::uintptr_t>(ptr);\n+ const auto aligned = (intptr - 1u + align) & - align;","path":"components/detournavigator/recastallocutils.hpp","position":93,"original_position":93,"commit_id":"d2c2bdadb5ab1f16a79120ffd91623d157e4cf37","original_commit_id":"d2c2bdadb5ab1f16a79120ffd91623d157e4cf37","user":{"login":"psi29a","id":1122069,"node_id":"MDQ6VXNlcjExMjIwNjk=","avatar_url":"https://avatars2.githubusercontent.com/u/1122069?v=4","gravatar_id":"","url":"https://api.github.com/users/psi29a","html_url":"https://github.com/psi29a","followers_url":"https://api.github.com/users/psi29a/followers","following_url":"https://api.github.com/users/psi29a/following{/other_user}","gists_url":"https://api.github.com/users/psi29a/gists{/gist_id}","starred_url":"https://api.github.com/users/psi29a/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/psi29a/subscriptions","organizations_url":"https://api.github.com/users/psi29a/orgs","repos_url":"https://api.github.com/users/psi29a/repos","events_url":"https://api.github.com/users/psi29a/events{/privacy}","received_events_url":"https://api.github.com/users/psi29a/received_events","type":"User","site_admin":false},"body":"Try this one? #2026 ","created_at":"2018-11-06T19:45:30Z","updated_at":"2018-11-06T19:45:31Z","html_url":"https://github.com/OpenMW/openmw/pull/2021#discussion_r231266316","pull_request_url":"https://api.github.com/repos/OpenMW/openmw/pulls/2021","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/OpenMW/openmw/pulls/comments/231266316"},"html":{"href":"https://github.com/OpenMW/openmw/pull/2021#discussion_r231266316"},"pull_request":{"href":"https://api.github.com/repos/OpenMW/openmw/pulls/2021"}},"in_reply_to_id":230824934},"pull_request":{"url":"https://api.github.com/repos/OpenMW/openmw/pulls/2021","id":228188946,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4MTg4OTQ2","html_url":"https://github.com/OpenMW/openmw/pull/2021","diff_url":"https://github.com/OpenMW/openmw/pull/2021.diff","patch_url":"https://github.com/OpenMW/openmw/pull/2021.patch","issue_url":"https://api.github.com/repos/OpenMW/openmw/issues/2021","number":2021,"state":"closed","locked":false,"title":"Recast global allocator","user":{"login":"elsid","id":764107,"node_id":"MDQ6VXNlcjc2NDEwNw==","avatar_url":"https://avatars2.githubusercontent.com/u/764107?v=4","gravatar_id":"","url":"https://api.github.com/users/elsid","html_url":"https://github.com/elsid","followers_url":"https://api.github.com/users/elsid/followers","following_url":"https://api.github.com/users/elsid/following{/other_user}","gists_url":"https://api.github.com/users/elsid/gists{/gist_id}","starred_url":"https://api.github.com/users/elsid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elsid/subscriptions","organizations_url":"https://api.github.com/users/elsid/orgs","repos_url":"https://api.github.com/users/elsid/repos","events_url":"https://api.github.com/users/elsid/events{/privacy}","received_events_url":"https://api.github.com/users/elsid/received_events","type":"User","site_admin":false},"body":"To fix https://github.com/OpenMW/openmw/pull/1633#issuecomment-435601824 . Recastnavigation uses a lot of small vectors to perform internal calculations like [this](https://github.com/OpenMW/openmw/blob/d3633bbada6ec44c9e6dc3e04404a1438ce71afa/extern/recastnavigation/Recast/Source/RecastContour.cpp#L904) one. It has allocator function customization which supports different allocation policies: permanent and temporary. By default both of them use `malloc`. `rcIntArray` allocates using temporary policy. To reduce `malloc` calls all temporary allocations should use preallocated buffer. This pr set custom allocator for recastnavigation with stack allocator for temporary allocations.\r\n\r\nHere is memory profiles to compare:\r\n\r\n[openmw-45](https://github.com/OpenMW/openmw/commit/de381d0d49c702b8e52a5208cb783144aec53216) branch:\r\n\r\n\r\n\r\n[master](https://github.com/OpenMW/openmw/commit/d3633bbada6ec44c9e6dc3e04404a1438ce71afa) branch:\r\n\r\n\r\n\r\n[this](https://github.com/OpenMW/openmw/commit/b477775e1602893c6586b0525ed104b1b383636e) pr:\r\n\r\n","created_at":"2018-11-04T17:01:38Z","updated_at":"2018-11-06T19:45:31Z","closed_at":"2018-11-05T06:51:11Z","merged_at":"2018-11-05T06:51:11Z","merge_commit_sha":"28913758ce6cb06591123ca213f451c4cc0f92af","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/OpenMW/openmw/pulls/2021/commits","review_comments_url":"https://api.github.com/repos/OpenMW/openmw/pulls/2021/comments","review_comment_url":"https://api.github.com/repos/OpenMW/openmw/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OpenMW/openmw/issues/2021/comments","statuses_url":"https://api.github.com/repos/OpenMW/openmw/statuses/d2c2bdadb5ab1f16a79120ffd91623d157e4cf37","head":{"label":"elsid:recast_global_allocator","ref":"recast_global_allocator","sha":"d2c2bdadb5ab1f16a79120ffd91623d157e4cf37","user":{"login":"elsid","id":764107,"node_id":"MDQ6VXNlcjc2NDEwNw==","avatar_url":"https://avatars2.githubusercontent.com/u/764107?v=4","gravatar_id":"","url":"https://api.github.com/users/elsid","html_url":"https://github.com/elsid","followers_url":"https://api.github.com/users/elsid/followers","following_url":"https://api.github.com/users/elsid/following{/other_user}","gists_url":"https://api.github.com/users/elsid/gists{/gist_id}","starred_url":"https://api.github.com/users/elsid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elsid/subscriptions","organizations_url":"https://api.github.com/users/elsid/orgs","repos_url":"https://api.github.com/users/elsid/repos","events_url":"https://api.github.com/users/elsid/events{/privacy}","received_events_url":"https://api.github.com/users/elsid/received_events","type":"User","site_admin":false},"repo":{"id":98830051,"node_id":"MDEwOlJlcG9zaXRvcnk5ODgzMDA1MQ==","name":"openmw","full_name":"elsid/openmw","private":false,"owner":{"login":"elsid","id":764107,"node_id":"MDQ6VXNlcjc2NDEwNw==","avatar_url":"https://avatars2.githubusercontent.com/u/764107?v=4","gravatar_id":"","url":"https://api.github.com/users/elsid","html_url":"https://github.com/elsid","followers_url":"https://api.github.com/users/elsid/followers","following_url":"https://api.github.com/users/elsid/following{/other_user}","gists_url":"https://api.github.com/users/elsid/gists{/gist_id}","starred_url":"https://api.github.com/users/elsid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elsid/subscriptions","organizations_url":"https://api.github.com/users/elsid/orgs","repos_url":"https://api.github.com/users/elsid/repos","events_url":"https://api.github.com/users/elsid/events{/privacy}","received_events_url":"https://api.github.com/users/elsid/received_events","type":"User","site_admin":false},"html_url":"https://github.com/elsid/openmw","description":"OpenMW is an unofficial open source engine reimplementation of the game Morrowind.","fork":true,"url":"https://api.github.com/repos/elsid/openmw","forks_url":"https://api.github.com/repos/elsid/openmw/forks","keys_url":"https://api.github.com/repos/elsid/openmw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elsid/openmw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elsid/openmw/teams","hooks_url":"https://api.github.com/repos/elsid/openmw/hooks","issue_events_url":"https://api.github.com/repos/elsid/openmw/issues/events{/number}","events_url":"https://api.github.com/repos/elsid/openmw/events","assignees_url":"https://api.github.com/repos/elsid/openmw/assignees{/user}","branches_url":"https://api.github.com/repos/elsid/openmw/branches{/branch}","tags_url":"https://api.github.com/repos/elsid/openmw/tags","blobs_url":"https://api.github.com/repos/elsid/openmw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elsid/openmw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elsid/openmw/git/refs{/sha}","trees_url":"https://api.github.com/repos/elsid/openmw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elsid/openmw/statuses/{sha}","languages_url":"https://api.github.com/repos/elsid/openmw/languages","stargazers_url":"https://api.github.com/repos/elsid/openmw/stargazers","contributors_url":"https://api.github.com/repos/elsid/openmw/contributors","subscribers_url":"https://api.github.com/repos/elsid/openmw/subscribers","subscription_url":"https://api.github.com/repos/elsid/openmw/subscription","commits_url":"https://api.github.com/repos/elsid/openmw/commits{/sha}","git_commits_url":"https://api.github.com/repos/elsid/openmw/git/commits{/sha}","comments_url":"https://api.github.com/repos/elsid/openmw/comments{/number}","issue_comment_url":"https://api.github.com/repos/elsid/openmw/issues/comments{/number}","contents_url":"https://api.github.com/repos/elsid/openmw/contents/{+path}","compare_url":"https://api.github.com/repos/elsid/openmw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elsid/openmw/merges","archive_url":"https://api.github.com/repos/elsid/openmw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elsid/openmw/downloads","issues_url":"https://api.github.com/repos/elsid/openmw/issues{/number}","pulls_url":"https://api.github.com/repos/elsid/openmw/pulls{/number}","milestones_url":"https://api.github.com/repos/elsid/openmw/milestones{/number}","notifications_url":"https://api.github.com/repos/elsid/openmw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elsid/openmw/labels{/name}","releases_url":"https://api.github.com/repos/elsid/openmw/releases{/id}","deployments_url":"https://api.github.com/repos/elsid/openmw/deployments","created_at":"2017-07-30T23:12:12Z","updated_at":"2018-11-05T10:10:03Z","pushed_at":"2018-11-05T10:10:00Z","git_url":"git://github.com/elsid/openmw.git","ssh_url":"[email protected]:elsid/openmw.git","clone_url":"https://github.com/elsid/openmw.git","svn_url":"https://github.com/elsid/openmw","homepage":"http://www.openmw.org/","size":57162,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"OpenMW:master","ref":"master","sha":"d3633bbada6ec44c9e6dc3e04404a1438ce71afa","user":{"login":"OpenMW","id":6727417,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3Mjc0MTc=","avatar_url":"https://avatars0.githubusercontent.com/u/6727417?v=4","gravatar_id":"","url":"https://api.github.com/users/OpenMW","html_url":"https://github.com/OpenMW","followers_url":"https://api.github.com/users/OpenMW/followers","following_url":"https://api.github.com/users/OpenMW/following{/other_user}","gists_url":"https://api.github.com/users/OpenMW/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenMW/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenMW/subscriptions","organizations_url":"https://api.github.com/users/OpenMW/orgs","repos_url":"https://api.github.com/users/OpenMW/repos","events_url":"https://api.github.com/users/OpenMW/events{/privacy}","received_events_url":"https://api.github.com/users/OpenMW/received_events","type":"Organization","site_admin":false},"repo":{"id":285722,"node_id":"MDEwOlJlcG9zaXRvcnkyODU3MjI=","name":"openmw","full_name":"OpenMW/openmw","private":false,"owner":{"login":"OpenMW","id":6727417,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3Mjc0MTc=","avatar_url":"https://avatars0.githubusercontent.com/u/6727417?v=4","gravatar_id":"","url":"https://api.github.com/users/OpenMW","html_url":"https://github.com/OpenMW","followers_url":"https://api.github.com/users/OpenMW/followers","following_url":"https://api.github.com/users/OpenMW/following{/other_user}","gists_url":"https://api.github.com/users/OpenMW/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenMW/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenMW/subscriptions","organizations_url":"https://api.github.com/users/OpenMW/orgs","repos_url":"https://api.github.com/users/OpenMW/repos","events_url":"https://api.github.com/users/OpenMW/events{/privacy}","received_events_url":"https://api.github.com/users/OpenMW/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/OpenMW/openmw","description":"OpenMW is an unofficial open source engine reimplementation of the game Morrowind.","fork":false,"url":"https://api.github.com/repos/OpenMW/openmw","forks_url":"https://api.github.com/repos/OpenMW/openmw/forks","keys_url":"https://api.github.com/repos/OpenMW/openmw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OpenMW/openmw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OpenMW/openmw/teams","hooks_url":"https://api.github.com/repos/OpenMW/openmw/hooks","issue_events_url":"https://api.github.com/repos/OpenMW/openmw/issues/events{/number}","events_url":"https://api.github.com/repos/OpenMW/openmw/events","assignees_url":"https://api.github.com/repos/OpenMW/openmw/assignees{/user}","branches_url":"https://api.github.com/repos/OpenMW/openmw/branches{/branch}","tags_url":"https://api.github.com/repos/OpenMW/openmw/tags","blobs_url":"https://api.github.com/repos/OpenMW/openmw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OpenMW/openmw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OpenMW/openmw/git/refs{/sha}","trees_url":"https://api.github.com/repos/OpenMW/openmw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OpenMW/openmw/statuses/{sha}","languages_url":"https://api.github.com/repos/OpenMW/openmw/languages","stargazers_url":"https://api.github.com/repos/OpenMW/openmw/stargazers","contributors_url":"https://api.github.com/repos/OpenMW/openmw/contributors","subscribers_url":"https://api.github.com/repos/OpenMW/openmw/subscribers","subscription_url":"https://api.github.com/repos/OpenMW/openmw/subscription","commits_url":"https://api.github.com/repos/OpenMW/openmw/commits{/sha}","git_commits_url":"https://api.github.com/repos/OpenMW/openmw/git/commits{/sha}","comments_url":"https://api.github.com/repos/OpenMW/openmw/comments{/number}","issue_comment_url":"https://api.github.com/repos/OpenMW/openmw/issues/comments{/number}","contents_url":"https://api.github.com/repos/OpenMW/openmw/contents/{+path}","compare_url":"https://api.github.com/repos/OpenMW/openmw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OpenMW/openmw/merges","archive_url":"https://api.github.com/repos/OpenMW/openmw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OpenMW/openmw/downloads","issues_url":"https://api.github.com/repos/OpenMW/openmw/issues{/number}","pulls_url":"https://api.github.com/repos/OpenMW/openmw/pulls{/number}","milestones_url":"https://api.github.com/repos/OpenMW/openmw/milestones{/number}","notifications_url":"https://api.github.com/repos/OpenMW/openmw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OpenMW/openmw/labels{/name}","releases_url":"https://api.github.com/repos/OpenMW/openmw/releases{/id}","deployments_url":"https://api.github.com/repos/OpenMW/openmw/deployments","created_at":"2009-08-23T14:46:21Z","updated_at":"2018-11-06T00:31:08Z","pushed_at":"2018-11-06T19:44:54Z","git_url":"git://github.com/OpenMW/openmw.git","ssh_url":"[email protected]:OpenMW/openmw.git","clone_url":"https://github.com/OpenMW/openmw.git","svn_url":"https://github.com/OpenMW/openmw","homepage":"http://www.openmw.org/","size":56134,"stargazers_count":2345,"watchers_count":2345,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":672,"mirror_url":null,"archived":false,"open_issues_count":27,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":672,"open_issues":27,"watchers":2345,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OpenMW/openmw/pulls/2021"},"html":{"href":"https://github.com/OpenMW/openmw/pull/2021"},"issue":{"href":"https://api.github.com/repos/OpenMW/openmw/issues/2021"},"comments":{"href":"https://api.github.com/repos/OpenMW/openmw/issues/2021/comments"},"review_comments":{"href":"https://api.github.com/repos/OpenMW/openmw/pulls/2021/comments"},"review_comment":{"href":"https://api.github.com/repos/OpenMW/openmw/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OpenMW/openmw/pulls/2021/commits"},"statuses":{"href":"https://api.github.com/repos/OpenMW/openmw/statuses/d2c2bdadb5ab1f16a79120ffd91623d157e4cf37"}},"author_association":"CONTRIBUTOR"}} | {
"id": 285722,
"name": "OpenMW/openmw",
"url": "https://api.github.com/repos/OpenMW/openmw"
} | {
"id": 1122069,
"login": "psi29a",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1122069?",
"url": "https://api.github.com/users/psi29a"
} | {
"id": 6727417,
"login": "OpenMW",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6727417?",
"url": "https://api.github.com/orgs/OpenMW"
} | 2018-11-06T19:45:30 | 8545113462 | {"actor":{"display_login":"psi29a"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/onfido/onfido-sdk-ui/pulls/comments/205222004","pull_request_review_id":140449953,"id":205222004,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNTIyMjAwNA==","diff_hunk":"@@ -163,8 +163,9 @@ class Confirm extends Component {\n const duration = Math.round(performance.now() - this.startTime)\n sendEvent('Completed upload', {duration, method: this.props.method})\n this.setState({onfidoId: apiResponse.id})\n+ const shouldWarnGlareDetection = this.props.documentType !== 'poa'\n const warnings = apiResponse.sdk_warnings\n- if (warnings && !warnings.detect_glare.valid) {\n+ if (warnings && !warnings.detect_glare.valid && shouldWarnGlareDetection) {","path":"src/components/Confirm/index.js","position":7,"original_position":7,"commit_id":"b1d80ced3f03fe90a60374a163be6175b08f8a35","original_commit_id":"b1d80ced3f03fe90a60374a163be6175b08f8a35","user":{"login":"elhesuu","id":1504258,"node_id":"MDQ6VXNlcjE1MDQyNTg=","avatar_url":"https://avatars2.githubusercontent.com/u/1504258?v=4","gravatar_id":"","url":"https://api.github.com/users/elhesuu","html_url":"https://github.com/elhesuu","followers_url":"https://api.github.com/users/elhesuu/followers","following_url":"https://api.github.com/users/elhesuu/following{/other_user}","gists_url":"https://api.github.com/users/elhesuu/gists{/gist_id}","starred_url":"https://api.github.com/users/elhesuu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elhesuu/subscriptions","organizations_url":"https://api.github.com/users/elhesuu/orgs","repos_url":"https://api.github.com/users/elhesuu/repos","events_url":"https://api.github.com/users/elhesuu/events{/privacy}","received_events_url":"https://api.github.com/users/elhesuu/received_events","type":"User","site_admin":false},"body":"Great, I completely missed it. Thanks @rfreitas ","created_at":"2018-07-25T18:45:25Z","updated_at":"2018-07-25T18:45:26Z","html_url":"https://github.com/onfido/onfido-sdk-ui/pull/375#discussion_r205222004","pull_request_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/pulls/375","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/onfido/onfido-sdk-ui/pulls/comments/205222004"},"html":{"href":"https://github.com/onfido/onfido-sdk-ui/pull/375#discussion_r205222004"},"pull_request":{"href":"https://api.github.com/repos/onfido/onfido-sdk-ui/pulls/375"}},"in_reply_to_id":205140493},"pull_request":{"url":"https://api.github.com/repos/onfido/onfido-sdk-ui/pulls/375","id":202609617,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyNjA5NjE3","html_url":"https://github.com/onfido/onfido-sdk-ui/pull/375","diff_url":"https://github.com/onfido/onfido-sdk-ui/pull/375.diff","patch_url":"https://github.com/onfido/onfido-sdk-ui/pull/375.patch","issue_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/issues/375","number":375,"state":"open","locked":false,"title":"Feature/proof of address document","user":{"login":"elhesuu","id":1504258,"node_id":"MDQ6VXNlcjE1MDQyNTg=","avatar_url":"https://avatars2.githubusercontent.com/u/1504258?v=4","gravatar_id":"","url":"https://api.github.com/users/elhesuu","html_url":"https://github.com/elhesuu","followers_url":"https://api.github.com/users/elhesuu/followers","following_url":"https://api.github.com/users/elhesuu/following{/other_user}","gists_url":"https://api.github.com/users/elhesuu/gists{/gist_id}","starred_url":"https://api.github.com/users/elhesuu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elhesuu/subscriptions","organizations_url":"https://api.github.com/users/elhesuu/orgs","repos_url":"https://api.github.com/users/elhesuu/repos","events_url":"https://api.github.com/users/elhesuu/events{/privacy}","received_events_url":"https://api.github.com/users/elhesuu/received_events","type":"User","site_admin":false},"body":"# Problem\r\nAdd option to initiate `poa` (proof of address) as step.\r\n\r\n# Solution\r\nDisplay document upload screen (without document selection) with \"Proof of address\" as the title, showing only one document side, and upload it as `unknown` type. Glare validation is disabled.\r\n\r\nNote: \r\nDocument validation was requested to be disabled, but as far as I can see it happens on the server side, and can't be disabled in the front end.\r\n\r\n## Checklist\r\n_put `n/a` if item is not relevant to PR changes_\r\n\r\n- [n/a] Have the CHANGELOG, README, MIGRATION, RELEASE_GUIDELINES docs been updated?\r\n- [n/a] Have new automated tests been implemented?\r\n- [n/a] Have new manual tests been written down?\r\n- [ ] Have tests passed locally?\r\n- [x] Have any new strings been translated?\r\n","created_at":"2018-07-19T16:03:09Z","updated_at":"2018-07-25T18:45:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6b1aa2c2cffa8b7a5bedd06c8f4546393dd518e6","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/pulls/375/commits","review_comments_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/pulls/375/comments","review_comment_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/issues/375/comments","statuses_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/statuses/b1d80ced3f03fe90a60374a163be6175b08f8a35","head":{"label":"onfido:feature/proof-of-address-document","ref":"feature/proof-of-address-document","sha":"b1d80ced3f03fe90a60374a163be6175b08f8a35","user":{"login":"onfido","id":6752448,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3NTI0NDg=","avatar_url":"https://avatars3.githubusercontent.com/u/6752448?v=4","gravatar_id":"","url":"https://api.github.com/users/onfido","html_url":"https://github.com/onfido","followers_url":"https://api.github.com/users/onfido/followers","following_url":"https://api.github.com/users/onfido/following{/other_user}","gists_url":"https://api.github.com/users/onfido/gists{/gist_id}","starred_url":"https://api.github.com/users/onfido/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/onfido/subscriptions","organizations_url":"https://api.github.com/users/onfido/orgs","repos_url":"https://api.github.com/users/onfido/repos","events_url":"https://api.github.com/users/onfido/events{/privacy}","received_events_url":"https://api.github.com/users/onfido/received_events","type":"Organization","site_admin":false},"repo":{"id":59305266,"node_id":"MDEwOlJlcG9zaXRvcnk1OTMwNTI2Ng==","name":"onfido-sdk-ui","full_name":"onfido/onfido-sdk-ui","owner":{"login":"onfido","id":6752448,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3NTI0NDg=","avatar_url":"https://avatars3.githubusercontent.com/u/6752448?v=4","gravatar_id":"","url":"https://api.github.com/users/onfido","html_url":"https://github.com/onfido","followers_url":"https://api.github.com/users/onfido/followers","following_url":"https://api.github.com/users/onfido/following{/other_user}","gists_url":"https://api.github.com/users/onfido/gists{/gist_id}","starred_url":"https://api.github.com/users/onfido/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/onfido/subscriptions","organizations_url":"https://api.github.com/users/onfido/orgs","repos_url":"https://api.github.com/users/onfido/repos","events_url":"https://api.github.com/users/onfido/events{/privacy}","received_events_url":"https://api.github.com/users/onfido/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/onfido/onfido-sdk-ui","description":"The Onfido SDK for Front-end JavaScript","fork":false,"url":"https://api.github.com/repos/onfido/onfido-sdk-ui","forks_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/forks","keys_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/teams","hooks_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/hooks","issue_events_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/issues/events{/number}","events_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/events","assignees_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/assignees{/user}","branches_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/branches{/branch}","tags_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/tags","blobs_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/languages","stargazers_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/stargazers","contributors_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/contributors","subscribers_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/subscribers","subscription_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/subscription","commits_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/contents/{+path}","compare_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/merges","archive_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/downloads","issues_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/issues{/number}","pulls_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/labels{/name}","releases_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/releases{/id}","deployments_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/deployments","created_at":"2016-05-20T15:25:36Z","updated_at":"2018-07-17T20:51:12Z","pushed_at":"2018-07-25T17:01:41Z","git_url":"git://github.com/onfido/onfido-sdk-ui.git","ssh_url":"[email protected]:onfido/onfido-sdk-ui.git","clone_url":"https://github.com/onfido/onfido-sdk-ui.git","svn_url":"https://github.com/onfido/onfido-sdk-ui","homepage":"","size":7030,"stargazers_count":43,"watchers_count":43,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":20,"mirror_url":null,"archived":false,"open_issues_count":13,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":20,"open_issues":13,"watchers":43,"default_branch":"master"}},"base":{"label":"onfido:development","ref":"development","sha":"d6e7731a9cbfbb60546214b40ee2964a598de47b","user":{"login":"onfido","id":6752448,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3NTI0NDg=","avatar_url":"https://avatars3.githubusercontent.com/u/6752448?v=4","gravatar_id":"","url":"https://api.github.com/users/onfido","html_url":"https://github.com/onfido","followers_url":"https://api.github.com/users/onfido/followers","following_url":"https://api.github.com/users/onfido/following{/other_user}","gists_url":"https://api.github.com/users/onfido/gists{/gist_id}","starred_url":"https://api.github.com/users/onfido/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/onfido/subscriptions","organizations_url":"https://api.github.com/users/onfido/orgs","repos_url":"https://api.github.com/users/onfido/repos","events_url":"https://api.github.com/users/onfido/events{/privacy}","received_events_url":"https://api.github.com/users/onfido/received_events","type":"Organization","site_admin":false},"repo":{"id":59305266,"node_id":"MDEwOlJlcG9zaXRvcnk1OTMwNTI2Ng==","name":"onfido-sdk-ui","full_name":"onfido/onfido-sdk-ui","owner":{"login":"onfido","id":6752448,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3NTI0NDg=","avatar_url":"https://avatars3.githubusercontent.com/u/6752448?v=4","gravatar_id":"","url":"https://api.github.com/users/onfido","html_url":"https://github.com/onfido","followers_url":"https://api.github.com/users/onfido/followers","following_url":"https://api.github.com/users/onfido/following{/other_user}","gists_url":"https://api.github.com/users/onfido/gists{/gist_id}","starred_url":"https://api.github.com/users/onfido/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/onfido/subscriptions","organizations_url":"https://api.github.com/users/onfido/orgs","repos_url":"https://api.github.com/users/onfido/repos","events_url":"https://api.github.com/users/onfido/events{/privacy}","received_events_url":"https://api.github.com/users/onfido/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/onfido/onfido-sdk-ui","description":"The Onfido SDK for Front-end JavaScript","fork":false,"url":"https://api.github.com/repos/onfido/onfido-sdk-ui","forks_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/forks","keys_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/teams","hooks_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/hooks","issue_events_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/issues/events{/number}","events_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/events","assignees_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/assignees{/user}","branches_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/branches{/branch}","tags_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/tags","blobs_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/languages","stargazers_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/stargazers","contributors_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/contributors","subscribers_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/subscribers","subscription_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/subscription","commits_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/contents/{+path}","compare_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/merges","archive_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/downloads","issues_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/issues{/number}","pulls_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/labels{/name}","releases_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/releases{/id}","deployments_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/deployments","created_at":"2016-05-20T15:25:36Z","updated_at":"2018-07-17T20:51:12Z","pushed_at":"2018-07-25T17:01:41Z","git_url":"git://github.com/onfido/onfido-sdk-ui.git","ssh_url":"[email protected]:onfido/onfido-sdk-ui.git","clone_url":"https://github.com/onfido/onfido-sdk-ui.git","svn_url":"https://github.com/onfido/onfido-sdk-ui","homepage":"","size":7030,"stargazers_count":43,"watchers_count":43,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":20,"mirror_url":null,"archived":false,"open_issues_count":13,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":20,"open_issues":13,"watchers":43,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/onfido/onfido-sdk-ui/pulls/375"},"html":{"href":"https://github.com/onfido/onfido-sdk-ui/pull/375"},"issue":{"href":"https://api.github.com/repos/onfido/onfido-sdk-ui/issues/375"},"comments":{"href":"https://api.github.com/repos/onfido/onfido-sdk-ui/issues/375/comments"},"review_comments":{"href":"https://api.github.com/repos/onfido/onfido-sdk-ui/pulls/375/comments"},"review_comment":{"href":"https://api.github.com/repos/onfido/onfido-sdk-ui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/onfido/onfido-sdk-ui/pulls/375/commits"},"statuses":{"href":"https://api.github.com/repos/onfido/onfido-sdk-ui/statuses/b1d80ced3f03fe90a60374a163be6175b08f8a35"}},"author_association":"COLLABORATOR"}} | {
"id": 59305266,
"name": "onfido/onfido-sdk-ui",
"url": "https://api.github.com/repos/onfido/onfido-sdk-ui"
} | {
"id": 1504258,
"login": "elhesuu",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1504258?",
"url": "https://api.github.com/users/elhesuu"
} | {
"id": 6752448,
"login": "onfido",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6752448?",
"url": "https://api.github.com/orgs/onfido"
} | 2018-07-25T18:45:25 | 8018336160 | {"actor":{"display_login":"elhesuu"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/elastic/elasticsearch/pulls/comments/211567663","pull_request_review_id":148012718,"id":211567663,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMTU2NzY2Mw==","diff_hunk":"@@ -177,18 +132,20 @@ public static Mapper getFieldMapper(MapperService mapperService, String field) {\n continue;\n }\n \n- // Ignore fields that are not in the allowed mapper types. Some\n- // types do not support term queries, and thus we cannot generate\n- // a special query for them.\n- String mappingType = fieldType.typeName();\n- if (acceptAllTypes == false && ALLOWED_QUERY_MAPPER_TYPES.contains(mappingType) == false) {\n+ if (acceptMetadataField == false && fieldType.name().startsWith(\"_\")) {\n+ // Ignore metadata fields\n continue;\n }\n \n- // Ignore metadata fields.\n- Mapper mapper = getFieldMapper(context.getMapperService(), fieldName);\n- if (acceptMetadataField == false && mapper instanceof MetadataFieldMapper) {\n- continue;\n+ if (acceptAllTypes == false) {\n+ try {\n+ fieldType.termQuery(\"\", context);\n+ } catch (QueryShardException |UnsupportedOperationException e) {\n+ // field type is never searchable with term queries (eg. geo point): ignore\n+ continue;\n+ } catch (RuntimeException e) {\n+ // other exceptions are parsing errors or not indexed fields: keep","path":"server/src/main/java/org/elasticsearch/index/search/QueryParserHelper.java","position":116,"original_position":116,"commit_id":"45197d482078bd7ae95ba8067977acd5ad3718ad","original_commit_id":"45197d482078bd7ae95ba8067977acd5ad3718ad","user":{"login":"jimczi","id":15977469,"node_id":"MDQ6VXNlcjE1OTc3NDY5","avatar_url":"https://avatars0.githubusercontent.com/u/15977469?v=4","gravatar_id":"","url":"https://api.github.com/users/jimczi","html_url":"https://github.com/jimczi","followers_url":"https://api.github.com/users/jimczi/followers","following_url":"https://api.github.com/users/jimczi/following{/other_user}","gists_url":"https://api.github.com/users/jimczi/gists{/gist_id}","starred_url":"https://api.github.com/users/jimczi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimczi/subscriptions","organizations_url":"https://api.github.com/users/jimczi/orgs","repos_url":"https://api.github.com/users/jimczi/repos","events_url":"https://api.github.com/users/jimczi/events{/privacy}","received_events_url":"https://api.github.com/users/jimczi/received_events","type":"User","site_admin":false},"body":"No, this case is for field mappers that need a special input (numbers, boolean, ...) so this is consistent with the current behavior. The goal here is to select fields that can handle a `term` query so we silently ignore those that can't. Previously this selection was based on an hardcoded list of field types.","created_at":"2018-08-21T11:19:16Z","updated_at":"2018-08-21T11:19:16Z","html_url":"https://github.com/elastic/elasticsearch/pull/33020#discussion_r211567663","pull_request_url":"https://api.github.com/repos/elastic/elasticsearch/pulls/33020","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/comments/211567663"},"html":{"href":"https://github.com/elastic/elasticsearch/pull/33020#discussion_r211567663"},"pull_request":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/33020"}},"in_reply_to_id":211563835},"pull_request":{"url":"https://api.github.com/repos/elastic/elasticsearch/pulls/33020","id":209784116,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA5Nzg0MTE2","html_url":"https://github.com/elastic/elasticsearch/pull/33020","diff_url":"https://github.com/elastic/elasticsearch/pull/33020.diff","patch_url":"https://github.com/elastic/elasticsearch/pull/33020.patch","issue_url":"https://api.github.com/repos/elastic/elasticsearch/issues/33020","number":33020,"state":"open","locked":false,"title":"Change query field expansion","user":{"login":"jimczi","id":15977469,"node_id":"MDQ6VXNlcjE1OTc3NDY5","avatar_url":"https://avatars0.githubusercontent.com/u/15977469?v=4","gravatar_id":"","url":"https://api.github.com/users/jimczi","html_url":"https://github.com/jimczi","followers_url":"https://api.github.com/users/jimczi/followers","following_url":"https://api.github.com/users/jimczi/following{/other_user}","gists_url":"https://api.github.com/users/jimczi/gists{/gist_id}","starred_url":"https://api.github.com/users/jimczi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimczi/subscriptions","organizations_url":"https://api.github.com/users/jimczi/orgs","repos_url":"https://api.github.com/users/jimczi/repos","events_url":"https://api.github.com/users/jimczi/events{/privacy}","received_events_url":"https://api.github.com/users/jimczi/received_events","type":"User","site_admin":false},"body":"This commit changes the query field expansion for query parsers\r\nto not rely on an hardcoded list of field types. Instead we rely on\r\nthe type of exception that is thrown by MappedFieldType#termQuery to\r\ninclude/exclude an expanded field.\r\n\r\nSupersedes #31655\r\n\r\nCloses #31798","created_at":"2018-08-21T10:47:58Z","updated_at":"2018-08-21T11:19:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"78dd16f81e7ddddc3b0da9d0e1b1897ddbb471ef","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":146832564,"node_id":"MDU6TGFiZWwxNDY4MzI1NjQ=","url":"https://api.github.com/repos/elastic/elasticsearch/labels/:Search/Search","name":":Search/Search","color":"0e8a16","default":false},{"id":23174,"node_id":"MDU6TGFiZWwyMzE3NA==","url":"https://api.github.com/repos/elastic/elasticsearch/labels/%3Eenhancement","name":">enhancement","color":"4a4ea8","default":false},{"id":962378555,"node_id":"MDU6TGFiZWw5NjIzNzg1NTU=","url":"https://api.github.com/repos/elastic/elasticsearch/labels/v6.5.0","name":"v6.5.0","color":"Dddddd","default":false},{"id":484855464,"node_id":"MDU6TGFiZWw0ODQ4NTU0NjQ=","url":"https://api.github.com/repos/elastic/elasticsearch/labels/v7.0.0","name":"v7.0.0","color":"dddddd","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/elastic/elasticsearch/pulls/33020/commits","review_comments_url":"https://api.github.com/repos/elastic/elasticsearch/pulls/33020/comments","review_comment_url":"https://api.github.com/repos/elastic/elasticsearch/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elastic/elasticsearch/issues/33020/comments","statuses_url":"https://api.github.com/repos/elastic/elasticsearch/statuses/45197d482078bd7ae95ba8067977acd5ad3718ad","head":{"label":"jimczi:query_fields_expansion","ref":"query_fields_expansion","sha":"45197d482078bd7ae95ba8067977acd5ad3718ad","user":{"login":"jimczi","id":15977469,"node_id":"MDQ6VXNlcjE1OTc3NDY5","avatar_url":"https://avatars0.githubusercontent.com/u/15977469?v=4","gravatar_id":"","url":"https://api.github.com/users/jimczi","html_url":"https://github.com/jimczi","followers_url":"https://api.github.com/users/jimczi/followers","following_url":"https://api.github.com/users/jimczi/following{/other_user}","gists_url":"https://api.github.com/users/jimczi/gists{/gist_id}","starred_url":"https://api.github.com/users/jimczi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimczi/subscriptions","organizations_url":"https://api.github.com/users/jimczi/orgs","repos_url":"https://api.github.com/users/jimczi/repos","events_url":"https://api.github.com/users/jimczi/events{/privacy}","received_events_url":"https://api.github.com/users/jimczi/received_events","type":"User","site_admin":false},"repo":{"id":91054845,"node_id":"MDEwOlJlcG9zaXRvcnk5MTA1NDg0NQ==","name":"elasticsearch","full_name":"jimczi/elasticsearch","owner":{"login":"jimczi","id":15977469,"node_id":"MDQ6VXNlcjE1OTc3NDY5","avatar_url":"https://avatars0.githubusercontent.com/u/15977469?v=4","gravatar_id":"","url":"https://api.github.com/users/jimczi","html_url":"https://github.com/jimczi","followers_url":"https://api.github.com/users/jimczi/followers","following_url":"https://api.github.com/users/jimczi/following{/other_user}","gists_url":"https://api.github.com/users/jimczi/gists{/gist_id}","starred_url":"https://api.github.com/users/jimczi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimczi/subscriptions","organizations_url":"https://api.github.com/users/jimczi/orgs","repos_url":"https://api.github.com/users/jimczi/repos","events_url":"https://api.github.com/users/jimczi/events{/privacy}","received_events_url":"https://api.github.com/users/jimczi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jimczi/elasticsearch","description":"Open Source, Distributed, RESTful Search Engine","fork":true,"url":"https://api.github.com/repos/jimczi/elasticsearch","forks_url":"https://api.github.com/repos/jimczi/elasticsearch/forks","keys_url":"https://api.github.com/repos/jimczi/elasticsearch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jimczi/elasticsearch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jimczi/elasticsearch/teams","hooks_url":"https://api.github.com/repos/jimczi/elasticsearch/hooks","issue_events_url":"https://api.github.com/repos/jimczi/elasticsearch/issues/events{/number}","events_url":"https://api.github.com/repos/jimczi/elasticsearch/events","assignees_url":"https://api.github.com/repos/jimczi/elasticsearch/assignees{/user}","branches_url":"https://api.github.com/repos/jimczi/elasticsearch/branches{/branch}","tags_url":"https://api.github.com/repos/jimczi/elasticsearch/tags","blobs_url":"https://api.github.com/repos/jimczi/elasticsearch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jimczi/elasticsearch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jimczi/elasticsearch/git/refs{/sha}","trees_url":"https://api.github.com/repos/jimczi/elasticsearch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jimczi/elasticsearch/statuses/{sha}","languages_url":"https://api.github.com/repos/jimczi/elasticsearch/languages","stargazers_url":"https://api.github.com/repos/jimczi/elasticsearch/stargazers","contributors_url":"https://api.github.com/repos/jimczi/elasticsearch/contributors","subscribers_url":"https://api.github.com/repos/jimczi/elasticsearch/subscribers","subscription_url":"https://api.github.com/repos/jimczi/elasticsearch/subscription","commits_url":"https://api.github.com/repos/jimczi/elasticsearch/commits{/sha}","git_commits_url":"https://api.github.com/repos/jimczi/elasticsearch/git/commits{/sha}","comments_url":"https://api.github.com/repos/jimczi/elasticsearch/comments{/number}","issue_comment_url":"https://api.github.com/repos/jimczi/elasticsearch/issues/comments{/number}","contents_url":"https://api.github.com/repos/jimczi/elasticsearch/contents/{+path}","compare_url":"https://api.github.com/repos/jimczi/elasticsearch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jimczi/elasticsearch/merges","archive_url":"https://api.github.com/repos/jimczi/elasticsearch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jimczi/elasticsearch/downloads","issues_url":"https://api.github.com/repos/jimczi/elasticsearch/issues{/number}","pulls_url":"https://api.github.com/repos/jimczi/elasticsearch/pulls{/number}","milestones_url":"https://api.github.com/repos/jimczi/elasticsearch/milestones{/number}","notifications_url":"https://api.github.com/repos/jimczi/elasticsearch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jimczi/elasticsearch/labels{/name}","releases_url":"https://api.github.com/repos/jimczi/elasticsearch/releases{/id}","deployments_url":"https://api.github.com/repos/jimczi/elasticsearch/deployments","created_at":"2017-05-12T05:31:39Z","updated_at":"2017-05-12T05:32:12Z","pushed_at":"2018-08-21T11:04:41Z","git_url":"git://github.com/jimczi/elasticsearch.git","ssh_url":"[email protected]:jimczi/elasticsearch.git","clone_url":"https://github.com/jimczi/elasticsearch.git","svn_url":"https://github.com/jimczi/elasticsearch","homepage":"https://www.elastic.co/products/elasticsearch","size":448289,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"elastic:master","ref":"master","sha":"92076497e507ab27bbb603f8dbcc6c2e236eaafa","user":{"login":"elastic","id":6764390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3NjQzOTA=","avatar_url":"https://avatars0.githubusercontent.com/u/6764390?v=4","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"repo":{"id":507775,"node_id":"MDEwOlJlcG9zaXRvcnk1MDc3NzU=","name":"elasticsearch","full_name":"elastic/elasticsearch","owner":{"login":"elastic","id":6764390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3NjQzOTA=","avatar_url":"https://avatars0.githubusercontent.com/u/6764390?v=4","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elastic/elasticsearch","description":"Open Source, Distributed, RESTful Search Engine","fork":false,"url":"https://api.github.com/repos/elastic/elasticsearch","forks_url":"https://api.github.com/repos/elastic/elasticsearch/forks","keys_url":"https://api.github.com/repos/elastic/elasticsearch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elastic/elasticsearch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elastic/elasticsearch/teams","hooks_url":"https://api.github.com/repos/elastic/elasticsearch/hooks","issue_events_url":"https://api.github.com/repos/elastic/elasticsearch/issues/events{/number}","events_url":"https://api.github.com/repos/elastic/elasticsearch/events","assignees_url":"https://api.github.com/repos/elastic/elasticsearch/assignees{/user}","branches_url":"https://api.github.com/repos/elastic/elasticsearch/branches{/branch}","tags_url":"https://api.github.com/repos/elastic/elasticsearch/tags","blobs_url":"https://api.github.com/repos/elastic/elasticsearch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elastic/elasticsearch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elastic/elasticsearch/git/refs{/sha}","trees_url":"https://api.github.com/repos/elastic/elasticsearch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elastic/elasticsearch/statuses/{sha}","languages_url":"https://api.github.com/repos/elastic/elasticsearch/languages","stargazers_url":"https://api.github.com/repos/elastic/elasticsearch/stargazers","contributors_url":"https://api.github.com/repos/elastic/elasticsearch/contributors","subscribers_url":"https://api.github.com/repos/elastic/elasticsearch/subscribers","subscription_url":"https://api.github.com/repos/elastic/elasticsearch/subscription","commits_url":"https://api.github.com/repos/elastic/elasticsearch/commits{/sha}","git_commits_url":"https://api.github.com/repos/elastic/elasticsearch/git/commits{/sha}","comments_url":"https://api.github.com/repos/elastic/elasticsearch/comments{/number}","issue_comment_url":"https://api.github.com/repos/elastic/elasticsearch/issues/comments{/number}","contents_url":"https://api.github.com/repos/elastic/elasticsearch/contents/{+path}","compare_url":"https://api.github.com/repos/elastic/elasticsearch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elastic/elasticsearch/merges","archive_url":"https://api.github.com/repos/elastic/elasticsearch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elastic/elasticsearch/downloads","issues_url":"https://api.github.com/repos/elastic/elasticsearch/issues{/number}","pulls_url":"https://api.github.com/repos/elastic/elasticsearch/pulls{/number}","milestones_url":"https://api.github.com/repos/elastic/elasticsearch/milestones{/number}","notifications_url":"https://api.github.com/repos/elastic/elasticsearch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elastic/elasticsearch/labels{/name}","releases_url":"https://api.github.com/repos/elastic/elasticsearch/releases{/id}","deployments_url":"https://api.github.com/repos/elastic/elasticsearch/deployments","created_at":"2010-02-08T13:20:56Z","updated_at":"2018-08-21T10:44:22Z","pushed_at":"2018-08-21T11:17:38Z","git_url":"git://github.com/elastic/elasticsearch.git","ssh_url":"[email protected]:elastic/elasticsearch.git","clone_url":"https://github.com/elastic/elasticsearch.git","svn_url":"https://github.com/elastic/elasticsearch","homepage":"https://www.elastic.co/products/elasticsearch","size":504094,"stargazers_count":33628,"watchers_count":33628,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11428,"mirror_url":null,"archived":false,"open_issues_count":1611,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":11428,"open_issues":1611,"watchers":33628,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/33020"},"html":{"href":"https://github.com/elastic/elasticsearch/pull/33020"},"issue":{"href":"https://api.github.com/repos/elastic/elasticsearch/issues/33020"},"comments":{"href":"https://api.github.com/repos/elastic/elasticsearch/issues/33020/comments"},"review_comments":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/33020/comments"},"review_comment":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/33020/commits"},"statuses":{"href":"https://api.github.com/repos/elastic/elasticsearch/statuses/45197d482078bd7ae95ba8067977acd5ad3718ad"}},"author_association":"MEMBER"}} | {
"id": 507775,
"name": "elastic/elasticsearch",
"url": "https://api.github.com/repos/elastic/elasticsearch"
} | {
"id": 15977469,
"login": "jimczi",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/15977469?",
"url": "https://api.github.com/users/jimczi"
} | {
"id": 6764390,
"login": "elastic",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6764390?",
"url": "https://api.github.com/orgs/elastic"
} | 2018-08-21T11:19:16 | 8143571641 | {"actor":{"display_login":"jimczi"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/elastic/kibana/pulls/comments/209932962","pull_request_review_id":146040641,"id":209932962,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwOTkzMjk2Mg==","diff_hunk":"@@ -31,7 +31,7 @@ process.env.kbnWorkerType = 'managr';\n export default class ClusterManager {\n static async create(opts = {}, settings = {}) {\n const transformedSettings = transformDeprecations(settings);\n- const config = await Config.withDefaultSchema(transformedSettings);\n+ const config = Config.withDefaultSchema(transformedSettings);","path":"src/cli/cluster/cluster_manager.js","position":5,"original_position":5,"commit_id":"9922cb2fe56dfaa70f71c18d811a760f3d0cdcd4","original_commit_id":"9922cb2fe56dfaa70f71c18d811a760f3d0cdcd4","user":{"login":"azasypkin","id":1713708,"node_id":"MDQ6VXNlcjE3MTM3MDg=","avatar_url":"https://avatars1.githubusercontent.com/u/1713708?v=4","gravatar_id":"","url":"https://api.github.com/users/azasypkin","html_url":"https://github.com/azasypkin","followers_url":"https://api.github.com/users/azasypkin/followers","following_url":"https://api.github.com/users/azasypkin/following{/other_user}","gists_url":"https://api.github.com/users/azasypkin/gists{/gist_id}","starred_url":"https://api.github.com/users/azasypkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/azasypkin/subscriptions","organizations_url":"https://api.github.com/users/azasypkin/orgs","repos_url":"https://api.github.com/users/azasypkin/repos","events_url":"https://api.github.com/users/azasypkin/events{/privacy}","received_events_url":"https://api.github.com/users/azasypkin/received_events","type":"User","site_admin":false},"body":"Hmm, thanks for sharing! You have quite a few smart defaults :)","created_at":"2018-08-14T12:35:12Z","updated_at":"2018-08-14T12:35:12Z","html_url":"https://github.com/elastic/kibana/pull/21831#discussion_r209932962","pull_request_url":"https://api.github.com/repos/elastic/kibana/pulls/21831","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/elastic/kibana/pulls/comments/209932962"},"html":{"href":"https://github.com/elastic/kibana/pull/21831#discussion_r209932962"},"pull_request":{"href":"https://api.github.com/repos/elastic/kibana/pulls/21831"}},"in_reply_to_id":208875293},"pull_request":{"url":"https://api.github.com/repos/elastic/kibana/pulls/21831","id":207263412,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3MjYzNDEy","html_url":"https://github.com/elastic/kibana/pull/21831","diff_url":"https://github.com/elastic/kibana/pull/21831.diff","patch_url":"https://github.com/elastic/kibana/pull/21831.patch","issue_url":"https://api.github.com/repos/elastic/kibana/issues/21831","number":21831,"state":"open","locked":false,"title":"Make core logging independent from the legacy Kibana.","user":{"login":"azasypkin","id":1713708,"node_id":"MDQ6VXNlcjE3MTM3MDg=","avatar_url":"https://avatars1.githubusercontent.com/u/1713708?v=4","gravatar_id":"","url":"https://api.github.com/users/azasypkin","html_url":"https://github.com/azasypkin","followers_url":"https://api.github.com/users/azasypkin/followers","following_url":"https://api.github.com/users/azasypkin/following{/other_user}","gists_url":"https://api.github.com/users/azasypkin/gists{/gist_id}","starred_url":"https://api.github.com/users/azasypkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/azasypkin/subscriptions","organizations_url":"https://api.github.com/users/azasypkin/orgs","repos_url":"https://api.github.com/users/azasypkin/repos","events_url":"https://api.github.com/users/azasypkin/events{/privacy}","received_events_url":"https://api.github.com/users/azasypkin/received_events","type":"User","site_admin":false},"body":"In this PR I decouple core logging from the \"legacy\" `kbnServer.server.log` so that core can log _before_ \"legacy\" Kibana is started or not started at all (e.g. `ClusterManager` process). It also eliminates the need in passing `env` that deep in core services/system hierarchy (`env` should have been passed to `Appenders` factory).\r\n\r\nSurely it may look a bit hackish, but this logging backward compatibility bridge is supposed to die as soon as we switch entire Kibana to use the core own logging system.\r\n\r\nUnblocks https://github.com/elastic/kibana/pull/19994","created_at":"2018-08-09T10:02:41Z","updated_at":"2018-08-14T12:35:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2b0c505444506ec866d6b2ca3c4a98e39a014fa4","assignee":null,"assignees":[],"requested_reviewers":[{"login":"epixa","id":53814,"node_id":"MDQ6VXNlcjUzODE0","avatar_url":"https://avatars0.githubusercontent.com/u/53814?v=4","gravatar_id":"","url":"https://api.github.com/users/epixa","html_url":"https://github.com/epixa","followers_url":"https://api.github.com/users/epixa/followers","following_url":"https://api.github.com/users/epixa/following{/other_user}","gists_url":"https://api.github.com/users/epixa/gists{/gist_id}","starred_url":"https://api.github.com/users/epixa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/epixa/subscriptions","organizations_url":"https://api.github.com/users/epixa/orgs","repos_url":"https://api.github.com/users/epixa/repos","events_url":"https://api.github.com/users/epixa/events{/privacy}","received_events_url":"https://api.github.com/users/epixa/received_events","type":"User","site_admin":false},{"login":"spalger","id":1329312,"node_id":"MDQ6VXNlcjEzMjkzMTI=","avatar_url":"https://avatars1.githubusercontent.com/u/1329312?v=4","gravatar_id":"","url":"https://api.github.com/users/spalger","html_url":"https://github.com/spalger","followers_url":"https://api.github.com/users/spalger/followers","following_url":"https://api.github.com/users/spalger/following{/other_user}","gists_url":"https://api.github.com/users/spalger/gists{/gist_id}","starred_url":"https://api.github.com/users/spalger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spalger/subscriptions","organizations_url":"https://api.github.com/users/spalger/orgs","repos_url":"https://api.github.com/users/spalger/repos","events_url":"https://api.github.com/users/spalger/events{/privacy}","received_events_url":"https://api.github.com/users/spalger/received_events","type":"User","site_admin":false},{"login":"archanid","id":13165182,"node_id":"MDQ6VXNlcjEzMTY1MTgy","avatar_url":"https://avatars3.githubusercontent.com/u/13165182?v=4","gravatar_id":"","url":"https://api.github.com/users/archanid","html_url":"https://github.com/archanid","followers_url":"https://api.github.com/users/archanid/followers","following_url":"https://api.github.com/users/archanid/following{/other_user}","gists_url":"https://api.github.com/users/archanid/gists{/gist_id}","starred_url":"https://api.github.com/users/archanid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/archanid/subscriptions","organizations_url":"https://api.github.com/users/archanid/orgs","repos_url":"https://api.github.com/users/archanid/repos","events_url":"https://api.github.com/users/archanid/events{/privacy}","received_events_url":"https://api.github.com/users/archanid/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":635458035,"node_id":"MDU6TGFiZWw2MzU0NTgwMzU=","url":"https://api.github.com/repos/elastic/kibana/labels/:New%20Platform","name":":New Platform","color":"009800","default":false},{"id":470241278,"node_id":"MDU6TGFiZWw0NzAyNDEyNzg=","url":"https://api.github.com/repos/elastic/kibana/labels/:Platform","name":":Platform","color":"fef2c0","default":false},{"id":912973198,"node_id":"MDU6TGFiZWw5MTI5NzMxOTg=","url":"https://api.github.com/repos/elastic/kibana/labels/v6.5.0","name":"v6.5.0","color":"ffffff","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/elastic/kibana/pulls/21831/commits","review_comments_url":"https://api.github.com/repos/elastic/kibana/pulls/21831/comments","review_comment_url":"https://api.github.com/repos/elastic/kibana/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elastic/kibana/issues/21831/comments","statuses_url":"https://api.github.com/repos/elastic/kibana/statuses/9922cb2fe56dfaa70f71c18d811a760f3d0cdcd4","head":{"label":"azasypkin:issue-xxx-core-independent-logging","ref":"issue-xxx-core-independent-logging","sha":"9922cb2fe56dfaa70f71c18d811a760f3d0cdcd4","user":{"login":"azasypkin","id":1713708,"node_id":"MDQ6VXNlcjE3MTM3MDg=","avatar_url":"https://avatars1.githubusercontent.com/u/1713708?v=4","gravatar_id":"","url":"https://api.github.com/users/azasypkin","html_url":"https://github.com/azasypkin","followers_url":"https://api.github.com/users/azasypkin/followers","following_url":"https://api.github.com/users/azasypkin/following{/other_user}","gists_url":"https://api.github.com/users/azasypkin/gists{/gist_id}","starred_url":"https://api.github.com/users/azasypkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/azasypkin/subscriptions","organizations_url":"https://api.github.com/users/azasypkin/orgs","repos_url":"https://api.github.com/users/azasypkin/repos","events_url":"https://api.github.com/users/azasypkin/events{/privacy}","received_events_url":"https://api.github.com/users/azasypkin/received_events","type":"User","site_admin":false},"repo":{"id":92031734,"node_id":"MDEwOlJlcG9zaXRvcnk5MjAzMTczNA==","name":"kibana","full_name":"azasypkin/kibana","owner":{"login":"azasypkin","id":1713708,"node_id":"MDQ6VXNlcjE3MTM3MDg=","avatar_url":"https://avatars1.githubusercontent.com/u/1713708?v=4","gravatar_id":"","url":"https://api.github.com/users/azasypkin","html_url":"https://github.com/azasypkin","followers_url":"https://api.github.com/users/azasypkin/followers","following_url":"https://api.github.com/users/azasypkin/following{/other_user}","gists_url":"https://api.github.com/users/azasypkin/gists{/gist_id}","starred_url":"https://api.github.com/users/azasypkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/azasypkin/subscriptions","organizations_url":"https://api.github.com/users/azasypkin/orgs","repos_url":"https://api.github.com/users/azasypkin/repos","events_url":"https://api.github.com/users/azasypkin/events{/privacy}","received_events_url":"https://api.github.com/users/azasypkin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/azasypkin/kibana","description":":bar_chart: Kibana analytics and search dashboard for Elasticsearch","fork":true,"url":"https://api.github.com/repos/azasypkin/kibana","forks_url":"https://api.github.com/repos/azasypkin/kibana/forks","keys_url":"https://api.github.com/repos/azasypkin/kibana/keys{/key_id}","collaborators_url":"https://api.github.com/repos/azasypkin/kibana/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/azasypkin/kibana/teams","hooks_url":"https://api.github.com/repos/azasypkin/kibana/hooks","issue_events_url":"https://api.github.com/repos/azasypkin/kibana/issues/events{/number}","events_url":"https://api.github.com/repos/azasypkin/kibana/events","assignees_url":"https://api.github.com/repos/azasypkin/kibana/assignees{/user}","branches_url":"https://api.github.com/repos/azasypkin/kibana/branches{/branch}","tags_url":"https://api.github.com/repos/azasypkin/kibana/tags","blobs_url":"https://api.github.com/repos/azasypkin/kibana/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/azasypkin/kibana/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/azasypkin/kibana/git/refs{/sha}","trees_url":"https://api.github.com/repos/azasypkin/kibana/git/trees{/sha}","statuses_url":"https://api.github.com/repos/azasypkin/kibana/statuses/{sha}","languages_url":"https://api.github.com/repos/azasypkin/kibana/languages","stargazers_url":"https://api.github.com/repos/azasypkin/kibana/stargazers","contributors_url":"https://api.github.com/repos/azasypkin/kibana/contributors","subscribers_url":"https://api.github.com/repos/azasypkin/kibana/subscribers","subscription_url":"https://api.github.com/repos/azasypkin/kibana/subscription","commits_url":"https://api.github.com/repos/azasypkin/kibana/commits{/sha}","git_commits_url":"https://api.github.com/repos/azasypkin/kibana/git/commits{/sha}","comments_url":"https://api.github.com/repos/azasypkin/kibana/comments{/number}","issue_comment_url":"https://api.github.com/repos/azasypkin/kibana/issues/comments{/number}","contents_url":"https://api.github.com/repos/azasypkin/kibana/contents/{+path}","compare_url":"https://api.github.com/repos/azasypkin/kibana/compare/{base}...{head}","merges_url":"https://api.github.com/repos/azasypkin/kibana/merges","archive_url":"https://api.github.com/repos/azasypkin/kibana/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/azasypkin/kibana/downloads","issues_url":"https://api.github.com/repos/azasypkin/kibana/issues{/number}","pulls_url":"https://api.github.com/repos/azasypkin/kibana/pulls{/number}","milestones_url":"https://api.github.com/repos/azasypkin/kibana/milestones{/number}","notifications_url":"https://api.github.com/repos/azasypkin/kibana/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/azasypkin/kibana/labels{/name}","releases_url":"https://api.github.com/repos/azasypkin/kibana/releases{/id}","deployments_url":"https://api.github.com/repos/azasypkin/kibana/deployments","created_at":"2017-05-22T08:45:03Z","updated_at":"2018-04-11T12:45:47Z","pushed_at":"2018-08-14T10:11:43Z","git_url":"git://github.com/azasypkin/kibana.git","ssh_url":"[email protected]:azasypkin/kibana.git","clone_url":"https://github.com/azasypkin/kibana.git","svn_url":"https://github.com/azasypkin/kibana","homepage":"https://www.elastic.co/products/kibana","size":423253,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"elastic:master","ref":"master","sha":"4cd9699108ce5e29699255a990aedeee58785e82","user":{"login":"elastic","id":6764390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3NjQzOTA=","avatar_url":"https://avatars0.githubusercontent.com/u/6764390?v=4","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"repo":{"id":7833168,"node_id":"MDEwOlJlcG9zaXRvcnk3ODMzMTY4","name":"kibana","full_name":"elastic/kibana","owner":{"login":"elastic","id":6764390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3NjQzOTA=","avatar_url":"https://avatars0.githubusercontent.com/u/6764390?v=4","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elastic/kibana","description":":bar_chart: Kibana analytics and search dashboard for Elasticsearch","fork":false,"url":"https://api.github.com/repos/elastic/kibana","forks_url":"https://api.github.com/repos/elastic/kibana/forks","keys_url":"https://api.github.com/repos/elastic/kibana/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elastic/kibana/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elastic/kibana/teams","hooks_url":"https://api.github.com/repos/elastic/kibana/hooks","issue_events_url":"https://api.github.com/repos/elastic/kibana/issues/events{/number}","events_url":"https://api.github.com/repos/elastic/kibana/events","assignees_url":"https://api.github.com/repos/elastic/kibana/assignees{/user}","branches_url":"https://api.github.com/repos/elastic/kibana/branches{/branch}","tags_url":"https://api.github.com/repos/elastic/kibana/tags","blobs_url":"https://api.github.com/repos/elastic/kibana/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elastic/kibana/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elastic/kibana/git/refs{/sha}","trees_url":"https://api.github.com/repos/elastic/kibana/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elastic/kibana/statuses/{sha}","languages_url":"https://api.github.com/repos/elastic/kibana/languages","stargazers_url":"https://api.github.com/repos/elastic/kibana/stargazers","contributors_url":"https://api.github.com/repos/elastic/kibana/contributors","subscribers_url":"https://api.github.com/repos/elastic/kibana/subscribers","subscription_url":"https://api.github.com/repos/elastic/kibana/subscription","commits_url":"https://api.github.com/repos/elastic/kibana/commits{/sha}","git_commits_url":"https://api.github.com/repos/elastic/kibana/git/commits{/sha}","comments_url":"https://api.github.com/repos/elastic/kibana/comments{/number}","issue_comment_url":"https://api.github.com/repos/elastic/kibana/issues/comments{/number}","contents_url":"https://api.github.com/repos/elastic/kibana/contents/{+path}","compare_url":"https://api.github.com/repos/elastic/kibana/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elastic/kibana/merges","archive_url":"https://api.github.com/repos/elastic/kibana/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elastic/kibana/downloads","issues_url":"https://api.github.com/repos/elastic/kibana/issues{/number}","pulls_url":"https://api.github.com/repos/elastic/kibana/pulls{/number}","milestones_url":"https://api.github.com/repos/elastic/kibana/milestones{/number}","notifications_url":"https://api.github.com/repos/elastic/kibana/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elastic/kibana/labels{/name}","releases_url":"https://api.github.com/repos/elastic/kibana/releases{/id}","deployments_url":"https://api.github.com/repos/elastic/kibana/deployments","created_at":"2013-01-26T04:00:59Z","updated_at":"2018-08-14T12:00:11Z","pushed_at":"2018-08-14T11:58:47Z","git_url":"git://github.com/elastic/kibana.git","ssh_url":"[email protected]:elastic/kibana.git","clone_url":"https://github.com/elastic/kibana.git","svn_url":"https://github.com/elastic/kibana","homepage":"https://www.elastic.co/products/kibana","size":437706,"stargazers_count":9868,"watchers_count":9868,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3848,"mirror_url":null,"archived":false,"open_issues_count":3305,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":3848,"open_issues":3305,"watchers":9868,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elastic/kibana/pulls/21831"},"html":{"href":"https://github.com/elastic/kibana/pull/21831"},"issue":{"href":"https://api.github.com/repos/elastic/kibana/issues/21831"},"comments":{"href":"https://api.github.com/repos/elastic/kibana/issues/21831/comments"},"review_comments":{"href":"https://api.github.com/repos/elastic/kibana/pulls/21831/comments"},"review_comment":{"href":"https://api.github.com/repos/elastic/kibana/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elastic/kibana/pulls/21831/commits"},"statuses":{"href":"https://api.github.com/repos/elastic/kibana/statuses/9922cb2fe56dfaa70f71c18d811a760f3d0cdcd4"}},"author_association":"MEMBER"}} | {
"id": 7833168,
"name": "elastic/kibana",
"url": "https://api.github.com/repos/elastic/kibana"
} | {
"id": 1713708,
"login": "azasypkin",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1713708?",
"url": "https://api.github.com/users/azasypkin"
} | {
"id": 6764390,
"login": "elastic",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6764390?",
"url": "https://api.github.com/orgs/elastic"
} | 2018-08-14T12:35:12 | 8110916108 | {"actor":{"display_login":"azasypkin"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/elastic/kibana/pulls/comments/245092713","pull_request_review_id":189130539,"id":245092713,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NTA5MjcxMw==","diff_hunk":"@@ -0,0 +1,17 @@\n+`xpack.infra.enabled`:: Set to `false` to disable the Logs and Infrastructure UI plugin {kib}. Defaults to `true`.\n+\n+`xpack.infra.sources.default.logAlias`:: Index pattern for matching indices that contain log data. Defaults to `filebeat-*`.\n+\n+`xpack.infra.sources.default.metricAlias`:: Index pattern for matching indices that contain Metricbeat data. Defaults to `metricbeat-*`.\n+\n+`xpack.infra.sources.default.fields.timestamp`:: Timestamp used to for sorting log entries. Defaults to `@timestamp`.","path":"docs/settings/general-infra-logs-ui-settings.asciidoc","position":7,"original_position":7,"commit_id":"ea9bc5ef37f75e26df8fa9a5cf43c71b867eaa44","original_commit_id":"ea9bc5ef37f75e26df8fa9a5cf43c71b867eaa44","user":{"login":"dedemorton","id":14206422,"node_id":"MDQ6VXNlcjE0MjA2NDIy","avatar_url":"https://avatars3.githubusercontent.com/u/14206422?v=4","gravatar_id":"","url":"https://api.github.com/users/dedemorton","html_url":"https://github.com/dedemorton","followers_url":"https://api.github.com/users/dedemorton/followers","following_url":"https://api.github.com/users/dedemorton/following{/other_user}","gists_url":"https://api.github.com/users/dedemorton/gists{/gist_id}","starred_url":"https://api.github.com/users/dedemorton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dedemorton/subscriptions","organizations_url":"https://api.github.com/users/dedemorton/orgs","repos_url":"https://api.github.com/users/dedemorton/repos","events_url":"https://api.github.com/users/dedemorton/events{/privacy}","received_events_url":"https://api.github.com/users/dedemorton/received_events","type":"User","site_admin":false},"body":"Looks like you missed my earlier comment: Say either \"used to sort\" or \"for sorting\"","created_at":"2019-01-03T18:38:04Z","updated_at":"2019-01-03T18:46:39Z","html_url":"https://github.com/elastic/kibana/pull/26579#discussion_r245092713","pull_request_url":"https://api.github.com/repos/elastic/kibana/pulls/26579","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/elastic/kibana/pulls/comments/245092713"},"html":{"href":"https://github.com/elastic/kibana/pull/26579#discussion_r245092713"},"pull_request":{"href":"https://api.github.com/repos/elastic/kibana/pulls/26579"}}},"pull_request":{"url":"https://api.github.com/repos/elastic/kibana/pulls/26579","id":235623670,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM1NjIzNjcw","html_url":"https://github.com/elastic/kibana/pull/26579","diff_url":"https://github.com/elastic/kibana/pull/26579.diff","patch_url":"https://github.com/elastic/kibana/pull/26579.patch","issue_url":"https://api.github.com/repos/elastic/kibana/issues/26579","number":26579,"state":"open","locked":false,"title":"[InfraOps] Update docs with data source configuration","user":{"login":"simianhacker","id":41702,"node_id":"MDQ6VXNlcjQxNzAy","avatar_url":"https://avatars2.githubusercontent.com/u/41702?v=4","gravatar_id":"","url":"https://api.github.com/users/simianhacker","html_url":"https://github.com/simianhacker","followers_url":"https://api.github.com/users/simianhacker/followers","following_url":"https://api.github.com/users/simianhacker/following{/other_user}","gists_url":"https://api.github.com/users/simianhacker/gists{/gist_id}","starred_url":"https://api.github.com/users/simianhacker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simianhacker/subscriptions","organizations_url":"https://api.github.com/users/simianhacker/orgs","repos_url":"https://api.github.com/users/simianhacker/repos","events_url":"https://api.github.com/users/simianhacker/events{/privacy}","received_events_url":"https://api.github.com/users/simianhacker/received_events","type":"User","site_admin":false},"body":"This PR adds a section to both the logging and infrastructure ui docs explaining how to override the index pattern for each. \r\n\r\nFixes elastic/kibana#26059","created_at":"2018-12-03T23:06:21Z","updated_at":"2019-01-03T18:46:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"709e91e2cc10da938bef80623e5d9930bdbc3266","assignee":{"login":"simianhacker","id":41702,"node_id":"MDQ6VXNlcjQxNzAy","avatar_url":"https://avatars2.githubusercontent.com/u/41702?v=4","gravatar_id":"","url":"https://api.github.com/users/simianhacker","html_url":"https://github.com/simianhacker","followers_url":"https://api.github.com/users/simianhacker/followers","following_url":"https://api.github.com/users/simianhacker/following{/other_user}","gists_url":"https://api.github.com/users/simianhacker/gists{/gist_id}","starred_url":"https://api.github.com/users/simianhacker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simianhacker/subscriptions","organizations_url":"https://api.github.com/users/simianhacker/orgs","repos_url":"https://api.github.com/users/simianhacker/repos","events_url":"https://api.github.com/users/simianhacker/events{/privacy}","received_events_url":"https://api.github.com/users/simianhacker/received_events","type":"User","site_admin":false},"assignees":[{"login":"simianhacker","id":41702,"node_id":"MDQ6VXNlcjQxNzAy","avatar_url":"https://avatars2.githubusercontent.com/u/41702?v=4","gravatar_id":"","url":"https://api.github.com/users/simianhacker","html_url":"https://github.com/simianhacker","followers_url":"https://api.github.com/users/simianhacker/followers","following_url":"https://api.github.com/users/simianhacker/following{/other_user}","gists_url":"https://api.github.com/users/simianhacker/gists{/gist_id}","starred_url":"https://api.github.com/users/simianhacker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simianhacker/subscriptions","organizations_url":"https://api.github.com/users/simianhacker/orgs","repos_url":"https://api.github.com/users/simianhacker/repos","events_url":"https://api.github.com/users/simianhacker/events{/privacy}","received_events_url":"https://api.github.com/users/simianhacker/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":983061515,"node_id":"MDU6TGFiZWw5ODMwNjE1MTU=","url":"https://api.github.com/repos/elastic/kibana/labels/:Infra%20UI","name":":Infra UI","color":"fef2c0","default":false},{"id":899581493,"node_id":"MDU6TGFiZWw4OTk1ODE0OTM=","url":"https://api.github.com/repos/elastic/kibana/labels/[zube]:%20In%20Review","name":"[zube]: In Review","color":"ffffff","default":false},{"id":135307740,"node_id":"MDU6TGFiZWwxMzUzMDc3NDA=","url":"https://api.github.com/repos/elastic/kibana/labels/review","name":"review","color":"0052cc","default":false},{"id":1062169267,"node_id":"MDU6TGFiZWwxMDYyMTY5MjY3","url":"https://api.github.com/repos/elastic/kibana/labels/v6.6.0","name":"v6.6.0","color":"ffffff","default":false},{"id":654061976,"node_id":"MDU6TGFiZWw2NTQwNjE5NzY=","url":"https://api.github.com/repos/elastic/kibana/labels/v7.0.0","name":"v7.0.0","color":"ffffff","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/elastic/kibana/pulls/26579/commits","review_comments_url":"https://api.github.com/repos/elastic/kibana/pulls/26579/comments","review_comment_url":"https://api.github.com/repos/elastic/kibana/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elastic/kibana/issues/26579/comments","statuses_url":"https://api.github.com/repos/elastic/kibana/statuses/ea9bc5ef37f75e26df8fa9a5cf43c71b867eaa44","head":{"label":"simianhacker:fixes-26059","ref":"fixes-26059","sha":"ea9bc5ef37f75e26df8fa9a5cf43c71b867eaa44","user":{"login":"simianhacker","id":41702,"node_id":"MDQ6VXNlcjQxNzAy","avatar_url":"https://avatars2.githubusercontent.com/u/41702?v=4","gravatar_id":"","url":"https://api.github.com/users/simianhacker","html_url":"https://github.com/simianhacker","followers_url":"https://api.github.com/users/simianhacker/followers","following_url":"https://api.github.com/users/simianhacker/following{/other_user}","gists_url":"https://api.github.com/users/simianhacker/gists{/gist_id}","starred_url":"https://api.github.com/users/simianhacker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simianhacker/subscriptions","organizations_url":"https://api.github.com/users/simianhacker/orgs","repos_url":"https://api.github.com/users/simianhacker/repos","events_url":"https://api.github.com/users/simianhacker/events{/privacy}","received_events_url":"https://api.github.com/users/simianhacker/received_events","type":"User","site_admin":false},"repo":{"id":14648766,"node_id":"MDEwOlJlcG9zaXRvcnkxNDY0ODc2Ng==","name":"kibana","full_name":"simianhacker/kibana","private":false,"owner":{"login":"simianhacker","id":41702,"node_id":"MDQ6VXNlcjQxNzAy","avatar_url":"https://avatars2.githubusercontent.com/u/41702?v=4","gravatar_id":"","url":"https://api.github.com/users/simianhacker","html_url":"https://github.com/simianhacker","followers_url":"https://api.github.com/users/simianhacker/followers","following_url":"https://api.github.com/users/simianhacker/following{/other_user}","gists_url":"https://api.github.com/users/simianhacker/gists{/gist_id}","starred_url":"https://api.github.com/users/simianhacker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simianhacker/subscriptions","organizations_url":"https://api.github.com/users/simianhacker/orgs","repos_url":"https://api.github.com/users/simianhacker/repos","events_url":"https://api.github.com/users/simianhacker/events{/privacy}","received_events_url":"https://api.github.com/users/simianhacker/received_events","type":"User","site_admin":false},"html_url":"https://github.com/simianhacker/kibana","description":"Kibana 3","fork":true,"url":"https://api.github.com/repos/simianhacker/kibana","forks_url":"https://api.github.com/repos/simianhacker/kibana/forks","keys_url":"https://api.github.com/repos/simianhacker/kibana/keys{/key_id}","collaborators_url":"https://api.github.com/repos/simianhacker/kibana/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/simianhacker/kibana/teams","hooks_url":"https://api.github.com/repos/simianhacker/kibana/hooks","issue_events_url":"https://api.github.com/repos/simianhacker/kibana/issues/events{/number}","events_url":"https://api.github.com/repos/simianhacker/kibana/events","assignees_url":"https://api.github.com/repos/simianhacker/kibana/assignees{/user}","branches_url":"https://api.github.com/repos/simianhacker/kibana/branches{/branch}","tags_url":"https://api.github.com/repos/simianhacker/kibana/tags","blobs_url":"https://api.github.com/repos/simianhacker/kibana/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/simianhacker/kibana/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/simianhacker/kibana/git/refs{/sha}","trees_url":"https://api.github.com/repos/simianhacker/kibana/git/trees{/sha}","statuses_url":"https://api.github.com/repos/simianhacker/kibana/statuses/{sha}","languages_url":"https://api.github.com/repos/simianhacker/kibana/languages","stargazers_url":"https://api.github.com/repos/simianhacker/kibana/stargazers","contributors_url":"https://api.github.com/repos/simianhacker/kibana/contributors","subscribers_url":"https://api.github.com/repos/simianhacker/kibana/subscribers","subscription_url":"https://api.github.com/repos/simianhacker/kibana/subscription","commits_url":"https://api.github.com/repos/simianhacker/kibana/commits{/sha}","git_commits_url":"https://api.github.com/repos/simianhacker/kibana/git/commits{/sha}","comments_url":"https://api.github.com/repos/simianhacker/kibana/comments{/number}","issue_comment_url":"https://api.github.com/repos/simianhacker/kibana/issues/comments{/number}","contents_url":"https://api.github.com/repos/simianhacker/kibana/contents/{+path}","compare_url":"https://api.github.com/repos/simianhacker/kibana/compare/{base}...{head}","merges_url":"https://api.github.com/repos/simianhacker/kibana/merges","archive_url":"https://api.github.com/repos/simianhacker/kibana/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/simianhacker/kibana/downloads","issues_url":"https://api.github.com/repos/simianhacker/kibana/issues{/number}","pulls_url":"https://api.github.com/repos/simianhacker/kibana/pulls{/number}","milestones_url":"https://api.github.com/repos/simianhacker/kibana/milestones{/number}","notifications_url":"https://api.github.com/repos/simianhacker/kibana/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/simianhacker/kibana/labels{/name}","releases_url":"https://api.github.com/repos/simianhacker/kibana/releases{/id}","deployments_url":"https://api.github.com/repos/simianhacker/kibana/deployments","created_at":"2013-11-23T19:19:22Z","updated_at":"2018-12-17T21:57:44Z","pushed_at":"2018-12-18T17:34:09Z","git_url":"git://github.com/simianhacker/kibana.git","ssh_url":"[email protected]:simianhacker/kibana.git","clone_url":"https://github.com/simianhacker/kibana.git","svn_url":"https://github.com/simianhacker/kibana","homepage":"http://www.elasticsearch.org/overview/kibana/","size":505435,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"elastic:master","ref":"master","sha":"00aabd458569382fb51aaba008ac7edcee84c44e","user":{"login":"elastic","id":6764390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3NjQzOTA=","avatar_url":"https://avatars0.githubusercontent.com/u/6764390?v=4","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"repo":{"id":7833168,"node_id":"MDEwOlJlcG9zaXRvcnk3ODMzMTY4","name":"kibana","full_name":"elastic/kibana","private":false,"owner":{"login":"elastic","id":6764390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3NjQzOTA=","avatar_url":"https://avatars0.githubusercontent.com/u/6764390?v=4","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/elastic/kibana","description":":bar_chart: Kibana analytics and search dashboard for Elasticsearch","fork":false,"url":"https://api.github.com/repos/elastic/kibana","forks_url":"https://api.github.com/repos/elastic/kibana/forks","keys_url":"https://api.github.com/repos/elastic/kibana/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elastic/kibana/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elastic/kibana/teams","hooks_url":"https://api.github.com/repos/elastic/kibana/hooks","issue_events_url":"https://api.github.com/repos/elastic/kibana/issues/events{/number}","events_url":"https://api.github.com/repos/elastic/kibana/events","assignees_url":"https://api.github.com/repos/elastic/kibana/assignees{/user}","branches_url":"https://api.github.com/repos/elastic/kibana/branches{/branch}","tags_url":"https://api.github.com/repos/elastic/kibana/tags","blobs_url":"https://api.github.com/repos/elastic/kibana/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elastic/kibana/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elastic/kibana/git/refs{/sha}","trees_url":"https://api.github.com/repos/elastic/kibana/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elastic/kibana/statuses/{sha}","languages_url":"https://api.github.com/repos/elastic/kibana/languages","stargazers_url":"https://api.github.com/repos/elastic/kibana/stargazers","contributors_url":"https://api.github.com/repos/elastic/kibana/contributors","subscribers_url":"https://api.github.com/repos/elastic/kibana/subscribers","subscription_url":"https://api.github.com/repos/elastic/kibana/subscription","commits_url":"https://api.github.com/repos/elastic/kibana/commits{/sha}","git_commits_url":"https://api.github.com/repos/elastic/kibana/git/commits{/sha}","comments_url":"https://api.github.com/repos/elastic/kibana/comments{/number}","issue_comment_url":"https://api.github.com/repos/elastic/kibana/issues/comments{/number}","contents_url":"https://api.github.com/repos/elastic/kibana/contents/{+path}","compare_url":"https://api.github.com/repos/elastic/kibana/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elastic/kibana/merges","archive_url":"https://api.github.com/repos/elastic/kibana/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elastic/kibana/downloads","issues_url":"https://api.github.com/repos/elastic/kibana/issues{/number}","pulls_url":"https://api.github.com/repos/elastic/kibana/pulls{/number}","milestones_url":"https://api.github.com/repos/elastic/kibana/milestones{/number}","notifications_url":"https://api.github.com/repos/elastic/kibana/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elastic/kibana/labels{/name}","releases_url":"https://api.github.com/repos/elastic/kibana/releases{/id}","deployments_url":"https://api.github.com/repos/elastic/kibana/deployments","created_at":"2013-01-26T04:00:59Z","updated_at":"2019-01-03T18:23:18Z","pushed_at":"2019-01-03T18:42:54Z","git_url":"git://github.com/elastic/kibana.git","ssh_url":"[email protected]:elastic/kibana.git","clone_url":"https://github.com/elastic/kibana.git","svn_url":"https://github.com/elastic/kibana","homepage":"https://www.elastic.co/products/kibana","size":525840,"stargazers_count":10795,"watchers_count":10795,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4208,"mirror_url":null,"archived":false,"open_issues_count":3990,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":4208,"open_issues":3990,"watchers":10795,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elastic/kibana/pulls/26579"},"html":{"href":"https://github.com/elastic/kibana/pull/26579"},"issue":{"href":"https://api.github.com/repos/elastic/kibana/issues/26579"},"comments":{"href":"https://api.github.com/repos/elastic/kibana/issues/26579/comments"},"review_comments":{"href":"https://api.github.com/repos/elastic/kibana/pulls/26579/comments"},"review_comment":{"href":"https://api.github.com/repos/elastic/kibana/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elastic/kibana/pulls/26579/commits"},"statuses":{"href":"https://api.github.com/repos/elastic/kibana/statuses/ea9bc5ef37f75e26df8fa9a5cf43c71b867eaa44"}},"author_association":"MEMBER"}} | {
"id": 7833168,
"name": "elastic/kibana",
"url": "https://api.github.com/repos/elastic/kibana"
} | {
"id": 14206422,
"login": "dedemorton",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/14206422?",
"url": "https://api.github.com/users/dedemorton"
} | {
"id": 6764390,
"login": "elastic",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6764390?",
"url": "https://api.github.com/orgs/elastic"
} | 2019-01-03T18:38:04 | 8830326368 | {"actor":{"display_login":"dedemorton"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/elastic/apm-server/pulls/comments/203642872","pull_request_review_id":138571275,"id":203642872,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMzY0Mjg3Mg==","diff_hunk":"@@ -42,26 +43,30 @@ type Config struct {\n \tMaxConnections int `config:\"max_connections\"`\n \tMaxRequestQueueTime time.Duration `config:\"max_request_queue_time\"`\n \tExpvar *ExpvarConfig `config:\"expvar\"`\n-\tFrontend *FrontendConfig `config:\"frontend\"`\n \tMetrics *metricsConfig `config:\"metrics\"`\n \tAugmentEnabled bool `config:\"capture_personal_data\"`\n \tSelfInstrumentation *InstrumentationConfig `config:\"instrumentation\"`\n+\n+\tRumConfig *rumConfig `config:\"rum\"`\n+\tFrontendConfig *rumConfig `config:\"frontend\"`\n+\trum *rumConfig","path":"beater/config.go","position":19,"original_position":19,"commit_id":"72ea177e8ecd535fe9d8d2ac64c205c1947ee5d9","original_commit_id":"72ea177e8ecd535fe9d8d2ac64c205c1947ee5d9","user":{"login":"simitt","id":5555349,"node_id":"MDQ6VXNlcjU1NTUzNDk=","avatar_url":"https://avatars0.githubusercontent.com/u/5555349?v=4","gravatar_id":"","url":"https://api.github.com/users/simitt","html_url":"https://github.com/simitt","followers_url":"https://api.github.com/users/simitt/followers","following_url":"https://api.github.com/users/simitt/following{/other_user}","gists_url":"https://api.github.com/users/simitt/gists{/gist_id}","starred_url":"https://api.github.com/users/simitt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simitt/subscriptions","organizations_url":"https://api.github.com/users/simitt/orgs","repos_url":"https://api.github.com/users/simitt/repos","events_url":"https://api.github.com/users/simitt/events{/privacy}","received_events_url":"https://api.github.com/users/simitt/received_events","type":"User","site_admin":false},"body":"This should definitely work. It would however put logic that concerns the configuration file to all places using the configuration. \r\nI see handling the backwards compatible `FrontendConfig` as an implementation detail of the configuration, that is why I wanted to handle it directly at the config level. But I didn't find a way to do this without changing the signature for the frontendConfig, so I get your point.\r\nI'm fine with changing when you think it makes it easier. ","created_at":"2018-07-19T08:34:45Z","updated_at":"2018-07-19T08:34:46Z","html_url":"https://github.com/elastic/apm-server/pull/1155#discussion_r203642872","pull_request_url":"https://api.github.com/repos/elastic/apm-server/pulls/1155","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/elastic/apm-server/pulls/comments/203642872"},"html":{"href":"https://github.com/elastic/apm-server/pull/1155#discussion_r203642872"},"pull_request":{"href":"https://api.github.com/repos/elastic/apm-server/pulls/1155"}},"in_reply_to_id":203625551},"pull_request":{"url":"https://api.github.com/repos/elastic/apm-server/pulls/1155","id":202285353,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyMjg1MzUz","html_url":"https://github.com/elastic/apm-server/pull/1155","diff_url":"https://github.com/elastic/apm-server/pull/1155.diff","patch_url":"https://github.com/elastic/apm-server/pull/1155.patch","issue_url":"https://api.github.com/repos/elastic/apm-server/issues/1155","number":1155,"state":"open","locked":false,"title":"Update RUM related config, endpoint and tests.","user":{"login":"simitt","id":5555349,"node_id":"MDQ6VXNlcjU1NTUzNDk=","avatar_url":"https://avatars0.githubusercontent.com/u/5555349?v=4","gravatar_id":"","url":"https://api.github.com/users/simitt","html_url":"https://github.com/simitt","followers_url":"https://api.github.com/users/simitt/followers","following_url":"https://api.github.com/users/simitt/following{/other_user}","gists_url":"https://api.github.com/users/simitt/gists{/gist_id}","starred_url":"https://api.github.com/users/simitt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simitt/subscriptions","organizations_url":"https://api.github.com/users/simitt/orgs","repos_url":"https://api.github.com/users/simitt/repos","events_url":"https://api.github.com/users/simitt/events{/privacy}","received_events_url":"https://api.github.com/users/simitt/received_events","type":"User","site_admin":false},"body":"* Use `rum` over `frontend` in config file, but still support the usage of `frontend` for backwards compatibility.\r\n* Rename all `frontend` test files to `rum`\r\n* Support `client-side` and `rum` as endpoint to be backwards compatible.\r\n\r\nimplements elastic/apm-server#1136\r\n","created_at":"2018-07-18T15:06:33Z","updated_at":"2018-07-19T08:34:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b94170c28715133d70cd16b285a572f8c8ac9415","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":882569418,"node_id":"MDU6TGFiZWw4ODI1Njk0MTg=","url":"https://api.github.com/repos/elastic/apm-server/labels/[zube]:%20In%20Review","name":"[zube]: In Review","color":"ffffff","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/elastic/apm-server/pulls/1155/commits","review_comments_url":"https://api.github.com/repos/elastic/apm-server/pulls/1155/comments","review_comment_url":"https://api.github.com/repos/elastic/apm-server/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elastic/apm-server/issues/1155/comments","statuses_url":"https://api.github.com/repos/elastic/apm-server/statuses/72ea177e8ecd535fe9d8d2ac64c205c1947ee5d9","head":{"label":"simitt:1136-use-rum","ref":"1136-use-rum","sha":"72ea177e8ecd535fe9d8d2ac64c205c1947ee5d9","user":{"login":"simitt","id":5555349,"node_id":"MDQ6VXNlcjU1NTUzNDk=","avatar_url":"https://avatars0.githubusercontent.com/u/5555349?v=4","gravatar_id":"","url":"https://api.github.com/users/simitt","html_url":"https://github.com/simitt","followers_url":"https://api.github.com/users/simitt/followers","following_url":"https://api.github.com/users/simitt/following{/other_user}","gists_url":"https://api.github.com/users/simitt/gists{/gist_id}","starred_url":"https://api.github.com/users/simitt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simitt/subscriptions","organizations_url":"https://api.github.com/users/simitt/orgs","repos_url":"https://api.github.com/users/simitt/repos","events_url":"https://api.github.com/users/simitt/events{/privacy}","received_events_url":"https://api.github.com/users/simitt/received_events","type":"User","site_admin":false},"repo":{"id":100600390,"node_id":"MDEwOlJlcG9zaXRvcnkxMDA2MDAzOTA=","name":"apm-server","full_name":"simitt/apm-server","owner":{"login":"simitt","id":5555349,"node_id":"MDQ6VXNlcjU1NTUzNDk=","avatar_url":"https://avatars0.githubusercontent.com/u/5555349?v=4","gravatar_id":"","url":"https://api.github.com/users/simitt","html_url":"https://github.com/simitt","followers_url":"https://api.github.com/users/simitt/followers","following_url":"https://api.github.com/users/simitt/following{/other_user}","gists_url":"https://api.github.com/users/simitt/gists{/gist_id}","starred_url":"https://api.github.com/users/simitt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simitt/subscriptions","organizations_url":"https://api.github.com/users/simitt/orgs","repos_url":"https://api.github.com/users/simitt/repos","events_url":"https://api.github.com/users/simitt/events{/privacy}","received_events_url":"https://api.github.com/users/simitt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/simitt/apm-server","description":"APM Server (Experimental)","fork":true,"url":"https://api.github.com/repos/simitt/apm-server","forks_url":"https://api.github.com/repos/simitt/apm-server/forks","keys_url":"https://api.github.com/repos/simitt/apm-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/simitt/apm-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/simitt/apm-server/teams","hooks_url":"https://api.github.com/repos/simitt/apm-server/hooks","issue_events_url":"https://api.github.com/repos/simitt/apm-server/issues/events{/number}","events_url":"https://api.github.com/repos/simitt/apm-server/events","assignees_url":"https://api.github.com/repos/simitt/apm-server/assignees{/user}","branches_url":"https://api.github.com/repos/simitt/apm-server/branches{/branch}","tags_url":"https://api.github.com/repos/simitt/apm-server/tags","blobs_url":"https://api.github.com/repos/simitt/apm-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/simitt/apm-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/simitt/apm-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/simitt/apm-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/simitt/apm-server/statuses/{sha}","languages_url":"https://api.github.com/repos/simitt/apm-server/languages","stargazers_url":"https://api.github.com/repos/simitt/apm-server/stargazers","contributors_url":"https://api.github.com/repos/simitt/apm-server/contributors","subscribers_url":"https://api.github.com/repos/simitt/apm-server/subscribers","subscription_url":"https://api.github.com/repos/simitt/apm-server/subscription","commits_url":"https://api.github.com/repos/simitt/apm-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/simitt/apm-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/simitt/apm-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/simitt/apm-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/simitt/apm-server/contents/{+path}","compare_url":"https://api.github.com/repos/simitt/apm-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/simitt/apm-server/merges","archive_url":"https://api.github.com/repos/simitt/apm-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/simitt/apm-server/downloads","issues_url":"https://api.github.com/repos/simitt/apm-server/issues{/number}","pulls_url":"https://api.github.com/repos/simitt/apm-server/pulls{/number}","milestones_url":"https://api.github.com/repos/simitt/apm-server/milestones{/number}","notifications_url":"https://api.github.com/repos/simitt/apm-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/simitt/apm-server/labels{/name}","releases_url":"https://api.github.com/repos/simitt/apm-server/releases{/id}","deployments_url":"https://api.github.com/repos/simitt/apm-server/deployments","created_at":"2017-08-17T12:20:36Z","updated_at":"2018-06-26T09:38:22Z","pushed_at":"2018-07-19T08:24:27Z","git_url":"git://github.com/simitt/apm-server.git","ssh_url":"[email protected]:simitt/apm-server.git","clone_url":"https://github.com/simitt/apm-server.git","svn_url":"https://github.com/simitt/apm-server","homepage":"","size":9035,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"elastic:master","ref":"master","sha":"323f04e004a0bae327efc257d901fe74c26fc56b","user":{"login":"elastic","id":6764390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3NjQzOTA=","avatar_url":"https://avatars0.githubusercontent.com/u/6764390?v=4","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"repo":{"id":99251094,"node_id":"MDEwOlJlcG9zaXRvcnk5OTI1MTA5NA==","name":"apm-server","full_name":"elastic/apm-server","owner":{"login":"elastic","id":6764390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3NjQzOTA=","avatar_url":"https://avatars0.githubusercontent.com/u/6764390?v=4","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elastic/apm-server","description":"APM Server","fork":false,"url":"https://api.github.com/repos/elastic/apm-server","forks_url":"https://api.github.com/repos/elastic/apm-server/forks","keys_url":"https://api.github.com/repos/elastic/apm-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elastic/apm-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elastic/apm-server/teams","hooks_url":"https://api.github.com/repos/elastic/apm-server/hooks","issue_events_url":"https://api.github.com/repos/elastic/apm-server/issues/events{/number}","events_url":"https://api.github.com/repos/elastic/apm-server/events","assignees_url":"https://api.github.com/repos/elastic/apm-server/assignees{/user}","branches_url":"https://api.github.com/repos/elastic/apm-server/branches{/branch}","tags_url":"https://api.github.com/repos/elastic/apm-server/tags","blobs_url":"https://api.github.com/repos/elastic/apm-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elastic/apm-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elastic/apm-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/elastic/apm-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elastic/apm-server/statuses/{sha}","languages_url":"https://api.github.com/repos/elastic/apm-server/languages","stargazers_url":"https://api.github.com/repos/elastic/apm-server/stargazers","contributors_url":"https://api.github.com/repos/elastic/apm-server/contributors","subscribers_url":"https://api.github.com/repos/elastic/apm-server/subscribers","subscription_url":"https://api.github.com/repos/elastic/apm-server/subscription","commits_url":"https://api.github.com/repos/elastic/apm-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/elastic/apm-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/elastic/apm-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/elastic/apm-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/elastic/apm-server/contents/{+path}","compare_url":"https://api.github.com/repos/elastic/apm-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elastic/apm-server/merges","archive_url":"https://api.github.com/repos/elastic/apm-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elastic/apm-server/downloads","issues_url":"https://api.github.com/repos/elastic/apm-server/issues{/number}","pulls_url":"https://api.github.com/repos/elastic/apm-server/pulls{/number}","milestones_url":"https://api.github.com/repos/elastic/apm-server/milestones{/number}","notifications_url":"https://api.github.com/repos/elastic/apm-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elastic/apm-server/labels{/name}","releases_url":"https://api.github.com/repos/elastic/apm-server/releases{/id}","deployments_url":"https://api.github.com/repos/elastic/apm-server/deployments","created_at":"2017-08-03T16:03:34Z","updated_at":"2018-07-19T08:23:55Z","pushed_at":"2018-07-19T08:24:29Z","git_url":"git://github.com/elastic/apm-server.git","ssh_url":"[email protected]:elastic/apm-server.git","clone_url":"https://github.com/elastic/apm-server.git","svn_url":"https://github.com/elastic/apm-server","homepage":"https://www.elastic.co/guide/en/apm/server/current/index.html","size":9220,"stargazers_count":365,"watchers_count":365,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":72,"mirror_url":null,"archived":false,"open_issues_count":48,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":72,"open_issues":48,"watchers":365,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elastic/apm-server/pulls/1155"},"html":{"href":"https://github.com/elastic/apm-server/pull/1155"},"issue":{"href":"https://api.github.com/repos/elastic/apm-server/issues/1155"},"comments":{"href":"https://api.github.com/repos/elastic/apm-server/issues/1155/comments"},"review_comments":{"href":"https://api.github.com/repos/elastic/apm-server/pulls/1155/comments"},"review_comment":{"href":"https://api.github.com/repos/elastic/apm-server/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elastic/apm-server/pulls/1155/commits"},"statuses":{"href":"https://api.github.com/repos/elastic/apm-server/statuses/72ea177e8ecd535fe9d8d2ac64c205c1947ee5d9"}},"author_association":"COLLABORATOR"}} | {
"id": 99251094,
"name": "elastic/apm-server",
"url": "https://api.github.com/repos/elastic/apm-server"
} | {
"id": 5555349,
"login": "simitt",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5555349?",
"url": "https://api.github.com/users/simitt"
} | {
"id": 6764390,
"login": "elastic",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6764390?",
"url": "https://api.github.com/orgs/elastic"
} | 2018-07-19T08:34:45 | 7987667416 | {"actor":{"display_login":"simitt"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/AmadeusITGroup/sonar-stash/pulls/comments/207467685","pull_request_review_id":143084576,"id":207467685,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNzQ2NzY4NQ==","diff_hunk":"@@ -267,6 +275,23 @@ public void approvePullRequest(PullRequestRef pr) throws StashClientException {\n MessageFormat.format(PULL_REQUEST_APPROVAL_POST_ERROR_MESSAGE, pr.repository(), pr.pullRequestId()));\r\n }\r\n \r\n+\r\n+ public void markPullRequestNeedsWork(PullRequestRef pr ) throws StashClientException {\r\n+ String request = MessageFormat.format(API_ONE_PR_NEEDS_WORK,\r\n+ baseUrl,\r\n+ pr.project(),\r\n+ pr.repository(),\r\n+ pr.pullRequestId(),\r\n+ credentials.getUserSlug());\r\n+ JsonObject json = new JsonObject();\r\n+ json.put(\"status\",\"NEEDS_WORK\");\r","path":"src/main/java/org/sonar/plugins/stash/client/StashClient.java","position":35,"original_position":35,"commit_id":"969bc36f7fbe6f4d59176329814d9628e64ccf22","original_commit_id":"969bc36f7fbe6f4d59176329814d9628e64ccf22","user":{"login":"t-8ch","id":717901,"node_id":"MDQ6VXNlcjcxNzkwMQ==","avatar_url":"https://avatars3.githubusercontent.com/u/717901?v=4","gravatar_id":"","url":"https://api.github.com/users/t-8ch","html_url":"https://github.com/t-8ch","followers_url":"https://api.github.com/users/t-8ch/followers","following_url":"https://api.github.com/users/t-8ch/following{/other_user}","gists_url":"https://api.github.com/users/t-8ch/gists{/gist_id}","starred_url":"https://api.github.com/users/t-8ch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/t-8ch/subscriptions","organizations_url":"https://api.github.com/users/t-8ch/orgs","repos_url":"https://api.github.com/users/t-8ch/repos","events_url":"https://api.github.com/users/t-8ch/events{/privacy}","received_events_url":"https://api.github.com/users/t-8ch/received_events","type":"User","site_admin":false},"body":"Needs a space after `,`.","created_at":"2018-08-03T07:54:13Z","updated_at":"2018-08-03T07:54:49Z","html_url":"https://github.com/AmadeusITGroup/sonar-stash/pull/190#discussion_r207467685","pull_request_url":"https://api.github.com/repos/AmadeusITGroup/sonar-stash/pulls/190","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/AmadeusITGroup/sonar-stash/pulls/comments/207467685"},"html":{"href":"https://github.com/AmadeusITGroup/sonar-stash/pull/190#discussion_r207467685"},"pull_request":{"href":"https://api.github.com/repos/AmadeusITGroup/sonar-stash/pulls/190"}}},"pull_request":{"url":"https://api.github.com/repos/AmadeusITGroup/sonar-stash/pulls/190","id":204864882,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0ODY0ODgy","html_url":"https://github.com/AmadeusITGroup/sonar-stash/pull/190","diff_url":"https://github.com/AmadeusITGroup/sonar-stash/pull/190.diff","patch_url":"https://github.com/AmadeusITGroup/sonar-stash/pull/190.patch","issue_url":"https://api.github.com/repos/AmadeusITGroup/sonar-stash/issues/190","number":190,"state":"open","locked":false,"title":"Change pull request status to NEEDS_WORK instead of resetting approval.","user":{"login":"tommywo","id":11270518,"node_id":"MDQ6VXNlcjExMjcwNTE4","avatar_url":"https://avatars0.githubusercontent.com/u/11270518?v=4","gravatar_id":"","url":"https://api.github.com/users/tommywo","html_url":"https://github.com/tommywo","followers_url":"https://api.github.com/users/tommywo/followers","following_url":"https://api.github.com/users/tommywo/following{/other_user}","gists_url":"https://api.github.com/users/tommywo/gists{/gist_id}","starred_url":"https://api.github.com/users/tommywo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tommywo/subscriptions","organizations_url":"https://api.github.com/users/tommywo/orgs","repos_url":"https://api.github.com/users/tommywo/repos","events_url":"https://api.github.com/users/tommywo/events{/privacy}","received_events_url":"https://api.github.com/users/tommywo/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-07-30T16:45:36Z","updated_at":"2018-08-03T07:54:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ea8a8306244f3a61688812d65b7caac3084e1447","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/AmadeusITGroup/sonar-stash/pulls/190/commits","review_comments_url":"https://api.github.com/repos/AmadeusITGroup/sonar-stash/pulls/190/comments","review_comment_url":"https://api.github.com/repos/AmadeusITGroup/sonar-stash/pulls/comments{/number}","comments_url":"https://api.github.com/repos/AmadeusITGroup/sonar-stash/issues/190/comments","statuses_url":"https://api.github.com/repos/AmadeusITGroup/sonar-stash/statuses/969bc36f7fbe6f4d59176329814d9628e64ccf22","head":{"label":"stepstone-tech:master","ref":"master","sha":"969bc36f7fbe6f4d59176329814d9628e64ccf22","user":{"login":"stepstone-tech","id":13017749,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMDE3NzQ5","avatar_url":"https://avatars1.githubusercontent.com/u/13017749?v=4","gravatar_id":"","url":"https://api.github.com/users/stepstone-tech","html_url":"https://github.com/stepstone-tech","followers_url":"https://api.github.com/users/stepstone-tech/followers","following_url":"https://api.github.com/users/stepstone-tech/following{/other_user}","gists_url":"https://api.github.com/users/stepstone-tech/gists{/gist_id}","starred_url":"https://api.github.com/users/stepstone-tech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stepstone-tech/subscriptions","organizations_url":"https://api.github.com/users/stepstone-tech/orgs","repos_url":"https://api.github.com/users/stepstone-tech/repos","events_url":"https://api.github.com/users/stepstone-tech/events{/privacy}","received_events_url":"https://api.github.com/users/stepstone-tech/received_events","type":"Organization","site_admin":false},"repo":{"id":121489907,"node_id":"MDEwOlJlcG9zaXRvcnkxMjE0ODk5MDc=","name":"sonar-stash","full_name":"stepstone-tech/sonar-stash","owner":{"login":"stepstone-tech","id":13017749,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMDE3NzQ5","avatar_url":"https://avatars1.githubusercontent.com/u/13017749?v=4","gravatar_id":"","url":"https://api.github.com/users/stepstone-tech","html_url":"https://github.com/stepstone-tech","followers_url":"https://api.github.com/users/stepstone-tech/followers","following_url":"https://api.github.com/users/stepstone-tech/following{/other_user}","gists_url":"https://api.github.com/users/stepstone-tech/gists{/gist_id}","starred_url":"https://api.github.com/users/stepstone-tech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stepstone-tech/subscriptions","organizations_url":"https://api.github.com/users/stepstone-tech/orgs","repos_url":"https://api.github.com/users/stepstone-tech/repos","events_url":"https://api.github.com/users/stepstone-tech/events{/privacy}","received_events_url":"https://api.github.com/users/stepstone-tech/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/stepstone-tech/sonar-stash","description":"Stash (BitBucket) plugin, a pull-request decorator which allows to integrate SonarQube violations directly into your pull-request","fork":true,"url":"https://api.github.com/repos/stepstone-tech/sonar-stash","forks_url":"https://api.github.com/repos/stepstone-tech/sonar-stash/forks","keys_url":"https://api.github.com/repos/stepstone-tech/sonar-stash/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stepstone-tech/sonar-stash/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stepstone-tech/sonar-stash/teams","hooks_url":"https://api.github.com/repos/stepstone-tech/sonar-stash/hooks","issue_events_url":"https://api.github.com/repos/stepstone-tech/sonar-stash/issues/events{/number}","events_url":"https://api.github.com/repos/stepstone-tech/sonar-stash/events","assignees_url":"https://api.github.com/repos/stepstone-tech/sonar-stash/assignees{/user}","branches_url":"https://api.github.com/repos/stepstone-tech/sonar-stash/branches{/branch}","tags_url":"https://api.github.com/repos/stepstone-tech/sonar-stash/tags","blobs_url":"https://api.github.com/repos/stepstone-tech/sonar-stash/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stepstone-tech/sonar-stash/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stepstone-tech/sonar-stash/git/refs{/sha}","trees_url":"https://api.github.com/repos/stepstone-tech/sonar-stash/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stepstone-tech/sonar-stash/statuses/{sha}","languages_url":"https://api.github.com/repos/stepstone-tech/sonar-stash/languages","stargazers_url":"https://api.github.com/repos/stepstone-tech/sonar-stash/stargazers","contributors_url":"https://api.github.com/repos/stepstone-tech/sonar-stash/contributors","subscribers_url":"https://api.github.com/repos/stepstone-tech/sonar-stash/subscribers","subscription_url":"https://api.github.com/repos/stepstone-tech/sonar-stash/subscription","commits_url":"https://api.github.com/repos/stepstone-tech/sonar-stash/commits{/sha}","git_commits_url":"https://api.github.com/repos/stepstone-tech/sonar-stash/git/commits{/sha}","comments_url":"https://api.github.com/repos/stepstone-tech/sonar-stash/comments{/number}","issue_comment_url":"https://api.github.com/repos/stepstone-tech/sonar-stash/issues/comments{/number}","contents_url":"https://api.github.com/repos/stepstone-tech/sonar-stash/contents/{+path}","compare_url":"https://api.github.com/repos/stepstone-tech/sonar-stash/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stepstone-tech/sonar-stash/merges","archive_url":"https://api.github.com/repos/stepstone-tech/sonar-stash/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stepstone-tech/sonar-stash/downloads","issues_url":"https://api.github.com/repos/stepstone-tech/sonar-stash/issues{/number}","pulls_url":"https://api.github.com/repos/stepstone-tech/sonar-stash/pulls{/number}","milestones_url":"https://api.github.com/repos/stepstone-tech/sonar-stash/milestones{/number}","notifications_url":"https://api.github.com/repos/stepstone-tech/sonar-stash/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stepstone-tech/sonar-stash/labels{/name}","releases_url":"https://api.github.com/repos/stepstone-tech/sonar-stash/releases{/id}","deployments_url":"https://api.github.com/repos/stepstone-tech/sonar-stash/deployments","created_at":"2018-02-14T08:58:06Z","updated_at":"2018-07-31T12:35:46Z","pushed_at":"2018-07-31T12:35:45Z","git_url":"git://github.com/stepstone-tech/sonar-stash.git","ssh_url":"[email protected]:stepstone-tech/sonar-stash.git","clone_url":"https://github.com/stepstone-tech/sonar-stash.git","svn_url":"https://github.com/stepstone-tech/sonar-stash","homepage":"","size":1179,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"AmadeusITGroup:master","ref":"master","sha":"0fc7f9448749d200c62cc2cefe16b7c22cd96e62","user":{"login":"AmadeusITGroup","id":6802338,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4MDIzMzg=","avatar_url":"https://avatars3.githubusercontent.com/u/6802338?v=4","gravatar_id":"","url":"https://api.github.com/users/AmadeusITGroup","html_url":"https://github.com/AmadeusITGroup","followers_url":"https://api.github.com/users/AmadeusITGroup/followers","following_url":"https://api.github.com/users/AmadeusITGroup/following{/other_user}","gists_url":"https://api.github.com/users/AmadeusITGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/AmadeusITGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AmadeusITGroup/subscriptions","organizations_url":"https://api.github.com/users/AmadeusITGroup/orgs","repos_url":"https://api.github.com/users/AmadeusITGroup/repos","events_url":"https://api.github.com/users/AmadeusITGroup/events{/privacy}","received_events_url":"https://api.github.com/users/AmadeusITGroup/received_events","type":"Organization","site_admin":false},"repo":{"id":42864318,"node_id":"MDEwOlJlcG9zaXRvcnk0Mjg2NDMxOA==","name":"sonar-stash","full_name":"AmadeusITGroup/sonar-stash","owner":{"login":"AmadeusITGroup","id":6802338,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4MDIzMzg=","avatar_url":"https://avatars3.githubusercontent.com/u/6802338?v=4","gravatar_id":"","url":"https://api.github.com/users/AmadeusITGroup","html_url":"https://github.com/AmadeusITGroup","followers_url":"https://api.github.com/users/AmadeusITGroup/followers","following_url":"https://api.github.com/users/AmadeusITGroup/following{/other_user}","gists_url":"https://api.github.com/users/AmadeusITGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/AmadeusITGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AmadeusITGroup/subscriptions","organizations_url":"https://api.github.com/users/AmadeusITGroup/orgs","repos_url":"https://api.github.com/users/AmadeusITGroup/repos","events_url":"https://api.github.com/users/AmadeusITGroup/events{/privacy}","received_events_url":"https://api.github.com/users/AmadeusITGroup/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/AmadeusITGroup/sonar-stash","description":"Stash (BitBucket) plugin, a pull-request decorator which allows to integrate SonarQube violations directly into your pull-request","fork":false,"url":"https://api.github.com/repos/AmadeusITGroup/sonar-stash","forks_url":"https://api.github.com/repos/AmadeusITGroup/sonar-stash/forks","keys_url":"https://api.github.com/repos/AmadeusITGroup/sonar-stash/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AmadeusITGroup/sonar-stash/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AmadeusITGroup/sonar-stash/teams","hooks_url":"https://api.github.com/repos/AmadeusITGroup/sonar-stash/hooks","issue_events_url":"https://api.github.com/repos/AmadeusITGroup/sonar-stash/issues/events{/number}","events_url":"https://api.github.com/repos/AmadeusITGroup/sonar-stash/events","assignees_url":"https://api.github.com/repos/AmadeusITGroup/sonar-stash/assignees{/user}","branches_url":"https://api.github.com/repos/AmadeusITGroup/sonar-stash/branches{/branch}","tags_url":"https://api.github.com/repos/AmadeusITGroup/sonar-stash/tags","blobs_url":"https://api.github.com/repos/AmadeusITGroup/sonar-stash/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AmadeusITGroup/sonar-stash/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AmadeusITGroup/sonar-stash/git/refs{/sha}","trees_url":"https://api.github.com/repos/AmadeusITGroup/sonar-stash/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AmadeusITGroup/sonar-stash/statuses/{sha}","languages_url":"https://api.github.com/repos/AmadeusITGroup/sonar-stash/languages","stargazers_url":"https://api.github.com/repos/AmadeusITGroup/sonar-stash/stargazers","contributors_url":"https://api.github.com/repos/AmadeusITGroup/sonar-stash/contributors","subscribers_url":"https://api.github.com/repos/AmadeusITGroup/sonar-stash/subscribers","subscription_url":"https://api.github.com/repos/AmadeusITGroup/sonar-stash/subscription","commits_url":"https://api.github.com/repos/AmadeusITGroup/sonar-stash/commits{/sha}","git_commits_url":"https://api.github.com/repos/AmadeusITGroup/sonar-stash/git/commits{/sha}","comments_url":"https://api.github.com/repos/AmadeusITGroup/sonar-stash/comments{/number}","issue_comment_url":"https://api.github.com/repos/AmadeusITGroup/sonar-stash/issues/comments{/number}","contents_url":"https://api.github.com/repos/AmadeusITGroup/sonar-stash/contents/{+path}","compare_url":"https://api.github.com/repos/AmadeusITGroup/sonar-stash/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AmadeusITGroup/sonar-stash/merges","archive_url":"https://api.github.com/repos/AmadeusITGroup/sonar-stash/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AmadeusITGroup/sonar-stash/downloads","issues_url":"https://api.github.com/repos/AmadeusITGroup/sonar-stash/issues{/number}","pulls_url":"https://api.github.com/repos/AmadeusITGroup/sonar-stash/pulls{/number}","milestones_url":"https://api.github.com/repos/AmadeusITGroup/sonar-stash/milestones{/number}","notifications_url":"https://api.github.com/repos/AmadeusITGroup/sonar-stash/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AmadeusITGroup/sonar-stash/labels{/name}","releases_url":"https://api.github.com/repos/AmadeusITGroup/sonar-stash/releases{/id}","deployments_url":"https://api.github.com/repos/AmadeusITGroup/sonar-stash/deployments","created_at":"2015-09-21T12:15:13Z","updated_at":"2018-08-03T07:49:22Z","pushed_at":"2018-08-03T07:49:19Z","git_url":"git://github.com/AmadeusITGroup/sonar-stash.git","ssh_url":"[email protected]:AmadeusITGroup/sonar-stash.git","clone_url":"https://github.com/AmadeusITGroup/sonar-stash.git","svn_url":"https://github.com/AmadeusITGroup/sonar-stash","homepage":"","size":1178,"stargazers_count":148,"watchers_count":148,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":78,"mirror_url":null,"archived":false,"open_issues_count":24,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":78,"open_issues":24,"watchers":148,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/AmadeusITGroup/sonar-stash/pulls/190"},"html":{"href":"https://github.com/AmadeusITGroup/sonar-stash/pull/190"},"issue":{"href":"https://api.github.com/repos/AmadeusITGroup/sonar-stash/issues/190"},"comments":{"href":"https://api.github.com/repos/AmadeusITGroup/sonar-stash/issues/190/comments"},"review_comments":{"href":"https://api.github.com/repos/AmadeusITGroup/sonar-stash/pulls/190/comments"},"review_comment":{"href":"https://api.github.com/repos/AmadeusITGroup/sonar-stash/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/AmadeusITGroup/sonar-stash/pulls/190/commits"},"statuses":{"href":"https://api.github.com/repos/AmadeusITGroup/sonar-stash/statuses/969bc36f7fbe6f4d59176329814d9628e64ccf22"}},"author_association":"NONE"}} | {
"id": 42864318,
"name": "AmadeusITGroup/sonar-stash",
"url": "https://api.github.com/repos/AmadeusITGroup/sonar-stash"
} | {
"id": 717901,
"login": "t-8ch",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/717901?",
"url": "https://api.github.com/users/t-8ch"
} | {
"id": 6802338,
"login": "AmadeusITGroup",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6802338?",
"url": "https://api.github.com/orgs/AmadeusITGroup"
} | 2018-08-03T07:54:13 | 8061127019 | {"actor":{"display_login":"t-8ch"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/Azure/Azure-AppServices-Diagnostics-Portal/pulls/comments/230108673","pull_request_review_id":170769865,"id":230108673,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMDEwODY3Mw==","diff_hunk":"@@ -0,0 +1,38 @@\n+import { Component, OnInit } from '@angular/core';\n+import { IDetectorResponse } from '../../../../shared/models/detectorresponse';\n+import { DetectorViewBaseComponent } from '../../detector-view-base/detector-view-base.component';\n+import { ActivatedRoute } from '@angular/router';\n+import { AppAnalysisService } from '../../../../shared/services/appanalysis.service';\n+import { DetectorControlService } from 'applens-diagnostics';\n+\n+@Component({\n+ selector: 'autohealing-detector',\n+ templateUrl: './autohealing-detector.component.html',\n+ styleUrls: ['./autohealing-detector.component.css']\n+})\n+\n+export class AutohealingDetectorComponent extends DetectorViewBaseComponent implements OnInit {","path":"AngularApp/src/app/availability/detector-view/detectors/autohealing-detector/autohealing-detector.component.ts","position":14,"original_position":14,"commit_id":"3127bf3768f9ffaa9fc33061df40f38376de1689","original_commit_id":"3127bf3768f9ffaa9fc33061df40f38376de1689","user":{"login":"stevenernst131","id":7739017,"node_id":"MDQ6VXNlcjc3MzkwMTc=","avatar_url":"https://avatars2.githubusercontent.com/u/7739017?v=4","gravatar_id":"","url":"https://api.github.com/users/stevenernst131","html_url":"https://github.com/stevenernst131","followers_url":"https://api.github.com/users/stevenernst131/followers","following_url":"https://api.github.com/users/stevenernst131/following{/other_user}","gists_url":"https://api.github.com/users/stevenernst131/gists{/gist_id}","starred_url":"https://api.github.com/users/stevenernst131/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevenernst131/subscriptions","organizations_url":"https://api.github.com/users/stevenernst131/orgs","repos_url":"https://api.github.com/users/stevenernst131/repos","events_url":"https://api.github.com/users/stevenernst131/events{/privacy}","received_events_url":"https://api.github.com/users/stevenernst131/received_events","type":"User","site_admin":false},"body":"Are you still using this?","created_at":"2018-11-01T16:35:21Z","updated_at":"2018-11-01T16:35:21Z","html_url":"https://github.com/Azure/Azure-AppServices-Diagnostics-Portal/pull/180#discussion_r230108673","pull_request_url":"https://api.github.com/repos/Azure/Azure-AppServices-Diagnostics-Portal/pulls/180","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Azure/Azure-AppServices-Diagnostics-Portal/pulls/comments/230108673"},"html":{"href":"https://github.com/Azure/Azure-AppServices-Diagnostics-Portal/pull/180#discussion_r230108673"},"pull_request":{"href":"https://api.github.com/repos/Azure/Azure-AppServices-Diagnostics-Portal/pulls/180"}}},"pull_request":{"url":"https://api.github.com/repos/Azure/Azure-AppServices-Diagnostics-Portal/pulls/180","id":227389239,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3Mzg5MjM5","html_url":"https://github.com/Azure/Azure-AppServices-Diagnostics-Portal/pull/180","diff_url":"https://github.com/Azure/Azure-AppServices-Diagnostics-Portal/pull/180.diff","patch_url":"https://github.com/Azure/Azure-AppServices-Diagnostics-Portal/pull/180.patch","issue_url":"https://api.github.com/repos/Azure/Azure-AppServices-Diagnostics-Portal/issues/180","number":180,"state":"open","locked":false,"title":"Autohealingfixes","user":{"login":"puneetg1983","id":5299838,"node_id":"MDQ6VXNlcjUyOTk4Mzg=","avatar_url":"https://avatars0.githubusercontent.com/u/5299838?v=4","gravatar_id":"","url":"https://api.github.com/users/puneetg1983","html_url":"https://github.com/puneetg1983","followers_url":"https://api.github.com/users/puneetg1983/followers","following_url":"https://api.github.com/users/puneetg1983/following{/other_user}","gists_url":"https://api.github.com/users/puneetg1983/gists{/gist_id}","starred_url":"https://api.github.com/users/puneetg1983/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puneetg1983/subscriptions","organizations_url":"https://api.github.com/users/puneetg1983/orgs","repos_url":"https://api.github.com/users/puneetg1983/repos","events_url":"https://api.github.com/users/puneetg1983/events{/privacy}","received_events_url":"https://api.github.com/users/puneetg1983/received_events","type":"User","site_admin":false},"body":"Fixing AutoHeal detector and ensuring time range selection","created_at":"2018-10-31T18:04:24Z","updated_at":"2018-11-01T16:35:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d58b7356ec3002fc752ffcfb8b4a474d2527c575","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Azure/Azure-AppServices-Diagnostics-Portal/pulls/180/commits","review_comments_url":"https://api.github.com/repos/Azure/Azure-AppServices-Diagnostics-Portal/pulls/180/comments","review_comment_url":"https://api.github.com/repos/Azure/Azure-AppServices-Diagnostics-Portal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/Azure-AppServices-Diagnostics-Portal/issues/180/comments","statuses_url":"https://api.github.com/repos/Azure/Azure-AppServices-Diagnostics-Portal/statuses/3127bf3768f9ffaa9fc33061df40f38376de1689","head":{"label":"Azure:autohealingfixes","ref":"autohealingfixes","sha":"3127bf3768f9ffaa9fc33061df40f38376de1689","user":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":100755397,"node_id":"MDEwOlJlcG9zaXRvcnkxMDA3NTUzOTc=","name":"Azure-AppServices-Diagnostics-Portal","full_name":"Azure/Azure-AppServices-Diagnostics-Portal","private":false,"owner":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Azure/Azure-AppServices-Diagnostics-Portal","description":"Azure Web Apps Support Center provides developers with various features to troubleshoot their applications hosted on App Service.","fork":false,"url":"https://api.github.com/repos/Azure/Azure-AppServices-Diagnostics-Portal","forks_url":"https://api.github.com/repos/Azure/Azure-AppServices-Diagnostics-Portal/forks","keys_url":"https://api.github.com/repos/Azure/Azure-AppServices-Diagnostics-Portal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/Azure-AppServices-Diagnostics-Portal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/Azure-AppServices-Diagnostics-Portal/teams","hooks_url":"https://api.github.com/repos/Azure/Azure-AppServices-Diagnostics-Portal/hooks","issue_events_url":"https://api.github.com/repos/Azure/Azure-AppServices-Diagnostics-Portal/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/Azure-AppServices-Diagnostics-Portal/events","assignees_url":"https://api.github.com/repos/Azure/Azure-AppServices-Diagnostics-Portal/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/Azure-AppServices-Diagnostics-Portal/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/Azure-AppServices-Diagnostics-Portal/tags","blobs_url":"https://api.github.com/repos/Azure/Azure-AppServices-Diagnostics-Portal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/Azure-AppServices-Diagnostics-Portal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/Azure-AppServices-Diagnostics-Portal/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/Azure-AppServices-Diagnostics-Portal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/Azure-AppServices-Diagnostics-Portal/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/Azure-AppServices-Diagnostics-Portal/languages","stargazers_url":"https://api.github.com/repos/Azure/Azure-AppServices-Diagnostics-Portal/stargazers","contributors_url":"https://api.github.com/repos/Azure/Azure-AppServices-Diagnostics-Portal/contributors","subscribers_url":"https://api.github.com/repos/Azure/Azure-AppServices-Diagnostics-Portal/subscribers","subscription_url":"https://api.github.com/repos/Azure/Azure-AppServices-Diagnostics-Portal/subscription","commits_url":"https://api.github.com/repos/Azure/Azure-AppServices-Diagnostics-Portal/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/Azure-AppServices-Diagnostics-Portal/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/Azure-AppServices-Diagnostics-Portal/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/Azure-AppServices-Diagnostics-Portal/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/Azure-AppServices-Diagnostics-Portal/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/Azure-AppServices-Diagnostics-Portal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/Azure-AppServices-Diagnostics-Portal/merges","archive_url":"https://api.github.com/repos/Azure/Azure-AppServices-Diagnostics-Portal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/Azure-AppServices-Diagnostics-Portal/downloads","issues_url":"https://api.github.com/repos/Azure/Azure-AppServices-Diagnostics-Portal/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/Azure-AppServices-Diagnostics-Portal/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/Azure-AppServices-Diagnostics-Portal/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/Azure-AppServices-Diagnostics-Portal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/Azure-AppServices-Diagnostics-Portal/labels{/name}","releases_url":"https://api.github.com/repos/Azure/Azure-AppServices-Diagnostics-Portal/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/Azure-AppServices-Diagnostics-Portal/deployments","created_at":"2017-08-18T22:44:50Z","updated_at":"2018-10-31T19:52:57Z","pushed_at":"2018-10-31T20:28:31Z","git_url":"git://github.com/Azure/Azure-AppServices-Diagnostics-Portal.git","ssh_url":"[email protected]:Azure/Azure-AppServices-Diagnostics-Portal.git","clone_url":"https://github.com/Azure/Azure-AppServices-Diagnostics-Portal.git","svn_url":"https://github.com/Azure/Azure-AppServices-Diagnostics-Portal","homepage":null,"size":973,"stargazers_count":10,"watchers_count":10,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":15,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":4,"open_issues":15,"watchers":10,"default_branch":"master"}},"base":{"label":"Azure:master","ref":"master","sha":"3444bcada3c59acc084c92877020cbf835069700","user":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":100755397,"node_id":"MDEwOlJlcG9zaXRvcnkxMDA3NTUzOTc=","name":"Azure-AppServices-Diagnostics-Portal","full_name":"Azure/Azure-AppServices-Diagnostics-Portal","private":false,"owner":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Azure/Azure-AppServices-Diagnostics-Portal","description":"Azure Web Apps Support Center provides developers with various features to troubleshoot their applications hosted on App Service.","fork":false,"url":"https://api.github.com/repos/Azure/Azure-AppServices-Diagnostics-Portal","forks_url":"https://api.github.com/repos/Azure/Azure-AppServices-Diagnostics-Portal/forks","keys_url":"https://api.github.com/repos/Azure/Azure-AppServices-Diagnostics-Portal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/Azure-AppServices-Diagnostics-Portal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/Azure-AppServices-Diagnostics-Portal/teams","hooks_url":"https://api.github.com/repos/Azure/Azure-AppServices-Diagnostics-Portal/hooks","issue_events_url":"https://api.github.com/repos/Azure/Azure-AppServices-Diagnostics-Portal/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/Azure-AppServices-Diagnostics-Portal/events","assignees_url":"https://api.github.com/repos/Azure/Azure-AppServices-Diagnostics-Portal/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/Azure-AppServices-Diagnostics-Portal/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/Azure-AppServices-Diagnostics-Portal/tags","blobs_url":"https://api.github.com/repos/Azure/Azure-AppServices-Diagnostics-Portal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/Azure-AppServices-Diagnostics-Portal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/Azure-AppServices-Diagnostics-Portal/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/Azure-AppServices-Diagnostics-Portal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/Azure-AppServices-Diagnostics-Portal/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/Azure-AppServices-Diagnostics-Portal/languages","stargazers_url":"https://api.github.com/repos/Azure/Azure-AppServices-Diagnostics-Portal/stargazers","contributors_url":"https://api.github.com/repos/Azure/Azure-AppServices-Diagnostics-Portal/contributors","subscribers_url":"https://api.github.com/repos/Azure/Azure-AppServices-Diagnostics-Portal/subscribers","subscription_url":"https://api.github.com/repos/Azure/Azure-AppServices-Diagnostics-Portal/subscription","commits_url":"https://api.github.com/repos/Azure/Azure-AppServices-Diagnostics-Portal/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/Azure-AppServices-Diagnostics-Portal/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/Azure-AppServices-Diagnostics-Portal/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/Azure-AppServices-Diagnostics-Portal/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/Azure-AppServices-Diagnostics-Portal/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/Azure-AppServices-Diagnostics-Portal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/Azure-AppServices-Diagnostics-Portal/merges","archive_url":"https://api.github.com/repos/Azure/Azure-AppServices-Diagnostics-Portal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/Azure-AppServices-Diagnostics-Portal/downloads","issues_url":"https://api.github.com/repos/Azure/Azure-AppServices-Diagnostics-Portal/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/Azure-AppServices-Diagnostics-Portal/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/Azure-AppServices-Diagnostics-Portal/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/Azure-AppServices-Diagnostics-Portal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/Azure-AppServices-Diagnostics-Portal/labels{/name}","releases_url":"https://api.github.com/repos/Azure/Azure-AppServices-Diagnostics-Portal/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/Azure-AppServices-Diagnostics-Portal/deployments","created_at":"2017-08-18T22:44:50Z","updated_at":"2018-10-31T19:52:57Z","pushed_at":"2018-10-31T20:28:31Z","git_url":"git://github.com/Azure/Azure-AppServices-Diagnostics-Portal.git","ssh_url":"[email protected]:Azure/Azure-AppServices-Diagnostics-Portal.git","clone_url":"https://github.com/Azure/Azure-AppServices-Diagnostics-Portal.git","svn_url":"https://github.com/Azure/Azure-AppServices-Diagnostics-Portal","homepage":null,"size":973,"stargazers_count":10,"watchers_count":10,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":15,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":4,"open_issues":15,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/Azure-AppServices-Diagnostics-Portal/pulls/180"},"html":{"href":"https://github.com/Azure/Azure-AppServices-Diagnostics-Portal/pull/180"},"issue":{"href":"https://api.github.com/repos/Azure/Azure-AppServices-Diagnostics-Portal/issues/180"},"comments":{"href":"https://api.github.com/repos/Azure/Azure-AppServices-Diagnostics-Portal/issues/180/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/Azure-AppServices-Diagnostics-Portal/pulls/180/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/Azure-AppServices-Diagnostics-Portal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/Azure-AppServices-Diagnostics-Portal/pulls/180/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/Azure-AppServices-Diagnostics-Portal/statuses/3127bf3768f9ffaa9fc33061df40f38376de1689"}},"author_association":"CONTRIBUTOR"}} | {
"id": 100755397,
"name": "Azure/Azure-AppServices-Diagnostics-Portal",
"url": "https://api.github.com/repos/Azure/Azure-AppServices-Diagnostics-Portal"
} | {
"id": 7739017,
"login": "stevenernst131",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7739017?",
"url": "https://api.github.com/users/stevenernst131"
} | {
"id": 6844498,
"login": "Azure",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6844498?",
"url": "https://api.github.com/orgs/Azure"
} | 2018-11-01T16:35:21 | 8520185196 | {"actor":{"display_login":"stevenernst131"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/Azure/azure-functions-durable-extension/pulls/comments/183570763","pull_request_review_id":114594216,"id":183570763,"diff_hunk":"@@ -117,7 +137,22 @@ public void SetFunctionInvocationCallback(Func<Task> callback)\n \n if (returnValue != null)\n {\n- this.context.SetOutput(returnValue);\n+ if (orchestratorInfo.IsOutOfProc)\n+ {\n+ var jObj = returnValue as JObject;\n+ if (returnValue != null)","path":"src/WebJobs.Extensions.DurableTask/Listener/TaskOrchestrationShim.cs","position":71,"original_position":71,"commit_id":"a0caba9c01838b56e8bfa3117dce8941dfb3835e","original_commit_id":"a0caba9c01838b56e8bfa3117dce8941dfb3835e","user":{"login":"cgillum","id":2704139,"avatar_url":"https://avatars2.githubusercontent.com/u/2704139?v=4","gravatar_id":"","url":"https://api.github.com/users/cgillum","html_url":"https://github.com/cgillum","followers_url":"https://api.github.com/users/cgillum/followers","following_url":"https://api.github.com/users/cgillum/following{/other_user}","gists_url":"https://api.github.com/users/cgillum/gists{/gist_id}","starred_url":"https://api.github.com/users/cgillum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cgillum/subscriptions","organizations_url":"https://api.github.com/users/cgillum/orgs","repos_url":"https://api.github.com/users/cgillum/repos","events_url":"https://api.github.com/users/cgillum/events{/privacy}","received_events_url":"https://api.github.com/users/cgillum/received_events","type":"User","site_admin":false},"body":"This should be `if (jObj != null)`.","created_at":"2018-04-23T23:53:02Z","updated_at":"2018-04-23T23:53:55Z","html_url":"https://github.com/Azure/azure-functions-durable-extension/pull/269#discussion_r183570763","pull_request_url":"https://api.github.com/repos/Azure/azure-functions-durable-extension/pulls/269","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-functions-durable-extension/pulls/comments/183570763"},"html":{"href":"https://github.com/Azure/azure-functions-durable-extension/pull/269#discussion_r183570763"},"pull_request":{"href":"https://api.github.com/repos/Azure/azure-functions-durable-extension/pulls/269"}}},"pull_request":{"url":"https://api.github.com/repos/Azure/azure-functions-durable-extension/pulls/269","id":182921715,"html_url":"https://github.com/Azure/azure-functions-durable-extension/pull/269","diff_url":"https://github.com/Azure/azure-functions-durable-extension/pull/269.diff","patch_url":"https://github.com/Azure/azure-functions-durable-extension/pull/269.patch","issue_url":"https://api.github.com/repos/Azure/azure-functions-durable-extension/issues/269","number":269,"state":"open","locked":false,"title":"Nodejs v2","user":{"login":"kashimiz","id":17170862,"avatar_url":"https://avatars1.githubusercontent.com/u/17170862?v=4","gravatar_id":"","url":"https://api.github.com/users/kashimiz","html_url":"https://github.com/kashimiz","followers_url":"https://api.github.com/users/kashimiz/followers","following_url":"https://api.github.com/users/kashimiz/following{/other_user}","gists_url":"https://api.github.com/users/kashimiz/gists{/gist_id}","starred_url":"https://api.github.com/users/kashimiz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kashimiz/subscriptions","organizations_url":"https://api.github.com/users/kashimiz/orgs","repos_url":"https://api.github.com/users/kashimiz/repos","events_url":"https://api.github.com/users/kashimiz/events{/privacy}","received_events_url":"https://api.github.com/users/kashimiz/received_events","type":"User","site_admin":false},"body":"Enables interpretation/output of JSON schema for out of proc orchestrators.","created_at":"2018-04-19T23:07:36Z","updated_at":"2018-04-23T23:53:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ff933c76561307ccb9355d233d1d126c3c75741f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Azure/azure-functions-durable-extension/pulls/269/commits","review_comments_url":"https://api.github.com/repos/Azure/azure-functions-durable-extension/pulls/269/comments","review_comment_url":"https://api.github.com/repos/Azure/azure-functions-durable-extension/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/azure-functions-durable-extension/issues/269/comments","statuses_url":"https://api.github.com/repos/Azure/azure-functions-durable-extension/statuses/a0caba9c01838b56e8bfa3117dce8941dfb3835e","head":{"label":"kashimiz:nodejs-v2","ref":"nodejs-v2","sha":"a0caba9c01838b56e8bfa3117dce8941dfb3835e","user":{"login":"kashimiz","id":17170862,"avatar_url":"https://avatars1.githubusercontent.com/u/17170862?v=4","gravatar_id":"","url":"https://api.github.com/users/kashimiz","html_url":"https://github.com/kashimiz","followers_url":"https://api.github.com/users/kashimiz/followers","following_url":"https://api.github.com/users/kashimiz/following{/other_user}","gists_url":"https://api.github.com/users/kashimiz/gists{/gist_id}","starred_url":"https://api.github.com/users/kashimiz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kashimiz/subscriptions","organizations_url":"https://api.github.com/users/kashimiz/orgs","repos_url":"https://api.github.com/users/kashimiz/repos","events_url":"https://api.github.com/users/kashimiz/events{/privacy}","received_events_url":"https://api.github.com/users/kashimiz/received_events","type":"User","site_admin":false},"repo":{"id":117751429,"name":"azure-functions-durable-extension","full_name":"kashimiz/azure-functions-durable-extension","owner":{"login":"kashimiz","id":17170862,"avatar_url":"https://avatars1.githubusercontent.com/u/17170862?v=4","gravatar_id":"","url":"https://api.github.com/users/kashimiz","html_url":"https://github.com/kashimiz","followers_url":"https://api.github.com/users/kashimiz/followers","following_url":"https://api.github.com/users/kashimiz/following{/other_user}","gists_url":"https://api.github.com/users/kashimiz/gists{/gist_id}","starred_url":"https://api.github.com/users/kashimiz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kashimiz/subscriptions","organizations_url":"https://api.github.com/users/kashimiz/orgs","repos_url":"https://api.github.com/users/kashimiz/repos","events_url":"https://api.github.com/users/kashimiz/events{/privacy}","received_events_url":"https://api.github.com/users/kashimiz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kashimiz/azure-functions-durable-extension","description":"Durable Task Framework extension for Azure Functions","fork":true,"url":"https://api.github.com/repos/kashimiz/azure-functions-durable-extension","forks_url":"https://api.github.com/repos/kashimiz/azure-functions-durable-extension/forks","keys_url":"https://api.github.com/repos/kashimiz/azure-functions-durable-extension/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kashimiz/azure-functions-durable-extension/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kashimiz/azure-functions-durable-extension/teams","hooks_url":"https://api.github.com/repos/kashimiz/azure-functions-durable-extension/hooks","issue_events_url":"https://api.github.com/repos/kashimiz/azure-functions-durable-extension/issues/events{/number}","events_url":"https://api.github.com/repos/kashimiz/azure-functions-durable-extension/events","assignees_url":"https://api.github.com/repos/kashimiz/azure-functions-durable-extension/assignees{/user}","branches_url":"https://api.github.com/repos/kashimiz/azure-functions-durable-extension/branches{/branch}","tags_url":"https://api.github.com/repos/kashimiz/azure-functions-durable-extension/tags","blobs_url":"https://api.github.com/repos/kashimiz/azure-functions-durable-extension/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kashimiz/azure-functions-durable-extension/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kashimiz/azure-functions-durable-extension/git/refs{/sha}","trees_url":"https://api.github.com/repos/kashimiz/azure-functions-durable-extension/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kashimiz/azure-functions-durable-extension/statuses/{sha}","languages_url":"https://api.github.com/repos/kashimiz/azure-functions-durable-extension/languages","stargazers_url":"https://api.github.com/repos/kashimiz/azure-functions-durable-extension/stargazers","contributors_url":"https://api.github.com/repos/kashimiz/azure-functions-durable-extension/contributors","subscribers_url":"https://api.github.com/repos/kashimiz/azure-functions-durable-extension/subscribers","subscription_url":"https://api.github.com/repos/kashimiz/azure-functions-durable-extension/subscription","commits_url":"https://api.github.com/repos/kashimiz/azure-functions-durable-extension/commits{/sha}","git_commits_url":"https://api.github.com/repos/kashimiz/azure-functions-durable-extension/git/commits{/sha}","comments_url":"https://api.github.com/repos/kashimiz/azure-functions-durable-extension/comments{/number}","issue_comment_url":"https://api.github.com/repos/kashimiz/azure-functions-durable-extension/issues/comments{/number}","contents_url":"https://api.github.com/repos/kashimiz/azure-functions-durable-extension/contents/{+path}","compare_url":"https://api.github.com/repos/kashimiz/azure-functions-durable-extension/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kashimiz/azure-functions-durable-extension/merges","archive_url":"https://api.github.com/repos/kashimiz/azure-functions-durable-extension/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kashimiz/azure-functions-durable-extension/downloads","issues_url":"https://api.github.com/repos/kashimiz/azure-functions-durable-extension/issues{/number}","pulls_url":"https://api.github.com/repos/kashimiz/azure-functions-durable-extension/pulls{/number}","milestones_url":"https://api.github.com/repos/kashimiz/azure-functions-durable-extension/milestones{/number}","notifications_url":"https://api.github.com/repos/kashimiz/azure-functions-durable-extension/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kashimiz/azure-functions-durable-extension/labels{/name}","releases_url":"https://api.github.com/repos/kashimiz/azure-functions-durable-extension/releases{/id}","deployments_url":"https://api.github.com/repos/kashimiz/azure-functions-durable-extension/deployments","created_at":"2018-01-16T22:39:19Z","updated_at":"2018-04-11T17:37:12Z","pushed_at":"2018-04-23T23:39:45Z","git_url":"git://github.com/kashimiz/azure-functions-durable-extension.git","ssh_url":"[email protected]:kashimiz/azure-functions-durable-extension.git","clone_url":"https://github.com/kashimiz/azure-functions-durable-extension.git","svn_url":"https://github.com/kashimiz/azure-functions-durable-extension","homepage":null,"size":9520,"stargazers_count":1,"watchers_count":1,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"Azure:dev","ref":"dev","sha":"fff0bb7b45db6877225d7ef79d06254c4cf2efcf","user":{"login":"Azure","id":6844498,"avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":93190658,"name":"azure-functions-durable-extension","full_name":"Azure/azure-functions-durable-extension","owner":{"login":"Azure","id":6844498,"avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Azure/azure-functions-durable-extension","description":"Durable Task Framework extension for Azure Functions","fork":false,"url":"https://api.github.com/repos/Azure/azure-functions-durable-extension","forks_url":"https://api.github.com/repos/Azure/azure-functions-durable-extension/forks","keys_url":"https://api.github.com/repos/Azure/azure-functions-durable-extension/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/azure-functions-durable-extension/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/azure-functions-durable-extension/teams","hooks_url":"https://api.github.com/repos/Azure/azure-functions-durable-extension/hooks","issue_events_url":"https://api.github.com/repos/Azure/azure-functions-durable-extension/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/azure-functions-durable-extension/events","assignees_url":"https://api.github.com/repos/Azure/azure-functions-durable-extension/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/azure-functions-durable-extension/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/azure-functions-durable-extension/tags","blobs_url":"https://api.github.com/repos/Azure/azure-functions-durable-extension/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/azure-functions-durable-extension/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/azure-functions-durable-extension/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/azure-functions-durable-extension/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/azure-functions-durable-extension/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/azure-functions-durable-extension/languages","stargazers_url":"https://api.github.com/repos/Azure/azure-functions-durable-extension/stargazers","contributors_url":"https://api.github.com/repos/Azure/azure-functions-durable-extension/contributors","subscribers_url":"https://api.github.com/repos/Azure/azure-functions-durable-extension/subscribers","subscription_url":"https://api.github.com/repos/Azure/azure-functions-durable-extension/subscription","commits_url":"https://api.github.com/repos/Azure/azure-functions-durable-extension/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/azure-functions-durable-extension/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/azure-functions-durable-extension/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/azure-functions-durable-extension/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/azure-functions-durable-extension/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/azure-functions-durable-extension/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/azure-functions-durable-extension/merges","archive_url":"https://api.github.com/repos/Azure/azure-functions-durable-extension/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/azure-functions-durable-extension/downloads","issues_url":"https://api.github.com/repos/Azure/azure-functions-durable-extension/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/azure-functions-durable-extension/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/azure-functions-durable-extension/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/azure-functions-durable-extension/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/azure-functions-durable-extension/labels{/name}","releases_url":"https://api.github.com/repos/Azure/azure-functions-durable-extension/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/azure-functions-durable-extension/deployments","created_at":"2017-06-02T17:51:30Z","updated_at":"2018-04-23T15:30:23Z","pushed_at":"2018-04-23T23:39:47Z","git_url":"git://github.com/Azure/azure-functions-durable-extension.git","ssh_url":"[email protected]:Azure/azure-functions-durable-extension.git","clone_url":"https://github.com/Azure/azure-functions-durable-extension.git","svn_url":"https://github.com/Azure/azure-functions-durable-extension","homepage":null,"size":9516,"stargazers_count":105,"watchers_count":105,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":39,"mirror_url":null,"archived":false,"open_issues_count":54,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":39,"open_issues":54,"watchers":105,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-functions-durable-extension/pulls/269"},"html":{"href":"https://github.com/Azure/azure-functions-durable-extension/pull/269"},"issue":{"href":"https://api.github.com/repos/Azure/azure-functions-durable-extension/issues/269"},"comments":{"href":"https://api.github.com/repos/Azure/azure-functions-durable-extension/issues/269/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/azure-functions-durable-extension/pulls/269/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/azure-functions-durable-extension/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/azure-functions-durable-extension/pulls/269/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/azure-functions-durable-extension/statuses/a0caba9c01838b56e8bfa3117dce8941dfb3835e"}},"author_association":"MEMBER"}} | {
"id": 93190658,
"name": "Azure/azure-functions-durable-extension",
"url": "https://api.github.com/repos/Azure/azure-functions-durable-extension"
} | {
"id": 2704139,
"login": "cgillum",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2704139?",
"url": "https://api.github.com/users/cgillum"
} | {
"id": 6844498,
"login": "Azure",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6844498?",
"url": "https://api.github.com/orgs/Azure"
} | 2018-04-23T23:53:02 | 7575122339 | {"actor":{"display_login":"cgillum"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/Azure/sonic-utilities/pulls/comments/232037699","pull_request_review_id":173141178,"id":232037699,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMjAzNzY5OQ==","diff_hunk":"@@ -12,17 +12,20 @@\n from swsssdk import ConfigDBConnector\n from natsort import natsorted\n from minigraph import parse_device_desc_xml\n+from portconfig import get_port_config","path":"config/main.py","position":4,"original_position":4,"commit_id":"26670e8b77dc4b1ac48cd7522d52c7efe710a723","original_commit_id":"26670e8b77dc4b1ac48cd7522d52c7efe710a723","user":{"login":"jleveque","id":3300381,"node_id":"MDQ6VXNlcjMzMDAzODE=","avatar_url":"https://avatars1.githubusercontent.com/u/3300381?v=4","gravatar_id":"","url":"https://api.github.com/users/jleveque","html_url":"https://github.com/jleveque","followers_url":"https://api.github.com/users/jleveque/followers","following_url":"https://api.github.com/users/jleveque/following{/other_user}","gists_url":"https://api.github.com/users/jleveque/gists{/gist_id}","starred_url":"https://api.github.com/users/jleveque/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jleveque/subscriptions","organizations_url":"https://api.github.com/users/jleveque/orgs","repos_url":"https://api.github.com/users/jleveque/repos","events_url":"https://api.github.com/users/jleveque/events{/privacy}","received_events_url":"https://api.github.com/users/jleveque/received_events","type":"User","site_admin":false},"body":"Why add this import if you are not using it?","created_at":"2018-11-08T19:48:40Z","updated_at":"2018-11-08T19:50:43Z","html_url":"https://github.com/Azure/sonic-utilities/pull/362#discussion_r232037699","pull_request_url":"https://api.github.com/repos/Azure/sonic-utilities/pulls/362","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Azure/sonic-utilities/pulls/comments/232037699"},"html":{"href":"https://github.com/Azure/sonic-utilities/pull/362#discussion_r232037699"},"pull_request":{"href":"https://api.github.com/repos/Azure/sonic-utilities/pulls/362"}}},"pull_request":{"url":"https://api.github.com/repos/Azure/sonic-utilities/pulls/362","id":227253317,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3MjUzMzE3","html_url":"https://github.com/Azure/sonic-utilities/pull/362","diff_url":"https://github.com/Azure/sonic-utilities/pull/362.diff","patch_url":"https://github.com/Azure/sonic-utilities/pull/362.patch","issue_url":"https://api.github.com/repos/Azure/sonic-utilities/issues/362","number":362,"state":"open","locked":false,"title":" [sonic-cfggen]: Optimizing config/main.py to use config_db to fetch port related information and remove sonic-cfggen from the script.","user":{"login":"paavaanan","id":30253537,"node_id":"MDQ6VXNlcjMwMjUzNTM3","avatar_url":"https://avatars0.githubusercontent.com/u/30253537?v=4","gravatar_id":"","url":"https://api.github.com/users/paavaanan","html_url":"https://github.com/paavaanan","followers_url":"https://api.github.com/users/paavaanan/followers","following_url":"https://api.github.com/users/paavaanan/following{/other_user}","gists_url":"https://api.github.com/users/paavaanan/gists{/gist_id}","starred_url":"https://api.github.com/users/paavaanan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paavaanan/subscriptions","organizations_url":"https://api.github.com/users/paavaanan/orgs","repos_url":"https://api.github.com/users/paavaanan/repos","events_url":"https://api.github.com/users/paavaanan/events{/privacy}","received_events_url":"https://api.github.com/users/paavaanan/received_events","type":"User","site_admin":false},"body":"<!--\r\nPlease make sure you've read and understood our contributing guidelines:\r\nhttps://github.com/Azure/SONiC/blob/gh-pages/CONTRIBUTING.md\r\n\r\n** Make sure all your commits include a signature generated with `git commit -s` **\r\n\r\nIf this is a bug fix, make sure your description includes \"closes #xxxx\",\r\n\"fixes #xxxx\" or \"resolves #xxxx\" so that GitHub automatically closes the related\r\nissue when the PR is merged\r\n\r\nPlease provide the following information:\r\n-->\r\n\r\n**- What I did**\r\n- interface_naming_mode functions fetch the alias_interface_name via sonic-cfggen. But, with the recent change in config_db removes all port related entries when a sepecific interface is down. This affects the existing implementation of fetching port details to following fucntions [ interface_alias_to_name(), interface_name_to_allias(), InterfaceAliasConverter() ] and throws key error.\r\n\r\n**- How I did it**\r\n\r\n- To fix this, harnessed the existing port_config.ini file to fetch the interface details and populated a port_dict and this fetch the alias interface names quickly.\r\n\r\nNOTE: config commands are entirely modified from linux commands to db format. This fix does not cover interface validation for those commands.\r\n\r\n\r\n","created_at":"2018-10-31T11:41:37Z","updated_at":"2018-11-08T19:50:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8b0edd8e1c5a5f90e5a7def7ee04c333fd1ad347","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":338891062,"node_id":"MDU6TGFiZWwzMzg4OTEwNjI=","url":"https://api.github.com/repos/Azure/sonic-utilities/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/Azure/sonic-utilities/pulls/362/commits","review_comments_url":"https://api.github.com/repos/Azure/sonic-utilities/pulls/362/comments","review_comment_url":"https://api.github.com/repos/Azure/sonic-utilities/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/sonic-utilities/issues/362/comments","statuses_url":"https://api.github.com/repos/Azure/sonic-utilities/statuses/26670e8b77dc4b1ac48cd7522d52c7efe710a723","head":{"label":"paavaanan:sonic-keyerror-fixes","ref":"sonic-keyerror-fixes","sha":"26670e8b77dc4b1ac48cd7522d52c7efe710a723","user":{"login":"paavaanan","id":30253537,"node_id":"MDQ6VXNlcjMwMjUzNTM3","avatar_url":"https://avatars0.githubusercontent.com/u/30253537?v=4","gravatar_id":"","url":"https://api.github.com/users/paavaanan","html_url":"https://github.com/paavaanan","followers_url":"https://api.github.com/users/paavaanan/followers","following_url":"https://api.github.com/users/paavaanan/following{/other_user}","gists_url":"https://api.github.com/users/paavaanan/gists{/gist_id}","starred_url":"https://api.github.com/users/paavaanan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paavaanan/subscriptions","organizations_url":"https://api.github.com/users/paavaanan/orgs","repos_url":"https://api.github.com/users/paavaanan/repos","events_url":"https://api.github.com/users/paavaanan/events{/privacy}","received_events_url":"https://api.github.com/users/paavaanan/received_events","type":"User","site_admin":false},"repo":{"id":135414184,"node_id":"MDEwOlJlcG9zaXRvcnkxMzU0MTQxODQ=","name":"sonic-utilities","full_name":"paavaanan/sonic-utilities","private":false,"owner":{"login":"paavaanan","id":30253537,"node_id":"MDQ6VXNlcjMwMjUzNTM3","avatar_url":"https://avatars0.githubusercontent.com/u/30253537?v=4","gravatar_id":"","url":"https://api.github.com/users/paavaanan","html_url":"https://github.com/paavaanan","followers_url":"https://api.github.com/users/paavaanan/followers","following_url":"https://api.github.com/users/paavaanan/following{/other_user}","gists_url":"https://api.github.com/users/paavaanan/gists{/gist_id}","starred_url":"https://api.github.com/users/paavaanan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paavaanan/subscriptions","organizations_url":"https://api.github.com/users/paavaanan/orgs","repos_url":"https://api.github.com/users/paavaanan/repos","events_url":"https://api.github.com/users/paavaanan/events{/privacy}","received_events_url":"https://api.github.com/users/paavaanan/received_events","type":"User","site_admin":false},"html_url":"https://github.com/paavaanan/sonic-utilities","description":"Command line utilities for the SONiC project","fork":true,"url":"https://api.github.com/repos/paavaanan/sonic-utilities","forks_url":"https://api.github.com/repos/paavaanan/sonic-utilities/forks","keys_url":"https://api.github.com/repos/paavaanan/sonic-utilities/keys{/key_id}","collaborators_url":"https://api.github.com/repos/paavaanan/sonic-utilities/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/paavaanan/sonic-utilities/teams","hooks_url":"https://api.github.com/repos/paavaanan/sonic-utilities/hooks","issue_events_url":"https://api.github.com/repos/paavaanan/sonic-utilities/issues/events{/number}","events_url":"https://api.github.com/repos/paavaanan/sonic-utilities/events","assignees_url":"https://api.github.com/repos/paavaanan/sonic-utilities/assignees{/user}","branches_url":"https://api.github.com/repos/paavaanan/sonic-utilities/branches{/branch}","tags_url":"https://api.github.com/repos/paavaanan/sonic-utilities/tags","blobs_url":"https://api.github.com/repos/paavaanan/sonic-utilities/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/paavaanan/sonic-utilities/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/paavaanan/sonic-utilities/git/refs{/sha}","trees_url":"https://api.github.com/repos/paavaanan/sonic-utilities/git/trees{/sha}","statuses_url":"https://api.github.com/repos/paavaanan/sonic-utilities/statuses/{sha}","languages_url":"https://api.github.com/repos/paavaanan/sonic-utilities/languages","stargazers_url":"https://api.github.com/repos/paavaanan/sonic-utilities/stargazers","contributors_url":"https://api.github.com/repos/paavaanan/sonic-utilities/contributors","subscribers_url":"https://api.github.com/repos/paavaanan/sonic-utilities/subscribers","subscription_url":"https://api.github.com/repos/paavaanan/sonic-utilities/subscription","commits_url":"https://api.github.com/repos/paavaanan/sonic-utilities/commits{/sha}","git_commits_url":"https://api.github.com/repos/paavaanan/sonic-utilities/git/commits{/sha}","comments_url":"https://api.github.com/repos/paavaanan/sonic-utilities/comments{/number}","issue_comment_url":"https://api.github.com/repos/paavaanan/sonic-utilities/issues/comments{/number}","contents_url":"https://api.github.com/repos/paavaanan/sonic-utilities/contents/{+path}","compare_url":"https://api.github.com/repos/paavaanan/sonic-utilities/compare/{base}...{head}","merges_url":"https://api.github.com/repos/paavaanan/sonic-utilities/merges","archive_url":"https://api.github.com/repos/paavaanan/sonic-utilities/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/paavaanan/sonic-utilities/downloads","issues_url":"https://api.github.com/repos/paavaanan/sonic-utilities/issues{/number}","pulls_url":"https://api.github.com/repos/paavaanan/sonic-utilities/pulls{/number}","milestones_url":"https://api.github.com/repos/paavaanan/sonic-utilities/milestones{/number}","notifications_url":"https://api.github.com/repos/paavaanan/sonic-utilities/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/paavaanan/sonic-utilities/labels{/name}","releases_url":"https://api.github.com/repos/paavaanan/sonic-utilities/releases{/id}","deployments_url":"https://api.github.com/repos/paavaanan/sonic-utilities/deployments","created_at":"2018-05-30T08:42:13Z","updated_at":"2018-10-31T10:09:36Z","pushed_at":"2018-11-08T12:23:20Z","git_url":"git://github.com/paavaanan/sonic-utilities.git","ssh_url":"[email protected]:paavaanan/sonic-utilities.git","clone_url":"https://github.com/paavaanan/sonic-utilities.git","svn_url":"https://github.com/paavaanan/sonic-utilities","homepage":null,"size":732,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Azure:master","ref":"master","sha":"d7bc98e17df64d3895c5c580d09a9269a9ba9ed9","user":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":53515393,"node_id":"MDEwOlJlcG9zaXRvcnk1MzUxNTM5Mw==","name":"sonic-utilities","full_name":"Azure/sonic-utilities","private":false,"owner":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Azure/sonic-utilities","description":"Command line utilities for the SONiC project","fork":false,"url":"https://api.github.com/repos/Azure/sonic-utilities","forks_url":"https://api.github.com/repos/Azure/sonic-utilities/forks","keys_url":"https://api.github.com/repos/Azure/sonic-utilities/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/sonic-utilities/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/sonic-utilities/teams","hooks_url":"https://api.github.com/repos/Azure/sonic-utilities/hooks","issue_events_url":"https://api.github.com/repos/Azure/sonic-utilities/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/sonic-utilities/events","assignees_url":"https://api.github.com/repos/Azure/sonic-utilities/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/sonic-utilities/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/sonic-utilities/tags","blobs_url":"https://api.github.com/repos/Azure/sonic-utilities/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/sonic-utilities/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/sonic-utilities/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/sonic-utilities/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/sonic-utilities/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/sonic-utilities/languages","stargazers_url":"https://api.github.com/repos/Azure/sonic-utilities/stargazers","contributors_url":"https://api.github.com/repos/Azure/sonic-utilities/contributors","subscribers_url":"https://api.github.com/repos/Azure/sonic-utilities/subscribers","subscription_url":"https://api.github.com/repos/Azure/sonic-utilities/subscription","commits_url":"https://api.github.com/repos/Azure/sonic-utilities/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/sonic-utilities/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/sonic-utilities/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/sonic-utilities/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/sonic-utilities/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/sonic-utilities/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/sonic-utilities/merges","archive_url":"https://api.github.com/repos/Azure/sonic-utilities/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/sonic-utilities/downloads","issues_url":"https://api.github.com/repos/Azure/sonic-utilities/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/sonic-utilities/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/sonic-utilities/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/sonic-utilities/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/sonic-utilities/labels{/name}","releases_url":"https://api.github.com/repos/Azure/sonic-utilities/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/sonic-utilities/deployments","created_at":"2016-03-09T16:59:59Z","updated_at":"2018-11-08T04:46:02Z","pushed_at":"2018-11-08T17:47:16Z","git_url":"git://github.com/Azure/sonic-utilities.git","ssh_url":"[email protected]:Azure/sonic-utilities.git","clone_url":"https://github.com/Azure/sonic-utilities.git","svn_url":"https://github.com/Azure/sonic-utilities","homepage":null,"size":702,"stargazers_count":8,"watchers_count":8,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":60,"mirror_url":null,"archived":false,"open_issues_count":50,"license":null,"forks":60,"open_issues":50,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/sonic-utilities/pulls/362"},"html":{"href":"https://github.com/Azure/sonic-utilities/pull/362"},"issue":{"href":"https://api.github.com/repos/Azure/sonic-utilities/issues/362"},"comments":{"href":"https://api.github.com/repos/Azure/sonic-utilities/issues/362/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/sonic-utilities/pulls/362/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/sonic-utilities/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/sonic-utilities/pulls/362/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/sonic-utilities/statuses/26670e8b77dc4b1ac48cd7522d52c7efe710a723"}},"author_association":"CONTRIBUTOR"}} | {
"id": 53515393,
"name": "Azure/sonic-utilities",
"url": "https://api.github.com/repos/Azure/sonic-utilities"
} | {
"id": 3300381,
"login": "jleveque",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3300381?",
"url": "https://api.github.com/users/jleveque"
} | {
"id": 6844498,
"login": "Azure",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6844498?",
"url": "https://api.github.com/orgs/Azure"
} | 2018-11-08T19:48:40 | 8558975317 | {"actor":{"display_login":"jleveque"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/Azure/azure-powershell/pulls/comments/193842100","pull_request_review_id":126893496,"id":193842100,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5Mzg0MjEwMA==","diff_hunk":"@@ -0,0 +1,167 @@\n+# ----------------------------------------------------------------------------------\n+#\n+# Copyright Microsoft Corporation\n+# Licensed under the Apache License, Version 2.0 (the \"License\");\n+# you may not use this file except in compliance with the License.\n+# You may obtain a copy of the License at\n+# http://www.apache.org/licenses/LICENSE-2.0\n+# Unless required by applicable law or agreed to in writing, software\n+# distributed under the License is distributed on an \"AS IS\" BASIS,\n+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+# See the License for the specific language governing permissions and\n+# limitations under the License.\n+# ----------------------------------------------------------------------------------\n+\n+<#\n+.SYNOPSIS\n+List monthly reservation summaries with reservation order Id\n+#>\n+function Test-ListReservationSummariesMonthlyWithOrderId\n+{","path":"src/ResourceManager/Consumption/Commands.Consumption.Test/ScenarioTests/ReservationTests.ps1","position":20,"original_position":20,"commit_id":"fe8a19f88479dd979cbbc728b5cf8f6653507f9d","original_commit_id":"b19afd2e874231a44ff65dc6542826bd05b3ae73","user":{"login":"maddieclayton","id":8137559,"node_id":"MDQ6VXNlcjgxMzc1NTk=","avatar_url":"https://avatars1.githubusercontent.com/u/8137559?v=4","gravatar_id":"","url":"https://api.github.com/users/maddieclayton","html_url":"https://github.com/maddieclayton","followers_url":"https://api.github.com/users/maddieclayton/followers","following_url":"https://api.github.com/users/maddieclayton/following{/other_user}","gists_url":"https://api.github.com/users/maddieclayton/gists{/gist_id}","starred_url":"https://api.github.com/users/maddieclayton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maddieclayton/subscriptions","organizations_url":"https://api.github.com/users/maddieclayton/orgs","repos_url":"https://api.github.com/users/maddieclayton/repos","events_url":"https://api.github.com/users/maddieclayton/events{/privacy}","received_events_url":"https://api.github.com/users/maddieclayton/received_events","type":"User","site_admin":false},"body":"Got it. Then all you need to do is add instructions about how to record the test here as well.","created_at":"2018-06-07T18:13:23Z","updated_at":"2018-06-07T18:20:14Z","html_url":"https://github.com/Azure/azure-powershell/pull/6276#discussion_r193842100","pull_request_url":"https://api.github.com/repos/Azure/azure-powershell/pulls/6276","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-powershell/pulls/comments/193842100"},"html":{"href":"https://github.com/Azure/azure-powershell/pull/6276#discussion_r193842100"},"pull_request":{"href":"https://api.github.com/repos/Azure/azure-powershell/pulls/6276"}},"in_reply_to_id":193202762},"pull_request":{"url":"https://api.github.com/repos/Azure/azure-powershell/pulls/6276","id":189820638,"node_id":"MDExOlB1bGxSZXF1ZXN0MTg5ODIwNjM4","html_url":"https://github.com/Azure/azure-powershell/pull/6276","diff_url":"https://github.com/Azure/azure-powershell/pull/6276.diff","patch_url":"https://github.com/Azure/azure-powershell/pull/6276.patch","issue_url":"https://api.github.com/repos/Azure/azure-powershell/issues/6276","number":6276,"state":"open","locked":false,"title":"Consumption: introduce new cmdlets to CRUD budget, Get price sheet, marketplace, reservation summary/detail","user":{"login":"bgsky","id":12025904,"node_id":"MDQ6VXNlcjEyMDI1OTA0","avatar_url":"https://avatars3.githubusercontent.com/u/12025904?v=4","gravatar_id":"","url":"https://api.github.com/users/bgsky","html_url":"https://github.com/bgsky","followers_url":"https://api.github.com/users/bgsky/followers","following_url":"https://api.github.com/users/bgsky/following{/other_user}","gists_url":"https://api.github.com/users/bgsky/gists{/gist_id}","starred_url":"https://api.github.com/users/bgsky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bgsky/subscriptions","organizations_url":"https://api.github.com/users/bgsky/orgs","repos_url":"https://api.github.com/users/bgsky/repos","events_url":"https://api.github.com/users/bgsky/events{/privacy}","received_events_url":"https://api.github.com/users/bgsky/received_events","type":"User","site_admin":false},"body":"<!-- DO NOT DELETE THIS TEMPLATE -->\r\n\r\n## Description\r\n\r\nIntroduce 4 new cmdlets to CRUD budget. Budget can be managed by the user to help monitor their cost or usage.\r\nIntroduce 4 new cmdlets to get price sheet, marketplace, reservation summary and reservation detail\r\n\r\n## Checklist\r\n\r\n- [X ] I have read the [_Submitting Changes_](https://github.com/Azure/azure-powershell/blob/preview/CONTRIBUTING.md#submitting-changes) section of [`CONTRIBUTING.md`](https://github.com/Azure/azure-powershell/blob/preview/CONTRIBUTING.md)\r\n- [X ] The title of the PR is clear and informative\r\n- [X ] The appropriate [change log has been updated](https://github.com/Azure/azure-powershell/blob/preview/CONTRIBUTING.md#updating-the-change-log)\r\n- [X ] The PR does not introduce [breaking changes](https://github.com/Azure/azure-powershell/blob/preview/documentation/breaking-changes/breaking-changes-definition.md)\r\n- [X ] If applicable, the changes made in the PR have proper test coverage\r\n- [X ] For public API changes to cmdlets:\r\n - [X ] the changes have gone through a [cmdlet design review](https://github.com/Azure/azure-powershell-cmdlet-review-pr)\r\n - [X ] the cmdlet markdown files were [generated using the `platyPS` module](https://github.com/Azure/azure-powershell/blob/preview/documentation/development-docs/help-generation.md)\r\n","created_at":"2018-05-22T23:38:00Z","updated_at":"2018-06-07T18:20:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6eaa6b7beccdc07b523d44c2e8b3374d3a3e4a85","assignee":{"login":"maddieclayton","id":8137559,"node_id":"MDQ6VXNlcjgxMzc1NTk=","avatar_url":"https://avatars1.githubusercontent.com/u/8137559?v=4","gravatar_id":"","url":"https://api.github.com/users/maddieclayton","html_url":"https://github.com/maddieclayton","followers_url":"https://api.github.com/users/maddieclayton/followers","following_url":"https://api.github.com/users/maddieclayton/following{/other_user}","gists_url":"https://api.github.com/users/maddieclayton/gists{/gist_id}","starred_url":"https://api.github.com/users/maddieclayton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maddieclayton/subscriptions","organizations_url":"https://api.github.com/users/maddieclayton/orgs","repos_url":"https://api.github.com/users/maddieclayton/repos","events_url":"https://api.github.com/users/maddieclayton/events{/privacy}","received_events_url":"https://api.github.com/users/maddieclayton/received_events","type":"User","site_admin":false},"assignees":[{"login":"maddieclayton","id":8137559,"node_id":"MDQ6VXNlcjgxMzc1NTk=","avatar_url":"https://avatars1.githubusercontent.com/u/8137559?v=4","gravatar_id":"","url":"https://api.github.com/users/maddieclayton","html_url":"https://github.com/maddieclayton","followers_url":"https://api.github.com/users/maddieclayton/followers","following_url":"https://api.github.com/users/maddieclayton/following{/other_user}","gists_url":"https://api.github.com/users/maddieclayton/gists{/gist_id}","starred_url":"https://api.github.com/users/maddieclayton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maddieclayton/subscriptions","organizations_url":"https://api.github.com/users/maddieclayton/orgs","repos_url":"https://api.github.com/users/maddieclayton/repos","events_url":"https://api.github.com/users/maddieclayton/events{/privacy}","received_events_url":"https://api.github.com/users/maddieclayton/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":723106857,"node_id":"MDU6TGFiZWw3MjMxMDY4NTc=","url":"https://api.github.com/repos/Azure/azure-powershell/labels/Cmdlet%20Review%20Complete","name":"Cmdlet Review Complete","color":"90f433","default":false},{"id":556234674,"node_id":"MDU6TGFiZWw1NTYyMzQ2NzQ=","url":"https://api.github.com/repos/Azure/azure-powershell/labels/needs-review","name":"needs-review","color":"fbcfff","default":false}],"milestone":{"url":"https://api.github.com/repos/Azure/azure-powershell/milestones/47","html_url":"https://github.com/Azure/azure-powershell/milestone/47","labels_url":"https://api.github.com/repos/Azure/azure-powershell/milestones/47/labels","id":3312824,"node_id":"MDk6TWlsZXN0b25lMzMxMjgyNA==","number":47,"title":"2018-06-15","description":"Reviews Complete: 6/4; Code Complete 6/11; Release to CloudShell 6/15 Public Availability: 6/19","creator":{"login":"sphibbs","id":14059531,"node_id":"MDQ6VXNlcjE0MDU5NTMx","avatar_url":"https://avatars0.githubusercontent.com/u/14059531?v=4","gravatar_id":"","url":"https://api.github.com/users/sphibbs","html_url":"https://github.com/sphibbs","followers_url":"https://api.github.com/users/sphibbs/followers","following_url":"https://api.github.com/users/sphibbs/following{/other_user}","gists_url":"https://api.github.com/users/sphibbs/gists{/gist_id}","starred_url":"https://api.github.com/users/sphibbs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sphibbs/subscriptions","organizations_url":"https://api.github.com/users/sphibbs/orgs","repos_url":"https://api.github.com/users/sphibbs/repos","events_url":"https://api.github.com/users/sphibbs/events{/privacy}","received_events_url":"https://api.github.com/users/sphibbs/received_events","type":"User","site_admin":false},"open_issues":36,"closed_issues":3,"state":"open","created_at":"2018-05-01T22:36:59Z","updated_at":"2018-06-07T07:09:42Z","due_on":"2018-06-11T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/Azure/azure-powershell/pulls/6276/commits","review_comments_url":"https://api.github.com/repos/Azure/azure-powershell/pulls/6276/comments","review_comment_url":"https://api.github.com/repos/Azure/azure-powershell/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/azure-powershell/issues/6276/comments","statuses_url":"https://api.github.com/repos/Azure/azure-powershell/statuses/fe8a19f88479dd979cbbc728b5cf8f6653507f9d","head":{"label":"bgsky:preview","ref":"preview","sha":"fe8a19f88479dd979cbbc728b5cf8f6653507f9d","user":{"login":"bgsky","id":12025904,"node_id":"MDQ6VXNlcjEyMDI1OTA0","avatar_url":"https://avatars3.githubusercontent.com/u/12025904?v=4","gravatar_id":"","url":"https://api.github.com/users/bgsky","html_url":"https://github.com/bgsky","followers_url":"https://api.github.com/users/bgsky/followers","following_url":"https://api.github.com/users/bgsky/following{/other_user}","gists_url":"https://api.github.com/users/bgsky/gists{/gist_id}","starred_url":"https://api.github.com/users/bgsky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bgsky/subscriptions","organizations_url":"https://api.github.com/users/bgsky/orgs","repos_url":"https://api.github.com/users/bgsky/repos","events_url":"https://api.github.com/users/bgsky/events{/privacy}","received_events_url":"https://api.github.com/users/bgsky/received_events","type":"User","site_admin":false},"repo":{"id":129820039,"node_id":"MDEwOlJlcG9zaXRvcnkxMjk4MjAwMzk=","name":"azure-powershell","full_name":"bgsky/azure-powershell","owner":{"login":"bgsky","id":12025904,"node_id":"MDQ6VXNlcjEyMDI1OTA0","avatar_url":"https://avatars3.githubusercontent.com/u/12025904?v=4","gravatar_id":"","url":"https://api.github.com/users/bgsky","html_url":"https://github.com/bgsky","followers_url":"https://api.github.com/users/bgsky/followers","following_url":"https://api.github.com/users/bgsky/following{/other_user}","gists_url":"https://api.github.com/users/bgsky/gists{/gist_id}","starred_url":"https://api.github.com/users/bgsky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bgsky/subscriptions","organizations_url":"https://api.github.com/users/bgsky/orgs","repos_url":"https://api.github.com/users/bgsky/repos","events_url":"https://api.github.com/users/bgsky/events{/privacy}","received_events_url":"https://api.github.com/users/bgsky/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bgsky/azure-powershell","description":"Microsoft Azure PowerShell","fork":true,"url":"https://api.github.com/repos/bgsky/azure-powershell","forks_url":"https://api.github.com/repos/bgsky/azure-powershell/forks","keys_url":"https://api.github.com/repos/bgsky/azure-powershell/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bgsky/azure-powershell/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bgsky/azure-powershell/teams","hooks_url":"https://api.github.com/repos/bgsky/azure-powershell/hooks","issue_events_url":"https://api.github.com/repos/bgsky/azure-powershell/issues/events{/number}","events_url":"https://api.github.com/repos/bgsky/azure-powershell/events","assignees_url":"https://api.github.com/repos/bgsky/azure-powershell/assignees{/user}","branches_url":"https://api.github.com/repos/bgsky/azure-powershell/branches{/branch}","tags_url":"https://api.github.com/repos/bgsky/azure-powershell/tags","blobs_url":"https://api.github.com/repos/bgsky/azure-powershell/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bgsky/azure-powershell/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bgsky/azure-powershell/git/refs{/sha}","trees_url":"https://api.github.com/repos/bgsky/azure-powershell/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bgsky/azure-powershell/statuses/{sha}","languages_url":"https://api.github.com/repos/bgsky/azure-powershell/languages","stargazers_url":"https://api.github.com/repos/bgsky/azure-powershell/stargazers","contributors_url":"https://api.github.com/repos/bgsky/azure-powershell/contributors","subscribers_url":"https://api.github.com/repos/bgsky/azure-powershell/subscribers","subscription_url":"https://api.github.com/repos/bgsky/azure-powershell/subscription","commits_url":"https://api.github.com/repos/bgsky/azure-powershell/commits{/sha}","git_commits_url":"https://api.github.com/repos/bgsky/azure-powershell/git/commits{/sha}","comments_url":"https://api.github.com/repos/bgsky/azure-powershell/comments{/number}","issue_comment_url":"https://api.github.com/repos/bgsky/azure-powershell/issues/comments{/number}","contents_url":"https://api.github.com/repos/bgsky/azure-powershell/contents/{+path}","compare_url":"https://api.github.com/repos/bgsky/azure-powershell/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bgsky/azure-powershell/merges","archive_url":"https://api.github.com/repos/bgsky/azure-powershell/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bgsky/azure-powershell/downloads","issues_url":"https://api.github.com/repos/bgsky/azure-powershell/issues{/number}","pulls_url":"https://api.github.com/repos/bgsky/azure-powershell/pulls{/number}","milestones_url":"https://api.github.com/repos/bgsky/azure-powershell/milestones{/number}","notifications_url":"https://api.github.com/repos/bgsky/azure-powershell/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bgsky/azure-powershell/labels{/name}","releases_url":"https://api.github.com/repos/bgsky/azure-powershell/releases{/id}","deployments_url":"https://api.github.com/repos/bgsky/azure-powershell/deployments","created_at":"2018-04-16T23:51:38Z","updated_at":"2018-06-07T05:45:08Z","pushed_at":"2018-06-07T05:45:04Z","git_url":"git://github.com/bgsky/azure-powershell.git","ssh_url":"[email protected]:bgsky/azure-powershell.git","clone_url":"https://github.com/bgsky/azure-powershell.git","svn_url":"https://github.com/bgsky/azure-powershell","homepage":null,"size":416823,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"preview"}},"base":{"label":"Azure:preview","ref":"preview","sha":"fc10098cd42a01b8565c690f4ea00c487fcb369e","user":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":23891194,"node_id":"MDEwOlJlcG9zaXRvcnkyMzg5MTE5NA==","name":"azure-powershell","full_name":"Azure/azure-powershell","owner":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Azure/azure-powershell","description":"Microsoft Azure PowerShell","fork":false,"url":"https://api.github.com/repos/Azure/azure-powershell","forks_url":"https://api.github.com/repos/Azure/azure-powershell/forks","keys_url":"https://api.github.com/repos/Azure/azure-powershell/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/azure-powershell/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/azure-powershell/teams","hooks_url":"https://api.github.com/repos/Azure/azure-powershell/hooks","issue_events_url":"https://api.github.com/repos/Azure/azure-powershell/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/azure-powershell/events","assignees_url":"https://api.github.com/repos/Azure/azure-powershell/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/azure-powershell/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/azure-powershell/tags","blobs_url":"https://api.github.com/repos/Azure/azure-powershell/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/azure-powershell/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/azure-powershell/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/azure-powershell/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/azure-powershell/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/azure-powershell/languages","stargazers_url":"https://api.github.com/repos/Azure/azure-powershell/stargazers","contributors_url":"https://api.github.com/repos/Azure/azure-powershell/contributors","subscribers_url":"https://api.github.com/repos/Azure/azure-powershell/subscribers","subscription_url":"https://api.github.com/repos/Azure/azure-powershell/subscription","commits_url":"https://api.github.com/repos/Azure/azure-powershell/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/azure-powershell/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/azure-powershell/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/azure-powershell/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/azure-powershell/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/azure-powershell/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/azure-powershell/merges","archive_url":"https://api.github.com/repos/Azure/azure-powershell/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/azure-powershell/downloads","issues_url":"https://api.github.com/repos/Azure/azure-powershell/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/azure-powershell/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/azure-powershell/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/azure-powershell/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/azure-powershell/labels{/name}","releases_url":"https://api.github.com/repos/Azure/azure-powershell/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/azure-powershell/deployments","created_at":"2014-09-10T20:35:18Z","updated_at":"2018-06-07T17:48:44Z","pushed_at":"2018-06-07T17:48:35Z","git_url":"git://github.com/Azure/azure-powershell.git","ssh_url":"[email protected]:Azure/azure-powershell.git","clone_url":"https://github.com/Azure/azure-powershell.git","svn_url":"https://github.com/Azure/azure-powershell","homepage":null,"size":424988,"stargazers_count":1025,"watchers_count":1025,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1082,"mirror_url":null,"archived":false,"open_issues_count":643,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1082,"open_issues":643,"watchers":1025,"default_branch":"preview"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-powershell/pulls/6276"},"html":{"href":"https://github.com/Azure/azure-powershell/pull/6276"},"issue":{"href":"https://api.github.com/repos/Azure/azure-powershell/issues/6276"},"comments":{"href":"https://api.github.com/repos/Azure/azure-powershell/issues/6276/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/azure-powershell/pulls/6276/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/azure-powershell/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/azure-powershell/pulls/6276/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/azure-powershell/statuses/fe8a19f88479dd979cbbc728b5cf8f6653507f9d"}},"author_association":"NONE"}} | {
"id": 23891194,
"name": "Azure/azure-powershell",
"url": "https://api.github.com/repos/Azure/azure-powershell"
} | {
"id": 8137559,
"login": "maddieclayton",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/8137559?",
"url": "https://api.github.com/users/maddieclayton"
} | {
"id": 6844498,
"login": "Azure",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6844498?",
"url": "https://api.github.com/orgs/Azure"
} | 2018-06-07T18:13:23 | 7792590285 | {"actor":{"display_login":"maddieclayton"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/Azure/azure-rest-api-specs/pulls/comments/195938204","pull_request_review_id":129398030,"id":195938204,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NTkzODIwNA==","diff_hunk":"@@ -7,7 +7,7 @@ Please also specify `--node-sdks-folder=<path to root folder of your azure-sdk-f\n nodejs:","path":"specification/containerregistry/resource-manager/readme.nodejs.md","position":1,"original_position":1,"commit_id":"94aaf65edfd82b449c0d7e8128fcfedfe6870849","original_commit_id":"94aaf65edfd82b449c0d7e8128fcfedfe6870849","user":{"login":"northtyphoon","id":2686301,"node_id":"MDQ6VXNlcjI2ODYzMDE=","avatar_url":"https://avatars3.githubusercontent.com/u/2686301?v=4","gravatar_id":"","url":"https://api.github.com/users/northtyphoon","html_url":"https://github.com/northtyphoon","followers_url":"https://api.github.com/users/northtyphoon/followers","following_url":"https://api.github.com/users/northtyphoon/following{/other_user}","gists_url":"https://api.github.com/users/northtyphoon/gists{/gist_id}","starred_url":"https://api.github.com/users/northtyphoon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/northtyphoon/subscriptions","organizations_url":"https://api.github.com/users/northtyphoon/orgs","repos_url":"https://api.github.com/users/northtyphoon/repos","events_url":"https://api.github.com/users/northtyphoon/events{/privacy}","received_events_url":"https://api.github.com/users/northtyphoon/received_events","type":"User","site_admin":false},"body":"You may consider the following solution without updating the default so that you can limit the chagne to nodejs. \r\n\r\n``` yaml $(nodejs)\r\nnodejs:\r\n azure-arm: true\r\n package-name: azure-arm-containerregistry\r\n package-version: 2.3.0\r\n output-folder: $(node-sdks-folder)/lib/services/containerRegistryManagement\r\n generate-license-txt: true\r\n generate-package-json: true\r\n generate-readme-md: true\r\n\r\ninput-file:\r\n- Microsoft.ContainerRegistry/stable/2017-10-01/containerregistry.json\r\n- Microsoft.ContainerRegistry/preview/2018-02-01-preview/containerregistry_build.json \r\n```","created_at":"2018-06-17T19:05:22Z","updated_at":"2018-06-17T19:05:23Z","html_url":"https://github.com/Azure/azure-rest-api-specs/pull/3251#discussion_r195938204","pull_request_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/pulls/3251","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-rest-api-specs/pulls/comments/195938204"},"html":{"href":"https://github.com/Azure/azure-rest-api-specs/pull/3251#discussion_r195938204"},"pull_request":{"href":"https://api.github.com/repos/Azure/azure-rest-api-specs/pulls/3251"}}},"pull_request":{"url":"https://api.github.com/repos/Azure/azure-rest-api-specs/pulls/3251","id":195265056,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1MjY1MDU2","html_url":"https://github.com/Azure/azure-rest-api-specs/pull/3251","diff_url":"https://github.com/Azure/azure-rest-api-specs/pull/3251.diff","patch_url":"https://github.com/Azure/azure-rest-api-specs/pull/3251.patch","issue_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/issues/3251","number":3251,"state":"open","locked":false,"title":"[ACR] Update default tag to 2018-02-preview","user":{"login":"djyou","id":3630974,"node_id":"MDQ6VXNlcjM2MzA5NzQ=","avatar_url":"https://avatars3.githubusercontent.com/u/3630974?v=4","gravatar_id":"","url":"https://api.github.com/users/djyou","html_url":"https://github.com/djyou","followers_url":"https://api.github.com/users/djyou/followers","following_url":"https://api.github.com/users/djyou/following{/other_user}","gists_url":"https://api.github.com/users/djyou/gists{/gist_id}","starred_url":"https://api.github.com/users/djyou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/djyou/subscriptions","organizations_url":"https://api.github.com/users/djyou/orgs","repos_url":"https://api.github.com/users/djyou/repos","events_url":"https://api.github.com/users/djyou/events{/privacy}","received_events_url":"https://api.github.com/users/djyou/received_events","type":"User","site_admin":false},"body":"This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.\r\n\r\n### PR information\r\n- [x] The title of the PR is clear and informative.\r\n- [x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, [see this page](https://github.com/Azure/azure-powershell/blob/master/documentation/development-docs/cleaning-up-commits.md).\r\n- [x] Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.\r\n- [x] If applicable, the PR references the bug/issue that it fixes.\r\n- [x] Swagger files are correctly named (e.g. the `api-version` in the path should match the `api-version` in the spec).\r\n\r\n### Quality of Swagger\r\n- [x] I have read the [contribution guidelines](https://github.com/Azure/azure-rest-api-specs/blob/master/.github/CONTRIBUTING.md).\r\n- [x] My spec meets the review criteria:\r\n - [x] The spec conforms to the [Swagger 2.0 specification](https://github.com/OAI/OpenAPI-Specification/blob/master/versions/2.0.md).\r\n - [x] The spec follows the guidelines described in the [Swagger checklist](https://github.com/Azure/azure-rest-api-specs/blob/master/documentation/swagger-checklist.md) document.\r\n - [x] [Validation tools](https://github.com/Azure/azure-rest-api-specs/blob/master/documentation/swagger-checklist.md#validation-tools-for-swagger-checklist) were run on swagger spec(s) and have all been fixed in this PR.\r\n","created_at":"2018-06-15T19:36:29Z","updated_at":"2018-06-17T19:05:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"133eb14c2f1424efe00cfa1d57978b372e44de13","assignee":{"login":"annatisch","id":8689453,"node_id":"MDQ6VXNlcjg2ODk0NTM=","avatar_url":"https://avatars2.githubusercontent.com/u/8689453?v=4","gravatar_id":"","url":"https://api.github.com/users/annatisch","html_url":"https://github.com/annatisch","followers_url":"https://api.github.com/users/annatisch/followers","following_url":"https://api.github.com/users/annatisch/following{/other_user}","gists_url":"https://api.github.com/users/annatisch/gists{/gist_id}","starred_url":"https://api.github.com/users/annatisch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/annatisch/subscriptions","organizations_url":"https://api.github.com/users/annatisch/orgs","repos_url":"https://api.github.com/users/annatisch/repos","events_url":"https://api.github.com/users/annatisch/events{/privacy}","received_events_url":"https://api.github.com/users/annatisch/received_events","type":"User","site_admin":false},"assignees":[{"login":"annatisch","id":8689453,"node_id":"MDQ6VXNlcjg2ODk0NTM=","avatar_url":"https://avatars2.githubusercontent.com/u/8689453?v=4","gravatar_id":"","url":"https://api.github.com/users/annatisch","html_url":"https://github.com/annatisch","followers_url":"https://api.github.com/users/annatisch/followers","following_url":"https://api.github.com/users/annatisch/following{/other_user}","gists_url":"https://api.github.com/users/annatisch/gists{/gist_id}","starred_url":"https://api.github.com/users/annatisch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/annatisch/subscriptions","organizations_url":"https://api.github.com/users/annatisch/orgs","repos_url":"https://api.github.com/users/annatisch/repos","events_url":"https://api.github.com/users/annatisch/events{/privacy}","received_events_url":"https://api.github.com/users/annatisch/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"annatisch","id":8689453,"node_id":"MDQ6VXNlcjg2ODk0NTM=","avatar_url":"https://avatars2.githubusercontent.com/u/8689453?v=4","gravatar_id":"","url":"https://api.github.com/users/annatisch","html_url":"https://github.com/annatisch","followers_url":"https://api.github.com/users/annatisch/followers","following_url":"https://api.github.com/users/annatisch/following{/other_user}","gists_url":"https://api.github.com/users/annatisch/gists{/gist_id}","starred_url":"https://api.github.com/users/annatisch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/annatisch/subscriptions","organizations_url":"https://api.github.com/users/annatisch/orgs","repos_url":"https://api.github.com/users/annatisch/repos","events_url":"https://api.github.com/users/annatisch/events{/privacy}","received_events_url":"https://api.github.com/users/annatisch/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/pulls/3251/commits","review_comments_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/pulls/3251/comments","review_comment_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/issues/3251/comments","statuses_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/statuses/94aaf65edfd82b449c0d7e8128fcfedfe6870849","head":{"label":"AzureCR:doyou/nodejs","ref":"doyou/nodejs","sha":"94aaf65edfd82b449c0d7e8128fcfedfe6870849","user":{"login":"AzureCR","id":8304256,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgzMDQyNTY=","avatar_url":"https://avatars1.githubusercontent.com/u/8304256?v=4","gravatar_id":"","url":"https://api.github.com/users/AzureCR","html_url":"https://github.com/AzureCR","followers_url":"https://api.github.com/users/AzureCR/followers","following_url":"https://api.github.com/users/AzureCR/following{/other_user}","gists_url":"https://api.github.com/users/AzureCR/gists{/gist_id}","starred_url":"https://api.github.com/users/AzureCR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AzureCR/subscriptions","organizations_url":"https://api.github.com/users/AzureCR/orgs","repos_url":"https://api.github.com/users/AzureCR/repos","events_url":"https://api.github.com/users/AzureCR/events{/privacy}","received_events_url":"https://api.github.com/users/AzureCR/received_events","type":"Organization","site_admin":false},"repo":{"id":64787178,"node_id":"MDEwOlJlcG9zaXRvcnk2NDc4NzE3OA==","name":"azure-rest-api-specs","full_name":"AzureCR/azure-rest-api-specs","owner":{"login":"AzureCR","id":8304256,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgzMDQyNTY=","avatar_url":"https://avatars1.githubusercontent.com/u/8304256?v=4","gravatar_id":"","url":"https://api.github.com/users/AzureCR","html_url":"https://github.com/AzureCR","followers_url":"https://api.github.com/users/AzureCR/followers","following_url":"https://api.github.com/users/AzureCR/following{/other_user}","gists_url":"https://api.github.com/users/AzureCR/gists{/gist_id}","starred_url":"https://api.github.com/users/AzureCR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AzureCR/subscriptions","organizations_url":"https://api.github.com/users/AzureCR/orgs","repos_url":"https://api.github.com/users/AzureCR/repos","events_url":"https://api.github.com/users/AzureCR/events{/privacy}","received_events_url":"https://api.github.com/users/AzureCR/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/AzureCR/azure-rest-api-specs","description":"The source for REST API specifications for Microsoft Azure.","fork":true,"url":"https://api.github.com/repos/AzureCR/azure-rest-api-specs","forks_url":"https://api.github.com/repos/AzureCR/azure-rest-api-specs/forks","keys_url":"https://api.github.com/repos/AzureCR/azure-rest-api-specs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AzureCR/azure-rest-api-specs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AzureCR/azure-rest-api-specs/teams","hooks_url":"https://api.github.com/repos/AzureCR/azure-rest-api-specs/hooks","issue_events_url":"https://api.github.com/repos/AzureCR/azure-rest-api-specs/issues/events{/number}","events_url":"https://api.github.com/repos/AzureCR/azure-rest-api-specs/events","assignees_url":"https://api.github.com/repos/AzureCR/azure-rest-api-specs/assignees{/user}","branches_url":"https://api.github.com/repos/AzureCR/azure-rest-api-specs/branches{/branch}","tags_url":"https://api.github.com/repos/AzureCR/azure-rest-api-specs/tags","blobs_url":"https://api.github.com/repos/AzureCR/azure-rest-api-specs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AzureCR/azure-rest-api-specs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AzureCR/azure-rest-api-specs/git/refs{/sha}","trees_url":"https://api.github.com/repos/AzureCR/azure-rest-api-specs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AzureCR/azure-rest-api-specs/statuses/{sha}","languages_url":"https://api.github.com/repos/AzureCR/azure-rest-api-specs/languages","stargazers_url":"https://api.github.com/repos/AzureCR/azure-rest-api-specs/stargazers","contributors_url":"https://api.github.com/repos/AzureCR/azure-rest-api-specs/contributors","subscribers_url":"https://api.github.com/repos/AzureCR/azure-rest-api-specs/subscribers","subscription_url":"https://api.github.com/repos/AzureCR/azure-rest-api-specs/subscription","commits_url":"https://api.github.com/repos/AzureCR/azure-rest-api-specs/commits{/sha}","git_commits_url":"https://api.github.com/repos/AzureCR/azure-rest-api-specs/git/commits{/sha}","comments_url":"https://api.github.com/repos/AzureCR/azure-rest-api-specs/comments{/number}","issue_comment_url":"https://api.github.com/repos/AzureCR/azure-rest-api-specs/issues/comments{/number}","contents_url":"https://api.github.com/repos/AzureCR/azure-rest-api-specs/contents/{+path}","compare_url":"https://api.github.com/repos/AzureCR/azure-rest-api-specs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AzureCR/azure-rest-api-specs/merges","archive_url":"https://api.github.com/repos/AzureCR/azure-rest-api-specs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AzureCR/azure-rest-api-specs/downloads","issues_url":"https://api.github.com/repos/AzureCR/azure-rest-api-specs/issues{/number}","pulls_url":"https://api.github.com/repos/AzureCR/azure-rest-api-specs/pulls{/number}","milestones_url":"https://api.github.com/repos/AzureCR/azure-rest-api-specs/milestones{/number}","notifications_url":"https://api.github.com/repos/AzureCR/azure-rest-api-specs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AzureCR/azure-rest-api-specs/labels{/name}","releases_url":"https://api.github.com/repos/AzureCR/azure-rest-api-specs/releases{/id}","deployments_url":"https://api.github.com/repos/AzureCR/azure-rest-api-specs/deployments","created_at":"2016-08-02T19:41:29Z","updated_at":"2018-06-15T19:23:09Z","pushed_at":"2018-06-15T19:36:12Z","git_url":"git://github.com/AzureCR/azure-rest-api-specs.git","ssh_url":"[email protected]:AzureCR/azure-rest-api-specs.git","clone_url":"https://github.com/AzureCR/azure-rest-api-specs.git","svn_url":"https://github.com/AzureCR/azure-rest-api-specs","homepage":"","size":20411,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"Azure:master","ref":"master","sha":"825771db8ef8cc734469760b86fc0190c1f0ef3f","user":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":39093389,"node_id":"MDEwOlJlcG9zaXRvcnkzOTA5MzM4OQ==","name":"azure-rest-api-specs","full_name":"Azure/azure-rest-api-specs","owner":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Azure/azure-rest-api-specs","description":"The source for REST API specifications for Microsoft Azure.","fork":false,"url":"https://api.github.com/repos/Azure/azure-rest-api-specs","forks_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/forks","keys_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/teams","hooks_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/hooks","issue_events_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/events","assignees_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/tags","blobs_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/languages","stargazers_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/stargazers","contributors_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/contributors","subscribers_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/subscribers","subscription_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/subscription","commits_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/merges","archive_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/downloads","issues_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/labels{/name}","releases_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/deployments","created_at":"2015-07-14T18:37:13Z","updated_at":"2018-06-15T22:41:41Z","pushed_at":"2018-06-17T07:10:20Z","git_url":"git://github.com/Azure/azure-rest-api-specs.git","ssh_url":"[email protected]:Azure/azure-rest-api-specs.git","clone_url":"https://github.com/Azure/azure-rest-api-specs.git","svn_url":"https://github.com/Azure/azure-rest-api-specs","homepage":"","size":20775,"stargazers_count":304,"watchers_count":304,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":796,"mirror_url":null,"archived":false,"open_issues_count":300,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":796,"open_issues":300,"watchers":304,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-rest-api-specs/pulls/3251"},"html":{"href":"https://github.com/Azure/azure-rest-api-specs/pull/3251"},"issue":{"href":"https://api.github.com/repos/Azure/azure-rest-api-specs/issues/3251"},"comments":{"href":"https://api.github.com/repos/Azure/azure-rest-api-specs/issues/3251/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/azure-rest-api-specs/pulls/3251/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/azure-rest-api-specs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/azure-rest-api-specs/pulls/3251/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/azure-rest-api-specs/statuses/94aaf65edfd82b449c0d7e8128fcfedfe6870849"}},"author_association":"MEMBER"}} | {
"id": 39093389,
"name": "Azure/azure-rest-api-specs",
"url": "https://api.github.com/repos/Azure/azure-rest-api-specs"
} | {
"id": 2686301,
"login": "northtyphoon",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2686301?",
"url": "https://api.github.com/users/northtyphoon"
} | {
"id": 6844498,
"login": "Azure",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6844498?",
"url": "https://api.github.com/orgs/Azure"
} | 2018-06-17T19:05:22 | 7836406100 | {"actor":{"display_login":"northtyphoon"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/Azure/azure-quickstart-templates/pulls/comments/199068510","pull_request_review_id":133115456,"id":199068510,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5OTA2ODUxMA==","diff_hunk":"@@ -0,0 +1,142 @@\n+{\n+ \"$schema\": \"https://schema.management.azure.com/schemas/2015-01-01/deploymentTemplate.json#\",\n+ \"contentVersion\": \"1.0.0.0\",\n+ \"parameters\": {\n+ \"webappName\": {\n+ \"type\": \"string\",\n+ \"defaultValue\": \"GEN-UNIQUE\",\n+ \"minLength\": 1,\n+ \"metadata\": {\n+ \"description\": \"The name of the web application\"\n+ }\n+ },\n+ \"appInsightsName\": {\n+ \"type\": \"string\",\n+ \"minLength\": 1,\n+ \"defaultValue\": \"GEN-UNIQUE\",\n+ \"metadata\": {\n+ \"description\": \"The name of the application insights instance\"\n+ }\n+ },\n+ \"location\": {\n+ \"type\": \"string\",\n+ \"minLength\": 1,\n+ \"defaultValue\": \"[resourceGroup().location]\",\n+ \"metadata\": {\n+ \"description\": \"The location for the resources\"\n+ }\n+ },\n+ \"hostingPlanName\": { \n+ \"type\": \"string\",\n+ \"minLength\": 1,\n+ \"defaultValue\": \"GEN-UNIQUE\",\n+ \"metadata\": {\n+ \"description\": \"The name of the hosting plan for the web application\"\n+ }\n+ },\n+ \"skuName\": {\n+ \"type\": \"string\",\n+ \"defaultValue\": \"F1\",\n+ \"metadata\": {\n+ \"description\": \"The hosting plan's pricing tier and capacity. Check details at https://azure.microsoft.com/en-us/pricing/details/app-service/\"\n+ }\n+ },\n+ \"owner\": {\n+ \"type\": \"string\",\n+ \"defaultValue\": \"GEN-UNIQUE\",","path":"101-webapp-including-insights/azuredeploy.json","position":null,"original_position":46,"commit_id":"2043504f24ee153d76dd2598f12861c0238b5a12","original_commit_id":"7a218a1908f47f18a2f38c3eaa3a0a0044eaae27","user":{"login":"maikvandergaag","id":9531411,"node_id":"MDQ6VXNlcjk1MzE0MTE=","avatar_url":"https://avatars3.githubusercontent.com/u/9531411?v=4","gravatar_id":"","url":"https://api.github.com/users/maikvandergaag","html_url":"https://github.com/maikvandergaag","followers_url":"https://api.github.com/users/maikvandergaag/followers","following_url":"https://api.github.com/users/maikvandergaag/following{/other_user}","gists_url":"https://api.github.com/users/maikvandergaag/gists{/gist_id}","starred_url":"https://api.github.com/users/maikvandergaag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maikvandergaag/subscriptions","organizations_url":"https://api.github.com/users/maikvandergaag/orgs","repos_url":"https://api.github.com/users/maikvandergaag/repos","events_url":"https://api.github.com/users/maikvandergaag/events{/privacy}","received_events_url":"https://api.github.com/users/maikvandergaag/received_events","type":"User","site_admin":false},"body":"done","created_at":"2018-06-29T06:54:56Z","updated_at":"2018-06-29T06:54:57Z","html_url":"https://github.com/Azure/azure-quickstart-templates/pull/4615#discussion_r199068510","pull_request_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/pulls/4615","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-quickstart-templates/pulls/comments/199068510"},"html":{"href":"https://github.com/Azure/azure-quickstart-templates/pull/4615#discussion_r199068510"},"pull_request":{"href":"https://api.github.com/repos/Azure/azure-quickstart-templates/pulls/4615"}},"in_reply_to_id":199015671},"pull_request":{"url":"https://api.github.com/repos/Azure/azure-quickstart-templates/pulls/4615","id":186333278,"node_id":"MDExOlB1bGxSZXF1ZXN0MTg2MzMzMjc4","html_url":"https://github.com/Azure/azure-quickstart-templates/pull/4615","diff_url":"https://github.com/Azure/azure-quickstart-templates/pull/4615.diff","patch_url":"https://github.com/Azure/azure-quickstart-templates/pull/4615.patch","issue_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/issues/4615","number":4615,"state":"open","locked":false,"title":"added template","user":{"login":"maikvandergaag","id":9531411,"node_id":"MDQ6VXNlcjk1MzE0MTE=","avatar_url":"https://avatars3.githubusercontent.com/u/9531411?v=4","gravatar_id":"","url":"https://api.github.com/users/maikvandergaag","html_url":"https://github.com/maikvandergaag","followers_url":"https://api.github.com/users/maikvandergaag/followers","following_url":"https://api.github.com/users/maikvandergaag/following{/other_user}","gists_url":"https://api.github.com/users/maikvandergaag/gists{/gist_id}","starred_url":"https://api.github.com/users/maikvandergaag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maikvandergaag/subscriptions","organizations_url":"https://api.github.com/users/maikvandergaag/orgs","repos_url":"https://api.github.com/users/maikvandergaag/repos","events_url":"https://api.github.com/users/maikvandergaag/events{/privacy}","received_events_url":"https://api.github.com/users/maikvandergaag/received_events","type":"User","site_admin":false},"body":"### Best Practice Checklist\r\nCheck these items before submitting a PR... See the Contribution Guide for the full detail: https://github.com/Azure/azure-quickstart-templates/blob/master/1-CONTRIBUTION-GUIDE/README.md \r\n\r\n1. uri's compatible with all clouds (Stack, China, Government)\r\n1. Staged artifacts use _artifactsLocation & _artifactsLocationSasToken\r\n1. Use resourceGroup().location for resource locations\r\n1. Folder names for artifacts (nestedtemplates, scripts, DSC)\r\n1. Use literal values for apiVersion (no variables)\r\n1. Parameter files (GEN-UNIQUE for value generation and no \"changemeplease\" values\r\n1. $schema and other uris use https\r\n1. Use uniqueString() whenever possible to generate names for resources. While this is not required, it's one of the most common failure points in a deployment. \r\n1. Update the metadata.json with the current date\r\n\r\nFor details: https://github.com/Azure/azure-quickstart-templates/blob/master/1-CONTRIBUTION-GUIDE/bp-checklist.md\r\n\r\n- [ ] - Please check this box once you've submitted the PR if you've read through the Contribution Guide and best practices checklist.\r\n\r\n### Changelog\r\n\r\n*\r\n*\r\n*\r\n\r\n","created_at":"2018-05-07T12:10:08Z","updated_at":"2018-06-29T06:54:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7ce6f24d4ffa8942f18c573ae4c9d949eeda91f7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/pulls/4615/commits","review_comments_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/pulls/4615/comments","review_comment_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/issues/4615/comments","statuses_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/statuses/2043504f24ee153d76dd2598f12861c0238b5a12","head":{"label":"maikvandergaag:webapp-incl-insights","ref":"webapp-incl-insights","sha":"2043504f24ee153d76dd2598f12861c0238b5a12","user":{"login":"maikvandergaag","id":9531411,"node_id":"MDQ6VXNlcjk1MzE0MTE=","avatar_url":"https://avatars3.githubusercontent.com/u/9531411?v=4","gravatar_id":"","url":"https://api.github.com/users/maikvandergaag","html_url":"https://github.com/maikvandergaag","followers_url":"https://api.github.com/users/maikvandergaag/followers","following_url":"https://api.github.com/users/maikvandergaag/following{/other_user}","gists_url":"https://api.github.com/users/maikvandergaag/gists{/gist_id}","starred_url":"https://api.github.com/users/maikvandergaag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maikvandergaag/subscriptions","organizations_url":"https://api.github.com/users/maikvandergaag/orgs","repos_url":"https://api.github.com/users/maikvandergaag/repos","events_url":"https://api.github.com/users/maikvandergaag/events{/privacy}","received_events_url":"https://api.github.com/users/maikvandergaag/received_events","type":"User","site_admin":false},"repo":{"id":128366756,"node_id":"MDEwOlJlcG9zaXRvcnkxMjgzNjY3NTY=","name":"azure-quickstart-templates","full_name":"maikvandergaag/azure-quickstart-templates","owner":{"login":"maikvandergaag","id":9531411,"node_id":"MDQ6VXNlcjk1MzE0MTE=","avatar_url":"https://avatars3.githubusercontent.com/u/9531411?v=4","gravatar_id":"","url":"https://api.github.com/users/maikvandergaag","html_url":"https://github.com/maikvandergaag","followers_url":"https://api.github.com/users/maikvandergaag/followers","following_url":"https://api.github.com/users/maikvandergaag/following{/other_user}","gists_url":"https://api.github.com/users/maikvandergaag/gists{/gist_id}","starred_url":"https://api.github.com/users/maikvandergaag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maikvandergaag/subscriptions","organizations_url":"https://api.github.com/users/maikvandergaag/orgs","repos_url":"https://api.github.com/users/maikvandergaag/repos","events_url":"https://api.github.com/users/maikvandergaag/events{/privacy}","received_events_url":"https://api.github.com/users/maikvandergaag/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/maikvandergaag/azure-quickstart-templates","description":"Azure Quickstart Templates","fork":true,"url":"https://api.github.com/repos/maikvandergaag/azure-quickstart-templates","forks_url":"https://api.github.com/repos/maikvandergaag/azure-quickstart-templates/forks","keys_url":"https://api.github.com/repos/maikvandergaag/azure-quickstart-templates/keys{/key_id}","collaborators_url":"https://api.github.com/repos/maikvandergaag/azure-quickstart-templates/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/maikvandergaag/azure-quickstart-templates/teams","hooks_url":"https://api.github.com/repos/maikvandergaag/azure-quickstart-templates/hooks","issue_events_url":"https://api.github.com/repos/maikvandergaag/azure-quickstart-templates/issues/events{/number}","events_url":"https://api.github.com/repos/maikvandergaag/azure-quickstart-templates/events","assignees_url":"https://api.github.com/repos/maikvandergaag/azure-quickstart-templates/assignees{/user}","branches_url":"https://api.github.com/repos/maikvandergaag/azure-quickstart-templates/branches{/branch}","tags_url":"https://api.github.com/repos/maikvandergaag/azure-quickstart-templates/tags","blobs_url":"https://api.github.com/repos/maikvandergaag/azure-quickstart-templates/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/maikvandergaag/azure-quickstart-templates/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/maikvandergaag/azure-quickstart-templates/git/refs{/sha}","trees_url":"https://api.github.com/repos/maikvandergaag/azure-quickstart-templates/git/trees{/sha}","statuses_url":"https://api.github.com/repos/maikvandergaag/azure-quickstart-templates/statuses/{sha}","languages_url":"https://api.github.com/repos/maikvandergaag/azure-quickstart-templates/languages","stargazers_url":"https://api.github.com/repos/maikvandergaag/azure-quickstart-templates/stargazers","contributors_url":"https://api.github.com/repos/maikvandergaag/azure-quickstart-templates/contributors","subscribers_url":"https://api.github.com/repos/maikvandergaag/azure-quickstart-templates/subscribers","subscription_url":"https://api.github.com/repos/maikvandergaag/azure-quickstart-templates/subscription","commits_url":"https://api.github.com/repos/maikvandergaag/azure-quickstart-templates/commits{/sha}","git_commits_url":"https://api.github.com/repos/maikvandergaag/azure-quickstart-templates/git/commits{/sha}","comments_url":"https://api.github.com/repos/maikvandergaag/azure-quickstart-templates/comments{/number}","issue_comment_url":"https://api.github.com/repos/maikvandergaag/azure-quickstart-templates/issues/comments{/number}","contents_url":"https://api.github.com/repos/maikvandergaag/azure-quickstart-templates/contents/{+path}","compare_url":"https://api.github.com/repos/maikvandergaag/azure-quickstart-templates/compare/{base}...{head}","merges_url":"https://api.github.com/repos/maikvandergaag/azure-quickstart-templates/merges","archive_url":"https://api.github.com/repos/maikvandergaag/azure-quickstart-templates/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/maikvandergaag/azure-quickstart-templates/downloads","issues_url":"https://api.github.com/repos/maikvandergaag/azure-quickstart-templates/issues{/number}","pulls_url":"https://api.github.com/repos/maikvandergaag/azure-quickstart-templates/pulls{/number}","milestones_url":"https://api.github.com/repos/maikvandergaag/azure-quickstart-templates/milestones{/number}","notifications_url":"https://api.github.com/repos/maikvandergaag/azure-quickstart-templates/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/maikvandergaag/azure-quickstart-templates/labels{/name}","releases_url":"https://api.github.com/repos/maikvandergaag/azure-quickstart-templates/releases{/id}","deployments_url":"https://api.github.com/repos/maikvandergaag/azure-quickstart-templates/deployments","created_at":"2018-04-06T08:01:46Z","updated_at":"2018-04-06T08:46:17Z","pushed_at":"2018-06-29T06:54:20Z","git_url":"git://github.com/maikvandergaag/azure-quickstart-templates.git","ssh_url":"[email protected]:maikvandergaag/azure-quickstart-templates.git","clone_url":"https://github.com/maikvandergaag/azure-quickstart-templates.git","svn_url":"https://github.com/maikvandergaag/azure-quickstart-templates","homepage":"https://azure.microsoft.com/en-us/documentation/templates","size":248320,"stargazers_count":0,"watchers_count":0,"language":"PowerShell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Azure:master","ref":"master","sha":"7077db05e213c75f6d6282ed750f1c6d3674d210","user":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":34407651,"node_id":"MDEwOlJlcG9zaXRvcnkzNDQwNzY1MQ==","name":"azure-quickstart-templates","full_name":"Azure/azure-quickstart-templates","owner":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Azure/azure-quickstart-templates","description":"Azure Quickstart Templates","fork":false,"url":"https://api.github.com/repos/Azure/azure-quickstart-templates","forks_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/forks","keys_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/teams","hooks_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/hooks","issue_events_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/events","assignees_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/tags","blobs_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/languages","stargazers_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/stargazers","contributors_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/contributors","subscribers_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/subscribers","subscription_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/subscription","commits_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/merges","archive_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/downloads","issues_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/labels{/name}","releases_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/deployments","created_at":"2015-04-22T18:19:03Z","updated_at":"2018-06-29T06:07:35Z","pushed_at":"2018-06-29T06:54:23Z","git_url":"git://github.com/Azure/azure-quickstart-templates.git","ssh_url":"[email protected]:Azure/azure-quickstart-templates.git","clone_url":"https://github.com/Azure/azure-quickstart-templates.git","svn_url":"https://github.com/Azure/azure-quickstart-templates","homepage":"https://azure.microsoft.com/en-us/documentation/templates","size":304966,"stargazers_count":3791,"watchers_count":3791,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5411,"mirror_url":null,"archived":false,"open_issues_count":470,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":5411,"open_issues":470,"watchers":3791,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-quickstart-templates/pulls/4615"},"html":{"href":"https://github.com/Azure/azure-quickstart-templates/pull/4615"},"issue":{"href":"https://api.github.com/repos/Azure/azure-quickstart-templates/issues/4615"},"comments":{"href":"https://api.github.com/repos/Azure/azure-quickstart-templates/issues/4615/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/azure-quickstart-templates/pulls/4615/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/azure-quickstart-templates/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/azure-quickstart-templates/pulls/4615/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/azure-quickstart-templates/statuses/2043504f24ee153d76dd2598f12861c0238b5a12"}},"author_association":"CONTRIBUTOR"}} | {
"id": 34407651,
"name": "Azure/azure-quickstart-templates",
"url": "https://api.github.com/repos/Azure/azure-quickstart-templates"
} | {
"id": 9531411,
"login": "maikvandergaag",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9531411?",
"url": "https://api.github.com/users/maikvandergaag"
} | {
"id": 6844498,
"login": "Azure",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6844498?",
"url": "https://api.github.com/orgs/Azure"
} | 2018-06-29T06:54:56 | 7896010542 | {"actor":{"display_login":"maikvandergaag"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/Azure/acs-engine/pulls/comments/182924614","pull_request_review_id":113824642,"id":182924614,"diff_hunk":"@@ -188,11 +186,13 @@ Write-AzureConfig()\n \"aadClientSecret\": \"$AADClientSecret\",\r\n \"resourceGroup\": \"$global:ResourceGroup\",\r\n \"location\": \"$Location\",\r\n+ \"vmType\": \"$global:VmType\",\r\n \"subnetName\": \"$global:SubnetName\",\r\n \"securityGroupName\": \"$global:SecurityGroupName\",\r\n \"vnetName\": \"$global:VNetName\",\r\n \"routeTableName\": \"$global:RouteTableName\",\r\n \"primaryAvailabilitySetName\": \"$global:PrimaryAvailabilitySetName\",\r\n+ \"primaryScaleSetName\": \"$global:PrimaryScaleSetName\",\r","path":"parts/k8s/kuberneteswindowssetup.ps1","position":45,"original_position":45,"commit_id":"a141b74a0a216718f42ad564742e9f024e9a7cf9","original_commit_id":"a141b74a0a216718f42ad564742e9f024e9a7cf9","user":{"login":"JiangtianLi","id":25217557,"avatar_url":"https://avatars2.githubusercontent.com/u/25217557?v=4","gravatar_id":"","url":"https://api.github.com/users/JiangtianLi","html_url":"https://github.com/JiangtianLi","followers_url":"https://api.github.com/users/JiangtianLi/followers","following_url":"https://api.github.com/users/JiangtianLi/following{/other_user}","gists_url":"https://api.github.com/users/JiangtianLi/gists{/gist_id}","starred_url":"https://api.github.com/users/JiangtianLi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JiangtianLi/subscriptions","organizations_url":"https://api.github.com/users/JiangtianLi/orgs","repos_url":"https://api.github.com/users/JiangtianLi/repos","events_url":"https://api.github.com/users/JiangtianLi/events{/privacy}","received_events_url":"https://api.github.com/users/JiangtianLi/received_events","type":"User","site_admin":false},"body":"where is primaryScaleSetName used?","created_at":"2018-04-20T01:11:53Z","updated_at":"2018-04-20T01:11:53Z","html_url":"https://github.com/Azure/acs-engine/pull/2620#discussion_r182924614","pull_request_url":"https://api.github.com/repos/Azure/acs-engine/pulls/2620","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Azure/acs-engine/pulls/comments/182924614"},"html":{"href":"https://github.com/Azure/acs-engine/pull/2620#discussion_r182924614"},"pull_request":{"href":"https://api.github.com/repos/Azure/acs-engine/pulls/2620"}}},"pull_request":{"url":"https://api.github.com/repos/Azure/acs-engine/pulls/2620","id":180038981,"html_url":"https://github.com/Azure/acs-engine/pull/2620","diff_url":"https://github.com/Azure/acs-engine/pull/2620.diff","patch_url":"https://github.com/Azure/acs-engine/pull/2620.patch","issue_url":"https://api.github.com/repos/Azure/acs-engine/issues/2620","number":2620,"state":"open","locked":false,"title":"VirtualMachineScaleSets support for Kubernetes","user":{"login":"sozercan","id":852750,"avatar_url":"https://avatars0.githubusercontent.com/u/852750?v=4","gravatar_id":"","url":"https://api.github.com/users/sozercan","html_url":"https://github.com/sozercan","followers_url":"https://api.github.com/users/sozercan/followers","following_url":"https://api.github.com/users/sozercan/following{/other_user}","gists_url":"https://api.github.com/users/sozercan/gists{/gist_id}","starred_url":"https://api.github.com/users/sozercan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sozercan/subscriptions","organizations_url":"https://api.github.com/users/sozercan/orgs","repos_url":"https://api.github.com/users/sozercan/repos","events_url":"https://api.github.com/users/sozercan/events{/privacy}","received_events_url":"https://api.github.com/users/sozercan/received_events","type":"User","site_admin":false},"body":"<!-- Thanks for sending a pull request! Here are some tips for you:\r\n1. If you want *faster* PR reviews, read how: https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md#best-practices-for-faster-reviews\r\n-->\r\n\r\n**What this PR does / why we need it**:\r\n* Adds support for Virtual Machine Scale sets for Kubernetes v1.10 agent pools\r\n\r\n**Which issue this PR fixes**: \r\nfixes #2403 \r\n\r\n**If applicable**:\r\n- [x] documentation\r\n- [x] unit tests\r\n- [x] tested backward compatibility (~ie. deploy with previous version, upgrade with this branch~)\r\n\r\n**Release note**:\r\n<!-- Steps to write your release note:\r\n1. Use the release-note-* labels to set the release note state (if you have access)\r\n2. Enter your extended release note in the below block; leaving it blank means using the PR title as the release note. If no release note is required, just write `NONE`.\r\n-->\r\n```release-note\r\nAdd Virtual Machine Scale Sets support for Kubernetes v1.10+ agent availability profile\r\n```\r\n\r\ncc @feiskyer @JiangtianLi \r\n","created_at":"2018-04-06T19:51:22Z","updated_at":"2018-04-20T01:11:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9d5b613cd1c0cbf7957221f1a01d7595554b6530","assignee":{"login":"sozercan","id":852750,"avatar_url":"https://avatars0.githubusercontent.com/u/852750?v=4","gravatar_id":"","url":"https://api.github.com/users/sozercan","html_url":"https://github.com/sozercan","followers_url":"https://api.github.com/users/sozercan/followers","following_url":"https://api.github.com/users/sozercan/following{/other_user}","gists_url":"https://api.github.com/users/sozercan/gists{/gist_id}","starred_url":"https://api.github.com/users/sozercan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sozercan/subscriptions","organizations_url":"https://api.github.com/users/sozercan/orgs","repos_url":"https://api.github.com/users/sozercan/repos","events_url":"https://api.github.com/users/sozercan/events{/privacy}","received_events_url":"https://api.github.com/users/sozercan/received_events","type":"User","site_admin":false},"assignees":[{"login":"sozercan","id":852750,"avatar_url":"https://avatars0.githubusercontent.com/u/852750?v=4","gravatar_id":"","url":"https://api.github.com/users/sozercan","html_url":"https://github.com/sozercan","followers_url":"https://api.github.com/users/sozercan/followers","following_url":"https://api.github.com/users/sozercan/following{/other_user}","gists_url":"https://api.github.com/users/sozercan/gists{/gist_id}","starred_url":"https://api.github.com/users/sozercan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sozercan/subscriptions","organizations_url":"https://api.github.com/users/sozercan/orgs","repos_url":"https://api.github.com/users/sozercan/repos","events_url":"https://api.github.com/users/sozercan/events{/privacy}","received_events_url":"https://api.github.com/users/sozercan/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"jackfrancis","id":1494193,"avatar_url":"https://avatars0.githubusercontent.com/u/1494193?v=4","gravatar_id":"","url":"https://api.github.com/users/jackfrancis","html_url":"https://github.com/jackfrancis","followers_url":"https://api.github.com/users/jackfrancis/followers","following_url":"https://api.github.com/users/jackfrancis/following{/other_user}","gists_url":"https://api.github.com/users/jackfrancis/gists{/gist_id}","starred_url":"https://api.github.com/users/jackfrancis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jackfrancis/subscriptions","organizations_url":"https://api.github.com/users/jackfrancis/orgs","repos_url":"https://api.github.com/users/jackfrancis/repos","events_url":"https://api.github.com/users/jackfrancis/events{/privacy}","received_events_url":"https://api.github.com/users/jackfrancis/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Azure/acs-engine/pulls/2620/commits","review_comments_url":"https://api.github.com/repos/Azure/acs-engine/pulls/2620/comments","review_comment_url":"https://api.github.com/repos/Azure/acs-engine/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/acs-engine/issues/2620/comments","statuses_url":"https://api.github.com/repos/Azure/acs-engine/statuses/a141b74a0a216718f42ad564742e9f024e9a7cf9","head":{"label":"sozercan:vmss","ref":"vmss","sha":"a141b74a0a216718f42ad564742e9f024e9a7cf9","user":{"login":"sozercan","id":852750,"avatar_url":"https://avatars0.githubusercontent.com/u/852750?v=4","gravatar_id":"","url":"https://api.github.com/users/sozercan","html_url":"https://github.com/sozercan","followers_url":"https://api.github.com/users/sozercan/followers","following_url":"https://api.github.com/users/sozercan/following{/other_user}","gists_url":"https://api.github.com/users/sozercan/gists{/gist_id}","starred_url":"https://api.github.com/users/sozercan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sozercan/subscriptions","organizations_url":"https://api.github.com/users/sozercan/orgs","repos_url":"https://api.github.com/users/sozercan/repos","events_url":"https://api.github.com/users/sozercan/events{/privacy}","received_events_url":"https://api.github.com/users/sozercan/received_events","type":"User","site_admin":false},"repo":{"id":83094157,"name":"acs-engine","full_name":"sozercan/acs-engine","owner":{"login":"sozercan","id":852750,"avatar_url":"https://avatars0.githubusercontent.com/u/852750?v=4","gravatar_id":"","url":"https://api.github.com/users/sozercan","html_url":"https://github.com/sozercan","followers_url":"https://api.github.com/users/sozercan/followers","following_url":"https://api.github.com/users/sozercan/following{/other_user}","gists_url":"https://api.github.com/users/sozercan/gists{/gist_id}","starred_url":"https://api.github.com/users/sozercan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sozercan/subscriptions","organizations_url":"https://api.github.com/users/sozercan/orgs","repos_url":"https://api.github.com/users/sozercan/repos","events_url":"https://api.github.com/users/sozercan/events{/privacy}","received_events_url":"https://api.github.com/users/sozercan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sozercan/acs-engine","description":"Azure Container Service Engine - a place for community to collaborate and build the best open Docker container infrastructure for Azure.","fork":true,"url":"https://api.github.com/repos/sozercan/acs-engine","forks_url":"https://api.github.com/repos/sozercan/acs-engine/forks","keys_url":"https://api.github.com/repos/sozercan/acs-engine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sozercan/acs-engine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sozercan/acs-engine/teams","hooks_url":"https://api.github.com/repos/sozercan/acs-engine/hooks","issue_events_url":"https://api.github.com/repos/sozercan/acs-engine/issues/events{/number}","events_url":"https://api.github.com/repos/sozercan/acs-engine/events","assignees_url":"https://api.github.com/repos/sozercan/acs-engine/assignees{/user}","branches_url":"https://api.github.com/repos/sozercan/acs-engine/branches{/branch}","tags_url":"https://api.github.com/repos/sozercan/acs-engine/tags","blobs_url":"https://api.github.com/repos/sozercan/acs-engine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sozercan/acs-engine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sozercan/acs-engine/git/refs{/sha}","trees_url":"https://api.github.com/repos/sozercan/acs-engine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sozercan/acs-engine/statuses/{sha}","languages_url":"https://api.github.com/repos/sozercan/acs-engine/languages","stargazers_url":"https://api.github.com/repos/sozercan/acs-engine/stargazers","contributors_url":"https://api.github.com/repos/sozercan/acs-engine/contributors","subscribers_url":"https://api.github.com/repos/sozercan/acs-engine/subscribers","subscription_url":"https://api.github.com/repos/sozercan/acs-engine/subscription","commits_url":"https://api.github.com/repos/sozercan/acs-engine/commits{/sha}","git_commits_url":"https://api.github.com/repos/sozercan/acs-engine/git/commits{/sha}","comments_url":"https://api.github.com/repos/sozercan/acs-engine/comments{/number}","issue_comment_url":"https://api.github.com/repos/sozercan/acs-engine/issues/comments{/number}","contents_url":"https://api.github.com/repos/sozercan/acs-engine/contents/{+path}","compare_url":"https://api.github.com/repos/sozercan/acs-engine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sozercan/acs-engine/merges","archive_url":"https://api.github.com/repos/sozercan/acs-engine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sozercan/acs-engine/downloads","issues_url":"https://api.github.com/repos/sozercan/acs-engine/issues{/number}","pulls_url":"https://api.github.com/repos/sozercan/acs-engine/pulls{/number}","milestones_url":"https://api.github.com/repos/sozercan/acs-engine/milestones{/number}","notifications_url":"https://api.github.com/repos/sozercan/acs-engine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sozercan/acs-engine/labels{/name}","releases_url":"https://api.github.com/repos/sozercan/acs-engine/releases{/id}","deployments_url":"https://api.github.com/repos/sozercan/acs-engine/deployments","created_at":"2017-02-25T00:23:46Z","updated_at":"2018-04-17T20:29:00Z","pushed_at":"2018-04-19T17:47:39Z","git_url":"git://github.com/sozercan/acs-engine.git","ssh_url":"[email protected]:sozercan/acs-engine.git","clone_url":"https://github.com/sozercan/acs-engine.git","svn_url":"https://github.com/sozercan/acs-engine","homepage":"","size":65458,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Azure:master","ref":"master","sha":"27a594c07b34c367085cb73016a96afa71b0e7da","user":{"login":"Azure","id":6844498,"avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":66011370,"name":"acs-engine","full_name":"Azure/acs-engine","owner":{"login":"Azure","id":6844498,"avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Azure/acs-engine","description":"Azure Container Service Engine - a place for community to collaborate and build the best open Docker container infrastructure for Azure.","fork":false,"url":"https://api.github.com/repos/Azure/acs-engine","forks_url":"https://api.github.com/repos/Azure/acs-engine/forks","keys_url":"https://api.github.com/repos/Azure/acs-engine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/acs-engine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/acs-engine/teams","hooks_url":"https://api.github.com/repos/Azure/acs-engine/hooks","issue_events_url":"https://api.github.com/repos/Azure/acs-engine/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/acs-engine/events","assignees_url":"https://api.github.com/repos/Azure/acs-engine/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/acs-engine/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/acs-engine/tags","blobs_url":"https://api.github.com/repos/Azure/acs-engine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/acs-engine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/acs-engine/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/acs-engine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/acs-engine/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/acs-engine/languages","stargazers_url":"https://api.github.com/repos/Azure/acs-engine/stargazers","contributors_url":"https://api.github.com/repos/Azure/acs-engine/contributors","subscribers_url":"https://api.github.com/repos/Azure/acs-engine/subscribers","subscription_url":"https://api.github.com/repos/Azure/acs-engine/subscription","commits_url":"https://api.github.com/repos/Azure/acs-engine/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/acs-engine/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/acs-engine/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/acs-engine/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/acs-engine/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/acs-engine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/acs-engine/merges","archive_url":"https://api.github.com/repos/Azure/acs-engine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/acs-engine/downloads","issues_url":"https://api.github.com/repos/Azure/acs-engine/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/acs-engine/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/acs-engine/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/acs-engine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/acs-engine/labels{/name}","releases_url":"https://api.github.com/repos/Azure/acs-engine/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/acs-engine/deployments","created_at":"2016-08-18T16:05:16Z","updated_at":"2018-04-19T23:40:48Z","pushed_at":"2018-04-20T00:31:07Z","git_url":"git://github.com/Azure/acs-engine.git","ssh_url":"[email protected]:Azure/acs-engine.git","clone_url":"https://github.com/Azure/acs-engine.git","svn_url":"https://github.com/Azure/acs-engine","homepage":"","size":75948,"stargazers_count":748,"watchers_count":748,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":484,"mirror_url":null,"archived":false,"open_issues_count":454,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":484,"open_issues":454,"watchers":748,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/acs-engine/pulls/2620"},"html":{"href":"https://github.com/Azure/acs-engine/pull/2620"},"issue":{"href":"https://api.github.com/repos/Azure/acs-engine/issues/2620"},"comments":{"href":"https://api.github.com/repos/Azure/acs-engine/issues/2620/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/acs-engine/pulls/2620/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/acs-engine/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/acs-engine/pulls/2620/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/acs-engine/statuses/a141b74a0a216718f42ad564742e9f024e9a7cf9"}},"author_association":"CONTRIBUTOR"}} | {
"id": 66011370,
"name": "Azure/acs-engine",
"url": "https://api.github.com/repos/Azure/acs-engine"
} | {
"id": 25217557,
"login": "JiangtianLi",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/25217557?",
"url": "https://api.github.com/users/JiangtianLi"
} | {
"id": 6844498,
"login": "Azure",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6844498?",
"url": "https://api.github.com/orgs/Azure"
} | 2018-04-20T01:11:53 | 7558974647 | {"actor":{"display_login":"JiangtianLi"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/Azure/acs-engine/pulls/comments/189686989","pull_request_review_id":121914934,"id":189686989,"diff_hunk":"@@ -95,14 +95,20 @@ for i in /etc/origin/master/master-config.yaml /tmp/bootstrapconfigs/* /tmp/ansi\n sed -i \"s|HOSTNAME|${HOSTNAME}|g;\" $i\n done\n \n+mkdir -p /root/.kube\n+\n+for loc in /root/.kube/config /etc/origin/node/bootstrap.kubeconfig /etc/origin/node/node.kubeconfig; do\n+ cp /etc/origin/master/admin.kubeconfig \"$loc\"\n+done\n+\n # note: ${SERVICE_TYPE}-node crash loops until master is up\n-for unit in etcd.service ${SERVICE_TYPE}-master-api.service ${SERVICE_TYPE}-master-controllers.service; do\n-\tsystemctl enable $unit\n-\tsystemctl start $unit\n+# copy each statid pod into place so the kubelet will run it [apiserver, controller, etcd]\n+for pod in /etc/origin/node/disabled/*;\n+do\n+ mv \"$pod\" /etc/origin/node/pods","path":"parts/openshift/unstable/openshiftmasterscript.sh","position":38,"original_position":38,"commit_id":"4806b40c17b801f6c287b3e30f31937a3156fba2","original_commit_id":"4806b40c17b801f6c287b3e30f31937a3156fba2","user":{"login":"jim-minter","id":1038301,"avatar_url":"https://avatars2.githubusercontent.com/u/1038301?v=4","gravatar_id":"","url":"https://api.github.com/users/jim-minter","html_url":"https://github.com/jim-minter","followers_url":"https://api.github.com/users/jim-minter/followers","following_url":"https://api.github.com/users/jim-minter/following{/other_user}","gists_url":"https://api.github.com/users/jim-minter/gists{/gist_id}","starred_url":"https://api.github.com/users/jim-minter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jim-minter/subscriptions","organizations_url":"https://api.github.com/users/jim-minter/orgs","repos_url":"https://api.github.com/users/jim-minter/repos","events_url":"https://api.github.com/users/jim-minter/events{/privacy}","received_events_url":"https://api.github.com/users/jim-minter/received_events","type":"User","site_admin":false},"body":"just mv /etc/origin/node/disabled/* /etc/origin/node/pods","created_at":"2018-05-21T19:17:59Z","updated_at":"2018-05-21T19:18:00Z","html_url":"https://github.com/Azure/acs-engine/pull/2972#discussion_r189686989","pull_request_url":"https://api.github.com/repos/Azure/acs-engine/pulls/2972","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Azure/acs-engine/pulls/comments/189686989"},"html":{"href":"https://github.com/Azure/acs-engine/pull/2972#discussion_r189686989"},"pull_request":{"href":"https://api.github.com/repos/Azure/acs-engine/pulls/2972"}}},"pull_request":{"url":"https://api.github.com/repos/Azure/acs-engine/pulls/2972","id":188220698,"html_url":"https://github.com/Azure/acs-engine/pull/2972","diff_url":"https://github.com/Azure/acs-engine/pull/2972.diff","patch_url":"https://github.com/Azure/acs-engine/pull/2972.patch","issue_url":"https://api.github.com/repos/Azure/acs-engine/issues/2972","number":2972,"state":"open","locked":false,"title":"Adding necessary configuration for 3.10 Openshift nodes.","user":{"login":"kwoodson","id":1385770,"avatar_url":"https://avatars2.githubusercontent.com/u/1385770?v=4","gravatar_id":"","url":"https://api.github.com/users/kwoodson","html_url":"https://github.com/kwoodson","followers_url":"https://api.github.com/users/kwoodson/followers","following_url":"https://api.github.com/users/kwoodson/following{/other_user}","gists_url":"https://api.github.com/users/kwoodson/gists{/gist_id}","starred_url":"https://api.github.com/users/kwoodson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kwoodson/subscriptions","organizations_url":"https://api.github.com/users/kwoodson/orgs","repos_url":"https://api.github.com/users/kwoodson/repos","events_url":"https://api.github.com/users/kwoodson/events{/privacy}","received_events_url":"https://api.github.com/users/kwoodson/received_events","type":"User","site_admin":false},"body":"@jim-minter @kargakis @pweil-\r\n\r\nWhen moving to 3.10 Openshift nodes we need to bootstrap the node image so that the hosted control plane will run during start.","created_at":"2018-05-15T18:46:08Z","updated_at":"2018-05-21T19:18:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d1e29172c84d31d153a4af83b3f52dfd5492d8da","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":936451056,"url":"https://api.github.com/repos/Azure/acs-engine/labels/size/L","name":"size/L","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Azure/acs-engine/pulls/2972/commits","review_comments_url":"https://api.github.com/repos/Azure/acs-engine/pulls/2972/comments","review_comment_url":"https://api.github.com/repos/Azure/acs-engine/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/acs-engine/issues/2972/comments","statuses_url":"https://api.github.com/repos/Azure/acs-engine/statuses/4806b40c17b801f6c287b3e30f31937a3156fba2","head":{"label":"kwoodson:azure_3_10_openshift_control_plane","ref":"azure_3_10_openshift_control_plane","sha":"4806b40c17b801f6c287b3e30f31937a3156fba2","user":{"login":"kwoodson","id":1385770,"avatar_url":"https://avatars2.githubusercontent.com/u/1385770?v=4","gravatar_id":"","url":"https://api.github.com/users/kwoodson","html_url":"https://github.com/kwoodson","followers_url":"https://api.github.com/users/kwoodson/followers","following_url":"https://api.github.com/users/kwoodson/following{/other_user}","gists_url":"https://api.github.com/users/kwoodson/gists{/gist_id}","starred_url":"https://api.github.com/users/kwoodson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kwoodson/subscriptions","organizations_url":"https://api.github.com/users/kwoodson/orgs","repos_url":"https://api.github.com/users/kwoodson/repos","events_url":"https://api.github.com/users/kwoodson/events{/privacy}","received_events_url":"https://api.github.com/users/kwoodson/received_events","type":"User","site_admin":false},"repo":{"id":124893700,"name":"acs-engine","full_name":"kwoodson/acs-engine","owner":{"login":"kwoodson","id":1385770,"avatar_url":"https://avatars2.githubusercontent.com/u/1385770?v=4","gravatar_id":"","url":"https://api.github.com/users/kwoodson","html_url":"https://github.com/kwoodson","followers_url":"https://api.github.com/users/kwoodson/followers","following_url":"https://api.github.com/users/kwoodson/following{/other_user}","gists_url":"https://api.github.com/users/kwoodson/gists{/gist_id}","starred_url":"https://api.github.com/users/kwoodson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kwoodson/subscriptions","organizations_url":"https://api.github.com/users/kwoodson/orgs","repos_url":"https://api.github.com/users/kwoodson/repos","events_url":"https://api.github.com/users/kwoodson/events{/privacy}","received_events_url":"https://api.github.com/users/kwoodson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kwoodson/acs-engine","description":"Azure Container Service Engine - a place for community to collaborate and build the best open Docker container infrastructure for Azure.","fork":true,"url":"https://api.github.com/repos/kwoodson/acs-engine","forks_url":"https://api.github.com/repos/kwoodson/acs-engine/forks","keys_url":"https://api.github.com/repos/kwoodson/acs-engine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kwoodson/acs-engine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kwoodson/acs-engine/teams","hooks_url":"https://api.github.com/repos/kwoodson/acs-engine/hooks","issue_events_url":"https://api.github.com/repos/kwoodson/acs-engine/issues/events{/number}","events_url":"https://api.github.com/repos/kwoodson/acs-engine/events","assignees_url":"https://api.github.com/repos/kwoodson/acs-engine/assignees{/user}","branches_url":"https://api.github.com/repos/kwoodson/acs-engine/branches{/branch}","tags_url":"https://api.github.com/repos/kwoodson/acs-engine/tags","blobs_url":"https://api.github.com/repos/kwoodson/acs-engine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kwoodson/acs-engine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kwoodson/acs-engine/git/refs{/sha}","trees_url":"https://api.github.com/repos/kwoodson/acs-engine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kwoodson/acs-engine/statuses/{sha}","languages_url":"https://api.github.com/repos/kwoodson/acs-engine/languages","stargazers_url":"https://api.github.com/repos/kwoodson/acs-engine/stargazers","contributors_url":"https://api.github.com/repos/kwoodson/acs-engine/contributors","subscribers_url":"https://api.github.com/repos/kwoodson/acs-engine/subscribers","subscription_url":"https://api.github.com/repos/kwoodson/acs-engine/subscription","commits_url":"https://api.github.com/repos/kwoodson/acs-engine/commits{/sha}","git_commits_url":"https://api.github.com/repos/kwoodson/acs-engine/git/commits{/sha}","comments_url":"https://api.github.com/repos/kwoodson/acs-engine/comments{/number}","issue_comment_url":"https://api.github.com/repos/kwoodson/acs-engine/issues/comments{/number}","contents_url":"https://api.github.com/repos/kwoodson/acs-engine/contents/{+path}","compare_url":"https://api.github.com/repos/kwoodson/acs-engine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kwoodson/acs-engine/merges","archive_url":"https://api.github.com/repos/kwoodson/acs-engine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kwoodson/acs-engine/downloads","issues_url":"https://api.github.com/repos/kwoodson/acs-engine/issues{/number}","pulls_url":"https://api.github.com/repos/kwoodson/acs-engine/pulls{/number}","milestones_url":"https://api.github.com/repos/kwoodson/acs-engine/milestones{/number}","notifications_url":"https://api.github.com/repos/kwoodson/acs-engine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kwoodson/acs-engine/labels{/name}","releases_url":"https://api.github.com/repos/kwoodson/acs-engine/releases{/id}","deployments_url":"https://api.github.com/repos/kwoodson/acs-engine/deployments","created_at":"2018-03-12T13:31:15Z","updated_at":"2018-05-21T18:49:32Z","pushed_at":"2018-05-21T18:49:31Z","git_url":"git://github.com/kwoodson/acs-engine.git","ssh_url":"[email protected]:kwoodson/acs-engine.git","clone_url":"https://github.com/kwoodson/acs-engine.git","svn_url":"https://github.com/kwoodson/acs-engine","homepage":"","size":67897,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Azure:master","ref":"master","sha":"25cfb555f3c0efcd6ff864f0bde64099e80c9aa0","user":{"login":"Azure","id":6844498,"avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":66011370,"name":"acs-engine","full_name":"Azure/acs-engine","owner":{"login":"Azure","id":6844498,"avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Azure/acs-engine","description":"Azure Container Service Engine - a place for community to collaborate and build the best open Docker container infrastructure for Azure.","fork":false,"url":"https://api.github.com/repos/Azure/acs-engine","forks_url":"https://api.github.com/repos/Azure/acs-engine/forks","keys_url":"https://api.github.com/repos/Azure/acs-engine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/acs-engine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/acs-engine/teams","hooks_url":"https://api.github.com/repos/Azure/acs-engine/hooks","issue_events_url":"https://api.github.com/repos/Azure/acs-engine/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/acs-engine/events","assignees_url":"https://api.github.com/repos/Azure/acs-engine/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/acs-engine/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/acs-engine/tags","blobs_url":"https://api.github.com/repos/Azure/acs-engine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/acs-engine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/acs-engine/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/acs-engine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/acs-engine/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/acs-engine/languages","stargazers_url":"https://api.github.com/repos/Azure/acs-engine/stargazers","contributors_url":"https://api.github.com/repos/Azure/acs-engine/contributors","subscribers_url":"https://api.github.com/repos/Azure/acs-engine/subscribers","subscription_url":"https://api.github.com/repos/Azure/acs-engine/subscription","commits_url":"https://api.github.com/repos/Azure/acs-engine/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/acs-engine/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/acs-engine/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/acs-engine/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/acs-engine/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/acs-engine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/acs-engine/merges","archive_url":"https://api.github.com/repos/Azure/acs-engine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/acs-engine/downloads","issues_url":"https://api.github.com/repos/Azure/acs-engine/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/acs-engine/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/acs-engine/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/acs-engine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/acs-engine/labels{/name}","releases_url":"https://api.github.com/repos/Azure/acs-engine/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/acs-engine/deployments","created_at":"2016-08-18T16:05:16Z","updated_at":"2018-05-21T18:32:57Z","pushed_at":"2018-05-21T18:22:58Z","git_url":"git://github.com/Azure/acs-engine.git","ssh_url":"[email protected]:Azure/acs-engine.git","clone_url":"https://github.com/Azure/acs-engine.git","svn_url":"https://github.com/Azure/acs-engine","homepage":"","size":79842,"stargazers_count":800,"watchers_count":800,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":523,"mirror_url":null,"archived":false,"open_issues_count":493,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":523,"open_issues":493,"watchers":800,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/acs-engine/pulls/2972"},"html":{"href":"https://github.com/Azure/acs-engine/pull/2972"},"issue":{"href":"https://api.github.com/repos/Azure/acs-engine/issues/2972"},"comments":{"href":"https://api.github.com/repos/Azure/acs-engine/issues/2972/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/acs-engine/pulls/2972/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/acs-engine/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/acs-engine/pulls/2972/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/acs-engine/statuses/4806b40c17b801f6c287b3e30f31937a3156fba2"}},"author_association":"CONTRIBUTOR"}} | {
"id": 66011370,
"name": "Azure/acs-engine",
"url": "https://api.github.com/repos/Azure/acs-engine"
} | {
"id": 1038301,
"login": "jim-minter",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1038301?",
"url": "https://api.github.com/users/jim-minter"
} | {
"id": 6844498,
"login": "Azure",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6844498?",
"url": "https://api.github.com/orgs/Azure"
} | 2018-05-21T19:17:59 | 7706555041 | {"actor":{"display_login":"jim-minter"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/projectatomic/rpm-ostree/pulls/comments/192114605","pull_request_review_id":124822067,"id":192114605,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5MjExNDYwNQ==","diff_hunk":"@@ -0,0 +1,204 @@\n+[[package]]","path":"rust/Cargo.lock","position":1,"original_position":1,"commit_id":"b5316dab0a089933a28dd61fe1947ad641544f4a","original_commit_id":"b5316dab0a089933a28dd61fe1947ad641544f4a","user":{"login":"cgwalters","id":244096,"node_id":"MDQ6VXNlcjI0NDA5Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/244096?v=4","gravatar_id":"","url":"https://api.github.com/users/cgwalters","html_url":"https://github.com/cgwalters","followers_url":"https://api.github.com/users/cgwalters/followers","following_url":"https://api.github.com/users/cgwalters/following{/other_user}","gists_url":"https://api.github.com/users/cgwalters/gists{/gist_id}","starred_url":"https://api.github.com/users/cgwalters/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cgwalters/subscriptions","organizations_url":"https://api.github.com/users/cgwalters/orgs","repos_url":"https://api.github.com/users/cgwalters/repos","events_url":"https://api.github.com/users/cgwalters/events{/privacy}","received_events_url":"https://api.github.com/users/cgwalters/received_events","type":"User","site_admin":false},"body":"I think opinion is split on this somewhat, but I personally don't like shipping `Cargo.lock` in git. Do pinning when we hit breakage (and ideally submit patches), rather than the constant maintenance overhead of bumping it.","created_at":"2018-05-31T14:16:49Z","updated_at":"2018-05-31T14:17:34Z","html_url":"https://github.com/projectatomic/rpm-ostree/pull/1377#discussion_r192114605","pull_request_url":"https://api.github.com/repos/projectatomic/rpm-ostree/pulls/1377","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/projectatomic/rpm-ostree/pulls/comments/192114605"},"html":{"href":"https://github.com/projectatomic/rpm-ostree/pull/1377#discussion_r192114605"},"pull_request":{"href":"https://api.github.com/repos/projectatomic/rpm-ostree/pulls/1377"}}},"pull_request":{"url":"https://api.github.com/repos/projectatomic/rpm-ostree/pulls/1377","id":191590208,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkxNTkwMjA4","html_url":"https://github.com/projectatomic/rpm-ostree/pull/1377","diff_url":"https://github.com/projectatomic/rpm-ostree/pull/1377.diff","patch_url":"https://github.com/projectatomic/rpm-ostree/pull/1377.patch","issue_url":"https://api.github.com/repos/projectatomic/rpm-ostree/issues/1377","number":1377,"state":"open","locked":false,"title":"RFC: WIP: Add support for YAML treefiles","user":{"login":"jlebon","id":11934099,"node_id":"MDQ6VXNlcjExOTM0MDk5","avatar_url":"https://avatars3.githubusercontent.com/u/11934099?v=4","gravatar_id":"","url":"https://api.github.com/users/jlebon","html_url":"https://github.com/jlebon","followers_url":"https://api.github.com/users/jlebon/followers","following_url":"https://api.github.com/users/jlebon/following{/other_user}","gists_url":"https://api.github.com/users/jlebon/gists{/gist_id}","starred_url":"https://api.github.com/users/jlebon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlebon/subscriptions","organizations_url":"https://api.github.com/users/jlebon/orgs","repos_url":"https://api.github.com/users/jlebon/repos","events_url":"https://api.github.com/users/jlebon/events{/privacy}","received_events_url":"https://api.github.com/users/jlebon/received_events","type":"User","site_admin":false},"body":"Let's modernize and start supporting YAML treefiles. I'll dare make the\r\nsweeping generalization that most people would prefer reading and\r\nwriting YAML over JSON.\r\n\r\nThis takes bits from coreos-assembler[1] that know how to serialize a\r\nYAML file and spit it back out as a JSON and makes it into a shared lib\r\nthat we can link against. We could use this eventually for JSON inputs\r\nas well to force a validation check before composing.\r\n\r\nIf we go this route, we could then turn on `--enable-rust` in FAHC for\r\nnow and drop the duplicate code in coreos-assembler.\r\n\r\n[1] https://github.com/cgwalters/coreos-assembler","created_at":"2018-05-30T21:47:23Z","updated_at":"2018-05-31T14:17:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c5afe8e483e21035aef1643a6b2d69893df5e5c5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/projectatomic/rpm-ostree/pulls/1377/commits","review_comments_url":"https://api.github.com/repos/projectatomic/rpm-ostree/pulls/1377/comments","review_comment_url":"https://api.github.com/repos/projectatomic/rpm-ostree/pulls/comments{/number}","comments_url":"https://api.github.com/repos/projectatomic/rpm-ostree/issues/1377/comments","statuses_url":"https://api.github.com/repos/projectatomic/rpm-ostree/statuses/b5316dab0a089933a28dd61fe1947ad641544f4a","head":{"label":"jlebon:pr/yaml-rust","ref":"pr/yaml-rust","sha":"b5316dab0a089933a28dd61fe1947ad641544f4a","user":{"login":"jlebon","id":11934099,"node_id":"MDQ6VXNlcjExOTM0MDk5","avatar_url":"https://avatars3.githubusercontent.com/u/11934099?v=4","gravatar_id":"","url":"https://api.github.com/users/jlebon","html_url":"https://github.com/jlebon","followers_url":"https://api.github.com/users/jlebon/followers","following_url":"https://api.github.com/users/jlebon/following{/other_user}","gists_url":"https://api.github.com/users/jlebon/gists{/gist_id}","starred_url":"https://api.github.com/users/jlebon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlebon/subscriptions","organizations_url":"https://api.github.com/users/jlebon/orgs","repos_url":"https://api.github.com/users/jlebon/repos","events_url":"https://api.github.com/users/jlebon/events{/privacy}","received_events_url":"https://api.github.com/users/jlebon/received_events","type":"User","site_admin":false},"repo":{"id":43963435,"node_id":"MDEwOlJlcG9zaXRvcnk0Mzk2MzQzNQ==","name":"rpm-ostree","full_name":"jlebon/rpm-ostree","owner":{"login":"jlebon","id":11934099,"node_id":"MDQ6VXNlcjExOTM0MDk5","avatar_url":"https://avatars3.githubusercontent.com/u/11934099?v=4","gravatar_id":"","url":"https://api.github.com/users/jlebon","html_url":"https://github.com/jlebon","followers_url":"https://api.github.com/users/jlebon/followers","following_url":"https://api.github.com/users/jlebon/following{/other_user}","gists_url":"https://api.github.com/users/jlebon/gists{/gist_id}","starred_url":"https://api.github.com/users/jlebon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlebon/subscriptions","organizations_url":"https://api.github.com/users/jlebon/orgs","repos_url":"https://api.github.com/users/jlebon/repos","events_url":"https://api.github.com/users/jlebon/events{/privacy}","received_events_url":"https://api.github.com/users/jlebon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jlebon/rpm-ostree","description":"Store RPMs in OSTree repository, and atomically upgrade from commits","fork":true,"url":"https://api.github.com/repos/jlebon/rpm-ostree","forks_url":"https://api.github.com/repos/jlebon/rpm-ostree/forks","keys_url":"https://api.github.com/repos/jlebon/rpm-ostree/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jlebon/rpm-ostree/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jlebon/rpm-ostree/teams","hooks_url":"https://api.github.com/repos/jlebon/rpm-ostree/hooks","issue_events_url":"https://api.github.com/repos/jlebon/rpm-ostree/issues/events{/number}","events_url":"https://api.github.com/repos/jlebon/rpm-ostree/events","assignees_url":"https://api.github.com/repos/jlebon/rpm-ostree/assignees{/user}","branches_url":"https://api.github.com/repos/jlebon/rpm-ostree/branches{/branch}","tags_url":"https://api.github.com/repos/jlebon/rpm-ostree/tags","blobs_url":"https://api.github.com/repos/jlebon/rpm-ostree/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jlebon/rpm-ostree/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jlebon/rpm-ostree/git/refs{/sha}","trees_url":"https://api.github.com/repos/jlebon/rpm-ostree/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jlebon/rpm-ostree/statuses/{sha}","languages_url":"https://api.github.com/repos/jlebon/rpm-ostree/languages","stargazers_url":"https://api.github.com/repos/jlebon/rpm-ostree/stargazers","contributors_url":"https://api.github.com/repos/jlebon/rpm-ostree/contributors","subscribers_url":"https://api.github.com/repos/jlebon/rpm-ostree/subscribers","subscription_url":"https://api.github.com/repos/jlebon/rpm-ostree/subscription","commits_url":"https://api.github.com/repos/jlebon/rpm-ostree/commits{/sha}","git_commits_url":"https://api.github.com/repos/jlebon/rpm-ostree/git/commits{/sha}","comments_url":"https://api.github.com/repos/jlebon/rpm-ostree/comments{/number}","issue_comment_url":"https://api.github.com/repos/jlebon/rpm-ostree/issues/comments{/number}","contents_url":"https://api.github.com/repos/jlebon/rpm-ostree/contents/{+path}","compare_url":"https://api.github.com/repos/jlebon/rpm-ostree/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jlebon/rpm-ostree/merges","archive_url":"https://api.github.com/repos/jlebon/rpm-ostree/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jlebon/rpm-ostree/downloads","issues_url":"https://api.github.com/repos/jlebon/rpm-ostree/issues{/number}","pulls_url":"https://api.github.com/repos/jlebon/rpm-ostree/pulls{/number}","milestones_url":"https://api.github.com/repos/jlebon/rpm-ostree/milestones{/number}","notifications_url":"https://api.github.com/repos/jlebon/rpm-ostree/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jlebon/rpm-ostree/labels{/name}","releases_url":"https://api.github.com/repos/jlebon/rpm-ostree/releases{/id}","deployments_url":"https://api.github.com/repos/jlebon/rpm-ostree/deployments","created_at":"2015-10-09T15:15:14Z","updated_at":"2018-05-15T00:55:35Z","pushed_at":"2018-05-30T21:46:40Z","git_url":"git://github.com/jlebon/rpm-ostree.git","ssh_url":"[email protected]:jlebon/rpm-ostree.git","clone_url":"https://github.com/jlebon/rpm-ostree.git","svn_url":"https://github.com/jlebon/rpm-ostree","homepage":"","size":6745,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"projectatomic:master","ref":"master","sha":"89d130c5965dfb1714d463c12dee32790ac5652c","user":{"login":"projectatomic","id":6852258,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NTIyNTg=","avatar_url":"https://avatars1.githubusercontent.com/u/6852258?v=4","gravatar_id":"","url":"https://api.github.com/users/projectatomic","html_url":"https://github.com/projectatomic","followers_url":"https://api.github.com/users/projectatomic/followers","following_url":"https://api.github.com/users/projectatomic/following{/other_user}","gists_url":"https://api.github.com/users/projectatomic/gists{/gist_id}","starred_url":"https://api.github.com/users/projectatomic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projectatomic/subscriptions","organizations_url":"https://api.github.com/users/projectatomic/orgs","repos_url":"https://api.github.com/users/projectatomic/repos","events_url":"https://api.github.com/users/projectatomic/events{/privacy}","received_events_url":"https://api.github.com/users/projectatomic/received_events","type":"Organization","site_admin":false},"repo":{"id":15369584,"node_id":"MDEwOlJlcG9zaXRvcnkxNTM2OTU4NA==","name":"rpm-ostree","full_name":"projectatomic/rpm-ostree","owner":{"login":"projectatomic","id":6852258,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NTIyNTg=","avatar_url":"https://avatars1.githubusercontent.com/u/6852258?v=4","gravatar_id":"","url":"https://api.github.com/users/projectatomic","html_url":"https://github.com/projectatomic","followers_url":"https://api.github.com/users/projectatomic/followers","following_url":"https://api.github.com/users/projectatomic/following{/other_user}","gists_url":"https://api.github.com/users/projectatomic/gists{/gist_id}","starred_url":"https://api.github.com/users/projectatomic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projectatomic/subscriptions","organizations_url":"https://api.github.com/users/projectatomic/orgs","repos_url":"https://api.github.com/users/projectatomic/repos","events_url":"https://api.github.com/users/projectatomic/events{/privacy}","received_events_url":"https://api.github.com/users/projectatomic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/projectatomic/rpm-ostree","description":"⚛📦 Hybrid image/package system with atomic upgrades and package layering","fork":false,"url":"https://api.github.com/repos/projectatomic/rpm-ostree","forks_url":"https://api.github.com/repos/projectatomic/rpm-ostree/forks","keys_url":"https://api.github.com/repos/projectatomic/rpm-ostree/keys{/key_id}","collaborators_url":"https://api.github.com/repos/projectatomic/rpm-ostree/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/projectatomic/rpm-ostree/teams","hooks_url":"https://api.github.com/repos/projectatomic/rpm-ostree/hooks","issue_events_url":"https://api.github.com/repos/projectatomic/rpm-ostree/issues/events{/number}","events_url":"https://api.github.com/repos/projectatomic/rpm-ostree/events","assignees_url":"https://api.github.com/repos/projectatomic/rpm-ostree/assignees{/user}","branches_url":"https://api.github.com/repos/projectatomic/rpm-ostree/branches{/branch}","tags_url":"https://api.github.com/repos/projectatomic/rpm-ostree/tags","blobs_url":"https://api.github.com/repos/projectatomic/rpm-ostree/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/projectatomic/rpm-ostree/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/projectatomic/rpm-ostree/git/refs{/sha}","trees_url":"https://api.github.com/repos/projectatomic/rpm-ostree/git/trees{/sha}","statuses_url":"https://api.github.com/repos/projectatomic/rpm-ostree/statuses/{sha}","languages_url":"https://api.github.com/repos/projectatomic/rpm-ostree/languages","stargazers_url":"https://api.github.com/repos/projectatomic/rpm-ostree/stargazers","contributors_url":"https://api.github.com/repos/projectatomic/rpm-ostree/contributors","subscribers_url":"https://api.github.com/repos/projectatomic/rpm-ostree/subscribers","subscription_url":"https://api.github.com/repos/projectatomic/rpm-ostree/subscription","commits_url":"https://api.github.com/repos/projectatomic/rpm-ostree/commits{/sha}","git_commits_url":"https://api.github.com/repos/projectatomic/rpm-ostree/git/commits{/sha}","comments_url":"https://api.github.com/repos/projectatomic/rpm-ostree/comments{/number}","issue_comment_url":"https://api.github.com/repos/projectatomic/rpm-ostree/issues/comments{/number}","contents_url":"https://api.github.com/repos/projectatomic/rpm-ostree/contents/{+path}","compare_url":"https://api.github.com/repos/projectatomic/rpm-ostree/compare/{base}...{head}","merges_url":"https://api.github.com/repos/projectatomic/rpm-ostree/merges","archive_url":"https://api.github.com/repos/projectatomic/rpm-ostree/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/projectatomic/rpm-ostree/downloads","issues_url":"https://api.github.com/repos/projectatomic/rpm-ostree/issues{/number}","pulls_url":"https://api.github.com/repos/projectatomic/rpm-ostree/pulls{/number}","milestones_url":"https://api.github.com/repos/projectatomic/rpm-ostree/milestones{/number}","notifications_url":"https://api.github.com/repos/projectatomic/rpm-ostree/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/projectatomic/rpm-ostree/labels{/name}","releases_url":"https://api.github.com/repos/projectatomic/rpm-ostree/releases{/id}","deployments_url":"https://api.github.com/repos/projectatomic/rpm-ostree/deployments","created_at":"2013-12-22T03:16:38Z","updated_at":"2018-05-31T02:45:31Z","pushed_at":"2018-05-30T21:47:24Z","git_url":"git://github.com/projectatomic/rpm-ostree.git","ssh_url":"[email protected]:projectatomic/rpm-ostree.git","clone_url":"https://github.com/projectatomic/rpm-ostree.git","svn_url":"https://github.com/projectatomic/rpm-ostree","homepage":"","size":6754,"stargazers_count":210,"watchers_count":210,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":78,"mirror_url":null,"archived":false,"open_issues_count":155,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":78,"open_issues":155,"watchers":210,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/projectatomic/rpm-ostree/pulls/1377"},"html":{"href":"https://github.com/projectatomic/rpm-ostree/pull/1377"},"issue":{"href":"https://api.github.com/repos/projectatomic/rpm-ostree/issues/1377"},"comments":{"href":"https://api.github.com/repos/projectatomic/rpm-ostree/issues/1377/comments"},"review_comments":{"href":"https://api.github.com/repos/projectatomic/rpm-ostree/pulls/1377/comments"},"review_comment":{"href":"https://api.github.com/repos/projectatomic/rpm-ostree/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/projectatomic/rpm-ostree/pulls/1377/commits"},"statuses":{"href":"https://api.github.com/repos/projectatomic/rpm-ostree/statuses/b5316dab0a089933a28dd61fe1947ad641544f4a"}},"author_association":"MEMBER"}} | {
"id": 15369584,
"name": "projectatomic/rpm-ostree",
"url": "https://api.github.com/repos/projectatomic/rpm-ostree"
} | {
"id": 244096,
"login": "cgwalters",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/244096?",
"url": "https://api.github.com/users/cgwalters"
} | {
"id": 6852258,
"login": "projectatomic",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6852258?",
"url": "https://api.github.com/orgs/projectatomic"
} | 2018-05-31T14:16:49 | 7756681366 | {"actor":{"display_login":"cgwalters"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/ONSdigital/ras-frontstage/pulls/comments/180652124","pull_request_review_id":111106745,"id":180652124,"diff_hunk":"@@ -36,6 +36,15 @@ class Config(object):\n RAS_FRONTSTAGE_API_SERVICE = '{}://{}:{}/'.format(RAS_FRONTSTAGE_API_PROTOCOL,\n RAS_FRONTSTAGE_API_HOST,\n RAS_FRONTSTAGE_API_PORT)\n+\n+ RAS_SECURE_MESSAGING_PROTOCOL = os.getenv('RAS_SECURE_MESSAGING_PROTOCOL', 'http')\n+ RAS_SECURE_MESSAGING_HOST = os.getenv('RAS_SECURE_MESSAGING_HOST', 'localhost')\n+ RAS_SECURE_MESSAGING_PORT = os.getenv('RAS_SECURE_MESSAGING_PORT', 5050)\n+\n+ RAS_SECURE_MESSAGING_SERVICE = '{}://{}:{}/'.format(RAS_SECURE_MESSAGING_PROTOCOL,","path":"config.py","position":18,"original_position":18,"commit_id":"e104e42192bd2fab79c389861176d87061cef532","original_commit_id":"e104e42192bd2fab79c389861176d87061cef532","user":{"login":"rhiGriff","id":22023945,"avatar_url":"https://avatars2.githubusercontent.com/u/22023945?v=4","gravatar_id":"","url":"https://api.github.com/users/rhiGriff","html_url":"https://github.com/rhiGriff","followers_url":"https://api.github.com/users/rhiGriff/followers","following_url":"https://api.github.com/users/rhiGriff/following{/other_user}","gists_url":"https://api.github.com/users/rhiGriff/gists{/gist_id}","starred_url":"https://api.github.com/users/rhiGriff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhiGriff/subscriptions","organizations_url":"https://api.github.com/users/rhiGriff/orgs","repos_url":"https://api.github.com/users/rhiGriff/repos","events_url":"https://api.github.com/users/rhiGriff/events{/privacy}","received_events_url":"https://api.github.com/users/rhiGriff/received_events","type":"User","site_admin":false},"body":"These shoud be RAS_SECURE_MESSAGE_SERVICE_PORT ect, to coincide what's in Jenkins","created_at":"2018-04-11T06:59:49Z","updated_at":"2018-04-11T06:59:57Z","html_url":"https://github.com/ONSdigital/ras-frontstage/pull/301#discussion_r180652124","pull_request_url":"https://api.github.com/repos/ONSdigital/ras-frontstage/pulls/301","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ONSdigital/ras-frontstage/pulls/comments/180652124"},"html":{"href":"https://github.com/ONSdigital/ras-frontstage/pull/301#discussion_r180652124"},"pull_request":{"href":"https://api.github.com/repos/ONSdigital/ras-frontstage/pulls/301"}}},"pull_request":{"url":"https://api.github.com/repos/ONSdigital/ras-frontstage/pulls/301","id":180561193,"html_url":"https://github.com/ONSdigital/ras-frontstage/pull/301","diff_url":"https://github.com/ONSdigital/ras-frontstage/pull/301.diff","patch_url":"https://github.com/ONSdigital/ras-frontstage/pull/301.patch","issue_url":"https://api.github.com/repos/ONSdigital/ras-frontstage/issues/301","number":301,"state":"open","locked":false,"title":"Use cdn remove gulp","user":{"login":"insacuri","id":3965382,"avatar_url":"https://avatars2.githubusercontent.com/u/3965382?v=4","gravatar_id":"","url":"https://api.github.com/users/insacuri","html_url":"https://github.com/insacuri","followers_url":"https://api.github.com/users/insacuri/followers","following_url":"https://api.github.com/users/insacuri/following{/other_user}","gists_url":"https://api.github.com/users/insacuri/gists{/gist_id}","starred_url":"https://api.github.com/users/insacuri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/insacuri/subscriptions","organizations_url":"https://api.github.com/users/insacuri/orgs","repos_url":"https://api.github.com/users/insacuri/repos","events_url":"https://api.github.com/users/insacuri/events{/privacy}","received_events_url":"https://api.github.com/users/insacuri/received_events","type":"User","site_admin":false},"body":"Branched off https://github.com/ONSdigital/ras-frontstage/pull/294 which needs to be merged in first.\r\nThere is A LOT of styling code that isn't used in this repo. It makes it really confusing when figuring out what is actually being used.\r\nThis PR is at least a first pass, as I'm fairly sure there is more unused code that can be deleted, at removing unused code to make the codebase tidier.\r\nThis PR should have more then the normal amount of approval and each person reviewing it should test it to ensure that nothing looks obviously out of place.","created_at":"2018-04-10T10:46:29Z","updated_at":"2018-04-11T06:59:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"acedd7e571de65217175ba63fe1b2ac7fc267cdf","assignee":null,"assignees":[],"requested_reviewers":[{"login":"davidmort","id":1504284,"avatar_url":"https://avatars1.githubusercontent.com/u/1504284?v=4","gravatar_id":"","url":"https://api.github.com/users/davidmort","html_url":"https://github.com/davidmort","followers_url":"https://api.github.com/users/davidmort/followers","following_url":"https://api.github.com/users/davidmort/following{/other_user}","gists_url":"https://api.github.com/users/davidmort/gists{/gist_id}","starred_url":"https://api.github.com/users/davidmort/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidmort/subscriptions","organizations_url":"https://api.github.com/users/davidmort/orgs","repos_url":"https://api.github.com/users/davidmort/repos","events_url":"https://api.github.com/users/davidmort/events{/privacy}","received_events_url":"https://api.github.com/users/davidmort/received_events","type":"User","site_admin":false},{"login":"ajmaddaford","id":1754822,"avatar_url":"https://avatars3.githubusercontent.com/u/1754822?v=4","gravatar_id":"","url":"https://api.github.com/users/ajmaddaford","html_url":"https://github.com/ajmaddaford","followers_url":"https://api.github.com/users/ajmaddaford/followers","following_url":"https://api.github.com/users/ajmaddaford/following{/other_user}","gists_url":"https://api.github.com/users/ajmaddaford/gists{/gist_id}","starred_url":"https://api.github.com/users/ajmaddaford/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajmaddaford/subscriptions","organizations_url":"https://api.github.com/users/ajmaddaford/orgs","repos_url":"https://api.github.com/users/ajmaddaford/repos","events_url":"https://api.github.com/users/ajmaddaford/events{/privacy}","received_events_url":"https://api.github.com/users/ajmaddaford/received_events","type":"User","site_admin":false},{"login":"pricem14pc","id":12876332,"avatar_url":"https://avatars3.githubusercontent.com/u/12876332?v=4","gravatar_id":"","url":"https://api.github.com/users/pricem14pc","html_url":"https://github.com/pricem14pc","followers_url":"https://api.github.com/users/pricem14pc/followers","following_url":"https://api.github.com/users/pricem14pc/following{/other_user}","gists_url":"https://api.github.com/users/pricem14pc/gists{/gist_id}","starred_url":"https://api.github.com/users/pricem14pc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pricem14pc/subscriptions","organizations_url":"https://api.github.com/users/pricem14pc/orgs","repos_url":"https://api.github.com/users/pricem14pc/repos","events_url":"https://api.github.com/users/pricem14pc/events{/privacy}","received_events_url":"https://api.github.com/users/pricem14pc/received_events","type":"User","site_admin":false},{"login":"emilioward","id":16239750,"avatar_url":"https://avatars2.githubusercontent.com/u/16239750?v=4","gravatar_id":"","url":"https://api.github.com/users/emilioward","html_url":"https://github.com/emilioward","followers_url":"https://api.github.com/users/emilioward/followers","following_url":"https://api.github.com/users/emilioward/following{/other_user}","gists_url":"https://api.github.com/users/emilioward/gists{/gist_id}","starred_url":"https://api.github.com/users/emilioward/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emilioward/subscriptions","organizations_url":"https://api.github.com/users/emilioward/orgs","repos_url":"https://api.github.com/users/emilioward/repos","events_url":"https://api.github.com/users/emilioward/events{/privacy}","received_events_url":"https://api.github.com/users/emilioward/received_events","type":"User","site_admin":false},{"login":"dcdarrell9","id":16637283,"avatar_url":"https://avatars3.githubusercontent.com/u/16637283?v=4","gravatar_id":"","url":"https://api.github.com/users/dcdarrell9","html_url":"https://github.com/dcdarrell9","followers_url":"https://api.github.com/users/dcdarrell9/followers","following_url":"https://api.github.com/users/dcdarrell9/following{/other_user}","gists_url":"https://api.github.com/users/dcdarrell9/gists{/gist_id}","starred_url":"https://api.github.com/users/dcdarrell9/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcdarrell9/subscriptions","organizations_url":"https://api.github.com/users/dcdarrell9/orgs","repos_url":"https://api.github.com/users/dcdarrell9/repos","events_url":"https://api.github.com/users/dcdarrell9/events{/privacy}","received_events_url":"https://api.github.com/users/dcdarrell9/received_events","type":"User","site_admin":false},{"login":"andrewmil","id":22077099,"avatar_url":"https://avatars3.githubusercontent.com/u/22077099?v=4","gravatar_id":"","url":"https://api.github.com/users/andrewmil","html_url":"https://github.com/andrewmil","followers_url":"https://api.github.com/users/andrewmil/followers","following_url":"https://api.github.com/users/andrewmil/following{/other_user}","gists_url":"https://api.github.com/users/andrewmil/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewmil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewmil/subscriptions","organizations_url":"https://api.github.com/users/andrewmil/orgs","repos_url":"https://api.github.com/users/andrewmil/repos","events_url":"https://api.github.com/users/andrewmil/events{/privacy}","received_events_url":"https://api.github.com/users/andrewmil/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ONSdigital/ras-frontstage/pulls/301/commits","review_comments_url":"https://api.github.com/repos/ONSdigital/ras-frontstage/pulls/301/comments","review_comment_url":"https://api.github.com/repos/ONSdigital/ras-frontstage/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ONSdigital/ras-frontstage/issues/301/comments","statuses_url":"https://api.github.com/repos/ONSdigital/ras-frontstage/statuses/e104e42192bd2fab79c389861176d87061cef532","head":{"label":"ONSdigital:use-cdn-remove-gulp","ref":"use-cdn-remove-gulp","sha":"e104e42192bd2fab79c389861176d87061cef532","user":{"login":"ONSdigital","id":6865137,"avatar_url":"https://avatars0.githubusercontent.com/u/6865137?v=4","gravatar_id":"","url":"https://api.github.com/users/ONSdigital","html_url":"https://github.com/ONSdigital","followers_url":"https://api.github.com/users/ONSdigital/followers","following_url":"https://api.github.com/users/ONSdigital/following{/other_user}","gists_url":"https://api.github.com/users/ONSdigital/gists{/gist_id}","starred_url":"https://api.github.com/users/ONSdigital/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ONSdigital/subscriptions","organizations_url":"https://api.github.com/users/ONSdigital/orgs","repos_url":"https://api.github.com/users/ONSdigital/repos","events_url":"https://api.github.com/users/ONSdigital/events{/privacy}","received_events_url":"https://api.github.com/users/ONSdigital/received_events","type":"Organization","site_admin":false},"repo":{"id":79330497,"name":"ras-frontstage","full_name":"ONSdigital/ras-frontstage","owner":{"login":"ONSdigital","id":6865137,"avatar_url":"https://avatars0.githubusercontent.com/u/6865137?v=4","gravatar_id":"","url":"https://api.github.com/users/ONSdigital","html_url":"https://github.com/ONSdigital","followers_url":"https://api.github.com/users/ONSdigital/followers","following_url":"https://api.github.com/users/ONSdigital/following{/other_user}","gists_url":"https://api.github.com/users/ONSdigital/gists{/gist_id}","starred_url":"https://api.github.com/users/ONSdigital/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ONSdigital/subscriptions","organizations_url":"https://api.github.com/users/ONSdigital/orgs","repos_url":"https://api.github.com/users/ONSdigital/repos","events_url":"https://api.github.com/users/ONSdigital/events{/privacy}","received_events_url":"https://api.github.com/users/ONSdigital/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ONSdigital/ras-frontstage","description":"User interface for Respondent Account Services","fork":false,"url":"https://api.github.com/repos/ONSdigital/ras-frontstage","forks_url":"https://api.github.com/repos/ONSdigital/ras-frontstage/forks","keys_url":"https://api.github.com/repos/ONSdigital/ras-frontstage/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ONSdigital/ras-frontstage/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ONSdigital/ras-frontstage/teams","hooks_url":"https://api.github.com/repos/ONSdigital/ras-frontstage/hooks","issue_events_url":"https://api.github.com/repos/ONSdigital/ras-frontstage/issues/events{/number}","events_url":"https://api.github.com/repos/ONSdigital/ras-frontstage/events","assignees_url":"https://api.github.com/repos/ONSdigital/ras-frontstage/assignees{/user}","branches_url":"https://api.github.com/repos/ONSdigital/ras-frontstage/branches{/branch}","tags_url":"https://api.github.com/repos/ONSdigital/ras-frontstage/tags","blobs_url":"https://api.github.com/repos/ONSdigital/ras-frontstage/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ONSdigital/ras-frontstage/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ONSdigital/ras-frontstage/git/refs{/sha}","trees_url":"https://api.github.com/repos/ONSdigital/ras-frontstage/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ONSdigital/ras-frontstage/statuses/{sha}","languages_url":"https://api.github.com/repos/ONSdigital/ras-frontstage/languages","stargazers_url":"https://api.github.com/repos/ONSdigital/ras-frontstage/stargazers","contributors_url":"https://api.github.com/repos/ONSdigital/ras-frontstage/contributors","subscribers_url":"https://api.github.com/repos/ONSdigital/ras-frontstage/subscribers","subscription_url":"https://api.github.com/repos/ONSdigital/ras-frontstage/subscription","commits_url":"https://api.github.com/repos/ONSdigital/ras-frontstage/commits{/sha}","git_commits_url":"https://api.github.com/repos/ONSdigital/ras-frontstage/git/commits{/sha}","comments_url":"https://api.github.com/repos/ONSdigital/ras-frontstage/comments{/number}","issue_comment_url":"https://api.github.com/repos/ONSdigital/ras-frontstage/issues/comments{/number}","contents_url":"https://api.github.com/repos/ONSdigital/ras-frontstage/contents/{+path}","compare_url":"https://api.github.com/repos/ONSdigital/ras-frontstage/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ONSdigital/ras-frontstage/merges","archive_url":"https://api.github.com/repos/ONSdigital/ras-frontstage/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ONSdigital/ras-frontstage/downloads","issues_url":"https://api.github.com/repos/ONSdigital/ras-frontstage/issues{/number}","pulls_url":"https://api.github.com/repos/ONSdigital/ras-frontstage/pulls{/number}","milestones_url":"https://api.github.com/repos/ONSdigital/ras-frontstage/milestones{/number}","notifications_url":"https://api.github.com/repos/ONSdigital/ras-frontstage/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ONSdigital/ras-frontstage/labels{/name}","releases_url":"https://api.github.com/repos/ONSdigital/ras-frontstage/releases{/id}","deployments_url":"https://api.github.com/repos/ONSdigital/ras-frontstage/deployments","created_at":"2017-01-18T10:43:25Z","updated_at":"2018-04-10T13:27:06Z","pushed_at":"2018-04-11T06:57:50Z","git_url":"git://github.com/ONSdigital/ras-frontstage.git","ssh_url":"[email protected]:ONSdigital/ras-frontstage.git","clone_url":"https://github.com/ONSdigital/ras-frontstage.git","svn_url":"https://github.com/ONSdigital/ras-frontstage","homepage":null,"size":11380,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":1,"open_issues":5,"watchers":4,"default_branch":"master"}},"base":{"label":"ONSdigital:master","ref":"master","sha":"d5b8a5c9b19032b1ae0321c8dce5bb48108d1860","user":{"login":"ONSdigital","id":6865137,"avatar_url":"https://avatars0.githubusercontent.com/u/6865137?v=4","gravatar_id":"","url":"https://api.github.com/users/ONSdigital","html_url":"https://github.com/ONSdigital","followers_url":"https://api.github.com/users/ONSdigital/followers","following_url":"https://api.github.com/users/ONSdigital/following{/other_user}","gists_url":"https://api.github.com/users/ONSdigital/gists{/gist_id}","starred_url":"https://api.github.com/users/ONSdigital/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ONSdigital/subscriptions","organizations_url":"https://api.github.com/users/ONSdigital/orgs","repos_url":"https://api.github.com/users/ONSdigital/repos","events_url":"https://api.github.com/users/ONSdigital/events{/privacy}","received_events_url":"https://api.github.com/users/ONSdigital/received_events","type":"Organization","site_admin":false},"repo":{"id":79330497,"name":"ras-frontstage","full_name":"ONSdigital/ras-frontstage","owner":{"login":"ONSdigital","id":6865137,"avatar_url":"https://avatars0.githubusercontent.com/u/6865137?v=4","gravatar_id":"","url":"https://api.github.com/users/ONSdigital","html_url":"https://github.com/ONSdigital","followers_url":"https://api.github.com/users/ONSdigital/followers","following_url":"https://api.github.com/users/ONSdigital/following{/other_user}","gists_url":"https://api.github.com/users/ONSdigital/gists{/gist_id}","starred_url":"https://api.github.com/users/ONSdigital/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ONSdigital/subscriptions","organizations_url":"https://api.github.com/users/ONSdigital/orgs","repos_url":"https://api.github.com/users/ONSdigital/repos","events_url":"https://api.github.com/users/ONSdigital/events{/privacy}","received_events_url":"https://api.github.com/users/ONSdigital/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ONSdigital/ras-frontstage","description":"User interface for Respondent Account Services","fork":false,"url":"https://api.github.com/repos/ONSdigital/ras-frontstage","forks_url":"https://api.github.com/repos/ONSdigital/ras-frontstage/forks","keys_url":"https://api.github.com/repos/ONSdigital/ras-frontstage/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ONSdigital/ras-frontstage/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ONSdigital/ras-frontstage/teams","hooks_url":"https://api.github.com/repos/ONSdigital/ras-frontstage/hooks","issue_events_url":"https://api.github.com/repos/ONSdigital/ras-frontstage/issues/events{/number}","events_url":"https://api.github.com/repos/ONSdigital/ras-frontstage/events","assignees_url":"https://api.github.com/repos/ONSdigital/ras-frontstage/assignees{/user}","branches_url":"https://api.github.com/repos/ONSdigital/ras-frontstage/branches{/branch}","tags_url":"https://api.github.com/repos/ONSdigital/ras-frontstage/tags","blobs_url":"https://api.github.com/repos/ONSdigital/ras-frontstage/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ONSdigital/ras-frontstage/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ONSdigital/ras-frontstage/git/refs{/sha}","trees_url":"https://api.github.com/repos/ONSdigital/ras-frontstage/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ONSdigital/ras-frontstage/statuses/{sha}","languages_url":"https://api.github.com/repos/ONSdigital/ras-frontstage/languages","stargazers_url":"https://api.github.com/repos/ONSdigital/ras-frontstage/stargazers","contributors_url":"https://api.github.com/repos/ONSdigital/ras-frontstage/contributors","subscribers_url":"https://api.github.com/repos/ONSdigital/ras-frontstage/subscribers","subscription_url":"https://api.github.com/repos/ONSdigital/ras-frontstage/subscription","commits_url":"https://api.github.com/repos/ONSdigital/ras-frontstage/commits{/sha}","git_commits_url":"https://api.github.com/repos/ONSdigital/ras-frontstage/git/commits{/sha}","comments_url":"https://api.github.com/repos/ONSdigital/ras-frontstage/comments{/number}","issue_comment_url":"https://api.github.com/repos/ONSdigital/ras-frontstage/issues/comments{/number}","contents_url":"https://api.github.com/repos/ONSdigital/ras-frontstage/contents/{+path}","compare_url":"https://api.github.com/repos/ONSdigital/ras-frontstage/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ONSdigital/ras-frontstage/merges","archive_url":"https://api.github.com/repos/ONSdigital/ras-frontstage/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ONSdigital/ras-frontstage/downloads","issues_url":"https://api.github.com/repos/ONSdigital/ras-frontstage/issues{/number}","pulls_url":"https://api.github.com/repos/ONSdigital/ras-frontstage/pulls{/number}","milestones_url":"https://api.github.com/repos/ONSdigital/ras-frontstage/milestones{/number}","notifications_url":"https://api.github.com/repos/ONSdigital/ras-frontstage/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ONSdigital/ras-frontstage/labels{/name}","releases_url":"https://api.github.com/repos/ONSdigital/ras-frontstage/releases{/id}","deployments_url":"https://api.github.com/repos/ONSdigital/ras-frontstage/deployments","created_at":"2017-01-18T10:43:25Z","updated_at":"2018-04-10T13:27:06Z","pushed_at":"2018-04-11T06:57:50Z","git_url":"git://github.com/ONSdigital/ras-frontstage.git","ssh_url":"[email protected]:ONSdigital/ras-frontstage.git","clone_url":"https://github.com/ONSdigital/ras-frontstage.git","svn_url":"https://github.com/ONSdigital/ras-frontstage","homepage":null,"size":11380,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":1,"open_issues":5,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ONSdigital/ras-frontstage/pulls/301"},"html":{"href":"https://github.com/ONSdigital/ras-frontstage/pull/301"},"issue":{"href":"https://api.github.com/repos/ONSdigital/ras-frontstage/issues/301"},"comments":{"href":"https://api.github.com/repos/ONSdigital/ras-frontstage/issues/301/comments"},"review_comments":{"href":"https://api.github.com/repos/ONSdigital/ras-frontstage/pulls/301/comments"},"review_comment":{"href":"https://api.github.com/repos/ONSdigital/ras-frontstage/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ONSdigital/ras-frontstage/pulls/301/commits"},"statuses":{"href":"https://api.github.com/repos/ONSdigital/ras-frontstage/statuses/e104e42192bd2fab79c389861176d87061cef532"}},"author_association":"CONTRIBUTOR"}} | {
"id": 79330497,
"name": "ONSdigital/ras-frontstage",
"url": "https://api.github.com/repos/ONSdigital/ras-frontstage"
} | {
"id": 22023945,
"login": "rhiGriff",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/22023945?",
"url": "https://api.github.com/users/rhiGriff"
} | {
"id": 6865137,
"login": "ONSdigital",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6865137?",
"url": "https://api.github.com/orgs/ONSdigital"
} | 2018-04-11T06:59:49 | 7511531278 | {"actor":{"display_login":"rhiGriff"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/ONSdigital/eq-author-api/pulls/comments/230756013","pull_request_review_id":171562868,"id":230756013,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMDc1NjAxMw==","diff_hunk":"@@ -65,10 +65,17 @@ const Resolvers = {\n await Resolvers.Mutation.createPage(root, { input: page }, ctx);\n return section;\n },\n- updateSection: (_, args, ctx) =>\n- ctx.repositories.Section.update(args.input),\n- deleteSection: (_, args, ctx) =>\n- ctx.repositories.Section.remove(args.input.id),\n+ updateSection: (_, { input }, ctx) => {\n+ if (!input.introductionEnabled) {","path":"schema/resolvers.js","position":9,"original_position":9,"commit_id":"6bb9a2731b04d08421f8a3ca463c16347114e371","original_commit_id":"6bb9a2731b04d08421f8a3ca463c16347114e371","user":{"login":"rmccar","id":42928680,"node_id":"MDQ6VXNlcjQyOTI4Njgw","avatar_url":"https://avatars0.githubusercontent.com/u/42928680?v=4","gravatar_id":"","url":"https://api.github.com/users/rmccar","html_url":"https://github.com/rmccar","followers_url":"https://api.github.com/users/rmccar/followers","following_url":"https://api.github.com/users/rmccar/following{/other_user}","gists_url":"https://api.github.com/users/rmccar/gists{/gist_id}","starred_url":"https://api.github.com/users/rmccar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmccar/subscriptions","organizations_url":"https://api.github.com/users/rmccar/orgs","repos_url":"https://api.github.com/users/rmccar/repos","events_url":"https://api.github.com/users/rmccar/events{/privacy}","received_events_url":"https://api.github.com/users/rmccar/received_events","type":"User","site_admin":false},"body":"Discussed with Tom and SamG. Decided that this was the best way forward for this for now as the best solution we came up with was to change the entity editor to accept arrays. This was considered beyond the scope of this PR so will be handled as a separate piece of tech debt","created_at":"2018-11-05T13:53:25Z","updated_at":"2018-11-05T13:53:25Z","html_url":"https://github.com/ONSdigital/eq-author-api/pull/172#discussion_r230756013","pull_request_url":"https://api.github.com/repos/ONSdigital/eq-author-api/pulls/172","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ONSdigital/eq-author-api/pulls/comments/230756013"},"html":{"href":"https://github.com/ONSdigital/eq-author-api/pull/172#discussion_r230756013"},"pull_request":{"href":"https://api.github.com/repos/ONSdigital/eq-author-api/pulls/172"}},"in_reply_to_id":230699013},"pull_request":{"url":"https://api.github.com/repos/ONSdigital/eq-author-api/pulls/172","id":226886610,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2ODg2NjEw","html_url":"https://github.com/ONSdigital/eq-author-api/pull/172","diff_url":"https://github.com/ONSdigital/eq-author-api/pull/172.diff","patch_url":"https://github.com/ONSdigital/eq-author-api/pull/172.patch","issue_url":"https://api.github.com/repos/ONSdigital/eq-author-api/issues/172","number":172,"state":"open","locked":false,"title":"Section Introduction","user":{"login":"SamGodwin2","id":35268220,"node_id":"MDQ6VXNlcjM1MjY4MjIw","avatar_url":"https://avatars2.githubusercontent.com/u/35268220?v=4","gravatar_id":"","url":"https://api.github.com/users/SamGodwin2","html_url":"https://github.com/SamGodwin2","followers_url":"https://api.github.com/users/SamGodwin2/followers","following_url":"https://api.github.com/users/SamGodwin2/following{/other_user}","gists_url":"https://api.github.com/users/SamGodwin2/gists{/gist_id}","starred_url":"https://api.github.com/users/SamGodwin2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SamGodwin2/subscriptions","organizations_url":"https://api.github.com/users/SamGodwin2/orgs","repos_url":"https://api.github.com/users/SamGodwin2/repos","events_url":"https://api.github.com/users/SamGodwin2/events{/privacy}","received_events_url":"https://api.github.com/users/SamGodwin2/received_events","type":"User","site_admin":false},"body":"### What is the context of this PR?\r\nCouple issues in the api meant that the section introduction resolvers weren't working correctly. This PR address those issues.\r\n\r\n### How to review \r\nNew tests pass and e2e implementation passes.\r\n","created_at":"2018-10-30T11:36:02Z","updated_at":"2018-11-05T13:53:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c67d4d30b58946ad1e4aeca0d657ffc58307e2a4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ONSdigital/eq-author-api/pulls/172/commits","review_comments_url":"https://api.github.com/repos/ONSdigital/eq-author-api/pulls/172/comments","review_comment_url":"https://api.github.com/repos/ONSdigital/eq-author-api/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ONSdigital/eq-author-api/issues/172/comments","statuses_url":"https://api.github.com/repos/ONSdigital/eq-author-api/statuses/6bb9a2731b04d08421f8a3ca463c16347114e371","head":{"label":"ONSdigital:683-section-introduction-page-api-part-2","ref":"683-section-introduction-page-api-part-2","sha":"6bb9a2731b04d08421f8a3ca463c16347114e371","user":{"login":"ONSdigital","id":6865137,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NjUxMzc=","avatar_url":"https://avatars0.githubusercontent.com/u/6865137?v=4","gravatar_id":"","url":"https://api.github.com/users/ONSdigital","html_url":"https://github.com/ONSdigital","followers_url":"https://api.github.com/users/ONSdigital/followers","following_url":"https://api.github.com/users/ONSdigital/following{/other_user}","gists_url":"https://api.github.com/users/ONSdigital/gists{/gist_id}","starred_url":"https://api.github.com/users/ONSdigital/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ONSdigital/subscriptions","organizations_url":"https://api.github.com/users/ONSdigital/orgs","repos_url":"https://api.github.com/users/ONSdigital/repos","events_url":"https://api.github.com/users/ONSdigital/events{/privacy}","received_events_url":"https://api.github.com/users/ONSdigital/received_events","type":"Organization","site_admin":false},"repo":{"id":92409567,"node_id":"MDEwOlJlcG9zaXRvcnk5MjQwOTU2Nw==","name":"eq-author-api","full_name":"ONSdigital/eq-author-api","private":false,"owner":{"login":"ONSdigital","id":6865137,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NjUxMzc=","avatar_url":"https://avatars0.githubusercontent.com/u/6865137?v=4","gravatar_id":"","url":"https://api.github.com/users/ONSdigital","html_url":"https://github.com/ONSdigital","followers_url":"https://api.github.com/users/ONSdigital/followers","following_url":"https://api.github.com/users/ONSdigital/following{/other_user}","gists_url":"https://api.github.com/users/ONSdigital/gists{/gist_id}","starred_url":"https://api.github.com/users/ONSdigital/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ONSdigital/subscriptions","organizations_url":"https://api.github.com/users/ONSdigital/orgs","repos_url":"https://api.github.com/users/ONSdigital/repos","events_url":"https://api.github.com/users/ONSdigital/events{/privacy}","received_events_url":"https://api.github.com/users/ONSdigital/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ONSdigital/eq-author-api","description":"A backend API for the eq-author application.","fork":false,"url":"https://api.github.com/repos/ONSdigital/eq-author-api","forks_url":"https://api.github.com/repos/ONSdigital/eq-author-api/forks","keys_url":"https://api.github.com/repos/ONSdigital/eq-author-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ONSdigital/eq-author-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ONSdigital/eq-author-api/teams","hooks_url":"https://api.github.com/repos/ONSdigital/eq-author-api/hooks","issue_events_url":"https://api.github.com/repos/ONSdigital/eq-author-api/issues/events{/number}","events_url":"https://api.github.com/repos/ONSdigital/eq-author-api/events","assignees_url":"https://api.github.com/repos/ONSdigital/eq-author-api/assignees{/user}","branches_url":"https://api.github.com/repos/ONSdigital/eq-author-api/branches{/branch}","tags_url":"https://api.github.com/repos/ONSdigital/eq-author-api/tags","blobs_url":"https://api.github.com/repos/ONSdigital/eq-author-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ONSdigital/eq-author-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ONSdigital/eq-author-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/ONSdigital/eq-author-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ONSdigital/eq-author-api/statuses/{sha}","languages_url":"https://api.github.com/repos/ONSdigital/eq-author-api/languages","stargazers_url":"https://api.github.com/repos/ONSdigital/eq-author-api/stargazers","contributors_url":"https://api.github.com/repos/ONSdigital/eq-author-api/contributors","subscribers_url":"https://api.github.com/repos/ONSdigital/eq-author-api/subscribers","subscription_url":"https://api.github.com/repos/ONSdigital/eq-author-api/subscription","commits_url":"https://api.github.com/repos/ONSdigital/eq-author-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/ONSdigital/eq-author-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/ONSdigital/eq-author-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/ONSdigital/eq-author-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/ONSdigital/eq-author-api/contents/{+path}","compare_url":"https://api.github.com/repos/ONSdigital/eq-author-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ONSdigital/eq-author-api/merges","archive_url":"https://api.github.com/repos/ONSdigital/eq-author-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ONSdigital/eq-author-api/downloads","issues_url":"https://api.github.com/repos/ONSdigital/eq-author-api/issues{/number}","pulls_url":"https://api.github.com/repos/ONSdigital/eq-author-api/pulls{/number}","milestones_url":"https://api.github.com/repos/ONSdigital/eq-author-api/milestones{/number}","notifications_url":"https://api.github.com/repos/ONSdigital/eq-author-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ONSdigital/eq-author-api/labels{/name}","releases_url":"https://api.github.com/repos/ONSdigital/eq-author-api/releases{/id}","deployments_url":"https://api.github.com/repos/ONSdigital/eq-author-api/deployments","created_at":"2017-05-25T14:07:17Z","updated_at":"2018-11-02T14:48:26Z","pushed_at":"2018-11-05T11:37:01Z","git_url":"git://github.com/ONSdigital/eq-author-api.git","ssh_url":"[email protected]:ONSdigital/eq-author-api.git","clone_url":"https://github.com/ONSdigital/eq-author-api.git","svn_url":"https://github.com/ONSdigital/eq-author-api","homepage":"http://eq-author-api.apps.devtest.onsclofo.uk/graphiql","size":1393,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":6,"license":null,"forks":0,"open_issues":6,"watchers":2,"default_branch":"master"}},"base":{"label":"ONSdigital:master","ref":"master","sha":"78b9ba039ee9037a4ba2a4a56fd03905b7465a18","user":{"login":"ONSdigital","id":6865137,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NjUxMzc=","avatar_url":"https://avatars0.githubusercontent.com/u/6865137?v=4","gravatar_id":"","url":"https://api.github.com/users/ONSdigital","html_url":"https://github.com/ONSdigital","followers_url":"https://api.github.com/users/ONSdigital/followers","following_url":"https://api.github.com/users/ONSdigital/following{/other_user}","gists_url":"https://api.github.com/users/ONSdigital/gists{/gist_id}","starred_url":"https://api.github.com/users/ONSdigital/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ONSdigital/subscriptions","organizations_url":"https://api.github.com/users/ONSdigital/orgs","repos_url":"https://api.github.com/users/ONSdigital/repos","events_url":"https://api.github.com/users/ONSdigital/events{/privacy}","received_events_url":"https://api.github.com/users/ONSdigital/received_events","type":"Organization","site_admin":false},"repo":{"id":92409567,"node_id":"MDEwOlJlcG9zaXRvcnk5MjQwOTU2Nw==","name":"eq-author-api","full_name":"ONSdigital/eq-author-api","private":false,"owner":{"login":"ONSdigital","id":6865137,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NjUxMzc=","avatar_url":"https://avatars0.githubusercontent.com/u/6865137?v=4","gravatar_id":"","url":"https://api.github.com/users/ONSdigital","html_url":"https://github.com/ONSdigital","followers_url":"https://api.github.com/users/ONSdigital/followers","following_url":"https://api.github.com/users/ONSdigital/following{/other_user}","gists_url":"https://api.github.com/users/ONSdigital/gists{/gist_id}","starred_url":"https://api.github.com/users/ONSdigital/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ONSdigital/subscriptions","organizations_url":"https://api.github.com/users/ONSdigital/orgs","repos_url":"https://api.github.com/users/ONSdigital/repos","events_url":"https://api.github.com/users/ONSdigital/events{/privacy}","received_events_url":"https://api.github.com/users/ONSdigital/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ONSdigital/eq-author-api","description":"A backend API for the eq-author application.","fork":false,"url":"https://api.github.com/repos/ONSdigital/eq-author-api","forks_url":"https://api.github.com/repos/ONSdigital/eq-author-api/forks","keys_url":"https://api.github.com/repos/ONSdigital/eq-author-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ONSdigital/eq-author-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ONSdigital/eq-author-api/teams","hooks_url":"https://api.github.com/repos/ONSdigital/eq-author-api/hooks","issue_events_url":"https://api.github.com/repos/ONSdigital/eq-author-api/issues/events{/number}","events_url":"https://api.github.com/repos/ONSdigital/eq-author-api/events","assignees_url":"https://api.github.com/repos/ONSdigital/eq-author-api/assignees{/user}","branches_url":"https://api.github.com/repos/ONSdigital/eq-author-api/branches{/branch}","tags_url":"https://api.github.com/repos/ONSdigital/eq-author-api/tags","blobs_url":"https://api.github.com/repos/ONSdigital/eq-author-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ONSdigital/eq-author-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ONSdigital/eq-author-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/ONSdigital/eq-author-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ONSdigital/eq-author-api/statuses/{sha}","languages_url":"https://api.github.com/repos/ONSdigital/eq-author-api/languages","stargazers_url":"https://api.github.com/repos/ONSdigital/eq-author-api/stargazers","contributors_url":"https://api.github.com/repos/ONSdigital/eq-author-api/contributors","subscribers_url":"https://api.github.com/repos/ONSdigital/eq-author-api/subscribers","subscription_url":"https://api.github.com/repos/ONSdigital/eq-author-api/subscription","commits_url":"https://api.github.com/repos/ONSdigital/eq-author-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/ONSdigital/eq-author-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/ONSdigital/eq-author-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/ONSdigital/eq-author-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/ONSdigital/eq-author-api/contents/{+path}","compare_url":"https://api.github.com/repos/ONSdigital/eq-author-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ONSdigital/eq-author-api/merges","archive_url":"https://api.github.com/repos/ONSdigital/eq-author-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ONSdigital/eq-author-api/downloads","issues_url":"https://api.github.com/repos/ONSdigital/eq-author-api/issues{/number}","pulls_url":"https://api.github.com/repos/ONSdigital/eq-author-api/pulls{/number}","milestones_url":"https://api.github.com/repos/ONSdigital/eq-author-api/milestones{/number}","notifications_url":"https://api.github.com/repos/ONSdigital/eq-author-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ONSdigital/eq-author-api/labels{/name}","releases_url":"https://api.github.com/repos/ONSdigital/eq-author-api/releases{/id}","deployments_url":"https://api.github.com/repos/ONSdigital/eq-author-api/deployments","created_at":"2017-05-25T14:07:17Z","updated_at":"2018-11-02T14:48:26Z","pushed_at":"2018-11-05T11:37:01Z","git_url":"git://github.com/ONSdigital/eq-author-api.git","ssh_url":"[email protected]:ONSdigital/eq-author-api.git","clone_url":"https://github.com/ONSdigital/eq-author-api.git","svn_url":"https://github.com/ONSdigital/eq-author-api","homepage":"http://eq-author-api.apps.devtest.onsclofo.uk/graphiql","size":1393,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":6,"license":null,"forks":0,"open_issues":6,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ONSdigital/eq-author-api/pulls/172"},"html":{"href":"https://github.com/ONSdigital/eq-author-api/pull/172"},"issue":{"href":"https://api.github.com/repos/ONSdigital/eq-author-api/issues/172"},"comments":{"href":"https://api.github.com/repos/ONSdigital/eq-author-api/issues/172/comments"},"review_comments":{"href":"https://api.github.com/repos/ONSdigital/eq-author-api/pulls/172/comments"},"review_comment":{"href":"https://api.github.com/repos/ONSdigital/eq-author-api/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ONSdigital/eq-author-api/pulls/172/commits"},"statuses":{"href":"https://api.github.com/repos/ONSdigital/eq-author-api/statuses/6bb9a2731b04d08421f8a3ca463c16347114e371"}},"author_association":"CONTRIBUTOR"}} | {
"id": 92409567,
"name": "ONSdigital/eq-author-api",
"url": "https://api.github.com/repos/ONSdigital/eq-author-api"
} | {
"id": 42928680,
"login": "rmccar",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/42928680?",
"url": "https://api.github.com/users/rmccar"
} | {
"id": 6865137,
"login": "ONSdigital",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6865137?",
"url": "https://api.github.com/orgs/ONSdigital"
} | 2018-11-05T13:53:25 | 8535821010 | {"actor":{"display_login":"rmccar"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/ONSdigital/registers-react-library/pulls/comments/180707604","pull_request_review_id":111171863,"id":180707604,"diff_hunk":"@@ -0,0 +1,37 @@\n+import React from 'react';\n+import { shallow, mount, render } from 'enzyme';\n+import { expect } from 'chai';\n+import sinon from 'sinon';\n+import Pagination from '../../components/internal/Pagination';\n+\n+ // Shallow Rendering\n+ // https://github.com/airbnb/enzyme/blob/master/docs/api/shallow.md\n+describe('Pagination - Shallow Rendering', () => {\n+ it('to have the correct number of Pagination classes', () => {\n+ const wrapper = shallow(\n+ <Pagination\n+ onChange={() => alert('Switch Page...')}\n+ page={3}\n+ pagesize={4}\n+ numPages={6}\n+ />,\n+ );\n+ expect(wrapper.find('.mars')).to.have.length(2);\n+ });\n+});\n+\n+ // Static Rendered Markup\n+ // https://github.com/airbnb/enzyme/blob/master/docs/api/render.md\n+describe('Pagination - Static Rendered Markup', () => {\n+ it('renders the correct number of items?', () => {\n+ const wrapper = render(\n+ <Pagination\n+ onChange={() => alert('Switch Page...')}\n+ page={3}\n+ pagesize={4}\n+ numPages={6}\n+ />,\n+ );\n+ expect(wrapper.find('.mars').length).to.equal(2);","path":"src/__tests__/internal/Pagination.js","position":35,"original_position":35,"commit_id":"63880322cf829c3e4e096648215e611e6a34a066","original_commit_id":"63880322cf829c3e4e096648215e611e6a34a066","user":{"login":"ONS-Tom","id":23335263,"avatar_url":"https://avatars0.githubusercontent.com/u/23335263?v=4","gravatar_id":"","url":"https://api.github.com/users/ONS-Tom","html_url":"https://github.com/ONS-Tom","followers_url":"https://api.github.com/users/ONS-Tom/followers","following_url":"https://api.github.com/users/ONS-Tom/following{/other_user}","gists_url":"https://api.github.com/users/ONS-Tom/gists{/gist_id}","starred_url":"https://api.github.com/users/ONS-Tom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ONS-Tom/subscriptions","organizations_url":"https://api.github.com/users/ONS-Tom/orgs","repos_url":"https://api.github.com/users/ONS-Tom/repos","events_url":"https://api.github.com/users/ONS-Tom/events{/privacy}","received_events_url":"https://api.github.com/users/ONS-Tom/received_events","type":"User","site_admin":false},"body":"This should check that there are 4 items present on a page, at the moment you are checking that both pagination buttons (next/prev) are present","created_at":"2018-04-11T10:34:15Z","updated_at":"2018-04-11T10:39:31Z","html_url":"https://github.com/ONSdigital/registers-react-library/pull/12#discussion_r180707604","pull_request_url":"https://api.github.com/repos/ONSdigital/registers-react-library/pulls/12","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ONSdigital/registers-react-library/pulls/comments/180707604"},"html":{"href":"https://github.com/ONSdigital/registers-react-library/pull/12#discussion_r180707604"},"pull_request":{"href":"https://api.github.com/repos/ONSdigital/registers-react-library/pulls/12"}}},"pull_request":{"url":"https://api.github.com/repos/ONSdigital/registers-react-library/pulls/12","id":180852197,"html_url":"https://github.com/ONSdigital/registers-react-library/pull/12","diff_url":"https://github.com/ONSdigital/registers-react-library/pull/12.diff","patch_url":"https://github.com/ONSdigital/registers-react-library/pull/12.patch","issue_url":"https://api.github.com/repos/ONSdigital/registers-react-library/issues/12","number":12,"state":"open","locked":false,"title":"Feature/internal styles","user":{"login":"urquha","id":35800749,"avatar_url":"https://avatars3.githubusercontent.com/u/35800749?v=4","gravatar_id":"","url":"https://api.github.com/users/urquha","html_url":"https://github.com/urquha","followers_url":"https://api.github.com/users/urquha/followers","following_url":"https://api.github.com/users/urquha/following{/other_user}","gists_url":"https://api.github.com/users/urquha/gists{/gist_id}","starred_url":"https://api.github.com/users/urquha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/urquha/subscriptions","organizations_url":"https://api.github.com/users/urquha/orgs","repos_url":"https://api.github.com/users/urquha/repos","events_url":"https://api.github.com/users/urquha/events{/privacy}","received_events_url":"https://api.github.com/users/urquha/received_events","type":"User","site_admin":false},"body":"Add new UI components to react pattern library.\r\n\r\n- Added Ui components from BI-UI to registers-react-library.\r\n- Made tests for said components.","created_at":"2018-04-11T10:07:20Z","updated_at":"2018-04-11T10:39:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"275426ea7d33550477430929eac60d8b442c3c6a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ONSdigital/registers-react-library/pulls/12/commits","review_comments_url":"https://api.github.com/repos/ONSdigital/registers-react-library/pulls/12/comments","review_comment_url":"https://api.github.com/repos/ONSdigital/registers-react-library/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ONSdigital/registers-react-library/issues/12/comments","statuses_url":"https://api.github.com/repos/ONSdigital/registers-react-library/statuses/63880322cf829c3e4e096648215e611e6a34a066","head":{"label":"ONSdigital:feature/internal-styles","ref":"feature/internal-styles","sha":"63880322cf829c3e4e096648215e611e6a34a066","user":{"login":"ONSdigital","id":6865137,"avatar_url":"https://avatars0.githubusercontent.com/u/6865137?v=4","gravatar_id":"","url":"https://api.github.com/users/ONSdigital","html_url":"https://github.com/ONSdigital","followers_url":"https://api.github.com/users/ONSdigital/followers","following_url":"https://api.github.com/users/ONSdigital/following{/other_user}","gists_url":"https://api.github.com/users/ONSdigital/gists{/gist_id}","starred_url":"https://api.github.com/users/ONSdigital/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ONSdigital/subscriptions","organizations_url":"https://api.github.com/users/ONSdigital/orgs","repos_url":"https://api.github.com/users/ONSdigital/repos","events_url":"https://api.github.com/users/ONSdigital/events{/privacy}","received_events_url":"https://api.github.com/users/ONSdigital/received_events","type":"Organization","site_admin":false},"repo":{"id":107095573,"name":"registers-react-library","full_name":"ONSdigital/registers-react-library","owner":{"login":"ONSdigital","id":6865137,"avatar_url":"https://avatars0.githubusercontent.com/u/6865137?v=4","gravatar_id":"","url":"https://api.github.com/users/ONSdigital","html_url":"https://github.com/ONSdigital","followers_url":"https://api.github.com/users/ONSdigital/followers","following_url":"https://api.github.com/users/ONSdigital/following{/other_user}","gists_url":"https://api.github.com/users/ONSdigital/gists{/gist_id}","starred_url":"https://api.github.com/users/ONSdigital/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ONSdigital/subscriptions","organizations_url":"https://api.github.com/users/ONSdigital/orgs","repos_url":"https://api.github.com/users/ONSdigital/repos","events_url":"https://api.github.com/users/ONSdigital/events{/privacy}","received_events_url":"https://api.github.com/users/ONSdigital/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ONSdigital/registers-react-library","description":"React library for common components across Registers user interfaces","fork":false,"url":"https://api.github.com/repos/ONSdigital/registers-react-library","forks_url":"https://api.github.com/repos/ONSdigital/registers-react-library/forks","keys_url":"https://api.github.com/repos/ONSdigital/registers-react-library/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ONSdigital/registers-react-library/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ONSdigital/registers-react-library/teams","hooks_url":"https://api.github.com/repos/ONSdigital/registers-react-library/hooks","issue_events_url":"https://api.github.com/repos/ONSdigital/registers-react-library/issues/events{/number}","events_url":"https://api.github.com/repos/ONSdigital/registers-react-library/events","assignees_url":"https://api.github.com/repos/ONSdigital/registers-react-library/assignees{/user}","branches_url":"https://api.github.com/repos/ONSdigital/registers-react-library/branches{/branch}","tags_url":"https://api.github.com/repos/ONSdigital/registers-react-library/tags","blobs_url":"https://api.github.com/repos/ONSdigital/registers-react-library/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ONSdigital/registers-react-library/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ONSdigital/registers-react-library/git/refs{/sha}","trees_url":"https://api.github.com/repos/ONSdigital/registers-react-library/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ONSdigital/registers-react-library/statuses/{sha}","languages_url":"https://api.github.com/repos/ONSdigital/registers-react-library/languages","stargazers_url":"https://api.github.com/repos/ONSdigital/registers-react-library/stargazers","contributors_url":"https://api.github.com/repos/ONSdigital/registers-react-library/contributors","subscribers_url":"https://api.github.com/repos/ONSdigital/registers-react-library/subscribers","subscription_url":"https://api.github.com/repos/ONSdigital/registers-react-library/subscription","commits_url":"https://api.github.com/repos/ONSdigital/registers-react-library/commits{/sha}","git_commits_url":"https://api.github.com/repos/ONSdigital/registers-react-library/git/commits{/sha}","comments_url":"https://api.github.com/repos/ONSdigital/registers-react-library/comments{/number}","issue_comment_url":"https://api.github.com/repos/ONSdigital/registers-react-library/issues/comments{/number}","contents_url":"https://api.github.com/repos/ONSdigital/registers-react-library/contents/{+path}","compare_url":"https://api.github.com/repos/ONSdigital/registers-react-library/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ONSdigital/registers-react-library/merges","archive_url":"https://api.github.com/repos/ONSdigital/registers-react-library/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ONSdigital/registers-react-library/downloads","issues_url":"https://api.github.com/repos/ONSdigital/registers-react-library/issues{/number}","pulls_url":"https://api.github.com/repos/ONSdigital/registers-react-library/pulls{/number}","milestones_url":"https://api.github.com/repos/ONSdigital/registers-react-library/milestones{/number}","notifications_url":"https://api.github.com/repos/ONSdigital/registers-react-library/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ONSdigital/registers-react-library/labels{/name}","releases_url":"https://api.github.com/repos/ONSdigital/registers-react-library/releases{/id}","deployments_url":"https://api.github.com/repos/ONSdigital/registers-react-library/deployments","created_at":"2017-10-16T07:53:02Z","updated_at":"2017-10-18T08:31:15Z","pushed_at":"2018-04-11T10:07:20Z","git_url":"git://github.com/ONSdigital/registers-react-library.git","ssh_url":"[email protected]:ONSdigital/registers-react-library.git","clone_url":"https://github.com/ONSdigital/registers-react-library.git","svn_url":"https://github.com/ONSdigital/registers-react-library","homepage":"https://onsdigital.github.io/registers-react-library","size":690,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":1,"open_issues":2,"watchers":0,"default_branch":"develop"}},"base":{"label":"ONSdigital:develop","ref":"develop","sha":"f0ed46b6be9fd10b04f4efc53e844fa0b8fc2dea","user":{"login":"ONSdigital","id":6865137,"avatar_url":"https://avatars0.githubusercontent.com/u/6865137?v=4","gravatar_id":"","url":"https://api.github.com/users/ONSdigital","html_url":"https://github.com/ONSdigital","followers_url":"https://api.github.com/users/ONSdigital/followers","following_url":"https://api.github.com/users/ONSdigital/following{/other_user}","gists_url":"https://api.github.com/users/ONSdigital/gists{/gist_id}","starred_url":"https://api.github.com/users/ONSdigital/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ONSdigital/subscriptions","organizations_url":"https://api.github.com/users/ONSdigital/orgs","repos_url":"https://api.github.com/users/ONSdigital/repos","events_url":"https://api.github.com/users/ONSdigital/events{/privacy}","received_events_url":"https://api.github.com/users/ONSdigital/received_events","type":"Organization","site_admin":false},"repo":{"id":107095573,"name":"registers-react-library","full_name":"ONSdigital/registers-react-library","owner":{"login":"ONSdigital","id":6865137,"avatar_url":"https://avatars0.githubusercontent.com/u/6865137?v=4","gravatar_id":"","url":"https://api.github.com/users/ONSdigital","html_url":"https://github.com/ONSdigital","followers_url":"https://api.github.com/users/ONSdigital/followers","following_url":"https://api.github.com/users/ONSdigital/following{/other_user}","gists_url":"https://api.github.com/users/ONSdigital/gists{/gist_id}","starred_url":"https://api.github.com/users/ONSdigital/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ONSdigital/subscriptions","organizations_url":"https://api.github.com/users/ONSdigital/orgs","repos_url":"https://api.github.com/users/ONSdigital/repos","events_url":"https://api.github.com/users/ONSdigital/events{/privacy}","received_events_url":"https://api.github.com/users/ONSdigital/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ONSdigital/registers-react-library","description":"React library for common components across Registers user interfaces","fork":false,"url":"https://api.github.com/repos/ONSdigital/registers-react-library","forks_url":"https://api.github.com/repos/ONSdigital/registers-react-library/forks","keys_url":"https://api.github.com/repos/ONSdigital/registers-react-library/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ONSdigital/registers-react-library/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ONSdigital/registers-react-library/teams","hooks_url":"https://api.github.com/repos/ONSdigital/registers-react-library/hooks","issue_events_url":"https://api.github.com/repos/ONSdigital/registers-react-library/issues/events{/number}","events_url":"https://api.github.com/repos/ONSdigital/registers-react-library/events","assignees_url":"https://api.github.com/repos/ONSdigital/registers-react-library/assignees{/user}","branches_url":"https://api.github.com/repos/ONSdigital/registers-react-library/branches{/branch}","tags_url":"https://api.github.com/repos/ONSdigital/registers-react-library/tags","blobs_url":"https://api.github.com/repos/ONSdigital/registers-react-library/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ONSdigital/registers-react-library/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ONSdigital/registers-react-library/git/refs{/sha}","trees_url":"https://api.github.com/repos/ONSdigital/registers-react-library/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ONSdigital/registers-react-library/statuses/{sha}","languages_url":"https://api.github.com/repos/ONSdigital/registers-react-library/languages","stargazers_url":"https://api.github.com/repos/ONSdigital/registers-react-library/stargazers","contributors_url":"https://api.github.com/repos/ONSdigital/registers-react-library/contributors","subscribers_url":"https://api.github.com/repos/ONSdigital/registers-react-library/subscribers","subscription_url":"https://api.github.com/repos/ONSdigital/registers-react-library/subscription","commits_url":"https://api.github.com/repos/ONSdigital/registers-react-library/commits{/sha}","git_commits_url":"https://api.github.com/repos/ONSdigital/registers-react-library/git/commits{/sha}","comments_url":"https://api.github.com/repos/ONSdigital/registers-react-library/comments{/number}","issue_comment_url":"https://api.github.com/repos/ONSdigital/registers-react-library/issues/comments{/number}","contents_url":"https://api.github.com/repos/ONSdigital/registers-react-library/contents/{+path}","compare_url":"https://api.github.com/repos/ONSdigital/registers-react-library/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ONSdigital/registers-react-library/merges","archive_url":"https://api.github.com/repos/ONSdigital/registers-react-library/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ONSdigital/registers-react-library/downloads","issues_url":"https://api.github.com/repos/ONSdigital/registers-react-library/issues{/number}","pulls_url":"https://api.github.com/repos/ONSdigital/registers-react-library/pulls{/number}","milestones_url":"https://api.github.com/repos/ONSdigital/registers-react-library/milestones{/number}","notifications_url":"https://api.github.com/repos/ONSdigital/registers-react-library/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ONSdigital/registers-react-library/labels{/name}","releases_url":"https://api.github.com/repos/ONSdigital/registers-react-library/releases{/id}","deployments_url":"https://api.github.com/repos/ONSdigital/registers-react-library/deployments","created_at":"2017-10-16T07:53:02Z","updated_at":"2017-10-18T08:31:15Z","pushed_at":"2018-04-11T10:07:20Z","git_url":"git://github.com/ONSdigital/registers-react-library.git","ssh_url":"[email protected]:ONSdigital/registers-react-library.git","clone_url":"https://github.com/ONSdigital/registers-react-library.git","svn_url":"https://github.com/ONSdigital/registers-react-library","homepage":"https://onsdigital.github.io/registers-react-library","size":690,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":1,"open_issues":2,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/ONSdigital/registers-react-library/pulls/12"},"html":{"href":"https://github.com/ONSdigital/registers-react-library/pull/12"},"issue":{"href":"https://api.github.com/repos/ONSdigital/registers-react-library/issues/12"},"comments":{"href":"https://api.github.com/repos/ONSdigital/registers-react-library/issues/12/comments"},"review_comments":{"href":"https://api.github.com/repos/ONSdigital/registers-react-library/pulls/12/comments"},"review_comment":{"href":"https://api.github.com/repos/ONSdigital/registers-react-library/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ONSdigital/registers-react-library/pulls/12/commits"},"statuses":{"href":"https://api.github.com/repos/ONSdigital/registers-react-library/statuses/63880322cf829c3e4e096648215e611e6a34a066"}},"author_association":"NONE"}} | {
"id": 107095573,
"name": "ONSdigital/registers-react-library",
"url": "https://api.github.com/repos/ONSdigital/registers-react-library"
} | {
"id": 23335263,
"login": "ONS-Tom",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/23335263?",
"url": "https://api.github.com/users/ONS-Tom"
} | {
"id": 6865137,
"login": "ONSdigital",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6865137?",
"url": "https://api.github.com/orgs/ONSdigital"
} | 2018-04-11T10:34:15 | 7512652287 | {"actor":{"display_login":"ONS-Tom"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/apprenda/kismatic/pulls/comments/173557234","pull_request_review_id":102776248,"id":173557234,"diff_hunk":"@@ -0,0 +1,10 @@\n+FROM python:2\n+\n+WORKDIR /root/kismatic\n+EXPOSE 8080 8443","path":"Dockerfile","position":4,"original_position":4,"commit_id":"5259cbea9d2bfa3754784617206a8b3404ff3595","original_commit_id":"5259cbea9d2bfa3754784617206a8b3404ff3595","user":{"login":"dkoshkin","id":4969231,"avatar_url":"https://avatars1.githubusercontent.com/u/4969231?v=4","gravatar_id":"","url":"https://api.github.com/users/dkoshkin","html_url":"https://github.com/dkoshkin","followers_url":"https://api.github.com/users/dkoshkin/followers","following_url":"https://api.github.com/users/dkoshkin/following{/other_user}","gists_url":"https://api.github.com/users/dkoshkin/gists{/gist_id}","starred_url":"https://api.github.com/users/dkoshkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dkoshkin/subscriptions","organizations_url":"https://api.github.com/users/dkoshkin/orgs","repos_url":"https://api.github.com/users/dkoshkin/repos","events_url":"https://api.github.com/users/dkoshkin/events{/privacy}","received_events_url":"https://api.github.com/users/dkoshkin/received_events","type":"User","site_admin":false},"body":"Need to add `8001`","created_at":"2018-03-09T20:18:00Z","updated_at":"2018-03-09T20:18:00Z","html_url":"https://github.com/apprenda/kismatic/pull/1126#discussion_r173557234","pull_request_url":"https://api.github.com/repos/apprenda/kismatic/pulls/1126","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apprenda/kismatic/pulls/comments/173557234"},"html":{"href":"https://github.com/apprenda/kismatic/pull/1126#discussion_r173557234"},"pull_request":{"href":"https://api.github.com/repos/apprenda/kismatic/pulls/1126"}}},"pull_request":{"url":"https://api.github.com/repos/apprenda/kismatic/pulls/1126","id":170611472,"html_url":"https://github.com/apprenda/kismatic/pull/1126","diff_url":"https://github.com/apprenda/kismatic/pull/1126.diff","patch_url":"https://github.com/apprenda/kismatic/pull/1126.patch","issue_url":"https://api.github.com/repos/apprenda/kismatic/issues/1126","number":1126,"state":"open","locked":false,"title":"Dockerize kismatic","user":{"login":"emmetthitz","id":6633471,"avatar_url":"https://avatars2.githubusercontent.com/u/6633471?v=4","gravatar_id":"","url":"https://api.github.com/users/emmetthitz","html_url":"https://github.com/emmetthitz","followers_url":"https://api.github.com/users/emmetthitz/followers","following_url":"https://api.github.com/users/emmetthitz/following{/other_user}","gists_url":"https://api.github.com/users/emmetthitz/gists{/gist_id}","starred_url":"https://api.github.com/users/emmetthitz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emmetthitz/subscriptions","organizations_url":"https://api.github.com/users/emmetthitz/orgs","repos_url":"https://api.github.com/users/emmetthitz/repos","events_url":"https://api.github.com/users/emmetthitz/events{/privacy}","received_events_url":"https://api.github.com/users/emmetthitz/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-02-21T22:53:34Z","updated_at":"2018-03-09T20:18:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a0e5a6575869eb6092d0f2b433016ae4f2d910ac","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apprenda/kismatic/pulls/1126/commits","review_comments_url":"https://api.github.com/repos/apprenda/kismatic/pulls/1126/comments","review_comment_url":"https://api.github.com/repos/apprenda/kismatic/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apprenda/kismatic/issues/1126/comments","statuses_url":"https://api.github.com/repos/apprenda/kismatic/statuses/5259cbea9d2bfa3754784617206a8b3404ff3595","head":{"label":"apprenda:dockerize","ref":"dockerize","sha":"5259cbea9d2bfa3754784617206a8b3404ff3595","user":{"login":"apprenda","id":6901411,"avatar_url":"https://avatars2.githubusercontent.com/u/6901411?v=4","gravatar_id":"","url":"https://api.github.com/users/apprenda","html_url":"https://github.com/apprenda","followers_url":"https://api.github.com/users/apprenda/followers","following_url":"https://api.github.com/users/apprenda/following{/other_user}","gists_url":"https://api.github.com/users/apprenda/gists{/gist_id}","starred_url":"https://api.github.com/users/apprenda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apprenda/subscriptions","organizations_url":"https://api.github.com/users/apprenda/orgs","repos_url":"https://api.github.com/users/apprenda/repos","events_url":"https://api.github.com/users/apprenda/events{/privacy}","received_events_url":"https://api.github.com/users/apprenda/received_events","type":"Organization","site_admin":false},"repo":{"id":64937285,"name":"kismatic","full_name":"apprenda/kismatic","owner":{"login":"apprenda","id":6901411,"avatar_url":"https://avatars2.githubusercontent.com/u/6901411?v=4","gravatar_id":"","url":"https://api.github.com/users/apprenda","html_url":"https://github.com/apprenda","followers_url":"https://api.github.com/users/apprenda/followers","following_url":"https://api.github.com/users/apprenda/following{/other_user}","gists_url":"https://api.github.com/users/apprenda/gists{/gist_id}","starred_url":"https://api.github.com/users/apprenda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apprenda/subscriptions","organizations_url":"https://api.github.com/users/apprenda/orgs","repos_url":"https://api.github.com/users/apprenda/repos","events_url":"https://api.github.com/users/apprenda/events{/privacy}","received_events_url":"https://api.github.com/users/apprenda/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apprenda/kismatic","description":"Kismatic Enterprise Toolkit: Fully-Automated, Production-Grade Kubernetes Operations","fork":false,"url":"https://api.github.com/repos/apprenda/kismatic","forks_url":"https://api.github.com/repos/apprenda/kismatic/forks","keys_url":"https://api.github.com/repos/apprenda/kismatic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apprenda/kismatic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apprenda/kismatic/teams","hooks_url":"https://api.github.com/repos/apprenda/kismatic/hooks","issue_events_url":"https://api.github.com/repos/apprenda/kismatic/issues/events{/number}","events_url":"https://api.github.com/repos/apprenda/kismatic/events","assignees_url":"https://api.github.com/repos/apprenda/kismatic/assignees{/user}","branches_url":"https://api.github.com/repos/apprenda/kismatic/branches{/branch}","tags_url":"https://api.github.com/repos/apprenda/kismatic/tags","blobs_url":"https://api.github.com/repos/apprenda/kismatic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apprenda/kismatic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apprenda/kismatic/git/refs{/sha}","trees_url":"https://api.github.com/repos/apprenda/kismatic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apprenda/kismatic/statuses/{sha}","languages_url":"https://api.github.com/repos/apprenda/kismatic/languages","stargazers_url":"https://api.github.com/repos/apprenda/kismatic/stargazers","contributors_url":"https://api.github.com/repos/apprenda/kismatic/contributors","subscribers_url":"https://api.github.com/repos/apprenda/kismatic/subscribers","subscription_url":"https://api.github.com/repos/apprenda/kismatic/subscription","commits_url":"https://api.github.com/repos/apprenda/kismatic/commits{/sha}","git_commits_url":"https://api.github.com/repos/apprenda/kismatic/git/commits{/sha}","comments_url":"https://api.github.com/repos/apprenda/kismatic/comments{/number}","issue_comment_url":"https://api.github.com/repos/apprenda/kismatic/issues/comments{/number}","contents_url":"https://api.github.com/repos/apprenda/kismatic/contents/{+path}","compare_url":"https://api.github.com/repos/apprenda/kismatic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apprenda/kismatic/merges","archive_url":"https://api.github.com/repos/apprenda/kismatic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apprenda/kismatic/downloads","issues_url":"https://api.github.com/repos/apprenda/kismatic/issues{/number}","pulls_url":"https://api.github.com/repos/apprenda/kismatic/pulls{/number}","milestones_url":"https://api.github.com/repos/apprenda/kismatic/milestones{/number}","notifications_url":"https://api.github.com/repos/apprenda/kismatic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apprenda/kismatic/labels{/name}","releases_url":"https://api.github.com/repos/apprenda/kismatic/releases{/id}","deployments_url":"https://api.github.com/repos/apprenda/kismatic/deployments","created_at":"2016-08-04T13:33:36Z","updated_at":"2018-03-07T11:32:12Z","pushed_at":"2018-03-09T19:40:29Z","git_url":"git://github.com/apprenda/kismatic.git","ssh_url":"[email protected]:apprenda/kismatic.git","clone_url":"https://github.com/apprenda/kismatic.git","svn_url":"https://github.com/apprenda/kismatic","homepage":"","size":7545,"stargazers_count":649,"watchers_count":649,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":110,"mirror_url":null,"archived":false,"open_issues_count":80,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":110,"open_issues":80,"watchers":649,"default_branch":"master"}},"base":{"label":"apprenda:ket-server","ref":"ket-server","sha":"4ef12d6b8646518fb31fc02b5eb8ddd2fac7f771","user":{"login":"apprenda","id":6901411,"avatar_url":"https://avatars2.githubusercontent.com/u/6901411?v=4","gravatar_id":"","url":"https://api.github.com/users/apprenda","html_url":"https://github.com/apprenda","followers_url":"https://api.github.com/users/apprenda/followers","following_url":"https://api.github.com/users/apprenda/following{/other_user}","gists_url":"https://api.github.com/users/apprenda/gists{/gist_id}","starred_url":"https://api.github.com/users/apprenda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apprenda/subscriptions","organizations_url":"https://api.github.com/users/apprenda/orgs","repos_url":"https://api.github.com/users/apprenda/repos","events_url":"https://api.github.com/users/apprenda/events{/privacy}","received_events_url":"https://api.github.com/users/apprenda/received_events","type":"Organization","site_admin":false},"repo":{"id":64937285,"name":"kismatic","full_name":"apprenda/kismatic","owner":{"login":"apprenda","id":6901411,"avatar_url":"https://avatars2.githubusercontent.com/u/6901411?v=4","gravatar_id":"","url":"https://api.github.com/users/apprenda","html_url":"https://github.com/apprenda","followers_url":"https://api.github.com/users/apprenda/followers","following_url":"https://api.github.com/users/apprenda/following{/other_user}","gists_url":"https://api.github.com/users/apprenda/gists{/gist_id}","starred_url":"https://api.github.com/users/apprenda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apprenda/subscriptions","organizations_url":"https://api.github.com/users/apprenda/orgs","repos_url":"https://api.github.com/users/apprenda/repos","events_url":"https://api.github.com/users/apprenda/events{/privacy}","received_events_url":"https://api.github.com/users/apprenda/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apprenda/kismatic","description":"Kismatic Enterprise Toolkit: Fully-Automated, Production-Grade Kubernetes Operations","fork":false,"url":"https://api.github.com/repos/apprenda/kismatic","forks_url":"https://api.github.com/repos/apprenda/kismatic/forks","keys_url":"https://api.github.com/repos/apprenda/kismatic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apprenda/kismatic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apprenda/kismatic/teams","hooks_url":"https://api.github.com/repos/apprenda/kismatic/hooks","issue_events_url":"https://api.github.com/repos/apprenda/kismatic/issues/events{/number}","events_url":"https://api.github.com/repos/apprenda/kismatic/events","assignees_url":"https://api.github.com/repos/apprenda/kismatic/assignees{/user}","branches_url":"https://api.github.com/repos/apprenda/kismatic/branches{/branch}","tags_url":"https://api.github.com/repos/apprenda/kismatic/tags","blobs_url":"https://api.github.com/repos/apprenda/kismatic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apprenda/kismatic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apprenda/kismatic/git/refs{/sha}","trees_url":"https://api.github.com/repos/apprenda/kismatic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apprenda/kismatic/statuses/{sha}","languages_url":"https://api.github.com/repos/apprenda/kismatic/languages","stargazers_url":"https://api.github.com/repos/apprenda/kismatic/stargazers","contributors_url":"https://api.github.com/repos/apprenda/kismatic/contributors","subscribers_url":"https://api.github.com/repos/apprenda/kismatic/subscribers","subscription_url":"https://api.github.com/repos/apprenda/kismatic/subscription","commits_url":"https://api.github.com/repos/apprenda/kismatic/commits{/sha}","git_commits_url":"https://api.github.com/repos/apprenda/kismatic/git/commits{/sha}","comments_url":"https://api.github.com/repos/apprenda/kismatic/comments{/number}","issue_comment_url":"https://api.github.com/repos/apprenda/kismatic/issues/comments{/number}","contents_url":"https://api.github.com/repos/apprenda/kismatic/contents/{+path}","compare_url":"https://api.github.com/repos/apprenda/kismatic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apprenda/kismatic/merges","archive_url":"https://api.github.com/repos/apprenda/kismatic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apprenda/kismatic/downloads","issues_url":"https://api.github.com/repos/apprenda/kismatic/issues{/number}","pulls_url":"https://api.github.com/repos/apprenda/kismatic/pulls{/number}","milestones_url":"https://api.github.com/repos/apprenda/kismatic/milestones{/number}","notifications_url":"https://api.github.com/repos/apprenda/kismatic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apprenda/kismatic/labels{/name}","releases_url":"https://api.github.com/repos/apprenda/kismatic/releases{/id}","deployments_url":"https://api.github.com/repos/apprenda/kismatic/deployments","created_at":"2016-08-04T13:33:36Z","updated_at":"2018-03-07T11:32:12Z","pushed_at":"2018-03-09T19:40:29Z","git_url":"git://github.com/apprenda/kismatic.git","ssh_url":"[email protected]:apprenda/kismatic.git","clone_url":"https://github.com/apprenda/kismatic.git","svn_url":"https://github.com/apprenda/kismatic","homepage":"","size":7545,"stargazers_count":649,"watchers_count":649,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":110,"mirror_url":null,"archived":false,"open_issues_count":80,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":110,"open_issues":80,"watchers":649,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apprenda/kismatic/pulls/1126"},"html":{"href":"https://github.com/apprenda/kismatic/pull/1126"},"issue":{"href":"https://api.github.com/repos/apprenda/kismatic/issues/1126"},"comments":{"href":"https://api.github.com/repos/apprenda/kismatic/issues/1126/comments"},"review_comments":{"href":"https://api.github.com/repos/apprenda/kismatic/pulls/1126/comments"},"review_comment":{"href":"https://api.github.com/repos/apprenda/kismatic/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apprenda/kismatic/pulls/1126/commits"},"statuses":{"href":"https://api.github.com/repos/apprenda/kismatic/statuses/5259cbea9d2bfa3754784617206a8b3404ff3595"}},"author_association":"CONTRIBUTOR"}} | {
"id": 64937285,
"name": "apprenda/kismatic",
"url": "https://api.github.com/repos/apprenda/kismatic"
} | {
"id": 4969231,
"login": "dkoshkin",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4969231?",
"url": "https://api.github.com/users/dkoshkin"
} | {
"id": 6901411,
"login": "apprenda",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6901411?",
"url": "https://api.github.com/orgs/apprenda"
} | 2018-03-09T20:18:00 | 7358026669 | {"actor":{"display_login":"dkoshkin"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/cocos-creator/cocos2d-x-lite/pulls/comments/195311984","pull_request_review_id":128653179,"id":195311984,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NTMxMTk4NA==","diff_hunk":"@@ -446,19 +446,18 @@ - (void) startup\n NSString *resourcePath = [[NSBundle mainBundle] resourcePath];\n FileUtils::getInstance()->addSearchPath(resourcePath.UTF8String);\n \n- // app\n- _app = new AppDelegate();\n-\n- [self setupUI];\n- [self adjustEditMenuIndex];\n+ // not show the custom menu items\n+ // [self setupUI];\n+ // [self adjustEditMenuIndex];","path":"tools/simulator/frameworks/runtime-src/proj.ios_mac/mac/SimulatorApp.mm","position":92,"original_position":92,"commit_id":"7e3bd3e52ff7e61b6f7a71b93f6b5c2354948090","original_commit_id":"7e3bd3e52ff7e61b6f7a71b93f6b5c2354948090","user":{"login":"minggo","id":488203,"node_id":"MDQ6VXNlcjQ4ODIwMw==","avatar_url":"https://avatars1.githubusercontent.com/u/488203?v=4","gravatar_id":"","url":"https://api.github.com/users/minggo","html_url":"https://github.com/minggo","followers_url":"https://api.github.com/users/minggo/followers","following_url":"https://api.github.com/users/minggo/following{/other_user}","gists_url":"https://api.github.com/users/minggo/gists{/gist_id}","starred_url":"https://api.github.com/users/minggo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minggo/subscriptions","organizations_url":"https://api.github.com/users/minggo/orgs","repos_url":"https://api.github.com/users/minggo/repos","events_url":"https://api.github.com/users/minggo/events{/privacy}","received_events_url":"https://api.github.com/users/minggo/received_events","type":"User","site_admin":false},"body":"I think these features are needed, and should be implemented in JS later.","created_at":"2018-06-14T06:19:50Z","updated_at":"2018-06-14T06:19:50Z","html_url":"https://github.com/cocos-creator/cocos2d-x-lite/pull/1313#discussion_r195311984","pull_request_url":"https://api.github.com/repos/cocos-creator/cocos2d-x-lite/pulls/1313","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/cocos-creator/cocos2d-x-lite/pulls/comments/195311984"},"html":{"href":"https://github.com/cocos-creator/cocos2d-x-lite/pull/1313#discussion_r195311984"},"pull_request":{"href":"https://api.github.com/repos/cocos-creator/cocos2d-x-lite/pulls/1313"}},"in_reply_to_id":195310761},"pull_request":{"url":"https://api.github.com/repos/cocos-creator/cocos2d-x-lite/pulls/1313","id":194545596,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0NTQ1NTk2","html_url":"https://github.com/cocos-creator/cocos2d-x-lite/pull/1313","diff_url":"https://github.com/cocos-creator/cocos2d-x-lite/pull/1313.diff","patch_url":"https://github.com/cocos-creator/cocos2d-x-lite/pull/1313.patch","issue_url":"https://api.github.com/repos/cocos-creator/cocos2d-x-lite/issues/1313","number":1313,"state":"open","locked":false,"title":"gen-simulator works on mac, but not full features","user":{"login":"drelaptop","id":26329291,"node_id":"MDQ6VXNlcjI2MzI5Mjkx","avatar_url":"https://avatars3.githubusercontent.com/u/26329291?v=4","gravatar_id":"","url":"https://api.github.com/users/drelaptop","html_url":"https://github.com/drelaptop","followers_url":"https://api.github.com/users/drelaptop/followers","following_url":"https://api.github.com/users/drelaptop/following{/other_user}","gists_url":"https://api.github.com/users/drelaptop/gists{/gist_id}","starred_url":"https://api.github.com/users/drelaptop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drelaptop/subscriptions","organizations_url":"https://api.github.com/users/drelaptop/orgs","repos_url":"https://api.github.com/users/drelaptop/repos","events_url":"https://api.github.com/users/drelaptop/events{/privacy}","received_events_url":"https://api.github.com/users/drelaptop/received_events","type":"User","site_admin":false},"body":"## Attention\r\n\r\nView control features are lost, for those reason.\r\n\r\n1. needed native feature disappear at native runtime, for example\r\n```\r\nauto displayStats = Director::getInstance()->isDisplayStats(); // display FPS or not\r\nDirector::getInstance()->getOpenGLView()->setFrameZoomFactor(scale); // scale\r\n```\r\n2. those codes of Simulator are confusing, for example\r\nwhat's the meaning of adding `PlayerEditBoxServiceProtocol` class into simulator\r\n\r\n## Tests\r\n\r\n\r\n","created_at":"2018-06-13T10:51:04Z","updated_at":"2018-06-14T06:19:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"02e6bdadd64487b411afa72f58cf43dae50a70af","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/cocos-creator/cocos2d-x-lite/pulls/1313/commits","review_comments_url":"https://api.github.com/repos/cocos-creator/cocos2d-x-lite/pulls/1313/comments","review_comment_url":"https://api.github.com/repos/cocos-creator/cocos2d-x-lite/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cocos-creator/cocos2d-x-lite/issues/1313/comments","statuses_url":"https://api.github.com/repos/cocos-creator/cocos2d-x-lite/statuses/7e3bd3e52ff7e61b6f7a71b93f6b5c2354948090","head":{"label":"drelaptop:gen-sim-adapt","ref":"gen-sim-adapt","sha":"7e3bd3e52ff7e61b6f7a71b93f6b5c2354948090","user":{"login":"drelaptop","id":26329291,"node_id":"MDQ6VXNlcjI2MzI5Mjkx","avatar_url":"https://avatars3.githubusercontent.com/u/26329291?v=4","gravatar_id":"","url":"https://api.github.com/users/drelaptop","html_url":"https://github.com/drelaptop","followers_url":"https://api.github.com/users/drelaptop/followers","following_url":"https://api.github.com/users/drelaptop/following{/other_user}","gists_url":"https://api.github.com/users/drelaptop/gists{/gist_id}","starred_url":"https://api.github.com/users/drelaptop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drelaptop/subscriptions","organizations_url":"https://api.github.com/users/drelaptop/orgs","repos_url":"https://api.github.com/users/drelaptop/repos","events_url":"https://api.github.com/users/drelaptop/events{/privacy}","received_events_url":"https://api.github.com/users/drelaptop/received_events","type":"User","site_admin":false},"repo":{"id":131251065,"node_id":"MDEwOlJlcG9zaXRvcnkxMzEyNTEwNjU=","name":"cocos2d-x-lite","full_name":"drelaptop/cocos2d-x-lite","owner":{"login":"drelaptop","id":26329291,"node_id":"MDQ6VXNlcjI2MzI5Mjkx","avatar_url":"https://avatars3.githubusercontent.com/u/26329291?v=4","gravatar_id":"","url":"https://api.github.com/users/drelaptop","html_url":"https://github.com/drelaptop","followers_url":"https://api.github.com/users/drelaptop/followers","following_url":"https://api.github.com/users/drelaptop/following{/other_user}","gists_url":"https://api.github.com/users/drelaptop/gists{/gist_id}","starred_url":"https://api.github.com/users/drelaptop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drelaptop/subscriptions","organizations_url":"https://api.github.com/users/drelaptop/orgs","repos_url":"https://api.github.com/users/drelaptop/repos","events_url":"https://api.github.com/users/drelaptop/events{/privacy}","received_events_url":"https://api.github.com/users/drelaptop/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/drelaptop/cocos2d-x-lite","description":"Lite version cocos2d-x based on Cocos Runtime","fork":true,"url":"https://api.github.com/repos/drelaptop/cocos2d-x-lite","forks_url":"https://api.github.com/repos/drelaptop/cocos2d-x-lite/forks","keys_url":"https://api.github.com/repos/drelaptop/cocos2d-x-lite/keys{/key_id}","collaborators_url":"https://api.github.com/repos/drelaptop/cocos2d-x-lite/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/drelaptop/cocos2d-x-lite/teams","hooks_url":"https://api.github.com/repos/drelaptop/cocos2d-x-lite/hooks","issue_events_url":"https://api.github.com/repos/drelaptop/cocos2d-x-lite/issues/events{/number}","events_url":"https://api.github.com/repos/drelaptop/cocos2d-x-lite/events","assignees_url":"https://api.github.com/repos/drelaptop/cocos2d-x-lite/assignees{/user}","branches_url":"https://api.github.com/repos/drelaptop/cocos2d-x-lite/branches{/branch}","tags_url":"https://api.github.com/repos/drelaptop/cocos2d-x-lite/tags","blobs_url":"https://api.github.com/repos/drelaptop/cocos2d-x-lite/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/drelaptop/cocos2d-x-lite/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/drelaptop/cocos2d-x-lite/git/refs{/sha}","trees_url":"https://api.github.com/repos/drelaptop/cocos2d-x-lite/git/trees{/sha}","statuses_url":"https://api.github.com/repos/drelaptop/cocos2d-x-lite/statuses/{sha}","languages_url":"https://api.github.com/repos/drelaptop/cocos2d-x-lite/languages","stargazers_url":"https://api.github.com/repos/drelaptop/cocos2d-x-lite/stargazers","contributors_url":"https://api.github.com/repos/drelaptop/cocos2d-x-lite/contributors","subscribers_url":"https://api.github.com/repos/drelaptop/cocos2d-x-lite/subscribers","subscription_url":"https://api.github.com/repos/drelaptop/cocos2d-x-lite/subscription","commits_url":"https://api.github.com/repos/drelaptop/cocos2d-x-lite/commits{/sha}","git_commits_url":"https://api.github.com/repos/drelaptop/cocos2d-x-lite/git/commits{/sha}","comments_url":"https://api.github.com/repos/drelaptop/cocos2d-x-lite/comments{/number}","issue_comment_url":"https://api.github.com/repos/drelaptop/cocos2d-x-lite/issues/comments{/number}","contents_url":"https://api.github.com/repos/drelaptop/cocos2d-x-lite/contents/{+path}","compare_url":"https://api.github.com/repos/drelaptop/cocos2d-x-lite/compare/{base}...{head}","merges_url":"https://api.github.com/repos/drelaptop/cocos2d-x-lite/merges","archive_url":"https://api.github.com/repos/drelaptop/cocos2d-x-lite/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/drelaptop/cocos2d-x-lite/downloads","issues_url":"https://api.github.com/repos/drelaptop/cocos2d-x-lite/issues{/number}","pulls_url":"https://api.github.com/repos/drelaptop/cocos2d-x-lite/pulls{/number}","milestones_url":"https://api.github.com/repos/drelaptop/cocos2d-x-lite/milestones{/number}","notifications_url":"https://api.github.com/repos/drelaptop/cocos2d-x-lite/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/drelaptop/cocos2d-x-lite/labels{/name}","releases_url":"https://api.github.com/repos/drelaptop/cocos2d-x-lite/releases{/id}","deployments_url":"https://api.github.com/repos/drelaptop/cocos2d-x-lite/deployments","created_at":"2018-04-27T05:47:55Z","updated_at":"2018-04-27T05:48:03Z","pushed_at":"2018-06-14T04:58:48Z","git_url":"git://github.com/drelaptop/cocos2d-x-lite.git","ssh_url":"[email protected]:drelaptop/cocos2d-x-lite.git","clone_url":"https://github.com/drelaptop/cocos2d-x-lite.git","svn_url":"https://github.com/drelaptop/cocos2d-x-lite","homepage":null,"size":30110,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"cocos-creator:runtime","ref":"runtime","sha":"af0742a634847d35b945449893b224268f2954e6","user":{"login":"cocos-creator","id":6937061,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5MzcwNjE=","avatar_url":"https://avatars3.githubusercontent.com/u/6937061?v=4","gravatar_id":"","url":"https://api.github.com/users/cocos-creator","html_url":"https://github.com/cocos-creator","followers_url":"https://api.github.com/users/cocos-creator/followers","following_url":"https://api.github.com/users/cocos-creator/following{/other_user}","gists_url":"https://api.github.com/users/cocos-creator/gists{/gist_id}","starred_url":"https://api.github.com/users/cocos-creator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cocos-creator/subscriptions","organizations_url":"https://api.github.com/users/cocos-creator/orgs","repos_url":"https://api.github.com/users/cocos-creator/repos","events_url":"https://api.github.com/users/cocos-creator/events{/privacy}","received_events_url":"https://api.github.com/users/cocos-creator/received_events","type":"Organization","site_admin":false},"repo":{"id":53839527,"node_id":"MDEwOlJlcG9zaXRvcnk1MzgzOTUyNw==","name":"cocos2d-x-lite","full_name":"cocos-creator/cocos2d-x-lite","owner":{"login":"cocos-creator","id":6937061,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5MzcwNjE=","avatar_url":"https://avatars3.githubusercontent.com/u/6937061?v=4","gravatar_id":"","url":"https://api.github.com/users/cocos-creator","html_url":"https://github.com/cocos-creator","followers_url":"https://api.github.com/users/cocos-creator/followers","following_url":"https://api.github.com/users/cocos-creator/following{/other_user}","gists_url":"https://api.github.com/users/cocos-creator/gists{/gist_id}","starred_url":"https://api.github.com/users/cocos-creator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cocos-creator/subscriptions","organizations_url":"https://api.github.com/users/cocos-creator/orgs","repos_url":"https://api.github.com/users/cocos-creator/repos","events_url":"https://api.github.com/users/cocos-creator/events{/privacy}","received_events_url":"https://api.github.com/users/cocos-creator/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cocos-creator/cocos2d-x-lite","description":"Lite version cocos2d-x based on Cocos Runtime","fork":false,"url":"https://api.github.com/repos/cocos-creator/cocos2d-x-lite","forks_url":"https://api.github.com/repos/cocos-creator/cocos2d-x-lite/forks","keys_url":"https://api.github.com/repos/cocos-creator/cocos2d-x-lite/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cocos-creator/cocos2d-x-lite/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cocos-creator/cocos2d-x-lite/teams","hooks_url":"https://api.github.com/repos/cocos-creator/cocos2d-x-lite/hooks","issue_events_url":"https://api.github.com/repos/cocos-creator/cocos2d-x-lite/issues/events{/number}","events_url":"https://api.github.com/repos/cocos-creator/cocos2d-x-lite/events","assignees_url":"https://api.github.com/repos/cocos-creator/cocos2d-x-lite/assignees{/user}","branches_url":"https://api.github.com/repos/cocos-creator/cocos2d-x-lite/branches{/branch}","tags_url":"https://api.github.com/repos/cocos-creator/cocos2d-x-lite/tags","blobs_url":"https://api.github.com/repos/cocos-creator/cocos2d-x-lite/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cocos-creator/cocos2d-x-lite/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cocos-creator/cocos2d-x-lite/git/refs{/sha}","trees_url":"https://api.github.com/repos/cocos-creator/cocos2d-x-lite/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cocos-creator/cocos2d-x-lite/statuses/{sha}","languages_url":"https://api.github.com/repos/cocos-creator/cocos2d-x-lite/languages","stargazers_url":"https://api.github.com/repos/cocos-creator/cocos2d-x-lite/stargazers","contributors_url":"https://api.github.com/repos/cocos-creator/cocos2d-x-lite/contributors","subscribers_url":"https://api.github.com/repos/cocos-creator/cocos2d-x-lite/subscribers","subscription_url":"https://api.github.com/repos/cocos-creator/cocos2d-x-lite/subscription","commits_url":"https://api.github.com/repos/cocos-creator/cocos2d-x-lite/commits{/sha}","git_commits_url":"https://api.github.com/repos/cocos-creator/cocos2d-x-lite/git/commits{/sha}","comments_url":"https://api.github.com/repos/cocos-creator/cocos2d-x-lite/comments{/number}","issue_comment_url":"https://api.github.com/repos/cocos-creator/cocos2d-x-lite/issues/comments{/number}","contents_url":"https://api.github.com/repos/cocos-creator/cocos2d-x-lite/contents/{+path}","compare_url":"https://api.github.com/repos/cocos-creator/cocos2d-x-lite/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cocos-creator/cocos2d-x-lite/merges","archive_url":"https://api.github.com/repos/cocos-creator/cocos2d-x-lite/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cocos-creator/cocos2d-x-lite/downloads","issues_url":"https://api.github.com/repos/cocos-creator/cocos2d-x-lite/issues{/number}","pulls_url":"https://api.github.com/repos/cocos-creator/cocos2d-x-lite/pulls{/number}","milestones_url":"https://api.github.com/repos/cocos-creator/cocos2d-x-lite/milestones{/number}","notifications_url":"https://api.github.com/repos/cocos-creator/cocos2d-x-lite/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cocos-creator/cocos2d-x-lite/labels{/name}","releases_url":"https://api.github.com/repos/cocos-creator/cocos2d-x-lite/releases{/id}","deployments_url":"https://api.github.com/repos/cocos-creator/cocos2d-x-lite/deployments","created_at":"2016-03-14T08:35:33Z","updated_at":"2018-06-14T03:27:20Z","pushed_at":"2018-06-14T04:58:49Z","git_url":"git://github.com/cocos-creator/cocos2d-x-lite.git","ssh_url":"[email protected]:cocos-creator/cocos2d-x-lite.git","clone_url":"https://github.com/cocos-creator/cocos2d-x-lite.git","svn_url":"https://github.com/cocos-creator/cocos2d-x-lite","homepage":null,"size":30114,"stargazers_count":229,"watchers_count":229,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":267,"mirror_url":null,"archived":false,"open_issues_count":38,"license":null,"forks":267,"open_issues":38,"watchers":229,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/cocos-creator/cocos2d-x-lite/pulls/1313"},"html":{"href":"https://github.com/cocos-creator/cocos2d-x-lite/pull/1313"},"issue":{"href":"https://api.github.com/repos/cocos-creator/cocos2d-x-lite/issues/1313"},"comments":{"href":"https://api.github.com/repos/cocos-creator/cocos2d-x-lite/issues/1313/comments"},"review_comments":{"href":"https://api.github.com/repos/cocos-creator/cocos2d-x-lite/pulls/1313/comments"},"review_comment":{"href":"https://api.github.com/repos/cocos-creator/cocos2d-x-lite/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cocos-creator/cocos2d-x-lite/pulls/1313/commits"},"statuses":{"href":"https://api.github.com/repos/cocos-creator/cocos2d-x-lite/statuses/7e3bd3e52ff7e61b6f7a71b93f6b5c2354948090"}},"author_association":"NONE"}} | {
"id": 53839527,
"name": "cocos-creator/cocos2d-x-lite",
"url": "https://api.github.com/repos/cocos-creator/cocos2d-x-lite"
} | {
"id": 488203,
"login": "minggo",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/488203?",
"url": "https://api.github.com/users/minggo"
} | {
"id": 6937061,
"login": "cocos-creator",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6937061?",
"url": "https://api.github.com/orgs/cocos-creator"
} | 2018-06-14T06:19:50 | 7823028997 | {"actor":{"display_login":"minggo"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/ProtonMail/sieve.js/pulls/comments/236265480","pull_request_review_id":178285116,"id":236265480,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNjI2NTQ4MA==","diff_hunk":"@@ -0,0 +1,335 @@\n+import { escapeCharacters, unique } from './commons';\n+import { MATCH_KEYS, OPERATOR_KEYS, TEST_NODES, V1, V2 } from './constants';\n+import { InvalidInputError } from './Errors';\n+\n+/**\n+ * Validates and correct the received simple representation.\n+ * @param {{Operator: *, Conditions: *, Actions: *}} simple\n+ * @return {*}\n+ */\n+function correctSimpleRepresentation(simple) {\n+ if (['Operator', 'Conditions', 'Actions'].find((key) => !simple[key])) {\n+ throw new InvalidInputError('Invalid simple keys');\n+ }\n+\n+ if (\n+ !// beware the !\n+ (simple.Operator instanceof Object && simple.Conditions instanceof Array && simple.Actions instanceof Object)\n+ ) {\n+ throw new InvalidInputError('Invalid simple data types');\n+ }\n+\n+ if (!simple.Operator.label || !simple.Operator.value) {\n+ throw new InvalidInputError('Invalid simple operator');\n+ }\n+\n+ for (const condition of simple.Conditions) {\n+ for (const key of ['Type', 'Comparator']) {\n+ const value = condition[key];\n+ if (!value || !value.label || !value.value) {\n+ throw new InvalidInputError('Invalid simple conditions');\n+ }\n+ }\n+ if (!condition.Values) {\n+ throw new InvalidInputError('Invalid simple conditions');\n+ }\n+ }\n+\n+ if (\n+ !simple.Actions.FileInto ||\n+ !(simple.Actions.FileInto instanceof Array) ||\n+ !simple.Actions.Mark ||\n+ typeof simple.Actions.Mark.Read === 'undefined' ||\n+ typeof simple.Actions.Mark.Starred === 'undefined'\n+ ) {\n+ throw new InvalidInputError('Invalid simple actions');\n+ }\n+\n+ return simple;\n+}\n+\n+/**\n+ * Builds an address test.\n+ * @param {String[]} headers\n+ * @param {String[]} keys\n+ * @param {String} match\n+ * @return {{Headers: String[], Keys: String[], Match: {Type: String}, Type: String, AddressPart: {Type: String}}}\n+ */\n+function buildAddressTest(headers, keys, match) {\n+ return {\n+ Headers: headers,\n+ Keys: keys,\n+ Match: {\n+ Type: match\n+ },\n+ Format: {\n+ Type: 'UnicodeCaseMap'\n+ },\n+ Type: 'Address',\n+ AddressPart: {\n+ Type: 'All'\n+ }\n+ };\n+}\n+\n+/**\n+ * Builds a setflag action, for read or starred.\n+ * @param {Boolean} read\n+ * @param {Boolean} starred\n+ * @return {{Flags: String[], Type: String}}\n+ */\n+function buildSetflagThen(read, starred) {\n+ const flags = [];\n+ if (read) {\n+ flags.push('\\\\Seen');\n+ }\n+ if (starred) {\n+ flags.push('\\\\Flagged');\n+ }\n+ return {\n+ Flags: flags,\n+ Type: 'AddFlag'\n+ };\n+}\n+\n+/**\n+ * Builds a vacation action.\n+ * @param {String} message - the message to be sent.\n+ * @param {Number} version - the sieve version.\n+ * @return {{Message: String, Args: {MIMEType: String}, Type: String}}\n+ */\n+function buildVacationAction(message, version) {\n+ return {\n+ Message: message,\n+ Args: { MIMEType: 'text/html' },\n+ Type: version === V1 ? 'Vacation\\\\Vacation' : 'Vacation'\n+ };\n+}\n+\n+/**\n+ * Builds a fileinto action.\n+ * @param {String} name - the folder.\n+ * @return {{Name: String, Type: String}}\n+ */\n+function buildFileintoAction(name) {\n+ return {\n+ Name: name,\n+ Type: 'FileInto'\n+ };\n+}\n+\n+/**\n+ * Builds a simple test.\n+ * @param {String[]} headers - a list of header.\n+ * @param {String[]} keys - the keys.\n+ * @param {String} match - the match value.\n+ * @return {{Headers: String[], Keys: String[], Format: {Type: String}, Type: String}}\n+ */\n+function buildSimpleHeaderTest(headers, keys, match) {\n+ return {\n+ Headers: headers,\n+ Keys: keys,\n+ Match: {\n+ Type: match // The value can be removed if needed, it's backend compatible.\n+ },\n+ Format: {\n+ Type: 'UnicodeCaseMap'\n+ },\n+ Type: 'Header'\n+ };\n+}\n+\n+/**\n+ * Negates a given test.\n+ * @param {*} test an already computer test.\n+ * @return {{Test: *, Type: String}}\n+ */\n+function buildTestNegate(test) {\n+ return {\n+ Test: test,\n+ Type: 'Not'\n+ };\n+}\n+\n+/**\n+ * Builds a require node.\n+ * @param {String[]} requires - the extensions to require.\n+ * @param {String[]} mandatory - the extensions to require anyway.\n+ * @return {{List: String[], Type: 'Require'}}\n+ */\n+function buildSieveRequire(requires, mandatory = ['fileinto', 'imap4flags']) {\n+ return {\n+ List: unique([...mandatory, ...requires]),\n+ Type: 'Require'\n+ };\n+}\n+\n+/**\n+ * Builds the tree.\n+ * @param {{requires: String[], comparators: String[], type: String, tests: {}, thens: []}} parameters - the different parameters.\n+ * @param {Number} version - the sieve version.\n+ * @return {Array}\n+ */\n+function buildBasicTree(parameters, version) {\n+ const treeStructure = [];\n+ if (version === V2) {\n+ treeStructure.push(\n+ buildSieveRequire(\n+ ['include', 'environment', 'variables', 'relational', 'comparator-i;ascii-numeric', 'spamtest'],\n+ []\n+ )\n+ );\n+ }\n+\n+ treeStructure.push(buildSieveRequire(parameters.requires));\n+\n+ if (version === V2) {\n+ treeStructure.push(...TEST_NODES.spamtest);\n+ treeStructure.push(buildComparatorComment(parameters.comparators, parameters.type));\n+ }\n+\n+ treeStructure.push({\n+ If: {\n+ Tests: parameters.tests,\n+ Type: parameters.type\n+ },\n+ Then: parameters.thens,\n+ Type: 'If'\n+ });\n+ return treeStructure;\n+}\n+\n+/**\n+ * Build the comment node from a comparator.\n+ * @param {String[]} comparators - the comparators.\n+ * @param {String} type - the type. Either AllOf or AnyOf\n+ * @return {{Text: String, Type: String}}\n+ */\n+function buildComparatorComment(comparators, type) {\n+ const commentArray = ['/**'];\n+\n+ if (type === 'AllOf') {\n+ commentArray.push(' @type and');\n+ } else if (type === 'AnyOf') {\n+ commentArray.push(' @type or');\n+ } else {\n+ throw new TypeError('Undefined type ' + type);\n+ }\n+\n+ commentArray.push(...comparators.map((comparator) => ' @comparator ' + comparator));\n+\n+ commentArray.push('/');\n+ return {\n+ Text: commentArray.join('\\r\\n *'),\n+ Type: 'Comment'\n+ };\n+}\n+\n+/**\n+ * Build match and values from comparator and condition.\n+ * @param {String} comparator\n+ * @param {{Values: String}} condition\n+ * @return {{match: String, values: String[]}}\n+ */\n+function buildMatchAndValues(comparator, condition) {\n+ // starts and ends does not exists in sieve. Replacing it to match.\n+ condition.Values = condition.Values.map((value) => {\n+ const escaped = escapeCharacters(value);\n+ switch (comparator) {\n+ case 'starts':\n+ return ''.concat(escaped, '*');\n+ case 'ends':\n+ return ''.concat('*', value);\n+ default:\n+ return value;\n+ }\n+ });\n+\n+ comparator = comparator === 'starts' || comparator === 'ends' ? 'matches' : comparator;","path":"src/toTree.js","position":248,"original_position":248,"commit_id":"85d5bc66368229cc418d391a991edc2ac10760f8","original_commit_id":"85d5bc66368229cc418d391a991edc2ac10760f8","user":{"login":"dhoko","id":713283,"node_id":"MDQ6VXNlcjcxMzI4Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/713283?v=4","gravatar_id":"","url":"https://api.github.com/users/dhoko","html_url":"https://github.com/dhoko","followers_url":"https://api.github.com/users/dhoko/followers","following_url":"https://api.github.com/users/dhoko/following{/other_user}","gists_url":"https://api.github.com/users/dhoko/gists{/gist_id}","starred_url":"https://api.github.com/users/dhoko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhoko/subscriptions","organizations_url":"https://api.github.com/users/dhoko/orgs","repos_url":"https://api.github.com/users/dhoko/repos","events_url":"https://api.github.com/users/dhoko/events{/privacy}","received_events_url":"https://api.github.com/users/dhoko/received_events","type":"User","site_admin":false},"body":"don't mutate this var and add `()`","created_at":"2018-11-26T14:03:25Z","updated_at":"2018-11-26T14:05:59Z","html_url":"https://github.com/ProtonMail/sieve.js/pull/8#discussion_r236265480","pull_request_url":"https://api.github.com/repos/ProtonMail/sieve.js/pulls/8","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/ProtonMail/sieve.js/pulls/comments/236265480"},"html":{"href":"https://github.com/ProtonMail/sieve.js/pull/8#discussion_r236265480"},"pull_request":{"href":"https://api.github.com/repos/ProtonMail/sieve.js/pulls/8"}}},"pull_request":{"url":"https://api.github.com/repos/ProtonMail/sieve.js/pulls/8","id":230549014,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMwNTQ5MDE0","html_url":"https://github.com/ProtonMail/sieve.js/pull/8","diff_url":"https://github.com/ProtonMail/sieve.js/pull/8.diff","patch_url":"https://github.com/ProtonMail/sieve.js/pull/8.patch","issue_url":"https://api.github.com/repos/ProtonMail/sieve.js/issues/8","number":8,"state":"open","locked":false,"title":"V2 compat","user":{"login":"ThHareau","id":9265111,"node_id":"MDQ6VXNlcjkyNjUxMTE=","avatar_url":"https://avatars0.githubusercontent.com/u/9265111?v=4","gravatar_id":"","url":"https://api.github.com/users/ThHareau","html_url":"https://github.com/ThHareau","followers_url":"https://api.github.com/users/ThHareau/followers","following_url":"https://api.github.com/users/ThHareau/following{/other_user}","gists_url":"https://api.github.com/users/ThHareau/gists{/gist_id}","starred_url":"https://api.github.com/users/ThHareau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ThHareau/subscriptions","organizations_url":"https://api.github.com/users/ThHareau/orgs","repos_url":"https://api.github.com/users/ThHareau/repos","events_url":"https://api.github.com/users/ThHareau/events{/privacy}","received_events_url":"https://api.github.com/users/ThHareau/received_events","type":"User","site_admin":false},"body":"* Recognizes the spamtest\r\n* Generation with spamtest if version 2","created_at":"2018-11-13T16:49:32Z","updated_at":"2018-11-26T14:05:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0bb689d0fdcd7d177e89c2fa6a2bf97aaaaafd3e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ProtonMail/sieve.js/pulls/8/commits","review_comments_url":"https://api.github.com/repos/ProtonMail/sieve.js/pulls/8/comments","review_comment_url":"https://api.github.com/repos/ProtonMail/sieve.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ProtonMail/sieve.js/issues/8/comments","statuses_url":"https://api.github.com/repos/ProtonMail/sieve.js/statuses/85d5bc66368229cc418d391a991edc2ac10760f8","head":{"label":"ProtonMail:v2-compat","ref":"v2-compat","sha":"85d5bc66368229cc418d391a991edc2ac10760f8","user":{"login":"ProtonMail","id":6953970,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5NTM5NzA=","avatar_url":"https://avatars1.githubusercontent.com/u/6953970?v=4","gravatar_id":"","url":"https://api.github.com/users/ProtonMail","html_url":"https://github.com/ProtonMail","followers_url":"https://api.github.com/users/ProtonMail/followers","following_url":"https://api.github.com/users/ProtonMail/following{/other_user}","gists_url":"https://api.github.com/users/ProtonMail/gists{/gist_id}","starred_url":"https://api.github.com/users/ProtonMail/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ProtonMail/subscriptions","organizations_url":"https://api.github.com/users/ProtonMail/orgs","repos_url":"https://api.github.com/users/ProtonMail/repos","events_url":"https://api.github.com/users/ProtonMail/events{/privacy}","received_events_url":"https://api.github.com/users/ProtonMail/received_events","type":"Organization","site_admin":false},"repo":{"id":61641954,"node_id":"MDEwOlJlcG9zaXRvcnk2MTY0MTk1NA==","name":"sieve.js","full_name":"ProtonMail/sieve.js","private":false,"owner":{"login":"ProtonMail","id":6953970,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5NTM5NzA=","avatar_url":"https://avatars1.githubusercontent.com/u/6953970?v=4","gravatar_id":"","url":"https://api.github.com/users/ProtonMail","html_url":"https://github.com/ProtonMail","followers_url":"https://api.github.com/users/ProtonMail/followers","following_url":"https://api.github.com/users/ProtonMail/following{/other_user}","gists_url":"https://api.github.com/users/ProtonMail/gists{/gist_id}","starred_url":"https://api.github.com/users/ProtonMail/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ProtonMail/subscriptions","organizations_url":"https://api.github.com/users/ProtonMail/orgs","repos_url":"https://api.github.com/users/ProtonMail/repos","events_url":"https://api.github.com/users/ProtonMail/events{/privacy}","received_events_url":"https://api.github.com/users/ProtonMail/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ProtonMail/sieve.js","description":"Javascript library to wrap sieve configuration","fork":false,"url":"https://api.github.com/repos/ProtonMail/sieve.js","forks_url":"https://api.github.com/repos/ProtonMail/sieve.js/forks","keys_url":"https://api.github.com/repos/ProtonMail/sieve.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ProtonMail/sieve.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ProtonMail/sieve.js/teams","hooks_url":"https://api.github.com/repos/ProtonMail/sieve.js/hooks","issue_events_url":"https://api.github.com/repos/ProtonMail/sieve.js/issues/events{/number}","events_url":"https://api.github.com/repos/ProtonMail/sieve.js/events","assignees_url":"https://api.github.com/repos/ProtonMail/sieve.js/assignees{/user}","branches_url":"https://api.github.com/repos/ProtonMail/sieve.js/branches{/branch}","tags_url":"https://api.github.com/repos/ProtonMail/sieve.js/tags","blobs_url":"https://api.github.com/repos/ProtonMail/sieve.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ProtonMail/sieve.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ProtonMail/sieve.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/ProtonMail/sieve.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ProtonMail/sieve.js/statuses/{sha}","languages_url":"https://api.github.com/repos/ProtonMail/sieve.js/languages","stargazers_url":"https://api.github.com/repos/ProtonMail/sieve.js/stargazers","contributors_url":"https://api.github.com/repos/ProtonMail/sieve.js/contributors","subscribers_url":"https://api.github.com/repos/ProtonMail/sieve.js/subscribers","subscription_url":"https://api.github.com/repos/ProtonMail/sieve.js/subscription","commits_url":"https://api.github.com/repos/ProtonMail/sieve.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/ProtonMail/sieve.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/ProtonMail/sieve.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/ProtonMail/sieve.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/ProtonMail/sieve.js/contents/{+path}","compare_url":"https://api.github.com/repos/ProtonMail/sieve.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ProtonMail/sieve.js/merges","archive_url":"https://api.github.com/repos/ProtonMail/sieve.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ProtonMail/sieve.js/downloads","issues_url":"https://api.github.com/repos/ProtonMail/sieve.js/issues{/number}","pulls_url":"https://api.github.com/repos/ProtonMail/sieve.js/pulls{/number}","milestones_url":"https://api.github.com/repos/ProtonMail/sieve.js/milestones{/number}","notifications_url":"https://api.github.com/repos/ProtonMail/sieve.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ProtonMail/sieve.js/labels{/name}","releases_url":"https://api.github.com/repos/ProtonMail/sieve.js/releases{/id}","deployments_url":"https://api.github.com/repos/ProtonMail/sieve.js/deployments","created_at":"2016-06-21T14:45:42Z","updated_at":"2018-11-20T15:59:36Z","pushed_at":"2018-11-23T16:52:16Z","git_url":"git://github.com/ProtonMail/sieve.js.git","ssh_url":"[email protected]:ProtonMail/sieve.js.git","clone_url":"https://github.com/ProtonMail/sieve.js.git","svn_url":"https://github.com/ProtonMail/sieve.js","homepage":null,"size":710,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":3,"license":null,"forks":4,"open_issues":3,"watchers":4,"default_branch":"master"}},"base":{"label":"ProtonMail:master","ref":"master","sha":"a65ac55089c94030a859083ade4d865ae35cc0ec","user":{"login":"ProtonMail","id":6953970,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5NTM5NzA=","avatar_url":"https://avatars1.githubusercontent.com/u/6953970?v=4","gravatar_id":"","url":"https://api.github.com/users/ProtonMail","html_url":"https://github.com/ProtonMail","followers_url":"https://api.github.com/users/ProtonMail/followers","following_url":"https://api.github.com/users/ProtonMail/following{/other_user}","gists_url":"https://api.github.com/users/ProtonMail/gists{/gist_id}","starred_url":"https://api.github.com/users/ProtonMail/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ProtonMail/subscriptions","organizations_url":"https://api.github.com/users/ProtonMail/orgs","repos_url":"https://api.github.com/users/ProtonMail/repos","events_url":"https://api.github.com/users/ProtonMail/events{/privacy}","received_events_url":"https://api.github.com/users/ProtonMail/received_events","type":"Organization","site_admin":false},"repo":{"id":61641954,"node_id":"MDEwOlJlcG9zaXRvcnk2MTY0MTk1NA==","name":"sieve.js","full_name":"ProtonMail/sieve.js","private":false,"owner":{"login":"ProtonMail","id":6953970,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5NTM5NzA=","avatar_url":"https://avatars1.githubusercontent.com/u/6953970?v=4","gravatar_id":"","url":"https://api.github.com/users/ProtonMail","html_url":"https://github.com/ProtonMail","followers_url":"https://api.github.com/users/ProtonMail/followers","following_url":"https://api.github.com/users/ProtonMail/following{/other_user}","gists_url":"https://api.github.com/users/ProtonMail/gists{/gist_id}","starred_url":"https://api.github.com/users/ProtonMail/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ProtonMail/subscriptions","organizations_url":"https://api.github.com/users/ProtonMail/orgs","repos_url":"https://api.github.com/users/ProtonMail/repos","events_url":"https://api.github.com/users/ProtonMail/events{/privacy}","received_events_url":"https://api.github.com/users/ProtonMail/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ProtonMail/sieve.js","description":"Javascript library to wrap sieve configuration","fork":false,"url":"https://api.github.com/repos/ProtonMail/sieve.js","forks_url":"https://api.github.com/repos/ProtonMail/sieve.js/forks","keys_url":"https://api.github.com/repos/ProtonMail/sieve.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ProtonMail/sieve.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ProtonMail/sieve.js/teams","hooks_url":"https://api.github.com/repos/ProtonMail/sieve.js/hooks","issue_events_url":"https://api.github.com/repos/ProtonMail/sieve.js/issues/events{/number}","events_url":"https://api.github.com/repos/ProtonMail/sieve.js/events","assignees_url":"https://api.github.com/repos/ProtonMail/sieve.js/assignees{/user}","branches_url":"https://api.github.com/repos/ProtonMail/sieve.js/branches{/branch}","tags_url":"https://api.github.com/repos/ProtonMail/sieve.js/tags","blobs_url":"https://api.github.com/repos/ProtonMail/sieve.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ProtonMail/sieve.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ProtonMail/sieve.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/ProtonMail/sieve.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ProtonMail/sieve.js/statuses/{sha}","languages_url":"https://api.github.com/repos/ProtonMail/sieve.js/languages","stargazers_url":"https://api.github.com/repos/ProtonMail/sieve.js/stargazers","contributors_url":"https://api.github.com/repos/ProtonMail/sieve.js/contributors","subscribers_url":"https://api.github.com/repos/ProtonMail/sieve.js/subscribers","subscription_url":"https://api.github.com/repos/ProtonMail/sieve.js/subscription","commits_url":"https://api.github.com/repos/ProtonMail/sieve.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/ProtonMail/sieve.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/ProtonMail/sieve.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/ProtonMail/sieve.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/ProtonMail/sieve.js/contents/{+path}","compare_url":"https://api.github.com/repos/ProtonMail/sieve.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ProtonMail/sieve.js/merges","archive_url":"https://api.github.com/repos/ProtonMail/sieve.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ProtonMail/sieve.js/downloads","issues_url":"https://api.github.com/repos/ProtonMail/sieve.js/issues{/number}","pulls_url":"https://api.github.com/repos/ProtonMail/sieve.js/pulls{/number}","milestones_url":"https://api.github.com/repos/ProtonMail/sieve.js/milestones{/number}","notifications_url":"https://api.github.com/repos/ProtonMail/sieve.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ProtonMail/sieve.js/labels{/name}","releases_url":"https://api.github.com/repos/ProtonMail/sieve.js/releases{/id}","deployments_url":"https://api.github.com/repos/ProtonMail/sieve.js/deployments","created_at":"2016-06-21T14:45:42Z","updated_at":"2018-11-20T15:59:36Z","pushed_at":"2018-11-23T16:52:16Z","git_url":"git://github.com/ProtonMail/sieve.js.git","ssh_url":"[email protected]:ProtonMail/sieve.js.git","clone_url":"https://github.com/ProtonMail/sieve.js.git","svn_url":"https://github.com/ProtonMail/sieve.js","homepage":null,"size":710,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":3,"license":null,"forks":4,"open_issues":3,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ProtonMail/sieve.js/pulls/8"},"html":{"href":"https://github.com/ProtonMail/sieve.js/pull/8"},"issue":{"href":"https://api.github.com/repos/ProtonMail/sieve.js/issues/8"},"comments":{"href":"https://api.github.com/repos/ProtonMail/sieve.js/issues/8/comments"},"review_comments":{"href":"https://api.github.com/repos/ProtonMail/sieve.js/pulls/8/comments"},"review_comment":{"href":"https://api.github.com/repos/ProtonMail/sieve.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ProtonMail/sieve.js/pulls/8/commits"},"statuses":{"href":"https://api.github.com/repos/ProtonMail/sieve.js/statuses/85d5bc66368229cc418d391a991edc2ac10760f8"}},"author_association":"COLLABORATOR"}} | {
"id": 61641954,
"name": "ProtonMail/sieve.js",
"url": "https://api.github.com/repos/ProtonMail/sieve.js"
} | {
"id": 713283,
"login": "dhoko",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/713283?",
"url": "https://api.github.com/users/dhoko"
} | {
"id": 6953970,
"login": "ProtonMail",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6953970?",
"url": "https://api.github.com/orgs/ProtonMail"
} | 2018-11-26T14:03:25 | 8647383362 | {"actor":{"display_login":"dhoko"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/episode6/android-inject/pulls/comments/205988383","pull_request_review_id":141361509,"id":205988383,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNTk4ODM4Mw==","diff_hunk":"@@ -2,16 +2,17 @@ buildscript {\n repositories {\n jcenter()\n google()\n+ maven { url \"https://oss.sonatype.org/content/repositories/snapshots/\" }\n }\n dependencies {\n- classpath 'com.android.tools.build:gradle:3.1.2'\n- classpath 'com.episode6.hackit.deployable:deployable:0.1.11'\n- classpath 'com.episode6.hackit.gdmc:gdmc:0.1.8'\n+ classpath 'com.android.tools.build:gradle:3.1.3'\n+ classpath 'com.episode6.hackit.deployable:deployable:0.2.0-SNAPSHOT'\n+ classpath 'com.episode6.hackit.gdmc:gdmc:0.1.10-SNAPSHOT'","path":"build.gradle","position":12,"original_position":12,"commit_id":"976c4abadc166b4cc4f9ea079cc370f1d3f1445c","original_commit_id":"976c4abadc166b4cc4f9ea079cc370f1d3f1445c","user":{"login":"ghackett","id":568930,"node_id":"MDQ6VXNlcjU2ODkzMA==","avatar_url":"https://avatars1.githubusercontent.com/u/568930?v=4","gravatar_id":"","url":"https://api.github.com/users/ghackett","html_url":"https://github.com/ghackett","followers_url":"https://api.github.com/users/ghackett/followers","following_url":"https://api.github.com/users/ghackett/following{/other_user}","gists_url":"https://api.github.com/users/ghackett/gists{/gist_id}","starred_url":"https://api.github.com/users/ghackett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ghackett/subscriptions","organizations_url":"https://api.github.com/users/ghackett/orgs","repos_url":"https://api.github.com/users/ghackett/repos","events_url":"https://api.github.com/users/ghackett/events{/privacy}","received_events_url":"https://api.github.com/users/ghackett/received_events","type":"User","site_admin":false},"body":"fix","created_at":"2018-07-29T21:48:44Z","updated_at":"2018-07-29T21:48:47Z","html_url":"https://github.com/episode6/android-inject/pull/1#discussion_r205988383","pull_request_url":"https://api.github.com/repos/episode6/android-inject/pulls/1","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/episode6/android-inject/pulls/comments/205988383"},"html":{"href":"https://github.com/episode6/android-inject/pull/1#discussion_r205988383"},"pull_request":{"href":"https://api.github.com/repos/episode6/android-inject/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/episode6/android-inject/pulls/1","id":204663012,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0NjYzMDEy","html_url":"https://github.com/episode6/android-inject/pull/1","diff_url":"https://github.com/episode6/android-inject/pull/1.diff","patch_url":"https://github.com/episode6/android-inject/pull/1.patch","issue_url":"https://api.github.com/repos/episode6/android-inject/issues/1","number":1,"state":"open","locked":false,"title":"Upgrade [gradle 4.4 -> 4.9, deployable 0.1.12 -> 0.2.0, gdmc 0.1.9 -> 0.1.10]","user":{"login":"ghackett","id":568930,"node_id":"MDQ6VXNlcjU2ODkzMA==","avatar_url":"https://avatars1.githubusercontent.com/u/568930?v=4","gravatar_id":"","url":"https://api.github.com/users/ghackett","html_url":"https://github.com/ghackett","followers_url":"https://api.github.com/users/ghackett/followers","following_url":"https://api.github.com/users/ghackett/following{/other_user}","gists_url":"https://api.github.com/users/ghackett/gists{/gist_id}","starred_url":"https://api.github.com/users/ghackett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ghackett/subscriptions","organizations_url":"https://api.github.com/users/ghackett/orgs","repos_url":"https://api.github.com/users/ghackett/repos","events_url":"https://api.github.com/users/ghackett/events{/privacy}","received_events_url":"https://api.github.com/users/ghackett/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-07-29T21:46:34Z","updated_at":"2018-07-29T21:48:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b4ce4a7ef2d877e04ebf2e4e0cf01126ba85c6ae","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/episode6/android-inject/pulls/1/commits","review_comments_url":"https://api.github.com/repos/episode6/android-inject/pulls/1/comments","review_comment_url":"https://api.github.com/repos/episode6/android-inject/pulls/comments{/number}","comments_url":"https://api.github.com/repos/episode6/android-inject/issues/1/comments","statuses_url":"https://api.github.com/repos/episode6/android-inject/statuses/976c4abadc166b4cc4f9ea079cc370f1d3f1445c","head":{"label":"episode6:feature/gradle-49","ref":"feature/gradle-49","sha":"976c4abadc166b4cc4f9ea079cc370f1d3f1445c","user":{"login":"episode6","id":6998849,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5OTg4NDk=","avatar_url":"https://avatars0.githubusercontent.com/u/6998849?v=4","gravatar_id":"","url":"https://api.github.com/users/episode6","html_url":"https://github.com/episode6","followers_url":"https://api.github.com/users/episode6/followers","following_url":"https://api.github.com/users/episode6/following{/other_user}","gists_url":"https://api.github.com/users/episode6/gists{/gist_id}","starred_url":"https://api.github.com/users/episode6/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/episode6/subscriptions","organizations_url":"https://api.github.com/users/episode6/orgs","repos_url":"https://api.github.com/users/episode6/repos","events_url":"https://api.github.com/users/episode6/events{/privacy}","received_events_url":"https://api.github.com/users/episode6/received_events","type":"Organization","site_admin":false},"repo":{"id":92747011,"node_id":"MDEwOlJlcG9zaXRvcnk5Mjc0NzAxMQ==","name":"android-inject","full_name":"episode6/android-inject","owner":{"login":"episode6","id":6998849,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5OTg4NDk=","avatar_url":"https://avatars0.githubusercontent.com/u/6998849?v=4","gravatar_id":"","url":"https://api.github.com/users/episode6","html_url":"https://github.com/episode6","followers_url":"https://api.github.com/users/episode6/followers","following_url":"https://api.github.com/users/episode6/following{/other_user}","gists_url":"https://api.github.com/users/episode6/gists{/gist_id}","starred_url":"https://api.github.com/users/episode6/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/episode6/subscriptions","organizations_url":"https://api.github.com/users/episode6/orgs","repos_url":"https://api.github.com/users/episode6/repos","events_url":"https://api.github.com/users/episode6/events{/privacy}","received_events_url":"https://api.github.com/users/episode6/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/episode6/android-inject","description":"Some annotations and modules for bootstrapping android apps with dagger2","fork":false,"url":"https://api.github.com/repos/episode6/android-inject","forks_url":"https://api.github.com/repos/episode6/android-inject/forks","keys_url":"https://api.github.com/repos/episode6/android-inject/keys{/key_id}","collaborators_url":"https://api.github.com/repos/episode6/android-inject/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/episode6/android-inject/teams","hooks_url":"https://api.github.com/repos/episode6/android-inject/hooks","issue_events_url":"https://api.github.com/repos/episode6/android-inject/issues/events{/number}","events_url":"https://api.github.com/repos/episode6/android-inject/events","assignees_url":"https://api.github.com/repos/episode6/android-inject/assignees{/user}","branches_url":"https://api.github.com/repos/episode6/android-inject/branches{/branch}","tags_url":"https://api.github.com/repos/episode6/android-inject/tags","blobs_url":"https://api.github.com/repos/episode6/android-inject/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/episode6/android-inject/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/episode6/android-inject/git/refs{/sha}","trees_url":"https://api.github.com/repos/episode6/android-inject/git/trees{/sha}","statuses_url":"https://api.github.com/repos/episode6/android-inject/statuses/{sha}","languages_url":"https://api.github.com/repos/episode6/android-inject/languages","stargazers_url":"https://api.github.com/repos/episode6/android-inject/stargazers","contributors_url":"https://api.github.com/repos/episode6/android-inject/contributors","subscribers_url":"https://api.github.com/repos/episode6/android-inject/subscribers","subscription_url":"https://api.github.com/repos/episode6/android-inject/subscription","commits_url":"https://api.github.com/repos/episode6/android-inject/commits{/sha}","git_commits_url":"https://api.github.com/repos/episode6/android-inject/git/commits{/sha}","comments_url":"https://api.github.com/repos/episode6/android-inject/comments{/number}","issue_comment_url":"https://api.github.com/repos/episode6/android-inject/issues/comments{/number}","contents_url":"https://api.github.com/repos/episode6/android-inject/contents/{+path}","compare_url":"https://api.github.com/repos/episode6/android-inject/compare/{base}...{head}","merges_url":"https://api.github.com/repos/episode6/android-inject/merges","archive_url":"https://api.github.com/repos/episode6/android-inject/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/episode6/android-inject/downloads","issues_url":"https://api.github.com/repos/episode6/android-inject/issues{/number}","pulls_url":"https://api.github.com/repos/episode6/android-inject/pulls{/number}","milestones_url":"https://api.github.com/repos/episode6/android-inject/milestones{/number}","notifications_url":"https://api.github.com/repos/episode6/android-inject/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/episode6/android-inject/labels{/name}","releases_url":"https://api.github.com/repos/episode6/android-inject/releases{/id}","deployments_url":"https://api.github.com/repos/episode6/android-inject/deployments","created_at":"2017-05-29T14:22:17Z","updated_at":"2017-05-30T16:29:22Z","pushed_at":"2018-07-29T21:46:34Z","git_url":"git://github.com/episode6/android-inject.git","ssh_url":"[email protected]:episode6/android-inject.git","clone_url":"https://github.com/episode6/android-inject.git","svn_url":"https://github.com/episode6/android-inject","homepage":null,"size":98,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"episode6:develop","ref":"develop","sha":"73a27a3cfc3e12572d499c800184d8ba6b9e13ed","user":{"login":"episode6","id":6998849,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5OTg4NDk=","avatar_url":"https://avatars0.githubusercontent.com/u/6998849?v=4","gravatar_id":"","url":"https://api.github.com/users/episode6","html_url":"https://github.com/episode6","followers_url":"https://api.github.com/users/episode6/followers","following_url":"https://api.github.com/users/episode6/following{/other_user}","gists_url":"https://api.github.com/users/episode6/gists{/gist_id}","starred_url":"https://api.github.com/users/episode6/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/episode6/subscriptions","organizations_url":"https://api.github.com/users/episode6/orgs","repos_url":"https://api.github.com/users/episode6/repos","events_url":"https://api.github.com/users/episode6/events{/privacy}","received_events_url":"https://api.github.com/users/episode6/received_events","type":"Organization","site_admin":false},"repo":{"id":92747011,"node_id":"MDEwOlJlcG9zaXRvcnk5Mjc0NzAxMQ==","name":"android-inject","full_name":"episode6/android-inject","owner":{"login":"episode6","id":6998849,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5OTg4NDk=","avatar_url":"https://avatars0.githubusercontent.com/u/6998849?v=4","gravatar_id":"","url":"https://api.github.com/users/episode6","html_url":"https://github.com/episode6","followers_url":"https://api.github.com/users/episode6/followers","following_url":"https://api.github.com/users/episode6/following{/other_user}","gists_url":"https://api.github.com/users/episode6/gists{/gist_id}","starred_url":"https://api.github.com/users/episode6/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/episode6/subscriptions","organizations_url":"https://api.github.com/users/episode6/orgs","repos_url":"https://api.github.com/users/episode6/repos","events_url":"https://api.github.com/users/episode6/events{/privacy}","received_events_url":"https://api.github.com/users/episode6/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/episode6/android-inject","description":"Some annotations and modules for bootstrapping android apps with dagger2","fork":false,"url":"https://api.github.com/repos/episode6/android-inject","forks_url":"https://api.github.com/repos/episode6/android-inject/forks","keys_url":"https://api.github.com/repos/episode6/android-inject/keys{/key_id}","collaborators_url":"https://api.github.com/repos/episode6/android-inject/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/episode6/android-inject/teams","hooks_url":"https://api.github.com/repos/episode6/android-inject/hooks","issue_events_url":"https://api.github.com/repos/episode6/android-inject/issues/events{/number}","events_url":"https://api.github.com/repos/episode6/android-inject/events","assignees_url":"https://api.github.com/repos/episode6/android-inject/assignees{/user}","branches_url":"https://api.github.com/repos/episode6/android-inject/branches{/branch}","tags_url":"https://api.github.com/repos/episode6/android-inject/tags","blobs_url":"https://api.github.com/repos/episode6/android-inject/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/episode6/android-inject/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/episode6/android-inject/git/refs{/sha}","trees_url":"https://api.github.com/repos/episode6/android-inject/git/trees{/sha}","statuses_url":"https://api.github.com/repos/episode6/android-inject/statuses/{sha}","languages_url":"https://api.github.com/repos/episode6/android-inject/languages","stargazers_url":"https://api.github.com/repos/episode6/android-inject/stargazers","contributors_url":"https://api.github.com/repos/episode6/android-inject/contributors","subscribers_url":"https://api.github.com/repos/episode6/android-inject/subscribers","subscription_url":"https://api.github.com/repos/episode6/android-inject/subscription","commits_url":"https://api.github.com/repos/episode6/android-inject/commits{/sha}","git_commits_url":"https://api.github.com/repos/episode6/android-inject/git/commits{/sha}","comments_url":"https://api.github.com/repos/episode6/android-inject/comments{/number}","issue_comment_url":"https://api.github.com/repos/episode6/android-inject/issues/comments{/number}","contents_url":"https://api.github.com/repos/episode6/android-inject/contents/{+path}","compare_url":"https://api.github.com/repos/episode6/android-inject/compare/{base}...{head}","merges_url":"https://api.github.com/repos/episode6/android-inject/merges","archive_url":"https://api.github.com/repos/episode6/android-inject/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/episode6/android-inject/downloads","issues_url":"https://api.github.com/repos/episode6/android-inject/issues{/number}","pulls_url":"https://api.github.com/repos/episode6/android-inject/pulls{/number}","milestones_url":"https://api.github.com/repos/episode6/android-inject/milestones{/number}","notifications_url":"https://api.github.com/repos/episode6/android-inject/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/episode6/android-inject/labels{/name}","releases_url":"https://api.github.com/repos/episode6/android-inject/releases{/id}","deployments_url":"https://api.github.com/repos/episode6/android-inject/deployments","created_at":"2017-05-29T14:22:17Z","updated_at":"2017-05-30T16:29:22Z","pushed_at":"2018-07-29T21:46:34Z","git_url":"git://github.com/episode6/android-inject.git","ssh_url":"[email protected]:episode6/android-inject.git","clone_url":"https://github.com/episode6/android-inject.git","svn_url":"https://github.com/episode6/android-inject","homepage":null,"size":98,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/episode6/android-inject/pulls/1"},"html":{"href":"https://github.com/episode6/android-inject/pull/1"},"issue":{"href":"https://api.github.com/repos/episode6/android-inject/issues/1"},"comments":{"href":"https://api.github.com/repos/episode6/android-inject/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/episode6/android-inject/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/episode6/android-inject/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/episode6/android-inject/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/episode6/android-inject/statuses/976c4abadc166b4cc4f9ea079cc370f1d3f1445c"}},"author_association":"MEMBER"}} | {
"id": 92747011,
"name": "episode6/android-inject",
"url": "https://api.github.com/repos/episode6/android-inject"
} | {
"id": 568930,
"login": "ghackett",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/568930?",
"url": "https://api.github.com/users/ghackett"
} | {
"id": 6998849,
"login": "episode6",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6998849?",
"url": "https://api.github.com/orgs/episode6"
} | 2018-07-29T21:48:44 | 8034699134 | {"actor":{"display_login":"ghackett"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/SpectraLogic/kotlin-utils/pulls/comments/165686771","pull_request_review_id":93669595,"id":165686771,"diff_hunk":"@@ -0,0 +1,33 @@\n+package com.spectralogic.kotlinutils.core","path":"guava/src/test/kotlin/com/spectralogic/kotlinutils/core/curryTest.kt","position":1,"original_position":1,"commit_id":"2a55a70047b0a5089fe8cf28648e969f45668cf9","original_commit_id":"2a55a70047b0a5089fe8cf28648e969f45668cf9","user":{"login":"rpmoore","id":1901294,"avatar_url":"https://avatars2.githubusercontent.com/u/1901294?v=4","gravatar_id":"","url":"https://api.github.com/users/rpmoore","html_url":"https://github.com/rpmoore","followers_url":"https://api.github.com/users/rpmoore/followers","following_url":"https://api.github.com/users/rpmoore/following{/other_user}","gists_url":"https://api.github.com/users/rpmoore/gists{/gist_id}","starred_url":"https://api.github.com/users/rpmoore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rpmoore/subscriptions","organizations_url":"https://api.github.com/users/rpmoore/orgs","repos_url":"https://api.github.com/users/rpmoore/repos","events_url":"https://api.github.com/users/rpmoore/events{/privacy}","received_events_url":"https://api.github.com/users/rpmoore/received_events","type":"User","site_admin":false},"body":"Capitalize this filename","created_at":"2018-02-02T16:09:22Z","updated_at":"2018-02-02T16:11:47Z","html_url":"https://github.com/SpectraLogic/kotlin-utils/pull/1#discussion_r165686771","pull_request_url":"https://api.github.com/repos/SpectraLogic/kotlin-utils/pulls/1","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/SpectraLogic/kotlin-utils/pulls/comments/165686771"},"html":{"href":"https://github.com/SpectraLogic/kotlin-utils/pull/1#discussion_r165686771"},"pull_request":{"href":"https://api.github.com/repos/SpectraLogic/kotlin-utils/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/SpectraLogic/kotlin-utils/pulls/1","id":165465416,"html_url":"https://github.com/SpectraLogic/kotlin-utils/pull/1","diff_url":"https://github.com/SpectraLogic/kotlin-utils/pull/1.diff","patch_url":"https://github.com/SpectraLogic/kotlin-utils/pull/1.patch","issue_url":"https://api.github.com/repos/SpectraLogic/kotlin-utils/issues/1","number":1,"state":"open","locked":false,"title":"Initial","user":{"login":"scribe","id":192110,"avatar_url":"https://avatars2.githubusercontent.com/u/192110?v=4","gravatar_id":"","url":"https://api.github.com/users/scribe","html_url":"https://github.com/scribe","followers_url":"https://api.github.com/users/scribe/followers","following_url":"https://api.github.com/users/scribe/following{/other_user}","gists_url":"https://api.github.com/users/scribe/gists{/gist_id}","starred_url":"https://api.github.com/users/scribe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scribe/subscriptions","organizations_url":"https://api.github.com/users/scribe/orgs","repos_url":"https://api.github.com/users/scribe/repos","events_url":"https://api.github.com/users/scribe/events{/privacy}","received_events_url":"https://api.github.com/users/scribe/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-01-26T21:31:12Z","updated_at":"2018-02-02T16:11:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ef3234d794a154bf6d56c1075949a87acbae7900","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/SpectraLogic/kotlin-utils/pulls/1/commits","review_comments_url":"https://api.github.com/repos/SpectraLogic/kotlin-utils/pulls/1/comments","review_comment_url":"https://api.github.com/repos/SpectraLogic/kotlin-utils/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SpectraLogic/kotlin-utils/issues/1/comments","statuses_url":"https://api.github.com/repos/SpectraLogic/kotlin-utils/statuses/2a55a70047b0a5089fe8cf28648e969f45668cf9","head":{"label":"scribe:master","ref":"master","sha":"2a55a70047b0a5089fe8cf28648e969f45668cf9","user":{"login":"scribe","id":192110,"avatar_url":"https://avatars2.githubusercontent.com/u/192110?v=4","gravatar_id":"","url":"https://api.github.com/users/scribe","html_url":"https://github.com/scribe","followers_url":"https://api.github.com/users/scribe/followers","following_url":"https://api.github.com/users/scribe/following{/other_user}","gists_url":"https://api.github.com/users/scribe/gists{/gist_id}","starred_url":"https://api.github.com/users/scribe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scribe/subscriptions","organizations_url":"https://api.github.com/users/scribe/orgs","repos_url":"https://api.github.com/users/scribe/repos","events_url":"https://api.github.com/users/scribe/events{/privacy}","received_events_url":"https://api.github.com/users/scribe/received_events","type":"User","site_admin":false},"repo":{"id":119076531,"name":"kotlin-utils","full_name":"scribe/kotlin-utils","owner":{"login":"scribe","id":192110,"avatar_url":"https://avatars2.githubusercontent.com/u/192110?v=4","gravatar_id":"","url":"https://api.github.com/users/scribe","html_url":"https://github.com/scribe","followers_url":"https://api.github.com/users/scribe/followers","following_url":"https://api.github.com/users/scribe/following{/other_user}","gists_url":"https://api.github.com/users/scribe/gists{/gist_id}","starred_url":"https://api.github.com/users/scribe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scribe/subscriptions","organizations_url":"https://api.github.com/users/scribe/orgs","repos_url":"https://api.github.com/users/scribe/repos","events_url":"https://api.github.com/users/scribe/events{/privacy}","received_events_url":"https://api.github.com/users/scribe/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/scribe/kotlin-utils","description":null,"fork":true,"url":"https://api.github.com/repos/scribe/kotlin-utils","forks_url":"https://api.github.com/repos/scribe/kotlin-utils/forks","keys_url":"https://api.github.com/repos/scribe/kotlin-utils/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scribe/kotlin-utils/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scribe/kotlin-utils/teams","hooks_url":"https://api.github.com/repos/scribe/kotlin-utils/hooks","issue_events_url":"https://api.github.com/repos/scribe/kotlin-utils/issues/events{/number}","events_url":"https://api.github.com/repos/scribe/kotlin-utils/events","assignees_url":"https://api.github.com/repos/scribe/kotlin-utils/assignees{/user}","branches_url":"https://api.github.com/repos/scribe/kotlin-utils/branches{/branch}","tags_url":"https://api.github.com/repos/scribe/kotlin-utils/tags","blobs_url":"https://api.github.com/repos/scribe/kotlin-utils/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scribe/kotlin-utils/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scribe/kotlin-utils/git/refs{/sha}","trees_url":"https://api.github.com/repos/scribe/kotlin-utils/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scribe/kotlin-utils/statuses/{sha}","languages_url":"https://api.github.com/repos/scribe/kotlin-utils/languages","stargazers_url":"https://api.github.com/repos/scribe/kotlin-utils/stargazers","contributors_url":"https://api.github.com/repos/scribe/kotlin-utils/contributors","subscribers_url":"https://api.github.com/repos/scribe/kotlin-utils/subscribers","subscription_url":"https://api.github.com/repos/scribe/kotlin-utils/subscription","commits_url":"https://api.github.com/repos/scribe/kotlin-utils/commits{/sha}","git_commits_url":"https://api.github.com/repos/scribe/kotlin-utils/git/commits{/sha}","comments_url":"https://api.github.com/repos/scribe/kotlin-utils/comments{/number}","issue_comment_url":"https://api.github.com/repos/scribe/kotlin-utils/issues/comments{/number}","contents_url":"https://api.github.com/repos/scribe/kotlin-utils/contents/{+path}","compare_url":"https://api.github.com/repos/scribe/kotlin-utils/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scribe/kotlin-utils/merges","archive_url":"https://api.github.com/repos/scribe/kotlin-utils/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scribe/kotlin-utils/downloads","issues_url":"https://api.github.com/repos/scribe/kotlin-utils/issues{/number}","pulls_url":"https://api.github.com/repos/scribe/kotlin-utils/pulls{/number}","milestones_url":"https://api.github.com/repos/scribe/kotlin-utils/milestones{/number}","notifications_url":"https://api.github.com/repos/scribe/kotlin-utils/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scribe/kotlin-utils/labels{/name}","releases_url":"https://api.github.com/repos/scribe/kotlin-utils/releases{/id}","deployments_url":"https://api.github.com/repos/scribe/kotlin-utils/deployments","created_at":"2018-01-26T16:38:23Z","updated_at":"2018-01-26T21:30:45Z","pushed_at":"2018-01-26T21:30:43Z","git_url":"git://github.com/scribe/kotlin-utils.git","ssh_url":"[email protected]:scribe/kotlin-utils.git","clone_url":"https://github.com/scribe/kotlin-utils.git","svn_url":"https://github.com/scribe/kotlin-utils","homepage":null,"size":11,"stargazers_count":0,"watchers_count":0,"language":"Kotlin","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"SpectraLogic:master","ref":"master","sha":"e61c7b14fe8c7b624e15fd5b0219ad3ff764cd98","user":{"login":"SpectraLogic","id":7060807,"avatar_url":"https://avatars1.githubusercontent.com/u/7060807?v=4","gravatar_id":"","url":"https://api.github.com/users/SpectraLogic","html_url":"https://github.com/SpectraLogic","followers_url":"https://api.github.com/users/SpectraLogic/followers","following_url":"https://api.github.com/users/SpectraLogic/following{/other_user}","gists_url":"https://api.github.com/users/SpectraLogic/gists{/gist_id}","starred_url":"https://api.github.com/users/SpectraLogic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SpectraLogic/subscriptions","organizations_url":"https://api.github.com/users/SpectraLogic/orgs","repos_url":"https://api.github.com/users/SpectraLogic/repos","events_url":"https://api.github.com/users/SpectraLogic/events{/privacy}","received_events_url":"https://api.github.com/users/SpectraLogic/received_events","type":"Organization","site_admin":false},"repo":{"id":119076020,"name":"kotlin-utils","full_name":"SpectraLogic/kotlin-utils","owner":{"login":"SpectraLogic","id":7060807,"avatar_url":"https://avatars1.githubusercontent.com/u/7060807?v=4","gravatar_id":"","url":"https://api.github.com/users/SpectraLogic","html_url":"https://github.com/SpectraLogic","followers_url":"https://api.github.com/users/SpectraLogic/followers","following_url":"https://api.github.com/users/SpectraLogic/following{/other_user}","gists_url":"https://api.github.com/users/SpectraLogic/gists{/gist_id}","starred_url":"https://api.github.com/users/SpectraLogic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SpectraLogic/subscriptions","organizations_url":"https://api.github.com/users/SpectraLogic/orgs","repos_url":"https://api.github.com/users/SpectraLogic/repos","events_url":"https://api.github.com/users/SpectraLogic/events{/privacy}","received_events_url":"https://api.github.com/users/SpectraLogic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SpectraLogic/kotlin-utils","description":null,"fork":false,"url":"https://api.github.com/repos/SpectraLogic/kotlin-utils","forks_url":"https://api.github.com/repos/SpectraLogic/kotlin-utils/forks","keys_url":"https://api.github.com/repos/SpectraLogic/kotlin-utils/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SpectraLogic/kotlin-utils/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SpectraLogic/kotlin-utils/teams","hooks_url":"https://api.github.com/repos/SpectraLogic/kotlin-utils/hooks","issue_events_url":"https://api.github.com/repos/SpectraLogic/kotlin-utils/issues/events{/number}","events_url":"https://api.github.com/repos/SpectraLogic/kotlin-utils/events","assignees_url":"https://api.github.com/repos/SpectraLogic/kotlin-utils/assignees{/user}","branches_url":"https://api.github.com/repos/SpectraLogic/kotlin-utils/branches{/branch}","tags_url":"https://api.github.com/repos/SpectraLogic/kotlin-utils/tags","blobs_url":"https://api.github.com/repos/SpectraLogic/kotlin-utils/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SpectraLogic/kotlin-utils/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SpectraLogic/kotlin-utils/git/refs{/sha}","trees_url":"https://api.github.com/repos/SpectraLogic/kotlin-utils/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SpectraLogic/kotlin-utils/statuses/{sha}","languages_url":"https://api.github.com/repos/SpectraLogic/kotlin-utils/languages","stargazers_url":"https://api.github.com/repos/SpectraLogic/kotlin-utils/stargazers","contributors_url":"https://api.github.com/repos/SpectraLogic/kotlin-utils/contributors","subscribers_url":"https://api.github.com/repos/SpectraLogic/kotlin-utils/subscribers","subscription_url":"https://api.github.com/repos/SpectraLogic/kotlin-utils/subscription","commits_url":"https://api.github.com/repos/SpectraLogic/kotlin-utils/commits{/sha}","git_commits_url":"https://api.github.com/repos/SpectraLogic/kotlin-utils/git/commits{/sha}","comments_url":"https://api.github.com/repos/SpectraLogic/kotlin-utils/comments{/number}","issue_comment_url":"https://api.github.com/repos/SpectraLogic/kotlin-utils/issues/comments{/number}","contents_url":"https://api.github.com/repos/SpectraLogic/kotlin-utils/contents/{+path}","compare_url":"https://api.github.com/repos/SpectraLogic/kotlin-utils/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SpectraLogic/kotlin-utils/merges","archive_url":"https://api.github.com/repos/SpectraLogic/kotlin-utils/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SpectraLogic/kotlin-utils/downloads","issues_url":"https://api.github.com/repos/SpectraLogic/kotlin-utils/issues{/number}","pulls_url":"https://api.github.com/repos/SpectraLogic/kotlin-utils/pulls{/number}","milestones_url":"https://api.github.com/repos/SpectraLogic/kotlin-utils/milestones{/number}","notifications_url":"https://api.github.com/repos/SpectraLogic/kotlin-utils/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SpectraLogic/kotlin-utils/labels{/name}","releases_url":"https://api.github.com/repos/SpectraLogic/kotlin-utils/releases{/id}","deployments_url":"https://api.github.com/repos/SpectraLogic/kotlin-utils/deployments","created_at":"2018-01-26T16:34:25Z","updated_at":"2018-01-26T16:34:25Z","pushed_at":"2018-01-26T21:31:13Z","git_url":"git://github.com/SpectraLogic/kotlin-utils.git","ssh_url":"[email protected]:SpectraLogic/kotlin-utils.git","clone_url":"https://github.com/SpectraLogic/kotlin-utils.git","svn_url":"https://github.com/SpectraLogic/kotlin-utils","homepage":null,"size":5,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SpectraLogic/kotlin-utils/pulls/1"},"html":{"href":"https://github.com/SpectraLogic/kotlin-utils/pull/1"},"issue":{"href":"https://api.github.com/repos/SpectraLogic/kotlin-utils/issues/1"},"comments":{"href":"https://api.github.com/repos/SpectraLogic/kotlin-utils/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/SpectraLogic/kotlin-utils/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/SpectraLogic/kotlin-utils/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SpectraLogic/kotlin-utils/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/SpectraLogic/kotlin-utils/statuses/2a55a70047b0a5089fe8cf28648e969f45668cf9"}},"author_association":"NONE"}} | {
"id": 119076020,
"name": "SpectraLogic/kotlin-utils",
"url": "https://api.github.com/repos/SpectraLogic/kotlin-utils"
} | {
"id": 1901294,
"login": "rpmoore",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1901294?",
"url": "https://api.github.com/users/rpmoore"
} | {
"id": 7060807,
"login": "SpectraLogic",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7060807?",
"url": "https://api.github.com/orgs/SpectraLogic"
} | 2018-02-02T16:09:22 | 7190113852 | {"actor":{"display_login":"rpmoore"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/ioBroker/ioBroker.js-controller/pulls/comments/235425900","pull_request_review_id":177287929,"id":235425900,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNTQyNTkwMA==","diff_hunk":"@@ -1137,8 +1139,13 @@ function Adapter(options) {\n if (!obj.common.hasOwnProperty('type')) {\r\n logger.warn(that.namespace + ' setObject ' + id + ' (type=' + obj.type + ') property common.type missing!');\r\n }\r\n+ if (obj.common.hasOwnProperty('def') && obj.common.def !== undefined) {\r","path":"lib/adapter.js","position":24,"original_position":24,"commit_id":"d50e6e1bd49703737d82bc9e0f8c00671adcb91d","original_commit_id":"d50e6e1bd49703737d82bc9e0f8c00671adcb91d","user":{"login":"AlCalzone","id":17641229,"node_id":"MDQ6VXNlcjE3NjQxMjI5","avatar_url":"https://avatars2.githubusercontent.com/u/17641229?v=4","gravatar_id":"","url":"https://api.github.com/users/AlCalzone","html_url":"https://github.com/AlCalzone","followers_url":"https://api.github.com/users/AlCalzone/followers","following_url":"https://api.github.com/users/AlCalzone/following{/other_user}","gists_url":"https://api.github.com/users/AlCalzone/gists{/gist_id}","starred_url":"https://api.github.com/users/AlCalzone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlCalzone/subscriptions","organizations_url":"https://api.github.com/users/AlCalzone/orgs","repos_url":"https://api.github.com/users/AlCalzone/repos","events_url":"https://api.github.com/users/AlCalzone/events{/privacy}","received_events_url":"https://api.github.com/users/AlCalzone/received_events","type":"User","site_admin":false},"body":"This could just be `if (obj.common.def != undefined)`. `!=` checks for `null` and `undefined` as opposed to `!==`","created_at":"2018-11-21T15:13:51Z","updated_at":"2018-11-21T15:13:51Z","html_url":"https://github.com/ioBroker/ioBroker.js-controller/pull/273#discussion_r235425900","pull_request_url":"https://api.github.com/repos/ioBroker/ioBroker.js-controller/pulls/273","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ioBroker/ioBroker.js-controller/pulls/comments/235425900"},"html":{"href":"https://github.com/ioBroker/ioBroker.js-controller/pull/273#discussion_r235425900"},"pull_request":{"href":"https://api.github.com/repos/ioBroker/ioBroker.js-controller/pulls/273"}}},"pull_request":{"url":"https://api.github.com/repos/ioBroker/ioBroker.js-controller/pulls/273","id":232464688,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMyNDY0Njg4","html_url":"https://github.com/ioBroker/ioBroker.js-controller/pull/273","diff_url":"https://github.com/ioBroker/ioBroker.js-controller/pull/273.diff","patch_url":"https://github.com/ioBroker/ioBroker.js-controller/pull/273.patch","issue_url":"https://api.github.com/repos/ioBroker/ioBroker.js-controller/issues/273","number":273,"state":"open","locked":false,"title":"set obj.common.def as initial value","user":{"login":"foxriver76","id":25484431,"node_id":"MDQ6VXNlcjI1NDg0NDMx","avatar_url":"https://avatars0.githubusercontent.com/u/25484431?v=4","gravatar_id":"","url":"https://api.github.com/users/foxriver76","html_url":"https://github.com/foxriver76","followers_url":"https://api.github.com/users/foxriver76/followers","following_url":"https://api.github.com/users/foxriver76/following{/other_user}","gists_url":"https://api.github.com/users/foxriver76/gists{/gist_id}","starred_url":"https://api.github.com/users/foxriver76/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/foxriver76/subscriptions","organizations_url":"https://api.github.com/users/foxriver76/orgs","repos_url":"https://api.github.com/users/foxriver76/repos","events_url":"https://api.github.com/users/foxriver76/events{/privacy}","received_events_url":"https://api.github.com/users/foxriver76/received_events","type":"User","site_admin":false},"body":"-on setObject\r\n-and setObjectNotExists\r\n-solves #228 \r\n\r\nsorry, some lines have been formatted accidentally","created_at":"2018-11-20T21:28:14Z","updated_at":"2018-11-21T15:13:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"07cd5f471a2fc9de364429789b9f5b173e06da03","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ioBroker/ioBroker.js-controller/pulls/273/commits","review_comments_url":"https://api.github.com/repos/ioBroker/ioBroker.js-controller/pulls/273/comments","review_comment_url":"https://api.github.com/repos/ioBroker/ioBroker.js-controller/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ioBroker/ioBroker.js-controller/issues/273/comments","statuses_url":"https://api.github.com/repos/ioBroker/ioBroker.js-controller/statuses/d50e6e1bd49703737d82bc9e0f8c00671adcb91d","head":{"label":"foxriver76:fox76-dev","ref":"fox76-dev","sha":"d50e6e1bd49703737d82bc9e0f8c00671adcb91d","user":{"login":"foxriver76","id":25484431,"node_id":"MDQ6VXNlcjI1NDg0NDMx","avatar_url":"https://avatars0.githubusercontent.com/u/25484431?v=4","gravatar_id":"","url":"https://api.github.com/users/foxriver76","html_url":"https://github.com/foxriver76","followers_url":"https://api.github.com/users/foxriver76/followers","following_url":"https://api.github.com/users/foxriver76/following{/other_user}","gists_url":"https://api.github.com/users/foxriver76/gists{/gist_id}","starred_url":"https://api.github.com/users/foxriver76/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/foxriver76/subscriptions","organizations_url":"https://api.github.com/users/foxriver76/orgs","repos_url":"https://api.github.com/users/foxriver76/repos","events_url":"https://api.github.com/users/foxriver76/events{/privacy}","received_events_url":"https://api.github.com/users/foxriver76/received_events","type":"User","site_admin":false},"repo":{"id":153521823,"node_id":"MDEwOlJlcG9zaXRvcnkxNTM1MjE4MjM=","name":"ioBroker.js-controller","full_name":"foxriver76/ioBroker.js-controller","private":false,"owner":{"login":"foxriver76","id":25484431,"node_id":"MDQ6VXNlcjI1NDg0NDMx","avatar_url":"https://avatars0.githubusercontent.com/u/25484431?v=4","gravatar_id":"","url":"https://api.github.com/users/foxriver76","html_url":"https://github.com/foxriver76","followers_url":"https://api.github.com/users/foxriver76/followers","following_url":"https://api.github.com/users/foxriver76/following{/other_user}","gists_url":"https://api.github.com/users/foxriver76/gists{/gist_id}","starred_url":"https://api.github.com/users/foxriver76/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/foxriver76/subscriptions","organizations_url":"https://api.github.com/users/foxriver76/orgs","repos_url":"https://api.github.com/users/foxriver76/repos","events_url":"https://api.github.com/users/foxriver76/events{/privacy}","received_events_url":"https://api.github.com/users/foxriver76/received_events","type":"User","site_admin":false},"html_url":"https://github.com/foxriver76/ioBroker.js-controller","description":"ioBroker controller","fork":true,"url":"https://api.github.com/repos/foxriver76/ioBroker.js-controller","forks_url":"https://api.github.com/repos/foxriver76/ioBroker.js-controller/forks","keys_url":"https://api.github.com/repos/foxriver76/ioBroker.js-controller/keys{/key_id}","collaborators_url":"https://api.github.com/repos/foxriver76/ioBroker.js-controller/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/foxriver76/ioBroker.js-controller/teams","hooks_url":"https://api.github.com/repos/foxriver76/ioBroker.js-controller/hooks","issue_events_url":"https://api.github.com/repos/foxriver76/ioBroker.js-controller/issues/events{/number}","events_url":"https://api.github.com/repos/foxriver76/ioBroker.js-controller/events","assignees_url":"https://api.github.com/repos/foxriver76/ioBroker.js-controller/assignees{/user}","branches_url":"https://api.github.com/repos/foxriver76/ioBroker.js-controller/branches{/branch}","tags_url":"https://api.github.com/repos/foxriver76/ioBroker.js-controller/tags","blobs_url":"https://api.github.com/repos/foxriver76/ioBroker.js-controller/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/foxriver76/ioBroker.js-controller/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/foxriver76/ioBroker.js-controller/git/refs{/sha}","trees_url":"https://api.github.com/repos/foxriver76/ioBroker.js-controller/git/trees{/sha}","statuses_url":"https://api.github.com/repos/foxriver76/ioBroker.js-controller/statuses/{sha}","languages_url":"https://api.github.com/repos/foxriver76/ioBroker.js-controller/languages","stargazers_url":"https://api.github.com/repos/foxriver76/ioBroker.js-controller/stargazers","contributors_url":"https://api.github.com/repos/foxriver76/ioBroker.js-controller/contributors","subscribers_url":"https://api.github.com/repos/foxriver76/ioBroker.js-controller/subscribers","subscription_url":"https://api.github.com/repos/foxriver76/ioBroker.js-controller/subscription","commits_url":"https://api.github.com/repos/foxriver76/ioBroker.js-controller/commits{/sha}","git_commits_url":"https://api.github.com/repos/foxriver76/ioBroker.js-controller/git/commits{/sha}","comments_url":"https://api.github.com/repos/foxriver76/ioBroker.js-controller/comments{/number}","issue_comment_url":"https://api.github.com/repos/foxriver76/ioBroker.js-controller/issues/comments{/number}","contents_url":"https://api.github.com/repos/foxriver76/ioBroker.js-controller/contents/{+path}","compare_url":"https://api.github.com/repos/foxriver76/ioBroker.js-controller/compare/{base}...{head}","merges_url":"https://api.github.com/repos/foxriver76/ioBroker.js-controller/merges","archive_url":"https://api.github.com/repos/foxriver76/ioBroker.js-controller/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/foxriver76/ioBroker.js-controller/downloads","issues_url":"https://api.github.com/repos/foxriver76/ioBroker.js-controller/issues{/number}","pulls_url":"https://api.github.com/repos/foxriver76/ioBroker.js-controller/pulls{/number}","milestones_url":"https://api.github.com/repos/foxriver76/ioBroker.js-controller/milestones{/number}","notifications_url":"https://api.github.com/repos/foxriver76/ioBroker.js-controller/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/foxriver76/ioBroker.js-controller/labels{/name}","releases_url":"https://api.github.com/repos/foxriver76/ioBroker.js-controller/releases{/id}","deployments_url":"https://api.github.com/repos/foxriver76/ioBroker.js-controller/deployments","created_at":"2018-10-17T20:48:28Z","updated_at":"2018-10-17T20:48:31Z","pushed_at":"2018-11-20T23:36:15Z","git_url":"git://github.com/foxriver76/ioBroker.js-controller.git","ssh_url":"[email protected]:foxriver76/ioBroker.js-controller.git","clone_url":"https://github.com/foxriver76/ioBroker.js-controller.git","svn_url":"https://github.com/foxriver76/ioBroker.js-controller","homepage":"http://iobroker.net","size":73440,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ioBroker:1.6.0-dev","ref":"1.6.0-dev","sha":"e0dc618f7191c7766c5bf4260ae4790327a18af9","user":{"login":"ioBroker","id":7231148,"node_id":"MDEyOk9yZ2FuaXphdGlvbjcyMzExNDg=","avatar_url":"https://avatars1.githubusercontent.com/u/7231148?v=4","gravatar_id":"","url":"https://api.github.com/users/ioBroker","html_url":"https://github.com/ioBroker","followers_url":"https://api.github.com/users/ioBroker/followers","following_url":"https://api.github.com/users/ioBroker/following{/other_user}","gists_url":"https://api.github.com/users/ioBroker/gists{/gist_id}","starred_url":"https://api.github.com/users/ioBroker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ioBroker/subscriptions","organizations_url":"https://api.github.com/users/ioBroker/orgs","repos_url":"https://api.github.com/users/ioBroker/repos","events_url":"https://api.github.com/users/ioBroker/events{/privacy}","received_events_url":"https://api.github.com/users/ioBroker/received_events","type":"Organization","site_admin":false},"repo":{"id":22116780,"node_id":"MDEwOlJlcG9zaXRvcnkyMjExNjc4MA==","name":"ioBroker.js-controller","full_name":"ioBroker/ioBroker.js-controller","private":false,"owner":{"login":"ioBroker","id":7231148,"node_id":"MDEyOk9yZ2FuaXphdGlvbjcyMzExNDg=","avatar_url":"https://avatars1.githubusercontent.com/u/7231148?v=4","gravatar_id":"","url":"https://api.github.com/users/ioBroker","html_url":"https://github.com/ioBroker","followers_url":"https://api.github.com/users/ioBroker/followers","following_url":"https://api.github.com/users/ioBroker/following{/other_user}","gists_url":"https://api.github.com/users/ioBroker/gists{/gist_id}","starred_url":"https://api.github.com/users/ioBroker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ioBroker/subscriptions","organizations_url":"https://api.github.com/users/ioBroker/orgs","repos_url":"https://api.github.com/users/ioBroker/repos","events_url":"https://api.github.com/users/ioBroker/events{/privacy}","received_events_url":"https://api.github.com/users/ioBroker/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ioBroker/ioBroker.js-controller","description":"ioBroker controller","fork":false,"url":"https://api.github.com/repos/ioBroker/ioBroker.js-controller","forks_url":"https://api.github.com/repos/ioBroker/ioBroker.js-controller/forks","keys_url":"https://api.github.com/repos/ioBroker/ioBroker.js-controller/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ioBroker/ioBroker.js-controller/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ioBroker/ioBroker.js-controller/teams","hooks_url":"https://api.github.com/repos/ioBroker/ioBroker.js-controller/hooks","issue_events_url":"https://api.github.com/repos/ioBroker/ioBroker.js-controller/issues/events{/number}","events_url":"https://api.github.com/repos/ioBroker/ioBroker.js-controller/events","assignees_url":"https://api.github.com/repos/ioBroker/ioBroker.js-controller/assignees{/user}","branches_url":"https://api.github.com/repos/ioBroker/ioBroker.js-controller/branches{/branch}","tags_url":"https://api.github.com/repos/ioBroker/ioBroker.js-controller/tags","blobs_url":"https://api.github.com/repos/ioBroker/ioBroker.js-controller/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ioBroker/ioBroker.js-controller/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ioBroker/ioBroker.js-controller/git/refs{/sha}","trees_url":"https://api.github.com/repos/ioBroker/ioBroker.js-controller/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ioBroker/ioBroker.js-controller/statuses/{sha}","languages_url":"https://api.github.com/repos/ioBroker/ioBroker.js-controller/languages","stargazers_url":"https://api.github.com/repos/ioBroker/ioBroker.js-controller/stargazers","contributors_url":"https://api.github.com/repos/ioBroker/ioBroker.js-controller/contributors","subscribers_url":"https://api.github.com/repos/ioBroker/ioBroker.js-controller/subscribers","subscription_url":"https://api.github.com/repos/ioBroker/ioBroker.js-controller/subscription","commits_url":"https://api.github.com/repos/ioBroker/ioBroker.js-controller/commits{/sha}","git_commits_url":"https://api.github.com/repos/ioBroker/ioBroker.js-controller/git/commits{/sha}","comments_url":"https://api.github.com/repos/ioBroker/ioBroker.js-controller/comments{/number}","issue_comment_url":"https://api.github.com/repos/ioBroker/ioBroker.js-controller/issues/comments{/number}","contents_url":"https://api.github.com/repos/ioBroker/ioBroker.js-controller/contents/{+path}","compare_url":"https://api.github.com/repos/ioBroker/ioBroker.js-controller/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ioBroker/ioBroker.js-controller/merges","archive_url":"https://api.github.com/repos/ioBroker/ioBroker.js-controller/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ioBroker/ioBroker.js-controller/downloads","issues_url":"https://api.github.com/repos/ioBroker/ioBroker.js-controller/issues{/number}","pulls_url":"https://api.github.com/repos/ioBroker/ioBroker.js-controller/pulls{/number}","milestones_url":"https://api.github.com/repos/ioBroker/ioBroker.js-controller/milestones{/number}","notifications_url":"https://api.github.com/repos/ioBroker/ioBroker.js-controller/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ioBroker/ioBroker.js-controller/labels{/name}","releases_url":"https://api.github.com/repos/ioBroker/ioBroker.js-controller/releases{/id}","deployments_url":"https://api.github.com/repos/ioBroker/ioBroker.js-controller/deployments","created_at":"2014-07-22T18:58:09Z","updated_at":"2018-11-20T13:41:48Z","pushed_at":"2018-11-21T15:05:05Z","git_url":"git://github.com/ioBroker/ioBroker.js-controller.git","ssh_url":"[email protected]:ioBroker/ioBroker.js-controller.git","clone_url":"https://github.com/ioBroker/ioBroker.js-controller.git","svn_url":"https://github.com/ioBroker/ioBroker.js-controller","homepage":"http://iobroker.net","size":73346,"stargazers_count":172,"watchers_count":172,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":28,"mirror_url":null,"archived":false,"open_issues_count":41,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":28,"open_issues":41,"watchers":172,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ioBroker/ioBroker.js-controller/pulls/273"},"html":{"href":"https://github.com/ioBroker/ioBroker.js-controller/pull/273"},"issue":{"href":"https://api.github.com/repos/ioBroker/ioBroker.js-controller/issues/273"},"comments":{"href":"https://api.github.com/repos/ioBroker/ioBroker.js-controller/issues/273/comments"},"review_comments":{"href":"https://api.github.com/repos/ioBroker/ioBroker.js-controller/pulls/273/comments"},"review_comment":{"href":"https://api.github.com/repos/ioBroker/ioBroker.js-controller/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ioBroker/ioBroker.js-controller/pulls/273/commits"},"statuses":{"href":"https://api.github.com/repos/ioBroker/ioBroker.js-controller/statuses/d50e6e1bd49703737d82bc9e0f8c00671adcb91d"}},"author_association":"NONE"}} | {
"id": 22116780,
"name": "ioBroker/ioBroker.js-controller",
"url": "https://api.github.com/repos/ioBroker/ioBroker.js-controller"
} | {
"id": 17641229,
"login": "AlCalzone",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/17641229?",
"url": "https://api.github.com/users/AlCalzone"
} | {
"id": 7231148,
"login": "ioBroker",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7231148?",
"url": "https://api.github.com/orgs/ioBroker"
} | 2018-11-21T15:13:51 | 8627549185 | {"actor":{"display_login":"AlCalzone"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/tldr-pages/tldr/pulls/comments/224979331","pull_request_review_id":164484559,"id":224979331,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNDk3OTMzMQ==","diff_hunk":"@@ -0,0 +1,23 @@\n+# mlr\n+\n+> Miller is like awk, sed, cut, join, and sort for name-indexed data such as CSV, TSV, and tabular JSON.\n+\n+- Pretty-print a CSV file in a tabular format:\n+\n+`mlr --icsv --opprint cat {{example.csv}}`\n+\n+- Sort first alphabetically on field1, and then sort in descending numerical order on field2:\n+\n+`mlr --icsv --opprint sort -f {{field1}} -nr {{field2}} {{example.csv}}`\n+\n+- Convert CSV to JSON, performing calculations and outputting those calculations:","path":"pages/common/mlr.md","position":13,"original_position":13,"commit_id":"32c8e7fe793cf07728f6c5d44e9e85987a204522","original_commit_id":"32c8e7fe793cf07728f6c5d44e9e85987a204522","user":{"login":"agnivade","id":1774000,"node_id":"MDQ6VXNlcjE3NzQwMDA=","avatar_url":"https://avatars1.githubusercontent.com/u/1774000?v=4","gravatar_id":"","url":"https://api.github.com/users/agnivade","html_url":"https://github.com/agnivade","followers_url":"https://api.github.com/users/agnivade/followers","following_url":"https://api.github.com/users/agnivade/following{/other_user}","gists_url":"https://api.github.com/users/agnivade/gists{/gist_id}","starred_url":"https://api.github.com/users/agnivade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agnivade/subscriptions","organizations_url":"https://api.github.com/users/agnivade/orgs","repos_url":"https://api.github.com/users/agnivade/repos","events_url":"https://api.github.com/users/agnivade/events{/privacy}","received_events_url":"https://api.github.com/users/agnivade/received_events","type":"User","site_admin":false},"body":"outputting is not a word. How about \"display\" ?","created_at":"2018-10-14T04:41:53Z","updated_at":"2018-10-14T04:41:59Z","html_url":"https://github.com/tldr-pages/tldr/pull/2434#discussion_r224979331","pull_request_url":"https://api.github.com/repos/tldr-pages/tldr/pulls/2434","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/tldr-pages/tldr/pulls/comments/224979331"},"html":{"href":"https://github.com/tldr-pages/tldr/pull/2434#discussion_r224979331"},"pull_request":{"href":"https://api.github.com/repos/tldr-pages/tldr/pulls/2434"}}},"pull_request":{"url":"https://api.github.com/repos/tldr-pages/tldr/pulls/2434","id":222503610,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyNTAzNjEw","html_url":"https://github.com/tldr-pages/tldr/pull/2434","diff_url":"https://github.com/tldr-pages/tldr/pull/2434.diff","patch_url":"https://github.com/tldr-pages/tldr/pull/2434.patch","issue_url":"https://api.github.com/repos/tldr-pages/tldr/issues/2434","number":2434,"state":"open","locked":false,"title":"mlr: add page","user":{"login":"russsaidwords","id":974636,"node_id":"MDQ6VXNlcjk3NDYzNg==","avatar_url":"https://avatars2.githubusercontent.com/u/974636?v=4","gravatar_id":"","url":"https://api.github.com/users/russsaidwords","html_url":"https://github.com/russsaidwords","followers_url":"https://api.github.com/users/russsaidwords/followers","following_url":"https://api.github.com/users/russsaidwords/following{/other_user}","gists_url":"https://api.github.com/users/russsaidwords/gists{/gist_id}","starred_url":"https://api.github.com/users/russsaidwords/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/russsaidwords/subscriptions","organizations_url":"https://api.github.com/users/russsaidwords/orgs","repos_url":"https://api.github.com/users/russsaidwords/repos","events_url":"https://api.github.com/users/russsaidwords/events{/privacy}","received_events_url":"https://api.github.com/users/russsaidwords/received_events","type":"User","site_admin":false},"body":"Closes #2331 \r\n\r\n----\r\n<!-- Thank you for sending a PR! -->\r\n<!-- Please perform the following checks and check all the boxes that apply. -->\r\n<!-- If your PR does not create a command page,\r\n you can remove the first two checklist items. -->\r\n<!-- If your PR neither creates nor edits a command page (e.g. README edits, etc.)\r\n you can simply remove the entire checklist. -->\r\n\r\n- [x] The page (if new), does not already exist in the repo.\r\n\r\n- [x] The page (if new), has been added to the correct platform folder: \r\n `common/` if it's common to all platforms, `linux/` if it's Linux-specific, and so on.\r\n\r\n- [x] The page has 8 or fewer examples.\r\n\r\n- [x] The PR is appropriately titled: \r\n `<command name>: add page` for new pages, or `<command name>: <description of changes>` for pages being edited.\r\n\r\n- [x] The page follows the [contributing](https://github.com/tldr-pages/tldr/blob/master/CONTRIBUTING.md) guidelines.\r\n","created_at":"2018-10-12T15:26:06Z","updated_at":"2018-10-14T04:41:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"272426066ac7a925ebaff5af36ef2f319f7c5cd2","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":70484774,"node_id":"MDU6TGFiZWw3MDQ4NDc3NA==","url":"https://api.github.com/repos/tldr-pages/tldr/labels/new%20command","name":"new command","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/tldr-pages/tldr/pulls/2434/commits","review_comments_url":"https://api.github.com/repos/tldr-pages/tldr/pulls/2434/comments","review_comment_url":"https://api.github.com/repos/tldr-pages/tldr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tldr-pages/tldr/issues/2434/comments","statuses_url":"https://api.github.com/repos/tldr-pages/tldr/statuses/32c8e7fe793cf07728f6c5d44e9e85987a204522","head":{"label":"russsaidwords:miller","ref":"miller","sha":"32c8e7fe793cf07728f6c5d44e9e85987a204522","user":{"login":"russsaidwords","id":974636,"node_id":"MDQ6VXNlcjk3NDYzNg==","avatar_url":"https://avatars2.githubusercontent.com/u/974636?v=4","gravatar_id":"","url":"https://api.github.com/users/russsaidwords","html_url":"https://github.com/russsaidwords","followers_url":"https://api.github.com/users/russsaidwords/followers","following_url":"https://api.github.com/users/russsaidwords/following{/other_user}","gists_url":"https://api.github.com/users/russsaidwords/gists{/gist_id}","starred_url":"https://api.github.com/users/russsaidwords/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/russsaidwords/subscriptions","organizations_url":"https://api.github.com/users/russsaidwords/orgs","repos_url":"https://api.github.com/users/russsaidwords/repos","events_url":"https://api.github.com/users/russsaidwords/events{/privacy}","received_events_url":"https://api.github.com/users/russsaidwords/received_events","type":"User","site_admin":false},"repo":{"id":150515480,"node_id":"MDEwOlJlcG9zaXRvcnkxNTA1MTU0ODA=","name":"tldr","full_name":"russsaidwords/tldr","private":false,"owner":{"login":"russsaidwords","id":974636,"node_id":"MDQ6VXNlcjk3NDYzNg==","avatar_url":"https://avatars2.githubusercontent.com/u/974636?v=4","gravatar_id":"","url":"https://api.github.com/users/russsaidwords","html_url":"https://github.com/russsaidwords","followers_url":"https://api.github.com/users/russsaidwords/followers","following_url":"https://api.github.com/users/russsaidwords/following{/other_user}","gists_url":"https://api.github.com/users/russsaidwords/gists{/gist_id}","starred_url":"https://api.github.com/users/russsaidwords/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/russsaidwords/subscriptions","organizations_url":"https://api.github.com/users/russsaidwords/orgs","repos_url":"https://api.github.com/users/russsaidwords/repos","events_url":"https://api.github.com/users/russsaidwords/events{/privacy}","received_events_url":"https://api.github.com/users/russsaidwords/received_events","type":"User","site_admin":false},"html_url":"https://github.com/russsaidwords/tldr","description":":books: Simplified and community-driven man pages","fork":true,"url":"https://api.github.com/repos/russsaidwords/tldr","forks_url":"https://api.github.com/repos/russsaidwords/tldr/forks","keys_url":"https://api.github.com/repos/russsaidwords/tldr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/russsaidwords/tldr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/russsaidwords/tldr/teams","hooks_url":"https://api.github.com/repos/russsaidwords/tldr/hooks","issue_events_url":"https://api.github.com/repos/russsaidwords/tldr/issues/events{/number}","events_url":"https://api.github.com/repos/russsaidwords/tldr/events","assignees_url":"https://api.github.com/repos/russsaidwords/tldr/assignees{/user}","branches_url":"https://api.github.com/repos/russsaidwords/tldr/branches{/branch}","tags_url":"https://api.github.com/repos/russsaidwords/tldr/tags","blobs_url":"https://api.github.com/repos/russsaidwords/tldr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/russsaidwords/tldr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/russsaidwords/tldr/git/refs{/sha}","trees_url":"https://api.github.com/repos/russsaidwords/tldr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/russsaidwords/tldr/statuses/{sha}","languages_url":"https://api.github.com/repos/russsaidwords/tldr/languages","stargazers_url":"https://api.github.com/repos/russsaidwords/tldr/stargazers","contributors_url":"https://api.github.com/repos/russsaidwords/tldr/contributors","subscribers_url":"https://api.github.com/repos/russsaidwords/tldr/subscribers","subscription_url":"https://api.github.com/repos/russsaidwords/tldr/subscription","commits_url":"https://api.github.com/repos/russsaidwords/tldr/commits{/sha}","git_commits_url":"https://api.github.com/repos/russsaidwords/tldr/git/commits{/sha}","comments_url":"https://api.github.com/repos/russsaidwords/tldr/comments{/number}","issue_comment_url":"https://api.github.com/repos/russsaidwords/tldr/issues/comments{/number}","contents_url":"https://api.github.com/repos/russsaidwords/tldr/contents/{+path}","compare_url":"https://api.github.com/repos/russsaidwords/tldr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/russsaidwords/tldr/merges","archive_url":"https://api.github.com/repos/russsaidwords/tldr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/russsaidwords/tldr/downloads","issues_url":"https://api.github.com/repos/russsaidwords/tldr/issues{/number}","pulls_url":"https://api.github.com/repos/russsaidwords/tldr/pulls{/number}","milestones_url":"https://api.github.com/repos/russsaidwords/tldr/milestones{/number}","notifications_url":"https://api.github.com/repos/russsaidwords/tldr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/russsaidwords/tldr/labels{/name}","releases_url":"https://api.github.com/repos/russsaidwords/tldr/releases{/id}","deployments_url":"https://api.github.com/repos/russsaidwords/tldr/deployments","created_at":"2018-09-27T02:13:06Z","updated_at":"2018-10-12T14:18:19Z","pushed_at":"2018-10-13T02:27:13Z","git_url":"git://github.com/russsaidwords/tldr.git","ssh_url":"[email protected]:russsaidwords/tldr.git","clone_url":"https://github.com/russsaidwords/tldr.git","svn_url":"https://github.com/russsaidwords/tldr","homepage":"http://tldr-pages.github.io/","size":3547,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"tldr-pages:master","ref":"master","sha":"01146452dd5da5f1190b314e33bab626a166db76","user":{"login":"tldr-pages","id":7366472,"node_id":"MDEyOk9yZ2FuaXphdGlvbjczNjY0NzI=","avatar_url":"https://avatars1.githubusercontent.com/u/7366472?v=4","gravatar_id":"","url":"https://api.github.com/users/tldr-pages","html_url":"https://github.com/tldr-pages","followers_url":"https://api.github.com/users/tldr-pages/followers","following_url":"https://api.github.com/users/tldr-pages/following{/other_user}","gists_url":"https://api.github.com/users/tldr-pages/gists{/gist_id}","starred_url":"https://api.github.com/users/tldr-pages/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tldr-pages/subscriptions","organizations_url":"https://api.github.com/users/tldr-pages/orgs","repos_url":"https://api.github.com/users/tldr-pages/repos","events_url":"https://api.github.com/users/tldr-pages/events{/privacy}","received_events_url":"https://api.github.com/users/tldr-pages/received_events","type":"Organization","site_admin":false},"repo":{"id":15019962,"node_id":"MDEwOlJlcG9zaXRvcnkxNTAxOTk2Mg==","name":"tldr","full_name":"tldr-pages/tldr","private":false,"owner":{"login":"tldr-pages","id":7366472,"node_id":"MDEyOk9yZ2FuaXphdGlvbjczNjY0NzI=","avatar_url":"https://avatars1.githubusercontent.com/u/7366472?v=4","gravatar_id":"","url":"https://api.github.com/users/tldr-pages","html_url":"https://github.com/tldr-pages","followers_url":"https://api.github.com/users/tldr-pages/followers","following_url":"https://api.github.com/users/tldr-pages/following{/other_user}","gists_url":"https://api.github.com/users/tldr-pages/gists{/gist_id}","starred_url":"https://api.github.com/users/tldr-pages/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tldr-pages/subscriptions","organizations_url":"https://api.github.com/users/tldr-pages/orgs","repos_url":"https://api.github.com/users/tldr-pages/repos","events_url":"https://api.github.com/users/tldr-pages/events{/privacy}","received_events_url":"https://api.github.com/users/tldr-pages/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/tldr-pages/tldr","description":":books: Simplified and community-driven man pages","fork":false,"url":"https://api.github.com/repos/tldr-pages/tldr","forks_url":"https://api.github.com/repos/tldr-pages/tldr/forks","keys_url":"https://api.github.com/repos/tldr-pages/tldr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tldr-pages/tldr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tldr-pages/tldr/teams","hooks_url":"https://api.github.com/repos/tldr-pages/tldr/hooks","issue_events_url":"https://api.github.com/repos/tldr-pages/tldr/issues/events{/number}","events_url":"https://api.github.com/repos/tldr-pages/tldr/events","assignees_url":"https://api.github.com/repos/tldr-pages/tldr/assignees{/user}","branches_url":"https://api.github.com/repos/tldr-pages/tldr/branches{/branch}","tags_url":"https://api.github.com/repos/tldr-pages/tldr/tags","blobs_url":"https://api.github.com/repos/tldr-pages/tldr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tldr-pages/tldr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tldr-pages/tldr/git/refs{/sha}","trees_url":"https://api.github.com/repos/tldr-pages/tldr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tldr-pages/tldr/statuses/{sha}","languages_url":"https://api.github.com/repos/tldr-pages/tldr/languages","stargazers_url":"https://api.github.com/repos/tldr-pages/tldr/stargazers","contributors_url":"https://api.github.com/repos/tldr-pages/tldr/contributors","subscribers_url":"https://api.github.com/repos/tldr-pages/tldr/subscribers","subscription_url":"https://api.github.com/repos/tldr-pages/tldr/subscription","commits_url":"https://api.github.com/repos/tldr-pages/tldr/commits{/sha}","git_commits_url":"https://api.github.com/repos/tldr-pages/tldr/git/commits{/sha}","comments_url":"https://api.github.com/repos/tldr-pages/tldr/comments{/number}","issue_comment_url":"https://api.github.com/repos/tldr-pages/tldr/issues/comments{/number}","contents_url":"https://api.github.com/repos/tldr-pages/tldr/contents/{+path}","compare_url":"https://api.github.com/repos/tldr-pages/tldr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tldr-pages/tldr/merges","archive_url":"https://api.github.com/repos/tldr-pages/tldr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tldr-pages/tldr/downloads","issues_url":"https://api.github.com/repos/tldr-pages/tldr/issues{/number}","pulls_url":"https://api.github.com/repos/tldr-pages/tldr/pulls{/number}","milestones_url":"https://api.github.com/repos/tldr-pages/tldr/milestones{/number}","notifications_url":"https://api.github.com/repos/tldr-pages/tldr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tldr-pages/tldr/labels{/name}","releases_url":"https://api.github.com/repos/tldr-pages/tldr/releases{/id}","deployments_url":"https://api.github.com/repos/tldr-pages/tldr/deployments","created_at":"2013-12-08T07:34:43Z","updated_at":"2018-10-13T20:59:56Z","pushed_at":"2018-10-13T23:04:19Z","git_url":"git://github.com/tldr-pages/tldr.git","ssh_url":"[email protected]:tldr-pages/tldr.git","clone_url":"https://github.com/tldr-pages/tldr.git","svn_url":"https://github.com/tldr-pages/tldr","homepage":"http://tldr-pages.github.io/","size":3583,"stargazers_count":18845,"watchers_count":18845,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1397,"mirror_url":null,"archived":false,"open_issues_count":88,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1397,"open_issues":88,"watchers":18845,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tldr-pages/tldr/pulls/2434"},"html":{"href":"https://github.com/tldr-pages/tldr/pull/2434"},"issue":{"href":"https://api.github.com/repos/tldr-pages/tldr/issues/2434"},"comments":{"href":"https://api.github.com/repos/tldr-pages/tldr/issues/2434/comments"},"review_comments":{"href":"https://api.github.com/repos/tldr-pages/tldr/pulls/2434/comments"},"review_comment":{"href":"https://api.github.com/repos/tldr-pages/tldr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tldr-pages/tldr/pulls/2434/commits"},"statuses":{"href":"https://api.github.com/repos/tldr-pages/tldr/statuses/32c8e7fe793cf07728f6c5d44e9e85987a204522"}},"author_association":"CONTRIBUTOR"}} | {
"id": 15019962,
"name": "tldr-pages/tldr",
"url": "https://api.github.com/repos/tldr-pages/tldr"
} | {
"id": 1774000,
"login": "agnivade",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1774000?",
"url": "https://api.github.com/users/agnivade"
} | {
"id": 7366472,
"login": "tldr-pages",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7366472?",
"url": "https://api.github.com/orgs/tldr-pages"
} | 2018-10-14T04:41:53 | 8416605608 | {"actor":{"display_login":"agnivade"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/pulls/comments/206653576","pull_request_review_id":142087610,"id":206653576,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNjY1MzU3Ng==","diff_hunk":"@@ -1,7 +1,5 @@\n documentation_complete: true\n \n-prodtype: rhel6,rhel7,fedora","path":"linux_os/guide/system/logging/log_rotation/ensure_logrotate_activated.rule","position":3,"original_position":3,"commit_id":"ecfe3d05fcda0fbd14c663482fa1bdf85c5859eb","original_commit_id":"ecfe3d05fcda0fbd14c663482fa1bdf85c5859eb","user":{"login":"cipherboy","id":914030,"node_id":"MDQ6VXNlcjkxNDAzMA==","avatar_url":"https://avatars2.githubusercontent.com/u/914030?v=4","gravatar_id":"","url":"https://api.github.com/users/cipherboy","html_url":"https://github.com/cipherboy","followers_url":"https://api.github.com/users/cipherboy/followers","following_url":"https://api.github.com/users/cipherboy/following{/other_user}","gists_url":"https://api.github.com/users/cipherboy/gists{/gist_id}","starred_url":"https://api.github.com/users/cipherboy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cipherboy/subscriptions","organizations_url":"https://api.github.com/users/cipherboy/orgs","repos_url":"https://api.github.com/users/cipherboy/repos","events_url":"https://api.github.com/users/cipherboy/events{/privacy}","received_events_url":"https://api.github.com/users/cipherboy/received_events","type":"User","site_admin":false},"body":"Apparently it runs in OpenSUSE and people have lots of questions about it: https://forums.opensuse.org/showthread.php/505897-On-a-fresh-installation-is-logrotate-running-by-default","created_at":"2018-07-31T19:24:45Z","updated_at":"2018-07-31T19:27:07Z","html_url":"https://github.com/OpenSCAP/scap-security-guide/pull/3156#discussion_r206653576","pull_request_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/pulls/3156","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/OpenSCAP/scap-security-guide/pulls/comments/206653576"},"html":{"href":"https://github.com/OpenSCAP/scap-security-guide/pull/3156#discussion_r206653576"},"pull_request":{"href":"https://api.github.com/repos/OpenSCAP/scap-security-guide/pulls/3156"}}},"pull_request":{"url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/pulls/3156","id":203569274,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzNTY5Mjc0","html_url":"https://github.com/OpenSCAP/scap-security-guide/pull/3156","diff_url":"https://github.com/OpenSCAP/scap-security-guide/pull/3156.diff","patch_url":"https://github.com/OpenSCAP/scap-security-guide/pull/3156.patch","issue_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/issues/3156","number":3156,"state":"open","locked":false,"title":"Simplify prodtype again","user":{"login":"cipherboy","id":914030,"node_id":"MDQ6VXNlcjkxNDAzMA==","avatar_url":"https://avatars2.githubusercontent.com/u/914030?v=4","gravatar_id":"","url":"https://api.github.com/users/cipherboy","html_url":"https://github.com/cipherboy","followers_url":"https://api.github.com/users/cipherboy/followers","following_url":"https://api.github.com/users/cipherboy/following{/other_user}","gists_url":"https://api.github.com/users/cipherboy/gists{/gist_id}","starred_url":"https://api.github.com/users/cipherboy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cipherboy/subscriptions","organizations_url":"https://api.github.com/users/cipherboy/orgs","repos_url":"https://api.github.com/users/cipherboy/repos","events_url":"https://api.github.com/users/cipherboy/events{/privacy}","received_events_url":"https://api.github.com/users/cipherboy/received_events","type":"User","site_admin":false},"body":"Simplify the `prodtype`s again!\r\n\r\nCreate a utility to track `prodtype` usage vs. actual value and update the rules/vars accordingly. Like #3161, I'd prefer to review the utility later as part of #3014.","created_at":"2018-07-24T15:34:56Z","updated_at":"2018-07-31T19:27:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b00a78c2662c2df1a990c25044f1b4215c93aab7","assignee":{"login":"yuumasato","id":7460169,"node_id":"MDQ6VXNlcjc0NjAxNjk=","avatar_url":"https://avatars0.githubusercontent.com/u/7460169?v=4","gravatar_id":"","url":"https://api.github.com/users/yuumasato","html_url":"https://github.com/yuumasato","followers_url":"https://api.github.com/users/yuumasato/followers","following_url":"https://api.github.com/users/yuumasato/following{/other_user}","gists_url":"https://api.github.com/users/yuumasato/gists{/gist_id}","starred_url":"https://api.github.com/users/yuumasato/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuumasato/subscriptions","organizations_url":"https://api.github.com/users/yuumasato/orgs","repos_url":"https://api.github.com/users/yuumasato/repos","events_url":"https://api.github.com/users/yuumasato/events{/privacy}","received_events_url":"https://api.github.com/users/yuumasato/received_events","type":"User","site_admin":false},"assignees":[{"login":"yuumasato","id":7460169,"node_id":"MDQ6VXNlcjc0NjAxNjk=","avatar_url":"https://avatars0.githubusercontent.com/u/7460169?v=4","gravatar_id":"","url":"https://api.github.com/users/yuumasato","html_url":"https://github.com/yuumasato","followers_url":"https://api.github.com/users/yuumasato/followers","following_url":"https://api.github.com/users/yuumasato/following{/other_user}","gists_url":"https://api.github.com/users/yuumasato/gists{/gist_id}","starred_url":"https://api.github.com/users/yuumasato/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuumasato/subscriptions","organizations_url":"https://api.github.com/users/yuumasato/orgs","repos_url":"https://api.github.com/users/yuumasato/repos","events_url":"https://api.github.com/users/yuumasato/events{/privacy}","received_events_url":"https://api.github.com/users/yuumasato/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":126561448,"node_id":"MDU6TGFiZWwxMjY1NjE0NDg=","url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/labels/BLOCKER","name":"BLOCKER","color":"e11d21","default":false},{"id":913378788,"node_id":"MDU6TGFiZWw5MTMzNzg3ODg=","url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/labels/refactoring","name":"refactoring","color":"82e5a6","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/pulls/3156/commits","review_comments_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/pulls/3156/comments","review_comment_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/issues/3156/comments","statuses_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/statuses/ecfe3d05fcda0fbd14c663482fa1bdf85c5859eb","head":{"label":"cipherboy:prodtype-simplify-again","ref":"prodtype-simplify-again","sha":"ecfe3d05fcda0fbd14c663482fa1bdf85c5859eb","user":{"login":"cipherboy","id":914030,"node_id":"MDQ6VXNlcjkxNDAzMA==","avatar_url":"https://avatars2.githubusercontent.com/u/914030?v=4","gravatar_id":"","url":"https://api.github.com/users/cipherboy","html_url":"https://github.com/cipherboy","followers_url":"https://api.github.com/users/cipherboy/followers","following_url":"https://api.github.com/users/cipherboy/following{/other_user}","gists_url":"https://api.github.com/users/cipherboy/gists{/gist_id}","starred_url":"https://api.github.com/users/cipherboy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cipherboy/subscriptions","organizations_url":"https://api.github.com/users/cipherboy/orgs","repos_url":"https://api.github.com/users/cipherboy/repos","events_url":"https://api.github.com/users/cipherboy/events{/privacy}","received_events_url":"https://api.github.com/users/cipherboy/received_events","type":"User","site_admin":false},"repo":{"id":136047739,"node_id":"MDEwOlJlcG9zaXRvcnkxMzYwNDc3Mzk=","name":"scap-security-guide","full_name":"cipherboy/scap-security-guide","owner":{"login":"cipherboy","id":914030,"node_id":"MDQ6VXNlcjkxNDAzMA==","avatar_url":"https://avatars2.githubusercontent.com/u/914030?v=4","gravatar_id":"","url":"https://api.github.com/users/cipherboy","html_url":"https://github.com/cipherboy","followers_url":"https://api.github.com/users/cipherboy/followers","following_url":"https://api.github.com/users/cipherboy/following{/other_user}","gists_url":"https://api.github.com/users/cipherboy/gists{/gist_id}","starred_url":"https://api.github.com/users/cipherboy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cipherboy/subscriptions","organizations_url":"https://api.github.com/users/cipherboy/orgs","repos_url":"https://api.github.com/users/cipherboy/repos","events_url":"https://api.github.com/users/cipherboy/events{/privacy}","received_events_url":"https://api.github.com/users/cipherboy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cipherboy/scap-security-guide","description":"Baseline compliance content in SCAP formats","fork":true,"url":"https://api.github.com/repos/cipherboy/scap-security-guide","forks_url":"https://api.github.com/repos/cipherboy/scap-security-guide/forks","keys_url":"https://api.github.com/repos/cipherboy/scap-security-guide/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cipherboy/scap-security-guide/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cipherboy/scap-security-guide/teams","hooks_url":"https://api.github.com/repos/cipherboy/scap-security-guide/hooks","issue_events_url":"https://api.github.com/repos/cipherboy/scap-security-guide/issues/events{/number}","events_url":"https://api.github.com/repos/cipherboy/scap-security-guide/events","assignees_url":"https://api.github.com/repos/cipherboy/scap-security-guide/assignees{/user}","branches_url":"https://api.github.com/repos/cipherboy/scap-security-guide/branches{/branch}","tags_url":"https://api.github.com/repos/cipherboy/scap-security-guide/tags","blobs_url":"https://api.github.com/repos/cipherboy/scap-security-guide/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cipherboy/scap-security-guide/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cipherboy/scap-security-guide/git/refs{/sha}","trees_url":"https://api.github.com/repos/cipherboy/scap-security-guide/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cipherboy/scap-security-guide/statuses/{sha}","languages_url":"https://api.github.com/repos/cipherboy/scap-security-guide/languages","stargazers_url":"https://api.github.com/repos/cipherboy/scap-security-guide/stargazers","contributors_url":"https://api.github.com/repos/cipherboy/scap-security-guide/contributors","subscribers_url":"https://api.github.com/repos/cipherboy/scap-security-guide/subscribers","subscription_url":"https://api.github.com/repos/cipherboy/scap-security-guide/subscription","commits_url":"https://api.github.com/repos/cipherboy/scap-security-guide/commits{/sha}","git_commits_url":"https://api.github.com/repos/cipherboy/scap-security-guide/git/commits{/sha}","comments_url":"https://api.github.com/repos/cipherboy/scap-security-guide/comments{/number}","issue_comment_url":"https://api.github.com/repos/cipherboy/scap-security-guide/issues/comments{/number}","contents_url":"https://api.github.com/repos/cipherboy/scap-security-guide/contents/{+path}","compare_url":"https://api.github.com/repos/cipherboy/scap-security-guide/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cipherboy/scap-security-guide/merges","archive_url":"https://api.github.com/repos/cipherboy/scap-security-guide/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cipherboy/scap-security-guide/downloads","issues_url":"https://api.github.com/repos/cipherboy/scap-security-guide/issues{/number}","pulls_url":"https://api.github.com/repos/cipherboy/scap-security-guide/pulls{/number}","milestones_url":"https://api.github.com/repos/cipherboy/scap-security-guide/milestones{/number}","notifications_url":"https://api.github.com/repos/cipherboy/scap-security-guide/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cipherboy/scap-security-guide/labels{/name}","releases_url":"https://api.github.com/repos/cipherboy/scap-security-guide/releases{/id}","deployments_url":"https://api.github.com/repos/cipherboy/scap-security-guide/deployments","created_at":"2018-06-04T15:44:48Z","updated_at":"2018-07-31T17:42:13Z","pushed_at":"2018-07-31T19:12:01Z","git_url":"git://github.com/cipherboy/scap-security-guide.git","ssh_url":"[email protected]:cipherboy/scap-security-guide.git","clone_url":"https://github.com/cipherboy/scap-security-guide.git","svn_url":"https://github.com/cipherboy/scap-security-guide","homepage":"https://www.open-scap.org/security-policies/scap-security-guide","size":24885,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"OpenSCAP:master","ref":"master","sha":"ec3889e652d048bfbfb12608ae7d832e8f88da8a","user":{"login":"OpenSCAP","id":7439934,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc0Mzk5MzQ=","avatar_url":"https://avatars1.githubusercontent.com/u/7439934?v=4","gravatar_id":"","url":"https://api.github.com/users/OpenSCAP","html_url":"https://github.com/OpenSCAP","followers_url":"https://api.github.com/users/OpenSCAP/followers","following_url":"https://api.github.com/users/OpenSCAP/following{/other_user}","gists_url":"https://api.github.com/users/OpenSCAP/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenSCAP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenSCAP/subscriptions","organizations_url":"https://api.github.com/users/OpenSCAP/orgs","repos_url":"https://api.github.com/users/OpenSCAP/repos","events_url":"https://api.github.com/users/OpenSCAP/events{/privacy}","received_events_url":"https://api.github.com/users/OpenSCAP/received_events","type":"Organization","site_admin":false},"repo":{"id":19279458,"node_id":"MDEwOlJlcG9zaXRvcnkxOTI3OTQ1OA==","name":"scap-security-guide","full_name":"OpenSCAP/scap-security-guide","owner":{"login":"OpenSCAP","id":7439934,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc0Mzk5MzQ=","avatar_url":"https://avatars1.githubusercontent.com/u/7439934?v=4","gravatar_id":"","url":"https://api.github.com/users/OpenSCAP","html_url":"https://github.com/OpenSCAP","followers_url":"https://api.github.com/users/OpenSCAP/followers","following_url":"https://api.github.com/users/OpenSCAP/following{/other_user}","gists_url":"https://api.github.com/users/OpenSCAP/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenSCAP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenSCAP/subscriptions","organizations_url":"https://api.github.com/users/OpenSCAP/orgs","repos_url":"https://api.github.com/users/OpenSCAP/repos","events_url":"https://api.github.com/users/OpenSCAP/events{/privacy}","received_events_url":"https://api.github.com/users/OpenSCAP/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OpenSCAP/scap-security-guide","description":"Baseline compliance content in SCAP formats","fork":false,"url":"https://api.github.com/repos/OpenSCAP/scap-security-guide","forks_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/forks","keys_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/teams","hooks_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/hooks","issue_events_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/issues/events{/number}","events_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/events","assignees_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/assignees{/user}","branches_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/branches{/branch}","tags_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/tags","blobs_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/git/refs{/sha}","trees_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/statuses/{sha}","languages_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/languages","stargazers_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/stargazers","contributors_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/contributors","subscribers_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/subscribers","subscription_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/subscription","commits_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/commits{/sha}","git_commits_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/git/commits{/sha}","comments_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/comments{/number}","issue_comment_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/issues/comments{/number}","contents_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/contents/{+path}","compare_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/merges","archive_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/downloads","issues_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/issues{/number}","pulls_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/pulls{/number}","milestones_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/milestones{/number}","notifications_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/labels{/name}","releases_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/releases{/id}","deployments_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/deployments","created_at":"2014-04-29T14:32:02Z","updated_at":"2018-07-31T17:17:40Z","pushed_at":"2018-07-31T19:12:03Z","git_url":"git://github.com/OpenSCAP/scap-security-guide.git","ssh_url":"[email protected]:OpenSCAP/scap-security-guide.git","clone_url":"https://github.com/OpenSCAP/scap-security-guide.git","svn_url":"https://github.com/OpenSCAP/scap-security-guide","homepage":"https://www.open-scap.org/security-policies/scap-security-guide","size":24138,"stargazers_count":439,"watchers_count":439,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":233,"mirror_url":null,"archived":false,"open_issues_count":155,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":233,"open_issues":155,"watchers":439,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OpenSCAP/scap-security-guide/pulls/3156"},"html":{"href":"https://github.com/OpenSCAP/scap-security-guide/pull/3156"},"issue":{"href":"https://api.github.com/repos/OpenSCAP/scap-security-guide/issues/3156"},"comments":{"href":"https://api.github.com/repos/OpenSCAP/scap-security-guide/issues/3156/comments"},"review_comments":{"href":"https://api.github.com/repos/OpenSCAP/scap-security-guide/pulls/3156/comments"},"review_comment":{"href":"https://api.github.com/repos/OpenSCAP/scap-security-guide/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OpenSCAP/scap-security-guide/pulls/3156/commits"},"statuses":{"href":"https://api.github.com/repos/OpenSCAP/scap-security-guide/statuses/ecfe3d05fcda0fbd14c663482fa1bdf85c5859eb"}},"author_association":"CONTRIBUTOR"}} | {
"id": 19279458,
"name": "OpenSCAP/scap-security-guide",
"url": "https://api.github.com/repos/OpenSCAP/scap-security-guide"
} | {
"id": 914030,
"login": "cipherboy",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/914030?",
"url": "https://api.github.com/users/cipherboy"
} | {
"id": 7439934,
"login": "OpenSCAP",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7439934?",
"url": "https://api.github.com/orgs/OpenSCAP"
} | 2018-07-31T19:24:45 | 8046182321 | {"actor":{"display_login":"cipherboy"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/OP-TEE/optee_os/pulls/comments/183995049","pull_request_review_id":115094658,"id":183995049,"diff_hunk":"@@ -0,0 +1,266 @@\n+/* SPDX-License-Identifier: BSD-2-Clause */\n+/*\n+ * Copyright (C) 2015 Freescale Semiconductor, Inc.\n+ * Copyright (c) 2016, Wind River Systems.\n+ * All rights reserved.\n+ * Copyright 2017-2018 NXP\n+ *\n+ * Redistribution and use in source and binary forms, with or without\n+ * modification, are permitted provided that the following conditions are met:\n+ *\n+ * 1. Redistributions of source code must retain the above copyright notice,\n+ * this list of conditions and the following disclaimer.\n+ *\n+ * 2. Redistributions in binary form must reproduce the above copyright notice,\n+ * this list of conditions and the following disclaimer in the documentation\n+ * and/or other materials provided with the distribution.\n+ *\n+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS \"AS IS\"\n+ * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE\n+ * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE\n+ * ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE\n+ * LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR\n+ * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF\n+ * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS\n+ * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN\n+ * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)\n+ * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE\n+ * POSSIBILITY OF SUCH DAMAGE.\n+ */\n+\n+#ifndef PLATFORM_CONFIG_IMX6Q_H\n+#define PLATFORM_CONFIG_IMX6Q_H\n+\n+/* Board specific console UART */\n+#if defined(PLATFORM_FLAVOR_mx6qsabrelite)\n+#define CONSOLE_UART_BASE\t\tUART2_BASE\n+#endif\n+#if defined(PLATFORM_FLAVOR_mx6qpsabreauto) || \\\n+\tdefined(PLATFORM_FLAVOR_mx6qsabreauto) || \\\n+\tdefined(PLATFORM_FLAVOR_mx6dlsabreauto)\n+#define CONSOLE_UART_BASE\t\tUART4_BASE\n+#endif\n+#ifndef CONSOLE_UART_BASE\n+#define CONSOLE_UART_BASE\t\tUART1_BASE\n+#endif\n+\n+/* Board specific RAM size */\n+#if defined(PLATFORM_FLAVOR_mx6qsabrelite) || \\\n+\tdefined(PLATFORM_FLAVOR_mx6qsabresd) || \\\n+\tdefined(PLATFORM_FLAVOR_mx6qsabrelite) || \\\n+\tdefined(PLATFORM_FLAVOR_mx6dlsabresd) || \\\n+\tdefined(PLATFORM_FLAVOR_mx6qpsabresd)\n+#define DRAM0_SIZE\t\t\t0x40000000\n+#endif\n+\n+#if defined(PLATFORM_FLAVOR_mx6qpsabreauto) || \\\n+\tdefined(PLATFORM_FLAVOR_mx6qsabreauto) || \\\n+\tdefined(PLATFORM_FLAVOR_mx6dlsabreauto)\n+#define DRAM0_SIZE\t\t\t0x80000000\n+#endif\n+\n+/* Core number depends of SoC version. */\n+#if defined(CFG_MX6QP) || defined(CFG_MX6Q)\n+#define CFG_TEE_CORE_NB_CORE\t\t4\n+#endif\n+#if defined(CFG_MX6D) || defined(CFG_MX6DL)\n+#define CFG_TEE_CORE_NB_CORE\t\t2\n+#endif\n+#if defined(CFG_MX6S)\n+#define CFG_TEE_CORE_NB_CORE\t\t1\n+#endif\n+\n+/* Common RAM and cache controller configuration */\n+#define CFG_TEE_RAM_VA_SIZE\t\t(1024 * 1024)\n+\n+#define DDR_PHYS_START\t\t\tDRAM0_BASE\n+#define DDR_SIZE\t\t\tDRAM0_SIZE\n+\n+#ifndef CFG_DDR_SIZE\n+#define CFG_DDR_SIZE\t\t\tDDR_SIZE\n+#endif\n+\n+/*\n+ * PL310 TAG RAM Control Register\n+ *\n+ * bit[10:8]:1 - 2 cycle of write accesses latency\n+ * bit[6:4]:1 - 2 cycle of read accesses latency\n+ * bit[2:0]:1 - 2 cycle of setup latency\n+ */\n+#ifndef PL310_TAG_RAM_CTRL_INIT\n+#define PL310_TAG_RAM_CTRL_INIT\t\t0x00000111\n+#endif\n+\n+/*\n+ * PL310 DATA RAM Control Register\n+ *\n+ * bit[10:8]:2 - 3 cycle of write accesses latency\n+ * bit[6:4]:2 - 3 cycle of read accesses latency\n+ * bit[2:0]:2 - 3 cycle of setup latency\n+ */\n+#ifndef PL310_DATA_RAM_CTRL_INIT\n+#define PL310_DATA_RAM_CTRL_INIT\t0x00000222\n+#endif\n+\n+/*\n+ * PL310 Auxiliary Control Register\n+ *\n+ * I/Dcache prefetch enabled (bit29:28=2b11)\n+ * NS can access interrupts (bit27=1)\n+ * NS can lockown cache lines (bit26=1)\n+ * Pseudo-random replacement policy (bit25=0)\n+ * Force write allocated (default)\n+ * Shared attribute internally ignored (bit22=1, bit13=0)\n+ * Parity disabled (bit21=0)\n+ * Event monitor disabled (bit20=0)\n+ * Platform flavor specific way config (dual / quad):\n+ * - 64kb way size (bit19:17=3b011)\n+ * - 16-way associativity (bit16=1)\n+ * Platform flavor specific way config (dual lite / solo):\n+ * - 32kb way size (bit19:17=3b010)\n+ * - no 16-way associativity (bit16=0)\n+ * Store buffer device limitation enabled (bit11=1)\n+ * Cacheable accesses have high prio (bit10=0)\n+ * Full Line Zero (FLZ) disabled (bit0=0)\n+ */\n+#ifndef PL310_AUX_CTRL_INIT\n+#if defined(CFG_MX6QP) || defined(CFG_MX6Q) || defined(CFG_MX6D)\n+#define PL310_AUX_CTRL_INIT\t\t0x3C470800\n+#else\n+#define PL310_AUX_CTRL_INIT\t\t0x3C440800\n+#endif\n+#endif\n+\n+/*\n+ * PL310 Prefetch Control Register\n+ *\n+ * Double linefill disabled (bit30=0)\n+ * I/D prefetch enabled (bit29:28=2b11)\n+ * Prefetch drop enabled (bit24=1)\n+ * Incr double linefill disable (bit23=0)\n+ * Prefetch offset = 7 (bit4:0)\n+ */\n+#define PL310_PREFETCH_CTRL_INIT\t0x31000007\n+\n+/*\n+ * PL310 Power Register\n+ *\n+ * Dynamic clock gating enabled\n+ * Standby mode enabled\n+ */\n+#define PL310_POWER_CTRL_INIT\t\t0x00000003\n+\n+/*\n+ * SCU Invalidate Register\n+ *\n+ * Invalidate all registers\n+ */\n+#define SCU_INV_CTRL_INIT\t\t0xFFFFFFFF\n+\n+/*\n+ * SCU Access Register\n+ * - both secure CPU access SCU\n+ */\n+#define SCU_SAC_CTRL_INIT\t\t0x0000000F\n+\n+/*\n+ * SCU NonSecure Access Register\n+ * - both nonsec cpu access SCU, private and global timer\n+ */\n+#define SCU_NSAC_CTRL_INIT\t\t0x00000FFF\n+\n+/* define the memory areas */\n+\n+#ifdef CFG_WITH_PAGER\n+\n+/*\n+ * TEE/TZ RAM layout:\n+ *\n+ * +---------------------------------------+ <- CFG_CORE_TZSRAM_EMUL_START\n+ * | TEE private highly | TEE_RAM | ^\n+ * | secure memory | | | CFG_CORE_TZSRAM_EMUL_SIZE\n+ * +---------------------------------------+ v\n+ *\n+ * +---------------------------------------+ <- CFG_DDR_TEETZ_RESERVED_START\n+ * | TEE private secure | TA_RAM | ^\n+ * | external memory | | |\n+ * +---------------------------------------+ | CFG_DDR_TEETZ_RESERVED_SIZE\n+ * | Non secure | SHM | |\n+ * | shared memory | | |\n+ * +---------------------------------------+ v\n+ *\n+ * TEE_RAM : default 256kByte\n+ * TA_RAM : all what is left in DDR TEE reserved area\n+ * PUB_RAM : default 2MByte\n+ */\n+\n+/* emulated SRAM, at start of secure DDR */\n+\n+#define CFG_CORE_TZSRAM_EMUL_START\t0x4E000000\n+\n+#define TZSRAM_BASE\t\t\tCFG_CORE_TZSRAM_EMUL_START\n+#define TZSRAM_SIZE\t\t\tCFG_CORE_TZSRAM_EMUL_SIZE\n+\n+/* Location of trusted dram */\n+\n+#define CFG_DDR_TEETZ_RESERVED_START\t0x4E100000\n+#define CFG_DDR_TEETZ_RESERVED_SIZE\t0x01F00000\n+\n+#define CFG_PUB_RAM_SIZE\t\t(2 * 1024 * 1024)","path":"core/arch/arm/plat-imx/config/imx6q.h","position":209,"original_position":209,"commit_id":"9251a3e6ba75d644cdd79223943c463419a51265","original_commit_id":"9251a3e6ba75d644cdd79223943c463419a51265","user":{"login":"etienne-lms","id":19990310,"avatar_url":"https://avatars3.githubusercontent.com/u/19990310?v=4","gravatar_id":"","url":"https://api.github.com/users/etienne-lms","html_url":"https://github.com/etienne-lms","followers_url":"https://api.github.com/users/etienne-lms/followers","following_url":"https://api.github.com/users/etienne-lms/following{/other_user}","gists_url":"https://api.github.com/users/etienne-lms/gists{/gist_id}","starred_url":"https://api.github.com/users/etienne-lms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/etienne-lms/subscriptions","organizations_url":"https://api.github.com/users/etienne-lms/orgs","repos_url":"https://api.github.com/users/etienne-lms/repos","events_url":"https://api.github.com/users/etienne-lms/events{/privacy}","received_events_url":"https://api.github.com/users/etienne-lms/received_events","type":"User","site_admin":false},"body":"original static shm was 1MB.","created_at":"2018-04-25T09:30:16Z","updated_at":"2018-04-25T09:46:12Z","html_url":"https://github.com/OP-TEE/optee_os/pull/2217#discussion_r183995049","pull_request_url":"https://api.github.com/repos/OP-TEE/optee_os/pulls/2217","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/OP-TEE/optee_os/pulls/comments/183995049"},"html":{"href":"https://github.com/OP-TEE/optee_os/pull/2217#discussion_r183995049"},"pull_request":{"href":"https://api.github.com/repos/OP-TEE/optee_os/pulls/2217"}}},"pull_request":{"url":"https://api.github.com/repos/OP-TEE/optee_os/pulls/2217","id":177726035,"html_url":"https://github.com/OP-TEE/optee_os/pull/2217","diff_url":"https://github.com/OP-TEE/optee_os/pull/2217.diff","patch_url":"https://github.com/OP-TEE/optee_os/pull/2217.patch","issue_url":"https://api.github.com/repos/OP-TEE/optee_os/issues/2217","number":2217,"state":"open","locked":false,"title":"Upstream i.MX SoC support (part1)","user":{"login":"sdininno","id":23036407,"avatar_url":"https://avatars3.githubusercontent.com/u/23036407?v=4","gravatar_id":"","url":"https://api.github.com/users/sdininno","html_url":"https://github.com/sdininno","followers_url":"https://api.github.com/users/sdininno/followers","following_url":"https://api.github.com/users/sdininno/following{/other_user}","gists_url":"https://api.github.com/users/sdininno/gists{/gist_id}","starred_url":"https://api.github.com/users/sdininno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdininno/subscriptions","organizations_url":"https://api.github.com/users/sdininno/orgs","repos_url":"https://api.github.com/users/sdininno/repos","events_url":"https://api.github.com/users/sdininno/events{/privacy}","received_events_url":"https://api.github.com/users/sdininno/received_events","type":"User","site_admin":false},"body":"This is the first part of the pull request #2216\r\n\r\nThis is a cleanup and reorganising the header file. It does not change the number of SoC or the feature supported.\r\n<!--\r\n If you are new to submitting pull requests to OP-TEE, then please have a\r\n look at the list below and tick them off before submitting the pull request.\r\n\r\n 1. Read our contribution guidelines:\r\n documentation/github.md.\r\n\r\n 2. Read the contribution section in Notice.md and pay extra attention to the\r\n \"Developer Certificate of Origin\" part:\r\n https://github.com/OP-TEE/optee_os/blob/master/Notice.md#contributions.\r\n\r\n 3. You should run checkpatch preferably before submitting the pull request.\r\n\r\n 4. When everything has been reviewed, you will need to squash, rebase and\r\n add tags like `Reviewed-by`, `Acked-by`, `Tested-by` etc.\r\n\r\n NOTE: This comment will not be shown in the pull request, so no harm keeping\r\n it, but feel free to remove it if you like.\r\n-->\r\n","created_at":"2018-03-27T12:37:20Z","updated_at":"2018-04-25T09:46:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4ba75936844ccfae21372235d3bc710945ff6461","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/OP-TEE/optee_os/pulls/2217/commits","review_comments_url":"https://api.github.com/repos/OP-TEE/optee_os/pulls/2217/comments","review_comment_url":"https://api.github.com/repos/OP-TEE/optee_os/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OP-TEE/optee_os/issues/2217/comments","statuses_url":"https://api.github.com/repos/OP-TEE/optee_os/statuses/9251a3e6ba75d644cdd79223943c463419a51265","head":{"label":"sdininno:feature/upstream/part1","ref":"feature/upstream/part1","sha":"9251a3e6ba75d644cdd79223943c463419a51265","user":{"login":"sdininno","id":23036407,"avatar_url":"https://avatars3.githubusercontent.com/u/23036407?v=4","gravatar_id":"","url":"https://api.github.com/users/sdininno","html_url":"https://github.com/sdininno","followers_url":"https://api.github.com/users/sdininno/followers","following_url":"https://api.github.com/users/sdininno/following{/other_user}","gists_url":"https://api.github.com/users/sdininno/gists{/gist_id}","starred_url":"https://api.github.com/users/sdininno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdininno/subscriptions","organizations_url":"https://api.github.com/users/sdininno/orgs","repos_url":"https://api.github.com/users/sdininno/repos","events_url":"https://api.github.com/users/sdininno/events{/privacy}","received_events_url":"https://api.github.com/users/sdininno/received_events","type":"User","site_admin":false},"repo":{"id":126526749,"name":"optee_os","full_name":"sdininno/optee_os","owner":{"login":"sdininno","id":23036407,"avatar_url":"https://avatars3.githubusercontent.com/u/23036407?v=4","gravatar_id":"","url":"https://api.github.com/users/sdininno","html_url":"https://github.com/sdininno","followers_url":"https://api.github.com/users/sdininno/followers","following_url":"https://api.github.com/users/sdininno/following{/other_user}","gists_url":"https://api.github.com/users/sdininno/gists{/gist_id}","starred_url":"https://api.github.com/users/sdininno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdininno/subscriptions","organizations_url":"https://api.github.com/users/sdininno/orgs","repos_url":"https://api.github.com/users/sdininno/repos","events_url":"https://api.github.com/users/sdininno/events{/privacy}","received_events_url":"https://api.github.com/users/sdininno/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sdininno/optee_os","description":"Trusted side of the TEE","fork":true,"url":"https://api.github.com/repos/sdininno/optee_os","forks_url":"https://api.github.com/repos/sdininno/optee_os/forks","keys_url":"https://api.github.com/repos/sdininno/optee_os/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sdininno/optee_os/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sdininno/optee_os/teams","hooks_url":"https://api.github.com/repos/sdininno/optee_os/hooks","issue_events_url":"https://api.github.com/repos/sdininno/optee_os/issues/events{/number}","events_url":"https://api.github.com/repos/sdininno/optee_os/events","assignees_url":"https://api.github.com/repos/sdininno/optee_os/assignees{/user}","branches_url":"https://api.github.com/repos/sdininno/optee_os/branches{/branch}","tags_url":"https://api.github.com/repos/sdininno/optee_os/tags","blobs_url":"https://api.github.com/repos/sdininno/optee_os/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sdininno/optee_os/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sdininno/optee_os/git/refs{/sha}","trees_url":"https://api.github.com/repos/sdininno/optee_os/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sdininno/optee_os/statuses/{sha}","languages_url":"https://api.github.com/repos/sdininno/optee_os/languages","stargazers_url":"https://api.github.com/repos/sdininno/optee_os/stargazers","contributors_url":"https://api.github.com/repos/sdininno/optee_os/contributors","subscribers_url":"https://api.github.com/repos/sdininno/optee_os/subscribers","subscription_url":"https://api.github.com/repos/sdininno/optee_os/subscription","commits_url":"https://api.github.com/repos/sdininno/optee_os/commits{/sha}","git_commits_url":"https://api.github.com/repos/sdininno/optee_os/git/commits{/sha}","comments_url":"https://api.github.com/repos/sdininno/optee_os/comments{/number}","issue_comment_url":"https://api.github.com/repos/sdininno/optee_os/issues/comments{/number}","contents_url":"https://api.github.com/repos/sdininno/optee_os/contents/{+path}","compare_url":"https://api.github.com/repos/sdininno/optee_os/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sdininno/optee_os/merges","archive_url":"https://api.github.com/repos/sdininno/optee_os/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sdininno/optee_os/downloads","issues_url":"https://api.github.com/repos/sdininno/optee_os/issues{/number}","pulls_url":"https://api.github.com/repos/sdininno/optee_os/pulls{/number}","milestones_url":"https://api.github.com/repos/sdininno/optee_os/milestones{/number}","notifications_url":"https://api.github.com/repos/sdininno/optee_os/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sdininno/optee_os/labels{/name}","releases_url":"https://api.github.com/repos/sdininno/optee_os/releases{/id}","deployments_url":"https://api.github.com/repos/sdininno/optee_os/deployments","created_at":"2018-03-23T18:49:50Z","updated_at":"2018-03-23T18:49:56Z","pushed_at":"2018-04-25T09:14:36Z","git_url":"git://github.com/sdininno/optee_os.git","ssh_url":"[email protected]:sdininno/optee_os.git","clone_url":"https://github.com/sdininno/optee_os.git","svn_url":"https://github.com/sdininno/optee_os","homepage":null,"size":12931,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"OP-TEE:master","ref":"master","sha":"9a159b2fcb11df3b78b14e7f305a9b9240d04bd7","user":{"login":"OP-TEE","id":7488961,"avatar_url":"https://avatars1.githubusercontent.com/u/7488961?v=4","gravatar_id":"","url":"https://api.github.com/users/OP-TEE","html_url":"https://github.com/OP-TEE","followers_url":"https://api.github.com/users/OP-TEE/followers","following_url":"https://api.github.com/users/OP-TEE/following{/other_user}","gists_url":"https://api.github.com/users/OP-TEE/gists{/gist_id}","starred_url":"https://api.github.com/users/OP-TEE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OP-TEE/subscriptions","organizations_url":"https://api.github.com/users/OP-TEE/orgs","repos_url":"https://api.github.com/users/OP-TEE/repos","events_url":"https://api.github.com/users/OP-TEE/events{/privacy}","received_events_url":"https://api.github.com/users/OP-TEE/received_events","type":"Organization","site_admin":false},"repo":{"id":20193261,"name":"optee_os","full_name":"OP-TEE/optee_os","owner":{"login":"OP-TEE","id":7488961,"avatar_url":"https://avatars1.githubusercontent.com/u/7488961?v=4","gravatar_id":"","url":"https://api.github.com/users/OP-TEE","html_url":"https://github.com/OP-TEE","followers_url":"https://api.github.com/users/OP-TEE/followers","following_url":"https://api.github.com/users/OP-TEE/following{/other_user}","gists_url":"https://api.github.com/users/OP-TEE/gists{/gist_id}","starred_url":"https://api.github.com/users/OP-TEE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OP-TEE/subscriptions","organizations_url":"https://api.github.com/users/OP-TEE/orgs","repos_url":"https://api.github.com/users/OP-TEE/repos","events_url":"https://api.github.com/users/OP-TEE/events{/privacy}","received_events_url":"https://api.github.com/users/OP-TEE/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OP-TEE/optee_os","description":"Trusted side of the TEE","fork":false,"url":"https://api.github.com/repos/OP-TEE/optee_os","forks_url":"https://api.github.com/repos/OP-TEE/optee_os/forks","keys_url":"https://api.github.com/repos/OP-TEE/optee_os/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OP-TEE/optee_os/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OP-TEE/optee_os/teams","hooks_url":"https://api.github.com/repos/OP-TEE/optee_os/hooks","issue_events_url":"https://api.github.com/repos/OP-TEE/optee_os/issues/events{/number}","events_url":"https://api.github.com/repos/OP-TEE/optee_os/events","assignees_url":"https://api.github.com/repos/OP-TEE/optee_os/assignees{/user}","branches_url":"https://api.github.com/repos/OP-TEE/optee_os/branches{/branch}","tags_url":"https://api.github.com/repos/OP-TEE/optee_os/tags","blobs_url":"https://api.github.com/repos/OP-TEE/optee_os/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OP-TEE/optee_os/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OP-TEE/optee_os/git/refs{/sha}","trees_url":"https://api.github.com/repos/OP-TEE/optee_os/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OP-TEE/optee_os/statuses/{sha}","languages_url":"https://api.github.com/repos/OP-TEE/optee_os/languages","stargazers_url":"https://api.github.com/repos/OP-TEE/optee_os/stargazers","contributors_url":"https://api.github.com/repos/OP-TEE/optee_os/contributors","subscribers_url":"https://api.github.com/repos/OP-TEE/optee_os/subscribers","subscription_url":"https://api.github.com/repos/OP-TEE/optee_os/subscription","commits_url":"https://api.github.com/repos/OP-TEE/optee_os/commits{/sha}","git_commits_url":"https://api.github.com/repos/OP-TEE/optee_os/git/commits{/sha}","comments_url":"https://api.github.com/repos/OP-TEE/optee_os/comments{/number}","issue_comment_url":"https://api.github.com/repos/OP-TEE/optee_os/issues/comments{/number}","contents_url":"https://api.github.com/repos/OP-TEE/optee_os/contents/{+path}","compare_url":"https://api.github.com/repos/OP-TEE/optee_os/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OP-TEE/optee_os/merges","archive_url":"https://api.github.com/repos/OP-TEE/optee_os/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OP-TEE/optee_os/downloads","issues_url":"https://api.github.com/repos/OP-TEE/optee_os/issues{/number}","pulls_url":"https://api.github.com/repos/OP-TEE/optee_os/pulls{/number}","milestones_url":"https://api.github.com/repos/OP-TEE/optee_os/milestones{/number}","notifications_url":"https://api.github.com/repos/OP-TEE/optee_os/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OP-TEE/optee_os/labels{/name}","releases_url":"https://api.github.com/repos/OP-TEE/optee_os/releases{/id}","deployments_url":"https://api.github.com/repos/OP-TEE/optee_os/deployments","created_at":"2014-05-26T17:18:57Z","updated_at":"2018-04-24T14:10:11Z","pushed_at":"2018-04-25T09:36:41Z","git_url":"git://github.com/OP-TEE/optee_os.git","ssh_url":"[email protected]:OP-TEE/optee_os.git","clone_url":"https://github.com/OP-TEE/optee_os.git","svn_url":"https://github.com/OP-TEE/optee_os","homepage":null,"size":12923,"stargazers_count":381,"watchers_count":381,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":333,"mirror_url":null,"archived":false,"open_issues_count":172,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":333,"open_issues":172,"watchers":381,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OP-TEE/optee_os/pulls/2217"},"html":{"href":"https://github.com/OP-TEE/optee_os/pull/2217"},"issue":{"href":"https://api.github.com/repos/OP-TEE/optee_os/issues/2217"},"comments":{"href":"https://api.github.com/repos/OP-TEE/optee_os/issues/2217/comments"},"review_comments":{"href":"https://api.github.com/repos/OP-TEE/optee_os/pulls/2217/comments"},"review_comment":{"href":"https://api.github.com/repos/OP-TEE/optee_os/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OP-TEE/optee_os/pulls/2217/commits"},"statuses":{"href":"https://api.github.com/repos/OP-TEE/optee_os/statuses/9251a3e6ba75d644cdd79223943c463419a51265"}},"author_association":"NONE"}} | {
"id": 20193261,
"name": "OP-TEE/optee_os",
"url": "https://api.github.com/repos/OP-TEE/optee_os"
} | {
"id": 19990310,
"login": "etienne-lms",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/19990310?",
"url": "https://api.github.com/users/etienne-lms"
} | {
"id": 7488961,
"login": "OP-TEE",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7488961?",
"url": "https://api.github.com/orgs/OP-TEE"
} | 2018-04-25T09:30:16 | 7583749737 | {"actor":{"display_login":"etienne-lms"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/dealii/dealii/pulls/comments/208125385","pull_request_review_id":143870962,"id":208125385,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwODEyNTM4NQ==","diff_hunk":"@@ -636,6 +636,44 @@ namespace MatrixFreeOperators\n const VectorizedArray<Number> * in_array,\n VectorizedArray<Number> * out_array) const;\n \n+ /**\n+ * This operation performs a projection from the data given in quadrature\n+ * points to the actual basis underlying this object. This projection can\n+ * also be interpreted as a change of the basis from the Lagrange\n+ * interpolation polynomials in the quadrature points and to the\n+ * representation by the basis underlying the current `fe_eval` object.\n+ *\n+ * Calling this function on an array as\n+ * @code\n+ * inverse_mass.transform_from_q_points_to_basis(1, array,\n+ * phi.begin_dof_values());","path":"include/deal.II/matrix_free/operators.h","position":14,"original_position":14,"commit_id":"56169943a69b4615671c8b8451300f2f00cf9178","original_commit_id":"56169943a69b4615671c8b8451300f2f00cf9178","user":{"login":"masterleinad","id":2423533,"node_id":"MDQ6VXNlcjI0MjM1MzM=","avatar_url":"https://avatars0.githubusercontent.com/u/2423533?v=4","gravatar_id":"","url":"https://api.github.com/users/masterleinad","html_url":"https://github.com/masterleinad","followers_url":"https://api.github.com/users/masterleinad/followers","following_url":"https://api.github.com/users/masterleinad/following{/other_user}","gists_url":"https://api.github.com/users/masterleinad/gists{/gist_id}","starred_url":"https://api.github.com/users/masterleinad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/masterleinad/subscriptions","organizations_url":"https://api.github.com/users/masterleinad/orgs","repos_url":"https://api.github.com/users/masterleinad/repos","events_url":"https://api.github.com/users/masterleinad/events{/privacy}","received_events_url":"https://api.github.com/users/masterleinad/received_events","type":"User","site_admin":false},"body":"Can you align this parameter with the others?","created_at":"2018-08-07T07:31:13Z","updated_at":"2018-08-07T07:45:00Z","html_url":"https://github.com/dealii/dealii/pull/7034#discussion_r208125385","pull_request_url":"https://api.github.com/repos/dealii/dealii/pulls/7034","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/dealii/dealii/pulls/comments/208125385"},"html":{"href":"https://github.com/dealii/dealii/pull/7034#discussion_r208125385"},"pull_request":{"href":"https://api.github.com/repos/dealii/dealii/pulls/7034"}}},"pull_request":{"url":"https://api.github.com/repos/dealii/dealii/pulls/7034","id":206444254,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2NDQ0MjU0","html_url":"https://github.com/dealii/dealii/pull/7034","diff_url":"https://github.com/dealii/dealii/pull/7034.diff","patch_url":"https://github.com/dealii/dealii/pull/7034.patch","issue_url":"https://api.github.com/repos/dealii/dealii/issues/7034","number":7034,"state":"open","locked":false,"title":"Add transformation function between bases in matrix-free","user":{"login":"kronbichler","id":8276200,"node_id":"MDQ6VXNlcjgyNzYyMDA=","avatar_url":"https://avatars0.githubusercontent.com/u/8276200?v=4","gravatar_id":"","url":"https://api.github.com/users/kronbichler","html_url":"https://github.com/kronbichler","followers_url":"https://api.github.com/users/kronbichler/followers","following_url":"https://api.github.com/users/kronbichler/following{/other_user}","gists_url":"https://api.github.com/users/kronbichler/gists{/gist_id}","starred_url":"https://api.github.com/users/kronbichler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kronbichler/subscriptions","organizations_url":"https://api.github.com/users/kronbichler/orgs","repos_url":"https://api.github.com/users/kronbichler/repos","events_url":"https://api.github.com/users/kronbichler/events{/privacy}","received_events_url":"https://api.github.com/users/kronbichler/received_events","type":"User","site_admin":false},"body":"The new function provides a fast implementation of the projection from values in quadrature points to the values in the basis for the special case that the number of quadrature points is the same as the number of basis functions.\r\n\r\nThis projection operation can be interpreted as a change of basis (from the Lagrange polynomials defined in the quadrature points to the actual basis). This operation is sometimes useful in DG methods where a fast change between a representation in quadrature points and in the basis is necessary, e.g. in so-called arbitrary-derivative methods as described in https://doi.org/10.1007/s10915-018-0649-2","created_at":"2018-08-06T15:57:11Z","updated_at":"2018-08-07T07:45:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c7a35c8a89e0578a31627e27c3b2f8ab82b12300","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":506087764,"node_id":"MDU6TGFiZWw1MDYwODc3NjQ=","url":"https://api.github.com/repos/dealii/dealii/labels/Matrix-free","name":"Matrix-free","color":"006b75","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/dealii/dealii/pulls/7034/commits","review_comments_url":"https://api.github.com/repos/dealii/dealii/pulls/7034/comments","review_comment_url":"https://api.github.com/repos/dealii/dealii/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dealii/dealii/issues/7034/comments","statuses_url":"https://api.github.com/repos/dealii/dealii/statuses/56169943a69b4615671c8b8451300f2f00cf9178","head":{"label":"kronbichler:mf_transform_q_points_to_basis","ref":"mf_transform_q_points_to_basis","sha":"56169943a69b4615671c8b8451300f2f00cf9178","user":{"login":"kronbichler","id":8276200,"node_id":"MDQ6VXNlcjgyNzYyMDA=","avatar_url":"https://avatars0.githubusercontent.com/u/8276200?v=4","gravatar_id":"","url":"https://api.github.com/users/kronbichler","html_url":"https://github.com/kronbichler","followers_url":"https://api.github.com/users/kronbichler/followers","following_url":"https://api.github.com/users/kronbichler/following{/other_user}","gists_url":"https://api.github.com/users/kronbichler/gists{/gist_id}","starred_url":"https://api.github.com/users/kronbichler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kronbichler/subscriptions","organizations_url":"https://api.github.com/users/kronbichler/orgs","repos_url":"https://api.github.com/users/kronbichler/repos","events_url":"https://api.github.com/users/kronbichler/events{/privacy}","received_events_url":"https://api.github.com/users/kronbichler/received_events","type":"User","site_admin":false},"repo":{"id":22549298,"node_id":"MDEwOlJlcG9zaXRvcnkyMjU0OTI5OA==","name":"dealii","full_name":"kronbichler/dealii","owner":{"login":"kronbichler","id":8276200,"node_id":"MDQ6VXNlcjgyNzYyMDA=","avatar_url":"https://avatars0.githubusercontent.com/u/8276200?v=4","gravatar_id":"","url":"https://api.github.com/users/kronbichler","html_url":"https://github.com/kronbichler","followers_url":"https://api.github.com/users/kronbichler/followers","following_url":"https://api.github.com/users/kronbichler/following{/other_user}","gists_url":"https://api.github.com/users/kronbichler/gists{/gist_id}","starred_url":"https://api.github.com/users/kronbichler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kronbichler/subscriptions","organizations_url":"https://api.github.com/users/kronbichler/orgs","repos_url":"https://api.github.com/users/kronbichler/repos","events_url":"https://api.github.com/users/kronbichler/events{/privacy}","received_events_url":"https://api.github.com/users/kronbichler/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kronbichler/dealii","description":"The development repository for the deal.II finite element library.","fork":true,"url":"https://api.github.com/repos/kronbichler/dealii","forks_url":"https://api.github.com/repos/kronbichler/dealii/forks","keys_url":"https://api.github.com/repos/kronbichler/dealii/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kronbichler/dealii/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kronbichler/dealii/teams","hooks_url":"https://api.github.com/repos/kronbichler/dealii/hooks","issue_events_url":"https://api.github.com/repos/kronbichler/dealii/issues/events{/number}","events_url":"https://api.github.com/repos/kronbichler/dealii/events","assignees_url":"https://api.github.com/repos/kronbichler/dealii/assignees{/user}","branches_url":"https://api.github.com/repos/kronbichler/dealii/branches{/branch}","tags_url":"https://api.github.com/repos/kronbichler/dealii/tags","blobs_url":"https://api.github.com/repos/kronbichler/dealii/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kronbichler/dealii/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kronbichler/dealii/git/refs{/sha}","trees_url":"https://api.github.com/repos/kronbichler/dealii/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kronbichler/dealii/statuses/{sha}","languages_url":"https://api.github.com/repos/kronbichler/dealii/languages","stargazers_url":"https://api.github.com/repos/kronbichler/dealii/stargazers","contributors_url":"https://api.github.com/repos/kronbichler/dealii/contributors","subscribers_url":"https://api.github.com/repos/kronbichler/dealii/subscribers","subscription_url":"https://api.github.com/repos/kronbichler/dealii/subscription","commits_url":"https://api.github.com/repos/kronbichler/dealii/commits{/sha}","git_commits_url":"https://api.github.com/repos/kronbichler/dealii/git/commits{/sha}","comments_url":"https://api.github.com/repos/kronbichler/dealii/comments{/number}","issue_comment_url":"https://api.github.com/repos/kronbichler/dealii/issues/comments{/number}","contents_url":"https://api.github.com/repos/kronbichler/dealii/contents/{+path}","compare_url":"https://api.github.com/repos/kronbichler/dealii/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kronbichler/dealii/merges","archive_url":"https://api.github.com/repos/kronbichler/dealii/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kronbichler/dealii/downloads","issues_url":"https://api.github.com/repos/kronbichler/dealii/issues{/number}","pulls_url":"https://api.github.com/repos/kronbichler/dealii/pulls{/number}","milestones_url":"https://api.github.com/repos/kronbichler/dealii/milestones{/number}","notifications_url":"https://api.github.com/repos/kronbichler/dealii/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kronbichler/dealii/labels{/name}","releases_url":"https://api.github.com/repos/kronbichler/dealii/releases{/id}","deployments_url":"https://api.github.com/repos/kronbichler/dealii/deployments","created_at":"2014-08-02T15:52:43Z","updated_at":"2016-01-11T13:12:43Z","pushed_at":"2018-08-07T07:19:36Z","git_url":"git://github.com/kronbichler/dealii.git","ssh_url":"[email protected]:kronbichler/dealii.git","clone_url":"https://github.com/kronbichler/dealii.git","svn_url":"https://github.com/kronbichler/dealii","homepage":"http://www.dealii.org/","size":199235,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dealii:master","ref":"master","sha":"bce353f0bcc60747fe8a8b93a44c94d8cf87da6e","user":{"login":"dealii","id":7506070,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc1MDYwNzA=","avatar_url":"https://avatars3.githubusercontent.com/u/7506070?v=4","gravatar_id":"","url":"https://api.github.com/users/dealii","html_url":"https://github.com/dealii","followers_url":"https://api.github.com/users/dealii/followers","following_url":"https://api.github.com/users/dealii/following{/other_user}","gists_url":"https://api.github.com/users/dealii/gists{/gist_id}","starred_url":"https://api.github.com/users/dealii/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dealii/subscriptions","organizations_url":"https://api.github.com/users/dealii/orgs","repos_url":"https://api.github.com/users/dealii/repos","events_url":"https://api.github.com/users/dealii/events{/privacy}","received_events_url":"https://api.github.com/users/dealii/received_events","type":"Organization","site_admin":false},"repo":{"id":21943980,"node_id":"MDEwOlJlcG9zaXRvcnkyMTk0Mzk4MA==","name":"dealii","full_name":"dealii/dealii","owner":{"login":"dealii","id":7506070,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc1MDYwNzA=","avatar_url":"https://avatars3.githubusercontent.com/u/7506070?v=4","gravatar_id":"","url":"https://api.github.com/users/dealii","html_url":"https://github.com/dealii","followers_url":"https://api.github.com/users/dealii/followers","following_url":"https://api.github.com/users/dealii/following{/other_user}","gists_url":"https://api.github.com/users/dealii/gists{/gist_id}","starred_url":"https://api.github.com/users/dealii/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dealii/subscriptions","organizations_url":"https://api.github.com/users/dealii/orgs","repos_url":"https://api.github.com/users/dealii/repos","events_url":"https://api.github.com/users/dealii/events{/privacy}","received_events_url":"https://api.github.com/users/dealii/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dealii/dealii","description":"The development repository for the deal.II finite element library.","fork":false,"url":"https://api.github.com/repos/dealii/dealii","forks_url":"https://api.github.com/repos/dealii/dealii/forks","keys_url":"https://api.github.com/repos/dealii/dealii/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dealii/dealii/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dealii/dealii/teams","hooks_url":"https://api.github.com/repos/dealii/dealii/hooks","issue_events_url":"https://api.github.com/repos/dealii/dealii/issues/events{/number}","events_url":"https://api.github.com/repos/dealii/dealii/events","assignees_url":"https://api.github.com/repos/dealii/dealii/assignees{/user}","branches_url":"https://api.github.com/repos/dealii/dealii/branches{/branch}","tags_url":"https://api.github.com/repos/dealii/dealii/tags","blobs_url":"https://api.github.com/repos/dealii/dealii/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dealii/dealii/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dealii/dealii/git/refs{/sha}","trees_url":"https://api.github.com/repos/dealii/dealii/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dealii/dealii/statuses/{sha}","languages_url":"https://api.github.com/repos/dealii/dealii/languages","stargazers_url":"https://api.github.com/repos/dealii/dealii/stargazers","contributors_url":"https://api.github.com/repos/dealii/dealii/contributors","subscribers_url":"https://api.github.com/repos/dealii/dealii/subscribers","subscription_url":"https://api.github.com/repos/dealii/dealii/subscription","commits_url":"https://api.github.com/repos/dealii/dealii/commits{/sha}","git_commits_url":"https://api.github.com/repos/dealii/dealii/git/commits{/sha}","comments_url":"https://api.github.com/repos/dealii/dealii/comments{/number}","issue_comment_url":"https://api.github.com/repos/dealii/dealii/issues/comments{/number}","contents_url":"https://api.github.com/repos/dealii/dealii/contents/{+path}","compare_url":"https://api.github.com/repos/dealii/dealii/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dealii/dealii/merges","archive_url":"https://api.github.com/repos/dealii/dealii/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dealii/dealii/downloads","issues_url":"https://api.github.com/repos/dealii/dealii/issues{/number}","pulls_url":"https://api.github.com/repos/dealii/dealii/pulls{/number}","milestones_url":"https://api.github.com/repos/dealii/dealii/milestones{/number}","notifications_url":"https://api.github.com/repos/dealii/dealii/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dealii/dealii/labels{/name}","releases_url":"https://api.github.com/repos/dealii/dealii/releases{/id}","deployments_url":"https://api.github.com/repos/dealii/dealii/deployments","created_at":"2014-07-17T14:00:26Z","updated_at":"2018-08-06T19:30:30Z","pushed_at":"2018-08-07T07:20:50Z","git_url":"git://github.com/dealii/dealii.git","ssh_url":"[email protected]:dealii/dealii.git","clone_url":"https://github.com/dealii/dealii.git","svn_url":"https://github.com/dealii/dealii","homepage":"http://www.dealii.org/","size":199487,"stargazers_count":363,"watchers_count":363,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":313,"mirror_url":null,"archived":false,"open_issues_count":293,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":313,"open_issues":293,"watchers":363,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dealii/dealii/pulls/7034"},"html":{"href":"https://github.com/dealii/dealii/pull/7034"},"issue":{"href":"https://api.github.com/repos/dealii/dealii/issues/7034"},"comments":{"href":"https://api.github.com/repos/dealii/dealii/issues/7034/comments"},"review_comments":{"href":"https://api.github.com/repos/dealii/dealii/pulls/7034/comments"},"review_comment":{"href":"https://api.github.com/repos/dealii/dealii/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dealii/dealii/pulls/7034/commits"},"statuses":{"href":"https://api.github.com/repos/dealii/dealii/statuses/56169943a69b4615671c8b8451300f2f00cf9178"}},"author_association":"MEMBER"}} | {
"id": 21943980,
"name": "dealii/dealii",
"url": "https://api.github.com/repos/dealii/dealii"
} | {
"id": 2423533,
"login": "masterleinad",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2423533?",
"url": "https://api.github.com/users/masterleinad"
} | {
"id": 7506070,
"login": "dealii",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7506070?",
"url": "https://api.github.com/orgs/dealii"
} | 2018-08-07T07:31:13 | 8075906858 | {"actor":{"display_login":"masterleinad"}} |
Subsets and Splits