type
stringclasses 14
values | public
bool 1
class | payload
stringlengths 2
363k
| repo
dict | actor
dict | org
dict | created_at
timestamp[us] | id
stringlengths 10
10
| other
stringlengths 31
69
|
|---|---|---|---|---|---|---|---|---|
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/cloudposse/docs/pulls/comments/241898404","pull_request_review_id":185294435,"id":241898404,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MTg5ODQwNA==","diff_hunk":"@@ -0,0 +1,90 @@\n+---\n+title: \"Strategy for Infrastructure Integration Testing\"\n+date: \"2018-12-14\" \n+description: \"We need a consistent way to test and validate that our infrastructure automation (kops, helm, terraform modules, etc) are working correctly.\"\n+weight: 2\n+---\n+\n+## Status\n+\n+**Proposed**\n+\n+## Context\n+\n+We maintain 250+ active projects on GitHub. These projects receive a lot of contributions from community members. \n+\n+We need a way to test `terraform` modules, `kops` clusters, `helm` charts, `helmfile` deployments, and more generally the functionality of our `geodesic` containers.\n+Our situation is a bit unique in that we need to test the integration of dozens of tools that span languages, authors, and organizations. \n+We do not have the privilege of just testing one language or framework.\n+\n+To date, we have not done much in the form of automated testing. When we receive contributions from members, someone on our team needs to manually checkout the changes to validate them. This is time consuming and we do not have the engineering resources to scale with the growth in popularity of our Open Source projects.\n+\n+We have seen approaches to automated testing of terraform.\n+\n+### Test Kitchen\n+\n+[Test Kitchen](https://github.com/newcontext-oss/kitchen-terraform) is the original testing framework for terraform written in ruby. \n+It presents a familiar testing interface for terraform, for anyone with a software development background. The lightweight DSL presents an \n+easy way to define tests plus with the full support of the ruby language, a `gem` for everything under the sun. Ruby is a fanastic language\n+for writing DSLs and aptly suited for the purpose of writing tests.\n+\n+For non-ruby developers, ruby is a bit of a mystery. Most developers require something like `rbenv` or `rvm` to run Ruby due to issues with version compatibilities. If a company depends on Ruby, this is not a big deal, but for companies that do not use it make it a daunting task. Gems install gems install gems and before you know it, you have installed the actual \"kitchen sink\". This is to say, ruby apps are anything but lightweight and installing gems across platforms is a hit-or-miss business, especially when they require [`ffi`](https://github.com/ffi/ffi) to compile dependencies (which also means you need developer tools installed). Ruby is also a polarizing language, much the same way of \n+Python, Go or Java.\n+\n+\n+### Terratest\n+\n+[Terratest](https://github.com/gruntwork-io/terratest) is a project by Gruntworks that they use internally for building and running automated tests against terraform modules. \n+\n+The project has received immense interest and is engineering-wise a beautiful solution to the problem. By writing the integration tests in Go and compiling them down to a single, cross-architecture/platform binary, the end-user is able to run tests without needing to install the [\"kitchen sink\"](https://en.wikipedia.org/wiki/Scope_creep) to testing tools.\n+\n+The problem with this approach is it sets the bar very high for users of `terraform`, many of which do not come from a strict software development background.\n+The persons who will most of the time run the tests are not the end users of the modules, but the developers of them. Getting started with Go requires a bit of commitment to get it setup and installed. In the end, we feel that this will exclude a large part of our community, which is contrary to our inclusive ethos. \n+\n+For an example, let us consider the wildly popular blogging platform of Wordpress.Much of its success was derived from the fact that it made it very easy\n+for anyone to get started without needing to be a rocketscientist. We should embrace some of those same elements. \n+\n+This is also a terraform-centric approach. It does not address our need to test kops, helm, helmfile, etc. We would prefer not to need to develop (5) new\n+techniques for each tool because that will increase the burden on our contributors to master testing frameworks.\n+\n+### Bats\n+\n+Bats stands for the \"Bash Automated Testing System\". It has been around for many years. While the original maintainers have abandoned the project, there is an active community effort and [official fork](https://github.com/bats-core/bats-core) that is committed to maintaining it (as of 2017-09). \n+\n+Bats presents a familiar testing DSL for running adhoc commands using the `bash` shell. This is really nice since it is a general way to test commands \n+and outcomes in a largely language/framework agnostic manner. That is, it is not opinionated in the same way as more language-specific testing frameworks. \n+Since the tests are just commands wrapped with a simple DSL plus some syntatic sugar, it is easy for anyone who has ever written a shell script to pick it up\n+in a matter of minutes.\n+\n+The downside with `bats` is that it is written in `bash`, which is not a *modern* programming language. The underlying code that powers `bats` is complicated\n+for the uniniated shell programmers. Also, since it is interpreted (not compiled), lots of files/libraries get installed on the system much like a python or ruby app. The tests we write will most likely run commands like `curl` or `jq`, so there are more *native dependencies* that need to be installed. \n+\n+Using the `bats` strategy will probably necessistate running tests in a container to avoid needing to install too many native dependecies. \n+\n+We noticed that [HashiCorp](https://www.hashicorp.com/) is using `bats-core` for the automated testing of their [`consul-helm`](https://github.com/hashicorp/consul-helm) chart. This is a good example of the verstatility of `bats` for testing.\n+\n+\n+### Makefile\n+\n+We could of course use a simple (or not so simple) `Makefile` to run our tests. By default `make` will abort on the first non-zero exit codes recieved by any of the commands. \n+\n+The problem with using a general purpose tool like `make` is that it is overloading the purpose of the tool: task running. We would need to develop\n+our own testing framework and methodology on top of it, which is not our core competency or business differentiator. \n+\n+Also, `make` is not a well understood language by developers because a `Makefile` is basically templated shell scrits, so the execution flow is awkward. ","path":"content/design-decisions/0002-infrastructure-integration-testing.md","position":74,"original_position":74,"commit_id":"5be701e1c9e550e0b643a371690e013a25952eda","original_commit_id":"5be701e1c9e550e0b643a371690e013a25952eda","user":{"login":"aknysh","id":7356997,"node_id":"MDQ6VXNlcjczNTY5OTc=","avatar_url":"https://avatars0.githubusercontent.com/u/7356997?v=4","gravatar_id":"","url":"https://api.github.com/users/aknysh","html_url":"https://github.com/aknysh","followers_url":"https://api.github.com/users/aknysh/followers","following_url":"https://api.github.com/users/aknysh/following{/other_user}","gists_url":"https://api.github.com/users/aknysh/gists{/gist_id}","starred_url":"https://api.github.com/users/aknysh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aknysh/subscriptions","organizations_url":"https://api.github.com/users/aknysh/orgs","repos_url":"https://api.github.com/users/aknysh/repos","events_url":"https://api.github.com/users/aknysh/events{/privacy}","received_events_url":"https://api.github.com/users/aknysh/received_events","type":"User","site_admin":false},"body":"```suggestion\r\nAlso, `make` is not a well understood language by developers because a `Makefile` is basically templated shell scripts, so the execution flow is awkward. \r\n```","created_at":"2018-12-14T21:37:05Z","updated_at":"2018-12-14T21:37:05Z","html_url":"https://github.com/cloudposse/docs/pull/329#discussion_r241898404","pull_request_url":"https://api.github.com/repos/cloudposse/docs/pulls/329","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/cloudposse/docs/pulls/comments/241898404"},"html":{"href":"https://github.com/cloudposse/docs/pull/329#discussion_r241898404"},"pull_request":{"href":"https://api.github.com/repos/cloudposse/docs/pulls/329"}}},"pull_request":{"url":"https://api.github.com/repos/cloudposse/docs/pulls/329","id":238832813,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM4ODMyODEz","html_url":"https://github.com/cloudposse/docs/pull/329","diff_url":"https://github.com/cloudposse/docs/pull/329.diff","patch_url":"https://github.com/cloudposse/docs/pull/329.patch","issue_url":"https://api.github.com/repos/cloudposse/docs/issues/329","number":329,"state":"open","locked":false,"title":"Document infrastructure integration testing decisions","user":{"login":"osterman","id":52489,"node_id":"MDQ6VXNlcjUyNDg5","avatar_url":"https://avatars3.githubusercontent.com/u/52489?v=4","gravatar_id":"","url":"https://api.github.com/users/osterman","html_url":"https://github.com/osterman","followers_url":"https://api.github.com/users/osterman/followers","following_url":"https://api.github.com/users/osterman/following{/other_user}","gists_url":"https://api.github.com/users/osterman/gists{/gist_id}","starred_url":"https://api.github.com/users/osterman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/osterman/subscriptions","organizations_url":"https://api.github.com/users/osterman/orgs","repos_url":"https://api.github.com/users/osterman/repos","events_url":"https://api.github.com/users/osterman/events{/privacy}","received_events_url":"https://api.github.com/users/osterman/received_events","type":"User","site_admin":false},"body":"## what\r\n* Document the design decisions and considerations that have gone into selecting an automated testing framework\r\n\r\n## why\r\n* Transparency \r\n* Bats might be a controversial choice due to it's \"bash\" dependency","created_at":"2018-12-14T20:23:22Z","updated_at":"2018-12-14T21:37:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a98b1539be0b7e9c534bca487a590eae6f5d58dc","assignee":null,"assignees":[],"requested_reviewers":[{"login":"goruha","id":496956,"node_id":"MDQ6VXNlcjQ5Njk1Ng==","avatar_url":"https://avatars1.githubusercontent.com/u/496956?v=4","gravatar_id":"","url":"https://api.github.com/users/goruha","html_url":"https://github.com/goruha","followers_url":"https://api.github.com/users/goruha/followers","following_url":"https://api.github.com/users/goruha/following{/other_user}","gists_url":"https://api.github.com/users/goruha/gists{/gist_id}","starred_url":"https://api.github.com/users/goruha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/goruha/subscriptions","organizations_url":"https://api.github.com/users/goruha/orgs","repos_url":"https://api.github.com/users/goruha/repos","events_url":"https://api.github.com/users/goruha/events{/privacy}","received_events_url":"https://api.github.com/users/goruha/received_events","type":"User","site_admin":false},{"login":"joshmyers","id":3025844,"node_id":"MDQ6VXNlcjMwMjU4NDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/3025844?v=4","gravatar_id":"","url":"https://api.github.com/users/joshmyers","html_url":"https://github.com/joshmyers","followers_url":"https://api.github.com/users/joshmyers/followers","following_url":"https://api.github.com/users/joshmyers/following{/other_user}","gists_url":"https://api.github.com/users/joshmyers/gists{/gist_id}","starred_url":"https://api.github.com/users/joshmyers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshmyers/subscriptions","organizations_url":"https://api.github.com/users/joshmyers/orgs","repos_url":"https://api.github.com/users/joshmyers/repos","events_url":"https://api.github.com/users/joshmyers/events{/privacy}","received_events_url":"https://api.github.com/users/joshmyers/received_events","type":"User","site_admin":false},{"login":"solairerove","id":9396988,"node_id":"MDQ6VXNlcjkzOTY5ODg=","avatar_url":"https://avatars2.githubusercontent.com/u/9396988?v=4","gravatar_id":"","url":"https://api.github.com/users/solairerove","html_url":"https://github.com/solairerove","followers_url":"https://api.github.com/users/solairerove/followers","following_url":"https://api.github.com/users/solairerove/following{/other_user}","gists_url":"https://api.github.com/users/solairerove/gists{/gist_id}","starred_url":"https://api.github.com/users/solairerove/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/solairerove/subscriptions","organizations_url":"https://api.github.com/users/solairerove/orgs","repos_url":"https://api.github.com/users/solairerove/repos","events_url":"https://api.github.com/users/solairerove/events{/privacy}","received_events_url":"https://api.github.com/users/solairerove/received_events","type":"User","site_admin":false},{"login":"alebabai","id":19958900,"node_id":"MDQ6VXNlcjE5OTU4OTAw","avatar_url":"https://avatars1.githubusercontent.com/u/19958900?v=4","gravatar_id":"","url":"https://api.github.com/users/alebabai","html_url":"https://github.com/alebabai","followers_url":"https://api.github.com/users/alebabai/followers","following_url":"https://api.github.com/users/alebabai/following{/other_user}","gists_url":"https://api.github.com/users/alebabai/gists{/gist_id}","starred_url":"https://api.github.com/users/alebabai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alebabai/subscriptions","organizations_url":"https://api.github.com/users/alebabai/orgs","repos_url":"https://api.github.com/users/alebabai/repos","events_url":"https://api.github.com/users/alebabai/events{/privacy}","received_events_url":"https://api.github.com/users/alebabai/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/cloudposse/docs/pulls/329/commits","review_comments_url":"https://api.github.com/repos/cloudposse/docs/pulls/329/comments","review_comment_url":"https://api.github.com/repos/cloudposse/docs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cloudposse/docs/issues/329/comments","statuses_url":"https://api.github.com/repos/cloudposse/docs/statuses/5be701e1c9e550e0b643a371690e013a25952eda","head":{"label":"cloudposse:automated-testing","ref":"automated-testing","sha":"5be701e1c9e550e0b643a371690e013a25952eda","user":{"login":"cloudposse","id":16398900,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2Mzk4OTAw","avatar_url":"https://avatars2.githubusercontent.com/u/16398900?v=4","gravatar_id":"","url":"https://api.github.com/users/cloudposse","html_url":"https://github.com/cloudposse","followers_url":"https://api.github.com/users/cloudposse/followers","following_url":"https://api.github.com/users/cloudposse/following{/other_user}","gists_url":"https://api.github.com/users/cloudposse/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudposse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudposse/subscriptions","organizations_url":"https://api.github.com/users/cloudposse/orgs","repos_url":"https://api.github.com/users/cloudposse/repos","events_url":"https://api.github.com/users/cloudposse/events{/privacy}","received_events_url":"https://api.github.com/users/cloudposse/received_events","type":"Organization","site_admin":false},"repo":{"id":131331275,"node_id":"MDEwOlJlcG9zaXRvcnkxMzEzMzEyNzU=","name":"docs","full_name":"cloudposse/docs","private":false,"owner":{"login":"cloudposse","id":16398900,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2Mzk4OTAw","avatar_url":"https://avatars2.githubusercontent.com/u/16398900?v=4","gravatar_id":"","url":"https://api.github.com/users/cloudposse","html_url":"https://github.com/cloudposse","followers_url":"https://api.github.com/users/cloudposse/followers","following_url":"https://api.github.com/users/cloudposse/following{/other_user}","gists_url":"https://api.github.com/users/cloudposse/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudposse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudposse/subscriptions","organizations_url":"https://api.github.com/users/cloudposse/orgs","repos_url":"https://api.github.com/users/cloudposse/repos","events_url":"https://api.github.com/users/cloudposse/events{/privacy}","received_events_url":"https://api.github.com/users/cloudposse/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/cloudposse/docs","description":"📘 Cloud Posse Developer Hub. Complete documentation for the Cloud Posse solution. https://docs.cloudposse.com","fork":false,"url":"https://api.github.com/repos/cloudposse/docs","forks_url":"https://api.github.com/repos/cloudposse/docs/forks","keys_url":"https://api.github.com/repos/cloudposse/docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cloudposse/docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cloudposse/docs/teams","hooks_url":"https://api.github.com/repos/cloudposse/docs/hooks","issue_events_url":"https://api.github.com/repos/cloudposse/docs/issues/events{/number}","events_url":"https://api.github.com/repos/cloudposse/docs/events","assignees_url":"https://api.github.com/repos/cloudposse/docs/assignees{/user}","branches_url":"https://api.github.com/repos/cloudposse/docs/branches{/branch}","tags_url":"https://api.github.com/repos/cloudposse/docs/tags","blobs_url":"https://api.github.com/repos/cloudposse/docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cloudposse/docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cloudposse/docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/cloudposse/docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cloudposse/docs/statuses/{sha}","languages_url":"https://api.github.com/repos/cloudposse/docs/languages","stargazers_url":"https://api.github.com/repos/cloudposse/docs/stargazers","contributors_url":"https://api.github.com/repos/cloudposse/docs/contributors","subscribers_url":"https://api.github.com/repos/cloudposse/docs/subscribers","subscription_url":"https://api.github.com/repos/cloudposse/docs/subscription","commits_url":"https://api.github.com/repos/cloudposse/docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/cloudposse/docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/cloudposse/docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/cloudposse/docs/issues/comments{/number}","contents_url":"https://api.github.com/repos/cloudposse/docs/contents/{+path}","compare_url":"https://api.github.com/repos/cloudposse/docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cloudposse/docs/merges","archive_url":"https://api.github.com/repos/cloudposse/docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cloudposse/docs/downloads","issues_url":"https://api.github.com/repos/cloudposse/docs/issues{/number}","pulls_url":"https://api.github.com/repos/cloudposse/docs/pulls{/number}","milestones_url":"https://api.github.com/repos/cloudposse/docs/milestones{/number}","notifications_url":"https://api.github.com/repos/cloudposse/docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cloudposse/docs/labels{/name}","releases_url":"https://api.github.com/repos/cloudposse/docs/releases{/id}","deployments_url":"https://api.github.com/repos/cloudposse/docs/deployments","created_at":"2018-04-27T18:23:32Z","updated_at":"2018-12-14T04:26:05Z","pushed_at":"2018-12-14T20:40:37Z","git_url":"git://github.com/cloudposse/docs.git","ssh_url":"[email protected]:cloudposse/docs.git","clone_url":"https://github.com/cloudposse/docs.git","svn_url":"https://github.com/cloudposse/docs","homepage":"https://docs.cloudposse.com/","size":25153,"stargazers_count":10,"watchers_count":10,"language":"CSS","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":116,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":5,"open_issues":116,"watchers":10,"default_branch":"master"}},"base":{"label":"cloudposse:master","ref":"master","sha":"a09dc385a1b85abca18655d785b7525552cd0f3a","user":{"login":"cloudposse","id":16398900,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2Mzk4OTAw","avatar_url":"https://avatars2.githubusercontent.com/u/16398900?v=4","gravatar_id":"","url":"https://api.github.com/users/cloudposse","html_url":"https://github.com/cloudposse","followers_url":"https://api.github.com/users/cloudposse/followers","following_url":"https://api.github.com/users/cloudposse/following{/other_user}","gists_url":"https://api.github.com/users/cloudposse/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudposse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudposse/subscriptions","organizations_url":"https://api.github.com/users/cloudposse/orgs","repos_url":"https://api.github.com/users/cloudposse/repos","events_url":"https://api.github.com/users/cloudposse/events{/privacy}","received_events_url":"https://api.github.com/users/cloudposse/received_events","type":"Organization","site_admin":false},"repo":{"id":131331275,"node_id":"MDEwOlJlcG9zaXRvcnkxMzEzMzEyNzU=","name":"docs","full_name":"cloudposse/docs","private":false,"owner":{"login":"cloudposse","id":16398900,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2Mzk4OTAw","avatar_url":"https://avatars2.githubusercontent.com/u/16398900?v=4","gravatar_id":"","url":"https://api.github.com/users/cloudposse","html_url":"https://github.com/cloudposse","followers_url":"https://api.github.com/users/cloudposse/followers","following_url":"https://api.github.com/users/cloudposse/following{/other_user}","gists_url":"https://api.github.com/users/cloudposse/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudposse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudposse/subscriptions","organizations_url":"https://api.github.com/users/cloudposse/orgs","repos_url":"https://api.github.com/users/cloudposse/repos","events_url":"https://api.github.com/users/cloudposse/events{/privacy}","received_events_url":"https://api.github.com/users/cloudposse/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/cloudposse/docs","description":"📘 Cloud Posse Developer Hub. Complete documentation for the Cloud Posse solution. https://docs.cloudposse.com","fork":false,"url":"https://api.github.com/repos/cloudposse/docs","forks_url":"https://api.github.com/repos/cloudposse/docs/forks","keys_url":"https://api.github.com/repos/cloudposse/docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cloudposse/docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cloudposse/docs/teams","hooks_url":"https://api.github.com/repos/cloudposse/docs/hooks","issue_events_url":"https://api.github.com/repos/cloudposse/docs/issues/events{/number}","events_url":"https://api.github.com/repos/cloudposse/docs/events","assignees_url":"https://api.github.com/repos/cloudposse/docs/assignees{/user}","branches_url":"https://api.github.com/repos/cloudposse/docs/branches{/branch}","tags_url":"https://api.github.com/repos/cloudposse/docs/tags","blobs_url":"https://api.github.com/repos/cloudposse/docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cloudposse/docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cloudposse/docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/cloudposse/docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cloudposse/docs/statuses/{sha}","languages_url":"https://api.github.com/repos/cloudposse/docs/languages","stargazers_url":"https://api.github.com/repos/cloudposse/docs/stargazers","contributors_url":"https://api.github.com/repos/cloudposse/docs/contributors","subscribers_url":"https://api.github.com/repos/cloudposse/docs/subscribers","subscription_url":"https://api.github.com/repos/cloudposse/docs/subscription","commits_url":"https://api.github.com/repos/cloudposse/docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/cloudposse/docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/cloudposse/docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/cloudposse/docs/issues/comments{/number}","contents_url":"https://api.github.com/repos/cloudposse/docs/contents/{+path}","compare_url":"https://api.github.com/repos/cloudposse/docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cloudposse/docs/merges","archive_url":"https://api.github.com/repos/cloudposse/docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cloudposse/docs/downloads","issues_url":"https://api.github.com/repos/cloudposse/docs/issues{/number}","pulls_url":"https://api.github.com/repos/cloudposse/docs/pulls{/number}","milestones_url":"https://api.github.com/repos/cloudposse/docs/milestones{/number}","notifications_url":"https://api.github.com/repos/cloudposse/docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cloudposse/docs/labels{/name}","releases_url":"https://api.github.com/repos/cloudposse/docs/releases{/id}","deployments_url":"https://api.github.com/repos/cloudposse/docs/deployments","created_at":"2018-04-27T18:23:32Z","updated_at":"2018-12-14T04:26:05Z","pushed_at":"2018-12-14T20:40:37Z","git_url":"git://github.com/cloudposse/docs.git","ssh_url":"[email protected]:cloudposse/docs.git","clone_url":"https://github.com/cloudposse/docs.git","svn_url":"https://github.com/cloudposse/docs","homepage":"https://docs.cloudposse.com/","size":25153,"stargazers_count":10,"watchers_count":10,"language":"CSS","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":116,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":5,"open_issues":116,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cloudposse/docs/pulls/329"},"html":{"href":"https://github.com/cloudposse/docs/pull/329"},"issue":{"href":"https://api.github.com/repos/cloudposse/docs/issues/329"},"comments":{"href":"https://api.github.com/repos/cloudposse/docs/issues/329/comments"},"review_comments":{"href":"https://api.github.com/repos/cloudposse/docs/pulls/329/comments"},"review_comment":{"href":"https://api.github.com/repos/cloudposse/docs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cloudposse/docs/pulls/329/commits"},"statuses":{"href":"https://api.github.com/repos/cloudposse/docs/statuses/5be701e1c9e550e0b643a371690e013a25952eda"}},"author_association":"MEMBER"}} | {
"id": 131331275,
"name": "cloudposse/docs",
"url": "https://api.github.com/repos/cloudposse/docs"
} | {
"id": 7356997,
"login": "aknysh",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7356997?",
"url": "https://api.github.com/users/aknysh"
} | {
"id": 16398900,
"login": "cloudposse",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/16398900?",
"url": "https://api.github.com/orgs/cloudposse"
} | 2018-12-14T21:37:05 | 8757536415 | {"actor":{"display_login":"aknysh"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/yarpc/yarpc-go/pulls/comments/233307690","pull_request_review_id":174688302,"id":233307690,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMzMwNzY5MA==","diff_hunk":"@@ -0,0 +1,120 @@\n+// Copyright (c) 2018 Uber Technologies, Inc.\n+//\n+// Permission is hereby granted, free of charge, to any person obtaining a copy\n+// of this software and associated documentation files (the \"Software\"), to deal\n+// in the Software without restriction, including without limitation the rights\n+// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell\n+// copies of the Software, and to permit persons to whom the Software is\n+// furnished to do so, subject to the following conditions:\n+//\n+// The above copyright notice and this permission notice shall be included in\n+// all copies or substantial portions of the Software.\n+//\n+// THE SOFTWARE IS PROVIDED \"AS IS\", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR\n+// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,\n+// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE\n+// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER\n+// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,\n+// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN\n+// THE SOFTWARE.\n+\n+package yarpcmiddlewarefx\n+\n+import (\n+\t\"fmt\"\n+\n+\t\"go.uber.org/config\"\n+\t\"go.uber.org/fx\"\n+\tyarpc \"go.uber.org/yarpc/v2\"\n+)\n+\n+const outboundTransportMiddlewareConfigurationKey = \"yarpc.middleware.outbounds.transport\"\n+\n+// Module produces ordered slices of middleware according to\n+// the middleware configuration.\n+var Module = fx.Provide(\n+\tNewOutboundTransportMiddlewareConfig,\n+\tNewUnaryOutboundTransportMiddleware,\n+)\n+\n+// OutboundTransportMiddlewareConfig describes the configuration\n+// shape for an ordered list of unary outbound transport middleware.\n+type OutboundTransportMiddlewareConfig struct {\n+\tUnary []string `yaml:\"unary\"`\n+}\n+\n+// OutboundTransportMiddlewareConfigParams defines the dependencies of this module.\n+type OutboundTransportMiddlewareConfigParams struct {\n+\tfx.In\n+\n+\tProvider config.Provider\n+}\n+\n+// OutboundTransportMiddlewareConfigResult defines the values produced by this module.\n+type OutboundTransportMiddlewareConfigResult struct {\n+\tfx.Out\n+\n+\tConfig OutboundTransportMiddlewareConfig\n+}\n+\n+// NewOutboundTransportMiddlewareConfig produces an UnaryOutboundTransportMiddlewareConfig.\n+func NewOutboundTransportMiddlewareConfig(p OutboundTransportMiddlewareConfigParams) (OutboundTransportMiddlewareConfigResult, error) {\n+\tmc := OutboundTransportMiddlewareConfig{}\n+\tif err := p.Provider.Get(outboundTransportMiddlewareConfigurationKey).Populate(&mc); err != nil {\n+\t\treturn OutboundTransportMiddlewareConfigResult{}, err\n+\t}\n+\treturn OutboundTransportMiddlewareConfigResult{\n+\t\tConfig: mc,\n+\t}, nil\n+}\n+\n+// UnaryOutboundTransportMiddlewareParams defines the dependencies of this module.\n+type UnaryOutboundTransportMiddlewareParams struct {\n+\tfx.In\n+\n+\tConfig OutboundTransportMiddlewareConfig\n+\tMiddleware []yarpc.UnaryOutboundTransportMiddleware `group:\"yarpcfx\"`\n+\tMiddlewareLists [][]yarpc.UnaryOutboundTransportMiddleware `group:\"yarpcfx\"`\n+}\n+\n+// UnaryOutboundTransportMiddlewareResult defines the values produced by this module.\n+type UnaryOutboundTransportMiddlewareResult struct {\n+\tfx.Out\n+\n+\tMiddleware []yarpc.UnaryOutboundTransportMiddleware `name:\"yarpcfx\"`","path":"v2/yarpcmiddlewarefx/yarpcmiddlewarefx.go","position":84,"original_position":84,"commit_id":"adb07762b46690b47f5ca19727fd75dc84beaadb","original_commit_id":"adb07762b46690b47f5ca19727fd75dc84beaadb","user":{"login":"AlexAPB","id":3745201,"node_id":"MDQ6VXNlcjM3NDUyMDE=","avatar_url":"https://avatars2.githubusercontent.com/u/3745201?v=4","gravatar_id":"","url":"https://api.github.com/users/AlexAPB","html_url":"https://github.com/AlexAPB","followers_url":"https://api.github.com/users/AlexAPB/followers","following_url":"https://api.github.com/users/AlexAPB/following{/other_user}","gists_url":"https://api.github.com/users/AlexAPB/gists{/gist_id}","starred_url":"https://api.github.com/users/AlexAPB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlexAPB/subscriptions","organizations_url":"https://api.github.com/users/AlexAPB/orgs","repos_url":"https://api.github.com/users/AlexAPB/repos","events_url":"https://api.github.com/users/AlexAPB/events{/privacy}","received_events_url":"https://api.github.com/users/AlexAPB/received_events","type":"User","site_admin":false},"body":"nit: OrderedMiddleware\r\n\r\nAlso, can we add a `doc.go` to indicate that this slice is ordered and intended to be applied as-is?","created_at":"2018-11-14T03:59:45Z","updated_at":"2018-11-14T03:59:49Z","html_url":"https://github.com/yarpc/yarpc-go/pull/1643#discussion_r233307690","pull_request_url":"https://api.github.com/repos/yarpc/yarpc-go/pulls/1643","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/yarpc/yarpc-go/pulls/comments/233307690"},"html":{"href":"https://github.com/yarpc/yarpc-go/pull/1643#discussion_r233307690"},"pull_request":{"href":"https://api.github.com/repos/yarpc/yarpc-go/pulls/1643"}}},"pull_request":{"url":"https://api.github.com/repos/yarpc/yarpc-go/pulls/1643","id":229855193,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5ODU1MTkz","html_url":"https://github.com/yarpc/yarpc-go/pull/1643","diff_url":"https://github.com/yarpc/yarpc-go/pull/1643.diff","patch_url":"https://github.com/yarpc/yarpc-go/pull/1643.patch","issue_url":"https://api.github.com/repos/yarpc/yarpc-go/issues/1643","number":1643,"state":"open","locked":false,"title":"[v2] Fx: Integrate unary outbound transport middleware","user":{"login":"amckinney","id":5760684,"node_id":"MDQ6VXNlcjU3NjA2ODQ=","avatar_url":"https://avatars1.githubusercontent.com/u/5760684?v=4","gravatar_id":"","url":"https://api.github.com/users/amckinney","html_url":"https://github.com/amckinney","followers_url":"https://api.github.com/users/amckinney/followers","following_url":"https://api.github.com/users/amckinney/following{/other_user}","gists_url":"https://api.github.com/users/amckinney/gists{/gist_id}","starred_url":"https://api.github.com/users/amckinney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amckinney/subscriptions","organizations_url":"https://api.github.com/users/amckinney/orgs","repos_url":"https://api.github.com/users/amckinney/repos","events_url":"https://api.github.com/users/amckinney/events{/privacy}","received_events_url":"https://api.github.com/users/amckinney/received_events","type":"User","site_admin":false},"body":"This builds upon the work in the previous Fx PRs and integrates outbound middleware into the set of configurable dependencies in the transport layer. Unlike the previous Fx configurations, the middleware respects a specific ordering, so the `Provider` pattern doesn't quite fit. If we were to use a `Provider` for middleware, it would end up looking similar to a global, flat structure which conflicts with the Fx-way of doing things, i.e. providing something along the lines of\r\n```\r\ntype Middleware struct {\r\n UnaryTransport []yarpc.UnaryOutboundTransportMiddleware\r\n UnaryEncoding []yarpc.UnaryOutboundEncodingMiddleware\r\n}\r\n```\r\n\r\nInstead, we take advantage of Fx-named types to provide an ordered list of middleware. With this, users will provide into the `yarpcfx` group for each of their middleware, and each transport module, e.g. `yarpchttpfx` will consume the namd `yarpcfx` slice. If users accidentally produce a named `yarpcfx` type (as opposed to providing into the group), then we will encounter an error because a type will be produced more than once (as desired).\r\n","created_at":"2018-11-10T00:30:21Z","updated_at":"2018-11-14T03:59:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"04664c76f66e0a49f0f2384ff08e63e0748cc957","assignee":null,"assignees":[],"requested_reviewers":[{"login":"kriskowal","id":60294,"node_id":"MDQ6VXNlcjYwMjk0","avatar_url":"https://avatars1.githubusercontent.com/u/60294?v=4","gravatar_id":"","url":"https://api.github.com/users/kriskowal","html_url":"https://github.com/kriskowal","followers_url":"https://api.github.com/users/kriskowal/followers","following_url":"https://api.github.com/users/kriskowal/following{/other_user}","gists_url":"https://api.github.com/users/kriskowal/gists{/gist_id}","starred_url":"https://api.github.com/users/kriskowal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kriskowal/subscriptions","organizations_url":"https://api.github.com/users/kriskowal/orgs","repos_url":"https://api.github.com/users/kriskowal/repos","events_url":"https://api.github.com/users/kriskowal/events{/privacy}","received_events_url":"https://api.github.com/users/kriskowal/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/yarpc/yarpc-go/pulls/1643/commits","review_comments_url":"https://api.github.com/repos/yarpc/yarpc-go/pulls/1643/comments","review_comment_url":"https://api.github.com/repos/yarpc/yarpc-go/pulls/comments{/number}","comments_url":"https://api.github.com/repos/yarpc/yarpc-go/issues/1643/comments","statuses_url":"https://api.github.com/repos/yarpc/yarpc-go/statuses/adb07762b46690b47f5ca19727fd75dc84beaadb","head":{"label":"yarpc:mensch/spring/middlewarefx","ref":"mensch/spring/middlewarefx","sha":"adb07762b46690b47f5ca19727fd75dc84beaadb","user":{"login":"yarpc","id":16569504,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NTY5NTA0","avatar_url":"https://avatars2.githubusercontent.com/u/16569504?v=4","gravatar_id":"","url":"https://api.github.com/users/yarpc","html_url":"https://github.com/yarpc","followers_url":"https://api.github.com/users/yarpc/followers","following_url":"https://api.github.com/users/yarpc/following{/other_user}","gists_url":"https://api.github.com/users/yarpc/gists{/gist_id}","starred_url":"https://api.github.com/users/yarpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yarpc/subscriptions","organizations_url":"https://api.github.com/users/yarpc/orgs","repos_url":"https://api.github.com/users/yarpc/repos","events_url":"https://api.github.com/users/yarpc/events{/privacy}","received_events_url":"https://api.github.com/users/yarpc/received_events","type":"Organization","site_admin":false},"repo":{"id":50390111,"node_id":"MDEwOlJlcG9zaXRvcnk1MDM5MDExMQ==","name":"yarpc-go","full_name":"yarpc/yarpc-go","private":false,"owner":{"login":"yarpc","id":16569504,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NTY5NTA0","avatar_url":"https://avatars2.githubusercontent.com/u/16569504?v=4","gravatar_id":"","url":"https://api.github.com/users/yarpc","html_url":"https://github.com/yarpc","followers_url":"https://api.github.com/users/yarpc/followers","following_url":"https://api.github.com/users/yarpc/following{/other_user}","gists_url":"https://api.github.com/users/yarpc/gists{/gist_id}","starred_url":"https://api.github.com/users/yarpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yarpc/subscriptions","organizations_url":"https://api.github.com/users/yarpc/orgs","repos_url":"https://api.github.com/users/yarpc/repos","events_url":"https://api.github.com/users/yarpc/events{/privacy}","received_events_url":"https://api.github.com/users/yarpc/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/yarpc/yarpc-go","description":"A message passing platform for Go","fork":false,"url":"https://api.github.com/repos/yarpc/yarpc-go","forks_url":"https://api.github.com/repos/yarpc/yarpc-go/forks","keys_url":"https://api.github.com/repos/yarpc/yarpc-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yarpc/yarpc-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yarpc/yarpc-go/teams","hooks_url":"https://api.github.com/repos/yarpc/yarpc-go/hooks","issue_events_url":"https://api.github.com/repos/yarpc/yarpc-go/issues/events{/number}","events_url":"https://api.github.com/repos/yarpc/yarpc-go/events","assignees_url":"https://api.github.com/repos/yarpc/yarpc-go/assignees{/user}","branches_url":"https://api.github.com/repos/yarpc/yarpc-go/branches{/branch}","tags_url":"https://api.github.com/repos/yarpc/yarpc-go/tags","blobs_url":"https://api.github.com/repos/yarpc/yarpc-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yarpc/yarpc-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yarpc/yarpc-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/yarpc/yarpc-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yarpc/yarpc-go/statuses/{sha}","languages_url":"https://api.github.com/repos/yarpc/yarpc-go/languages","stargazers_url":"https://api.github.com/repos/yarpc/yarpc-go/stargazers","contributors_url":"https://api.github.com/repos/yarpc/yarpc-go/contributors","subscribers_url":"https://api.github.com/repos/yarpc/yarpc-go/subscribers","subscription_url":"https://api.github.com/repos/yarpc/yarpc-go/subscription","commits_url":"https://api.github.com/repos/yarpc/yarpc-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/yarpc/yarpc-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/yarpc/yarpc-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/yarpc/yarpc-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/yarpc/yarpc-go/contents/{+path}","compare_url":"https://api.github.com/repos/yarpc/yarpc-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yarpc/yarpc-go/merges","archive_url":"https://api.github.com/repos/yarpc/yarpc-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yarpc/yarpc-go/downloads","issues_url":"https://api.github.com/repos/yarpc/yarpc-go/issues{/number}","pulls_url":"https://api.github.com/repos/yarpc/yarpc-go/pulls{/number}","milestones_url":"https://api.github.com/repos/yarpc/yarpc-go/milestones{/number}","notifications_url":"https://api.github.com/repos/yarpc/yarpc-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yarpc/yarpc-go/labels{/name}","releases_url":"https://api.github.com/repos/yarpc/yarpc-go/releases{/id}","deployments_url":"https://api.github.com/repos/yarpc/yarpc-go/deployments","created_at":"2016-01-26T00:04:14Z","updated_at":"2018-11-13T19:04:07Z","pushed_at":"2018-11-14T03:45:00Z","git_url":"git://github.com/yarpc/yarpc-go.git","ssh_url":"[email protected]:yarpc/yarpc-go.git","clone_url":"https://github.com/yarpc/yarpc-go.git","svn_url":"https://github.com/yarpc/yarpc-go","homepage":"","size":12216,"stargazers_count":167,"watchers_count":167,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":38,"mirror_url":null,"archived":false,"open_issues_count":12,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":38,"open_issues":12,"watchers":167,"default_branch":"dev"}},"base":{"label":"yarpc:spring","ref":"spring","sha":"36221a85309e0cd51267af219d6fb74019f86770","user":{"login":"yarpc","id":16569504,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NTY5NTA0","avatar_url":"https://avatars2.githubusercontent.com/u/16569504?v=4","gravatar_id":"","url":"https://api.github.com/users/yarpc","html_url":"https://github.com/yarpc","followers_url":"https://api.github.com/users/yarpc/followers","following_url":"https://api.github.com/users/yarpc/following{/other_user}","gists_url":"https://api.github.com/users/yarpc/gists{/gist_id}","starred_url":"https://api.github.com/users/yarpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yarpc/subscriptions","organizations_url":"https://api.github.com/users/yarpc/orgs","repos_url":"https://api.github.com/users/yarpc/repos","events_url":"https://api.github.com/users/yarpc/events{/privacy}","received_events_url":"https://api.github.com/users/yarpc/received_events","type":"Organization","site_admin":false},"repo":{"id":50390111,"node_id":"MDEwOlJlcG9zaXRvcnk1MDM5MDExMQ==","name":"yarpc-go","full_name":"yarpc/yarpc-go","private":false,"owner":{"login":"yarpc","id":16569504,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NTY5NTA0","avatar_url":"https://avatars2.githubusercontent.com/u/16569504?v=4","gravatar_id":"","url":"https://api.github.com/users/yarpc","html_url":"https://github.com/yarpc","followers_url":"https://api.github.com/users/yarpc/followers","following_url":"https://api.github.com/users/yarpc/following{/other_user}","gists_url":"https://api.github.com/users/yarpc/gists{/gist_id}","starred_url":"https://api.github.com/users/yarpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yarpc/subscriptions","organizations_url":"https://api.github.com/users/yarpc/orgs","repos_url":"https://api.github.com/users/yarpc/repos","events_url":"https://api.github.com/users/yarpc/events{/privacy}","received_events_url":"https://api.github.com/users/yarpc/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/yarpc/yarpc-go","description":"A message passing platform for Go","fork":false,"url":"https://api.github.com/repos/yarpc/yarpc-go","forks_url":"https://api.github.com/repos/yarpc/yarpc-go/forks","keys_url":"https://api.github.com/repos/yarpc/yarpc-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yarpc/yarpc-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yarpc/yarpc-go/teams","hooks_url":"https://api.github.com/repos/yarpc/yarpc-go/hooks","issue_events_url":"https://api.github.com/repos/yarpc/yarpc-go/issues/events{/number}","events_url":"https://api.github.com/repos/yarpc/yarpc-go/events","assignees_url":"https://api.github.com/repos/yarpc/yarpc-go/assignees{/user}","branches_url":"https://api.github.com/repos/yarpc/yarpc-go/branches{/branch}","tags_url":"https://api.github.com/repos/yarpc/yarpc-go/tags","blobs_url":"https://api.github.com/repos/yarpc/yarpc-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yarpc/yarpc-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yarpc/yarpc-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/yarpc/yarpc-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yarpc/yarpc-go/statuses/{sha}","languages_url":"https://api.github.com/repos/yarpc/yarpc-go/languages","stargazers_url":"https://api.github.com/repos/yarpc/yarpc-go/stargazers","contributors_url":"https://api.github.com/repos/yarpc/yarpc-go/contributors","subscribers_url":"https://api.github.com/repos/yarpc/yarpc-go/subscribers","subscription_url":"https://api.github.com/repos/yarpc/yarpc-go/subscription","commits_url":"https://api.github.com/repos/yarpc/yarpc-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/yarpc/yarpc-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/yarpc/yarpc-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/yarpc/yarpc-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/yarpc/yarpc-go/contents/{+path}","compare_url":"https://api.github.com/repos/yarpc/yarpc-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yarpc/yarpc-go/merges","archive_url":"https://api.github.com/repos/yarpc/yarpc-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yarpc/yarpc-go/downloads","issues_url":"https://api.github.com/repos/yarpc/yarpc-go/issues{/number}","pulls_url":"https://api.github.com/repos/yarpc/yarpc-go/pulls{/number}","milestones_url":"https://api.github.com/repos/yarpc/yarpc-go/milestones{/number}","notifications_url":"https://api.github.com/repos/yarpc/yarpc-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yarpc/yarpc-go/labels{/name}","releases_url":"https://api.github.com/repos/yarpc/yarpc-go/releases{/id}","deployments_url":"https://api.github.com/repos/yarpc/yarpc-go/deployments","created_at":"2016-01-26T00:04:14Z","updated_at":"2018-11-13T19:04:07Z","pushed_at":"2018-11-14T03:45:00Z","git_url":"git://github.com/yarpc/yarpc-go.git","ssh_url":"[email protected]:yarpc/yarpc-go.git","clone_url":"https://github.com/yarpc/yarpc-go.git","svn_url":"https://github.com/yarpc/yarpc-go","homepage":"","size":12216,"stargazers_count":167,"watchers_count":167,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":38,"mirror_url":null,"archived":false,"open_issues_count":12,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":38,"open_issues":12,"watchers":167,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/yarpc/yarpc-go/pulls/1643"},"html":{"href":"https://github.com/yarpc/yarpc-go/pull/1643"},"issue":{"href":"https://api.github.com/repos/yarpc/yarpc-go/issues/1643"},"comments":{"href":"https://api.github.com/repos/yarpc/yarpc-go/issues/1643/comments"},"review_comments":{"href":"https://api.github.com/repos/yarpc/yarpc-go/pulls/1643/comments"},"review_comment":{"href":"https://api.github.com/repos/yarpc/yarpc-go/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/yarpc/yarpc-go/pulls/1643/commits"},"statuses":{"href":"https://api.github.com/repos/yarpc/yarpc-go/statuses/adb07762b46690b47f5ca19727fd75dc84beaadb"}},"author_association":"COLLABORATOR"}} | {
"id": 50390111,
"name": "yarpc/yarpc-go",
"url": "https://api.github.com/repos/yarpc/yarpc-go"
} | {
"id": 3745201,
"login": "AlexAPB",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3745201?",
"url": "https://api.github.com/users/AlexAPB"
} | {
"id": 16569504,
"login": "yarpc",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/16569504?",
"url": "https://api.github.com/orgs/yarpc"
} | 2018-11-14T03:59:45 | 8585557572 | {"actor":{"display_login":"AlexAPB"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/htmlacademy-htmlcss/509305-technomart/pulls/comments/171965399","pull_request_review_id":100915005,"id":171965399,"diff_hunk":"@@ -1,12 +1,181 @@\n <!DOCTYPE html>\n <html lang=\"ru\">\n- <head>\n- <meta charset=\"utf-8\">\n- <title>HTML Academy: Техномарт</title>\n- </head>\n- <body>\n+\t<head>\n+\t\t<meta charset=\"utf-8\">\n+\t\t<title>HTML Academy: Техномарт</title>\n+\t</head>\n+\t<body>\n \n- <p>Репозиторий создан для обучения на интенсивном онлайн‑курсе «<a href=\"https://htmlacademy.ru/intensive/htmlcss\">Профессиональный HTML и CSS, уровень 1</a>».</p>\n+\t\t<header>\n+\t\t\t<div class=\"header-top\">\n+\t\t\t\t<div>\n+\t\t\t\t\t<a class=\"button\" href=\"#\">Техномарт</a>\n+\t\t\t\t</div>\n+\t\t\t\t<form action=\"#\" method=\"get\">\n+\t\t\t\t\t<input type=\"search\" name=\"search\">\n+\t\t\t\t</form>\n+\t\t\t\t<div><a class=\"button bookmarks\" href=\"#\">Закладки:0</a></div>\n+\t\t\t\t<div><a class=\"button basket\" href=\"#\">Корзина:0</a></div>\n+\t\t\t\t<div><a class=\"button order\" href=\"#\">Оформить заказ</a></div>\n+\t\t\t</div>\n+\t\t\t<section>\n+\t\t\t\t<p>Интернет-магазин строительных материалов и инструментов для ремонта</p>\n+\t\t\t</section>\n+\t\t\t<section class=\"address\">\n+\t\t\t\t<div>\n+\t\t\t\t\t<p>+7495-555-05-55</p>","path":"index.html","position":32,"original_position":32,"commit_id":"5fe3fecd413d453368c4a112b4363c37315bc5d8","original_commit_id":"5fe3fecd413d453368c4a112b4363c37315bc5d8","user":{"login":"NikolaySolodukhin","id":16778779,"avatar_url":"https://avatars2.githubusercontent.com/u/16778779?v=4","gravatar_id":"","url":"https://api.github.com/users/NikolaySolodukhin","html_url":"https://github.com/NikolaySolodukhin","followers_url":"https://api.github.com/users/NikolaySolodukhin/followers","following_url":"https://api.github.com/users/NikolaySolodukhin/following{/other_user}","gists_url":"https://api.github.com/users/NikolaySolodukhin/gists{/gist_id}","starred_url":"https://api.github.com/users/NikolaySolodukhin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NikolaySolodukhin/subscriptions","organizations_url":"https://api.github.com/users/NikolaySolodukhin/orgs","repos_url":"https://api.github.com/users/NikolaySolodukhin/repos","events_url":"https://api.github.com/users/NikolaySolodukhin/events{/privacy}","received_events_url":"https://api.github.com/users/NikolaySolodukhin/received_events","type":"User","site_admin":false},"body":"Принципиально неверно. Телефон всегда ссылка. Я захочу нажать и чтобы у меня открылось приложение на телефоне например. ","created_at":"2018-03-02T21:19:27Z","updated_at":"2018-03-02T21:31:17Z","html_url":"https://github.com/htmlacademy-htmlcss/509305-technomart/pull/2#discussion_r171965399","pull_request_url":"https://api.github.com/repos/htmlacademy-htmlcss/509305-technomart/pulls/2","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/509305-technomart/pulls/comments/171965399"},"html":{"href":"https://github.com/htmlacademy-htmlcss/509305-technomart/pull/2#discussion_r171965399"},"pull_request":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/509305-technomart/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/htmlacademy-htmlcss/509305-technomart/pulls/2","id":172561751,"html_url":"https://github.com/htmlacademy-htmlcss/509305-technomart/pull/2","diff_url":"https://github.com/htmlacademy-htmlcss/509305-technomart/pull/2.diff","patch_url":"https://github.com/htmlacademy-htmlcss/509305-technomart/pull/2.patch","issue_url":"https://api.github.com/repos/htmlacademy-htmlcss/509305-technomart/issues/2","number":2,"state":"open","locked":false,"title":"добавил блоки: шапка, особенности, товары, произодители и сервисы","user":{"login":"k-solovev","id":36707988,"avatar_url":"https://avatars0.githubusercontent.com/u/36707988?v=4","gravatar_id":"","url":"https://api.github.com/users/k-solovev","html_url":"https://github.com/k-solovev","followers_url":"https://api.github.com/users/k-solovev/followers","following_url":"https://api.github.com/users/k-solovev/following{/other_user}","gists_url":"https://api.github.com/users/k-solovev/gists{/gist_id}","starred_url":"https://api.github.com/users/k-solovev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k-solovev/subscriptions","organizations_url":"https://api.github.com/users/k-solovev/orgs","repos_url":"https://api.github.com/users/k-solovev/repos","events_url":"https://api.github.com/users/k-solovev/events{/privacy}","received_events_url":"https://api.github.com/users/k-solovev/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-03-02T17:37:30Z","updated_at":"2018-03-02T21:31:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"18beee0c409adb5b2870f27ab25e300d2230d899","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/htmlacademy-htmlcss/509305-technomart/pulls/2/commits","review_comments_url":"https://api.github.com/repos/htmlacademy-htmlcss/509305-technomart/pulls/2/comments","review_comment_url":"https://api.github.com/repos/htmlacademy-htmlcss/509305-technomart/pulls/comments{/number}","comments_url":"https://api.github.com/repos/htmlacademy-htmlcss/509305-technomart/issues/2/comments","statuses_url":"https://api.github.com/repos/htmlacademy-htmlcss/509305-technomart/statuses/5fe3fecd413d453368c4a112b4363c37315bc5d8","head":{"label":"k-solovev:master","ref":"master","sha":"5fe3fecd413d453368c4a112b4363c37315bc5d8","user":{"login":"k-solovev","id":36707988,"avatar_url":"https://avatars0.githubusercontent.com/u/36707988?v=4","gravatar_id":"","url":"https://api.github.com/users/k-solovev","html_url":"https://github.com/k-solovev","followers_url":"https://api.github.com/users/k-solovev/followers","following_url":"https://api.github.com/users/k-solovev/following{/other_user}","gists_url":"https://api.github.com/users/k-solovev/gists{/gist_id}","starred_url":"https://api.github.com/users/k-solovev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k-solovev/subscriptions","organizations_url":"https://api.github.com/users/k-solovev/orgs","repos_url":"https://api.github.com/users/k-solovev/repos","events_url":"https://api.github.com/users/k-solovev/events{/privacy}","received_events_url":"https://api.github.com/users/k-solovev/received_events","type":"User","site_admin":false},"repo":{"id":123152673,"name":"509305-technomart","full_name":"k-solovev/509305-technomart","owner":{"login":"k-solovev","id":36707988,"avatar_url":"https://avatars0.githubusercontent.com/u/36707988?v=4","gravatar_id":"","url":"https://api.github.com/users/k-solovev","html_url":"https://github.com/k-solovev","followers_url":"https://api.github.com/users/k-solovev/followers","following_url":"https://api.github.com/users/k-solovev/following{/other_user}","gists_url":"https://api.github.com/users/k-solovev/gists{/gist_id}","starred_url":"https://api.github.com/users/k-solovev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k-solovev/subscriptions","organizations_url":"https://api.github.com/users/k-solovev/orgs","repos_url":"https://api.github.com/users/k-solovev/repos","events_url":"https://api.github.com/users/k-solovev/events{/privacy}","received_events_url":"https://api.github.com/users/k-solovev/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/k-solovev/509305-technomart","description":"Константин Соловьев","fork":true,"url":"https://api.github.com/repos/k-solovev/509305-technomart","forks_url":"https://api.github.com/repos/k-solovev/509305-technomart/forks","keys_url":"https://api.github.com/repos/k-solovev/509305-technomart/keys{/key_id}","collaborators_url":"https://api.github.com/repos/k-solovev/509305-technomart/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/k-solovev/509305-technomart/teams","hooks_url":"https://api.github.com/repos/k-solovev/509305-technomart/hooks","issue_events_url":"https://api.github.com/repos/k-solovev/509305-technomart/issues/events{/number}","events_url":"https://api.github.com/repos/k-solovev/509305-technomart/events","assignees_url":"https://api.github.com/repos/k-solovev/509305-technomart/assignees{/user}","branches_url":"https://api.github.com/repos/k-solovev/509305-technomart/branches{/branch}","tags_url":"https://api.github.com/repos/k-solovev/509305-technomart/tags","blobs_url":"https://api.github.com/repos/k-solovev/509305-technomart/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/k-solovev/509305-technomart/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/k-solovev/509305-technomart/git/refs{/sha}","trees_url":"https://api.github.com/repos/k-solovev/509305-technomart/git/trees{/sha}","statuses_url":"https://api.github.com/repos/k-solovev/509305-technomart/statuses/{sha}","languages_url":"https://api.github.com/repos/k-solovev/509305-technomart/languages","stargazers_url":"https://api.github.com/repos/k-solovev/509305-technomart/stargazers","contributors_url":"https://api.github.com/repos/k-solovev/509305-technomart/contributors","subscribers_url":"https://api.github.com/repos/k-solovev/509305-technomart/subscribers","subscription_url":"https://api.github.com/repos/k-solovev/509305-technomart/subscription","commits_url":"https://api.github.com/repos/k-solovev/509305-technomart/commits{/sha}","git_commits_url":"https://api.github.com/repos/k-solovev/509305-technomart/git/commits{/sha}","comments_url":"https://api.github.com/repos/k-solovev/509305-technomart/comments{/number}","issue_comment_url":"https://api.github.com/repos/k-solovev/509305-technomart/issues/comments{/number}","contents_url":"https://api.github.com/repos/k-solovev/509305-technomart/contents/{+path}","compare_url":"https://api.github.com/repos/k-solovev/509305-technomart/compare/{base}...{head}","merges_url":"https://api.github.com/repos/k-solovev/509305-technomart/merges","archive_url":"https://api.github.com/repos/k-solovev/509305-technomart/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/k-solovev/509305-technomart/downloads","issues_url":"https://api.github.com/repos/k-solovev/509305-technomart/issues{/number}","pulls_url":"https://api.github.com/repos/k-solovev/509305-technomart/pulls{/number}","milestones_url":"https://api.github.com/repos/k-solovev/509305-technomart/milestones{/number}","notifications_url":"https://api.github.com/repos/k-solovev/509305-technomart/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/k-solovev/509305-technomart/labels{/name}","releases_url":"https://api.github.com/repos/k-solovev/509305-technomart/releases{/id}","deployments_url":"https://api.github.com/repos/k-solovev/509305-technomart/deployments","created_at":"2018-02-27T15:57:54Z","updated_at":"2018-02-27T15:57:56Z","pushed_at":"2018-03-02T17:35:22Z","git_url":"git://github.com/k-solovev/509305-technomart.git","ssh_url":"[email protected]:k-solovev/509305-technomart.git","clone_url":"https://github.com/k-solovev/509305-technomart.git","svn_url":"https://github.com/k-solovev/509305-technomart","homepage":null,"size":7,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"htmlacademy-htmlcss:master","ref":"master","sha":"855a36ae749e72ba6b5fe975fe4b3916377b437e","user":{"login":"htmlacademy-htmlcss","id":16576942,"avatar_url":"https://avatars3.githubusercontent.com/u/16576942?v=4","gravatar_id":"","url":"https://api.github.com/users/htmlacademy-htmlcss","html_url":"https://github.com/htmlacademy-htmlcss","followers_url":"https://api.github.com/users/htmlacademy-htmlcss/followers","following_url":"https://api.github.com/users/htmlacademy-htmlcss/following{/other_user}","gists_url":"https://api.github.com/users/htmlacademy-htmlcss/gists{/gist_id}","starred_url":"https://api.github.com/users/htmlacademy-htmlcss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/htmlacademy-htmlcss/subscriptions","organizations_url":"https://api.github.com/users/htmlacademy-htmlcss/orgs","repos_url":"https://api.github.com/users/htmlacademy-htmlcss/repos","events_url":"https://api.github.com/users/htmlacademy-htmlcss/events{/privacy}","received_events_url":"https://api.github.com/users/htmlacademy-htmlcss/received_events","type":"Organization","site_admin":false},"repo":{"id":123133041,"name":"509305-technomart","full_name":"htmlacademy-htmlcss/509305-technomart","owner":{"login":"htmlacademy-htmlcss","id":16576942,"avatar_url":"https://avatars3.githubusercontent.com/u/16576942?v=4","gravatar_id":"","url":"https://api.github.com/users/htmlacademy-htmlcss","html_url":"https://github.com/htmlacademy-htmlcss","followers_url":"https://api.github.com/users/htmlacademy-htmlcss/followers","following_url":"https://api.github.com/users/htmlacademy-htmlcss/following{/other_user}","gists_url":"https://api.github.com/users/htmlacademy-htmlcss/gists{/gist_id}","starred_url":"https://api.github.com/users/htmlacademy-htmlcss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/htmlacademy-htmlcss/subscriptions","organizations_url":"https://api.github.com/users/htmlacademy-htmlcss/orgs","repos_url":"https://api.github.com/users/htmlacademy-htmlcss/repos","events_url":"https://api.github.com/users/htmlacademy-htmlcss/events{/privacy}","received_events_url":"https://api.github.com/users/htmlacademy-htmlcss/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/htmlacademy-htmlcss/509305-technomart","description":"Константин Соловьев","fork":false,"url":"https://api.github.com/repos/htmlacademy-htmlcss/509305-technomart","forks_url":"https://api.github.com/repos/htmlacademy-htmlcss/509305-technomart/forks","keys_url":"https://api.github.com/repos/htmlacademy-htmlcss/509305-technomart/keys{/key_id}","collaborators_url":"https://api.github.com/repos/htmlacademy-htmlcss/509305-technomart/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/htmlacademy-htmlcss/509305-technomart/teams","hooks_url":"https://api.github.com/repos/htmlacademy-htmlcss/509305-technomart/hooks","issue_events_url":"https://api.github.com/repos/htmlacademy-htmlcss/509305-technomart/issues/events{/number}","events_url":"https://api.github.com/repos/htmlacademy-htmlcss/509305-technomart/events","assignees_url":"https://api.github.com/repos/htmlacademy-htmlcss/509305-technomart/assignees{/user}","branches_url":"https://api.github.com/repos/htmlacademy-htmlcss/509305-technomart/branches{/branch}","tags_url":"https://api.github.com/repos/htmlacademy-htmlcss/509305-technomart/tags","blobs_url":"https://api.github.com/repos/htmlacademy-htmlcss/509305-technomart/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/htmlacademy-htmlcss/509305-technomart/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/htmlacademy-htmlcss/509305-technomart/git/refs{/sha}","trees_url":"https://api.github.com/repos/htmlacademy-htmlcss/509305-technomart/git/trees{/sha}","statuses_url":"https://api.github.com/repos/htmlacademy-htmlcss/509305-technomart/statuses/{sha}","languages_url":"https://api.github.com/repos/htmlacademy-htmlcss/509305-technomart/languages","stargazers_url":"https://api.github.com/repos/htmlacademy-htmlcss/509305-technomart/stargazers","contributors_url":"https://api.github.com/repos/htmlacademy-htmlcss/509305-technomart/contributors","subscribers_url":"https://api.github.com/repos/htmlacademy-htmlcss/509305-technomart/subscribers","subscription_url":"https://api.github.com/repos/htmlacademy-htmlcss/509305-technomart/subscription","commits_url":"https://api.github.com/repos/htmlacademy-htmlcss/509305-technomart/commits{/sha}","git_commits_url":"https://api.github.com/repos/htmlacademy-htmlcss/509305-technomart/git/commits{/sha}","comments_url":"https://api.github.com/repos/htmlacademy-htmlcss/509305-technomart/comments{/number}","issue_comment_url":"https://api.github.com/repos/htmlacademy-htmlcss/509305-technomart/issues/comments{/number}","contents_url":"https://api.github.com/repos/htmlacademy-htmlcss/509305-technomart/contents/{+path}","compare_url":"https://api.github.com/repos/htmlacademy-htmlcss/509305-technomart/compare/{base}...{head}","merges_url":"https://api.github.com/repos/htmlacademy-htmlcss/509305-technomart/merges","archive_url":"https://api.github.com/repos/htmlacademy-htmlcss/509305-technomart/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/htmlacademy-htmlcss/509305-technomart/downloads","issues_url":"https://api.github.com/repos/htmlacademy-htmlcss/509305-technomart/issues{/number}","pulls_url":"https://api.github.com/repos/htmlacademy-htmlcss/509305-technomart/pulls{/number}","milestones_url":"https://api.github.com/repos/htmlacademy-htmlcss/509305-technomart/milestones{/number}","notifications_url":"https://api.github.com/repos/htmlacademy-htmlcss/509305-technomart/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/htmlacademy-htmlcss/509305-technomart/labels{/name}","releases_url":"https://api.github.com/repos/htmlacademy-htmlcss/509305-technomart/releases{/id}","deployments_url":"https://api.github.com/repos/htmlacademy-htmlcss/509305-technomart/deployments","created_at":"2018-02-27T13:29:04Z","updated_at":"2018-02-27T16:32:14Z","pushed_at":"2018-03-02T17:37:31Z","git_url":"git://github.com/htmlacademy-htmlcss/509305-technomart.git","ssh_url":"[email protected]:htmlacademy-htmlcss/509305-technomart.git","clone_url":"https://github.com/htmlacademy-htmlcss/509305-technomart.git","svn_url":"https://github.com/htmlacademy-htmlcss/509305-technomart","homepage":"https://github.com/k-solovev/509305-technomart","size":7,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":true,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/509305-technomart/pulls/2"},"html":{"href":"https://github.com/htmlacademy-htmlcss/509305-technomart/pull/2"},"issue":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/509305-technomart/issues/2"},"comments":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/509305-technomart/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/509305-technomart/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/509305-technomart/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/509305-technomart/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/509305-technomart/statuses/5fe3fecd413d453368c4a112b4363c37315bc5d8"}},"author_association":"CONTRIBUTOR"}} | {
"id": 123133041,
"name": "htmlacademy-htmlcss/509305-technomart",
"url": "https://api.github.com/repos/htmlacademy-htmlcss/509305-technomart"
} | {
"id": 16778779,
"login": "NikolaySolodukhin",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/16778779?",
"url": "https://api.github.com/users/NikolaySolodukhin"
} | {
"id": 16576942,
"login": "htmlacademy-htmlcss",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/16576942?",
"url": "https://api.github.com/orgs/htmlacademy-htmlcss"
} | 2018-03-02T21:19:27 | 7324158662 | {"actor":{"display_login":"NikolaySolodukhin"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/htmlacademy-htmlcss/765803-device/pulls/comments/195359836","pull_request_review_id":128711184,"id":195359836,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NTM1OTgzNg==","diff_hunk":"@@ -0,0 +1,542 @@\n+/* Общие стили */\n+\n+@font-face {\n+ font-family: 'Open Sans';\n+ src: url('../fonts/opensans.woff2') format('woff2'), url('../fonts/opensans.woff') format('woff');\n+ font-weight: normal;","path":"css/style.css","position":6,"original_position":6,"commit_id":"909476bdc35e37d66d949b63a272b9b8b31b8420","original_commit_id":"909476bdc35e37d66d949b63a272b9b8b31b8420","user":{"login":"urazaev","id":22894816,"node_id":"MDQ6VXNlcjIyODk0ODE2","avatar_url":"https://avatars1.githubusercontent.com/u/22894816?v=4","gravatar_id":"","url":"https://api.github.com/users/urazaev","html_url":"https://github.com/urazaev","followers_url":"https://api.github.com/users/urazaev/followers","following_url":"https://api.github.com/users/urazaev/following{/other_user}","gists_url":"https://api.github.com/users/urazaev/gists{/gist_id}","starred_url":"https://api.github.com/users/urazaev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/urazaev/subscriptions","organizations_url":"https://api.github.com/users/urazaev/orgs","repos_url":"https://api.github.com/users/urazaev/repos","events_url":"https://api.github.com/users/urazaev/events{/privacy}","received_events_url":"https://api.github.com/users/urazaev/received_events","type":"User","site_admin":false},"body":"давай сделаем цифрами, это будет `font-weight: 400;`","created_at":"2018-06-14T09:40:21Z","updated_at":"2018-06-14T09:52:52Z","html_url":"https://github.com/htmlacademy-htmlcss/765803-device/pull/5#discussion_r195359836","pull_request_url":"https://api.github.com/repos/htmlacademy-htmlcss/765803-device/pulls/5","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/765803-device/pulls/comments/195359836"},"html":{"href":"https://github.com/htmlacademy-htmlcss/765803-device/pull/5#discussion_r195359836"},"pull_request":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/765803-device/pulls/5"}}},"pull_request":{"url":"https://api.github.com/repos/htmlacademy-htmlcss/765803-device/pulls/5","id":194728557,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0NzI4NTU3","html_url":"https://github.com/htmlacademy-htmlcss/765803-device/pull/5","diff_url":"https://github.com/htmlacademy-htmlcss/765803-device/pull/5.diff","patch_url":"https://github.com/htmlacademy-htmlcss/765803-device/pull/5.patch","issue_url":"https://api.github.com/repos/htmlacademy-htmlcss/765803-device/issues/5","number":5,"state":"open","locked":false,"title":"Базовая стилизация личного проекта","user":{"login":"YanShuoBing","id":37852149,"node_id":"MDQ6VXNlcjM3ODUyMTQ5","avatar_url":"https://avatars2.githubusercontent.com/u/37852149?v=4","gravatar_id":"","url":"https://api.github.com/users/YanShuoBing","html_url":"https://github.com/YanShuoBing","followers_url":"https://api.github.com/users/YanShuoBing/followers","following_url":"https://api.github.com/users/YanShuoBing/following{/other_user}","gists_url":"https://api.github.com/users/YanShuoBing/gists{/gist_id}","starred_url":"https://api.github.com/users/YanShuoBing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YanShuoBing/subscriptions","organizations_url":"https://api.github.com/users/YanShuoBing/orgs","repos_url":"https://api.github.com/users/YanShuoBing/repos","events_url":"https://api.github.com/users/YanShuoBing/events{/privacy}","received_events_url":"https://api.github.com/users/YanShuoBing/received_events","type":"User","site_admin":false},"body":"Имел проблемы с подключением нестандартного шрифта Gilroy. На страницах можно увидеть странные и заметно отличающиеся от макета вариации шрифта. Собирал через fontsquirrel.com . Был бы признателен, если бы ты помог мне понять, что я сделал не так. \r\n\r\n---\r\n:mortar_board: [Базовая стилизация личного проекта](https://up.htmlacademy.ru/htmlcss/21/user/765803/tasks/32)\n\n:boom: https://htmlacademy-htmlcss.github.io/765803-device/5/","created_at":"2018-06-13T22:05:37Z","updated_at":"2018-06-14T09:52:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"11944397ea2570e15fc7a844471e8f22b0e928b5","assignee":{"login":"urazaev","id":22894816,"node_id":"MDQ6VXNlcjIyODk0ODE2","avatar_url":"https://avatars1.githubusercontent.com/u/22894816?v=4","gravatar_id":"","url":"https://api.github.com/users/urazaev","html_url":"https://github.com/urazaev","followers_url":"https://api.github.com/users/urazaev/followers","following_url":"https://api.github.com/users/urazaev/following{/other_user}","gists_url":"https://api.github.com/users/urazaev/gists{/gist_id}","starred_url":"https://api.github.com/users/urazaev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/urazaev/subscriptions","organizations_url":"https://api.github.com/users/urazaev/orgs","repos_url":"https://api.github.com/users/urazaev/repos","events_url":"https://api.github.com/users/urazaev/events{/privacy}","received_events_url":"https://api.github.com/users/urazaev/received_events","type":"User","site_admin":false},"assignees":[{"login":"urazaev","id":22894816,"node_id":"MDQ6VXNlcjIyODk0ODE2","avatar_url":"https://avatars1.githubusercontent.com/u/22894816?v=4","gravatar_id":"","url":"https://api.github.com/users/urazaev","html_url":"https://github.com/urazaev","followers_url":"https://api.github.com/users/urazaev/followers","following_url":"https://api.github.com/users/urazaev/following{/other_user}","gists_url":"https://api.github.com/users/urazaev/gists{/gist_id}","starred_url":"https://api.github.com/users/urazaev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/urazaev/subscriptions","organizations_url":"https://api.github.com/users/urazaev/orgs","repos_url":"https://api.github.com/users/urazaev/repos","events_url":"https://api.github.com/users/urazaev/events{/privacy}","received_events_url":"https://api.github.com/users/urazaev/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/htmlacademy-htmlcss/765803-device/pulls/5/commits","review_comments_url":"https://api.github.com/repos/htmlacademy-htmlcss/765803-device/pulls/5/comments","review_comment_url":"https://api.github.com/repos/htmlacademy-htmlcss/765803-device/pulls/comments{/number}","comments_url":"https://api.github.com/repos/htmlacademy-htmlcss/765803-device/issues/5/comments","statuses_url":"https://api.github.com/repos/htmlacademy-htmlcss/765803-device/statuses/909476bdc35e37d66d949b63a272b9b8b31b8420","head":{"label":"YanShuoBing:master","ref":"master","sha":"909476bdc35e37d66d949b63a272b9b8b31b8420","user":{"login":"YanShuoBing","id":37852149,"node_id":"MDQ6VXNlcjM3ODUyMTQ5","avatar_url":"https://avatars2.githubusercontent.com/u/37852149?v=4","gravatar_id":"","url":"https://api.github.com/users/YanShuoBing","html_url":"https://github.com/YanShuoBing","followers_url":"https://api.github.com/users/YanShuoBing/followers","following_url":"https://api.github.com/users/YanShuoBing/following{/other_user}","gists_url":"https://api.github.com/users/YanShuoBing/gists{/gist_id}","starred_url":"https://api.github.com/users/YanShuoBing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YanShuoBing/subscriptions","organizations_url":"https://api.github.com/users/YanShuoBing/orgs","repos_url":"https://api.github.com/users/YanShuoBing/repos","events_url":"https://api.github.com/users/YanShuoBing/events{/privacy}","received_events_url":"https://api.github.com/users/YanShuoBing/received_events","type":"User","site_admin":false},"repo":{"id":135301263,"node_id":"MDEwOlJlcG9zaXRvcnkxMzUzMDEyNjM=","name":"765803-device","full_name":"YanShuoBing/765803-device","owner":{"login":"YanShuoBing","id":37852149,"node_id":"MDQ6VXNlcjM3ODUyMTQ5","avatar_url":"https://avatars2.githubusercontent.com/u/37852149?v=4","gravatar_id":"","url":"https://api.github.com/users/YanShuoBing","html_url":"https://github.com/YanShuoBing","followers_url":"https://api.github.com/users/YanShuoBing/followers","following_url":"https://api.github.com/users/YanShuoBing/following{/other_user}","gists_url":"https://api.github.com/users/YanShuoBing/gists{/gist_id}","starred_url":"https://api.github.com/users/YanShuoBing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YanShuoBing/subscriptions","organizations_url":"https://api.github.com/users/YanShuoBing/orgs","repos_url":"https://api.github.com/users/YanShuoBing/repos","events_url":"https://api.github.com/users/YanShuoBing/events{/privacy}","received_events_url":"https://api.github.com/users/YanShuoBing/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/YanShuoBing/765803-device","description":"Ян Сербин","fork":true,"url":"https://api.github.com/repos/YanShuoBing/765803-device","forks_url":"https://api.github.com/repos/YanShuoBing/765803-device/forks","keys_url":"https://api.github.com/repos/YanShuoBing/765803-device/keys{/key_id}","collaborators_url":"https://api.github.com/repos/YanShuoBing/765803-device/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/YanShuoBing/765803-device/teams","hooks_url":"https://api.github.com/repos/YanShuoBing/765803-device/hooks","issue_events_url":"https://api.github.com/repos/YanShuoBing/765803-device/issues/events{/number}","events_url":"https://api.github.com/repos/YanShuoBing/765803-device/events","assignees_url":"https://api.github.com/repos/YanShuoBing/765803-device/assignees{/user}","branches_url":"https://api.github.com/repos/YanShuoBing/765803-device/branches{/branch}","tags_url":"https://api.github.com/repos/YanShuoBing/765803-device/tags","blobs_url":"https://api.github.com/repos/YanShuoBing/765803-device/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/YanShuoBing/765803-device/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/YanShuoBing/765803-device/git/refs{/sha}","trees_url":"https://api.github.com/repos/YanShuoBing/765803-device/git/trees{/sha}","statuses_url":"https://api.github.com/repos/YanShuoBing/765803-device/statuses/{sha}","languages_url":"https://api.github.com/repos/YanShuoBing/765803-device/languages","stargazers_url":"https://api.github.com/repos/YanShuoBing/765803-device/stargazers","contributors_url":"https://api.github.com/repos/YanShuoBing/765803-device/contributors","subscribers_url":"https://api.github.com/repos/YanShuoBing/765803-device/subscribers","subscription_url":"https://api.github.com/repos/YanShuoBing/765803-device/subscription","commits_url":"https://api.github.com/repos/YanShuoBing/765803-device/commits{/sha}","git_commits_url":"https://api.github.com/repos/YanShuoBing/765803-device/git/commits{/sha}","comments_url":"https://api.github.com/repos/YanShuoBing/765803-device/comments{/number}","issue_comment_url":"https://api.github.com/repos/YanShuoBing/765803-device/issues/comments{/number}","contents_url":"https://api.github.com/repos/YanShuoBing/765803-device/contents/{+path}","compare_url":"https://api.github.com/repos/YanShuoBing/765803-device/compare/{base}...{head}","merges_url":"https://api.github.com/repos/YanShuoBing/765803-device/merges","archive_url":"https://api.github.com/repos/YanShuoBing/765803-device/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/YanShuoBing/765803-device/downloads","issues_url":"https://api.github.com/repos/YanShuoBing/765803-device/issues{/number}","pulls_url":"https://api.github.com/repos/YanShuoBing/765803-device/pulls{/number}","milestones_url":"https://api.github.com/repos/YanShuoBing/765803-device/milestones{/number}","notifications_url":"https://api.github.com/repos/YanShuoBing/765803-device/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/YanShuoBing/765803-device/labels{/name}","releases_url":"https://api.github.com/repos/YanShuoBing/765803-device/releases{/id}","deployments_url":"https://api.github.com/repos/YanShuoBing/765803-device/deployments","created_at":"2018-05-29T13:35:25Z","updated_at":"2018-06-14T08:47:20Z","pushed_at":"2018-06-14T08:47:18Z","git_url":"git://github.com/YanShuoBing/765803-device.git","ssh_url":"[email protected]:YanShuoBing/765803-device.git","clone_url":"https://github.com/YanShuoBing/765803-device.git","svn_url":"https://github.com/YanShuoBing/765803-device","homepage":"","size":506,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"htmlacademy-htmlcss:master","ref":"master","sha":"0ea5a1d1fcf3d58150c5b3fb7877b7bcdc18e74f","user":{"login":"htmlacademy-htmlcss","id":16576942,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NTc2OTQy","avatar_url":"https://avatars3.githubusercontent.com/u/16576942?v=4","gravatar_id":"","url":"https://api.github.com/users/htmlacademy-htmlcss","html_url":"https://github.com/htmlacademy-htmlcss","followers_url":"https://api.github.com/users/htmlacademy-htmlcss/followers","following_url":"https://api.github.com/users/htmlacademy-htmlcss/following{/other_user}","gists_url":"https://api.github.com/users/htmlacademy-htmlcss/gists{/gist_id}","starred_url":"https://api.github.com/users/htmlacademy-htmlcss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/htmlacademy-htmlcss/subscriptions","organizations_url":"https://api.github.com/users/htmlacademy-htmlcss/orgs","repos_url":"https://api.github.com/users/htmlacademy-htmlcss/repos","events_url":"https://api.github.com/users/htmlacademy-htmlcss/events{/privacy}","received_events_url":"https://api.github.com/users/htmlacademy-htmlcss/received_events","type":"Organization","site_admin":false},"repo":{"id":135301077,"node_id":"MDEwOlJlcG9zaXRvcnkxMzUzMDEwNzc=","name":"765803-device","full_name":"htmlacademy-htmlcss/765803-device","owner":{"login":"htmlacademy-htmlcss","id":16576942,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NTc2OTQy","avatar_url":"https://avatars3.githubusercontent.com/u/16576942?v=4","gravatar_id":"","url":"https://api.github.com/users/htmlacademy-htmlcss","html_url":"https://github.com/htmlacademy-htmlcss","followers_url":"https://api.github.com/users/htmlacademy-htmlcss/followers","following_url":"https://api.github.com/users/htmlacademy-htmlcss/following{/other_user}","gists_url":"https://api.github.com/users/htmlacademy-htmlcss/gists{/gist_id}","starred_url":"https://api.github.com/users/htmlacademy-htmlcss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/htmlacademy-htmlcss/subscriptions","organizations_url":"https://api.github.com/users/htmlacademy-htmlcss/orgs","repos_url":"https://api.github.com/users/htmlacademy-htmlcss/repos","events_url":"https://api.github.com/users/htmlacademy-htmlcss/events{/privacy}","received_events_url":"https://api.github.com/users/htmlacademy-htmlcss/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/htmlacademy-htmlcss/765803-device","description":"Yan Serbin","fork":false,"url":"https://api.github.com/repos/htmlacademy-htmlcss/765803-device","forks_url":"https://api.github.com/repos/htmlacademy-htmlcss/765803-device/forks","keys_url":"https://api.github.com/repos/htmlacademy-htmlcss/765803-device/keys{/key_id}","collaborators_url":"https://api.github.com/repos/htmlacademy-htmlcss/765803-device/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/htmlacademy-htmlcss/765803-device/teams","hooks_url":"https://api.github.com/repos/htmlacademy-htmlcss/765803-device/hooks","issue_events_url":"https://api.github.com/repos/htmlacademy-htmlcss/765803-device/issues/events{/number}","events_url":"https://api.github.com/repos/htmlacademy-htmlcss/765803-device/events","assignees_url":"https://api.github.com/repos/htmlacademy-htmlcss/765803-device/assignees{/user}","branches_url":"https://api.github.com/repos/htmlacademy-htmlcss/765803-device/branches{/branch}","tags_url":"https://api.github.com/repos/htmlacademy-htmlcss/765803-device/tags","blobs_url":"https://api.github.com/repos/htmlacademy-htmlcss/765803-device/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/htmlacademy-htmlcss/765803-device/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/htmlacademy-htmlcss/765803-device/git/refs{/sha}","trees_url":"https://api.github.com/repos/htmlacademy-htmlcss/765803-device/git/trees{/sha}","statuses_url":"https://api.github.com/repos/htmlacademy-htmlcss/765803-device/statuses/{sha}","languages_url":"https://api.github.com/repos/htmlacademy-htmlcss/765803-device/languages","stargazers_url":"https://api.github.com/repos/htmlacademy-htmlcss/765803-device/stargazers","contributors_url":"https://api.github.com/repos/htmlacademy-htmlcss/765803-device/contributors","subscribers_url":"https://api.github.com/repos/htmlacademy-htmlcss/765803-device/subscribers","subscription_url":"https://api.github.com/repos/htmlacademy-htmlcss/765803-device/subscription","commits_url":"https://api.github.com/repos/htmlacademy-htmlcss/765803-device/commits{/sha}","git_commits_url":"https://api.github.com/repos/htmlacademy-htmlcss/765803-device/git/commits{/sha}","comments_url":"https://api.github.com/repos/htmlacademy-htmlcss/765803-device/comments{/number}","issue_comment_url":"https://api.github.com/repos/htmlacademy-htmlcss/765803-device/issues/comments{/number}","contents_url":"https://api.github.com/repos/htmlacademy-htmlcss/765803-device/contents/{+path}","compare_url":"https://api.github.com/repos/htmlacademy-htmlcss/765803-device/compare/{base}...{head}","merges_url":"https://api.github.com/repos/htmlacademy-htmlcss/765803-device/merges","archive_url":"https://api.github.com/repos/htmlacademy-htmlcss/765803-device/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/htmlacademy-htmlcss/765803-device/downloads","issues_url":"https://api.github.com/repos/htmlacademy-htmlcss/765803-device/issues{/number}","pulls_url":"https://api.github.com/repos/htmlacademy-htmlcss/765803-device/pulls{/number}","milestones_url":"https://api.github.com/repos/htmlacademy-htmlcss/765803-device/milestones{/number}","notifications_url":"https://api.github.com/repos/htmlacademy-htmlcss/765803-device/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/htmlacademy-htmlcss/765803-device/labels{/name}","releases_url":"https://api.github.com/repos/htmlacademy-htmlcss/765803-device/releases{/id}","deployments_url":"https://api.github.com/repos/htmlacademy-htmlcss/765803-device/deployments","created_at":"2018-05-29T13:34:12Z","updated_at":"2018-06-11T04:42:44Z","pushed_at":"2018-06-14T09:17:59Z","git_url":"git://github.com/htmlacademy-htmlcss/765803-device.git","ssh_url":"[email protected]:htmlacademy-htmlcss/765803-device.git","clone_url":"https://github.com/htmlacademy-htmlcss/765803-device.git","svn_url":"https://github.com/htmlacademy-htmlcss/765803-device","homepage":"https://github.com/YanShuoBing/765803-device","size":350,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":true,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/765803-device/pulls/5"},"html":{"href":"https://github.com/htmlacademy-htmlcss/765803-device/pull/5"},"issue":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/765803-device/issues/5"},"comments":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/765803-device/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/765803-device/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/765803-device/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/765803-device/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/765803-device/statuses/909476bdc35e37d66d949b63a272b9b8b31b8420"}},"author_association":"CONTRIBUTOR"}} | {
"id": 135301077,
"name": "htmlacademy-htmlcss/765803-device",
"url": "https://api.github.com/repos/htmlacademy-htmlcss/765803-device"
} | {
"id": 22894816,
"login": "urazaev",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/22894816?",
"url": "https://api.github.com/users/urazaev"
} | {
"id": 16576942,
"login": "htmlacademy-htmlcss",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/16576942?",
"url": "https://api.github.com/orgs/htmlacademy-htmlcss"
} | 2018-06-14T09:40:21 | 7824037334 | {"actor":{"display_login":"urazaev"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/htmlacademy-htmlcss/587225-device/pulls/comments/197486701","pull_request_review_id":131240211,"id":197486701,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NzQ4NjcwMQ==","diff_hunk":"@@ -136,31 +136,38 @@ <h2 class=\"visually-hidden\">Фильтр каталога</h2>\n \t\t\t\t\t<fieldset class=\"filter-area\">\n \t\t\t\t\t\t<legend class=\"filter-area-title\">Цвет</legend>\n \t\t\t\t\t\t<ul class=\"color-list\">\n-\t\t\t\t\t\t\t<li class=\"color-item color-checked\">\n-\t\t\t\t\t\t\t\t<label class=\"color-label\"><input class=\"visually-hidden\" type=\"checkbox\" name=\"color-black\" checked>Черный</label>\n+\t\t\t\t\t\t\t<li class=\"color-item\">\n+\t\t\t\t\t\t\t\t<input class=\"visually-hidden filter-input-checkbox\" type=\"checkbox\" name=\"color-black\" id=\"color-black\" checked>","path":"catalog.html","position":null,"original_position":32,"commit_id":"4088afcdcb234ad745c7c286d5f03e06abb6bc49","original_commit_id":"4088afcdcb234ad745c7c286d5f03e06abb6bc49","user":{"login":"GeorgeGUS","id":12587125,"node_id":"MDQ6VXNlcjEyNTg3MTI1","avatar_url":"https://avatars0.githubusercontent.com/u/12587125?v=4","gravatar_id":"","url":"https://api.github.com/users/GeorgeGUS","html_url":"https://github.com/GeorgeGUS","followers_url":"https://api.github.com/users/GeorgeGUS/followers","following_url":"https://api.github.com/users/GeorgeGUS/following{/other_user}","gists_url":"https://api.github.com/users/GeorgeGUS/gists{/gist_id}","starred_url":"https://api.github.com/users/GeorgeGUS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GeorgeGUS/subscriptions","organizations_url":"https://api.github.com/users/GeorgeGUS/orgs","repos_url":"https://api.github.com/users/GeorgeGUS/repos","events_url":"https://api.github.com/users/GeorgeGUS/events{/privacy}","received_events_url":"https://api.github.com/users/GeorgeGUS/received_events","type":"User","site_admin":false},"body":"Также не свёрстаны состояния для заблокированных чекбоксов и радиокнопок.","created_at":"2018-06-22T15:41:16Z","updated_at":"2018-06-22T15:52:25Z","html_url":"https://github.com/htmlacademy-htmlcss/587225-device/pull/8#discussion_r197486701","pull_request_url":"https://api.github.com/repos/htmlacademy-htmlcss/587225-device/pulls/8","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/587225-device/pulls/comments/197486701"},"html":{"href":"https://github.com/htmlacademy-htmlcss/587225-device/pull/8#discussion_r197486701"},"pull_request":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/587225-device/pulls/8"}},"in_reply_to_id":197483291},"pull_request":{"url":"https://api.github.com/repos/htmlacademy-htmlcss/587225-device/pulls/8","id":196352825,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk2MzUyODI1","html_url":"https://github.com/htmlacademy-htmlcss/587225-device/pull/8","diff_url":"https://github.com/htmlacademy-htmlcss/587225-device/pull/8.diff","patch_url":"https://github.com/htmlacademy-htmlcss/587225-device/pull/8.patch","issue_url":"https://api.github.com/repos/htmlacademy-htmlcss/587225-device/issues/8","number":8,"state":"open","locked":false,"title":"Декоративные элементы личного проекта","user":{"login":"intsamoilov","id":39725294,"node_id":"MDQ6VXNlcjM5NzI1Mjk0","avatar_url":"https://avatars3.githubusercontent.com/u/39725294?v=4","gravatar_id":"","url":"https://api.github.com/users/intsamoilov","html_url":"https://github.com/intsamoilov","followers_url":"https://api.github.com/users/intsamoilov/followers","following_url":"https://api.github.com/users/intsamoilov/following{/other_user}","gists_url":"https://api.github.com/users/intsamoilov/gists{/gist_id}","starred_url":"https://api.github.com/users/intsamoilov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/intsamoilov/subscriptions","organizations_url":"https://api.github.com/users/intsamoilov/orgs","repos_url":"https://api.github.com/users/intsamoilov/repos","events_url":"https://api.github.com/users/intsamoilov/events{/privacy}","received_events_url":"https://api.github.com/users/intsamoilov/received_events","type":"User","site_admin":false},"body":"\n\n---\n:mortar_board: [Декоративные элементы личного проекта](https://up.htmlacademy.ru/htmlcss/21/user/587225/tasks/44)\n\n:boom: https://htmlacademy-htmlcss.github.io/587225-device/8/","created_at":"2018-06-21T06:58:19Z","updated_at":"2018-06-22T15:52:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c47880a9b6b28732fc769ac79fd7de3d6725b3e4","assignee":{"login":"GeorgeGUS","id":12587125,"node_id":"MDQ6VXNlcjEyNTg3MTI1","avatar_url":"https://avatars0.githubusercontent.com/u/12587125?v=4","gravatar_id":"","url":"https://api.github.com/users/GeorgeGUS","html_url":"https://github.com/GeorgeGUS","followers_url":"https://api.github.com/users/GeorgeGUS/followers","following_url":"https://api.github.com/users/GeorgeGUS/following{/other_user}","gists_url":"https://api.github.com/users/GeorgeGUS/gists{/gist_id}","starred_url":"https://api.github.com/users/GeorgeGUS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GeorgeGUS/subscriptions","organizations_url":"https://api.github.com/users/GeorgeGUS/orgs","repos_url":"https://api.github.com/users/GeorgeGUS/repos","events_url":"https://api.github.com/users/GeorgeGUS/events{/privacy}","received_events_url":"https://api.github.com/users/GeorgeGUS/received_events","type":"User","site_admin":false},"assignees":[{"login":"GeorgeGUS","id":12587125,"node_id":"MDQ6VXNlcjEyNTg3MTI1","avatar_url":"https://avatars0.githubusercontent.com/u/12587125?v=4","gravatar_id":"","url":"https://api.github.com/users/GeorgeGUS","html_url":"https://github.com/GeorgeGUS","followers_url":"https://api.github.com/users/GeorgeGUS/followers","following_url":"https://api.github.com/users/GeorgeGUS/following{/other_user}","gists_url":"https://api.github.com/users/GeorgeGUS/gists{/gist_id}","starred_url":"https://api.github.com/users/GeorgeGUS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GeorgeGUS/subscriptions","organizations_url":"https://api.github.com/users/GeorgeGUS/orgs","repos_url":"https://api.github.com/users/GeorgeGUS/repos","events_url":"https://api.github.com/users/GeorgeGUS/events{/privacy}","received_events_url":"https://api.github.com/users/GeorgeGUS/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/htmlacademy-htmlcss/587225-device/pulls/8/commits","review_comments_url":"https://api.github.com/repos/htmlacademy-htmlcss/587225-device/pulls/8/comments","review_comment_url":"https://api.github.com/repos/htmlacademy-htmlcss/587225-device/pulls/comments{/number}","comments_url":"https://api.github.com/repos/htmlacademy-htmlcss/587225-device/issues/8/comments","statuses_url":"https://api.github.com/repos/htmlacademy-htmlcss/587225-device/statuses/4088afcdcb234ad745c7c286d5f03e06abb6bc49","head":{"label":"intsamoilov:master","ref":"master","sha":"4088afcdcb234ad745c7c286d5f03e06abb6bc49","user":{"login":"intsamoilov","id":39725294,"node_id":"MDQ6VXNlcjM5NzI1Mjk0","avatar_url":"https://avatars3.githubusercontent.com/u/39725294?v=4","gravatar_id":"","url":"https://api.github.com/users/intsamoilov","html_url":"https://github.com/intsamoilov","followers_url":"https://api.github.com/users/intsamoilov/followers","following_url":"https://api.github.com/users/intsamoilov/following{/other_user}","gists_url":"https://api.github.com/users/intsamoilov/gists{/gist_id}","starred_url":"https://api.github.com/users/intsamoilov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/intsamoilov/subscriptions","organizations_url":"https://api.github.com/users/intsamoilov/orgs","repos_url":"https://api.github.com/users/intsamoilov/repos","events_url":"https://api.github.com/users/intsamoilov/events{/privacy}","received_events_url":"https://api.github.com/users/intsamoilov/received_events","type":"User","site_admin":false},"repo":{"id":135263773,"node_id":"MDEwOlJlcG9zaXRvcnkxMzUyNjM3NzM=","name":"587225-device","full_name":"intsamoilov/587225-device","owner":{"login":"intsamoilov","id":39725294,"node_id":"MDQ6VXNlcjM5NzI1Mjk0","avatar_url":"https://avatars3.githubusercontent.com/u/39725294?v=4","gravatar_id":"","url":"https://api.github.com/users/intsamoilov","html_url":"https://github.com/intsamoilov","followers_url":"https://api.github.com/users/intsamoilov/followers","following_url":"https://api.github.com/users/intsamoilov/following{/other_user}","gists_url":"https://api.github.com/users/intsamoilov/gists{/gist_id}","starred_url":"https://api.github.com/users/intsamoilov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/intsamoilov/subscriptions","organizations_url":"https://api.github.com/users/intsamoilov/orgs","repos_url":"https://api.github.com/users/intsamoilov/repos","events_url":"https://api.github.com/users/intsamoilov/events{/privacy}","received_events_url":"https://api.github.com/users/intsamoilov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/intsamoilov/587225-device","description":"Александр Самойлов","fork":true,"url":"https://api.github.com/repos/intsamoilov/587225-device","forks_url":"https://api.github.com/repos/intsamoilov/587225-device/forks","keys_url":"https://api.github.com/repos/intsamoilov/587225-device/keys{/key_id}","collaborators_url":"https://api.github.com/repos/intsamoilov/587225-device/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/intsamoilov/587225-device/teams","hooks_url":"https://api.github.com/repos/intsamoilov/587225-device/hooks","issue_events_url":"https://api.github.com/repos/intsamoilov/587225-device/issues/events{/number}","events_url":"https://api.github.com/repos/intsamoilov/587225-device/events","assignees_url":"https://api.github.com/repos/intsamoilov/587225-device/assignees{/user}","branches_url":"https://api.github.com/repos/intsamoilov/587225-device/branches{/branch}","tags_url":"https://api.github.com/repos/intsamoilov/587225-device/tags","blobs_url":"https://api.github.com/repos/intsamoilov/587225-device/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/intsamoilov/587225-device/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/intsamoilov/587225-device/git/refs{/sha}","trees_url":"https://api.github.com/repos/intsamoilov/587225-device/git/trees{/sha}","statuses_url":"https://api.github.com/repos/intsamoilov/587225-device/statuses/{sha}","languages_url":"https://api.github.com/repos/intsamoilov/587225-device/languages","stargazers_url":"https://api.github.com/repos/intsamoilov/587225-device/stargazers","contributors_url":"https://api.github.com/repos/intsamoilov/587225-device/contributors","subscribers_url":"https://api.github.com/repos/intsamoilov/587225-device/subscribers","subscription_url":"https://api.github.com/repos/intsamoilov/587225-device/subscription","commits_url":"https://api.github.com/repos/intsamoilov/587225-device/commits{/sha}","git_commits_url":"https://api.github.com/repos/intsamoilov/587225-device/git/commits{/sha}","comments_url":"https://api.github.com/repos/intsamoilov/587225-device/comments{/number}","issue_comment_url":"https://api.github.com/repos/intsamoilov/587225-device/issues/comments{/number}","contents_url":"https://api.github.com/repos/intsamoilov/587225-device/contents/{+path}","compare_url":"https://api.github.com/repos/intsamoilov/587225-device/compare/{base}...{head}","merges_url":"https://api.github.com/repos/intsamoilov/587225-device/merges","archive_url":"https://api.github.com/repos/intsamoilov/587225-device/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/intsamoilov/587225-device/downloads","issues_url":"https://api.github.com/repos/intsamoilov/587225-device/issues{/number}","pulls_url":"https://api.github.com/repos/intsamoilov/587225-device/pulls{/number}","milestones_url":"https://api.github.com/repos/intsamoilov/587225-device/milestones{/number}","notifications_url":"https://api.github.com/repos/intsamoilov/587225-device/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/intsamoilov/587225-device/labels{/name}","releases_url":"https://api.github.com/repos/intsamoilov/587225-device/releases{/id}","deployments_url":"https://api.github.com/repos/intsamoilov/587225-device/deployments","created_at":"2018-05-29T08:17:24Z","updated_at":"2018-06-22T10:54:55Z","pushed_at":"2018-06-22T10:54:53Z","git_url":"git://github.com/intsamoilov/587225-device.git","ssh_url":"[email protected]:intsamoilov/587225-device.git","clone_url":"https://github.com/intsamoilov/587225-device.git","svn_url":"https://github.com/intsamoilov/587225-device","homepage":null,"size":592,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"htmlacademy-htmlcss:master","ref":"master","sha":"52509dfc3812362afbf8d74369348b8fe0698f75","user":{"login":"htmlacademy-htmlcss","id":16576942,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NTc2OTQy","avatar_url":"https://avatars3.githubusercontent.com/u/16576942?v=4","gravatar_id":"","url":"https://api.github.com/users/htmlacademy-htmlcss","html_url":"https://github.com/htmlacademy-htmlcss","followers_url":"https://api.github.com/users/htmlacademy-htmlcss/followers","following_url":"https://api.github.com/users/htmlacademy-htmlcss/following{/other_user}","gists_url":"https://api.github.com/users/htmlacademy-htmlcss/gists{/gist_id}","starred_url":"https://api.github.com/users/htmlacademy-htmlcss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/htmlacademy-htmlcss/subscriptions","organizations_url":"https://api.github.com/users/htmlacademy-htmlcss/orgs","repos_url":"https://api.github.com/users/htmlacademy-htmlcss/repos","events_url":"https://api.github.com/users/htmlacademy-htmlcss/events{/privacy}","received_events_url":"https://api.github.com/users/htmlacademy-htmlcss/received_events","type":"Organization","site_admin":false},"repo":{"id":135263065,"node_id":"MDEwOlJlcG9zaXRvcnkxMzUyNjMwNjU=","name":"587225-device","full_name":"htmlacademy-htmlcss/587225-device","owner":{"login":"htmlacademy-htmlcss","id":16576942,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NTc2OTQy","avatar_url":"https://avatars3.githubusercontent.com/u/16576942?v=4","gravatar_id":"","url":"https://api.github.com/users/htmlacademy-htmlcss","html_url":"https://github.com/htmlacademy-htmlcss","followers_url":"https://api.github.com/users/htmlacademy-htmlcss/followers","following_url":"https://api.github.com/users/htmlacademy-htmlcss/following{/other_user}","gists_url":"https://api.github.com/users/htmlacademy-htmlcss/gists{/gist_id}","starred_url":"https://api.github.com/users/htmlacademy-htmlcss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/htmlacademy-htmlcss/subscriptions","organizations_url":"https://api.github.com/users/htmlacademy-htmlcss/orgs","repos_url":"https://api.github.com/users/htmlacademy-htmlcss/repos","events_url":"https://api.github.com/users/htmlacademy-htmlcss/events{/privacy}","received_events_url":"https://api.github.com/users/htmlacademy-htmlcss/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/htmlacademy-htmlcss/587225-device","description":"Александр Самойлов","fork":false,"url":"https://api.github.com/repos/htmlacademy-htmlcss/587225-device","forks_url":"https://api.github.com/repos/htmlacademy-htmlcss/587225-device/forks","keys_url":"https://api.github.com/repos/htmlacademy-htmlcss/587225-device/keys{/key_id}","collaborators_url":"https://api.github.com/repos/htmlacademy-htmlcss/587225-device/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/htmlacademy-htmlcss/587225-device/teams","hooks_url":"https://api.github.com/repos/htmlacademy-htmlcss/587225-device/hooks","issue_events_url":"https://api.github.com/repos/htmlacademy-htmlcss/587225-device/issues/events{/number}","events_url":"https://api.github.com/repos/htmlacademy-htmlcss/587225-device/events","assignees_url":"https://api.github.com/repos/htmlacademy-htmlcss/587225-device/assignees{/user}","branches_url":"https://api.github.com/repos/htmlacademy-htmlcss/587225-device/branches{/branch}","tags_url":"https://api.github.com/repos/htmlacademy-htmlcss/587225-device/tags","blobs_url":"https://api.github.com/repos/htmlacademy-htmlcss/587225-device/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/htmlacademy-htmlcss/587225-device/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/htmlacademy-htmlcss/587225-device/git/refs{/sha}","trees_url":"https://api.github.com/repos/htmlacademy-htmlcss/587225-device/git/trees{/sha}","statuses_url":"https://api.github.com/repos/htmlacademy-htmlcss/587225-device/statuses/{sha}","languages_url":"https://api.github.com/repos/htmlacademy-htmlcss/587225-device/languages","stargazers_url":"https://api.github.com/repos/htmlacademy-htmlcss/587225-device/stargazers","contributors_url":"https://api.github.com/repos/htmlacademy-htmlcss/587225-device/contributors","subscribers_url":"https://api.github.com/repos/htmlacademy-htmlcss/587225-device/subscribers","subscription_url":"https://api.github.com/repos/htmlacademy-htmlcss/587225-device/subscription","commits_url":"https://api.github.com/repos/htmlacademy-htmlcss/587225-device/commits{/sha}","git_commits_url":"https://api.github.com/repos/htmlacademy-htmlcss/587225-device/git/commits{/sha}","comments_url":"https://api.github.com/repos/htmlacademy-htmlcss/587225-device/comments{/number}","issue_comment_url":"https://api.github.com/repos/htmlacademy-htmlcss/587225-device/issues/comments{/number}","contents_url":"https://api.github.com/repos/htmlacademy-htmlcss/587225-device/contents/{+path}","compare_url":"https://api.github.com/repos/htmlacademy-htmlcss/587225-device/compare/{base}...{head}","merges_url":"https://api.github.com/repos/htmlacademy-htmlcss/587225-device/merges","archive_url":"https://api.github.com/repos/htmlacademy-htmlcss/587225-device/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/htmlacademy-htmlcss/587225-device/downloads","issues_url":"https://api.github.com/repos/htmlacademy-htmlcss/587225-device/issues{/number}","pulls_url":"https://api.github.com/repos/htmlacademy-htmlcss/587225-device/pulls{/number}","milestones_url":"https://api.github.com/repos/htmlacademy-htmlcss/587225-device/milestones{/number}","notifications_url":"https://api.github.com/repos/htmlacademy-htmlcss/587225-device/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/htmlacademy-htmlcss/587225-device/labels{/name}","releases_url":"https://api.github.com/repos/htmlacademy-htmlcss/587225-device/releases{/id}","deployments_url":"https://api.github.com/repos/htmlacademy-htmlcss/587225-device/deployments","created_at":"2018-05-29T08:11:31Z","updated_at":"2018-06-19T07:54:53Z","pushed_at":"2018-06-22T15:23:46Z","git_url":"git://github.com/htmlacademy-htmlcss/587225-device.git","ssh_url":"[email protected]:htmlacademy-htmlcss/587225-device.git","clone_url":"https://github.com/htmlacademy-htmlcss/587225-device.git","svn_url":"https://github.com/htmlacademy-htmlcss/587225-device","homepage":"https://github.com/intsamoilov/587225-device","size":631,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":true,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/587225-device/pulls/8"},"html":{"href":"https://github.com/htmlacademy-htmlcss/587225-device/pull/8"},"issue":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/587225-device/issues/8"},"comments":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/587225-device/issues/8/comments"},"review_comments":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/587225-device/pulls/8/comments"},"review_comment":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/587225-device/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/587225-device/pulls/8/commits"},"statuses":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/587225-device/statuses/4088afcdcb234ad745c7c286d5f03e06abb6bc49"}},"author_association":"CONTRIBUTOR"}} | {
"id": 135263065,
"name": "htmlacademy-htmlcss/587225-device",
"url": "https://api.github.com/repos/htmlacademy-htmlcss/587225-device"
} | {
"id": 12587125,
"login": "GeorgeGUS",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/12587125?",
"url": "https://api.github.com/users/GeorgeGUS"
} | {
"id": 16576942,
"login": "htmlacademy-htmlcss",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/16576942?",
"url": "https://api.github.com/orgs/htmlacademy-htmlcss"
} | 2018-06-22T15:41:16 | 7864945078 | {"actor":{"display_login":"GeorgeGUS"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/htmlacademy-htmlcss/190994-sedona/pulls/comments/214743088","pull_request_review_id":151859591,"id":214743088,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNDc0MzA4OA==","diff_hunk":"@@ -65,11 +108,11 @@ <h2>Стоимость в сутки(Р):</h2>\n <div class=\"result-info\">\n <div class=\"result-type\">\n <span>Гостиница</span>\n- <button>Подробнее</button>\n+ <input class=\"info\" type=\"submit\" value=\"Подробнее\">","path":"hotels.html","position":117,"original_position":117,"commit_id":"b035f1419a7d4996260a226c0c4617bc787a3a32","original_commit_id":"b035f1419a7d4996260a226c0c4617bc787a3a32","user":{"login":"Sergeygezha","id":41345915,"node_id":"MDQ6VXNlcjQxMzQ1OTE1","avatar_url":"https://avatars2.githubusercontent.com/u/41345915?v=4","gravatar_id":"","url":"https://api.github.com/users/Sergeygezha","html_url":"https://github.com/Sergeygezha","followers_url":"https://api.github.com/users/Sergeygezha/followers","following_url":"https://api.github.com/users/Sergeygezha/following{/other_user}","gists_url":"https://api.github.com/users/Sergeygezha/gists{/gist_id}","starred_url":"https://api.github.com/users/Sergeygezha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sergeygezha/subscriptions","organizations_url":"https://api.github.com/users/Sergeygezha/orgs","repos_url":"https://api.github.com/users/Sergeygezha/repos","events_url":"https://api.github.com/users/Sergeygezha/events{/privacy}","received_events_url":"https://api.github.com/users/Sergeygezha/received_events","type":"User","site_admin":false},"body":"исправил","created_at":"2018-09-03T18:17:05Z","updated_at":"2018-09-03T18:17:05Z","html_url":"https://github.com/htmlacademy-htmlcss/190994-sedona/pull/4#discussion_r214743088","pull_request_url":"https://api.github.com/repos/htmlacademy-htmlcss/190994-sedona/pulls/4","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/190994-sedona/pulls/comments/214743088"},"html":{"href":"https://github.com/htmlacademy-htmlcss/190994-sedona/pull/4#discussion_r214743088"},"pull_request":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/190994-sedona/pulls/4"}},"in_reply_to_id":214578926},"pull_request":{"url":"https://api.github.com/repos/htmlacademy-htmlcss/190994-sedona/pulls/4","id":212608535,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEyNjA4NTM1","html_url":"https://github.com/htmlacademy-htmlcss/190994-sedona/pull/4","diff_url":"https://github.com/htmlacademy-htmlcss/190994-sedona/pull/4.diff","patch_url":"https://github.com/htmlacademy-htmlcss/190994-sedona/pull/4.patch","issue_url":"https://api.github.com/repos/htmlacademy-htmlcss/190994-sedona/issues/4","number":4,"state":"open","locked":false,"title":"Завершаем разметку личного проекта","user":{"login":"Sergeygezha","id":41345915,"node_id":"MDQ6VXNlcjQxMzQ1OTE1","avatar_url":"https://avatars2.githubusercontent.com/u/41345915?v=4","gravatar_id":"","url":"https://api.github.com/users/Sergeygezha","html_url":"https://github.com/Sergeygezha","followers_url":"https://api.github.com/users/Sergeygezha/followers","following_url":"https://api.github.com/users/Sergeygezha/following{/other_user}","gists_url":"https://api.github.com/users/Sergeygezha/gists{/gist_id}","starred_url":"https://api.github.com/users/Sergeygezha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sergeygezha/subscriptions","organizations_url":"https://api.github.com/users/Sergeygezha/orgs","repos_url":"https://api.github.com/users/Sergeygezha/repos","events_url":"https://api.github.com/users/Sergeygezha/events{/privacy}","received_events_url":"https://api.github.com/users/Sergeygezha/received_events","type":"User","site_admin":false},"body":"\n\n---\n:mortar_board: [Завершаем разметку личного проекта](https://up.htmlacademy.ru/htmlcss/22/user/190994/tasks/26)","created_at":"2018-09-02T19:46:33Z","updated_at":"2018-09-03T18:17:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d7db99e8bbd8e6b995254b32a4abca0aa18d8efb","assignee":{"login":"v1z","id":8428903,"node_id":"MDQ6VXNlcjg0Mjg5MDM=","avatar_url":"https://avatars0.githubusercontent.com/u/8428903?v=4","gravatar_id":"","url":"https://api.github.com/users/v1z","html_url":"https://github.com/v1z","followers_url":"https://api.github.com/users/v1z/followers","following_url":"https://api.github.com/users/v1z/following{/other_user}","gists_url":"https://api.github.com/users/v1z/gists{/gist_id}","starred_url":"https://api.github.com/users/v1z/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/v1z/subscriptions","organizations_url":"https://api.github.com/users/v1z/orgs","repos_url":"https://api.github.com/users/v1z/repos","events_url":"https://api.github.com/users/v1z/events{/privacy}","received_events_url":"https://api.github.com/users/v1z/received_events","type":"User","site_admin":false},"assignees":[{"login":"v1z","id":8428903,"node_id":"MDQ6VXNlcjg0Mjg5MDM=","avatar_url":"https://avatars0.githubusercontent.com/u/8428903?v=4","gravatar_id":"","url":"https://api.github.com/users/v1z","html_url":"https://github.com/v1z","followers_url":"https://api.github.com/users/v1z/followers","following_url":"https://api.github.com/users/v1z/following{/other_user}","gists_url":"https://api.github.com/users/v1z/gists{/gist_id}","starred_url":"https://api.github.com/users/v1z/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/v1z/subscriptions","organizations_url":"https://api.github.com/users/v1z/orgs","repos_url":"https://api.github.com/users/v1z/repos","events_url":"https://api.github.com/users/v1z/events{/privacy}","received_events_url":"https://api.github.com/users/v1z/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/htmlacademy-htmlcss/190994-sedona/pulls/4/commits","review_comments_url":"https://api.github.com/repos/htmlacademy-htmlcss/190994-sedona/pulls/4/comments","review_comment_url":"https://api.github.com/repos/htmlacademy-htmlcss/190994-sedona/pulls/comments{/number}","comments_url":"https://api.github.com/repos/htmlacademy-htmlcss/190994-sedona/issues/4/comments","statuses_url":"https://api.github.com/repos/htmlacademy-htmlcss/190994-sedona/statuses/b035f1419a7d4996260a226c0c4617bc787a3a32","head":{"label":"Sergeygezha:master","ref":"master","sha":"b035f1419a7d4996260a226c0c4617bc787a3a32","user":{"login":"Sergeygezha","id":41345915,"node_id":"MDQ6VXNlcjQxMzQ1OTE1","avatar_url":"https://avatars2.githubusercontent.com/u/41345915?v=4","gravatar_id":"","url":"https://api.github.com/users/Sergeygezha","html_url":"https://github.com/Sergeygezha","followers_url":"https://api.github.com/users/Sergeygezha/followers","following_url":"https://api.github.com/users/Sergeygezha/following{/other_user}","gists_url":"https://api.github.com/users/Sergeygezha/gists{/gist_id}","starred_url":"https://api.github.com/users/Sergeygezha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sergeygezha/subscriptions","organizations_url":"https://api.github.com/users/Sergeygezha/orgs","repos_url":"https://api.github.com/users/Sergeygezha/repos","events_url":"https://api.github.com/users/Sergeygezha/events{/privacy}","received_events_url":"https://api.github.com/users/Sergeygezha/received_events","type":"User","site_admin":false},"repo":{"id":143772502,"node_id":"MDEwOlJlcG9zaXRvcnkxNDM3NzI1MDI=","name":"190994-sedona","full_name":"Sergeygezha/190994-sedona","owner":{"login":"Sergeygezha","id":41345915,"node_id":"MDQ6VXNlcjQxMzQ1OTE1","avatar_url":"https://avatars2.githubusercontent.com/u/41345915?v=4","gravatar_id":"","url":"https://api.github.com/users/Sergeygezha","html_url":"https://github.com/Sergeygezha","followers_url":"https://api.github.com/users/Sergeygezha/followers","following_url":"https://api.github.com/users/Sergeygezha/following{/other_user}","gists_url":"https://api.github.com/users/Sergeygezha/gists{/gist_id}","starred_url":"https://api.github.com/users/Sergeygezha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sergeygezha/subscriptions","organizations_url":"https://api.github.com/users/Sergeygezha/orgs","repos_url":"https://api.github.com/users/Sergeygezha/repos","events_url":"https://api.github.com/users/Sergeygezha/events{/privacy}","received_events_url":"https://api.github.com/users/Sergeygezha/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Sergeygezha/190994-sedona","description":"Sergey Gezha","fork":true,"url":"https://api.github.com/repos/Sergeygezha/190994-sedona","forks_url":"https://api.github.com/repos/Sergeygezha/190994-sedona/forks","keys_url":"https://api.github.com/repos/Sergeygezha/190994-sedona/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Sergeygezha/190994-sedona/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Sergeygezha/190994-sedona/teams","hooks_url":"https://api.github.com/repos/Sergeygezha/190994-sedona/hooks","issue_events_url":"https://api.github.com/repos/Sergeygezha/190994-sedona/issues/events{/number}","events_url":"https://api.github.com/repos/Sergeygezha/190994-sedona/events","assignees_url":"https://api.github.com/repos/Sergeygezha/190994-sedona/assignees{/user}","branches_url":"https://api.github.com/repos/Sergeygezha/190994-sedona/branches{/branch}","tags_url":"https://api.github.com/repos/Sergeygezha/190994-sedona/tags","blobs_url":"https://api.github.com/repos/Sergeygezha/190994-sedona/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Sergeygezha/190994-sedona/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Sergeygezha/190994-sedona/git/refs{/sha}","trees_url":"https://api.github.com/repos/Sergeygezha/190994-sedona/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Sergeygezha/190994-sedona/statuses/{sha}","languages_url":"https://api.github.com/repos/Sergeygezha/190994-sedona/languages","stargazers_url":"https://api.github.com/repos/Sergeygezha/190994-sedona/stargazers","contributors_url":"https://api.github.com/repos/Sergeygezha/190994-sedona/contributors","subscribers_url":"https://api.github.com/repos/Sergeygezha/190994-sedona/subscribers","subscription_url":"https://api.github.com/repos/Sergeygezha/190994-sedona/subscription","commits_url":"https://api.github.com/repos/Sergeygezha/190994-sedona/commits{/sha}","git_commits_url":"https://api.github.com/repos/Sergeygezha/190994-sedona/git/commits{/sha}","comments_url":"https://api.github.com/repos/Sergeygezha/190994-sedona/comments{/number}","issue_comment_url":"https://api.github.com/repos/Sergeygezha/190994-sedona/issues/comments{/number}","contents_url":"https://api.github.com/repos/Sergeygezha/190994-sedona/contents/{+path}","compare_url":"https://api.github.com/repos/Sergeygezha/190994-sedona/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Sergeygezha/190994-sedona/merges","archive_url":"https://api.github.com/repos/Sergeygezha/190994-sedona/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Sergeygezha/190994-sedona/downloads","issues_url":"https://api.github.com/repos/Sergeygezha/190994-sedona/issues{/number}","pulls_url":"https://api.github.com/repos/Sergeygezha/190994-sedona/pulls{/number}","milestones_url":"https://api.github.com/repos/Sergeygezha/190994-sedona/milestones{/number}","notifications_url":"https://api.github.com/repos/Sergeygezha/190994-sedona/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Sergeygezha/190994-sedona/labels{/name}","releases_url":"https://api.github.com/repos/Sergeygezha/190994-sedona/releases{/id}","deployments_url":"https://api.github.com/repos/Sergeygezha/190994-sedona/deployments","created_at":"2018-08-06T19:18:36Z","updated_at":"2018-09-02T19:46:16Z","pushed_at":"2018-09-02T19:46:14Z","git_url":"git://github.com/Sergeygezha/190994-sedona.git","ssh_url":"[email protected]:Sergeygezha/190994-sedona.git","clone_url":"https://github.com/Sergeygezha/190994-sedona.git","svn_url":"https://github.com/Sergeygezha/190994-sedona","homepage":null,"size":687,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"htmlacademy-htmlcss:master","ref":"master","sha":"029f2a0385e3546a6f7a9e8e74b843cee6d3336d","user":{"login":"htmlacademy-htmlcss","id":16576942,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NTc2OTQy","avatar_url":"https://avatars3.githubusercontent.com/u/16576942?v=4","gravatar_id":"","url":"https://api.github.com/users/htmlacademy-htmlcss","html_url":"https://github.com/htmlacademy-htmlcss","followers_url":"https://api.github.com/users/htmlacademy-htmlcss/followers","following_url":"https://api.github.com/users/htmlacademy-htmlcss/following{/other_user}","gists_url":"https://api.github.com/users/htmlacademy-htmlcss/gists{/gist_id}","starred_url":"https://api.github.com/users/htmlacademy-htmlcss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/htmlacademy-htmlcss/subscriptions","organizations_url":"https://api.github.com/users/htmlacademy-htmlcss/orgs","repos_url":"https://api.github.com/users/htmlacademy-htmlcss/repos","events_url":"https://api.github.com/users/htmlacademy-htmlcss/events{/privacy}","received_events_url":"https://api.github.com/users/htmlacademy-htmlcss/received_events","type":"Organization","site_admin":false},"repo":{"id":143772412,"node_id":"MDEwOlJlcG9zaXRvcnkxNDM3NzI0MTI=","name":"190994-sedona","full_name":"htmlacademy-htmlcss/190994-sedona","owner":{"login":"htmlacademy-htmlcss","id":16576942,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NTc2OTQy","avatar_url":"https://avatars3.githubusercontent.com/u/16576942?v=4","gravatar_id":"","url":"https://api.github.com/users/htmlacademy-htmlcss","html_url":"https://github.com/htmlacademy-htmlcss","followers_url":"https://api.github.com/users/htmlacademy-htmlcss/followers","following_url":"https://api.github.com/users/htmlacademy-htmlcss/following{/other_user}","gists_url":"https://api.github.com/users/htmlacademy-htmlcss/gists{/gist_id}","starred_url":"https://api.github.com/users/htmlacademy-htmlcss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/htmlacademy-htmlcss/subscriptions","organizations_url":"https://api.github.com/users/htmlacademy-htmlcss/orgs","repos_url":"https://api.github.com/users/htmlacademy-htmlcss/repos","events_url":"https://api.github.com/users/htmlacademy-htmlcss/events{/privacy}","received_events_url":"https://api.github.com/users/htmlacademy-htmlcss/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/htmlacademy-htmlcss/190994-sedona","description":"Sergey Gezha","fork":false,"url":"https://api.github.com/repos/htmlacademy-htmlcss/190994-sedona","forks_url":"https://api.github.com/repos/htmlacademy-htmlcss/190994-sedona/forks","keys_url":"https://api.github.com/repos/htmlacademy-htmlcss/190994-sedona/keys{/key_id}","collaborators_url":"https://api.github.com/repos/htmlacademy-htmlcss/190994-sedona/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/htmlacademy-htmlcss/190994-sedona/teams","hooks_url":"https://api.github.com/repos/htmlacademy-htmlcss/190994-sedona/hooks","issue_events_url":"https://api.github.com/repos/htmlacademy-htmlcss/190994-sedona/issues/events{/number}","events_url":"https://api.github.com/repos/htmlacademy-htmlcss/190994-sedona/events","assignees_url":"https://api.github.com/repos/htmlacademy-htmlcss/190994-sedona/assignees{/user}","branches_url":"https://api.github.com/repos/htmlacademy-htmlcss/190994-sedona/branches{/branch}","tags_url":"https://api.github.com/repos/htmlacademy-htmlcss/190994-sedona/tags","blobs_url":"https://api.github.com/repos/htmlacademy-htmlcss/190994-sedona/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/htmlacademy-htmlcss/190994-sedona/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/htmlacademy-htmlcss/190994-sedona/git/refs{/sha}","trees_url":"https://api.github.com/repos/htmlacademy-htmlcss/190994-sedona/git/trees{/sha}","statuses_url":"https://api.github.com/repos/htmlacademy-htmlcss/190994-sedona/statuses/{sha}","languages_url":"https://api.github.com/repos/htmlacademy-htmlcss/190994-sedona/languages","stargazers_url":"https://api.github.com/repos/htmlacademy-htmlcss/190994-sedona/stargazers","contributors_url":"https://api.github.com/repos/htmlacademy-htmlcss/190994-sedona/contributors","subscribers_url":"https://api.github.com/repos/htmlacademy-htmlcss/190994-sedona/subscribers","subscription_url":"https://api.github.com/repos/htmlacademy-htmlcss/190994-sedona/subscription","commits_url":"https://api.github.com/repos/htmlacademy-htmlcss/190994-sedona/commits{/sha}","git_commits_url":"https://api.github.com/repos/htmlacademy-htmlcss/190994-sedona/git/commits{/sha}","comments_url":"https://api.github.com/repos/htmlacademy-htmlcss/190994-sedona/comments{/number}","issue_comment_url":"https://api.github.com/repos/htmlacademy-htmlcss/190994-sedona/issues/comments{/number}","contents_url":"https://api.github.com/repos/htmlacademy-htmlcss/190994-sedona/contents/{+path}","compare_url":"https://api.github.com/repos/htmlacademy-htmlcss/190994-sedona/compare/{base}...{head}","merges_url":"https://api.github.com/repos/htmlacademy-htmlcss/190994-sedona/merges","archive_url":"https://api.github.com/repos/htmlacademy-htmlcss/190994-sedona/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/htmlacademy-htmlcss/190994-sedona/downloads","issues_url":"https://api.github.com/repos/htmlacademy-htmlcss/190994-sedona/issues{/number}","pulls_url":"https://api.github.com/repos/htmlacademy-htmlcss/190994-sedona/pulls{/number}","milestones_url":"https://api.github.com/repos/htmlacademy-htmlcss/190994-sedona/milestones{/number}","notifications_url":"https://api.github.com/repos/htmlacademy-htmlcss/190994-sedona/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/htmlacademy-htmlcss/190994-sedona/labels{/name}","releases_url":"https://api.github.com/repos/htmlacademy-htmlcss/190994-sedona/releases{/id}","deployments_url":"https://api.github.com/repos/htmlacademy-htmlcss/190994-sedona/deployments","created_at":"2018-08-06T19:17:48Z","updated_at":"2018-08-29T06:15:37Z","pushed_at":"2018-09-02T19:46:34Z","git_url":"git://github.com/htmlacademy-htmlcss/190994-sedona.git","ssh_url":"[email protected]:htmlacademy-htmlcss/190994-sedona.git","clone_url":"https://github.com/htmlacademy-htmlcss/190994-sedona.git","svn_url":"https://github.com/htmlacademy-htmlcss/190994-sedona","homepage":"https://github.com/Sergeygezha/190994-sedona","size":684,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/190994-sedona/pulls/4"},"html":{"href":"https://github.com/htmlacademy-htmlcss/190994-sedona/pull/4"},"issue":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/190994-sedona/issues/4"},"comments":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/190994-sedona/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/190994-sedona/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/190994-sedona/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/190994-sedona/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/190994-sedona/statuses/b035f1419a7d4996260a226c0c4617bc787a3a32"}},"author_association":"CONTRIBUTOR"}} | {
"id": 143772412,
"name": "htmlacademy-htmlcss/190994-sedona",
"url": "https://api.github.com/repos/htmlacademy-htmlcss/190994-sedona"
} | {
"id": 41345915,
"login": "Sergeygezha",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/41345915?",
"url": "https://api.github.com/users/Sergeygezha"
} | {
"id": 16576942,
"login": "htmlacademy-htmlcss",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/16576942?",
"url": "https://api.github.com/orgs/htmlacademy-htmlcss"
} | 2018-09-03T18:17:05 | 8207550800 | {"actor":{"display_login":"Sergeygezha"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/7ninjas/7ninjas-website/pulls/comments/194059090","pull_request_review_id":127132027,"id":194059090,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NDA1OTA5MA==","diff_hunk":"@@ -0,0 +1,54 @@\n+import React from 'react'\n+import { connect } from 'react-redux'\n+import { Field, reduxForm } from 'redux-form'\n+import { email, length, required } from 'redux-form-validators'\n+import Input from 'components/fields/Input/Input'\n+import Textarea from 'components/fields/Textarea/Textarea'\n+import { estimateRequest } from 'modules/estimate'\n+import { ArrowButton } from 'components/Controls/ArrowButton'\n+import c from './ContactForm.module.scss'\n+\n+const ContactForm = ({ handleSubmit, onSubmit, isSubmitting, className }) => (\n+ <form onSubmit={handleSubmit(onSubmit)} className={className}>\n+ <Field\n+ name=\"name\"\n+ placeholder=\"Your name\"\n+ component={Input}\n+ validate={[required({ msg: 'Required.' }), length({ min: 2, msg: 'Please enter at least 2 characters.' })]}\n+ />\n+ <Field\n+ name=\"email\"\n+ placeholder=\"Your e-mail\"\n+ component={Input}\n+ validate={[required({ msg: 'Required.' }), email({ msg: 'Please enter a valid email address.' })]}\n+ />\n+ <Field\n+ name=\"description\"\n+ placeholder=\"Your message\"\n+ component={Textarea}\n+ validate={[\n+ required({ msg: 'Required.' }),\n+ length({\n+ min: 10,\n+ msg: 'Please tell us a bit more, we\\'d love to hear about your project! Please enter at least 10 characters.',\n+ }),\n+ ]}\n+ />\n+\n+ <ArrowButton submitting={isSubmitting} type=\"submit\" className={c.btn}>\n+ Send the message\n+ </ArrowButton>\n+ </form>\n+)\n+\n+export default connect(","path":"src/routes/Home/components/ContactSection/components/ContactForm/ContactForm.js","position":44,"original_position":44,"commit_id":"ca2e0cad69cfe82914d29330a120c34060c373c4","original_commit_id":"ca2e0cad69cfe82914d29330a120c34060c373c4","user":{"login":"ArekRado","id":9938199,"node_id":"MDQ6VXNlcjk5MzgxOTk=","avatar_url":"https://avatars1.githubusercontent.com/u/9938199?v=4","gravatar_id":"","url":"https://api.github.com/users/ArekRado","html_url":"https://github.com/ArekRado","followers_url":"https://api.github.com/users/ArekRado/followers","following_url":"https://api.github.com/users/ArekRado/following{/other_user}","gists_url":"https://api.github.com/users/ArekRado/gists{/gist_id}","starred_url":"https://api.github.com/users/ArekRado/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ArekRado/subscriptions","organizations_url":"https://api.github.com/users/ArekRado/orgs","repos_url":"https://api.github.com/users/ArekRado/repos","events_url":"https://api.github.com/users/ArekRado/events{/privacy}","received_events_url":"https://api.github.com/users/ArekRado/received_events","type":"User","site_admin":false},"body":"no-default","created_at":"2018-06-08T13:35:34Z","updated_at":"2018-06-08T13:47:24Z","html_url":"https://github.com/7ninjas/7ninjas-website/pull/4#discussion_r194059090","pull_request_url":"https://api.github.com/repos/7ninjas/7ninjas-website/pulls/4","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/7ninjas/7ninjas-website/pulls/comments/194059090"},"html":{"href":"https://github.com/7ninjas/7ninjas-website/pull/4#discussion_r194059090"},"pull_request":{"href":"https://api.github.com/repos/7ninjas/7ninjas-website/pulls/4"}}},"pull_request":{"url":"https://api.github.com/repos/7ninjas/7ninjas-website/pulls/4","id":193336568,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzMzM2NTY4","html_url":"https://github.com/7ninjas/7ninjas-website/pull/4","diff_url":"https://github.com/7ninjas/7ninjas-website/pull/4.diff","patch_url":"https://github.com/7ninjas/7ninjas-website/pull/4.patch","issue_url":"https://api.github.com/repos/7ninjas/7ninjas-website/issues/4","number":4,"state":"open","locked":false,"title":"#509 Added home page","user":{"login":"szczepanbarszczowski","id":25323934,"node_id":"MDQ6VXNlcjI1MzIzOTM0","avatar_url":"https://avatars2.githubusercontent.com/u/25323934?v=4","gravatar_id":"","url":"https://api.github.com/users/szczepanbarszczowski","html_url":"https://github.com/szczepanbarszczowski","followers_url":"https://api.github.com/users/szczepanbarszczowski/followers","following_url":"https://api.github.com/users/szczepanbarszczowski/following{/other_user}","gists_url":"https://api.github.com/users/szczepanbarszczowski/gists{/gist_id}","starred_url":"https://api.github.com/users/szczepanbarszczowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/szczepanbarszczowski/subscriptions","organizations_url":"https://api.github.com/users/szczepanbarszczowski/orgs","repos_url":"https://api.github.com/users/szczepanbarszczowski/repos","events_url":"https://api.github.com/users/szczepanbarszczowski/events{/privacy}","received_events_url":"https://api.github.com/users/szczepanbarszczowski/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-06-07T14:14:14Z","updated_at":"2018-06-08T13:47:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6962221f8b9cbd36919bc53adf52e073200009e9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/7ninjas/7ninjas-website/pulls/4/commits","review_comments_url":"https://api.github.com/repos/7ninjas/7ninjas-website/pulls/4/comments","review_comment_url":"https://api.github.com/repos/7ninjas/7ninjas-website/pulls/comments{/number}","comments_url":"https://api.github.com/repos/7ninjas/7ninjas-website/issues/4/comments","statuses_url":"https://api.github.com/repos/7ninjas/7ninjas-website/statuses/ca2e0cad69cfe82914d29330a120c34060c373c4","head":{"label":"7ninjas:feature/#509-home","ref":"feature/#509-home","sha":"ca2e0cad69cfe82914d29330a120c34060c373c4","user":{"login":"7ninjas","id":16597072,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NTk3MDcy","avatar_url":"https://avatars2.githubusercontent.com/u/16597072?v=4","gravatar_id":"","url":"https://api.github.com/users/7ninjas","html_url":"https://github.com/7ninjas","followers_url":"https://api.github.com/users/7ninjas/followers","following_url":"https://api.github.com/users/7ninjas/following{/other_user}","gists_url":"https://api.github.com/users/7ninjas/gists{/gist_id}","starred_url":"https://api.github.com/users/7ninjas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/7ninjas/subscriptions","organizations_url":"https://api.github.com/users/7ninjas/orgs","repos_url":"https://api.github.com/users/7ninjas/repos","events_url":"https://api.github.com/users/7ninjas/events{/privacy}","received_events_url":"https://api.github.com/users/7ninjas/received_events","type":"Organization","site_admin":false},"repo":{"id":135990770,"node_id":"MDEwOlJlcG9zaXRvcnkxMzU5OTA3NzA=","name":"7ninjas-website","full_name":"7ninjas/7ninjas-website","owner":{"login":"7ninjas","id":16597072,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NTk3MDcy","avatar_url":"https://avatars2.githubusercontent.com/u/16597072?v=4","gravatar_id":"","url":"https://api.github.com/users/7ninjas","html_url":"https://github.com/7ninjas","followers_url":"https://api.github.com/users/7ninjas/followers","following_url":"https://api.github.com/users/7ninjas/following{/other_user}","gists_url":"https://api.github.com/users/7ninjas/gists{/gist_id}","starred_url":"https://api.github.com/users/7ninjas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/7ninjas/subscriptions","organizations_url":"https://api.github.com/users/7ninjas/orgs","repos_url":"https://api.github.com/users/7ninjas/repos","events_url":"https://api.github.com/users/7ninjas/events{/privacy}","received_events_url":"https://api.github.com/users/7ninjas/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/7ninjas/7ninjas-website","description":null,"fork":false,"url":"https://api.github.com/repos/7ninjas/7ninjas-website","forks_url":"https://api.github.com/repos/7ninjas/7ninjas-website/forks","keys_url":"https://api.github.com/repos/7ninjas/7ninjas-website/keys{/key_id}","collaborators_url":"https://api.github.com/repos/7ninjas/7ninjas-website/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/7ninjas/7ninjas-website/teams","hooks_url":"https://api.github.com/repos/7ninjas/7ninjas-website/hooks","issue_events_url":"https://api.github.com/repos/7ninjas/7ninjas-website/issues/events{/number}","events_url":"https://api.github.com/repos/7ninjas/7ninjas-website/events","assignees_url":"https://api.github.com/repos/7ninjas/7ninjas-website/assignees{/user}","branches_url":"https://api.github.com/repos/7ninjas/7ninjas-website/branches{/branch}","tags_url":"https://api.github.com/repos/7ninjas/7ninjas-website/tags","blobs_url":"https://api.github.com/repos/7ninjas/7ninjas-website/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/7ninjas/7ninjas-website/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/7ninjas/7ninjas-website/git/refs{/sha}","trees_url":"https://api.github.com/repos/7ninjas/7ninjas-website/git/trees{/sha}","statuses_url":"https://api.github.com/repos/7ninjas/7ninjas-website/statuses/{sha}","languages_url":"https://api.github.com/repos/7ninjas/7ninjas-website/languages","stargazers_url":"https://api.github.com/repos/7ninjas/7ninjas-website/stargazers","contributors_url":"https://api.github.com/repos/7ninjas/7ninjas-website/contributors","subscribers_url":"https://api.github.com/repos/7ninjas/7ninjas-website/subscribers","subscription_url":"https://api.github.com/repos/7ninjas/7ninjas-website/subscription","commits_url":"https://api.github.com/repos/7ninjas/7ninjas-website/commits{/sha}","git_commits_url":"https://api.github.com/repos/7ninjas/7ninjas-website/git/commits{/sha}","comments_url":"https://api.github.com/repos/7ninjas/7ninjas-website/comments{/number}","issue_comment_url":"https://api.github.com/repos/7ninjas/7ninjas-website/issues/comments{/number}","contents_url":"https://api.github.com/repos/7ninjas/7ninjas-website/contents/{+path}","compare_url":"https://api.github.com/repos/7ninjas/7ninjas-website/compare/{base}...{head}","merges_url":"https://api.github.com/repos/7ninjas/7ninjas-website/merges","archive_url":"https://api.github.com/repos/7ninjas/7ninjas-website/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/7ninjas/7ninjas-website/downloads","issues_url":"https://api.github.com/repos/7ninjas/7ninjas-website/issues{/number}","pulls_url":"https://api.github.com/repos/7ninjas/7ninjas-website/pulls{/number}","milestones_url":"https://api.github.com/repos/7ninjas/7ninjas-website/milestones{/number}","notifications_url":"https://api.github.com/repos/7ninjas/7ninjas-website/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/7ninjas/7ninjas-website/labels{/name}","releases_url":"https://api.github.com/repos/7ninjas/7ninjas-website/releases{/id}","deployments_url":"https://api.github.com/repos/7ninjas/7ninjas-website/deployments","created_at":"2018-06-04T07:58:42Z","updated_at":"2018-06-06T08:32:24Z","pushed_at":"2018-06-08T11:22:32Z","git_url":"git://github.com/7ninjas/7ninjas-website.git","ssh_url":"[email protected]:7ninjas/7ninjas-website.git","clone_url":"https://github.com/7ninjas/7ninjas-website.git","svn_url":"https://github.com/7ninjas/7ninjas-website","homepage":null,"size":46894,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":4,"watchers":3,"default_branch":"develop"}},"base":{"label":"7ninjas:develop","ref":"develop","sha":"235b3a93799ae43d686f31121f9ee552dbafb7a2","user":{"login":"7ninjas","id":16597072,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NTk3MDcy","avatar_url":"https://avatars2.githubusercontent.com/u/16597072?v=4","gravatar_id":"","url":"https://api.github.com/users/7ninjas","html_url":"https://github.com/7ninjas","followers_url":"https://api.github.com/users/7ninjas/followers","following_url":"https://api.github.com/users/7ninjas/following{/other_user}","gists_url":"https://api.github.com/users/7ninjas/gists{/gist_id}","starred_url":"https://api.github.com/users/7ninjas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/7ninjas/subscriptions","organizations_url":"https://api.github.com/users/7ninjas/orgs","repos_url":"https://api.github.com/users/7ninjas/repos","events_url":"https://api.github.com/users/7ninjas/events{/privacy}","received_events_url":"https://api.github.com/users/7ninjas/received_events","type":"Organization","site_admin":false},"repo":{"id":135990770,"node_id":"MDEwOlJlcG9zaXRvcnkxMzU5OTA3NzA=","name":"7ninjas-website","full_name":"7ninjas/7ninjas-website","owner":{"login":"7ninjas","id":16597072,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NTk3MDcy","avatar_url":"https://avatars2.githubusercontent.com/u/16597072?v=4","gravatar_id":"","url":"https://api.github.com/users/7ninjas","html_url":"https://github.com/7ninjas","followers_url":"https://api.github.com/users/7ninjas/followers","following_url":"https://api.github.com/users/7ninjas/following{/other_user}","gists_url":"https://api.github.com/users/7ninjas/gists{/gist_id}","starred_url":"https://api.github.com/users/7ninjas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/7ninjas/subscriptions","organizations_url":"https://api.github.com/users/7ninjas/orgs","repos_url":"https://api.github.com/users/7ninjas/repos","events_url":"https://api.github.com/users/7ninjas/events{/privacy}","received_events_url":"https://api.github.com/users/7ninjas/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/7ninjas/7ninjas-website","description":null,"fork":false,"url":"https://api.github.com/repos/7ninjas/7ninjas-website","forks_url":"https://api.github.com/repos/7ninjas/7ninjas-website/forks","keys_url":"https://api.github.com/repos/7ninjas/7ninjas-website/keys{/key_id}","collaborators_url":"https://api.github.com/repos/7ninjas/7ninjas-website/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/7ninjas/7ninjas-website/teams","hooks_url":"https://api.github.com/repos/7ninjas/7ninjas-website/hooks","issue_events_url":"https://api.github.com/repos/7ninjas/7ninjas-website/issues/events{/number}","events_url":"https://api.github.com/repos/7ninjas/7ninjas-website/events","assignees_url":"https://api.github.com/repos/7ninjas/7ninjas-website/assignees{/user}","branches_url":"https://api.github.com/repos/7ninjas/7ninjas-website/branches{/branch}","tags_url":"https://api.github.com/repos/7ninjas/7ninjas-website/tags","blobs_url":"https://api.github.com/repos/7ninjas/7ninjas-website/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/7ninjas/7ninjas-website/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/7ninjas/7ninjas-website/git/refs{/sha}","trees_url":"https://api.github.com/repos/7ninjas/7ninjas-website/git/trees{/sha}","statuses_url":"https://api.github.com/repos/7ninjas/7ninjas-website/statuses/{sha}","languages_url":"https://api.github.com/repos/7ninjas/7ninjas-website/languages","stargazers_url":"https://api.github.com/repos/7ninjas/7ninjas-website/stargazers","contributors_url":"https://api.github.com/repos/7ninjas/7ninjas-website/contributors","subscribers_url":"https://api.github.com/repos/7ninjas/7ninjas-website/subscribers","subscription_url":"https://api.github.com/repos/7ninjas/7ninjas-website/subscription","commits_url":"https://api.github.com/repos/7ninjas/7ninjas-website/commits{/sha}","git_commits_url":"https://api.github.com/repos/7ninjas/7ninjas-website/git/commits{/sha}","comments_url":"https://api.github.com/repos/7ninjas/7ninjas-website/comments{/number}","issue_comment_url":"https://api.github.com/repos/7ninjas/7ninjas-website/issues/comments{/number}","contents_url":"https://api.github.com/repos/7ninjas/7ninjas-website/contents/{+path}","compare_url":"https://api.github.com/repos/7ninjas/7ninjas-website/compare/{base}...{head}","merges_url":"https://api.github.com/repos/7ninjas/7ninjas-website/merges","archive_url":"https://api.github.com/repos/7ninjas/7ninjas-website/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/7ninjas/7ninjas-website/downloads","issues_url":"https://api.github.com/repos/7ninjas/7ninjas-website/issues{/number}","pulls_url":"https://api.github.com/repos/7ninjas/7ninjas-website/pulls{/number}","milestones_url":"https://api.github.com/repos/7ninjas/7ninjas-website/milestones{/number}","notifications_url":"https://api.github.com/repos/7ninjas/7ninjas-website/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/7ninjas/7ninjas-website/labels{/name}","releases_url":"https://api.github.com/repos/7ninjas/7ninjas-website/releases{/id}","deployments_url":"https://api.github.com/repos/7ninjas/7ninjas-website/deployments","created_at":"2018-06-04T07:58:42Z","updated_at":"2018-06-06T08:32:24Z","pushed_at":"2018-06-08T11:22:32Z","git_url":"git://github.com/7ninjas/7ninjas-website.git","ssh_url":"[email protected]:7ninjas/7ninjas-website.git","clone_url":"https://github.com/7ninjas/7ninjas-website.git","svn_url":"https://github.com/7ninjas/7ninjas-website","homepage":null,"size":46894,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":4,"watchers":3,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/7ninjas/7ninjas-website/pulls/4"},"html":{"href":"https://github.com/7ninjas/7ninjas-website/pull/4"},"issue":{"href":"https://api.github.com/repos/7ninjas/7ninjas-website/issues/4"},"comments":{"href":"https://api.github.com/repos/7ninjas/7ninjas-website/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/7ninjas/7ninjas-website/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/7ninjas/7ninjas-website/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/7ninjas/7ninjas-website/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/7ninjas/7ninjas-website/statuses/ca2e0cad69cfe82914d29330a120c34060c373c4"}},"author_association":"CONTRIBUTOR"}} | {
"id": 135990770,
"name": "7ninjas/7ninjas-website",
"url": "https://api.github.com/repos/7ninjas/7ninjas-website"
} | {
"id": 9938199,
"login": "ArekRado",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9938199?",
"url": "https://api.github.com/users/ArekRado"
} | {
"id": 16597072,
"login": "7ninjas",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/16597072?",
"url": "https://api.github.com/orgs/7ninjas"
} | 2018-06-08T13:35:34 | 7797074958 | {"actor":{"display_login":"ArekRado"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/7ninjas/7ninjas-website/pulls/comments/207870097","pull_request_review_id":143565768,"id":207870097,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNzg3MDA5Nw==","diff_hunk":"@@ -0,0 +1,16 @@\n+export const getURL = link => {\n+ const URL = Cypress.env(link)\n+ const host = Cypress.env('HOST')\n+ const port = Cypress.env('PORT')\n+\n+ if (link != 'HOME_URL' && !URL) {\n+ throw new Error('No such link found! Look into cypress.json to find a correct link!')\n+ }\n+ if (URL.match(/@|https|http/)) {\n+ return URL\n+ }\n+ if (host.match(/localhost/)) {\n+ return `http://${host}:${port}/${URL}`","path":"cypress/helper.js","position":13,"original_position":13,"commit_id":"46d68bd555b297dfdcb2fecad98bfb8b5e2da34a","original_commit_id":"46d68bd555b297dfdcb2fecad98bfb8b5e2da34a","user":{"login":"MykolaRudnytskyi","id":27192591,"node_id":"MDQ6VXNlcjI3MTkyNTkx","avatar_url":"https://avatars3.githubusercontent.com/u/27192591?v=4","gravatar_id":"","url":"https://api.github.com/users/MykolaRudnytskyi","html_url":"https://github.com/MykolaRudnytskyi","followers_url":"https://api.github.com/users/MykolaRudnytskyi/followers","following_url":"https://api.github.com/users/MykolaRudnytskyi/following{/other_user}","gists_url":"https://api.github.com/users/MykolaRudnytskyi/gists{/gist_id}","starred_url":"https://api.github.com/users/MykolaRudnytskyi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MykolaRudnytskyi/subscriptions","organizations_url":"https://api.github.com/users/MykolaRudnytskyi/orgs","repos_url":"https://api.github.com/users/MykolaRudnytskyi/repos","events_url":"https://api.github.com/users/MykolaRudnytskyi/events{/privacy}","received_events_url":"https://api.github.com/users/MykolaRudnytskyi/received_events","type":"User","site_admin":false},"body":"@hypeofpipe no, I think that you should use another validator for this.","created_at":"2018-08-06T12:16:28Z","updated_at":"2018-08-06T12:16:28Z","html_url":"https://github.com/7ninjas/7ninjas-website/pull/170#discussion_r207870097","pull_request_url":"https://api.github.com/repos/7ninjas/7ninjas-website/pulls/170","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/7ninjas/7ninjas-website/pulls/comments/207870097"},"html":{"href":"https://github.com/7ninjas/7ninjas-website/pull/170#discussion_r207870097"},"pull_request":{"href":"https://api.github.com/repos/7ninjas/7ninjas-website/pulls/170"}},"in_reply_to_id":207864785},"pull_request":{"url":"https://api.github.com/repos/7ninjas/7ninjas-website/pulls/170","id":206367597,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2MzY3NTk3","html_url":"https://github.com/7ninjas/7ninjas-website/pull/170","diff_url":"https://github.com/7ninjas/7ninjas-website/pull/170.diff","patch_url":"https://github.com/7ninjas/7ninjas-website/pull/170.patch","issue_url":"https://api.github.com/repos/7ninjas/7ninjas-website/issues/170","number":170,"state":"open","locked":false,"title":"Reorganised the structure of tests","user":{"login":"hypeofpipe","id":14982064,"node_id":"MDQ6VXNlcjE0OTgyMDY0","avatar_url":"https://avatars3.githubusercontent.com/u/14982064?v=4","gravatar_id":"","url":"https://api.github.com/users/hypeofpipe","html_url":"https://github.com/hypeofpipe","followers_url":"https://api.github.com/users/hypeofpipe/followers","following_url":"https://api.github.com/users/hypeofpipe/following{/other_user}","gists_url":"https://api.github.com/users/hypeofpipe/gists{/gist_id}","starred_url":"https://api.github.com/users/hypeofpipe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hypeofpipe/subscriptions","organizations_url":"https://api.github.com/users/hypeofpipe/orgs","repos_url":"https://api.github.com/users/hypeofpipe/repos","events_url":"https://api.github.com/users/hypeofpipe/events{/privacy}","received_events_url":"https://api.github.com/users/hypeofpipe/received_events","type":"User","site_admin":false},"body":"- Refactored the project structure: now your data.js wouldn't be called as test, so it will save time of CI;\n- Refactored URL's: now you can provide your own URL (e.g., it is necessary for testing of staging, production, etc.);","created_at":"2018-08-06T11:21:54Z","updated_at":"2018-08-06T12:16:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"583be39a6a14744b56fbe5b77fbec9946a7c8adc","assignee":{"login":"hypeofpipe","id":14982064,"node_id":"MDQ6VXNlcjE0OTgyMDY0","avatar_url":"https://avatars3.githubusercontent.com/u/14982064?v=4","gravatar_id":"","url":"https://api.github.com/users/hypeofpipe","html_url":"https://github.com/hypeofpipe","followers_url":"https://api.github.com/users/hypeofpipe/followers","following_url":"https://api.github.com/users/hypeofpipe/following{/other_user}","gists_url":"https://api.github.com/users/hypeofpipe/gists{/gist_id}","starred_url":"https://api.github.com/users/hypeofpipe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hypeofpipe/subscriptions","organizations_url":"https://api.github.com/users/hypeofpipe/orgs","repos_url":"https://api.github.com/users/hypeofpipe/repos","events_url":"https://api.github.com/users/hypeofpipe/events{/privacy}","received_events_url":"https://api.github.com/users/hypeofpipe/received_events","type":"User","site_admin":false},"assignees":[{"login":"hypeofpipe","id":14982064,"node_id":"MDQ6VXNlcjE0OTgyMDY0","avatar_url":"https://avatars3.githubusercontent.com/u/14982064?v=4","gravatar_id":"","url":"https://api.github.com/users/hypeofpipe","html_url":"https://github.com/hypeofpipe","followers_url":"https://api.github.com/users/hypeofpipe/followers","following_url":"https://api.github.com/users/hypeofpipe/following{/other_user}","gists_url":"https://api.github.com/users/hypeofpipe/gists{/gist_id}","starred_url":"https://api.github.com/users/hypeofpipe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hypeofpipe/subscriptions","organizations_url":"https://api.github.com/users/hypeofpipe/orgs","repos_url":"https://api.github.com/users/hypeofpipe/repos","events_url":"https://api.github.com/users/hypeofpipe/events{/privacy}","received_events_url":"https://api.github.com/users/hypeofpipe/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":997247440,"node_id":"MDU6TGFiZWw5OTcyNDc0NDA=","url":"https://api.github.com/repos/7ninjas/7ninjas-website/labels/e2e%20tests","name":"e2e tests","color":"006b75","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/7ninjas/7ninjas-website/pulls/170/commits","review_comments_url":"https://api.github.com/repos/7ninjas/7ninjas-website/pulls/170/comments","review_comment_url":"https://api.github.com/repos/7ninjas/7ninjas-website/pulls/comments{/number}","comments_url":"https://api.github.com/repos/7ninjas/7ninjas-website/issues/170/comments","statuses_url":"https://api.github.com/repos/7ninjas/7ninjas-website/statuses/46d68bd555b297dfdcb2fecad98bfb8b5e2da34a","head":{"label":"7ninjas:feature/e2e-completion","ref":"feature/e2e-completion","sha":"46d68bd555b297dfdcb2fecad98bfb8b5e2da34a","user":{"login":"7ninjas","id":16597072,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NTk3MDcy","avatar_url":"https://avatars2.githubusercontent.com/u/16597072?v=4","gravatar_id":"","url":"https://api.github.com/users/7ninjas","html_url":"https://github.com/7ninjas","followers_url":"https://api.github.com/users/7ninjas/followers","following_url":"https://api.github.com/users/7ninjas/following{/other_user}","gists_url":"https://api.github.com/users/7ninjas/gists{/gist_id}","starred_url":"https://api.github.com/users/7ninjas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/7ninjas/subscriptions","organizations_url":"https://api.github.com/users/7ninjas/orgs","repos_url":"https://api.github.com/users/7ninjas/repos","events_url":"https://api.github.com/users/7ninjas/events{/privacy}","received_events_url":"https://api.github.com/users/7ninjas/received_events","type":"Organization","site_admin":false},"repo":{"id":135990770,"node_id":"MDEwOlJlcG9zaXRvcnkxMzU5OTA3NzA=","name":"7ninjas-website","full_name":"7ninjas/7ninjas-website","owner":{"login":"7ninjas","id":16597072,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NTk3MDcy","avatar_url":"https://avatars2.githubusercontent.com/u/16597072?v=4","gravatar_id":"","url":"https://api.github.com/users/7ninjas","html_url":"https://github.com/7ninjas","followers_url":"https://api.github.com/users/7ninjas/followers","following_url":"https://api.github.com/users/7ninjas/following{/other_user}","gists_url":"https://api.github.com/users/7ninjas/gists{/gist_id}","starred_url":"https://api.github.com/users/7ninjas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/7ninjas/subscriptions","organizations_url":"https://api.github.com/users/7ninjas/orgs","repos_url":"https://api.github.com/users/7ninjas/repos","events_url":"https://api.github.com/users/7ninjas/events{/privacy}","received_events_url":"https://api.github.com/users/7ninjas/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/7ninjas/7ninjas-website","description":null,"fork":false,"url":"https://api.github.com/repos/7ninjas/7ninjas-website","forks_url":"https://api.github.com/repos/7ninjas/7ninjas-website/forks","keys_url":"https://api.github.com/repos/7ninjas/7ninjas-website/keys{/key_id}","collaborators_url":"https://api.github.com/repos/7ninjas/7ninjas-website/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/7ninjas/7ninjas-website/teams","hooks_url":"https://api.github.com/repos/7ninjas/7ninjas-website/hooks","issue_events_url":"https://api.github.com/repos/7ninjas/7ninjas-website/issues/events{/number}","events_url":"https://api.github.com/repos/7ninjas/7ninjas-website/events","assignees_url":"https://api.github.com/repos/7ninjas/7ninjas-website/assignees{/user}","branches_url":"https://api.github.com/repos/7ninjas/7ninjas-website/branches{/branch}","tags_url":"https://api.github.com/repos/7ninjas/7ninjas-website/tags","blobs_url":"https://api.github.com/repos/7ninjas/7ninjas-website/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/7ninjas/7ninjas-website/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/7ninjas/7ninjas-website/git/refs{/sha}","trees_url":"https://api.github.com/repos/7ninjas/7ninjas-website/git/trees{/sha}","statuses_url":"https://api.github.com/repos/7ninjas/7ninjas-website/statuses/{sha}","languages_url":"https://api.github.com/repos/7ninjas/7ninjas-website/languages","stargazers_url":"https://api.github.com/repos/7ninjas/7ninjas-website/stargazers","contributors_url":"https://api.github.com/repos/7ninjas/7ninjas-website/contributors","subscribers_url":"https://api.github.com/repos/7ninjas/7ninjas-website/subscribers","subscription_url":"https://api.github.com/repos/7ninjas/7ninjas-website/subscription","commits_url":"https://api.github.com/repos/7ninjas/7ninjas-website/commits{/sha}","git_commits_url":"https://api.github.com/repos/7ninjas/7ninjas-website/git/commits{/sha}","comments_url":"https://api.github.com/repos/7ninjas/7ninjas-website/comments{/number}","issue_comment_url":"https://api.github.com/repos/7ninjas/7ninjas-website/issues/comments{/number}","contents_url":"https://api.github.com/repos/7ninjas/7ninjas-website/contents/{+path}","compare_url":"https://api.github.com/repos/7ninjas/7ninjas-website/compare/{base}...{head}","merges_url":"https://api.github.com/repos/7ninjas/7ninjas-website/merges","archive_url":"https://api.github.com/repos/7ninjas/7ninjas-website/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/7ninjas/7ninjas-website/downloads","issues_url":"https://api.github.com/repos/7ninjas/7ninjas-website/issues{/number}","pulls_url":"https://api.github.com/repos/7ninjas/7ninjas-website/pulls{/number}","milestones_url":"https://api.github.com/repos/7ninjas/7ninjas-website/milestones{/number}","notifications_url":"https://api.github.com/repos/7ninjas/7ninjas-website/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/7ninjas/7ninjas-website/labels{/name}","releases_url":"https://api.github.com/repos/7ninjas/7ninjas-website/releases{/id}","deployments_url":"https://api.github.com/repos/7ninjas/7ninjas-website/deployments","created_at":"2018-06-04T07:58:42Z","updated_at":"2018-08-06T07:59:48Z","pushed_at":"2018-08-06T11:21:55Z","git_url":"git://github.com/7ninjas/7ninjas-website.git","ssh_url":"[email protected]:7ninjas/7ninjas-website.git","clone_url":"https://github.com/7ninjas/7ninjas-website.git","svn_url":"https://github.com/7ninjas/7ninjas-website","homepage":null,"size":185123,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":3,"watchers":4,"default_branch":"develop"}},"base":{"label":"7ninjas:develop","ref":"develop","sha":"e5688df5d8fd065436bc4ad1a4d5d72aaa67151d","user":{"login":"7ninjas","id":16597072,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NTk3MDcy","avatar_url":"https://avatars2.githubusercontent.com/u/16597072?v=4","gravatar_id":"","url":"https://api.github.com/users/7ninjas","html_url":"https://github.com/7ninjas","followers_url":"https://api.github.com/users/7ninjas/followers","following_url":"https://api.github.com/users/7ninjas/following{/other_user}","gists_url":"https://api.github.com/users/7ninjas/gists{/gist_id}","starred_url":"https://api.github.com/users/7ninjas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/7ninjas/subscriptions","organizations_url":"https://api.github.com/users/7ninjas/orgs","repos_url":"https://api.github.com/users/7ninjas/repos","events_url":"https://api.github.com/users/7ninjas/events{/privacy}","received_events_url":"https://api.github.com/users/7ninjas/received_events","type":"Organization","site_admin":false},"repo":{"id":135990770,"node_id":"MDEwOlJlcG9zaXRvcnkxMzU5OTA3NzA=","name":"7ninjas-website","full_name":"7ninjas/7ninjas-website","owner":{"login":"7ninjas","id":16597072,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NTk3MDcy","avatar_url":"https://avatars2.githubusercontent.com/u/16597072?v=4","gravatar_id":"","url":"https://api.github.com/users/7ninjas","html_url":"https://github.com/7ninjas","followers_url":"https://api.github.com/users/7ninjas/followers","following_url":"https://api.github.com/users/7ninjas/following{/other_user}","gists_url":"https://api.github.com/users/7ninjas/gists{/gist_id}","starred_url":"https://api.github.com/users/7ninjas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/7ninjas/subscriptions","organizations_url":"https://api.github.com/users/7ninjas/orgs","repos_url":"https://api.github.com/users/7ninjas/repos","events_url":"https://api.github.com/users/7ninjas/events{/privacy}","received_events_url":"https://api.github.com/users/7ninjas/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/7ninjas/7ninjas-website","description":null,"fork":false,"url":"https://api.github.com/repos/7ninjas/7ninjas-website","forks_url":"https://api.github.com/repos/7ninjas/7ninjas-website/forks","keys_url":"https://api.github.com/repos/7ninjas/7ninjas-website/keys{/key_id}","collaborators_url":"https://api.github.com/repos/7ninjas/7ninjas-website/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/7ninjas/7ninjas-website/teams","hooks_url":"https://api.github.com/repos/7ninjas/7ninjas-website/hooks","issue_events_url":"https://api.github.com/repos/7ninjas/7ninjas-website/issues/events{/number}","events_url":"https://api.github.com/repos/7ninjas/7ninjas-website/events","assignees_url":"https://api.github.com/repos/7ninjas/7ninjas-website/assignees{/user}","branches_url":"https://api.github.com/repos/7ninjas/7ninjas-website/branches{/branch}","tags_url":"https://api.github.com/repos/7ninjas/7ninjas-website/tags","blobs_url":"https://api.github.com/repos/7ninjas/7ninjas-website/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/7ninjas/7ninjas-website/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/7ninjas/7ninjas-website/git/refs{/sha}","trees_url":"https://api.github.com/repos/7ninjas/7ninjas-website/git/trees{/sha}","statuses_url":"https://api.github.com/repos/7ninjas/7ninjas-website/statuses/{sha}","languages_url":"https://api.github.com/repos/7ninjas/7ninjas-website/languages","stargazers_url":"https://api.github.com/repos/7ninjas/7ninjas-website/stargazers","contributors_url":"https://api.github.com/repos/7ninjas/7ninjas-website/contributors","subscribers_url":"https://api.github.com/repos/7ninjas/7ninjas-website/subscribers","subscription_url":"https://api.github.com/repos/7ninjas/7ninjas-website/subscription","commits_url":"https://api.github.com/repos/7ninjas/7ninjas-website/commits{/sha}","git_commits_url":"https://api.github.com/repos/7ninjas/7ninjas-website/git/commits{/sha}","comments_url":"https://api.github.com/repos/7ninjas/7ninjas-website/comments{/number}","issue_comment_url":"https://api.github.com/repos/7ninjas/7ninjas-website/issues/comments{/number}","contents_url":"https://api.github.com/repos/7ninjas/7ninjas-website/contents/{+path}","compare_url":"https://api.github.com/repos/7ninjas/7ninjas-website/compare/{base}...{head}","merges_url":"https://api.github.com/repos/7ninjas/7ninjas-website/merges","archive_url":"https://api.github.com/repos/7ninjas/7ninjas-website/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/7ninjas/7ninjas-website/downloads","issues_url":"https://api.github.com/repos/7ninjas/7ninjas-website/issues{/number}","pulls_url":"https://api.github.com/repos/7ninjas/7ninjas-website/pulls{/number}","milestones_url":"https://api.github.com/repos/7ninjas/7ninjas-website/milestones{/number}","notifications_url":"https://api.github.com/repos/7ninjas/7ninjas-website/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/7ninjas/7ninjas-website/labels{/name}","releases_url":"https://api.github.com/repos/7ninjas/7ninjas-website/releases{/id}","deployments_url":"https://api.github.com/repos/7ninjas/7ninjas-website/deployments","created_at":"2018-06-04T07:58:42Z","updated_at":"2018-08-06T07:59:48Z","pushed_at":"2018-08-06T11:21:55Z","git_url":"git://github.com/7ninjas/7ninjas-website.git","ssh_url":"[email protected]:7ninjas/7ninjas-website.git","clone_url":"https://github.com/7ninjas/7ninjas-website.git","svn_url":"https://github.com/7ninjas/7ninjas-website","homepage":null,"size":185123,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":3,"watchers":4,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/7ninjas/7ninjas-website/pulls/170"},"html":{"href":"https://github.com/7ninjas/7ninjas-website/pull/170"},"issue":{"href":"https://api.github.com/repos/7ninjas/7ninjas-website/issues/170"},"comments":{"href":"https://api.github.com/repos/7ninjas/7ninjas-website/issues/170/comments"},"review_comments":{"href":"https://api.github.com/repos/7ninjas/7ninjas-website/pulls/170/comments"},"review_comment":{"href":"https://api.github.com/repos/7ninjas/7ninjas-website/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/7ninjas/7ninjas-website/pulls/170/commits"},"statuses":{"href":"https://api.github.com/repos/7ninjas/7ninjas-website/statuses/46d68bd555b297dfdcb2fecad98bfb8b5e2da34a"}},"author_association":"COLLABORATOR"}} | {
"id": 135990770,
"name": "7ninjas/7ninjas-website",
"url": "https://api.github.com/repos/7ninjas/7ninjas-website"
} | {
"id": 27192591,
"login": "MykolaRudnytskyi",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/27192591?",
"url": "https://api.github.com/users/MykolaRudnytskyi"
} | {
"id": 16597072,
"login": "7ninjas",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/16597072?",
"url": "https://api.github.com/orgs/7ninjas"
} | 2018-08-06T12:16:28 | 8071150157 | {"actor":{"display_login":"MykolaRudnytskyi"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/LiskHQ/lisk-hub/pulls/comments/185738423","pull_request_review_id":117186196,"id":185738423,"diff_hunk":"@@ -82,6 +83,16 @@ class SendWritable extends React.Component {\n <h2>{this.props.t('Transfer')}</h2>\n <span className={`${styles.subTitle} ${styles.transfer}`}>{this.props.t('Quickly send and request LSK token')}</span>\n </header>\n+\n+ <div className={`${grid.row} ${styles.tab} `}>\n+ <div className={`${grid['col-xs-6']} ${styles.tabActive} send-tab`}>\n+ {this.props.t('Send')}\n+ </div>\n+ <div className={`${grid['col-xs-6']} ${styles.tabInactive} request-tab`} onClick={() => { this.props.setTabSend(false); }}>\n+ {this.props.t('Request')}\n+ </div>\n+ </div>","path":"src/components/sendWritable/send.js","position":18,"original_position":18,"commit_id":"9dd1e670bc5a30339794b26e15a6250964477039","original_commit_id":"9dd1e670bc5a30339794b26e15a6250964477039","user":{"login":"slaweet","id":1254342,"avatar_url":"https://avatars0.githubusercontent.com/u/1254342?v=4","gravatar_id":"","url":"https://api.github.com/users/slaweet","html_url":"https://github.com/slaweet","followers_url":"https://api.github.com/users/slaweet/followers","following_url":"https://api.github.com/users/slaweet/following{/other_user}","gists_url":"https://api.github.com/users/slaweet/gists{/gist_id}","starred_url":"https://api.github.com/users/slaweet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slaweet/subscriptions","organizations_url":"https://api.github.com/users/slaweet/orgs","repos_url":"https://api.github.com/users/slaweet/repos","events_url":"https://api.github.com/users/slaweet/events{/privacy}","received_events_url":"https://api.github.com/users/slaweet/received_events","type":"User","site_admin":false},"body":"The tab switcher is duplicated in send and receive. Should be a separate component with own CSS.","created_at":"2018-05-03T09:17:18Z","updated_at":"2018-05-03T09:17:31Z","html_url":"https://github.com/LiskHQ/lisk-hub/pull/781#discussion_r185738423","pull_request_url":"https://api.github.com/repos/LiskHQ/lisk-hub/pulls/781","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/LiskHQ/lisk-hub/pulls/comments/185738423"},"html":{"href":"https://github.com/LiskHQ/lisk-hub/pull/781#discussion_r185738423"},"pull_request":{"href":"https://api.github.com/repos/LiskHQ/lisk-hub/pulls/781"}}},"pull_request":{"url":"https://api.github.com/repos/LiskHQ/lisk-hub/pulls/781","id":185431353,"html_url":"https://github.com/LiskHQ/lisk-hub/pull/781","diff_url":"https://github.com/LiskHQ/lisk-hub/pull/781.diff","patch_url":"https://github.com/LiskHQ/lisk-hub/pull/781.patch","issue_url":"https://api.github.com/repos/LiskHQ/lisk-hub/issues/781","number":781,"state":"open","locked":false,"title":"Implement basic request LSK tab","user":{"login":"ginacontrino","id":9592216,"avatar_url":"https://avatars0.githubusercontent.com/u/9592216?v=4","gravatar_id":"","url":"https://api.github.com/users/ginacontrino","html_url":"https://github.com/ginacontrino","followers_url":"https://api.github.com/users/ginacontrino/followers","following_url":"https://api.github.com/users/ginacontrino/following{/other_user}","gists_url":"https://api.github.com/users/ginacontrino/gists{/gist_id}","starred_url":"https://api.github.com/users/ginacontrino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ginacontrino/subscriptions","organizations_url":"https://api.github.com/users/ginacontrino/orgs","repos_url":"https://api.github.com/users/ginacontrino/repos","events_url":"https://api.github.com/users/ginacontrino/events{/privacy}","received_events_url":"https://api.github.com/users/ginacontrino/received_events","type":"User","site_admin":false},"body":"### What was the problem?\r\nWe had no way to request LSK\r\n\r\n### How did I fix it?\r\nBy adding this , but without \"request specific amount\", so for now this is only one step\r\n\r\n\r\nI put this component into the multistep anyway, since there will be more steps in future, so I had to change the multistep component to also work with only one child. This can be removed, once we have multiple children again.\r\n\r\n\r\nTodo: \r\n[ ] clean up ?\r\n[ ] generate QR code with help of a package (to also add the logo)-> imo can be done in a separate PR (a possible tool could be https://github.com/fisherw/qrcode-logo)\r\n[ x ] tests\r\n[ x ] adjust for mobile\r\n\r\n### How to test it?\r\n- Try clicking on \"request\"\r\n- Make sure the QR code and everything else is working\r\n- Then click again on `send`\r\n\r\n### Review checklist\r\n- The PR solves #772\r\n- The PR follows our [Test guide](/LiskHQ/lisk-hub/blob/development/docs/TEST_GUIDE.md)\r\n- The PR follows our [CSS guide](/LiskHQ/lisk-hub/blob/development/docs/CSS_GUIDE.md)\r\n","created_at":"2018-05-02T13:02:16Z","updated_at":"2018-05-03T09:17:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d660be2e6dcccc6addd7a45405675d9a0a43c697","assignee":{"login":"ginacontrino","id":9592216,"avatar_url":"https://avatars0.githubusercontent.com/u/9592216?v=4","gravatar_id":"","url":"https://api.github.com/users/ginacontrino","html_url":"https://github.com/ginacontrino","followers_url":"https://api.github.com/users/ginacontrino/followers","following_url":"https://api.github.com/users/ginacontrino/following{/other_user}","gists_url":"https://api.github.com/users/ginacontrino/gists{/gist_id}","starred_url":"https://api.github.com/users/ginacontrino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ginacontrino/subscriptions","organizations_url":"https://api.github.com/users/ginacontrino/orgs","repos_url":"https://api.github.com/users/ginacontrino/repos","events_url":"https://api.github.com/users/ginacontrino/events{/privacy}","received_events_url":"https://api.github.com/users/ginacontrino/received_events","type":"User","site_admin":false},"assignees":[{"login":"ginacontrino","id":9592216,"avatar_url":"https://avatars0.githubusercontent.com/u/9592216?v=4","gravatar_id":"","url":"https://api.github.com/users/ginacontrino","html_url":"https://github.com/ginacontrino","followers_url":"https://api.github.com/users/ginacontrino/followers","following_url":"https://api.github.com/users/ginacontrino/following{/other_user}","gists_url":"https://api.github.com/users/ginacontrino/gists{/gist_id}","starred_url":"https://api.github.com/users/ginacontrino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ginacontrino/subscriptions","organizations_url":"https://api.github.com/users/ginacontrino/orgs","repos_url":"https://api.github.com/users/ginacontrino/repos","events_url":"https://api.github.com/users/ginacontrino/events{/privacy}","received_events_url":"https://api.github.com/users/ginacontrino/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"yasharAyari","id":6761937,"avatar_url":"https://avatars0.githubusercontent.com/u/6761937?v=4","gravatar_id":"","url":"https://api.github.com/users/yasharAyari","html_url":"https://github.com/yasharAyari","followers_url":"https://api.github.com/users/yasharAyari/followers","following_url":"https://api.github.com/users/yasharAyari/following{/other_user}","gists_url":"https://api.github.com/users/yasharAyari/gists{/gist_id}","starred_url":"https://api.github.com/users/yasharAyari/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yasharAyari/subscriptions","organizations_url":"https://api.github.com/users/yasharAyari/orgs","repos_url":"https://api.github.com/users/yasharAyari/repos","events_url":"https://api.github.com/users/yasharAyari/events{/privacy}","received_events_url":"https://api.github.com/users/yasharAyari/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":751132568,"url":"https://api.github.com/repos/LiskHQ/lisk-hub/labels/:eye:%20pending%20review","name":":eye: pending review","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/LiskHQ/lisk-hub/pulls/781/commits","review_comments_url":"https://api.github.com/repos/LiskHQ/lisk-hub/pulls/781/comments","review_comment_url":"https://api.github.com/repos/LiskHQ/lisk-hub/pulls/comments{/number}","comments_url":"https://api.github.com/repos/LiskHQ/lisk-hub/issues/781/comments","statuses_url":"https://api.github.com/repos/LiskHQ/lisk-hub/statuses/9dd1e670bc5a30339794b26e15a6250964477039","head":{"label":"LiskHQ:772-basic-request-lsk","ref":"772-basic-request-lsk","sha":"9dd1e670bc5a30339794b26e15a6250964477039","user":{"login":"LiskHQ","id":16600915,"avatar_url":"https://avatars1.githubusercontent.com/u/16600915?v=4","gravatar_id":"","url":"https://api.github.com/users/LiskHQ","html_url":"https://github.com/LiskHQ","followers_url":"https://api.github.com/users/LiskHQ/followers","following_url":"https://api.github.com/users/LiskHQ/following{/other_user}","gists_url":"https://api.github.com/users/LiskHQ/gists{/gist_id}","starred_url":"https://api.github.com/users/LiskHQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LiskHQ/subscriptions","organizations_url":"https://api.github.com/users/LiskHQ/orgs","repos_url":"https://api.github.com/users/LiskHQ/repos","events_url":"https://api.github.com/users/LiskHQ/events{/privacy}","received_events_url":"https://api.github.com/users/LiskHQ/received_events","type":"Organization","site_admin":false},"repo":{"id":109285783,"name":"lisk-hub","full_name":"LiskHQ/lisk-hub","owner":{"login":"LiskHQ","id":16600915,"avatar_url":"https://avatars1.githubusercontent.com/u/16600915?v=4","gravatar_id":"","url":"https://api.github.com/users/LiskHQ","html_url":"https://github.com/LiskHQ","followers_url":"https://api.github.com/users/LiskHQ/followers","following_url":"https://api.github.com/users/LiskHQ/following{/other_user}","gists_url":"https://api.github.com/users/LiskHQ/gists{/gist_id}","starred_url":"https://api.github.com/users/LiskHQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LiskHQ/subscriptions","organizations_url":"https://api.github.com/users/LiskHQ/orgs","repos_url":"https://api.github.com/users/LiskHQ/repos","events_url":"https://api.github.com/users/LiskHQ/events{/privacy}","received_events_url":"https://api.github.com/users/LiskHQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/LiskHQ/lisk-hub","description":"🖥 Graphical User Interface (GUI) to manage Lisk IDs, tokens and your sidechains","fork":false,"url":"https://api.github.com/repos/LiskHQ/lisk-hub","forks_url":"https://api.github.com/repos/LiskHQ/lisk-hub/forks","keys_url":"https://api.github.com/repos/LiskHQ/lisk-hub/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LiskHQ/lisk-hub/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LiskHQ/lisk-hub/teams","hooks_url":"https://api.github.com/repos/LiskHQ/lisk-hub/hooks","issue_events_url":"https://api.github.com/repos/LiskHQ/lisk-hub/issues/events{/number}","events_url":"https://api.github.com/repos/LiskHQ/lisk-hub/events","assignees_url":"https://api.github.com/repos/LiskHQ/lisk-hub/assignees{/user}","branches_url":"https://api.github.com/repos/LiskHQ/lisk-hub/branches{/branch}","tags_url":"https://api.github.com/repos/LiskHQ/lisk-hub/tags","blobs_url":"https://api.github.com/repos/LiskHQ/lisk-hub/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LiskHQ/lisk-hub/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LiskHQ/lisk-hub/git/refs{/sha}","trees_url":"https://api.github.com/repos/LiskHQ/lisk-hub/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LiskHQ/lisk-hub/statuses/{sha}","languages_url":"https://api.github.com/repos/LiskHQ/lisk-hub/languages","stargazers_url":"https://api.github.com/repos/LiskHQ/lisk-hub/stargazers","contributors_url":"https://api.github.com/repos/LiskHQ/lisk-hub/contributors","subscribers_url":"https://api.github.com/repos/LiskHQ/lisk-hub/subscribers","subscription_url":"https://api.github.com/repos/LiskHQ/lisk-hub/subscription","commits_url":"https://api.github.com/repos/LiskHQ/lisk-hub/commits{/sha}","git_commits_url":"https://api.github.com/repos/LiskHQ/lisk-hub/git/commits{/sha}","comments_url":"https://api.github.com/repos/LiskHQ/lisk-hub/comments{/number}","issue_comment_url":"https://api.github.com/repos/LiskHQ/lisk-hub/issues/comments{/number}","contents_url":"https://api.github.com/repos/LiskHQ/lisk-hub/contents/{+path}","compare_url":"https://api.github.com/repos/LiskHQ/lisk-hub/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LiskHQ/lisk-hub/merges","archive_url":"https://api.github.com/repos/LiskHQ/lisk-hub/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LiskHQ/lisk-hub/downloads","issues_url":"https://api.github.com/repos/LiskHQ/lisk-hub/issues{/number}","pulls_url":"https://api.github.com/repos/LiskHQ/lisk-hub/pulls{/number}","milestones_url":"https://api.github.com/repos/LiskHQ/lisk-hub/milestones{/number}","notifications_url":"https://api.github.com/repos/LiskHQ/lisk-hub/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LiskHQ/lisk-hub/labels{/name}","releases_url":"https://api.github.com/repos/LiskHQ/lisk-hub/releases{/id}","deployments_url":"https://api.github.com/repos/LiskHQ/lisk-hub/deployments","created_at":"2017-11-02T15:49:25Z","updated_at":"2018-05-03T06:13:13Z","pushed_at":"2018-05-03T09:06:11Z","git_url":"git://github.com/LiskHQ/lisk-hub.git","ssh_url":"[email protected]:LiskHQ/lisk-hub.git","clone_url":"https://github.com/LiskHQ/lisk-hub.git","svn_url":"https://github.com/LiskHQ/lisk-hub","homepage":"https://lisk.io/hub/","size":18512,"stargazers_count":78,"watchers_count":78,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":21,"mirror_url":null,"archived":false,"open_issues_count":65,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":21,"open_issues":65,"watchers":78,"default_branch":"development"}},"base":{"label":"LiskHQ:0.7.0","ref":"0.7.0","sha":"336a7ce0cd9e31662c3ffd25f92541d9e8f50e86","user":{"login":"LiskHQ","id":16600915,"avatar_url":"https://avatars1.githubusercontent.com/u/16600915?v=4","gravatar_id":"","url":"https://api.github.com/users/LiskHQ","html_url":"https://github.com/LiskHQ","followers_url":"https://api.github.com/users/LiskHQ/followers","following_url":"https://api.github.com/users/LiskHQ/following{/other_user}","gists_url":"https://api.github.com/users/LiskHQ/gists{/gist_id}","starred_url":"https://api.github.com/users/LiskHQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LiskHQ/subscriptions","organizations_url":"https://api.github.com/users/LiskHQ/orgs","repos_url":"https://api.github.com/users/LiskHQ/repos","events_url":"https://api.github.com/users/LiskHQ/events{/privacy}","received_events_url":"https://api.github.com/users/LiskHQ/received_events","type":"Organization","site_admin":false},"repo":{"id":109285783,"name":"lisk-hub","full_name":"LiskHQ/lisk-hub","owner":{"login":"LiskHQ","id":16600915,"avatar_url":"https://avatars1.githubusercontent.com/u/16600915?v=4","gravatar_id":"","url":"https://api.github.com/users/LiskHQ","html_url":"https://github.com/LiskHQ","followers_url":"https://api.github.com/users/LiskHQ/followers","following_url":"https://api.github.com/users/LiskHQ/following{/other_user}","gists_url":"https://api.github.com/users/LiskHQ/gists{/gist_id}","starred_url":"https://api.github.com/users/LiskHQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LiskHQ/subscriptions","organizations_url":"https://api.github.com/users/LiskHQ/orgs","repos_url":"https://api.github.com/users/LiskHQ/repos","events_url":"https://api.github.com/users/LiskHQ/events{/privacy}","received_events_url":"https://api.github.com/users/LiskHQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/LiskHQ/lisk-hub","description":"🖥 Graphical User Interface (GUI) to manage Lisk IDs, tokens and your sidechains","fork":false,"url":"https://api.github.com/repos/LiskHQ/lisk-hub","forks_url":"https://api.github.com/repos/LiskHQ/lisk-hub/forks","keys_url":"https://api.github.com/repos/LiskHQ/lisk-hub/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LiskHQ/lisk-hub/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LiskHQ/lisk-hub/teams","hooks_url":"https://api.github.com/repos/LiskHQ/lisk-hub/hooks","issue_events_url":"https://api.github.com/repos/LiskHQ/lisk-hub/issues/events{/number}","events_url":"https://api.github.com/repos/LiskHQ/lisk-hub/events","assignees_url":"https://api.github.com/repos/LiskHQ/lisk-hub/assignees{/user}","branches_url":"https://api.github.com/repos/LiskHQ/lisk-hub/branches{/branch}","tags_url":"https://api.github.com/repos/LiskHQ/lisk-hub/tags","blobs_url":"https://api.github.com/repos/LiskHQ/lisk-hub/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LiskHQ/lisk-hub/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LiskHQ/lisk-hub/git/refs{/sha}","trees_url":"https://api.github.com/repos/LiskHQ/lisk-hub/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LiskHQ/lisk-hub/statuses/{sha}","languages_url":"https://api.github.com/repos/LiskHQ/lisk-hub/languages","stargazers_url":"https://api.github.com/repos/LiskHQ/lisk-hub/stargazers","contributors_url":"https://api.github.com/repos/LiskHQ/lisk-hub/contributors","subscribers_url":"https://api.github.com/repos/LiskHQ/lisk-hub/subscribers","subscription_url":"https://api.github.com/repos/LiskHQ/lisk-hub/subscription","commits_url":"https://api.github.com/repos/LiskHQ/lisk-hub/commits{/sha}","git_commits_url":"https://api.github.com/repos/LiskHQ/lisk-hub/git/commits{/sha}","comments_url":"https://api.github.com/repos/LiskHQ/lisk-hub/comments{/number}","issue_comment_url":"https://api.github.com/repos/LiskHQ/lisk-hub/issues/comments{/number}","contents_url":"https://api.github.com/repos/LiskHQ/lisk-hub/contents/{+path}","compare_url":"https://api.github.com/repos/LiskHQ/lisk-hub/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LiskHQ/lisk-hub/merges","archive_url":"https://api.github.com/repos/LiskHQ/lisk-hub/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LiskHQ/lisk-hub/downloads","issues_url":"https://api.github.com/repos/LiskHQ/lisk-hub/issues{/number}","pulls_url":"https://api.github.com/repos/LiskHQ/lisk-hub/pulls{/number}","milestones_url":"https://api.github.com/repos/LiskHQ/lisk-hub/milestones{/number}","notifications_url":"https://api.github.com/repos/LiskHQ/lisk-hub/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LiskHQ/lisk-hub/labels{/name}","releases_url":"https://api.github.com/repos/LiskHQ/lisk-hub/releases{/id}","deployments_url":"https://api.github.com/repos/LiskHQ/lisk-hub/deployments","created_at":"2017-11-02T15:49:25Z","updated_at":"2018-05-03T06:13:13Z","pushed_at":"2018-05-03T09:06:11Z","git_url":"git://github.com/LiskHQ/lisk-hub.git","ssh_url":"[email protected]:LiskHQ/lisk-hub.git","clone_url":"https://github.com/LiskHQ/lisk-hub.git","svn_url":"https://github.com/LiskHQ/lisk-hub","homepage":"https://lisk.io/hub/","size":18512,"stargazers_count":78,"watchers_count":78,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":21,"mirror_url":null,"archived":false,"open_issues_count":65,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":21,"open_issues":65,"watchers":78,"default_branch":"development"}},"_links":{"self":{"href":"https://api.github.com/repos/LiskHQ/lisk-hub/pulls/781"},"html":{"href":"https://github.com/LiskHQ/lisk-hub/pull/781"},"issue":{"href":"https://api.github.com/repos/LiskHQ/lisk-hub/issues/781"},"comments":{"href":"https://api.github.com/repos/LiskHQ/lisk-hub/issues/781/comments"},"review_comments":{"href":"https://api.github.com/repos/LiskHQ/lisk-hub/pulls/781/comments"},"review_comment":{"href":"https://api.github.com/repos/LiskHQ/lisk-hub/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/LiskHQ/lisk-hub/pulls/781/commits"},"statuses":{"href":"https://api.github.com/repos/LiskHQ/lisk-hub/statuses/9dd1e670bc5a30339794b26e15a6250964477039"}},"author_association":"MEMBER"}} | {
"id": 109285783,
"name": "LiskHQ/lisk-hub",
"url": "https://api.github.com/repos/LiskHQ/lisk-hub"
} | {
"id": 1254342,
"login": "slaweet",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1254342?",
"url": "https://api.github.com/users/slaweet"
} | {
"id": 16600915,
"login": "LiskHQ",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/16600915?",
"url": "https://api.github.com/orgs/LiskHQ"
} | 2018-05-03T09:17:18 | 7621646118 | {"actor":{"display_login":"slaweet"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/pallets/flask/pulls/comments/184556178","pull_request_review_id":115778552,"id":184556178,"diff_hunk":"@@ -544,7 +544,10 @@ def main(self, *args, **kwargs):\n # script that is loaded here also attempts to start a server.\n os.environ['FLASK_RUN_FROM_CLI'] = 'true'\n \n- if self.load_dotenv:\n+ val = os.environ.get('FLASK_DONT_LOAD_ENV')\n+ load_dotenv = not val or val in ('0', 'false', 'no')","path":"flask/cli.py","position":6,"original_position":6,"commit_id":"54660eaa607079260a847b3b8c37d108ffb71d64","original_commit_id":"54660eaa607079260a847b3b8c37d108ffb71d64","user":{"login":"ThiefMaster","id":179599,"avatar_url":"https://avatars1.githubusercontent.com/u/179599?v=4","gravatar_id":"","url":"https://api.github.com/users/ThiefMaster","html_url":"https://github.com/ThiefMaster","followers_url":"https://api.github.com/users/ThiefMaster/followers","following_url":"https://api.github.com/users/ThiefMaster/following{/other_user}","gists_url":"https://api.github.com/users/ThiefMaster/gists{/gist_id}","starred_url":"https://api.github.com/users/ThiefMaster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ThiefMaster/subscriptions","organizations_url":"https://api.github.com/users/ThiefMaster/orgs","repos_url":"https://api.github.com/users/ThiefMaster/repos","events_url":"https://api.github.com/users/ThiefMaster/events{/privacy}","received_events_url":"https://api.github.com/users/ThiefMaster/received_events","type":"User","site_admin":false},"body":"ok fine for me as well","created_at":"2018-04-26T23:13:24Z","updated_at":"2018-04-26T23:13:24Z","html_url":"https://github.com/pallets/flask/pull/2724#discussion_r184556178","pull_request_url":"https://api.github.com/repos/pallets/flask/pulls/2724","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/pallets/flask/pulls/comments/184556178"},"html":{"href":"https://github.com/pallets/flask/pull/2724#discussion_r184556178"},"pull_request":{"href":"https://api.github.com/repos/pallets/flask/pulls/2724"}},"in_reply_to_id":184555358},"pull_request":{"url":"https://api.github.com/repos/pallets/flask/pulls/2724","id":184486047,"html_url":"https://github.com/pallets/flask/pull/2724","diff_url":"https://github.com/pallets/flask/pull/2724.diff","patch_url":"https://github.com/pallets/flask/pull/2724.patch","issue_url":"https://api.github.com/repos/pallets/flask/issues/2724","number":2724,"state":"open","locked":false,"title":"Use FLASK_DONT_LOAD_ENV flag to disable load .env","user":{"login":"lepture","id":290496,"avatar_url":"https://avatars2.githubusercontent.com/u/290496?v=4","gravatar_id":"","url":"https://api.github.com/users/lepture","html_url":"https://github.com/lepture","followers_url":"https://api.github.com/users/lepture/followers","following_url":"https://api.github.com/users/lepture/following{/other_user}","gists_url":"https://api.github.com/users/lepture/gists{/gist_id}","starred_url":"https://api.github.com/users/lepture/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lepture/subscriptions","organizations_url":"https://api.github.com/users/lepture/orgs","repos_url":"https://api.github.com/users/lepture/repos","events_url":"https://api.github.com/users/lepture/events{/privacy}","received_events_url":"https://api.github.com/users/lepture/received_events","type":"User","site_admin":false},"body":"Fix issue: https://github.com/pallets/flask/issues/2722","created_at":"2018-04-26T23:03:09Z","updated_at":"2018-04-26T23:13:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8c56a0e652cc5550fe58728ab94877350050856b","assignee":null,"assignees":[],"requested_reviewers":[{"login":"davidism","id":1242887,"avatar_url":"https://avatars1.githubusercontent.com/u/1242887?v=4","gravatar_id":"","url":"https://api.github.com/users/davidism","html_url":"https://github.com/davidism","followers_url":"https://api.github.com/users/davidism/followers","following_url":"https://api.github.com/users/davidism/following{/other_user}","gists_url":"https://api.github.com/users/davidism/gists{/gist_id}","starred_url":"https://api.github.com/users/davidism/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidism/subscriptions","organizations_url":"https://api.github.com/users/davidism/orgs","repos_url":"https://api.github.com/users/davidism/repos","events_url":"https://api.github.com/users/davidism/events{/privacy}","received_events_url":"https://api.github.com/users/davidism/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/pallets/flask/pulls/2724/commits","review_comments_url":"https://api.github.com/repos/pallets/flask/pulls/2724/comments","review_comment_url":"https://api.github.com/repos/pallets/flask/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pallets/flask/issues/2724/comments","statuses_url":"https://api.github.com/repos/pallets/flask/statuses/54660eaa607079260a847b3b8c37d108ffb71d64","head":{"label":"pallets:issue-2722","ref":"issue-2722","sha":"54660eaa607079260a847b3b8c37d108ffb71d64","user":{"login":"pallets","id":16748505,"avatar_url":"https://avatars3.githubusercontent.com/u/16748505?v=4","gravatar_id":"","url":"https://api.github.com/users/pallets","html_url":"https://github.com/pallets","followers_url":"https://api.github.com/users/pallets/followers","following_url":"https://api.github.com/users/pallets/following{/other_user}","gists_url":"https://api.github.com/users/pallets/gists{/gist_id}","starred_url":"https://api.github.com/users/pallets/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pallets/subscriptions","organizations_url":"https://api.github.com/users/pallets/orgs","repos_url":"https://api.github.com/users/pallets/repos","events_url":"https://api.github.com/users/pallets/events{/privacy}","received_events_url":"https://api.github.com/users/pallets/received_events","type":"Organization","site_admin":false},"repo":{"id":596892,"name":"flask","full_name":"pallets/flask","owner":{"login":"pallets","id":16748505,"avatar_url":"https://avatars3.githubusercontent.com/u/16748505?v=4","gravatar_id":"","url":"https://api.github.com/users/pallets","html_url":"https://github.com/pallets","followers_url":"https://api.github.com/users/pallets/followers","following_url":"https://api.github.com/users/pallets/following{/other_user}","gists_url":"https://api.github.com/users/pallets/gists{/gist_id}","starred_url":"https://api.github.com/users/pallets/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pallets/subscriptions","organizations_url":"https://api.github.com/users/pallets/orgs","repos_url":"https://api.github.com/users/pallets/repos","events_url":"https://api.github.com/users/pallets/events{/privacy}","received_events_url":"https://api.github.com/users/pallets/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pallets/flask","description":"The Python micro framework for building web applications.","fork":false,"url":"https://api.github.com/repos/pallets/flask","forks_url":"https://api.github.com/repos/pallets/flask/forks","keys_url":"https://api.github.com/repos/pallets/flask/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pallets/flask/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pallets/flask/teams","hooks_url":"https://api.github.com/repos/pallets/flask/hooks","issue_events_url":"https://api.github.com/repos/pallets/flask/issues/events{/number}","events_url":"https://api.github.com/repos/pallets/flask/events","assignees_url":"https://api.github.com/repos/pallets/flask/assignees{/user}","branches_url":"https://api.github.com/repos/pallets/flask/branches{/branch}","tags_url":"https://api.github.com/repos/pallets/flask/tags","blobs_url":"https://api.github.com/repos/pallets/flask/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pallets/flask/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pallets/flask/git/refs{/sha}","trees_url":"https://api.github.com/repos/pallets/flask/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pallets/flask/statuses/{sha}","languages_url":"https://api.github.com/repos/pallets/flask/languages","stargazers_url":"https://api.github.com/repos/pallets/flask/stargazers","contributors_url":"https://api.github.com/repos/pallets/flask/contributors","subscribers_url":"https://api.github.com/repos/pallets/flask/subscribers","subscription_url":"https://api.github.com/repos/pallets/flask/subscription","commits_url":"https://api.github.com/repos/pallets/flask/commits{/sha}","git_commits_url":"https://api.github.com/repos/pallets/flask/git/commits{/sha}","comments_url":"https://api.github.com/repos/pallets/flask/comments{/number}","issue_comment_url":"https://api.github.com/repos/pallets/flask/issues/comments{/number}","contents_url":"https://api.github.com/repos/pallets/flask/contents/{+path}","compare_url":"https://api.github.com/repos/pallets/flask/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pallets/flask/merges","archive_url":"https://api.github.com/repos/pallets/flask/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pallets/flask/downloads","issues_url":"https://api.github.com/repos/pallets/flask/issues{/number}","pulls_url":"https://api.github.com/repos/pallets/flask/pulls{/number}","milestones_url":"https://api.github.com/repos/pallets/flask/milestones{/number}","notifications_url":"https://api.github.com/repos/pallets/flask/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pallets/flask/labels{/name}","releases_url":"https://api.github.com/repos/pallets/flask/releases{/id}","deployments_url":"https://api.github.com/repos/pallets/flask/deployments","created_at":"2010-04-06T11:11:59Z","updated_at":"2018-04-26T23:04:59Z","pushed_at":"2018-04-26T23:03:09Z","git_url":"git://github.com/pallets/flask.git","ssh_url":"[email protected]:pallets/flask.git","clone_url":"https://github.com/pallets/flask.git","svn_url":"https://github.com/pallets/flask","homepage":"https://www.palletsprojects.com/p/flask/","size":6192,"stargazers_count":35053,"watchers_count":35053,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":10682,"mirror_url":null,"archived":false,"open_issues_count":20,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":10682,"open_issues":20,"watchers":35053,"default_branch":"master"}},"base":{"label":"pallets:master","ref":"master","sha":"08ef4d03d869cd6d51faf8e37349070b7507f175","user":{"login":"pallets","id":16748505,"avatar_url":"https://avatars3.githubusercontent.com/u/16748505?v=4","gravatar_id":"","url":"https://api.github.com/users/pallets","html_url":"https://github.com/pallets","followers_url":"https://api.github.com/users/pallets/followers","following_url":"https://api.github.com/users/pallets/following{/other_user}","gists_url":"https://api.github.com/users/pallets/gists{/gist_id}","starred_url":"https://api.github.com/users/pallets/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pallets/subscriptions","organizations_url":"https://api.github.com/users/pallets/orgs","repos_url":"https://api.github.com/users/pallets/repos","events_url":"https://api.github.com/users/pallets/events{/privacy}","received_events_url":"https://api.github.com/users/pallets/received_events","type":"Organization","site_admin":false},"repo":{"id":596892,"name":"flask","full_name":"pallets/flask","owner":{"login":"pallets","id":16748505,"avatar_url":"https://avatars3.githubusercontent.com/u/16748505?v=4","gravatar_id":"","url":"https://api.github.com/users/pallets","html_url":"https://github.com/pallets","followers_url":"https://api.github.com/users/pallets/followers","following_url":"https://api.github.com/users/pallets/following{/other_user}","gists_url":"https://api.github.com/users/pallets/gists{/gist_id}","starred_url":"https://api.github.com/users/pallets/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pallets/subscriptions","organizations_url":"https://api.github.com/users/pallets/orgs","repos_url":"https://api.github.com/users/pallets/repos","events_url":"https://api.github.com/users/pallets/events{/privacy}","received_events_url":"https://api.github.com/users/pallets/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pallets/flask","description":"The Python micro framework for building web applications.","fork":false,"url":"https://api.github.com/repos/pallets/flask","forks_url":"https://api.github.com/repos/pallets/flask/forks","keys_url":"https://api.github.com/repos/pallets/flask/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pallets/flask/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pallets/flask/teams","hooks_url":"https://api.github.com/repos/pallets/flask/hooks","issue_events_url":"https://api.github.com/repos/pallets/flask/issues/events{/number}","events_url":"https://api.github.com/repos/pallets/flask/events","assignees_url":"https://api.github.com/repos/pallets/flask/assignees{/user}","branches_url":"https://api.github.com/repos/pallets/flask/branches{/branch}","tags_url":"https://api.github.com/repos/pallets/flask/tags","blobs_url":"https://api.github.com/repos/pallets/flask/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pallets/flask/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pallets/flask/git/refs{/sha}","trees_url":"https://api.github.com/repos/pallets/flask/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pallets/flask/statuses/{sha}","languages_url":"https://api.github.com/repos/pallets/flask/languages","stargazers_url":"https://api.github.com/repos/pallets/flask/stargazers","contributors_url":"https://api.github.com/repos/pallets/flask/contributors","subscribers_url":"https://api.github.com/repos/pallets/flask/subscribers","subscription_url":"https://api.github.com/repos/pallets/flask/subscription","commits_url":"https://api.github.com/repos/pallets/flask/commits{/sha}","git_commits_url":"https://api.github.com/repos/pallets/flask/git/commits{/sha}","comments_url":"https://api.github.com/repos/pallets/flask/comments{/number}","issue_comment_url":"https://api.github.com/repos/pallets/flask/issues/comments{/number}","contents_url":"https://api.github.com/repos/pallets/flask/contents/{+path}","compare_url":"https://api.github.com/repos/pallets/flask/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pallets/flask/merges","archive_url":"https://api.github.com/repos/pallets/flask/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pallets/flask/downloads","issues_url":"https://api.github.com/repos/pallets/flask/issues{/number}","pulls_url":"https://api.github.com/repos/pallets/flask/pulls{/number}","milestones_url":"https://api.github.com/repos/pallets/flask/milestones{/number}","notifications_url":"https://api.github.com/repos/pallets/flask/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pallets/flask/labels{/name}","releases_url":"https://api.github.com/repos/pallets/flask/releases{/id}","deployments_url":"https://api.github.com/repos/pallets/flask/deployments","created_at":"2010-04-06T11:11:59Z","updated_at":"2018-04-26T23:04:59Z","pushed_at":"2018-04-26T23:03:09Z","git_url":"git://github.com/pallets/flask.git","ssh_url":"[email protected]:pallets/flask.git","clone_url":"https://github.com/pallets/flask.git","svn_url":"https://github.com/pallets/flask","homepage":"https://www.palletsprojects.com/p/flask/","size":6192,"stargazers_count":35053,"watchers_count":35053,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":10682,"mirror_url":null,"archived":false,"open_issues_count":20,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":10682,"open_issues":20,"watchers":35053,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pallets/flask/pulls/2724"},"html":{"href":"https://github.com/pallets/flask/pull/2724"},"issue":{"href":"https://api.github.com/repos/pallets/flask/issues/2724"},"comments":{"href":"https://api.github.com/repos/pallets/flask/issues/2724/comments"},"review_comments":{"href":"https://api.github.com/repos/pallets/flask/pulls/2724/comments"},"review_comment":{"href":"https://api.github.com/repos/pallets/flask/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pallets/flask/pulls/2724/commits"},"statuses":{"href":"https://api.github.com/repos/pallets/flask/statuses/54660eaa607079260a847b3b8c37d108ffb71d64"}},"author_association":"MEMBER"}} | {
"id": 596892,
"name": "pallets/flask",
"url": "https://api.github.com/repos/pallets/flask"
} | {
"id": 179599,
"login": "ThiefMaster",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/179599?",
"url": "https://api.github.com/users/ThiefMaster"
} | {
"id": 16748505,
"login": "pallets",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/16748505?",
"url": "https://api.github.com/orgs/pallets"
} | 2018-04-26T23:13:24 | 7594463056 | {"actor":{"display_login":"ThiefMaster"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/ColoredCow/employee-portal/pulls/comments/201223913","pull_request_review_id":135679450,"id":201223913,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMTIyMzkxMw==","diff_hunk":"@@ -73,6 +73,7 @@\n 'index' => 'applications.volunteer.index',\n 'edit' => 'applications.volunteer.edit',\n ]);\n+ Route::post('{application}/sendmail', 'JobApplicationController@sendMail');","path":"routes/web.php","position":4,"original_position":4,"commit_id":"ded86be6279e6346103d724664abf0a30282dd28","original_commit_id":"ded86be6279e6346103d724664abf0a30282dd28","user":{"login":"wevekamola","id":29367838,"node_id":"MDQ6VXNlcjI5MzY3ODM4","avatar_url":"https://avatars2.githubusercontent.com/u/29367838?v=4","gravatar_id":"","url":"https://api.github.com/users/wevekamola","html_url":"https://github.com/wevekamola","followers_url":"https://api.github.com/users/wevekamola/followers","following_url":"https://api.github.com/users/wevekamola/following{/other_user}","gists_url":"https://api.github.com/users/wevekamola/gists{/gist_id}","starred_url":"https://api.github.com/users/wevekamola/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wevekamola/subscriptions","organizations_url":"https://api.github.com/users/wevekamola/orgs","repos_url":"https://api.github.com/users/wevekamola/repos","events_url":"https://api.github.com/users/wevekamola/events{/privacy}","received_events_url":"https://api.github.com/users/wevekamola/received_events","type":"User","site_admin":false},"body":"Here `JobApplicationController@sendMail` looks too ambiguous, can't we use `JobApplicationController@sendApplicationMail`, then it will be more readable to others. let me know your thoughts @abhishek-pokhriyal .","created_at":"2018-07-10T05:54:52Z","updated_at":"2018-07-10T05:56:02Z","html_url":"https://github.com/ColoredCow/employee-portal/pull/536#discussion_r201223913","pull_request_url":"https://api.github.com/repos/ColoredCow/employee-portal/pulls/536","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ColoredCow/employee-portal/pulls/comments/201223913"},"html":{"href":"https://github.com/ColoredCow/employee-portal/pull/536#discussion_r201223913"},"pull_request":{"href":"https://api.github.com/repos/ColoredCow/employee-portal/pulls/536"}}},"pull_request":{"url":"https://api.github.com/repos/ColoredCow/employee-portal/pulls/536","id":198665597,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4NjY1NTk3","html_url":"https://github.com/ColoredCow/employee-portal/pull/536","diff_url":"https://github.com/ColoredCow/employee-portal/pull/536.diff","patch_url":"https://github.com/ColoredCow/employee-portal/pull/536.patch","issue_url":"https://api.github.com/repos/ColoredCow/employee-portal/issues/536","number":536,"state":"open","locked":false,"title":"378 custom emails","user":{"login":"abhishek-pokhriyal","id":11808845,"node_id":"MDQ6VXNlcjExODA4ODQ1","avatar_url":"https://avatars3.githubusercontent.com/u/11808845?v=4","gravatar_id":"","url":"https://api.github.com/users/abhishek-pokhriyal","html_url":"https://github.com/abhishek-pokhriyal","followers_url":"https://api.github.com/users/abhishek-pokhriyal/followers","following_url":"https://api.github.com/users/abhishek-pokhriyal/following{/other_user}","gists_url":"https://api.github.com/users/abhishek-pokhriyal/gists{/gist_id}","starred_url":"https://api.github.com/users/abhishek-pokhriyal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abhishek-pokhriyal/subscriptions","organizations_url":"https://api.github.com/users/abhishek-pokhriyal/orgs","repos_url":"https://api.github.com/users/abhishek-pokhriyal/repos","events_url":"https://api.github.com/users/abhishek-pokhriyal/events{/privacy}","received_events_url":"https://api.github.com/users/abhishek-pokhriyal/received_events","type":"User","site_admin":false},"body":"#378 \r\n\r\n1. Added a button `Send Mail` at the top of the applicant's job application page. This button is outside of any particular application round.\r\n2. Created a new file `custom-mail-modal.blade.php`. This modal will open up when the `Send Mail` button is clicked.\r\n3. When the user sends this mail, the following things happen:\r\n - The control passes to `JobApplicationController` which prepares the data\r\n - The data is saved in `hr_application_meta` table\r\n - Mail is sent and redirects back to that particular job application's page\r\n","created_at":"2018-07-02T12:35:04Z","updated_at":"2018-07-10T05:56:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e48347ae059a1eb6aa52cf8d01fd22a21e6415cd","assignee":{"login":"abhishek-pokhriyal","id":11808845,"node_id":"MDQ6VXNlcjExODA4ODQ1","avatar_url":"https://avatars3.githubusercontent.com/u/11808845?v=4","gravatar_id":"","url":"https://api.github.com/users/abhishek-pokhriyal","html_url":"https://github.com/abhishek-pokhriyal","followers_url":"https://api.github.com/users/abhishek-pokhriyal/followers","following_url":"https://api.github.com/users/abhishek-pokhriyal/following{/other_user}","gists_url":"https://api.github.com/users/abhishek-pokhriyal/gists{/gist_id}","starred_url":"https://api.github.com/users/abhishek-pokhriyal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abhishek-pokhriyal/subscriptions","organizations_url":"https://api.github.com/users/abhishek-pokhriyal/orgs","repos_url":"https://api.github.com/users/abhishek-pokhriyal/repos","events_url":"https://api.github.com/users/abhishek-pokhriyal/events{/privacy}","received_events_url":"https://api.github.com/users/abhishek-pokhriyal/received_events","type":"User","site_admin":false},"assignees":[{"login":"abhishek-pokhriyal","id":11808845,"node_id":"MDQ6VXNlcjExODA4ODQ1","avatar_url":"https://avatars3.githubusercontent.com/u/11808845?v=4","gravatar_id":"","url":"https://api.github.com/users/abhishek-pokhriyal","html_url":"https://github.com/abhishek-pokhriyal","followers_url":"https://api.github.com/users/abhishek-pokhriyal/followers","following_url":"https://api.github.com/users/abhishek-pokhriyal/following{/other_user}","gists_url":"https://api.github.com/users/abhishek-pokhriyal/gists{/gist_id}","starred_url":"https://api.github.com/users/abhishek-pokhriyal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abhishek-pokhriyal/subscriptions","organizations_url":"https://api.github.com/users/abhishek-pokhriyal/orgs","repos_url":"https://api.github.com/users/abhishek-pokhriyal/repos","events_url":"https://api.github.com/users/abhishek-pokhriyal/events{/privacy}","received_events_url":"https://api.github.com/users/abhishek-pokhriyal/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"bohraji","id":12884297,"node_id":"MDQ6VXNlcjEyODg0Mjk3","avatar_url":"https://avatars1.githubusercontent.com/u/12884297?v=4","gravatar_id":"","url":"https://api.github.com/users/bohraji","html_url":"https://github.com/bohraji","followers_url":"https://api.github.com/users/bohraji/followers","following_url":"https://api.github.com/users/bohraji/following{/other_user}","gists_url":"https://api.github.com/users/bohraji/gists{/gist_id}","starred_url":"https://api.github.com/users/bohraji/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bohraji/subscriptions","organizations_url":"https://api.github.com/users/bohraji/orgs","repos_url":"https://api.github.com/users/bohraji/repos","events_url":"https://api.github.com/users/bohraji/events{/privacy}","received_events_url":"https://api.github.com/users/bohraji/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":866718225,"node_id":"MDU6TGFiZWw4NjY3MTgyMjU=","url":"https://api.github.com/repos/ColoredCow/employee-portal/labels/status%20:%20ready%20for%20review","name":"status : ready for review","color":"bfd4f2","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ColoredCow/employee-portal/pulls/536/commits","review_comments_url":"https://api.github.com/repos/ColoredCow/employee-portal/pulls/536/comments","review_comment_url":"https://api.github.com/repos/ColoredCow/employee-portal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ColoredCow/employee-portal/issues/536/comments","statuses_url":"https://api.github.com/repos/ColoredCow/employee-portal/statuses/ded86be6279e6346103d724664abf0a30282dd28","head":{"label":"ColoredCow:378-custom-emails","ref":"378-custom-emails","sha":"ded86be6279e6346103d724664abf0a30282dd28","user":{"login":"ColoredCow","id":17040495,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3MDQwNDk1","avatar_url":"https://avatars3.githubusercontent.com/u/17040495?v=4","gravatar_id":"","url":"https://api.github.com/users/ColoredCow","html_url":"https://github.com/ColoredCow","followers_url":"https://api.github.com/users/ColoredCow/followers","following_url":"https://api.github.com/users/ColoredCow/following{/other_user}","gists_url":"https://api.github.com/users/ColoredCow/gists{/gist_id}","starred_url":"https://api.github.com/users/ColoredCow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ColoredCow/subscriptions","organizations_url":"https://api.github.com/users/ColoredCow/orgs","repos_url":"https://api.github.com/users/ColoredCow/repos","events_url":"https://api.github.com/users/ColoredCow/events{/privacy}","received_events_url":"https://api.github.com/users/ColoredCow/received_events","type":"Organization","site_admin":false},"repo":{"id":125008594,"node_id":"MDEwOlJlcG9zaXRvcnkxMjUwMDg1OTQ=","name":"employee-portal","full_name":"ColoredCow/employee-portal","owner":{"login":"ColoredCow","id":17040495,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3MDQwNDk1","avatar_url":"https://avatars3.githubusercontent.com/u/17040495?v=4","gravatar_id":"","url":"https://api.github.com/users/ColoredCow","html_url":"https://github.com/ColoredCow","followers_url":"https://api.github.com/users/ColoredCow/followers","following_url":"https://api.github.com/users/ColoredCow/following{/other_user}","gists_url":"https://api.github.com/users/ColoredCow/gists{/gist_id}","starred_url":"https://api.github.com/users/ColoredCow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ColoredCow/subscriptions","organizations_url":"https://api.github.com/users/ColoredCow/orgs","repos_url":"https://api.github.com/users/ColoredCow/repos","events_url":"https://api.github.com/users/ColoredCow/events{/privacy}","received_events_url":"https://api.github.com/users/ColoredCow/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ColoredCow/employee-portal","description":"Solution for organisations to manage all operations' data. Built over GSuite.","fork":false,"url":"https://api.github.com/repos/ColoredCow/employee-portal","forks_url":"https://api.github.com/repos/ColoredCow/employee-portal/forks","keys_url":"https://api.github.com/repos/ColoredCow/employee-portal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ColoredCow/employee-portal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ColoredCow/employee-portal/teams","hooks_url":"https://api.github.com/repos/ColoredCow/employee-portal/hooks","issue_events_url":"https://api.github.com/repos/ColoredCow/employee-portal/issues/events{/number}","events_url":"https://api.github.com/repos/ColoredCow/employee-portal/events","assignees_url":"https://api.github.com/repos/ColoredCow/employee-portal/assignees{/user}","branches_url":"https://api.github.com/repos/ColoredCow/employee-portal/branches{/branch}","tags_url":"https://api.github.com/repos/ColoredCow/employee-portal/tags","blobs_url":"https://api.github.com/repos/ColoredCow/employee-portal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ColoredCow/employee-portal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ColoredCow/employee-portal/git/refs{/sha}","trees_url":"https://api.github.com/repos/ColoredCow/employee-portal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ColoredCow/employee-portal/statuses/{sha}","languages_url":"https://api.github.com/repos/ColoredCow/employee-portal/languages","stargazers_url":"https://api.github.com/repos/ColoredCow/employee-portal/stargazers","contributors_url":"https://api.github.com/repos/ColoredCow/employee-portal/contributors","subscribers_url":"https://api.github.com/repos/ColoredCow/employee-portal/subscribers","subscription_url":"https://api.github.com/repos/ColoredCow/employee-portal/subscription","commits_url":"https://api.github.com/repos/ColoredCow/employee-portal/commits{/sha}","git_commits_url":"https://api.github.com/repos/ColoredCow/employee-portal/git/commits{/sha}","comments_url":"https://api.github.com/repos/ColoredCow/employee-portal/comments{/number}","issue_comment_url":"https://api.github.com/repos/ColoredCow/employee-portal/issues/comments{/number}","contents_url":"https://api.github.com/repos/ColoredCow/employee-portal/contents/{+path}","compare_url":"https://api.github.com/repos/ColoredCow/employee-portal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ColoredCow/employee-portal/merges","archive_url":"https://api.github.com/repos/ColoredCow/employee-portal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ColoredCow/employee-portal/downloads","issues_url":"https://api.github.com/repos/ColoredCow/employee-portal/issues{/number}","pulls_url":"https://api.github.com/repos/ColoredCow/employee-portal/pulls{/number}","milestones_url":"https://api.github.com/repos/ColoredCow/employee-portal/milestones{/number}","notifications_url":"https://api.github.com/repos/ColoredCow/employee-portal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ColoredCow/employee-portal/labels{/name}","releases_url":"https://api.github.com/repos/ColoredCow/employee-portal/releases{/id}","deployments_url":"https://api.github.com/repos/ColoredCow/employee-portal/deployments","created_at":"2018-03-13T07:16:20Z","updated_at":"2018-07-04T09:39:22Z","pushed_at":"2018-07-10T05:52:22Z","git_url":"git://github.com/ColoredCow/employee-portal.git","ssh_url":"[email protected]:ColoredCow/employee-portal.git","clone_url":"https://github.com/ColoredCow/employee-portal.git","svn_url":"https://github.com/ColoredCow/employee-portal","homepage":"","size":3387,"stargazers_count":3,"watchers_count":3,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":131,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":6,"open_issues":131,"watchers":3,"default_branch":"master"}},"base":{"label":"ColoredCow:develop","ref":"develop","sha":"cc0dce030d52330f85b0adfaeade1a43a4a6bed9","user":{"login":"ColoredCow","id":17040495,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3MDQwNDk1","avatar_url":"https://avatars3.githubusercontent.com/u/17040495?v=4","gravatar_id":"","url":"https://api.github.com/users/ColoredCow","html_url":"https://github.com/ColoredCow","followers_url":"https://api.github.com/users/ColoredCow/followers","following_url":"https://api.github.com/users/ColoredCow/following{/other_user}","gists_url":"https://api.github.com/users/ColoredCow/gists{/gist_id}","starred_url":"https://api.github.com/users/ColoredCow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ColoredCow/subscriptions","organizations_url":"https://api.github.com/users/ColoredCow/orgs","repos_url":"https://api.github.com/users/ColoredCow/repos","events_url":"https://api.github.com/users/ColoredCow/events{/privacy}","received_events_url":"https://api.github.com/users/ColoredCow/received_events","type":"Organization","site_admin":false},"repo":{"id":125008594,"node_id":"MDEwOlJlcG9zaXRvcnkxMjUwMDg1OTQ=","name":"employee-portal","full_name":"ColoredCow/employee-portal","owner":{"login":"ColoredCow","id":17040495,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3MDQwNDk1","avatar_url":"https://avatars3.githubusercontent.com/u/17040495?v=4","gravatar_id":"","url":"https://api.github.com/users/ColoredCow","html_url":"https://github.com/ColoredCow","followers_url":"https://api.github.com/users/ColoredCow/followers","following_url":"https://api.github.com/users/ColoredCow/following{/other_user}","gists_url":"https://api.github.com/users/ColoredCow/gists{/gist_id}","starred_url":"https://api.github.com/users/ColoredCow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ColoredCow/subscriptions","organizations_url":"https://api.github.com/users/ColoredCow/orgs","repos_url":"https://api.github.com/users/ColoredCow/repos","events_url":"https://api.github.com/users/ColoredCow/events{/privacy}","received_events_url":"https://api.github.com/users/ColoredCow/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ColoredCow/employee-portal","description":"Solution for organisations to manage all operations' data. Built over GSuite.","fork":false,"url":"https://api.github.com/repos/ColoredCow/employee-portal","forks_url":"https://api.github.com/repos/ColoredCow/employee-portal/forks","keys_url":"https://api.github.com/repos/ColoredCow/employee-portal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ColoredCow/employee-portal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ColoredCow/employee-portal/teams","hooks_url":"https://api.github.com/repos/ColoredCow/employee-portal/hooks","issue_events_url":"https://api.github.com/repos/ColoredCow/employee-portal/issues/events{/number}","events_url":"https://api.github.com/repos/ColoredCow/employee-portal/events","assignees_url":"https://api.github.com/repos/ColoredCow/employee-portal/assignees{/user}","branches_url":"https://api.github.com/repos/ColoredCow/employee-portal/branches{/branch}","tags_url":"https://api.github.com/repos/ColoredCow/employee-portal/tags","blobs_url":"https://api.github.com/repos/ColoredCow/employee-portal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ColoredCow/employee-portal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ColoredCow/employee-portal/git/refs{/sha}","trees_url":"https://api.github.com/repos/ColoredCow/employee-portal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ColoredCow/employee-portal/statuses/{sha}","languages_url":"https://api.github.com/repos/ColoredCow/employee-portal/languages","stargazers_url":"https://api.github.com/repos/ColoredCow/employee-portal/stargazers","contributors_url":"https://api.github.com/repos/ColoredCow/employee-portal/contributors","subscribers_url":"https://api.github.com/repos/ColoredCow/employee-portal/subscribers","subscription_url":"https://api.github.com/repos/ColoredCow/employee-portal/subscription","commits_url":"https://api.github.com/repos/ColoredCow/employee-portal/commits{/sha}","git_commits_url":"https://api.github.com/repos/ColoredCow/employee-portal/git/commits{/sha}","comments_url":"https://api.github.com/repos/ColoredCow/employee-portal/comments{/number}","issue_comment_url":"https://api.github.com/repos/ColoredCow/employee-portal/issues/comments{/number}","contents_url":"https://api.github.com/repos/ColoredCow/employee-portal/contents/{+path}","compare_url":"https://api.github.com/repos/ColoredCow/employee-portal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ColoredCow/employee-portal/merges","archive_url":"https://api.github.com/repos/ColoredCow/employee-portal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ColoredCow/employee-portal/downloads","issues_url":"https://api.github.com/repos/ColoredCow/employee-portal/issues{/number}","pulls_url":"https://api.github.com/repos/ColoredCow/employee-portal/pulls{/number}","milestones_url":"https://api.github.com/repos/ColoredCow/employee-portal/milestones{/number}","notifications_url":"https://api.github.com/repos/ColoredCow/employee-portal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ColoredCow/employee-portal/labels{/name}","releases_url":"https://api.github.com/repos/ColoredCow/employee-portal/releases{/id}","deployments_url":"https://api.github.com/repos/ColoredCow/employee-portal/deployments","created_at":"2018-03-13T07:16:20Z","updated_at":"2018-07-04T09:39:22Z","pushed_at":"2018-07-10T05:52:22Z","git_url":"git://github.com/ColoredCow/employee-portal.git","ssh_url":"[email protected]:ColoredCow/employee-portal.git","clone_url":"https://github.com/ColoredCow/employee-portal.git","svn_url":"https://github.com/ColoredCow/employee-portal","homepage":"","size":3387,"stargazers_count":3,"watchers_count":3,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":131,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":6,"open_issues":131,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ColoredCow/employee-portal/pulls/536"},"html":{"href":"https://github.com/ColoredCow/employee-portal/pull/536"},"issue":{"href":"https://api.github.com/repos/ColoredCow/employee-portal/issues/536"},"comments":{"href":"https://api.github.com/repos/ColoredCow/employee-portal/issues/536/comments"},"review_comments":{"href":"https://api.github.com/repos/ColoredCow/employee-portal/pulls/536/comments"},"review_comment":{"href":"https://api.github.com/repos/ColoredCow/employee-portal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ColoredCow/employee-portal/pulls/536/commits"},"statuses":{"href":"https://api.github.com/repos/ColoredCow/employee-portal/statuses/ded86be6279e6346103d724664abf0a30282dd28"}},"author_association":"COLLABORATOR"}} | {
"id": 125008594,
"name": "ColoredCow/employee-portal",
"url": "https://api.github.com/repos/ColoredCow/employee-portal"
} | {
"id": 29367838,
"login": "wevekamola",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/29367838?",
"url": "https://api.github.com/users/wevekamola"
} | {
"id": 17040495,
"login": "ColoredCow",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/17040495?",
"url": "https://api.github.com/orgs/ColoredCow"
} | 2018-07-10T05:54:52 | 7941639080 | {"actor":{"display_login":"wevekamola"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/RUGSoftEng/2018-PyDash.io/pulls/comments/189434640","pull_request_review_id":121619280,"id":189434640,"diff_hunk":"@@ -0,0 +1,70 @@\n+import React, { Component} from 'react';\r\n+\r\n+import Button from 'material-ui/Button';\r\n+import { Link } from 'react-router-dom';\r\n+\r\n+class EndpointsTable extends Component {\r\n+ render = () => {\r\n+ console.log(this.props.data);\r","path":"pydash-front/src/authenticated_app/endpoint/EndpointsTable.js","position":null,"original_position":8,"commit_id":"75c9b734d2ccb2ca1bb6b947af585e0212f04e60","original_commit_id":"a7730531b7ac535562cb86efde716715ef31cc91","user":{"login":"ArjanTilstra","id":26383724,"avatar_url":"https://avatars1.githubusercontent.com/u/26383724?v=4","gravatar_id":"","url":"https://api.github.com/users/ArjanTilstra","html_url":"https://github.com/ArjanTilstra","followers_url":"https://api.github.com/users/ArjanTilstra/followers","following_url":"https://api.github.com/users/ArjanTilstra/following{/other_user}","gists_url":"https://api.github.com/users/ArjanTilstra/gists{/gist_id}","starred_url":"https://api.github.com/users/ArjanTilstra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ArjanTilstra/subscriptions","organizations_url":"https://api.github.com/users/ArjanTilstra/orgs","repos_url":"https://api.github.com/users/ArjanTilstra/repos","events_url":"https://api.github.com/users/ArjanTilstra/events{/privacy}","received_events_url":"https://api.github.com/users/ArjanTilstra/received_events","type":"User","site_admin":false},"body":"This has been fixed","created_at":"2018-05-19T13:35:06Z","updated_at":"2018-05-19T13:35:07Z","html_url":"https://github.com/RUGSoftEng/2018-PyDash.io/pull/338#discussion_r189434640","pull_request_url":"https://api.github.com/repos/RUGSoftEng/2018-PyDash.io/pulls/338","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/RUGSoftEng/2018-PyDash.io/pulls/comments/189434640"},"html":{"href":"https://github.com/RUGSoftEng/2018-PyDash.io/pull/338#discussion_r189434640"},"pull_request":{"href":"https://api.github.com/repos/RUGSoftEng/2018-PyDash.io/pulls/338"}},"in_reply_to_id":188611624},"pull_request":{"url":"https://api.github.com/repos/RUGSoftEng/2018-PyDash.io/pulls/338","id":188398755,"html_url":"https://github.com/RUGSoftEng/2018-PyDash.io/pull/338","diff_url":"https://github.com/RUGSoftEng/2018-PyDash.io/pull/338.diff","patch_url":"https://github.com/RUGSoftEng/2018-PyDash.io/pull/338.patch","issue_url":"https://api.github.com/repos/RUGSoftEng/2018-PyDash.io/issues/338","number":338,"state":"open","locked":false,"title":"Master pr","user":{"login":"Qqwy","id":5345745,"avatar_url":"https://avatars2.githubusercontent.com/u/5345745?v=4","gravatar_id":"","url":"https://api.github.com/users/Qqwy","html_url":"https://github.com/Qqwy","followers_url":"https://api.github.com/users/Qqwy/followers","following_url":"https://api.github.com/users/Qqwy/following{/other_user}","gists_url":"https://api.github.com/users/Qqwy/gists{/gist_id}","starred_url":"https://api.github.com/users/Qqwy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Qqwy/subscriptions","organizations_url":"https://api.github.com/users/Qqwy/orgs","repos_url":"https://api.github.com/users/Qqwy/repos","events_url":"https://api.github.com/users/Qqwy/events{/privacy}","received_events_url":"https://api.github.com/users/Qqwy/received_events","type":"User","site_admin":false},"body":"New PR from Development to Master.\r\n\r\nContains the new hotfix that ensures graphs show up.","created_at":"2018-05-16T11:18:13Z","updated_at":"2018-05-19T13:35:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dd3b6cfbd5adeb8fad46435011646cb61d666c76","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/RUGSoftEng/2018-PyDash.io/pulls/338/commits","review_comments_url":"https://api.github.com/repos/RUGSoftEng/2018-PyDash.io/pulls/338/comments","review_comment_url":"https://api.github.com/repos/RUGSoftEng/2018-PyDash.io/pulls/comments{/number}","comments_url":"https://api.github.com/repos/RUGSoftEng/2018-PyDash.io/issues/338/comments","statuses_url":"https://api.github.com/repos/RUGSoftEng/2018-PyDash.io/statuses/75c9b734d2ccb2ca1bb6b947af585e0212f04e60","head":{"label":"RUGSoftEng:master_pr","ref":"master_pr","sha":"75c9b734d2ccb2ca1bb6b947af585e0212f04e60","user":{"login":"RUGSoftEng","id":17049951,"avatar_url":"https://avatars3.githubusercontent.com/u/17049951?v=4","gravatar_id":"","url":"https://api.github.com/users/RUGSoftEng","html_url":"https://github.com/RUGSoftEng","followers_url":"https://api.github.com/users/RUGSoftEng/followers","following_url":"https://api.github.com/users/RUGSoftEng/following{/other_user}","gists_url":"https://api.github.com/users/RUGSoftEng/gists{/gist_id}","starred_url":"https://api.github.com/users/RUGSoftEng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RUGSoftEng/subscriptions","organizations_url":"https://api.github.com/users/RUGSoftEng/orgs","repos_url":"https://api.github.com/users/RUGSoftEng/repos","events_url":"https://api.github.com/users/RUGSoftEng/events{/privacy}","received_events_url":"https://api.github.com/users/RUGSoftEng/received_events","type":"Organization","site_admin":false},"repo":{"id":121507896,"name":"2018-PyDash.io","full_name":"RUGSoftEng/2018-PyDash.io","owner":{"login":"RUGSoftEng","id":17049951,"avatar_url":"https://avatars3.githubusercontent.com/u/17049951?v=4","gravatar_id":"","url":"https://api.github.com/users/RUGSoftEng","html_url":"https://github.com/RUGSoftEng","followers_url":"https://api.github.com/users/RUGSoftEng/followers","following_url":"https://api.github.com/users/RUGSoftEng/following{/other_user}","gists_url":"https://api.github.com/users/RUGSoftEng/gists{/gist_id}","starred_url":"https://api.github.com/users/RUGSoftEng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RUGSoftEng/subscriptions","organizations_url":"https://api.github.com/users/RUGSoftEng/orgs","repos_url":"https://api.github.com/users/RUGSoftEng/repos","events_url":"https://api.github.com/users/RUGSoftEng/events{/privacy}","received_events_url":"https://api.github.com/users/RUGSoftEng/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/RUGSoftEng/2018-PyDash.io","description":"A Flask Web-service for visualising Flask-Monitoring-Dashboards","fork":false,"url":"https://api.github.com/repos/RUGSoftEng/2018-PyDash.io","forks_url":"https://api.github.com/repos/RUGSoftEng/2018-PyDash.io/forks","keys_url":"https://api.github.com/repos/RUGSoftEng/2018-PyDash.io/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RUGSoftEng/2018-PyDash.io/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RUGSoftEng/2018-PyDash.io/teams","hooks_url":"https://api.github.com/repos/RUGSoftEng/2018-PyDash.io/hooks","issue_events_url":"https://api.github.com/repos/RUGSoftEng/2018-PyDash.io/issues/events{/number}","events_url":"https://api.github.com/repos/RUGSoftEng/2018-PyDash.io/events","assignees_url":"https://api.github.com/repos/RUGSoftEng/2018-PyDash.io/assignees{/user}","branches_url":"https://api.github.com/repos/RUGSoftEng/2018-PyDash.io/branches{/branch}","tags_url":"https://api.github.com/repos/RUGSoftEng/2018-PyDash.io/tags","blobs_url":"https://api.github.com/repos/RUGSoftEng/2018-PyDash.io/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RUGSoftEng/2018-PyDash.io/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RUGSoftEng/2018-PyDash.io/git/refs{/sha}","trees_url":"https://api.github.com/repos/RUGSoftEng/2018-PyDash.io/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RUGSoftEng/2018-PyDash.io/statuses/{sha}","languages_url":"https://api.github.com/repos/RUGSoftEng/2018-PyDash.io/languages","stargazers_url":"https://api.github.com/repos/RUGSoftEng/2018-PyDash.io/stargazers","contributors_url":"https://api.github.com/repos/RUGSoftEng/2018-PyDash.io/contributors","subscribers_url":"https://api.github.com/repos/RUGSoftEng/2018-PyDash.io/subscribers","subscription_url":"https://api.github.com/repos/RUGSoftEng/2018-PyDash.io/subscription","commits_url":"https://api.github.com/repos/RUGSoftEng/2018-PyDash.io/commits{/sha}","git_commits_url":"https://api.github.com/repos/RUGSoftEng/2018-PyDash.io/git/commits{/sha}","comments_url":"https://api.github.com/repos/RUGSoftEng/2018-PyDash.io/comments{/number}","issue_comment_url":"https://api.github.com/repos/RUGSoftEng/2018-PyDash.io/issues/comments{/number}","contents_url":"https://api.github.com/repos/RUGSoftEng/2018-PyDash.io/contents/{+path}","compare_url":"https://api.github.com/repos/RUGSoftEng/2018-PyDash.io/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RUGSoftEng/2018-PyDash.io/merges","archive_url":"https://api.github.com/repos/RUGSoftEng/2018-PyDash.io/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RUGSoftEng/2018-PyDash.io/downloads","issues_url":"https://api.github.com/repos/RUGSoftEng/2018-PyDash.io/issues{/number}","pulls_url":"https://api.github.com/repos/RUGSoftEng/2018-PyDash.io/pulls{/number}","milestones_url":"https://api.github.com/repos/RUGSoftEng/2018-PyDash.io/milestones{/number}","notifications_url":"https://api.github.com/repos/RUGSoftEng/2018-PyDash.io/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RUGSoftEng/2018-PyDash.io/labels{/name}","releases_url":"https://api.github.com/repos/RUGSoftEng/2018-PyDash.io/releases{/id}","deployments_url":"https://api.github.com/repos/RUGSoftEng/2018-PyDash.io/deployments","created_at":"2018-02-14T12:23:45Z","updated_at":"2018-05-16T18:56:01Z","pushed_at":"2018-05-19T13:34:26Z","git_url":"git://github.com/RUGSoftEng/2018-PyDash.io.git","ssh_url":"[email protected]:RUGSoftEng/2018-PyDash.io.git","clone_url":"https://github.com/RUGSoftEng/2018-PyDash.io.git","svn_url":"https://github.com/RUGSoftEng/2018-PyDash.io","homepage":null,"size":10328,"stargazers_count":4,"watchers_count":4,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":52,"license":null,"forks":1,"open_issues":52,"watchers":4,"default_branch":"development"}},"base":{"label":"RUGSoftEng:master","ref":"master","sha":"0edd8df974a384ccc31ff59659b20b9ed6e453c1","user":{"login":"RUGSoftEng","id":17049951,"avatar_url":"https://avatars3.githubusercontent.com/u/17049951?v=4","gravatar_id":"","url":"https://api.github.com/users/RUGSoftEng","html_url":"https://github.com/RUGSoftEng","followers_url":"https://api.github.com/users/RUGSoftEng/followers","following_url":"https://api.github.com/users/RUGSoftEng/following{/other_user}","gists_url":"https://api.github.com/users/RUGSoftEng/gists{/gist_id}","starred_url":"https://api.github.com/users/RUGSoftEng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RUGSoftEng/subscriptions","organizations_url":"https://api.github.com/users/RUGSoftEng/orgs","repos_url":"https://api.github.com/users/RUGSoftEng/repos","events_url":"https://api.github.com/users/RUGSoftEng/events{/privacy}","received_events_url":"https://api.github.com/users/RUGSoftEng/received_events","type":"Organization","site_admin":false},"repo":{"id":121507896,"name":"2018-PyDash.io","full_name":"RUGSoftEng/2018-PyDash.io","owner":{"login":"RUGSoftEng","id":17049951,"avatar_url":"https://avatars3.githubusercontent.com/u/17049951?v=4","gravatar_id":"","url":"https://api.github.com/users/RUGSoftEng","html_url":"https://github.com/RUGSoftEng","followers_url":"https://api.github.com/users/RUGSoftEng/followers","following_url":"https://api.github.com/users/RUGSoftEng/following{/other_user}","gists_url":"https://api.github.com/users/RUGSoftEng/gists{/gist_id}","starred_url":"https://api.github.com/users/RUGSoftEng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RUGSoftEng/subscriptions","organizations_url":"https://api.github.com/users/RUGSoftEng/orgs","repos_url":"https://api.github.com/users/RUGSoftEng/repos","events_url":"https://api.github.com/users/RUGSoftEng/events{/privacy}","received_events_url":"https://api.github.com/users/RUGSoftEng/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/RUGSoftEng/2018-PyDash.io","description":"A Flask Web-service for visualising Flask-Monitoring-Dashboards","fork":false,"url":"https://api.github.com/repos/RUGSoftEng/2018-PyDash.io","forks_url":"https://api.github.com/repos/RUGSoftEng/2018-PyDash.io/forks","keys_url":"https://api.github.com/repos/RUGSoftEng/2018-PyDash.io/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RUGSoftEng/2018-PyDash.io/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RUGSoftEng/2018-PyDash.io/teams","hooks_url":"https://api.github.com/repos/RUGSoftEng/2018-PyDash.io/hooks","issue_events_url":"https://api.github.com/repos/RUGSoftEng/2018-PyDash.io/issues/events{/number}","events_url":"https://api.github.com/repos/RUGSoftEng/2018-PyDash.io/events","assignees_url":"https://api.github.com/repos/RUGSoftEng/2018-PyDash.io/assignees{/user}","branches_url":"https://api.github.com/repos/RUGSoftEng/2018-PyDash.io/branches{/branch}","tags_url":"https://api.github.com/repos/RUGSoftEng/2018-PyDash.io/tags","blobs_url":"https://api.github.com/repos/RUGSoftEng/2018-PyDash.io/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RUGSoftEng/2018-PyDash.io/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RUGSoftEng/2018-PyDash.io/git/refs{/sha}","trees_url":"https://api.github.com/repos/RUGSoftEng/2018-PyDash.io/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RUGSoftEng/2018-PyDash.io/statuses/{sha}","languages_url":"https://api.github.com/repos/RUGSoftEng/2018-PyDash.io/languages","stargazers_url":"https://api.github.com/repos/RUGSoftEng/2018-PyDash.io/stargazers","contributors_url":"https://api.github.com/repos/RUGSoftEng/2018-PyDash.io/contributors","subscribers_url":"https://api.github.com/repos/RUGSoftEng/2018-PyDash.io/subscribers","subscription_url":"https://api.github.com/repos/RUGSoftEng/2018-PyDash.io/subscription","commits_url":"https://api.github.com/repos/RUGSoftEng/2018-PyDash.io/commits{/sha}","git_commits_url":"https://api.github.com/repos/RUGSoftEng/2018-PyDash.io/git/commits{/sha}","comments_url":"https://api.github.com/repos/RUGSoftEng/2018-PyDash.io/comments{/number}","issue_comment_url":"https://api.github.com/repos/RUGSoftEng/2018-PyDash.io/issues/comments{/number}","contents_url":"https://api.github.com/repos/RUGSoftEng/2018-PyDash.io/contents/{+path}","compare_url":"https://api.github.com/repos/RUGSoftEng/2018-PyDash.io/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RUGSoftEng/2018-PyDash.io/merges","archive_url":"https://api.github.com/repos/RUGSoftEng/2018-PyDash.io/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RUGSoftEng/2018-PyDash.io/downloads","issues_url":"https://api.github.com/repos/RUGSoftEng/2018-PyDash.io/issues{/number}","pulls_url":"https://api.github.com/repos/RUGSoftEng/2018-PyDash.io/pulls{/number}","milestones_url":"https://api.github.com/repos/RUGSoftEng/2018-PyDash.io/milestones{/number}","notifications_url":"https://api.github.com/repos/RUGSoftEng/2018-PyDash.io/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RUGSoftEng/2018-PyDash.io/labels{/name}","releases_url":"https://api.github.com/repos/RUGSoftEng/2018-PyDash.io/releases{/id}","deployments_url":"https://api.github.com/repos/RUGSoftEng/2018-PyDash.io/deployments","created_at":"2018-02-14T12:23:45Z","updated_at":"2018-05-16T18:56:01Z","pushed_at":"2018-05-19T13:34:26Z","git_url":"git://github.com/RUGSoftEng/2018-PyDash.io.git","ssh_url":"[email protected]:RUGSoftEng/2018-PyDash.io.git","clone_url":"https://github.com/RUGSoftEng/2018-PyDash.io.git","svn_url":"https://github.com/RUGSoftEng/2018-PyDash.io","homepage":null,"size":10328,"stargazers_count":4,"watchers_count":4,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":52,"license":null,"forks":1,"open_issues":52,"watchers":4,"default_branch":"development"}},"_links":{"self":{"href":"https://api.github.com/repos/RUGSoftEng/2018-PyDash.io/pulls/338"},"html":{"href":"https://github.com/RUGSoftEng/2018-PyDash.io/pull/338"},"issue":{"href":"https://api.github.com/repos/RUGSoftEng/2018-PyDash.io/issues/338"},"comments":{"href":"https://api.github.com/repos/RUGSoftEng/2018-PyDash.io/issues/338/comments"},"review_comments":{"href":"https://api.github.com/repos/RUGSoftEng/2018-PyDash.io/pulls/338/comments"},"review_comment":{"href":"https://api.github.com/repos/RUGSoftEng/2018-PyDash.io/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/RUGSoftEng/2018-PyDash.io/pulls/338/commits"},"statuses":{"href":"https://api.github.com/repos/RUGSoftEng/2018-PyDash.io/statuses/75c9b734d2ccb2ca1bb6b947af585e0212f04e60"}},"author_association":"COLLABORATOR"}} | {
"id": 121507896,
"name": "RUGSoftEng/2018-PyDash.io",
"url": "https://api.github.com/repos/RUGSoftEng/2018-PyDash.io"
} | {
"id": 26383724,
"login": "ArjanTilstra",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/26383724?",
"url": "https://api.github.com/users/ArjanTilstra"
} | {
"id": 17049951,
"login": "RUGSoftEng",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/17049951?",
"url": "https://api.github.com/orgs/RUGSoftEng"
} | 2018-05-19T13:35:06 | 7699514149 | {"actor":{"display_login":"ArjanTilstra"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/RUGSoftEng/2018-Hestia-IOS/pulls/comments/185010289","pull_request_review_id":116315685,"id":185010289,"diff_hunk":"@@ -14,7 +14,7 @@ public Device Deserialize(JToken jT, NetworkHandler networkHandler)\n // get id, name and type\n string id = jT.Value<string>(\"deviceId\");\n string name = jT.Value<string>(\"name\");\n- string type = jT.Value<string>(\"name\");\n+ string type = jT.Value<string>(\"type\");","path":"Hestia/Hestia/backend/models/deserializers/DeviceDeserializer.cs","position":5,"original_position":5,"commit_id":"81f75393f5ffb4062724c076982fc9dc5e9f937c","original_commit_id":"81f75393f5ffb4062724c076982fc9dc5e9f937c","user":{"login":"MarcF12","id":31476157,"avatar_url":"https://avatars3.githubusercontent.com/u/31476157?v=4","gravatar_id":"","url":"https://api.github.com/users/MarcF12","html_url":"https://github.com/MarcF12","followers_url":"https://api.github.com/users/MarcF12/followers","following_url":"https://api.github.com/users/MarcF12/following{/other_user}","gists_url":"https://api.github.com/users/MarcF12/gists{/gist_id}","starred_url":"https://api.github.com/users/MarcF12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarcF12/subscriptions","organizations_url":"https://api.github.com/users/MarcF12/orgs","repos_url":"https://api.github.com/users/MarcF12/repos","events_url":"https://api.github.com/users/MarcF12/events{/privacy}","received_events_url":"https://api.github.com/users/MarcF12/received_events","type":"User","site_admin":false},"body":"Did this have impact for the front end?","created_at":"2018-04-30T14:53:41Z","updated_at":"2018-04-30T14:53:41Z","html_url":"https://github.com/RUGSoftEng/2018-Hestia-IOS/pull/108#discussion_r185010289","pull_request_url":"https://api.github.com/repos/RUGSoftEng/2018-Hestia-IOS/pulls/108","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/RUGSoftEng/2018-Hestia-IOS/pulls/comments/185010289"},"html":{"href":"https://github.com/RUGSoftEng/2018-Hestia-IOS/pull/108#discussion_r185010289"},"pull_request":{"href":"https://api.github.com/repos/RUGSoftEng/2018-Hestia-IOS/pulls/108"}}},"pull_request":{"url":"https://api.github.com/repos/RUGSoftEng/2018-Hestia-IOS/pulls/108","id":184961705,"html_url":"https://github.com/RUGSoftEng/2018-Hestia-IOS/pull/108","diff_url":"https://github.com/RUGSoftEng/2018-Hestia-IOS/pull/108.diff","patch_url":"https://github.com/RUGSoftEng/2018-Hestia-IOS/pull/108.patch","issue_url":"https://api.github.com/repos/RUGSoftEng/2018-Hestia-IOS/issues/108","number":108,"state":"open","locked":false,"title":"Added unit tests for server interactor and fixed bug in device deserializer","user":{"login":"daangroot","id":22012675,"avatar_url":"https://avatars2.githubusercontent.com/u/22012675?v=4","gravatar_id":"","url":"https://api.github.com/users/daangroot","html_url":"https://github.com/daangroot","followers_url":"https://api.github.com/users/daangroot/followers","following_url":"https://api.github.com/users/daangroot/following{/other_user}","gists_url":"https://api.github.com/users/daangroot/gists{/gist_id}","starred_url":"https://api.github.com/users/daangroot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daangroot/subscriptions","organizations_url":"https://api.github.com/users/daangroot/orgs","repos_url":"https://api.github.com/users/daangroot/repos","events_url":"https://api.github.com/users/daangroot/events{/privacy}","received_events_url":"https://api.github.com/users/daangroot/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-04-30T13:51:56Z","updated_at":"2018-04-30T14:53:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"844d87a37dad9aaf9d031702206b51c4ef757e25","assignee":null,"assignees":[],"requested_reviewers":[{"login":"SinasAppel","id":17566646,"avatar_url":"https://avatars1.githubusercontent.com/u/17566646?v=4","gravatar_id":"","url":"https://api.github.com/users/SinasAppel","html_url":"https://github.com/SinasAppel","followers_url":"https://api.github.com/users/SinasAppel/followers","following_url":"https://api.github.com/users/SinasAppel/following{/other_user}","gists_url":"https://api.github.com/users/SinasAppel/gists{/gist_id}","starred_url":"https://api.github.com/users/SinasAppel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SinasAppel/subscriptions","organizations_url":"https://api.github.com/users/SinasAppel/orgs","repos_url":"https://api.github.com/users/SinasAppel/repos","events_url":"https://api.github.com/users/SinasAppel/events{/privacy}","received_events_url":"https://api.github.com/users/SinasAppel/received_events","type":"User","site_admin":false},{"login":"Mikmist","id":25775714,"avatar_url":"https://avatars2.githubusercontent.com/u/25775714?v=4","gravatar_id":"","url":"https://api.github.com/users/Mikmist","html_url":"https://github.com/Mikmist","followers_url":"https://api.github.com/users/Mikmist/followers","following_url":"https://api.github.com/users/Mikmist/following{/other_user}","gists_url":"https://api.github.com/users/Mikmist/gists{/gist_id}","starred_url":"https://api.github.com/users/Mikmist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mikmist/subscriptions","organizations_url":"https://api.github.com/users/Mikmist/orgs","repos_url":"https://api.github.com/users/Mikmist/repos","events_url":"https://api.github.com/users/Mikmist/events{/privacy}","received_events_url":"https://api.github.com/users/Mikmist/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/RUGSoftEng/2018-Hestia-IOS/pulls/108/commits","review_comments_url":"https://api.github.com/repos/RUGSoftEng/2018-Hestia-IOS/pulls/108/comments","review_comment_url":"https://api.github.com/repos/RUGSoftEng/2018-Hestia-IOS/pulls/comments{/number}","comments_url":"https://api.github.com/repos/RUGSoftEng/2018-Hestia-IOS/issues/108/comments","statuses_url":"https://api.github.com/repos/RUGSoftEng/2018-Hestia-IOS/statuses/81f75393f5ffb4062724c076982fc9dc5e9f937c","head":{"label":"RUGSoftEng:serverinteractor-testing","ref":"serverinteractor-testing","sha":"81f75393f5ffb4062724c076982fc9dc5e9f937c","user":{"login":"RUGSoftEng","id":17049951,"avatar_url":"https://avatars3.githubusercontent.com/u/17049951?v=4","gravatar_id":"","url":"https://api.github.com/users/RUGSoftEng","html_url":"https://github.com/RUGSoftEng","followers_url":"https://api.github.com/users/RUGSoftEng/followers","following_url":"https://api.github.com/users/RUGSoftEng/following{/other_user}","gists_url":"https://api.github.com/users/RUGSoftEng/gists{/gist_id}","starred_url":"https://api.github.com/users/RUGSoftEng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RUGSoftEng/subscriptions","organizations_url":"https://api.github.com/users/RUGSoftEng/orgs","repos_url":"https://api.github.com/users/RUGSoftEng/repos","events_url":"https://api.github.com/users/RUGSoftEng/events{/privacy}","received_events_url":"https://api.github.com/users/RUGSoftEng/received_events","type":"Organization","site_admin":false},"repo":{"id":121536309,"name":"2018-Hestia-IOS","full_name":"RUGSoftEng/2018-Hestia-IOS","owner":{"login":"RUGSoftEng","id":17049951,"avatar_url":"https://avatars3.githubusercontent.com/u/17049951?v=4","gravatar_id":"","url":"https://api.github.com/users/RUGSoftEng","html_url":"https://github.com/RUGSoftEng","followers_url":"https://api.github.com/users/RUGSoftEng/followers","following_url":"https://api.github.com/users/RUGSoftEng/following{/other_user}","gists_url":"https://api.github.com/users/RUGSoftEng/gists{/gist_id}","starred_url":"https://api.github.com/users/RUGSoftEng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RUGSoftEng/subscriptions","organizations_url":"https://api.github.com/users/RUGSoftEng/orgs","repos_url":"https://api.github.com/users/RUGSoftEng/repos","events_url":"https://api.github.com/users/RUGSoftEng/events{/privacy}","received_events_url":"https://api.github.com/users/RUGSoftEng/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/RUGSoftEng/2018-Hestia-IOS","description":null,"fork":false,"url":"https://api.github.com/repos/RUGSoftEng/2018-Hestia-IOS","forks_url":"https://api.github.com/repos/RUGSoftEng/2018-Hestia-IOS/forks","keys_url":"https://api.github.com/repos/RUGSoftEng/2018-Hestia-IOS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RUGSoftEng/2018-Hestia-IOS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RUGSoftEng/2018-Hestia-IOS/teams","hooks_url":"https://api.github.com/repos/RUGSoftEng/2018-Hestia-IOS/hooks","issue_events_url":"https://api.github.com/repos/RUGSoftEng/2018-Hestia-IOS/issues/events{/number}","events_url":"https://api.github.com/repos/RUGSoftEng/2018-Hestia-IOS/events","assignees_url":"https://api.github.com/repos/RUGSoftEng/2018-Hestia-IOS/assignees{/user}","branches_url":"https://api.github.com/repos/RUGSoftEng/2018-Hestia-IOS/branches{/branch}","tags_url":"https://api.github.com/repos/RUGSoftEng/2018-Hestia-IOS/tags","blobs_url":"https://api.github.com/repos/RUGSoftEng/2018-Hestia-IOS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RUGSoftEng/2018-Hestia-IOS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RUGSoftEng/2018-Hestia-IOS/git/refs{/sha}","trees_url":"https://api.github.com/repos/RUGSoftEng/2018-Hestia-IOS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RUGSoftEng/2018-Hestia-IOS/statuses/{sha}","languages_url":"https://api.github.com/repos/RUGSoftEng/2018-Hestia-IOS/languages","stargazers_url":"https://api.github.com/repos/RUGSoftEng/2018-Hestia-IOS/stargazers","contributors_url":"https://api.github.com/repos/RUGSoftEng/2018-Hestia-IOS/contributors","subscribers_url":"https://api.github.com/repos/RUGSoftEng/2018-Hestia-IOS/subscribers","subscription_url":"https://api.github.com/repos/RUGSoftEng/2018-Hestia-IOS/subscription","commits_url":"https://api.github.com/repos/RUGSoftEng/2018-Hestia-IOS/commits{/sha}","git_commits_url":"https://api.github.com/repos/RUGSoftEng/2018-Hestia-IOS/git/commits{/sha}","comments_url":"https://api.github.com/repos/RUGSoftEng/2018-Hestia-IOS/comments{/number}","issue_comment_url":"https://api.github.com/repos/RUGSoftEng/2018-Hestia-IOS/issues/comments{/number}","contents_url":"https://api.github.com/repos/RUGSoftEng/2018-Hestia-IOS/contents/{+path}","compare_url":"https://api.github.com/repos/RUGSoftEng/2018-Hestia-IOS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RUGSoftEng/2018-Hestia-IOS/merges","archive_url":"https://api.github.com/repos/RUGSoftEng/2018-Hestia-IOS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RUGSoftEng/2018-Hestia-IOS/downloads","issues_url":"https://api.github.com/repos/RUGSoftEng/2018-Hestia-IOS/issues{/number}","pulls_url":"https://api.github.com/repos/RUGSoftEng/2018-Hestia-IOS/pulls{/number}","milestones_url":"https://api.github.com/repos/RUGSoftEng/2018-Hestia-IOS/milestones{/number}","notifications_url":"https://api.github.com/repos/RUGSoftEng/2018-Hestia-IOS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RUGSoftEng/2018-Hestia-IOS/labels{/name}","releases_url":"https://api.github.com/repos/RUGSoftEng/2018-Hestia-IOS/releases{/id}","deployments_url":"https://api.github.com/repos/RUGSoftEng/2018-Hestia-IOS/deployments","created_at":"2018-02-14T16:56:13Z","updated_at":"2018-04-18T05:34:40Z","pushed_at":"2018-04-30T14:51:35Z","git_url":"git://github.com/RUGSoftEng/2018-Hestia-IOS.git","ssh_url":"[email protected]:RUGSoftEng/2018-Hestia-IOS.git","clone_url":"https://github.com/RUGSoftEng/2018-Hestia-IOS.git","svn_url":"https://github.com/RUGSoftEng/2018-Hestia-IOS","homepage":null,"size":11358,"stargazers_count":3,"watchers_count":3,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":null,"forks":0,"open_issues":2,"watchers":3,"default_branch":"master"}},"base":{"label":"RUGSoftEng:development","ref":"development","sha":"e529179a0fa9cb12023643f23e5d6edd8bd0b9a7","user":{"login":"RUGSoftEng","id":17049951,"avatar_url":"https://avatars3.githubusercontent.com/u/17049951?v=4","gravatar_id":"","url":"https://api.github.com/users/RUGSoftEng","html_url":"https://github.com/RUGSoftEng","followers_url":"https://api.github.com/users/RUGSoftEng/followers","following_url":"https://api.github.com/users/RUGSoftEng/following{/other_user}","gists_url":"https://api.github.com/users/RUGSoftEng/gists{/gist_id}","starred_url":"https://api.github.com/users/RUGSoftEng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RUGSoftEng/subscriptions","organizations_url":"https://api.github.com/users/RUGSoftEng/orgs","repos_url":"https://api.github.com/users/RUGSoftEng/repos","events_url":"https://api.github.com/users/RUGSoftEng/events{/privacy}","received_events_url":"https://api.github.com/users/RUGSoftEng/received_events","type":"Organization","site_admin":false},"repo":{"id":121536309,"name":"2018-Hestia-IOS","full_name":"RUGSoftEng/2018-Hestia-IOS","owner":{"login":"RUGSoftEng","id":17049951,"avatar_url":"https://avatars3.githubusercontent.com/u/17049951?v=4","gravatar_id":"","url":"https://api.github.com/users/RUGSoftEng","html_url":"https://github.com/RUGSoftEng","followers_url":"https://api.github.com/users/RUGSoftEng/followers","following_url":"https://api.github.com/users/RUGSoftEng/following{/other_user}","gists_url":"https://api.github.com/users/RUGSoftEng/gists{/gist_id}","starred_url":"https://api.github.com/users/RUGSoftEng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RUGSoftEng/subscriptions","organizations_url":"https://api.github.com/users/RUGSoftEng/orgs","repos_url":"https://api.github.com/users/RUGSoftEng/repos","events_url":"https://api.github.com/users/RUGSoftEng/events{/privacy}","received_events_url":"https://api.github.com/users/RUGSoftEng/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/RUGSoftEng/2018-Hestia-IOS","description":null,"fork":false,"url":"https://api.github.com/repos/RUGSoftEng/2018-Hestia-IOS","forks_url":"https://api.github.com/repos/RUGSoftEng/2018-Hestia-IOS/forks","keys_url":"https://api.github.com/repos/RUGSoftEng/2018-Hestia-IOS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RUGSoftEng/2018-Hestia-IOS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RUGSoftEng/2018-Hestia-IOS/teams","hooks_url":"https://api.github.com/repos/RUGSoftEng/2018-Hestia-IOS/hooks","issue_events_url":"https://api.github.com/repos/RUGSoftEng/2018-Hestia-IOS/issues/events{/number}","events_url":"https://api.github.com/repos/RUGSoftEng/2018-Hestia-IOS/events","assignees_url":"https://api.github.com/repos/RUGSoftEng/2018-Hestia-IOS/assignees{/user}","branches_url":"https://api.github.com/repos/RUGSoftEng/2018-Hestia-IOS/branches{/branch}","tags_url":"https://api.github.com/repos/RUGSoftEng/2018-Hestia-IOS/tags","blobs_url":"https://api.github.com/repos/RUGSoftEng/2018-Hestia-IOS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RUGSoftEng/2018-Hestia-IOS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RUGSoftEng/2018-Hestia-IOS/git/refs{/sha}","trees_url":"https://api.github.com/repos/RUGSoftEng/2018-Hestia-IOS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RUGSoftEng/2018-Hestia-IOS/statuses/{sha}","languages_url":"https://api.github.com/repos/RUGSoftEng/2018-Hestia-IOS/languages","stargazers_url":"https://api.github.com/repos/RUGSoftEng/2018-Hestia-IOS/stargazers","contributors_url":"https://api.github.com/repos/RUGSoftEng/2018-Hestia-IOS/contributors","subscribers_url":"https://api.github.com/repos/RUGSoftEng/2018-Hestia-IOS/subscribers","subscription_url":"https://api.github.com/repos/RUGSoftEng/2018-Hestia-IOS/subscription","commits_url":"https://api.github.com/repos/RUGSoftEng/2018-Hestia-IOS/commits{/sha}","git_commits_url":"https://api.github.com/repos/RUGSoftEng/2018-Hestia-IOS/git/commits{/sha}","comments_url":"https://api.github.com/repos/RUGSoftEng/2018-Hestia-IOS/comments{/number}","issue_comment_url":"https://api.github.com/repos/RUGSoftEng/2018-Hestia-IOS/issues/comments{/number}","contents_url":"https://api.github.com/repos/RUGSoftEng/2018-Hestia-IOS/contents/{+path}","compare_url":"https://api.github.com/repos/RUGSoftEng/2018-Hestia-IOS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RUGSoftEng/2018-Hestia-IOS/merges","archive_url":"https://api.github.com/repos/RUGSoftEng/2018-Hestia-IOS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RUGSoftEng/2018-Hestia-IOS/downloads","issues_url":"https://api.github.com/repos/RUGSoftEng/2018-Hestia-IOS/issues{/number}","pulls_url":"https://api.github.com/repos/RUGSoftEng/2018-Hestia-IOS/pulls{/number}","milestones_url":"https://api.github.com/repos/RUGSoftEng/2018-Hestia-IOS/milestones{/number}","notifications_url":"https://api.github.com/repos/RUGSoftEng/2018-Hestia-IOS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RUGSoftEng/2018-Hestia-IOS/labels{/name}","releases_url":"https://api.github.com/repos/RUGSoftEng/2018-Hestia-IOS/releases{/id}","deployments_url":"https://api.github.com/repos/RUGSoftEng/2018-Hestia-IOS/deployments","created_at":"2018-02-14T16:56:13Z","updated_at":"2018-04-18T05:34:40Z","pushed_at":"2018-04-30T14:51:35Z","git_url":"git://github.com/RUGSoftEng/2018-Hestia-IOS.git","ssh_url":"[email protected]:RUGSoftEng/2018-Hestia-IOS.git","clone_url":"https://github.com/RUGSoftEng/2018-Hestia-IOS.git","svn_url":"https://github.com/RUGSoftEng/2018-Hestia-IOS","homepage":null,"size":11358,"stargazers_count":3,"watchers_count":3,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":null,"forks":0,"open_issues":2,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/RUGSoftEng/2018-Hestia-IOS/pulls/108"},"html":{"href":"https://github.com/RUGSoftEng/2018-Hestia-IOS/pull/108"},"issue":{"href":"https://api.github.com/repos/RUGSoftEng/2018-Hestia-IOS/issues/108"},"comments":{"href":"https://api.github.com/repos/RUGSoftEng/2018-Hestia-IOS/issues/108/comments"},"review_comments":{"href":"https://api.github.com/repos/RUGSoftEng/2018-Hestia-IOS/pulls/108/comments"},"review_comment":{"href":"https://api.github.com/repos/RUGSoftEng/2018-Hestia-IOS/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/RUGSoftEng/2018-Hestia-IOS/pulls/108/commits"},"statuses":{"href":"https://api.github.com/repos/RUGSoftEng/2018-Hestia-IOS/statuses/81f75393f5ffb4062724c076982fc9dc5e9f937c"}},"author_association":"COLLABORATOR"}} | {
"id": 121536309,
"name": "RUGSoftEng/2018-Hestia-IOS",
"url": "https://api.github.com/repos/RUGSoftEng/2018-Hestia-IOS"
} | {
"id": 31476157,
"login": "MarcF12",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/31476157?",
"url": "https://api.github.com/users/MarcF12"
} | {
"id": 17049951,
"login": "RUGSoftEng",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/17049951?",
"url": "https://api.github.com/orgs/RUGSoftEng"
} | 2018-04-30T14:53:41 | 7606925815 | {"actor":{"display_login":"MarcF12"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/bigchaindb/BEPs/pulls/comments/217676049","pull_request_review_id":155447058,"id":217676049,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNzY3NjA0OQ==","diff_hunk":"@@ -0,0 +1,283 @@\n+```\n+shortname: BEP-23\n+name: Performance Study: Analysis of Transaction Throughput in a BigchainDB Network\n+type: Informational\n+status: Raw\n+editor: Alberto Granzotto <[email protected]>\n+contributors: Troy McConaghy <[email protected]>, Muawia Khan <[email protected]>\n+```\n+\n+# Performance Study: Analysis of Transaction Throughput in a BigchainDB Network\n+\n+## Abstract\n+Transaction throughput is a key metric to evaluate the suitability of a blockchain system for real world applications. BigchainDB is now in its beta phase, and we don't expect major changes in the parts of the code that are responsible for the throughput of the system (i.e. the validation logic), for this reason we can now run performance tests and publish our results. The tested setup consists of a 4 node network running a [recent version of BigchainDB][bdb:git-commit]. Each node runs on a different virtual machine, hosted in the [Azure infrastructure][azure:landing-page]. A fifth virtual machine is used to generate the workload and collect metrics. Depending on the configuration of the system, the tested BigchainDB network, under constant load, finalizes between 300 and 1000 transactions per second.\n+\n+## Introduction\n+Blockchain systems are currently under heavy research and development. Different projects have different definitions of what a blockchain is—or should be.\n+Given that there is no standard definition of *blockchain* (as there is, for example, for relational database management systems), no formal definitions of metrics exist, and no formal *benchmarking software suite* can be applied across different blockchain systems. Still, we can find concepts that are valid across multiple systems; a transaction, for example, goes through different states during its lifetime such as:\n+\n+- **Accepted** by the network. In order to be accepted, a transaction must be \"valid,\" where the definition of valid varies from network to network.\n+- **Committed** in the blockchain. If a transaction makes it into a block, it is stored together with other transactions in the local database of the node.\n+- **Finalized**. Finality means that once a transaction is committed, it cannot be reversed, i.e. the data cannot be rolled back to the previous state. Different blockchain systems may provide different types of finality. Typically, this is defined in the consensus protocol. Different types of consensus exist, such as voting-based consensus with immediate finality and lottery-based consensus with probabilistic finality. (Definition from the [Hyperledger Performance and Scale Working Group][hl:finality].) For BigchainDB, once a transaction is committed it is also finalized.\n+\n+Note that BigchainDB inherits Tendermint **instant finality**. This means that as soon as a new block is committed, it cannot be reversed. Through this document, we won't make any distinction between a *committed* transaction and a *finalized* transaction. For clarity, we will always prefer the term *finalized*.\n+\n+Given that, the metrics we measured in our experiments are:\n+\n+- Transaction acceptance rate.\n+- Transaction finalization rate.\n+- Time to accept a transaction (how much time it takes for a valid transaction to be stored in the mempool).\n+- Time to finalize a transaction (how much time it takes for a valid transaction to be stored in the blockchain).\n+\n+Those metrics reflect the different states of a valid transaction: accepted and finalized.\n+\n+Even if the reference metric is how many transactions the network finalizes per second, during this analysis we dig deeper and analyze the distribution on accepted transactions, committed etc. We want to make sure that the system is responsive most of the time, and we don't want to get fooled by an average that hides a lot of data behind it. Knowing the actual distribution of how much time it takes for a transaction to be accepted and then committed allows us to have a clear understanding of the responsiveness of the system, and this is something we won't know if we look only at the average. For this reason we developed our own tool, `bigchaindb-benchmark`.\n+[BigchainDB Benchmark][bdb:benchmark-tool] is the tool we developed to generate the workload and collect statistics. It can simulate a large amount of workload by spawning multiple processes, and output a CSV file to timestamp the different steps in the life cycle of a transaction. This allows us to measure the distribution of how long it takes for a transaction to be accepted and later finalized.\n+We also run other tests using a customized version of [`tm-bench`][tm:tm-bench].\n+\n+Another thing to consider is that BigchainDB is a multi-asset blockchain. With BigchainDB, users can create their own custom assets. Each new asset is identified by a unique value, that is the `id` of the `CREATE` transaction that minted it. Assets have their own unique history or—in more precise terms—directed acyclic graph. In order to check if a transaction is a double spend, we can safely ignore all transactions related to other assets. This means that when BigchainDB has to validate a block, it can parallelize validation, exploiting all cores in the current machine (more details to come). To understand if we could get a performance boost out of this, we integrated a new experimental feature that enables parallel validation of transactions. This feature is a proof of concept to show that higher throughput is realizable. Note: this feature skips also *Check Tx*, used by Tendermint to check a transaction before storing it in the mempool. BigchainDB validates transactions as soon as they are posted to the HTTP API, so *Check Tx* in this case is redundant. We must mention that *Check Tx* is used also to validate transactions coming from the other nodes of the network, so disabling it might allow byzantine actors to push invalid transactions to the mempool (handling invalid transactions is [actively discussed in the Tendermint issue tracker][tm:invalid-txs]). Even if an invalid transaction makes it to the mempool, it will be always discarded during the *Deliver Tx* phase, so this experimental feature will still maintain a correct state of the application. Parallel validation is an optimistic approach that will be eventually developed for specific production use cases.\n+\n+## Methods\n+<!--\n+METHODS. The methods section will help you determine exactly how the authors performed the experiment.\n+\n+The methods describes both specific techniques and the overall experimental strategy used by the scientists. Generally, the methods section does not need to be read in detail. Refer to this section if you have a specific question about the experimental design.\n+-->\n+\n+The performance tests were run on the Microsoft Azure cloud infrastructure. For the BigchainDB nodes, we choose compute optimized virtual machines from the [Fsv2 series][azure:fsv2], specifically *Standard F32s v2* (32 vCPUs, 64GiB memory, SSD drives with estimated IOPS limit of 5000). For the machine generating the workload, we used a *Standard F8s v2* (8 vCPUs, 16GiB memory). The virtual machines were all in the same datacenter.","path":"23/README.md","position":47,"original_position":47,"commit_id":"c6a661ae5895c12ca4e6a584a9ea2d4884967f6d","original_commit_id":"c6a661ae5895c12ca4e6a584a9ea2d4884967f6d","user":{"login":"vrde","id":134680,"node_id":"MDQ6VXNlcjEzNDY4MA==","avatar_url":"https://avatars1.githubusercontent.com/u/134680?v=4","gravatar_id":"","url":"https://api.github.com/users/vrde","html_url":"https://github.com/vrde","followers_url":"https://api.github.com/users/vrde/followers","following_url":"https://api.github.com/users/vrde/following{/other_user}","gists_url":"https://api.github.com/users/vrde/gists{/gist_id}","starred_url":"https://api.github.com/users/vrde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vrde/subscriptions","organizations_url":"https://api.github.com/users/vrde/orgs","repos_url":"https://api.github.com/users/vrde/repos","events_url":"https://api.github.com/users/vrde/events{/privacy}","received_events_url":"https://api.github.com/users/vrde/received_events","type":"User","site_admin":false},"body":"About the IOPS of the disk, I used the data coming from portal.azure.com... Not sure why they have two different numbers, check this screenshot:\r\n\r\n\r\n\r\nI'll make the suggested changes.","created_at":"2018-09-14T10:58:44Z","updated_at":"2018-09-14T10:58:45Z","html_url":"https://github.com/bigchaindb/BEPs/pull/85#discussion_r217676049","pull_request_url":"https://api.github.com/repos/bigchaindb/BEPs/pulls/85","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/bigchaindb/BEPs/pulls/comments/217676049"},"html":{"href":"https://github.com/bigchaindb/BEPs/pull/85#discussion_r217676049"},"pull_request":{"href":"https://api.github.com/repos/bigchaindb/BEPs/pulls/85"}},"in_reply_to_id":217666040},"pull_request":{"url":"https://api.github.com/repos/bigchaindb/BEPs/pulls/85","id":215514233,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1NTE0MjMz","html_url":"https://github.com/bigchaindb/BEPs/pull/85","diff_url":"https://github.com/bigchaindb/BEPs/pull/85.diff","patch_url":"https://github.com/bigchaindb/BEPs/pull/85.patch","issue_url":"https://api.github.com/repos/bigchaindb/BEPs/issues/85","number":85,"state":"open","locked":false,"title":"Problem: there is no performance analysis of bdb","user":{"login":"vrde","id":134680,"node_id":"MDQ6VXNlcjEzNDY4MA==","avatar_url":"https://avatars1.githubusercontent.com/u/134680?v=4","gravatar_id":"","url":"https://api.github.com/users/vrde","html_url":"https://github.com/vrde","followers_url":"https://api.github.com/users/vrde/followers","following_url":"https://api.github.com/users/vrde/following{/other_user}","gists_url":"https://api.github.com/users/vrde/gists{/gist_id}","starred_url":"https://api.github.com/users/vrde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vrde/subscriptions","organizations_url":"https://api.github.com/users/vrde/orgs","repos_url":"https://api.github.com/users/vrde/repos","events_url":"https://api.github.com/users/vrde/events{/privacy}","received_events_url":"https://api.github.com/users/vrde/received_events","type":"User","site_admin":false},"body":"Solution: run some performance tests and write a report about it.","created_at":"2018-09-14T08:11:20Z","updated_at":"2018-09-14T10:58:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"aa9bd047f75eead481a014468c18ff5527019127","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/bigchaindb/BEPs/pulls/85/commits","review_comments_url":"https://api.github.com/repos/bigchaindb/BEPs/pulls/85/comments","review_comment_url":"https://api.github.com/repos/bigchaindb/BEPs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bigchaindb/BEPs/issues/85/comments","statuses_url":"https://api.github.com/repos/bigchaindb/BEPs/statuses/c6a661ae5895c12ca4e6a584a9ea2d4884967f6d","head":{"label":"vrde:bep-performance","ref":"bep-performance","sha":"c6a661ae5895c12ca4e6a584a9ea2d4884967f6d","user":{"login":"vrde","id":134680,"node_id":"MDQ6VXNlcjEzNDY4MA==","avatar_url":"https://avatars1.githubusercontent.com/u/134680?v=4","gravatar_id":"","url":"https://api.github.com/users/vrde","html_url":"https://github.com/vrde","followers_url":"https://api.github.com/users/vrde/followers","following_url":"https://api.github.com/users/vrde/following{/other_user}","gists_url":"https://api.github.com/users/vrde/gists{/gist_id}","starred_url":"https://api.github.com/users/vrde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vrde/subscriptions","organizations_url":"https://api.github.com/users/vrde/orgs","repos_url":"https://api.github.com/users/vrde/repos","events_url":"https://api.github.com/users/vrde/events{/privacy}","received_events_url":"https://api.github.com/users/vrde/received_events","type":"User","site_admin":false},"repo":{"id":120628361,"node_id":"MDEwOlJlcG9zaXRvcnkxMjA2MjgzNjE=","name":"bigchaindb-beps","full_name":"vrde/bigchaindb-beps","owner":{"login":"vrde","id":134680,"node_id":"MDQ6VXNlcjEzNDY4MA==","avatar_url":"https://avatars1.githubusercontent.com/u/134680?v=4","gravatar_id":"","url":"https://api.github.com/users/vrde","html_url":"https://github.com/vrde","followers_url":"https://api.github.com/users/vrde/followers","following_url":"https://api.github.com/users/vrde/following{/other_user}","gists_url":"https://api.github.com/users/vrde/gists{/gist_id}","starred_url":"https://api.github.com/users/vrde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vrde/subscriptions","organizations_url":"https://api.github.com/users/vrde/orgs","repos_url":"https://api.github.com/users/vrde/repos","events_url":"https://api.github.com/users/vrde/events{/privacy}","received_events_url":"https://api.github.com/users/vrde/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vrde/bigchaindb-beps","description":"BigchainDB Enhancement Proposals","fork":true,"url":"https://api.github.com/repos/vrde/bigchaindb-beps","forks_url":"https://api.github.com/repos/vrde/bigchaindb-beps/forks","keys_url":"https://api.github.com/repos/vrde/bigchaindb-beps/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vrde/bigchaindb-beps/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vrde/bigchaindb-beps/teams","hooks_url":"https://api.github.com/repos/vrde/bigchaindb-beps/hooks","issue_events_url":"https://api.github.com/repos/vrde/bigchaindb-beps/issues/events{/number}","events_url":"https://api.github.com/repos/vrde/bigchaindb-beps/events","assignees_url":"https://api.github.com/repos/vrde/bigchaindb-beps/assignees{/user}","branches_url":"https://api.github.com/repos/vrde/bigchaindb-beps/branches{/branch}","tags_url":"https://api.github.com/repos/vrde/bigchaindb-beps/tags","blobs_url":"https://api.github.com/repos/vrde/bigchaindb-beps/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vrde/bigchaindb-beps/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vrde/bigchaindb-beps/git/refs{/sha}","trees_url":"https://api.github.com/repos/vrde/bigchaindb-beps/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vrde/bigchaindb-beps/statuses/{sha}","languages_url":"https://api.github.com/repos/vrde/bigchaindb-beps/languages","stargazers_url":"https://api.github.com/repos/vrde/bigchaindb-beps/stargazers","contributors_url":"https://api.github.com/repos/vrde/bigchaindb-beps/contributors","subscribers_url":"https://api.github.com/repos/vrde/bigchaindb-beps/subscribers","subscription_url":"https://api.github.com/repos/vrde/bigchaindb-beps/subscription","commits_url":"https://api.github.com/repos/vrde/bigchaindb-beps/commits{/sha}","git_commits_url":"https://api.github.com/repos/vrde/bigchaindb-beps/git/commits{/sha}","comments_url":"https://api.github.com/repos/vrde/bigchaindb-beps/comments{/number}","issue_comment_url":"https://api.github.com/repos/vrde/bigchaindb-beps/issues/comments{/number}","contents_url":"https://api.github.com/repos/vrde/bigchaindb-beps/contents/{+path}","compare_url":"https://api.github.com/repos/vrde/bigchaindb-beps/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vrde/bigchaindb-beps/merges","archive_url":"https://api.github.com/repos/vrde/bigchaindb-beps/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vrde/bigchaindb-beps/downloads","issues_url":"https://api.github.com/repos/vrde/bigchaindb-beps/issues{/number}","pulls_url":"https://api.github.com/repos/vrde/bigchaindb-beps/pulls{/number}","milestones_url":"https://api.github.com/repos/vrde/bigchaindb-beps/milestones{/number}","notifications_url":"https://api.github.com/repos/vrde/bigchaindb-beps/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vrde/bigchaindb-beps/labels{/name}","releases_url":"https://api.github.com/repos/vrde/bigchaindb-beps/releases{/id}","deployments_url":"https://api.github.com/repos/vrde/bigchaindb-beps/deployments","created_at":"2018-02-07T14:51:34Z","updated_at":"2018-07-18T13:21:46Z","pushed_at":"2018-09-14T09:33:20Z","git_url":"git://github.com/vrde/bigchaindb-beps.git","ssh_url":"[email protected]:vrde/bigchaindb-beps.git","clone_url":"https://github.com/vrde/bigchaindb-beps.git","svn_url":"https://github.com/vrde/bigchaindb-beps","homepage":"","size":1259,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bigchaindb:master","ref":"master","sha":"54497e84f5ce90435cb154082a012803338bf4fb","user":{"login":"bigchaindb","id":17097586,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3MDk3NTg2","avatar_url":"https://avatars0.githubusercontent.com/u/17097586?v=4","gravatar_id":"","url":"https://api.github.com/users/bigchaindb","html_url":"https://github.com/bigchaindb","followers_url":"https://api.github.com/users/bigchaindb/followers","following_url":"https://api.github.com/users/bigchaindb/following{/other_user}","gists_url":"https://api.github.com/users/bigchaindb/gists{/gist_id}","starred_url":"https://api.github.com/users/bigchaindb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bigchaindb/subscriptions","organizations_url":"https://api.github.com/users/bigchaindb/orgs","repos_url":"https://api.github.com/users/bigchaindb/repos","events_url":"https://api.github.com/users/bigchaindb/events{/privacy}","received_events_url":"https://api.github.com/users/bigchaindb/received_events","type":"Organization","site_admin":false},"repo":{"id":120627608,"node_id":"MDEwOlJlcG9zaXRvcnkxMjA2Mjc2MDg=","name":"BEPs","full_name":"bigchaindb/BEPs","owner":{"login":"bigchaindb","id":17097586,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3MDk3NTg2","avatar_url":"https://avatars0.githubusercontent.com/u/17097586?v=4","gravatar_id":"","url":"https://api.github.com/users/bigchaindb","html_url":"https://github.com/bigchaindb","followers_url":"https://api.github.com/users/bigchaindb/followers","following_url":"https://api.github.com/users/bigchaindb/following{/other_user}","gists_url":"https://api.github.com/users/bigchaindb/gists{/gist_id}","starred_url":"https://api.github.com/users/bigchaindb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bigchaindb/subscriptions","organizations_url":"https://api.github.com/users/bigchaindb/orgs","repos_url":"https://api.github.com/users/bigchaindb/repos","events_url":"https://api.github.com/users/bigchaindb/events{/privacy}","received_events_url":"https://api.github.com/users/bigchaindb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bigchaindb/BEPs","description":" BigchainDB Enhancement Proposals","fork":false,"url":"https://api.github.com/repos/bigchaindb/BEPs","forks_url":"https://api.github.com/repos/bigchaindb/BEPs/forks","keys_url":"https://api.github.com/repos/bigchaindb/BEPs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bigchaindb/BEPs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bigchaindb/BEPs/teams","hooks_url":"https://api.github.com/repos/bigchaindb/BEPs/hooks","issue_events_url":"https://api.github.com/repos/bigchaindb/BEPs/issues/events{/number}","events_url":"https://api.github.com/repos/bigchaindb/BEPs/events","assignees_url":"https://api.github.com/repos/bigchaindb/BEPs/assignees{/user}","branches_url":"https://api.github.com/repos/bigchaindb/BEPs/branches{/branch}","tags_url":"https://api.github.com/repos/bigchaindb/BEPs/tags","blobs_url":"https://api.github.com/repos/bigchaindb/BEPs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bigchaindb/BEPs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bigchaindb/BEPs/git/refs{/sha}","trees_url":"https://api.github.com/repos/bigchaindb/BEPs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bigchaindb/BEPs/statuses/{sha}","languages_url":"https://api.github.com/repos/bigchaindb/BEPs/languages","stargazers_url":"https://api.github.com/repos/bigchaindb/BEPs/stargazers","contributors_url":"https://api.github.com/repos/bigchaindb/BEPs/contributors","subscribers_url":"https://api.github.com/repos/bigchaindb/BEPs/subscribers","subscription_url":"https://api.github.com/repos/bigchaindb/BEPs/subscription","commits_url":"https://api.github.com/repos/bigchaindb/BEPs/commits{/sha}","git_commits_url":"https://api.github.com/repos/bigchaindb/BEPs/git/commits{/sha}","comments_url":"https://api.github.com/repos/bigchaindb/BEPs/comments{/number}","issue_comment_url":"https://api.github.com/repos/bigchaindb/BEPs/issues/comments{/number}","contents_url":"https://api.github.com/repos/bigchaindb/BEPs/contents/{+path}","compare_url":"https://api.github.com/repos/bigchaindb/BEPs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bigchaindb/BEPs/merges","archive_url":"https://api.github.com/repos/bigchaindb/BEPs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bigchaindb/BEPs/downloads","issues_url":"https://api.github.com/repos/bigchaindb/BEPs/issues{/number}","pulls_url":"https://api.github.com/repos/bigchaindb/BEPs/pulls{/number}","milestones_url":"https://api.github.com/repos/bigchaindb/BEPs/milestones{/number}","notifications_url":"https://api.github.com/repos/bigchaindb/BEPs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bigchaindb/BEPs/labels{/name}","releases_url":"https://api.github.com/repos/bigchaindb/BEPs/releases{/id}","deployments_url":"https://api.github.com/repos/bigchaindb/BEPs/deployments","created_at":"2018-02-07T14:45:22Z","updated_at":"2018-09-14T08:13:38Z","pushed_at":"2018-09-14T10:31:02Z","git_url":"git://github.com/bigchaindb/BEPs.git","ssh_url":"[email protected]:bigchaindb/BEPs.git","clone_url":"https://github.com/bigchaindb/BEPs.git","svn_url":"https://github.com/bigchaindb/BEPs","homepage":"","size":1060,"stargazers_count":14,"watchers_count":14,"language":"Shell","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":16,"mirror_url":null,"archived":false,"open_issues_count":15,"license":null,"forks":16,"open_issues":15,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bigchaindb/BEPs/pulls/85"},"html":{"href":"https://github.com/bigchaindb/BEPs/pull/85"},"issue":{"href":"https://api.github.com/repos/bigchaindb/BEPs/issues/85"},"comments":{"href":"https://api.github.com/repos/bigchaindb/BEPs/issues/85/comments"},"review_comments":{"href":"https://api.github.com/repos/bigchaindb/BEPs/pulls/85/comments"},"review_comment":{"href":"https://api.github.com/repos/bigchaindb/BEPs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bigchaindb/BEPs/pulls/85/commits"},"statuses":{"href":"https://api.github.com/repos/bigchaindb/BEPs/statuses/c6a661ae5895c12ca4e6a584a9ea2d4884967f6d"}},"author_association":"CONTRIBUTOR"}} | {
"id": 120627608,
"name": "bigchaindb/BEPs",
"url": "https://api.github.com/repos/bigchaindb/BEPs"
} | {
"id": 134680,
"login": "vrde",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/134680?",
"url": "https://api.github.com/users/vrde"
} | {
"id": 17097586,
"login": "bigchaindb",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/17097586?",
"url": "https://api.github.com/orgs/bigchaindb"
} | 2018-09-14T10:58:44 | 8265394128 | {"actor":{"display_login":"vrde"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/bigchaindb/bigchaindb/pulls/comments/187897040","pull_request_review_id":119766133,"id":187897040,"diff_hunk":"@@ -5,4 +5,4 @@ RUN pip install --upgrade \\\n \tpycco \\\n \twebsocket-client~=0.47.0 \\\n \tpytest~=3.0 \\\n-\tbigchaindb-driver==0.5.0a2\n+\tbigchaindb-driver==0.5.0a4","path":"acceptance/python/Dockerfile","position":5,"original_position":5,"commit_id":"337a344e8a045e511e881d5a2fa8c634e653884c","original_commit_id":"337a344e8a045e511e881d5a2fa8c634e653884c","user":{"login":"ttmc","id":1210951,"avatar_url":"https://avatars1.githubusercontent.com/u/1210951?v=4","gravatar_id":"","url":"https://api.github.com/users/ttmc","html_url":"https://github.com/ttmc","followers_url":"https://api.github.com/users/ttmc/followers","following_url":"https://api.github.com/users/ttmc/following{/other_user}","gists_url":"https://api.github.com/users/ttmc/gists{/gist_id}","starred_url":"https://api.github.com/users/ttmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ttmc/subscriptions","organizations_url":"https://api.github.com/users/ttmc/orgs","repos_url":"https://api.github.com/users/ttmc/repos","events_url":"https://api.github.com/users/ttmc/events{/privacy}","received_events_url":"https://api.github.com/users/ttmc/received_events","type":"User","site_admin":false},"body":"If the driver had its own release process document, we could put a task in that, but it doesn't have one. However, there _is_ an open issue to create one. I'll add a comment to that issue, noting that the process should include updating this line in the bigchaindb/bigchaindb repo.","created_at":"2018-05-14T09:59:47Z","updated_at":"2018-05-14T09:59:47Z","html_url":"https://github.com/bigchaindb/bigchaindb/pull/2282#discussion_r187897040","pull_request_url":"https://api.github.com/repos/bigchaindb/bigchaindb/pulls/2282","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/bigchaindb/bigchaindb/pulls/comments/187897040"},"html":{"href":"https://github.com/bigchaindb/bigchaindb/pull/2282#discussion_r187897040"},"pull_request":{"href":"https://api.github.com/repos/bigchaindb/bigchaindb/pulls/2282"}},"in_reply_to_id":187564591},"pull_request":{"url":"https://api.github.com/repos/bigchaindb/bigchaindb/pulls/2282","id":187404948,"html_url":"https://github.com/bigchaindb/bigchaindb/pull/2282","diff_url":"https://github.com/bigchaindb/bigchaindb/pull/2282.diff","patch_url":"https://github.com/bigchaindb/bigchaindb/pull/2282.patch","issue_url":"https://api.github.com/repos/bigchaindb/bigchaindb/issues/2282","number":2282,"state":"open","locked":false,"title":"Problem: acceptance tests are using old pydriver","user":{"login":"vrde","id":134680,"avatar_url":"https://avatars1.githubusercontent.com/u/134680?v=4","gravatar_id":"","url":"https://api.github.com/users/vrde","html_url":"https://github.com/vrde","followers_url":"https://api.github.com/users/vrde/followers","following_url":"https://api.github.com/users/vrde/following{/other_user}","gists_url":"https://api.github.com/users/vrde/gists{/gist_id}","starred_url":"https://api.github.com/users/vrde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vrde/subscriptions","organizations_url":"https://api.github.com/users/vrde/orgs","repos_url":"https://api.github.com/users/vrde/repos","events_url":"https://api.github.com/users/vrde/events{/privacy}","received_events_url":"https://api.github.com/users/vrde/received_events","type":"User","site_admin":false},"body":"Solution: update to the new driver version, and simplify the code removing the `mode` parameter.","created_at":"2018-05-11T08:57:29Z","updated_at":"2018-05-14T09:59:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c4ee076daab4fcfc76bbdcfcd962d1a7624620b6","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/bigchaindb/bigchaindb/pulls/2282/commits","review_comments_url":"https://api.github.com/repos/bigchaindb/bigchaindb/pulls/2282/comments","review_comment_url":"https://api.github.com/repos/bigchaindb/bigchaindb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bigchaindb/bigchaindb/issues/2282/comments","statuses_url":"https://api.github.com/repos/bigchaindb/bigchaindb/statuses/337a344e8a045e511e881d5a2fa8c634e653884c","head":{"label":"vrde:update-acceptance-to-driver-alpha4","ref":"update-acceptance-to-driver-alpha4","sha":"337a344e8a045e511e881d5a2fa8c634e653884c","user":{"login":"vrde","id":134680,"avatar_url":"https://avatars1.githubusercontent.com/u/134680?v=4","gravatar_id":"","url":"https://api.github.com/users/vrde","html_url":"https://github.com/vrde","followers_url":"https://api.github.com/users/vrde/followers","following_url":"https://api.github.com/users/vrde/following{/other_user}","gists_url":"https://api.github.com/users/vrde/gists{/gist_id}","starred_url":"https://api.github.com/users/vrde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vrde/subscriptions","organizations_url":"https://api.github.com/users/vrde/orgs","repos_url":"https://api.github.com/users/vrde/repos","events_url":"https://api.github.com/users/vrde/events{/privacy}","received_events_url":"https://api.github.com/users/vrde/received_events","type":"User","site_admin":false},"repo":{"id":64463734,"name":"bigchaindb","full_name":"vrde/bigchaindb","owner":{"login":"vrde","id":134680,"avatar_url":"https://avatars1.githubusercontent.com/u/134680?v=4","gravatar_id":"","url":"https://api.github.com/users/vrde","html_url":"https://github.com/vrde","followers_url":"https://api.github.com/users/vrde/followers","following_url":"https://api.github.com/users/vrde/following{/other_user}","gists_url":"https://api.github.com/users/vrde/gists{/gist_id}","starred_url":"https://api.github.com/users/vrde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vrde/subscriptions","organizations_url":"https://api.github.com/users/vrde/orgs","repos_url":"https://api.github.com/users/vrde/repos","events_url":"https://api.github.com/users/vrde/events{/privacy}","received_events_url":"https://api.github.com/users/vrde/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vrde/bigchaindb","description":"Meet BigchainDB. The blockchain database.","fork":true,"url":"https://api.github.com/repos/vrde/bigchaindb","forks_url":"https://api.github.com/repos/vrde/bigchaindb/forks","keys_url":"https://api.github.com/repos/vrde/bigchaindb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vrde/bigchaindb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vrde/bigchaindb/teams","hooks_url":"https://api.github.com/repos/vrde/bigchaindb/hooks","issue_events_url":"https://api.github.com/repos/vrde/bigchaindb/issues/events{/number}","events_url":"https://api.github.com/repos/vrde/bigchaindb/events","assignees_url":"https://api.github.com/repos/vrde/bigchaindb/assignees{/user}","branches_url":"https://api.github.com/repos/vrde/bigchaindb/branches{/branch}","tags_url":"https://api.github.com/repos/vrde/bigchaindb/tags","blobs_url":"https://api.github.com/repos/vrde/bigchaindb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vrde/bigchaindb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vrde/bigchaindb/git/refs{/sha}","trees_url":"https://api.github.com/repos/vrde/bigchaindb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vrde/bigchaindb/statuses/{sha}","languages_url":"https://api.github.com/repos/vrde/bigchaindb/languages","stargazers_url":"https://api.github.com/repos/vrde/bigchaindb/stargazers","contributors_url":"https://api.github.com/repos/vrde/bigchaindb/contributors","subscribers_url":"https://api.github.com/repos/vrde/bigchaindb/subscribers","subscription_url":"https://api.github.com/repos/vrde/bigchaindb/subscription","commits_url":"https://api.github.com/repos/vrde/bigchaindb/commits{/sha}","git_commits_url":"https://api.github.com/repos/vrde/bigchaindb/git/commits{/sha}","comments_url":"https://api.github.com/repos/vrde/bigchaindb/comments{/number}","issue_comment_url":"https://api.github.com/repos/vrde/bigchaindb/issues/comments{/number}","contents_url":"https://api.github.com/repos/vrde/bigchaindb/contents/{+path}","compare_url":"https://api.github.com/repos/vrde/bigchaindb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vrde/bigchaindb/merges","archive_url":"https://api.github.com/repos/vrde/bigchaindb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vrde/bigchaindb/downloads","issues_url":"https://api.github.com/repos/vrde/bigchaindb/issues{/number}","pulls_url":"https://api.github.com/repos/vrde/bigchaindb/pulls{/number}","milestones_url":"https://api.github.com/repos/vrde/bigchaindb/milestones{/number}","notifications_url":"https://api.github.com/repos/vrde/bigchaindb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vrde/bigchaindb/labels{/name}","releases_url":"https://api.github.com/repos/vrde/bigchaindb/releases{/id}","deployments_url":"https://api.github.com/repos/vrde/bigchaindb/deployments","created_at":"2016-07-29T08:18:47Z","updated_at":"2018-05-08T11:13:44Z","pushed_at":"2018-05-11T08:26:14Z","git_url":"git://github.com/vrde/bigchaindb.git","ssh_url":"[email protected]:vrde/bigchaindb.git","clone_url":"https://github.com/vrde/bigchaindb.git","svn_url":"https://github.com/vrde/bigchaindb","homepage":"https://www.bigchaindb.com/","size":9049,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bigchaindb:master","ref":"master","sha":"d2685052a676bf7bb274135a559b501c4cb17db7","user":{"login":"bigchaindb","id":17097586,"avatar_url":"https://avatars0.githubusercontent.com/u/17097586?v=4","gravatar_id":"","url":"https://api.github.com/users/bigchaindb","html_url":"https://github.com/bigchaindb","followers_url":"https://api.github.com/users/bigchaindb/followers","following_url":"https://api.github.com/users/bigchaindb/following{/other_user}","gists_url":"https://api.github.com/users/bigchaindb/gists{/gist_id}","starred_url":"https://api.github.com/users/bigchaindb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bigchaindb/subscriptions","organizations_url":"https://api.github.com/users/bigchaindb/orgs","repos_url":"https://api.github.com/users/bigchaindb/repos","events_url":"https://api.github.com/users/bigchaindb/events{/privacy}","received_events_url":"https://api.github.com/users/bigchaindb/received_events","type":"Organization","site_admin":false},"repo":{"id":51290852,"name":"bigchaindb","full_name":"bigchaindb/bigchaindb","owner":{"login":"bigchaindb","id":17097586,"avatar_url":"https://avatars0.githubusercontent.com/u/17097586?v=4","gravatar_id":"","url":"https://api.github.com/users/bigchaindb","html_url":"https://github.com/bigchaindb","followers_url":"https://api.github.com/users/bigchaindb/followers","following_url":"https://api.github.com/users/bigchaindb/following{/other_user}","gists_url":"https://api.github.com/users/bigchaindb/gists{/gist_id}","starred_url":"https://api.github.com/users/bigchaindb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bigchaindb/subscriptions","organizations_url":"https://api.github.com/users/bigchaindb/orgs","repos_url":"https://api.github.com/users/bigchaindb/repos","events_url":"https://api.github.com/users/bigchaindb/events{/privacy}","received_events_url":"https://api.github.com/users/bigchaindb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bigchaindb/bigchaindb","description":"Meet BigchainDB. The blockchain database.","fork":false,"url":"https://api.github.com/repos/bigchaindb/bigchaindb","forks_url":"https://api.github.com/repos/bigchaindb/bigchaindb/forks","keys_url":"https://api.github.com/repos/bigchaindb/bigchaindb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bigchaindb/bigchaindb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bigchaindb/bigchaindb/teams","hooks_url":"https://api.github.com/repos/bigchaindb/bigchaindb/hooks","issue_events_url":"https://api.github.com/repos/bigchaindb/bigchaindb/issues/events{/number}","events_url":"https://api.github.com/repos/bigchaindb/bigchaindb/events","assignees_url":"https://api.github.com/repos/bigchaindb/bigchaindb/assignees{/user}","branches_url":"https://api.github.com/repos/bigchaindb/bigchaindb/branches{/branch}","tags_url":"https://api.github.com/repos/bigchaindb/bigchaindb/tags","blobs_url":"https://api.github.com/repos/bigchaindb/bigchaindb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bigchaindb/bigchaindb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bigchaindb/bigchaindb/git/refs{/sha}","trees_url":"https://api.github.com/repos/bigchaindb/bigchaindb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bigchaindb/bigchaindb/statuses/{sha}","languages_url":"https://api.github.com/repos/bigchaindb/bigchaindb/languages","stargazers_url":"https://api.github.com/repos/bigchaindb/bigchaindb/stargazers","contributors_url":"https://api.github.com/repos/bigchaindb/bigchaindb/contributors","subscribers_url":"https://api.github.com/repos/bigchaindb/bigchaindb/subscribers","subscription_url":"https://api.github.com/repos/bigchaindb/bigchaindb/subscription","commits_url":"https://api.github.com/repos/bigchaindb/bigchaindb/commits{/sha}","git_commits_url":"https://api.github.com/repos/bigchaindb/bigchaindb/git/commits{/sha}","comments_url":"https://api.github.com/repos/bigchaindb/bigchaindb/comments{/number}","issue_comment_url":"https://api.github.com/repos/bigchaindb/bigchaindb/issues/comments{/number}","contents_url":"https://api.github.com/repos/bigchaindb/bigchaindb/contents/{+path}","compare_url":"https://api.github.com/repos/bigchaindb/bigchaindb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bigchaindb/bigchaindb/merges","archive_url":"https://api.github.com/repos/bigchaindb/bigchaindb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bigchaindb/bigchaindb/downloads","issues_url":"https://api.github.com/repos/bigchaindb/bigchaindb/issues{/number}","pulls_url":"https://api.github.com/repos/bigchaindb/bigchaindb/pulls{/number}","milestones_url":"https://api.github.com/repos/bigchaindb/bigchaindb/milestones{/number}","notifications_url":"https://api.github.com/repos/bigchaindb/bigchaindb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bigchaindb/bigchaindb/labels{/name}","releases_url":"https://api.github.com/repos/bigchaindb/bigchaindb/releases{/id}","deployments_url":"https://api.github.com/repos/bigchaindb/bigchaindb/deployments","created_at":"2016-02-08T10:12:58Z","updated_at":"2018-05-14T08:58:50Z","pushed_at":"2018-05-14T09:52:28Z","git_url":"git://github.com/bigchaindb/bigchaindb.git","ssh_url":"[email protected]:bigchaindb/bigchaindb.git","clone_url":"https://github.com/bigchaindb/bigchaindb.git","svn_url":"https://github.com/bigchaindb/bigchaindb","homepage":"https://www.bigchaindb.com/","size":8970,"stargazers_count":2502,"watchers_count":2502,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":476,"mirror_url":null,"archived":false,"open_issues_count":157,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":476,"open_issues":157,"watchers":2502,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bigchaindb/bigchaindb/pulls/2282"},"html":{"href":"https://github.com/bigchaindb/bigchaindb/pull/2282"},"issue":{"href":"https://api.github.com/repos/bigchaindb/bigchaindb/issues/2282"},"comments":{"href":"https://api.github.com/repos/bigchaindb/bigchaindb/issues/2282/comments"},"review_comments":{"href":"https://api.github.com/repos/bigchaindb/bigchaindb/pulls/2282/comments"},"review_comment":{"href":"https://api.github.com/repos/bigchaindb/bigchaindb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bigchaindb/bigchaindb/pulls/2282/commits"},"statuses":{"href":"https://api.github.com/repos/bigchaindb/bigchaindb/statuses/337a344e8a045e511e881d5a2fa8c634e653884c"}},"author_association":"CONTRIBUTOR"}} | {
"id": 51290852,
"name": "bigchaindb/bigchaindb",
"url": "https://api.github.com/repos/bigchaindb/bigchaindb"
} | {
"id": 1210951,
"login": "ttmc",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1210951?",
"url": "https://api.github.com/users/ttmc"
} | {
"id": 17097586,
"login": "bigchaindb",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/17097586?",
"url": "https://api.github.com/orgs/bigchaindb"
} | 2018-05-14T09:59:47 | 7669547518 | {"actor":{"display_login":"ttmc"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/gruntwork-io/terratest/pulls/comments/219439157","pull_request_review_id":157612827,"id":219439157,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxOTQzOTE1Nw==","diff_hunk":"@@ -171,13 +286,66 @@ func GetInstanceIdsForInstanceGroupE(t *testing.T, projectID string, zone string\n \t\t}\n \t\treturn nil\n \t}); err != nil {\n-\t\treturn nil, fmt.Errorf(\"InstanceGroups.ListInstances(%s) got error: %v\", groupName, err)\n+\t\treturn nil, fmt.Errorf(\"InstanceGroups.ListInstances(%s) got error: %v\", ig.Name, err)\n \t}\n \n \treturn instanceIDs, nil\n }\n \n-// NewComputeService creates a new Compute service.\n+// GetRandomInstance returns a randomly selected Instance from the Regional Instance Group\n+func (ig *RegionalInstanceGroup) GetRandomInstance(t *testing.T) *Instance {\n+\tinstance, err := ig.GetRandomInstanceE(t)\n+\tif err != nil {\n+\t\tt.Fatal(err)\n+\t}\n+\n+\treturn instance\n+}\n+\n+// GetRandomInstanceE returns a randomly selected Instance from the Regional Instance Group\n+func (ig *RegionalInstanceGroup) GetRandomInstanceE(t *testing.T) (*Instance, error) {\n+\tinstanceIDs := ig.GetInstanceIds(t)\n+\tclusterSize := int(ig.Size)\n+\trandIndex := random.Random(1, clusterSize)\n+\n+\tif randIndex > len(instanceIDs) {","path":"modules/gcp/compute.go","position":364,"original_position":364,"commit_id":"15572ea1ea6c4ffce70b1e01eed96b81f3423e6e","original_commit_id":"15572ea1ea6c4ffce70b1e01eed96b81f3423e6e","user":{"login":"brikis98","id":711908,"node_id":"MDQ6VXNlcjcxMTkwOA==","avatar_url":"https://avatars1.githubusercontent.com/u/711908?v=4","gravatar_id":"","url":"https://api.github.com/users/brikis98","html_url":"https://github.com/brikis98","followers_url":"https://api.github.com/users/brikis98/followers","following_url":"https://api.github.com/users/brikis98/following{/other_user}","gists_url":"https://api.github.com/users/brikis98/gists{/gist_id}","starred_url":"https://api.github.com/users/brikis98/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brikis98/subscriptions","organizations_url":"https://api.github.com/users/brikis98/orgs","repos_url":"https://api.github.com/users/brikis98/repos","events_url":"https://api.github.com/users/brikis98/events{/privacy}","received_events_url":"https://api.github.com/users/brikis98/received_events","type":"User","site_admin":false},"body":"When would this happen?","created_at":"2018-09-21T09:34:26Z","updated_at":"2018-09-21T09:40:06Z","html_url":"https://github.com/gruntwork-io/terratest/pull/157#discussion_r219439157","pull_request_url":"https://api.github.com/repos/gruntwork-io/terratest/pulls/157","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/gruntwork-io/terratest/pulls/comments/219439157"},"html":{"href":"https://github.com/gruntwork-io/terratest/pull/157#discussion_r219439157"},"pull_request":{"href":"https://api.github.com/repos/gruntwork-io/terratest/pulls/157"}}},"pull_request":{"url":"https://api.github.com/repos/gruntwork-io/terratest/pulls/157","id":217168458,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3MTY4NDU4","html_url":"https://github.com/gruntwork-io/terratest/pull/157","diff_url":"https://github.com/gruntwork-io/terratest/pull/157.diff","patch_url":"https://github.com/gruntwork-io/terratest/pull/157.patch","issue_url":"https://api.github.com/repos/gruntwork-io/terratest/issues/157","number":157,"state":"open","locked":false,"title":"Update GCP Module to Support Regional Instance Groups, Cleaner Usage Model","user":{"login":"josh-padnick","id":4295964,"node_id":"MDQ6VXNlcjQyOTU5NjQ=","avatar_url":"https://avatars1.githubusercontent.com/u/4295964?v=4","gravatar_id":"","url":"https://api.github.com/users/josh-padnick","html_url":"https://github.com/josh-padnick","followers_url":"https://api.github.com/users/josh-padnick/followers","following_url":"https://api.github.com/users/josh-padnick/following{/other_user}","gists_url":"https://api.github.com/users/josh-padnick/gists{/gist_id}","starred_url":"https://api.github.com/users/josh-padnick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josh-padnick/subscriptions","organizations_url":"https://api.github.com/users/josh-padnick/orgs","repos_url":"https://api.github.com/users/josh-padnick/repos","events_url":"https://api.github.com/users/josh-padnick/events{/privacy}","received_events_url":"https://api.github.com/users/josh-padnick/received_events","type":"User","site_admin":false},"body":"This PR was originally motivated by my need to finish setting up automated tests for the https://github.com/hashicorp/terraform-google-consul repo. In that repo, I added support for Regional Instance Groups to Consul. To add support for that in Terratst led to a cascade of changes, plus a number of insights on creating a cleaner API for Terratest. Included in this PR:\r\n\r\n- **Update the Terratest GCP API to \"fetch\" new resources.** GCP's Golang SDK often returns just an ID for a resource, requiring a follow-up query task. I switched to instantiating new GCP resources by fetching their data from GCP to create a cleaner usage model that more closely aligns with the GCP SDK.\r\n\r\n- **Add More Helper Functions.** For example, `GetRandomInstance()` to return a randomly selected, fully populated Instance object from a Zonal or Regional Instance Group.\r\n\r\n- **Add Better Test Coverage.** There are now readily available helper functions for launching and destroying a Compute Instance with Go instead of just with Terraform. This made writing tests easier. I also added more test coverage to some functions.","created_at":"2018-09-21T04:26:35Z","updated_at":"2018-09-21T09:40:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bca6850608bc8ac3d7e5649f88f29a847f3f12dd","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/gruntwork-io/terratest/pulls/157/commits","review_comments_url":"https://api.github.com/repos/gruntwork-io/terratest/pulls/157/comments","review_comment_url":"https://api.github.com/repos/gruntwork-io/terratest/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gruntwork-io/terratest/issues/157/comments","statuses_url":"https://api.github.com/repos/gruntwork-io/terratest/statuses/15572ea1ea6c4ffce70b1e01eed96b81f3423e6e","head":{"label":"gruntwork-io:tweaks","ref":"tweaks","sha":"15572ea1ea6c4ffce70b1e01eed96b81f3423e6e","user":{"login":"gruntwork-io","id":17118990,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3MTE4OTkw","avatar_url":"https://avatars3.githubusercontent.com/u/17118990?v=4","gravatar_id":"","url":"https://api.github.com/users/gruntwork-io","html_url":"https://github.com/gruntwork-io","followers_url":"https://api.github.com/users/gruntwork-io/followers","following_url":"https://api.github.com/users/gruntwork-io/following{/other_user}","gists_url":"https://api.github.com/users/gruntwork-io/gists{/gist_id}","starred_url":"https://api.github.com/users/gruntwork-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gruntwork-io/subscriptions","organizations_url":"https://api.github.com/users/gruntwork-io/orgs","repos_url":"https://api.github.com/users/gruntwork-io/repos","events_url":"https://api.github.com/users/gruntwork-io/events{/privacy}","received_events_url":"https://api.github.com/users/gruntwork-io/received_events","type":"Organization","site_admin":false},"repo":{"id":53174289,"node_id":"MDEwOlJlcG9zaXRvcnk1MzE3NDI4OQ==","name":"terratest","full_name":"gruntwork-io/terratest","private":false,"owner":{"login":"gruntwork-io","id":17118990,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3MTE4OTkw","avatar_url":"https://avatars3.githubusercontent.com/u/17118990?v=4","gravatar_id":"","url":"https://api.github.com/users/gruntwork-io","html_url":"https://github.com/gruntwork-io","followers_url":"https://api.github.com/users/gruntwork-io/followers","following_url":"https://api.github.com/users/gruntwork-io/following{/other_user}","gists_url":"https://api.github.com/users/gruntwork-io/gists{/gist_id}","starred_url":"https://api.github.com/users/gruntwork-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gruntwork-io/subscriptions","organizations_url":"https://api.github.com/users/gruntwork-io/orgs","repos_url":"https://api.github.com/users/gruntwork-io/repos","events_url":"https://api.github.com/users/gruntwork-io/events{/privacy}","received_events_url":"https://api.github.com/users/gruntwork-io/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/gruntwork-io/terratest","description":" Terratest is a Go library that makes it easier to write automated tests for your infrastructure code.","fork":false,"url":"https://api.github.com/repos/gruntwork-io/terratest","forks_url":"https://api.github.com/repos/gruntwork-io/terratest/forks","keys_url":"https://api.github.com/repos/gruntwork-io/terratest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gruntwork-io/terratest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gruntwork-io/terratest/teams","hooks_url":"https://api.github.com/repos/gruntwork-io/terratest/hooks","issue_events_url":"https://api.github.com/repos/gruntwork-io/terratest/issues/events{/number}","events_url":"https://api.github.com/repos/gruntwork-io/terratest/events","assignees_url":"https://api.github.com/repos/gruntwork-io/terratest/assignees{/user}","branches_url":"https://api.github.com/repos/gruntwork-io/terratest/branches{/branch}","tags_url":"https://api.github.com/repos/gruntwork-io/terratest/tags","blobs_url":"https://api.github.com/repos/gruntwork-io/terratest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gruntwork-io/terratest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gruntwork-io/terratest/git/refs{/sha}","trees_url":"https://api.github.com/repos/gruntwork-io/terratest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gruntwork-io/terratest/statuses/{sha}","languages_url":"https://api.github.com/repos/gruntwork-io/terratest/languages","stargazers_url":"https://api.github.com/repos/gruntwork-io/terratest/stargazers","contributors_url":"https://api.github.com/repos/gruntwork-io/terratest/contributors","subscribers_url":"https://api.github.com/repos/gruntwork-io/terratest/subscribers","subscription_url":"https://api.github.com/repos/gruntwork-io/terratest/subscription","commits_url":"https://api.github.com/repos/gruntwork-io/terratest/commits{/sha}","git_commits_url":"https://api.github.com/repos/gruntwork-io/terratest/git/commits{/sha}","comments_url":"https://api.github.com/repos/gruntwork-io/terratest/comments{/number}","issue_comment_url":"https://api.github.com/repos/gruntwork-io/terratest/issues/comments{/number}","contents_url":"https://api.github.com/repos/gruntwork-io/terratest/contents/{+path}","compare_url":"https://api.github.com/repos/gruntwork-io/terratest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gruntwork-io/terratest/merges","archive_url":"https://api.github.com/repos/gruntwork-io/terratest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gruntwork-io/terratest/downloads","issues_url":"https://api.github.com/repos/gruntwork-io/terratest/issues{/number}","pulls_url":"https://api.github.com/repos/gruntwork-io/terratest/pulls{/number}","milestones_url":"https://api.github.com/repos/gruntwork-io/terratest/milestones{/number}","notifications_url":"https://api.github.com/repos/gruntwork-io/terratest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gruntwork-io/terratest/labels{/name}","releases_url":"https://api.github.com/repos/gruntwork-io/terratest/releases{/id}","deployments_url":"https://api.github.com/repos/gruntwork-io/terratest/deployments","created_at":"2016-03-05T00:26:17Z","updated_at":"2018-09-20T23:46:19Z","pushed_at":"2018-09-21T04:27:01Z","git_url":"git://github.com/gruntwork-io/terratest.git","ssh_url":"[email protected]:gruntwork-io/terratest.git","clone_url":"https://github.com/gruntwork-io/terratest.git","svn_url":"https://github.com/gruntwork-io/terratest","homepage":"https://gruntwork.io/","size":731,"stargazers_count":1367,"watchers_count":1367,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":87,"mirror_url":null,"archived":false,"open_issues_count":24,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":87,"open_issues":24,"watchers":1367,"default_branch":"master"}},"base":{"label":"gruntwork-io:master","ref":"master","sha":"c16e30927ee077a7bcde417fcc10fb020c406cf8","user":{"login":"gruntwork-io","id":17118990,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3MTE4OTkw","avatar_url":"https://avatars3.githubusercontent.com/u/17118990?v=4","gravatar_id":"","url":"https://api.github.com/users/gruntwork-io","html_url":"https://github.com/gruntwork-io","followers_url":"https://api.github.com/users/gruntwork-io/followers","following_url":"https://api.github.com/users/gruntwork-io/following{/other_user}","gists_url":"https://api.github.com/users/gruntwork-io/gists{/gist_id}","starred_url":"https://api.github.com/users/gruntwork-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gruntwork-io/subscriptions","organizations_url":"https://api.github.com/users/gruntwork-io/orgs","repos_url":"https://api.github.com/users/gruntwork-io/repos","events_url":"https://api.github.com/users/gruntwork-io/events{/privacy}","received_events_url":"https://api.github.com/users/gruntwork-io/received_events","type":"Organization","site_admin":false},"repo":{"id":53174289,"node_id":"MDEwOlJlcG9zaXRvcnk1MzE3NDI4OQ==","name":"terratest","full_name":"gruntwork-io/terratest","private":false,"owner":{"login":"gruntwork-io","id":17118990,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3MTE4OTkw","avatar_url":"https://avatars3.githubusercontent.com/u/17118990?v=4","gravatar_id":"","url":"https://api.github.com/users/gruntwork-io","html_url":"https://github.com/gruntwork-io","followers_url":"https://api.github.com/users/gruntwork-io/followers","following_url":"https://api.github.com/users/gruntwork-io/following{/other_user}","gists_url":"https://api.github.com/users/gruntwork-io/gists{/gist_id}","starred_url":"https://api.github.com/users/gruntwork-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gruntwork-io/subscriptions","organizations_url":"https://api.github.com/users/gruntwork-io/orgs","repos_url":"https://api.github.com/users/gruntwork-io/repos","events_url":"https://api.github.com/users/gruntwork-io/events{/privacy}","received_events_url":"https://api.github.com/users/gruntwork-io/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/gruntwork-io/terratest","description":" Terratest is a Go library that makes it easier to write automated tests for your infrastructure code.","fork":false,"url":"https://api.github.com/repos/gruntwork-io/terratest","forks_url":"https://api.github.com/repos/gruntwork-io/terratest/forks","keys_url":"https://api.github.com/repos/gruntwork-io/terratest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gruntwork-io/terratest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gruntwork-io/terratest/teams","hooks_url":"https://api.github.com/repos/gruntwork-io/terratest/hooks","issue_events_url":"https://api.github.com/repos/gruntwork-io/terratest/issues/events{/number}","events_url":"https://api.github.com/repos/gruntwork-io/terratest/events","assignees_url":"https://api.github.com/repos/gruntwork-io/terratest/assignees{/user}","branches_url":"https://api.github.com/repos/gruntwork-io/terratest/branches{/branch}","tags_url":"https://api.github.com/repos/gruntwork-io/terratest/tags","blobs_url":"https://api.github.com/repos/gruntwork-io/terratest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gruntwork-io/terratest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gruntwork-io/terratest/git/refs{/sha}","trees_url":"https://api.github.com/repos/gruntwork-io/terratest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gruntwork-io/terratest/statuses/{sha}","languages_url":"https://api.github.com/repos/gruntwork-io/terratest/languages","stargazers_url":"https://api.github.com/repos/gruntwork-io/terratest/stargazers","contributors_url":"https://api.github.com/repos/gruntwork-io/terratest/contributors","subscribers_url":"https://api.github.com/repos/gruntwork-io/terratest/subscribers","subscription_url":"https://api.github.com/repos/gruntwork-io/terratest/subscription","commits_url":"https://api.github.com/repos/gruntwork-io/terratest/commits{/sha}","git_commits_url":"https://api.github.com/repos/gruntwork-io/terratest/git/commits{/sha}","comments_url":"https://api.github.com/repos/gruntwork-io/terratest/comments{/number}","issue_comment_url":"https://api.github.com/repos/gruntwork-io/terratest/issues/comments{/number}","contents_url":"https://api.github.com/repos/gruntwork-io/terratest/contents/{+path}","compare_url":"https://api.github.com/repos/gruntwork-io/terratest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gruntwork-io/terratest/merges","archive_url":"https://api.github.com/repos/gruntwork-io/terratest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gruntwork-io/terratest/downloads","issues_url":"https://api.github.com/repos/gruntwork-io/terratest/issues{/number}","pulls_url":"https://api.github.com/repos/gruntwork-io/terratest/pulls{/number}","milestones_url":"https://api.github.com/repos/gruntwork-io/terratest/milestones{/number}","notifications_url":"https://api.github.com/repos/gruntwork-io/terratest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gruntwork-io/terratest/labels{/name}","releases_url":"https://api.github.com/repos/gruntwork-io/terratest/releases{/id}","deployments_url":"https://api.github.com/repos/gruntwork-io/terratest/deployments","created_at":"2016-03-05T00:26:17Z","updated_at":"2018-09-20T23:46:19Z","pushed_at":"2018-09-21T04:27:01Z","git_url":"git://github.com/gruntwork-io/terratest.git","ssh_url":"[email protected]:gruntwork-io/terratest.git","clone_url":"https://github.com/gruntwork-io/terratest.git","svn_url":"https://github.com/gruntwork-io/terratest","homepage":"https://gruntwork.io/","size":731,"stargazers_count":1367,"watchers_count":1367,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":87,"mirror_url":null,"archived":false,"open_issues_count":24,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":87,"open_issues":24,"watchers":1367,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gruntwork-io/terratest/pulls/157"},"html":{"href":"https://github.com/gruntwork-io/terratest/pull/157"},"issue":{"href":"https://api.github.com/repos/gruntwork-io/terratest/issues/157"},"comments":{"href":"https://api.github.com/repos/gruntwork-io/terratest/issues/157/comments"},"review_comments":{"href":"https://api.github.com/repos/gruntwork-io/terratest/pulls/157/comments"},"review_comment":{"href":"https://api.github.com/repos/gruntwork-io/terratest/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gruntwork-io/terratest/pulls/157/commits"},"statuses":{"href":"https://api.github.com/repos/gruntwork-io/terratest/statuses/15572ea1ea6c4ffce70b1e01eed96b81f3423e6e"}},"author_association":"CONTRIBUTOR"}} | {
"id": 53174289,
"name": "gruntwork-io/terratest",
"url": "https://api.github.com/repos/gruntwork-io/terratest"
} | {
"id": 711908,
"login": "brikis98",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/711908?",
"url": "https://api.github.com/users/brikis98"
} | {
"id": 17118990,
"login": "gruntwork-io",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/17118990?",
"url": "https://api.github.com/orgs/gruntwork-io"
} | 2018-09-21T09:34:26 | 8300926870 | {"actor":{"display_login":"brikis98"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/rocketsofawesome/newgistics-ruby/pulls/comments/216078195","pull_request_review_id":153491598,"id":216078195,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNjA3ODE5NQ==","diff_hunk":"@@ -1,6 +1,6 @@\n module Newgistics\n class Customer\n- include Virtus.model\n+ include Newgistics::Model","path":"lib/newgistics/customer.rb","position":4,"original_position":4,"commit_id":"e4349005732483c6fa5fbc1a05e0071db24839da","original_commit_id":"e4349005732483c6fa5fbc1a05e0071db24839da","user":{"login":"manmartinez","id":1505446,"node_id":"MDQ6VXNlcjE1MDU0NDY=","avatar_url":"https://avatars2.githubusercontent.com/u/1505446?v=4","gravatar_id":"","url":"https://api.github.com/users/manmartinez","html_url":"https://github.com/manmartinez","followers_url":"https://api.github.com/users/manmartinez/followers","following_url":"https://api.github.com/users/manmartinez/following{/other_user}","gists_url":"https://api.github.com/users/manmartinez/gists{/gist_id}","starred_url":"https://api.github.com/users/manmartinez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manmartinez/subscriptions","organizations_url":"https://api.github.com/users/manmartinez/orgs","repos_url":"https://api.github.com/users/manmartinez/repos","events_url":"https://api.github.com/users/manmartinez/events{/privacy}","received_events_url":"https://api.github.com/users/manmartinez/received_events","type":"User","site_admin":false},"body":"I wasn't sure if we should go with including a module or inheriting from a base class, any thoughts?","created_at":"2018-09-07T20:26:46Z","updated_at":"2018-09-07T20:26:52Z","html_url":"https://github.com/rocketsofawesome/newgistics-ruby/pull/32#discussion_r216078195","pull_request_url":"https://api.github.com/repos/rocketsofawesome/newgistics-ruby/pulls/32","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/rocketsofawesome/newgistics-ruby/pulls/comments/216078195"},"html":{"href":"https://github.com/rocketsofawesome/newgistics-ruby/pull/32#discussion_r216078195"},"pull_request":{"href":"https://api.github.com/repos/rocketsofawesome/newgistics-ruby/pulls/32"}}},"pull_request":{"url":"https://api.github.com/repos/rocketsofawesome/newgistics-ruby/pulls/32","id":214014296,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE0MDE0Mjk2","html_url":"https://github.com/rocketsofawesome/newgistics-ruby/pull/32","diff_url":"https://github.com/rocketsofawesome/newgistics-ruby/pull/32.diff","patch_url":"https://github.com/rocketsofawesome/newgistics-ruby/pull/32.patch","issue_url":"https://api.github.com/repos/rocketsofawesome/newgistics-ruby/issues/32","number":32,"state":"open","locked":false,"title":"Allow developers to query manifests","user":{"login":"manmartinez","id":1505446,"node_id":"MDQ6VXNlcjE1MDU0NDY=","avatar_url":"https://avatars2.githubusercontent.com/u/1505446?v=4","gravatar_id":"","url":"https://api.github.com/users/manmartinez","html_url":"https://github.com/manmartinez","followers_url":"https://api.github.com/users/manmartinez/followers","following_url":"https://api.github.com/users/manmartinez/following{/other_user}","gists_url":"https://api.github.com/users/manmartinez/gists{/gist_id}","starred_url":"https://api.github.com/users/manmartinez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manmartinez/subscriptions","organizations_url":"https://api.github.com/users/manmartinez/orgs","repos_url":"https://api.github.com/users/manmartinez/repos","events_url":"https://api.github.com/users/manmartinez/events{/privacy}","received_events_url":"https://api.github.com/users/manmartinez/received_events","type":"User","site_admin":false},"body":"#### What's this PR do?\r\nWith this change we'll allow developers to query manifests using the `Newgistics::Manifest.where` method.\r\n\r\nWe'll also refactor our models so they include the `Newgistics::Model` module, which allows each class to override the `.element_selector` method to indicate the css selector we should use to get to the XML node that contains the attributes for instances of this class when parsing responses from the API.\r\n\r\nThis simplifies building `Newgistics::Query` objects and gives us a bit more flexibility when parsing deeply-nested objects. ","created_at":"2018-09-07T19:06:03Z","updated_at":"2018-09-07T20:26:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7413cd3294732b8e16658d766845dbd4e10ae50d","assignee":null,"assignees":[],"requested_reviewers":[{"login":"jrusso1020","id":7664106,"node_id":"MDQ6VXNlcjc2NjQxMDY=","avatar_url":"https://avatars3.githubusercontent.com/u/7664106?v=4","gravatar_id":"","url":"https://api.github.com/users/jrusso1020","html_url":"https://github.com/jrusso1020","followers_url":"https://api.github.com/users/jrusso1020/followers","following_url":"https://api.github.com/users/jrusso1020/following{/other_user}","gists_url":"https://api.github.com/users/jrusso1020/gists{/gist_id}","starred_url":"https://api.github.com/users/jrusso1020/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrusso1020/subscriptions","organizations_url":"https://api.github.com/users/jrusso1020/orgs","repos_url":"https://api.github.com/users/jrusso1020/repos","events_url":"https://api.github.com/users/jrusso1020/events{/privacy}","received_events_url":"https://api.github.com/users/jrusso1020/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/rocketsofawesome/newgistics-ruby/pulls/32/commits","review_comments_url":"https://api.github.com/repos/rocketsofawesome/newgistics-ruby/pulls/32/comments","review_comment_url":"https://api.github.com/repos/rocketsofawesome/newgistics-ruby/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rocketsofawesome/newgistics-ruby/issues/32/comments","statuses_url":"https://api.github.com/repos/rocketsofawesome/newgistics-ruby/statuses/e4349005732483c6fa5fbc1a05e0071db24839da","head":{"label":"rocketsofawesome:query-manifests","ref":"query-manifests","sha":"e4349005732483c6fa5fbc1a05e0071db24839da","user":{"login":"rocketsofawesome","id":17131620,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3MTMxNjIw","avatar_url":"https://avatars0.githubusercontent.com/u/17131620?v=4","gravatar_id":"","url":"https://api.github.com/users/rocketsofawesome","html_url":"https://github.com/rocketsofawesome","followers_url":"https://api.github.com/users/rocketsofawesome/followers","following_url":"https://api.github.com/users/rocketsofawesome/following{/other_user}","gists_url":"https://api.github.com/users/rocketsofawesome/gists{/gist_id}","starred_url":"https://api.github.com/users/rocketsofawesome/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rocketsofawesome/subscriptions","organizations_url":"https://api.github.com/users/rocketsofawesome/orgs","repos_url":"https://api.github.com/users/rocketsofawesome/repos","events_url":"https://api.github.com/users/rocketsofawesome/events{/privacy}","received_events_url":"https://api.github.com/users/rocketsofawesome/received_events","type":"Organization","site_admin":false},"repo":{"id":100068129,"node_id":"MDEwOlJlcG9zaXRvcnkxMDAwNjgxMjk=","name":"newgistics-ruby","full_name":"rocketsofawesome/newgistics-ruby","owner":{"login":"rocketsofawesome","id":17131620,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3MTMxNjIw","avatar_url":"https://avatars0.githubusercontent.com/u/17131620?v=4","gravatar_id":"","url":"https://api.github.com/users/rocketsofawesome","html_url":"https://github.com/rocketsofawesome","followers_url":"https://api.github.com/users/rocketsofawesome/followers","following_url":"https://api.github.com/users/rocketsofawesome/following{/other_user}","gists_url":"https://api.github.com/users/rocketsofawesome/gists{/gist_id}","starred_url":"https://api.github.com/users/rocketsofawesome/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rocketsofawesome/subscriptions","organizations_url":"https://api.github.com/users/rocketsofawesome/orgs","repos_url":"https://api.github.com/users/rocketsofawesome/repos","events_url":"https://api.github.com/users/rocketsofawesome/events{/privacy}","received_events_url":"https://api.github.com/users/rocketsofawesome/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rocketsofawesome/newgistics-ruby","description":"Ruby client for the Newgistics API","fork":false,"url":"https://api.github.com/repos/rocketsofawesome/newgistics-ruby","forks_url":"https://api.github.com/repos/rocketsofawesome/newgistics-ruby/forks","keys_url":"https://api.github.com/repos/rocketsofawesome/newgistics-ruby/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rocketsofawesome/newgistics-ruby/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rocketsofawesome/newgistics-ruby/teams","hooks_url":"https://api.github.com/repos/rocketsofawesome/newgistics-ruby/hooks","issue_events_url":"https://api.github.com/repos/rocketsofawesome/newgistics-ruby/issues/events{/number}","events_url":"https://api.github.com/repos/rocketsofawesome/newgistics-ruby/events","assignees_url":"https://api.github.com/repos/rocketsofawesome/newgistics-ruby/assignees{/user}","branches_url":"https://api.github.com/repos/rocketsofawesome/newgistics-ruby/branches{/branch}","tags_url":"https://api.github.com/repos/rocketsofawesome/newgistics-ruby/tags","blobs_url":"https://api.github.com/repos/rocketsofawesome/newgistics-ruby/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rocketsofawesome/newgistics-ruby/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rocketsofawesome/newgistics-ruby/git/refs{/sha}","trees_url":"https://api.github.com/repos/rocketsofawesome/newgistics-ruby/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rocketsofawesome/newgistics-ruby/statuses/{sha}","languages_url":"https://api.github.com/repos/rocketsofawesome/newgistics-ruby/languages","stargazers_url":"https://api.github.com/repos/rocketsofawesome/newgistics-ruby/stargazers","contributors_url":"https://api.github.com/repos/rocketsofawesome/newgistics-ruby/contributors","subscribers_url":"https://api.github.com/repos/rocketsofawesome/newgistics-ruby/subscribers","subscription_url":"https://api.github.com/repos/rocketsofawesome/newgistics-ruby/subscription","commits_url":"https://api.github.com/repos/rocketsofawesome/newgistics-ruby/commits{/sha}","git_commits_url":"https://api.github.com/repos/rocketsofawesome/newgistics-ruby/git/commits{/sha}","comments_url":"https://api.github.com/repos/rocketsofawesome/newgistics-ruby/comments{/number}","issue_comment_url":"https://api.github.com/repos/rocketsofawesome/newgistics-ruby/issues/comments{/number}","contents_url":"https://api.github.com/repos/rocketsofawesome/newgistics-ruby/contents/{+path}","compare_url":"https://api.github.com/repos/rocketsofawesome/newgistics-ruby/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rocketsofawesome/newgistics-ruby/merges","archive_url":"https://api.github.com/repos/rocketsofawesome/newgistics-ruby/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rocketsofawesome/newgistics-ruby/downloads","issues_url":"https://api.github.com/repos/rocketsofawesome/newgistics-ruby/issues{/number}","pulls_url":"https://api.github.com/repos/rocketsofawesome/newgistics-ruby/pulls{/number}","milestones_url":"https://api.github.com/repos/rocketsofawesome/newgistics-ruby/milestones{/number}","notifications_url":"https://api.github.com/repos/rocketsofawesome/newgistics-ruby/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rocketsofawesome/newgistics-ruby/labels{/name}","releases_url":"https://api.github.com/repos/rocketsofawesome/newgistics-ruby/releases{/id}","deployments_url":"https://api.github.com/repos/rocketsofawesome/newgistics-ruby/deployments","created_at":"2017-08-11T20:31:26Z","updated_at":"2018-09-04T17:24:14Z","pushed_at":"2018-09-07T20:23:27Z","git_url":"git://github.com/rocketsofawesome/newgistics-ruby.git","ssh_url":"[email protected]:rocketsofawesome/newgistics-ruby.git","clone_url":"https://github.com/rocketsofawesome/newgistics-ruby.git","svn_url":"https://github.com/rocketsofawesome/newgistics-ruby","homepage":null,"size":114,"stargazers_count":5,"watchers_count":5,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":2,"watchers":5,"default_branch":"master"}},"base":{"label":"rocketsofawesome:master","ref":"master","sha":"5153b5580fcaafc99308f334b7c8af4d6a21f445","user":{"login":"rocketsofawesome","id":17131620,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3MTMxNjIw","avatar_url":"https://avatars0.githubusercontent.com/u/17131620?v=4","gravatar_id":"","url":"https://api.github.com/users/rocketsofawesome","html_url":"https://github.com/rocketsofawesome","followers_url":"https://api.github.com/users/rocketsofawesome/followers","following_url":"https://api.github.com/users/rocketsofawesome/following{/other_user}","gists_url":"https://api.github.com/users/rocketsofawesome/gists{/gist_id}","starred_url":"https://api.github.com/users/rocketsofawesome/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rocketsofawesome/subscriptions","organizations_url":"https://api.github.com/users/rocketsofawesome/orgs","repos_url":"https://api.github.com/users/rocketsofawesome/repos","events_url":"https://api.github.com/users/rocketsofawesome/events{/privacy}","received_events_url":"https://api.github.com/users/rocketsofawesome/received_events","type":"Organization","site_admin":false},"repo":{"id":100068129,"node_id":"MDEwOlJlcG9zaXRvcnkxMDAwNjgxMjk=","name":"newgistics-ruby","full_name":"rocketsofawesome/newgistics-ruby","owner":{"login":"rocketsofawesome","id":17131620,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3MTMxNjIw","avatar_url":"https://avatars0.githubusercontent.com/u/17131620?v=4","gravatar_id":"","url":"https://api.github.com/users/rocketsofawesome","html_url":"https://github.com/rocketsofawesome","followers_url":"https://api.github.com/users/rocketsofawesome/followers","following_url":"https://api.github.com/users/rocketsofawesome/following{/other_user}","gists_url":"https://api.github.com/users/rocketsofawesome/gists{/gist_id}","starred_url":"https://api.github.com/users/rocketsofawesome/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rocketsofawesome/subscriptions","organizations_url":"https://api.github.com/users/rocketsofawesome/orgs","repos_url":"https://api.github.com/users/rocketsofawesome/repos","events_url":"https://api.github.com/users/rocketsofawesome/events{/privacy}","received_events_url":"https://api.github.com/users/rocketsofawesome/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rocketsofawesome/newgistics-ruby","description":"Ruby client for the Newgistics API","fork":false,"url":"https://api.github.com/repos/rocketsofawesome/newgistics-ruby","forks_url":"https://api.github.com/repos/rocketsofawesome/newgistics-ruby/forks","keys_url":"https://api.github.com/repos/rocketsofawesome/newgistics-ruby/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rocketsofawesome/newgistics-ruby/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rocketsofawesome/newgistics-ruby/teams","hooks_url":"https://api.github.com/repos/rocketsofawesome/newgistics-ruby/hooks","issue_events_url":"https://api.github.com/repos/rocketsofawesome/newgistics-ruby/issues/events{/number}","events_url":"https://api.github.com/repos/rocketsofawesome/newgistics-ruby/events","assignees_url":"https://api.github.com/repos/rocketsofawesome/newgistics-ruby/assignees{/user}","branches_url":"https://api.github.com/repos/rocketsofawesome/newgistics-ruby/branches{/branch}","tags_url":"https://api.github.com/repos/rocketsofawesome/newgistics-ruby/tags","blobs_url":"https://api.github.com/repos/rocketsofawesome/newgistics-ruby/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rocketsofawesome/newgistics-ruby/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rocketsofawesome/newgistics-ruby/git/refs{/sha}","trees_url":"https://api.github.com/repos/rocketsofawesome/newgistics-ruby/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rocketsofawesome/newgistics-ruby/statuses/{sha}","languages_url":"https://api.github.com/repos/rocketsofawesome/newgistics-ruby/languages","stargazers_url":"https://api.github.com/repos/rocketsofawesome/newgistics-ruby/stargazers","contributors_url":"https://api.github.com/repos/rocketsofawesome/newgistics-ruby/contributors","subscribers_url":"https://api.github.com/repos/rocketsofawesome/newgistics-ruby/subscribers","subscription_url":"https://api.github.com/repos/rocketsofawesome/newgistics-ruby/subscription","commits_url":"https://api.github.com/repos/rocketsofawesome/newgistics-ruby/commits{/sha}","git_commits_url":"https://api.github.com/repos/rocketsofawesome/newgistics-ruby/git/commits{/sha}","comments_url":"https://api.github.com/repos/rocketsofawesome/newgistics-ruby/comments{/number}","issue_comment_url":"https://api.github.com/repos/rocketsofawesome/newgistics-ruby/issues/comments{/number}","contents_url":"https://api.github.com/repos/rocketsofawesome/newgistics-ruby/contents/{+path}","compare_url":"https://api.github.com/repos/rocketsofawesome/newgistics-ruby/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rocketsofawesome/newgistics-ruby/merges","archive_url":"https://api.github.com/repos/rocketsofawesome/newgistics-ruby/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rocketsofawesome/newgistics-ruby/downloads","issues_url":"https://api.github.com/repos/rocketsofawesome/newgistics-ruby/issues{/number}","pulls_url":"https://api.github.com/repos/rocketsofawesome/newgistics-ruby/pulls{/number}","milestones_url":"https://api.github.com/repos/rocketsofawesome/newgistics-ruby/milestones{/number}","notifications_url":"https://api.github.com/repos/rocketsofawesome/newgistics-ruby/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rocketsofawesome/newgistics-ruby/labels{/name}","releases_url":"https://api.github.com/repos/rocketsofawesome/newgistics-ruby/releases{/id}","deployments_url":"https://api.github.com/repos/rocketsofawesome/newgistics-ruby/deployments","created_at":"2017-08-11T20:31:26Z","updated_at":"2018-09-04T17:24:14Z","pushed_at":"2018-09-07T20:23:27Z","git_url":"git://github.com/rocketsofawesome/newgistics-ruby.git","ssh_url":"[email protected]:rocketsofawesome/newgistics-ruby.git","clone_url":"https://github.com/rocketsofawesome/newgistics-ruby.git","svn_url":"https://github.com/rocketsofawesome/newgistics-ruby","homepage":null,"size":114,"stargazers_count":5,"watchers_count":5,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":2,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rocketsofawesome/newgistics-ruby/pulls/32"},"html":{"href":"https://github.com/rocketsofawesome/newgistics-ruby/pull/32"},"issue":{"href":"https://api.github.com/repos/rocketsofawesome/newgistics-ruby/issues/32"},"comments":{"href":"https://api.github.com/repos/rocketsofawesome/newgistics-ruby/issues/32/comments"},"review_comments":{"href":"https://api.github.com/repos/rocketsofawesome/newgistics-ruby/pulls/32/comments"},"review_comment":{"href":"https://api.github.com/repos/rocketsofawesome/newgistics-ruby/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rocketsofawesome/newgistics-ruby/pulls/32/commits"},"statuses":{"href":"https://api.github.com/repos/rocketsofawesome/newgistics-ruby/statuses/e4349005732483c6fa5fbc1a05e0071db24839da"}},"author_association":"COLLABORATOR"}} | {
"id": 100068129,
"name": "rocketsofawesome/newgistics-ruby",
"url": "https://api.github.com/repos/rocketsofawesome/newgistics-ruby"
} | {
"id": 1505446,
"login": "manmartinez",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1505446?",
"url": "https://api.github.com/users/manmartinez"
} | {
"id": 17131620,
"login": "rocketsofawesome",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/17131620?",
"url": "https://api.github.com/orgs/rocketsofawesome"
} | 2018-09-07T20:26:46 | 8232670723 | {"actor":{"display_login":"manmartinez"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/dask/dask/pulls/comments/224307666","pull_request_review_id":163641267,"id":224307666,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNDMwNzY2Ng==","diff_hunk":"@@ -825,10 +825,13 @@ def warn_on_get(get):\n else:\n if get in named_schedulers.values():\n _warnned_on_get[0] = True\n- warnings.warn(\"The get= keyword has been deprecated. \"\n- \"Please use the scheduler= keyword instead with the \"\n- \"name of the desired scheduler \"\n- \"like 'threads' or 'processes'\")\n+ warnings.warn(\n+ \"The get= keyword has been deprecated. \"\n+ \"Please use the scheduler= keyword instead with the name of \"\n+ \"the desired scheduler like 'threads' or 'processes'\\n\"\n+ \" x.compute(scheduler='threads') \\n\"\n+ \"or with a function that takes the graph and keys\\n\"","path":"dask/base.py","position":13,"original_position":13,"commit_id":"ddbdd3a971f0a288a4014282ff2c075a529bf630","original_commit_id":"ddbdd3a971f0a288a4014282ff2c075a529bf630","user":{"login":"jni","id":492549,"node_id":"MDQ6VXNlcjQ5MjU0OQ==","avatar_url":"https://avatars3.githubusercontent.com/u/492549?v=4","gravatar_id":"","url":"https://api.github.com/users/jni","html_url":"https://github.com/jni","followers_url":"https://api.github.com/users/jni/followers","following_url":"https://api.github.com/users/jni/following{/other_user}","gists_url":"https://api.github.com/users/jni/gists{/gist_id}","starred_url":"https://api.github.com/users/jni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jni/subscriptions","organizations_url":"https://api.github.com/users/jni/orgs","repos_url":"https://api.github.com/users/jni/repos","events_url":"https://api.github.com/users/jni/events{/privacy}","received_events_url":"https://api.github.com/users/jni/received_events","type":"User","site_admin":false},"body":"As a functional programming person, I like the callable interface even better than having to e.g. subclass client, though of course that might end up being the easiest option in many cases. So I very much appreciate the extra flexibility, thanks @mrocklin!","created_at":"2018-10-11T03:55:13Z","updated_at":"2018-10-11T03:55:13Z","html_url":"https://github.com/dask/dask/pull/4062#discussion_r224307666","pull_request_url":"https://api.github.com/repos/dask/dask/pulls/4062","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/dask/dask/pulls/comments/224307666"},"html":{"href":"https://github.com/dask/dask/pull/4062#discussion_r224307666"},"pull_request":{"href":"https://api.github.com/repos/dask/dask/pulls/4062"}},"in_reply_to_id":223770408},"pull_request":{"url":"https://api.github.com/repos/dask/dask/pulls/4062","id":221145651,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIxMTQ1NjUx","html_url":"https://github.com/dask/dask/pull/4062","diff_url":"https://github.com/dask/dask/pull/4062.diff","patch_url":"https://github.com/dask/dask/pull/4062.patch","issue_url":"https://api.github.com/repos/dask/dask/issues/4062","number":4062,"state":"closed","locked":false,"title":"Pass get functions through scheduler keyword","user":{"login":"mrocklin","id":306380,"node_id":"MDQ6VXNlcjMwNjM4MA==","avatar_url":"https://avatars3.githubusercontent.com/u/306380?v=4","gravatar_id":"","url":"https://api.github.com/users/mrocklin","html_url":"https://github.com/mrocklin","followers_url":"https://api.github.com/users/mrocklin/followers","following_url":"https://api.github.com/users/mrocklin/following{/other_user}","gists_url":"https://api.github.com/users/mrocklin/gists{/gist_id}","starred_url":"https://api.github.com/users/mrocklin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrocklin/subscriptions","organizations_url":"https://api.github.com/users/mrocklin/orgs","repos_url":"https://api.github.com/users/mrocklin/repos","events_url":"https://api.github.com/users/mrocklin/events{/privacy}","received_events_url":"https://api.github.com/users/mrocklin/received_events","type":"User","site_admin":false},"body":"- [x] Tests added / passed\r\n- [x] Passes `flake8 dask`\r\n\r\nYou can now do things like `scheduler=dask.threaded.get`\r\n\r\nQuestion: Should I also start to raise a proper error when people use the `get=` keyword? Currently we warn.","created_at":"2018-10-08T14:50:34Z","updated_at":"2018-10-11T03:55:13Z","closed_at":"2018-10-09T16:47:19Z","merged_at":"2018-10-09T16:47:19Z","merge_commit_sha":"49a6420f0fd635ef2e954896bc835f16a0af18c3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dask/dask/pulls/4062/commits","review_comments_url":"https://api.github.com/repos/dask/dask/pulls/4062/comments","review_comment_url":"https://api.github.com/repos/dask/dask/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dask/dask/issues/4062/comments","statuses_url":"https://api.github.com/repos/dask/dask/statuses/ddbdd3a971f0a288a4014282ff2c075a529bf630","head":{"label":"mrocklin:scheduler-get","ref":"scheduler-get","sha":"ddbdd3a971f0a288a4014282ff2c075a529bf630","user":{"login":"mrocklin","id":306380,"node_id":"MDQ6VXNlcjMwNjM4MA==","avatar_url":"https://avatars3.githubusercontent.com/u/306380?v=4","gravatar_id":"","url":"https://api.github.com/users/mrocklin","html_url":"https://github.com/mrocklin","followers_url":"https://api.github.com/users/mrocklin/followers","following_url":"https://api.github.com/users/mrocklin/following{/other_user}","gists_url":"https://api.github.com/users/mrocklin/gists{/gist_id}","starred_url":"https://api.github.com/users/mrocklin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrocklin/subscriptions","organizations_url":"https://api.github.com/users/mrocklin/orgs","repos_url":"https://api.github.com/users/mrocklin/repos","events_url":"https://api.github.com/users/mrocklin/events{/privacy}","received_events_url":"https://api.github.com/users/mrocklin/received_events","type":"User","site_admin":false},"repo":{"id":28313768,"node_id":"MDEwOlJlcG9zaXRvcnkyODMxMzc2OA==","name":"dask","full_name":"mrocklin/dask","private":false,"owner":{"login":"mrocklin","id":306380,"node_id":"MDQ6VXNlcjMwNjM4MA==","avatar_url":"https://avatars3.githubusercontent.com/u/306380?v=4","gravatar_id":"","url":"https://api.github.com/users/mrocklin","html_url":"https://github.com/mrocklin","followers_url":"https://api.github.com/users/mrocklin/followers","following_url":"https://api.github.com/users/mrocklin/following{/other_user}","gists_url":"https://api.github.com/users/mrocklin/gists{/gist_id}","starred_url":"https://api.github.com/users/mrocklin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrocklin/subscriptions","organizations_url":"https://api.github.com/users/mrocklin/orgs","repos_url":"https://api.github.com/users/mrocklin/repos","events_url":"https://api.github.com/users/mrocklin/events{/privacy}","received_events_url":"https://api.github.com/users/mrocklin/received_events","type":"User","site_admin":false},"html_url":"https://github.com/mrocklin/dask","description":"Task scheduling and blocked algorithms for parallel processing","fork":true,"url":"https://api.github.com/repos/mrocklin/dask","forks_url":"https://api.github.com/repos/mrocklin/dask/forks","keys_url":"https://api.github.com/repos/mrocklin/dask/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mrocklin/dask/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mrocklin/dask/teams","hooks_url":"https://api.github.com/repos/mrocklin/dask/hooks","issue_events_url":"https://api.github.com/repos/mrocklin/dask/issues/events{/number}","events_url":"https://api.github.com/repos/mrocklin/dask/events","assignees_url":"https://api.github.com/repos/mrocklin/dask/assignees{/user}","branches_url":"https://api.github.com/repos/mrocklin/dask/branches{/branch}","tags_url":"https://api.github.com/repos/mrocklin/dask/tags","blobs_url":"https://api.github.com/repos/mrocklin/dask/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mrocklin/dask/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mrocklin/dask/git/refs{/sha}","trees_url":"https://api.github.com/repos/mrocklin/dask/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mrocklin/dask/statuses/{sha}","languages_url":"https://api.github.com/repos/mrocklin/dask/languages","stargazers_url":"https://api.github.com/repos/mrocklin/dask/stargazers","contributors_url":"https://api.github.com/repos/mrocklin/dask/contributors","subscribers_url":"https://api.github.com/repos/mrocklin/dask/subscribers","subscription_url":"https://api.github.com/repos/mrocklin/dask/subscription","commits_url":"https://api.github.com/repos/mrocklin/dask/commits{/sha}","git_commits_url":"https://api.github.com/repos/mrocklin/dask/git/commits{/sha}","comments_url":"https://api.github.com/repos/mrocklin/dask/comments{/number}","issue_comment_url":"https://api.github.com/repos/mrocklin/dask/issues/comments{/number}","contents_url":"https://api.github.com/repos/mrocklin/dask/contents/{+path}","compare_url":"https://api.github.com/repos/mrocklin/dask/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mrocklin/dask/merges","archive_url":"https://api.github.com/repos/mrocklin/dask/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mrocklin/dask/downloads","issues_url":"https://api.github.com/repos/mrocklin/dask/issues{/number}","pulls_url":"https://api.github.com/repos/mrocklin/dask/pulls{/number}","milestones_url":"https://api.github.com/repos/mrocklin/dask/milestones{/number}","notifications_url":"https://api.github.com/repos/mrocklin/dask/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mrocklin/dask/labels{/name}","releases_url":"https://api.github.com/repos/mrocklin/dask/releases{/id}","deployments_url":"https://api.github.com/repos/mrocklin/dask/deployments","created_at":"2014-12-21T21:26:56Z","updated_at":"2018-09-26T21:48:55Z","pushed_at":"2018-10-10T17:05:11Z","git_url":"git://github.com/mrocklin/dask.git","ssh_url":"[email protected]:mrocklin/dask.git","clone_url":"https://github.com/mrocklin/dask.git","svn_url":"https://github.com/mrocklin/dask","homepage":"","size":18404,"stargazers_count":16,"watchers_count":16,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":16,"default_branch":"master"}},"base":{"label":"dask:master","ref":"master","sha":"1b03c8da258f77f8d18688da5a781459c0969613","user":{"login":"dask","id":17131925,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3MTMxOTI1","avatar_url":"https://avatars1.githubusercontent.com/u/17131925?v=4","gravatar_id":"","url":"https://api.github.com/users/dask","html_url":"https://github.com/dask","followers_url":"https://api.github.com/users/dask/followers","following_url":"https://api.github.com/users/dask/following{/other_user}","gists_url":"https://api.github.com/users/dask/gists{/gist_id}","starred_url":"https://api.github.com/users/dask/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dask/subscriptions","organizations_url":"https://api.github.com/users/dask/orgs","repos_url":"https://api.github.com/users/dask/repos","events_url":"https://api.github.com/users/dask/events{/privacy}","received_events_url":"https://api.github.com/users/dask/received_events","type":"Organization","site_admin":false},"repo":{"id":28782747,"node_id":"MDEwOlJlcG9zaXRvcnkyODc4Mjc0Nw==","name":"dask","full_name":"dask/dask","private":false,"owner":{"login":"dask","id":17131925,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3MTMxOTI1","avatar_url":"https://avatars1.githubusercontent.com/u/17131925?v=4","gravatar_id":"","url":"https://api.github.com/users/dask","html_url":"https://github.com/dask","followers_url":"https://api.github.com/users/dask/followers","following_url":"https://api.github.com/users/dask/following{/other_user}","gists_url":"https://api.github.com/users/dask/gists{/gist_id}","starred_url":"https://api.github.com/users/dask/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dask/subscriptions","organizations_url":"https://api.github.com/users/dask/orgs","repos_url":"https://api.github.com/users/dask/repos","events_url":"https://api.github.com/users/dask/events{/privacy}","received_events_url":"https://api.github.com/users/dask/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dask/dask","description":"Parallel computing with task scheduling","fork":false,"url":"https://api.github.com/repos/dask/dask","forks_url":"https://api.github.com/repos/dask/dask/forks","keys_url":"https://api.github.com/repos/dask/dask/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dask/dask/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dask/dask/teams","hooks_url":"https://api.github.com/repos/dask/dask/hooks","issue_events_url":"https://api.github.com/repos/dask/dask/issues/events{/number}","events_url":"https://api.github.com/repos/dask/dask/events","assignees_url":"https://api.github.com/repos/dask/dask/assignees{/user}","branches_url":"https://api.github.com/repos/dask/dask/branches{/branch}","tags_url":"https://api.github.com/repos/dask/dask/tags","blobs_url":"https://api.github.com/repos/dask/dask/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dask/dask/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dask/dask/git/refs{/sha}","trees_url":"https://api.github.com/repos/dask/dask/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dask/dask/statuses/{sha}","languages_url":"https://api.github.com/repos/dask/dask/languages","stargazers_url":"https://api.github.com/repos/dask/dask/stargazers","contributors_url":"https://api.github.com/repos/dask/dask/contributors","subscribers_url":"https://api.github.com/repos/dask/dask/subscribers","subscription_url":"https://api.github.com/repos/dask/dask/subscription","commits_url":"https://api.github.com/repos/dask/dask/commits{/sha}","git_commits_url":"https://api.github.com/repos/dask/dask/git/commits{/sha}","comments_url":"https://api.github.com/repos/dask/dask/comments{/number}","issue_comment_url":"https://api.github.com/repos/dask/dask/issues/comments{/number}","contents_url":"https://api.github.com/repos/dask/dask/contents/{+path}","compare_url":"https://api.github.com/repos/dask/dask/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dask/dask/merges","archive_url":"https://api.github.com/repos/dask/dask/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dask/dask/downloads","issues_url":"https://api.github.com/repos/dask/dask/issues{/number}","pulls_url":"https://api.github.com/repos/dask/dask/pulls{/number}","milestones_url":"https://api.github.com/repos/dask/dask/milestones{/number}","notifications_url":"https://api.github.com/repos/dask/dask/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dask/dask/labels{/name}","releases_url":"https://api.github.com/repos/dask/dask/releases{/id}","deployments_url":"https://api.github.com/repos/dask/dask/deployments","created_at":"2015-01-04T18:50:00Z","updated_at":"2018-10-11T00:49:01Z","pushed_at":"2018-10-11T03:25:40Z","git_url":"git://github.com/dask/dask.git","ssh_url":"[email protected]:dask/dask.git","clone_url":"https://github.com/dask/dask.git","svn_url":"https://github.com/dask/dask","homepage":"https://dask.org","size":18074,"stargazers_count":3531,"watchers_count":3531,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":599,"mirror_url":null,"archived":false,"open_issues_count":525,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":599,"open_issues":525,"watchers":3531,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dask/dask/pulls/4062"},"html":{"href":"https://github.com/dask/dask/pull/4062"},"issue":{"href":"https://api.github.com/repos/dask/dask/issues/4062"},"comments":{"href":"https://api.github.com/repos/dask/dask/issues/4062/comments"},"review_comments":{"href":"https://api.github.com/repos/dask/dask/pulls/4062/comments"},"review_comment":{"href":"https://api.github.com/repos/dask/dask/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dask/dask/pulls/4062/commits"},"statuses":{"href":"https://api.github.com/repos/dask/dask/statuses/ddbdd3a971f0a288a4014282ff2c075a529bf630"}},"author_association":"MEMBER"}} | {
"id": 28782747,
"name": "dask/dask",
"url": "https://api.github.com/repos/dask/dask"
} | {
"id": 492549,
"login": "jni",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/492549?",
"url": "https://api.github.com/users/jni"
} | {
"id": 17131925,
"login": "dask",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/17131925?",
"url": "https://api.github.com/orgs/dask"
} | 2018-10-11T03:55:13 | 8401956681 | {"actor":{"display_login":"jni"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-saml/pulls/comments/202875863","pull_request_review_id":137655412,"id":202875863,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMjg3NTg2Mw==","diff_hunk":"@@ -0,0 +1,95 @@\n+/*\n+ * Copyright (c) 2018, WSO2 Inc. (http://www.wso2.org) All Rights Reserved.\n+ *\n+ * WSO2 Inc. licenses this file to you under the Apache License,\n+ * Version 2.0 (the \"License\"); you may not use this file except\n+ * in compliance with the License.\n+ * You may obtain a copy of the License at\n+ *\n+ * http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing,\n+ * software distributed under the License is distributed on an\n+ * \"AS IS\" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY\n+ * KIND, either express or implied. See the License for the\n+ * specific language governing permissions and limitations\n+ * under the License.\n+ */\n+\n+package org.wso2.carbon.identity.sso.saml;\n+\n+import org.apache.commons.logging.Log;\n+import org.apache.commons.logging.LogFactory;\n+import org.apache.xml.security.exceptions.Base64DecodingException;\n+import org.apache.xml.security.utils.Base64;\n+import org.joda.time.DateTime;\n+import org.opensaml.saml2.core.Response;\n+import org.wso2.carbon.identity.base.IdentityException;\n+import org.wso2.carbon.identity.sso.saml.builders.ResponseBuilder;\n+import org.wso2.carbon.identity.sso.saml.dao.SAML2ArtifactInfoDAO;\n+import org.wso2.carbon.identity.sso.saml.dao.impl.SAML2ArtifactInfoDAOImpl;\n+import org.wso2.carbon.identity.sso.saml.dto.SAML2ArtifactInfo;\n+import org.wso2.carbon.identity.sso.saml.exception.ArtifactBindingException;\n+import org.wso2.carbon.identity.sso.saml.exception.IdentitySAML2SSOException;\n+import org.wso2.carbon.identity.sso.saml.util.SAMLSSOUtil;\n+\n+import java.security.NoSuchAlgorithmException;\n+\n+/**\n+ * This class is used to resolve a previously issued SAML2 artifact.\n+ */\n+public class SAMLSSOArtifactResolver {\n+\n+ private static Log log = LogFactory.getLog(SAMLSSOArtifactResolver.class);","path":"components/org.wso2.carbon.identity.sso.saml/src/main/java/org/wso2/carbon/identity/sso/saml/SAMLSSOArtifactResolver.java","position":43,"original_position":43,"commit_id":"720b46649b2d7e8fbef546d8947221a066a5932e","original_commit_id":"720b46649b2d7e8fbef546d8947221a066a5932e","user":{"login":"ruwanta","id":1294542,"node_id":"MDQ6VXNlcjEyOTQ1NDI=","avatar_url":"https://avatars2.githubusercontent.com/u/1294542?v=4","gravatar_id":"","url":"https://api.github.com/users/ruwanta","html_url":"https://github.com/ruwanta","followers_url":"https://api.github.com/users/ruwanta/followers","following_url":"https://api.github.com/users/ruwanta/following{/other_user}","gists_url":"https://api.github.com/users/ruwanta/gists{/gist_id}","starred_url":"https://api.github.com/users/ruwanta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ruwanta/subscriptions","organizations_url":"https://api.github.com/users/ruwanta/orgs","repos_url":"https://api.github.com/users/ruwanta/repos","events_url":"https://api.github.com/users/ruwanta/events{/privacy}","received_events_url":"https://api.github.com/users/ruwanta/received_events","type":"User","site_admin":false},"body":"private static final","created_at":"2018-07-17T02:03:15Z","updated_at":"2018-07-17T02:33:06Z","html_url":"https://github.com/wso2-extensions/identity-inbound-auth-saml/pull/188#discussion_r202875863","pull_request_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-saml/pulls/188","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-saml/pulls/comments/202875863"},"html":{"href":"https://github.com/wso2-extensions/identity-inbound-auth-saml/pull/188#discussion_r202875863"},"pull_request":{"href":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-saml/pulls/188"}}},"pull_request":{"url":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-saml/pulls/188","id":200629503,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAwNjI5NTAz","html_url":"https://github.com/wso2-extensions/identity-inbound-auth-saml/pull/188","diff_url":"https://github.com/wso2-extensions/identity-inbound-auth-saml/pull/188.diff","patch_url":"https://github.com/wso2-extensions/identity-inbound-auth-saml/pull/188.patch","issue_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-saml/issues/188","number":188,"state":"open","locked":false,"title":"SAML2 Artifact Binding - Basic response artifact binding flow","user":{"login":"vihanga-liyanage","id":9441136,"node_id":"MDQ6VXNlcjk0NDExMzY=","avatar_url":"https://avatars0.githubusercontent.com/u/9441136?v=4","gravatar_id":"","url":"https://api.github.com/users/vihanga-liyanage","html_url":"https://github.com/vihanga-liyanage","followers_url":"https://api.github.com/users/vihanga-liyanage/followers","following_url":"https://api.github.com/users/vihanga-liyanage/following{/other_user}","gists_url":"https://api.github.com/users/vihanga-liyanage/gists{/gist_id}","starred_url":"https://api.github.com/users/vihanga-liyanage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vihanga-liyanage/subscriptions","organizations_url":"https://api.github.com/users/vihanga-liyanage/orgs","repos_url":"https://api.github.com/users/vihanga-liyanage/repos","events_url":"https://api.github.com/users/vihanga-liyanage/events{/privacy}","received_events_url":"https://api.github.com/users/vihanga-liyanage/received_events","type":"User","site_admin":false},"body":"### Proposed changes \r\n- Issue SAML2 artifacts after checking for the artifact binding enablement property.\r\n- Save required data against artifact in the database.\r\n- Endpoint to resolve issued saml2 artifacts.\r\n- Resolve given artifact and send the SAML2 response by querying the database.\r\n\r\nRefers https://github.com/wso2/product-is/issues/3401","created_at":"2018-07-11T08:55:27Z","updated_at":"2018-07-17T02:33:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"99b77c76b5923d8230bfe9b314ad3bf074f72aa6","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-saml/pulls/188/commits","review_comments_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-saml/pulls/188/comments","review_comment_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-saml/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-saml/issues/188/comments","statuses_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-saml/statuses/720b46649b2d7e8fbef546d8947221a066a5932e","head":{"label":"vihanga-liyanage:artifct-basic","ref":"artifct-basic","sha":"720b46649b2d7e8fbef546d8947221a066a5932e","user":{"login":"vihanga-liyanage","id":9441136,"node_id":"MDQ6VXNlcjk0NDExMzY=","avatar_url":"https://avatars0.githubusercontent.com/u/9441136?v=4","gravatar_id":"","url":"https://api.github.com/users/vihanga-liyanage","html_url":"https://github.com/vihanga-liyanage","followers_url":"https://api.github.com/users/vihanga-liyanage/followers","following_url":"https://api.github.com/users/vihanga-liyanage/following{/other_user}","gists_url":"https://api.github.com/users/vihanga-liyanage/gists{/gist_id}","starred_url":"https://api.github.com/users/vihanga-liyanage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vihanga-liyanage/subscriptions","organizations_url":"https://api.github.com/users/vihanga-liyanage/orgs","repos_url":"https://api.github.com/users/vihanga-liyanage/repos","events_url":"https://api.github.com/users/vihanga-liyanage/events{/privacy}","received_events_url":"https://api.github.com/users/vihanga-liyanage/received_events","type":"User","site_admin":false},"repo":{"id":138997160,"node_id":"MDEwOlJlcG9zaXRvcnkxMzg5OTcxNjA=","name":"identity-inbound-auth-saml","full_name":"vihanga-liyanage/identity-inbound-auth-saml","owner":{"login":"vihanga-liyanage","id":9441136,"node_id":"MDQ6VXNlcjk0NDExMzY=","avatar_url":"https://avatars0.githubusercontent.com/u/9441136?v=4","gravatar_id":"","url":"https://api.github.com/users/vihanga-liyanage","html_url":"https://github.com/vihanga-liyanage","followers_url":"https://api.github.com/users/vihanga-liyanage/followers","following_url":"https://api.github.com/users/vihanga-liyanage/following{/other_user}","gists_url":"https://api.github.com/users/vihanga-liyanage/gists{/gist_id}","starred_url":"https://api.github.com/users/vihanga-liyanage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vihanga-liyanage/subscriptions","organizations_url":"https://api.github.com/users/vihanga-liyanage/orgs","repos_url":"https://api.github.com/users/vihanga-liyanage/repos","events_url":"https://api.github.com/users/vihanga-liyanage/events{/privacy}","received_events_url":"https://api.github.com/users/vihanga-liyanage/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vihanga-liyanage/identity-inbound-auth-saml","description":null,"fork":true,"url":"https://api.github.com/repos/vihanga-liyanage/identity-inbound-auth-saml","forks_url":"https://api.github.com/repos/vihanga-liyanage/identity-inbound-auth-saml/forks","keys_url":"https://api.github.com/repos/vihanga-liyanage/identity-inbound-auth-saml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vihanga-liyanage/identity-inbound-auth-saml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vihanga-liyanage/identity-inbound-auth-saml/teams","hooks_url":"https://api.github.com/repos/vihanga-liyanage/identity-inbound-auth-saml/hooks","issue_events_url":"https://api.github.com/repos/vihanga-liyanage/identity-inbound-auth-saml/issues/events{/number}","events_url":"https://api.github.com/repos/vihanga-liyanage/identity-inbound-auth-saml/events","assignees_url":"https://api.github.com/repos/vihanga-liyanage/identity-inbound-auth-saml/assignees{/user}","branches_url":"https://api.github.com/repos/vihanga-liyanage/identity-inbound-auth-saml/branches{/branch}","tags_url":"https://api.github.com/repos/vihanga-liyanage/identity-inbound-auth-saml/tags","blobs_url":"https://api.github.com/repos/vihanga-liyanage/identity-inbound-auth-saml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vihanga-liyanage/identity-inbound-auth-saml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vihanga-liyanage/identity-inbound-auth-saml/git/refs{/sha}","trees_url":"https://api.github.com/repos/vihanga-liyanage/identity-inbound-auth-saml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vihanga-liyanage/identity-inbound-auth-saml/statuses/{sha}","languages_url":"https://api.github.com/repos/vihanga-liyanage/identity-inbound-auth-saml/languages","stargazers_url":"https://api.github.com/repos/vihanga-liyanage/identity-inbound-auth-saml/stargazers","contributors_url":"https://api.github.com/repos/vihanga-liyanage/identity-inbound-auth-saml/contributors","subscribers_url":"https://api.github.com/repos/vihanga-liyanage/identity-inbound-auth-saml/subscribers","subscription_url":"https://api.github.com/repos/vihanga-liyanage/identity-inbound-auth-saml/subscription","commits_url":"https://api.github.com/repos/vihanga-liyanage/identity-inbound-auth-saml/commits{/sha}","git_commits_url":"https://api.github.com/repos/vihanga-liyanage/identity-inbound-auth-saml/git/commits{/sha}","comments_url":"https://api.github.com/repos/vihanga-liyanage/identity-inbound-auth-saml/comments{/number}","issue_comment_url":"https://api.github.com/repos/vihanga-liyanage/identity-inbound-auth-saml/issues/comments{/number}","contents_url":"https://api.github.com/repos/vihanga-liyanage/identity-inbound-auth-saml/contents/{+path}","compare_url":"https://api.github.com/repos/vihanga-liyanage/identity-inbound-auth-saml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vihanga-liyanage/identity-inbound-auth-saml/merges","archive_url":"https://api.github.com/repos/vihanga-liyanage/identity-inbound-auth-saml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vihanga-liyanage/identity-inbound-auth-saml/downloads","issues_url":"https://api.github.com/repos/vihanga-liyanage/identity-inbound-auth-saml/issues{/number}","pulls_url":"https://api.github.com/repos/vihanga-liyanage/identity-inbound-auth-saml/pulls{/number}","milestones_url":"https://api.github.com/repos/vihanga-liyanage/identity-inbound-auth-saml/milestones{/number}","notifications_url":"https://api.github.com/repos/vihanga-liyanage/identity-inbound-auth-saml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vihanga-liyanage/identity-inbound-auth-saml/labels{/name}","releases_url":"https://api.github.com/repos/vihanga-liyanage/identity-inbound-auth-saml/releases{/id}","deployments_url":"https://api.github.com/repos/vihanga-liyanage/identity-inbound-auth-saml/deployments","created_at":"2018-06-28T09:30:51Z","updated_at":"2018-06-28T09:30:54Z","pushed_at":"2018-07-16T16:30:49Z","git_url":"git://github.com/vihanga-liyanage/identity-inbound-auth-saml.git","ssh_url":"[email protected]:vihanga-liyanage/identity-inbound-auth-saml.git","clone_url":"https://github.com/vihanga-liyanage/identity-inbound-auth-saml.git","svn_url":"https://github.com/vihanga-liyanage/identity-inbound-auth-saml","homepage":null,"size":2134,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"wso2-extensions:master","ref":"master","sha":"821fa9673322269547fa48eede1652bd79e44fc3","user":{"login":"wso2-extensions","id":17171218,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3MTcxMjE4","avatar_url":"https://avatars0.githubusercontent.com/u/17171218?v=4","gravatar_id":"","url":"https://api.github.com/users/wso2-extensions","html_url":"https://github.com/wso2-extensions","followers_url":"https://api.github.com/users/wso2-extensions/followers","following_url":"https://api.github.com/users/wso2-extensions/following{/other_user}","gists_url":"https://api.github.com/users/wso2-extensions/gists{/gist_id}","starred_url":"https://api.github.com/users/wso2-extensions/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wso2-extensions/subscriptions","organizations_url":"https://api.github.com/users/wso2-extensions/orgs","repos_url":"https://api.github.com/users/wso2-extensions/repos","events_url":"https://api.github.com/users/wso2-extensions/events{/privacy}","received_events_url":"https://api.github.com/users/wso2-extensions/received_events","type":"Organization","site_admin":false},"repo":{"id":52759151,"node_id":"MDEwOlJlcG9zaXRvcnk1Mjc1OTE1MQ==","name":"identity-inbound-auth-saml","full_name":"wso2-extensions/identity-inbound-auth-saml","owner":{"login":"wso2-extensions","id":17171218,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3MTcxMjE4","avatar_url":"https://avatars0.githubusercontent.com/u/17171218?v=4","gravatar_id":"","url":"https://api.github.com/users/wso2-extensions","html_url":"https://github.com/wso2-extensions","followers_url":"https://api.github.com/users/wso2-extensions/followers","following_url":"https://api.github.com/users/wso2-extensions/following{/other_user}","gists_url":"https://api.github.com/users/wso2-extensions/gists{/gist_id}","starred_url":"https://api.github.com/users/wso2-extensions/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wso2-extensions/subscriptions","organizations_url":"https://api.github.com/users/wso2-extensions/orgs","repos_url":"https://api.github.com/users/wso2-extensions/repos","events_url":"https://api.github.com/users/wso2-extensions/events{/privacy}","received_events_url":"https://api.github.com/users/wso2-extensions/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wso2-extensions/identity-inbound-auth-saml","description":null,"fork":false,"url":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-saml","forks_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-saml/forks","keys_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-saml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-saml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-saml/teams","hooks_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-saml/hooks","issue_events_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-saml/issues/events{/number}","events_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-saml/events","assignees_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-saml/assignees{/user}","branches_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-saml/branches{/branch}","tags_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-saml/tags","blobs_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-saml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-saml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-saml/git/refs{/sha}","trees_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-saml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-saml/statuses/{sha}","languages_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-saml/languages","stargazers_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-saml/stargazers","contributors_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-saml/contributors","subscribers_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-saml/subscribers","subscription_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-saml/subscription","commits_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-saml/commits{/sha}","git_commits_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-saml/git/commits{/sha}","comments_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-saml/comments{/number}","issue_comment_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-saml/issues/comments{/number}","contents_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-saml/contents/{+path}","compare_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-saml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-saml/merges","archive_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-saml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-saml/downloads","issues_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-saml/issues{/number}","pulls_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-saml/pulls{/number}","milestones_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-saml/milestones{/number}","notifications_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-saml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-saml/labels{/name}","releases_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-saml/releases{/id}","deployments_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-saml/deployments","created_at":"2016-02-29T02:49:36Z","updated_at":"2018-07-10T05:40:42Z","pushed_at":"2018-07-16T16:30:51Z","git_url":"git://github.com/wso2-extensions/identity-inbound-auth-saml.git","ssh_url":"[email protected]:wso2-extensions/identity-inbound-auth-saml.git","clone_url":"https://github.com/wso2-extensions/identity-inbound-auth-saml.git","svn_url":"https://github.com/wso2-extensions/identity-inbound-auth-saml","homepage":null,"size":2052,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":57,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":57,"open_issues":7,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-saml/pulls/188"},"html":{"href":"https://github.com/wso2-extensions/identity-inbound-auth-saml/pull/188"},"issue":{"href":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-saml/issues/188"},"comments":{"href":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-saml/issues/188/comments"},"review_comments":{"href":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-saml/pulls/188/comments"},"review_comment":{"href":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-saml/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-saml/pulls/188/commits"},"statuses":{"href":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-saml/statuses/720b46649b2d7e8fbef546d8947221a066a5932e"}},"author_association":"CONTRIBUTOR"}} | {
"id": 52759151,
"name": "wso2-extensions/identity-inbound-auth-saml",
"url": "https://api.github.com/repos/wso2-extensions/identity-inbound-auth-saml"
} | {
"id": 1294542,
"login": "ruwanta",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1294542?",
"url": "https://api.github.com/users/ruwanta"
} | {
"id": 17171218,
"login": "wso2-extensions",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/17171218?",
"url": "https://api.github.com/orgs/wso2-extensions"
} | 2018-07-17T02:03:15 | 7973983826 | {"actor":{"display_login":"ruwanta"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/wso2-extensions/identity-data-publisher-authentication/pulls/comments/218793393","pull_request_review_id":156798373,"id":218793393,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxODc5MzM5Mw==","diff_hunk":"@@ -0,0 +1,219 @@\n+/*\n+ * Copyright (c) 2018, WSO2 Inc. (http://www.wso2.org) All Rights Reserved.\n+ *\n+ * WSO2 Inc. licenses this file to you under the Apache License,\n+ * Version 2.0 (the \"License\"); you may not use this file except\n+ * in compliance with the License.\n+ * You may obtain a copy of the License at\n+ *\n+ * http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing,\n+ * software distributed under the License is distributed on an\n+ * \"AS IS\" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY\n+ * KIND, either express or implied. See the License for the\n+ * specific language governing permissions and limitations\n+ * under the License.\n+ */\n+\n+package org.wso2.carbon.identity.data.publisher.authentication.audit;\n+\n+import org.apache.commons.logging.Log;\n+import org.apache.commons.logging.LogFactory;\n+import org.wso2.carbon.CarbonConstants;\n+import org.wso2.carbon.identity.application.authentication.framework.config.model.ExternalIdPConfig;\n+import org.wso2.carbon.identity.application.authentication.framework.config.model.SequenceConfig;\n+import org.wso2.carbon.identity.application.authentication.framework.context.AuthenticationContext;\n+import org.wso2.carbon.identity.application.authentication.framework.context.SessionContext;\n+import org.wso2.carbon.identity.application.authentication.framework.model.AuthenticatedUser;\n+import org.wso2.carbon.identity.application.authentication.framework.model.AuthenticationResult;\n+import org.wso2.carbon.identity.application.authentication.framework.util.FrameworkConstants;\n+import org.wso2.carbon.identity.data.publisher.authentication.audit.model.AuthenticationAuditData;\n+import org.wso2.carbon.identity.event.IdentityEventConstants;\n+import org.wso2.carbon.identity.event.IdentityEventException;\n+import org.wso2.carbon.identity.event.event.Event;\n+import org.wso2.carbon.identity.event.handler.AbstractEventHandler;\n+\n+import java.util.Map;\n+\n+/**\n+ * Log the authentication login data.\n+ */\n+public class AuthenticationAuditLoggingHandler extends AbstractEventHandler {\n+\n+ private static final Log AUDIT_LOG = CarbonConstants.AUDIT_LOG;\n+ private static final Log LOG = LogFactory.getLog(AuthenticationAuditLoggingHandler.class);\n+\n+ @Override\n+ public String getName() {\n+\n+ return AuthenticationAuditLoggerConstants.AUTHENTICATION_AUDIT_LOGGER;\n+ }\n+\n+ @Override\n+ public void handleEvent(Event event) throws IdentityEventException {\n+\n+ AuthenticationAuditData authenticationAuditData = null;\n+ if (event.getEventName().equals(IdentityEventConstants.EventName.AUTHENTICATION_STEP_SUCCESS.name())) {\n+ authenticationAuditData = AuthenticationAuditLoggerUtils.createAuthenticationAudiDataObject(event,\n+ AuthenticationAuditLoggerConstants.AUDIT_AUTHENTICATION_STEP);\n+ doPublishAuthenticationStepSuccess(authenticationAuditData);\n+\n+ } else if (event.getEventName().equals(IdentityEventConstants.EventName.AUTHENTICATION_STEP_FAILURE.name())) {\n+ authenticationAuditData = AuthenticationAuditLoggerUtils.createAuthenticationAudiDataObject(event,\n+ AuthenticationAuditLoggerConstants.AUDIT_AUTHENTICATION_STEP);\n+ doPublishAuthenticationStepFailure(authenticationAuditData);\n+\n+ } else if (event.getEventName().equals(IdentityEventConstants.EventName.AUTHENTICATION_SUCCESS.name())) {\n+ authenticationAuditData = AuthenticationAuditLoggerUtils.createAuthenticationAudiDataObject(event,\n+ AuthenticationAuditLoggerConstants.AUDIT_AUTHENTICATION);\n+ doPublishAuthenticationSuccess(authenticationAuditData);\n+\n+ } else if (event.getEventName().equals(IdentityEventConstants.EventName.AUTHENTICATION_FAILURE.name())) {\n+ authenticationAuditData = AuthenticationAuditLoggerUtils.createAuthenticationAudiDataObject(event,\n+ AuthenticationAuditLoggerConstants.AUDIT_AUTHENTICATION);\n+ doPublishAuthenticationFailure(authenticationAuditData);\n+\n+ } else if (event.getEventName().equals(IdentityEventConstants.EventName.SESSION_TERMINATE.name())) {\n+ publishSessionTermination(event);\n+ } else {\n+ LOG.error(\"Event \" + event.getEventName() + \" cannot be handled\");\n+ }\n+ }\n+\n+ protected void doPublishAuthenticationStepSuccess(AuthenticationAuditData authenticationData) {\n+\n+ String auditData = \"\\\"\" + \"ContextIdentifier\" + \"\\\" : \\\"\" + authenticationData.getContextIdentifier()\n+ + \"\\\",\\\"\" + \"AuthenticatedUser\" + \"\\\" : \\\"\" + authenticationData.getAuthenticatedUser()\n+ + \"\\\",\\\"\" + \"AuthenticatedUserTenantDomain\" + \"\\\" : \\\"\" + authenticationData.getTenantDomain()\n+ + \"\\\",\\\"\" + \"ServiceProviderName\" + \"\\\" : \\\"\" + authenticationData.getServiceProvider()\n+ + \"\\\",\\\"\" + \"RequestType\" + \"\\\" : \\\"\" + authenticationData.getInboundProtocol()\n+ + \"\\\",\\\"\" + \"RelyingParty\" + \"\\\" : \\\"\" + authenticationData.getRelyingParty()\n+ + \"\\\",\\\"\" + \"AuthenticatedIdP\" + \"\\\" : \\\"\" + authenticationData.getAuthenticatedIdps()\n+ + \"\\\"\";\n+\n+ AUDIT_LOG.info(String.format(\n+ FrameworkConstants.AUDIT_MESSAGE,\n+ authenticationData.getAuthenticatedUser(),\n+ \"LoginStepSuccess\",\n+ \"ApplicationAuthenticationFramework\", auditData, FrameworkConstants.AUDIT_SUCCESS));\n+\n+ }\n+\n+ protected void doPublishAuthenticationStepFailure(AuthenticationAuditData authenticationData) {\n+\n+ String auditData = \"\\\"\" + \"ContextIdentifier\" + \"\\\" : \\\"\" + authenticationData.getContextIdentifier()\n+ + \"\\\",\\\"\" + \"ServiceProviderName\" + \"\\\" : \\\"\" + authenticationData.getServiceProvider()\n+ + \"\\\",\\\"\" + \"RequestType\" + \"\\\" : \\\"\" + authenticationData.getInboundProtocol()\n+ + \"\\\",\\\"\" + \"RelyingParty\" + \"\\\" : \\\"\" + authenticationData.getRelyingParty()\n+ + \"\\\",\\\"\" + \"StepNo\" + \"\\\" : \\\"\" + authenticationData.getStepNo()\n+ + \"\\\"\";\n+\n+ AUDIT_LOG.info(String.format(\n+ FrameworkConstants.AUDIT_MESSAGE,\n+ null,\n+ \"Login\",\n+ \"ApplicationAuthenticationFramework\", auditData, FrameworkConstants.AUDIT_FAILED));\n+ }\n+\n+ protected void doPublishAuthenticationSuccess(AuthenticationAuditData authenticationData) {\n+\n+ AuthenticationResult authenticationResult = new AuthenticationResult();\n+ authenticationResult.setAuthenticated(true);\n+ String auditData = \"\\\"\" + \"ContextIdentifier\" + \"\\\" : \\\"\" + authenticationData.getContextIdentifier()\n+ + \"\\\",\\\"\" + \"AuthenticatedUser\" + \"\\\" : \\\"\" + authenticationData.getAuthenticatedUser()\n+ + \"\\\",\\\"\" + \"AuthenticatedUserTenantDomain\" + \"\\\" : \\\"\" + authenticationData.getTenantDomain()\n+ + \"\\\",\\\"\" + \"ServiceProviderName\" + \"\\\" : \\\"\" + authenticationData.getServiceProvider()\n+ + \"\\\",\\\"\" + \"RequestType\" + \"\\\" : \\\"\" + authenticationData.getInboundProtocol()\n+ + \"\\\",\\\"\" + \"RelyingParty\" + \"\\\" : \\\"\" + authenticationData.getRelyingParty()\n+ + \"\\\",\\\"\" + \"AuthenticatedIdPs\" + \"\\\" : \\\"\" + authenticationData.getAuthenticatedIdps()\n+ + \"\\\"\";\n+\n+ AUDIT_LOG.info(String.format(\n+ FrameworkConstants.AUDIT_MESSAGE,\n+ authenticationData.getAuthenticatedUser(),\n+ \"Login\",\n+ \"ApplicationAuthenticationFramework\", auditData, FrameworkConstants.AUDIT_SUCCESS));\n+ }\n+\n+ protected void doPublishAuthenticationFailure(AuthenticationAuditData authenticationData) {\n+\n+ String auditData = \"\\\"\" + \"ContextIdentifier\" + \"\\\" : \\\"\" + authenticationData.getContextIdentifier()\n+ + \"\\\",\\\"\" + \"ServiceProviderName\" + \"\\\" : \\\"\" + authenticationData.getServiceProvider()\n+ + \"\\\",\\\"\" + \"RequestType\" + \"\\\" : \\\"\" + authenticationData.getInboundProtocol()\n+ + \"\\\",\\\"\" + \"RelyingParty\" + \"\\\" : \\\"\" + authenticationData.getRelyingParty()\n+ + \"\\\",\\\"\" + \"StepNo\" + \"\\\" : \\\"\" + authenticationData.getStepNo()\n+ + \"\\\"\";\n+\n+ AUDIT_LOG.info(String.format(\n+ FrameworkConstants.AUDIT_MESSAGE,\n+ null,\n+ \"Login\",\n+ \"ApplicationAuthenticationFramework\", auditData, FrameworkConstants.AUDIT_FAILED));\n+ }\n+\n+\n+ protected void doPublishSessionTermination(AuthenticationContext context, String username,\n+ String tenantDomain, String authenticatedIDPs) {\n+\n+ String auditData = \"\\\"\" + \"ContextIdentifier\" + \"\\\" : \\\"\" + context.getContextIdentifier()\n+\n+ + \"\\\",\\\"\" + \"LoggedOutUser\" + \"\\\" : \\\"\" + username\n+ + \"\\\",\\\"\" + \"LoggedOutUserTenantDomain\" + \"\\\" : \\\"\" + tenantDomain\n+ + \"\\\",\\\"\" + \"ServiceProviderName\" + \"\\\" : \\\"\" + context.getServiceProviderName()\n+ + \"\\\",\\\"\" + \"RequestType\" + \"\\\" : \\\"\" + context.getRequestType()\n+ + \"\\\",\\\"\" + \"RelyingParty\" + \"\\\" : \\\"\" + context.getRelyingParty()\n+ + \"\\\",\\\"\" + \"AuthenticatedIdPs\" + \"\\\" : \\\"\" + authenticatedIDPs\n+ + \"\\\"\";\n+\n+ String idpName = null;\n+ ExternalIdPConfig externalIdPConfig = context.getExternalIdP();\n+ if (externalIdPConfig != null) {\n+ idpName = externalIdPConfig.getName();\n+ }\n+ AUDIT_LOG.info(String.format(\n+ FrameworkConstants.AUDIT_MESSAGE,\n+ username,\n+ \"Logout\", idpName, auditData, FrameworkConstants.AUDIT_SUCCESS));\n+ }\n+\n+\n+\n+ protected void publishSessionTermination(Event event) {","path":"components/org.wso2.carbon.identity.data.publisher.authentication.audit/src/main/java/org/wso2/carbon/identity/data/publisher/authentication/audit/AuthenticationAuditLoggingHandler.java","position":182,"original_position":182,"commit_id":"76eb781481d4a3b00e2a1d30f8094356f2c4295a","original_commit_id":"76eb781481d4a3b00e2a1d30f8094356f2c4295a","user":{"login":"hasinthaindrajee","id":3666100,"node_id":"MDQ6VXNlcjM2NjYxMDA=","avatar_url":"https://avatars0.githubusercontent.com/u/3666100?v=4","gravatar_id":"","url":"https://api.github.com/users/hasinthaindrajee","html_url":"https://github.com/hasinthaindrajee","followers_url":"https://api.github.com/users/hasinthaindrajee/followers","following_url":"https://api.github.com/users/hasinthaindrajee/following{/other_user}","gists_url":"https://api.github.com/users/hasinthaindrajee/gists{/gist_id}","starred_url":"https://api.github.com/users/hasinthaindrajee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hasinthaindrajee/subscriptions","organizations_url":"https://api.github.com/users/hasinthaindrajee/orgs","repos_url":"https://api.github.com/users/hasinthaindrajee/repos","events_url":"https://api.github.com/users/hasinthaindrajee/events{/privacy}","received_events_url":"https://api.github.com/users/hasinthaindrajee/received_events","type":"User","site_admin":false},"body":"Let's rename these methods to more meaningful names. Now we are no longer publishing anything and this is not extended from publishers. These handlers are writing to audit logs. So lets use more meaningful names.","created_at":"2018-09-19T13:03:01Z","updated_at":"2018-09-19T13:04:52Z","html_url":"https://github.com/wso2-extensions/identity-data-publisher-authentication/pull/61#discussion_r218793393","pull_request_url":"https://api.github.com/repos/wso2-extensions/identity-data-publisher-authentication/pulls/61","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/wso2-extensions/identity-data-publisher-authentication/pulls/comments/218793393"},"html":{"href":"https://github.com/wso2-extensions/identity-data-publisher-authentication/pull/61#discussion_r218793393"},"pull_request":{"href":"https://api.github.com/repos/wso2-extensions/identity-data-publisher-authentication/pulls/61"}}},"pull_request":{"url":"https://api.github.com/repos/wso2-extensions/identity-data-publisher-authentication/pulls/61","id":211524466,"node_id":"MDExOlB1bGxSZXF1ZXN0MjExNTI0NDY2","html_url":"https://github.com/wso2-extensions/identity-data-publisher-authentication/pull/61","diff_url":"https://github.com/wso2-extensions/identity-data-publisher-authentication/pull/61.diff","patch_url":"https://github.com/wso2-extensions/identity-data-publisher-authentication/pull/61.patch","issue_url":"https://api.github.com/repos/wso2-extensions/identity-data-publisher-authentication/issues/61","number":61,"state":"open","locked":false,"title":"Existing data publishers were changed into event handlers.","user":{"login":"sachiniWettasinghe","id":19415049,"node_id":"MDQ6VXNlcjE5NDE1MDQ5","avatar_url":"https://avatars0.githubusercontent.com/u/19415049?v=4","gravatar_id":"","url":"https://api.github.com/users/sachiniWettasinghe","html_url":"https://github.com/sachiniWettasinghe","followers_url":"https://api.github.com/users/sachiniWettasinghe/followers","following_url":"https://api.github.com/users/sachiniWettasinghe/following{/other_user}","gists_url":"https://api.github.com/users/sachiniWettasinghe/gists{/gist_id}","starred_url":"https://api.github.com/users/sachiniWettasinghe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sachiniWettasinghe/subscriptions","organizations_url":"https://api.github.com/users/sachiniWettasinghe/orgs","repos_url":"https://api.github.com/users/sachiniWettasinghe/repos","events_url":"https://api.github.com/users/sachiniWettasinghe/events{/privacy}","received_events_url":"https://api.github.com/users/sachiniWettasinghe/received_events","type":"User","site_admin":false},"body":"**Proposed changes in this pull request**\r\n\r\n- Existing data publishers (DASLoginDataPublisherImpl, DASSessionDataPublisherImplTest, and AuthenticationAuditLogger) which implemented the AbstractAuthenticationDataPublisher were deprecated and changed to implement AbstractEventHanlder to act as event handlers namely AnalyticsLoginDataPublishHandler, AnalyticsSessionDataPublishHandler, and AuthenticationAuditLoggingHandler. \r\n- The AuthnDataPublisherProxy was updated to support both iterative data publishing and invoking event handlers through IdentityEventService.\r\n- AbstractAuthenticationDataPublisher was deprecated.\r\n- Unit tests for AnalyticsLoginDataPublishHandler and AnalyticsSessionDataPublishHandler were added. ","created_at":"2018-08-28T19:00:53Z","updated_at":"2018-09-19T13:04:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d8fdbcb184879cc1b417bdce4b6bc15db534ae30","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/wso2-extensions/identity-data-publisher-authentication/pulls/61/commits","review_comments_url":"https://api.github.com/repos/wso2-extensions/identity-data-publisher-authentication/pulls/61/comments","review_comment_url":"https://api.github.com/repos/wso2-extensions/identity-data-publisher-authentication/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wso2-extensions/identity-data-publisher-authentication/issues/61/comments","statuses_url":"https://api.github.com/repos/wso2-extensions/identity-data-publisher-authentication/statuses/76eb781481d4a3b00e2a1d30f8094356f2c4295a","head":{"label":"sachiniWettasinghe:test_cpl_feature","ref":"test_cpl_feature","sha":"76eb781481d4a3b00e2a1d30f8094356f2c4295a","user":{"login":"sachiniWettasinghe","id":19415049,"node_id":"MDQ6VXNlcjE5NDE1MDQ5","avatar_url":"https://avatars0.githubusercontent.com/u/19415049?v=4","gravatar_id":"","url":"https://api.github.com/users/sachiniWettasinghe","html_url":"https://github.com/sachiniWettasinghe","followers_url":"https://api.github.com/users/sachiniWettasinghe/followers","following_url":"https://api.github.com/users/sachiniWettasinghe/following{/other_user}","gists_url":"https://api.github.com/users/sachiniWettasinghe/gists{/gist_id}","starred_url":"https://api.github.com/users/sachiniWettasinghe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sachiniWettasinghe/subscriptions","organizations_url":"https://api.github.com/users/sachiniWettasinghe/orgs","repos_url":"https://api.github.com/users/sachiniWettasinghe/repos","events_url":"https://api.github.com/users/sachiniWettasinghe/events{/privacy}","received_events_url":"https://api.github.com/users/sachiniWettasinghe/received_events","type":"User","site_admin":false},"repo":{"id":144407980,"node_id":"MDEwOlJlcG9zaXRvcnkxNDQ0MDc5ODA=","name":"identity-data-publisher-authentication","full_name":"sachiniWettasinghe/identity-data-publisher-authentication","private":false,"owner":{"login":"sachiniWettasinghe","id":19415049,"node_id":"MDQ6VXNlcjE5NDE1MDQ5","avatar_url":"https://avatars0.githubusercontent.com/u/19415049?v=4","gravatar_id":"","url":"https://api.github.com/users/sachiniWettasinghe","html_url":"https://github.com/sachiniWettasinghe","followers_url":"https://api.github.com/users/sachiniWettasinghe/followers","following_url":"https://api.github.com/users/sachiniWettasinghe/following{/other_user}","gists_url":"https://api.github.com/users/sachiniWettasinghe/gists{/gist_id}","starred_url":"https://api.github.com/users/sachiniWettasinghe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sachiniWettasinghe/subscriptions","organizations_url":"https://api.github.com/users/sachiniWettasinghe/orgs","repos_url":"https://api.github.com/users/sachiniWettasinghe/repos","events_url":"https://api.github.com/users/sachiniWettasinghe/events{/privacy}","received_events_url":"https://api.github.com/users/sachiniWettasinghe/received_events","type":"User","site_admin":false},"html_url":"https://github.com/sachiniWettasinghe/identity-data-publisher-authentication","description":null,"fork":true,"url":"https://api.github.com/repos/sachiniWettasinghe/identity-data-publisher-authentication","forks_url":"https://api.github.com/repos/sachiniWettasinghe/identity-data-publisher-authentication/forks","keys_url":"https://api.github.com/repos/sachiniWettasinghe/identity-data-publisher-authentication/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sachiniWettasinghe/identity-data-publisher-authentication/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sachiniWettasinghe/identity-data-publisher-authentication/teams","hooks_url":"https://api.github.com/repos/sachiniWettasinghe/identity-data-publisher-authentication/hooks","issue_events_url":"https://api.github.com/repos/sachiniWettasinghe/identity-data-publisher-authentication/issues/events{/number}","events_url":"https://api.github.com/repos/sachiniWettasinghe/identity-data-publisher-authentication/events","assignees_url":"https://api.github.com/repos/sachiniWettasinghe/identity-data-publisher-authentication/assignees{/user}","branches_url":"https://api.github.com/repos/sachiniWettasinghe/identity-data-publisher-authentication/branches{/branch}","tags_url":"https://api.github.com/repos/sachiniWettasinghe/identity-data-publisher-authentication/tags","blobs_url":"https://api.github.com/repos/sachiniWettasinghe/identity-data-publisher-authentication/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sachiniWettasinghe/identity-data-publisher-authentication/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sachiniWettasinghe/identity-data-publisher-authentication/git/refs{/sha}","trees_url":"https://api.github.com/repos/sachiniWettasinghe/identity-data-publisher-authentication/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sachiniWettasinghe/identity-data-publisher-authentication/statuses/{sha}","languages_url":"https://api.github.com/repos/sachiniWettasinghe/identity-data-publisher-authentication/languages","stargazers_url":"https://api.github.com/repos/sachiniWettasinghe/identity-data-publisher-authentication/stargazers","contributors_url":"https://api.github.com/repos/sachiniWettasinghe/identity-data-publisher-authentication/contributors","subscribers_url":"https://api.github.com/repos/sachiniWettasinghe/identity-data-publisher-authentication/subscribers","subscription_url":"https://api.github.com/repos/sachiniWettasinghe/identity-data-publisher-authentication/subscription","commits_url":"https://api.github.com/repos/sachiniWettasinghe/identity-data-publisher-authentication/commits{/sha}","git_commits_url":"https://api.github.com/repos/sachiniWettasinghe/identity-data-publisher-authentication/git/commits{/sha}","comments_url":"https://api.github.com/repos/sachiniWettasinghe/identity-data-publisher-authentication/comments{/number}","issue_comment_url":"https://api.github.com/repos/sachiniWettasinghe/identity-data-publisher-authentication/issues/comments{/number}","contents_url":"https://api.github.com/repos/sachiniWettasinghe/identity-data-publisher-authentication/contents/{+path}","compare_url":"https://api.github.com/repos/sachiniWettasinghe/identity-data-publisher-authentication/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sachiniWettasinghe/identity-data-publisher-authentication/merges","archive_url":"https://api.github.com/repos/sachiniWettasinghe/identity-data-publisher-authentication/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sachiniWettasinghe/identity-data-publisher-authentication/downloads","issues_url":"https://api.github.com/repos/sachiniWettasinghe/identity-data-publisher-authentication/issues{/number}","pulls_url":"https://api.github.com/repos/sachiniWettasinghe/identity-data-publisher-authentication/pulls{/number}","milestones_url":"https://api.github.com/repos/sachiniWettasinghe/identity-data-publisher-authentication/milestones{/number}","notifications_url":"https://api.github.com/repos/sachiniWettasinghe/identity-data-publisher-authentication/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sachiniWettasinghe/identity-data-publisher-authentication/labels{/name}","releases_url":"https://api.github.com/repos/sachiniWettasinghe/identity-data-publisher-authentication/releases{/id}","deployments_url":"https://api.github.com/repos/sachiniWettasinghe/identity-data-publisher-authentication/deployments","created_at":"2018-08-11T18:10:48Z","updated_at":"2018-08-11T18:10:50Z","pushed_at":"2018-09-18T11:25:48Z","git_url":"git://github.com/sachiniWettasinghe/identity-data-publisher-authentication.git","ssh_url":"[email protected]:sachiniWettasinghe/identity-data-publisher-authentication.git","clone_url":"https://github.com/sachiniWettasinghe/identity-data-publisher-authentication.git","svn_url":"https://github.com/sachiniWettasinghe/identity-data-publisher-authentication","homepage":null,"size":353,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"wso2-extensions:master","ref":"master","sha":"85220ad76fab3cbf93c0e030231d80650245f851","user":{"login":"wso2-extensions","id":17171218,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3MTcxMjE4","avatar_url":"https://avatars0.githubusercontent.com/u/17171218?v=4","gravatar_id":"","url":"https://api.github.com/users/wso2-extensions","html_url":"https://github.com/wso2-extensions","followers_url":"https://api.github.com/users/wso2-extensions/followers","following_url":"https://api.github.com/users/wso2-extensions/following{/other_user}","gists_url":"https://api.github.com/users/wso2-extensions/gists{/gist_id}","starred_url":"https://api.github.com/users/wso2-extensions/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wso2-extensions/subscriptions","organizations_url":"https://api.github.com/users/wso2-extensions/orgs","repos_url":"https://api.github.com/users/wso2-extensions/repos","events_url":"https://api.github.com/users/wso2-extensions/events{/privacy}","received_events_url":"https://api.github.com/users/wso2-extensions/received_events","type":"Organization","site_admin":false},"repo":{"id":59820096,"node_id":"MDEwOlJlcG9zaXRvcnk1OTgyMDA5Ng==","name":"identity-data-publisher-authentication","full_name":"wso2-extensions/identity-data-publisher-authentication","private":false,"owner":{"login":"wso2-extensions","id":17171218,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3MTcxMjE4","avatar_url":"https://avatars0.githubusercontent.com/u/17171218?v=4","gravatar_id":"","url":"https://api.github.com/users/wso2-extensions","html_url":"https://github.com/wso2-extensions","followers_url":"https://api.github.com/users/wso2-extensions/followers","following_url":"https://api.github.com/users/wso2-extensions/following{/other_user}","gists_url":"https://api.github.com/users/wso2-extensions/gists{/gist_id}","starred_url":"https://api.github.com/users/wso2-extensions/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wso2-extensions/subscriptions","organizations_url":"https://api.github.com/users/wso2-extensions/orgs","repos_url":"https://api.github.com/users/wso2-extensions/repos","events_url":"https://api.github.com/users/wso2-extensions/events{/privacy}","received_events_url":"https://api.github.com/users/wso2-extensions/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/wso2-extensions/identity-data-publisher-authentication","description":null,"fork":false,"url":"https://api.github.com/repos/wso2-extensions/identity-data-publisher-authentication","forks_url":"https://api.github.com/repos/wso2-extensions/identity-data-publisher-authentication/forks","keys_url":"https://api.github.com/repos/wso2-extensions/identity-data-publisher-authentication/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wso2-extensions/identity-data-publisher-authentication/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wso2-extensions/identity-data-publisher-authentication/teams","hooks_url":"https://api.github.com/repos/wso2-extensions/identity-data-publisher-authentication/hooks","issue_events_url":"https://api.github.com/repos/wso2-extensions/identity-data-publisher-authentication/issues/events{/number}","events_url":"https://api.github.com/repos/wso2-extensions/identity-data-publisher-authentication/events","assignees_url":"https://api.github.com/repos/wso2-extensions/identity-data-publisher-authentication/assignees{/user}","branches_url":"https://api.github.com/repos/wso2-extensions/identity-data-publisher-authentication/branches{/branch}","tags_url":"https://api.github.com/repos/wso2-extensions/identity-data-publisher-authentication/tags","blobs_url":"https://api.github.com/repos/wso2-extensions/identity-data-publisher-authentication/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wso2-extensions/identity-data-publisher-authentication/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wso2-extensions/identity-data-publisher-authentication/git/refs{/sha}","trees_url":"https://api.github.com/repos/wso2-extensions/identity-data-publisher-authentication/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wso2-extensions/identity-data-publisher-authentication/statuses/{sha}","languages_url":"https://api.github.com/repos/wso2-extensions/identity-data-publisher-authentication/languages","stargazers_url":"https://api.github.com/repos/wso2-extensions/identity-data-publisher-authentication/stargazers","contributors_url":"https://api.github.com/repos/wso2-extensions/identity-data-publisher-authentication/contributors","subscribers_url":"https://api.github.com/repos/wso2-extensions/identity-data-publisher-authentication/subscribers","subscription_url":"https://api.github.com/repos/wso2-extensions/identity-data-publisher-authentication/subscription","commits_url":"https://api.github.com/repos/wso2-extensions/identity-data-publisher-authentication/commits{/sha}","git_commits_url":"https://api.github.com/repos/wso2-extensions/identity-data-publisher-authentication/git/commits{/sha}","comments_url":"https://api.github.com/repos/wso2-extensions/identity-data-publisher-authentication/comments{/number}","issue_comment_url":"https://api.github.com/repos/wso2-extensions/identity-data-publisher-authentication/issues/comments{/number}","contents_url":"https://api.github.com/repos/wso2-extensions/identity-data-publisher-authentication/contents/{+path}","compare_url":"https://api.github.com/repos/wso2-extensions/identity-data-publisher-authentication/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wso2-extensions/identity-data-publisher-authentication/merges","archive_url":"https://api.github.com/repos/wso2-extensions/identity-data-publisher-authentication/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wso2-extensions/identity-data-publisher-authentication/downloads","issues_url":"https://api.github.com/repos/wso2-extensions/identity-data-publisher-authentication/issues{/number}","pulls_url":"https://api.github.com/repos/wso2-extensions/identity-data-publisher-authentication/pulls{/number}","milestones_url":"https://api.github.com/repos/wso2-extensions/identity-data-publisher-authentication/milestones{/number}","notifications_url":"https://api.github.com/repos/wso2-extensions/identity-data-publisher-authentication/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wso2-extensions/identity-data-publisher-authentication/labels{/name}","releases_url":"https://api.github.com/repos/wso2-extensions/identity-data-publisher-authentication/releases{/id}","deployments_url":"https://api.github.com/repos/wso2-extensions/identity-data-publisher-authentication/deployments","created_at":"2016-05-27T08:51:02Z","updated_at":"2016-05-30T09:04:15Z","pushed_at":"2018-09-18T11:25:49Z","git_url":"git://github.com/wso2-extensions/identity-data-publisher-authentication.git","ssh_url":"[email protected]:wso2-extensions/identity-data-publisher-authentication.git","clone_url":"https://github.com/wso2-extensions/identity-data-publisher-authentication.git","svn_url":"https://github.com/wso2-extensions/identity-data-publisher-authentication","homepage":null,"size":297,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":20,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":20,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wso2-extensions/identity-data-publisher-authentication/pulls/61"},"html":{"href":"https://github.com/wso2-extensions/identity-data-publisher-authentication/pull/61"},"issue":{"href":"https://api.github.com/repos/wso2-extensions/identity-data-publisher-authentication/issues/61"},"comments":{"href":"https://api.github.com/repos/wso2-extensions/identity-data-publisher-authentication/issues/61/comments"},"review_comments":{"href":"https://api.github.com/repos/wso2-extensions/identity-data-publisher-authentication/pulls/61/comments"},"review_comment":{"href":"https://api.github.com/repos/wso2-extensions/identity-data-publisher-authentication/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wso2-extensions/identity-data-publisher-authentication/pulls/61/commits"},"statuses":{"href":"https://api.github.com/repos/wso2-extensions/identity-data-publisher-authentication/statuses/76eb781481d4a3b00e2a1d30f8094356f2c4295a"}},"author_association":"NONE"}} | {
"id": 59820096,
"name": "wso2-extensions/identity-data-publisher-authentication",
"url": "https://api.github.com/repos/wso2-extensions/identity-data-publisher-authentication"
} | {
"id": 3666100,
"login": "hasinthaindrajee",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3666100?",
"url": "https://api.github.com/users/hasinthaindrajee"
} | {
"id": 17171218,
"login": "wso2-extensions",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/17171218?",
"url": "https://api.github.com/orgs/wso2-extensions"
} | 2018-09-19T13:03:01 | 8288788630 | {"actor":{"display_login":"hasinthaindrajee"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/graphcool/prisma/pulls/comments/178123004","pull_request_review_id":108131026,"id":178123004,"diff_hunk":"@@ -149,181 +105,110 @@ object DatabaseQueryBuilder {\n overrideMaxNodeCount: Option[Int] = None\n ): DBIOAction[ResolverResultNew[RelationNode], NoStream, Effect] = {\n \n- val tableName = relationId\n- val (conditionCommand, orderByCommand, limitCommand, _) = extractQueryArgs(projectId, tableName, args, overrideMaxNodeCount = overrideMaxNodeCount)\n+ val tableName = relationId\n+ val (conditionCommand, orderByCommand, limitCommand) = extractQueryArgs(projectId, tableName, args, None, overrideMaxNodeCount = overrideMaxNodeCount)\n \n val query = sql\"select * from `#$projectId`.`#$tableName`\" concat\n prefixIfNotNone(\"where\", conditionCommand) concat\n prefixIfNotNone(\"order by\", orderByCommand) concat\n prefixIfNotNone(\"limit\", limitCommand)\n \n- query.as[RelationNode].map { nodes =>\n- ResolverResultNew(\n- nodes = args.get.dropExtraLimitItem(nodes),\n- hasNextPage = args.get.hasNext(nodes.size),\n- hasPreviousPage = args.get.hasPrevious(nodes.size)\n- )\n- }\n+ query.as[RelationNode].map(args.get.resultTransform)\n }\n \n def selectAllFromListTable(projectId: String,\n model: Model,\n field: Field,\n args: Option[QueryArguments],\n- overrideMaxNodeCount: Option[Int] = None): SqlStreamingAction[Vector[ScalarListElement], ScalarListElement, Read] = {\n+ overrideMaxNodeCount: Option[Int] = None): DBIOAction[ResolverResultNew[ScalarListValues], NoStream, Effect] = {\n \n- val tableName = s\"${model.name}_${field.name}\"\n- val (conditionCommand, orderByCommand, limitCommand, _) = extractListQueryArgs(projectId, tableName, args, overrideMaxNodeCount = overrideMaxNodeCount)\n+ val tableName = s\"${model.name}_${field.name}\"\n+ val (conditionCommand, orderByCommand, limitCommand) = extractQueryArgs(projectId, tableName, args, None, overrideMaxNodeCount = overrideMaxNodeCount, true)\n \n val query =\n sql\"select * from `#$projectId`.`#$tableName`\" concat\n prefixIfNotNone(\"where\", conditionCommand) concat\n prefixIfNotNone(\"order by\", orderByCommand) concat\n prefixIfNotNone(\"limit\", limitCommand)\n \n- query.as[ScalarListElement](getResultForScalarListField(field))\n- }\n-\n- def countAllFromModel(project: Project, model: Model, where: Option[DataItemFilterCollection]): SQLActionBuilder = {\n- val whereSql = where.flatMap { where =>\n- QueryArgumentsHelpers.generateFilterConditions(project.id, model.name, where)\n+ query.as[ScalarListElement](getResultForScalarListField(field)).map { scalarListElements =>\n+ val res = args.get.resultTransform(scalarListElements)\n+ val convertedValues =\n+ res.nodes\n+ .groupBy(_.nodeId)\n+ .map { case (id, values) => ScalarListValues(IdGCValue(id), ListGCValue(values.sortBy(_.position).map(_.value))) }\n+ .toVector\n+ res.copy(nodes = convertedValues)\n }\n- sql\"select count(*) from `#${project.id}`.`#${model.name}`\" ++ prefixIfNotNone(\"where\", whereSql)\n }\n \n- def extractQueryArgs(\n- projectId: String,\n- modelName: String,\n- args: Option[QueryArguments],\n- defaultOrderShortcut: Option[String] = None,\n- overrideMaxNodeCount: Option[Int] = None): (Option[SQLActionBuilder], Option[SQLActionBuilder], Option[SQLActionBuilder], ResultTransform) = {\n- args match {\n- case None => (None, None, None, x => ResolverResult(x))\n- case Some(givenArgs: QueryArguments) =>\n- (\n- givenArgs.extractWhereConditionCommand(projectId, modelName),\n- givenArgs.extractOrderByCommand(projectId, modelName, defaultOrderShortcut),\n- overrideMaxNodeCount match {\n- case None => givenArgs.extractLimitCommand(projectId, modelName)\n- case Some(maxCount: Int) => givenArgs.extractLimitCommand(projectId, modelName, maxCount)\n- },\n- givenArgs.extractResultTransform(projectId, modelName)\n- )\n- }\n- }\n-\n- def extractListQueryArgs(\n- projectId: String,\n- modelName: String,\n- args: Option[QueryArguments],\n- defaultOrderShortcut: Option[String] = None,\n- overrideMaxNodeCount: Option[Int] = None): (Option[SQLActionBuilder], Option[SQLActionBuilder], Option[SQLActionBuilder], ResultListTransform) = {\n- args match {\n- case None =>\n- (None,\n- None,\n- None,\n- x =>\n- ResolverResult(x.map { listValue =>\n- DataItem(id = listValue.nodeId, userData = Map(\"value\" -> Some(listValue.value)))\n- }))\n- case Some(givenArgs: QueryArguments) =>\n- (\n- givenArgs.extractWhereConditionCommand(projectId, modelName),\n- givenArgs.extractOrderByCommandForLists(projectId, modelName, defaultOrderShortcut),\n- overrideMaxNodeCount match {\n- case None => givenArgs.extractLimitCommand(projectId, modelName)\n- case Some(maxCount: Int) => givenArgs.extractLimitCommand(projectId, modelName, maxCount)\n- },\n- givenArgs.extractListResultTransform(projectId, modelName)\n- )\n- }\n+ def countAllFromModel(project: Project, model: Model, whereFilter: Option[DataItemFilterCollection]): DBIOAction[Int, NoStream, Effect] = {\n+ val whereSql = whereFilter.flatMap(where => QueryArgumentsHelpers.generateFilterConditions(project.id, model.name, where))\n+ val query = sql\"select count(*) from `#${project.id}`.`#${model.name}`\" ++ prefixIfNotNone(\"where\", whereSql)\n+ query.as[Int].map(_.head)\n }\n \n- def itemCountForTable(projectId: String, modelName: String) = {\n- sql\"SELECT COUNT(*) AS Count FROM `#$projectId`.`#$modelName`\"\n+ def batchSelectFromModelByUnique(projectId: String,\n+ model: Model,\n+ fieldName: String,\n+ values: Vector[GCValue]): SqlStreamingAction[Vector[PrismaNode], PrismaNode, Effect] = {\n+ val query = sql\"select * from `#$projectId`.`#${model.name}` where `#$fieldName` in (\" concat combineByComma(values.map(gcValueToSQLBuilder)) concat sql\")\"\n+ query.as[PrismaNode](getResultForModel(model))\n }\n \n- def existsNullByModelAndScalarField(projectId: String, modelName: String, fieldName: String) = {\n- sql\"\"\"SELECT EXISTS(Select `id` FROM `#$projectId`.`#$modelName`\n- WHERE `#$projectId`.`#$modelName`.#$fieldName IS NULL)\"\"\"\n- }\n+ def batchSelectFromModelByUniqueSimple(projectId: String, model: Model, fieldName: String, values: Vector[GCValue]): SimpleDBIO[Vector[PrismaNode]] =\n+ SimpleDBIO[Vector[PrismaNode]] { x =>\n+ val placeHolders = values.map(_ => \"?\").mkString(\",\")\n+ val query = s\"select * from `$projectId`.`${model.name}` where `$fieldName` in ($placeHolders)\"\n+ val batchSelect: PreparedStatement = x.connection.prepareStatement(query)\n+ values.zipWithIndex.foreach { gcValueWithIndex =>\n+ batchSelect.setGcValue(gcValueWithIndex._2 + 1, gcValueWithIndex._1)\n+ }\n+ val rs: ResultSet = batchSelect.executeQuery()\n \n- def existsNullByModelAndRelationField(projectId: String, modelName: String, field: Field) = {\n- val relationId = field.relation.get.id\n- val relationSide = field.relationSide.get.toString\n- sql\"\"\"select EXISTS (\n- select `id`from `#$projectId`.`#$modelName`\n- where `id` Not IN\n- (Select `#$projectId`.`#$relationId`.#$relationSide from `#$projectId`.`#$relationId`)\n- )\"\"\"\n- }\n+ var result: Vector[PrismaNode] = Vector.empty\n+ while (rs.next) {","path":"server/connectors/api-connector-mysql/src/main/scala/com/prisma/api/connector/mysql/database/DatabaseQueryBuilder.scala","position":336,"original_position":336,"commit_id":"b46277164a7f5233bcd613f512463c2c83e5b6cb","original_commit_id":"b46277164a7f5233bcd613f512463c2c83e5b6cb","user":{"login":"codacy-bot","id":19940114,"avatar_url":"https://avatars1.githubusercontent.com/u/19940114?v=4","gravatar_id":"","url":"https://api.github.com/users/codacy-bot","html_url":"https://github.com/codacy-bot","followers_url":"https://api.github.com/users/codacy-bot/followers","following_url":"https://api.github.com/users/codacy-bot/following{/other_user}","gists_url":"https://api.github.com/users/codacy-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/codacy-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codacy-bot/subscriptions","organizations_url":"https://api.github.com/users/codacy-bot/orgs","repos_url":"https://api.github.com/users/codacy-bot/repos","events_url":"https://api.github.com/users/codacy-bot/events{/privacy}","received_events_url":"https://api.github.com/users/codacy-bot/received_events","type":"User","site_admin":false},"body":" Issue found: [Avoid using while loops](https://app.codacy.com/app/graphcool/prisma/pullRequest?prid=1467914)","created_at":"2018-03-29T17:12:22Z","updated_at":"2018-03-29T17:12:22Z","html_url":"https://github.com/graphcool/prisma/pull/2145#discussion_r178123004","pull_request_url":"https://api.github.com/repos/graphcool/prisma/pulls/2145","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/graphcool/prisma/pulls/comments/178123004"},"html":{"href":"https://github.com/graphcool/prisma/pull/2145#discussion_r178123004"},"pull_request":{"href":"https://api.github.com/repos/graphcool/prisma/pulls/2145"}}},"pull_request":{"url":"https://api.github.com/repos/graphcool/prisma/pulls/2145","id":177128259,"html_url":"https://github.com/graphcool/prisma/pull/2145","diff_url":"https://github.com/graphcool/prisma/pull/2145.diff","patch_url":"https://github.com/graphcool/prisma/pull/2145.patch","issue_url":"https://api.github.com/repos/graphcool/prisma/issues/2145","number":2145,"state":"open","locked":false,"title":"[WIP] Use gc values in connectors","user":{"login":"do4gr","id":16278407,"avatar_url":"https://avatars2.githubusercontent.com/u/16278407?v=4","gravatar_id":"","url":"https://api.github.com/users/do4gr","html_url":"https://github.com/do4gr","followers_url":"https://api.github.com/users/do4gr/followers","following_url":"https://api.github.com/users/do4gr/following{/other_user}","gists_url":"https://api.github.com/users/do4gr/gists{/gist_id}","starred_url":"https://api.github.com/users/do4gr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/do4gr/subscriptions","organizations_url":"https://api.github.com/users/do4gr/orgs","repos_url":"https://api.github.com/users/do4gr/repos","events_url":"https://api.github.com/users/do4gr/events{/privacy}","received_events_url":"https://api.github.com/users/do4gr/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-03-23T16:54:25Z","updated_at":"2018-03-29T17:12:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"472c65b033c24627613bec09c29cec80e2b135cc","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/graphcool/prisma/pulls/2145/commits","review_comments_url":"https://api.github.com/repos/graphcool/prisma/pulls/2145/comments","review_comment_url":"https://api.github.com/repos/graphcool/prisma/pulls/comments{/number}","comments_url":"https://api.github.com/repos/graphcool/prisma/issues/2145/comments","statuses_url":"https://api.github.com/repos/graphcool/prisma/statuses/b46277164a7f5233bcd613f512463c2c83e5b6cb","head":{"label":"graphcool:UseGCValuesInConnectors","ref":"UseGCValuesInConnectors","sha":"b46277164a7f5233bcd613f512463c2c83e5b6cb","user":{"login":"graphcool","id":17219288,"avatar_url":"https://avatars0.githubusercontent.com/u/17219288?v=4","gravatar_id":"","url":"https://api.github.com/users/graphcool","html_url":"https://github.com/graphcool","followers_url":"https://api.github.com/users/graphcool/followers","following_url":"https://api.github.com/users/graphcool/following{/other_user}","gists_url":"https://api.github.com/users/graphcool/gists{/gist_id}","starred_url":"https://api.github.com/users/graphcool/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/graphcool/subscriptions","organizations_url":"https://api.github.com/users/graphcool/orgs","repos_url":"https://api.github.com/users/graphcool/repos","events_url":"https://api.github.com/users/graphcool/events{/privacy}","received_events_url":"https://api.github.com/users/graphcool/received_events","type":"Organization","site_admin":false},"repo":{"id":69164196,"name":"prisma","full_name":"graphcool/prisma","owner":{"login":"graphcool","id":17219288,"avatar_url":"https://avatars0.githubusercontent.com/u/17219288?v=4","gravatar_id":"","url":"https://api.github.com/users/graphcool","html_url":"https://github.com/graphcool","followers_url":"https://api.github.com/users/graphcool/followers","following_url":"https://api.github.com/users/graphcool/following{/other_user}","gists_url":"https://api.github.com/users/graphcool/gists{/gist_id}","starred_url":"https://api.github.com/users/graphcool/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/graphcool/subscriptions","organizations_url":"https://api.github.com/users/graphcool/orgs","repos_url":"https://api.github.com/users/graphcool/repos","events_url":"https://api.github.com/users/graphcool/events{/privacy}","received_events_url":"https://api.github.com/users/graphcool/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/graphcool/prisma","description":"⚡️ Prisma turns your database into a realtime GraphQL API","fork":false,"url":"https://api.github.com/repos/graphcool/prisma","forks_url":"https://api.github.com/repos/graphcool/prisma/forks","keys_url":"https://api.github.com/repos/graphcool/prisma/keys{/key_id}","collaborators_url":"https://api.github.com/repos/graphcool/prisma/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/graphcool/prisma/teams","hooks_url":"https://api.github.com/repos/graphcool/prisma/hooks","issue_events_url":"https://api.github.com/repos/graphcool/prisma/issues/events{/number}","events_url":"https://api.github.com/repos/graphcool/prisma/events","assignees_url":"https://api.github.com/repos/graphcool/prisma/assignees{/user}","branches_url":"https://api.github.com/repos/graphcool/prisma/branches{/branch}","tags_url":"https://api.github.com/repos/graphcool/prisma/tags","blobs_url":"https://api.github.com/repos/graphcool/prisma/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/graphcool/prisma/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/graphcool/prisma/git/refs{/sha}","trees_url":"https://api.github.com/repos/graphcool/prisma/git/trees{/sha}","statuses_url":"https://api.github.com/repos/graphcool/prisma/statuses/{sha}","languages_url":"https://api.github.com/repos/graphcool/prisma/languages","stargazers_url":"https://api.github.com/repos/graphcool/prisma/stargazers","contributors_url":"https://api.github.com/repos/graphcool/prisma/contributors","subscribers_url":"https://api.github.com/repos/graphcool/prisma/subscribers","subscription_url":"https://api.github.com/repos/graphcool/prisma/subscription","commits_url":"https://api.github.com/repos/graphcool/prisma/commits{/sha}","git_commits_url":"https://api.github.com/repos/graphcool/prisma/git/commits{/sha}","comments_url":"https://api.github.com/repos/graphcool/prisma/comments{/number}","issue_comment_url":"https://api.github.com/repos/graphcool/prisma/issues/comments{/number}","contents_url":"https://api.github.com/repos/graphcool/prisma/contents/{+path}","compare_url":"https://api.github.com/repos/graphcool/prisma/compare/{base}...{head}","merges_url":"https://api.github.com/repos/graphcool/prisma/merges","archive_url":"https://api.github.com/repos/graphcool/prisma/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/graphcool/prisma/downloads","issues_url":"https://api.github.com/repos/graphcool/prisma/issues{/number}","pulls_url":"https://api.github.com/repos/graphcool/prisma/pulls{/number}","milestones_url":"https://api.github.com/repos/graphcool/prisma/milestones{/number}","notifications_url":"https://api.github.com/repos/graphcool/prisma/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/graphcool/prisma/labels{/name}","releases_url":"https://api.github.com/repos/graphcool/prisma/releases{/id}","deployments_url":"https://api.github.com/repos/graphcool/prisma/deployments","created_at":"2016-09-25T12:54:40Z","updated_at":"2018-03-29T17:02:01Z","pushed_at":"2018-03-29T17:09:27Z","git_url":"git://github.com/graphcool/prisma.git","ssh_url":"[email protected]:graphcool/prisma.git","clone_url":"https://github.com/graphcool/prisma.git","svn_url":"https://github.com/graphcool/prisma","homepage":"https://www.prismagraphql.com","size":14328,"stargazers_count":6770,"watchers_count":6770,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":381,"mirror_url":null,"archived":false,"open_issues_count":363,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":381,"open_issues":363,"watchers":6770,"default_branch":"master"}},"base":{"label":"graphcool:master","ref":"master","sha":"931801fcba0be5c31adf01a008e682e0437a50fe","user":{"login":"graphcool","id":17219288,"avatar_url":"https://avatars0.githubusercontent.com/u/17219288?v=4","gravatar_id":"","url":"https://api.github.com/users/graphcool","html_url":"https://github.com/graphcool","followers_url":"https://api.github.com/users/graphcool/followers","following_url":"https://api.github.com/users/graphcool/following{/other_user}","gists_url":"https://api.github.com/users/graphcool/gists{/gist_id}","starred_url":"https://api.github.com/users/graphcool/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/graphcool/subscriptions","organizations_url":"https://api.github.com/users/graphcool/orgs","repos_url":"https://api.github.com/users/graphcool/repos","events_url":"https://api.github.com/users/graphcool/events{/privacy}","received_events_url":"https://api.github.com/users/graphcool/received_events","type":"Organization","site_admin":false},"repo":{"id":69164196,"name":"prisma","full_name":"graphcool/prisma","owner":{"login":"graphcool","id":17219288,"avatar_url":"https://avatars0.githubusercontent.com/u/17219288?v=4","gravatar_id":"","url":"https://api.github.com/users/graphcool","html_url":"https://github.com/graphcool","followers_url":"https://api.github.com/users/graphcool/followers","following_url":"https://api.github.com/users/graphcool/following{/other_user}","gists_url":"https://api.github.com/users/graphcool/gists{/gist_id}","starred_url":"https://api.github.com/users/graphcool/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/graphcool/subscriptions","organizations_url":"https://api.github.com/users/graphcool/orgs","repos_url":"https://api.github.com/users/graphcool/repos","events_url":"https://api.github.com/users/graphcool/events{/privacy}","received_events_url":"https://api.github.com/users/graphcool/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/graphcool/prisma","description":"⚡️ Prisma turns your database into a realtime GraphQL API","fork":false,"url":"https://api.github.com/repos/graphcool/prisma","forks_url":"https://api.github.com/repos/graphcool/prisma/forks","keys_url":"https://api.github.com/repos/graphcool/prisma/keys{/key_id}","collaborators_url":"https://api.github.com/repos/graphcool/prisma/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/graphcool/prisma/teams","hooks_url":"https://api.github.com/repos/graphcool/prisma/hooks","issue_events_url":"https://api.github.com/repos/graphcool/prisma/issues/events{/number}","events_url":"https://api.github.com/repos/graphcool/prisma/events","assignees_url":"https://api.github.com/repos/graphcool/prisma/assignees{/user}","branches_url":"https://api.github.com/repos/graphcool/prisma/branches{/branch}","tags_url":"https://api.github.com/repos/graphcool/prisma/tags","blobs_url":"https://api.github.com/repos/graphcool/prisma/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/graphcool/prisma/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/graphcool/prisma/git/refs{/sha}","trees_url":"https://api.github.com/repos/graphcool/prisma/git/trees{/sha}","statuses_url":"https://api.github.com/repos/graphcool/prisma/statuses/{sha}","languages_url":"https://api.github.com/repos/graphcool/prisma/languages","stargazers_url":"https://api.github.com/repos/graphcool/prisma/stargazers","contributors_url":"https://api.github.com/repos/graphcool/prisma/contributors","subscribers_url":"https://api.github.com/repos/graphcool/prisma/subscribers","subscription_url":"https://api.github.com/repos/graphcool/prisma/subscription","commits_url":"https://api.github.com/repos/graphcool/prisma/commits{/sha}","git_commits_url":"https://api.github.com/repos/graphcool/prisma/git/commits{/sha}","comments_url":"https://api.github.com/repos/graphcool/prisma/comments{/number}","issue_comment_url":"https://api.github.com/repos/graphcool/prisma/issues/comments{/number}","contents_url":"https://api.github.com/repos/graphcool/prisma/contents/{+path}","compare_url":"https://api.github.com/repos/graphcool/prisma/compare/{base}...{head}","merges_url":"https://api.github.com/repos/graphcool/prisma/merges","archive_url":"https://api.github.com/repos/graphcool/prisma/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/graphcool/prisma/downloads","issues_url":"https://api.github.com/repos/graphcool/prisma/issues{/number}","pulls_url":"https://api.github.com/repos/graphcool/prisma/pulls{/number}","milestones_url":"https://api.github.com/repos/graphcool/prisma/milestones{/number}","notifications_url":"https://api.github.com/repos/graphcool/prisma/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/graphcool/prisma/labels{/name}","releases_url":"https://api.github.com/repos/graphcool/prisma/releases{/id}","deployments_url":"https://api.github.com/repos/graphcool/prisma/deployments","created_at":"2016-09-25T12:54:40Z","updated_at":"2018-03-29T17:02:01Z","pushed_at":"2018-03-29T17:09:27Z","git_url":"git://github.com/graphcool/prisma.git","ssh_url":"[email protected]:graphcool/prisma.git","clone_url":"https://github.com/graphcool/prisma.git","svn_url":"https://github.com/graphcool/prisma","homepage":"https://www.prismagraphql.com","size":14328,"stargazers_count":6770,"watchers_count":6770,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":381,"mirror_url":null,"archived":false,"open_issues_count":363,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":381,"open_issues":363,"watchers":6770,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/graphcool/prisma/pulls/2145"},"html":{"href":"https://github.com/graphcool/prisma/pull/2145"},"issue":{"href":"https://api.github.com/repos/graphcool/prisma/issues/2145"},"comments":{"href":"https://api.github.com/repos/graphcool/prisma/issues/2145/comments"},"review_comments":{"href":"https://api.github.com/repos/graphcool/prisma/pulls/2145/comments"},"review_comment":{"href":"https://api.github.com/repos/graphcool/prisma/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/graphcool/prisma/pulls/2145/commits"},"statuses":{"href":"https://api.github.com/repos/graphcool/prisma/statuses/b46277164a7f5233bcd613f512463c2c83e5b6cb"}},"author_association":"MEMBER"}} | {
"id": 69164196,
"name": "graphcool/prisma",
"url": "https://api.github.com/repos/graphcool/prisma"
} | {
"id": 19940114,
"login": "codacy-bot",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/19940114?",
"url": "https://api.github.com/users/codacy-bot"
} | {
"id": 17219288,
"login": "graphcool",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/17219288?",
"url": "https://api.github.com/orgs/graphcool"
} | 2018-03-29T17:12:22 | 7455160707 | {"actor":{"display_login":"codacy-bot"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/shipshapecode/shepherd/pulls/comments/224288672","pull_request_review_id":163618531,"id":224288672,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNDI4ODY3Mg==","diff_hunk":"@@ -31,7 +31,7 @@\n as they enter and exit the view.\n `\n ],\n- attachTo: '.hero-welcome bottom',\n+ attachTo: '.hero-welcome bottom-start',","path":"docs/welcome/js/welcome.js","position":null,"original_position":5,"commit_id":"1cc8ae4d3466a33930fc240eff47c7257fbdf884","original_commit_id":"3f0022084c847de2f4455daf66fe856102b2213e","user":{"login":"BrianSipple","id":5483853,"node_id":"MDQ6VXNlcjU0ODM4NTM=","avatar_url":"https://avatars0.githubusercontent.com/u/5483853?v=4","gravatar_id":"","url":"https://api.github.com/users/BrianSipple","html_url":"https://github.com/BrianSipple","followers_url":"https://api.github.com/users/BrianSipple/followers","following_url":"https://api.github.com/users/BrianSipple/following{/other_user}","gists_url":"https://api.github.com/users/BrianSipple/gists{/gist_id}","starred_url":"https://api.github.com/users/BrianSipple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BrianSipple/subscriptions","organizations_url":"https://api.github.com/users/BrianSipple/orgs","repos_url":"https://api.github.com/users/BrianSipple/repos","events_url":"https://api.github.com/users/BrianSipple/events{/privacy}","received_events_url":"https://api.github.com/users/BrianSipple/received_events","type":"User","site_admin":false},"body":"@chuckcarpenter @rwwagner90 This could be what we want, though. I was thinking the placement should move the arrow, but after revisiting both the Tippy and Popper demos, it appears that the main idea is to move the body of the tooltip.","created_at":"2018-10-11T01:16:26Z","updated_at":"2018-10-11T01:16:27Z","html_url":"https://github.com/shipshapecode/shepherd/pull/268#discussion_r224288672","pull_request_url":"https://api.github.com/repos/shipshapecode/shepherd/pulls/268","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/shipshapecode/shepherd/pulls/comments/224288672"},"html":{"href":"https://github.com/shipshapecode/shepherd/pull/268#discussion_r224288672"},"pull_request":{"href":"https://api.github.com/repos/shipshapecode/shepherd/pulls/268"}},"in_reply_to_id":224187834},"pull_request":{"url":"https://api.github.com/repos/shipshapecode/shepherd/pulls/268","id":221653454,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIxNjUzNDU0","html_url":"https://github.com/shipshapecode/shepherd/pull/268","diff_url":"https://github.com/shipshapecode/shepherd/pull/268.diff","patch_url":"https://github.com/shipshapecode/shepherd/pull/268.patch","issue_url":"https://api.github.com/repos/shipshapecode/shepherd/issues/268","number":268,"state":"open","locked":false,"title":"remove some popper arrow styles and target tippy-arrow","user":{"login":"chuckcarpenter","id":706378,"node_id":"MDQ6VXNlcjcwNjM3OA==","avatar_url":"https://avatars1.githubusercontent.com/u/706378?v=4","gravatar_id":"","url":"https://api.github.com/users/chuckcarpenter","html_url":"https://github.com/chuckcarpenter","followers_url":"https://api.github.com/users/chuckcarpenter/followers","following_url":"https://api.github.com/users/chuckcarpenter/following{/other_user}","gists_url":"https://api.github.com/users/chuckcarpenter/gists{/gist_id}","starred_url":"https://api.github.com/users/chuckcarpenter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chuckcarpenter/subscriptions","organizations_url":"https://api.github.com/users/chuckcarpenter/orgs","repos_url":"https://api.github.com/users/chuckcarpenter/repos","events_url":"https://api.github.com/users/chuckcarpenter/events{/privacy}","received_events_url":"https://api.github.com/users/chuckcarpenter/received_events","type":"User","site_admin":false},"body":"Fixes #266 ","created_at":"2018-10-10T04:11:22Z","updated_at":"2018-10-11T01:16:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"55717cc1ef99e66d3b1c6a74a6b3c7132c8f311d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/shipshapecode/shepherd/pulls/268/commits","review_comments_url":"https://api.github.com/repos/shipshapecode/shepherd/pulls/268/comments","review_comment_url":"https://api.github.com/repos/shipshapecode/shepherd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/shipshapecode/shepherd/issues/268/comments","statuses_url":"https://api.github.com/repos/shipshapecode/shepherd/statuses/1cc8ae4d3466a33930fc240eff47c7257fbdf884","head":{"label":"shipshapecode:bug/267","ref":"bug/267","sha":"1cc8ae4d3466a33930fc240eff47c7257fbdf884","user":{"login":"shipshapecode","id":17297725,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3Mjk3NzI1","avatar_url":"https://avatars2.githubusercontent.com/u/17297725?v=4","gravatar_id":"","url":"https://api.github.com/users/shipshapecode","html_url":"https://github.com/shipshapecode","followers_url":"https://api.github.com/users/shipshapecode/followers","following_url":"https://api.github.com/users/shipshapecode/following{/other_user}","gists_url":"https://api.github.com/users/shipshapecode/gists{/gist_id}","starred_url":"https://api.github.com/users/shipshapecode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shipshapecode/subscriptions","organizations_url":"https://api.github.com/users/shipshapecode/orgs","repos_url":"https://api.github.com/users/shipshapecode/repos","events_url":"https://api.github.com/users/shipshapecode/events{/privacy}","received_events_url":"https://api.github.com/users/shipshapecode/received_events","type":"Organization","site_admin":false},"repo":{"id":15246993,"node_id":"MDEwOlJlcG9zaXRvcnkxNTI0Njk5Mw==","name":"shepherd","full_name":"shipshapecode/shepherd","private":false,"owner":{"login":"shipshapecode","id":17297725,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3Mjk3NzI1","avatar_url":"https://avatars2.githubusercontent.com/u/17297725?v=4","gravatar_id":"","url":"https://api.github.com/users/shipshapecode","html_url":"https://github.com/shipshapecode","followers_url":"https://api.github.com/users/shipshapecode/followers","following_url":"https://api.github.com/users/shipshapecode/following{/other_user}","gists_url":"https://api.github.com/users/shipshapecode/gists{/gist_id}","starred_url":"https://api.github.com/users/shipshapecode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shipshapecode/subscriptions","organizations_url":"https://api.github.com/users/shipshapecode/orgs","repos_url":"https://api.github.com/users/shipshapecode/repos","events_url":"https://api.github.com/users/shipshapecode/events{/privacy}","received_events_url":"https://api.github.com/users/shipshapecode/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/shipshapecode/shepherd","description":"Guide your users through a tour of your app","fork":false,"url":"https://api.github.com/repos/shipshapecode/shepherd","forks_url":"https://api.github.com/repos/shipshapecode/shepherd/forks","keys_url":"https://api.github.com/repos/shipshapecode/shepherd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shipshapecode/shepherd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shipshapecode/shepherd/teams","hooks_url":"https://api.github.com/repos/shipshapecode/shepherd/hooks","issue_events_url":"https://api.github.com/repos/shipshapecode/shepherd/issues/events{/number}","events_url":"https://api.github.com/repos/shipshapecode/shepherd/events","assignees_url":"https://api.github.com/repos/shipshapecode/shepherd/assignees{/user}","branches_url":"https://api.github.com/repos/shipshapecode/shepherd/branches{/branch}","tags_url":"https://api.github.com/repos/shipshapecode/shepherd/tags","blobs_url":"https://api.github.com/repos/shipshapecode/shepherd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shipshapecode/shepherd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shipshapecode/shepherd/git/refs{/sha}","trees_url":"https://api.github.com/repos/shipshapecode/shepherd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shipshapecode/shepherd/statuses/{sha}","languages_url":"https://api.github.com/repos/shipshapecode/shepherd/languages","stargazers_url":"https://api.github.com/repos/shipshapecode/shepherd/stargazers","contributors_url":"https://api.github.com/repos/shipshapecode/shepherd/contributors","subscribers_url":"https://api.github.com/repos/shipshapecode/shepherd/subscribers","subscription_url":"https://api.github.com/repos/shipshapecode/shepherd/subscription","commits_url":"https://api.github.com/repos/shipshapecode/shepherd/commits{/sha}","git_commits_url":"https://api.github.com/repos/shipshapecode/shepherd/git/commits{/sha}","comments_url":"https://api.github.com/repos/shipshapecode/shepherd/comments{/number}","issue_comment_url":"https://api.github.com/repos/shipshapecode/shepherd/issues/comments{/number}","contents_url":"https://api.github.com/repos/shipshapecode/shepherd/contents/{+path}","compare_url":"https://api.github.com/repos/shipshapecode/shepherd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shipshapecode/shepherd/merges","archive_url":"https://api.github.com/repos/shipshapecode/shepherd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shipshapecode/shepherd/downloads","issues_url":"https://api.github.com/repos/shipshapecode/shepherd/issues{/number}","pulls_url":"https://api.github.com/repos/shipshapecode/shepherd/pulls{/number}","milestones_url":"https://api.github.com/repos/shipshapecode/shepherd/milestones{/number}","notifications_url":"https://api.github.com/repos/shipshapecode/shepherd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shipshapecode/shepherd/labels{/name}","releases_url":"https://api.github.com/repos/shipshapecode/shepherd/releases{/id}","deployments_url":"https://api.github.com/repos/shipshapecode/shepherd/deployments","created_at":"2013-12-17T06:30:27Z","updated_at":"2018-10-10T02:48:03Z","pushed_at":"2018-10-11T00:16:05Z","git_url":"git://github.com/shipshapecode/shepherd.git","ssh_url":"[email protected]:shipshapecode/shepherd.git","clone_url":"https://github.com/shipshapecode/shepherd.git","svn_url":"https://github.com/shipshapecode/shepherd","homepage":"https://shipshapecode.github.io/shepherd/docs/welcome","size":3671,"stargazers_count":5892,"watchers_count":5892,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":376,"mirror_url":null,"archived":false,"open_issues_count":13,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":376,"open_issues":13,"watchers":5892,"default_branch":"master"}},"base":{"label":"shipshapecode:master","ref":"master","sha":"a821cd57573e0fcf8d353451b52a12cc661b50d4","user":{"login":"shipshapecode","id":17297725,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3Mjk3NzI1","avatar_url":"https://avatars2.githubusercontent.com/u/17297725?v=4","gravatar_id":"","url":"https://api.github.com/users/shipshapecode","html_url":"https://github.com/shipshapecode","followers_url":"https://api.github.com/users/shipshapecode/followers","following_url":"https://api.github.com/users/shipshapecode/following{/other_user}","gists_url":"https://api.github.com/users/shipshapecode/gists{/gist_id}","starred_url":"https://api.github.com/users/shipshapecode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shipshapecode/subscriptions","organizations_url":"https://api.github.com/users/shipshapecode/orgs","repos_url":"https://api.github.com/users/shipshapecode/repos","events_url":"https://api.github.com/users/shipshapecode/events{/privacy}","received_events_url":"https://api.github.com/users/shipshapecode/received_events","type":"Organization","site_admin":false},"repo":{"id":15246993,"node_id":"MDEwOlJlcG9zaXRvcnkxNTI0Njk5Mw==","name":"shepherd","full_name":"shipshapecode/shepherd","private":false,"owner":{"login":"shipshapecode","id":17297725,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3Mjk3NzI1","avatar_url":"https://avatars2.githubusercontent.com/u/17297725?v=4","gravatar_id":"","url":"https://api.github.com/users/shipshapecode","html_url":"https://github.com/shipshapecode","followers_url":"https://api.github.com/users/shipshapecode/followers","following_url":"https://api.github.com/users/shipshapecode/following{/other_user}","gists_url":"https://api.github.com/users/shipshapecode/gists{/gist_id}","starred_url":"https://api.github.com/users/shipshapecode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shipshapecode/subscriptions","organizations_url":"https://api.github.com/users/shipshapecode/orgs","repos_url":"https://api.github.com/users/shipshapecode/repos","events_url":"https://api.github.com/users/shipshapecode/events{/privacy}","received_events_url":"https://api.github.com/users/shipshapecode/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/shipshapecode/shepherd","description":"Guide your users through a tour of your app","fork":false,"url":"https://api.github.com/repos/shipshapecode/shepherd","forks_url":"https://api.github.com/repos/shipshapecode/shepherd/forks","keys_url":"https://api.github.com/repos/shipshapecode/shepherd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shipshapecode/shepherd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shipshapecode/shepherd/teams","hooks_url":"https://api.github.com/repos/shipshapecode/shepherd/hooks","issue_events_url":"https://api.github.com/repos/shipshapecode/shepherd/issues/events{/number}","events_url":"https://api.github.com/repos/shipshapecode/shepherd/events","assignees_url":"https://api.github.com/repos/shipshapecode/shepherd/assignees{/user}","branches_url":"https://api.github.com/repos/shipshapecode/shepherd/branches{/branch}","tags_url":"https://api.github.com/repos/shipshapecode/shepherd/tags","blobs_url":"https://api.github.com/repos/shipshapecode/shepherd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shipshapecode/shepherd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shipshapecode/shepherd/git/refs{/sha}","trees_url":"https://api.github.com/repos/shipshapecode/shepherd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shipshapecode/shepherd/statuses/{sha}","languages_url":"https://api.github.com/repos/shipshapecode/shepherd/languages","stargazers_url":"https://api.github.com/repos/shipshapecode/shepherd/stargazers","contributors_url":"https://api.github.com/repos/shipshapecode/shepherd/contributors","subscribers_url":"https://api.github.com/repos/shipshapecode/shepherd/subscribers","subscription_url":"https://api.github.com/repos/shipshapecode/shepherd/subscription","commits_url":"https://api.github.com/repos/shipshapecode/shepherd/commits{/sha}","git_commits_url":"https://api.github.com/repos/shipshapecode/shepherd/git/commits{/sha}","comments_url":"https://api.github.com/repos/shipshapecode/shepherd/comments{/number}","issue_comment_url":"https://api.github.com/repos/shipshapecode/shepherd/issues/comments{/number}","contents_url":"https://api.github.com/repos/shipshapecode/shepherd/contents/{+path}","compare_url":"https://api.github.com/repos/shipshapecode/shepherd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shipshapecode/shepherd/merges","archive_url":"https://api.github.com/repos/shipshapecode/shepherd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shipshapecode/shepherd/downloads","issues_url":"https://api.github.com/repos/shipshapecode/shepherd/issues{/number}","pulls_url":"https://api.github.com/repos/shipshapecode/shepherd/pulls{/number}","milestones_url":"https://api.github.com/repos/shipshapecode/shepherd/milestones{/number}","notifications_url":"https://api.github.com/repos/shipshapecode/shepherd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shipshapecode/shepherd/labels{/name}","releases_url":"https://api.github.com/repos/shipshapecode/shepherd/releases{/id}","deployments_url":"https://api.github.com/repos/shipshapecode/shepherd/deployments","created_at":"2013-12-17T06:30:27Z","updated_at":"2018-10-10T02:48:03Z","pushed_at":"2018-10-11T00:16:05Z","git_url":"git://github.com/shipshapecode/shepherd.git","ssh_url":"[email protected]:shipshapecode/shepherd.git","clone_url":"https://github.com/shipshapecode/shepherd.git","svn_url":"https://github.com/shipshapecode/shepherd","homepage":"https://shipshapecode.github.io/shepherd/docs/welcome","size":3671,"stargazers_count":5892,"watchers_count":5892,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":376,"mirror_url":null,"archived":false,"open_issues_count":13,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":376,"open_issues":13,"watchers":5892,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/shipshapecode/shepherd/pulls/268"},"html":{"href":"https://github.com/shipshapecode/shepherd/pull/268"},"issue":{"href":"https://api.github.com/repos/shipshapecode/shepherd/issues/268"},"comments":{"href":"https://api.github.com/repos/shipshapecode/shepherd/issues/268/comments"},"review_comments":{"href":"https://api.github.com/repos/shipshapecode/shepherd/pulls/268/comments"},"review_comment":{"href":"https://api.github.com/repos/shipshapecode/shepherd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/shipshapecode/shepherd/pulls/268/commits"},"statuses":{"href":"https://api.github.com/repos/shipshapecode/shepherd/statuses/1cc8ae4d3466a33930fc240eff47c7257fbdf884"}},"author_association":"CONTRIBUTOR"}} | {
"id": 15246993,
"name": "shipshapecode/shepherd",
"url": "https://api.github.com/repos/shipshapecode/shepherd"
} | {
"id": 5483853,
"login": "BrianSipple",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5483853?",
"url": "https://api.github.com/users/BrianSipple"
} | {
"id": 17297725,
"login": "shipshapecode",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/17297725?",
"url": "https://api.github.com/orgs/shipshapecode"
} | 2018-10-11T01:16:26 | 8401478818 | {"actor":{"display_login":"BrianSipple"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/vapor/vapor/pulls/comments/167154495","pull_request_review_id":95332295,"id":167154495,"diff_hunk":"@@ -17,6 +17,22 @@ extension Router {\n self.register(route: route)\n return route\n }\n+ \n+ /// Registers a route handler at the supplied path.\n+ @discardableResult\n+ fileprivate func on<C, T>(\n+ _ method: HTTPMethod,\n+ to path: [PathComponent],","path":"Sources/Vapor/Routing/Router+Method.swift","position":9,"original_position":9,"commit_id":"c132ba9bbb2b7666002efa30b5f989290ac67e26","original_commit_id":"c132ba9bbb2b7666002efa30b5f989290ac67e26","user":{"login":"Joannis","id":1951674,"avatar_url":"https://avatars2.githubusercontent.com/u/1951674?v=4","gravatar_id":"","url":"https://api.github.com/users/Joannis","html_url":"https://github.com/Joannis","followers_url":"https://api.github.com/users/Joannis/followers","following_url":"https://api.github.com/users/Joannis/following{/other_user}","gists_url":"https://api.github.com/users/Joannis/gists{/gist_id}","starred_url":"https://api.github.com/users/Joannis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Joannis/subscriptions","organizations_url":"https://api.github.com/users/Joannis/orgs","repos_url":"https://api.github.com/users/Joannis/repos","events_url":"https://api.github.com/users/Joannis/events{/privacy}","received_events_url":"https://api.github.com/users/Joannis/received_events","type":"User","site_admin":false},"body":"That was just mimicking the existing function signature above. I'll have to change the existing public function, too, then.","created_at":"2018-02-09T07:18:37Z","updated_at":"2018-02-09T07:18:37Z","html_url":"https://github.com/vapor/vapor/pull/1448#discussion_r167154495","pull_request_url":"https://api.github.com/repos/vapor/vapor/pulls/1448","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/vapor/vapor/pulls/comments/167154495"},"html":{"href":"https://github.com/vapor/vapor/pull/1448#discussion_r167154495"},"pull_request":{"href":"https://api.github.com/repos/vapor/vapor/pulls/1448"}},"in_reply_to_id":167153703},"pull_request":{"url":"https://api.github.com/repos/vapor/vapor/pulls/1448","id":164892084,"html_url":"https://github.com/vapor/vapor/pull/1448","diff_url":"https://github.com/vapor/vapor/pull/1448.diff","patch_url":"https://github.com/vapor/vapor/pull/1448.patch","issue_url":"https://api.github.com/repos/vapor/vapor/issues/1448","number":1448,"state":"open","locked":false,"title":"Add helpers for decoding content from requests with a body","user":{"login":"Joannis","id":1951674,"avatar_url":"https://avatars2.githubusercontent.com/u/1951674?v=4","gravatar_id":"","url":"https://api.github.com/users/Joannis","html_url":"https://github.com/Joannis","followers_url":"https://api.github.com/users/Joannis/followers","following_url":"https://api.github.com/users/Joannis/following{/other_user}","gists_url":"https://api.github.com/users/Joannis/gists{/gist_id}","starred_url":"https://api.github.com/users/Joannis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Joannis/subscriptions","organizations_url":"https://api.github.com/users/Joannis/orgs","repos_url":"https://api.github.com/users/Joannis/repos","events_url":"https://api.github.com/users/Joannis/events{/privacy}","received_events_url":"https://api.github.com/users/Joannis/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-01-24T16:11:17Z","updated_at":"2018-02-09T07:18:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8ef74bb0365adc7f739dff69b778da37a6683796","assignee":{"login":"Joannis","id":1951674,"avatar_url":"https://avatars2.githubusercontent.com/u/1951674?v=4","gravatar_id":"","url":"https://api.github.com/users/Joannis","html_url":"https://github.com/Joannis","followers_url":"https://api.github.com/users/Joannis/followers","following_url":"https://api.github.com/users/Joannis/following{/other_user}","gists_url":"https://api.github.com/users/Joannis/gists{/gist_id}","starred_url":"https://api.github.com/users/Joannis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Joannis/subscriptions","organizations_url":"https://api.github.com/users/Joannis/orgs","repos_url":"https://api.github.com/users/Joannis/repos","events_url":"https://api.github.com/users/Joannis/events{/privacy}","received_events_url":"https://api.github.com/users/Joannis/received_events","type":"User","site_admin":false},"assignees":[{"login":"Joannis","id":1951674,"avatar_url":"https://avatars2.githubusercontent.com/u/1951674?v=4","gravatar_id":"","url":"https://api.github.com/users/Joannis","html_url":"https://github.com/Joannis","followers_url":"https://api.github.com/users/Joannis/followers","following_url":"https://api.github.com/users/Joannis/following{/other_user}","gists_url":"https://api.github.com/users/Joannis/gists{/gist_id}","starred_url":"https://api.github.com/users/Joannis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Joannis/subscriptions","organizations_url":"https://api.github.com/users/Joannis/orgs","repos_url":"https://api.github.com/users/Joannis/repos","events_url":"https://api.github.com/users/Joannis/events{/privacy}","received_events_url":"https://api.github.com/users/Joannis/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/vapor/vapor/pulls/1448/commits","review_comments_url":"https://api.github.com/repos/vapor/vapor/pulls/1448/comments","review_comment_url":"https://api.github.com/repos/vapor/vapor/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vapor/vapor/issues/1448/comments","statuses_url":"https://api.github.com/repos/vapor/vapor/statuses/c132ba9bbb2b7666002efa30b5f989290ac67e26","head":{"label":"vapor:content-helpers","ref":"content-helpers","sha":"c132ba9bbb2b7666002efa30b5f989290ac67e26","user":{"login":"vapor","id":17364220,"avatar_url":"https://avatars1.githubusercontent.com/u/17364220?v=4","gravatar_id":"","url":"https://api.github.com/users/vapor","html_url":"https://github.com/vapor","followers_url":"https://api.github.com/users/vapor/followers","following_url":"https://api.github.com/users/vapor/following{/other_user}","gists_url":"https://api.github.com/users/vapor/gists{/gist_id}","starred_url":"https://api.github.com/users/vapor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vapor/subscriptions","organizations_url":"https://api.github.com/users/vapor/orgs","repos_url":"https://api.github.com/users/vapor/repos","events_url":"https://api.github.com/users/vapor/events{/privacy}","received_events_url":"https://api.github.com/users/vapor/received_events","type":"Organization","site_admin":false},"repo":{"id":49910095,"name":"vapor","full_name":"vapor/vapor","owner":{"login":"vapor","id":17364220,"avatar_url":"https://avatars1.githubusercontent.com/u/17364220?v=4","gravatar_id":"","url":"https://api.github.com/users/vapor","html_url":"https://github.com/vapor","followers_url":"https://api.github.com/users/vapor/followers","following_url":"https://api.github.com/users/vapor/following{/other_user}","gists_url":"https://api.github.com/users/vapor/gists{/gist_id}","starred_url":"https://api.github.com/users/vapor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vapor/subscriptions","organizations_url":"https://api.github.com/users/vapor/orgs","repos_url":"https://api.github.com/users/vapor/repos","events_url":"https://api.github.com/users/vapor/events{/privacy}","received_events_url":"https://api.github.com/users/vapor/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vapor/vapor","description":"💧 A server-side Swift web framework.","fork":false,"url":"https://api.github.com/repos/vapor/vapor","forks_url":"https://api.github.com/repos/vapor/vapor/forks","keys_url":"https://api.github.com/repos/vapor/vapor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vapor/vapor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vapor/vapor/teams","hooks_url":"https://api.github.com/repos/vapor/vapor/hooks","issue_events_url":"https://api.github.com/repos/vapor/vapor/issues/events{/number}","events_url":"https://api.github.com/repos/vapor/vapor/events","assignees_url":"https://api.github.com/repos/vapor/vapor/assignees{/user}","branches_url":"https://api.github.com/repos/vapor/vapor/branches{/branch}","tags_url":"https://api.github.com/repos/vapor/vapor/tags","blobs_url":"https://api.github.com/repos/vapor/vapor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vapor/vapor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vapor/vapor/git/refs{/sha}","trees_url":"https://api.github.com/repos/vapor/vapor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vapor/vapor/statuses/{sha}","languages_url":"https://api.github.com/repos/vapor/vapor/languages","stargazers_url":"https://api.github.com/repos/vapor/vapor/stargazers","contributors_url":"https://api.github.com/repos/vapor/vapor/contributors","subscribers_url":"https://api.github.com/repos/vapor/vapor/subscribers","subscription_url":"https://api.github.com/repos/vapor/vapor/subscription","commits_url":"https://api.github.com/repos/vapor/vapor/commits{/sha}","git_commits_url":"https://api.github.com/repos/vapor/vapor/git/commits{/sha}","comments_url":"https://api.github.com/repos/vapor/vapor/comments{/number}","issue_comment_url":"https://api.github.com/repos/vapor/vapor/issues/comments{/number}","contents_url":"https://api.github.com/repos/vapor/vapor/contents/{+path}","compare_url":"https://api.github.com/repos/vapor/vapor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vapor/vapor/merges","archive_url":"https://api.github.com/repos/vapor/vapor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vapor/vapor/downloads","issues_url":"https://api.github.com/repos/vapor/vapor/issues{/number}","pulls_url":"https://api.github.com/repos/vapor/vapor/pulls{/number}","milestones_url":"https://api.github.com/repos/vapor/vapor/milestones{/number}","notifications_url":"https://api.github.com/repos/vapor/vapor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vapor/vapor/labels{/name}","releases_url":"https://api.github.com/repos/vapor/vapor/releases{/id}","deployments_url":"https://api.github.com/repos/vapor/vapor/deployments","created_at":"2016-01-18T22:37:52Z","updated_at":"2018-02-08T21:07:01Z","pushed_at":"2018-02-09T07:10:12Z","git_url":"git://github.com/vapor/vapor.git","ssh_url":"[email protected]:vapor/vapor.git","clone_url":"https://github.com/vapor/vapor.git","svn_url":"https://github.com/vapor/vapor","homepage":"https://vapor.codes","size":14126,"stargazers_count":12574,"watchers_count":12574,"language":"Swift","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":764,"mirror_url":null,"archived":false,"open_issues_count":112,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":764,"open_issues":112,"watchers":12574,"default_branch":"master"}},"base":{"label":"vapor:beta","ref":"beta","sha":"51e85d8fde64b7f1a402d43096ab1b1a4477a1f8","user":{"login":"vapor","id":17364220,"avatar_url":"https://avatars1.githubusercontent.com/u/17364220?v=4","gravatar_id":"","url":"https://api.github.com/users/vapor","html_url":"https://github.com/vapor","followers_url":"https://api.github.com/users/vapor/followers","following_url":"https://api.github.com/users/vapor/following{/other_user}","gists_url":"https://api.github.com/users/vapor/gists{/gist_id}","starred_url":"https://api.github.com/users/vapor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vapor/subscriptions","organizations_url":"https://api.github.com/users/vapor/orgs","repos_url":"https://api.github.com/users/vapor/repos","events_url":"https://api.github.com/users/vapor/events{/privacy}","received_events_url":"https://api.github.com/users/vapor/received_events","type":"Organization","site_admin":false},"repo":{"id":49910095,"name":"vapor","full_name":"vapor/vapor","owner":{"login":"vapor","id":17364220,"avatar_url":"https://avatars1.githubusercontent.com/u/17364220?v=4","gravatar_id":"","url":"https://api.github.com/users/vapor","html_url":"https://github.com/vapor","followers_url":"https://api.github.com/users/vapor/followers","following_url":"https://api.github.com/users/vapor/following{/other_user}","gists_url":"https://api.github.com/users/vapor/gists{/gist_id}","starred_url":"https://api.github.com/users/vapor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vapor/subscriptions","organizations_url":"https://api.github.com/users/vapor/orgs","repos_url":"https://api.github.com/users/vapor/repos","events_url":"https://api.github.com/users/vapor/events{/privacy}","received_events_url":"https://api.github.com/users/vapor/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vapor/vapor","description":"💧 A server-side Swift web framework.","fork":false,"url":"https://api.github.com/repos/vapor/vapor","forks_url":"https://api.github.com/repos/vapor/vapor/forks","keys_url":"https://api.github.com/repos/vapor/vapor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vapor/vapor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vapor/vapor/teams","hooks_url":"https://api.github.com/repos/vapor/vapor/hooks","issue_events_url":"https://api.github.com/repos/vapor/vapor/issues/events{/number}","events_url":"https://api.github.com/repos/vapor/vapor/events","assignees_url":"https://api.github.com/repos/vapor/vapor/assignees{/user}","branches_url":"https://api.github.com/repos/vapor/vapor/branches{/branch}","tags_url":"https://api.github.com/repos/vapor/vapor/tags","blobs_url":"https://api.github.com/repos/vapor/vapor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vapor/vapor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vapor/vapor/git/refs{/sha}","trees_url":"https://api.github.com/repos/vapor/vapor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vapor/vapor/statuses/{sha}","languages_url":"https://api.github.com/repos/vapor/vapor/languages","stargazers_url":"https://api.github.com/repos/vapor/vapor/stargazers","contributors_url":"https://api.github.com/repos/vapor/vapor/contributors","subscribers_url":"https://api.github.com/repos/vapor/vapor/subscribers","subscription_url":"https://api.github.com/repos/vapor/vapor/subscription","commits_url":"https://api.github.com/repos/vapor/vapor/commits{/sha}","git_commits_url":"https://api.github.com/repos/vapor/vapor/git/commits{/sha}","comments_url":"https://api.github.com/repos/vapor/vapor/comments{/number}","issue_comment_url":"https://api.github.com/repos/vapor/vapor/issues/comments{/number}","contents_url":"https://api.github.com/repos/vapor/vapor/contents/{+path}","compare_url":"https://api.github.com/repos/vapor/vapor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vapor/vapor/merges","archive_url":"https://api.github.com/repos/vapor/vapor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vapor/vapor/downloads","issues_url":"https://api.github.com/repos/vapor/vapor/issues{/number}","pulls_url":"https://api.github.com/repos/vapor/vapor/pulls{/number}","milestones_url":"https://api.github.com/repos/vapor/vapor/milestones{/number}","notifications_url":"https://api.github.com/repos/vapor/vapor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vapor/vapor/labels{/name}","releases_url":"https://api.github.com/repos/vapor/vapor/releases{/id}","deployments_url":"https://api.github.com/repos/vapor/vapor/deployments","created_at":"2016-01-18T22:37:52Z","updated_at":"2018-02-08T21:07:01Z","pushed_at":"2018-02-09T07:10:12Z","git_url":"git://github.com/vapor/vapor.git","ssh_url":"[email protected]:vapor/vapor.git","clone_url":"https://github.com/vapor/vapor.git","svn_url":"https://github.com/vapor/vapor","homepage":"https://vapor.codes","size":14126,"stargazers_count":12574,"watchers_count":12574,"language":"Swift","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":764,"mirror_url":null,"archived":false,"open_issues_count":112,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":764,"open_issues":112,"watchers":12574,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vapor/vapor/pulls/1448"},"html":{"href":"https://github.com/vapor/vapor/pull/1448"},"issue":{"href":"https://api.github.com/repos/vapor/vapor/issues/1448"},"comments":{"href":"https://api.github.com/repos/vapor/vapor/issues/1448/comments"},"review_comments":{"href":"https://api.github.com/repos/vapor/vapor/pulls/1448/comments"},"review_comment":{"href":"https://api.github.com/repos/vapor/vapor/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vapor/vapor/pulls/1448/commits"},"statuses":{"href":"https://api.github.com/repos/vapor/vapor/statuses/c132ba9bbb2b7666002efa30b5f989290ac67e26"}},"author_association":"MEMBER"}} | {
"id": 49910095,
"name": "vapor/vapor",
"url": "https://api.github.com/repos/vapor/vapor"
} | {
"id": 1951674,
"login": "Joannis",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1951674?",
"url": "https://api.github.com/users/Joannis"
} | {
"id": 17364220,
"login": "vapor",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/17364220?",
"url": "https://api.github.com/orgs/vapor"
} | 2018-02-09T07:18:37 | 7221278223 | {"actor":{"display_login":"Joannis"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/auto-wcag/auto-wcag/pulls/comments/216564732","pull_request_review_id":153671416,"id":216564732,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNjU2NDczMg==","diff_hunk":"@@ -0,0 +1,150 @@\n+---\n+name: ARIA required owned elements\n+\n+description: |\n+\tThe rule checks existence of role(s) on required owned elements.\n+\n+success_criterion:\n+- 1.3.1\n+\n+test_aspects:\n+- DOM Tree\n+\n+authors:\n+- Audrey Maniez\n+- Jey Nandakumar\n+---\n+\n+## Test procedure\n+\n+### Applicability\n+\n+The rule applies to any element that is [exposed to assistive technologies](#exposed-to-assistive-technologies) with a [non empty](#non-empty) `role` attribute whose value is applicable to required owned elements.\n+\n+**Note:** I\n+\n+### Expectation\n+\n+Each target element has atleast one owned element with a relevant `role` attribute.\n+\n+## Assumptions\n+\n+*There are currently no assumptions/ add any assumptions as necessary*\n+\n+## Accessibility Support\n+\n+*There are no major accessibility support issues known for this rule/ or add any support details as necessary*\n+\n+## Background\n+\n+- [Required Owned Element](https://www.w3.org/TR/wai-aria-1.1/#mustContain)\n+\n+## Test Cases\n+\n+### Passed\n+\n+#### Pass example 1","path":"_rules/SC1-3-1-aria-required-owned-element.md","position":46,"original_position":46,"commit_id":"eb7a10412ac0bf1bc104ea20aef151902ec92723","original_commit_id":"eb7a10412ac0bf1bc104ea20aef151902ec92723","user":{"login":"annethyme","id":15611692,"node_id":"MDQ6VXNlcjE1NjExNjky","avatar_url":"https://avatars1.githubusercontent.com/u/15611692?v=4","gravatar_id":"","url":"https://api.github.com/users/annethyme","html_url":"https://github.com/annethyme","followers_url":"https://api.github.com/users/annethyme/followers","following_url":"https://api.github.com/users/annethyme/following{/other_user}","gists_url":"https://api.github.com/users/annethyme/gists{/gist_id}","starred_url":"https://api.github.com/users/annethyme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/annethyme/subscriptions","organizations_url":"https://api.github.com/users/annethyme/orgs","repos_url":"https://api.github.com/users/annethyme/repos","events_url":"https://api.github.com/users/annethyme/events{/privacy}","received_events_url":"https://api.github.com/users/annethyme/received_events","type":"User","site_admin":false},"body":"Should this be \"Passed example 1\"? (same for the rest)","created_at":"2018-09-11T07:08:19Z","updated_at":"2018-09-11T07:16:29Z","html_url":"https://github.com/auto-wcag/auto-wcag/pull/245#discussion_r216564732","pull_request_url":"https://api.github.com/repos/auto-wcag/auto-wcag/pulls/245","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/auto-wcag/auto-wcag/pulls/comments/216564732"},"html":{"href":"https://github.com/auto-wcag/auto-wcag/pull/245#discussion_r216564732"},"pull_request":{"href":"https://api.github.com/repos/auto-wcag/auto-wcag/pulls/245"}}},"pull_request":{"url":"https://api.github.com/repos/auto-wcag/auto-wcag/pulls/245","id":212920654,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEyOTIwNjU0","html_url":"https://github.com/auto-wcag/auto-wcag/pull/245","diff_url":"https://github.com/auto-wcag/auto-wcag/pull/245.diff","patch_url":"https://github.com/auto-wcag/auto-wcag/pull/245.patch","issue_url":"https://api.github.com/repos/auto-wcag/auto-wcag/issues/245","number":245,"state":"open","locked":false,"title":"SC1-3-1-aria-required-owned-element","user":{"login":"jkodu","id":20978252,"node_id":"MDQ6VXNlcjIwOTc4MjUy","avatar_url":"https://avatars3.githubusercontent.com/u/20978252?v=4","gravatar_id":"","url":"https://api.github.com/users/jkodu","html_url":"https://github.com/jkodu","followers_url":"https://api.github.com/users/jkodu/followers","following_url":"https://api.github.com/users/jkodu/following{/other_user}","gists_url":"https://api.github.com/users/jkodu/gists{/gist_id}","starred_url":"https://api.github.com/users/jkodu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkodu/subscriptions","organizations_url":"https://api.github.com/users/jkodu/orgs","repos_url":"https://api.github.com/users/jkodu/repos","events_url":"https://api.github.com/users/jkodu/events{/privacy}","received_events_url":"https://api.github.com/users/jkodu/received_events","type":"User","site_admin":false},"body":"New Rule: aria-required-owned-element\r\nCo-authored by @audreymaniez 👍 🎆 \r\n\r\nCloses issue: \r\n- https://github.com/auto-wcag/auto-wcag/issues/201\r\n\r\n## Guidance the the PR (pull request) creator\r\n\r\n**When creating PR:**\r\n- [ ] Make sure you requesting to **pull a issue/feature/bugfix branch** (right side) to the master branch (left side).\r\n- [ ] Make sure the pull request is prefixed with `Rule:` or `Algorithm:` or `Chore:` based on work involved.\r\n\r\n**After creating PR:**\r\n- [ ] Add yourself (and co-authors) as \"Assignees\" for PR\r\n- [ ] Add relevant project (e.g. \"Q3 2018 Status\") to PR\r\n- [ ] OPTIONAL: If you want anyone in particular to review your pull request, assign them as \"Reviewers\".\r\n- [ ] Close the issue that the PR resolves (and make sure the issue is referenced in the top of this comment)\r\n\r\n# How to Review And Approve\r\n- Go to the “files changed” tab, there you will have the option to leave comments on different lines. \r\n- Once the review is completed, find the “Review changes” button in the top right, select “approve” and click “Submit review”.\r\n","created_at":"2018-09-04T10:01:10Z","updated_at":"2018-09-11T07:16:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"965ee88d2f5f1fb8303597f2a7bceab88ddff56e","assignee":null,"assignees":[],"requested_reviewers":[{"login":"WilcoFiers","id":530687,"node_id":"MDQ6VXNlcjUzMDY4Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/530687?v=4","gravatar_id":"","url":"https://api.github.com/users/WilcoFiers","html_url":"https://github.com/WilcoFiers","followers_url":"https://api.github.com/users/WilcoFiers/followers","following_url":"https://api.github.com/users/WilcoFiers/following{/other_user}","gists_url":"https://api.github.com/users/WilcoFiers/gists{/gist_id}","starred_url":"https://api.github.com/users/WilcoFiers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WilcoFiers/subscriptions","organizations_url":"https://api.github.com/users/WilcoFiers/orgs","repos_url":"https://api.github.com/users/WilcoFiers/repos","events_url":"https://api.github.com/users/WilcoFiers/events{/privacy}","received_events_url":"https://api.github.com/users/WilcoFiers/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1051532509,"node_id":"MDU6TGFiZWwxMDUxNTMyNTA5","url":"https://api.github.com/repos/auto-wcag/auto-wcag/labels/Rule","name":"Rule","color":"d572e0","default":false},{"id":981517307,"node_id":"MDU6TGFiZWw5ODE1MTczMDc=","url":"https://api.github.com/repos/auto-wcag/auto-wcag/labels/reviewer%20wanted","name":"reviewer wanted","color":"0f1b89","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/auto-wcag/auto-wcag/pulls/245/commits","review_comments_url":"https://api.github.com/repos/auto-wcag/auto-wcag/pulls/245/comments","review_comment_url":"https://api.github.com/repos/auto-wcag/auto-wcag/pulls/comments{/number}","comments_url":"https://api.github.com/repos/auto-wcag/auto-wcag/issues/245/comments","statuses_url":"https://api.github.com/repos/auto-wcag/auto-wcag/statuses/eb7a10412ac0bf1bc104ea20aef151902ec92723","head":{"label":"auto-wcag:aria-required-owned-element","ref":"aria-required-owned-element","sha":"eb7a10412ac0bf1bc104ea20aef151902ec92723","user":{"login":"auto-wcag","id":17526379,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NTI2Mzc5","avatar_url":"https://avatars1.githubusercontent.com/u/17526379?v=4","gravatar_id":"","url":"https://api.github.com/users/auto-wcag","html_url":"https://github.com/auto-wcag","followers_url":"https://api.github.com/users/auto-wcag/followers","following_url":"https://api.github.com/users/auto-wcag/following{/other_user}","gists_url":"https://api.github.com/users/auto-wcag/gists{/gist_id}","starred_url":"https://api.github.com/users/auto-wcag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/auto-wcag/subscriptions","organizations_url":"https://api.github.com/users/auto-wcag/orgs","repos_url":"https://api.github.com/users/auto-wcag/repos","events_url":"https://api.github.com/users/auto-wcag/events{/privacy}","received_events_url":"https://api.github.com/users/auto-wcag/received_events","type":"Organization","site_admin":false},"repo":{"id":52717143,"node_id":"MDEwOlJlcG9zaXRvcnk1MjcxNzE0Mw==","name":"auto-wcag","full_name":"auto-wcag/auto-wcag","owner":{"login":"auto-wcag","id":17526379,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NTI2Mzc5","avatar_url":"https://avatars1.githubusercontent.com/u/17526379?v=4","gravatar_id":"","url":"https://api.github.com/users/auto-wcag","html_url":"https://github.com/auto-wcag","followers_url":"https://api.github.com/users/auto-wcag/followers","following_url":"https://api.github.com/users/auto-wcag/following{/other_user}","gists_url":"https://api.github.com/users/auto-wcag/gists{/gist_id}","starred_url":"https://api.github.com/users/auto-wcag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/auto-wcag/subscriptions","organizations_url":"https://api.github.com/users/auto-wcag/orgs","repos_url":"https://api.github.com/users/auto-wcag/repos","events_url":"https://api.github.com/users/auto-wcag/events{/privacy}","received_events_url":"https://api.github.com/users/auto-wcag/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/auto-wcag/auto-wcag","description":null,"fork":false,"url":"https://api.github.com/repos/auto-wcag/auto-wcag","forks_url":"https://api.github.com/repos/auto-wcag/auto-wcag/forks","keys_url":"https://api.github.com/repos/auto-wcag/auto-wcag/keys{/key_id}","collaborators_url":"https://api.github.com/repos/auto-wcag/auto-wcag/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/auto-wcag/auto-wcag/teams","hooks_url":"https://api.github.com/repos/auto-wcag/auto-wcag/hooks","issue_events_url":"https://api.github.com/repos/auto-wcag/auto-wcag/issues/events{/number}","events_url":"https://api.github.com/repos/auto-wcag/auto-wcag/events","assignees_url":"https://api.github.com/repos/auto-wcag/auto-wcag/assignees{/user}","branches_url":"https://api.github.com/repos/auto-wcag/auto-wcag/branches{/branch}","tags_url":"https://api.github.com/repos/auto-wcag/auto-wcag/tags","blobs_url":"https://api.github.com/repos/auto-wcag/auto-wcag/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/auto-wcag/auto-wcag/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/auto-wcag/auto-wcag/git/refs{/sha}","trees_url":"https://api.github.com/repos/auto-wcag/auto-wcag/git/trees{/sha}","statuses_url":"https://api.github.com/repos/auto-wcag/auto-wcag/statuses/{sha}","languages_url":"https://api.github.com/repos/auto-wcag/auto-wcag/languages","stargazers_url":"https://api.github.com/repos/auto-wcag/auto-wcag/stargazers","contributors_url":"https://api.github.com/repos/auto-wcag/auto-wcag/contributors","subscribers_url":"https://api.github.com/repos/auto-wcag/auto-wcag/subscribers","subscription_url":"https://api.github.com/repos/auto-wcag/auto-wcag/subscription","commits_url":"https://api.github.com/repos/auto-wcag/auto-wcag/commits{/sha}","git_commits_url":"https://api.github.com/repos/auto-wcag/auto-wcag/git/commits{/sha}","comments_url":"https://api.github.com/repos/auto-wcag/auto-wcag/comments{/number}","issue_comment_url":"https://api.github.com/repos/auto-wcag/auto-wcag/issues/comments{/number}","contents_url":"https://api.github.com/repos/auto-wcag/auto-wcag/contents/{+path}","compare_url":"https://api.github.com/repos/auto-wcag/auto-wcag/compare/{base}...{head}","merges_url":"https://api.github.com/repos/auto-wcag/auto-wcag/merges","archive_url":"https://api.github.com/repos/auto-wcag/auto-wcag/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/auto-wcag/auto-wcag/downloads","issues_url":"https://api.github.com/repos/auto-wcag/auto-wcag/issues{/number}","pulls_url":"https://api.github.com/repos/auto-wcag/auto-wcag/pulls{/number}","milestones_url":"https://api.github.com/repos/auto-wcag/auto-wcag/milestones{/number}","notifications_url":"https://api.github.com/repos/auto-wcag/auto-wcag/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/auto-wcag/auto-wcag/labels{/name}","releases_url":"https://api.github.com/repos/auto-wcag/auto-wcag/releases{/id}","deployments_url":"https://api.github.com/repos/auto-wcag/auto-wcag/deployments","created_at":"2016-02-28T11:08:46Z","updated_at":"2018-09-03T13:59:12Z","pushed_at":"2018-09-07T10:47:26Z","git_url":"git://github.com/auto-wcag/auto-wcag.git","ssh_url":"[email protected]:auto-wcag/auto-wcag.git","clone_url":"https://github.com/auto-wcag/auto-wcag.git","svn_url":"https://github.com/auto-wcag/auto-wcag","homepage":null,"size":141089,"stargazers_count":17,"watchers_count":17,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":18,"mirror_url":null,"archived":false,"open_issues_count":66,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":18,"open_issues":66,"watchers":17,"default_branch":"master"}},"base":{"label":"auto-wcag:master","ref":"master","sha":"7c4aef330fe630712bfa309bd708c6f2734e6599","user":{"login":"auto-wcag","id":17526379,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NTI2Mzc5","avatar_url":"https://avatars1.githubusercontent.com/u/17526379?v=4","gravatar_id":"","url":"https://api.github.com/users/auto-wcag","html_url":"https://github.com/auto-wcag","followers_url":"https://api.github.com/users/auto-wcag/followers","following_url":"https://api.github.com/users/auto-wcag/following{/other_user}","gists_url":"https://api.github.com/users/auto-wcag/gists{/gist_id}","starred_url":"https://api.github.com/users/auto-wcag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/auto-wcag/subscriptions","organizations_url":"https://api.github.com/users/auto-wcag/orgs","repos_url":"https://api.github.com/users/auto-wcag/repos","events_url":"https://api.github.com/users/auto-wcag/events{/privacy}","received_events_url":"https://api.github.com/users/auto-wcag/received_events","type":"Organization","site_admin":false},"repo":{"id":52717143,"node_id":"MDEwOlJlcG9zaXRvcnk1MjcxNzE0Mw==","name":"auto-wcag","full_name":"auto-wcag/auto-wcag","owner":{"login":"auto-wcag","id":17526379,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NTI2Mzc5","avatar_url":"https://avatars1.githubusercontent.com/u/17526379?v=4","gravatar_id":"","url":"https://api.github.com/users/auto-wcag","html_url":"https://github.com/auto-wcag","followers_url":"https://api.github.com/users/auto-wcag/followers","following_url":"https://api.github.com/users/auto-wcag/following{/other_user}","gists_url":"https://api.github.com/users/auto-wcag/gists{/gist_id}","starred_url":"https://api.github.com/users/auto-wcag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/auto-wcag/subscriptions","organizations_url":"https://api.github.com/users/auto-wcag/orgs","repos_url":"https://api.github.com/users/auto-wcag/repos","events_url":"https://api.github.com/users/auto-wcag/events{/privacy}","received_events_url":"https://api.github.com/users/auto-wcag/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/auto-wcag/auto-wcag","description":null,"fork":false,"url":"https://api.github.com/repos/auto-wcag/auto-wcag","forks_url":"https://api.github.com/repos/auto-wcag/auto-wcag/forks","keys_url":"https://api.github.com/repos/auto-wcag/auto-wcag/keys{/key_id}","collaborators_url":"https://api.github.com/repos/auto-wcag/auto-wcag/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/auto-wcag/auto-wcag/teams","hooks_url":"https://api.github.com/repos/auto-wcag/auto-wcag/hooks","issue_events_url":"https://api.github.com/repos/auto-wcag/auto-wcag/issues/events{/number}","events_url":"https://api.github.com/repos/auto-wcag/auto-wcag/events","assignees_url":"https://api.github.com/repos/auto-wcag/auto-wcag/assignees{/user}","branches_url":"https://api.github.com/repos/auto-wcag/auto-wcag/branches{/branch}","tags_url":"https://api.github.com/repos/auto-wcag/auto-wcag/tags","blobs_url":"https://api.github.com/repos/auto-wcag/auto-wcag/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/auto-wcag/auto-wcag/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/auto-wcag/auto-wcag/git/refs{/sha}","trees_url":"https://api.github.com/repos/auto-wcag/auto-wcag/git/trees{/sha}","statuses_url":"https://api.github.com/repos/auto-wcag/auto-wcag/statuses/{sha}","languages_url":"https://api.github.com/repos/auto-wcag/auto-wcag/languages","stargazers_url":"https://api.github.com/repos/auto-wcag/auto-wcag/stargazers","contributors_url":"https://api.github.com/repos/auto-wcag/auto-wcag/contributors","subscribers_url":"https://api.github.com/repos/auto-wcag/auto-wcag/subscribers","subscription_url":"https://api.github.com/repos/auto-wcag/auto-wcag/subscription","commits_url":"https://api.github.com/repos/auto-wcag/auto-wcag/commits{/sha}","git_commits_url":"https://api.github.com/repos/auto-wcag/auto-wcag/git/commits{/sha}","comments_url":"https://api.github.com/repos/auto-wcag/auto-wcag/comments{/number}","issue_comment_url":"https://api.github.com/repos/auto-wcag/auto-wcag/issues/comments{/number}","contents_url":"https://api.github.com/repos/auto-wcag/auto-wcag/contents/{+path}","compare_url":"https://api.github.com/repos/auto-wcag/auto-wcag/compare/{base}...{head}","merges_url":"https://api.github.com/repos/auto-wcag/auto-wcag/merges","archive_url":"https://api.github.com/repos/auto-wcag/auto-wcag/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/auto-wcag/auto-wcag/downloads","issues_url":"https://api.github.com/repos/auto-wcag/auto-wcag/issues{/number}","pulls_url":"https://api.github.com/repos/auto-wcag/auto-wcag/pulls{/number}","milestones_url":"https://api.github.com/repos/auto-wcag/auto-wcag/milestones{/number}","notifications_url":"https://api.github.com/repos/auto-wcag/auto-wcag/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/auto-wcag/auto-wcag/labels{/name}","releases_url":"https://api.github.com/repos/auto-wcag/auto-wcag/releases{/id}","deployments_url":"https://api.github.com/repos/auto-wcag/auto-wcag/deployments","created_at":"2016-02-28T11:08:46Z","updated_at":"2018-09-03T13:59:12Z","pushed_at":"2018-09-07T10:47:26Z","git_url":"git://github.com/auto-wcag/auto-wcag.git","ssh_url":"[email protected]:auto-wcag/auto-wcag.git","clone_url":"https://github.com/auto-wcag/auto-wcag.git","svn_url":"https://github.com/auto-wcag/auto-wcag","homepage":null,"size":141089,"stargazers_count":17,"watchers_count":17,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":18,"mirror_url":null,"archived":false,"open_issues_count":66,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":18,"open_issues":66,"watchers":17,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/auto-wcag/auto-wcag/pulls/245"},"html":{"href":"https://github.com/auto-wcag/auto-wcag/pull/245"},"issue":{"href":"https://api.github.com/repos/auto-wcag/auto-wcag/issues/245"},"comments":{"href":"https://api.github.com/repos/auto-wcag/auto-wcag/issues/245/comments"},"review_comments":{"href":"https://api.github.com/repos/auto-wcag/auto-wcag/pulls/245/comments"},"review_comment":{"href":"https://api.github.com/repos/auto-wcag/auto-wcag/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/auto-wcag/auto-wcag/pulls/245/commits"},"statuses":{"href":"https://api.github.com/repos/auto-wcag/auto-wcag/statuses/eb7a10412ac0bf1bc104ea20aef151902ec92723"}},"author_association":"COLLABORATOR"}} | {
"id": 52717143,
"name": "auto-wcag/auto-wcag",
"url": "https://api.github.com/repos/auto-wcag/auto-wcag"
} | {
"id": 15611692,
"login": "annethyme",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/15611692?",
"url": "https://api.github.com/users/annethyme"
} | {
"id": 17526379,
"login": "auto-wcag",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/17526379?",
"url": "https://api.github.com/orgs/auto-wcag"
} | 2018-09-11T07:08:19 | 8244671632 | {"actor":{"display_login":"annethyme"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/cuappdev/clicker-backend/pulls/comments/174991166","pull_request_review_id":104447555,"id":174991166,"diff_hunk":"@@ -30,10 +30,24 @@ export class User extends Base {\n @Column('string')\n lastName: string = '';\n \n+ @ManyToMany(type => Poll, poll => poll.admins)\n+ @JoinTable()\n+ myPolls: ?Poll[] = [];","path":"src/models/User.js","position":6,"original_position":6,"commit_id":"524b9273cab102824ef52a60399dfbe331cd5872","original_commit_id":"524b9273cab102824ef52a60399dfbe331cd5872","user":{"login":"JehronPett","id":21367399,"avatar_url":"https://avatars3.githubusercontent.com/u/21367399?v=4","gravatar_id":"","url":"https://api.github.com/users/JehronPett","html_url":"https://github.com/JehronPett","followers_url":"https://api.github.com/users/JehronPett/followers","following_url":"https://api.github.com/users/JehronPett/following{/other_user}","gists_url":"https://api.github.com/users/JehronPett/gists{/gist_id}","starred_url":"https://api.github.com/users/JehronPett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JehronPett/subscriptions","organizations_url":"https://api.github.com/users/JehronPett/orgs","repos_url":"https://api.github.com/users/JehronPett/repos","events_url":"https://api.github.com/users/JehronPett/events{/privacy}","received_events_url":"https://api.github.com/users/JehronPett/received_events","type":"User","site_admin":false},"body":"definitely","created_at":"2018-03-16T03:41:24Z","updated_at":"2018-03-16T03:41:24Z","html_url":"https://github.com/cuappdev/clicker-backend/pull/85#discussion_r174991166","pull_request_url":"https://api.github.com/repos/cuappdev/clicker-backend/pulls/85","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/cuappdev/clicker-backend/pulls/comments/174991166"},"html":{"href":"https://github.com/cuappdev/clicker-backend/pull/85#discussion_r174991166"},"pull_request":{"href":"https://api.github.com/repos/cuappdev/clicker-backend/pulls/85"}},"in_reply_to_id":174989785},"pull_request":{"url":"https://api.github.com/repos/cuappdev/clicker-backend/pulls/85","id":175423917,"html_url":"https://github.com/cuappdev/clicker-backend/pull/85","diff_url":"https://github.com/cuappdev/clicker-backend/pull/85.diff","patch_url":"https://github.com/cuappdev/clicker-backend/pull/85.patch","issue_url":"https://api.github.com/repos/cuappdev/clicker-backend/issues/85","number":85,"state":"open","locked":false,"title":"Route auth","user":{"login":"JehronPett","id":21367399,"avatar_url":"https://avatars3.githubusercontent.com/u/21367399?v=4","gravatar_id":"","url":"https://api.github.com/users/JehronPett","html_url":"https://github.com/JehronPett","followers_url":"https://api.github.com/users/JehronPett/followers","following_url":"https://api.github.com/users/JehronPett/following{/other_user}","gists_url":"https://api.github.com/users/JehronPett/gists{/gist_id}","starred_url":"https://api.github.com/users/JehronPett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JehronPett/subscriptions","organizations_url":"https://api.github.com/users/JehronPett/orgs","repos_url":"https://api.github.com/users/JehronPett/repos","events_url":"https://api.github.com/users/JehronPett/events{/privacy}","received_events_url":"https://api.github.com/users/JehronPett/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-03-16T02:10:21Z","updated_at":"2018-03-16T03:41:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e705564ac7f7915ed84b4b4cea5131a800277fc4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/cuappdev/clicker-backend/pulls/85/commits","review_comments_url":"https://api.github.com/repos/cuappdev/clicker-backend/pulls/85/comments","review_comment_url":"https://api.github.com/repos/cuappdev/clicker-backend/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cuappdev/clicker-backend/issues/85/comments","statuses_url":"https://api.github.com/repos/cuappdev/clicker-backend/statuses/524b9273cab102824ef52a60399dfbe331cd5872","head":{"label":"cuappdev:routeAuth","ref":"routeAuth","sha":"524b9273cab102824ef52a60399dfbe331cd5872","user":{"login":"cuappdev","id":17533691,"avatar_url":"https://avatars0.githubusercontent.com/u/17533691?v=4","gravatar_id":"","url":"https://api.github.com/users/cuappdev","html_url":"https://github.com/cuappdev","followers_url":"https://api.github.com/users/cuappdev/followers","following_url":"https://api.github.com/users/cuappdev/following{/other_user}","gists_url":"https://api.github.com/users/cuappdev/gists{/gist_id}","starred_url":"https://api.github.com/users/cuappdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cuappdev/subscriptions","organizations_url":"https://api.github.com/users/cuappdev/orgs","repos_url":"https://api.github.com/users/cuappdev/repos","events_url":"https://api.github.com/users/cuappdev/events{/privacy}","received_events_url":"https://api.github.com/users/cuappdev/received_events","type":"Organization","site_admin":false},"repo":{"id":82960237,"name":"clicker-backend","full_name":"cuappdev/clicker-backend","owner":{"login":"cuappdev","id":17533691,"avatar_url":"https://avatars0.githubusercontent.com/u/17533691?v=4","gravatar_id":"","url":"https://api.github.com/users/cuappdev","html_url":"https://github.com/cuappdev","followers_url":"https://api.github.com/users/cuappdev/followers","following_url":"https://api.github.com/users/cuappdev/following{/other_user}","gists_url":"https://api.github.com/users/cuappdev/gists{/gist_id}","starred_url":"https://api.github.com/users/cuappdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cuappdev/subscriptions","organizations_url":"https://api.github.com/users/cuappdev/orgs","repos_url":"https://api.github.com/users/cuappdev/repos","events_url":"https://api.github.com/users/cuappdev/events{/privacy}","received_events_url":"https://api.github.com/users/cuappdev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cuappdev/clicker-backend","description":"Backend for the clicker app","fork":false,"url":"https://api.github.com/repos/cuappdev/clicker-backend","forks_url":"https://api.github.com/repos/cuappdev/clicker-backend/forks","keys_url":"https://api.github.com/repos/cuappdev/clicker-backend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cuappdev/clicker-backend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cuappdev/clicker-backend/teams","hooks_url":"https://api.github.com/repos/cuappdev/clicker-backend/hooks","issue_events_url":"https://api.github.com/repos/cuappdev/clicker-backend/issues/events{/number}","events_url":"https://api.github.com/repos/cuappdev/clicker-backend/events","assignees_url":"https://api.github.com/repos/cuappdev/clicker-backend/assignees{/user}","branches_url":"https://api.github.com/repos/cuappdev/clicker-backend/branches{/branch}","tags_url":"https://api.github.com/repos/cuappdev/clicker-backend/tags","blobs_url":"https://api.github.com/repos/cuappdev/clicker-backend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cuappdev/clicker-backend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cuappdev/clicker-backend/git/refs{/sha}","trees_url":"https://api.github.com/repos/cuappdev/clicker-backend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cuappdev/clicker-backend/statuses/{sha}","languages_url":"https://api.github.com/repos/cuappdev/clicker-backend/languages","stargazers_url":"https://api.github.com/repos/cuappdev/clicker-backend/stargazers","contributors_url":"https://api.github.com/repos/cuappdev/clicker-backend/contributors","subscribers_url":"https://api.github.com/repos/cuappdev/clicker-backend/subscribers","subscription_url":"https://api.github.com/repos/cuappdev/clicker-backend/subscription","commits_url":"https://api.github.com/repos/cuappdev/clicker-backend/commits{/sha}","git_commits_url":"https://api.github.com/repos/cuappdev/clicker-backend/git/commits{/sha}","comments_url":"https://api.github.com/repos/cuappdev/clicker-backend/comments{/number}","issue_comment_url":"https://api.github.com/repos/cuappdev/clicker-backend/issues/comments{/number}","contents_url":"https://api.github.com/repos/cuappdev/clicker-backend/contents/{+path}","compare_url":"https://api.github.com/repos/cuappdev/clicker-backend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cuappdev/clicker-backend/merges","archive_url":"https://api.github.com/repos/cuappdev/clicker-backend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cuappdev/clicker-backend/downloads","issues_url":"https://api.github.com/repos/cuappdev/clicker-backend/issues{/number}","pulls_url":"https://api.github.com/repos/cuappdev/clicker-backend/pulls{/number}","milestones_url":"https://api.github.com/repos/cuappdev/clicker-backend/milestones{/number}","notifications_url":"https://api.github.com/repos/cuappdev/clicker-backend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cuappdev/clicker-backend/labels{/name}","releases_url":"https://api.github.com/repos/cuappdev/clicker-backend/releases{/id}","deployments_url":"https://api.github.com/repos/cuappdev/clicker-backend/deployments","created_at":"2017-02-23T18:52:52Z","updated_at":"2018-03-14T04:09:33Z","pushed_at":"2018-03-16T02:10:22Z","git_url":"git://github.com/cuappdev/clicker-backend.git","ssh_url":"[email protected]:cuappdev/clicker-backend.git","clone_url":"https://github.com/cuappdev/clicker-backend.git","svn_url":"https://github.com/cuappdev/clicker-backend","homepage":null,"size":372,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":4,"license":null,"forks":0,"open_issues":4,"watchers":1,"default_branch":"master"}},"base":{"label":"cuappdev:megan/users","ref":"megan/users","sha":"e5764b3ee366a2f21e1fb14bd2d56fe82c9a3a74","user":{"login":"cuappdev","id":17533691,"avatar_url":"https://avatars0.githubusercontent.com/u/17533691?v=4","gravatar_id":"","url":"https://api.github.com/users/cuappdev","html_url":"https://github.com/cuappdev","followers_url":"https://api.github.com/users/cuappdev/followers","following_url":"https://api.github.com/users/cuappdev/following{/other_user}","gists_url":"https://api.github.com/users/cuappdev/gists{/gist_id}","starred_url":"https://api.github.com/users/cuappdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cuappdev/subscriptions","organizations_url":"https://api.github.com/users/cuappdev/orgs","repos_url":"https://api.github.com/users/cuappdev/repos","events_url":"https://api.github.com/users/cuappdev/events{/privacy}","received_events_url":"https://api.github.com/users/cuappdev/received_events","type":"Organization","site_admin":false},"repo":{"id":82960237,"name":"clicker-backend","full_name":"cuappdev/clicker-backend","owner":{"login":"cuappdev","id":17533691,"avatar_url":"https://avatars0.githubusercontent.com/u/17533691?v=4","gravatar_id":"","url":"https://api.github.com/users/cuappdev","html_url":"https://github.com/cuappdev","followers_url":"https://api.github.com/users/cuappdev/followers","following_url":"https://api.github.com/users/cuappdev/following{/other_user}","gists_url":"https://api.github.com/users/cuappdev/gists{/gist_id}","starred_url":"https://api.github.com/users/cuappdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cuappdev/subscriptions","organizations_url":"https://api.github.com/users/cuappdev/orgs","repos_url":"https://api.github.com/users/cuappdev/repos","events_url":"https://api.github.com/users/cuappdev/events{/privacy}","received_events_url":"https://api.github.com/users/cuappdev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cuappdev/clicker-backend","description":"Backend for the clicker app","fork":false,"url":"https://api.github.com/repos/cuappdev/clicker-backend","forks_url":"https://api.github.com/repos/cuappdev/clicker-backend/forks","keys_url":"https://api.github.com/repos/cuappdev/clicker-backend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cuappdev/clicker-backend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cuappdev/clicker-backend/teams","hooks_url":"https://api.github.com/repos/cuappdev/clicker-backend/hooks","issue_events_url":"https://api.github.com/repos/cuappdev/clicker-backend/issues/events{/number}","events_url":"https://api.github.com/repos/cuappdev/clicker-backend/events","assignees_url":"https://api.github.com/repos/cuappdev/clicker-backend/assignees{/user}","branches_url":"https://api.github.com/repos/cuappdev/clicker-backend/branches{/branch}","tags_url":"https://api.github.com/repos/cuappdev/clicker-backend/tags","blobs_url":"https://api.github.com/repos/cuappdev/clicker-backend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cuappdev/clicker-backend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cuappdev/clicker-backend/git/refs{/sha}","trees_url":"https://api.github.com/repos/cuappdev/clicker-backend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cuappdev/clicker-backend/statuses/{sha}","languages_url":"https://api.github.com/repos/cuappdev/clicker-backend/languages","stargazers_url":"https://api.github.com/repos/cuappdev/clicker-backend/stargazers","contributors_url":"https://api.github.com/repos/cuappdev/clicker-backend/contributors","subscribers_url":"https://api.github.com/repos/cuappdev/clicker-backend/subscribers","subscription_url":"https://api.github.com/repos/cuappdev/clicker-backend/subscription","commits_url":"https://api.github.com/repos/cuappdev/clicker-backend/commits{/sha}","git_commits_url":"https://api.github.com/repos/cuappdev/clicker-backend/git/commits{/sha}","comments_url":"https://api.github.com/repos/cuappdev/clicker-backend/comments{/number}","issue_comment_url":"https://api.github.com/repos/cuappdev/clicker-backend/issues/comments{/number}","contents_url":"https://api.github.com/repos/cuappdev/clicker-backend/contents/{+path}","compare_url":"https://api.github.com/repos/cuappdev/clicker-backend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cuappdev/clicker-backend/merges","archive_url":"https://api.github.com/repos/cuappdev/clicker-backend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cuappdev/clicker-backend/downloads","issues_url":"https://api.github.com/repos/cuappdev/clicker-backend/issues{/number}","pulls_url":"https://api.github.com/repos/cuappdev/clicker-backend/pulls{/number}","milestones_url":"https://api.github.com/repos/cuappdev/clicker-backend/milestones{/number}","notifications_url":"https://api.github.com/repos/cuappdev/clicker-backend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cuappdev/clicker-backend/labels{/name}","releases_url":"https://api.github.com/repos/cuappdev/clicker-backend/releases{/id}","deployments_url":"https://api.github.com/repos/cuappdev/clicker-backend/deployments","created_at":"2017-02-23T18:52:52Z","updated_at":"2018-03-14T04:09:33Z","pushed_at":"2018-03-16T02:10:22Z","git_url":"git://github.com/cuappdev/clicker-backend.git","ssh_url":"[email protected]:cuappdev/clicker-backend.git","clone_url":"https://github.com/cuappdev/clicker-backend.git","svn_url":"https://github.com/cuappdev/clicker-backend","homepage":null,"size":372,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":4,"license":null,"forks":0,"open_issues":4,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cuappdev/clicker-backend/pulls/85"},"html":{"href":"https://github.com/cuappdev/clicker-backend/pull/85"},"issue":{"href":"https://api.github.com/repos/cuappdev/clicker-backend/issues/85"},"comments":{"href":"https://api.github.com/repos/cuappdev/clicker-backend/issues/85/comments"},"review_comments":{"href":"https://api.github.com/repos/cuappdev/clicker-backend/pulls/85/comments"},"review_comment":{"href":"https://api.github.com/repos/cuappdev/clicker-backend/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cuappdev/clicker-backend/pulls/85/commits"},"statuses":{"href":"https://api.github.com/repos/cuappdev/clicker-backend/statuses/524b9273cab102824ef52a60399dfbe331cd5872"}},"author_association":"CONTRIBUTOR"}} | {
"id": 82960237,
"name": "cuappdev/clicker-backend",
"url": "https://api.github.com/repos/cuappdev/clicker-backend"
} | {
"id": 21367399,
"login": "JehronPett",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/21367399?",
"url": "https://api.github.com/users/JehronPett"
} | {
"id": 17533691,
"login": "cuappdev",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/17533691?",
"url": "https://api.github.com/orgs/cuappdev"
} | 2018-03-16T03:41:24 | 7388598053 | {"actor":{"display_login":"JehronPett"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/node-nock/nock/pulls/comments/172409232","pull_request_review_id":101418705,"id":172409232,"diff_hunk":"@@ -322,23 +322,44 @@ tap.test('nockBack record tests', function (nw) {\n //Adding this test because there was an issue when not calling\n //nock.activate() after calling nock.restore()\n nw.test('it can record twice', {skip: process.env.AIRPLANE}, function (t) {\n+","path":"tests/test_back.js","position":4,"original_position":4,"commit_id":"b9329ed2f09e9171df772f47c64e817e503b382a","original_commit_id":"b9329ed2f09e9171df772f47c64e817e503b382a","user":{"login":"mbad0la","id":8503331,"avatar_url":"https://avatars2.githubusercontent.com/u/8503331?v=4","gravatar_id":"","url":"https://api.github.com/users/mbad0la","html_url":"https://github.com/mbad0la","followers_url":"https://api.github.com/users/mbad0la/followers","following_url":"https://api.github.com/users/mbad0la/following{/other_user}","gists_url":"https://api.github.com/users/mbad0la/gists{/gist_id}","starred_url":"https://api.github.com/users/mbad0la/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbad0la/subscriptions","organizations_url":"https://api.github.com/users/mbad0la/orgs","repos_url":"https://api.github.com/users/mbad0la/repos","events_url":"https://api.github.com/users/mbad0la/events{/privacy}","received_events_url":"https://api.github.com/users/mbad0la/received_events","type":"User","site_admin":false},"body":"I added it deliberately. Found it to improve readability for me. I'll remove it.","created_at":"2018-03-06T04:51:29Z","updated_at":"2018-03-06T04:51:29Z","html_url":"https://github.com/node-nock/nock/pull/1090#discussion_r172409232","pull_request_url":"https://api.github.com/repos/node-nock/nock/pulls/1090","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/node-nock/nock/pulls/comments/172409232"},"html":{"href":"https://github.com/node-nock/nock/pull/1090#discussion_r172409232"},"pull_request":{"href":"https://api.github.com/repos/node-nock/nock/pulls/1090"}},"in_reply_to_id":172289746},"pull_request":{"url":"https://api.github.com/repos/node-nock/nock/pulls/1090","id":172775560,"html_url":"https://github.com/node-nock/nock/pull/1090","diff_url":"https://github.com/node-nock/nock/pull/1090.diff","patch_url":"https://github.com/node-nock/nock/pull/1090.patch","issue_url":"https://api.github.com/repos/node-nock/nock/issues/1090","number":1090,"state":"open","locked":false,"title":"Remove airplane dependency from \"tests/test_back.js#L261\"","user":{"login":"mbad0la","id":8503331,"avatar_url":"https://avatars2.githubusercontent.com/u/8503331?v=4","gravatar_id":"","url":"https://api.github.com/users/mbad0la","html_url":"https://github.com/mbad0la","followers_url":"https://api.github.com/users/mbad0la/followers","following_url":"https://api.github.com/users/mbad0la/following{/other_user}","gists_url":"https://api.github.com/users/mbad0la/gists{/gist_id}","starred_url":"https://api.github.com/users/mbad0la/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbad0la/subscriptions","organizations_url":"https://api.github.com/users/mbad0la/orgs","repos_url":"https://api.github.com/users/mbad0la/repos","events_url":"https://api.github.com/users/mbad0la/events{/privacy}","received_events_url":"https://api.github.com/users/mbad0la/received_events","type":"User","site_admin":false},"body":"Fixes #1086 . Part of #1077 ","created_at":"2018-03-05T05:13:01Z","updated_at":"2018-03-06T04:51:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"00a1892c61103585b5ab38fe39cb44ad964f29b7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/node-nock/nock/pulls/1090/commits","review_comments_url":"https://api.github.com/repos/node-nock/nock/pulls/1090/comments","review_comment_url":"https://api.github.com/repos/node-nock/nock/pulls/comments{/number}","comments_url":"https://api.github.com/repos/node-nock/nock/issues/1090/comments","statuses_url":"https://api.github.com/repos/node-nock/nock/statuses/b9329ed2f09e9171df772f47c64e817e503b382a","head":{"label":"node-nock:mbadola/1086","ref":"mbadola/1086","sha":"b9329ed2f09e9171df772f47c64e817e503b382a","user":{"login":"node-nock","id":17545810,"avatar_url":"https://avatars2.githubusercontent.com/u/17545810?v=4","gravatar_id":"","url":"https://api.github.com/users/node-nock","html_url":"https://github.com/node-nock","followers_url":"https://api.github.com/users/node-nock/followers","following_url":"https://api.github.com/users/node-nock/following{/other_user}","gists_url":"https://api.github.com/users/node-nock/gists{/gist_id}","starred_url":"https://api.github.com/users/node-nock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/node-nock/subscriptions","organizations_url":"https://api.github.com/users/node-nock/orgs","repos_url":"https://api.github.com/users/node-nock/repos","events_url":"https://api.github.com/users/node-nock/events{/privacy}","received_events_url":"https://api.github.com/users/node-nock/received_events","type":"Organization","site_admin":false},"repo":{"id":2436267,"name":"nock","full_name":"node-nock/nock","owner":{"login":"node-nock","id":17545810,"avatar_url":"https://avatars2.githubusercontent.com/u/17545810?v=4","gravatar_id":"","url":"https://api.github.com/users/node-nock","html_url":"https://github.com/node-nock","followers_url":"https://api.github.com/users/node-nock/followers","following_url":"https://api.github.com/users/node-nock/following{/other_user}","gists_url":"https://api.github.com/users/node-nock/gists{/gist_id}","starred_url":"https://api.github.com/users/node-nock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/node-nock/subscriptions","organizations_url":"https://api.github.com/users/node-nock/orgs","repos_url":"https://api.github.com/users/node-nock/repos","events_url":"https://api.github.com/users/node-nock/events{/privacy}","received_events_url":"https://api.github.com/users/node-nock/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/node-nock/nock","description":"HTTP mocking and expectations library","fork":false,"url":"https://api.github.com/repos/node-nock/nock","forks_url":"https://api.github.com/repos/node-nock/nock/forks","keys_url":"https://api.github.com/repos/node-nock/nock/keys{/key_id}","collaborators_url":"https://api.github.com/repos/node-nock/nock/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/node-nock/nock/teams","hooks_url":"https://api.github.com/repos/node-nock/nock/hooks","issue_events_url":"https://api.github.com/repos/node-nock/nock/issues/events{/number}","events_url":"https://api.github.com/repos/node-nock/nock/events","assignees_url":"https://api.github.com/repos/node-nock/nock/assignees{/user}","branches_url":"https://api.github.com/repos/node-nock/nock/branches{/branch}","tags_url":"https://api.github.com/repos/node-nock/nock/tags","blobs_url":"https://api.github.com/repos/node-nock/nock/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/node-nock/nock/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/node-nock/nock/git/refs{/sha}","trees_url":"https://api.github.com/repos/node-nock/nock/git/trees{/sha}","statuses_url":"https://api.github.com/repos/node-nock/nock/statuses/{sha}","languages_url":"https://api.github.com/repos/node-nock/nock/languages","stargazers_url":"https://api.github.com/repos/node-nock/nock/stargazers","contributors_url":"https://api.github.com/repos/node-nock/nock/contributors","subscribers_url":"https://api.github.com/repos/node-nock/nock/subscribers","subscription_url":"https://api.github.com/repos/node-nock/nock/subscription","commits_url":"https://api.github.com/repos/node-nock/nock/commits{/sha}","git_commits_url":"https://api.github.com/repos/node-nock/nock/git/commits{/sha}","comments_url":"https://api.github.com/repos/node-nock/nock/comments{/number}","issue_comment_url":"https://api.github.com/repos/node-nock/nock/issues/comments{/number}","contents_url":"https://api.github.com/repos/node-nock/nock/contents/{+path}","compare_url":"https://api.github.com/repos/node-nock/nock/compare/{base}...{head}","merges_url":"https://api.github.com/repos/node-nock/nock/merges","archive_url":"https://api.github.com/repos/node-nock/nock/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/node-nock/nock/downloads","issues_url":"https://api.github.com/repos/node-nock/nock/issues{/number}","pulls_url":"https://api.github.com/repos/node-nock/nock/pulls{/number}","milestones_url":"https://api.github.com/repos/node-nock/nock/milestones{/number}","notifications_url":"https://api.github.com/repos/node-nock/nock/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/node-nock/nock/labels{/name}","releases_url":"https://api.github.com/repos/node-nock/nock/releases{/id}","deployments_url":"https://api.github.com/repos/node-nock/nock/deployments","created_at":"2011-09-22T10:08:03Z","updated_at":"2018-03-06T01:50:56Z","pushed_at":"2018-03-05T05:13:01Z","git_url":"git://github.com/node-nock/nock.git","ssh_url":"[email protected]:node-nock/nock.git","clone_url":"https://github.com/node-nock/nock.git","svn_url":"https://github.com/node-nock/nock","homepage":"","size":3162,"stargazers_count":5953,"watchers_count":5953,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":446,"mirror_url":null,"archived":false,"open_issues_count":155,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":446,"open_issues":155,"watchers":5953,"default_branch":"master"}},"base":{"label":"node-nock:master","ref":"master","sha":"41a583d78ed0ffb9bc7305f5a6caf2549ef490c9","user":{"login":"node-nock","id":17545810,"avatar_url":"https://avatars2.githubusercontent.com/u/17545810?v=4","gravatar_id":"","url":"https://api.github.com/users/node-nock","html_url":"https://github.com/node-nock","followers_url":"https://api.github.com/users/node-nock/followers","following_url":"https://api.github.com/users/node-nock/following{/other_user}","gists_url":"https://api.github.com/users/node-nock/gists{/gist_id}","starred_url":"https://api.github.com/users/node-nock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/node-nock/subscriptions","organizations_url":"https://api.github.com/users/node-nock/orgs","repos_url":"https://api.github.com/users/node-nock/repos","events_url":"https://api.github.com/users/node-nock/events{/privacy}","received_events_url":"https://api.github.com/users/node-nock/received_events","type":"Organization","site_admin":false},"repo":{"id":2436267,"name":"nock","full_name":"node-nock/nock","owner":{"login":"node-nock","id":17545810,"avatar_url":"https://avatars2.githubusercontent.com/u/17545810?v=4","gravatar_id":"","url":"https://api.github.com/users/node-nock","html_url":"https://github.com/node-nock","followers_url":"https://api.github.com/users/node-nock/followers","following_url":"https://api.github.com/users/node-nock/following{/other_user}","gists_url":"https://api.github.com/users/node-nock/gists{/gist_id}","starred_url":"https://api.github.com/users/node-nock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/node-nock/subscriptions","organizations_url":"https://api.github.com/users/node-nock/orgs","repos_url":"https://api.github.com/users/node-nock/repos","events_url":"https://api.github.com/users/node-nock/events{/privacy}","received_events_url":"https://api.github.com/users/node-nock/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/node-nock/nock","description":"HTTP mocking and expectations library","fork":false,"url":"https://api.github.com/repos/node-nock/nock","forks_url":"https://api.github.com/repos/node-nock/nock/forks","keys_url":"https://api.github.com/repos/node-nock/nock/keys{/key_id}","collaborators_url":"https://api.github.com/repos/node-nock/nock/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/node-nock/nock/teams","hooks_url":"https://api.github.com/repos/node-nock/nock/hooks","issue_events_url":"https://api.github.com/repos/node-nock/nock/issues/events{/number}","events_url":"https://api.github.com/repos/node-nock/nock/events","assignees_url":"https://api.github.com/repos/node-nock/nock/assignees{/user}","branches_url":"https://api.github.com/repos/node-nock/nock/branches{/branch}","tags_url":"https://api.github.com/repos/node-nock/nock/tags","blobs_url":"https://api.github.com/repos/node-nock/nock/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/node-nock/nock/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/node-nock/nock/git/refs{/sha}","trees_url":"https://api.github.com/repos/node-nock/nock/git/trees{/sha}","statuses_url":"https://api.github.com/repos/node-nock/nock/statuses/{sha}","languages_url":"https://api.github.com/repos/node-nock/nock/languages","stargazers_url":"https://api.github.com/repos/node-nock/nock/stargazers","contributors_url":"https://api.github.com/repos/node-nock/nock/contributors","subscribers_url":"https://api.github.com/repos/node-nock/nock/subscribers","subscription_url":"https://api.github.com/repos/node-nock/nock/subscription","commits_url":"https://api.github.com/repos/node-nock/nock/commits{/sha}","git_commits_url":"https://api.github.com/repos/node-nock/nock/git/commits{/sha}","comments_url":"https://api.github.com/repos/node-nock/nock/comments{/number}","issue_comment_url":"https://api.github.com/repos/node-nock/nock/issues/comments{/number}","contents_url":"https://api.github.com/repos/node-nock/nock/contents/{+path}","compare_url":"https://api.github.com/repos/node-nock/nock/compare/{base}...{head}","merges_url":"https://api.github.com/repos/node-nock/nock/merges","archive_url":"https://api.github.com/repos/node-nock/nock/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/node-nock/nock/downloads","issues_url":"https://api.github.com/repos/node-nock/nock/issues{/number}","pulls_url":"https://api.github.com/repos/node-nock/nock/pulls{/number}","milestones_url":"https://api.github.com/repos/node-nock/nock/milestones{/number}","notifications_url":"https://api.github.com/repos/node-nock/nock/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/node-nock/nock/labels{/name}","releases_url":"https://api.github.com/repos/node-nock/nock/releases{/id}","deployments_url":"https://api.github.com/repos/node-nock/nock/deployments","created_at":"2011-09-22T10:08:03Z","updated_at":"2018-03-06T01:50:56Z","pushed_at":"2018-03-05T05:13:01Z","git_url":"git://github.com/node-nock/nock.git","ssh_url":"[email protected]:node-nock/nock.git","clone_url":"https://github.com/node-nock/nock.git","svn_url":"https://github.com/node-nock/nock","homepage":"","size":3162,"stargazers_count":5953,"watchers_count":5953,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":446,"mirror_url":null,"archived":false,"open_issues_count":155,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":446,"open_issues":155,"watchers":5953,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/node-nock/nock/pulls/1090"},"html":{"href":"https://github.com/node-nock/nock/pull/1090"},"issue":{"href":"https://api.github.com/repos/node-nock/nock/issues/1090"},"comments":{"href":"https://api.github.com/repos/node-nock/nock/issues/1090/comments"},"review_comments":{"href":"https://api.github.com/repos/node-nock/nock/pulls/1090/comments"},"review_comment":{"href":"https://api.github.com/repos/node-nock/nock/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/node-nock/nock/pulls/1090/commits"},"statuses":{"href":"https://api.github.com/repos/node-nock/nock/statuses/b9329ed2f09e9171df772f47c64e817e503b382a"}},"author_association":"CONTRIBUTOR"}} | {
"id": 2436267,
"name": "node-nock/nock",
"url": "https://api.github.com/repos/node-nock/nock"
} | {
"id": 8503331,
"login": "mbad0la",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/8503331?",
"url": "https://api.github.com/users/mbad0la"
} | {
"id": 17545810,
"login": "node-nock",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/17545810?",
"url": "https://api.github.com/orgs/node-nock"
} | 2018-03-06T04:51:29 | 7335567654 | {"actor":{"display_login":"mbad0la"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/indexexchange/pub-matic-adapter/pulls/comments/179604631","pull_request_review_id":109882319,"id":179604631,"diff_hunk":"@@ -141,20 +244,26 @@ function PubMaticHtb(configs) {\n */\n \n /* ---------------------- PUT CODE HERE ------------------------------------ */\n- var queryObj = {};\n- var callbackId = System.generateUniqueId();\n-\n- /* Change this to your bidder endpoint.*/\n- var baseUrl = Browser.getProtocol() + '//someAdapterEndpoint.com/bid';\n-\n- /* ---------------- Craft bid request using the above returnParcels --------- */\n-\n+ var payload = {},\n+ callbackId = System.generateUniqueId(),\n+ baseUrl = Browser.getProtocol() + '//hbopenbid.pubmatic.com/translator?source=index-client';\n+ payload = {\n+ id: '' + new Date().getTime(), // str | mandatory\n+ at: 1, // int | mandatory\n+ cur: ['USD'], // [str] | opt\n+ imp: __populateImprObject(returnParcels), // obj | mandatory - pending\n+ site: __populateSiteObject(returnParcels[0].pubId), //// obj | opt\n+ device: __populateDeviceInfo(returnParcels[0]), // obj | mandatory\n+ user: __populateUserInfo(returnParcels[0]), // obj | opt\n+ ext: __populateExtObject(returnParcels[0]), // not required?? - to be checked\n+ secure: Browser.getProtocol() === \"https:\" ? 1 : 0\n+ }\n \n /* -------------------------------------------------------------------------- */\n-\n+ console.log(JSON.stringify(payload));","path":"pub-matic-htb.js","position":142,"original_position":142,"commit_id":"e530994b77bac19b7c18cf105d70e0c70232ab0f","original_commit_id":"e530994b77bac19b7c18cf105d70e0c70232ab0f","user":{"login":"ix-certification","id":28928533,"avatar_url":"https://avatars2.githubusercontent.com/u/28928533?v=4","gravatar_id":"","url":"https://api.github.com/users/ix-certification","html_url":"https://github.com/ix-certification","followers_url":"https://api.github.com/users/ix-certification/followers","following_url":"https://api.github.com/users/ix-certification/following{/other_user}","gists_url":"https://api.github.com/users/ix-certification/gists{/gist_id}","starred_url":"https://api.github.com/users/ix-certification/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ix-certification/subscriptions","organizations_url":"https://api.github.com/users/ix-certification/orgs","repos_url":"https://api.github.com/users/ix-certification/repos","events_url":"https://api.github.com/users/ix-certification/events{/privacy}","received_events_url":"https://api.github.com/users/ix-certification/received_events","type":"User","site_admin":false},"body":"Please remove this console.log","created_at":"2018-04-05T21:21:33Z","updated_at":"2018-04-05T21:25:01Z","html_url":"https://github.com/indexexchange/pub-matic-adapter/pull/7#discussion_r179604631","pull_request_url":"https://api.github.com/repos/indexexchange/pub-matic-adapter/pulls/7","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/indexexchange/pub-matic-adapter/pulls/comments/179604631"},"html":{"href":"https://github.com/indexexchange/pub-matic-adapter/pull/7#discussion_r179604631"},"pull_request":{"href":"https://api.github.com/repos/indexexchange/pub-matic-adapter/pulls/7"}}},"pull_request":{"url":"https://api.github.com/repos/indexexchange/pub-matic-adapter/pulls/7","id":175649778,"html_url":"https://github.com/indexexchange/pub-matic-adapter/pull/7","diff_url":"https://github.com/indexexchange/pub-matic-adapter/pull/7.diff","patch_url":"https://github.com/indexexchange/pub-matic-adapter/pull/7.patch","issue_url":"https://api.github.com/repos/indexexchange/pub-matic-adapter/issues/7","number":7,"state":"open","locked":false,"title":"Squashed commit of the following (+ rebase):","user":{"login":"mike-chowla","id":13356910,"avatar_url":"https://avatars3.githubusercontent.com/u/13356910?v=4","gravatar_id":"","url":"https://api.github.com/users/mike-chowla","html_url":"https://github.com/mike-chowla","followers_url":"https://api.github.com/users/mike-chowla/followers","following_url":"https://api.github.com/users/mike-chowla/following{/other_user}","gists_url":"https://api.github.com/users/mike-chowla/gists{/gist_id}","starred_url":"https://api.github.com/users/mike-chowla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mike-chowla/subscriptions","organizations_url":"https://api.github.com/users/mike-chowla/orgs","repos_url":"https://api.github.com/users/mike-chowla/repos","events_url":"https://api.github.com/users/mike-chowla/events{/privacy}","received_events_url":"https://api.github.com/users/mike-chowla/received_events","type":"User","site_admin":false},"body":"commit c3b3b1caabc934860f7b93fd331e1237eed21da8\r\nAuthor: PubMatic-OpenWrap <[email protected]>\r\nDate: Mon Mar 12 11:57:07 2018 +0530\r\n\r\n changes according to code review comments\r\n\r\ncommit 33fe662a2187e4f23cbaf691713bac6ffe19f9c1\r\nAuthor: PubMatic-OpenWrap <[email protected]>\r\nDate: Mon Mar 12 11:40:28 2018 +0530\r\n\r\n adding dev dependency for mock-browser\r\n\r\ncommit f8740e2ee5b1ffafe6868a4212a260c7c13ea1ba\r\nAuthor: PubMatic-OpenWrap <[email protected]>\r\nDate: Thu Feb 15 18:02:03 2018 +0530\r\n\r\n Update README.md\r\n\r\ncommit 126a18ca93f35ea20071e50e11a9bbb70af18dc0\r\nAuthor: PubMatic-OpenWrap <[email protected]>\r\nDate: Wed Feb 14 13:52:37 2018 +0530\r\n\r\n changes to parseResponse method\r\n\r\ncommit f188c408792ed010a872d067ea3ddcd98bce3de9\r\nAuthor: PubMatic-OpenWrap <[email protected]>\r\nDate: Tue Feb 13 11:05:11 2018 +0530\r\n\r\n first version of code for pubmatic adapter\r\n\r\ncommit 8052dcf910b23ef70e777b56bd450d364cba613b\r\nAuthor: PubMatic-OpenWrap <[email protected]>\r\nDate: Mon Feb 12 15:45:23 2018 +0530\r\n\r\n adding mock response data\r\n\r\ncommit 713bf922cd44e6daff1692c5c5868d93e2133b03\r\nAuthor: PubMatic-OpenWrap <[email protected]>\r\nDate: Mon Feb 12 15:35:18 2018 +0530\r\n\r\n test commit\r\n\r\ncommit e5e0e692da8860f0200ea5d6aaccee1579939164\r\nAuthor: PubMatic-OpenWrap <[email protected]>\r\nDate: Mon Feb 12 14:51:31 2018 +0530\r\n\r\n Update README.md","created_at":"2018-03-16T21:25:30Z","updated_at":"2018-04-05T21:25:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9801e221098b9d05a4eee22a485818446ab567c3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/indexexchange/pub-matic-adapter/pulls/7/commits","review_comments_url":"https://api.github.com/repos/indexexchange/pub-matic-adapter/pulls/7/comments","review_comment_url":"https://api.github.com/repos/indexexchange/pub-matic-adapter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/indexexchange/pub-matic-adapter/issues/7/comments","statuses_url":"https://api.github.com/repos/indexexchange/pub-matic-adapter/statuses/e530994b77bac19b7c18cf105d70e0c70232ab0f","head":{"label":"mike-chowla:development-v2-rebased","ref":"development-v2-rebased","sha":"e530994b77bac19b7c18cf105d70e0c70232ab0f","user":{"login":"mike-chowla","id":13356910,"avatar_url":"https://avatars3.githubusercontent.com/u/13356910?v=4","gravatar_id":"","url":"https://api.github.com/users/mike-chowla","html_url":"https://github.com/mike-chowla","followers_url":"https://api.github.com/users/mike-chowla/followers","following_url":"https://api.github.com/users/mike-chowla/following{/other_user}","gists_url":"https://api.github.com/users/mike-chowla/gists{/gist_id}","starred_url":"https://api.github.com/users/mike-chowla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mike-chowla/subscriptions","organizations_url":"https://api.github.com/users/mike-chowla/orgs","repos_url":"https://api.github.com/users/mike-chowla/repos","events_url":"https://api.github.com/users/mike-chowla/events{/privacy}","received_events_url":"https://api.github.com/users/mike-chowla/received_events","type":"User","site_admin":false},"repo":{"id":125102599,"name":"pub-matic-adapter","full_name":"mike-chowla/pub-matic-adapter","owner":{"login":"mike-chowla","id":13356910,"avatar_url":"https://avatars3.githubusercontent.com/u/13356910?v=4","gravatar_id":"","url":"https://api.github.com/users/mike-chowla","html_url":"https://github.com/mike-chowla","followers_url":"https://api.github.com/users/mike-chowla/followers","following_url":"https://api.github.com/users/mike-chowla/following{/other_user}","gists_url":"https://api.github.com/users/mike-chowla/gists{/gist_id}","starred_url":"https://api.github.com/users/mike-chowla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mike-chowla/subscriptions","organizations_url":"https://api.github.com/users/mike-chowla/orgs","repos_url":"https://api.github.com/users/mike-chowla/repos","events_url":"https://api.github.com/users/mike-chowla/events{/privacy}","received_events_url":"https://api.github.com/users/mike-chowla/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mike-chowla/pub-matic-adapter","description":null,"fork":true,"url":"https://api.github.com/repos/mike-chowla/pub-matic-adapter","forks_url":"https://api.github.com/repos/mike-chowla/pub-matic-adapter/forks","keys_url":"https://api.github.com/repos/mike-chowla/pub-matic-adapter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mike-chowla/pub-matic-adapter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mike-chowla/pub-matic-adapter/teams","hooks_url":"https://api.github.com/repos/mike-chowla/pub-matic-adapter/hooks","issue_events_url":"https://api.github.com/repos/mike-chowla/pub-matic-adapter/issues/events{/number}","events_url":"https://api.github.com/repos/mike-chowla/pub-matic-adapter/events","assignees_url":"https://api.github.com/repos/mike-chowla/pub-matic-adapter/assignees{/user}","branches_url":"https://api.github.com/repos/mike-chowla/pub-matic-adapter/branches{/branch}","tags_url":"https://api.github.com/repos/mike-chowla/pub-matic-adapter/tags","blobs_url":"https://api.github.com/repos/mike-chowla/pub-matic-adapter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mike-chowla/pub-matic-adapter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mike-chowla/pub-matic-adapter/git/refs{/sha}","trees_url":"https://api.github.com/repos/mike-chowla/pub-matic-adapter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mike-chowla/pub-matic-adapter/statuses/{sha}","languages_url":"https://api.github.com/repos/mike-chowla/pub-matic-adapter/languages","stargazers_url":"https://api.github.com/repos/mike-chowla/pub-matic-adapter/stargazers","contributors_url":"https://api.github.com/repos/mike-chowla/pub-matic-adapter/contributors","subscribers_url":"https://api.github.com/repos/mike-chowla/pub-matic-adapter/subscribers","subscription_url":"https://api.github.com/repos/mike-chowla/pub-matic-adapter/subscription","commits_url":"https://api.github.com/repos/mike-chowla/pub-matic-adapter/commits{/sha}","git_commits_url":"https://api.github.com/repos/mike-chowla/pub-matic-adapter/git/commits{/sha}","comments_url":"https://api.github.com/repos/mike-chowla/pub-matic-adapter/comments{/number}","issue_comment_url":"https://api.github.com/repos/mike-chowla/pub-matic-adapter/issues/comments{/number}","contents_url":"https://api.github.com/repos/mike-chowla/pub-matic-adapter/contents/{+path}","compare_url":"https://api.github.com/repos/mike-chowla/pub-matic-adapter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mike-chowla/pub-matic-adapter/merges","archive_url":"https://api.github.com/repos/mike-chowla/pub-matic-adapter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mike-chowla/pub-matic-adapter/downloads","issues_url":"https://api.github.com/repos/mike-chowla/pub-matic-adapter/issues{/number}","pulls_url":"https://api.github.com/repos/mike-chowla/pub-matic-adapter/pulls{/number}","milestones_url":"https://api.github.com/repos/mike-chowla/pub-matic-adapter/milestones{/number}","notifications_url":"https://api.github.com/repos/mike-chowla/pub-matic-adapter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mike-chowla/pub-matic-adapter/labels{/name}","releases_url":"https://api.github.com/repos/mike-chowla/pub-matic-adapter/releases{/id}","deployments_url":"https://api.github.com/repos/mike-chowla/pub-matic-adapter/deployments","created_at":"2018-03-13T19:17:43Z","updated_at":"2018-03-20T21:50:18Z","pushed_at":"2018-03-30T05:54:33Z","git_url":"git://github.com/mike-chowla/pub-matic-adapter.git","ssh_url":"[email protected]:mike-chowla/pub-matic-adapter.git","clone_url":"https://github.com/mike-chowla/pub-matic-adapter.git","svn_url":"https://github.com/mike-chowla/pub-matic-adapter","homepage":null,"size":89,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master-v2"}},"base":{"label":"indexexchange:master-v2","ref":"master-v2","sha":"fc932f879fe81e081e7b6db624064b82b9aac864","user":{"login":"indexexchange","id":17625003,"avatar_url":"https://avatars1.githubusercontent.com/u/17625003?v=4","gravatar_id":"","url":"https://api.github.com/users/indexexchange","html_url":"https://github.com/indexexchange","followers_url":"https://api.github.com/users/indexexchange/followers","following_url":"https://api.github.com/users/indexexchange/following{/other_user}","gists_url":"https://api.github.com/users/indexexchange/gists{/gist_id}","starred_url":"https://api.github.com/users/indexexchange/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/indexexchange/subscriptions","organizations_url":"https://api.github.com/users/indexexchange/orgs","repos_url":"https://api.github.com/users/indexexchange/repos","events_url":"https://api.github.com/users/indexexchange/events{/privacy}","received_events_url":"https://api.github.com/users/indexexchange/received_events","type":"Organization","site_admin":false},"repo":{"id":106612769,"name":"pub-matic-adapter","full_name":"indexexchange/pub-matic-adapter","owner":{"login":"indexexchange","id":17625003,"avatar_url":"https://avatars1.githubusercontent.com/u/17625003?v=4","gravatar_id":"","url":"https://api.github.com/users/indexexchange","html_url":"https://github.com/indexexchange","followers_url":"https://api.github.com/users/indexexchange/followers","following_url":"https://api.github.com/users/indexexchange/following{/other_user}","gists_url":"https://api.github.com/users/indexexchange/gists{/gist_id}","starred_url":"https://api.github.com/users/indexexchange/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/indexexchange/subscriptions","organizations_url":"https://api.github.com/users/indexexchange/orgs","repos_url":"https://api.github.com/users/indexexchange/repos","events_url":"https://api.github.com/users/indexexchange/events{/privacy}","received_events_url":"https://api.github.com/users/indexexchange/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/indexexchange/pub-matic-adapter","description":null,"fork":false,"url":"https://api.github.com/repos/indexexchange/pub-matic-adapter","forks_url":"https://api.github.com/repos/indexexchange/pub-matic-adapter/forks","keys_url":"https://api.github.com/repos/indexexchange/pub-matic-adapter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/indexexchange/pub-matic-adapter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/indexexchange/pub-matic-adapter/teams","hooks_url":"https://api.github.com/repos/indexexchange/pub-matic-adapter/hooks","issue_events_url":"https://api.github.com/repos/indexexchange/pub-matic-adapter/issues/events{/number}","events_url":"https://api.github.com/repos/indexexchange/pub-matic-adapter/events","assignees_url":"https://api.github.com/repos/indexexchange/pub-matic-adapter/assignees{/user}","branches_url":"https://api.github.com/repos/indexexchange/pub-matic-adapter/branches{/branch}","tags_url":"https://api.github.com/repos/indexexchange/pub-matic-adapter/tags","blobs_url":"https://api.github.com/repos/indexexchange/pub-matic-adapter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/indexexchange/pub-matic-adapter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/indexexchange/pub-matic-adapter/git/refs{/sha}","trees_url":"https://api.github.com/repos/indexexchange/pub-matic-adapter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/indexexchange/pub-matic-adapter/statuses/{sha}","languages_url":"https://api.github.com/repos/indexexchange/pub-matic-adapter/languages","stargazers_url":"https://api.github.com/repos/indexexchange/pub-matic-adapter/stargazers","contributors_url":"https://api.github.com/repos/indexexchange/pub-matic-adapter/contributors","subscribers_url":"https://api.github.com/repos/indexexchange/pub-matic-adapter/subscribers","subscription_url":"https://api.github.com/repos/indexexchange/pub-matic-adapter/subscription","commits_url":"https://api.github.com/repos/indexexchange/pub-matic-adapter/commits{/sha}","git_commits_url":"https://api.github.com/repos/indexexchange/pub-matic-adapter/git/commits{/sha}","comments_url":"https://api.github.com/repos/indexexchange/pub-matic-adapter/comments{/number}","issue_comment_url":"https://api.github.com/repos/indexexchange/pub-matic-adapter/issues/comments{/number}","contents_url":"https://api.github.com/repos/indexexchange/pub-matic-adapter/contents/{+path}","compare_url":"https://api.github.com/repos/indexexchange/pub-matic-adapter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/indexexchange/pub-matic-adapter/merges","archive_url":"https://api.github.com/repos/indexexchange/pub-matic-adapter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/indexexchange/pub-matic-adapter/downloads","issues_url":"https://api.github.com/repos/indexexchange/pub-matic-adapter/issues{/number}","pulls_url":"https://api.github.com/repos/indexexchange/pub-matic-adapter/pulls{/number}","milestones_url":"https://api.github.com/repos/indexexchange/pub-matic-adapter/milestones{/number}","notifications_url":"https://api.github.com/repos/indexexchange/pub-matic-adapter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/indexexchange/pub-matic-adapter/labels{/name}","releases_url":"https://api.github.com/repos/indexexchange/pub-matic-adapter/releases{/id}","deployments_url":"https://api.github.com/repos/indexexchange/pub-matic-adapter/deployments","created_at":"2017-10-11T21:44:41Z","updated_at":"2018-03-14T21:38:40Z","pushed_at":"2018-03-30T05:54:35Z","git_url":"git://github.com/indexexchange/pub-matic-adapter.git","ssh_url":"[email protected]:indexexchange/pub-matic-adapter.git","clone_url":"https://github.com/indexexchange/pub-matic-adapter.git","svn_url":"https://github.com/indexexchange/pub-matic-adapter","homepage":null,"size":71,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":3,"open_issues":1,"watchers":0,"default_branch":"master-v2"}},"_links":{"self":{"href":"https://api.github.com/repos/indexexchange/pub-matic-adapter/pulls/7"},"html":{"href":"https://github.com/indexexchange/pub-matic-adapter/pull/7"},"issue":{"href":"https://api.github.com/repos/indexexchange/pub-matic-adapter/issues/7"},"comments":{"href":"https://api.github.com/repos/indexexchange/pub-matic-adapter/issues/7/comments"},"review_comments":{"href":"https://api.github.com/repos/indexexchange/pub-matic-adapter/pulls/7/comments"},"review_comment":{"href":"https://api.github.com/repos/indexexchange/pub-matic-adapter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/indexexchange/pub-matic-adapter/pulls/7/commits"},"statuses":{"href":"https://api.github.com/repos/indexexchange/pub-matic-adapter/statuses/e530994b77bac19b7c18cf105d70e0c70232ab0f"}},"author_association":"COLLABORATOR"}} | {
"id": 106612769,
"name": "indexexchange/pub-matic-adapter",
"url": "https://api.github.com/repos/indexexchange/pub-matic-adapter"
} | {
"id": 28928533,
"login": "ix-certification",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/28928533?",
"url": "https://api.github.com/users/ix-certification"
} | {
"id": 17625003,
"login": "indexexchange",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/17625003?",
"url": "https://api.github.com/orgs/indexexchange"
} | 2018-04-05T21:21:33 | 7487708053 | {"actor":{"display_login":"ix-certification"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/compiz-reloaded/compiz-plugins-experimental/pulls/comments/198592480","pull_request_review_id":132549638,"id":198592480,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5ODU5MjQ4MA==","diff_hunk":"@@ -546,7 +549,14 @@ earthPreparePaintScreen (CompScreen *s,\n \tes->gha = (float)currenttime->tm_hour-(es->tz +\n \t\t\t\t(float)currenttime->tm_isdst) +\n \t\t\t\t(float)currenttime->tm_min / 60.0f;\n-\n+\t\t\t\t(float)currenttime->tm_sec/3600.0000f;\n+\t\n+\t/* Animation */\n+\tes->rotation += es->rotspeed;\n+\tif (es->rotation > 360)\n+\tes->rotation -= 360;","path":"src/earth/earth.c","position":20,"original_position":20,"commit_id":"f96050172ed2e09ce3a56d65052e934fc8a24136","original_commit_id":"f96050172ed2e09ce3a56d65052e934fc8a24136","user":{"login":"soreau","id":1450125,"node_id":"MDQ6VXNlcjE0NTAxMjU=","avatar_url":"https://avatars1.githubusercontent.com/u/1450125?v=4","gravatar_id":"","url":"https://api.github.com/users/soreau","html_url":"https://github.com/soreau","followers_url":"https://api.github.com/users/soreau/followers","following_url":"https://api.github.com/users/soreau/following{/other_user}","gists_url":"https://api.github.com/users/soreau/gists{/gist_id}","starred_url":"https://api.github.com/users/soreau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soreau/subscriptions","organizations_url":"https://api.github.com/users/soreau/orgs","repos_url":"https://api.github.com/users/soreau/repos","events_url":"https://api.github.com/users/soreau/events{/privacy}","received_events_url":"https://api.github.com/users/soreau/received_events","type":"User","site_admin":false},"body":"there should be an indent after if conditional like this:\r\n```\r\nif (es->rotation > 360)\r\n\tes->rotation -= 360;\r\n```","created_at":"2018-06-27T18:13:58Z","updated_at":"2018-06-27T18:13:58Z","html_url":"https://github.com/compiz-reloaded/compiz-plugins-experimental/pull/55#discussion_r198592480","pull_request_url":"https://api.github.com/repos/compiz-reloaded/compiz-plugins-experimental/pulls/55","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/compiz-reloaded/compiz-plugins-experimental/pulls/comments/198592480"},"html":{"href":"https://github.com/compiz-reloaded/compiz-plugins-experimental/pull/55#discussion_r198592480"},"pull_request":{"href":"https://api.github.com/repos/compiz-reloaded/compiz-plugins-experimental/pulls/55"}}},"pull_request":{"url":"https://api.github.com/repos/compiz-reloaded/compiz-plugins-experimental/pulls/55","id":197568005,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3NTY4MDA1","html_url":"https://github.com/compiz-reloaded/compiz-plugins-experimental/pull/55","diff_url":"https://github.com/compiz-reloaded/compiz-plugins-experimental/pull/55.diff","patch_url":"https://github.com/compiz-reloaded/compiz-plugins-experimental/pull/55.patch","issue_url":"https://api.github.com/repos/compiz-reloaded/compiz-plugins-experimental/issues/55","number":55,"state":"open","locked":false,"title":"Rotation","user":{"login":"Eignar17","id":8561550,"node_id":"MDQ6VXNlcjg1NjE1NTA=","avatar_url":"https://avatars2.githubusercontent.com/u/8561550?v=4","gravatar_id":"","url":"https://api.github.com/users/Eignar17","html_url":"https://github.com/Eignar17","followers_url":"https://api.github.com/users/Eignar17/followers","following_url":"https://api.github.com/users/Eignar17/following{/other_user}","gists_url":"https://api.github.com/users/Eignar17/gists{/gist_id}","starred_url":"https://api.github.com/users/Eignar17/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Eignar17/subscriptions","organizations_url":"https://api.github.com/users/Eignar17/orgs","repos_url":"https://api.github.com/users/Eignar17/repos","events_url":"https://api.github.com/users/Eignar17/events{/privacy}","received_events_url":"https://api.github.com/users/Eignar17/received_events","type":"User","site_admin":false},"body":"to http://cgit.compiz.org/~satamaxx/earth/commit/?id=b0cf3ab7452848569e5002b9df1266e85f51a995\r\nauthor\tMaxime Wack [email protected]\r\n\r\n","created_at":"2018-06-26T22:22:00Z","updated_at":"2018-06-27T18:13:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9813ec13ec11c0930642225fd944aa93b4f873b6","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/compiz-reloaded/compiz-plugins-experimental/pulls/55/commits","review_comments_url":"https://api.github.com/repos/compiz-reloaded/compiz-plugins-experimental/pulls/55/comments","review_comment_url":"https://api.github.com/repos/compiz-reloaded/compiz-plugins-experimental/pulls/comments{/number}","comments_url":"https://api.github.com/repos/compiz-reloaded/compiz-plugins-experimental/issues/55/comments","statuses_url":"https://api.github.com/repos/compiz-reloaded/compiz-plugins-experimental/statuses/f96050172ed2e09ce3a56d65052e934fc8a24136","head":{"label":"Eignar17:Rotation","ref":"Rotation","sha":"f96050172ed2e09ce3a56d65052e934fc8a24136","user":{"login":"Eignar17","id":8561550,"node_id":"MDQ6VXNlcjg1NjE1NTA=","avatar_url":"https://avatars2.githubusercontent.com/u/8561550?v=4","gravatar_id":"","url":"https://api.github.com/users/Eignar17","html_url":"https://github.com/Eignar17","followers_url":"https://api.github.com/users/Eignar17/followers","following_url":"https://api.github.com/users/Eignar17/following{/other_user}","gists_url":"https://api.github.com/users/Eignar17/gists{/gist_id}","starred_url":"https://api.github.com/users/Eignar17/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Eignar17/subscriptions","organizations_url":"https://api.github.com/users/Eignar17/orgs","repos_url":"https://api.github.com/users/Eignar17/repos","events_url":"https://api.github.com/users/Eignar17/events{/privacy}","received_events_url":"https://api.github.com/users/Eignar17/received_events","type":"User","site_admin":false},"repo":{"id":131927376,"node_id":"MDEwOlJlcG9zaXRvcnkxMzE5MjczNzY=","name":"compiz-plugins-experimental","full_name":"Eignar17/compiz-plugins-experimental","owner":{"login":"Eignar17","id":8561550,"node_id":"MDQ6VXNlcjg1NjE1NTA=","avatar_url":"https://avatars2.githubusercontent.com/u/8561550?v=4","gravatar_id":"","url":"https://api.github.com/users/Eignar17","html_url":"https://github.com/Eignar17","followers_url":"https://api.github.com/users/Eignar17/followers","following_url":"https://api.github.com/users/Eignar17/following{/other_user}","gists_url":"https://api.github.com/users/Eignar17/gists{/gist_id}","starred_url":"https://api.github.com/users/Eignar17/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Eignar17/subscriptions","organizations_url":"https://api.github.com/users/Eignar17/orgs","repos_url":"https://api.github.com/users/Eignar17/repos","events_url":"https://api.github.com/users/Eignar17/events{/privacy}","received_events_url":"https://api.github.com/users/Eignar17/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Eignar17/compiz-plugins-experimental","description":"compiz-plugins-experimental 0.8.x project","fork":true,"url":"https://api.github.com/repos/Eignar17/compiz-plugins-experimental","forks_url":"https://api.github.com/repos/Eignar17/compiz-plugins-experimental/forks","keys_url":"https://api.github.com/repos/Eignar17/compiz-plugins-experimental/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Eignar17/compiz-plugins-experimental/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Eignar17/compiz-plugins-experimental/teams","hooks_url":"https://api.github.com/repos/Eignar17/compiz-plugins-experimental/hooks","issue_events_url":"https://api.github.com/repos/Eignar17/compiz-plugins-experimental/issues/events{/number}","events_url":"https://api.github.com/repos/Eignar17/compiz-plugins-experimental/events","assignees_url":"https://api.github.com/repos/Eignar17/compiz-plugins-experimental/assignees{/user}","branches_url":"https://api.github.com/repos/Eignar17/compiz-plugins-experimental/branches{/branch}","tags_url":"https://api.github.com/repos/Eignar17/compiz-plugins-experimental/tags","blobs_url":"https://api.github.com/repos/Eignar17/compiz-plugins-experimental/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Eignar17/compiz-plugins-experimental/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Eignar17/compiz-plugins-experimental/git/refs{/sha}","trees_url":"https://api.github.com/repos/Eignar17/compiz-plugins-experimental/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Eignar17/compiz-plugins-experimental/statuses/{sha}","languages_url":"https://api.github.com/repos/Eignar17/compiz-plugins-experimental/languages","stargazers_url":"https://api.github.com/repos/Eignar17/compiz-plugins-experimental/stargazers","contributors_url":"https://api.github.com/repos/Eignar17/compiz-plugins-experimental/contributors","subscribers_url":"https://api.github.com/repos/Eignar17/compiz-plugins-experimental/subscribers","subscription_url":"https://api.github.com/repos/Eignar17/compiz-plugins-experimental/subscription","commits_url":"https://api.github.com/repos/Eignar17/compiz-plugins-experimental/commits{/sha}","git_commits_url":"https://api.github.com/repos/Eignar17/compiz-plugins-experimental/git/commits{/sha}","comments_url":"https://api.github.com/repos/Eignar17/compiz-plugins-experimental/comments{/number}","issue_comment_url":"https://api.github.com/repos/Eignar17/compiz-plugins-experimental/issues/comments{/number}","contents_url":"https://api.github.com/repos/Eignar17/compiz-plugins-experimental/contents/{+path}","compare_url":"https://api.github.com/repos/Eignar17/compiz-plugins-experimental/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Eignar17/compiz-plugins-experimental/merges","archive_url":"https://api.github.com/repos/Eignar17/compiz-plugins-experimental/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Eignar17/compiz-plugins-experimental/downloads","issues_url":"https://api.github.com/repos/Eignar17/compiz-plugins-experimental/issues{/number}","pulls_url":"https://api.github.com/repos/Eignar17/compiz-plugins-experimental/pulls{/number}","milestones_url":"https://api.github.com/repos/Eignar17/compiz-plugins-experimental/milestones{/number}","notifications_url":"https://api.github.com/repos/Eignar17/compiz-plugins-experimental/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Eignar17/compiz-plugins-experimental/labels{/name}","releases_url":"https://api.github.com/repos/Eignar17/compiz-plugins-experimental/releases{/id}","deployments_url":"https://api.github.com/repos/Eignar17/compiz-plugins-experimental/deployments","created_at":"2018-05-03T01:53:51Z","updated_at":"2018-06-22T21:20:58Z","pushed_at":"2018-06-26T22:21:07Z","git_url":"git://github.com/Eignar17/compiz-plugins-experimental.git","ssh_url":"[email protected]:Eignar17/compiz-plugins-experimental.git","clone_url":"https://github.com/Eignar17/compiz-plugins-experimental.git","svn_url":"https://github.com/Eignar17/compiz-plugins-experimental","homepage":"","size":19879,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"compiz-reloaded:master","ref":"master","sha":"a8866887039adfa76a929eb4d096d816f2265385","user":{"login":"compiz-reloaded","id":17723096,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NzIzMDk2","avatar_url":"https://avatars0.githubusercontent.com/u/17723096?v=4","gravatar_id":"","url":"https://api.github.com/users/compiz-reloaded","html_url":"https://github.com/compiz-reloaded","followers_url":"https://api.github.com/users/compiz-reloaded/followers","following_url":"https://api.github.com/users/compiz-reloaded/following{/other_user}","gists_url":"https://api.github.com/users/compiz-reloaded/gists{/gist_id}","starred_url":"https://api.github.com/users/compiz-reloaded/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/compiz-reloaded/subscriptions","organizations_url":"https://api.github.com/users/compiz-reloaded/orgs","repos_url":"https://api.github.com/users/compiz-reloaded/repos","events_url":"https://api.github.com/users/compiz-reloaded/events{/privacy}","received_events_url":"https://api.github.com/users/compiz-reloaded/received_events","type":"Organization","site_admin":false},"repo":{"id":49286835,"node_id":"MDEwOlJlcG9zaXRvcnk0OTI4NjgzNQ==","name":"compiz-plugins-experimental","full_name":"compiz-reloaded/compiz-plugins-experimental","owner":{"login":"compiz-reloaded","id":17723096,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NzIzMDk2","avatar_url":"https://avatars0.githubusercontent.com/u/17723096?v=4","gravatar_id":"","url":"https://api.github.com/users/compiz-reloaded","html_url":"https://github.com/compiz-reloaded","followers_url":"https://api.github.com/users/compiz-reloaded/followers","following_url":"https://api.github.com/users/compiz-reloaded/following{/other_user}","gists_url":"https://api.github.com/users/compiz-reloaded/gists{/gist_id}","starred_url":"https://api.github.com/users/compiz-reloaded/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/compiz-reloaded/subscriptions","organizations_url":"https://api.github.com/users/compiz-reloaded/orgs","repos_url":"https://api.github.com/users/compiz-reloaded/repos","events_url":"https://api.github.com/users/compiz-reloaded/events{/privacy}","received_events_url":"https://api.github.com/users/compiz-reloaded/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/compiz-reloaded/compiz-plugins-experimental","description":"Mirrored from https://gitlab.com/compiz/compiz-plugins-experimental.git","fork":false,"url":"https://api.github.com/repos/compiz-reloaded/compiz-plugins-experimental","forks_url":"https://api.github.com/repos/compiz-reloaded/compiz-plugins-experimental/forks","keys_url":"https://api.github.com/repos/compiz-reloaded/compiz-plugins-experimental/keys{/key_id}","collaborators_url":"https://api.github.com/repos/compiz-reloaded/compiz-plugins-experimental/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/compiz-reloaded/compiz-plugins-experimental/teams","hooks_url":"https://api.github.com/repos/compiz-reloaded/compiz-plugins-experimental/hooks","issue_events_url":"https://api.github.com/repos/compiz-reloaded/compiz-plugins-experimental/issues/events{/number}","events_url":"https://api.github.com/repos/compiz-reloaded/compiz-plugins-experimental/events","assignees_url":"https://api.github.com/repos/compiz-reloaded/compiz-plugins-experimental/assignees{/user}","branches_url":"https://api.github.com/repos/compiz-reloaded/compiz-plugins-experimental/branches{/branch}","tags_url":"https://api.github.com/repos/compiz-reloaded/compiz-plugins-experimental/tags","blobs_url":"https://api.github.com/repos/compiz-reloaded/compiz-plugins-experimental/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/compiz-reloaded/compiz-plugins-experimental/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/compiz-reloaded/compiz-plugins-experimental/git/refs{/sha}","trees_url":"https://api.github.com/repos/compiz-reloaded/compiz-plugins-experimental/git/trees{/sha}","statuses_url":"https://api.github.com/repos/compiz-reloaded/compiz-plugins-experimental/statuses/{sha}","languages_url":"https://api.github.com/repos/compiz-reloaded/compiz-plugins-experimental/languages","stargazers_url":"https://api.github.com/repos/compiz-reloaded/compiz-plugins-experimental/stargazers","contributors_url":"https://api.github.com/repos/compiz-reloaded/compiz-plugins-experimental/contributors","subscribers_url":"https://api.github.com/repos/compiz-reloaded/compiz-plugins-experimental/subscribers","subscription_url":"https://api.github.com/repos/compiz-reloaded/compiz-plugins-experimental/subscription","commits_url":"https://api.github.com/repos/compiz-reloaded/compiz-plugins-experimental/commits{/sha}","git_commits_url":"https://api.github.com/repos/compiz-reloaded/compiz-plugins-experimental/git/commits{/sha}","comments_url":"https://api.github.com/repos/compiz-reloaded/compiz-plugins-experimental/comments{/number}","issue_comment_url":"https://api.github.com/repos/compiz-reloaded/compiz-plugins-experimental/issues/comments{/number}","contents_url":"https://api.github.com/repos/compiz-reloaded/compiz-plugins-experimental/contents/{+path}","compare_url":"https://api.github.com/repos/compiz-reloaded/compiz-plugins-experimental/compare/{base}...{head}","merges_url":"https://api.github.com/repos/compiz-reloaded/compiz-plugins-experimental/merges","archive_url":"https://api.github.com/repos/compiz-reloaded/compiz-plugins-experimental/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/compiz-reloaded/compiz-plugins-experimental/downloads","issues_url":"https://api.github.com/repos/compiz-reloaded/compiz-plugins-experimental/issues{/number}","pulls_url":"https://api.github.com/repos/compiz-reloaded/compiz-plugins-experimental/pulls{/number}","milestones_url":"https://api.github.com/repos/compiz-reloaded/compiz-plugins-experimental/milestones{/number}","notifications_url":"https://api.github.com/repos/compiz-reloaded/compiz-plugins-experimental/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/compiz-reloaded/compiz-plugins-experimental/labels{/name}","releases_url":"https://api.github.com/repos/compiz-reloaded/compiz-plugins-experimental/releases{/id}","deployments_url":"https://api.github.com/repos/compiz-reloaded/compiz-plugins-experimental/deployments","created_at":"2016-01-08T17:40:02Z","updated_at":"2018-06-23T06:38:21Z","pushed_at":"2018-06-26T22:21:59Z","git_url":"git://github.com/compiz-reloaded/compiz-plugins-experimental.git","ssh_url":"[email protected]:compiz-reloaded/compiz-plugins-experimental.git","clone_url":"https://github.com/compiz-reloaded/compiz-plugins-experimental.git","svn_url":"https://github.com/compiz-reloaded/compiz-plugins-experimental","homepage":"","size":19791,"stargazers_count":7,"watchers_count":7,"language":"C","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":8,"open_issues":6,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/compiz-reloaded/compiz-plugins-experimental/pulls/55"},"html":{"href":"https://github.com/compiz-reloaded/compiz-plugins-experimental/pull/55"},"issue":{"href":"https://api.github.com/repos/compiz-reloaded/compiz-plugins-experimental/issues/55"},"comments":{"href":"https://api.github.com/repos/compiz-reloaded/compiz-plugins-experimental/issues/55/comments"},"review_comments":{"href":"https://api.github.com/repos/compiz-reloaded/compiz-plugins-experimental/pulls/55/comments"},"review_comment":{"href":"https://api.github.com/repos/compiz-reloaded/compiz-plugins-experimental/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/compiz-reloaded/compiz-plugins-experimental/pulls/55/commits"},"statuses":{"href":"https://api.github.com/repos/compiz-reloaded/compiz-plugins-experimental/statuses/f96050172ed2e09ce3a56d65052e934fc8a24136"}},"author_association":"CONTRIBUTOR"}} | {
"id": 49286835,
"name": "compiz-reloaded/compiz-plugins-experimental",
"url": "https://api.github.com/repos/compiz-reloaded/compiz-plugins-experimental"
} | {
"id": 1450125,
"login": "soreau",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1450125?",
"url": "https://api.github.com/users/soreau"
} | {
"id": 17723096,
"login": "compiz-reloaded",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/17723096?",
"url": "https://api.github.com/orgs/compiz-reloaded"
} | 2018-06-27T18:13:58 | 7887364818 | {"actor":{"display_login":"soreau"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/resin-io-modules/resin-procbots/pulls/comments/165360725","pull_request_review_id":93285571,"id":165360725,"diff_hunk":"@@ -1,10 +1,48 @@\n /// <reference types=\"mocha\" />\n import { expect } from 'chai';\n \n+import * as readFile from 'fs-readfile-promise';","path":"tests/services/messenger/translators/front.spec.ts","position":4,"original_position":4,"commit_id":"1295a82f934063d8932319be8f812fc49a525eb0","original_commit_id":"1295a82f934063d8932319be8f812fc49a525eb0","user":{"login":"hedss","id":8259026,"avatar_url":"https://avatars0.githubusercontent.com/u/8259026?v=4","gravatar_id":"","url":"https://api.github.com/users/hedss","html_url":"https://github.com/hedss","followers_url":"https://api.github.com/users/hedss/followers","following_url":"https://api.github.com/users/hedss/following{/other_user}","gists_url":"https://api.github.com/users/hedss/gists{/gist_id}","starred_url":"https://api.github.com/users/hedss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hedss/subscriptions","organizations_url":"https://api.github.com/users/hedss/orgs","repos_url":"https://api.github.com/users/hedss/repos","events_url":"https://api.github.com/users/hedss/events{/privacy}","received_events_url":"https://api.github.com/users/hedss/received_events","type":"User","site_admin":false},"body":"If you're just using it for reading a file:\r\n```\r\nimport * as FS from 'fs';\r\nconst readFile = Promise.promisify(FS.readFile);\r\n```\r\nI'm all in favour of utilities, but this seems extremely heavy for just reading a file when an extra line will get you exactly the same results.\r\n\r\nMaybe we should be including a utility service for general FS access.","created_at":"2018-02-01T13:52:57Z","updated_at":"2018-02-01T13:53:55Z","html_url":"https://github.com/resin-io-modules/resin-procbots/pull/387#discussion_r165360725","pull_request_url":"https://api.github.com/repos/resin-io-modules/resin-procbots/pulls/387","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/resin-io-modules/resin-procbots/pulls/comments/165360725"},"html":{"href":"https://github.com/resin-io-modules/resin-procbots/pull/387#discussion_r165360725"},"pull_request":{"href":"https://api.github.com/repos/resin-io-modules/resin-procbots/pulls/387"}}},"pull_request":{"url":"https://api.github.com/repos/resin-io-modules/resin-procbots/pulls/387","id":165410535,"html_url":"https://github.com/resin-io-modules/resin-procbots/pull/387","diff_url":"https://github.com/resin-io-modules/resin-procbots/pull/387.diff","patch_url":"https://github.com/resin-io-modules/resin-procbots/pull/387.patch","issue_url":"https://api.github.com/repos/resin-io-modules/resin-procbots/issues/387","number":387,"state":"open","locked":false,"title":"SyncBot: Improve resilience of Front linked thread searching","user":{"login":"sqweelygig","id":20857369,"avatar_url":"https://avatars0.githubusercontent.com/u/20857369?v=4","gravatar_id":"","url":"https://api.github.com/users/sqweelygig","html_url":"https://github.com/sqweelygig","followers_url":"https://api.github.com/users/sqweelygig/followers","following_url":"https://api.github.com/users/sqweelygig/following{/other_user}","gists_url":"https://api.github.com/users/sqweelygig/gists{/gist_id}","starred_url":"https://api.github.com/users/sqweelygig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sqweelygig/subscriptions","organizations_url":"https://api.github.com/users/sqweelygig/orgs","repos_url":"https://api.github.com/users/sqweelygig/repos","events_url":"https://api.github.com/users/sqweelygig/events{/privacy}","received_events_url":"https://api.github.com/users/sqweelygig/received_events","type":"User","site_admin":false},"body":"* Increase the uniqueness of each `duff` string\r\n* Fixed a comment I happened to notice was wrong\r\n* Added error messages for Flowdock 5xx errors\r\n\r\nThis is because increasing the error output revealed that SyncBot is attempting to post messages to a duff thread id on Flowdock\r\n\r\nChange-Type: patch\r\nConnects-To: #367 \r\n\r\n---\r\n##### Contributor checklist\r\n<!-- For completed items, change [ ] to [x]. -->\r\n- [x] Build output been rebuilt and tested\r\n- [ ] Introduces security considerations\r\n- [x] Tests are included\r\n- [ ] Documentation is added or changed\r\n- [ ] Affects the development, build or deployment processes of the component\r\n\r\n##### Reviewer Guidelines\r\n- When submitting a review, please pick:\r\n - '*Approve*' if this change would be acceptable in the codebase (even if there are minor or cosmetic tweaks that could be improved).\r\n - '*Request Changes*' if this change would not be acceptable in our codebase (e.g. bugs, changes that will make development harder in future, security/performance issues, etc).\r\n - '*Comment*' if you don't feel you have enough information to decide either way (e.g. if you have major questions, or you don't understand the context of the change sufficiently to fully review yourself, but want to make a comment)\r\n---\r\n---- Autogenerated Waffleboard Connection: Connects to #367","created_at":"2018-01-26T16:52:27Z","updated_at":"2018-02-01T13:53:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e89df962a8ce258abaaf71582773cedf2752e21b","assignee":{"login":"sqweelygig","id":20857369,"avatar_url":"https://avatars0.githubusercontent.com/u/20857369?v=4","gravatar_id":"","url":"https://api.github.com/users/sqweelygig","html_url":"https://github.com/sqweelygig","followers_url":"https://api.github.com/users/sqweelygig/followers","following_url":"https://api.github.com/users/sqweelygig/following{/other_user}","gists_url":"https://api.github.com/users/sqweelygig/gists{/gist_id}","starred_url":"https://api.github.com/users/sqweelygig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sqweelygig/subscriptions","organizations_url":"https://api.github.com/users/sqweelygig/orgs","repos_url":"https://api.github.com/users/sqweelygig/repos","events_url":"https://api.github.com/users/sqweelygig/events{/privacy}","received_events_url":"https://api.github.com/users/sqweelygig/received_events","type":"User","site_admin":false},"assignees":[{"login":"sqweelygig","id":20857369,"avatar_url":"https://avatars0.githubusercontent.com/u/20857369?v=4","gravatar_id":"","url":"https://api.github.com/users/sqweelygig","html_url":"https://github.com/sqweelygig","followers_url":"https://api.github.com/users/sqweelygig/followers","following_url":"https://api.github.com/users/sqweelygig/following{/other_user}","gists_url":"https://api.github.com/users/sqweelygig/gists{/gist_id}","starred_url":"https://api.github.com/users/sqweelygig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sqweelygig/subscriptions","organizations_url":"https://api.github.com/users/sqweelygig/orgs","repos_url":"https://api.github.com/users/sqweelygig/repos","events_url":"https://api.github.com/users/sqweelygig/events{/privacy}","received_events_url":"https://api.github.com/users/sqweelygig/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"pimterry","id":1526883,"avatar_url":"https://avatars0.githubusercontent.com/u/1526883?v=4","gravatar_id":"","url":"https://api.github.com/users/pimterry","html_url":"https://github.com/pimterry","followers_url":"https://api.github.com/users/pimterry/followers","following_url":"https://api.github.com/users/pimterry/following{/other_user}","gists_url":"https://api.github.com/users/pimterry/gists{/gist_id}","starred_url":"https://api.github.com/users/pimterry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pimterry/subscriptions","organizations_url":"https://api.github.com/users/pimterry/orgs","repos_url":"https://api.github.com/users/pimterry/repos","events_url":"https://api.github.com/users/pimterry/events{/privacy}","received_events_url":"https://api.github.com/users/pimterry/received_events","type":"User","site_admin":false},{"login":"jviotti","id":2192773,"avatar_url":"https://avatars0.githubusercontent.com/u/2192773?v=4","gravatar_id":"","url":"https://api.github.com/users/jviotti","html_url":"https://github.com/jviotti","followers_url":"https://api.github.com/users/jviotti/followers","following_url":"https://api.github.com/users/jviotti/following{/other_user}","gists_url":"https://api.github.com/users/jviotti/gists{/gist_id}","starred_url":"https://api.github.com/users/jviotti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jviotti/subscriptions","organizations_url":"https://api.github.com/users/jviotti/orgs","repos_url":"https://api.github.com/users/jviotti/repos","events_url":"https://api.github.com/users/jviotti/events{/privacy}","received_events_url":"https://api.github.com/users/jviotti/received_events","type":"User","site_admin":false}],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/resin-io-modules/resin-procbots/pulls/387/commits","review_comments_url":"https://api.github.com/repos/resin-io-modules/resin-procbots/pulls/387/comments","review_comment_url":"https://api.github.com/repos/resin-io-modules/resin-procbots/pulls/comments{/number}","comments_url":"https://api.github.com/repos/resin-io-modules/resin-procbots/issues/387/comments","statuses_url":"https://api.github.com/repos/resin-io-modules/resin-procbots/statuses/1295a82f934063d8932319be8f812fc49a525eb0","head":{"label":"resin-io-modules:367-400-bug","ref":"367-400-bug","sha":"1295a82f934063d8932319be8f812fc49a525eb0","user":{"login":"resin-io-modules","id":17724750,"avatar_url":"https://avatars0.githubusercontent.com/u/17724750?v=4","gravatar_id":"","url":"https://api.github.com/users/resin-io-modules","html_url":"https://github.com/resin-io-modules","followers_url":"https://api.github.com/users/resin-io-modules/followers","following_url":"https://api.github.com/users/resin-io-modules/following{/other_user}","gists_url":"https://api.github.com/users/resin-io-modules/gists{/gist_id}","starred_url":"https://api.github.com/users/resin-io-modules/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/resin-io-modules/subscriptions","organizations_url":"https://api.github.com/users/resin-io-modules/orgs","repos_url":"https://api.github.com/users/resin-io-modules/repos","events_url":"https://api.github.com/users/resin-io-modules/events{/privacy}","received_events_url":"https://api.github.com/users/resin-io-modules/received_events","type":"Organization","site_admin":false},"repo":{"id":76547744,"name":"resin-procbots","full_name":"resin-io-modules/resin-procbots","owner":{"login":"resin-io-modules","id":17724750,"avatar_url":"https://avatars0.githubusercontent.com/u/17724750?v=4","gravatar_id":"","url":"https://api.github.com/users/resin-io-modules","html_url":"https://github.com/resin-io-modules","followers_url":"https://api.github.com/users/resin-io-modules/followers","following_url":"https://api.github.com/users/resin-io-modules/following{/other_user}","gists_url":"https://api.github.com/users/resin-io-modules/gists{/gist_id}","starred_url":"https://api.github.com/users/resin-io-modules/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/resin-io-modules/subscriptions","organizations_url":"https://api.github.com/users/resin-io-modules/orgs","repos_url":"https://api.github.com/users/resin-io-modules/repos","events_url":"https://api.github.com/users/resin-io-modules/events{/privacy}","received_events_url":"https://api.github.com/users/resin-io-modules/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/resin-io-modules/resin-procbots","description":"Process bots used for automating the development and deployment CI pipeline","fork":false,"url":"https://api.github.com/repos/resin-io-modules/resin-procbots","forks_url":"https://api.github.com/repos/resin-io-modules/resin-procbots/forks","keys_url":"https://api.github.com/repos/resin-io-modules/resin-procbots/keys{/key_id}","collaborators_url":"https://api.github.com/repos/resin-io-modules/resin-procbots/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/resin-io-modules/resin-procbots/teams","hooks_url":"https://api.github.com/repos/resin-io-modules/resin-procbots/hooks","issue_events_url":"https://api.github.com/repos/resin-io-modules/resin-procbots/issues/events{/number}","events_url":"https://api.github.com/repos/resin-io-modules/resin-procbots/events","assignees_url":"https://api.github.com/repos/resin-io-modules/resin-procbots/assignees{/user}","branches_url":"https://api.github.com/repos/resin-io-modules/resin-procbots/branches{/branch}","tags_url":"https://api.github.com/repos/resin-io-modules/resin-procbots/tags","blobs_url":"https://api.github.com/repos/resin-io-modules/resin-procbots/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/resin-io-modules/resin-procbots/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/resin-io-modules/resin-procbots/git/refs{/sha}","trees_url":"https://api.github.com/repos/resin-io-modules/resin-procbots/git/trees{/sha}","statuses_url":"https://api.github.com/repos/resin-io-modules/resin-procbots/statuses/{sha}","languages_url":"https://api.github.com/repos/resin-io-modules/resin-procbots/languages","stargazers_url":"https://api.github.com/repos/resin-io-modules/resin-procbots/stargazers","contributors_url":"https://api.github.com/repos/resin-io-modules/resin-procbots/contributors","subscribers_url":"https://api.github.com/repos/resin-io-modules/resin-procbots/subscribers","subscription_url":"https://api.github.com/repos/resin-io-modules/resin-procbots/subscription","commits_url":"https://api.github.com/repos/resin-io-modules/resin-procbots/commits{/sha}","git_commits_url":"https://api.github.com/repos/resin-io-modules/resin-procbots/git/commits{/sha}","comments_url":"https://api.github.com/repos/resin-io-modules/resin-procbots/comments{/number}","issue_comment_url":"https://api.github.com/repos/resin-io-modules/resin-procbots/issues/comments{/number}","contents_url":"https://api.github.com/repos/resin-io-modules/resin-procbots/contents/{+path}","compare_url":"https://api.github.com/repos/resin-io-modules/resin-procbots/compare/{base}...{head}","merges_url":"https://api.github.com/repos/resin-io-modules/resin-procbots/merges","archive_url":"https://api.github.com/repos/resin-io-modules/resin-procbots/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/resin-io-modules/resin-procbots/downloads","issues_url":"https://api.github.com/repos/resin-io-modules/resin-procbots/issues{/number}","pulls_url":"https://api.github.com/repos/resin-io-modules/resin-procbots/pulls{/number}","milestones_url":"https://api.github.com/repos/resin-io-modules/resin-procbots/milestones{/number}","notifications_url":"https://api.github.com/repos/resin-io-modules/resin-procbots/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/resin-io-modules/resin-procbots/labels{/name}","releases_url":"https://api.github.com/repos/resin-io-modules/resin-procbots/releases{/id}","deployments_url":"https://api.github.com/repos/resin-io-modules/resin-procbots/deployments","created_at":"2016-12-15T09:58:14Z","updated_at":"2017-08-10T14:23:54Z","pushed_at":"2018-02-01T13:03:39Z","git_url":"git://github.com/resin-io-modules/resin-procbots.git","ssh_url":"[email protected]:resin-io-modules/resin-procbots.git","clone_url":"https://github.com/resin-io-modules/resin-procbots.git","svn_url":"https://github.com/resin-io-modules/resin-procbots","homepage":"https://resin-io-modules.github.io/resin-procbots","size":3358,"stargazers_count":2,"watchers_count":2,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":93,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":3,"open_issues":93,"watchers":2,"default_branch":"master"}},"base":{"label":"resin-io-modules:master","ref":"master","sha":"7f79d901af3d9d8ab2a99a73d315e80038777f9d","user":{"login":"resin-io-modules","id":17724750,"avatar_url":"https://avatars0.githubusercontent.com/u/17724750?v=4","gravatar_id":"","url":"https://api.github.com/users/resin-io-modules","html_url":"https://github.com/resin-io-modules","followers_url":"https://api.github.com/users/resin-io-modules/followers","following_url":"https://api.github.com/users/resin-io-modules/following{/other_user}","gists_url":"https://api.github.com/users/resin-io-modules/gists{/gist_id}","starred_url":"https://api.github.com/users/resin-io-modules/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/resin-io-modules/subscriptions","organizations_url":"https://api.github.com/users/resin-io-modules/orgs","repos_url":"https://api.github.com/users/resin-io-modules/repos","events_url":"https://api.github.com/users/resin-io-modules/events{/privacy}","received_events_url":"https://api.github.com/users/resin-io-modules/received_events","type":"Organization","site_admin":false},"repo":{"id":76547744,"name":"resin-procbots","full_name":"resin-io-modules/resin-procbots","owner":{"login":"resin-io-modules","id":17724750,"avatar_url":"https://avatars0.githubusercontent.com/u/17724750?v=4","gravatar_id":"","url":"https://api.github.com/users/resin-io-modules","html_url":"https://github.com/resin-io-modules","followers_url":"https://api.github.com/users/resin-io-modules/followers","following_url":"https://api.github.com/users/resin-io-modules/following{/other_user}","gists_url":"https://api.github.com/users/resin-io-modules/gists{/gist_id}","starred_url":"https://api.github.com/users/resin-io-modules/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/resin-io-modules/subscriptions","organizations_url":"https://api.github.com/users/resin-io-modules/orgs","repos_url":"https://api.github.com/users/resin-io-modules/repos","events_url":"https://api.github.com/users/resin-io-modules/events{/privacy}","received_events_url":"https://api.github.com/users/resin-io-modules/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/resin-io-modules/resin-procbots","description":"Process bots used for automating the development and deployment CI pipeline","fork":false,"url":"https://api.github.com/repos/resin-io-modules/resin-procbots","forks_url":"https://api.github.com/repos/resin-io-modules/resin-procbots/forks","keys_url":"https://api.github.com/repos/resin-io-modules/resin-procbots/keys{/key_id}","collaborators_url":"https://api.github.com/repos/resin-io-modules/resin-procbots/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/resin-io-modules/resin-procbots/teams","hooks_url":"https://api.github.com/repos/resin-io-modules/resin-procbots/hooks","issue_events_url":"https://api.github.com/repos/resin-io-modules/resin-procbots/issues/events{/number}","events_url":"https://api.github.com/repos/resin-io-modules/resin-procbots/events","assignees_url":"https://api.github.com/repos/resin-io-modules/resin-procbots/assignees{/user}","branches_url":"https://api.github.com/repos/resin-io-modules/resin-procbots/branches{/branch}","tags_url":"https://api.github.com/repos/resin-io-modules/resin-procbots/tags","blobs_url":"https://api.github.com/repos/resin-io-modules/resin-procbots/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/resin-io-modules/resin-procbots/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/resin-io-modules/resin-procbots/git/refs{/sha}","trees_url":"https://api.github.com/repos/resin-io-modules/resin-procbots/git/trees{/sha}","statuses_url":"https://api.github.com/repos/resin-io-modules/resin-procbots/statuses/{sha}","languages_url":"https://api.github.com/repos/resin-io-modules/resin-procbots/languages","stargazers_url":"https://api.github.com/repos/resin-io-modules/resin-procbots/stargazers","contributors_url":"https://api.github.com/repos/resin-io-modules/resin-procbots/contributors","subscribers_url":"https://api.github.com/repos/resin-io-modules/resin-procbots/subscribers","subscription_url":"https://api.github.com/repos/resin-io-modules/resin-procbots/subscription","commits_url":"https://api.github.com/repos/resin-io-modules/resin-procbots/commits{/sha}","git_commits_url":"https://api.github.com/repos/resin-io-modules/resin-procbots/git/commits{/sha}","comments_url":"https://api.github.com/repos/resin-io-modules/resin-procbots/comments{/number}","issue_comment_url":"https://api.github.com/repos/resin-io-modules/resin-procbots/issues/comments{/number}","contents_url":"https://api.github.com/repos/resin-io-modules/resin-procbots/contents/{+path}","compare_url":"https://api.github.com/repos/resin-io-modules/resin-procbots/compare/{base}...{head}","merges_url":"https://api.github.com/repos/resin-io-modules/resin-procbots/merges","archive_url":"https://api.github.com/repos/resin-io-modules/resin-procbots/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/resin-io-modules/resin-procbots/downloads","issues_url":"https://api.github.com/repos/resin-io-modules/resin-procbots/issues{/number}","pulls_url":"https://api.github.com/repos/resin-io-modules/resin-procbots/pulls{/number}","milestones_url":"https://api.github.com/repos/resin-io-modules/resin-procbots/milestones{/number}","notifications_url":"https://api.github.com/repos/resin-io-modules/resin-procbots/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/resin-io-modules/resin-procbots/labels{/name}","releases_url":"https://api.github.com/repos/resin-io-modules/resin-procbots/releases{/id}","deployments_url":"https://api.github.com/repos/resin-io-modules/resin-procbots/deployments","created_at":"2016-12-15T09:58:14Z","updated_at":"2017-08-10T14:23:54Z","pushed_at":"2018-02-01T13:03:39Z","git_url":"git://github.com/resin-io-modules/resin-procbots.git","ssh_url":"[email protected]:resin-io-modules/resin-procbots.git","clone_url":"https://github.com/resin-io-modules/resin-procbots.git","svn_url":"https://github.com/resin-io-modules/resin-procbots","homepage":"https://resin-io-modules.github.io/resin-procbots","size":3358,"stargazers_count":2,"watchers_count":2,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":93,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":3,"open_issues":93,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/resin-io-modules/resin-procbots/pulls/387"},"html":{"href":"https://github.com/resin-io-modules/resin-procbots/pull/387"},"issue":{"href":"https://api.github.com/repos/resin-io-modules/resin-procbots/issues/387"},"comments":{"href":"https://api.github.com/repos/resin-io-modules/resin-procbots/issues/387/comments"},"review_comments":{"href":"https://api.github.com/repos/resin-io-modules/resin-procbots/pulls/387/comments"},"review_comment":{"href":"https://api.github.com/repos/resin-io-modules/resin-procbots/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/resin-io-modules/resin-procbots/pulls/387/commits"},"statuses":{"href":"https://api.github.com/repos/resin-io-modules/resin-procbots/statuses/1295a82f934063d8932319be8f812fc49a525eb0"}},"author_association":"CONTRIBUTOR"}} | {
"id": 76547744,
"name": "resin-io-modules/resin-procbots",
"url": "https://api.github.com/repos/resin-io-modules/resin-procbots"
} | {
"id": 8259026,
"login": "hedss",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/8259026?",
"url": "https://api.github.com/users/hedss"
} | {
"id": 17724750,
"login": "resin-io-modules",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/17724750?",
"url": "https://api.github.com/orgs/resin-io-modules"
} | 2018-02-01T13:52:57 | 7183577234 | {"actor":{"display_login":"hedss"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/intel/govmm/pulls/comments/208606570","pull_request_review_id":144450029,"id":208606570,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwODYwNjU3MA==","diff_hunk":"@@ -938,12 +938,17 @@ func (q *QMP) ExecHotplugMemory(ctx context.Context, qomtype, id, mempath string\n }\n \n // ExecutePCIVSockAdd adds a vhost-vsock-pci bus\n-func (q *QMP) ExecutePCIVSockAdd(ctx context.Context, id, guestCID, vhostfd string, disableModern bool) error {\n+func (q *QMP) ExecutePCIVSockAdd(ctx context.Context, id, guestCID, vhostfd, addr, bus string, disableModern bool) error {\n \targs := map[string]interface{}{\n \t\t\"driver\": VHostVSockPCI,\n \t\t\"id\": id,\n \t\t\"guest-cid\": guestCID,\n \t\t\"vhostfd\": vhostfd,\n+\t\t\"addr\": addr,","path":"qemu/qmp.go","position":11,"original_position":11,"commit_id":"26fee3ec322238419384ddd2967534e1a7f5d971","original_commit_id":"26fee3ec322238419384ddd2967534e1a7f5d971","user":{"login":"markdryan","id":984073,"node_id":"MDQ6VXNlcjk4NDA3Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/984073?v=4","gravatar_id":"","url":"https://api.github.com/users/markdryan","html_url":"https://github.com/markdryan","followers_url":"https://api.github.com/users/markdryan/followers","following_url":"https://api.github.com/users/markdryan/following{/other_user}","gists_url":"https://api.github.com/users/markdryan/gists{/gist_id}","starred_url":"https://api.github.com/users/markdryan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markdryan/subscriptions","organizations_url":"https://api.github.com/users/markdryan/orgs","repos_url":"https://api.github.com/users/markdryan/repos","events_url":"https://api.github.com/users/markdryan/events{/privacy}","received_events_url":"https://api.github.com/users/markdryan/received_events","type":"User","site_admin":false},"body":"I see. The problem is the commit message is very confusing. It talks about making the bus parameter mandatory but if you look in the code that it adds the bus parameter appears to be optional. It seems that both I and @sboeuf were confused by this so it's probab","created_at":"2018-08-08T14:38:07Z","updated_at":"2018-08-08T14:38:07Z","html_url":"https://github.com/intel/govmm/pull/34#discussion_r208606570","pull_request_url":"https://api.github.com/repos/intel/govmm/pulls/34","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/intel/govmm/pulls/comments/208606570"},"html":{"href":"https://github.com/intel/govmm/pull/34#discussion_r208606570"},"pull_request":{"href":"https://api.github.com/repos/intel/govmm/pulls/34"}},"in_reply_to_id":208442317},"pull_request":{"url":"https://api.github.com/repos/intel/govmm/pulls/34","id":206790962,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2NzkwOTYy","html_url":"https://github.com/intel/govmm/pull/34","diff_url":"https://github.com/intel/govmm/pull/34.diff","patch_url":"https://github.com/intel/govmm/pull/34.patch","issue_url":"https://api.github.com/repos/intel/govmm/issues/34","number":34,"state":"open","locked":false,"title":"qemu/qmp: add addr and bus to hotplug vsock devices","user":{"login":"devimc","id":13009432,"node_id":"MDQ6VXNlcjEzMDA5NDMy","avatar_url":"https://avatars0.githubusercontent.com/u/13009432?v=4","gravatar_id":"","url":"https://api.github.com/users/devimc","html_url":"https://github.com/devimc","followers_url":"https://api.github.com/users/devimc/followers","following_url":"https://api.github.com/users/devimc/following{/other_user}","gists_url":"https://api.github.com/users/devimc/gists{/gist_id}","starred_url":"https://api.github.com/users/devimc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/devimc/subscriptions","organizations_url":"https://api.github.com/users/devimc/orgs","repos_url":"https://api.github.com/users/devimc/repos","events_url":"https://api.github.com/users/devimc/events{/privacy}","received_events_url":"https://api.github.com/users/devimc/received_events","type":"User","site_admin":false},"body":"addr and bus must be specified when a new device is hot plugged\r\non machines based on PCIe, like q35.\r\n\r\nSigned-off-by: Julio Montes <[email protected]>","created_at":"2018-08-07T18:42:14Z","updated_at":"2018-08-08T14:38:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"941fb3d20910899bbfb6dc9e0556ced017fedc2f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/intel/govmm/pulls/34/commits","review_comments_url":"https://api.github.com/repos/intel/govmm/pulls/34/comments","review_comment_url":"https://api.github.com/repos/intel/govmm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/intel/govmm/issues/34/comments","statuses_url":"https://api.github.com/repos/intel/govmm/statuses/26fee3ec322238419384ddd2967534e1a7f5d971","head":{"label":"devimc:topic/addrBusVsock","ref":"topic/addrBusVsock","sha":"26fee3ec322238419384ddd2967534e1a7f5d971","user":{"login":"devimc","id":13009432,"node_id":"MDQ6VXNlcjEzMDA5NDMy","avatar_url":"https://avatars0.githubusercontent.com/u/13009432?v=4","gravatar_id":"","url":"https://api.github.com/users/devimc","html_url":"https://github.com/devimc","followers_url":"https://api.github.com/users/devimc/followers","following_url":"https://api.github.com/users/devimc/following{/other_user}","gists_url":"https://api.github.com/users/devimc/gists{/gist_id}","starred_url":"https://api.github.com/users/devimc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/devimc/subscriptions","organizations_url":"https://api.github.com/users/devimc/orgs","repos_url":"https://api.github.com/users/devimc/repos","events_url":"https://api.github.com/users/devimc/events{/privacy}","received_events_url":"https://api.github.com/users/devimc/received_events","type":"User","site_admin":false},"repo":{"id":113993471,"node_id":"MDEwOlJlcG9zaXRvcnkxMTM5OTM0NzE=","name":"govmm","full_name":"devimc/govmm","owner":{"login":"devimc","id":13009432,"node_id":"MDQ6VXNlcjEzMDA5NDMy","avatar_url":"https://avatars0.githubusercontent.com/u/13009432?v=4","gravatar_id":"","url":"https://api.github.com/users/devimc","html_url":"https://github.com/devimc","followers_url":"https://api.github.com/users/devimc/followers","following_url":"https://api.github.com/users/devimc/following{/other_user}","gists_url":"https://api.github.com/users/devimc/gists{/gist_id}","starred_url":"https://api.github.com/users/devimc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/devimc/subscriptions","organizations_url":"https://api.github.com/users/devimc/orgs","repos_url":"https://api.github.com/users/devimc/repos","events_url":"https://api.github.com/users/devimc/events{/privacy}","received_events_url":"https://api.github.com/users/devimc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/devimc/govmm","description":"Virtual Machine Manager for Go (govmm) is a suite of packages that provide Go APIs for creating and managing virtual machines.","fork":true,"url":"https://api.github.com/repos/devimc/govmm","forks_url":"https://api.github.com/repos/devimc/govmm/forks","keys_url":"https://api.github.com/repos/devimc/govmm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/devimc/govmm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/devimc/govmm/teams","hooks_url":"https://api.github.com/repos/devimc/govmm/hooks","issue_events_url":"https://api.github.com/repos/devimc/govmm/issues/events{/number}","events_url":"https://api.github.com/repos/devimc/govmm/events","assignees_url":"https://api.github.com/repos/devimc/govmm/assignees{/user}","branches_url":"https://api.github.com/repos/devimc/govmm/branches{/branch}","tags_url":"https://api.github.com/repos/devimc/govmm/tags","blobs_url":"https://api.github.com/repos/devimc/govmm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/devimc/govmm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/devimc/govmm/git/refs{/sha}","trees_url":"https://api.github.com/repos/devimc/govmm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/devimc/govmm/statuses/{sha}","languages_url":"https://api.github.com/repos/devimc/govmm/languages","stargazers_url":"https://api.github.com/repos/devimc/govmm/stargazers","contributors_url":"https://api.github.com/repos/devimc/govmm/contributors","subscribers_url":"https://api.github.com/repos/devimc/govmm/subscribers","subscription_url":"https://api.github.com/repos/devimc/govmm/subscription","commits_url":"https://api.github.com/repos/devimc/govmm/commits{/sha}","git_commits_url":"https://api.github.com/repos/devimc/govmm/git/commits{/sha}","comments_url":"https://api.github.com/repos/devimc/govmm/comments{/number}","issue_comment_url":"https://api.github.com/repos/devimc/govmm/issues/comments{/number}","contents_url":"https://api.github.com/repos/devimc/govmm/contents/{+path}","compare_url":"https://api.github.com/repos/devimc/govmm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/devimc/govmm/merges","archive_url":"https://api.github.com/repos/devimc/govmm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/devimc/govmm/downloads","issues_url":"https://api.github.com/repos/devimc/govmm/issues{/number}","pulls_url":"https://api.github.com/repos/devimc/govmm/pulls{/number}","milestones_url":"https://api.github.com/repos/devimc/govmm/milestones{/number}","notifications_url":"https://api.github.com/repos/devimc/govmm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/devimc/govmm/labels{/name}","releases_url":"https://api.github.com/repos/devimc/govmm/releases{/id}","deployments_url":"https://api.github.com/repos/devimc/govmm/deployments","created_at":"2017-12-12T13:25:49Z","updated_at":"2018-08-03T12:52:58Z","pushed_at":"2018-08-07T18:41:33Z","git_url":"git://github.com/devimc/govmm.git","ssh_url":"[email protected]:devimc/govmm.git","clone_url":"https://github.com/devimc/govmm.git","svn_url":"https://github.com/devimc/govmm","homepage":"","size":185,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"intel:master","ref":"master","sha":"8d626afb0cc0ba7e2fb249c83761f0a2b28af546","user":{"login":"intel","id":17888862,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3ODg4ODYy","avatar_url":"https://avatars3.githubusercontent.com/u/17888862?v=4","gravatar_id":"","url":"https://api.github.com/users/intel","html_url":"https://github.com/intel","followers_url":"https://api.github.com/users/intel/followers","following_url":"https://api.github.com/users/intel/following{/other_user}","gists_url":"https://api.github.com/users/intel/gists{/gist_id}","starred_url":"https://api.github.com/users/intel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/intel/subscriptions","organizations_url":"https://api.github.com/users/intel/orgs","repos_url":"https://api.github.com/users/intel/repos","events_url":"https://api.github.com/users/intel/events{/privacy}","received_events_url":"https://api.github.com/users/intel/received_events","type":"Organization","site_admin":false},"repo":{"id":111746109,"node_id":"MDEwOlJlcG9zaXRvcnkxMTE3NDYxMDk=","name":"govmm","full_name":"intel/govmm","owner":{"login":"intel","id":17888862,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3ODg4ODYy","avatar_url":"https://avatars3.githubusercontent.com/u/17888862?v=4","gravatar_id":"","url":"https://api.github.com/users/intel","html_url":"https://github.com/intel","followers_url":"https://api.github.com/users/intel/followers","following_url":"https://api.github.com/users/intel/following{/other_user}","gists_url":"https://api.github.com/users/intel/gists{/gist_id}","starred_url":"https://api.github.com/users/intel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/intel/subscriptions","organizations_url":"https://api.github.com/users/intel/orgs","repos_url":"https://api.github.com/users/intel/repos","events_url":"https://api.github.com/users/intel/events{/privacy}","received_events_url":"https://api.github.com/users/intel/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/intel/govmm","description":"Virtual Machine Manager for Go (govmm) is a suite of packages that provide Go APIs for creating and managing virtual machines.","fork":false,"url":"https://api.github.com/repos/intel/govmm","forks_url":"https://api.github.com/repos/intel/govmm/forks","keys_url":"https://api.github.com/repos/intel/govmm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/intel/govmm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/intel/govmm/teams","hooks_url":"https://api.github.com/repos/intel/govmm/hooks","issue_events_url":"https://api.github.com/repos/intel/govmm/issues/events{/number}","events_url":"https://api.github.com/repos/intel/govmm/events","assignees_url":"https://api.github.com/repos/intel/govmm/assignees{/user}","branches_url":"https://api.github.com/repos/intel/govmm/branches{/branch}","tags_url":"https://api.github.com/repos/intel/govmm/tags","blobs_url":"https://api.github.com/repos/intel/govmm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/intel/govmm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/intel/govmm/git/refs{/sha}","trees_url":"https://api.github.com/repos/intel/govmm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/intel/govmm/statuses/{sha}","languages_url":"https://api.github.com/repos/intel/govmm/languages","stargazers_url":"https://api.github.com/repos/intel/govmm/stargazers","contributors_url":"https://api.github.com/repos/intel/govmm/contributors","subscribers_url":"https://api.github.com/repos/intel/govmm/subscribers","subscription_url":"https://api.github.com/repos/intel/govmm/subscription","commits_url":"https://api.github.com/repos/intel/govmm/commits{/sha}","git_commits_url":"https://api.github.com/repos/intel/govmm/git/commits{/sha}","comments_url":"https://api.github.com/repos/intel/govmm/comments{/number}","issue_comment_url":"https://api.github.com/repos/intel/govmm/issues/comments{/number}","contents_url":"https://api.github.com/repos/intel/govmm/contents/{+path}","compare_url":"https://api.github.com/repos/intel/govmm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/intel/govmm/merges","archive_url":"https://api.github.com/repos/intel/govmm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/intel/govmm/downloads","issues_url":"https://api.github.com/repos/intel/govmm/issues{/number}","pulls_url":"https://api.github.com/repos/intel/govmm/pulls{/number}","milestones_url":"https://api.github.com/repos/intel/govmm/milestones{/number}","notifications_url":"https://api.github.com/repos/intel/govmm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/intel/govmm/labels{/name}","releases_url":"https://api.github.com/repos/intel/govmm/releases{/id}","deployments_url":"https://api.github.com/repos/intel/govmm/deployments","created_at":"2017-11-23T00:39:55Z","updated_at":"2018-08-06T17:44:36Z","pushed_at":"2018-08-08T03:13:02Z","git_url":"git://github.com/intel/govmm.git","ssh_url":"[email protected]:intel/govmm.git","clone_url":"https://github.com/intel/govmm.git","svn_url":"https://github.com/intel/govmm","homepage":"","size":196,"stargazers_count":20,"watchers_count":20,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"archived":false,"open_issues_count":9,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":14,"open_issues":9,"watchers":20,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/intel/govmm/pulls/34"},"html":{"href":"https://github.com/intel/govmm/pull/34"},"issue":{"href":"https://api.github.com/repos/intel/govmm/issues/34"},"comments":{"href":"https://api.github.com/repos/intel/govmm/issues/34/comments"},"review_comments":{"href":"https://api.github.com/repos/intel/govmm/pulls/34/comments"},"review_comment":{"href":"https://api.github.com/repos/intel/govmm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/intel/govmm/pulls/34/commits"},"statuses":{"href":"https://api.github.com/repos/intel/govmm/statuses/26fee3ec322238419384ddd2967534e1a7f5d971"}},"author_association":"CONTRIBUTOR"}} | {
"id": 111746109,
"name": "intel/govmm",
"url": "https://api.github.com/repos/intel/govmm"
} | {
"id": 984073,
"login": "markdryan",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/984073?",
"url": "https://api.github.com/users/markdryan"
} | {
"id": 17888862,
"login": "intel",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/17888862?",
"url": "https://api.github.com/orgs/intel"
} | 2018-08-08T14:38:07 | 8084400262 | {"actor":{"display_login":"markdryan"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/intel/webml-polyfill/pulls/comments/204267743","pull_request_review_id":139312107,"id":204267743,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNDI2Nzc0Mw==","diff_hunk":"@@ -0,0 +1,372 @@\n+class PoseNet{\n+ constructor(tfmodel, backend, version, outputstride, input, type){\n+ this._tfmodel = tfmodel;\n+ this._model = null;\n+ this._compilation;\n+ this._execution;\n+ this._tensorIds = [];\n+ this._operandIndex = 0;\n+ this._version = version;\n+ this._outputstride = outputstride;\n+ this._inputs = input;\n+ this._shape = [];\n+ this._outputs = [];\n+ this._type = type;\n+ if (typeof backend !== 'undefined') {\n+ this._backend = backend;\n+ } \n+ else {\n+ if (nnNative) {\n+ this._backend = 'WebML';\n+ } \n+ else {\n+ this._backend = 'WASM';\n+ }\n+ }\n+ if (this._backend === 'WebML') {\n+ if (nnNative === null) {\n+ throw Error('Fails to initialize neural network context');\n+ }\n+ this._nn = nnNative;\n+ }\n+ else if (this._backend === 'WASM' || this._backend === 'WebGL2') {\n+ this._nn = nnPolyfill;\n+ }\n+ }\n+ async createCompiledModel(){\n+ let options = {};\n+ if(this._backend === 'WebGL2'){\n+ options.useWebGL2 = true;\n+ }\n+ this._model = await this._nn.createModel(options);\n+ \n+ await this._addTensorOperands();\n+ this._addOpsAndParams();\n+ \n+ await this._model.finish();\n+ this._compilation = await this._model.createCompilation();\n+ this._compilation.setPreference(this._nn.PREFER_FAST_SINGLE_ANSWER);\n+ await this._compilation.finish();\n+ this._execution = await this._compilation.createExecution();\n+ }\n+\n+ async compute_single(inputTensor, heatmapTensor, offsetTensor){\n+ this._execution.setInput(0, inputTensor);\n+ this._execution.setOutput(0, heatmapTensor);\n+ this._execution.setOutput(1, offsetTensor);\n+ let error = await this._execution.startCompute();\n+ if(error){\n+ return error;\n+ }\n+ return 'success';\n+ }\n+\n+ async compute_multi(inputTensor, heatmapTensor, offsetTensor, displacement_fwd, displacement_bwd){\n+ this._execution.setInput(0, inputTensor);\n+ this._execution.setOutput(0, heatmapTensor);\n+ this._execution.setOutput(1, offsetTensor);\n+ this._execution.setOutput(2, displacement_fwd);\n+ this._execution.setOutput(3, displacement_bwd);\n+ let error = await this._execution.startCompute();\n+ if(error){\n+ return error;\n+ }\n+ return 'success';\n+ }\n+\n+\n+ async _addTensorOperands(){\n+ this._tfmodel = toOutputStridedLayers(this._tfmodel, this._outputstride);\n+ let dimension_out;\n+ let dimension_in = this._inputs;\n+ const type = this._nn.TENSOR_FLOAT32;\n+ for(let i in this._tfmodel){\n+ let dimension = [];\n+ let weights = [];\n+ let dimension_bias = [];\n+ let bias = [];\n+ if(this._tfmodel[i][\"convType\"] === \"conv2d\"){\n+ await getDimensionData(\"conv2d\", this._version, i).then(function(data){\n+ dimension.push(resize(data[0]));\n+ weights.push(new Float32Array(transpose_weights(data[1], data[0])));\n+ dimension_bias.push(data[2]);\n+ bias.push(data[3]);\n+ });\n+ dimension_out = this._calculateOutput(dimension_in, dimension[0], this._tfmodel[i][\"stride\"], \"conv2d\");\n+ dimension_in = dimension_out;\n+ this._outputs.push(this._operandIndex);\n+ this._model.addOperand({type: type, dimensions: dimension_out});\n+ this._operandIndex++;\n+ }\n+ if(this._tfmodel[i][\"convType\"] === \"separableConv\"){\n+ let data = await getDimensionData(\"separableConv\", this._version, i);\n+ if(this._tfmodel[i].rate == 1){\n+ dimension.push(resize(data[0][0]));\n+ dimension.push(resize(data[0][1]));\n+ weights.push(new Float32Array(transpose_weights(data[1][0], data[0][0])));\n+ weights.push(new Float32Array(transpose_weights(data[1][1], data[0][1])));\n+ dimension_bias.push(data[2][0]);\n+ dimension_bias.push(data[2][1]);\n+ bias.push(data[3][0]);\n+ bias.push(data[3][1]);\n+ }else{\n+ let dilationData = dilationWeights(new Float32Array(transpose_weights(data[1][0], data[0][0])), \n+ resize(data[0][0]), this._tfmodel[i].rate);\n+ dimension.push(dilationData[0]);\n+ dimension.push(resize(data[0][1]));\n+ weights.push(dilationData[1]);\n+ weights.push(new Float32Array(transpose_weights(data[1][1], data[0][1])));\n+ dimension_bias.push(data[2][0]);\n+ dimension_bias.push(data[2][1]);\n+ bias.push(data[3][0]);\n+ bias.push(data[3][1]);\n+ }\n+\n+ if(this._tfmodel[i].rate == 1){\n+ dimension_out = this._calculateOutput(dimension_in, dimension[0], \n+ this._tfmodel[i][\"stride\"], \n+ \"depthwise\");\n+ }\n+ else{\n+ dimension_out = this._calculateOutput(dimension_in, resize(data[0][0]), \n+ this._tfmodel[i][\"stride\"], \n+ \"depthwise\");\n+ }\n+ dimension_in = dimension_out;\n+ this._outputs.push(this._operandIndex);\n+ this._model.addOperand({type:type, dimensions: dimension_out});\n+ this._operandIndex++;\n+ dimension_out = this._calculateOutput(dimension_in, dimension[1], 1, \"pointwise\");\n+ dimension_in = dimension_out;\n+ this._outputs.push(this._operandIndex);\n+ this._model.addOperand({type:type, dimensions: dimension_out});\n+ this._operandIndex++;\n+ }\n+ for(let j in dimension){\n+ let tensorId = this._operandIndex++;\n+ let tensorType = {type: type, dimensions: dimension[j]};\n+ this._shape.push(dimension[j]);\n+ this._model.addOperand(tensorType);\n+ this._model.setOperandValue(tensorId, weights[j]);\n+ tensorId = this._operandIndex++;\n+ let tensorType_bias = {type: type, dimensions: dimension_bias[j]};\n+ this._model.addOperand(tensorType_bias);\n+ this._model.setOperandValue(tensorId, bias[j]);\n+ } \n+ }\n+ //insert output layer\n+ let tensorType, tensorType_bias;\n+ let value, value_bias;\n+ let shape_weights, shape_bias;\n+ await getOutputLayer(\"heatmap\", this._version).then(function(data){\n+ tensorType = {type: type, dimensions: resize(data[0])};\n+ tensorType_bias = {type: type, dimensions: data[2]};\n+ value = new Float32Array(transpose_weights(data[1], data[0]));\n+ value_bias = data[3];\n+ }); \n+ let tensorId = this._operandIndex++;\n+ this._model.addOperand(tensorType);\n+ this._model.setOperandValue(tensorId, value);\n+ tensorId = this._operandIndex++;\n+ this._model.addOperand(tensorType_bias);\n+ this._model.setOperandValue(tensorId, value_bias);\n+ \n+ await getOutputLayer(\"offset\", this._version).then(function(data){\n+ tensorType = {type: type, dimensions: resize(data[0])};\n+ tensorType_bias = {type: type, dimensions: data[2]};\n+ value = new Float32Array(transpose_weights(data[1], data[0]));\n+ value_bias = data[3];\n+ }); \n+ tensorId = this._operandIndex++;\n+ this._model.addOperand(tensorType);\n+ this._model.setOperandValue(tensorId, value);\n+ tensorId = this._operandIndex++;\n+ this._model.addOperand(tensorType_bias);\n+ this._model.setOperandValue(tensorId, value_bias);\n+ \n+ if(this._type === \"Multiperson\"){ \n+ await getOutputLayer(\"displacement_fwd\", this._version).then(function(data){\n+ tensorType = {type: type, dimensions: resize(data[0])};\n+ tensorType_bias = {type: type, dimensions: data[2]};\n+ value = new Float32Array(transpose_weights(data[1], data[0]));\n+ value_bias = data[3];\n+ }); \n+ tensorId = this._operandIndex++;\n+ this._model.addOperand(tensorType);\n+ this._model.setOperandValue(tensorId, value);\n+ tensorId = this._operandIndex++;\n+ this._model.addOperand(tensorType_bias);\n+ this._model.setOperandValue(tensorId, value_bias);\n+ \n+ await getOutputLayer(\"displacement_bwd\", this._version).then(function(data){","path":"examples/posenet/src/PoseNet.js","position":201,"original_position":201,"commit_id":"a9bb904a62832b15836a4fec0366b82d8dd69c96","original_commit_id":"a9bb904a62832b15836a4fec0366b82d8dd69c96","user":{"login":"huningxin","id":1005673,"node_id":"MDQ6VXNlcjEwMDU2NzM=","avatar_url":"https://avatars1.githubusercontent.com/u/1005673?v=4","gravatar_id":"","url":"https://api.github.com/users/huningxin","html_url":"https://github.com/huningxin","followers_url":"https://api.github.com/users/huningxin/followers","following_url":"https://api.github.com/users/huningxin/following{/other_user}","gists_url":"https://api.github.com/users/huningxin/gists{/gist_id}","starred_url":"https://api.github.com/users/huningxin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huningxin/subscriptions","organizations_url":"https://api.github.com/users/huningxin/orgs","repos_url":"https://api.github.com/users/huningxin/repos","events_url":"https://api.github.com/users/huningxin/events{/privacy}","received_events_url":"https://api.github.com/users/huningxin/received_events","type":"User","site_admin":false},"body":"ditto.","created_at":"2018-07-23T02:08:17Z","updated_at":"2018-07-23T02:31:46Z","html_url":"https://github.com/intel/webml-polyfill/pull/82#discussion_r204267743","pull_request_url":"https://api.github.com/repos/intel/webml-polyfill/pulls/82","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/intel/webml-polyfill/pulls/comments/204267743"},"html":{"href":"https://github.com/intel/webml-polyfill/pull/82#discussion_r204267743"},"pull_request":{"href":"https://api.github.com/repos/intel/webml-polyfill/pulls/82"}}},"pull_request":{"url":"https://api.github.com/repos/intel/webml-polyfill/pulls/82","id":197614699,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3NjE0Njk5","html_url":"https://github.com/intel/webml-polyfill/pull/82","diff_url":"https://github.com/intel/webml-polyfill/pull/82.diff","patch_url":"https://github.com/intel/webml-polyfill/pull/82.patch","issue_url":"https://api.github.com/repos/intel/webml-polyfill/issues/82","number":82,"state":"open","locked":false,"title":"PoseNet example","user":{"login":"yl495","id":35751009,"node_id":"MDQ6VXNlcjM1NzUxMDA5","avatar_url":"https://avatars3.githubusercontent.com/u/35751009?v=4","gravatar_id":"","url":"https://api.github.com/users/yl495","html_url":"https://github.com/yl495","followers_url":"https://api.github.com/users/yl495/followers","following_url":"https://api.github.com/users/yl495/following{/other_user}","gists_url":"https://api.github.com/users/yl495/gists{/gist_id}","starred_url":"https://api.github.com/users/yl495/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yl495/subscriptions","organizations_url":"https://api.github.com/users/yl495/orgs","repos_url":"https://api.github.com/users/yl495/repos","events_url":"https://api.github.com/users/yl495/events{/privacy}","received_events_url":"https://api.github.com/users/yl495/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-06-27T04:40:47Z","updated_at":"2018-07-23T02:31:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6ea235f7389528eeb5cb175025c2534d309c470c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/intel/webml-polyfill/pulls/82/commits","review_comments_url":"https://api.github.com/repos/intel/webml-polyfill/pulls/82/comments","review_comment_url":"https://api.github.com/repos/intel/webml-polyfill/pulls/comments{/number}","comments_url":"https://api.github.com/repos/intel/webml-polyfill/issues/82/comments","statuses_url":"https://api.github.com/repos/intel/webml-polyfill/statuses/a9bb904a62832b15836a4fec0366b82d8dd69c96","head":{"label":"yl495:master","ref":"master","sha":"a9bb904a62832b15836a4fec0366b82d8dd69c96","user":{"login":"yl495","id":35751009,"node_id":"MDQ6VXNlcjM1NzUxMDA5","avatar_url":"https://avatars3.githubusercontent.com/u/35751009?v=4","gravatar_id":"","url":"https://api.github.com/users/yl495","html_url":"https://github.com/yl495","followers_url":"https://api.github.com/users/yl495/followers","following_url":"https://api.github.com/users/yl495/following{/other_user}","gists_url":"https://api.github.com/users/yl495/gists{/gist_id}","starred_url":"https://api.github.com/users/yl495/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yl495/subscriptions","organizations_url":"https://api.github.com/users/yl495/orgs","repos_url":"https://api.github.com/users/yl495/repos","events_url":"https://api.github.com/users/yl495/events{/privacy}","received_events_url":"https://api.github.com/users/yl495/received_events","type":"User","site_admin":false},"repo":{"id":136129220,"node_id":"MDEwOlJlcG9zaXRvcnkxMzYxMjkyMjA=","name":"webml-polyfill","full_name":"yl495/webml-polyfill","owner":{"login":"yl495","id":35751009,"node_id":"MDQ6VXNlcjM1NzUxMDA5","avatar_url":"https://avatars3.githubusercontent.com/u/35751009?v=4","gravatar_id":"","url":"https://api.github.com/users/yl495","html_url":"https://github.com/yl495","followers_url":"https://api.github.com/users/yl495/followers","following_url":"https://api.github.com/users/yl495/following{/other_user}","gists_url":"https://api.github.com/users/yl495/gists{/gist_id}","starred_url":"https://api.github.com/users/yl495/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yl495/subscriptions","organizations_url":"https://api.github.com/users/yl495/orgs","repos_url":"https://api.github.com/users/yl495/repos","events_url":"https://api.github.com/users/yl495/events{/privacy}","received_events_url":"https://api.github.com/users/yl495/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yl495/webml-polyfill","description":null,"fork":true,"url":"https://api.github.com/repos/yl495/webml-polyfill","forks_url":"https://api.github.com/repos/yl495/webml-polyfill/forks","keys_url":"https://api.github.com/repos/yl495/webml-polyfill/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yl495/webml-polyfill/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yl495/webml-polyfill/teams","hooks_url":"https://api.github.com/repos/yl495/webml-polyfill/hooks","issue_events_url":"https://api.github.com/repos/yl495/webml-polyfill/issues/events{/number}","events_url":"https://api.github.com/repos/yl495/webml-polyfill/events","assignees_url":"https://api.github.com/repos/yl495/webml-polyfill/assignees{/user}","branches_url":"https://api.github.com/repos/yl495/webml-polyfill/branches{/branch}","tags_url":"https://api.github.com/repos/yl495/webml-polyfill/tags","blobs_url":"https://api.github.com/repos/yl495/webml-polyfill/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yl495/webml-polyfill/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yl495/webml-polyfill/git/refs{/sha}","trees_url":"https://api.github.com/repos/yl495/webml-polyfill/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yl495/webml-polyfill/statuses/{sha}","languages_url":"https://api.github.com/repos/yl495/webml-polyfill/languages","stargazers_url":"https://api.github.com/repos/yl495/webml-polyfill/stargazers","contributors_url":"https://api.github.com/repos/yl495/webml-polyfill/contributors","subscribers_url":"https://api.github.com/repos/yl495/webml-polyfill/subscribers","subscription_url":"https://api.github.com/repos/yl495/webml-polyfill/subscription","commits_url":"https://api.github.com/repos/yl495/webml-polyfill/commits{/sha}","git_commits_url":"https://api.github.com/repos/yl495/webml-polyfill/git/commits{/sha}","comments_url":"https://api.github.com/repos/yl495/webml-polyfill/comments{/number}","issue_comment_url":"https://api.github.com/repos/yl495/webml-polyfill/issues/comments{/number}","contents_url":"https://api.github.com/repos/yl495/webml-polyfill/contents/{+path}","compare_url":"https://api.github.com/repos/yl495/webml-polyfill/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yl495/webml-polyfill/merges","archive_url":"https://api.github.com/repos/yl495/webml-polyfill/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yl495/webml-polyfill/downloads","issues_url":"https://api.github.com/repos/yl495/webml-polyfill/issues{/number}","pulls_url":"https://api.github.com/repos/yl495/webml-polyfill/pulls{/number}","milestones_url":"https://api.github.com/repos/yl495/webml-polyfill/milestones{/number}","notifications_url":"https://api.github.com/repos/yl495/webml-polyfill/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yl495/webml-polyfill/labels{/name}","releases_url":"https://api.github.com/repos/yl495/webml-polyfill/releases{/id}","deployments_url":"https://api.github.com/repos/yl495/webml-polyfill/deployments","created_at":"2018-06-05T06:15:28Z","updated_at":"2018-07-20T10:24:10Z","pushed_at":"2018-07-20T10:24:08Z","git_url":"git://github.com/yl495/webml-polyfill.git","ssh_url":"[email protected]:yl495/webml-polyfill.git","clone_url":"https://github.com/yl495/webml-polyfill.git","svn_url":"https://github.com/yl495/webml-polyfill","homepage":null,"size":3834,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"intel:master","ref":"master","sha":"be6d3ef08896964a82e6afe80b796d037f1d5ad5","user":{"login":"intel","id":17888862,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3ODg4ODYy","avatar_url":"https://avatars3.githubusercontent.com/u/17888862?v=4","gravatar_id":"","url":"https://api.github.com/users/intel","html_url":"https://github.com/intel","followers_url":"https://api.github.com/users/intel/followers","following_url":"https://api.github.com/users/intel/following{/other_user}","gists_url":"https://api.github.com/users/intel/gists{/gist_id}","starred_url":"https://api.github.com/users/intel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/intel/subscriptions","organizations_url":"https://api.github.com/users/intel/orgs","repos_url":"https://api.github.com/users/intel/repos","events_url":"https://api.github.com/users/intel/events{/privacy}","received_events_url":"https://api.github.com/users/intel/received_events","type":"Organization","site_admin":false},"repo":{"id":126892425,"node_id":"MDEwOlJlcG9zaXRvcnkxMjY4OTI0MjU=","name":"webml-polyfill","full_name":"intel/webml-polyfill","owner":{"login":"intel","id":17888862,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3ODg4ODYy","avatar_url":"https://avatars3.githubusercontent.com/u/17888862?v=4","gravatar_id":"","url":"https://api.github.com/users/intel","html_url":"https://github.com/intel","followers_url":"https://api.github.com/users/intel/followers","following_url":"https://api.github.com/users/intel/following{/other_user}","gists_url":"https://api.github.com/users/intel/gists{/gist_id}","starred_url":"https://api.github.com/users/intel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/intel/subscriptions","organizations_url":"https://api.github.com/users/intel/orgs","repos_url":"https://api.github.com/users/intel/repos","events_url":"https://api.github.com/users/intel/events{/privacy}","received_events_url":"https://api.github.com/users/intel/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/intel/webml-polyfill","description":null,"fork":false,"url":"https://api.github.com/repos/intel/webml-polyfill","forks_url":"https://api.github.com/repos/intel/webml-polyfill/forks","keys_url":"https://api.github.com/repos/intel/webml-polyfill/keys{/key_id}","collaborators_url":"https://api.github.com/repos/intel/webml-polyfill/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/intel/webml-polyfill/teams","hooks_url":"https://api.github.com/repos/intel/webml-polyfill/hooks","issue_events_url":"https://api.github.com/repos/intel/webml-polyfill/issues/events{/number}","events_url":"https://api.github.com/repos/intel/webml-polyfill/events","assignees_url":"https://api.github.com/repos/intel/webml-polyfill/assignees{/user}","branches_url":"https://api.github.com/repos/intel/webml-polyfill/branches{/branch}","tags_url":"https://api.github.com/repos/intel/webml-polyfill/tags","blobs_url":"https://api.github.com/repos/intel/webml-polyfill/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/intel/webml-polyfill/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/intel/webml-polyfill/git/refs{/sha}","trees_url":"https://api.github.com/repos/intel/webml-polyfill/git/trees{/sha}","statuses_url":"https://api.github.com/repos/intel/webml-polyfill/statuses/{sha}","languages_url":"https://api.github.com/repos/intel/webml-polyfill/languages","stargazers_url":"https://api.github.com/repos/intel/webml-polyfill/stargazers","contributors_url":"https://api.github.com/repos/intel/webml-polyfill/contributors","subscribers_url":"https://api.github.com/repos/intel/webml-polyfill/subscribers","subscription_url":"https://api.github.com/repos/intel/webml-polyfill/subscription","commits_url":"https://api.github.com/repos/intel/webml-polyfill/commits{/sha}","git_commits_url":"https://api.github.com/repos/intel/webml-polyfill/git/commits{/sha}","comments_url":"https://api.github.com/repos/intel/webml-polyfill/comments{/number}","issue_comment_url":"https://api.github.com/repos/intel/webml-polyfill/issues/comments{/number}","contents_url":"https://api.github.com/repos/intel/webml-polyfill/contents/{+path}","compare_url":"https://api.github.com/repos/intel/webml-polyfill/compare/{base}...{head}","merges_url":"https://api.github.com/repos/intel/webml-polyfill/merges","archive_url":"https://api.github.com/repos/intel/webml-polyfill/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/intel/webml-polyfill/downloads","issues_url":"https://api.github.com/repos/intel/webml-polyfill/issues{/number}","pulls_url":"https://api.github.com/repos/intel/webml-polyfill/pulls{/number}","milestones_url":"https://api.github.com/repos/intel/webml-polyfill/milestones{/number}","notifications_url":"https://api.github.com/repos/intel/webml-polyfill/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/intel/webml-polyfill/labels{/name}","releases_url":"https://api.github.com/repos/intel/webml-polyfill/releases{/id}","deployments_url":"https://api.github.com/repos/intel/webml-polyfill/deployments","created_at":"2018-03-26T21:31:32Z","updated_at":"2018-07-22T23:18:33Z","pushed_at":"2018-07-22T23:18:31Z","git_url":"git://github.com/intel/webml-polyfill.git","ssh_url":"[email protected]:intel/webml-polyfill.git","clone_url":"https://github.com/intel/webml-polyfill.git","svn_url":"https://github.com/intel/webml-polyfill","homepage":null,"size":9408,"stargazers_count":13,"watchers_count":13,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"archived":false,"open_issues_count":42,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":12,"open_issues":42,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/intel/webml-polyfill/pulls/82"},"html":{"href":"https://github.com/intel/webml-polyfill/pull/82"},"issue":{"href":"https://api.github.com/repos/intel/webml-polyfill/issues/82"},"comments":{"href":"https://api.github.com/repos/intel/webml-polyfill/issues/82/comments"},"review_comments":{"href":"https://api.github.com/repos/intel/webml-polyfill/pulls/82/comments"},"review_comment":{"href":"https://api.github.com/repos/intel/webml-polyfill/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/intel/webml-polyfill/pulls/82/commits"},"statuses":{"href":"https://api.github.com/repos/intel/webml-polyfill/statuses/a9bb904a62832b15836a4fec0366b82d8dd69c96"}},"author_association":"CONTRIBUTOR"}} | {
"id": 126892425,
"name": "intel/webml-polyfill",
"url": "https://api.github.com/repos/intel/webml-polyfill"
} | {
"id": 1005673,
"login": "huningxin",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1005673?",
"url": "https://api.github.com/users/huningxin"
} | {
"id": 17888862,
"login": "intel",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/17888862?",
"url": "https://api.github.com/orgs/intel"
} | 2018-07-23T02:08:17 | 8001371006 | {"actor":{"display_login":"huningxin"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/certbot/certbot/pulls/comments/185296624","pull_request_review_id":116656176,"id":185296624,"diff_hunk":"@@ -0,0 +1,65 @@\n+\"\"\"","path":"acme/acme/str_utils.py","position":1,"original_position":1,"commit_id":"9eb2bff2629579002aac1f6c90c3840421156669","original_commit_id":"9eb2bff2629579002aac1f6c90c3840421156669","user":{"login":"bmw","id":6504915,"avatar_url":"https://avatars0.githubusercontent.com/u/6504915?v=4","gravatar_id":"","url":"https://api.github.com/users/bmw","html_url":"https://github.com/bmw","followers_url":"https://api.github.com/users/bmw/followers","following_url":"https://api.github.com/users/bmw/following{/other_user}","gists_url":"https://api.github.com/users/bmw/gists{/gist_id}","starred_url":"https://api.github.com/users/bmw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmw/subscriptions","organizations_url":"https://api.github.com/users/bmw/orgs","repos_url":"https://api.github.com/users/bmw/repos","events_url":"https://api.github.com/users/bmw/events{/privacy}","received_events_url":"https://api.github.com/users/bmw/received_events","type":"User","site_admin":false},"body":"I agree with you that `decode` and `encode` could have been designed better. I just think they are very common when writing Python 3 programs and people with experience dealing with I/O in Python 3 will have learned to use these methods before while everyone who works on that part of Certbot would have to learn about our custom methods.\r\n\r\nAgain, I'm not against you adding these utility methods, I just think always using them when we know the type is a bad idea.\r\n\r\nAs for that specific issue, I think it luckily doesn't really affect us because our code has to work in Python 2 and 3 where there is no `unicode` type and `str` and `bytes` only have `encode` and `decode` respectively. By having to make our code work in both, I think we avoid the situation of calling `decode` on a `unicode` object or `encode` on a `str` because the equivalent types in Python 3 (`str` and `bytes` respectively) don't have those methods.","created_at":"2018-05-01T18:30:47Z","updated_at":"2018-05-01T18:30:47Z","html_url":"https://github.com/certbot/certbot/pull/5874#discussion_r185296624","pull_request_url":"https://api.github.com/repos/certbot/certbot/pulls/5874","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/certbot/certbot/pulls/comments/185296624"},"html":{"href":"https://github.com/certbot/certbot/pull/5874#discussion_r185296624"},"pull_request":{"href":"https://api.github.com/repos/certbot/certbot/pulls/5874"}},"in_reply_to_id":182602797},"pull_request":{"url":"https://api.github.com/repos/certbot/certbot/pulls/5874","id":181600416,"html_url":"https://github.com/certbot/certbot/pull/5874","diff_url":"https://github.com/certbot/certbot/pull/5874.diff","patch_url":"https://github.com/certbot/certbot/pull/5874.patch","issue_url":"https://api.github.com/repos/certbot/certbot/issues/5874","number":5874,"state":"open","locked":false,"title":"Check_untyped_defs in mypy with clean output for acme","user":{"login":"ohemorange","id":1227205,"avatar_url":"https://avatars0.githubusercontent.com/u/1227205?v=4","gravatar_id":"","url":"https://api.github.com/users/ohemorange","html_url":"https://github.com/ohemorange","followers_url":"https://api.github.com/users/ohemorange/followers","following_url":"https://api.github.com/users/ohemorange/following{/other_user}","gists_url":"https://api.github.com/users/ohemorange/gists{/gist_id}","starred_url":"https://api.github.com/users/ohemorange/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ohemorange/subscriptions","organizations_url":"https://api.github.com/users/ohemorange/orgs","repos_url":"https://api.github.com/users/ohemorange/repos","events_url":"https://api.github.com/users/ohemorange/events{/privacy}","received_events_url":"https://api.github.com/users/ohemorange/received_events","type":"User","site_admin":false},"body":"Part of #5850.","created_at":"2018-04-13T21:29:59Z","updated_at":"2018-05-01T18:30:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"421acccfe253b07ef8082d9a9f70e37f47c6bf7f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/certbot/certbot/milestones/52","html_url":"https://github.com/certbot/certbot/milestone/52","labels_url":"https://api.github.com/repos/certbot/certbot/milestones/52/labels","id":3194336,"number":52,"title":"0.24.0","description":"","creator":{"login":"bmw","id":6504915,"avatar_url":"https://avatars0.githubusercontent.com/u/6504915?v=4","gravatar_id":"","url":"https://api.github.com/users/bmw","html_url":"https://github.com/bmw","followers_url":"https://api.github.com/users/bmw/followers","following_url":"https://api.github.com/users/bmw/following{/other_user}","gists_url":"https://api.github.com/users/bmw/gists{/gist_id}","starred_url":"https://api.github.com/users/bmw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmw/subscriptions","organizations_url":"https://api.github.com/users/bmw/orgs","repos_url":"https://api.github.com/users/bmw/repos","events_url":"https://api.github.com/users/bmw/events{/privacy}","received_events_url":"https://api.github.com/users/bmw/received_events","type":"User","site_admin":false},"open_issues":32,"closed_issues":13,"state":"open","created_at":"2018-03-16T20:10:48Z","updated_at":"2018-04-26T00:22:29Z","due_on":"2018-05-02T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/certbot/certbot/pulls/5874/commits","review_comments_url":"https://api.github.com/repos/certbot/certbot/pulls/5874/comments","review_comment_url":"https://api.github.com/repos/certbot/certbot/pulls/comments{/number}","comments_url":"https://api.github.com/repos/certbot/certbot/issues/5874/comments","statuses_url":"https://api.github.com/repos/certbot/certbot/statuses/9eb2bff2629579002aac1f6c90c3840421156669","head":{"label":"certbot:mypy-acme","ref":"mypy-acme","sha":"9eb2bff2629579002aac1f6c90c3840421156669","user":{"login":"certbot","id":17889013,"avatar_url":"https://avatars2.githubusercontent.com/u/17889013?v=4","gravatar_id":"","url":"https://api.github.com/users/certbot","html_url":"https://github.com/certbot","followers_url":"https://api.github.com/users/certbot/followers","following_url":"https://api.github.com/users/certbot/following{/other_user}","gists_url":"https://api.github.com/users/certbot/gists{/gist_id}","starred_url":"https://api.github.com/users/certbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/certbot/subscriptions","organizations_url":"https://api.github.com/users/certbot/orgs","repos_url":"https://api.github.com/users/certbot/repos","events_url":"https://api.github.com/users/certbot/events{/privacy}","received_events_url":"https://api.github.com/users/certbot/received_events","type":"Organization","site_admin":false},"repo":{"id":26516210,"name":"certbot","full_name":"certbot/certbot","owner":{"login":"certbot","id":17889013,"avatar_url":"https://avatars2.githubusercontent.com/u/17889013?v=4","gravatar_id":"","url":"https://api.github.com/users/certbot","html_url":"https://github.com/certbot","followers_url":"https://api.github.com/users/certbot/followers","following_url":"https://api.github.com/users/certbot/following{/other_user}","gists_url":"https://api.github.com/users/certbot/gists{/gist_id}","starred_url":"https://api.github.com/users/certbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/certbot/subscriptions","organizations_url":"https://api.github.com/users/certbot/orgs","repos_url":"https://api.github.com/users/certbot/repos","events_url":"https://api.github.com/users/certbot/events{/privacy}","received_events_url":"https://api.github.com/users/certbot/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/certbot/certbot","description":"Certbot is EFF's tool to obtain certs from Let's Encrypt and (optionally) auto-enable HTTPS on your server. It can also act as a client for any other CA that uses the ACME protocol.","fork":false,"url":"https://api.github.com/repos/certbot/certbot","forks_url":"https://api.github.com/repos/certbot/certbot/forks","keys_url":"https://api.github.com/repos/certbot/certbot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/certbot/certbot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/certbot/certbot/teams","hooks_url":"https://api.github.com/repos/certbot/certbot/hooks","issue_events_url":"https://api.github.com/repos/certbot/certbot/issues/events{/number}","events_url":"https://api.github.com/repos/certbot/certbot/events","assignees_url":"https://api.github.com/repos/certbot/certbot/assignees{/user}","branches_url":"https://api.github.com/repos/certbot/certbot/branches{/branch}","tags_url":"https://api.github.com/repos/certbot/certbot/tags","blobs_url":"https://api.github.com/repos/certbot/certbot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/certbot/certbot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/certbot/certbot/git/refs{/sha}","trees_url":"https://api.github.com/repos/certbot/certbot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/certbot/certbot/statuses/{sha}","languages_url":"https://api.github.com/repos/certbot/certbot/languages","stargazers_url":"https://api.github.com/repos/certbot/certbot/stargazers","contributors_url":"https://api.github.com/repos/certbot/certbot/contributors","subscribers_url":"https://api.github.com/repos/certbot/certbot/subscribers","subscription_url":"https://api.github.com/repos/certbot/certbot/subscription","commits_url":"https://api.github.com/repos/certbot/certbot/commits{/sha}","git_commits_url":"https://api.github.com/repos/certbot/certbot/git/commits{/sha}","comments_url":"https://api.github.com/repos/certbot/certbot/comments{/number}","issue_comment_url":"https://api.github.com/repos/certbot/certbot/issues/comments{/number}","contents_url":"https://api.github.com/repos/certbot/certbot/contents/{+path}","compare_url":"https://api.github.com/repos/certbot/certbot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/certbot/certbot/merges","archive_url":"https://api.github.com/repos/certbot/certbot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/certbot/certbot/downloads","issues_url":"https://api.github.com/repos/certbot/certbot/issues{/number}","pulls_url":"https://api.github.com/repos/certbot/certbot/pulls{/number}","milestones_url":"https://api.github.com/repos/certbot/certbot/milestones{/number}","notifications_url":"https://api.github.com/repos/certbot/certbot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/certbot/certbot/labels{/name}","releases_url":"https://api.github.com/repos/certbot/certbot/releases{/id}","deployments_url":"https://api.github.com/repos/certbot/certbot/deployments","created_at":"2014-11-12T02:52:20Z","updated_at":"2018-05-01T18:08:09Z","pushed_at":"2018-05-01T07:38:37Z","git_url":"git://github.com/certbot/certbot.git","ssh_url":"[email protected]:certbot/certbot.git","clone_url":"https://github.com/certbot/certbot.git","svn_url":"https://github.com/certbot/certbot","homepage":"","size":18543,"stargazers_count":22009,"watchers_count":22009,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2082,"mirror_url":null,"archived":false,"open_issues_count":980,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":2082,"open_issues":980,"watchers":22009,"default_branch":"master"}},"base":{"label":"certbot:master","ref":"master","sha":"a9e01ade4c2d42d48e6e9a77d975a28d7f0533b9","user":{"login":"certbot","id":17889013,"avatar_url":"https://avatars2.githubusercontent.com/u/17889013?v=4","gravatar_id":"","url":"https://api.github.com/users/certbot","html_url":"https://github.com/certbot","followers_url":"https://api.github.com/users/certbot/followers","following_url":"https://api.github.com/users/certbot/following{/other_user}","gists_url":"https://api.github.com/users/certbot/gists{/gist_id}","starred_url":"https://api.github.com/users/certbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/certbot/subscriptions","organizations_url":"https://api.github.com/users/certbot/orgs","repos_url":"https://api.github.com/users/certbot/repos","events_url":"https://api.github.com/users/certbot/events{/privacy}","received_events_url":"https://api.github.com/users/certbot/received_events","type":"Organization","site_admin":false},"repo":{"id":26516210,"name":"certbot","full_name":"certbot/certbot","owner":{"login":"certbot","id":17889013,"avatar_url":"https://avatars2.githubusercontent.com/u/17889013?v=4","gravatar_id":"","url":"https://api.github.com/users/certbot","html_url":"https://github.com/certbot","followers_url":"https://api.github.com/users/certbot/followers","following_url":"https://api.github.com/users/certbot/following{/other_user}","gists_url":"https://api.github.com/users/certbot/gists{/gist_id}","starred_url":"https://api.github.com/users/certbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/certbot/subscriptions","organizations_url":"https://api.github.com/users/certbot/orgs","repos_url":"https://api.github.com/users/certbot/repos","events_url":"https://api.github.com/users/certbot/events{/privacy}","received_events_url":"https://api.github.com/users/certbot/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/certbot/certbot","description":"Certbot is EFF's tool to obtain certs from Let's Encrypt and (optionally) auto-enable HTTPS on your server. It can also act as a client for any other CA that uses the ACME protocol.","fork":false,"url":"https://api.github.com/repos/certbot/certbot","forks_url":"https://api.github.com/repos/certbot/certbot/forks","keys_url":"https://api.github.com/repos/certbot/certbot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/certbot/certbot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/certbot/certbot/teams","hooks_url":"https://api.github.com/repos/certbot/certbot/hooks","issue_events_url":"https://api.github.com/repos/certbot/certbot/issues/events{/number}","events_url":"https://api.github.com/repos/certbot/certbot/events","assignees_url":"https://api.github.com/repos/certbot/certbot/assignees{/user}","branches_url":"https://api.github.com/repos/certbot/certbot/branches{/branch}","tags_url":"https://api.github.com/repos/certbot/certbot/tags","blobs_url":"https://api.github.com/repos/certbot/certbot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/certbot/certbot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/certbot/certbot/git/refs{/sha}","trees_url":"https://api.github.com/repos/certbot/certbot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/certbot/certbot/statuses/{sha}","languages_url":"https://api.github.com/repos/certbot/certbot/languages","stargazers_url":"https://api.github.com/repos/certbot/certbot/stargazers","contributors_url":"https://api.github.com/repos/certbot/certbot/contributors","subscribers_url":"https://api.github.com/repos/certbot/certbot/subscribers","subscription_url":"https://api.github.com/repos/certbot/certbot/subscription","commits_url":"https://api.github.com/repos/certbot/certbot/commits{/sha}","git_commits_url":"https://api.github.com/repos/certbot/certbot/git/commits{/sha}","comments_url":"https://api.github.com/repos/certbot/certbot/comments{/number}","issue_comment_url":"https://api.github.com/repos/certbot/certbot/issues/comments{/number}","contents_url":"https://api.github.com/repos/certbot/certbot/contents/{+path}","compare_url":"https://api.github.com/repos/certbot/certbot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/certbot/certbot/merges","archive_url":"https://api.github.com/repos/certbot/certbot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/certbot/certbot/downloads","issues_url":"https://api.github.com/repos/certbot/certbot/issues{/number}","pulls_url":"https://api.github.com/repos/certbot/certbot/pulls{/number}","milestones_url":"https://api.github.com/repos/certbot/certbot/milestones{/number}","notifications_url":"https://api.github.com/repos/certbot/certbot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/certbot/certbot/labels{/name}","releases_url":"https://api.github.com/repos/certbot/certbot/releases{/id}","deployments_url":"https://api.github.com/repos/certbot/certbot/deployments","created_at":"2014-11-12T02:52:20Z","updated_at":"2018-05-01T18:08:09Z","pushed_at":"2018-05-01T07:38:37Z","git_url":"git://github.com/certbot/certbot.git","ssh_url":"[email protected]:certbot/certbot.git","clone_url":"https://github.com/certbot/certbot.git","svn_url":"https://github.com/certbot/certbot","homepage":"","size":18543,"stargazers_count":22009,"watchers_count":22009,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2082,"mirror_url":null,"archived":false,"open_issues_count":980,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":2082,"open_issues":980,"watchers":22009,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/certbot/certbot/pulls/5874"},"html":{"href":"https://github.com/certbot/certbot/pull/5874"},"issue":{"href":"https://api.github.com/repos/certbot/certbot/issues/5874"},"comments":{"href":"https://api.github.com/repos/certbot/certbot/issues/5874/comments"},"review_comments":{"href":"https://api.github.com/repos/certbot/certbot/pulls/5874/comments"},"review_comment":{"href":"https://api.github.com/repos/certbot/certbot/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/certbot/certbot/pulls/5874/commits"},"statuses":{"href":"https://api.github.com/repos/certbot/certbot/statuses/9eb2bff2629579002aac1f6c90c3840421156669"}},"author_association":"CONTRIBUTOR"}} | {
"id": 26516210,
"name": "certbot/certbot",
"url": "https://api.github.com/repos/certbot/certbot"
} | {
"id": 6504915,
"login": "bmw",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6504915?",
"url": "https://api.github.com/users/bmw"
} | {
"id": 17889013,
"login": "certbot",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/17889013?",
"url": "https://api.github.com/orgs/certbot"
} | 2018-05-01T18:30:47 | 7612703053 | {"actor":{"display_login":"bmw"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/gridsome/gridsome/pulls/comments/237560851","pull_request_review_id":179889945,"id":237560851,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNzU2MDg1MQ==","diff_hunk":"@@ -0,0 +1,201 @@\n+const axios = require('axios')\n+const reduce = require('lodash.reduce')\n+const { \n+ cullByWordCount\n+} = require('./utils')\n+const slugify = require('@sindresorhus/slugify')\n+const Nodes = require('./entities/Nodes')\n+const TaxonomyTerms = require('./entities/TaxonomyTerms')\n+const Files = require('./entities/Files')\n+const Users = require('./entities/Users')\n+\n+\n+class DrupalSource {\n+ // defaultOptions merged with this.options in App.vue\n+ static defaultOptions() {\n+ return {\n+ baseUrl: '',\n+ views: [], // deprecated\n+ entities: [],","path":"packages/source-drupal/src/DrupalSource.js","position":19,"original_position":19,"commit_id":"4250bf2e346da0a731e9d4ebbcd456a9d7d0257b","original_commit_id":"4250bf2e346da0a731e9d4ebbcd456a9d7d0257b","user":{"login":"matt-e-king","id":3094245,"node_id":"MDQ6VXNlcjMwOTQyNDU=","avatar_url":"https://avatars0.githubusercontent.com/u/3094245?v=4","gravatar_id":"","url":"https://api.github.com/users/matt-e-king","html_url":"https://github.com/matt-e-king","followers_url":"https://api.github.com/users/matt-e-king/followers","following_url":"https://api.github.com/users/matt-e-king/following{/other_user}","gists_url":"https://api.github.com/users/matt-e-king/gists{/gist_id}","starred_url":"https://api.github.com/users/matt-e-king/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matt-e-king/subscriptions","organizations_url":"https://api.github.com/users/matt-e-king/orgs","repos_url":"https://api.github.com/users/matt-e-king/repos","events_url":"https://api.github.com/users/matt-e-king/events{/privacy}","received_events_url":"https://api.github.com/users/matt-e-king/received_events","type":"User","site_admin":false},"body":"@hjvedvik the `defaultsDeep` in App.js that merges the `defaultOptions` with the user options doesn't do a concat of the Array. It replaces the `indexes`.\r\n\r\nDoes this need to be adjust in App.js first?","created_at":"2018-11-29T16:29:37Z","updated_at":"2018-11-29T16:29:38Z","html_url":"https://github.com/gridsome/gridsome/pull/41#discussion_r237560851","pull_request_url":"https://api.github.com/repos/gridsome/gridsome/pulls/41","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/gridsome/gridsome/pulls/comments/237560851"},"html":{"href":"https://github.com/gridsome/gridsome/pull/41#discussion_r237560851"},"pull_request":{"href":"https://api.github.com/repos/gridsome/gridsome/pulls/41"}},"in_reply_to_id":237548711},"pull_request":{"url":"https://api.github.com/repos/gridsome/gridsome/pulls/41","id":231340294,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxMzQwMjk0","html_url":"https://github.com/gridsome/gridsome/pull/41","diff_url":"https://github.com/gridsome/gridsome/pull/41.diff","patch_url":"https://github.com/gridsome/gridsome/pull/41.patch","issue_url":"https://api.github.com/repos/gridsome/gridsome/issues/41","number":41,"state":"open","locked":false,"title":"@gridsome/source-drupal","user":{"login":"matt-e-king","id":3094245,"node_id":"MDQ6VXNlcjMwOTQyNDU=","avatar_url":"https://avatars0.githubusercontent.com/u/3094245?v=4","gravatar_id":"","url":"https://api.github.com/users/matt-e-king","html_url":"https://github.com/matt-e-king","followers_url":"https://api.github.com/users/matt-e-king/followers","following_url":"https://api.github.com/users/matt-e-king/following{/other_user}","gists_url":"https://api.github.com/users/matt-e-king/gists{/gist_id}","starred_url":"https://api.github.com/users/matt-e-king/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matt-e-king/subscriptions","organizations_url":"https://api.github.com/users/matt-e-king/orgs","repos_url":"https://api.github.com/users/matt-e-king/repos","events_url":"https://api.github.com/users/matt-e-king/events{/privacy}","received_events_url":"https://api.github.com/users/matt-e-king/received_events","type":"User","site_admin":false},"body":"https://github.com/gridsome/gridsome/issues/40\r\n","created_at":"2018-11-15T21:29:12Z","updated_at":"2018-11-29T16:29:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"72f2b2d3ec9592524184abdc9ec0ee2bc4e74bb1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/gridsome/gridsome/pulls/41/commits","review_comments_url":"https://api.github.com/repos/gridsome/gridsome/pulls/41/comments","review_comment_url":"https://api.github.com/repos/gridsome/gridsome/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gridsome/gridsome/issues/41/comments","statuses_url":"https://api.github.com/repos/gridsome/gridsome/statuses/4250bf2e346da0a731e9d4ebbcd456a9d7d0257b","head":{"label":"matt-e-king:source-drupal","ref":"source-drupal","sha":"4250bf2e346da0a731e9d4ebbcd456a9d7d0257b","user":{"login":"matt-e-king","id":3094245,"node_id":"MDQ6VXNlcjMwOTQyNDU=","avatar_url":"https://avatars0.githubusercontent.com/u/3094245?v=4","gravatar_id":"","url":"https://api.github.com/users/matt-e-king","html_url":"https://github.com/matt-e-king","followers_url":"https://api.github.com/users/matt-e-king/followers","following_url":"https://api.github.com/users/matt-e-king/following{/other_user}","gists_url":"https://api.github.com/users/matt-e-king/gists{/gist_id}","starred_url":"https://api.github.com/users/matt-e-king/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matt-e-king/subscriptions","organizations_url":"https://api.github.com/users/matt-e-king/orgs","repos_url":"https://api.github.com/users/matt-e-king/repos","events_url":"https://api.github.com/users/matt-e-king/events{/privacy}","received_events_url":"https://api.github.com/users/matt-e-king/received_events","type":"User","site_admin":false},"repo":{"id":157770930,"node_id":"MDEwOlJlcG9zaXRvcnkxNTc3NzA5MzA=","name":"gridsome","full_name":"matt-e-king/gridsome","private":false,"owner":{"login":"matt-e-king","id":3094245,"node_id":"MDQ6VXNlcjMwOTQyNDU=","avatar_url":"https://avatars0.githubusercontent.com/u/3094245?v=4","gravatar_id":"","url":"https://api.github.com/users/matt-e-king","html_url":"https://github.com/matt-e-king","followers_url":"https://api.github.com/users/matt-e-king/followers","following_url":"https://api.github.com/users/matt-e-king/following{/other_user}","gists_url":"https://api.github.com/users/matt-e-king/gists{/gist_id}","starred_url":"https://api.github.com/users/matt-e-king/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matt-e-king/subscriptions","organizations_url":"https://api.github.com/users/matt-e-king/orgs","repos_url":"https://api.github.com/users/matt-e-king/repos","events_url":"https://api.github.com/users/matt-e-king/events{/privacy}","received_events_url":"https://api.github.com/users/matt-e-king/received_events","type":"User","site_admin":false},"html_url":"https://github.com/matt-e-king/gridsome","description":"⚡️ [WIP] Build blazing fast websites for any CMS or data with Vue.js","fork":true,"url":"https://api.github.com/repos/matt-e-king/gridsome","forks_url":"https://api.github.com/repos/matt-e-king/gridsome/forks","keys_url":"https://api.github.com/repos/matt-e-king/gridsome/keys{/key_id}","collaborators_url":"https://api.github.com/repos/matt-e-king/gridsome/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/matt-e-king/gridsome/teams","hooks_url":"https://api.github.com/repos/matt-e-king/gridsome/hooks","issue_events_url":"https://api.github.com/repos/matt-e-king/gridsome/issues/events{/number}","events_url":"https://api.github.com/repos/matt-e-king/gridsome/events","assignees_url":"https://api.github.com/repos/matt-e-king/gridsome/assignees{/user}","branches_url":"https://api.github.com/repos/matt-e-king/gridsome/branches{/branch}","tags_url":"https://api.github.com/repos/matt-e-king/gridsome/tags","blobs_url":"https://api.github.com/repos/matt-e-king/gridsome/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/matt-e-king/gridsome/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/matt-e-king/gridsome/git/refs{/sha}","trees_url":"https://api.github.com/repos/matt-e-king/gridsome/git/trees{/sha}","statuses_url":"https://api.github.com/repos/matt-e-king/gridsome/statuses/{sha}","languages_url":"https://api.github.com/repos/matt-e-king/gridsome/languages","stargazers_url":"https://api.github.com/repos/matt-e-king/gridsome/stargazers","contributors_url":"https://api.github.com/repos/matt-e-king/gridsome/contributors","subscribers_url":"https://api.github.com/repos/matt-e-king/gridsome/subscribers","subscription_url":"https://api.github.com/repos/matt-e-king/gridsome/subscription","commits_url":"https://api.github.com/repos/matt-e-king/gridsome/commits{/sha}","git_commits_url":"https://api.github.com/repos/matt-e-king/gridsome/git/commits{/sha}","comments_url":"https://api.github.com/repos/matt-e-king/gridsome/comments{/number}","issue_comment_url":"https://api.github.com/repos/matt-e-king/gridsome/issues/comments{/number}","contents_url":"https://api.github.com/repos/matt-e-king/gridsome/contents/{+path}","compare_url":"https://api.github.com/repos/matt-e-king/gridsome/compare/{base}...{head}","merges_url":"https://api.github.com/repos/matt-e-king/gridsome/merges","archive_url":"https://api.github.com/repos/matt-e-king/gridsome/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/matt-e-king/gridsome/downloads","issues_url":"https://api.github.com/repos/matt-e-king/gridsome/issues{/number}","pulls_url":"https://api.github.com/repos/matt-e-king/gridsome/pulls{/number}","milestones_url":"https://api.github.com/repos/matt-e-king/gridsome/milestones{/number}","notifications_url":"https://api.github.com/repos/matt-e-king/gridsome/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/matt-e-king/gridsome/labels{/name}","releases_url":"https://api.github.com/repos/matt-e-king/gridsome/releases{/id}","deployments_url":"https://api.github.com/repos/matt-e-king/gridsome/deployments","created_at":"2018-11-15T20:49:48Z","updated_at":"2018-11-15T20:49:51Z","pushed_at":"2018-11-28T18:22:26Z","git_url":"git://github.com/matt-e-king/gridsome.git","ssh_url":"[email protected]:matt-e-king/gridsome.git","clone_url":"https://github.com/matt-e-king/gridsome.git","svn_url":"https://github.com/matt-e-king/gridsome","homepage":"https://gridsome.org","size":1032,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"gridsome:master","ref":"master","sha":"6dd3321d62165f9c63eba1804a4310dd4a667ec3","user":{"login":"gridsome","id":17981963,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3OTgxOTYz","avatar_url":"https://avatars2.githubusercontent.com/u/17981963?v=4","gravatar_id":"","url":"https://api.github.com/users/gridsome","html_url":"https://github.com/gridsome","followers_url":"https://api.github.com/users/gridsome/followers","following_url":"https://api.github.com/users/gridsome/following{/other_user}","gists_url":"https://api.github.com/users/gridsome/gists{/gist_id}","starred_url":"https://api.github.com/users/gridsome/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gridsome/subscriptions","organizations_url":"https://api.github.com/users/gridsome/orgs","repos_url":"https://api.github.com/users/gridsome/repos","events_url":"https://api.github.com/users/gridsome/events{/privacy}","received_events_url":"https://api.github.com/users/gridsome/received_events","type":"Organization","site_admin":false},"repo":{"id":143078055,"node_id":"MDEwOlJlcG9zaXRvcnkxNDMwNzgwNTU=","name":"gridsome","full_name":"gridsome/gridsome","private":false,"owner":{"login":"gridsome","id":17981963,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3OTgxOTYz","avatar_url":"https://avatars2.githubusercontent.com/u/17981963?v=4","gravatar_id":"","url":"https://api.github.com/users/gridsome","html_url":"https://github.com/gridsome","followers_url":"https://api.github.com/users/gridsome/followers","following_url":"https://api.github.com/users/gridsome/following{/other_user}","gists_url":"https://api.github.com/users/gridsome/gists{/gist_id}","starred_url":"https://api.github.com/users/gridsome/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gridsome/subscriptions","organizations_url":"https://api.github.com/users/gridsome/orgs","repos_url":"https://api.github.com/users/gridsome/repos","events_url":"https://api.github.com/users/gridsome/events{/privacy}","received_events_url":"https://api.github.com/users/gridsome/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/gridsome/gridsome","description":"⚡️ [WIP] Build blazing fast websites for any CMS or data with Vue.js","fork":false,"url":"https://api.github.com/repos/gridsome/gridsome","forks_url":"https://api.github.com/repos/gridsome/gridsome/forks","keys_url":"https://api.github.com/repos/gridsome/gridsome/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gridsome/gridsome/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gridsome/gridsome/teams","hooks_url":"https://api.github.com/repos/gridsome/gridsome/hooks","issue_events_url":"https://api.github.com/repos/gridsome/gridsome/issues/events{/number}","events_url":"https://api.github.com/repos/gridsome/gridsome/events","assignees_url":"https://api.github.com/repos/gridsome/gridsome/assignees{/user}","branches_url":"https://api.github.com/repos/gridsome/gridsome/branches{/branch}","tags_url":"https://api.github.com/repos/gridsome/gridsome/tags","blobs_url":"https://api.github.com/repos/gridsome/gridsome/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gridsome/gridsome/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gridsome/gridsome/git/refs{/sha}","trees_url":"https://api.github.com/repos/gridsome/gridsome/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gridsome/gridsome/statuses/{sha}","languages_url":"https://api.github.com/repos/gridsome/gridsome/languages","stargazers_url":"https://api.github.com/repos/gridsome/gridsome/stargazers","contributors_url":"https://api.github.com/repos/gridsome/gridsome/contributors","subscribers_url":"https://api.github.com/repos/gridsome/gridsome/subscribers","subscription_url":"https://api.github.com/repos/gridsome/gridsome/subscription","commits_url":"https://api.github.com/repos/gridsome/gridsome/commits{/sha}","git_commits_url":"https://api.github.com/repos/gridsome/gridsome/git/commits{/sha}","comments_url":"https://api.github.com/repos/gridsome/gridsome/comments{/number}","issue_comment_url":"https://api.github.com/repos/gridsome/gridsome/issues/comments{/number}","contents_url":"https://api.github.com/repos/gridsome/gridsome/contents/{+path}","compare_url":"https://api.github.com/repos/gridsome/gridsome/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gridsome/gridsome/merges","archive_url":"https://api.github.com/repos/gridsome/gridsome/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gridsome/gridsome/downloads","issues_url":"https://api.github.com/repos/gridsome/gridsome/issues{/number}","pulls_url":"https://api.github.com/repos/gridsome/gridsome/pulls{/number}","milestones_url":"https://api.github.com/repos/gridsome/gridsome/milestones{/number}","notifications_url":"https://api.github.com/repos/gridsome/gridsome/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gridsome/gridsome/labels{/name}","releases_url":"https://api.github.com/repos/gridsome/gridsome/releases{/id}","deployments_url":"https://api.github.com/repos/gridsome/gridsome/deployments","created_at":"2018-07-31T22:55:06Z","updated_at":"2018-11-29T14:09:10Z","pushed_at":"2018-11-29T14:09:06Z","git_url":"git://github.com/gridsome/gridsome.git","ssh_url":"[email protected]:gridsome/gridsome.git","clone_url":"https://github.com/gridsome/gridsome.git","svn_url":"https://github.com/gridsome/gridsome","homepage":"https://gridsome.org","size":1158,"stargazers_count":1177,"watchers_count":1177,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":40,"mirror_url":null,"archived":false,"open_issues_count":31,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":40,"open_issues":31,"watchers":1177,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gridsome/gridsome/pulls/41"},"html":{"href":"https://github.com/gridsome/gridsome/pull/41"},"issue":{"href":"https://api.github.com/repos/gridsome/gridsome/issues/41"},"comments":{"href":"https://api.github.com/repos/gridsome/gridsome/issues/41/comments"},"review_comments":{"href":"https://api.github.com/repos/gridsome/gridsome/pulls/41/comments"},"review_comment":{"href":"https://api.github.com/repos/gridsome/gridsome/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gridsome/gridsome/pulls/41/commits"},"statuses":{"href":"https://api.github.com/repos/gridsome/gridsome/statuses/4250bf2e346da0a731e9d4ebbcd456a9d7d0257b"}},"author_association":"NONE"}} | {
"id": 143078055,
"name": "gridsome/gridsome",
"url": "https://api.github.com/repos/gridsome/gridsome"
} | {
"id": 3094245,
"login": "matt-e-king",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3094245?",
"url": "https://api.github.com/users/matt-e-king"
} | {
"id": 17981963,
"login": "gridsome",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/17981963?",
"url": "https://api.github.com/orgs/gridsome"
} | 2018-11-29T16:29:37 | 8670432993 | {"actor":{"display_login":"matt-e-king"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/3mdeb/edk2-platforms/pulls/comments/221909258","pull_request_review_id":160668686,"id":221909258,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMTkwOTI1OA==","diff_hunk":"@@ -1,46 +1,57 @@\n-#\r\n-#\r\n-# Copyright (c) 1999 - 2014, Intel Corporation. All rights reserved\r\n-# \r\r\n-# This program and the accompanying materials are licensed and made available under\r\r\n-# the terms and conditions of the BSD License that accompanies this distribution. \r\r\n-# The full text of the license may be found at \r\r\n-# http://opensource.org/licenses/bsd-license.php. \r\r\n-# \r\r\n-# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN \"AS IS\" BASIS, \r\r\n-# WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. \r\r\n-# \r\r\n-#\r\n-#\r\n-# Module Name:\r\n-#\r\n-# CpuIA32Lib.inf\r\n-#\r\n-# Abstract:\r\n-#\r\n-# Component description file for the Cpu IA32 library.\r\n-#\r\n-#--*/\r\n-\r\n-[defines]\r\n- INF_VERSION = 0x00010005\r\n- BASE_NAME = CpuIA32Lib\r\n- FILE_GUID = 98546178-64F1-4d2e-814F-6BF963DB7930\r\n- MODULE_TYPE = BASE\r\n- VERSION_STRING = 1.0\r\n- LIBRARY_CLASS = CpuIA32Lib\r\n- PI_SPECIFICATION_VERSION = 0x0001000A\r\n-\r\n-[Sources]\r\n- EfiCpuVersion.c\r\n-\r\n-[Sources.IA32]\r\n- IA32/CpuIA32.c\r\n-\r\n-[Sources.X64]\r\n- X64/Cpu.asm\r\n- X64/Cpu.S\r\n-\r\n-[Packages]\r\n- MdePkg/MdePkg.dec\r\n- Vlv2TbltDevicePkg/PlatformPkg.dec\r\n+#\n+#\n+# Copyright (c) 1999 - 2014, Intel Corporation. All rights reserved\n+# \n+\n+# This program and the accompanying materials are licensed and made available under\n+\n+# the terms and conditions of the BSD License that accompanies this distribution. \n+\n+# The full text of the license may be found at \n+\n+# http://opensource.org/licenses/bsd-license.php. \n+\n+# \n+\n+# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN \"AS IS\" BASIS, \n+\n+# WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. \n+\n+# ","path":"Vlv2TbltDevicePkg/Library/CpuIA32Lib/CpuIA32Lib.inf","position":66,"original_position":66,"commit_id":"d0ab342d6103020c08683993b0948b09c90d1838","original_commit_id":"d0ab342d6103020c08683993b0948b09c90d1838","user":{"login":"krystian-hebel","id":40995177,"node_id":"MDQ6VXNlcjQwOTk1MTc3","avatar_url":"https://avatars2.githubusercontent.com/u/40995177?v=4","gravatar_id":"","url":"https://api.github.com/users/krystian-hebel","html_url":"https://github.com/krystian-hebel","followers_url":"https://api.github.com/users/krystian-hebel/followers","following_url":"https://api.github.com/users/krystian-hebel/following{/other_user}","gists_url":"https://api.github.com/users/krystian-hebel/gists{/gist_id}","starred_url":"https://api.github.com/users/krystian-hebel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krystian-hebel/subscriptions","organizations_url":"https://api.github.com/users/krystian-hebel/orgs","repos_url":"https://api.github.com/users/krystian-hebel/repos","events_url":"https://api.github.com/users/krystian-hebel/events{/privacy}","received_events_url":"https://api.github.com/users/krystian-hebel/received_events","type":"User","site_admin":false},"body":"@pietrushnic original line endings are a mess. There are some `\\n`, `\\r\\n`, even `\\r\\r\\n`, all in one file. It is hard to edit those files without editor automatically fixing at least `\\r\\r\\n`.","created_at":"2018-10-02T11:10:02Z","updated_at":"2018-10-02T11:10:02Z","html_url":"https://github.com/3mdeb/edk2-platforms/pull/1#discussion_r221909258","pull_request_url":"https://api.github.com/repos/3mdeb/edk2-platforms/pulls/1","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/3mdeb/edk2-platforms/pulls/comments/221909258"},"html":{"href":"https://github.com/3mdeb/edk2-platforms/pull/1#discussion_r221909258"},"pull_request":{"href":"https://api.github.com/repos/3mdeb/edk2-platforms/pulls/1"}},"in_reply_to_id":219794094},"pull_request":{"url":"https://api.github.com/repos/3mdeb/edk2-platforms/pulls/1","id":217336394,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3MzM2Mzk0","html_url":"https://github.com/3mdeb/edk2-platforms/pull/1","diff_url":"https://github.com/3mdeb/edk2-platforms/pull/1.diff","patch_url":"https://github.com/3mdeb/edk2-platforms/pull/1.patch","issue_url":"https://api.github.com/repos/3mdeb/edk2-platforms/issues/1","number":1,"state":"open","locked":false,"title":"WIP: gcc ia32","user":{"login":"krystian-hebel","id":40995177,"node_id":"MDQ6VXNlcjQwOTk1MTc3","avatar_url":"https://avatars2.githubusercontent.com/u/40995177?v=4","gravatar_id":"","url":"https://api.github.com/users/krystian-hebel","html_url":"https://github.com/krystian-hebel","followers_url":"https://api.github.com/users/krystian-hebel/followers","following_url":"https://api.github.com/users/krystian-hebel/following{/other_user}","gists_url":"https://api.github.com/users/krystian-hebel/gists{/gist_id}","starred_url":"https://api.github.com/users/krystian-hebel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krystian-hebel/subscriptions","organizations_url":"https://api.github.com/users/krystian-hebel/orgs","repos_url":"https://api.github.com/users/krystian-hebel/repos","events_url":"https://api.github.com/users/krystian-hebel/events{/privacy}","received_events_url":"https://api.github.com/users/krystian-hebel/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-09-21T16:23:36Z","updated_at":"2018-10-02T11:10:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ffbfdb7a0abd75d37d9ae9f381951fe0dd723695","assignee":{"login":"krystian-hebel","id":40995177,"node_id":"MDQ6VXNlcjQwOTk1MTc3","avatar_url":"https://avatars2.githubusercontent.com/u/40995177?v=4","gravatar_id":"","url":"https://api.github.com/users/krystian-hebel","html_url":"https://github.com/krystian-hebel","followers_url":"https://api.github.com/users/krystian-hebel/followers","following_url":"https://api.github.com/users/krystian-hebel/following{/other_user}","gists_url":"https://api.github.com/users/krystian-hebel/gists{/gist_id}","starred_url":"https://api.github.com/users/krystian-hebel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krystian-hebel/subscriptions","organizations_url":"https://api.github.com/users/krystian-hebel/orgs","repos_url":"https://api.github.com/users/krystian-hebel/repos","events_url":"https://api.github.com/users/krystian-hebel/events{/privacy}","received_events_url":"https://api.github.com/users/krystian-hebel/received_events","type":"User","site_admin":false},"assignees":[{"login":"krystian-hebel","id":40995177,"node_id":"MDQ6VXNlcjQwOTk1MTc3","avatar_url":"https://avatars2.githubusercontent.com/u/40995177?v=4","gravatar_id":"","url":"https://api.github.com/users/krystian-hebel","html_url":"https://github.com/krystian-hebel","followers_url":"https://api.github.com/users/krystian-hebel/followers","following_url":"https://api.github.com/users/krystian-hebel/following{/other_user}","gists_url":"https://api.github.com/users/krystian-hebel/gists{/gist_id}","starred_url":"https://api.github.com/users/krystian-hebel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krystian-hebel/subscriptions","organizations_url":"https://api.github.com/users/krystian-hebel/orgs","repos_url":"https://api.github.com/users/krystian-hebel/repos","events_url":"https://api.github.com/users/krystian-hebel/events{/privacy}","received_events_url":"https://api.github.com/users/krystian-hebel/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/3mdeb/edk2-platforms/pulls/1/commits","review_comments_url":"https://api.github.com/repos/3mdeb/edk2-platforms/pulls/1/comments","review_comment_url":"https://api.github.com/repos/3mdeb/edk2-platforms/pulls/comments{/number}","comments_url":"https://api.github.com/repos/3mdeb/edk2-platforms/issues/1/comments","statuses_url":"https://api.github.com/repos/3mdeb/edk2-platforms/statuses/d0ab342d6103020c08683993b0948b09c90d1838","head":{"label":"krystian-hebel:gcc_ia32","ref":"gcc_ia32","sha":"d0ab342d6103020c08683993b0948b09c90d1838","user":{"login":"krystian-hebel","id":40995177,"node_id":"MDQ6VXNlcjQwOTk1MTc3","avatar_url":"https://avatars2.githubusercontent.com/u/40995177?v=4","gravatar_id":"","url":"https://api.github.com/users/krystian-hebel","html_url":"https://github.com/krystian-hebel","followers_url":"https://api.github.com/users/krystian-hebel/followers","following_url":"https://api.github.com/users/krystian-hebel/following{/other_user}","gists_url":"https://api.github.com/users/krystian-hebel/gists{/gist_id}","starred_url":"https://api.github.com/users/krystian-hebel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krystian-hebel/subscriptions","organizations_url":"https://api.github.com/users/krystian-hebel/orgs","repos_url":"https://api.github.com/users/krystian-hebel/repos","events_url":"https://api.github.com/users/krystian-hebel/events{/privacy}","received_events_url":"https://api.github.com/users/krystian-hebel/received_events","type":"User","site_admin":false},"repo":{"id":149788861,"node_id":"MDEwOlJlcG9zaXRvcnkxNDk3ODg4NjE=","name":"edk2-platforms","full_name":"krystian-hebel/edk2-platforms","private":false,"owner":{"login":"krystian-hebel","id":40995177,"node_id":"MDQ6VXNlcjQwOTk1MTc3","avatar_url":"https://avatars2.githubusercontent.com/u/40995177?v=4","gravatar_id":"","url":"https://api.github.com/users/krystian-hebel","html_url":"https://github.com/krystian-hebel","followers_url":"https://api.github.com/users/krystian-hebel/followers","following_url":"https://api.github.com/users/krystian-hebel/following{/other_user}","gists_url":"https://api.github.com/users/krystian-hebel/gists{/gist_id}","starred_url":"https://api.github.com/users/krystian-hebel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krystian-hebel/subscriptions","organizations_url":"https://api.github.com/users/krystian-hebel/orgs","repos_url":"https://api.github.com/users/krystian-hebel/repos","events_url":"https://api.github.com/users/krystian-hebel/events{/privacy}","received_events_url":"https://api.github.com/users/krystian-hebel/received_events","type":"User","site_admin":false},"html_url":"https://github.com/krystian-hebel/edk2-platforms","description":"EDK II sample platform branches and tags","fork":true,"url":"https://api.github.com/repos/krystian-hebel/edk2-platforms","forks_url":"https://api.github.com/repos/krystian-hebel/edk2-platforms/forks","keys_url":"https://api.github.com/repos/krystian-hebel/edk2-platforms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/krystian-hebel/edk2-platforms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/krystian-hebel/edk2-platforms/teams","hooks_url":"https://api.github.com/repos/krystian-hebel/edk2-platforms/hooks","issue_events_url":"https://api.github.com/repos/krystian-hebel/edk2-platforms/issues/events{/number}","events_url":"https://api.github.com/repos/krystian-hebel/edk2-platforms/events","assignees_url":"https://api.github.com/repos/krystian-hebel/edk2-platforms/assignees{/user}","branches_url":"https://api.github.com/repos/krystian-hebel/edk2-platforms/branches{/branch}","tags_url":"https://api.github.com/repos/krystian-hebel/edk2-platforms/tags","blobs_url":"https://api.github.com/repos/krystian-hebel/edk2-platforms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/krystian-hebel/edk2-platforms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/krystian-hebel/edk2-platforms/git/refs{/sha}","trees_url":"https://api.github.com/repos/krystian-hebel/edk2-platforms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/krystian-hebel/edk2-platforms/statuses/{sha}","languages_url":"https://api.github.com/repos/krystian-hebel/edk2-platforms/languages","stargazers_url":"https://api.github.com/repos/krystian-hebel/edk2-platforms/stargazers","contributors_url":"https://api.github.com/repos/krystian-hebel/edk2-platforms/contributors","subscribers_url":"https://api.github.com/repos/krystian-hebel/edk2-platforms/subscribers","subscription_url":"https://api.github.com/repos/krystian-hebel/edk2-platforms/subscription","commits_url":"https://api.github.com/repos/krystian-hebel/edk2-platforms/commits{/sha}","git_commits_url":"https://api.github.com/repos/krystian-hebel/edk2-platforms/git/commits{/sha}","comments_url":"https://api.github.com/repos/krystian-hebel/edk2-platforms/comments{/number}","issue_comment_url":"https://api.github.com/repos/krystian-hebel/edk2-platforms/issues/comments{/number}","contents_url":"https://api.github.com/repos/krystian-hebel/edk2-platforms/contents/{+path}","compare_url":"https://api.github.com/repos/krystian-hebel/edk2-platforms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/krystian-hebel/edk2-platforms/merges","archive_url":"https://api.github.com/repos/krystian-hebel/edk2-platforms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/krystian-hebel/edk2-platforms/downloads","issues_url":"https://api.github.com/repos/krystian-hebel/edk2-platforms/issues{/number}","pulls_url":"https://api.github.com/repos/krystian-hebel/edk2-platforms/pulls{/number}","milestones_url":"https://api.github.com/repos/krystian-hebel/edk2-platforms/milestones{/number}","notifications_url":"https://api.github.com/repos/krystian-hebel/edk2-platforms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/krystian-hebel/edk2-platforms/labels{/name}","releases_url":"https://api.github.com/repos/krystian-hebel/edk2-platforms/releases{/id}","deployments_url":"https://api.github.com/repos/krystian-hebel/edk2-platforms/deployments","created_at":"2018-09-21T16:21:05Z","updated_at":"2018-09-21T16:21:11Z","pushed_at":"2018-09-21T16:22:07Z","git_url":"git://github.com/krystian-hebel/edk2-platforms.git","ssh_url":"[email protected]:krystian-hebel/edk2-platforms.git","clone_url":"https://github.com/krystian-hebel/edk2-platforms.git","svn_url":"https://github.com/krystian-hebel/edk2-platforms","homepage":"","size":176559,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-2-clause","name":"BSD 2-Clause \"Simplified\" License","spdx_id":"BSD-2-Clause","url":"https://api.github.com/licenses/bsd-2-clause","node_id":"MDc6TGljZW5zZTQ="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"3mdeb:devel-MinnowBoardMax-UDK2017","ref":"devel-MinnowBoardMax-UDK2017","sha":"eca2880ccff04e169d918d0f9b12e38efb1b234d","user":{"login":"3mdeb","id":17986768,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3OTg2NzY4","avatar_url":"https://avatars3.githubusercontent.com/u/17986768?v=4","gravatar_id":"","url":"https://api.github.com/users/3mdeb","html_url":"https://github.com/3mdeb","followers_url":"https://api.github.com/users/3mdeb/followers","following_url":"https://api.github.com/users/3mdeb/following{/other_user}","gists_url":"https://api.github.com/users/3mdeb/gists{/gist_id}","starred_url":"https://api.github.com/users/3mdeb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/3mdeb/subscriptions","organizations_url":"https://api.github.com/users/3mdeb/orgs","repos_url":"https://api.github.com/users/3mdeb/repos","events_url":"https://api.github.com/users/3mdeb/events{/privacy}","received_events_url":"https://api.github.com/users/3mdeb/received_events","type":"Organization","site_admin":false},"repo":{"id":123984334,"node_id":"MDEwOlJlcG9zaXRvcnkxMjM5ODQzMzQ=","name":"edk2-platforms","full_name":"3mdeb/edk2-platforms","private":false,"owner":{"login":"3mdeb","id":17986768,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3OTg2NzY4","avatar_url":"https://avatars3.githubusercontent.com/u/17986768?v=4","gravatar_id":"","url":"https://api.github.com/users/3mdeb","html_url":"https://github.com/3mdeb","followers_url":"https://api.github.com/users/3mdeb/followers","following_url":"https://api.github.com/users/3mdeb/following{/other_user}","gists_url":"https://api.github.com/users/3mdeb/gists{/gist_id}","starred_url":"https://api.github.com/users/3mdeb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/3mdeb/subscriptions","organizations_url":"https://api.github.com/users/3mdeb/orgs","repos_url":"https://api.github.com/users/3mdeb/repos","events_url":"https://api.github.com/users/3mdeb/events{/privacy}","received_events_url":"https://api.github.com/users/3mdeb/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/3mdeb/edk2-platforms","description":"EDK II sample platform branches and tags","fork":true,"url":"https://api.github.com/repos/3mdeb/edk2-platforms","forks_url":"https://api.github.com/repos/3mdeb/edk2-platforms/forks","keys_url":"https://api.github.com/repos/3mdeb/edk2-platforms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/3mdeb/edk2-platforms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/3mdeb/edk2-platforms/teams","hooks_url":"https://api.github.com/repos/3mdeb/edk2-platforms/hooks","issue_events_url":"https://api.github.com/repos/3mdeb/edk2-platforms/issues/events{/number}","events_url":"https://api.github.com/repos/3mdeb/edk2-platforms/events","assignees_url":"https://api.github.com/repos/3mdeb/edk2-platforms/assignees{/user}","branches_url":"https://api.github.com/repos/3mdeb/edk2-platforms/branches{/branch}","tags_url":"https://api.github.com/repos/3mdeb/edk2-platforms/tags","blobs_url":"https://api.github.com/repos/3mdeb/edk2-platforms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/3mdeb/edk2-platforms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/3mdeb/edk2-platforms/git/refs{/sha}","trees_url":"https://api.github.com/repos/3mdeb/edk2-platforms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/3mdeb/edk2-platforms/statuses/{sha}","languages_url":"https://api.github.com/repos/3mdeb/edk2-platforms/languages","stargazers_url":"https://api.github.com/repos/3mdeb/edk2-platforms/stargazers","contributors_url":"https://api.github.com/repos/3mdeb/edk2-platforms/contributors","subscribers_url":"https://api.github.com/repos/3mdeb/edk2-platforms/subscribers","subscription_url":"https://api.github.com/repos/3mdeb/edk2-platforms/subscription","commits_url":"https://api.github.com/repos/3mdeb/edk2-platforms/commits{/sha}","git_commits_url":"https://api.github.com/repos/3mdeb/edk2-platforms/git/commits{/sha}","comments_url":"https://api.github.com/repos/3mdeb/edk2-platforms/comments{/number}","issue_comment_url":"https://api.github.com/repos/3mdeb/edk2-platforms/issues/comments{/number}","contents_url":"https://api.github.com/repos/3mdeb/edk2-platforms/contents/{+path}","compare_url":"https://api.github.com/repos/3mdeb/edk2-platforms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/3mdeb/edk2-platforms/merges","archive_url":"https://api.github.com/repos/3mdeb/edk2-platforms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/3mdeb/edk2-platforms/downloads","issues_url":"https://api.github.com/repos/3mdeb/edk2-platforms/issues{/number}","pulls_url":"https://api.github.com/repos/3mdeb/edk2-platforms/pulls{/number}","milestones_url":"https://api.github.com/repos/3mdeb/edk2-platforms/milestones{/number}","notifications_url":"https://api.github.com/repos/3mdeb/edk2-platforms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/3mdeb/edk2-platforms/labels{/name}","releases_url":"https://api.github.com/repos/3mdeb/edk2-platforms/releases{/id}","deployments_url":"https://api.github.com/repos/3mdeb/edk2-platforms/deployments","created_at":"2018-03-05T22:00:41Z","updated_at":"2018-03-05T22:00:46Z","pushed_at":"2018-10-02T10:32:34Z","git_url":"git://github.com/3mdeb/edk2-platforms.git","ssh_url":"[email protected]:3mdeb/edk2-platforms.git","clone_url":"https://github.com/3mdeb/edk2-platforms.git","svn_url":"https://github.com/3mdeb/edk2-platforms","homepage":"","size":176124,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"bsd-2-clause","name":"BSD 2-Clause \"Simplified\" License","spdx_id":"BSD-2-Clause","url":"https://api.github.com/licenses/bsd-2-clause","node_id":"MDc6TGljZW5zZTQ="},"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/3mdeb/edk2-platforms/pulls/1"},"html":{"href":"https://github.com/3mdeb/edk2-platforms/pull/1"},"issue":{"href":"https://api.github.com/repos/3mdeb/edk2-platforms/issues/1"},"comments":{"href":"https://api.github.com/repos/3mdeb/edk2-platforms/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/3mdeb/edk2-platforms/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/3mdeb/edk2-platforms/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/3mdeb/edk2-platforms/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/3mdeb/edk2-platforms/statuses/d0ab342d6103020c08683993b0948b09c90d1838"}},"author_association":"NONE"}} | {
"id": 123984334,
"name": "3mdeb/edk2-platforms",
"url": "https://api.github.com/repos/3mdeb/edk2-platforms"
} | {
"id": 40995177,
"login": "krystian-hebel",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/40995177?",
"url": "https://api.github.com/users/krystian-hebel"
} | {
"id": 17986768,
"login": "3mdeb",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/17986768?",
"url": "https://api.github.com/orgs/3mdeb"
} | 2018-10-02T11:10:02 | 8353762645 | {"actor":{"display_login":"krystian-hebel"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/digitalorigin/slimpay/pulls/comments/179757735","pull_request_review_id":110062363,"id":179757735,"diff_hunk":"@@ -55,7 +53,7 @@ def self.answer(http_response)\n if http_response.code >= 400\n Slimpay::Error.new(http_response)\n else\n- http_response\n+ http_response.body","path":"lib/slimpay.rb","position":18,"original_position":18,"commit_id":"8d5fca1b4a56d7900a2573b4f848b7aef4283bea","original_commit_id":"8d5fca1b4a56d7900a2573b4f848b7aef4283bea","user":{"login":"Kitton","id":591125,"avatar_url":"https://avatars1.githubusercontent.com/u/591125?v=4","gravatar_id":"","url":"https://api.github.com/users/Kitton","html_url":"https://github.com/Kitton","followers_url":"https://api.github.com/users/Kitton/followers","following_url":"https://api.github.com/users/Kitton/following{/other_user}","gists_url":"https://api.github.com/users/Kitton/gists{/gist_id}","starred_url":"https://api.github.com/users/Kitton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kitton/subscriptions","organizations_url":"https://api.github.com/users/Kitton/orgs","repos_url":"https://api.github.com/users/Kitton/repos","events_url":"https://api.github.com/users/Kitton/events{/privacy}","received_events_url":"https://api.github.com/users/Kitton/received_events","type":"User","site_admin":false},"body":"It's due to changes in `HTTParty` gem","created_at":"2018-04-06T13:32:01Z","updated_at":"2018-04-06T13:32:05Z","html_url":"https://github.com/digitalorigin/slimpay/pull/1#discussion_r179757735","pull_request_url":"https://api.github.com/repos/digitalorigin/slimpay/pulls/1","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/digitalorigin/slimpay/pulls/comments/179757735"},"html":{"href":"https://github.com/digitalorigin/slimpay/pull/1#discussion_r179757735"},"pull_request":{"href":"https://api.github.com/repos/digitalorigin/slimpay/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/digitalorigin/slimpay/pulls/1","id":179906956,"html_url":"https://github.com/digitalorigin/slimpay/pull/1","diff_url":"https://github.com/digitalorigin/slimpay/pull/1.diff","patch_url":"https://github.com/digitalorigin/slimpay/pull/1.patch","issue_url":"https://api.github.com/repos/digitalorigin/slimpay/issues/1","number":1,"state":"open","locked":false,"title":"Update gem accordingly to the current API version ","user":{"login":"Kitton","id":591125,"avatar_url":"https://avatars1.githubusercontent.com/u/591125?v=4","gravatar_id":"","url":"https://api.github.com/users/Kitton","html_url":"https://github.com/Kitton","followers_url":"https://api.github.com/users/Kitton/followers","following_url":"https://api.github.com/users/Kitton/following{/other_user}","gists_url":"https://api.github.com/users/Kitton/gists{/gist_id}","starred_url":"https://api.github.com/users/Kitton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kitton/subscriptions","organizations_url":"https://api.github.com/users/Kitton/orgs","repos_url":"https://api.github.com/users/Kitton/repos","events_url":"https://api.github.com/users/Kitton/events{/privacy}","received_events_url":"https://api.github.com/users/Kitton/received_events","type":"User","site_admin":false},"body":"Looks like some details in Slimpay API were changed so some changes were made + VCR cassettes were updated.","created_at":"2018-04-06T10:11:18Z","updated_at":"2018-04-06T13:32:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6eab1d36c620f6236e75f06862be8e30aeae3576","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/digitalorigin/slimpay/pulls/1/commits","review_comments_url":"https://api.github.com/repos/digitalorigin/slimpay/pulls/1/comments","review_comment_url":"https://api.github.com/repos/digitalorigin/slimpay/pulls/comments{/number}","comments_url":"https://api.github.com/repos/digitalorigin/slimpay/issues/1/comments","statuses_url":"https://api.github.com/repos/digitalorigin/slimpay/statuses/8d5fca1b4a56d7900a2573b4f848b7aef4283bea","head":{"label":"digitalorigin:fix_gem","ref":"fix_gem","sha":"8d5fca1b4a56d7900a2573b4f848b7aef4283bea","user":{"login":"digitalorigin","id":17987120,"avatar_url":"https://avatars0.githubusercontent.com/u/17987120?v=4","gravatar_id":"","url":"https://api.github.com/users/digitalorigin","html_url":"https://github.com/digitalorigin","followers_url":"https://api.github.com/users/digitalorigin/followers","following_url":"https://api.github.com/users/digitalorigin/following{/other_user}","gists_url":"https://api.github.com/users/digitalorigin/gists{/gist_id}","starred_url":"https://api.github.com/users/digitalorigin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/digitalorigin/subscriptions","organizations_url":"https://api.github.com/users/digitalorigin/orgs","repos_url":"https://api.github.com/users/digitalorigin/repos","events_url":"https://api.github.com/users/digitalorigin/events{/privacy}","received_events_url":"https://api.github.com/users/digitalorigin/received_events","type":"Organization","site_admin":false},"repo":{"id":128217083,"name":"slimpay","full_name":"digitalorigin/slimpay","owner":{"login":"digitalorigin","id":17987120,"avatar_url":"https://avatars0.githubusercontent.com/u/17987120?v=4","gravatar_id":"","url":"https://api.github.com/users/digitalorigin","html_url":"https://github.com/digitalorigin","followers_url":"https://api.github.com/users/digitalorigin/followers","following_url":"https://api.github.com/users/digitalorigin/following{/other_user}","gists_url":"https://api.github.com/users/digitalorigin/gists{/gist_id}","starred_url":"https://api.github.com/users/digitalorigin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/digitalorigin/subscriptions","organizations_url":"https://api.github.com/users/digitalorigin/orgs","repos_url":"https://api.github.com/users/digitalorigin/repos","events_url":"https://api.github.com/users/digitalorigin/events{/privacy}","received_events_url":"https://api.github.com/users/digitalorigin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/digitalorigin/slimpay","description":"Ruby implementation of the Slimpay Hypermedia API.","fork":true,"url":"https://api.github.com/repos/digitalorigin/slimpay","forks_url":"https://api.github.com/repos/digitalorigin/slimpay/forks","keys_url":"https://api.github.com/repos/digitalorigin/slimpay/keys{/key_id}","collaborators_url":"https://api.github.com/repos/digitalorigin/slimpay/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/digitalorigin/slimpay/teams","hooks_url":"https://api.github.com/repos/digitalorigin/slimpay/hooks","issue_events_url":"https://api.github.com/repos/digitalorigin/slimpay/issues/events{/number}","events_url":"https://api.github.com/repos/digitalorigin/slimpay/events","assignees_url":"https://api.github.com/repos/digitalorigin/slimpay/assignees{/user}","branches_url":"https://api.github.com/repos/digitalorigin/slimpay/branches{/branch}","tags_url":"https://api.github.com/repos/digitalorigin/slimpay/tags","blobs_url":"https://api.github.com/repos/digitalorigin/slimpay/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/digitalorigin/slimpay/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/digitalorigin/slimpay/git/refs{/sha}","trees_url":"https://api.github.com/repos/digitalorigin/slimpay/git/trees{/sha}","statuses_url":"https://api.github.com/repos/digitalorigin/slimpay/statuses/{sha}","languages_url":"https://api.github.com/repos/digitalorigin/slimpay/languages","stargazers_url":"https://api.github.com/repos/digitalorigin/slimpay/stargazers","contributors_url":"https://api.github.com/repos/digitalorigin/slimpay/contributors","subscribers_url":"https://api.github.com/repos/digitalorigin/slimpay/subscribers","subscription_url":"https://api.github.com/repos/digitalorigin/slimpay/subscription","commits_url":"https://api.github.com/repos/digitalorigin/slimpay/commits{/sha}","git_commits_url":"https://api.github.com/repos/digitalorigin/slimpay/git/commits{/sha}","comments_url":"https://api.github.com/repos/digitalorigin/slimpay/comments{/number}","issue_comment_url":"https://api.github.com/repos/digitalorigin/slimpay/issues/comments{/number}","contents_url":"https://api.github.com/repos/digitalorigin/slimpay/contents/{+path}","compare_url":"https://api.github.com/repos/digitalorigin/slimpay/compare/{base}...{head}","merges_url":"https://api.github.com/repos/digitalorigin/slimpay/merges","archive_url":"https://api.github.com/repos/digitalorigin/slimpay/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/digitalorigin/slimpay/downloads","issues_url":"https://api.github.com/repos/digitalorigin/slimpay/issues{/number}","pulls_url":"https://api.github.com/repos/digitalorigin/slimpay/pulls{/number}","milestones_url":"https://api.github.com/repos/digitalorigin/slimpay/milestones{/number}","notifications_url":"https://api.github.com/repos/digitalorigin/slimpay/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/digitalorigin/slimpay/labels{/name}","releases_url":"https://api.github.com/repos/digitalorigin/slimpay/releases{/id}","deployments_url":"https://api.github.com/repos/digitalorigin/slimpay/deployments","created_at":"2018-04-05T14:20:56Z","updated_at":"2018-04-05T14:20:58Z","pushed_at":"2018-04-06T12:39:41Z","git_url":"git://github.com/digitalorigin/slimpay.git","ssh_url":"[email protected]:digitalorigin/slimpay.git","clone_url":"https://github.com/digitalorigin/slimpay.git","svn_url":"https://github.com/digitalorigin/slimpay","homepage":null,"size":74,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"develop"}},"base":{"label":"digitalorigin:master","ref":"master","sha":"77d3b96b015a07078af3c420af72a547a80d168c","user":{"login":"digitalorigin","id":17987120,"avatar_url":"https://avatars0.githubusercontent.com/u/17987120?v=4","gravatar_id":"","url":"https://api.github.com/users/digitalorigin","html_url":"https://github.com/digitalorigin","followers_url":"https://api.github.com/users/digitalorigin/followers","following_url":"https://api.github.com/users/digitalorigin/following{/other_user}","gists_url":"https://api.github.com/users/digitalorigin/gists{/gist_id}","starred_url":"https://api.github.com/users/digitalorigin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/digitalorigin/subscriptions","organizations_url":"https://api.github.com/users/digitalorigin/orgs","repos_url":"https://api.github.com/users/digitalorigin/repos","events_url":"https://api.github.com/users/digitalorigin/events{/privacy}","received_events_url":"https://api.github.com/users/digitalorigin/received_events","type":"Organization","site_admin":false},"repo":{"id":128217083,"name":"slimpay","full_name":"digitalorigin/slimpay","owner":{"login":"digitalorigin","id":17987120,"avatar_url":"https://avatars0.githubusercontent.com/u/17987120?v=4","gravatar_id":"","url":"https://api.github.com/users/digitalorigin","html_url":"https://github.com/digitalorigin","followers_url":"https://api.github.com/users/digitalorigin/followers","following_url":"https://api.github.com/users/digitalorigin/following{/other_user}","gists_url":"https://api.github.com/users/digitalorigin/gists{/gist_id}","starred_url":"https://api.github.com/users/digitalorigin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/digitalorigin/subscriptions","organizations_url":"https://api.github.com/users/digitalorigin/orgs","repos_url":"https://api.github.com/users/digitalorigin/repos","events_url":"https://api.github.com/users/digitalorigin/events{/privacy}","received_events_url":"https://api.github.com/users/digitalorigin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/digitalorigin/slimpay","description":"Ruby implementation of the Slimpay Hypermedia API.","fork":true,"url":"https://api.github.com/repos/digitalorigin/slimpay","forks_url":"https://api.github.com/repos/digitalorigin/slimpay/forks","keys_url":"https://api.github.com/repos/digitalorigin/slimpay/keys{/key_id}","collaborators_url":"https://api.github.com/repos/digitalorigin/slimpay/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/digitalorigin/slimpay/teams","hooks_url":"https://api.github.com/repos/digitalorigin/slimpay/hooks","issue_events_url":"https://api.github.com/repos/digitalorigin/slimpay/issues/events{/number}","events_url":"https://api.github.com/repos/digitalorigin/slimpay/events","assignees_url":"https://api.github.com/repos/digitalorigin/slimpay/assignees{/user}","branches_url":"https://api.github.com/repos/digitalorigin/slimpay/branches{/branch}","tags_url":"https://api.github.com/repos/digitalorigin/slimpay/tags","blobs_url":"https://api.github.com/repos/digitalorigin/slimpay/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/digitalorigin/slimpay/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/digitalorigin/slimpay/git/refs{/sha}","trees_url":"https://api.github.com/repos/digitalorigin/slimpay/git/trees{/sha}","statuses_url":"https://api.github.com/repos/digitalorigin/slimpay/statuses/{sha}","languages_url":"https://api.github.com/repos/digitalorigin/slimpay/languages","stargazers_url":"https://api.github.com/repos/digitalorigin/slimpay/stargazers","contributors_url":"https://api.github.com/repos/digitalorigin/slimpay/contributors","subscribers_url":"https://api.github.com/repos/digitalorigin/slimpay/subscribers","subscription_url":"https://api.github.com/repos/digitalorigin/slimpay/subscription","commits_url":"https://api.github.com/repos/digitalorigin/slimpay/commits{/sha}","git_commits_url":"https://api.github.com/repos/digitalorigin/slimpay/git/commits{/sha}","comments_url":"https://api.github.com/repos/digitalorigin/slimpay/comments{/number}","issue_comment_url":"https://api.github.com/repos/digitalorigin/slimpay/issues/comments{/number}","contents_url":"https://api.github.com/repos/digitalorigin/slimpay/contents/{+path}","compare_url":"https://api.github.com/repos/digitalorigin/slimpay/compare/{base}...{head}","merges_url":"https://api.github.com/repos/digitalorigin/slimpay/merges","archive_url":"https://api.github.com/repos/digitalorigin/slimpay/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/digitalorigin/slimpay/downloads","issues_url":"https://api.github.com/repos/digitalorigin/slimpay/issues{/number}","pulls_url":"https://api.github.com/repos/digitalorigin/slimpay/pulls{/number}","milestones_url":"https://api.github.com/repos/digitalorigin/slimpay/milestones{/number}","notifications_url":"https://api.github.com/repos/digitalorigin/slimpay/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/digitalorigin/slimpay/labels{/name}","releases_url":"https://api.github.com/repos/digitalorigin/slimpay/releases{/id}","deployments_url":"https://api.github.com/repos/digitalorigin/slimpay/deployments","created_at":"2018-04-05T14:20:56Z","updated_at":"2018-04-05T14:20:58Z","pushed_at":"2018-04-06T12:39:41Z","git_url":"git://github.com/digitalorigin/slimpay.git","ssh_url":"[email protected]:digitalorigin/slimpay.git","clone_url":"https://github.com/digitalorigin/slimpay.git","svn_url":"https://github.com/digitalorigin/slimpay","homepage":null,"size":74,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/digitalorigin/slimpay/pulls/1"},"html":{"href":"https://github.com/digitalorigin/slimpay/pull/1"},"issue":{"href":"https://api.github.com/repos/digitalorigin/slimpay/issues/1"},"comments":{"href":"https://api.github.com/repos/digitalorigin/slimpay/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/digitalorigin/slimpay/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/digitalorigin/slimpay/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/digitalorigin/slimpay/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/digitalorigin/slimpay/statuses/8d5fca1b4a56d7900a2573b4f848b7aef4283bea"}},"author_association":"COLLABORATOR"}} | {
"id": 128217083,
"name": "digitalorigin/slimpay",
"url": "https://api.github.com/repos/digitalorigin/slimpay"
} | {
"id": 591125,
"login": "Kitton",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/591125?",
"url": "https://api.github.com/users/Kitton"
} | {
"id": 17987120,
"login": "digitalorigin",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/17987120?",
"url": "https://api.github.com/orgs/digitalorigin"
} | 2018-04-06T13:32:01 | 7490957259 | {"actor":{"display_login":"Kitton"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/toshiapp/toshi-ios-client/pulls/comments/169327094","pull_request_review_id":97834055,"id":169327094,"diff_hunk":"@@ -100,4 +100,33 @@ extension String {\n \n return lines.joined(separator: \"\\n\")\n }\n+\n+ func toChecksumEncodedAddress() -> String? {","path":"Toshi/Extensions/String+Additions.swift","position":5,"original_position":5,"commit_id":"8fb4ca2ee4d1960e60e40d6dd6f7b6f858f30013","original_commit_id":"8fb4ca2ee4d1960e60e40d6dd6f7b6f858f30013","user":{"login":"tristan","id":1412,"avatar_url":"https://avatars1.githubusercontent.com/u/1412?v=4","gravatar_id":"","url":"https://api.github.com/users/tristan","html_url":"https://github.com/tristan","followers_url":"https://api.github.com/users/tristan/followers","following_url":"https://api.github.com/users/tristan/following{/other_user}","gists_url":"https://api.github.com/users/tristan/gists{/gist_id}","starred_url":"https://api.github.com/users/tristan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tristan/subscriptions","organizations_url":"https://api.github.com/users/tristan/orgs","repos_url":"https://api.github.com/users/tristan/repos","events_url":"https://api.github.com/users/tristan/events{/privacy}","received_events_url":"https://api.github.com/users/tristan/received_events","type":"User","site_admin":false},"body":"I updated the PR description with a link to the EIP for it (which has the reference implementations in python and javascript)","created_at":"2018-02-20T14:04:48Z","updated_at":"2018-02-20T14:04:48Z","html_url":"https://github.com/toshiapp/toshi-ios-client/pull/740#discussion_r169327094","pull_request_url":"https://api.github.com/repos/toshiapp/toshi-ios-client/pulls/740","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/toshiapp/toshi-ios-client/pulls/comments/169327094"},"html":{"href":"https://github.com/toshiapp/toshi-ios-client/pull/740#discussion_r169327094"},"pull_request":{"href":"https://api.github.com/repos/toshiapp/toshi-ios-client/pulls/740"}},"in_reply_to_id":169325535},"pull_request":{"url":"https://api.github.com/repos/toshiapp/toshi-ios-client/pulls/740","id":170189505,"html_url":"https://github.com/toshiapp/toshi-ios-client/pull/740","diff_url":"https://github.com/toshiapp/toshi-ios-client/pull/740.diff","patch_url":"https://github.com/toshiapp/toshi-ios-client/pull/740.patch","issue_url":"https://api.github.com/repos/toshiapp/toshi-ios-client/issues/740","number":740,"state":"open","locked":false,"title":"[IOS-500]: Show checksum encoded wallet address","user":{"login":"yuliaveres","id":27722554,"avatar_url":"https://avatars2.githubusercontent.com/u/27722554?v=4","gravatar_id":"","url":"https://api.github.com/users/yuliaveres","html_url":"https://github.com/yuliaveres","followers_url":"https://api.github.com/users/yuliaveres/followers","following_url":"https://api.github.com/users/yuliaveres/following{/other_user}","gists_url":"https://api.github.com/users/yuliaveres/gists{/gist_id}","starred_url":"https://api.github.com/users/yuliaveres/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuliaveres/subscriptions","organizations_url":"https://api.github.com/users/yuliaveres/orgs","repos_url":"https://api.github.com/users/yuliaveres/repos","events_url":"https://api.github.com/users/yuliaveres/events{/privacy}","received_events_url":"https://api.github.com/users/yuliaveres/received_events","type":"User","site_admin":false},"body":"Implements checksum encoding for addresses\r\nhttps://github.com/ethereum/EIPs/blob/master/EIPS/eip-55.md\r\n\r\n\r\n","created_at":"2018-02-20T13:18:49Z","updated_at":"2018-02-20T14:04:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bc3922d7b13d2011483ee5eed860beea67136484","assignee":null,"assignees":[],"requested_reviewers":[{"login":"tristan","id":1412,"avatar_url":"https://avatars1.githubusercontent.com/u/1412?v=4","gravatar_id":"","url":"https://api.github.com/users/tristan","html_url":"https://github.com/tristan","followers_url":"https://api.github.com/users/tristan/followers","following_url":"https://api.github.com/users/tristan/following{/other_user}","gists_url":"https://api.github.com/users/tristan/gists{/gist_id}","starred_url":"https://api.github.com/users/tristan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tristan/subscriptions","organizations_url":"https://api.github.com/users/tristan/orgs","repos_url":"https://api.github.com/users/tristan/repos","events_url":"https://api.github.com/users/tristan/events{/privacy}","received_events_url":"https://api.github.com/users/tristan/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/toshiapp/toshi-ios-client/pulls/740/commits","review_comments_url":"https://api.github.com/repos/toshiapp/toshi-ios-client/pulls/740/comments","review_comment_url":"https://api.github.com/repos/toshiapp/toshi-ios-client/pulls/comments{/number}","comments_url":"https://api.github.com/repos/toshiapp/toshi-ios-client/issues/740/comments","statuses_url":"https://api.github.com/repos/toshiapp/toshi-ios-client/statuses/8fb4ca2ee4d1960e60e40d6dd6f7b6f858f30013","head":{"label":"toshiapp:improve/checksum-encoded-address","ref":"improve/checksum-encoded-address","sha":"8fb4ca2ee4d1960e60e40d6dd6f7b6f858f30013","user":{"login":"toshiapp","id":18060234,"avatar_url":"https://avatars3.githubusercontent.com/u/18060234?v=4","gravatar_id":"","url":"https://api.github.com/users/toshiapp","html_url":"https://github.com/toshiapp","followers_url":"https://api.github.com/users/toshiapp/followers","following_url":"https://api.github.com/users/toshiapp/following{/other_user}","gists_url":"https://api.github.com/users/toshiapp/gists{/gist_id}","starred_url":"https://api.github.com/users/toshiapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toshiapp/subscriptions","organizations_url":"https://api.github.com/users/toshiapp/orgs","repos_url":"https://api.github.com/users/toshiapp/repos","events_url":"https://api.github.com/users/toshiapp/events{/privacy}","received_events_url":"https://api.github.com/users/toshiapp/received_events","type":"Organization","site_admin":false},"repo":{"id":78760233,"name":"toshi-ios-client","full_name":"toshiapp/toshi-ios-client","owner":{"login":"toshiapp","id":18060234,"avatar_url":"https://avatars3.githubusercontent.com/u/18060234?v=4","gravatar_id":"","url":"https://api.github.com/users/toshiapp","html_url":"https://github.com/toshiapp","followers_url":"https://api.github.com/users/toshiapp/followers","following_url":"https://api.github.com/users/toshiapp/following{/other_user}","gists_url":"https://api.github.com/users/toshiapp/gists{/gist_id}","starred_url":"https://api.github.com/users/toshiapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toshiapp/subscriptions","organizations_url":"https://api.github.com/users/toshiapp/orgs","repos_url":"https://api.github.com/users/toshiapp/repos","events_url":"https://api.github.com/users/toshiapp/events{/privacy}","received_events_url":"https://api.github.com/users/toshiapp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/toshiapp/toshi-ios-client","description":"iOS client for Toshi","fork":false,"url":"https://api.github.com/repos/toshiapp/toshi-ios-client","forks_url":"https://api.github.com/repos/toshiapp/toshi-ios-client/forks","keys_url":"https://api.github.com/repos/toshiapp/toshi-ios-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/toshiapp/toshi-ios-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/toshiapp/toshi-ios-client/teams","hooks_url":"https://api.github.com/repos/toshiapp/toshi-ios-client/hooks","issue_events_url":"https://api.github.com/repos/toshiapp/toshi-ios-client/issues/events{/number}","events_url":"https://api.github.com/repos/toshiapp/toshi-ios-client/events","assignees_url":"https://api.github.com/repos/toshiapp/toshi-ios-client/assignees{/user}","branches_url":"https://api.github.com/repos/toshiapp/toshi-ios-client/branches{/branch}","tags_url":"https://api.github.com/repos/toshiapp/toshi-ios-client/tags","blobs_url":"https://api.github.com/repos/toshiapp/toshi-ios-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/toshiapp/toshi-ios-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/toshiapp/toshi-ios-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/toshiapp/toshi-ios-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/toshiapp/toshi-ios-client/statuses/{sha}","languages_url":"https://api.github.com/repos/toshiapp/toshi-ios-client/languages","stargazers_url":"https://api.github.com/repos/toshiapp/toshi-ios-client/stargazers","contributors_url":"https://api.github.com/repos/toshiapp/toshi-ios-client/contributors","subscribers_url":"https://api.github.com/repos/toshiapp/toshi-ios-client/subscribers","subscription_url":"https://api.github.com/repos/toshiapp/toshi-ios-client/subscription","commits_url":"https://api.github.com/repos/toshiapp/toshi-ios-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/toshiapp/toshi-ios-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/toshiapp/toshi-ios-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/toshiapp/toshi-ios-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/toshiapp/toshi-ios-client/contents/{+path}","compare_url":"https://api.github.com/repos/toshiapp/toshi-ios-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/toshiapp/toshi-ios-client/merges","archive_url":"https://api.github.com/repos/toshiapp/toshi-ios-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/toshiapp/toshi-ios-client/downloads","issues_url":"https://api.github.com/repos/toshiapp/toshi-ios-client/issues{/number}","pulls_url":"https://api.github.com/repos/toshiapp/toshi-ios-client/pulls{/number}","milestones_url":"https://api.github.com/repos/toshiapp/toshi-ios-client/milestones{/number}","notifications_url":"https://api.github.com/repos/toshiapp/toshi-ios-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/toshiapp/toshi-ios-client/labels{/name}","releases_url":"https://api.github.com/repos/toshiapp/toshi-ios-client/releases{/id}","deployments_url":"https://api.github.com/repos/toshiapp/toshi-ios-client/deployments","created_at":"2017-01-12T15:41:29Z","updated_at":"2018-02-19T07:39:37Z","pushed_at":"2018-02-20T13:44:54Z","git_url":"git://github.com/toshiapp/toshi-ios-client.git","ssh_url":"[email protected]:toshiapp/toshi-ios-client.git","clone_url":"https://github.com/toshiapp/toshi-ios-client.git","svn_url":"https://github.com/toshiapp/toshi-ios-client","homepage":"","size":577060,"stargazers_count":85,"watchers_count":85,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":25,"mirror_url":null,"archived":false,"open_issues_count":23,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":25,"open_issues":23,"watchers":85,"default_branch":"master"}},"base":{"label":"toshiapp:feature/send_flow","ref":"feature/send_flow","sha":"69682b398eb4b2d3b488ee6cdaf76d0442ba3a91","user":{"login":"toshiapp","id":18060234,"avatar_url":"https://avatars3.githubusercontent.com/u/18060234?v=4","gravatar_id":"","url":"https://api.github.com/users/toshiapp","html_url":"https://github.com/toshiapp","followers_url":"https://api.github.com/users/toshiapp/followers","following_url":"https://api.github.com/users/toshiapp/following{/other_user}","gists_url":"https://api.github.com/users/toshiapp/gists{/gist_id}","starred_url":"https://api.github.com/users/toshiapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toshiapp/subscriptions","organizations_url":"https://api.github.com/users/toshiapp/orgs","repos_url":"https://api.github.com/users/toshiapp/repos","events_url":"https://api.github.com/users/toshiapp/events{/privacy}","received_events_url":"https://api.github.com/users/toshiapp/received_events","type":"Organization","site_admin":false},"repo":{"id":78760233,"name":"toshi-ios-client","full_name":"toshiapp/toshi-ios-client","owner":{"login":"toshiapp","id":18060234,"avatar_url":"https://avatars3.githubusercontent.com/u/18060234?v=4","gravatar_id":"","url":"https://api.github.com/users/toshiapp","html_url":"https://github.com/toshiapp","followers_url":"https://api.github.com/users/toshiapp/followers","following_url":"https://api.github.com/users/toshiapp/following{/other_user}","gists_url":"https://api.github.com/users/toshiapp/gists{/gist_id}","starred_url":"https://api.github.com/users/toshiapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toshiapp/subscriptions","organizations_url":"https://api.github.com/users/toshiapp/orgs","repos_url":"https://api.github.com/users/toshiapp/repos","events_url":"https://api.github.com/users/toshiapp/events{/privacy}","received_events_url":"https://api.github.com/users/toshiapp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/toshiapp/toshi-ios-client","description":"iOS client for Toshi","fork":false,"url":"https://api.github.com/repos/toshiapp/toshi-ios-client","forks_url":"https://api.github.com/repos/toshiapp/toshi-ios-client/forks","keys_url":"https://api.github.com/repos/toshiapp/toshi-ios-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/toshiapp/toshi-ios-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/toshiapp/toshi-ios-client/teams","hooks_url":"https://api.github.com/repos/toshiapp/toshi-ios-client/hooks","issue_events_url":"https://api.github.com/repos/toshiapp/toshi-ios-client/issues/events{/number}","events_url":"https://api.github.com/repos/toshiapp/toshi-ios-client/events","assignees_url":"https://api.github.com/repos/toshiapp/toshi-ios-client/assignees{/user}","branches_url":"https://api.github.com/repos/toshiapp/toshi-ios-client/branches{/branch}","tags_url":"https://api.github.com/repos/toshiapp/toshi-ios-client/tags","blobs_url":"https://api.github.com/repos/toshiapp/toshi-ios-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/toshiapp/toshi-ios-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/toshiapp/toshi-ios-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/toshiapp/toshi-ios-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/toshiapp/toshi-ios-client/statuses/{sha}","languages_url":"https://api.github.com/repos/toshiapp/toshi-ios-client/languages","stargazers_url":"https://api.github.com/repos/toshiapp/toshi-ios-client/stargazers","contributors_url":"https://api.github.com/repos/toshiapp/toshi-ios-client/contributors","subscribers_url":"https://api.github.com/repos/toshiapp/toshi-ios-client/subscribers","subscription_url":"https://api.github.com/repos/toshiapp/toshi-ios-client/subscription","commits_url":"https://api.github.com/repos/toshiapp/toshi-ios-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/toshiapp/toshi-ios-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/toshiapp/toshi-ios-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/toshiapp/toshi-ios-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/toshiapp/toshi-ios-client/contents/{+path}","compare_url":"https://api.github.com/repos/toshiapp/toshi-ios-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/toshiapp/toshi-ios-client/merges","archive_url":"https://api.github.com/repos/toshiapp/toshi-ios-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/toshiapp/toshi-ios-client/downloads","issues_url":"https://api.github.com/repos/toshiapp/toshi-ios-client/issues{/number}","pulls_url":"https://api.github.com/repos/toshiapp/toshi-ios-client/pulls{/number}","milestones_url":"https://api.github.com/repos/toshiapp/toshi-ios-client/milestones{/number}","notifications_url":"https://api.github.com/repos/toshiapp/toshi-ios-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/toshiapp/toshi-ios-client/labels{/name}","releases_url":"https://api.github.com/repos/toshiapp/toshi-ios-client/releases{/id}","deployments_url":"https://api.github.com/repos/toshiapp/toshi-ios-client/deployments","created_at":"2017-01-12T15:41:29Z","updated_at":"2018-02-19T07:39:37Z","pushed_at":"2018-02-20T13:44:54Z","git_url":"git://github.com/toshiapp/toshi-ios-client.git","ssh_url":"[email protected]:toshiapp/toshi-ios-client.git","clone_url":"https://github.com/toshiapp/toshi-ios-client.git","svn_url":"https://github.com/toshiapp/toshi-ios-client","homepage":"","size":577060,"stargazers_count":85,"watchers_count":85,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":25,"mirror_url":null,"archived":false,"open_issues_count":23,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":25,"open_issues":23,"watchers":85,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/toshiapp/toshi-ios-client/pulls/740"},"html":{"href":"https://github.com/toshiapp/toshi-ios-client/pull/740"},"issue":{"href":"https://api.github.com/repos/toshiapp/toshi-ios-client/issues/740"},"comments":{"href":"https://api.github.com/repos/toshiapp/toshi-ios-client/issues/740/comments"},"review_comments":{"href":"https://api.github.com/repos/toshiapp/toshi-ios-client/pulls/740/comments"},"review_comment":{"href":"https://api.github.com/repos/toshiapp/toshi-ios-client/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/toshiapp/toshi-ios-client/pulls/740/commits"},"statuses":{"href":"https://api.github.com/repos/toshiapp/toshi-ios-client/statuses/8fb4ca2ee4d1960e60e40d6dd6f7b6f858f30013"}},"author_association":"CONTRIBUTOR"}} | {
"id": 78760233,
"name": "toshiapp/toshi-ios-client",
"url": "https://api.github.com/repos/toshiapp/toshi-ios-client"
} | {
"id": 1412,
"login": "tristan",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1412?",
"url": "https://api.github.com/users/tristan"
} | {
"id": 18060234,
"login": "toshiapp",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/18060234?",
"url": "https://api.github.com/orgs/toshiapp"
} | 2018-02-20T14:04:48 | 7269559437 | {"actor":{"display_login":"tristan"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/RIT-Space-Exploration/SPEX-Project-Definition-Documents/pulls/comments/214758550","pull_request_review_id":151877347,"id":214758550,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNDc1ODU1MA==","diff_hunk":"@@ -0,0 +1,405 @@\n+%% *************************************************************************\n+%%\n+%% This is the PDD for Rovers 2018\n+%%\n+%% This document uses IEEEtran.cls, the official IEEE LaTeX class\n+%% for authors of the Institute of Electrical and Electronics Engineers\n+%% (IEEE) Transactions journals and conferences.\n+%%\n+%% *************************************************************************\n+\n+\\documentclass[conference]{IEEEtran} % http://www.ctan.org/pkg/ieeetran\n+ \\usepackage{ltxtable, tabularx, longtable} \n+\\usepackage{tabularx} % fix tables\n+ \\newcolumntype{L}{>{\\raggedright\\arraybackslash}X} \n+\\usepackage{multirow} \n+\\usepackage{blindtext} % enable placeholder text generator\n+\\usepackage{graphicx} % enable toolbox for embedding figures and pictures\n+\\usepackage{nomencl} % enable package for adding a list of variables and constants at the beginning, aka \"nomenclature\"\n+\\usepackage{siunitx} % enable package for easily formatting units\n+\\usepackage{hyperref} % enable package for cross-referencing figures, sections, references etc.\n+% how to use hyperref: http://www2.washjeff.edu/users/rhigginbottom/latex/resources/lecture09.pdf\n+\\usepackage[T1]{fontenc} % change text encoding to make it more crisp\n+\\usepackage{etoolbox} % enable conditionals for help text\n+\\usepackage{booktabs} % make beautiful tables!\n+\\usepackage[utf8]{inputenc}\n+\\usepackage[english]{babel}\n+ \n+\\usepackage{hyperref}\n+\\hypersetup{\n+ colorlinks=true,\n+ linkcolor=blue,\n+ filecolor=magenta, \n+ urlcolor=cyan,\n+}\n+\n+% initialize nomenclature package\n+\\makenomenclature{}\n+\n+% set title. choose something as descriptive and precise as possible. Descriptive > sounding cool. remember this!\n+\\title{Rovers} %TODO come up with a better title\n+\n+\\author{\n+ \\IEEEauthorblockN{Thomas~Hall\\IEEEauthorrefmark{1}}\n+ \\IEEEauthorblockA{RIT Space Exploration, Rochester Institute of Technology \\\\ Rochester, N.Y. \\\\ Email: \\IEEEauthorrefmark{1}[email protected] }\n+}\n+\n+% page header for pages other than cover page\n+\\markboth{Project Design Document Standard}%\n+{Hall \\MakeLowercase{\\textit{et al.}}: RIT Space Exploration}\n+\n+\\begin{document}\n+\\maketitle\n+\\hyphenation{explor-ation}\n+\n+\\begin{abstract}\n+Design and construction of a mock-rover. \n+The goal of this project is delivering a functioning mock rover.\n+We define mock rover as a functioning rover built to specifications for a mock mission as it will not be launched.\n+A rover would be an area of space exploration completely new to RIT SPEX, because of this there are a lot of unknowns that need to be answered before starting this project. \n+Because of this the project will require a large amount of prototyping and testing. \n+The team would look at the talent and skills of RIT Space Exploration and answer the question: what caliber of rover are we able to make. \n+It would employ a multidisciplinary team for construction and development. The project would be slated to run for two semesters. \n+The rover would be extremely promotable and would look great at Imagine RIT. \n+\\end{abstract}\n+\n+\\label{sec:nomenclature}\n+\\newcommand{\\nomunit}[1]{\\renewcommand{\\nomentryend}{\\hspace*{\\fill}#1}}\n+\\renewcommand{\\nompreamble}{}\n+\n+\\nomenclature{RIT}{Rochester Institute of Technology}\n+\\nomenclature{SPEX}{RIT Space Exploration}\n+\\nomenclature{PDD}{Project Design Document}\n+\\nomenclature{URC}{University Robotics Competition}\n+\\nomenclature{MVP}{Minimum Viable Product}\n+\n+% Intro\n+\\section{Introduction}\n+\\label{sec:introduction}\n+\n+\\IEEEPARstart{R}{obotics} and by extension rovers are a tremendously important\n+part of space exploration. \n+This is also an area that RIT Space Exploration has very little experience with project-wise.\n+The purpose of this project is to assess and assert the capability of RIT SPEX regarding the construction and fabrication of a mock-rover and then begin construction. \n+As this is a new area to RIT SPEX, prototyping and experimenting is necessary to most effectively accomplish this goal. \n+This project will look at the unknowns, technical challenges, project management, and member skills of RIT Space Exploration in regard to a University Rover Competition (URC) capable rover and rover construction. \n+The URC is hosted by The Mars Society annually. \n+It is very competitive and requires a very complex and expensive rover that is currently out of scope for SPEX. \n+This rover would need to be capable of full autonomous navigation, soil collection and analysis, and precise robotics. \n+This project is the first step in building the skills for such a team.\n+Rovers are important, they are one of the primary ways we explore space and other planets. \n+This project exists to get our members experience with rovers by building such a rover. \n+\n+\\section{Primary Objective}\n+\\label{sec:primary-obj}\n+The goal of this project is delivering a functioning mock rover.\n+We define mock rover as a functioning rover built to specifications for a mock mission as it will not be launched. \n+We define rover as a vehicle for driving over rough terrain, especially one driven by remote control.\n+The rover will allow the team to develop skills and knowledge to build a\n+more feature completer rover in the future. \n+These skills include rover fabrication and design, autonomous navigation, electrical system design, rover testing, computer vision, and robotics.\n+The rover will be testing using events designed like the URC but scaled down to fit the scope of this rover. \n+We will be using time as a metric as well as binary metrics for completion of the parts of the competition. \n+Some features might behave differently than expected or planned these features will be evaluated accordingly.\n+This includes ’does the rocker-bogie system works as intended’, ’will the rover stop when directed at an obstacle’, etc. \n+The details are defined in the minimum viable product section.\n+\n+\\subsection{Minimum Viable Product}\n+\\label{subsec:mvp}\n+The minimum viable product (MVP) has been defined by the basics of what can be called a 'functioning rover'. This includes features like suspension, motors, power and controls. The MVP is defined by the following features: \n+\n+\\begin{table}[hb!]\n+ \\caption{Minimum Viable Product}\n+ \\centering\n+ {\\renewcommand{\\arraystretch}{1.5}\n+ \\begin{tabularx}{\\linewidth}{LL} \n+ \\hline\n+ \\textbf{Feature} & \\textbf{Reason} \\\\\n+ \\hline\n+ Rocker-bogie-like suspension & This is the NASA preferred rover suspension style. \\\\\n+ Ability to control remotely (such as a gamepad) & Remote control is essential for rovers. \\\\\n+ Ability to traverse terrain such as gravel, cement, and asphalt & Multi-terrain traversal is important for rovers. \\\\\n+ Technical report on GitHub & This will allow for future teams to easily learn from this teams experience. \\\\\n+ Rover hardware & Having a physical rover is important for a rover project as it allows for lessons to be learned in construction. \\\\ \n+ Present at Imagine RIT & This is essential for promotional value. \\\\\n+ Partial self-driving & Partially autonomous navigation for future URC readiness. \\\\\n+ \\hline\n+ \\end{tabularx}\n+ }\n+\\label{tab:mvp-one}\n+\\end{table}\n+\n+\\subsection{Improvements}\n+\\label{subsec:improvements}\n+The MVP is intended to be flexible in implementation depending on funding. \n+The purpose of the project is to gain experience in rovers and robotics and this can be done in a number of form factors.\n+The size and materials are not defined because of this. \n+Should the funding allow for it there are many improvements that can be made beyond the MVP. \n+This allows for more experience to be gained, thus fulfilling the goals of the project.\n+\n+\\begin{table}[ht!]\n+ \\caption{Improvements}\n+ \\centering\n+ {\\renewcommand{\\arraystretch}{1.5}\n+ \\begin{tabularx}{\\linewidth}{LL}\n+ \\hline\n+ \\textbf{Feature} & \\textbf{Reason} \\\\ \n+ \\hline\n+ Lidar based CV & Autonomous navigation for future URC readiness. \\\\\n+ Improved navigation with use of GPS system & Additional navigation options. \\\\\n+ Robotic arm with 3+ degrees of freedom & URC readiness and rover capabilities. \\\\ \n+ Drill or grasper attachment & Increased capabilities of the robotic arm. \\\\\n+ Soil sample analysis with Archimedes' screw & Scientific possibilities. \\\\\n+ Larger and or faster rover & Able to traverse obstacles of greater magnitude or hold more scientific equipment for future expansion. \\\\\n+ Solar cells & Additional long-term navigation viability and experience. \\\\\n+ Web control interface with GUI & Easier navigation. \\\\","path":"Rovers/Rovers.tex","position":155,"original_position":155,"commit_id":"797f8bf26d4fea47b0c9f212c92ae0e7479a2b6f","original_commit_id":"797f8bf26d4fea47b0c9f212c92ae0e7479a2b6f","user":{"login":"tjh2822","id":22133499,"node_id":"MDQ6VXNlcjIyMTMzNDk5","avatar_url":"https://avatars0.githubusercontent.com/u/22133499?v=4","gravatar_id":"","url":"https://api.github.com/users/tjh2822","html_url":"https://github.com/tjh2822","followers_url":"https://api.github.com/users/tjh2822/followers","following_url":"https://api.github.com/users/tjh2822/following{/other_user}","gists_url":"https://api.github.com/users/tjh2822/gists{/gist_id}","starred_url":"https://api.github.com/users/tjh2822/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tjh2822/subscriptions","organizations_url":"https://api.github.com/users/tjh2822/orgs","repos_url":"https://api.github.com/users/tjh2822/repos","events_url":"https://api.github.com/users/tjh2822/events{/privacy}","received_events_url":"https://api.github.com/users/tjh2822/received_events","type":"User","site_admin":false},"body":"I had in mind, show rover on google maps (or similar) with GPS, show a better overview of rover systems, etc...","created_at":"2018-09-03T22:04:27Z","updated_at":"2018-09-03T22:04:27Z","html_url":"https://github.com/RIT-Space-Exploration/SPEX-Project-Definition-Documents/pull/37#discussion_r214758550","pull_request_url":"https://api.github.com/repos/RIT-Space-Exploration/SPEX-Project-Definition-Documents/pulls/37","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/RIT-Space-Exploration/SPEX-Project-Definition-Documents/pulls/comments/214758550"},"html":{"href":"https://github.com/RIT-Space-Exploration/SPEX-Project-Definition-Documents/pull/37#discussion_r214758550"},"pull_request":{"href":"https://api.github.com/repos/RIT-Space-Exploration/SPEX-Project-Definition-Documents/pulls/37"}},"in_reply_to_id":214756842},"pull_request":{"url":"https://api.github.com/repos/RIT-Space-Exploration/SPEX-Project-Definition-Documents/pulls/37","id":207802517,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3ODAyNTE3","html_url":"https://github.com/RIT-Space-Exploration/SPEX-Project-Definition-Documents/pull/37","diff_url":"https://github.com/RIT-Space-Exploration/SPEX-Project-Definition-Documents/pull/37.diff","patch_url":"https://github.com/RIT-Space-Exploration/SPEX-Project-Definition-Documents/pull/37.patch","issue_url":"https://api.github.com/repos/RIT-Space-Exploration/SPEX-Project-Definition-Documents/issues/37","number":37,"state":"open","locked":false,"title":"Rover","user":{"login":"tjh2822","id":22133499,"node_id":"MDQ6VXNlcjIyMTMzNDk5","avatar_url":"https://avatars0.githubusercontent.com/u/22133499?v=4","gravatar_id":"","url":"https://api.github.com/users/tjh2822","html_url":"https://github.com/tjh2822","followers_url":"https://api.github.com/users/tjh2822/followers","following_url":"https://api.github.com/users/tjh2822/following{/other_user}","gists_url":"https://api.github.com/users/tjh2822/gists{/gist_id}","starred_url":"https://api.github.com/users/tjh2822/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tjh2822/subscriptions","organizations_url":"https://api.github.com/users/tjh2822/orgs","repos_url":"https://api.github.com/users/tjh2822/repos","events_url":"https://api.github.com/users/tjh2822/events{/privacy}","received_events_url":"https://api.github.com/users/tjh2822/received_events","type":"User","site_admin":false},"body":"### Authors\r\n* Thomas Hall tjh2822\r\n\r\n### Abstract\r\nDesign and construction of a mock rover. \r\nA rover would be an area of space exploration completely new to RIT SPEX, because of this there are a lot of unknowns that need to be answered before starting this project. \r\nBecause of this the project will require a large amount of prototyping and testing. \r\nThe team would look at the talent and skills of RIT Space Exploration and answer the question: what caliber of rover are we able to make. \r\nIt would employ a multidisciplinary team for construction and development. The project would be slated to run for two semesters. \r\nThe rover would be extremely promotable and would look great at Imagine RIT. \r\n\r\n#### PDF\r\nhttps://github.com/RIT-Space-Exploration/SPEX-Project-Definition-Documents/blob/Rover/Rovers/Rovers.pdf\r\n\r\n### Comments for Reviewers (optional)\r\nInclude notes for the reviewers here.\r\n","created_at":"2018-08-12T03:17:12Z","updated_at":"2018-09-03T22:04:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"66483a5e830d91ef4b6af014cec4a36ecab2bfde","assignee":null,"assignees":[],"requested_reviewers":[{"login":"ddm9599","id":19338761,"node_id":"MDQ6VXNlcjE5MzM4NzYx","avatar_url":"https://avatars2.githubusercontent.com/u/19338761?v=4","gravatar_id":"","url":"https://api.github.com/users/ddm9599","html_url":"https://github.com/ddm9599","followers_url":"https://api.github.com/users/ddm9599/followers","following_url":"https://api.github.com/users/ddm9599/following{/other_user}","gists_url":"https://api.github.com/users/ddm9599/gists{/gist_id}","starred_url":"https://api.github.com/users/ddm9599/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ddm9599/subscriptions","organizations_url":"https://api.github.com/users/ddm9599/orgs","repos_url":"https://api.github.com/users/ddm9599/repos","events_url":"https://api.github.com/users/ddm9599/events{/privacy}","received_events_url":"https://api.github.com/users/ddm9599/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/RIT-Space-Exploration/SPEX-Project-Definition-Documents/pulls/37/commits","review_comments_url":"https://api.github.com/repos/RIT-Space-Exploration/SPEX-Project-Definition-Documents/pulls/37/comments","review_comment_url":"https://api.github.com/repos/RIT-Space-Exploration/SPEX-Project-Definition-Documents/pulls/comments{/number}","comments_url":"https://api.github.com/repos/RIT-Space-Exploration/SPEX-Project-Definition-Documents/issues/37/comments","statuses_url":"https://api.github.com/repos/RIT-Space-Exploration/SPEX-Project-Definition-Documents/statuses/797f8bf26d4fea47b0c9f212c92ae0e7479a2b6f","head":{"label":"RIT-Space-Exploration:Rover","ref":"Rover","sha":"797f8bf26d4fea47b0c9f212c92ae0e7479a2b6f","user":{"login":"RIT-Space-Exploration","id":18233185,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4MjMzMTg1","avatar_url":"https://avatars0.githubusercontent.com/u/18233185?v=4","gravatar_id":"","url":"https://api.github.com/users/RIT-Space-Exploration","html_url":"https://github.com/RIT-Space-Exploration","followers_url":"https://api.github.com/users/RIT-Space-Exploration/followers","following_url":"https://api.github.com/users/RIT-Space-Exploration/following{/other_user}","gists_url":"https://api.github.com/users/RIT-Space-Exploration/gists{/gist_id}","starred_url":"https://api.github.com/users/RIT-Space-Exploration/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RIT-Space-Exploration/subscriptions","organizations_url":"https://api.github.com/users/RIT-Space-Exploration/orgs","repos_url":"https://api.github.com/users/RIT-Space-Exploration/repos","events_url":"https://api.github.com/users/RIT-Space-Exploration/events{/privacy}","received_events_url":"https://api.github.com/users/RIT-Space-Exploration/received_events","type":"Organization","site_admin":false},"repo":{"id":83093086,"node_id":"MDEwOlJlcG9zaXRvcnk4MzA5MzA4Ng==","name":"SPEX-Project-Definition-Documents","full_name":"RIT-Space-Exploration/SPEX-Project-Definition-Documents","owner":{"login":"RIT-Space-Exploration","id":18233185,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4MjMzMTg1","avatar_url":"https://avatars0.githubusercontent.com/u/18233185?v=4","gravatar_id":"","url":"https://api.github.com/users/RIT-Space-Exploration","html_url":"https://github.com/RIT-Space-Exploration","followers_url":"https://api.github.com/users/RIT-Space-Exploration/followers","following_url":"https://api.github.com/users/RIT-Space-Exploration/following{/other_user}","gists_url":"https://api.github.com/users/RIT-Space-Exploration/gists{/gist_id}","starred_url":"https://api.github.com/users/RIT-Space-Exploration/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RIT-Space-Exploration/subscriptions","organizations_url":"https://api.github.com/users/RIT-Space-Exploration/orgs","repos_url":"https://api.github.com/users/RIT-Space-Exploration/repos","events_url":"https://api.github.com/users/RIT-Space-Exploration/events{/privacy}","received_events_url":"https://api.github.com/users/RIT-Space-Exploration/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/RIT-Space-Exploration/SPEX-Project-Definition-Documents","description":"A standard on RIT Space Exploration project proposals and formatting boilerplate","fork":false,"url":"https://api.github.com/repos/RIT-Space-Exploration/SPEX-Project-Definition-Documents","forks_url":"https://api.github.com/repos/RIT-Space-Exploration/SPEX-Project-Definition-Documents/forks","keys_url":"https://api.github.com/repos/RIT-Space-Exploration/SPEX-Project-Definition-Documents/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RIT-Space-Exploration/SPEX-Project-Definition-Documents/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RIT-Space-Exploration/SPEX-Project-Definition-Documents/teams","hooks_url":"https://api.github.com/repos/RIT-Space-Exploration/SPEX-Project-Definition-Documents/hooks","issue_events_url":"https://api.github.com/repos/RIT-Space-Exploration/SPEX-Project-Definition-Documents/issues/events{/number}","events_url":"https://api.github.com/repos/RIT-Space-Exploration/SPEX-Project-Definition-Documents/events","assignees_url":"https://api.github.com/repos/RIT-Space-Exploration/SPEX-Project-Definition-Documents/assignees{/user}","branches_url":"https://api.github.com/repos/RIT-Space-Exploration/SPEX-Project-Definition-Documents/branches{/branch}","tags_url":"https://api.github.com/repos/RIT-Space-Exploration/SPEX-Project-Definition-Documents/tags","blobs_url":"https://api.github.com/repos/RIT-Space-Exploration/SPEX-Project-Definition-Documents/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RIT-Space-Exploration/SPEX-Project-Definition-Documents/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RIT-Space-Exploration/SPEX-Project-Definition-Documents/git/refs{/sha}","trees_url":"https://api.github.com/repos/RIT-Space-Exploration/SPEX-Project-Definition-Documents/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RIT-Space-Exploration/SPEX-Project-Definition-Documents/statuses/{sha}","languages_url":"https://api.github.com/repos/RIT-Space-Exploration/SPEX-Project-Definition-Documents/languages","stargazers_url":"https://api.github.com/repos/RIT-Space-Exploration/SPEX-Project-Definition-Documents/stargazers","contributors_url":"https://api.github.com/repos/RIT-Space-Exploration/SPEX-Project-Definition-Documents/contributors","subscribers_url":"https://api.github.com/repos/RIT-Space-Exploration/SPEX-Project-Definition-Documents/subscribers","subscription_url":"https://api.github.com/repos/RIT-Space-Exploration/SPEX-Project-Definition-Documents/subscription","commits_url":"https://api.github.com/repos/RIT-Space-Exploration/SPEX-Project-Definition-Documents/commits{/sha}","git_commits_url":"https://api.github.com/repos/RIT-Space-Exploration/SPEX-Project-Definition-Documents/git/commits{/sha}","comments_url":"https://api.github.com/repos/RIT-Space-Exploration/SPEX-Project-Definition-Documents/comments{/number}","issue_comment_url":"https://api.github.com/repos/RIT-Space-Exploration/SPEX-Project-Definition-Documents/issues/comments{/number}","contents_url":"https://api.github.com/repos/RIT-Space-Exploration/SPEX-Project-Definition-Documents/contents/{+path}","compare_url":"https://api.github.com/repos/RIT-Space-Exploration/SPEX-Project-Definition-Documents/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RIT-Space-Exploration/SPEX-Project-Definition-Documents/merges","archive_url":"https://api.github.com/repos/RIT-Space-Exploration/SPEX-Project-Definition-Documents/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RIT-Space-Exploration/SPEX-Project-Definition-Documents/downloads","issues_url":"https://api.github.com/repos/RIT-Space-Exploration/SPEX-Project-Definition-Documents/issues{/number}","pulls_url":"https://api.github.com/repos/RIT-Space-Exploration/SPEX-Project-Definition-Documents/pulls{/number}","milestones_url":"https://api.github.com/repos/RIT-Space-Exploration/SPEX-Project-Definition-Documents/milestones{/number}","notifications_url":"https://api.github.com/repos/RIT-Space-Exploration/SPEX-Project-Definition-Documents/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RIT-Space-Exploration/SPEX-Project-Definition-Documents/labels{/name}","releases_url":"https://api.github.com/repos/RIT-Space-Exploration/SPEX-Project-Definition-Documents/releases{/id}","deployments_url":"https://api.github.com/repos/RIT-Space-Exploration/SPEX-Project-Definition-Documents/deployments","created_at":"2017-02-25T00:01:22Z","updated_at":"2018-08-31T05:57:05Z","pushed_at":"2018-09-03T19:38:58Z","git_url":"git://github.com/RIT-Space-Exploration/SPEX-Project-Definition-Documents.git","ssh_url":"[email protected]:RIT-Space-Exploration/SPEX-Project-Definition-Documents.git","clone_url":"https://github.com/RIT-Space-Exploration/SPEX-Project-Definition-Documents.git","svn_url":"https://github.com/RIT-Space-Exploration/SPEX-Project-Definition-Documents","homepage":null,"size":23039,"stargazers_count":6,"watchers_count":6,"language":"TeX","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":9,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":9,"watchers":6,"default_branch":"master"}},"base":{"label":"RIT-Space-Exploration:master","ref":"master","sha":"c2ab82c3f0f6fd0cf3f77214d4d039ab88341662","user":{"login":"RIT-Space-Exploration","id":18233185,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4MjMzMTg1","avatar_url":"https://avatars0.githubusercontent.com/u/18233185?v=4","gravatar_id":"","url":"https://api.github.com/users/RIT-Space-Exploration","html_url":"https://github.com/RIT-Space-Exploration","followers_url":"https://api.github.com/users/RIT-Space-Exploration/followers","following_url":"https://api.github.com/users/RIT-Space-Exploration/following{/other_user}","gists_url":"https://api.github.com/users/RIT-Space-Exploration/gists{/gist_id}","starred_url":"https://api.github.com/users/RIT-Space-Exploration/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RIT-Space-Exploration/subscriptions","organizations_url":"https://api.github.com/users/RIT-Space-Exploration/orgs","repos_url":"https://api.github.com/users/RIT-Space-Exploration/repos","events_url":"https://api.github.com/users/RIT-Space-Exploration/events{/privacy}","received_events_url":"https://api.github.com/users/RIT-Space-Exploration/received_events","type":"Organization","site_admin":false},"repo":{"id":83093086,"node_id":"MDEwOlJlcG9zaXRvcnk4MzA5MzA4Ng==","name":"SPEX-Project-Definition-Documents","full_name":"RIT-Space-Exploration/SPEX-Project-Definition-Documents","owner":{"login":"RIT-Space-Exploration","id":18233185,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4MjMzMTg1","avatar_url":"https://avatars0.githubusercontent.com/u/18233185?v=4","gravatar_id":"","url":"https://api.github.com/users/RIT-Space-Exploration","html_url":"https://github.com/RIT-Space-Exploration","followers_url":"https://api.github.com/users/RIT-Space-Exploration/followers","following_url":"https://api.github.com/users/RIT-Space-Exploration/following{/other_user}","gists_url":"https://api.github.com/users/RIT-Space-Exploration/gists{/gist_id}","starred_url":"https://api.github.com/users/RIT-Space-Exploration/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RIT-Space-Exploration/subscriptions","organizations_url":"https://api.github.com/users/RIT-Space-Exploration/orgs","repos_url":"https://api.github.com/users/RIT-Space-Exploration/repos","events_url":"https://api.github.com/users/RIT-Space-Exploration/events{/privacy}","received_events_url":"https://api.github.com/users/RIT-Space-Exploration/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/RIT-Space-Exploration/SPEX-Project-Definition-Documents","description":"A standard on RIT Space Exploration project proposals and formatting boilerplate","fork":false,"url":"https://api.github.com/repos/RIT-Space-Exploration/SPEX-Project-Definition-Documents","forks_url":"https://api.github.com/repos/RIT-Space-Exploration/SPEX-Project-Definition-Documents/forks","keys_url":"https://api.github.com/repos/RIT-Space-Exploration/SPEX-Project-Definition-Documents/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RIT-Space-Exploration/SPEX-Project-Definition-Documents/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RIT-Space-Exploration/SPEX-Project-Definition-Documents/teams","hooks_url":"https://api.github.com/repos/RIT-Space-Exploration/SPEX-Project-Definition-Documents/hooks","issue_events_url":"https://api.github.com/repos/RIT-Space-Exploration/SPEX-Project-Definition-Documents/issues/events{/number}","events_url":"https://api.github.com/repos/RIT-Space-Exploration/SPEX-Project-Definition-Documents/events","assignees_url":"https://api.github.com/repos/RIT-Space-Exploration/SPEX-Project-Definition-Documents/assignees{/user}","branches_url":"https://api.github.com/repos/RIT-Space-Exploration/SPEX-Project-Definition-Documents/branches{/branch}","tags_url":"https://api.github.com/repos/RIT-Space-Exploration/SPEX-Project-Definition-Documents/tags","blobs_url":"https://api.github.com/repos/RIT-Space-Exploration/SPEX-Project-Definition-Documents/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RIT-Space-Exploration/SPEX-Project-Definition-Documents/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RIT-Space-Exploration/SPEX-Project-Definition-Documents/git/refs{/sha}","trees_url":"https://api.github.com/repos/RIT-Space-Exploration/SPEX-Project-Definition-Documents/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RIT-Space-Exploration/SPEX-Project-Definition-Documents/statuses/{sha}","languages_url":"https://api.github.com/repos/RIT-Space-Exploration/SPEX-Project-Definition-Documents/languages","stargazers_url":"https://api.github.com/repos/RIT-Space-Exploration/SPEX-Project-Definition-Documents/stargazers","contributors_url":"https://api.github.com/repos/RIT-Space-Exploration/SPEX-Project-Definition-Documents/contributors","subscribers_url":"https://api.github.com/repos/RIT-Space-Exploration/SPEX-Project-Definition-Documents/subscribers","subscription_url":"https://api.github.com/repos/RIT-Space-Exploration/SPEX-Project-Definition-Documents/subscription","commits_url":"https://api.github.com/repos/RIT-Space-Exploration/SPEX-Project-Definition-Documents/commits{/sha}","git_commits_url":"https://api.github.com/repos/RIT-Space-Exploration/SPEX-Project-Definition-Documents/git/commits{/sha}","comments_url":"https://api.github.com/repos/RIT-Space-Exploration/SPEX-Project-Definition-Documents/comments{/number}","issue_comment_url":"https://api.github.com/repos/RIT-Space-Exploration/SPEX-Project-Definition-Documents/issues/comments{/number}","contents_url":"https://api.github.com/repos/RIT-Space-Exploration/SPEX-Project-Definition-Documents/contents/{+path}","compare_url":"https://api.github.com/repos/RIT-Space-Exploration/SPEX-Project-Definition-Documents/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RIT-Space-Exploration/SPEX-Project-Definition-Documents/merges","archive_url":"https://api.github.com/repos/RIT-Space-Exploration/SPEX-Project-Definition-Documents/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RIT-Space-Exploration/SPEX-Project-Definition-Documents/downloads","issues_url":"https://api.github.com/repos/RIT-Space-Exploration/SPEX-Project-Definition-Documents/issues{/number}","pulls_url":"https://api.github.com/repos/RIT-Space-Exploration/SPEX-Project-Definition-Documents/pulls{/number}","milestones_url":"https://api.github.com/repos/RIT-Space-Exploration/SPEX-Project-Definition-Documents/milestones{/number}","notifications_url":"https://api.github.com/repos/RIT-Space-Exploration/SPEX-Project-Definition-Documents/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RIT-Space-Exploration/SPEX-Project-Definition-Documents/labels{/name}","releases_url":"https://api.github.com/repos/RIT-Space-Exploration/SPEX-Project-Definition-Documents/releases{/id}","deployments_url":"https://api.github.com/repos/RIT-Space-Exploration/SPEX-Project-Definition-Documents/deployments","created_at":"2017-02-25T00:01:22Z","updated_at":"2018-08-31T05:57:05Z","pushed_at":"2018-09-03T19:38:58Z","git_url":"git://github.com/RIT-Space-Exploration/SPEX-Project-Definition-Documents.git","ssh_url":"[email protected]:RIT-Space-Exploration/SPEX-Project-Definition-Documents.git","clone_url":"https://github.com/RIT-Space-Exploration/SPEX-Project-Definition-Documents.git","svn_url":"https://github.com/RIT-Space-Exploration/SPEX-Project-Definition-Documents","homepage":null,"size":23039,"stargazers_count":6,"watchers_count":6,"language":"TeX","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":9,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":9,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/RIT-Space-Exploration/SPEX-Project-Definition-Documents/pulls/37"},"html":{"href":"https://github.com/RIT-Space-Exploration/SPEX-Project-Definition-Documents/pull/37"},"issue":{"href":"https://api.github.com/repos/RIT-Space-Exploration/SPEX-Project-Definition-Documents/issues/37"},"comments":{"href":"https://api.github.com/repos/RIT-Space-Exploration/SPEX-Project-Definition-Documents/issues/37/comments"},"review_comments":{"href":"https://api.github.com/repos/RIT-Space-Exploration/SPEX-Project-Definition-Documents/pulls/37/comments"},"review_comment":{"href":"https://api.github.com/repos/RIT-Space-Exploration/SPEX-Project-Definition-Documents/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/RIT-Space-Exploration/SPEX-Project-Definition-Documents/pulls/37/commits"},"statuses":{"href":"https://api.github.com/repos/RIT-Space-Exploration/SPEX-Project-Definition-Documents/statuses/797f8bf26d4fea47b0c9f212c92ae0e7479a2b6f"}},"author_association":"MEMBER"}} | {
"id": 83093086,
"name": "RIT-Space-Exploration/SPEX-Project-Definition-Documents",
"url": "https://api.github.com/repos/RIT-Space-Exploration/SPEX-Project-Definition-Documents"
} | {
"id": 22133499,
"login": "tjh2822",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/22133499?",
"url": "https://api.github.com/users/tjh2822"
} | {
"id": 18233185,
"login": "RIT-Space-Exploration",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/18233185?",
"url": "https://api.github.com/orgs/RIT-Space-Exploration"
} | 2018-09-03T22:04:27 | 8208055356 | {"actor":{"display_login":"tjh2822"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/kubevirt/containerized-data-importer/pulls/comments/199279861","pull_request_review_id":133377359,"id":199279861,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5OTI3OTg2MQ==","diff_hunk":"@@ -326,3 +329,297 @@ func addToMap(m1, m2 map[string]string) map[string]string {\n \t}\n \treturn m1\n }\n+\n+// returns the CloneRequest string which contains the pvc name (and namespace) from which we want to clone the image.\n+func getCloneRequestPVC(pvc *v1.PersistentVolumeClaim) (string, error) {\n+\tcr, found := pvc.Annotations[AnnCloneRequest]\n+\tif !found || cr == \"\" {\n+\t\tverb := \"empty\"\n+\t\tif !found {\n+\t\t\tverb = \"missing\"\n+\t\t}\n+\t\treturn cr, errors.Errorf(\"annotation %q in pvc \\\"%s/%s\\\" is %s\\n\", AnnCloneRequest, pvc.Namespace, pvc.Name, verb)\n+\t}\n+\treturn cr, nil\n+}\n+\n+func CreateCloneSourcePod(client kubernetes.Interface, image, verbose, pullPolicy, cr, secretName string, pvc *v1.PersistentVolumeClaim) (*v1.Pod, error) {\n+\tstrArr := strings.Split(cr, \"/\")\n+ var ns string = \"\"\n+\tif strArr == nil || len(strArr) < 2 {\n+\t\tglog.V(Vdebug).Infof(\"Wrong CloneRequest Annotation\")\n+\t\treturn nil, nil\n+\t}\n+\tns = strArr[0]\n+\tpvcName := strArr[1]\n+\t\n+\tpod := MakeCloneSourcePodSpec(image, verbose, pullPolicy, cr, secretName, pvcName)\n+\n+\tpod, err := client.CoreV1().Pods(ns).Create(pod)\n+\tif err != nil {\n+\t\treturn nil, errors.Wrap(err, \"source pod API create errored\")\n+\t}\n+\tglog.V(Vuser).Infof(\"source pod \\\"%s/%s\\\" (image: %q) created\\n\", pod.Namespace, pod.Name, image)\n+\treturn pod, nil\n+}\n+\n+// return the clone source pod spec based on the target pvc.\n+func MakeCloneSourcePodSpec(image, verbose, pullPolicy, cr, secret string, pvcName string) *v1.Pod {","path":"pkg/controller/util.go","position":61,"original_position":61,"commit_id":"ca271bd534babdd9c3fd63958fbf4d86e09a706c","original_commit_id":"ca271bd534babdd9c3fd63958fbf4d86e09a706c","user":{"login":"jeffvance","id":3076896,"node_id":"MDQ6VXNlcjMwNzY4OTY=","avatar_url":"https://avatars3.githubusercontent.com/u/3076896?v=4","gravatar_id":"","url":"https://api.github.com/users/jeffvance","html_url":"https://github.com/jeffvance","followers_url":"https://api.github.com/users/jeffvance/followers","following_url":"https://api.github.com/users/jeffvance/following{/other_user}","gists_url":"https://api.github.com/users/jeffvance/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffvance/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffvance/subscriptions","organizations_url":"https://api.github.com/users/jeffvance/orgs","repos_url":"https://api.github.com/users/jeffvance/repos","events_url":"https://api.github.com/users/jeffvance/events{/privacy}","received_events_url":"https://api.github.com/users/jeffvance/received_events","type":"User","site_admin":false},"body":"is this exported due to test requirements?","created_at":"2018-06-29T21:03:59Z","updated_at":"2018-06-29T21:04:00Z","html_url":"https://github.com/kubevirt/containerized-data-importer/pull/219#discussion_r199279861","pull_request_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/pulls/219","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/kubevirt/containerized-data-importer/pulls/comments/199279861"},"html":{"href":"https://github.com/kubevirt/containerized-data-importer/pull/219#discussion_r199279861"},"pull_request":{"href":"https://api.github.com/repos/kubevirt/containerized-data-importer/pulls/219"}}},"pull_request":{"url":"https://api.github.com/repos/kubevirt/containerized-data-importer/pulls/219","id":196117106,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk2MTE3MTA2","html_url":"https://github.com/kubevirt/containerized-data-importer/pull/219","diff_url":"https://github.com/kubevirt/containerized-data-importer/pull/219.diff","patch_url":"https://github.com/kubevirt/containerized-data-importer/pull/219.patch","issue_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/issues/219","number":219,"state":"open","locked":false,"title":"[WIP] Host-assisted cloning integrated to CDI","user":{"login":"zvikorn","id":29862284,"node_id":"MDQ6VXNlcjI5ODYyMjg0","avatar_url":"https://avatars1.githubusercontent.com/u/29862284?v=4","gravatar_id":"","url":"https://api.github.com/users/zvikorn","html_url":"https://github.com/zvikorn","followers_url":"https://api.github.com/users/zvikorn/followers","following_url":"https://api.github.com/users/zvikorn/following{/other_user}","gists_url":"https://api.github.com/users/zvikorn/gists{/gist_id}","starred_url":"https://api.github.com/users/zvikorn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zvikorn/subscriptions","organizations_url":"https://api.github.com/users/zvikorn/orgs","repos_url":"https://api.github.com/users/zvikorn/repos","events_url":"https://api.github.com/users/zvikorn/events{/privacy}","received_events_url":"https://api.github.com/users/zvikorn/received_events","type":"User","site_admin":false},"body":"Still need to add 'CloneOf' on cloning completion.\r\nI might also find a way to label the node automatically, for the the NodeAffinity.\r\n","created_at":"2018-06-20T12:12:34Z","updated_at":"2018-06-29T21:04:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0f02b7832b39130d71599abd73d11504ef1884f4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":907411020,"node_id":"MDU6TGFiZWw5MDc0MTEwMjA=","url":"https://api.github.com/repos/kubevirt/containerized-data-importer/labels/Do%20Not%20Merge","name":"Do Not Merge","color":"c6362b","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/pulls/219/commits","review_comments_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/pulls/219/comments","review_comment_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/issues/219/comments","statuses_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/statuses/ca271bd534babdd9c3fd63958fbf4d86e09a706c","head":{"label":"zvikorn:master","ref":"master","sha":"ca271bd534babdd9c3fd63958fbf4d86e09a706c","user":{"login":"zvikorn","id":29862284,"node_id":"MDQ6VXNlcjI5ODYyMjg0","avatar_url":"https://avatars1.githubusercontent.com/u/29862284?v=4","gravatar_id":"","url":"https://api.github.com/users/zvikorn","html_url":"https://github.com/zvikorn","followers_url":"https://api.github.com/users/zvikorn/followers","following_url":"https://api.github.com/users/zvikorn/following{/other_user}","gists_url":"https://api.github.com/users/zvikorn/gists{/gist_id}","starred_url":"https://api.github.com/users/zvikorn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zvikorn/subscriptions","organizations_url":"https://api.github.com/users/zvikorn/orgs","repos_url":"https://api.github.com/users/zvikorn/repos","events_url":"https://api.github.com/users/zvikorn/events{/privacy}","received_events_url":"https://api.github.com/users/zvikorn/received_events","type":"User","site_admin":false},"repo":{"id":137721708,"node_id":"MDEwOlJlcG9zaXRvcnkxMzc3MjE3MDg=","name":"containerized-data-importer","full_name":"zvikorn/containerized-data-importer","owner":{"login":"zvikorn","id":29862284,"node_id":"MDQ6VXNlcjI5ODYyMjg0","avatar_url":"https://avatars1.githubusercontent.com/u/29862284?v=4","gravatar_id":"","url":"https://api.github.com/users/zvikorn","html_url":"https://github.com/zvikorn","followers_url":"https://api.github.com/users/zvikorn/followers","following_url":"https://api.github.com/users/zvikorn/following{/other_user}","gists_url":"https://api.github.com/users/zvikorn/gists{/gist_id}","starred_url":"https://api.github.com/users/zvikorn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zvikorn/subscriptions","organizations_url":"https://api.github.com/users/zvikorn/orgs","repos_url":"https://api.github.com/users/zvikorn/repos","events_url":"https://api.github.com/users/zvikorn/events{/privacy}","received_events_url":"https://api.github.com/users/zvikorn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zvikorn/containerized-data-importer","description":"Data Import Service for kubernetes, designed with kubevirt in mind.","fork":true,"url":"https://api.github.com/repos/zvikorn/containerized-data-importer","forks_url":"https://api.github.com/repos/zvikorn/containerized-data-importer/forks","keys_url":"https://api.github.com/repos/zvikorn/containerized-data-importer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zvikorn/containerized-data-importer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zvikorn/containerized-data-importer/teams","hooks_url":"https://api.github.com/repos/zvikorn/containerized-data-importer/hooks","issue_events_url":"https://api.github.com/repos/zvikorn/containerized-data-importer/issues/events{/number}","events_url":"https://api.github.com/repos/zvikorn/containerized-data-importer/events","assignees_url":"https://api.github.com/repos/zvikorn/containerized-data-importer/assignees{/user}","branches_url":"https://api.github.com/repos/zvikorn/containerized-data-importer/branches{/branch}","tags_url":"https://api.github.com/repos/zvikorn/containerized-data-importer/tags","blobs_url":"https://api.github.com/repos/zvikorn/containerized-data-importer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zvikorn/containerized-data-importer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zvikorn/containerized-data-importer/git/refs{/sha}","trees_url":"https://api.github.com/repos/zvikorn/containerized-data-importer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zvikorn/containerized-data-importer/statuses/{sha}","languages_url":"https://api.github.com/repos/zvikorn/containerized-data-importer/languages","stargazers_url":"https://api.github.com/repos/zvikorn/containerized-data-importer/stargazers","contributors_url":"https://api.github.com/repos/zvikorn/containerized-data-importer/contributors","subscribers_url":"https://api.github.com/repos/zvikorn/containerized-data-importer/subscribers","subscription_url":"https://api.github.com/repos/zvikorn/containerized-data-importer/subscription","commits_url":"https://api.github.com/repos/zvikorn/containerized-data-importer/commits{/sha}","git_commits_url":"https://api.github.com/repos/zvikorn/containerized-data-importer/git/commits{/sha}","comments_url":"https://api.github.com/repos/zvikorn/containerized-data-importer/comments{/number}","issue_comment_url":"https://api.github.com/repos/zvikorn/containerized-data-importer/issues/comments{/number}","contents_url":"https://api.github.com/repos/zvikorn/containerized-data-importer/contents/{+path}","compare_url":"https://api.github.com/repos/zvikorn/containerized-data-importer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zvikorn/containerized-data-importer/merges","archive_url":"https://api.github.com/repos/zvikorn/containerized-data-importer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zvikorn/containerized-data-importer/downloads","issues_url":"https://api.github.com/repos/zvikorn/containerized-data-importer/issues{/number}","pulls_url":"https://api.github.com/repos/zvikorn/containerized-data-importer/pulls{/number}","milestones_url":"https://api.github.com/repos/zvikorn/containerized-data-importer/milestones{/number}","notifications_url":"https://api.github.com/repos/zvikorn/containerized-data-importer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zvikorn/containerized-data-importer/labels{/name}","releases_url":"https://api.github.com/repos/zvikorn/containerized-data-importer/releases{/id}","deployments_url":"https://api.github.com/repos/zvikorn/containerized-data-importer/deployments","created_at":"2018-06-18T07:26:36Z","updated_at":"2018-06-21T10:48:57Z","pushed_at":"2018-06-21T10:48:55Z","git_url":"git://github.com/zvikorn/containerized-data-importer.git","ssh_url":"[email protected]:zvikorn/containerized-data-importer.git","clone_url":"https://github.com/zvikorn/containerized-data-importer.git","svn_url":"https://github.com/zvikorn/containerized-data-importer","homepage":"","size":35084,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubevirt:master","ref":"master","sha":"1e16a9d5fdec729b00977aa6142154628ac4674d","user":{"login":"kubevirt","id":18700703,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NzAwNzAz","avatar_url":"https://avatars1.githubusercontent.com/u/18700703?v=4","gravatar_id":"","url":"https://api.github.com/users/kubevirt","html_url":"https://github.com/kubevirt","followers_url":"https://api.github.com/users/kubevirt/followers","following_url":"https://api.github.com/users/kubevirt/following{/other_user}","gists_url":"https://api.github.com/users/kubevirt/gists{/gist_id}","starred_url":"https://api.github.com/users/kubevirt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubevirt/subscriptions","organizations_url":"https://api.github.com/users/kubevirt/orgs","repos_url":"https://api.github.com/users/kubevirt/repos","events_url":"https://api.github.com/users/kubevirt/events{/privacy}","received_events_url":"https://api.github.com/users/kubevirt/received_events","type":"Organization","site_admin":false},"repo":{"id":117756215,"node_id":"MDEwOlJlcG9zaXRvcnkxMTc3NTYyMTU=","name":"containerized-data-importer","full_name":"kubevirt/containerized-data-importer","owner":{"login":"kubevirt","id":18700703,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NzAwNzAz","avatar_url":"https://avatars1.githubusercontent.com/u/18700703?v=4","gravatar_id":"","url":"https://api.github.com/users/kubevirt","html_url":"https://github.com/kubevirt","followers_url":"https://api.github.com/users/kubevirt/followers","following_url":"https://api.github.com/users/kubevirt/following{/other_user}","gists_url":"https://api.github.com/users/kubevirt/gists{/gist_id}","starred_url":"https://api.github.com/users/kubevirt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubevirt/subscriptions","organizations_url":"https://api.github.com/users/kubevirt/orgs","repos_url":"https://api.github.com/users/kubevirt/repos","events_url":"https://api.github.com/users/kubevirt/events{/privacy}","received_events_url":"https://api.github.com/users/kubevirt/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubevirt/containerized-data-importer","description":"Data Import Service for kubernetes, designed with kubevirt in mind.","fork":false,"url":"https://api.github.com/repos/kubevirt/containerized-data-importer","forks_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/forks","keys_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/teams","hooks_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/hooks","issue_events_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/issues/events{/number}","events_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/events","assignees_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/assignees{/user}","branches_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/branches{/branch}","tags_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/tags","blobs_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/statuses/{sha}","languages_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/languages","stargazers_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/stargazers","contributors_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/contributors","subscribers_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/subscribers","subscription_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/subscription","commits_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/contents/{+path}","compare_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/merges","archive_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/downloads","issues_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/issues{/number}","pulls_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/pulls{/number}","milestones_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/milestones{/number}","notifications_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/labels{/name}","releases_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/releases{/id}","deployments_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/deployments","created_at":"2018-01-16T23:35:48Z","updated_at":"2018-06-27T20:26:21Z","pushed_at":"2018-06-29T15:32:46Z","git_url":"git://github.com/kubevirt/containerized-data-importer.git","ssh_url":"[email protected]:kubevirt/containerized-data-importer.git","clone_url":"https://github.com/kubevirt/containerized-data-importer.git","svn_url":"https://github.com/kubevirt/containerized-data-importer","homepage":"","size":35101,"stargazers_count":4,"watchers_count":4,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"archived":false,"open_issues_count":18,"license":null,"forks":11,"open_issues":18,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubevirt/containerized-data-importer/pulls/219"},"html":{"href":"https://github.com/kubevirt/containerized-data-importer/pull/219"},"issue":{"href":"https://api.github.com/repos/kubevirt/containerized-data-importer/issues/219"},"comments":{"href":"https://api.github.com/repos/kubevirt/containerized-data-importer/issues/219/comments"},"review_comments":{"href":"https://api.github.com/repos/kubevirt/containerized-data-importer/pulls/219/comments"},"review_comment":{"href":"https://api.github.com/repos/kubevirt/containerized-data-importer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubevirt/containerized-data-importer/pulls/219/commits"},"statuses":{"href":"https://api.github.com/repos/kubevirt/containerized-data-importer/statuses/ca271bd534babdd9c3fd63958fbf4d86e09a706c"}},"author_association":"NONE"}} | {
"id": 117756215,
"name": "kubevirt/containerized-data-importer",
"url": "https://api.github.com/repos/kubevirt/containerized-data-importer"
} | {
"id": 3076896,
"login": "jeffvance",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3076896?",
"url": "https://api.github.com/users/jeffvance"
} | {
"id": 18700703,
"login": "kubevirt",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/18700703?",
"url": "https://api.github.com/orgs/kubevirt"
} | 2018-06-29T21:03:59 | 7899981370 | {"actor":{"display_login":"jeffvance"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/kubevirt/web-ui-design/pulls/comments/220685949","pull_request_review_id":159151704,"id":220685949,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMDY4NTk0OQ==","diff_hunk":"@@ -0,0 +1,33 @@\n+# Clone VM\n+\n+\n+\n+Cloning a VM allows the user to quickly create an identical copy of a virtual machine while powered off.\n+\n+\n+\n+Cloning is accessed from the VM List View. All item filters should be turned on by default, ensuring that all VMs are shown to the user.\n+\n+The Clone option should appear in the kebab menu whether the target is online or offline.\n+\n+\n+\n+If the VM is powered on, a warning will appear at the top of the Clone Virtual Machine modal. Running VMs will be shut down automatically if the user proceeds with a clone and then turned back on once the clone finishes.\n+\n+The only required field is the name, which is pre-filled based on the target VM’s name and appended with “-clone”. The user can add a description and change the new VM’s Namespace (which is the same as the target by default). They can also turn off the option to start the virtual machine after the cloning process finishes.\n+\n+Because all required fields are filled in by default, the \"Clone Virtual Machine” button is active. If the user deletes the Name field this button will become inactive.\n+\n+Details of the target VM’s configuration are displayed for the user’s reference. These options cannot be modified here prior to cloning.\n+\n+The user would then click “Clone Virtual Machine”.\n+\n+\n+\n+If the target VM fails to shut down properly, an error toast notification would be displayed. The user would then need to power off the VM manually and re-open the Clone modal to try again.\n+\n+\n+\n+If the cloning process starts successfully, the newly-cloned VM will appear in the list and a toast notification will confirm that the cloning process has begun. The status icon of the clone is a spinner with a completion percentage next to it. The clone does not have an IP address until after its first boot.\n+","path":"ui-design/virtual-machines/clone-vm/clone-vm.md","position":32,"original_position":32,"commit_id":"4004d4dfb02b23614c759ef2219c430fd3a2c2c2","original_commit_id":"4004d4dfb02b23614c759ef2219c430fd3a2c2c2","user":{"login":"aglitke","id":333311,"node_id":"MDQ6VXNlcjMzMzMxMQ==","avatar_url":"https://avatars2.githubusercontent.com/u/333311?v=4","gravatar_id":"","url":"https://api.github.com/users/aglitke","html_url":"https://github.com/aglitke","followers_url":"https://api.github.com/users/aglitke/followers","following_url":"https://api.github.com/users/aglitke/following{/other_user}","gists_url":"https://api.github.com/users/aglitke/gists{/gist_id}","starred_url":"https://api.github.com/users/aglitke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aglitke/subscriptions","organizations_url":"https://api.github.com/users/aglitke/orgs","repos_url":"https://api.github.com/users/aglitke/repos","events_url":"https://api.github.com/users/aglitke/events{/privacy}","received_events_url":"https://api.github.com/users/aglitke/received_events","type":"User","site_admin":false},"body":"We should disable certain operations on the source VM during a clone operation (such as starting the VM). Perhaps the VM's status icon should change to a lock or something? We will need to figure out a way to lock VMs from starting (maybe an addition to the VM CRD?)","created_at":"2018-09-26T19:03:05Z","updated_at":"2018-09-26T19:03:06Z","html_url":"https://github.com/kubevirt/web-ui-design/pull/11#discussion_r220685949","pull_request_url":"https://api.github.com/repos/kubevirt/web-ui-design/pulls/11","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/kubevirt/web-ui-design/pulls/comments/220685949"},"html":{"href":"https://github.com/kubevirt/web-ui-design/pull/11#discussion_r220685949"},"pull_request":{"href":"https://api.github.com/repos/kubevirt/web-ui-design/pulls/11"}}},"pull_request":{"url":"https://api.github.com/repos/kubevirt/web-ui-design/pulls/11","id":218351156,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE4MzUxMTU2","html_url":"https://github.com/kubevirt/web-ui-design/pull/11","diff_url":"https://github.com/kubevirt/web-ui-design/pull/11.diff","patch_url":"https://github.com/kubevirt/web-ui-design/pull/11.patch","issue_url":"https://api.github.com/repos/kubevirt/web-ui-design/issues/11","number":11,"state":"open","locked":false,"title":"Add Clone VM documentation","user":{"login":"andybraren","id":9122899,"node_id":"MDQ6VXNlcjkxMjI4OTk=","avatar_url":"https://avatars1.githubusercontent.com/u/9122899?v=4","gravatar_id":"","url":"https://api.github.com/users/andybraren","html_url":"https://github.com/andybraren","followers_url":"https://api.github.com/users/andybraren/followers","following_url":"https://api.github.com/users/andybraren/following{/other_user}","gists_url":"https://api.github.com/users/andybraren/gists{/gist_id}","starred_url":"https://api.github.com/users/andybraren/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andybraren/subscriptions","organizations_url":"https://api.github.com/users/andybraren/orgs","repos_url":"https://api.github.com/users/andybraren/repos","events_url":"https://api.github.com/users/andybraren/events{/privacy}","received_events_url":"https://api.github.com/users/andybraren/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-09-26T15:02:09Z","updated_at":"2018-09-26T19:03:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f202e799433c5ea38515ea8eccd523200c0df8f7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/kubevirt/web-ui-design/pulls/11/commits","review_comments_url":"https://api.github.com/repos/kubevirt/web-ui-design/pulls/11/comments","review_comment_url":"https://api.github.com/repos/kubevirt/web-ui-design/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubevirt/web-ui-design/issues/11/comments","statuses_url":"https://api.github.com/repos/kubevirt/web-ui-design/statuses/4004d4dfb02b23614c759ef2219c430fd3a2c2c2","head":{"label":"andybraren:edit-clone-vm","ref":"edit-clone-vm","sha":"4004d4dfb02b23614c759ef2219c430fd3a2c2c2","user":{"login":"andybraren","id":9122899,"node_id":"MDQ6VXNlcjkxMjI4OTk=","avatar_url":"https://avatars1.githubusercontent.com/u/9122899?v=4","gravatar_id":"","url":"https://api.github.com/users/andybraren","html_url":"https://github.com/andybraren","followers_url":"https://api.github.com/users/andybraren/followers","following_url":"https://api.github.com/users/andybraren/following{/other_user}","gists_url":"https://api.github.com/users/andybraren/gists{/gist_id}","starred_url":"https://api.github.com/users/andybraren/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andybraren/subscriptions","organizations_url":"https://api.github.com/users/andybraren/orgs","repos_url":"https://api.github.com/users/andybraren/repos","events_url":"https://api.github.com/users/andybraren/events{/privacy}","received_events_url":"https://api.github.com/users/andybraren/received_events","type":"User","site_admin":false},"repo":{"id":146649251,"node_id":"MDEwOlJlcG9zaXRvcnkxNDY2NDkyNTE=","name":"web-ui-design","full_name":"andybraren/web-ui-design","private":false,"owner":{"login":"andybraren","id":9122899,"node_id":"MDQ6VXNlcjkxMjI4OTk=","avatar_url":"https://avatars1.githubusercontent.com/u/9122899?v=4","gravatar_id":"","url":"https://api.github.com/users/andybraren","html_url":"https://github.com/andybraren","followers_url":"https://api.github.com/users/andybraren/followers","following_url":"https://api.github.com/users/andybraren/following{/other_user}","gists_url":"https://api.github.com/users/andybraren/gists{/gist_id}","starred_url":"https://api.github.com/users/andybraren/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andybraren/subscriptions","organizations_url":"https://api.github.com/users/andybraren/orgs","repos_url":"https://api.github.com/users/andybraren/repos","events_url":"https://api.github.com/users/andybraren/events{/privacy}","received_events_url":"https://api.github.com/users/andybraren/received_events","type":"User","site_admin":false},"html_url":"https://github.com/andybraren/web-ui-design","description":" Images and Markdown documenting proposed user workflows for the UI","fork":true,"url":"https://api.github.com/repos/andybraren/web-ui-design","forks_url":"https://api.github.com/repos/andybraren/web-ui-design/forks","keys_url":"https://api.github.com/repos/andybraren/web-ui-design/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andybraren/web-ui-design/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andybraren/web-ui-design/teams","hooks_url":"https://api.github.com/repos/andybraren/web-ui-design/hooks","issue_events_url":"https://api.github.com/repos/andybraren/web-ui-design/issues/events{/number}","events_url":"https://api.github.com/repos/andybraren/web-ui-design/events","assignees_url":"https://api.github.com/repos/andybraren/web-ui-design/assignees{/user}","branches_url":"https://api.github.com/repos/andybraren/web-ui-design/branches{/branch}","tags_url":"https://api.github.com/repos/andybraren/web-ui-design/tags","blobs_url":"https://api.github.com/repos/andybraren/web-ui-design/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andybraren/web-ui-design/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andybraren/web-ui-design/git/refs{/sha}","trees_url":"https://api.github.com/repos/andybraren/web-ui-design/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andybraren/web-ui-design/statuses/{sha}","languages_url":"https://api.github.com/repos/andybraren/web-ui-design/languages","stargazers_url":"https://api.github.com/repos/andybraren/web-ui-design/stargazers","contributors_url":"https://api.github.com/repos/andybraren/web-ui-design/contributors","subscribers_url":"https://api.github.com/repos/andybraren/web-ui-design/subscribers","subscription_url":"https://api.github.com/repos/andybraren/web-ui-design/subscription","commits_url":"https://api.github.com/repos/andybraren/web-ui-design/commits{/sha}","git_commits_url":"https://api.github.com/repos/andybraren/web-ui-design/git/commits{/sha}","comments_url":"https://api.github.com/repos/andybraren/web-ui-design/comments{/number}","issue_comment_url":"https://api.github.com/repos/andybraren/web-ui-design/issues/comments{/number}","contents_url":"https://api.github.com/repos/andybraren/web-ui-design/contents/{+path}","compare_url":"https://api.github.com/repos/andybraren/web-ui-design/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andybraren/web-ui-design/merges","archive_url":"https://api.github.com/repos/andybraren/web-ui-design/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andybraren/web-ui-design/downloads","issues_url":"https://api.github.com/repos/andybraren/web-ui-design/issues{/number}","pulls_url":"https://api.github.com/repos/andybraren/web-ui-design/pulls{/number}","milestones_url":"https://api.github.com/repos/andybraren/web-ui-design/milestones{/number}","notifications_url":"https://api.github.com/repos/andybraren/web-ui-design/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andybraren/web-ui-design/labels{/name}","releases_url":"https://api.github.com/repos/andybraren/web-ui-design/releases{/id}","deployments_url":"https://api.github.com/repos/andybraren/web-ui-design/deployments","created_at":"2018-08-29T19:37:59Z","updated_at":"2018-09-26T14:11:59Z","pushed_at":"2018-09-26T15:01:59Z","git_url":"git://github.com/andybraren/web-ui-design.git","ssh_url":"[email protected]:andybraren/web-ui-design.git","clone_url":"https://github.com/andybraren/web-ui-design.git","svn_url":"https://github.com/andybraren/web-ui-design","homepage":"","size":4078,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubevirt:master","ref":"master","sha":"20d39cba6878d57b3d37ae58ed85cf39d79220da","user":{"login":"kubevirt","id":18700703,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NzAwNzAz","avatar_url":"https://avatars1.githubusercontent.com/u/18700703?v=4","gravatar_id":"","url":"https://api.github.com/users/kubevirt","html_url":"https://github.com/kubevirt","followers_url":"https://api.github.com/users/kubevirt/followers","following_url":"https://api.github.com/users/kubevirt/following{/other_user}","gists_url":"https://api.github.com/users/kubevirt/gists{/gist_id}","starred_url":"https://api.github.com/users/kubevirt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubevirt/subscriptions","organizations_url":"https://api.github.com/users/kubevirt/orgs","repos_url":"https://api.github.com/users/kubevirt/repos","events_url":"https://api.github.com/users/kubevirt/events{/privacy}","received_events_url":"https://api.github.com/users/kubevirt/received_events","type":"Organization","site_admin":false},"repo":{"id":146456816,"node_id":"MDEwOlJlcG9zaXRvcnkxNDY0NTY4MTY=","name":"web-ui-design","full_name":"kubevirt/web-ui-design","private":false,"owner":{"login":"kubevirt","id":18700703,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NzAwNzAz","avatar_url":"https://avatars1.githubusercontent.com/u/18700703?v=4","gravatar_id":"","url":"https://api.github.com/users/kubevirt","html_url":"https://github.com/kubevirt","followers_url":"https://api.github.com/users/kubevirt/followers","following_url":"https://api.github.com/users/kubevirt/following{/other_user}","gists_url":"https://api.github.com/users/kubevirt/gists{/gist_id}","starred_url":"https://api.github.com/users/kubevirt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubevirt/subscriptions","organizations_url":"https://api.github.com/users/kubevirt/orgs","repos_url":"https://api.github.com/users/kubevirt/repos","events_url":"https://api.github.com/users/kubevirt/events{/privacy}","received_events_url":"https://api.github.com/users/kubevirt/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/kubevirt/web-ui-design","description":" Images and Markdown documenting proposed user workflows for the UI","fork":false,"url":"https://api.github.com/repos/kubevirt/web-ui-design","forks_url":"https://api.github.com/repos/kubevirt/web-ui-design/forks","keys_url":"https://api.github.com/repos/kubevirt/web-ui-design/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubevirt/web-ui-design/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubevirt/web-ui-design/teams","hooks_url":"https://api.github.com/repos/kubevirt/web-ui-design/hooks","issue_events_url":"https://api.github.com/repos/kubevirt/web-ui-design/issues/events{/number}","events_url":"https://api.github.com/repos/kubevirt/web-ui-design/events","assignees_url":"https://api.github.com/repos/kubevirt/web-ui-design/assignees{/user}","branches_url":"https://api.github.com/repos/kubevirt/web-ui-design/branches{/branch}","tags_url":"https://api.github.com/repos/kubevirt/web-ui-design/tags","blobs_url":"https://api.github.com/repos/kubevirt/web-ui-design/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubevirt/web-ui-design/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubevirt/web-ui-design/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubevirt/web-ui-design/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubevirt/web-ui-design/statuses/{sha}","languages_url":"https://api.github.com/repos/kubevirt/web-ui-design/languages","stargazers_url":"https://api.github.com/repos/kubevirt/web-ui-design/stargazers","contributors_url":"https://api.github.com/repos/kubevirt/web-ui-design/contributors","subscribers_url":"https://api.github.com/repos/kubevirt/web-ui-design/subscribers","subscription_url":"https://api.github.com/repos/kubevirt/web-ui-design/subscription","commits_url":"https://api.github.com/repos/kubevirt/web-ui-design/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubevirt/web-ui-design/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubevirt/web-ui-design/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubevirt/web-ui-design/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubevirt/web-ui-design/contents/{+path}","compare_url":"https://api.github.com/repos/kubevirt/web-ui-design/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubevirt/web-ui-design/merges","archive_url":"https://api.github.com/repos/kubevirt/web-ui-design/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubevirt/web-ui-design/downloads","issues_url":"https://api.github.com/repos/kubevirt/web-ui-design/issues{/number}","pulls_url":"https://api.github.com/repos/kubevirt/web-ui-design/pulls{/number}","milestones_url":"https://api.github.com/repos/kubevirt/web-ui-design/milestones{/number}","notifications_url":"https://api.github.com/repos/kubevirt/web-ui-design/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubevirt/web-ui-design/labels{/name}","releases_url":"https://api.github.com/repos/kubevirt/web-ui-design/releases{/id}","deployments_url":"https://api.github.com/repos/kubevirt/web-ui-design/deployments","created_at":"2018-08-28T14:05:32Z","updated_at":"2018-09-26T14:11:36Z","pushed_at":"2018-09-26T15:02:10Z","git_url":"git://github.com/kubevirt/web-ui-design.git","ssh_url":"[email protected]:kubevirt/web-ui-design.git","clone_url":"https://github.com/kubevirt/web-ui-design.git","svn_url":"https://github.com/kubevirt/web-ui-design","homepage":"","size":1618,"stargazers_count":1,"watchers_count":1,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2,"open_issues":4,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubevirt/web-ui-design/pulls/11"},"html":{"href":"https://github.com/kubevirt/web-ui-design/pull/11"},"issue":{"href":"https://api.github.com/repos/kubevirt/web-ui-design/issues/11"},"comments":{"href":"https://api.github.com/repos/kubevirt/web-ui-design/issues/11/comments"},"review_comments":{"href":"https://api.github.com/repos/kubevirt/web-ui-design/pulls/11/comments"},"review_comment":{"href":"https://api.github.com/repos/kubevirt/web-ui-design/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubevirt/web-ui-design/pulls/11/commits"},"statuses":{"href":"https://api.github.com/repos/kubevirt/web-ui-design/statuses/4004d4dfb02b23614c759ef2219c430fd3a2c2c2"}},"author_association":"COLLABORATOR"}} | {
"id": 146456816,
"name": "kubevirt/web-ui-design",
"url": "https://api.github.com/repos/kubevirt/web-ui-design"
} | {
"id": 333311,
"login": "aglitke",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/333311?",
"url": "https://api.github.com/users/aglitke"
} | {
"id": 18700703,
"login": "kubevirt",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/18700703?",
"url": "https://api.github.com/orgs/kubevirt"
} | 2018-09-26T19:03:05 | 8326948986 | {"actor":{"display_login":"aglitke"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/indiemoney/react-native-slider/pulls/comments/165545252","pull_request_review_id":93504315,"id":165545252,"diff_hunk":"@@ -352,7 +353,7 @@ export default class Slider extends PureComponent {\n trackHighlightStyle = {\n position: 'absolute',\n left: 0,\n- width: Animated.add(thumbLeft, thumbSize.width / 2),","path":"src/Slider.js","position":18,"original_position":18,"commit_id":"708f57c076271c2739b42a1dddecf2fc8b6da624","original_commit_id":"708f57c076271c2739b42a1dddecf2fc8b6da624","user":{"login":"idealllee","id":700961,"avatar_url":"https://avatars0.githubusercontent.com/u/700961?v=4","gravatar_id":"","url":"https://api.github.com/users/idealllee","html_url":"https://github.com/idealllee","followers_url":"https://api.github.com/users/idealllee/followers","following_url":"https://api.github.com/users/idealllee/following{/other_user}","gists_url":"https://api.github.com/users/idealllee/gists{/gist_id}","starred_url":"https://api.github.com/users/idealllee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/idealllee/subscriptions","organizations_url":"https://api.github.com/users/idealllee/orgs","repos_url":"https://api.github.com/users/idealllee/repos","events_url":"https://api.github.com/users/idealllee/events{/privacy}","received_events_url":"https://api.github.com/users/idealllee/received_events","type":"User","site_admin":false},"body":"`thumbLeft` was removed though still referenced here which gives us run time errors","created_at":"2018-02-02T02:29:41Z","updated_at":"2018-02-02T02:29:41Z","html_url":"https://github.com/indiemoney/react-native-slider/pull/1#discussion_r165545252","pull_request_url":"https://api.github.com/repos/indiemoney/react-native-slider/pulls/1","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/indiemoney/react-native-slider/pulls/comments/165545252"},"html":{"href":"https://github.com/indiemoney/react-native-slider/pull/1#discussion_r165545252"},"pull_request":{"href":"https://api.github.com/repos/indiemoney/react-native-slider/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/indiemoney/react-native-slider/pulls/1","id":166703839,"html_url":"https://github.com/indiemoney/react-native-slider/pull/1","diff_url":"https://github.com/indiemoney/react-native-slider/pull/1.diff","patch_url":"https://github.com/indiemoney/react-native-slider/pull/1.patch","issue_url":"https://api.github.com/repos/indiemoney/react-native-slider/issues/1","number":1,"state":"open","locked":false,"title":"attemp to fix existing functionality","user":{"login":"idealllee","id":700961,"avatar_url":"https://avatars0.githubusercontent.com/u/700961?v=4","gravatar_id":"","url":"https://api.github.com/users/idealllee","html_url":"https://github.com/idealllee","followers_url":"https://api.github.com/users/idealllee/followers","following_url":"https://api.github.com/users/idealllee/following{/other_user}","gists_url":"https://api.github.com/users/idealllee/gists{/gist_id}","starred_url":"https://api.github.com/users/idealllee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/idealllee/subscriptions","organizations_url":"https://api.github.com/users/idealllee/orgs","repos_url":"https://api.github.com/users/idealllee/repos","events_url":"https://api.github.com/users/idealllee/events{/privacy}","received_events_url":"https://api.github.com/users/idealllee/received_events","type":"User","site_admin":false},"body":"The `patch-1` branch has the changes to add multiple thumbs and original PR here: https://github.com/jeanregisser/react-native-slider/pull/89/files\r\n\r\nThough it breaks existing functionalities (see comments) below and this PR still doesn't fix the incorrect track highlighting issue. ","created_at":"2018-02-02T02:28:59Z","updated_at":"2018-02-02T02:29:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"89a9dd31ab8b72135ca883e1092334e2fd8cd649","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/indiemoney/react-native-slider/pulls/1/commits","review_comments_url":"https://api.github.com/repos/indiemoney/react-native-slider/pulls/1/comments","review_comment_url":"https://api.github.com/repos/indiemoney/react-native-slider/pulls/comments{/number}","comments_url":"https://api.github.com/repos/indiemoney/react-native-slider/issues/1/comments","statuses_url":"https://api.github.com/repos/indiemoney/react-native-slider/statuses/708f57c076271c2739b42a1dddecf2fc8b6da624","head":{"label":"indiemoney:fix-single","ref":"fix-single","sha":"708f57c076271c2739b42a1dddecf2fc8b6da624","user":{"login":"indiemoney","id":18709998,"avatar_url":"https://avatars2.githubusercontent.com/u/18709998?v=4","gravatar_id":"","url":"https://api.github.com/users/indiemoney","html_url":"https://github.com/indiemoney","followers_url":"https://api.github.com/users/indiemoney/followers","following_url":"https://api.github.com/users/indiemoney/following{/other_user}","gists_url":"https://api.github.com/users/indiemoney/gists{/gist_id}","starred_url":"https://api.github.com/users/indiemoney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/indiemoney/subscriptions","organizations_url":"https://api.github.com/users/indiemoney/orgs","repos_url":"https://api.github.com/users/indiemoney/repos","events_url":"https://api.github.com/users/indiemoney/events{/privacy}","received_events_url":"https://api.github.com/users/indiemoney/received_events","type":"Organization","site_admin":false},"repo":{"id":119901657,"name":"react-native-slider","full_name":"indiemoney/react-native-slider","owner":{"login":"indiemoney","id":18709998,"avatar_url":"https://avatars2.githubusercontent.com/u/18709998?v=4","gravatar_id":"","url":"https://api.github.com/users/indiemoney","html_url":"https://github.com/indiemoney","followers_url":"https://api.github.com/users/indiemoney/followers","following_url":"https://api.github.com/users/indiemoney/following{/other_user}","gists_url":"https://api.github.com/users/indiemoney/gists{/gist_id}","starred_url":"https://api.github.com/users/indiemoney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/indiemoney/subscriptions","organizations_url":"https://api.github.com/users/indiemoney/orgs","repos_url":"https://api.github.com/users/indiemoney/repos","events_url":"https://api.github.com/users/indiemoney/events{/privacy}","received_events_url":"https://api.github.com/users/indiemoney/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/indiemoney/react-native-slider","description":"A pure JavaScript <Slider> component for react-native","fork":true,"url":"https://api.github.com/repos/indiemoney/react-native-slider","forks_url":"https://api.github.com/repos/indiemoney/react-native-slider/forks","keys_url":"https://api.github.com/repos/indiemoney/react-native-slider/keys{/key_id}","collaborators_url":"https://api.github.com/repos/indiemoney/react-native-slider/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/indiemoney/react-native-slider/teams","hooks_url":"https://api.github.com/repos/indiemoney/react-native-slider/hooks","issue_events_url":"https://api.github.com/repos/indiemoney/react-native-slider/issues/events{/number}","events_url":"https://api.github.com/repos/indiemoney/react-native-slider/events","assignees_url":"https://api.github.com/repos/indiemoney/react-native-slider/assignees{/user}","branches_url":"https://api.github.com/repos/indiemoney/react-native-slider/branches{/branch}","tags_url":"https://api.github.com/repos/indiemoney/react-native-slider/tags","blobs_url":"https://api.github.com/repos/indiemoney/react-native-slider/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/indiemoney/react-native-slider/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/indiemoney/react-native-slider/git/refs{/sha}","trees_url":"https://api.github.com/repos/indiemoney/react-native-slider/git/trees{/sha}","statuses_url":"https://api.github.com/repos/indiemoney/react-native-slider/statuses/{sha}","languages_url":"https://api.github.com/repos/indiemoney/react-native-slider/languages","stargazers_url":"https://api.github.com/repos/indiemoney/react-native-slider/stargazers","contributors_url":"https://api.github.com/repos/indiemoney/react-native-slider/contributors","subscribers_url":"https://api.github.com/repos/indiemoney/react-native-slider/subscribers","subscription_url":"https://api.github.com/repos/indiemoney/react-native-slider/subscription","commits_url":"https://api.github.com/repos/indiemoney/react-native-slider/commits{/sha}","git_commits_url":"https://api.github.com/repos/indiemoney/react-native-slider/git/commits{/sha}","comments_url":"https://api.github.com/repos/indiemoney/react-native-slider/comments{/number}","issue_comment_url":"https://api.github.com/repos/indiemoney/react-native-slider/issues/comments{/number}","contents_url":"https://api.github.com/repos/indiemoney/react-native-slider/contents/{+path}","compare_url":"https://api.github.com/repos/indiemoney/react-native-slider/compare/{base}...{head}","merges_url":"https://api.github.com/repos/indiemoney/react-native-slider/merges","archive_url":"https://api.github.com/repos/indiemoney/react-native-slider/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/indiemoney/react-native-slider/downloads","issues_url":"https://api.github.com/repos/indiemoney/react-native-slider/issues{/number}","pulls_url":"https://api.github.com/repos/indiemoney/react-native-slider/pulls{/number}","milestones_url":"https://api.github.com/repos/indiemoney/react-native-slider/milestones{/number}","notifications_url":"https://api.github.com/repos/indiemoney/react-native-slider/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/indiemoney/react-native-slider/labels{/name}","releases_url":"https://api.github.com/repos/indiemoney/react-native-slider/releases{/id}","deployments_url":"https://api.github.com/repos/indiemoney/react-native-slider/deployments","created_at":"2018-02-01T22:31:46Z","updated_at":"2018-02-01T22:31:48Z","pushed_at":"2018-02-02T02:29:00Z","git_url":"git://github.com/indiemoney/react-native-slider.git","ssh_url":"[email protected]:indiemoney/react-native-slider.git","clone_url":"https://github.com/indiemoney/react-native-slider.git","svn_url":"https://github.com/indiemoney/react-native-slider","homepage":"","size":1058,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"indiemoney:patch-1","ref":"patch-1","sha":"b70fbf9a04069faa8ea8a31e1394494f30dd33d0","user":{"login":"indiemoney","id":18709998,"avatar_url":"https://avatars2.githubusercontent.com/u/18709998?v=4","gravatar_id":"","url":"https://api.github.com/users/indiemoney","html_url":"https://github.com/indiemoney","followers_url":"https://api.github.com/users/indiemoney/followers","following_url":"https://api.github.com/users/indiemoney/following{/other_user}","gists_url":"https://api.github.com/users/indiemoney/gists{/gist_id}","starred_url":"https://api.github.com/users/indiemoney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/indiemoney/subscriptions","organizations_url":"https://api.github.com/users/indiemoney/orgs","repos_url":"https://api.github.com/users/indiemoney/repos","events_url":"https://api.github.com/users/indiemoney/events{/privacy}","received_events_url":"https://api.github.com/users/indiemoney/received_events","type":"Organization","site_admin":false},"repo":{"id":119901657,"name":"react-native-slider","full_name":"indiemoney/react-native-slider","owner":{"login":"indiemoney","id":18709998,"avatar_url":"https://avatars2.githubusercontent.com/u/18709998?v=4","gravatar_id":"","url":"https://api.github.com/users/indiemoney","html_url":"https://github.com/indiemoney","followers_url":"https://api.github.com/users/indiemoney/followers","following_url":"https://api.github.com/users/indiemoney/following{/other_user}","gists_url":"https://api.github.com/users/indiemoney/gists{/gist_id}","starred_url":"https://api.github.com/users/indiemoney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/indiemoney/subscriptions","organizations_url":"https://api.github.com/users/indiemoney/orgs","repos_url":"https://api.github.com/users/indiemoney/repos","events_url":"https://api.github.com/users/indiemoney/events{/privacy}","received_events_url":"https://api.github.com/users/indiemoney/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/indiemoney/react-native-slider","description":"A pure JavaScript <Slider> component for react-native","fork":true,"url":"https://api.github.com/repos/indiemoney/react-native-slider","forks_url":"https://api.github.com/repos/indiemoney/react-native-slider/forks","keys_url":"https://api.github.com/repos/indiemoney/react-native-slider/keys{/key_id}","collaborators_url":"https://api.github.com/repos/indiemoney/react-native-slider/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/indiemoney/react-native-slider/teams","hooks_url":"https://api.github.com/repos/indiemoney/react-native-slider/hooks","issue_events_url":"https://api.github.com/repos/indiemoney/react-native-slider/issues/events{/number}","events_url":"https://api.github.com/repos/indiemoney/react-native-slider/events","assignees_url":"https://api.github.com/repos/indiemoney/react-native-slider/assignees{/user}","branches_url":"https://api.github.com/repos/indiemoney/react-native-slider/branches{/branch}","tags_url":"https://api.github.com/repos/indiemoney/react-native-slider/tags","blobs_url":"https://api.github.com/repos/indiemoney/react-native-slider/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/indiemoney/react-native-slider/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/indiemoney/react-native-slider/git/refs{/sha}","trees_url":"https://api.github.com/repos/indiemoney/react-native-slider/git/trees{/sha}","statuses_url":"https://api.github.com/repos/indiemoney/react-native-slider/statuses/{sha}","languages_url":"https://api.github.com/repos/indiemoney/react-native-slider/languages","stargazers_url":"https://api.github.com/repos/indiemoney/react-native-slider/stargazers","contributors_url":"https://api.github.com/repos/indiemoney/react-native-slider/contributors","subscribers_url":"https://api.github.com/repos/indiemoney/react-native-slider/subscribers","subscription_url":"https://api.github.com/repos/indiemoney/react-native-slider/subscription","commits_url":"https://api.github.com/repos/indiemoney/react-native-slider/commits{/sha}","git_commits_url":"https://api.github.com/repos/indiemoney/react-native-slider/git/commits{/sha}","comments_url":"https://api.github.com/repos/indiemoney/react-native-slider/comments{/number}","issue_comment_url":"https://api.github.com/repos/indiemoney/react-native-slider/issues/comments{/number}","contents_url":"https://api.github.com/repos/indiemoney/react-native-slider/contents/{+path}","compare_url":"https://api.github.com/repos/indiemoney/react-native-slider/compare/{base}...{head}","merges_url":"https://api.github.com/repos/indiemoney/react-native-slider/merges","archive_url":"https://api.github.com/repos/indiemoney/react-native-slider/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/indiemoney/react-native-slider/downloads","issues_url":"https://api.github.com/repos/indiemoney/react-native-slider/issues{/number}","pulls_url":"https://api.github.com/repos/indiemoney/react-native-slider/pulls{/number}","milestones_url":"https://api.github.com/repos/indiemoney/react-native-slider/milestones{/number}","notifications_url":"https://api.github.com/repos/indiemoney/react-native-slider/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/indiemoney/react-native-slider/labels{/name}","releases_url":"https://api.github.com/repos/indiemoney/react-native-slider/releases{/id}","deployments_url":"https://api.github.com/repos/indiemoney/react-native-slider/deployments","created_at":"2018-02-01T22:31:46Z","updated_at":"2018-02-01T22:31:48Z","pushed_at":"2018-02-02T02:29:00Z","git_url":"git://github.com/indiemoney/react-native-slider.git","ssh_url":"[email protected]:indiemoney/react-native-slider.git","clone_url":"https://github.com/indiemoney/react-native-slider.git","svn_url":"https://github.com/indiemoney/react-native-slider","homepage":"","size":1058,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/indiemoney/react-native-slider/pulls/1"},"html":{"href":"https://github.com/indiemoney/react-native-slider/pull/1"},"issue":{"href":"https://api.github.com/repos/indiemoney/react-native-slider/issues/1"},"comments":{"href":"https://api.github.com/repos/indiemoney/react-native-slider/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/indiemoney/react-native-slider/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/indiemoney/react-native-slider/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/indiemoney/react-native-slider/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/indiemoney/react-native-slider/statuses/708f57c076271c2739b42a1dddecf2fc8b6da624"}},"author_association":"NONE"}} | {
"id": 119901657,
"name": "indiemoney/react-native-slider",
"url": "https://api.github.com/repos/indiemoney/react-native-slider"
} | {
"id": 700961,
"login": "idealllee",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/700961?",
"url": "https://api.github.com/users/idealllee"
} | {
"id": 18709998,
"login": "indiemoney",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/18709998?",
"url": "https://api.github.com/orgs/indiemoney"
} | 2018-02-02T02:29:41 | 7187027636 | {"actor":{"display_login":"idealllee"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/aceleradora-TW/hospebem/pulls/comments/237099878","pull_request_review_id":179314197,"id":237099878,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNzA5OTg3OA==","diff_hunk":"@@ -29,9 +28,9 @@ public String solicitacoesRelatorio() {\n \n String listaSolicitacoesRelatorio = solicitacoes\n .stream()\n- .filter(solicitacao -> solicitacao.getStatus().equalsIgnoreCase(\"Hospede\") ||\n- solicitacao.getStatus().equalsIgnoreCase(\"Ex hospede\") ||\n- solicitacao.getStatus().equals(\"Negado\")\n+ .filter(solicitacao -> solicitacao.getStatus().equalsIgnoreCase(Solicitacao.Status.HOSPEDE) ||","path":"app/src/main/java/com/thoughtworks/aceleradora/solicitacao/dominio/SolicitacaoCsvService.java","position":15,"original_position":15,"commit_id":"6c9b5bc0a92cc744df2cbcada1b58ebf5ef3cfb6","original_commit_id":"6c9b5bc0a92cc744df2cbcada1b58ebf5ef3cfb6","user":{"login":"othman853","id":4705127,"node_id":"MDQ6VXNlcjQ3MDUxMjc=","avatar_url":"https://avatars3.githubusercontent.com/u/4705127?v=4","gravatar_id":"","url":"https://api.github.com/users/othman853","html_url":"https://github.com/othman853","followers_url":"https://api.github.com/users/othman853/followers","following_url":"https://api.github.com/users/othman853/following{/other_user}","gists_url":"https://api.github.com/users/othman853/gists{/gist_id}","starred_url":"https://api.github.com/users/othman853/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/othman853/subscriptions","organizations_url":"https://api.github.com/users/othman853/orgs","repos_url":"https://api.github.com/users/othman853/repos","events_url":"https://api.github.com/users/othman853/events{/privacy}","received_events_url":"https://api.github.com/users/othman853/received_events","type":"User","site_admin":false},"body":"Esse método não deveria existir nesse enum, essa lógica não está fazendo sentido, já que o método sempre retorna `false`, esse filtro sempre vai funcionar do mesmo jeito incorreto.\r\n\r\nDeveríamos usar `==`:\r\n\r\n```java\r\n .filter(solicitacao -> solicitacao.getStatus() == Solicitacao.Status.HOSPEDE \r\n || solicitacao.getStatus() == Solicitacao.Status.EX_HOSPEDE // ...\r\n)\r\n// ...\r\n```","created_at":"2018-11-28T14:15:31Z","updated_at":"2018-11-28T14:15:36Z","html_url":"https://github.com/aceleradora-TW/hospebem/pull/113#discussion_r237099878","pull_request_url":"https://api.github.com/repos/aceleradora-TW/hospebem/pulls/113","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/aceleradora-TW/hospebem/pulls/comments/237099878"},"html":{"href":"https://github.com/aceleradora-TW/hospebem/pull/113#discussion_r237099878"},"pull_request":{"href":"https://api.github.com/repos/aceleradora-TW/hospebem/pulls/113"}}},"pull_request":{"url":"https://api.github.com/repos/aceleradora-TW/hospebem/pulls/113","id":234263652,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM0MjYzNjUy","html_url":"https://github.com/aceleradora-TW/hospebem/pull/113","diff_url":"https://github.com/aceleradora-TW/hospebem/pull/113.diff","patch_url":"https://github.com/aceleradora-TW/hospebem/pull/113.patch","issue_url":"https://api.github.com/repos/aceleradora-TW/hospebem/issues/113","number":113,"state":"open","locked":false,"title":"Refatora enum","user":{"login":"DiovaneMendes","id":21377189,"node_id":"MDQ6VXNlcjIxMzc3MTg5","avatar_url":"https://avatars0.githubusercontent.com/u/21377189?v=4","gravatar_id":"","url":"https://api.github.com/users/DiovaneMendes","html_url":"https://github.com/DiovaneMendes","followers_url":"https://api.github.com/users/DiovaneMendes/followers","following_url":"https://api.github.com/users/DiovaneMendes/following{/other_user}","gists_url":"https://api.github.com/users/DiovaneMendes/gists{/gist_id}","starred_url":"https://api.github.com/users/DiovaneMendes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DiovaneMendes/subscriptions","organizations_url":"https://api.github.com/users/DiovaneMendes/orgs","repos_url":"https://api.github.com/users/DiovaneMendes/repos","events_url":"https://api.github.com/users/DiovaneMendes/events{/privacy}","received_events_url":"https://api.github.com/users/DiovaneMendes/received_events","type":"User","site_admin":false},"body":"Refatoramos para não precisar mais usar toString e os status não serem mais String e sim enum","created_at":"2018-11-28T12:46:27Z","updated_at":"2018-11-28T14:15:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5de3d9484a06c0354fc5fa5b253123110a1a2801","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/aceleradora-TW/hospebem/pulls/113/commits","review_comments_url":"https://api.github.com/repos/aceleradora-TW/hospebem/pulls/113/comments","review_comment_url":"https://api.github.com/repos/aceleradora-TW/hospebem/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aceleradora-TW/hospebem/issues/113/comments","statuses_url":"https://api.github.com/repos/aceleradora-TW/hospebem/statuses/6c9b5bc0a92cc744df2cbcada1b58ebf5ef3cfb6","head":{"label":"aceleradora-TW:melhoria/refatora-enum","ref":"melhoria/refatora-enum","sha":"6c9b5bc0a92cc744df2cbcada1b58ebf5ef3cfb6","user":{"login":"aceleradora-TW","id":18720656,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NzIwNjU2","avatar_url":"https://avatars0.githubusercontent.com/u/18720656?v=4","gravatar_id":"","url":"https://api.github.com/users/aceleradora-TW","html_url":"https://github.com/aceleradora-TW","followers_url":"https://api.github.com/users/aceleradora-TW/followers","following_url":"https://api.github.com/users/aceleradora-TW/following{/other_user}","gists_url":"https://api.github.com/users/aceleradora-TW/gists{/gist_id}","starred_url":"https://api.github.com/users/aceleradora-TW/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aceleradora-TW/subscriptions","organizations_url":"https://api.github.com/users/aceleradora-TW/orgs","repos_url":"https://api.github.com/users/aceleradora-TW/repos","events_url":"https://api.github.com/users/aceleradora-TW/events{/privacy}","received_events_url":"https://api.github.com/users/aceleradora-TW/received_events","type":"Organization","site_admin":false},"repo":{"id":151568054,"node_id":"MDEwOlJlcG9zaXRvcnkxNTE1NjgwNTQ=","name":"hospebem","full_name":"aceleradora-TW/hospebem","private":false,"owner":{"login":"aceleradora-TW","id":18720656,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NzIwNjU2","avatar_url":"https://avatars0.githubusercontent.com/u/18720656?v=4","gravatar_id":"","url":"https://api.github.com/users/aceleradora-TW","html_url":"https://github.com/aceleradora-TW","followers_url":"https://api.github.com/users/aceleradora-TW/followers","following_url":"https://api.github.com/users/aceleradora-TW/following{/other_user}","gists_url":"https://api.github.com/users/aceleradora-TW/gists{/gist_id}","starred_url":"https://api.github.com/users/aceleradora-TW/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aceleradora-TW/subscriptions","organizations_url":"https://api.github.com/users/aceleradora-TW/orgs","repos_url":"https://api.github.com/users/aceleradora-TW/repos","events_url":"https://api.github.com/users/aceleradora-TW/events{/privacy}","received_events_url":"https://api.github.com/users/aceleradora-TW/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/aceleradora-TW/hospebem","description":null,"fork":false,"url":"https://api.github.com/repos/aceleradora-TW/hospebem","forks_url":"https://api.github.com/repos/aceleradora-TW/hospebem/forks","keys_url":"https://api.github.com/repos/aceleradora-TW/hospebem/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aceleradora-TW/hospebem/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aceleradora-TW/hospebem/teams","hooks_url":"https://api.github.com/repos/aceleradora-TW/hospebem/hooks","issue_events_url":"https://api.github.com/repos/aceleradora-TW/hospebem/issues/events{/number}","events_url":"https://api.github.com/repos/aceleradora-TW/hospebem/events","assignees_url":"https://api.github.com/repos/aceleradora-TW/hospebem/assignees{/user}","branches_url":"https://api.github.com/repos/aceleradora-TW/hospebem/branches{/branch}","tags_url":"https://api.github.com/repos/aceleradora-TW/hospebem/tags","blobs_url":"https://api.github.com/repos/aceleradora-TW/hospebem/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aceleradora-TW/hospebem/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aceleradora-TW/hospebem/git/refs{/sha}","trees_url":"https://api.github.com/repos/aceleradora-TW/hospebem/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aceleradora-TW/hospebem/statuses/{sha}","languages_url":"https://api.github.com/repos/aceleradora-TW/hospebem/languages","stargazers_url":"https://api.github.com/repos/aceleradora-TW/hospebem/stargazers","contributors_url":"https://api.github.com/repos/aceleradora-TW/hospebem/contributors","subscribers_url":"https://api.github.com/repos/aceleradora-TW/hospebem/subscribers","subscription_url":"https://api.github.com/repos/aceleradora-TW/hospebem/subscription","commits_url":"https://api.github.com/repos/aceleradora-TW/hospebem/commits{/sha}","git_commits_url":"https://api.github.com/repos/aceleradora-TW/hospebem/git/commits{/sha}","comments_url":"https://api.github.com/repos/aceleradora-TW/hospebem/comments{/number}","issue_comment_url":"https://api.github.com/repos/aceleradora-TW/hospebem/issues/comments{/number}","contents_url":"https://api.github.com/repos/aceleradora-TW/hospebem/contents/{+path}","compare_url":"https://api.github.com/repos/aceleradora-TW/hospebem/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aceleradora-TW/hospebem/merges","archive_url":"https://api.github.com/repos/aceleradora-TW/hospebem/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aceleradora-TW/hospebem/downloads","issues_url":"https://api.github.com/repos/aceleradora-TW/hospebem/issues{/number}","pulls_url":"https://api.github.com/repos/aceleradora-TW/hospebem/pulls{/number}","milestones_url":"https://api.github.com/repos/aceleradora-TW/hospebem/milestones{/number}","notifications_url":"https://api.github.com/repos/aceleradora-TW/hospebem/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aceleradora-TW/hospebem/labels{/name}","releases_url":"https://api.github.com/repos/aceleradora-TW/hospebem/releases{/id}","deployments_url":"https://api.github.com/repos/aceleradora-TW/hospebem/deployments","created_at":"2018-10-04T12:28:26Z","updated_at":"2018-11-28T13:24:25Z","pushed_at":"2018-11-28T14:14:18Z","git_url":"git://github.com/aceleradora-TW/hospebem.git","ssh_url":"[email protected]:aceleradora-TW/hospebem.git","clone_url":"https://github.com/aceleradora-TW/hospebem.git","svn_url":"https://github.com/aceleradora-TW/hospebem","homepage":null,"size":643,"stargazers_count":5,"watchers_count":5,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":35,"license":null,"forks":0,"open_issues":35,"watchers":5,"default_branch":"master"}},"base":{"label":"aceleradora-TW:master","ref":"master","sha":"5f9918eeab578b9c0dfaa25de81dfd6728eedc06","user":{"login":"aceleradora-TW","id":18720656,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NzIwNjU2","avatar_url":"https://avatars0.githubusercontent.com/u/18720656?v=4","gravatar_id":"","url":"https://api.github.com/users/aceleradora-TW","html_url":"https://github.com/aceleradora-TW","followers_url":"https://api.github.com/users/aceleradora-TW/followers","following_url":"https://api.github.com/users/aceleradora-TW/following{/other_user}","gists_url":"https://api.github.com/users/aceleradora-TW/gists{/gist_id}","starred_url":"https://api.github.com/users/aceleradora-TW/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aceleradora-TW/subscriptions","organizations_url":"https://api.github.com/users/aceleradora-TW/orgs","repos_url":"https://api.github.com/users/aceleradora-TW/repos","events_url":"https://api.github.com/users/aceleradora-TW/events{/privacy}","received_events_url":"https://api.github.com/users/aceleradora-TW/received_events","type":"Organization","site_admin":false},"repo":{"id":151568054,"node_id":"MDEwOlJlcG9zaXRvcnkxNTE1NjgwNTQ=","name":"hospebem","full_name":"aceleradora-TW/hospebem","private":false,"owner":{"login":"aceleradora-TW","id":18720656,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NzIwNjU2","avatar_url":"https://avatars0.githubusercontent.com/u/18720656?v=4","gravatar_id":"","url":"https://api.github.com/users/aceleradora-TW","html_url":"https://github.com/aceleradora-TW","followers_url":"https://api.github.com/users/aceleradora-TW/followers","following_url":"https://api.github.com/users/aceleradora-TW/following{/other_user}","gists_url":"https://api.github.com/users/aceleradora-TW/gists{/gist_id}","starred_url":"https://api.github.com/users/aceleradora-TW/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aceleradora-TW/subscriptions","organizations_url":"https://api.github.com/users/aceleradora-TW/orgs","repos_url":"https://api.github.com/users/aceleradora-TW/repos","events_url":"https://api.github.com/users/aceleradora-TW/events{/privacy}","received_events_url":"https://api.github.com/users/aceleradora-TW/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/aceleradora-TW/hospebem","description":null,"fork":false,"url":"https://api.github.com/repos/aceleradora-TW/hospebem","forks_url":"https://api.github.com/repos/aceleradora-TW/hospebem/forks","keys_url":"https://api.github.com/repos/aceleradora-TW/hospebem/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aceleradora-TW/hospebem/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aceleradora-TW/hospebem/teams","hooks_url":"https://api.github.com/repos/aceleradora-TW/hospebem/hooks","issue_events_url":"https://api.github.com/repos/aceleradora-TW/hospebem/issues/events{/number}","events_url":"https://api.github.com/repos/aceleradora-TW/hospebem/events","assignees_url":"https://api.github.com/repos/aceleradora-TW/hospebem/assignees{/user}","branches_url":"https://api.github.com/repos/aceleradora-TW/hospebem/branches{/branch}","tags_url":"https://api.github.com/repos/aceleradora-TW/hospebem/tags","blobs_url":"https://api.github.com/repos/aceleradora-TW/hospebem/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aceleradora-TW/hospebem/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aceleradora-TW/hospebem/git/refs{/sha}","trees_url":"https://api.github.com/repos/aceleradora-TW/hospebem/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aceleradora-TW/hospebem/statuses/{sha}","languages_url":"https://api.github.com/repos/aceleradora-TW/hospebem/languages","stargazers_url":"https://api.github.com/repos/aceleradora-TW/hospebem/stargazers","contributors_url":"https://api.github.com/repos/aceleradora-TW/hospebem/contributors","subscribers_url":"https://api.github.com/repos/aceleradora-TW/hospebem/subscribers","subscription_url":"https://api.github.com/repos/aceleradora-TW/hospebem/subscription","commits_url":"https://api.github.com/repos/aceleradora-TW/hospebem/commits{/sha}","git_commits_url":"https://api.github.com/repos/aceleradora-TW/hospebem/git/commits{/sha}","comments_url":"https://api.github.com/repos/aceleradora-TW/hospebem/comments{/number}","issue_comment_url":"https://api.github.com/repos/aceleradora-TW/hospebem/issues/comments{/number}","contents_url":"https://api.github.com/repos/aceleradora-TW/hospebem/contents/{+path}","compare_url":"https://api.github.com/repos/aceleradora-TW/hospebem/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aceleradora-TW/hospebem/merges","archive_url":"https://api.github.com/repos/aceleradora-TW/hospebem/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aceleradora-TW/hospebem/downloads","issues_url":"https://api.github.com/repos/aceleradora-TW/hospebem/issues{/number}","pulls_url":"https://api.github.com/repos/aceleradora-TW/hospebem/pulls{/number}","milestones_url":"https://api.github.com/repos/aceleradora-TW/hospebem/milestones{/number}","notifications_url":"https://api.github.com/repos/aceleradora-TW/hospebem/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aceleradora-TW/hospebem/labels{/name}","releases_url":"https://api.github.com/repos/aceleradora-TW/hospebem/releases{/id}","deployments_url":"https://api.github.com/repos/aceleradora-TW/hospebem/deployments","created_at":"2018-10-04T12:28:26Z","updated_at":"2018-11-28T13:24:25Z","pushed_at":"2018-11-28T14:14:18Z","git_url":"git://github.com/aceleradora-TW/hospebem.git","ssh_url":"[email protected]:aceleradora-TW/hospebem.git","clone_url":"https://github.com/aceleradora-TW/hospebem.git","svn_url":"https://github.com/aceleradora-TW/hospebem","homepage":null,"size":643,"stargazers_count":5,"watchers_count":5,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":35,"license":null,"forks":0,"open_issues":35,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/aceleradora-TW/hospebem/pulls/113"},"html":{"href":"https://github.com/aceleradora-TW/hospebem/pull/113"},"issue":{"href":"https://api.github.com/repos/aceleradora-TW/hospebem/issues/113"},"comments":{"href":"https://api.github.com/repos/aceleradora-TW/hospebem/issues/113/comments"},"review_comments":{"href":"https://api.github.com/repos/aceleradora-TW/hospebem/pulls/113/comments"},"review_comment":{"href":"https://api.github.com/repos/aceleradora-TW/hospebem/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aceleradora-TW/hospebem/pulls/113/commits"},"statuses":{"href":"https://api.github.com/repos/aceleradora-TW/hospebem/statuses/6c9b5bc0a92cc744df2cbcada1b58ebf5ef3cfb6"}},"author_association":"CONTRIBUTOR"}} | {
"id": 151568054,
"name": "aceleradora-TW/hospebem",
"url": "https://api.github.com/repos/aceleradora-TW/hospebem"
} | {
"id": 4705127,
"login": "othman853",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4705127?",
"url": "https://api.github.com/users/othman853"
} | {
"id": 18720656,
"login": "aceleradora-TW",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/18720656?",
"url": "https://api.github.com/orgs/aceleradora-TW"
} | 2018-11-28T14:15:31 | 8662094009 | {"actor":{"display_login":"othman853"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/mrgsolve/mrgsolvetk/pulls/comments/182937252","pull_request_review_id":113833457,"id":182937252,"diff_hunk":"@@ -131,7 +144,151 @@ out\n \n distinct(out,ID,CL,VC)\n \n+```\n+## Maximum Likelihood Parameter Optimization\n+\n+### `mrgoptim`\n+This example shows a simultaneous fit of PK and PD data from five dose levels.\n+\n+#### Data structure\n+The data to be fit is an mrgsolve dataset. Required columns for fitting are:\n+\n+- ID\t\n+- time\t\n+- evid\n+- cmt\n+- amt\n+- dv\t\n+\n+\n+```{r}\n+data <- read.csv(\"inst/maintenance/data/optim-example.csv\")\n+\n+head(data)\n+```\n+\n+Plot the data to get an idea of the profiles to be fit. cmt 1 is plasma concentration\n+data and cmt 2 is PD data\n+\n+```{r warning=FALSE}\n+ggplot(data,aes(x=time,y=dv,color=as.factor(ID)))+\n+ geom_point()+\n+ geom_line()+\n+ facet_wrap(\"cmt\")+\n+ guides(color=F)\n+```\n+\n+The following model will be fit to these data:\n+\n+- PK: 2 compartment model\n+- PD: Emax model with baseline\n+- Proportional error models for both PK and PD\n+\n+```{r}\n+code<-\"\n+$PROB 2 cmt PK Model, Emax PD model\n+\n+$PARAM\n+CL=10\n+VC = 20\n+VP = 20\n+Q=20\n+Emax = 60\n+BL = 50\n+EC50 = 10\n+gamma =1\n+sigma1 = 0.1\n+sigma2 = 0.1\n+\n+$CMT X1 X2 \n+\n+$ODE\n+dxdt_X1 = -(Q+CL)/VC*X1+Q/VP*X2;\n+dxdt_X2 = Q/VC*X1-Q/VP*X2;\n+\n+$TABLE","path":"README.Rmd","position":95,"original_position":95,"commit_id":"f8a5a787f006bcb60d2a46ef8009a45fb5ecc346","original_commit_id":"f8a5a787f006bcb60d2a46ef8009a45fb5ecc346","user":{"login":"kylebmetrum","id":16908301,"avatar_url":"https://avatars2.githubusercontent.com/u/16908301?v=4","gravatar_id":"","url":"https://api.github.com/users/kylebmetrum","html_url":"https://github.com/kylebmetrum","followers_url":"https://api.github.com/users/kylebmetrum/followers","following_url":"https://api.github.com/users/kylebmetrum/following{/other_user}","gists_url":"https://api.github.com/users/kylebmetrum/gists{/gist_id}","starred_url":"https://api.github.com/users/kylebmetrum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kylebmetrum/subscriptions","organizations_url":"https://api.github.com/users/kylebmetrum/orgs","repos_url":"https://api.github.com/users/kylebmetrum/repos","events_url":"https://api.github.com/users/kylebmetrum/events{/privacy}","received_events_url":"https://api.github.com/users/kylebmetrum/received_events","type":"User","site_admin":false},"body":"Rather than using a \"wide\" setup here, can we require something like this? Not sure how this would play out with all the subsequent code; but it seems like you could avoid that `reformat` function all together by asking the model to return single column with the predicted values. \r\n\r\n```r\r\n$TABLE\r\ncapture IPRED = X1/VC;\r\ncapture var = (PK*sigma1)*(PK*sigma1);\r\n\r\nif(CMT ==2) {\r\n IPRED = BL-(pow(PK,gamma)*Emax)/(pow(PK,gamma)+pow(EC50,gamma));\r\n var = (PD*sigma2)*(PD*sigma2);\r\n}\r\n```\r\n\r\nThen, I'd guess you could have some sensible default names for the `output` and `var` arguments. ","created_at":"2018-04-20T03:19:02Z","updated_at":"2018-04-20T03:48:11Z","html_url":"https://github.com/mrgsolve/mrgsolvetk/pull/1#discussion_r182937252","pull_request_url":"https://api.github.com/repos/mrgsolve/mrgsolvetk/pulls/1","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/mrgsolve/mrgsolvetk/pulls/comments/182937252"},"html":{"href":"https://github.com/mrgsolve/mrgsolvetk/pull/1#discussion_r182937252"},"pull_request":{"href":"https://api.github.com/repos/mrgsolve/mrgsolvetk/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/mrgsolve/mrgsolvetk/pulls/1","id":181604176,"html_url":"https://github.com/mrgsolve/mrgsolvetk/pull/1","diff_url":"https://github.com/mrgsolve/mrgsolvetk/pull/1.diff","patch_url":"https://github.com/mrgsolve/mrgsolvetk/pull/1.patch","issue_url":"https://api.github.com/repos/mrgsolve/mrgsolvetk/issues/1","number":1,"state":"open","locked":false,"title":"Maximum Likelihood parameter optimization","user":{"login":"mhismail","id":27981719,"avatar_url":"https://avatars2.githubusercontent.com/u/27981719?v=4","gravatar_id":"","url":"https://api.github.com/users/mhismail","html_url":"https://github.com/mhismail","followers_url":"https://api.github.com/users/mhismail/followers","following_url":"https://api.github.com/users/mhismail/following{/other_user}","gists_url":"https://api.github.com/users/mhismail/gists{/gist_id}","starred_url":"https://api.github.com/users/mhismail/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhismail/subscriptions","organizations_url":"https://api.github.com/users/mhismail/orgs","repos_url":"https://api.github.com/users/mhismail/repos","events_url":"https://api.github.com/users/mhismail/events{/privacy}","received_events_url":"https://api.github.com/users/mhismail/received_events","type":"User","site_admin":false},"body":"Pull request for adding functions to automate parameter optimization workflow.\r\n\r\n- Added mrgoptim function. Takes model object and parameters to be optimized as arguments, and returns final parameter estimates and precision. \r\n- Included example in README\r\n\r\nI imagine there may need to be some tweaks to workflow/output, wanted to get some feedback early on. ","created_at":"2018-04-13T21:52:49Z","updated_at":"2018-04-20T03:48:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"65618fab304daf139a0ca61280de87c546ae4ecd","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mrgsolve/mrgsolvetk/pulls/1/commits","review_comments_url":"https://api.github.com/repos/mrgsolve/mrgsolvetk/pulls/1/comments","review_comment_url":"https://api.github.com/repos/mrgsolve/mrgsolvetk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mrgsolve/mrgsolvetk/issues/1/comments","statuses_url":"https://api.github.com/repos/mrgsolve/mrgsolvetk/statuses/f8a5a787f006bcb60d2a46ef8009a45fb5ecc346","head":{"label":"mhismail:mrgoptim","ref":"mrgoptim","sha":"f8a5a787f006bcb60d2a46ef8009a45fb5ecc346","user":{"login":"mhismail","id":27981719,"avatar_url":"https://avatars2.githubusercontent.com/u/27981719?v=4","gravatar_id":"","url":"https://api.github.com/users/mhismail","html_url":"https://github.com/mhismail","followers_url":"https://api.github.com/users/mhismail/followers","following_url":"https://api.github.com/users/mhismail/following{/other_user}","gists_url":"https://api.github.com/users/mhismail/gists{/gist_id}","starred_url":"https://api.github.com/users/mhismail/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhismail/subscriptions","organizations_url":"https://api.github.com/users/mhismail/orgs","repos_url":"https://api.github.com/users/mhismail/repos","events_url":"https://api.github.com/users/mhismail/events{/privacy}","received_events_url":"https://api.github.com/users/mhismail/received_events","type":"User","site_admin":false},"repo":{"id":129432186,"name":"mrgsolvetk","full_name":"mhismail/mrgsolvetk","owner":{"login":"mhismail","id":27981719,"avatar_url":"https://avatars2.githubusercontent.com/u/27981719?v=4","gravatar_id":"","url":"https://api.github.com/users/mhismail","html_url":"https://github.com/mhismail","followers_url":"https://api.github.com/users/mhismail/followers","following_url":"https://api.github.com/users/mhismail/following{/other_user}","gists_url":"https://api.github.com/users/mhismail/gists{/gist_id}","starred_url":"https://api.github.com/users/mhismail/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhismail/subscriptions","organizations_url":"https://api.github.com/users/mhismail/orgs","repos_url":"https://api.github.com/users/mhismail/repos","events_url":"https://api.github.com/users/mhismail/events{/privacy}","received_events_url":"https://api.github.com/users/mhismail/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mhismail/mrgsolvetk","description":"Tool Kit / Workflows for mrgsolve focused on QSP type modeling","fork":true,"url":"https://api.github.com/repos/mhismail/mrgsolvetk","forks_url":"https://api.github.com/repos/mhismail/mrgsolvetk/forks","keys_url":"https://api.github.com/repos/mhismail/mrgsolvetk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mhismail/mrgsolvetk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mhismail/mrgsolvetk/teams","hooks_url":"https://api.github.com/repos/mhismail/mrgsolvetk/hooks","issue_events_url":"https://api.github.com/repos/mhismail/mrgsolvetk/issues/events{/number}","events_url":"https://api.github.com/repos/mhismail/mrgsolvetk/events","assignees_url":"https://api.github.com/repos/mhismail/mrgsolvetk/assignees{/user}","branches_url":"https://api.github.com/repos/mhismail/mrgsolvetk/branches{/branch}","tags_url":"https://api.github.com/repos/mhismail/mrgsolvetk/tags","blobs_url":"https://api.github.com/repos/mhismail/mrgsolvetk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mhismail/mrgsolvetk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mhismail/mrgsolvetk/git/refs{/sha}","trees_url":"https://api.github.com/repos/mhismail/mrgsolvetk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mhismail/mrgsolvetk/statuses/{sha}","languages_url":"https://api.github.com/repos/mhismail/mrgsolvetk/languages","stargazers_url":"https://api.github.com/repos/mhismail/mrgsolvetk/stargazers","contributors_url":"https://api.github.com/repos/mhismail/mrgsolvetk/contributors","subscribers_url":"https://api.github.com/repos/mhismail/mrgsolvetk/subscribers","subscription_url":"https://api.github.com/repos/mhismail/mrgsolvetk/subscription","commits_url":"https://api.github.com/repos/mhismail/mrgsolvetk/commits{/sha}","git_commits_url":"https://api.github.com/repos/mhismail/mrgsolvetk/git/commits{/sha}","comments_url":"https://api.github.com/repos/mhismail/mrgsolvetk/comments{/number}","issue_comment_url":"https://api.github.com/repos/mhismail/mrgsolvetk/issues/comments{/number}","contents_url":"https://api.github.com/repos/mhismail/mrgsolvetk/contents/{+path}","compare_url":"https://api.github.com/repos/mhismail/mrgsolvetk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mhismail/mrgsolvetk/merges","archive_url":"https://api.github.com/repos/mhismail/mrgsolvetk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mhismail/mrgsolvetk/downloads","issues_url":"https://api.github.com/repos/mhismail/mrgsolvetk/issues{/number}","pulls_url":"https://api.github.com/repos/mhismail/mrgsolvetk/pulls{/number}","milestones_url":"https://api.github.com/repos/mhismail/mrgsolvetk/milestones{/number}","notifications_url":"https://api.github.com/repos/mhismail/mrgsolvetk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mhismail/mrgsolvetk/labels{/name}","releases_url":"https://api.github.com/repos/mhismail/mrgsolvetk/releases{/id}","deployments_url":"https://api.github.com/repos/mhismail/mrgsolvetk/deployments","created_at":"2018-04-13T17:12:13Z","updated_at":"2018-04-13T17:12:15Z","pushed_at":"2018-04-14T01:35:27Z","git_url":"git://github.com/mhismail/mrgsolvetk.git","ssh_url":"[email protected]:mhismail/mrgsolvetk.git","clone_url":"https://github.com/mhismail/mrgsolvetk.git","svn_url":"https://github.com/mhismail/mrgsolvetk","homepage":"","size":2453,"stargazers_count":0,"watchers_count":0,"language":"R","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mrgsolve:master","ref":"master","sha":"a4fac13b4b331a41427f7ce8405162e43d3db5a9","user":{"login":"mrgsolve","id":19160377,"avatar_url":"https://avatars3.githubusercontent.com/u/19160377?v=4","gravatar_id":"","url":"https://api.github.com/users/mrgsolve","html_url":"https://github.com/mrgsolve","followers_url":"https://api.github.com/users/mrgsolve/followers","following_url":"https://api.github.com/users/mrgsolve/following{/other_user}","gists_url":"https://api.github.com/users/mrgsolve/gists{/gist_id}","starred_url":"https://api.github.com/users/mrgsolve/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrgsolve/subscriptions","organizations_url":"https://api.github.com/users/mrgsolve/orgs","repos_url":"https://api.github.com/users/mrgsolve/repos","events_url":"https://api.github.com/users/mrgsolve/events{/privacy}","received_events_url":"https://api.github.com/users/mrgsolve/received_events","type":"Organization","site_admin":false},"repo":{"id":92877977,"name":"mrgsolvetk","full_name":"mrgsolve/mrgsolvetk","owner":{"login":"mrgsolve","id":19160377,"avatar_url":"https://avatars3.githubusercontent.com/u/19160377?v=4","gravatar_id":"","url":"https://api.github.com/users/mrgsolve","html_url":"https://github.com/mrgsolve","followers_url":"https://api.github.com/users/mrgsolve/followers","following_url":"https://api.github.com/users/mrgsolve/following{/other_user}","gists_url":"https://api.github.com/users/mrgsolve/gists{/gist_id}","starred_url":"https://api.github.com/users/mrgsolve/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrgsolve/subscriptions","organizations_url":"https://api.github.com/users/mrgsolve/orgs","repos_url":"https://api.github.com/users/mrgsolve/repos","events_url":"https://api.github.com/users/mrgsolve/events{/privacy}","received_events_url":"https://api.github.com/users/mrgsolve/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mrgsolve/mrgsolvetk","description":"Tool Kit / Workflows for mrgsolve focused on QSP type modeling","fork":false,"url":"https://api.github.com/repos/mrgsolve/mrgsolvetk","forks_url":"https://api.github.com/repos/mrgsolve/mrgsolvetk/forks","keys_url":"https://api.github.com/repos/mrgsolve/mrgsolvetk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mrgsolve/mrgsolvetk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mrgsolve/mrgsolvetk/teams","hooks_url":"https://api.github.com/repos/mrgsolve/mrgsolvetk/hooks","issue_events_url":"https://api.github.com/repos/mrgsolve/mrgsolvetk/issues/events{/number}","events_url":"https://api.github.com/repos/mrgsolve/mrgsolvetk/events","assignees_url":"https://api.github.com/repos/mrgsolve/mrgsolvetk/assignees{/user}","branches_url":"https://api.github.com/repos/mrgsolve/mrgsolvetk/branches{/branch}","tags_url":"https://api.github.com/repos/mrgsolve/mrgsolvetk/tags","blobs_url":"https://api.github.com/repos/mrgsolve/mrgsolvetk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mrgsolve/mrgsolvetk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mrgsolve/mrgsolvetk/git/refs{/sha}","trees_url":"https://api.github.com/repos/mrgsolve/mrgsolvetk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mrgsolve/mrgsolvetk/statuses/{sha}","languages_url":"https://api.github.com/repos/mrgsolve/mrgsolvetk/languages","stargazers_url":"https://api.github.com/repos/mrgsolve/mrgsolvetk/stargazers","contributors_url":"https://api.github.com/repos/mrgsolve/mrgsolvetk/contributors","subscribers_url":"https://api.github.com/repos/mrgsolve/mrgsolvetk/subscribers","subscription_url":"https://api.github.com/repos/mrgsolve/mrgsolvetk/subscription","commits_url":"https://api.github.com/repos/mrgsolve/mrgsolvetk/commits{/sha}","git_commits_url":"https://api.github.com/repos/mrgsolve/mrgsolvetk/git/commits{/sha}","comments_url":"https://api.github.com/repos/mrgsolve/mrgsolvetk/comments{/number}","issue_comment_url":"https://api.github.com/repos/mrgsolve/mrgsolvetk/issues/comments{/number}","contents_url":"https://api.github.com/repos/mrgsolve/mrgsolvetk/contents/{+path}","compare_url":"https://api.github.com/repos/mrgsolve/mrgsolvetk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mrgsolve/mrgsolvetk/merges","archive_url":"https://api.github.com/repos/mrgsolve/mrgsolvetk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mrgsolve/mrgsolvetk/downloads","issues_url":"https://api.github.com/repos/mrgsolve/mrgsolvetk/issues{/number}","pulls_url":"https://api.github.com/repos/mrgsolve/mrgsolvetk/pulls{/number}","milestones_url":"https://api.github.com/repos/mrgsolve/mrgsolvetk/milestones{/number}","notifications_url":"https://api.github.com/repos/mrgsolve/mrgsolvetk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mrgsolve/mrgsolvetk/labels{/name}","releases_url":"https://api.github.com/repos/mrgsolve/mrgsolvetk/releases{/id}","deployments_url":"https://api.github.com/repos/mrgsolve/mrgsolvetk/deployments","created_at":"2017-05-30T21:31:22Z","updated_at":"2018-03-19T13:34:29Z","pushed_at":"2018-04-14T01:35:28Z","git_url":"git://github.com/mrgsolve/mrgsolvetk.git","ssh_url":"[email protected]:mrgsolve/mrgsolvetk.git","clone_url":"https://github.com/mrgsolve/mrgsolvetk.git","svn_url":"https://github.com/mrgsolve/mrgsolvetk","homepage":"","size":2142,"stargazers_count":1,"watchers_count":1,"language":"R","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":2,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mrgsolve/mrgsolvetk/pulls/1"},"html":{"href":"https://github.com/mrgsolve/mrgsolvetk/pull/1"},"issue":{"href":"https://api.github.com/repos/mrgsolve/mrgsolvetk/issues/1"},"comments":{"href":"https://api.github.com/repos/mrgsolve/mrgsolvetk/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/mrgsolve/mrgsolvetk/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/mrgsolve/mrgsolvetk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mrgsolve/mrgsolvetk/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/mrgsolve/mrgsolvetk/statuses/f8a5a787f006bcb60d2a46ef8009a45fb5ecc346"}},"author_association":"NONE"}} | {
"id": 92877977,
"name": "mrgsolve/mrgsolvetk",
"url": "https://api.github.com/repos/mrgsolve/mrgsolvetk"
} | {
"id": 16908301,
"login": "kylebmetrum",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/16908301?",
"url": "https://api.github.com/users/kylebmetrum"
} | {
"id": 19160377,
"login": "mrgsolve",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/19160377?",
"url": "https://api.github.com/orgs/mrgsolve"
} | 2018-04-20T03:19:02 | 7559411806 | {"actor":{"display_login":"kylebmetrum"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/ethpm/ethpm-spec/pulls/comments/186863285","pull_request_review_id":118528442,"id":186863285,"diff_hunk":"@@ -0,0 +1,278 @@\n+{\n+ \"title\": \"Package Specification\",\n+ \"type\": \"object\",\n+ \"required\": [\n+ \"manifest_version\",\n+ \"package_name\",\n+ \"version\"\n+ ],\n+ \"version\": \"2\",\n+ \"properties\": {\n+ \"manifest_version\": {\n+ \"type\": \"string\",\n+ \"title\": \"EthPM Manifest Version\",\n+ \"default\": \"2\",\n+ \"enum\": [\"2\"]\n+ },\n+ \"package_name\": {\n+ \"title\": \"The name of the package that this release is for\",\n+ \"type\": \"string\",\n+ \"pattern\": \"^[a-z][-a-z0-9]{0,213}$\"\n+ },\n+ \"meta\": {\n+ \"$ref\": \"#/definitions/PackageMeta\"\n+ },\n+ \"version\": {\n+ \"title\": \"Version\",\n+ \"type\": \"string\"\n+ },\n+ \"sources\": {\n+ \"title\": \"Sources\",\n+ \"type\": \"object\",\n+ \"patternProperties\": {\n+ \"\\\\.\\\\/.*\": {\n+ \"anyOf\": [\n+ {\n+ \"title\": \"Source code\",\n+ \"type\": \"string\"\n+ },\n+ {\n+ \"$ref\": \"IPFS-URI\"\n+ }\n+ ]\n+ }\n+ }\n+ },\n+ \"contract_types\": {\n+ \"title\": \"The contract types included in this release\",\n+ \"type\": \"object\",\n+ \"patternProperties\": {\n+ \"[a-zA-Z][-a-zA-Z0-9_]*(?:\\\\[[-a-zA-Z0-9]{1,256}\\\\])$\": {\n+ \"$ref\": \"#/definitions/ContractType\"\n+ }\n+ }\n+ },\n+ \"deployments\": {\n+ \"title\": \"The deployed contract instances in this release\",\n+ \"type\": \"object\",\n+ \"patternProperties\": {\n+ \"^blockchain\\\\://[0-9a-zA-Z]{64}/block/[0-9a-zA-Z]{64}$\": {\n+ \"type\": \"object\",\n+ \"patternProperties\": {\n+ \"^[a-zA-Z][a-zA-Z0-9_]*$\": {\n+ \"$ref\": \"#/definitions/ContractInstance\"\n+ }\n+ }\n+ }\n+ }\n+ },\n+ \"build_dependencies\": {\n+ \"title\": \"Build Dependencies\",\n+ \"type\": \"object\",\n+ \"patternProperties\": {\n+ \"^[a-z][-a-z0-9]{0,213}$\": {\n+ \"$ref\": \"#/definitions/IPFS-URI\"\n+ }\n+ }\n+ }\n+ },\n+ \"definitions\": {\n+ \"PackageMeta\": {\n+ \"title\": \"Metadata about the package\",\n+ \"type\": \"object\",\n+ \"properties\": {\n+ \"authors\": {\n+ \"title\": \"Package authors\",\n+ \"type\": \"array\",\n+ \"items\": {\n+ \"type\": \"string\"\n+ }\n+ },\n+ \"license\": {\n+ \"title\": \"The license that this package and it's source are released under\",\n+ \"type\": \"string\"\n+ },\n+ \"description\": {\n+ \"title\": \"Description of this package\",\n+ \"type\": \"string\"\n+ },\n+ \"keywords\": {\n+ \"title\": \"Keywords that apply to this package\",\n+ \"type\": \"array\",\n+ \"items\": {\n+ \"type\": \"string\"\n+ }\n+ },\n+ \"links\": {\n+ \"title\": \"URIs for resources related to this package\",\n+ \"type\": \"object\",\n+ \"additionalProperties\": {\n+ \"type\": \"string\",\n+ \"format\": \"URI\"\n+ }\n+ }\n+ }\n+ },\n+ \"ContractType\": {\n+ \"title\": \"Data for a contract type included in this package\",\n+ \"type\": \"object\",\n+ \"properties\":{\n+ \"contract_name\": {\n+ \"title\": \"The name for this contract type as found in the project source code.\",\n+ \"type\": \"string\",\n+ \"pattern\": \"[a-zA-Z][a-zA-Z0-9_]*\"\n+ },\n+ \"bytecode\": {\n+ \"title\": \"The unlinked '0x' prefixed bytecode for this contract type\",\n+ \"type\": \"string\"\n+ },\n+ \"runtime_bytecode\": {\n+ \"title\": \"The unlinked '0x' prefixed runtime portion of the bytecode for this contract type\",\n+ \"type\": \"string\"\n+ },\n+ \"abi\": {\n+ \"title\": \"The ABI for this contract type\",\n+ \"type\": \"array\"\n+ },\n+ \"natspec\": {\n+ \"title\": \"The combined user-doc and dev-doc for this contract\",\n+ \"type\": \"object\"\n+ },\n+ \"compiler\": {\n+ \"$ref\": \"#/definitions/CompilerInformation\"\n+ }\n+ }\n+ },\n+ \"ContractInstance\": {\n+ \"title\": \"Data for a deployed instance of a contract\",\n+ \"type\": \"object\",\n+ \"required\": [\n+ \"contract_type\"\n+ ],\n+ \"properties\": {\n+ \"contract_type\": {\n+ \"title\": \"The contract type of this contract instance\",\n+ \"type\": \"string\",\n+ \"pattern\": \"^(?:[a-z][-a-z0-9]{0,213}\\\\:)?[a-zA-Z][-a-zA-Z0-9_]*(?:\\\\[[-a-zA-Z0-9]{1,256}\\\\])?$\"\n+ },\n+ \"address\": {\n+ \"$ref\": \"#/definitions/Address\"\n+ },\n+ \"transaction\": {\n+ \"$ref\": \"#/definitions/TransactionHash\"\n+ },\n+ \"block\": {\n+ \"$ref\": \"#/definitions/BlockHash\"\n+ },\n+ \"runtime_bytecode\": {\n+ \"title\": \"The on-chain bytecode for this contract instance.\",\n+ \"type\": \"string\"\n+ },\n+ \"compiler\": {\n+ \"$ref\": \"#/definitions/CompilerInformation\"\n+ },\n+ \"link_dependencies\": {\n+ \"title\": \"The values for the link references found within this contract instances runtime bytecode\",\n+ \"type\": \"array\",\n+ \"items\": {\n+ \"$ref\": \"#/definitions/LinkValue\"\n+ }\n+ }\n+ }\n+ },\n+ \"LinkValue\": {\n+ \"title\": \"A value for an individual link reference in a contract's bytecode\",\n+ \"type\": \"object\",\n+ \"required\": [\n+ \"offset\",\n+ \"value\"\n+ ],\n+ \"properties\": {\n+ \"offset\": {\n+ \"type\": \"integer\",\n+ \"minimum\": 0\n+ },\n+ \"value\": {\n+ \"title\": \"The value for the link reference\",\n+ \"type\": \"string\",\n+ \"anyOf\": [\n+ {\"$ref\": \"#/definitions/Address\"},\n+ {\"$ref\": \"#/definitions/ContractInstanceName\"},\n+ {\"$ref\": \"#/definitions/PackageContractInstanceName\"}\n+ ]\n+ }\n+ }\n+ },\n+ \"ContractInstanceName\": {\n+ \"title\": \"The name of the deployed contract instance\",\n+ \"type\": \"string\",\n+ \"pattern\": \"^[a-zA-Z][a-zA-Z0-9_]*$\"\n+ },\n+ \"PackageContractInstanceName\": {\n+ \"title\": \"The path to a deployed contract instance somewhere down the dependency tree\",\n+ \"type\": \"string\",\n+ \"pattern\": \"^([a-z][-a-z0-9]{0,213}\\\\:)+[a-zA-Z][a-zA-Z0-9_]*$\"\n+ },\n+ \"CompilerInformation\": {\n+ \"title\": \"Information about the software that was used to compile a contract type or instance\",\n+ \"type\": \"object\",\n+ \"required\": [\n+ \"type\",\n+ \"version\"\n+ ],\n+ \"properties\": {\n+ \"type\": {\n+ \"title\": \"The name of the compiler\",\n+ \"enum\": [\n+ \"solc\",\n+ \"solcjs\"\n+ ]\n+ },\n+ \"version\": {\n+ \"title\": \"The version string for the compiler\",\n+ \"type\": \"string\"\n+ },\n+ \"settings\": {\n+ \"title\": \"The settings used for compilation\",\n+ \"anyOf\": [\n+ {\"$ref\": \"solc_Settings\"}\n+ ]\n+ }\n+ }\n+ },\n+ \"solc_Settings\": {\n+ \"title\": \"Settings for use with the solc or solcjs compiler\",\n+ \"type\": \"object\",\n+ \"properties\": {\n+ \"optimize\": {\n+ \"type\": \"boolean\"\n+ },\n+ \"optimize_runs\": {\n+ \"type\": \"integer\",\n+ \"minimum\": 1\n+ }\n+ }\n+ },\n+ \"Address\": {\n+ \"title\": \"An Ethereum address\",\n+ \"type\": \"string\",\n+ \"pattern\": \"^0x[0-9a-fA-F]{40}$\"\n+ },\n+ \"TransactionHash\": {\n+ \"title\": \"An Ethereum transaction hash\",\n+ \"type\": \"string\",\n+ \"pattern\": \"^0x[0-9a-zA-Z]{64}$\"\n+ },\n+ \"BlockHash\": {\n+ \"title\": \"An Ethereum block hash\",\n+ \"type\": \"string\",\n+ \"pattern\": \"^0x[0-9a-zA-Z]{64}$\"\n+ },\n+ \"IPFS-URI\": {\n+ \"title\": \"An IPFS URI\",\n+ \"type\": \"string\",\n+ \"format\": \"uri\",\n+ \"pattern\": \"^ipfs:/?/?.*$\"\n+ }\n+ }\n+}","path":"spec/package.spec.json","position":278,"original_position":278,"commit_id":"2b6a162df59c598006be24921fdb3ae5b8aa39f1","original_commit_id":"2b6a162df59c598006be24921fdb3ae5b8aa39f1","user":{"login":"njgheorghita","id":9753150,"avatar_url":"https://avatars0.githubusercontent.com/u/9753150?v=4","gravatar_id":"","url":"https://api.github.com/users/njgheorghita","html_url":"https://github.com/njgheorghita","followers_url":"https://api.github.com/users/njgheorghita/followers","following_url":"https://api.github.com/users/njgheorghita/following{/other_user}","gists_url":"https://api.github.com/users/njgheorghita/gists{/gist_id}","starred_url":"https://api.github.com/users/njgheorghita/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/njgheorghita/subscriptions","organizations_url":"https://api.github.com/users/njgheorghita/orgs","repos_url":"https://api.github.com/users/njgheorghita/repos","events_url":"https://api.github.com/users/njgheorghita/events{/privacy}","received_events_url":"https://api.github.com/users/njgheorghita/received_events","type":"User","site_admin":false},"body":"Yeah probably, I'll get rid of it now. I can't think of any reason we'd want to keep it around","created_at":"2018-05-08T20:50:46Z","updated_at":"2018-05-08T20:50:47Z","html_url":"https://github.com/ethpm/ethpm-spec/pull/86#discussion_r186863285","pull_request_url":"https://api.github.com/repos/ethpm/ethpm-spec/pulls/86","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/ethpm/ethpm-spec/pulls/comments/186863285"},"html":{"href":"https://github.com/ethpm/ethpm-spec/pull/86#discussion_r186863285"},"pull_request":{"href":"https://api.github.com/repos/ethpm/ethpm-spec/pulls/86"}},"in_reply_to_id":186862115},"pull_request":{"url":"https://api.github.com/repos/ethpm/ethpm-spec/pulls/86","id":185608609,"html_url":"https://github.com/ethpm/ethpm-spec/pull/86","diff_url":"https://github.com/ethpm/ethpm-spec/pull/86.diff","patch_url":"https://github.com/ethpm/ethpm-spec/pull/86.patch","issue_url":"https://api.github.com/repos/ethpm/ethpm-spec/issues/86","number":86,"state":"open","locked":false,"title":"Rename lockfile to package","user":{"login":"njgheorghita","id":9753150,"avatar_url":"https://avatars0.githubusercontent.com/u/9753150?v=4","gravatar_id":"","url":"https://api.github.com/users/njgheorghita","html_url":"https://github.com/njgheorghita","followers_url":"https://api.github.com/users/njgheorghita/followers","following_url":"https://api.github.com/users/njgheorghita/following{/other_user}","gists_url":"https://api.github.com/users/njgheorghita/gists{/gist_id}","starred_url":"https://api.github.com/users/njgheorghita/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/njgheorghita/subscriptions","organizations_url":"https://api.github.com/users/njgheorghita/orgs","repos_url":"https://api.github.com/users/njgheorghita/repos","events_url":"https://api.github.com/users/njgheorghita/events{/privacy}","received_events_url":"https://api.github.com/users/njgheorghita/received_events","type":"User","site_admin":false},"body":"Use of \"Lockfile\" can be confusing and misleading as Package Managers will be expected to implement their own lockfiles based on what packages they have installed.\r\n\r\nThis pr renames occurrences of \"Lockfile\" to \"Package\". \r\nAlso updates \"lockfile_version\" in schema to \"manifest_version\"\r\n\r\ncloses #73 ","created_at":"2018-05-03T03:13:16Z","updated_at":"2018-05-08T20:50:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f28655403cf0ce62e82bba234bb8c72c3be3e7a7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":455090514,"url":"https://api.github.com/repos/ethpm/ethpm-spec/labels/Open%20for%20Discussion","name":"Open for Discussion","color":"006b75","default":false},{"id":516894724,"url":"https://api.github.com/repos/ethpm/ethpm-spec/labels/Version%202","name":"Version 2","color":"d4c5f9","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ethpm/ethpm-spec/pulls/86/commits","review_comments_url":"https://api.github.com/repos/ethpm/ethpm-spec/pulls/86/comments","review_comment_url":"https://api.github.com/repos/ethpm/ethpm-spec/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ethpm/ethpm-spec/issues/86/comments","statuses_url":"https://api.github.com/repos/ethpm/ethpm-spec/statuses/2b6a162df59c598006be24921fdb3ae5b8aa39f1","head":{"label":"njgheorghita:rename-lockfile-to-package","ref":"rename-lockfile-to-package","sha":"2b6a162df59c598006be24921fdb3ae5b8aa39f1","user":{"login":"njgheorghita","id":9753150,"avatar_url":"https://avatars0.githubusercontent.com/u/9753150?v=4","gravatar_id":"","url":"https://api.github.com/users/njgheorghita","html_url":"https://github.com/njgheorghita","followers_url":"https://api.github.com/users/njgheorghita/followers","following_url":"https://api.github.com/users/njgheorghita/following{/other_user}","gists_url":"https://api.github.com/users/njgheorghita/gists{/gist_id}","starred_url":"https://api.github.com/users/njgheorghita/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/njgheorghita/subscriptions","organizations_url":"https://api.github.com/users/njgheorghita/orgs","repos_url":"https://api.github.com/users/njgheorghita/repos","events_url":"https://api.github.com/users/njgheorghita/events{/privacy}","received_events_url":"https://api.github.com/users/njgheorghita/received_events","type":"User","site_admin":false},"repo":{"id":131926487,"name":"ethpm-spec","full_name":"njgheorghita/ethpm-spec","owner":{"login":"njgheorghita","id":9753150,"avatar_url":"https://avatars0.githubusercontent.com/u/9753150?v=4","gravatar_id":"","url":"https://api.github.com/users/njgheorghita","html_url":"https://github.com/njgheorghita","followers_url":"https://api.github.com/users/njgheorghita/followers","following_url":"https://api.github.com/users/njgheorghita/following{/other_user}","gists_url":"https://api.github.com/users/njgheorghita/gists{/gist_id}","starred_url":"https://api.github.com/users/njgheorghita/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/njgheorghita/subscriptions","organizations_url":"https://api.github.com/users/njgheorghita/orgs","repos_url":"https://api.github.com/users/njgheorghita/repos","events_url":"https://api.github.com/users/njgheorghita/events{/privacy}","received_events_url":"https://api.github.com/users/njgheorghita/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/njgheorghita/ethpm-spec","description":"Ethereum Package Manager","fork":true,"url":"https://api.github.com/repos/njgheorghita/ethpm-spec","forks_url":"https://api.github.com/repos/njgheorghita/ethpm-spec/forks","keys_url":"https://api.github.com/repos/njgheorghita/ethpm-spec/keys{/key_id}","collaborators_url":"https://api.github.com/repos/njgheorghita/ethpm-spec/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/njgheorghita/ethpm-spec/teams","hooks_url":"https://api.github.com/repos/njgheorghita/ethpm-spec/hooks","issue_events_url":"https://api.github.com/repos/njgheorghita/ethpm-spec/issues/events{/number}","events_url":"https://api.github.com/repos/njgheorghita/ethpm-spec/events","assignees_url":"https://api.github.com/repos/njgheorghita/ethpm-spec/assignees{/user}","branches_url":"https://api.github.com/repos/njgheorghita/ethpm-spec/branches{/branch}","tags_url":"https://api.github.com/repos/njgheorghita/ethpm-spec/tags","blobs_url":"https://api.github.com/repos/njgheorghita/ethpm-spec/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/njgheorghita/ethpm-spec/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/njgheorghita/ethpm-spec/git/refs{/sha}","trees_url":"https://api.github.com/repos/njgheorghita/ethpm-spec/git/trees{/sha}","statuses_url":"https://api.github.com/repos/njgheorghita/ethpm-spec/statuses/{sha}","languages_url":"https://api.github.com/repos/njgheorghita/ethpm-spec/languages","stargazers_url":"https://api.github.com/repos/njgheorghita/ethpm-spec/stargazers","contributors_url":"https://api.github.com/repos/njgheorghita/ethpm-spec/contributors","subscribers_url":"https://api.github.com/repos/njgheorghita/ethpm-spec/subscribers","subscription_url":"https://api.github.com/repos/njgheorghita/ethpm-spec/subscription","commits_url":"https://api.github.com/repos/njgheorghita/ethpm-spec/commits{/sha}","git_commits_url":"https://api.github.com/repos/njgheorghita/ethpm-spec/git/commits{/sha}","comments_url":"https://api.github.com/repos/njgheorghita/ethpm-spec/comments{/number}","issue_comment_url":"https://api.github.com/repos/njgheorghita/ethpm-spec/issues/comments{/number}","contents_url":"https://api.github.com/repos/njgheorghita/ethpm-spec/contents/{+path}","compare_url":"https://api.github.com/repos/njgheorghita/ethpm-spec/compare/{base}...{head}","merges_url":"https://api.github.com/repos/njgheorghita/ethpm-spec/merges","archive_url":"https://api.github.com/repos/njgheorghita/ethpm-spec/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/njgheorghita/ethpm-spec/downloads","issues_url":"https://api.github.com/repos/njgheorghita/ethpm-spec/issues{/number}","pulls_url":"https://api.github.com/repos/njgheorghita/ethpm-spec/pulls{/number}","milestones_url":"https://api.github.com/repos/njgheorghita/ethpm-spec/milestones{/number}","notifications_url":"https://api.github.com/repos/njgheorghita/ethpm-spec/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/njgheorghita/ethpm-spec/labels{/name}","releases_url":"https://api.github.com/repos/njgheorghita/ethpm-spec/releases{/id}","deployments_url":"https://api.github.com/repos/njgheorghita/ethpm-spec/deployments","created_at":"2018-05-03T01:44:32Z","updated_at":"2018-05-03T01:44:34Z","pushed_at":"2018-05-08T20:47:38Z","git_url":"git://github.com/njgheorghita/ethpm-spec.git","ssh_url":"[email protected]:njgheorghita/ethpm-spec.git","clone_url":"https://github.com/njgheorghita/ethpm-spec.git","svn_url":"https://github.com/njgheorghita/ethpm-spec","homepage":null,"size":182,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ethpm:master","ref":"master","sha":"1f3f10786f544cf17d690d5d4cf680d6fd812e51","user":{"login":"ethpm","id":19231566,"avatar_url":"https://avatars2.githubusercontent.com/u/19231566?v=4","gravatar_id":"","url":"https://api.github.com/users/ethpm","html_url":"https://github.com/ethpm","followers_url":"https://api.github.com/users/ethpm/followers","following_url":"https://api.github.com/users/ethpm/following{/other_user}","gists_url":"https://api.github.com/users/ethpm/gists{/gist_id}","starred_url":"https://api.github.com/users/ethpm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethpm/subscriptions","organizations_url":"https://api.github.com/users/ethpm/orgs","repos_url":"https://api.github.com/users/ethpm/repos","events_url":"https://api.github.com/users/ethpm/events{/privacy}","received_events_url":"https://api.github.com/users/ethpm/received_events","type":"Organization","site_admin":false},"repo":{"id":58237418,"name":"ethpm-spec","full_name":"ethpm/ethpm-spec","owner":{"login":"ethpm","id":19231566,"avatar_url":"https://avatars2.githubusercontent.com/u/19231566?v=4","gravatar_id":"","url":"https://api.github.com/users/ethpm","html_url":"https://github.com/ethpm","followers_url":"https://api.github.com/users/ethpm/followers","following_url":"https://api.github.com/users/ethpm/following{/other_user}","gists_url":"https://api.github.com/users/ethpm/gists{/gist_id}","starred_url":"https://api.github.com/users/ethpm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethpm/subscriptions","organizations_url":"https://api.github.com/users/ethpm/orgs","repos_url":"https://api.github.com/users/ethpm/repos","events_url":"https://api.github.com/users/ethpm/events{/privacy}","received_events_url":"https://api.github.com/users/ethpm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ethpm/ethpm-spec","description":"Ethereum Package Manager","fork":false,"url":"https://api.github.com/repos/ethpm/ethpm-spec","forks_url":"https://api.github.com/repos/ethpm/ethpm-spec/forks","keys_url":"https://api.github.com/repos/ethpm/ethpm-spec/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ethpm/ethpm-spec/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ethpm/ethpm-spec/teams","hooks_url":"https://api.github.com/repos/ethpm/ethpm-spec/hooks","issue_events_url":"https://api.github.com/repos/ethpm/ethpm-spec/issues/events{/number}","events_url":"https://api.github.com/repos/ethpm/ethpm-spec/events","assignees_url":"https://api.github.com/repos/ethpm/ethpm-spec/assignees{/user}","branches_url":"https://api.github.com/repos/ethpm/ethpm-spec/branches{/branch}","tags_url":"https://api.github.com/repos/ethpm/ethpm-spec/tags","blobs_url":"https://api.github.com/repos/ethpm/ethpm-spec/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ethpm/ethpm-spec/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ethpm/ethpm-spec/git/refs{/sha}","trees_url":"https://api.github.com/repos/ethpm/ethpm-spec/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ethpm/ethpm-spec/statuses/{sha}","languages_url":"https://api.github.com/repos/ethpm/ethpm-spec/languages","stargazers_url":"https://api.github.com/repos/ethpm/ethpm-spec/stargazers","contributors_url":"https://api.github.com/repos/ethpm/ethpm-spec/contributors","subscribers_url":"https://api.github.com/repos/ethpm/ethpm-spec/subscribers","subscription_url":"https://api.github.com/repos/ethpm/ethpm-spec/subscription","commits_url":"https://api.github.com/repos/ethpm/ethpm-spec/commits{/sha}","git_commits_url":"https://api.github.com/repos/ethpm/ethpm-spec/git/commits{/sha}","comments_url":"https://api.github.com/repos/ethpm/ethpm-spec/comments{/number}","issue_comment_url":"https://api.github.com/repos/ethpm/ethpm-spec/issues/comments{/number}","contents_url":"https://api.github.com/repos/ethpm/ethpm-spec/contents/{+path}","compare_url":"https://api.github.com/repos/ethpm/ethpm-spec/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ethpm/ethpm-spec/merges","archive_url":"https://api.github.com/repos/ethpm/ethpm-spec/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ethpm/ethpm-spec/downloads","issues_url":"https://api.github.com/repos/ethpm/ethpm-spec/issues{/number}","pulls_url":"https://api.github.com/repos/ethpm/ethpm-spec/pulls{/number}","milestones_url":"https://api.github.com/repos/ethpm/ethpm-spec/milestones{/number}","notifications_url":"https://api.github.com/repos/ethpm/ethpm-spec/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ethpm/ethpm-spec/labels{/name}","releases_url":"https://api.github.com/repos/ethpm/ethpm-spec/releases{/id}","deployments_url":"https://api.github.com/repos/ethpm/ethpm-spec/deployments","created_at":"2016-05-06T22:07:50Z","updated_at":"2018-05-08T12:48:16Z","pushed_at":"2018-05-08T20:47:32Z","git_url":"git://github.com/ethpm/ethpm-spec.git","ssh_url":"[email protected]:ethpm/ethpm-spec.git","clone_url":"https://github.com/ethpm/ethpm-spec.git","svn_url":"https://github.com/ethpm/ethpm-spec","homepage":null,"size":172,"stargazers_count":108,"watchers_count":108,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"archived":false,"open_issues_count":15,"license":null,"forks":18,"open_issues":15,"watchers":108,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ethpm/ethpm-spec/pulls/86"},"html":{"href":"https://github.com/ethpm/ethpm-spec/pull/86"},"issue":{"href":"https://api.github.com/repos/ethpm/ethpm-spec/issues/86"},"comments":{"href":"https://api.github.com/repos/ethpm/ethpm-spec/issues/86/comments"},"review_comments":{"href":"https://api.github.com/repos/ethpm/ethpm-spec/pulls/86/comments"},"review_comment":{"href":"https://api.github.com/repos/ethpm/ethpm-spec/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ethpm/ethpm-spec/pulls/86/commits"},"statuses":{"href":"https://api.github.com/repos/ethpm/ethpm-spec/statuses/2b6a162df59c598006be24921fdb3ae5b8aa39f1"}},"author_association":"NONE"}} | {
"id": 58237418,
"name": "ethpm/ethpm-spec",
"url": "https://api.github.com/repos/ethpm/ethpm-spec"
} | {
"id": 9753150,
"login": "njgheorghita",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9753150?",
"url": "https://api.github.com/users/njgheorghita"
} | {
"id": 19231566,
"login": "ethpm",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/19231566?",
"url": "https://api.github.com/orgs/ethpm"
} | 2018-05-08T20:50:46 | 7646091839 | {"actor":{"display_login":"njgheorghita"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/qri-io/qri/pulls/comments/235508285","pull_request_review_id":177390568,"id":235508285,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNTUwODI4NQ==","diff_hunk":"@@ -57,31 +57,38 @@ func (n *QriNode) ConnectedQriPeerIDs() []peer.ID {\n \treturn peers\n }\n \n-// ClosestConnectedPeers checks if a peer is connected, and if so adds it to the top\n+// ClosestConnectedQriPeers checks if a peer is connected, and if so adds it to the top\n // of a slice cap(max) of peers to try to connect to\n // TODO - In the future we'll use a few tricks to improve on just iterating the list\n // at a bare minimum we should grab a randomized set of peers\n-func (n *QriNode) ClosestConnectedPeers(id profile.ID, max int) (pid []peer.ID) {\n+func (n *QriNode) ClosestConnectedQriPeers(profileID profile.ID, max int) (pid []peer.ID) {\n \tadded := 0\n \tif !n.Online {\n \t\treturn []peer.ID{}\n \t}\n \n-\tif ids, err := n.Repo.Profiles().PeerIDs(id); err == nil {\n-\t\tfor _, id := range ids {\n-\t\t\tif len(n.host.Network().ConnsToPeer(id)) > 0 {\n+\tif peerIDs, err := n.Repo.Profiles().PeerIDs(profileID); err == nil {\n+\t\tfor _, peerID := range peerIDs {\n+\t\t\tif len(n.host.Network().ConnsToPeer(peerID)) > 0 {\n \t\t\t\tadded++\n-\t\t\t\tpid = append(pid, id)\n+\t\t\t\tpid = append(pid, peerID)\n \t\t\t}\n \t\t}\n \t}\n \n \tif len(pid) == 0 {\n \t\tfor _, conn := range n.host.Network().Conns() {\n-\t\t\tpid = append(pid, conn.RemotePeer())\n-\t\t\tadded++\n-\t\t\tif added == max {\n-\t\t\t\tbreak\n+\t\t\tpeerID := conn.RemotePeer()\n+\t\t\tprotocols, err := n.host.Peerstore().SupportsProtocols(peerID, string(QriProtocolID))\n+\t\t\tif err != nil {\n+\t\t\t\tcontinue\n+\t\t\t}\n+\t\t\tif len(protocols) != 0 {\n+\t\t\t\tpid = append(pid, peerID)\n+\t\t\t\tadded++\n+\t\t\t\tif added == max {","path":"p2p/peers.go","position":43,"original_position":43,"commit_id":"868bd5d2bfb98ee35220389152fb4edb2254c354","original_commit_id":"06260ad5e482666855114f63b18769893bb6ea51","user":{"login":"dustmop","id":2515490,"node_id":"MDQ6VXNlcjI1MTU0OTA=","avatar_url":"https://avatars2.githubusercontent.com/u/2515490?v=4","gravatar_id":"","url":"https://api.github.com/users/dustmop","html_url":"https://github.com/dustmop","followers_url":"https://api.github.com/users/dustmop/followers","following_url":"https://api.github.com/users/dustmop/following{/other_user}","gists_url":"https://api.github.com/users/dustmop/gists{/gist_id}","starred_url":"https://api.github.com/users/dustmop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dustmop/subscriptions","organizations_url":"https://api.github.com/users/dustmop/orgs","repos_url":"https://api.github.com/users/dustmop/repos","events_url":"https://api.github.com/users/dustmop/events{/privacy}","received_events_url":"https://api.github.com/users/dustmop/received_events","type":"User","site_admin":false},"body":"Please change this to `added >= max`. It's functionally the same thing, but it makes it a little clearer what's going on. Plus, if the code changes in the future (like, another condition ends up doing `added++`), this condition will handle the case of going above the max length.","created_at":"2018-11-21T19:05:12Z","updated_at":"2018-11-21T19:11:35Z","html_url":"https://github.com/qri-io/qri/pull/620#discussion_r235508285","pull_request_url":"https://api.github.com/repos/qri-io/qri/pulls/620","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/qri-io/qri/pulls/comments/235508285"},"html":{"href":"https://github.com/qri-io/qri/pull/620#discussion_r235508285"},"pull_request":{"href":"https://api.github.com/repos/qri-io/qri/pulls/620"}}},"pull_request":{"url":"https://api.github.com/repos/qri-io/qri/pulls/620","id":232487958,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMyNDg3OTU4","html_url":"https://github.com/qri-io/qri/pull/620","diff_url":"https://github.com/qri-io/qri/pull/620.diff","patch_url":"https://github.com/qri-io/qri/pull/620.patch","issue_url":"https://api.github.com/repos/qri-io/qri/issues/620","number":620,"state":"open","locked":false,"title":"feat(registry): create api endpoint to request list of available datasets from the registry","user":{"login":"ramfox","id":17440142,"node_id":"MDQ6VXNlcjE3NDQwMTQy","avatar_url":"https://avatars0.githubusercontent.com/u/17440142?v=4","gravatar_id":"","url":"https://api.github.com/users/ramfox","html_url":"https://github.com/ramfox","followers_url":"https://api.github.com/users/ramfox/followers","following_url":"https://api.github.com/users/ramfox/following{/other_user}","gists_url":"https://api.github.com/users/ramfox/gists{/gist_id}","starred_url":"https://api.github.com/users/ramfox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ramfox/subscriptions","organizations_url":"https://api.github.com/users/ramfox/orgs","repos_url":"https://api.github.com/users/ramfox/repos","events_url":"https://api.github.com/users/ramfox/events{/privacy}","received_events_url":"https://api.github.com/users/ramfox/received_events","type":"User","site_admin":false},"body":"closes #616 \r\nAlso changes `ClosestConnectedPeer` to `ClosestConnectedQriPeer`, which gives a list of Qri Peers, rather than arbitrary peers we happen to be connected to.","created_at":"2018-11-20T23:06:35Z","updated_at":"2018-11-21T19:11:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2715382b882ef825cb11e5f5721ad1708474aac8","assignee":{"login":"ramfox","id":17440142,"node_id":"MDQ6VXNlcjE3NDQwMTQy","avatar_url":"https://avatars0.githubusercontent.com/u/17440142?v=4","gravatar_id":"","url":"https://api.github.com/users/ramfox","html_url":"https://github.com/ramfox","followers_url":"https://api.github.com/users/ramfox/followers","following_url":"https://api.github.com/users/ramfox/following{/other_user}","gists_url":"https://api.github.com/users/ramfox/gists{/gist_id}","starred_url":"https://api.github.com/users/ramfox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ramfox/subscriptions","organizations_url":"https://api.github.com/users/ramfox/orgs","repos_url":"https://api.github.com/users/ramfox/repos","events_url":"https://api.github.com/users/ramfox/events{/privacy}","received_events_url":"https://api.github.com/users/ramfox/received_events","type":"User","site_admin":false},"assignees":[{"login":"ramfox","id":17440142,"node_id":"MDQ6VXNlcjE3NDQwMTQy","avatar_url":"https://avatars0.githubusercontent.com/u/17440142?v=4","gravatar_id":"","url":"https://api.github.com/users/ramfox","html_url":"https://github.com/ramfox","followers_url":"https://api.github.com/users/ramfox/followers","following_url":"https://api.github.com/users/ramfox/following{/other_user}","gists_url":"https://api.github.com/users/ramfox/gists{/gist_id}","starred_url":"https://api.github.com/users/ramfox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ramfox/subscriptions","organizations_url":"https://api.github.com/users/ramfox/orgs","repos_url":"https://api.github.com/users/ramfox/repos","events_url":"https://api.github.com/users/ramfox/events{/privacy}","received_events_url":"https://api.github.com/users/ramfox/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"b5","id":1154390,"node_id":"MDQ6VXNlcjExNTQzOTA=","avatar_url":"https://avatars1.githubusercontent.com/u/1154390?v=4","gravatar_id":"","url":"https://api.github.com/users/b5","html_url":"https://github.com/b5","followers_url":"https://api.github.com/users/b5/followers","following_url":"https://api.github.com/users/b5/following{/other_user}","gists_url":"https://api.github.com/users/b5/gists{/gist_id}","starred_url":"https://api.github.com/users/b5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/b5/subscriptions","organizations_url":"https://api.github.com/users/b5/orgs","repos_url":"https://api.github.com/users/b5/repos","events_url":"https://api.github.com/users/b5/events{/privacy}","received_events_url":"https://api.github.com/users/b5/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":673327179,"node_id":"MDU6TGFiZWw2NzMzMjcxNzk=","url":"https://api.github.com/repos/qri-io/qri/labels/in%20progress","name":"in progress","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/qri-io/qri/pulls/620/commits","review_comments_url":"https://api.github.com/repos/qri-io/qri/pulls/620/comments","review_comment_url":"https://api.github.com/repos/qri-io/qri/pulls/comments{/number}","comments_url":"https://api.github.com/repos/qri-io/qri/issues/620/comments","statuses_url":"https://api.github.com/repos/qri-io/qri/statuses/868bd5d2bfb98ee35220389152fb4edb2254c354","head":{"label":"qri-io:closestp2p","ref":"closestp2p","sha":"868bd5d2bfb98ee35220389152fb4edb2254c354","user":{"login":"qri-io","id":19268065,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5MjY4MDY1","avatar_url":"https://avatars1.githubusercontent.com/u/19268065?v=4","gravatar_id":"","url":"https://api.github.com/users/qri-io","html_url":"https://github.com/qri-io","followers_url":"https://api.github.com/users/qri-io/followers","following_url":"https://api.github.com/users/qri-io/following{/other_user}","gists_url":"https://api.github.com/users/qri-io/gists{/gist_id}","starred_url":"https://api.github.com/users/qri-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qri-io/subscriptions","organizations_url":"https://api.github.com/users/qri-io/orgs","repos_url":"https://api.github.com/users/qri-io/repos","events_url":"https://api.github.com/users/qri-io/events{/privacy}","received_events_url":"https://api.github.com/users/qri-io/received_events","type":"Organization","site_admin":false},"repo":{"id":71603023,"node_id":"MDEwOlJlcG9zaXRvcnk3MTYwMzAyMw==","name":"qri","full_name":"qri-io/qri","private":false,"owner":{"login":"qri-io","id":19268065,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5MjY4MDY1","avatar_url":"https://avatars1.githubusercontent.com/u/19268065?v=4","gravatar_id":"","url":"https://api.github.com/users/qri-io","html_url":"https://github.com/qri-io","followers_url":"https://api.github.com/users/qri-io/followers","following_url":"https://api.github.com/users/qri-io/following{/other_user}","gists_url":"https://api.github.com/users/qri-io/gists{/gist_id}","starred_url":"https://api.github.com/users/qri-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qri-io/subscriptions","organizations_url":"https://api.github.com/users/qri-io/orgs","repos_url":"https://api.github.com/users/qri-io/repos","events_url":"https://api.github.com/users/qri-io/events{/privacy}","received_events_url":"https://api.github.com/users/qri-io/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/qri-io/qri","description":"you're invited to a data party!","fork":false,"url":"https://api.github.com/repos/qri-io/qri","forks_url":"https://api.github.com/repos/qri-io/qri/forks","keys_url":"https://api.github.com/repos/qri-io/qri/keys{/key_id}","collaborators_url":"https://api.github.com/repos/qri-io/qri/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/qri-io/qri/teams","hooks_url":"https://api.github.com/repos/qri-io/qri/hooks","issue_events_url":"https://api.github.com/repos/qri-io/qri/issues/events{/number}","events_url":"https://api.github.com/repos/qri-io/qri/events","assignees_url":"https://api.github.com/repos/qri-io/qri/assignees{/user}","branches_url":"https://api.github.com/repos/qri-io/qri/branches{/branch}","tags_url":"https://api.github.com/repos/qri-io/qri/tags","blobs_url":"https://api.github.com/repos/qri-io/qri/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/qri-io/qri/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/qri-io/qri/git/refs{/sha}","trees_url":"https://api.github.com/repos/qri-io/qri/git/trees{/sha}","statuses_url":"https://api.github.com/repos/qri-io/qri/statuses/{sha}","languages_url":"https://api.github.com/repos/qri-io/qri/languages","stargazers_url":"https://api.github.com/repos/qri-io/qri/stargazers","contributors_url":"https://api.github.com/repos/qri-io/qri/contributors","subscribers_url":"https://api.github.com/repos/qri-io/qri/subscribers","subscription_url":"https://api.github.com/repos/qri-io/qri/subscription","commits_url":"https://api.github.com/repos/qri-io/qri/commits{/sha}","git_commits_url":"https://api.github.com/repos/qri-io/qri/git/commits{/sha}","comments_url":"https://api.github.com/repos/qri-io/qri/comments{/number}","issue_comment_url":"https://api.github.com/repos/qri-io/qri/issues/comments{/number}","contents_url":"https://api.github.com/repos/qri-io/qri/contents/{+path}","compare_url":"https://api.github.com/repos/qri-io/qri/compare/{base}...{head}","merges_url":"https://api.github.com/repos/qri-io/qri/merges","archive_url":"https://api.github.com/repos/qri-io/qri/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/qri-io/qri/downloads","issues_url":"https://api.github.com/repos/qri-io/qri/issues{/number}","pulls_url":"https://api.github.com/repos/qri-io/qri/pulls{/number}","milestones_url":"https://api.github.com/repos/qri-io/qri/milestones{/number}","notifications_url":"https://api.github.com/repos/qri-io/qri/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/qri-io/qri/labels{/name}","releases_url":"https://api.github.com/repos/qri-io/qri/releases{/id}","deployments_url":"https://api.github.com/repos/qri-io/qri/deployments","created_at":"2016-10-21T22:58:23Z","updated_at":"2018-11-20T22:59:02Z","pushed_at":"2018-11-20T23:06:35Z","git_url":"git://github.com/qri-io/qri.git","ssh_url":"[email protected]:qri-io/qri.git","clone_url":"https://github.com/qri-io/qri.git","svn_url":"https://github.com/qri-io/qri","homepage":"https://qri.io","size":29804,"stargazers_count":85,"watchers_count":85,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"archived":false,"open_issues_count":37,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":14,"open_issues":37,"watchers":85,"default_branch":"master"}},"base":{"label":"qri-io:master","ref":"master","sha":"3f8368f9c832bb61969a3d1f7669d8aa5e7d91ca","user":{"login":"qri-io","id":19268065,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5MjY4MDY1","avatar_url":"https://avatars1.githubusercontent.com/u/19268065?v=4","gravatar_id":"","url":"https://api.github.com/users/qri-io","html_url":"https://github.com/qri-io","followers_url":"https://api.github.com/users/qri-io/followers","following_url":"https://api.github.com/users/qri-io/following{/other_user}","gists_url":"https://api.github.com/users/qri-io/gists{/gist_id}","starred_url":"https://api.github.com/users/qri-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qri-io/subscriptions","organizations_url":"https://api.github.com/users/qri-io/orgs","repos_url":"https://api.github.com/users/qri-io/repos","events_url":"https://api.github.com/users/qri-io/events{/privacy}","received_events_url":"https://api.github.com/users/qri-io/received_events","type":"Organization","site_admin":false},"repo":{"id":71603023,"node_id":"MDEwOlJlcG9zaXRvcnk3MTYwMzAyMw==","name":"qri","full_name":"qri-io/qri","private":false,"owner":{"login":"qri-io","id":19268065,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5MjY4MDY1","avatar_url":"https://avatars1.githubusercontent.com/u/19268065?v=4","gravatar_id":"","url":"https://api.github.com/users/qri-io","html_url":"https://github.com/qri-io","followers_url":"https://api.github.com/users/qri-io/followers","following_url":"https://api.github.com/users/qri-io/following{/other_user}","gists_url":"https://api.github.com/users/qri-io/gists{/gist_id}","starred_url":"https://api.github.com/users/qri-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qri-io/subscriptions","organizations_url":"https://api.github.com/users/qri-io/orgs","repos_url":"https://api.github.com/users/qri-io/repos","events_url":"https://api.github.com/users/qri-io/events{/privacy}","received_events_url":"https://api.github.com/users/qri-io/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/qri-io/qri","description":"you're invited to a data party!","fork":false,"url":"https://api.github.com/repos/qri-io/qri","forks_url":"https://api.github.com/repos/qri-io/qri/forks","keys_url":"https://api.github.com/repos/qri-io/qri/keys{/key_id}","collaborators_url":"https://api.github.com/repos/qri-io/qri/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/qri-io/qri/teams","hooks_url":"https://api.github.com/repos/qri-io/qri/hooks","issue_events_url":"https://api.github.com/repos/qri-io/qri/issues/events{/number}","events_url":"https://api.github.com/repos/qri-io/qri/events","assignees_url":"https://api.github.com/repos/qri-io/qri/assignees{/user}","branches_url":"https://api.github.com/repos/qri-io/qri/branches{/branch}","tags_url":"https://api.github.com/repos/qri-io/qri/tags","blobs_url":"https://api.github.com/repos/qri-io/qri/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/qri-io/qri/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/qri-io/qri/git/refs{/sha}","trees_url":"https://api.github.com/repos/qri-io/qri/git/trees{/sha}","statuses_url":"https://api.github.com/repos/qri-io/qri/statuses/{sha}","languages_url":"https://api.github.com/repos/qri-io/qri/languages","stargazers_url":"https://api.github.com/repos/qri-io/qri/stargazers","contributors_url":"https://api.github.com/repos/qri-io/qri/contributors","subscribers_url":"https://api.github.com/repos/qri-io/qri/subscribers","subscription_url":"https://api.github.com/repos/qri-io/qri/subscription","commits_url":"https://api.github.com/repos/qri-io/qri/commits{/sha}","git_commits_url":"https://api.github.com/repos/qri-io/qri/git/commits{/sha}","comments_url":"https://api.github.com/repos/qri-io/qri/comments{/number}","issue_comment_url":"https://api.github.com/repos/qri-io/qri/issues/comments{/number}","contents_url":"https://api.github.com/repos/qri-io/qri/contents/{+path}","compare_url":"https://api.github.com/repos/qri-io/qri/compare/{base}...{head}","merges_url":"https://api.github.com/repos/qri-io/qri/merges","archive_url":"https://api.github.com/repos/qri-io/qri/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/qri-io/qri/downloads","issues_url":"https://api.github.com/repos/qri-io/qri/issues{/number}","pulls_url":"https://api.github.com/repos/qri-io/qri/pulls{/number}","milestones_url":"https://api.github.com/repos/qri-io/qri/milestones{/number}","notifications_url":"https://api.github.com/repos/qri-io/qri/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/qri-io/qri/labels{/name}","releases_url":"https://api.github.com/repos/qri-io/qri/releases{/id}","deployments_url":"https://api.github.com/repos/qri-io/qri/deployments","created_at":"2016-10-21T22:58:23Z","updated_at":"2018-11-20T22:59:02Z","pushed_at":"2018-11-20T23:06:35Z","git_url":"git://github.com/qri-io/qri.git","ssh_url":"[email protected]:qri-io/qri.git","clone_url":"https://github.com/qri-io/qri.git","svn_url":"https://github.com/qri-io/qri","homepage":"https://qri.io","size":29804,"stargazers_count":85,"watchers_count":85,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"archived":false,"open_issues_count":37,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":14,"open_issues":37,"watchers":85,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/qri-io/qri/pulls/620"},"html":{"href":"https://github.com/qri-io/qri/pull/620"},"issue":{"href":"https://api.github.com/repos/qri-io/qri/issues/620"},"comments":{"href":"https://api.github.com/repos/qri-io/qri/issues/620/comments"},"review_comments":{"href":"https://api.github.com/repos/qri-io/qri/pulls/620/comments"},"review_comment":{"href":"https://api.github.com/repos/qri-io/qri/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/qri-io/qri/pulls/620/commits"},"statuses":{"href":"https://api.github.com/repos/qri-io/qri/statuses/868bd5d2bfb98ee35220389152fb4edb2254c354"}},"author_association":"MEMBER"}} | {
"id": 71603023,
"name": "qri-io/qri",
"url": "https://api.github.com/repos/qri-io/qri"
} | {
"id": 2515490,
"login": "dustmop",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2515490?",
"url": "https://api.github.com/users/dustmop"
} | {
"id": 19268065,
"login": "qri-io",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/19268065?",
"url": "https://api.github.com/orgs/qri-io"
} | 2018-11-21T19:05:12 | 8629000551 | {"actor":{"display_login":"dustmop"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/PBSPro/pbspro/pulls/comments/168848004","pull_request_review_id":97289265,"id":168848004,"diff_hunk":"@@ -222,7 +226,7 @@ def test_fairshare_formula5(self):\n \"\"\"\n \n self.set_up_resource_group()\n- a = {'log_filter': 2048, 'fair_share': \"True All\"}\n+ a = {'log_filter': 2048, 'fair_share': \"True ALL\"}","path":"test/tests/functional/pbs_fairshare.py","position":20,"original_position":20,"commit_id":"ec3f30e95ee5b246c37b42d30212fa31a3a8e595","original_commit_id":"ec3f30e95ee5b246c37b42d30212fa31a3a8e595","user":{"login":"vstumpf","id":6844975,"avatar_url":"https://avatars1.githubusercontent.com/u/6844975?v=4","gravatar_id":"","url":"https://api.github.com/users/vstumpf","html_url":"https://github.com/vstumpf","followers_url":"https://api.github.com/users/vstumpf/followers","following_url":"https://api.github.com/users/vstumpf/following{/other_user}","gists_url":"https://api.github.com/users/vstumpf/gists{/gist_id}","starred_url":"https://api.github.com/users/vstumpf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vstumpf/subscriptions","organizations_url":"https://api.github.com/users/vstumpf/orgs","repos_url":"https://api.github.com/users/vstumpf/repos","events_url":"https://api.github.com/users/vstumpf/events{/privacy}","received_events_url":"https://api.github.com/users/vstumpf/received_events","type":"User","site_admin":false},"body":"does this not require double quotes like #565?\r\nor was it rejected because it was `All` instead of `ALL`","created_at":"2018-02-16T19:22:56Z","updated_at":"2018-02-16T19:23:02Z","html_url":"https://github.com/PBSPro/pbspro/pull/566#discussion_r168848004","pull_request_url":"https://api.github.com/repos/PBSPro/pbspro/pulls/566","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/PBSPro/pbspro/pulls/comments/168848004"},"html":{"href":"https://github.com/PBSPro/pbspro/pull/566#discussion_r168848004"},"pull_request":{"href":"https://api.github.com/repos/PBSPro/pbspro/pulls/566"}}},"pull_request":{"url":"https://api.github.com/repos/PBSPro/pbspro/pulls/566","id":169496405,"html_url":"https://github.com/PBSPro/pbspro/pull/566","diff_url":"https://github.com/PBSPro/pbspro/pull/566.diff","patch_url":"https://github.com/PBSPro/pbspro/pull/566.patch","issue_url":"https://api.github.com/repos/PBSPro/pbspro/issues/566","number":566,"state":"open","locked":false,"title":"updated tests for pbs_fairshare.py","user":{"login":"anamikau","id":17330444,"avatar_url":"https://avatars3.githubusercontent.com/u/17330444?v=4","gravatar_id":"","url":"https://api.github.com/users/anamikau","html_url":"https://github.com/anamikau","followers_url":"https://api.github.com/users/anamikau/followers","following_url":"https://api.github.com/users/anamikau/following{/other_user}","gists_url":"https://api.github.com/users/anamikau/gists{/gist_id}","starred_url":"https://api.github.com/users/anamikau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anamikau/subscriptions","organizations_url":"https://api.github.com/users/anamikau/orgs","repos_url":"https://api.github.com/users/anamikau/repos","events_url":"https://api.github.com/users/anamikau/events{/privacy}","received_events_url":"https://api.github.com/users/anamikau/received_events","type":"User","site_admin":false},"body":"<!--- Please review your changes in preview mode -->\r\n<!--- Provide a general summary of your changes in the Title above -->\r\n\r\n#### Bug/feature Description\r\n* *Bugs: test_fairshare_formula5 is failing due to sched_config errors on some platforms*\r\n* *Bugs: All tests are failing due to mismatch in jobs political order*\r\n* *If there is an issue ID, link to it: [PP-1084](https://pbspro.atlassian.net/browse/PP-1084)*\r\n\r\n#### Affected Platform(s)\r\n* *Platform : All*\r\n\r\n#### Cause / Analysis / Design\r\n* *Bugs: sched_config value was not set as documented hence on some paltforms tests were failing. Also all tests were failing intermittently as all jobs are getting submitted at same time but for some cases it is observed that scheduler sometime picks job3 over job1 causing the tests to fail.*\r\n\r\n#### Solution Description\r\n* *Added sleep in between job submission to get different timestamp*\r\n\r\n#### Checklist:\r\n<!--- Use the preview button to see the checkboxes/links properly. -->\r\n<!--- Go over the following points, and put an `x` (without spaces around it) in the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [x] I have joined the **[pbspro community forum](http://community.pbspro.org/)**.\r\n- [x] My pull request contains a **single, signed** commit. See **[setting up gpg signature](https://pbspro.atlassian.net/wiki/display/DG/Signing+Your+Git+Commits)**.\r\n- [x] My code follows the **[coding style](https://pbspro.atlassian.net/wiki/display/DG/Coding+Standards)** of this project.\r\n- [ ] My change requires project documentation. See **[required documentation checklist](https://pbspro.atlassian.net/wiki/display/DG/Checklist+for+Developing+Features+and+Bug+Fixes)** for details.\r\n - [ ] I have added documentation in the **[project documentation area](https://pbspro.atlassian.net/wiki/display/PD)**.\r\n- [ ] I have added new **PTL test(s) to my commit**. (See **[using PTL for testing](https://pbspro.atlassian.net/wiki/display/DG/Using+PTL+for+Testing)**) *(or)*\r\n - [ ] I have added **manual test(s) to this pull request and explained why PTL is not appropriate** for this case.\r\n- [ ] All new and existing automated tests have passed. (See **[running automated PTL tests](https://pbspro.atlassian.net/wiki/display/DG/PTL+Quick+Start+Guide)**).\r\n- [ ] I have attached **test logs to this pull request** as evidence of testing/verification.\r\n\r\n\r\n__***For further information please visit the [Developer Guide Home](https://pbspro.atlassian.net/wiki/display/DG/Developer+Guide+Home).***__\r\n","created_at":"2018-02-15T21:58:02Z","updated_at":"2018-02-16T19:23:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3dccce48787fc848f2dc679c357a7234442fe177","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/PBSPro/pbspro/pulls/566/commits","review_comments_url":"https://api.github.com/repos/PBSPro/pbspro/pulls/566/comments","review_comment_url":"https://api.github.com/repos/PBSPro/pbspro/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PBSPro/pbspro/issues/566/comments","statuses_url":"https://api.github.com/repos/PBSPro/pbspro/statuses/ec3f30e95ee5b246c37b42d30212fa31a3a8e595","head":{"label":"anamikau:pbs_fairshare","ref":"pbs_fairshare","sha":"ec3f30e95ee5b246c37b42d30212fa31a3a8e595","user":{"login":"anamikau","id":17330444,"avatar_url":"https://avatars3.githubusercontent.com/u/17330444?v=4","gravatar_id":"","url":"https://api.github.com/users/anamikau","html_url":"https://github.com/anamikau","followers_url":"https://api.github.com/users/anamikau/followers","following_url":"https://api.github.com/users/anamikau/following{/other_user}","gists_url":"https://api.github.com/users/anamikau/gists{/gist_id}","starred_url":"https://api.github.com/users/anamikau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anamikau/subscriptions","organizations_url":"https://api.github.com/users/anamikau/orgs","repos_url":"https://api.github.com/users/anamikau/repos","events_url":"https://api.github.com/users/anamikau/events{/privacy}","received_events_url":"https://api.github.com/users/anamikau/received_events","type":"User","site_admin":false},"repo":{"id":61910033,"name":"pbspro","full_name":"anamikau/pbspro","owner":{"login":"anamikau","id":17330444,"avatar_url":"https://avatars3.githubusercontent.com/u/17330444?v=4","gravatar_id":"","url":"https://api.github.com/users/anamikau","html_url":"https://github.com/anamikau","followers_url":"https://api.github.com/users/anamikau/followers","following_url":"https://api.github.com/users/anamikau/following{/other_user}","gists_url":"https://api.github.com/users/anamikau/gists{/gist_id}","starred_url":"https://api.github.com/users/anamikau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anamikau/subscriptions","organizations_url":"https://api.github.com/users/anamikau/orgs","repos_url":"https://api.github.com/users/anamikau/repos","events_url":"https://api.github.com/users/anamikau/events{/privacy}","received_events_url":"https://api.github.com/users/anamikau/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/anamikau/pbspro","description":"An HPC workload manager and job scheduler for desktops, clusters, and clouds.","fork":true,"url":"https://api.github.com/repos/anamikau/pbspro","forks_url":"https://api.github.com/repos/anamikau/pbspro/forks","keys_url":"https://api.github.com/repos/anamikau/pbspro/keys{/key_id}","collaborators_url":"https://api.github.com/repos/anamikau/pbspro/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/anamikau/pbspro/teams","hooks_url":"https://api.github.com/repos/anamikau/pbspro/hooks","issue_events_url":"https://api.github.com/repos/anamikau/pbspro/issues/events{/number}","events_url":"https://api.github.com/repos/anamikau/pbspro/events","assignees_url":"https://api.github.com/repos/anamikau/pbspro/assignees{/user}","branches_url":"https://api.github.com/repos/anamikau/pbspro/branches{/branch}","tags_url":"https://api.github.com/repos/anamikau/pbspro/tags","blobs_url":"https://api.github.com/repos/anamikau/pbspro/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/anamikau/pbspro/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/anamikau/pbspro/git/refs{/sha}","trees_url":"https://api.github.com/repos/anamikau/pbspro/git/trees{/sha}","statuses_url":"https://api.github.com/repos/anamikau/pbspro/statuses/{sha}","languages_url":"https://api.github.com/repos/anamikau/pbspro/languages","stargazers_url":"https://api.github.com/repos/anamikau/pbspro/stargazers","contributors_url":"https://api.github.com/repos/anamikau/pbspro/contributors","subscribers_url":"https://api.github.com/repos/anamikau/pbspro/subscribers","subscription_url":"https://api.github.com/repos/anamikau/pbspro/subscription","commits_url":"https://api.github.com/repos/anamikau/pbspro/commits{/sha}","git_commits_url":"https://api.github.com/repos/anamikau/pbspro/git/commits{/sha}","comments_url":"https://api.github.com/repos/anamikau/pbspro/comments{/number}","issue_comment_url":"https://api.github.com/repos/anamikau/pbspro/issues/comments{/number}","contents_url":"https://api.github.com/repos/anamikau/pbspro/contents/{+path}","compare_url":"https://api.github.com/repos/anamikau/pbspro/compare/{base}...{head}","merges_url":"https://api.github.com/repos/anamikau/pbspro/merges","archive_url":"https://api.github.com/repos/anamikau/pbspro/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/anamikau/pbspro/downloads","issues_url":"https://api.github.com/repos/anamikau/pbspro/issues{/number}","pulls_url":"https://api.github.com/repos/anamikau/pbspro/pulls{/number}","milestones_url":"https://api.github.com/repos/anamikau/pbspro/milestones{/number}","notifications_url":"https://api.github.com/repos/anamikau/pbspro/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/anamikau/pbspro/labels{/name}","releases_url":"https://api.github.com/repos/anamikau/pbspro/releases{/id}","deployments_url":"https://api.github.com/repos/anamikau/pbspro/deployments","created_at":"2016-06-24T20:14:17Z","updated_at":"2016-06-24T20:14:22Z","pushed_at":"2018-02-16T19:17:25Z","git_url":"git://github.com/anamikau/pbspro.git","ssh_url":"[email protected]:anamikau/pbspro.git","clone_url":"https://github.com/anamikau/pbspro.git","svn_url":"https://github.com/anamikau/pbspro","homepage":"www.pbspro.org","size":10309,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"PBSPro:master","ref":"master","sha":"595956b31ad1beb8c39db575c009f808d445ed19","user":{"login":"PBSPro","id":19280436,"avatar_url":"https://avatars2.githubusercontent.com/u/19280436?v=4","gravatar_id":"","url":"https://api.github.com/users/PBSPro","html_url":"https://github.com/PBSPro","followers_url":"https://api.github.com/users/PBSPro/followers","following_url":"https://api.github.com/users/PBSPro/following{/other_user}","gists_url":"https://api.github.com/users/PBSPro/gists{/gist_id}","starred_url":"https://api.github.com/users/PBSPro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PBSPro/subscriptions","organizations_url":"https://api.github.com/users/PBSPro/orgs","repos_url":"https://api.github.com/users/PBSPro/repos","events_url":"https://api.github.com/users/PBSPro/events{/privacy}","received_events_url":"https://api.github.com/users/PBSPro/received_events","type":"Organization","site_admin":false},"repo":{"id":59082072,"name":"pbspro","full_name":"PBSPro/pbspro","owner":{"login":"PBSPro","id":19280436,"avatar_url":"https://avatars2.githubusercontent.com/u/19280436?v=4","gravatar_id":"","url":"https://api.github.com/users/PBSPro","html_url":"https://github.com/PBSPro","followers_url":"https://api.github.com/users/PBSPro/followers","following_url":"https://api.github.com/users/PBSPro/following{/other_user}","gists_url":"https://api.github.com/users/PBSPro/gists{/gist_id}","starred_url":"https://api.github.com/users/PBSPro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PBSPro/subscriptions","organizations_url":"https://api.github.com/users/PBSPro/orgs","repos_url":"https://api.github.com/users/PBSPro/repos","events_url":"https://api.github.com/users/PBSPro/events{/privacy}","received_events_url":"https://api.github.com/users/PBSPro/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PBSPro/pbspro","description":"An HPC workload manager and job scheduler for desktops, clusters, and clouds.","fork":false,"url":"https://api.github.com/repos/PBSPro/pbspro","forks_url":"https://api.github.com/repos/PBSPro/pbspro/forks","keys_url":"https://api.github.com/repos/PBSPro/pbspro/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PBSPro/pbspro/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PBSPro/pbspro/teams","hooks_url":"https://api.github.com/repos/PBSPro/pbspro/hooks","issue_events_url":"https://api.github.com/repos/PBSPro/pbspro/issues/events{/number}","events_url":"https://api.github.com/repos/PBSPro/pbspro/events","assignees_url":"https://api.github.com/repos/PBSPro/pbspro/assignees{/user}","branches_url":"https://api.github.com/repos/PBSPro/pbspro/branches{/branch}","tags_url":"https://api.github.com/repos/PBSPro/pbspro/tags","blobs_url":"https://api.github.com/repos/PBSPro/pbspro/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PBSPro/pbspro/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PBSPro/pbspro/git/refs{/sha}","trees_url":"https://api.github.com/repos/PBSPro/pbspro/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PBSPro/pbspro/statuses/{sha}","languages_url":"https://api.github.com/repos/PBSPro/pbspro/languages","stargazers_url":"https://api.github.com/repos/PBSPro/pbspro/stargazers","contributors_url":"https://api.github.com/repos/PBSPro/pbspro/contributors","subscribers_url":"https://api.github.com/repos/PBSPro/pbspro/subscribers","subscription_url":"https://api.github.com/repos/PBSPro/pbspro/subscription","commits_url":"https://api.github.com/repos/PBSPro/pbspro/commits{/sha}","git_commits_url":"https://api.github.com/repos/PBSPro/pbspro/git/commits{/sha}","comments_url":"https://api.github.com/repos/PBSPro/pbspro/comments{/number}","issue_comment_url":"https://api.github.com/repos/PBSPro/pbspro/issues/comments{/number}","contents_url":"https://api.github.com/repos/PBSPro/pbspro/contents/{+path}","compare_url":"https://api.github.com/repos/PBSPro/pbspro/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PBSPro/pbspro/merges","archive_url":"https://api.github.com/repos/PBSPro/pbspro/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PBSPro/pbspro/downloads","issues_url":"https://api.github.com/repos/PBSPro/pbspro/issues{/number}","pulls_url":"https://api.github.com/repos/PBSPro/pbspro/pulls{/number}","milestones_url":"https://api.github.com/repos/PBSPro/pbspro/milestones{/number}","notifications_url":"https://api.github.com/repos/PBSPro/pbspro/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PBSPro/pbspro/labels{/name}","releases_url":"https://api.github.com/repos/PBSPro/pbspro/releases{/id}","deployments_url":"https://api.github.com/repos/PBSPro/pbspro/deployments","created_at":"2016-05-18T04:31:29Z","updated_at":"2018-02-15T06:05:37Z","pushed_at":"2018-02-16T19:17:27Z","git_url":"git://github.com/PBSPro/pbspro.git","ssh_url":"[email protected]:PBSPro/pbspro.git","clone_url":"https://github.com/PBSPro/pbspro.git","svn_url":"https://github.com/PBSPro/pbspro","homepage":"www.pbspro.org","size":10237,"stargazers_count":144,"watchers_count":144,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":125,"mirror_url":null,"archived":false,"open_issues_count":15,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":125,"open_issues":15,"watchers":144,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PBSPro/pbspro/pulls/566"},"html":{"href":"https://github.com/PBSPro/pbspro/pull/566"},"issue":{"href":"https://api.github.com/repos/PBSPro/pbspro/issues/566"},"comments":{"href":"https://api.github.com/repos/PBSPro/pbspro/issues/566/comments"},"review_comments":{"href":"https://api.github.com/repos/PBSPro/pbspro/pulls/566/comments"},"review_comment":{"href":"https://api.github.com/repos/PBSPro/pbspro/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PBSPro/pbspro/pulls/566/commits"},"statuses":{"href":"https://api.github.com/repos/PBSPro/pbspro/statuses/ec3f30e95ee5b246c37b42d30212fa31a3a8e595"}},"author_association":"CONTRIBUTOR"}} | {
"id": 59082072,
"name": "PBSPro/pbspro",
"url": "https://api.github.com/repos/PBSPro/pbspro"
} | {
"id": 6844975,
"login": "vstumpf",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6844975?",
"url": "https://api.github.com/users/vstumpf"
} | {
"id": 19280436,
"login": "PBSPro",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/19280436?",
"url": "https://api.github.com/orgs/PBSPro"
} | 2018-02-16T19:22:56 | 7256771827 | {"actor":{"display_login":"vstumpf"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/PDP-10/its/pulls/comments/243495374","pull_request_review_id":187281269,"id":243495374,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MzQ5NTM3NA==","diff_hunk":"@@ -0,0 +1,385 @@\n+\tTITLE PAPSAV\n+\n+\t; EJS (2018-12-20): Sourcee reconstructed CHANNA;RAKASH PAPSAV binary.\n+ ; This reconstructed version uses macros from SYSENG; CALRET > as the original\n+\t; source did. The original PAPSAV shared some code with SYSEN1;SYSMSG > (which\n+\t; also inserted SYSENG; CALRET >). Where applicable, the source from SYSMSG was\n+\t; used in this reconstruction.\n+\n+.INSRT SYSENG;CALRET >\n+\n+t1=1\n+t=2\n+tt=3\n+a=4\n+.prsva=4\n+b=5\n+c=6\n+f=7\n+pt=10\n+ch=11\n+count=12\n+.prsvz=13\n+.ap.=14\n+.pf.=15\n+.cf.=16\n+p=17\n+\n+tyic==2 ; tty input channel\n+tyoc==1 ; tty output channel\n+tyo=<.iot tyoc,> ; instruction to output a char\n+\n+\t0\t\t;not sure why this is needed\n+\n+; SYSTEM MESSAGE BUFFER CONTAINS 8-WORD ENTRIES AS FOLLOWS:\n+;\tABCDEF,,ASCIZ\n+;\tARG1\n+;\t...\n+;\tARG6\n+;\tTIME\n+; A..F = FORMAT OF ARG1..ARG6 RESPECTIVELY, CODED:\n+FMTBL:\t0\t;0 END OF MESSAGE\n+\tTYPOCT\t;1 FULL WORD OCTAL\n+\tTYPDEC\t;2 FULL WD DECIMAL\n+\tTYPHAF\t;3 \" WITH COMMAS\n+\tTYCRLF\t;4 DO CR\n+\tCPOPJ\t;5 ?\n+\tTYPSIX\t;6 SIXBIT\n+\tTYPASZ\t;7 ASCIZ\n+\n+CPOPJ:\tPOPJ P,\n+\n+feep: blt b,(.prsva)\n+CRLF:\tASCIZ/\n+/\n+\n+CMACMA:\tASCIZ/,,/\n+\n+SEP:\tASCIZ/-----\n+/\n+\n+bletch: asciz\\\n+WRONG SYSTEM VERSION - REPURIFY\n+\\\n+\n+MEMHOL:\tASCIZ\\\n+WARNING: THERE IS A HOLE IN MEMORY\n+\\\n+\n+\f;;; MAIN PROGRAM\n+\n+PROGRAM SYSMSG","path":"src/sysen3/papsav.2","position":71,"original_position":71,"commit_id":"0048851a021d3b1f04e0dba3065f326bd941d93b","original_commit_id":"0048851a021d3b1f04e0dba3065f326bd941d93b","user":{"login":"larsbrinkhoff","id":775050,"node_id":"MDQ6VXNlcjc3NTA1MA==","avatar_url":"https://avatars0.githubusercontent.com/u/775050?v=4","gravatar_id":"","url":"https://api.github.com/users/larsbrinkhoff","html_url":"https://github.com/larsbrinkhoff","followers_url":"https://api.github.com/users/larsbrinkhoff/followers","following_url":"https://api.github.com/users/larsbrinkhoff/following{/other_user}","gists_url":"https://api.github.com/users/larsbrinkhoff/gists{/gist_id}","starred_url":"https://api.github.com/users/larsbrinkhoff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/larsbrinkhoff/subscriptions","organizations_url":"https://api.github.com/users/larsbrinkhoff/orgs","repos_url":"https://api.github.com/users/larsbrinkhoff/repos","events_url":"https://api.github.com/users/larsbrinkhoff/events{/privacy}","received_events_url":"https://api.github.com/users/larsbrinkhoff/received_events","type":"User","site_admin":false},"body":"Ok, makes sense.","created_at":"2018-12-21T06:11:20Z","updated_at":"2018-12-21T06:11:20Z","html_url":"https://github.com/PDP-10/its/pull/1453#discussion_r243495374","pull_request_url":"https://api.github.com/repos/PDP-10/its/pulls/1453","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/PDP-10/its/pulls/comments/243495374"},"html":{"href":"https://github.com/PDP-10/its/pull/1453#discussion_r243495374"},"pull_request":{"href":"https://api.github.com/repos/PDP-10/its/pulls/1453"}},"in_reply_to_id":243493658},"pull_request":{"url":"https://api.github.com/repos/PDP-10/its/pulls/1453","id":240342961,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQwMzQyOTYx","html_url":"https://github.com/PDP-10/its/pull/1453","diff_url":"https://github.com/PDP-10/its/pull/1453.diff","patch_url":"https://github.com/PDP-10/its/pull/1453.patch","issue_url":"https://api.github.com/repos/PDP-10/its/issues/1453","number":1453,"state":"open","locked":false,"title":"Updated SYSEN3;PAPSAV 1 as SYSEN3;PAPSAV 2 to use SYSENG;CALRET","user":{"login":"eswenson1","id":867939,"node_id":"MDQ6VXNlcjg2NzkzOQ==","avatar_url":"https://avatars0.githubusercontent.com/u/867939?v=4","gravatar_id":"","url":"https://api.github.com/users/eswenson1","html_url":"https://github.com/eswenson1","followers_url":"https://api.github.com/users/eswenson1/followers","following_url":"https://api.github.com/users/eswenson1/following{/other_user}","gists_url":"https://api.github.com/users/eswenson1/gists{/gist_id}","starred_url":"https://api.github.com/users/eswenson1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eswenson1/subscriptions","organizations_url":"https://api.github.com/users/eswenson1/orgs","repos_url":"https://api.github.com/users/eswenson1/repos","events_url":"https://api.github.com/users/eswenson1/events{/privacy}","received_events_url":"https://api.github.com/users/eswenson1/received_events","type":"User","site_admin":false},"body":"The original PAPSAV used macros from SYSENG;CALRET >. This update makes PAPSAV use CALRET too. The resulting binary compares identically to CHANNA;RAKASH PAPSAV.\r\n\r\nResolves #1451.","created_at":"2018-12-21T00:46:46Z","updated_at":"2018-12-21T06:11:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d5b746f584c10e06ffc4d605e13bb013024dc94d","assignee":null,"assignees":[],"requested_reviewers":[{"login":"atsampson","id":436317,"node_id":"MDQ6VXNlcjQzNjMxNw==","avatar_url":"https://avatars3.githubusercontent.com/u/436317?v=4","gravatar_id":"","url":"https://api.github.com/users/atsampson","html_url":"https://github.com/atsampson","followers_url":"https://api.github.com/users/atsampson/followers","following_url":"https://api.github.com/users/atsampson/following{/other_user}","gists_url":"https://api.github.com/users/atsampson/gists{/gist_id}","starred_url":"https://api.github.com/users/atsampson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atsampson/subscriptions","organizations_url":"https://api.github.com/users/atsampson/orgs","repos_url":"https://api.github.com/users/atsampson/repos","events_url":"https://api.github.com/users/atsampson/events{/privacy}","received_events_url":"https://api.github.com/users/atsampson/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/PDP-10/its/pulls/1453/commits","review_comments_url":"https://api.github.com/repos/PDP-10/its/pulls/1453/comments","review_comment_url":"https://api.github.com/repos/PDP-10/its/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PDP-10/its/issues/1453/comments","statuses_url":"https://api.github.com/repos/PDP-10/its/statuses/0048851a021d3b1f04e0dba3065f326bd941d93b","head":{"label":"PDP-10:ejs/papsav_1451_3","ref":"ejs/papsav_1451_3","sha":"0048851a021d3b1f04e0dba3065f326bd941d93b","user":{"login":"PDP-10","id":19323163,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5MzIzMTYz","avatar_url":"https://avatars1.githubusercontent.com/u/19323163?v=4","gravatar_id":"","url":"https://api.github.com/users/PDP-10","html_url":"https://github.com/PDP-10","followers_url":"https://api.github.com/users/PDP-10/followers","following_url":"https://api.github.com/users/PDP-10/following{/other_user}","gists_url":"https://api.github.com/users/PDP-10/gists{/gist_id}","starred_url":"https://api.github.com/users/PDP-10/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PDP-10/subscriptions","organizations_url":"https://api.github.com/users/PDP-10/orgs","repos_url":"https://api.github.com/users/PDP-10/repos","events_url":"https://api.github.com/users/PDP-10/events{/privacy}","received_events_url":"https://api.github.com/users/PDP-10/received_events","type":"Organization","site_admin":false},"repo":{"id":71775220,"node_id":"MDEwOlJlcG9zaXRvcnk3MTc3NTIyMA==","name":"its","full_name":"PDP-10/its","private":false,"owner":{"login":"PDP-10","id":19323163,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5MzIzMTYz","avatar_url":"https://avatars1.githubusercontent.com/u/19323163?v=4","gravatar_id":"","url":"https://api.github.com/users/PDP-10","html_url":"https://github.com/PDP-10","followers_url":"https://api.github.com/users/PDP-10/followers","following_url":"https://api.github.com/users/PDP-10/following{/other_user}","gists_url":"https://api.github.com/users/PDP-10/gists{/gist_id}","starred_url":"https://api.github.com/users/PDP-10/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PDP-10/subscriptions","organizations_url":"https://api.github.com/users/PDP-10/orgs","repos_url":"https://api.github.com/users/PDP-10/repos","events_url":"https://api.github.com/users/PDP-10/events{/privacy}","received_events_url":"https://api.github.com/users/PDP-10/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/PDP-10/its","description":"Incompatible Timesharing System","fork":false,"url":"https://api.github.com/repos/PDP-10/its","forks_url":"https://api.github.com/repos/PDP-10/its/forks","keys_url":"https://api.github.com/repos/PDP-10/its/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PDP-10/its/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PDP-10/its/teams","hooks_url":"https://api.github.com/repos/PDP-10/its/hooks","issue_events_url":"https://api.github.com/repos/PDP-10/its/issues/events{/number}","events_url":"https://api.github.com/repos/PDP-10/its/events","assignees_url":"https://api.github.com/repos/PDP-10/its/assignees{/user}","branches_url":"https://api.github.com/repos/PDP-10/its/branches{/branch}","tags_url":"https://api.github.com/repos/PDP-10/its/tags","blobs_url":"https://api.github.com/repos/PDP-10/its/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PDP-10/its/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PDP-10/its/git/refs{/sha}","trees_url":"https://api.github.com/repos/PDP-10/its/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PDP-10/its/statuses/{sha}","languages_url":"https://api.github.com/repos/PDP-10/its/languages","stargazers_url":"https://api.github.com/repos/PDP-10/its/stargazers","contributors_url":"https://api.github.com/repos/PDP-10/its/contributors","subscribers_url":"https://api.github.com/repos/PDP-10/its/subscribers","subscription_url":"https://api.github.com/repos/PDP-10/its/subscription","commits_url":"https://api.github.com/repos/PDP-10/its/commits{/sha}","git_commits_url":"https://api.github.com/repos/PDP-10/its/git/commits{/sha}","comments_url":"https://api.github.com/repos/PDP-10/its/comments{/number}","issue_comment_url":"https://api.github.com/repos/PDP-10/its/issues/comments{/number}","contents_url":"https://api.github.com/repos/PDP-10/its/contents/{+path}","compare_url":"https://api.github.com/repos/PDP-10/its/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PDP-10/its/merges","archive_url":"https://api.github.com/repos/PDP-10/its/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PDP-10/its/downloads","issues_url":"https://api.github.com/repos/PDP-10/its/issues{/number}","pulls_url":"https://api.github.com/repos/PDP-10/its/pulls{/number}","milestones_url":"https://api.github.com/repos/PDP-10/its/milestones{/number}","notifications_url":"https://api.github.com/repos/PDP-10/its/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PDP-10/its/labels{/name}","releases_url":"https://api.github.com/repos/PDP-10/its/releases{/id}","deployments_url":"https://api.github.com/repos/PDP-10/its/deployments","created_at":"2016-10-24T09:52:01Z","updated_at":"2018-12-21T05:51:27Z","pushed_at":"2018-12-21T05:51:29Z","git_url":"git://github.com/PDP-10/its.git","ssh_url":"[email protected]:PDP-10/its.git","clone_url":"https://github.com/PDP-10/its.git","svn_url":"https://github.com/PDP-10/its","homepage":null,"size":107228,"stargazers_count":378,"watchers_count":378,"language":"Assembly","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":30,"mirror_url":null,"archived":false,"open_issues_count":400,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":30,"open_issues":400,"watchers":378,"default_branch":"master"}},"base":{"label":"PDP-10:master","ref":"master","sha":"29f02fe11266a08ab96fcb0bcb04bc0bea98066d","user":{"login":"PDP-10","id":19323163,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5MzIzMTYz","avatar_url":"https://avatars1.githubusercontent.com/u/19323163?v=4","gravatar_id":"","url":"https://api.github.com/users/PDP-10","html_url":"https://github.com/PDP-10","followers_url":"https://api.github.com/users/PDP-10/followers","following_url":"https://api.github.com/users/PDP-10/following{/other_user}","gists_url":"https://api.github.com/users/PDP-10/gists{/gist_id}","starred_url":"https://api.github.com/users/PDP-10/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PDP-10/subscriptions","organizations_url":"https://api.github.com/users/PDP-10/orgs","repos_url":"https://api.github.com/users/PDP-10/repos","events_url":"https://api.github.com/users/PDP-10/events{/privacy}","received_events_url":"https://api.github.com/users/PDP-10/received_events","type":"Organization","site_admin":false},"repo":{"id":71775220,"node_id":"MDEwOlJlcG9zaXRvcnk3MTc3NTIyMA==","name":"its","full_name":"PDP-10/its","private":false,"owner":{"login":"PDP-10","id":19323163,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5MzIzMTYz","avatar_url":"https://avatars1.githubusercontent.com/u/19323163?v=4","gravatar_id":"","url":"https://api.github.com/users/PDP-10","html_url":"https://github.com/PDP-10","followers_url":"https://api.github.com/users/PDP-10/followers","following_url":"https://api.github.com/users/PDP-10/following{/other_user}","gists_url":"https://api.github.com/users/PDP-10/gists{/gist_id}","starred_url":"https://api.github.com/users/PDP-10/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PDP-10/subscriptions","organizations_url":"https://api.github.com/users/PDP-10/orgs","repos_url":"https://api.github.com/users/PDP-10/repos","events_url":"https://api.github.com/users/PDP-10/events{/privacy}","received_events_url":"https://api.github.com/users/PDP-10/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/PDP-10/its","description":"Incompatible Timesharing System","fork":false,"url":"https://api.github.com/repos/PDP-10/its","forks_url":"https://api.github.com/repos/PDP-10/its/forks","keys_url":"https://api.github.com/repos/PDP-10/its/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PDP-10/its/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PDP-10/its/teams","hooks_url":"https://api.github.com/repos/PDP-10/its/hooks","issue_events_url":"https://api.github.com/repos/PDP-10/its/issues/events{/number}","events_url":"https://api.github.com/repos/PDP-10/its/events","assignees_url":"https://api.github.com/repos/PDP-10/its/assignees{/user}","branches_url":"https://api.github.com/repos/PDP-10/its/branches{/branch}","tags_url":"https://api.github.com/repos/PDP-10/its/tags","blobs_url":"https://api.github.com/repos/PDP-10/its/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PDP-10/its/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PDP-10/its/git/refs{/sha}","trees_url":"https://api.github.com/repos/PDP-10/its/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PDP-10/its/statuses/{sha}","languages_url":"https://api.github.com/repos/PDP-10/its/languages","stargazers_url":"https://api.github.com/repos/PDP-10/its/stargazers","contributors_url":"https://api.github.com/repos/PDP-10/its/contributors","subscribers_url":"https://api.github.com/repos/PDP-10/its/subscribers","subscription_url":"https://api.github.com/repos/PDP-10/its/subscription","commits_url":"https://api.github.com/repos/PDP-10/its/commits{/sha}","git_commits_url":"https://api.github.com/repos/PDP-10/its/git/commits{/sha}","comments_url":"https://api.github.com/repos/PDP-10/its/comments{/number}","issue_comment_url":"https://api.github.com/repos/PDP-10/its/issues/comments{/number}","contents_url":"https://api.github.com/repos/PDP-10/its/contents/{+path}","compare_url":"https://api.github.com/repos/PDP-10/its/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PDP-10/its/merges","archive_url":"https://api.github.com/repos/PDP-10/its/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PDP-10/its/downloads","issues_url":"https://api.github.com/repos/PDP-10/its/issues{/number}","pulls_url":"https://api.github.com/repos/PDP-10/its/pulls{/number}","milestones_url":"https://api.github.com/repos/PDP-10/its/milestones{/number}","notifications_url":"https://api.github.com/repos/PDP-10/its/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PDP-10/its/labels{/name}","releases_url":"https://api.github.com/repos/PDP-10/its/releases{/id}","deployments_url":"https://api.github.com/repos/PDP-10/its/deployments","created_at":"2016-10-24T09:52:01Z","updated_at":"2018-12-21T05:51:27Z","pushed_at":"2018-12-21T05:51:29Z","git_url":"git://github.com/PDP-10/its.git","ssh_url":"[email protected]:PDP-10/its.git","clone_url":"https://github.com/PDP-10/its.git","svn_url":"https://github.com/PDP-10/its","homepage":null,"size":107228,"stargazers_count":378,"watchers_count":378,"language":"Assembly","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":30,"mirror_url":null,"archived":false,"open_issues_count":400,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":30,"open_issues":400,"watchers":378,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PDP-10/its/pulls/1453"},"html":{"href":"https://github.com/PDP-10/its/pull/1453"},"issue":{"href":"https://api.github.com/repos/PDP-10/its/issues/1453"},"comments":{"href":"https://api.github.com/repos/PDP-10/its/issues/1453/comments"},"review_comments":{"href":"https://api.github.com/repos/PDP-10/its/pulls/1453/comments"},"review_comment":{"href":"https://api.github.com/repos/PDP-10/its/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PDP-10/its/pulls/1453/commits"},"statuses":{"href":"https://api.github.com/repos/PDP-10/its/statuses/0048851a021d3b1f04e0dba3065f326bd941d93b"}},"author_association":"MEMBER"}} | {
"id": 71775220,
"name": "PDP-10/its",
"url": "https://api.github.com/repos/PDP-10/its"
} | {
"id": 775050,
"login": "larsbrinkhoff",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/775050?",
"url": "https://api.github.com/users/larsbrinkhoff"
} | {
"id": 19323163,
"login": "PDP-10",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/19323163?",
"url": "https://api.github.com/orgs/PDP-10"
} | 2018-12-21T06:11:20 | 8789816842 | {"actor":{"display_login":"larsbrinkhoff"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/tecnocen-com/codeception-api-skeleton/pulls/comments/186606311","pull_request_review_id":118216287,"id":186606311,"diff_hunk":"@@ -8,16 +8,18 @@\n \"require\": {\n \"php\": \">=7.0.0\",\n \"codeception/base\": \"^2.2.3\",\n- \"codeception/verify\": \"~0.3.1\",\n+ \"codeception/verify\": \"^0.3.1\",\n \"facebook/webdriver\": \"^1.0.1\",\n \"flow/jsonpath\": \"^0.3.0\",\n \"guzzlehttp/guzzle\": \">=4.1.4 <7.0\"\n },\n \"autoload\": {\n+ \"psr-4\": { \"CodeceptionSkeleton\\\\\": \"src/\" },\n \"classmap\": [\n \"ComposerListener.php\"\n ]\n },\n+ \"bin\": [\"codecept-skeleton\"],","path":"composer.json","position":16,"original_position":16,"commit_id":"3b4ac50c84fe4b33fa4b3d8f3de2acca3fe3d0d0","original_commit_id":"3b4ac50c84fe4b33fa4b3d8f3de2acca3fe3d0d0","user":{"login":"Faryshta","id":2029247,"avatar_url":"https://avatars0.githubusercontent.com/u/2029247?v=4","gravatar_id":"","url":"https://api.github.com/users/Faryshta","html_url":"https://github.com/Faryshta","followers_url":"https://api.github.com/users/Faryshta/followers","following_url":"https://api.github.com/users/Faryshta/following{/other_user}","gists_url":"https://api.github.com/users/Faryshta/gists{/gist_id}","starred_url":"https://api.github.com/users/Faryshta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Faryshta/subscriptions","organizations_url":"https://api.github.com/users/Faryshta/orgs","repos_url":"https://api.github.com/users/Faryshta/repos","events_url":"https://api.github.com/users/Faryshta/events{/privacy}","received_events_url":"https://api.github.com/users/Faryshta/received_events","type":"User","site_admin":false},"body":"Ok it seems the use case for bin files is not clear.\r\n\r\nWhen someone adds a dependency on a project the 'require' section of composer.json its called a library, said library can include bin files to be executed by the project.\r\n\r\nThis repository is not a library and is never meant to be included as dependency in the 'require' section of any project. This repository is meant to be used as the skeleton for a project. So there is no use for any bin file here.","created_at":"2018-05-08T03:05:20Z","updated_at":"2018-05-08T03:05:20Z","html_url":"https://github.com/tecnocen-com/codeception-api-skeleton/pull/1#discussion_r186606311","pull_request_url":"https://api.github.com/repos/tecnocen-com/codeception-api-skeleton/pulls/1","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/tecnocen-com/codeception-api-skeleton/pulls/comments/186606311"},"html":{"href":"https://github.com/tecnocen-com/codeception-api-skeleton/pull/1#discussion_r186606311"},"pull_request":{"href":"https://api.github.com/repos/tecnocen-com/codeception-api-skeleton/pulls/1"}},"in_reply_to_id":184837645},"pull_request":{"url":"https://api.github.com/repos/tecnocen-com/codeception-api-skeleton/pulls/1","id":184532521,"html_url":"https://github.com/tecnocen-com/codeception-api-skeleton/pull/1","diff_url":"https://github.com/tecnocen-com/codeception-api-skeleton/pull/1.diff","patch_url":"https://github.com/tecnocen-com/codeception-api-skeleton/pull/1.patch","issue_url":"https://api.github.com/repos/tecnocen-com/codeception-api-skeleton/issues/1","number":1,"state":"open","locked":false,"title":"Single responsibility and new binary script","user":{"login":"Chofoteddy","id":1615875,"avatar_url":"https://avatars0.githubusercontent.com/u/1615875?v=4","gravatar_id":"","url":"https://api.github.com/users/Chofoteddy","html_url":"https://github.com/Chofoteddy","followers_url":"https://api.github.com/users/Chofoteddy/followers","following_url":"https://api.github.com/users/Chofoteddy/following{/other_user}","gists_url":"https://api.github.com/users/Chofoteddy/gists{/gist_id}","starred_url":"https://api.github.com/users/Chofoteddy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Chofoteddy/subscriptions","organizations_url":"https://api.github.com/users/Chofoteddy/orgs","repos_url":"https://api.github.com/users/Chofoteddy/repos","events_url":"https://api.github.com/users/Chofoteddy/events{/privacy}","received_events_url":"https://api.github.com/users/Chofoteddy/received_events","type":"User","site_admin":false},"body":"In order to have a better control over the drivers and be able to add functionality for each one more easily, I have separated the code, following the methodology of single responsibility.\r\n\r\nI have also added a new file that will be executed as a binary to be able to execute it from composer in any project.\r\n\r\nI attach an image to summarize the changes made.\r\n\r\n\r\n","created_at":"2018-04-27T06:12:58Z","updated_at":"2018-05-08T03:05:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"50a91a8af2a7846295958adba68bc906ee46d969","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/tecnocen-com/codeception-api-skeleton/pulls/1/commits","review_comments_url":"https://api.github.com/repos/tecnocen-com/codeception-api-skeleton/pulls/1/comments","review_comment_url":"https://api.github.com/repos/tecnocen-com/codeception-api-skeleton/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tecnocen-com/codeception-api-skeleton/issues/1/comments","statuses_url":"https://api.github.com/repos/tecnocen-com/codeception-api-skeleton/statuses/3b4ac50c84fe4b33fa4b3d8f3de2acca3fe3d0d0","head":{"label":"Chofoteddy:master","ref":"master","sha":"3b4ac50c84fe4b33fa4b3d8f3de2acca3fe3d0d0","user":{"login":"Chofoteddy","id":1615875,"avatar_url":"https://avatars0.githubusercontent.com/u/1615875?v=4","gravatar_id":"","url":"https://api.github.com/users/Chofoteddy","html_url":"https://github.com/Chofoteddy","followers_url":"https://api.github.com/users/Chofoteddy/followers","following_url":"https://api.github.com/users/Chofoteddy/following{/other_user}","gists_url":"https://api.github.com/users/Chofoteddy/gists{/gist_id}","starred_url":"https://api.github.com/users/Chofoteddy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Chofoteddy/subscriptions","organizations_url":"https://api.github.com/users/Chofoteddy/orgs","repos_url":"https://api.github.com/users/Chofoteddy/repos","events_url":"https://api.github.com/users/Chofoteddy/events{/privacy}","received_events_url":"https://api.github.com/users/Chofoteddy/received_events","type":"User","site_admin":false},"repo":{"id":131245068,"name":"codeception-api-skeleton","full_name":"Chofoteddy/codeception-api-skeleton","owner":{"login":"Chofoteddy","id":1615875,"avatar_url":"https://avatars0.githubusercontent.com/u/1615875?v=4","gravatar_id":"","url":"https://api.github.com/users/Chofoteddy","html_url":"https://github.com/Chofoteddy","followers_url":"https://api.github.com/users/Chofoteddy/followers","following_url":"https://api.github.com/users/Chofoteddy/following{/other_user}","gists_url":"https://api.github.com/users/Chofoteddy/gists{/gist_id}","starred_url":"https://api.github.com/users/Chofoteddy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Chofoteddy/subscriptions","organizations_url":"https://api.github.com/users/Chofoteddy/orgs","repos_url":"https://api.github.com/users/Chofoteddy/repos","events_url":"https://api.github.com/users/Chofoteddy/events{/privacy}","received_events_url":"https://api.github.com/users/Chofoteddy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Chofoteddy/codeception-api-skeleton","description":"Codeception template to create automated tests on external APIs","fork":true,"url":"https://api.github.com/repos/Chofoteddy/codeception-api-skeleton","forks_url":"https://api.github.com/repos/Chofoteddy/codeception-api-skeleton/forks","keys_url":"https://api.github.com/repos/Chofoteddy/codeception-api-skeleton/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Chofoteddy/codeception-api-skeleton/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Chofoteddy/codeception-api-skeleton/teams","hooks_url":"https://api.github.com/repos/Chofoteddy/codeception-api-skeleton/hooks","issue_events_url":"https://api.github.com/repos/Chofoteddy/codeception-api-skeleton/issues/events{/number}","events_url":"https://api.github.com/repos/Chofoteddy/codeception-api-skeleton/events","assignees_url":"https://api.github.com/repos/Chofoteddy/codeception-api-skeleton/assignees{/user}","branches_url":"https://api.github.com/repos/Chofoteddy/codeception-api-skeleton/branches{/branch}","tags_url":"https://api.github.com/repos/Chofoteddy/codeception-api-skeleton/tags","blobs_url":"https://api.github.com/repos/Chofoteddy/codeception-api-skeleton/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Chofoteddy/codeception-api-skeleton/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Chofoteddy/codeception-api-skeleton/git/refs{/sha}","trees_url":"https://api.github.com/repos/Chofoteddy/codeception-api-skeleton/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Chofoteddy/codeception-api-skeleton/statuses/{sha}","languages_url":"https://api.github.com/repos/Chofoteddy/codeception-api-skeleton/languages","stargazers_url":"https://api.github.com/repos/Chofoteddy/codeception-api-skeleton/stargazers","contributors_url":"https://api.github.com/repos/Chofoteddy/codeception-api-skeleton/contributors","subscribers_url":"https://api.github.com/repos/Chofoteddy/codeception-api-skeleton/subscribers","subscription_url":"https://api.github.com/repos/Chofoteddy/codeception-api-skeleton/subscription","commits_url":"https://api.github.com/repos/Chofoteddy/codeception-api-skeleton/commits{/sha}","git_commits_url":"https://api.github.com/repos/Chofoteddy/codeception-api-skeleton/git/commits{/sha}","comments_url":"https://api.github.com/repos/Chofoteddy/codeception-api-skeleton/comments{/number}","issue_comment_url":"https://api.github.com/repos/Chofoteddy/codeception-api-skeleton/issues/comments{/number}","contents_url":"https://api.github.com/repos/Chofoteddy/codeception-api-skeleton/contents/{+path}","compare_url":"https://api.github.com/repos/Chofoteddy/codeception-api-skeleton/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Chofoteddy/codeception-api-skeleton/merges","archive_url":"https://api.github.com/repos/Chofoteddy/codeception-api-skeleton/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Chofoteddy/codeception-api-skeleton/downloads","issues_url":"https://api.github.com/repos/Chofoteddy/codeception-api-skeleton/issues{/number}","pulls_url":"https://api.github.com/repos/Chofoteddy/codeception-api-skeleton/pulls{/number}","milestones_url":"https://api.github.com/repos/Chofoteddy/codeception-api-skeleton/milestones{/number}","notifications_url":"https://api.github.com/repos/Chofoteddy/codeception-api-skeleton/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Chofoteddy/codeception-api-skeleton/labels{/name}","releases_url":"https://api.github.com/repos/Chofoteddy/codeception-api-skeleton/releases{/id}","deployments_url":"https://api.github.com/repos/Chofoteddy/codeception-api-skeleton/deployments","created_at":"2018-04-27T04:22:19Z","updated_at":"2018-04-27T05:45:03Z","pushed_at":"2018-04-27T05:45:02Z","git_url":"git://github.com/Chofoteddy/codeception-api-skeleton.git","ssh_url":"[email protected]:Chofoteddy/codeception-api-skeleton.git","clone_url":"https://github.com/Chofoteddy/codeception-api-skeleton.git","svn_url":"https://github.com/Chofoteddy/codeception-api-skeleton","homepage":null,"size":40,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"tecnocen-com:master","ref":"master","sha":"25e6a6a1f7eeee942fed0b471b59b638028fb051","user":{"login":"tecnocen-com","id":19325750,"avatar_url":"https://avatars2.githubusercontent.com/u/19325750?v=4","gravatar_id":"","url":"https://api.github.com/users/tecnocen-com","html_url":"https://github.com/tecnocen-com","followers_url":"https://api.github.com/users/tecnocen-com/followers","following_url":"https://api.github.com/users/tecnocen-com/following{/other_user}","gists_url":"https://api.github.com/users/tecnocen-com/gists{/gist_id}","starred_url":"https://api.github.com/users/tecnocen-com/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tecnocen-com/subscriptions","organizations_url":"https://api.github.com/users/tecnocen-com/orgs","repos_url":"https://api.github.com/users/tecnocen-com/repos","events_url":"https://api.github.com/users/tecnocen-com/events{/privacy}","received_events_url":"https://api.github.com/users/tecnocen-com/received_events","type":"Organization","site_admin":false},"repo":{"id":102801804,"name":"codeception-api-skeleton","full_name":"tecnocen-com/codeception-api-skeleton","owner":{"login":"tecnocen-com","id":19325750,"avatar_url":"https://avatars2.githubusercontent.com/u/19325750?v=4","gravatar_id":"","url":"https://api.github.com/users/tecnocen-com","html_url":"https://github.com/tecnocen-com","followers_url":"https://api.github.com/users/tecnocen-com/followers","following_url":"https://api.github.com/users/tecnocen-com/following{/other_user}","gists_url":"https://api.github.com/users/tecnocen-com/gists{/gist_id}","starred_url":"https://api.github.com/users/tecnocen-com/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tecnocen-com/subscriptions","organizations_url":"https://api.github.com/users/tecnocen-com/orgs","repos_url":"https://api.github.com/users/tecnocen-com/repos","events_url":"https://api.github.com/users/tecnocen-com/events{/privacy}","received_events_url":"https://api.github.com/users/tecnocen-com/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tecnocen-com/codeception-api-skeleton","description":"Codeception template to create automated tests on external APIs","fork":false,"url":"https://api.github.com/repos/tecnocen-com/codeception-api-skeleton","forks_url":"https://api.github.com/repos/tecnocen-com/codeception-api-skeleton/forks","keys_url":"https://api.github.com/repos/tecnocen-com/codeception-api-skeleton/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tecnocen-com/codeception-api-skeleton/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tecnocen-com/codeception-api-skeleton/teams","hooks_url":"https://api.github.com/repos/tecnocen-com/codeception-api-skeleton/hooks","issue_events_url":"https://api.github.com/repos/tecnocen-com/codeception-api-skeleton/issues/events{/number}","events_url":"https://api.github.com/repos/tecnocen-com/codeception-api-skeleton/events","assignees_url":"https://api.github.com/repos/tecnocen-com/codeception-api-skeleton/assignees{/user}","branches_url":"https://api.github.com/repos/tecnocen-com/codeception-api-skeleton/branches{/branch}","tags_url":"https://api.github.com/repos/tecnocen-com/codeception-api-skeleton/tags","blobs_url":"https://api.github.com/repos/tecnocen-com/codeception-api-skeleton/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tecnocen-com/codeception-api-skeleton/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tecnocen-com/codeception-api-skeleton/git/refs{/sha}","trees_url":"https://api.github.com/repos/tecnocen-com/codeception-api-skeleton/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tecnocen-com/codeception-api-skeleton/statuses/{sha}","languages_url":"https://api.github.com/repos/tecnocen-com/codeception-api-skeleton/languages","stargazers_url":"https://api.github.com/repos/tecnocen-com/codeception-api-skeleton/stargazers","contributors_url":"https://api.github.com/repos/tecnocen-com/codeception-api-skeleton/contributors","subscribers_url":"https://api.github.com/repos/tecnocen-com/codeception-api-skeleton/subscribers","subscription_url":"https://api.github.com/repos/tecnocen-com/codeception-api-skeleton/subscription","commits_url":"https://api.github.com/repos/tecnocen-com/codeception-api-skeleton/commits{/sha}","git_commits_url":"https://api.github.com/repos/tecnocen-com/codeception-api-skeleton/git/commits{/sha}","comments_url":"https://api.github.com/repos/tecnocen-com/codeception-api-skeleton/comments{/number}","issue_comment_url":"https://api.github.com/repos/tecnocen-com/codeception-api-skeleton/issues/comments{/number}","contents_url":"https://api.github.com/repos/tecnocen-com/codeception-api-skeleton/contents/{+path}","compare_url":"https://api.github.com/repos/tecnocen-com/codeception-api-skeleton/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tecnocen-com/codeception-api-skeleton/merges","archive_url":"https://api.github.com/repos/tecnocen-com/codeception-api-skeleton/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tecnocen-com/codeception-api-skeleton/downloads","issues_url":"https://api.github.com/repos/tecnocen-com/codeception-api-skeleton/issues{/number}","pulls_url":"https://api.github.com/repos/tecnocen-com/codeception-api-skeleton/pulls{/number}","milestones_url":"https://api.github.com/repos/tecnocen-com/codeception-api-skeleton/milestones{/number}","notifications_url":"https://api.github.com/repos/tecnocen-com/codeception-api-skeleton/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tecnocen-com/codeception-api-skeleton/labels{/name}","releases_url":"https://api.github.com/repos/tecnocen-com/codeception-api-skeleton/releases{/id}","deployments_url":"https://api.github.com/repos/tecnocen-com/codeception-api-skeleton/deployments","created_at":"2017-09-08T01:15:12Z","updated_at":"2017-09-08T01:22:08Z","pushed_at":"2018-04-27T06:12:59Z","git_url":"git://github.com/tecnocen-com/codeception-api-skeleton.git","ssh_url":"[email protected]:tecnocen-com/codeception-api-skeleton.git","clone_url":"https://github.com/tecnocen-com/codeception-api-skeleton.git","svn_url":"https://github.com/tecnocen-com/codeception-api-skeleton","homepage":null,"size":26,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":2,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tecnocen-com/codeception-api-skeleton/pulls/1"},"html":{"href":"https://github.com/tecnocen-com/codeception-api-skeleton/pull/1"},"issue":{"href":"https://api.github.com/repos/tecnocen-com/codeception-api-skeleton/issues/1"},"comments":{"href":"https://api.github.com/repos/tecnocen-com/codeception-api-skeleton/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/tecnocen-com/codeception-api-skeleton/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/tecnocen-com/codeception-api-skeleton/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tecnocen-com/codeception-api-skeleton/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/tecnocen-com/codeception-api-skeleton/statuses/3b4ac50c84fe4b33fa4b3d8f3de2acca3fe3d0d0"}},"author_association":"NONE"}} | {
"id": 102801804,
"name": "tecnocen-com/codeception-api-skeleton",
"url": "https://api.github.com/repos/tecnocen-com/codeception-api-skeleton"
} | {
"id": 2029247,
"login": "Faryshta",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2029247?",
"url": "https://api.github.com/users/Faryshta"
} | {
"id": 19325750,
"login": "tecnocen-com",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/19325750?",
"url": "https://api.github.com/orgs/tecnocen-com"
} | 2018-05-08T03:05:20 | 7641162992 | {"actor":{"display_login":"Faryshta"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/screwdriver-cd/ui/pulls/comments/199636601","pull_request_review_id":133795212,"id":199636601,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5OTYzNjYwMQ==","diff_hunk":"@@ -16,7 +16,9 @@ export default Route.extend({\n tagPayload.forEach((tagObj) => {\n const taggedVerObj = verPayload.find(verObj => verObj.version === tagObj.version);\n \n- taggedVerObj.tag = taggedVerObj.tag ? `${taggedVerObj.tag} ${tagObj.tag}` : tagObj.tag;\n+ if (taggedVerObj) {","path":"app/templates/detail/route.js","position":5,"original_position":5,"commit_id":"73016111b14f3a19cad1d7f1609a9ac04c5a561c","original_commit_id":"73016111b14f3a19cad1d7f1609a9ac04c5a561c","user":{"login":"tkyi","id":3230529,"node_id":"MDQ6VXNlcjMyMzA1Mjk=","avatar_url":"https://avatars3.githubusercontent.com/u/3230529?v=4","gravatar_id":"","url":"https://api.github.com/users/tkyi","html_url":"https://github.com/tkyi","followers_url":"https://api.github.com/users/tkyi/followers","following_url":"https://api.github.com/users/tkyi/following{/other_user}","gists_url":"https://api.github.com/users/tkyi/gists{/gist_id}","starred_url":"https://api.github.com/users/tkyi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tkyi/subscriptions","organizations_url":"https://api.github.com/users/tkyi/orgs","repos_url":"https://api.github.com/users/tkyi/repos","events_url":"https://api.github.com/users/tkyi/events{/privacy}","received_events_url":"https://api.github.com/users/tkyi/received_events","type":"User","site_admin":false},"body":"probably should add this check to commands too","created_at":"2018-07-02T22:17:13Z","updated_at":"2018-07-02T22:17:14Z","html_url":"https://github.com/screwdriver-cd/ui/pull/327#discussion_r199636601","pull_request_url":"https://api.github.com/repos/screwdriver-cd/ui/pulls/327","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/screwdriver-cd/ui/pulls/comments/199636601"},"html":{"href":"https://github.com/screwdriver-cd/ui/pull/327#discussion_r199636601"},"pull_request":{"href":"https://api.github.com/repos/screwdriver-cd/ui/pulls/327"}}},"pull_request":{"url":"https://api.github.com/repos/screwdriver-cd/ui/pulls/327","id":198778237,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4Nzc4MjM3","html_url":"https://github.com/screwdriver-cd/ui/pull/327","diff_url":"https://github.com/screwdriver-cd/ui/pull/327.diff","patch_url":"https://github.com/screwdriver-cd/ui/pull/327.patch","issue_url":"https://api.github.com/repos/screwdriver-cd/ui/issues/327","number":327,"state":"open","locked":false,"title":"fix: Show Stop for UNSTABLE running builds","user":{"login":"jithin1987","id":193126,"node_id":"MDQ6VXNlcjE5MzEyNg==","avatar_url":"https://avatars2.githubusercontent.com/u/193126?v=4","gravatar_id":"","url":"https://api.github.com/users/jithin1987","html_url":"https://github.com/jithin1987","followers_url":"https://api.github.com/users/jithin1987/followers","following_url":"https://api.github.com/users/jithin1987/following{/other_user}","gists_url":"https://api.github.com/users/jithin1987/gists{/gist_id}","starred_url":"https://api.github.com/users/jithin1987/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jithin1987/subscriptions","organizations_url":"https://api.github.com/users/jithin1987/orgs","repos_url":"https://api.github.com/users/jithin1987/repos","events_url":"https://api.github.com/users/jithin1987/events{/privacy}","received_events_url":"https://api.github.com/users/jithin1987/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-07-02T20:14:08Z","updated_at":"2018-07-02T22:17:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1968de7dcf887a17663905d154d030a6e3f5d48e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/screwdriver-cd/ui/pulls/327/commits","review_comments_url":"https://api.github.com/repos/screwdriver-cd/ui/pulls/327/comments","review_comment_url":"https://api.github.com/repos/screwdriver-cd/ui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/screwdriver-cd/ui/issues/327/comments","statuses_url":"https://api.github.com/repos/screwdriver-cd/ui/statuses/73016111b14f3a19cad1d7f1609a9ac04c5a561c","head":{"label":"jithin1987:fixes","ref":"fixes","sha":"73016111b14f3a19cad1d7f1609a9ac04c5a561c","user":{"login":"jithin1987","id":193126,"node_id":"MDQ6VXNlcjE5MzEyNg==","avatar_url":"https://avatars2.githubusercontent.com/u/193126?v=4","gravatar_id":"","url":"https://api.github.com/users/jithin1987","html_url":"https://github.com/jithin1987","followers_url":"https://api.github.com/users/jithin1987/followers","following_url":"https://api.github.com/users/jithin1987/following{/other_user}","gists_url":"https://api.github.com/users/jithin1987/gists{/gist_id}","starred_url":"https://api.github.com/users/jithin1987/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jithin1987/subscriptions","organizations_url":"https://api.github.com/users/jithin1987/orgs","repos_url":"https://api.github.com/users/jithin1987/repos","events_url":"https://api.github.com/users/jithin1987/events{/privacy}","received_events_url":"https://api.github.com/users/jithin1987/received_events","type":"User","site_admin":false},"repo":{"id":96585258,"node_id":"MDEwOlJlcG9zaXRvcnk5NjU4NTI1OA==","name":"ui","full_name":"jithin1987/ui","owner":{"login":"jithin1987","id":193126,"node_id":"MDQ6VXNlcjE5MzEyNg==","avatar_url":"https://avatars2.githubusercontent.com/u/193126?v=4","gravatar_id":"","url":"https://api.github.com/users/jithin1987","html_url":"https://github.com/jithin1987","followers_url":"https://api.github.com/users/jithin1987/followers","following_url":"https://api.github.com/users/jithin1987/following{/other_user}","gists_url":"https://api.github.com/users/jithin1987/gists{/gist_id}","starred_url":"https://api.github.com/users/jithin1987/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jithin1987/subscriptions","organizations_url":"https://api.github.com/users/jithin1987/orgs","repos_url":"https://api.github.com/users/jithin1987/repos","events_url":"https://api.github.com/users/jithin1987/events{/privacy}","received_events_url":"https://api.github.com/users/jithin1987/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jithin1987/ui","description":"Screwdriver UI","fork":true,"url":"https://api.github.com/repos/jithin1987/ui","forks_url":"https://api.github.com/repos/jithin1987/ui/forks","keys_url":"https://api.github.com/repos/jithin1987/ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jithin1987/ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jithin1987/ui/teams","hooks_url":"https://api.github.com/repos/jithin1987/ui/hooks","issue_events_url":"https://api.github.com/repos/jithin1987/ui/issues/events{/number}","events_url":"https://api.github.com/repos/jithin1987/ui/events","assignees_url":"https://api.github.com/repos/jithin1987/ui/assignees{/user}","branches_url":"https://api.github.com/repos/jithin1987/ui/branches{/branch}","tags_url":"https://api.github.com/repos/jithin1987/ui/tags","blobs_url":"https://api.github.com/repos/jithin1987/ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jithin1987/ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jithin1987/ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/jithin1987/ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jithin1987/ui/statuses/{sha}","languages_url":"https://api.github.com/repos/jithin1987/ui/languages","stargazers_url":"https://api.github.com/repos/jithin1987/ui/stargazers","contributors_url":"https://api.github.com/repos/jithin1987/ui/contributors","subscribers_url":"https://api.github.com/repos/jithin1987/ui/subscribers","subscription_url":"https://api.github.com/repos/jithin1987/ui/subscription","commits_url":"https://api.github.com/repos/jithin1987/ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/jithin1987/ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/jithin1987/ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/jithin1987/ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/jithin1987/ui/contents/{+path}","compare_url":"https://api.github.com/repos/jithin1987/ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jithin1987/ui/merges","archive_url":"https://api.github.com/repos/jithin1987/ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jithin1987/ui/downloads","issues_url":"https://api.github.com/repos/jithin1987/ui/issues{/number}","pulls_url":"https://api.github.com/repos/jithin1987/ui/pulls{/number}","milestones_url":"https://api.github.com/repos/jithin1987/ui/milestones{/number}","notifications_url":"https://api.github.com/repos/jithin1987/ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jithin1987/ui/labels{/name}","releases_url":"https://api.github.com/repos/jithin1987/ui/releases{/id}","deployments_url":"https://api.github.com/repos/jithin1987/ui/deployments","created_at":"2017-07-08T00:15:15Z","updated_at":"2018-06-22T20:54:21Z","pushed_at":"2018-07-02T21:51:19Z","git_url":"git://github.com/jithin1987/ui.git","ssh_url":"[email protected]:jithin1987/ui.git","clone_url":"https://github.com/jithin1987/ui.git","svn_url":"https://github.com/jithin1987/ui","homepage":"https://cd.screwdriver.cd/pipelines/7","size":3268,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"screwdriver-cd:master","ref":"master","sha":"81203bdc0a741c11a12f017ced3101b7d3adcc82","user":{"login":"screwdriver-cd","id":19417863,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NDE3ODYz","avatar_url":"https://avatars0.githubusercontent.com/u/19417863?v=4","gravatar_id":"","url":"https://api.github.com/users/screwdriver-cd","html_url":"https://github.com/screwdriver-cd","followers_url":"https://api.github.com/users/screwdriver-cd/followers","following_url":"https://api.github.com/users/screwdriver-cd/following{/other_user}","gists_url":"https://api.github.com/users/screwdriver-cd/gists{/gist_id}","starred_url":"https://api.github.com/users/screwdriver-cd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/screwdriver-cd/subscriptions","organizations_url":"https://api.github.com/users/screwdriver-cd/orgs","repos_url":"https://api.github.com/users/screwdriver-cd/repos","events_url":"https://api.github.com/users/screwdriver-cd/events{/privacy}","received_events_url":"https://api.github.com/users/screwdriver-cd/received_events","type":"Organization","site_admin":false},"repo":{"id":64884594,"node_id":"MDEwOlJlcG9zaXRvcnk2NDg4NDU5NA==","name":"ui","full_name":"screwdriver-cd/ui","owner":{"login":"screwdriver-cd","id":19417863,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NDE3ODYz","avatar_url":"https://avatars0.githubusercontent.com/u/19417863?v=4","gravatar_id":"","url":"https://api.github.com/users/screwdriver-cd","html_url":"https://github.com/screwdriver-cd","followers_url":"https://api.github.com/users/screwdriver-cd/followers","following_url":"https://api.github.com/users/screwdriver-cd/following{/other_user}","gists_url":"https://api.github.com/users/screwdriver-cd/gists{/gist_id}","starred_url":"https://api.github.com/users/screwdriver-cd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/screwdriver-cd/subscriptions","organizations_url":"https://api.github.com/users/screwdriver-cd/orgs","repos_url":"https://api.github.com/users/screwdriver-cd/repos","events_url":"https://api.github.com/users/screwdriver-cd/events{/privacy}","received_events_url":"https://api.github.com/users/screwdriver-cd/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/screwdriver-cd/ui","description":"Screwdriver UI","fork":false,"url":"https://api.github.com/repos/screwdriver-cd/ui","forks_url":"https://api.github.com/repos/screwdriver-cd/ui/forks","keys_url":"https://api.github.com/repos/screwdriver-cd/ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/screwdriver-cd/ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/screwdriver-cd/ui/teams","hooks_url":"https://api.github.com/repos/screwdriver-cd/ui/hooks","issue_events_url":"https://api.github.com/repos/screwdriver-cd/ui/issues/events{/number}","events_url":"https://api.github.com/repos/screwdriver-cd/ui/events","assignees_url":"https://api.github.com/repos/screwdriver-cd/ui/assignees{/user}","branches_url":"https://api.github.com/repos/screwdriver-cd/ui/branches{/branch}","tags_url":"https://api.github.com/repos/screwdriver-cd/ui/tags","blobs_url":"https://api.github.com/repos/screwdriver-cd/ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/screwdriver-cd/ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/screwdriver-cd/ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/screwdriver-cd/ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/screwdriver-cd/ui/statuses/{sha}","languages_url":"https://api.github.com/repos/screwdriver-cd/ui/languages","stargazers_url":"https://api.github.com/repos/screwdriver-cd/ui/stargazers","contributors_url":"https://api.github.com/repos/screwdriver-cd/ui/contributors","subscribers_url":"https://api.github.com/repos/screwdriver-cd/ui/subscribers","subscription_url":"https://api.github.com/repos/screwdriver-cd/ui/subscription","commits_url":"https://api.github.com/repos/screwdriver-cd/ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/screwdriver-cd/ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/screwdriver-cd/ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/screwdriver-cd/ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/screwdriver-cd/ui/contents/{+path}","compare_url":"https://api.github.com/repos/screwdriver-cd/ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/screwdriver-cd/ui/merges","archive_url":"https://api.github.com/repos/screwdriver-cd/ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/screwdriver-cd/ui/downloads","issues_url":"https://api.github.com/repos/screwdriver-cd/ui/issues{/number}","pulls_url":"https://api.github.com/repos/screwdriver-cd/ui/pulls{/number}","milestones_url":"https://api.github.com/repos/screwdriver-cd/ui/milestones{/number}","notifications_url":"https://api.github.com/repos/screwdriver-cd/ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/screwdriver-cd/ui/labels{/name}","releases_url":"https://api.github.com/repos/screwdriver-cd/ui/releases{/id}","deployments_url":"https://api.github.com/repos/screwdriver-cd/ui/deployments","created_at":"2016-08-03T22:48:11Z","updated_at":"2018-06-28T20:34:46Z","pushed_at":"2018-07-02T22:06:50Z","git_url":"git://github.com/screwdriver-cd/ui.git","ssh_url":"[email protected]:screwdriver-cd/ui.git","clone_url":"https://github.com/screwdriver-cd/ui.git","svn_url":"https://github.com/screwdriver-cd/ui","homepage":"https://cd.screwdriver.cd/pipelines/7","size":3292,"stargazers_count":9,"watchers_count":9,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":20,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":20,"open_issues":7,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/screwdriver-cd/ui/pulls/327"},"html":{"href":"https://github.com/screwdriver-cd/ui/pull/327"},"issue":{"href":"https://api.github.com/repos/screwdriver-cd/ui/issues/327"},"comments":{"href":"https://api.github.com/repos/screwdriver-cd/ui/issues/327/comments"},"review_comments":{"href":"https://api.github.com/repos/screwdriver-cd/ui/pulls/327/comments"},"review_comment":{"href":"https://api.github.com/repos/screwdriver-cd/ui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/screwdriver-cd/ui/pulls/327/commits"},"statuses":{"href":"https://api.github.com/repos/screwdriver-cd/ui/statuses/73016111b14f3a19cad1d7f1609a9ac04c5a561c"}},"author_association":"CONTRIBUTOR"}} | {
"id": 64884594,
"name": "screwdriver-cd/ui",
"url": "https://api.github.com/repos/screwdriver-cd/ui"
} | {
"id": 3230529,
"login": "tkyi",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3230529?",
"url": "https://api.github.com/users/tkyi"
} | {
"id": 19417863,
"login": "screwdriver-cd",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/19417863?",
"url": "https://api.github.com/orgs/screwdriver-cd"
} | 2018-07-02T22:17:13 | 7909219458 | {"actor":{"display_login":"tkyi"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/material-components/material-components-web/pulls/comments/223119751","pull_request_review_id":162138975,"id":223119751,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMzExOTc1MQ==","diff_hunk":"@@ -150,14 +175,49 @@ class MDCSelect extends MDCComponent {\n }\n }\n \n+ /**\n+ * Handles setup for the enhanced menu.\n+ * @private\n+ */\n+ enhancedSelectSetup_(menuFactory) {\n+ const isDisabled = this.root_.classList.contains(cssClasses.DISABLED);\n+ this.selectedText_.setAttribute('tabindex', isDisabled ? '-1' : '0');\n+ this.menuElement_ = /** @type {HTMLElement} */ (this.root_.querySelector(strings.MENU_SELECTOR));\n+ this.menu_ = menuFactory(this.menuElement_);\n+ this.menu_.hoistMenuToBody();\n+ this.menu_.setAnchorElement(/** @type {!HTMLElement} */ (this.root_));\n+ this.menu_.setAnchorCorner(menuSurfaceConstants.Corner.BOTTOM_START);\n+ this.menu_.listen(menuSurfaceConstants.strings.CLOSED_EVENT, () => {\n+ // menuOpened_ is used to track the state of the menu opening or closing since the menu.open function\n+ // will return false if the menu is still closing and this method listens to the closed event which\n+ // occurs after the menu is already closed.\n+ this.menuOpened_ = false;\n+ if (document.activeElement !== this.selectedText_) {\n+ this.foundation_.handleBlur();\n+ }\n+ });\n+\n+ // Menu should open to the last selected element.\n+ this.menu_.listen(menuSurfaceConstants.strings.OPENED_EVENT, () => {","path":"packages/mdc-select/index.js","position":159,"original_position":159,"commit_id":"072116aa57a87bdafc4ab7a4c57a116e95bbd669","original_commit_id":"072116aa57a87bdafc4ab7a4c57a116e95bbd669","user":{"login":"kfranqueiro","id":398379,"node_id":"MDQ6VXNlcjM5ODM3OQ==","avatar_url":"https://avatars2.githubusercontent.com/u/398379?v=4","gravatar_id":"","url":"https://api.github.com/users/kfranqueiro","html_url":"https://github.com/kfranqueiro","followers_url":"https://api.github.com/users/kfranqueiro/followers","following_url":"https://api.github.com/users/kfranqueiro/following{/other_user}","gists_url":"https://api.github.com/users/kfranqueiro/gists{/gist_id}","starred_url":"https://api.github.com/users/kfranqueiro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kfranqueiro/subscriptions","organizations_url":"https://api.github.com/users/kfranqueiro/orgs","repos_url":"https://api.github.com/users/kfranqueiro/repos","events_url":"https://api.github.com/users/kfranqueiro/events{/privacy}","received_events_url":"https://api.github.com/users/kfranqueiro/received_events","type":"User","site_admin":false},"body":"Are these listeners ever being removed?","created_at":"2018-10-05T19:41:13Z","updated_at":"2018-10-05T19:45:41Z","html_url":"https://github.com/material-components/material-components-web/pull/3608#discussion_r223119751","pull_request_url":"https://api.github.com/repos/material-components/material-components-web/pulls/3608","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/material-components/material-components-web/pulls/comments/223119751"},"html":{"href":"https://github.com/material-components/material-components-web/pull/3608#discussion_r223119751"},"pull_request":{"href":"https://api.github.com/repos/material-components/material-components-web/pulls/3608"}}},"pull_request":{"url":"https://api.github.com/repos/material-components/material-components-web/pulls/3608","id":217349383,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3MzQ5Mzgz","html_url":"https://github.com/material-components/material-components-web/pull/3608","diff_url":"https://github.com/material-components/material-components-web/pull/3608.diff","patch_url":"https://github.com/material-components/material-components-web/pull/3608.patch","issue_url":"https://api.github.com/repos/material-components/material-components-web/issues/3608","number":3608,"state":"open","locked":false,"title":"feat(select): Add enhanced select","user":{"login":"williamernest","id":34519388,"node_id":"MDQ6VXNlcjM0NTE5Mzg4","avatar_url":"https://avatars3.githubusercontent.com/u/34519388?v=4","gravatar_id":"","url":"https://api.github.com/users/williamernest","html_url":"https://github.com/williamernest","followers_url":"https://api.github.com/users/williamernest/followers","following_url":"https://api.github.com/users/williamernest/following{/other_user}","gists_url":"https://api.github.com/users/williamernest/gists{/gist_id}","starred_url":"https://api.github.com/users/williamernest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/williamernest/subscriptions","organizations_url":"https://api.github.com/users/williamernest/orgs","repos_url":"https://api.github.com/users/williamernest/repos","events_url":"https://api.github.com/users/williamernest/events{/privacy}","received_events_url":"https://api.github.com/users/williamernest/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-09-21T17:21:00Z","updated_at":"2018-10-05T19:45:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"61f5a3193fcc5f703507822aacda76077fbe19fb","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1036895551,"node_id":"MDU6TGFiZWwxMDM2ODk1NTUx","url":"https://api.github.com/repos/material-components/material-components-web/labels/cla:%20yes","name":"cla: yes","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/material-components/material-components-web/pulls/3608/commits","review_comments_url":"https://api.github.com/repos/material-components/material-components-web/pulls/3608/comments","review_comment_url":"https://api.github.com/repos/material-components/material-components-web/pulls/comments{/number}","comments_url":"https://api.github.com/repos/material-components/material-components-web/issues/3608/comments","statuses_url":"https://api.github.com/repos/material-components/material-components-web/statuses/072116aa57a87bdafc4ab7a4c57a116e95bbd669","head":{"label":"material-components:feat/select/enhanced-select","ref":"feat/select/enhanced-select","sha":"072116aa57a87bdafc4ab7a4c57a116e95bbd669","user":{"login":"material-components","id":19478152,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NDc4MTUy","avatar_url":"https://avatars3.githubusercontent.com/u/19478152?v=4","gravatar_id":"","url":"https://api.github.com/users/material-components","html_url":"https://github.com/material-components","followers_url":"https://api.github.com/users/material-components/followers","following_url":"https://api.github.com/users/material-components/following{/other_user}","gists_url":"https://api.github.com/users/material-components/gists{/gist_id}","starred_url":"https://api.github.com/users/material-components/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/material-components/subscriptions","organizations_url":"https://api.github.com/users/material-components/orgs","repos_url":"https://api.github.com/users/material-components/repos","events_url":"https://api.github.com/users/material-components/events{/privacy}","received_events_url":"https://api.github.com/users/material-components/received_events","type":"Organization","site_admin":false},"repo":{"id":75642389,"node_id":"MDEwOlJlcG9zaXRvcnk3NTY0MjM4OQ==","name":"material-components-web","full_name":"material-components/material-components-web","private":false,"owner":{"login":"material-components","id":19478152,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NDc4MTUy","avatar_url":"https://avatars3.githubusercontent.com/u/19478152?v=4","gravatar_id":"","url":"https://api.github.com/users/material-components","html_url":"https://github.com/material-components","followers_url":"https://api.github.com/users/material-components/followers","following_url":"https://api.github.com/users/material-components/following{/other_user}","gists_url":"https://api.github.com/users/material-components/gists{/gist_id}","starred_url":"https://api.github.com/users/material-components/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/material-components/subscriptions","organizations_url":"https://api.github.com/users/material-components/orgs","repos_url":"https://api.github.com/users/material-components/repos","events_url":"https://api.github.com/users/material-components/events{/privacy}","received_events_url":"https://api.github.com/users/material-components/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/material-components/material-components-web","description":"Modular and customizable Material Design UI components for the web","fork":false,"url":"https://api.github.com/repos/material-components/material-components-web","forks_url":"https://api.github.com/repos/material-components/material-components-web/forks","keys_url":"https://api.github.com/repos/material-components/material-components-web/keys{/key_id}","collaborators_url":"https://api.github.com/repos/material-components/material-components-web/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/material-components/material-components-web/teams","hooks_url":"https://api.github.com/repos/material-components/material-components-web/hooks","issue_events_url":"https://api.github.com/repos/material-components/material-components-web/issues/events{/number}","events_url":"https://api.github.com/repos/material-components/material-components-web/events","assignees_url":"https://api.github.com/repos/material-components/material-components-web/assignees{/user}","branches_url":"https://api.github.com/repos/material-components/material-components-web/branches{/branch}","tags_url":"https://api.github.com/repos/material-components/material-components-web/tags","blobs_url":"https://api.github.com/repos/material-components/material-components-web/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/material-components/material-components-web/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/material-components/material-components-web/git/refs{/sha}","trees_url":"https://api.github.com/repos/material-components/material-components-web/git/trees{/sha}","statuses_url":"https://api.github.com/repos/material-components/material-components-web/statuses/{sha}","languages_url":"https://api.github.com/repos/material-components/material-components-web/languages","stargazers_url":"https://api.github.com/repos/material-components/material-components-web/stargazers","contributors_url":"https://api.github.com/repos/material-components/material-components-web/contributors","subscribers_url":"https://api.github.com/repos/material-components/material-components-web/subscribers","subscription_url":"https://api.github.com/repos/material-components/material-components-web/subscription","commits_url":"https://api.github.com/repos/material-components/material-components-web/commits{/sha}","git_commits_url":"https://api.github.com/repos/material-components/material-components-web/git/commits{/sha}","comments_url":"https://api.github.com/repos/material-components/material-components-web/comments{/number}","issue_comment_url":"https://api.github.com/repos/material-components/material-components-web/issues/comments{/number}","contents_url":"https://api.github.com/repos/material-components/material-components-web/contents/{+path}","compare_url":"https://api.github.com/repos/material-components/material-components-web/compare/{base}...{head}","merges_url":"https://api.github.com/repos/material-components/material-components-web/merges","archive_url":"https://api.github.com/repos/material-components/material-components-web/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/material-components/material-components-web/downloads","issues_url":"https://api.github.com/repos/material-components/material-components-web/issues{/number}","pulls_url":"https://api.github.com/repos/material-components/material-components-web/pulls{/number}","milestones_url":"https://api.github.com/repos/material-components/material-components-web/milestones{/number}","notifications_url":"https://api.github.com/repos/material-components/material-components-web/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/material-components/material-components-web/labels{/name}","releases_url":"https://api.github.com/repos/material-components/material-components-web/releases{/id}","deployments_url":"https://api.github.com/repos/material-components/material-components-web/deployments","created_at":"2016-12-05T16:04:09Z","updated_at":"2018-10-05T19:24:47Z","pushed_at":"2018-10-05T17:21:12Z","git_url":"git://github.com/material-components/material-components-web.git","ssh_url":"[email protected]:material-components/material-components-web.git","clone_url":"https://github.com/material-components/material-components-web.git","svn_url":"https://github.com/material-components/material-components-web","homepage":"https://material.io/develop/","size":70401,"stargazers_count":10495,"watchers_count":10495,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1262,"mirror_url":null,"archived":false,"open_issues_count":321,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1262,"open_issues":321,"watchers":10495,"default_branch":"master"}},"base":{"label":"material-components:feat/select-new","ref":"feat/select-new","sha":"9c24a9ed4f6397352abb29f136e764aaacc0d4bf","user":{"login":"material-components","id":19478152,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NDc4MTUy","avatar_url":"https://avatars3.githubusercontent.com/u/19478152?v=4","gravatar_id":"","url":"https://api.github.com/users/material-components","html_url":"https://github.com/material-components","followers_url":"https://api.github.com/users/material-components/followers","following_url":"https://api.github.com/users/material-components/following{/other_user}","gists_url":"https://api.github.com/users/material-components/gists{/gist_id}","starred_url":"https://api.github.com/users/material-components/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/material-components/subscriptions","organizations_url":"https://api.github.com/users/material-components/orgs","repos_url":"https://api.github.com/users/material-components/repos","events_url":"https://api.github.com/users/material-components/events{/privacy}","received_events_url":"https://api.github.com/users/material-components/received_events","type":"Organization","site_admin":false},"repo":{"id":75642389,"node_id":"MDEwOlJlcG9zaXRvcnk3NTY0MjM4OQ==","name":"material-components-web","full_name":"material-components/material-components-web","private":false,"owner":{"login":"material-components","id":19478152,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NDc4MTUy","avatar_url":"https://avatars3.githubusercontent.com/u/19478152?v=4","gravatar_id":"","url":"https://api.github.com/users/material-components","html_url":"https://github.com/material-components","followers_url":"https://api.github.com/users/material-components/followers","following_url":"https://api.github.com/users/material-components/following{/other_user}","gists_url":"https://api.github.com/users/material-components/gists{/gist_id}","starred_url":"https://api.github.com/users/material-components/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/material-components/subscriptions","organizations_url":"https://api.github.com/users/material-components/orgs","repos_url":"https://api.github.com/users/material-components/repos","events_url":"https://api.github.com/users/material-components/events{/privacy}","received_events_url":"https://api.github.com/users/material-components/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/material-components/material-components-web","description":"Modular and customizable Material Design UI components for the web","fork":false,"url":"https://api.github.com/repos/material-components/material-components-web","forks_url":"https://api.github.com/repos/material-components/material-components-web/forks","keys_url":"https://api.github.com/repos/material-components/material-components-web/keys{/key_id}","collaborators_url":"https://api.github.com/repos/material-components/material-components-web/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/material-components/material-components-web/teams","hooks_url":"https://api.github.com/repos/material-components/material-components-web/hooks","issue_events_url":"https://api.github.com/repos/material-components/material-components-web/issues/events{/number}","events_url":"https://api.github.com/repos/material-components/material-components-web/events","assignees_url":"https://api.github.com/repos/material-components/material-components-web/assignees{/user}","branches_url":"https://api.github.com/repos/material-components/material-components-web/branches{/branch}","tags_url":"https://api.github.com/repos/material-components/material-components-web/tags","blobs_url":"https://api.github.com/repos/material-components/material-components-web/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/material-components/material-components-web/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/material-components/material-components-web/git/refs{/sha}","trees_url":"https://api.github.com/repos/material-components/material-components-web/git/trees{/sha}","statuses_url":"https://api.github.com/repos/material-components/material-components-web/statuses/{sha}","languages_url":"https://api.github.com/repos/material-components/material-components-web/languages","stargazers_url":"https://api.github.com/repos/material-components/material-components-web/stargazers","contributors_url":"https://api.github.com/repos/material-components/material-components-web/contributors","subscribers_url":"https://api.github.com/repos/material-components/material-components-web/subscribers","subscription_url":"https://api.github.com/repos/material-components/material-components-web/subscription","commits_url":"https://api.github.com/repos/material-components/material-components-web/commits{/sha}","git_commits_url":"https://api.github.com/repos/material-components/material-components-web/git/commits{/sha}","comments_url":"https://api.github.com/repos/material-components/material-components-web/comments{/number}","issue_comment_url":"https://api.github.com/repos/material-components/material-components-web/issues/comments{/number}","contents_url":"https://api.github.com/repos/material-components/material-components-web/contents/{+path}","compare_url":"https://api.github.com/repos/material-components/material-components-web/compare/{base}...{head}","merges_url":"https://api.github.com/repos/material-components/material-components-web/merges","archive_url":"https://api.github.com/repos/material-components/material-components-web/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/material-components/material-components-web/downloads","issues_url":"https://api.github.com/repos/material-components/material-components-web/issues{/number}","pulls_url":"https://api.github.com/repos/material-components/material-components-web/pulls{/number}","milestones_url":"https://api.github.com/repos/material-components/material-components-web/milestones{/number}","notifications_url":"https://api.github.com/repos/material-components/material-components-web/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/material-components/material-components-web/labels{/name}","releases_url":"https://api.github.com/repos/material-components/material-components-web/releases{/id}","deployments_url":"https://api.github.com/repos/material-components/material-components-web/deployments","created_at":"2016-12-05T16:04:09Z","updated_at":"2018-10-05T19:24:47Z","pushed_at":"2018-10-05T17:21:12Z","git_url":"git://github.com/material-components/material-components-web.git","ssh_url":"[email protected]:material-components/material-components-web.git","clone_url":"https://github.com/material-components/material-components-web.git","svn_url":"https://github.com/material-components/material-components-web","homepage":"https://material.io/develop/","size":70401,"stargazers_count":10495,"watchers_count":10495,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1262,"mirror_url":null,"archived":false,"open_issues_count":321,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1262,"open_issues":321,"watchers":10495,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/material-components/material-components-web/pulls/3608"},"html":{"href":"https://github.com/material-components/material-components-web/pull/3608"},"issue":{"href":"https://api.github.com/repos/material-components/material-components-web/issues/3608"},"comments":{"href":"https://api.github.com/repos/material-components/material-components-web/issues/3608/comments"},"review_comments":{"href":"https://api.github.com/repos/material-components/material-components-web/pulls/3608/comments"},"review_comment":{"href":"https://api.github.com/repos/material-components/material-components-web/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/material-components/material-components-web/pulls/3608/commits"},"statuses":{"href":"https://api.github.com/repos/material-components/material-components-web/statuses/072116aa57a87bdafc4ab7a4c57a116e95bbd669"}},"author_association":"CONTRIBUTOR"}} | {
"id": 75642389,
"name": "material-components/material-components-web",
"url": "https://api.github.com/repos/material-components/material-components-web"
} | {
"id": 398379,
"login": "kfranqueiro",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/398379?",
"url": "https://api.github.com/users/kfranqueiro"
} | {
"id": 19478152,
"login": "material-components",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/19478152?",
"url": "https://api.github.com/orgs/material-components"
} | 2018-10-05T19:41:13 | 8376417901 | {"actor":{"display_login":"kfranqueiro"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/material-components/material-components-ios/pulls/comments/205173753","pull_request_review_id":140391654,"id":205173753,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNTE3Mzc1Mw==","diff_hunk":"@@ -269,18 +269,19 @@ recommendations:\n \n Since assistive technologies visit all cards in a collection in a sequential order, it is often \n easier to distinguish between elements that belong to different cards by aggregating all the \n-card's information to a single sentence. This can be done by setting an appropriate \n+card's information so the card is read as a single sentence. \n+This can be done by setting an appropriate \n [`accessibilityLabel`](https://developer.apple.com/documentation/uikit/uiaccessibilityelement/1619577-accessibilitylabel) \n for the card. Additionally, set the card's \n-[`isAccessiblityElement`](https://developer.apple.com/documentation/objectivec/nsobject/1615141-isaccessibilityelement) \n-to on. Cards are a container element and setting isAccessibiltElement for a container turns \n-off individually selecting its subelements.\n+[`isAccessibilityElement`](https://developer.apple.com/documentation/objectivec/nsobject/1615141-isaccessibilityelement) \n+to true. Cards are a container element and setting isAccessibiltyElement for a container \n+turns off individually selecting its subelements.\n \n Swift\n ```swift\n card.isAccessibilityElement = true\n card.accessibilityLabel = \"Location (userLocation.name) is popular with users \" +\n- \"who enjoy (userLocation.popularActivityMatchingUserProfile(userProfile).\"\n+ \"who enjoy (userLocation.popularActivityMatchingUserProfile(userProfile))\"","path":"components/Cards/README.md","position":21,"original_position":21,"commit_id":"407acabaa7d5a3d45dfeed83596c007e18dccd7c","original_commit_id":"407acabaa7d5a3d45dfeed83596c007e18dccd7c","user":{"login":"romoore","id":1753199,"node_id":"MDQ6VXNlcjE3NTMxOTk=","avatar_url":"https://avatars3.githubusercontent.com/u/1753199?v=4","gravatar_id":"","url":"https://api.github.com/users/romoore","html_url":"https://github.com/romoore","followers_url":"https://api.github.com/users/romoore/followers","following_url":"https://api.github.com/users/romoore/following{/other_user}","gists_url":"https://api.github.com/users/romoore/gists{/gist_id}","starred_url":"https://api.github.com/users/romoore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/romoore/subscriptions","organizations_url":"https://api.github.com/users/romoore/orgs","repos_url":"https://api.github.com/users/romoore/repos","events_url":"https://api.github.com/users/romoore/events{/privacy}","received_events_url":"https://api.github.com/users/romoore/received_events","type":"User","site_admin":false},"body":"I thought value escapes needed to be preceded with a backslash?","created_at":"2018-07-25T16:17:32Z","updated_at":"2018-07-25T16:19:37Z","html_url":"https://github.com/material-components/material-components-ios/pull/4634#discussion_r205173753","pull_request_url":"https://api.github.com/repos/material-components/material-components-ios/pulls/4634","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/material-components/material-components-ios/pulls/comments/205173753"},"html":{"href":"https://github.com/material-components/material-components-ios/pull/4634#discussion_r205173753"},"pull_request":{"href":"https://api.github.com/repos/material-components/material-components-ios/pulls/4634"}}},"pull_request":{"url":"https://api.github.com/repos/material-components/material-components-ios/pulls/4634","id":203890787,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzODkwNzg3","html_url":"https://github.com/material-components/material-components-ios/pull/4634","diff_url":"https://github.com/material-components/material-components-ios/pull/4634.diff","patch_url":"https://github.com/material-components/material-components-ios/pull/4634.patch","issue_url":"https://api.github.com/repos/material-components/material-components-ios/issues/4634","number":4634,"state":"open","locked":false,"title":"[Cards] Accessibility: Fixing documentation typos","user":{"login":"galiak11","id":2329102,"node_id":"MDQ6VXNlcjIzMjkxMDI=","avatar_url":"https://avatars0.githubusercontent.com/u/2329102?v=4","gravatar_id":"","url":"https://api.github.com/users/galiak11","html_url":"https://github.com/galiak11","followers_url":"https://api.github.com/users/galiak11/followers","following_url":"https://api.github.com/users/galiak11/following{/other_user}","gists_url":"https://api.github.com/users/galiak11/gists{/gist_id}","starred_url":"https://api.github.com/users/galiak11/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/galiak11/subscriptions","organizations_url":"https://api.github.com/users/galiak11/orgs","repos_url":"https://api.github.com/users/galiak11/repos","events_url":"https://api.github.com/users/galiak11/events{/privacy}","received_events_url":"https://api.github.com/users/galiak11/received_events","type":"User","site_admin":false},"body":"- Fixing typos in accessibility documentation for Cards.\r\n- Fixing a script to correctly show a message when Jazzy is not installed.\r\n","created_at":"2018-07-25T16:15:39Z","updated_at":"2018-07-25T16:19:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"37fe2c56f30c94707a19eb72b4dad4e8e1888742","assignee":null,"assignees":[],"requested_reviewers":[{"login":"yarneo","id":4066863,"node_id":"MDQ6VXNlcjQwNjY4NjM=","avatar_url":"https://avatars2.githubusercontent.com/u/4066863?v=4","gravatar_id":"","url":"https://api.github.com/users/yarneo","html_url":"https://github.com/yarneo","followers_url":"https://api.github.com/users/yarneo/followers","following_url":"https://api.github.com/users/yarneo/following{/other_user}","gists_url":"https://api.github.com/users/yarneo/gists{/gist_id}","starred_url":"https://api.github.com/users/yarneo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yarneo/subscriptions","organizations_url":"https://api.github.com/users/yarneo/orgs","repos_url":"https://api.github.com/users/yarneo/repos","events_url":"https://api.github.com/users/yarneo/events{/privacy}","received_events_url":"https://api.github.com/users/yarneo/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":413941621,"node_id":"MDU6TGFiZWw0MTM5NDE2MjE=","url":"https://api.github.com/repos/material-components/material-components-ios/labels/Accessibility","name":"Accessibility","color":"c5def5","default":false},{"id":824189294,"node_id":"MDU6TGFiZWw4MjQxODkyOTQ=","url":"https://api.github.com/repos/material-components/material-components-ios/labels/[Cards]","name":"[Cards]","color":"eeeeee","default":false},{"id":273191333,"node_id":"MDU6TGFiZWwyNzMxOTEzMzM=","url":"https://api.github.com/repos/material-components/material-components-ios/labels/cla:%20yes","name":"cla: yes","color":"c2e0c6","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/material-components/material-components-ios/pulls/4634/commits","review_comments_url":"https://api.github.com/repos/material-components/material-components-ios/pulls/4634/comments","review_comment_url":"https://api.github.com/repos/material-components/material-components-ios/pulls/comments{/number}","comments_url":"https://api.github.com/repos/material-components/material-components-ios/issues/4634/comments","statuses_url":"https://api.github.com/repos/material-components/material-components-ios/statuses/407acabaa7d5a3d45dfeed83596c007e18dccd7c","head":{"label":"galiak11:gk_cards_readme","ref":"gk_cards_readme","sha":"407acabaa7d5a3d45dfeed83596c007e18dccd7c","user":{"login":"galiak11","id":2329102,"node_id":"MDQ6VXNlcjIzMjkxMDI=","avatar_url":"https://avatars0.githubusercontent.com/u/2329102?v=4","gravatar_id":"","url":"https://api.github.com/users/galiak11","html_url":"https://github.com/galiak11","followers_url":"https://api.github.com/users/galiak11/followers","following_url":"https://api.github.com/users/galiak11/following{/other_user}","gists_url":"https://api.github.com/users/galiak11/gists{/gist_id}","starred_url":"https://api.github.com/users/galiak11/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/galiak11/subscriptions","organizations_url":"https://api.github.com/users/galiak11/orgs","repos_url":"https://api.github.com/users/galiak11/repos","events_url":"https://api.github.com/users/galiak11/events{/privacy}","received_events_url":"https://api.github.com/users/galiak11/received_events","type":"User","site_admin":false},"repo":{"id":137527649,"node_id":"MDEwOlJlcG9zaXRvcnkxMzc1Mjc2NDk=","name":"material-components-ios","full_name":"galiak11/material-components-ios","owner":{"login":"galiak11","id":2329102,"node_id":"MDQ6VXNlcjIzMjkxMDI=","avatar_url":"https://avatars0.githubusercontent.com/u/2329102?v=4","gravatar_id":"","url":"https://api.github.com/users/galiak11","html_url":"https://github.com/galiak11","followers_url":"https://api.github.com/users/galiak11/followers","following_url":"https://api.github.com/users/galiak11/following{/other_user}","gists_url":"https://api.github.com/users/galiak11/gists{/gist_id}","starred_url":"https://api.github.com/users/galiak11/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/galiak11/subscriptions","organizations_url":"https://api.github.com/users/galiak11/orgs","repos_url":"https://api.github.com/users/galiak11/repos","events_url":"https://api.github.com/users/galiak11/events{/privacy}","received_events_url":"https://api.github.com/users/galiak11/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/galiak11/material-components-ios","description":"Modular and customizable Material Design UI components for iOS","fork":true,"url":"https://api.github.com/repos/galiak11/material-components-ios","forks_url":"https://api.github.com/repos/galiak11/material-components-ios/forks","keys_url":"https://api.github.com/repos/galiak11/material-components-ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/galiak11/material-components-ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/galiak11/material-components-ios/teams","hooks_url":"https://api.github.com/repos/galiak11/material-components-ios/hooks","issue_events_url":"https://api.github.com/repos/galiak11/material-components-ios/issues/events{/number}","events_url":"https://api.github.com/repos/galiak11/material-components-ios/events","assignees_url":"https://api.github.com/repos/galiak11/material-components-ios/assignees{/user}","branches_url":"https://api.github.com/repos/galiak11/material-components-ios/branches{/branch}","tags_url":"https://api.github.com/repos/galiak11/material-components-ios/tags","blobs_url":"https://api.github.com/repos/galiak11/material-components-ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/galiak11/material-components-ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/galiak11/material-components-ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/galiak11/material-components-ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/galiak11/material-components-ios/statuses/{sha}","languages_url":"https://api.github.com/repos/galiak11/material-components-ios/languages","stargazers_url":"https://api.github.com/repos/galiak11/material-components-ios/stargazers","contributors_url":"https://api.github.com/repos/galiak11/material-components-ios/contributors","subscribers_url":"https://api.github.com/repos/galiak11/material-components-ios/subscribers","subscription_url":"https://api.github.com/repos/galiak11/material-components-ios/subscription","commits_url":"https://api.github.com/repos/galiak11/material-components-ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/galiak11/material-components-ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/galiak11/material-components-ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/galiak11/material-components-ios/issues/comments{/number}","contents_url":"https://api.github.com/repos/galiak11/material-components-ios/contents/{+path}","compare_url":"https://api.github.com/repos/galiak11/material-components-ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/galiak11/material-components-ios/merges","archive_url":"https://api.github.com/repos/galiak11/material-components-ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/galiak11/material-components-ios/downloads","issues_url":"https://api.github.com/repos/galiak11/material-components-ios/issues{/number}","pulls_url":"https://api.github.com/repos/galiak11/material-components-ios/pulls{/number}","milestones_url":"https://api.github.com/repos/galiak11/material-components-ios/milestones{/number}","notifications_url":"https://api.github.com/repos/galiak11/material-components-ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/galiak11/material-components-ios/labels{/name}","releases_url":"https://api.github.com/repos/galiak11/material-components-ios/releases{/id}","deployments_url":"https://api.github.com/repos/galiak11/material-components-ios/deployments","created_at":"2018-06-15T20:09:08Z","updated_at":"2018-07-25T15:29:13Z","pushed_at":"2018-07-25T15:46:01Z","git_url":"git://github.com/galiak11/material-components-ios.git","ssh_url":"[email protected]:galiak11/material-components-ios.git","clone_url":"https://github.com/galiak11/material-components-ios.git","svn_url":"https://github.com/galiak11/material-components-ios","homepage":"","size":165324,"stargazers_count":0,"watchers_count":0,"language":"Objective-C","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"material-components:develop","ref":"develop","sha":"87496292fff9a73ca671ab63939fcc2ed665fe34","user":{"login":"material-components","id":19478152,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NDc4MTUy","avatar_url":"https://avatars3.githubusercontent.com/u/19478152?v=4","gravatar_id":"","url":"https://api.github.com/users/material-components","html_url":"https://github.com/material-components","followers_url":"https://api.github.com/users/material-components/followers","following_url":"https://api.github.com/users/material-components/following{/other_user}","gists_url":"https://api.github.com/users/material-components/gists{/gist_id}","starred_url":"https://api.github.com/users/material-components/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/material-components/subscriptions","organizations_url":"https://api.github.com/users/material-components/orgs","repos_url":"https://api.github.com/users/material-components/repos","events_url":"https://api.github.com/users/material-components/events{/privacy}","received_events_url":"https://api.github.com/users/material-components/received_events","type":"Organization","site_admin":false},"repo":{"id":43820219,"node_id":"MDEwOlJlcG9zaXRvcnk0MzgyMDIxOQ==","name":"material-components-ios","full_name":"material-components/material-components-ios","owner":{"login":"material-components","id":19478152,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NDc4MTUy","avatar_url":"https://avatars3.githubusercontent.com/u/19478152?v=4","gravatar_id":"","url":"https://api.github.com/users/material-components","html_url":"https://github.com/material-components","followers_url":"https://api.github.com/users/material-components/followers","following_url":"https://api.github.com/users/material-components/following{/other_user}","gists_url":"https://api.github.com/users/material-components/gists{/gist_id}","starred_url":"https://api.github.com/users/material-components/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/material-components/subscriptions","organizations_url":"https://api.github.com/users/material-components/orgs","repos_url":"https://api.github.com/users/material-components/repos","events_url":"https://api.github.com/users/material-components/events{/privacy}","received_events_url":"https://api.github.com/users/material-components/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/material-components/material-components-ios","description":"Modular and customizable Material Design UI components for iOS","fork":false,"url":"https://api.github.com/repos/material-components/material-components-ios","forks_url":"https://api.github.com/repos/material-components/material-components-ios/forks","keys_url":"https://api.github.com/repos/material-components/material-components-ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/material-components/material-components-ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/material-components/material-components-ios/teams","hooks_url":"https://api.github.com/repos/material-components/material-components-ios/hooks","issue_events_url":"https://api.github.com/repos/material-components/material-components-ios/issues/events{/number}","events_url":"https://api.github.com/repos/material-components/material-components-ios/events","assignees_url":"https://api.github.com/repos/material-components/material-components-ios/assignees{/user}","branches_url":"https://api.github.com/repos/material-components/material-components-ios/branches{/branch}","tags_url":"https://api.github.com/repos/material-components/material-components-ios/tags","blobs_url":"https://api.github.com/repos/material-components/material-components-ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/material-components/material-components-ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/material-components/material-components-ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/material-components/material-components-ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/material-components/material-components-ios/statuses/{sha}","languages_url":"https://api.github.com/repos/material-components/material-components-ios/languages","stargazers_url":"https://api.github.com/repos/material-components/material-components-ios/stargazers","contributors_url":"https://api.github.com/repos/material-components/material-components-ios/contributors","subscribers_url":"https://api.github.com/repos/material-components/material-components-ios/subscribers","subscription_url":"https://api.github.com/repos/material-components/material-components-ios/subscription","commits_url":"https://api.github.com/repos/material-components/material-components-ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/material-components/material-components-ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/material-components/material-components-ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/material-components/material-components-ios/issues/comments{/number}","contents_url":"https://api.github.com/repos/material-components/material-components-ios/contents/{+path}","compare_url":"https://api.github.com/repos/material-components/material-components-ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/material-components/material-components-ios/merges","archive_url":"https://api.github.com/repos/material-components/material-components-ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/material-components/material-components-ios/downloads","issues_url":"https://api.github.com/repos/material-components/material-components-ios/issues{/number}","pulls_url":"https://api.github.com/repos/material-components/material-components-ios/pulls{/number}","milestones_url":"https://api.github.com/repos/material-components/material-components-ios/milestones{/number}","notifications_url":"https://api.github.com/repos/material-components/material-components-ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/material-components/material-components-ios/labels{/name}","releases_url":"https://api.github.com/repos/material-components/material-components-ios/releases{/id}","deployments_url":"https://api.github.com/repos/material-components/material-components-ios/deployments","created_at":"2015-10-07T14:12:39Z","updated_at":"2018-07-25T14:55:44Z","pushed_at":"2018-07-25T16:15:39Z","git_url":"git://github.com/material-components/material-components-ios.git","ssh_url":"[email protected]:material-components/material-components-ios.git","clone_url":"https://github.com/material-components/material-components-ios.git","svn_url":"https://github.com/material-components/material-components-ios","homepage":"","size":115167,"stargazers_count":2588,"watchers_count":2588,"language":"Objective-C","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":377,"mirror_url":null,"archived":false,"open_issues_count":999,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":377,"open_issues":999,"watchers":2588,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/material-components/material-components-ios/pulls/4634"},"html":{"href":"https://github.com/material-components/material-components-ios/pull/4634"},"issue":{"href":"https://api.github.com/repos/material-components/material-components-ios/issues/4634"},"comments":{"href":"https://api.github.com/repos/material-components/material-components-ios/issues/4634/comments"},"review_comments":{"href":"https://api.github.com/repos/material-components/material-components-ios/pulls/4634/comments"},"review_comment":{"href":"https://api.github.com/repos/material-components/material-components-ios/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/material-components/material-components-ios/pulls/4634/commits"},"statuses":{"href":"https://api.github.com/repos/material-components/material-components-ios/statuses/407acabaa7d5a3d45dfeed83596c007e18dccd7c"}},"author_association":"CONTRIBUTOR"}} | {
"id": 43820219,
"name": "material-components/material-components-ios",
"url": "https://api.github.com/repos/material-components/material-components-ios"
} | {
"id": 1753199,
"login": "romoore",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1753199?",
"url": "https://api.github.com/users/romoore"
} | {
"id": 19478152,
"login": "material-components",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/19478152?",
"url": "https://api.github.com/orgs/material-components"
} | 2018-07-25T16:17:32 | 8017580197 | {"actor":{"display_login":"romoore"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/apigee/apigee-edge-drupal/pulls/comments/229186009","pull_request_review_id":169623934,"id":229186009,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyOTE4NjAwOQ==","diff_hunk":"@@ -0,0 +1,11 @@\n+name: Apigee Edge Test Module","path":"tests/modules/apigee_mock_client/apigee_mock_client.info.yml","position":1,"original_position":1,"commit_id":"7d37982edb0f00b3cb3e1e90c7b41c981ccf1358","original_commit_id":"7d37982edb0f00b3cb3e1e90c7b41c981ccf1358","user":{"login":"mxr576","id":1755573,"node_id":"MDQ6VXNlcjE3NTU1NzM=","avatar_url":"https://avatars2.githubusercontent.com/u/1755573?v=4","gravatar_id":"","url":"https://api.github.com/users/mxr576","html_url":"https://github.com/mxr576","followers_url":"https://api.github.com/users/mxr576/followers","following_url":"https://api.github.com/users/mxr576/following{/other_user}","gists_url":"https://api.github.com/users/mxr576/gists{/gist_id}","starred_url":"https://api.github.com/users/mxr576/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mxr576/subscriptions","organizations_url":"https://api.github.com/users/mxr576/orgs","repos_url":"https://api.github.com/users/mxr576/repos","events_url":"https://api.github.com/users/mxr576/events{/privacy}","received_events_url":"https://api.github.com/users/mxr576/received_events","type":"User","site_admin":false},"body":"Module's (display) name should be more unique.","created_at":"2018-10-30T06:14:36Z","updated_at":"2018-10-30T06:42:35Z","html_url":"https://github.com/apigee/apigee-edge-drupal/pull/79#discussion_r229186009","pull_request_url":"https://api.github.com/repos/apigee/apigee-edge-drupal/pulls/79","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/apigee/apigee-edge-drupal/pulls/comments/229186009"},"html":{"href":"https://github.com/apigee/apigee-edge-drupal/pull/79#discussion_r229186009"},"pull_request":{"href":"https://api.github.com/repos/apigee/apigee-edge-drupal/pulls/79"}}},"pull_request":{"url":"https://api.github.com/repos/apigee/apigee-edge-drupal/pulls/79","id":224770747,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI0NzcwNzQ3","html_url":"https://github.com/apigee/apigee-edge-drupal/pull/79","diff_url":"https://github.com/apigee/apigee-edge-drupal/pull/79.diff","patch_url":"https://github.com/apigee/apigee-edge-drupal/pull/79.patch","issue_url":"https://api.github.com/repos/apigee/apigee-edge-drupal/issues/79","number":79,"state":"open","locked":false,"title":"Move mock client testing sub-module from Monetization to Edge","user":{"login":"void--","id":7862702,"node_id":"MDQ6VXNlcjc4NjI3MDI=","avatar_url":"https://avatars1.githubusercontent.com/u/7862702?v=4","gravatar_id":"","url":"https://api.github.com/users/void--","html_url":"https://github.com/void--","followers_url":"https://api.github.com/users/void--/followers","following_url":"https://api.github.com/users/void--/following{/other_user}","gists_url":"https://api.github.com/users/void--/gists{/gist_id}","starred_url":"https://api.github.com/users/void--/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/void--/subscriptions","organizations_url":"https://api.github.com/users/void--/orgs","repos_url":"https://api.github.com/users/void--/repos","events_url":"https://api.github.com/users/void--/events{/privacy}","received_events_url":"https://api.github.com/users/void--/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-10-22T18:31:01Z","updated_at":"2018-10-30T06:42:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"04a1f3bdd94f1690087fc5c5ea47113203d4d0d6","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apigee/apigee-edge-drupal/pulls/79/commits","review_comments_url":"https://api.github.com/repos/apigee/apigee-edge-drupal/pulls/79/comments","review_comment_url":"https://api.github.com/repos/apigee/apigee-edge-drupal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apigee/apigee-edge-drupal/issues/79/comments","statuses_url":"https://api.github.com/repos/apigee/apigee-edge-drupal/statuses/7d37982edb0f00b3cb3e1e90c7b41c981ccf1358","head":{"label":"void--:8.x-1.x","ref":"8.x-1.x","sha":"7d37982edb0f00b3cb3e1e90c7b41c981ccf1358","user":{"login":"void--","id":7862702,"node_id":"MDQ6VXNlcjc4NjI3MDI=","avatar_url":"https://avatars1.githubusercontent.com/u/7862702?v=4","gravatar_id":"","url":"https://api.github.com/users/void--","html_url":"https://github.com/void--","followers_url":"https://api.github.com/users/void--/followers","following_url":"https://api.github.com/users/void--/following{/other_user}","gists_url":"https://api.github.com/users/void--/gists{/gist_id}","starred_url":"https://api.github.com/users/void--/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/void--/subscriptions","organizations_url":"https://api.github.com/users/void--/orgs","repos_url":"https://api.github.com/users/void--/repos","events_url":"https://api.github.com/users/void--/events{/privacy}","received_events_url":"https://api.github.com/users/void--/received_events","type":"User","site_admin":false},"repo":{"id":153706500,"node_id":"MDEwOlJlcG9zaXRvcnkxNTM3MDY1MDA=","name":"apigee-edge-drupal","full_name":"void--/apigee-edge-drupal","private":false,"owner":{"login":"void--","id":7862702,"node_id":"MDQ6VXNlcjc4NjI3MDI=","avatar_url":"https://avatars1.githubusercontent.com/u/7862702?v=4","gravatar_id":"","url":"https://api.github.com/users/void--","html_url":"https://github.com/void--","followers_url":"https://api.github.com/users/void--/followers","following_url":"https://api.github.com/users/void--/following{/other_user}","gists_url":"https://api.github.com/users/void--/gists{/gist_id}","starred_url":"https://api.github.com/users/void--/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/void--/subscriptions","organizations_url":"https://api.github.com/users/void--/orgs","repos_url":"https://api.github.com/users/void--/repos","events_url":"https://api.github.com/users/void--/events{/privacy}","received_events_url":"https://api.github.com/users/void--/received_events","type":"User","site_admin":false},"html_url":"https://github.com/void--/apigee-edge-drupal","description":"The Apigee Edge module enables you to integrate a Drupal 8 with Apigee Edge.","fork":true,"url":"https://api.github.com/repos/void--/apigee-edge-drupal","forks_url":"https://api.github.com/repos/void--/apigee-edge-drupal/forks","keys_url":"https://api.github.com/repos/void--/apigee-edge-drupal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/void--/apigee-edge-drupal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/void--/apigee-edge-drupal/teams","hooks_url":"https://api.github.com/repos/void--/apigee-edge-drupal/hooks","issue_events_url":"https://api.github.com/repos/void--/apigee-edge-drupal/issues/events{/number}","events_url":"https://api.github.com/repos/void--/apigee-edge-drupal/events","assignees_url":"https://api.github.com/repos/void--/apigee-edge-drupal/assignees{/user}","branches_url":"https://api.github.com/repos/void--/apigee-edge-drupal/branches{/branch}","tags_url":"https://api.github.com/repos/void--/apigee-edge-drupal/tags","blobs_url":"https://api.github.com/repos/void--/apigee-edge-drupal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/void--/apigee-edge-drupal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/void--/apigee-edge-drupal/git/refs{/sha}","trees_url":"https://api.github.com/repos/void--/apigee-edge-drupal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/void--/apigee-edge-drupal/statuses/{sha}","languages_url":"https://api.github.com/repos/void--/apigee-edge-drupal/languages","stargazers_url":"https://api.github.com/repos/void--/apigee-edge-drupal/stargazers","contributors_url":"https://api.github.com/repos/void--/apigee-edge-drupal/contributors","subscribers_url":"https://api.github.com/repos/void--/apigee-edge-drupal/subscribers","subscription_url":"https://api.github.com/repos/void--/apigee-edge-drupal/subscription","commits_url":"https://api.github.com/repos/void--/apigee-edge-drupal/commits{/sha}","git_commits_url":"https://api.github.com/repos/void--/apigee-edge-drupal/git/commits{/sha}","comments_url":"https://api.github.com/repos/void--/apigee-edge-drupal/comments{/number}","issue_comment_url":"https://api.github.com/repos/void--/apigee-edge-drupal/issues/comments{/number}","contents_url":"https://api.github.com/repos/void--/apigee-edge-drupal/contents/{+path}","compare_url":"https://api.github.com/repos/void--/apigee-edge-drupal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/void--/apigee-edge-drupal/merges","archive_url":"https://api.github.com/repos/void--/apigee-edge-drupal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/void--/apigee-edge-drupal/downloads","issues_url":"https://api.github.com/repos/void--/apigee-edge-drupal/issues{/number}","pulls_url":"https://api.github.com/repos/void--/apigee-edge-drupal/pulls{/number}","milestones_url":"https://api.github.com/repos/void--/apigee-edge-drupal/milestones{/number}","notifications_url":"https://api.github.com/repos/void--/apigee-edge-drupal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/void--/apigee-edge-drupal/labels{/name}","releases_url":"https://api.github.com/repos/void--/apigee-edge-drupal/releases{/id}","deployments_url":"https://api.github.com/repos/void--/apigee-edge-drupal/deployments","created_at":"2018-10-19T00:57:17Z","updated_at":"2018-10-22T18:29:06Z","pushed_at":"2018-10-29T16:59:37Z","git_url":"git://github.com/void--/apigee-edge-drupal.git","ssh_url":"[email protected]:void--/apigee-edge-drupal.git","clone_url":"https://github.com/void--/apigee-edge-drupal.git","svn_url":"https://github.com/void--/apigee-edge-drupal","homepage":"","size":1688,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"8.x-1.x"}},"base":{"label":"apigee:8.x-1.x","ref":"8.x-1.x","sha":"ec0734043de096244c31070ed7a4583304b2abf6","user":{"login":"apigee","id":19557821,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NTU3ODIx","avatar_url":"https://avatars0.githubusercontent.com/u/19557821?v=4","gravatar_id":"","url":"https://api.github.com/users/apigee","html_url":"https://github.com/apigee","followers_url":"https://api.github.com/users/apigee/followers","following_url":"https://api.github.com/users/apigee/following{/other_user}","gists_url":"https://api.github.com/users/apigee/gists{/gist_id}","starred_url":"https://api.github.com/users/apigee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apigee/subscriptions","organizations_url":"https://api.github.com/users/apigee/orgs","repos_url":"https://api.github.com/users/apigee/repos","events_url":"https://api.github.com/users/apigee/events{/privacy}","received_events_url":"https://api.github.com/users/apigee/received_events","type":"Organization","site_admin":false},"repo":{"id":130411545,"node_id":"MDEwOlJlcG9zaXRvcnkxMzA0MTE1NDU=","name":"apigee-edge-drupal","full_name":"apigee/apigee-edge-drupal","private":false,"owner":{"login":"apigee","id":19557821,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NTU3ODIx","avatar_url":"https://avatars0.githubusercontent.com/u/19557821?v=4","gravatar_id":"","url":"https://api.github.com/users/apigee","html_url":"https://github.com/apigee","followers_url":"https://api.github.com/users/apigee/followers","following_url":"https://api.github.com/users/apigee/following{/other_user}","gists_url":"https://api.github.com/users/apigee/gists{/gist_id}","starred_url":"https://api.github.com/users/apigee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apigee/subscriptions","organizations_url":"https://api.github.com/users/apigee/orgs","repos_url":"https://api.github.com/users/apigee/repos","events_url":"https://api.github.com/users/apigee/events{/privacy}","received_events_url":"https://api.github.com/users/apigee/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apigee/apigee-edge-drupal","description":"The Apigee Edge module enables you to integrate a Drupal 8 with Apigee Edge.","fork":false,"url":"https://api.github.com/repos/apigee/apigee-edge-drupal","forks_url":"https://api.github.com/repos/apigee/apigee-edge-drupal/forks","keys_url":"https://api.github.com/repos/apigee/apigee-edge-drupal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apigee/apigee-edge-drupal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apigee/apigee-edge-drupal/teams","hooks_url":"https://api.github.com/repos/apigee/apigee-edge-drupal/hooks","issue_events_url":"https://api.github.com/repos/apigee/apigee-edge-drupal/issues/events{/number}","events_url":"https://api.github.com/repos/apigee/apigee-edge-drupal/events","assignees_url":"https://api.github.com/repos/apigee/apigee-edge-drupal/assignees{/user}","branches_url":"https://api.github.com/repos/apigee/apigee-edge-drupal/branches{/branch}","tags_url":"https://api.github.com/repos/apigee/apigee-edge-drupal/tags","blobs_url":"https://api.github.com/repos/apigee/apigee-edge-drupal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apigee/apigee-edge-drupal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apigee/apigee-edge-drupal/git/refs{/sha}","trees_url":"https://api.github.com/repos/apigee/apigee-edge-drupal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apigee/apigee-edge-drupal/statuses/{sha}","languages_url":"https://api.github.com/repos/apigee/apigee-edge-drupal/languages","stargazers_url":"https://api.github.com/repos/apigee/apigee-edge-drupal/stargazers","contributors_url":"https://api.github.com/repos/apigee/apigee-edge-drupal/contributors","subscribers_url":"https://api.github.com/repos/apigee/apigee-edge-drupal/subscribers","subscription_url":"https://api.github.com/repos/apigee/apigee-edge-drupal/subscription","commits_url":"https://api.github.com/repos/apigee/apigee-edge-drupal/commits{/sha}","git_commits_url":"https://api.github.com/repos/apigee/apigee-edge-drupal/git/commits{/sha}","comments_url":"https://api.github.com/repos/apigee/apigee-edge-drupal/comments{/number}","issue_comment_url":"https://api.github.com/repos/apigee/apigee-edge-drupal/issues/comments{/number}","contents_url":"https://api.github.com/repos/apigee/apigee-edge-drupal/contents/{+path}","compare_url":"https://api.github.com/repos/apigee/apigee-edge-drupal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apigee/apigee-edge-drupal/merges","archive_url":"https://api.github.com/repos/apigee/apigee-edge-drupal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apigee/apigee-edge-drupal/downloads","issues_url":"https://api.github.com/repos/apigee/apigee-edge-drupal/issues{/number}","pulls_url":"https://api.github.com/repos/apigee/apigee-edge-drupal/pulls{/number}","milestones_url":"https://api.github.com/repos/apigee/apigee-edge-drupal/milestones{/number}","notifications_url":"https://api.github.com/repos/apigee/apigee-edge-drupal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apigee/apigee-edge-drupal/labels{/name}","releases_url":"https://api.github.com/repos/apigee/apigee-edge-drupal/releases{/id}","deployments_url":"https://api.github.com/repos/apigee/apigee-edge-drupal/deployments","created_at":"2018-04-20T20:36:23Z","updated_at":"2018-10-19T15:52:05Z","pushed_at":"2018-10-25T02:54:00Z","git_url":"git://github.com/apigee/apigee-edge-drupal.git","ssh_url":"[email protected]:apigee/apigee-edge-drupal.git","clone_url":"https://github.com/apigee/apigee-edge-drupal.git","svn_url":"https://github.com/apigee/apigee-edge-drupal","homepage":"https://www.drupal.org/project/apigee_edge","size":1728,"stargazers_count":3,"watchers_count":3,"language":"PHP","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":8,"open_issues":6,"watchers":3,"default_branch":"8.x-1.x"}},"_links":{"self":{"href":"https://api.github.com/repos/apigee/apigee-edge-drupal/pulls/79"},"html":{"href":"https://github.com/apigee/apigee-edge-drupal/pull/79"},"issue":{"href":"https://api.github.com/repos/apigee/apigee-edge-drupal/issues/79"},"comments":{"href":"https://api.github.com/repos/apigee/apigee-edge-drupal/issues/79/comments"},"review_comments":{"href":"https://api.github.com/repos/apigee/apigee-edge-drupal/pulls/79/comments"},"review_comment":{"href":"https://api.github.com/repos/apigee/apigee-edge-drupal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apigee/apigee-edge-drupal/pulls/79/commits"},"statuses":{"href":"https://api.github.com/repos/apigee/apigee-edge-drupal/statuses/7d37982edb0f00b3cb3e1e90c7b41c981ccf1358"}},"author_association":"NONE"}} | {
"id": 130411545,
"name": "apigee/apigee-edge-drupal",
"url": "https://api.github.com/repos/apigee/apigee-edge-drupal"
} | {
"id": 1755573,
"login": "mxr576",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1755573?",
"url": "https://api.github.com/users/mxr576"
} | {
"id": 19557821,
"login": "apigee",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/19557821?",
"url": "https://api.github.com/orgs/apigee"
} | 2018-10-30T06:14:36 | 8502860922 | {"actor":{"display_login":"mxr576"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/comments/229717657","pull_request_review_id":170282238,"id":229717657,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyOTcxNzY1Nw==","diff_hunk":"@@ -28,6 +29,144 @@ extern \"C\" {\n \n #include <device.h>\n \n+/**\n+ * @brief UART controller configuration structure\n+ *\n+ * @note Used for UART high level API\n+ *\n+ * @param baudrate Baudrate setting.\n+ * @param rx_timeout RX timeout in ms.\n+ * @param flags Bit field with following parts:\n+ *\n+ * parity [ 0 : 2 ] - Parity bits.\n+ * stop_bits [ 3 : 4 ] - Stop bits.\n+ * data_bits [ 5 : 7 ] - Data bits.\n+ * flow_ctrl [ 8 : 9 ] - Flow control setting.\n+ */\n+struct uart_config {\n+\tu32_t baudrate;\n+\tu32_t rx_timeout;\n+\tu32_t flags;","path":"include/uart.h","position":27,"original_position":27,"commit_id":"8e849c8b411b044b8ecbc8107a310f23b4cdf5ec","original_commit_id":"8e849c8b411b044b8ecbc8107a310f23b4cdf5ec","user":{"login":"galak","id":16417047,"node_id":"MDQ6VXNlcjE2NDE3MDQ3","avatar_url":"https://avatars2.githubusercontent.com/u/16417047?v=4","gravatar_id":"","url":"https://api.github.com/users/galak","html_url":"https://github.com/galak","followers_url":"https://api.github.com/users/galak/followers","following_url":"https://api.github.com/users/galak/following{/other_user}","gists_url":"https://api.github.com/users/galak/gists{/gist_id}","starred_url":"https://api.github.com/users/galak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/galak/subscriptions","organizations_url":"https://api.github.com/users/galak/orgs","repos_url":"https://api.github.com/users/galak/repos","events_url":"https://api.github.com/users/galak/events{/privacy}","received_events_url":"https://api.github.com/users/galak/received_events","type":"User","site_admin":false},"body":"Is the savings really worth it? We're probably adding code size to do shift and masks vs just being able to directly access the variable. Also, I feels like the shift/mask is error prone to the driver developer from a security point of view. (I feel like I've seen over and over again coverity reporting simliar issues in GPIO drivers related to some bit masks there).","created_at":"2018-10-31T14:30:05Z","updated_at":"2018-10-31T14:30:06Z","html_url":"https://github.com/zephyrproject-rtos/zephyr/pull/10820#discussion_r229717657","pull_request_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/10820","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/comments/229717657"},"html":{"href":"https://github.com/zephyrproject-rtos/zephyr/pull/10820#discussion_r229717657"},"pull_request":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/10820"}},"in_reply_to_id":229398189},"pull_request":{"url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/10820","id":225382738,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1MzgyNzM4","html_url":"https://github.com/zephyrproject-rtos/zephyr/pull/10820","diff_url":"https://github.com/zephyrproject-rtos/zephyr/pull/10820.diff","patch_url":"https://github.com/zephyrproject-rtos/zephyr/pull/10820.patch","issue_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/10820","number":10820,"state":"open","locked":false,"title":"[RFC] api: uart: Add new high level UART API.","user":{"login":"Mierunski","id":19541298,"node_id":"MDQ6VXNlcjE5NTQxMjk4","avatar_url":"https://avatars0.githubusercontent.com/u/19541298?v=4","gravatar_id":"","url":"https://api.github.com/users/Mierunski","html_url":"https://github.com/Mierunski","followers_url":"https://api.github.com/users/Mierunski/followers","following_url":"https://api.github.com/users/Mierunski/following{/other_user}","gists_url":"https://api.github.com/users/Mierunski/gists{/gist_id}","starred_url":"https://api.github.com/users/Mierunski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mierunski/subscriptions","organizations_url":"https://api.github.com/users/Mierunski/orgs","repos_url":"https://api.github.com/users/Mierunski/repos","events_url":"https://api.github.com/users/Mierunski/events{/privacy}","received_events_url":"https://api.github.com/users/Mierunski/received_events","type":"User","site_admin":false},"body":"Added new UART API, that allows for longer transmissions, leaves IRQ handling on driver side and allows for DMA usage.\r\n\r\nAdded configuration option for setting like baudrate, stop bits, parity and data bits.\r\n\r\nThis PR is created as conclusion to #8243 #1682 #8306 #8307 #3457\r\n\r\nEventually this should become main API.\r\n\r\nLooking for comments, I will add example of shim implementation after feedback on current work.\r\n","created_at":"2018-10-24T12:29:07Z","updated_at":"2018-10-31T14:30:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9a63515f000ff5ada9e643270511c23b16571eb0","assignee":null,"assignees":[],"requested_reviewers":[{"login":"nashif","id":180017,"node_id":"MDQ6VXNlcjE4MDAxNw==","avatar_url":"https://avatars0.githubusercontent.com/u/180017?v=4","gravatar_id":"","url":"https://api.github.com/users/nashif","html_url":"https://github.com/nashif","followers_url":"https://api.github.com/users/nashif/followers","following_url":"https://api.github.com/users/nashif/following{/other_user}","gists_url":"https://api.github.com/users/nashif/gists{/gist_id}","starred_url":"https://api.github.com/users/nashif/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nashif/subscriptions","organizations_url":"https://api.github.com/users/nashif/orgs","repos_url":"https://api.github.com/users/nashif/repos","events_url":"https://api.github.com/users/nashif/events{/privacy}","received_events_url":"https://api.github.com/users/nashif/received_events","type":"User","site_admin":false},{"login":"kl-cruz","id":3696781,"node_id":"MDQ6VXNlcjM2OTY3ODE=","avatar_url":"https://avatars2.githubusercontent.com/u/3696781?v=4","gravatar_id":"","url":"https://api.github.com/users/kl-cruz","html_url":"https://github.com/kl-cruz","followers_url":"https://api.github.com/users/kl-cruz/followers","following_url":"https://api.github.com/users/kl-cruz/following{/other_user}","gists_url":"https://api.github.com/users/kl-cruz/gists{/gist_id}","starred_url":"https://api.github.com/users/kl-cruz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kl-cruz/subscriptions","organizations_url":"https://api.github.com/users/kl-cruz/orgs","repos_url":"https://api.github.com/users/kl-cruz/repos","events_url":"https://api.github.com/users/kl-cruz/events{/privacy}","received_events_url":"https://api.github.com/users/kl-cruz/received_events","type":"User","site_admin":false},{"login":"MaureenHelm","id":6172539,"node_id":"MDQ6VXNlcjYxNzI1Mzk=","avatar_url":"https://avatars2.githubusercontent.com/u/6172539?v=4","gravatar_id":"","url":"https://api.github.com/users/MaureenHelm","html_url":"https://github.com/MaureenHelm","followers_url":"https://api.github.com/users/MaureenHelm/followers","following_url":"https://api.github.com/users/MaureenHelm/following{/other_user}","gists_url":"https://api.github.com/users/MaureenHelm/gists{/gist_id}","starred_url":"https://api.github.com/users/MaureenHelm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaureenHelm/subscriptions","organizations_url":"https://api.github.com/users/MaureenHelm/orgs","repos_url":"https://api.github.com/users/MaureenHelm/repos","events_url":"https://api.github.com/users/MaureenHelm/events{/privacy}","received_events_url":"https://api.github.com/users/MaureenHelm/received_events","type":"User","site_admin":false},{"login":"carlescufi","id":12450381,"node_id":"MDQ6VXNlcjEyNDUwMzgx","avatar_url":"https://avatars3.githubusercontent.com/u/12450381?v=4","gravatar_id":"","url":"https://api.github.com/users/carlescufi","html_url":"https://github.com/carlescufi","followers_url":"https://api.github.com/users/carlescufi/followers","following_url":"https://api.github.com/users/carlescufi/following{/other_user}","gists_url":"https://api.github.com/users/carlescufi/gists{/gist_id}","starred_url":"https://api.github.com/users/carlescufi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carlescufi/subscriptions","organizations_url":"https://api.github.com/users/carlescufi/orgs","repos_url":"https://api.github.com/users/carlescufi/repos","events_url":"https://api.github.com/users/carlescufi/events{/privacy}","received_events_url":"https://api.github.com/users/carlescufi/received_events","type":"User","site_admin":false},{"login":"nordic-krch","id":16899589,"node_id":"MDQ6VXNlcjE2ODk5NTg5","avatar_url":"https://avatars3.githubusercontent.com/u/16899589?v=4","gravatar_id":"","url":"https://api.github.com/users/nordic-krch","html_url":"https://github.com/nordic-krch","followers_url":"https://api.github.com/users/nordic-krch/followers","following_url":"https://api.github.com/users/nordic-krch/following{/other_user}","gists_url":"https://api.github.com/users/nordic-krch/gists{/gist_id}","starred_url":"https://api.github.com/users/nordic-krch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nordic-krch/subscriptions","organizations_url":"https://api.github.com/users/nordic-krch/orgs","repos_url":"https://api.github.com/users/nordic-krch/repos","events_url":"https://api.github.com/users/nordic-krch/events{/privacy}","received_events_url":"https://api.github.com/users/nordic-krch/received_events","type":"User","site_admin":false},{"login":"anangl","id":16913290,"node_id":"MDQ6VXNlcjE2OTEzMjkw","avatar_url":"https://avatars3.githubusercontent.com/u/16913290?v=4","gravatar_id":"","url":"https://api.github.com/users/anangl","html_url":"https://github.com/anangl","followers_url":"https://api.github.com/users/anangl/followers","following_url":"https://api.github.com/users/anangl/following{/other_user}","gists_url":"https://api.github.com/users/anangl/gists{/gist_id}","starred_url":"https://api.github.com/users/anangl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anangl/subscriptions","organizations_url":"https://api.github.com/users/anangl/orgs","repos_url":"https://api.github.com/users/anangl/repos","events_url":"https://api.github.com/users/anangl/events{/privacy}","received_events_url":"https://api.github.com/users/anangl/received_events","type":"User","site_admin":false},{"login":"erwango","id":18574308,"node_id":"MDQ6VXNlcjE4NTc0MzA4","avatar_url":"https://avatars1.githubusercontent.com/u/18574308?v=4","gravatar_id":"","url":"https://api.github.com/users/erwango","html_url":"https://github.com/erwango","followers_url":"https://api.github.com/users/erwango/followers","following_url":"https://api.github.com/users/erwango/following{/other_user}","gists_url":"https://api.github.com/users/erwango/gists{/gist_id}","starred_url":"https://api.github.com/users/erwango/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erwango/subscriptions","organizations_url":"https://api.github.com/users/erwango/orgs","repos_url":"https://api.github.com/users/erwango/repos","events_url":"https://api.github.com/users/erwango/events{/privacy}","received_events_url":"https://api.github.com/users/erwango/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/10820/commits","review_comments_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/10820/comments","review_comment_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/10820/comments","statuses_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/statuses/8e849c8b411b044b8ecbc8107a310f23b4cdf5ec","head":{"label":"Mierunski:uart_high_level_api","ref":"uart_high_level_api","sha":"8e849c8b411b044b8ecbc8107a310f23b4cdf5ec","user":{"login":"Mierunski","id":19541298,"node_id":"MDQ6VXNlcjE5NTQxMjk4","avatar_url":"https://avatars0.githubusercontent.com/u/19541298?v=4","gravatar_id":"","url":"https://api.github.com/users/Mierunski","html_url":"https://github.com/Mierunski","followers_url":"https://api.github.com/users/Mierunski/followers","following_url":"https://api.github.com/users/Mierunski/following{/other_user}","gists_url":"https://api.github.com/users/Mierunski/gists{/gist_id}","starred_url":"https://api.github.com/users/Mierunski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mierunski/subscriptions","organizations_url":"https://api.github.com/users/Mierunski/orgs","repos_url":"https://api.github.com/users/Mierunski/repos","events_url":"https://api.github.com/users/Mierunski/events{/privacy}","received_events_url":"https://api.github.com/users/Mierunski/received_events","type":"User","site_admin":false},"repo":{"id":134420444,"node_id":"MDEwOlJlcG9zaXRvcnkxMzQ0MjA0NDQ=","name":"zephyr","full_name":"Mierunski/zephyr","private":false,"owner":{"login":"Mierunski","id":19541298,"node_id":"MDQ6VXNlcjE5NTQxMjk4","avatar_url":"https://avatars0.githubusercontent.com/u/19541298?v=4","gravatar_id":"","url":"https://api.github.com/users/Mierunski","html_url":"https://github.com/Mierunski","followers_url":"https://api.github.com/users/Mierunski/followers","following_url":"https://api.github.com/users/Mierunski/following{/other_user}","gists_url":"https://api.github.com/users/Mierunski/gists{/gist_id}","starred_url":"https://api.github.com/users/Mierunski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mierunski/subscriptions","organizations_url":"https://api.github.com/users/Mierunski/orgs","repos_url":"https://api.github.com/users/Mierunski/repos","events_url":"https://api.github.com/users/Mierunski/events{/privacy}","received_events_url":"https://api.github.com/users/Mierunski/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Mierunski/zephyr","description":"Primary GIT Repository for the Zephyr Project","fork":true,"url":"https://api.github.com/repos/Mierunski/zephyr","forks_url":"https://api.github.com/repos/Mierunski/zephyr/forks","keys_url":"https://api.github.com/repos/Mierunski/zephyr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Mierunski/zephyr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Mierunski/zephyr/teams","hooks_url":"https://api.github.com/repos/Mierunski/zephyr/hooks","issue_events_url":"https://api.github.com/repos/Mierunski/zephyr/issues/events{/number}","events_url":"https://api.github.com/repos/Mierunski/zephyr/events","assignees_url":"https://api.github.com/repos/Mierunski/zephyr/assignees{/user}","branches_url":"https://api.github.com/repos/Mierunski/zephyr/branches{/branch}","tags_url":"https://api.github.com/repos/Mierunski/zephyr/tags","blobs_url":"https://api.github.com/repos/Mierunski/zephyr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Mierunski/zephyr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Mierunski/zephyr/git/refs{/sha}","trees_url":"https://api.github.com/repos/Mierunski/zephyr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Mierunski/zephyr/statuses/{sha}","languages_url":"https://api.github.com/repos/Mierunski/zephyr/languages","stargazers_url":"https://api.github.com/repos/Mierunski/zephyr/stargazers","contributors_url":"https://api.github.com/repos/Mierunski/zephyr/contributors","subscribers_url":"https://api.github.com/repos/Mierunski/zephyr/subscribers","subscription_url":"https://api.github.com/repos/Mierunski/zephyr/subscription","commits_url":"https://api.github.com/repos/Mierunski/zephyr/commits{/sha}","git_commits_url":"https://api.github.com/repos/Mierunski/zephyr/git/commits{/sha}","comments_url":"https://api.github.com/repos/Mierunski/zephyr/comments{/number}","issue_comment_url":"https://api.github.com/repos/Mierunski/zephyr/issues/comments{/number}","contents_url":"https://api.github.com/repos/Mierunski/zephyr/contents/{+path}","compare_url":"https://api.github.com/repos/Mierunski/zephyr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Mierunski/zephyr/merges","archive_url":"https://api.github.com/repos/Mierunski/zephyr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Mierunski/zephyr/downloads","issues_url":"https://api.github.com/repos/Mierunski/zephyr/issues{/number}","pulls_url":"https://api.github.com/repos/Mierunski/zephyr/pulls{/number}","milestones_url":"https://api.github.com/repos/Mierunski/zephyr/milestones{/number}","notifications_url":"https://api.github.com/repos/Mierunski/zephyr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Mierunski/zephyr/labels{/name}","releases_url":"https://api.github.com/repos/Mierunski/zephyr/releases{/id}","deployments_url":"https://api.github.com/repos/Mierunski/zephyr/deployments","created_at":"2018-05-22T13:36:49Z","updated_at":"2018-05-22T13:37:30Z","pushed_at":"2018-10-30T15:03:13Z","git_url":"git://github.com/Mierunski/zephyr.git","ssh_url":"[email protected]:Mierunski/zephyr.git","clone_url":"https://github.com/Mierunski/zephyr.git","svn_url":"https://github.com/Mierunski/zephyr","homepage":"https://docs.zephyrproject.org","size":155397,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"zephyrproject-rtos:master","ref":"master","sha":"9f7e25ad227be17b1f48addc60b0f3d8b7618f04","user":{"login":"zephyrproject-rtos","id":19595895,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NTk1ODk1","avatar_url":"https://avatars2.githubusercontent.com/u/19595895?v=4","gravatar_id":"","url":"https://api.github.com/users/zephyrproject-rtos","html_url":"https://github.com/zephyrproject-rtos","followers_url":"https://api.github.com/users/zephyrproject-rtos/followers","following_url":"https://api.github.com/users/zephyrproject-rtos/following{/other_user}","gists_url":"https://api.github.com/users/zephyrproject-rtos/gists{/gist_id}","starred_url":"https://api.github.com/users/zephyrproject-rtos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zephyrproject-rtos/subscriptions","organizations_url":"https://api.github.com/users/zephyrproject-rtos/orgs","repos_url":"https://api.github.com/users/zephyrproject-rtos/repos","events_url":"https://api.github.com/users/zephyrproject-rtos/events{/privacy}","received_events_url":"https://api.github.com/users/zephyrproject-rtos/received_events","type":"Organization","site_admin":false},"repo":{"id":59771425,"node_id":"MDEwOlJlcG9zaXRvcnk1OTc3MTQyNQ==","name":"zephyr","full_name":"zephyrproject-rtos/zephyr","private":false,"owner":{"login":"zephyrproject-rtos","id":19595895,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NTk1ODk1","avatar_url":"https://avatars2.githubusercontent.com/u/19595895?v=4","gravatar_id":"","url":"https://api.github.com/users/zephyrproject-rtos","html_url":"https://github.com/zephyrproject-rtos","followers_url":"https://api.github.com/users/zephyrproject-rtos/followers","following_url":"https://api.github.com/users/zephyrproject-rtos/following{/other_user}","gists_url":"https://api.github.com/users/zephyrproject-rtos/gists{/gist_id}","starred_url":"https://api.github.com/users/zephyrproject-rtos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zephyrproject-rtos/subscriptions","organizations_url":"https://api.github.com/users/zephyrproject-rtos/orgs","repos_url":"https://api.github.com/users/zephyrproject-rtos/repos","events_url":"https://api.github.com/users/zephyrproject-rtos/events{/privacy}","received_events_url":"https://api.github.com/users/zephyrproject-rtos/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/zephyrproject-rtos/zephyr","description":"Primary GIT Repository for the Zephyr Project","fork":false,"url":"https://api.github.com/repos/zephyrproject-rtos/zephyr","forks_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/forks","keys_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/teams","hooks_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/hooks","issue_events_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/events{/number}","events_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/events","assignees_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/assignees{/user}","branches_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/branches{/branch}","tags_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/tags","blobs_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/git/refs{/sha}","trees_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/statuses/{sha}","languages_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/languages","stargazers_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/stargazers","contributors_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/contributors","subscribers_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/subscribers","subscription_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/subscription","commits_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/commits{/sha}","git_commits_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/git/commits{/sha}","comments_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/comments{/number}","issue_comment_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/comments{/number}","contents_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/contents/{+path}","compare_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/merges","archive_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/downloads","issues_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues{/number}","pulls_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls{/number}","milestones_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/milestones{/number}","notifications_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/labels{/name}","releases_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/releases{/id}","deployments_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/deployments","created_at":"2016-05-26T17:54:19Z","updated_at":"2018-10-31T14:12:09Z","pushed_at":"2018-10-31T14:25:37Z","git_url":"git://github.com/zephyrproject-rtos/zephyr.git","ssh_url":"[email protected]:zephyrproject-rtos/zephyr.git","clone_url":"https://github.com/zephyrproject-rtos/zephyr.git","svn_url":"https://github.com/zephyrproject-rtos/zephyr","homepage":"https://docs.zephyrproject.org","size":155995,"stargazers_count":1318,"watchers_count":1318,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":857,"mirror_url":null,"archived":false,"open_issues_count":1124,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":857,"open_issues":1124,"watchers":1318,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/10820"},"html":{"href":"https://github.com/zephyrproject-rtos/zephyr/pull/10820"},"issue":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/10820"},"comments":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/10820/comments"},"review_comments":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/10820/comments"},"review_comment":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/10820/commits"},"statuses":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/statuses/8e849c8b411b044b8ecbc8107a310f23b4cdf5ec"}},"author_association":"COLLABORATOR"}} | {
"id": 59771425,
"name": "zephyrproject-rtos/zephyr",
"url": "https://api.github.com/repos/zephyrproject-rtos/zephyr"
} | {
"id": 16417047,
"login": "galak",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/16417047?",
"url": "https://api.github.com/users/galak"
} | {
"id": 19595895,
"login": "zephyrproject-rtos",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/19595895?",
"url": "https://api.github.com/orgs/zephyrproject-rtos"
} | 2018-10-31T14:30:05 | 8512719204 | {"actor":{"display_login":"galak"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/comments/168900856","pull_request_review_id":97352147,"id":168900856,"diff_hunk":"@@ -0,0 +1,128 @@\n+/*\n+ * Copyright (c) 2018 Intel Corporation\n+ *\n+ * SPDX-License-Identifier: Apache-2.0\n+ */\n+\n+#include <kernel.h>\n+#include <pthread.h>\n+#include <errno.h>\n+\n+#ifndef _PTHREAD_SEMAPHORE_H\n+#define _PTHREAD_SEMAPHORE_H\n+\n+int sem_destroy(sem_t *semaphore)\n+{\n+\tif (k_sem_count_get(semaphore->sem) != 0) {\n+\t\terrno = EINVAL;\n+\t\treturn -1;\n+\t}\n+\n+\tk_sem_reset(semaphore->sem);\n+\n+\treturn 0;\n+}\n+\n+int sem_getvalue(sem_t *semaphore, int *value)\n+{\n+\t*value = (int) k_sem_count_get(semaphore->sem);\n+\n+\treturn 0;\n+}\n+\n+int sem_init(sem_t *semaphore, int pshared, unsigned int value)\n+{\n+\tif ((semaphore->sem->limit) == 0) {\n+\t\terrno = EINVAL;\n+\t\treturn -1;\n+\t}\n+\n+\t__ASSERT((pshared == 1) || (pshared == 0), \"not correct pshared\");\n+\n+\tk_sem_init(semaphore->sem, value, semaphore->sem->limit);\n+\n+\treturn 0;\n+}\n+\n+int sem_post(sem_t *semaphore)\n+{\n+\tif (semaphore->sem == 0) {","path":"kernel/posix/pthread_semaphore.c","position":49,"original_position":49,"commit_id":"e0a7215bb7c8e804af9244bc247e7cb860206c71","original_commit_id":"e0a7215bb7c8e804af9244bc247e7cb860206c71","user":{"login":"lpereira","id":15001,"avatar_url":"https://avatars1.githubusercontent.com/u/15001?v=4","gravatar_id":"","url":"https://api.github.com/users/lpereira","html_url":"https://github.com/lpereira","followers_url":"https://api.github.com/users/lpereira/followers","following_url":"https://api.github.com/users/lpereira/following{/other_user}","gists_url":"https://api.github.com/users/lpereira/gists{/gist_id}","starred_url":"https://api.github.com/users/lpereira/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lpereira/subscriptions","organizations_url":"https://api.github.com/users/lpereira/orgs","repos_url":"https://api.github.com/users/lpereira/repos","events_url":"https://api.github.com/users/lpereira/events{/privacy}","received_events_url":"https://api.github.com/users/lpereira/received_events","type":"User","site_admin":false},"body":"Why is a pointer being compared to `0`? Can this simply be a call to `k_sem_give()`?","created_at":"2018-02-17T00:15:32Z","updated_at":"2018-02-17T00:20:07Z","html_url":"https://github.com/zephyrproject-rtos/zephyr/pull/5532#discussion_r168900856","pull_request_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/5532","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/comments/168900856"},"html":{"href":"https://github.com/zephyrproject-rtos/zephyr/pull/5532#discussion_r168900856"},"pull_request":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/5532"}}},"pull_request":{"url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/5532","id":160678835,"html_url":"https://github.com/zephyrproject-rtos/zephyr/pull/5532","diff_url":"https://github.com/zephyrproject-rtos/zephyr/pull/5532.diff","patch_url":"https://github.com/zephyrproject-rtos/zephyr/pull/5532.patch","issue_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/5532","number":5532,"state":"open","locked":false,"title":"kernel: add POSIX API for semaphore","user":{"login":"punitvara","id":9531144,"avatar_url":"https://avatars3.githubusercontent.com/u/9531144?v=4","gravatar_id":"","url":"https://api.github.com/users/punitvara","html_url":"https://github.com/punitvara","followers_url":"https://api.github.com/users/punitvara/followers","following_url":"https://api.github.com/users/punitvara/following{/other_user}","gists_url":"https://api.github.com/users/punitvara/gists{/gist_id}","starred_url":"https://api.github.com/users/punitvara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/punitvara/subscriptions","organizations_url":"https://api.github.com/users/punitvara/orgs","repos_url":"https://api.github.com/users/punitvara/repos","events_url":"https://api.github.com/users/punitvara/events{/privacy}","received_events_url":"https://api.github.com/users/punitvara/received_events","type":"User","site_admin":false},"body":"Add POSIX APIs for semaphore\r\n\r\nSigned-off-by: Punit Vara <[email protected]>","created_at":"2018-01-02T06:06:38Z","updated_at":"2018-02-17T00:20:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"78d68078ac0ad4c31beb45201cffc278c56243a2","assignee":null,"assignees":[],"requested_reviewers":[{"login":"youvedeep","id":27796270,"avatar_url":"https://avatars0.githubusercontent.com/u/27796270?v=4","gravatar_id":"","url":"https://api.github.com/users/youvedeep","html_url":"https://github.com/youvedeep","followers_url":"https://api.github.com/users/youvedeep/followers","following_url":"https://api.github.com/users/youvedeep/following{/other_user}","gists_url":"https://api.github.com/users/youvedeep/gists{/gist_id}","starred_url":"https://api.github.com/users/youvedeep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/youvedeep/subscriptions","organizations_url":"https://api.github.com/users/youvedeep/orgs","repos_url":"https://api.github.com/users/youvedeep/repos","events_url":"https://api.github.com/users/youvedeep/events{/privacy}","received_events_url":"https://api.github.com/users/youvedeep/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/5532/commits","review_comments_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/5532/comments","review_comment_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/5532/comments","statuses_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/statuses/e0a7215bb7c8e804af9244bc247e7cb860206c71","head":{"label":"punitvara:sem_posix","ref":"sem_posix","sha":"e0a7215bb7c8e804af9244bc247e7cb860206c71","user":{"login":"punitvara","id":9531144,"avatar_url":"https://avatars3.githubusercontent.com/u/9531144?v=4","gravatar_id":"","url":"https://api.github.com/users/punitvara","html_url":"https://github.com/punitvara","followers_url":"https://api.github.com/users/punitvara/followers","following_url":"https://api.github.com/users/punitvara/following{/other_user}","gists_url":"https://api.github.com/users/punitvara/gists{/gist_id}","starred_url":"https://api.github.com/users/punitvara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/punitvara/subscriptions","organizations_url":"https://api.github.com/users/punitvara/orgs","repos_url":"https://api.github.com/users/punitvara/repos","events_url":"https://api.github.com/users/punitvara/events{/privacy}","received_events_url":"https://api.github.com/users/punitvara/received_events","type":"User","site_admin":false},"repo":{"id":77270338,"name":"zephyr","full_name":"punitvara/zephyr","owner":{"login":"punitvara","id":9531144,"avatar_url":"https://avatars3.githubusercontent.com/u/9531144?v=4","gravatar_id":"","url":"https://api.github.com/users/punitvara","html_url":"https://github.com/punitvara","followers_url":"https://api.github.com/users/punitvara/followers","following_url":"https://api.github.com/users/punitvara/following{/other_user}","gists_url":"https://api.github.com/users/punitvara/gists{/gist_id}","starred_url":"https://api.github.com/users/punitvara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/punitvara/subscriptions","organizations_url":"https://api.github.com/users/punitvara/orgs","repos_url":"https://api.github.com/users/punitvara/repos","events_url":"https://api.github.com/users/punitvara/events{/privacy}","received_events_url":"https://api.github.com/users/punitvara/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/punitvara/zephyr","description":"Mirror of the zephyr repo on https://gerrit.zephyrproject.org","fork":true,"url":"https://api.github.com/repos/punitvara/zephyr","forks_url":"https://api.github.com/repos/punitvara/zephyr/forks","keys_url":"https://api.github.com/repos/punitvara/zephyr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/punitvara/zephyr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/punitvara/zephyr/teams","hooks_url":"https://api.github.com/repos/punitvara/zephyr/hooks","issue_events_url":"https://api.github.com/repos/punitvara/zephyr/issues/events{/number}","events_url":"https://api.github.com/repos/punitvara/zephyr/events","assignees_url":"https://api.github.com/repos/punitvara/zephyr/assignees{/user}","branches_url":"https://api.github.com/repos/punitvara/zephyr/branches{/branch}","tags_url":"https://api.github.com/repos/punitvara/zephyr/tags","blobs_url":"https://api.github.com/repos/punitvara/zephyr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/punitvara/zephyr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/punitvara/zephyr/git/refs{/sha}","trees_url":"https://api.github.com/repos/punitvara/zephyr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/punitvara/zephyr/statuses/{sha}","languages_url":"https://api.github.com/repos/punitvara/zephyr/languages","stargazers_url":"https://api.github.com/repos/punitvara/zephyr/stargazers","contributors_url":"https://api.github.com/repos/punitvara/zephyr/contributors","subscribers_url":"https://api.github.com/repos/punitvara/zephyr/subscribers","subscription_url":"https://api.github.com/repos/punitvara/zephyr/subscription","commits_url":"https://api.github.com/repos/punitvara/zephyr/commits{/sha}","git_commits_url":"https://api.github.com/repos/punitvara/zephyr/git/commits{/sha}","comments_url":"https://api.github.com/repos/punitvara/zephyr/comments{/number}","issue_comment_url":"https://api.github.com/repos/punitvara/zephyr/issues/comments{/number}","contents_url":"https://api.github.com/repos/punitvara/zephyr/contents/{+path}","compare_url":"https://api.github.com/repos/punitvara/zephyr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/punitvara/zephyr/merges","archive_url":"https://api.github.com/repos/punitvara/zephyr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/punitvara/zephyr/downloads","issues_url":"https://api.github.com/repos/punitvara/zephyr/issues{/number}","pulls_url":"https://api.github.com/repos/punitvara/zephyr/pulls{/number}","milestones_url":"https://api.github.com/repos/punitvara/zephyr/milestones{/number}","notifications_url":"https://api.github.com/repos/punitvara/zephyr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/punitvara/zephyr/labels{/name}","releases_url":"https://api.github.com/repos/punitvara/zephyr/releases{/id}","deployments_url":"https://api.github.com/repos/punitvara/zephyr/deployments","created_at":"2016-12-24T06:49:54Z","updated_at":"2017-05-02T05:26:14Z","pushed_at":"2018-02-09T10:16:40Z","git_url":"git://github.com/punitvara/zephyr.git","ssh_url":"[email protected]:punitvara/zephyr.git","clone_url":"https://github.com/punitvara/zephyr.git","svn_url":"https://github.com/punitvara/zephyr","homepage":null,"size":99651,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"zephyrproject-rtos:master","ref":"master","sha":"aa8850b42a4745dbcc086359964ef385ca8ffc98","user":{"login":"zephyrproject-rtos","id":19595895,"avatar_url":"https://avatars2.githubusercontent.com/u/19595895?v=4","gravatar_id":"","url":"https://api.github.com/users/zephyrproject-rtos","html_url":"https://github.com/zephyrproject-rtos","followers_url":"https://api.github.com/users/zephyrproject-rtos/followers","following_url":"https://api.github.com/users/zephyrproject-rtos/following{/other_user}","gists_url":"https://api.github.com/users/zephyrproject-rtos/gists{/gist_id}","starred_url":"https://api.github.com/users/zephyrproject-rtos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zephyrproject-rtos/subscriptions","organizations_url":"https://api.github.com/users/zephyrproject-rtos/orgs","repos_url":"https://api.github.com/users/zephyrproject-rtos/repos","events_url":"https://api.github.com/users/zephyrproject-rtos/events{/privacy}","received_events_url":"https://api.github.com/users/zephyrproject-rtos/received_events","type":"Organization","site_admin":false},"repo":{"id":59771425,"name":"zephyr","full_name":"zephyrproject-rtos/zephyr","owner":{"login":"zephyrproject-rtos","id":19595895,"avatar_url":"https://avatars2.githubusercontent.com/u/19595895?v=4","gravatar_id":"","url":"https://api.github.com/users/zephyrproject-rtos","html_url":"https://github.com/zephyrproject-rtos","followers_url":"https://api.github.com/users/zephyrproject-rtos/followers","following_url":"https://api.github.com/users/zephyrproject-rtos/following{/other_user}","gists_url":"https://api.github.com/users/zephyrproject-rtos/gists{/gist_id}","starred_url":"https://api.github.com/users/zephyrproject-rtos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zephyrproject-rtos/subscriptions","organizations_url":"https://api.github.com/users/zephyrproject-rtos/orgs","repos_url":"https://api.github.com/users/zephyrproject-rtos/repos","events_url":"https://api.github.com/users/zephyrproject-rtos/events{/privacy}","received_events_url":"https://api.github.com/users/zephyrproject-rtos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zephyrproject-rtos/zephyr","description":"Primary GIT Repository for the Zephyr Project","fork":false,"url":"https://api.github.com/repos/zephyrproject-rtos/zephyr","forks_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/forks","keys_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/teams","hooks_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/hooks","issue_events_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/events{/number}","events_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/events","assignees_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/assignees{/user}","branches_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/branches{/branch}","tags_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/tags","blobs_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/git/refs{/sha}","trees_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/statuses/{sha}","languages_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/languages","stargazers_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/stargazers","contributors_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/contributors","subscribers_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/subscribers","subscription_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/subscription","commits_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/commits{/sha}","git_commits_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/git/commits{/sha}","comments_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/comments{/number}","issue_comment_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/comments{/number}","contents_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/contents/{+path}","compare_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/merges","archive_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/downloads","issues_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues{/number}","pulls_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls{/number}","milestones_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/milestones{/number}","notifications_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/labels{/name}","releases_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/releases{/id}","deployments_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/deployments","created_at":"2016-05-26T17:54:19Z","updated_at":"2018-02-16T20:21:55Z","pushed_at":"2018-02-16T23:20:35Z","git_url":"git://github.com/zephyrproject-rtos/zephyr.git","ssh_url":"[email protected]:zephyrproject-rtos/zephyr.git","clone_url":"https://github.com/zephyrproject-rtos/zephyr.git","svn_url":"https://github.com/zephyrproject-rtos/zephyr","homepage":"http://zephyrproject.org/doc","size":101573,"stargazers_count":647,"watchers_count":647,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":462,"mirror_url":null,"archived":false,"open_issues_count":766,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":462,"open_issues":766,"watchers":647,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/5532"},"html":{"href":"https://github.com/zephyrproject-rtos/zephyr/pull/5532"},"issue":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/5532"},"comments":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/5532/comments"},"review_comments":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/5532/comments"},"review_comment":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/5532/commits"},"statuses":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/statuses/e0a7215bb7c8e804af9244bc247e7cb860206c71"}},"author_association":"COLLABORATOR"}} | {
"id": 59771425,
"name": "zephyrproject-rtos/zephyr",
"url": "https://api.github.com/repos/zephyrproject-rtos/zephyr"
} | {
"id": 15001,
"login": "lpereira",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/15001?",
"url": "https://api.github.com/users/lpereira"
} | {
"id": 19595895,
"login": "zephyrproject-rtos",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/19595895?",
"url": "https://api.github.com/orgs/zephyrproject-rtos"
} | 2018-02-17T00:15:32 | 7257862830 | {"actor":{"display_login":"lpereira"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/comments/229456674","pull_request_review_id":169963069,"id":229456674,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyOTQ1NjY3NA==","diff_hunk":"@@ -27,6 +27,13 @@\n #define POINTER_TO_INT(x) ((s32_t) (x))\n #define INT_TO_POINTER(x) ((void *) (x))\n \n+#define BITS_PER_LONG\t(__CHAR_BIT__) * (__SIZEOF_LONG__)","path":"include/misc/util.h","position":4,"original_position":4,"commit_id":"6a4b7bf0799ada8bc48f343d881dfa6b9d88d451","original_commit_id":"6a4b7bf0799ada8bc48f343d881dfa6b9d88d451","user":{"login":"ulfalizer","id":154768,"node_id":"MDQ6VXNlcjE1NDc2OA==","avatar_url":"https://avatars2.githubusercontent.com/u/154768?v=4","gravatar_id":"","url":"https://api.github.com/users/ulfalizer","html_url":"https://github.com/ulfalizer","followers_url":"https://api.github.com/users/ulfalizer/followers","following_url":"https://api.github.com/users/ulfalizer/following{/other_user}","gists_url":"https://api.github.com/users/ulfalizer/gists{/gist_id}","starred_url":"https://api.github.com/users/ulfalizer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ulfalizer/subscriptions","organizations_url":"https://api.github.com/users/ulfalizer/orgs","repos_url":"https://api.github.com/users/ulfalizer/repos","events_url":"https://api.github.com/users/ulfalizer/events{/privacy}","received_events_url":"https://api.github.com/users/ulfalizer/received_events","type":"User","site_admin":false},"body":"Could make this\r\n\r\n```c\r\n#define BITS_PER_LONG (__CHAR_BIT__ * __SIZEOF__LONG__)\r\n```\r\n\r\nThat's what `tools/include/asm-generic/bitsperlong.h` does.\r\n\r\n`CHAR_BIT` could come from `limits.h`, to avoid `__CHAR_BIT__`, though it's probably safe to assume that one exists if the other does, and it saves a header.","created_at":"2018-10-30T19:39:13Z","updated_at":"2018-10-30T19:55:19Z","html_url":"https://github.com/zephyrproject-rtos/zephyr/pull/10944#discussion_r229456674","pull_request_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/10944","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/comments/229456674"},"html":{"href":"https://github.com/zephyrproject-rtos/zephyr/pull/10944#discussion_r229456674"},"pull_request":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/10944"}}},"pull_request":{"url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/10944","id":227034157,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3MDM0MTU3","html_url":"https://github.com/zephyrproject-rtos/zephyr/pull/10944","diff_url":"https://github.com/zephyrproject-rtos/zephyr/pull/10944.diff","patch_url":"https://github.com/zephyrproject-rtos/zephyr/pull/10944.patch","issue_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/10944","number":10944,"state":"open","locked":false,"title":"util: Add GENMASK helper macro definition","user":{"login":"himanshujha199640","id":33165596,"node_id":"MDQ6VXNlcjMzMTY1NTk2","avatar_url":"https://avatars2.githubusercontent.com/u/33165596?v=4","gravatar_id":"","url":"https://api.github.com/users/himanshujha199640","html_url":"https://github.com/himanshujha199640","followers_url":"https://api.github.com/users/himanshujha199640/followers","following_url":"https://api.github.com/users/himanshujha199640/following{/other_user}","gists_url":"https://api.github.com/users/himanshujha199640/gists{/gist_id}","starred_url":"https://api.github.com/users/himanshujha199640/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/himanshujha199640/subscriptions","organizations_url":"https://api.github.com/users/himanshujha199640/orgs","repos_url":"https://api.github.com/users/himanshujha199640/repos","events_url":"https://api.github.com/users/himanshujha199640/events{/privacy}","received_events_url":"https://api.github.com/users/himanshujha199640/received_events","type":"User","site_admin":false},"body":"Macro is used to create contiguous bitmask between the\r\narguments passed to the macro.\r\n\r\n`BITS_PER_LONG` is computed as the multiplication of predefined\r\nmacros `__CHAR_BIT__` and `__SIZEOF_LONG__`.\r\n\r\nBoth gcc and clang support these predefined macros.\r\n\r\nWith this change, replace the redundant defintions of\r\nGENMASK with the new generic macro available.\r\n\r\nFixes #10843\r\n\r\nSigned-off-by: Himanshu Jha <[email protected]>\r\n\r\nCc @ulfalizer \r\n\r\n```\r\nhimanshu@himanshu-Vostro-3559:~$ uname -a\r\nLinux himanshu-Vostro-3559 4.15.0-38-generic #41-Ubuntu SMP Wed Oct 10 10:59:38 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux\r\n\r\nhimanshu@himanshu-Vostro-3559:~$ clang -dM -E -x c /dev/null | grep -w '__SIZEOF_LONG__\\|__CHAR_BIT__'\r\n#define __CHAR_BIT__ 8\r\n#define __SIZEOF_LONG__ 8\r\n\r\nhimanshu@himanshu-Vostro-3559:~$ gcc -dM -E -x c /dev/null | grep -w '__SIZEOF_LONG__\\|__CHAR_BIT__'\r\n#define __CHAR_BIT__ 8\r\n#define __SIZEOF_LONG__ 8\r\n```","created_at":"2018-10-30T18:28:58Z","updated_at":"2018-10-30T19:55:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"11a02376add5e670c76b2e3892fcc023ee033b2c","assignee":null,"assignees":[],"requested_reviewers":[{"login":"andyross","id":300115,"node_id":"MDQ6VXNlcjMwMDExNQ==","avatar_url":"https://avatars1.githubusercontent.com/u/300115?v=4","gravatar_id":"","url":"https://api.github.com/users/andyross","html_url":"https://github.com/andyross","followers_url":"https://api.github.com/users/andyross/followers","following_url":"https://api.github.com/users/andyross/following{/other_user}","gists_url":"https://api.github.com/users/andyross/gists{/gist_id}","starred_url":"https://api.github.com/users/andyross/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andyross/subscriptions","organizations_url":"https://api.github.com/users/andyross/orgs","repos_url":"https://api.github.com/users/andyross/repos","events_url":"https://api.github.com/users/andyross/events{/privacy}","received_events_url":"https://api.github.com/users/andyross/received_events","type":"User","site_admin":false},{"login":"andrewboie","id":3387369,"node_id":"MDQ6VXNlcjMzODczNjk=","avatar_url":"https://avatars1.githubusercontent.com/u/3387369?v=4","gravatar_id":"","url":"https://api.github.com/users/andrewboie","html_url":"https://github.com/andrewboie","followers_url":"https://api.github.com/users/andrewboie/followers","following_url":"https://api.github.com/users/andrewboie/following{/other_user}","gists_url":"https://api.github.com/users/andrewboie/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewboie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewboie/subscriptions","organizations_url":"https://api.github.com/users/andrewboie/orgs","repos_url":"https://api.github.com/users/andrewboie/repos","events_url":"https://api.github.com/users/andrewboie/events{/privacy}","received_events_url":"https://api.github.com/users/andrewboie/received_events","type":"User","site_admin":false},{"login":"MaureenHelm","id":6172539,"node_id":"MDQ6VXNlcjYxNzI1Mzk=","avatar_url":"https://avatars2.githubusercontent.com/u/6172539?v=4","gravatar_id":"","url":"https://api.github.com/users/MaureenHelm","html_url":"https://github.com/MaureenHelm","followers_url":"https://api.github.com/users/MaureenHelm/followers","following_url":"https://api.github.com/users/MaureenHelm/following{/other_user}","gists_url":"https://api.github.com/users/MaureenHelm/gists{/gist_id}","starred_url":"https://api.github.com/users/MaureenHelm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaureenHelm/subscriptions","organizations_url":"https://api.github.com/users/MaureenHelm/orgs","repos_url":"https://api.github.com/users/MaureenHelm/repos","events_url":"https://api.github.com/users/MaureenHelm/events{/privacy}","received_events_url":"https://api.github.com/users/MaureenHelm/received_events","type":"User","site_admin":false},{"login":"erwango","id":18574308,"node_id":"MDQ6VXNlcjE4NTc0MzA4","avatar_url":"https://avatars1.githubusercontent.com/u/18574308?v=4","gravatar_id":"","url":"https://api.github.com/users/erwango","html_url":"https://github.com/erwango","followers_url":"https://api.github.com/users/erwango/followers","following_url":"https://api.github.com/users/erwango/following{/other_user}","gists_url":"https://api.github.com/users/erwango/gists{/gist_id}","starred_url":"https://api.github.com/users/erwango/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erwango/subscriptions","organizations_url":"https://api.github.com/users/erwango/orgs","repos_url":"https://api.github.com/users/erwango/repos","events_url":"https://api.github.com/users/erwango/events{/privacy}","received_events_url":"https://api.github.com/users/erwango/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/10944/commits","review_comments_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/10944/comments","review_comment_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/10944/comments","statuses_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/statuses/6a4b7bf0799ada8bc48f343d881dfa6b9d88d451","head":{"label":"himanshujha199640:20181030-GENMASK","ref":"20181030-GENMASK","sha":"6a4b7bf0799ada8bc48f343d881dfa6b9d88d451","user":{"login":"himanshujha199640","id":33165596,"node_id":"MDQ6VXNlcjMzMTY1NTk2","avatar_url":"https://avatars2.githubusercontent.com/u/33165596?v=4","gravatar_id":"","url":"https://api.github.com/users/himanshujha199640","html_url":"https://github.com/himanshujha199640","followers_url":"https://api.github.com/users/himanshujha199640/followers","following_url":"https://api.github.com/users/himanshujha199640/following{/other_user}","gists_url":"https://api.github.com/users/himanshujha199640/gists{/gist_id}","starred_url":"https://api.github.com/users/himanshujha199640/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/himanshujha199640/subscriptions","organizations_url":"https://api.github.com/users/himanshujha199640/orgs","repos_url":"https://api.github.com/users/himanshujha199640/repos","events_url":"https://api.github.com/users/himanshujha199640/events{/privacy}","received_events_url":"https://api.github.com/users/himanshujha199640/received_events","type":"User","site_admin":false},"repo":{"id":140594040,"node_id":"MDEwOlJlcG9zaXRvcnkxNDA1OTQwNDA=","name":"zephyr","full_name":"himanshujha199640/zephyr","private":false,"owner":{"login":"himanshujha199640","id":33165596,"node_id":"MDQ6VXNlcjMzMTY1NTk2","avatar_url":"https://avatars2.githubusercontent.com/u/33165596?v=4","gravatar_id":"","url":"https://api.github.com/users/himanshujha199640","html_url":"https://github.com/himanshujha199640","followers_url":"https://api.github.com/users/himanshujha199640/followers","following_url":"https://api.github.com/users/himanshujha199640/following{/other_user}","gists_url":"https://api.github.com/users/himanshujha199640/gists{/gist_id}","starred_url":"https://api.github.com/users/himanshujha199640/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/himanshujha199640/subscriptions","organizations_url":"https://api.github.com/users/himanshujha199640/orgs","repos_url":"https://api.github.com/users/himanshujha199640/repos","events_url":"https://api.github.com/users/himanshujha199640/events{/privacy}","received_events_url":"https://api.github.com/users/himanshujha199640/received_events","type":"User","site_admin":false},"html_url":"https://github.com/himanshujha199640/zephyr","description":"Primary GIT Repository for the Zephyr Project","fork":true,"url":"https://api.github.com/repos/himanshujha199640/zephyr","forks_url":"https://api.github.com/repos/himanshujha199640/zephyr/forks","keys_url":"https://api.github.com/repos/himanshujha199640/zephyr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/himanshujha199640/zephyr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/himanshujha199640/zephyr/teams","hooks_url":"https://api.github.com/repos/himanshujha199640/zephyr/hooks","issue_events_url":"https://api.github.com/repos/himanshujha199640/zephyr/issues/events{/number}","events_url":"https://api.github.com/repos/himanshujha199640/zephyr/events","assignees_url":"https://api.github.com/repos/himanshujha199640/zephyr/assignees{/user}","branches_url":"https://api.github.com/repos/himanshujha199640/zephyr/branches{/branch}","tags_url":"https://api.github.com/repos/himanshujha199640/zephyr/tags","blobs_url":"https://api.github.com/repos/himanshujha199640/zephyr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/himanshujha199640/zephyr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/himanshujha199640/zephyr/git/refs{/sha}","trees_url":"https://api.github.com/repos/himanshujha199640/zephyr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/himanshujha199640/zephyr/statuses/{sha}","languages_url":"https://api.github.com/repos/himanshujha199640/zephyr/languages","stargazers_url":"https://api.github.com/repos/himanshujha199640/zephyr/stargazers","contributors_url":"https://api.github.com/repos/himanshujha199640/zephyr/contributors","subscribers_url":"https://api.github.com/repos/himanshujha199640/zephyr/subscribers","subscription_url":"https://api.github.com/repos/himanshujha199640/zephyr/subscription","commits_url":"https://api.github.com/repos/himanshujha199640/zephyr/commits{/sha}","git_commits_url":"https://api.github.com/repos/himanshujha199640/zephyr/git/commits{/sha}","comments_url":"https://api.github.com/repos/himanshujha199640/zephyr/comments{/number}","issue_comment_url":"https://api.github.com/repos/himanshujha199640/zephyr/issues/comments{/number}","contents_url":"https://api.github.com/repos/himanshujha199640/zephyr/contents/{+path}","compare_url":"https://api.github.com/repos/himanshujha199640/zephyr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/himanshujha199640/zephyr/merges","archive_url":"https://api.github.com/repos/himanshujha199640/zephyr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/himanshujha199640/zephyr/downloads","issues_url":"https://api.github.com/repos/himanshujha199640/zephyr/issues{/number}","pulls_url":"https://api.github.com/repos/himanshujha199640/zephyr/pulls{/number}","milestones_url":"https://api.github.com/repos/himanshujha199640/zephyr/milestones{/number}","notifications_url":"https://api.github.com/repos/himanshujha199640/zephyr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/himanshujha199640/zephyr/labels{/name}","releases_url":"https://api.github.com/repos/himanshujha199640/zephyr/releases{/id}","deployments_url":"https://api.github.com/repos/himanshujha199640/zephyr/deployments","created_at":"2018-07-11T15:21:47Z","updated_at":"2018-07-11T15:22:34Z","pushed_at":"2018-10-30T18:21:34Z","git_url":"git://github.com/himanshujha199640/zephyr.git","ssh_url":"[email protected]:himanshujha199640/zephyr.git","clone_url":"https://github.com/himanshujha199640/zephyr.git","svn_url":"https://github.com/himanshujha199640/zephyr","homepage":"https://docs.zephyrproject.org","size":155841,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"zephyrproject-rtos:master","ref":"master","sha":"7700eb2a15e1a492e1ee9e85a8be67a09fa76700","user":{"login":"zephyrproject-rtos","id":19595895,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NTk1ODk1","avatar_url":"https://avatars2.githubusercontent.com/u/19595895?v=4","gravatar_id":"","url":"https://api.github.com/users/zephyrproject-rtos","html_url":"https://github.com/zephyrproject-rtos","followers_url":"https://api.github.com/users/zephyrproject-rtos/followers","following_url":"https://api.github.com/users/zephyrproject-rtos/following{/other_user}","gists_url":"https://api.github.com/users/zephyrproject-rtos/gists{/gist_id}","starred_url":"https://api.github.com/users/zephyrproject-rtos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zephyrproject-rtos/subscriptions","organizations_url":"https://api.github.com/users/zephyrproject-rtos/orgs","repos_url":"https://api.github.com/users/zephyrproject-rtos/repos","events_url":"https://api.github.com/users/zephyrproject-rtos/events{/privacy}","received_events_url":"https://api.github.com/users/zephyrproject-rtos/received_events","type":"Organization","site_admin":false},"repo":{"id":59771425,"node_id":"MDEwOlJlcG9zaXRvcnk1OTc3MTQyNQ==","name":"zephyr","full_name":"zephyrproject-rtos/zephyr","private":false,"owner":{"login":"zephyrproject-rtos","id":19595895,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NTk1ODk1","avatar_url":"https://avatars2.githubusercontent.com/u/19595895?v=4","gravatar_id":"","url":"https://api.github.com/users/zephyrproject-rtos","html_url":"https://github.com/zephyrproject-rtos","followers_url":"https://api.github.com/users/zephyrproject-rtos/followers","following_url":"https://api.github.com/users/zephyrproject-rtos/following{/other_user}","gists_url":"https://api.github.com/users/zephyrproject-rtos/gists{/gist_id}","starred_url":"https://api.github.com/users/zephyrproject-rtos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zephyrproject-rtos/subscriptions","organizations_url":"https://api.github.com/users/zephyrproject-rtos/orgs","repos_url":"https://api.github.com/users/zephyrproject-rtos/repos","events_url":"https://api.github.com/users/zephyrproject-rtos/events{/privacy}","received_events_url":"https://api.github.com/users/zephyrproject-rtos/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/zephyrproject-rtos/zephyr","description":"Primary GIT Repository for the Zephyr Project","fork":false,"url":"https://api.github.com/repos/zephyrproject-rtos/zephyr","forks_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/forks","keys_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/teams","hooks_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/hooks","issue_events_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/events{/number}","events_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/events","assignees_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/assignees{/user}","branches_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/branches{/branch}","tags_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/tags","blobs_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/git/refs{/sha}","trees_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/statuses/{sha}","languages_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/languages","stargazers_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/stargazers","contributors_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/contributors","subscribers_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/subscribers","subscription_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/subscription","commits_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/commits{/sha}","git_commits_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/git/commits{/sha}","comments_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/comments{/number}","issue_comment_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/comments{/number}","contents_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/contents/{+path}","compare_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/merges","archive_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/downloads","issues_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues{/number}","pulls_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls{/number}","milestones_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/milestones{/number}","notifications_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/labels{/name}","releases_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/releases{/id}","deployments_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/deployments","created_at":"2016-05-26T17:54:19Z","updated_at":"2018-10-30T19:39:52Z","pushed_at":"2018-10-30T19:43:46Z","git_url":"git://github.com/zephyrproject-rtos/zephyr.git","ssh_url":"[email protected]:zephyrproject-rtos/zephyr.git","clone_url":"https://github.com/zephyrproject-rtos/zephyr.git","svn_url":"https://github.com/zephyrproject-rtos/zephyr","homepage":"https://docs.zephyrproject.org","size":156006,"stargazers_count":1315,"watchers_count":1315,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":857,"mirror_url":null,"archived":false,"open_issues_count":1120,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":857,"open_issues":1120,"watchers":1315,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/10944"},"html":{"href":"https://github.com/zephyrproject-rtos/zephyr/pull/10944"},"issue":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/10944"},"comments":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/10944/comments"},"review_comments":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/10944/comments"},"review_comment":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/10944/commits"},"statuses":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/statuses/6a4b7bf0799ada8bc48f343d881dfa6b9d88d451"}},"author_association":"CONTRIBUTOR"}} | {
"id": 59771425,
"name": "zephyrproject-rtos/zephyr",
"url": "https://api.github.com/repos/zephyrproject-rtos/zephyr"
} | {
"id": 154768,
"login": "ulfalizer",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/154768?",
"url": "https://api.github.com/users/ulfalizer"
} | {
"id": 19595895,
"login": "zephyrproject-rtos",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/19595895?",
"url": "https://api.github.com/orgs/zephyrproject-rtos"
} | 2018-10-30T19:39:13 | 8507735551 | {"actor":{"display_login":"ulfalizer"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/comments/239622794","pull_request_review_id":182443730,"id":239622794,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzOTYyMjc5NA==","diff_hunk":"@@ -0,0 +1,31 @@\n+set(CMAKE_SYSTEM_NAME Generic)\n+set(CMAKE_SYSTEM_PROCESSOR ${ARCH})\n+\n+set(BUILD_SHARED_LIBS OFF)\n+\n+set(CMAKE_FIND_ROOT_PATH_MODE_PROGRAM NEVER)\n+set(CMAKE_FIND_ROOT_PATH_MODE_LIBRARY ONLY)\n+set(CMAKE_FIND_ROOT_PATH_MODE_INCLUDE ONLY)\n+set(CMAKE_FIND_ROOT_PATH_MODE_PACKAGE ONLY)\n+\n+if(NOT (COMPILER STREQUAL \"host-gcc\"))\n+ include(${TOOLCHAIN_ROOT}/cmake/toolchain/${ZEPHYR_TOOLCHAIN_VARIANT}/target.cmake)\n+endif()\n+\n+# Configure the toolchain based on what toolchain technology is used\n+# (gcc, host-gcc etc.)\n+include(${ZEPHYR_BASE}/cmake/compiler/${COMPILER}/target.cmake OPTIONAL)","path":"cmake/target_toolchain.cmake","position":17,"original_position":17,"commit_id":"9cf4ee7f85adb282742d72cf27ded16cc66ae45c","original_commit_id":"9cf4ee7f85adb282742d72cf27ded16cc66ae45c","user":{"login":"mped-oticon","id":39737157,"node_id":"MDQ6VXNlcjM5NzM3MTU3","avatar_url":"https://avatars3.githubusercontent.com/u/39737157?v=4","gravatar_id":"","url":"https://api.github.com/users/mped-oticon","html_url":"https://github.com/mped-oticon","followers_url":"https://api.github.com/users/mped-oticon/followers","following_url":"https://api.github.com/users/mped-oticon/following{/other_user}","gists_url":"https://api.github.com/users/mped-oticon/gists{/gist_id}","starred_url":"https://api.github.com/users/mped-oticon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mped-oticon/subscriptions","organizations_url":"https://api.github.com/users/mped-oticon/orgs","repos_url":"https://api.github.com/users/mped-oticon/repos","events_url":"https://api.github.com/users/mped-oticon/events{/privacy}","received_events_url":"https://api.github.com/users/mped-oticon/received_events","type":"User","site_admin":false},"body":"Dissonance between base directories for compiler and toolchain folders:\r\nAbove for host-gcc, `TOOLCHAIN_ROOT` was used, but here we use `ZEPHYR_BASE`.\r\nShould be `TOOLCHAIN_ROOT` in both places as that works with out-of-tree stuff.","created_at":"2018-12-06T21:33:55Z","updated_at":"2018-12-06T21:51:54Z","html_url":"https://github.com/zephyrproject-rtos/zephyr/pull/11810#discussion_r239622794","pull_request_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/11810","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/comments/239622794"},"html":{"href":"https://github.com/zephyrproject-rtos/zephyr/pull/11810#discussion_r239622794"},"pull_request":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/11810"}}},"pull_request":{"url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/11810","id":235436016,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM1NDM2MDE2","html_url":"https://github.com/zephyrproject-rtos/zephyr/pull/11810","diff_url":"https://github.com/zephyrproject-rtos/zephyr/pull/11810.diff","patch_url":"https://github.com/zephyrproject-rtos/zephyr/pull/11810.patch","issue_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/11810","number":11810,"state":"open","locked":false,"title":"cmake: Split toolchain configuration into pre-and post-DT","user":{"login":"SebastianBoe","id":609230,"node_id":"MDQ6VXNlcjYwOTIzMA==","avatar_url":"https://avatars0.githubusercontent.com/u/609230?v=4","gravatar_id":"","url":"https://api.github.com/users/SebastianBoe","html_url":"https://github.com/SebastianBoe","followers_url":"https://api.github.com/users/SebastianBoe/followers","following_url":"https://api.github.com/users/SebastianBoe/following{/other_user}","gists_url":"https://api.github.com/users/SebastianBoe/gists{/gist_id}","starred_url":"https://api.github.com/users/SebastianBoe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SebastianBoe/subscriptions","organizations_url":"https://api.github.com/users/SebastianBoe/orgs","repos_url":"https://api.github.com/users/SebastianBoe/repos","events_url":"https://api.github.com/users/SebastianBoe/events{/privacy}","received_events_url":"https://api.github.com/users/SebastianBoe/received_events","type":"User","site_admin":false},"body":"Split up the toolchain configuration into two phases, generic and\r\ntarget. The 'generic' phase configures the toolchain just enough to be\r\nable to preprocess DT files. The 'target' phase completes the\r\nconfiguration with target-specific configuration.","created_at":"2018-12-03T12:50:34Z","updated_at":"2018-12-06T21:51:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"eaec80c75bd12e9f2c507769ae28eadb5fcf966f","assignee":null,"assignees":[],"requested_reviewers":[{"login":"nashif","id":180017,"node_id":"MDQ6VXNlcjE4MDAxNw==","avatar_url":"https://avatars0.githubusercontent.com/u/180017?v=4","gravatar_id":"","url":"https://api.github.com/users/nashif","html_url":"https://github.com/nashif","followers_url":"https://api.github.com/users/nashif/followers","following_url":"https://api.github.com/users/nashif/following{/other_user}","gists_url":"https://api.github.com/users/nashif/gists{/gist_id}","starred_url":"https://api.github.com/users/nashif/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nashif/subscriptions","organizations_url":"https://api.github.com/users/nashif/orgs","repos_url":"https://api.github.com/users/nashif/repos","events_url":"https://api.github.com/users/nashif/events{/privacy}","received_events_url":"https://api.github.com/users/nashif/received_events","type":"User","site_admin":false},{"login":"carlescufi","id":12450381,"node_id":"MDQ6VXNlcjEyNDUwMzgx","avatar_url":"https://avatars3.githubusercontent.com/u/12450381?v=4","gravatar_id":"","url":"https://api.github.com/users/carlescufi","html_url":"https://github.com/carlescufi","followers_url":"https://api.github.com/users/carlescufi/followers","following_url":"https://api.github.com/users/carlescufi/following{/other_user}","gists_url":"https://api.github.com/users/carlescufi/gists{/gist_id}","starred_url":"https://api.github.com/users/carlescufi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carlescufi/subscriptions","organizations_url":"https://api.github.com/users/carlescufi/orgs","repos_url":"https://api.github.com/users/carlescufi/repos","events_url":"https://api.github.com/users/carlescufi/events{/privacy}","received_events_url":"https://api.github.com/users/carlescufi/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/11810/commits","review_comments_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/11810/comments","review_comment_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/11810/comments","statuses_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/statuses/9cf4ee7f85adb282742d72cf27ded16cc66ae45c","head":{"label":"SebastianBoe:split_files","ref":"split_files","sha":"9cf4ee7f85adb282742d72cf27ded16cc66ae45c","user":{"login":"SebastianBoe","id":609230,"node_id":"MDQ6VXNlcjYwOTIzMA==","avatar_url":"https://avatars0.githubusercontent.com/u/609230?v=4","gravatar_id":"","url":"https://api.github.com/users/SebastianBoe","html_url":"https://github.com/SebastianBoe","followers_url":"https://api.github.com/users/SebastianBoe/followers","following_url":"https://api.github.com/users/SebastianBoe/following{/other_user}","gists_url":"https://api.github.com/users/SebastianBoe/gists{/gist_id}","starred_url":"https://api.github.com/users/SebastianBoe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SebastianBoe/subscriptions","organizations_url":"https://api.github.com/users/SebastianBoe/orgs","repos_url":"https://api.github.com/users/SebastianBoe/repos","events_url":"https://api.github.com/users/SebastianBoe/events{/privacy}","received_events_url":"https://api.github.com/users/SebastianBoe/received_events","type":"User","site_admin":false},"repo":{"id":96869533,"node_id":"MDEwOlJlcG9zaXRvcnk5Njg2OTUzMw==","name":"zephyr","full_name":"SebastianBoe/zephyr","private":false,"owner":{"login":"SebastianBoe","id":609230,"node_id":"MDQ6VXNlcjYwOTIzMA==","avatar_url":"https://avatars0.githubusercontent.com/u/609230?v=4","gravatar_id":"","url":"https://api.github.com/users/SebastianBoe","html_url":"https://github.com/SebastianBoe","followers_url":"https://api.github.com/users/SebastianBoe/followers","following_url":"https://api.github.com/users/SebastianBoe/following{/other_user}","gists_url":"https://api.github.com/users/SebastianBoe/gists{/gist_id}","starred_url":"https://api.github.com/users/SebastianBoe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SebastianBoe/subscriptions","organizations_url":"https://api.github.com/users/SebastianBoe/orgs","repos_url":"https://api.github.com/users/SebastianBoe/repos","events_url":"https://api.github.com/users/SebastianBoe/events{/privacy}","received_events_url":"https://api.github.com/users/SebastianBoe/received_events","type":"User","site_admin":false},"html_url":"https://github.com/SebastianBoe/zephyr","description":"Primary GIT Repository for the Zephyr Project","fork":true,"url":"https://api.github.com/repos/SebastianBoe/zephyr","forks_url":"https://api.github.com/repos/SebastianBoe/zephyr/forks","keys_url":"https://api.github.com/repos/SebastianBoe/zephyr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SebastianBoe/zephyr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SebastianBoe/zephyr/teams","hooks_url":"https://api.github.com/repos/SebastianBoe/zephyr/hooks","issue_events_url":"https://api.github.com/repos/SebastianBoe/zephyr/issues/events{/number}","events_url":"https://api.github.com/repos/SebastianBoe/zephyr/events","assignees_url":"https://api.github.com/repos/SebastianBoe/zephyr/assignees{/user}","branches_url":"https://api.github.com/repos/SebastianBoe/zephyr/branches{/branch}","tags_url":"https://api.github.com/repos/SebastianBoe/zephyr/tags","blobs_url":"https://api.github.com/repos/SebastianBoe/zephyr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SebastianBoe/zephyr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SebastianBoe/zephyr/git/refs{/sha}","trees_url":"https://api.github.com/repos/SebastianBoe/zephyr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SebastianBoe/zephyr/statuses/{sha}","languages_url":"https://api.github.com/repos/SebastianBoe/zephyr/languages","stargazers_url":"https://api.github.com/repos/SebastianBoe/zephyr/stargazers","contributors_url":"https://api.github.com/repos/SebastianBoe/zephyr/contributors","subscribers_url":"https://api.github.com/repos/SebastianBoe/zephyr/subscribers","subscription_url":"https://api.github.com/repos/SebastianBoe/zephyr/subscription","commits_url":"https://api.github.com/repos/SebastianBoe/zephyr/commits{/sha}","git_commits_url":"https://api.github.com/repos/SebastianBoe/zephyr/git/commits{/sha}","comments_url":"https://api.github.com/repos/SebastianBoe/zephyr/comments{/number}","issue_comment_url":"https://api.github.com/repos/SebastianBoe/zephyr/issues/comments{/number}","contents_url":"https://api.github.com/repos/SebastianBoe/zephyr/contents/{+path}","compare_url":"https://api.github.com/repos/SebastianBoe/zephyr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SebastianBoe/zephyr/merges","archive_url":"https://api.github.com/repos/SebastianBoe/zephyr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SebastianBoe/zephyr/downloads","issues_url":"https://api.github.com/repos/SebastianBoe/zephyr/issues{/number}","pulls_url":"https://api.github.com/repos/SebastianBoe/zephyr/pulls{/number}","milestones_url":"https://api.github.com/repos/SebastianBoe/zephyr/milestones{/number}","notifications_url":"https://api.github.com/repos/SebastianBoe/zephyr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SebastianBoe/zephyr/labels{/name}","releases_url":"https://api.github.com/repos/SebastianBoe/zephyr/releases{/id}","deployments_url":"https://api.github.com/repos/SebastianBoe/zephyr/deployments","created_at":"2017-07-11T08:24:03Z","updated_at":"2017-07-11T08:24:40Z","pushed_at":"2018-12-06T15:19:09Z","git_url":"git://github.com/SebastianBoe/zephyr.git","ssh_url":"[email protected]:SebastianBoe/zephyr.git","clone_url":"https://github.com/SebastianBoe/zephyr.git","svn_url":"https://github.com/SebastianBoe/zephyr","homepage":"http://zephyrproject.org/doc","size":164696,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"zephyrproject-rtos:master","ref":"master","sha":"48f493208baf4d7e6d8f72b1473889b2cc9fcbcb","user":{"login":"zephyrproject-rtos","id":19595895,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NTk1ODk1","avatar_url":"https://avatars2.githubusercontent.com/u/19595895?v=4","gravatar_id":"","url":"https://api.github.com/users/zephyrproject-rtos","html_url":"https://github.com/zephyrproject-rtos","followers_url":"https://api.github.com/users/zephyrproject-rtos/followers","following_url":"https://api.github.com/users/zephyrproject-rtos/following{/other_user}","gists_url":"https://api.github.com/users/zephyrproject-rtos/gists{/gist_id}","starred_url":"https://api.github.com/users/zephyrproject-rtos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zephyrproject-rtos/subscriptions","organizations_url":"https://api.github.com/users/zephyrproject-rtos/orgs","repos_url":"https://api.github.com/users/zephyrproject-rtos/repos","events_url":"https://api.github.com/users/zephyrproject-rtos/events{/privacy}","received_events_url":"https://api.github.com/users/zephyrproject-rtos/received_events","type":"Organization","site_admin":false},"repo":{"id":59771425,"node_id":"MDEwOlJlcG9zaXRvcnk1OTc3MTQyNQ==","name":"zephyr","full_name":"zephyrproject-rtos/zephyr","private":false,"owner":{"login":"zephyrproject-rtos","id":19595895,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NTk1ODk1","avatar_url":"https://avatars2.githubusercontent.com/u/19595895?v=4","gravatar_id":"","url":"https://api.github.com/users/zephyrproject-rtos","html_url":"https://github.com/zephyrproject-rtos","followers_url":"https://api.github.com/users/zephyrproject-rtos/followers","following_url":"https://api.github.com/users/zephyrproject-rtos/following{/other_user}","gists_url":"https://api.github.com/users/zephyrproject-rtos/gists{/gist_id}","starred_url":"https://api.github.com/users/zephyrproject-rtos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zephyrproject-rtos/subscriptions","organizations_url":"https://api.github.com/users/zephyrproject-rtos/orgs","repos_url":"https://api.github.com/users/zephyrproject-rtos/repos","events_url":"https://api.github.com/users/zephyrproject-rtos/events{/privacy}","received_events_url":"https://api.github.com/users/zephyrproject-rtos/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/zephyrproject-rtos/zephyr","description":"Primary GIT Repository for the Zephyr Project","fork":false,"url":"https://api.github.com/repos/zephyrproject-rtos/zephyr","forks_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/forks","keys_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/teams","hooks_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/hooks","issue_events_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/events{/number}","events_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/events","assignees_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/assignees{/user}","branches_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/branches{/branch}","tags_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/tags","blobs_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/git/refs{/sha}","trees_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/statuses/{sha}","languages_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/languages","stargazers_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/stargazers","contributors_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/contributors","subscribers_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/subscribers","subscription_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/subscription","commits_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/commits{/sha}","git_commits_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/git/commits{/sha}","comments_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/comments{/number}","issue_comment_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/comments{/number}","contents_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/contents/{+path}","compare_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/merges","archive_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/downloads","issues_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues{/number}","pulls_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls{/number}","milestones_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/milestones{/number}","notifications_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/labels{/name}","releases_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/releases{/id}","deployments_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/deployments","created_at":"2016-05-26T17:54:19Z","updated_at":"2018-12-06T20:45:25Z","pushed_at":"2018-12-06T20:44:24Z","git_url":"git://github.com/zephyrproject-rtos/zephyr.git","ssh_url":"[email protected]:zephyrproject-rtos/zephyr.git","clone_url":"https://github.com/zephyrproject-rtos/zephyr.git","svn_url":"https://github.com/zephyrproject-rtos/zephyr","homepage":"https://docs.zephyrproject.org","size":160570,"stargazers_count":1424,"watchers_count":1424,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":948,"mirror_url":null,"archived":false,"open_issues_count":1156,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":948,"open_issues":1156,"watchers":1424,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/11810"},"html":{"href":"https://github.com/zephyrproject-rtos/zephyr/pull/11810"},"issue":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/11810"},"comments":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/11810/comments"},"review_comments":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/11810/comments"},"review_comment":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/11810/commits"},"statuses":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/statuses/9cf4ee7f85adb282742d72cf27ded16cc66ae45c"}},"author_association":"COLLABORATOR"}} | {
"id": 59771425,
"name": "zephyrproject-rtos/zephyr",
"url": "https://api.github.com/repos/zephyrproject-rtos/zephyr"
} | {
"id": 39737157,
"login": "mped-oticon",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/39737157?",
"url": "https://api.github.com/users/mped-oticon"
} | {
"id": 19595895,
"login": "zephyrproject-rtos",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/19595895?",
"url": "https://api.github.com/orgs/zephyrproject-rtos"
} | 2018-12-06T21:33:55 | 8712321836 | {"actor":{"display_login":"mped-oticon"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/Jigsaw-Code/intra/pulls/comments/207036355","pull_request_review_id":142525707,"id":207036355,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNzAzNjM1NQ==","diff_hunk":"@@ -0,0 +1,155 @@\n+/*\n+Copyright 2018 Jigsaw Operations LLC\n+\n+Licensed under the Apache License, Version 2.0 (the \"License\");\n+you may not use this file except in compliance with the License.\n+You may obtain a copy of the License at\n+\n+https://www.apache.org/licenses/LICENSE-2.0\n+\n+Unless required by applicable law or agreed to in writing, software\n+distributed under the License is distributed on an \"AS IS\" BASIS,\n+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+See the License for the specific language governing permissions and\n+limitations under the License.\n+*/\n+package app.intra;\n+\n+import android.app.Dialog;\n+import android.os.Bundle;\n+import android.support.v7.app.AlertDialog;\n+import android.support.v7.preference.PreferenceDialogFragmentCompat;\n+import android.text.Editable;\n+import android.text.TextWatcher;\n+import android.view.KeyEvent;\n+import android.view.View;\n+import android.widget.Button;\n+import android.widget.EditText;\n+import android.widget.RadioGroup;\n+import android.widget.TextView;\n+\n+import java.net.MalformedURLException;\n+import java.net.URL;\n+\n+import app.intra.util.Untemplate;\n+\n+/**\n+ * User interface for a the server URL selection.\n+ */\n+\n+public class ServerChooserFragment extends PreferenceDialogFragmentCompat\n+ implements RadioGroup.OnCheckedChangeListener, TextWatcher, EditText.OnEditorActionListener {\n+ private String newUrl = null;\n+ private RadioGroup buttons = null;\n+ private EditText text = null;\n+\n+ public static ServerChooserFragment newInstance(String key) {\n+ final ServerChooserFragment fragment = new ServerChooserFragment();\n+ final Bundle bundle = new Bundle(1);\n+ bundle.putString(ARG_KEY, key);\n+ fragment.setArguments(bundle);\n+ return fragment;\n+ }\n+\n+ @Override\n+ public void onCheckedChanged(RadioGroup group, int checkedId) {\n+ if (checkedId == R.id.pref_server_google) {\n+ newUrl = getResources().getString(R.string.url0);\n+ setValid(true);","path":"Android/app/src/main/java/app/intra/ServerChooserFragment.java","position":58,"original_position":58,"commit_id":"b235ba621f4071b5e46f3782ca5981af38e06cdf","original_commit_id":"b235ba621f4071b5e46f3782ca5981af38e06cdf","user":{"login":"cjhenck","id":2380566,"node_id":"MDQ6VXNlcjIzODA1NjY=","avatar_url":"https://avatars3.githubusercontent.com/u/2380566?v=4","gravatar_id":"","url":"https://api.github.com/users/cjhenck","html_url":"https://github.com/cjhenck","followers_url":"https://api.github.com/users/cjhenck/followers","following_url":"https://api.github.com/users/cjhenck/following{/other_user}","gists_url":"https://api.github.com/users/cjhenck/gists{/gist_id}","starred_url":"https://api.github.com/users/cjhenck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjhenck/subscriptions","organizations_url":"https://api.github.com/users/cjhenck/orgs","repos_url":"https://api.github.com/users/cjhenck/repos","events_url":"https://api.github.com/users/cjhenck/events{/privacy}","received_events_url":"https://api.github.com/users/cjhenck/received_events","type":"User","site_admin":false},"body":"I personally like to set the UI based on state. E.g. update newURL, then call an updateUI() function, or have a setter of some sort for newURL. Makes it easier to maintain the UI logic.","created_at":"2018-08-01T21:23:08Z","updated_at":"2018-08-01T21:31:48Z","html_url":"https://github.com/Jigsaw-Code/intra/pull/26#discussion_r207036355","pull_request_url":"https://api.github.com/repos/Jigsaw-Code/intra/pulls/26","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/Jigsaw-Code/intra/pulls/comments/207036355"},"html":{"href":"https://github.com/Jigsaw-Code/intra/pull/26#discussion_r207036355"},"pull_request":{"href":"https://api.github.com/repos/Jigsaw-Code/intra/pulls/26"}}},"pull_request":{"url":"https://api.github.com/repos/Jigsaw-Code/intra/pulls/26","id":205256742,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1MjU2NzQy","html_url":"https://github.com/Jigsaw-Code/intra/pull/26","diff_url":"https://github.com/Jigsaw-Code/intra/pull/26.diff","patch_url":"https://github.com/Jigsaw-Code/intra/pull/26.patch","issue_url":"https://api.github.com/repos/Jigsaw-Code/intra/issues/26","number":26,"state":"open","locked":false,"title":"Move server selection to Settings and allows URLs","user":{"login":"bemasc","id":191945,"node_id":"MDQ6VXNlcjE5MTk0NQ==","avatar_url":"https://avatars1.githubusercontent.com/u/191945?v=4","gravatar_id":"","url":"https://api.github.com/users/bemasc","html_url":"https://github.com/bemasc","followers_url":"https://api.github.com/users/bemasc/followers","following_url":"https://api.github.com/users/bemasc/following{/other_user}","gists_url":"https://api.github.com/users/bemasc/gists{/gist_id}","starred_url":"https://api.github.com/users/bemasc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bemasc/subscriptions","organizations_url":"https://api.github.com/users/bemasc/orgs","repos_url":"https://api.github.com/users/bemasc/repos","events_url":"https://api.github.com/users/bemasc/events{/privacy}","received_events_url":"https://api.github.com/users/bemasc/received_events","type":"User","site_admin":false},"body":"With this change, the user can select a server before initiating a\r\nconnection for the first time (important if the default server\r\nis not working for any reason). This change also allows advanced\r\nusers to use arbitrary DOH servers, not just the two presets.\r\n\r\nThis change removes the server control from the main screen.\r\nThis is good for visual consistency, but if users find it harder\r\nto discover this option then that could be an unfortunate side-effect.\r\n\r\nFixes #21","created_at":"2018-07-31T22:09:47Z","updated_at":"2018-08-01T21:31:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f519794b8e72f2313d8a11236a533912c7f5e77f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Jigsaw-Code/intra/pulls/26/commits","review_comments_url":"https://api.github.com/repos/Jigsaw-Code/intra/pulls/26/comments","review_comment_url":"https://api.github.com/repos/Jigsaw-Code/intra/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Jigsaw-Code/intra/issues/26/comments","statuses_url":"https://api.github.com/repos/Jigsaw-Code/intra/statuses/b235ba621f4071b5e46f3782ca5981af38e06cdf","head":{"label":"Jigsaw-Code:bemasc-custom","ref":"bemasc-custom","sha":"b235ba621f4071b5e46f3782ca5981af38e06cdf","user":{"login":"Jigsaw-Code","id":19845815,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5ODQ1ODE1","avatar_url":"https://avatars0.githubusercontent.com/u/19845815?v=4","gravatar_id":"","url":"https://api.github.com/users/Jigsaw-Code","html_url":"https://github.com/Jigsaw-Code","followers_url":"https://api.github.com/users/Jigsaw-Code/followers","following_url":"https://api.github.com/users/Jigsaw-Code/following{/other_user}","gists_url":"https://api.github.com/users/Jigsaw-Code/gists{/gist_id}","starred_url":"https://api.github.com/users/Jigsaw-Code/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jigsaw-Code/subscriptions","organizations_url":"https://api.github.com/users/Jigsaw-Code/orgs","repos_url":"https://api.github.com/users/Jigsaw-Code/repos","events_url":"https://api.github.com/users/Jigsaw-Code/events{/privacy}","received_events_url":"https://api.github.com/users/Jigsaw-Code/received_events","type":"Organization","site_admin":false},"repo":{"id":131884789,"node_id":"MDEwOlJlcG9zaXRvcnkxMzE4ODQ3ODk=","name":"intra","full_name":"Jigsaw-Code/intra","owner":{"login":"Jigsaw-Code","id":19845815,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5ODQ1ODE1","avatar_url":"https://avatars0.githubusercontent.com/u/19845815?v=4","gravatar_id":"","url":"https://api.github.com/users/Jigsaw-Code","html_url":"https://github.com/Jigsaw-Code","followers_url":"https://api.github.com/users/Jigsaw-Code/followers","following_url":"https://api.github.com/users/Jigsaw-Code/following{/other_user}","gists_url":"https://api.github.com/users/Jigsaw-Code/gists{/gist_id}","starred_url":"https://api.github.com/users/Jigsaw-Code/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jigsaw-Code/subscriptions","organizations_url":"https://api.github.com/users/Jigsaw-Code/orgs","repos_url":"https://api.github.com/users/Jigsaw-Code/repos","events_url":"https://api.github.com/users/Jigsaw-Code/events{/privacy}","received_events_url":"https://api.github.com/users/Jigsaw-Code/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Jigsaw-Code/intra","description":"An experimental tool that allows you to test new DNS-over-HTTPS services on Android","fork":false,"url":"https://api.github.com/repos/Jigsaw-Code/intra","forks_url":"https://api.github.com/repos/Jigsaw-Code/intra/forks","keys_url":"https://api.github.com/repos/Jigsaw-Code/intra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Jigsaw-Code/intra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Jigsaw-Code/intra/teams","hooks_url":"https://api.github.com/repos/Jigsaw-Code/intra/hooks","issue_events_url":"https://api.github.com/repos/Jigsaw-Code/intra/issues/events{/number}","events_url":"https://api.github.com/repos/Jigsaw-Code/intra/events","assignees_url":"https://api.github.com/repos/Jigsaw-Code/intra/assignees{/user}","branches_url":"https://api.github.com/repos/Jigsaw-Code/intra/branches{/branch}","tags_url":"https://api.github.com/repos/Jigsaw-Code/intra/tags","blobs_url":"https://api.github.com/repos/Jigsaw-Code/intra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Jigsaw-Code/intra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Jigsaw-Code/intra/git/refs{/sha}","trees_url":"https://api.github.com/repos/Jigsaw-Code/intra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Jigsaw-Code/intra/statuses/{sha}","languages_url":"https://api.github.com/repos/Jigsaw-Code/intra/languages","stargazers_url":"https://api.github.com/repos/Jigsaw-Code/intra/stargazers","contributors_url":"https://api.github.com/repos/Jigsaw-Code/intra/contributors","subscribers_url":"https://api.github.com/repos/Jigsaw-Code/intra/subscribers","subscription_url":"https://api.github.com/repos/Jigsaw-Code/intra/subscription","commits_url":"https://api.github.com/repos/Jigsaw-Code/intra/commits{/sha}","git_commits_url":"https://api.github.com/repos/Jigsaw-Code/intra/git/commits{/sha}","comments_url":"https://api.github.com/repos/Jigsaw-Code/intra/comments{/number}","issue_comment_url":"https://api.github.com/repos/Jigsaw-Code/intra/issues/comments{/number}","contents_url":"https://api.github.com/repos/Jigsaw-Code/intra/contents/{+path}","compare_url":"https://api.github.com/repos/Jigsaw-Code/intra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Jigsaw-Code/intra/merges","archive_url":"https://api.github.com/repos/Jigsaw-Code/intra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Jigsaw-Code/intra/downloads","issues_url":"https://api.github.com/repos/Jigsaw-Code/intra/issues{/number}","pulls_url":"https://api.github.com/repos/Jigsaw-Code/intra/pulls{/number}","milestones_url":"https://api.github.com/repos/Jigsaw-Code/intra/milestones{/number}","notifications_url":"https://api.github.com/repos/Jigsaw-Code/intra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Jigsaw-Code/intra/labels{/name}","releases_url":"https://api.github.com/repos/Jigsaw-Code/intra/releases{/id}","deployments_url":"https://api.github.com/repos/Jigsaw-Code/intra/deployments","created_at":"2018-05-02T17:32:48Z","updated_at":"2018-08-01T15:30:34Z","pushed_at":"2018-08-01T18:06:17Z","git_url":"git://github.com/Jigsaw-Code/intra.git","ssh_url":"[email protected]:Jigsaw-Code/intra.git","clone_url":"https://github.com/Jigsaw-Code/intra.git","svn_url":"https://github.com/Jigsaw-Code/intra","homepage":null,"size":7238,"stargazers_count":47,"watchers_count":47,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":11,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":4,"open_issues":11,"watchers":47,"default_branch":"master"}},"base":{"label":"Jigsaw-Code:bemasc-webrtc","ref":"bemasc-webrtc","sha":"0ca54590f07688b3f0c749df7516aab2f225d645","user":{"login":"Jigsaw-Code","id":19845815,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5ODQ1ODE1","avatar_url":"https://avatars0.githubusercontent.com/u/19845815?v=4","gravatar_id":"","url":"https://api.github.com/users/Jigsaw-Code","html_url":"https://github.com/Jigsaw-Code","followers_url":"https://api.github.com/users/Jigsaw-Code/followers","following_url":"https://api.github.com/users/Jigsaw-Code/following{/other_user}","gists_url":"https://api.github.com/users/Jigsaw-Code/gists{/gist_id}","starred_url":"https://api.github.com/users/Jigsaw-Code/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jigsaw-Code/subscriptions","organizations_url":"https://api.github.com/users/Jigsaw-Code/orgs","repos_url":"https://api.github.com/users/Jigsaw-Code/repos","events_url":"https://api.github.com/users/Jigsaw-Code/events{/privacy}","received_events_url":"https://api.github.com/users/Jigsaw-Code/received_events","type":"Organization","site_admin":false},"repo":{"id":131884789,"node_id":"MDEwOlJlcG9zaXRvcnkxMzE4ODQ3ODk=","name":"intra","full_name":"Jigsaw-Code/intra","owner":{"login":"Jigsaw-Code","id":19845815,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5ODQ1ODE1","avatar_url":"https://avatars0.githubusercontent.com/u/19845815?v=4","gravatar_id":"","url":"https://api.github.com/users/Jigsaw-Code","html_url":"https://github.com/Jigsaw-Code","followers_url":"https://api.github.com/users/Jigsaw-Code/followers","following_url":"https://api.github.com/users/Jigsaw-Code/following{/other_user}","gists_url":"https://api.github.com/users/Jigsaw-Code/gists{/gist_id}","starred_url":"https://api.github.com/users/Jigsaw-Code/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jigsaw-Code/subscriptions","organizations_url":"https://api.github.com/users/Jigsaw-Code/orgs","repos_url":"https://api.github.com/users/Jigsaw-Code/repos","events_url":"https://api.github.com/users/Jigsaw-Code/events{/privacy}","received_events_url":"https://api.github.com/users/Jigsaw-Code/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Jigsaw-Code/intra","description":"An experimental tool that allows you to test new DNS-over-HTTPS services on Android","fork":false,"url":"https://api.github.com/repos/Jigsaw-Code/intra","forks_url":"https://api.github.com/repos/Jigsaw-Code/intra/forks","keys_url":"https://api.github.com/repos/Jigsaw-Code/intra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Jigsaw-Code/intra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Jigsaw-Code/intra/teams","hooks_url":"https://api.github.com/repos/Jigsaw-Code/intra/hooks","issue_events_url":"https://api.github.com/repos/Jigsaw-Code/intra/issues/events{/number}","events_url":"https://api.github.com/repos/Jigsaw-Code/intra/events","assignees_url":"https://api.github.com/repos/Jigsaw-Code/intra/assignees{/user}","branches_url":"https://api.github.com/repos/Jigsaw-Code/intra/branches{/branch}","tags_url":"https://api.github.com/repos/Jigsaw-Code/intra/tags","blobs_url":"https://api.github.com/repos/Jigsaw-Code/intra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Jigsaw-Code/intra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Jigsaw-Code/intra/git/refs{/sha}","trees_url":"https://api.github.com/repos/Jigsaw-Code/intra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Jigsaw-Code/intra/statuses/{sha}","languages_url":"https://api.github.com/repos/Jigsaw-Code/intra/languages","stargazers_url":"https://api.github.com/repos/Jigsaw-Code/intra/stargazers","contributors_url":"https://api.github.com/repos/Jigsaw-Code/intra/contributors","subscribers_url":"https://api.github.com/repos/Jigsaw-Code/intra/subscribers","subscription_url":"https://api.github.com/repos/Jigsaw-Code/intra/subscription","commits_url":"https://api.github.com/repos/Jigsaw-Code/intra/commits{/sha}","git_commits_url":"https://api.github.com/repos/Jigsaw-Code/intra/git/commits{/sha}","comments_url":"https://api.github.com/repos/Jigsaw-Code/intra/comments{/number}","issue_comment_url":"https://api.github.com/repos/Jigsaw-Code/intra/issues/comments{/number}","contents_url":"https://api.github.com/repos/Jigsaw-Code/intra/contents/{+path}","compare_url":"https://api.github.com/repos/Jigsaw-Code/intra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Jigsaw-Code/intra/merges","archive_url":"https://api.github.com/repos/Jigsaw-Code/intra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Jigsaw-Code/intra/downloads","issues_url":"https://api.github.com/repos/Jigsaw-Code/intra/issues{/number}","pulls_url":"https://api.github.com/repos/Jigsaw-Code/intra/pulls{/number}","milestones_url":"https://api.github.com/repos/Jigsaw-Code/intra/milestones{/number}","notifications_url":"https://api.github.com/repos/Jigsaw-Code/intra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Jigsaw-Code/intra/labels{/name}","releases_url":"https://api.github.com/repos/Jigsaw-Code/intra/releases{/id}","deployments_url":"https://api.github.com/repos/Jigsaw-Code/intra/deployments","created_at":"2018-05-02T17:32:48Z","updated_at":"2018-08-01T15:30:34Z","pushed_at":"2018-08-01T18:06:17Z","git_url":"git://github.com/Jigsaw-Code/intra.git","ssh_url":"[email protected]:Jigsaw-Code/intra.git","clone_url":"https://github.com/Jigsaw-Code/intra.git","svn_url":"https://github.com/Jigsaw-Code/intra","homepage":null,"size":7238,"stargazers_count":47,"watchers_count":47,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":11,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":4,"open_issues":11,"watchers":47,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Jigsaw-Code/intra/pulls/26"},"html":{"href":"https://github.com/Jigsaw-Code/intra/pull/26"},"issue":{"href":"https://api.github.com/repos/Jigsaw-Code/intra/issues/26"},"comments":{"href":"https://api.github.com/repos/Jigsaw-Code/intra/issues/26/comments"},"review_comments":{"href":"https://api.github.com/repos/Jigsaw-Code/intra/pulls/26/comments"},"review_comment":{"href":"https://api.github.com/repos/Jigsaw-Code/intra/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Jigsaw-Code/intra/pulls/26/commits"},"statuses":{"href":"https://api.github.com/repos/Jigsaw-Code/intra/statuses/b235ba621f4071b5e46f3782ca5981af38e06cdf"}},"author_association":"CONTRIBUTOR"}} | {
"id": 131884789,
"name": "Jigsaw-Code/intra",
"url": "https://api.github.com/repos/Jigsaw-Code/intra"
} | {
"id": 2380566,
"login": "cjhenck",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2380566?",
"url": "https://api.github.com/users/cjhenck"
} | {
"id": 19845815,
"login": "Jigsaw-Code",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/19845815?",
"url": "https://api.github.com/orgs/Jigsaw-Code"
} | 2018-08-01T21:23:08 | 8053094512 | {"actor":{"display_login":"cjhenck"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/infostellarinc/starcoder/pulls/comments/180279892","pull_request_review_id":110673063,"id":180279892,"diff_hunk":"@@ -587,6 +618,49 @@\n <value>samp_rate</value>\n </param>\n </block>\n+ <block>\n+ <key>starcoder_complex_to_msg_c</key>\n+ <param>\n+ <key>alias</key>\n+ <value></value>\n+ </param>\n+ <param>\n+ <key>comment</key>\n+ <value></value>\n+ </param>\n+ <param>\n+ <key>affinity</key>\n+ <value></value>\n+ </param>\n+ <param>\n+ <key>_enabled</key>\n+ <value>True</value>\n+ </param>\n+ <param>\n+ <key>_coordinate</key>\n+ <value>(752, 340)</value>\n+ </param>\n+ <param>\n+ <key>_rotation</key>\n+ <value>0</value>\n+ </param>\n+ <param>\n+ <key>id</key>\n+ <value>starcoder_complex_to_msg_c_0</value>\n+ </param>\n+ <param>\n+ <key>maxoutbuf</key>\n+ <value>0</value>\n+ </param>\n+ <param>\n+ <key>minoutbuf</key>\n+ <value>0</value>\n+ </param>\n+ <param>\n+ <key>num_items</key>\n+ <value>131072</value>","path":"flowgraphs/test.grc","position":91,"original_position":91,"commit_id":"c8e5fdcc6cf325d8bef875a5f009cc583a149b39","original_commit_id":"c8e5fdcc6cf325d8bef875a5f009cc583a149b39","user":{"login":"gavinreaney","id":34636113,"avatar_url":"https://avatars2.githubusercontent.com/u/34636113?v=4","gravatar_id":"","url":"https://api.github.com/users/gavinreaney","html_url":"https://github.com/gavinreaney","followers_url":"https://api.github.com/users/gavinreaney/followers","following_url":"https://api.github.com/users/gavinreaney/following{/other_user}","gists_url":"https://api.github.com/users/gavinreaney/gists{/gist_id}","starred_url":"https://api.github.com/users/gavinreaney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gavinreaney/subscriptions","organizations_url":"https://api.github.com/users/gavinreaney/orgs","repos_url":"https://api.github.com/users/gavinreaney/repos","events_url":"https://api.github.com/users/gavinreaney/events{/privacy}","received_events_url":"https://api.github.com/users/gavinreaney/received_events","type":"User","site_admin":false},"body":"What's the significance of this value? (I mean how was it chosen and would we ever want to change it?).","created_at":"2018-04-10T02:10:55Z","updated_at":"2018-04-10T02:26:37Z","html_url":"https://github.com/infostellarinc/starcoder/pull/25#discussion_r180279892","pull_request_url":"https://api.github.com/repos/infostellarinc/starcoder/pulls/25","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/infostellarinc/starcoder/pulls/comments/180279892"},"html":{"href":"https://github.com/infostellarinc/starcoder/pull/25#discussion_r180279892"},"pull_request":{"href":"https://api.github.com/repos/infostellarinc/starcoder/pulls/25"}}},"pull_request":{"url":"https://api.github.com/repos/infostellarinc/starcoder/pulls/25","id":180290556,"html_url":"https://github.com/infostellarinc/starcoder/pull/25","diff_url":"https://github.com/infostellarinc/starcoder/pull/25.diff","patch_url":"https://github.com/infostellarinc/starcoder/pull/25.patch","issue_url":"https://api.github.com/repos/infostellarinc/starcoder/issues/25","number":25,"state":"open","locked":false,"title":"implementation of complex_to_msg_c block","user":{"login":"reiinakano","id":18363734,"avatar_url":"https://avatars0.githubusercontent.com/u/18363734?v=4","gravatar_id":"","url":"https://api.github.com/users/reiinakano","html_url":"https://github.com/reiinakano","followers_url":"https://api.github.com/users/reiinakano/followers","following_url":"https://api.github.com/users/reiinakano/following{/other_user}","gists_url":"https://api.github.com/users/reiinakano/gists{/gist_id}","starred_url":"https://api.github.com/users/reiinakano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reiinakano/subscriptions","organizations_url":"https://api.github.com/users/reiinakano/orgs","repos_url":"https://api.github.com/users/reiinakano/repos","events_url":"https://api.github.com/users/reiinakano/events{/privacy}","received_events_url":"https://api.github.com/users/reiinakano/received_events","type":"User","site_admin":false},"body":"This GNURadio block monitors an incoming stream of complex floats and sends them as a PMT message when `num_items` items are received. This is so we can still send partial.bin files to GCP\r\n\r\nOne thing of note that is left as a TODO is that this implementation may drop up to `num_items - 1` items at the very end when the flowgraph is closed. For our use case, this means up to 1MB of data (since we will set it to send 1MB messages). \r\n\r\nFrom calculations, 1MB of data is equivalent to ~1.165 seconds of data at the very end for a 112500Hz sample rate. `(1024^2 bytes) / (8 bytes/sample) / (112500samples/sec) = ~1.165secs`\r\n\r\nAt higher sampling rates (>UHF), the amount of time dropped will be even lower. Those last few milliseconds aren't likely to hold any useful information since the satellite will be gone by then. Note that this only affects the partial IQ data this block sends. ","created_at":"2018-04-09T12:04:23Z","updated_at":"2018-04-10T02:26:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6a5941bcea8433686841b1e1f734933ab4dad7e8","assignee":null,"assignees":[],"requested_reviewers":[{"login":"vaelen","id":154691,"avatar_url":"https://avatars2.githubusercontent.com/u/154691?v=4","gravatar_id":"","url":"https://api.github.com/users/vaelen","html_url":"https://github.com/vaelen","followers_url":"https://api.github.com/users/vaelen/followers","following_url":"https://api.github.com/users/vaelen/following{/other_user}","gists_url":"https://api.github.com/users/vaelen/gists{/gist_id}","starred_url":"https://api.github.com/users/vaelen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vaelen/subscriptions","organizations_url":"https://api.github.com/users/vaelen/orgs","repos_url":"https://api.github.com/users/vaelen/repos","events_url":"https://api.github.com/users/vaelen/events{/privacy}","received_events_url":"https://api.github.com/users/vaelen/received_events","type":"User","site_admin":false},{"login":"anuraaga","id":198344,"avatar_url":"https://avatars0.githubusercontent.com/u/198344?v=4","gravatar_id":"","url":"https://api.github.com/users/anuraaga","html_url":"https://github.com/anuraaga","followers_url":"https://api.github.com/users/anuraaga/followers","following_url":"https://api.github.com/users/anuraaga/following{/other_user}","gists_url":"https://api.github.com/users/anuraaga/gists{/gist_id}","starred_url":"https://api.github.com/users/anuraaga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anuraaga/subscriptions","organizations_url":"https://api.github.com/users/anuraaga/orgs","repos_url":"https://api.github.com/users/anuraaga/repos","events_url":"https://api.github.com/users/anuraaga/events{/privacy}","received_events_url":"https://api.github.com/users/anuraaga/received_events","type":"User","site_admin":false},{"login":"koncha99","id":7948053,"avatar_url":"https://avatars0.githubusercontent.com/u/7948053?v=4","gravatar_id":"","url":"https://api.github.com/users/koncha99","html_url":"https://github.com/koncha99","followers_url":"https://api.github.com/users/koncha99/followers","following_url":"https://api.github.com/users/koncha99/following{/other_user}","gists_url":"https://api.github.com/users/koncha99/gists{/gist_id}","starred_url":"https://api.github.com/users/koncha99/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/koncha99/subscriptions","organizations_url":"https://api.github.com/users/koncha99/orgs","repos_url":"https://api.github.com/users/koncha99/repos","events_url":"https://api.github.com/users/koncha99/events{/privacy}","received_events_url":"https://api.github.com/users/koncha99/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/infostellarinc/starcoder/pulls/25/commits","review_comments_url":"https://api.github.com/repos/infostellarinc/starcoder/pulls/25/comments","review_comment_url":"https://api.github.com/repos/infostellarinc/starcoder/pulls/comments{/number}","comments_url":"https://api.github.com/repos/infostellarinc/starcoder/issues/25/comments","statuses_url":"https://api.github.com/repos/infostellarinc/starcoder/statuses/c8e5fdcc6cf325d8bef875a5f009cc583a149b39","head":{"label":"reiinakano:stream-to-message","ref":"stream-to-message","sha":"c8e5fdcc6cf325d8bef875a5f009cc583a149b39","user":{"login":"reiinakano","id":18363734,"avatar_url":"https://avatars0.githubusercontent.com/u/18363734?v=4","gravatar_id":"","url":"https://api.github.com/users/reiinakano","html_url":"https://github.com/reiinakano","followers_url":"https://api.github.com/users/reiinakano/followers","following_url":"https://api.github.com/users/reiinakano/following{/other_user}","gists_url":"https://api.github.com/users/reiinakano/gists{/gist_id}","starred_url":"https://api.github.com/users/reiinakano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reiinakano/subscriptions","organizations_url":"https://api.github.com/users/reiinakano/orgs","repos_url":"https://api.github.com/users/reiinakano/repos","events_url":"https://api.github.com/users/reiinakano/events{/privacy}","received_events_url":"https://api.github.com/users/reiinakano/received_events","type":"User","site_admin":false},"repo":{"id":122559290,"name":"starcoder","full_name":"reiinakano/starcoder","owner":{"login":"reiinakano","id":18363734,"avatar_url":"https://avatars0.githubusercontent.com/u/18363734?v=4","gravatar_id":"","url":"https://api.github.com/users/reiinakano","html_url":"https://github.com/reiinakano","followers_url":"https://api.github.com/users/reiinakano/followers","following_url":"https://api.github.com/users/reiinakano/following{/other_user}","gists_url":"https://api.github.com/users/reiinakano/gists{/gist_id}","starred_url":"https://api.github.com/users/reiinakano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reiinakano/subscriptions","organizations_url":"https://api.github.com/users/reiinakano/orgs","repos_url":"https://api.github.com/users/reiinakano/repos","events_url":"https://api.github.com/users/reiinakano/events{/privacy}","received_events_url":"https://api.github.com/users/reiinakano/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/reiinakano/starcoder","description":"A server to read/write data from/to the stars, written in Go.","fork":true,"url":"https://api.github.com/repos/reiinakano/starcoder","forks_url":"https://api.github.com/repos/reiinakano/starcoder/forks","keys_url":"https://api.github.com/repos/reiinakano/starcoder/keys{/key_id}","collaborators_url":"https://api.github.com/repos/reiinakano/starcoder/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/reiinakano/starcoder/teams","hooks_url":"https://api.github.com/repos/reiinakano/starcoder/hooks","issue_events_url":"https://api.github.com/repos/reiinakano/starcoder/issues/events{/number}","events_url":"https://api.github.com/repos/reiinakano/starcoder/events","assignees_url":"https://api.github.com/repos/reiinakano/starcoder/assignees{/user}","branches_url":"https://api.github.com/repos/reiinakano/starcoder/branches{/branch}","tags_url":"https://api.github.com/repos/reiinakano/starcoder/tags","blobs_url":"https://api.github.com/repos/reiinakano/starcoder/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/reiinakano/starcoder/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/reiinakano/starcoder/git/refs{/sha}","trees_url":"https://api.github.com/repos/reiinakano/starcoder/git/trees{/sha}","statuses_url":"https://api.github.com/repos/reiinakano/starcoder/statuses/{sha}","languages_url":"https://api.github.com/repos/reiinakano/starcoder/languages","stargazers_url":"https://api.github.com/repos/reiinakano/starcoder/stargazers","contributors_url":"https://api.github.com/repos/reiinakano/starcoder/contributors","subscribers_url":"https://api.github.com/repos/reiinakano/starcoder/subscribers","subscription_url":"https://api.github.com/repos/reiinakano/starcoder/subscription","commits_url":"https://api.github.com/repos/reiinakano/starcoder/commits{/sha}","git_commits_url":"https://api.github.com/repos/reiinakano/starcoder/git/commits{/sha}","comments_url":"https://api.github.com/repos/reiinakano/starcoder/comments{/number}","issue_comment_url":"https://api.github.com/repos/reiinakano/starcoder/issues/comments{/number}","contents_url":"https://api.github.com/repos/reiinakano/starcoder/contents/{+path}","compare_url":"https://api.github.com/repos/reiinakano/starcoder/compare/{base}...{head}","merges_url":"https://api.github.com/repos/reiinakano/starcoder/merges","archive_url":"https://api.github.com/repos/reiinakano/starcoder/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/reiinakano/starcoder/downloads","issues_url":"https://api.github.com/repos/reiinakano/starcoder/issues{/number}","pulls_url":"https://api.github.com/repos/reiinakano/starcoder/pulls{/number}","milestones_url":"https://api.github.com/repos/reiinakano/starcoder/milestones{/number}","notifications_url":"https://api.github.com/repos/reiinakano/starcoder/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/reiinakano/starcoder/labels{/name}","releases_url":"https://api.github.com/repos/reiinakano/starcoder/releases{/id}","deployments_url":"https://api.github.com/repos/reiinakano/starcoder/deployments","created_at":"2018-02-23T01:47:27Z","updated_at":"2018-02-22T11:23:14Z","pushed_at":"2018-04-09T12:04:25Z","git_url":"git://github.com/reiinakano/starcoder.git","ssh_url":"[email protected]:reiinakano/starcoder.git","clone_url":"https://github.com/reiinakano/starcoder.git","svn_url":"https://github.com/reiinakano/starcoder","homepage":null,"size":362,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"infostellarinc:master","ref":"master","sha":"e3c1cf94f2a731f868900d62c966e78d142c0abe","user":{"login":"infostellarinc","id":19871194,"avatar_url":"https://avatars1.githubusercontent.com/u/19871194?v=4","gravatar_id":"","url":"https://api.github.com/users/infostellarinc","html_url":"https://github.com/infostellarinc","followers_url":"https://api.github.com/users/infostellarinc/followers","following_url":"https://api.github.com/users/infostellarinc/following{/other_user}","gists_url":"https://api.github.com/users/infostellarinc/gists{/gist_id}","starred_url":"https://api.github.com/users/infostellarinc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/infostellarinc/subscriptions","organizations_url":"https://api.github.com/users/infostellarinc/orgs","repos_url":"https://api.github.com/users/infostellarinc/repos","events_url":"https://api.github.com/users/infostellarinc/events{/privacy}","received_events_url":"https://api.github.com/users/infostellarinc/received_events","type":"Organization","site_admin":false},"repo":{"id":122469333,"name":"starcoder","full_name":"infostellarinc/starcoder","owner":{"login":"infostellarinc","id":19871194,"avatar_url":"https://avatars1.githubusercontent.com/u/19871194?v=4","gravatar_id":"","url":"https://api.github.com/users/infostellarinc","html_url":"https://github.com/infostellarinc","followers_url":"https://api.github.com/users/infostellarinc/followers","following_url":"https://api.github.com/users/infostellarinc/following{/other_user}","gists_url":"https://api.github.com/users/infostellarinc/gists{/gist_id}","starred_url":"https://api.github.com/users/infostellarinc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/infostellarinc/subscriptions","organizations_url":"https://api.github.com/users/infostellarinc/orgs","repos_url":"https://api.github.com/users/infostellarinc/repos","events_url":"https://api.github.com/users/infostellarinc/events{/privacy}","received_events_url":"https://api.github.com/users/infostellarinc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/infostellarinc/starcoder","description":"A server to read/write data from/to the stars, written in Go.","fork":false,"url":"https://api.github.com/repos/infostellarinc/starcoder","forks_url":"https://api.github.com/repos/infostellarinc/starcoder/forks","keys_url":"https://api.github.com/repos/infostellarinc/starcoder/keys{/key_id}","collaborators_url":"https://api.github.com/repos/infostellarinc/starcoder/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/infostellarinc/starcoder/teams","hooks_url":"https://api.github.com/repos/infostellarinc/starcoder/hooks","issue_events_url":"https://api.github.com/repos/infostellarinc/starcoder/issues/events{/number}","events_url":"https://api.github.com/repos/infostellarinc/starcoder/events","assignees_url":"https://api.github.com/repos/infostellarinc/starcoder/assignees{/user}","branches_url":"https://api.github.com/repos/infostellarinc/starcoder/branches{/branch}","tags_url":"https://api.github.com/repos/infostellarinc/starcoder/tags","blobs_url":"https://api.github.com/repos/infostellarinc/starcoder/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/infostellarinc/starcoder/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/infostellarinc/starcoder/git/refs{/sha}","trees_url":"https://api.github.com/repos/infostellarinc/starcoder/git/trees{/sha}","statuses_url":"https://api.github.com/repos/infostellarinc/starcoder/statuses/{sha}","languages_url":"https://api.github.com/repos/infostellarinc/starcoder/languages","stargazers_url":"https://api.github.com/repos/infostellarinc/starcoder/stargazers","contributors_url":"https://api.github.com/repos/infostellarinc/starcoder/contributors","subscribers_url":"https://api.github.com/repos/infostellarinc/starcoder/subscribers","subscription_url":"https://api.github.com/repos/infostellarinc/starcoder/subscription","commits_url":"https://api.github.com/repos/infostellarinc/starcoder/commits{/sha}","git_commits_url":"https://api.github.com/repos/infostellarinc/starcoder/git/commits{/sha}","comments_url":"https://api.github.com/repos/infostellarinc/starcoder/comments{/number}","issue_comment_url":"https://api.github.com/repos/infostellarinc/starcoder/issues/comments{/number}","contents_url":"https://api.github.com/repos/infostellarinc/starcoder/contents/{+path}","compare_url":"https://api.github.com/repos/infostellarinc/starcoder/compare/{base}...{head}","merges_url":"https://api.github.com/repos/infostellarinc/starcoder/merges","archive_url":"https://api.github.com/repos/infostellarinc/starcoder/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/infostellarinc/starcoder/downloads","issues_url":"https://api.github.com/repos/infostellarinc/starcoder/issues{/number}","pulls_url":"https://api.github.com/repos/infostellarinc/starcoder/pulls{/number}","milestones_url":"https://api.github.com/repos/infostellarinc/starcoder/milestones{/number}","notifications_url":"https://api.github.com/repos/infostellarinc/starcoder/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/infostellarinc/starcoder/labels{/name}","releases_url":"https://api.github.com/repos/infostellarinc/starcoder/releases{/id}","deployments_url":"https://api.github.com/repos/infostellarinc/starcoder/deployments","created_at":"2018-02-22T11:23:14Z","updated_at":"2018-04-02T02:33:44Z","pushed_at":"2018-04-09T12:04:27Z","git_url":"git://github.com/infostellarinc/starcoder.git","ssh_url":"[email protected]:infostellarinc/starcoder.git","clone_url":"https://github.com/infostellarinc/starcoder.git","svn_url":"https://github.com/infostellarinc/starcoder","homepage":null,"size":327,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":3,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/infostellarinc/starcoder/pulls/25"},"html":{"href":"https://github.com/infostellarinc/starcoder/pull/25"},"issue":{"href":"https://api.github.com/repos/infostellarinc/starcoder/issues/25"},"comments":{"href":"https://api.github.com/repos/infostellarinc/starcoder/issues/25/comments"},"review_comments":{"href":"https://api.github.com/repos/infostellarinc/starcoder/pulls/25/comments"},"review_comment":{"href":"https://api.github.com/repos/infostellarinc/starcoder/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/infostellarinc/starcoder/pulls/25/commits"},"statuses":{"href":"https://api.github.com/repos/infostellarinc/starcoder/statuses/c8e5fdcc6cf325d8bef875a5f009cc583a149b39"}},"author_association":"CONTRIBUTOR"}} | {
"id": 122469333,
"name": "infostellarinc/starcoder",
"url": "https://api.github.com/repos/infostellarinc/starcoder"
} | {
"id": 34636113,
"login": "gavinreaney",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/34636113?",
"url": "https://api.github.com/users/gavinreaney"
} | {
"id": 19871194,
"login": "infostellarinc",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/19871194?",
"url": "https://api.github.com/orgs/infostellarinc"
} | 2018-04-10T02:10:55 | 7504237366 | {"actor":{"display_login":"gavinreaney"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/chanzuckerberg/idseq-web/pulls/comments/212684710","pull_request_review_id":149373668,"id":212684710,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMjY4NDcxMA==","diff_hunk":"@@ -120,27 +137,41 @@ def set_phylo_tree\n assert_access\n end\n \n- def sample_details_json(pipeline_runs, taxid)\n+ def sample_details_json(pipeline_run_ids, taxid)\n+ return [] if pipeline_run_ids.blank?\n+\n # Retrieve information for displaying the tree's sample list.\n # Expose it as an array of hashes containing\n # - sample name\n # - project id and name\n # - pipeline run id to be used for the sample\n- # - number of reads matching the specified taxid in NT\n- return [] if pipeline_runs.blank?\n- Sample.connection.select_all(\"\n- select pipeline_runs_samples_projects.name,\n- pipeline_runs_samples_projects.project_id,\n- pipeline_runs_samples_projects.project_name,\n- pipeline_runs_samples_projects.pipeline_run_id,\n- taxon_counts.count as taxid_nt_reads\n- from (select pipeline_runs.id as pipeline_run_id, samples.name, samples.project_id, projects.name as project_name\n- from ((pipeline_runs inner join samples on pipeline_runs.sample_id = samples.id)\n- inner join projects on samples.project_id = projects.id)\n- where pipeline_runs.id in (#{pipeline_runs.pluck(:id).join(',')})) pipeline_runs_samples_projects\n- inner join taxon_counts\n- on taxon_counts.pipeline_run_id = pipeline_runs_samples_projects.pipeline_run_id\n- where taxon_counts.tax_id = #{taxid} and taxon_counts.count_type = 'NT'\n+ samples_projects = Sample.connection.select_all(\"\n+ select\n+ pipeline_runs_samples_projects.name,\n+ pipeline_runs_samples_projects.project_id,\n+ pipeline_runs_samples_projects.project_name,\n+ pipeline_runs_samples_projects.pipeline_run_id\n+ from\n+ (select\n+ pipeline_runs.id as pipeline_run_id,\n+ samples.name,\n+ samples.project_id,\n+ projects.name as project_name\n+ from\n+ ((pipeline_runs inner join samples on pipeline_runs.sample_id = samples.id)\n+ inner join projects on samples.project_id = projects.id)\n+ where pipeline_runs.id in (#{pipeline_run_ids.join(',')})) pipeline_runs_samples_projects\n \").to_hash\n+\n+ # Also add:\n+ # - number of reads matching the specified taxid in NT\n+ # Do not include the query on taxon_counts in the previous query above using a join,\n+ # because the taxon_counts table is large.\n+ taxon_counts = TaxonCount.where(pipeline_run_id: pipeline_run_ids).where(tax_id: taxid).where(count_type: 'NT').index_by(&:pipeline_run_id)","path":"app/controllers/phylo_trees_controller.rb","position":118,"original_position":118,"commit_id":"898279be0faef26b38e92a04161180ff3488f5a2","original_commit_id":"898279be0faef26b38e92a04161180ff3488f5a2","user":{"login":"cdebourcy","id":16944816,"node_id":"MDQ6VXNlcjE2OTQ0ODE2","avatar_url":"https://avatars2.githubusercontent.com/u/16944816?v=4","gravatar_id":"","url":"https://api.github.com/users/cdebourcy","html_url":"https://github.com/cdebourcy","followers_url":"https://api.github.com/users/cdebourcy/followers","following_url":"https://api.github.com/users/cdebourcy/following{/other_user}","gists_url":"https://api.github.com/users/cdebourcy/gists{/gist_id}","starred_url":"https://api.github.com/users/cdebourcy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdebourcy/subscriptions","organizations_url":"https://api.github.com/users/cdebourcy/orgs","repos_url":"https://api.github.com/users/cdebourcy/repos","events_url":"https://api.github.com/users/cdebourcy/events{/privacy}","received_events_url":"https://api.github.com/users/cdebourcy/received_events","type":"User","site_admin":false},"body":"https://github.com/chanzuckerberg/idseq-web/blob/master/db/schema.rb#L349","created_at":"2018-08-24T16:32:45Z","updated_at":"2018-08-24T16:32:45Z","html_url":"https://github.com/chanzuckerberg/idseq-web/pull/1444#discussion_r212684710","pull_request_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/pulls/1444","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/chanzuckerberg/idseq-web/pulls/comments/212684710"},"html":{"href":"https://github.com/chanzuckerberg/idseq-web/pull/1444#discussion_r212684710"},"pull_request":{"href":"https://api.github.com/repos/chanzuckerberg/idseq-web/pulls/1444"}},"in_reply_to_id":212653995},"pull_request":{"url":"https://api.github.com/repos/chanzuckerberg/idseq-web/pulls/1444","id":210534167,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwNTM0MTY3","html_url":"https://github.com/chanzuckerberg/idseq-web/pull/1444","diff_url":"https://github.com/chanzuckerberg/idseq-web/pull/1444.diff","patch_url":"https://github.com/chanzuckerberg/idseq-web/pull/1444.patch","issue_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/issues/1444","number":1444,"state":"open","locked":false,"title":"Charles/taxon lookup perf","user":{"login":"cdebourcy","id":16944816,"node_id":"MDQ6VXNlcjE2OTQ0ODE2","avatar_url":"https://avatars2.githubusercontent.com/u/16944816?v=4","gravatar_id":"","url":"https://api.github.com/users/cdebourcy","html_url":"https://github.com/cdebourcy","followers_url":"https://api.github.com/users/cdebourcy/followers","following_url":"https://api.github.com/users/cdebourcy/following{/other_user}","gists_url":"https://api.github.com/users/cdebourcy/gists{/gist_id}","starred_url":"https://api.github.com/users/cdebourcy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdebourcy/subscriptions","organizations_url":"https://api.github.com/users/cdebourcy/orgs","repos_url":"https://api.github.com/users/cdebourcy/repos","events_url":"https://api.github.com/users/cdebourcy/events{/privacy}","received_events_url":"https://api.github.com/users/cdebourcy/received_events","type":"User","site_admin":false},"body":"Speed up phylo_tree related pages.\r\nAlso, add an index to taxon_lineages to speed up the report page.","created_at":"2018-08-23T18:20:10Z","updated_at":"2018-08-24T16:32:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f5b04a272b6ab14e6c7dd0c05d6d29ba9a2367c3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/pulls/1444/commits","review_comments_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/pulls/1444/comments","review_comment_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/pulls/comments{/number}","comments_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/issues/1444/comments","statuses_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/statuses/898279be0faef26b38e92a04161180ff3488f5a2","head":{"label":"chanzuckerberg:charles/taxon-lookup-perf","ref":"charles/taxon-lookup-perf","sha":"898279be0faef26b38e92a04161180ff3488f5a2","user":{"login":"chanzuckerberg","id":19917299,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5OTE3Mjk5","avatar_url":"https://avatars2.githubusercontent.com/u/19917299?v=4","gravatar_id":"","url":"https://api.github.com/users/chanzuckerberg","html_url":"https://github.com/chanzuckerberg","followers_url":"https://api.github.com/users/chanzuckerberg/followers","following_url":"https://api.github.com/users/chanzuckerberg/following{/other_user}","gists_url":"https://api.github.com/users/chanzuckerberg/gists{/gist_id}","starred_url":"https://api.github.com/users/chanzuckerberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chanzuckerberg/subscriptions","organizations_url":"https://api.github.com/users/chanzuckerberg/orgs","repos_url":"https://api.github.com/users/chanzuckerberg/repos","events_url":"https://api.github.com/users/chanzuckerberg/events{/privacy}","received_events_url":"https://api.github.com/users/chanzuckerberg/received_events","type":"Organization","site_admin":false},"repo":{"id":99148438,"node_id":"MDEwOlJlcG9zaXRvcnk5OTE0ODQzOA==","name":"idseq-web","full_name":"chanzuckerberg/idseq-web","owner":{"login":"chanzuckerberg","id":19917299,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5OTE3Mjk5","avatar_url":"https://avatars2.githubusercontent.com/u/19917299?v=4","gravatar_id":"","url":"https://api.github.com/users/chanzuckerberg","html_url":"https://github.com/chanzuckerberg","followers_url":"https://api.github.com/users/chanzuckerberg/followers","following_url":"https://api.github.com/users/chanzuckerberg/following{/other_user}","gists_url":"https://api.github.com/users/chanzuckerberg/gists{/gist_id}","starred_url":"https://api.github.com/users/chanzuckerberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chanzuckerberg/subscriptions","organizations_url":"https://api.github.com/users/chanzuckerberg/orgs","repos_url":"https://api.github.com/users/chanzuckerberg/repos","events_url":"https://api.github.com/users/chanzuckerberg/events{/privacy}","received_events_url":"https://api.github.com/users/chanzuckerberg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/chanzuckerberg/idseq-web","description":"Infectious Disease Sequencing Platform","fork":false,"url":"https://api.github.com/repos/chanzuckerberg/idseq-web","forks_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/forks","keys_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/teams","hooks_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/hooks","issue_events_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/issues/events{/number}","events_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/events","assignees_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/assignees{/user}","branches_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/branches{/branch}","tags_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/tags","blobs_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/git/refs{/sha}","trees_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/statuses/{sha}","languages_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/languages","stargazers_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/stargazers","contributors_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/contributors","subscribers_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/subscribers","subscription_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/subscription","commits_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/commits{/sha}","git_commits_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/git/commits{/sha}","comments_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/comments{/number}","issue_comment_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/issues/comments{/number}","contents_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/contents/{+path}","compare_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/merges","archive_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/downloads","issues_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/issues{/number}","pulls_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/pulls{/number}","milestones_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/milestones{/number}","notifications_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/labels{/name}","releases_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/releases{/id}","deployments_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/deployments","created_at":"2017-08-02T18:24:03Z","updated_at":"2018-08-22T18:16:39Z","pushed_at":"2018-08-24T01:03:56Z","git_url":"git://github.com/chanzuckerberg/idseq-web.git","ssh_url":"[email protected]:chanzuckerberg/idseq-web.git","clone_url":"https://github.com/chanzuckerberg/idseq-web.git","svn_url":"https://github.com/chanzuckerberg/idseq-web","homepage":"https://idseq.net/","size":47301,"stargazers_count":9,"watchers_count":9,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":5,"watchers":9,"default_branch":"master"}},"base":{"label":"chanzuckerberg:master","ref":"master","sha":"82649f63f00fe616f412eb3d95b5dd2e156561fd","user":{"login":"chanzuckerberg","id":19917299,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5OTE3Mjk5","avatar_url":"https://avatars2.githubusercontent.com/u/19917299?v=4","gravatar_id":"","url":"https://api.github.com/users/chanzuckerberg","html_url":"https://github.com/chanzuckerberg","followers_url":"https://api.github.com/users/chanzuckerberg/followers","following_url":"https://api.github.com/users/chanzuckerberg/following{/other_user}","gists_url":"https://api.github.com/users/chanzuckerberg/gists{/gist_id}","starred_url":"https://api.github.com/users/chanzuckerberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chanzuckerberg/subscriptions","organizations_url":"https://api.github.com/users/chanzuckerberg/orgs","repos_url":"https://api.github.com/users/chanzuckerberg/repos","events_url":"https://api.github.com/users/chanzuckerberg/events{/privacy}","received_events_url":"https://api.github.com/users/chanzuckerberg/received_events","type":"Organization","site_admin":false},"repo":{"id":99148438,"node_id":"MDEwOlJlcG9zaXRvcnk5OTE0ODQzOA==","name":"idseq-web","full_name":"chanzuckerberg/idseq-web","owner":{"login":"chanzuckerberg","id":19917299,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5OTE3Mjk5","avatar_url":"https://avatars2.githubusercontent.com/u/19917299?v=4","gravatar_id":"","url":"https://api.github.com/users/chanzuckerberg","html_url":"https://github.com/chanzuckerberg","followers_url":"https://api.github.com/users/chanzuckerberg/followers","following_url":"https://api.github.com/users/chanzuckerberg/following{/other_user}","gists_url":"https://api.github.com/users/chanzuckerberg/gists{/gist_id}","starred_url":"https://api.github.com/users/chanzuckerberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chanzuckerberg/subscriptions","organizations_url":"https://api.github.com/users/chanzuckerberg/orgs","repos_url":"https://api.github.com/users/chanzuckerberg/repos","events_url":"https://api.github.com/users/chanzuckerberg/events{/privacy}","received_events_url":"https://api.github.com/users/chanzuckerberg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/chanzuckerberg/idseq-web","description":"Infectious Disease Sequencing Platform","fork":false,"url":"https://api.github.com/repos/chanzuckerberg/idseq-web","forks_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/forks","keys_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/teams","hooks_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/hooks","issue_events_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/issues/events{/number}","events_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/events","assignees_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/assignees{/user}","branches_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/branches{/branch}","tags_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/tags","blobs_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/git/refs{/sha}","trees_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/statuses/{sha}","languages_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/languages","stargazers_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/stargazers","contributors_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/contributors","subscribers_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/subscribers","subscription_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/subscription","commits_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/commits{/sha}","git_commits_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/git/commits{/sha}","comments_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/comments{/number}","issue_comment_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/issues/comments{/number}","contents_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/contents/{+path}","compare_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/merges","archive_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/downloads","issues_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/issues{/number}","pulls_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/pulls{/number}","milestones_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/milestones{/number}","notifications_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/labels{/name}","releases_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/releases{/id}","deployments_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/deployments","created_at":"2017-08-02T18:24:03Z","updated_at":"2018-08-22T18:16:39Z","pushed_at":"2018-08-24T01:03:56Z","git_url":"git://github.com/chanzuckerberg/idseq-web.git","ssh_url":"[email protected]:chanzuckerberg/idseq-web.git","clone_url":"https://github.com/chanzuckerberg/idseq-web.git","svn_url":"https://github.com/chanzuckerberg/idseq-web","homepage":"https://idseq.net/","size":47301,"stargazers_count":9,"watchers_count":9,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":5,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/chanzuckerberg/idseq-web/pulls/1444"},"html":{"href":"https://github.com/chanzuckerberg/idseq-web/pull/1444"},"issue":{"href":"https://api.github.com/repos/chanzuckerberg/idseq-web/issues/1444"},"comments":{"href":"https://api.github.com/repos/chanzuckerberg/idseq-web/issues/1444/comments"},"review_comments":{"href":"https://api.github.com/repos/chanzuckerberg/idseq-web/pulls/1444/comments"},"review_comment":{"href":"https://api.github.com/repos/chanzuckerberg/idseq-web/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/chanzuckerberg/idseq-web/pulls/1444/commits"},"statuses":{"href":"https://api.github.com/repos/chanzuckerberg/idseq-web/statuses/898279be0faef26b38e92a04161180ff3488f5a2"}},"author_association":"CONTRIBUTOR"}} | {
"id": 99148438,
"name": "chanzuckerberg/idseq-web",
"url": "https://api.github.com/repos/chanzuckerberg/idseq-web"
} | {
"id": 16944816,
"login": "cdebourcy",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/16944816?",
"url": "https://api.github.com/users/cdebourcy"
} | {
"id": 19917299,
"login": "chanzuckerberg",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/19917299?",
"url": "https://api.github.com/orgs/chanzuckerberg"
} | 2018-08-24T16:32:45 | 8164042475 | {"actor":{"display_login":"cdebourcy"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/m3db/m3metrics/pulls/comments/174905687","pull_request_review_id":104349482,"id":174905687,"diff_hunk":"@@ -0,0 +1,229 @@\n+// Copyright (c) 2018 Uber Technologies, Inc.\n+//\n+// Permission is hereby granted, free of charge, to any person obtaining a copy\n+// of this software and associated documentation files (the \"Software\"), to deal\n+// in the Software without restriction, including without limitation the rights\n+// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell\n+// copies of the Software, and to permit persons to whom the Software is\n+// furnished to do so, subject to the following conditions:\n+//\n+// The above copyright notice and this permission notice shall be included in\n+// all copies or substantial portions of the Software.\n+//\n+// THE SOFTWARE IS PROVIDED \"AS IS\", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR\n+// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,\n+// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE\n+// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER\n+// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,\n+// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN\n+// THE SOFTWARE.\n+\n+package models\n+\n+import (\n+\t\"sort\"\n+\n+\t\"github.com/m3db/m3metrics/policy\"\n+)\n+\n+// RollupTarget is a common json serializable rollup target.\n+type RollupTarget struct {\n+\tName string `json:\"name\" validate:\"required\"`\n+\tTags []string `json:\"tags\" validate:\"required\"`\n+\tPolicies []policy.Policy `json:\"policies\" validate:\"required\"`\n+}\n+\n+// RollupRule is a common json serializable rollup rule. Implements Sort interface.\n+type RollupRule struct {\n+\tID string `json:\"id,omitempty\"`\n+\tName string `json:\"name\" validate:\"required\"`\n+\tFilter string `json:\"filter\" validate:\"required\"`\n+\tTargets []RollupTarget `json:\"targets\" validate:\"required,dive,required\"`\n+\tCutoverMillis int64 `json:\"cutoverMillis,omitempty\"`\n+\tLastUpdatedBy string `json:\"lastUpdatedBy\"`\n+\tLastUpdatedAtMillis int64 `json:\"lastUpdatedAtMillis\"`\n+}\n+\n+// RollupTargetView is a human friendly representation of a rollup rule target at a given point in time.","path":"rules/models/rollup.go","position":47,"original_position":47,"commit_id":"676916c3952bae975e7d15f9ad429538afa16d27","original_commit_id":"99c0c810b3b49d8103a595be252c72fcec2ae005","user":{"login":"jskelcy","id":2659770,"avatar_url":"https://avatars3.githubusercontent.com/u/2659770?v=4","gravatar_id":"","url":"https://api.github.com/users/jskelcy","html_url":"https://github.com/jskelcy","followers_url":"https://api.github.com/users/jskelcy/followers","following_url":"https://api.github.com/users/jskelcy/following{/other_user}","gists_url":"https://api.github.com/users/jskelcy/gists{/gist_id}","starred_url":"https://api.github.com/users/jskelcy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jskelcy/subscriptions","organizations_url":"https://api.github.com/users/jskelcy/orgs","repos_url":"https://api.github.com/users/jskelcy/repos","events_url":"https://api.github.com/users/jskelcy/events{/privacy}","received_events_url":"https://api.github.com/users/jskelcy/received_events","type":"User","site_admin":false},"body":"For sure. I generally come from the school of putting all the public types at the top of the file, but that may not be the convention of the repo.","created_at":"2018-03-15T19:31:37Z","updated_at":"2018-03-15T19:31:37Z","html_url":"https://github.com/m3db/m3metrics/pull/134#discussion_r174905687","pull_request_url":"https://api.github.com/repos/m3db/m3metrics/pulls/134","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/m3db/m3metrics/pulls/comments/174905687"},"html":{"href":"https://github.com/m3db/m3metrics/pull/134#discussion_r174905687"},"pull_request":{"href":"https://api.github.com/repos/m3db/m3metrics/pulls/134"}},"in_reply_to_id":174901626},"pull_request":{"url":"https://api.github.com/repos/m3db/m3metrics/pulls/134","id":174520714,"html_url":"https://github.com/m3db/m3metrics/pull/134","diff_url":"https://github.com/m3db/m3metrics/pull/134.diff","patch_url":"https://github.com/m3db/m3metrics/pull/134.patch","issue_url":"https://api.github.com/repos/m3db/m3metrics/issues/134","number":134,"state":"open","locked":false,"title":"Added json serializable of rule structs","user":{"login":"jskelcy","id":2659770,"avatar_url":"https://avatars3.githubusercontent.com/u/2659770?v=4","gravatar_id":"","url":"https://api.github.com/users/jskelcy","html_url":"https://github.com/jskelcy","followers_url":"https://api.github.com/users/jskelcy/followers","following_url":"https://api.github.com/users/jskelcy/following{/other_user}","gists_url":"https://api.github.com/users/jskelcy/gists{/gist_id}","starred_url":"https://api.github.com/users/jskelcy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jskelcy/subscriptions","organizations_url":"https://api.github.com/users/jskelcy/orgs","repos_url":"https://api.github.com/users/jskelcy/repos","events_url":"https://api.github.com/users/jskelcy/events{/privacy}","received_events_url":"https://api.github.com/users/jskelcy/received_events","type":"User","site_admin":false},"body":"Various components of the M3 stack pass rules over HTTP/JSON but using the schema.* structs generated from protobuf would not be appropriate to serialize into JSON to pass between services. These files provide a JSON serializable struct, these structs also implement the sort interface.","created_at":"2018-03-12T23:20:07Z","updated_at":"2018-03-15T19:31:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0a17066505592bb7806384fcd3d820860e81a366","assignee":null,"assignees":[],"requested_reviewers":[{"login":"m-sandusky","id":13059735,"avatar_url":"https://avatars2.githubusercontent.com/u/13059735?v=4","gravatar_id":"","url":"https://api.github.com/users/m-sandusky","html_url":"https://github.com/m-sandusky","followers_url":"https://api.github.com/users/m-sandusky/followers","following_url":"https://api.github.com/users/m-sandusky/following{/other_user}","gists_url":"https://api.github.com/users/m-sandusky/gists{/gist_id}","starred_url":"https://api.github.com/users/m-sandusky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m-sandusky/subscriptions","organizations_url":"https://api.github.com/users/m-sandusky/orgs","repos_url":"https://api.github.com/users/m-sandusky/repos","events_url":"https://api.github.com/users/m-sandusky/events{/privacy}","received_events_url":"https://api.github.com/users/m-sandusky/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/m3db/m3metrics/pulls/134/commits","review_comments_url":"https://api.github.com/repos/m3db/m3metrics/pulls/134/comments","review_comment_url":"https://api.github.com/repos/m3db/m3metrics/pulls/comments{/number}","comments_url":"https://api.github.com/repos/m3db/m3metrics/issues/134/comments","statuses_url":"https://api.github.com/repos/m3db/m3metrics/statuses/676916c3952bae975e7d15f9ad429538afa16d27","head":{"label":"m3db:js/json","ref":"js/json","sha":"676916c3952bae975e7d15f9ad429538afa16d27","user":{"login":"m3db","id":19937171,"avatar_url":"https://avatars0.githubusercontent.com/u/19937171?v=4","gravatar_id":"","url":"https://api.github.com/users/m3db","html_url":"https://github.com/m3db","followers_url":"https://api.github.com/users/m3db/followers","following_url":"https://api.github.com/users/m3db/following{/other_user}","gists_url":"https://api.github.com/users/m3db/gists{/gist_id}","starred_url":"https://api.github.com/users/m3db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m3db/subscriptions","organizations_url":"https://api.github.com/users/m3db/orgs","repos_url":"https://api.github.com/users/m3db/repos","events_url":"https://api.github.com/users/m3db/events{/privacy}","received_events_url":"https://api.github.com/users/m3db/received_events","type":"Organization","site_admin":false},"repo":{"id":76399863,"name":"m3metrics","full_name":"m3db/m3metrics","owner":{"login":"m3db","id":19937171,"avatar_url":"https://avatars0.githubusercontent.com/u/19937171?v=4","gravatar_id":"","url":"https://api.github.com/users/m3db","html_url":"https://github.com/m3db","followers_url":"https://api.github.com/users/m3db/followers","following_url":"https://api.github.com/users/m3db/following{/other_user}","gists_url":"https://api.github.com/users/m3db/gists{/gist_id}","starred_url":"https://api.github.com/users/m3db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m3db/subscriptions","organizations_url":"https://api.github.com/users/m3db/orgs","repos_url":"https://api.github.com/users/m3db/repos","events_url":"https://api.github.com/users/m3db/events{/privacy}","received_events_url":"https://api.github.com/users/m3db/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/m3db/m3metrics","description":"Metrics data structures and serialization/deserialization protocols","fork":false,"url":"https://api.github.com/repos/m3db/m3metrics","forks_url":"https://api.github.com/repos/m3db/m3metrics/forks","keys_url":"https://api.github.com/repos/m3db/m3metrics/keys{/key_id}","collaborators_url":"https://api.github.com/repos/m3db/m3metrics/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/m3db/m3metrics/teams","hooks_url":"https://api.github.com/repos/m3db/m3metrics/hooks","issue_events_url":"https://api.github.com/repos/m3db/m3metrics/issues/events{/number}","events_url":"https://api.github.com/repos/m3db/m3metrics/events","assignees_url":"https://api.github.com/repos/m3db/m3metrics/assignees{/user}","branches_url":"https://api.github.com/repos/m3db/m3metrics/branches{/branch}","tags_url":"https://api.github.com/repos/m3db/m3metrics/tags","blobs_url":"https://api.github.com/repos/m3db/m3metrics/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/m3db/m3metrics/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/m3db/m3metrics/git/refs{/sha}","trees_url":"https://api.github.com/repos/m3db/m3metrics/git/trees{/sha}","statuses_url":"https://api.github.com/repos/m3db/m3metrics/statuses/{sha}","languages_url":"https://api.github.com/repos/m3db/m3metrics/languages","stargazers_url":"https://api.github.com/repos/m3db/m3metrics/stargazers","contributors_url":"https://api.github.com/repos/m3db/m3metrics/contributors","subscribers_url":"https://api.github.com/repos/m3db/m3metrics/subscribers","subscription_url":"https://api.github.com/repos/m3db/m3metrics/subscription","commits_url":"https://api.github.com/repos/m3db/m3metrics/commits{/sha}","git_commits_url":"https://api.github.com/repos/m3db/m3metrics/git/commits{/sha}","comments_url":"https://api.github.com/repos/m3db/m3metrics/comments{/number}","issue_comment_url":"https://api.github.com/repos/m3db/m3metrics/issues/comments{/number}","contents_url":"https://api.github.com/repos/m3db/m3metrics/contents/{+path}","compare_url":"https://api.github.com/repos/m3db/m3metrics/compare/{base}...{head}","merges_url":"https://api.github.com/repos/m3db/m3metrics/merges","archive_url":"https://api.github.com/repos/m3db/m3metrics/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/m3db/m3metrics/downloads","issues_url":"https://api.github.com/repos/m3db/m3metrics/issues{/number}","pulls_url":"https://api.github.com/repos/m3db/m3metrics/pulls{/number}","milestones_url":"https://api.github.com/repos/m3db/m3metrics/milestones{/number}","notifications_url":"https://api.github.com/repos/m3db/m3metrics/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/m3db/m3metrics/labels{/name}","releases_url":"https://api.github.com/repos/m3db/m3metrics/releases{/id}","deployments_url":"https://api.github.com/repos/m3db/m3metrics/deployments","created_at":"2016-12-13T21:28:26Z","updated_at":"2018-03-15T17:13:59Z","pushed_at":"2018-03-15T19:23:14Z","git_url":"git://github.com/m3db/m3metrics.git","ssh_url":"[email protected]:m3db/m3metrics.git","clone_url":"https://github.com/m3db/m3metrics.git","svn_url":"https://github.com/m3db/m3metrics","homepage":"","size":714,"stargazers_count":2,"watchers_count":2,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":10,"watchers":2,"default_branch":"master"}},"base":{"label":"m3db:master","ref":"master","sha":"6ce003d1844b949e34cd43a0a839eb8ffe7ed400","user":{"login":"m3db","id":19937171,"avatar_url":"https://avatars0.githubusercontent.com/u/19937171?v=4","gravatar_id":"","url":"https://api.github.com/users/m3db","html_url":"https://github.com/m3db","followers_url":"https://api.github.com/users/m3db/followers","following_url":"https://api.github.com/users/m3db/following{/other_user}","gists_url":"https://api.github.com/users/m3db/gists{/gist_id}","starred_url":"https://api.github.com/users/m3db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m3db/subscriptions","organizations_url":"https://api.github.com/users/m3db/orgs","repos_url":"https://api.github.com/users/m3db/repos","events_url":"https://api.github.com/users/m3db/events{/privacy}","received_events_url":"https://api.github.com/users/m3db/received_events","type":"Organization","site_admin":false},"repo":{"id":76399863,"name":"m3metrics","full_name":"m3db/m3metrics","owner":{"login":"m3db","id":19937171,"avatar_url":"https://avatars0.githubusercontent.com/u/19937171?v=4","gravatar_id":"","url":"https://api.github.com/users/m3db","html_url":"https://github.com/m3db","followers_url":"https://api.github.com/users/m3db/followers","following_url":"https://api.github.com/users/m3db/following{/other_user}","gists_url":"https://api.github.com/users/m3db/gists{/gist_id}","starred_url":"https://api.github.com/users/m3db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m3db/subscriptions","organizations_url":"https://api.github.com/users/m3db/orgs","repos_url":"https://api.github.com/users/m3db/repos","events_url":"https://api.github.com/users/m3db/events{/privacy}","received_events_url":"https://api.github.com/users/m3db/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/m3db/m3metrics","description":"Metrics data structures and serialization/deserialization protocols","fork":false,"url":"https://api.github.com/repos/m3db/m3metrics","forks_url":"https://api.github.com/repos/m3db/m3metrics/forks","keys_url":"https://api.github.com/repos/m3db/m3metrics/keys{/key_id}","collaborators_url":"https://api.github.com/repos/m3db/m3metrics/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/m3db/m3metrics/teams","hooks_url":"https://api.github.com/repos/m3db/m3metrics/hooks","issue_events_url":"https://api.github.com/repos/m3db/m3metrics/issues/events{/number}","events_url":"https://api.github.com/repos/m3db/m3metrics/events","assignees_url":"https://api.github.com/repos/m3db/m3metrics/assignees{/user}","branches_url":"https://api.github.com/repos/m3db/m3metrics/branches{/branch}","tags_url":"https://api.github.com/repos/m3db/m3metrics/tags","blobs_url":"https://api.github.com/repos/m3db/m3metrics/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/m3db/m3metrics/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/m3db/m3metrics/git/refs{/sha}","trees_url":"https://api.github.com/repos/m3db/m3metrics/git/trees{/sha}","statuses_url":"https://api.github.com/repos/m3db/m3metrics/statuses/{sha}","languages_url":"https://api.github.com/repos/m3db/m3metrics/languages","stargazers_url":"https://api.github.com/repos/m3db/m3metrics/stargazers","contributors_url":"https://api.github.com/repos/m3db/m3metrics/contributors","subscribers_url":"https://api.github.com/repos/m3db/m3metrics/subscribers","subscription_url":"https://api.github.com/repos/m3db/m3metrics/subscription","commits_url":"https://api.github.com/repos/m3db/m3metrics/commits{/sha}","git_commits_url":"https://api.github.com/repos/m3db/m3metrics/git/commits{/sha}","comments_url":"https://api.github.com/repos/m3db/m3metrics/comments{/number}","issue_comment_url":"https://api.github.com/repos/m3db/m3metrics/issues/comments{/number}","contents_url":"https://api.github.com/repos/m3db/m3metrics/contents/{+path}","compare_url":"https://api.github.com/repos/m3db/m3metrics/compare/{base}...{head}","merges_url":"https://api.github.com/repos/m3db/m3metrics/merges","archive_url":"https://api.github.com/repos/m3db/m3metrics/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/m3db/m3metrics/downloads","issues_url":"https://api.github.com/repos/m3db/m3metrics/issues{/number}","pulls_url":"https://api.github.com/repos/m3db/m3metrics/pulls{/number}","milestones_url":"https://api.github.com/repos/m3db/m3metrics/milestones{/number}","notifications_url":"https://api.github.com/repos/m3db/m3metrics/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/m3db/m3metrics/labels{/name}","releases_url":"https://api.github.com/repos/m3db/m3metrics/releases{/id}","deployments_url":"https://api.github.com/repos/m3db/m3metrics/deployments","created_at":"2016-12-13T21:28:26Z","updated_at":"2018-03-15T17:13:59Z","pushed_at":"2018-03-15T19:23:14Z","git_url":"git://github.com/m3db/m3metrics.git","ssh_url":"[email protected]:m3db/m3metrics.git","clone_url":"https://github.com/m3db/m3metrics.git","svn_url":"https://github.com/m3db/m3metrics","homepage":"","size":714,"stargazers_count":2,"watchers_count":2,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":10,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/m3db/m3metrics/pulls/134"},"html":{"href":"https://github.com/m3db/m3metrics/pull/134"},"issue":{"href":"https://api.github.com/repos/m3db/m3metrics/issues/134"},"comments":{"href":"https://api.github.com/repos/m3db/m3metrics/issues/134/comments"},"review_comments":{"href":"https://api.github.com/repos/m3db/m3metrics/pulls/134/comments"},"review_comment":{"href":"https://api.github.com/repos/m3db/m3metrics/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/m3db/m3metrics/pulls/134/commits"},"statuses":{"href":"https://api.github.com/repos/m3db/m3metrics/statuses/676916c3952bae975e7d15f9ad429538afa16d27"}},"author_association":"NONE"}} | {
"id": 76399863,
"name": "m3db/m3metrics",
"url": "https://api.github.com/repos/m3db/m3metrics"
} | {
"id": 2659770,
"login": "jskelcy",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2659770?",
"url": "https://api.github.com/users/jskelcy"
} | {
"id": 19937171,
"login": "m3db",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/19937171?",
"url": "https://api.github.com/orgs/m3db"
} | 2018-03-15T19:31:37 | 7386893425 | {"actor":{"display_login":"jskelcy"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/m3db/m3msg/pulls/comments/177532720","pull_request_review_id":107419712,"id":177532720,"diff_hunk":"@@ -0,0 +1,118 @@\n+// Copyright (c) 2018 Uber Technologies, Inc.\n+//\n+// Permission is hereby granted, free of charge, to any person obtaining a copy\n+// of this software and associated documentation files (the \"Software\"), to deal\n+// in the Software without restriction, including without limitation the rights\n+// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell\n+// copies of the Software, and to permit persons to whom the Software is\n+// furnished to do so, subject to the following conditions:\n+//\n+// The above copyright notice and this permission notice shall be included in\n+// all copies or substantial portions of the Software.\n+//\n+// THE SOFTWARE IS PROVIDED \"AS IS\", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR\n+// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,\n+// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE\n+// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER\n+// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,\n+// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN\n+// THE SOFTWARE.\n+\n+package topic\n+\n+import (\n+\t\"github.com/m3db/m3cluster/client\"\n+\t\"github.com/m3db/m3cluster/kv\"\n+\t\"github.com/m3db/m3cluster/services\"\n+)\n+\n+// Topic defines the topic of messages.\n+type Topic interface {\n+\t// Name returns the name of the topic.\n+\tName() string\n+\n+\t// SetName sets the name of the topic.\n+\tSetName(value string) Topic\n+\n+\t// NumberOfShards returns the total number of shards of the topic.\n+\tNumberOfShards() uint32\n+\n+\t// SetNumberOfShards sets the total number of shards of the topic.\n+\tSetNumberOfShards(value uint32) Topic\n+\n+\t// ConsumerServices returns the consumers of the topic.\n+\tConsumerServices() []ConsumerService\n+\n+\t// SetConsumerServices sets the consumers of the topic.\n+\tSetConsumerServices(value []ConsumerService) Topic\n+}\n+\n+// ConsumerService is a service that consumes the messages in a topic.\n+type ConsumerService interface {\n+\t// ServiceID returns the service id of the consumer service.\n+\tServiceID() services.ServiceID\n+\n+\t// SetServiceID sets the service id of the consumer service.\n+\tSetServiceID(value services.ServiceID) ConsumerService\n+\n+\t// ConsumptionType returns the consumption type of the consumer service.\n+\tConsumptionType() ConsumptionType\n+\n+\t// SetConsumptionType sets the consumption type of the consumer service.\n+\tSetConsumptionType(value ConsumptionType) ConsumerService\n+\n+\t// String returns the string representation of the consumer service.\n+\tString() string\n+}\n+\n+// Watch watches the updates of a topic.\n+type Watch interface {\n+\tC() <-chan struct{}\n+\tGet() Topic\n+\tClose()\n+}\n+\n+// Service provides accessibility to topics.\n+type Service interface {\n+\t// Get returns the topic for the given name.","path":"topic/types.go","position":77,"original_position":77,"commit_id":"fa7a75d09cca229e6942b96ea1f3a04b82bdca6d","original_commit_id":"fa7a75d09cca229e6942b96ea1f3a04b82bdca6d","user":{"login":"m-sandusky","id":13059735,"avatar_url":"https://avatars2.githubusercontent.com/u/13059735?v=4","gravatar_id":"","url":"https://api.github.com/users/m-sandusky","html_url":"https://github.com/m-sandusky","followers_url":"https://api.github.com/users/m-sandusky/followers","following_url":"https://api.github.com/users/m-sandusky/following{/other_user}","gists_url":"https://api.github.com/users/m-sandusky/gists{/gist_id}","starred_url":"https://api.github.com/users/m-sandusky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m-sandusky/subscriptions","organizations_url":"https://api.github.com/users/m-sandusky/orgs","repos_url":"https://api.github.com/users/m-sandusky/repos","events_url":"https://api.github.com/users/m-sandusky/events{/privacy}","received_events_url":"https://api.github.com/users/m-sandusky/received_events","type":"User","site_admin":false},"body":"Nit: Might be worth adding in the comment that the int param is version.","created_at":"2018-03-27T18:48:27Z","updated_at":"2018-03-27T18:51:12Z","html_url":"https://github.com/m3db/m3msg/pull/4#discussion_r177532720","pull_request_url":"https://api.github.com/repos/m3db/m3msg/pulls/4","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/m3db/m3msg/pulls/comments/177532720"},"html":{"href":"https://github.com/m3db/m3msg/pull/4#discussion_r177532720"},"pull_request":{"href":"https://api.github.com/repos/m3db/m3msg/pulls/4"}}},"pull_request":{"url":"https://api.github.com/repos/m3db/m3msg/pulls/4","id":177301461,"html_url":"https://github.com/m3db/m3msg/pull/4","diff_url":"https://github.com/m3db/m3msg/pull/4.diff","patch_url":"https://github.com/m3db/m3msg/pull/4.patch","issue_url":"https://api.github.com/repos/m3db/m3msg/issues/4","number":4,"state":"open","locked":false,"title":"Add topic interfaces","user":{"login":"cw9","id":6710599,"avatar_url":"https://avatars0.githubusercontent.com/u/6710599?v=4","gravatar_id":"","url":"https://api.github.com/users/cw9","html_url":"https://github.com/cw9","followers_url":"https://api.github.com/users/cw9/followers","following_url":"https://api.github.com/users/cw9/following{/other_user}","gists_url":"https://api.github.com/users/cw9/gists{/gist_id}","starred_url":"https://api.github.com/users/cw9/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cw9/subscriptions","organizations_url":"https://api.github.com/users/cw9/orgs","repos_url":"https://api.github.com/users/cw9/repos","events_url":"https://api.github.com/users/cw9/events{/privacy}","received_events_url":"https://api.github.com/users/cw9/received_events","type":"User","site_admin":false},"body":"Add topic interfaces, this pr is rebased from #3 \r\n\r\n@xichen2020 @jeromefroe @schallert \r\n","created_at":"2018-03-25T17:43:29Z","updated_at":"2018-03-27T18:51:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"812a1cc660f529aee8d22f4b78abdf7276e8f88b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/m3db/m3msg/pulls/4/commits","review_comments_url":"https://api.github.com/repos/m3db/m3msg/pulls/4/comments","review_comment_url":"https://api.github.com/repos/m3db/m3msg/pulls/comments{/number}","comments_url":"https://api.github.com/repos/m3db/m3msg/issues/4/comments","statuses_url":"https://api.github.com/repos/m3db/m3msg/statuses/fa7a75d09cca229e6942b96ea1f3a04b82bdca6d","head":{"label":"m3db:chao-topic","ref":"chao-topic","sha":"fa7a75d09cca229e6942b96ea1f3a04b82bdca6d","user":{"login":"m3db","id":19937171,"avatar_url":"https://avatars0.githubusercontent.com/u/19937171?v=4","gravatar_id":"","url":"https://api.github.com/users/m3db","html_url":"https://github.com/m3db","followers_url":"https://api.github.com/users/m3db/followers","following_url":"https://api.github.com/users/m3db/following{/other_user}","gists_url":"https://api.github.com/users/m3db/gists{/gist_id}","starred_url":"https://api.github.com/users/m3db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m3db/subscriptions","organizations_url":"https://api.github.com/users/m3db/orgs","repos_url":"https://api.github.com/users/m3db/repos","events_url":"https://api.github.com/users/m3db/events{/privacy}","received_events_url":"https://api.github.com/users/m3db/received_events","type":"Organization","site_admin":false},"repo":{"id":126348256,"name":"m3msg","full_name":"m3db/m3msg","owner":{"login":"m3db","id":19937171,"avatar_url":"https://avatars0.githubusercontent.com/u/19937171?v=4","gravatar_id":"","url":"https://api.github.com/users/m3db","html_url":"https://github.com/m3db","followers_url":"https://api.github.com/users/m3db/followers","following_url":"https://api.github.com/users/m3db/following{/other_user}","gists_url":"https://api.github.com/users/m3db/gists{/gist_id}","starred_url":"https://api.github.com/users/m3db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m3db/subscriptions","organizations_url":"https://api.github.com/users/m3db/orgs","repos_url":"https://api.github.com/users/m3db/repos","events_url":"https://api.github.com/users/m3db/events{/privacy}","received_events_url":"https://api.github.com/users/m3db/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/m3db/m3msg","description":null,"fork":false,"url":"https://api.github.com/repos/m3db/m3msg","forks_url":"https://api.github.com/repos/m3db/m3msg/forks","keys_url":"https://api.github.com/repos/m3db/m3msg/keys{/key_id}","collaborators_url":"https://api.github.com/repos/m3db/m3msg/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/m3db/m3msg/teams","hooks_url":"https://api.github.com/repos/m3db/m3msg/hooks","issue_events_url":"https://api.github.com/repos/m3db/m3msg/issues/events{/number}","events_url":"https://api.github.com/repos/m3db/m3msg/events","assignees_url":"https://api.github.com/repos/m3db/m3msg/assignees{/user}","branches_url":"https://api.github.com/repos/m3db/m3msg/branches{/branch}","tags_url":"https://api.github.com/repos/m3db/m3msg/tags","blobs_url":"https://api.github.com/repos/m3db/m3msg/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/m3db/m3msg/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/m3db/m3msg/git/refs{/sha}","trees_url":"https://api.github.com/repos/m3db/m3msg/git/trees{/sha}","statuses_url":"https://api.github.com/repos/m3db/m3msg/statuses/{sha}","languages_url":"https://api.github.com/repos/m3db/m3msg/languages","stargazers_url":"https://api.github.com/repos/m3db/m3msg/stargazers","contributors_url":"https://api.github.com/repos/m3db/m3msg/contributors","subscribers_url":"https://api.github.com/repos/m3db/m3msg/subscribers","subscription_url":"https://api.github.com/repos/m3db/m3msg/subscription","commits_url":"https://api.github.com/repos/m3db/m3msg/commits{/sha}","git_commits_url":"https://api.github.com/repos/m3db/m3msg/git/commits{/sha}","comments_url":"https://api.github.com/repos/m3db/m3msg/comments{/number}","issue_comment_url":"https://api.github.com/repos/m3db/m3msg/issues/comments{/number}","contents_url":"https://api.github.com/repos/m3db/m3msg/contents/{+path}","compare_url":"https://api.github.com/repos/m3db/m3msg/compare/{base}...{head}","merges_url":"https://api.github.com/repos/m3db/m3msg/merges","archive_url":"https://api.github.com/repos/m3db/m3msg/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/m3db/m3msg/downloads","issues_url":"https://api.github.com/repos/m3db/m3msg/issues{/number}","pulls_url":"https://api.github.com/repos/m3db/m3msg/pulls{/number}","milestones_url":"https://api.github.com/repos/m3db/m3msg/milestones{/number}","notifications_url":"https://api.github.com/repos/m3db/m3msg/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/m3db/m3msg/labels{/name}","releases_url":"https://api.github.com/repos/m3db/m3msg/releases{/id}","deployments_url":"https://api.github.com/repos/m3db/m3msg/deployments","created_at":"2018-03-22T14:32:21Z","updated_at":"2018-03-22T21:18:35Z","pushed_at":"2018-03-26T16:36:02Z","git_url":"git://github.com/m3db/m3msg.git","ssh_url":"[email protected]:m3db/m3msg.git","clone_url":"https://github.com/m3db/m3msg.git","svn_url":"https://github.com/m3db/m3msg","homepage":null,"size":43,"stargazers_count":0,"watchers_count":0,"language":"Makefile","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"m3db:chao-protocol","ref":"chao-protocol","sha":"162d1306388715b5fc7d6c1e7a841a7de3bd9fc0","user":{"login":"m3db","id":19937171,"avatar_url":"https://avatars0.githubusercontent.com/u/19937171?v=4","gravatar_id":"","url":"https://api.github.com/users/m3db","html_url":"https://github.com/m3db","followers_url":"https://api.github.com/users/m3db/followers","following_url":"https://api.github.com/users/m3db/following{/other_user}","gists_url":"https://api.github.com/users/m3db/gists{/gist_id}","starred_url":"https://api.github.com/users/m3db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m3db/subscriptions","organizations_url":"https://api.github.com/users/m3db/orgs","repos_url":"https://api.github.com/users/m3db/repos","events_url":"https://api.github.com/users/m3db/events{/privacy}","received_events_url":"https://api.github.com/users/m3db/received_events","type":"Organization","site_admin":false},"repo":{"id":126348256,"name":"m3msg","full_name":"m3db/m3msg","owner":{"login":"m3db","id":19937171,"avatar_url":"https://avatars0.githubusercontent.com/u/19937171?v=4","gravatar_id":"","url":"https://api.github.com/users/m3db","html_url":"https://github.com/m3db","followers_url":"https://api.github.com/users/m3db/followers","following_url":"https://api.github.com/users/m3db/following{/other_user}","gists_url":"https://api.github.com/users/m3db/gists{/gist_id}","starred_url":"https://api.github.com/users/m3db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m3db/subscriptions","organizations_url":"https://api.github.com/users/m3db/orgs","repos_url":"https://api.github.com/users/m3db/repos","events_url":"https://api.github.com/users/m3db/events{/privacy}","received_events_url":"https://api.github.com/users/m3db/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/m3db/m3msg","description":null,"fork":false,"url":"https://api.github.com/repos/m3db/m3msg","forks_url":"https://api.github.com/repos/m3db/m3msg/forks","keys_url":"https://api.github.com/repos/m3db/m3msg/keys{/key_id}","collaborators_url":"https://api.github.com/repos/m3db/m3msg/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/m3db/m3msg/teams","hooks_url":"https://api.github.com/repos/m3db/m3msg/hooks","issue_events_url":"https://api.github.com/repos/m3db/m3msg/issues/events{/number}","events_url":"https://api.github.com/repos/m3db/m3msg/events","assignees_url":"https://api.github.com/repos/m3db/m3msg/assignees{/user}","branches_url":"https://api.github.com/repos/m3db/m3msg/branches{/branch}","tags_url":"https://api.github.com/repos/m3db/m3msg/tags","blobs_url":"https://api.github.com/repos/m3db/m3msg/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/m3db/m3msg/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/m3db/m3msg/git/refs{/sha}","trees_url":"https://api.github.com/repos/m3db/m3msg/git/trees{/sha}","statuses_url":"https://api.github.com/repos/m3db/m3msg/statuses/{sha}","languages_url":"https://api.github.com/repos/m3db/m3msg/languages","stargazers_url":"https://api.github.com/repos/m3db/m3msg/stargazers","contributors_url":"https://api.github.com/repos/m3db/m3msg/contributors","subscribers_url":"https://api.github.com/repos/m3db/m3msg/subscribers","subscription_url":"https://api.github.com/repos/m3db/m3msg/subscription","commits_url":"https://api.github.com/repos/m3db/m3msg/commits{/sha}","git_commits_url":"https://api.github.com/repos/m3db/m3msg/git/commits{/sha}","comments_url":"https://api.github.com/repos/m3db/m3msg/comments{/number}","issue_comment_url":"https://api.github.com/repos/m3db/m3msg/issues/comments{/number}","contents_url":"https://api.github.com/repos/m3db/m3msg/contents/{+path}","compare_url":"https://api.github.com/repos/m3db/m3msg/compare/{base}...{head}","merges_url":"https://api.github.com/repos/m3db/m3msg/merges","archive_url":"https://api.github.com/repos/m3db/m3msg/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/m3db/m3msg/downloads","issues_url":"https://api.github.com/repos/m3db/m3msg/issues{/number}","pulls_url":"https://api.github.com/repos/m3db/m3msg/pulls{/number}","milestones_url":"https://api.github.com/repos/m3db/m3msg/milestones{/number}","notifications_url":"https://api.github.com/repos/m3db/m3msg/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/m3db/m3msg/labels{/name}","releases_url":"https://api.github.com/repos/m3db/m3msg/releases{/id}","deployments_url":"https://api.github.com/repos/m3db/m3msg/deployments","created_at":"2018-03-22T14:32:21Z","updated_at":"2018-03-22T21:18:35Z","pushed_at":"2018-03-26T16:36:02Z","git_url":"git://github.com/m3db/m3msg.git","ssh_url":"[email protected]:m3db/m3msg.git","clone_url":"https://github.com/m3db/m3msg.git","svn_url":"https://github.com/m3db/m3msg","homepage":null,"size":43,"stargazers_count":0,"watchers_count":0,"language":"Makefile","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/m3db/m3msg/pulls/4"},"html":{"href":"https://github.com/m3db/m3msg/pull/4"},"issue":{"href":"https://api.github.com/repos/m3db/m3msg/issues/4"},"comments":{"href":"https://api.github.com/repos/m3db/m3msg/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/m3db/m3msg/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/m3db/m3msg/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/m3db/m3msg/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/m3db/m3msg/statuses/fa7a75d09cca229e6942b96ea1f3a04b82bdca6d"}},"author_association":"CONTRIBUTOR"}} | {
"id": 126348256,
"name": "m3db/m3msg",
"url": "https://api.github.com/repos/m3db/m3msg"
} | {
"id": 13059735,
"login": "m-sandusky",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/13059735?",
"url": "https://api.github.com/users/m-sandusky"
} | {
"id": 19937171,
"login": "m3db",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/19937171?",
"url": "https://api.github.com/orgs/m3db"
} | 2018-03-27T18:48:27 | 7443367833 | {"actor":{"display_login":"m-sandusky"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/elixir-ecto/ecto/pulls/comments/208933583","pull_request_review_id":144845441,"id":208933583,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwODkzMzU4Mw==","diff_hunk":"@@ -875,6 +884,94 @@ defmodule Ecto.Type do\n end\n end\n \n+ @doc \"\"\"\n+ Checks if two terms are equal.\n+\n+ Depending on the given `type` performs a structural or semantical comparison.\n+\n+ ## Examples\n+\n+ iex> equal?(:integer, 1, 1)\n+ true\n+ iex> equal?(:decimal, Decimal.new(\"1\"), Decimal.new(\"1.00\"))\n+ true\n+\n+ \"\"\"\n+ @spec equal?(t, term, term) :: boolean\n+ def equal?(type, term1, term2) do\n+ if requires_semantic_comparison?(type) do\n+ do_equal?(type, term1, term2)\n+ else\n+ term1 == term2\n+ end\n+ end\n+\n+ defp requires_semantic_comparison?(:decimal),\n+ do: true\n+ defp requires_semantic_comparison?(:date),\n+ do: false\n+ defp requires_semantic_comparison?(type) when type in @calendar,\n+ do: true\n+ defp requires_semantic_comparison?(type) when type in @base,\n+ do: false\n+ defp requires_semantic_comparison?({:array, type}),\n+ do: requires_semantic_comparison?(type)\n+ defp requires_semantic_comparison?({:map, type}),\n+ do: requires_semantic_comparison?(type)\n+ defp requires_semantic_comparison?(module) when is_atom(module) do\n+ function_exported?(module, :equal?, 2)\n+ end\n+\n+ defp do_equal?(:decimal, %Decimal{} = term1, %Decimal{} = term2) do\n+ Decimal.equal?(term1, term2)\n+ end\n+ defp do_equal?(type, %Time{} = term1, %Time{} = term2) when type in [:time, :time_usec] do\n+ Time.compare(term1, term2) == :eq\n+ end\n+ defp do_equal?(type, %NaiveDateTime{} = term1, %NaiveDateTime{} = term2)\n+ when type in [:naive_datetime, :naive_datetime_usec] do\n+ NaiveDateTime.compare(term1, term2) == :eq\n+ end\n+ defp do_equal?(type, %DateTime{} = term1, %DateTime{} = term2)\n+ when type in [:utc_datetime, :utc_datetime_usec] do\n+ DateTime.compare(term1, term2) == :eq\n+ end\n+ defp do_equal?(type, term1, term2) when type in @base do\n+ term1 == term2\n+ end\n+ defp do_equal?(module, term1, term2) when is_atom(module) do\n+ module.equal?(term1, term2)","path":"lib/ecto/type.ex","position":93,"original_position":93,"commit_id":"08eb66ca4f15826b65dee66cb20a22ed2f44d1f9","original_commit_id":"08eb66ca4f15826b65dee66cb20a22ed2f44d1f9","user":{"login":"wojtekmach","id":76071,"node_id":"MDQ6VXNlcjc2MDcx","avatar_url":"https://avatars0.githubusercontent.com/u/76071?v=4","gravatar_id":"","url":"https://api.github.com/users/wojtekmach","html_url":"https://github.com/wojtekmach","followers_url":"https://api.github.com/users/wojtekmach/followers","following_url":"https://api.github.com/users/wojtekmach/following{/other_user}","gists_url":"https://api.github.com/users/wojtekmach/gists{/gist_id}","starred_url":"https://api.github.com/users/wojtekmach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wojtekmach/subscriptions","organizations_url":"https://api.github.com/users/wojtekmach/orgs","repos_url":"https://api.github.com/users/wojtekmach/repos","events_url":"https://api.github.com/users/wojtekmach/events{/privacy}","received_events_url":"https://api.github.com/users/wojtekmach/received_events","type":"User","site_admin":false},"body":"@fertapric yes, that close (fyi: decimal and calendar types are in `@base` but that's a minor detail that's easy to fix)\r\n\r\nWe would still be inefficient for nested composites like `{:array, {:array, integer()}}` but to be fair that should be rather uncommon.\r\n\r\n@josevalim do you have a preference?","created_at":"2018-08-09T13:43:40Z","updated_at":"2018-08-09T13:43:40Z","html_url":"https://github.com/elixir-ecto/ecto/pull/2651#discussion_r208933583","pull_request_url":"https://api.github.com/repos/elixir-ecto/ecto/pulls/2651","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/elixir-ecto/ecto/pulls/comments/208933583"},"html":{"href":"https://github.com/elixir-ecto/ecto/pull/2651#discussion_r208933583"},"pull_request":{"href":"https://api.github.com/repos/elixir-ecto/ecto/pulls/2651"}},"in_reply_to_id":208901669},"pull_request":{"url":"https://api.github.com/repos/elixir-ecto/ecto/pulls/2651","id":207289221,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3Mjg5MjIx","html_url":"https://github.com/elixir-ecto/ecto/pull/2651","diff_url":"https://github.com/elixir-ecto/ecto/pull/2651.diff","patch_url":"https://github.com/elixir-ecto/ecto/pull/2651.patch","issue_url":"https://api.github.com/repos/elixir-ecto/ecto/issues/2651","number":2651,"state":"open","locked":false,"title":"Semantic comparisons in changesets","user":{"login":"wojtekmach","id":76071,"node_id":"MDQ6VXNlcjc2MDcx","avatar_url":"https://avatars0.githubusercontent.com/u/76071?v=4","gravatar_id":"","url":"https://api.github.com/users/wojtekmach","html_url":"https://github.com/wojtekmach","followers_url":"https://api.github.com/users/wojtekmach/followers","following_url":"https://api.github.com/users/wojtekmach/following{/other_user}","gists_url":"https://api.github.com/users/wojtekmach/gists{/gist_id}","starred_url":"https://api.github.com/users/wojtekmach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wojtekmach/subscriptions","organizations_url":"https://api.github.com/users/wojtekmach/orgs","repos_url":"https://api.github.com/users/wojtekmach/repos","events_url":"https://api.github.com/users/wojtekmach/events{/privacy}","received_events_url":"https://api.github.com/users/wojtekmach/received_events","type":"User","site_admin":false},"body":"Fixes #2473 \r\n\r\n* Add `Ecto.Type.equal?/3` callback\r\n* Add `Ecto.Type.equal?/2` function","created_at":"2018-08-09T11:47:36Z","updated_at":"2018-08-09T13:43:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f0fcf51f500ae16464a6add2d5d8687b6258110f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/elixir-ecto/ecto/pulls/2651/commits","review_comments_url":"https://api.github.com/repos/elixir-ecto/ecto/pulls/2651/comments","review_comment_url":"https://api.github.com/repos/elixir-ecto/ecto/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elixir-ecto/ecto/issues/2651/comments","statuses_url":"https://api.github.com/repos/elixir-ecto/ecto/statuses/08eb66ca4f15826b65dee66cb20a22ed2f44d1f9","head":{"label":"wojtekmach:wm-decimal-equals","ref":"wm-decimal-equals","sha":"08eb66ca4f15826b65dee66cb20a22ed2f44d1f9","user":{"login":"wojtekmach","id":76071,"node_id":"MDQ6VXNlcjc2MDcx","avatar_url":"https://avatars0.githubusercontent.com/u/76071?v=4","gravatar_id":"","url":"https://api.github.com/users/wojtekmach","html_url":"https://github.com/wojtekmach","followers_url":"https://api.github.com/users/wojtekmach/followers","following_url":"https://api.github.com/users/wojtekmach/following{/other_user}","gists_url":"https://api.github.com/users/wojtekmach/gists{/gist_id}","starred_url":"https://api.github.com/users/wojtekmach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wojtekmach/subscriptions","organizations_url":"https://api.github.com/users/wojtekmach/orgs","repos_url":"https://api.github.com/users/wojtekmach/repos","events_url":"https://api.github.com/users/wojtekmach/events{/privacy}","received_events_url":"https://api.github.com/users/wojtekmach/received_events","type":"User","site_admin":false},"repo":{"id":39089739,"node_id":"MDEwOlJlcG9zaXRvcnkzOTA4OTczOQ==","name":"ecto","full_name":"wojtekmach/ecto","owner":{"login":"wojtekmach","id":76071,"node_id":"MDQ6VXNlcjc2MDcx","avatar_url":"https://avatars0.githubusercontent.com/u/76071?v=4","gravatar_id":"","url":"https://api.github.com/users/wojtekmach","html_url":"https://github.com/wojtekmach","followers_url":"https://api.github.com/users/wojtekmach/followers","following_url":"https://api.github.com/users/wojtekmach/following{/other_user}","gists_url":"https://api.github.com/users/wojtekmach/gists{/gist_id}","starred_url":"https://api.github.com/users/wojtekmach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wojtekmach/subscriptions","organizations_url":"https://api.github.com/users/wojtekmach/orgs","repos_url":"https://api.github.com/users/wojtekmach/repos","events_url":"https://api.github.com/users/wojtekmach/events{/privacy}","received_events_url":"https://api.github.com/users/wojtekmach/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wojtekmach/ecto","description":"A database wrapper and language integrated query for Elixir","fork":true,"url":"https://api.github.com/repos/wojtekmach/ecto","forks_url":"https://api.github.com/repos/wojtekmach/ecto/forks","keys_url":"https://api.github.com/repos/wojtekmach/ecto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wojtekmach/ecto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wojtekmach/ecto/teams","hooks_url":"https://api.github.com/repos/wojtekmach/ecto/hooks","issue_events_url":"https://api.github.com/repos/wojtekmach/ecto/issues/events{/number}","events_url":"https://api.github.com/repos/wojtekmach/ecto/events","assignees_url":"https://api.github.com/repos/wojtekmach/ecto/assignees{/user}","branches_url":"https://api.github.com/repos/wojtekmach/ecto/branches{/branch}","tags_url":"https://api.github.com/repos/wojtekmach/ecto/tags","blobs_url":"https://api.github.com/repos/wojtekmach/ecto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wojtekmach/ecto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wojtekmach/ecto/git/refs{/sha}","trees_url":"https://api.github.com/repos/wojtekmach/ecto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wojtekmach/ecto/statuses/{sha}","languages_url":"https://api.github.com/repos/wojtekmach/ecto/languages","stargazers_url":"https://api.github.com/repos/wojtekmach/ecto/stargazers","contributors_url":"https://api.github.com/repos/wojtekmach/ecto/contributors","subscribers_url":"https://api.github.com/repos/wojtekmach/ecto/subscribers","subscription_url":"https://api.github.com/repos/wojtekmach/ecto/subscription","commits_url":"https://api.github.com/repos/wojtekmach/ecto/commits{/sha}","git_commits_url":"https://api.github.com/repos/wojtekmach/ecto/git/commits{/sha}","comments_url":"https://api.github.com/repos/wojtekmach/ecto/comments{/number}","issue_comment_url":"https://api.github.com/repos/wojtekmach/ecto/issues/comments{/number}","contents_url":"https://api.github.com/repos/wojtekmach/ecto/contents/{+path}","compare_url":"https://api.github.com/repos/wojtekmach/ecto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wojtekmach/ecto/merges","archive_url":"https://api.github.com/repos/wojtekmach/ecto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wojtekmach/ecto/downloads","issues_url":"https://api.github.com/repos/wojtekmach/ecto/issues{/number}","pulls_url":"https://api.github.com/repos/wojtekmach/ecto/pulls{/number}","milestones_url":"https://api.github.com/repos/wojtekmach/ecto/milestones{/number}","notifications_url":"https://api.github.com/repos/wojtekmach/ecto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wojtekmach/ecto/labels{/name}","releases_url":"https://api.github.com/repos/wojtekmach/ecto/releases{/id}","deployments_url":"https://api.github.com/repos/wojtekmach/ecto/deployments","created_at":"2015-07-14T17:22:52Z","updated_at":"2016-05-17T18:07:43Z","pushed_at":"2018-08-09T11:46:47Z","git_url":"git://github.com/wojtekmach/ecto.git","ssh_url":"[email protected]:wojtekmach/ecto.git","clone_url":"https://github.com/wojtekmach/ecto.git","svn_url":"https://github.com/wojtekmach/ecto","homepage":"","size":10482,"stargazers_count":0,"watchers_count":0,"language":"Elixir","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"elixir-ecto:master","ref":"master","sha":"022f244aa4839d61dc4cf413813e5d02fd4fbd64","user":{"login":"elixir-ecto","id":19973437,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5OTczNDM3","avatar_url":"https://avatars3.githubusercontent.com/u/19973437?v=4","gravatar_id":"","url":"https://api.github.com/users/elixir-ecto","html_url":"https://github.com/elixir-ecto","followers_url":"https://api.github.com/users/elixir-ecto/followers","following_url":"https://api.github.com/users/elixir-ecto/following{/other_user}","gists_url":"https://api.github.com/users/elixir-ecto/gists{/gist_id}","starred_url":"https://api.github.com/users/elixir-ecto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elixir-ecto/subscriptions","organizations_url":"https://api.github.com/users/elixir-ecto/orgs","repos_url":"https://api.github.com/users/elixir-ecto/repos","events_url":"https://api.github.com/users/elixir-ecto/events{/privacy}","received_events_url":"https://api.github.com/users/elixir-ecto/received_events","type":"Organization","site_admin":false},"repo":{"id":10649374,"node_id":"MDEwOlJlcG9zaXRvcnkxMDY0OTM3NA==","name":"ecto","full_name":"elixir-ecto/ecto","owner":{"login":"elixir-ecto","id":19973437,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5OTczNDM3","avatar_url":"https://avatars3.githubusercontent.com/u/19973437?v=4","gravatar_id":"","url":"https://api.github.com/users/elixir-ecto","html_url":"https://github.com/elixir-ecto","followers_url":"https://api.github.com/users/elixir-ecto/followers","following_url":"https://api.github.com/users/elixir-ecto/following{/other_user}","gists_url":"https://api.github.com/users/elixir-ecto/gists{/gist_id}","starred_url":"https://api.github.com/users/elixir-ecto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elixir-ecto/subscriptions","organizations_url":"https://api.github.com/users/elixir-ecto/orgs","repos_url":"https://api.github.com/users/elixir-ecto/repos","events_url":"https://api.github.com/users/elixir-ecto/events{/privacy}","received_events_url":"https://api.github.com/users/elixir-ecto/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elixir-ecto/ecto","description":"A database wrapper and language integrated query for Elixir","fork":false,"url":"https://api.github.com/repos/elixir-ecto/ecto","forks_url":"https://api.github.com/repos/elixir-ecto/ecto/forks","keys_url":"https://api.github.com/repos/elixir-ecto/ecto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elixir-ecto/ecto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elixir-ecto/ecto/teams","hooks_url":"https://api.github.com/repos/elixir-ecto/ecto/hooks","issue_events_url":"https://api.github.com/repos/elixir-ecto/ecto/issues/events{/number}","events_url":"https://api.github.com/repos/elixir-ecto/ecto/events","assignees_url":"https://api.github.com/repos/elixir-ecto/ecto/assignees{/user}","branches_url":"https://api.github.com/repos/elixir-ecto/ecto/branches{/branch}","tags_url":"https://api.github.com/repos/elixir-ecto/ecto/tags","blobs_url":"https://api.github.com/repos/elixir-ecto/ecto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elixir-ecto/ecto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elixir-ecto/ecto/git/refs{/sha}","trees_url":"https://api.github.com/repos/elixir-ecto/ecto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elixir-ecto/ecto/statuses/{sha}","languages_url":"https://api.github.com/repos/elixir-ecto/ecto/languages","stargazers_url":"https://api.github.com/repos/elixir-ecto/ecto/stargazers","contributors_url":"https://api.github.com/repos/elixir-ecto/ecto/contributors","subscribers_url":"https://api.github.com/repos/elixir-ecto/ecto/subscribers","subscription_url":"https://api.github.com/repos/elixir-ecto/ecto/subscription","commits_url":"https://api.github.com/repos/elixir-ecto/ecto/commits{/sha}","git_commits_url":"https://api.github.com/repos/elixir-ecto/ecto/git/commits{/sha}","comments_url":"https://api.github.com/repos/elixir-ecto/ecto/comments{/number}","issue_comment_url":"https://api.github.com/repos/elixir-ecto/ecto/issues/comments{/number}","contents_url":"https://api.github.com/repos/elixir-ecto/ecto/contents/{+path}","compare_url":"https://api.github.com/repos/elixir-ecto/ecto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elixir-ecto/ecto/merges","archive_url":"https://api.github.com/repos/elixir-ecto/ecto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elixir-ecto/ecto/downloads","issues_url":"https://api.github.com/repos/elixir-ecto/ecto/issues{/number}","pulls_url":"https://api.github.com/repos/elixir-ecto/ecto/pulls{/number}","milestones_url":"https://api.github.com/repos/elixir-ecto/ecto/milestones{/number}","notifications_url":"https://api.github.com/repos/elixir-ecto/ecto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elixir-ecto/ecto/labels{/name}","releases_url":"https://api.github.com/repos/elixir-ecto/ecto/releases{/id}","deployments_url":"https://api.github.com/repos/elixir-ecto/ecto/deployments","created_at":"2013-06-12T18:42:06Z","updated_at":"2018-08-09T10:30:47Z","pushed_at":"2018-08-09T11:47:37Z","git_url":"git://github.com/elixir-ecto/ecto.git","ssh_url":"[email protected]:elixir-ecto/ecto.git","clone_url":"https://github.com/elixir-ecto/ecto.git","svn_url":"https://github.com/elixir-ecto/ecto","homepage":"https://hexdocs.pm/ecto","size":10932,"stargazers_count":3635,"watchers_count":3635,"language":"Elixir","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":894,"mirror_url":null,"archived":false,"open_issues_count":34,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":894,"open_issues":34,"watchers":3635,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elixir-ecto/ecto/pulls/2651"},"html":{"href":"https://github.com/elixir-ecto/ecto/pull/2651"},"issue":{"href":"https://api.github.com/repos/elixir-ecto/ecto/issues/2651"},"comments":{"href":"https://api.github.com/repos/elixir-ecto/ecto/issues/2651/comments"},"review_comments":{"href":"https://api.github.com/repos/elixir-ecto/ecto/pulls/2651/comments"},"review_comment":{"href":"https://api.github.com/repos/elixir-ecto/ecto/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elixir-ecto/ecto/pulls/2651/commits"},"statuses":{"href":"https://api.github.com/repos/elixir-ecto/ecto/statuses/08eb66ca4f15826b65dee66cb20a22ed2f44d1f9"}},"author_association":"CONTRIBUTOR"}} | {
"id": 10649374,
"name": "elixir-ecto/ecto",
"url": "https://api.github.com/repos/elixir-ecto/ecto"
} | {
"id": 76071,
"login": "wojtekmach",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/76071?",
"url": "https://api.github.com/users/wojtekmach"
} | {
"id": 19973437,
"login": "elixir-ecto",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/19973437?",
"url": "https://api.github.com/orgs/elixir-ecto"
} | 2018-08-09T13:43:40 | 8090285989 | {"actor":{"display_login":"wojtekmach"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/devtools-html/debugger.html/pulls/comments/227756436","pull_request_review_id":167867323,"id":227756436,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNzc1NjQzNg==","diff_hunk":"@@ -655,8 +655,8 @@ support-files =\n [browser_dbg-asm.js]\n [browser_dbg-async-stepping.js]\n [browser_dbg-sourcemapped-breakpoint-console.js]\n-[browser_dbg-xhr-breakpoints.js]\n skip-if = (os == \"win\" && ccov) # Bug 1453549\n+[browser_dbg-xhr-breakpoints.js]","path":"src/test/mochitest/browser.ini","position":6,"original_position":6,"commit_id":"875f440386eb690cf45832b41bf2a77524e47a53","original_commit_id":"875f440386eb690cf45832b41bf2a77524e47a53","user":{"login":"darkwing","id":46655,"node_id":"MDQ6VXNlcjQ2NjU1","avatar_url":"https://avatars0.githubusercontent.com/u/46655?v=4","gravatar_id":"","url":"https://api.github.com/users/darkwing","html_url":"https://github.com/darkwing","followers_url":"https://api.github.com/users/darkwing/followers","following_url":"https://api.github.com/users/darkwing/following{/other_user}","gists_url":"https://api.github.com/users/darkwing/gists{/gist_id}","starred_url":"https://api.github.com/users/darkwing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darkwing/subscriptions","organizations_url":"https://api.github.com/users/darkwing/orgs","repos_url":"https://api.github.com/users/darkwing/repos","events_url":"https://api.github.com/users/darkwing/events{/privacy}","received_events_url":"https://api.github.com/users/darkwing/received_events","type":"User","site_admin":false},"body":"No; the `skip-if` conditions apply to the test *above* the `skip-if` text, so in this case line 657","created_at":"2018-10-24T11:57:59Z","updated_at":"2018-10-24T11:57:59Z","html_url":"https://github.com/devtools-html/debugger.html/pull/7147#discussion_r227756436","pull_request_url":"https://api.github.com/repos/devtools-html/debugger.html/pulls/7147","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/devtools-html/debugger.html/pulls/comments/227756436"},"html":{"href":"https://github.com/devtools-html/debugger.html/pull/7147#discussion_r227756436"},"pull_request":{"href":"https://api.github.com/repos/devtools-html/debugger.html/pulls/7147"}},"in_reply_to_id":227638987},"pull_request":{"url":"https://api.github.com/repos/devtools-html/debugger.html/pulls/7147","id":225206825,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1MjA2ODI1","html_url":"https://github.com/devtools-html/debugger.html/pull/7147","diff_url":"https://github.com/devtools-html/debugger.html/pull/7147.diff","patch_url":"https://github.com/devtools-html/debugger.html/pull/7147.patch","issue_url":"https://api.github.com/repos/devtools-html/debugger.html/issues/7147","number":7147,"state":"closed","locked":false,"title":"Properly set permissions for testing, label nit","user":{"login":"darkwing","id":46655,"node_id":"MDQ6VXNlcjQ2NjU1","avatar_url":"https://avatars0.githubusercontent.com/u/46655?v=4","gravatar_id":"","url":"https://api.github.com/users/darkwing","html_url":"https://github.com/darkwing","followers_url":"https://api.github.com/users/darkwing/followers","following_url":"https://api.github.com/users/darkwing/following{/other_user}","gists_url":"https://api.github.com/users/darkwing/gists{/gist_id}","starred_url":"https://api.github.com/users/darkwing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darkwing/subscriptions","organizations_url":"https://api.github.com/users/darkwing/orgs","repos_url":"https://api.github.com/users/darkwing/repos","events_url":"https://api.github.com/users/darkwing/events{/privacy}","received_events_url":"https://api.github.com/users/darkwing/received_events","type":"User","site_admin":false},"body":"- Label nit was something @flodolo had pointed out but we missed.\r\n- The condition for a test goes underneath it, so we accidentally added a condition to the xhr breakpoint test and removed it from its desired test.","created_at":"2018-10-23T22:24:22Z","updated_at":"2018-10-24T11:57:59Z","closed_at":"2018-10-23T23:11:31Z","merged_at":"2018-10-23T23:11:31Z","merge_commit_sha":"064f6e1e5d0db9f95f53dd9affa26108b8733f4c","assignee":null,"assignees":[],"requested_reviewers":[{"login":"flodolo","id":3644868,"node_id":"MDQ6VXNlcjM2NDQ4Njg=","avatar_url":"https://avatars0.githubusercontent.com/u/3644868?v=4","gravatar_id":"","url":"https://api.github.com/users/flodolo","html_url":"https://github.com/flodolo","followers_url":"https://api.github.com/users/flodolo/followers","following_url":"https://api.github.com/users/flodolo/following{/other_user}","gists_url":"https://api.github.com/users/flodolo/gists{/gist_id}","starred_url":"https://api.github.com/users/flodolo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flodolo/subscriptions","organizations_url":"https://api.github.com/users/flodolo/orgs","repos_url":"https://api.github.com/users/flodolo/repos","events_url":"https://api.github.com/users/flodolo/events{/privacy}","received_events_url":"https://api.github.com/users/flodolo/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/devtools-html/debugger.html/pulls/7147/commits","review_comments_url":"https://api.github.com/repos/devtools-html/debugger.html/pulls/7147/comments","review_comment_url":"https://api.github.com/repos/devtools-html/debugger.html/pulls/comments{/number}","comments_url":"https://api.github.com/repos/devtools-html/debugger.html/issues/7147/comments","statuses_url":"https://api.github.com/repos/devtools-html/debugger.html/statuses/875f440386eb690cf45832b41bf2a77524e47a53","head":{"label":"darkwing:quick-xhr-fix","ref":"quick-xhr-fix","sha":"875f440386eb690cf45832b41bf2a77524e47a53","user":{"login":"darkwing","id":46655,"node_id":"MDQ6VXNlcjQ2NjU1","avatar_url":"https://avatars0.githubusercontent.com/u/46655?v=4","gravatar_id":"","url":"https://api.github.com/users/darkwing","html_url":"https://github.com/darkwing","followers_url":"https://api.github.com/users/darkwing/followers","following_url":"https://api.github.com/users/darkwing/following{/other_user}","gists_url":"https://api.github.com/users/darkwing/gists{/gist_id}","starred_url":"https://api.github.com/users/darkwing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darkwing/subscriptions","organizations_url":"https://api.github.com/users/darkwing/orgs","repos_url":"https://api.github.com/users/darkwing/repos","events_url":"https://api.github.com/users/darkwing/events{/privacy}","received_events_url":"https://api.github.com/users/darkwing/received_events","type":"User","site_admin":false},"repo":{"id":71071373,"node_id":"MDEwOlJlcG9zaXRvcnk3MTA3MTM3Mw==","name":"debugger.html","full_name":"darkwing/debugger.html","private":false,"owner":{"login":"darkwing","id":46655,"node_id":"MDQ6VXNlcjQ2NjU1","avatar_url":"https://avatars0.githubusercontent.com/u/46655?v=4","gravatar_id":"","url":"https://api.github.com/users/darkwing","html_url":"https://github.com/darkwing","followers_url":"https://api.github.com/users/darkwing/followers","following_url":"https://api.github.com/users/darkwing/following{/other_user}","gists_url":"https://api.github.com/users/darkwing/gists{/gist_id}","starred_url":"https://api.github.com/users/darkwing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darkwing/subscriptions","organizations_url":"https://api.github.com/users/darkwing/orgs","repos_url":"https://api.github.com/users/darkwing/repos","events_url":"https://api.github.com/users/darkwing/events{/privacy}","received_events_url":"https://api.github.com/users/darkwing/received_events","type":"User","site_admin":false},"html_url":"https://github.com/darkwing/debugger.html","description":"The Firefox debugger that works anywhere","fork":true,"url":"https://api.github.com/repos/darkwing/debugger.html","forks_url":"https://api.github.com/repos/darkwing/debugger.html/forks","keys_url":"https://api.github.com/repos/darkwing/debugger.html/keys{/key_id}","collaborators_url":"https://api.github.com/repos/darkwing/debugger.html/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/darkwing/debugger.html/teams","hooks_url":"https://api.github.com/repos/darkwing/debugger.html/hooks","issue_events_url":"https://api.github.com/repos/darkwing/debugger.html/issues/events{/number}","events_url":"https://api.github.com/repos/darkwing/debugger.html/events","assignees_url":"https://api.github.com/repos/darkwing/debugger.html/assignees{/user}","branches_url":"https://api.github.com/repos/darkwing/debugger.html/branches{/branch}","tags_url":"https://api.github.com/repos/darkwing/debugger.html/tags","blobs_url":"https://api.github.com/repos/darkwing/debugger.html/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/darkwing/debugger.html/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/darkwing/debugger.html/git/refs{/sha}","trees_url":"https://api.github.com/repos/darkwing/debugger.html/git/trees{/sha}","statuses_url":"https://api.github.com/repos/darkwing/debugger.html/statuses/{sha}","languages_url":"https://api.github.com/repos/darkwing/debugger.html/languages","stargazers_url":"https://api.github.com/repos/darkwing/debugger.html/stargazers","contributors_url":"https://api.github.com/repos/darkwing/debugger.html/contributors","subscribers_url":"https://api.github.com/repos/darkwing/debugger.html/subscribers","subscription_url":"https://api.github.com/repos/darkwing/debugger.html/subscription","commits_url":"https://api.github.com/repos/darkwing/debugger.html/commits{/sha}","git_commits_url":"https://api.github.com/repos/darkwing/debugger.html/git/commits{/sha}","comments_url":"https://api.github.com/repos/darkwing/debugger.html/comments{/number}","issue_comment_url":"https://api.github.com/repos/darkwing/debugger.html/issues/comments{/number}","contents_url":"https://api.github.com/repos/darkwing/debugger.html/contents/{+path}","compare_url":"https://api.github.com/repos/darkwing/debugger.html/compare/{base}...{head}","merges_url":"https://api.github.com/repos/darkwing/debugger.html/merges","archive_url":"https://api.github.com/repos/darkwing/debugger.html/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/darkwing/debugger.html/downloads","issues_url":"https://api.github.com/repos/darkwing/debugger.html/issues{/number}","pulls_url":"https://api.github.com/repos/darkwing/debugger.html/pulls{/number}","milestones_url":"https://api.github.com/repos/darkwing/debugger.html/milestones{/number}","notifications_url":"https://api.github.com/repos/darkwing/debugger.html/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/darkwing/debugger.html/labels{/name}","releases_url":"https://api.github.com/repos/darkwing/debugger.html/releases{/id}","deployments_url":"https://api.github.com/repos/darkwing/debugger.html/deployments","created_at":"2016-10-16T19:12:39Z","updated_at":"2018-10-22T15:44:32Z","pushed_at":"2018-10-23T23:06:40Z","git_url":"git://github.com/darkwing/debugger.html.git","ssh_url":"[email protected]:darkwing/debugger.html.git","clone_url":"https://github.com/darkwing/debugger.html.git","svn_url":"https://github.com/darkwing/debugger.html","homepage":"","size":28598,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"devtools-html:master","ref":"master","sha":"9309042df4ecd99c8859b190d8fc8287e18851ad","user":{"login":"devtools-html","id":19979421,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5OTc5NDIx","avatar_url":"https://avatars2.githubusercontent.com/u/19979421?v=4","gravatar_id":"","url":"https://api.github.com/users/devtools-html","html_url":"https://github.com/devtools-html","followers_url":"https://api.github.com/users/devtools-html/followers","following_url":"https://api.github.com/users/devtools-html/following{/other_user}","gists_url":"https://api.github.com/users/devtools-html/gists{/gist_id}","starred_url":"https://api.github.com/users/devtools-html/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/devtools-html/subscriptions","organizations_url":"https://api.github.com/users/devtools-html/orgs","repos_url":"https://api.github.com/users/devtools-html/repos","events_url":"https://api.github.com/users/devtools-html/events{/privacy}","received_events_url":"https://api.github.com/users/devtools-html/received_events","type":"Organization","site_admin":false},"repo":{"id":54585418,"node_id":"MDEwOlJlcG9zaXRvcnk1NDU4NTQxOA==","name":"debugger.html","full_name":"devtools-html/debugger.html","private":false,"owner":{"login":"devtools-html","id":19979421,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5OTc5NDIx","avatar_url":"https://avatars2.githubusercontent.com/u/19979421?v=4","gravatar_id":"","url":"https://api.github.com/users/devtools-html","html_url":"https://github.com/devtools-html","followers_url":"https://api.github.com/users/devtools-html/followers","following_url":"https://api.github.com/users/devtools-html/following{/other_user}","gists_url":"https://api.github.com/users/devtools-html/gists{/gist_id}","starred_url":"https://api.github.com/users/devtools-html/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/devtools-html/subscriptions","organizations_url":"https://api.github.com/users/devtools-html/orgs","repos_url":"https://api.github.com/users/devtools-html/repos","events_url":"https://api.github.com/users/devtools-html/events{/privacy}","received_events_url":"https://api.github.com/users/devtools-html/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/devtools-html/debugger.html","description":"The Firefox debugger that works anywhere :boom:","fork":false,"url":"https://api.github.com/repos/devtools-html/debugger.html","forks_url":"https://api.github.com/repos/devtools-html/debugger.html/forks","keys_url":"https://api.github.com/repos/devtools-html/debugger.html/keys{/key_id}","collaborators_url":"https://api.github.com/repos/devtools-html/debugger.html/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/devtools-html/debugger.html/teams","hooks_url":"https://api.github.com/repos/devtools-html/debugger.html/hooks","issue_events_url":"https://api.github.com/repos/devtools-html/debugger.html/issues/events{/number}","events_url":"https://api.github.com/repos/devtools-html/debugger.html/events","assignees_url":"https://api.github.com/repos/devtools-html/debugger.html/assignees{/user}","branches_url":"https://api.github.com/repos/devtools-html/debugger.html/branches{/branch}","tags_url":"https://api.github.com/repos/devtools-html/debugger.html/tags","blobs_url":"https://api.github.com/repos/devtools-html/debugger.html/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/devtools-html/debugger.html/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/devtools-html/debugger.html/git/refs{/sha}","trees_url":"https://api.github.com/repos/devtools-html/debugger.html/git/trees{/sha}","statuses_url":"https://api.github.com/repos/devtools-html/debugger.html/statuses/{sha}","languages_url":"https://api.github.com/repos/devtools-html/debugger.html/languages","stargazers_url":"https://api.github.com/repos/devtools-html/debugger.html/stargazers","contributors_url":"https://api.github.com/repos/devtools-html/debugger.html/contributors","subscribers_url":"https://api.github.com/repos/devtools-html/debugger.html/subscribers","subscription_url":"https://api.github.com/repos/devtools-html/debugger.html/subscription","commits_url":"https://api.github.com/repos/devtools-html/debugger.html/commits{/sha}","git_commits_url":"https://api.github.com/repos/devtools-html/debugger.html/git/commits{/sha}","comments_url":"https://api.github.com/repos/devtools-html/debugger.html/comments{/number}","issue_comment_url":"https://api.github.com/repos/devtools-html/debugger.html/issues/comments{/number}","contents_url":"https://api.github.com/repos/devtools-html/debugger.html/contents/{+path}","compare_url":"https://api.github.com/repos/devtools-html/debugger.html/compare/{base}...{head}","merges_url":"https://api.github.com/repos/devtools-html/debugger.html/merges","archive_url":"https://api.github.com/repos/devtools-html/debugger.html/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/devtools-html/debugger.html/downloads","issues_url":"https://api.github.com/repos/devtools-html/debugger.html/issues{/number}","pulls_url":"https://api.github.com/repos/devtools-html/debugger.html/pulls{/number}","milestones_url":"https://api.github.com/repos/devtools-html/debugger.html/milestones{/number}","notifications_url":"https://api.github.com/repos/devtools-html/debugger.html/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/devtools-html/debugger.html/labels{/name}","releases_url":"https://api.github.com/repos/devtools-html/debugger.html/releases{/id}","deployments_url":"https://api.github.com/repos/devtools-html/debugger.html/deployments","created_at":"2016-03-23T18:55:36Z","updated_at":"2018-10-23T23:18:44Z","pushed_at":"2018-10-24T07:34:34Z","git_url":"git://github.com/devtools-html/debugger.html.git","ssh_url":"[email protected]:devtools-html/debugger.html.git","clone_url":"https://github.com/devtools-html/debugger.html.git","svn_url":"https://github.com/devtools-html/debugger.html","homepage":"https://devtools-html.github.io/debugger.html/","size":29037,"stargazers_count":4033,"watchers_count":4033,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":718,"mirror_url":null,"archived":false,"open_issues_count":248,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":718,"open_issues":248,"watchers":4033,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/devtools-html/debugger.html/pulls/7147"},"html":{"href":"https://github.com/devtools-html/debugger.html/pull/7147"},"issue":{"href":"https://api.github.com/repos/devtools-html/debugger.html/issues/7147"},"comments":{"href":"https://api.github.com/repos/devtools-html/debugger.html/issues/7147/comments"},"review_comments":{"href":"https://api.github.com/repos/devtools-html/debugger.html/pulls/7147/comments"},"review_comment":{"href":"https://api.github.com/repos/devtools-html/debugger.html/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/devtools-html/debugger.html/pulls/7147/commits"},"statuses":{"href":"https://api.github.com/repos/devtools-html/debugger.html/statuses/875f440386eb690cf45832b41bf2a77524e47a53"}},"author_association":"CONTRIBUTOR"}} | {
"id": 54585418,
"name": "devtools-html/debugger.html",
"url": "https://api.github.com/repos/devtools-html/debugger.html"
} | {
"id": 46655,
"login": "darkwing",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/46655?",
"url": "https://api.github.com/users/darkwing"
} | {
"id": 19979421,
"login": "devtools-html",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/19979421?",
"url": "https://api.github.com/orgs/devtools-html"
} | 2018-10-24T11:57:59 | 8472665167 | {"actor":{"display_login":"darkwing"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/iotaledger/iri/pulls/comments/232701274","pull_request_review_id":173942724,"id":232701274,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMjcwMTI3NA==","diff_hunk":"@@ -244,6 +347,29 @@ void propagateSolidTransactions() {\n }\n }\n \n+\n+ /**\n+ * Updates a transaction after it was stored in the tangle. Tells the node to not request the transaction anymore,\n+ * to update the live tips accordingly, and attempts to solidify the transaction.\n+ *\n+ * <p/>\n+ * Performs the following operations:\n+ *\n+ * <ol>\n+ * <li>Removes {@code transactionViewModel}'s hash from the the request queue since we already found it.</li>\n+ * <li>If {@code transactionViewModel} has no children, we add it to the node's active tip list</li>\n+ * <li>Removes {@code transactionViewModel}'s parents from the node's tip list (if they're present there)</li>\n+ * <li>Attempts to quickly solidify {@code transactionViewModel} by checking whether its direct parents\n+ * are soild. If solid we add it to the queue transaction solidification thread to help it propagate the","path":"src/main/java/com/iota/iri/TransactionValidator.java","position":217,"original_position":217,"commit_id":"5761c81bdee969833d24d22069a3d7e246cfb69d","original_commit_id":"5761c81bdee969833d24d22069a3d7e246cfb69d","user":{"login":"alon-e","id":25587995,"node_id":"MDQ6VXNlcjI1NTg3OTk1","avatar_url":"https://avatars3.githubusercontent.com/u/25587995?v=4","gravatar_id":"","url":"https://api.github.com/users/alon-e","html_url":"https://github.com/alon-e","followers_url":"https://api.github.com/users/alon-e/followers","following_url":"https://api.github.com/users/alon-e/following{/other_user}","gists_url":"https://api.github.com/users/alon-e/gists{/gist_id}","starred_url":"https://api.github.com/users/alon-e/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alon-e/subscriptions","organizations_url":"https://api.github.com/users/alon-e/orgs","repos_url":"https://api.github.com/users/alon-e/repos","events_url":"https://api.github.com/users/alon-e/events{/privacy}","received_events_url":"https://api.github.com/users/alon-e/received_events","type":"User","site_admin":false},"body":"```suggestion\r\n * are solid. If solid we add it to the queue transaction solidification thread to help it propagate the\r\n```","created_at":"2018-11-12T15:28:32Z","updated_at":"2018-11-12T15:35:55Z","html_url":"https://github.com/iotaledger/iri/pull/1142#discussion_r232701274","pull_request_url":"https://api.github.com/repos/iotaledger/iri/pulls/1142","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/iotaledger/iri/pulls/comments/232701274"},"html":{"href":"https://github.com/iotaledger/iri/pull/1142#discussion_r232701274"},"pull_request":{"href":"https://api.github.com/repos/iotaledger/iri/pulls/1142"}}},"pull_request":{"url":"https://api.github.com/repos/iotaledger/iri/pulls/1142","id":230140016,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMwMTQwMDE2","html_url":"https://github.com/iotaledger/iri/pull/1142","diff_url":"https://github.com/iotaledger/iri/pull/1142.diff","patch_url":"https://github.com/iotaledger/iri/pull/1142.patch","issue_url":"https://api.github.com/repos/iotaledger/iri/issues/1142","number":1142,"state":"open","locked":false,"title":"Transaction Validator Documentation","user":{"login":"GalRogozinski","id":7954839,"node_id":"MDQ6VXNlcjc5NTQ4Mzk=","avatar_url":"https://avatars3.githubusercontent.com/u/7954839?v=4","gravatar_id":"","url":"https://api.github.com/users/GalRogozinski","html_url":"https://github.com/GalRogozinski","followers_url":"https://api.github.com/users/GalRogozinski/followers","following_url":"https://api.github.com/users/GalRogozinski/following{/other_user}","gists_url":"https://api.github.com/users/GalRogozinski/gists{/gist_id}","starred_url":"https://api.github.com/users/GalRogozinski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GalRogozinski/subscriptions","organizations_url":"https://api.github.com/users/GalRogozinski/orgs","repos_url":"https://api.github.com/users/GalRogozinski/repos","events_url":"https://api.github.com/users/GalRogozinski/events{/privacy}","received_events_url":"https://api.github.com/users/GalRogozinski/received_events","type":"User","site_admin":false},"body":"# Description\r\n\r\nDocument `Transaction Validator`\r\n\r\nFixes #1107\r\n\r\n## Type of change\r\n\r\n- Documentation Fix","created_at":"2018-11-12T13:48:00Z","updated_at":"2018-11-12T15:35:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e0fec66446f86a9f68f76212d4f58644e8262585","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/iotaledger/iri/pulls/1142/commits","review_comments_url":"https://api.github.com/repos/iotaledger/iri/pulls/1142/comments","review_comment_url":"https://api.github.com/repos/iotaledger/iri/pulls/comments{/number}","comments_url":"https://api.github.com/repos/iotaledger/iri/issues/1142/comments","statuses_url":"https://api.github.com/repos/iotaledger/iri/statuses/5761c81bdee969833d24d22069a3d7e246cfb69d","head":{"label":"GalRogozinski:document-transactionvalidator","ref":"document-transactionvalidator","sha":"5761c81bdee969833d24d22069a3d7e246cfb69d","user":{"login":"GalRogozinski","id":7954839,"node_id":"MDQ6VXNlcjc5NTQ4Mzk=","avatar_url":"https://avatars3.githubusercontent.com/u/7954839?v=4","gravatar_id":"","url":"https://api.github.com/users/GalRogozinski","html_url":"https://github.com/GalRogozinski","followers_url":"https://api.github.com/users/GalRogozinski/followers","following_url":"https://api.github.com/users/GalRogozinski/following{/other_user}","gists_url":"https://api.github.com/users/GalRogozinski/gists{/gist_id}","starred_url":"https://api.github.com/users/GalRogozinski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GalRogozinski/subscriptions","organizations_url":"https://api.github.com/users/GalRogozinski/orgs","repos_url":"https://api.github.com/users/GalRogozinski/repos","events_url":"https://api.github.com/users/GalRogozinski/events{/privacy}","received_events_url":"https://api.github.com/users/GalRogozinski/received_events","type":"User","site_admin":false},"repo":{"id":111612948,"node_id":"MDEwOlJlcG9zaXRvcnkxMTE2MTI5NDg=","name":"iri","full_name":"GalRogozinski/iri","private":false,"owner":{"login":"GalRogozinski","id":7954839,"node_id":"MDQ6VXNlcjc5NTQ4Mzk=","avatar_url":"https://avatars3.githubusercontent.com/u/7954839?v=4","gravatar_id":"","url":"https://api.github.com/users/GalRogozinski","html_url":"https://github.com/GalRogozinski","followers_url":"https://api.github.com/users/GalRogozinski/followers","following_url":"https://api.github.com/users/GalRogozinski/following{/other_user}","gists_url":"https://api.github.com/users/GalRogozinski/gists{/gist_id}","starred_url":"https://api.github.com/users/GalRogozinski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GalRogozinski/subscriptions","organizations_url":"https://api.github.com/users/GalRogozinski/orgs","repos_url":"https://api.github.com/users/GalRogozinski/repos","events_url":"https://api.github.com/users/GalRogozinski/events{/privacy}","received_events_url":"https://api.github.com/users/GalRogozinski/received_events","type":"User","site_admin":false},"html_url":"https://github.com/GalRogozinski/iri","description":"IOTA Reference Implementation","fork":true,"url":"https://api.github.com/repos/GalRogozinski/iri","forks_url":"https://api.github.com/repos/GalRogozinski/iri/forks","keys_url":"https://api.github.com/repos/GalRogozinski/iri/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GalRogozinski/iri/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GalRogozinski/iri/teams","hooks_url":"https://api.github.com/repos/GalRogozinski/iri/hooks","issue_events_url":"https://api.github.com/repos/GalRogozinski/iri/issues/events{/number}","events_url":"https://api.github.com/repos/GalRogozinski/iri/events","assignees_url":"https://api.github.com/repos/GalRogozinski/iri/assignees{/user}","branches_url":"https://api.github.com/repos/GalRogozinski/iri/branches{/branch}","tags_url":"https://api.github.com/repos/GalRogozinski/iri/tags","blobs_url":"https://api.github.com/repos/GalRogozinski/iri/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GalRogozinski/iri/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GalRogozinski/iri/git/refs{/sha}","trees_url":"https://api.github.com/repos/GalRogozinski/iri/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GalRogozinski/iri/statuses/{sha}","languages_url":"https://api.github.com/repos/GalRogozinski/iri/languages","stargazers_url":"https://api.github.com/repos/GalRogozinski/iri/stargazers","contributors_url":"https://api.github.com/repos/GalRogozinski/iri/contributors","subscribers_url":"https://api.github.com/repos/GalRogozinski/iri/subscribers","subscription_url":"https://api.github.com/repos/GalRogozinski/iri/subscription","commits_url":"https://api.github.com/repos/GalRogozinski/iri/commits{/sha}","git_commits_url":"https://api.github.com/repos/GalRogozinski/iri/git/commits{/sha}","comments_url":"https://api.github.com/repos/GalRogozinski/iri/comments{/number}","issue_comment_url":"https://api.github.com/repos/GalRogozinski/iri/issues/comments{/number}","contents_url":"https://api.github.com/repos/GalRogozinski/iri/contents/{+path}","compare_url":"https://api.github.com/repos/GalRogozinski/iri/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GalRogozinski/iri/merges","archive_url":"https://api.github.com/repos/GalRogozinski/iri/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GalRogozinski/iri/downloads","issues_url":"https://api.github.com/repos/GalRogozinski/iri/issues{/number}","pulls_url":"https://api.github.com/repos/GalRogozinski/iri/pulls{/number}","milestones_url":"https://api.github.com/repos/GalRogozinski/iri/milestones{/number}","notifications_url":"https://api.github.com/repos/GalRogozinski/iri/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GalRogozinski/iri/labels{/name}","releases_url":"https://api.github.com/repos/GalRogozinski/iri/releases{/id}","deployments_url":"https://api.github.com/repos/GalRogozinski/iri/deployments","created_at":"2017-11-21T23:27:08Z","updated_at":"2018-10-28T10:51:00Z","pushed_at":"2018-11-12T15:14:33Z","git_url":"git://github.com/GalRogozinski/iri.git","ssh_url":"[email protected]:GalRogozinski/iri.git","clone_url":"https://github.com/GalRogozinski/iri.git","svn_url":"https://github.com/GalRogozinski/iri","homepage":null,"size":177393,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":5,"watchers":0,"default_branch":"dev"}},"base":{"label":"iotaledger:dev","ref":"dev","sha":"fcf2d105851ee891b093e2857592fa05258ec5be","user":{"login":"iotaledger","id":20126597,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwMTI2NTk3","avatar_url":"https://avatars3.githubusercontent.com/u/20126597?v=4","gravatar_id":"","url":"https://api.github.com/users/iotaledger","html_url":"https://github.com/iotaledger","followers_url":"https://api.github.com/users/iotaledger/followers","following_url":"https://api.github.com/users/iotaledger/following{/other_user}","gists_url":"https://api.github.com/users/iotaledger/gists{/gist_id}","starred_url":"https://api.github.com/users/iotaledger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iotaledger/subscriptions","organizations_url":"https://api.github.com/users/iotaledger/orgs","repos_url":"https://api.github.com/users/iotaledger/repos","events_url":"https://api.github.com/users/iotaledger/events{/privacy}","received_events_url":"https://api.github.com/users/iotaledger/received_events","type":"Organization","site_admin":false},"repo":{"id":71836159,"node_id":"MDEwOlJlcG9zaXRvcnk3MTgzNjE1OQ==","name":"iri","full_name":"iotaledger/iri","private":false,"owner":{"login":"iotaledger","id":20126597,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwMTI2NTk3","avatar_url":"https://avatars3.githubusercontent.com/u/20126597?v=4","gravatar_id":"","url":"https://api.github.com/users/iotaledger","html_url":"https://github.com/iotaledger","followers_url":"https://api.github.com/users/iotaledger/followers","following_url":"https://api.github.com/users/iotaledger/following{/other_user}","gists_url":"https://api.github.com/users/iotaledger/gists{/gist_id}","starred_url":"https://api.github.com/users/iotaledger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iotaledger/subscriptions","organizations_url":"https://api.github.com/users/iotaledger/orgs","repos_url":"https://api.github.com/users/iotaledger/repos","events_url":"https://api.github.com/users/iotaledger/events{/privacy}","received_events_url":"https://api.github.com/users/iotaledger/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/iotaledger/iri","description":"IOTA Reference Implementation","fork":false,"url":"https://api.github.com/repos/iotaledger/iri","forks_url":"https://api.github.com/repos/iotaledger/iri/forks","keys_url":"https://api.github.com/repos/iotaledger/iri/keys{/key_id}","collaborators_url":"https://api.github.com/repos/iotaledger/iri/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/iotaledger/iri/teams","hooks_url":"https://api.github.com/repos/iotaledger/iri/hooks","issue_events_url":"https://api.github.com/repos/iotaledger/iri/issues/events{/number}","events_url":"https://api.github.com/repos/iotaledger/iri/events","assignees_url":"https://api.github.com/repos/iotaledger/iri/assignees{/user}","branches_url":"https://api.github.com/repos/iotaledger/iri/branches{/branch}","tags_url":"https://api.github.com/repos/iotaledger/iri/tags","blobs_url":"https://api.github.com/repos/iotaledger/iri/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/iotaledger/iri/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/iotaledger/iri/git/refs{/sha}","trees_url":"https://api.github.com/repos/iotaledger/iri/git/trees{/sha}","statuses_url":"https://api.github.com/repos/iotaledger/iri/statuses/{sha}","languages_url":"https://api.github.com/repos/iotaledger/iri/languages","stargazers_url":"https://api.github.com/repos/iotaledger/iri/stargazers","contributors_url":"https://api.github.com/repos/iotaledger/iri/contributors","subscribers_url":"https://api.github.com/repos/iotaledger/iri/subscribers","subscription_url":"https://api.github.com/repos/iotaledger/iri/subscription","commits_url":"https://api.github.com/repos/iotaledger/iri/commits{/sha}","git_commits_url":"https://api.github.com/repos/iotaledger/iri/git/commits{/sha}","comments_url":"https://api.github.com/repos/iotaledger/iri/comments{/number}","issue_comment_url":"https://api.github.com/repos/iotaledger/iri/issues/comments{/number}","contents_url":"https://api.github.com/repos/iotaledger/iri/contents/{+path}","compare_url":"https://api.github.com/repos/iotaledger/iri/compare/{base}...{head}","merges_url":"https://api.github.com/repos/iotaledger/iri/merges","archive_url":"https://api.github.com/repos/iotaledger/iri/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/iotaledger/iri/downloads","issues_url":"https://api.github.com/repos/iotaledger/iri/issues{/number}","pulls_url":"https://api.github.com/repos/iotaledger/iri/pulls{/number}","milestones_url":"https://api.github.com/repos/iotaledger/iri/milestones{/number}","notifications_url":"https://api.github.com/repos/iotaledger/iri/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/iotaledger/iri/labels{/name}","releases_url":"https://api.github.com/repos/iotaledger/iri/releases{/id}","deployments_url":"https://api.github.com/repos/iotaledger/iri/deployments","created_at":"2016-10-24T22:06:06Z","updated_at":"2018-11-12T15:26:46Z","pushed_at":"2018-11-12T15:26:40Z","git_url":"git://github.com/iotaledger/iri.git","ssh_url":"[email protected]:iotaledger/iri.git","clone_url":"https://github.com/iotaledger/iri.git","svn_url":"https://github.com/iotaledger/iri","homepage":null,"size":177022,"stargazers_count":1064,"watchers_count":1064,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":374,"mirror_url":null,"archived":false,"open_issues_count":277,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":374,"open_issues":277,"watchers":1064,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/iotaledger/iri/pulls/1142"},"html":{"href":"https://github.com/iotaledger/iri/pull/1142"},"issue":{"href":"https://api.github.com/repos/iotaledger/iri/issues/1142"},"comments":{"href":"https://api.github.com/repos/iotaledger/iri/issues/1142/comments"},"review_comments":{"href":"https://api.github.com/repos/iotaledger/iri/pulls/1142/comments"},"review_comment":{"href":"https://api.github.com/repos/iotaledger/iri/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/iotaledger/iri/pulls/1142/commits"},"statuses":{"href":"https://api.github.com/repos/iotaledger/iri/statuses/5761c81bdee969833d24d22069a3d7e246cfb69d"}},"author_association":"MEMBER"}} | {
"id": 71836159,
"name": "iotaledger/iri",
"url": "https://api.github.com/repos/iotaledger/iri"
} | {
"id": 25587995,
"login": "alon-e",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/25587995?",
"url": "https://api.github.com/users/alon-e"
} | {
"id": 20126597,
"login": "iotaledger",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/20126597?",
"url": "https://api.github.com/orgs/iotaledger"
} | 2018-11-12T15:28:32 | 8574757918 | {"actor":{"display_login":"alon-e"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/dig-eg-gaz/content/pulls/comments/168072845","pull_request_review_id":95803723,"id":168072845,"diff_hunk":"@@ -292,1251 +326,3661 @@\n <p>BAGGAGE AND FORWARDING AGENTS.</p>\n <p>Officially appointed & Sole Agents in Cairo to the P.&O. S.N.\n Co.</p>\n- <p>RESIDENTS IN EGYPT procceding to Europe for the summe are requested to \n- applt to our offices for information respecting their passages,where steamer plans\n- may be consulted, and Bertha secured by all Lines of Steamers to all parts of the.\n- Globe; arrangements can also be made for the collection and forwarding of their baggage \n- and clearance at port of arrival.</p>\n+ <p>RESIDENTS IN EGYPT procceding to Europe for the summe are requested to\n+ applt to our offices for information respecting their passages,where\n+ steamer plans may be consulted, and Bertha secured by all Lines of\n+ Steamers to all parts of the. Globe; arrangements can also be made for\n+ the collection and forwarding of their baggage and clearance at port of\n+ arrival.</p>\n <p>CIRCULAR NOTES issued payable at the current rate of exchange in all the\n principal cities of Europe.</p>\n <p>WEEKLY FREIGHT SERVICE FROM CAIRO TO ASSUAN AND HALFA.</p>\n <p>Cook's Interpreters in uniform are present at principal Railway Stations\n and Landing-places in Europe to assist passengers holding their\n tickets.</p>\n- <p>Large and splendildly appointes steamers beloning to the Company leave Cairo\n- thrice weekly, between November and March, for Luxor, Assonan and Wady Fhalfa in \n- connection with trains de luxe to Khartonm. Moderate Fares.</p>\n- <p>FREIGHT SERVICE. Steamers leave Cairo every Saturday fo Assonan and Halfs.</p>\n- <p>Special combined rail and steamer Nile Tours at greatly reduced prices. \n- Special Steamers and Dahabeahs for Private Parties.</p>\n+ <p>Large and splendildly appointes steamers beloning to the Company leave\n+ Cairo thrice weekly, between November and March, for Luxor, Assonan and\n+ Wady Fhalfa in connection with trains de luxe to Khartonm. Moderate\n+ Fares.</p>\n+ <p>FREIGHT SERVICE. Steamers leave Cairo every Saturday fo Assonan and\n+ Halfs.</p>\n+ <p>Special combined rail and steamer Nile Tours at greatly reduced prices.\n+ Special Steamers and Dahabeahs for Private Parties.</p>\n <p>Special arrangements for tour in PALESTINE, SYRIA and the DESERT; Lowest\n rates.</p>\n <p>Best camp equipment in the country.</p>\n </div>\n- </div>\n- <cb n=\"2\" /> \n- <div type=\"advert\" xml:id=\"deg-ad-bis02\">\n- <head>British India S. N. Company, Limited.</head>\n- <p>Fortnightly Service in connection with the Co's Indian Mail Lines.-- Calling at\n- ADEN, COLOMBO, MADRAS, and CALCUTTA Out, and MARSEILLES (GENOA and PLYMOUTH\n- optional) Home. Sailings from Suez.</p>\n- <p>OUTWARD.—<name>Golconda</name> ... <date when=\"1907-04-26\">April 26</date>\n- | HOMEWARD.—<name>Matiana</name> ... <date when=\"1907-04-24\">April\n- 24</date></p>\n- <p>EAST AFRICAN LINE OF STEAMERS.</p>\n- <p>Calling at Aden, Mombasa, Zanzibar and Beira. Monthly service.</p>\n- <table rows=\"2\" cols=\"9\">\n- <row>\n- <cell rows=\"3\">First Class Fares from Suez to</cell>\n- <cell>Aden</cell>\n- <cell>£11. 8</cell>\n- <cell>Colombo</cell>\n- <cell>£25.15</cell>\n- <cell>Calcutta</cell>\n- <cell>£31. 0</cell>\n- <cell>Marseilles</cell>\n- <cell>£15.12</cell>\n- </row>\n- <row>\n- <cell rows=\"2\">Bombay</cell>\n- <cell rows=\"2\">£31.10</cell>\n- <cell>Madras</cell>\n- <cell>£20.11</cell>\n- <cell>Genoa</cell>\n- <cell>£13.10</cell>\n- <cell rows=\"2\">London</cell>\n- <cell rows=\"2\">£19. 0</cell>\n- </row>\n- <row>\n- <cell>Mombasa</cell>\n- <cell>£26.10</cell>\n- <cell>Zanzibar</cell>\n- <cell>£30. 0</cell>\n- </row>\n- </table>\n- <p>From Port-Said £2 less Homeward, and £2 more Outward. Second class, two thirds of\n- 1st Class Fares.</p>\n- <p>PORT SAID Agents: Worms & Co. and Willi & Co., Ltd. -- CAIRO &\n- ALEXANDRIA: --Thos. Cook & Son, Ltd., and the Anglo-American Hotel &\n- Steamer Co. For particulars apply G. BEYTS & Co., Suez. <measure\n- type=\"indexNo\">31-12-906</measure></p>\n- </div><div type=\"advert\" xml:id=\"deg-ad-all01\">\n- <head>ANCHOR LINE, LIMITED.</head>\n- <p>(HENDERSON BROTHERS,) LONDON, LIVERPOOL AND GLASGOW.</p>\n- <p>Booking Passengers and Cargo through to Ports in India, Europe nad America</p>\n- <p>First class passengers steamers. Sailing fortnightly from Suez.</p>\n- <table rows=\"2\" cols=\"6\">\n- <row>\n- <cell>For MARSEILLES & LIVERPOOL</cell>\n- <cell><name>S.S. “Massllia”</name></cell>\n- <cell><date when=\"1907-04-27\">April 27</date></cell>\n- <cell>For CALCUTTA</cell>\n- <cell><name>S.S. \"Drahoman\"</name></cell>\n- <cell><date when=\"1907-04-19\">April 19</date></cell>\n- </row>\n- <row>\n- <cell>For LONDON</cell>\n- <cell><name>S.S. “Bohemia\"</name></cell>\n- <cell><date when=\"1907-04-08\">April 08</date></cell>\n- <cell>For BOMBAY</cell>\n- <cell><name>S.S. \"Australia\"</name></cell>\n- <cell><date when=\"1907-04-25\">April 25</date></cell>\n- </row>\n- </table>\n- <p>Saloon Fares: from Port Said to Gibraltar £9, Marseilles £9, London and Liverpool\n- £14; add £1 to above fare for passengers from Cairo, Ismailia, or Suez. 5 %\n- reduction to families of three or more adults. 15 % reduction on return tickets\n- within 6 months. Reduced rates on streamers not carrying surgeon and stewardess.\n- <measure type=\"indexNo\">31-12-906</measure></p>\n- <p>Agents: Cairo, Thos. Cook & Son. Port-Said, Cory Brothers & Co. -- For\n- further particulars apply G. BEYTS & Co., Suez. </p>\n- </div> <div type=\"advert\" xml:id=\"deg-ad-doa02\">\n- <head>Deutsche Ost Afrika Linie.</head>\n- <p>Regelmässiger Reichspostdampferdienst. German E. African Line. Imperial Service.\n- Departures from Port Said (Approximate Dates.)</p>\n- <p>OUT to Aden, Zanzibar, Cape Town and intermediate ports:--</p>\n- <p><name>S. S. Prasident</name>\n- <date when=\"1907-04-07\">April 7</date> | <name>S. S. Konig</name> <!-- how do I that weird o-->\n- <date when=\"1907-04-19\">April 19</date></p>\n- <p>HOME to Naples, Genoa, Marseilles, Algiers, Tangiers, Lisbon, Dover, Flushing,\n- and Hamburg.</p>\n- <p><name>S. S. Markgraf</name>\n- <date when=\"1907-04-13\">April 13</date> | <name>S. S. Prinzregent</name>\n- <date when=\"1907-04-24\">April 24</date></p>\n- <p>First class steamers fitted with latest improvements. Stewardesses and doctors\n- carried. Low passage rates.</p>\n- <p>Splendid accommodation for passengars of all classes.</p>\n- <p>For all particulars apply to <orgName>Fix & David</orgName>, CAIRO (Sharia Mansour Pacha,\n- Telephone 865).</p>\n- </div> <div type=\"advert\" xml:id=\"deg-ad-mma01\">\n- <head>Messageries Maritimes.</head>\n- <p>From Alexandria</p>\n- <table rows=\"12\" cols=\"5\">\n- <head><hi rend=\"bold\">Sailing from Alexandria in March, 1907.</hi></head>\n- <row>\n- <cell cols=\"5\"><hi rend=\"bold\">For Marseilles direct</hi></cell>\n- </row>\n- <row>\n- <cell>Friday</cell>\n- <cell><date when=\"1907-04-19\">19 April</date></cell>\n- <cell>at 4 p.m.</cell>\n- <cell>Orenoque</cell>\n- <cell>Capt. Lassince</cell>\n- </row>\n- <row>\n- <cell>Friday</cell>\n- <cell><date when=\"1907-04-26\">26 April</date></cell>\n- <cell>at 4 p.m.</cell>\n- <cell>Portugal</cell>\n- <cell>Capt. Protet</cell>\n- </row>\n- <row>\n- <cell>Friday</cell>\n- <cell><date when=\"1907-05-03\">3 May</date></cell>\n- <cell>at 4 p.m.</cell>\n- <cell>Niger</cell>\n- <cell>Capt. X</cell>\n- </row>\n- <row>\n- <cell>Friday</cell>\n- <cell><date when=\"1907-05-10\">10 May</date></cell>\n- <cell>at 4 p.m.</cell>\n- <cell>Congo</cell>\n- <cell>Capt. Baretge</cell>\n- </row>\n- <row>\n- <cell>Friday</cell>\n- <cell><date when=\"1907-05-17\">17 May</date></cell>\n- <cell>at 4 p.m.</cell>\n- <cell>Orenoque</cell>\n- <cell>Capt. Lassince</cell>\n- </row>\n- <row>\n- <cell cols=\"5\"><hi rend=\"bold\">For Port Said and Beyrouth</hi></cell>\n- </row>\n- <row>\n- <cell>Thursday</cell>\n- <cell><date when=\"1907-04-18\">18 April</date></cell>\n- <cell>at 8 a.m.</cell>\n- <cell>Portugal</cell>\n- <cell>Capt. Protet</cell>\n- </row>\n- <row>\n- <cell>Thursday</cell>\n- <cell><date when=\"1907-05-02\">2 May</date></cell>\n- <cell>at 8 a.m.</cell>\n- <cell>Congo</cell>\n- <cell>Capt. Baretge</cell>\n- </row>\n- <row>\n- <cell cols=\"5\"><hi rend=\"bold\">For Port Said, Jaffa and Beyrouth</hi></cell>\n- </row>\n- <row>\n- <cell>Thursday</cell>\n- <cell><date when=\"1907-04-25\">25 April</date></cell>\n- <cell>at 8 a.m.</cell>\n- <cell>Niger</cell>\n- <cell>Capt. X</cell>\n- </row>\n- <row>\n- <cell>Thursday</cell>\n- <cell><date when=\"1907-05-09\">9 May</date></cell>\n- <cell>at 8 a.m.</cell>\n- <cell>Orenogue</cell>\n- <cell>Capt. Lassince</cell>\n- </row>\n- </table>\n- <table rows=\"8\" cols=\"3\">\n- <head><hi rend=\"bold\">Rates of passage mess</hi></head>\n- <head type=\"sub\">Including table wine.</head>\n- <row role=\"label\">\n- <cell/>\n- <cell>1st Class</cell>\n- <cell>2nd Class</cell>\n- </row>\n- <row>\n- <cell>From Alexandria or Port Said (directly or via Alexandria) To\n- Marseilles</cell>\n- <cell>£12.9.8</cell>\n- <cell>£9.10.3</cell>\n- </row>\n- <row>\n- <cell>From Alexandria To Port Said</cell>\n- <cell>£1.15.10</cell>\n- <cell>£1.7.10</cell>\n- </row>\n- <row>\n- <cell>From Alexandria to Jaffa</cell>\n- <cell>£3.3.5</cell>\n- <cell>£2.3.5</cell>\n- </row>\n- <row>\n- <cell>From Alexandria to Beyrouth</cell>\n- <cell>£4.7.2</cell>\n- <cell>£3.5.2.</cell>\n- </row>\n- <row>\n- <cell>Through tickets for Paris (via Marseilles from Alexandria)</cell>\n- <cell>£15.12.1</cell>\n- <cell>£10.12.5</cell>\n- </row>\n- <row>\n- <cell>Through tickets for Paris (via Marseilles) from Port Said (directly or\n- via Alexandria)</cell>\n- <cell>£16.5.11</cell>\n- <cell>£13.1.5</cell>\n- </row>\n- <row>\n- <cell>Through tickets for London (via Marseilles) (Calais-Douvree) from\n- Alexandria or Port Said (directly or via Alexandria)</cell>\n- <cell>£16.12.10</cell>\n- <cell>£12.9.8</cell>\n- </row>\n- <row>\n- <cell>Interchangeable return tickets with the Austrian Lloyd Cy. (available\n- one way by Messageries Maritimes and on return by Austrian Lloyd) (via Tricate)</cell>\n- <cell>£31.11.10</cell>\n- <cell>£15.11.2</cell>\n- </row>\n- </table>\n- <table rend=\"frame\" xml:id=\"SailingfromPortSaid\">\n- <head><hi rend=\"bold\">Sailing from Port Said in April, 1907</hi></head>\n- <row>\n- <cell rows=\"5\">For Marseilles Direct</cell>\n- <cell>Probably on</cell>\n- <cell>Tuesday</cell>\n- <cell><date when=\"1907-04-09\">9 April</date></cell>\n- <cell>Orus</cell>\n- <cell>Capt. Riviere</cell>\n- <cell>returning from Indian Ocean</cell>\n- </row>\n- <row>\n- <cell>Probably on</cell>\n- <cell>Thursday</cell>\n- <cell><date when=\"1907-04-11\">11 April</date></cell>\n- <cell>Tonkin</cell>\n- <cell>Capt. Charbonnel</cell>\n- <cell>returning from China</cell>\n- </row>\n- <row>\n- <cell>Probably on</cell>\n- <cell>Saturday</cell>\n- <cell><date when=\"1907-04-20\">20 April</date></cell>\n- <cell>Caledonian</cell>\n- <cell>Capt. Chamayou</cell>\n- <cell>returning from Indian Ocean</cell>\n- </row>\n- <row>\n- <cell>Probably on</cell>\n- <cell>Thursday</cell>\n- <cell><date when=\"1907-04-25\">25 April</date></cell>\n- <cell>Ernest-Simons</cell>\n- <cell>Capt. Girard</cell>\n- <cell>returning from China</cell>\n- </row>\n- <row>\n- <cell>Probably on</cell>\n- <cell>Sunday</cell>\n- <cell><date when=\"1907-04-28\">28 April</date></cell>\n- <cell>Sydney</cell>\n- <cell>Capt. Barillon</cell>\n- <cell>returning from Australia</cell>\n- </row>\n- </table>\n- <table rend=\"frame\" xml:id=\"SailingfromSuez\">\n- <head><hi rend=\"bold\">Sailing from Suez in April, 1907</hi></head>\n- <row>\n- <cell rows=\"2\">For Aden, Colombo, Singapore, Saigon, Hong-Kong, Shanghai,\n- Kobe and Yokohama</cell>\n- <cell>Saturday</cell>\n- <cell><date when=\"1907-04-08\">8 April</date></cell>\n- <cell>Oceanien</cell>\n- <cell>Capt. Maguen</cell>\n- </row>\n- <row>\n- <cell>For Djibouti, Colombo, Singapore, Saigon, Hong-Kong, Shanghai, Kobe\n- and Yokohama</cell>\n- <cell>Saturday</cell>\n- <cell><date when=\"1907-04-20\">2) April</date></cell>\n- <cell>Tourane</cell>\n- <cell>Capt. Lancelio</cell>\n- </row>\n- <row>\n- <cell>For Djibouti, Zanzibar, Mutsamudu, Mayotte, Majunga, Nossi-Bé, D.\n- Suares, Tamatave, La Réunion and Maurice</cell>\n- <cell>Tuesday</cell>\n- <cell><date when=\"1907-04-16\">16 April</date></cell>\n- <cell>Adour</cell>\n- <cell>Capt. Riquier</cell>\n- </row>\n- <row>\n- <cell rows=\"2\">For Djibouti, Aden, Mabé Diego-Suares, Ste. Marie, Tamatave,\n- La Réunion and Maurice</cell>\n- <cell>Thursday</cell>\n- <cell><date when=\"1907-05-01\">1 May</date></cell>\n- <cell>Oxus</cell>\n- <cell>Capt. Riviere</cell>\n- </row>\n- <row>\n- <cell>For Aden, Bombay, Colombo, Freemantle, Adelaide, Melbourne, Sidney, and\n- Noumes</cell>\n- <cell>Monday</cell>\n- <cell><date when=\"1907-04-01\">1 April</date></cell>\n- <cell>Nera</cell>\n- <cell>Capt. Schmidt</cell>\n- </row>\n- </table>\n- <p>Cairo Agency (Shepheard's Hotel) <measure type=\"indexNo\">8-22-90</measure></p>\n- </div><div type=\"advert\" xml:id=\"deg-ad-pri02\">\n- <head>PRINCE LINE.</head>\n- <table rend=\"frame\" xml:id=\"Table1\">\n- <row>\n- <cell>Calabrian Prince (bldg)</cell>\n- <cell>Tons 12,000</cell>\n- <cell>Tuscan Prince (bldg)</cell>\n- <cell>Tons 12,000</cell>\n- <cell>Flemish Prince (bldg)</cell>\n- <cell>Tons 10,250</cell>\n- </row>\n- <row>\n- <cell>Corsican Prince</cell>\n- <cell>Tons 10,250</cell>\n- <cell>Welsh Prince</cell>\n- <cell>Tons 8,400</cell>\n- <cell>Norse Prince</cell>\n- <cell>Tons 10,250</cell>\n- </row>\n- <row>\n- <cell>Afghan Prince</cell>\n- <cell>Tons 8,400</cell>\n- <cell>Black Prince</cell>\n- <cell>Tons 7,000</cell>\n- <cell>African Prince</cell>\n- <cell>Tons 8,400</cell>\n- </row>\n- <row>\n- <cell>Tudor Prince</cell>\n- <cell>Tons 7,200</cell>\n- <cell>Crown Prince</cell>\n- <cell>Tons 5,050</cell>\n- <cell>Saxon Prince</cell>\n- <cell>Tons 6,000</cell>\n- </row>\n- <row>\n- <cell>Norman Prince</cell>\n- <cell>Tons 6,000</cell>\n- <cell>Egyptian Prince</cell>\n- <cell>Tons 4,950</cell>\n- <cell>Italian Prince</cell>\n- <cell>Tons 5,000</cell>\n- </row>\n- <row>\n- <cell>Merchant Prince</cell>\n- <cell>Tons 4,950</cell>\n- <cell>Trojan Prince</cell>\n- <cell>Tons 4,900</cell>\n- <cell>Sailor Prince</cell>\n- <cell>Tons 4,950</cell>\n- </row>\n- <row>\n- <cell>Soldier Prince</cell>\n- <cell>Tons 4,950</cell>\n- <cell>Russian Prince</cell>\n- <cell>Tons 4,400</cell>\n- <cell>Georgian Prince</cell>\n- <cell>Tons 4,750</cell>\n- </row>\n- <row>\n- <cell>Spartan Prince</cell>\n- <cell>Tons 4,650</cell>\n- <cell>Sicilian Prince</cell>\n- <cell>Tons 4,000</cell>\n- <cell>Mexican Prince</cell>\n- <cell>Tons 4,400</cell>\n- </row>\n- <row>\n- <cell>Napolitan Prince</cell>\n- <cell>Tons 4,000</cell>\n- <cell>Moorish Prince</cell>\n- <cell>Tons 3,200</cell>\n- <cell>Highland Prince</cell>\n- <cell>Tons 3,900</cell>\n- </row>\n- <row>\n- <cell>Imperial Prince</cell>\n- <cell>Tons 3,750</cell>\n- <cell>Castillian Prince</cell>\n- <cell>Tons 3,100</cell>\n- <cell>British Prince</cell>\n- <cell>Tons 3,200</cell>\n- </row>\n- <row>\n- <cell>Grecian Prince</cell>\n- <cell>Tons 3,150</cell>\n- <cell>Creole Prince</cell>\n- <cell>Tons 3,100</cell>\n- <cell>Carib Prince</cell>\n- <cell>Tons 3,100</cell>\n- </row>\n- <row>\n- <cell>Eastern Prince</cell>\n- <cell>Tons 3,100</cell>\n- <cell>Asiatic Prince</cell>\n- <cell>Tons 3,050</cell>\n- <cell>Persian Prince</cell>\n- <cell>Tons 3,100</cell>\n- </row>\n- <row>\n- <cell>Kaffir Prince</cell>\n- <cell>Tons 3, 50</cell>\n- <cell>Cyprian Prince</cell>\n- <cell>Tons 2,750</cell>\n- <cell>Syrian Prince</cell>\n- <cell>Tons 3,000</cell>\n- </row>\n- <row>\n- <cell>Orange Prince</cell>\n- <cell>Tons 2,850</cell>\n- <cell>Roman Prince</cell>\n- <cell>Tons 2,600</cell>\n- <cell>Indian Prince</cell>\n- <cell>Tons 2,750</cell>\n- </row>\n- <row>\n- <cell>Scottish Prince</cell>\n- <cell>Tons 2,600</cell>\n- <cell>Royal Prince</cell>\n- <cell>Tons 2,300</cell>\n- <cell>Ocean Prince</cell>\n- <cell>Tons 2,450</cell>\n- </row>\n- </table>\n- <p>Good passengers accommodation . -- C. J. GRACE & Co., Alexandria, Agents.</p>\n- <p>Sailings every 10 days from Manchester and Liverpool and fortnightly from Antwerp\n- and London to Alexandria and Syrian Coast. The dates are approximate</p>\n- <table rows=\"4\" cols=\"8\">\n- <row>\n- <cell>Carib Prince</cell>\n- <cell>due from</cell>\n- <cell><placeName>Manchester</placeName></cell>\n- <cell>about <date when=\"1907-04-28\">April 28</date></cell>\n- <cell>Merchant Prince</cell>\n- <cell>due from</cell>\n- <cell><placeName>Manchester</placeName></cell>\n- <cell><date when=\"1907-05-07\">May 7</date></cell>\n- </row>\n- <row>\n- <cell>Imperical Prince</cell>\n- <cell>due from</cell>\n- <cell><placeName>London</placeName></cell>\n- <cell><date when=\"1907-04-30\">April 30</date></cell>\n- <cell>Trojan Prince</cell>\n- <cell>due from</cell>\n- <cell><placeName>Manchester</placeName></cell>\n- <cell><date when=\"1907-05-18\">May 18</date></cell>\n- </row>\n- <row>\n- <cell>Sailor Prince</cell>\n- <cell>due from</cell>\n- <cell><placeName>Antwerp</placeName> &\n- <placeName>London</placeName></cell>\n- <cell><date when=\"1907-05-06\">May 6</date></cell>\n- <cell>Highland Prince</cell>\n- <cell>due from</cell>\n- <cell><placeName>Antwerp</placeName> &\n- <placeName>London</placeName></cell>\n- <cell><date when=\"1907-05-21\">May 21</date></cell>\n- </row>\n- </table>\n- <p>The S.S. Egyptian Prince is now loading for <placeName>Manchester</placeName>.</p>\n- </div> <div type=\"advert\" xml:id=\"deg-ad-bam02\">\n- <head>Asia Minor Steamship Co., Ltd.</head>\n- <p>Frequent sailings From ALEXANDRIA to CYPRUS and and Coast of Syria. \n- Passengers booked to JAFFA, BEYROUT AND TRIPOLi at modern fares</p> \n- <p>For further particulars apply: Manager, 3 St. Mark's-Street, Alexandria.\n- <measure type=\"indexNo\">28478-31-12-06</measure></p>\n- </div> <div type=\"advert\" xml:id=\"deg-ad-ell03\">\n- <table rows=\"3\" cols=\"6\">\n- <row>\n- <cell cols=\"3\">Ellermans CITY LINE.</cell>\n- <cell cols=\"3\">\n- <p>Ellermans CITY & HALL LINE.</p>\n- </cell>\n- </row>\n- <row>\n- <cell cols=\"6\">The undermentioned First Class Passenger Steamers will be\n- dispatched from Port Said on or about the following dates for</cell>\n- </row>\n- <row>\n- <cell>Marseilles and London</cell>\n- <cell><name>S.S. City of Calcutta</name></cell>\n- <cell><date> May ...</date></cell> \n- <cell>Marseilles & Liverpool</cell>\n- <cell><name>S.S. City of London</name></cell>\n- <cell><date when=\"1907-04-25\">April 25</date></cell>\n- </row>\n- <row>\n- <cell>Colombo and Calcutta</cell>\n- <cell><name>S.S. City of Benares</name></cell>\n- <cell><date when=\"1907-05-08\">May 08</date></cell>\n- <cell>Bombay & Karachi</cell>\n- <cell><name>S.S. City of Glasgow</name></cell>\n- <cell><date when=\"1907-05-10\">May 10</date></cell>\n- </row>\n- </table>\n- <p>SALOON FARES:—Port Said to Malta £4.10.0. Marseilles. £10.0.0. London or\n- Liverpool, £l4.0.0. Colombo, Calcutta, Bombay or Karachi, £35.0.0. Special\n- rates for steamers not carrying Doctor or Stewardess. For further particulars\n- apply to</p>\n- <p>CORY BROS. & Co., Ltd., Agents for CITY Line, Port Said: W. STAPLEDON &\n- SON, Agents for Hall Line, Port Said ; or COOK & SON (Egypt), Ltd., Cairo.\n- <measure type=\"indexNo\">28-2-907</measure></p>\n- </div> <div type=\"advert\" xml:id=\"deg-ad-sgr03\">\n- <head>SUDAN GOVERNMENT RAILWAYS.</head>\n- <p>SUMMER SERVICE FROM APRIL 13th UNTIL FURTHER NOTICE.</p>\n- <table rows=\"8\" cols=\"9\">\n- <row>\n- <cell cols=\"5\">UP</cell>\n- <cell cols=\"4\">Down</cell>\n- </row>\n- <row>\n- <cell>Express</cell>\n- <cell>UP</cell>\n- <cell>Slow.</cell>\n- <cell/>\n- <cell/>\n- <cell/>\n- <cell/>\n- <cell>Express</cell>\n- <cell>DOWN</cell>\n- <cell>Slow</cell>\n- <cell/>\n- </row>\n- <row>\n- <cell>Sun. and Wedn.‡</cell>\n- <cell>Sat. and Tues.</cell>\n- <cell>8 p.m.</cell>\n- <cell>depart</cell>\n- <cell>Cairo</cell>\n- <cell>arrive</cell>\n- <cell>Sun. and Wedn.‡ </cell>\n- <cell>Tues. and Satur.</cell>\n- <cell>7.35 a.m.</cell>\n- </row>\n- <row>\n- <cell>Mon. and Thurs.</cell>\n- <cell>Sun. and Wedn.</cell>\n- <cell>5.40 p.m..</cell>\n- <cell>arr.</cell>\n- <cell>Shellal</cell>\n- <cell>depart</cell>\n- <cell>Sat. and Tues.‡</cell>\n- <cell>Mon. and Fridays</cell>\n- <cell>9.40 a.m.</cell>\n- </row>\n- <row>\n- <cell>Mon. and Thurs.</cell>\n- <cell>Sun. and Wed.</cell>\n- <cell>7 p.m.</cell>\n- <cell>depart</cell>\n- <cell>Shellal</cell>\n- <cell>arrive</cell>\n- <cell>Sat. and Tues. 8 a.m.</cell>\n- <cell>Mon and Fri.</cell>\n- <cell>mornings</cell>\n- </row>\n- <row>\n- <cell>Wednesdays and Saturdays</cell>\n- <cell>Wedn and Sat</cell>\n- <cell>11 a.m.</cell>\n- <cell>arr.</cell>\n- <cell>Halfa</cell>\n- <cell>depart</cell>\n- <cell>Thur. and Sun</cell>\n- <cell>about midnight</cell>\n- <cell>Sat. and Wed. </cell>\n- <cell>noon</cell>\n- </row>\n- <row>\n- <cell>Wednesdays and Saturdays‡</cell>\n- <cell/>\n- <cell>3 p.m.</cell>\n- <cell>depart</cell>\n- <cell>Halfa</cell>\n- <cell>arr. </cell>\n- <cell>Thursday‡ and Sundays</cell>\n- <cell/>\n- <cell>10.15 p.m.</cell>\n- </row>\n- <row>\n- <cell>Thursdays and Sundays‡</cell>\n- <cell/>\n- <cell>1.50 a.m.</cell>\n- <cell>depart</cell>\n- <cell>Abu Hamed</cell>\n- <cell>depart</cell>\n- <cell>Thursdays and Sundays</cell>\n- <cell/>\n- <cell>12.30 a.m.</cell>\n- </row>\n- <row>\n- <cell>Thursdays and Sundays‡</cell>\n- <cell/>\n- <cell>9 a.m.</cell>\n- <cell>depart</cell>\n- <cell>Atbara Jcn.</cell>\n- <cell>depart</cell>\n- <cell>Thursdays‡ and Sunday‡</cell>\n- <cell/>\n- <cell>6.15 p.m.</cell>\n- </row>\n- <row>\n- <cell>Thursdays and Sundays‡</cell>\n- <cell/>\n- <cell>5.30 p.m.</cell>\n- <cell>arr.</cell>\n- <cell>Khartoum N.</cell>\n- <cell>depart</cell>\n- <cell>Wednesdays and Saturdays‡</cell>\n- <cell/>\n- <cell>9.15 p.m.</cell>\n- </row>\n- </table>\n- <p>‡Sleeping and Dining Cars. </p>\n- <p>Note.—Passangers leaving Halfa by mail steamer in connection with Wednesday\n- night mail from Khartoum may remain on board in orer to travel by the Sunday \n- train from Shellal with Sleeping and Dinning Car connection at Luxor \n- <measure type=\"indexNo\">14-6-907</measure> </p>\n- </div><div type=\"advert\" xml:id=\"deg-ad-rea01\">\n- <head>ROYAL EXCHANGE ASSURANCE.</head>\n- <p>Incorporated A. D. 1720.</p>\n- <p>Chief Office: ROYAL EXCHANGE, LONDON, E.C.</p>\n- <p>FUNDS IN HAND EXCEED £4,500,000 CLAIMS PAID £40,000,000</p>\n- <table rows=\"2\" cols=\"2\">\n- <row role=\"label\">\n- <cell>FIRE</cell>\n- <cell>MARINE</cell>\n- </row>\n- <row>\n- <cell>ALEXANDRIA … ANGLO-EGYPTIAN BANK.</cell>\n- <cell>ALEXANDRIA … Mr. J. B. CAFFARI</cell>\n- </row>\n- <row>\n- <cell>CAIRO … Mr. J. B. CAFFARI</cell>\n- <cell>SUEZ … Mr. GEO. MEINECKE.</cell>\n- </row>\n- </table>\n- <p><measure type=\"indexNo\">21-6-906</measure></p>\n- </div> <div type=\"advert\" xml:id=\"deg-ad-lac01\">\n- <head>LONDON ASSURANCE CORPORATION.</head>\n- <p>072 Established 1720. - Agents: BANK OF EGYPT, Limited </p>\n- </div><div type=\"advert\" xml:id=\"deg-ad-nfl01\">\n- <head>NORTHERN FIRE AND LIFE ASSURANCE Coy.</head>\n- <p>The undersigned agents are authorised to issue policies on behalf of the above\n- Company at moderate rates.</p>\n- <p>IMPERIAL OTTOMAN BANK, Alexandria. OTTO STERZING, Cairo. GEORG. MEINECKE, Suez.</p>\n- </div> <div type=\"advert\" xml:id=\"deg-ad-nml02\">\n- <head>THE NATIONAL MUTUAL LIFE ASSOCIATION OF AUSTRALASIA, LTD. EST. 1869.</head>\n- <p>Funds exceed £4,000,000. Annual Income exceeds £700,000.</p>\n- <p>Special privileges offered to British Naval and Military Officers serving in\n- Egypt or the Soudan.</p>\n- <p>Example of whole Policy Life.</p>\n- <p>Age of proposer 30. Sum assured £1,000 with profits payable at death. Annual\n- premium covering war risk and foreign residence £28:6:8</p>\n- <p>Head Office: Cairo, Khedivial Exchange Court.</p>\n- </div><div type=\"advert\" xml:id=\"deg-ad-sio01\">\n- <head>Sun Insurance Office,</head>\n- <p>LONDON. Founded 1710.-Total sum insured in 1902 £487,600,000.</p>\n- <p>General Agents : BEHREND & Co., Alexandria.LEON HELLER, Cairo Agent. C. Lazzerini & Co., \n- Suez Agents </p>\n- </div><div type=\"advert\" xml:id=\"deg-ad-pss01\">\n- <head>PORT SAID-SAVOY HOTEL.</head>\n- <p>NEW FIRST-CLASS HOTEL, OVERLOOKING THE HARBOUR & OPPOSITE CUSTOM HOUSE</p>\n- <p>Open all the year round. — Well-appointed Bar. Electric Light.</p>\n- <p>MODERATE CHARGES. SPECIAL TERMS FOR RESIDENTS 1190A2-5</p>\n- </div>\n- <cb n=\"3\"/>\n- <div type=\"advert\" xml:id=\"deg-ad-aan05\">\n- <head>Hamburg & Anglo-American Nile Co.</head>\n- <p>Weekly departure during Winter Season by the Luxurious First Class\n- Tourist Steamers \"VICTORIA,\" \"PURITAN,\" and \"GERMANIA.\"</p>\n- <p>Bi-weekly Express Service between LUXOR and ASSUAN by S.S.\n- \"MAYFLOWER.\"</p>\n- <p><lb/>Regular weekly Departures to the SECOND CATARACT by the S.S.\n- \"NUBIA.\"</p>\n- <p><lb/>THROUGH BOOKINGS TO KHARTOUM, GONDOKORO AND THE WHITE NILE.</p>\n- <p><lb/>Steamers and Dahabeahs for private charter. Steam Tugs and Steam\n- Launches for hire.</p>\n- <p><lb/>FREIGHT SERVICE BY STEAM BARGES BETWEEN CAIRO AND ALEXANDRIA.</p>\n- <p><lb/>Working in conjunction and under special arrangement with the “Upper\n- Egypt Hotels Company.\"</p>\n- <p>For details and programmes apply to HEAD OFFICE: Sharia\n- Boulac, Continental Hotel Buildings,\" CAIRO</p>\n- <p>Hamburg-Amerika Linie.</p>\n- <p>Accelerated Service by: </p>\n- <p>S.S. OCEANA, of 8,000 Tons, 350 berths including 90 single cabins.</p>\n- <p>Greatest Comfort, Best Cuisine.</p>\n- <table>\n- <row>\n- <cell rows=\"6\">FARES: to NAPLES from £10, to GENOA from £13.</cell>\n- <cell>Leaves Alexandria:</cell>\n- <cell>Arr. Naples:</cell>\n- <cell>*Arr. Genoa:</cell>\n- </row>\n- <row>\n- <cell><date when=\"1907-12-08\">8</date> & <date when=\"1907-12-22\"\n- ></date>22 December.</cell>\n- <cell><date when=\"1907-12-11\">11</date> & <date\n- when=\"1907-12-25\"></date>25</cell>\n- <cell><date when=\"1907-12-12\">12</date> & <date\n- when=\"1907-12-26\">26 December.</date></cell>\n- </row>\n- <row>\n- <cell><date when=\"1907-01-12\">12</date>, <date when=\"1907-01-19\"\n- >19</date>, &<date when=\"1907-01-26\">26\n- January</date>.</cell>\n- <cell><date when=\"1907-01-15\">15 January</date>, <date when=\"1907-01-22\"\n- >22</date>, & <date when=\"1907-01-29\">29\n- January</date>.</cell>\n- <cell>….….….</cell>\n- </row>\n- <row>\n- <cell><date when=\"1907-02-02\">2</date>,<date when=\"1907-02-09\"\n- >9</date>, <date when=\"1907-02-16\">16</date>, <date\n- when=\"1907-02-23\">23 February</date>.</cell>\n- <cell><date when=\"1907-02-05\">5 February</date>, <date when=\"1907-02-12\"\n- >12</date>, <date when=\"1907-02-19\">19</date>,<date\n- when=\"1907-02-26\">26 February</date>.</cell>\n- <cell>….….….</cell>\n- </row>\n- <row>\n- <cell><date when=\"1907-03-02\">2</date>,<date when=\"1907-03-09\"\n- >9</date>, <date when=\"1907-03-16\">16</date>, <date\n- when=\"1907-03-23\">23</date>,<date when=\"1907-03-30\">30\n- March</date>.</cell>\n- <cell><date when=\"1907-03-05\">5</date>, <date when=\"1907-03-12\"\n- >12</date>, <date when=\"1907-03-19\">19</date>, <date\n- when=\"1907-03-26\">26 March</date>.</cell>\n- <cell>….….….</cell>\n- </row>\n- <row>\n- <cell><date when=\"1907-04-06\">6</date>, <date when=\"1907-04-13\">13\n- April</date>.</cell>\n- <cell><date when=\"1907-04-02\">2</date>, <date when=\"1907-04-09\"\n- >9</date>, <date when=\"1907-04-16\">16 April</date>.</cell>\n- <cell><date when=\"1907-04-17\">17 April</date>.</cell>\n- </row>\n- </table>\n- <p>Great Oriental Cruise by S.S. MOLTKE on <date when=\"1907-03-05\">March\n- 5th</date> from Alexandria.</p>\n- <p>Departures from Port Said:</p>\n- <p><hi rend=\"bold\">To East Asia</hi>: <date when=\"1907-01-03\">Jan 3</date>,\n- SCANDIA; <date when=\"1907-02-03\">Febr. 3</date>, HABSBURG; <date\n- when=\"1907-03-06\">March 6</date>, RHENANIA; <date when=\"1907-04-08\"\n- >April 8</date>, HOHENSTAUFEN; <date when=\"1907-05-04\">May 4</date>,\n- SILESIA.</p>\n- <p><hi rend=\"bold\">To Port Sudan</hi> and <hi rend=\"bold\">Persian Gulf</hi>:\n- <date when=\"1907-01-10\">Jan. 10</date>, ASSYRIA; <date\n- when=\"1907-02-10\">Febr. 10</date>, SAVOIA; <date when=\"1907-03-23\"\n- >March 23</date>, – <date when=\"1907-04-23\">April 23</date>,\n- CANADIA.</p>\n- <p><hi rend=\"bold\">To Naples, Plymouth</hi> and <hi rend=\"bold\">Hamburg</hi>\n- <date when=\"1907-01-12\">Jan. 12</date>, RHENANIA; <date\n- when=\"1907-02-09\">Febr. 9</date>, HOHENSTAUFEN; <date\n- when=\"1907-03-09\">March 9</date>, SILESIA; <date when=\"1907-04-20\"\n- >April 20</date>, SCANDIA; <date when=\"1907-05-04\">May 4</date>,\n- HABSBURG; <date when=\"1907-06-15\">June 15</date>, RHENANIA.</p>\n- <p><hi rend=\"bold\">To Marseilles</hi> and <hi rend=\"bold\">Hamburg</hi>:\n- <date when=\"1907-01-19\">Jan. 19</date>, HUNGARIA.</p>\n- <p><hi rend=\"italic\">Apply to: HAMBURG-AMERICA LINIE, Continental Hotel,\n- CAIRO. C.J. GRACE & CO., ALEXANDRIA. </hi></p>\n- <p><measure type=\"indexNo\">29074</measure>\n- <hi rend=\"italic\">DEUTSCHES KOHLEN DEPOT, PORT SAID & SUEZ.</hi>\n- <measure type=\"indexNo\">31-11-07</measure></p>\n- </div> <div type=\"advert\" xml:id=\"deg-ad-nll02\">\n- <head>NORDDEUTSCHER LLOYD.</head>\n- <p>ALEXANDRIA-NAPLES-MARSEILLES. Weekly Departure from Alexandria (3\n- p.m.)</p>\n- <p>SCHLESWIG: 10, 24 April; 15, 29 May; 12, 26 June</p>\n- <p>HOHENZOLLERN: 3, 17 April; 8, 22 May; 5, 19 June.</p>\n- <p>The following S.S. are intended to leave PORT-SAID:</p>\n- <table rows=\"12\" cols=\"3\">\n- <row>\n- <cell cols=\"3\">HOMEWARD : for Bremen of Hamburg via Naples, Genoa,\n- (Gibraltar), Southampton, Antwerp.</cell>\n- </row>\n- <row>\n- <cell><name>Prinzess Alice</name></cell>\n- <cell><measure quantity=\"11100\" unit=\"ton\">11100</measure>\n- Tons</cell>\n- <cell>about <date when=\"1907-04-04\">4 April</date></cell>\n- </row>\n- <row>\n- <cell><name>Bremen</name></cell>\n- <cell><measure quantity=\"11600\" unit=\"ton\">11,600</measure>\n- Tons</cell>\n- <cell>about <date when=\"1907-04-03\">3 April</date></cell>\n- </row>\n- <row>\n- <cell><name>Prinz Ludwig</name></cell>\n- <cell><measure quantity=\"9600\" unit=\"ton\">9600</measure> Tons</cell>\n- <cell>about <date when=\"1907-04-19\">19 April</date></cell>\n- </row>\n- <row>\n- <cell><name>Bulow</name></cell>\n- <cell><measure quantity=\"9000\" unit=\"ton\">9000</measure> Tons</cell>\n- <cell>about <date when=\"1907-04-23\">23 April</date></cell></row>\n- <row>\n- <cell><name>Zieten</name></cell>\n- <cell><measure quantity=\"8000\" unit=\"ton\">8000</measure> Tons</cell>\n- <cell>about <date when=\"1907-05-03\">3 May</date></cell>\n- </row>\n- <row>\n- <cell cols=\"3\">OUTWARD: for CHINA and JAPAN via SUEZ, ADEN, COLOMBO,\n- PENANG, SINGAPORE.</cell>\n- </row>\n- <row>\n- <cell><name>Bayern</name></cell>\n- <cell><measure unit=\"ton\" quantity=\"5000\">5000</measure> Tons</cell>\n- <cell>about <date when=\"1907-04-01\">1 April</date></cell>\n- </row>\n- <row>\n- <cell><name>Gneissenau</name></cell>\n- <cell><measure unit=\"ton\" quantity=\"6300\">6300</measure> Tons</cell>\n- <cell>about <date when=\"1907-04-15\">15 April</date></cell>\n- </row>\n- <row>\n- <cell cols=\"3\">For AUSTRALIA via SUEZ, ADEN, COLOMBO.</cell>\n- </row>\n- <row>\n- <cell><name>Prinz Heinrch</name></cell>\n- <cell><measure unit=\"ton\" quantity=\"6500\">6500</measure> Tons</cell>\n- <cell>about <date when=\"1907-04-05\">5 April</date></cell>\n- </row>\n- <row>\n- <cell><name>Kleist</name></cell>\n- <cell><measure unit=\"ton\" quantity=\"9600\">9600</measure> Tons</cell>\n- <cell>about <date when=\"1907-05-03\">3 May</date></cell>\n- </row>\n- </table>\n- <p>ROYAL ROUMANIAN EXPRESS STEAMER SERVICE</p>\n- <p>Alexandria to Smyrna, Mitylene, Constantinople & Cosntanza. – Weekly\n- departure from Alexandria every Friday at 4 p.m. with the new twin screw\n- S.S. REGELE CAROL I., ROUMANIA and IMPERATUL TRAJAN</p>\n- <p>For particulars apply to the Agents: OTTO STERZING, Opera Square, Cairo.\n- Wm. H. Muller & Col, Sesostris-st., Alexandria. Messrs. THOS. COOK\n- & SON (Egypt) LTD., are authorised to sell tickets in CAIRO and\n- ALEXANDRIA, <measure type=\"indexNo\">31-10-06</measure></p>\n- </div><div type=\"advert\" xml:id=\"deg-ad-als03\">\n- <head>Austrian Lloyd’s Steam Navigation</head>\n- <p><hi rend=\"bold\">Alexandria-Brindisi-Venice Trieste.</hi> Express Mail\n- Service. Steamers leave Alexandria Saturdays 4 p.m. arrive at Brindisi\n- Tuesdays 5 a.m. in time for Express to Milan, Lucerne, Paris, Vienna,\n- Berlin, London, leaving Brindisi 7 a.m. Arrival at Venice Wednesday\n- about 8.30 a.m. Passengers may proceed from Venice to Switzerland, Paris\n- and London by the 2 p.m. and 11.5 p.m. – Expresses. Arrival at Trieste\n- Wednesday about 3 p.m. in connection with the Train de Luxe proceeding\n- the same evening to Vienna, Frankfort, Cologne, Brussel, Ostende and\n- London. Arrival at London every Friday 5.12 p.m.</p>\n- <p>Special Train Service from Cairo Station to Alexandria Quay alongside\n- steamer, Saturdays at 9.30 a.m.</p>\n- <p><hi rend=\"bold\">Intermediate Service: Alexandria-Brindisi & Trieste\n- Line.</hi></p>\n- <p>Steamer leaves Alexandria every Thursday 10 a.m. On and from <date\n- when=\"1907-04-11\">April 11th</date> at 4 p.m.</p>\n- <p><hi rend=\"bold\">Syrian-Caramanian Line.</hi> Port Said, Jaffa, Beyrout,\n- Tripoli, Alexandretta, Mersina, <date when=\"1907-02-18\">Febr. 18</date>;\n- <date when=\"1907-03-04\">March 4</date>, <date when=\"1907-03-18\"\n- >18</date> ; <date when=\"1907-04-01\">April 1</date>. <date\n- when=\"1907-04-15\">15</date>, <date when=\"1907-04-29\">29</date> ;\n- <date when=\"1907-05-13\">May 13</date>, <date when=\"1907-05-27\"\n- >27</date> ; <date when=\"1907-06-10\">June 10</date>, <date\n- when=\"1907-06-24\">24</date>.</p>\n- <p><hi rend=\"bold\">Syrian-Cyprus Line.</hi> Beyrout, Limassol, Larnaca,\n- Mersina, <date when=\"1907-02-26\">Febr. 26</date>; <date\n- when=\"1907-03-12\">March 12</date>, <date when=\"1907-03-26\">26</date>\n- ; <date when=\"1907-04-09\">April 9</date>. <date when=\"1907-04-23\"\n- >23</date> ; <date when=\"1907-05-07\">May 7</date>, <date\n- when=\"1907-05-21\">21</date> ; <date when=\"1907-06-04\">June 4</date>,\n- <date when=\"1907-06-18\">18</date>.</p>\n- <p><hi rend=\"bold\">Far East Lines.</hi> Departures from Port Said: To Suez,\n- Aden, Bombay, Colombo, Penang, Singapore, Hong-Kong, Shanghai, <hi\n- rend=\"italic\">Yokohama</hi> and <hi rend=\"italic\">Kobé</hi>, <date\n- when=\"1907-03-06\">6 March</date>, <date when=\"1907-04-03\">3\n- April</date>, <date when=\"1907-05-04\">4 May</date>, <date\n- when=\"1907-06-03\">3 June</date>.</p>\n- <p>To Suez, Aden and <hi rend=\"italic\">Bombay</hi> accelerated service <date\n- when=\"1907-02-22\">22 Febr.</date>; <date when=\"1907-03-07\">7</date>,\n- <date when=\"1907-03-23\">23 March</date> ; <date when=\"1907-04-04\"\n- >4</date>, <date when=\"1907-04-23\">23 April</date> ; <date\n- when=\"1907-05-08\">8 May</date> ; <date when=\"1907-06-08\">8\n- June</date>.</p>\n- <p>To Suez, Aden, Karachi, Colombo, Madras, Rangoon, and <hi rend=\"italic\"\n- >Calcutta</hi> about <date when=\"1907-01-18\">18 Jan.</date>, <date\n- when=\"1907-02-18\">18 Feb.</date>, <date when=\"1907-03-18\">18\n- March</date>, <date when=\"1907-04-18\">18 April</date>, <date\n- when=\"1907-05-18\">18 May</date>, <date when=\"1907-06-18\">18\n- June</date>. – For information apply to the Agents, Alexandria, Port\n- Said, Suez, and Khartum.</p>\n- <p>Special rates for Egyptian officials, members of Army of Occupation and\n- their families.</p>\n- <p><measure type=\"indexNo\">31-12-90</measure></p>\n- </div> <div type=\"advert\" xml:id=\"deg-ad-pap01\">\n- <head>THE PAPAYANNI LINE.</head>\n- <head type=\"sub\">(The Ellerman Lines, Ltd.)</head>\n- <p>Frequent Sailings from ALEXANDRIA to LIVERPOOL. Regular Services from\n- LIVERPOOL to ALEXANDRIA, ALGERIA, MALTA, LEVANT, BLACK SEA, and other\n- Mediterranean Ports. Excellent Passenger Accommodation. Stewardess\n- carried. Liberal table and Moderate Fares for single and return\n- tickets.</p>\n- <p>CARGO taken by special agreement only. Through Freights quoted for the\n- UNITED STATES INLAND TOWNS and GREAT BRITAIN.</p>\n- <p>For passage or freight apply BARKER & Co., Agents. Alexandria. </p>\n- <p>The <name>S S. CITY OF CAMBRIDGE</name> now loading will leave for\n- <placeName>Liverpool</placeName> in a few days and the <name>S S.\n- BRITANNIA</name> for <placeName>Manchester</placeName>will leave in a few days. <measure\n- type=\"indexNo\">17-4-906</measure></p>\n- </div><div type=\"advert\" xml:id=\"deg-ad-ell02\">\n- <head>The Ellerman Lines, Limited.</head>\n- <head type=\"sub\">(Including Westcott & Laurance Line.)</head>\n- <p>Regular sailings from Liverpool, Glasgow, Antwerp and London to\n- Alexandria. Frequent sailings from Alexandria to Liverpool and London.\n- Through freight rates to Inland towns in Great Britain also to the\n- U.S.A. N. E. TAMVACO, Alexandria, Agent.</p>\n- <table rows=\"4\" cols=\"5\">\n- <row>\n- <cell>Ellerman <name>S.S. \"Flavian\"</name></cell>\n- <cell>expected from</cell>\n- <cell><placeName>Liverpool</placeName>, <placeName>Malta</placeName>\n- and <placeName>Mizrata</placeName></cell>\n- <cell>about</cell>\n- <cell><date when=\"1907-04-24\"> 24</date></cell>\n- </row>\n- <row>\n- <cell>Westcott <name>S.S. \"City of Perth\"</name></cell>\n- <cell>expected from</cell>\n- <cell><placeName>Antwerp</placeName>,\n- <placeName>London</placeName><placeName>Malta</placeName> and\n- <placeName>Tripoli</placeName></cell>\n- <cell>about</cell>\n- <cell><date when=\"1907-04-23\">23rd</date></cell>\n- </row>\n- <row>\n- <cell>Westcott <name>S.S. \"City of DUndee\"</name></cell>\n- <cell>expected from</cell>\n- <cell><placeName>Antwerp</placeName>, <placeName>London</placeName>\n- and <placeName>Malta</placeName></cell>\n- <cell>about</cell>\n- <cell><date when=\"1907-04-29\">29</date></cell>\n- </row>\n- <row>\n- <cell>Westcott <name>S.S. \"Bulgarian\"</name></cell>\n- <cell>expected from</cell>\n- <cell><placeName>Liverpool</placeName>, and <placeName>Malta</placeName>\n- <placeName>....</placeName></cell>\n- <cell/>\n- <cell/>\n- </row>\n- </table>\n- <p>The <name>S.S. Andalusian</name>, now on the loading for\n- <placeName>Liverpool</placeName>, will sail on or about 21st inst. to be \n- followed by the <name>S.S. \"Algerian\"</name>.</p>\n- </div><div type=\"advert\" xml:id=\"deg-ad-rsn02\">\n- <head>Russian Stream Navigation Co.</head>\n- <p>Express Service by the following fine, new steamers between Alexandria, Piraeus,\n- Constantinople, and Odessa --</p>\n- <p><hi rend=\"bold\">Emperor Nicolas II</hi>, <hi rend=\"bold\">Reine Olga</hi>, <hi\n- rend=\"bold\">Tchihatchoff</hi> (7070 tons each) and <hi rend=\"bold\"\n- >Tsaritza</hi> (6000 tons)</p>\n- <p>Arrive Alexandria Friday noon, leave Alexandria Tuesday, 3 p.m. Circular route\n- between Alexandria, Port Said, the Syrian ports, Chio, Smyrna, Salonica, Mount\n- Athos, Dardanelles, Constantinople, and Odessa. Arrive Alexandria alternate\n- Saturdays early morn; leaving Alexandria same day at 4 p.m.</p>\n- <p><hi rend=\"bold\">Crimean or Bessarabian table wines free</hi>.</p>\n- <p><measure type=\"indexNo\">26376-31-6-907</measure></p>\n- </div><div type=\"advert\" xml:id=\"deg-ad-ngi01\" xml:lang=\"fr\">\n- <head>Navigation Générale Italienne.</head>\n- <p>Societes Reunies Florio-Rubattino. - Services Postaux. - Departs d'Avril.</p>\n- <table rows=\"5\" cols=\"4\">\n- <row>\n- <cell>Les Jeudis</cell>\n- <cell>4, 11, 18, et 25</cell>\n- <cell>à 3 h. p.m.</cell>\n- <cell>direct pour Messine, Naples, Livourne et Gênes.</cell>\n- </row>\n- <row>\n- <cell>Les Lundis</cell>\n- <cell>1 et 15</cell>\n- <cell>à 3 h. p.m.</cell>\n- <cell>direct pour Brindisi, Bari, Ancône et Venise.</cell>\n- </row>\n- <row>\n- <cell>Les Mercredis</cell>\n- <cell>3 et 17</cell>\n- <cell>à 10 h. a.m.</cell>\n- <cell>pour les escales de la Syrie et Larnaque.</cell>\n- </row>\n- <row>\n- <cell>Les Lundis</cell>\n- <cell>1 et 29</cell>\n- <cell>à 4 h. p.m.</cell>\n- <cell>pour Port-Saïd, Suez et Massawah.</cell>\n- </row>\n- <row>\n- <cell>Les Dimanche</cell>\n- <cell>5 et Lundi 22</cell>\n- <cell>à 5 h. p.m.</cell>\n- <cell>pour Port-Saïd.</cell>\n- </row>\n- </table>\n- <p><measure type=\"indexNo\">31-12-906</measure></p>\n- </div><div type=\"advert\" xml:id=\"deg-ad-wsl02\">\n- <head>WHITE STAR LINE.</head>\n- <p>NEW YORK AND BOSTON MEDITERRANEAN SERVICE.</p>\n- <p>REGULAR SAILINGS BETWEEN SOUTHAMPTON-CHEROUG and NEW YORK via Queenstown (Westbound)\n- via Plymouth (Eastbound) LIVERPOOL and NEW YORK, via Queenstown, LIVERPOOL and BOSTON viq Queentown,\n- GENOA, PALERMO,NAPLES, NEW YORK and","path":"1907-04-22.xml","position":null,"original_position":4971,"commit_id":"d2cedfa61c7c32dfdba41807c7d0e5f8c5f2b7e8","original_commit_id":"d2cedfa61c7c32dfdba41807c7d0e5f8c5f2b7e8","user":{"login":"whanley","id":7728326,"avatar_url":"https://avatars0.githubusercontent.com/u/7728326?v=4","gravatar_id":"","url":"https://api.github.com/users/whanley","html_url":"https://github.com/whanley","followers_url":"https://api.github.com/users/whanley/followers","following_url":"https://api.github.com/users/whanley/following{/other_user}","gists_url":"https://api.github.com/users/whanley/gists{/gist_id}","starred_url":"https://api.github.com/users/whanley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whanley/subscriptions","organizations_url":"https://api.github.com/users/whanley/orgs","repos_url":"https://api.github.com/users/whanley/repos","events_url":"https://api.github.com/users/whanley/events{/privacy}","received_events_url":"https://api.github.com/users/whanley/received_events","type":"User","site_admin":false},"body":"add another `</div>` to close the marche de minet el bassal section.","created_at":"2018-02-14T04:06:08Z","updated_at":"2018-02-14T04:13:02Z","html_url":"https://github.com/dig-eg-gaz/content/pull/615#discussion_r168072845","pull_request_url":"https://api.github.com/repos/dig-eg-gaz/content/pulls/615","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/dig-eg-gaz/content/pulls/comments/168072845"},"html":{"href":"https://github.com/dig-eg-gaz/content/pull/615#discussion_r168072845"},"pull_request":{"href":"https://api.github.com/repos/dig-eg-gaz/content/pulls/615"}}},"pull_request":{"url":"https://api.github.com/repos/dig-eg-gaz/content/pulls/615","id":167052460,"html_url":"https://github.com/dig-eg-gaz/content/pull/615","diff_url":"https://github.com/dig-eg-gaz/content/pull/615.diff","patch_url":"https://github.com/dig-eg-gaz/content/pull/615.patch","issue_url":"https://api.github.com/repos/dig-eg-gaz/content/issues/615","number":615,"state":"open","locked":false,"title":"Deliverable 2","user":{"login":"claudia5","id":35342632,"avatar_url":"https://avatars0.githubusercontent.com/u/35342632?v=4","gravatar_id":"","url":"https://api.github.com/users/claudia5","html_url":"https://github.com/claudia5","followers_url":"https://api.github.com/users/claudia5/followers","following_url":"https://api.github.com/users/claudia5/following{/other_user}","gists_url":"https://api.github.com/users/claudia5/gists{/gist_id}","starred_url":"https://api.github.com/users/claudia5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/claudia5/subscriptions","organizations_url":"https://api.github.com/users/claudia5/orgs","repos_url":"https://api.github.com/users/claudia5/repos","events_url":"https://api.github.com/users/claudia5/events{/privacy}","received_events_url":"https://api.github.com/users/claudia5/received_events","type":"User","site_admin":false},"body":"Page 2 and 3 of the Monday issue","created_at":"2018-02-05T03:49:57Z","updated_at":"2018-02-14T04:13:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3b119062f03474b41379a7caa28c28deae3f37c3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dig-eg-gaz/content/pulls/615/commits","review_comments_url":"https://api.github.com/repos/dig-eg-gaz/content/pulls/615/comments","review_comment_url":"https://api.github.com/repos/dig-eg-gaz/content/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dig-eg-gaz/content/issues/615/comments","statuses_url":"https://api.github.com/repos/dig-eg-gaz/content/statuses/d2cedfa61c7c32dfdba41807c7d0e5f8c5f2b7e8","head":{"label":"claudia5:master","ref":"master","sha":"d2cedfa61c7c32dfdba41807c7d0e5f8c5f2b7e8","user":{"login":"claudia5","id":35342632,"avatar_url":"https://avatars0.githubusercontent.com/u/35342632?v=4","gravatar_id":"","url":"https://api.github.com/users/claudia5","html_url":"https://github.com/claudia5","followers_url":"https://api.github.com/users/claudia5/followers","following_url":"https://api.github.com/users/claudia5/following{/other_user}","gists_url":"https://api.github.com/users/claudia5/gists{/gist_id}","starred_url":"https://api.github.com/users/claudia5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/claudia5/subscriptions","organizations_url":"https://api.github.com/users/claudia5/orgs","repos_url":"https://api.github.com/users/claudia5/repos","events_url":"https://api.github.com/users/claudia5/events{/privacy}","received_events_url":"https://api.github.com/users/claudia5/received_events","type":"User","site_admin":false},"repo":{"id":118778543,"name":"content","full_name":"claudia5/content","owner":{"login":"claudia5","id":35342632,"avatar_url":"https://avatars0.githubusercontent.com/u/35342632?v=4","gravatar_id":"","url":"https://api.github.com/users/claudia5","html_url":"https://github.com/claudia5","followers_url":"https://api.github.com/users/claudia5/followers","following_url":"https://api.github.com/users/claudia5/following{/other_user}","gists_url":"https://api.github.com/users/claudia5/gists{/gist_id}","starred_url":"https://api.github.com/users/claudia5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/claudia5/subscriptions","organizations_url":"https://api.github.com/users/claudia5/orgs","repos_url":"https://api.github.com/users/claudia5/repos","events_url":"https://api.github.com/users/claudia5/events{/privacy}","received_events_url":"https://api.github.com/users/claudia5/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/claudia5/content","description":"TEI-encoded contents of the Egyptian Gazette","fork":true,"url":"https://api.github.com/repos/claudia5/content","forks_url":"https://api.github.com/repos/claudia5/content/forks","keys_url":"https://api.github.com/repos/claudia5/content/keys{/key_id}","collaborators_url":"https://api.github.com/repos/claudia5/content/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/claudia5/content/teams","hooks_url":"https://api.github.com/repos/claudia5/content/hooks","issue_events_url":"https://api.github.com/repos/claudia5/content/issues/events{/number}","events_url":"https://api.github.com/repos/claudia5/content/events","assignees_url":"https://api.github.com/repos/claudia5/content/assignees{/user}","branches_url":"https://api.github.com/repos/claudia5/content/branches{/branch}","tags_url":"https://api.github.com/repos/claudia5/content/tags","blobs_url":"https://api.github.com/repos/claudia5/content/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/claudia5/content/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/claudia5/content/git/refs{/sha}","trees_url":"https://api.github.com/repos/claudia5/content/git/trees{/sha}","statuses_url":"https://api.github.com/repos/claudia5/content/statuses/{sha}","languages_url":"https://api.github.com/repos/claudia5/content/languages","stargazers_url":"https://api.github.com/repos/claudia5/content/stargazers","contributors_url":"https://api.github.com/repos/claudia5/content/contributors","subscribers_url":"https://api.github.com/repos/claudia5/content/subscribers","subscription_url":"https://api.github.com/repos/claudia5/content/subscription","commits_url":"https://api.github.com/repos/claudia5/content/commits{/sha}","git_commits_url":"https://api.github.com/repos/claudia5/content/git/commits{/sha}","comments_url":"https://api.github.com/repos/claudia5/content/comments{/number}","issue_comment_url":"https://api.github.com/repos/claudia5/content/issues/comments{/number}","contents_url":"https://api.github.com/repos/claudia5/content/contents/{+path}","compare_url":"https://api.github.com/repos/claudia5/content/compare/{base}...{head}","merges_url":"https://api.github.com/repos/claudia5/content/merges","archive_url":"https://api.github.com/repos/claudia5/content/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/claudia5/content/downloads","issues_url":"https://api.github.com/repos/claudia5/content/issues{/number}","pulls_url":"https://api.github.com/repos/claudia5/content/pulls{/number}","milestones_url":"https://api.github.com/repos/claudia5/content/milestones{/number}","notifications_url":"https://api.github.com/repos/claudia5/content/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/claudia5/content/labels{/name}","releases_url":"https://api.github.com/repos/claudia5/content/releases{/id}","deployments_url":"https://api.github.com/repos/claudia5/content/deployments","created_at":"2018-01-24T14:47:40Z","updated_at":"2018-01-24T14:47:46Z","pushed_at":"2018-02-12T15:47:45Z","git_url":"git://github.com/claudia5/content.git","ssh_url":"[email protected]:claudia5/content.git","clone_url":"https://github.com/claudia5/content.git","svn_url":"https://github.com/claudia5/content","homepage":null,"size":662650,"stargazers_count":0,"watchers_count":0,"language":"XSLT","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dig-eg-gaz:master","ref":"master","sha":"bae982f10cfda14eb879d226c50ce09b44ec029f","user":{"login":"dig-eg-gaz","id":20173960,"avatar_url":"https://avatars1.githubusercontent.com/u/20173960?v=4","gravatar_id":"","url":"https://api.github.com/users/dig-eg-gaz","html_url":"https://github.com/dig-eg-gaz","followers_url":"https://api.github.com/users/dig-eg-gaz/followers","following_url":"https://api.github.com/users/dig-eg-gaz/following{/other_user}","gists_url":"https://api.github.com/users/dig-eg-gaz/gists{/gist_id}","starred_url":"https://api.github.com/users/dig-eg-gaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dig-eg-gaz/subscriptions","organizations_url":"https://api.github.com/users/dig-eg-gaz/orgs","repos_url":"https://api.github.com/users/dig-eg-gaz/repos","events_url":"https://api.github.com/users/dig-eg-gaz/events{/privacy}","received_events_url":"https://api.github.com/users/dig-eg-gaz/received_events","type":"Organization","site_admin":false},"repo":{"id":62155362,"name":"content","full_name":"dig-eg-gaz/content","owner":{"login":"dig-eg-gaz","id":20173960,"avatar_url":"https://avatars1.githubusercontent.com/u/20173960?v=4","gravatar_id":"","url":"https://api.github.com/users/dig-eg-gaz","html_url":"https://github.com/dig-eg-gaz","followers_url":"https://api.github.com/users/dig-eg-gaz/followers","following_url":"https://api.github.com/users/dig-eg-gaz/following{/other_user}","gists_url":"https://api.github.com/users/dig-eg-gaz/gists{/gist_id}","starred_url":"https://api.github.com/users/dig-eg-gaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dig-eg-gaz/subscriptions","organizations_url":"https://api.github.com/users/dig-eg-gaz/orgs","repos_url":"https://api.github.com/users/dig-eg-gaz/repos","events_url":"https://api.github.com/users/dig-eg-gaz/events{/privacy}","received_events_url":"https://api.github.com/users/dig-eg-gaz/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dig-eg-gaz/content","description":"TEI-encoded contents of the Egyptian Gazette","fork":false,"url":"https://api.github.com/repos/dig-eg-gaz/content","forks_url":"https://api.github.com/repos/dig-eg-gaz/content/forks","keys_url":"https://api.github.com/repos/dig-eg-gaz/content/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dig-eg-gaz/content/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dig-eg-gaz/content/teams","hooks_url":"https://api.github.com/repos/dig-eg-gaz/content/hooks","issue_events_url":"https://api.github.com/repos/dig-eg-gaz/content/issues/events{/number}","events_url":"https://api.github.com/repos/dig-eg-gaz/content/events","assignees_url":"https://api.github.com/repos/dig-eg-gaz/content/assignees{/user}","branches_url":"https://api.github.com/repos/dig-eg-gaz/content/branches{/branch}","tags_url":"https://api.github.com/repos/dig-eg-gaz/content/tags","blobs_url":"https://api.github.com/repos/dig-eg-gaz/content/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dig-eg-gaz/content/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dig-eg-gaz/content/git/refs{/sha}","trees_url":"https://api.github.com/repos/dig-eg-gaz/content/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dig-eg-gaz/content/statuses/{sha}","languages_url":"https://api.github.com/repos/dig-eg-gaz/content/languages","stargazers_url":"https://api.github.com/repos/dig-eg-gaz/content/stargazers","contributors_url":"https://api.github.com/repos/dig-eg-gaz/content/contributors","subscribers_url":"https://api.github.com/repos/dig-eg-gaz/content/subscribers","subscription_url":"https://api.github.com/repos/dig-eg-gaz/content/subscription","commits_url":"https://api.github.com/repos/dig-eg-gaz/content/commits{/sha}","git_commits_url":"https://api.github.com/repos/dig-eg-gaz/content/git/commits{/sha}","comments_url":"https://api.github.com/repos/dig-eg-gaz/content/comments{/number}","issue_comment_url":"https://api.github.com/repos/dig-eg-gaz/content/issues/comments{/number}","contents_url":"https://api.github.com/repos/dig-eg-gaz/content/contents/{+path}","compare_url":"https://api.github.com/repos/dig-eg-gaz/content/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dig-eg-gaz/content/merges","archive_url":"https://api.github.com/repos/dig-eg-gaz/content/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dig-eg-gaz/content/downloads","issues_url":"https://api.github.com/repos/dig-eg-gaz/content/issues{/number}","pulls_url":"https://api.github.com/repos/dig-eg-gaz/content/pulls{/number}","milestones_url":"https://api.github.com/repos/dig-eg-gaz/content/milestones{/number}","notifications_url":"https://api.github.com/repos/dig-eg-gaz/content/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dig-eg-gaz/content/labels{/name}","releases_url":"https://api.github.com/repos/dig-eg-gaz/content/releases{/id}","deployments_url":"https://api.github.com/repos/dig-eg-gaz/content/deployments","created_at":"2016-06-28T16:03:54Z","updated_at":"2017-05-08T20:35:42Z","pushed_at":"2018-02-14T03:43:23Z","git_url":"git://github.com/dig-eg-gaz/content.git","ssh_url":"[email protected]:dig-eg-gaz/content.git","clone_url":"https://github.com/dig-eg-gaz/content.git","svn_url":"https://github.com/dig-eg-gaz/content","homepage":null,"size":663524,"stargazers_count":3,"watchers_count":3,"language":"XSLT","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":137,"mirror_url":null,"archived":false,"open_issues_count":38,"license":null,"forks":137,"open_issues":38,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dig-eg-gaz/content/pulls/615"},"html":{"href":"https://github.com/dig-eg-gaz/content/pull/615"},"issue":{"href":"https://api.github.com/repos/dig-eg-gaz/content/issues/615"},"comments":{"href":"https://api.github.com/repos/dig-eg-gaz/content/issues/615/comments"},"review_comments":{"href":"https://api.github.com/repos/dig-eg-gaz/content/pulls/615/comments"},"review_comment":{"href":"https://api.github.com/repos/dig-eg-gaz/content/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dig-eg-gaz/content/pulls/615/commits"},"statuses":{"href":"https://api.github.com/repos/dig-eg-gaz/content/statuses/d2cedfa61c7c32dfdba41807c7d0e5f8c5f2b7e8"}},"author_association":"CONTRIBUTOR"}} | {
"id": 62155362,
"name": "dig-eg-gaz/content",
"url": "https://api.github.com/repos/dig-eg-gaz/content"
} | {
"id": 7728326,
"login": "whanley",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7728326?",
"url": "https://api.github.com/users/whanley"
} | {
"id": 20173960,
"login": "dig-eg-gaz",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/20173960?",
"url": "https://api.github.com/orgs/dig-eg-gaz"
} | 2018-02-14T04:06:08 | 7241901532 | {"actor":{"display_login":"whanley"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/codelabsab/timereport/pulls/comments/244529602","pull_request_review_id":188434321,"id":244529602,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NDUyOTYwMg==","diff_hunk":"@@ -19,25 +19,14 @@ def slack_responder(url, msg):\n \n def slack_payload_extractor(req):\n \"\"\"\n- Returns a dict containing the pure slack payload. Removes apigw metadata.\n- d =\n- \"token\": \"secret\",\n- \"team_id\": \"team_id\",\n- \"team_domain\": \"team_domain\",\n- \"channel_id\": \"channel_id\",\n- \"channel_name\": \"channel_name\",\n- \"user_id\": \"user101\",\n- \"user_name\": \"test_user\",\n- \"command\": \"%2Fno-wsgi\",\n- \"text\": \"add+vab+2018-10-01:2018-10-10\",\n- \"response_url\": \"https%3A%2F%2Fhooks.slack.com%2Fcommands%2FT2FG58LDV%2F4913463461%2FbVUlrKZrnElSOBUqn01FoxNf\",\n- \"trigger_id\": \"490225208629.83549292471.860541eab9e9c3c6d2234ea2e222c7a5\"\n+ Extract the body data of the slack request.\n+\n+ :param req:\n+ :return: dict\n \"\"\"\n- d = {}\n- for param in req['body'].split(\"&\"):\n- key, value = param.split(\"=\")\n- d[key] = value\n- return d\n+\n+ # parse_qs makes a list of all values, and that's why the v.pop() is necessary\n+ return {k: v.pop() for (k,v) in parse_qs(req['body']).items()}","path":"timereport/lib/slack.py","position":48,"original_position":48,"commit_id":"2548deff0e22149a089d9ca418323ec5e180fd1e","original_commit_id":"2548deff0e22149a089d9ca418323ec5e180fd1e","user":{"login":"kamigerami","id":9321510,"node_id":"MDQ6VXNlcjkzMjE1MTA=","avatar_url":"https://avatars3.githubusercontent.com/u/9321510?v=4","gravatar_id":"","url":"https://api.github.com/users/kamigerami","html_url":"https://github.com/kamigerami","followers_url":"https://api.github.com/users/kamigerami/followers","following_url":"https://api.github.com/users/kamigerami/following{/other_user}","gists_url":"https://api.github.com/users/kamigerami/gists{/gist_id}","starred_url":"https://api.github.com/users/kamigerami/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kamigerami/subscriptions","organizations_url":"https://api.github.com/users/kamigerami/orgs","repos_url":"https://api.github.com/users/kamigerami/repos","events_url":"https://api.github.com/users/kamigerami/events{/privacy}","received_events_url":"https://api.github.com/users/kamigerami/received_events","type":"User","site_admin":false},"body":"very nice!","created_at":"2018-12-30T10:10:13Z","updated_at":"2018-12-30T10:10:13Z","html_url":"https://github.com/codelabsab/timereport/pull/25#discussion_r244529602","pull_request_url":"https://api.github.com/repos/codelabsab/timereport/pulls/25","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/codelabsab/timereport/pulls/comments/244529602"},"html":{"href":"https://github.com/codelabsab/timereport/pull/25#discussion_r244529602"},"pull_request":{"href":"https://api.github.com/repos/codelabsab/timereport/pulls/25"}}},"pull_request":{"url":"https://api.github.com/repos/codelabsab/timereport/pulls/25","id":241483598,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQxNDgzNTk4","html_url":"https://github.com/codelabsab/timereport/pull/25","diff_url":"https://github.com/codelabsab/timereport/pull/25.diff","patch_url":"https://github.com/codelabsab/timereport/pull/25.patch","issue_url":"https://api.github.com/repos/codelabsab/timereport/issues/25","number":25,"state":"open","locked":false,"title":"Use parse qs","user":{"login":"parberge","id":5441497,"node_id":"MDQ6VXNlcjU0NDE0OTc=","avatar_url":"https://avatars2.githubusercontent.com/u/5441497?v=4","gravatar_id":"","url":"https://api.github.com/users/parberge","html_url":"https://github.com/parberge","followers_url":"https://api.github.com/users/parberge/followers","following_url":"https://api.github.com/users/parberge/following{/other_user}","gists_url":"https://api.github.com/users/parberge/gists{/gist_id}","starred_url":"https://api.github.com/users/parberge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/parberge/subscriptions","organizations_url":"https://api.github.com/users/parberge/orgs","repos_url":"https://api.github.com/users/parberge/repos","events_url":"https://api.github.com/users/parberge/events{/privacy}","received_events_url":"https://api.github.com/users/parberge/received_events","type":"User","site_admin":false},"body":"To simplify a bit, we will use parse qs for extracting the relevant data\r\nfrom slack request.","created_at":"2018-12-30T09:45:53Z","updated_at":"2018-12-30T10:10:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"96f1d49648a52ad0ef656f483f3b1ce932350ae3","assignee":null,"assignees":[],"requested_reviewers":[{"login":"tommymalmqvist","id":2495141,"node_id":"MDQ6VXNlcjI0OTUxNDE=","avatar_url":"https://avatars1.githubusercontent.com/u/2495141?v=4","gravatar_id":"","url":"https://api.github.com/users/tommymalmqvist","html_url":"https://github.com/tommymalmqvist","followers_url":"https://api.github.com/users/tommymalmqvist/followers","following_url":"https://api.github.com/users/tommymalmqvist/following{/other_user}","gists_url":"https://api.github.com/users/tommymalmqvist/gists{/gist_id}","starred_url":"https://api.github.com/users/tommymalmqvist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tommymalmqvist/subscriptions","organizations_url":"https://api.github.com/users/tommymalmqvist/orgs","repos_url":"https://api.github.com/users/tommymalmqvist/repos","events_url":"https://api.github.com/users/tommymalmqvist/events{/privacy}","received_events_url":"https://api.github.com/users/tommymalmqvist/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/codelabsab/timereport/pulls/25/commits","review_comments_url":"https://api.github.com/repos/codelabsab/timereport/pulls/25/comments","review_comment_url":"https://api.github.com/repos/codelabsab/timereport/pulls/comments{/number}","comments_url":"https://api.github.com/repos/codelabsab/timereport/issues/25/comments","statuses_url":"https://api.github.com/repos/codelabsab/timereport/statuses/2548deff0e22149a089d9ca418323ec5e180fd1e","head":{"label":"codelabsab:use_parse_qs","ref":"use_parse_qs","sha":"2548deff0e22149a089d9ca418323ec5e180fd1e","user":{"login":"codelabsab","id":20194383,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwMTk0Mzgz","avatar_url":"https://avatars0.githubusercontent.com/u/20194383?v=4","gravatar_id":"","url":"https://api.github.com/users/codelabsab","html_url":"https://github.com/codelabsab","followers_url":"https://api.github.com/users/codelabsab/followers","following_url":"https://api.github.com/users/codelabsab/following{/other_user}","gists_url":"https://api.github.com/users/codelabsab/gists{/gist_id}","starred_url":"https://api.github.com/users/codelabsab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codelabsab/subscriptions","organizations_url":"https://api.github.com/users/codelabsab/orgs","repos_url":"https://api.github.com/users/codelabsab/repos","events_url":"https://api.github.com/users/codelabsab/events{/privacy}","received_events_url":"https://api.github.com/users/codelabsab/received_events","type":"Organization","site_admin":false},"repo":{"id":146574433,"node_id":"MDEwOlJlcG9zaXRvcnkxNDY1NzQ0MzM=","name":"timereport","full_name":"codelabsab/timereport","private":false,"owner":{"login":"codelabsab","id":20194383,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwMTk0Mzgz","avatar_url":"https://avatars0.githubusercontent.com/u/20194383?v=4","gravatar_id":"","url":"https://api.github.com/users/codelabsab","html_url":"https://github.com/codelabsab","followers_url":"https://api.github.com/users/codelabsab/followers","following_url":"https://api.github.com/users/codelabsab/following{/other_user}","gists_url":"https://api.github.com/users/codelabsab/gists{/gist_id}","starred_url":"https://api.github.com/users/codelabsab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codelabsab/subscriptions","organizations_url":"https://api.github.com/users/codelabsab/orgs","repos_url":"https://api.github.com/users/codelabsab/repos","events_url":"https://api.github.com/users/codelabsab/events{/privacy}","received_events_url":"https://api.github.com/users/codelabsab/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/codelabsab/timereport","description":"slack timereporting tool using aws lambda, api gateway, flask and python","fork":false,"url":"https://api.github.com/repos/codelabsab/timereport","forks_url":"https://api.github.com/repos/codelabsab/timereport/forks","keys_url":"https://api.github.com/repos/codelabsab/timereport/keys{/key_id}","collaborators_url":"https://api.github.com/repos/codelabsab/timereport/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/codelabsab/timereport/teams","hooks_url":"https://api.github.com/repos/codelabsab/timereport/hooks","issue_events_url":"https://api.github.com/repos/codelabsab/timereport/issues/events{/number}","events_url":"https://api.github.com/repos/codelabsab/timereport/events","assignees_url":"https://api.github.com/repos/codelabsab/timereport/assignees{/user}","branches_url":"https://api.github.com/repos/codelabsab/timereport/branches{/branch}","tags_url":"https://api.github.com/repos/codelabsab/timereport/tags","blobs_url":"https://api.github.com/repos/codelabsab/timereport/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/codelabsab/timereport/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/codelabsab/timereport/git/refs{/sha}","trees_url":"https://api.github.com/repos/codelabsab/timereport/git/trees{/sha}","statuses_url":"https://api.github.com/repos/codelabsab/timereport/statuses/{sha}","languages_url":"https://api.github.com/repos/codelabsab/timereport/languages","stargazers_url":"https://api.github.com/repos/codelabsab/timereport/stargazers","contributors_url":"https://api.github.com/repos/codelabsab/timereport/contributors","subscribers_url":"https://api.github.com/repos/codelabsab/timereport/subscribers","subscription_url":"https://api.github.com/repos/codelabsab/timereport/subscription","commits_url":"https://api.github.com/repos/codelabsab/timereport/commits{/sha}","git_commits_url":"https://api.github.com/repos/codelabsab/timereport/git/commits{/sha}","comments_url":"https://api.github.com/repos/codelabsab/timereport/comments{/number}","issue_comment_url":"https://api.github.com/repos/codelabsab/timereport/issues/comments{/number}","contents_url":"https://api.github.com/repos/codelabsab/timereport/contents/{+path}","compare_url":"https://api.github.com/repos/codelabsab/timereport/compare/{base}...{head}","merges_url":"https://api.github.com/repos/codelabsab/timereport/merges","archive_url":"https://api.github.com/repos/codelabsab/timereport/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/codelabsab/timereport/downloads","issues_url":"https://api.github.com/repos/codelabsab/timereport/issues{/number}","pulls_url":"https://api.github.com/repos/codelabsab/timereport/pulls{/number}","milestones_url":"https://api.github.com/repos/codelabsab/timereport/milestones{/number}","notifications_url":"https://api.github.com/repos/codelabsab/timereport/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/codelabsab/timereport/labels{/name}","releases_url":"https://api.github.com/repos/codelabsab/timereport/releases{/id}","deployments_url":"https://api.github.com/repos/codelabsab/timereport/deployments","created_at":"2018-08-29T09:08:20Z","updated_at":"2018-10-14T14:42:34Z","pushed_at":"2018-12-30T10:01:46Z","git_url":"git://github.com/codelabsab/timereport.git","ssh_url":"[email protected]:codelabsab/timereport.git","clone_url":"https://github.com/codelabsab/timereport.git","svn_url":"https://github.com/codelabsab/timereport","homepage":"","size":180,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":14,"license":null,"forks":0,"open_issues":14,"watchers":0,"default_branch":"master"}},"base":{"label":"codelabsab:factory","ref":"factory","sha":"7bb0dd63eae1eb0fba8366e30b93808ac05a5b9b","user":{"login":"codelabsab","id":20194383,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwMTk0Mzgz","avatar_url":"https://avatars0.githubusercontent.com/u/20194383?v=4","gravatar_id":"","url":"https://api.github.com/users/codelabsab","html_url":"https://github.com/codelabsab","followers_url":"https://api.github.com/users/codelabsab/followers","following_url":"https://api.github.com/users/codelabsab/following{/other_user}","gists_url":"https://api.github.com/users/codelabsab/gists{/gist_id}","starred_url":"https://api.github.com/users/codelabsab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codelabsab/subscriptions","organizations_url":"https://api.github.com/users/codelabsab/orgs","repos_url":"https://api.github.com/users/codelabsab/repos","events_url":"https://api.github.com/users/codelabsab/events{/privacy}","received_events_url":"https://api.github.com/users/codelabsab/received_events","type":"Organization","site_admin":false},"repo":{"id":146574433,"node_id":"MDEwOlJlcG9zaXRvcnkxNDY1NzQ0MzM=","name":"timereport","full_name":"codelabsab/timereport","private":false,"owner":{"login":"codelabsab","id":20194383,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwMTk0Mzgz","avatar_url":"https://avatars0.githubusercontent.com/u/20194383?v=4","gravatar_id":"","url":"https://api.github.com/users/codelabsab","html_url":"https://github.com/codelabsab","followers_url":"https://api.github.com/users/codelabsab/followers","following_url":"https://api.github.com/users/codelabsab/following{/other_user}","gists_url":"https://api.github.com/users/codelabsab/gists{/gist_id}","starred_url":"https://api.github.com/users/codelabsab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codelabsab/subscriptions","organizations_url":"https://api.github.com/users/codelabsab/orgs","repos_url":"https://api.github.com/users/codelabsab/repos","events_url":"https://api.github.com/users/codelabsab/events{/privacy}","received_events_url":"https://api.github.com/users/codelabsab/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/codelabsab/timereport","description":"slack timereporting tool using aws lambda, api gateway, flask and python","fork":false,"url":"https://api.github.com/repos/codelabsab/timereport","forks_url":"https://api.github.com/repos/codelabsab/timereport/forks","keys_url":"https://api.github.com/repos/codelabsab/timereport/keys{/key_id}","collaborators_url":"https://api.github.com/repos/codelabsab/timereport/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/codelabsab/timereport/teams","hooks_url":"https://api.github.com/repos/codelabsab/timereport/hooks","issue_events_url":"https://api.github.com/repos/codelabsab/timereport/issues/events{/number}","events_url":"https://api.github.com/repos/codelabsab/timereport/events","assignees_url":"https://api.github.com/repos/codelabsab/timereport/assignees{/user}","branches_url":"https://api.github.com/repos/codelabsab/timereport/branches{/branch}","tags_url":"https://api.github.com/repos/codelabsab/timereport/tags","blobs_url":"https://api.github.com/repos/codelabsab/timereport/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/codelabsab/timereport/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/codelabsab/timereport/git/refs{/sha}","trees_url":"https://api.github.com/repos/codelabsab/timereport/git/trees{/sha}","statuses_url":"https://api.github.com/repos/codelabsab/timereport/statuses/{sha}","languages_url":"https://api.github.com/repos/codelabsab/timereport/languages","stargazers_url":"https://api.github.com/repos/codelabsab/timereport/stargazers","contributors_url":"https://api.github.com/repos/codelabsab/timereport/contributors","subscribers_url":"https://api.github.com/repos/codelabsab/timereport/subscribers","subscription_url":"https://api.github.com/repos/codelabsab/timereport/subscription","commits_url":"https://api.github.com/repos/codelabsab/timereport/commits{/sha}","git_commits_url":"https://api.github.com/repos/codelabsab/timereport/git/commits{/sha}","comments_url":"https://api.github.com/repos/codelabsab/timereport/comments{/number}","issue_comment_url":"https://api.github.com/repos/codelabsab/timereport/issues/comments{/number}","contents_url":"https://api.github.com/repos/codelabsab/timereport/contents/{+path}","compare_url":"https://api.github.com/repos/codelabsab/timereport/compare/{base}...{head}","merges_url":"https://api.github.com/repos/codelabsab/timereport/merges","archive_url":"https://api.github.com/repos/codelabsab/timereport/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/codelabsab/timereport/downloads","issues_url":"https://api.github.com/repos/codelabsab/timereport/issues{/number}","pulls_url":"https://api.github.com/repos/codelabsab/timereport/pulls{/number}","milestones_url":"https://api.github.com/repos/codelabsab/timereport/milestones{/number}","notifications_url":"https://api.github.com/repos/codelabsab/timereport/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/codelabsab/timereport/labels{/name}","releases_url":"https://api.github.com/repos/codelabsab/timereport/releases{/id}","deployments_url":"https://api.github.com/repos/codelabsab/timereport/deployments","created_at":"2018-08-29T09:08:20Z","updated_at":"2018-10-14T14:42:34Z","pushed_at":"2018-12-30T10:01:46Z","git_url":"git://github.com/codelabsab/timereport.git","ssh_url":"[email protected]:codelabsab/timereport.git","clone_url":"https://github.com/codelabsab/timereport.git","svn_url":"https://github.com/codelabsab/timereport","homepage":"","size":180,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":14,"license":null,"forks":0,"open_issues":14,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/codelabsab/timereport/pulls/25"},"html":{"href":"https://github.com/codelabsab/timereport/pull/25"},"issue":{"href":"https://api.github.com/repos/codelabsab/timereport/issues/25"},"comments":{"href":"https://api.github.com/repos/codelabsab/timereport/issues/25/comments"},"review_comments":{"href":"https://api.github.com/repos/codelabsab/timereport/pulls/25/comments"},"review_comment":{"href":"https://api.github.com/repos/codelabsab/timereport/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/codelabsab/timereport/pulls/25/commits"},"statuses":{"href":"https://api.github.com/repos/codelabsab/timereport/statuses/2548deff0e22149a089d9ca418323ec5e180fd1e"}},"author_association":"MEMBER"}} | {
"id": 146574433,
"name": "codelabsab/timereport",
"url": "https://api.github.com/repos/codelabsab/timereport"
} | {
"id": 9321510,
"login": "kamigerami",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9321510?",
"url": "https://api.github.com/users/kamigerami"
} | {
"id": 20194383,
"login": "codelabsab",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/20194383?",
"url": "https://api.github.com/orgs/codelabsab"
} | 2018-12-30T10:10:13 | 8816400812 | {"actor":{"display_login":"kamigerami"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/singularityware/singularity/pulls/comments/218958323","pull_request_review_id":157014978,"id":218958323,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxODk1ODMyMw==","diff_hunk":"@@ -0,0 +1,134 @@\n+// Copyright (c) 2018, Sylabs Inc. All rights reserved.\n+// This software is licensed under a 3-clause BSD license. Please consult the\n+// LICENSE.md file distributed with the sources of this project regarding your\n+// rights to use or distribute this software.\n+\n+package nvidiautils\n+\n+import (\n+\t\"bufio\"\n+\t\"os\"\n+\t\"os/exec\"\n+\t\"path/filepath\"\n+\t\"regexp\"\n+\t\"strings\"\n+)\n+\n+// GetNvidiaBindPath returns a string array consisting of filepaths of nvidia\n+// related files to be added to the BindPaths\n+func GetNvidiaBindPath(abspath string) []string {\n+\tvar strArray []string\n+\tvar bindArray []string\n+\tvar searchArray []string\n+\tvar commentID = regexp.MustCompile(`#`)\n+\tvar soID = regexp.MustCompile(\".so\")\n+\n+\t// use nvidia-container-cli (if present)\n+\tcommand, err := exec.LookPath(\"nvidia-container-cli\")\n+\tif err == nil {\n+\t\tcmd := exec.Command(command, \"list\", \"--binaries\", \"--ipcs\", \"--libraries\")\n+\t\tout, err := cmd.Output()\n+\t\tif err == nil {\n+\n+\t\t\tfor _, line := range strings.Split(string(out), \"\\n\") {\n+\t\t\t\tval := soID.FindString(line) // this will disallow binaries (non .so files)\n+\t\t\t\tif val != \"\" { // contains .so\n+\t\t\t\t\tif line != \"\" {\n+\t\t\t\t\t\t// extract the filename from the path\n+\t\t\t\t\t\tfileNames := strings.SplitAfter(line, \"/\")\n+\t\t\t\t\t\tfileName := fileNames[len(fileNames)-1]\n+\n+\t\t\t\t\t\ttestString := line + \":/.singularity.d/libs/\" + fileName\n+\t\t\t\t\t\tbindArray = append(bindArray, testString)\n+\t\t\t\t\t\tstrArray = append(strArray, fileName)\n+\t\t\t\t\t}\n+\t\t\t\t} else { // binary executable\n+\t\t\t\t\tbindArray = append(bindArray, line)\n+\t\t\t\t\tstrArray = append(strArray, line)\n+\t\t\t\t}\n+\t\t\t}\n+\t\t}\n+\t}\n+\n+\tcliEntries := strings.Join(strArray, \" \") // save away for later comparison check (disallow duplicates)\n+\n+\t// grab the entries in nvliblist.conf file\n+\t// use ldconfig to pattern match from ld.so.cache\n+\tnewpath, err := filepath.Glob(abspath + \"/nvliblist.conf\")","path":"src/pkg/util/nvidiautils/nvidiautils.go","position":57,"original_position":57,"commit_id":"672f0e753500b55b26a04f736fb72b3c47ba3216","original_commit_id":"672f0e753500b55b26a04f736fb72b3c47ba3216","user":{"login":"GodloveD","id":7672924,"node_id":"MDQ6VXNlcjc2NzI5MjQ=","avatar_url":"https://avatars3.githubusercontent.com/u/7672924?v=4","gravatar_id":"","url":"https://api.github.com/users/GodloveD","html_url":"https://github.com/GodloveD","followers_url":"https://api.github.com/users/GodloveD/followers","following_url":"https://api.github.com/users/GodloveD/following{/other_user}","gists_url":"https://api.github.com/users/GodloveD/gists{/gist_id}","starred_url":"https://api.github.com/users/GodloveD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GodloveD/subscriptions","organizations_url":"https://api.github.com/users/GodloveD/orgs","repos_url":"https://api.github.com/users/GodloveD/repos","events_url":"https://api.github.com/users/GodloveD/events{/privacy}","received_events_url":"https://api.github.com/users/GodloveD/received_events","type":"User","site_admin":false},"body":"If you want to just append `.1` to all of the `nvidia-container-cli` entries and search for them as well, I think it's reasonable? \r\n\r\n@jmstover yes there was a recent issue where a user was confused b/c `nvidia-container-cli` does not provide open GL libraries, but that behavior is correct and our behavior is wrong. We should comment those libs out of the conf file imho because those libs are not strictly tied to the version of the driver as the other libs are. ","created_at":"2018-09-19T20:47:48Z","updated_at":"2018-09-19T20:47:49Z","html_url":"https://github.com/singularityware/singularity/pull/2020#discussion_r218958323","pull_request_url":"https://api.github.com/repos/singularityware/singularity/pulls/2020","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/singularityware/singularity/pulls/comments/218958323"},"html":{"href":"https://github.com/singularityware/singularity/pull/2020#discussion_r218958323"},"pull_request":{"href":"https://api.github.com/repos/singularityware/singularity/pulls/2020"}},"in_reply_to_id":218934987},"pull_request":{"url":"https://api.github.com/repos/singularityware/singularity/pulls/2020","id":216672956,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE2NjcyOTU2","html_url":"https://github.com/singularityware/singularity/pull/2020","diff_url":"https://github.com/singularityware/singularity/pull/2020.diff","patch_url":"https://github.com/singularityware/singularity/pull/2020.patch","issue_url":"https://api.github.com/repos/singularityware/singularity/issues/2020","number":2020,"state":"open","locked":false,"title":"Enable --nv option to bind in nvidia drivers","user":{"login":"ctmadison","id":35241899,"node_id":"MDQ6VXNlcjM1MjQxODk5","avatar_url":"https://avatars3.githubusercontent.com/u/35241899?v=4","gravatar_id":"","url":"https://api.github.com/users/ctmadison","html_url":"https://github.com/ctmadison","followers_url":"https://api.github.com/users/ctmadison/followers","following_url":"https://api.github.com/users/ctmadison/following{/other_user}","gists_url":"https://api.github.com/users/ctmadison/gists{/gist_id}","starred_url":"https://api.github.com/users/ctmadison/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ctmadison/subscriptions","organizations_url":"https://api.github.com/users/ctmadison/orgs","repos_url":"https://api.github.com/users/ctmadison/repos","events_url":"https://api.github.com/users/ctmadison/events{/privacy}","received_events_url":"https://api.github.com/users/ctmadison/received_events","type":"User","site_admin":false},"body":"**Description of the Pull Request (PR):**\r\n\r\nAdd in support for automatically binding Nvidia libraries/drivers with a cmd line --nv argument.\r\n\r\n\r\n**This fixes or addresses the following GitHub issues:**\r\n\r\n- Fixes #1886\r\n\r\n\r\n**Checkoff for all PRs:**\r\n\r\n- [x] I have read the [Guidelines for Contributing](https://github.com/singularityware/singularity/blob/master/CONTRIBUTING.md), and this PR conforms to the stated requirements.\r\n- [ ] I have added changes to the [CHANGELOG](https://github.com/singularityware/singularity/blob/development/CHANGELOG.md) and and documentation updates to the [singularityware](https://www.github.com/singularityware/singularityware.github.io) documentation base.\r\n- [ ] I have tested this PR locally with a `make test`\r\n- [x] This PR is against the project's master branch\r\n- [x] I have added myself as a contributor to the [contributors's file](https://github.com/singularityware/singularity/blob/master/CONTRIBUTORS.md)\r\n- [x] This PR is ready for review and/or merge\r\n\r\n\r\nAttn: @singularityware-admin\r\n","created_at":"2018-09-19T15:01:43Z","updated_at":"2018-09-19T20:47:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0c5f397e7333e2a1e5c7c7637c58024211c9af85","assignee":{"login":"cclerget","id":3274134,"node_id":"MDQ6VXNlcjMyNzQxMzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/3274134?v=4","gravatar_id":"","url":"https://api.github.com/users/cclerget","html_url":"https://github.com/cclerget","followers_url":"https://api.github.com/users/cclerget/followers","following_url":"https://api.github.com/users/cclerget/following{/other_user}","gists_url":"https://api.github.com/users/cclerget/gists{/gist_id}","starred_url":"https://api.github.com/users/cclerget/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cclerget/subscriptions","organizations_url":"https://api.github.com/users/cclerget/orgs","repos_url":"https://api.github.com/users/cclerget/repos","events_url":"https://api.github.com/users/cclerget/events{/privacy}","received_events_url":"https://api.github.com/users/cclerget/received_events","type":"User","site_admin":false},"assignees":[{"login":"cclerget","id":3274134,"node_id":"MDQ6VXNlcjMyNzQxMzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/3274134?v=4","gravatar_id":"","url":"https://api.github.com/users/cclerget","html_url":"https://github.com/cclerget","followers_url":"https://api.github.com/users/cclerget/followers","following_url":"https://api.github.com/users/cclerget/following{/other_user}","gists_url":"https://api.github.com/users/cclerget/gists{/gist_id}","starred_url":"https://api.github.com/users/cclerget/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cclerget/subscriptions","organizations_url":"https://api.github.com/users/cclerget/orgs","repos_url":"https://api.github.com/users/cclerget/repos","events_url":"https://api.github.com/users/cclerget/events{/privacy}","received_events_url":"https://api.github.com/users/cclerget/received_events","type":"User","site_admin":false},{"login":"GodloveD","id":7672924,"node_id":"MDQ6VXNlcjc2NzI5MjQ=","avatar_url":"https://avatars3.githubusercontent.com/u/7672924?v=4","gravatar_id":"","url":"https://api.github.com/users/GodloveD","html_url":"https://github.com/GodloveD","followers_url":"https://api.github.com/users/GodloveD/followers","following_url":"https://api.github.com/users/GodloveD/following{/other_user}","gists_url":"https://api.github.com/users/GodloveD/gists{/gist_id}","starred_url":"https://api.github.com/users/GodloveD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GodloveD/subscriptions","organizations_url":"https://api.github.com/users/GodloveD/orgs","repos_url":"https://api.github.com/users/GodloveD/repos","events_url":"https://api.github.com/users/GodloveD/events{/privacy}","received_events_url":"https://api.github.com/users/GodloveD/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":775894486,"node_id":"MDU6TGFiZWw3NzU4OTQ0ODY=","url":"https://api.github.com/repos/singularityware/singularity/labels/Release%203.0","name":"Release 3.0","color":"398bef","default":false}],"milestone":{"url":"https://api.github.com/repos/singularityware/singularity/milestones/12","html_url":"https://github.com/singularityware/singularity/milestone/12","labels_url":"https://api.github.com/repos/singularityware/singularity/milestones/12/labels","id":3622224,"node_id":"MDk6TWlsZXN0b25lMzYyMjIyNA==","number":12,"title":"3.0.0 Release Beta","description":"These are things that need to get done before the 3.0.0 Beta release. 😄 ","creator":{"login":"GodloveD","id":7672924,"node_id":"MDQ6VXNlcjc2NzI5MjQ=","avatar_url":"https://avatars3.githubusercontent.com/u/7672924?v=4","gravatar_id":"","url":"https://api.github.com/users/GodloveD","html_url":"https://github.com/GodloveD","followers_url":"https://api.github.com/users/GodloveD/followers","following_url":"https://api.github.com/users/GodloveD/following{/other_user}","gists_url":"https://api.github.com/users/GodloveD/gists{/gist_id}","starred_url":"https://api.github.com/users/GodloveD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GodloveD/subscriptions","organizations_url":"https://api.github.com/users/GodloveD/orgs","repos_url":"https://api.github.com/users/GodloveD/repos","events_url":"https://api.github.com/users/GodloveD/events{/privacy}","received_events_url":"https://api.github.com/users/GodloveD/received_events","type":"User","site_admin":false},"open_issues":26,"closed_issues":48,"state":"open","created_at":"2018-09-04T20:01:15Z","updated_at":"2018-09-19T17:45:55Z","due_on":"2018-09-24T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/singularityware/singularity/pulls/2020/commits","review_comments_url":"https://api.github.com/repos/singularityware/singularity/pulls/2020/comments","review_comment_url":"https://api.github.com/repos/singularityware/singularity/pulls/comments{/number}","comments_url":"https://api.github.com/repos/singularityware/singularity/issues/2020/comments","statuses_url":"https://api.github.com/repos/singularityware/singularity/statuses/672f0e753500b55b26a04f736fb72b3c47ba3216","head":{"label":"ctmadison:enable_nv","ref":"enable_nv","sha":"672f0e753500b55b26a04f736fb72b3c47ba3216","user":{"login":"ctmadison","id":35241899,"node_id":"MDQ6VXNlcjM1MjQxODk5","avatar_url":"https://avatars3.githubusercontent.com/u/35241899?v=4","gravatar_id":"","url":"https://api.github.com/users/ctmadison","html_url":"https://github.com/ctmadison","followers_url":"https://api.github.com/users/ctmadison/followers","following_url":"https://api.github.com/users/ctmadison/following{/other_user}","gists_url":"https://api.github.com/users/ctmadison/gists{/gist_id}","starred_url":"https://api.github.com/users/ctmadison/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ctmadison/subscriptions","organizations_url":"https://api.github.com/users/ctmadison/orgs","repos_url":"https://api.github.com/users/ctmadison/repos","events_url":"https://api.github.com/users/ctmadison/events{/privacy}","received_events_url":"https://api.github.com/users/ctmadison/received_events","type":"User","site_admin":false},"repo":{"id":145888018,"node_id":"MDEwOlJlcG9zaXRvcnkxNDU4ODgwMTg=","name":"singularity","full_name":"ctmadison/singularity","private":false,"owner":{"login":"ctmadison","id":35241899,"node_id":"MDQ6VXNlcjM1MjQxODk5","avatar_url":"https://avatars3.githubusercontent.com/u/35241899?v=4","gravatar_id":"","url":"https://api.github.com/users/ctmadison","html_url":"https://github.com/ctmadison","followers_url":"https://api.github.com/users/ctmadison/followers","following_url":"https://api.github.com/users/ctmadison/following{/other_user}","gists_url":"https://api.github.com/users/ctmadison/gists{/gist_id}","starred_url":"https://api.github.com/users/ctmadison/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ctmadison/subscriptions","organizations_url":"https://api.github.com/users/ctmadison/orgs","repos_url":"https://api.github.com/users/ctmadison/repos","events_url":"https://api.github.com/users/ctmadison/events{/privacy}","received_events_url":"https://api.github.com/users/ctmadison/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ctmadison/singularity","description":"Singularity: Application containers for Linux","fork":true,"url":"https://api.github.com/repos/ctmadison/singularity","forks_url":"https://api.github.com/repos/ctmadison/singularity/forks","keys_url":"https://api.github.com/repos/ctmadison/singularity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ctmadison/singularity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ctmadison/singularity/teams","hooks_url":"https://api.github.com/repos/ctmadison/singularity/hooks","issue_events_url":"https://api.github.com/repos/ctmadison/singularity/issues/events{/number}","events_url":"https://api.github.com/repos/ctmadison/singularity/events","assignees_url":"https://api.github.com/repos/ctmadison/singularity/assignees{/user}","branches_url":"https://api.github.com/repos/ctmadison/singularity/branches{/branch}","tags_url":"https://api.github.com/repos/ctmadison/singularity/tags","blobs_url":"https://api.github.com/repos/ctmadison/singularity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ctmadison/singularity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ctmadison/singularity/git/refs{/sha}","trees_url":"https://api.github.com/repos/ctmadison/singularity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ctmadison/singularity/statuses/{sha}","languages_url":"https://api.github.com/repos/ctmadison/singularity/languages","stargazers_url":"https://api.github.com/repos/ctmadison/singularity/stargazers","contributors_url":"https://api.github.com/repos/ctmadison/singularity/contributors","subscribers_url":"https://api.github.com/repos/ctmadison/singularity/subscribers","subscription_url":"https://api.github.com/repos/ctmadison/singularity/subscription","commits_url":"https://api.github.com/repos/ctmadison/singularity/commits{/sha}","git_commits_url":"https://api.github.com/repos/ctmadison/singularity/git/commits{/sha}","comments_url":"https://api.github.com/repos/ctmadison/singularity/comments{/number}","issue_comment_url":"https://api.github.com/repos/ctmadison/singularity/issues/comments{/number}","contents_url":"https://api.github.com/repos/ctmadison/singularity/contents/{+path}","compare_url":"https://api.github.com/repos/ctmadison/singularity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ctmadison/singularity/merges","archive_url":"https://api.github.com/repos/ctmadison/singularity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ctmadison/singularity/downloads","issues_url":"https://api.github.com/repos/ctmadison/singularity/issues{/number}","pulls_url":"https://api.github.com/repos/ctmadison/singularity/pulls{/number}","milestones_url":"https://api.github.com/repos/ctmadison/singularity/milestones{/number}","notifications_url":"https://api.github.com/repos/ctmadison/singularity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ctmadison/singularity/labels{/name}","releases_url":"https://api.github.com/repos/ctmadison/singularity/releases{/id}","deployments_url":"https://api.github.com/repos/ctmadison/singularity/deployments","created_at":"2018-08-23T17:44:42Z","updated_at":"2018-09-19T14:28:36Z","pushed_at":"2018-09-19T15:24:02Z","git_url":"git://github.com/ctmadison/singularity.git","ssh_url":"[email protected]:ctmadison/singularity.git","clone_url":"https://github.com/ctmadison/singularity.git","svn_url":"https://github.com/ctmadison/singularity","homepage":"https://www.sylabs.io/singularity/","size":11492,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"singularityware:master","ref":"master","sha":"8eea5c3ca1549d4ab8f245060bda94774348a72b","user":{"login":"singularityware","id":20306680,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwMzA2Njgw","avatar_url":"https://avatars0.githubusercontent.com/u/20306680?v=4","gravatar_id":"","url":"https://api.github.com/users/singularityware","html_url":"https://github.com/singularityware","followers_url":"https://api.github.com/users/singularityware/followers","following_url":"https://api.github.com/users/singularityware/following{/other_user}","gists_url":"https://api.github.com/users/singularityware/gists{/gist_id}","starred_url":"https://api.github.com/users/singularityware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/singularityware/subscriptions","organizations_url":"https://api.github.com/users/singularityware/orgs","repos_url":"https://api.github.com/users/singularityware/repos","events_url":"https://api.github.com/users/singularityware/events{/privacy}","received_events_url":"https://api.github.com/users/singularityware/received_events","type":"Organization","site_admin":false},"repo":{"id":43982667,"node_id":"MDEwOlJlcG9zaXRvcnk0Mzk4MjY2Nw==","name":"singularity","full_name":"singularityware/singularity","private":false,"owner":{"login":"singularityware","id":20306680,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwMzA2Njgw","avatar_url":"https://avatars0.githubusercontent.com/u/20306680?v=4","gravatar_id":"","url":"https://api.github.com/users/singularityware","html_url":"https://github.com/singularityware","followers_url":"https://api.github.com/users/singularityware/followers","following_url":"https://api.github.com/users/singularityware/following{/other_user}","gists_url":"https://api.github.com/users/singularityware/gists{/gist_id}","starred_url":"https://api.github.com/users/singularityware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/singularityware/subscriptions","organizations_url":"https://api.github.com/users/singularityware/orgs","repos_url":"https://api.github.com/users/singularityware/repos","events_url":"https://api.github.com/users/singularityware/events{/privacy}","received_events_url":"https://api.github.com/users/singularityware/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/singularityware/singularity","description":"Singularity: Application containers for Linux","fork":false,"url":"https://api.github.com/repos/singularityware/singularity","forks_url":"https://api.github.com/repos/singularityware/singularity/forks","keys_url":"https://api.github.com/repos/singularityware/singularity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/singularityware/singularity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/singularityware/singularity/teams","hooks_url":"https://api.github.com/repos/singularityware/singularity/hooks","issue_events_url":"https://api.github.com/repos/singularityware/singularity/issues/events{/number}","events_url":"https://api.github.com/repos/singularityware/singularity/events","assignees_url":"https://api.github.com/repos/singularityware/singularity/assignees{/user}","branches_url":"https://api.github.com/repos/singularityware/singularity/branches{/branch}","tags_url":"https://api.github.com/repos/singularityware/singularity/tags","blobs_url":"https://api.github.com/repos/singularityware/singularity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/singularityware/singularity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/singularityware/singularity/git/refs{/sha}","trees_url":"https://api.github.com/repos/singularityware/singularity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/singularityware/singularity/statuses/{sha}","languages_url":"https://api.github.com/repos/singularityware/singularity/languages","stargazers_url":"https://api.github.com/repos/singularityware/singularity/stargazers","contributors_url":"https://api.github.com/repos/singularityware/singularity/contributors","subscribers_url":"https://api.github.com/repos/singularityware/singularity/subscribers","subscription_url":"https://api.github.com/repos/singularityware/singularity/subscription","commits_url":"https://api.github.com/repos/singularityware/singularity/commits{/sha}","git_commits_url":"https://api.github.com/repos/singularityware/singularity/git/commits{/sha}","comments_url":"https://api.github.com/repos/singularityware/singularity/comments{/number}","issue_comment_url":"https://api.github.com/repos/singularityware/singularity/issues/comments{/number}","contents_url":"https://api.github.com/repos/singularityware/singularity/contents/{+path}","compare_url":"https://api.github.com/repos/singularityware/singularity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/singularityware/singularity/merges","archive_url":"https://api.github.com/repos/singularityware/singularity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/singularityware/singularity/downloads","issues_url":"https://api.github.com/repos/singularityware/singularity/issues{/number}","pulls_url":"https://api.github.com/repos/singularityware/singularity/pulls{/number}","milestones_url":"https://api.github.com/repos/singularityware/singularity/milestones{/number}","notifications_url":"https://api.github.com/repos/singularityware/singularity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/singularityware/singularity/labels{/name}","releases_url":"https://api.github.com/repos/singularityware/singularity/releases{/id}","deployments_url":"https://api.github.com/repos/singularityware/singularity/deployments","created_at":"2015-10-09T22:15:12Z","updated_at":"2018-09-19T13:44:48Z","pushed_at":"2018-09-19T20:24:46Z","git_url":"git://github.com/singularityware/singularity.git","ssh_url":"[email protected]:singularityware/singularity.git","clone_url":"https://github.com/singularityware/singularity.git","svn_url":"https://github.com/singularityware/singularity","homepage":"https://www.sylabs.io/singularity/","size":11467,"stargazers_count":767,"watchers_count":767,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":220,"mirror_url":null,"archived":false,"open_issues_count":284,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":220,"open_issues":284,"watchers":767,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/singularityware/singularity/pulls/2020"},"html":{"href":"https://github.com/singularityware/singularity/pull/2020"},"issue":{"href":"https://api.github.com/repos/singularityware/singularity/issues/2020"},"comments":{"href":"https://api.github.com/repos/singularityware/singularity/issues/2020/comments"},"review_comments":{"href":"https://api.github.com/repos/singularityware/singularity/pulls/2020/comments"},"review_comment":{"href":"https://api.github.com/repos/singularityware/singularity/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/singularityware/singularity/pulls/2020/commits"},"statuses":{"href":"https://api.github.com/repos/singularityware/singularity/statuses/672f0e753500b55b26a04f736fb72b3c47ba3216"}},"author_association":"CONTRIBUTOR"}} | {
"id": 43982667,
"name": "singularityware/singularity",
"url": "https://api.github.com/repos/singularityware/singularity"
} | {
"id": 7672924,
"login": "GodloveD",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7672924?",
"url": "https://api.github.com/users/GodloveD"
} | {
"id": 20306680,
"login": "singularityware",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/20306680?",
"url": "https://api.github.com/orgs/singularityware"
} | 2018-09-19T20:47:48 | 8291546760 | {"actor":{"display_login":"GodloveD"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/joinfaces/joinfaces/pulls/comments/232389937","pull_request_review_id":173585449,"id":232389937,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMjM4OTkzNw==","diff_hunk":"@@ -12,6 +13,7 @@ buildscript {\n classpath \"com.netflix.nebula:gradle-lint-plugin:10.1.3\"\n classpath \"de.aaschmid:gradle-cpd-plugin:1.1\"\n classpath \"io.codearte.gradle.nexus:gradle-nexus-staging-plugin:0.12.0\"","path":"build.gradle","position":11,"original_position":11,"commit_id":"1afbb7057dfa53dd7cc767c822180f923a4218b5","original_commit_id":"1afbb7057dfa53dd7cc767c822180f923a4218b5","user":{"login":"persapiens","id":261952,"node_id":"MDQ6VXNlcjI2MTk1Mg==","avatar_url":"https://avatars2.githubusercontent.com/u/261952?v=4","gravatar_id":"","url":"https://api.github.com/users/persapiens","html_url":"https://github.com/persapiens","followers_url":"https://api.github.com/users/persapiens/followers","following_url":"https://api.github.com/users/persapiens/following{/other_user}","gists_url":"https://api.github.com/users/persapiens/gists{/gist_id}","starred_url":"https://api.github.com/users/persapiens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/persapiens/subscriptions","organizations_url":"https://api.github.com/users/persapiens/orgs","repos_url":"https://api.github.com/users/persapiens/repos","events_url":"https://api.github.com/users/persapiens/events{/privacy}","received_events_url":"https://api.github.com/users/persapiens/received_events","type":"User","site_admin":false},"body":"Should `gradle-nexus-staging-plugin` not be removed?","created_at":"2018-11-09T20:52:22Z","updated_at":"2018-11-09T20:56:30Z","html_url":"https://github.com/joinfaces/joinfaces/pull/574#discussion_r232389937","pull_request_url":"https://api.github.com/repos/joinfaces/joinfaces/pulls/574","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/joinfaces/joinfaces/pulls/comments/232389937"},"html":{"href":"https://github.com/joinfaces/joinfaces/pull/574#discussion_r232389937"},"pull_request":{"href":"https://api.github.com/repos/joinfaces/joinfaces/pulls/574"}}},"pull_request":{"url":"https://api.github.com/repos/joinfaces/joinfaces/pulls/574","id":229778836,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5Nzc4ODM2","html_url":"https://github.com/joinfaces/joinfaces/pull/574","diff_url":"https://github.com/joinfaces/joinfaces/pull/574.diff","patch_url":"https://github.com/joinfaces/joinfaces/pull/574.patch","issue_url":"https://api.github.com/repos/joinfaces/joinfaces/issues/574","number":574,"state":"open","locked":false,"title":"Fix nexus publishing on travis","user":{"login":"larsgrefer","id":6069961,"node_id":"MDQ6VXNlcjYwNjk5NjE=","avatar_url":"https://avatars3.githubusercontent.com/u/6069961?v=4","gravatar_id":"","url":"https://api.github.com/users/larsgrefer","html_url":"https://github.com/larsgrefer","followers_url":"https://api.github.com/users/larsgrefer/followers","following_url":"https://api.github.com/users/larsgrefer/following{/other_user}","gists_url":"https://api.github.com/users/larsgrefer/gists{/gist_id}","starred_url":"https://api.github.com/users/larsgrefer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/larsgrefer/subscriptions","organizations_url":"https://api.github.com/users/larsgrefer/orgs","repos_url":"https://api.github.com/users/larsgrefer/repos","events_url":"https://api.github.com/users/larsgrefer/events{/privacy}","received_events_url":"https://api.github.com/users/larsgrefer/received_events","type":"User","site_admin":false},"body":"fixes #573\r\n\r\nsee also: marcphilipp/nexus-publish-plugin#1","created_at":"2018-11-09T18:23:49Z","updated_at":"2018-11-09T20:56:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8c268e99e11e3c37bda7aefa76f31c1a0618d6fd","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":366359072,"node_id":"MDU6TGFiZWwzNjYzNTkwNzI=","url":"https://api.github.com/repos/joinfaces/joinfaces/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/joinfaces/joinfaces/pulls/574/commits","review_comments_url":"https://api.github.com/repos/joinfaces/joinfaces/pulls/574/comments","review_comment_url":"https://api.github.com/repos/joinfaces/joinfaces/pulls/comments{/number}","comments_url":"https://api.github.com/repos/joinfaces/joinfaces/issues/574/comments","statuses_url":"https://api.github.com/repos/joinfaces/joinfaces/statuses/1afbb7057dfa53dd7cc767c822180f923a4218b5","head":{"label":"larsgrefer:feature/nexusPublishPlugin","ref":"feature/nexusPublishPlugin","sha":"1afbb7057dfa53dd7cc767c822180f923a4218b5","user":{"login":"larsgrefer","id":6069961,"node_id":"MDQ6VXNlcjYwNjk5NjE=","avatar_url":"https://avatars3.githubusercontent.com/u/6069961?v=4","gravatar_id":"","url":"https://api.github.com/users/larsgrefer","html_url":"https://github.com/larsgrefer","followers_url":"https://api.github.com/users/larsgrefer/followers","following_url":"https://api.github.com/users/larsgrefer/following{/other_user}","gists_url":"https://api.github.com/users/larsgrefer/gists{/gist_id}","starred_url":"https://api.github.com/users/larsgrefer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/larsgrefer/subscriptions","organizations_url":"https://api.github.com/users/larsgrefer/orgs","repos_url":"https://api.github.com/users/larsgrefer/repos","events_url":"https://api.github.com/users/larsgrefer/events{/privacy}","received_events_url":"https://api.github.com/users/larsgrefer/received_events","type":"User","site_admin":false},"repo":{"id":79970372,"node_id":"MDEwOlJlcG9zaXRvcnk3OTk3MDM3Mg==","name":"joinfaces","full_name":"larsgrefer/joinfaces","private":false,"owner":{"login":"larsgrefer","id":6069961,"node_id":"MDQ6VXNlcjYwNjk5NjE=","avatar_url":"https://avatars3.githubusercontent.com/u/6069961?v=4","gravatar_id":"","url":"https://api.github.com/users/larsgrefer","html_url":"https://github.com/larsgrefer","followers_url":"https://api.github.com/users/larsgrefer/followers","following_url":"https://api.github.com/users/larsgrefer/following{/other_user}","gists_url":"https://api.github.com/users/larsgrefer/gists{/gist_id}","starred_url":"https://api.github.com/users/larsgrefer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/larsgrefer/subscriptions","organizations_url":"https://api.github.com/users/larsgrefer/orgs","repos_url":"https://api.github.com/users/larsgrefer/repos","events_url":"https://api.github.com/users/larsgrefer/events{/privacy}","received_events_url":"https://api.github.com/users/larsgrefer/received_events","type":"User","site_admin":false},"html_url":"https://github.com/larsgrefer/joinfaces","description":"JoinFaces: JSF Spring Boot Starters - JSF inside JAR packaged Spring Boot Application","fork":true,"url":"https://api.github.com/repos/larsgrefer/joinfaces","forks_url":"https://api.github.com/repos/larsgrefer/joinfaces/forks","keys_url":"https://api.github.com/repos/larsgrefer/joinfaces/keys{/key_id}","collaborators_url":"https://api.github.com/repos/larsgrefer/joinfaces/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/larsgrefer/joinfaces/teams","hooks_url":"https://api.github.com/repos/larsgrefer/joinfaces/hooks","issue_events_url":"https://api.github.com/repos/larsgrefer/joinfaces/issues/events{/number}","events_url":"https://api.github.com/repos/larsgrefer/joinfaces/events","assignees_url":"https://api.github.com/repos/larsgrefer/joinfaces/assignees{/user}","branches_url":"https://api.github.com/repos/larsgrefer/joinfaces/branches{/branch}","tags_url":"https://api.github.com/repos/larsgrefer/joinfaces/tags","blobs_url":"https://api.github.com/repos/larsgrefer/joinfaces/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/larsgrefer/joinfaces/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/larsgrefer/joinfaces/git/refs{/sha}","trees_url":"https://api.github.com/repos/larsgrefer/joinfaces/git/trees{/sha}","statuses_url":"https://api.github.com/repos/larsgrefer/joinfaces/statuses/{sha}","languages_url":"https://api.github.com/repos/larsgrefer/joinfaces/languages","stargazers_url":"https://api.github.com/repos/larsgrefer/joinfaces/stargazers","contributors_url":"https://api.github.com/repos/larsgrefer/joinfaces/contributors","subscribers_url":"https://api.github.com/repos/larsgrefer/joinfaces/subscribers","subscription_url":"https://api.github.com/repos/larsgrefer/joinfaces/subscription","commits_url":"https://api.github.com/repos/larsgrefer/joinfaces/commits{/sha}","git_commits_url":"https://api.github.com/repos/larsgrefer/joinfaces/git/commits{/sha}","comments_url":"https://api.github.com/repos/larsgrefer/joinfaces/comments{/number}","issue_comment_url":"https://api.github.com/repos/larsgrefer/joinfaces/issues/comments{/number}","contents_url":"https://api.github.com/repos/larsgrefer/joinfaces/contents/{+path}","compare_url":"https://api.github.com/repos/larsgrefer/joinfaces/compare/{base}...{head}","merges_url":"https://api.github.com/repos/larsgrefer/joinfaces/merges","archive_url":"https://api.github.com/repos/larsgrefer/joinfaces/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/larsgrefer/joinfaces/downloads","issues_url":"https://api.github.com/repos/larsgrefer/joinfaces/issues{/number}","pulls_url":"https://api.github.com/repos/larsgrefer/joinfaces/pulls{/number}","milestones_url":"https://api.github.com/repos/larsgrefer/joinfaces/milestones{/number}","notifications_url":"https://api.github.com/repos/larsgrefer/joinfaces/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/larsgrefer/joinfaces/labels{/name}","releases_url":"https://api.github.com/repos/larsgrefer/joinfaces/releases{/id}","deployments_url":"https://api.github.com/repos/larsgrefer/joinfaces/deployments","created_at":"2017-01-25T00:57:58Z","updated_at":"2018-11-09T02:40:55Z","pushed_at":"2018-11-09T19:12:17Z","git_url":"git://github.com/larsgrefer/joinfaces.git","ssh_url":"[email protected]:larsgrefer/joinfaces.git","clone_url":"https://github.com/larsgrefer/joinfaces.git","svn_url":"https://github.com/larsgrefer/joinfaces","homepage":"http://joinfaces.org","size":3180,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"joinfaces:master","ref":"master","sha":"e61337519bd81e59b0cf7241ae8785953dc9fd67","user":{"login":"joinfaces","id":20363967,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwMzYzOTY3","avatar_url":"https://avatars3.githubusercontent.com/u/20363967?v=4","gravatar_id":"","url":"https://api.github.com/users/joinfaces","html_url":"https://github.com/joinfaces","followers_url":"https://api.github.com/users/joinfaces/followers","following_url":"https://api.github.com/users/joinfaces/following{/other_user}","gists_url":"https://api.github.com/users/joinfaces/gists{/gist_id}","starred_url":"https://api.github.com/users/joinfaces/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joinfaces/subscriptions","organizations_url":"https://api.github.com/users/joinfaces/orgs","repos_url":"https://api.github.com/users/joinfaces/repos","events_url":"https://api.github.com/users/joinfaces/events{/privacy}","received_events_url":"https://api.github.com/users/joinfaces/received_events","type":"Organization","site_admin":false},"repo":{"id":57401572,"node_id":"MDEwOlJlcG9zaXRvcnk1NzQwMTU3Mg==","name":"joinfaces","full_name":"joinfaces/joinfaces","private":false,"owner":{"login":"joinfaces","id":20363967,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwMzYzOTY3","avatar_url":"https://avatars3.githubusercontent.com/u/20363967?v=4","gravatar_id":"","url":"https://api.github.com/users/joinfaces","html_url":"https://github.com/joinfaces","followers_url":"https://api.github.com/users/joinfaces/followers","following_url":"https://api.github.com/users/joinfaces/following{/other_user}","gists_url":"https://api.github.com/users/joinfaces/gists{/gist_id}","starred_url":"https://api.github.com/users/joinfaces/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joinfaces/subscriptions","organizations_url":"https://api.github.com/users/joinfaces/orgs","repos_url":"https://api.github.com/users/joinfaces/repos","events_url":"https://api.github.com/users/joinfaces/events{/privacy}","received_events_url":"https://api.github.com/users/joinfaces/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/joinfaces/joinfaces","description":"JoinFaces: JSF Spring Boot Starters - JSF inside Spring Boot Application","fork":false,"url":"https://api.github.com/repos/joinfaces/joinfaces","forks_url":"https://api.github.com/repos/joinfaces/joinfaces/forks","keys_url":"https://api.github.com/repos/joinfaces/joinfaces/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joinfaces/joinfaces/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joinfaces/joinfaces/teams","hooks_url":"https://api.github.com/repos/joinfaces/joinfaces/hooks","issue_events_url":"https://api.github.com/repos/joinfaces/joinfaces/issues/events{/number}","events_url":"https://api.github.com/repos/joinfaces/joinfaces/events","assignees_url":"https://api.github.com/repos/joinfaces/joinfaces/assignees{/user}","branches_url":"https://api.github.com/repos/joinfaces/joinfaces/branches{/branch}","tags_url":"https://api.github.com/repos/joinfaces/joinfaces/tags","blobs_url":"https://api.github.com/repos/joinfaces/joinfaces/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joinfaces/joinfaces/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joinfaces/joinfaces/git/refs{/sha}","trees_url":"https://api.github.com/repos/joinfaces/joinfaces/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joinfaces/joinfaces/statuses/{sha}","languages_url":"https://api.github.com/repos/joinfaces/joinfaces/languages","stargazers_url":"https://api.github.com/repos/joinfaces/joinfaces/stargazers","contributors_url":"https://api.github.com/repos/joinfaces/joinfaces/contributors","subscribers_url":"https://api.github.com/repos/joinfaces/joinfaces/subscribers","subscription_url":"https://api.github.com/repos/joinfaces/joinfaces/subscription","commits_url":"https://api.github.com/repos/joinfaces/joinfaces/commits{/sha}","git_commits_url":"https://api.github.com/repos/joinfaces/joinfaces/git/commits{/sha}","comments_url":"https://api.github.com/repos/joinfaces/joinfaces/comments{/number}","issue_comment_url":"https://api.github.com/repos/joinfaces/joinfaces/issues/comments{/number}","contents_url":"https://api.github.com/repos/joinfaces/joinfaces/contents/{+path}","compare_url":"https://api.github.com/repos/joinfaces/joinfaces/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joinfaces/joinfaces/merges","archive_url":"https://api.github.com/repos/joinfaces/joinfaces/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joinfaces/joinfaces/downloads","issues_url":"https://api.github.com/repos/joinfaces/joinfaces/issues{/number}","pulls_url":"https://api.github.com/repos/joinfaces/joinfaces/pulls{/number}","milestones_url":"https://api.github.com/repos/joinfaces/joinfaces/milestones{/number}","notifications_url":"https://api.github.com/repos/joinfaces/joinfaces/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joinfaces/joinfaces/labels{/name}","releases_url":"https://api.github.com/repos/joinfaces/joinfaces/releases{/id}","deployments_url":"https://api.github.com/repos/joinfaces/joinfaces/deployments","created_at":"2016-04-29T17:27:00Z","updated_at":"2018-11-09T20:36:36Z","pushed_at":"2018-11-09T19:12:18Z","git_url":"git://github.com/joinfaces/joinfaces.git","ssh_url":"[email protected]:joinfaces/joinfaces.git","clone_url":"https://github.com/joinfaces/joinfaces.git","svn_url":"https://github.com/joinfaces/joinfaces","homepage":"http://joinfaces.org","size":3186,"stargazers_count":195,"watchers_count":195,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":55,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":55,"open_issues":7,"watchers":195,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/joinfaces/joinfaces/pulls/574"},"html":{"href":"https://github.com/joinfaces/joinfaces/pull/574"},"issue":{"href":"https://api.github.com/repos/joinfaces/joinfaces/issues/574"},"comments":{"href":"https://api.github.com/repos/joinfaces/joinfaces/issues/574/comments"},"review_comments":{"href":"https://api.github.com/repos/joinfaces/joinfaces/pulls/574/comments"},"review_comment":{"href":"https://api.github.com/repos/joinfaces/joinfaces/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/joinfaces/joinfaces/pulls/574/commits"},"statuses":{"href":"https://api.github.com/repos/joinfaces/joinfaces/statuses/1afbb7057dfa53dd7cc767c822180f923a4218b5"}},"author_association":"COLLABORATOR"}} | {
"id": 57401572,
"name": "joinfaces/joinfaces",
"url": "https://api.github.com/repos/joinfaces/joinfaces"
} | {
"id": 261952,
"login": "persapiens",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/261952?",
"url": "https://api.github.com/users/persapiens"
} | {
"id": 20363967,
"login": "joinfaces",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/20363967?",
"url": "https://api.github.com/orgs/joinfaces"
} | 2018-11-09T20:52:22 | 8565734672 | {"actor":{"display_login":"persapiens"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/Metatavu/tulistop-api/pulls/comments/234645664","pull_request_review_id":176330555,"id":234645664,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNDY0NTY2NA==","diff_hunk":"@@ -0,0 +1,236 @@\n+package fi.metatavu.tulistop.sites;\n+\n+import java.time.OffsetDateTime;\n+import java.util.Arrays;\n+import java.util.Collections;\n+import java.util.List;\n+import java.util.Set;\n+import java.util.UUID;\n+import java.util.stream.Collectors;\n+\n+import javax.enterprise.context.ApplicationScoped;\n+import javax.inject.Inject;\n+\n+import org.keycloak.representations.idm.authorization.DecisionStrategy;\n+import org.keycloak.representations.idm.authorization.Logic;\n+import org.keycloak.representations.idm.authorization.UserPolicyRepresentation;\n+import org.slf4j.Logger;\n+\n+import fi.metatavu.tulistop.keycloak.AuthorizationScope;\n+import fi.metatavu.tulistop.keycloak.KeycloakInternalApiController;\n+import fi.metatavu.tulistop.keycloak.ResourceType;\n+import fi.metatavu.tulistop.persistence.dao.SiteDAO;\n+import fi.metatavu.tulistop.persistence.model.Realm;\n+import fi.metatavu.tulistop.persistence.model.Site;\n+import fi.metatavu.tulistop.rest.LoginDetails;\n+import fi.metatavu.tulistop.rest.model.Site.StatusEnum;\n+import fi.metatavu.tulistop.rest.model.SiteUser.RoleEnum;\n+import fi.metatavu.tulistop.users.UsersController;\n+\n+/**\n+ * Controller for sites\n+ * \n+ * @author Antti Leppä\n+ */\n+@ApplicationScoped\n+public class SitesController {\n+\n+ private static final String SITE_URI_TEMPLATE = \"/v1/realms/%s/sites/%s\";\n+ private static final String SITE_NAME_TEMPLATE = \"site-%s\";\n+ private static final String SITE_ROLE_PERMISSION_NAME_TEMPLATE = \"site-%s-permission-%s\";\n+\n+ @Inject\n+ private Logger logger;\n+ \n+ @Inject\n+ private SiteDAO siteDAO;\n+ \n+ @Inject\n+ private KeycloakInternalApiController keycloakInternalApiController;\n+\n+ @Inject\n+ private UsersController usersController;\n+ \n+ /**\n+ * Creates new site\n+ * \n+ * @param loginDetails login details\n+ * @param address address\n+ * @param customer customer\n+ * @param status status\n+ * @param archivementDate archivement date\n+ * @param description description\n+ * @param officialsComment officials comment\n+ * @param operation operation id\n+ * @param creatorId creator id\n+ * @return created site\n+ */\n+ public Site createSite(LoginDetails loginDetails, Realm realm, String address, String customer, StatusEnum status, OffsetDateTime archivementDate, String description, String officialsComment, String operation, UUID creatorId) {\n+ Site site = siteDAO.create(UUID.randomUUID(), realm, address, customer, status, archivementDate, description, officialsComment, operation, creatorId, creatorId);\n+ UUID resourceId = keycloakInternalApiController.createProtectedResource(realm, getResourceName(site), getResourceUri(realm, site), ResourceType.SITE, Arrays.asList(AuthorizationScope.SITE_PLAN, AuthorizationScope.SITE_WORK));\n+ \n+ UserPolicyRepresentation creatorPolicy = usersController.findUserPolicy(realm, creatorId);\n+ List<UUID> creatorPolicyIds = creatorPolicy == null ? Collections.emptyList() : Arrays.asList(UUID.fromString(creatorPolicy.getId()));\n+ \n+ keycloakInternalApiController.upsertScopePermission(realm, resourceId, Arrays.asList(AuthorizationScope.SITE_WORK), getSiteRolePermissionName(site, RoleEnum.WORKER), DecisionStrategy.AFFIRMATIVE, Logic.POSITIVE, creatorPolicyIds);\n+ keycloakInternalApiController.upsertScopePermission(realm, resourceId, Arrays.asList(AuthorizationScope.SITE_PLAN), getSiteRolePermissionName(site, RoleEnum.PLANNER), DecisionStrategy.AFFIRMATIVE, Logic.POSITIVE, creatorPolicyIds);\n+\n+ return site;\n+ }\n+ \n+ /**\n+ * Grants access to user to a site\n+ * \n+ * @param loginDetails login details\n+ * @param site site\n+ * @param userRole role \n+ * @param userId user id\n+ */\n+ public void createSiteUser(LoginDetails loginDetails, Realm realm, Site site, RoleEnum userRole, UUID userId) {\n+ UserPolicyRepresentation policyId = usersController.findUserPolicy(realm, userId);\n+ if (policyId == null) {\n+ logger.error(\"Failed to resolve user {} policy\", userId);","path":"src/main/java/fi/metatavu/tulistop/sites/SitesController.java","position":92,"original_position":92,"commit_id":"bd481a94957084b4c2d53a49de101a72436b46be","original_commit_id":"bd481a94957084b4c2d53a49de101a72436b46be","user":{"login":"sonarcloud[bot]","id":39514782,"node_id":"MDM6Qm90Mzk1MTQ3ODI=","avatar_url":"https://avatars2.githubusercontent.com/in/12526?v=4","gravatar_id":"","url":"https://api.github.com/users/sonarcloud%5Bbot%5D","html_url":"https://github.com/apps/sonarcloud","followers_url":"https://api.github.com/users/sonarcloud%5Bbot%5D/followers","following_url":"https://api.github.com/users/sonarcloud%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/sonarcloud%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/sonarcloud%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sonarcloud%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/sonarcloud%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/sonarcloud%5Bbot%5D/repos","events_url":"https://api.github.com/users/sonarcloud%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/sonarcloud%5Bbot%5D/received_events","type":"Bot","site_admin":false},"body":" Code Smell: Define a constant instead of duplicating this literal \"Failed to resolve user {} policy\" 3 times. ([squid:S1192](https://sonarcloud.io/organizations/metatavu-oy/rules#rule_key=squid%3AS1192))\n\n[See it in SonarCloud](https://sonarcloud.io/project/issues?id=fi.metatavu.tulistop%3Atulistop-api&pullRequest=5&issues=AWcsaRWZH5xombRgQkLS&open=AWcsaRWZH5xombRgQkLS)\n\n[ISSUE_KEY]: AWcsaRWZH5xombRgQkLS","created_at":"2018-11-19T14:48:39Z","updated_at":"2018-11-19T14:48:41Z","html_url":"https://github.com/Metatavu/tulistop-api/pull/5#discussion_r234645664","pull_request_url":"https://api.github.com/repos/Metatavu/tulistop-api/pulls/5","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/Metatavu/tulistop-api/pulls/comments/234645664"},"html":{"href":"https://github.com/Metatavu/tulistop-api/pull/5#discussion_r234645664"},"pull_request":{"href":"https://api.github.com/repos/Metatavu/tulistop-api/pulls/5"}}},"pull_request":{"url":"https://api.github.com/repos/Metatavu/tulistop-api/pulls/5","id":231855217,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxODU1MjE3","html_url":"https://github.com/Metatavu/tulistop-api/pull/5","diff_url":"https://github.com/Metatavu/tulistop-api/pull/5.diff","patch_url":"https://github.com/Metatavu/tulistop-api/pull/5.patch","issue_url":"https://api.github.com/repos/Metatavu/tulistop-api/issues/5","number":5,"state":"open","locked":false,"title":"Feature 3 bootstrap authz","user":{"login":"anttileppa","id":1730736,"node_id":"MDQ6VXNlcjE3MzA3MzY=","avatar_url":"https://avatars3.githubusercontent.com/u/1730736?v=4","gravatar_id":"","url":"https://api.github.com/users/anttileppa","html_url":"https://github.com/anttileppa","followers_url":"https://api.github.com/users/anttileppa/followers","following_url":"https://api.github.com/users/anttileppa/following{/other_user}","gists_url":"https://api.github.com/users/anttileppa/gists{/gist_id}","starred_url":"https://api.github.com/users/anttileppa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anttileppa/subscriptions","organizations_url":"https://api.github.com/users/anttileppa/orgs","repos_url":"https://api.github.com/users/anttileppa/repos","events_url":"https://api.github.com/users/anttileppa/events{/privacy}","received_events_url":"https://api.github.com/users/anttileppa/received_events","type":"User","site_admin":false},"body":"Resolves #3 ","created_at":"2018-11-19T05:10:20Z","updated_at":"2018-11-19T14:48:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"89c7329bcce20d6c5577fd72efd358384b74316d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Metatavu/tulistop-api/pulls/5/commits","review_comments_url":"https://api.github.com/repos/Metatavu/tulistop-api/pulls/5/comments","review_comment_url":"https://api.github.com/repos/Metatavu/tulistop-api/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Metatavu/tulistop-api/issues/5/comments","statuses_url":"https://api.github.com/repos/Metatavu/tulistop-api/statuses/bd481a94957084b4c2d53a49de101a72436b46be","head":{"label":"Metatavu:feature-3-bootstrap-authz","ref":"feature-3-bootstrap-authz","sha":"bd481a94957084b4c2d53a49de101a72436b46be","user":{"login":"Metatavu","id":20443466,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNDQzNDY2","avatar_url":"https://avatars0.githubusercontent.com/u/20443466?v=4","gravatar_id":"","url":"https://api.github.com/users/Metatavu","html_url":"https://github.com/Metatavu","followers_url":"https://api.github.com/users/Metatavu/followers","following_url":"https://api.github.com/users/Metatavu/following{/other_user}","gists_url":"https://api.github.com/users/Metatavu/gists{/gist_id}","starred_url":"https://api.github.com/users/Metatavu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Metatavu/subscriptions","organizations_url":"https://api.github.com/users/Metatavu/orgs","repos_url":"https://api.github.com/users/Metatavu/repos","events_url":"https://api.github.com/users/Metatavu/events{/privacy}","received_events_url":"https://api.github.com/users/Metatavu/received_events","type":"Organization","site_admin":false},"repo":{"id":156186449,"node_id":"MDEwOlJlcG9zaXRvcnkxNTYxODY0NDk=","name":"tulistop-api","full_name":"Metatavu/tulistop-api","private":false,"owner":{"login":"Metatavu","id":20443466,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNDQzNDY2","avatar_url":"https://avatars0.githubusercontent.com/u/20443466?v=4","gravatar_id":"","url":"https://api.github.com/users/Metatavu","html_url":"https://github.com/Metatavu","followers_url":"https://api.github.com/users/Metatavu/followers","following_url":"https://api.github.com/users/Metatavu/following{/other_user}","gists_url":"https://api.github.com/users/Metatavu/gists{/gist_id}","starred_url":"https://api.github.com/users/Metatavu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Metatavu/subscriptions","organizations_url":"https://api.github.com/users/Metatavu/orgs","repos_url":"https://api.github.com/users/Metatavu/repos","events_url":"https://api.github.com/users/Metatavu/events{/privacy}","received_events_url":"https://api.github.com/users/Metatavu/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Metatavu/tulistop-api","description":null,"fork":false,"url":"https://api.github.com/repos/Metatavu/tulistop-api","forks_url":"https://api.github.com/repos/Metatavu/tulistop-api/forks","keys_url":"https://api.github.com/repos/Metatavu/tulistop-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Metatavu/tulistop-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Metatavu/tulistop-api/teams","hooks_url":"https://api.github.com/repos/Metatavu/tulistop-api/hooks","issue_events_url":"https://api.github.com/repos/Metatavu/tulistop-api/issues/events{/number}","events_url":"https://api.github.com/repos/Metatavu/tulistop-api/events","assignees_url":"https://api.github.com/repos/Metatavu/tulistop-api/assignees{/user}","branches_url":"https://api.github.com/repos/Metatavu/tulistop-api/branches{/branch}","tags_url":"https://api.github.com/repos/Metatavu/tulistop-api/tags","blobs_url":"https://api.github.com/repos/Metatavu/tulistop-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Metatavu/tulistop-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Metatavu/tulistop-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/Metatavu/tulistop-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Metatavu/tulistop-api/statuses/{sha}","languages_url":"https://api.github.com/repos/Metatavu/tulistop-api/languages","stargazers_url":"https://api.github.com/repos/Metatavu/tulistop-api/stargazers","contributors_url":"https://api.github.com/repos/Metatavu/tulistop-api/contributors","subscribers_url":"https://api.github.com/repos/Metatavu/tulistop-api/subscribers","subscription_url":"https://api.github.com/repos/Metatavu/tulistop-api/subscription","commits_url":"https://api.github.com/repos/Metatavu/tulistop-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/Metatavu/tulistop-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/Metatavu/tulistop-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/Metatavu/tulistop-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/Metatavu/tulistop-api/contents/{+path}","compare_url":"https://api.github.com/repos/Metatavu/tulistop-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Metatavu/tulistop-api/merges","archive_url":"https://api.github.com/repos/Metatavu/tulistop-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Metatavu/tulistop-api/downloads","issues_url":"https://api.github.com/repos/Metatavu/tulistop-api/issues{/number}","pulls_url":"https://api.github.com/repos/Metatavu/tulistop-api/pulls{/number}","milestones_url":"https://api.github.com/repos/Metatavu/tulistop-api/milestones{/number}","notifications_url":"https://api.github.com/repos/Metatavu/tulistop-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Metatavu/tulistop-api/labels{/name}","releases_url":"https://api.github.com/repos/Metatavu/tulistop-api/releases{/id}","deployments_url":"https://api.github.com/repos/Metatavu/tulistop-api/deployments","created_at":"2018-11-05T08:45:29Z","updated_at":"2018-11-19T04:49:58Z","pushed_at":"2018-11-19T14:37:44Z","git_url":"git://github.com/Metatavu/tulistop-api.git","ssh_url":"[email protected]:Metatavu/tulistop-api.git","clone_url":"https://github.com/Metatavu/tulistop-api.git","svn_url":"https://github.com/Metatavu/tulistop-api","homepage":null,"size":293,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":0,"open_issues":2,"watchers":0,"default_branch":"develop"}},"base":{"label":"Metatavu:develop","ref":"develop","sha":"03452917324dd9a95310f3106bd1ab76abdc7940","user":{"login":"Metatavu","id":20443466,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNDQzNDY2","avatar_url":"https://avatars0.githubusercontent.com/u/20443466?v=4","gravatar_id":"","url":"https://api.github.com/users/Metatavu","html_url":"https://github.com/Metatavu","followers_url":"https://api.github.com/users/Metatavu/followers","following_url":"https://api.github.com/users/Metatavu/following{/other_user}","gists_url":"https://api.github.com/users/Metatavu/gists{/gist_id}","starred_url":"https://api.github.com/users/Metatavu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Metatavu/subscriptions","organizations_url":"https://api.github.com/users/Metatavu/orgs","repos_url":"https://api.github.com/users/Metatavu/repos","events_url":"https://api.github.com/users/Metatavu/events{/privacy}","received_events_url":"https://api.github.com/users/Metatavu/received_events","type":"Organization","site_admin":false},"repo":{"id":156186449,"node_id":"MDEwOlJlcG9zaXRvcnkxNTYxODY0NDk=","name":"tulistop-api","full_name":"Metatavu/tulistop-api","private":false,"owner":{"login":"Metatavu","id":20443466,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNDQzNDY2","avatar_url":"https://avatars0.githubusercontent.com/u/20443466?v=4","gravatar_id":"","url":"https://api.github.com/users/Metatavu","html_url":"https://github.com/Metatavu","followers_url":"https://api.github.com/users/Metatavu/followers","following_url":"https://api.github.com/users/Metatavu/following{/other_user}","gists_url":"https://api.github.com/users/Metatavu/gists{/gist_id}","starred_url":"https://api.github.com/users/Metatavu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Metatavu/subscriptions","organizations_url":"https://api.github.com/users/Metatavu/orgs","repos_url":"https://api.github.com/users/Metatavu/repos","events_url":"https://api.github.com/users/Metatavu/events{/privacy}","received_events_url":"https://api.github.com/users/Metatavu/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Metatavu/tulistop-api","description":null,"fork":false,"url":"https://api.github.com/repos/Metatavu/tulistop-api","forks_url":"https://api.github.com/repos/Metatavu/tulistop-api/forks","keys_url":"https://api.github.com/repos/Metatavu/tulistop-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Metatavu/tulistop-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Metatavu/tulistop-api/teams","hooks_url":"https://api.github.com/repos/Metatavu/tulistop-api/hooks","issue_events_url":"https://api.github.com/repos/Metatavu/tulistop-api/issues/events{/number}","events_url":"https://api.github.com/repos/Metatavu/tulistop-api/events","assignees_url":"https://api.github.com/repos/Metatavu/tulistop-api/assignees{/user}","branches_url":"https://api.github.com/repos/Metatavu/tulistop-api/branches{/branch}","tags_url":"https://api.github.com/repos/Metatavu/tulistop-api/tags","blobs_url":"https://api.github.com/repos/Metatavu/tulistop-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Metatavu/tulistop-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Metatavu/tulistop-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/Metatavu/tulistop-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Metatavu/tulistop-api/statuses/{sha}","languages_url":"https://api.github.com/repos/Metatavu/tulistop-api/languages","stargazers_url":"https://api.github.com/repos/Metatavu/tulistop-api/stargazers","contributors_url":"https://api.github.com/repos/Metatavu/tulistop-api/contributors","subscribers_url":"https://api.github.com/repos/Metatavu/tulistop-api/subscribers","subscription_url":"https://api.github.com/repos/Metatavu/tulistop-api/subscription","commits_url":"https://api.github.com/repos/Metatavu/tulistop-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/Metatavu/tulistop-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/Metatavu/tulistop-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/Metatavu/tulistop-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/Metatavu/tulistop-api/contents/{+path}","compare_url":"https://api.github.com/repos/Metatavu/tulistop-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Metatavu/tulistop-api/merges","archive_url":"https://api.github.com/repos/Metatavu/tulistop-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Metatavu/tulistop-api/downloads","issues_url":"https://api.github.com/repos/Metatavu/tulistop-api/issues{/number}","pulls_url":"https://api.github.com/repos/Metatavu/tulistop-api/pulls{/number}","milestones_url":"https://api.github.com/repos/Metatavu/tulistop-api/milestones{/number}","notifications_url":"https://api.github.com/repos/Metatavu/tulistop-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Metatavu/tulistop-api/labels{/name}","releases_url":"https://api.github.com/repos/Metatavu/tulistop-api/releases{/id}","deployments_url":"https://api.github.com/repos/Metatavu/tulistop-api/deployments","created_at":"2018-11-05T08:45:29Z","updated_at":"2018-11-19T04:49:58Z","pushed_at":"2018-11-19T14:37:44Z","git_url":"git://github.com/Metatavu/tulistop-api.git","ssh_url":"[email protected]:Metatavu/tulistop-api.git","clone_url":"https://github.com/Metatavu/tulistop-api.git","svn_url":"https://github.com/Metatavu/tulistop-api","homepage":null,"size":293,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":0,"open_issues":2,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/Metatavu/tulistop-api/pulls/5"},"html":{"href":"https://github.com/Metatavu/tulistop-api/pull/5"},"issue":{"href":"https://api.github.com/repos/Metatavu/tulistop-api/issues/5"},"comments":{"href":"https://api.github.com/repos/Metatavu/tulistop-api/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/Metatavu/tulistop-api/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/Metatavu/tulistop-api/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Metatavu/tulistop-api/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/Metatavu/tulistop-api/statuses/bd481a94957084b4c2d53a49de101a72436b46be"}},"author_association":"NONE"}} | {
"id": 156186449,
"name": "Metatavu/tulistop-api",
"url": "https://api.github.com/repos/Metatavu/tulistop-api"
} | {
"id": 39514782,
"login": "sonarcloud[bot]",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/39514782?",
"url": "https://api.github.com/users/sonarcloud[bot]"
} | {
"id": 20443466,
"login": "Metatavu",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/20443466?",
"url": "https://api.github.com/orgs/Metatavu"
} | 2018-11-19T14:48:39 | 8613329765 | {"actor":{"display_login":"sonarcloud"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/assembl/assembl/pulls/comments/191206956","pull_request_review_id":123735710,"id":191206956,"diff_hunk":"@@ -0,0 +1,21 @@\n+.multicolumn-admin {\n+ .admin-export-section {\n+ .admin-content {\n+ text-align: center;\n+\n+ .form-group {\n+ text-align: left;\n+ display: inline-block;\n+\n+ .export-language-dropdown {\n+ margin-top: 20px;\n+ position: absolute;","path":"assembl/static2/css/components/multiColumnAdmin.scss","position":12,"original_position":12,"commit_id":"86f55b12ed42c15c11df7e82eff38e0249c858ba","original_commit_id":"86f55b12ed42c15c11df7e82eff38e0249c858ba","user":{"login":"ayyazdaniaryan","id":1242841,"avatar_url":"https://avatars2.githubusercontent.com/u/1242841?v=4","gravatar_id":"","url":"https://api.github.com/users/ayyazdaniaryan","html_url":"https://github.com/ayyazdaniaryan","followers_url":"https://api.github.com/users/ayyazdaniaryan/followers","following_url":"https://api.github.com/users/ayyazdaniaryan/following{/other_user}","gists_url":"https://api.github.com/users/ayyazdaniaryan/gists{/gist_id}","starred_url":"https://api.github.com/users/ayyazdaniaryan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ayyazdaniaryan/subscriptions","organizations_url":"https://api.github.com/users/ayyazdaniaryan/orgs","repos_url":"https://api.github.com/users/ayyazdaniaryan/repos","events_url":"https://api.github.com/users/ayyazdaniaryan/events{/privacy}","received_events_url":"https://api.github.com/users/ayyazdaniaryan/received_events","type":"User","site_admin":false},"body":"Oh yea! There is no mobile admin section! Okay, then keep this. Good call.","created_at":"2018-05-28T13:29:04Z","updated_at":"2018-05-28T13:29:05Z","html_url":"https://github.com/assembl/assembl/pull/432#discussion_r191206956","pull_request_url":"https://api.github.com/repos/assembl/assembl/pulls/432","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/assembl/assembl/pulls/comments/191206956"},"html":{"href":"https://github.com/assembl/assembl/pull/432#discussion_r191206956"},"pull_request":{"href":"https://api.github.com/repos/assembl/assembl/pulls/432"}},"in_reply_to_id":191201376},"pull_request":{"url":"https://api.github.com/repos/assembl/assembl/pulls/432","id":189003829,"html_url":"https://github.com/assembl/assembl/pull/432","diff_url":"https://github.com/assembl/assembl/pull/432.diff","patch_url":"https://github.com/assembl/assembl/pull/432.patch","issue_url":"https://api.github.com/repos/assembl/assembl/issues/432","number":432,"state":"open","locked":false,"title":"create page for thread and multicolumn extract","user":{"login":"MilanBarande","id":25273007,"avatar_url":"https://avatars2.githubusercontent.com/u/25273007?v=4","gravatar_id":"","url":"https://api.github.com/users/MilanBarande","html_url":"https://github.com/MilanBarande","followers_url":"https://api.github.com/users/MilanBarande/followers","following_url":"https://api.github.com/users/MilanBarande/following{/other_user}","gists_url":"https://api.github.com/users/MilanBarande/gists{/gist_id}","starred_url":"https://api.github.com/users/MilanBarande/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MilanBarande/subscriptions","organizations_url":"https://api.github.com/users/MilanBarande/orgs","repos_url":"https://api.github.com/users/MilanBarande/repos","events_url":"https://api.github.com/users/MilanBarande/events{/privacy}","received_events_url":"https://api.github.com/users/MilanBarande/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-05-18T11:56:28Z","updated_at":"2018-05-28T13:29:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"15b5f64cb60748809765ae8dba18c303b6263e29","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/assembl/assembl/pulls/432/commits","review_comments_url":"https://api.github.com/repos/assembl/assembl/pulls/432/comments","review_comment_url":"https://api.github.com/repos/assembl/assembl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/assembl/assembl/issues/432/comments","statuses_url":"https://api.github.com/repos/assembl/assembl/statuses/86f55b12ed42c15c11df7e82eff38e0249c858ba","head":{"label":"assembl:thread-multicolumn-extraction-page","ref":"thread-multicolumn-extraction-page","sha":"86f55b12ed42c15c11df7e82eff38e0249c858ba","user":{"login":"assembl","id":20449542,"avatar_url":"https://avatars3.githubusercontent.com/u/20449542?v=4","gravatar_id":"","url":"https://api.github.com/users/assembl","html_url":"https://github.com/assembl","followers_url":"https://api.github.com/users/assembl/followers","following_url":"https://api.github.com/users/assembl/following{/other_user}","gists_url":"https://api.github.com/users/assembl/gists{/gist_id}","starred_url":"https://api.github.com/users/assembl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/assembl/subscriptions","organizations_url":"https://api.github.com/users/assembl/orgs","repos_url":"https://api.github.com/users/assembl/repos","events_url":"https://api.github.com/users/assembl/events{/privacy}","received_events_url":"https://api.github.com/users/assembl/received_events","type":"Organization","site_admin":false},"repo":{"id":18962634,"name":"assembl","full_name":"assembl/assembl","owner":{"login":"assembl","id":20449542,"avatar_url":"https://avatars3.githubusercontent.com/u/20449542?v=4","gravatar_id":"","url":"https://api.github.com/users/assembl","html_url":"https://github.com/assembl","followers_url":"https://api.github.com/users/assembl/followers","following_url":"https://api.github.com/users/assembl/following{/other_user}","gists_url":"https://api.github.com/users/assembl/gists{/gist_id}","starred_url":"https://api.github.com/users/assembl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/assembl/subscriptions","organizations_url":"https://api.github.com/users/assembl/orgs","repos_url":"https://api.github.com/users/assembl/repos","events_url":"https://api.github.com/users/assembl/events{/privacy}","received_events_url":"https://api.github.com/users/assembl/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/assembl/assembl","description":"Assembl is an online debate and synthesis platform","fork":false,"url":"https://api.github.com/repos/assembl/assembl","forks_url":"https://api.github.com/repos/assembl/assembl/forks","keys_url":"https://api.github.com/repos/assembl/assembl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/assembl/assembl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/assembl/assembl/teams","hooks_url":"https://api.github.com/repos/assembl/assembl/hooks","issue_events_url":"https://api.github.com/repos/assembl/assembl/issues/events{/number}","events_url":"https://api.github.com/repos/assembl/assembl/events","assignees_url":"https://api.github.com/repos/assembl/assembl/assignees{/user}","branches_url":"https://api.github.com/repos/assembl/assembl/branches{/branch}","tags_url":"https://api.github.com/repos/assembl/assembl/tags","blobs_url":"https://api.github.com/repos/assembl/assembl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/assembl/assembl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/assembl/assembl/git/refs{/sha}","trees_url":"https://api.github.com/repos/assembl/assembl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/assembl/assembl/statuses/{sha}","languages_url":"https://api.github.com/repos/assembl/assembl/languages","stargazers_url":"https://api.github.com/repos/assembl/assembl/stargazers","contributors_url":"https://api.github.com/repos/assembl/assembl/contributors","subscribers_url":"https://api.github.com/repos/assembl/assembl/subscribers","subscription_url":"https://api.github.com/repos/assembl/assembl/subscription","commits_url":"https://api.github.com/repos/assembl/assembl/commits{/sha}","git_commits_url":"https://api.github.com/repos/assembl/assembl/git/commits{/sha}","comments_url":"https://api.github.com/repos/assembl/assembl/comments{/number}","issue_comment_url":"https://api.github.com/repos/assembl/assembl/issues/comments{/number}","contents_url":"https://api.github.com/repos/assembl/assembl/contents/{+path}","compare_url":"https://api.github.com/repos/assembl/assembl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/assembl/assembl/merges","archive_url":"https://api.github.com/repos/assembl/assembl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/assembl/assembl/downloads","issues_url":"https://api.github.com/repos/assembl/assembl/issues{/number}","pulls_url":"https://api.github.com/repos/assembl/assembl/pulls{/number}","milestones_url":"https://api.github.com/repos/assembl/assembl/milestones{/number}","notifications_url":"https://api.github.com/repos/assembl/assembl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/assembl/assembl/labels{/name}","releases_url":"https://api.github.com/repos/assembl/assembl/releases{/id}","deployments_url":"https://api.github.com/repos/assembl/assembl/deployments","created_at":"2014-04-20T10:52:11Z","updated_at":"2018-05-28T09:55:15Z","pushed_at":"2018-05-28T12:51:53Z","git_url":"git://github.com/assembl/assembl.git","ssh_url":"[email protected]:assembl/assembl.git","clone_url":"https://github.com/assembl/assembl.git","svn_url":"https://github.com/assembl/assembl","homepage":"http://assembl.bluenove.com","size":72673,"stargazers_count":83,"watchers_count":83,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":28,"mirror_url":null,"archived":false,"open_issues_count":21,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":28,"open_issues":21,"watchers":83,"default_branch":"develop"}},"base":{"label":"assembl:develop","ref":"develop","sha":"20eb65b95830675b41dc1292e213e312d1fabe3d","user":{"login":"assembl","id":20449542,"avatar_url":"https://avatars3.githubusercontent.com/u/20449542?v=4","gravatar_id":"","url":"https://api.github.com/users/assembl","html_url":"https://github.com/assembl","followers_url":"https://api.github.com/users/assembl/followers","following_url":"https://api.github.com/users/assembl/following{/other_user}","gists_url":"https://api.github.com/users/assembl/gists{/gist_id}","starred_url":"https://api.github.com/users/assembl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/assembl/subscriptions","organizations_url":"https://api.github.com/users/assembl/orgs","repos_url":"https://api.github.com/users/assembl/repos","events_url":"https://api.github.com/users/assembl/events{/privacy}","received_events_url":"https://api.github.com/users/assembl/received_events","type":"Organization","site_admin":false},"repo":{"id":18962634,"name":"assembl","full_name":"assembl/assembl","owner":{"login":"assembl","id":20449542,"avatar_url":"https://avatars3.githubusercontent.com/u/20449542?v=4","gravatar_id":"","url":"https://api.github.com/users/assembl","html_url":"https://github.com/assembl","followers_url":"https://api.github.com/users/assembl/followers","following_url":"https://api.github.com/users/assembl/following{/other_user}","gists_url":"https://api.github.com/users/assembl/gists{/gist_id}","starred_url":"https://api.github.com/users/assembl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/assembl/subscriptions","organizations_url":"https://api.github.com/users/assembl/orgs","repos_url":"https://api.github.com/users/assembl/repos","events_url":"https://api.github.com/users/assembl/events{/privacy}","received_events_url":"https://api.github.com/users/assembl/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/assembl/assembl","description":"Assembl is an online debate and synthesis platform","fork":false,"url":"https://api.github.com/repos/assembl/assembl","forks_url":"https://api.github.com/repos/assembl/assembl/forks","keys_url":"https://api.github.com/repos/assembl/assembl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/assembl/assembl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/assembl/assembl/teams","hooks_url":"https://api.github.com/repos/assembl/assembl/hooks","issue_events_url":"https://api.github.com/repos/assembl/assembl/issues/events{/number}","events_url":"https://api.github.com/repos/assembl/assembl/events","assignees_url":"https://api.github.com/repos/assembl/assembl/assignees{/user}","branches_url":"https://api.github.com/repos/assembl/assembl/branches{/branch}","tags_url":"https://api.github.com/repos/assembl/assembl/tags","blobs_url":"https://api.github.com/repos/assembl/assembl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/assembl/assembl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/assembl/assembl/git/refs{/sha}","trees_url":"https://api.github.com/repos/assembl/assembl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/assembl/assembl/statuses/{sha}","languages_url":"https://api.github.com/repos/assembl/assembl/languages","stargazers_url":"https://api.github.com/repos/assembl/assembl/stargazers","contributors_url":"https://api.github.com/repos/assembl/assembl/contributors","subscribers_url":"https://api.github.com/repos/assembl/assembl/subscribers","subscription_url":"https://api.github.com/repos/assembl/assembl/subscription","commits_url":"https://api.github.com/repos/assembl/assembl/commits{/sha}","git_commits_url":"https://api.github.com/repos/assembl/assembl/git/commits{/sha}","comments_url":"https://api.github.com/repos/assembl/assembl/comments{/number}","issue_comment_url":"https://api.github.com/repos/assembl/assembl/issues/comments{/number}","contents_url":"https://api.github.com/repos/assembl/assembl/contents/{+path}","compare_url":"https://api.github.com/repos/assembl/assembl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/assembl/assembl/merges","archive_url":"https://api.github.com/repos/assembl/assembl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/assembl/assembl/downloads","issues_url":"https://api.github.com/repos/assembl/assembl/issues{/number}","pulls_url":"https://api.github.com/repos/assembl/assembl/pulls{/number}","milestones_url":"https://api.github.com/repos/assembl/assembl/milestones{/number}","notifications_url":"https://api.github.com/repos/assembl/assembl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/assembl/assembl/labels{/name}","releases_url":"https://api.github.com/repos/assembl/assembl/releases{/id}","deployments_url":"https://api.github.com/repos/assembl/assembl/deployments","created_at":"2014-04-20T10:52:11Z","updated_at":"2018-05-28T09:55:15Z","pushed_at":"2018-05-28T12:51:53Z","git_url":"git://github.com/assembl/assembl.git","ssh_url":"[email protected]:assembl/assembl.git","clone_url":"https://github.com/assembl/assembl.git","svn_url":"https://github.com/assembl/assembl","homepage":"http://assembl.bluenove.com","size":72673,"stargazers_count":83,"watchers_count":83,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":28,"mirror_url":null,"archived":false,"open_issues_count":21,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":28,"open_issues":21,"watchers":83,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/assembl/assembl/pulls/432"},"html":{"href":"https://github.com/assembl/assembl/pull/432"},"issue":{"href":"https://api.github.com/repos/assembl/assembl/issues/432"},"comments":{"href":"https://api.github.com/repos/assembl/assembl/issues/432/comments"},"review_comments":{"href":"https://api.github.com/repos/assembl/assembl/pulls/432/comments"},"review_comment":{"href":"https://api.github.com/repos/assembl/assembl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/assembl/assembl/pulls/432/commits"},"statuses":{"href":"https://api.github.com/repos/assembl/assembl/statuses/86f55b12ed42c15c11df7e82eff38e0249c858ba"}},"author_association":"CONTRIBUTOR"}} | {
"id": 18962634,
"name": "assembl/assembl",
"url": "https://api.github.com/repos/assembl/assembl"
} | {
"id": 1242841,
"login": "ayyazdaniaryan",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1242841?",
"url": "https://api.github.com/users/ayyazdaniaryan"
} | {
"id": 20449542,
"login": "assembl",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/20449542?",
"url": "https://api.github.com/orgs/assembl"
} | 2018-05-28T13:29:04 | 7738820124 | {"actor":{"display_login":"ayyazdaniaryan"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/SolaceSamples/solace-samples-cloudfoundry-java/pulls/comments/181848122","pull_request_review_id":112543392,"id":181848122,"diff_hunk":"@@ -68,11 +68,11 @@\n \t// This bean is for information only, it can be used to discover more about\n \t// the solace service in use.\n \t@Autowired\n-\tprivate SolaceMessagingInfo solaceMessagingInfo;\n+\tprivate SolaceServiceCredentials solaceMessagingInfo;","path":"spring-cloud-autoconf-jndi/src/main/java/com/solace/samples/cloudfoundry/springcloud/controller/SolaceController.java","position":33,"original_position":33,"commit_id":"faa48637f0d386dab03e19dea2217f1794dacc79","original_commit_id":"faa48637f0d386dab03e19dea2217f1794dacc79","user":{"login":"mdspielman","id":1561721,"avatar_url":"https://avatars2.githubusercontent.com/u/1561721?v=4","gravatar_id":"","url":"https://api.github.com/users/mdspielman","html_url":"https://github.com/mdspielman","followers_url":"https://api.github.com/users/mdspielman/followers","following_url":"https://api.github.com/users/mdspielman/following{/other_user}","gists_url":"https://api.github.com/users/mdspielman/gists{/gist_id}","starred_url":"https://api.github.com/users/mdspielman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdspielman/subscriptions","organizations_url":"https://api.github.com/users/mdspielman/orgs","repos_url":"https://api.github.com/users/mdspielman/repos","events_url":"https://api.github.com/users/mdspielman/events{/privacy}","received_events_url":"https://api.github.com/users/mdspielman/received_events","type":"User","site_admin":false},"body":"Needs update.","created_at":"2018-04-16T18:52:52Z","updated_at":"2018-04-16T19:00:30Z","html_url":"https://github.com/SolaceSamples/solace-samples-cloudfoundry-java/pull/36#discussion_r181848122","pull_request_url":"https://api.github.com/repos/SolaceSamples/solace-samples-cloudfoundry-java/pulls/36","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/SolaceSamples/solace-samples-cloudfoundry-java/pulls/comments/181848122"},"html":{"href":"https://github.com/SolaceSamples/solace-samples-cloudfoundry-java/pull/36#discussion_r181848122"},"pull_request":{"href":"https://api.github.com/repos/SolaceSamples/solace-samples-cloudfoundry-java/pulls/36"}}},"pull_request":{"url":"https://api.github.com/repos/SolaceSamples/solace-samples-cloudfoundry-java/pulls/36","id":181229944,"html_url":"https://github.com/SolaceSamples/solace-samples-cloudfoundry-java/pull/36","diff_url":"https://github.com/SolaceSamples/solace-samples-cloudfoundry-java/pull/36.diff","patch_url":"https://github.com/SolaceSamples/solace-samples-cloudfoundry-java/pull/36.patch","issue_url":"https://api.github.com/repos/SolaceSamples/solace-samples-cloudfoundry-java/issues/36","number":36,"state":"open","locked":false,"title":"Update Solace Cloud Foundry Spring Cloud Connector and JCSMP/JMS autoconfigure dependencies","user":{"login":"Nephery","id":11084623,"avatar_url":"https://avatars0.githubusercontent.com/u/11084623?v=4","gravatar_id":"","url":"https://api.github.com/users/Nephery","html_url":"https://github.com/Nephery","followers_url":"https://api.github.com/users/Nephery/followers","following_url":"https://api.github.com/users/Nephery/following{/other_user}","gists_url":"https://api.github.com/users/Nephery/gists{/gist_id}","starred_url":"https://api.github.com/users/Nephery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nephery/subscriptions","organizations_url":"https://api.github.com/users/Nephery/orgs","repos_url":"https://api.github.com/users/Nephery/repos","events_url":"https://api.github.com/users/Nephery/events{/privacy}","received_events_url":"https://api.github.com/users/Nephery/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-04-12T14:51:35Z","updated_at":"2018-04-16T19:00:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"679ff4b6c55f606637b412422c1aa3695bc226ef","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/SolaceSamples/solace-samples-cloudfoundry-java/pulls/36/commits","review_comments_url":"https://api.github.com/repos/SolaceSamples/solace-samples-cloudfoundry-java/pulls/36/comments","review_comment_url":"https://api.github.com/repos/SolaceSamples/solace-samples-cloudfoundry-java/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SolaceSamples/solace-samples-cloudfoundry-java/issues/36/comments","statuses_url":"https://api.github.com/repos/SolaceSamples/solace-samples-cloudfoundry-java/statuses/faa48637f0d386dab03e19dea2217f1794dacc79","head":{"label":"SolaceDev:update-spring-boot-dependencies","ref":"update-spring-boot-dependencies","sha":"faa48637f0d386dab03e19dea2217f1794dacc79","user":{"login":"SolaceDev","id":20047150,"avatar_url":"https://avatars1.githubusercontent.com/u/20047150?v=4","gravatar_id":"","url":"https://api.github.com/users/SolaceDev","html_url":"https://github.com/SolaceDev","followers_url":"https://api.github.com/users/SolaceDev/followers","following_url":"https://api.github.com/users/SolaceDev/following{/other_user}","gists_url":"https://api.github.com/users/SolaceDev/gists{/gist_id}","starred_url":"https://api.github.com/users/SolaceDev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SolaceDev/subscriptions","organizations_url":"https://api.github.com/users/SolaceDev/orgs","repos_url":"https://api.github.com/users/SolaceDev/repos","events_url":"https://api.github.com/users/SolaceDev/events{/privacy}","received_events_url":"https://api.github.com/users/SolaceDev/received_events","type":"Organization","site_admin":false},"repo":{"id":109283270,"name":"solace-samples-cloudfoundry-java","full_name":"SolaceDev/solace-samples-cloudfoundry-java","owner":{"login":"SolaceDev","id":20047150,"avatar_url":"https://avatars1.githubusercontent.com/u/20047150?v=4","gravatar_id":"","url":"https://api.github.com/users/SolaceDev","html_url":"https://github.com/SolaceDev","followers_url":"https://api.github.com/users/SolaceDev/followers","following_url":"https://api.github.com/users/SolaceDev/following{/other_user}","gists_url":"https://api.github.com/users/SolaceDev/gists{/gist_id}","starred_url":"https://api.github.com/users/SolaceDev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SolaceDev/subscriptions","organizations_url":"https://api.github.com/users/SolaceDev/orgs","repos_url":"https://api.github.com/users/SolaceDev/repos","events_url":"https://api.github.com/users/SolaceDev/events{/privacy}","received_events_url":"https://api.github.com/users/SolaceDev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SolaceDev/solace-samples-cloudfoundry-java","description":"Samples showing how to connect and exchange messages with Solace Messaging for Pivotal Cloud Foundry.","fork":true,"url":"https://api.github.com/repos/SolaceDev/solace-samples-cloudfoundry-java","forks_url":"https://api.github.com/repos/SolaceDev/solace-samples-cloudfoundry-java/forks","keys_url":"https://api.github.com/repos/SolaceDev/solace-samples-cloudfoundry-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SolaceDev/solace-samples-cloudfoundry-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SolaceDev/solace-samples-cloudfoundry-java/teams","hooks_url":"https://api.github.com/repos/SolaceDev/solace-samples-cloudfoundry-java/hooks","issue_events_url":"https://api.github.com/repos/SolaceDev/solace-samples-cloudfoundry-java/issues/events{/number}","events_url":"https://api.github.com/repos/SolaceDev/solace-samples-cloudfoundry-java/events","assignees_url":"https://api.github.com/repos/SolaceDev/solace-samples-cloudfoundry-java/assignees{/user}","branches_url":"https://api.github.com/repos/SolaceDev/solace-samples-cloudfoundry-java/branches{/branch}","tags_url":"https://api.github.com/repos/SolaceDev/solace-samples-cloudfoundry-java/tags","blobs_url":"https://api.github.com/repos/SolaceDev/solace-samples-cloudfoundry-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SolaceDev/solace-samples-cloudfoundry-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SolaceDev/solace-samples-cloudfoundry-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/SolaceDev/solace-samples-cloudfoundry-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SolaceDev/solace-samples-cloudfoundry-java/statuses/{sha}","languages_url":"https://api.github.com/repos/SolaceDev/solace-samples-cloudfoundry-java/languages","stargazers_url":"https://api.github.com/repos/SolaceDev/solace-samples-cloudfoundry-java/stargazers","contributors_url":"https://api.github.com/repos/SolaceDev/solace-samples-cloudfoundry-java/contributors","subscribers_url":"https://api.github.com/repos/SolaceDev/solace-samples-cloudfoundry-java/subscribers","subscription_url":"https://api.github.com/repos/SolaceDev/solace-samples-cloudfoundry-java/subscription","commits_url":"https://api.github.com/repos/SolaceDev/solace-samples-cloudfoundry-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/SolaceDev/solace-samples-cloudfoundry-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/SolaceDev/solace-samples-cloudfoundry-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/SolaceDev/solace-samples-cloudfoundry-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/SolaceDev/solace-samples-cloudfoundry-java/contents/{+path}","compare_url":"https://api.github.com/repos/SolaceDev/solace-samples-cloudfoundry-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SolaceDev/solace-samples-cloudfoundry-java/merges","archive_url":"https://api.github.com/repos/SolaceDev/solace-samples-cloudfoundry-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SolaceDev/solace-samples-cloudfoundry-java/downloads","issues_url":"https://api.github.com/repos/SolaceDev/solace-samples-cloudfoundry-java/issues{/number}","pulls_url":"https://api.github.com/repos/SolaceDev/solace-samples-cloudfoundry-java/pulls{/number}","milestones_url":"https://api.github.com/repos/SolaceDev/solace-samples-cloudfoundry-java/milestones{/number}","notifications_url":"https://api.github.com/repos/SolaceDev/solace-samples-cloudfoundry-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SolaceDev/solace-samples-cloudfoundry-java/labels{/name}","releases_url":"https://api.github.com/repos/SolaceDev/solace-samples-cloudfoundry-java/releases{/id}","deployments_url":"https://api.github.com/repos/SolaceDev/solace-samples-cloudfoundry-java/deployments","created_at":"2017-11-02T15:29:16Z","updated_at":"2018-03-16T17:46:21Z","pushed_at":"2018-04-13T20:38:25Z","git_url":"git://github.com/SolaceDev/solace-samples-cloudfoundry-java.git","ssh_url":"[email protected]:SolaceDev/solace-samples-cloudfoundry-java.git","clone_url":"https://github.com/SolaceDev/solace-samples-cloudfoundry-java.git","svn_url":"https://github.com/SolaceDev/solace-samples-cloudfoundry-java","homepage":"http://dev.solace.com/get-started/pcf-tutorials/","size":2989,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"SolaceSamples:master","ref":"master","sha":"20e61dcc88f09ab4ecc78950efa4e5bbc0a010ba","user":{"login":"SolaceSamples","id":20524091,"avatar_url":"https://avatars3.githubusercontent.com/u/20524091?v=4","gravatar_id":"","url":"https://api.github.com/users/SolaceSamples","html_url":"https://github.com/SolaceSamples","followers_url":"https://api.github.com/users/SolaceSamples/followers","following_url":"https://api.github.com/users/SolaceSamples/following{/other_user}","gists_url":"https://api.github.com/users/SolaceSamples/gists{/gist_id}","starred_url":"https://api.github.com/users/SolaceSamples/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SolaceSamples/subscriptions","organizations_url":"https://api.github.com/users/SolaceSamples/orgs","repos_url":"https://api.github.com/users/SolaceSamples/repos","events_url":"https://api.github.com/users/SolaceSamples/events{/privacy}","received_events_url":"https://api.github.com/users/SolaceSamples/received_events","type":"Organization","site_admin":false},"repo":{"id":64405195,"name":"solace-samples-cloudfoundry-java","full_name":"SolaceSamples/solace-samples-cloudfoundry-java","owner":{"login":"SolaceSamples","id":20524091,"avatar_url":"https://avatars3.githubusercontent.com/u/20524091?v=4","gravatar_id":"","url":"https://api.github.com/users/SolaceSamples","html_url":"https://github.com/SolaceSamples","followers_url":"https://api.github.com/users/SolaceSamples/followers","following_url":"https://api.github.com/users/SolaceSamples/following{/other_user}","gists_url":"https://api.github.com/users/SolaceSamples/gists{/gist_id}","starred_url":"https://api.github.com/users/SolaceSamples/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SolaceSamples/subscriptions","organizations_url":"https://api.github.com/users/SolaceSamples/orgs","repos_url":"https://api.github.com/users/SolaceSamples/repos","events_url":"https://api.github.com/users/SolaceSamples/events{/privacy}","received_events_url":"https://api.github.com/users/SolaceSamples/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SolaceSamples/solace-samples-cloudfoundry-java","description":"Samples showing how to connect and exchange messages with Solace Messaging for Pivotal Cloud Foundry.","fork":false,"url":"https://api.github.com/repos/SolaceSamples/solace-samples-cloudfoundry-java","forks_url":"https://api.github.com/repos/SolaceSamples/solace-samples-cloudfoundry-java/forks","keys_url":"https://api.github.com/repos/SolaceSamples/solace-samples-cloudfoundry-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SolaceSamples/solace-samples-cloudfoundry-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SolaceSamples/solace-samples-cloudfoundry-java/teams","hooks_url":"https://api.github.com/repos/SolaceSamples/solace-samples-cloudfoundry-java/hooks","issue_events_url":"https://api.github.com/repos/SolaceSamples/solace-samples-cloudfoundry-java/issues/events{/number}","events_url":"https://api.github.com/repos/SolaceSamples/solace-samples-cloudfoundry-java/events","assignees_url":"https://api.github.com/repos/SolaceSamples/solace-samples-cloudfoundry-java/assignees{/user}","branches_url":"https://api.github.com/repos/SolaceSamples/solace-samples-cloudfoundry-java/branches{/branch}","tags_url":"https://api.github.com/repos/SolaceSamples/solace-samples-cloudfoundry-java/tags","blobs_url":"https://api.github.com/repos/SolaceSamples/solace-samples-cloudfoundry-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SolaceSamples/solace-samples-cloudfoundry-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SolaceSamples/solace-samples-cloudfoundry-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/SolaceSamples/solace-samples-cloudfoundry-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SolaceSamples/solace-samples-cloudfoundry-java/statuses/{sha}","languages_url":"https://api.github.com/repos/SolaceSamples/solace-samples-cloudfoundry-java/languages","stargazers_url":"https://api.github.com/repos/SolaceSamples/solace-samples-cloudfoundry-java/stargazers","contributors_url":"https://api.github.com/repos/SolaceSamples/solace-samples-cloudfoundry-java/contributors","subscribers_url":"https://api.github.com/repos/SolaceSamples/solace-samples-cloudfoundry-java/subscribers","subscription_url":"https://api.github.com/repos/SolaceSamples/solace-samples-cloudfoundry-java/subscription","commits_url":"https://api.github.com/repos/SolaceSamples/solace-samples-cloudfoundry-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/SolaceSamples/solace-samples-cloudfoundry-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/SolaceSamples/solace-samples-cloudfoundry-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/SolaceSamples/solace-samples-cloudfoundry-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/SolaceSamples/solace-samples-cloudfoundry-java/contents/{+path}","compare_url":"https://api.github.com/repos/SolaceSamples/solace-samples-cloudfoundry-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SolaceSamples/solace-samples-cloudfoundry-java/merges","archive_url":"https://api.github.com/repos/SolaceSamples/solace-samples-cloudfoundry-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SolaceSamples/solace-samples-cloudfoundry-java/downloads","issues_url":"https://api.github.com/repos/SolaceSamples/solace-samples-cloudfoundry-java/issues{/number}","pulls_url":"https://api.github.com/repos/SolaceSamples/solace-samples-cloudfoundry-java/pulls{/number}","milestones_url":"https://api.github.com/repos/SolaceSamples/solace-samples-cloudfoundry-java/milestones{/number}","notifications_url":"https://api.github.com/repos/SolaceSamples/solace-samples-cloudfoundry-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SolaceSamples/solace-samples-cloudfoundry-java/labels{/name}","releases_url":"https://api.github.com/repos/SolaceSamples/solace-samples-cloudfoundry-java/releases{/id}","deployments_url":"https://api.github.com/repos/SolaceSamples/solace-samples-cloudfoundry-java/deployments","created_at":"2016-07-28T15:06:57Z","updated_at":"2018-01-10T19:30:08Z","pushed_at":"2018-04-13T20:38:26Z","git_url":"git://github.com/SolaceSamples/solace-samples-cloudfoundry-java.git","ssh_url":"[email protected]:SolaceSamples/solace-samples-cloudfoundry-java.git","clone_url":"https://github.com/SolaceSamples/solace-samples-cloudfoundry-java.git","svn_url":"https://github.com/SolaceSamples/solace-samples-cloudfoundry-java","homepage":"http://dev.solace.com/get-started/pcf-tutorials/","size":2903,"stargazers_count":26,"watchers_count":26,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":10,"open_issues":6,"watchers":26,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SolaceSamples/solace-samples-cloudfoundry-java/pulls/36"},"html":{"href":"https://github.com/SolaceSamples/solace-samples-cloudfoundry-java/pull/36"},"issue":{"href":"https://api.github.com/repos/SolaceSamples/solace-samples-cloudfoundry-java/issues/36"},"comments":{"href":"https://api.github.com/repos/SolaceSamples/solace-samples-cloudfoundry-java/issues/36/comments"},"review_comments":{"href":"https://api.github.com/repos/SolaceSamples/solace-samples-cloudfoundry-java/pulls/36/comments"},"review_comment":{"href":"https://api.github.com/repos/SolaceSamples/solace-samples-cloudfoundry-java/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SolaceSamples/solace-samples-cloudfoundry-java/pulls/36/commits"},"statuses":{"href":"https://api.github.com/repos/SolaceSamples/solace-samples-cloudfoundry-java/statuses/faa48637f0d386dab03e19dea2217f1794dacc79"}},"author_association":"NONE"}} | {
"id": 64405195,
"name": "SolaceSamples/solace-samples-cloudfoundry-java",
"url": "https://api.github.com/repos/SolaceSamples/solace-samples-cloudfoundry-java"
} | {
"id": 1561721,
"login": "mdspielman",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1561721?",
"url": "https://api.github.com/users/mdspielman"
} | {
"id": 20524091,
"login": "SolaceSamples",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/20524091?",
"url": "https://api.github.com/orgs/SolaceSamples"
} | 2018-04-16T18:52:52 | 7538046191 | {"actor":{"display_login":"mdspielman"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/bitprim/bitprim-cs/pulls/comments/202128044","pull_request_review_id":136765836,"id":202128044,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMjEyODA0NA==","diff_hunk":"@@ -6,103 +6,362 @@ namespace Bitprim\n public enum ErrorCode\n {\n // general codes\n+ /// <summary>\n+ /// The operation finished without errors\n+ /// </summary>\n Success = 0,\n+ /// <summary>\n+ /// The operation is deprecated\n+ /// </summary>\n Deprecated = 6,\n+ /// <summary>\n+ /// Unknown error\n+ /// </summary>\n Unknown = 43,\n+ /// <summary>\n+ /// The resource not exists","path":"bitprim/idiomatic/ErrorCode.cs","position":17,"original_position":17,"commit_id":"88c0c2ce69406f46e8d4b715a378b5cfc6677e4a","original_commit_id":"88c0c2ce69406f46e8d4b715a378b5cfc6677e4a","user":{"login":"dario-ramos","id":4640062,"node_id":"MDQ6VXNlcjQ2NDAwNjI=","avatar_url":"https://avatars3.githubusercontent.com/u/4640062?v=4","gravatar_id":"","url":"https://api.github.com/users/dario-ramos","html_url":"https://github.com/dario-ramos","followers_url":"https://api.github.com/users/dario-ramos/followers","following_url":"https://api.github.com/users/dario-ramos/following{/other_user}","gists_url":"https://api.github.com/users/dario-ramos/gists{/gist_id}","starred_url":"https://api.github.com/users/dario-ramos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dario-ramos/subscriptions","organizations_url":"https://api.github.com/users/dario-ramos/orgs","repos_url":"https://api.github.com/users/dario-ramos/repos","events_url":"https://api.github.com/users/dario-ramos/events{/privacy}","received_events_url":"https://api.github.com/users/dario-ramos/received_events","type":"User","site_admin":false},"body":"does not exist","created_at":"2018-07-12T18:04:53Z","updated_at":"2018-07-12T18:15:02Z","html_url":"https://github.com/bitprim/bitprim-cs/pull/123#discussion_r202128044","pull_request_url":"https://api.github.com/repos/bitprim/bitprim-cs/pulls/123","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/bitprim/bitprim-cs/pulls/comments/202128044"},"html":{"href":"https://github.com/bitprim/bitprim-cs/pull/123#discussion_r202128044"},"pull_request":{"href":"https://api.github.com/repos/bitprim/bitprim-cs/pulls/123"}}},"pull_request":{"url":"https://api.github.com/repos/bitprim/bitprim-cs/pulls/123","id":201081174,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxMDgxMTc0","html_url":"https://github.com/bitprim/bitprim-cs/pull/123","diff_url":"https://github.com/bitprim/bitprim-cs/pull/123.diff","patch_url":"https://github.com/bitprim/bitprim-cs/pull/123.patch","issue_url":"https://api.github.com/repos/bitprim/bitprim-cs/issues/123","number":123,"state":"open","locked":false,"title":"Added comments to types","user":{"login":"mdallago","id":2328735,"node_id":"MDQ6VXNlcjIzMjg3MzU=","avatar_url":"https://avatars2.githubusercontent.com/u/2328735?v=4","gravatar_id":"","url":"https://api.github.com/users/mdallago","html_url":"https://github.com/mdallago","followers_url":"https://api.github.com/users/mdallago/followers","following_url":"https://api.github.com/users/mdallago/following{/other_user}","gists_url":"https://api.github.com/users/mdallago/gists{/gist_id}","starred_url":"https://api.github.com/users/mdallago/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdallago/subscriptions","organizations_url":"https://api.github.com/users/mdallago/orgs","repos_url":"https://api.github.com/users/mdallago/repos","events_url":"https://api.github.com/users/mdallago/events{/privacy}","received_events_url":"https://api.github.com/users/mdallago/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-07-12T18:04:06Z","updated_at":"2018-07-12T18:15:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dcf60c5bf6c0717912e4b67fc562c088a53ce39e","assignee":{"login":"mdallago","id":2328735,"node_id":"MDQ6VXNlcjIzMjg3MzU=","avatar_url":"https://avatars2.githubusercontent.com/u/2328735?v=4","gravatar_id":"","url":"https://api.github.com/users/mdallago","html_url":"https://github.com/mdallago","followers_url":"https://api.github.com/users/mdallago/followers","following_url":"https://api.github.com/users/mdallago/following{/other_user}","gists_url":"https://api.github.com/users/mdallago/gists{/gist_id}","starred_url":"https://api.github.com/users/mdallago/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdallago/subscriptions","organizations_url":"https://api.github.com/users/mdallago/orgs","repos_url":"https://api.github.com/users/mdallago/repos","events_url":"https://api.github.com/users/mdallago/events{/privacy}","received_events_url":"https://api.github.com/users/mdallago/received_events","type":"User","site_admin":false},"assignees":[{"login":"mdallago","id":2328735,"node_id":"MDQ6VXNlcjIzMjg3MzU=","avatar_url":"https://avatars2.githubusercontent.com/u/2328735?v=4","gravatar_id":"","url":"https://api.github.com/users/mdallago","html_url":"https://github.com/mdallago","followers_url":"https://api.github.com/users/mdallago/followers","following_url":"https://api.github.com/users/mdallago/following{/other_user}","gists_url":"https://api.github.com/users/mdallago/gists{/gist_id}","starred_url":"https://api.github.com/users/mdallago/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdallago/subscriptions","organizations_url":"https://api.github.com/users/mdallago/orgs","repos_url":"https://api.github.com/users/mdallago/repos","events_url":"https://api.github.com/users/mdallago/events{/privacy}","received_events_url":"https://api.github.com/users/mdallago/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"fpelliccioni","id":273683,"node_id":"MDQ6VXNlcjI3MzY4Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/273683?v=4","gravatar_id":"","url":"https://api.github.com/users/fpelliccioni","html_url":"https://github.com/fpelliccioni","followers_url":"https://api.github.com/users/fpelliccioni/followers","following_url":"https://api.github.com/users/fpelliccioni/following{/other_user}","gists_url":"https://api.github.com/users/fpelliccioni/gists{/gist_id}","starred_url":"https://api.github.com/users/fpelliccioni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fpelliccioni/subscriptions","organizations_url":"https://api.github.com/users/fpelliccioni/orgs","repos_url":"https://api.github.com/users/fpelliccioni/repos","events_url":"https://api.github.com/users/fpelliccioni/events{/privacy}","received_events_url":"https://api.github.com/users/fpelliccioni/received_events","type":"User","site_admin":false},{"login":"hanchon","id":5675227,"node_id":"MDQ6VXNlcjU2NzUyMjc=","avatar_url":"https://avatars1.githubusercontent.com/u/5675227?v=4","gravatar_id":"","url":"https://api.github.com/users/hanchon","html_url":"https://github.com/hanchon","followers_url":"https://api.github.com/users/hanchon/followers","following_url":"https://api.github.com/users/hanchon/following{/other_user}","gists_url":"https://api.github.com/users/hanchon/gists{/gist_id}","starred_url":"https://api.github.com/users/hanchon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hanchon/subscriptions","organizations_url":"https://api.github.com/users/hanchon/orgs","repos_url":"https://api.github.com/users/hanchon/repos","events_url":"https://api.github.com/users/hanchon/events{/privacy}","received_events_url":"https://api.github.com/users/hanchon/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/bitprim/bitprim-cs/pulls/123/commits","review_comments_url":"https://api.github.com/repos/bitprim/bitprim-cs/pulls/123/comments","review_comment_url":"https://api.github.com/repos/bitprim/bitprim-cs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bitprim/bitprim-cs/issues/123/comments","statuses_url":"https://api.github.com/repos/bitprim/bitprim-cs/statuses/88c0c2ce69406f46e8d4b715a378b5cfc6677e4a","head":{"label":"bitprim:feature-CS-66","ref":"feature-CS-66","sha":"88c0c2ce69406f46e8d4b715a378b5cfc6677e4a","user":{"login":"bitprim","id":20631151,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNjMxMTUx","avatar_url":"https://avatars0.githubusercontent.com/u/20631151?v=4","gravatar_id":"","url":"https://api.github.com/users/bitprim","html_url":"https://github.com/bitprim","followers_url":"https://api.github.com/users/bitprim/followers","following_url":"https://api.github.com/users/bitprim/following{/other_user}","gists_url":"https://api.github.com/users/bitprim/gists{/gist_id}","starred_url":"https://api.github.com/users/bitprim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitprim/subscriptions","organizations_url":"https://api.github.com/users/bitprim/orgs","repos_url":"https://api.github.com/users/bitprim/repos","events_url":"https://api.github.com/users/bitprim/events{/privacy}","received_events_url":"https://api.github.com/users/bitprim/received_events","type":"Organization","site_admin":false},"repo":{"id":95145297,"node_id":"MDEwOlJlcG9zaXRvcnk5NTE0NTI5Nw==","name":"bitprim-cs","full_name":"bitprim/bitprim-cs","owner":{"login":"bitprim","id":20631151,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNjMxMTUx","avatar_url":"https://avatars0.githubusercontent.com/u/20631151?v=4","gravatar_id":"","url":"https://api.github.com/users/bitprim","html_url":"https://github.com/bitprim","followers_url":"https://api.github.com/users/bitprim/followers","following_url":"https://api.github.com/users/bitprim/following{/other_user}","gists_url":"https://api.github.com/users/bitprim/gists{/gist_id}","starred_url":"https://api.github.com/users/bitprim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitprim/subscriptions","organizations_url":"https://api.github.com/users/bitprim/orgs","repos_url":"https://api.github.com/users/bitprim/repos","events_url":"https://api.github.com/users/bitprim/events{/privacy}","received_events_url":"https://api.github.com/users/bitprim/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bitprim/bitprim-cs","description":null,"fork":false,"url":"https://api.github.com/repos/bitprim/bitprim-cs","forks_url":"https://api.github.com/repos/bitprim/bitprim-cs/forks","keys_url":"https://api.github.com/repos/bitprim/bitprim-cs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bitprim/bitprim-cs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bitprim/bitprim-cs/teams","hooks_url":"https://api.github.com/repos/bitprim/bitprim-cs/hooks","issue_events_url":"https://api.github.com/repos/bitprim/bitprim-cs/issues/events{/number}","events_url":"https://api.github.com/repos/bitprim/bitprim-cs/events","assignees_url":"https://api.github.com/repos/bitprim/bitprim-cs/assignees{/user}","branches_url":"https://api.github.com/repos/bitprim/bitprim-cs/branches{/branch}","tags_url":"https://api.github.com/repos/bitprim/bitprim-cs/tags","blobs_url":"https://api.github.com/repos/bitprim/bitprim-cs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bitprim/bitprim-cs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bitprim/bitprim-cs/git/refs{/sha}","trees_url":"https://api.github.com/repos/bitprim/bitprim-cs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bitprim/bitprim-cs/statuses/{sha}","languages_url":"https://api.github.com/repos/bitprim/bitprim-cs/languages","stargazers_url":"https://api.github.com/repos/bitprim/bitprim-cs/stargazers","contributors_url":"https://api.github.com/repos/bitprim/bitprim-cs/contributors","subscribers_url":"https://api.github.com/repos/bitprim/bitprim-cs/subscribers","subscription_url":"https://api.github.com/repos/bitprim/bitprim-cs/subscription","commits_url":"https://api.github.com/repos/bitprim/bitprim-cs/commits{/sha}","git_commits_url":"https://api.github.com/repos/bitprim/bitprim-cs/git/commits{/sha}","comments_url":"https://api.github.com/repos/bitprim/bitprim-cs/comments{/number}","issue_comment_url":"https://api.github.com/repos/bitprim/bitprim-cs/issues/comments{/number}","contents_url":"https://api.github.com/repos/bitprim/bitprim-cs/contents/{+path}","compare_url":"https://api.github.com/repos/bitprim/bitprim-cs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bitprim/bitprim-cs/merges","archive_url":"https://api.github.com/repos/bitprim/bitprim-cs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bitprim/bitprim-cs/downloads","issues_url":"https://api.github.com/repos/bitprim/bitprim-cs/issues{/number}","pulls_url":"https://api.github.com/repos/bitprim/bitprim-cs/pulls{/number}","milestones_url":"https://api.github.com/repos/bitprim/bitprim-cs/milestones{/number}","notifications_url":"https://api.github.com/repos/bitprim/bitprim-cs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bitprim/bitprim-cs/labels{/name}","releases_url":"https://api.github.com/repos/bitprim/bitprim-cs/releases{/id}","deployments_url":"https://api.github.com/repos/bitprim/bitprim-cs/deployments","created_at":"2017-06-22T18:33:13Z","updated_at":"2018-07-12T15:12:06Z","pushed_at":"2018-07-12T18:04:06Z","git_url":"git://github.com/bitprim/bitprim-cs.git","ssh_url":"[email protected]:bitprim/bitprim-cs.git","clone_url":"https://github.com/bitprim/bitprim-cs.git","svn_url":"https://github.com/bitprim/bitprim-cs","homepage":null,"size":1476,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"bitprim:dev","ref":"dev","sha":"8a3e087a4b0ef302030f599288d9d8cdfa70c8ad","user":{"login":"bitprim","id":20631151,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNjMxMTUx","avatar_url":"https://avatars0.githubusercontent.com/u/20631151?v=4","gravatar_id":"","url":"https://api.github.com/users/bitprim","html_url":"https://github.com/bitprim","followers_url":"https://api.github.com/users/bitprim/followers","following_url":"https://api.github.com/users/bitprim/following{/other_user}","gists_url":"https://api.github.com/users/bitprim/gists{/gist_id}","starred_url":"https://api.github.com/users/bitprim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitprim/subscriptions","organizations_url":"https://api.github.com/users/bitprim/orgs","repos_url":"https://api.github.com/users/bitprim/repos","events_url":"https://api.github.com/users/bitprim/events{/privacy}","received_events_url":"https://api.github.com/users/bitprim/received_events","type":"Organization","site_admin":false},"repo":{"id":95145297,"node_id":"MDEwOlJlcG9zaXRvcnk5NTE0NTI5Nw==","name":"bitprim-cs","full_name":"bitprim/bitprim-cs","owner":{"login":"bitprim","id":20631151,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNjMxMTUx","avatar_url":"https://avatars0.githubusercontent.com/u/20631151?v=4","gravatar_id":"","url":"https://api.github.com/users/bitprim","html_url":"https://github.com/bitprim","followers_url":"https://api.github.com/users/bitprim/followers","following_url":"https://api.github.com/users/bitprim/following{/other_user}","gists_url":"https://api.github.com/users/bitprim/gists{/gist_id}","starred_url":"https://api.github.com/users/bitprim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitprim/subscriptions","organizations_url":"https://api.github.com/users/bitprim/orgs","repos_url":"https://api.github.com/users/bitprim/repos","events_url":"https://api.github.com/users/bitprim/events{/privacy}","received_events_url":"https://api.github.com/users/bitprim/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bitprim/bitprim-cs","description":null,"fork":false,"url":"https://api.github.com/repos/bitprim/bitprim-cs","forks_url":"https://api.github.com/repos/bitprim/bitprim-cs/forks","keys_url":"https://api.github.com/repos/bitprim/bitprim-cs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bitprim/bitprim-cs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bitprim/bitprim-cs/teams","hooks_url":"https://api.github.com/repos/bitprim/bitprim-cs/hooks","issue_events_url":"https://api.github.com/repos/bitprim/bitprim-cs/issues/events{/number}","events_url":"https://api.github.com/repos/bitprim/bitprim-cs/events","assignees_url":"https://api.github.com/repos/bitprim/bitprim-cs/assignees{/user}","branches_url":"https://api.github.com/repos/bitprim/bitprim-cs/branches{/branch}","tags_url":"https://api.github.com/repos/bitprim/bitprim-cs/tags","blobs_url":"https://api.github.com/repos/bitprim/bitprim-cs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bitprim/bitprim-cs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bitprim/bitprim-cs/git/refs{/sha}","trees_url":"https://api.github.com/repos/bitprim/bitprim-cs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bitprim/bitprim-cs/statuses/{sha}","languages_url":"https://api.github.com/repos/bitprim/bitprim-cs/languages","stargazers_url":"https://api.github.com/repos/bitprim/bitprim-cs/stargazers","contributors_url":"https://api.github.com/repos/bitprim/bitprim-cs/contributors","subscribers_url":"https://api.github.com/repos/bitprim/bitprim-cs/subscribers","subscription_url":"https://api.github.com/repos/bitprim/bitprim-cs/subscription","commits_url":"https://api.github.com/repos/bitprim/bitprim-cs/commits{/sha}","git_commits_url":"https://api.github.com/repos/bitprim/bitprim-cs/git/commits{/sha}","comments_url":"https://api.github.com/repos/bitprim/bitprim-cs/comments{/number}","issue_comment_url":"https://api.github.com/repos/bitprim/bitprim-cs/issues/comments{/number}","contents_url":"https://api.github.com/repos/bitprim/bitprim-cs/contents/{+path}","compare_url":"https://api.github.com/repos/bitprim/bitprim-cs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bitprim/bitprim-cs/merges","archive_url":"https://api.github.com/repos/bitprim/bitprim-cs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bitprim/bitprim-cs/downloads","issues_url":"https://api.github.com/repos/bitprim/bitprim-cs/issues{/number}","pulls_url":"https://api.github.com/repos/bitprim/bitprim-cs/pulls{/number}","milestones_url":"https://api.github.com/repos/bitprim/bitprim-cs/milestones{/number}","notifications_url":"https://api.github.com/repos/bitprim/bitprim-cs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bitprim/bitprim-cs/labels{/name}","releases_url":"https://api.github.com/repos/bitprim/bitprim-cs/releases{/id}","deployments_url":"https://api.github.com/repos/bitprim/bitprim-cs/deployments","created_at":"2017-06-22T18:33:13Z","updated_at":"2018-07-12T15:12:06Z","pushed_at":"2018-07-12T18:04:06Z","git_url":"git://github.com/bitprim/bitprim-cs.git","ssh_url":"[email protected]:bitprim/bitprim-cs.git","clone_url":"https://github.com/bitprim/bitprim-cs.git","svn_url":"https://github.com/bitprim/bitprim-cs","homepage":null,"size":1476,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bitprim/bitprim-cs/pulls/123"},"html":{"href":"https://github.com/bitprim/bitprim-cs/pull/123"},"issue":{"href":"https://api.github.com/repos/bitprim/bitprim-cs/issues/123"},"comments":{"href":"https://api.github.com/repos/bitprim/bitprim-cs/issues/123/comments"},"review_comments":{"href":"https://api.github.com/repos/bitprim/bitprim-cs/pulls/123/comments"},"review_comment":{"href":"https://api.github.com/repos/bitprim/bitprim-cs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bitprim/bitprim-cs/pulls/123/commits"},"statuses":{"href":"https://api.github.com/repos/bitprim/bitprim-cs/statuses/88c0c2ce69406f46e8d4b715a378b5cfc6677e4a"}},"author_association":"CONTRIBUTOR"}} | {
"id": 95145297,
"name": "bitprim/bitprim-cs",
"url": "https://api.github.com/repos/bitprim/bitprim-cs"
} | {
"id": 4640062,
"login": "dario-ramos",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4640062?",
"url": "https://api.github.com/users/dario-ramos"
} | {
"id": 20631151,
"login": "bitprim",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/20631151?",
"url": "https://api.github.com/orgs/bitprim"
} | 2018-07-12T18:04:53 | 7957885763 | {"actor":{"display_login":"dario-ramos"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/openatx/weditor/pulls/comments/230618413","pull_request_review_id":171394812,"id":230618413,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMDYxODQxMw==","diff_hunk":"@@ -630,12 +677,12 @@ new Vue({\n this.loading = true;\n this.codeInsert(code);\n this.codeRunDebugCode(code)\n- .then(this.delayReload)\n+ // .then(this.delayReload)","path":"weditor/static/js/index.js","position":184,"original_position":184,"commit_id":"07128972969d4b9c5e34337f3802a925b0d3079e","original_commit_id":"07128972969d4b9c5e34337f3802a925b0d3079e","user":{"login":"codeskyblue","id":3281689,"node_id":"MDQ6VXNlcjMyODE2ODk=","avatar_url":"https://avatars3.githubusercontent.com/u/3281689?v=4","gravatar_id":"","url":"https://api.github.com/users/codeskyblue","html_url":"https://github.com/codeskyblue","followers_url":"https://api.github.com/users/codeskyblue/followers","following_url":"https://api.github.com/users/codeskyblue/following{/other_user}","gists_url":"https://api.github.com/users/codeskyblue/gists{/gist_id}","starred_url":"https://api.github.com/users/codeskyblue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codeskyblue/subscriptions","organizations_url":"https://api.github.com/users/codeskyblue/orgs","repos_url":"https://api.github.com/users/codeskyblue/repos","events_url":"https://api.github.com/users/codeskyblue/events{/privacy}","received_events_url":"https://api.github.com/users/codeskyblue/received_events","type":"User","site_admin":false},"body":"deleted","created_at":"2018-11-05T01:59:57Z","updated_at":"2018-11-05T01:59:57Z","html_url":"https://github.com/openatx/weditor/pull/30#discussion_r230618413","pull_request_url":"https://api.github.com/repos/openatx/weditor/pulls/30","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/openatx/weditor/pulls/comments/230618413"},"html":{"href":"https://github.com/openatx/weditor/pull/30#discussion_r230618413"},"pull_request":{"href":"https://api.github.com/repos/openatx/weditor/pulls/30"}}},"pull_request":{"url":"https://api.github.com/repos/openatx/weditor/pulls/30","id":228221201,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4MjIxMjAx","html_url":"https://github.com/openatx/weditor/pull/30","diff_url":"https://github.com/openatx/weditor/pull/30.diff","patch_url":"https://github.com/openatx/weditor/pull/30.patch","issue_url":"https://api.github.com/repos/openatx/weditor/issues/30","number":30,"state":"open","locked":false,"title":"增加实时界面操控，改变操作逻辑","user":{"login":"zhuzhenyuan","id":19206416,"node_id":"MDQ6VXNlcjE5MjA2NDE2","avatar_url":"https://avatars2.githubusercontent.com/u/19206416?v=4","gravatar_id":"","url":"https://api.github.com/users/zhuzhenyuan","html_url":"https://github.com/zhuzhenyuan","followers_url":"https://api.github.com/users/zhuzhenyuan/followers","following_url":"https://api.github.com/users/zhuzhenyuan/following{/other_user}","gists_url":"https://api.github.com/users/zhuzhenyuan/gists{/gist_id}","starred_url":"https://api.github.com/users/zhuzhenyuan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhuzhenyuan/subscriptions","organizations_url":"https://api.github.com/users/zhuzhenyuan/orgs","repos_url":"https://api.github.com/users/zhuzhenyuan/repos","events_url":"https://api.github.com/users/zhuzhenyuan/events{/privacy}","received_events_url":"https://api.github.com/users/zhuzhenyuan/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-11-05T01:47:50Z","updated_at":"2018-11-05T01:59:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fcbd5a3898a3cd9fe968ac00f7b7c0d74f53fb4f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/openatx/weditor/pulls/30/commits","review_comments_url":"https://api.github.com/repos/openatx/weditor/pulls/30/comments","review_comment_url":"https://api.github.com/repos/openatx/weditor/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openatx/weditor/issues/30/comments","statuses_url":"https://api.github.com/repos/openatx/weditor/statuses/07128972969d4b9c5e34337f3802a925b0d3079e","head":{"label":"zhuzhenyuan:zzy","ref":"zzy","sha":"07128972969d4b9c5e34337f3802a925b0d3079e","user":{"login":"zhuzhenyuan","id":19206416,"node_id":"MDQ6VXNlcjE5MjA2NDE2","avatar_url":"https://avatars2.githubusercontent.com/u/19206416?v=4","gravatar_id":"","url":"https://api.github.com/users/zhuzhenyuan","html_url":"https://github.com/zhuzhenyuan","followers_url":"https://api.github.com/users/zhuzhenyuan/followers","following_url":"https://api.github.com/users/zhuzhenyuan/following{/other_user}","gists_url":"https://api.github.com/users/zhuzhenyuan/gists{/gist_id}","starred_url":"https://api.github.com/users/zhuzhenyuan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhuzhenyuan/subscriptions","organizations_url":"https://api.github.com/users/zhuzhenyuan/orgs","repos_url":"https://api.github.com/users/zhuzhenyuan/repos","events_url":"https://api.github.com/users/zhuzhenyuan/events{/privacy}","received_events_url":"https://api.github.com/users/zhuzhenyuan/received_events","type":"User","site_admin":false},"repo":{"id":155670998,"node_id":"MDEwOlJlcG9zaXRvcnkxNTU2NzA5OTg=","name":"weditor","full_name":"zhuzhenyuan/weditor","private":false,"owner":{"login":"zhuzhenyuan","id":19206416,"node_id":"MDQ6VXNlcjE5MjA2NDE2","avatar_url":"https://avatars2.githubusercontent.com/u/19206416?v=4","gravatar_id":"","url":"https://api.github.com/users/zhuzhenyuan","html_url":"https://github.com/zhuzhenyuan","followers_url":"https://api.github.com/users/zhuzhenyuan/followers","following_url":"https://api.github.com/users/zhuzhenyuan/following{/other_user}","gists_url":"https://api.github.com/users/zhuzhenyuan/gists{/gist_id}","starred_url":"https://api.github.com/users/zhuzhenyuan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhuzhenyuan/subscriptions","organizations_url":"https://api.github.com/users/zhuzhenyuan/orgs","repos_url":"https://api.github.com/users/zhuzhenyuan/repos","events_url":"https://api.github.com/users/zhuzhenyuan/events{/privacy}","received_events_url":"https://api.github.com/users/zhuzhenyuan/received_events","type":"User","site_admin":false},"html_url":"https://github.com/zhuzhenyuan/weditor","description":"web editor for atx","fork":true,"url":"https://api.github.com/repos/zhuzhenyuan/weditor","forks_url":"https://api.github.com/repos/zhuzhenyuan/weditor/forks","keys_url":"https://api.github.com/repos/zhuzhenyuan/weditor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zhuzhenyuan/weditor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zhuzhenyuan/weditor/teams","hooks_url":"https://api.github.com/repos/zhuzhenyuan/weditor/hooks","issue_events_url":"https://api.github.com/repos/zhuzhenyuan/weditor/issues/events{/number}","events_url":"https://api.github.com/repos/zhuzhenyuan/weditor/events","assignees_url":"https://api.github.com/repos/zhuzhenyuan/weditor/assignees{/user}","branches_url":"https://api.github.com/repos/zhuzhenyuan/weditor/branches{/branch}","tags_url":"https://api.github.com/repos/zhuzhenyuan/weditor/tags","blobs_url":"https://api.github.com/repos/zhuzhenyuan/weditor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zhuzhenyuan/weditor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zhuzhenyuan/weditor/git/refs{/sha}","trees_url":"https://api.github.com/repos/zhuzhenyuan/weditor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zhuzhenyuan/weditor/statuses/{sha}","languages_url":"https://api.github.com/repos/zhuzhenyuan/weditor/languages","stargazers_url":"https://api.github.com/repos/zhuzhenyuan/weditor/stargazers","contributors_url":"https://api.github.com/repos/zhuzhenyuan/weditor/contributors","subscribers_url":"https://api.github.com/repos/zhuzhenyuan/weditor/subscribers","subscription_url":"https://api.github.com/repos/zhuzhenyuan/weditor/subscription","commits_url":"https://api.github.com/repos/zhuzhenyuan/weditor/commits{/sha}","git_commits_url":"https://api.github.com/repos/zhuzhenyuan/weditor/git/commits{/sha}","comments_url":"https://api.github.com/repos/zhuzhenyuan/weditor/comments{/number}","issue_comment_url":"https://api.github.com/repos/zhuzhenyuan/weditor/issues/comments{/number}","contents_url":"https://api.github.com/repos/zhuzhenyuan/weditor/contents/{+path}","compare_url":"https://api.github.com/repos/zhuzhenyuan/weditor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zhuzhenyuan/weditor/merges","archive_url":"https://api.github.com/repos/zhuzhenyuan/weditor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zhuzhenyuan/weditor/downloads","issues_url":"https://api.github.com/repos/zhuzhenyuan/weditor/issues{/number}","pulls_url":"https://api.github.com/repos/zhuzhenyuan/weditor/pulls{/number}","milestones_url":"https://api.github.com/repos/zhuzhenyuan/weditor/milestones{/number}","notifications_url":"https://api.github.com/repos/zhuzhenyuan/weditor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zhuzhenyuan/weditor/labels{/name}","releases_url":"https://api.github.com/repos/zhuzhenyuan/weditor/releases{/id}","deployments_url":"https://api.github.com/repos/zhuzhenyuan/weditor/deployments","created_at":"2018-11-01T06:23:27Z","updated_at":"2018-11-01T06:23:29Z","pushed_at":"2018-11-05T01:46:40Z","git_url":"git://github.com/zhuzhenyuan/weditor.git","ssh_url":"[email protected]:zhuzhenyuan/weditor.git","clone_url":"https://github.com/zhuzhenyuan/weditor.git","svn_url":"https://github.com/zhuzhenyuan/weditor","homepage":null,"size":1070,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openatx:master","ref":"master","sha":"3ab3e0ae685b66be7140ff3199212eaf1e1e7444","user":{"login":"openatx","id":20634838,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNjM0ODM4","avatar_url":"https://avatars3.githubusercontent.com/u/20634838?v=4","gravatar_id":"","url":"https://api.github.com/users/openatx","html_url":"https://github.com/openatx","followers_url":"https://api.github.com/users/openatx/followers","following_url":"https://api.github.com/users/openatx/following{/other_user}","gists_url":"https://api.github.com/users/openatx/gists{/gist_id}","starred_url":"https://api.github.com/users/openatx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openatx/subscriptions","organizations_url":"https://api.github.com/users/openatx/orgs","repos_url":"https://api.github.com/users/openatx/repos","events_url":"https://api.github.com/users/openatx/events{/privacy}","received_events_url":"https://api.github.com/users/openatx/received_events","type":"Organization","site_admin":false},"repo":{"id":84531631,"node_id":"MDEwOlJlcG9zaXRvcnk4NDUzMTYzMQ==","name":"weditor","full_name":"openatx/weditor","private":false,"owner":{"login":"openatx","id":20634838,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNjM0ODM4","avatar_url":"https://avatars3.githubusercontent.com/u/20634838?v=4","gravatar_id":"","url":"https://api.github.com/users/openatx","html_url":"https://github.com/openatx","followers_url":"https://api.github.com/users/openatx/followers","following_url":"https://api.github.com/users/openatx/following{/other_user}","gists_url":"https://api.github.com/users/openatx/gists{/gist_id}","starred_url":"https://api.github.com/users/openatx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openatx/subscriptions","organizations_url":"https://api.github.com/users/openatx/orgs","repos_url":"https://api.github.com/users/openatx/repos","events_url":"https://api.github.com/users/openatx/events{/privacy}","received_events_url":"https://api.github.com/users/openatx/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/openatx/weditor","description":"web editor for atx","fork":false,"url":"https://api.github.com/repos/openatx/weditor","forks_url":"https://api.github.com/repos/openatx/weditor/forks","keys_url":"https://api.github.com/repos/openatx/weditor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openatx/weditor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openatx/weditor/teams","hooks_url":"https://api.github.com/repos/openatx/weditor/hooks","issue_events_url":"https://api.github.com/repos/openatx/weditor/issues/events{/number}","events_url":"https://api.github.com/repos/openatx/weditor/events","assignees_url":"https://api.github.com/repos/openatx/weditor/assignees{/user}","branches_url":"https://api.github.com/repos/openatx/weditor/branches{/branch}","tags_url":"https://api.github.com/repos/openatx/weditor/tags","blobs_url":"https://api.github.com/repos/openatx/weditor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openatx/weditor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openatx/weditor/git/refs{/sha}","trees_url":"https://api.github.com/repos/openatx/weditor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openatx/weditor/statuses/{sha}","languages_url":"https://api.github.com/repos/openatx/weditor/languages","stargazers_url":"https://api.github.com/repos/openatx/weditor/stargazers","contributors_url":"https://api.github.com/repos/openatx/weditor/contributors","subscribers_url":"https://api.github.com/repos/openatx/weditor/subscribers","subscription_url":"https://api.github.com/repos/openatx/weditor/subscription","commits_url":"https://api.github.com/repos/openatx/weditor/commits{/sha}","git_commits_url":"https://api.github.com/repos/openatx/weditor/git/commits{/sha}","comments_url":"https://api.github.com/repos/openatx/weditor/comments{/number}","issue_comment_url":"https://api.github.com/repos/openatx/weditor/issues/comments{/number}","contents_url":"https://api.github.com/repos/openatx/weditor/contents/{+path}","compare_url":"https://api.github.com/repos/openatx/weditor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openatx/weditor/merges","archive_url":"https://api.github.com/repos/openatx/weditor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openatx/weditor/downloads","issues_url":"https://api.github.com/repos/openatx/weditor/issues{/number}","pulls_url":"https://api.github.com/repos/openatx/weditor/pulls{/number}","milestones_url":"https://api.github.com/repos/openatx/weditor/milestones{/number}","notifications_url":"https://api.github.com/repos/openatx/weditor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openatx/weditor/labels{/name}","releases_url":"https://api.github.com/repos/openatx/weditor/releases{/id}","deployments_url":"https://api.github.com/repos/openatx/weditor/deployments","created_at":"2017-03-10T07:23:40Z","updated_at":"2018-10-25T01:46:23Z","pushed_at":"2018-11-05T01:47:50Z","git_url":"git://github.com/openatx/weditor.git","ssh_url":"[email protected]:openatx/weditor.git","clone_url":"https://github.com/openatx/weditor.git","svn_url":"https://github.com/openatx/weditor","homepage":null,"size":1070,"stargazers_count":97,"watchers_count":97,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":36,"mirror_url":null,"archived":false,"open_issues_count":15,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":36,"open_issues":15,"watchers":97,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openatx/weditor/pulls/30"},"html":{"href":"https://github.com/openatx/weditor/pull/30"},"issue":{"href":"https://api.github.com/repos/openatx/weditor/issues/30"},"comments":{"href":"https://api.github.com/repos/openatx/weditor/issues/30/comments"},"review_comments":{"href":"https://api.github.com/repos/openatx/weditor/pulls/30/comments"},"review_comment":{"href":"https://api.github.com/repos/openatx/weditor/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openatx/weditor/pulls/30/commits"},"statuses":{"href":"https://api.github.com/repos/openatx/weditor/statuses/07128972969d4b9c5e34337f3802a925b0d3079e"}},"author_association":"NONE"}} | {
"id": 84531631,
"name": "openatx/weditor",
"url": "https://api.github.com/repos/openatx/weditor"
} | {
"id": 3281689,
"login": "codeskyblue",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3281689?",
"url": "https://api.github.com/users/codeskyblue"
} | {
"id": 20634838,
"login": "openatx",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/20634838?",
"url": "https://api.github.com/orgs/openatx"
} | 2018-11-05T01:59:57 | 8532942792 | {"actor":{"display_login":"codeskyblue"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/googlecartographer/cartographer/pulls/comments/208889554","pull_request_review_id":144548776,"id":208889554,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwODg4OTU1NA==","diff_hunk":"@@ -28,20 +28,25 @@ proto::TimedPointCloudData ToProto(\n proto.set_timestamp(common::ToUniversal(timed_point_cloud_data.time));\n *proto.mutable_origin() = transform::ToProto(timed_point_cloud_data.origin);\n proto.mutable_point_data()->Reserve(timed_point_cloud_data.ranges.size());\n- for (const Eigen::Vector4f& range : timed_point_cloud_data.ranges) {\n- *proto.add_point_data() = transform::ToProto(range);\n+ for (const TimedRangefinderPoint& range : timed_point_cloud_data.ranges) {\n+ *proto.add_point_data() = ToProto(range);\n }\n return proto;\n }\n \n TimedPointCloudData FromProto(const proto::TimedPointCloudData& proto) {\n TimedPointCloud timed_point_cloud;\n- timed_point_cloud.reserve(proto.point_data().size());\n- std::transform(\n- proto.point_data().begin(), proto.point_data().end(),\n- std::back_inserter(timed_point_cloud),\n- static_cast<Eigen::Vector4f (*)(const transform::proto::Vector4f&)>(\n- transform::ToEigen));\n+ if (proto.point_data().size() > 0) {\n+ timed_point_cloud.reserve(proto.point_data().size());\n+ for (const auto& timed_point_proto : proto.point_data())\n+ timed_point_cloud.push_back(FromProto(timed_point_proto));","path":"cartographer/sensor/timed_point_cloud_data.cc","position":23,"original_position":23,"commit_id":"29319b9be674fd1e0b03a9ac659a5da173663630","original_commit_id":"29319b9be674fd1e0b03a9ac659a5da173663630","user":{"login":"pifon2a","id":32522095,"node_id":"MDQ6VXNlcjMyNTIyMDk1","avatar_url":"https://avatars2.githubusercontent.com/u/32522095?v=4","gravatar_id":"","url":"https://api.github.com/users/pifon2a","html_url":"https://github.com/pifon2a","followers_url":"https://api.github.com/users/pifon2a/followers","following_url":"https://api.github.com/users/pifon2a/following{/other_user}","gists_url":"https://api.github.com/users/pifon2a/gists{/gist_id}","starred_url":"https://api.github.com/users/pifon2a/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pifon2a/subscriptions","organizations_url":"https://api.github.com/users/pifon2a/orgs","repos_url":"https://api.github.com/users/pifon2a/repos","events_url":"https://api.github.com/users/pifon2a/events{/privacy}","received_events_url":"https://api.github.com/users/pifon2a/received_events","type":"User","site_admin":false},"body":"nit: unfortunately, style guide requires {} here.","created_at":"2018-08-09T11:05:37Z","updated_at":"2018-08-09T11:05:46Z","html_url":"https://github.com/googlecartographer/cartographer/pull/1357#discussion_r208889554","pull_request_url":"https://api.github.com/repos/googlecartographer/cartographer/pulls/1357","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/googlecartographer/cartographer/pulls/comments/208889554"},"html":{"href":"https://github.com/googlecartographer/cartographer/pull/1357#discussion_r208889554"},"pull_request":{"href":"https://api.github.com/repos/googlecartographer/cartographer/pulls/1357"}}},"pull_request":{"url":"https://api.github.com/repos/googlecartographer/cartographer/pulls/1357","id":205113525,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1MTEzNTI1","html_url":"https://github.com/googlecartographer/cartographer/pull/1357","diff_url":"https://github.com/googlecartographer/cartographer/pull/1357.diff","patch_url":"https://github.com/googlecartographer/cartographer/pull/1357.patch","issue_url":"https://api.github.com/repos/googlecartographer/cartographer/issues/1357","number":1357,"state":"open","locked":false,"title":"Introduce [Timed]RangefinderPoint.","user":{"login":"ojura","id":9062353,"node_id":"MDQ6VXNlcjkwNjIzNTM=","avatar_url":"https://avatars3.githubusercontent.com/u/9062353?v=4","gravatar_id":"","url":"https://api.github.com/users/ojura","html_url":"https://github.com/ojura","followers_url":"https://api.github.com/users/ojura/followers","following_url":"https://api.github.com/users/ojura/following{/other_user}","gists_url":"https://api.github.com/users/ojura/gists{/gist_id}","starred_url":"https://api.github.com/users/ojura/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ojura/subscriptions","organizations_url":"https://api.github.com/users/ojura/orgs","repos_url":"https://api.github.com/users/ojura/repos","events_url":"https://api.github.com/users/ojura/events{/privacy}","received_events_url":"https://api.github.com/users/ojura/received_events","type":"User","site_admin":false},"body":"RFC: https://github.com/googlecartographer/rfcs/pull/36","created_at":"2018-07-31T13:31:07Z","updated_at":"2018-08-09T11:05:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fb954e4d7b630a15147d72d39dbd7b7e15180010","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":418020229,"node_id":"MDU6TGFiZWw0MTgwMjAyMjk=","url":"https://api.github.com/repos/googlecartographer/cartographer/labels/cla:%20yes","name":"cla: yes","color":"0e8a16","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/googlecartographer/cartographer/pulls/1357/commits","review_comments_url":"https://api.github.com/repos/googlecartographer/cartographer/pulls/1357/comments","review_comment_url":"https://api.github.com/repos/googlecartographer/cartographer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/googlecartographer/cartographer/issues/1357/comments","statuses_url":"https://api.github.com/repos/googlecartographer/cartographer/statuses/29319b9be674fd1e0b03a9ac659a5da173663630","head":{"label":"larics:introduce-rangefinderpoint","ref":"introduce-rangefinderpoint","sha":"29319b9be674fd1e0b03a9ac659a5da173663630","user":{"login":"larics","id":5793148,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU3OTMxNDg=","avatar_url":"https://avatars3.githubusercontent.com/u/5793148?v=4","gravatar_id":"","url":"https://api.github.com/users/larics","html_url":"https://github.com/larics","followers_url":"https://api.github.com/users/larics/followers","following_url":"https://api.github.com/users/larics/following{/other_user}","gists_url":"https://api.github.com/users/larics/gists{/gist_id}","starred_url":"https://api.github.com/users/larics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/larics/subscriptions","organizations_url":"https://api.github.com/users/larics/orgs","repos_url":"https://api.github.com/users/larics/repos","events_url":"https://api.github.com/users/larics/events{/privacy}","received_events_url":"https://api.github.com/users/larics/received_events","type":"Organization","site_admin":false},"repo":{"id":85944805,"node_id":"MDEwOlJlcG9zaXRvcnk4NTk0NDgwNQ==","name":"cartographer","full_name":"larics/cartographer","owner":{"login":"larics","id":5793148,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU3OTMxNDg=","avatar_url":"https://avatars3.githubusercontent.com/u/5793148?v=4","gravatar_id":"","url":"https://api.github.com/users/larics","html_url":"https://github.com/larics","followers_url":"https://api.github.com/users/larics/followers","following_url":"https://api.github.com/users/larics/following{/other_user}","gists_url":"https://api.github.com/users/larics/gists{/gist_id}","starred_url":"https://api.github.com/users/larics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/larics/subscriptions","organizations_url":"https://api.github.com/users/larics/orgs","repos_url":"https://api.github.com/users/larics/repos","events_url":"https://api.github.com/users/larics/events{/privacy}","received_events_url":"https://api.github.com/users/larics/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/larics/cartographer","description":"Cartographer is a system that provides real-time simultaneous localization and mapping (SLAM) in 2D and 3D across multiple platforms and sensor configurations.","fork":true,"url":"https://api.github.com/repos/larics/cartographer","forks_url":"https://api.github.com/repos/larics/cartographer/forks","keys_url":"https://api.github.com/repos/larics/cartographer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/larics/cartographer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/larics/cartographer/teams","hooks_url":"https://api.github.com/repos/larics/cartographer/hooks","issue_events_url":"https://api.github.com/repos/larics/cartographer/issues/events{/number}","events_url":"https://api.github.com/repos/larics/cartographer/events","assignees_url":"https://api.github.com/repos/larics/cartographer/assignees{/user}","branches_url":"https://api.github.com/repos/larics/cartographer/branches{/branch}","tags_url":"https://api.github.com/repos/larics/cartographer/tags","blobs_url":"https://api.github.com/repos/larics/cartographer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/larics/cartographer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/larics/cartographer/git/refs{/sha}","trees_url":"https://api.github.com/repos/larics/cartographer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/larics/cartographer/statuses/{sha}","languages_url":"https://api.github.com/repos/larics/cartographer/languages","stargazers_url":"https://api.github.com/repos/larics/cartographer/stargazers","contributors_url":"https://api.github.com/repos/larics/cartographer/contributors","subscribers_url":"https://api.github.com/repos/larics/cartographer/subscribers","subscription_url":"https://api.github.com/repos/larics/cartographer/subscription","commits_url":"https://api.github.com/repos/larics/cartographer/commits{/sha}","git_commits_url":"https://api.github.com/repos/larics/cartographer/git/commits{/sha}","comments_url":"https://api.github.com/repos/larics/cartographer/comments{/number}","issue_comment_url":"https://api.github.com/repos/larics/cartographer/issues/comments{/number}","contents_url":"https://api.github.com/repos/larics/cartographer/contents/{+path}","compare_url":"https://api.github.com/repos/larics/cartographer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/larics/cartographer/merges","archive_url":"https://api.github.com/repos/larics/cartographer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/larics/cartographer/downloads","issues_url":"https://api.github.com/repos/larics/cartographer/issues{/number}","pulls_url":"https://api.github.com/repos/larics/cartographer/pulls{/number}","milestones_url":"https://api.github.com/repos/larics/cartographer/milestones{/number}","notifications_url":"https://api.github.com/repos/larics/cartographer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/larics/cartographer/labels{/name}","releases_url":"https://api.github.com/repos/larics/cartographer/releases{/id}","deployments_url":"https://api.github.com/repos/larics/cartographer/deployments","created_at":"2017-03-23T12:01:16Z","updated_at":"2018-08-08T22:08:39Z","pushed_at":"2018-08-09T08:31:56Z","git_url":"git://github.com/larics/cartographer.git","ssh_url":"[email protected]:larics/cartographer.git","clone_url":"https://github.com/larics/cartographer.git","svn_url":"https://github.com/larics/cartographer","homepage":"","size":5194,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"googlecartographer:master","ref":"master","sha":"d5840e960a79c11fe8c04675b17c5f7844853d3b","user":{"login":"googlecartographer","id":20636162,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNjM2MTYy","avatar_url":"https://avatars3.githubusercontent.com/u/20636162?v=4","gravatar_id":"","url":"https://api.github.com/users/googlecartographer","html_url":"https://github.com/googlecartographer","followers_url":"https://api.github.com/users/googlecartographer/followers","following_url":"https://api.github.com/users/googlecartographer/following{/other_user}","gists_url":"https://api.github.com/users/googlecartographer/gists{/gist_id}","starred_url":"https://api.github.com/users/googlecartographer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/googlecartographer/subscriptions","organizations_url":"https://api.github.com/users/googlecartographer/orgs","repos_url":"https://api.github.com/users/googlecartographer/repos","events_url":"https://api.github.com/users/googlecartographer/events{/privacy}","received_events_url":"https://api.github.com/users/googlecartographer/received_events","type":"Organization","site_admin":false},"repo":{"id":64732358,"node_id":"MDEwOlJlcG9zaXRvcnk2NDczMjM1OA==","name":"cartographer","full_name":"googlecartographer/cartographer","owner":{"login":"googlecartographer","id":20636162,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNjM2MTYy","avatar_url":"https://avatars3.githubusercontent.com/u/20636162?v=4","gravatar_id":"","url":"https://api.github.com/users/googlecartographer","html_url":"https://github.com/googlecartographer","followers_url":"https://api.github.com/users/googlecartographer/followers","following_url":"https://api.github.com/users/googlecartographer/following{/other_user}","gists_url":"https://api.github.com/users/googlecartographer/gists{/gist_id}","starred_url":"https://api.github.com/users/googlecartographer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/googlecartographer/subscriptions","organizations_url":"https://api.github.com/users/googlecartographer/orgs","repos_url":"https://api.github.com/users/googlecartographer/repos","events_url":"https://api.github.com/users/googlecartographer/events{/privacy}","received_events_url":"https://api.github.com/users/googlecartographer/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/googlecartographer/cartographer","description":"Cartographer is a system that provides real-time simultaneous localization and mapping (SLAM) in 2D and 3D across multiple platforms and sensor configurations.","fork":false,"url":"https://api.github.com/repos/googlecartographer/cartographer","forks_url":"https://api.github.com/repos/googlecartographer/cartographer/forks","keys_url":"https://api.github.com/repos/googlecartographer/cartographer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/googlecartographer/cartographer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/googlecartographer/cartographer/teams","hooks_url":"https://api.github.com/repos/googlecartographer/cartographer/hooks","issue_events_url":"https://api.github.com/repos/googlecartographer/cartographer/issues/events{/number}","events_url":"https://api.github.com/repos/googlecartographer/cartographer/events","assignees_url":"https://api.github.com/repos/googlecartographer/cartographer/assignees{/user}","branches_url":"https://api.github.com/repos/googlecartographer/cartographer/branches{/branch}","tags_url":"https://api.github.com/repos/googlecartographer/cartographer/tags","blobs_url":"https://api.github.com/repos/googlecartographer/cartographer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/googlecartographer/cartographer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/googlecartographer/cartographer/git/refs{/sha}","trees_url":"https://api.github.com/repos/googlecartographer/cartographer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/googlecartographer/cartographer/statuses/{sha}","languages_url":"https://api.github.com/repos/googlecartographer/cartographer/languages","stargazers_url":"https://api.github.com/repos/googlecartographer/cartographer/stargazers","contributors_url":"https://api.github.com/repos/googlecartographer/cartographer/contributors","subscribers_url":"https://api.github.com/repos/googlecartographer/cartographer/subscribers","subscription_url":"https://api.github.com/repos/googlecartographer/cartographer/subscription","commits_url":"https://api.github.com/repos/googlecartographer/cartographer/commits{/sha}","git_commits_url":"https://api.github.com/repos/googlecartographer/cartographer/git/commits{/sha}","comments_url":"https://api.github.com/repos/googlecartographer/cartographer/comments{/number}","issue_comment_url":"https://api.github.com/repos/googlecartographer/cartographer/issues/comments{/number}","contents_url":"https://api.github.com/repos/googlecartographer/cartographer/contents/{+path}","compare_url":"https://api.github.com/repos/googlecartographer/cartographer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/googlecartographer/cartographer/merges","archive_url":"https://api.github.com/repos/googlecartographer/cartographer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/googlecartographer/cartographer/downloads","issues_url":"https://api.github.com/repos/googlecartographer/cartographer/issues{/number}","pulls_url":"https://api.github.com/repos/googlecartographer/cartographer/pulls{/number}","milestones_url":"https://api.github.com/repos/googlecartographer/cartographer/milestones{/number}","notifications_url":"https://api.github.com/repos/googlecartographer/cartographer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/googlecartographer/cartographer/labels{/name}","releases_url":"https://api.github.com/repos/googlecartographer/cartographer/releases{/id}","deployments_url":"https://api.github.com/repos/googlecartographer/cartographer/deployments","created_at":"2016-08-02T06:55:43Z","updated_at":"2018-08-09T08:30:46Z","pushed_at":"2018-08-09T11:03:30Z","git_url":"git://github.com/googlecartographer/cartographer.git","ssh_url":"[email protected]:googlecartographer/cartographer.git","clone_url":"https://github.com/googlecartographer/cartographer.git","svn_url":"https://github.com/googlecartographer/cartographer","homepage":"","size":5142,"stargazers_count":3574,"watchers_count":3574,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":1168,"mirror_url":null,"archived":false,"open_issues_count":47,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1168,"open_issues":47,"watchers":3574,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/googlecartographer/cartographer/pulls/1357"},"html":{"href":"https://github.com/googlecartographer/cartographer/pull/1357"},"issue":{"href":"https://api.github.com/repos/googlecartographer/cartographer/issues/1357"},"comments":{"href":"https://api.github.com/repos/googlecartographer/cartographer/issues/1357/comments"},"review_comments":{"href":"https://api.github.com/repos/googlecartographer/cartographer/pulls/1357/comments"},"review_comment":{"href":"https://api.github.com/repos/googlecartographer/cartographer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/googlecartographer/cartographer/pulls/1357/commits"},"statuses":{"href":"https://api.github.com/repos/googlecartographer/cartographer/statuses/29319b9be674fd1e0b03a9ac659a5da173663630"}},"author_association":"CONTRIBUTOR"}} | {
"id": 64732358,
"name": "googlecartographer/cartographer",
"url": "https://api.github.com/repos/googlecartographer/cartographer"
} | {
"id": 32522095,
"login": "pifon2a",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/32522095?",
"url": "https://api.github.com/users/pifon2a"
} | {
"id": 20636162,
"login": "googlecartographer",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/20636162?",
"url": "https://api.github.com/orgs/googlecartographer"
} | 2018-08-09T11:05:37 | 8089481817 | {"actor":{"display_login":"pifon2a"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/cumulus-nasa/cumulus/pulls/comments/168616448","pull_request_review_id":97015904,"id":168616448,"diff_hunk":"@@ -330,6 +330,33 @@ exports.listS3Objects = (bucket, prefix = null, skipFolders = true) => {\n });\n };\n \n+/**\n+ * Fetch complete list of S3 objects\n+ *\n+ * listObjectsV2 is limited to 1,000 results per call. This function continues\n+ * listing objects until there are no more to be fetched.\n+ *\n+ * The passed params must be compatible with the listObjectsV2 call.\n+ *\n+ * https://docs.aws.amazon.com/AWSJavaScriptSDK/latest/AWS/S3.html#listObjectsV2-property\n+ *\n+ * @param {Object} params - params for the s3.listObjectsV2 call\n+ * @returns {Promise.<Array>} - resolves to an array of objects corresponding to\n+ * the Contents property of the listObjectsV2 response\n+ */\n+async function listS3ObjectsV2(params) {\n+ const data = await exports.s3().listObjectsV2(params).promise();\n+\n+ if (data.IsTruncated) {\n+ const newParams = Object.assign({}, params);\n+ newParams.ContinuationToken = data.NextContinuationToken;\n+ return data.Contents.concat(await exports.listS3ObjectsV2(newParams));","path":"packages/common/aws.js","position":24,"original_position":24,"commit_id":"d6b144bac1d7424df3d490b0f972995813a27a64","original_commit_id":"d6b144bac1d7424df3d490b0f972995813a27a64","user":{"login":"yjpa7145","id":6790070,"avatar_url":"https://avatars2.githubusercontent.com/u/6790070?v=4","gravatar_id":"","url":"https://api.github.com/users/yjpa7145","html_url":"https://github.com/yjpa7145","followers_url":"https://api.github.com/users/yjpa7145/followers","following_url":"https://api.github.com/users/yjpa7145/following{/other_user}","gists_url":"https://api.github.com/users/yjpa7145/gists{/gist_id}","starred_url":"https://api.github.com/users/yjpa7145/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yjpa7145/subscriptions","organizations_url":"https://api.github.com/users/yjpa7145/orgs","repos_url":"https://api.github.com/users/yjpa7145/repos","events_url":"https://api.github.com/users/yjpa7145/events{/privacy}","received_events_url":"https://api.github.com/users/yjpa7145/received_events","type":"User","site_admin":false},"body":"The `await` here means that a Promise is returned.","created_at":"2018-02-15T21:40:08Z","updated_at":"2018-02-15T21:40:08Z","html_url":"https://github.com/cumulus-nasa/cumulus/pull/195#discussion_r168616448","pull_request_url":"https://api.github.com/repos/cumulus-nasa/cumulus/pulls/195","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/cumulus-nasa/cumulus/pulls/comments/168616448"},"html":{"href":"https://github.com/cumulus-nasa/cumulus/pull/195#discussion_r168616448"},"pull_request":{"href":"https://api.github.com/repos/cumulus-nasa/cumulus/pulls/195"}},"in_reply_to_id":168610568},"pull_request":{"url":"https://api.github.com/repos/cumulus-nasa/cumulus/pulls/195","id":169483038,"html_url":"https://github.com/cumulus-nasa/cumulus/pull/195","diff_url":"https://github.com/cumulus-nasa/cumulus/pull/195.diff","patch_url":"https://github.com/cumulus-nasa/cumulus/pull/195.patch","issue_url":"https://api.github.com/repos/cumulus-nasa/cumulus/issues/195","number":195,"state":"open","locked":false,"title":"Simplified S3 file listings","user":{"login":"yjpa7145","id":6790070,"avatar_url":"https://avatars2.githubusercontent.com/u/6790070?v=4","gravatar_id":"","url":"https://api.github.com/users/yjpa7145","html_url":"https://github.com/yjpa7145","followers_url":"https://api.github.com/users/yjpa7145/followers","following_url":"https://api.github.com/users/yjpa7145/following{/other_user}","gists_url":"https://api.github.com/users/yjpa7145/gists{/gist_id}","starred_url":"https://api.github.com/users/yjpa7145/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yjpa7145/subscriptions","organizations_url":"https://api.github.com/users/yjpa7145/orgs","repos_url":"https://api.github.com/users/yjpa7145/repos","events_url":"https://api.github.com/users/yjpa7145/events{/privacy}","received_events_url":"https://api.github.com/users/yjpa7145/received_events","type":"User","site_admin":false},"body":"Extract S3 list objects code from s3 module to common aws module.","created_at":"2018-02-15T20:57:03Z","updated_at":"2018-02-15T21:40:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f8351086c09ef92abd902c2f8ad1968293934e2d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/cumulus-nasa/cumulus/pulls/195/commits","review_comments_url":"https://api.github.com/repos/cumulus-nasa/cumulus/pulls/195/comments","review_comment_url":"https://api.github.com/repos/cumulus-nasa/cumulus/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cumulus-nasa/cumulus/issues/195/comments","statuses_url":"https://api.github.com/repos/cumulus-nasa/cumulus/statuses/d6b144bac1d7424df3d490b0f972995813a27a64","head":{"label":"cumulus-nasa:MoveS3ListToAws","ref":"MoveS3ListToAws","sha":"d6b144bac1d7424df3d490b0f972995813a27a64","user":{"login":"cumulus-nasa","id":20669771,"avatar_url":"https://avatars3.githubusercontent.com/u/20669771?v=4","gravatar_id":"","url":"https://api.github.com/users/cumulus-nasa","html_url":"https://github.com/cumulus-nasa","followers_url":"https://api.github.com/users/cumulus-nasa/followers","following_url":"https://api.github.com/users/cumulus-nasa/following{/other_user}","gists_url":"https://api.github.com/users/cumulus-nasa/gists{/gist_id}","starred_url":"https://api.github.com/users/cumulus-nasa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cumulus-nasa/subscriptions","organizations_url":"https://api.github.com/users/cumulus-nasa/orgs","repos_url":"https://api.github.com/users/cumulus-nasa/repos","events_url":"https://api.github.com/users/cumulus-nasa/events{/privacy}","received_events_url":"https://api.github.com/users/cumulus-nasa/received_events","type":"Organization","site_admin":false},"repo":{"id":95879196,"name":"cumulus","full_name":"cumulus-nasa/cumulus","owner":{"login":"cumulus-nasa","id":20669771,"avatar_url":"https://avatars3.githubusercontent.com/u/20669771?v=4","gravatar_id":"","url":"https://api.github.com/users/cumulus-nasa","html_url":"https://github.com/cumulus-nasa","followers_url":"https://api.github.com/users/cumulus-nasa/followers","following_url":"https://api.github.com/users/cumulus-nasa/following{/other_user}","gists_url":"https://api.github.com/users/cumulus-nasa/gists{/gist_id}","starred_url":"https://api.github.com/users/cumulus-nasa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cumulus-nasa/subscriptions","organizations_url":"https://api.github.com/users/cumulus-nasa/orgs","repos_url":"https://api.github.com/users/cumulus-nasa/repos","events_url":"https://api.github.com/users/cumulus-nasa/events{/privacy}","received_events_url":"https://api.github.com/users/cumulus-nasa/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cumulus-nasa/cumulus","description":"Cumulus Framework + Cumulus API","fork":false,"url":"https://api.github.com/repos/cumulus-nasa/cumulus","forks_url":"https://api.github.com/repos/cumulus-nasa/cumulus/forks","keys_url":"https://api.github.com/repos/cumulus-nasa/cumulus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cumulus-nasa/cumulus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cumulus-nasa/cumulus/teams","hooks_url":"https://api.github.com/repos/cumulus-nasa/cumulus/hooks","issue_events_url":"https://api.github.com/repos/cumulus-nasa/cumulus/issues/events{/number}","events_url":"https://api.github.com/repos/cumulus-nasa/cumulus/events","assignees_url":"https://api.github.com/repos/cumulus-nasa/cumulus/assignees{/user}","branches_url":"https://api.github.com/repos/cumulus-nasa/cumulus/branches{/branch}","tags_url":"https://api.github.com/repos/cumulus-nasa/cumulus/tags","blobs_url":"https://api.github.com/repos/cumulus-nasa/cumulus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cumulus-nasa/cumulus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cumulus-nasa/cumulus/git/refs{/sha}","trees_url":"https://api.github.com/repos/cumulus-nasa/cumulus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cumulus-nasa/cumulus/statuses/{sha}","languages_url":"https://api.github.com/repos/cumulus-nasa/cumulus/languages","stargazers_url":"https://api.github.com/repos/cumulus-nasa/cumulus/stargazers","contributors_url":"https://api.github.com/repos/cumulus-nasa/cumulus/contributors","subscribers_url":"https://api.github.com/repos/cumulus-nasa/cumulus/subscribers","subscription_url":"https://api.github.com/repos/cumulus-nasa/cumulus/subscription","commits_url":"https://api.github.com/repos/cumulus-nasa/cumulus/commits{/sha}","git_commits_url":"https://api.github.com/repos/cumulus-nasa/cumulus/git/commits{/sha}","comments_url":"https://api.github.com/repos/cumulus-nasa/cumulus/comments{/number}","issue_comment_url":"https://api.github.com/repos/cumulus-nasa/cumulus/issues/comments{/number}","contents_url":"https://api.github.com/repos/cumulus-nasa/cumulus/contents/{+path}","compare_url":"https://api.github.com/repos/cumulus-nasa/cumulus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cumulus-nasa/cumulus/merges","archive_url":"https://api.github.com/repos/cumulus-nasa/cumulus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cumulus-nasa/cumulus/downloads","issues_url":"https://api.github.com/repos/cumulus-nasa/cumulus/issues{/number}","pulls_url":"https://api.github.com/repos/cumulus-nasa/cumulus/pulls{/number}","milestones_url":"https://api.github.com/repos/cumulus-nasa/cumulus/milestones{/number}","notifications_url":"https://api.github.com/repos/cumulus-nasa/cumulus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cumulus-nasa/cumulus/labels{/name}","releases_url":"https://api.github.com/repos/cumulus-nasa/cumulus/releases{/id}","deployments_url":"https://api.github.com/repos/cumulus-nasa/cumulus/deployments","created_at":"2017-06-30T10:52:28Z","updated_at":"2018-01-24T19:59:16Z","pushed_at":"2018-02-15T20:57:04Z","git_url":"git://github.com/cumulus-nasa/cumulus.git","ssh_url":"[email protected]:cumulus-nasa/cumulus.git","clone_url":"https://github.com/cumulus-nasa/cumulus.git","svn_url":"https://github.com/cumulus-nasa/cumulus","homepage":"","size":55239,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":1,"open_issues":8,"watchers":2,"default_branch":"master"}},"base":{"label":"cumulus-nasa:s3syngran_mu","ref":"s3syngran_mu","sha":"3e278d3396351d0655ccbd66e51bd9d349a690ca","user":{"login":"cumulus-nasa","id":20669771,"avatar_url":"https://avatars3.githubusercontent.com/u/20669771?v=4","gravatar_id":"","url":"https://api.github.com/users/cumulus-nasa","html_url":"https://github.com/cumulus-nasa","followers_url":"https://api.github.com/users/cumulus-nasa/followers","following_url":"https://api.github.com/users/cumulus-nasa/following{/other_user}","gists_url":"https://api.github.com/users/cumulus-nasa/gists{/gist_id}","starred_url":"https://api.github.com/users/cumulus-nasa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cumulus-nasa/subscriptions","organizations_url":"https://api.github.com/users/cumulus-nasa/orgs","repos_url":"https://api.github.com/users/cumulus-nasa/repos","events_url":"https://api.github.com/users/cumulus-nasa/events{/privacy}","received_events_url":"https://api.github.com/users/cumulus-nasa/received_events","type":"Organization","site_admin":false},"repo":{"id":95879196,"name":"cumulus","full_name":"cumulus-nasa/cumulus","owner":{"login":"cumulus-nasa","id":20669771,"avatar_url":"https://avatars3.githubusercontent.com/u/20669771?v=4","gravatar_id":"","url":"https://api.github.com/users/cumulus-nasa","html_url":"https://github.com/cumulus-nasa","followers_url":"https://api.github.com/users/cumulus-nasa/followers","following_url":"https://api.github.com/users/cumulus-nasa/following{/other_user}","gists_url":"https://api.github.com/users/cumulus-nasa/gists{/gist_id}","starred_url":"https://api.github.com/users/cumulus-nasa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cumulus-nasa/subscriptions","organizations_url":"https://api.github.com/users/cumulus-nasa/orgs","repos_url":"https://api.github.com/users/cumulus-nasa/repos","events_url":"https://api.github.com/users/cumulus-nasa/events{/privacy}","received_events_url":"https://api.github.com/users/cumulus-nasa/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cumulus-nasa/cumulus","description":"Cumulus Framework + Cumulus API","fork":false,"url":"https://api.github.com/repos/cumulus-nasa/cumulus","forks_url":"https://api.github.com/repos/cumulus-nasa/cumulus/forks","keys_url":"https://api.github.com/repos/cumulus-nasa/cumulus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cumulus-nasa/cumulus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cumulus-nasa/cumulus/teams","hooks_url":"https://api.github.com/repos/cumulus-nasa/cumulus/hooks","issue_events_url":"https://api.github.com/repos/cumulus-nasa/cumulus/issues/events{/number}","events_url":"https://api.github.com/repos/cumulus-nasa/cumulus/events","assignees_url":"https://api.github.com/repos/cumulus-nasa/cumulus/assignees{/user}","branches_url":"https://api.github.com/repos/cumulus-nasa/cumulus/branches{/branch}","tags_url":"https://api.github.com/repos/cumulus-nasa/cumulus/tags","blobs_url":"https://api.github.com/repos/cumulus-nasa/cumulus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cumulus-nasa/cumulus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cumulus-nasa/cumulus/git/refs{/sha}","trees_url":"https://api.github.com/repos/cumulus-nasa/cumulus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cumulus-nasa/cumulus/statuses/{sha}","languages_url":"https://api.github.com/repos/cumulus-nasa/cumulus/languages","stargazers_url":"https://api.github.com/repos/cumulus-nasa/cumulus/stargazers","contributors_url":"https://api.github.com/repos/cumulus-nasa/cumulus/contributors","subscribers_url":"https://api.github.com/repos/cumulus-nasa/cumulus/subscribers","subscription_url":"https://api.github.com/repos/cumulus-nasa/cumulus/subscription","commits_url":"https://api.github.com/repos/cumulus-nasa/cumulus/commits{/sha}","git_commits_url":"https://api.github.com/repos/cumulus-nasa/cumulus/git/commits{/sha}","comments_url":"https://api.github.com/repos/cumulus-nasa/cumulus/comments{/number}","issue_comment_url":"https://api.github.com/repos/cumulus-nasa/cumulus/issues/comments{/number}","contents_url":"https://api.github.com/repos/cumulus-nasa/cumulus/contents/{+path}","compare_url":"https://api.github.com/repos/cumulus-nasa/cumulus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cumulus-nasa/cumulus/merges","archive_url":"https://api.github.com/repos/cumulus-nasa/cumulus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cumulus-nasa/cumulus/downloads","issues_url":"https://api.github.com/repos/cumulus-nasa/cumulus/issues{/number}","pulls_url":"https://api.github.com/repos/cumulus-nasa/cumulus/pulls{/number}","milestones_url":"https://api.github.com/repos/cumulus-nasa/cumulus/milestones{/number}","notifications_url":"https://api.github.com/repos/cumulus-nasa/cumulus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cumulus-nasa/cumulus/labels{/name}","releases_url":"https://api.github.com/repos/cumulus-nasa/cumulus/releases{/id}","deployments_url":"https://api.github.com/repos/cumulus-nasa/cumulus/deployments","created_at":"2017-06-30T10:52:28Z","updated_at":"2018-01-24T19:59:16Z","pushed_at":"2018-02-15T20:57:04Z","git_url":"git://github.com/cumulus-nasa/cumulus.git","ssh_url":"[email protected]:cumulus-nasa/cumulus.git","clone_url":"https://github.com/cumulus-nasa/cumulus.git","svn_url":"https://github.com/cumulus-nasa/cumulus","homepage":"","size":55239,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":1,"open_issues":8,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cumulus-nasa/cumulus/pulls/195"},"html":{"href":"https://github.com/cumulus-nasa/cumulus/pull/195"},"issue":{"href":"https://api.github.com/repos/cumulus-nasa/cumulus/issues/195"},"comments":{"href":"https://api.github.com/repos/cumulus-nasa/cumulus/issues/195/comments"},"review_comments":{"href":"https://api.github.com/repos/cumulus-nasa/cumulus/pulls/195/comments"},"review_comment":{"href":"https://api.github.com/repos/cumulus-nasa/cumulus/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cumulus-nasa/cumulus/pulls/195/commits"},"statuses":{"href":"https://api.github.com/repos/cumulus-nasa/cumulus/statuses/d6b144bac1d7424df3d490b0f972995813a27a64"}},"author_association":"CONTRIBUTOR"}} | {
"id": 95879196,
"name": "cumulus-nasa/cumulus",
"url": "https://api.github.com/repos/cumulus-nasa/cumulus"
} | {
"id": 6790070,
"login": "yjpa7145",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6790070?",
"url": "https://api.github.com/users/yjpa7145"
} | {
"id": 20669771,
"login": "cumulus-nasa",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/20669771?",
"url": "https://api.github.com/orgs/cumulus-nasa"
} | 2018-02-15T21:40:08 | 7252086522 | {"actor":{"display_login":"yjpa7145"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/rchain/rchain/pulls/comments/229344699","pull_request_review_id":169822807,"id":229344699,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyOTM0NDY5OQ==","diff_hunk":"@@ -371,10 +371,14 @@ class FineGrainedReplayRSpace[F[_], C, P, E, A, R, K](store: IStore[C, P, A, K],\n }\n }\n \n- override def clear(): F[Unit] = syncF.delay {\n- replayData.clear()\n- super.clear()\n- }\n+ override def clear(): F[Unit] =\n+ syncF\n+ .delay {\n+ replayData.clear()\n+ }\n+ .flatMap { _ =>\n+ super.clear()\n+ }","path":"rspace/src/main/scala/coop/rchain/rspace/spaces/FineGrainedReplayRSpace.scala","position":15,"original_position":15,"commit_id":"40c07baed5aef40de958f3987d9f890647af288e","original_commit_id":"5c85304dccaf5bbc4d8c4b7e48f60e3601dd7672","user":{"login":"KentShikama","id":6329898,"node_id":"MDQ6VXNlcjYzMjk4OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6329898?v=4","gravatar_id":"","url":"https://api.github.com/users/KentShikama","html_url":"https://github.com/KentShikama","followers_url":"https://api.github.com/users/KentShikama/followers","following_url":"https://api.github.com/users/KentShikama/following{/other_user}","gists_url":"https://api.github.com/users/KentShikama/gists{/gist_id}","starred_url":"https://api.github.com/users/KentShikama/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KentShikama/subscriptions","organizations_url":"https://api.github.com/users/KentShikama/orgs","repos_url":"https://api.github.com/users/KentShikama/repos","events_url":"https://api.github.com/users/KentShikama/events{/privacy}","received_events_url":"https://api.github.com/users/KentShikama/received_events","type":"User","site_admin":false},"body":"Yeah +1 on that `for/yield`","created_at":"2018-10-30T15:03:00Z","updated_at":"2018-10-30T15:03:26Z","html_url":"https://github.com/rchain/rchain/pull/1762#discussion_r229344699","pull_request_url":"https://api.github.com/repos/rchain/rchain/pulls/1762","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/rchain/rchain/pulls/comments/229344699"},"html":{"href":"https://github.com/rchain/rchain/pull/1762#discussion_r229344699"},"pull_request":{"href":"https://api.github.com/repos/rchain/rchain/pulls/1762"}},"in_reply_to_id":229227747},"pull_request":{"url":"https://api.github.com/repos/rchain/rchain/pulls/1762","id":226646467,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2NjQ2NDY3","html_url":"https://github.com/rchain/rchain/pull/1762","diff_url":"https://github.com/rchain/rchain/pull/1762.diff","patch_url":"https://github.com/rchain/rchain/pull/1762.patch","issue_url":"https://api.github.com/repos/rchain/rchain/issues/1762","number":1762,"state":"open","locked":false,"title":"Remove cats.Id from Runtime (and dependencies)","user":{"login":"lukasz-golebiewski","id":6169602,"node_id":"MDQ6VXNlcjYxNjk2MDI=","avatar_url":"https://avatars1.githubusercontent.com/u/6169602?v=4","gravatar_id":"","url":"https://api.github.com/users/lukasz-golebiewski","html_url":"https://github.com/lukasz-golebiewski","followers_url":"https://api.github.com/users/lukasz-golebiewski/followers","following_url":"https://api.github.com/users/lukasz-golebiewski/following{/other_user}","gists_url":"https://api.github.com/users/lukasz-golebiewski/gists{/gist_id}","starred_url":"https://api.github.com/users/lukasz-golebiewski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukasz-golebiewski/subscriptions","organizations_url":"https://api.github.com/users/lukasz-golebiewski/orgs","repos_url":"https://api.github.com/users/lukasz-golebiewski/repos","events_url":"https://api.github.com/users/lukasz-golebiewski/events{/privacy}","received_events_url":"https://api.github.com/users/lukasz-golebiewski/received_events","type":"User","site_admin":false},"body":"## Overview\r\nTitle says all. We want to get rid of the Id monad in production code (and it's effects)\r\n\r\n### Which JIRA issue does this PR relate to? If there is not a JIRA issue addressing this work, please create one now and add the link here.\r\nhttps://rchain.atlassian.net/browse/CORE-1267\r\n\r\n### Complete this checklist before you submit the PR\r\n- [x] This PR contains no more than 200 lines of code, excluding test code.\r\n- [x] This PR meets [RChain development coding standards](https://rchain.atlassian.net/wiki/spaces/DOC/pages/28082177/Coding+Standards).\r\n- [x] If this PR adds a new feature, this PR includes tests related to this feature.\r\n- [x] You assigned one person to review this PR\r\n\r\n### Notes\r\nOptional. Add any notes on caveats, approaches you tried that didn't work, or anything else.\r\n","created_at":"2018-10-29T17:22:11Z","updated_at":"2018-10-30T15:03:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9b23deaf21e617301f656ed5036fd3b41f07ff31","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/rchain/rchain/pulls/1762/commits","review_comments_url":"https://api.github.com/repos/rchain/rchain/pulls/1762/comments","review_comment_url":"https://api.github.com/repos/rchain/rchain/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rchain/rchain/issues/1762/comments","statuses_url":"https://api.github.com/repos/rchain/rchain/statuses/40c07baed5aef40de958f3987d9f890647af288e","head":{"label":"lukasz-golebiewski:refactoring/remove-id-from-runtime","ref":"refactoring/remove-id-from-runtime","sha":"40c07baed5aef40de958f3987d9f890647af288e","user":{"login":"lukasz-golebiewski","id":6169602,"node_id":"MDQ6VXNlcjYxNjk2MDI=","avatar_url":"https://avatars1.githubusercontent.com/u/6169602?v=4","gravatar_id":"","url":"https://api.github.com/users/lukasz-golebiewski","html_url":"https://github.com/lukasz-golebiewski","followers_url":"https://api.github.com/users/lukasz-golebiewski/followers","following_url":"https://api.github.com/users/lukasz-golebiewski/following{/other_user}","gists_url":"https://api.github.com/users/lukasz-golebiewski/gists{/gist_id}","starred_url":"https://api.github.com/users/lukasz-golebiewski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukasz-golebiewski/subscriptions","organizations_url":"https://api.github.com/users/lukasz-golebiewski/orgs","repos_url":"https://api.github.com/users/lukasz-golebiewski/repos","events_url":"https://api.github.com/users/lukasz-golebiewski/events{/privacy}","received_events_url":"https://api.github.com/users/lukasz-golebiewski/received_events","type":"User","site_admin":false},"repo":{"id":133328145,"node_id":"MDEwOlJlcG9zaXRvcnkxMzMzMjgxNDU=","name":"rchain","full_name":"lukasz-golebiewski/rchain","private":false,"owner":{"login":"lukasz-golebiewski","id":6169602,"node_id":"MDQ6VXNlcjYxNjk2MDI=","avatar_url":"https://avatars1.githubusercontent.com/u/6169602?v=4","gravatar_id":"","url":"https://api.github.com/users/lukasz-golebiewski","html_url":"https://github.com/lukasz-golebiewski","followers_url":"https://api.github.com/users/lukasz-golebiewski/followers","following_url":"https://api.github.com/users/lukasz-golebiewski/following{/other_user}","gists_url":"https://api.github.com/users/lukasz-golebiewski/gists{/gist_id}","starred_url":"https://api.github.com/users/lukasz-golebiewski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukasz-golebiewski/subscriptions","organizations_url":"https://api.github.com/users/lukasz-golebiewski/orgs","repos_url":"https://api.github.com/users/lukasz-golebiewski/repos","events_url":"https://api.github.com/users/lukasz-golebiewski/events{/privacy}","received_events_url":"https://api.github.com/users/lukasz-golebiewski/received_events","type":"User","site_admin":false},"html_url":"https://github.com/lukasz-golebiewski/rchain","description":null,"fork":true,"url":"https://api.github.com/repos/lukasz-golebiewski/rchain","forks_url":"https://api.github.com/repos/lukasz-golebiewski/rchain/forks","keys_url":"https://api.github.com/repos/lukasz-golebiewski/rchain/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lukasz-golebiewski/rchain/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lukasz-golebiewski/rchain/teams","hooks_url":"https://api.github.com/repos/lukasz-golebiewski/rchain/hooks","issue_events_url":"https://api.github.com/repos/lukasz-golebiewski/rchain/issues/events{/number}","events_url":"https://api.github.com/repos/lukasz-golebiewski/rchain/events","assignees_url":"https://api.github.com/repos/lukasz-golebiewski/rchain/assignees{/user}","branches_url":"https://api.github.com/repos/lukasz-golebiewski/rchain/branches{/branch}","tags_url":"https://api.github.com/repos/lukasz-golebiewski/rchain/tags","blobs_url":"https://api.github.com/repos/lukasz-golebiewski/rchain/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lukasz-golebiewski/rchain/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lukasz-golebiewski/rchain/git/refs{/sha}","trees_url":"https://api.github.com/repos/lukasz-golebiewski/rchain/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lukasz-golebiewski/rchain/statuses/{sha}","languages_url":"https://api.github.com/repos/lukasz-golebiewski/rchain/languages","stargazers_url":"https://api.github.com/repos/lukasz-golebiewski/rchain/stargazers","contributors_url":"https://api.github.com/repos/lukasz-golebiewski/rchain/contributors","subscribers_url":"https://api.github.com/repos/lukasz-golebiewski/rchain/subscribers","subscription_url":"https://api.github.com/repos/lukasz-golebiewski/rchain/subscription","commits_url":"https://api.github.com/repos/lukasz-golebiewski/rchain/commits{/sha}","git_commits_url":"https://api.github.com/repos/lukasz-golebiewski/rchain/git/commits{/sha}","comments_url":"https://api.github.com/repos/lukasz-golebiewski/rchain/comments{/number}","issue_comment_url":"https://api.github.com/repos/lukasz-golebiewski/rchain/issues/comments{/number}","contents_url":"https://api.github.com/repos/lukasz-golebiewski/rchain/contents/{+path}","compare_url":"https://api.github.com/repos/lukasz-golebiewski/rchain/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lukasz-golebiewski/rchain/merges","archive_url":"https://api.github.com/repos/lukasz-golebiewski/rchain/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lukasz-golebiewski/rchain/downloads","issues_url":"https://api.github.com/repos/lukasz-golebiewski/rchain/issues{/number}","pulls_url":"https://api.github.com/repos/lukasz-golebiewski/rchain/pulls{/number}","milestones_url":"https://api.github.com/repos/lukasz-golebiewski/rchain/milestones{/number}","notifications_url":"https://api.github.com/repos/lukasz-golebiewski/rchain/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lukasz-golebiewski/rchain/labels{/name}","releases_url":"https://api.github.com/repos/lukasz-golebiewski/rchain/releases{/id}","deployments_url":"https://api.github.com/repos/lukasz-golebiewski/rchain/deployments","created_at":"2018-05-14T08:19:49Z","updated_at":"2018-05-14T08:19:53Z","pushed_at":"2018-10-30T14:45:13Z","git_url":"git://github.com/lukasz-golebiewski/rchain.git","ssh_url":"[email protected]:lukasz-golebiewski/rchain.git","clone_url":"https://github.com/lukasz-golebiewski/rchain.git","svn_url":"https://github.com/lukasz-golebiewski/rchain","homepage":null,"size":19098,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rchain:dev","ref":"dev","sha":"c187fd1f4dc750ecdd8c21199df2bca5ecfb0aee","user":{"login":"rchain","id":20671765,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNjcxNzY1","avatar_url":"https://avatars0.githubusercontent.com/u/20671765?v=4","gravatar_id":"","url":"https://api.github.com/users/rchain","html_url":"https://github.com/rchain","followers_url":"https://api.github.com/users/rchain/followers","following_url":"https://api.github.com/users/rchain/following{/other_user}","gists_url":"https://api.github.com/users/rchain/gists{/gist_id}","starred_url":"https://api.github.com/users/rchain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rchain/subscriptions","organizations_url":"https://api.github.com/users/rchain/orgs","repos_url":"https://api.github.com/users/rchain/repos","events_url":"https://api.github.com/users/rchain/events{/privacy}","received_events_url":"https://api.github.com/users/rchain/received_events","type":"Organization","site_admin":false},"repo":{"id":84493691,"node_id":"MDEwOlJlcG9zaXRvcnk4NDQ5MzY5MQ==","name":"rchain","full_name":"rchain/rchain","private":false,"owner":{"login":"rchain","id":20671765,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNjcxNzY1","avatar_url":"https://avatars0.githubusercontent.com/u/20671765?v=4","gravatar_id":"","url":"https://api.github.com/users/rchain","html_url":"https://github.com/rchain","followers_url":"https://api.github.com/users/rchain/followers","following_url":"https://api.github.com/users/rchain/following{/other_user}","gists_url":"https://api.github.com/users/rchain/gists{/gist_id}","starred_url":"https://api.github.com/users/rchain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rchain/subscriptions","organizations_url":"https://api.github.com/users/rchain/orgs","repos_url":"https://api.github.com/users/rchain/repos","events_url":"https://api.github.com/users/rchain/events{/privacy}","received_events_url":"https://api.github.com/users/rchain/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/rchain/rchain","description":null,"fork":false,"url":"https://api.github.com/repos/rchain/rchain","forks_url":"https://api.github.com/repos/rchain/rchain/forks","keys_url":"https://api.github.com/repos/rchain/rchain/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rchain/rchain/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rchain/rchain/teams","hooks_url":"https://api.github.com/repos/rchain/rchain/hooks","issue_events_url":"https://api.github.com/repos/rchain/rchain/issues/events{/number}","events_url":"https://api.github.com/repos/rchain/rchain/events","assignees_url":"https://api.github.com/repos/rchain/rchain/assignees{/user}","branches_url":"https://api.github.com/repos/rchain/rchain/branches{/branch}","tags_url":"https://api.github.com/repos/rchain/rchain/tags","blobs_url":"https://api.github.com/repos/rchain/rchain/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rchain/rchain/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rchain/rchain/git/refs{/sha}","trees_url":"https://api.github.com/repos/rchain/rchain/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rchain/rchain/statuses/{sha}","languages_url":"https://api.github.com/repos/rchain/rchain/languages","stargazers_url":"https://api.github.com/repos/rchain/rchain/stargazers","contributors_url":"https://api.github.com/repos/rchain/rchain/contributors","subscribers_url":"https://api.github.com/repos/rchain/rchain/subscribers","subscription_url":"https://api.github.com/repos/rchain/rchain/subscription","commits_url":"https://api.github.com/repos/rchain/rchain/commits{/sha}","git_commits_url":"https://api.github.com/repos/rchain/rchain/git/commits{/sha}","comments_url":"https://api.github.com/repos/rchain/rchain/comments{/number}","issue_comment_url":"https://api.github.com/repos/rchain/rchain/issues/comments{/number}","contents_url":"https://api.github.com/repos/rchain/rchain/contents/{+path}","compare_url":"https://api.github.com/repos/rchain/rchain/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rchain/rchain/merges","archive_url":"https://api.github.com/repos/rchain/rchain/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rchain/rchain/downloads","issues_url":"https://api.github.com/repos/rchain/rchain/issues{/number}","pulls_url":"https://api.github.com/repos/rchain/rchain/pulls{/number}","milestones_url":"https://api.github.com/repos/rchain/rchain/milestones{/number}","notifications_url":"https://api.github.com/repos/rchain/rchain/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rchain/rchain/labels{/name}","releases_url":"https://api.github.com/repos/rchain/rchain/releases{/id}","deployments_url":"https://api.github.com/repos/rchain/rchain/deployments","created_at":"2017-03-09T22:15:35Z","updated_at":"2018-10-30T14:04:50Z","pushed_at":"2018-10-30T15:00:47Z","git_url":"git://github.com/rchain/rchain.git","ssh_url":"[email protected]:rchain/rchain.git","clone_url":"https://github.com/rchain/rchain.git","svn_url":"https://github.com/rchain/rchain","homepage":null,"size":19107,"stargazers_count":467,"watchers_count":467,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":134,"mirror_url":null,"archived":false,"open_issues_count":31,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":134,"open_issues":31,"watchers":467,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/rchain/rchain/pulls/1762"},"html":{"href":"https://github.com/rchain/rchain/pull/1762"},"issue":{"href":"https://api.github.com/repos/rchain/rchain/issues/1762"},"comments":{"href":"https://api.github.com/repos/rchain/rchain/issues/1762/comments"},"review_comments":{"href":"https://api.github.com/repos/rchain/rchain/pulls/1762/comments"},"review_comment":{"href":"https://api.github.com/repos/rchain/rchain/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rchain/rchain/pulls/1762/commits"},"statuses":{"href":"https://api.github.com/repos/rchain/rchain/statuses/40c07baed5aef40de958f3987d9f890647af288e"}},"author_association":"COLLABORATOR"}} | {
"id": 84493691,
"name": "rchain/rchain",
"url": "https://api.github.com/repos/rchain/rchain"
} | {
"id": 6329898,
"login": "KentShikama",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6329898?",
"url": "https://api.github.com/users/KentShikama"
} | {
"id": 20671765,
"login": "rchain",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/20671765?",
"url": "https://api.github.com/orgs/rchain"
} | 2018-10-30T15:03:00 | 8505752190 | {"actor":{"display_login":"KentShikama"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/StackStorm-Exchange/stackstorm-vsphere/pulls/comments/223139839","pull_request_review_id":162205309,"id":223139839,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMzEzOTgzOQ==","diff_hunk":"@@ -0,0 +1,45 @@\n+# Licensed to the StackStorm, Inc ('StackStorm') under one or more\n+# contributor license agreements. See the NOTICE file distributed with\n+# this work for additional information regarding copyright ownership.\n+# The ASF licenses this file to You under the Apache License, Version 2.0\n+# (the \"License\"); you may not use this file except in compliance with\n+# the License. You may obtain a copy of the License at\n+#\n+# http://www.apache.org/licenses/LICENSE-2.0\n+#\n+# Unless required by applicable law or agreed to in writing, software\n+# distributed under the License is distributed on an \"AS IS\" BASIS,\n+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+# See the License for the specific language governing permissions and\n+# limitations under the License.\n+\n+from vmwarelib import guest\n+from vmwarelib import inventory\n+from vmwarelib.actions import BaseAction\n+\n+\n+class InitiateFileTransferToGuest(BaseAction):\n+\n+ def run(self, vm_id, username, password, directory, localpath,\n+ vsphere=None):\n+ \"\"\"\n+ Upload a file to a directory inside a guest.\n+\n+ Args:\n+ - vm_id: MOID of the Virtual Machine\n+ - username: username to perform the operation\n+ - password: password of that user\n+ - directory: Directory name in the guest to store the file\n+ - localpath: The path to the local file consisting of the\n+ - path type (pack|path), then a colon, then\n+ - a path.\n+ - examples: pack:packname/path-inside-pack/to/file\n+ - path:/full/path/to/file","path":"actions/guest_file_upload.py","position":37,"original_position":37,"commit_id":"27821ad45cd4011d6dcbde6757c03ec8da589af5","original_commit_id":"27821ad45cd4011d6dcbde6757c03ec8da589af5","user":{"login":"LindsayHill","id":3607046,"node_id":"MDQ6VXNlcjM2MDcwNDY=","avatar_url":"https://avatars2.githubusercontent.com/u/3607046?v=4","gravatar_id":"","url":"https://api.github.com/users/LindsayHill","html_url":"https://github.com/LindsayHill","followers_url":"https://api.github.com/users/LindsayHill/followers","following_url":"https://api.github.com/users/LindsayHill/following{/other_user}","gists_url":"https://api.github.com/users/LindsayHill/gists{/gist_id}","starred_url":"https://api.github.com/users/LindsayHill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LindsayHill/subscriptions","organizations_url":"https://api.github.com/users/LindsayHill/orgs","repos_url":"https://api.github.com/users/LindsayHill/repos","events_url":"https://api.github.com/users/LindsayHill/events{/privacy}","received_events_url":"https://api.github.com/users/LindsayHill/received_events","type":"User","site_admin":false},"body":"I'm really not a fan of this style of handling paths. I'd rather just specify a path, because I don't think that other people will be putting their files into their own pack, but will instead use a different location. \r\n\r\nBut maybe I'm in the minority here. I'd like to get some input from other pack contributors before merging this.","created_at":"2018-10-05T21:11:19Z","updated_at":"2018-10-05T21:11:20Z","html_url":"https://github.com/StackStorm-Exchange/stackstorm-vsphere/pull/34#discussion_r223139839","pull_request_url":"https://api.github.com/repos/StackStorm-Exchange/stackstorm-vsphere/pulls/34","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/StackStorm-Exchange/stackstorm-vsphere/pulls/comments/223139839"},"html":{"href":"https://github.com/StackStorm-Exchange/stackstorm-vsphere/pull/34#discussion_r223139839"},"pull_request":{"href":"https://api.github.com/repos/StackStorm-Exchange/stackstorm-vsphere/pulls/34"}}},"pull_request":{"url":"https://api.github.com/repos/StackStorm-Exchange/stackstorm-vsphere/pulls/34","id":219493383,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5NDkzMzgz","html_url":"https://github.com/StackStorm-Exchange/stackstorm-vsphere/pull/34","diff_url":"https://github.com/StackStorm-Exchange/stackstorm-vsphere/pull/34.diff","patch_url":"https://github.com/StackStorm-Exchange/stackstorm-vsphere/pull/34.patch","issue_url":"https://api.github.com/repos/StackStorm-Exchange/stackstorm-vsphere/issues/34","number":34,"state":"open","locked":false,"title":"Add some actions enabling Guest Operations APIs","user":{"login":"jeking3","id":11771245,"node_id":"MDQ6VXNlcjExNzcxMjQ1","avatar_url":"https://avatars2.githubusercontent.com/u/11771245?v=4","gravatar_id":"","url":"https://api.github.com/users/jeking3","html_url":"https://github.com/jeking3","followers_url":"https://api.github.com/users/jeking3/followers","following_url":"https://api.github.com/users/jeking3/following{/other_user}","gists_url":"https://api.github.com/users/jeking3/gists{/gist_id}","starred_url":"https://api.github.com/users/jeking3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeking3/subscriptions","organizations_url":"https://api.github.com/users/jeking3/orgs","repos_url":"https://api.github.com/users/jeking3/repos","events_url":"https://api.github.com/users/jeking3/events{/privacy}","received_events_url":"https://api.github.com/users/jeking3/received_events","type":"User","site_admin":false},"body":"Includes an Orquesta Workflow that allows one to run a script inside a guest and obtain the output.\r\n\r\nThis has been tested against a Windows guest, and has no unit tests right now. It handles script success and failure, and the top level action reflects that state. With PowerShell it looks like the exit_code is 1 for any non-zero exit code the script returns. I haven't been able to get the \"-File\" argument to work with PowerShell that might allow it to return the error code properly. It may not handle all error cases properly. It does however provide some useful functionality and I'm looking for input from folks involved with the project as to how to improve it further.","created_at":"2018-10-01T19:46:56Z","updated_at":"2018-10-05T21:11:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"68b8f6353f1cf3cd0f4dd332bc99f1c53e9c58aa","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/StackStorm-Exchange/stackstorm-vsphere/pulls/34/commits","review_comments_url":"https://api.github.com/repos/StackStorm-Exchange/stackstorm-vsphere/pulls/34/comments","review_comment_url":"https://api.github.com/repos/StackStorm-Exchange/stackstorm-vsphere/pulls/comments{/number}","comments_url":"https://api.github.com/repos/StackStorm-Exchange/stackstorm-vsphere/issues/34/comments","statuses_url":"https://api.github.com/repos/StackStorm-Exchange/stackstorm-vsphere/statuses/27821ad45cd4011d6dcbde6757c03ec8da589af5","head":{"label":"jeking3:guestops","ref":"guestops","sha":"27821ad45cd4011d6dcbde6757c03ec8da589af5","user":{"login":"jeking3","id":11771245,"node_id":"MDQ6VXNlcjExNzcxMjQ1","avatar_url":"https://avatars2.githubusercontent.com/u/11771245?v=4","gravatar_id":"","url":"https://api.github.com/users/jeking3","html_url":"https://github.com/jeking3","followers_url":"https://api.github.com/users/jeking3/followers","following_url":"https://api.github.com/users/jeking3/following{/other_user}","gists_url":"https://api.github.com/users/jeking3/gists{/gist_id}","starred_url":"https://api.github.com/users/jeking3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeking3/subscriptions","organizations_url":"https://api.github.com/users/jeking3/orgs","repos_url":"https://api.github.com/users/jeking3/repos","events_url":"https://api.github.com/users/jeking3/events{/privacy}","received_events_url":"https://api.github.com/users/jeking3/received_events","type":"User","site_admin":false},"repo":{"id":150738908,"node_id":"MDEwOlJlcG9zaXRvcnkxNTA3Mzg5MDg=","name":"stackstorm-vsphere","full_name":"jeking3/stackstorm-vsphere","private":false,"owner":{"login":"jeking3","id":11771245,"node_id":"MDQ6VXNlcjExNzcxMjQ1","avatar_url":"https://avatars2.githubusercontent.com/u/11771245?v=4","gravatar_id":"","url":"https://api.github.com/users/jeking3","html_url":"https://github.com/jeking3","followers_url":"https://api.github.com/users/jeking3/followers","following_url":"https://api.github.com/users/jeking3/following{/other_user}","gists_url":"https://api.github.com/users/jeking3/gists{/gist_id}","starred_url":"https://api.github.com/users/jeking3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeking3/subscriptions","organizations_url":"https://api.github.com/users/jeking3/orgs","repos_url":"https://api.github.com/users/jeking3/repos","events_url":"https://api.github.com/users/jeking3/events{/privacy}","received_events_url":"https://api.github.com/users/jeking3/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jeking3/stackstorm-vsphere","description":null,"fork":true,"url":"https://api.github.com/repos/jeking3/stackstorm-vsphere","forks_url":"https://api.github.com/repos/jeking3/stackstorm-vsphere/forks","keys_url":"https://api.github.com/repos/jeking3/stackstorm-vsphere/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jeking3/stackstorm-vsphere/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jeking3/stackstorm-vsphere/teams","hooks_url":"https://api.github.com/repos/jeking3/stackstorm-vsphere/hooks","issue_events_url":"https://api.github.com/repos/jeking3/stackstorm-vsphere/issues/events{/number}","events_url":"https://api.github.com/repos/jeking3/stackstorm-vsphere/events","assignees_url":"https://api.github.com/repos/jeking3/stackstorm-vsphere/assignees{/user}","branches_url":"https://api.github.com/repos/jeking3/stackstorm-vsphere/branches{/branch}","tags_url":"https://api.github.com/repos/jeking3/stackstorm-vsphere/tags","blobs_url":"https://api.github.com/repos/jeking3/stackstorm-vsphere/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jeking3/stackstorm-vsphere/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jeking3/stackstorm-vsphere/git/refs{/sha}","trees_url":"https://api.github.com/repos/jeking3/stackstorm-vsphere/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jeking3/stackstorm-vsphere/statuses/{sha}","languages_url":"https://api.github.com/repos/jeking3/stackstorm-vsphere/languages","stargazers_url":"https://api.github.com/repos/jeking3/stackstorm-vsphere/stargazers","contributors_url":"https://api.github.com/repos/jeking3/stackstorm-vsphere/contributors","subscribers_url":"https://api.github.com/repos/jeking3/stackstorm-vsphere/subscribers","subscription_url":"https://api.github.com/repos/jeking3/stackstorm-vsphere/subscription","commits_url":"https://api.github.com/repos/jeking3/stackstorm-vsphere/commits{/sha}","git_commits_url":"https://api.github.com/repos/jeking3/stackstorm-vsphere/git/commits{/sha}","comments_url":"https://api.github.com/repos/jeking3/stackstorm-vsphere/comments{/number}","issue_comment_url":"https://api.github.com/repos/jeking3/stackstorm-vsphere/issues/comments{/number}","contents_url":"https://api.github.com/repos/jeking3/stackstorm-vsphere/contents/{+path}","compare_url":"https://api.github.com/repos/jeking3/stackstorm-vsphere/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jeking3/stackstorm-vsphere/merges","archive_url":"https://api.github.com/repos/jeking3/stackstorm-vsphere/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jeking3/stackstorm-vsphere/downloads","issues_url":"https://api.github.com/repos/jeking3/stackstorm-vsphere/issues{/number}","pulls_url":"https://api.github.com/repos/jeking3/stackstorm-vsphere/pulls{/number}","milestones_url":"https://api.github.com/repos/jeking3/stackstorm-vsphere/milestones{/number}","notifications_url":"https://api.github.com/repos/jeking3/stackstorm-vsphere/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jeking3/stackstorm-vsphere/labels{/name}","releases_url":"https://api.github.com/repos/jeking3/stackstorm-vsphere/releases{/id}","deployments_url":"https://api.github.com/repos/jeking3/stackstorm-vsphere/deployments","created_at":"2018-09-28T12:42:09Z","updated_at":"2018-09-28T12:43:07Z","pushed_at":"2018-10-05T20:31:07Z","git_url":"git://github.com/jeking3/stackstorm-vsphere.git","ssh_url":"[email protected]:jeking3/stackstorm-vsphere.git","clone_url":"https://github.com/jeking3/stackstorm-vsphere.git","svn_url":"https://github.com/jeking3/stackstorm-vsphere","homepage":null,"size":215,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"StackStorm-Exchange:master","ref":"master","sha":"35e296cd79f8d166060ee5433db354e73a0c2746","user":{"login":"StackStorm-Exchange","id":20677668,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNjc3NjY4","avatar_url":"https://avatars2.githubusercontent.com/u/20677668?v=4","gravatar_id":"","url":"https://api.github.com/users/StackStorm-Exchange","html_url":"https://github.com/StackStorm-Exchange","followers_url":"https://api.github.com/users/StackStorm-Exchange/followers","following_url":"https://api.github.com/users/StackStorm-Exchange/following{/other_user}","gists_url":"https://api.github.com/users/StackStorm-Exchange/gists{/gist_id}","starred_url":"https://api.github.com/users/StackStorm-Exchange/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StackStorm-Exchange/subscriptions","organizations_url":"https://api.github.com/users/StackStorm-Exchange/orgs","repos_url":"https://api.github.com/users/StackStorm-Exchange/repos","events_url":"https://api.github.com/users/StackStorm-Exchange/events{/privacy}","received_events_url":"https://api.github.com/users/StackStorm-Exchange/received_events","type":"Organization","site_admin":false},"repo":{"id":75044451,"node_id":"MDEwOlJlcG9zaXRvcnk3NTA0NDQ1MQ==","name":"stackstorm-vsphere","full_name":"StackStorm-Exchange/stackstorm-vsphere","private":false,"owner":{"login":"StackStorm-Exchange","id":20677668,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNjc3NjY4","avatar_url":"https://avatars2.githubusercontent.com/u/20677668?v=4","gravatar_id":"","url":"https://api.github.com/users/StackStorm-Exchange","html_url":"https://github.com/StackStorm-Exchange","followers_url":"https://api.github.com/users/StackStorm-Exchange/followers","following_url":"https://api.github.com/users/StackStorm-Exchange/following{/other_user}","gists_url":"https://api.github.com/users/StackStorm-Exchange/gists{/gist_id}","starred_url":"https://api.github.com/users/StackStorm-Exchange/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StackStorm-Exchange/subscriptions","organizations_url":"https://api.github.com/users/StackStorm-Exchange/orgs","repos_url":"https://api.github.com/users/StackStorm-Exchange/repos","events_url":"https://api.github.com/users/StackStorm-Exchange/events{/privacy}","received_events_url":"https://api.github.com/users/StackStorm-Exchange/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/StackStorm-Exchange/stackstorm-vsphere","description":null,"fork":false,"url":"https://api.github.com/repos/StackStorm-Exchange/stackstorm-vsphere","forks_url":"https://api.github.com/repos/StackStorm-Exchange/stackstorm-vsphere/forks","keys_url":"https://api.github.com/repos/StackStorm-Exchange/stackstorm-vsphere/keys{/key_id}","collaborators_url":"https://api.github.com/repos/StackStorm-Exchange/stackstorm-vsphere/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/StackStorm-Exchange/stackstorm-vsphere/teams","hooks_url":"https://api.github.com/repos/StackStorm-Exchange/stackstorm-vsphere/hooks","issue_events_url":"https://api.github.com/repos/StackStorm-Exchange/stackstorm-vsphere/issues/events{/number}","events_url":"https://api.github.com/repos/StackStorm-Exchange/stackstorm-vsphere/events","assignees_url":"https://api.github.com/repos/StackStorm-Exchange/stackstorm-vsphere/assignees{/user}","branches_url":"https://api.github.com/repos/StackStorm-Exchange/stackstorm-vsphere/branches{/branch}","tags_url":"https://api.github.com/repos/StackStorm-Exchange/stackstorm-vsphere/tags","blobs_url":"https://api.github.com/repos/StackStorm-Exchange/stackstorm-vsphere/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/StackStorm-Exchange/stackstorm-vsphere/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/StackStorm-Exchange/stackstorm-vsphere/git/refs{/sha}","trees_url":"https://api.github.com/repos/StackStorm-Exchange/stackstorm-vsphere/git/trees{/sha}","statuses_url":"https://api.github.com/repos/StackStorm-Exchange/stackstorm-vsphere/statuses/{sha}","languages_url":"https://api.github.com/repos/StackStorm-Exchange/stackstorm-vsphere/languages","stargazers_url":"https://api.github.com/repos/StackStorm-Exchange/stackstorm-vsphere/stargazers","contributors_url":"https://api.github.com/repos/StackStorm-Exchange/stackstorm-vsphere/contributors","subscribers_url":"https://api.github.com/repos/StackStorm-Exchange/stackstorm-vsphere/subscribers","subscription_url":"https://api.github.com/repos/StackStorm-Exchange/stackstorm-vsphere/subscription","commits_url":"https://api.github.com/repos/StackStorm-Exchange/stackstorm-vsphere/commits{/sha}","git_commits_url":"https://api.github.com/repos/StackStorm-Exchange/stackstorm-vsphere/git/commits{/sha}","comments_url":"https://api.github.com/repos/StackStorm-Exchange/stackstorm-vsphere/comments{/number}","issue_comment_url":"https://api.github.com/repos/StackStorm-Exchange/stackstorm-vsphere/issues/comments{/number}","contents_url":"https://api.github.com/repos/StackStorm-Exchange/stackstorm-vsphere/contents/{+path}","compare_url":"https://api.github.com/repos/StackStorm-Exchange/stackstorm-vsphere/compare/{base}...{head}","merges_url":"https://api.github.com/repos/StackStorm-Exchange/stackstorm-vsphere/merges","archive_url":"https://api.github.com/repos/StackStorm-Exchange/stackstorm-vsphere/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/StackStorm-Exchange/stackstorm-vsphere/downloads","issues_url":"https://api.github.com/repos/StackStorm-Exchange/stackstorm-vsphere/issues{/number}","pulls_url":"https://api.github.com/repos/StackStorm-Exchange/stackstorm-vsphere/pulls{/number}","milestones_url":"https://api.github.com/repos/StackStorm-Exchange/stackstorm-vsphere/milestones{/number}","notifications_url":"https://api.github.com/repos/StackStorm-Exchange/stackstorm-vsphere/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/StackStorm-Exchange/stackstorm-vsphere/labels{/name}","releases_url":"https://api.github.com/repos/StackStorm-Exchange/stackstorm-vsphere/releases{/id}","deployments_url":"https://api.github.com/repos/StackStorm-Exchange/stackstorm-vsphere/deployments","created_at":"2016-11-29T04:51:50Z","updated_at":"2018-08-16T16:18:37Z","pushed_at":"2018-10-05T20:31:08Z","git_url":"git://github.com/StackStorm-Exchange/stackstorm-vsphere.git","ssh_url":"[email protected]:StackStorm-Exchange/stackstorm-vsphere.git","clone_url":"https://github.com/StackStorm-Exchange/stackstorm-vsphere.git","svn_url":"https://github.com/StackStorm-Exchange/stackstorm-vsphere","homepage":null,"size":207,"stargazers_count":4,"watchers_count":4,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":5,"license":null,"forks":8,"open_issues":5,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/StackStorm-Exchange/stackstorm-vsphere/pulls/34"},"html":{"href":"https://github.com/StackStorm-Exchange/stackstorm-vsphere/pull/34"},"issue":{"href":"https://api.github.com/repos/StackStorm-Exchange/stackstorm-vsphere/issues/34"},"comments":{"href":"https://api.github.com/repos/StackStorm-Exchange/stackstorm-vsphere/issues/34/comments"},"review_comments":{"href":"https://api.github.com/repos/StackStorm-Exchange/stackstorm-vsphere/pulls/34/comments"},"review_comment":{"href":"https://api.github.com/repos/StackStorm-Exchange/stackstorm-vsphere/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/StackStorm-Exchange/stackstorm-vsphere/pulls/34/commits"},"statuses":{"href":"https://api.github.com/repos/StackStorm-Exchange/stackstorm-vsphere/statuses/27821ad45cd4011d6dcbde6757c03ec8da589af5"}},"author_association":"NONE"}} | {
"id": 75044451,
"name": "StackStorm-Exchange/stackstorm-vsphere",
"url": "https://api.github.com/repos/StackStorm-Exchange/stackstorm-vsphere"
} | {
"id": 3607046,
"login": "LindsayHill",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3607046?",
"url": "https://api.github.com/users/LindsayHill"
} | {
"id": 20677668,
"login": "StackStorm-Exchange",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/20677668?",
"url": "https://api.github.com/orgs/StackStorm-Exchange"
} | 2018-10-05T21:11:19 | 8376802621 | {"actor":{"display_login":"LindsayHill"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/se-edu/addressbook-level4/pulls/comments/182018134","pull_request_review_id":112739318,"id":182018134,"diff_hunk":"@@ -1,57 +1,44 @@\n package seedu.address.logic.commands;\n \n-import static seedu.address.logic.UndoRedoStackUtil.prepareStack;\n import static seedu.address.logic.commands.CommandTestUtil.assertCommandFailure;\n import static seedu.address.logic.commands.CommandTestUtil.assertCommandSuccess;\n import static seedu.address.logic.commands.CommandTestUtil.deleteFirstPerson;\n-import static seedu.address.testutil.TypicalIndexes.INDEX_FIRST_PERSON;\n import static seedu.address.testutil.TypicalPersons.getTypicalAddressBook;\n \n-import java.util.Arrays;\n-import java.util.Collections;\n-\n import org.junit.Before;\n import org.junit.Test;\n \n import seedu.address.logic.CommandHistory;\n-import seedu.address.logic.UndoRedoStack;\n import seedu.address.model.Model;\n import seedu.address.model.ModelManager;\n import seedu.address.model.UserPrefs;\n \n public class UndoCommandTest {\n private static final CommandHistory EMPTY_COMMAND_HISTORY = new CommandHistory();\n- private static final UndoRedoStack EMPTY_STACK = new UndoRedoStack();\n \n private final Model model = new ModelManager(getTypicalAddressBook(), new UserPrefs());\n- private final DeleteCommand deleteCommandOne = new DeleteCommand(INDEX_FIRST_PERSON);\n- private final DeleteCommand deleteCommandTwo = new DeleteCommand(INDEX_FIRST_PERSON);\n \n @Before\n public void setUp() {\n- deleteCommandOne.setData(model, EMPTY_COMMAND_HISTORY, EMPTY_STACK);\n- deleteCommandTwo.setData(model, EMPTY_COMMAND_HISTORY, EMPTY_STACK);\n+ deleteFirstPerson(model);\n+ deleteFirstPerson(model);\n }\n \n @Test\n- public void execute() throws Exception {\n- UndoRedoStack undoRedoStack = prepareStack(\n- Arrays.asList(deleteCommandOne, deleteCommandTwo), Collections.emptyList());\n+ public void execute() {\n UndoCommand undoCommand = new UndoCommand();\n- undoCommand.setData(model, EMPTY_COMMAND_HISTORY, undoRedoStack);\n- deleteCommandOne.execute();\n- deleteCommandTwo.execute();\n+ undoCommand.setData(model, EMPTY_COMMAND_HISTORY);\n \n- // multiple commands in undoStack\n+ // multiple address books in undoStack\n Model expectedModel = new ModelManager(getTypicalAddressBook(), new UserPrefs());\n deleteFirstPerson(expectedModel);\n assertCommandSuccess(undoCommand, model, UndoCommand.MESSAGE_SUCCESS, expectedModel);\n \n- // single command in undoStack\n+ // multiple address books in undoStack\n expectedModel = new ModelManager(getTypicalAddressBook(), new UserPrefs());\n assertCommandSuccess(undoCommand, model, UndoCommand.MESSAGE_SUCCESS, expectedModel);\n \n- // no command in undoStack\n+ // single address book in undoStack","path":"src/test/java/seedu/address/logic/commands/UndoCommandTest.java","position":61,"original_position":61,"commit_id":"5a3698ddf567552f06628aebd646706425e3b525","original_commit_id":"5a3698ddf567552f06628aebd646706425e3b525","user":{"login":"Zhiyuan-Amos","id":19281514,"avatar_url":"https://avatars3.githubusercontent.com/u/19281514?v=4","gravatar_id":"","url":"https://api.github.com/users/Zhiyuan-Amos","html_url":"https://github.com/Zhiyuan-Amos","followers_url":"https://api.github.com/users/Zhiyuan-Amos/followers","following_url":"https://api.github.com/users/Zhiyuan-Amos/following{/other_user}","gists_url":"https://api.github.com/users/Zhiyuan-Amos/gists{/gist_id}","starred_url":"https://api.github.com/users/Zhiyuan-Amos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zhiyuan-Amos/subscriptions","organizations_url":"https://api.github.com/users/Zhiyuan-Amos/orgs","repos_url":"https://api.github.com/users/Zhiyuan-Amos/repos","events_url":"https://api.github.com/users/Zhiyuan-Amos/events{/privacy}","received_events_url":"https://api.github.com/users/Zhiyuan-Amos/received_events","type":"User","site_admin":false},"body":"no longer undoStack :P same for above.","created_at":"2018-04-17T09:57:49Z","updated_at":"2018-04-17T10:01:17Z","html_url":"https://github.com/se-edu/addressbook-level4/pull/861#discussion_r182018134","pull_request_url":"https://api.github.com/repos/se-edu/addressbook-level4/pulls/861","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/se-edu/addressbook-level4/pulls/comments/182018134"},"html":{"href":"https://github.com/se-edu/addressbook-level4/pull/861#discussion_r182018134"},"pull_request":{"href":"https://api.github.com/repos/se-edu/addressbook-level4/pulls/861"}}},"pull_request":{"url":"https://api.github.com/repos/se-edu/addressbook-level4/pulls/861","id":177302021,"html_url":"https://github.com/se-edu/addressbook-level4/pull/861","diff_url":"https://github.com/se-edu/addressbook-level4/pull/861.diff","patch_url":"https://github.com/se-edu/addressbook-level4/pull/861.patch","issue_url":"https://api.github.com/repos/se-edu/addressbook-level4/issues/861","number":861,"state":"open","locked":false,"title":"Decouple UndoableCommand from ReadOnlyAddressBook #670","user":{"login":"yamidark","id":18352498,"avatar_url":"https://avatars1.githubusercontent.com/u/18352498?v=4","gravatar_id":"","url":"https://api.github.com/users/yamidark","html_url":"https://github.com/yamidark","followers_url":"https://api.github.com/users/yamidark/followers","following_url":"https://api.github.com/users/yamidark/following{/other_user}","gists_url":"https://api.github.com/users/yamidark/gists{/gist_id}","starred_url":"https://api.github.com/users/yamidark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yamidark/subscriptions","organizations_url":"https://api.github.com/users/yamidark/orgs","repos_url":"https://api.github.com/users/yamidark/repos","events_url":"https://api.github.com/users/yamidark/events{/privacy}","received_events_url":"https://api.github.com/users/yamidark/received_events","type":"User","site_admin":false},"body":"Fixes #670 and #828 \r\n```\r\nUndoRedoStack stores the UndoableCommands that were executed for\r\nundoing and redoing of commands.\r\n\r\nThis forces UndoableCommand to store the previous AddressBook state\r\nrequired for undoing the command, which is unnecessary coupling.\r\n\r\nLet's update UndoRedoStack to store ReadOnlyAddressBook instead.\r\n```","created_at":"2018-03-25T17:55:39Z","updated_at":"2018-04-17T10:01:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"291432e1ec28280ed3b7aa1c66be5c5a57420b73","assignee":null,"assignees":[],"requested_reviewers":[{"login":"yamgent","id":3168908,"avatar_url":"https://avatars1.githubusercontent.com/u/3168908?v=4","gravatar_id":"","url":"https://api.github.com/users/yamgent","html_url":"https://github.com/yamgent","followers_url":"https://api.github.com/users/yamgent/followers","following_url":"https://api.github.com/users/yamgent/following{/other_user}","gists_url":"https://api.github.com/users/yamgent/gists{/gist_id}","starred_url":"https://api.github.com/users/yamgent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yamgent/subscriptions","organizations_url":"https://api.github.com/users/yamgent/orgs","repos_url":"https://api.github.com/users/yamgent/repos","events_url":"https://api.github.com/users/yamgent/events{/privacy}","received_events_url":"https://api.github.com/users/yamgent/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":456150466,"url":"https://api.github.com/repos/se-edu/addressbook-level4/labels/s.ToReview","name":"s.ToReview","color":"0052cc","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/se-edu/addressbook-level4/pulls/861/commits","review_comments_url":"https://api.github.com/repos/se-edu/addressbook-level4/pulls/861/comments","review_comment_url":"https://api.github.com/repos/se-edu/addressbook-level4/pulls/comments{/number}","comments_url":"https://api.github.com/repos/se-edu/addressbook-level4/issues/861/comments","statuses_url":"https://api.github.com/repos/se-edu/addressbook-level4/statuses/5a3698ddf567552f06628aebd646706425e3b525","head":{"label":"yamidark:670-decouple-undoablecommand-addressbook","ref":"670-decouple-undoablecommand-addressbook","sha":"5a3698ddf567552f06628aebd646706425e3b525","user":{"login":"yamidark","id":18352498,"avatar_url":"https://avatars1.githubusercontent.com/u/18352498?v=4","gravatar_id":"","url":"https://api.github.com/users/yamidark","html_url":"https://github.com/yamidark","followers_url":"https://api.github.com/users/yamidark/followers","following_url":"https://api.github.com/users/yamidark/following{/other_user}","gists_url":"https://api.github.com/users/yamidark/gists{/gist_id}","starred_url":"https://api.github.com/users/yamidark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yamidark/subscriptions","organizations_url":"https://api.github.com/users/yamidark/orgs","repos_url":"https://api.github.com/users/yamidark/repos","events_url":"https://api.github.com/users/yamidark/events{/privacy}","received_events_url":"https://api.github.com/users/yamidark/received_events","type":"User","site_admin":false},"repo":{"id":115731630,"name":"addressbook-level4","full_name":"yamidark/addressbook-level4","owner":{"login":"yamidark","id":18352498,"avatar_url":"https://avatars1.githubusercontent.com/u/18352498?v=4","gravatar_id":"","url":"https://api.github.com/users/yamidark","html_url":"https://github.com/yamidark","followers_url":"https://api.github.com/users/yamidark/followers","following_url":"https://api.github.com/users/yamidark/following{/other_user}","gists_url":"https://api.github.com/users/yamidark/gists{/gist_id}","starred_url":"https://api.github.com/users/yamidark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yamidark/subscriptions","organizations_url":"https://api.github.com/users/yamidark/orgs","repos_url":"https://api.github.com/users/yamidark/repos","events_url":"https://api.github.com/users/yamidark/events{/privacy}","received_events_url":"https://api.github.com/users/yamidark/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yamidark/addressbook-level4","description":"Address Book sample application (Level 4)","fork":true,"url":"https://api.github.com/repos/yamidark/addressbook-level4","forks_url":"https://api.github.com/repos/yamidark/addressbook-level4/forks","keys_url":"https://api.github.com/repos/yamidark/addressbook-level4/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yamidark/addressbook-level4/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yamidark/addressbook-level4/teams","hooks_url":"https://api.github.com/repos/yamidark/addressbook-level4/hooks","issue_events_url":"https://api.github.com/repos/yamidark/addressbook-level4/issues/events{/number}","events_url":"https://api.github.com/repos/yamidark/addressbook-level4/events","assignees_url":"https://api.github.com/repos/yamidark/addressbook-level4/assignees{/user}","branches_url":"https://api.github.com/repos/yamidark/addressbook-level4/branches{/branch}","tags_url":"https://api.github.com/repos/yamidark/addressbook-level4/tags","blobs_url":"https://api.github.com/repos/yamidark/addressbook-level4/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yamidark/addressbook-level4/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yamidark/addressbook-level4/git/refs{/sha}","trees_url":"https://api.github.com/repos/yamidark/addressbook-level4/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yamidark/addressbook-level4/statuses/{sha}","languages_url":"https://api.github.com/repos/yamidark/addressbook-level4/languages","stargazers_url":"https://api.github.com/repos/yamidark/addressbook-level4/stargazers","contributors_url":"https://api.github.com/repos/yamidark/addressbook-level4/contributors","subscribers_url":"https://api.github.com/repos/yamidark/addressbook-level4/subscribers","subscription_url":"https://api.github.com/repos/yamidark/addressbook-level4/subscription","commits_url":"https://api.github.com/repos/yamidark/addressbook-level4/commits{/sha}","git_commits_url":"https://api.github.com/repos/yamidark/addressbook-level4/git/commits{/sha}","comments_url":"https://api.github.com/repos/yamidark/addressbook-level4/comments{/number}","issue_comment_url":"https://api.github.com/repos/yamidark/addressbook-level4/issues/comments{/number}","contents_url":"https://api.github.com/repos/yamidark/addressbook-level4/contents/{+path}","compare_url":"https://api.github.com/repos/yamidark/addressbook-level4/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yamidark/addressbook-level4/merges","archive_url":"https://api.github.com/repos/yamidark/addressbook-level4/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yamidark/addressbook-level4/downloads","issues_url":"https://api.github.com/repos/yamidark/addressbook-level4/issues{/number}","pulls_url":"https://api.github.com/repos/yamidark/addressbook-level4/pulls{/number}","milestones_url":"https://api.github.com/repos/yamidark/addressbook-level4/milestones{/number}","notifications_url":"https://api.github.com/repos/yamidark/addressbook-level4/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yamidark/addressbook-level4/labels{/name}","releases_url":"https://api.github.com/repos/yamidark/addressbook-level4/releases{/id}","deployments_url":"https://api.github.com/repos/yamidark/addressbook-level4/deployments","created_at":"2017-12-29T15:08:24Z","updated_at":"2018-04-14T15:15:04Z","pushed_at":"2018-04-16T18:01:50Z","git_url":"git://github.com/yamidark/addressbook-level4.git","ssh_url":"[email protected]:yamidark/addressbook-level4.git","clone_url":"https://github.com/yamidark/addressbook-level4.git","svn_url":"https://github.com/yamidark/addressbook-level4","homepage":"https://se-edu.github.io/addressbook-level4","size":9580,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"base":{"label":"se-edu:master","ref":"master","sha":"69b40e4b1a5db3552b3570228fb7e81eb6860a42","user":{"login":"se-edu","id":20763652,"avatar_url":"https://avatars2.githubusercontent.com/u/20763652?v=4","gravatar_id":"","url":"https://api.github.com/users/se-edu","html_url":"https://github.com/se-edu","followers_url":"https://api.github.com/users/se-edu/followers","following_url":"https://api.github.com/users/se-edu/following{/other_user}","gists_url":"https://api.github.com/users/se-edu/gists{/gist_id}","starred_url":"https://api.github.com/users/se-edu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/se-edu/subscriptions","organizations_url":"https://api.github.com/users/se-edu/orgs","repos_url":"https://api.github.com/users/se-edu/repos","events_url":"https://api.github.com/users/se-edu/events{/privacy}","received_events_url":"https://api.github.com/users/se-edu/received_events","type":"Organization","site_admin":false},"repo":{"id":65120941,"name":"addressbook-level4","full_name":"se-edu/addressbook-level4","owner":{"login":"se-edu","id":20763652,"avatar_url":"https://avatars2.githubusercontent.com/u/20763652?v=4","gravatar_id":"","url":"https://api.github.com/users/se-edu","html_url":"https://github.com/se-edu","followers_url":"https://api.github.com/users/se-edu/followers","following_url":"https://api.github.com/users/se-edu/following{/other_user}","gists_url":"https://api.github.com/users/se-edu/gists{/gist_id}","starred_url":"https://api.github.com/users/se-edu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/se-edu/subscriptions","organizations_url":"https://api.github.com/users/se-edu/orgs","repos_url":"https://api.github.com/users/se-edu/repos","events_url":"https://api.github.com/users/se-edu/events{/privacy}","received_events_url":"https://api.github.com/users/se-edu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/se-edu/addressbook-level4","description":"Address Book sample application (Level 4)","fork":false,"url":"https://api.github.com/repos/se-edu/addressbook-level4","forks_url":"https://api.github.com/repos/se-edu/addressbook-level4/forks","keys_url":"https://api.github.com/repos/se-edu/addressbook-level4/keys{/key_id}","collaborators_url":"https://api.github.com/repos/se-edu/addressbook-level4/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/se-edu/addressbook-level4/teams","hooks_url":"https://api.github.com/repos/se-edu/addressbook-level4/hooks","issue_events_url":"https://api.github.com/repos/se-edu/addressbook-level4/issues/events{/number}","events_url":"https://api.github.com/repos/se-edu/addressbook-level4/events","assignees_url":"https://api.github.com/repos/se-edu/addressbook-level4/assignees{/user}","branches_url":"https://api.github.com/repos/se-edu/addressbook-level4/branches{/branch}","tags_url":"https://api.github.com/repos/se-edu/addressbook-level4/tags","blobs_url":"https://api.github.com/repos/se-edu/addressbook-level4/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/se-edu/addressbook-level4/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/se-edu/addressbook-level4/git/refs{/sha}","trees_url":"https://api.github.com/repos/se-edu/addressbook-level4/git/trees{/sha}","statuses_url":"https://api.github.com/repos/se-edu/addressbook-level4/statuses/{sha}","languages_url":"https://api.github.com/repos/se-edu/addressbook-level4/languages","stargazers_url":"https://api.github.com/repos/se-edu/addressbook-level4/stargazers","contributors_url":"https://api.github.com/repos/se-edu/addressbook-level4/contributors","subscribers_url":"https://api.github.com/repos/se-edu/addressbook-level4/subscribers","subscription_url":"https://api.github.com/repos/se-edu/addressbook-level4/subscription","commits_url":"https://api.github.com/repos/se-edu/addressbook-level4/commits{/sha}","git_commits_url":"https://api.github.com/repos/se-edu/addressbook-level4/git/commits{/sha}","comments_url":"https://api.github.com/repos/se-edu/addressbook-level4/comments{/number}","issue_comment_url":"https://api.github.com/repos/se-edu/addressbook-level4/issues/comments{/number}","contents_url":"https://api.github.com/repos/se-edu/addressbook-level4/contents/{+path}","compare_url":"https://api.github.com/repos/se-edu/addressbook-level4/compare/{base}...{head}","merges_url":"https://api.github.com/repos/se-edu/addressbook-level4/merges","archive_url":"https://api.github.com/repos/se-edu/addressbook-level4/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/se-edu/addressbook-level4/downloads","issues_url":"https://api.github.com/repos/se-edu/addressbook-level4/issues{/number}","pulls_url":"https://api.github.com/repos/se-edu/addressbook-level4/pulls{/number}","milestones_url":"https://api.github.com/repos/se-edu/addressbook-level4/milestones{/number}","notifications_url":"https://api.github.com/repos/se-edu/addressbook-level4/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/se-edu/addressbook-level4/labels{/name}","releases_url":"https://api.github.com/repos/se-edu/addressbook-level4/releases{/id}","deployments_url":"https://api.github.com/repos/se-edu/addressbook-level4/deployments","created_at":"2016-08-07T07:17:26Z","updated_at":"2018-04-14T05:07:28Z","pushed_at":"2018-04-16T18:50:37Z","git_url":"git://github.com/se-edu/addressbook-level4.git","ssh_url":"[email protected]:se-edu/addressbook-level4.git","clone_url":"https://github.com/se-edu/addressbook-level4.git","svn_url":"https://github.com/se-edu/addressbook-level4","homepage":"https://se-edu.github.io/addressbook-level4","size":20336,"stargazers_count":8,"watchers_count":8,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":989,"mirror_url":null,"archived":false,"open_issues_count":96,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":989,"open_issues":96,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/se-edu/addressbook-level4/pulls/861"},"html":{"href":"https://github.com/se-edu/addressbook-level4/pull/861"},"issue":{"href":"https://api.github.com/repos/se-edu/addressbook-level4/issues/861"},"comments":{"href":"https://api.github.com/repos/se-edu/addressbook-level4/issues/861/comments"},"review_comments":{"href":"https://api.github.com/repos/se-edu/addressbook-level4/pulls/861/comments"},"review_comment":{"href":"https://api.github.com/repos/se-edu/addressbook-level4/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/se-edu/addressbook-level4/pulls/861/commits"},"statuses":{"href":"https://api.github.com/repos/se-edu/addressbook-level4/statuses/5a3698ddf567552f06628aebd646706425e3b525"}},"author_association":"CONTRIBUTOR"}} | {
"id": 65120941,
"name": "se-edu/addressbook-level4",
"url": "https://api.github.com/repos/se-edu/addressbook-level4"
} | {
"id": 19281514,
"login": "Zhiyuan-Amos",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/19281514?",
"url": "https://api.github.com/users/Zhiyuan-Amos"
} | {
"id": 20763652,
"login": "se-edu",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/20763652?",
"url": "https://api.github.com/orgs/se-edu"
} | 2018-04-17T09:57:49 | 7541522602 | {"actor":{"display_login":"Zhiyuan-Amos"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/openebs/openebs-docs/pulls/comments/222201978","pull_request_review_id":161030095,"id":222201978,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMjIwMTk3OA==","diff_hunk":"@@ -6,202 +6,133 @@ sidebar_label: Upgrade\n \n ------\n \n-OpenEBS supports upgrade to 0.6 version only from 0.5.3 and 0.5.4.\n+# Upgrade from OpenEBS 0.6.0 TO 0.7.0\n \n-For older verions, upgrade to either 0.5.3 or 0.5.4 before upgrading to 0.6. For steps to upgrade to 0.5.3 or 0.5.4, [click](https://v05-docs.openebs.io/) here.\n+## Overview\n \n+This document describes the steps for upgrading OpenEBS from 0.6.0 to 0.7.0. The upgrade of OpenEBS is a two step process. \n+- *Step 1* - Upgrade the OpenEBS Operator \n+- *Step 2* - Upgrade the OpenEBS Volumes that were created with older OpenEBS Operator (0.6.0) \n \n-1. Upgrade the OpenEBS operator.\n+**Note:**\n+For older verions, OpenEBS supports upgrade to 0.6 version only from 0.5.3 and 0.5.4. For steps to upgrade to 0.6.0, [click](https://v06-docs.openebs.io/docs/next/upgrade.html) here.\n \n-2. Upgrade the OpenEBS volumes that were created with older OpenEBS operator.\n+### Terminology\n \n-Upgrading OpenEBS Operator depends on how OpenEBS was installed (using kubectl or helm). Based on the type of installation select one of the following.\n+- *OpenEBS Operator : Refers to maya-apiserver & openebs-provisioner along w/ respective services, service a/c, roles, rolebindings*\n+- *OpenEBS Volume: The Jiva controller & replica pods*\n+- *All steps described in this document need to be performed on the Kubernetes master or from a machine that has access to Kubernetes master*\n \n-**Step-1 Upgrade OpenEBS Operator**\n+## Step 1: Upgrade the OpenEBS Operator\n \n-**Upgrade Using Kubectl** (OpenEBS was installed by kubectl using the openebs-operator.yaml file)\n+OpenEBS 0.7.0 has made the following significant changes to the OpenEBS Operator (aka OpenEBS control plane components):\n+- A new provisioning and policy enforcement engine. This introduces a breaking changes as it expects the volume policies to be present as annotations in storage class as opposed to `parameters` or `environment variables`.","path":"docs/upgrade.md","position":31,"original_position":31,"commit_id":"94f292aa51ec53242867fad91edba95f13de948d","original_commit_id":"94f292aa51ec53242867fad91edba95f13de948d","user":{"login":"mahebbar","id":30617626,"node_id":"MDQ6VXNlcjMwNjE3NjI2","avatar_url":"https://avatars0.githubusercontent.com/u/30617626?v=4","gravatar_id":"","url":"https://api.github.com/users/mahebbar","html_url":"https://github.com/mahebbar","followers_url":"https://api.github.com/users/mahebbar/followers","following_url":"https://api.github.com/users/mahebbar/following{/other_user}","gists_url":"https://api.github.com/users/mahebbar/gists{/gist_id}","starred_url":"https://api.github.com/users/mahebbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mahebbar/subscriptions","organizations_url":"https://api.github.com/users/mahebbar/orgs","repos_url":"https://api.github.com/users/mahebbar/repos","events_url":"https://api.github.com/users/mahebbar/events{/privacy}","received_events_url":"https://api.github.com/users/mahebbar/received_events","type":"User","site_admin":false},"body":"This introduces formatting changes as it expects...\r\n","created_at":"2018-10-03T06:59:56Z","updated_at":"2018-10-03T06:59:56Z","html_url":"https://github.com/openebs/openebs-docs/pull/315#discussion_r222201978","pull_request_url":"https://api.github.com/repos/openebs/openebs-docs/pulls/315","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/openebs/openebs-docs/pulls/comments/222201978"},"html":{"href":"https://github.com/openebs/openebs-docs/pull/315#discussion_r222201978"},"pull_request":{"href":"https://api.github.com/repos/openebs/openebs-docs/pulls/315"}}},"pull_request":{"url":"https://api.github.com/repos/openebs/openebs-docs/pulls/315","id":219337381,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5MzM3Mzgx","html_url":"https://github.com/openebs/openebs-docs/pull/315","diff_url":"https://github.com/openebs/openebs-docs/pull/315.diff","patch_url":"https://github.com/openebs/openebs-docs/pull/315.patch","issue_url":"https://api.github.com/repos/openebs/openebs-docs/issues/315","number":315,"state":"open","locked":false,"title":"Upgrade steps from 0.6 to 0.7","user":{"login":"prabhatkumarthakur","id":20839334,"node_id":"MDQ6VXNlcjIwODM5MzM0","avatar_url":"https://avatars2.githubusercontent.com/u/20839334?v=4","gravatar_id":"","url":"https://api.github.com/users/prabhatkumarthakur","html_url":"https://github.com/prabhatkumarthakur","followers_url":"https://api.github.com/users/prabhatkumarthakur/followers","following_url":"https://api.github.com/users/prabhatkumarthakur/following{/other_user}","gists_url":"https://api.github.com/users/prabhatkumarthakur/gists{/gist_id}","starred_url":"https://api.github.com/users/prabhatkumarthakur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prabhatkumarthakur/subscriptions","organizations_url":"https://api.github.com/users/prabhatkumarthakur/orgs","repos_url":"https://api.github.com/users/prabhatkumarthakur/repos","events_url":"https://api.github.com/users/prabhatkumarthakur/events{/privacy}","received_events_url":"https://api.github.com/users/prabhatkumarthakur/received_events","type":"User","site_admin":false},"body":"Steps for the upgrade from the 0.6 version to 0.7 version.\r\nSigned-off-by: Prabhat Kumar Thakur [email protected]","created_at":"2018-10-01T11:07:13Z","updated_at":"2018-10-03T06:59:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c0448051a9a4458745078f5688038e1f873800b4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/openebs/openebs-docs/pulls/315/commits","review_comments_url":"https://api.github.com/repos/openebs/openebs-docs/pulls/315/comments","review_comment_url":"https://api.github.com/repos/openebs/openebs-docs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openebs/openebs-docs/issues/315/comments","statuses_url":"https://api.github.com/repos/openebs/openebs-docs/statuses/94f292aa51ec53242867fad91edba95f13de948d","head":{"label":"openebs:prabhatkumarthakur-patch-2","ref":"prabhatkumarthakur-patch-2","sha":"94f292aa51ec53242867fad91edba95f13de948d","user":{"login":"openebs","id":20769039,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNzY5MDM5","avatar_url":"https://avatars0.githubusercontent.com/u/20769039?v=4","gravatar_id":"","url":"https://api.github.com/users/openebs","html_url":"https://github.com/openebs","followers_url":"https://api.github.com/users/openebs/followers","following_url":"https://api.github.com/users/openebs/following{/other_user}","gists_url":"https://api.github.com/users/openebs/gists{/gist_id}","starred_url":"https://api.github.com/users/openebs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openebs/subscriptions","organizations_url":"https://api.github.com/users/openebs/orgs","repos_url":"https://api.github.com/users/openebs/repos","events_url":"https://api.github.com/users/openebs/events{/privacy}","received_events_url":"https://api.github.com/users/openebs/received_events","type":"Organization","site_admin":false},"repo":{"id":121746365,"node_id":"MDEwOlJlcG9zaXRvcnkxMjE3NDYzNjU=","name":"openebs-docs","full_name":"openebs/openebs-docs","private":false,"owner":{"login":"openebs","id":20769039,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNzY5MDM5","avatar_url":"https://avatars0.githubusercontent.com/u/20769039?v=4","gravatar_id":"","url":"https://api.github.com/users/openebs","html_url":"https://github.com/openebs","followers_url":"https://api.github.com/users/openebs/followers","following_url":"https://api.github.com/users/openebs/following{/other_user}","gists_url":"https://api.github.com/users/openebs/gists{/gist_id}","starred_url":"https://api.github.com/users/openebs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openebs/subscriptions","organizations_url":"https://api.github.com/users/openebs/orgs","repos_url":"https://api.github.com/users/openebs/repos","events_url":"https://api.github.com/users/openebs/events{/privacy}","received_events_url":"https://api.github.com/users/openebs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/openebs/openebs-docs","description":"Documentation for OpenEBS project. OpenEBS provides storage for stateful applications on Kubernetes in CAS (Container Attached Storage) architecture.","fork":false,"url":"https://api.github.com/repos/openebs/openebs-docs","forks_url":"https://api.github.com/repos/openebs/openebs-docs/forks","keys_url":"https://api.github.com/repos/openebs/openebs-docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openebs/openebs-docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openebs/openebs-docs/teams","hooks_url":"https://api.github.com/repos/openebs/openebs-docs/hooks","issue_events_url":"https://api.github.com/repos/openebs/openebs-docs/issues/events{/number}","events_url":"https://api.github.com/repos/openebs/openebs-docs/events","assignees_url":"https://api.github.com/repos/openebs/openebs-docs/assignees{/user}","branches_url":"https://api.github.com/repos/openebs/openebs-docs/branches{/branch}","tags_url":"https://api.github.com/repos/openebs/openebs-docs/tags","blobs_url":"https://api.github.com/repos/openebs/openebs-docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openebs/openebs-docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openebs/openebs-docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/openebs/openebs-docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openebs/openebs-docs/statuses/{sha}","languages_url":"https://api.github.com/repos/openebs/openebs-docs/languages","stargazers_url":"https://api.github.com/repos/openebs/openebs-docs/stargazers","contributors_url":"https://api.github.com/repos/openebs/openebs-docs/contributors","subscribers_url":"https://api.github.com/repos/openebs/openebs-docs/subscribers","subscription_url":"https://api.github.com/repos/openebs/openebs-docs/subscription","commits_url":"https://api.github.com/repos/openebs/openebs-docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/openebs/openebs-docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/openebs/openebs-docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/openebs/openebs-docs/issues/comments{/number}","contents_url":"https://api.github.com/repos/openebs/openebs-docs/contents/{+path}","compare_url":"https://api.github.com/repos/openebs/openebs-docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openebs/openebs-docs/merges","archive_url":"https://api.github.com/repos/openebs/openebs-docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openebs/openebs-docs/downloads","issues_url":"https://api.github.com/repos/openebs/openebs-docs/issues{/number}","pulls_url":"https://api.github.com/repos/openebs/openebs-docs/pulls{/number}","milestones_url":"https://api.github.com/repos/openebs/openebs-docs/milestones{/number}","notifications_url":"https://api.github.com/repos/openebs/openebs-docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openebs/openebs-docs/labels{/name}","releases_url":"https://api.github.com/repos/openebs/openebs-docs/releases{/id}","deployments_url":"https://api.github.com/repos/openebs/openebs-docs/deployments","created_at":"2018-02-16T12:04:56Z","updated_at":"2018-09-27T07:13:52Z","pushed_at":"2018-10-03T06:02:29Z","git_url":"git://github.com/openebs/openebs-docs.git","ssh_url":"[email protected]:openebs/openebs-docs.git","clone_url":"https://github.com/openebs/openebs-docs.git","svn_url":"https://github.com/openebs/openebs-docs","homepage":"https://docs.openebs.io","size":18441,"stargazers_count":13,"watchers_count":13,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":31,"mirror_url":null,"archived":false,"open_issues_count":9,"license":null,"forks":31,"open_issues":9,"watchers":13,"default_branch":"master"}},"base":{"label":"openebs:staging","ref":"staging","sha":"2d8c15782147eb29fbc633c32d3dfdd5923698a4","user":{"login":"openebs","id":20769039,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNzY5MDM5","avatar_url":"https://avatars0.githubusercontent.com/u/20769039?v=4","gravatar_id":"","url":"https://api.github.com/users/openebs","html_url":"https://github.com/openebs","followers_url":"https://api.github.com/users/openebs/followers","following_url":"https://api.github.com/users/openebs/following{/other_user}","gists_url":"https://api.github.com/users/openebs/gists{/gist_id}","starred_url":"https://api.github.com/users/openebs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openebs/subscriptions","organizations_url":"https://api.github.com/users/openebs/orgs","repos_url":"https://api.github.com/users/openebs/repos","events_url":"https://api.github.com/users/openebs/events{/privacy}","received_events_url":"https://api.github.com/users/openebs/received_events","type":"Organization","site_admin":false},"repo":{"id":121746365,"node_id":"MDEwOlJlcG9zaXRvcnkxMjE3NDYzNjU=","name":"openebs-docs","full_name":"openebs/openebs-docs","private":false,"owner":{"login":"openebs","id":20769039,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNzY5MDM5","avatar_url":"https://avatars0.githubusercontent.com/u/20769039?v=4","gravatar_id":"","url":"https://api.github.com/users/openebs","html_url":"https://github.com/openebs","followers_url":"https://api.github.com/users/openebs/followers","following_url":"https://api.github.com/users/openebs/following{/other_user}","gists_url":"https://api.github.com/users/openebs/gists{/gist_id}","starred_url":"https://api.github.com/users/openebs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openebs/subscriptions","organizations_url":"https://api.github.com/users/openebs/orgs","repos_url":"https://api.github.com/users/openebs/repos","events_url":"https://api.github.com/users/openebs/events{/privacy}","received_events_url":"https://api.github.com/users/openebs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/openebs/openebs-docs","description":"Documentation for OpenEBS project. OpenEBS provides storage for stateful applications on Kubernetes in CAS (Container Attached Storage) architecture.","fork":false,"url":"https://api.github.com/repos/openebs/openebs-docs","forks_url":"https://api.github.com/repos/openebs/openebs-docs/forks","keys_url":"https://api.github.com/repos/openebs/openebs-docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openebs/openebs-docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openebs/openebs-docs/teams","hooks_url":"https://api.github.com/repos/openebs/openebs-docs/hooks","issue_events_url":"https://api.github.com/repos/openebs/openebs-docs/issues/events{/number}","events_url":"https://api.github.com/repos/openebs/openebs-docs/events","assignees_url":"https://api.github.com/repos/openebs/openebs-docs/assignees{/user}","branches_url":"https://api.github.com/repos/openebs/openebs-docs/branches{/branch}","tags_url":"https://api.github.com/repos/openebs/openebs-docs/tags","blobs_url":"https://api.github.com/repos/openebs/openebs-docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openebs/openebs-docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openebs/openebs-docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/openebs/openebs-docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openebs/openebs-docs/statuses/{sha}","languages_url":"https://api.github.com/repos/openebs/openebs-docs/languages","stargazers_url":"https://api.github.com/repos/openebs/openebs-docs/stargazers","contributors_url":"https://api.github.com/repos/openebs/openebs-docs/contributors","subscribers_url":"https://api.github.com/repos/openebs/openebs-docs/subscribers","subscription_url":"https://api.github.com/repos/openebs/openebs-docs/subscription","commits_url":"https://api.github.com/repos/openebs/openebs-docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/openebs/openebs-docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/openebs/openebs-docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/openebs/openebs-docs/issues/comments{/number}","contents_url":"https://api.github.com/repos/openebs/openebs-docs/contents/{+path}","compare_url":"https://api.github.com/repos/openebs/openebs-docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openebs/openebs-docs/merges","archive_url":"https://api.github.com/repos/openebs/openebs-docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openebs/openebs-docs/downloads","issues_url":"https://api.github.com/repos/openebs/openebs-docs/issues{/number}","pulls_url":"https://api.github.com/repos/openebs/openebs-docs/pulls{/number}","milestones_url":"https://api.github.com/repos/openebs/openebs-docs/milestones{/number}","notifications_url":"https://api.github.com/repos/openebs/openebs-docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openebs/openebs-docs/labels{/name}","releases_url":"https://api.github.com/repos/openebs/openebs-docs/releases{/id}","deployments_url":"https://api.github.com/repos/openebs/openebs-docs/deployments","created_at":"2018-02-16T12:04:56Z","updated_at":"2018-09-27T07:13:52Z","pushed_at":"2018-10-03T06:02:29Z","git_url":"git://github.com/openebs/openebs-docs.git","ssh_url":"[email protected]:openebs/openebs-docs.git","clone_url":"https://github.com/openebs/openebs-docs.git","svn_url":"https://github.com/openebs/openebs-docs","homepage":"https://docs.openebs.io","size":18441,"stargazers_count":13,"watchers_count":13,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":31,"mirror_url":null,"archived":false,"open_issues_count":9,"license":null,"forks":31,"open_issues":9,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openebs/openebs-docs/pulls/315"},"html":{"href":"https://github.com/openebs/openebs-docs/pull/315"},"issue":{"href":"https://api.github.com/repos/openebs/openebs-docs/issues/315"},"comments":{"href":"https://api.github.com/repos/openebs/openebs-docs/issues/315/comments"},"review_comments":{"href":"https://api.github.com/repos/openebs/openebs-docs/pulls/315/comments"},"review_comment":{"href":"https://api.github.com/repos/openebs/openebs-docs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openebs/openebs-docs/pulls/315/commits"},"statuses":{"href":"https://api.github.com/repos/openebs/openebs-docs/statuses/94f292aa51ec53242867fad91edba95f13de948d"}},"author_association":"MEMBER"}} | {
"id": 121746365,
"name": "openebs/openebs-docs",
"url": "https://api.github.com/repos/openebs/openebs-docs"
} | {
"id": 30617626,
"login": "mahebbar",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/30617626?",
"url": "https://api.github.com/users/mahebbar"
} | {
"id": 20769039,
"login": "openebs",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/20769039?",
"url": "https://api.github.com/orgs/openebs"
} | 2018-10-03T06:59:56 | 8359112764 | {"actor":{"display_login":"mahebbar"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/Informatik-HS-KL/Python-Tutorial/pulls/comments/236545655","pull_request_review_id":178639194,"id":236545655,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNjU0NTY1NQ==","diff_hunk":"@@ -0,0 +1,62 @@\n+% !TeX root = ../../pythonTutorial.tex\n+\\section{Vorteile von Funktionen}\n+\n+Warum benutzen Programmierer Funktionen? Diese bieten eine Vielzahl an Vorteilen, wie z.B.\n+\n+\\begin{itemize}\n+\t\\item das Aufteilen von komplexen in mehrere simple Aufgaben\n+\t\\item das Verhindern von Code-Duplikationen\n+\t\\item bessere Lesbarkeit/Erweiterbarkeit/Ver�nderbarkeit\n+\t\\item vereinfachtes Debugging\n+\\end{itemize}\n+\n+\\subsection{Aufteilen von komplexen Aufgaben}\n+\\label{vorteileVonFunktionen:subsection:splitComplexTask}\n+Bei komplexen Aufgaben kommt es schnell zu einer hohen Anzahl an\n+Code-Zeilen. Das kann f�r den Programmierer und die Kollegen, die an den Aufgaben mitwirken, problematisch sein.\n+Der Code ist schlecht zu lesen und die Fehlersuche schwierig.\n+Schritte, die immer wieder gebraucht werden, w�ren das Abfangen, Auslesen, Interpretieren und Aufbereiten von Daten. Anf�nger k�nnten den Fehler machen, diese Aufgaben in einer gro�en komplexen Funktion zu schreiben.\n+\n+\\begin{lstlisting}[caption=Schlechter Umgang mit komplexen Prozessen, label=vorteileVonFunktionen:lst:badComplexFunction]\n+def processData(source):\n+ ...\n+ return finalData\n+\\end{lstlisting}\n+\n+Es ist m�hsam herauszufinden, was genau in dieser Funktion passiert.\n+Ein Beispiel zum Aufteilen des Code-Blocks k�nnte weiterhelfen.\n+\n+\\begin{lstlisting}[caption=Komplexit�t aufgeteilt in mehrere Funktionen, label=vorteileVonFunktionen:lst:goodComplexFunction]\n+def processData(source)","path":"chapters/functions/vorteileVonFunktionen.tex","position":30,"original_position":30,"commit_id":"aae0d72bba0b2ae06617b5172a7707f42261ddf8","original_commit_id":"aae0d72bba0b2ae06617b5172a7707f42261ddf8","user":{"login":"Callesto1","id":28858959,"node_id":"MDQ6VXNlcjI4ODU4OTU5","avatar_url":"https://avatars1.githubusercontent.com/u/28858959?v=4","gravatar_id":"","url":"https://api.github.com/users/Callesto1","html_url":"https://github.com/Callesto1","followers_url":"https://api.github.com/users/Callesto1/followers","following_url":"https://api.github.com/users/Callesto1/following{/other_user}","gists_url":"https://api.github.com/users/Callesto1/gists{/gist_id}","starred_url":"https://api.github.com/users/Callesto1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Callesto1/subscriptions","organizations_url":"https://api.github.com/users/Callesto1/orgs","repos_url":"https://api.github.com/users/Callesto1/repos","events_url":"https://api.github.com/users/Callesto1/events{/privacy}","received_events_url":"https://api.github.com/users/Callesto1/received_events","type":"User","site_admin":false},"body":"> def processData(source)\r\n\r\ndef processData(source):","created_at":"2018-11-27T07:30:41Z","updated_at":"2018-11-27T07:47:12Z","html_url":"https://github.com/Informatik-HS-KL/Python-Tutorial/pull/23#discussion_r236545655","pull_request_url":"https://api.github.com/repos/Informatik-HS-KL/Python-Tutorial/pulls/23","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/Informatik-HS-KL/Python-Tutorial/pulls/comments/236545655"},"html":{"href":"https://github.com/Informatik-HS-KL/Python-Tutorial/pull/23#discussion_r236545655"},"pull_request":{"href":"https://api.github.com/repos/Informatik-HS-KL/Python-Tutorial/pulls/23"}}},"pull_request":{"url":"https://api.github.com/repos/Informatik-HS-KL/Python-Tutorial/pulls/23","id":229896564,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5ODk2NTY0","html_url":"https://github.com/Informatik-HS-KL/Python-Tutorial/pull/23","diff_url":"https://github.com/Informatik-HS-KL/Python-Tutorial/pull/23.diff","patch_url":"https://github.com/Informatik-HS-KL/Python-Tutorial/pull/23.patch","issue_url":"https://api.github.com/repos/Informatik-HS-KL/Python-Tutorial/issues/23","number":23,"state":"open","locked":false,"title":"Kapitel Funktionen hinzugefügt","user":{"login":"GesunderApfel","id":9647392,"node_id":"MDQ6VXNlcjk2NDczOTI=","avatar_url":"https://avatars1.githubusercontent.com/u/9647392?v=4","gravatar_id":"","url":"https://api.github.com/users/GesunderApfel","html_url":"https://github.com/GesunderApfel","followers_url":"https://api.github.com/users/GesunderApfel/followers","following_url":"https://api.github.com/users/GesunderApfel/following{/other_user}","gists_url":"https://api.github.com/users/GesunderApfel/gists{/gist_id}","starred_url":"https://api.github.com/users/GesunderApfel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GesunderApfel/subscriptions","organizations_url":"https://api.github.com/users/GesunderApfel/orgs","repos_url":"https://api.github.com/users/GesunderApfel/repos","events_url":"https://api.github.com/users/GesunderApfel/events{/privacy}","received_events_url":"https://api.github.com/users/GesunderApfel/received_events","type":"User","site_admin":false},"body":"Kapitel \"Funktionen\"","created_at":"2018-11-10T15:59:05Z","updated_at":"2018-11-27T07:47:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f57883d26770d98a3440f51c88cd2f48d05b4130","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Informatik-HS-KL/Python-Tutorial/pulls/23/commits","review_comments_url":"https://api.github.com/repos/Informatik-HS-KL/Python-Tutorial/pulls/23/comments","review_comment_url":"https://api.github.com/repos/Informatik-HS-KL/Python-Tutorial/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Informatik-HS-KL/Python-Tutorial/issues/23/comments","statuses_url":"https://api.github.com/repos/Informatik-HS-KL/Python-Tutorial/statuses/aae0d72bba0b2ae06617b5172a7707f42261ddf8","head":{"label":"GesunderApfel:develop","ref":"develop","sha":"aae0d72bba0b2ae06617b5172a7707f42261ddf8","user":{"login":"GesunderApfel","id":9647392,"node_id":"MDQ6VXNlcjk2NDczOTI=","avatar_url":"https://avatars1.githubusercontent.com/u/9647392?v=4","gravatar_id":"","url":"https://api.github.com/users/GesunderApfel","html_url":"https://github.com/GesunderApfel","followers_url":"https://api.github.com/users/GesunderApfel/followers","following_url":"https://api.github.com/users/GesunderApfel/following{/other_user}","gists_url":"https://api.github.com/users/GesunderApfel/gists{/gist_id}","starred_url":"https://api.github.com/users/GesunderApfel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GesunderApfel/subscriptions","organizations_url":"https://api.github.com/users/GesunderApfel/orgs","repos_url":"https://api.github.com/users/GesunderApfel/repos","events_url":"https://api.github.com/users/GesunderApfel/events{/privacy}","received_events_url":"https://api.github.com/users/GesunderApfel/received_events","type":"User","site_admin":false},"repo":{"id":153588431,"node_id":"MDEwOlJlcG9zaXRvcnkxNTM1ODg0MzE=","name":"Python-Tutorial","full_name":"GesunderApfel/Python-Tutorial","private":false,"owner":{"login":"GesunderApfel","id":9647392,"node_id":"MDQ6VXNlcjk2NDczOTI=","avatar_url":"https://avatars1.githubusercontent.com/u/9647392?v=4","gravatar_id":"","url":"https://api.github.com/users/GesunderApfel","html_url":"https://github.com/GesunderApfel","followers_url":"https://api.github.com/users/GesunderApfel/followers","following_url":"https://api.github.com/users/GesunderApfel/following{/other_user}","gists_url":"https://api.github.com/users/GesunderApfel/gists{/gist_id}","starred_url":"https://api.github.com/users/GesunderApfel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GesunderApfel/subscriptions","organizations_url":"https://api.github.com/users/GesunderApfel/orgs","repos_url":"https://api.github.com/users/GesunderApfel/repos","events_url":"https://api.github.com/users/GesunderApfel/events{/privacy}","received_events_url":"https://api.github.com/users/GesunderApfel/received_events","type":"User","site_admin":false},"html_url":"https://github.com/GesunderApfel/Python-Tutorial","description":"Python Tutorial / Collaborative Writing","fork":true,"url":"https://api.github.com/repos/GesunderApfel/Python-Tutorial","forks_url":"https://api.github.com/repos/GesunderApfel/Python-Tutorial/forks","keys_url":"https://api.github.com/repos/GesunderApfel/Python-Tutorial/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GesunderApfel/Python-Tutorial/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GesunderApfel/Python-Tutorial/teams","hooks_url":"https://api.github.com/repos/GesunderApfel/Python-Tutorial/hooks","issue_events_url":"https://api.github.com/repos/GesunderApfel/Python-Tutorial/issues/events{/number}","events_url":"https://api.github.com/repos/GesunderApfel/Python-Tutorial/events","assignees_url":"https://api.github.com/repos/GesunderApfel/Python-Tutorial/assignees{/user}","branches_url":"https://api.github.com/repos/GesunderApfel/Python-Tutorial/branches{/branch}","tags_url":"https://api.github.com/repos/GesunderApfel/Python-Tutorial/tags","blobs_url":"https://api.github.com/repos/GesunderApfel/Python-Tutorial/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GesunderApfel/Python-Tutorial/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GesunderApfel/Python-Tutorial/git/refs{/sha}","trees_url":"https://api.github.com/repos/GesunderApfel/Python-Tutorial/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GesunderApfel/Python-Tutorial/statuses/{sha}","languages_url":"https://api.github.com/repos/GesunderApfel/Python-Tutorial/languages","stargazers_url":"https://api.github.com/repos/GesunderApfel/Python-Tutorial/stargazers","contributors_url":"https://api.github.com/repos/GesunderApfel/Python-Tutorial/contributors","subscribers_url":"https://api.github.com/repos/GesunderApfel/Python-Tutorial/subscribers","subscription_url":"https://api.github.com/repos/GesunderApfel/Python-Tutorial/subscription","commits_url":"https://api.github.com/repos/GesunderApfel/Python-Tutorial/commits{/sha}","git_commits_url":"https://api.github.com/repos/GesunderApfel/Python-Tutorial/git/commits{/sha}","comments_url":"https://api.github.com/repos/GesunderApfel/Python-Tutorial/comments{/number}","issue_comment_url":"https://api.github.com/repos/GesunderApfel/Python-Tutorial/issues/comments{/number}","contents_url":"https://api.github.com/repos/GesunderApfel/Python-Tutorial/contents/{+path}","compare_url":"https://api.github.com/repos/GesunderApfel/Python-Tutorial/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GesunderApfel/Python-Tutorial/merges","archive_url":"https://api.github.com/repos/GesunderApfel/Python-Tutorial/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GesunderApfel/Python-Tutorial/downloads","issues_url":"https://api.github.com/repos/GesunderApfel/Python-Tutorial/issues{/number}","pulls_url":"https://api.github.com/repos/GesunderApfel/Python-Tutorial/pulls{/number}","milestones_url":"https://api.github.com/repos/GesunderApfel/Python-Tutorial/milestones{/number}","notifications_url":"https://api.github.com/repos/GesunderApfel/Python-Tutorial/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GesunderApfel/Python-Tutorial/labels{/name}","releases_url":"https://api.github.com/repos/GesunderApfel/Python-Tutorial/releases{/id}","deployments_url":"https://api.github.com/repos/GesunderApfel/Python-Tutorial/deployments","created_at":"2018-10-18T08:18:07Z","updated_at":"2018-11-22T09:21:28Z","pushed_at":"2018-11-22T09:21:26Z","git_url":"git://github.com/GesunderApfel/Python-Tutorial.git","ssh_url":"[email protected]:GesunderApfel/Python-Tutorial.git","clone_url":"https://github.com/GesunderApfel/Python-Tutorial.git","svn_url":"https://github.com/GesunderApfel/Python-Tutorial","homepage":"","size":141,"stargazers_count":0,"watchers_count":0,"language":"TeX","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"Informatik-HS-KL:develop","ref":"develop","sha":"fcea1b3e96fc9ad8df40f53dbe0c7e19adc60287","user":{"login":"Informatik-HS-KL","id":20774205,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNzc0MjA1","avatar_url":"https://avatars0.githubusercontent.com/u/20774205?v=4","gravatar_id":"","url":"https://api.github.com/users/Informatik-HS-KL","html_url":"https://github.com/Informatik-HS-KL","followers_url":"https://api.github.com/users/Informatik-HS-KL/followers","following_url":"https://api.github.com/users/Informatik-HS-KL/following{/other_user}","gists_url":"https://api.github.com/users/Informatik-HS-KL/gists{/gist_id}","starred_url":"https://api.github.com/users/Informatik-HS-KL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Informatik-HS-KL/subscriptions","organizations_url":"https://api.github.com/users/Informatik-HS-KL/orgs","repos_url":"https://api.github.com/users/Informatik-HS-KL/repos","events_url":"https://api.github.com/users/Informatik-HS-KL/events{/privacy}","received_events_url":"https://api.github.com/users/Informatik-HS-KL/received_events","type":"Organization","site_admin":false},"repo":{"id":153462071,"node_id":"MDEwOlJlcG9zaXRvcnkxNTM0NjIwNzE=","name":"Python-Tutorial","full_name":"Informatik-HS-KL/Python-Tutorial","private":false,"owner":{"login":"Informatik-HS-KL","id":20774205,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNzc0MjA1","avatar_url":"https://avatars0.githubusercontent.com/u/20774205?v=4","gravatar_id":"","url":"https://api.github.com/users/Informatik-HS-KL","html_url":"https://github.com/Informatik-HS-KL","followers_url":"https://api.github.com/users/Informatik-HS-KL/followers","following_url":"https://api.github.com/users/Informatik-HS-KL/following{/other_user}","gists_url":"https://api.github.com/users/Informatik-HS-KL/gists{/gist_id}","starred_url":"https://api.github.com/users/Informatik-HS-KL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Informatik-HS-KL/subscriptions","organizations_url":"https://api.github.com/users/Informatik-HS-KL/orgs","repos_url":"https://api.github.com/users/Informatik-HS-KL/repos","events_url":"https://api.github.com/users/Informatik-HS-KL/events{/privacy}","received_events_url":"https://api.github.com/users/Informatik-HS-KL/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Informatik-HS-KL/Python-Tutorial","description":"Python Tutorial / Collaborative Writing","fork":false,"url":"https://api.github.com/repos/Informatik-HS-KL/Python-Tutorial","forks_url":"https://api.github.com/repos/Informatik-HS-KL/Python-Tutorial/forks","keys_url":"https://api.github.com/repos/Informatik-HS-KL/Python-Tutorial/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Informatik-HS-KL/Python-Tutorial/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Informatik-HS-KL/Python-Tutorial/teams","hooks_url":"https://api.github.com/repos/Informatik-HS-KL/Python-Tutorial/hooks","issue_events_url":"https://api.github.com/repos/Informatik-HS-KL/Python-Tutorial/issues/events{/number}","events_url":"https://api.github.com/repos/Informatik-HS-KL/Python-Tutorial/events","assignees_url":"https://api.github.com/repos/Informatik-HS-KL/Python-Tutorial/assignees{/user}","branches_url":"https://api.github.com/repos/Informatik-HS-KL/Python-Tutorial/branches{/branch}","tags_url":"https://api.github.com/repos/Informatik-HS-KL/Python-Tutorial/tags","blobs_url":"https://api.github.com/repos/Informatik-HS-KL/Python-Tutorial/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Informatik-HS-KL/Python-Tutorial/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Informatik-HS-KL/Python-Tutorial/git/refs{/sha}","trees_url":"https://api.github.com/repos/Informatik-HS-KL/Python-Tutorial/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Informatik-HS-KL/Python-Tutorial/statuses/{sha}","languages_url":"https://api.github.com/repos/Informatik-HS-KL/Python-Tutorial/languages","stargazers_url":"https://api.github.com/repos/Informatik-HS-KL/Python-Tutorial/stargazers","contributors_url":"https://api.github.com/repos/Informatik-HS-KL/Python-Tutorial/contributors","subscribers_url":"https://api.github.com/repos/Informatik-HS-KL/Python-Tutorial/subscribers","subscription_url":"https://api.github.com/repos/Informatik-HS-KL/Python-Tutorial/subscription","commits_url":"https://api.github.com/repos/Informatik-HS-KL/Python-Tutorial/commits{/sha}","git_commits_url":"https://api.github.com/repos/Informatik-HS-KL/Python-Tutorial/git/commits{/sha}","comments_url":"https://api.github.com/repos/Informatik-HS-KL/Python-Tutorial/comments{/number}","issue_comment_url":"https://api.github.com/repos/Informatik-HS-KL/Python-Tutorial/issues/comments{/number}","contents_url":"https://api.github.com/repos/Informatik-HS-KL/Python-Tutorial/contents/{+path}","compare_url":"https://api.github.com/repos/Informatik-HS-KL/Python-Tutorial/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Informatik-HS-KL/Python-Tutorial/merges","archive_url":"https://api.github.com/repos/Informatik-HS-KL/Python-Tutorial/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Informatik-HS-KL/Python-Tutorial/downloads","issues_url":"https://api.github.com/repos/Informatik-HS-KL/Python-Tutorial/issues{/number}","pulls_url":"https://api.github.com/repos/Informatik-HS-KL/Python-Tutorial/pulls{/number}","milestones_url":"https://api.github.com/repos/Informatik-HS-KL/Python-Tutorial/milestones{/number}","notifications_url":"https://api.github.com/repos/Informatik-HS-KL/Python-Tutorial/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Informatik-HS-KL/Python-Tutorial/labels{/name}","releases_url":"https://api.github.com/repos/Informatik-HS-KL/Python-Tutorial/releases{/id}","deployments_url":"https://api.github.com/repos/Informatik-HS-KL/Python-Tutorial/deployments","created_at":"2018-10-17T13:31:12Z","updated_at":"2018-11-20T09:31:57Z","pushed_at":"2018-11-27T07:21:29Z","git_url":"git://github.com/Informatik-HS-KL/Python-Tutorial.git","ssh_url":"[email protected]:Informatik-HS-KL/Python-Tutorial.git","clone_url":"https://github.com/Informatik-HS-KL/Python-Tutorial.git","svn_url":"https://github.com/Informatik-HS-KL/Python-Tutorial","homepage":"","size":663,"stargazers_count":1,"watchers_count":1,"language":"TeX","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"archived":false,"open_issues_count":27,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":16,"open_issues":27,"watchers":1,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/Informatik-HS-KL/Python-Tutorial/pulls/23"},"html":{"href":"https://github.com/Informatik-HS-KL/Python-Tutorial/pull/23"},"issue":{"href":"https://api.github.com/repos/Informatik-HS-KL/Python-Tutorial/issues/23"},"comments":{"href":"https://api.github.com/repos/Informatik-HS-KL/Python-Tutorial/issues/23/comments"},"review_comments":{"href":"https://api.github.com/repos/Informatik-HS-KL/Python-Tutorial/pulls/23/comments"},"review_comment":{"href":"https://api.github.com/repos/Informatik-HS-KL/Python-Tutorial/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Informatik-HS-KL/Python-Tutorial/pulls/23/commits"},"statuses":{"href":"https://api.github.com/repos/Informatik-HS-KL/Python-Tutorial/statuses/aae0d72bba0b2ae06617b5172a7707f42261ddf8"}},"author_association":"COLLABORATOR"}} | {
"id": 153462071,
"name": "Informatik-HS-KL/Python-Tutorial",
"url": "https://api.github.com/repos/Informatik-HS-KL/Python-Tutorial"
} | {
"id": 28858959,
"login": "Callesto1",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/28858959?",
"url": "https://api.github.com/users/Callesto1"
} | {
"id": 20774205,
"login": "Informatik-HS-KL",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/20774205?",
"url": "https://api.github.com/orgs/Informatik-HS-KL"
} | 2018-11-27T07:30:41 | 8652366481 | {"actor":{"display_login":"Callesto1"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/pytorch/glow/pulls/comments/241159448","pull_request_review_id":184361016,"id":241159448,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MTE1OTQ0OA==","diff_hunk":"@@ -116,8 +117,9 @@ QuantizationTransform32To8 quantizeScaleOffset32To8(float scale,\n /// Calculate TensorQuantizationParams based on the clipped \\p min and \\p max\n /// floating point range and using the quantization method described\n /// by \\p schema.\n-TensorQuantizationParams chooseQuantizationParams(float min, float max,\n- Schema schema = Asymmetric);\n+TensorQuantizationParams\n+chooseQuantizationParams(float min, float max, Schema schema = Asymmetric,\n+ ElemKind Ty = ElemKind::Int8QTy);","path":"include/glow/Quantization/Base/Base.h","position":29,"original_position":29,"commit_id":"9400054895b6309f32dc5d0012f193de91aa4130","original_commit_id":"9400054895b6309f32dc5d0012f193de91aa4130","user":{"login":"rdzhabarov","id":34466929,"node_id":"MDQ6VXNlcjM0NDY2OTI5","avatar_url":"https://avatars0.githubusercontent.com/u/34466929?v=4","gravatar_id":"","url":"https://api.github.com/users/rdzhabarov","html_url":"https://github.com/rdzhabarov","followers_url":"https://api.github.com/users/rdzhabarov/followers","following_url":"https://api.github.com/users/rdzhabarov/following{/other_user}","gists_url":"https://api.github.com/users/rdzhabarov/gists{/gist_id}","starred_url":"https://api.github.com/users/rdzhabarov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rdzhabarov/subscriptions","organizations_url":"https://api.github.com/users/rdzhabarov/orgs","repos_url":"https://api.github.com/users/rdzhabarov/repos","events_url":"https://api.github.com/users/rdzhabarov/events{/privacy}","received_events_url":"https://api.github.com/users/rdzhabarov/received_events","type":"User","site_admin":false},"body":"need to update comment.","created_at":"2018-12-12T19:43:22Z","updated_at":"2018-12-12T19:47:12Z","html_url":"https://github.com/pytorch/glow/pull/2167#discussion_r241159448","pull_request_url":"https://api.github.com/repos/pytorch/glow/pulls/2167","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/pytorch/glow/pulls/comments/241159448"},"html":{"href":"https://github.com/pytorch/glow/pull/2167#discussion_r241159448"},"pull_request":{"href":"https://api.github.com/repos/pytorch/glow/pulls/2167"}}},"pull_request":{"url":"https://api.github.com/repos/pytorch/glow/pulls/2167","id":238030139,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM4MDMwMTM5","html_url":"https://github.com/pytorch/glow/pull/2167","diff_url":"https://github.com/pytorch/glow/pull/2167.diff","patch_url":"https://github.com/pytorch/glow/pull/2167.patch","issue_url":"https://api.github.com/repos/pytorch/glow/issues/2167","number":2167,"state":"open","locked":false,"title":"Make sure we can quantize constant tensors to int8, int16, int32 with all schema","user":{"login":"tlepley-cadence","id":42064208,"node_id":"MDQ6VXNlcjQyMDY0MjA4","avatar_url":"https://avatars2.githubusercontent.com/u/42064208?v=4","gravatar_id":"","url":"https://api.github.com/users/tlepley-cadence","html_url":"https://github.com/tlepley-cadence","followers_url":"https://api.github.com/users/tlepley-cadence/followers","following_url":"https://api.github.com/users/tlepley-cadence/following{/other_user}","gists_url":"https://api.github.com/users/tlepley-cadence/gists{/gist_id}","starred_url":"https://api.github.com/users/tlepley-cadence/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tlepley-cadence/subscriptions","organizations_url":"https://api.github.com/users/tlepley-cadence/orgs","repos_url":"https://api.github.com/users/tlepley-cadence/repos","events_url":"https://api.github.com/users/tlepley-cadence/events{/privacy}","received_events_url":"https://api.github.com/users/tlepley-cadence/received_events","type":"User","site_admin":false},"body":"*Description*: \r\nExtend `chooseQuantizationParams()`, `quantize()`, `dequantize()` and `convertConstant()` functions to support any quantized type and any quantization scheme.\r\n\r\nEDIT: for consistency with the new interface of `chooseQuantizationParams`, I renamed the internal enum `SymmetricWithUInt8` into `SymmetricWithUnsigned`. The user option doesn't change in this PR, but the idea is to have later 2 options: `quantization-type` that gives the base quantization type (int8, int16 etc..) and `quantization-schema` that tells the way float should be converted to this base quantization type.\r\n\r\n@nadavrot This is a step related to what we discussed in #2078 for having a more generic support in Glow for quantization data types. \r\n\r\n*Testing*:\r\nExtended test `quantizeTensor` to test all combiantion: Qtype/Qscheme\r\n\r\n*Documentation*: N/A","created_at":"2018-12-12T13:04:58Z","updated_at":"2018-12-12T19:47:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"269a6a76defcc06d3566c88c86b2350d3d155e84","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":706497924,"node_id":"MDU6TGFiZWw3MDY0OTc5MjQ=","url":"https://api.github.com/repos/pytorch/glow/labels/CLA%20Signed","name":"CLA Signed","color":"009900","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/pytorch/glow/pulls/2167/commits","review_comments_url":"https://api.github.com/repos/pytorch/glow/pulls/2167/comments","review_comment_url":"https://api.github.com/repos/pytorch/glow/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pytorch/glow/issues/2167/comments","statuses_url":"https://api.github.com/repos/pytorch/glow/statuses/9400054895b6309f32dc5d0012f193de91aa4130","head":{"label":"Cadence-TIP-AI:cadence/tl/more-int16","ref":"cadence/tl/more-int16","sha":"9400054895b6309f32dc5d0012f193de91aa4130","user":{"login":"Cadence-TIP-AI","id":42153068,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyMTUzMDY4","avatar_url":"https://avatars0.githubusercontent.com/u/42153068?v=4","gravatar_id":"","url":"https://api.github.com/users/Cadence-TIP-AI","html_url":"https://github.com/Cadence-TIP-AI","followers_url":"https://api.github.com/users/Cadence-TIP-AI/followers","following_url":"https://api.github.com/users/Cadence-TIP-AI/following{/other_user}","gists_url":"https://api.github.com/users/Cadence-TIP-AI/gists{/gist_id}","starred_url":"https://api.github.com/users/Cadence-TIP-AI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cadence-TIP-AI/subscriptions","organizations_url":"https://api.github.com/users/Cadence-TIP-AI/orgs","repos_url":"https://api.github.com/users/Cadence-TIP-AI/repos","events_url":"https://api.github.com/users/Cadence-TIP-AI/events{/privacy}","received_events_url":"https://api.github.com/users/Cadence-TIP-AI/received_events","type":"Organization","site_admin":false},"repo":{"id":143771565,"node_id":"MDEwOlJlcG9zaXRvcnkxNDM3NzE1NjU=","name":"glow","full_name":"Cadence-TIP-AI/glow","private":false,"owner":{"login":"Cadence-TIP-AI","id":42153068,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyMTUzMDY4","avatar_url":"https://avatars0.githubusercontent.com/u/42153068?v=4","gravatar_id":"","url":"https://api.github.com/users/Cadence-TIP-AI","html_url":"https://github.com/Cadence-TIP-AI","followers_url":"https://api.github.com/users/Cadence-TIP-AI/followers","following_url":"https://api.github.com/users/Cadence-TIP-AI/following{/other_user}","gists_url":"https://api.github.com/users/Cadence-TIP-AI/gists{/gist_id}","starred_url":"https://api.github.com/users/Cadence-TIP-AI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cadence-TIP-AI/subscriptions","organizations_url":"https://api.github.com/users/Cadence-TIP-AI/orgs","repos_url":"https://api.github.com/users/Cadence-TIP-AI/repos","events_url":"https://api.github.com/users/Cadence-TIP-AI/events{/privacy}","received_events_url":"https://api.github.com/users/Cadence-TIP-AI/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Cadence-TIP-AI/glow","description":"Compiler for Neural Network hardware accelerators","fork":true,"url":"https://api.github.com/repos/Cadence-TIP-AI/glow","forks_url":"https://api.github.com/repos/Cadence-TIP-AI/glow/forks","keys_url":"https://api.github.com/repos/Cadence-TIP-AI/glow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Cadence-TIP-AI/glow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Cadence-TIP-AI/glow/teams","hooks_url":"https://api.github.com/repos/Cadence-TIP-AI/glow/hooks","issue_events_url":"https://api.github.com/repos/Cadence-TIP-AI/glow/issues/events{/number}","events_url":"https://api.github.com/repos/Cadence-TIP-AI/glow/events","assignees_url":"https://api.github.com/repos/Cadence-TIP-AI/glow/assignees{/user}","branches_url":"https://api.github.com/repos/Cadence-TIP-AI/glow/branches{/branch}","tags_url":"https://api.github.com/repos/Cadence-TIP-AI/glow/tags","blobs_url":"https://api.github.com/repos/Cadence-TIP-AI/glow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Cadence-TIP-AI/glow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Cadence-TIP-AI/glow/git/refs{/sha}","trees_url":"https://api.github.com/repos/Cadence-TIP-AI/glow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Cadence-TIP-AI/glow/statuses/{sha}","languages_url":"https://api.github.com/repos/Cadence-TIP-AI/glow/languages","stargazers_url":"https://api.github.com/repos/Cadence-TIP-AI/glow/stargazers","contributors_url":"https://api.github.com/repos/Cadence-TIP-AI/glow/contributors","subscribers_url":"https://api.github.com/repos/Cadence-TIP-AI/glow/subscribers","subscription_url":"https://api.github.com/repos/Cadence-TIP-AI/glow/subscription","commits_url":"https://api.github.com/repos/Cadence-TIP-AI/glow/commits{/sha}","git_commits_url":"https://api.github.com/repos/Cadence-TIP-AI/glow/git/commits{/sha}","comments_url":"https://api.github.com/repos/Cadence-TIP-AI/glow/comments{/number}","issue_comment_url":"https://api.github.com/repos/Cadence-TIP-AI/glow/issues/comments{/number}","contents_url":"https://api.github.com/repos/Cadence-TIP-AI/glow/contents/{+path}","compare_url":"https://api.github.com/repos/Cadence-TIP-AI/glow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Cadence-TIP-AI/glow/merges","archive_url":"https://api.github.com/repos/Cadence-TIP-AI/glow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Cadence-TIP-AI/glow/downloads","issues_url":"https://api.github.com/repos/Cadence-TIP-AI/glow/issues{/number}","pulls_url":"https://api.github.com/repos/Cadence-TIP-AI/glow/pulls{/number}","milestones_url":"https://api.github.com/repos/Cadence-TIP-AI/glow/milestones{/number}","notifications_url":"https://api.github.com/repos/Cadence-TIP-AI/glow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Cadence-TIP-AI/glow/labels{/name}","releases_url":"https://api.github.com/repos/Cadence-TIP-AI/glow/releases{/id}","deployments_url":"https://api.github.com/repos/Cadence-TIP-AI/glow/deployments","created_at":"2018-08-06T19:09:08Z","updated_at":"2018-11-26T14:20:09Z","pushed_at":"2018-12-12T16:56:30Z","git_url":"git://github.com/Cadence-TIP-AI/glow.git","ssh_url":"[email protected]:Cadence-TIP-AI/glow.git","clone_url":"https://github.com/Cadence-TIP-AI/glow.git","svn_url":"https://github.com/Cadence-TIP-AI/glow","homepage":null,"size":10876,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pytorch:master","ref":"master","sha":"81f97e447ddfca3025c9fa8b3548062149621345","user":{"login":"pytorch","id":21003710,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMDAzNzEw","avatar_url":"https://avatars3.githubusercontent.com/u/21003710?v=4","gravatar_id":"","url":"https://api.github.com/users/pytorch","html_url":"https://github.com/pytorch","followers_url":"https://api.github.com/users/pytorch/followers","following_url":"https://api.github.com/users/pytorch/following{/other_user}","gists_url":"https://api.github.com/users/pytorch/gists{/gist_id}","starred_url":"https://api.github.com/users/pytorch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pytorch/subscriptions","organizations_url":"https://api.github.com/users/pytorch/orgs","repos_url":"https://api.github.com/users/pytorch/repos","events_url":"https://api.github.com/users/pytorch/events{/privacy}","received_events_url":"https://api.github.com/users/pytorch/received_events","type":"Organization","site_admin":false},"repo":{"id":105281531,"node_id":"MDEwOlJlcG9zaXRvcnkxMDUyODE1MzE=","name":"glow","full_name":"pytorch/glow","private":false,"owner":{"login":"pytorch","id":21003710,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMDAzNzEw","avatar_url":"https://avatars3.githubusercontent.com/u/21003710?v=4","gravatar_id":"","url":"https://api.github.com/users/pytorch","html_url":"https://github.com/pytorch","followers_url":"https://api.github.com/users/pytorch/followers","following_url":"https://api.github.com/users/pytorch/following{/other_user}","gists_url":"https://api.github.com/users/pytorch/gists{/gist_id}","starred_url":"https://api.github.com/users/pytorch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pytorch/subscriptions","organizations_url":"https://api.github.com/users/pytorch/orgs","repos_url":"https://api.github.com/users/pytorch/repos","events_url":"https://api.github.com/users/pytorch/events{/privacy}","received_events_url":"https://api.github.com/users/pytorch/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/pytorch/glow","description":"Compiler for Neural Network hardware accelerators","fork":false,"url":"https://api.github.com/repos/pytorch/glow","forks_url":"https://api.github.com/repos/pytorch/glow/forks","keys_url":"https://api.github.com/repos/pytorch/glow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pytorch/glow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pytorch/glow/teams","hooks_url":"https://api.github.com/repos/pytorch/glow/hooks","issue_events_url":"https://api.github.com/repos/pytorch/glow/issues/events{/number}","events_url":"https://api.github.com/repos/pytorch/glow/events","assignees_url":"https://api.github.com/repos/pytorch/glow/assignees{/user}","branches_url":"https://api.github.com/repos/pytorch/glow/branches{/branch}","tags_url":"https://api.github.com/repos/pytorch/glow/tags","blobs_url":"https://api.github.com/repos/pytorch/glow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pytorch/glow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pytorch/glow/git/refs{/sha}","trees_url":"https://api.github.com/repos/pytorch/glow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pytorch/glow/statuses/{sha}","languages_url":"https://api.github.com/repos/pytorch/glow/languages","stargazers_url":"https://api.github.com/repos/pytorch/glow/stargazers","contributors_url":"https://api.github.com/repos/pytorch/glow/contributors","subscribers_url":"https://api.github.com/repos/pytorch/glow/subscribers","subscription_url":"https://api.github.com/repos/pytorch/glow/subscription","commits_url":"https://api.github.com/repos/pytorch/glow/commits{/sha}","git_commits_url":"https://api.github.com/repos/pytorch/glow/git/commits{/sha}","comments_url":"https://api.github.com/repos/pytorch/glow/comments{/number}","issue_comment_url":"https://api.github.com/repos/pytorch/glow/issues/comments{/number}","contents_url":"https://api.github.com/repos/pytorch/glow/contents/{+path}","compare_url":"https://api.github.com/repos/pytorch/glow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pytorch/glow/merges","archive_url":"https://api.github.com/repos/pytorch/glow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pytorch/glow/downloads","issues_url":"https://api.github.com/repos/pytorch/glow/issues{/number}","pulls_url":"https://api.github.com/repos/pytorch/glow/pulls{/number}","milestones_url":"https://api.github.com/repos/pytorch/glow/milestones{/number}","notifications_url":"https://api.github.com/repos/pytorch/glow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pytorch/glow/labels{/name}","releases_url":"https://api.github.com/repos/pytorch/glow/releases{/id}","deployments_url":"https://api.github.com/repos/pytorch/glow/deployments","created_at":"2017-09-29T14:28:18Z","updated_at":"2018-12-12T19:41:36Z","pushed_at":"2018-12-12T19:41:32Z","git_url":"git://github.com/pytorch/glow.git","ssh_url":"[email protected]:pytorch/glow.git","clone_url":"https://github.com/pytorch/glow.git","svn_url":"https://github.com/pytorch/glow","homepage":null,"size":10805,"stargazers_count":1109,"watchers_count":1109,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":149,"mirror_url":null,"archived":false,"open_issues_count":83,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":149,"open_issues":83,"watchers":1109,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pytorch/glow/pulls/2167"},"html":{"href":"https://github.com/pytorch/glow/pull/2167"},"issue":{"href":"https://api.github.com/repos/pytorch/glow/issues/2167"},"comments":{"href":"https://api.github.com/repos/pytorch/glow/issues/2167/comments"},"review_comments":{"href":"https://api.github.com/repos/pytorch/glow/pulls/2167/comments"},"review_comment":{"href":"https://api.github.com/repos/pytorch/glow/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pytorch/glow/pulls/2167/commits"},"statuses":{"href":"https://api.github.com/repos/pytorch/glow/statuses/9400054895b6309f32dc5d0012f193de91aa4130"}},"author_association":"CONTRIBUTOR"}} | {
"id": 105281531,
"name": "pytorch/glow",
"url": "https://api.github.com/repos/pytorch/glow"
} | {
"id": 34466929,
"login": "rdzhabarov",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/34466929?",
"url": "https://api.github.com/users/rdzhabarov"
} | {
"id": 21003710,
"login": "pytorch",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/21003710?",
"url": "https://api.github.com/orgs/pytorch"
} | 2018-12-12T19:43:22 | 8743651418 | {"actor":{"display_login":"rdzhabarov"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/cilium/cilium/pulls/comments/224909857","pull_request_review_id":164402541,"id":224909857,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNDkwOTg1Nw==","diff_hunk":"@@ -0,0 +1,57 @@\n+// Copyright 2018 Authors of Cilium\n+//\n+// Licensed under the Apache License, Version 2.0 (the \"License\");\n+// you may not use this file except in compliance with the License.\n+// You may obtain a copy of the License at\n+//\n+// http://www.apache.org/licenses/LICENSE-2.0\n+//\n+// Unless required by applicable law or agreed to in writing, software\n+// distributed under the License is distributed on an \"AS IS\" BASIS,\n+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+// See the License for the specific language governing permissions and\n+// limitations under the License.\n+\n+package format\n+\n+import (\n+\t\"strconv\"\n+\t\"strings\"\n+\n+\t\"github.com/spf13/pflag\"\n+)\n+\n+type Uint16Flags []uint16","path":"pkg/monitor/format/flags.go","position":24,"original_position":24,"commit_id":"8dbacf1809f9d6ce40e5bd44b8dbe1edf56f9a14","original_commit_id":"8dbacf1809f9d6ce40e5bd44b8dbe1edf56f9a14","user":{"login":"houndci-bot","id":6697940,"node_id":"MDQ6VXNlcjY2OTc5NDA=","avatar_url":"https://avatars0.githubusercontent.com/u/6697940?v=4","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"exported type Uint16Flags should have comment or be unexported","created_at":"2018-10-12T20:43:57Z","updated_at":"2018-10-12T20:43:57Z","html_url":"https://github.com/cilium/cilium/pull/5873#discussion_r224909857","pull_request_url":"https://api.github.com/repos/cilium/cilium/pulls/5873","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/cilium/cilium/pulls/comments/224909857"},"html":{"href":"https://github.com/cilium/cilium/pull/5873#discussion_r224909857"},"pull_request":{"href":"https://api.github.com/repos/cilium/cilium/pulls/5873"}}},"pull_request":{"url":"https://api.github.com/repos/cilium/cilium/pulls/5873","id":222335012,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyMzM1MDEy","html_url":"https://github.com/cilium/cilium/pull/5873","diff_url":"https://github.com/cilium/cilium/pull/5873.diff","patch_url":"https://github.com/cilium/cilium/pull/5873.patch","issue_url":"https://api.github.com/repos/cilium/cilium/issues/5873","number":5873,"state":"open","locked":false,"title":"Tool for debugging ring-buffer-crash.dump","user":{"login":"joestringer","id":1243336,"node_id":"MDQ6VXNlcjEyNDMzMzY=","avatar_url":"https://avatars2.githubusercontent.com/u/1243336?v=4","gravatar_id":"","url":"https://api.github.com/users/joestringer","html_url":"https://github.com/joestringer","followers_url":"https://api.github.com/users/joestringer/followers","following_url":"https://api.github.com/users/joestringer/following{/other_user}","gists_url":"https://api.github.com/users/joestringer/gists{/gist_id}","starred_url":"https://api.github.com/users/joestringer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joestringer/subscriptions","organizations_url":"https://api.github.com/users/joestringer/orgs","repos_url":"https://api.github.com/users/joestringer/repos","events_url":"https://api.github.com/users/joestringer/events{/privacy}","received_events_url":"https://api.github.com/users/joestringer/received_events","type":"User","site_admin":false},"body":" The dumps from the bpf package are difficult to parse by eye or hand.\r\n This tool takes such a file in as input and attempts to render it into\r\n something readable by humans.\r\n \r\n WIP: At the moment it tries to read events from the dump of the page\r\n using the same CGO extensions that are used for dumping from the kernel.\r\n Unfortunately, Golang is currently complaining that it passes pointers\r\n to Go pointers which means it can't iterate through the actual data.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/cilium/cilium/5873)\n<!-- Reviewable:end -->\n","created_at":"2018-10-12T02:55:52Z","updated_at":"2018-10-12T20:43:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dc34b8ab50a8ce2f72cefbbdf11dac745cd3a994","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[{"name":"bpf","id":2519779,"node_id":"MDQ6VGVhbTI1MTk3Nzk=","slug":"bpf","description":"BPF datapath","privacy":"closed","url":"https://api.github.com/teams/2519779","members_url":"https://api.github.com/teams/2519779/members{/member}","repositories_url":"https://api.github.com/teams/2519779/repos","permission":"pull"},{"name":"docs","id":2519789,"node_id":"MDQ6VGVhbTI1MTk3ODk=","slug":"docs","description":"Documentation","privacy":"closed","url":"https://api.github.com/teams/2519789","members_url":"https://api.github.com/teams/2519789/members{/member}","repositories_url":"https://api.github.com/teams/2519789/repos","permission":"pull"},{"name":"monitor","id":2519793,"node_id":"MDQ6VGVhbTI1MTk3OTM=","slug":"monitor","description":"Monitoring layer","privacy":"closed","url":"https://api.github.com/teams/2519793","members_url":"https://api.github.com/teams/2519793/members{/member}","repositories_url":"https://api.github.com/teams/2519793/repos","permission":"pull"},{"name":"cli","id":2519794,"node_id":"MDQ6VGVhbTI1MTk3OTQ=","slug":"cli","description":"Command Line Interface tools","privacy":"closed","url":"https://api.github.com/teams/2519794","members_url":"https://api.github.com/teams/2519794/members{/member}","repositories_url":"https://api.github.com/teams/2519794/repos","permission":"pull"},{"name":"api","id":2519795,"node_id":"MDQ6VGVhbTI1MTk3OTU=","slug":"api","description":"REST API","privacy":"closed","url":"https://api.github.com/teams/2519795","members_url":"https://api.github.com/teams/2519795/members{/member}","repositories_url":"https://api.github.com/teams/2519795/repos","permission":"pull"},{"name":"janitors","id":2519796,"node_id":"MDQ6VGVhbTI1MTk3OTY=","slug":"janitors","description":"Rotating team of janitors for unowned code","privacy":"closed","url":"https://api.github.com/teams/2519796","members_url":"https://api.github.com/teams/2519796/members{/member}","repositories_url":"https://api.github.com/teams/2519796/repos","permission":"pull"},{"name":"contributing","id":2519797,"node_id":"MDQ6VGVhbTI1MTk3OTc=","slug":"contributing","description":"Developer contribution process","privacy":"closed","url":"https://api.github.com/teams/2519797","members_url":"https://api.github.com/teams/2519797/members{/member}","repositories_url":"https://api.github.com/teams/2519797/repos","permission":"pull"}],"labels":[{"id":722357775,"node_id":"MDU6TGFiZWw3MjIzNTc3NzU=","url":"https://api.github.com/repos/cilium/cilium/labels/area/misc","name":"area/misc","color":"49e59c","default":false},{"id":403244562,"node_id":"MDU6TGFiZWw0MDMyNDQ1NjI=","url":"https://api.github.com/repos/cilium/cilium/labels/wip","name":"wip","color":"fef2c0","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/cilium/cilium/pulls/5873/commits","review_comments_url":"https://api.github.com/repos/cilium/cilium/pulls/5873/comments","review_comment_url":"https://api.github.com/repos/cilium/cilium/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cilium/cilium/issues/5873/comments","statuses_url":"https://api.github.com/repos/cilium/cilium/statuses/8dbacf1809f9d6ce40e5bd44b8dbe1edf56f9a14","head":{"label":"cilium:pr/ring-buffer-dump-tool","ref":"pr/ring-buffer-dump-tool","sha":"8dbacf1809f9d6ce40e5bd44b8dbe1edf56f9a14","user":{"login":"cilium","id":21054566,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMDU0NTY2","avatar_url":"https://avatars0.githubusercontent.com/u/21054566?v=4","gravatar_id":"","url":"https://api.github.com/users/cilium","html_url":"https://github.com/cilium","followers_url":"https://api.github.com/users/cilium/followers","following_url":"https://api.github.com/users/cilium/following{/other_user}","gists_url":"https://api.github.com/users/cilium/gists{/gist_id}","starred_url":"https://api.github.com/users/cilium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cilium/subscriptions","organizations_url":"https://api.github.com/users/cilium/orgs","repos_url":"https://api.github.com/users/cilium/repos","events_url":"https://api.github.com/users/cilium/events{/privacy}","received_events_url":"https://api.github.com/users/cilium/received_events","type":"Organization","site_admin":false},"repo":{"id":48109239,"node_id":"MDEwOlJlcG9zaXRvcnk0ODEwOTIzOQ==","name":"cilium","full_name":"cilium/cilium","private":false,"owner":{"login":"cilium","id":21054566,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMDU0NTY2","avatar_url":"https://avatars0.githubusercontent.com/u/21054566?v=4","gravatar_id":"","url":"https://api.github.com/users/cilium","html_url":"https://github.com/cilium","followers_url":"https://api.github.com/users/cilium/followers","following_url":"https://api.github.com/users/cilium/following{/other_user}","gists_url":"https://api.github.com/users/cilium/gists{/gist_id}","starred_url":"https://api.github.com/users/cilium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cilium/subscriptions","organizations_url":"https://api.github.com/users/cilium/orgs","repos_url":"https://api.github.com/users/cilium/repos","events_url":"https://api.github.com/users/cilium/events{/privacy}","received_events_url":"https://api.github.com/users/cilium/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/cilium/cilium","description":"HTTP, gRPC, and Kafka Aware Security and Networking for Containers with BPF and XDP","fork":false,"url":"https://api.github.com/repos/cilium/cilium","forks_url":"https://api.github.com/repos/cilium/cilium/forks","keys_url":"https://api.github.com/repos/cilium/cilium/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cilium/cilium/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cilium/cilium/teams","hooks_url":"https://api.github.com/repos/cilium/cilium/hooks","issue_events_url":"https://api.github.com/repos/cilium/cilium/issues/events{/number}","events_url":"https://api.github.com/repos/cilium/cilium/events","assignees_url":"https://api.github.com/repos/cilium/cilium/assignees{/user}","branches_url":"https://api.github.com/repos/cilium/cilium/branches{/branch}","tags_url":"https://api.github.com/repos/cilium/cilium/tags","blobs_url":"https://api.github.com/repos/cilium/cilium/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cilium/cilium/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cilium/cilium/git/refs{/sha}","trees_url":"https://api.github.com/repos/cilium/cilium/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cilium/cilium/statuses/{sha}","languages_url":"https://api.github.com/repos/cilium/cilium/languages","stargazers_url":"https://api.github.com/repos/cilium/cilium/stargazers","contributors_url":"https://api.github.com/repos/cilium/cilium/contributors","subscribers_url":"https://api.github.com/repos/cilium/cilium/subscribers","subscription_url":"https://api.github.com/repos/cilium/cilium/subscription","commits_url":"https://api.github.com/repos/cilium/cilium/commits{/sha}","git_commits_url":"https://api.github.com/repos/cilium/cilium/git/commits{/sha}","comments_url":"https://api.github.com/repos/cilium/cilium/comments{/number}","issue_comment_url":"https://api.github.com/repos/cilium/cilium/issues/comments{/number}","contents_url":"https://api.github.com/repos/cilium/cilium/contents/{+path}","compare_url":"https://api.github.com/repos/cilium/cilium/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cilium/cilium/merges","archive_url":"https://api.github.com/repos/cilium/cilium/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cilium/cilium/downloads","issues_url":"https://api.github.com/repos/cilium/cilium/issues{/number}","pulls_url":"https://api.github.com/repos/cilium/cilium/pulls{/number}","milestones_url":"https://api.github.com/repos/cilium/cilium/milestones{/number}","notifications_url":"https://api.github.com/repos/cilium/cilium/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cilium/cilium/labels{/name}","releases_url":"https://api.github.com/repos/cilium/cilium/releases{/id}","deployments_url":"https://api.github.com/repos/cilium/cilium/deployments","created_at":"2015-12-16T12:33:31Z","updated_at":"2018-10-12T20:28:59Z","pushed_at":"2018-10-12T20:43:44Z","git_url":"git://github.com/cilium/cilium.git","ssh_url":"[email protected]:cilium/cilium.git","clone_url":"https://github.com/cilium/cilium.git","svn_url":"https://github.com/cilium/cilium","homepage":"","size":65044,"stargazers_count":2906,"watchers_count":2906,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":259,"mirror_url":null,"archived":false,"open_issues_count":514,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":259,"open_issues":514,"watchers":2906,"default_branch":"master"}},"base":{"label":"cilium:master","ref":"master","sha":"4ceea609c57f2eb91c27a71cfc3089186293b578","user":{"login":"cilium","id":21054566,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMDU0NTY2","avatar_url":"https://avatars0.githubusercontent.com/u/21054566?v=4","gravatar_id":"","url":"https://api.github.com/users/cilium","html_url":"https://github.com/cilium","followers_url":"https://api.github.com/users/cilium/followers","following_url":"https://api.github.com/users/cilium/following{/other_user}","gists_url":"https://api.github.com/users/cilium/gists{/gist_id}","starred_url":"https://api.github.com/users/cilium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cilium/subscriptions","organizations_url":"https://api.github.com/users/cilium/orgs","repos_url":"https://api.github.com/users/cilium/repos","events_url":"https://api.github.com/users/cilium/events{/privacy}","received_events_url":"https://api.github.com/users/cilium/received_events","type":"Organization","site_admin":false},"repo":{"id":48109239,"node_id":"MDEwOlJlcG9zaXRvcnk0ODEwOTIzOQ==","name":"cilium","full_name":"cilium/cilium","private":false,"owner":{"login":"cilium","id":21054566,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMDU0NTY2","avatar_url":"https://avatars0.githubusercontent.com/u/21054566?v=4","gravatar_id":"","url":"https://api.github.com/users/cilium","html_url":"https://github.com/cilium","followers_url":"https://api.github.com/users/cilium/followers","following_url":"https://api.github.com/users/cilium/following{/other_user}","gists_url":"https://api.github.com/users/cilium/gists{/gist_id}","starred_url":"https://api.github.com/users/cilium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cilium/subscriptions","organizations_url":"https://api.github.com/users/cilium/orgs","repos_url":"https://api.github.com/users/cilium/repos","events_url":"https://api.github.com/users/cilium/events{/privacy}","received_events_url":"https://api.github.com/users/cilium/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/cilium/cilium","description":"HTTP, gRPC, and Kafka Aware Security and Networking for Containers with BPF and XDP","fork":false,"url":"https://api.github.com/repos/cilium/cilium","forks_url":"https://api.github.com/repos/cilium/cilium/forks","keys_url":"https://api.github.com/repos/cilium/cilium/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cilium/cilium/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cilium/cilium/teams","hooks_url":"https://api.github.com/repos/cilium/cilium/hooks","issue_events_url":"https://api.github.com/repos/cilium/cilium/issues/events{/number}","events_url":"https://api.github.com/repos/cilium/cilium/events","assignees_url":"https://api.github.com/repos/cilium/cilium/assignees{/user}","branches_url":"https://api.github.com/repos/cilium/cilium/branches{/branch}","tags_url":"https://api.github.com/repos/cilium/cilium/tags","blobs_url":"https://api.github.com/repos/cilium/cilium/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cilium/cilium/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cilium/cilium/git/refs{/sha}","trees_url":"https://api.github.com/repos/cilium/cilium/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cilium/cilium/statuses/{sha}","languages_url":"https://api.github.com/repos/cilium/cilium/languages","stargazers_url":"https://api.github.com/repos/cilium/cilium/stargazers","contributors_url":"https://api.github.com/repos/cilium/cilium/contributors","subscribers_url":"https://api.github.com/repos/cilium/cilium/subscribers","subscription_url":"https://api.github.com/repos/cilium/cilium/subscription","commits_url":"https://api.github.com/repos/cilium/cilium/commits{/sha}","git_commits_url":"https://api.github.com/repos/cilium/cilium/git/commits{/sha}","comments_url":"https://api.github.com/repos/cilium/cilium/comments{/number}","issue_comment_url":"https://api.github.com/repos/cilium/cilium/issues/comments{/number}","contents_url":"https://api.github.com/repos/cilium/cilium/contents/{+path}","compare_url":"https://api.github.com/repos/cilium/cilium/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cilium/cilium/merges","archive_url":"https://api.github.com/repos/cilium/cilium/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cilium/cilium/downloads","issues_url":"https://api.github.com/repos/cilium/cilium/issues{/number}","pulls_url":"https://api.github.com/repos/cilium/cilium/pulls{/number}","milestones_url":"https://api.github.com/repos/cilium/cilium/milestones{/number}","notifications_url":"https://api.github.com/repos/cilium/cilium/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cilium/cilium/labels{/name}","releases_url":"https://api.github.com/repos/cilium/cilium/releases{/id}","deployments_url":"https://api.github.com/repos/cilium/cilium/deployments","created_at":"2015-12-16T12:33:31Z","updated_at":"2018-10-12T20:28:59Z","pushed_at":"2018-10-12T20:43:44Z","git_url":"git://github.com/cilium/cilium.git","ssh_url":"[email protected]:cilium/cilium.git","clone_url":"https://github.com/cilium/cilium.git","svn_url":"https://github.com/cilium/cilium","homepage":"","size":65044,"stargazers_count":2906,"watchers_count":2906,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":259,"mirror_url":null,"archived":false,"open_issues_count":514,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":259,"open_issues":514,"watchers":2906,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cilium/cilium/pulls/5873"},"html":{"href":"https://github.com/cilium/cilium/pull/5873"},"issue":{"href":"https://api.github.com/repos/cilium/cilium/issues/5873"},"comments":{"href":"https://api.github.com/repos/cilium/cilium/issues/5873/comments"},"review_comments":{"href":"https://api.github.com/repos/cilium/cilium/pulls/5873/comments"},"review_comment":{"href":"https://api.github.com/repos/cilium/cilium/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cilium/cilium/pulls/5873/commits"},"statuses":{"href":"https://api.github.com/repos/cilium/cilium/statuses/8dbacf1809f9d6ce40e5bd44b8dbe1edf56f9a14"}},"author_association":"CONTRIBUTOR"}} | {
"id": 48109239,
"name": "cilium/cilium",
"url": "https://api.github.com/repos/cilium/cilium"
} | {
"id": 6697940,
"login": "houndci-bot",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6697940?",
"url": "https://api.github.com/users/houndci-bot"
} | {
"id": 21054566,
"login": "cilium",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/21054566?",
"url": "https://api.github.com/orgs/cilium"
} | 2018-10-12T20:43:57 | 8413577110 | {"actor":{"display_login":"houndci-bot"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/cilium/cilium/pulls/comments/202846949","pull_request_review_id":137622920,"id":202846949,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMjg0Njk0OQ==","diff_hunk":"@@ -276,27 +275,25 @@ enum {\n \n /* Magic skb->mark markers which identify packets originating from the host\n *\n- * The upper 16 bits contain the magic marker values which indicate whether\n- * the packet is coming from an ingress or egress proxy, or a local process.\n+ * The upper 16 bits contain\n+ * - the magic marker values which indicate whether the packet is coming from\n+ * an ingress or egress proxy, or a local process.\n+ * - the cluster id\n *\n * The lower 16 bits may contain the security identity of the original source\n * endpoint.\n */\n-#define MARK_MAGIC_HOST_MASK\t\t0xFFF\n-#define MARK_MAGIC_PROXY_INGRESS\t0xFEA\n-#define MARK_MAGIC_PROXY_EGRESS\t\t0xFEB\n-#define MARK_MAGIC_HOST\t\t\t0xFEC\n-#define MARK_IDENTITY_MASK\t\t(0xFFFF << 16)\n-\n-#define SOURCE_INGRESS_PROXY 1\n-#define SOURCE_EGRESS_PROXY 2\n+#define MARK_MAGIC_HOST_MASK\t\t0xF00\n+#define MARK_MAGIC_PROXY_INGRESS\t0xA00\n+#define MARK_MAGIC_PROXY_EGRESS\t\t0xB00\n+#define MARK_MAGIC_HOST\t\t\t0xC00","path":"bpf/lib/common.h","position":44,"original_position":44,"commit_id":"1b156c6d4f206d074f67d84c6d5780304bca2b80","original_commit_id":"1b156c6d4f206d074f67d84c6d5780304bca2b80","user":{"login":"joestringer","id":1243336,"node_id":"MDQ6VXNlcjEyNDMzMzY=","avatar_url":"https://avatars2.githubusercontent.com/u/1243336?v=4","gravatar_id":"","url":"https://api.github.com/users/joestringer","html_url":"https://github.com/joestringer","followers_url":"https://api.github.com/users/joestringer/followers","following_url":"https://api.github.com/users/joestringer/following{/other_user}","gists_url":"https://api.github.com/users/joestringer/gists{/gist_id}","starred_url":"https://api.github.com/users/joestringer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joestringer/subscriptions","organizations_url":"https://api.github.com/users/joestringer/orgs","repos_url":"https://api.github.com/users/joestringer/repos","events_url":"https://api.github.com/users/joestringer/events{/privacy}","received_events_url":"https://api.github.com/users/joestringer/received_events","type":"User","site_admin":false},"body":"Nope, that's basically it.","created_at":"2018-07-16T22:39:23Z","updated_at":"2018-07-16T22:39:23Z","html_url":"https://github.com/cilium/cilium/pull/4858#discussion_r202846949","pull_request_url":"https://api.github.com/repos/cilium/cilium/pulls/4858","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/cilium/cilium/pulls/comments/202846949"},"html":{"href":"https://github.com/cilium/cilium/pull/4858#discussion_r202846949"},"pull_request":{"href":"https://api.github.com/repos/cilium/cilium/pulls/4858"}},"in_reply_to_id":202831975},"pull_request":{"url":"https://api.github.com/repos/cilium/cilium/pulls/4858","id":201741667,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxNzQxNjY3","html_url":"https://github.com/cilium/cilium/pull/4858","diff_url":"https://github.com/cilium/cilium/pull/4858.diff","patch_url":"https://github.com/cilium/cilium/pull/4858.patch","issue_url":"https://api.github.com/repos/cilium/cilium/issues/4858","number":4858,"state":"open","locked":false,"title":"bpf: Allow to use 24 bits for security identities","user":{"login":"tgraf","id":1417913,"node_id":"MDQ6VXNlcjE0MTc5MTM=","avatar_url":"https://avatars1.githubusercontent.com/u/1417913?v=4","gravatar_id":"","url":"https://api.github.com/users/tgraf","html_url":"https://github.com/tgraf","followers_url":"https://api.github.com/users/tgraf/followers","following_url":"https://api.github.com/users/tgraf/following{/other_user}","gists_url":"https://api.github.com/users/tgraf/gists{/gist_id}","starred_url":"https://api.github.com/users/tgraf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tgraf/subscriptions","organizations_url":"https://api.github.com/users/tgraf/orgs","repos_url":"https://api.github.com/users/tgraf/repos","events_url":"https://api.github.com/users/tgraf/events{/privacy}","received_events_url":"https://api.github.com/users/tgraf/received_events","type":"User","site_admin":false},"body":"This changes the BPF datapath to use 32 bit integers to handle security\r\nidentities. It also adjusts the skb mark handling to split up the identity and\r\nuse part of the existing magic marker to store the new extended 8 bits of the\r\nidentity.\r\n\r\nThis commit does not extend the the allocator to use additional identity space\r\nyet.\r\n\r\nRequired for #4727\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/cilium/cilium/4858)\n<!-- Reviewable:end -->\n","created_at":"2018-07-16T19:50:15Z","updated_at":"2018-07-16T22:39:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3d97bead2544e0413014b42c5b79b5eb4c935ec0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[{"name":"proxy","id":2519788,"node_id":"MDQ6VGVhbTI1MTk3ODg=","slug":"proxy","description":"Proxy layer","privacy":"closed","url":"https://api.github.com/teams/2519788","members_url":"https://api.github.com/teams/2519788/members{/member}","repositories_url":"https://api.github.com/teams/2519788/repos","permission":"pull"},{"name":"endpoint","id":2519798,"node_id":"MDQ6VGVhbTI1MTk3OTg=","slug":"endpoint","description":"Endpoint abstraction","privacy":"closed","url":"https://api.github.com/teams/2519798","members_url":"https://api.github.com/teams/2519798/members{/member}","repositories_url":"https://api.github.com/teams/2519798/repos","permission":"pull"}],"labels":[{"id":721252768,"node_id":"MDU6TGFiZWw3MjEyNTI3Njg=","url":"https://api.github.com/repos/cilium/cilium/labels/area/datapath","name":"area/datapath","color":"bfdadc","default":false},{"id":721424175,"node_id":"MDU6TGFiZWw3MjE0MjQxNzU=","url":"https://api.github.com/repos/cilium/cilium/labels/area/proxy","name":"area/proxy","color":"fef2c0","default":false},{"id":300384441,"node_id":"MDU6TGFiZWwzMDAzODQ0NDE=","url":"https://api.github.com/repos/cilium/cilium/labels/kind/enhancement","name":"kind/enhancement","color":"84b6eb","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/cilium/cilium/pulls/4858/commits","review_comments_url":"https://api.github.com/repos/cilium/cilium/pulls/4858/comments","review_comment_url":"https://api.github.com/repos/cilium/cilium/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cilium/cilium/issues/4858/comments","statuses_url":"https://api.github.com/repos/cilium/cilium/statuses/1b156c6d4f206d074f67d84c6d5780304bca2b80","head":{"label":"cilium:32bit-identity","ref":"32bit-identity","sha":"1b156c6d4f206d074f67d84c6d5780304bca2b80","user":{"login":"cilium","id":21054566,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMDU0NTY2","avatar_url":"https://avatars0.githubusercontent.com/u/21054566?v=4","gravatar_id":"","url":"https://api.github.com/users/cilium","html_url":"https://github.com/cilium","followers_url":"https://api.github.com/users/cilium/followers","following_url":"https://api.github.com/users/cilium/following{/other_user}","gists_url":"https://api.github.com/users/cilium/gists{/gist_id}","starred_url":"https://api.github.com/users/cilium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cilium/subscriptions","organizations_url":"https://api.github.com/users/cilium/orgs","repos_url":"https://api.github.com/users/cilium/repos","events_url":"https://api.github.com/users/cilium/events{/privacy}","received_events_url":"https://api.github.com/users/cilium/received_events","type":"Organization","site_admin":false},"repo":{"id":48109239,"node_id":"MDEwOlJlcG9zaXRvcnk0ODEwOTIzOQ==","name":"cilium","full_name":"cilium/cilium","owner":{"login":"cilium","id":21054566,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMDU0NTY2","avatar_url":"https://avatars0.githubusercontent.com/u/21054566?v=4","gravatar_id":"","url":"https://api.github.com/users/cilium","html_url":"https://github.com/cilium","followers_url":"https://api.github.com/users/cilium/followers","following_url":"https://api.github.com/users/cilium/following{/other_user}","gists_url":"https://api.github.com/users/cilium/gists{/gist_id}","starred_url":"https://api.github.com/users/cilium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cilium/subscriptions","organizations_url":"https://api.github.com/users/cilium/orgs","repos_url":"https://api.github.com/users/cilium/repos","events_url":"https://api.github.com/users/cilium/events{/privacy}","received_events_url":"https://api.github.com/users/cilium/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cilium/cilium","description":"HTTP, gRPC, and Kafka Aware Security and Networking for Containers with BPF and XDP","fork":false,"url":"https://api.github.com/repos/cilium/cilium","forks_url":"https://api.github.com/repos/cilium/cilium/forks","keys_url":"https://api.github.com/repos/cilium/cilium/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cilium/cilium/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cilium/cilium/teams","hooks_url":"https://api.github.com/repos/cilium/cilium/hooks","issue_events_url":"https://api.github.com/repos/cilium/cilium/issues/events{/number}","events_url":"https://api.github.com/repos/cilium/cilium/events","assignees_url":"https://api.github.com/repos/cilium/cilium/assignees{/user}","branches_url":"https://api.github.com/repos/cilium/cilium/branches{/branch}","tags_url":"https://api.github.com/repos/cilium/cilium/tags","blobs_url":"https://api.github.com/repos/cilium/cilium/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cilium/cilium/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cilium/cilium/git/refs{/sha}","trees_url":"https://api.github.com/repos/cilium/cilium/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cilium/cilium/statuses/{sha}","languages_url":"https://api.github.com/repos/cilium/cilium/languages","stargazers_url":"https://api.github.com/repos/cilium/cilium/stargazers","contributors_url":"https://api.github.com/repos/cilium/cilium/contributors","subscribers_url":"https://api.github.com/repos/cilium/cilium/subscribers","subscription_url":"https://api.github.com/repos/cilium/cilium/subscription","commits_url":"https://api.github.com/repos/cilium/cilium/commits{/sha}","git_commits_url":"https://api.github.com/repos/cilium/cilium/git/commits{/sha}","comments_url":"https://api.github.com/repos/cilium/cilium/comments{/number}","issue_comment_url":"https://api.github.com/repos/cilium/cilium/issues/comments{/number}","contents_url":"https://api.github.com/repos/cilium/cilium/contents/{+path}","compare_url":"https://api.github.com/repos/cilium/cilium/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cilium/cilium/merges","archive_url":"https://api.github.com/repos/cilium/cilium/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cilium/cilium/downloads","issues_url":"https://api.github.com/repos/cilium/cilium/issues{/number}","pulls_url":"https://api.github.com/repos/cilium/cilium/pulls{/number}","milestones_url":"https://api.github.com/repos/cilium/cilium/milestones{/number}","notifications_url":"https://api.github.com/repos/cilium/cilium/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cilium/cilium/labels{/name}","releases_url":"https://api.github.com/repos/cilium/cilium/releases{/id}","deployments_url":"https://api.github.com/repos/cilium/cilium/deployments","created_at":"2015-12-16T12:33:31Z","updated_at":"2018-07-16T22:17:57Z","pushed_at":"2018-07-16T22:28:25Z","git_url":"git://github.com/cilium/cilium.git","ssh_url":"[email protected]:cilium/cilium.git","clone_url":"https://github.com/cilium/cilium.git","svn_url":"https://github.com/cilium/cilium","homepage":"","size":54332,"stargazers_count":2540,"watchers_count":2540,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":228,"mirror_url":null,"archived":false,"open_issues_count":495,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":228,"open_issues":495,"watchers":2540,"default_branch":"master"}},"base":{"label":"cilium:master","ref":"master","sha":"04c810122df1a53232799edb488de4de6b5dc29b","user":{"login":"cilium","id":21054566,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMDU0NTY2","avatar_url":"https://avatars0.githubusercontent.com/u/21054566?v=4","gravatar_id":"","url":"https://api.github.com/users/cilium","html_url":"https://github.com/cilium","followers_url":"https://api.github.com/users/cilium/followers","following_url":"https://api.github.com/users/cilium/following{/other_user}","gists_url":"https://api.github.com/users/cilium/gists{/gist_id}","starred_url":"https://api.github.com/users/cilium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cilium/subscriptions","organizations_url":"https://api.github.com/users/cilium/orgs","repos_url":"https://api.github.com/users/cilium/repos","events_url":"https://api.github.com/users/cilium/events{/privacy}","received_events_url":"https://api.github.com/users/cilium/received_events","type":"Organization","site_admin":false},"repo":{"id":48109239,"node_id":"MDEwOlJlcG9zaXRvcnk0ODEwOTIzOQ==","name":"cilium","full_name":"cilium/cilium","owner":{"login":"cilium","id":21054566,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMDU0NTY2","avatar_url":"https://avatars0.githubusercontent.com/u/21054566?v=4","gravatar_id":"","url":"https://api.github.com/users/cilium","html_url":"https://github.com/cilium","followers_url":"https://api.github.com/users/cilium/followers","following_url":"https://api.github.com/users/cilium/following{/other_user}","gists_url":"https://api.github.com/users/cilium/gists{/gist_id}","starred_url":"https://api.github.com/users/cilium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cilium/subscriptions","organizations_url":"https://api.github.com/users/cilium/orgs","repos_url":"https://api.github.com/users/cilium/repos","events_url":"https://api.github.com/users/cilium/events{/privacy}","received_events_url":"https://api.github.com/users/cilium/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cilium/cilium","description":"HTTP, gRPC, and Kafka Aware Security and Networking for Containers with BPF and XDP","fork":false,"url":"https://api.github.com/repos/cilium/cilium","forks_url":"https://api.github.com/repos/cilium/cilium/forks","keys_url":"https://api.github.com/repos/cilium/cilium/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cilium/cilium/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cilium/cilium/teams","hooks_url":"https://api.github.com/repos/cilium/cilium/hooks","issue_events_url":"https://api.github.com/repos/cilium/cilium/issues/events{/number}","events_url":"https://api.github.com/repos/cilium/cilium/events","assignees_url":"https://api.github.com/repos/cilium/cilium/assignees{/user}","branches_url":"https://api.github.com/repos/cilium/cilium/branches{/branch}","tags_url":"https://api.github.com/repos/cilium/cilium/tags","blobs_url":"https://api.github.com/repos/cilium/cilium/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cilium/cilium/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cilium/cilium/git/refs{/sha}","trees_url":"https://api.github.com/repos/cilium/cilium/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cilium/cilium/statuses/{sha}","languages_url":"https://api.github.com/repos/cilium/cilium/languages","stargazers_url":"https://api.github.com/repos/cilium/cilium/stargazers","contributors_url":"https://api.github.com/repos/cilium/cilium/contributors","subscribers_url":"https://api.github.com/repos/cilium/cilium/subscribers","subscription_url":"https://api.github.com/repos/cilium/cilium/subscription","commits_url":"https://api.github.com/repos/cilium/cilium/commits{/sha}","git_commits_url":"https://api.github.com/repos/cilium/cilium/git/commits{/sha}","comments_url":"https://api.github.com/repos/cilium/cilium/comments{/number}","issue_comment_url":"https://api.github.com/repos/cilium/cilium/issues/comments{/number}","contents_url":"https://api.github.com/repos/cilium/cilium/contents/{+path}","compare_url":"https://api.github.com/repos/cilium/cilium/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cilium/cilium/merges","archive_url":"https://api.github.com/repos/cilium/cilium/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cilium/cilium/downloads","issues_url":"https://api.github.com/repos/cilium/cilium/issues{/number}","pulls_url":"https://api.github.com/repos/cilium/cilium/pulls{/number}","milestones_url":"https://api.github.com/repos/cilium/cilium/milestones{/number}","notifications_url":"https://api.github.com/repos/cilium/cilium/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cilium/cilium/labels{/name}","releases_url":"https://api.github.com/repos/cilium/cilium/releases{/id}","deployments_url":"https://api.github.com/repos/cilium/cilium/deployments","created_at":"2015-12-16T12:33:31Z","updated_at":"2018-07-16T22:17:57Z","pushed_at":"2018-07-16T22:28:25Z","git_url":"git://github.com/cilium/cilium.git","ssh_url":"[email protected]:cilium/cilium.git","clone_url":"https://github.com/cilium/cilium.git","svn_url":"https://github.com/cilium/cilium","homepage":"","size":54332,"stargazers_count":2540,"watchers_count":2540,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":228,"mirror_url":null,"archived":false,"open_issues_count":495,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":228,"open_issues":495,"watchers":2540,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cilium/cilium/pulls/4858"},"html":{"href":"https://github.com/cilium/cilium/pull/4858"},"issue":{"href":"https://api.github.com/repos/cilium/cilium/issues/4858"},"comments":{"href":"https://api.github.com/repos/cilium/cilium/issues/4858/comments"},"review_comments":{"href":"https://api.github.com/repos/cilium/cilium/pulls/4858/comments"},"review_comment":{"href":"https://api.github.com/repos/cilium/cilium/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cilium/cilium/pulls/4858/commits"},"statuses":{"href":"https://api.github.com/repos/cilium/cilium/statuses/1b156c6d4f206d074f67d84c6d5780304bca2b80"}},"author_association":"MEMBER"}} | {
"id": 48109239,
"name": "cilium/cilium",
"url": "https://api.github.com/repos/cilium/cilium"
} | {
"id": 1243336,
"login": "joestringer",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1243336?",
"url": "https://api.github.com/users/joestringer"
} | {
"id": 21054566,
"login": "cilium",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/21054566?",
"url": "https://api.github.com/orgs/cilium"
} | 2018-07-16T22:39:23 | 7973346061 | {"actor":{"display_login":"joestringer"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/nismod/smif/pulls/comments/194817705","pull_request_review_id":128061352,"id":194817705,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NDgxNzcwNQ==","diff_hunk":"@@ -435,30 +435,38 @@ def execute_model_run(args):\n ----------\n args\n \"\"\"\n- timestamp = datetime.datetime.fromtimestamp(time.time()).strftime('%Y%m%dT%H%M%S')\n-\n LOGGER.info(\"Loading resolution data\")\n load_resolution_sets(args.directory)\n \n- LOGGER.info(\"Getting model run definition\")\n- model_run_config = get_model_run_definition(args.directory, args.modelrun)\n+ if args.batchfile:\n+ with open(args.modelrun, 'r') as f:\n+ model_runs = f.read().splitlines()","path":"src/smif/cli/__init__.py","position":13,"original_position":13,"commit_id":"0049967388b462bb54d28bd54c786552a37d25d4","original_commit_id":"8cd943ae8e2a8d5e88bff27a971deabda1c1bc33","user":{"login":"RoaldL","id":9946900,"node_id":"MDQ6VXNlcjk5NDY5MDA=","avatar_url":"https://avatars0.githubusercontent.com/u/9946900?v=4","gravatar_id":"","url":"https://api.github.com/users/RoaldL","html_url":"https://github.com/RoaldL","followers_url":"https://api.github.com/users/RoaldL/followers","following_url":"https://api.github.com/users/RoaldL/following{/other_user}","gists_url":"https://api.github.com/users/RoaldL/gists{/gist_id}","starred_url":"https://api.github.com/users/RoaldL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RoaldL/subscriptions","organizations_url":"https://api.github.com/users/RoaldL/orgs","repos_url":"https://api.github.com/users/RoaldL/repos","events_url":"https://api.github.com/users/RoaldL/events{/privacy}","received_events_url":"https://api.github.com/users/RoaldL/received_events","type":"User","site_admin":false},"body":"Done","created_at":"2018-06-12T17:06:04Z","updated_at":"2018-06-12T17:06:04Z","html_url":"https://github.com/nismod/smif/pull/179#discussion_r194817705","pull_request_url":"https://api.github.com/repos/nismod/smif/pulls/179","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/nismod/smif/pulls/comments/194817705"},"html":{"href":"https://github.com/nismod/smif/pull/179#discussion_r194817705"},"pull_request":{"href":"https://api.github.com/repos/nismod/smif/pulls/179"}},"in_reply_to_id":194721394},"pull_request":{"url":"https://api.github.com/repos/nismod/smif/pulls/179","id":194263110,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0MjYzMTEw","html_url":"https://github.com/nismod/smif/pull/179","diff_url":"https://github.com/nismod/smif/pull/179.diff","patch_url":"https://github.com/nismod/smif/pull/179.patch","issue_url":"https://api.github.com/repos/nismod/smif/issues/179","number":179,"state":"open","locked":false,"title":"Feature/batch run","user":{"login":"RoaldL","id":9946900,"node_id":"MDQ6VXNlcjk5NDY5MDA=","avatar_url":"https://avatars0.githubusercontent.com/u/9946900?v=4","gravatar_id":"","url":"https://api.github.com/users/RoaldL","html_url":"https://github.com/RoaldL","followers_url":"https://api.github.com/users/RoaldL/followers","following_url":"https://api.github.com/users/RoaldL/following{/other_user}","gists_url":"https://api.github.com/users/RoaldL/gists{/gist_id}","starred_url":"https://api.github.com/users/RoaldL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RoaldL/subscriptions","organizations_url":"https://api.github.com/users/RoaldL/orgs","repos_url":"https://api.github.com/users/RoaldL/repos","events_url":"https://api.github.com/users/RoaldL/events{/privacy}","received_events_url":"https://api.github.com/users/RoaldL/received_events","type":"User","site_admin":false},"body":"This feature enables the user to sequentially run multiple modelruns from a modelrun batch file that contains a list of modelrun names.","created_at":"2018-06-12T12:28:18Z","updated_at":"2018-06-12T17:06:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b2497fa33bc1fab3b00b729c6a687c62c8389b2f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/nismod/smif/pulls/179/commits","review_comments_url":"https://api.github.com/repos/nismod/smif/pulls/179/comments","review_comment_url":"https://api.github.com/repos/nismod/smif/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nismod/smif/issues/179/comments","statuses_url":"https://api.github.com/repos/nismod/smif/statuses/0049967388b462bb54d28bd54c786552a37d25d4","head":{"label":"nismod:feature/batch_run","ref":"feature/batch_run","sha":"0049967388b462bb54d28bd54c786552a37d25d4","user":{"login":"nismod","id":21081508,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMDgxNTA4","avatar_url":"https://avatars3.githubusercontent.com/u/21081508?v=4","gravatar_id":"","url":"https://api.github.com/users/nismod","html_url":"https://github.com/nismod","followers_url":"https://api.github.com/users/nismod/followers","following_url":"https://api.github.com/users/nismod/following{/other_user}","gists_url":"https://api.github.com/users/nismod/gists{/gist_id}","starred_url":"https://api.github.com/users/nismod/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nismod/subscriptions","organizations_url":"https://api.github.com/users/nismod/orgs","repos_url":"https://api.github.com/users/nismod/repos","events_url":"https://api.github.com/users/nismod/events{/privacy}","received_events_url":"https://api.github.com/users/nismod/received_events","type":"Organization","site_admin":false},"repo":{"id":67128476,"node_id":"MDEwOlJlcG9zaXRvcnk2NzEyODQ3Ng==","name":"smif","full_name":"nismod/smif","owner":{"login":"nismod","id":21081508,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMDgxNTA4","avatar_url":"https://avatars3.githubusercontent.com/u/21081508?v=4","gravatar_id":"","url":"https://api.github.com/users/nismod","html_url":"https://github.com/nismod","followers_url":"https://api.github.com/users/nismod/followers","following_url":"https://api.github.com/users/nismod/following{/other_user}","gists_url":"https://api.github.com/users/nismod/gists{/gist_id}","starred_url":"https://api.github.com/users/nismod/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nismod/subscriptions","organizations_url":"https://api.github.com/users/nismod/orgs","repos_url":"https://api.github.com/users/nismod/repos","events_url":"https://api.github.com/users/nismod/events{/privacy}","received_events_url":"https://api.github.com/users/nismod/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nismod/smif","description":"Simulation Model Integration Framework","fork":false,"url":"https://api.github.com/repos/nismod/smif","forks_url":"https://api.github.com/repos/nismod/smif/forks","keys_url":"https://api.github.com/repos/nismod/smif/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nismod/smif/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nismod/smif/teams","hooks_url":"https://api.github.com/repos/nismod/smif/hooks","issue_events_url":"https://api.github.com/repos/nismod/smif/issues/events{/number}","events_url":"https://api.github.com/repos/nismod/smif/events","assignees_url":"https://api.github.com/repos/nismod/smif/assignees{/user}","branches_url":"https://api.github.com/repos/nismod/smif/branches{/branch}","tags_url":"https://api.github.com/repos/nismod/smif/tags","blobs_url":"https://api.github.com/repos/nismod/smif/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nismod/smif/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nismod/smif/git/refs{/sha}","trees_url":"https://api.github.com/repos/nismod/smif/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nismod/smif/statuses/{sha}","languages_url":"https://api.github.com/repos/nismod/smif/languages","stargazers_url":"https://api.github.com/repos/nismod/smif/stargazers","contributors_url":"https://api.github.com/repos/nismod/smif/contributors","subscribers_url":"https://api.github.com/repos/nismod/smif/subscribers","subscription_url":"https://api.github.com/repos/nismod/smif/subscription","commits_url":"https://api.github.com/repos/nismod/smif/commits{/sha}","git_commits_url":"https://api.github.com/repos/nismod/smif/git/commits{/sha}","comments_url":"https://api.github.com/repos/nismod/smif/comments{/number}","issue_comment_url":"https://api.github.com/repos/nismod/smif/issues/comments{/number}","contents_url":"https://api.github.com/repos/nismod/smif/contents/{+path}","compare_url":"https://api.github.com/repos/nismod/smif/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nismod/smif/merges","archive_url":"https://api.github.com/repos/nismod/smif/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nismod/smif/downloads","issues_url":"https://api.github.com/repos/nismod/smif/issues{/number}","pulls_url":"https://api.github.com/repos/nismod/smif/pulls{/number}","milestones_url":"https://api.github.com/repos/nismod/smif/milestones{/number}","notifications_url":"https://api.github.com/repos/nismod/smif/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nismod/smif/labels{/name}","releases_url":"https://api.github.com/repos/nismod/smif/releases{/id}","deployments_url":"https://api.github.com/repos/nismod/smif/deployments","created_at":"2016-09-01T12:17:41Z","updated_at":"2018-06-12T12:43:25Z","pushed_at":"2018-06-12T15:10:51Z","git_url":"git://github.com/nismod/smif.git","ssh_url":"[email protected]:nismod/smif.git","clone_url":"https://github.com/nismod/smif.git","svn_url":"https://github.com/nismod/smif","homepage":"http://www.itrc.org.uk","size":5749,"stargazers_count":5,"watchers_count":5,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":5,"open_issues":4,"watchers":5,"default_branch":"master"}},"base":{"label":"nismod:master","ref":"master","sha":"afd6df473f7aa7176b67cacc564f4e852a6af33f","user":{"login":"nismod","id":21081508,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMDgxNTA4","avatar_url":"https://avatars3.githubusercontent.com/u/21081508?v=4","gravatar_id":"","url":"https://api.github.com/users/nismod","html_url":"https://github.com/nismod","followers_url":"https://api.github.com/users/nismod/followers","following_url":"https://api.github.com/users/nismod/following{/other_user}","gists_url":"https://api.github.com/users/nismod/gists{/gist_id}","starred_url":"https://api.github.com/users/nismod/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nismod/subscriptions","organizations_url":"https://api.github.com/users/nismod/orgs","repos_url":"https://api.github.com/users/nismod/repos","events_url":"https://api.github.com/users/nismod/events{/privacy}","received_events_url":"https://api.github.com/users/nismod/received_events","type":"Organization","site_admin":false},"repo":{"id":67128476,"node_id":"MDEwOlJlcG9zaXRvcnk2NzEyODQ3Ng==","name":"smif","full_name":"nismod/smif","owner":{"login":"nismod","id":21081508,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMDgxNTA4","avatar_url":"https://avatars3.githubusercontent.com/u/21081508?v=4","gravatar_id":"","url":"https://api.github.com/users/nismod","html_url":"https://github.com/nismod","followers_url":"https://api.github.com/users/nismod/followers","following_url":"https://api.github.com/users/nismod/following{/other_user}","gists_url":"https://api.github.com/users/nismod/gists{/gist_id}","starred_url":"https://api.github.com/users/nismod/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nismod/subscriptions","organizations_url":"https://api.github.com/users/nismod/orgs","repos_url":"https://api.github.com/users/nismod/repos","events_url":"https://api.github.com/users/nismod/events{/privacy}","received_events_url":"https://api.github.com/users/nismod/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nismod/smif","description":"Simulation Model Integration Framework","fork":false,"url":"https://api.github.com/repos/nismod/smif","forks_url":"https://api.github.com/repos/nismod/smif/forks","keys_url":"https://api.github.com/repos/nismod/smif/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nismod/smif/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nismod/smif/teams","hooks_url":"https://api.github.com/repos/nismod/smif/hooks","issue_events_url":"https://api.github.com/repos/nismod/smif/issues/events{/number}","events_url":"https://api.github.com/repos/nismod/smif/events","assignees_url":"https://api.github.com/repos/nismod/smif/assignees{/user}","branches_url":"https://api.github.com/repos/nismod/smif/branches{/branch}","tags_url":"https://api.github.com/repos/nismod/smif/tags","blobs_url":"https://api.github.com/repos/nismod/smif/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nismod/smif/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nismod/smif/git/refs{/sha}","trees_url":"https://api.github.com/repos/nismod/smif/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nismod/smif/statuses/{sha}","languages_url":"https://api.github.com/repos/nismod/smif/languages","stargazers_url":"https://api.github.com/repos/nismod/smif/stargazers","contributors_url":"https://api.github.com/repos/nismod/smif/contributors","subscribers_url":"https://api.github.com/repos/nismod/smif/subscribers","subscription_url":"https://api.github.com/repos/nismod/smif/subscription","commits_url":"https://api.github.com/repos/nismod/smif/commits{/sha}","git_commits_url":"https://api.github.com/repos/nismod/smif/git/commits{/sha}","comments_url":"https://api.github.com/repos/nismod/smif/comments{/number}","issue_comment_url":"https://api.github.com/repos/nismod/smif/issues/comments{/number}","contents_url":"https://api.github.com/repos/nismod/smif/contents/{+path}","compare_url":"https://api.github.com/repos/nismod/smif/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nismod/smif/merges","archive_url":"https://api.github.com/repos/nismod/smif/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nismod/smif/downloads","issues_url":"https://api.github.com/repos/nismod/smif/issues{/number}","pulls_url":"https://api.github.com/repos/nismod/smif/pulls{/number}","milestones_url":"https://api.github.com/repos/nismod/smif/milestones{/number}","notifications_url":"https://api.github.com/repos/nismod/smif/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nismod/smif/labels{/name}","releases_url":"https://api.github.com/repos/nismod/smif/releases{/id}","deployments_url":"https://api.github.com/repos/nismod/smif/deployments","created_at":"2016-09-01T12:17:41Z","updated_at":"2018-06-12T12:43:25Z","pushed_at":"2018-06-12T15:10:51Z","git_url":"git://github.com/nismod/smif.git","ssh_url":"[email protected]:nismod/smif.git","clone_url":"https://github.com/nismod/smif.git","svn_url":"https://github.com/nismod/smif","homepage":"http://www.itrc.org.uk","size":5749,"stargazers_count":5,"watchers_count":5,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":5,"open_issues":4,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nismod/smif/pulls/179"},"html":{"href":"https://github.com/nismod/smif/pull/179"},"issue":{"href":"https://api.github.com/repos/nismod/smif/issues/179"},"comments":{"href":"https://api.github.com/repos/nismod/smif/issues/179/comments"},"review_comments":{"href":"https://api.github.com/repos/nismod/smif/pulls/179/comments"},"review_comment":{"href":"https://api.github.com/repos/nismod/smif/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nismod/smif/pulls/179/commits"},"statuses":{"href":"https://api.github.com/repos/nismod/smif/statuses/0049967388b462bb54d28bd54c786552a37d25d4"}},"author_association":"CONTRIBUTOR"}} | {
"id": 67128476,
"name": "nismod/smif",
"url": "https://api.github.com/repos/nismod/smif"
} | {
"id": 9946900,
"login": "RoaldL",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9946900?",
"url": "https://api.github.com/users/RoaldL"
} | {
"id": 21081508,
"login": "nismod",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/21081508?",
"url": "https://api.github.com/orgs/nismod"
} | 2018-06-12T17:06:04 | 7813837098 | {"actor":{"display_login":"RoaldL"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/pandas-dev/pandas/pulls/comments/169502031","pull_request_review_id":98038482,"id":169502031,"diff_hunk":"@@ -732,8 +737,15 @@ def __rsub__(self, other):\n return -(self - other)\n cls.__rsub__ = __rsub__\n \n- cls.__iadd__ = __add__\n- cls.__isub__ = __sub__\n+ def __iadd__(self, other):\n+ # alias for __add__\n+ return self.__add__(other)\n+ cls.__iadd__ = __iadd__","path":"pandas/core/indexes/datetimelike.py","position":45,"original_position":45,"commit_id":"88c9638fca91f8ce0b54c43af4cf0e56506ba08b","original_commit_id":"88c9638fca91f8ce0b54c43af4cf0e56506ba08b","user":{"login":"jbrockmendel","id":8078968,"avatar_url":"https://avatars1.githubusercontent.com/u/8078968?v=4","gravatar_id":"","url":"https://api.github.com/users/jbrockmendel","html_url":"https://github.com/jbrockmendel","followers_url":"https://api.github.com/users/jbrockmendel/followers","following_url":"https://api.github.com/users/jbrockmendel/following{/other_user}","gists_url":"https://api.github.com/users/jbrockmendel/gists{/gist_id}","starred_url":"https://api.github.com/users/jbrockmendel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbrockmendel/subscriptions","organizations_url":"https://api.github.com/users/jbrockmendel/orgs","repos_url":"https://api.github.com/users/jbrockmendel/repos","events_url":"https://api.github.com/users/jbrockmendel/events{/privacy}","received_events_url":"https://api.github.com/users/jbrockmendel/received_events","type":"User","site_admin":false},"body":"If we just set `cls.__iadd__ = __add__` then when we check for `Index.__iadd__.__name__` we'll get `__add__` instead of `__iadd__`. Not a big deal, but its cheap to make it pretty.","created_at":"2018-02-21T00:15:47Z","updated_at":"2018-02-21T00:15:47Z","html_url":"https://github.com/pandas-dev/pandas/pull/19723#discussion_r169502031","pull_request_url":"https://api.github.com/repos/pandas-dev/pandas/pulls/19723","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/comments/169502031"},"html":{"href":"https://github.com/pandas-dev/pandas/pull/19723#discussion_r169502031"},"pull_request":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/19723"}},"in_reply_to_id":169499253},"pull_request":{"url":"https://api.github.com/repos/pandas-dev/pandas/pulls/19723","id":169534505,"html_url":"https://github.com/pandas-dev/pandas/pull/19723","diff_url":"https://github.com/pandas-dev/pandas/pull/19723.diff","patch_url":"https://github.com/pandas-dev/pandas/pull/19723.patch","issue_url":"https://api.github.com/repos/pandas-dev/pandas/issues/19723","number":19723,"state":"open","locked":false,"title":"Fix index op names and pinning","user":{"login":"jbrockmendel","id":8078968,"avatar_url":"https://avatars1.githubusercontent.com/u/8078968?v=4","gravatar_id":"","url":"https://api.github.com/users/jbrockmendel","html_url":"https://github.com/jbrockmendel","followers_url":"https://api.github.com/users/jbrockmendel/followers","following_url":"https://api.github.com/users/jbrockmendel/following{/other_user}","gists_url":"https://api.github.com/users/jbrockmendel/gists{/gist_id}","starred_url":"https://api.github.com/users/jbrockmendel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbrockmendel/subscriptions","organizations_url":"https://api.github.com/users/jbrockmendel/orgs","repos_url":"https://api.github.com/users/jbrockmendel/repos","events_url":"https://api.github.com/users/jbrockmendel/events{/privacy}","received_events_url":"https://api.github.com/users/jbrockmendel/received_events","type":"User","site_admin":false},"body":"This is a moderately big one, but changes very little.\r\n\r\nFixes incorrect Index ops names and several methods that are defined but not pinned to the class (#19716).\r\n\r\nAvoids the need to pass `reversed` and `str_rep` in a bunch of places, cleans up some of the Index classmethods.\r\n\r\nRemoves the no-longer-needed catching of AttributeError in RangeIndex ops.\r\n\r\nThe part that may be controversial (and almost certainly needs new tests) is that `Index.__rsub__` is implemented, since it doesn't currently exist. This implements it in \"the obvious way\", but the fact that `Index.__sub__` isn't defined in the obvious way suggests this _might_ not be desired. Comments welcome.\r\n\r\n- [x] closes #19716\r\n- [x] tests added / passed\r\n- [x] passes `git diff upstream/master -u -- \"*.py\" | flake8 --diff`\r\n- [ ] whatsnew entry\r\n","created_at":"2018-02-16T02:09:12Z","updated_at":"2018-02-21T00:15:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a5b404c42abbcbda3d36b7d2391e5ff4898f46f5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":35818298,"url":"https://api.github.com/repos/pandas-dev/pandas/labels/API%20Design","name":"API Design","color":"AD7FA8","default":false},{"id":47223669,"url":"https://api.github.com/repos/pandas-dev/pandas/labels/Numeric","name":"Numeric","color":"006b75","default":false},{"id":49597148,"url":"https://api.github.com/repos/pandas-dev/pandas/labels/Timedelta","name":"Timedelta","color":"5319e7","default":false},{"id":211840,"url":"https://api.github.com/repos/pandas-dev/pandas/labels/Timeseries","name":"Timeseries","color":"AFEEEE","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/pandas-dev/pandas/pulls/19723/commits","review_comments_url":"https://api.github.com/repos/pandas-dev/pandas/pulls/19723/comments","review_comment_url":"https://api.github.com/repos/pandas-dev/pandas/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pandas-dev/pandas/issues/19723/comments","statuses_url":"https://api.github.com/repos/pandas-dev/pandas/statuses/88c9638fca91f8ce0b54c43af4cf0e56506ba08b","head":{"label":"jbrockmendel:opprep","ref":"opprep","sha":"88c9638fca91f8ce0b54c43af4cf0e56506ba08b","user":{"login":"jbrockmendel","id":8078968,"avatar_url":"https://avatars1.githubusercontent.com/u/8078968?v=4","gravatar_id":"","url":"https://api.github.com/users/jbrockmendel","html_url":"https://github.com/jbrockmendel","followers_url":"https://api.github.com/users/jbrockmendel/followers","following_url":"https://api.github.com/users/jbrockmendel/following{/other_user}","gists_url":"https://api.github.com/users/jbrockmendel/gists{/gist_id}","starred_url":"https://api.github.com/users/jbrockmendel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbrockmendel/subscriptions","organizations_url":"https://api.github.com/users/jbrockmendel/orgs","repos_url":"https://api.github.com/users/jbrockmendel/repos","events_url":"https://api.github.com/users/jbrockmendel/events{/privacy}","received_events_url":"https://api.github.com/users/jbrockmendel/received_events","type":"User","site_admin":false},"repo":{"id":96820953,"name":"pandas","full_name":"jbrockmendel/pandas","owner":{"login":"jbrockmendel","id":8078968,"avatar_url":"https://avatars1.githubusercontent.com/u/8078968?v=4","gravatar_id":"","url":"https://api.github.com/users/jbrockmendel","html_url":"https://github.com/jbrockmendel","followers_url":"https://api.github.com/users/jbrockmendel/followers","following_url":"https://api.github.com/users/jbrockmendel/following{/other_user}","gists_url":"https://api.github.com/users/jbrockmendel/gists{/gist_id}","starred_url":"https://api.github.com/users/jbrockmendel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbrockmendel/subscriptions","organizations_url":"https://api.github.com/users/jbrockmendel/orgs","repos_url":"https://api.github.com/users/jbrockmendel/repos","events_url":"https://api.github.com/users/jbrockmendel/events{/privacy}","received_events_url":"https://api.github.com/users/jbrockmendel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jbrockmendel/pandas","description":"Flexible and powerful data analysis / manipulation library for Python, providing labeled data structures similar to R data.frame objects, statistical functions, and much more","fork":true,"url":"https://api.github.com/repos/jbrockmendel/pandas","forks_url":"https://api.github.com/repos/jbrockmendel/pandas/forks","keys_url":"https://api.github.com/repos/jbrockmendel/pandas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jbrockmendel/pandas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jbrockmendel/pandas/teams","hooks_url":"https://api.github.com/repos/jbrockmendel/pandas/hooks","issue_events_url":"https://api.github.com/repos/jbrockmendel/pandas/issues/events{/number}","events_url":"https://api.github.com/repos/jbrockmendel/pandas/events","assignees_url":"https://api.github.com/repos/jbrockmendel/pandas/assignees{/user}","branches_url":"https://api.github.com/repos/jbrockmendel/pandas/branches{/branch}","tags_url":"https://api.github.com/repos/jbrockmendel/pandas/tags","blobs_url":"https://api.github.com/repos/jbrockmendel/pandas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jbrockmendel/pandas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jbrockmendel/pandas/git/refs{/sha}","trees_url":"https://api.github.com/repos/jbrockmendel/pandas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jbrockmendel/pandas/statuses/{sha}","languages_url":"https://api.github.com/repos/jbrockmendel/pandas/languages","stargazers_url":"https://api.github.com/repos/jbrockmendel/pandas/stargazers","contributors_url":"https://api.github.com/repos/jbrockmendel/pandas/contributors","subscribers_url":"https://api.github.com/repos/jbrockmendel/pandas/subscribers","subscription_url":"https://api.github.com/repos/jbrockmendel/pandas/subscription","commits_url":"https://api.github.com/repos/jbrockmendel/pandas/commits{/sha}","git_commits_url":"https://api.github.com/repos/jbrockmendel/pandas/git/commits{/sha}","comments_url":"https://api.github.com/repos/jbrockmendel/pandas/comments{/number}","issue_comment_url":"https://api.github.com/repos/jbrockmendel/pandas/issues/comments{/number}","contents_url":"https://api.github.com/repos/jbrockmendel/pandas/contents/{+path}","compare_url":"https://api.github.com/repos/jbrockmendel/pandas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jbrockmendel/pandas/merges","archive_url":"https://api.github.com/repos/jbrockmendel/pandas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jbrockmendel/pandas/downloads","issues_url":"https://api.github.com/repos/jbrockmendel/pandas/issues{/number}","pulls_url":"https://api.github.com/repos/jbrockmendel/pandas/pulls{/number}","milestones_url":"https://api.github.com/repos/jbrockmendel/pandas/milestones{/number}","notifications_url":"https://api.github.com/repos/jbrockmendel/pandas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jbrockmendel/pandas/labels{/name}","releases_url":"https://api.github.com/repos/jbrockmendel/pandas/releases{/id}","deployments_url":"https://api.github.com/repos/jbrockmendel/pandas/deployments","created_at":"2017-07-10T21:01:07Z","updated_at":"2017-07-10T21:01:15Z","pushed_at":"2018-02-20T23:41:38Z","git_url":"git://github.com/jbrockmendel/pandas.git","ssh_url":"[email protected]:jbrockmendel/pandas.git","clone_url":"https://github.com/jbrockmendel/pandas.git","svn_url":"https://github.com/jbrockmendel/pandas","homepage":"http://pandas.pydata.org","size":116769,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"pandas-dev:master","ref":"master","sha":"5bb5e33ffe01eb7c82e8eed327f8745cfacdaada","user":{"login":"pandas-dev","id":21206976,"avatar_url":"https://avatars2.githubusercontent.com/u/21206976?v=4","gravatar_id":"","url":"https://api.github.com/users/pandas-dev","html_url":"https://github.com/pandas-dev","followers_url":"https://api.github.com/users/pandas-dev/followers","following_url":"https://api.github.com/users/pandas-dev/following{/other_user}","gists_url":"https://api.github.com/users/pandas-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/pandas-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pandas-dev/subscriptions","organizations_url":"https://api.github.com/users/pandas-dev/orgs","repos_url":"https://api.github.com/users/pandas-dev/repos","events_url":"https://api.github.com/users/pandas-dev/events{/privacy}","received_events_url":"https://api.github.com/users/pandas-dev/received_events","type":"Organization","site_admin":false},"repo":{"id":858127,"name":"pandas","full_name":"pandas-dev/pandas","owner":{"login":"pandas-dev","id":21206976,"avatar_url":"https://avatars2.githubusercontent.com/u/21206976?v=4","gravatar_id":"","url":"https://api.github.com/users/pandas-dev","html_url":"https://github.com/pandas-dev","followers_url":"https://api.github.com/users/pandas-dev/followers","following_url":"https://api.github.com/users/pandas-dev/following{/other_user}","gists_url":"https://api.github.com/users/pandas-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/pandas-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pandas-dev/subscriptions","organizations_url":"https://api.github.com/users/pandas-dev/orgs","repos_url":"https://api.github.com/users/pandas-dev/repos","events_url":"https://api.github.com/users/pandas-dev/events{/privacy}","received_events_url":"https://api.github.com/users/pandas-dev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pandas-dev/pandas","description":"Flexible and powerful data analysis / manipulation library for Python, providing labeled data structures similar to R data.frame objects, statistical functions, and much more","fork":false,"url":"https://api.github.com/repos/pandas-dev/pandas","forks_url":"https://api.github.com/repos/pandas-dev/pandas/forks","keys_url":"https://api.github.com/repos/pandas-dev/pandas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pandas-dev/pandas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pandas-dev/pandas/teams","hooks_url":"https://api.github.com/repos/pandas-dev/pandas/hooks","issue_events_url":"https://api.github.com/repos/pandas-dev/pandas/issues/events{/number}","events_url":"https://api.github.com/repos/pandas-dev/pandas/events","assignees_url":"https://api.github.com/repos/pandas-dev/pandas/assignees{/user}","branches_url":"https://api.github.com/repos/pandas-dev/pandas/branches{/branch}","tags_url":"https://api.github.com/repos/pandas-dev/pandas/tags","blobs_url":"https://api.github.com/repos/pandas-dev/pandas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pandas-dev/pandas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pandas-dev/pandas/git/refs{/sha}","trees_url":"https://api.github.com/repos/pandas-dev/pandas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pandas-dev/pandas/statuses/{sha}","languages_url":"https://api.github.com/repos/pandas-dev/pandas/languages","stargazers_url":"https://api.github.com/repos/pandas-dev/pandas/stargazers","contributors_url":"https://api.github.com/repos/pandas-dev/pandas/contributors","subscribers_url":"https://api.github.com/repos/pandas-dev/pandas/subscribers","subscription_url":"https://api.github.com/repos/pandas-dev/pandas/subscription","commits_url":"https://api.github.com/repos/pandas-dev/pandas/commits{/sha}","git_commits_url":"https://api.github.com/repos/pandas-dev/pandas/git/commits{/sha}","comments_url":"https://api.github.com/repos/pandas-dev/pandas/comments{/number}","issue_comment_url":"https://api.github.com/repos/pandas-dev/pandas/issues/comments{/number}","contents_url":"https://api.github.com/repos/pandas-dev/pandas/contents/{+path}","compare_url":"https://api.github.com/repos/pandas-dev/pandas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pandas-dev/pandas/merges","archive_url":"https://api.github.com/repos/pandas-dev/pandas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pandas-dev/pandas/downloads","issues_url":"https://api.github.com/repos/pandas-dev/pandas/issues{/number}","pulls_url":"https://api.github.com/repos/pandas-dev/pandas/pulls{/number}","milestones_url":"https://api.github.com/repos/pandas-dev/pandas/milestones{/number}","notifications_url":"https://api.github.com/repos/pandas-dev/pandas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pandas-dev/pandas/labels{/name}","releases_url":"https://api.github.com/repos/pandas-dev/pandas/releases{/id}","deployments_url":"https://api.github.com/repos/pandas-dev/pandas/deployments","created_at":"2010-08-24T01:37:33Z","updated_at":"2018-02-21T00:06:26Z","pushed_at":"2018-02-20T23:54:15Z","git_url":"git://github.com/pandas-dev/pandas.git","ssh_url":"[email protected]:pandas-dev/pandas.git","clone_url":"https://github.com/pandas-dev/pandas.git","svn_url":"https://github.com/pandas-dev/pandas","homepage":"http://pandas.pydata.org","size":116749,"stargazers_count":12959,"watchers_count":12959,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5024,"mirror_url":null,"archived":false,"open_issues_count":2369,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":5024,"open_issues":2369,"watchers":12959,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/19723"},"html":{"href":"https://github.com/pandas-dev/pandas/pull/19723"},"issue":{"href":"https://api.github.com/repos/pandas-dev/pandas/issues/19723"},"comments":{"href":"https://api.github.com/repos/pandas-dev/pandas/issues/19723/comments"},"review_comments":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/19723/comments"},"review_comment":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/19723/commits"},"statuses":{"href":"https://api.github.com/repos/pandas-dev/pandas/statuses/88c9638fca91f8ce0b54c43af4cf0e56506ba08b"}},"author_association":"CONTRIBUTOR"}} | {
"id": 858127,
"name": "pandas-dev/pandas",
"url": "https://api.github.com/repos/pandas-dev/pandas"
} | {
"id": 8078968,
"login": "jbrockmendel",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/8078968?",
"url": "https://api.github.com/users/jbrockmendel"
} | {
"id": 21206976,
"login": "pandas-dev",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/21206976?",
"url": "https://api.github.com/orgs/pandas-dev"
} | 2018-02-21T00:15:47 | 7272663648 | {"actor":{"display_login":"jbrockmendel"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/pandas-dev/pandas/pulls/comments/240100345","pull_request_review_id":183050586,"id":240100345,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MDEwMDM0NQ==","diff_hunk":"@@ -43,8 +43,8 @@ def test_groupby_with_timegrouper(self):\n \n expected = DataFrame(\n {'Quantity': 0},\n- index=date_range('20130901 13:00:00',\n- '20131205 13:00:00', freq='5D',\n+ index=date_range('20130901',","path":"pandas/tests/groupby/test_timegrouper.py","position":6,"original_position":6,"commit_id":"1d4ac73aa1e3fb41acde6f7d726a07833652f9f0","original_commit_id":"1d4ac73aa1e3fb41acde6f7d726a07833652f9f0","user":{"login":"mroeschke","id":10647082,"node_id":"MDQ6VXNlcjEwNjQ3MDgy","avatar_url":"https://avatars0.githubusercontent.com/u/10647082?v=4","gravatar_id":"","url":"https://api.github.com/users/mroeschke","html_url":"https://github.com/mroeschke","followers_url":"https://api.github.com/users/mroeschke/followers","following_url":"https://api.github.com/users/mroeschke/following{/other_user}","gists_url":"https://api.github.com/users/mroeschke/gists{/gist_id}","starred_url":"https://api.github.com/users/mroeschke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mroeschke/subscriptions","organizations_url":"https://api.github.com/users/mroeschke/orgs","repos_url":"https://api.github.com/users/mroeschke/repos","events_url":"https://api.github.com/users/mroeschke/events{/privacy}","received_events_url":"https://api.github.com/users/mroeschke/received_events","type":"User","site_admin":false},"body":"Why did this test have to change?","created_at":"2018-12-10T07:06:36Z","updated_at":"2018-12-10T07:10:24Z","html_url":"https://github.com/pandas-dev/pandas/pull/24159#discussion_r240100345","pull_request_url":"https://api.github.com/repos/pandas-dev/pandas/pulls/24159","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/comments/240100345"},"html":{"href":"https://github.com/pandas-dev/pandas/pull/24159#discussion_r240100345"},"pull_request":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/24159"}}},"pull_request":{"url":"https://api.github.com/repos/pandas-dev/pandas/pulls/24159","id":237046634,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM3MDQ2NjM0","html_url":"https://github.com/pandas-dev/pandas/pull/24159","diff_url":"https://github.com/pandas-dev/pandas/pull/24159.diff","patch_url":"https://github.com/pandas-dev/pandas/pull/24159.patch","issue_url":"https://api.github.com/repos/pandas-dev/pandas/issues/24159","number":24159,"state":"open","locked":false,"title":"BUG - anchoring dates for resample with Day(n>1)","user":{"login":"ArtinSarraf","id":13501084,"node_id":"MDQ6VXNlcjEzNTAxMDg0","avatar_url":"https://avatars1.githubusercontent.com/u/13501084?v=4","gravatar_id":"","url":"https://api.github.com/users/ArtinSarraf","html_url":"https://github.com/ArtinSarraf","followers_url":"https://api.github.com/users/ArtinSarraf/followers","following_url":"https://api.github.com/users/ArtinSarraf/following{/other_user}","gists_url":"https://api.github.com/users/ArtinSarraf/gists{/gist_id}","starred_url":"https://api.github.com/users/ArtinSarraf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ArtinSarraf/subscriptions","organizations_url":"https://api.github.com/users/ArtinSarraf/orgs","repos_url":"https://api.github.com/users/ArtinSarraf/repos","events_url":"https://api.github.com/users/ArtinSarraf/events{/privacy}","received_events_url":"https://api.github.com/users/ArtinSarraf/received_events","type":"User","site_admin":false},"body":"- [ ] closes #24127\r\n- [ ] tests added / passed\r\n- [ ] passes `git diff upstream/master -u -- \"*.py\" | flake8 --diff`\r\n- [ ] whatsnew entry\r\n","created_at":"2018-12-08T05:24:02Z","updated_at":"2018-12-10T07:10:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"21a0367831f8592cf26384f518d92b6866f3564b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":76811,"node_id":"MDU6TGFiZWw3NjgxMQ==","url":"https://api.github.com/repos/pandas-dev/pandas/labels/Bug","name":"Bug","color":"e10c02","default":false},{"id":53181044,"node_id":"MDU6TGFiZWw1MzE4MTA0NA==","url":"https://api.github.com/repos/pandas-dev/pandas/labels/Frequency","name":"Frequency","color":"0052cc","default":false},{"id":74975453,"node_id":"MDU6TGFiZWw3NDk3NTQ1Mw==","url":"https://api.github.com/repos/pandas-dev/pandas/labels/Resample","name":"Resample","color":"207de5","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/pandas-dev/pandas/pulls/24159/commits","review_comments_url":"https://api.github.com/repos/pandas-dev/pandas/pulls/24159/comments","review_comment_url":"https://api.github.com/repos/pandas-dev/pandas/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pandas-dev/pandas/issues/24159/comments","statuses_url":"https://api.github.com/repos/pandas-dev/pandas/statuses/1d4ac73aa1e3fb41acde6f7d726a07833652f9f0","head":{"label":"ArtinSarraf:bug/get_range_edges","ref":"bug/get_range_edges","sha":"1d4ac73aa1e3fb41acde6f7d726a07833652f9f0","user":{"login":"ArtinSarraf","id":13501084,"node_id":"MDQ6VXNlcjEzNTAxMDg0","avatar_url":"https://avatars1.githubusercontent.com/u/13501084?v=4","gravatar_id":"","url":"https://api.github.com/users/ArtinSarraf","html_url":"https://github.com/ArtinSarraf","followers_url":"https://api.github.com/users/ArtinSarraf/followers","following_url":"https://api.github.com/users/ArtinSarraf/following{/other_user}","gists_url":"https://api.github.com/users/ArtinSarraf/gists{/gist_id}","starred_url":"https://api.github.com/users/ArtinSarraf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ArtinSarraf/subscriptions","organizations_url":"https://api.github.com/users/ArtinSarraf/orgs","repos_url":"https://api.github.com/users/ArtinSarraf/repos","events_url":"https://api.github.com/users/ArtinSarraf/events{/privacy}","received_events_url":"https://api.github.com/users/ArtinSarraf/received_events","type":"User","site_admin":false},"repo":{"id":152918136,"node_id":"MDEwOlJlcG9zaXRvcnkxNTI5MTgxMzY=","name":"pandas","full_name":"ArtinSarraf/pandas","private":false,"owner":{"login":"ArtinSarraf","id":13501084,"node_id":"MDQ6VXNlcjEzNTAxMDg0","avatar_url":"https://avatars1.githubusercontent.com/u/13501084?v=4","gravatar_id":"","url":"https://api.github.com/users/ArtinSarraf","html_url":"https://github.com/ArtinSarraf","followers_url":"https://api.github.com/users/ArtinSarraf/followers","following_url":"https://api.github.com/users/ArtinSarraf/following{/other_user}","gists_url":"https://api.github.com/users/ArtinSarraf/gists{/gist_id}","starred_url":"https://api.github.com/users/ArtinSarraf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ArtinSarraf/subscriptions","organizations_url":"https://api.github.com/users/ArtinSarraf/orgs","repos_url":"https://api.github.com/users/ArtinSarraf/repos","events_url":"https://api.github.com/users/ArtinSarraf/events{/privacy}","received_events_url":"https://api.github.com/users/ArtinSarraf/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ArtinSarraf/pandas","description":"Flexible and powerful data analysis / manipulation library for Python, providing labeled data structures similar to R data.frame objects, statistical functions, and much more","fork":true,"url":"https://api.github.com/repos/ArtinSarraf/pandas","forks_url":"https://api.github.com/repos/ArtinSarraf/pandas/forks","keys_url":"https://api.github.com/repos/ArtinSarraf/pandas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ArtinSarraf/pandas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ArtinSarraf/pandas/teams","hooks_url":"https://api.github.com/repos/ArtinSarraf/pandas/hooks","issue_events_url":"https://api.github.com/repos/ArtinSarraf/pandas/issues/events{/number}","events_url":"https://api.github.com/repos/ArtinSarraf/pandas/events","assignees_url":"https://api.github.com/repos/ArtinSarraf/pandas/assignees{/user}","branches_url":"https://api.github.com/repos/ArtinSarraf/pandas/branches{/branch}","tags_url":"https://api.github.com/repos/ArtinSarraf/pandas/tags","blobs_url":"https://api.github.com/repos/ArtinSarraf/pandas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ArtinSarraf/pandas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ArtinSarraf/pandas/git/refs{/sha}","trees_url":"https://api.github.com/repos/ArtinSarraf/pandas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ArtinSarraf/pandas/statuses/{sha}","languages_url":"https://api.github.com/repos/ArtinSarraf/pandas/languages","stargazers_url":"https://api.github.com/repos/ArtinSarraf/pandas/stargazers","contributors_url":"https://api.github.com/repos/ArtinSarraf/pandas/contributors","subscribers_url":"https://api.github.com/repos/ArtinSarraf/pandas/subscribers","subscription_url":"https://api.github.com/repos/ArtinSarraf/pandas/subscription","commits_url":"https://api.github.com/repos/ArtinSarraf/pandas/commits{/sha}","git_commits_url":"https://api.github.com/repos/ArtinSarraf/pandas/git/commits{/sha}","comments_url":"https://api.github.com/repos/ArtinSarraf/pandas/comments{/number}","issue_comment_url":"https://api.github.com/repos/ArtinSarraf/pandas/issues/comments{/number}","contents_url":"https://api.github.com/repos/ArtinSarraf/pandas/contents/{+path}","compare_url":"https://api.github.com/repos/ArtinSarraf/pandas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ArtinSarraf/pandas/merges","archive_url":"https://api.github.com/repos/ArtinSarraf/pandas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ArtinSarraf/pandas/downloads","issues_url":"https://api.github.com/repos/ArtinSarraf/pandas/issues{/number}","pulls_url":"https://api.github.com/repos/ArtinSarraf/pandas/pulls{/number}","milestones_url":"https://api.github.com/repos/ArtinSarraf/pandas/milestones{/number}","notifications_url":"https://api.github.com/repos/ArtinSarraf/pandas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ArtinSarraf/pandas/labels{/name}","releases_url":"https://api.github.com/repos/ArtinSarraf/pandas/releases{/id}","deployments_url":"https://api.github.com/repos/ArtinSarraf/pandas/deployments","created_at":"2018-10-13T22:02:09Z","updated_at":"2018-11-27T03:34:47Z","pushed_at":"2018-12-10T05:04:52Z","git_url":"git://github.com/ArtinSarraf/pandas.git","ssh_url":"[email protected]:ArtinSarraf/pandas.git","clone_url":"https://github.com/ArtinSarraf/pandas.git","svn_url":"https://github.com/ArtinSarraf/pandas","homepage":"https://pandas.pydata.org","size":140050,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pandas-dev:master","ref":"master","sha":"c0b9eea7067d6089fabdc31ac2ed4cc16d063568","user":{"login":"pandas-dev","id":21206976,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMjA2OTc2","avatar_url":"https://avatars2.githubusercontent.com/u/21206976?v=4","gravatar_id":"","url":"https://api.github.com/users/pandas-dev","html_url":"https://github.com/pandas-dev","followers_url":"https://api.github.com/users/pandas-dev/followers","following_url":"https://api.github.com/users/pandas-dev/following{/other_user}","gists_url":"https://api.github.com/users/pandas-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/pandas-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pandas-dev/subscriptions","organizations_url":"https://api.github.com/users/pandas-dev/orgs","repos_url":"https://api.github.com/users/pandas-dev/repos","events_url":"https://api.github.com/users/pandas-dev/events{/privacy}","received_events_url":"https://api.github.com/users/pandas-dev/received_events","type":"Organization","site_admin":false},"repo":{"id":858127,"node_id":"MDEwOlJlcG9zaXRvcnk4NTgxMjc=","name":"pandas","full_name":"pandas-dev/pandas","private":false,"owner":{"login":"pandas-dev","id":21206976,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMjA2OTc2","avatar_url":"https://avatars2.githubusercontent.com/u/21206976?v=4","gravatar_id":"","url":"https://api.github.com/users/pandas-dev","html_url":"https://github.com/pandas-dev","followers_url":"https://api.github.com/users/pandas-dev/followers","following_url":"https://api.github.com/users/pandas-dev/following{/other_user}","gists_url":"https://api.github.com/users/pandas-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/pandas-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pandas-dev/subscriptions","organizations_url":"https://api.github.com/users/pandas-dev/orgs","repos_url":"https://api.github.com/users/pandas-dev/repos","events_url":"https://api.github.com/users/pandas-dev/events{/privacy}","received_events_url":"https://api.github.com/users/pandas-dev/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/pandas-dev/pandas","description":"Flexible and powerful data analysis / manipulation library for Python, providing labeled data structures similar to R data.frame objects, statistical functions, and much more","fork":false,"url":"https://api.github.com/repos/pandas-dev/pandas","forks_url":"https://api.github.com/repos/pandas-dev/pandas/forks","keys_url":"https://api.github.com/repos/pandas-dev/pandas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pandas-dev/pandas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pandas-dev/pandas/teams","hooks_url":"https://api.github.com/repos/pandas-dev/pandas/hooks","issue_events_url":"https://api.github.com/repos/pandas-dev/pandas/issues/events{/number}","events_url":"https://api.github.com/repos/pandas-dev/pandas/events","assignees_url":"https://api.github.com/repos/pandas-dev/pandas/assignees{/user}","branches_url":"https://api.github.com/repos/pandas-dev/pandas/branches{/branch}","tags_url":"https://api.github.com/repos/pandas-dev/pandas/tags","blobs_url":"https://api.github.com/repos/pandas-dev/pandas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pandas-dev/pandas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pandas-dev/pandas/git/refs{/sha}","trees_url":"https://api.github.com/repos/pandas-dev/pandas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pandas-dev/pandas/statuses/{sha}","languages_url":"https://api.github.com/repos/pandas-dev/pandas/languages","stargazers_url":"https://api.github.com/repos/pandas-dev/pandas/stargazers","contributors_url":"https://api.github.com/repos/pandas-dev/pandas/contributors","subscribers_url":"https://api.github.com/repos/pandas-dev/pandas/subscribers","subscription_url":"https://api.github.com/repos/pandas-dev/pandas/subscription","commits_url":"https://api.github.com/repos/pandas-dev/pandas/commits{/sha}","git_commits_url":"https://api.github.com/repos/pandas-dev/pandas/git/commits{/sha}","comments_url":"https://api.github.com/repos/pandas-dev/pandas/comments{/number}","issue_comment_url":"https://api.github.com/repos/pandas-dev/pandas/issues/comments{/number}","contents_url":"https://api.github.com/repos/pandas-dev/pandas/contents/{+path}","compare_url":"https://api.github.com/repos/pandas-dev/pandas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pandas-dev/pandas/merges","archive_url":"https://api.github.com/repos/pandas-dev/pandas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pandas-dev/pandas/downloads","issues_url":"https://api.github.com/repos/pandas-dev/pandas/issues{/number}","pulls_url":"https://api.github.com/repos/pandas-dev/pandas/pulls{/number}","milestones_url":"https://api.github.com/repos/pandas-dev/pandas/milestones{/number}","notifications_url":"https://api.github.com/repos/pandas-dev/pandas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pandas-dev/pandas/labels{/name}","releases_url":"https://api.github.com/repos/pandas-dev/pandas/releases{/id}","deployments_url":"https://api.github.com/repos/pandas-dev/pandas/deployments","created_at":"2010-08-24T01:37:33Z","updated_at":"2018-12-10T04:09:46Z","pushed_at":"2018-12-10T06:35:33Z","git_url":"git://github.com/pandas-dev/pandas.git","ssh_url":"[email protected]:pandas-dev/pandas.git","clone_url":"https://github.com/pandas-dev/pandas.git","svn_url":"https://github.com/pandas-dev/pandas","homepage":"https://pandas.pydata.org","size":139689,"stargazers_count":17297,"watchers_count":17297,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":6964,"mirror_url":null,"archived":false,"open_issues_count":2832,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":6964,"open_issues":2832,"watchers":17297,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/24159"},"html":{"href":"https://github.com/pandas-dev/pandas/pull/24159"},"issue":{"href":"https://api.github.com/repos/pandas-dev/pandas/issues/24159"},"comments":{"href":"https://api.github.com/repos/pandas-dev/pandas/issues/24159/comments"},"review_comments":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/24159/comments"},"review_comment":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/24159/commits"},"statuses":{"href":"https://api.github.com/repos/pandas-dev/pandas/statuses/1d4ac73aa1e3fb41acde6f7d726a07833652f9f0"}},"author_association":"CONTRIBUTOR"}} | {
"id": 858127,
"name": "pandas-dev/pandas",
"url": "https://api.github.com/repos/pandas-dev/pandas"
} | {
"id": 10647082,
"login": "mroeschke",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/10647082?",
"url": "https://api.github.com/users/mroeschke"
} | {
"id": 21206976,
"login": "pandas-dev",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/21206976?",
"url": "https://api.github.com/orgs/pandas-dev"
} | 2018-12-10T07:06:36 | 8724811732 | {"actor":{"display_login":"mroeschke"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/openattic/ceph/pulls/comments/167861887","pull_request_review_id":96138240,"id":167861887,"diff_hunk":"@@ -5,13 +5,14 @@ import {\n Input,\n OnChanges,\n OnInit,\n- Output,\n+ Output, TemplateRef,","path":"src/pybind/mgr/dashboard_v2/frontend/src/app/shared/components/table/table.component.ts","position":5,"original_position":5,"commit_id":"03f85735b1533d2912b67686cd2860a4c6b0175f","original_commit_id":"03f85735b1533d2912b67686cd2860a4c6b0175f","user":{"login":"tspmelo","id":399326,"avatar_url":"https://avatars2.githubusercontent.com/u/399326?v=4","gravatar_id":"","url":"https://api.github.com/users/tspmelo","html_url":"https://github.com/tspmelo","followers_url":"https://api.github.com/users/tspmelo/followers","following_url":"https://api.github.com/users/tspmelo/following{/other_user}","gists_url":"https://api.github.com/users/tspmelo/gists{/gist_id}","starred_url":"https://api.github.com/users/tspmelo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tspmelo/subscriptions","organizations_url":"https://api.github.com/users/tspmelo/orgs","repos_url":"https://api.github.com/users/tspmelo/repos","events_url":"https://api.github.com/users/tspmelo/events{/privacy}","received_events_url":"https://api.github.com/users/tspmelo/received_events","type":"User","site_admin":false},"body":"break this into 2 lines.","created_at":"2018-02-13T13:23:34Z","updated_at":"2018-02-13T13:23:34Z","html_url":"https://github.com/openattic/ceph/pull/90#discussion_r167861887","pull_request_url":"https://api.github.com/repos/openattic/ceph/pulls/90","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/openattic/ceph/pulls/comments/167861887"},"html":{"href":"https://github.com/openattic/ceph/pull/90#discussion_r167861887"},"pull_request":{"href":"https://api.github.com/repos/openattic/ceph/pulls/90"}}},"pull_request":{"url":"https://api.github.com/repos/openattic/ceph/pulls/90","id":168835200,"html_url":"https://github.com/openattic/ceph/pull/90","diff_url":"https://github.com/openattic/ceph/pull/90.diff","patch_url":"https://github.com/openattic/ceph/pull/90.patch","issue_url":"https://api.github.com/repos/openattic/ceph/issues/90","number":90,"state":"open","locked":false,"title":"mgr/dashboard_v2: Easy table cell transformation","user":{"login":"Devp00l","id":16167865,"avatar_url":"https://avatars3.githubusercontent.com/u/16167865?v=4","gravatar_id":"","url":"https://api.github.com/users/Devp00l","html_url":"https://github.com/Devp00l","followers_url":"https://api.github.com/users/Devp00l/followers","following_url":"https://api.github.com/users/Devp00l/following{/other_user}","gists_url":"https://api.github.com/users/Devp00l/gists{/gist_id}","starred_url":"https://api.github.com/users/Devp00l/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Devp00l/subscriptions","organizations_url":"https://api.github.com/users/Devp00l/orgs","repos_url":"https://api.github.com/users/Devp00l/repos","events_url":"https://api.github.com/users/Devp00l/events{/privacy}","received_events_url":"https://api.github.com/users/Devp00l/received_events","type":"User","site_admin":false},"body":"The table column definition is extended by \"cellTransformation\"\r\nproperty, which is filled through the use of \"CellTemplate\" enum.\r\nIf you have set that, a specific template reference will be used for\r\nthe ngx column property \"cellTemplate\". All references are stored\r\nat the bottom of the data table template.\r\n\r\nSigned-off-by: Stephan Müller <[email protected]>","created_at":"2018-02-13T12:44:47Z","updated_at":"2018-02-13T13:23:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"43b1d1e19d96858858f5974256046d282c53d964","assignee":null,"assignees":[],"requested_reviewers":[{"login":"votdev","id":1897962,"avatar_url":"https://avatars3.githubusercontent.com/u/1897962?v=4","gravatar_id":"","url":"https://api.github.com/users/votdev","html_url":"https://github.com/votdev","followers_url":"https://api.github.com/users/votdev/followers","following_url":"https://api.github.com/users/votdev/following{/other_user}","gists_url":"https://api.github.com/users/votdev/gists{/gist_id}","starred_url":"https://api.github.com/users/votdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/votdev/subscriptions","organizations_url":"https://api.github.com/users/votdev/orgs","repos_url":"https://api.github.com/users/votdev/repos","events_url":"https://api.github.com/users/votdev/events{/privacy}","received_events_url":"https://api.github.com/users/votdev/received_events","type":"User","site_admin":false},{"login":"Exotelis","id":7863239,"avatar_url":"https://avatars3.githubusercontent.com/u/7863239?v=4","gravatar_id":"","url":"https://api.github.com/users/Exotelis","html_url":"https://github.com/Exotelis","followers_url":"https://api.github.com/users/Exotelis/followers","following_url":"https://api.github.com/users/Exotelis/following{/other_user}","gists_url":"https://api.github.com/users/Exotelis/gists{/gist_id}","starred_url":"https://api.github.com/users/Exotelis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Exotelis/subscriptions","organizations_url":"https://api.github.com/users/Exotelis/orgs","repos_url":"https://api.github.com/users/Exotelis/repos","events_url":"https://api.github.com/users/Exotelis/events{/privacy}","received_events_url":"https://api.github.com/users/Exotelis/received_events","type":"User","site_admin":false},{"login":"ricardoasmarques","id":14297426,"avatar_url":"https://avatars2.githubusercontent.com/u/14297426?v=4","gravatar_id":"","url":"https://api.github.com/users/ricardoasmarques","html_url":"https://github.com/ricardoasmarques","followers_url":"https://api.github.com/users/ricardoasmarques/followers","following_url":"https://api.github.com/users/ricardoasmarques/following{/other_user}","gists_url":"https://api.github.com/users/ricardoasmarques/gists{/gist_id}","starred_url":"https://api.github.com/users/ricardoasmarques/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ricardoasmarques/subscriptions","organizations_url":"https://api.github.com/users/ricardoasmarques/orgs","repos_url":"https://api.github.com/users/ricardoasmarques/repos","events_url":"https://api.github.com/users/ricardoasmarques/events{/privacy}","received_events_url":"https://api.github.com/users/ricardoasmarques/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":816251175,"url":"https://api.github.com/repos/openattic/ceph/labels/dashboard/frontend","name":"dashboard/frontend","color":"792fce","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/openattic/ceph/pulls/90/commits","review_comments_url":"https://api.github.com/repos/openattic/ceph/pulls/90/comments","review_comment_url":"https://api.github.com/repos/openattic/ceph/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openattic/ceph/issues/90/comments","statuses_url":"https://api.github.com/repos/openattic/ceph/statuses/03f85735b1533d2912b67686cd2860a4c6b0175f","head":{"label":"Devp00l:table-cell-transformation","ref":"table-cell-transformation","sha":"03f85735b1533d2912b67686cd2860a4c6b0175f","user":{"login":"Devp00l","id":16167865,"avatar_url":"https://avatars3.githubusercontent.com/u/16167865?v=4","gravatar_id":"","url":"https://api.github.com/users/Devp00l","html_url":"https://github.com/Devp00l","followers_url":"https://api.github.com/users/Devp00l/followers","following_url":"https://api.github.com/users/Devp00l/following{/other_user}","gists_url":"https://api.github.com/users/Devp00l/gists{/gist_id}","starred_url":"https://api.github.com/users/Devp00l/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Devp00l/subscriptions","organizations_url":"https://api.github.com/users/Devp00l/orgs","repos_url":"https://api.github.com/users/Devp00l/repos","events_url":"https://api.github.com/users/Devp00l/events{/privacy}","received_events_url":"https://api.github.com/users/Devp00l/received_events","type":"User","site_admin":false},"repo":{"id":117702152,"name":"ceph","full_name":"Devp00l/ceph","owner":{"login":"Devp00l","id":16167865,"avatar_url":"https://avatars3.githubusercontent.com/u/16167865?v=4","gravatar_id":"","url":"https://api.github.com/users/Devp00l","html_url":"https://github.com/Devp00l","followers_url":"https://api.github.com/users/Devp00l/followers","following_url":"https://api.github.com/users/Devp00l/following{/other_user}","gists_url":"https://api.github.com/users/Devp00l/gists{/gist_id}","starred_url":"https://api.github.com/users/Devp00l/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Devp00l/subscriptions","organizations_url":"https://api.github.com/users/Devp00l/orgs","repos_url":"https://api.github.com/users/Devp00l/repos","events_url":"https://api.github.com/users/Devp00l/events{/privacy}","received_events_url":"https://api.github.com/users/Devp00l/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Devp00l/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":true,"url":"https://api.github.com/repos/Devp00l/ceph","forks_url":"https://api.github.com/repos/Devp00l/ceph/forks","keys_url":"https://api.github.com/repos/Devp00l/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Devp00l/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Devp00l/ceph/teams","hooks_url":"https://api.github.com/repos/Devp00l/ceph/hooks","issue_events_url":"https://api.github.com/repos/Devp00l/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/Devp00l/ceph/events","assignees_url":"https://api.github.com/repos/Devp00l/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/Devp00l/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/Devp00l/ceph/tags","blobs_url":"https://api.github.com/repos/Devp00l/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Devp00l/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Devp00l/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/Devp00l/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Devp00l/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/Devp00l/ceph/languages","stargazers_url":"https://api.github.com/repos/Devp00l/ceph/stargazers","contributors_url":"https://api.github.com/repos/Devp00l/ceph/contributors","subscribers_url":"https://api.github.com/repos/Devp00l/ceph/subscribers","subscription_url":"https://api.github.com/repos/Devp00l/ceph/subscription","commits_url":"https://api.github.com/repos/Devp00l/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/Devp00l/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/Devp00l/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/Devp00l/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/Devp00l/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/Devp00l/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Devp00l/ceph/merges","archive_url":"https://api.github.com/repos/Devp00l/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Devp00l/ceph/downloads","issues_url":"https://api.github.com/repos/Devp00l/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/Devp00l/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/Devp00l/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/Devp00l/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Devp00l/ceph/labels{/name}","releases_url":"https://api.github.com/repos/Devp00l/ceph/releases{/id}","deployments_url":"https://api.github.com/repos/Devp00l/ceph/deployments","created_at":"2018-01-16T15:31:47Z","updated_at":"2018-01-16T15:32:06Z","pushed_at":"2018-02-13T12:32:15Z","git_url":"git://github.com/Devp00l/ceph.git","ssh_url":"[email protected]:Devp00l/ceph.git","clone_url":"https://github.com/Devp00l/ceph.git","svn_url":"https://github.com/Devp00l/ceph","homepage":"http://ceph.com","size":266442,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openattic:wip-mgr-dashboard_v2","ref":"wip-mgr-dashboard_v2","sha":"0d984a4f0b88753749b6edc7113a27213b07716c","user":{"login":"openattic","id":21334646,"avatar_url":"https://avatars3.githubusercontent.com/u/21334646?v=4","gravatar_id":"","url":"https://api.github.com/users/openattic","html_url":"https://github.com/openattic","followers_url":"https://api.github.com/users/openattic/followers","following_url":"https://api.github.com/users/openattic/following{/other_user}","gists_url":"https://api.github.com/users/openattic/gists{/gist_id}","starred_url":"https://api.github.com/users/openattic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openattic/subscriptions","organizations_url":"https://api.github.com/users/openattic/orgs","repos_url":"https://api.github.com/users/openattic/repos","events_url":"https://api.github.com/users/openattic/events{/privacy}","received_events_url":"https://api.github.com/users/openattic/received_events","type":"Organization","site_admin":false},"repo":{"id":118111246,"name":"ceph","full_name":"openattic/ceph","owner":{"login":"openattic","id":21334646,"avatar_url":"https://avatars3.githubusercontent.com/u/21334646?v=4","gravatar_id":"","url":"https://api.github.com/users/openattic","html_url":"https://github.com/openattic","followers_url":"https://api.github.com/users/openattic/followers","following_url":"https://api.github.com/users/openattic/following{/other_user}","gists_url":"https://api.github.com/users/openattic/gists{/gist_id}","starred_url":"https://api.github.com/users/openattic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openattic/subscriptions","organizations_url":"https://api.github.com/users/openattic/orgs","repos_url":"https://api.github.com/users/openattic/repos","events_url":"https://api.github.com/users/openattic/events{/privacy}","received_events_url":"https://api.github.com/users/openattic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openattic/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":true,"url":"https://api.github.com/repos/openattic/ceph","forks_url":"https://api.github.com/repos/openattic/ceph/forks","keys_url":"https://api.github.com/repos/openattic/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openattic/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openattic/ceph/teams","hooks_url":"https://api.github.com/repos/openattic/ceph/hooks","issue_events_url":"https://api.github.com/repos/openattic/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/openattic/ceph/events","assignees_url":"https://api.github.com/repos/openattic/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/openattic/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/openattic/ceph/tags","blobs_url":"https://api.github.com/repos/openattic/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openattic/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openattic/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/openattic/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openattic/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/openattic/ceph/languages","stargazers_url":"https://api.github.com/repos/openattic/ceph/stargazers","contributors_url":"https://api.github.com/repos/openattic/ceph/contributors","subscribers_url":"https://api.github.com/repos/openattic/ceph/subscribers","subscription_url":"https://api.github.com/repos/openattic/ceph/subscription","commits_url":"https://api.github.com/repos/openattic/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/openattic/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/openattic/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/openattic/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/openattic/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/openattic/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openattic/ceph/merges","archive_url":"https://api.github.com/repos/openattic/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openattic/ceph/downloads","issues_url":"https://api.github.com/repos/openattic/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/openattic/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/openattic/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/openattic/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openattic/ceph/labels{/name}","releases_url":"https://api.github.com/repos/openattic/ceph/releases{/id}","deployments_url":"https://api.github.com/repos/openattic/ceph/deployments","created_at":"2018-01-19T10:24:24Z","updated_at":"2018-02-06T04:05:00Z","pushed_at":"2018-02-13T12:44:48Z","git_url":"git://github.com/openattic/ceph.git","ssh_url":"[email protected]:openattic/ceph.git","clone_url":"https://github.com/openattic/ceph.git","svn_url":"https://github.com/openattic/ceph","homepage":"http://ceph.com","size":266227,"stargazers_count":3,"watchers_count":3,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":15,"license":null,"forks":3,"open_issues":15,"watchers":3,"default_branch":"wip-mgr-dashboard_v2"}},"_links":{"self":{"href":"https://api.github.com/repos/openattic/ceph/pulls/90"},"html":{"href":"https://github.com/openattic/ceph/pull/90"},"issue":{"href":"https://api.github.com/repos/openattic/ceph/issues/90"},"comments":{"href":"https://api.github.com/repos/openattic/ceph/issues/90/comments"},"review_comments":{"href":"https://api.github.com/repos/openattic/ceph/pulls/90/comments"},"review_comment":{"href":"https://api.github.com/repos/openattic/ceph/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openattic/ceph/pulls/90/commits"},"statuses":{"href":"https://api.github.com/repos/openattic/ceph/statuses/03f85735b1533d2912b67686cd2860a4c6b0175f"}},"author_association":"NONE"}} | {
"id": 118111246,
"name": "openattic/ceph",
"url": "https://api.github.com/repos/openattic/ceph"
} | {
"id": 399326,
"login": "tspmelo",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/399326?",
"url": "https://api.github.com/users/tspmelo"
} | {
"id": 21334646,
"login": "openattic",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/21334646?",
"url": "https://api.github.com/orgs/openattic"
} | 2018-02-13T13:23:34 | 7238055458 | {"actor":{"display_login":"tspmelo"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/pulls/comments/206838709","pull_request_review_id":142325523,"id":206838709,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNjgzODcwOQ==","diff_hunk":"@@ -0,0 +1,139 @@\n+.checkbox-filter {\n+\n+ .tag {\n+ margin: 0 .5rem .5rem 0;\n+ }\n+\n+ .checkbox-filter__modal {\n+\n+ @include tablet {\n+ top: 10vh;\n+ left: 10vw;\n+ width: 80vw;\n+ height: 80vh;\n+ padding: 2rem;\n+ }\n+\n+ display: none;\n+ position: fixed;\n+ top: 0;\n+ left: 0;\n+ width: 100vw;\n+ height: 100vh;\n+ padding: 1rem;\n+ background-color: color('white');\n+ box-shadow: $box-shadow-primary color('dark-gray', -4);\n+ z-index: 999;\n+ overflow-y: scroll;\n+\n+ &.visible {\n+ display: block;\n+\n+ + .overlay {\n+ display: block;\n+ }\n+ }\n+\n+ header {\n+ @include tablet {\n+ margin-top: 0;\n+ }\n+\n+ margin-top: 2rem;\n+ }\n+\n+ .checkbox-filter__filter {\n+ margin-bottom: 1rem;\n+ }\n+\n+ .checkbox-filter__checkboxes {\n+ padding-bottom: 4rem;\n+ columns: auto 320px;\n+\n+ > * {\n+ display: inline-block;\n+ width: 100%;\n+ padding-right: 1rem;\n+ }\n+\n+ > [hidden] {\n+ display: none;\n+ }\n+ }\n+\n+ .checkbox-filter__actions {\n+ @include theme('border-color', 'color-primary--lighten-4', 'checkbox-with-filter-action-border-bottom');\n+ @include tablet {\n+ bottom: 10vh;\n+ left: 10vw;\n+ width: 80vw;\n+ height: 3rem;\n+ padding-left: 2rem;\n+ }\n+\n+ display: flex;\n+ position: fixed;\n+ bottom: 0;\n+ left: 0;\n+ align-items: center;\n+ width: 100vw;\n+ height: 3rem;\n+ padding-left: 1rem;\n+ border-top: 2px solid;\n+ background-color: color('white');\n+ }\n+\n+ button.checkbox-filter__close {\n+\n+ @include tablet {\n+ top: 10vh;\n+ right: 10vw;\n+ width: auto;\n+ }\n+ position: fixed;\n+","path":"styleguide/components/31-molecules/fields/checkbox-with-filter/_checkbox-with-filter.scss","position":94,"original_position":94,"commit_id":"8e1262d862a6884420ca107d359d16f42eec4ddf","original_commit_id":"8e1262d862a6884420ca107d359d16f42eec4ddf","user":{"login":"Jeroen005","id":2283257,"node_id":"MDQ6VXNlcjIyODMyNTc=","avatar_url":"https://avatars2.githubusercontent.com/u/2283257?v=4","gravatar_id":"","url":"https://api.github.com/users/Jeroen005","html_url":"https://github.com/Jeroen005","followers_url":"https://api.github.com/users/Jeroen005/followers","following_url":"https://api.github.com/users/Jeroen005/following{/other_user}","gists_url":"https://api.github.com/users/Jeroen005/gists{/gist_id}","starred_url":"https://api.github.com/users/Jeroen005/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jeroen005/subscriptions","organizations_url":"https://api.github.com/users/Jeroen005/orgs","repos_url":"https://api.github.com/users/Jeroen005/repos","events_url":"https://api.github.com/users/Jeroen005/events{/privacy}","received_events_url":"https://api.github.com/users/Jeroen005/received_events","type":"User","site_admin":false},"body":"waarom deze gekke enter?:P","created_at":"2018-08-01T11:06:20Z","updated_at":"2018-08-01T11:11:02Z","html_url":"https://github.com/StadGent/drupal_theme_gent-base/pull/272#discussion_r206838709","pull_request_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/pulls/272","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/pulls/comments/206838709"},"html":{"href":"https://github.com/StadGent/drupal_theme_gent-base/pull/272#discussion_r206838709"},"pull_request":{"href":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/pulls/272"}}},"pull_request":{"url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/pulls/272","id":205385056,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1Mzg1MDU2","html_url":"https://github.com/StadGent/drupal_theme_gent-base/pull/272","diff_url":"https://github.com/StadGent/drupal_theme_gent-base/pull/272.diff","patch_url":"https://github.com/StadGent/drupal_theme_gent-base/pull/272.patch","issue_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/issues/272","number":272,"state":"open","locked":false,"title":"DTGB-484: checkboxes with filter","user":{"login":"delrueba","id":31842807,"node_id":"MDQ6VXNlcjMxODQyODA3","avatar_url":"https://avatars2.githubusercontent.com/u/31842807?v=4","gravatar_id":"","url":"https://api.github.com/users/delrueba","html_url":"https://github.com/delrueba","followers_url":"https://api.github.com/users/delrueba/followers","following_url":"https://api.github.com/users/delrueba/following{/other_user}","gists_url":"https://api.github.com/users/delrueba/gists{/gist_id}","starred_url":"https://api.github.com/users/delrueba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/delrueba/subscriptions","organizations_url":"https://api.github.com/users/delrueba/orgs","repos_url":"https://api.github.com/users/delrueba/repos","events_url":"https://api.github.com/users/delrueba/events{/privacy}","received_events_url":"https://api.github.com/users/delrueba/received_events","type":"User","site_admin":false},"body":"<!--- Provide a general summary of your changes in the Title above -->\r\n\r\n## Description\r\n<!--- Describe your changes in detail -->\r\n\r\n## Motivation and Context\r\n<!--- Why is this change required? What problem does it solve? -->\r\n<!--- If it fixes an open issue, please link to the issue here. -->\r\n\r\n## How Has This Been Tested?\r\n<!--- Please describe in detail how you tested your changes. -->\r\n<!--- Include details of your testing environment, and the tests you ran to -->\r\n<!--- see how your change affects other areas of the code, etc. -->\r\n\r\n## Screenshots (if appropriate):\r\n\r\n\r\n\r\n\r\n\r\n## Types of changes\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->\r\n- [ ] Bug fix (non-breaking change which fixes an issue)\r\n- [ ] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\r\n\r\n## Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [ ] I have read the **CONTRIBUTING** document.\r\n- [ ] I have updated the documentation accordingly.\r\n- [ ] I have updated the style guide CHANGELOG accordingly.\r\n- [ ] I have updated the gent_base CHANGELOG accordingly.\r\n","created_at":"2018-08-01T10:51:24Z","updated_at":"2018-08-01T11:11:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"306ab31bcc99fa98f7fa70ced0033ad5b689a75c","assignee":null,"assignees":[],"requested_reviewers":[{"login":"meirege","id":30627591,"node_id":"MDQ6VXNlcjMwNjI3NTkx","avatar_url":"https://avatars3.githubusercontent.com/u/30627591?v=4","gravatar_id":"","url":"https://api.github.com/users/meirege","html_url":"https://github.com/meirege","followers_url":"https://api.github.com/users/meirege/followers","following_url":"https://api.github.com/users/meirege/following{/other_user}","gists_url":"https://api.github.com/users/meirege/gists{/gist_id}","starred_url":"https://api.github.com/users/meirege/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meirege/subscriptions","organizations_url":"https://api.github.com/users/meirege/orgs","repos_url":"https://api.github.com/users/meirege/repos","events_url":"https://api.github.com/users/meirege/events{/privacy}","received_events_url":"https://api.github.com/users/meirege/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/pulls/272/commits","review_comments_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/pulls/272/comments","review_comment_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/pulls/comments{/number}","comments_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/issues/272/comments","statuses_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/statuses/8e1262d862a6884420ca107d359d16f42eec4ddf","head":{"label":"StadGent:feature/DTGB-484","ref":"feature/DTGB-484","sha":"8e1262d862a6884420ca107d359d16f42eec4ddf","user":{"login":"StadGent","id":22027661,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMDI3NjYx","avatar_url":"https://avatars2.githubusercontent.com/u/22027661?v=4","gravatar_id":"","url":"https://api.github.com/users/StadGent","html_url":"https://github.com/StadGent","followers_url":"https://api.github.com/users/StadGent/followers","following_url":"https://api.github.com/users/StadGent/following{/other_user}","gists_url":"https://api.github.com/users/StadGent/gists{/gist_id}","starred_url":"https://api.github.com/users/StadGent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StadGent/subscriptions","organizations_url":"https://api.github.com/users/StadGent/orgs","repos_url":"https://api.github.com/users/StadGent/repos","events_url":"https://api.github.com/users/StadGent/events{/privacy}","received_events_url":"https://api.github.com/users/StadGent/received_events","type":"Organization","site_admin":false},"repo":{"id":117522691,"node_id":"MDEwOlJlcG9zaXRvcnkxMTc1MjI2OTE=","name":"drupal_theme_gent-base","full_name":"StadGent/drupal_theme_gent-base","owner":{"login":"StadGent","id":22027661,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMDI3NjYx","avatar_url":"https://avatars2.githubusercontent.com/u/22027661?v=4","gravatar_id":"","url":"https://api.github.com/users/StadGent","html_url":"https://github.com/StadGent","followers_url":"https://api.github.com/users/StadGent/followers","following_url":"https://api.github.com/users/StadGent/following{/other_user}","gists_url":"https://api.github.com/users/StadGent/gists{/gist_id}","starred_url":"https://api.github.com/users/StadGent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StadGent/subscriptions","organizations_url":"https://api.github.com/users/StadGent/orgs","repos_url":"https://api.github.com/users/StadGent/repos","events_url":"https://api.github.com/users/StadGent/events{/privacy}","received_events_url":"https://api.github.com/users/StadGent/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/StadGent/drupal_theme_gent-base","description":"gent_base is a modern, Sass and Compass enabled Drupal 7 / 8 base theme.","fork":false,"url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base","forks_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/forks","keys_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/keys{/key_id}","collaborators_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/teams","hooks_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/hooks","issue_events_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/issues/events{/number}","events_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/events","assignees_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/assignees{/user}","branches_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/branches{/branch}","tags_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/tags","blobs_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/git/refs{/sha}","trees_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/git/trees{/sha}","statuses_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/statuses/{sha}","languages_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/languages","stargazers_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/stargazers","contributors_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/contributors","subscribers_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/subscribers","subscription_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/subscription","commits_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/commits{/sha}","git_commits_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/git/commits{/sha}","comments_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/comments{/number}","issue_comment_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/issues/comments{/number}","contents_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/contents/{+path}","compare_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/compare/{base}...{head}","merges_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/merges","archive_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/downloads","issues_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/issues{/number}","pulls_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/pulls{/number}","milestones_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/milestones{/number}","notifications_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/labels{/name}","releases_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/releases{/id}","deployments_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/deployments","created_at":"2018-01-15T09:10:15Z","updated_at":"2018-08-01T10:50:41Z","pushed_at":"2018-08-01T10:51:24Z","git_url":"git://github.com/StadGent/drupal_theme_gent-base.git","ssh_url":"[email protected]:StadGent/drupal_theme_gent-base.git","clone_url":"https://github.com/StadGent/drupal_theme_gent-base.git","svn_url":"https://github.com/StadGent/drupal_theme_gent-base","homepage":"","size":36344,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":0,"open_issues":2,"watchers":0,"default_branch":"8.x-3.x-dev"}},"base":{"label":"StadGent:8.x-3.x-dev","ref":"8.x-3.x-dev","sha":"f9245912c3508dcbc1fe1d405005f3a20246cc6a","user":{"login":"StadGent","id":22027661,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMDI3NjYx","avatar_url":"https://avatars2.githubusercontent.com/u/22027661?v=4","gravatar_id":"","url":"https://api.github.com/users/StadGent","html_url":"https://github.com/StadGent","followers_url":"https://api.github.com/users/StadGent/followers","following_url":"https://api.github.com/users/StadGent/following{/other_user}","gists_url":"https://api.github.com/users/StadGent/gists{/gist_id}","starred_url":"https://api.github.com/users/StadGent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StadGent/subscriptions","organizations_url":"https://api.github.com/users/StadGent/orgs","repos_url":"https://api.github.com/users/StadGent/repos","events_url":"https://api.github.com/users/StadGent/events{/privacy}","received_events_url":"https://api.github.com/users/StadGent/received_events","type":"Organization","site_admin":false},"repo":{"id":117522691,"node_id":"MDEwOlJlcG9zaXRvcnkxMTc1MjI2OTE=","name":"drupal_theme_gent-base","full_name":"StadGent/drupal_theme_gent-base","owner":{"login":"StadGent","id":22027661,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMDI3NjYx","avatar_url":"https://avatars2.githubusercontent.com/u/22027661?v=4","gravatar_id":"","url":"https://api.github.com/users/StadGent","html_url":"https://github.com/StadGent","followers_url":"https://api.github.com/users/StadGent/followers","following_url":"https://api.github.com/users/StadGent/following{/other_user}","gists_url":"https://api.github.com/users/StadGent/gists{/gist_id}","starred_url":"https://api.github.com/users/StadGent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StadGent/subscriptions","organizations_url":"https://api.github.com/users/StadGent/orgs","repos_url":"https://api.github.com/users/StadGent/repos","events_url":"https://api.github.com/users/StadGent/events{/privacy}","received_events_url":"https://api.github.com/users/StadGent/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/StadGent/drupal_theme_gent-base","description":"gent_base is a modern, Sass and Compass enabled Drupal 7 / 8 base theme.","fork":false,"url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base","forks_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/forks","keys_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/keys{/key_id}","collaborators_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/teams","hooks_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/hooks","issue_events_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/issues/events{/number}","events_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/events","assignees_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/assignees{/user}","branches_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/branches{/branch}","tags_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/tags","blobs_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/git/refs{/sha}","trees_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/git/trees{/sha}","statuses_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/statuses/{sha}","languages_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/languages","stargazers_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/stargazers","contributors_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/contributors","subscribers_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/subscribers","subscription_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/subscription","commits_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/commits{/sha}","git_commits_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/git/commits{/sha}","comments_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/comments{/number}","issue_comment_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/issues/comments{/number}","contents_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/contents/{+path}","compare_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/compare/{base}...{head}","merges_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/merges","archive_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/downloads","issues_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/issues{/number}","pulls_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/pulls{/number}","milestones_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/milestones{/number}","notifications_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/labels{/name}","releases_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/releases{/id}","deployments_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/deployments","created_at":"2018-01-15T09:10:15Z","updated_at":"2018-08-01T10:50:41Z","pushed_at":"2018-08-01T10:51:24Z","git_url":"git://github.com/StadGent/drupal_theme_gent-base.git","ssh_url":"[email protected]:StadGent/drupal_theme_gent-base.git","clone_url":"https://github.com/StadGent/drupal_theme_gent-base.git","svn_url":"https://github.com/StadGent/drupal_theme_gent-base","homepage":"","size":36344,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":0,"open_issues":2,"watchers":0,"default_branch":"8.x-3.x-dev"}},"_links":{"self":{"href":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/pulls/272"},"html":{"href":"https://github.com/StadGent/drupal_theme_gent-base/pull/272"},"issue":{"href":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/issues/272"},"comments":{"href":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/issues/272/comments"},"review_comments":{"href":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/pulls/272/comments"},"review_comment":{"href":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/pulls/272/commits"},"statuses":{"href":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/statuses/8e1262d862a6884420ca107d359d16f42eec4ddf"}},"author_association":"CONTRIBUTOR"}} | {
"id": 117522691,
"name": "StadGent/drupal_theme_gent-base",
"url": "https://api.github.com/repos/StadGent/drupal_theme_gent-base"
} | {
"id": 2283257,
"login": "Jeroen005",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2283257?",
"url": "https://api.github.com/users/Jeroen005"
} | {
"id": 22027661,
"login": "StadGent",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/22027661?",
"url": "https://api.github.com/orgs/StadGent"
} | 2018-08-01T11:06:20 | 8049754928 | {"actor":{"display_login":"Jeroen005"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/pulls/comments/198069588","pull_request_review_id":131929354,"id":198069588,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5ODA2OTU4OA==","diff_hunk":"@@ -43,9 +43,11 @@\n }\n \n > ul {\n- display: flex;\n- flex: 1 1 100%;\n- flex-wrap: wrap;\n+ @include tablet {","path":"styleguide/components/61-layouts/general/overview-layout/_overview-layout.scss","position":7,"original_position":7,"commit_id":"58c470536ee2cb61f6300ba57950934025ee181b","original_commit_id":"58c470536ee2cb61f6300ba57950934025ee181b","user":{"login":"delrueba","id":31842807,"node_id":"MDQ6VXNlcjMxODQyODA3","avatar_url":"https://avatars2.githubusercontent.com/u/31842807?v=4","gravatar_id":"","url":"https://api.github.com/users/delrueba","html_url":"https://github.com/delrueba","followers_url":"https://api.github.com/users/delrueba/followers","following_url":"https://api.github.com/users/delrueba/following{/other_user}","gists_url":"https://api.github.com/users/delrueba/gists{/gist_id}","starred_url":"https://api.github.com/users/delrueba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/delrueba/subscriptions","organizations_url":"https://api.github.com/users/delrueba/orgs","repos_url":"https://api.github.com/users/delrueba/repos","events_url":"https://api.github.com/users/delrueba/events{/privacy}","received_events_url":"https://api.github.com/users/delrueba/received_events","type":"User","site_admin":false},"body":"Why is it no longer flex below tablet?\r\nWont the teasers get too large?","created_at":"2018-06-26T09:12:07Z","updated_at":"2018-06-26T09:12:17Z","html_url":"https://github.com/StadGent/drupal_theme_gent-base/pull/214#discussion_r198069588","pull_request_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/pulls/214","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/pulls/comments/198069588"},"html":{"href":"https://github.com/StadGent/drupal_theme_gent-base/pull/214#discussion_r198069588"},"pull_request":{"href":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/pulls/214"}}},"pull_request":{"url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/pulls/214","id":197352084,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3MzUyMDg0","html_url":"https://github.com/StadGent/drupal_theme_gent-base/pull/214","diff_url":"https://github.com/StadGent/drupal_theme_gent-base/pull/214.diff","patch_url":"https://github.com/StadGent/drupal_theme_gent-base/pull/214.patch","issue_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/issues/214","number":214,"state":"open","locked":false,"title":"Feature/DTGB-454: Fixed news overview page.","user":{"login":"meirege","id":30627591,"node_id":"MDQ6VXNlcjMwNjI3NTkx","avatar_url":"https://avatars3.githubusercontent.com/u/30627591?v=4","gravatar_id":"","url":"https://api.github.com/users/meirege","html_url":"https://github.com/meirege","followers_url":"https://api.github.com/users/meirege/followers","following_url":"https://api.github.com/users/meirege/following{/other_user}","gists_url":"https://api.github.com/users/meirege/gists{/gist_id}","starred_url":"https://api.github.com/users/meirege/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meirege/subscriptions","organizations_url":"https://api.github.com/users/meirege/orgs","repos_url":"https://api.github.com/users/meirege/repos","events_url":"https://api.github.com/users/meirege/events{/privacy}","received_events_url":"https://api.github.com/users/meirege/received_events","type":"User","site_admin":false},"body":"<!--- Provide a general summary of your changes in the Title above -->\r\n\r\n## Description\r\n<!--- Describe your changes in detail -->\r\n\r\n## Motivation and Context\r\n<!--- Why is this change required? What problem does it solve? -->\r\n<!--- If it fixes an open issue, please link to the issue here. -->\r\n\r\n## How Has This Been Tested?\r\n<!--- Please describe in detail how you tested your changes. -->\r\n<!--- Include details of your testing environment, and the tests you ran to -->\r\n<!--- see how your change affects other areas of the code, etc. -->\r\n\r\n## Screenshots (if appropriate):\r\n\r\n## Types of changes\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->\r\n- [ ] Bug fix (non-breaking change which fixes an issue)\r\n- [ ] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\r\n\r\n## Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [ ] I have read the **CONTRIBUTING** document.\r\n- [ ] I have updated the documentation accordingly.\r\n- [ ] I have updated the style guide CHANGELOG accordingly.\r\n- [ ] I have updated the gent_base CHANGELOG accordingly.\r\n","created_at":"2018-06-26T09:08:49Z","updated_at":"2018-06-26T09:12:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e0f48e209265c92dd1f5851b6eac317f8942d46f","assignee":{"login":"meirege","id":30627591,"node_id":"MDQ6VXNlcjMwNjI3NTkx","avatar_url":"https://avatars3.githubusercontent.com/u/30627591?v=4","gravatar_id":"","url":"https://api.github.com/users/meirege","html_url":"https://github.com/meirege","followers_url":"https://api.github.com/users/meirege/followers","following_url":"https://api.github.com/users/meirege/following{/other_user}","gists_url":"https://api.github.com/users/meirege/gists{/gist_id}","starred_url":"https://api.github.com/users/meirege/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meirege/subscriptions","organizations_url":"https://api.github.com/users/meirege/orgs","repos_url":"https://api.github.com/users/meirege/repos","events_url":"https://api.github.com/users/meirege/events{/privacy}","received_events_url":"https://api.github.com/users/meirege/received_events","type":"User","site_admin":false},"assignees":[{"login":"meirege","id":30627591,"node_id":"MDQ6VXNlcjMwNjI3NTkx","avatar_url":"https://avatars3.githubusercontent.com/u/30627591?v=4","gravatar_id":"","url":"https://api.github.com/users/meirege","html_url":"https://github.com/meirege","followers_url":"https://api.github.com/users/meirege/followers","following_url":"https://api.github.com/users/meirege/following{/other_user}","gists_url":"https://api.github.com/users/meirege/gists{/gist_id}","starred_url":"https://api.github.com/users/meirege/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meirege/subscriptions","organizations_url":"https://api.github.com/users/meirege/orgs","repos_url":"https://api.github.com/users/meirege/repos","events_url":"https://api.github.com/users/meirege/events{/privacy}","received_events_url":"https://api.github.com/users/meirege/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"Jeroen005","id":2283257,"node_id":"MDQ6VXNlcjIyODMyNTc=","avatar_url":"https://avatars2.githubusercontent.com/u/2283257?v=4","gravatar_id":"","url":"https://api.github.com/users/Jeroen005","html_url":"https://github.com/Jeroen005","followers_url":"https://api.github.com/users/Jeroen005/followers","following_url":"https://api.github.com/users/Jeroen005/following{/other_user}","gists_url":"https://api.github.com/users/Jeroen005/gists{/gist_id}","starred_url":"https://api.github.com/users/Jeroen005/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jeroen005/subscriptions","organizations_url":"https://api.github.com/users/Jeroen005/orgs","repos_url":"https://api.github.com/users/Jeroen005/repos","events_url":"https://api.github.com/users/Jeroen005/events{/privacy}","received_events_url":"https://api.github.com/users/Jeroen005/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/pulls/214/commits","review_comments_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/pulls/214/comments","review_comment_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/pulls/comments{/number}","comments_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/issues/214/comments","statuses_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/statuses/58c470536ee2cb61f6300ba57950934025ee181b","head":{"label":"StadGent:feature/DTGB-454","ref":"feature/DTGB-454","sha":"58c470536ee2cb61f6300ba57950934025ee181b","user":{"login":"StadGent","id":22027661,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMDI3NjYx","avatar_url":"https://avatars2.githubusercontent.com/u/22027661?v=4","gravatar_id":"","url":"https://api.github.com/users/StadGent","html_url":"https://github.com/StadGent","followers_url":"https://api.github.com/users/StadGent/followers","following_url":"https://api.github.com/users/StadGent/following{/other_user}","gists_url":"https://api.github.com/users/StadGent/gists{/gist_id}","starred_url":"https://api.github.com/users/StadGent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StadGent/subscriptions","organizations_url":"https://api.github.com/users/StadGent/orgs","repos_url":"https://api.github.com/users/StadGent/repos","events_url":"https://api.github.com/users/StadGent/events{/privacy}","received_events_url":"https://api.github.com/users/StadGent/received_events","type":"Organization","site_admin":false},"repo":{"id":117522691,"node_id":"MDEwOlJlcG9zaXRvcnkxMTc1MjI2OTE=","name":"drupal_theme_gent-base","full_name":"StadGent/drupal_theme_gent-base","owner":{"login":"StadGent","id":22027661,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMDI3NjYx","avatar_url":"https://avatars2.githubusercontent.com/u/22027661?v=4","gravatar_id":"","url":"https://api.github.com/users/StadGent","html_url":"https://github.com/StadGent","followers_url":"https://api.github.com/users/StadGent/followers","following_url":"https://api.github.com/users/StadGent/following{/other_user}","gists_url":"https://api.github.com/users/StadGent/gists{/gist_id}","starred_url":"https://api.github.com/users/StadGent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StadGent/subscriptions","organizations_url":"https://api.github.com/users/StadGent/orgs","repos_url":"https://api.github.com/users/StadGent/repos","events_url":"https://api.github.com/users/StadGent/events{/privacy}","received_events_url":"https://api.github.com/users/StadGent/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/StadGent/drupal_theme_gent-base","description":"gent_base is a modern, Sass and Compass enabled Drupal 7 / 8 base theme.","fork":false,"url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base","forks_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/forks","keys_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/keys{/key_id}","collaborators_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/teams","hooks_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/hooks","issue_events_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/issues/events{/number}","events_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/events","assignees_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/assignees{/user}","branches_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/branches{/branch}","tags_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/tags","blobs_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/git/refs{/sha}","trees_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/git/trees{/sha}","statuses_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/statuses/{sha}","languages_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/languages","stargazers_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/stargazers","contributors_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/contributors","subscribers_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/subscribers","subscription_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/subscription","commits_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/commits{/sha}","git_commits_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/git/commits{/sha}","comments_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/comments{/number}","issue_comment_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/issues/comments{/number}","contents_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/contents/{+path}","compare_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/compare/{base}...{head}","merges_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/merges","archive_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/downloads","issues_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/issues{/number}","pulls_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/pulls{/number}","milestones_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/milestones{/number}","notifications_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/labels{/name}","releases_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/releases{/id}","deployments_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/deployments","created_at":"2018-01-15T09:10:15Z","updated_at":"2018-06-26T09:08:52Z","pushed_at":"2018-06-26T09:08:55Z","git_url":"git://github.com/StadGent/drupal_theme_gent-base.git","ssh_url":"[email protected]:StadGent/drupal_theme_gent-base.git","clone_url":"https://github.com/StadGent/drupal_theme_gent-base.git","svn_url":"https://github.com/StadGent/drupal_theme_gent-base","homepage":"","size":35679,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":0,"open_issues":3,"watchers":0,"default_branch":"8.x-3.x-dev"}},"base":{"label":"StadGent:8.x-3.x-dev","ref":"8.x-3.x-dev","sha":"153acd3355de63e5121427d90f207814112cfcb4","user":{"login":"StadGent","id":22027661,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMDI3NjYx","avatar_url":"https://avatars2.githubusercontent.com/u/22027661?v=4","gravatar_id":"","url":"https://api.github.com/users/StadGent","html_url":"https://github.com/StadGent","followers_url":"https://api.github.com/users/StadGent/followers","following_url":"https://api.github.com/users/StadGent/following{/other_user}","gists_url":"https://api.github.com/users/StadGent/gists{/gist_id}","starred_url":"https://api.github.com/users/StadGent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StadGent/subscriptions","organizations_url":"https://api.github.com/users/StadGent/orgs","repos_url":"https://api.github.com/users/StadGent/repos","events_url":"https://api.github.com/users/StadGent/events{/privacy}","received_events_url":"https://api.github.com/users/StadGent/received_events","type":"Organization","site_admin":false},"repo":{"id":117522691,"node_id":"MDEwOlJlcG9zaXRvcnkxMTc1MjI2OTE=","name":"drupal_theme_gent-base","full_name":"StadGent/drupal_theme_gent-base","owner":{"login":"StadGent","id":22027661,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMDI3NjYx","avatar_url":"https://avatars2.githubusercontent.com/u/22027661?v=4","gravatar_id":"","url":"https://api.github.com/users/StadGent","html_url":"https://github.com/StadGent","followers_url":"https://api.github.com/users/StadGent/followers","following_url":"https://api.github.com/users/StadGent/following{/other_user}","gists_url":"https://api.github.com/users/StadGent/gists{/gist_id}","starred_url":"https://api.github.com/users/StadGent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StadGent/subscriptions","organizations_url":"https://api.github.com/users/StadGent/orgs","repos_url":"https://api.github.com/users/StadGent/repos","events_url":"https://api.github.com/users/StadGent/events{/privacy}","received_events_url":"https://api.github.com/users/StadGent/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/StadGent/drupal_theme_gent-base","description":"gent_base is a modern, Sass and Compass enabled Drupal 7 / 8 base theme.","fork":false,"url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base","forks_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/forks","keys_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/keys{/key_id}","collaborators_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/teams","hooks_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/hooks","issue_events_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/issues/events{/number}","events_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/events","assignees_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/assignees{/user}","branches_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/branches{/branch}","tags_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/tags","blobs_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/git/refs{/sha}","trees_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/git/trees{/sha}","statuses_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/statuses/{sha}","languages_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/languages","stargazers_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/stargazers","contributors_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/contributors","subscribers_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/subscribers","subscription_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/subscription","commits_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/commits{/sha}","git_commits_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/git/commits{/sha}","comments_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/comments{/number}","issue_comment_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/issues/comments{/number}","contents_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/contents/{+path}","compare_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/compare/{base}...{head}","merges_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/merges","archive_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/downloads","issues_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/issues{/number}","pulls_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/pulls{/number}","milestones_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/milestones{/number}","notifications_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/labels{/name}","releases_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/releases{/id}","deployments_url":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/deployments","created_at":"2018-01-15T09:10:15Z","updated_at":"2018-06-26T09:08:52Z","pushed_at":"2018-06-26T09:08:55Z","git_url":"git://github.com/StadGent/drupal_theme_gent-base.git","ssh_url":"[email protected]:StadGent/drupal_theme_gent-base.git","clone_url":"https://github.com/StadGent/drupal_theme_gent-base.git","svn_url":"https://github.com/StadGent/drupal_theme_gent-base","homepage":"","size":35679,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":0,"open_issues":3,"watchers":0,"default_branch":"8.x-3.x-dev"}},"_links":{"self":{"href":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/pulls/214"},"html":{"href":"https://github.com/StadGent/drupal_theme_gent-base/pull/214"},"issue":{"href":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/issues/214"},"comments":{"href":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/issues/214/comments"},"review_comments":{"href":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/pulls/214/comments"},"review_comment":{"href":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/pulls/214/commits"},"statuses":{"href":"https://api.github.com/repos/StadGent/drupal_theme_gent-base/statuses/58c470536ee2cb61f6300ba57950934025ee181b"}},"author_association":"COLLABORATOR"}} | {
"id": 117522691,
"name": "StadGent/drupal_theme_gent-base",
"url": "https://api.github.com/repos/StadGent/drupal_theme_gent-base"
} | {
"id": 31842807,
"login": "delrueba",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/31842807?",
"url": "https://api.github.com/users/delrueba"
} | {
"id": 22027661,
"login": "StadGent",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/22027661?",
"url": "https://api.github.com/orgs/StadGent"
} | 2018-06-26T09:12:07 | 7878090333 | {"actor":{"display_login":"delrueba"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/LiteOS/LiteOS/pulls/comments/192645406","pull_request_review_id":125351088,"id":192645406,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5MjY0NTQwNg==","diff_hunk":"@@ -0,0 +1,157 @@\n+/*----------------------------------------------------------------------------\n+ * Copyright (c) <2016-2018>, <Huawei Technologies Co., Ltd>\n+ * All rights reserved.\n+ * Redistribution and use in source and binary forms, with or without modification,\n+ * are permitted provided that the following conditions are met:\n+ * 1. Redistributions of source code must retain the above copyright notice, this list of\n+ * conditions and the following disclaimer.\n+ * 2. Redistributions in binary form must reproduce the above copyright notice, this list\n+ * of conditions and the following disclaimer in the documentation and/or other materials\n+ * provided with the distribution.\n+ * 3. Neither the name of the copyright holder nor the names of its contributors may be used\n+ * to endorse or promote products derived from this software without specific prior written\n+ * permission.\n+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS\n+ * \"AS IS\" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,\n+ * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR\n+ * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR\n+ * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,\n+ * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,\n+ * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS;\n+ * OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY,\n+ * WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR\n+ * OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF\n+ * ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.\n+ *---------------------------------------------------------------------------*/\n+/*----------------------------------------------------------------------------\n+ * Notice of Export Control Law\n+ * ===============================================\n+ * Huawei LiteOS may be subject to applicable export control laws and regulations, which might\n+ * include those applicable to Huawei LiteOS of U.S. and the country in which you are located.\n+ * Import, export and usage of Huawei LiteOS in any manner by you shall be in compliance with such\n+ * applicable export control laws and regulations.\n+ *---------------------------------------------------------------------------*/\n+\n+#ifndef __MQTT_CLIENT_H__\n+#define __MQTT_CLIENT_H__\n+\n+#ifdef __cplusplus\n+extern \"C\" {\n+#endif\n+\n+#define MAX_REPORT_DATA_LEN (1024)","path":"components/connectivity/agent_tiny/mqtt_client/mqtt_client.h","position":42,"original_position":42,"commit_id":"d5a3d5019da1bcf36896913a3c106e4d2f8172d7","original_commit_id":"d5a3d5019da1bcf36896913a3c106e4d2f8172d7","user":{"login":"IOTBaicheng","id":30918679,"node_id":"MDQ6VXNlcjMwOTE4Njc5","avatar_url":"https://avatars3.githubusercontent.com/u/30918679?v=4","gravatar_id":"","url":"https://api.github.com/users/IOTBaicheng","html_url":"https://github.com/IOTBaicheng","followers_url":"https://api.github.com/users/IOTBaicheng/followers","following_url":"https://api.github.com/users/IOTBaicheng/following{/other_user}","gists_url":"https://api.github.com/users/IOTBaicheng/gists{/gist_id}","starred_url":"https://api.github.com/users/IOTBaicheng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IOTBaicheng/subscriptions","organizations_url":"https://api.github.com/users/IOTBaicheng/orgs","repos_url":"https://api.github.com/users/IOTBaicheng/repos","events_url":"https://api.github.com/users/IOTBaicheng/events{/privacy}","received_events_url":"https://api.github.com/users/IOTBaicheng/received_events","type":"User","site_admin":false},"body":"1024根据什么定的？","created_at":"2018-06-04T07:21:13Z","updated_at":"2018-06-04T07:29:47Z","html_url":"https://github.com/LiteOS/LiteOS/pull/180#discussion_r192645406","pull_request_url":"https://api.github.com/repos/LiteOS/LiteOS/pulls/180","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/LiteOS/LiteOS/pulls/comments/192645406"},"html":{"href":"https://github.com/LiteOS/LiteOS/pull/180#discussion_r192645406"},"pull_request":{"href":"https://api.github.com/repos/LiteOS/LiteOS/pulls/180"}}},"pull_request":{"url":"https://api.github.com/repos/LiteOS/LiteOS/pulls/180","id":191967276,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkxOTY3Mjc2","html_url":"https://github.com/LiteOS/LiteOS/pull/180","diff_url":"https://github.com/LiteOS/LiteOS/pull/180.diff","patch_url":"https://github.com/LiteOS/LiteOS/pull/180.patch","issue_url":"https://api.github.com/repos/LiteOS/LiteOS/issues/180","number":180,"state":"open","locked":false,"title":"Develop","user":{"login":"IOTBaicheng","id":30918679,"node_id":"MDQ6VXNlcjMwOTE4Njc5","avatar_url":"https://avatars3.githubusercontent.com/u/30918679?v=4","gravatar_id":"","url":"https://api.github.com/users/IOTBaicheng","html_url":"https://github.com/IOTBaicheng","followers_url":"https://api.github.com/users/IOTBaicheng/followers","following_url":"https://api.github.com/users/IOTBaicheng/following{/other_user}","gists_url":"https://api.github.com/users/IOTBaicheng/gists{/gist_id}","starred_url":"https://api.github.com/users/IOTBaicheng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IOTBaicheng/subscriptions","organizations_url":"https://api.github.com/users/IOTBaicheng/orgs","repos_url":"https://api.github.com/users/IOTBaicheng/repos","events_url":"https://api.github.com/users/IOTBaicheng/events{/privacy}","received_events_url":"https://api.github.com/users/IOTBaicheng/received_events","type":"User","site_admin":false},"body":"merge mqtt.","created_at":"2018-06-01T08:31:49Z","updated_at":"2018-06-04T07:29:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f6842a4b61e7b989bc62ed7d1af2b8dd485cfa87","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/LiteOS/LiteOS/pulls/180/commits","review_comments_url":"https://api.github.com/repos/LiteOS/LiteOS/pulls/180/comments","review_comment_url":"https://api.github.com/repos/LiteOS/LiteOS/pulls/comments{/number}","comments_url":"https://api.github.com/repos/LiteOS/LiteOS/issues/180/comments","statuses_url":"https://api.github.com/repos/LiteOS/LiteOS/statuses/d5a3d5019da1bcf36896913a3c106e4d2f8172d7","head":{"label":"l00438842:develop","ref":"develop","sha":"d5a3d5019da1bcf36896913a3c106e4d2f8172d7","user":{"login":"l00438842","id":39366143,"node_id":"MDQ6VXNlcjM5MzY2MTQz","avatar_url":"https://avatars1.githubusercontent.com/u/39366143?v=4","gravatar_id":"","url":"https://api.github.com/users/l00438842","html_url":"https://github.com/l00438842","followers_url":"https://api.github.com/users/l00438842/followers","following_url":"https://api.github.com/users/l00438842/following{/other_user}","gists_url":"https://api.github.com/users/l00438842/gists{/gist_id}","starred_url":"https://api.github.com/users/l00438842/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/l00438842/subscriptions","organizations_url":"https://api.github.com/users/l00438842/orgs","repos_url":"https://api.github.com/users/l00438842/repos","events_url":"https://api.github.com/users/l00438842/events{/privacy}","received_events_url":"https://api.github.com/users/l00438842/received_events","type":"User","site_admin":false},"repo":{"id":133895236,"node_id":"MDEwOlJlcG9zaXRvcnkxMzM4OTUyMzY=","name":"LiteOS","full_name":"l00438842/LiteOS","owner":{"login":"l00438842","id":39366143,"node_id":"MDQ6VXNlcjM5MzY2MTQz","avatar_url":"https://avatars1.githubusercontent.com/u/39366143?v=4","gravatar_id":"","url":"https://api.github.com/users/l00438842","html_url":"https://github.com/l00438842","followers_url":"https://api.github.com/users/l00438842/followers","following_url":"https://api.github.com/users/l00438842/following{/other_user}","gists_url":"https://api.github.com/users/l00438842/gists{/gist_id}","starred_url":"https://api.github.com/users/l00438842/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/l00438842/subscriptions","organizations_url":"https://api.github.com/users/l00438842/orgs","repos_url":"https://api.github.com/users/l00438842/repos","events_url":"https://api.github.com/users/l00438842/events{/privacy}","received_events_url":"https://api.github.com/users/l00438842/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/l00438842/LiteOS","description":"code and manual","fork":true,"url":"https://api.github.com/repos/l00438842/LiteOS","forks_url":"https://api.github.com/repos/l00438842/LiteOS/forks","keys_url":"https://api.github.com/repos/l00438842/LiteOS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/l00438842/LiteOS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/l00438842/LiteOS/teams","hooks_url":"https://api.github.com/repos/l00438842/LiteOS/hooks","issue_events_url":"https://api.github.com/repos/l00438842/LiteOS/issues/events{/number}","events_url":"https://api.github.com/repos/l00438842/LiteOS/events","assignees_url":"https://api.github.com/repos/l00438842/LiteOS/assignees{/user}","branches_url":"https://api.github.com/repos/l00438842/LiteOS/branches{/branch}","tags_url":"https://api.github.com/repos/l00438842/LiteOS/tags","blobs_url":"https://api.github.com/repos/l00438842/LiteOS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/l00438842/LiteOS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/l00438842/LiteOS/git/refs{/sha}","trees_url":"https://api.github.com/repos/l00438842/LiteOS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/l00438842/LiteOS/statuses/{sha}","languages_url":"https://api.github.com/repos/l00438842/LiteOS/languages","stargazers_url":"https://api.github.com/repos/l00438842/LiteOS/stargazers","contributors_url":"https://api.github.com/repos/l00438842/LiteOS/contributors","subscribers_url":"https://api.github.com/repos/l00438842/LiteOS/subscribers","subscription_url":"https://api.github.com/repos/l00438842/LiteOS/subscription","commits_url":"https://api.github.com/repos/l00438842/LiteOS/commits{/sha}","git_commits_url":"https://api.github.com/repos/l00438842/LiteOS/git/commits{/sha}","comments_url":"https://api.github.com/repos/l00438842/LiteOS/comments{/number}","issue_comment_url":"https://api.github.com/repos/l00438842/LiteOS/issues/comments{/number}","contents_url":"https://api.github.com/repos/l00438842/LiteOS/contents/{+path}","compare_url":"https://api.github.com/repos/l00438842/LiteOS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/l00438842/LiteOS/merges","archive_url":"https://api.github.com/repos/l00438842/LiteOS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/l00438842/LiteOS/downloads","issues_url":"https://api.github.com/repos/l00438842/LiteOS/issues{/number}","pulls_url":"https://api.github.com/repos/l00438842/LiteOS/pulls{/number}","milestones_url":"https://api.github.com/repos/l00438842/LiteOS/milestones{/number}","notifications_url":"https://api.github.com/repos/l00438842/LiteOS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/l00438842/LiteOS/labels{/name}","releases_url":"https://api.github.com/repos/l00438842/LiteOS/releases{/id}","deployments_url":"https://api.github.com/repos/l00438842/LiteOS/deployments","created_at":"2018-05-18T02:57:26Z","updated_at":"2018-05-18T02:57:37Z","pushed_at":"2018-06-01T08:09:37Z","git_url":"git://github.com/l00438842/LiteOS.git","ssh_url":"[email protected]:l00438842/LiteOS.git","clone_url":"https://github.com/l00438842/LiteOS.git","svn_url":"https://github.com/l00438842/LiteOS","homepage":null,"size":149713,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"LiteOS:develop","ref":"develop","sha":"272b8c73cb584c5c098f145bcf73c0fcad81ff20","user":{"login":"LiteOS","id":22132015,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMTMyMDE1","avatar_url":"https://avatars1.githubusercontent.com/u/22132015?v=4","gravatar_id":"","url":"https://api.github.com/users/LiteOS","html_url":"https://github.com/LiteOS","followers_url":"https://api.github.com/users/LiteOS/followers","following_url":"https://api.github.com/users/LiteOS/following{/other_user}","gists_url":"https://api.github.com/users/LiteOS/gists{/gist_id}","starred_url":"https://api.github.com/users/LiteOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LiteOS/subscriptions","organizations_url":"https://api.github.com/users/LiteOS/orgs","repos_url":"https://api.github.com/users/LiteOS/repos","events_url":"https://api.github.com/users/LiteOS/events{/privacy}","received_events_url":"https://api.github.com/users/LiteOS/received_events","type":"Organization","site_admin":false},"repo":{"id":67934190,"node_id":"MDEwOlJlcG9zaXRvcnk2NzkzNDE5MA==","name":"LiteOS","full_name":"LiteOS/LiteOS","owner":{"login":"LiteOS","id":22132015,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMTMyMDE1","avatar_url":"https://avatars1.githubusercontent.com/u/22132015?v=4","gravatar_id":"","url":"https://api.github.com/users/LiteOS","html_url":"https://github.com/LiteOS","followers_url":"https://api.github.com/users/LiteOS/followers","following_url":"https://api.github.com/users/LiteOS/following{/other_user}","gists_url":"https://api.github.com/users/LiteOS/gists{/gist_id}","starred_url":"https://api.github.com/users/LiteOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LiteOS/subscriptions","organizations_url":"https://api.github.com/users/LiteOS/orgs","repos_url":"https://api.github.com/users/LiteOS/repos","events_url":"https://api.github.com/users/LiteOS/events{/privacy}","received_events_url":"https://api.github.com/users/LiteOS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/LiteOS/LiteOS","description":"code and manual","fork":false,"url":"https://api.github.com/repos/LiteOS/LiteOS","forks_url":"https://api.github.com/repos/LiteOS/LiteOS/forks","keys_url":"https://api.github.com/repos/LiteOS/LiteOS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LiteOS/LiteOS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LiteOS/LiteOS/teams","hooks_url":"https://api.github.com/repos/LiteOS/LiteOS/hooks","issue_events_url":"https://api.github.com/repos/LiteOS/LiteOS/issues/events{/number}","events_url":"https://api.github.com/repos/LiteOS/LiteOS/events","assignees_url":"https://api.github.com/repos/LiteOS/LiteOS/assignees{/user}","branches_url":"https://api.github.com/repos/LiteOS/LiteOS/branches{/branch}","tags_url":"https://api.github.com/repos/LiteOS/LiteOS/tags","blobs_url":"https://api.github.com/repos/LiteOS/LiteOS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LiteOS/LiteOS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LiteOS/LiteOS/git/refs{/sha}","trees_url":"https://api.github.com/repos/LiteOS/LiteOS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LiteOS/LiteOS/statuses/{sha}","languages_url":"https://api.github.com/repos/LiteOS/LiteOS/languages","stargazers_url":"https://api.github.com/repos/LiteOS/LiteOS/stargazers","contributors_url":"https://api.github.com/repos/LiteOS/LiteOS/contributors","subscribers_url":"https://api.github.com/repos/LiteOS/LiteOS/subscribers","subscription_url":"https://api.github.com/repos/LiteOS/LiteOS/subscription","commits_url":"https://api.github.com/repos/LiteOS/LiteOS/commits{/sha}","git_commits_url":"https://api.github.com/repos/LiteOS/LiteOS/git/commits{/sha}","comments_url":"https://api.github.com/repos/LiteOS/LiteOS/comments{/number}","issue_comment_url":"https://api.github.com/repos/LiteOS/LiteOS/issues/comments{/number}","contents_url":"https://api.github.com/repos/LiteOS/LiteOS/contents/{+path}","compare_url":"https://api.github.com/repos/LiteOS/LiteOS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LiteOS/LiteOS/merges","archive_url":"https://api.github.com/repos/LiteOS/LiteOS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LiteOS/LiteOS/downloads","issues_url":"https://api.github.com/repos/LiteOS/LiteOS/issues{/number}","pulls_url":"https://api.github.com/repos/LiteOS/LiteOS/pulls{/number}","milestones_url":"https://api.github.com/repos/LiteOS/LiteOS/milestones{/number}","notifications_url":"https://api.github.com/repos/LiteOS/LiteOS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LiteOS/LiteOS/labels{/name}","releases_url":"https://api.github.com/repos/LiteOS/LiteOS/releases{/id}","deployments_url":"https://api.github.com/repos/LiteOS/LiteOS/deployments","created_at":"2016-09-11T14:25:51Z","updated_at":"2018-06-02T10:36:21Z","pushed_at":"2018-06-03T15:12:01Z","git_url":"git://github.com/LiteOS/LiteOS.git","ssh_url":"[email protected]:LiteOS/LiteOS.git","clone_url":"https://github.com/LiteOS/LiteOS.git","svn_url":"https://github.com/LiteOS/LiteOS","homepage":null,"size":149557,"stargazers_count":626,"watchers_count":626,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":390,"mirror_url":null,"archived":false,"open_issues_count":18,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":390,"open_issues":18,"watchers":626,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/LiteOS/LiteOS/pulls/180"},"html":{"href":"https://github.com/LiteOS/LiteOS/pull/180"},"issue":{"href":"https://api.github.com/repos/LiteOS/LiteOS/issues/180"},"comments":{"href":"https://api.github.com/repos/LiteOS/LiteOS/issues/180/comments"},"review_comments":{"href":"https://api.github.com/repos/LiteOS/LiteOS/pulls/180/comments"},"review_comment":{"href":"https://api.github.com/repos/LiteOS/LiteOS/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/LiteOS/LiteOS/pulls/180/commits"},"statuses":{"href":"https://api.github.com/repos/LiteOS/LiteOS/statuses/d5a3d5019da1bcf36896913a3c106e4d2f8172d7"}},"author_association":"NONE"}} | {
"id": 67934190,
"name": "LiteOS/LiteOS",
"url": "https://api.github.com/repos/LiteOS/LiteOS"
} | {
"id": 30918679,
"login": "IOTBaicheng",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/30918679?",
"url": "https://api.github.com/users/IOTBaicheng"
} | {
"id": 22132015,
"login": "LiteOS",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/22132015?",
"url": "https://api.github.com/orgs/LiteOS"
} | 2018-06-04T07:21:13 | 7770056054 | {"actor":{"display_login":"IOTBaicheng"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/pyinduct/pyinduct/pulls/comments/236765641","pull_request_review_id":178909744,"id":236765641,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNjc2NTY0MQ==","diff_hunk":"@@ -522,8 +531,23 @@ class Base:\n Args:\n fractions (iterable of :py:class:`.BaseFraction`): List, array or\n dict of :py:class:`.BaseFraction`'s\n+ matching_bases (list of str): List of labels from exactly matching\n+ bases, for which no transformation is necessary.\n+ Useful for transformations from bases the 'live' in\n+ different function spaces but evolve with the same time\n+ dynamic/coefficients (e.g. modal bases).\n+ intermediate_base (str): If it is ceratain that this base instance will\n+ be asked (as destination base) to return a transformation\n+ to a source base, whose implementation is cumbersome,\n+ its label can be provided here. This will trigger the generation\n+ of the transformation using build-in features.\n+ The algorithm, implemented in :py:class:`.get_weights_transformation`\n+ is then called again with the intermediate base as destination\n+ base and the 'old' source base. With this technique arbitrary\n+ long transformation chains are possible, if the provided\n+ intermediate bases again define intermediate bases.\n \"\"\"\n- def __init__(self, fractions):\n+ def __init__(self, fractions, matching_bases=list(), intermediate_base=None):","path":"pyinduct/core.py","position":null,"original_position":64,"commit_id":"d8fb52c85b467dbd1cdec1015d4c9f45d505a49c","original_commit_id":"90210b79c8a1d04bc92665ba0bd342295fc46404","user":{"login":"riemarc","id":18379817,"node_id":"MDQ6VXNlcjE4Mzc5ODE3","avatar_url":"https://avatars1.githubusercontent.com/u/18379817?v=4","gravatar_id":"","url":"https://api.github.com/users/riemarc","html_url":"https://github.com/riemarc","followers_url":"https://api.github.com/users/riemarc/followers","following_url":"https://api.github.com/users/riemarc/following{/other_user}","gists_url":"https://api.github.com/users/riemarc/gists{/gist_id}","starred_url":"https://api.github.com/users/riemarc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/riemarc/subscriptions","organizations_url":"https://api.github.com/users/riemarc/orgs","repos_url":"https://api.github.com/users/riemarc/repos","events_url":"https://api.github.com/users/riemarc/events{/privacy}","received_events_url":"https://api.github.com/users/riemarc/received_events","type":"User","site_admin":false},"body":"yes `matching_bases=tuple()` is the better idea","created_at":"2018-11-27T17:21:04Z","updated_at":"2018-11-27T17:21:04Z","html_url":"https://github.com/pyinduct/pyinduct/pull/36#discussion_r236765641","pull_request_url":"https://api.github.com/repos/pyinduct/pyinduct/pulls/36","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/pyinduct/pyinduct/pulls/comments/236765641"},"html":{"href":"https://github.com/pyinduct/pyinduct/pull/36#discussion_r236765641"},"pull_request":{"href":"https://api.github.com/repos/pyinduct/pyinduct/pulls/36"}},"in_reply_to_id":236742497},"pull_request":{"url":"https://api.github.com/repos/pyinduct/pyinduct/pulls/36","id":147054158,"node_id":"MDExOlB1bGxSZXF1ZXN0MTQ3MDU0MTU4","html_url":"https://github.com/pyinduct/pyinduct/pull/36","diff_url":"https://github.com/pyinduct/pyinduct/pull/36.diff","patch_url":"https://github.com/pyinduct/pyinduct/pull/36.patch","issue_url":"https://api.github.com/repos/pyinduct/pyinduct/issues/36","number":36,"state":"open","locked":false,"title":"Built-in \"transform from stacked base\" feature","user":{"login":"riemarc","id":18379817,"node_id":"MDQ6VXNlcjE4Mzc5ODE3","avatar_url":"https://avatars1.githubusercontent.com/u/18379817?v=4","gravatar_id":"","url":"https://api.github.com/users/riemarc","html_url":"https://github.com/riemarc","followers_url":"https://api.github.com/users/riemarc/followers","following_url":"https://api.github.com/users/riemarc/following{/other_user}","gists_url":"https://api.github.com/users/riemarc/gists{/gist_id}","starred_url":"https://api.github.com/users/riemarc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/riemarc/subscriptions","organizations_url":"https://api.github.com/users/riemarc/orgs","repos_url":"https://api.github.com/users/riemarc/repos","events_url":"https://api.github.com/users/riemarc/events{/privacy}","received_events_url":"https://api.github.com/users/riemarc/received_events","type":"User","site_admin":false},"body":"This pr is a part of pr #93.","created_at":"2017-10-17T14:24:14Z","updated_at":"2018-11-27T17:21:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4c116bfdc51abc314b1655e17e3104f9905bacd2","assignee":{"login":"riemarc","id":18379817,"node_id":"MDQ6VXNlcjE4Mzc5ODE3","avatar_url":"https://avatars1.githubusercontent.com/u/18379817?v=4","gravatar_id":"","url":"https://api.github.com/users/riemarc","html_url":"https://github.com/riemarc","followers_url":"https://api.github.com/users/riemarc/followers","following_url":"https://api.github.com/users/riemarc/following{/other_user}","gists_url":"https://api.github.com/users/riemarc/gists{/gist_id}","starred_url":"https://api.github.com/users/riemarc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/riemarc/subscriptions","organizations_url":"https://api.github.com/users/riemarc/orgs","repos_url":"https://api.github.com/users/riemarc/repos","events_url":"https://api.github.com/users/riemarc/events{/privacy}","received_events_url":"https://api.github.com/users/riemarc/received_events","type":"User","site_admin":false},"assignees":[{"login":"riemarc","id":18379817,"node_id":"MDQ6VXNlcjE4Mzc5ODE3","avatar_url":"https://avatars1.githubusercontent.com/u/18379817?v=4","gravatar_id":"","url":"https://api.github.com/users/riemarc","html_url":"https://github.com/riemarc","followers_url":"https://api.github.com/users/riemarc/followers","following_url":"https://api.github.com/users/riemarc/following{/other_user}","gists_url":"https://api.github.com/users/riemarc/gists{/gist_id}","starred_url":"https://api.github.com/users/riemarc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/riemarc/subscriptions","organizations_url":"https://api.github.com/users/riemarc/orgs","repos_url":"https://api.github.com/users/riemarc/repos","events_url":"https://api.github.com/users/riemarc/events{/privacy}","received_events_url":"https://api.github.com/users/riemarc/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":308536754,"node_id":"MDU6TGFiZWwzMDg1MzY3NTQ=","url":"https://api.github.com/repos/pyinduct/pyinduct/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/pyinduct/pyinduct/pulls/36/commits","review_comments_url":"https://api.github.com/repos/pyinduct/pyinduct/pulls/36/comments","review_comment_url":"https://api.github.com/repos/pyinduct/pyinduct/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pyinduct/pyinduct/issues/36/comments","statuses_url":"https://api.github.com/repos/pyinduct/pyinduct/statuses/d8fb52c85b467dbd1cdec1015d4c9f45d505a49c","head":{"label":"riemarc:feature-transform_from_stacked_base","ref":"feature-transform_from_stacked_base","sha":"d8fb52c85b467dbd1cdec1015d4c9f45d505a49c","user":{"login":"riemarc","id":18379817,"node_id":"MDQ6VXNlcjE4Mzc5ODE3","avatar_url":"https://avatars1.githubusercontent.com/u/18379817?v=4","gravatar_id":"","url":"https://api.github.com/users/riemarc","html_url":"https://github.com/riemarc","followers_url":"https://api.github.com/users/riemarc/followers","following_url":"https://api.github.com/users/riemarc/following{/other_user}","gists_url":"https://api.github.com/users/riemarc/gists{/gist_id}","starred_url":"https://api.github.com/users/riemarc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/riemarc/subscriptions","organizations_url":"https://api.github.com/users/riemarc/orgs","repos_url":"https://api.github.com/users/riemarc/repos","events_url":"https://api.github.com/users/riemarc/events{/privacy}","received_events_url":"https://api.github.com/users/riemarc/received_events","type":"User","site_admin":false},"repo":{"id":58375402,"node_id":"MDEwOlJlcG9zaXRvcnk1ODM3NTQwMg==","name":"pyinduct","full_name":"riemarc/pyinduct","private":false,"owner":{"login":"riemarc","id":18379817,"node_id":"MDQ6VXNlcjE4Mzc5ODE3","avatar_url":"https://avatars1.githubusercontent.com/u/18379817?v=4","gravatar_id":"","url":"https://api.github.com/users/riemarc","html_url":"https://github.com/riemarc","followers_url":"https://api.github.com/users/riemarc/followers","following_url":"https://api.github.com/users/riemarc/following{/other_user}","gists_url":"https://api.github.com/users/riemarc/gists{/gist_id}","starred_url":"https://api.github.com/users/riemarc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/riemarc/subscriptions","organizations_url":"https://api.github.com/users/riemarc/orgs","repos_url":"https://api.github.com/users/riemarc/repos","events_url":"https://api.github.com/users/riemarc/events{/privacy}","received_events_url":"https://api.github.com/users/riemarc/received_events","type":"User","site_admin":false},"html_url":"https://github.com/riemarc/pyinduct","description":"Python based toolbox for infinite dimensional boundary controlled systems","fork":true,"url":"https://api.github.com/repos/riemarc/pyinduct","forks_url":"https://api.github.com/repos/riemarc/pyinduct/forks","keys_url":"https://api.github.com/repos/riemarc/pyinduct/keys{/key_id}","collaborators_url":"https://api.github.com/repos/riemarc/pyinduct/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/riemarc/pyinduct/teams","hooks_url":"https://api.github.com/repos/riemarc/pyinduct/hooks","issue_events_url":"https://api.github.com/repos/riemarc/pyinduct/issues/events{/number}","events_url":"https://api.github.com/repos/riemarc/pyinduct/events","assignees_url":"https://api.github.com/repos/riemarc/pyinduct/assignees{/user}","branches_url":"https://api.github.com/repos/riemarc/pyinduct/branches{/branch}","tags_url":"https://api.github.com/repos/riemarc/pyinduct/tags","blobs_url":"https://api.github.com/repos/riemarc/pyinduct/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/riemarc/pyinduct/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/riemarc/pyinduct/git/refs{/sha}","trees_url":"https://api.github.com/repos/riemarc/pyinduct/git/trees{/sha}","statuses_url":"https://api.github.com/repos/riemarc/pyinduct/statuses/{sha}","languages_url":"https://api.github.com/repos/riemarc/pyinduct/languages","stargazers_url":"https://api.github.com/repos/riemarc/pyinduct/stargazers","contributors_url":"https://api.github.com/repos/riemarc/pyinduct/contributors","subscribers_url":"https://api.github.com/repos/riemarc/pyinduct/subscribers","subscription_url":"https://api.github.com/repos/riemarc/pyinduct/subscription","commits_url":"https://api.github.com/repos/riemarc/pyinduct/commits{/sha}","git_commits_url":"https://api.github.com/repos/riemarc/pyinduct/git/commits{/sha}","comments_url":"https://api.github.com/repos/riemarc/pyinduct/comments{/number}","issue_comment_url":"https://api.github.com/repos/riemarc/pyinduct/issues/comments{/number}","contents_url":"https://api.github.com/repos/riemarc/pyinduct/contents/{+path}","compare_url":"https://api.github.com/repos/riemarc/pyinduct/compare/{base}...{head}","merges_url":"https://api.github.com/repos/riemarc/pyinduct/merges","archive_url":"https://api.github.com/repos/riemarc/pyinduct/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/riemarc/pyinduct/downloads","issues_url":"https://api.github.com/repos/riemarc/pyinduct/issues{/number}","pulls_url":"https://api.github.com/repos/riemarc/pyinduct/pulls{/number}","milestones_url":"https://api.github.com/repos/riemarc/pyinduct/milestones{/number}","notifications_url":"https://api.github.com/repos/riemarc/pyinduct/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/riemarc/pyinduct/labels{/name}","releases_url":"https://api.github.com/repos/riemarc/pyinduct/releases{/id}","deployments_url":"https://api.github.com/repos/riemarc/pyinduct/deployments","created_at":"2016-05-09T12:39:26Z","updated_at":"2018-11-23T17:34:33Z","pushed_at":"2018-11-27T17:05:11Z","git_url":"git://github.com/riemarc/pyinduct.git","ssh_url":"[email protected]:riemarc/pyinduct.git","clone_url":"https://github.com/riemarc/pyinduct.git","svn_url":"https://github.com/riemarc/pyinduct","homepage":null,"size":6432,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"pyinduct:develop","ref":"develop","sha":"8ce29e2b029e1dffd3300e27be0963b38b06c577","user":{"login":"pyinduct","id":22238507,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMjM4NTA3","avatar_url":"https://avatars0.githubusercontent.com/u/22238507?v=4","gravatar_id":"","url":"https://api.github.com/users/pyinduct","html_url":"https://github.com/pyinduct","followers_url":"https://api.github.com/users/pyinduct/followers","following_url":"https://api.github.com/users/pyinduct/following{/other_user}","gists_url":"https://api.github.com/users/pyinduct/gists{/gist_id}","starred_url":"https://api.github.com/users/pyinduct/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pyinduct/subscriptions","organizations_url":"https://api.github.com/users/pyinduct/orgs","repos_url":"https://api.github.com/users/pyinduct/repos","events_url":"https://api.github.com/users/pyinduct/events{/privacy}","received_events_url":"https://api.github.com/users/pyinduct/received_events","type":"Organization","site_admin":false},"repo":{"id":49257835,"node_id":"MDEwOlJlcG9zaXRvcnk0OTI1NzgzNQ==","name":"pyinduct","full_name":"pyinduct/pyinduct","private":false,"owner":{"login":"pyinduct","id":22238507,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMjM4NTA3","avatar_url":"https://avatars0.githubusercontent.com/u/22238507?v=4","gravatar_id":"","url":"https://api.github.com/users/pyinduct","html_url":"https://github.com/pyinduct","followers_url":"https://api.github.com/users/pyinduct/followers","following_url":"https://api.github.com/users/pyinduct/following{/other_user}","gists_url":"https://api.github.com/users/pyinduct/gists{/gist_id}","starred_url":"https://api.github.com/users/pyinduct/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pyinduct/subscriptions","organizations_url":"https://api.github.com/users/pyinduct/orgs","repos_url":"https://api.github.com/users/pyinduct/repos","events_url":"https://api.github.com/users/pyinduct/events{/privacy}","received_events_url":"https://api.github.com/users/pyinduct/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/pyinduct/pyinduct","description":"Python based toolbox for infinite dimensional boundary controlled systems","fork":false,"url":"https://api.github.com/repos/pyinduct/pyinduct","forks_url":"https://api.github.com/repos/pyinduct/pyinduct/forks","keys_url":"https://api.github.com/repos/pyinduct/pyinduct/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pyinduct/pyinduct/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pyinduct/pyinduct/teams","hooks_url":"https://api.github.com/repos/pyinduct/pyinduct/hooks","issue_events_url":"https://api.github.com/repos/pyinduct/pyinduct/issues/events{/number}","events_url":"https://api.github.com/repos/pyinduct/pyinduct/events","assignees_url":"https://api.github.com/repos/pyinduct/pyinduct/assignees{/user}","branches_url":"https://api.github.com/repos/pyinduct/pyinduct/branches{/branch}","tags_url":"https://api.github.com/repos/pyinduct/pyinduct/tags","blobs_url":"https://api.github.com/repos/pyinduct/pyinduct/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pyinduct/pyinduct/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pyinduct/pyinduct/git/refs{/sha}","trees_url":"https://api.github.com/repos/pyinduct/pyinduct/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pyinduct/pyinduct/statuses/{sha}","languages_url":"https://api.github.com/repos/pyinduct/pyinduct/languages","stargazers_url":"https://api.github.com/repos/pyinduct/pyinduct/stargazers","contributors_url":"https://api.github.com/repos/pyinduct/pyinduct/contributors","subscribers_url":"https://api.github.com/repos/pyinduct/pyinduct/subscribers","subscription_url":"https://api.github.com/repos/pyinduct/pyinduct/subscription","commits_url":"https://api.github.com/repos/pyinduct/pyinduct/commits{/sha}","git_commits_url":"https://api.github.com/repos/pyinduct/pyinduct/git/commits{/sha}","comments_url":"https://api.github.com/repos/pyinduct/pyinduct/comments{/number}","issue_comment_url":"https://api.github.com/repos/pyinduct/pyinduct/issues/comments{/number}","contents_url":"https://api.github.com/repos/pyinduct/pyinduct/contents/{+path}","compare_url":"https://api.github.com/repos/pyinduct/pyinduct/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pyinduct/pyinduct/merges","archive_url":"https://api.github.com/repos/pyinduct/pyinduct/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pyinduct/pyinduct/downloads","issues_url":"https://api.github.com/repos/pyinduct/pyinduct/issues{/number}","pulls_url":"https://api.github.com/repos/pyinduct/pyinduct/pulls{/number}","milestones_url":"https://api.github.com/repos/pyinduct/pyinduct/milestones{/number}","notifications_url":"https://api.github.com/repos/pyinduct/pyinduct/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pyinduct/pyinduct/labels{/name}","releases_url":"https://api.github.com/repos/pyinduct/pyinduct/releases{/id}","deployments_url":"https://api.github.com/repos/pyinduct/pyinduct/deployments","created_at":"2016-01-08T07:46:55Z","updated_at":"2018-11-24T00:25:42Z","pushed_at":"2018-11-27T17:05:14Z","git_url":"git://github.com/pyinduct/pyinduct.git","ssh_url":"[email protected]:pyinduct/pyinduct.git","clone_url":"https://github.com/pyinduct/pyinduct.git","svn_url":"https://github.com/pyinduct/pyinduct","homepage":null,"size":6036,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":31,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":8,"open_issues":31,"watchers":1,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/pyinduct/pyinduct/pulls/36"},"html":{"href":"https://github.com/pyinduct/pyinduct/pull/36"},"issue":{"href":"https://api.github.com/repos/pyinduct/pyinduct/issues/36"},"comments":{"href":"https://api.github.com/repos/pyinduct/pyinduct/issues/36/comments"},"review_comments":{"href":"https://api.github.com/repos/pyinduct/pyinduct/pulls/36/comments"},"review_comment":{"href":"https://api.github.com/repos/pyinduct/pyinduct/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pyinduct/pyinduct/pulls/36/commits"},"statuses":{"href":"https://api.github.com/repos/pyinduct/pyinduct/statuses/d8fb52c85b467dbd1cdec1015d4c9f45d505a49c"}},"author_association":"CONTRIBUTOR"}} | {
"id": 49257835,
"name": "pyinduct/pyinduct",
"url": "https://api.github.com/repos/pyinduct/pyinduct"
} | {
"id": 18379817,
"login": "riemarc",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/18379817?",
"url": "https://api.github.com/users/riemarc"
} | {
"id": 22238507,
"login": "pyinduct",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/22238507?",
"url": "https://api.github.com/orgs/pyinduct"
} | 2018-11-27T17:21:04 | 8656039113 | {"actor":{"display_login":"riemarc"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/Sygic/sygic-maps-kit-ios/pulls/comments/236958203","pull_request_review_id":179143849,"id":236958203,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNjk1ODIwMw==","diff_hunk":"@@ -71,6 +73,24 @@ public class SYMKBrowseMapViewController: UIViewController {\n mapView.addMapMarkersCluster(mapSelectionManager.clusterLayer!)\n }\n \n+ // MARK: - PoiDetail\n+ \n+ private func showPoiDetail(with poiDetailViewModel: SYMKPoiDetailDataSource) {","path":"SygicMapsKit/Classes/BrowseMap/SYMKBrowseMapViewController.swift","position":15,"original_position":15,"commit_id":"332e1ab81e30425201945d4adcf09544b23cd0e7","original_commit_id":"332e1ab81e30425201945d4adcf09544b23cd0e7","user":{"login":"marekdovjak","id":16473083,"node_id":"MDQ6VXNlcjE2NDczMDgz","avatar_url":"https://avatars1.githubusercontent.com/u/16473083?v=4","gravatar_id":"","url":"https://api.github.com/users/marekdovjak","html_url":"https://github.com/marekdovjak","followers_url":"https://api.github.com/users/marekdovjak/followers","following_url":"https://api.github.com/users/marekdovjak/following{/other_user}","gists_url":"https://api.github.com/users/marekdovjak/gists{/gist_id}","starred_url":"https://api.github.com/users/marekdovjak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marekdovjak/subscriptions","organizations_url":"https://api.github.com/users/marekdovjak/orgs","repos_url":"https://api.github.com/users/marekdovjak/repos","events_url":"https://api.github.com/users/marekdovjak/events{/privacy}","received_events_url":"https://api.github.com/users/marekdovjak/received_events","type":"User","site_admin":false},"body":"to meno viewModel by som nahradil niecim inym","created_at":"2018-11-28T06:57:20Z","updated_at":"2018-11-28T06:57:21Z","html_url":"https://github.com/Sygic/sygic-maps-kit-ios/pull/3#discussion_r236958203","pull_request_url":"https://api.github.com/repos/Sygic/sygic-maps-kit-ios/pulls/3","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/Sygic/sygic-maps-kit-ios/pulls/comments/236958203"},"html":{"href":"https://github.com/Sygic/sygic-maps-kit-ios/pull/3#discussion_r236958203"},"pull_request":{"href":"https://api.github.com/repos/Sygic/sygic-maps-kit-ios/pulls/3"}}},"pull_request":{"url":"https://api.github.com/repos/Sygic/sygic-maps-kit-ios/pulls/3","id":233929190,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzOTI5MTkw","html_url":"https://github.com/Sygic/sygic-maps-kit-ios/pull/3","diff_url":"https://github.com/Sygic/sygic-maps-kit-ios/pull/3.diff","patch_url":"https://github.com/Sygic/sygic-maps-kit-ios/pull/3.patch","issue_url":"https://api.github.com/repos/Sygic/sygic-maps-kit-ios/issues/3","number":3,"state":"open","locked":false,"title":"Feature/poi detail","user":{"login":"jcaliksygic","id":30600531,"node_id":"MDQ6VXNlcjMwNjAwNTMx","avatar_url":"https://avatars2.githubusercontent.com/u/30600531?v=4","gravatar_id":"","url":"https://api.github.com/users/jcaliksygic","html_url":"https://github.com/jcaliksygic","followers_url":"https://api.github.com/users/jcaliksygic/followers","following_url":"https://api.github.com/users/jcaliksygic/following{/other_user}","gists_url":"https://api.github.com/users/jcaliksygic/gists{/gist_id}","starred_url":"https://api.github.com/users/jcaliksygic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcaliksygic/subscriptions","organizations_url":"https://api.github.com/users/jcaliksygic/orgs","repos_url":"https://api.github.com/users/jcaliksygic/repos","events_url":"https://api.github.com/users/jcaliksygic/events{/privacy}","received_events_url":"https://api.github.com/users/jcaliksygic/received_events","type":"User","site_admin":false},"body":"poiDetail brencha, rovno to davam do mvc brenche","created_at":"2018-11-27T14:23:14Z","updated_at":"2018-11-28T06:57:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5a7b618891053057ca0caa2b887bd81ae7bb1504","assignee":null,"assignees":[],"requested_reviewers":[{"login":"Kraci","id":7466614,"node_id":"MDQ6VXNlcjc0NjY2MTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/7466614?v=4","gravatar_id":"","url":"https://api.github.com/users/Kraci","html_url":"https://github.com/Kraci","followers_url":"https://api.github.com/users/Kraci/followers","following_url":"https://api.github.com/users/Kraci/following{/other_user}","gists_url":"https://api.github.com/users/Kraci/gists{/gist_id}","starred_url":"https://api.github.com/users/Kraci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kraci/subscriptions","organizations_url":"https://api.github.com/users/Kraci/orgs","repos_url":"https://api.github.com/users/Kraci/repos","events_url":"https://api.github.com/users/Kraci/events{/privacy}","received_events_url":"https://api.github.com/users/Kraci/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Sygic/sygic-maps-kit-ios/pulls/3/commits","review_comments_url":"https://api.github.com/repos/Sygic/sygic-maps-kit-ios/pulls/3/comments","review_comment_url":"https://api.github.com/repos/Sygic/sygic-maps-kit-ios/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Sygic/sygic-maps-kit-ios/issues/3/comments","statuses_url":"https://api.github.com/repos/Sygic/sygic-maps-kit-ios/statuses/332e1ab81e30425201945d4adcf09544b23cd0e7","head":{"label":"Sygic:feature/poi_detail","ref":"feature/poi_detail","sha":"332e1ab81e30425201945d4adcf09544b23cd0e7","user":{"login":"Sygic","id":22239860,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMjM5ODYw","avatar_url":"https://avatars3.githubusercontent.com/u/22239860?v=4","gravatar_id":"","url":"https://api.github.com/users/Sygic","html_url":"https://github.com/Sygic","followers_url":"https://api.github.com/users/Sygic/followers","following_url":"https://api.github.com/users/Sygic/following{/other_user}","gists_url":"https://api.github.com/users/Sygic/gists{/gist_id}","starred_url":"https://api.github.com/users/Sygic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sygic/subscriptions","organizations_url":"https://api.github.com/users/Sygic/orgs","repos_url":"https://api.github.com/users/Sygic/repos","events_url":"https://api.github.com/users/Sygic/events{/privacy}","received_events_url":"https://api.github.com/users/Sygic/received_events","type":"Organization","site_admin":false},"repo":{"id":156542589,"node_id":"MDEwOlJlcG9zaXRvcnkxNTY1NDI1ODk=","name":"sygic-maps-kit-ios","full_name":"Sygic/sygic-maps-kit-ios","private":false,"owner":{"login":"Sygic","id":22239860,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMjM5ODYw","avatar_url":"https://avatars3.githubusercontent.com/u/22239860?v=4","gravatar_id":"","url":"https://api.github.com/users/Sygic","html_url":"https://github.com/Sygic","followers_url":"https://api.github.com/users/Sygic/followers","following_url":"https://api.github.com/users/Sygic/following{/other_user}","gists_url":"https://api.github.com/users/Sygic/gists{/gist_id}","starred_url":"https://api.github.com/users/Sygic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sygic/subscriptions","organizations_url":"https://api.github.com/users/Sygic/orgs","repos_url":"https://api.github.com/users/Sygic/repos","events_url":"https://api.github.com/users/Sygic/events{/privacy}","received_events_url":"https://api.github.com/users/Sygic/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Sygic/sygic-maps-kit-ios","description":null,"fork":false,"url":"https://api.github.com/repos/Sygic/sygic-maps-kit-ios","forks_url":"https://api.github.com/repos/Sygic/sygic-maps-kit-ios/forks","keys_url":"https://api.github.com/repos/Sygic/sygic-maps-kit-ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Sygic/sygic-maps-kit-ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Sygic/sygic-maps-kit-ios/teams","hooks_url":"https://api.github.com/repos/Sygic/sygic-maps-kit-ios/hooks","issue_events_url":"https://api.github.com/repos/Sygic/sygic-maps-kit-ios/issues/events{/number}","events_url":"https://api.github.com/repos/Sygic/sygic-maps-kit-ios/events","assignees_url":"https://api.github.com/repos/Sygic/sygic-maps-kit-ios/assignees{/user}","branches_url":"https://api.github.com/repos/Sygic/sygic-maps-kit-ios/branches{/branch}","tags_url":"https://api.github.com/repos/Sygic/sygic-maps-kit-ios/tags","blobs_url":"https://api.github.com/repos/Sygic/sygic-maps-kit-ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Sygic/sygic-maps-kit-ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Sygic/sygic-maps-kit-ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/Sygic/sygic-maps-kit-ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Sygic/sygic-maps-kit-ios/statuses/{sha}","languages_url":"https://api.github.com/repos/Sygic/sygic-maps-kit-ios/languages","stargazers_url":"https://api.github.com/repos/Sygic/sygic-maps-kit-ios/stargazers","contributors_url":"https://api.github.com/repos/Sygic/sygic-maps-kit-ios/contributors","subscribers_url":"https://api.github.com/repos/Sygic/sygic-maps-kit-ios/subscribers","subscription_url":"https://api.github.com/repos/Sygic/sygic-maps-kit-ios/subscription","commits_url":"https://api.github.com/repos/Sygic/sygic-maps-kit-ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/Sygic/sygic-maps-kit-ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/Sygic/sygic-maps-kit-ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/Sygic/sygic-maps-kit-ios/issues/comments{/number}","contents_url":"https://api.github.com/repos/Sygic/sygic-maps-kit-ios/contents/{+path}","compare_url":"https://api.github.com/repos/Sygic/sygic-maps-kit-ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Sygic/sygic-maps-kit-ios/merges","archive_url":"https://api.github.com/repos/Sygic/sygic-maps-kit-ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Sygic/sygic-maps-kit-ios/downloads","issues_url":"https://api.github.com/repos/Sygic/sygic-maps-kit-ios/issues{/number}","pulls_url":"https://api.github.com/repos/Sygic/sygic-maps-kit-ios/pulls{/number}","milestones_url":"https://api.github.com/repos/Sygic/sygic-maps-kit-ios/milestones{/number}","notifications_url":"https://api.github.com/repos/Sygic/sygic-maps-kit-ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Sygic/sygic-maps-kit-ios/labels{/name}","releases_url":"https://api.github.com/repos/Sygic/sygic-maps-kit-ios/releases{/id}","deployments_url":"https://api.github.com/repos/Sygic/sygic-maps-kit-ios/deployments","created_at":"2018-11-07T12:22:44Z","updated_at":"2018-11-07T12:32:44Z","pushed_at":"2018-11-27T14:23:15Z","git_url":"git://github.com/Sygic/sygic-maps-kit-ios.git","ssh_url":"[email protected]:Sygic/sygic-maps-kit-ios.git","clone_url":"https://github.com/Sygic/sygic-maps-kit-ios.git","svn_url":"https://github.com/Sygic/sygic-maps-kit-ios","homepage":null,"size":79,"stargazers_count":1,"watchers_count":1,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"Sygic:feature/mvc_switch","ref":"feature/mvc_switch","sha":"bce8f99053fff0a98209a5d87cb1b2f088b2a79a","user":{"login":"Sygic","id":22239860,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMjM5ODYw","avatar_url":"https://avatars3.githubusercontent.com/u/22239860?v=4","gravatar_id":"","url":"https://api.github.com/users/Sygic","html_url":"https://github.com/Sygic","followers_url":"https://api.github.com/users/Sygic/followers","following_url":"https://api.github.com/users/Sygic/following{/other_user}","gists_url":"https://api.github.com/users/Sygic/gists{/gist_id}","starred_url":"https://api.github.com/users/Sygic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sygic/subscriptions","organizations_url":"https://api.github.com/users/Sygic/orgs","repos_url":"https://api.github.com/users/Sygic/repos","events_url":"https://api.github.com/users/Sygic/events{/privacy}","received_events_url":"https://api.github.com/users/Sygic/received_events","type":"Organization","site_admin":false},"repo":{"id":156542589,"node_id":"MDEwOlJlcG9zaXRvcnkxNTY1NDI1ODk=","name":"sygic-maps-kit-ios","full_name":"Sygic/sygic-maps-kit-ios","private":false,"owner":{"login":"Sygic","id":22239860,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMjM5ODYw","avatar_url":"https://avatars3.githubusercontent.com/u/22239860?v=4","gravatar_id":"","url":"https://api.github.com/users/Sygic","html_url":"https://github.com/Sygic","followers_url":"https://api.github.com/users/Sygic/followers","following_url":"https://api.github.com/users/Sygic/following{/other_user}","gists_url":"https://api.github.com/users/Sygic/gists{/gist_id}","starred_url":"https://api.github.com/users/Sygic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sygic/subscriptions","organizations_url":"https://api.github.com/users/Sygic/orgs","repos_url":"https://api.github.com/users/Sygic/repos","events_url":"https://api.github.com/users/Sygic/events{/privacy}","received_events_url":"https://api.github.com/users/Sygic/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Sygic/sygic-maps-kit-ios","description":null,"fork":false,"url":"https://api.github.com/repos/Sygic/sygic-maps-kit-ios","forks_url":"https://api.github.com/repos/Sygic/sygic-maps-kit-ios/forks","keys_url":"https://api.github.com/repos/Sygic/sygic-maps-kit-ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Sygic/sygic-maps-kit-ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Sygic/sygic-maps-kit-ios/teams","hooks_url":"https://api.github.com/repos/Sygic/sygic-maps-kit-ios/hooks","issue_events_url":"https://api.github.com/repos/Sygic/sygic-maps-kit-ios/issues/events{/number}","events_url":"https://api.github.com/repos/Sygic/sygic-maps-kit-ios/events","assignees_url":"https://api.github.com/repos/Sygic/sygic-maps-kit-ios/assignees{/user}","branches_url":"https://api.github.com/repos/Sygic/sygic-maps-kit-ios/branches{/branch}","tags_url":"https://api.github.com/repos/Sygic/sygic-maps-kit-ios/tags","blobs_url":"https://api.github.com/repos/Sygic/sygic-maps-kit-ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Sygic/sygic-maps-kit-ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Sygic/sygic-maps-kit-ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/Sygic/sygic-maps-kit-ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Sygic/sygic-maps-kit-ios/statuses/{sha}","languages_url":"https://api.github.com/repos/Sygic/sygic-maps-kit-ios/languages","stargazers_url":"https://api.github.com/repos/Sygic/sygic-maps-kit-ios/stargazers","contributors_url":"https://api.github.com/repos/Sygic/sygic-maps-kit-ios/contributors","subscribers_url":"https://api.github.com/repos/Sygic/sygic-maps-kit-ios/subscribers","subscription_url":"https://api.github.com/repos/Sygic/sygic-maps-kit-ios/subscription","commits_url":"https://api.github.com/repos/Sygic/sygic-maps-kit-ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/Sygic/sygic-maps-kit-ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/Sygic/sygic-maps-kit-ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/Sygic/sygic-maps-kit-ios/issues/comments{/number}","contents_url":"https://api.github.com/repos/Sygic/sygic-maps-kit-ios/contents/{+path}","compare_url":"https://api.github.com/repos/Sygic/sygic-maps-kit-ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Sygic/sygic-maps-kit-ios/merges","archive_url":"https://api.github.com/repos/Sygic/sygic-maps-kit-ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Sygic/sygic-maps-kit-ios/downloads","issues_url":"https://api.github.com/repos/Sygic/sygic-maps-kit-ios/issues{/number}","pulls_url":"https://api.github.com/repos/Sygic/sygic-maps-kit-ios/pulls{/number}","milestones_url":"https://api.github.com/repos/Sygic/sygic-maps-kit-ios/milestones{/number}","notifications_url":"https://api.github.com/repos/Sygic/sygic-maps-kit-ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Sygic/sygic-maps-kit-ios/labels{/name}","releases_url":"https://api.github.com/repos/Sygic/sygic-maps-kit-ios/releases{/id}","deployments_url":"https://api.github.com/repos/Sygic/sygic-maps-kit-ios/deployments","created_at":"2018-11-07T12:22:44Z","updated_at":"2018-11-07T12:32:44Z","pushed_at":"2018-11-27T14:23:15Z","git_url":"git://github.com/Sygic/sygic-maps-kit-ios.git","ssh_url":"[email protected]:Sygic/sygic-maps-kit-ios.git","clone_url":"https://github.com/Sygic/sygic-maps-kit-ios.git","svn_url":"https://github.com/Sygic/sygic-maps-kit-ios","homepage":null,"size":79,"stargazers_count":1,"watchers_count":1,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Sygic/sygic-maps-kit-ios/pulls/3"},"html":{"href":"https://github.com/Sygic/sygic-maps-kit-ios/pull/3"},"issue":{"href":"https://api.github.com/repos/Sygic/sygic-maps-kit-ios/issues/3"},"comments":{"href":"https://api.github.com/repos/Sygic/sygic-maps-kit-ios/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/Sygic/sygic-maps-kit-ios/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/Sygic/sygic-maps-kit-ios/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Sygic/sygic-maps-kit-ios/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/Sygic/sygic-maps-kit-ios/statuses/332e1ab81e30425201945d4adcf09544b23cd0e7"}},"author_association":"CONTRIBUTOR"}} | {
"id": 156542589,
"name": "Sygic/sygic-maps-kit-ios",
"url": "https://api.github.com/repos/Sygic/sygic-maps-kit-ios"
} | {
"id": 16473083,
"login": "marekdovjak",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/16473083?",
"url": "https://api.github.com/users/marekdovjak"
} | {
"id": 22239860,
"login": "Sygic",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/22239860?",
"url": "https://api.github.com/orgs/Sygic"
} | 2018-11-28T06:57:20 | 8659624944 | {"actor":{"display_login":"marekdovjak"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/our-city-app/oca-backend/pulls/comments/228863612","pull_request_review_id":169223754,"id":228863612,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyODg2MzYxMg==","diff_hunk":"@@ -56,13 +57,22 @@ def trans():\n branding_settings.text_color = branding_settings_to.text_color\n branding_settings.show_identity_name = branding_settings_to.show_identity_name\n branding_settings.show_avatar = branding_settings_to.show_avatar\n+ branding_settings.recommend_enabled = branding_settings_to.recommend_enabled\n+\n branding_settings.modification_time = now()\n \n sln_settings.events_branding_hash = None\n sln_settings.updates_pending = True\n \n to_be_put = [branding_settings, sln_settings]\n \n+ if branding_settings_to.left_align_icons != branding_settings.left_align_icons:\n+ static_content = SolutionStaticContent.list_non_deleted(service_user)\n+ for static_content in SolutionStaticContent.list_non_deleted(service_user):","path":"src/solutions/common/bizz/branding_settings.py","position":23,"original_position":23,"commit_id":"c464e3a29b7fa86d413f5cc3195086ce4579ba7b","original_commit_id":"c464e3a29b7fa86d413f5cc3195086ce4579ba7b","user":{"login":"lucasvanhalst","id":6652304,"node_id":"MDQ6VXNlcjY2NTIzMDQ=","avatar_url":"https://avatars0.githubusercontent.com/u/6652304?v=4","gravatar_id":"","url":"https://api.github.com/users/lucasvanhalst","html_url":"https://github.com/lucasvanhalst","followers_url":"https://api.github.com/users/lucasvanhalst/followers","following_url":"https://api.github.com/users/lucasvanhalst/following{/other_user}","gists_url":"https://api.github.com/users/lucasvanhalst/gists{/gist_id}","starred_url":"https://api.github.com/users/lucasvanhalst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucasvanhalst/subscriptions","organizations_url":"https://api.github.com/users/lucasvanhalst/orgs","repos_url":"https://api.github.com/users/lucasvanhalst/repos","events_url":"https://api.github.com/users/lucasvanhalst/events{/privacy}","received_events_url":"https://api.github.com/users/lucasvanhalst/received_events","type":"User","site_admin":false},"body":"nitpick, remove double space after static_content :) ","created_at":"2018-10-29T10:08:16Z","updated_at":"2018-10-29T10:19:36Z","html_url":"https://github.com/our-city-app/oca-backend/pull/1163#discussion_r228863612","pull_request_url":"https://api.github.com/repos/our-city-app/oca-backend/pulls/1163","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/our-city-app/oca-backend/pulls/comments/228863612"},"html":{"href":"https://github.com/our-city-app/oca-backend/pull/1163#discussion_r228863612"},"pull_request":{"href":"https://api.github.com/repos/our-city-app/oca-backend/pulls/1163"}}},"pull_request":{"url":"https://api.github.com/repos/our-city-app/oca-backend/pulls/1163","id":226376326,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2Mzc2MzI2","html_url":"https://github.com/our-city-app/oca-backend/pull/1163","diff_url":"https://github.com/our-city-app/oca-backend/pull/1163.diff","patch_url":"https://github.com/our-city-app/oca-backend/pull/1163.patch","issue_url":"https://api.github.com/repos/our-city-app/oca-backend/issues/1163","number":1163,"state":"open","locked":false,"title":"Dashboard: Add a new tab in settings to customize app texts.","user":{"login":"abom","id":511438,"node_id":"MDQ6VXNlcjUxMTQzOA==","avatar_url":"https://avatars2.githubusercontent.com/u/511438?v=4","gravatar_id":"","url":"https://api.github.com/users/abom","html_url":"https://github.com/abom","followers_url":"https://api.github.com/users/abom/followers","following_url":"https://api.github.com/users/abom/following{/other_user}","gists_url":"https://api.github.com/users/abom/gists{/gist_id}","starred_url":"https://api.github.com/users/abom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abom/subscriptions","organizations_url":"https://api.github.com/users/abom/orgs","repos_url":"https://api.github.com/users/abom/repos","events_url":"https://api.github.com/users/abom/events{/privacy}","received_events_url":"https://api.github.com/users/abom/received_events","type":"User","site_admin":false},"body":"- [ ] NL Translations\r\n\r\nCloses #1147.","created_at":"2018-10-28T15:46:34Z","updated_at":"2018-10-29T10:19:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3bb1fceb4e7cefef704d164f00fafb134328b8ce","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":481139219,"node_id":"MDU6TGFiZWw0ODExMzkyMTk=","url":"https://api.github.com/repos/our-city-app/oca-backend/labels/state_inprogress","name":"state_inprogress","color":"c1e0c6","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/our-city-app/oca-backend/pulls/1163/commits","review_comments_url":"https://api.github.com/repos/our-city-app/oca-backend/pulls/1163/comments","review_comment_url":"https://api.github.com/repos/our-city-app/oca-backend/pulls/comments{/number}","comments_url":"https://api.github.com/repos/our-city-app/oca-backend/issues/1163/comments","statuses_url":"https://api.github.com/repos/our-city-app/oca-backend/statuses/c464e3a29b7fa86d413f5cc3195086ce4579ba7b","head":{"label":"our-city-app:app_texts_2","ref":"app_texts_2","sha":"c464e3a29b7fa86d413f5cc3195086ce4579ba7b","user":{"login":"our-city-app","id":22347101,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMzQ3MTAx","avatar_url":"https://avatars0.githubusercontent.com/u/22347101?v=4","gravatar_id":"","url":"https://api.github.com/users/our-city-app","html_url":"https://github.com/our-city-app","followers_url":"https://api.github.com/users/our-city-app/followers","following_url":"https://api.github.com/users/our-city-app/following{/other_user}","gists_url":"https://api.github.com/users/our-city-app/gists{/gist_id}","starred_url":"https://api.github.com/users/our-city-app/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/our-city-app/subscriptions","organizations_url":"https://api.github.com/users/our-city-app/orgs","repos_url":"https://api.github.com/users/our-city-app/repos","events_url":"https://api.github.com/users/our-city-app/events{/privacy}","received_events_url":"https://api.github.com/users/our-city-app/received_events","type":"Organization","site_admin":false},"repo":{"id":68822180,"node_id":"MDEwOlJlcG9zaXRvcnk2ODgyMjE4MA==","name":"oca-backend","full_name":"our-city-app/oca-backend","private":false,"owner":{"login":"our-city-app","id":22347101,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMzQ3MTAx","avatar_url":"https://avatars0.githubusercontent.com/u/22347101?v=4","gravatar_id":"","url":"https://api.github.com/users/our-city-app","html_url":"https://github.com/our-city-app","followers_url":"https://api.github.com/users/our-city-app/followers","following_url":"https://api.github.com/users/our-city-app/following{/other_user}","gists_url":"https://api.github.com/users/our-city-app/gists{/gist_id}","starred_url":"https://api.github.com/users/our-city-app/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/our-city-app/subscriptions","organizations_url":"https://api.github.com/users/our-city-app/orgs","repos_url":"https://api.github.com/users/our-city-app/repos","events_url":"https://api.github.com/users/our-city-app/events{/privacy}","received_events_url":"https://api.github.com/users/our-city-app/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/our-city-app/oca-backend","description":null,"fork":false,"url":"https://api.github.com/repos/our-city-app/oca-backend","forks_url":"https://api.github.com/repos/our-city-app/oca-backend/forks","keys_url":"https://api.github.com/repos/our-city-app/oca-backend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/our-city-app/oca-backend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/our-city-app/oca-backend/teams","hooks_url":"https://api.github.com/repos/our-city-app/oca-backend/hooks","issue_events_url":"https://api.github.com/repos/our-city-app/oca-backend/issues/events{/number}","events_url":"https://api.github.com/repos/our-city-app/oca-backend/events","assignees_url":"https://api.github.com/repos/our-city-app/oca-backend/assignees{/user}","branches_url":"https://api.github.com/repos/our-city-app/oca-backend/branches{/branch}","tags_url":"https://api.github.com/repos/our-city-app/oca-backend/tags","blobs_url":"https://api.github.com/repos/our-city-app/oca-backend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/our-city-app/oca-backend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/our-city-app/oca-backend/git/refs{/sha}","trees_url":"https://api.github.com/repos/our-city-app/oca-backend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/our-city-app/oca-backend/statuses/{sha}","languages_url":"https://api.github.com/repos/our-city-app/oca-backend/languages","stargazers_url":"https://api.github.com/repos/our-city-app/oca-backend/stargazers","contributors_url":"https://api.github.com/repos/our-city-app/oca-backend/contributors","subscribers_url":"https://api.github.com/repos/our-city-app/oca-backend/subscribers","subscription_url":"https://api.github.com/repos/our-city-app/oca-backend/subscription","commits_url":"https://api.github.com/repos/our-city-app/oca-backend/commits{/sha}","git_commits_url":"https://api.github.com/repos/our-city-app/oca-backend/git/commits{/sha}","comments_url":"https://api.github.com/repos/our-city-app/oca-backend/comments{/number}","issue_comment_url":"https://api.github.com/repos/our-city-app/oca-backend/issues/comments{/number}","contents_url":"https://api.github.com/repos/our-city-app/oca-backend/contents/{+path}","compare_url":"https://api.github.com/repos/our-city-app/oca-backend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/our-city-app/oca-backend/merges","archive_url":"https://api.github.com/repos/our-city-app/oca-backend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/our-city-app/oca-backend/downloads","issues_url":"https://api.github.com/repos/our-city-app/oca-backend/issues{/number}","pulls_url":"https://api.github.com/repos/our-city-app/oca-backend/pulls{/number}","milestones_url":"https://api.github.com/repos/our-city-app/oca-backend/milestones{/number}","notifications_url":"https://api.github.com/repos/our-city-app/oca-backend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/our-city-app/oca-backend/labels{/name}","releases_url":"https://api.github.com/repos/our-city-app/oca-backend/releases{/id}","deployments_url":"https://api.github.com/repos/our-city-app/oca-backend/deployments","created_at":"2016-09-21T13:55:22Z","updated_at":"2018-10-29T09:31:12Z","pushed_at":"2018-10-29T09:31:09Z","git_url":"git://github.com/our-city-app/oca-backend.git","ssh_url":"[email protected]:our-city-app/oca-backend.git","clone_url":"https://github.com/our-city-app/oca-backend.git","svn_url":"https://github.com/our-city-app/oca-backend","homepage":null,"size":16457,"stargazers_count":0,"watchers_count":0,"language":"PostScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":173,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1,"open_issues":173,"watchers":0,"default_branch":"master"}},"base":{"label":"our-city-app:master","ref":"master","sha":"c35c55dd8d1f40695dabb329404df949fb085c06","user":{"login":"our-city-app","id":22347101,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMzQ3MTAx","avatar_url":"https://avatars0.githubusercontent.com/u/22347101?v=4","gravatar_id":"","url":"https://api.github.com/users/our-city-app","html_url":"https://github.com/our-city-app","followers_url":"https://api.github.com/users/our-city-app/followers","following_url":"https://api.github.com/users/our-city-app/following{/other_user}","gists_url":"https://api.github.com/users/our-city-app/gists{/gist_id}","starred_url":"https://api.github.com/users/our-city-app/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/our-city-app/subscriptions","organizations_url":"https://api.github.com/users/our-city-app/orgs","repos_url":"https://api.github.com/users/our-city-app/repos","events_url":"https://api.github.com/users/our-city-app/events{/privacy}","received_events_url":"https://api.github.com/users/our-city-app/received_events","type":"Organization","site_admin":false},"repo":{"id":68822180,"node_id":"MDEwOlJlcG9zaXRvcnk2ODgyMjE4MA==","name":"oca-backend","full_name":"our-city-app/oca-backend","private":false,"owner":{"login":"our-city-app","id":22347101,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMzQ3MTAx","avatar_url":"https://avatars0.githubusercontent.com/u/22347101?v=4","gravatar_id":"","url":"https://api.github.com/users/our-city-app","html_url":"https://github.com/our-city-app","followers_url":"https://api.github.com/users/our-city-app/followers","following_url":"https://api.github.com/users/our-city-app/following{/other_user}","gists_url":"https://api.github.com/users/our-city-app/gists{/gist_id}","starred_url":"https://api.github.com/users/our-city-app/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/our-city-app/subscriptions","organizations_url":"https://api.github.com/users/our-city-app/orgs","repos_url":"https://api.github.com/users/our-city-app/repos","events_url":"https://api.github.com/users/our-city-app/events{/privacy}","received_events_url":"https://api.github.com/users/our-city-app/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/our-city-app/oca-backend","description":null,"fork":false,"url":"https://api.github.com/repos/our-city-app/oca-backend","forks_url":"https://api.github.com/repos/our-city-app/oca-backend/forks","keys_url":"https://api.github.com/repos/our-city-app/oca-backend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/our-city-app/oca-backend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/our-city-app/oca-backend/teams","hooks_url":"https://api.github.com/repos/our-city-app/oca-backend/hooks","issue_events_url":"https://api.github.com/repos/our-city-app/oca-backend/issues/events{/number}","events_url":"https://api.github.com/repos/our-city-app/oca-backend/events","assignees_url":"https://api.github.com/repos/our-city-app/oca-backend/assignees{/user}","branches_url":"https://api.github.com/repos/our-city-app/oca-backend/branches{/branch}","tags_url":"https://api.github.com/repos/our-city-app/oca-backend/tags","blobs_url":"https://api.github.com/repos/our-city-app/oca-backend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/our-city-app/oca-backend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/our-city-app/oca-backend/git/refs{/sha}","trees_url":"https://api.github.com/repos/our-city-app/oca-backend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/our-city-app/oca-backend/statuses/{sha}","languages_url":"https://api.github.com/repos/our-city-app/oca-backend/languages","stargazers_url":"https://api.github.com/repos/our-city-app/oca-backend/stargazers","contributors_url":"https://api.github.com/repos/our-city-app/oca-backend/contributors","subscribers_url":"https://api.github.com/repos/our-city-app/oca-backend/subscribers","subscription_url":"https://api.github.com/repos/our-city-app/oca-backend/subscription","commits_url":"https://api.github.com/repos/our-city-app/oca-backend/commits{/sha}","git_commits_url":"https://api.github.com/repos/our-city-app/oca-backend/git/commits{/sha}","comments_url":"https://api.github.com/repos/our-city-app/oca-backend/comments{/number}","issue_comment_url":"https://api.github.com/repos/our-city-app/oca-backend/issues/comments{/number}","contents_url":"https://api.github.com/repos/our-city-app/oca-backend/contents/{+path}","compare_url":"https://api.github.com/repos/our-city-app/oca-backend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/our-city-app/oca-backend/merges","archive_url":"https://api.github.com/repos/our-city-app/oca-backend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/our-city-app/oca-backend/downloads","issues_url":"https://api.github.com/repos/our-city-app/oca-backend/issues{/number}","pulls_url":"https://api.github.com/repos/our-city-app/oca-backend/pulls{/number}","milestones_url":"https://api.github.com/repos/our-city-app/oca-backend/milestones{/number}","notifications_url":"https://api.github.com/repos/our-city-app/oca-backend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/our-city-app/oca-backend/labels{/name}","releases_url":"https://api.github.com/repos/our-city-app/oca-backend/releases{/id}","deployments_url":"https://api.github.com/repos/our-city-app/oca-backend/deployments","created_at":"2016-09-21T13:55:22Z","updated_at":"2018-10-29T09:31:12Z","pushed_at":"2018-10-29T09:31:09Z","git_url":"git://github.com/our-city-app/oca-backend.git","ssh_url":"[email protected]:our-city-app/oca-backend.git","clone_url":"https://github.com/our-city-app/oca-backend.git","svn_url":"https://github.com/our-city-app/oca-backend","homepage":null,"size":16457,"stargazers_count":0,"watchers_count":0,"language":"PostScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":173,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1,"open_issues":173,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/our-city-app/oca-backend/pulls/1163"},"html":{"href":"https://github.com/our-city-app/oca-backend/pull/1163"},"issue":{"href":"https://api.github.com/repos/our-city-app/oca-backend/issues/1163"},"comments":{"href":"https://api.github.com/repos/our-city-app/oca-backend/issues/1163/comments"},"review_comments":{"href":"https://api.github.com/repos/our-city-app/oca-backend/pulls/1163/comments"},"review_comment":{"href":"https://api.github.com/repos/our-city-app/oca-backend/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/our-city-app/oca-backend/pulls/1163/commits"},"statuses":{"href":"https://api.github.com/repos/our-city-app/oca-backend/statuses/c464e3a29b7fa86d413f5cc3195086ce4579ba7b"}},"author_association":"CONTRIBUTOR"}} | {
"id": 68822180,
"name": "our-city-app/oca-backend",
"url": "https://api.github.com/repos/our-city-app/oca-backend"
} | {
"id": 6652304,
"login": "lucasvanhalst",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6652304?",
"url": "https://api.github.com/users/lucasvanhalst"
} | {
"id": 22347101,
"login": "our-city-app",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/22347101?",
"url": "https://api.github.com/orgs/our-city-app"
} | 2018-10-29T10:08:16 | 8496750706 | {"actor":{"display_login":"lucasvanhalst"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/mozilla-mobile/android-components/pulls/comments/226277712","pull_request_review_id":166057638,"id":226277712,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNjI3NzcxMg==","diff_hunk":"@@ -64,6 +64,25 @@ class SessionManagerTest {\n assertEquals(\"http://www.firefox.com\", manager.selectedSessionOrThrow.url)\n }\n \n+ @Test\n+ fun `session can be added by specifying parent`() {\n+ val manager = SessionManager(mock())\n+ val session1 = Session(\"https://www.mozilla.org\")\n+ val session2 = Session(\"https://www.firefox.com\")\n+ val session3 = Session(\"https://wiki.mozilla.org\")\n+ val session4 = Session(\"https://github.com/mozilla-mobile/android-components\")\n+\n+ manager.add(session1)\n+ manager.add(session2)\n+ manager.add(session3, parent = session1)\n+ manager.add(session4, parent = session2)\n+\n+ assertNull(manager.sessions[0].parentId)\n+ assertNull(manager.sessions[1].parentId)\n+ assertEquals(session1.id, manager.sessions[2].parentId)\n+ assertEquals(session2.id, manager.sessions[3].parentId)\n+ }\n+","path":"components/browser/session/src/test/java/mozilla/components/browser/session/SessionManagerTest.kt","position":22,"original_position":22,"commit_id":"8d9d2a4ba478bd3baba1deee98d8db42a5930a4d","original_commit_id":"8d9d2a4ba478bd3baba1deee98d8db42a5930a4d","user":{"login":"pocmo","id":89638,"node_id":"MDQ6VXNlcjg5NjM4","avatar_url":"https://avatars0.githubusercontent.com/u/89638?v=4","gravatar_id":"","url":"https://api.github.com/users/pocmo","html_url":"https://github.com/pocmo","followers_url":"https://api.github.com/users/pocmo/followers","following_url":"https://api.github.com/users/pocmo/following{/other_user}","gists_url":"https://api.github.com/users/pocmo/gists{/gist_id}","starred_url":"https://api.github.com/users/pocmo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pocmo/subscriptions","organizations_url":"https://api.github.com/users/pocmo/orgs","repos_url":"https://api.github.com/users/pocmo/repos","events_url":"https://api.github.com/users/pocmo/events{/privacy}","received_events_url":"https://api.github.com/users/pocmo/received_events","type":"User","site_admin":false},"body":"We could add another test that makes sure we are throwing an exception, e.g.:\r\n\r\n```Kotlin\r\n@Test(expected = IllegalArgumentException::class)\r\nfun `session manager throws exception if parent is not in session manager`() {\r\n val parent = Session(\"https://www.mozilla.org\")\r\n val session = Session(\"https://www.firefox.com\")\r\n\r\n val manager = SessionManager(mock())\r\n manager.add(session, parent = parent)\r\n}\r\n```","created_at":"2018-10-18T12:06:49Z","updated_at":"2018-10-18T12:06:52Z","html_url":"https://github.com/mozilla-mobile/android-components/pull/1103#discussion_r226277712","pull_request_url":"https://api.github.com/repos/mozilla-mobile/android-components/pulls/1103","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/mozilla-mobile/android-components/pulls/comments/226277712"},"html":{"href":"https://github.com/mozilla-mobile/android-components/pull/1103#discussion_r226277712"},"pull_request":{"href":"https://api.github.com/repos/mozilla-mobile/android-components/pulls/1103"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla-mobile/android-components/pulls/1103","id":223890412,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIzODkwNDEy","html_url":"https://github.com/mozilla-mobile/android-components/pull/1103","diff_url":"https://github.com/mozilla-mobile/android-components/pull/1103.diff","patch_url":"https://github.com/mozilla-mobile/android-components/pull/1103.patch","issue_url":"https://api.github.com/repos/mozilla-mobile/android-components/issues/1103","number":1103,"state":"open","locked":false,"title":"Close #1064: add Parent id to Session","user":{"login":"walkingice","id":54793,"node_id":"MDQ6VXNlcjU0Nzkz","avatar_url":"https://avatars1.githubusercontent.com/u/54793?v=4","gravatar_id":"","url":"https://api.github.com/users/walkingice","html_url":"https://github.com/walkingice","followers_url":"https://api.github.com/users/walkingice/followers","following_url":"https://api.github.com/users/walkingice/following{/other_user}","gists_url":"https://api.github.com/users/walkingice/gists{/gist_id}","starred_url":"https://api.github.com/users/walkingice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/walkingice/subscriptions","organizations_url":"https://api.github.com/users/walkingice/orgs","repos_url":"https://api.github.com/users/walkingice/repos","events_url":"https://api.github.com/users/walkingice/events{/privacy}","received_events_url":"https://api.github.com/users/walkingice/received_events","type":"User","site_admin":false},"body":"When creating new session from an existing session, we need to the\r\nrelationship between two sessions. For example, to click a href link in\r\nweb-page to open new tab.\r\n\r\nThis commit add parent id to Session. If a session is added without\r\nparent, it will be append to tail of sessions. Otherwise it will sit\r\nnext to parent.","created_at":"2018-10-18T09:46:17Z","updated_at":"2018-10-18T12:06:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b30bd61a564f047cd7c55d827063e4ad59d93053","assignee":null,"assignees":[],"requested_reviewers":[{"login":"csadilek","id":472523,"node_id":"MDQ6VXNlcjQ3MjUyMw==","avatar_url":"https://avatars1.githubusercontent.com/u/472523?v=4","gravatar_id":"","url":"https://api.github.com/users/csadilek","html_url":"https://github.com/csadilek","followers_url":"https://api.github.com/users/csadilek/followers","following_url":"https://api.github.com/users/csadilek/following{/other_user}","gists_url":"https://api.github.com/users/csadilek/gists{/gist_id}","starred_url":"https://api.github.com/users/csadilek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/csadilek/subscriptions","organizations_url":"https://api.github.com/users/csadilek/orgs","repos_url":"https://api.github.com/users/csadilek/repos","events_url":"https://api.github.com/users/csadilek/events{/privacy}","received_events_url":"https://api.github.com/users/csadilek/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mozilla-mobile/android-components/pulls/1103/commits","review_comments_url":"https://api.github.com/repos/mozilla-mobile/android-components/pulls/1103/comments","review_comment_url":"https://api.github.com/repos/mozilla-mobile/android-components/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla-mobile/android-components/issues/1103/comments","statuses_url":"https://api.github.com/repos/mozilla-mobile/android-components/statuses/8d9d2a4ba478bd3baba1deee98d8db42a5930a4d","head":{"label":"walkingice:issue_1064-keep_parent_session_reference","ref":"issue_1064-keep_parent_session_reference","sha":"8d9d2a4ba478bd3baba1deee98d8db42a5930a4d","user":{"login":"walkingice","id":54793,"node_id":"MDQ6VXNlcjU0Nzkz","avatar_url":"https://avatars1.githubusercontent.com/u/54793?v=4","gravatar_id":"","url":"https://api.github.com/users/walkingice","html_url":"https://github.com/walkingice","followers_url":"https://api.github.com/users/walkingice/followers","following_url":"https://api.github.com/users/walkingice/following{/other_user}","gists_url":"https://api.github.com/users/walkingice/gists{/gist_id}","starred_url":"https://api.github.com/users/walkingice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/walkingice/subscriptions","organizations_url":"https://api.github.com/users/walkingice/orgs","repos_url":"https://api.github.com/users/walkingice/repos","events_url":"https://api.github.com/users/walkingice/events{/privacy}","received_events_url":"https://api.github.com/users/walkingice/received_events","type":"User","site_admin":false},"repo":{"id":153579741,"node_id":"MDEwOlJlcG9zaXRvcnkxNTM1Nzk3NDE=","name":"android-components","full_name":"walkingice/android-components","private":false,"owner":{"login":"walkingice","id":54793,"node_id":"MDQ6VXNlcjU0Nzkz","avatar_url":"https://avatars1.githubusercontent.com/u/54793?v=4","gravatar_id":"","url":"https://api.github.com/users/walkingice","html_url":"https://github.com/walkingice","followers_url":"https://api.github.com/users/walkingice/followers","following_url":"https://api.github.com/users/walkingice/following{/other_user}","gists_url":"https://api.github.com/users/walkingice/gists{/gist_id}","starred_url":"https://api.github.com/users/walkingice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/walkingice/subscriptions","organizations_url":"https://api.github.com/users/walkingice/orgs","repos_url":"https://api.github.com/users/walkingice/repos","events_url":"https://api.github.com/users/walkingice/events{/privacy}","received_events_url":"https://api.github.com/users/walkingice/received_events","type":"User","site_admin":false},"html_url":"https://github.com/walkingice/android-components","description":"A collection of Android libraries to build browsers or browser-like applications.","fork":true,"url":"https://api.github.com/repos/walkingice/android-components","forks_url":"https://api.github.com/repos/walkingice/android-components/forks","keys_url":"https://api.github.com/repos/walkingice/android-components/keys{/key_id}","collaborators_url":"https://api.github.com/repos/walkingice/android-components/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/walkingice/android-components/teams","hooks_url":"https://api.github.com/repos/walkingice/android-components/hooks","issue_events_url":"https://api.github.com/repos/walkingice/android-components/issues/events{/number}","events_url":"https://api.github.com/repos/walkingice/android-components/events","assignees_url":"https://api.github.com/repos/walkingice/android-components/assignees{/user}","branches_url":"https://api.github.com/repos/walkingice/android-components/branches{/branch}","tags_url":"https://api.github.com/repos/walkingice/android-components/tags","blobs_url":"https://api.github.com/repos/walkingice/android-components/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/walkingice/android-components/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/walkingice/android-components/git/refs{/sha}","trees_url":"https://api.github.com/repos/walkingice/android-components/git/trees{/sha}","statuses_url":"https://api.github.com/repos/walkingice/android-components/statuses/{sha}","languages_url":"https://api.github.com/repos/walkingice/android-components/languages","stargazers_url":"https://api.github.com/repos/walkingice/android-components/stargazers","contributors_url":"https://api.github.com/repos/walkingice/android-components/contributors","subscribers_url":"https://api.github.com/repos/walkingice/android-components/subscribers","subscription_url":"https://api.github.com/repos/walkingice/android-components/subscription","commits_url":"https://api.github.com/repos/walkingice/android-components/commits{/sha}","git_commits_url":"https://api.github.com/repos/walkingice/android-components/git/commits{/sha}","comments_url":"https://api.github.com/repos/walkingice/android-components/comments{/number}","issue_comment_url":"https://api.github.com/repos/walkingice/android-components/issues/comments{/number}","contents_url":"https://api.github.com/repos/walkingice/android-components/contents/{+path}","compare_url":"https://api.github.com/repos/walkingice/android-components/compare/{base}...{head}","merges_url":"https://api.github.com/repos/walkingice/android-components/merges","archive_url":"https://api.github.com/repos/walkingice/android-components/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/walkingice/android-components/downloads","issues_url":"https://api.github.com/repos/walkingice/android-components/issues{/number}","pulls_url":"https://api.github.com/repos/walkingice/android-components/pulls{/number}","milestones_url":"https://api.github.com/repos/walkingice/android-components/milestones{/number}","notifications_url":"https://api.github.com/repos/walkingice/android-components/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/walkingice/android-components/labels{/name}","releases_url":"https://api.github.com/repos/walkingice/android-components/releases{/id}","deployments_url":"https://api.github.com/repos/walkingice/android-components/deployments","created_at":"2018-10-18T07:14:22Z","updated_at":"2018-10-18T07:14:30Z","pushed_at":"2018-10-18T10:38:24Z","git_url":"git://github.com/walkingice/android-components.git","ssh_url":"[email protected]:walkingice/android-components.git","clone_url":"https://github.com/walkingice/android-components.git","svn_url":"https://github.com/walkingice/android-components","homepage":"https://mozilla-mobile.github.io/android-components/","size":37033,"stargazers_count":0,"watchers_count":0,"language":"Kotlin","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla-mobile:master","ref":"master","sha":"889b428bbd8cbd19a84074b17e38ab66ee073239","user":{"login":"mozilla-mobile","id":22351667,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMzUxNjY3","avatar_url":"https://avatars3.githubusercontent.com/u/22351667?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla-mobile","html_url":"https://github.com/mozilla-mobile","followers_url":"https://api.github.com/users/mozilla-mobile/followers","following_url":"https://api.github.com/users/mozilla-mobile/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-mobile/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-mobile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-mobile/subscriptions","organizations_url":"https://api.github.com/users/mozilla-mobile/orgs","repos_url":"https://api.github.com/users/mozilla-mobile/repos","events_url":"https://api.github.com/users/mozilla-mobile/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-mobile/received_events","type":"Organization","site_admin":false},"repo":{"id":126199585,"node_id":"MDEwOlJlcG9zaXRvcnkxMjYxOTk1ODU=","name":"android-components","full_name":"mozilla-mobile/android-components","private":false,"owner":{"login":"mozilla-mobile","id":22351667,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMzUxNjY3","avatar_url":"https://avatars3.githubusercontent.com/u/22351667?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla-mobile","html_url":"https://github.com/mozilla-mobile","followers_url":"https://api.github.com/users/mozilla-mobile/followers","following_url":"https://api.github.com/users/mozilla-mobile/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-mobile/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-mobile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-mobile/subscriptions","organizations_url":"https://api.github.com/users/mozilla-mobile/orgs","repos_url":"https://api.github.com/users/mozilla-mobile/repos","events_url":"https://api.github.com/users/mozilla-mobile/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-mobile/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/mozilla-mobile/android-components","description":"A collection of Android libraries to build browsers or browser-like applications.","fork":false,"url":"https://api.github.com/repos/mozilla-mobile/android-components","forks_url":"https://api.github.com/repos/mozilla-mobile/android-components/forks","keys_url":"https://api.github.com/repos/mozilla-mobile/android-components/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla-mobile/android-components/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla-mobile/android-components/teams","hooks_url":"https://api.github.com/repos/mozilla-mobile/android-components/hooks","issue_events_url":"https://api.github.com/repos/mozilla-mobile/android-components/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla-mobile/android-components/events","assignees_url":"https://api.github.com/repos/mozilla-mobile/android-components/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla-mobile/android-components/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla-mobile/android-components/tags","blobs_url":"https://api.github.com/repos/mozilla-mobile/android-components/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla-mobile/android-components/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla-mobile/android-components/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla-mobile/android-components/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla-mobile/android-components/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla-mobile/android-components/languages","stargazers_url":"https://api.github.com/repos/mozilla-mobile/android-components/stargazers","contributors_url":"https://api.github.com/repos/mozilla-mobile/android-components/contributors","subscribers_url":"https://api.github.com/repos/mozilla-mobile/android-components/subscribers","subscription_url":"https://api.github.com/repos/mozilla-mobile/android-components/subscription","commits_url":"https://api.github.com/repos/mozilla-mobile/android-components/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla-mobile/android-components/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla-mobile/android-components/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla-mobile/android-components/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla-mobile/android-components/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla-mobile/android-components/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla-mobile/android-components/merges","archive_url":"https://api.github.com/repos/mozilla-mobile/android-components/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla-mobile/android-components/downloads","issues_url":"https://api.github.com/repos/mozilla-mobile/android-components/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla-mobile/android-components/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla-mobile/android-components/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla-mobile/android-components/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla-mobile/android-components/labels{/name}","releases_url":"https://api.github.com/repos/mozilla-mobile/android-components/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla-mobile/android-components/deployments","created_at":"2018-03-21T15:24:03Z","updated_at":"2018-10-18T07:05:14Z","pushed_at":"2018-10-18T12:05:12Z","git_url":"git://github.com/mozilla-mobile/android-components.git","ssh_url":"[email protected]:mozilla-mobile/android-components.git","clone_url":"https://github.com/mozilla-mobile/android-components.git","svn_url":"https://github.com/mozilla-mobile/android-components","homepage":"https://mozilla-mobile.github.io/android-components/","size":37053,"stargazers_count":439,"watchers_count":439,"language":"Kotlin","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":81,"mirror_url":null,"archived":false,"open_issues_count":220,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":81,"open_issues":220,"watchers":439,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla-mobile/android-components/pulls/1103"},"html":{"href":"https://github.com/mozilla-mobile/android-components/pull/1103"},"issue":{"href":"https://api.github.com/repos/mozilla-mobile/android-components/issues/1103"},"comments":{"href":"https://api.github.com/repos/mozilla-mobile/android-components/issues/1103/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla-mobile/android-components/pulls/1103/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla-mobile/android-components/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla-mobile/android-components/pulls/1103/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla-mobile/android-components/statuses/8d9d2a4ba478bd3baba1deee98d8db42a5930a4d"}},"author_association":"CONTRIBUTOR"}} | {
"id": 126199585,
"name": "mozilla-mobile/android-components",
"url": "https://api.github.com/repos/mozilla-mobile/android-components"
} | {
"id": 89638,
"login": "pocmo",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/89638?",
"url": "https://api.github.com/users/pocmo"
} | {
"id": 22351667,
"login": "mozilla-mobile",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/22351667?",
"url": "https://api.github.com/orgs/mozilla-mobile"
} | 2018-10-18T12:06:49 | 8442029799 | {"actor":{"display_login":"pocmo"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/pulls/comments/165439909","pull_request_review_id":93380178,"id":165439909,"diff_hunk":"@@ -176,7 +176,7 @@ class SearchEngines {\n /// Get all bundled (not custom) search engines, with the default search engine first,\n /// but the others in no particular order.\n class func getUnorderedBundledEnginesFor(locale: Locale) -> [OpenSearchEngine] {\n- let languageIdentifier = locale.identifier\n+ let languageIdentifier = Locale.preferredLanguages.first!","path":"Client/Frontend/Browser/SearchEngines.swift","position":5,"original_position":5,"commit_id":"b48e2f281ff35beb99af5eb0195eef9615811953","original_commit_id":"b48e2f281ff35beb99af5eb0195eef9615811953","user":{"login":"mkaply","id":345868,"avatar_url":"https://avatars3.githubusercontent.com/u/345868?v=4","gravatar_id":"","url":"https://api.github.com/users/mkaply","html_url":"https://github.com/mkaply","followers_url":"https://api.github.com/users/mkaply/followers","following_url":"https://api.github.com/users/mkaply/following{/other_user}","gists_url":"https://api.github.com/users/mkaply/gists{/gist_id}","starred_url":"https://api.github.com/users/mkaply/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkaply/subscriptions","organizations_url":"https://api.github.com/users/mkaply/orgs","repos_url":"https://api.github.com/users/mkaply/repos","events_url":"https://api.github.com/users/mkaply/events{/privacy}","received_events_url":"https://api.github.com/users/mkaply/received_events","type":"User","site_admin":false},"body":"I'm fine with that, but preferredLanguages should always have at least one value.","created_at":"2018-02-01T18:05:33Z","updated_at":"2018-02-01T18:05:33Z","html_url":"https://github.com/mozilla-mobile/firefox-ios/pull/3617#discussion_r165439909","pull_request_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/pulls/3617","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/mozilla-mobile/firefox-ios/pulls/comments/165439909"},"html":{"href":"https://github.com/mozilla-mobile/firefox-ios/pull/3617#discussion_r165439909"},"pull_request":{"href":"https://api.github.com/repos/mozilla-mobile/firefox-ios/pulls/3617"}},"in_reply_to_id":165425357},"pull_request":{"url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/pulls/3617","id":166589388,"html_url":"https://github.com/mozilla-mobile/firefox-ios/pull/3617","diff_url":"https://github.com/mozilla-mobile/firefox-ios/pull/3617.diff","patch_url":"https://github.com/mozilla-mobile/firefox-ios/pull/3617.patch","issue_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/issues/3617","number":3617,"state":"open","locked":false,"title":"locale.identifier is unreliable - use locale.preferred languages","user":{"login":"mkaply","id":345868,"avatar_url":"https://avatars3.githubusercontent.com/u/345868?v=4","gravatar_id":"","url":"https://api.github.com/users/mkaply","html_url":"https://github.com/mkaply","followers_url":"https://api.github.com/users/mkaply/followers","following_url":"https://api.github.com/users/mkaply/following{/other_user}","gists_url":"https://api.github.com/users/mkaply/gists{/gist_id}","starred_url":"https://api.github.com/users/mkaply/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkaply/subscriptions","organizations_url":"https://api.github.com/users/mkaply/orgs","repos_url":"https://api.github.com/users/mkaply/repos","events_url":"https://api.github.com/users/mkaply/events{/privacy}","received_events_url":"https://api.github.com/users/mkaply/received_events","type":"User","site_admin":false},"body":"*Thank you for submitting a pull request, your contributions are greatly appreciated!*\r\n\r\nPlease include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.\r\n## Pull Request Checklist\r\n\r\n- [ ] My patch has gone through review and I have addressed review comments\r\n- [ ] My patch has a standard commit message that looks like `Bug 12345678 - This fixes something something`\r\n\r\n- [ ] I have updated the *Unit Tests* to cover new or changed functionality\r\n- [ ] I have updated the *UI Tests* to cover new or changed functionality\r\n- [ ] I have marked the bug with `[needsuplift]`\r\n- [ ] I have made sure that localizable strings use `NSLocalizableString()`\r\n\r\n## Screenshots\r\n\r\nIf your patch includes user interface changes that you would like to suggest or that you would like UX to look at, please include them here.\r\n\r\n## Notes for testing this patch\r\n\r\nIf useful, please leave notes for QA, explaining what this patch changes and how it can be best tested and verified.\r\n","created_at":"2018-02-01T16:39:41Z","updated_at":"2018-02-01T18:05:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0d1281cce72711efa71041ad7dec5bb19359427b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/pulls/3617/commits","review_comments_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/pulls/3617/comments","review_comment_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/issues/3617/comments","statuses_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/statuses/b48e2f281ff35beb99af5eb0195eef9615811953","head":{"label":"mkaply:1434195_incorrect_china_search","ref":"1434195_incorrect_china_search","sha":"b48e2f281ff35beb99af5eb0195eef9615811953","user":{"login":"mkaply","id":345868,"avatar_url":"https://avatars3.githubusercontent.com/u/345868?v=4","gravatar_id":"","url":"https://api.github.com/users/mkaply","html_url":"https://github.com/mkaply","followers_url":"https://api.github.com/users/mkaply/followers","following_url":"https://api.github.com/users/mkaply/following{/other_user}","gists_url":"https://api.github.com/users/mkaply/gists{/gist_id}","starred_url":"https://api.github.com/users/mkaply/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkaply/subscriptions","organizations_url":"https://api.github.com/users/mkaply/orgs","repos_url":"https://api.github.com/users/mkaply/repos","events_url":"https://api.github.com/users/mkaply/events{/privacy}","received_events_url":"https://api.github.com/users/mkaply/received_events","type":"User","site_admin":false},"repo":{"id":56693289,"name":"firefox-ios","full_name":"mkaply/firefox-ios","owner":{"login":"mkaply","id":345868,"avatar_url":"https://avatars3.githubusercontent.com/u/345868?v=4","gravatar_id":"","url":"https://api.github.com/users/mkaply","html_url":"https://github.com/mkaply","followers_url":"https://api.github.com/users/mkaply/followers","following_url":"https://api.github.com/users/mkaply/following{/other_user}","gists_url":"https://api.github.com/users/mkaply/gists{/gist_id}","starred_url":"https://api.github.com/users/mkaply/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkaply/subscriptions","organizations_url":"https://api.github.com/users/mkaply/orgs","repos_url":"https://api.github.com/users/mkaply/repos","events_url":"https://api.github.com/users/mkaply/events{/privacy}","received_events_url":"https://api.github.com/users/mkaply/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mkaply/firefox-ios","description":"Firefox for iOS","fork":true,"url":"https://api.github.com/repos/mkaply/firefox-ios","forks_url":"https://api.github.com/repos/mkaply/firefox-ios/forks","keys_url":"https://api.github.com/repos/mkaply/firefox-ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mkaply/firefox-ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mkaply/firefox-ios/teams","hooks_url":"https://api.github.com/repos/mkaply/firefox-ios/hooks","issue_events_url":"https://api.github.com/repos/mkaply/firefox-ios/issues/events{/number}","events_url":"https://api.github.com/repos/mkaply/firefox-ios/events","assignees_url":"https://api.github.com/repos/mkaply/firefox-ios/assignees{/user}","branches_url":"https://api.github.com/repos/mkaply/firefox-ios/branches{/branch}","tags_url":"https://api.github.com/repos/mkaply/firefox-ios/tags","blobs_url":"https://api.github.com/repos/mkaply/firefox-ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mkaply/firefox-ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mkaply/firefox-ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/mkaply/firefox-ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mkaply/firefox-ios/statuses/{sha}","languages_url":"https://api.github.com/repos/mkaply/firefox-ios/languages","stargazers_url":"https://api.github.com/repos/mkaply/firefox-ios/stargazers","contributors_url":"https://api.github.com/repos/mkaply/firefox-ios/contributors","subscribers_url":"https://api.github.com/repos/mkaply/firefox-ios/subscribers","subscription_url":"https://api.github.com/repos/mkaply/firefox-ios/subscription","commits_url":"https://api.github.com/repos/mkaply/firefox-ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/mkaply/firefox-ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/mkaply/firefox-ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/mkaply/firefox-ios/issues/comments{/number}","contents_url":"https://api.github.com/repos/mkaply/firefox-ios/contents/{+path}","compare_url":"https://api.github.com/repos/mkaply/firefox-ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mkaply/firefox-ios/merges","archive_url":"https://api.github.com/repos/mkaply/firefox-ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mkaply/firefox-ios/downloads","issues_url":"https://api.github.com/repos/mkaply/firefox-ios/issues{/number}","pulls_url":"https://api.github.com/repos/mkaply/firefox-ios/pulls{/number}","milestones_url":"https://api.github.com/repos/mkaply/firefox-ios/milestones{/number}","notifications_url":"https://api.github.com/repos/mkaply/firefox-ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mkaply/firefox-ios/labels{/name}","releases_url":"https://api.github.com/repos/mkaply/firefox-ios/releases{/id}","deployments_url":"https://api.github.com/repos/mkaply/firefox-ios/deployments","created_at":"2016-04-20T14:20:43Z","updated_at":"2017-03-29T20:08:20Z","pushed_at":"2018-02-01T16:39:08Z","git_url":"git://github.com/mkaply/firefox-ios.git","ssh_url":"[email protected]:mkaply/firefox-ios.git","clone_url":"https://github.com/mkaply/firefox-ios.git","svn_url":"https://github.com/mkaply/firefox-ios","homepage":"","size":277427,"stargazers_count":0,"watchers_count":0,"language":"Swift","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla-mobile:master","ref":"master","sha":"2ba305c1493c604336e51ef6ca15b2e407886ecf","user":{"login":"mozilla-mobile","id":22351667,"avatar_url":"https://avatars3.githubusercontent.com/u/22351667?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla-mobile","html_url":"https://github.com/mozilla-mobile","followers_url":"https://api.github.com/users/mozilla-mobile/followers","following_url":"https://api.github.com/users/mozilla-mobile/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-mobile/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-mobile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-mobile/subscriptions","organizations_url":"https://api.github.com/users/mozilla-mobile/orgs","repos_url":"https://api.github.com/users/mozilla-mobile/repos","events_url":"https://api.github.com/users/mozilla-mobile/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-mobile/received_events","type":"Organization","site_admin":false},"repo":{"id":26133979,"name":"firefox-ios","full_name":"mozilla-mobile/firefox-ios","owner":{"login":"mozilla-mobile","id":22351667,"avatar_url":"https://avatars3.githubusercontent.com/u/22351667?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla-mobile","html_url":"https://github.com/mozilla-mobile","followers_url":"https://api.github.com/users/mozilla-mobile/followers","following_url":"https://api.github.com/users/mozilla-mobile/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-mobile/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-mobile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-mobile/subscriptions","organizations_url":"https://api.github.com/users/mozilla-mobile/orgs","repos_url":"https://api.github.com/users/mozilla-mobile/repos","events_url":"https://api.github.com/users/mozilla-mobile/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-mobile/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla-mobile/firefox-ios","description":"Firefox for iOS","fork":false,"url":"https://api.github.com/repos/mozilla-mobile/firefox-ios","forks_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/forks","keys_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/teams","hooks_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/hooks","issue_events_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/events","assignees_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/tags","blobs_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/languages","stargazers_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/stargazers","contributors_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/contributors","subscribers_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/subscribers","subscription_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/subscription","commits_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/merges","archive_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/downloads","issues_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/labels{/name}","releases_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/deployments","created_at":"2014-11-03T19:07:02Z","updated_at":"2018-02-01T02:45:36Z","pushed_at":"2018-02-01T16:39:41Z","git_url":"git://github.com/mozilla-mobile/firefox-ios.git","ssh_url":"[email protected]:mozilla-mobile/firefox-ios.git","clone_url":"https://github.com/mozilla-mobile/firefox-ios.git","svn_url":"https://github.com/mozilla-mobile/firefox-ios","homepage":"","size":567831,"stargazers_count":7791,"watchers_count":7791,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1703,"mirror_url":null,"archived":false,"open_issues_count":49,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0"},"forks":1703,"open_issues":49,"watchers":7791,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla-mobile/firefox-ios/pulls/3617"},"html":{"href":"https://github.com/mozilla-mobile/firefox-ios/pull/3617"},"issue":{"href":"https://api.github.com/repos/mozilla-mobile/firefox-ios/issues/3617"},"comments":{"href":"https://api.github.com/repos/mozilla-mobile/firefox-ios/issues/3617/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla-mobile/firefox-ios/pulls/3617/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla-mobile/firefox-ios/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla-mobile/firefox-ios/pulls/3617/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla-mobile/firefox-ios/statuses/b48e2f281ff35beb99af5eb0195eef9615811953"}},"author_association":"CONTRIBUTOR"}} | {
"id": 26133979,
"name": "mozilla-mobile/firefox-ios",
"url": "https://api.github.com/repos/mozilla-mobile/firefox-ios"
} | {
"id": 345868,
"login": "mkaply",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/345868?",
"url": "https://api.github.com/users/mkaply"
} | {
"id": 22351667,
"login": "mozilla-mobile",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/22351667?",
"url": "https://api.github.com/orgs/mozilla-mobile"
} | 2018-02-01T18:05:33 | 7185014161 | {"actor":{"display_login":"mkaply"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/jsonapi-suite/strong_resources/pulls/comments/171932855","pull_request_review_id":100877185,"id":171932855,"diff_hunk":"@@ -8,6 +8,11 @@ class << self\n attr_accessor :_strong_resources\n end\n end\n+\n+ if respond_to?(:register_exception)","path":"lib/strong_resources/controller/mixin.rb","position":5,"original_position":5,"commit_id":"73d1adb934289d0cf89eab04ea036584c3396d75","original_commit_id":"73d1adb934289d0cf89eab04ea036584c3396d75","user":{"login":"richmolj","id":55264,"avatar_url":"https://avatars1.githubusercontent.com/u/55264?v=4","gravatar_id":"","url":"https://api.github.com/users/richmolj","html_url":"https://github.com/richmolj","followers_url":"https://api.github.com/users/richmolj/followers","following_url":"https://api.github.com/users/richmolj/following{/other_user}","gists_url":"https://api.github.com/users/richmolj/gists{/gist_id}","starred_url":"https://api.github.com/users/richmolj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richmolj/subscriptions","organizations_url":"https://api.github.com/users/richmolj/orgs","repos_url":"https://api.github.com/users/richmolj/repos","events_url":"https://api.github.com/users/richmolj/events{/privacy}","received_events_url":"https://api.github.com/users/richmolj/received_events","type":"User","site_admin":false},"body":"maybe a quick comment on the respond to, nothing that we're integrating with errorable","created_at":"2018-03-02T18:57:41Z","updated_at":"2018-03-02T19:00:13Z","html_url":"https://github.com/jsonapi-suite/strong_resources/pull/8#discussion_r171932855","pull_request_url":"https://api.github.com/repos/jsonapi-suite/strong_resources/pulls/8","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/jsonapi-suite/strong_resources/pulls/comments/171932855"},"html":{"href":"https://github.com/jsonapi-suite/strong_resources/pull/8#discussion_r171932855"},"pull_request":{"href":"https://api.github.com/repos/jsonapi-suite/strong_resources/pulls/8"}}},"pull_request":{"url":"https://api.github.com/repos/jsonapi-suite/strong_resources/pulls/8","id":172577583,"html_url":"https://github.com/jsonapi-suite/strong_resources/pull/8","diff_url":"https://github.com/jsonapi-suite/strong_resources/pull/8.diff","patch_url":"https://github.com/jsonapi-suite/strong_resources/pull/8.patch","issue_url":"https://api.github.com/repos/jsonapi-suite/strong_resources/issues/8","number":8,"state":"open","locked":false,"title":"Show jsonapi-compliant errors on invalid param","user":{"login":"wadetandy","id":148470,"avatar_url":"https://avatars3.githubusercontent.com/u/148470?v=4","gravatar_id":"","url":"https://api.github.com/users/wadetandy","html_url":"https://github.com/wadetandy","followers_url":"https://api.github.com/users/wadetandy/followers","following_url":"https://api.github.com/users/wadetandy/following{/other_user}","gists_url":"https://api.github.com/users/wadetandy/gists{/gist_id}","starred_url":"https://api.github.com/users/wadetandy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wadetandy/subscriptions","organizations_url":"https://api.github.com/users/wadetandy/orgs","repos_url":"https://api.github.com/users/wadetandy/repos","events_url":"https://api.github.com/users/wadetandy/events{/privacy}","received_events_url":"https://api.github.com/users/wadetandy/received_events","type":"User","site_admin":false},"body":"Previously, when requests were made that violated the formats being\r\nchecked by strong_resources, there was an error thrown which resulted\r\nin a generic 500 error being sent back to the user, which wasn't\r\nparticularly helpful. Those errors are now caught, parsed, and returned\r\nas a jsonapi-compliant error object with a 400 (bad request) status.","created_at":"2018-03-02T18:55:24Z","updated_at":"2018-03-02T19:00:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a5773f1cc013311d33c7471f22a19151b7a29a7a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/jsonapi-suite/strong_resources/pulls/8/commits","review_comments_url":"https://api.github.com/repos/jsonapi-suite/strong_resources/pulls/8/comments","review_comment_url":"https://api.github.com/repos/jsonapi-suite/strong_resources/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jsonapi-suite/strong_resources/issues/8/comments","statuses_url":"https://api.github.com/repos/jsonapi-suite/strong_resources/statuses/73d1adb934289d0cf89eab04ea036584c3396d75","head":{"label":"wadetandy:master","ref":"master","sha":"73d1adb934289d0cf89eab04ea036584c3396d75","user":{"login":"wadetandy","id":148470,"avatar_url":"https://avatars3.githubusercontent.com/u/148470?v=4","gravatar_id":"","url":"https://api.github.com/users/wadetandy","html_url":"https://github.com/wadetandy","followers_url":"https://api.github.com/users/wadetandy/followers","following_url":"https://api.github.com/users/wadetandy/following{/other_user}","gists_url":"https://api.github.com/users/wadetandy/gists{/gist_id}","starred_url":"https://api.github.com/users/wadetandy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wadetandy/subscriptions","organizations_url":"https://api.github.com/users/wadetandy/orgs","repos_url":"https://api.github.com/users/wadetandy/repos","events_url":"https://api.github.com/users/wadetandy/events{/privacy}","received_events_url":"https://api.github.com/users/wadetandy/received_events","type":"User","site_admin":false},"repo":{"id":123611863,"name":"strong_resources","full_name":"wadetandy/strong_resources","owner":{"login":"wadetandy","id":148470,"avatar_url":"https://avatars3.githubusercontent.com/u/148470?v=4","gravatar_id":"","url":"https://api.github.com/users/wadetandy","html_url":"https://github.com/wadetandy","followers_url":"https://api.github.com/users/wadetandy/followers","following_url":"https://api.github.com/users/wadetandy/following{/other_user}","gists_url":"https://api.github.com/users/wadetandy/gists{/gist_id}","starred_url":"https://api.github.com/users/wadetandy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wadetandy/subscriptions","organizations_url":"https://api.github.com/users/wadetandy/orgs","repos_url":"https://api.github.com/users/wadetandy/repos","events_url":"https://api.github.com/users/wadetandy/events{/privacy}","received_events_url":"https://api.github.com/users/wadetandy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wadetandy/strong_resources","description":null,"fork":true,"url":"https://api.github.com/repos/wadetandy/strong_resources","forks_url":"https://api.github.com/repos/wadetandy/strong_resources/forks","keys_url":"https://api.github.com/repos/wadetandy/strong_resources/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wadetandy/strong_resources/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wadetandy/strong_resources/teams","hooks_url":"https://api.github.com/repos/wadetandy/strong_resources/hooks","issue_events_url":"https://api.github.com/repos/wadetandy/strong_resources/issues/events{/number}","events_url":"https://api.github.com/repos/wadetandy/strong_resources/events","assignees_url":"https://api.github.com/repos/wadetandy/strong_resources/assignees{/user}","branches_url":"https://api.github.com/repos/wadetandy/strong_resources/branches{/branch}","tags_url":"https://api.github.com/repos/wadetandy/strong_resources/tags","blobs_url":"https://api.github.com/repos/wadetandy/strong_resources/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wadetandy/strong_resources/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wadetandy/strong_resources/git/refs{/sha}","trees_url":"https://api.github.com/repos/wadetandy/strong_resources/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wadetandy/strong_resources/statuses/{sha}","languages_url":"https://api.github.com/repos/wadetandy/strong_resources/languages","stargazers_url":"https://api.github.com/repos/wadetandy/strong_resources/stargazers","contributors_url":"https://api.github.com/repos/wadetandy/strong_resources/contributors","subscribers_url":"https://api.github.com/repos/wadetandy/strong_resources/subscribers","subscription_url":"https://api.github.com/repos/wadetandy/strong_resources/subscription","commits_url":"https://api.github.com/repos/wadetandy/strong_resources/commits{/sha}","git_commits_url":"https://api.github.com/repos/wadetandy/strong_resources/git/commits{/sha}","comments_url":"https://api.github.com/repos/wadetandy/strong_resources/comments{/number}","issue_comment_url":"https://api.github.com/repos/wadetandy/strong_resources/issues/comments{/number}","contents_url":"https://api.github.com/repos/wadetandy/strong_resources/contents/{+path}","compare_url":"https://api.github.com/repos/wadetandy/strong_resources/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wadetandy/strong_resources/merges","archive_url":"https://api.github.com/repos/wadetandy/strong_resources/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wadetandy/strong_resources/downloads","issues_url":"https://api.github.com/repos/wadetandy/strong_resources/issues{/number}","pulls_url":"https://api.github.com/repos/wadetandy/strong_resources/pulls{/number}","milestones_url":"https://api.github.com/repos/wadetandy/strong_resources/milestones{/number}","notifications_url":"https://api.github.com/repos/wadetandy/strong_resources/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wadetandy/strong_resources/labels{/name}","releases_url":"https://api.github.com/repos/wadetandy/strong_resources/releases{/id}","deployments_url":"https://api.github.com/repos/wadetandy/strong_resources/deployments","created_at":"2018-03-02T17:52:34Z","updated_at":"2018-03-02T17:52:36Z","pushed_at":"2018-03-02T18:48:56Z","git_url":"git://github.com/wadetandy/strong_resources.git","ssh_url":"[email protected]:wadetandy/strong_resources.git","clone_url":"https://github.com/wadetandy/strong_resources.git","svn_url":"https://github.com/wadetandy/strong_resources","homepage":null,"size":49,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jsonapi-suite:master","ref":"master","sha":"dceab4bbc55fffcd459944316c934c613daf2d5c","user":{"login":"jsonapi-suite","id":22380796,"avatar_url":"https://avatars3.githubusercontent.com/u/22380796?v=4","gravatar_id":"","url":"https://api.github.com/users/jsonapi-suite","html_url":"https://github.com/jsonapi-suite","followers_url":"https://api.github.com/users/jsonapi-suite/followers","following_url":"https://api.github.com/users/jsonapi-suite/following{/other_user}","gists_url":"https://api.github.com/users/jsonapi-suite/gists{/gist_id}","starred_url":"https://api.github.com/users/jsonapi-suite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsonapi-suite/subscriptions","organizations_url":"https://api.github.com/users/jsonapi-suite/orgs","repos_url":"https://api.github.com/users/jsonapi-suite/repos","events_url":"https://api.github.com/users/jsonapi-suite/events{/privacy}","received_events_url":"https://api.github.com/users/jsonapi-suite/received_events","type":"Organization","site_admin":false},"repo":{"id":68965365,"name":"strong_resources","full_name":"jsonapi-suite/strong_resources","owner":{"login":"jsonapi-suite","id":22380796,"avatar_url":"https://avatars3.githubusercontent.com/u/22380796?v=4","gravatar_id":"","url":"https://api.github.com/users/jsonapi-suite","html_url":"https://github.com/jsonapi-suite","followers_url":"https://api.github.com/users/jsonapi-suite/followers","following_url":"https://api.github.com/users/jsonapi-suite/following{/other_user}","gists_url":"https://api.github.com/users/jsonapi-suite/gists{/gist_id}","starred_url":"https://api.github.com/users/jsonapi-suite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsonapi-suite/subscriptions","organizations_url":"https://api.github.com/users/jsonapi-suite/orgs","repos_url":"https://api.github.com/users/jsonapi-suite/repos","events_url":"https://api.github.com/users/jsonapi-suite/events{/privacy}","received_events_url":"https://api.github.com/users/jsonapi-suite/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jsonapi-suite/strong_resources","description":null,"fork":false,"url":"https://api.github.com/repos/jsonapi-suite/strong_resources","forks_url":"https://api.github.com/repos/jsonapi-suite/strong_resources/forks","keys_url":"https://api.github.com/repos/jsonapi-suite/strong_resources/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jsonapi-suite/strong_resources/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jsonapi-suite/strong_resources/teams","hooks_url":"https://api.github.com/repos/jsonapi-suite/strong_resources/hooks","issue_events_url":"https://api.github.com/repos/jsonapi-suite/strong_resources/issues/events{/number}","events_url":"https://api.github.com/repos/jsonapi-suite/strong_resources/events","assignees_url":"https://api.github.com/repos/jsonapi-suite/strong_resources/assignees{/user}","branches_url":"https://api.github.com/repos/jsonapi-suite/strong_resources/branches{/branch}","tags_url":"https://api.github.com/repos/jsonapi-suite/strong_resources/tags","blobs_url":"https://api.github.com/repos/jsonapi-suite/strong_resources/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jsonapi-suite/strong_resources/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jsonapi-suite/strong_resources/git/refs{/sha}","trees_url":"https://api.github.com/repos/jsonapi-suite/strong_resources/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jsonapi-suite/strong_resources/statuses/{sha}","languages_url":"https://api.github.com/repos/jsonapi-suite/strong_resources/languages","stargazers_url":"https://api.github.com/repos/jsonapi-suite/strong_resources/stargazers","contributors_url":"https://api.github.com/repos/jsonapi-suite/strong_resources/contributors","subscribers_url":"https://api.github.com/repos/jsonapi-suite/strong_resources/subscribers","subscription_url":"https://api.github.com/repos/jsonapi-suite/strong_resources/subscription","commits_url":"https://api.github.com/repos/jsonapi-suite/strong_resources/commits{/sha}","git_commits_url":"https://api.github.com/repos/jsonapi-suite/strong_resources/git/commits{/sha}","comments_url":"https://api.github.com/repos/jsonapi-suite/strong_resources/comments{/number}","issue_comment_url":"https://api.github.com/repos/jsonapi-suite/strong_resources/issues/comments{/number}","contents_url":"https://api.github.com/repos/jsonapi-suite/strong_resources/contents/{+path}","compare_url":"https://api.github.com/repos/jsonapi-suite/strong_resources/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jsonapi-suite/strong_resources/merges","archive_url":"https://api.github.com/repos/jsonapi-suite/strong_resources/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jsonapi-suite/strong_resources/downloads","issues_url":"https://api.github.com/repos/jsonapi-suite/strong_resources/issues{/number}","pulls_url":"https://api.github.com/repos/jsonapi-suite/strong_resources/pulls{/number}","milestones_url":"https://api.github.com/repos/jsonapi-suite/strong_resources/milestones{/number}","notifications_url":"https://api.github.com/repos/jsonapi-suite/strong_resources/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jsonapi-suite/strong_resources/labels{/name}","releases_url":"https://api.github.com/repos/jsonapi-suite/strong_resources/releases{/id}","deployments_url":"https://api.github.com/repos/jsonapi-suite/strong_resources/deployments","created_at":"2016-09-22T21:55:28Z","updated_at":"2017-11-03T08:42:11Z","pushed_at":"2018-03-02T18:55:25Z","git_url":"git://github.com/jsonapi-suite/strong_resources.git","ssh_url":"[email protected]:jsonapi-suite/strong_resources.git","clone_url":"https://github.com/jsonapi-suite/strong_resources.git","svn_url":"https://github.com/jsonapi-suite/strong_resources","homepage":null,"size":49,"stargazers_count":4,"watchers_count":4,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":8,"open_issues":3,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jsonapi-suite/strong_resources/pulls/8"},"html":{"href":"https://github.com/jsonapi-suite/strong_resources/pull/8"},"issue":{"href":"https://api.github.com/repos/jsonapi-suite/strong_resources/issues/8"},"comments":{"href":"https://api.github.com/repos/jsonapi-suite/strong_resources/issues/8/comments"},"review_comments":{"href":"https://api.github.com/repos/jsonapi-suite/strong_resources/pulls/8/comments"},"review_comment":{"href":"https://api.github.com/repos/jsonapi-suite/strong_resources/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jsonapi-suite/strong_resources/pulls/8/commits"},"statuses":{"href":"https://api.github.com/repos/jsonapi-suite/strong_resources/statuses/73d1adb934289d0cf89eab04ea036584c3396d75"}},"author_association":"NONE"}} | {
"id": 68965365,
"name": "jsonapi-suite/strong_resources",
"url": "https://api.github.com/repos/jsonapi-suite/strong_resources"
} | {
"id": 55264,
"login": "richmolj",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/55264?",
"url": "https://api.github.com/users/richmolj"
} | {
"id": 22380796,
"login": "jsonapi-suite",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/22380796?",
"url": "https://api.github.com/orgs/jsonapi-suite"
} | 2018-03-02T18:57:41 | 7323509700 | {"actor":{"display_login":"richmolj"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/MicrosoftDocs/commercialization-public/pulls/comments/239170811","pull_request_review_id":181883547,"id":239170811,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzOTE3MDgxMQ==","diff_hunk":"@@ -9,54 +9,105 @@ ms.date: 05/02/2017\n \n ---\n \n-# Precision touchpad tuning\n+# Tuning the Precision Touchpad\n \n-There are several approaches an OEM can take to adjust the default touchpad experience on their Windows-based device. The default values meet the needs of most users, so they should only be adjusted if they don't provide the specific experience that the OEM wants. \n+There are several approaches an OEM can take to adjust the default touchpad experience on their Windows-based device. The default values meet the needs of most users, so they should only be adjusted if they don't provide the specific experience that the OEM wants.\n \n-Be aware that serious problems can occur if you modify the registry incorrectly. Therefore, make sure that you follow these steps carefully. For additional protection, back up the registry before you modify it so you can restore the registry if a problem occurs. For more information about how to back up and restore the registry, see [How to back up and restore the registry in Windows](https://support.microsoft.com/en-us/help/322756/how-to-back-up-and-restore-the-registry-in-windowshttps:/support.microsoft.com/en-us/help/322756/how-to-back-up-and-restore-the-registry-in-windows).\n+> Be aware that serious problems can occur if the registry is modified incorrectly. Ensure these steps are followed carefully. For additional protection, back up the registry before modification. See [how to back up and restore the registry in Windows](https://support.microsoft.com/en-us/help/322756/how-to-back-up-and-restore-the-registry-in-windowshttps:/support.microsoft.com/en-us/help/322756/how-to-back-up-and-restore-the-registry-in-windows).\n \n-## Windows 10 tuning capabilities\n+## Servicing your configuration\n+As of 19H1 Windows supports two locations in the registry for customizing the touchpad. The keys in the rest of this document are located in one of these two places. This makes it possible to service your configuration through Windows Update. \n+- The device's `HKR` hardware key:\n+ - [Introduction to registry keys for drivers](https://docs.microsoft.com/en-us/windows-hardware/drivers/wdf/introduction-to-registry-keys-for-drivers)\n+ - [Device Driver INF AddReg Directive](https://docs.microsoft.com/en-us/windows-hardware/drivers/install/inf-addreg-directive)\n+ - [Opening a Device's Hardware Key](https://docs.microsoft.com/en-us/windows-hardware/drivers/install/opening-a-device-s-hardware-key)\n+- The old location: `HKEY_LOCAL_MACHINE\\Software\\Microsoft\\Windows\\CurrentVersion\\PrecisionTouchPad`\n \n-Windows 10, version 1607 provides new registry capabilities for better device tuning. Note that the default values are set to work well with most devices. \n+For _each_ of the registry keys in the rest of this guide, the HKR location is checked first, then the HKLM location next, enabling the ability to split configuration between the two.\n \n-The most common tuning required is shifting the touchpad offset. Keyboard offset registry keys are unchanged from Windows 8.1 and will continue to be used for Windows 10, version 1607. For more information, see [the touchpad tuning guide](https://docs.microsoft.com/en-us/windows-hardware/design/component-guidelines/windows-precision-touchpad-device-integration). All registry keys noted below are stored in: `HKEY_LOCAL_MACHINE\\SOFTWARE\\Microsoft\\Windows\\CurrentVersion\\PrecisionTouchPad\\`\n+## Accidental Activation Prevention\n+AAP is a feature of Windows that suppresses certain actions like mouse moves and taps for a short time after keyboarding events. The specific timeouts depend on the type of action and the region of the touchpad it was performed, as well as the user setting called `Touchpad sensitivity` found in Touchpad settings. More sensitive means less time is spent suppressing input after keyboarding events. Maximum sensitivity means AAP timeouts are zero and AAP is not in effect.\n+\n+| | |\n+| --- | --- |\n+|  |  |\n+\n+## Tunable parameters\n+Windows defines two classes of \"Curtain\" regions on the touchpad to help prevent accidental input when users are resting their hands on the keyboard or touchpad during normal use. This splits the touchpad into three regions:\n+- High sensitivity region: no input is ever suppressed in this region\n+- Curtain region: input may be suppressed for some time in this region\n+- Supercurtain region: certain kinds of input like taps are almost always suppressed when the gesture interacts with this region\n+\n+As of 19H1 there are two ways to configure the Curtain region. Directly from the edges of the touchpad, or the legacy method where curtains are determined based on the location of the touchpad with respect to the keyboard.\n+\n+Regardless of which curtain method is used, it is strongly recommended to describe to Windows the physical touchpad offset relative to the keyboard via `SpaceBarOffset` and `HorizontalOffset`. This is necessary for Windows to make decisions around a consistent and predictable user experience when the user switches between keyboarding and pointing. For more information, see the [Windows Precision Touchpad Device Integration](https://docs.microsoft.com/en-us/windows-hardware/design/component-guidelines/windows-precision-touchpad-device-integration) guide. ","path":"design/component-guidelines/touchpad-tuning-guidelines.md","position":41,"original_position":41,"commit_id":"32ec58515df93f277f36fe71a41932e5803c2c10","original_commit_id":"32ec58515df93f277f36fe71a41932e5803c2c10","user":{"login":"rossnichols","id":15374058,"node_id":"MDQ6VXNlcjE1Mzc0MDU4","avatar_url":"https://avatars3.githubusercontent.com/u/15374058?v=4","gravatar_id":"","url":"https://api.github.com/users/rossnichols","html_url":"https://github.com/rossnichols","followers_url":"https://api.github.com/users/rossnichols/followers","following_url":"https://api.github.com/users/rossnichols/following{/other_user}","gists_url":"https://api.github.com/users/rossnichols/gists{/gist_id}","starred_url":"https://api.github.com/users/rossnichols/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rossnichols/subscriptions","organizations_url":"https://api.github.com/users/rossnichols/orgs","repos_url":"https://api.github.com/users/rossnichols/repos","events_url":"https://api.github.com/users/rossnichols/events{/privacy}","received_events_url":"https://api.github.com/users/rossnichols/received_events","type":"User","site_admin":false},"body":"I'd rephrase in combination with above - e.g., even when explicitly configuring the curtains, it is still strongly recommended to provide the positioning information.","created_at":"2018-12-05T17:51:17Z","updated_at":"2018-12-05T17:55:32Z","html_url":"https://github.com/MicrosoftDocs/commercialization-public/pull/490#discussion_r239170811","pull_request_url":"https://api.github.com/repos/MicrosoftDocs/commercialization-public/pulls/490","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/MicrosoftDocs/commercialization-public/pulls/comments/239170811"},"html":{"href":"https://github.com/MicrosoftDocs/commercialization-public/pull/490#discussion_r239170811"},"pull_request":{"href":"https://api.github.com/repos/MicrosoftDocs/commercialization-public/pulls/490"}}},"pull_request":{"url":"https://api.github.com/repos/MicrosoftDocs/commercialization-public/pulls/490","id":234843806,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM0ODQzODA2","html_url":"https://github.com/MicrosoftDocs/commercialization-public/pull/490","diff_url":"https://github.com/MicrosoftDocs/commercialization-public/pull/490.diff","patch_url":"https://github.com/MicrosoftDocs/commercialization-public/pull/490.patch","issue_url":"https://api.github.com/repos/MicrosoftDocs/commercialization-public/issues/490","number":490,"state":"open","locked":false,"title":"Update touchpad tuning guide","user":{"login":"zhenyasav","id":3398896,"node_id":"MDQ6VXNlcjMzOTg4OTY=","avatar_url":"https://avatars0.githubusercontent.com/u/3398896?v=4","gravatar_id":"","url":"https://api.github.com/users/zhenyasav","html_url":"https://github.com/zhenyasav","followers_url":"https://api.github.com/users/zhenyasav/followers","following_url":"https://api.github.com/users/zhenyasav/following{/other_user}","gists_url":"https://api.github.com/users/zhenyasav/gists{/gist_id}","starred_url":"https://api.github.com/users/zhenyasav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhenyasav/subscriptions","organizations_url":"https://api.github.com/users/zhenyasav/orgs","repos_url":"https://api.github.com/users/zhenyasav/repos","events_url":"https://api.github.com/users/zhenyasav/events{/privacy}","received_events_url":"https://api.github.com/users/zhenyasav/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-11-30T01:34:53Z","updated_at":"2018-12-05T17:55:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e138378fe9864af61e34129dae1efcdc76fdf551","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/MicrosoftDocs/commercialization-public/pulls/490/commits","review_comments_url":"https://api.github.com/repos/MicrosoftDocs/commercialization-public/pulls/490/comments","review_comment_url":"https://api.github.com/repos/MicrosoftDocs/commercialization-public/pulls/comments{/number}","comments_url":"https://api.github.com/repos/MicrosoftDocs/commercialization-public/issues/490/comments","statuses_url":"https://api.github.com/repos/MicrosoftDocs/commercialization-public/statuses/32ec58515df93f277f36fe71a41932e5803c2c10","head":{"label":"zhenyasav:zhenya/touchpad-tuning-curtains","ref":"zhenya/touchpad-tuning-curtains","sha":"32ec58515df93f277f36fe71a41932e5803c2c10","user":{"login":"zhenyasav","id":3398896,"node_id":"MDQ6VXNlcjMzOTg4OTY=","avatar_url":"https://avatars0.githubusercontent.com/u/3398896?v=4","gravatar_id":"","url":"https://api.github.com/users/zhenyasav","html_url":"https://github.com/zhenyasav","followers_url":"https://api.github.com/users/zhenyasav/followers","following_url":"https://api.github.com/users/zhenyasav/following{/other_user}","gists_url":"https://api.github.com/users/zhenyasav/gists{/gist_id}","starred_url":"https://api.github.com/users/zhenyasav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhenyasav/subscriptions","organizations_url":"https://api.github.com/users/zhenyasav/orgs","repos_url":"https://api.github.com/users/zhenyasav/repos","events_url":"https://api.github.com/users/zhenyasav/events{/privacy}","received_events_url":"https://api.github.com/users/zhenyasav/received_events","type":"User","site_admin":false},"repo":{"id":144765011,"node_id":"MDEwOlJlcG9zaXRvcnkxNDQ3NjUwMTE=","name":"commercialization-public","full_name":"zhenyasav/commercialization-public","private":false,"owner":{"login":"zhenyasav","id":3398896,"node_id":"MDQ6VXNlcjMzOTg4OTY=","avatar_url":"https://avatars0.githubusercontent.com/u/3398896?v=4","gravatar_id":"","url":"https://api.github.com/users/zhenyasav","html_url":"https://github.com/zhenyasav","followers_url":"https://api.github.com/users/zhenyasav/followers","following_url":"https://api.github.com/users/zhenyasav/following{/other_user}","gists_url":"https://api.github.com/users/zhenyasav/gists{/gist_id}","starred_url":"https://api.github.com/users/zhenyasav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhenyasav/subscriptions","organizations_url":"https://api.github.com/users/zhenyasav/orgs","repos_url":"https://api.github.com/users/zhenyasav/repos","events_url":"https://api.github.com/users/zhenyasav/events{/privacy}","received_events_url":"https://api.github.com/users/zhenyasav/received_events","type":"User","site_admin":false},"html_url":"https://github.com/zhenyasav/commercialization-public","description":"Windows hardware documentation for Microsoft partners.","fork":true,"url":"https://api.github.com/repos/zhenyasav/commercialization-public","forks_url":"https://api.github.com/repos/zhenyasav/commercialization-public/forks","keys_url":"https://api.github.com/repos/zhenyasav/commercialization-public/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zhenyasav/commercialization-public/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zhenyasav/commercialization-public/teams","hooks_url":"https://api.github.com/repos/zhenyasav/commercialization-public/hooks","issue_events_url":"https://api.github.com/repos/zhenyasav/commercialization-public/issues/events{/number}","events_url":"https://api.github.com/repos/zhenyasav/commercialization-public/events","assignees_url":"https://api.github.com/repos/zhenyasav/commercialization-public/assignees{/user}","branches_url":"https://api.github.com/repos/zhenyasav/commercialization-public/branches{/branch}","tags_url":"https://api.github.com/repos/zhenyasav/commercialization-public/tags","blobs_url":"https://api.github.com/repos/zhenyasav/commercialization-public/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zhenyasav/commercialization-public/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zhenyasav/commercialization-public/git/refs{/sha}","trees_url":"https://api.github.com/repos/zhenyasav/commercialization-public/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zhenyasav/commercialization-public/statuses/{sha}","languages_url":"https://api.github.com/repos/zhenyasav/commercialization-public/languages","stargazers_url":"https://api.github.com/repos/zhenyasav/commercialization-public/stargazers","contributors_url":"https://api.github.com/repos/zhenyasav/commercialization-public/contributors","subscribers_url":"https://api.github.com/repos/zhenyasav/commercialization-public/subscribers","subscription_url":"https://api.github.com/repos/zhenyasav/commercialization-public/subscription","commits_url":"https://api.github.com/repos/zhenyasav/commercialization-public/commits{/sha}","git_commits_url":"https://api.github.com/repos/zhenyasav/commercialization-public/git/commits{/sha}","comments_url":"https://api.github.com/repos/zhenyasav/commercialization-public/comments{/number}","issue_comment_url":"https://api.github.com/repos/zhenyasav/commercialization-public/issues/comments{/number}","contents_url":"https://api.github.com/repos/zhenyasav/commercialization-public/contents/{+path}","compare_url":"https://api.github.com/repos/zhenyasav/commercialization-public/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zhenyasav/commercialization-public/merges","archive_url":"https://api.github.com/repos/zhenyasav/commercialization-public/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zhenyasav/commercialization-public/downloads","issues_url":"https://api.github.com/repos/zhenyasav/commercialization-public/issues{/number}","pulls_url":"https://api.github.com/repos/zhenyasav/commercialization-public/pulls{/number}","milestones_url":"https://api.github.com/repos/zhenyasav/commercialization-public/milestones{/number}","notifications_url":"https://api.github.com/repos/zhenyasav/commercialization-public/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zhenyasav/commercialization-public/labels{/name}","releases_url":"https://api.github.com/repos/zhenyasav/commercialization-public/releases{/id}","deployments_url":"https://api.github.com/repos/zhenyasav/commercialization-public/deployments","created_at":"2018-08-14T19:43:28Z","updated_at":"2018-08-14T19:43:53Z","pushed_at":"2018-11-30T19:12:08Z","git_url":"git://github.com/zhenyasav/commercialization-public.git","ssh_url":"[email protected]:zhenyasav/commercialization-public.git","clone_url":"https://github.com/zhenyasav/commercialization-public.git","svn_url":"https://github.com/zhenyasav/commercialization-public","homepage":null,"size":203101,"stargazers_count":0,"watchers_count":0,"language":"Batchfile","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"MicrosoftDocs:staging","ref":"staging","sha":"5c947e8b5d5c313b7664ff04d0ce7cabe3c92a4a","user":{"login":"MicrosoftDocs","id":22479449,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyNDc5NDQ5","avatar_url":"https://avatars2.githubusercontent.com/u/22479449?v=4","gravatar_id":"","url":"https://api.github.com/users/MicrosoftDocs","html_url":"https://github.com/MicrosoftDocs","followers_url":"https://api.github.com/users/MicrosoftDocs/followers","following_url":"https://api.github.com/users/MicrosoftDocs/following{/other_user}","gists_url":"https://api.github.com/users/MicrosoftDocs/gists{/gist_id}","starred_url":"https://api.github.com/users/MicrosoftDocs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MicrosoftDocs/subscriptions","organizations_url":"https://api.github.com/users/MicrosoftDocs/orgs","repos_url":"https://api.github.com/users/MicrosoftDocs/repos","events_url":"https://api.github.com/users/MicrosoftDocs/events{/privacy}","received_events_url":"https://api.github.com/users/MicrosoftDocs/received_events","type":"Organization","site_admin":false},"repo":{"id":92992508,"node_id":"MDEwOlJlcG9zaXRvcnk5Mjk5MjUwOA==","name":"commercialization-public","full_name":"MicrosoftDocs/commercialization-public","private":false,"owner":{"login":"MicrosoftDocs","id":22479449,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyNDc5NDQ5","avatar_url":"https://avatars2.githubusercontent.com/u/22479449?v=4","gravatar_id":"","url":"https://api.github.com/users/MicrosoftDocs","html_url":"https://github.com/MicrosoftDocs","followers_url":"https://api.github.com/users/MicrosoftDocs/followers","following_url":"https://api.github.com/users/MicrosoftDocs/following{/other_user}","gists_url":"https://api.github.com/users/MicrosoftDocs/gists{/gist_id}","starred_url":"https://api.github.com/users/MicrosoftDocs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MicrosoftDocs/subscriptions","organizations_url":"https://api.github.com/users/MicrosoftDocs/orgs","repos_url":"https://api.github.com/users/MicrosoftDocs/repos","events_url":"https://api.github.com/users/MicrosoftDocs/events{/privacy}","received_events_url":"https://api.github.com/users/MicrosoftDocs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/MicrosoftDocs/commercialization-public","description":"Windows hardware documentation for Microsoft partners.","fork":false,"url":"https://api.github.com/repos/MicrosoftDocs/commercialization-public","forks_url":"https://api.github.com/repos/MicrosoftDocs/commercialization-public/forks","keys_url":"https://api.github.com/repos/MicrosoftDocs/commercialization-public/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MicrosoftDocs/commercialization-public/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MicrosoftDocs/commercialization-public/teams","hooks_url":"https://api.github.com/repos/MicrosoftDocs/commercialization-public/hooks","issue_events_url":"https://api.github.com/repos/MicrosoftDocs/commercialization-public/issues/events{/number}","events_url":"https://api.github.com/repos/MicrosoftDocs/commercialization-public/events","assignees_url":"https://api.github.com/repos/MicrosoftDocs/commercialization-public/assignees{/user}","branches_url":"https://api.github.com/repos/MicrosoftDocs/commercialization-public/branches{/branch}","tags_url":"https://api.github.com/repos/MicrosoftDocs/commercialization-public/tags","blobs_url":"https://api.github.com/repos/MicrosoftDocs/commercialization-public/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MicrosoftDocs/commercialization-public/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MicrosoftDocs/commercialization-public/git/refs{/sha}","trees_url":"https://api.github.com/repos/MicrosoftDocs/commercialization-public/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MicrosoftDocs/commercialization-public/statuses/{sha}","languages_url":"https://api.github.com/repos/MicrosoftDocs/commercialization-public/languages","stargazers_url":"https://api.github.com/repos/MicrosoftDocs/commercialization-public/stargazers","contributors_url":"https://api.github.com/repos/MicrosoftDocs/commercialization-public/contributors","subscribers_url":"https://api.github.com/repos/MicrosoftDocs/commercialization-public/subscribers","subscription_url":"https://api.github.com/repos/MicrosoftDocs/commercialization-public/subscription","commits_url":"https://api.github.com/repos/MicrosoftDocs/commercialization-public/commits{/sha}","git_commits_url":"https://api.github.com/repos/MicrosoftDocs/commercialization-public/git/commits{/sha}","comments_url":"https://api.github.com/repos/MicrosoftDocs/commercialization-public/comments{/number}","issue_comment_url":"https://api.github.com/repos/MicrosoftDocs/commercialization-public/issues/comments{/number}","contents_url":"https://api.github.com/repos/MicrosoftDocs/commercialization-public/contents/{+path}","compare_url":"https://api.github.com/repos/MicrosoftDocs/commercialization-public/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MicrosoftDocs/commercialization-public/merges","archive_url":"https://api.github.com/repos/MicrosoftDocs/commercialization-public/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MicrosoftDocs/commercialization-public/downloads","issues_url":"https://api.github.com/repos/MicrosoftDocs/commercialization-public/issues{/number}","pulls_url":"https://api.github.com/repos/MicrosoftDocs/commercialization-public/pulls{/number}","milestones_url":"https://api.github.com/repos/MicrosoftDocs/commercialization-public/milestones{/number}","notifications_url":"https://api.github.com/repos/MicrosoftDocs/commercialization-public/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MicrosoftDocs/commercialization-public/labels{/name}","releases_url":"https://api.github.com/repos/MicrosoftDocs/commercialization-public/releases{/id}","deployments_url":"https://api.github.com/repos/MicrosoftDocs/commercialization-public/deployments","created_at":"2017-05-31T22:02:51Z","updated_at":"2018-12-04T23:32:24Z","pushed_at":"2018-12-04T23:32:22Z","git_url":"git://github.com/MicrosoftDocs/commercialization-public.git","ssh_url":"[email protected]:MicrosoftDocs/commercialization-public.git","clone_url":"https://github.com/MicrosoftDocs/commercialization-public.git","svn_url":"https://github.com/MicrosoftDocs/commercialization-public","homepage":null,"size":205784,"stargazers_count":34,"watchers_count":34,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":145,"mirror_url":null,"archived":false,"open_issues_count":30,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":145,"open_issues":30,"watchers":34,"default_branch":"staging"}},"_links":{"self":{"href":"https://api.github.com/repos/MicrosoftDocs/commercialization-public/pulls/490"},"html":{"href":"https://github.com/MicrosoftDocs/commercialization-public/pull/490"},"issue":{"href":"https://api.github.com/repos/MicrosoftDocs/commercialization-public/issues/490"},"comments":{"href":"https://api.github.com/repos/MicrosoftDocs/commercialization-public/issues/490/comments"},"review_comments":{"href":"https://api.github.com/repos/MicrosoftDocs/commercialization-public/pulls/490/comments"},"review_comment":{"href":"https://api.github.com/repos/MicrosoftDocs/commercialization-public/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/MicrosoftDocs/commercialization-public/pulls/490/commits"},"statuses":{"href":"https://api.github.com/repos/MicrosoftDocs/commercialization-public/statuses/32ec58515df93f277f36fe71a41932e5803c2c10"}},"author_association":"NONE"}} | {
"id": 92992508,
"name": "MicrosoftDocs/commercialization-public",
"url": "https://api.github.com/repos/MicrosoftDocs/commercialization-public"
} | {
"id": 15374058,
"login": "rossnichols",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/15374058?",
"url": "https://api.github.com/users/rossnichols"
} | {
"id": 22479449,
"login": "MicrosoftDocs",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/22479449?",
"url": "https://api.github.com/orgs/MicrosoftDocs"
} | 2018-12-05T17:51:17 | 8703923500 | {"actor":{"display_login":"rossnichols"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/FlockOfBirds/calendar/pulls/comments/204716079","pull_request_review_id":139828559,"id":204716079,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNDcxNjA3OQ==","diff_hunk":"@@ -0,0 +1,320 @@\n+import { shallow } from \"enzyme\";\n+import { createElement } from \"react\";\n+\n+import { Alert } from \"../Alert\";\n+import { CalendarProps, DragAndDropCalendar, MyCalendar } from \"../Calendar\";\n+\n+describe(\"Calendar\", () => {\n+ const renderCalendar = (props: CalendarProps) => shallow(createElement(MyCalendar, props));\n+ const calendarProps: CalendarProps = {\n+ events: [],\n+ height: 580,\n+ heightUnit: \"pixels\",\n+ loading: false,\n+ showMultiDayTimes: true,\n+ defaultView: \"month\",\n+ messages: [],\n+ popup: true,\n+ selectable: true,\n+ style: {},\n+ width: 100,\n+ widthUnit: \"percentage\"\n+ };\n+ const formats = {\n+ dayFormat: jasmine.any(Function),\n+ weekdayFormat: jasmine.any(Function),\n+ timeGutterFormat: jasmine.any(Function),\n+ monthHeaderFormat: jasmine.any(Function),\n+ dayHeaderFormat: jasmine.any(Function)\n+ };\n+\n+ beforeAll(() => {\n+ (window as any).mx = {\n+ session: {\n+ sessionData: {\n+ locale: { firstDayOfWeek: 1 }\n+ }\n+ },\n+ parser: {\n+ formatValue: () => jasmine.any(Function)\n+ }\n+ };\n+ });\n+\n+ it(\"renders the structure correctly\", () => {\n+ const calendarComponent = renderCalendar(calendarProps);\n+ const style = { width: \"100%\", height: \"580px\" };\n+\n+ expect(calendarComponent).toBeElement(\n+ createElement(\"div\", { className: \"widget-calendar\", style },\n+ createElement(DragAndDropCalendar, {\n+ events: [],\n+ allDayAccessor: jasmine.any(Function),\n+ eventPropGetter: jasmine.any(Function),\n+ defaultView: \"month\",\n+ formats,\n+ messages: \"\",\n+ views: [],\n+ popup: true,\n+ selectable: true,\n+ step: 60,\n+ showMultiDayTimes: true,\n+ onEventDrop: jasmine.any(Function),\n+ onEventResize: jasmine.any(Function),\n+ onSelectEvent: jasmine.any(Function),\n+ onSelectSlot: jasmine.any(Function)\n+ }),\n+ createElement(Alert, { className: \"widget-calendar-alert\" })\n+ )\n+ );\n+ });\n+\n+ it(\"should render a structure correctly with pixels\", () => {\n+ const calendarComponent = renderCalendar(calendarProps);\n+ const style = { width: \"100px\", height: \"580px\" };\n+ calendarComponent.setProps({\n+ heightUnit: \"pixels\",\n+ widthUnit: \"pixels\"\n+ });\n+\n+ expect(calendarComponent).toBeElement(\n+ createElement(\"div\", { className: \"widget-calendar\", style },\n+ createElement(DragAndDropCalendar, {\n+ events: [],\n+ allDayAccessor: jasmine.any(Function),\n+ eventPropGetter: jasmine.any(Function),\n+ defaultView: \"month\",\n+ formats,\n+ messages: \"\",\n+ views: [],\n+ popup: true,\n+ selectable: true,\n+ step: 60,\n+ showMultiDayTimes: true,\n+ onEventDrop: jasmine.any(Function),\n+ onEventResize: jasmine.any(Function),\n+ onSelectEvent: jasmine.any(Function),\n+ onSelectSlot: jasmine.any(Function)\n+ }),\n+ createElement(Alert, { className: \"widget-calendar-alert\" })\n+ )\n+ );\n+ });\n+\n+ it(\"should render a structure correctly with percentage\", () => {\n+ const calendarComponent = renderCalendar(calendarProps);\n+ const style = { width: \"100%\", paddingBottom: \"580%\" };\n+ calendarComponent.setProps({\n+ heightUnit: \"percentageOfWidth\",\n+ widthUnit: \"percentage\"\n+ });\n+\n+ expect(calendarComponent).toBeElement(\n+ createElement(\"div\", { className: \"widget-calendar\", style },\n+ createElement(DragAndDropCalendar, {\n+ events: [],\n+ allDayAccessor: jasmine.any(Function),\n+ eventPropGetter: jasmine.any(Function),\n+ defaultView: \"month\",\n+ formats,\n+ messages: \"\",\n+ views: [],\n+ popup: true,\n+ selectable: true,\n+ step: 60,\n+ showMultiDayTimes: true,\n+ onEventDrop: jasmine.any(Function),\n+ onEventResize: jasmine.any(Function),\n+ onSelectEvent: jasmine.any(Function),\n+ onSelectSlot: jasmine.any(Function)\n+ }),\n+ createElement(Alert, { className: \"widget-calendar-alert\" })\n+ )\n+ );\n+ });\n+\n+ it(\"should render a structure correctly with percentage of parent\", () => {\n+ const calendarComponent = renderCalendar(calendarProps);\n+ const style = { width: \"100%\", height: \"580%\" };\n+ calendarComponent.setProps({\n+ heightUnit: \"percentageOfParent\",\n+ widthUnit: \"percentage\"\n+ });\n+\n+ expect(calendarComponent).toBeElement(\n+ createElement(\"div\", { className: \"widget-calendar\", style },\n+ createElement(DragAndDropCalendar, {\n+ events: [],\n+ allDayAccessor: jasmine.any(Function),\n+ eventPropGetter: jasmine.any(Function),\n+ defaultView: \"month\",\n+ formats,\n+ messages: \"\",\n+ views: [],\n+ popup: true,\n+ selectable: true,\n+ step: 60,\n+ showMultiDayTimes: true,\n+ onEventDrop: jasmine.any(Function) as any,\n+ onEventResize: jasmine.any(Function) as any,\n+ onSelectEvent: jasmine.any(Function) as any,\n+ onSelectSlot: jasmine.any(Function) as any\n+ }),\n+ createElement(Alert, { className: \"widget-calendar-alert\" })\n+ )\n+ );\n+ });\n+\n+ it(\"should render a structure correctly with custom formats\", () => {\n+ const calendarComponent = renderCalendar(calendarProps);\n+ const dayFormat = (calendarComponent.instance() as any).dayFormat();\n+ const weekdayFormat = (calendarComponent.instance() as any).weekdayFormat();\n+ const timeGutterFormat = (calendarComponent.instance() as any).timeGutterFormat();\n+ const monthHeaderFormat = (calendarComponent.instance() as any).monthHeaderFormat();\n+ const dayHeaderFormat = (calendarComponent.instance() as any).dayHeaderFormat();\n+ const newProps = { events: [] };\n+ (calendarComponent.instance() as any).componentWillReceiveProps(newProps);\n+ const style = { width: \"100%\", height: \"580px\" };\n+ const customFormats = {\n+ dayFormat,\n+ weekdayFormat,\n+ timeGutterFormat,\n+ monthHeaderFormat,\n+ dayHeaderFormat\n+ };\n+\n+ expect(calendarComponent).toBeElement(\n+ createElement(\"div\", { className: \"widget-calendar\", style },\n+ createElement(DragAndDropCalendar, {\n+ events: [],\n+ allDayAccessor: jasmine.any(Function),\n+ eventPropGetter: jasmine.any(Function),\n+ defaultView: \"month\",\n+ formats: customFormats,\n+ messages: \"\",\n+ views: [],\n+ popup: true,\n+ selectable: true,\n+ step: 60,\n+ showMultiDayTimes: true,\n+ onEventDrop: jasmine.any(Function),\n+ onEventResize: jasmine.any(Function),\n+ onSelectEvent: jasmine.any(Function),\n+ onSelectSlot: jasmine.any(Function)\n+ }),\n+ createElement(Alert, { className: \"widget-calendar-alert\" })\n+ )\n+ );\n+ });\n+\n+ it(\"should renders all day events\", () => {\n+ const calendarComponent = renderCalendar(calendarProps);\n+ const style = { width: \"100%\", height: \"580px\" };\n+ const event = { allDay: true };\n+ (calendarComponent.instance() as any).allDayAccessor(event);\n+\n+ expect(calendarComponent).toBeElement(\n+ createElement(\"div\", { className: \"widget-calendar\", style },\n+ createElement(DragAndDropCalendar, {\n+ events: [],\n+ allDayAccessor: jasmine.any(Function),\n+ eventPropGetter: jasmine.any(Function),\n+ defaultView: \"month\",\n+ formats,\n+ messages: \"\",\n+ views: [],\n+ popup: true,\n+ selectable: true,\n+ step: 60,\n+ showMultiDayTimes: true,\n+ onEventDrop: jasmine.any(Function),\n+ onEventResize: jasmine.any(Function),\n+ onSelectEvent: jasmine.any(Function),\n+ onSelectSlot: jasmine.any(Function)\n+ }),\n+ createElement(Alert, { className: \"widget-calendar-alert\" })\n+ )\n+ );\n+ });\n+\n+ it(\"renders events with custom colors\", () => {\n+ const calendarComponent = renderCalendar(calendarProps);\n+ const style = { width: \"100%\", height: \"580px\" };\n+ const events = { color: \"red\" };\n+ (calendarComponent.instance() as any).eventColor(events);\n+\n+ expect(calendarComponent).toBeElement(\n+ createElement(\"div\", { className: \"widget-calendar\", style },\n+ createElement(DragAndDropCalendar, {\n+ events: [],\n+ allDayAccessor: jasmine.any(Function),\n+ eventPropGetter: jasmine.any(Function),\n+ defaultView: \"month\",\n+ formats,\n+ messages: \"\",\n+ views: [],\n+ popup: true,\n+ selectable: true,\n+ step: 60,\n+ showMultiDayTimes: true,\n+ onEventDrop: jasmine.any(Function),\n+ onEventResize: jasmine.any(Function),\n+ onSelectEvent: jasmine.any(Function),\n+ onSelectSlot: jasmine.any(Function)\n+ }),\n+ createElement(Alert, { className: \"widget-calendar-alert\" })\n+ )\n+ );\n+ });\n+\n+ describe(\"event handler\", () => {\n+ it(\"#onSelectSlot() calls the parent onSelectSlot handler\", () => {\n+ calendarProps.onSelectSlotAction = jasmine.createSpy(\"onClick\");\n+ const calendarComponent = renderCalendar(calendarProps);\n+ (calendarComponent.instance() as any).onSelectSlot();\n+\n+ expect(calendarProps.onSelectSlotAction).toHaveBeenCalled();\n+ });\n+\n+ it(\"#onSelectEvent() calls the parent onSelectEvent handler\", () => {\n+ calendarProps.onSelectEventAction = jasmine.createSpy(\"onClick\");\n+ const calendarComponent = renderCalendar(calendarProps);\n+ (calendarComponent.instance() as any).onSelectEvent();\n+\n+ expect(calendarProps.onSelectEventAction).toHaveBeenCalled();\n+ });\n+\n+ it(\"#onEventDrop() calls the parent onEventDrop handler when the dates are different\", () => {\n+ const eventInfo = {\n+ start: new Date(),\n+ event: {\n+ start: new Date((new Date()).valueOf() + 1000 * 3600 * 24)\n+ }\n+ };\n+ calendarProps.onEventDropAction = jasmine.createSpy(\"onDrop\");\n+ const calendarComponent = renderCalendar(calendarProps);\n+ (calendarComponent.instance() as any).onEventDrop(eventInfo);","path":"src/components/__tests__/Calendar.spec.ts","position":302,"original_position":296,"commit_id":"45a6879061fcb079c93ed8fe7db47be32e55a9d7","original_commit_id":"42c572ba03f56e9b5dbe24ad664690686b50ffd3","user":{"login":"jseremba","id":8972657,"node_id":"MDQ6VXNlcjg5NzI2NTc=","avatar_url":"https://avatars1.githubusercontent.com/u/8972657?v=4","gravatar_id":"","url":"https://api.github.com/users/jseremba","html_url":"https://github.com/jseremba","followers_url":"https://api.github.com/users/jseremba/followers","following_url":"https://api.github.com/users/jseremba/following{/other_user}","gists_url":"https://api.github.com/users/jseremba/gists{/gist_id}","starred_url":"https://api.github.com/users/jseremba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jseremba/subscriptions","organizations_url":"https://api.github.com/users/jseremba/orgs","repos_url":"https://api.github.com/users/jseremba/repos","events_url":"https://api.github.com/users/jseremba/events{/privacy}","received_events_url":"https://api.github.com/users/jseremba/received_events","type":"User","site_admin":false},"body":"I suggest u declare a `calendarComponent.instance() as any` within a jasmine `beforeAll` function and re-use it instead....its over repeated.","created_at":"2018-07-24T11:17:20Z","updated_at":"2018-07-24T11:50:49Z","html_url":"https://github.com/FlockOfBirds/calendar/pull/1#discussion_r204716079","pull_request_url":"https://api.github.com/repos/FlockOfBirds/calendar/pulls/1","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/FlockOfBirds/calendar/pulls/comments/204716079"},"html":{"href":"https://github.com/FlockOfBirds/calendar/pull/1#discussion_r204716079"},"pull_request":{"href":"https://api.github.com/repos/FlockOfBirds/calendar/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/FlockOfBirds/calendar/pulls/1","id":195449381,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1NDQ5Mzgx","html_url":"https://github.com/FlockOfBirds/calendar/pull/1","diff_url":"https://github.com/FlockOfBirds/calendar/pull/1.diff","patch_url":"https://github.com/FlockOfBirds/calendar/pull/1.patch","issue_url":"https://api.github.com/repos/FlockOfBirds/calendar/issues/1","number":1,"state":"open","locked":false,"title":"Feature/initial","user":{"login":"McDoyen","id":19818344,"node_id":"MDQ6VXNlcjE5ODE4MzQ0","avatar_url":"https://avatars3.githubusercontent.com/u/19818344?v=4","gravatar_id":"","url":"https://api.github.com/users/McDoyen","html_url":"https://github.com/McDoyen","followers_url":"https://api.github.com/users/McDoyen/followers","following_url":"https://api.github.com/users/McDoyen/following{/other_user}","gists_url":"https://api.github.com/users/McDoyen/gists{/gist_id}","starred_url":"https://api.github.com/users/McDoyen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/McDoyen/subscriptions","organizations_url":"https://api.github.com/users/McDoyen/orgs","repos_url":"https://api.github.com/users/McDoyen/repos","events_url":"https://api.github.com/users/McDoyen/events{/privacy}","received_events_url":"https://api.github.com/users/McDoyen/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-06-18T08:11:36Z","updated_at":"2018-07-24T11:50:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"391d1291e85c454f21200aeaff6a832c96b350da","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/FlockOfBirds/calendar/pulls/1/commits","review_comments_url":"https://api.github.com/repos/FlockOfBirds/calendar/pulls/1/comments","review_comment_url":"https://api.github.com/repos/FlockOfBirds/calendar/pulls/comments{/number}","comments_url":"https://api.github.com/repos/FlockOfBirds/calendar/issues/1/comments","statuses_url":"https://api.github.com/repos/FlockOfBirds/calendar/statuses/45a6879061fcb079c93ed8fe7db47be32e55a9d7","head":{"label":"FlockOfBirds:feature/initial","ref":"feature/initial","sha":"45a6879061fcb079c93ed8fe7db47be32e55a9d7","user":{"login":"FlockOfBirds","id":22542218,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyNTQyMjE4","avatar_url":"https://avatars2.githubusercontent.com/u/22542218?v=4","gravatar_id":"","url":"https://api.github.com/users/FlockOfBirds","html_url":"https://github.com/FlockOfBirds","followers_url":"https://api.github.com/users/FlockOfBirds/followers","following_url":"https://api.github.com/users/FlockOfBirds/following{/other_user}","gists_url":"https://api.github.com/users/FlockOfBirds/gists{/gist_id}","starred_url":"https://api.github.com/users/FlockOfBirds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FlockOfBirds/subscriptions","organizations_url":"https://api.github.com/users/FlockOfBirds/orgs","repos_url":"https://api.github.com/users/FlockOfBirds/repos","events_url":"https://api.github.com/users/FlockOfBirds/events{/privacy}","received_events_url":"https://api.github.com/users/FlockOfBirds/received_events","type":"Organization","site_admin":false},"repo":{"id":136609634,"node_id":"MDEwOlJlcG9zaXRvcnkxMzY2MDk2MzQ=","name":"calendar","full_name":"FlockOfBirds/calendar","owner":{"login":"FlockOfBirds","id":22542218,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyNTQyMjE4","avatar_url":"https://avatars2.githubusercontent.com/u/22542218?v=4","gravatar_id":"","url":"https://api.github.com/users/FlockOfBirds","html_url":"https://github.com/FlockOfBirds","followers_url":"https://api.github.com/users/FlockOfBirds/followers","following_url":"https://api.github.com/users/FlockOfBirds/following{/other_user}","gists_url":"https://api.github.com/users/FlockOfBirds/gists{/gist_id}","starred_url":"https://api.github.com/users/FlockOfBirds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FlockOfBirds/subscriptions","organizations_url":"https://api.github.com/users/FlockOfBirds/orgs","repos_url":"https://api.github.com/users/FlockOfBirds/repos","events_url":"https://api.github.com/users/FlockOfBirds/events{/privacy}","received_events_url":"https://api.github.com/users/FlockOfBirds/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/FlockOfBirds/calendar","description":null,"fork":true,"url":"https://api.github.com/repos/FlockOfBirds/calendar","forks_url":"https://api.github.com/repos/FlockOfBirds/calendar/forks","keys_url":"https://api.github.com/repos/FlockOfBirds/calendar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FlockOfBirds/calendar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FlockOfBirds/calendar/teams","hooks_url":"https://api.github.com/repos/FlockOfBirds/calendar/hooks","issue_events_url":"https://api.github.com/repos/FlockOfBirds/calendar/issues/events{/number}","events_url":"https://api.github.com/repos/FlockOfBirds/calendar/events","assignees_url":"https://api.github.com/repos/FlockOfBirds/calendar/assignees{/user}","branches_url":"https://api.github.com/repos/FlockOfBirds/calendar/branches{/branch}","tags_url":"https://api.github.com/repos/FlockOfBirds/calendar/tags","blobs_url":"https://api.github.com/repos/FlockOfBirds/calendar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FlockOfBirds/calendar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FlockOfBirds/calendar/git/refs{/sha}","trees_url":"https://api.github.com/repos/FlockOfBirds/calendar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FlockOfBirds/calendar/statuses/{sha}","languages_url":"https://api.github.com/repos/FlockOfBirds/calendar/languages","stargazers_url":"https://api.github.com/repos/FlockOfBirds/calendar/stargazers","contributors_url":"https://api.github.com/repos/FlockOfBirds/calendar/contributors","subscribers_url":"https://api.github.com/repos/FlockOfBirds/calendar/subscribers","subscription_url":"https://api.github.com/repos/FlockOfBirds/calendar/subscription","commits_url":"https://api.github.com/repos/FlockOfBirds/calendar/commits{/sha}","git_commits_url":"https://api.github.com/repos/FlockOfBirds/calendar/git/commits{/sha}","comments_url":"https://api.github.com/repos/FlockOfBirds/calendar/comments{/number}","issue_comment_url":"https://api.github.com/repos/FlockOfBirds/calendar/issues/comments{/number}","contents_url":"https://api.github.com/repos/FlockOfBirds/calendar/contents/{+path}","compare_url":"https://api.github.com/repos/FlockOfBirds/calendar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FlockOfBirds/calendar/merges","archive_url":"https://api.github.com/repos/FlockOfBirds/calendar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FlockOfBirds/calendar/downloads","issues_url":"https://api.github.com/repos/FlockOfBirds/calendar/issues{/number}","pulls_url":"https://api.github.com/repos/FlockOfBirds/calendar/pulls{/number}","milestones_url":"https://api.github.com/repos/FlockOfBirds/calendar/milestones{/number}","notifications_url":"https://api.github.com/repos/FlockOfBirds/calendar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FlockOfBirds/calendar/labels{/name}","releases_url":"https://api.github.com/repos/FlockOfBirds/calendar/releases{/id}","deployments_url":"https://api.github.com/repos/FlockOfBirds/calendar/deployments","created_at":"2018-06-08T11:22:39Z","updated_at":"2018-06-08T11:22:41Z","pushed_at":"2018-07-24T11:19:55Z","git_url":"git://github.com/FlockOfBirds/calendar.git","ssh_url":"[email protected]:FlockOfBirds/calendar.git","clone_url":"https://github.com/FlockOfBirds/calendar.git","svn_url":"https://github.com/FlockOfBirds/calendar","homepage":null,"size":2271,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"FlockOfBirds:master","ref":"master","sha":"f84cb061a1af33da105602fe845dc5aae79af891","user":{"login":"FlockOfBirds","id":22542218,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyNTQyMjE4","avatar_url":"https://avatars2.githubusercontent.com/u/22542218?v=4","gravatar_id":"","url":"https://api.github.com/users/FlockOfBirds","html_url":"https://github.com/FlockOfBirds","followers_url":"https://api.github.com/users/FlockOfBirds/followers","following_url":"https://api.github.com/users/FlockOfBirds/following{/other_user}","gists_url":"https://api.github.com/users/FlockOfBirds/gists{/gist_id}","starred_url":"https://api.github.com/users/FlockOfBirds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FlockOfBirds/subscriptions","organizations_url":"https://api.github.com/users/FlockOfBirds/orgs","repos_url":"https://api.github.com/users/FlockOfBirds/repos","events_url":"https://api.github.com/users/FlockOfBirds/events{/privacy}","received_events_url":"https://api.github.com/users/FlockOfBirds/received_events","type":"Organization","site_admin":false},"repo":{"id":136609634,"node_id":"MDEwOlJlcG9zaXRvcnkxMzY2MDk2MzQ=","name":"calendar","full_name":"FlockOfBirds/calendar","owner":{"login":"FlockOfBirds","id":22542218,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyNTQyMjE4","avatar_url":"https://avatars2.githubusercontent.com/u/22542218?v=4","gravatar_id":"","url":"https://api.github.com/users/FlockOfBirds","html_url":"https://github.com/FlockOfBirds","followers_url":"https://api.github.com/users/FlockOfBirds/followers","following_url":"https://api.github.com/users/FlockOfBirds/following{/other_user}","gists_url":"https://api.github.com/users/FlockOfBirds/gists{/gist_id}","starred_url":"https://api.github.com/users/FlockOfBirds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FlockOfBirds/subscriptions","organizations_url":"https://api.github.com/users/FlockOfBirds/orgs","repos_url":"https://api.github.com/users/FlockOfBirds/repos","events_url":"https://api.github.com/users/FlockOfBirds/events{/privacy}","received_events_url":"https://api.github.com/users/FlockOfBirds/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/FlockOfBirds/calendar","description":null,"fork":true,"url":"https://api.github.com/repos/FlockOfBirds/calendar","forks_url":"https://api.github.com/repos/FlockOfBirds/calendar/forks","keys_url":"https://api.github.com/repos/FlockOfBirds/calendar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FlockOfBirds/calendar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FlockOfBirds/calendar/teams","hooks_url":"https://api.github.com/repos/FlockOfBirds/calendar/hooks","issue_events_url":"https://api.github.com/repos/FlockOfBirds/calendar/issues/events{/number}","events_url":"https://api.github.com/repos/FlockOfBirds/calendar/events","assignees_url":"https://api.github.com/repos/FlockOfBirds/calendar/assignees{/user}","branches_url":"https://api.github.com/repos/FlockOfBirds/calendar/branches{/branch}","tags_url":"https://api.github.com/repos/FlockOfBirds/calendar/tags","blobs_url":"https://api.github.com/repos/FlockOfBirds/calendar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FlockOfBirds/calendar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FlockOfBirds/calendar/git/refs{/sha}","trees_url":"https://api.github.com/repos/FlockOfBirds/calendar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FlockOfBirds/calendar/statuses/{sha}","languages_url":"https://api.github.com/repos/FlockOfBirds/calendar/languages","stargazers_url":"https://api.github.com/repos/FlockOfBirds/calendar/stargazers","contributors_url":"https://api.github.com/repos/FlockOfBirds/calendar/contributors","subscribers_url":"https://api.github.com/repos/FlockOfBirds/calendar/subscribers","subscription_url":"https://api.github.com/repos/FlockOfBirds/calendar/subscription","commits_url":"https://api.github.com/repos/FlockOfBirds/calendar/commits{/sha}","git_commits_url":"https://api.github.com/repos/FlockOfBirds/calendar/git/commits{/sha}","comments_url":"https://api.github.com/repos/FlockOfBirds/calendar/comments{/number}","issue_comment_url":"https://api.github.com/repos/FlockOfBirds/calendar/issues/comments{/number}","contents_url":"https://api.github.com/repos/FlockOfBirds/calendar/contents/{+path}","compare_url":"https://api.github.com/repos/FlockOfBirds/calendar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FlockOfBirds/calendar/merges","archive_url":"https://api.github.com/repos/FlockOfBirds/calendar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FlockOfBirds/calendar/downloads","issues_url":"https://api.github.com/repos/FlockOfBirds/calendar/issues{/number}","pulls_url":"https://api.github.com/repos/FlockOfBirds/calendar/pulls{/number}","milestones_url":"https://api.github.com/repos/FlockOfBirds/calendar/milestones{/number}","notifications_url":"https://api.github.com/repos/FlockOfBirds/calendar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FlockOfBirds/calendar/labels{/name}","releases_url":"https://api.github.com/repos/FlockOfBirds/calendar/releases{/id}","deployments_url":"https://api.github.com/repos/FlockOfBirds/calendar/deployments","created_at":"2018-06-08T11:22:39Z","updated_at":"2018-06-08T11:22:41Z","pushed_at":"2018-07-24T11:19:55Z","git_url":"git://github.com/FlockOfBirds/calendar.git","ssh_url":"[email protected]:FlockOfBirds/calendar.git","clone_url":"https://github.com/FlockOfBirds/calendar.git","svn_url":"https://github.com/FlockOfBirds/calendar","homepage":null,"size":2271,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/FlockOfBirds/calendar/pulls/1"},"html":{"href":"https://github.com/FlockOfBirds/calendar/pull/1"},"issue":{"href":"https://api.github.com/repos/FlockOfBirds/calendar/issues/1"},"comments":{"href":"https://api.github.com/repos/FlockOfBirds/calendar/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/FlockOfBirds/calendar/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/FlockOfBirds/calendar/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/FlockOfBirds/calendar/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/FlockOfBirds/calendar/statuses/45a6879061fcb079c93ed8fe7db47be32e55a9d7"}},"author_association":"NONE"}} | {
"id": 136609634,
"name": "FlockOfBirds/calendar",
"url": "https://api.github.com/repos/FlockOfBirds/calendar"
} | {
"id": 8972657,
"login": "jseremba",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/8972657?",
"url": "https://api.github.com/users/jseremba"
} | {
"id": 22542218,
"login": "FlockOfBirds",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/22542218?",
"url": "https://api.github.com/orgs/FlockOfBirds"
} | 2018-07-24T11:17:20 | 8009643633 | {"actor":{"display_login":"jseremba"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/corda/corda/pulls/comments/183652764","pull_request_review_id":114688793,"id":183652764,"diff_hunk":"@@ -0,0 +1,137 @@\n+package net.corda.nodeapi.internal.network\n+\n+import net.corda.core.contracts.ContractClassName\n+import net.corda.core.crypto.SecureHash\n+import net.corda.core.node.services.AttachmentId\n+import net.corda.nodeapi.internal.ContractsJar\n+import net.corda.testing.common.internal.testNetworkParameters\n+import org.assertj.core.api.Assertions.assertThat\n+import org.junit.Test\n+\n+class NetworkBootstrapperTest {\n+ @Test\n+ fun `no jars against empty whitelist`() {\n+ val whitelist = generateWhitelist(emptyMap(), emptyList(), emptyList())\n+ assertThat(whitelist).isEmpty()\n+ }\n+\n+ @Test\n+ fun `no jars against single whitelist`() {\n+ val existingWhitelist = mapOf(\"class1\" to listOf(SecureHash.randomSHA256()))\n+ val newWhitelist = generateWhitelist(existingWhitelist, emptyList(), emptyList())\n+ assertThat(newWhitelist).isEqualTo(existingWhitelist)\n+ }\n+\n+ @Test\n+ fun `empty jar against empty whitelist`() {\n+ val whitelist = generateWhitelist(emptyMap(), emptyList(), listOf(TestContractsJar(contractClassNames = emptyList())))\n+ assertThat(whitelist).isEmpty()\n+ }\n+\n+ @Test\n+ fun `empty jar against single whitelist`() {\n+ val existingWhitelist = mapOf(\"class1\" to listOf(SecureHash.randomSHA256()))\n+ val newWhitelist = generateWhitelist(existingWhitelist, emptyList(), listOf(TestContractsJar(contractClassNames = emptyList())))\n+ assertThat(newWhitelist).isEqualTo(existingWhitelist)\n+ }\n+\n+ @Test\n+ fun `jar with single contract against empty whitelist`() {\n+ val contractsJar = TestContractsJar(contractClassNames = listOf(\"class1\"))\n+ val whitelist = generateWhitelist(emptyMap(), emptyList(), listOf(contractsJar))\n+ assertThat(whitelist).isEqualTo(mapOf(\n+ \"class1\" to listOf(contractsJar.hash)\n+ ))\n+ }\n+\n+ @Test\n+ fun `single contract jar against single whitelist of different contract`() {\n+ val class1JarHash = SecureHash.randomSHA256()\n+ val existingWhitelist = mapOf(\"class1\" to listOf(class1JarHash))\n+ val contractsJar = TestContractsJar(contractClassNames = listOf(\"class2\"))\n+ val whitelist = generateWhitelist(existingWhitelist, emptyList(), listOf(contractsJar))\n+ assertThat(whitelist).isEqualTo(mapOf(\n+ \"class1\" to listOf(class1JarHash),\n+ \"class2\" to listOf(contractsJar.hash)\n+ ))\n+ }\n+\n+ @Test\n+ fun `same jar with single contract`() {\n+ val jarHash = SecureHash.randomSHA256()\n+ val existingWhitelist = mapOf(\"class1\" to listOf(jarHash))\n+ val contractsJar = TestContractsJar(hash = jarHash, contractClassNames = listOf(\"class1\"))\n+ val newWhitelist = generateWhitelist(existingWhitelist, emptyList(), listOf(contractsJar))\n+ assertThat(newWhitelist).isEqualTo(existingWhitelist)\n+ }\n+\n+ @Test\n+ fun `jar with updated contract`() {\n+ val previousJarHash = SecureHash.randomSHA256()\n+ val existingWhitelist = mapOf(\"class1\" to listOf(previousJarHash))\n+ val newContractsJar = TestContractsJar(contractClassNames = listOf(\"class1\"))\n+ val newWhitelist = generateWhitelist(existingWhitelist, emptyList(), listOf(newContractsJar))\n+ assertThat(newWhitelist).isEqualTo(mapOf(\n+ \"class1\" to listOf(previousJarHash, newContractsJar.hash)\n+ ))\n+ }\n+\n+ @Test\n+ fun `jar with one existing contract and one new one`() {\n+ val previousJarHash = SecureHash.randomSHA256()\n+ val existingWhitelist = mapOf(\"class1\" to listOf(previousJarHash))\n+ val newContractsJar = TestContractsJar(contractClassNames = listOf(\"class1\", \"class2\"))\n+ val newWhitelist = generateWhitelist(existingWhitelist, emptyList(), listOf(newContractsJar))\n+ assertThat(newWhitelist).isEqualTo(mapOf(\n+ \"class1\" to listOf(previousJarHash, newContractsJar.hash),\n+ \"class2\" to listOf(newContractsJar.hash)\n+ ))\n+ }\n+\n+ @Test\n+ fun `two versions of the same contract`() {\n+ val version1Jar = TestContractsJar(contractClassNames = listOf(\"class1\"))\n+ val version2Jar = TestContractsJar(contractClassNames = listOf(\"class1\"))\n+ val newWhitelist = generateWhitelist(emptyMap(), emptyList(), listOf(version1Jar, version2Jar))\n+ assertThat(newWhitelist).isEqualTo(mapOf(\n+ \"class1\" to listOf(version1Jar.hash, version2Jar.hash)\n+ ))\n+ }\n+\n+ @Test\n+ fun `jar with single new contract that's excluded`() {\n+ val whitelist = generateWhitelist(emptyMap(), listOf(\"class1\"), listOf(TestContractsJar(contractClassNames = listOf(\"class1\"))))\n+ assertThat(whitelist).isEmpty()\n+ }\n+\n+ @Test\n+ fun `jar with two new contracts, one of which is excluded`() {\n+ val contractsJar = TestContractsJar(contractClassNames = listOf(\"class1\", \"class2\"))\n+ val whitelist = generateWhitelist(emptyMap(), listOf(\"class1\"), listOf(contractsJar))\n+ assertThat(whitelist).isEqualTo(mapOf(\n+ \"class2\" to listOf(contractsJar.hash)\n+ ))\n+ }\n+\n+ @Test\n+ fun `jar with updated contract but it's excluded`() {","path":"node-api/src/test/kotlin/net/corda/nodeapi/internal/network/NetworkBootstrapperTest.kt","position":119,"original_position":117,"commit_id":"1c1128c62616810183c649adfd891d7a6dbf7a09","original_commit_id":"f48648c506c8d337f75df2bf80384aea46c2fc63","user":{"login":"shamsasari","id":3883563,"avatar_url":"https://avatars3.githubusercontent.com/u/3883563?v=4","gravatar_id":"","url":"https://api.github.com/users/shamsasari","html_url":"https://github.com/shamsasari","followers_url":"https://api.github.com/users/shamsasari/followers","following_url":"https://api.github.com/users/shamsasari/following{/other_user}","gists_url":"https://api.github.com/users/shamsasari/gists{/gist_id}","starred_url":"https://api.github.com/users/shamsasari/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shamsasari/subscriptions","organizations_url":"https://api.github.com/users/shamsasari/orgs","repos_url":"https://api.github.com/users/shamsasari/repos","events_url":"https://api.github.com/users/shamsasari/events{/privacy}","received_events_url":"https://api.github.com/users/shamsasari/received_events","type":"User","site_admin":false},"body":"No, what you said makes sense. It's safer anyway. If it turns out it's not what users want then it can be changed.","created_at":"2018-04-24T08:53:21Z","updated_at":"2018-04-24T08:53:21Z","html_url":"https://github.com/corda/corda/pull/2980#discussion_r183652764","pull_request_url":"https://api.github.com/repos/corda/corda/pulls/2980","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/corda/corda/pulls/comments/183652764"},"html":{"href":"https://github.com/corda/corda/pull/2980#discussion_r183652764"},"pull_request":{"href":"https://api.github.com/repos/corda/corda/pulls/2980"}},"in_reply_to_id":183049624},"pull_request":{"url":"https://api.github.com/repos/corda/corda/pulls/2980","id":182761668,"html_url":"https://github.com/corda/corda/pull/2980","diff_url":"https://github.com/corda/corda/pull/2980.diff","patch_url":"https://github.com/corda/corda/pull/2980.patch","issue_url":"https://api.github.com/repos/corda/corda/issues/2980","number":2980,"state":"open","locked":false,"title":"CORDA-1325: Bootstrapper unable to whitelist two versions of the same…","user":{"login":"shamsasari","id":3883563,"avatar_url":"https://avatars3.githubusercontent.com/u/3883563?v=4","gravatar_id":"","url":"https://api.github.com/users/shamsasari","html_url":"https://github.com/shamsasari","followers_url":"https://api.github.com/users/shamsasari/followers","following_url":"https://api.github.com/users/shamsasari/following{/other_user}","gists_url":"https://api.github.com/users/shamsasari/gists{/gist_id}","starred_url":"https://api.github.com/users/shamsasari/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shamsasari/subscriptions","organizations_url":"https://api.github.com/users/shamsasari/orgs","repos_url":"https://api.github.com/users/shamsasari/repos","events_url":"https://api.github.com/users/shamsasari/events{/privacy}","received_events_url":"https://api.github.com/users/shamsasari/received_events","type":"User","site_admin":false},"body":"… contract simultaneously\r\n\r\nAlso added unit tests\r\n\r\n","created_at":"2018-04-19T12:35:39Z","updated_at":"2018-04-24T08:53:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c8e3c94f6dc11bda1fc16e6d233664d8550e3928","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/corda/corda/pulls/2980/commits","review_comments_url":"https://api.github.com/repos/corda/corda/pulls/2980/comments","review_comment_url":"https://api.github.com/repos/corda/corda/pulls/comments{/number}","comments_url":"https://api.github.com/repos/corda/corda/issues/2980/comments","statuses_url":"https://api.github.com/repos/corda/corda/statuses/1c1128c62616810183c649adfd891d7a6dbf7a09","head":{"label":"corda:shams-whitelist-two-versions","ref":"shams-whitelist-two-versions","sha":"1c1128c62616810183c649adfd891d7a6dbf7a09","user":{"login":"corda","id":22600631,"avatar_url":"https://avatars1.githubusercontent.com/u/22600631?v=4","gravatar_id":"","url":"https://api.github.com/users/corda","html_url":"https://github.com/corda","followers_url":"https://api.github.com/users/corda/followers","following_url":"https://api.github.com/users/corda/following{/other_user}","gists_url":"https://api.github.com/users/corda/gists{/gist_id}","starred_url":"https://api.github.com/users/corda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/corda/subscriptions","organizations_url":"https://api.github.com/users/corda/orgs","repos_url":"https://api.github.com/users/corda/repos","events_url":"https://api.github.com/users/corda/events{/privacy}","received_events_url":"https://api.github.com/users/corda/received_events","type":"Organization","site_admin":false},"repo":{"id":70137417,"name":"corda","full_name":"corda/corda","owner":{"login":"corda","id":22600631,"avatar_url":"https://avatars1.githubusercontent.com/u/22600631?v=4","gravatar_id":"","url":"https://api.github.com/users/corda","html_url":"https://github.com/corda","followers_url":"https://api.github.com/users/corda/followers","following_url":"https://api.github.com/users/corda/following{/other_user}","gists_url":"https://api.github.com/users/corda/gists{/gist_id}","starred_url":"https://api.github.com/users/corda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/corda/subscriptions","organizations_url":"https://api.github.com/users/corda/orgs","repos_url":"https://api.github.com/users/corda/repos","events_url":"https://api.github.com/users/corda/events{/privacy}","received_events_url":"https://api.github.com/users/corda/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/corda/corda","description":"Corda is a distributed ledger platform designed to record, manage and automate legal agreements between business partners. Designed by (and for) the world's largest financial institutions yet with applications in multiple industries. It offers a unique response to the privacy and scalability challenges facing decentralised applications.","fork":false,"url":"https://api.github.com/repos/corda/corda","forks_url":"https://api.github.com/repos/corda/corda/forks","keys_url":"https://api.github.com/repos/corda/corda/keys{/key_id}","collaborators_url":"https://api.github.com/repos/corda/corda/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/corda/corda/teams","hooks_url":"https://api.github.com/repos/corda/corda/hooks","issue_events_url":"https://api.github.com/repos/corda/corda/issues/events{/number}","events_url":"https://api.github.com/repos/corda/corda/events","assignees_url":"https://api.github.com/repos/corda/corda/assignees{/user}","branches_url":"https://api.github.com/repos/corda/corda/branches{/branch}","tags_url":"https://api.github.com/repos/corda/corda/tags","blobs_url":"https://api.github.com/repos/corda/corda/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/corda/corda/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/corda/corda/git/refs{/sha}","trees_url":"https://api.github.com/repos/corda/corda/git/trees{/sha}","statuses_url":"https://api.github.com/repos/corda/corda/statuses/{sha}","languages_url":"https://api.github.com/repos/corda/corda/languages","stargazers_url":"https://api.github.com/repos/corda/corda/stargazers","contributors_url":"https://api.github.com/repos/corda/corda/contributors","subscribers_url":"https://api.github.com/repos/corda/corda/subscribers","subscription_url":"https://api.github.com/repos/corda/corda/subscription","commits_url":"https://api.github.com/repos/corda/corda/commits{/sha}","git_commits_url":"https://api.github.com/repos/corda/corda/git/commits{/sha}","comments_url":"https://api.github.com/repos/corda/corda/comments{/number}","issue_comment_url":"https://api.github.com/repos/corda/corda/issues/comments{/number}","contents_url":"https://api.github.com/repos/corda/corda/contents/{+path}","compare_url":"https://api.github.com/repos/corda/corda/compare/{base}...{head}","merges_url":"https://api.github.com/repos/corda/corda/merges","archive_url":"https://api.github.com/repos/corda/corda/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/corda/corda/downloads","issues_url":"https://api.github.com/repos/corda/corda/issues{/number}","pulls_url":"https://api.github.com/repos/corda/corda/pulls{/number}","milestones_url":"https://api.github.com/repos/corda/corda/milestones{/number}","notifications_url":"https://api.github.com/repos/corda/corda/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/corda/corda/labels{/name}","releases_url":"https://api.github.com/repos/corda/corda/releases{/id}","deployments_url":"https://api.github.com/repos/corda/corda/deployments","created_at":"2016-10-06T08:46:29Z","updated_at":"2018-04-24T08:01:42Z","pushed_at":"2018-04-24T08:49:18Z","git_url":"git://github.com/corda/corda.git","ssh_url":"[email protected]:corda/corda.git","clone_url":"https://github.com/corda/corda.git","svn_url":"https://github.com/corda/corda","homepage":"https://www.corda.net","size":120200,"stargazers_count":1805,"watchers_count":1805,"language":"Kotlin","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":469,"mirror_url":null,"archived":false,"open_issues_count":135,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":469,"open_issues":135,"watchers":1805,"default_branch":"master"}},"base":{"label":"corda:master","ref":"master","sha":"c4ceca378762fe1959f075a1c8b1c301e411b6b8","user":{"login":"corda","id":22600631,"avatar_url":"https://avatars1.githubusercontent.com/u/22600631?v=4","gravatar_id":"","url":"https://api.github.com/users/corda","html_url":"https://github.com/corda","followers_url":"https://api.github.com/users/corda/followers","following_url":"https://api.github.com/users/corda/following{/other_user}","gists_url":"https://api.github.com/users/corda/gists{/gist_id}","starred_url":"https://api.github.com/users/corda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/corda/subscriptions","organizations_url":"https://api.github.com/users/corda/orgs","repos_url":"https://api.github.com/users/corda/repos","events_url":"https://api.github.com/users/corda/events{/privacy}","received_events_url":"https://api.github.com/users/corda/received_events","type":"Organization","site_admin":false},"repo":{"id":70137417,"name":"corda","full_name":"corda/corda","owner":{"login":"corda","id":22600631,"avatar_url":"https://avatars1.githubusercontent.com/u/22600631?v=4","gravatar_id":"","url":"https://api.github.com/users/corda","html_url":"https://github.com/corda","followers_url":"https://api.github.com/users/corda/followers","following_url":"https://api.github.com/users/corda/following{/other_user}","gists_url":"https://api.github.com/users/corda/gists{/gist_id}","starred_url":"https://api.github.com/users/corda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/corda/subscriptions","organizations_url":"https://api.github.com/users/corda/orgs","repos_url":"https://api.github.com/users/corda/repos","events_url":"https://api.github.com/users/corda/events{/privacy}","received_events_url":"https://api.github.com/users/corda/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/corda/corda","description":"Corda is a distributed ledger platform designed to record, manage and automate legal agreements between business partners. Designed by (and for) the world's largest financial institutions yet with applications in multiple industries. It offers a unique response to the privacy and scalability challenges facing decentralised applications.","fork":false,"url":"https://api.github.com/repos/corda/corda","forks_url":"https://api.github.com/repos/corda/corda/forks","keys_url":"https://api.github.com/repos/corda/corda/keys{/key_id}","collaborators_url":"https://api.github.com/repos/corda/corda/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/corda/corda/teams","hooks_url":"https://api.github.com/repos/corda/corda/hooks","issue_events_url":"https://api.github.com/repos/corda/corda/issues/events{/number}","events_url":"https://api.github.com/repos/corda/corda/events","assignees_url":"https://api.github.com/repos/corda/corda/assignees{/user}","branches_url":"https://api.github.com/repos/corda/corda/branches{/branch}","tags_url":"https://api.github.com/repos/corda/corda/tags","blobs_url":"https://api.github.com/repos/corda/corda/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/corda/corda/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/corda/corda/git/refs{/sha}","trees_url":"https://api.github.com/repos/corda/corda/git/trees{/sha}","statuses_url":"https://api.github.com/repos/corda/corda/statuses/{sha}","languages_url":"https://api.github.com/repos/corda/corda/languages","stargazers_url":"https://api.github.com/repos/corda/corda/stargazers","contributors_url":"https://api.github.com/repos/corda/corda/contributors","subscribers_url":"https://api.github.com/repos/corda/corda/subscribers","subscription_url":"https://api.github.com/repos/corda/corda/subscription","commits_url":"https://api.github.com/repos/corda/corda/commits{/sha}","git_commits_url":"https://api.github.com/repos/corda/corda/git/commits{/sha}","comments_url":"https://api.github.com/repos/corda/corda/comments{/number}","issue_comment_url":"https://api.github.com/repos/corda/corda/issues/comments{/number}","contents_url":"https://api.github.com/repos/corda/corda/contents/{+path}","compare_url":"https://api.github.com/repos/corda/corda/compare/{base}...{head}","merges_url":"https://api.github.com/repos/corda/corda/merges","archive_url":"https://api.github.com/repos/corda/corda/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/corda/corda/downloads","issues_url":"https://api.github.com/repos/corda/corda/issues{/number}","pulls_url":"https://api.github.com/repos/corda/corda/pulls{/number}","milestones_url":"https://api.github.com/repos/corda/corda/milestones{/number}","notifications_url":"https://api.github.com/repos/corda/corda/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/corda/corda/labels{/name}","releases_url":"https://api.github.com/repos/corda/corda/releases{/id}","deployments_url":"https://api.github.com/repos/corda/corda/deployments","created_at":"2016-10-06T08:46:29Z","updated_at":"2018-04-24T08:01:42Z","pushed_at":"2018-04-24T08:49:18Z","git_url":"git://github.com/corda/corda.git","ssh_url":"[email protected]:corda/corda.git","clone_url":"https://github.com/corda/corda.git","svn_url":"https://github.com/corda/corda","homepage":"https://www.corda.net","size":120200,"stargazers_count":1805,"watchers_count":1805,"language":"Kotlin","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":469,"mirror_url":null,"archived":false,"open_issues_count":135,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":469,"open_issues":135,"watchers":1805,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/corda/corda/pulls/2980"},"html":{"href":"https://github.com/corda/corda/pull/2980"},"issue":{"href":"https://api.github.com/repos/corda/corda/issues/2980"},"comments":{"href":"https://api.github.com/repos/corda/corda/issues/2980/comments"},"review_comments":{"href":"https://api.github.com/repos/corda/corda/pulls/2980/comments"},"review_comment":{"href":"https://api.github.com/repos/corda/corda/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/corda/corda/pulls/2980/commits"},"statuses":{"href":"https://api.github.com/repos/corda/corda/statuses/1c1128c62616810183c649adfd891d7a6dbf7a09"}},"author_association":"MEMBER"}} | {
"id": 70137417,
"name": "corda/corda",
"url": "https://api.github.com/repos/corda/corda"
} | {
"id": 3883563,
"login": "shamsasari",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3883563?",
"url": "https://api.github.com/users/shamsasari"
} | {
"id": 22600631,
"login": "corda",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/22600631?",
"url": "https://api.github.com/orgs/corda"
} | 2018-04-24T08:53:21 | 7576946590 | {"actor":{"display_login":"shamsasari"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/quicwg/base-drafts/pulls/comments/203421467","pull_request_review_id":138306817,"id":203421467,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMzQyMTQ2Nw==","diff_hunk":"@@ -532,6 +532,86 @@ See {{version-negotiation}} for a description of the version negotiation\n process.\n \n \n+## Retry Packet {#packet-retry}\n+\n+A Retry packet uses the invariant portion of the long packet header with a type\n+value of 0x7E. It carries an address validation token created by the server. It\n+is used by a server that wishes to perform a stateless retry (see\n+{{stateless-retry}}).\n+\n+~~~\n+ 0 1 2 3\n+ 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1\n++-+-+-+-+-+-+-+-+\n+|1| 0x7e |\n++-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+\n+| Version (32) |\n++-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+\n+|DCIL(4)|SCIL(4)|\n++-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+\n+| Destination Connection ID (0/32..144) ...\n++-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+\n+| Source Connection ID (0/32..144) ...\n++-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+\n+| ODCIL(8) | Original Destination Connection ID (*) |\n++-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+\n+| Retry Token (*) ...","path":"draft-ietf-quic-transport.md","position":26,"original_position":27,"commit_id":"cd9cdb48daea18b3f9b10e3459df09e833dcad32","original_commit_id":"bf3f67597f3315018d348bfcf638d8fb9379ff0f","user":{"login":"huitema","id":7464128,"node_id":"MDQ6VXNlcjc0NjQxMjg=","avatar_url":"https://avatars0.githubusercontent.com/u/7464128?v=4","gravatar_id":"","url":"https://api.github.com/users/huitema","html_url":"https://github.com/huitema","followers_url":"https://api.github.com/users/huitema/followers","following_url":"https://api.github.com/users/huitema/following{/other_user}","gists_url":"https://api.github.com/users/huitema/gists{/gist_id}","starred_url":"https://api.github.com/users/huitema/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huitema/subscriptions","organizations_url":"https://api.github.com/users/huitema/orgs","repos_url":"https://api.github.com/users/huitema/repos","events_url":"https://api.github.com/users/huitema/events{/privacy}","received_events_url":"https://api.github.com/users/huitema/received_events","type":"User","site_admin":false},"body":"@Marten: I am not sure this is a valid use case. The main use case for the retry packet is that it is sent by some kind of firewall as part of DOS defense. \r\n\r\nThe VN is sent end-to-end, and already carries a token of sorts with the Source CID. I don't see the use case of sending both retry and VN end to end.","created_at":"2018-07-18T15:19:56Z","updated_at":"2018-07-18T15:19:56Z","html_url":"https://github.com/quicwg/base-drafts/pull/1498#discussion_r203421467","pull_request_url":"https://api.github.com/repos/quicwg/base-drafts/pulls/1498","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/quicwg/base-drafts/pulls/comments/203421467"},"html":{"href":"https://github.com/quicwg/base-drafts/pull/1498#discussion_r203421467"},"pull_request":{"href":"https://api.github.com/repos/quicwg/base-drafts/pulls/1498"}},"in_reply_to_id":199249069},"pull_request":{"url":"https://api.github.com/repos/quicwg/base-drafts/pulls/1498","id":198188370,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4MTg4Mzcw","html_url":"https://github.com/quicwg/base-drafts/pull/1498","diff_url":"https://github.com/quicwg/base-drafts/pull/1498.diff","patch_url":"https://github.com/quicwg/base-drafts/pull/1498.patch","issue_url":"https://api.github.com/repos/quicwg/base-drafts/issues/1498","number":1498,"state":"open","locked":false,"title":"Rework Retry packet","user":{"login":"martinthomson","id":67641,"node_id":"MDQ6VXNlcjY3NjQx","avatar_url":"https://avatars1.githubusercontent.com/u/67641?v=4","gravatar_id":"","url":"https://api.github.com/users/martinthomson","html_url":"https://github.com/martinthomson","followers_url":"https://api.github.com/users/martinthomson/followers","following_url":"https://api.github.com/users/martinthomson/following{/other_user}","gists_url":"https://api.github.com/users/martinthomson/gists{/gist_id}","starred_url":"https://api.github.com/users/martinthomson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinthomson/subscriptions","organizations_url":"https://api.github.com/users/martinthomson/orgs","repos_url":"https://api.github.com/users/martinthomson/repos","events_url":"https://api.github.com/users/martinthomson/events{/privacy}","received_events_url":"https://api.github.com/users/martinthomson/received_events","type":"User","site_admin":false},"body":"This includes several changes:\r\n\r\n* I moved the Retry packet description. It is more like Version Negotiation than Handshake or Initial, so it made sense to move it up.\r\n\r\n* Retry doesn't include a packet number or payload. Like Version Negotiation, it includes a complete definition.\r\n\r\n* As discussed in #1451, this requires a server that might send another Retry to provide a connection ID of at least 8 octets.\r\n\r\n* I clarified the description of fields, expanded the pictures, and made some other editorial tweaks.\r\n\r\nOpen Question: would it make sense to normalize the encoding of Retry and Initial? The former includes a token without a length (because it's the last piece of the packet), whereas the latter includes a length-prefixed token. It might be easier to invert the ODCID and token on Retry. That would make the token processing more consistent. I'm not sure if we want to consider adding a token to 0-RTT and Handshake packets, but that would fully normalize things.\r\n\r\nOther open question (editorial): The variety of long header formats is now a little unwieldy. Should we reduce the long header back to what is in invariants and describe the packet number encoding part as being specific to Initial, Handshake, and 0-RTT? Something for editors to consider.\r\n\r\nCloses #1492, #1451, #1448.","created_at":"2018-06-29T00:40:19Z","updated_at":"2018-07-18T15:19:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c33a59d1eb88082c8fa9b5141781d3b23d219d00","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":481871399,"node_id":"MDU6TGFiZWw0ODE4NzEzOTk=","url":"https://api.github.com/repos/quicwg/base-drafts/labels/-transport","name":"-transport","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/quicwg/base-drafts/pulls/1498/commits","review_comments_url":"https://api.github.com/repos/quicwg/base-drafts/pulls/1498/comments","review_comment_url":"https://api.github.com/repos/quicwg/base-drafts/pulls/comments{/number}","comments_url":"https://api.github.com/repos/quicwg/base-drafts/issues/1498/comments","statuses_url":"https://api.github.com/repos/quicwg/base-drafts/statuses/cd9cdb48daea18b3f9b10e3459df09e833dcad32","head":{"label":"quicwg:move-retry","ref":"move-retry","sha":"cd9cdb48daea18b3f9b10e3459df09e833dcad32","user":{"login":"quicwg","id":22631371,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyNjMxMzcx","avatar_url":"https://avatars3.githubusercontent.com/u/22631371?v=4","gravatar_id":"","url":"https://api.github.com/users/quicwg","html_url":"https://github.com/quicwg","followers_url":"https://api.github.com/users/quicwg/followers","following_url":"https://api.github.com/users/quicwg/following{/other_user}","gists_url":"https://api.github.com/users/quicwg/gists{/gist_id}","starred_url":"https://api.github.com/users/quicwg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quicwg/subscriptions","organizations_url":"https://api.github.com/users/quicwg/orgs","repos_url":"https://api.github.com/users/quicwg/repos","events_url":"https://api.github.com/users/quicwg/events{/privacy}","received_events_url":"https://api.github.com/users/quicwg/received_events","type":"Organization","site_admin":false},"repo":{"id":73779599,"node_id":"MDEwOlJlcG9zaXRvcnk3Mzc3OTU5OQ==","name":"base-drafts","full_name":"quicwg/base-drafts","owner":{"login":"quicwg","id":22631371,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyNjMxMzcx","avatar_url":"https://avatars3.githubusercontent.com/u/22631371?v=4","gravatar_id":"","url":"https://api.github.com/users/quicwg","html_url":"https://github.com/quicwg","followers_url":"https://api.github.com/users/quicwg/followers","following_url":"https://api.github.com/users/quicwg/following{/other_user}","gists_url":"https://api.github.com/users/quicwg/gists{/gist_id}","starred_url":"https://api.github.com/users/quicwg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quicwg/subscriptions","organizations_url":"https://api.github.com/users/quicwg/orgs","repos_url":"https://api.github.com/users/quicwg/repos","events_url":"https://api.github.com/users/quicwg/events{/privacy}","received_events_url":"https://api.github.com/users/quicwg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/quicwg/base-drafts","description":" Internet-Drafts that make up the base QUIC specification","fork":false,"url":"https://api.github.com/repos/quicwg/base-drafts","forks_url":"https://api.github.com/repos/quicwg/base-drafts/forks","keys_url":"https://api.github.com/repos/quicwg/base-drafts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/quicwg/base-drafts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/quicwg/base-drafts/teams","hooks_url":"https://api.github.com/repos/quicwg/base-drafts/hooks","issue_events_url":"https://api.github.com/repos/quicwg/base-drafts/issues/events{/number}","events_url":"https://api.github.com/repos/quicwg/base-drafts/events","assignees_url":"https://api.github.com/repos/quicwg/base-drafts/assignees{/user}","branches_url":"https://api.github.com/repos/quicwg/base-drafts/branches{/branch}","tags_url":"https://api.github.com/repos/quicwg/base-drafts/tags","blobs_url":"https://api.github.com/repos/quicwg/base-drafts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/quicwg/base-drafts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/quicwg/base-drafts/git/refs{/sha}","trees_url":"https://api.github.com/repos/quicwg/base-drafts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/quicwg/base-drafts/statuses/{sha}","languages_url":"https://api.github.com/repos/quicwg/base-drafts/languages","stargazers_url":"https://api.github.com/repos/quicwg/base-drafts/stargazers","contributors_url":"https://api.github.com/repos/quicwg/base-drafts/contributors","subscribers_url":"https://api.github.com/repos/quicwg/base-drafts/subscribers","subscription_url":"https://api.github.com/repos/quicwg/base-drafts/subscription","commits_url":"https://api.github.com/repos/quicwg/base-drafts/commits{/sha}","git_commits_url":"https://api.github.com/repos/quicwg/base-drafts/git/commits{/sha}","comments_url":"https://api.github.com/repos/quicwg/base-drafts/comments{/number}","issue_comment_url":"https://api.github.com/repos/quicwg/base-drafts/issues/comments{/number}","contents_url":"https://api.github.com/repos/quicwg/base-drafts/contents/{+path}","compare_url":"https://api.github.com/repos/quicwg/base-drafts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/quicwg/base-drafts/merges","archive_url":"https://api.github.com/repos/quicwg/base-drafts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/quicwg/base-drafts/downloads","issues_url":"https://api.github.com/repos/quicwg/base-drafts/issues{/number}","pulls_url":"https://api.github.com/repos/quicwg/base-drafts/pulls{/number}","milestones_url":"https://api.github.com/repos/quicwg/base-drafts/milestones{/number}","notifications_url":"https://api.github.com/repos/quicwg/base-drafts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/quicwg/base-drafts/labels{/name}","releases_url":"https://api.github.com/repos/quicwg/base-drafts/releases{/id}","deployments_url":"https://api.github.com/repos/quicwg/base-drafts/deployments","created_at":"2016-11-15T05:30:30Z","updated_at":"2018-07-18T13:59:59Z","pushed_at":"2018-07-17T22:42:25Z","git_url":"git://github.com/quicwg/base-drafts.git","ssh_url":"[email protected]:quicwg/base-drafts.git","clone_url":"https://github.com/quicwg/base-drafts.git","svn_url":"https://github.com/quicwg/base-drafts","homepage":"https://quicwg.github.io/","size":46188,"stargazers_count":270,"watchers_count":270,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":64,"mirror_url":null,"archived":false,"open_issues_count":113,"license":null,"forks":64,"open_issues":113,"watchers":270,"default_branch":"master"}},"base":{"label":"quicwg:master","ref":"master","sha":"69f364940b67f61f52def13a4dca4ad937fdeb65","user":{"login":"quicwg","id":22631371,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyNjMxMzcx","avatar_url":"https://avatars3.githubusercontent.com/u/22631371?v=4","gravatar_id":"","url":"https://api.github.com/users/quicwg","html_url":"https://github.com/quicwg","followers_url":"https://api.github.com/users/quicwg/followers","following_url":"https://api.github.com/users/quicwg/following{/other_user}","gists_url":"https://api.github.com/users/quicwg/gists{/gist_id}","starred_url":"https://api.github.com/users/quicwg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quicwg/subscriptions","organizations_url":"https://api.github.com/users/quicwg/orgs","repos_url":"https://api.github.com/users/quicwg/repos","events_url":"https://api.github.com/users/quicwg/events{/privacy}","received_events_url":"https://api.github.com/users/quicwg/received_events","type":"Organization","site_admin":false},"repo":{"id":73779599,"node_id":"MDEwOlJlcG9zaXRvcnk3Mzc3OTU5OQ==","name":"base-drafts","full_name":"quicwg/base-drafts","owner":{"login":"quicwg","id":22631371,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyNjMxMzcx","avatar_url":"https://avatars3.githubusercontent.com/u/22631371?v=4","gravatar_id":"","url":"https://api.github.com/users/quicwg","html_url":"https://github.com/quicwg","followers_url":"https://api.github.com/users/quicwg/followers","following_url":"https://api.github.com/users/quicwg/following{/other_user}","gists_url":"https://api.github.com/users/quicwg/gists{/gist_id}","starred_url":"https://api.github.com/users/quicwg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quicwg/subscriptions","organizations_url":"https://api.github.com/users/quicwg/orgs","repos_url":"https://api.github.com/users/quicwg/repos","events_url":"https://api.github.com/users/quicwg/events{/privacy}","received_events_url":"https://api.github.com/users/quicwg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/quicwg/base-drafts","description":" Internet-Drafts that make up the base QUIC specification","fork":false,"url":"https://api.github.com/repos/quicwg/base-drafts","forks_url":"https://api.github.com/repos/quicwg/base-drafts/forks","keys_url":"https://api.github.com/repos/quicwg/base-drafts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/quicwg/base-drafts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/quicwg/base-drafts/teams","hooks_url":"https://api.github.com/repos/quicwg/base-drafts/hooks","issue_events_url":"https://api.github.com/repos/quicwg/base-drafts/issues/events{/number}","events_url":"https://api.github.com/repos/quicwg/base-drafts/events","assignees_url":"https://api.github.com/repos/quicwg/base-drafts/assignees{/user}","branches_url":"https://api.github.com/repos/quicwg/base-drafts/branches{/branch}","tags_url":"https://api.github.com/repos/quicwg/base-drafts/tags","blobs_url":"https://api.github.com/repos/quicwg/base-drafts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/quicwg/base-drafts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/quicwg/base-drafts/git/refs{/sha}","trees_url":"https://api.github.com/repos/quicwg/base-drafts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/quicwg/base-drafts/statuses/{sha}","languages_url":"https://api.github.com/repos/quicwg/base-drafts/languages","stargazers_url":"https://api.github.com/repos/quicwg/base-drafts/stargazers","contributors_url":"https://api.github.com/repos/quicwg/base-drafts/contributors","subscribers_url":"https://api.github.com/repos/quicwg/base-drafts/subscribers","subscription_url":"https://api.github.com/repos/quicwg/base-drafts/subscription","commits_url":"https://api.github.com/repos/quicwg/base-drafts/commits{/sha}","git_commits_url":"https://api.github.com/repos/quicwg/base-drafts/git/commits{/sha}","comments_url":"https://api.github.com/repos/quicwg/base-drafts/comments{/number}","issue_comment_url":"https://api.github.com/repos/quicwg/base-drafts/issues/comments{/number}","contents_url":"https://api.github.com/repos/quicwg/base-drafts/contents/{+path}","compare_url":"https://api.github.com/repos/quicwg/base-drafts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/quicwg/base-drafts/merges","archive_url":"https://api.github.com/repos/quicwg/base-drafts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/quicwg/base-drafts/downloads","issues_url":"https://api.github.com/repos/quicwg/base-drafts/issues{/number}","pulls_url":"https://api.github.com/repos/quicwg/base-drafts/pulls{/number}","milestones_url":"https://api.github.com/repos/quicwg/base-drafts/milestones{/number}","notifications_url":"https://api.github.com/repos/quicwg/base-drafts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/quicwg/base-drafts/labels{/name}","releases_url":"https://api.github.com/repos/quicwg/base-drafts/releases{/id}","deployments_url":"https://api.github.com/repos/quicwg/base-drafts/deployments","created_at":"2016-11-15T05:30:30Z","updated_at":"2018-07-18T13:59:59Z","pushed_at":"2018-07-17T22:42:25Z","git_url":"git://github.com/quicwg/base-drafts.git","ssh_url":"[email protected]:quicwg/base-drafts.git","clone_url":"https://github.com/quicwg/base-drafts.git","svn_url":"https://github.com/quicwg/base-drafts","homepage":"https://quicwg.github.io/","size":46188,"stargazers_count":270,"watchers_count":270,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":64,"mirror_url":null,"archived":false,"open_issues_count":113,"license":null,"forks":64,"open_issues":113,"watchers":270,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/quicwg/base-drafts/pulls/1498"},"html":{"href":"https://github.com/quicwg/base-drafts/pull/1498"},"issue":{"href":"https://api.github.com/repos/quicwg/base-drafts/issues/1498"},"comments":{"href":"https://api.github.com/repos/quicwg/base-drafts/issues/1498/comments"},"review_comments":{"href":"https://api.github.com/repos/quicwg/base-drafts/pulls/1498/comments"},"review_comment":{"href":"https://api.github.com/repos/quicwg/base-drafts/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/quicwg/base-drafts/pulls/1498/commits"},"statuses":{"href":"https://api.github.com/repos/quicwg/base-drafts/statuses/cd9cdb48daea18b3f9b10e3459df09e833dcad32"}},"author_association":"MEMBER"}} | {
"id": 73779599,
"name": "quicwg/base-drafts",
"url": "https://api.github.com/repos/quicwg/base-drafts"
} | {
"id": 7464128,
"login": "huitema",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7464128?",
"url": "https://api.github.com/users/huitema"
} | {
"id": 22631371,
"login": "quicwg",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/22631371?",
"url": "https://api.github.com/orgs/quicwg"
} | 2018-07-18T15:19:56 | 7983680247 | {"actor":{"display_login":"huitema"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/CodeYourFuture/js-exercises/pulls/comments/187139104","pull_request_review_id":118857702,"id":187139104,"diff_hunk":"@@ -9,7 +9,13 @@\n */\n \n function containsCode(sentence) {\n-\n+ if (sentence.indexOf(\"code\") >= 0){\n+ res = true;","path":"week-2/G-conditionals-2/exercise-4.js","position":6,"original_position":6,"commit_id":"2af9adfefa976983e7580fa08b38a1fafd3f4e52","original_commit_id":"2af9adfefa976983e7580fa08b38a1fafd3f4e52","user":{"login":"dubchoi","id":1028368,"avatar_url":"https://avatars1.githubusercontent.com/u/1028368?v=4","gravatar_id":"","url":"https://api.github.com/users/dubchoi","html_url":"https://github.com/dubchoi","followers_url":"https://api.github.com/users/dubchoi/followers","following_url":"https://api.github.com/users/dubchoi/following{/other_user}","gists_url":"https://api.github.com/users/dubchoi/gists{/gist_id}","starred_url":"https://api.github.com/users/dubchoi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dubchoi/subscriptions","organizations_url":"https://api.github.com/users/dubchoi/orgs","repos_url":"https://api.github.com/users/dubchoi/repos","events_url":"https://api.github.com/users/dubchoi/events{/privacy}","received_events_url":"https://api.github.com/users/dubchoi/received_events","type":"User","site_admin":false},"body":"res is a variable without declaration. That's not good :-)\r\nBest way though is to do this all without any variables. Remember conditional expressions will result in a boolean value already. So in this case you can directly return:\r\n`return sentence.indexOf(\"code\") >= 0;`","created_at":"2018-05-09T18:46:45Z","updated_at":"2018-05-09T18:47:42Z","html_url":"https://github.com/CodeYourFuture/js-exercises/pull/84#discussion_r187139104","pull_request_url":"https://api.github.com/repos/CodeYourFuture/js-exercises/pulls/84","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/CodeYourFuture/js-exercises/pulls/comments/187139104"},"html":{"href":"https://github.com/CodeYourFuture/js-exercises/pull/84#discussion_r187139104"},"pull_request":{"href":"https://api.github.com/repos/CodeYourFuture/js-exercises/pulls/84"}}},"pull_request":{"url":"https://api.github.com/repos/CodeYourFuture/js-exercises/pulls/84","id":185406597,"html_url":"https://github.com/CodeYourFuture/js-exercises/pull/84","diff_url":"https://github.com/CodeYourFuture/js-exercises/pull/84.diff","patch_url":"https://github.com/CodeYourFuture/js-exercises/pull/84.patch","issue_url":"https://api.github.com/repos/CodeYourFuture/js-exercises/issues/84","number":84,"state":"open","locked":false,"title":"Week 2","user":{"login":"hasaninqh","id":37044047,"avatar_url":"https://avatars3.githubusercontent.com/u/37044047?v=4","gravatar_id":"","url":"https://api.github.com/users/hasaninqh","html_url":"https://github.com/hasaninqh","followers_url":"https://api.github.com/users/hasaninqh/followers","following_url":"https://api.github.com/users/hasaninqh/following{/other_user}","gists_url":"https://api.github.com/users/hasaninqh/gists{/gist_id}","starred_url":"https://api.github.com/users/hasaninqh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hasaninqh/subscriptions","organizations_url":"https://api.github.com/users/hasaninqh/orgs","repos_url":"https://api.github.com/users/hasaninqh/repos","events_url":"https://api.github.com/users/hasaninqh/events{/privacy}","received_events_url":"https://api.github.com/users/hasaninqh/received_events","type":"User","site_admin":false},"body":"All exercised for week2 folder have been solved .","created_at":"2018-05-02T11:13:40Z","updated_at":"2018-05-09T18:47:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"020e227be723d8c378adef305ad18c4ac4833793","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/CodeYourFuture/js-exercises/pulls/84/commits","review_comments_url":"https://api.github.com/repos/CodeYourFuture/js-exercises/pulls/84/comments","review_comment_url":"https://api.github.com/repos/CodeYourFuture/js-exercises/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CodeYourFuture/js-exercises/issues/84/comments","statuses_url":"https://api.github.com/repos/CodeYourFuture/js-exercises/statuses/2af9adfefa976983e7580fa08b38a1fafd3f4e52","head":{"label":"hasaninqh:week-2","ref":"week-2","sha":"2af9adfefa976983e7580fa08b38a1fafd3f4e52","user":{"login":"hasaninqh","id":37044047,"avatar_url":"https://avatars3.githubusercontent.com/u/37044047?v=4","gravatar_id":"","url":"https://api.github.com/users/hasaninqh","html_url":"https://github.com/hasaninqh","followers_url":"https://api.github.com/users/hasaninqh/followers","following_url":"https://api.github.com/users/hasaninqh/following{/other_user}","gists_url":"https://api.github.com/users/hasaninqh/gists{/gist_id}","starred_url":"https://api.github.com/users/hasaninqh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hasaninqh/subscriptions","organizations_url":"https://api.github.com/users/hasaninqh/orgs","repos_url":"https://api.github.com/users/hasaninqh/repos","events_url":"https://api.github.com/users/hasaninqh/events{/privacy}","received_events_url":"https://api.github.com/users/hasaninqh/received_events","type":"User","site_admin":false},"repo":{"id":130556422,"name":"js-exercises","full_name":"hasaninqh/js-exercises","owner":{"login":"hasaninqh","id":37044047,"avatar_url":"https://avatars3.githubusercontent.com/u/37044047?v=4","gravatar_id":"","url":"https://api.github.com/users/hasaninqh","html_url":"https://github.com/hasaninqh","followers_url":"https://api.github.com/users/hasaninqh/followers","following_url":"https://api.github.com/users/hasaninqh/following{/other_user}","gists_url":"https://api.github.com/users/hasaninqh/gists{/gist_id}","starred_url":"https://api.github.com/users/hasaninqh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hasaninqh/subscriptions","organizations_url":"https://api.github.com/users/hasaninqh/orgs","repos_url":"https://api.github.com/users/hasaninqh/repos","events_url":"https://api.github.com/users/hasaninqh/events{/privacy}","received_events_url":"https://api.github.com/users/hasaninqh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hasaninqh/js-exercises","description":"JavaScript exercises for CodeYourFuture students","fork":true,"url":"https://api.github.com/repos/hasaninqh/js-exercises","forks_url":"https://api.github.com/repos/hasaninqh/js-exercises/forks","keys_url":"https://api.github.com/repos/hasaninqh/js-exercises/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hasaninqh/js-exercises/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hasaninqh/js-exercises/teams","hooks_url":"https://api.github.com/repos/hasaninqh/js-exercises/hooks","issue_events_url":"https://api.github.com/repos/hasaninqh/js-exercises/issues/events{/number}","events_url":"https://api.github.com/repos/hasaninqh/js-exercises/events","assignees_url":"https://api.github.com/repos/hasaninqh/js-exercises/assignees{/user}","branches_url":"https://api.github.com/repos/hasaninqh/js-exercises/branches{/branch}","tags_url":"https://api.github.com/repos/hasaninqh/js-exercises/tags","blobs_url":"https://api.github.com/repos/hasaninqh/js-exercises/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hasaninqh/js-exercises/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hasaninqh/js-exercises/git/refs{/sha}","trees_url":"https://api.github.com/repos/hasaninqh/js-exercises/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hasaninqh/js-exercises/statuses/{sha}","languages_url":"https://api.github.com/repos/hasaninqh/js-exercises/languages","stargazers_url":"https://api.github.com/repos/hasaninqh/js-exercises/stargazers","contributors_url":"https://api.github.com/repos/hasaninqh/js-exercises/contributors","subscribers_url":"https://api.github.com/repos/hasaninqh/js-exercises/subscribers","subscription_url":"https://api.github.com/repos/hasaninqh/js-exercises/subscription","commits_url":"https://api.github.com/repos/hasaninqh/js-exercises/commits{/sha}","git_commits_url":"https://api.github.com/repos/hasaninqh/js-exercises/git/commits{/sha}","comments_url":"https://api.github.com/repos/hasaninqh/js-exercises/comments{/number}","issue_comment_url":"https://api.github.com/repos/hasaninqh/js-exercises/issues/comments{/number}","contents_url":"https://api.github.com/repos/hasaninqh/js-exercises/contents/{+path}","compare_url":"https://api.github.com/repos/hasaninqh/js-exercises/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hasaninqh/js-exercises/merges","archive_url":"https://api.github.com/repos/hasaninqh/js-exercises/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hasaninqh/js-exercises/downloads","issues_url":"https://api.github.com/repos/hasaninqh/js-exercises/issues{/number}","pulls_url":"https://api.github.com/repos/hasaninqh/js-exercises/pulls{/number}","milestones_url":"https://api.github.com/repos/hasaninqh/js-exercises/milestones{/number}","notifications_url":"https://api.github.com/repos/hasaninqh/js-exercises/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hasaninqh/js-exercises/labels{/name}","releases_url":"https://api.github.com/repos/hasaninqh/js-exercises/releases{/id}","deployments_url":"https://api.github.com/repos/hasaninqh/js-exercises/deployments","created_at":"2018-04-22T10:17:12Z","updated_at":"2018-04-27T17:19:18Z","pushed_at":"2018-05-05T10:09:49Z","git_url":"git://github.com/hasaninqh/js-exercises.git","ssh_url":"[email protected]:hasaninqh/js-exercises.git","clone_url":"https://github.com/hasaninqh/js-exercises.git","svn_url":"https://github.com/hasaninqh/js-exercises","homepage":"","size":734,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"CodeYourFuture:master","ref":"master","sha":"91136b0256b20b680f949817c3915c1efa920251","user":{"login":"CodeYourFuture","id":22743767,"avatar_url":"https://avatars3.githubusercontent.com/u/22743767?v=4","gravatar_id":"","url":"https://api.github.com/users/CodeYourFuture","html_url":"https://github.com/CodeYourFuture","followers_url":"https://api.github.com/users/CodeYourFuture/followers","following_url":"https://api.github.com/users/CodeYourFuture/following{/other_user}","gists_url":"https://api.github.com/users/CodeYourFuture/gists{/gist_id}","starred_url":"https://api.github.com/users/CodeYourFuture/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CodeYourFuture/subscriptions","organizations_url":"https://api.github.com/users/CodeYourFuture/orgs","repos_url":"https://api.github.com/users/CodeYourFuture/repos","events_url":"https://api.github.com/users/CodeYourFuture/events{/privacy}","received_events_url":"https://api.github.com/users/CodeYourFuture/received_events","type":"Organization","site_admin":false},"repo":{"id":121384131,"name":"js-exercises","full_name":"CodeYourFuture/js-exercises","owner":{"login":"CodeYourFuture","id":22743767,"avatar_url":"https://avatars3.githubusercontent.com/u/22743767?v=4","gravatar_id":"","url":"https://api.github.com/users/CodeYourFuture","html_url":"https://github.com/CodeYourFuture","followers_url":"https://api.github.com/users/CodeYourFuture/followers","following_url":"https://api.github.com/users/CodeYourFuture/following{/other_user}","gists_url":"https://api.github.com/users/CodeYourFuture/gists{/gist_id}","starred_url":"https://api.github.com/users/CodeYourFuture/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CodeYourFuture/subscriptions","organizations_url":"https://api.github.com/users/CodeYourFuture/orgs","repos_url":"https://api.github.com/users/CodeYourFuture/repos","events_url":"https://api.github.com/users/CodeYourFuture/events{/privacy}","received_events_url":"https://api.github.com/users/CodeYourFuture/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CodeYourFuture/js-exercises","description":"JavaScript exercises for CodeYourFuture students","fork":false,"url":"https://api.github.com/repos/CodeYourFuture/js-exercises","forks_url":"https://api.github.com/repos/CodeYourFuture/js-exercises/forks","keys_url":"https://api.github.com/repos/CodeYourFuture/js-exercises/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CodeYourFuture/js-exercises/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CodeYourFuture/js-exercises/teams","hooks_url":"https://api.github.com/repos/CodeYourFuture/js-exercises/hooks","issue_events_url":"https://api.github.com/repos/CodeYourFuture/js-exercises/issues/events{/number}","events_url":"https://api.github.com/repos/CodeYourFuture/js-exercises/events","assignees_url":"https://api.github.com/repos/CodeYourFuture/js-exercises/assignees{/user}","branches_url":"https://api.github.com/repos/CodeYourFuture/js-exercises/branches{/branch}","tags_url":"https://api.github.com/repos/CodeYourFuture/js-exercises/tags","blobs_url":"https://api.github.com/repos/CodeYourFuture/js-exercises/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CodeYourFuture/js-exercises/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CodeYourFuture/js-exercises/git/refs{/sha}","trees_url":"https://api.github.com/repos/CodeYourFuture/js-exercises/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CodeYourFuture/js-exercises/statuses/{sha}","languages_url":"https://api.github.com/repos/CodeYourFuture/js-exercises/languages","stargazers_url":"https://api.github.com/repos/CodeYourFuture/js-exercises/stargazers","contributors_url":"https://api.github.com/repos/CodeYourFuture/js-exercises/contributors","subscribers_url":"https://api.github.com/repos/CodeYourFuture/js-exercises/subscribers","subscription_url":"https://api.github.com/repos/CodeYourFuture/js-exercises/subscription","commits_url":"https://api.github.com/repos/CodeYourFuture/js-exercises/commits{/sha}","git_commits_url":"https://api.github.com/repos/CodeYourFuture/js-exercises/git/commits{/sha}","comments_url":"https://api.github.com/repos/CodeYourFuture/js-exercises/comments{/number}","issue_comment_url":"https://api.github.com/repos/CodeYourFuture/js-exercises/issues/comments{/number}","contents_url":"https://api.github.com/repos/CodeYourFuture/js-exercises/contents/{+path}","compare_url":"https://api.github.com/repos/CodeYourFuture/js-exercises/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CodeYourFuture/js-exercises/merges","archive_url":"https://api.github.com/repos/CodeYourFuture/js-exercises/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CodeYourFuture/js-exercises/downloads","issues_url":"https://api.github.com/repos/CodeYourFuture/js-exercises/issues{/number}","pulls_url":"https://api.github.com/repos/CodeYourFuture/js-exercises/pulls{/number}","milestones_url":"https://api.github.com/repos/CodeYourFuture/js-exercises/milestones{/number}","notifications_url":"https://api.github.com/repos/CodeYourFuture/js-exercises/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CodeYourFuture/js-exercises/labels{/name}","releases_url":"https://api.github.com/repos/CodeYourFuture/js-exercises/releases{/id}","deployments_url":"https://api.github.com/repos/CodeYourFuture/js-exercises/deployments","created_at":"2018-02-13T13:12:58Z","updated_at":"2018-04-19T16:34:34Z","pushed_at":"2018-05-08T16:28:14Z","git_url":"git://github.com/CodeYourFuture/js-exercises.git","ssh_url":"[email protected]:CodeYourFuture/js-exercises.git","clone_url":"https://github.com/CodeYourFuture/js-exercises.git","svn_url":"https://github.com/CodeYourFuture/js-exercises","homepage":"","size":722,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":53,"mirror_url":null,"archived":false,"open_issues_count":52,"license":null,"forks":53,"open_issues":52,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CodeYourFuture/js-exercises/pulls/84"},"html":{"href":"https://github.com/CodeYourFuture/js-exercises/pull/84"},"issue":{"href":"https://api.github.com/repos/CodeYourFuture/js-exercises/issues/84"},"comments":{"href":"https://api.github.com/repos/CodeYourFuture/js-exercises/issues/84/comments"},"review_comments":{"href":"https://api.github.com/repos/CodeYourFuture/js-exercises/pulls/84/comments"},"review_comment":{"href":"https://api.github.com/repos/CodeYourFuture/js-exercises/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CodeYourFuture/js-exercises/pulls/84/commits"},"statuses":{"href":"https://api.github.com/repos/CodeYourFuture/js-exercises/statuses/2af9adfefa976983e7580fa08b38a1fafd3f4e52"}},"author_association":"NONE"}} | {
"id": 121384131,
"name": "CodeYourFuture/js-exercises",
"url": "https://api.github.com/repos/CodeYourFuture/js-exercises"
} | {
"id": 1028368,
"login": "dubchoi",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1028368?",
"url": "https://api.github.com/users/dubchoi"
} | {
"id": 22743767,
"login": "CodeYourFuture",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/22743767?",
"url": "https://api.github.com/orgs/CodeYourFuture"
} | 2018-05-09T18:46:45 | 7651532776 | {"actor":{"display_login":"dubchoi"}} |
Subsets and Splits