Search is not available for this dataset
type
stringclasses 17
values | public
bool 2
classes | payload
stringlengths 2
1.27M
| repo
dict | actor
dict | org
dict | created_at
timestamp[us] | id
stringclasses 0
values | other
stringlengths 34
66.4k
|
|---|---|---|---|---|---|---|---|---|
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/akka/akka.github.com/pulls/comments/7219611","id":7219611,"diff_hunk":"@@ -25,14 +42,14 @@\n <div class=\"row rel\">\n <div class=\"span6\">\n <div class=\"latest\">\n- <h2>Latest official version <small>Sep 23, 2013</small></h2>\n+ <h2>Latest official version <small>(open source)</small></h2>","path":"_includes/download.html","position":26,"original_position":26,"commit_id":"850772450972b386ddd65f2f389159bba9cb5f69","original_commit_id":"850772450972b386ddd65f2f389159bba9cb5f69","user":{"login":"jamesward","id":65043,"avatar_url":"https://0.gravatar.com/avatar/2a5d2e19906383b1a574f4d48d634d47?d=https%3A%2F%2Fidenticons.github.com%2Fde3d18f8753b0a7ee57b638f0fe6841f.png&r=x","gravatar_id":"2a5d2e19906383b1a574f4d48d634d47","url":"https://api.github.com/users/jamesward","html_url":"https://github.com/jamesward","followers_url":"https://api.github.com/users/jamesward/followers","following_url":"https://api.github.com/users/jamesward/following{/other_user}","gists_url":"https://api.github.com/users/jamesward/gists{/gist_id}","starred_url":"https://api.github.com/users/jamesward/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamesward/subscriptions","organizations_url":"https://api.github.com/users/jamesward/orgs","repos_url":"https://api.github.com/users/jamesward/repos","events_url":"https://api.github.com/users/jamesward/events{/privacy}","received_events_url":"https://api.github.com/users/jamesward/received_events","type":"User","site_admin":false},"body":"The REST service doesn't have a date right now. So that is why I dropped it. Had to do the same thing on playframework.com.","created_at":"2013-10-25T15:37:44Z","updated_at":"2013-10-25T15:37:44Z","html_url":"https://github.com/akka/akka.github.com/pull/64#discussion_r7219611","pull_request_url":"https://api.github.com/repos/akka/akka.github.com/pulls/64","_links":{"self":{"href":"https://api.github.com/repos/akka/akka.github.com/pulls/comments/7219611"},"html":{"href":"https://github.com/akka/akka.github.com/pull/64#discussion_r7219611"},"pull_request":{"href":"https://api.github.com/repos/akka/akka.github.com/pulls/64"}}}} | {
"id": 3603954,
"name": "akka.github.com",
"url": "https://github.com/akka/akka.github.com"
} | {
"id": null,
"login": "jamesward",
"gravatar_id": "2a5d2e19906383b1a574f4d48d634d47",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "akka",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-10-25T15:37:44 | null | {"repository":{"description":"The akka.io site","homepage":"akka.io","watchers":7,"stargazers":7,"forks":3,"fork":false,"size":1198,"owner":"akka","private":false,"open_issues":14,"has_issues":true,"has_downloads":true,"has_wiki":false,"language":"CSS","created_at":"2012-03-02T08:40:36-08:00","pushed_at":"2013-10-23T06:42:51-07:00","master_branch":"master","organization":"akka"},"actor_attributes":{"type":"User","name":"James Ward","blog":"http://www.jamesward.com","email":"[email protected]"},"url":"https://github.com/akka/akka.github.com/pull/64#discussion_r7219611"} |
PullRequestReviewCommentEvent | true | {"comment":{"commit_id":"1b331dc547a603fcca656881bd66ca69e2d14e60","id":2859615,"_links":{"self":{"href":"https://api.github.com/repos/akka/akka/pulls/comments/2859615"},"html":{"href":"https://github.com/akka/akka/pull/1097#discussion_r2859615"},"pull_request":{"href":"https://api.github.com/repos/akka/akka/pulls/1097"}},"position":483,"updated_at":"2013-02-01T14:29:35Z","user":{"id":470469,"events_url":"https://api.github.com/users/rkuhn/events{/privacy}","avatar_url":"https://secure.gravatar.com/avatar/262b1ab25e66b1e15a48fa3f68703aad?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","type":"User","following_url":"https://api.github.com/users/rkuhn/following","subscriptions_url":"https://api.github.com/users/rkuhn/subscriptions","followers_url":"https://api.github.com/users/rkuhn/followers","login":"rkuhn","gravatar_id":"262b1ab25e66b1e15a48fa3f68703aad","starred_url":"https://api.github.com/users/rkuhn/starred{/owner}{/repo}","url":"https://api.github.com/users/rkuhn","received_events_url":"https://api.github.com/users/rkuhn/received_events","gists_url":"https://api.github.com/users/rkuhn/gists{/gist_id}","repos_url":"https://api.github.com/users/rkuhn/repos","organizations_url":"https://api.github.com/users/rkuhn/orgs"},"path":"akka-docs/rst/scala/typed-channels.rst","original_commit_id":"1b331dc547a603fcca656881bd66ca69e2d14e60","body":"yes, I just wrote it half an hour ago ;-)","url":"https://api.github.com/repos/akka/akka/pulls/comments/2859615","created_at":"2013-02-01T14:29:35Z","original_position":483}} | {
"id": 130013,
"name": "akka",
"url": "https://github.com/akka/akka"
} | {
"id": null,
"login": "rkuhn",
"gravatar_id": "262b1ab25e66b1e15a48fa3f68703aad",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "akka",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-02-01T14:29:35 | null | {"repository":{"open_issues":10,"owner":"akka","has_wiki":false,"homepage":"http://akka.io","watchers":1507,"has_issues":false,"created_at":"2009-02-16T04:51:54-08:00","integrate_branch":"staging","description":"Akka Project","stargazers":1507,"organization":"akka","fork":false,"size":16892,"language":"Scala","pushed_at":"2013-02-01T05:14:13-08:00","forks":299,"private":false,"has_downloads":true},"actor_attributes":{"location":"Uppsala, Sweden","type":"User","company":"Typesafe Inc.","name":"Roland Kuhn","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/akka/akka/pull/1097#discussion_r2859615"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/amco/dolly/pulls/comments/6985744","id":6985744,"diff_hunk":"@@ -0,0 +1,38 @@\n+module Dolly\n+ class Property\n+ attr_writer :value\n+ attr_accessor :name\n+\n+ def initialize opts = {}\n+ @class_name = opts.delete(:class_name) if opts.present?\n+ @name = opts.delete(:name).to_s\n+ @default = opts.delete(:default)\n+ warn 'There are some unprocesed options' if opts.present?\n+ end\n+\n+ def value","path":"lib/dolly/property.rb","position":13,"original_position":13,"commit_id":"7086fe566fb7d8ef23cfef1f61be32219bbee4dc","original_commit_id":"7086fe566fb7d8ef23cfef1f61be32219bbee4dc","user":{"login":"aalvarado","id":370322,"avatar_url":"https://2.gravatar.com/avatar/98b22d59f361433cb2d68030e4a8c8f6?d=https%3A%2F%2Fidenticons.github.com%2Fe36203a2a7baf1dafacd6b64162b7a01.png","gravatar_id":"98b22d59f361433cb2d68030e4a8c8f6","url":"https://api.github.com/users/aalvarado","html_url":"https://github.com/aalvarado","followers_url":"https://api.github.com/users/aalvarado/followers","following_url":"https://api.github.com/users/aalvarado/following{/other_user}","gists_url":"https://api.github.com/users/aalvarado/gists{/gist_id}","starred_url":"https://api.github.com/users/aalvarado/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aalvarado/subscriptions","organizations_url":"https://api.github.com/users/aalvarado/orgs","repos_url":"https://api.github.com/users/aalvarado/repos","events_url":"https://api.github.com/users/aalvarado/events{/privacy}","received_events_url":"https://api.github.com/users/aalvarado/received_events","type":"User","site_admin":false},"body":"maybe something more dynamic:\r\n\r\n```ruby\r\ndef value\r\n self.send( self_klass.snake_case.to_sym )\r\nend\r\n\r\ndef hash_value\r\n @value.to_h\r\nend\r\n\r\ndef array_value\r\n @value.to_a\r\nend\r\n\r\ndef true_class_value\r\n #...\r\nend\r\n```\r\n\r\nwhat do you think?","created_at":"2013-10-15T21:32:05Z","updated_at":"2013-10-15T21:32:05Z","html_url":"https://github.com/amco/dolly/pull/5#discussion_r6985744","pull_request_url":"https://api.github.com/repos/amco/dolly/pulls/5","_links":{"self":{"href":"https://api.github.com/repos/amco/dolly/pulls/comments/6985744"},"html":{"href":"https://github.com/amco/dolly/pull/5#discussion_r6985744"},"pull_request":{"href":"https://api.github.com/repos/amco/dolly/pulls/5"}}}} | {
"id": 13510618,
"name": "dolly",
"url": "https://github.com/amco/dolly"
} | {
"id": null,
"login": "aalvarado",
"gravatar_id": "98b22d59f361433cb2d68030e4a8c8f6",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "amco",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-10-15T21:32:05 | null | {"repository":{"description":"Not an ORM for CouchDB in rails.","watchers":0,"stargazers":0,"forks":0,"fork":false,"size":248,"owner":"amco","private":false,"open_issues":6,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Ruby","created_at":"2013-10-11T14:54:52-07:00","pushed_at":"2013-10-15T13:35:55-07:00","master_branch":"master","organization":"amco"},"actor_attributes":{"type":"User","name":"Adan Alvarado","company":"Amco","location":"San diego, CA. / Tijuana, Baja Cal.","email":"[email protected]"},"url":"https://github.com/amco/dolly/pull/5#discussion_r6985744"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/ceph/ceph/pulls/comments/4305404","id":4305404,"body":"This is a good start, but you aren't testing most of the edge cases for this. You should be checking that it succeeds on GE when equal, and that it fails on GT when equal, etc.","diff_hunk":"@@ -0,0 +1,298 @@\n+// -*- mode:C; tab-width:8; c-basic-offset:2; indent-tabs-mode:t -*-\n+// vim: ts=8 sw=2 smarttab\n+\n+#include \"include/types.h\"\n+#include \"cls/version/cls_version_types.h\"\n+#include \"cls/version/cls_version_client.h\"\n+\n+#include \"gtest/gtest.h\"\n+#include \"test/librados/test.h\"\n+\n+#include <errno.h>\n+#include <string>\n+#include <vector>\n+\n+static librados::ObjectWriteOperation *new_op() {\n+ return new librados::ObjectWriteOperation();\n+}\n+\n+static librados::ObjectReadOperation *new_rop() {\n+ return new librados::ObjectReadOperation();\n+}\n+\n+TEST(cls_rgw, test_version_inc_read)\n+{\n+ librados::Rados rados;\n+ librados::IoCtx ioctx;\n+ string pool_name = get_temp_pool_name();\n+\n+ /* create pool */\n+ ASSERT_EQ(\"\", create_one_pool_pp(pool_name, rados));\n+ ASSERT_EQ(0, rados.ioctx_create(pool_name.c_str(), ioctx));\n+\n+ /* add chains */\n+ string oid = \"obj\";\n+\n+\n+ /* create object */\n+\n+ ASSERT_EQ(0, ioctx.create(oid, true));\n+\n+ obj_version ver;\n+\n+ ASSERT_EQ(0, cls_version_read(ioctx, oid, &ver));\n+ ASSERT_EQ(0, (long long)ver.ver);\n+ ASSERT_EQ(0, (int)ver.tag.size());\n+ \n+\n+ /* inc version */\n+ librados::ObjectWriteOperation *op = new_op();\n+ cls_version_inc(*op);\n+ ASSERT_EQ(0, ioctx.operate(oid, op));\n+\n+ ASSERT_EQ(0, cls_version_read(ioctx, oid, &ver));\n+ ASSERT_GT((long long)ver.ver, 0);\n+ ASSERT_NE(0, (int)ver.tag.size());\n+\n+ /* inc version again! */\n+ op = new_op();\n+ cls_version_inc(*op);\n+ ASSERT_EQ(0, ioctx.operate(oid, op));\n+\n+ obj_version ver2;\n+\n+ ASSERT_EQ(0, cls_version_read(ioctx, oid, &ver2));\n+ ASSERT_GT((long long)ver2.ver, (long long)ver.ver);\n+ ASSERT_EQ(0, (int)ver2.tag.compare(ver.tag));\n+\n+ delete op;\n+\n+ obj_version ver3;\n+\n+ librados::ObjectReadOperation *rop = new_rop();\n+ cls_version_read(*rop, &ver3);\n+ bufferlist outbl;\n+ ASSERT_EQ(0, ioctx.operate(oid, rop, &outbl));\n+ ASSERT_EQ(ver2.ver, ver3.ver);\n+ ASSERT_EQ(1, (long long)ver2.compare(&ver3));\n+\n+ delete op;\n+}\n+\n+\n+TEST(cls_rgw, test_version_set)\n+{\n+ librados::Rados rados;\n+ librados::IoCtx ioctx;\n+ string pool_name = get_temp_pool_name();\n+\n+ /* create pool */\n+ ASSERT_EQ(\"\", create_one_pool_pp(pool_name, rados));\n+ ASSERT_EQ(0, rados.ioctx_create(pool_name.c_str(), ioctx));\n+\n+ /* add chains */\n+ string oid = \"obj\";\n+\n+\n+ /* create object */\n+\n+ ASSERT_EQ(0, ioctx.create(oid, true));\n+\n+ obj_version ver;\n+\n+ ASSERT_EQ(0, cls_version_read(ioctx, oid, &ver));\n+ ASSERT_EQ(0, (long long)ver.ver);\n+ ASSERT_EQ(0, (int)ver.tag.size());\n+\n+\n+ ver.ver = 123;\n+ ver.tag = \"foo\";\n+\n+ /* set version */\n+ librados::ObjectWriteOperation *op = new_op();\n+ cls_version_set(*op, ver);\n+ ASSERT_EQ(0, ioctx.operate(oid, op));\n+\n+ /* read version */\n+ obj_version ver2;\n+\n+ ASSERT_EQ(0, cls_version_read(ioctx, oid, &ver2));\n+ ASSERT_EQ((long long)ver2.ver, (long long)ver.ver);\n+ ASSERT_EQ(0, (int)ver2.tag.compare(ver.tag));\n+\n+ delete op;\n+}\n+\n+TEST(cls_rgw, test_version_inc_cond)\n+{\n+ librados::Rados rados;\n+ librados::IoCtx ioctx;\n+ string pool_name = get_temp_pool_name();\n+\n+ /* create pool */\n+ ASSERT_EQ(\"\", create_one_pool_pp(pool_name, rados));\n+ ASSERT_EQ(0, rados.ioctx_create(pool_name.c_str(), ioctx));\n+\n+ /* add chains */\n+ string oid = \"obj\";\n+\n+\n+ /* create object */\n+\n+ ASSERT_EQ(0, ioctx.create(oid, true));\n+\n+ obj_version ver;\n+\n+ ASSERT_EQ(0, cls_version_read(ioctx, oid, &ver));\n+ ASSERT_EQ(0, (long long)ver.ver);\n+ ASSERT_EQ(0, (int)ver.tag.size());\n+ \n+ /* inc version */\n+ librados::ObjectWriteOperation *op = new_op();\n+ cls_version_inc(*op);\n+ ASSERT_EQ(0, ioctx.operate(oid, op));\n+\n+ ASSERT_EQ(0, cls_version_read(ioctx, oid, &ver));\n+ ASSERT_GT((long long)ver.ver, 0);\n+ ASSERT_NE(0, (int)ver.tag.size());\n+\n+ obj_version cond_ver = ver;\n+\n+\n+ /* inc version again! */\n+ op = new_op();\n+ cls_version_inc(*op);\n+ ASSERT_EQ(0, ioctx.operate(oid, op));\n+\n+ obj_version ver2;\n+\n+ ASSERT_EQ(0, cls_version_read(ioctx, oid, &ver2));\n+ ASSERT_GT((long long)ver2.ver, (long long)ver.ver);\n+ ASSERT_EQ(0, (int)ver2.tag.compare(ver.tag));\n+\n+\n+ /* now check various condition tests */\n+ cls_version_inc(*op, cond_ver, VER_COND_NONE);\n+ ASSERT_EQ(0, ioctx.operate(oid, op));\n+\n+ ASSERT_EQ(0, cls_version_read(ioctx, oid, &ver2));\n+ ASSERT_GT((long long)ver2.ver, (long long)ver.ver);\n+ ASSERT_EQ(0, (int)ver2.tag.compare(ver.tag));\n+\n+ /* a bunch of conditions that should fail */\n+ op = new_op();\n+ cls_version_inc(*op, cond_ver, VER_COND_EQ);\n+ ASSERT_EQ(-ECANCELED, ioctx.operate(oid, op));\n+\n+ op = new_op();\n+ cls_version_inc(*op, cond_ver, VER_COND_LT);\n+ ASSERT_EQ(-ECANCELED, ioctx.operate(oid, op));\n+\n+ op = new_op();\n+ cls_version_inc(*op, cond_ver, VER_COND_LE);\n+ ASSERT_EQ(-ECANCELED, ioctx.operate(oid, op));\n+\n+ op = new_op();\n+ cls_version_inc(*op, cond_ver, VER_COND_TAG_NE);\n+ ASSERT_EQ(-ECANCELED, ioctx.operate(oid, op));\n+\n+ ASSERT_EQ(0, cls_version_read(ioctx, oid, &ver2));\n+ ASSERT_GT((long long)ver2.ver, (long long)ver.ver);\n+ ASSERT_EQ(0, (int)ver2.tag.compare(ver.tag));\n+\n+ /* a bunch of conditions that should succeed */\n+ op = new_op();\n+ cls_version_inc(*op, ver2, VER_COND_EQ);\n+ ASSERT_EQ(0, ioctx.operate(oid, op));\n+\n+ op = new_op();\n+ cls_version_inc(*op, cond_ver, VER_COND_GT);\n+ ASSERT_EQ(0, ioctx.operate(oid, op));\n+\n+ op = new_op();\n+ cls_version_inc(*op, cond_ver, VER_COND_GE);\n+ ASSERT_EQ(0, ioctx.operate(oid, op));\n+\n+ op = new_op();\n+ cls_version_inc(*op, cond_ver, VER_COND_TAG_EQ);\n+ ASSERT_EQ(0, ioctx.operate(oid, op));\n+\n+ delete op;\n+}","path":"src/test/cls_version/test_cls_version.cc","position":221,"original_position":221,"commit_id":"4b55a28a31d90054a790c45f63b70182079fba7e","original_commit_id":"4b55a28a31d90054a790c45f63b70182079fba7e","user":{"login":"gregsfortytwo","id":908479,"avatar_url":"https://secure.gravatar.com/avatar/19fc74958678713dfdf1f8ca776f8fbc?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"19fc74958678713dfdf1f8ca776f8fbc","url":"https://api.github.com/users/gregsfortytwo","html_url":"https://github.com/gregsfortytwo","followers_url":"https://api.github.com/users/gregsfortytwo/followers","following_url":"https://api.github.com/users/gregsfortytwo/following{/other_user}","gists_url":"https://api.github.com/users/gregsfortytwo/gists{/gist_id}","starred_url":"https://api.github.com/users/gregsfortytwo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gregsfortytwo/subscriptions","organizations_url":"https://api.github.com/users/gregsfortytwo/orgs","repos_url":"https://api.github.com/users/gregsfortytwo/repos","events_url":"https://api.github.com/users/gregsfortytwo/events{/privacy}","received_events_url":"https://api.github.com/users/gregsfortytwo/received_events","type":"User"},"created_at":"2013-05-20T20:59:04Z","updated_at":"2013-05-20T20:59:04Z","html_url":"https://github.com/ceph/ceph/pull/289#discussion_r4305404","pull_request_url":"https://api.github.com/repos/ceph/ceph/pulls/289","_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments/4305404"},"html":{"href":"https://github.com/ceph/ceph/pull/289#discussion_r4305404"},"pull_request":{"href":"https://api.github.com/repos/ceph/ceph/pulls/289"}}}} | {
"id": 2310495,
"name": "ceph",
"url": "https://github.com/ceph/ceph"
} | {
"id": null,
"login": "gregsfortytwo",
"gravatar_id": "19fc74958678713dfdf1f8ca776f8fbc",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "ceph",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-05-20T20:59:04 | null | {"repository":{"description":"Ceph is a distributed object, block, and file storage platform ","homepage":"http://ceph.com","watchers":360,"stargazers":360,"forks":123,"fork":false,"size":30444,"owner":"ceph","private":false,"open_issues":8,"has_issues":false,"has_downloads":true,"has_wiki":false,"language":"C++","created_at":"2011-09-01T14:41:26-07:00","pushed_at":"2013-05-20T13:56:04-07:00","master_branch":"master","organization":"ceph"},"actor_attributes":{"type":"User","name":"Gregory Farnum","company":"Inktank","blog":"www.gregs42.com","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/ceph/ceph/pull/289#discussion_r4305404"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/ceph/ceph/pulls/comments/8341083","id":8341083,"diff_hunk":"@@ -7985,6 +8024,46 @@ int ReplicatedPG::recover_replicas(int max, ThreadPool::TPHandle &handle)\n return started;\n }\n \n+hobject_t\n+ReplicatedPG::earliest_peer_backfill()","path":"src/osd/ReplicatedPG.cc","position":224,"original_position":224,"commit_id":"ab5c32e23b30a7cd5fcfdb37bd4bdbb712531182","original_commit_id":"ab5c32e23b30a7cd5fcfdb37bd4bdbb712531182","user":{"login":"athanatos","id":544782,"avatar_url":"https://gravatar.com/avatar/2ffd507169940c5c0a05f3b9277fbb6a?d=https%3A%2F%2Fidenticons.github.com%2Fc7ae33d28c7600f115c5cd17c9a9c743.png&r=x","gravatar_id":"2ffd507169940c5c0a05f3b9277fbb6a","url":"https://api.github.com/users/athanatos","html_url":"https://github.com/athanatos","followers_url":"https://api.github.com/users/athanatos/followers","following_url":"https://api.github.com/users/athanatos/following{/other_user}","gists_url":"https://api.github.com/users/athanatos/gists{/gist_id}","starred_url":"https://api.github.com/users/athanatos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/athanatos/subscriptions","organizations_url":"https://api.github.com/users/athanatos/orgs","repos_url":"https://api.github.com/users/athanatos/repos","events_url":"https://api.github.com/users/athanatos/events{/privacy}","received_events_url":"https://api.github.com/users/athanatos/received_events","type":"User","site_admin":false},"body":"formatting, const","created_at":"2013-12-13T18:52:14Z","updated_at":"2013-12-13T18:52:14Z","html_url":"https://github.com/ceph/ceph/pull/931#discussion_r8341083","pull_request_url":"https://api.github.com/repos/ceph/ceph/pulls/931","_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments/8341083"},"html":{"href":"https://github.com/ceph/ceph/pull/931#discussion_r8341083"},"pull_request":{"href":"https://api.github.com/repos/ceph/ceph/pulls/931"}}}} | {
"id": 2310495,
"name": "ceph",
"url": "https://github.com/ceph/ceph"
} | {
"id": null,
"login": "athanatos",
"gravatar_id": "2ffd507169940c5c0a05f3b9277fbb6a",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "ceph",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-12-13T18:52:14 | null | {"repository":{"description":"Ceph is a distributed object, block, and file storage platform ","homepage":"http://ceph.com","watchers":544,"stargazers":544,"forks":232,"fork":false,"size":135390,"owner":"ceph","private":false,"open_issues":27,"has_issues":false,"has_downloads":true,"has_wiki":false,"language":"C++","created_at":"2011-09-01T14:41:26-07:00","pushed_at":"2013-12-13T10:49:46-08:00","master_branch":"master","organization":"ceph"},"actor_attributes":{"type":"User","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/ceph/ceph/pull/931#discussion_r8341083"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/cgeo/c-geo-opensource/pulls/comments/3309558","id":3309558,"body":"You should probably add an entry in `Intents.java`, such as:\r\n\r\n```java\r\n public static final String EXTRA_CACHELIST = PREFIX + \"cache_list\";\r\n```\r\n\r\nThis helps when debugging to use qualified names (as recommended for intents, and probably for loaders, by the Android documentation).","diff_hunk":"@@ -70,8 +79,9 @@\n import java.util.List;\n import java.util.Set;\n \n-public class cgeocaches extends AbstractListActivity implements FilteredActivity {\n+public class cgeocaches extends AbstractListActivity implements FilteredActivity, LoaderManager.LoaderCallbacks<SearchResult> {\n \n+ private static final String EXTRA_CACHELIST = \"CACHELIST\";","path":"main/src/cgeo/geocaching/cgeocaches.java","position":49,"original_position":49,"commit_id":"09418efa3d280bc8d83f107af5420af3b1a5b562","original_commit_id":"09418efa3d280bc8d83f107af5420af3b1a5b562","user":{"login":"samueltardieu","id":44656,"avatar_url":"https://secure.gravatar.com/avatar/6e6d5c89985a1976429d28f117eb5137?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"6e6d5c89985a1976429d28f117eb5137","url":"https://api.github.com/users/samueltardieu","html_url":"https://github.com/samueltardieu","followers_url":"https://api.github.com/users/samueltardieu/followers","following_url":"https://api.github.com/users/samueltardieu/following","gists_url":"https://api.github.com/users/samueltardieu/gists{/gist_id}","starred_url":"https://api.github.com/users/samueltardieu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samueltardieu/subscriptions","organizations_url":"https://api.github.com/users/samueltardieu/orgs","repos_url":"https://api.github.com/users/samueltardieu/repos","events_url":"https://api.github.com/users/samueltardieu/events{/privacy}","received_events_url":"https://api.github.com/users/samueltardieu/received_events","type":"User"},"created_at":"2013-03-10T10:11:57Z","updated_at":"2013-03-10T10:11:57Z","html_url":"https://github.com/cgeo/c-geo-opensource/pull/2554#discussion_r3309558","pull_request_url":"https://api.github.com/repos/cgeo/c-geo-opensource/pulls/2554","_links":{"self":{"href":"https://api.github.com/repos/cgeo/c-geo-opensource/pulls/comments/3309558"},"html":{"href":"https://github.com/cgeo/c-geo-opensource/pull/2554#discussion_r3309558"},"pull_request":{"href":"https://api.github.com/repos/cgeo/c-geo-opensource/pulls/2554"}}}} | {
"id": 2028724,
"name": "c-geo-opensource",
"url": "https://github.com/cgeo/c-geo-opensource"
} | {
"id": null,
"login": "samueltardieu",
"gravatar_id": "6e6d5c89985a1976429d28f117eb5137",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "cgeo",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-03-10T10:11:57 | null | {"repository":{"description":"This is an open source successor of c:geo - an Android geocaching app.","homepage":"www.cgeo.org","watchers":260,"stargazers":260,"forks":132,"fork":false,"size":4540,"owner":"cgeo","private":false,"open_issues":302,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Java","created_at":"2011-07-10T23:02:47-07:00","pushed_at":"2013-03-09T23:25:03-08:00","master_branch":"master","organization":"cgeo"},"actor_attributes":{"type":"User","name":"Samuel Tardieu","blog":"http://www.rfc1149.net/sam.html","location":"Paris, France","email":"[email protected]"},"url":"https://github.com/cgeo/c-geo-opensource/pull/2554#discussion_r3309558"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/cgeo/c-geo-opensource/pulls/comments/3350152","id":3350152,"body":"OK, so I have created new pull request.\r\nI have fixed (I hope) the problem with formatting (tab at the beginning of some strings). I did not know that it is important, but you are right - it looks much better.\r\nI have also made some small updates and now I test it in my device.","diff_hunk":"@@ -1,118 +1,120 @@\n <?xml version=\"1.0\" encoding=\"UTF-8\"?>\n <resources xmlns:tools=\"http://schemas.android.com/tools\">\n <string name=\"app_name\">c:geo</string>\n- <string name=\"app_name_compass\">c:geo kompas</string>\n+ <string name=\"app_name_compass\">c:geo compass</string>","path":"main/res/values-cs/strings.xml","position":5,"original_position":5,"commit_id":"c5c33fb217fc0b226226b0c82276f61003f08683","original_commit_id":"c5c33fb217fc0b226226b0c82276f61003f08683","user":{"login":"R3gi","id":2983869,"avatar_url":"https://secure.gravatar.com/avatar/8741e1955b583f2bec214a3fca56b881?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"8741e1955b583f2bec214a3fca56b881","url":"https://api.github.com/users/R3gi","html_url":"https://github.com/R3gi","followers_url":"https://api.github.com/users/R3gi/followers","following_url":"https://api.github.com/users/R3gi/following","gists_url":"https://api.github.com/users/R3gi/gists{/gist_id}","starred_url":"https://api.github.com/users/R3gi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/R3gi/subscriptions","organizations_url":"https://api.github.com/users/R3gi/orgs","repos_url":"https://api.github.com/users/R3gi/repos","events_url":"https://api.github.com/users/R3gi/events{/privacy}","received_events_url":"https://api.github.com/users/R3gi/received_events","type":"User"},"created_at":"2013-03-13T09:00:06Z","updated_at":"2013-03-13T09:00:06Z","html_url":"https://github.com/cgeo/c-geo-opensource/pull/2564#discussion_r3350152","pull_request_url":"https://api.github.com/repos/cgeo/c-geo-opensource/pulls/2564","_links":{"self":{"href":"https://api.github.com/repos/cgeo/c-geo-opensource/pulls/comments/3350152"},"html":{"href":"https://github.com/cgeo/c-geo-opensource/pull/2564#discussion_r3350152"},"pull_request":{"href":"https://api.github.com/repos/cgeo/c-geo-opensource/pulls/2564"}}}} | {
"id": 2028724,
"name": "c-geo-opensource",
"url": "https://github.com/cgeo/c-geo-opensource"
} | {
"id": null,
"login": "R3gi",
"gravatar_id": "8741e1955b583f2bec214a3fca56b881",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "cgeo",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-03-13T09:00:06 | null | {"repository":{"description":"This is an open source successor of c:geo - an Android geocaching app.","homepage":"www.cgeo.org","watchers":262,"stargazers":262,"forks":134,"fork":false,"size":4368,"owner":"cgeo","private":false,"open_issues":300,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Java","created_at":"2011-07-10T23:02:47-07:00","pushed_at":"2013-03-13T01:58:26-07:00","master_branch":"master","organization":"cgeo"},"actor_attributes":{"type":"User","name":"R3gi","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/cgeo/c-geo-opensource/pull/2564#discussion_r3350152"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/etsy/statsd/pulls/comments/5021037","id":5021037,"body":"not in love with this, but don't want people on node v0.8 developing on their laptop to get failed tests.","diff_hunk":"@@ -0,0 +1,51 @@\n+var process_mgmt = require('../lib/process_mgmt')\n+ , os = require('os');\n+\n+var config = {}\n+ , can_set_title = true;\n+\n+module.exports = {\n+\n+ setUp: function(callback) {\n+ config = {};\n+ version_number = process.version.split(\".\")[1];\n+ platform = os.platform();\n+ can_set_title = (version_number >= 10 || platform != 'darwin');","path":"test/process_mgmt_tests.js","position":13,"original_position":13,"commit_id":"dd1ad7b2383c2434e20715ee3e9703f2080994f5","original_commit_id":"dd1ad7b2383c2434e20715ee3e9703f2080994f5","user":{"login":"draco2003","id":196891,"avatar_url":"https://secure.gravatar.com/avatar/9593180ec2004cbf2dd038ee7cc418ae?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"9593180ec2004cbf2dd038ee7cc418ae","url":"https://api.github.com/users/draco2003","html_url":"https://github.com/draco2003","followers_url":"https://api.github.com/users/draco2003/followers","following_url":"https://api.github.com/users/draco2003/following{/other_user}","gists_url":"https://api.github.com/users/draco2003/gists{/gist_id}","starred_url":"https://api.github.com/users/draco2003/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/draco2003/subscriptions","organizations_url":"https://api.github.com/users/draco2003/orgs","repos_url":"https://api.github.com/users/draco2003/repos","events_url":"https://api.github.com/users/draco2003/events{/privacy}","received_events_url":"https://api.github.com/users/draco2003/received_events","type":"User"},"created_at":"2013-07-03T21:44:02Z","updated_at":"2013-07-03T21:44:02Z","html_url":"https://github.com/etsy/statsd/pull/311#discussion_r5021037","pull_request_url":"https://api.github.com/repos/etsy/statsd/pulls/311","_links":{"self":{"href":"https://api.github.com/repos/etsy/statsd/pulls/comments/5021037"},"html":{"href":"https://github.com/etsy/statsd/pull/311#discussion_r5021037"},"pull_request":{"href":"https://api.github.com/repos/etsy/statsd/pulls/311"}}}} | {
"id": 1207300,
"name": "statsd",
"url": "https://github.com/etsy/statsd"
} | {
"id": null,
"login": "draco2003",
"gravatar_id": "9593180ec2004cbf2dd038ee7cc418ae",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "etsy",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-07-03T21:44:02 | null | {"repository":{"description":"Simple daemon for easy stats aggregation","homepage":"","watchers":4141,"stargazers":4141,"forks":643,"fork":false,"size":536,"owner":"etsy","private":false,"open_issues":23,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"JavaScript","created_at":"2010-12-29T16:09:50-08:00","pushed_at":"2013-07-03T14:28:37-07:00","master_branch":"master","organization":"etsy"},"actor_attributes":{"type":"User","name":"Dan Rowe","company":"Etsy","blog":"http://dracosplace.com","location":"Boston","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/etsy/statsd/pull/311#discussion_r5021037"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/mono/MonoGame/pulls/comments/6564095","id":6564095,"body":"So in all the other uses this was `handle.AddrOfPinnedObject().ToInt64()`. I can't say why we explicitly switched to 64bit here. It seems like if we did the math using `IntPtr` it should be 64bit automatically.\r\n\r\nThe \"safe\" fix may be to replicate the old behavior, but i'd like to know why first. Anyone know why it was done this way?","diff_hunk":"@@ -0,0 +1,15 @@\n+using System;\n+using System.Collections.Generic;\n+using System.Linq;\n+using System.Runtime.InteropServices;\n+using System.Text;\n+\n+namespace Microsoft.Xna.Framework.Internal {\n+ public static class UnsafeExtensions {\n+ public static IntPtr AddressWithOffset (this GCHandle handle, int offsetInBytes) {\n+ var address = handle.AddrOfPinnedObject();","path":"MonoGame.Framework/Utilities/Unsafe.cs","position":10,"original_position":10,"commit_id":"7dff98a566ea56db97d7f5f02146265dc751dec8","original_commit_id":"7dff98a566ea56db97d7f5f02146265dc751dec8","user":{"login":"tomspilman","id":103522,"avatar_url":"https://0.gravatar.com/avatar/8d025ee1bc863257127e15e64d6438b1?d=https%3A%2F%2Fidenticons.github.com%2F22aa4afb21f6341e431a9862debe0144.png","gravatar_id":"8d025ee1bc863257127e15e64d6438b1","url":"https://api.github.com/users/tomspilman","html_url":"https://github.com/tomspilman","followers_url":"https://api.github.com/users/tomspilman/followers","following_url":"https://api.github.com/users/tomspilman/following{/other_user}","gists_url":"https://api.github.com/users/tomspilman/gists{/gist_id}","starred_url":"https://api.github.com/users/tomspilman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomspilman/subscriptions","organizations_url":"https://api.github.com/users/tomspilman/orgs","repos_url":"https://api.github.com/users/tomspilman/repos","events_url":"https://api.github.com/users/tomspilman/events{/privacy}","received_events_url":"https://api.github.com/users/tomspilman/received_events","type":"User"},"created_at":"2013-09-25T05:00:33Z","updated_at":"2013-09-25T05:00:33Z","html_url":"https://github.com/mono/MonoGame/pull/2030#discussion_r6564095","pull_request_url":"https://api.github.com/repos/mono/MonoGame/pulls/2030","_links":{"self":{"href":"https://api.github.com/repos/mono/MonoGame/pulls/comments/6564095"},"html":{"href":"https://github.com/mono/MonoGame/pull/2030#discussion_r6564095"},"pull_request":{"href":"https://api.github.com/repos/mono/MonoGame/pulls/2030"}}}} | {
"id": 1579990,
"name": "MonoGame",
"url": "https://github.com/mono/MonoGame"
} | {
"id": null,
"login": "tomspilman",
"gravatar_id": "8d025ee1bc863257127e15e64d6438b1",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "mono",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-09-25T05:00:33 | null | {"repository":{"description":"Cross Platform Implementation of XNA for iOS, Android, Mac , Linux, Windows, Windows8, OUYA and Playstation Mobile","homepage":"http://www.monogame.net","watchers":1612,"stargazers":1612,"forks":851,"fork":false,"size":296389,"owner":"mono","private":false,"open_issues":18,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"C#","created_at":"2011-04-06T17:23:40-07:00","pushed_at":"2013-09-24T15:55:14-07:00","master_branch":"develop","organization":"mono"},"actor_attributes":{"type":"User","name":"Tom Spilman","company":"Sickhead Games, LLC","blog":"http://www.sickheadgames.com","location":"Dallas, Texas","email":"[email protected]"},"url":"https://github.com/mono/MonoGame/pull/2030#discussion_r6564095"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/nipy/dipy/pulls/comments/8518892","id":8518892,"diff_hunk":"@@ -2,12 +2,103 @@\n \"\"\" Counting incidence of tracks in voxels of volume\n \"\"\"\n \n+import cython\n+\n import numpy as np\n cimport numpy as cnp\n+from ._utils import _mapping_to_voxel, _to_voxel_coordinates\n \n cdef extern from \"dpy_math.h\":\n double floor(double x)\n \n+def streamline_mapping(streamlines, voxel_size=None, affine=None,\n+ mapping_as_streamlines=False):\n+ \"\"\"Creates a mapping from voxel indices to streamlines\n+\n+ Returns a dictionary where each key is a 3d voxel index and the associated\n+ value is a list of the streamlines that pass through that voxel.\n+\n+ Parameters\n+ ----------\n+ streamlines : sequence\n+ A sequence of streamlines.\n+ voxel_size : array_like (3,), optional\n+ The size of the voxels in the image volume. This is ignored if affine\n+ is set.\n+ affine : array_like (4, 4), optional\n+ The mapping from voxel coordinates to streamline coordinates. If\n+ neither `affine` or `voxel_size` is set, the streamline values are\n+ assumed to be in voxel coordinates. IE ``[0, 0, 0]`` is the center of\n+ the first voxel and the voxel size is ``[1, 1, 1]``.\n+ mapping_as_streamlines : bool, optional, False by default\n+ If True voxel indices map to lists of streamline objects. Otherwise\n+ voxel indices map to lists of integers.\n+\n+ Returns\n+ -------\n+ mapping : defaultdict(list)\n+ A mapping from voxel indices to the streamlines that pass though that","path":"dipy/tracking/vox2track.pyx","position":39,"original_position":39,"commit_id":"3221c464a97bf42dda531d10ddd36088c42f1c0f","original_commit_id":"3221c464a97bf42dda531d10ddd36088c42f1c0f","user":{"login":"samuelstjean","id":3030760,"avatar_url":"https://gravatar.com/avatar/aa563b059bc3a3c024d01efc4d7cf006?d=https%3A%2F%2Fidenticons.github.com%2F916aa2bffed0c23062c3c745ea325d94.png&r=x","gravatar_id":"aa563b059bc3a3c024d01efc4d7cf006","url":"https://api.github.com/users/samuelstjean","html_url":"https://github.com/samuelstjean","followers_url":"https://api.github.com/users/samuelstjean/followers","following_url":"https://api.github.com/users/samuelstjean/following{/other_user}","gists_url":"https://api.github.com/users/samuelstjean/gists{/gist_id}","starred_url":"https://api.github.com/users/samuelstjean/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samuelstjean/subscriptions","organizations_url":"https://api.github.com/users/samuelstjean/orgs","repos_url":"https://api.github.com/users/samuelstjean/repos","events_url":"https://api.github.com/users/samuelstjean/events{/privacy}","received_events_url":"https://api.github.com/users/samuelstjean/received_events","type":"User","site_admin":false},"body":"thRough","created_at":"2013-12-22T00:33:36Z","updated_at":"2013-12-22T00:33:36Z","html_url":"https://github.com/nipy/dipy/pull/250#discussion_r8518892","pull_request_url":"https://api.github.com/repos/nipy/dipy/pulls/250","_links":{"self":{"href":"https://api.github.com/repos/nipy/dipy/pulls/comments/8518892"},"html":{"href":"https://github.com/nipy/dipy/pull/250#discussion_r8518892"},"pull_request":{"href":"https://api.github.com/repos/nipy/dipy/pulls/250"}}}} | {
"id": 505209,
"name": "dipy",
"url": "https://github.com/nipy/dipy"
} | {
"id": null,
"login": "samuelstjean",
"gravatar_id": "aa563b059bc3a3c024d01efc4d7cf006",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "nipy",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-12-22T00:33:36 | null | {"repository":{"description":"Diffusion MR Imaging in Python","homepage":"http://dipy.org","watchers":39,"stargazers":39,"forks":50,"fork":false,"size":14077,"owner":"nipy","private":false,"open_issues":37,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Python","created_at":"2010-02-06T03:43:08-08:00","pushed_at":"2013-12-21T16:15:16-08:00","master_branch":"master","organization":"nipy"},"actor_attributes":{"type":"User","name":"Samuel St-Jean","blog":"http://samuelstjean.github.io/","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/nipy/dipy/pull/250#discussion_r8518892"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/nipy/dipy/pulls/comments/6939329","id":6939329,"diff_hunk":"@@ -0,0 +1,81 @@\n+import numpy as np\r\n+import pylab as py\r","path":"dipy/reconst/tests/test_shore.py","position":2,"original_position":2,"commit_id":"8d31123fa37c02a36de7270b10c573d1e2c8967d","original_commit_id":"8d31123fa37c02a36de7270b10c573d1e2c8967d","user":{"login":"maurozucchelli","id":5042250,"avatar_url":"https://2.gravatar.com/avatar/4370b64027ff4fdc5ce77fb8f9f3bc3e?d=https%3A%2F%2Fidenticons.github.com%2F043badad30236d2ca3f7203e39d7585e.png","gravatar_id":"4370b64027ff4fdc5ce77fb8f9f3bc3e","url":"https://api.github.com/users/maurozucchelli","html_url":"https://github.com/maurozucchelli","followers_url":"https://api.github.com/users/maurozucchelli/followers","following_url":"https://api.github.com/users/maurozucchelli/following{/other_user}","gists_url":"https://api.github.com/users/maurozucchelli/gists{/gist_id}","starred_url":"https://api.github.com/users/maurozucchelli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maurozucchelli/subscriptions","organizations_url":"https://api.github.com/users/maurozucchelli/orgs","repos_url":"https://api.github.com/users/maurozucchelli/repos","events_url":"https://api.github.com/users/maurozucchelli/events{/privacy}","received_events_url":"https://api.github.com/users/maurozucchelli/received_events","type":"User","site_admin":false},"body":"Yes, I didn't know that Tau was already in gtab,\r\nI will make all the modify now!\r\n\r\n\r\nOn Mon, Oct 14, 2013 at 12:25 AM, Eleftherios Garyfallidis <\r\[email protected]> wrote:\r\n\r\n> In dipy/reconst/tests/test_shore.py:\r\n>\r\n> > @@ -0,0 +1,81 @@\r\n> > +import numpy as np\r\n> > +import pylab as py\r\n>\r\n> This is a good point @arokem <https://github.com/arokem>. @maurozucchelli<https://github.com/maurozucchelli>this pylab is what makes travis fail. Please remove.\r\n>\r\n> —\r\n> Reply to this email directly or view it on GitHub<https://github.com/nipy/dipy/pull/257/files#r6936205>\r\n> .\r\n>","created_at":"2013-10-14T08:35:59Z","updated_at":"2013-10-14T08:35:59Z","html_url":"https://github.com/nipy/dipy/pull/257#discussion_r6939329","pull_request_url":"https://api.github.com/repos/nipy/dipy/pulls/257","_links":{"self":{"href":"https://api.github.com/repos/nipy/dipy/pulls/comments/6939329"},"html":{"href":"https://github.com/nipy/dipy/pull/257#discussion_r6939329"},"pull_request":{"href":"https://api.github.com/repos/nipy/dipy/pulls/257"}}}} | {
"id": 505209,
"name": "dipy",
"url": "https://github.com/nipy/dipy"
} | {
"id": null,
"login": "maurozucchelli",
"gravatar_id": "4370b64027ff4fdc5ce77fb8f9f3bc3e",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "nipy",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-10-14T08:35:59 | null | {"repository":{"description":"Diffusion MR Imaging in Python","homepage":"http://dipy.org","watchers":37,"stargazers":37,"forks":48,"fork":false,"size":12843,"owner":"nipy","private":false,"open_issues":4,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Python","created_at":"2010-02-06T03:43:08-08:00","pushed_at":"2013-10-08T14:32:45-07:00","master_branch":"master","organization":"nipy"},"actor_attributes":{"type":"User","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/nipy/dipy/pull/257#discussion_r6939329"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/pulp/pulp/pulls/comments/3015855","id":3015855,"body":"regular English double quotes","path":"docs/sphinx/dev-guide/newtypesupport/plugin/migrations.rst","position":90,"original_position":90,"commit_id":"769e20f34a905dc8090b5b2d9c5ed934d09b4d97","original_commit_id":"769e20f34a905dc8090b5b2d9c5ed934d09b4d97","user":{"login":"mhrivnak","id":53091,"avatar_url":"https://secure.gravatar.com/avatar/06b29370cfbe838c3ed487118738d24e?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"06b29370cfbe838c3ed487118738d24e","url":"https://api.github.com/users/mhrivnak","followers_url":"https://api.github.com/users/mhrivnak/followers","following_url":"https://api.github.com/users/mhrivnak/following","gists_url":"https://api.github.com/users/mhrivnak/gists{/gist_id}","starred_url":"https://api.github.com/users/mhrivnak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhrivnak/subscriptions","organizations_url":"https://api.github.com/users/mhrivnak/orgs","repos_url":"https://api.github.com/users/mhrivnak/repos","events_url":"https://api.github.com/users/mhrivnak/events{/privacy}","received_events_url":"https://api.github.com/users/mhrivnak/received_events","type":"User"},"created_at":"2013-02-14T16:48:13Z","updated_at":"2013-02-14T16:48:13Z","_links":{"self":{"href":"https://api.github.com/repos/pulp/pulp/pulls/comments/3015855"},"html":{"href":"https://github.com/pulp/pulp/pull/289#discussion_r3015855"},"pull_request":{"href":"https://api.github.com/repos/pulp/pulp/pulls/289"}}}} | {
"id": 5314652,
"name": "pulp",
"url": "https://github.com/pulp/pulp"
} | {
"id": null,
"login": "mhrivnak",
"gravatar_id": "06b29370cfbe838c3ed487118738d24e",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "pulp",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-02-14T16:48:13 | null | {"repository":{"description":"Repository for Pulp platform code, including the server and base admin and consumer clients","homepage":"","watchers":25,"stargazers":25,"forks":17,"fork":false,"size":3596,"owner":"pulp","private":false,"open_issues":8,"has_issues":true,"has_downloads":true,"has_wiki":false,"language":"Python","created_at":"2012-08-06T06:49:20-07:00","pushed_at":"2013-02-14T08:44:04-08:00","master_branch":"master","organization":"pulp"},"actor_attributes":{"name":"Michael Hrivnak","company":"Red Hat, Inc.","location":"Raleigh, NC","type":"User","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/pulp/pulp/pull/289#discussion_r3015855"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/pulp/pulp/pulls/comments/3556815","id":3556815,"body":"I see your point, and have the subclass set it. But see my other comment about why the task is passed in. I wanted the subclass to have the ability to inspect the task and potentially use its data in the message.\r\n\r\nI'll be honest, it's likely a tad overengineered. I went a little crazy with the hooks, but since I knew this was gonna be used in a bunch of different areas, I didn't want any display text hardcoded, forcing the subclass to override a logic method just to introduce custom text.","diff_hunk":"@@ -215,13 +227,16 @@ def task_header(self, task):\n def waiting(self, task):\n \"\"\"\n Called while an accepted task (i.e. not postponed) is waiting to begin.\n- Subclasses may override this to display a custom message to the user.\n+ Subclasses may override this to return a custom message to the user.\n \n :param task: full task report for the task being displayed\n :type task: pulp.bindings.responses.Task\n+\n+ :return: message to be displayed with the progress spinner; must not contain \\n\n+ :rtype: str\n \"\"\"\n msg = _('Waiting to begin...')\n- self.prompt.write(msg, tag='waiting')\n+ return msg","path":"platform/src/pulp/client/commands/polling.py","position":87,"original_position":87,"commit_id":"1c11f357d83ba41dfce3942cc1c2fef42ecc252d","original_commit_id":"1c11f357d83ba41dfce3942cc1c2fef42ecc252d","user":{"login":"jdob","id":128268,"avatar_url":"https://secure.gravatar.com/avatar/68f0e8e8cb5deaf40ad4858efce8e559?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"68f0e8e8cb5deaf40ad4858efce8e559","url":"https://api.github.com/users/jdob","html_url":"https://github.com/jdob","followers_url":"https://api.github.com/users/jdob/followers","following_url":"https://api.github.com/users/jdob/following","gists_url":"https://api.github.com/users/jdob/gists{/gist_id}","starred_url":"https://api.github.com/users/jdob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdob/subscriptions","organizations_url":"https://api.github.com/users/jdob/orgs","repos_url":"https://api.github.com/users/jdob/repos","events_url":"https://api.github.com/users/jdob/events{/privacy}","received_events_url":"https://api.github.com/users/jdob/received_events","type":"User"},"created_at":"2013-03-27T18:22:09Z","updated_at":"2013-03-27T18:22:09Z","html_url":"https://github.com/pulp/pulp/pull/415#discussion_r3556815","pull_request_url":"https://api.github.com/repos/pulp/pulp/pulls/415","_links":{"self":{"href":"https://api.github.com/repos/pulp/pulp/pulls/comments/3556815"},"html":{"href":"https://github.com/pulp/pulp/pull/415#discussion_r3556815"},"pull_request":{"href":"https://api.github.com/repos/pulp/pulp/pulls/415"}}}} | {
"id": 5314652,
"name": "pulp",
"url": "https://github.com/pulp/pulp"
} | {
"id": null,
"login": "jdob",
"gravatar_id": "68f0e8e8cb5deaf40ad4858efce8e559",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "pulp",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-03-27T18:22:09 | null | {"repository":{"description":"Repository for Pulp platform code, including the server and base admin and consumer clients","homepage":"","watchers":29,"stargazers":29,"forks":20,"fork":false,"size":4392,"owner":"pulp","private":false,"open_issues":6,"has_issues":true,"has_downloads":true,"has_wiki":false,"language":"Python","created_at":"2012-08-06T06:49:20-07:00","pushed_at":"2013-03-27T11:15:37-07:00","master_branch":"master","organization":"pulp"},"actor_attributes":{"type":"User","name":"Jay Dobies","company":"Red Hat","blog":"http://noopenblockers.com","location":"New Jersey","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/pulp/pulp/pull/415#discussion_r3556815"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/pulp/pulp/pulls/comments/6627277","id":6627277,"body":"\"until *then*\"","diff_hunk":"@@ -0,0 +1,26 @@\n+# -*- coding: utf-8 -*-\n+#\n+# Copyright © 2013 Red Hat, Inc.\n+#\n+# This software is licensed to you under the GNU General Public\n+# License as published by the Free Software Foundation; either version\n+# 2 of the License (GPLv2) or (at your option) any later version.\n+# There is NO WARRANTY for this software, express or implied,\n+# including the implied warranties of MERCHANTABILITY,\n+# NON-INFRINGEMENT, or FITNESS FOR A PARTICULAR PURPOSE. You should\n+# have received a copy of GPLv2 along with this software; if not, see\n+# http://www.gnu.org/licenses/old-licenses/gpl-2.0.txt.\n+\"\"\"\n+Due to our factory, we cannot put the instantiation of the Celery application into our app.py\n+module, as it will lead to circular dependencies since tasks.py also need to import this object, and\n+the factory ends up importing tasks.py when it imports all the managers.\n+\n+Hopefully we will eliminate the factory in the future, but until this this workaround is necessary.","path":"server/pulp/server/async/celery_instance.py","position":18,"original_position":18,"commit_id":"323968db03c21677774e4c283a4c21c0e47f08b7","original_commit_id":"323968db03c21677774e4c283a4c21c0e47f08b7","user":{"login":"mhrivnak","id":53091,"avatar_url":"https://2.gravatar.com/avatar/06b29370cfbe838c3ed487118738d24e?d=https%3A%2F%2Fidenticons.github.com%2F4f2f638f5e4bdb50b21926f49a69f128.png","gravatar_id":"06b29370cfbe838c3ed487118738d24e","url":"https://api.github.com/users/mhrivnak","html_url":"https://github.com/mhrivnak","followers_url":"https://api.github.com/users/mhrivnak/followers","following_url":"https://api.github.com/users/mhrivnak/following{/other_user}","gists_url":"https://api.github.com/users/mhrivnak/gists{/gist_id}","starred_url":"https://api.github.com/users/mhrivnak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhrivnak/subscriptions","organizations_url":"https://api.github.com/users/mhrivnak/orgs","repos_url":"https://api.github.com/users/mhrivnak/repos","events_url":"https://api.github.com/users/mhrivnak/events{/privacy}","received_events_url":"https://api.github.com/users/mhrivnak/received_events","type":"User"},"created_at":"2013-09-27T13:24:24Z","updated_at":"2013-09-27T13:24:24Z","html_url":"https://github.com/pulp/pulp/pull/639#discussion_r6627277","pull_request_url":"https://api.github.com/repos/pulp/pulp/pulls/639","_links":{"self":{"href":"https://api.github.com/repos/pulp/pulp/pulls/comments/6627277"},"html":{"href":"https://github.com/pulp/pulp/pull/639#discussion_r6627277"},"pull_request":{"href":"https://api.github.com/repos/pulp/pulp/pulls/639"}}}} | {
"id": 5314652,
"name": "pulp",
"url": "https://github.com/pulp/pulp"
} | {
"id": null,
"login": "mhrivnak",
"gravatar_id": "06b29370cfbe838c3ed487118738d24e",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "pulp",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-09-27T13:24:24 | null | {"repository":{"description":"Repository for Pulp platform code, including the server and base admin and consumer clients","homepage":"","watchers":67,"stargazers":67,"forks":30,"fork":false,"size":67272,"owner":"pulp","private":false,"open_issues":5,"has_issues":true,"has_downloads":true,"has_wiki":false,"language":"Python","created_at":"2012-08-06T06:49:20-07:00","pushed_at":"2013-09-27T06:22:44-07:00","master_branch":"master","organization":"pulp"},"actor_attributes":{"type":"User","name":"Michael Hrivnak","company":"Red Hat, Inc.","location":"Raleigh, NC","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/pulp/pulp/pull/639#discussion_r6627277"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/pulp/pulp_rpm/pulls/comments/3175882","id":3175882,"body":"\"features\" is a bit vague, though the whole string feels a bit... dunno, awkward. Perhaps rephrase to mention it refers to handling RPMs installed on the consumer.","diff_hunk":"@@ -21,18 +21,24 @@\n \n # -- framework hook -----------------------------------------------------------\n \n+RPM_SECTION = 'rpm'\n+SECTION_DESC = _('manage RPM-related features')","path":"pulp_rpm/extensions/consumer/rpm_consumer/pulp_cli.py","position":5,"original_position":5,"commit_id":"119480f203a0700595e35ad00102bbd70f49c251","original_commit_id":"119480f203a0700595e35ad00102bbd70f49c251","user":{"login":"jdob","id":128268,"avatar_url":"https://secure.gravatar.com/avatar/68f0e8e8cb5deaf40ad4858efce8e559?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"68f0e8e8cb5deaf40ad4858efce8e559","url":"https://api.github.com/users/jdob","html_url":"https://github.com/jdob","followers_url":"https://api.github.com/users/jdob/followers","following_url":"https://api.github.com/users/jdob/following","gists_url":"https://api.github.com/users/jdob/gists{/gist_id}","starred_url":"https://api.github.com/users/jdob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdob/subscriptions","organizations_url":"https://api.github.com/users/jdob/orgs","repos_url":"https://api.github.com/users/jdob/repos","events_url":"https://api.github.com/users/jdob/events{/privacy}","received_events_url":"https://api.github.com/users/jdob/received_events","type":"User"},"created_at":"2013-02-27T18:55:08Z","updated_at":"2013-02-27T18:55:08Z","_links":{"self":{"href":"https://api.github.com/repos/pulp/pulp_rpm/pulls/comments/3175882"},"html":{"href":"https://github.com/pulp/pulp_rpm/pull/125#discussion_r3175882"},"pull_request":{"href":"https://api.github.com/repos/pulp/pulp_rpm/pulls/125"}}}} | {
"id": 6106345,
"name": "pulp_rpm",
"url": "https://github.com/pulp/pulp_rpm"
} | {
"id": null,
"login": "jdob",
"gravatar_id": "68f0e8e8cb5deaf40ad4858efce8e559",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "pulp",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-02-27T18:55:08 | null | {"repository":{"description":"RPM support for Pulp Platform","watchers":2,"stargazers":2,"forks":8,"fork":false,"size":1232,"owner":"pulp","private":false,"open_issues":1,"has_issues":true,"has_downloads":true,"has_wiki":false,"language":"Python","created_at":"2012-10-06T13:06:16-07:00","pushed_at":"2013-02-27T08:10:34-08:00","master_branch":"master","organization":"pulp"},"actor_attributes":{"type":"User","name":"Jay Dobies","company":"Red Hat","blog":"http://noopenblockers.com","location":"New Jersey","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/pulp/pulp_rpm/pull/125#discussion_r3175882"} |
PullRequestReviewCommentEvent | true | {"comment":{"original_commit_id":"f937140cb44fd7bfd7d21cb61f8f40fe9018d5e4","position":82,"created_at":"2013-01-31T22:18:59Z","updated_at":"2013-01-31T22:18:59Z","url":"https://api.github.com/repos/pulp/pulp/pulls/comments/2852062","id":2852062,"commit_id":"f937140cb44fd7bfd7d21cb61f8f40fe9018d5e4","path":"citrus/plugins/importers/citrus_http_importer/importer.py","original_position":82,"_links":{"pull_request":{"href":"https://api.github.com/repos/pulp/pulp/pulls/273"},"self":{"href":"https://api.github.com/repos/pulp/pulp/pulls/comments/2852062"},"html":{"href":"https://github.com/pulp/pulp/pull/273#discussion_r2852062"}},"body":"I'm a fan of only having this line in the try block, to avoid catching programming errors along with runtime errors (such as network errors).","user":{"received_events_url":"https://api.github.com/users/jlconnor/received_events","events_url":"https://api.github.com/users/jlconnor/events{/privacy}","organizations_url":"https://api.github.com/users/jlconnor/orgs","url":"https://api.github.com/users/jlconnor","id":100757,"following_url":"https://api.github.com/users/jlconnor/following","login":"jlconnor","followers_url":"https://api.github.com/users/jlconnor/followers","starred_url":"https://api.github.com/users/jlconnor/starred{/owner}{/repo}","avatar_url":"https://secure.gravatar.com/avatar/4f537432611bafa09247a28a10757af2?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","subscriptions_url":"https://api.github.com/users/jlconnor/subscriptions","type":"User","repos_url":"https://api.github.com/users/jlconnor/repos","gists_url":"https://api.github.com/users/jlconnor/gists{/gist_id}","gravatar_id":"4f537432611bafa09247a28a10757af2"}}} | {
"id": 5314652,
"name": "pulp",
"url": "https://github.com/pulp/pulp"
} | {
"id": null,
"login": "jlconnor",
"gravatar_id": "4f537432611bafa09247a28a10757af2",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "pulp",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-01-31T22:18:59 | null | {"repository":{"open_issues":5,"pushed_at":"2013-01-31T14:15:50-08:00","forks":17,"owner":"pulp","created_at":"2012-08-06T06:49:20-07:00","homepage":"","has_issues":true,"has_downloads":true,"description":"Repository for Pulp platform code, including the server and base admin and consumer clients","language":"Python","fork":false,"size":3516,"watchers":24,"private":false,"has_wiki":false,"organization":"pulp","stargazers":24},"actor_attributes":{"location":"Fort Collins, CO, USA","blog":"jasonconnor.me","type":"User","name":"Jason L Connor","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709","company":"Red Hat, Inc."},"url":"https://github.com/pulp/pulp/pull/273#discussion_r2852062"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/pulp/pulp/pulls/comments/7188287","id":7188287,"diff_hunk":"@@ -10,25 +10,269 @@\n # NON-INFRINGEMENT, or FITNESS FOR A PARTICULAR PURPOSE. You should\n # have received a copy of GPLv2 along with this software; if not, see\n # http://www.gnu.org/licenses/old-licenses/gpl-2.0.txt.\n-from celery import Task as CeleryTask\n+from gettext import gettext as _\n+\n+from celery import chain, task, Task as CeleryTask\n from celery.app import control\n \n from pulp.server.async.celery_instance import celery\n \n \n+DEFAULT_CELERY_QUEUE = 'celery'\n+RESOURCE_MANAGER_QUEUE = 'resource_manager'\n+\n+\n controller = control.Control(app=celery)\n+# The singleton ResourceManager will be stored here when and if it is instantiated. Only one worker\n+# should do this.\n+_resource_manager = None\n \n \n-class Task(CeleryTask):\n+class NoAvailableQueues(Exception):\n \"\"\"\n- This is a custom Pulp subclass of the Celery Task object. It allows us to inject some custom\n- behavior into each Pulp task, including management of resource locking.\n+ This Exception is raised by ResourceManager._get_workers_available_queue_stats() if the given\n+ worker does not have any available queues for reserved work. It can also be raised by\n+ ResourceManager._get_available_queue() if no queues can be found in the system.\n+ \"\"\"\n+ pass\n+\n+\n+class ResourceManager(object):\n+ \"\"\"\n+ Do not instantiate this object yourself! It must be a singleton. You can get the singleton\n+ instance from the _get_resource_manager() function. Also, do not use the ResourceManager\n+ directly unless you have thought about what you are doing very carefully. You should generally\n+ only use the _reserve_resource() and _queue_release_resource() functions from this module\n+ instead of the ResourceManager's methods.\n+\n+ The ResourceManager exists to help ensure that tasks that need to happen sequentially do not get\n+ processed in parallel. It is important that this class be a singleton across the entire Pulp\n+ installation, which can only be guaranteed if only one Celery worker is subscribed to work on\n+ tasks in the special named queue, RESOURCE_MANAGER_QUEUE, and that Celery worker has its\n+ concurrency set to 1.\n \"\"\"\n+ def __init__(self):\n+ \"\"\"\n+ Do not instantiate this object yourself! It must be a singleton. You can get the singleton\n+ instance from the _get_resource_manager() function.\n+\n+ Inspect the existing workers and the queues they are subscribed to. This information will be\n+ used to initialize the ResourceManager's state tables that it will use to route reserved\n+ tasks to the appropriate queues.\n+ \"\"\"\n+ # Map available queue names to their current loads\n+ self._available_queue_task_counts = {}\n+ # Map worker names to a list of reserved task queues that they are assigned to\n+ self._worker_queues = {}\n+ # Map resource_ids to the queue they are supposed to go to, and the number of tasks for the\n+ # resource\n+ self._resource_map = {}\n+\n+ # Inspect the available workers to build our state variables\n+ active_queues = controller.inspect().active_queues()\n+ for worker, queues in active_queues.items():\n+ self._worker_queues[worker] = []\n+ for queue in queues:\n+ # If the queue in question is not the normal celery queue or the special resource\n+ # manager queue, it is assumed to be a reserved instance queue\n+ if queue['name'] not in [DEFAULT_CELERY_QUEUE, RESOURCE_MANAGER_QUEUE]:\n+ self._available_queue_task_counts[queue['name']] = 0\n+ self._worker_queues[worker].append(queue['name'])\n+ # If the worker doesn't have any reserved task queues, let's remove it from our worker\n+ # table\n+ if self._worker_queues[worker] == []:\n+ del self._worker_queues[worker]\n+\n+ def release_resource(self, resource_id):\n+ \"\"\"\n+ When a resource-reserving task is complete, this method must be called with the\n+ resource_id so that the ResourceManager knows when it is safe to unmap a resource_id from\n+ its given queue name.\n+\n+ :param resource_id: The resource that is no longer in use\n+ :type resource_id: basestring\n+ \"\"\"\n+ try:\n+ self._resource_map[resource_id]['task_count'] -= 1\n+ # Let's keep from going negative on our queue task counts. This could happen if the\n+ # ResourceManager is restarted when the queue lengths were non-zero, since it\n+ # initializes the queue counts to 0.\n+ if self._available_queue_task_counts[self._resource_map[resource_id]['queue']]:\n+ self._available_queue_task_counts[self._resource_map[resource_id]['queue']] -= 1\n+\n+ if not self._resource_map[resource_id]['task_count']:\n+ del self._resource_map[resource_id]\n+ except KeyError:\n+ # If we are asked to release a resource that we don't have reserved, it is weird, but we\n+ # don't want to raise an Exception about it because our state does have that resource\n+ # unreserved. This could happen, for example, if the ResourceManager is restarted while\n+ # there is already work in queues.\n+ pass\n+\n+ def reserve_resource(self, resource_id):\n+ \"\"\"\n+ Return the name of a Celery queue that can be used to queue tasks that use the given\n+ resource_id.\n+\n+ :param resource_id: The ID of the resource that the caller wishes to process in a job queue\n+ :type resource_id: basestring\n+ :return: The name of a Celery queue that the task that wishes to use the given\n+ resource_id should be queued inside of.\n+ :rtype: basestr\n+ \"\"\"\n+ if resource_id in self._resource_map:\n+ self._resource_map[resource_id]['task_count'] += 1\n+ queue = self._resource_map[resource_id]['queue']\n+ else:\n+ queue = self._get_available_queue()\n+ self._resource_map[resource_id] = {'queue': queue, 'task_count': 1}\n+\n+ self._available_queue_task_counts[queue] += 1\n+ return queue\n+\n+ def _get_available_queue(self):\n+ \"\"\"\n+ Find the worker with the fewest assigned tasks, and return a queue name that is assigned to\n+ that worker.\n+\n+ :return: The name of an available queue\n+ :rtype: basestring\n+ \"\"\"\n+ least_busy_worker_task_count = None\n+ least_busy_worker_queue = None\n+ # Loop over our available workers, comparing them to find the least busy one\n+ for worker in self._worker_queues.keys():\n+ try:\n+ stats = self._get_workers_available_queue_stats(worker)\n+ except NoAvailableQueues:\n+ # If this worker doesn't have any available queues, let's continue\n+ continue\n+ # If this worker is less busy than the least busy one we've found so far, or if it's the\n+ # first worker we've found with an available queue, mark it.\n+ if stats['num_tasks'] < least_busy_worker_task_count \\\n+ or least_busy_worker_task_count is None:\n+ least_busy_worker_task_count = stats['num_tasks']\n+ least_busy_worker_queue = stats['least_busy_queue']\n+\n+ if least_busy_worker_queue is None:\n+ msg = _('There are no available queues in the system for reserved task work.')\n+ raise NoAvailableQueues(msg)\n+ return least_busy_worker_queue\n+\n+ def _get_workers_available_queue_stats(self, worker):\n+ \"\"\"\n+ Given a worker's name, find out how many tasks are assigned to it by considering the queues\n+ it's assigned to work on that are also in our self._available_queue_task_counts table.\n+ Return a dictionary that includes the total number of tasks found in the workers available\n+ queues, well as the name of its least busy queue. These are indexed by 'num_tasks' and","path":"server/pulp/server/async/tasks.py","position":162,"original_position":162,"commit_id":"57ba36047e71d4df73d8a59824433e09fe59e588","original_commit_id":"57ba36047e71d4df73d8a59824433e09fe59e588","user":{"login":"mhrivnak","id":53091,"avatar_url":"https://1.gravatar.com/avatar/06b29370cfbe838c3ed487118738d24e?d=https%3A%2F%2Fidenticons.github.com%2F4f2f638f5e4bdb50b21926f49a69f128.png&r=x","gravatar_id":"06b29370cfbe838c3ed487118738d24e","url":"https://api.github.com/users/mhrivnak","html_url":"https://github.com/mhrivnak","followers_url":"https://api.github.com/users/mhrivnak/followers","following_url":"https://api.github.com/users/mhrivnak/following{/other_user}","gists_url":"https://api.github.com/users/mhrivnak/gists{/gist_id}","starred_url":"https://api.github.com/users/mhrivnak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhrivnak/subscriptions","organizations_url":"https://api.github.com/users/mhrivnak/orgs","repos_url":"https://api.github.com/users/mhrivnak/repos","events_url":"https://api.github.com/users/mhrivnak/events{/privacy}","received_events_url":"https://api.github.com/users/mhrivnak/received_events","type":"User","site_admin":false},"body":"s/well/as well","created_at":"2013-10-24T13:56:32Z","updated_at":"2013-10-24T13:56:32Z","html_url":"https://github.com/pulp/pulp/pull/673#discussion_r7188287","pull_request_url":"https://api.github.com/repos/pulp/pulp/pulls/673","_links":{"self":{"href":"https://api.github.com/repos/pulp/pulp/pulls/comments/7188287"},"html":{"href":"https://github.com/pulp/pulp/pull/673#discussion_r7188287"},"pull_request":{"href":"https://api.github.com/repos/pulp/pulp/pulls/673"}}}} | {
"id": 5314652,
"name": "pulp",
"url": "https://github.com/pulp/pulp"
} | {
"id": null,
"login": "mhrivnak",
"gravatar_id": "06b29370cfbe838c3ed487118738d24e",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "pulp",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-10-24T13:56:32 | null | {"repository":{"description":"Repository for Pulp platform code, including the server and base admin and consumer clients","homepage":"","watchers":73,"stargazers":73,"forks":33,"fork":false,"size":68974,"owner":"pulp","private":false,"open_issues":4,"has_issues":true,"has_downloads":true,"has_wiki":false,"language":"Python","created_at":"2012-08-06T06:49:20-07:00","pushed_at":"2013-10-24T06:40:52-07:00","master_branch":"master","organization":"pulp"},"actor_attributes":{"type":"User","name":"Michael Hrivnak","company":"Red Hat, Inc.","location":"Raleigh, NC","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/pulp/pulp/pull/673#discussion_r7188287"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/pyne/pyne/pulls/comments/8311270","id":8311270,"diff_hunk":"@@ -312,7 +350,7 @@ def read_tracklist(self):\n for j in range(self.nrss):\n trackInfo = self.get_fortran_record()\n trackData = TrackData()","path":"pyne/mcnp.py","position":124,"original_position":124,"commit_id":"47c353bd3d1f5dfb8e4547f3c967329c30afb565","original_commit_id":"47c353bd3d1f5dfb8e4547f3c967329c30afb565","user":{"login":"scopatz","id":320553,"avatar_url":"https://gravatar.com/avatar/a6e6385b7870c04692700df9ba93eb27?d=https%3A%2F%2Fidenticons.github.com%2F428e35bdbf7d56719b4e42c16322333e.png&r=x","gravatar_id":"a6e6385b7870c04692700df9ba93eb27","url":"https://api.github.com/users/scopatz","html_url":"https://github.com/scopatz","followers_url":"https://api.github.com/users/scopatz/followers","following_url":"https://api.github.com/users/scopatz/following{/other_user}","gists_url":"https://api.github.com/users/scopatz/gists{/gist_id}","starred_url":"https://api.github.com/users/scopatz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scopatz/subscriptions","organizations_url":"https://api.github.com/users/scopatz/orgs","repos_url":"https://api.github.com/users/scopatz/repos","events_url":"https://api.github.com/users/scopatz/events{/privacy}","received_events_url":"https://api.github.com/users/scopatz/received_events","type":"User","site_admin":false},"body":"PEP8 no camel case, variables should be lowercase_with_underscores.","created_at":"2013-12-12T19:30:01Z","updated_at":"2013-12-12T19:30:01Z","html_url":"https://github.com/pyne/pyne/pull/223#discussion_r8311270","pull_request_url":"https://api.github.com/repos/pyne/pyne/pulls/223","_links":{"self":{"href":"https://api.github.com/repos/pyne/pyne/pulls/comments/8311270"},"html":{"href":"https://github.com/pyne/pyne/pull/223#discussion_r8311270"},"pull_request":{"href":"https://api.github.com/repos/pyne/pyne/pulls/223"}}}} | {
"id": 1684953,
"name": "pyne",
"url": "https://github.com/pyne/pyne"
} | {
"id": null,
"login": "scopatz",
"gravatar_id": "a6e6385b7870c04692700df9ba93eb27",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "pyne",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-12-12T19:30:01 | null | {"repository":{"description":"PyNE: The Nuclear Engineering Toolkit","homepage":"http://pynesim.org/","watchers":23,"stargazers":23,"forks":29,"fork":false,"size":10435,"owner":"pyne","private":false,"open_issues":42,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"C++","created_at":"2011-04-30T08:04:07-07:00","pushed_at":"2013-12-10T23:01:06-08:00","master_branch":"staging","organization":"pyne"},"actor_attributes":{"type":"User","name":"Anthony Scopatz","company":"The University of Wisconsin-Madison & NumFOCUS, Inc.","blog":"http://www.scopatz.com","location":"Chicago, IL","email":"[email protected]"},"url":"https://github.com/pyne/pyne/pull/223#discussion_r8311270"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/xbmc/xbmc/pulls/comments/7553973","id":7553973,"diff_hunk":"@@ -736,6 +736,24 @@\n </setting>\n </group>\n <group id=\"2\">\n+ <setting id=\"subtitles.savetomoviefolder\" type=\"boolean\" label=\"24104\" help=\"24106\">\n+ <level>1</level>\n+ <default>true</default>\n+ </setting>\n+ <setting id=\"subtitles.pauseonsearch\" type=\"boolean\" label=\"24105\" help=\"\">\n+ <level>1</level>\n+ <default>true</default>\n+ </setting>\n+ <setting id=\"subtitles.languages\" type=\"list[string]\" label=\"24111\" help=\"24112\">\n+ <level>1</level>\n+ <default>English</default>\n+ <constraints>\n+ <options>languages</options>\n+ <delimiter>,</delimiter>\n+ <minimum>1</minimum>\n+ </constraints>\n+ <control type=\"list\" format=\"string\" />","path":"system/settings/settings.xml","position":null,"original_position":20,"commit_id":"d0f90ec462454858a7e83721d3c67cfcf6af956b","original_commit_id":"801b3adc5ab2ecae6f94e1df1ffa3f854a6dfcaa","user":{"login":"jmarshallnz","id":406571,"avatar_url":"https://2.gravatar.com/avatar/f2f465d1d46f3f4436a7658f9817fa95?d=https%3A%2F%2Fidenticons.github.com%2F205e230239563b1219977f6b26fdf1e1.png&r=x","gravatar_id":"f2f465d1d46f3f4436a7658f9817fa95","url":"https://api.github.com/users/jmarshallnz","html_url":"https://github.com/jmarshallnz","followers_url":"https://api.github.com/users/jmarshallnz/followers","following_url":"https://api.github.com/users/jmarshallnz/following{/other_user}","gists_url":"https://api.github.com/users/jmarshallnz/gists{/gist_id}","starred_url":"https://api.github.com/users/jmarshallnz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmarshallnz/subscriptions","organizations_url":"https://api.github.com/users/jmarshallnz/orgs","repos_url":"https://api.github.com/users/jmarshallnz/repos","events_url":"https://api.github.com/users/jmarshallnz/events{/privacy}","received_events_url":"https://api.github.com/users/jmarshallnz/received_events","type":"User","site_admin":false},"body":"Yup - was waiting for it to build before testing :p Fixed.","created_at":"2013-11-11T08:23:19Z","updated_at":"2013-11-11T08:23:19Z","html_url":"https://github.com/xbmc/xbmc/pull/3552#discussion_r7553973","pull_request_url":"https://api.github.com/repos/xbmc/xbmc/pulls/3552","_links":{"self":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/comments/7553973"},"html":{"href":"https://github.com/xbmc/xbmc/pull/3552#discussion_r7553973"},"pull_request":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/3552"}}}} | {
"id": 1217614,
"name": "xbmc",
"url": "https://github.com/xbmc/xbmc"
} | {
"id": null,
"login": "jmarshallnz",
"gravatar_id": "f2f465d1d46f3f4436a7658f9817fa95",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "xbmc",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-11-11T08:23:19 | null | {"repository":{"description":"XBMC Main Repository","homepage":"http://xbmc.org","watchers":2754,"stargazers":2754,"forks":1635,"fork":false,"size":1310147,"owner":"xbmc","private":false,"open_issues":110,"has_issues":true,"has_downloads":true,"has_wiki":false,"language":"C","created_at":"2011-01-03T13:18:51-08:00","pushed_at":"2013-11-10T19:03:16-08:00","master_branch":"master","organization":"xbmc"},"actor_attributes":{"type":"User","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/xbmc/xbmc/pull/3552#discussion_r7553973"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/xbmc/xbmc/pulls/comments/6763316","id":6763316,"body":"Yes, but it also removes duplicate slashes (my version below might be a bit more obvious?)","diff_hunk":"@@ -517,6 +509,71 @@ bool CWIN32Util::RemoveExtraLongPathPrefix(std::wstring& path)\n return false;\n }\n \n+std::string CWIN32Util::SmartFixWin32PathSlashes(const std::string& path)\n+{\n+ size_t startReplaceFrom;\n+ if (path.compare(0, 4, \"\\\\\\\\?\\\\\", 4) == 0)\n+ startReplaceFrom = 4;\n+ else\n+ startReplaceFrom = 0;\n+\n+ return SimpleFixWin32PathSlashes(path, startReplaceFrom);\n+}\n+\n+std::string CWIN32Util::SimpleFixWin32PathSlashes(const std::string& path, size_t startPos /*= 0*/)","path":"xbmc/win32/WIN32Util.cpp","position":50,"original_position":50,"commit_id":"6a700b618de978888c6adfe17c1a1356bc4cf827","original_commit_id":"6a700b618de978888c6adfe17c1a1356bc4cf827","user":{"login":"jmarshallnz","id":406571,"avatar_url":"https://0.gravatar.com/avatar/f2f465d1d46f3f4436a7658f9817fa95?d=https%3A%2F%2Fidenticons.github.com%2F205e230239563b1219977f6b26fdf1e1.png","gravatar_id":"f2f465d1d46f3f4436a7658f9817fa95","url":"https://api.github.com/users/jmarshallnz","html_url":"https://github.com/jmarshallnz","followers_url":"https://api.github.com/users/jmarshallnz/followers","following_url":"https://api.github.com/users/jmarshallnz/following{/other_user}","gists_url":"https://api.github.com/users/jmarshallnz/gists{/gist_id}","starred_url":"https://api.github.com/users/jmarshallnz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmarshallnz/subscriptions","organizations_url":"https://api.github.com/users/jmarshallnz/orgs","repos_url":"https://api.github.com/users/jmarshallnz/repos","events_url":"https://api.github.com/users/jmarshallnz/events{/privacy}","received_events_url":"https://api.github.com/users/jmarshallnz/received_events","type":"User"},"created_at":"2013-10-04T09:07:11Z","updated_at":"2013-10-04T09:07:11Z","html_url":"https://github.com/xbmc/xbmc/pull/3374#discussion_r6763316","pull_request_url":"https://api.github.com/repos/xbmc/xbmc/pulls/3374","_links":{"self":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/comments/6763316"},"html":{"href":"https://github.com/xbmc/xbmc/pull/3374#discussion_r6763316"},"pull_request":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/3374"}}}} | {
"id": 1217614,
"name": "xbmc",
"url": "https://github.com/xbmc/xbmc"
} | {
"id": null,
"login": "jmarshallnz",
"gravatar_id": "f2f465d1d46f3f4436a7658f9817fa95",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "xbmc",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-10-04T09:07:11 | null | {"repository":{"description":"XBMC Main Repository","homepage":"http://xbmc.org","watchers":2677,"stargazers":2677,"forks":1551,"fork":false,"size":1293980,"owner":"xbmc","private":false,"open_issues":2,"has_issues":true,"has_downloads":true,"has_wiki":false,"language":"C","created_at":"2011-01-03T13:18:51-08:00","pushed_at":"2013-10-03T15:56:02-07:00","master_branch":"master","organization":"xbmc"},"actor_attributes":{"type":"User","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/xbmc/xbmc/pull/3374#discussion_r6763316"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/xbmc/xbmc/pulls/comments/6490967","id":6490967,"body":"never mind, I'm re-writing the code to sidestep around your issues.","diff_hunk":"@@ -13,121 +13,299 @@\n * GNU General Public License for more details.\n *\n * You should have received a copy of the GNU General Public License\n- * along with XBMC; see the file COPYING. If not, see\n- * <http://www.gnu.org/licenses/>.\n+ * along with XBMC; see the file COPYING. If not, write to\n+ * the Free Software Foundation, 675 Mass Ave, Cambridge, MA 02139, USA.\n+ * http://www.gnu.org/copyleft/gpl.html\n *\n */\n \n #include \"GUIDialogAccessPoints.h\"\n-#include \"guilib/GUIKeyboardFactory.h\"\n-#ifdef TARGET_POSIX\n-#include \"linux/NetworkLinux.h\"\n-#endif\n+#include \"dialogs/GUIDialogKeyboardGeneric.h\"\n #include \"Application.h\"\n+#include \"ApplicationMessenger.h\"\n #include \"FileItem.h\"\n #include \"guilib/Key.h\"\n #include \"guilib/LocalizeStrings.h\"\n+#include \"guilib/GUIWindowManager.h\"\n+#include \"utils/JobManager.h\"\n+#include \"ConnectionJob.h\"\n \n-#define CONTROL_ACCESS_POINTS 3\n+// defines for the controls\n+#define ACCESS_POINT_LABEL 1\n+#define ACCESS_POINT_LIST 3\n \n+//--------------------------------------------------------------\n+const std::string EncodeAccessPointParam(const std::string name, const CIPConfig &ipconfig)\n+{\n+ // encode CIPConfig structure into a string based ip connect param.\n+ std::string method(\"dhcp\");\n+ if (ipconfig.m_method == IP_CONFIG_STATIC)\n+ method = \"static\";\n+\n+ // '+' and '\\t' are invalid essid characters,\n+ // a ' ' is valid so watch out for those in the name.\n+ const std::string param(\"name+\" + name + \"\\t\" +\n+ \"method+\" + method + \"\\t\" +\n+ \"address+\" + ipconfig.m_address + \"\\t\" +\n+ \"netmask+\" + ipconfig.m_netmask + \"\\t\" +\n+ \"gateway+\" + ipconfig.m_gateway + \"\\t\" +\n+ \"nameserver+\" + ipconfig.m_nameserver + \"\\t\");\n+ return param;\n+}\n+\n+//--------------------------------------------------------------\n+//--------------------------------------------------------------\n CGUIDialogAccessPoints::CGUIDialogAccessPoints(void)\n : CGUIDialog(WINDOW_DIALOG_ACCESS_POINTS, \"DialogAccessPoints.xml\")\n {\n- m_accessPoints = new CFileItemList;\n+ m_connectionsFileList = new CFileItemList;\n }\n \n CGUIDialogAccessPoints::~CGUIDialogAccessPoints(void)\n {\n- delete m_accessPoints;\n+ delete m_connectionsFileList;\n }\n \n bool CGUIDialogAccessPoints::OnAction(const CAction &action)\n {\n if (action.GetID() == ACTION_SELECT_ITEM)\n {\n- CGUIMessage msg(GUI_MSG_ITEM_SELECTED, GetID(), CONTROL_ACCESS_POINTS);\n- OnMessage(msg);\n- int iItem = msg.GetParam1();\n+ // block users from doing another connection\n+ // while we are already trying to connect.\n+ if (!m_doing_connection)\n+ {\n+ // fetch the current selected item (access point)\n+ CGUIMessage msg(GUI_MSG_ITEM_SELECTED, GetID(), ACCESS_POINT_LIST);\n+ OnMessage(msg);\n+ int iItem = msg.GetParam1();\n+\n+ ConnectionList connections = g_application.getNetwork().GetConnections();\n+ CConnectionJob *connection = new CConnectionJob(connections[iItem],\n+ m_ipconfig, &g_application.getKeyringManager());\n+ CJobManager::GetInstance().AddJob(connection, this);\n+ m_doing_connection = true;\n+ }\n+ return true;\n+ }\n+ else if (action.GetID() == ACTION_CONNECTIONS_REFRESH)\n+ {\n+ // msg from Network Manager when the network connection changes.\n+ // this is for future support for scanning for new access points.\n+ UpdateConnectionList();\n+ return true;\n+ }\n \n- if (iItem == (int) m_aps.size())\n+ return CGUIDialog::OnAction(action);\n+}\n+\n+bool CGUIDialogAccessPoints::OnMessage(CGUIMessage& message)\n+{\n+ bool result = CGUIDialog::OnMessage(message);\n+ switch (message.GetMessage())\n+ {\n+ case GUI_MSG_WINDOW_INIT:\n {\n- m_selectedAPEssId = \"\";\n- if (CGUIKeyboardFactory::ShowAndGetInput(m_selectedAPEssId, g_localizeStrings.Get(789), false))\n- {\n- m_selectedAPEncMode = m_aps[iItem].getEncryptionMode();\n- m_wasItemSelected = true;\n- Close();\n- return true;\n- }\n+ m_use_ipconfig = false;\n+ m_doing_connection = false;\n+ // fetch the param list\n+ std::string param(message.GetStringParam());\n+\n+ // network apply vs network connect\n+ if (param.find(\"name+\") != std::string::npos)\n+ {\n+ m_use_ipconfig = true;\n+ // network apply, param contains a description for connecting\n+ // to an access point. we want to find this access point,\n+ // disable the others, then inject a OnAction msg to select it.\n+ DecodeAccessPointParam(param);\n+ // change the label to show we are doing a connection.\n+ CGUIMessage msg(GUI_MSG_LABEL_SET, GetID(), ACCESS_POINT_LABEL);\n+ // <string id=\"33203\">Connecting</string>\n+ msg.SetLabel(g_localizeStrings.Get(33203));\n+ OnMessage(msg);\n+ }\n+ UpdateConnectionList();","path":"xbmc/network/GUIDialogAccessPoints.cpp","position":146,"original_position":145,"commit_id":"3599eb3a642006ea5f9fa651b49720d16957976b","original_commit_id":"df2e6365be43b907f44d9f82b2f01bfc7ef91743","user":{"login":"davilla","id":419526,"avatar_url":"https://1.gravatar.com/avatar/2ab51ac6d7c1665da62a0a5c9ec340ae?d=https%3A%2F%2Fidenticons.github.com%2F2029876f12d1ab229360b9864af9ed10.png","gravatar_id":"2ab51ac6d7c1665da62a0a5c9ec340ae","url":"https://api.github.com/users/davilla","html_url":"https://github.com/davilla","followers_url":"https://api.github.com/users/davilla/followers","following_url":"https://api.github.com/users/davilla/following{/other_user}","gists_url":"https://api.github.com/users/davilla/gists{/gist_id}","starred_url":"https://api.github.com/users/davilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davilla/subscriptions","organizations_url":"https://api.github.com/users/davilla/orgs","repos_url":"https://api.github.com/users/davilla/repos","events_url":"https://api.github.com/users/davilla/events{/privacy}","received_events_url":"https://api.github.com/users/davilla/received_events","type":"User"},"created_at":"2013-09-20T16:32:13Z","updated_at":"2013-09-20T16:32:13Z","html_url":"https://github.com/xbmc/xbmc/pull/3288#discussion_r6490967","pull_request_url":"https://api.github.com/repos/xbmc/xbmc/pulls/3288","_links":{"self":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/comments/6490967"},"html":{"href":"https://github.com/xbmc/xbmc/pull/3288#discussion_r6490967"},"pull_request":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/3288"}}}} | {
"id": 1217614,
"name": "xbmc",
"url": "https://github.com/xbmc/xbmc"
} | {
"id": null,
"login": "davilla",
"gravatar_id": "2ab51ac6d7c1665da62a0a5c9ec340ae",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "xbmc",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-09-20T16:32:13 | null | {"repository":{"description":"XBMC Main Repository","homepage":"http://xbmc.org","watchers":2635,"stargazers":2635,"forks":1519,"fork":false,"size":1290960,"owner":"xbmc","private":false,"open_issues":1,"has_issues":true,"has_downloads":true,"has_wiki":false,"language":"C","created_at":"2011-01-03T13:18:51-08:00","pushed_at":"2013-09-20T02:23:13-07:00","master_branch":"master","organization":"xbmc"},"actor_attributes":{"type":"User","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/xbmc/xbmc/pull/3288#discussion_r6490967"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/xbmc/xbmc/pulls/comments/6787846","id":6787846,"diff_hunk":"@@ -229,20 +253,67 @@ RENDER_STEREO_MODE CStereoscopicsManager::GetPreferredPlaybackMode(void)\n return playbackMode;\n }\n \n-bool CStereoscopicsManager::OnMessage(CGUIMessage &message)\n+int CStereoscopicsManager::ConvertVideoToGuiStereoMode(const std::string &mode)\n {\n- switch (message.GetMessage())\n+ size_t i = 0;\n+ while (VideoModeToGuiModeMap[i].name)\n {\n- case GUI_MSG_PLAYBACK_STARTED:\n- OnPlaybackStarted();\n- break;\n- case GUI_MSG_PLAYBACK_STOPPED:\n- case GUI_MSG_PLAYLISTPLAYER_STOPPED:\n- OnPlaybackStopped();\n- break;\n+ if (mode == VideoModeToGuiModeMap[i].name)\n+ return VideoModeToGuiModeMap[i].mode;\n+ i++;\n }\n+ return -1;\n+}\n \n- return false;\n+int CStereoscopicsManager::ConvertStringToGuiStereoMode(const std::string &mode)\n+{\n+ size_t i = 0;\n+ while (StringToGuiModeMap[i].name)\n+ {\n+ if (mode == StringToGuiModeMap[i].name)\n+ return StringToGuiModeMap[i].mode;\n+ i++;\n+ }\n+ return ConvertVideoToGuiStereoMode(mode);\n+}\n+\n+const char* CStereoscopicsManager::ConvertGuiStereoModeToString(const RENDER_STEREO_MODE &mode)\n+{\n+ size_t i = 0;\n+ while (StringToGuiModeMap[i].name)\n+ {\n+ if (StringToGuiModeMap[i].mode == mode)\n+ return StringToGuiModeMap[i].name;\n+ i++;\n+ }\n+ return \"\";\n+}\n+\n+CAction CStereoscopicsManager::ConvertActionCommandToAction(const std::string &command, const std::string ¶meter)\n+{\n+ int actionId = -1;\n+ if (command == \"SetStereoMode\")\n+ {\n+ if (parameter == \"next\")\n+ actionId = ACTION_STEREOMODE_NEXT;\n+ else if (parameter == \"previous\")\n+ actionId = ACTION_STEREOMODE_PREVIOUS;\n+ else if (parameter == \"toggle\")\n+ actionId = ACTION_STEREOMODE_TOGGLE;\n+ else if (parameter == \"select\")\n+ actionId = ACTION_STEREOMODE_SELECT;\n+ else if (parameter == \"tomono\")\n+ actionId = ACTION_STEREOMODE_TOMONO;\n+\n+ // already have a valid actionID return it\n+ if (actionId > -1)\n+ return CAction(actionId);\n+\n+ // still no valid action ID, check if parameter is a supported stereomode\n+ if (ConvertStringToGuiStereoMode(parameter) > -1)\n+ return CAction(ACTION_STEREOMODE_SET, parameter);\n+ }\n+ return CAction(actionId);","path":"xbmc/guilib/StereoscopicsManager.cpp","position":171,"original_position":171,"commit_id":"cca02b5ff32ee251e538f3fe2ef22b1257bf7148","original_commit_id":"cca02b5ff32ee251e538f3fe2ef22b1257bf7148","user":{"login":"jmarshallnz","id":406571,"avatar_url":"https://2.gravatar.com/avatar/f2f465d1d46f3f4436a7658f9817fa95?d=https%3A%2F%2Fidenticons.github.com%2F205e230239563b1219977f6b26fdf1e1.png","gravatar_id":"f2f465d1d46f3f4436a7658f9817fa95","url":"https://api.github.com/users/jmarshallnz","html_url":"https://github.com/jmarshallnz","followers_url":"https://api.github.com/users/jmarshallnz/followers","following_url":"https://api.github.com/users/jmarshallnz/following{/other_user}","gists_url":"https://api.github.com/users/jmarshallnz/gists{/gist_id}","starred_url":"https://api.github.com/users/jmarshallnz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmarshallnz/subscriptions","organizations_url":"https://api.github.com/users/jmarshallnz/orgs","repos_url":"https://api.github.com/users/jmarshallnz/repos","events_url":"https://api.github.com/users/jmarshallnz/events{/privacy}","received_events_url":"https://api.github.com/users/jmarshallnz/received_events","type":"User"},"body":"This looks like a potential bug. I think you want return CAction(); ?","created_at":"2013-10-06T19:31:47Z","updated_at":"2013-10-06T19:31:47Z","html_url":"https://github.com/xbmc/xbmc/pull/3307#discussion_r6787846","pull_request_url":"https://api.github.com/repos/xbmc/xbmc/pulls/3307","_links":{"self":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/comments/6787846"},"html":{"href":"https://github.com/xbmc/xbmc/pull/3307#discussion_r6787846"},"pull_request":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/3307"}}}} | {
"id": 1217614,
"name": "xbmc",
"url": "https://github.com/xbmc/xbmc"
} | {
"id": null,
"login": "jmarshallnz",
"gravatar_id": "f2f465d1d46f3f4436a7658f9817fa95",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "xbmc",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-10-06T19:31:47 | null | {"repository":{"description":"XBMC Main Repository","homepage":"http://xbmc.org","watchers":2683,"stargazers":2683,"forks":1559,"fork":false,"size":1294974,"owner":"xbmc","private":false,"open_issues":6,"has_issues":true,"has_downloads":true,"has_wiki":false,"language":"C","created_at":"2011-01-03T13:18:51-08:00","pushed_at":"2013-10-06T11:39:23-07:00","master_branch":"master","organization":"xbmc"},"actor_attributes":{"type":"User","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/xbmc/xbmc/pull/3307#discussion_r6787846"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/xbmc/xbmc/pulls/comments/6786180","id":6786180,"diff_hunk":"@@ -255,3 +255,9 @@ void CKey::SetFromService(bool fromService)\n else if (key.GetButtonCode() == KEY_BUTTON_RIGHT_THUMB_STICK_RIGHT)\n m_amount[0] = key.GetRightThumbX();\n }\n+\n+CAction::CAction(int actionID, const std::string &name)\n+{\n+ m_id = actionID;\n+ m_name = name;\n+}","path":"xbmc/guilib/Key.cpp","position":9,"original_position":9,"commit_id":"8780672702da6a3baa4e273bca41c55d5ac5de73","original_commit_id":"8780672702da6a3baa4e273bca41c55d5ac5de73","user":{"login":"jmarshallnz","id":406571,"avatar_url":"https://0.gravatar.com/avatar/f2f465d1d46f3f4436a7658f9817fa95?d=https%3A%2F%2Fidenticons.github.com%2F205e230239563b1219977f6b26fdf1e1.png","gravatar_id":"f2f465d1d46f3f4436a7658f9817fa95","url":"https://api.github.com/users/jmarshallnz","html_url":"https://github.com/jmarshallnz","followers_url":"https://api.github.com/users/jmarshallnz/followers","following_url":"https://api.github.com/users/jmarshallnz/following{/other_user}","gists_url":"https://api.github.com/users/jmarshallnz/gists{/gist_id}","starred_url":"https://api.github.com/users/jmarshallnz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmarshallnz/subscriptions","organizations_url":"https://api.github.com/users/jmarshallnz/orgs","repos_url":"https://api.github.com/users/jmarshallnz/repos","events_url":"https://api.github.com/users/jmarshallnz/events{/privacy}","received_events_url":"https://api.github.com/users/jmarshallnz/received_events","type":"User"},"body":"No. You need to initialize whatever is normally done in the default constructor.","created_at":"2013-10-06T08:13:00Z","updated_at":"2013-10-06T08:13:00Z","html_url":"https://github.com/xbmc/xbmc/pull/3307#discussion_r6786180","pull_request_url":"https://api.github.com/repos/xbmc/xbmc/pulls/3307","_links":{"self":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/comments/6786180"},"html":{"href":"https://github.com/xbmc/xbmc/pull/3307#discussion_r6786180"},"pull_request":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/3307"}}}} | {
"id": 1217614,
"name": "xbmc",
"url": "https://github.com/xbmc/xbmc"
} | {
"id": null,
"login": "jmarshallnz",
"gravatar_id": "f2f465d1d46f3f4436a7658f9817fa95",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "xbmc",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-10-06T08:13:00 | null | {"repository":{"description":"XBMC Main Repository","homepage":"http://xbmc.org","watchers":2681,"stargazers":2681,"forks":1558,"fork":false,"size":1295385,"owner":"xbmc","private":false,"open_issues":6,"has_issues":true,"has_downloads":true,"has_wiki":false,"language":"C","created_at":"2011-01-03T13:18:51-08:00","pushed_at":"2013-10-05T12:19:41-07:00","master_branch":"master","organization":"xbmc"},"actor_attributes":{"type":"User","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/xbmc/xbmc/pull/3307#discussion_r6786180"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/yast/yast-network/pulls/comments/7183092","id":7183092,"diff_hunk":"@@ -346,12 +366,16 @@ def ManagedInit(key)\n # @param [String] key\tid of the widget\n # @param [Hash] event\tthe event being handled\n def ManagedStore(key, event)\n- event = deep_copy(event)\n- value_g = Convert.to_string(UI.QueryWidget(Id(key), :CurrentButton))\n- value = value_g == \"managed\"\n- if NetworkService.IsManaged != value\n- LanItems.SetModified\n- if value && Stage.normal\n+ new_backend = UI.QueryWidget(Id(key), :CurrentButton)\n+\n+ return if new_backend == NetworkService.current_name","path":"src/include/network/lan/complex.rb","position":61,"original_position":61,"commit_id":"555603fec488f598bfc2338f35e299e3f09f1494","original_commit_id":"555603fec488f598bfc2338f35e299e3f09f1494","user":{"login":"mvidner","id":102056,"avatar_url":"https://2.gravatar.com/avatar/cb3d39e1fb6fabb5f916885b6154623a?d=https%3A%2F%2Fidenticons.github.com%2F42c23523358d33619485db0a458fece0.png&r=x","gravatar_id":"cb3d39e1fb6fabb5f916885b6154623a","url":"https://api.github.com/users/mvidner","html_url":"https://github.com/mvidner","followers_url":"https://api.github.com/users/mvidner/followers","following_url":"https://api.github.com/users/mvidner/following{/other_user}","gists_url":"https://api.github.com/users/mvidner/gists{/gist_id}","starred_url":"https://api.github.com/users/mvidner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mvidner/subscriptions","organizations_url":"https://api.github.com/users/mvidner/orgs","repos_url":"https://api.github.com/users/mvidner/repos","events_url":"https://api.github.com/users/mvidner/events{/privacy}","received_events_url":"https://api.github.com/users/mvidner/received_events","type":"User","site_admin":false},"body":"Here `NetworkService.current_name` is used with the semantics `NetworkService.new_backend`. But that is NOT how it is defined and described in the other PR.","created_at":"2013-10-24T09:26:56Z","updated_at":"2013-10-24T09:26:56Z","html_url":"https://github.com/yast/yast-network/pull/119#discussion_r7183092","pull_request_url":"https://api.github.com/repos/yast/yast-network/pulls/119","_links":{"self":{"href":"https://api.github.com/repos/yast/yast-network/pulls/comments/7183092"},"html":{"href":"https://github.com/yast/yast-network/pull/119#discussion_r7183092"},"pull_request":{"href":"https://api.github.com/repos/yast/yast-network/pulls/119"}}}} | {
"id": 4368160,
"name": "yast-network",
"url": "https://github.com/yast/yast-network"
} | {
"id": null,
"login": "mvidner",
"gravatar_id": "cb3d39e1fb6fabb5f916885b6154623a",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "yast",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-10-24T09:26:56 | null | {"repository":{"description":"YaST module network","homepage":"http://en.opensuse.org/Portal:YaST","watchers":4,"stargazers":4,"forks":8,"fork":false,"size":24881,"owner":"yast","private":false,"open_issues":1,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Ruby","created_at":"2012-05-18T03:24:50-07:00","pushed_at":"2013-10-24T02:03:13-07:00","master_branch":"master","organization":"yast"},"actor_attributes":{"type":"User","name":"Martin Vidner","company":"SUSE","location":"Prague, CZ, EU","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/yast/yast-network/pull/119#discussion_r7183092"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/Bacon/BaconUser/pulls/comments/4028684","id":4028684,"body":"The various service names should probably follow the suggested naming scheme as explained in http://framework.zend.com/manual/2.1/en/modules/zend.service-manager.quick-start.html","diff_hunk":"@@ -0,0 +1,54 @@\n+<?php\n+/**\n+ * BaconUser\n+ *\n+ * @link http://github.com/Bacon/BaconUser For the canonical source repository\n+ * @copyright 2013 Ben Scholzen 'DASPRiD'\n+ * @license http://opensource.org/licenses/BSD-2-Clause Simplified BSD License\n+ */\n+\n+namespace BaconUser\\Factory;\n+\n+use BaconUser\\Password\\HandlerAggregate;\n+use Zend\\ServiceManager\\FactoryInterface;\n+use Zend\\ServiceManager\\ServiceLocatorInterface;\n+\n+class HandlerAggregateFactory implements FactoryInterface\n+{\n+ /**\n+ * createService(): defined by FactoryInterface.\n+ *\n+ * @see FactoryInterface::createService()\n+ * @param ServiceLocatorInterface $serviceLocator\n+ * @return HandlerAggregate\n+ */\n+ public function createService(ServiceLocatorInterface $serviceLocator)\n+ {\n+ $aggregate = new HandlerAggregate();\n+ $aggregate->setHandlerManager($serviceLocator->get('baconuser_password_handlermanager'));","path":"src/BaconUser/Factory/HandlerAggregateFactory.php","position":28,"original_position":28,"commit_id":"9d13bd22c7b1ae003fce74475a5648dd2ef90264","original_commit_id":"9d13bd22c7b1ae003fce74475a5648dd2ef90264","user":{"login":"Ocramius","id":154256,"avatar_url":"https://secure.gravatar.com/avatar/3cf7a8ab0bccee5b65d39b50a170a555?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"3cf7a8ab0bccee5b65d39b50a170a555","url":"https://api.github.com/users/Ocramius","html_url":"https://github.com/Ocramius","followers_url":"https://api.github.com/users/Ocramius/followers","following_url":"https://api.github.com/users/Ocramius/following","gists_url":"https://api.github.com/users/Ocramius/gists{/gist_id}","starred_url":"https://api.github.com/users/Ocramius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ocramius/subscriptions","organizations_url":"https://api.github.com/users/Ocramius/orgs","repos_url":"https://api.github.com/users/Ocramius/repos","events_url":"https://api.github.com/users/Ocramius/events{/privacy}","received_events_url":"https://api.github.com/users/Ocramius/received_events","type":"User"},"created_at":"2013-04-30T21:43:47Z","updated_at":"2013-04-30T21:43:47Z","html_url":"https://github.com/Bacon/BaconUser/pull/1#discussion_r4028684","pull_request_url":"https://api.github.com/repos/Bacon/BaconUser/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/Bacon/BaconUser/pulls/comments/4028684"},"html":{"href":"https://github.com/Bacon/BaconUser/pull/1#discussion_r4028684"},"pull_request":{"href":"https://api.github.com/repos/Bacon/BaconUser/pulls/1"}}}} | {
"id": 9759787,
"name": "BaconUser",
"url": "https://github.com/Bacon/BaconUser"
} | {
"id": null,
"login": "Ocramius",
"gravatar_id": "3cf7a8ab0bccee5b65d39b50a170a555",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "Bacon",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-04-30T21:43:47 | null | {"repository":{"description":"BaconUser provides simple user management","watchers":0,"stargazers":0,"forks":0,"fork":false,"size":176,"owner":"Bacon","private":false,"open_issues":1,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"PHP","created_at":"2013-04-29T15:49:12-07:00","pushed_at":"2013-04-30T10:27:43-07:00","master_branch":"master","organization":"Bacon"},"actor_attributes":{"type":"User","name":"Marco Pivetta","company":"Com2-Gmbh","blog":"http://ocramius.github.com/","location":"Germany","email":"[email protected]"},"url":"https://github.com/Bacon/BaconUser/pull/1#discussion_r4028684"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/Bacon/BaconUser/pulls/comments/6321308","id":6321308,"body":"I think it may be a problem for most hydrators that inflect the setter/getter based on the key. For instance DoctrineModule hydrator's assume that setter is \"set\" . ucfirst($key). So if we keep this underscore_separated people should define setFirst_Name method. I just went with the situation that will fit most situations without having to override each hydrator.","diff_hunk":"@@ -9,35 +9,33 @@\n \n namespace BaconUser\\Hydrator;\n \n+use Zend\\Stdlib\\Exception;\n use Zend\\Stdlib\\Hydrator\\ClassMethods;\n use Zend\\Stdlib\\Hydrator\\Strategy\\StrategyInterface;\n \n /**\n * Hydrator for the {@see RegistrationForm}.\n */\n-class RegistrationHydrator extends ClassMethods\n+class UserHydrator extends ClassMethods\n {\n /**\n * @param StrategyInterface $passwordHashingStrategy\n */\n public function __construct(StrategyInterface $passwordHashingStrategy)\n {\n- parent::__construct(true);\n- $this->addStrategy('password_hash', $passwordHashingStrategy);\n+ parent::__construct(false);\n+ $this->addStrategy('passwordHash', $passwordHashingStrategy);\n }\n \n /**\n- * hydrate(): defined by ClassMethods.\n- *\n- * @see ClassMethods::hydrate()\n- * @param array $data\n+ * @param array $data\n * @param object $object\n * @return object\n */\n public function hydrate(array $data, $object)\n {\n if (isset($data['password'])) {\n- $data['password_hash'] = $data['password'];\n+ $data['passwordHash'] = $data['password'];","path":"src/BaconUser/Hydrator/UserHydrator.php","position":38,"original_position":38,"commit_id":"1e9831f7926df07dba0f7f796cccb814578839c2","original_commit_id":"7a89a09d241e9508cb8e18a0f4e22959bffef4fb","user":{"login":"bakura10","id":1198915,"avatar_url":"https://2.gravatar.com/avatar/2c3202718f850e5822f31a72b904668e?d=https%3A%2F%2Fidenticons.github.com%2Fb0e559f9c86970d9f05bda45c329845f.png","gravatar_id":"2c3202718f850e5822f31a72b904668e","url":"https://api.github.com/users/bakura10","html_url":"https://github.com/bakura10","followers_url":"https://api.github.com/users/bakura10/followers","following_url":"https://api.github.com/users/bakura10/following{/other_user}","gists_url":"https://api.github.com/users/bakura10/gists{/gist_id}","starred_url":"https://api.github.com/users/bakura10/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bakura10/subscriptions","organizations_url":"https://api.github.com/users/bakura10/orgs","repos_url":"https://api.github.com/users/bakura10/repos","events_url":"https://api.github.com/users/bakura10/events{/privacy}","received_events_url":"https://api.github.com/users/bakura10/received_events","type":"User"},"created_at":"2013-09-12T13:26:23Z","updated_at":"2013-09-12T13:26:23Z","html_url":"https://github.com/Bacon/BaconUser/pull/20#discussion_r6321308","pull_request_url":"https://api.github.com/repos/Bacon/BaconUser/pulls/20","_links":{"self":{"href":"https://api.github.com/repos/Bacon/BaconUser/pulls/comments/6321308"},"html":{"href":"https://github.com/Bacon/BaconUser/pull/20#discussion_r6321308"},"pull_request":{"href":"https://api.github.com/repos/Bacon/BaconUser/pulls/20"}}}} | {
"id": 9759787,
"name": "BaconUser",
"url": "https://github.com/Bacon/BaconUser"
} | {
"id": null,
"login": "bakura10",
"gravatar_id": "2c3202718f850e5822f31a72b904668e",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "Bacon",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-09-12T13:26:23 | null | {"repository":{"description":"BaconUser provides simple user management","watchers":16,"stargazers":16,"forks":6,"fork":false,"size":533,"owner":"Bacon","private":false,"open_issues":12,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"PHP","created_at":"2013-04-29T15:49:12-07:00","pushed_at":"2013-08-29T17:44:08-07:00","master_branch":"master","organization":"Bacon"},"actor_attributes":{"type":"User","name":"Michaël Gallego","blog":"http://www.michaelgallego.fr","location":"Paris, France","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/Bacon/BaconUser/pull/20#discussion_r6321308"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/Jasig/cas/pulls/comments/4127294","id":4127294,"body":"I am going to merge this one in, and will open up a new thread on CS rules and line limits. Need to experiment with 140 a little bit throughout the build. ","diff_hunk":"@@ -140,7 +142,8 @@ public boolean delete(final RegisteredService registeredService) {\n \r\n @Override\r\n public RegisteredService findServiceById(final long id) {\r\n- return (RegisteredService) this.ldapTemplate.lookup(findDn(this.ldapServiceMapper.getSearchFilter(id).encode()), this.ldapServiceMapper);\r\n+ return (RegisteredService) this.ldapTemplate.lookup(findDn(this.ldapServiceMapper.getSearchFilter(id).encode()),\r","path":"cas-server-support-ldap/src/main/java/org/jasig/cas/adaptors/ldap/services/LdapServiceRegistryDao.java","position":43,"original_position":43,"commit_id":"8559ebb482471b0fe5524bfd026daad9669d8ce6","original_commit_id":"c35345277752704634c93a8ec45edd2367046587","user":{"login":"mmoayyed","id":1205228,"avatar_url":"https://secure.gravatar.com/avatar/c9007ddcff7509416844cd4849d64009?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"c9007ddcff7509416844cd4849d64009","url":"https://api.github.com/users/mmoayyed","html_url":"https://github.com/mmoayyed","followers_url":"https://api.github.com/users/mmoayyed/followers","following_url":"https://api.github.com/users/mmoayyed/following{/other_user}","gists_url":"https://api.github.com/users/mmoayyed/gists{/gist_id}","starred_url":"https://api.github.com/users/mmoayyed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmoayyed/subscriptions","organizations_url":"https://api.github.com/users/mmoayyed/orgs","repos_url":"https://api.github.com/users/mmoayyed/repos","events_url":"https://api.github.com/users/mmoayyed/events{/privacy}","received_events_url":"https://api.github.com/users/mmoayyed/received_events","type":"User"},"created_at":"2013-05-08T02:20:59Z","updated_at":"2013-05-08T02:20:59Z","html_url":"https://github.com/Jasig/cas/pull/243#discussion_r4127294","pull_request_url":"https://api.github.com/repos/Jasig/cas/pulls/243","_links":{"self":{"href":"https://api.github.com/repos/Jasig/cas/pulls/comments/4127294"},"html":{"href":"https://github.com/Jasig/cas/pull/243#discussion_r4127294"},"pull_request":{"href":"https://api.github.com/repos/Jasig/cas/pulls/243"}}}} | {
"id": 2352744,
"name": "cas",
"url": "https://github.com/Jasig/cas"
} | {
"id": null,
"login": "mmoayyed",
"gravatar_id": "c9007ddcff7509416844cd4849d64009",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "Jasig",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-05-08T02:20:59 | null | {"repository":{"description":"Jasig CAS - Single Sign On for the Web","homepage":"http://www.jasig.org/cas","watchers":191,"stargazers":191,"forks":125,"fork":false,"size":8036,"owner":"Jasig","private":false,"open_issues":12,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Java","created_at":"2011-09-08T18:36:42-07:00","pushed_at":"2013-05-07T19:19:24-07:00","master_branch":"master","organization":"Jasig"},"actor_attributes":{"type":"User","name":"Misagh Moayyed","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/Jasig/cas/pull/243#discussion_r4127294"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/TBEDP/datavjs/pulls/comments/6287617","id":6287617,"body":"为增强自定义,他们需要的baseline可能不称之为\"全网基数\",所以可以自定义图片. 在shu上面找了没找到什么合适的图片,于是放了微博的那个. 不太美观的话,一会儿ps一个替换掉","diff_hunk":"@@ -0,0 +1,54 @@\n+<!doctype html>\n+<html lang=\"en\">\n+<head>\n+ <meta charset=\"UTF-8\">\n+ <meta http-equiv=\"X-UA-Compatible\" content=\"IE=edge,chrome=1\" />\n+ <title>Document</title>\n+ <script src=\"../../build/deps.js\"></script>\n+ <script src=\"../../lib/datav.js\"></script> \n+ <script src=\"../../lib/charts/level.js\"></script> \n+ <style>\n+ .level {\n+ padding: 10px;\n+ margin: 10px;\n+ height: 235px;\n+ width: 300px;\n+ overflow: hidden;\n+ float: left;\n+ }\n+ </style>\n+</head>\n+<body>\n+ <div class=\"level\"></div>\n+ <div class=\"level\"></div>\n+ <div class=\"level\"></div>\n+ <div class=\"level\"></div>\n+ <div class=\"level\"></div>\n+ <script>\n+ /**\n+ * Examples about how to use LevelChart\n+ * var tester = new LevelChart(DomNode); //init levelchart\n+ * tester.render([ Array data ],{ Object globalBase: [Array globalBascialData], labels : [Array labelTypes], tipImg : \"String image url for giving a tip\" }, nobase : Boolean true/false );\n+ */\n+\n+ //To draw charts in different data env\n+ var tester = new LevelChart($('.level:eq(0)'));\n+ tester.render([ 10, 20, 30, 49, 50 ]);\n+\n+ var tester = new LevelChart($('.level:eq(1)'));\n+ tester.render([ 10, 35, 88, 49, 10 ], { globalBase : [ 10, 20, 50, 30, 15], labels : [ 'a', 'b', 'c', 'd', 'e' ] });\n+\n+ var tester = new LevelChart($('.level:eq(2)'));\n+ tester.render([ 0, 0, 0, 0, 0 ], { globalBase : [ 10, 20, 50, 30, 15], labels : [ 'a', 'b', 'c', 'd', 'e' ] });\n+\n+ //When there is no baseline, the hover effects won't be shown.\n+ var tester = new LevelChart($('.level:eq(3)'));\n+ tester.render([ 10, 35, 88, 49, 10 ], { nobase : true });\n+\n+ //You could use your own images for marking the baseline on the top-right of the chart now!\n+ var tester = new LevelChart($('.level:eq(4)'));\n+ tester.render([ 10, 35, 88, 49, 10 ], { globalBase : [ 0, 0, 5, 0, 0], tipImg : 'http://img03.taobaocdn.com/tps/i3/T1iTjQXXXbXXc_eAHa-19-18.png' });","path":"example/level/level_shu.html","position":50,"original_position":50,"commit_id":"390a2673283b2c3a7e999eebcab437461f5b824b","original_commit_id":"390a2673283b2c3a7e999eebcab437461f5b824b","user":{"login":"hlqf","id":3321729,"avatar_url":"https://2.gravatar.com/avatar/1cd69b5ba1ef0530281704961495a826?d=https%3A%2F%2Fidenticons.github.com%2F2f753de6ca05b8f31dd2ee9af8424517.png","gravatar_id":"1cd69b5ba1ef0530281704961495a826","url":"https://api.github.com/users/hlqf","html_url":"https://github.com/hlqf","followers_url":"https://api.github.com/users/hlqf/followers","following_url":"https://api.github.com/users/hlqf/following{/other_user}","gists_url":"https://api.github.com/users/hlqf/gists{/gist_id}","starred_url":"https://api.github.com/users/hlqf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hlqf/subscriptions","organizations_url":"https://api.github.com/users/hlqf/orgs","repos_url":"https://api.github.com/users/hlqf/repos","events_url":"https://api.github.com/users/hlqf/events{/privacy}","received_events_url":"https://api.github.com/users/hlqf/received_events","type":"User"},"created_at":"2013-09-11T07:40:43Z","updated_at":"2013-09-11T07:40:43Z","html_url":"https://github.com/TBEDP/datavjs/pull/137#discussion_r6287617","pull_request_url":"https://api.github.com/repos/TBEDP/datavjs/pulls/137","_links":{"self":{"href":"https://api.github.com/repos/TBEDP/datavjs/pulls/comments/6287617"},"html":{"href":"https://github.com/TBEDP/datavjs/pull/137#discussion_r6287617"},"pull_request":{"href":"https://api.github.com/repos/TBEDP/datavjs/pulls/137"}}}} | {
"id": 5519340,
"name": "datavjs",
"url": "https://github.com/TBEDP/datavjs"
} | {
"id": null,
"login": "hlqf",
"gravatar_id": "1cd69b5ba1ef0530281704961495a826",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "TBEDP",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-09-11T07:40:43 | null | {"repository":{"description":"DataV","homepage":"http://datavlab.org/datavjs/","watchers":340,"stargazers":340,"forks":196,"fork":false,"size":6027,"owner":"TBEDP","private":false,"open_issues":15,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"JavaScript","created_at":"2012-08-22T22:22:22-07:00","pushed_at":"2013-08-27T02:50:59-07:00","master_branch":"master","organization":"TBEDP"},"actor_attributes":{"type":"User","name":"hlqf","company":"Alibaba","blog":"www.hlqf.net","location":"Hangzhou,China","email":"[email protected]"},"url":"https://github.com/TBEDP/datavjs/pull/137#discussion_r6287617"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/Wikia/selenium-tests/pulls/comments/7923277","id":7923277,"diff_hunk":"@@ -27,4 +28,16 @@ public void Sections_002_hideTest() {\n \t\tarticle.verifySectionInvisibility();\n \t}\n \n+\n+\n+\t//@Test(groups={\"sectionTest_002\", \"sectionsTests\", \"mobile\"})\n+\tpublic void Sections_003_editSection() {\n+\t\tMobileArticlePageObject article = new MobileArticlePageObject(driver);\n+\t\tarticle.openSections(wikiURL);\n+\t\tarticle.clickSection(1);\n+\t\tString sectionText = article.getSectionText(0);\n+\t\tMobileEditModePageObject mobileEdit = article.editSection(0);\n+\t\tmobileEdit.verifyEditModeContent(sectionText);\n+\t}\n+","path":"src/test/java/com/wikia/webdriver/TestCases/Mobile/SectionsTests.java","position":26,"original_position":26,"commit_id":"b6ca5335df68c8eb8157e52684975d043c5527a9","original_commit_id":"b6ca5335df68c8eb8157e52684975d043c5527a9","user":{"login":"PiotrGackowski","id":2331033,"avatar_url":"https://2.gravatar.com/avatar/d8c493579b3f2ac83492b5fbeec49ead?d=https%3A%2F%2Fidenticons.github.com%2F28425a9734606493687287c3e98c73eb.png&r=x","gravatar_id":"d8c493579b3f2ac83492b5fbeec49ead","url":"https://api.github.com/users/PiotrGackowski","html_url":"https://github.com/PiotrGackowski","followers_url":"https://api.github.com/users/PiotrGackowski/followers","following_url":"https://api.github.com/users/PiotrGackowski/following{/other_user}","gists_url":"https://api.github.com/users/PiotrGackowski/gists{/gist_id}","starred_url":"https://api.github.com/users/PiotrGackowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PiotrGackowski/subscriptions","organizations_url":"https://api.github.com/users/PiotrGackowski/orgs","repos_url":"https://api.github.com/users/PiotrGackowski/repos","events_url":"https://api.github.com/users/PiotrGackowski/events{/privacy}","received_events_url":"https://api.github.com/users/PiotrGackowski/received_events","type":"User","site_admin":false},"body":"deleted\r\n","created_at":"2013-11-26T12:59:35Z","updated_at":"2013-11-26T12:59:35Z","html_url":"https://github.com/Wikia/selenium-tests/pull/105#discussion_r7923277","pull_request_url":"https://api.github.com/repos/Wikia/selenium-tests/pulls/105","_links":{"self":{"href":"https://api.github.com/repos/Wikia/selenium-tests/pulls/comments/7923277"},"html":{"href":"https://github.com/Wikia/selenium-tests/pull/105#discussion_r7923277"},"pull_request":{"href":"https://api.github.com/repos/Wikia/selenium-tests/pulls/105"}}}} | {
"id": 6275065,
"name": "selenium-tests",
"url": "https://github.com/Wikia/selenium-tests"
} | {
"id": null,
"login": "PiotrGackowski",
"gravatar_id": "d8c493579b3f2ac83492b5fbeec49ead",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "Wikia",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-11-26T12:59:35 | null | {"repository":{"description":"","watchers":0,"stargazers":0,"forks":3,"fork":false,"size":51787,"owner":"Wikia","private":false,"open_issues":10,"has_issues":false,"has_downloads":true,"has_wiki":true,"language":"Java","created_at":"2012-10-18T01:06:11-07:00","pushed_at":"2013-11-26T03:27:00-08:00","master_branch":"master","organization":"Wikia"},"actor_attributes":{"type":"User","name":"Piotr Gackowski","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/Wikia/selenium-tests/pull/105#discussion_r7923277"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/Wikia/selenium-tests/pulls/comments/5680205","id":5680205,"body":"there is no need to wait here?","diff_hunk":"@@ -65,4 +72,45 @@ public void verifyHideAll() {\n \t\twaitForElementByElement(hideAllButton);\n \t}\n \n+\tpublic void verifyCategoryExhibition() {\n+\t\tAssertion.assertTrue(categoryExhibition.size() == 4);","path":"src/test/java/com/wikia/webdriver/PageObjectsFactory/PageObject/Mobile/MobileCategoryPageObject.java","position":88,"original_position":88,"commit_id":"43c6d90c10aa78b1f7f039007c25001d5ef8497f","original_commit_id":"43c6d90c10aa78b1f7f039007c25001d5ef8497f","user":{"login":"kkarolk","id":2323048,"avatar_url":"https://secure.gravatar.com/avatar/8b0b24363117d88bec906f5971514d6d?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"8b0b24363117d88bec906f5971514d6d","url":"https://api.github.com/users/kkarolk","html_url":"https://github.com/kkarolk","followers_url":"https://api.github.com/users/kkarolk/followers","following_url":"https://api.github.com/users/kkarolk/following{/other_user}","gists_url":"https://api.github.com/users/kkarolk/gists{/gist_id}","starred_url":"https://api.github.com/users/kkarolk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kkarolk/subscriptions","organizations_url":"https://api.github.com/users/kkarolk/orgs","repos_url":"https://api.github.com/users/kkarolk/repos","events_url":"https://api.github.com/users/kkarolk/events{/privacy}","received_events_url":"https://api.github.com/users/kkarolk/received_events","type":"User"},"created_at":"2013-08-09T10:40:04Z","updated_at":"2013-08-09T10:40:04Z","html_url":"https://github.com/Wikia/selenium-tests/pull/47#discussion_r5680205","pull_request_url":"https://api.github.com/repos/Wikia/selenium-tests/pulls/47","_links":{"self":{"href":"https://api.github.com/repos/Wikia/selenium-tests/pulls/comments/5680205"},"html":{"href":"https://github.com/Wikia/selenium-tests/pull/47#discussion_r5680205"},"pull_request":{"href":"https://api.github.com/repos/Wikia/selenium-tests/pulls/47"}}}} | {
"id": 6275065,
"name": "selenium-tests",
"url": "https://github.com/Wikia/selenium-tests"
} | {
"id": null,
"login": "kkarolk",
"gravatar_id": "8b0b24363117d88bec906f5971514d6d",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "Wikia",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-08-09T10:40:04 | null | {"repository":{"description":"","watchers":0,"stargazers":0,"forks":3,"fork":false,"size":44441,"owner":"Wikia","private":false,"open_issues":9,"has_issues":false,"has_downloads":true,"has_wiki":true,"language":"Java","created_at":"2012-10-18T01:06:11-07:00","pushed_at":"2013-08-09T03:36:49-07:00","master_branch":"master","organization":"Wikia"},"actor_attributes":{"type":"User","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/Wikia/selenium-tests/pull/47#discussion_r5680205"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/Wikia/app/pulls/comments/7020534","id":7020534,"diff_hunk":"@@ -0,0 +1,512 @@\n+/*global define */\n+/**\n+ * listing & transmitting tags between modules handler\n+ *\n+ * @author Bartłomiej Kowalczyk\n+ */\n+\n+define( 'config', ['menu', 'editor', 'wikia.mustache', 'wikia.loader', 'toast'], function(menu, editor, mustache, loader, toast){\n+\n+ 'use strict';\n+\n+ var wrapper = document.getElementsByClassName( 'tagListWrapper' )[0],\n+\n+ //list of tags currently in the menu\n+ active = [],\n+\n+ //list of all tags\n+ taglist = {\n+\n+ tags: [\n+\n+ {\n+ name: \"Text Modifiers\",\n+ tags: [\n+ {\n+ name: \"Bold\",\n+ short: \"b\",\n+ tag: \"''_$''\"\n+ },\n+\n+ {\n+ name: \"Italic\",\n+ short: \"i\",\n+ tag: \"'''_$'''\"\n+ },\n+\n+ {\n+ name: \"Small\",\n+ short: \"sm\",\n+ tag: \"<small>_$</small>\"\n+ },\n+\n+ {\n+ name: \"Superscript\",\n+ short: \"sup\",\n+ tag: \"<sup>_$</sup>\"\n+ },\n+\n+ {\n+ name: \"Subscript\",\n+ short: \"sub\",\n+ tag: \"<sub>_$</sub>\"\n+ },\n+\n+ {\n+ name: \"S\",\n+ short: \"s\",\n+ tag: \"<s>_$</s>\"\n+ },\n+\n+ {\n+ name: \"Level 2 Headline\",\n+ short: \"h2\",\n+ tag: \"==_$==\"\n+ },\n+\n+ {\n+ name: \"Bulleted List\",\n+ short: \"ul\",\n+ tag: \"#\",\n+ extensions: function( limit ){\n+\n+ limit = Number( limit );\n+\n+ var result = '';\n+ if( limit && typeof limit === 'number'){\n+\n+ for (var i = 0; i < limit - 1; i++){\n+\n+ result +='\\n#';\n+ }\n+ }\n+ return result;\n+ }\n+ },\n+\n+ {\n+ name: \"Blockquote\",\n+ short: \"bq\",\n+ tag: \"<blockquote>_$</blockquote>\"\n+ }\n+ ]\n+ },\n+\n+ {\n+ name: \"Wiki Markup\",\n+ tags: [\n+\n+ {\n+ name: \"Link (external)\",\n+ short: \"ex\",\n+ tag: \"[http://_$]\",\n+ extensions: function( url, title ){\n+\n+ var result = '';\n+ if( url ) result += url.replace( 'http://', '' );\n+ if( title ) result += ' ' + title;\n+ return result;\n+ }\n+ },\n+\n+ {\n+ name: \"Link (internal)\",\n+ short: \"in\",\n+ tag: \"[[_$]]\"\n+ },\n+\n+ {\n+ name: \"File\",\n+ short: \"f\",\n+ tag: \"[[File:_$]]\",\n+ extensions: function( path ){\n+\n+ var result = '';\n+\n+ if( path ) {\n+ path += '';\n+ result += path.replace( 'http://', '' );\n+ }\n+ return result;\n+ }\n+ },\n+\n+ {\n+ name: \"Media\",\n+ short: \"m\",\n+ tag: \"[[Media:_$]]\"\n+ },\n+\n+ {\n+ name: \"Category\",\n+ short: \"c\",\n+ tag: \"[[Category:_$]]\"\n+ },\n+\n+ {\n+ name: \"Redirection\",\n+ short: \"r\",\n+ tag: \"#Redirect[[_$]]\"\n+ },\n+\n+ {\n+ name: \"Math Formula\",\n+ short: \"mth\",\n+ tag: \"<math>_$</math>\"\n+ },\n+\n+ {\n+ name: \"Code\",\n+ short: \"cod\",\n+ tag: \"<code>_$</code>\"\n+ },\n+\n+ {\n+ name: \"Ignore Wiki\",\n+ short: \"no\",\n+ tag: \"<nowiki>_$</nowiki>\"\n+ },\n+\n+ {\n+ name: \"Username + time\",\n+ short: \"u\",\n+ tag: \"~~~~\"\n+ },\n+\n+ {\n+ name: \"Horizontal Line\",\n+ short: \"l\",\n+ tag: \"--_$--\"\n+ },\n+\n+ {\n+ name: \"Strike\",\n+ short: \"str\",\n+ tag: \"<strike>_$</strike>\"\n+ },\n+\n+ {\n+ name: \"Hidden comment\",\n+ short: \"h\",\n+ tag: \"<!-- _$ -->\"\n+ },\n+\n+ {\n+ name: \"Reference\",\n+ short: \"ref\",\n+ tag: \"<ref>_$</ref>\"\n+ },\n+\n+ {\n+ name: \"Include Only\",\n+ short: \"inc\",\n+ tag: \"<includeonly></includeonly>\"\n+ },\n+\n+ {\n+ name: \"No Include\",\n+ short: \"ninc\",\n+ tag: \"<noinclude>_$</noinclude>\"\n+ }\n+ ]\n+ },\n+\n+ {\n+ name: \"Features and Media\",\n+ tags: [\n+\n+ {\n+ name: \"Gallery\",\n+ short: \"gal\",\n+ tag: \"<gallery>_$</gallery>\"\n+ }\n+ ]\n+ }\n+\n+ ]\n+ };\n+\n+ //toast message handler\n+ function alarm( type, data ){\n+\n+ switch(type){\n+\n+ case 'tag-add-success' :\n+ toast.show( 'You just added \"' + ( ( data.short ) ? data.short + '\" ' : '' ) + 'tag to the menu.'\n+ + '\\n' + 'Menu fulfillment: ' + active.length + ' / ' + menu.limit ); break;\n+\n+ case 'tag-add-error' :\n+ toast.show( 'Error adding \"' + ( ( data.short ) ? data.short + '\" ' : '' ) + 'tag to the menu.'\n+ + '\\n' + 'Menu fulfillment: ' + active.length + ' / ' + menu.limit ); break;\n+\n+ case 'tag-remove' :\n+ toast.show( 'You just removed \"' + ( ( data.short ) ? data.short + '\" ' : '' ) + 'tag from the menu.'\n+ + '\\n' + 'Menu fulfillment: ' + active.length + ' / ' + menu.limit ); break;\n+\n+ case 'no-tag' :\n+ toast.show( 'Tag \"' + ( ( data.short ) ? data.short + '\" ' : '' ) + ' is not in the menu.' ); break;\n+\n+ case 'start-message' :\n+ toast.show( 'You are currently editing article <b>' + wgTitle + '</b>. ' +\n+ 'Use checkboxes in tag lists below to add items to the animated menu. You can ' +\n+ 'also define custom tags.' ); break;\n+\n+ default: break;\n+ }\n+ }\n+\n+ //adds tag to the animated menu\n+ function addToMenu( tag ){\n+\n+ if( active.length < menu.limit ){\n+\n+ for( var i = 0; i < active.length; i++ ){\n+\n+ if( active[i].short === tag.short ) return false;\n+ }\n+ active.push( tag );\n+ menu.update( active );\n+ return true;\n+ }\n+ return false;\n+ }\n+\n+ //removes tag from the animated menu\n+ function remove( tagShort ){\n+\n+ for( var i = 0; i < active.length; i++ ){\n+\n+ if( active[i].short === tagShort ){\n+\n+ active.splice(i, 1);\n+ menu.update( active );\n+ return true;\n+ }\n+ }\n+ return false;\n+ }\n+\n+ //marks a group of chosen tags in the taglist\n+ function markTags( tagArr ){\n+\n+ for( var i = 0; i < tagArr.length; i++ ){\n+\n+ mark( findItem( tagArr[i] ) );\n+ }\n+ }\n+\n+ //finds a list item containing given tag\n+ function findItem( tag ){\n+\n+ var el = document.getElementById(tag.short).parentElement;\n+ return( el.tagName === 'LI' ) ? el : false;\n+ }\n+\n+ //marks a list item\n+ function mark( item ){\n+\n+ if( item && !item.classList.contains( 'marked' ) ){\n+\n+ var chb = item.getElementsByTagName( 'input' )[0];\n+\n+ chb.checked = true;\n+\n+ item.classList.add( 'marked' );\n+ }\n+ }\n+\n+ //clears previously given mark\n+ function clear( item ){\n+\n+ if( item && item.classList.contains( 'marked' ) ){\n+\n+ var chb = item.getElementsByTagName( 'input' )[0];\n+\n+ chb.checked = false;\n+\n+ item.classList.remove( 'marked' );\n+ }\n+ }\n+\n+ //handles checkbox changes\n+\n+ function onCheck ( chb ){\n+\n+ if( chb.checked ){\n+\n+ if( !addToMenu( findTag( chb.id ) ) ){\n+\n+ alarm( \"tag-add-error\", {short: chb.id});\n+ chb.checked = false;\n+ }else{\n+\n+ alarm( \"tag-add-success\", {short: chb.id});\n+ mark( chb.parentElement );\n+ }\n+\n+ }else{\n+\n+ if( !remove( chb.id ) ){\n+\n+ chb.checked = false;\n+ }else{\n+ alarm( \"tag-remove\", {short: chb.id});\n+ clear( chb.parentElement );\n+ }\n+ }\n+ }\n+\n+ //adds custom tag to the tags dictionary & saves it to localStorage ToDo\n+ function addCustom( tag ){\n+\n+ var cTags = JSON.parse( localStorage.getItem( 'cTags' ) );\n+ }\n+\n+ //finds tag object in the dictionary\n+ function findTag ( tagShort ){\n+\n+ for( var i = 0; i < taglist.tags.length; i++ ){\n+\n+ for( var j = 0; j < taglist.tags[i].tags.length; j++ ){\n+\n+ if( taglist.tags[i].tags[j].short === tagShort ){\n+\n+ return taglist.tags[i].tags[j];\n+ }\n+ }\n+ }\n+ return false;\n+ }\n+\n+ //makes all the links in the tagList insert it's tag\n+ function initLinks(){\n+\n+ wrapper.addEventListener( 'click', function( evt ){\n+\n+ if( evt.target.tagName === 'A' && evt.target.hasAttribute( 'data-tag' ) ){\n+\n+ editor.insert( evt.target.getAttribute( 'data-tag' ) );\n+ }\n+ } );\n+ }\n+\n+ //check if user possible wrote snippet <special_char><tag_shortcut><special_char>\n+ function handleSnippets( textBox, patterns, insert){\n+\n+ //ignore if anything else than snippet pattern given\n+ if( textBox.value[textBox.selectionStart-1] != patterns.snippetChar ) return;\n+ var endPos = textBox.selectionStart - 1;\n+\n+ //look if there is a snippet opener\n+ if( !textBox.value.substring( 0, endPos - 1 ).match( patterns.snippetChar ) ) return;\n+ var startPos = textBox.value.substring( 0, endPos).lastIndexOf( patterns.snippetChar );\n+\n+ var phrase = textBox.value.substring( startPos+1, endPos );\n+ if( phrase.match( patterns.snippetBreakers ) ) return;\n+\n+ var isExt = false;\n+ var tag;\n+\n+ if( phrase.indexOf( patterns.extChar ) != -1 ){\n+\n+ tag = findTag( phrase.substring( 0, phrase.indexOf( patterns.extChar ) ) );\n+ isExt = true;\n+ }else{\n+\n+ tag = findTag( phrase );\n+ }\n+\n+ if( tag ){\n+\n+ var ext = '',\n+ phr = tag.tag,\n+ phrTab,\n+ extTab;\n+\n+ if( isExt && phr.indexOf( patterns.caret ) ){\n+\n+ phrTab = phr.split( patterns.caret );\n+ extTab = phrase.split( patterns.extChar );\n+ extTab.splice( 0, 1 );\n+ ext = ( tag.extensions ) ? tag.extensions.apply( tag, extTab ) : ext;\n+ }\n+\n+ var sel = textBox.selectionStart;\n+ textBox.value = textBox.value.substring( 0, startPos ) +\n+ textBox.value.substring( endPos + 1 );\n+\n+ textBox.selectionStart = textBox.selectionEnd = sel - ( endPos + 1 - startPos );\n+ if( phrTab && isExt) {\n+ var ending = ( phrTab[1] ) ? phrTab[1] : '';\n+ insert( phrTab[0] + ext + ending );\n+ }\n+ else insert( phr + ext);\n+ }\n+ }\n+ \n+ //module initializer\n+ function init(){\n+\n+ editor.init( handleSnippets );\n+\n+ loader({\n+\n+ type: loader.MULTI,\n+ resources: {\n+ mustache: '/extensions/wikia/WikiaMobileEditor/templates/WikiaMobileEditorController_tagList.mustache'\n+ }\n+ }).done(function(resp){\n+\n+ wrapper.innerHTML = mustache.render(resp.mustache[0], taglist);\n+\n+ //menu initializing tags from lS or default ones\n+ active = [\n+ taglist.tags[1].tags[13],\n+ taglist.tags[0].tags[1],\n+ taglist.tags[0].tags[2],\n+ taglist.tags[0].tags[3],\n+ taglist.tags[0].tags[4],\n+ taglist.tags[0].tags[5],\n+ taglist.tags[0].tags[6],\n+ taglist.tags[1].tags[0],\n+ taglist.tags[1].tags[1],\n+ taglist.tags[1].tags[2],\n+ taglist.tags[1].tags[3],\n+ taglist.tags[1].tags[4],\n+ taglist.tags[1].tags[5],\n+ taglist.tags[1].tags[6],\n+ taglist.tags[1].tags[7],\n+ taglist.tags[1].tags[8],\n+ taglist.tags[1].tags[9],\n+ taglist.tags[1].tags[10],\n+ taglist.tags[1].tags[11],\n+ taglist.tags[1].tags[12]\n+ ];\n+\n+ markTags( active );","path":"extensions/wikia/WikiaMobileEditor/js/config2.js","position":486,"original_position":486,"commit_id":"a7185525428fc0b38b46c5f09d1b3cf5d3c501f1","original_commit_id":"a7185525428fc0b38b46c5f09d1b3cf5d3c501f1","user":{"login":"hakubo","id":1018759,"avatar_url":"https://1.gravatar.com/avatar/436a51c106f26ddb5e5379479842c8c0?d=https%3A%2F%2Fidenticons.github.com%2F125302bc102f69f59ce04dec8f5f9f30.png","gravatar_id":"436a51c106f26ddb5e5379479842c8c0","url":"https://api.github.com/users/hakubo","html_url":"https://github.com/hakubo","followers_url":"https://api.github.com/users/hakubo/followers","following_url":"https://api.github.com/users/hakubo/following{/other_user}","gists_url":"https://api.github.com/users/hakubo/gists{/gist_id}","starred_url":"https://api.github.com/users/hakubo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hakubo/subscriptions","organizations_url":"https://api.github.com/users/hakubo/orgs","repos_url":"https://api.github.com/users/hakubo/repos","events_url":"https://api.github.com/users/hakubo/events{/privacy}","received_events_url":"https://api.github.com/users/hakubo/received_events","type":"User","site_admin":false},"body":"too many white lines around\r\n\r\ntry to group lines together ","created_at":"2013-10-17T00:10:53Z","updated_at":"2013-10-17T00:10:53Z","html_url":"https://github.com/Wikia/app/pull/1762#discussion_r7020534","pull_request_url":"https://api.github.com/repos/Wikia/app/pulls/1762","_links":{"self":{"href":"https://api.github.com/repos/Wikia/app/pulls/comments/7020534"},"html":{"href":"https://github.com/Wikia/app/pull/1762#discussion_r7020534"},"pull_request":{"href":"https://api.github.com/repos/Wikia/app/pulls/1762"}}}} | {
"id": 5532313,
"name": "app",
"url": "https://github.com/Wikia/app"
} | {
"id": null,
"login": "hakubo",
"gravatar_id": "436a51c106f26ddb5e5379479842c8c0",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "Wikia",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-10-17T00:10:53 | null | {"repository":{"description":"Wikia Application Code","homepage":"http://dev.wikia.com","watchers":40,"stargazers":40,"forks":29,"fork":false,"size":533288,"owner":"Wikia","private":false,"open_issues":45,"has_issues":false,"has_downloads":true,"has_wiki":false,"language":"PHP","created_at":"2012-08-23T13:55:58-07:00","pushed_at":"2013-10-16T16:57:45-07:00","master_branch":"dev","organization":"Wikia"},"actor_attributes":{"type":"User","name":"Jakub Olek","company":"Wikia","blog":"8bit.wikia.com","location":"Poznań","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/Wikia/app/pull/1762#discussion_r7020534"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/adobe/brackets/pulls/comments/7096155","id":7096155,"diff_hunk":"@@ -133,11 +133,17 @@ define(function (require, exports, module) {\n } else if (e.which === KeyEvent.DOM_VK_ESCAPE) {\n buttonId = DIALOG_BTN_CANCEL;\n } else if (e.which === KeyEvent.DOM_VK_RETURN && !inTextArea) { // enter key in single-line text input still dismisses\n- // Click primary button\n- $primaryBtn.click();\n+ // Click focused button or primary if no focus\n+ if($focusedElement.length !== 0) {","path":"src/widgets/Dialogs.js","position":29,"original_position":29,"commit_id":"0d768285c814f18f4a92bd3c2aa7849455d83956","original_commit_id":"0d768285c814f18f4a92bd3c2aa7849455d83956","user":{"login":"redmunds","id":1197144,"avatar_url":"https://2.gravatar.com/avatar/bc4dc1a1f8e56e53cb59dbe14bfe9649?d=https%3A%2F%2Fidenticons.github.com%2Fb902e2eb189314dde52f693cebe423dc.png","gravatar_id":"bc4dc1a1f8e56e53cb59dbe14bfe9649","url":"https://api.github.com/users/redmunds","html_url":"https://github.com/redmunds","followers_url":"https://api.github.com/users/redmunds/followers","following_url":"https://api.github.com/users/redmunds/following{/other_user}","gists_url":"https://api.github.com/users/redmunds/gists{/gist_id}","starred_url":"https://api.github.com/users/redmunds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/redmunds/subscriptions","organizations_url":"https://api.github.com/users/redmunds/orgs","repos_url":"https://api.github.com/users/redmunds/repos","events_url":"https://api.github.com/users/redmunds/events{/privacy}","received_events_url":"https://api.github.com/users/redmunds/received_events","type":"User","site_admin":false},"body":"JSLint: Expected exactly one space between 'if' and '('.","created_at":"2013-10-21T15:03:22Z","updated_at":"2013-10-21T15:03:22Z","html_url":"https://github.com/adobe/brackets/pull/5579#discussion_r7096155","pull_request_url":"https://api.github.com/repos/adobe/brackets/pulls/5579","_links":{"self":{"href":"https://api.github.com/repos/adobe/brackets/pulls/comments/7096155"},"html":{"href":"https://github.com/adobe/brackets/pull/5579#discussion_r7096155"},"pull_request":{"href":"https://api.github.com/repos/adobe/brackets/pulls/5579"}}}} | {
"id": 2935735,
"name": "brackets",
"url": "https://github.com/adobe/brackets"
} | {
"id": null,
"login": "redmunds",
"gravatar_id": "bc4dc1a1f8e56e53cb59dbe14bfe9649",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "adobe",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-10-21T15:03:22 | null | {"repository":{"description":"An open source code editor for the web, written in JavaScript, HTML and CSS.","homepage":"http://brackets.io","watchers":12695,"stargazers":12695,"forks":2533,"fork":false,"size":161647,"owner":"adobe","private":false,"open_issues":567,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"JavaScript","created_at":"2011-12-07T13:14:40-08:00","pushed_at":"2013-10-21T08:02:25-07:00","master_branch":"master","organization":"adobe"},"actor_attributes":{"type":"User","name":"Randy Edmunds","company":"Adobe Systems, Inc.","location":"San Diego","email":"[email protected]"},"url":"https://github.com/adobe/brackets/pull/5579#discussion_r7096155"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/adobe/brackets/pulls/comments/3496175","id":3496175,"body":"PathUtils seems to be unused here","diff_hunk":"@@ -0,0 +1,281 @@\n+/*\n+ * Copyright (c) 2012 Adobe Systems Incorporated. All rights reserved.\n+ * \n+ * Permission is hereby granted, free of charge, to any person obtaining a\n+ * copy of this software and associated documentation files (the \"Software\"), \n+ * to deal in the Software without restriction, including without limitation \n+ * the rights to use, copy, modify, merge, publish, distribute, sublicense, \n+ * and/or sell copies of the Software, and to permit persons to whom the \n+ * Software is furnished to do so, subject to the following conditions:\n+ * \n+ * The above copyright notice and this permission notice shall be included in\n+ * all copies or substantial portions of the Software.\n+ * \n+ * THE SOFTWARE IS PROVIDED \"AS IS\", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR\n+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, \n+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE\n+ * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER \n+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING \n+ * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER \n+ * DEALINGS IN THE SOFTWARE.\n+ * \n+ */\n+\n+\n+/*jslint vars: true, plusplus: true, devel: true, nomen: true, indent: 4, maxerr: 50 */\n+/*global define, $, JSLINT, PathUtils, Mustache, brackets */","path":"src/extensions/default/JSLint/main.js","position":26,"original_position":26,"commit_id":"bdad83430c3a164ba6655136b0c42352fb064a88","original_commit_id":"bdad83430c3a164ba6655136b0c42352fb064a88","user":{"login":"DennisKehrig","id":1564859,"avatar_url":"https://secure.gravatar.com/avatar/9c3692686bd09f403ab230813d8e6578?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"9c3692686bd09f403ab230813d8e6578","url":"https://api.github.com/users/DennisKehrig","html_url":"https://github.com/DennisKehrig","followers_url":"https://api.github.com/users/DennisKehrig/followers","following_url":"https://api.github.com/users/DennisKehrig/following","gists_url":"https://api.github.com/users/DennisKehrig/gists{/gist_id}","starred_url":"https://api.github.com/users/DennisKehrig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DennisKehrig/subscriptions","organizations_url":"https://api.github.com/users/DennisKehrig/orgs","repos_url":"https://api.github.com/users/DennisKehrig/repos","events_url":"https://api.github.com/users/DennisKehrig/events{/privacy}","received_events_url":"https://api.github.com/users/DennisKehrig/received_events","type":"User"},"created_at":"2013-03-22T19:51:47Z","updated_at":"2013-03-22T19:51:47Z","html_url":"https://github.com/adobe/brackets/pull/3143#discussion_r3496175","pull_request_url":"https://api.github.com/repos/adobe/brackets/pulls/3143","_links":{"self":{"href":"https://api.github.com/repos/adobe/brackets/pulls/comments/3496175"},"html":{"href":"https://github.com/adobe/brackets/pull/3143#discussion_r3496175"},"pull_request":{"href":"https://api.github.com/repos/adobe/brackets/pulls/3143"}}}} | {
"id": 2935735,
"name": "brackets",
"url": "https://github.com/adobe/brackets"
} | {
"id": null,
"login": "DennisKehrig",
"gravatar_id": "9c3692686bd09f403ab230813d8e6578",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "adobe",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-03-22T19:51:47 | null | {"repository":{"description":"An open source code editor for the web, written in JavaScript, HTML and CSS.","homepage":"https://twitter.com/brackets","watchers":9264,"stargazers":9264,"forks":1454,"fork":false,"size":446412,"owner":"adobe","private":false,"open_issues":383,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"JavaScript","created_at":"2011-12-07T13:14:40-08:00","pushed_at":"2013-03-22T12:02:12-07:00","master_branch":"master","organization":"adobe"},"actor_attributes":{"type":"User","name":"Dennis Kehrig","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/adobe/brackets/pull/3143#discussion_r3496175"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/adobe/brackets/pulls/comments/4580504","id":4580504,"body":"After a fair amount of review, we deliberately chose to use a slightly heavier weight on the Mac because the standard weight seemed too light after we turned off subpixel antialiasing. I'm loath to go back on this decision now.","diff_hunk":"@@ -131,8 +131,7 @@\n }\n \n .code-font-mac() {\n- /* Use the Medium weight on the Mac to counterbalance the grayscale antialiasing. */\n- font-family: 'SourceCodePro-Medium', \"ＭＳ ゴシック\", \"MS Gothic\", monospace;\n+ font-family: 'SourceCodePro', \"ＭＳ ゴシック\", \"MS Gothic\", monospace;","path":"src/styles/brackets_theme_default.less","position":6,"original_position":6,"commit_id":"8c449347a9e433ad7b667e9e6bb90ff0eab5dcdb","original_commit_id":"8c449347a9e433ad7b667e9e6bb90ff0eab5dcdb","user":{"login":"njx","id":697759,"avatar_url":"https://secure.gravatar.com/avatar/6b448f9ed49b9b87ae5f86a97e4c0212?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"6b448f9ed49b9b87ae5f86a97e4c0212","url":"https://api.github.com/users/njx","html_url":"https://github.com/njx","followers_url":"https://api.github.com/users/njx/followers","following_url":"https://api.github.com/users/njx/following{/other_user}","gists_url":"https://api.github.com/users/njx/gists{/gist_id}","starred_url":"https://api.github.com/users/njx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/njx/subscriptions","organizations_url":"https://api.github.com/users/njx/orgs","repos_url":"https://api.github.com/users/njx/repos","events_url":"https://api.github.com/users/njx/events{/privacy}","received_events_url":"https://api.github.com/users/njx/received_events","type":"User"},"created_at":"2013-06-06T23:35:45Z","updated_at":"2013-06-06T23:35:45Z","html_url":"https://github.com/adobe/brackets/pull/4115#discussion_r4580504","pull_request_url":"https://api.github.com/repos/adobe/brackets/pulls/4115","_links":{"self":{"href":"https://api.github.com/repos/adobe/brackets/pulls/comments/4580504"},"html":{"href":"https://github.com/adobe/brackets/pull/4115#discussion_r4580504"},"pull_request":{"href":"https://api.github.com/repos/adobe/brackets/pulls/4115"}}}} | {
"id": 2935735,
"name": "brackets",
"url": "https://github.com/adobe/brackets"
} | {
"id": null,
"login": "njx",
"gravatar_id": "6b448f9ed49b9b87ae5f86a97e4c0212",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "adobe",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-06-06T23:35:45 | null | {"repository":{"description":"An open source code editor for the web, written in JavaScript, HTML and CSS.","homepage":"https://twitter.com/brackets","watchers":10278,"stargazers":10278,"forks":1749,"fork":false,"size":455688,"owner":"adobe","private":false,"open_issues":459,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"JavaScript","created_at":"2011-12-07T13:14:40-08:00","pushed_at":"2013-06-06T16:09:03-07:00","master_branch":"master","organization":"adobe"},"actor_attributes":{"type":"User","name":"Narciso Jaramillo","company":"Adobe","blog":"http://twitter.com/notwebsafe","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/adobe/brackets/pull/4115#discussion_r4580504"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/adobe/brackets/pulls/comments/6931028","id":6931028,"diff_hunk":"@@ -618,9 +618,22 @@ define(function (require, exports, module) {\n return hintList;\n }\n \n+ function activeEditorChangeHandler(event, current, previous) {\n+ $(current).on(\"editorChange\", _handleChange);","path":"src/editor/CodeHintManager.js","position":190,"original_position":190,"commit_id":"e3e9a6821b7e57929420f8d3ad6a345b98504983","original_commit_id":"e3e9a6821b7e57929420f8d3ad6a345b98504983","user":{"login":"RaymondLim","id":1542488,"avatar_url":"https://0.gravatar.com/avatar/5e78f1f6398b643b4e5269d2ab5e24c6?d=https%3A%2F%2Fidenticons.github.com%2F57d735d3e88b50accf03ab5d76419577.png","gravatar_id":"5e78f1f6398b643b4e5269d2ab5e24c6","url":"https://api.github.com/users/RaymondLim","html_url":"https://github.com/RaymondLim","followers_url":"https://api.github.com/users/RaymondLim/followers","following_url":"https://api.github.com/users/RaymondLim/following{/other_user}","gists_url":"https://api.github.com/users/RaymondLim/gists{/gist_id}","starred_url":"https://api.github.com/users/RaymondLim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RaymondLim/subscriptions","organizations_url":"https://api.github.com/users/RaymondLim/orgs","repos_url":"https://api.github.com/users/RaymondLim/repos","events_url":"https://api.github.com/users/RaymondLim/events{/privacy}","received_events_url":"https://api.github.com/users/RaymondLim/received_events","type":"User","site_admin":false},"body":"You need to check null on current before executing these two lines. ","created_at":"2013-10-12T07:33:30Z","updated_at":"2013-10-12T07:33:30Z","html_url":"https://github.com/adobe/brackets/pull/5421#discussion_r6931028","pull_request_url":"https://api.github.com/repos/adobe/brackets/pulls/5421","_links":{"self":{"href":"https://api.github.com/repos/adobe/brackets/pulls/comments/6931028"},"html":{"href":"https://github.com/adobe/brackets/pull/5421#discussion_r6931028"},"pull_request":{"href":"https://api.github.com/repos/adobe/brackets/pulls/5421"}}}} | {
"id": 2935735,
"name": "brackets",
"url": "https://github.com/adobe/brackets"
} | {
"id": null,
"login": "RaymondLim",
"gravatar_id": "5e78f1f6398b643b4e5269d2ab5e24c6",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "adobe",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-10-12T07:33:30 | null | {"repository":{"description":"An open source code editor for the web, written in JavaScript, HTML and CSS.","homepage":"http://brackets.io","watchers":12606,"stargazers":12606,"forks":2511,"fork":false,"size":160397,"owner":"adobe","private":false,"open_issues":532,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"JavaScript","created_at":"2011-12-07T13:14:40-08:00","pushed_at":"2013-10-11T23:56:56-07:00","master_branch":"master","organization":"adobe"},"actor_attributes":{"type":"User","name":"Raymond Lim","company":"Adobe Systems, Inc.","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/adobe/brackets/pull/5421#discussion_r6931028"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/adobe/brackets-shell/pulls/comments/6896383","id":6896383,"diff_hunk":"@@ -267,9 +267,9 @@ if (!appshell.app) {\n * \n * @return None. This is an asynchronous call that sends all return information to the callback.\n */\n- native function GetFileModificationTime();\n+ native function GetFileAttributes();\n appshell.fs.stat = function (path, callback) {\n- GetFileModificationTime(function (err, modtime, isDir) {\n+ GetFileAttributes(function (err, modtime, isDir, size) {","path":"appshell/appshell_extensions.js","position":null,"original_position":8,"commit_id":"8cd73c50739eff90196752ee10dbbf1c672d9130","original_commit_id":"cd161e20e4cdfc9cbcb625cc48764bac096faaa4","user":{"login":"couzteau","id":887904,"avatar_url":"https://0.gravatar.com/avatar/522318cfb7b9b10623038789edb64692?d=https%3A%2F%2Fidenticons.github.com%2F96c5f56d643ea6b13eb731947b5c0a49.png","gravatar_id":"522318cfb7b9b10623038789edb64692","url":"https://api.github.com/users/couzteau","html_url":"https://github.com/couzteau","followers_url":"https://api.github.com/users/couzteau/followers","following_url":"https://api.github.com/users/couzteau/following{/other_user}","gists_url":"https://api.github.com/users/couzteau/gists{/gist_id}","starred_url":"https://api.github.com/users/couzteau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/couzteau/subscriptions","organizations_url":"https://api.github.com/users/couzteau/orgs","repos_url":"https://api.github.com/users/couzteau/repos","events_url":"https://api.github.com/users/couzteau/events{/privacy}","received_events_url":"https://api.github.com/users/couzteau/received_events","type":"User","site_admin":false},"body":"changed name - but not returning more data - for now. Feature creep. I just need the size.","created_at":"2013-10-10T18:43:22Z","updated_at":"2013-10-10T18:43:22Z","html_url":"https://github.com/adobe/brackets-shell/pull/349#discussion_r6896383","pull_request_url":"https://api.github.com/repos/adobe/brackets-shell/pulls/349","_links":{"self":{"href":"https://api.github.com/repos/adobe/brackets-shell/pulls/comments/6896383"},"html":{"href":"https://github.com/adobe/brackets-shell/pull/349#discussion_r6896383"},"pull_request":{"href":"https://api.github.com/repos/adobe/brackets-shell/pulls/349"}}}} | {
"id": 4591033,
"name": "brackets-shell",
"url": "https://github.com/adobe/brackets-shell"
} | {
"id": null,
"login": "couzteau",
"gravatar_id": "522318cfb7b9b10623038789edb64692",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "adobe",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-10-10T18:43:22 | null | {"repository":{"description":"CEF3-based application shell for Brackets.","homepage":"http://brackets.io","watchers":368,"stargazers":368,"forks":316,"fork":false,"size":71675,"owner":"adobe","private":false,"open_issues":12,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Python","created_at":"2012-06-07T15:02:06-07:00","pushed_at":"2013-10-10T11:41:07-07:00","master_branch":"master","organization":"adobe"},"actor_attributes":{"type":"User","name":"Jochen","blog":"http://bitfaeule.net","location":"San Francisco","email":"[email protected]"},"url":"https://github.com/adobe/brackets-shell/pull/349#discussion_r6896383"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/adobe/brackets/pulls/comments/3104814","id":3104814,"body":"Nit: function body on a separate line.","path":"src/extensions/default/JavaScriptCodeHints/ScopeManager.js","position":192,"original_position":192,"commit_id":"eb85fb6831502839e0c6eed650674dbb1609fd9b","original_commit_id":"eb85fb6831502839e0c6eed650674dbb1609fd9b","user":{"login":"RaymondLim","id":1542488,"avatar_url":"https://secure.gravatar.com/avatar/5e78f1f6398b643b4e5269d2ab5e24c6?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"5e78f1f6398b643b4e5269d2ab5e24c6","url":"https://api.github.com/users/RaymondLim","html_url":"https://github.com/RaymondLim","followers_url":"https://api.github.com/users/RaymondLim/followers","following_url":"https://api.github.com/users/RaymondLim/following","gists_url":"https://api.github.com/users/RaymondLim/gists{/gist_id}","starred_url":"https://api.github.com/users/RaymondLim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RaymondLim/subscriptions","organizations_url":"https://api.github.com/users/RaymondLim/orgs","repos_url":"https://api.github.com/users/RaymondLim/repos","events_url":"https://api.github.com/users/RaymondLim/events{/privacy}","received_events_url":"https://api.github.com/users/RaymondLim/received_events","type":"User"},"created_at":"2013-02-21T19:38:21Z","updated_at":"2013-02-21T19:38:21Z","_links":{"self":{"href":"https://api.github.com/repos/adobe/brackets/pulls/comments/3104814"},"html":{"href":"https://github.com/adobe/brackets/pull/2873#discussion_r3104814"},"pull_request":{"href":"https://api.github.com/repos/adobe/brackets/pulls/2873"}}}} | {
"id": 2935735,
"name": "brackets",
"url": "https://github.com/adobe/brackets"
} | {
"id": null,
"login": "RaymondLim",
"gravatar_id": "5e78f1f6398b643b4e5269d2ab5e24c6",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "adobe",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-02-21T19:38:21 | null | {"repository":{"description":"An open source code editor for the web, written in JavaScript, HTML and CSS.","homepage":"https://twitter.com/brackets","watchers":8922,"stargazers":8922,"forks":1369,"fork":false,"size":445460,"owner":"adobe","private":false,"open_issues":360,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"JavaScript","created_at":"2011-12-07T13:14:40-08:00","pushed_at":"2013-02-21T11:32:06-08:00","master_branch":"master","organization":"adobe"},"actor_attributes":{"name":"Raymond Lim","company":"Adobe Systems, Inc.","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709","type":"User"},"url":"https://github.com/adobe/brackets/pull/2873#discussion_r3104814"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/anope/anope/pulls/comments/5057542","id":5057542,"body":"Tabbing/spaces/?","diff_hunk":"@@ -2597,13 +2637,10 @@ int moduleGetConfigDirective(Directive * d)\n }\n retval = parse_directive(d, directive, ac, av, linenum, 0, s);\n }\n- if (directive)\n- free(directive);\n+ Anope_Free(directive);\n+\t\tAnope_Free(dir);","path":"src/modules.c","position":283,"original_position":283,"commit_id":"cd02e46473c2881be960db5a56c208318b6b7405","original_commit_id":"cd02e46473c2881be960db5a56c208318b6b7405","user":{"login":"Adam-","id":309739,"avatar_url":"https://secure.gravatar.com/avatar/05c4b3f00fbd78e89faad4b559334881?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"05c4b3f00fbd78e89faad4b559334881","url":"https://api.github.com/users/Adam-","html_url":"https://github.com/Adam-","followers_url":"https://api.github.com/users/Adam-/followers","following_url":"https://api.github.com/users/Adam-/following{/other_user}","gists_url":"https://api.github.com/users/Adam-/gists{/gist_id}","starred_url":"https://api.github.com/users/Adam-/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Adam-/subscriptions","organizations_url":"https://api.github.com/users/Adam-/orgs","repos_url":"https://api.github.com/users/Adam-/repos","events_url":"https://api.github.com/users/Adam-/events{/privacy}","received_events_url":"https://api.github.com/users/Adam-/received_events","type":"User"},"created_at":"2013-07-08T05:16:03Z","updated_at":"2013-07-08T05:16:03Z","html_url":"https://github.com/anope/anope/pull/15#discussion_r5057542","pull_request_url":"https://api.github.com/repos/anope/anope/pulls/15","_links":{"self":{"href":"https://api.github.com/repos/anope/anope/pulls/comments/5057542"},"html":{"href":"https://github.com/anope/anope/pull/15#discussion_r5057542"},"pull_request":{"href":"https://api.github.com/repos/anope/anope/pulls/15"}}}} | {
"id": 909217,
"name": "anope",
"url": "https://github.com/anope/anope"
} | {
"id": null,
"login": "Adam-",
"gravatar_id": "05c4b3f00fbd78e89faad4b559334881",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "anope",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-07-08T05:16:03 | null | {"repository":{"description":"Anope IRC Services","homepage":"http://anope.org","watchers":36,"stargazers":36,"forks":19,"fork":false,"size":1700,"owner":"anope","private":false,"open_issues":1,"has_issues":false,"has_downloads":false,"has_wiki":false,"language":"C++","created_at":"2010-09-13T23:25:30-07:00","pushed_at":"2013-07-07T20:16:19-07:00","master_branch":"1.9","organization":"anope"},"actor_attributes":{"type":"User","name":"Adam","email":"[email protected]"},"url":"https://github.com/anope/anope/pull/15#discussion_r5057542"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/basho/riak_test/pulls/comments/4120862","id":4120862,"body":"No, I'll remove them.","diff_hunk":"@@ -0,0 +1,573 @@\n+-module(replication2_pg).\n+-export([confirm/0]).\n+-compile(export_all).\n+-include_lib(\"eunit/include/eunit.hrl\").\n+\n+-import(rt, [deploy_nodes/2,\n+ join/2,\n+ wait_until_nodes_ready/1,\n+ wait_until_no_pending_changes/1]).\n+\n+%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%\n+%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%\n+%% Test proxy_get in Default and Advanced mode of 1.3+ repl\n+%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%\n+%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%\n+setup_repl_clusters(Conf) ->\n+ NumNodes = 6,\n+ lager:info(\"Deploy ~p nodes\", [NumNodes]),\n+\n+ Nodes = deploy_nodes(NumNodes, Conf),\n+\n+ lager:info(\"Nodes = ~p\", [Nodes]),\n+ {[AFirst|_] = ANodes, Rest} = lists:split(2, Nodes),\n+ {[BFirst|_] = BNodes, [CFirst|_] = CNodes} = lists:split(2, Rest),\n+\n+ %%AllNodes = ANodes ++ BNodes ++ CNodes,\n+ rt:log_to_nodes(Nodes, \"Starting replication2_pg test\"),\n+\n+ lager:info(\"ANodes: ~p\", [ANodes]),\n+ lager:info(\"BNodes: ~p\", [BNodes]),\n+ lager:info(\"CNodes: ~p\", [CNodes]),\n+\n+ rt:log_to_nodes(Nodes, \"Building and connecting clusters\"),\n+\n+ lager:info(\"Build cluster A\"),\n+ repl_util:make_cluster(ANodes),\n+\n+ lager:info(\"Build cluster B\"),\n+ repl_util:make_cluster(BNodes),\n+\n+ lager:info(\"Build cluster C\"),\n+ repl_util:make_cluster(CNodes),\n+\n+ repl_util:name_cluster(AFirst, \"A\"),\n+ repl_util:name_cluster(BFirst, \"B\"),\n+ repl_util:name_cluster(CFirst, \"C\"),\n+ rt:wait_until_ring_converged(ANodes),\n+ rt:wait_until_ring_converged(BNodes),\n+ rt:wait_until_ring_converged(CNodes),\n+\n+ %% get the leader for the first cluster\n+ repl_util:wait_until_leader(AFirst),\n+ LeaderA = rpc:call(AFirst, riak_core_cluster_mgr, get_leader, []),\n+\n+ {ok, {_IP, BPort}} = rpc:call(BFirst, application, get_env,\n+ [riak_core, cluster_mgr]),\n+ repl_util:connect_cluster(LeaderA, \"127.0.0.1\", BPort),\n+\n+ {ok, {_IP, CPort}} = rpc:call(CFirst, application, get_env,\n+ [riak_core, cluster_mgr]),\n+ repl_util:connect_cluster(LeaderA, \"127.0.0.1\", CPort),\n+\n+ ?assertEqual(ok, repl_util:wait_for_connection(LeaderA, \"B\")),\n+ rt:wait_until_ring_converged(ANodes),\n+\n+ ?assertEqual(ok, repl_util:wait_for_connection(LeaderA, \"C\")),\n+ rt:wait_until_ring_converged(ANodes),\n+ {LeaderA, ANodes, BNodes, CNodes, Nodes}.\n+\n+\n+make_test_object(Suffix) ->\n+ Bucket = <<\"test_bucket\">>,\n+ KeyText = \"test_key\" ++ Suffix,\n+ ValueText = \"testdata_\" ++ Suffix,\n+ Key = erlang:list_to_binary(KeyText),\n+ Value = erlang:list_to_binary(ValueText),\n+ {Bucket, Key, Value}.\n+\n+test_basic_pg(Mode) ->\n+ banner(io_lib:format(\"test_basic_pg with ~p mode\", [Mode])),\n+ Conf = [\n+ {riak_repl,\n+ [\n+ {proxy_get, enabled},\n+ {fullsync_on_connect, false}\n+ ]}\n+ ],\n+ {LeaderA, ANodes, BNodes, _CNodes, AllNodes} =\n+ setup_repl_clusters(Conf),\n+ rt:log_to_nodes(AllNodes, \"Testing basic pg\"),\n+\n+ case Mode of\n+ mode_repl13 ->\n+ ModeRes = rpc:call(LeaderA, riak_repl_console, modes, [[\"mode_repl13\"]]),\n+ lager:info(\"ModeRes = ~p\", [ModeRes]);\n+ mixed ->\n+ lager:info(\"Using mode_repl12, mode_repl13\"),\n+ ok\n+ end,\n+ rt:wait_until_ring_converged(ANodes),\n+\n+ PGEnableResult = rpc:call(LeaderA, riak_repl_console, proxy_get, [[\"enable\",\"B\"]]),\n+ lager:info(\"Enabled pg: ~p\", [PGEnableResult]),\n+ Status = rpc:call(LeaderA, riak_repl_console, status, [quiet]),\n+\n+ case proplists:get_value(proxy_get_enabled, Status) of\n+ undefined -> fail;\n+ EnabledFor -> lager:info(\"PG enabled for cluster ~p\",[EnabledFor])\n+ end,\n+\n+ PidA = rt:pbc(LeaderA),\n+ {ok,CidA}=riak_repl_pb_api:get_clusterid(PidA),\n+ lager:info(\"Cluster ID for A = ~p\", [CidA]),\n+\n+ {Bucket, KeyA, ValueA} = make_test_object(\"a\"),\n+ {Bucket, KeyB, ValueB} = make_test_object(\"b\"),\n+\n+ rt:pbc_write(PidA, Bucket, KeyA, ValueA),\n+ rt:pbc_write(PidA, Bucket, KeyB, ValueB),\n+\n+ {_FirstA, FirstB, _FirstC} = get_firsts(AllNodes),\n+ PidB = rt:pbc(FirstB),\n+ lager:info(\"Connected to cluster B\"),\n+ {ok, PGResult} = riak_repl_pb_api:get(PidB,Bucket,KeyA,CidA),\n+ ?assertEqual(ValueA, riakc_obj:get_value(PGResult)),\n+\n+ rt:log_to_nodes(AllNodes, \"Disabling pg on A\"),\n+ PGDisableResult = rpc:call(LeaderA, riak_repl_console, proxy_get, [[\"disable\",\"B\"]]),\n+ lager:info(\"Disable pg ~p\", [PGDisableResult]),\n+ Status2 = rpc:call(LeaderA, riak_repl_console, status, [quiet]),\n+\n+ case proplists:get_value(proxy_get_enabled, Status2) of\n+ [] -> ok\n+ end,\n+\n+ rt:wait_until_ring_converged(ANodes),\n+ rt:wait_until_ring_converged(BNodes),\n+\n+ %% After the clusters are disconnected, see if the object was\n+ %% written locally after the PG\n+ {ok, PG2Value} = riak_repl_pb_api:get(PidB,Bucket,KeyA,CidA),\n+\n+ ?assertEqual(ValueA, riakc_obj:get_value(PG2Value)),\n+\n+ %% test an object that wasn't previously \"proxy-gotten\", it should fail\n+ FailedResult = riak_repl_pb_api:get(PidB,Bucket,KeyB,CidA),\n+ ?assertEqual({error, notfound}, FailedResult),\n+\n+ rt:clean_cluster(AllNodes),\n+ pass.\n+\n+%% test 1.2 replication (aka \"Default\" repl)\n+%% Mode is either mode_repl12 or mixed. \n+%% \"mixed\" is the default in 1.3: mode_repl12, mode_repl13\n+test_12_pg(Mode) ->\n+ banner(io_lib:format(\"test_12_pg with ~p mode\", [Mode])),\n+ Conf = [\n+ {riak_repl,\n+ [\n+ {proxy_get, enabled},\n+ {fullsync_on_connect, false}\n+ ]}\n+ ],\n+ {LeaderA, ANodes, BNodes, CNodes, AllNodes} =\n+ setup_repl_clusters(Conf),\n+\n+ {Bucket, KeyA, ValueA} = make_test_object(\"a\"),\n+ {Bucket, KeyB, ValueB} = make_test_object(\"b\"),\n+\n+ rt:log_to_nodes(AllNodes, \"Test 1.2 proxy_get\"),\n+ {_FirstA, FirstB, _FirstC} = get_firsts(AllNodes),\n+ case Mode of\n+ mode_repl12 ->\n+ ModeRes = rpc:call(FirstB, riak_repl_console, modes, [[\"mode_repl12\"]]),\n+ lager:info(\"ModeRes = ~p\", [ModeRes]);\n+ mixed ->\n+ lager:info(\"Using mode_repl12, mode_repl13\"),\n+ ok\n+ end,\n+ [rt:wait_until_ring_converged(Ns) || Ns <- [ANodes, BNodes, CNodes]],\n+\n+ PidA = rt:pbc(LeaderA),\n+ rt:pbc_write(PidA, Bucket, KeyA, ValueA),\n+ rt:pbc_write(PidA, Bucket, KeyB, ValueB),\n+\n+ {ok,CidA}=riak_repl_pb_api:get_clusterid(PidA),\n+ lager:info(\"Cluster ID for A = ~p\", [CidA]),\n+\n+ LeaderB = rpc:call(FirstB, riak_repl2_leader, leader_node, []),\n+ rt:log_to_nodes([LeaderB], \"Trying to use PG while it's disabled\"),\n+ PidB = rt:pbc(LeaderB),\n+ {error, notfound} = riak_repl_pb_api:get(PidB, Bucket, KeyA, CidA),\n+\n+ rt:log_to_nodes([LeaderA], \"Adding a listener\"),\n+ ListenerArgs = [[atom_to_list(LeaderA), \"127.0.0.1\", \"5666\"]],\n+ Res = rpc:call(LeaderA, riak_repl_console, add_listener, ListenerArgs),\n+ ?assertEqual(ok, Res),\n+\n+ [rt:wait_until_ring_converged(Ns) || Ns <- [ANodes, BNodes, CNodes]],\n+\n+ rt:log_to_nodes([FirstB], \"Adding a site\"),\n+ SiteArgs = [\"127.0.0.1\", \"5666\", \"rtmixed\"],\n+ Res = rpc:call(FirstB, riak_repl_console, add_site, [SiteArgs]),\n+ lager:info(\"Res = ~p\", [Res]),\n+\n+ rt:log_to_nodes(AllNodes, \"Waiting until connected\"),\n+ wait_until_12_connection(LeaderA),\n+\n+ [rt:wait_until_ring_converged(Ns) || Ns <- [ANodes, BNodes, CNodes]],\n+ lager:info(\"Trying proxy_get\"),\n+\n+ LeaderB2 = rpc:call(FirstB, riak_repl2_leader, leader_node, []),\n+ PidB2 = rt:pbc(LeaderB2),\n+ {ok, PGResult} = riak_repl_pb_api:get(PidB2, Bucket, KeyB, CidA),\n+ lager:info(\"PGResult: ~p\", [PGResult]),\n+ ?assertEqual(ValueB, riakc_obj:get_value(PGResult)),\n+\n+ rt:clean_cluster(AllNodes),\n+ pass.\n+\n+%% test shutting down nodes in source + sink clusters\n+test_pg_proxy() ->\n+ banner(\"test_pg_proxy\"),\n+ Conf = [\n+ {riak_repl,\n+ [\n+ {proxy_get, enabled},\n+ {fullsync_on_connect, false}\n+ ]}\n+ ],\n+ {LeaderA, ANodes, BNodes, _CNodes, AllNodes} =\n+ setup_repl_clusters(Conf),\n+ rt:log_to_nodes(AllNodes, \"Testing pg proxy\"),\n+ rt:wait_until_ring_converged(ANodes),\n+\n+ PGEnableResult = rpc:call(LeaderA, riak_repl_console, proxy_get, [[\"enable\",\"B\"]]),\n+ lager:info(\"Enabled pg: ~p\", [PGEnableResult]),\n+ Status = rpc:call(LeaderA, riak_repl_console, status, [quiet]),\n+\n+ case proplists:get_value(proxy_get_enabled, Status) of\n+ undefined -> fail;\n+ EnabledFor -> lager:info(\"PG enabled for cluster ~p\",[EnabledFor])\n+ end,\n+\n+ PidA = rt:pbc(LeaderA),\n+ {ok,CidA}=riak_repl_pb_api:get_clusterid(PidA),\n+ lager:info(\"Cluster ID for A = ~p\", [CidA]),\n+\n+ %% Write a new k/v for every PG test, otherwise you'll get a locally written response\n+ {Bucket, KeyA, ValueA} = make_test_object(\"a\"),\n+ {Bucket, KeyB, ValueB} = make_test_object(\"b\"),\n+ {Bucket, KeyC, ValueC} = make_test_object(\"c\"),\n+ {Bucket, KeyD, ValueD} = make_test_object(\"d\"),\n+\n+ rt:pbc_write(PidA, Bucket, KeyA, ValueA),\n+ rt:pbc_write(PidA, Bucket, KeyB, ValueB),\n+ rt:pbc_write(PidA, Bucket, KeyC, ValueC),\n+ rt:pbc_write(PidA, Bucket, KeyD, ValueD),\n+\n+ %% sanity check. You know, like the 10000 tests that autoconf runs \n+ %% before it actually does any work.\n+ {FirstA, FirstB, _FirstC} = get_firsts(AllNodes),\n+ PidB = rt:pbc(FirstB),\n+ lager:info(\"Connected to cluster B\"),\n+ {ok, PGResult} = riak_repl_pb_api:get(PidB,Bucket,KeyA,CidA),\n+ ?assertEqual(ValueA, riakc_obj:get_value(PGResult)),\n+\n+ lager:info(\"Stopping leader on requester cluster\"),\n+ PGLeaderB = rpc:call(FirstB, riak_core_cluster_mgr, get_leader, []),\n+ rt:log_to_nodes(AllNodes, \"Killing leader on requester cluster\"),\n+ rt:stop(PGLeaderB),\n+ [RunningBNode | _ ] = BNodes -- [PGLeaderB],\n+ repl_util:wait_until_leader(RunningBNode),\n+ lager:info(\"Now trying proxy_get\"),\n+ wait_until_pg(RunningBNode, PidB, Bucket, KeyC, CidA),\n+ lager:info(\"If you got here, proxy_get worked after the pg block requesting leader was killed\"),\n+\n+ lager:info(\"Stopping leader on provider cluster\"),\n+ PGLeaderA = rpc:call(FirstA, riak_core_cluster_mgr, get_leader, []),\n+ rt:stop(PGLeaderA),\n+ rt:log_to_nodes(AllNodes, \"Killing leader on provider cluster\"),\n+ [RunningANode | _ ] = ANodes -- [PGLeaderA],\n+ repl_util:wait_until_leader(RunningANode),\n+ wait_until_pg(RunningBNode, PidB, Bucket, KeyD, CidA),\n+ lager:info(\"If you got here, proxy_get worked after the pg block providing leader was killed\"),\n+ lager:info(\"pg_proxy test complete. Time to obtain celebratory cheese sticks.\"),\n+\n+ %% clean up so riak_test doesn't panic\n+ rt:start(PGLeaderA),","path":"tests/replication2_pg.erl","position":289,"original_position":289,"commit_id":"bf1c8d3166fadf7cafe68deba14cc03c8f32e2de","original_commit_id":"bf1c8d3166fadf7cafe68deba14cc03c8f32e2de","user":{"login":"metadave","id":58244,"avatar_url":"https://secure.gravatar.com/avatar/2a181b6e2658ad4106ea2bdd35e601f8?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"2a181b6e2658ad4106ea2bdd35e601f8","url":"https://api.github.com/users/metadave","html_url":"https://github.com/metadave","followers_url":"https://api.github.com/users/metadave/followers","following_url":"https://api.github.com/users/metadave/following{/other_user}","gists_url":"https://api.github.com/users/metadave/gists{/gist_id}","starred_url":"https://api.github.com/users/metadave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metadave/subscriptions","organizations_url":"https://api.github.com/users/metadave/orgs","repos_url":"https://api.github.com/users/metadave/repos","events_url":"https://api.github.com/users/metadave/events{/privacy}","received_events_url":"https://api.github.com/users/metadave/received_events","type":"User"},"created_at":"2013-05-07T19:22:53Z","updated_at":"2013-05-07T19:22:53Z","html_url":"https://github.com/basho/riak_test/pull/273#discussion_r4120862","pull_request_url":"https://api.github.com/repos/basho/riak_test/pulls/273","_links":{"self":{"href":"https://api.github.com/repos/basho/riak_test/pulls/comments/4120862"},"html":{"href":"https://github.com/basho/riak_test/pull/273#discussion_r4120862"},"pull_request":{"href":"https://api.github.com/repos/basho/riak_test/pulls/273"}}}} | {
"id": 3149948,
"name": "riak_test",
"url": "https://github.com/basho/riak_test"
} | {
"id": null,
"login": "metadave",
"gravatar_id": "2a181b6e2658ad4106ea2bdd35e601f8",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "basho",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-05-07T19:22:53 | null | {"repository":{"description":"I'm in your cluster, testing your riaks","homepage":"http://basho.github.com/riak_test/","watchers":25,"stargazers":25,"forks":6,"fork":false,"size":1532,"owner":"basho","private":false,"open_issues":32,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Erlang","created_at":"2012-01-10T16:31:00-08:00","pushed_at":"2013-05-07T10:32:20-07:00","master_branch":"master","organization":"basho"},"actor_attributes":{"type":"User","name":"Dave Parfitt","company":"Basho","blog":"http://about.me/metadave","location":"Buffalo, NY","email":"[email protected]"},"url":"https://github.com/basho/riak_test/pull/273#discussion_r4120862"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/basho/riak_core/pulls/comments/8516462","id":8516462,"diff_hunk":"@@ -831,6 +832,23 @@ add_user([Username|Options]) ->\n Error\n end.\n \n+alter_user([Username|Options]) ->\n+ case riak_core_security:alter_user(list_to_binary(Username),\n+ parse_options(Options)) of","path":"src/riak_core_console.erl","position":16,"original_position":16,"commit_id":"ceb875b57126e47f300bdf9c768b386c2ae82280","original_commit_id":"ceb875b57126e47f300bdf9c768b386c2ae82280","user":{"login":"evanmcc","id":38956,"avatar_url":"https://gravatar.com/avatar/647d8bae15a6921d394ff0dca0960eb5?d=https%3A%2F%2Fidenticons.github.com%2F24fc676fd9f7bba69640c6b1fd5c52f5.png&r=x","gravatar_id":"647d8bae15a6921d394ff0dca0960eb5","url":"https://api.github.com/users/evanmcc","html_url":"https://github.com/evanmcc","followers_url":"https://api.github.com/users/evanmcc/followers","following_url":"https://api.github.com/users/evanmcc/following{/other_user}","gists_url":"https://api.github.com/users/evanmcc/gists{/gist_id}","starred_url":"https://api.github.com/users/evanmcc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evanmcc/subscriptions","organizations_url":"https://api.github.com/users/evanmcc/orgs","repos_url":"https://api.github.com/users/evanmcc/repos","events_url":"https://api.github.com/users/evanmcc/events{/privacy}","received_events_url":"https://api.github.com/users/evanmcc/received_events","type":"User","site_admin":false},"body":"whitespace?","created_at":"2013-12-21T05:14:29Z","updated_at":"2013-12-21T05:14:29Z","html_url":"https://github.com/basho/riak_core/pull/451#discussion_r8516462","pull_request_url":"https://api.github.com/repos/basho/riak_core/pulls/451","_links":{"self":{"href":"https://api.github.com/repos/basho/riak_core/pulls/comments/8516462"},"html":{"href":"https://github.com/basho/riak_core/pull/451#discussion_r8516462"},"pull_request":{"href":"https://api.github.com/repos/basho/riak_core/pulls/451"}}}} | {
"id": 790938,
"name": "riak_core",
"url": "https://github.com/basho/riak_core"
} | {
"id": null,
"login": "evanmcc",
"gravatar_id": "647d8bae15a6921d394ff0dca0960eb5",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "basho",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-12-21T05:14:29 | null | {"repository":{"description":"Distributed systems infrastructure used by Riak.","homepage":"","watchers":379,"stargazers":379,"forks":131,"fork":false,"size":14479,"owner":"basho","private":false,"open_issues":61,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Erlang","created_at":"2010-07-22T07:11:49-07:00","pushed_at":"2013-12-20T17:18:38-08:00","master_branch":"develop","organization":"basho"},"actor_attributes":{"type":"User","name":"Evan Vigil-McClanahan","company":"Basho Technologies","location":"Esparto, CA","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/basho/riak_core/pull/451#discussion_r8516462"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/basho/riak_core/pulls/comments/7077598","id":7077598,"diff_hunk":"@@ -46,10 +48,14 @@ start_link() ->\n %% ===================================================================\n \n init([]) ->\n+ DistMonEnabled = app_helper:get_env(riak_core, disable_dist_mon,","path":"src/riak_core_sup.erl","position":13,"original_position":13,"commit_id":"a3ed175e312b449b59a9670010cf42f9f5054a1a","original_commit_id":"2852030ccb5b7c7863037ffa0dadbd5bf3a23bb8","user":{"login":"evanmcc","id":38956,"avatar_url":"https://2.gravatar.com/avatar/647d8bae15a6921d394ff0dca0960eb5?d=https%3A%2F%2Fidenticons.github.com%2F24fc676fd9f7bba69640c6b1fd5c52f5.png","gravatar_id":"647d8bae15a6921d394ff0dca0960eb5","url":"https://api.github.com/users/evanmcc","html_url":"https://github.com/evanmcc","followers_url":"https://api.github.com/users/evanmcc/followers","following_url":"https://api.github.com/users/evanmcc/following{/other_user}","gists_url":"https://api.github.com/users/evanmcc/gists{/gist_id}","starred_url":"https://api.github.com/users/evanmcc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evanmcc/subscriptions","organizations_url":"https://api.github.com/users/evanmcc/orgs","repos_url":"https://api.github.com/users/evanmcc/repos","events_url":"https://api.github.com/users/evanmcc/events{/privacy}","received_events_url":"https://api.github.com/users/evanmcc/received_events","type":"User","site_admin":false},"body":"My thinking was that since it's enabled by default, one would need to disable it, but it does look really ugly.","created_at":"2013-10-19T00:55:33Z","updated_at":"2013-10-19T00:55:33Z","html_url":"https://github.com/basho/riak_core/pull/414#discussion_r7077598","pull_request_url":"https://api.github.com/repos/basho/riak_core/pulls/414","_links":{"self":{"href":"https://api.github.com/repos/basho/riak_core/pulls/comments/7077598"},"html":{"href":"https://github.com/basho/riak_core/pull/414#discussion_r7077598"},"pull_request":{"href":"https://api.github.com/repos/basho/riak_core/pulls/414"}}}} | {
"id": 790938,
"name": "riak_core",
"url": "https://github.com/basho/riak_core"
} | {
"id": null,
"login": "evanmcc",
"gravatar_id": "647d8bae15a6921d394ff0dca0960eb5",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "basho",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-10-19T00:55:33 | null | {"repository":{"description":"Distributed systems infrastructure used by Riak.","homepage":"","watchers":354,"stargazers":354,"forks":114,"fork":false,"size":13602,"owner":"basho","private":false,"open_issues":58,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Erlang","created_at":"2010-07-22T07:11:49-07:00","pushed_at":"2013-10-18T17:53:44-07:00","master_branch":"develop","organization":"basho"},"actor_attributes":{"type":"User","name":"Evan Vigil-McClanahan","company":"Basho Technologies","location":"Esparto, CA","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/basho/riak_core/pull/414#discussion_r7077598"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/basho/riak_core/pulls/comments/6480942","id":6480942,"body":"Also, the -spec here appear to be a bit wonky: ok | max_concurrency doesn't match ok | max_tokens for the /1 and /2 arity flavors.","diff_hunk":"@@ -0,0 +1,529 @@\n+%% -------------------------------------------------------------------\n+%%\n+%% Copyright (c) 2013 Basho Technologies, Inc. All Rights Reserved.\n+%%\n+%% This file is provided to you under the Apache License,\n+%% Version 2.0 (the \"License\"); you may not use this file\n+%% except in compliance with the License. You may obtain\n+%% a copy of the License at\n+%%\n+%% http://www.apache.org/licenses/LICENSE-2.0\n+%%\n+%% Unless required by applicable law or agreed to in writing,\n+%% software distributed under the License is distributed on an\n+%% \"AS IS\" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY\n+%% KIND, either express or implied. See the License for the\n+%% specific language governing permissions and limitations\n+%% under the License.\n+%%\n+%% -------------------------------------------------------------------\n+-module(riak_core_bg_manager).\n+\n+-behaviour(gen_server).\n+\n+%% API\n+-export([\n+ %% Universal\n+ start_link/0,\n+ enable/0,\n+ disable/0,\n+ %% Locks\n+ %% TODO: refactor the lock implementation to another module ala tokens\n+ get_lock/1,\n+ get_lock/2,\n+ get_lock/3,\n+ lock_count/0,\n+ lock_count/1,\n+ lock_types/0,\n+ all_locks/0,\n+ query_locks/1,\n+ enable_locks/0,\n+ enable_locks/1,\n+ disable_locks/0,\n+ disable_locks/1,\n+ disable_locks/2,\n+ concurrency_limit/1,\n+ set_concurrency_limit/2,\n+ set_concurrency_limit/3,\n+ concurrency_limit_reached/1,\n+ %% Tokens, all proxied to riak_core_token_manager\n+ set_token_rate/2,\n+ token_rate/1,\n+ enable_tokens/0,\n+ enable_tokens/1,\n+ disable_tokens/0,\n+ disable_tokens/1,\n+ get_token/1,\n+ get_token/2,\n+ get_token/3,\n+ get_token_sync/1,\n+ get_token_sync/2,\n+ get_token_sync/3,\n+ token_types/0,\n+ tokens_given/0,\n+ tokens_given/1,\n+ tokens_waiting/0,\n+ tokens_waiting/1\n+ ]).\n+\n+-include(\"riak_core_token_manager.hrl\").\n+\n+%% gen_server callbacks\n+-export([init/1, handle_call/3, handle_cast/2, handle_info/2,\n+ terminate/2, code_change/3]).\n+\n+-record(state, {table_id:: ets:tid(), %% TableID of ?LM_ETS_TABLE\n+ enabled :: boolean()}).\n+\n+-record(lock_info, {concurrency_limit :: non_neg_integer(),\n+ enabled :: boolean()}).\n+\n+-define(SERVER, ?MODULE).\n+-define(DEFAULT_CONCURRENCY, 0). %% DO NOT CHANGE. DEFAULT SET TO 0 TO ENFORCE \"REGISTRATION\"\n+-define(limit(X), (X)#lock_info.concurrency_limit).\n+-define(enabled(X), (X)#lock_info.enabled).\n+-define(DEFAULT_LOCK_INFO, #lock_info{enabled=true, concurrency_limit=?DEFAULT_CONCURRENCY}).\n+-define(LM_ETS_TABLE, lock_mgr_table). %% name of private lock manager ETS table\n+-define(LM_ETS_OPTS, [private, bag]). %% creation time properties of lock manager ETS table\n+\n+-type concurrency_limit() :: non_neg_integer() | infinity.\n+\n+%%%===================================================================\n+%%% API\n+%%%===================================================================\n+\n+%% @doc Starts the server\n+-spec start_link() -> {ok, pid()} | ignore | {error, term}.\n+start_link() ->\n+ gen_server:start_link({local, ?SERVER}, ?MODULE, [], []).\n+\n+%% @doc Enable handing out of all background locks and tokens\n+-spec enable() -> ok.\n+enable() ->\n+ enable_tokens(),\n+ enable_locks().\n+\n+%% @doc Disable handing out of all background locks and tokens\n+-spec disable() -> ok.\n+disable() ->\n+ disable_tokens(),\n+ disable_locks().\n+\n+%%% Token API proxies to the token manager\n+\n+%% @doc Set the refill rate of tokens.\n+-spec set_token_rate(any(), riak_core_token_manager:tm_rate()) -> riak_core_token_manager:tm_rate().\n+set_token_rate(Type, {Period, Count}) ->\n+ riak_core_token_manager:set_token_rate(Type, {Period, Count}).\n+\n+-spec token_rate(any()) -> riak_core_token_manager:tm_rate().\n+token_rate(Type) ->\n+ riak_core_token_manager:token_rate(Type).\n+\n+%% @doc Asynchronously get a token of kind Type. returns \"max_tokens\" if empty\n+-spec get_token(any()) -> ok | max_tokens.\n+get_token(Type) ->\n+ get_token(Type, self()).\n+\n+%% @doc Asynchronously get a token of kind Type.\n+%% Associate token with provided pid or metadata. If metadata\n+%% is provided the lock is associated with the calling process.\n+%% Returns \"max_tokens\" if empty.\n+-spec get_token(any(), pid() | [{atom(), any()}]) -> ok | max_tokens.\n+get_token(Type, Pid) when is_pid(Pid) ->\n+ get_token(Type, Pid, []);\n+get_token(Type, Meta) ->\n+ get_token(Type, self(), Meta).\n+\n+-spec get_token(any(), pid(), [{atom(), any()}]) -> ok | max_concurrency.\n+get_token(Type, Pid, Meta) ->\n+ riak_core_token_manager:get_token_async(Type, Pid, Meta).","path":"src/riak_core_bg_manager.erl","position":140,"original_position":140,"commit_id":"68c3abef043b33c6acc4c30117bcdb4177f4e3cf","original_commit_id":"68c3abef043b33c6acc4c30117bcdb4177f4e3cf","user":{"login":"slfritchie","id":75320,"avatar_url":"https://2.gravatar.com/avatar/060adbfc2ae29925cf68444fe90fbc8c?d=https%3A%2F%2Fidenticons.github.com%2F3805ef2cf2995b070abc12dc92a3432e.png","gravatar_id":"060adbfc2ae29925cf68444fe90fbc8c","url":"https://api.github.com/users/slfritchie","html_url":"https://github.com/slfritchie","followers_url":"https://api.github.com/users/slfritchie/followers","following_url":"https://api.github.com/users/slfritchie/following{/other_user}","gists_url":"https://api.github.com/users/slfritchie/gists{/gist_id}","starred_url":"https://api.github.com/users/slfritchie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slfritchie/subscriptions","organizations_url":"https://api.github.com/users/slfritchie/orgs","repos_url":"https://api.github.com/users/slfritchie/repos","events_url":"https://api.github.com/users/slfritchie/events{/privacy}","received_events_url":"https://api.github.com/users/slfritchie/received_events","type":"User"},"created_at":"2013-09-20T07:26:35Z","updated_at":"2013-09-20T07:26:35Z","html_url":"https://github.com/basho/riak_core/pull/364#discussion_r6480942","pull_request_url":"https://api.github.com/repos/basho/riak_core/pulls/364","_links":{"self":{"href":"https://api.github.com/repos/basho/riak_core/pulls/comments/6480942"},"html":{"href":"https://github.com/basho/riak_core/pull/364#discussion_r6480942"},"pull_request":{"href":"https://api.github.com/repos/basho/riak_core/pulls/364"}}}} | {
"id": 790938,
"name": "riak_core",
"url": "https://github.com/basho/riak_core"
} | {
"id": null,
"login": "slfritchie",
"gravatar_id": "060adbfc2ae29925cf68444fe90fbc8c",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "basho",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-09-20T07:26:35 | null | {"repository":{"description":"Distributed systems infrastructure used by Riak.","homepage":"","watchers":348,"stargazers":348,"forks":112,"fork":false,"size":11992,"owner":"basho","private":false,"open_issues":3,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Erlang","created_at":"2010-07-22T07:11:49-07:00","pushed_at":"2013-09-17T16:20:16-07:00","master_branch":"develop","organization":"basho"},"actor_attributes":{"type":"User","name":"Scott Lystig Fritchie","company":"Basho Technologies / Snookles Music Consulting","blog":"http://www.snookles.com/scott/","location":"Minneapolis, MN USA","email":"[email protected]"},"url":"https://github.com/basho/riak_core/pull/364#discussion_r6480942"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/basho/riak_kv/pulls/comments/8451467","id":8451467,"diff_hunk":"@@ -680,22 +681,60 @@ build_or_rehash(Self, State=#state{index=Index, trees=Trees}) ->\n false -> build;\n true -> rehash\n end,\n- Lock = riak_kv_entropy_manager:get_lock(Type),\n- case {Lock, Type} of\n- {ok, build} ->\n- lager:debug(\"Starting build: ~p\", [Index]),\n- fold_keys(Index, Self),\n- lager:debug(\"Finished build (a): ~p\", [Index]), \n- gen_server:cast(Self, build_finished);\n- {ok, rehash} ->\n- lager:debug(\"Starting rehash: ~p\", [Index]),\n- [hashtree:rehash_tree(T) || {_,T} <- Trees],\n- lager:debug(\"Finished rehash (a): ~p\", [Index]),\n- gen_server:cast(Self, build_finished);\n- {_Error, _} ->\n+ case maybe_get_vnode_lock(Index) of\n+ ok ->\n+ Lock = riak_kv_entropy_manager:get_lock(Type),\n+ case {Lock, Type} of\n+ {ok, build} ->\n+ lager:debug(\"Starting build: ~p\", [Index]),\n+ fold_keys(Index, Self),\n+ lager:debug(\"Finished build (a): ~p\", [Index]), \n+ gen_server:cast(Self, build_finished);\n+ {ok, rehash} ->\n+ lager:debug(\"Starting rehash: ~p\", [Index]),\n+ [hashtree:rehash_tree(T) || {_,T} <- Trees],\n+ lager:debug(\"Finished rehash (a): ~p\", [Index]),\n+ gen_server:cast(Self, build_finished);\n+ {_Error, _} ->\n+ gen_server:cast(Self, build_failed)\n+ end;\n+ max_concurrency ->\n+ %% Something else is already doing a fold on this vnode.\n gen_server:cast(Self, build_failed)\n end.\n \n close_trees(State=#state{trees=Trees}) ->\n Trees2 = [{IdxN, hashtree:close(Tree)} || {IdxN, Tree} <- Trees],\n State#state{trees=Trees2}.\n+\n+%% @private\n+%% @doc Return true iff neither of the \"skip background manager\" configuration\n+%% settings are defined as anything other than false. 'skip_background_manager'\n+%% turns off all use of bg-mgr. 'aae_skip_background_manager' only stops\n+%% AAE tree rebuilds from using bg-mgr.\n+-spec use_bg_mgr() -> boolean().\n+use_bg_mgr() ->\n+ %% note we're tolerant here of any non-boolean value as well. Iff it's 'false', we don't skip.\n+ GlobalSkip = app_helper:get_env(riak_core, skip_background_manager, false) =/= false,\n+ AAESkip = app_helper:get_env(riak_core, aae_skip_background_manager, false) =/= false,\n+ not (GlobalSkip orelse AAESkip).\n+\n+%% @private\n+%% @doc Unless skipping the background manager, try to acquire the per-vnode lock.\n+%% Sets our task meta-data in the lock as 'aae_rebuild', which is useful for\n+%% seeing what's holding the lock via @link riak_core_background_mgr:ps/0.\n+-spec maybe_get_vnode_lock(SrcPartition::integer()) -> ok | max_concurrency.\n+maybe_get_vnode_lock(SrcPartition) ->","path":"src/riak_kv_index_hashtree.erl","position":68,"original_position":68,"commit_id":"f16f71bd0408bab1dad6e1b6ef2e65e5670b5062","original_commit_id":"f16f71bd0408bab1dad6e1b6ef2e65e5670b5062","user":{"login":"jrwest","id":167790,"avatar_url":"https://gravatar.com/avatar/98c57a5208aac0c0fdee1c531bb18d69?d=https%3A%2F%2Fidenticons.github.com%2F76d332ad822d75226cead4e913bed7b7.png&r=x","gravatar_id":"98c57a5208aac0c0fdee1c531bb18d69","url":"https://api.github.com/users/jrwest","html_url":"https://github.com/jrwest","followers_url":"https://api.github.com/users/jrwest/followers","following_url":"https://api.github.com/users/jrwest/following{/other_user}","gists_url":"https://api.github.com/users/jrwest/gists{/gist_id}","starred_url":"https://api.github.com/users/jrwest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrwest/subscriptions","organizations_url":"https://api.github.com/users/jrwest/orgs","repos_url":"https://api.github.com/users/jrwest/repos","events_url":"https://api.github.com/users/jrwest/events{/privacy}","received_events_url":"https://api.github.com/users/jrwest/received_events","type":"User","site_admin":false},"body":"We're going to need to test it anyways whether it's at the call or definition site and modifying the eqc test for this should be pretty straight forward. Plus the eqc test already exists. It seems to me that the new surface area is either spread over the call sites or the definition site (bg mgr) since the latter is new code IMO vs changing established code even more it makes more sense to localize the changes to the bg mgr and reduce repetition at least to me.\r\n\r\nAll in all the, I'm somewhat indifferent if it continues to work. \r\n\r\nSent from my iPhone\r\n\r\n> On Dec 18, 2013, at 12:42 PM, Chris T <[email protected]> wrote:\r\n> \r\n> In src/riak_kv_index_hashtree.erl:\r\n> \r\n> > +%% settings are defined as anything other than false. 'skip_background_manager'\r\n> > +%% turns off all use of bg-mgr. 'aae_skip_background_manager' only stops\r\n> > +%% AAE tree rebuilds from using bg-mgr.\r\n> > +-spec use_bg_mgr() -> boolean().\r\n> > +use_bg_mgr() ->\r\n> > + %% note we're tolerant here of any non-boolean value as well. Iff it's 'false', we don't skip.\r\n> > + GlobalSkip = app_helper:get_env(riak_core, skip_background_manager, false) =/= false,\r\n> > + AAESkip = app_helper:get_env(riak_core, aae_skip_background_manager, false) =/= false,\r\n> > + not (GlobalSkip orelse AAESkip).\r\n> > +\r\n> > +%% @private\r\n> > +%% @doc Unless skipping the background manager, try to acquire the per-vnode lock.\r\n> > +%% Sets our task meta-data in the lock as 'aae_rebuild', which is useful for\r\n> > +%% seeing what's holding the lock via @link riak_core_background_mgr:ps/0.\r\n> > +-spec maybe_get_vnode_lock(SrcPartition::integer()) -> ok | max_concurrency.\r\n> > +maybe_get_vnode_lock(SrcPartition) ->\r\n> While I don't mind moving the global check into get_lock, I don't like moving this into the arguments of get_lock, unless we're not planning on writing more eqc tests for it. Having a function in bg-mgr that does the checks for you is cool, though. Otherwise, it's going to get messy. We'd need to add these to more of the API, at least get_token, and set_concurrency_limit. More surface area.\r\n> \r\n> I propose that I create two additional helper functions in bg-mgr that do the config checking, but the call points still do the tests.\r\n> \r\n> —\r\n> Reply to this email directly or view it on GitHub.","created_at":"2013-12-18T21:17:13Z","updated_at":"2013-12-18T21:17:13Z","html_url":"https://github.com/basho/riak_kv/pull/769#discussion_r8451467","pull_request_url":"https://api.github.com/repos/basho/riak_kv/pulls/769","_links":{"self":{"href":"https://api.github.com/repos/basho/riak_kv/pulls/comments/8451467"},"html":{"href":"https://github.com/basho/riak_kv/pull/769#discussion_r8451467"},"pull_request":{"href":"https://api.github.com/repos/basho/riak_kv/pulls/769"}}}} | {
"id": 791522,
"name": "riak_kv",
"url": "https://github.com/basho/riak_kv"
} | {
"id": null,
"login": "jrwest",
"gravatar_id": "98c57a5208aac0c0fdee1c531bb18d69",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "basho",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-12-18T21:17:13 | null | {"repository":{"description":"Riak Key/Value Store","homepage":"","watchers":198,"stargazers":198,"forks":104,"fork":false,"size":13573,"owner":"basho","private":false,"open_issues":103,"has_issues":true,"has_downloads":true,"has_wiki":false,"language":"Erlang","created_at":"2010-07-22T10:27:35-07:00","pushed_at":"2013-12-18T10:38:32-08:00","master_branch":"develop","organization":"basho"},"actor_attributes":{"type":"User","name":"Jordan West","company":"Basho","blog":"blog.jordanwest.me","location":"San Francisco, CA","email":"[email protected]"},"url":"https://github.com/basho/riak_kv/pull/769#discussion_r8451467"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/basho/riak_dt/pulls/comments/6384918","id":6384918,"body":"Use `nonempty()` on these generators.","diff_hunk":"@@ -0,0 +1,423 @@\n+%% -------------------------------------------------------------------\n+%%\n+%% riak_dt_orswot: Tombstone-less, replicated, state based observe remove set\n+%%\n+%% Copyright (c) 2007-2013 Basho Technologies, Inc. All Rights Reserved.\n+%%\n+%% This file is provided to you under the Apache License,\n+%% Version 2.0 (the \"License\"); you may not use this file\n+%% except in compliance with the License. You may obtain\n+%% a copy of the License at\n+%%\n+%% http://www.apache.org/licenses/LICENSE-2.0\n+%%\n+%% Unless required by applicable law or agreed to in writing,\n+%% software distributed under the License is distributed on an\n+%% \"AS IS\" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY\n+%% KIND, either express or implied. See the License for the\n+%% specific language governing permissions and limitations\n+%% under the License.\n+%%\n+%% -------------------------------------------------------------------\n+\n+%% @doc An OR-Set CRDT. An OR-Set allows the adding, and removal, of\n+%% elements. Should an add and remove be concurrent, the add wins. In\n+%% this implementation there is a version vector for the whole set.\n+%% When an element is added to the set, the version vector is\n+%% incremented and the `{actor(), count()}' pair for that increment is\n+%% stored against the element as its \"birth dot\". Every time the\n+%% element is re-added to the set, its \"birth dot\" is updated to that\n+%% of the `{actor(), count()}' version vector entry resulting from the\n+%% add. When an element is removed, we simply drop it, no tombstones.\n+%%\n+%% When an element exists in replica A and not replica B, is it\n+%% because A added it and B has not yet seen that, or that B removed\n+%% it and A has not yet seen that? Usually the presence of a tombstone\n+%% arbitrates. In this implementation we compare the \"birth dot\" of\n+%% the present element to the clock in the Set it is absent from. If\n+%% the element dot is not \"seen\" by the Set clock, that means the\n+%% other set has yet to see this add, and the item is in the merged\n+%% Set. If the Set clock dominates the dot, that means the other Set\n+%% has removed this element already, and the item is not in the merged\n+%% Set.\n+%%\n+%% Essentially we've made a dotted version vector.\n+%%\n+%% @see riak_dt_multi, riak_dt_vclock\n+%%\n+%% @reference Marc Shapiro, Nuno Preguiça, Carlos Baquero, Marek\n+%% Zawirski (2011) A comprehensive study of Convergent and Commutative\n+%% Replicated Data Types. http://hal.upmc.fr/inria-00555588/\n+%%\n+%% @reference Annette Bieniusa, Marek Zawirski, Nuno Preguiça, Marc\n+%% Shapiro, Carlos Baquero, Valter Balegas, Sérgio Duarte (2012) An\n+%% Optimized Conflict-free Replicated Set\n+%% http://arxiv.org/abs/1210.3368\n+%%\n+%% @reference Nuno Preguiça, Carlos Baquero, Paulo Sérgio Almeida,\n+%% Victor Fonte, Ricardo Gonçalves http://arxiv.org/abs/1011.5808\n+%%\n+%% @end\n+-module(riak_dt_orswot).\n+\n+-behaviour(riak_dt).\n+\n+-ifdef(EQC).\n+-include_lib(\"eqc/include/eqc.hrl\").\n+-endif.\n+\n+-ifdef(TEST).\n+-include_lib(\"eunit/include/eunit.hrl\").\n+-endif.\n+\n+%% API\n+-export([new/0, value/1, value/2]).\n+-export([update/3, merge/2, equal/2]).\n+-export([to_binary/1, from_binary/1]).\n+-export([precondition_context/1]).\n+\n+%% EQC API\n+-ifdef(EQC).\n+-export([gen_op/0, update_expected/3, eqc_state_value/1, init_state/0, generate/0]).\n+-endif.\n+\n+-export_type([orswot/0, orswot_op/0, binary_orswot/0]).\n+\n+-opaque orswot() :: {riak_dt_vclock:vclock(), actorlist(), entries()}.\n+-opaque binary_orswot() :: binary(). %% A binary that from_binary/1 will operate on.\n+\n+-type orswot_op() :: {add, member()} | {remove, member()} |\n+ {add_all, [member()]} | {remove_all, [member()]} |\n+ {update, [orswot_op()]}.\n+-type orswot_q() :: size | {contains, term()}.\n+\n+%% a dict of actor() -> Alias::integer() mappings\n+%% Reason being to keep the dots as small as\n+%% possible and not repeat actor names over and over.\n+-type actorlist() :: [ {actor(), integer()} ].\n+-type actor() :: riak_dt:actor().\n+\n+%% a dict of member() -> member_info() mappings.\n+%% The `dot()' is a more effecient way of storing\n+%% knowledge about adds / removes than a UUID per add.\n+-type entries() :: [{member(), member_info()}].\n+\n+-type member_info() :: dot().\n+-type dot() :: {ActorAlias::pos_integer(), Count::pos_integer()}.\n+-type member() :: term().\n+\n+-spec new() -> orswot().\n+new() ->\n+ %% Use a dict of actors, and represent the actors as ints\n+ %% a sort of compression.\n+ {riak_dt_vclock:fresh(), orddict:new(), orddict:new()}.\n+\n+-spec value(orswot()) -> [member()].\n+value({_Clock, _Actors, Entries}) ->\n+ [K || {K, _Vclock} <- orddict:to_list(Entries)].\n+\n+-spec value(orswot_q(), orswot()) -> term().\n+value(size, ORset) ->\n+ length(value(ORset));\n+value({contains, Elem}, ORset) ->\n+ lists:member(Elem, value(ORset)).\n+\n+-spec update(orswot_op(), actor(), orswot()) -> {ok, orswot()} |\n+ {error, {precondition ,{not_present, member()}}}.\n+%% @doc take a list of Set operations and apply them to the set.\n+%% NOTE: either _all_ are applied, or _none_ are.\n+update({update, Ops}, Actor, ORSet) ->\n+ apply_ops(lists:sort(Ops), Actor, ORSet);\n+update({add, Elem}, Actor, ORSet) ->\n+ {ok, add_elem(Actor, ORSet, Elem)};\n+update({remove, Elem}, _Actor, ORSet) ->\n+ {_Clock, _Actors, Entries} = ORSet,\n+ remove_elem(orddict:find(Elem, Entries), Elem, ORSet);\n+update({add_all, Elems}, Actor, ORSet) ->\n+ ORSet2 = lists:foldl(fun(E, S) ->\n+ add_elem(Actor, S, E) end,\n+ ORSet,\n+ Elems),\n+ {ok, ORSet2};\n+\n+%% @doc note: this is atomic, either _all_ `Elems` are removed, or\n+%% none are.\n+update({remove_all, Elems}, Actor, ORSet) ->\n+ remove_all(Elems, Actor, ORSet).\n+\n+apply_ops([], _Actor, ORSet) ->\n+ {ok, ORSet};\n+apply_ops([Op | Rest], Actor, ORSet) ->\n+ case update(Op, Actor, ORSet) of\n+ {ok, ORSet2} ->\n+ apply_ops(Rest, Actor, ORSet2);\n+ Error ->\n+ Error\n+ end.\n+\n+remove_all([], _Actor, ORSet) ->\n+ {ok, ORSet};\n+remove_all([Elem | Rest], Actor, ORSet) ->\n+ case update({remove, Elem}, Actor, ORSet) of\n+ {ok, ORSet2} ->\n+ remove_all(Rest, Actor, ORSet2);\n+ Error ->\n+ Error\n+ end.\n+\n+-spec merge(orswot(), orswot()) -> orswot().\n+merge({Clock1, LHSActors, LHSEntries}, {Clock2, RHSActors, RHSEntries}) ->\n+ Actors = merge_actors(LHSActors, RHSActors),\n+ Clock = vclock_merge(Clock1, Clock2, LHSActors, RHSActors, Actors),\n+\n+ LHSClock = riak_dt_vclock:replace_actors(orddict:to_list(LHSActors), Clock1, 2),\n+ RHSClock = riak_dt_vclock:replace_actors(orddict:to_list(RHSActors), Clock2, 2),\n+ %% If an element is in both dicts, merge it. If it occurs in one,\n+ %% then see if its dot is dominated by the others whole set clock\n+ %% If so, then drop it, if not, keep it\n+ LHSKeys = sets:from_list(orddict:fetch_keys(LHSEntries)),\n+ RHSKeys = sets:from_list(orddict:fetch_keys(RHSEntries)),\n+ CommonKeys = sets:intersection(LHSKeys, RHSKeys),\n+ LHSUnique = sets:subtract(LHSKeys, CommonKeys),\n+ RHSUnique = sets:subtract(RHSKeys, CommonKeys),\n+\n+ Entries00 = merge_common_keys(CommonKeys, LHSEntries, RHSEntries, LHSActors, RHSActors, Actors),\n+ Entries0 = merge_disjoint_keys(LHSUnique, LHSEntries, RHSClock, LHSActors, Actors, Entries00),\n+ Entries = merge_disjoint_keys(RHSUnique, RHSEntries, LHSClock, RHSActors, Actors, Entries0),\n+\n+ {Clock, Actors, Entries}.\n+\n+%% @doc check if each element in `Entries' should be in the merged\n+%% set.\n+merge_disjoint_keys(Keys, Entries, SetClock, LocalActors, MergedActors, Accumulator) ->\n+ sets:fold(fun(Key, Acc) ->\n+ {Actor0, Count} = orddict:fetch(Key, Entries),\n+ {Real, Actor0} = lists:keyfind(Actor0, 2, LocalActors),\n+ case has_seen_dot({Real, riak_dt_vclock:get_counter(Real, SetClock)}, {Real, Count}) of\n+ false ->\n+ [NewDot] = riak_dt_vclock:replace_actors(orddict:to_list(MergedActors), [{Real, Count}]),\n+ orddict:store(Key, NewDot, Acc);\n+ true ->\n+ Acc\n+ end\n+ end,\n+ Accumulator,\n+ Keys).\n+\n+has_seen_dot({Actor, ClockCount}, {Actor, DotCount}) when ClockCount >= DotCount ->\n+ true;\n+has_seen_dot(_, _) ->\n+ false.\n+\n+%% @doc None of this is strictly needed for correctness, we could just\n+%% as easily take all the LHS entries for common keys. However,\n+%% `equal/2' requires a deterministic value for common keys. There is\n+%% probably a better way to get that, but for now we just take the\n+%% largest entry. When the count part of the dot is equal, we use the\n+%% actor to arbitrate.\n+merge_common_keys(CommonKeys, Entries1, Entries2, Actors1, Actors2, MergedActors) ->\n+ sets:fold(fun(Key, Acc) ->\n+ V1 = orddict:fetch(Key, Entries1),\n+ V2 = orddict:fetch(Key, Entries2),\n+ V = vclock_merge([V1], [V2], Actors1, Actors2, MergedActors),\n+ NewDot = greatest_dot(V),\n+ orddict:store(Key, NewDot, Acc) end,\n+ orddict:new(),\n+ CommonKeys).\n+\n+greatest_dot([Dot]) ->\n+ Dot;\n+greatest_dot([{A1, C1}, {_A2, C2}]) when C1 > C2 ->\n+ {A1, C1};\n+greatest_dot([{_A1, C1}, {A2, C2}]) when C1 < C2 ->\n+ {A2, C2};\n+%% Counts are equal, use the actor\n+greatest_dot([D1, D2]) when D1 > D2 ->\n+ D1;\n+greatest_dot([_, D2]) ->\n+ D2.\n+\n+-spec merge_actors(actorlist(), actorlist()) -> actorlist().\n+merge_actors(Actors1, Actors2) ->\n+ AL = [Actor || Actor <- orddict:fetch_keys(Actors1) ++ orddict:fetch_keys(Actors2)],\n+ Sorted = lists:usort(AL),\n+ {_Cnt, NewActors} = lists:foldl(fun(E, {Cnt, Dict}) ->\n+ {Cnt+1, orddict:store(E, Cnt, Dict)} end,\n+ {1, orddict:new()},\n+ Sorted),\n+ NewActors.\n+\n+-spec vclock_merge(riak_dt_vclock:vclock(), riak_dt_vclock:vclock(),\n+ actorlist(), actorlist(), actorlist()) -> riak_dt_vclock:vclock().\n+vclock_merge(V10, V20, Actors1, Actors2, MergedActors) ->\n+ V1 = riak_dt_vclock:replace_actors(orddict:to_list(Actors1), V10, 2),\n+ V2 = riak_dt_vclock:replace_actors(orddict:to_list(Actors2), V20, 2),\n+ Merged = riak_dt_vclock:merge([V1, V2]),\n+ riak_dt_vclock:replace_actors(orddict:to_list(MergedActors), Merged).\n+\n+-spec equal(orswot(), orswot()) -> boolean().\n+equal(ORSet1, ORSet2) ->\n+ ORSet1 == ORSet2.\n+\n+%% Private\n+-spec add_elem(actor(), orswot(), member()) -> orswot().\n+add_elem(Actor, {Clock, Actors0, Entries}, Elem) ->\n+ {Placeholder, Actors} = actor_placeholder(Actor, Actors0),\n+ NewClock = riak_dt_vclock:increment(Placeholder, Clock),\n+ Dot = riak_dt_vclock:get_counter(Placeholder, NewClock),\n+ {NewClock, Actors, orddict:store(Elem, {Placeholder, Dot}, Entries)}.\n+\n+-spec actor_placeholder(actor(), actorlist()) -> {non_neg_integer(), actorlist()}.\n+actor_placeholder(Actor, Actors) ->\n+ case orddict:find(Actor, Actors) of\n+ {ok, Placeholder} ->\n+ {Placeholder, Actors};\n+ error ->\n+ Placeholder = orddict:size(Actors) +1,\n+ {Placeholder, orddict:store(Actor, Placeholder, Actors)}\n+ end.\n+\n+remove_elem({ok, _Vclock}, Elem, {Clock, AL, Dict}) ->\n+ {ok, {Clock, AL, orddict:erase(Elem, Dict)}};\n+remove_elem(_, Elem, _ORSet) ->\n+ {error, {precondition, {not_present, Elem}}}.\n+\n+%% @doc the precondition context is a fragment of the CRDT\n+%% that operations with pre-conditions can be applied too.\n+%% In the case of OR-Sets this is the set of adds observed.\n+%% The system can then apply a remove to this context and merge it with a replica.\n+%% Especially useful for hybrid op/state systems where the context of an operation is\n+%% needed at a replica without sending the entire state to the client.\n+-spec precondition_context(orswot()) -> orswot().\n+precondition_context(ORSet) ->\n+ ORSet.\n+\n+-define(TAG, 75).\n+-define(V1_VERS, 1).\n+\n+-spec to_binary(orswot()) -> binary().\n+to_binary(ORSet) ->\n+ %% @TODO something smarter\n+ <<?TAG:8/integer, ?V1_VERS:8/integer, (term_to_binary(ORSet))/binary>>.\n+\n+-spec from_binary(binary()) -> orswot().\n+from_binary(<<?TAG:8/integer, ?V1_VERS:8/integer, Bin/binary>>) ->\n+ %% @TODO something smarter\n+ binary_to_term(Bin).\n+\n+%% ===================================================================\n+%% EUnit tests\n+%% ===================================================================\n+-ifdef(TEST).\n+\n+-ifdef(EQC).\n+eqc_value_test_() ->\n+ crdt_statem_eqc:run(?MODULE, 1000).\n+\n+generate() ->\n+ ?LET(Members, list(int()),\n+ lists:foldl(fun(M, Set) ->\n+ riak_dt_orswot:update({add, M}, choose(1, 50), Set) end,\n+ riak_dt_orswot:new(),\n+ Members)).\n+\n+%% EQC generator\n+gen_op() ->\n+ oneof([gen_updates(), gen_update()]).\n+\n+gen_updates() ->\n+ {update, non_empty(list(gen_update()))}.\n+\n+gen_update() ->\n+ oneof([{add, int()}, {remove, int()},\n+ {add_all, list(int())},","path":"src/riak_dt_orswot.erl","position":333,"original_position":333,"commit_id":"dbd9363a83bf353f8f50fcb264f9e595fc859cca","original_commit_id":"dbd9363a83bf353f8f50fcb264f9e595fc859cca","user":{"login":"seancribbs","id":1772,"avatar_url":"https://0.gravatar.com/avatar/ce461b57b6a1f65ce5b6cc1c124673e3?d=https%3A%2F%2Fidenticons.github.com%2F299570476c6f0309545110c592b6a63b.png","gravatar_id":"ce461b57b6a1f65ce5b6cc1c124673e3","url":"https://api.github.com/users/seancribbs","html_url":"https://github.com/seancribbs","followers_url":"https://api.github.com/users/seancribbs/followers","following_url":"https://api.github.com/users/seancribbs/following{/other_user}","gists_url":"https://api.github.com/users/seancribbs/gists{/gist_id}","starred_url":"https://api.github.com/users/seancribbs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seancribbs/subscriptions","organizations_url":"https://api.github.com/users/seancribbs/orgs","repos_url":"https://api.github.com/users/seancribbs/repos","events_url":"https://api.github.com/users/seancribbs/events{/privacy}","received_events_url":"https://api.github.com/users/seancribbs/received_events","type":"User"},"created_at":"2013-09-16T18:38:24Z","updated_at":"2013-09-16T18:38:24Z","html_url":"https://github.com/basho/riak_dt/pull/54#discussion_r6384918","pull_request_url":"https://api.github.com/repos/basho/riak_dt/pulls/54","_links":{"self":{"href":"https://api.github.com/repos/basho/riak_dt/pulls/comments/6384918"},"html":{"href":"https://github.com/basho/riak_dt/pull/54#discussion_r6384918"},"pull_request":{"href":"https://api.github.com/repos/basho/riak_dt/pulls/54"}}}} | {
"id": 2841977,
"name": "riak_dt",
"url": "https://github.com/basho/riak_dt"
} | {
"id": null,
"login": "seancribbs",
"gravatar_id": "ce461b57b6a1f65ce5b6cc1c124673e3",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "basho",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-09-16T18:38:24 | null | {"repository":{"description":"Riak core app for storing convergent data types","homepage":"","watchers":79,"stargazers":79,"forks":6,"fork":false,"size":1324,"owner":"basho","private":false,"open_issues":4,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Erlang","created_at":"2011-11-24T00:34:12-08:00","pushed_at":"2013-09-16T02:25:56-07:00","master_branch":"develop","organization":"basho"},"actor_attributes":{"type":"User","name":"Sean Cribbs","company":"Basho Technologies, Inc.","blog":"http://seancribbs.com/","location":"DeKalb, IL","email":"[email protected]"},"url":"https://github.com/basho/riak_dt/pull/54#discussion_r6384918"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/bitly/pynsq/pulls/comments/4435897","id":4435897,"body":"not really a big fan of logical clauses written like this (I had to think about it too much), I'd rather the more human-readable:\r\n\r\n```python\r\nif backoff_interval > 0 and backoff_interval != start_backoff_interval:\r\n # bla bla\r\n```","diff_hunk":"@@ -189,20 +193,54 @@ def _client_callback(self, response, message=None, task=None, conn=None, **kwarg\n This is the method that an asynchronous nsqreader should call to indicate\n async completion of a message. This will most likely be exposed as the respond\n callable in the Message instance with some functools voodoo\n+\n+ In addition, we take care of backoff and task blocking if a message is\n+ required WITH backoff. When this happens, we set a failure on the\n+ backoff timer and set the RDY count to zero. Once the backoff time has\n+ expired, we allow ONE of the connections to let a single message\n+ through in order to see if the task has recovered. In this state, one\n+ message at a time will pass through and once we have a success (ie: a\n+ message's .finish() is called), we go back to the normal RDY count.\n+\n+ NOTE: A message's .finish() and .requeue() count positively and\n+ negatively (resp) to the backoff state. .requeue(backoff=False),\n+ however, is considered neutral and will not help or hinder a task's\n+ backoff state.\n \"\"\"\n+ start_backoff_interval = self.backoff_timer[task].get_interval()\n if response is nsq.FIN:\n conn.in_flight -= 1\n- self.backoff_timer[task].success()\n+ if not self.backoff_block[task]:\n+ self.backoff_timer[task].success()\n self.finish(conn, message)\n elif response is nsq.REQ:\n conn.in_flight -= 1\n- if kwargs.get('backoff', True):\n+ if kwargs.get('backoff', True) and not self.backoff_block[task]: \n self.backoff_timer[task].failure()\n self.requeue(conn, message, time_ms=kwargs.get('time_ms', -1))\n elif response is nsq.TOUCH:\n- self.touch(conn, message)\n+ return self.touch(conn, message)\n else:\n raise TypeError(\"invalid NSQ response type: %s\" % response)\n+\n+ backoff_interval = self.backoff_timer[task].get_interval()\n+ if 0 < backoff_interval != start_backoff_interval:","path":"nsq/Reader.py","position":74,"original_position":74,"commit_id":"c9c0f4366ef388e13b676de2cccc73bccf17cc57","original_commit_id":"c9c0f4366ef388e13b676de2cccc73bccf17cc57","user":{"login":"mreiferson","id":187441,"avatar_url":"https://secure.gravatar.com/avatar/dd56a8e1de66aeedb987397511f830e7?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"dd56a8e1de66aeedb987397511f830e7","url":"https://api.github.com/users/mreiferson","html_url":"https://github.com/mreiferson","followers_url":"https://api.github.com/users/mreiferson/followers","following_url":"https://api.github.com/users/mreiferson/following{/other_user}","gists_url":"https://api.github.com/users/mreiferson/gists{/gist_id}","starred_url":"https://api.github.com/users/mreiferson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mreiferson/subscriptions","organizations_url":"https://api.github.com/users/mreiferson/orgs","repos_url":"https://api.github.com/users/mreiferson/repos","events_url":"https://api.github.com/users/mreiferson/events{/privacy}","received_events_url":"https://api.github.com/users/mreiferson/received_events","type":"User"},"created_at":"2013-05-29T14:48:13Z","updated_at":"2013-05-29T14:48:13Z","html_url":"https://github.com/bitly/pynsq/pull/28#discussion_r4435897","pull_request_url":"https://api.github.com/repos/bitly/pynsq/pulls/28","_links":{"self":{"href":"https://api.github.com/repos/bitly/pynsq/pulls/comments/4435897"},"html":{"href":"https://github.com/bitly/pynsq/pull/28#discussion_r4435897"},"pull_request":{"href":"https://api.github.com/repos/bitly/pynsq/pulls/28"}}}} | {
"id": 6475842,
"name": "pynsq",
"url": "https://github.com/bitly/pynsq"
} | {
"id": null,
"login": "mreiferson",
"gravatar_id": "dd56a8e1de66aeedb987397511f830e7",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "bitly",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-05-29T14:48:13 | null | {"repository":{"description":"official Python client library for NSQ","watchers":36,"stargazers":36,"forks":10,"fork":false,"size":299,"owner":"bitly","private":false,"open_issues":4,"has_issues":true,"has_downloads":true,"has_wiki":false,"language":"Python","created_at":"2012-10-31T08:09:40-07:00","pushed_at":"2013-05-09T14:44:43-07:00","master_branch":"master","organization":"bitly"},"actor_attributes":{"type":"User","name":"Matt Reiferson","company":"bitly","blog":"http://thejoyofcoding.org/","location":"New York, NY","email":"[email protected]"},"url":"https://github.com/bitly/pynsq/pull/28#discussion_r4435897"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/epnet/beerify/pulls/comments/6114621","id":6114621,"body":"You should sort alphabetically","diff_hunk":"@@ -2,7 +2,12 @@ class Photo < ActiveRecord::Base\n mount_uploader :attachment, PhotoUploader\n \n attr_accessible :attachment,\n+ :attachment_cache,\n :description,\n :priority,\n- :title\n+ :remove_attachment,","path":"app/models/photo.rb","position":8,"original_position":8,"commit_id":"7ad45368e4ecd48a050329b583dd6526266a0513","original_commit_id":"7ad45368e4ecd48a050329b583dd6526266a0513","user":{"login":"tiste","id":3153249,"avatar_url":"https://2.gravatar.com/avatar/8781ca2a4ea5a9bc0db653f9ba19ebeb?d=https%3A%2F%2Fidenticons.github.com%2F82e3845d1fb63f08f3321da3418972b9.png","gravatar_id":"8781ca2a4ea5a9bc0db653f9ba19ebeb","url":"https://api.github.com/users/tiste","html_url":"https://github.com/tiste","followers_url":"https://api.github.com/users/tiste/followers","following_url":"https://api.github.com/users/tiste/following{/other_user}","gists_url":"https://api.github.com/users/tiste/gists{/gist_id}","starred_url":"https://api.github.com/users/tiste/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tiste/subscriptions","organizations_url":"https://api.github.com/users/tiste/orgs","repos_url":"https://api.github.com/users/tiste/repos","events_url":"https://api.github.com/users/tiste/events{/privacy}","received_events_url":"https://api.github.com/users/tiste/received_events","type":"User"},"created_at":"2013-09-02T19:42:58Z","updated_at":"2013-09-02T19:42:58Z","html_url":"https://github.com/epnet/beerify/pull/11#discussion_r6114621","pull_request_url":"https://api.github.com/repos/epnet/beerify/pulls/11","_links":{"self":{"href":"https://api.github.com/repos/epnet/beerify/pulls/comments/6114621"},"html":{"href":"https://github.com/epnet/beerify/pull/11#discussion_r6114621"},"pull_request":{"href":"https://api.github.com/repos/epnet/beerify/pulls/11"}}}} | {
"id": 11905350,
"name": "beerify",
"url": "https://github.com/epnet/beerify"
} | {
"id": null,
"login": "tiste",
"gravatar_id": "8781ca2a4ea5a9bc0db653f9ba19ebeb",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "epnet",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-09-02T19:42:58 | null | {"repository":{"description":"We love beers, we love boilerplate. This is a Rails engine, containing beers and love.","watchers":2,"stargazers":2,"forks":0,"fork":false,"size":1484,"owner":"epnet","private":false,"open_issues":3,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"CSS","created_at":"2013-08-05T11:17:11-07:00","pushed_at":"2013-09-02T12:22:24-07:00","master_branch":"develop","organization":"epnet"},"actor_attributes":{"type":"User","name":"Baptiste Lecocq","company":"EPSI","blog":"tiste.io","location":"Lille","email":"[email protected]"},"url":"https://github.com/epnet/beerify/pull/11#discussion_r6114621"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/forge/core/pulls/comments/4056409","id":4056409,"body":"Okay, great. Let's try this.\r\n\r\n\r\nOn Thu, May 2, 2013 at 11:08 AM, Yann Albou <[email protected]>wrote:\r\n\r\n> In\r\n> project-model-maven/src/main/java/org/jboss/forge/maven/dependencies/RepositoryLookup.java:\r\n>\r\n> > @@ -71,11 +72,12 @@ public RepositoryLookup()\r\n> >\r\n> > @Inject\r\n> > public RepositoryLookup(final MavenContainer container, final ResourceFactory factory,\r\n> > - final ForgeEnvironment environment)\r\n> > + final ForgeEnvironment environment, final Project project)\r\n>\r\n> Yes, it is why in RepositoryLookup class I first tested if the repo method\r\n> parameter is null or empty and if it is the case then I use the repos from\r\n> maven request (initialized through populateDefaults )\r\n>\r\n> —\r\n> Reply to this email directly or view it on GitHub<https://github.com/forge/core/pull/316/files#r4056295>\r\n> .\r\n>\r\n\r\n\r\n\r\n-- \r\nLincoln Baxter, III\r\nhttp://ocpsoft.org\r\n\"Simpler is better.\"","diff_hunk":"@@ -71,11 +72,12 @@ public RepositoryLookup()\n \n @Inject\n public RepositoryLookup(final MavenContainer container, final ResourceFactory factory,\n- final ForgeEnvironment environment)\n+ final ForgeEnvironment environment, final Project project)","path":"project-model-maven/src/main/java/org/jboss/forge/maven/dependencies/RepositoryLookup.java","position":33,"original_position":33,"commit_id":"f53a68931a8b2ffd3fd54904e1502f34307129ac","original_commit_id":"f53a68931a8b2ffd3fd54904e1502f34307129ac","user":{"login":"lincolnthree","id":362329,"avatar_url":"https://secure.gravatar.com/avatar/be9be712febc4e422694a3a284421f66?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"be9be712febc4e422694a3a284421f66","url":"https://api.github.com/users/lincolnthree","html_url":"https://github.com/lincolnthree","followers_url":"https://api.github.com/users/lincolnthree/followers","following_url":"https://api.github.com/users/lincolnthree/following","gists_url":"https://api.github.com/users/lincolnthree/gists{/gist_id}","starred_url":"https://api.github.com/users/lincolnthree/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lincolnthree/subscriptions","organizations_url":"https://api.github.com/users/lincolnthree/orgs","repos_url":"https://api.github.com/users/lincolnthree/repos","events_url":"https://api.github.com/users/lincolnthree/events{/privacy}","received_events_url":"https://api.github.com/users/lincolnthree/received_events","type":"User"},"created_at":"2013-05-02T15:13:33Z","updated_at":"2013-05-02T15:13:33Z","html_url":"https://github.com/forge/core/pull/316#discussion_r4056409","pull_request_url":"https://api.github.com/repos/forge/core/pulls/316","_links":{"self":{"href":"https://api.github.com/repos/forge/core/pulls/comments/4056409"},"html":{"href":"https://github.com/forge/core/pull/316#discussion_r4056409"},"pull_request":{"href":"https://api.github.com/repos/forge/core/pulls/316"}}}} | {
"id": 1660918,
"name": "core",
"url": "https://github.com/forge/core"
} | {
"id": null,
"login": "lincolnthree",
"gravatar_id": "be9be712febc4e422694a3a284421f66",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "forge",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-05-02T15:13:33 | null | {"repository":{"description":"Forge Core Framework APIs and Implementation","homepage":"http://jboss.org/forge","watchers":104,"stargazers":104,"forks":86,"fork":false,"size":3212,"owner":"forge","private":false,"open_issues":3,"has_issues":false,"has_downloads":true,"has_wiki":false,"language":"Java","created_at":"2011-04-25T10:55:40-07:00","pushed_at":"2013-04-30T15:53:02-07:00","master_branch":"master","organization":"forge"},"actor_attributes":{"type":"User","name":"Lincoln Baxter, III","company":"JBoss by Red Hat, Inc","blog":"http://ocpsoft.com/","location":"USA","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/forge/core/pull/316#discussion_r4056409"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/gleez/cms/pulls/comments/3595040","id":3595040,"body":"for form action","diff_hunk":"@@ -150,11 +151,17 @@ public function action_login()\n \t\t$user = ORM::factory('user');\n \t\t$config = Kohana::$config->load('auth');\n \n+\t\t// Create form action\n+\t\t$destination = isset($_GET['destination']) ? $_GET['destination'] : Request::initial()->uri();\n+\t\t$params = array('action' => 'login');\n+\t\t$action = Route::get('user')->uri($params).URL::query(array('destination' => $destination));","path":"modules/user/classes/controller/user.php","position":36,"original_position":36,"commit_id":"c9dcefd56be0cafbbe0ac9e6ae9a5213aa359eda","original_commit_id":"c9dcefd56be0cafbbe0ac9e6ae9a5213aa359eda","user":{"login":"sergeyklay","id":1256298,"avatar_url":"https://secure.gravatar.com/avatar/58b4ea643d7161296f89910822d6e6a2?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"58b4ea643d7161296f89910822d6e6a2","url":"https://api.github.com/users/sergeyklay","html_url":"https://github.com/sergeyklay","followers_url":"https://api.github.com/users/sergeyklay/followers","following_url":"https://api.github.com/users/sergeyklay/following","gists_url":"https://api.github.com/users/sergeyklay/gists{/gist_id}","starred_url":"https://api.github.com/users/sergeyklay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sergeyklay/subscriptions","organizations_url":"https://api.github.com/users/sergeyklay/orgs","repos_url":"https://api.github.com/users/sergeyklay/repos","events_url":"https://api.github.com/users/sergeyklay/events{/privacy}","received_events_url":"https://api.github.com/users/sergeyklay/received_events","type":"User"},"created_at":"2013-03-30T17:28:36Z","updated_at":"2013-03-30T17:28:36Z","html_url":"https://github.com/gleez/cms/pull/216#discussion_r3595040","pull_request_url":"https://api.github.com/repos/gleez/cms/pulls/216","_links":{"self":{"href":"https://api.github.com/repos/gleez/cms/pulls/comments/3595040"},"html":{"href":"https://github.com/gleez/cms/pull/216#discussion_r3595040"},"pull_request":{"href":"https://api.github.com/repos/gleez/cms/pulls/216"}}}} | {
"id": 2134343,
"name": "cms",
"url": "https://github.com/gleez/cms"
} | {
"id": null,
"login": "sergeyklay",
"gravatar_id": "58b4ea643d7161296f89910822d6e6a2",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "gleez",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-03-30T17:28:36 | null | {"repository":{"description":"GleezCMS - A Light, Simple, Flexible Content Management System based on Kohana Framework","homepage":"www.gleezcms.org","watchers":60,"stargazers":60,"forks":14,"fork":false,"size":736,"owner":"gleez","private":false,"open_issues":18,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"PHP","created_at":"2011-07-31T16:51:02-07:00","pushed_at":"2013-03-30T10:05:07-07:00","master_branch":"master","organization":"gleez"},"actor_attributes":{"type":"User","name":"Sergey Yakovlev","company":"Gleez Technologies","blog":"klay.me","location":"Russia","email":"[email protected]"},"url":"https://github.com/gleez/cms/pull/216#discussion_r3595040"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/graze/graze.github.io/pulls/comments/7963771","id":7963771,"diff_hunk":"@@ -0,0 +1,52 @@\n+---\n+layout: post\n+title: Playing Jenga at recruitment fairs\n+description: And getting the best tech talent to join graze\n+tags: [Team, Recruitment]\n+author:\n+ name: Patrick Troughton\n+ link: https://github.com/chubbytown\n+ email: [email protected]\n+---\n+\n+The graze tech team is growing at a remarkable rate. Our recent launch in the USA, along with our new kids\n+and breakfast boxes mean we have a lot more demands on our time. So we're looking for hot tech talent!\n+\n+graze are investing in the future. We're looking for exceptional technology graduates with a passion for all\n+things tech. We run a code academy and invest in your personal development and training. And as a small company, you get\n+involved in everything. Take a look at our [jobs page](http://graze.com/uk/jobs/tech). Oh, and with free breakfast and\n+Friday beers, you can't go wrong.\n+\n+##We look in universities...##\n+\n+![Graze at Oxford](/images/graze-at-oxford.jpg \"Graze at Oxford\")\n+\n+Our \"lo-fi\" cardboard box stand is often dangerously close to collapse, but we love it. It's been to\n+Oxford, Cambridge and Bristol universities this year.\n+\n+graze is a technology company and that's the message we want to share. Every part of our service is underpinned\n+with world class technology to make it efficient and scalable. To do this we need world class tech talent so we're\n+bringing in some superstars to add to our already superstar-heavy tech team. We met some very smart graduates who we'd","path":"_posts/2013-11-17-playing-jenga.md","position":29,"original_position":29,"commit_id":"135dd478c0971dfa2e7169a3a81b344d9f2da35d","original_commit_id":"135dd478c0971dfa2e7169a3a81b344d9f2da35d","user":{"login":"chubbytown","id":5611706,"avatar_url":"https://0.gravatar.com/avatar/8b2d65dab8addacc7fd4ee814ef246b6?d=https%3A%2F%2Fidenticons.github.com%2F6b2d2cb0354fdda99ec07cc2edc3db1d.png&r=x","gravatar_id":"8b2d65dab8addacc7fd4ee814ef246b6","url":"https://api.github.com/users/chubbytown","html_url":"https://github.com/chubbytown","followers_url":"https://api.github.com/users/chubbytown/followers","following_url":"https://api.github.com/users/chubbytown/following{/other_user}","gists_url":"https://api.github.com/users/chubbytown/gists{/gist_id}","starred_url":"https://api.github.com/users/chubbytown/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chubbytown/subscriptions","organizations_url":"https://api.github.com/users/chubbytown/orgs","repos_url":"https://api.github.com/users/chubbytown/repos","events_url":"https://api.github.com/users/chubbytown/events{/privacy}","received_events_url":"https://api.github.com/users/chubbytown/received_events","type":"User","site_admin":false},"body":"haha! Ok, i'll tame it down. I'm trying to be grazy","created_at":"2013-11-27T17:25:44Z","updated_at":"2013-11-27T17:25:44Z","html_url":"https://github.com/graze/graze.github.io/pull/9#discussion_r7963771","pull_request_url":"https://api.github.com/repos/graze/graze.github.io/pulls/9","_links":{"self":{"href":"https://api.github.com/repos/graze/graze.github.io/pulls/comments/7963771"},"html":{"href":"https://github.com/graze/graze.github.io/pull/9#discussion_r7963771"},"pull_request":{"href":"https://api.github.com/repos/graze/graze.github.io/pulls/9"}}}} | {
"id": 9956492,
"name": "graze.github.io",
"url": "https://github.com/graze/graze.github.io"
} | {
"id": null,
"login": "chubbytown",
"gravatar_id": "8b2d65dab8addacc7fd4ee814ef246b6",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "graze",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-11-27T17:25:44 | null | {"repository":{"description":"Tech blog","homepage":"graze.github.io","watchers":1,"stargazers":1,"forks":0,"fork":false,"size":1358,"owner":"graze","private":false,"open_issues":1,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"CSS","created_at":"2013-05-09T02:42:45-07:00","pushed_at":"2013-11-27T08:50:38-08:00","master_branch":"master","organization":"graze"},"actor_attributes":{"type":"User","name":"Patrick Troughton","blog":"http://www.chubbyfish.co.uk","location":"London","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/graze/graze.github.io/pull/9#discussion_r7963771"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/http2/http2-spec/pulls/comments/4003650","id":4003650,"body":"I don't like this. We are building something where the next layer (your tier 3) has the final say on the semantics of frames and their ordering. This undermines that. There is no need to finagle this with statements like this. The HTTP usage defines the semantics of this frame in a strict set of cases. Where the semantics are undefined, they are undefined.\r\n\r\nThe HTTP usage does need to be clearer in some parts on when different endpoints are able to send what. That's where I'd prefer to see this addressed.","diff_hunk":"@@ -1204,42 +1317,84 @@ Upgrade: HTTP/2.0\n +---------------------------------------------------------------+\n </artwork>\n </figure>\n-\n- <t>\n- There are no frame-specific flags for the PUSH_PROMISE frame.\n- </t>\n-\n+ \n <t>\n- The body of a PUSH_PROMISE includes a \"Promised-Stream-ID\". This 31-bit identifier\n- indicates the stream on which the resource will be pushed. The promised stream\n+ The body of a PUSH_PROMISE includes a \"Promised-Stream-ID\". This \n+ unsigned 31-bit integer indentifies the stream the endpoint \n+ intends to start sending frames for. The promised stream\n identifier MUST be a valid choice for the next stream sent by the sender (see <xref\n target=\"StreamCreation\">new stream identifier</xref>).\n </t>\n \n <t>\n- There is no requirement that the streams referred to by this frame are created in the\n- order referenced. The PUSH_PROMISE only reserves stream identifiers for later use.\n+ PUSH_PROMISE frames are associated with an existing stream. If \n+ the stream identifier field specifies the value 0x0, a recipient\n+ MUST respond with a <xref target=\"SessionErrorHandler\">session \n+ error</xref> of type PROTOCOL_ERROR.\n </t>\n+ \n+ <t>\n+ The state of promised streams is bound to the state of the \n+ original associated stream on which the PUSH_PROMISE frame\n+ were sent. If the originating stream changes to half or\n+ fully closed, all associated promised streams close as well. \n+ More specifically, if the sender of the PUSH_PROMISE half-closes \n+ the original stream, the sender will no longer be permitted to \n+ send frames for any associated promised streams. Accordingly, the \n+ FINAL flag SHOULD NOT be set on a PUSH_PROMISE frame, as doing so \n+ would make it impossible for the sender to use the promised stream.\n+ </t>\n+ \n+ <t>There are no additional type-specific flags defined.</t>\n \n <t>\n- The PUSH_PROMISE also includes a <xref target=\"HeaderBlock\">header block</xref>, which\n- describes the resource that will be pushed.\n+ There is no requirement that promised streams are utilized in the\n+ order promised. The PUSH_PROMISE only reserves stream identifiers \n+ for later use.\n+ </t>\n+ \n+ <t>\n+ Recipients of PUSH_PROMISE frames can choose to reject promised\n+ streams by returning a RST_STREAM referencing the promised stream\n+ identifier back to the sender of the PUSH_PROMISE.\n </t>\n+ \n+ <t>\n+ Note that, currently, the only defined use of PUSH_PROMISE frames\n+ is by a server endpoint to notify a client that it intends to\n+ deliver one or more previously unsolicited streams to the client\n+ as described in <xref target=\"PushResources\">. While use of \n+ PUSH_PROMISE frames by the client is not strictly forbidden by this \n+ specification, such use is considered to be out of the scope of \n+ this specification. Server endpoints that do not wish to allow\n+ the use of PUSH_PROMISE streams by a client can reject promised\n+ streams using RST_STREAM frames with the REFUSED_STREAM or CANCEL\n+ code.\n+ </t>","path":"draft-ietf-httpbis-http2.xml","position":549,"original_position":549,"commit_id":"3cdb535a7b16c2e604cbab6f4b2c8d3a5d509fcc","original_commit_id":"3cdb535a7b16c2e604cbab6f4b2c8d3a5d509fcc","user":{"login":"martinthomson","id":67641,"avatar_url":"https://secure.gravatar.com/avatar/3fa6569f8aa70b9a0a7df4ad7bebc0df?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"3fa6569f8aa70b9a0a7df4ad7bebc0df","url":"https://api.github.com/users/martinthomson","html_url":"https://github.com/martinthomson","followers_url":"https://api.github.com/users/martinthomson/followers","following_url":"https://api.github.com/users/martinthomson/following","gists_url":"https://api.github.com/users/martinthomson/gists{/gist_id}","starred_url":"https://api.github.com/users/martinthomson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinthomson/subscriptions","organizations_url":"https://api.github.com/users/martinthomson/orgs","repos_url":"https://api.github.com/users/martinthomson/repos","events_url":"https://api.github.com/users/martinthomson/events{/privacy}","received_events_url":"https://api.github.com/users/martinthomson/received_events","type":"User"},"created_at":"2013-04-29T17:53:59Z","updated_at":"2013-04-29T17:53:59Z","html_url":"https://github.com/http2/http2-spec/pull/81#discussion_r4003650","pull_request_url":"https://api.github.com/repos/http2/http2-spec/pulls/81","_links":{"self":{"href":"https://api.github.com/repos/http2/http2-spec/pulls/comments/4003650"},"html":{"href":"https://github.com/http2/http2-spec/pull/81#discussion_r4003650"},"pull_request":{"href":"https://api.github.com/repos/http2/http2-spec/pulls/81"}}}} | {
"id": 8062859,
"name": "http2-spec",
"url": "https://github.com/http2/http2-spec"
} | {
"id": null,
"login": "martinthomson",
"gravatar_id": "3fa6569f8aa70b9a0a7df4ad7bebc0df",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "http2",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-04-29T17:53:59 | null | {"repository":{"description":"Working copy of the HTTP/2.0 Specification","homepage":"http://trac.tools.ietf.org/wg/httpbis/trac/wiki","watchers":169,"stargazers":169,"forks":12,"fork":false,"size":664,"owner":"http2","private":false,"open_issues":46,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"XML","created_at":"2013-02-06T15:48:45-08:00","pushed_at":"2013-04-25T12:07:21-07:00","master_branch":"master","organization":"http2"},"actor_attributes":{"type":"User","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/http2/http2-spec/pull/81#discussion_r4003650"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/irstv/orbisgis/pulls/comments/3655814","id":3655814,"body":"Seek the green square you should ! (javadoc please)","diff_hunk":"@@ -0,0 +1,101 @@\n+/**\n+ * OrbisGIS is a GIS application dedicated to scientific spatial simulation.\n+ * This cross-platform GIS is developed at French IRSTV institute and is able to\n+ * manipulate and create vector and raster spatial information.\n+ *\n+ * OrbisGIS is distributed under GPL 3 license. It is produced by the \"Atelier SIG\"\n+ * team of the IRSTV Institute <http://www.irstv.fr/> CNRS FR 2488.\n+ *\n+ * Copyright (C) 2007-2012 IRSTV (FR CNRS 2488)\n+ *\n+ * This file is part of OrbisGIS.\n+ *\n+ * OrbisGIS is free software: you can redistribute it and/or modify it under the\n+ * terms of the GNU General Public License as published by the Free Software\n+ * Foundation, either version 3 of the License, or (at your option) any later\n+ * version.\n+ *\n+ * OrbisGIS is distributed in the hope that it will be useful, but WITHOUT ANY\n+ * WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR\n+ * A PARTICULAR PURPOSE. See the GNU General Public License for more details.\n+ *\n+ * You should have received a copy of the GNU General Public License along with\n+ * OrbisGIS. If not, see <http://www.gnu.org/licenses/>.\n+ *\n+ * For more information, please consult: <http://www.orbisgis.org/>\n+ * or contact directly:\n+ * info_at_ orbisgis.org\n+ */\n+package org.orbisgis.view.toc.actions.cui;\n+\n+import org.orbisgis.view.toc.actions.cui.legend.ILegendPanel;\n+import org.orbisgis.view.toc.actions.cui.legends.PnlRule;\n+import org.orbisgis.view.toc.actions.cui.legends.PnlStyle;\n+import org.orbisgis.view.toc.wrapper.RuleWrapper;\n+import org.orbisgis.view.toc.wrapper.StyleWrapper;\n+\n+import javax.swing.*;\n+import java.awt.*;\n+import java.awt.event.MouseEvent;\n+import java.util.EventObject;\n+\n+/**\n+ * @author alexis\n+ */\n+public class LegendTreeCellEditor extends DefaultCellEditor {\n+ private JTextField field = new JTextField(20);\n+ Object obj;\n+","path":"orbisgis-view/src/main/java/org/orbisgis/view/toc/actions/cui/LegendTreeCellEditor.java","position":48,"original_position":48,"commit_id":"2d4acf8fb1b8813ac3598cb2e40906f58618bd49","original_commit_id":"2d4acf8fb1b8813ac3598cb2e40906f58618bd49","user":{"login":"nicolas-f","id":1382241,"avatar_url":"https://secure.gravatar.com/avatar/fc5d993d1796f944920e3d3db2a1409b?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"fc5d993d1796f944920e3d3db2a1409b","url":"https://api.github.com/users/nicolas-f","html_url":"https://github.com/nicolas-f","followers_url":"https://api.github.com/users/nicolas-f/followers","following_url":"https://api.github.com/users/nicolas-f/following","gists_url":"https://api.github.com/users/nicolas-f/gists{/gist_id}","starred_url":"https://api.github.com/users/nicolas-f/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicolas-f/subscriptions","organizations_url":"https://api.github.com/users/nicolas-f/orgs","repos_url":"https://api.github.com/users/nicolas-f/repos","events_url":"https://api.github.com/users/nicolas-f/events{/privacy}","received_events_url":"https://api.github.com/users/nicolas-f/received_events","type":"User"},"created_at":"2013-04-04T14:20:47Z","updated_at":"2013-04-04T14:20:47Z","html_url":"https://github.com/irstv/orbisgis/pull/372#discussion_r3655814","pull_request_url":"https://api.github.com/repos/irstv/orbisgis/pulls/372","_links":{"self":{"href":"https://api.github.com/repos/irstv/orbisgis/pulls/comments/3655814"},"html":{"href":"https://github.com/irstv/orbisgis/pull/372#discussion_r3655814"},"pull_request":{"href":"https://api.github.com/repos/irstv/orbisgis/pulls/372"}}}} | {
"id": 4735878,
"name": "orbisgis",
"url": "https://github.com/irstv/orbisgis"
} | {
"id": null,
"login": "nicolas-f",
"gravatar_id": "fc5d993d1796f944920e3d3db2a1409b",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "irstv",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-04-04T14:20:47 | null | {"repository":{"description":"A GIS software dedicated to scientific spatial simulation.","homepage":"http://www.orbisgis.org","watchers":8,"stargazers":8,"forks":9,"fork":false,"size":740,"owner":"irstv","private":false,"open_issues":75,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Java","created_at":"2012-06-20T23:59:24-07:00","pushed_at":"2013-04-04T04:59:14-07:00","master_branch":"master","organization":"irstv"},"actor_attributes":{"type":"User","name":"nicolas-f","company":"IRSTV, CNRS","location":"Nantes, France","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/irstv/orbisgis/pull/372#discussion_r3655814"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/mdsol/crichton/pulls/comments/6390206","id":6390206,"body":"This should be in spec/support","diff_hunk":"@@ -0,0 +1,7 @@\n+require 'action_controller'","path":"spec/fixtures/controllers_fixtures.rb","position":1,"original_position":1,"commit_id":"00131ef4a5cd14e400d90efe936412d8a656b260","original_commit_id":"00131ef4a5cd14e400d90efe936412d8a656b260","user":{"login":"fosdev","id":1307116,"avatar_url":"https://0.gravatar.com/avatar/a971447916d8e6d0e234cb0280a452e7?d=https%3A%2F%2Fidenticons.github.com%2F947b50b7bd77dc29b5e4e12e5dfe387c.png","gravatar_id":"a971447916d8e6d0e234cb0280a452e7","url":"https://api.github.com/users/fosdev","html_url":"https://github.com/fosdev","followers_url":"https://api.github.com/users/fosdev/followers","following_url":"https://api.github.com/users/fosdev/following{/other_user}","gists_url":"https://api.github.com/users/fosdev/gists{/gist_id}","starred_url":"https://api.github.com/users/fosdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fosdev/subscriptions","organizations_url":"https://api.github.com/users/fosdev/orgs","repos_url":"https://api.github.com/users/fosdev/repos","events_url":"https://api.github.com/users/fosdev/events{/privacy}","received_events_url":"https://api.github.com/users/fosdev/received_events","type":"User"},"created_at":"2013-09-16T21:32:41Z","updated_at":"2013-09-16T21:32:41Z","html_url":"https://github.com/mdsol/crichton/pull/41#discussion_r6390206","pull_request_url":"https://api.github.com/repos/mdsol/crichton/pulls/41","_links":{"self":{"href":"https://api.github.com/repos/mdsol/crichton/pulls/comments/6390206"},"html":{"href":"https://github.com/mdsol/crichton/pull/41#discussion_r6390206"},"pull_request":{"href":"https://api.github.com/repos/mdsol/crichton/pulls/41"}}}} | {
"id": 8062132,
"name": "crichton",
"url": "https://github.com/mdsol/crichton"
} | {
"id": null,
"login": "fosdev",
"gravatar_id": "a971447916d8e6d0e234cb0280a452e7",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "mdsol",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-09-16T21:32:41 | null | {"repository":{"description":"","watchers":0,"stargazers":0,"forks":0,"fork":false,"size":1490,"owner":"mdsol","private":false,"open_issues":3,"has_issues":false,"has_downloads":true,"has_wiki":false,"language":"Ruby","created_at":"2013-02-06T14:58:32-08:00","pushed_at":"2013-09-16T08:55:18-07:00","master_branch":"develop","organization":"mdsol"},"actor_attributes":{"type":"User","name":"Mark W. Foster","company":"Medidata Solutions Worldwide","blog":"www.mdsol.com","location":"Ross, CA","email":"[email protected]"},"url":"https://github.com/mdsol/crichton/pull/41#discussion_r6390206"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/mesos/spark/pulls/comments/5994301","id":5994301,"body":"There should be an extra space next to this minus sign.","diff_hunk":"@@ -165,14 +167,61 @@ def distinct(self):\n .reduceByKey(lambda x, _: x) \\\n .map(lambda (x, _): x)\n \n- # TODO: sampling needs to be re-implemented due to Batch\n- #def sample(self, withReplacement, fraction, seed):\n- # jrdd = self._jrdd.sample(withReplacement, fraction, seed)\n- # return RDD(jrdd, self.ctx)\n+ # sampling prototype: relies on NumPy for random numbers\n+ def sample(self, withReplacement, fraction, seed):\n+ \"\"\"\n+ Return a sampled subset of this RDD (currently requires numpy).\n+\n+ >>> sc.parallelize(range(0, 100)).sample(False, 0.1, 2).collect()\n+ [2, 3, 20, 21, 24, 41, 42, 66, 67, 89, 90, 98]\n+ \"\"\"\n+ return self.mapPartitionsWithSplit(RDDSampler(withReplacement, fraction, seed).func, True)\n+\n+ # this is ported from scala/spark/RDD.scala\n+ def takeSample(self, withReplacement, num, seed):\n+ \"\"\"\n+ Return a fixed-size sampled subset of this RDD (currently requires numpy).\n+\n+ >>> sc.parallelize(range(0, 10)).takeSample(True, 10, 1)\n+ [4, 2, 1, 8, 2, 7, 0, 4, 1, 4]\n+ \"\"\"\n \n- #def takeSample(self, withReplacement, num, seed):\n- # vals = self._jrdd.takeSample(withReplacement, num, seed)\n- # return [load_pickle(bytes(x)) for x in vals]\n+ fraction = 0.0\n+ total = 0\n+ multiplier = 3.0\n+ # TODO: it seems expensive to start a job just to initialize this variable but it may\n+ # not be possible to avoid it (Spark does the same)\n+ initialCount = self.count()\n+ maxSelected = 0\n+\n+ if (num < 0):\n+ raise Exception(\"Negative number of elements requested\")\n+\n+ if initialCount > sys.maxint - 1:\n+ maxSelected = sys.maxint - 1\n+ else:\n+ maxSelected = initialCount\n+\n+ if num > initialCount and not withReplacement:\n+ total = maxSelected\n+ fraction = multiplier * (maxSelected + 1) / initialCount\n+ else:\n+ fraction = multiplier * (num + 1) / initialCount\n+ total = num\n+\n+ samples = self.sample(withReplacement, fraction, seed).collect()\n+ \n+ # If the first sample didn't turn out large enough, keep trying to take samples;\n+ # this shouldn't happen often because we use a big multiplier for their initial size\n+ while len(samples) < total:\n+ if seed > sys.maxint -2:","path":"python/pyspark/rdd.py","position":74,"original_position":74,"commit_id":"72bc53c214988a817b2dd139df78320d192213d6","original_commit_id":"72bc53c214988a817b2dd139df78320d192213d6","user":{"login":"JoshRosen","id":50748,"avatar_url":"https://2.gravatar.com/avatar/784145e31736d98de13959d0ffe3cde6?d=https%3A%2F%2Fidenticons.github.com%2F7df099a6eeb2b574a12d5d52b843ad1c.png","gravatar_id":"784145e31736d98de13959d0ffe3cde6","url":"https://api.github.com/users/JoshRosen","html_url":"https://github.com/JoshRosen","followers_url":"https://api.github.com/users/JoshRosen/followers","following_url":"https://api.github.com/users/JoshRosen/following{/other_user}","gists_url":"https://api.github.com/users/JoshRosen/gists{/gist_id}","starred_url":"https://api.github.com/users/JoshRosen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JoshRosen/subscriptions","organizations_url":"https://api.github.com/users/JoshRosen/orgs","repos_url":"https://api.github.com/users/JoshRosen/repos","events_url":"https://api.github.com/users/JoshRosen/events{/privacy}","received_events_url":"https://api.github.com/users/JoshRosen/received_events","type":"User"},"created_at":"2013-08-27T00:17:37Z","updated_at":"2013-08-27T00:17:37Z","html_url":"https://github.com/mesos/spark/pull/861#discussion_r5994301","pull_request_url":"https://api.github.com/repos/mesos/spark/pulls/861","_links":{"self":{"href":"https://api.github.com/repos/mesos/spark/pulls/comments/5994301"},"html":{"href":"https://github.com/mesos/spark/pull/861#discussion_r5994301"},"pull_request":{"href":"https://api.github.com/repos/mesos/spark/pulls/861"}}}} | {
"id": 585719,
"name": "spark",
"url": "https://github.com/mesos/spark"
} | {
"id": null,
"login": "JoshRosen",
"gravatar_id": "784145e31736d98de13959d0ffe3cde6",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "mesos",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-08-27T00:17:37 | null | {"repository":{"description":"Lightning-fast cluster computing in Java, Scala and Python.","homepage":"www.spark-project.org","watchers":1247,"stargazers":1247,"forks":352,"fork":false,"size":61609,"owner":"mesos","private":false,"open_issues":32,"has_issues":false,"has_downloads":true,"has_wiki":true,"language":"Scala","created_at":"2010-03-29T15:59:04-07:00","pushed_at":"2013-08-26T11:59:34-07:00","integrate_branch":"master","master_branch":"master","organization":"mesos"},"actor_attributes":{"type":"User","name":"Josh Rosen","company":"","blog":"http://www.cs.berkeley.edu/~joshrosen/","location":"Berkeley, CA","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/mesos/spark/pull/861#discussion_r5994301"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/mesos/spark/pulls/comments/6101322","id":6101322,"body":"It looks like it implies it: http://lwn.net/Articles/245002/","diff_hunk":"@@ -0,0 +1,70 @@\n+---\n+layout: global\n+title: Hardware Provisioning\n+---\n+\n+A common question received by Spark developers is how to configure hardware for it. While the right\n+hardware will depend on the situation, we make the following recommendations.\n+\n+# Storage Systems\n+\n+Because most Spark jobs will likely have to read input data from an external storage system (e.g.\n+the Hadoop File System, or HBase), it is important to place it **as close to this system as\n+possible**. We recommend the following:\n+\n+* If at all possible, run Spark on the same nodes as HDFS. The simplest way is to set up a Spark\n+[standalone mode cluster](spark-standalone.html) on the same nodes, and configure Spark and\n+Hadoop's memory and CPU usage to avoid interference (for Hadoop, the relevant options are\n+`mapred.child.java.opts` for the per-task memory and `mapred.tasktracker.map.tasks.maximum`\n+and `mapred.tasktracker.reduce.tasks.maximum` for number of tasks). Alternatively, you can run\n+Hadoop and Spark on a common cluster manager like [Mesos](running-on-mesos.html) or\n+[Hadoop YARN](running-on-yarn.html).\n+\n+* If this is not possible, run Spark on different nodes in the same local-area network as HDFS.\n+If your cluster spans multiple racks, include some Spark nodes on each rack.\n+\n+* For low-latency data stores like HBase, it may be preferrable to run computing jobs on different\n+nodes than the storage system to avoid interference.\n+\n+# Local Disks\n+\n+While Spark can perform a lot of its computation in memory, it still uses local disks to store\n+data that doesn't fit in RAM, as well as to preserve intermediate output between stages. We\n+recommend having **4-8 disks** per node, configured _without_ RAID (just as separate mount points).\n+In Linux, mount the disks with the [`noatime` option](http://www.centos.org/docs/5/html/Global_File_System/s2-manage-mountnoatime.html)","path":"docs/hardware-provisioning.md","position":34,"original_position":34,"commit_id":"4819baa658a6c8a3e4c5c504af284ea6091e4c35","original_commit_id":"4819baa658a6c8a3e4c5c504af284ea6091e4c35","user":{"login":"mateiz","id":228859,"avatar_url":"https://1.gravatar.com/avatar/17d3d634fc898bf3ae19444450af6805?d=https%3A%2F%2Fidenticons.github.com%2F627fcfc1b5e8e4535cc26ecfa133743e.png","gravatar_id":"17d3d634fc898bf3ae19444450af6805","url":"https://api.github.com/users/mateiz","html_url":"https://github.com/mateiz","followers_url":"https://api.github.com/users/mateiz/followers","following_url":"https://api.github.com/users/mateiz/following{/other_user}","gists_url":"https://api.github.com/users/mateiz/gists{/gist_id}","starred_url":"https://api.github.com/users/mateiz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mateiz/subscriptions","organizations_url":"https://api.github.com/users/mateiz/orgs","repos_url":"https://api.github.com/users/mateiz/repos","events_url":"https://api.github.com/users/mateiz/events{/privacy}","received_events_url":"https://api.github.com/users/mateiz/received_events","type":"User"},"created_at":"2013-09-01T00:39:27Z","updated_at":"2013-09-01T00:39:27Z","html_url":"https://github.com/mesos/spark/pull/877#discussion_r6101322","pull_request_url":"https://api.github.com/repos/mesos/spark/pulls/877","_links":{"self":{"href":"https://api.github.com/repos/mesos/spark/pulls/comments/6101322"},"html":{"href":"https://github.com/mesos/spark/pull/877#discussion_r6101322"},"pull_request":{"href":"https://api.github.com/repos/mesos/spark/pulls/877"}}}} | {
"id": 585719,
"name": "spark",
"url": "https://github.com/mesos/spark"
} | {
"id": null,
"login": "mateiz",
"gravatar_id": "17d3d634fc898bf3ae19444450af6805",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "mesos",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-09-01T00:39:27 | null | {"repository":{"description":"Lightning-fast cluster computing in Java, Scala and Python.","homepage":"www.spark-project.org","watchers":1260,"stargazers":1260,"forks":358,"fork":false,"size":9616,"owner":"mesos","private":false,"open_issues":31,"has_issues":false,"has_downloads":true,"has_wiki":true,"language":"Scala","created_at":"2010-03-29T15:59:04-07:00","pushed_at":"2013-08-31T13:39:24-07:00","integrate_branch":"master","master_branch":"master","organization":"mesos"},"actor_attributes":{"type":"User","name":"Matei Zaharia","company":"UC Berkeley","blog":"www.cs.berkeley.edu/~matei","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/mesos/spark/pull/877#discussion_r6101322"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/neo4j/neo4j/pulls/comments/7303323","id":7303323,"diff_hunk":"@@ -19,6 +19,10 @@\n */\n package org.neo4j.kernel.api.scan;\n \n+import java.io.IOException;\n+\n public interface NodeRangeReader extends Iterable<NodeLabelRange>, AutoCloseable\n {\n+ @Override\n+ public void close() throws IOException;","path":"community/kernel/src/main/java/org/neo4j/kernel/api/scan/NodeRangeReader.java","position":9,"original_position":9,"commit_id":"d9ccc0dfb2c6dc951fa8687defdfcaecaacc1fd6","original_commit_id":"d9ccc0dfb2c6dc951fa8687defdfcaecaacc1fd6","user":{"login":"thobe","id":104385,"avatar_url":"https://2.gravatar.com/avatar/c3473bb95f28310df05f5e7374d9cb44?d=https%3A%2F%2Fidenticons.github.com%2F302e8a2ea782de9699c06280e709cd15.png&r=x","gravatar_id":"c3473bb95f28310df05f5e7374d9cb44","url":"https://api.github.com/users/thobe","html_url":"https://github.com/thobe","followers_url":"https://api.github.com/users/thobe/followers","following_url":"https://api.github.com/users/thobe/following{/other_user}","gists_url":"https://api.github.com/users/thobe/gists{/gist_id}","starred_url":"https://api.github.com/users/thobe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thobe/subscriptions","organizations_url":"https://api.github.com/users/thobe/orgs","repos_url":"https://api.github.com/users/thobe/repos","events_url":"https://api.github.com/users/thobe/events{/privacy}","received_events_url":"https://api.github.com/users/thobe/received_events","type":"User","site_admin":false},"body":"`java.io.Closeable` has this signature, why not just extend that interface instead of `java.lang.AutoCloseable`?\r\n(`java.io.Closeable` extends `java.lang.AutoCloseable`)","created_at":"2013-10-30T06:00:11Z","updated_at":"2013-10-30T06:00:11Z","html_url":"https://github.com/neo4j/neo4j/pull/1380#discussion_r7303323","pull_request_url":"https://api.github.com/repos/neo4j/neo4j/pulls/1380","_links":{"self":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/comments/7303323"},"html":{"href":"https://github.com/neo4j/neo4j/pull/1380#discussion_r7303323"},"pull_request":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/1380"}}}} | {
"id": 6650539,
"name": "neo4j",
"url": "https://github.com/neo4j/neo4j"
} | {
"id": null,
"login": "thobe",
"gravatar_id": "c3473bb95f28310df05f5e7374d9cb44",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "neo4j",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-10-30T06:00:11 | null | {"repository":{"description":"The World's Leading Graph Database","homepage":"http://neo4j.org","watchers":440,"stargazers":440,"forks":232,"fork":false,"size":229797,"owner":"neo4j","private":false,"open_issues":3,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Java","created_at":"2012-11-12T00:46:15-08:00","pushed_at":"2013-10-29T21:15:11-07:00","master_branch":"master","organization":"neo4j"},"actor_attributes":{"type":"User","name":"Tobias Lindaaker","company":"Neo Technology","blog":"http://journal.thobe.org","location":"","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/neo4j/neo4j/pull/1380#discussion_r7303323"} |
PullRequestReviewCommentEvent | true | {"comment":{"body":"done","position":17,"_links":{"self":{"href":"https://api.github.com/repos/netty/netty/pulls/comments/2547987"},"pull_request":{"href":"https://api.github.com/repos/netty/netty/pulls/867"},"html":{"href":"https://github.com/netty/netty/pull/867#discussion_r2547987"}},"created_at":"2013-01-04T08:00:10Z","commit_id":"84a8dd1000d3236b2964a8b6c1b479ede5062214","user":{"avatar_url":"https://secure.gravatar.com/avatar/b3ee4480d783c6d5e6e711fd03425ac6?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gists_url":"https://api.github.com/users/carrot-garden/gists{/gist_id}","received_events_url":"https://api.github.com/users/carrot-garden/received_events","organizations_url":"https://api.github.com/users/carrot-garden/orgs","followers_url":"https://api.github.com/users/carrot-garden/followers","repos_url":"https://api.github.com/users/carrot-garden/repos","gravatar_id":"b3ee4480d783c6d5e6e711fd03425ac6","url":"https://api.github.com/users/carrot-garden","starred_url":"https://api.github.com/users/carrot-garden/starred{/owner}{/repo}","following_url":"https://api.github.com/users/carrot-garden/following","type":"User","id":755059,"events_url":"https://api.github.com/users/carrot-garden/events{/privacy}","subscriptions_url":"https://api.github.com/users/carrot-garden/subscriptions","login":"carrot-garden"},"url":"https://api.github.com/repos/netty/netty/pulls/comments/2547987","path":"transport-udt/src/main/java/io/netty/transport/udt/oio/package-info.java","id":2547987,"original_position":17,"original_commit_id":"84a8dd1000d3236b2964a8b6c1b479ede5062214","updated_at":"2013-01-04T08:00:10Z"}} | {
"id": 1064563,
"name": "netty",
"url": "https://github.com/netty/netty"
} | {
"id": null,
"login": "carrot-garden",
"gravatar_id": "b3ee4480d783c6d5e6e711fd03425ac6",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "netty",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-01-04T08:00:10 | null | {"repository":{"owner":"netty","created_at":"2010-11-09T01:22:21-08:00","homepage":"http://netty.io/","integrate_branch":"master","open_issues":70,"pushed_at":"2013-01-03T22:06:03-08:00","description":"Netty project - an event-driven asynchronous network application framework","forks":319,"has_downloads":true,"organization":"netty","watchers":1259,"fork":false,"size":6780,"has_issues":true,"stargazers":1259,"language":"Java","private":false,"has_wiki":false},"actor_attributes":{"company":"CarrotGarden","location":"Planet Earth","name":"Andrei Pozolotin","blog":"http://carrot-garden.github.com/","type":"User","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/netty/netty/pull/867#discussion_r2547987"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/numpy/numpy/pulls/comments/5069435","id":5069435,"body":"Looking through this function, it looks like the fast path should work even for multi-dimensional arrays when `newtype == NULL && flags == 0)`. Could you also check to verify that that is correct?","diff_hunk":"@@ -1798,6 +1798,14 @@\n \n oldtype = PyArray_DESCR(arr);\n if (newtype == NULL) {\n+ /* \n+ * Check if object is of array dimension zero with Null newtype. \n+ * If so return it directly instead of calling PyArray_FromAny.\n+ */\n+ if (PyArray_NDIM(arr) == 0 && flags == 0) {","path":"numpy/core/src/multiarray/ctors.c","position":8,"original_position":8,"commit_id":"9b3e719b8ab153335bcc9064cf186c823367bdbe","original_commit_id":"9b3e719b8ab153335bcc9064cf186c823367bdbe","user":{"login":"charris","id":77272,"avatar_url":"https://secure.gravatar.com/avatar/96dd777e397ab128fedab46af97a3a4a?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"96dd777e397ab128fedab46af97a3a4a","url":"https://api.github.com/users/charris","html_url":"https://github.com/charris","followers_url":"https://api.github.com/users/charris/followers","following_url":"https://api.github.com/users/charris/following{/other_user}","gists_url":"https://api.github.com/users/charris/gists{/gist_id}","starred_url":"https://api.github.com/users/charris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/charris/subscriptions","organizations_url":"https://api.github.com/users/charris/orgs","repos_url":"https://api.github.com/users/charris/repos","events_url":"https://api.github.com/users/charris/events{/privacy}","received_events_url":"https://api.github.com/users/charris/received_events","type":"User"},"created_at":"2013-07-08T16:50:52Z","updated_at":"2013-07-08T16:50:52Z","html_url":"https://github.com/numpy/numpy/pull/3509#discussion_r5069435","pull_request_url":"https://api.github.com/repos/numpy/numpy/pulls/3509","_links":{"self":{"href":"https://api.github.com/repos/numpy/numpy/pulls/comments/5069435"},"html":{"href":"https://github.com/numpy/numpy/pull/3509#discussion_r5069435"},"pull_request":{"href":"https://api.github.com/repos/numpy/numpy/pulls/3509"}}}} | {
"id": 908607,
"name": "numpy",
"url": "https://github.com/numpy/numpy"
} | {
"id": null,
"login": "charris",
"gravatar_id": "96dd777e397ab128fedab46af97a3a4a",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "numpy",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-07-08T16:50:52 | null | {"repository":{"description":"Numpy main repository","homepage":"http://www.numpy.org/","watchers":881,"stargazers":881,"forks":370,"fork":false,"size":8400,"owner":"numpy","private":false,"open_issues":6,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"C","created_at":"2010-09-13T16:02:39-07:00","pushed_at":"2013-07-08T09:16:56-07:00","master_branch":"master","organization":"numpy"},"actor_attributes":{"type":"User","name":"Charles Harris","company":"Space Dynamics Laboratory","location":"Logan, Utah; USA","email":"[email protected]"},"url":"https://github.com/numpy/numpy/pull/3509#discussion_r5069435"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/numpy/numpy/pulls/comments/3813040","id":3813040,"body":"PyArray_IntpFromSequence itself isn't exposed in the public API, so\r\nchanging its signature per se shouldn't affect compatibility. (Propagating\r\nthat change out through callers might I guess... we'll have to see.)\r\n\r\n\r\nOn Tue, Apr 16, 2013 at 3:27 PM, seberg <[email protected]> wrote:\r\n\r\n> In numpy/core/src/multiarray/conversion_utils.c:\r\n>\r\n> > @@ -117,7 +118,7 @@\r\n> > }\r\n> > }\r\n> > seq->len = len;\r\n> > - nd = PyArray_IntpFromSequence(obj, (npy_intp *)seq->ptr, len);\r\n> > + nd = PyArray_IntpFromSequence(obj, (npy_intp *)seq->ptr, (int) len);\r\n>\r\n> The point of the change is to be able to avoid those errors for large\r\n> python sequences... If we can change PyArray_IntpFromSequence to use\r\n> npy_intp or maybe Py_ssize_t (I guess they are the same anyway?), without\r\n> breaking binary compatibility, that wouldn't seem bad to me, even if we\r\n> probably never use it like that.\r\n>\r\n> —\r\n> Reply to this email directly or view it on GitHub<https://github.com/numpy/numpy/pull/3243/files#r3812732>\r\n> .\r\n>","diff_hunk":"@@ -117,7 +118,7 @@\n }\n }\n seq->len = len;\n- nd = PyArray_IntpFromSequence(obj, (npy_intp *)seq->ptr, len);\n+ nd = PyArray_IntpFromSequence(obj, (npy_intp *)seq->ptr, (int) len);","path":"numpy/core/src/multiarray/conversion_utils.c","position":32,"original_position":32,"commit_id":"7fa1faf8f63420ebc62c52b5d29a675f33b57261","original_commit_id":"7fa1faf8f63420ebc62c52b5d29a675f33b57261","user":{"login":"njsmith","id":609896,"avatar_url":"https://secure.gravatar.com/avatar/97c543aca1ac7bbcfb5279d0300c8330?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"97c543aca1ac7bbcfb5279d0300c8330","url":"https://api.github.com/users/njsmith","html_url":"https://github.com/njsmith","followers_url":"https://api.github.com/users/njsmith/followers","following_url":"https://api.github.com/users/njsmith/following","gists_url":"https://api.github.com/users/njsmith/gists{/gist_id}","starred_url":"https://api.github.com/users/njsmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/njsmith/subscriptions","organizations_url":"https://api.github.com/users/njsmith/orgs","repos_url":"https://api.github.com/users/njsmith/repos","events_url":"https://api.github.com/users/njsmith/events{/privacy}","received_events_url":"https://api.github.com/users/njsmith/received_events","type":"User"},"created_at":"2013-04-16T14:42:14Z","updated_at":"2013-04-16T14:42:14Z","html_url":"https://github.com/numpy/numpy/pull/3243#discussion_r3813040","pull_request_url":"https://api.github.com/repos/numpy/numpy/pulls/3243","_links":{"self":{"href":"https://api.github.com/repos/numpy/numpy/pulls/comments/3813040"},"html":{"href":"https://github.com/numpy/numpy/pull/3243#discussion_r3813040"},"pull_request":{"href":"https://api.github.com/repos/numpy/numpy/pulls/3243"}}}} | {
"id": 908607,
"name": "numpy",
"url": "https://github.com/numpy/numpy"
} | {
"id": null,
"login": "njsmith",
"gravatar_id": "97c543aca1ac7bbcfb5279d0300c8330",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "numpy",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-04-16T14:42:14 | null | {"repository":{"description":"Numpy main repository","homepage":"http://www.numpy.org/","watchers":797,"stargazers":797,"forks":298,"fork":false,"size":6980,"owner":"numpy","private":false,"open_issues":1,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"C","created_at":"2010-09-13T16:02:39-07:00","pushed_at":"2013-04-15T09:17:31-07:00","master_branch":"master","organization":"numpy"},"actor_attributes":{"type":"User","email":"[email protected]"},"url":"https://github.com/numpy/numpy/pull/3243#discussion_r3813040"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/obiba/opal/pulls/comments/7466413","id":7466413,"diff_hunk":"@@ -95,7 +112,8 @@ public Response saveVocabulary(Opal.VocabularyDto dto) {\n \n Vocabulary vocabulary = taxonomyService.getVocabulary(taxonomyName, vocabularyName);\n //TODO use right template","path":"opal-core-ws/src/main/java/org/obiba/opal/web/system/VocabularyResource.java","position":34,"original_position":34,"commit_id":"425b5cecab9642ece6c2bda6ff893dcd80699f6e","original_commit_id":"425b5cecab9642ece6c2bda6ff893dcd80699f6e","user":{"login":"cthiebault","id":1970634,"avatar_url":"https://2.gravatar.com/avatar/a6ca4ecc9674edb671888325e7f5efa9?d=https%3A%2F%2Fidenticons.github.com%2Fb59be8a6e540201c9b7c25a047d82f24.png&r=x","gravatar_id":"a6ca4ecc9674edb671888325e7f5efa9","url":"https://api.github.com/users/cthiebault","html_url":"https://github.com/cthiebault","followers_url":"https://api.github.com/users/cthiebault/followers","following_url":"https://api.github.com/users/cthiebault/following{/other_user}","gists_url":"https://api.github.com/users/cthiebault/gists{/gist_id}","starred_url":"https://api.github.com/users/cthiebault/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cthiebault/subscriptions","organizations_url":"https://api.github.com/users/cthiebault/orgs","repos_url":"https://api.github.com/users/cthiebault/repos","events_url":"https://api.github.com/users/cthiebault/events{/privacy}","received_events_url":"https://api.github.com/users/cthiebault/received_events","type":"User","site_admin":false},"body":"rmove todo","created_at":"2013-11-06T15:26:59Z","updated_at":"2013-11-06T15:26:59Z","html_url":"https://github.com/obiba/opal/pull/299#discussion_r7466413","pull_request_url":"https://api.github.com/repos/obiba/opal/pulls/299","_links":{"self":{"href":"https://api.github.com/repos/obiba/opal/pulls/comments/7466413"},"html":{"href":"https://github.com/obiba/opal/pull/299#discussion_r7466413"},"pull_request":{"href":"https://api.github.com/repos/obiba/opal/pulls/299"}}}} | {
"id": 6372312,
"name": "opal",
"url": "https://github.com/obiba/opal"
} | {
"id": null,
"login": "cthiebault",
"gravatar_id": "a6ca4ecc9674edb671888325e7f5efa9",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "obiba",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-11-06T15:26:59 | null | {"repository":{"description":"OBiBa’s core database application for biobanks or epidemiological studies. ","homepage":"http://www.obiba.org/node/63","watchers":2,"stargazers":2,"forks":4,"fork":false,"size":170736,"owner":"obiba","private":false,"open_issues":1,"has_issues":false,"has_downloads":true,"has_wiki":false,"language":"JavaScript","created_at":"2012-10-24T08:35:10-07:00","pushed_at":"2013-11-06T07:10:35-08:00","master_branch":"master","organization":"obiba"},"actor_attributes":{"type":"User","name":"Cedric Thiebault","company":"Maelstrom Research / Obiba / P3G","blog":"http://cthiebault.github.io","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/obiba/opal/pull/299#discussion_r7466413"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/ooici/coverage-model/pulls/comments/3230233","id":3230233,"body":"Nope, shouldn't be an issue. They're assigned None, so if both None, pass, only one None, fail...","diff_hunk":"@@ -153,6 +153,12 @@ def _fromdict(cls, cmdict, arg_masks=None):\n ret = super(PythonFunction, cls)._fromdict(cmdict, arg_masks=arg_masks)\n return ret\n \n+ def __eq__(self, other):\n+ ret = False\n+ if super(PythonFunction, self).__eq__(other):\n+ ret = self.owner == other.owner and self.func_name == other.func_name","path":"coverage_model/parameter_functions.py","position":7,"original_position":7,"commit_id":"7670688bf7486ecebc530af27a399a0cbc1e90fa","original_commit_id":"7670688bf7486ecebc530af27a399a0cbc1e90fa","user":{"login":"blazetopher","id":302073,"avatar_url":"https://secure.gravatar.com/avatar/73ddf8f8382d707dc62b153e3b9e23a6?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"73ddf8f8382d707dc62b153e3b9e23a6","url":"https://api.github.com/users/blazetopher","html_url":"https://github.com/blazetopher","followers_url":"https://api.github.com/users/blazetopher/followers","following_url":"https://api.github.com/users/blazetopher/following","gists_url":"https://api.github.com/users/blazetopher/gists{/gist_id}","starred_url":"https://api.github.com/users/blazetopher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blazetopher/subscriptions","organizations_url":"https://api.github.com/users/blazetopher/orgs","repos_url":"https://api.github.com/users/blazetopher/repos","events_url":"https://api.github.com/users/blazetopher/events{/privacy}","received_events_url":"https://api.github.com/users/blazetopher/received_events","type":"User"},"created_at":"2013-03-04T19:17:46Z","updated_at":"2013-03-04T19:17:46Z","_links":{"self":{"href":"https://api.github.com/repos/ooici/coverage-model/pulls/comments/3230233"},"html":{"href":"https://github.com/ooici/coverage-model/pull/35#discussion_r3230233"},"pull_request":{"href":"https://api.github.com/repos/ooici/coverage-model/pulls/35"}}}} | {
"id": 4993236,
"name": "coverage-model",
"url": "https://github.com/ooici/coverage-model"
} | {
"id": null,
"login": "blazetopher",
"gravatar_id": "73ddf8f8382d707dc62b153e3b9e23a6",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "ooici",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-03-04T19:17:46 | null | {"repository":{"description":"","watchers":2,"stargazers":2,"forks":5,"fork":false,"size":284,"owner":"ooici","private":false,"open_issues":0,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Python","created_at":"2012-07-11T11:31:18-07:00","pushed_at":"2013-03-04T11:17:28-08:00","master_branch":"master","organization":"ooici"},"actor_attributes":{"type":"User","name":"Christopher Mueller","company":"RPS ASA","location":"South Kingstown, RI","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/ooici/coverage-model/pull/35#discussion_r3230233"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/ox-it/wl-course-signup/pulls/comments/4588557","id":4588557,"body":"How about adding a message to the exception saying that no query was supplied?","diff_hunk":"@@ -185,6 +190,23 @@ public Response setCourses(@QueryParam(\"terms\") String terms) throws JsonGenerat\n \t\treturn Response.ok(objectMapper.typedWriter(TypeFactory.collectionType(List.class, CourseGroup.class)).writeValueAsString(groups)).build();\n \t}\n \t\n+\t@Path(\"/solr/{command}\")\n+\t@GET\n+\t@Produces(MediaType.APPLICATION_JSON)\n+\tpublic StreamingOutput setSolr(@PathParam(\"command\") final String command, @Context UriInfo uriInfo) \n+\t\t\tthrows JsonGenerationException, JsonMappingException, IOException {\n+\t\t\n+\t\tif (!\"select\".equals(command)) {\n+\t\t\tthrow new WebApplicationException();\n+\t\t}\n+\t\tString query = uriInfo.getRequestUri().getRawQuery();\n+\t\tif (null == query) {\n+\t\t\tthrow new WebApplicationException();","path":"tool/src/main/java/uk/ac/ox/oucs/vle/CourseResource.java","position":48,"original_position":48,"commit_id":"d904638308f72ba31092e92f546b2e30038393f6","original_commit_id":"d904638308f72ba31092e92f546b2e30038393f6","user":{"login":"buckett","id":5921,"avatar_url":"https://secure.gravatar.com/avatar/1864a3ae539447512aeaf1cc478bb940?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"1864a3ae539447512aeaf1cc478bb940","url":"https://api.github.com/users/buckett","html_url":"https://github.com/buckett","followers_url":"https://api.github.com/users/buckett/followers","following_url":"https://api.github.com/users/buckett/following{/other_user}","gists_url":"https://api.github.com/users/buckett/gists{/gist_id}","starred_url":"https://api.github.com/users/buckett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/buckett/subscriptions","organizations_url":"https://api.github.com/users/buckett/orgs","repos_url":"https://api.github.com/users/buckett/repos","events_url":"https://api.github.com/users/buckett/events{/privacy}","received_events_url":"https://api.github.com/users/buckett/received_events","type":"User"},"created_at":"2013-06-07T13:52:44Z","updated_at":"2013-06-07T13:52:44Z","html_url":"https://github.com/ox-it/wl-course-signup/pull/81#discussion_r4588557","pull_request_url":"https://api.github.com/repos/ox-it/wl-course-signup/pulls/81","_links":{"self":{"href":"https://api.github.com/repos/ox-it/wl-course-signup/pulls/comments/4588557"},"html":{"href":"https://github.com/ox-it/wl-course-signup/pull/81#discussion_r4588557"},"pull_request":{"href":"https://api.github.com/repos/ox-it/wl-course-signup/pulls/81"}}}} | {
"id": 6059272,
"name": "wl-course-signup",
"url": "https://github.com/ox-it/wl-course-signup"
} | {
"id": null,
"login": "buckett",
"gravatar_id": "1864a3ae539447512aeaf1cc478bb940",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "ox-it",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-06-07T13:52:44 | null | {"repository":{"watchers":0,"stargazers":0,"forks":1,"fork":false,"size":660,"owner":"ox-it","private":false,"open_issues":8,"has_issues":false,"has_downloads":false,"has_wiki":false,"language":"JavaScript","created_at":"2012-10-03T04:47:33-07:00","pushed_at":"2013-06-07T03:33:57-07:00","master_branch":"master","organization":"ox-it"},"actor_attributes":{"type":"User","name":"Matthew Buckett","company":"University of Oxford","blog":"http://thicksliced.blogspot.com","location":"UK","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/ox-it/wl-course-signup/pull/81#discussion_r4588557"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/phpbb/phpbb3/pulls/comments/5053066","id":5053066,"body":"self::","diff_hunk":"@@ -0,0 +1,139 @@\n+<?php\n+/**\n+ *\n+ * @package testing\n+ * @copyright (c) 2013 phpBB Group\n+ * @license http://opensource.org/licenses/gpl-2.0.php GNU General Public License v2\n+ *\n+ */\n+\n+/**\n+ * @group functional\n+ */\n+class phpbb_functional_avatar_acp_test extends phpbb_functional_test_case\n+{\n+\tprivate $path;\n+\tprivate $form_content;\n+\n+\tpublic function setUp()\n+\t{\n+\t\tparent::setUp();\n+\t\t$this->path = __DIR__ . '/fixtures/files/';\n+\t\t$this->login();\n+\t\t$this->admin_login();\n+\t\t$this->add_lang(array('acp/board', 'ucp', 'acp/users', 'acp/groups'));\n+\t}\n+\n+\tpublic function test_acp_settings()\n+\t{\n+\t\t$crawler = $this->request('GET', 'adm/index.php?i=acp_board&mode=avatar&sid=' . $this->sid);","path":"tests/functional/avatar_acp_test.php","position":29,"original_position":29,"commit_id":"79dd44061bbfeab64dd2ff7b40541612c219c33c","original_commit_id":"79dd44061bbfeab64dd2ff7b40541612c219c33c","user":{"login":"dhruvgoel92","id":1470188,"avatar_url":"https://secure.gravatar.com/avatar/4fe5d0bdbba1174ffdc1aa46b5c81a0e?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"4fe5d0bdbba1174ffdc1aa46b5c81a0e","url":"https://api.github.com/users/dhruvgoel92","html_url":"https://github.com/dhruvgoel92","followers_url":"https://api.github.com/users/dhruvgoel92/followers","following_url":"https://api.github.com/users/dhruvgoel92/following{/other_user}","gists_url":"https://api.github.com/users/dhruvgoel92/gists{/gist_id}","starred_url":"https://api.github.com/users/dhruvgoel92/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhruvgoel92/subscriptions","organizations_url":"https://api.github.com/users/dhruvgoel92/orgs","repos_url":"https://api.github.com/users/dhruvgoel92/repos","events_url":"https://api.github.com/users/dhruvgoel92/events{/privacy}","received_events_url":"https://api.github.com/users/dhruvgoel92/received_events","type":"User"},"created_at":"2013-07-06T17:11:57Z","updated_at":"2013-07-06T17:11:57Z","html_url":"https://github.com/phpbb/phpbb3/pull/1401#discussion_r5053066","pull_request_url":"https://api.github.com/repos/phpbb/phpbb3/pulls/1401","_links":{"self":{"href":"https://api.github.com/repos/phpbb/phpbb3/pulls/comments/5053066"},"html":{"href":"https://github.com/phpbb/phpbb3/pull/1401#discussion_r5053066"},"pull_request":{"href":"https://api.github.com/repos/phpbb/phpbb3/pulls/1401"}}}} | {
"id": 541983,
"name": "phpbb3",
"url": "https://github.com/phpbb/phpbb3"
} | {
"id": null,
"login": "dhruvgoel92",
"gravatar_id": "4fe5d0bdbba1174ffdc1aa46b5c81a0e",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "phpbb",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-07-06T17:11:57 | null | {"repository":{"description":" phpBB 3 Development: phpBB is a popular open-source bulletin board written in PHP. This repository also contains the history of version 2.","homepage":"http://www.phpbb.com","watchers":485,"stargazers":485,"forks":266,"fork":false,"size":14816,"owner":"phpbb","private":false,"open_issues":54,"has_issues":false,"has_downloads":true,"has_wiki":false,"language":"PHP","created_at":"2010-03-01T14:33:17-08:00","pushed_at":"2013-07-06T09:15:45-07:00","master_branch":"develop","organization":"phpbb"},"actor_attributes":{"type":"User","name":"Dhruv Goel","blog":"","email":"[email protected]"},"url":"https://github.com/phpbb/phpbb3/pull/1401#discussion_r5053066"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/qiime/qiime/pulls/comments/3744300","id":3744300,"body":"The old name should be left in the changelog.","diff_hunk":"@@ -23,7 +23,7 @@ Fixed an issue with how centroids for a cluster are chosen. Output fasta file no\n \n \n == 0.83 ==\n-Make scripts compatible with QIIME workflow scripts (pick_otus_through_otu_table.py). Compatible with the QIIME 1.0 release.\n+Make scripts compatible with QIIME workflow scripts (pick_de_novo_otus.py). Compatible with the QIIME 1.0 release.","path":"qiime/support_files/denoiser/CHANGELOG","position":5,"original_position":5,"commit_id":"403685ff7eb40ef7e23223af8f9a0af90cd6fa14","original_commit_id":"403685ff7eb40ef7e23223af8f9a0af90cd6fa14","user":{"login":"jrrideout","id":1847232,"avatar_url":"https://secure.gravatar.com/avatar/9e0f900bf3227c537736e8d56121fa89?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"9e0f900bf3227c537736e8d56121fa89","url":"https://api.github.com/users/jrrideout","html_url":"https://github.com/jrrideout","followers_url":"https://api.github.com/users/jrrideout/followers","following_url":"https://api.github.com/users/jrrideout/following","gists_url":"https://api.github.com/users/jrrideout/gists{/gist_id}","starred_url":"https://api.github.com/users/jrrideout/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrrideout/subscriptions","organizations_url":"https://api.github.com/users/jrrideout/orgs","repos_url":"https://api.github.com/users/jrrideout/repos","events_url":"https://api.github.com/users/jrrideout/events{/privacy}","received_events_url":"https://api.github.com/users/jrrideout/received_events","type":"User"},"created_at":"2013-04-10T22:38:31Z","updated_at":"2013-04-10T22:38:31Z","html_url":"https://github.com/qiime/qiime/pull/848#discussion_r3744300","pull_request_url":"https://api.github.com/repos/qiime/qiime/pulls/848","_links":{"self":{"href":"https://api.github.com/repos/qiime/qiime/pulls/comments/3744300"},"html":{"href":"https://github.com/qiime/qiime/pull/848#discussion_r3744300"},"pull_request":{"href":"https://api.github.com/repos/qiime/qiime/pulls/848"}}}} | {
"id": 6209952,
"name": "qiime",
"url": "https://github.com/qiime/qiime"
} | {
"id": null,
"login": "jrrideout",
"gravatar_id": "9e0f900bf3227c537736e8d56121fa89",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "qiime",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-04-10T22:38:31 | null | {"repository":{"description":"Quantitative Insights Into Microbial Ecology (QIIME): Official repository for software and unit tests","homepage":"www.qiime.org","watchers":32,"stargazers":32,"forks":42,"fork":false,"size":55219,"owner":"qiime","private":false,"open_issues":234,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Python","created_at":"2012-10-13T19:51:46-07:00","pushed_at":"2013-04-09T18:12:08-07:00","master_branch":"master","organization":"qiime"},"actor_attributes":{"type":"User","name":"Jai Ram Rideout","company":"Microbial Genetics and Genomics Center","location":"Flagstaff, AZ","email":"[email protected]"},"url":"https://github.com/qiime/qiime/pull/848#discussion_r3744300"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/qiime/qiime/pulls/comments/3524664","id":3524664,"body":"Any reason not to wrap this in a QIIME script? Could integrate a little nicer that way (or alternatively, maybe we should just write a QIIME workflow that wraps all of these steps)? ","diff_hunk":"@@ -0,0 +1,88 @@\n+.. _SourceTracker:\n+\n+===========================\n+SourceTracker\n+===========================\n+\n+Introduction\n+------------\n+This tutorial explains how to use the SourceTracker software. SourceTracker is a software package designed to predict the relationship between microbial communities. These are 'Source' and 'Sink' \n+\n+Please note that this tutorial does not attempt to cover every possible usage of Source Tracker. Instead, it attempts to provide useful examples to give you an idea of how to use these statistical methods in your own analysis.\n+\n+Input Files\n+-----------\n+You can obtain the files used in this tutorial `here <https://www.dropbox.com/s/f4yikgac95ivkru/sourcetracker_tutorial_files.zip?m>`_. The files are taken from a study (Hewitt et al., 2013) Where samples were collected from three different NICUS, from various surfaces. These samples were sequenced and then analyzed against existing data sets using SourceTracker in order to predict the likely origin of the microbial communities of each specific NICU sample.\n+\n+Output Files\n+------------\n+The output file generated by this script will vary. They will all be placed in the directory specified by the required -o option. The files generated by this script contain charts and graphs and are in the pdf format. These can be viewed with a web browser or any other image viewing software.\n+\n+Test Usage\n+----------\n+Before running SourceTracker it may be useful to check that it that all of the dependencies as well as SourceTracker are correctly installed.\n+\n+To check that it is running properly, run the following command: ::\n+\n+ R --slave --vanilla --args -h < sourcetracker_for_qiime.r\n+\n+This command runs the 'help' command and returns a list of all of the options available to the terminal. The first few lines of the return are shown below. \n+\n+.. note::\n+\n+ * -i otu table: QIIME-formatted OTU table (first line is a comment line starting with '#', second line starts with '#OTU ID' followed by sample names). You must supply either this or the taxon table via '-t'.\n+ * -t taxon table: output from QIIME script summarize_taxa.py. You must supply either this or the otu table via '-i'.\n+ * -m mapfile: mapping file with an 'Env' column giving the source environments, and a 'SourceSink' column giving 'source' for source samples and 'sink' for sink samples.\n+ * -n number of restarts of Gibbs sampling (default 10)\n+ * -b number of burn-in iterations for Gibbs sampling (default 100)\n+\n+Filter otu table by 1%\n+---------------------\n+PERHAPS SOME HELP HERE ON WHY WE DO THIS?. Before the rest of the analysis is run the OTU table needs to be filtered by one percent. The number of samples in the OTU table can be obtained by running per_library_stats.py on the OTU table.\n+To filter the OTU table Run the following command: ::\n+\n+ filter_otus_from_otu_table.py -i otu_table.biom -o filtered_otu_table.biom -s 7\n+\n+This command will create an output file named :file:`filtered_otu_table.biom`, this is s new otu table that has been sampled to 1% the input to the -s command should be 1 percent of the samples in the original OTU table.\n+\n+Rarefy to 100 sequences\n+-----------------------\n+This command will rarefy the sequences to a depth of 100. \n+To rarefy the sequences run the following command: ::\n+ single_rarefaction.py -i filtered_otu_table.biom -o filtered_otu_table_100.biom -d 100\n+ \n+This command creates a new otu table named :file:`filtered_otu_table_100.biom` with the sequences rarefied to a depth of 100.\n+\n+Convert table from .biom to .txt\n+--------------------------------\n+SourceTracker does not work with the biom format. In order to run SourceTracker the OTU table needs to be converted to .txt.\n+To convert the OTU table to text format run the following command: ::\n+\n+ convert_biom.py -i filtered_otu_table_100.biom -o filtered_otu_table_100.txt -b\n+\n+This creates a file named :file:`filtered_otu_table_100.txt` which is the OTU table in text format. \n+\n+Run SourceTracker\n+-----------------\n+\n+When running SourceTracker it is important to note that a column titled 'SourceSink' is required and the categories in this column must be 'source', 'sink', or 'NA'. A column titled 'ENV' is also required the categories in this column are the names that are related to source an sink. us 'NA' for samples to not be included.\n+\n+In order to run SourceTracker run the following command: ::\n+\n+ R --slave --vanilla --args -i filtered_otu_table_100.txt -m map.txt -o sourcetracker_out < sourcetracker_for_qiime.r","path":"doc/tutorials/sourcetracker_tutorial.rst","position":72,"original_position":72,"commit_id":"8ebdf3bea0e78ab59bb5a572f4c94c0247637f34","original_commit_id":"8ebdf3bea0e78ab59bb5a572f4c94c0247637f34","user":{"login":"gregcaporaso","id":192372,"avatar_url":"https://secure.gravatar.com/avatar/24f019bae9a9c4282123961b01c7f0d5?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"24f019bae9a9c4282123961b01c7f0d5","url":"https://api.github.com/users/gregcaporaso","html_url":"https://github.com/gregcaporaso","followers_url":"https://api.github.com/users/gregcaporaso/followers","following_url":"https://api.github.com/users/gregcaporaso/following","gists_url":"https://api.github.com/users/gregcaporaso/gists{/gist_id}","starred_url":"https://api.github.com/users/gregcaporaso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gregcaporaso/subscriptions","organizations_url":"https://api.github.com/users/gregcaporaso/orgs","repos_url":"https://api.github.com/users/gregcaporaso/repos","events_url":"https://api.github.com/users/gregcaporaso/events{/privacy}","received_events_url":"https://api.github.com/users/gregcaporaso/received_events","type":"User"},"created_at":"2013-03-26T01:34:43Z","updated_at":"2013-03-26T01:34:43Z","html_url":"https://github.com/qiime/qiime/pull/719#discussion_r3524664","pull_request_url":"https://api.github.com/repos/qiime/qiime/pulls/719","_links":{"self":{"href":"https://api.github.com/repos/qiime/qiime/pulls/comments/3524664"},"html":{"href":"https://github.com/qiime/qiime/pull/719#discussion_r3524664"},"pull_request":{"href":"https://api.github.com/repos/qiime/qiime/pulls/719"}}}} | {
"id": 6209952,
"name": "qiime",
"url": "https://github.com/qiime/qiime"
} | {
"id": null,
"login": "gregcaporaso",
"gravatar_id": "24f019bae9a9c4282123961b01c7f0d5",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "qiime",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-03-26T01:34:43 | null | {"repository":{"description":"Quantitative Insights Into Microbial Ecology (QIIME): Official repository for software and unit tests","homepage":"www.qiime.org","watchers":31,"stargazers":31,"forks":41,"fork":false,"size":55143,"owner":"qiime","private":false,"open_issues":215,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Python","created_at":"2012-10-13T19:51:46-07:00","pushed_at":"2013-03-21T14:05:06-07:00","master_branch":"master","organization":"qiime"},"actor_attributes":{"type":"User","name":"Greg Caporaso","blog":"www.caporaso.us","location":"Flagstaff, Arizona, USA","email":"[email protected]"},"url":"https://github.com/qiime/qiime/pull/719#discussion_r3524664"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/rails/rails/pulls/comments/8518399","id":8518399,"diff_hunk":"@@ -62,7 +73,7 @@ def enum(definitions)\n _enum_methods_module.module_eval do\n # def direction=(value) self[:direction] = DIRECTION[value] end\n define_method(\"#{name}=\") { |value|\n- unless enum_values.has_key?(value)\n+ unless enum_values.has_key?(value) || value.nil? || value.to_s.strip.empty?","path":"activerecord/lib/active_record/enum.rb","position":23,"original_position":23,"commit_id":"8bb1b3204482bd48264d9c33cb848b1d132a913d","original_commit_id":"8bb1b3204482bd48264d9c33cb848b1d132a913d","user":{"login":"chancancode","id":55829,"avatar_url":"https://gravatar.com/avatar/22bb3e56828870ee9a0dd93aeadbe04a?d=https%3A%2F%2Fidenticons.github.com%2F8b407b57d02a2e41c7ba54441391d9ce.png&r=x","gravatar_id":"22bb3e56828870ee9a0dd93aeadbe04a","url":"https://api.github.com/users/chancancode","html_url":"https://github.com/chancancode","followers_url":"https://api.github.com/users/chancancode/followers","following_url":"https://api.github.com/users/chancancode/following{/other_user}","gists_url":"https://api.github.com/users/chancancode/gists{/gist_id}","starred_url":"https://api.github.com/users/chancancode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chancancode/subscriptions","organizations_url":"https://api.github.com/users/chancancode/orgs","repos_url":"https://api.github.com/users/chancancode/repos","events_url":"https://api.github.com/users/chancancode/events{/privacy}","received_events_url":"https://api.github.com/users/chancancode/received_events","type":"User","site_admin":false},"body":"*If* we are going to do this, :+1: for making it work with forms. Also, unrelated, but do you mind posting a gist of the view code (the form) you wrote to work with enums? I wonder if that could be made easier (`f.enum_select` or something)","created_at":"2013-12-21T20:41:05Z","updated_at":"2013-12-21T20:41:05Z","html_url":"https://github.com/rails/rails/pull/13419#discussion_r8518399","pull_request_url":"https://api.github.com/repos/rails/rails/pulls/13419","_links":{"self":{"href":"https://api.github.com/repos/rails/rails/pulls/comments/8518399"},"html":{"href":"https://github.com/rails/rails/pull/13419#discussion_r8518399"},"pull_request":{"href":"https://api.github.com/repos/rails/rails/pulls/13419"}}}} | {
"id": 8514,
"name": "rails",
"url": "https://github.com/rails/rails"
} | {
"id": null,
"login": "chancancode",
"gravatar_id": "22bb3e56828870ee9a0dd93aeadbe04a",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "rails",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-12-21T20:41:05 | null | {"repository":{"description":"Ruby on Rails","homepage":"http://rubyonrails.org","watchers":20339,"stargazers":20339,"forks":7096,"fork":false,"size":234530,"owner":"rails","private":false,"open_issues":768,"has_issues":true,"has_downloads":true,"has_wiki":false,"language":"Ruby","created_at":"2008-04-10T19:19:47-07:00","pushed_at":"2013-12-21T10:59:04-08:00","integrate_branch":"master","master_branch":"master","organization":"rails"},"actor_attributes":{"type":"User","name":"Godfrey Chan","blog":"http://about.me/godfreychan","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/rails/rails/pull/13419#discussion_r8518399"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/rails/rails/pulls/comments/8057583","id":8057583,"diff_hunk":"@@ -1,3 +1,8 @@\n+* Fix `QueryCache` to work with nested blocks, so that it will only clear the existing cache\n+ after leaving the outer block instead of clearing it right after the inner block is finished.\n+\n+ *Vipul A M*\n+","path":"activerecord/CHANGELOG.md","position":5,"original_position":5,"commit_id":"d174b23ffb4acce24d341c33691986e84b5faa3d","original_commit_id":"d174b23ffb4acce24d341c33691986e84b5faa3d","user":{"login":"vipulnsward","id":567626,"avatar_url":"https://2.gravatar.com/avatar/f459742822cf8347e83d5c445378a934?d=https%3A%2F%2Fidenticons.github.com%2Fdf97766e135d7b474bee10e0365d54bf.png&r=x","gravatar_id":"f459742822cf8347e83d5c445378a934","url":"https://api.github.com/users/vipulnsward","html_url":"https://github.com/vipulnsward","followers_url":"https://api.github.com/users/vipulnsward/followers","following_url":"https://api.github.com/users/vipulnsward/following{/other_user}","gists_url":"https://api.github.com/users/vipulnsward/gists{/gist_id}","starred_url":"https://api.github.com/users/vipulnsward/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vipulnsward/subscriptions","organizations_url":"https://api.github.com/users/vipulnsward/orgs","repos_url":"https://api.github.com/users/vipulnsward/repos","events_url":"https://api.github.com/users/vipulnsward/events{/privacy}","received_events_url":"https://api.github.com/users/vipulnsward/received_events","type":"User","site_admin":false},"body":"@carlosantoniodasilva thanks for the suggestion. updated.","created_at":"2013-12-03T12:00:36Z","updated_at":"2013-12-03T12:00:36Z","html_url":"https://github.com/rails/rails/pull/11643#discussion_r8057583","pull_request_url":"https://api.github.com/repos/rails/rails/pulls/11643","_links":{"self":{"href":"https://api.github.com/repos/rails/rails/pulls/comments/8057583"},"html":{"href":"https://github.com/rails/rails/pull/11643#discussion_r8057583"},"pull_request":{"href":"https://api.github.com/repos/rails/rails/pulls/11643"}}}} | {
"id": 8514,
"name": "rails",
"url": "https://github.com/rails/rails"
} | {
"id": null,
"login": "vipulnsward",
"gravatar_id": "f459742822cf8347e83d5c445378a934",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "rails",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-12-03T12:00:36 | null | {"repository":{"description":"Ruby on Rails","homepage":"http://rubyonrails.org","watchers":20197,"stargazers":20197,"forks":6986,"fork":false,"size":229874,"owner":"rails","private":false,"open_issues":769,"has_issues":true,"has_downloads":true,"has_wiki":false,"language":"Ruby","created_at":"2008-04-10T19:19:47-07:00","pushed_at":"2013-12-03T00:11:25-08:00","integrate_branch":"master","master_branch":"master","organization":"rails"},"actor_attributes":{"type":"User","name":"Vipul A M","company":"vipulnsward.com","blog":"vipulnsward.com","location":"Pune","email":"[email protected]"},"url":"https://github.com/rails/rails/pull/11643#discussion_r8057583"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/rspec/rspec-core/pulls/comments/5086681","id":5086681,"body":"That would be an idea, I'm not familiar with our release process, so I\r\ndelegate the decision to @myronmarston ;)\r\n\r\nOn Tuesday, 9 July 2013, David Chelimsky wrote:\r\n\r\n> In spec.txt:\r\n>\r\n> > with rspec_opts\r\n> > - with rcov=true\r\n> > - adds the rspec_opts after the rcov_opts and files\r\n> > - with rcov=false (default)\r\n> > - adds the rspec_opts\r\n> > + adds the rspec_opts\r\n> > with SPEC=path/to/file\r\n> > sets files to run\r\n> > with paths with quotes\r\n>\r\n> What about generating it during the release process so it's part of the\r\n> yard and/or relish docs, but not storing it in git?\r\n>\r\n> —\r\n> Reply to this email directly or view it on GitHub<https://github.com/rspec/rspec-core/pull/965/files#r5086649>\r\n> .\r\n>","diff_hunk":"@@ -912,23 +912,10 @@ RSpec::Core::RakeTask\n renders bundle exec rspec\n without Gemfile\n renders bundle exec rspec\n- with rcov\n- renders rcov\n- with bundler and rcov\n- renders bundle exec rcov\n with ruby options\n renders them before -S\n- with rcov_opts\n- with rcov=false (default)\n- does not add the rcov options to the command\n- with rcov=true\n- renders them after rcov\n- ensures that -Ispec:lib is in the resulting command\n with rspec_opts\n- with rcov=true\n- adds the rspec_opts after the rcov_opts and files\n- with rcov=false (default)\n- adds the rspec_opts\n+ adds the rspec_opts\n with SPEC=path/to/file\n sets files to run\n with paths with quotes","path":"spec.txt","position":24,"original_position":24,"commit_id":"b5d481894c8eec09ef727d478026f48c1043f72a","original_commit_id":"b5d481894c8eec09ef727d478026f48c1043f72a","user":{"login":"JonRowe","id":162976,"avatar_url":"https://secure.gravatar.com/avatar/d79fc498d7a5b2ce12180890247476f0?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"d79fc498d7a5b2ce12180890247476f0","url":"https://api.github.com/users/JonRowe","html_url":"https://github.com/JonRowe","followers_url":"https://api.github.com/users/JonRowe/followers","following_url":"https://api.github.com/users/JonRowe/following{/other_user}","gists_url":"https://api.github.com/users/JonRowe/gists{/gist_id}","starred_url":"https://api.github.com/users/JonRowe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JonRowe/subscriptions","organizations_url":"https://api.github.com/users/JonRowe/orgs","repos_url":"https://api.github.com/users/JonRowe/repos","events_url":"https://api.github.com/users/JonRowe/events{/privacy}","received_events_url":"https://api.github.com/users/JonRowe/received_events","type":"User"},"created_at":"2013-07-09T10:21:22Z","updated_at":"2013-07-09T10:21:22Z","html_url":"https://github.com/rspec/rspec-core/pull/965#discussion_r5086681","pull_request_url":"https://api.github.com/repos/rspec/rspec-core/pulls/965","_links":{"self":{"href":"https://api.github.com/repos/rspec/rspec-core/pulls/comments/5086681"},"html":{"href":"https://github.com/rspec/rspec-core/pull/965#discussion_r5086681"},"pull_request":{"href":"https://api.github.com/repos/rspec/rspec-core/pulls/965"}}}} | {
"id": 238972,
"name": "rspec-core",
"url": "https://github.com/rspec/rspec-core"
} | {
"id": null,
"login": "JonRowe",
"gravatar_id": "d79fc498d7a5b2ce12180890247476f0",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "rspec",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-07-09T10:21:22 | null | {"repository":{"description":"RSpec runner and formatters","homepage":"http://relishapp.com/rspec/rspec-core","watchers":488,"stargazers":488,"forks":296,"fork":false,"size":1200,"owner":"rspec","private":false,"open_issues":37,"has_issues":true,"has_downloads":false,"has_wiki":false,"language":"Ruby","created_at":"2009-06-29T08:41:05-07:00","pushed_at":"2013-07-08T22:04:24-07:00","master_branch":"master","organization":"rspec"},"actor_attributes":{"type":"User","name":"Jon Rowe","company":"Crafted Code Ltd","blog":"jonrowe.co.uk","location":"Sydney, Australia","email":"[email protected]"},"url":"https://github.com/rspec/rspec-core/pull/965#discussion_r5086681"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/scala/scala/pulls/comments/6911617","id":6911617,"diff_hunk":"@@ -0,0 +1,29 @@\n+===== lubs =====\n+java.lang.Object\n+java.lang.Object\n+AnyRef{def foo: Unit}\n+AnyRef{def foo: Unit}\n+java.lang.Object\n+java.lang.Object\n+C1\n+C1\n+C2\n+C2\n+===== glbs =====\n+X","path":"test/files/run/t7340c.check","position":13,"original_position":13,"commit_id":"1ac71ab761d9a8fc071a63ac8fe990c4de0e05d6","original_commit_id":"1ac71ab761d9a8fc071a63ac8fe990c4de0e05d6","user":{"login":"xeno-by","id":609152,"avatar_url":"https://1.gravatar.com/avatar/69e339fd10a5ad804c45e22c819c67ad?d=https%3A%2F%2Fidenticons.github.com%2F6a5b1b05e953818962474e94b67d1cc2.png","gravatar_id":"69e339fd10a5ad804c45e22c819c67ad","url":"https://api.github.com/users/xeno-by","html_url":"https://github.com/xeno-by","followers_url":"https://api.github.com/users/xeno-by/followers","following_url":"https://api.github.com/users/xeno-by/following{/other_user}","gists_url":"https://api.github.com/users/xeno-by/gists{/gist_id}","starred_url":"https://api.github.com/users/xeno-by/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xeno-by/subscriptions","organizations_url":"https://api.github.com/users/xeno-by/orgs","repos_url":"https://api.github.com/users/xeno-by/repos","events_url":"https://api.github.com/users/xeno-by/events{/privacy}","received_events_url":"https://api.github.com/users/xeno-by/received_events","type":"User","site_admin":false},"body":"Also this result exhibits an interesting problem. It essentially says that `glb(typeOf[AnyRef { def foo: Unit }], typeOf[X]) == typeOf[X]`, which is untrue, because `X <: AnyRef { def foo: Unit }` is false.\r\n\r\n```\r\nscala> class X { def foo: Unit = macro impl }\r\ndefined class X\r\n\r\nscala> glb(List(typeOf[X], typeOf[AnyRef { def foo: Unit }]))\r\nres0: $r.intp.global.Type = X\r\n\r\nscala> typeOf[X] <:< typeOf[AnyRef { def foo: Unit }]\r\nres1: Boolean = false\r\n```\r\n\r\nBut on the other hand, what should have `glb` returned? I can't see how there can exist a non-trivial type that is a subtype of both `X` and `AnyRef { def foo: Unit }`, so we should go for `Nothing`, right?","created_at":"2013-10-11T10:05:51Z","updated_at":"2013-10-11T10:05:51Z","html_url":"https://github.com/scala/scala/pull/3016#discussion_r6911617","pull_request_url":"https://api.github.com/repos/scala/scala/pulls/3016","_links":{"self":{"href":"https://api.github.com/repos/scala/scala/pulls/comments/6911617"},"html":{"href":"https://github.com/scala/scala/pull/3016#discussion_r6911617"},"pull_request":{"href":"https://api.github.com/repos/scala/scala/pulls/3016"}}}} | {
"id": 2888818,
"name": "scala",
"url": "https://github.com/scala/scala"
} | {
"id": null,
"login": "xeno-by",
"gravatar_id": "69e339fd10a5ad804c45e22c819c67ad",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "scala",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-10-11T10:05:51 | null | {"repository":{"description":"The Scala programming language","homepage":"http://www.scala-lang.org/","watchers":1700,"stargazers":1700,"forks":523,"fork":false,"size":102296,"owner":"scala","private":false,"open_issues":7,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Scala","created_at":"2011-11-30T21:02:34-08:00","pushed_at":"2013-10-09T05:13:25-07:00","integrate_branch":"develop","master_branch":"master","organization":"scala"},"actor_attributes":{"type":"User","name":"Eugene Burmako","company":"EPFL","blog":"xeno.by","location":"Lausanne, Switzerland","email":"[email protected]"},"url":"https://github.com/scala/scala/pull/3016#discussion_r6911617"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/scala/scala/pulls/comments/4343767","id":4343767,"body":"Typo in `stabilize`","diff_hunk":"@@ -110,8 +110,10 @@ trait Definitions extends api.StandardDefinitions {\n /** Is symbol a numeric value class? */\n def isNumericValueClass(sym: Symbol) = ScalaNumericValueClasses contains sym\n \n- def isGetClass(sym: Symbol) =\n- (sym.name == nme.getClass_) && flattensToEmpty(sym.paramss)\n+ def isGetClass(sym: Symbol) = (\n+ sym.name == nme.getClass_ // this condition is for performance only, this is called from `Typer#stabliize`.","path":"src/reflect/scala/reflect/internal/Definitions.scala","position":7,"original_position":7,"commit_id":"ffe821baa73cf10bed3c4e467f94ee492db8d381","original_commit_id":"ffe821baa73cf10bed3c4e467f94ee492db8d381","user":{"login":"xeno-by","id":609152,"avatar_url":"https://secure.gravatar.com/avatar/69e339fd10a5ad804c45e22c819c67ad?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"69e339fd10a5ad804c45e22c819c67ad","url":"https://api.github.com/users/xeno-by","html_url":"https://github.com/xeno-by","followers_url":"https://api.github.com/users/xeno-by/followers","following_url":"https://api.github.com/users/xeno-by/following{/other_user}","gists_url":"https://api.github.com/users/xeno-by/gists{/gist_id}","starred_url":"https://api.github.com/users/xeno-by/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xeno-by/subscriptions","organizations_url":"https://api.github.com/users/xeno-by/orgs","repos_url":"https://api.github.com/users/xeno-by/repos","events_url":"https://api.github.com/users/xeno-by/events{/privacy}","received_events_url":"https://api.github.com/users/xeno-by/received_events","type":"User"},"created_at":"2013-05-22T17:22:44Z","updated_at":"2013-05-22T17:22:44Z","html_url":"https://github.com/scala/scala/pull/2578#discussion_r4343767","pull_request_url":"https://api.github.com/repos/scala/scala/pulls/2578","_links":{"self":{"href":"https://api.github.com/repos/scala/scala/pulls/comments/4343767"},"html":{"href":"https://github.com/scala/scala/pull/2578#discussion_r4343767"},"pull_request":{"href":"https://api.github.com/repos/scala/scala/pulls/2578"}}}} | {
"id": 2888818,
"name": "scala",
"url": "https://github.com/scala/scala"
} | {
"id": null,
"login": "xeno-by",
"gravatar_id": "69e339fd10a5ad804c45e22c819c67ad",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "scala",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-05-22T17:22:44 | null | {"repository":{"description":"The Scala programming language","homepage":"http://www.scala-lang.org/","watchers":1280,"stargazers":1280,"forks":392,"fork":false,"size":97504,"owner":"scala","private":false,"open_issues":20,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Scala","created_at":"2011-11-30T21:02:34-08:00","pushed_at":"2013-05-22T04:34:34-07:00","integrate_branch":"develop","master_branch":"master","organization":"scala"},"actor_attributes":{"type":"User","name":"Eugene Burmako","company":"EPFL","blog":"xeno.by","location":"Lausanne, Switzerland","email":"[email protected]"},"url":"https://github.com/scala/scala/pull/2578#discussion_r4343767"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/scala/scala/pulls/comments/7760827","id":7760827,"diff_hunk":"@@ -204,8 +204,18 @@ trait CompilerControl { self: Global =>\n * If the unit corresponding to `source` has been removed in the meantime\n * the a NoSuchUnitError is raised in the response.\n */\n- def askLoadedTyped(source: SourceFile, response: Response[Tree]) =\n- postWorkItem(new AskLoadedTypedItem(source, response))\n+ def askLoadedTyped(sourceFile: SourceFile, response: Response[Tree]):Unit =\n+ askLoadedTyped(sourceFile, false, response)\n+\n+ def askLoadedTyped(sourceFile: SourceFile, keepLoaded: Boolean, response: Response[Tree]):Unit = {\n+ // iff the unit was already loaded (e.g. open buffer) we don't force a final reset controlled by keepLoaded\n+ val wasLoaded = ask{() => getUnit(sourceFile).isDefined}\n+ try postWorkItem(new AskLoadedTypedItem(sourceFile, response))\n+ finally { if (!wasLoaded && !keepLoaded) {\n+ val dummyResponse = new Response[Unit]()\n+ askFilesDeleted(List(sourceFile), dummyResponse)}\n+ }","path":"src/interactive/scala/tools/nsc/interactive/CompilerControl.scala","position":16,"original_position":16,"commit_id":"8b66ae36a5bea72d32fab52fa84111503ad86d54","original_commit_id":"8b66ae36a5bea72d32fab52fa84111503ad86d54","user":{"login":"dotta","id":703748,"avatar_url":"https://0.gravatar.com/avatar/a20e94bcdbd6613506c752e72209b584?d=https%3A%2F%2Fidenticons.github.com%2Fc2f90c1e30045a340972006bd3b02742.png&r=x","gravatar_id":"a20e94bcdbd6613506c752e72209b584","url":"https://api.github.com/users/dotta","html_url":"https://github.com/dotta","followers_url":"https://api.github.com/users/dotta/followers","following_url":"https://api.github.com/users/dotta/following{/other_user}","gists_url":"https://api.github.com/users/dotta/gists{/gist_id}","starred_url":"https://api.github.com/users/dotta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotta/subscriptions","organizations_url":"https://api.github.com/users/dotta/orgs","repos_url":"https://api.github.com/users/dotta/repos","events_url":"https://api.github.com/users/dotta/events{/privacy}","received_events_url":"https://api.github.com/users/dotta/received_events","type":"User","site_admin":false},"body":"You could call ``removeUnitOf`` inside ``waitLoadedTyped``...","created_at":"2013-11-19T15:42:51Z","updated_at":"2013-11-19T15:42:51Z","html_url":"https://github.com/scala/scala/pull/3158#discussion_r7760827","pull_request_url":"https://api.github.com/repos/scala/scala/pulls/3158","_links":{"self":{"href":"https://api.github.com/repos/scala/scala/pulls/comments/7760827"},"html":{"href":"https://github.com/scala/scala/pull/3158#discussion_r7760827"},"pull_request":{"href":"https://api.github.com/repos/scala/scala/pulls/3158"}}}} | {
"id": 2888818,
"name": "scala",
"url": "https://github.com/scala/scala"
} | {
"id": null,
"login": "dotta",
"gravatar_id": "a20e94bcdbd6613506c752e72209b584",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "scala",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-11-19T15:42:51 | null | {"repository":{"description":"The Scala programming language","homepage":"http://www.scala-lang.org/","watchers":1869,"stargazers":1869,"forks":566,"fork":false,"size":111611,"owner":"scala","private":false,"open_issues":17,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Scala","created_at":"2011-11-30T21:02:34-08:00","pushed_at":"2013-11-18T11:40:08-08:00","integrate_branch":"develop","master_branch":"master","organization":"scala"},"actor_attributes":{"type":"User","name":"Mirco Dotta","company":"Typesafe","location":"Lausanne","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/scala/scala/pull/3158#discussion_r7760827"} |
PullRequestReviewCommentEvent | true | {"comment":{"commit_id":"97f3c8391d3b050b87ca12e5adab84eba1b88f98","position":166,"user":{"organizations_url":"https://api.github.com/users/josef-pkt/orgs","gists_url":"https://api.github.com/users/josef-pkt/gists{/gist_id}","events_url":"https://api.github.com/users/josef-pkt/events{/privacy}","gravatar_id":"ad13088a623822caf74e635a68a55eae","type":"User","followers_url":"https://api.github.com/users/josef-pkt/followers","following_url":"https://api.github.com/users/josef-pkt/following","repos_url":"https://api.github.com/users/josef-pkt/repos","starred_url":"https://api.github.com/users/josef-pkt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josef-pkt/subscriptions","url":"https://api.github.com/users/josef-pkt","received_events_url":"https://api.github.com/users/josef-pkt/received_events","login":"josef-pkt","id":440735,"avatar_url":"https://secure.gravatar.com/avatar/ad13088a623822caf74e635a68a55eae?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png"},"original_position":166,"path":"scipy/stats/distributions.py","original_commit_id":"97f3c8391d3b050b87ca12e5adab84eba1b88f98","created_at":"2013-02-02T22:57:14Z","url":"https://api.github.com/repos/scipy/scipy/pulls/comments/2869828","id":2869828,"updated_at":"2013-02-02T22:57:14Z","_links":{"self":{"href":"https://api.github.com/repos/scipy/scipy/pulls/comments/2869828"},"html":{"href":"https://github.com/scipy/scipy/pull/400#discussion_r2869828"},"pull_request":{"href":"https://api.github.com/repos/scipy/scipy/pulls/400"}},"body":"is it possible to use the new ``_fix_loc_scale_kwarg3`` now for this?"}} | {
"id": 1460385,
"name": "scipy",
"url": "https://github.com/scipy/scipy"
} | {
"id": null,
"login": "josef-pkt",
"gravatar_id": "ad13088a623822caf74e635a68a55eae",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "scipy",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-02-02T22:57:14 | null | {"repository":{"open_issues":36,"owner":"scipy","homepage":"http://scipy.org/","watchers":592,"has_issues":false,"created_at":"2011-03-09T10:52:03-08:00","description":"Scipy main repository","stargazers":592,"has_downloads":true,"organization":"scipy","fork":false,"size":7916,"language":"C","pushed_at":"2013-02-02T12:13:38-08:00","forks":233,"private":false,"has_wiki":false},"actor_attributes":{"name":"Josef Perktold","type":"User","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/scipy/scipy/pull/400#discussion_r2869828"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/scipy/scipy_proceedings/pulls/comments/4507793","id":4507793,"body":"Hi Katy,\r\n\r\nThe P(x < y) term just represent a test of significance. Means that I consider x == y (null hypothesis) given a probabilistic significance of P (generally 95% is used, but can vary in the G-mode).","diff_hunk":"@@ -0,0 +1,631 @@\n+:author: Pedro Henrique Hasselmann\n+:email: [email protected]\n+:institution: Observatorio Nacional, Rio de Janeiro, Brazil\n+\n+:author: Jorge Márcio Carvano\n+:email: [email protected]\n+:institution: Observatorio Nacional, Rio de Janeiro, Brazil\n+\n+:author: Daniela Lazzaro\n+:email: [email protected]\n+:institution: Observatorio Nacional, Rio de Janeiro, Brazil\n+\n+-------------------------------------------------------------\n+Adapted G-mode Clustering Method applied to Asteroid Taxonomy\n+-------------------------------------------------------------\n+\n+.. class:: abstract\n+\n+ The original G-mode was a clustering method developed by A. I. Gavrishin in the 70's for geochemical classification of rocks, \n+ but was also applied to asteroid photometry, cosmic rays, lunar sample and planetary science spectroscopy data. \n+ In this work, we used an adapted version to classify the asteroid photometry from SDSS Moving Objects Catalog. \n+ The method works by identifying normal distributions in a multidimensional space of variables. \n+ The identification starts by locating a set of points with smallest mutual distance in the sample, \n+ which is a problem when data is not planar. Here we present a modified version of the G-mode algorithm,\n+ which was previously written in FORTRAN 77, in Python 2.7 and using NumPy, SciPy and Matplotlib packages. \n+ The NumPy was used for array and matrix manipulation and Matplotlib for plot control. \n+ The Scipy had a import role in speeding up G-mode, ``Scipy.spatial.distance.mahalanobis`` was chosen as distance estimator and \n+ ``Numpy.histogramdd`` was applied to find the initial seeds from which clusters are going to evolve. \n+ Scipy was also used to quickly produce dendrograms showing the distances among clusters.\n+\n+ Finally, results for Asteroids Taxonomy and tests for different sample sizes and implementations are presented.\n+\n+.. class:: keywords\n+\n+ clustering, taxonomy, asteroids, statistics, multivariate data, scipy, numpy\n+\n+Introduction\n+------------\n+\n+The clusters can be identified using the G-mode multivariate clustering method, designed by A. I. Gavrishin and Coradini [Cor76]_. \n+The algorithm was originally written in FORTRAN V by Cor77_ to classify geochemical samples [Cor76_, Bia80_], but is also applicable to a wide range of astrophysical fields, \n+as Small Solar System Bodies [Bar87_, Bir96_, Ful08_, Per10_], disk-resolved remote sensing [Pos80_, Tos05_, Cor08_, Ley10_, Tos10_], cosmic rays [Gio81]_ and quasars [Cor83]_. \n+In 1987, Bar87_ used original G-mode implementation to classify measurements of asteroids made by the Eight-Color Asteroid Survey [Zel85]_ and \n+IRAS geometric albedos [Mat86]_ to produce a taxonomic scheme. Using a sample of 442 asteroids with 8 variables, they recognized 18 classes using a confidence level\n+of 97.7 %. Those classes were grouped to represent the asteroid taxonomic types. G-mode also identified that just 3 variables\n+were enough to characterize the asteroid taxonomy. \n+\n+The G-mode classifies *N* elements into *Nc* unimodal clusters containing *Na* elements each. Elements are described by *M* variables. \n+This method is unsupervised, which allows an automatic identification of clusters without any *a priori* knowledge of sample distribution. \n+For that, user must control only one critical parameter for the classification, the confidence levels :math:`q_{1}` or\n+its corresponding critical value :math:`G_{q1}`. Smaller this parameter get, more clusters are resolved and smaller their spreads are.\n+\n+So, we choose this method to classify the asteroid observations from Sloan Digital Sky Moving Object Catalog, \n+the largest data set on photometry containing around 400,000 moving object entries, \n+due to its previous success on asteroid taxonomy, unsupervision and lower number of input parameters. \n+However, we were aware the computational limitation we were going to face, since the method never was applied to samples larger than 10,000 elements [Ley10]_\n+and its last implementation was outdated. Therefore, the G-mode used here follows an adapted version of the original method published by Gav92_, \n+briefly described by Ful00_ and reviewed by Tos05_ . \n+Median central tendency and absolute deviation estimators, a faster initial seed finder and statistical whitening were introduced to produce a more \n+robust set of clusters and optimize the processing time. The coding was performed using Python 2.7 with support of Matplotlib, NumPy and SciPy packages [*]_. \n+The algorithm can be briefly summarized by two parts: the first one is the cluster recognition and \n+the second evaluates each variable in the classification process. Each one are going to be described in the following sections. \n+\n+.. [*] The codebase_ is hosted through GitHub_ .\n+\n+.. _codebase: http://github.com/pedrohasselmann/GmodeClass\n+.. _GitHub: http://github.com/pedrohasselmann\n+ \n+Recognition Of The Unimodal Clusters\n+------------------------------------\n+\n+The first procedure can be summarized by the following topics and code snippets:\n+\n+- *The data is arranged in N X M matrix*. All variables are ``Scipy.cluster.vq.whiten`` , \n+ which means they are divided by their absolute deviation to scale all them up. \n+ This is a important measure when dealing with percentage variables, such as geometric albedos.\n+\n+- *Initial seed of a forming cluster is identified*. \n+ At the original implementation, the G-mode relied on a force-brute algorithm to find the three closest elements as initial seed, \n+ which required long processing time. Therefore, in this version, the initial seeds are searched recursively using ``Numpy.histogramdd`` , which\n+ speeds up the output:\n+\n+ .. code-block:: python\n+\n+ ###### barycenter.py ######\n+\n+ def boolist(index, values, lim):\n+ if all([boo(item[0],item[1]) \\\n+ for item in izip(values,lim)]):\n+ return index\n+\n+ def pairwise(iterable):\n+ \"\"\"s -> (s0,s1), (s1,s2), (s2, s3), ...\"\"\"\n+ a, b = tee(iterable)\n+ next(b, None)\n+ return izip(a, b)\n+\n+ def volume(lst):\n+ p = 1\n+ for i in lst: p *= i[1] - i[0]\n+ return p\n+ \n+ def barycenter_density(data, grid, upper, \\\n+ lower, dens, nmin):\n+ \n+ from numpy import histogramdd, array, \\\n+ unravel_index, amax\n+ \n+ rng = range(data.shape[1])\n+ \n+ nbin = map(int,array([grid]*data.shape[1]))\n+ \n+ hist, edges = histogramdd( \\\n+ data,bins=nbin,range=tuple(zip(lower, upper))\n+ \\ )\n+ \n+ limits = array( \\ \n+ [list(pairwise(edges[i])) for i in rng])\n+ \n+ ind = unravel_index(argmax(hist), hist.shape) \n+\n+ zone = array([limits[i,j] \\\n+ for i, j in izip(rng, ind)])\n+ \n+ density = amax(hist) / volume(zone)\n+ \n+ if density > dens and amax(hist) > nmin:\n+ zone = zone.T\n+ return barycenter_density(data, grid, \\\n+ zone[1], zone[0], density, nmin)\n+ else:\n+ return filter(lambda x: x != None, \\\n+ imap(lambda i, y: \\\n+ boolist(i,y,zone), \\\n+ xrange(data.shape[0]), data))\n+\n+The function above divides the variable hyperspace into large sectors, and just in the most crowded sector the initial seed is searched for. \n+Recursively, the most crowded sector is once divided as long as the density grows up. \n+When density decreases or the minimal number of points set by the user is reached, the procedure stops. \n+The initial seed is chosen from the elements of the most crowded sector. \n+In the end, starting central tendency :math:`\\mu_{i}` and standard deviation :math:`\\sigma_{i}` are estimated from the initial seed. \n+If any standard deviation is zero, the value is replaced by the median uncertainty of the variable. \n+\n+- *Z² criterion*. In the next step, the Mahalanobis distance (``Scipy.spatial.distance.mahalanobis``) between \n+ the tested cluster and all elements are computed:\n+ \n+ .. math::\n+\n+ \\overrightarrow{Z^{2}}_{j}=(\\overrightarrow{\\chi_{j}}-\\overrightarrow{\\mu})^{T}S^{-1}(\\overrightarrow{\\chi_{j}}-\\overrightarrow{\\mu})\n+\n+ where :math:`\\chi_{j}` is the jth element and ``S`` is covariance matrix of the tested cluster.\n+\n+- *Hypothesis Testing*. The Z² estimator follows a :math:`\\chi^{2}` distribution, but for sake of simplification, \n+ Z² can be transformed to Gaussian estimator ``G`` if the degree of freedom :math:`\\vec{f}` is large enough, which is satisfied for most of samples. \n+ Now, the critical value :math:`G_{q1}` in hypothesis testing are given as multiples of :math:`\\sigma` , simplifying its interpretation. \n+ Therefore, the vectorized transformation [Abr72]_ can be written:\n+\n+ .. math:: \n+\n+ \\vec{G_{j}}=\\sqrt{2\\cdot\\vec{Z^{2}}}-\\sqrt{2\\cdot\\frac{\\vec{f}}{N}-1}\n+ \n+\n+ while the elements of the vector degree of freedom are given by:\n+ \n+ .. math::\n+\n+ f_{k}=N\\cdot\\frac{M}{\\sum_{s=1}^{M}r_{ks}^{2}}\n+ \n+ for :math:`f_{k} > 100` , where :math:`r_{ks}^{2}` is the correlation coefficient. For :math:`30 < f_{k} < 100` , the ``G`` parameter becomes: \n+\n+ .. math::\n+\n+ \\vec{G_{j}}=\\frac{\\left(\\frac{Z^{2}}{\\vec{f}}\\right)^{1/3}-(1-\\frac{2}{9}\\cdot\\frac{\\vec{f}}{N})}{\\sqrt{\\frac{2}{9}\\cdot\\frac{\\vec{f}}{N}}}\n+ \n+ Then the null hypothesis :math:`\\chi_{ij} = \\mu_{i}` is tested with a statistical significance of :math:`P(G_{j} \\leq G_{q_{1},f})` for a :math:`\\chi_{j}`","path":"papers/pedro_hasselmann/gmode_scipy2013.rst","position":175,"original_position":175,"commit_id":"077ed30a62935e6eec11017eda630a6b92459818","original_commit_id":"077ed30a62935e6eec11017eda630a6b92459818","user":{"login":"pedrohasselmann","id":4039875,"avatar_url":"https://secure.gravatar.com/avatar/cc5fd0010b2e74376e817ddd0debb0dd?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"cc5fd0010b2e74376e817ddd0debb0dd","url":"https://api.github.com/users/pedrohasselmann","html_url":"https://github.com/pedrohasselmann","followers_url":"https://api.github.com/users/pedrohasselmann/followers","following_url":"https://api.github.com/users/pedrohasselmann/following{/other_user}","gists_url":"https://api.github.com/users/pedrohasselmann/gists{/gist_id}","starred_url":"https://api.github.com/users/pedrohasselmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pedrohasselmann/subscriptions","organizations_url":"https://api.github.com/users/pedrohasselmann/orgs","repos_url":"https://api.github.com/users/pedrohasselmann/repos","events_url":"https://api.github.com/users/pedrohasselmann/events{/privacy}","received_events_url":"https://api.github.com/users/pedrohasselmann/received_events","type":"User"},"created_at":"2013-06-03T19:34:59Z","updated_at":"2013-06-03T19:34:59Z","html_url":"https://github.com/scipy/scipy_proceedings/pull/51#discussion_r4507793","pull_request_url":"https://api.github.com/repos/scipy/scipy_proceedings/pulls/51","_links":{"self":{"href":"https://api.github.com/repos/scipy/scipy_proceedings/pulls/comments/4507793"},"html":{"href":"https://github.com/scipy/scipy_proceedings/pull/51#discussion_r4507793"},"pull_request":{"href":"https://api.github.com/repos/scipy/scipy_proceedings/pulls/51"}}}} | {
"id": 1825629,
"name": "scipy_proceedings",
"url": "https://github.com/scipy/scipy_proceedings"
} | {
"id": null,
"login": "pedrohasselmann",
"gravatar_id": "cc5fd0010b2e74376e817ddd0debb0dd",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "scipy",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-06-03T19:34:59 | null | {"repository":{"description":"Tools used to generate the SciPy conference proceedings","homepage":"","watchers":39,"stargazers":39,"forks":60,"fork":false,"size":3248,"owner":"scipy","private":false,"open_issues":16,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Python","created_at":"2011-05-31T03:26:48-07:00","pushed_at":"2013-05-29T08:11:36-07:00","master_branch":"master","organization":"scipy"},"actor_attributes":{"type":"User","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/scipy/scipy_proceedings/pull/51#discussion_r4507793"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/scipy/scipy_proceedings/pulls/comments/4607167","id":4607167,"body":"capital Hyperopt","diff_hunk":"@@ -0,0 +1,866 @@\n+:author: James Bergstra\n+:email: [email protected]\n+:institution: University of Waterloo\n+\n+:author: Dan Yamins\n+:email: [email protected]\n+:institution: Massachusetts Institute of Technology\n+\n+:author: David D. Cox\n+:email: [email protected]\n+:institution: Harvard University\n+\n+\n+--------------------------------------------------------------------------------------------\n+Hyperopt: A Python Library for Optimizing the Hyperparameters of Machine Learning Algorithms\n+--------------------------------------------------------------------------------------------\n+\n+.. class:: abstract\n+\n+ Sequential model-based optimization (also known as Bayesian optimization)\n+ is one of the most efficient\n+ methods (per function evaluation) of function minimization.\n+ This efficiency makes it appropriate for optimizing the hyperparameters\n+ of machine learning algorithms that are slow to train.\n+ The Hyperopt library provides algorithms and parallelization\n+ infrastructure for performing hyperparameter optimization (model\n+ selection) in Python.\n+ This paper describes basic and advanced usage of the Hyperopt library,\n+ introduces the high-level design, and lists some of the ongoing work\n+ related to the project.\n+\n+.. class:: keywords\n+\n+ Bayesian optimization, hyperparameter optimization, model selection\n+\n+\n+Introduction\n+------------\n+\n+Sequential model-based optimization (SMBO, also known as Bayesian optimization) is a general technique for function optimization that includes some of the most\n+call-efficient (in terms of function evaluations) optimization methods currently available.\n+Originally developed for experiment design (and oil exploration, [Mockus78]_) SMBO methods are generally applicable to scenarios in which a user wishes to minimize some scalar-valued function :math:`f(x)` that is costly to evaluate, often in terms of time or money.\n+Compared with standard optimization strategies such as conjugate gradient descent methods, model-based optimization algorithms invest more time between function evaluations in order to reduce the number of function evaluations overall.\n+\n+The advantages of SMBO are that it:\n+\n+* leverages smoothness without analytic gradient,\n+\n+* handles real-valued, discrete, and conditional variables,\n+\n+* handles parallel evaluations of :math:`f(x)`,\n+\n+* copes with hundreds of variables, even with budget of just a few hundred function evaluations.\n+\n+\n+Many widely-used machine learning algorithms take a significant amount of time to train from data.\n+At the same time, these same algorithms must be configured prior to training.\n+These configuration variables are called *hyperparameters*.\n+For example, Support Vector Machines (SVMs) have hyperparameters that include the regularization strength (often :math:`C`) the scaling of input data\n+(and more generally, the preprocessing of input data), the choice of similarity kernel, and the various parameters that are specific to that kernel choice.\n+Decision trees are another machine learning algorithm with hyperparameters related to the heuristic for creating internal nodes, and the pruning strategy for the tree after (or during) training.\n+Neural networks are a classic type of machine learning algorithm but they have so many hyperparameters that they have been considered too troublesome for inclusion in the sklearn library.\n+\n+Generally speaking, no matter what algorithm has been chosen (i.e. SVM, decision tree, neural network, or something else), hyperparameters have a significant\n+effect on the success of the training algorithm.\n+A poorly-configured SVM may perform no better than chance, while a well-configured one may achieve state-of-the-art prediction accuracy.\n+To experts and non-experts alike, adjusting hyperparameters to optimize end-to-end performance can be a daunting task.\n+Hyperparameters come in many varieties--continuous-valued ones with and without bounds, discrete ones that are either ordered or not, and conditional ones that do not even always apply\n+(e.g., the parameters of an optional pre-processing stage).\n+Because of this variety, conventional continuous and combinatorial optimization algorithms either do not directly apply,\n+or else operate without leveraging valuable structure in the configuration space.\n+Common practice for the optimization of hyperparameters is\n+(a) for algorithm developers to tune them by hand on representative problems to get good rules of thumb and default values,\n+and (b) for algorithm users to tune them manually for their particular prediction problems, perhaps with the assistance of [multi-resolution] grid search.\n+However, when dealing with more than a few hyperparameters (e.g. 5) this standard practice of manual search with grid refinement is not guaranteed to work well;\n+in such cases even random search has been shown to be competitive with domain experts [BB12]_.\n+\n+Hyperopt [Hyperopt]_ provides algorithms and software infrastructure for carrying out hyperparameter optimization for machine learning algorithms.\n+Hyperopt provides an optimization interface that distinguishes a *configuration space* and an *evaluation function* that assigns real-valued\n+*loss values* to points within the configuration space.\n+Unlike the fmin interface in SciPy or Matlab, Hyperopt's fmin interface requires users to specify the configuration space as a probability distribution.\n+Specifying a probability distribution rather than just bounds and hard constraints allows domain experts to encode more of their intuitions\n+regarding which values are plausible for various hyperparameters.\n+Like SciPy's new fmin interface, hyperopt makes the SMBO algorithm itself an interchangeable component, so it is easy for a user to search a specific\n+space using any of the provided SMBO implementations. Currently just two algorithms are provided --random search and Tree-of-Parzen-Estimators (TPE) algorithm introduced in [BBBK11]_ --\n+but more algorithms are planned: [SMAC]_, [ROAR]_, and Gaussian-process-based ones such as [Brochu10]_ and [SLA13]_.\n+\n+We are motivated to make hyperparameter optimization more reliable for four reasons:\n+\n+**Reproducibile research**\n+ Hyperopt formalizes the practice of model evaluation, so that benchmarking experiments can be reproduced at later dates, and by different people.\n+\n+**Empowering users**\n+ Learning algorithm designers can deliver flexible fully-configurable implementations to non-experts (e.g. deep learning systems), so long as they also provide a corresponding Hyperopt driver.\n+\n+**Designing better algorithms**\n+ As algorithm designers, we appreciate Hyperopt's capacity to find successful configurations that we might not have considered.\n+\n+**Fuzz testing**\n+ As algorithm designers, we appreciate Hyperopt's capacity to find failure modes via configurations that we had not considered.\n+\n+This paper describes the usage and architecture of Hyperopt, for both sequential and parallel optimization of expensive functions.\n+Hyperopt can in principle be used for any SMBO problem, but our development and testing efforts have been limited so far to the optimization of\n+hyperparameters for deep neural networks [hp-dbn]_ and convnet-based computer vision systems for object recognition [hp-convnet]_.\n+\n+\n+Getting Started with Hyperopt\n+-----------------------------\n+\n+This section introduces basic usage of the ``hyperopt.fmin`` function, which is hyperopt's basic optimization driver. \n+We will look at how to write an objective function that ``fmin`` can optimize, and how to describe a configuration space that ``fmin`` can search.\n+\n+Hyperopt shoulders the responsibility of finding the best value of a scalar-valued,\n+possibly-stochastic function over a set of possible arguments to that function.\n+Whereas most optimization packages assume that these inputs are drawn from a vector space,\n+Hyperopt encourages you, the user, to describe your configuration space in more detail.\n+Hyperopt is typically aimed at very difficult search settings, especially ones with many hyperparameters and a small budget for function evaluations.\n+By providing more information about where your function is defined, and where you think the best values are,\n+you allow algorithms in hyperopt to search more efficiently.\n+\n+The way to use hyperopt is to describe:\n+\n+* the objective function to minimize\n+* the space over which to search\n+* a trials database [optional]\n+* the search algorithm to use [optional]\n+\n+This section will explain how to describe the objective function, configuration space, and optimization algorithm.\n+Later,\n+Section `Trial results: more than just the loss`_ will explain how to use the trials database to analyze the results of a search,\n+and Section `Parallel Evaluation with a Cluster`_ will explain how to use parallel computation to search\n+faster.\n+\n+\n+Step 1: define an objective function\n+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n+\n+Hyperopt provides a few levels of increasing flexibility / complexity when it comes to specifying an objective function to minimize.\n+In the simplest case, an objective function is a Python function that accepts a single argument that stands for :math:`x` (which can be an arbitrary object),\n+and returns a single scalar value that represents the *loss* (:math:`f(x)`) incurred by that argument.\n+\n+So for a trivial example, if we want to minimize a quadratic function :math:`q(x, y) := x^2 + y^2` then we could define our objective ``q`` as follows:\n+\n+.. code-block:: python\n+\n+ def q(args):\n+ x, y = args\n+ return x ** 2 + y ** 2\n+\n+Although hyperopt accepts objective functions that are more complex in both the arguments they accept and their return value,","path":"papers/james_bergstra_hyperopt/paper.rst","position":150,"original_position":150,"commit_id":"4655f2d87f187df4f896381a5360c5fe2b93464c","original_commit_id":"4655f2d87f187df4f896381a5360c5fe2b93464c","user":{"login":"jarrodmillman","id":123428,"avatar_url":"https://secure.gravatar.com/avatar/41d3af311e5a84d652abffa2341165cd?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"41d3af311e5a84d652abffa2341165cd","url":"https://api.github.com/users/jarrodmillman","html_url":"https://github.com/jarrodmillman","followers_url":"https://api.github.com/users/jarrodmillman/followers","following_url":"https://api.github.com/users/jarrodmillman/following{/other_user}","gists_url":"https://api.github.com/users/jarrodmillman/gists{/gist_id}","starred_url":"https://api.github.com/users/jarrodmillman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jarrodmillman/subscriptions","organizations_url":"https://api.github.com/users/jarrodmillman/orgs","repos_url":"https://api.github.com/users/jarrodmillman/repos","events_url":"https://api.github.com/users/jarrodmillman/events{/privacy}","received_events_url":"https://api.github.com/users/jarrodmillman/received_events","type":"User"},"created_at":"2013-06-10T08:01:18Z","updated_at":"2013-06-10T08:01:18Z","html_url":"https://github.com/scipy/scipy_proceedings/pull/58#discussion_r4607167","pull_request_url":"https://api.github.com/repos/scipy/scipy_proceedings/pulls/58","_links":{"self":{"href":"https://api.github.com/repos/scipy/scipy_proceedings/pulls/comments/4607167"},"html":{"href":"https://github.com/scipy/scipy_proceedings/pull/58#discussion_r4607167"},"pull_request":{"href":"https://api.github.com/repos/scipy/scipy_proceedings/pulls/58"}}}} | {
"id": 1825629,
"name": "scipy_proceedings",
"url": "https://github.com/scipy/scipy_proceedings"
} | {
"id": null,
"login": "jarrodmillman",
"gravatar_id": "41d3af311e5a84d652abffa2341165cd",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "scipy",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-06-10T08:01:18 | null | {"repository":{"description":"Tools used to generate the SciPy conference proceedings","homepage":"","watchers":39,"stargazers":39,"forks":60,"fork":false,"size":1124,"owner":"scipy","private":false,"open_issues":17,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Python","created_at":"2011-05-31T03:26:48-07:00","pushed_at":"2013-06-09T02:57:05-07:00","master_branch":"master","organization":"scipy"},"actor_attributes":{"type":"User","name":"Jarrod Millman","company":"UC Berkeley","blog":"http://blog.jarrodmillman.com/","location":"California","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/scipy/scipy_proceedings/pull/58#discussion_r4607167"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/scipy/SciPyCentral/pulls/comments/5567112","id":5567112,"body":"Well, actually, I am using only one div 'spc-error-response' (the id value is not exactly right). Irrespective of the type of error we get, we just display in that div.\r\n\r\nSo, in that way, I wrote the message in js","diff_hunk":"@@ -0,0 +1,176 @@\n+/* \n+JavaScript definitions to handle comments on the site\n+*/\n+\n+(function($) {\n+$(document).ready(function() {\n+\n+ // preview comment\n+ $('.spc-comment-preview').on('click', function() {\n+ var data_submit = $(this).data('submit');\n+ var comment;\n+ if (data_submit == 'new') {\n+ comment = $('#id_comment').val();\n+ preview = '#spc-comment-preview';\n+ error_resp = '#spc-comment-error-response';\n+ } else if (data_submit == 'edit') {\n+ comment = $('#id_edit_comment').val();\n+ preview = '#spc-comment-edit-preview';\n+ error_resp = '#spc-comment-edit-error-response';\n+ }\n+ $.ajax ({\n+ type: 'get',\n+ url: '/comments/preview/',\n+ data: {'rest_comment': comment},\n+ success: function(response) {\n+ if (response.success) {\n+ $('.response-text').hide(); // hide previous response\n+ $(preview).show().html(response.html_comment);\n+ } \n+ else {\n+ $(error_resp).show().html(response.msg);\n+ }\n+ },\n+ error: function(XMLHttpRequest, textStatus, errorThrown) {\n+ console.error(errorThrown);\n+ console.error(textStatus);\n+ $(error_resp).show().html('Error raised. Try again later');","path":"scipy_central/comments/static/comments/comment-actions.js","position":37,"original_position":37,"commit_id":"0646ff19de115ac19a6e4fc6344c2ba8e4cb18a0","original_commit_id":"0646ff19de115ac19a6e4fc6344c2ba8e4cb18a0","user":{"login":"ksurya","id":932927,"avatar_url":"https://secure.gravatar.com/avatar/8bf688ba7ac4371539003fc279f383db?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"8bf688ba7ac4371539003fc279f383db","url":"https://api.github.com/users/ksurya","html_url":"https://github.com/ksurya","followers_url":"https://api.github.com/users/ksurya/followers","following_url":"https://api.github.com/users/ksurya/following{/other_user}","gists_url":"https://api.github.com/users/ksurya/gists{/gist_id}","starred_url":"https://api.github.com/users/ksurya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ksurya/subscriptions","organizations_url":"https://api.github.com/users/ksurya/orgs","repos_url":"https://api.github.com/users/ksurya/repos","events_url":"https://api.github.com/users/ksurya/events{/privacy}","received_events_url":"https://api.github.com/users/ksurya/received_events","type":"User"},"created_at":"2013-08-03T15:27:13Z","updated_at":"2013-08-03T15:27:13Z","html_url":"https://github.com/scipy/SciPyCentral/pull/131#discussion_r5567112","pull_request_url":"https://api.github.com/repos/scipy/SciPyCentral/pulls/131","_links":{"self":{"href":"https://api.github.com/repos/scipy/SciPyCentral/pulls/comments/5567112"},"html":{"href":"https://github.com/scipy/SciPyCentral/pull/131#discussion_r5567112"},"pull_request":{"href":"https://api.github.com/repos/scipy/SciPyCentral/pulls/131"}}}} | {
"id": 1724459,
"name": "SciPyCentral",
"url": "https://github.com/scipy/SciPyCentral"
} | {
"id": null,
"login": "ksurya",
"gravatar_id": "8bf688ba7ac4371539003fc279f383db",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "scipy",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-08-03T15:27:13 | null | {"repository":{"description":"SciPy Central","homepage":"http://scipy-central.org","watchers":5,"stargazers":5,"forks":4,"fork":false,"size":2568,"owner":"scipy","private":false,"open_issues":45,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Python","created_at":"2011-05-09T13:05:12-07:00","pushed_at":"2013-07-03T11:35:38-07:00","master_branch":"master","organization":"scipy"},"actor_attributes":{"type":"User","name":"Surya Kasturi","blog":"http://about.me/suryak","location":"India","email":"[email protected]"},"url":"https://github.com/scipy/SciPyCentral/pull/131#discussion_r5567112"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/site5/lumberg/pulls/comments/4061253","id":4061253,"body":"78181f887397bb92089e9b1dbaa8fe6fb7aaefa8","diff_hunk":"@@ -0,0 +1,353 @@\n+module Lumberg\n+ module Cpanel\n+ class Email < Base\n+ # Public: Get info about how the main email account handles\n+ # undeliverable mail.\n+ #\n+ # options - Hash options for API call params (default: {}).\n+ #\n+ # Returns Hash API response.\n+ def main_discard(options = {})\n+ perform_request(\n+ :api_function => \"checkmaindiscard\"\n+ )\n+ end\n+\n+ # Public: Add a forwarder.\n+ #\n+ # options - Hash options for API call params (default: {}):\n+ # :domain - String forwarder domain.\n+ # :email - String local part (\"user\" if \"[email protected]\").\n+ # :fwdopt - String type of forwarder. Accepted values:\n+ # \"pipe\", \"fwd\", \"system\", \"blackhole\", \"fail\"\n+ # :fwdemail - String Destination email address.\n+ # :fwdsystem - String system account to forward to (optional). Should\n+ # only be used if :fwdopt is set to \"system\".\n+ # :failmsgs - String failure message (optional). Only used if \"fwdopt\"\n+ # is set to \"fail\".\n+ # :pipefwd - String path to program to pipe to (optional). Only used\n+ # if \"fwdopt\" is set to \"pipe\"\n+ #\n+ # Returns Hash API response.\n+ def add_forwarder(options = {})\n+ perform_request({\n+ :api_function => \"addforward\"\n+ }.merge(options))\n+ end\n+\n+ # Public: Get list of forwarders.\n+ #\n+ # options - Hash options for API call params (default: {}):\n+ # :domain - String domain for which to retrieve forwarders (optional).\n+ # :regex - String regular expression to filter results (optional).\n+ #\n+ # Returns Hash API response.\n+ def forwarders(options = {})\n+ perform_request({\n+ :api_function => \"listforwards\"\n+ }.merge(options))\n+ end\n+\n+ # Public: Retrieve a list of domains that use aliases and custom\n+ # catch-all addresses.\n+ #\n+ # options - Hash options for API call params (default: {}).\n+ #\n+ # Returns Hash API response.\n+ def domains_with_aliases(options = {})\n+ perform_request(\n+ :api_function => \"listaliasbackups\"\n+ )\n+ end\n+\n+ # Public: Add a mailing list.\n+ #\n+ # options - Hash options for API call params (default: {}):\n+ # :list - String mailing liist name.\n+ # :password - String mailing list password.\n+ # :domain - String mailing list domain.\n+ #\n+ # Returns Hash API response.\n+ def add_mailing_list(options = {})\n+ perform_request({\n+ :api_function => \"addlist\",\n+ :api_version => 1, # :(","path":"lib/lumberg/cpanel/email.rb","position":null,"original_position":74,"commit_id":"78181f887397bb92089e9b1dbaa8fe6fb7aaefa8","original_commit_id":"583573af29790e36b3e8921b0e4f95780faebf6a","user":{"login":"drichert","id":145799,"avatar_url":"https://secure.gravatar.com/avatar/994da99e1b1a410b137e65a4df545b11?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"994da99e1b1a410b137e65a4df545b11","url":"https://api.github.com/users/drichert","html_url":"https://github.com/drichert","followers_url":"https://api.github.com/users/drichert/followers","following_url":"https://api.github.com/users/drichert/following","gists_url":"https://api.github.com/users/drichert/gists{/gist_id}","starred_url":"https://api.github.com/users/drichert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drichert/subscriptions","organizations_url":"https://api.github.com/users/drichert/orgs","repos_url":"https://api.github.com/users/drichert/repos","events_url":"https://api.github.com/users/drichert/events{/privacy}","received_events_url":"https://api.github.com/users/drichert/received_events","type":"User"},"created_at":"2013-05-02T18:49:14Z","updated_at":"2013-05-02T18:49:14Z","html_url":"https://github.com/site5/lumberg/pull/30#discussion_r4061253","pull_request_url":"https://api.github.com/repos/site5/lumberg/pulls/30","_links":{"self":{"href":"https://api.github.com/repos/site5/lumberg/pulls/comments/4061253"},"html":{"href":"https://github.com/site5/lumberg/pull/30#discussion_r4061253"},"pull_request":{"href":"https://api.github.com/repos/site5/lumberg/pulls/30"}}}} | {
"id": 1493275,
"name": "lumberg",
"url": "https://github.com/site5/lumberg"
} | {
"id": null,
"login": "drichert",
"gravatar_id": "994da99e1b1a410b137e65a4df545b11",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "site5",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-05-02T18:49:14 | null | {"repository":{"description":"Ruby library for the WHM & cPanel API; It's not a half day or anything like that.","homepage":"http://www.site5.com","watchers":33,"stargazers":33,"forks":10,"fork":false,"size":324,"owner":"site5","private":false,"open_issues":4,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Ruby","created_at":"2011-03-17T13:18:55-07:00","pushed_at":"2013-04-29T11:01:03-07:00","master_branch":"master","organization":"site5"},"actor_attributes":{"type":"User","name":"Dan Richert","company":"World Wide Web Hosting, LLC","blog":"http://twitter.com/drichert","location":"Metro Detroit, Michigan","email":"[email protected]"},"url":"https://github.com/site5/lumberg/pull/30#discussion_r4061253"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/sympy/sympy/pulls/comments/3741007","id":3741007,"body":"fixed.","diff_hunk":"@@ -280,6 +280,13 @@ def as_coeff_mmul(self):\n return 1, MatMul(self)\n \n \n+class MatrixElement(Expr):\n+ is_commutative=True","path":"sympy/matrices/expressions/matexpr.py","position":null,"original_position":43,"commit_id":"f5bd94e4c1d3f08314161655ebb797400e6509ea","original_commit_id":"ea34625fa1cbfda8667c820d436e5e4d4b91e7e0","user":{"login":"mrocklin","id":306380,"avatar_url":"https://secure.gravatar.com/avatar/8749ec52cee260c4c1f67f2dec29d957?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"8749ec52cee260c4c1f67f2dec29d957","url":"https://api.github.com/users/mrocklin","html_url":"https://github.com/mrocklin","followers_url":"https://api.github.com/users/mrocklin/followers","following_url":"https://api.github.com/users/mrocklin/following","gists_url":"https://api.github.com/users/mrocklin/gists{/gist_id}","starred_url":"https://api.github.com/users/mrocklin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrocklin/subscriptions","organizations_url":"https://api.github.com/users/mrocklin/orgs","repos_url":"https://api.github.com/users/mrocklin/repos","events_url":"https://api.github.com/users/mrocklin/events{/privacy}","received_events_url":"https://api.github.com/users/mrocklin/received_events","type":"User"},"created_at":"2013-04-10T19:35:08Z","updated_at":"2013-04-10T19:35:08Z","html_url":"https://github.com/sympy/sympy/pull/1975#discussion_r3741007","pull_request_url":"https://api.github.com/repos/sympy/sympy/pulls/1975","_links":{"self":{"href":"https://api.github.com/repos/sympy/sympy/pulls/comments/3741007"},"html":{"href":"https://github.com/sympy/sympy/pull/1975#discussion_r3741007"},"pull_request":{"href":"https://api.github.com/repos/sympy/sympy/pulls/1975"}}}} | {
"id": 640534,
"name": "sympy",
"url": "https://github.com/sympy/sympy"
} | {
"id": null,
"login": "mrocklin",
"gravatar_id": "8749ec52cee260c4c1f67f2dec29d957",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "sympy",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-04-10T19:35:08 | null | {"repository":{"description":"A computer algebra system written in pure Python","homepage":"http://sympy.org/","watchers":680,"stargazers":680,"forks":390,"fork":false,"size":4316,"owner":"sympy","private":false,"open_issues":89,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Python","created_at":"2010-04-30T13:37:14-07:00","pushed_at":"2013-04-10T12:11:31-07:00","master_branch":"master","organization":"sympy"},"actor_attributes":{"type":"User","name":"Matthew Rocklin","company":"University of Chicago","blog":"http://matthewrocklin.com","location":"Chicago, IL","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/sympy/sympy/pull/1975#discussion_r3741007"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/sympy/sympy/pulls/comments/6267127","id":6267127,"body":"Thanks Aaron, I'll fix it.","diff_hunk":"@@ -2138,3 +2201,471 @@ def holzer(x_0, y_0, z_0, a, b, c):\n x_0, y_0, z_0 = x, y, z\n \n return x_0, y_0, z_0\n+\n+\n+def diop_general_pythagorean(eq, param=symbols(\"m\", Integer=True)):\n+ \"\"\"\n+ Solves the general pythagorean equation,`a_{1}^2x_{1}^2 + a_{2}^2x_{2}^2 + . . . + a_{n}^2x_{n}^2 - a_{n + 1}^2x_{n + 1}^2 = 0`.\n+ Returns a tuple which contains a parametrized solution to the equation, sorted in the same order\n+ as the input variables.\n+\n+ Usage\n+ =====\n+\n+ ``diop_general_pythagorean(eq, param)`` -> where ``eq`` is a general pythagorean equation\n+ which is assumed to be zero and ``param`` is the base parameter used to construct other\n+ parameters by subscripting.\n+\n+ Examples\n+ ========\n+\n+ >>> from sympy.solvers.diophantine import diop_general_pythagorean\n+ >>> from sympy.abc import a, b, c, d, e\n+ >>> diop_general_pythagorean(a**2 + b**2 + c**2 - d**2)\n+ (m1**2 + m2**2 - m3**2, 2*m1*m3, 2*m2*m3, m1**2 + m2**2 + m3**2)\n+ >>> diop_general_pythagorean(9*a**2 - 4*b**2 + 16*c**2 + 25*d**2 + e**2)\n+ (10*m1**2 + 10*m2**2 + 10*m3**2 - 10*m4**2, 15*m1**2 + 15*m2**2 + 15*m3**2 + 15*m4**2, 15*m1*m4, 12*m2*m4, 60*m3*m4)\n+ \"\"\"\n+ var, coeff, diop_type = classify_diop(eq)\n+\n+ if diop_type == \"general_pythagorean\":\n+ return _diop_general_pythagorean(var, coeff, param)\n+\n+\n+def _diop_general_pythagorean(var, coeff, t):\n+\n+ if sign(coeff[var[0]**2]) + sign(coeff[var[1]**2]) + sign(coeff[var[2]**2]) < 0:\n+ for key in coeff.keys():\n+ coeff[key] = coeff[key] * -1\n+\n+ n = len(var)\n+ index = 0\n+\n+ for i, v in enumerate(var):\n+ if sign(coeff[v**2]) == -1:\n+ index = i\n+\n+ m = symbols(str(t) + \"1:\" + str(n), Integer=True)\n+ l = []\n+ ith = 0\n+\n+ for m_i in m:\n+ ith = ith + m_i**2\n+\n+ l.append(ith - 2*m[n - 2]**2)\n+\n+ for i in range(n - 2):\n+ l.append(2*m[i]*m[n-2])\n+\n+ sol = l[:index] + [ith] + l[index:]\n+\n+ lcm = 1\n+ for i, v in enumerate(var):\n+ if i == index or (index > 0 and i == 0) or (index == 0 and i == 1):\n+ lcm = ilcm(lcm, sqrt(abs(coeff[v**2])))\n+ else:\n+ lcm = ilcm(lcm, sqrt(coeff[v**2]) if sqrt(coeff[v**2]) % 2 else sqrt(coeff[v**2]) // 2)\n+\n+ for i, v in enumerate(var):\n+ sol[i] = (lcm*sol[i]) / sqrt(abs(coeff[v**2]))\n+\n+ return tuple(sol)\n+\n+\n+def diop_general_sum_of_squares(eq, limit=1):\n+ \"\"\"\n+ Returns a set of solution to the equation `x_{1}^2 + x_{2}^2 + . . . + x_{n}^2 - k = 0`.\n+ Returns at most ``limit`` number of solutions. Currently there is no way to set ``limit``\n+ using higher level API's like ``diophantine()`` or ``diop_solve()`` but that will be fixed\n+ soon.\n+\n+ Usage\n+ =====\n+\n+ ``general_sum_of_squares(eq, limit)`` -> Here ``eq`` is an expression which is assumed to be zero.\n+ Also, ``eq`` should be in the , form, `x_{1}^2 + x_{2}^2 + . . . + x_{n}^2 - k = 0`. At most ``limit``\n+ number of solutions are returned.\n+\n+ Details\n+ =======\n+\n+ When `n = 3` if `k = 4^a(8m + 7)` for some `a, m \\in Z` then there will be no solutions.\n+ Refer [1] for more details.\n+\n+ Examples\n+ ========\n+\n+ >>> from sympy.solvers.diophantine import diop_general_sum_of_squares\n+ >>> from sympy.abc import a, b, c, d, e, f\n+ >>> diop_general_sum_of_squares(a**2 + b**2 + c**2 + d**2 + e**2 - 2345)\n+ set([(0, 48, 5, 4, 0)])\n+\n+ Reference\n+ =========\n+\n+ .. [1] Representing an Integer as a sum of three squares, [online],\n+ Available: http://www.proofwiki.org/wiki/Integer_as_Sum_of_Three_Squares\n+ \"\"\"\n+ var, coeff, diop_type = classify_diop(eq)\n+\n+ if diop_type == \"general_sum_of_squares\":\n+ return _diop_general_sum_of_squares(var, coeff, limit)\n+\n+\n+def _diop_general_sum_of_squares(var, coeff, limit=1):\n+\n+ n = len(var)\n+ k = -int(coeff[Integer(1)])\n+ s = set([])\n+\n+ if k < 0:\n+ return set([])\n+\n+ if n == 3:\n+ s.add(sum_of_three_squares(k))\n+ elif n == 4:\n+ s.add(sum_of_four_squares(k))\n+ else:\n+\n+ m = n // 4\n+ f = partition(k, m)\n+\n+ for j in range(limit):\n+\n+ soln = []\n+ try:\n+ l = next(f)\n+ except StopIteration:\n+ break\n+\n+ for n_i in l:\n+ a, b, c, d = sum_of_four_squares(n_i)\n+ soln = soln + [a, b, c, d]\n+\n+ soln = soln + [0] * (n % 4)\n+\n+ s.add(tuple(soln))\n+\n+ return s\n+\n+\n+## Functions below this comment can be more suitably grouped under an Additive number theory module\n+## rather than the Diophantine equation module.\n+\n+\n+def partition(n, k=None, zeros=False):\n+ \"\"\"\n+ Returns a generator that can be used to generate partitions of an integer `n`. A partition\n+ of `n` is a set of positive integers which add upto `n`. For example, partitions of 3 are","path":"sympy/solvers/diophantine.py","position":432,"original_position":432,"commit_id":"9d3f9f4ad57ff9129b4f5b18920924125de80549","original_commit_id":"9d3f9f4ad57ff9129b4f5b18920924125de80549","user":{"login":"thilinarmtb","id":1346780,"avatar_url":"https://2.gravatar.com/avatar/8ccd21c14794d3d064b60a91526687f0?d=https%3A%2F%2Fidenticons.github.com%2F0efa9a616cdb866286cc2910434f550e.png","gravatar_id":"8ccd21c14794d3d064b60a91526687f0","url":"https://api.github.com/users/thilinarmtb","html_url":"https://github.com/thilinarmtb","followers_url":"https://api.github.com/users/thilinarmtb/followers","following_url":"https://api.github.com/users/thilinarmtb/following{/other_user}","gists_url":"https://api.github.com/users/thilinarmtb/gists{/gist_id}","starred_url":"https://api.github.com/users/thilinarmtb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thilinarmtb/subscriptions","organizations_url":"https://api.github.com/users/thilinarmtb/orgs","repos_url":"https://api.github.com/users/thilinarmtb/repos","events_url":"https://api.github.com/users/thilinarmtb/events{/privacy}","received_events_url":"https://api.github.com/users/thilinarmtb/received_events","type":"User"},"created_at":"2013-09-10T14:36:14Z","updated_at":"2013-09-10T14:36:14Z","html_url":"https://github.com/sympy/sympy/pull/2432#discussion_r6267127","pull_request_url":"https://api.github.com/repos/sympy/sympy/pulls/2432","_links":{"self":{"href":"https://api.github.com/repos/sympy/sympy/pulls/comments/6267127"},"html":{"href":"https://github.com/sympy/sympy/pull/2432#discussion_r6267127"},"pull_request":{"href":"https://api.github.com/repos/sympy/sympy/pulls/2432"}}}} | {
"id": 640534,
"name": "sympy",
"url": "https://github.com/sympy/sympy"
} | {
"id": null,
"login": "thilinarmtb",
"gravatar_id": "8ccd21c14794d3d064b60a91526687f0",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "sympy",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-09-10T14:36:14 | null | {"repository":{"description":"A computer algebra system written in pure Python","homepage":"http://sympy.org/","watchers":814,"stargazers":814,"forks":465,"fork":false,"size":150600,"owner":"sympy","private":false,"open_issues":117,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Python","created_at":"2010-04-30T13:37:14-07:00","pushed_at":"2013-09-09T23:22:45-07:00","master_branch":"master","organization":"sympy"},"actor_attributes":{"type":"User","name":"Thilina Bandara Rathnayake","location":"Sri Lanka","email":"[email protected]"},"url":"https://github.com/sympy/sympy/pull/2432#discussion_r6267127"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/sympy/sympy/pulls/comments/3307667","id":3307667,"body":"@smichr looking at the other test cases there is no spacing there.So would you like me to include it here.Thanks","diff_hunk":"@@ -3524,6 +3524,121 @@ def test_jz():\n assert qapply(TensorProduct(1,Jz)*TensorProduct(JzKet(j1,m1),JzKet(j2,m2))) == \\\n hbar*m2*TensorProduct(JzKet(j1,m1),JzKet(j2,m2))\n \n+def test_rotation():\n+ a, b, g = symbols('a b g')\n+ j, m = symbols('j m')\n+ assert qapply(Rotation(0, pi/2, 0)*JxKet(1, 1)) == (\n+ JxKet(1, -1)/2 - sqrt(2)*JxKet(1, 0)/2 + JxKet(1, 1)/2)\n+ assert qapply(Rotation(pi, pi/2, 0)*JyKet(1, 1)) == (\n+ -JyKet(1, -1)/2 + sqrt(2)*JyKet(1, 0)/2 - JyKet(1, 1)/2)\n+ assert qapply(Rotation(0, pi/2, pi)*JzKet(1, 1)) == (\n+ -JzKet(1, -1)/2 - sqrt(2)*JzKet(1, 0)/2 - JzKet(1, 1)/2)\n+ assert qapply(Rotation(pi, pi, pi)*JzKet(1, 1)) == JzKet(1, -1)\n+ assert qapply(Rotation(a, 0, pi/2)*JxKet(1, 1)) == -I*exp(-I*a)*JxKet(1, 1)\n+ assert qapply(Rotation(0, b, pi/2)*JyKet(1, 1)) == (\n+ -sqrt(2)*sin(b)*JyKet(1,0)/2 - I*cos(b)*JyKet(1,-1)/2 -\n+ I*cos(b)*JyKet(1,1)/2 + I*JyKet(1,-1)/2 - I*JyKet(1,1)/2)\n+ assert qapply(Rotation(pi/2, 0, g)*JzKet(1, 1)) == - I*exp(-I*g)*JzKet(1, 1)\n+ assert qapply(Rotation(a, b, pi/2)*JxKet(1, 1)) == (\n+ - sqrt(2)*exp(-I*a)*sin(b)*JxKet(1,0)/2 -\n+ I*exp(-I*a)*cos(b)*JxKet(1,-1)/2 - I*exp(-I*a)*cos(b)*JxKet(1,1)/2 +\n+ I*exp(-I*a)*JxKet(1,-1)/2 - I*exp(-I*a)*JxKet(1,1)/2)\n+ assert qapply(Rotation(a, pi/2, g)*JyKet(1, 1)) == (\n+ exp(-I*a)*exp(I*g)*JyKet(1,-1)/2 - sqrt(2)*exp(-I*a)*JyKet(1,0)/2 +\n+ exp(-I*a)*exp(-I*g)*JyKet(1,1)/2)\n+ assert qapply(Rotation(pi/2, b, g)*JzKet(1, 1)) == (\n+ I*exp(I*g)*cos(b)*JzKet(1,-1)/2 -\n+ I*exp(I*g)*JzKet(1,-1)/2 + sqrt(2)*I*sin(b)*JzKet(1,0)/2 -\n+ I*exp(-I*g)*cos(b)*JzKet(1,1)/2 - I*exp(-I*g)*JzKet(1,1)/2)\n+ assert qapply(Rotation(a, b, g)*JzKet(1, 1)) == (\n+ -exp(-I*a)*exp(I*g)*cos(b)*JzKet(1,-1)/2 +\n+ exp(-I*a)*exp(I*g)*JzKet(1,-1)/2 - sqrt(2)*exp(-I*a)*sin(b)*JzKet(1,0)/2\n+ + exp(-I*a)*exp(-I*g)*cos(b)*JzKet(1,1)/2 +\n+ exp(-I*a)*exp(-I*g)*JzKet(1,1)/2)\n+ assert qapply(Rotation(0, pi/2, 0)*JxKet(S(3)/2, S(1)/2)) == (\n+ sqrt(6)*JxKet(S(3)/2,S(-3)/2)/4 - sqrt(2)*JxKet(S(3)/2,S(-1)/2)/4 -\n+ sqrt(2)*JxKet(S(3)/2,S(1)/2)/4 + sqrt(6)*JxKet(S(3)/2,S(3)/2)/4)\n+ assert qapply(Rotation(pi, pi/2, 0)*JyKet(S(3)/2, S(1)/2)) == (\n+ -sqrt(6)*I*JyKet(S(3)/2,S(-3)/2)/4 + sqrt(2)*I*JyKet(S(3)/2,S(-1)/2)/4\n+ + sqrt(2)*I*JyKet(S(3)/2,S(1)/2)/4 - sqrt(6)*I*JyKet(S(3)/2,S(3)/2)/4)\n+ assert qapply(Rotation(0, pi/2, pi)*JzKet(S(1)/2, S(1)/2)) == (\n+ -sqrt(2)*I*JzKet(S(1)/2,S(-1)/2)/2 - sqrt(2)*I*JzKet(S(1)/2,S(1)/2)/2)\n+ assert qapply(Rotation(a, 0, pi/2)*JxKet(S(3)/2, S(1)/2)) == (\n+ exp(-I*pi/4)*exp(-I*a/2)*JxKet(S(3)/2,S(1)/2))\n+ assert qapply(Rotation(0, b, pi/2)*JyKet(S(1)/2, S(1)/2)) == (\n+ -exp(I*pi/4)*sin(b/2)*JyKet(S(1)/2,S(-1)/2) +\n+ exp(-I*pi/4)*cos(b/2)*JyKet(S(1)/2,S(1)/2))\n+ assert qapply(Rotation(pi/2, 0, g)*JzKet(S(5)/2, S(3)/2)) == (\n+ exp(-3*I*pi/4)*exp(-3*I*g/2)*JzKet(S(5)/2,S(3)/2))\n+ assert qapply(Rotation(a, b, pi/2)*JxKet(S(1)/2, S(1)/2)) == (\n+ - exp(I*pi/4)*exp(-I*a/2)*sin(b/2)*JxKet(S(1)/2,S(-1)/2) +\n+ exp(-I*pi/4)*exp(-I*a/2)*cos(b/2)*JxKet(S(1)/2,S(1)/2))\n+ assert qapply(Rotation(a, pi/2, g)*JyKet(S(1)/2, S(1)/2)) == (\n+ - sqrt(2)*exp(-I*a/2)*exp(I*g/2)*JyKet(S(1)/2,S(-1)/2)/2 +\n+ sqrt(2)*exp(-I*a/2)*exp(-I*g/2)*JyKet(S(1)/2,S(1)/2)/2)\n+ assert qapply(Rotation(pi/2, b, g)*JzKet(S(1)/2, S(1)/2)) == (\n+ - exp(-I*pi/4)*exp(I*g/2)*sin(b/2)*JzKet(S(1)/2,S(-1)/2) +\n+ exp(-I*pi/4)*exp(-I*g/2)*cos(b/2)*JzKet(S(1)/2,S(1)/2))\n+ assert qapply(Rotation(a, b, g)*JzKet(S(1)/2, S(1)/2)) == (\n+ - exp(-I*a/2)*exp(I*g/2)*sin(b/2)*JzKet(S(1)/2,S(-1)/2) +\n+ exp(-I*a/2)*exp(-I*g/2)*cos(b/2)*JzKet(S(1)/2,S(1)/2))\n+ assert qapply(Rotation(0, pi/2, 0)*JxKet(j, m), dummy = False) == (\n+ Sum(WignerD(j, m, mp, 0, pi/2, 0)*JxKet(j,mp), (mp, -j, j)))\n+ assert qapply(Rotation(pi, pi/2, 0)*JyKet(j, m), dummy = False) == (\n+ Sum(WignerD(j, m, mp, pi, pi/2, 0)*JyKet(j,mp), (mp, -j, j)))\n+ assert qapply(Rotation(pi, pi, pi)*JzKet(j, m), dummy = False) == (\n+ Sum(WignerD(j, m, mp, pi, pi, pi)*JzKet(j,mp), (mp, -j, j)))\n+ assert qapply(Rotation(a, 0, pi/2)*JxKet(j, m), dummy = False) == (\n+ Sum(WignerD(j, m, mp, a, 0, pi/2)*JxKet(j,mp), (mp, -j, j)))\n+ assert qapply(Rotation(0, b, pi/2)*JyKet(j, m), dummy = False) == (\n+ Sum(WignerD(j, m, mp, 0, b, pi/2)*JyKet(j,mp), (mp, -j, j)))\n+ assert qapply(Rotation(pi/2, pi, g)*JzKet(j, m), dummy = False) == (\n+ Sum(WignerD(j, m, mp, pi/2, pi, g)*JzKet(j,mp), (mp, -j, j)))\n+ assert qapply(Rotation(a, b, pi/2)*JxKet(j, m), dummy = False) == (\n+ Sum(WignerD(j, m, mp, a, b, pi/2)*JxKet(j,mp), (mp, -j, j)))\n+ assert qapply(Rotation(a, pi/2, g)*JyKet(j, m), dummy = False) == (\n+ Sum(WignerD(j, m, mp, a, pi/2, g)*JyKet(j,mp), (mp, -j, j)))\n+ assert qapply(Rotation(pi/2, b, g)*JzKet(j, m), dummy = False) == (\n+ Sum(WignerD(j, m, mp, pi/2, b, g)*JzKet(j,mp), (mp, -j, j)))\n+ assert qapply(Rotation(a, b, g)*JzKet(j, m), dummy = False) == (\n+ Sum(WignerD(j, m, mp, a, b, g)*JzKet(j,mp), (mp, -j, j)))\n+ assert qapply(Rotation(0, pi/2, 0)*JxKetCoupled(1, 1, (1,1))) == (\n+ JxKetCoupled(1,-1,(1,1))/2 - sqrt(2)*JxKetCoupled(1,0,(1,1))/2 +\n+ JxKetCoupled(1,1,(1,1))/2)\n+ assert qapply(Rotation(0, pi, pi/2)*JyKetCoupled(1, 1, (1,1))) == (\n+ I*JyKetCoupled(1,-1,(1,1)))\n+ assert qapply(Rotation(0, pi, pi)*JzKetCoupled(1,1,(1,1))) == (\n+ -JzKetCoupled(1,-1,(1,1)))\n+ assert qapply(Rotation(a, 0, pi)*JxKetCoupled(1,1,(1,1))) == (\n+ -exp(-I*a)*JxKetCoupled(1,1,(1,1)))\n+ assert qapply(Rotation(a, b, pi)*JyKetCoupled(1,1,(1,1))) == (\n+ -sqrt(2)*exp(-I*a)*sin(b)*JyKetCoupled(1,0,(1,1))/2 +\n+ exp(-I*a)*cos(b)*JyKetCoupled(1,-1,(1,1))/2 -\n+ exp(-I*a)*cos(b)*JyKetCoupled(1,1,(1,1))/2 -\n+ exp(-I*a)*JyKetCoupled(1,-1,(1,1))/2 -\n+ exp(-I*a)*JyKetCoupled(1,1,(1,1))/2)\n+ assert qapply(Rotation(a,b,g)*JzKetCoupled(1,1,(1,1))) == (\n+ -exp(-I*a)*exp(I*g)*cos(b)*JzKetCoupled(1,-1,(1,1))/2 +\n+ exp(-I*a)*exp(I*g)*JzKetCoupled(1,-1,(1,1))/2 -\n+ sqrt(2)*exp(-I*a)*sin(b)*JzKetCoupled(1,0,(1,1))/2 +\n+ exp(-I*a)*exp(-I*g)*cos(b)*JzKetCoupled(1,1,(1,1))/2 +\n+ exp(-I*a)*exp(-I*g)*JzKetCoupled(1,1,(1,1))/2)\n+ assert qapply(Rotation(0, pi/2, 0)*JzKetCoupled(1,1,(S(3)/2,S(1)/2))) == (\n+ JzKetCoupled(1,-1,(S(3)/2,S(1)/2))/2 -\n+ sqrt(2)*JzKetCoupled(1,0,(S(3)/2,S(1)/2))/2 +\n+ JzKetCoupled(1,1,(S(3)/2,S(1)/2))/2)\n+ assert qapply(Rotation(0, pi/2, 0)*JyKetCoupled(1,1,(j1,j2))) == (\n+ JyKetCoupled(1,-1,(j1,j2))/2 - sqrt(2)*JyKetCoupled(1,0,(j1,j2))/2 +\n+ JyKetCoupled(1,1,(j1,j2))/2)\n+ assert qapply(Rotation(a, b, g)*JxKetCoupled(1,1,(j1,j2))) == (\n+ -exp(-I*a)*exp(I*g)*cos(b)*JxKetCoupled(1,-1,(j1,j2))/2 +\n+ exp(-I*a)*exp(I*g)*JxKetCoupled(1,-1,(j1,j2))/2 -","path":"sympy/physics/quantum/tests/test_spin.py","position":119,"original_position":119,"commit_id":"142f5c9b2fb2c381922ab6ba6ef7f0111d678bdc","original_commit_id":"142f5c9b2fb2c381922ab6ba6ef7f0111d678bdc","user":{"login":"amitjamadagni","id":1212282,"avatar_url":"https://secure.gravatar.com/avatar/60b93135d3f29bfedb4594542703e4ad?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"60b93135d3f29bfedb4594542703e4ad","url":"https://api.github.com/users/amitjamadagni","html_url":"https://github.com/amitjamadagni","followers_url":"https://api.github.com/users/amitjamadagni/followers","following_url":"https://api.github.com/users/amitjamadagni/following","gists_url":"https://api.github.com/users/amitjamadagni/gists{/gist_id}","starred_url":"https://api.github.com/users/amitjamadagni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amitjamadagni/subscriptions","organizations_url":"https://api.github.com/users/amitjamadagni/orgs","repos_url":"https://api.github.com/users/amitjamadagni/repos","events_url":"https://api.github.com/users/amitjamadagni/events{/privacy}","received_events_url":"https://api.github.com/users/amitjamadagni/received_events","type":"User"},"created_at":"2013-03-09T09:25:12Z","updated_at":"2013-03-09T09:25:12Z","html_url":"https://github.com/sympy/sympy/pull/1834#discussion_r3307667","pull_request_url":"https://api.github.com/repos/sympy/sympy/pulls/1834","_links":{"self":{"href":"https://api.github.com/repos/sympy/sympy/pulls/comments/3307667"},"html":{"href":"https://github.com/sympy/sympy/pull/1834#discussion_r3307667"},"pull_request":{"href":"https://api.github.com/repos/sympy/sympy/pulls/1834"}}}} | {
"id": 640534,
"name": "sympy",
"url": "https://github.com/sympy/sympy"
} | {
"id": null,
"login": "amitjamadagni",
"gravatar_id": "60b93135d3f29bfedb4594542703e4ad",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "sympy",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-03-09T09:25:12 | null | {"repository":{"description":"A computer algebra system written in pure Python","homepage":"http://sympy.org/","watchers":642,"stargazers":642,"forks":360,"fork":false,"size":7340,"owner":"sympy","private":false,"open_issues":70,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Python","created_at":"2010-04-30T13:37:14-07:00","pushed_at":"2013-03-08T04:32:29-08:00","master_branch":"master","organization":"sympy"},"actor_attributes":{"type":"User","name":"Amit","email":"[email protected]"},"url":"https://github.com/sympy/sympy/pull/1834#discussion_r3307667"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/sympy/sympy/pulls/comments/8354233","id":8354233,"diff_hunk":"@@ -0,0 +1,128 @@\n+from sympy.core.add import Add\n+from sympy.core.basic import Basic\n+from sympy.core.expr import Expr\n+from sympy.core.mul import Mul\n+from sympy.core.numbers import Integer\n+from sympy.core.singleton import S\n+from sympy.core.symbol import symbols\n+from sympy.utilities.pytest import raises\n+\n+from sympy.core.dispatch import dispatch\n+\n+\n+def test_dispatch_on_sympy_objects():\n+ @dispatch(str)\n+ def f(a):\n+ return a*3\n+\n+ @dispatch(int)\n+ def f(b):\n+ return \"integer value: {}\".format(b)\n+\n+ @dispatch(int, int)\n+ def f(a, b):\n+ return \"two integers: {}, {}\".format(a, b)\n+\n+ @dispatch(Basic)\n+ def g(a):\n+ return \"Basic\"\n+\n+ @dispatch(Expr)\n+ def g(a):\n+ return \"Expr\"\n+\n+ @dispatch(Integer)\n+ def g(a):\n+ return \"Integer\"\n+\n+ assert g(S.One) == \"Integer\"\n+ assert g(Integer(2)/2) == \"Integer\"\n+ x = symbols('x')\n+ assert g(x) == \"Expr\"\n+ # assert g(x**2+1) == \"Expr\"\n+\n+ @dispatch(Add)\n+ def g(a):\n+ return \"Add\"\n+\n+ assert g(x**2+1) == \"Add\"\n+ assert f(\"triple this \") == \"triple this triple this triple this \"\n+ assert f(34) == \"integer value: 34\"\n+ assert f(3, 444) == \"two integers: 3, 444\"\n+ raises(TypeError, lambda: f(\"her\", 32))\n+\n+\n+def test_intertwined_inheritances():\n+ class DispTestA(object): pass\n+ class DispTestB(object): pass\n+ class DispTestA1(DispTestA): pass\n+ class DispTestA2(DispTestA): pass\n+ class DispTestB1(DispTestB): pass\n+ class DispTestAB(DispTestA, DispTestB): pass\n+ class DispTestAB1(DispTestAB): pass\n+ class DispTestAB2(DispTestAB): pass\n+ class DispTestAB12(DispTestAB1, DispTestAB2): pass\n+\n+ @dispatch(DispTestAB1, object)\n+ def dispfu(a, b):\n+ return (DispTestAB1, object)\n+\n+ @dispatch(object, DispTestAB1)\n+ def dispfu(a, b):\n+ return (object, DispTestAB1)\n+\n+ @dispatch(DispTestA, DispTestB)\n+ def dispfu(a, b):\n+ return (DispTestA, DispTestB)\n+\n+ @dispatch(DispTestA)\n+ def dispfu(a):\n+ return (DispTestA)\n+\n+ @dispatch(DispTestB)\n+ def dispfu(a):\n+ return (DispTestB)\n+\n+ def assert_list1():\n+ assert dispfu(DispTestAB1(), DispTestAB1()) == (DispTestAB1, object)","path":"sympy/core/tests/test_dispatch.py","position":87,"original_position":87,"commit_id":"db220a317bcb7e5a68e440c2c1c3a7a22c4e9dfe","original_commit_id":"db220a317bcb7e5a68e440c2c1c3a7a22c4e9dfe","user":{"login":"Upabjojr","id":4128856,"avatar_url":"https://gravatar.com/avatar/4269396616e7d6f6ac94558b4bfa7717?d=https%3A%2F%2Fidenticons.github.com%2Fb18737a65bda5740f801daa568d541b3.png&r=x","gravatar_id":"4269396616e7d6f6ac94558b4bfa7717","url":"https://api.github.com/users/Upabjojr","html_url":"https://github.com/Upabjojr","followers_url":"https://api.github.com/users/Upabjojr/followers","following_url":"https://api.github.com/users/Upabjojr/following{/other_user}","gists_url":"https://api.github.com/users/Upabjojr/gists{/gist_id}","starred_url":"https://api.github.com/users/Upabjojr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Upabjojr/subscriptions","organizations_url":"https://api.github.com/users/Upabjojr/orgs","repos_url":"https://api.github.com/users/Upabjojr/repos","events_url":"https://api.github.com/users/Upabjojr/events{/privacy}","received_events_url":"https://api.github.com/users/Upabjojr/received_events","type":"User","site_admin":false},"body":"This is an ambiguous match, because both `(DispTestAB1, object)` and `(object, DispTestAB1)` would match it, with the same degree of subclass specificity. My solution was to privilege the first argument specificity. (By specificity I mean the choice of lowest subclass).","created_at":"2013-12-15T08:25:36Z","updated_at":"2013-12-15T08:25:36Z","html_url":"https://github.com/sympy/sympy/pull/2680#discussion_r8354233","pull_request_url":"https://api.github.com/repos/sympy/sympy/pulls/2680","_links":{"self":{"href":"https://api.github.com/repos/sympy/sympy/pulls/comments/8354233"},"html":{"href":"https://github.com/sympy/sympy/pull/2680#discussion_r8354233"},"pull_request":{"href":"https://api.github.com/repos/sympy/sympy/pulls/2680"}}}} | {
"id": 640534,
"name": "sympy",
"url": "https://github.com/sympy/sympy"
} | {
"id": null,
"login": "Upabjojr",
"gravatar_id": "4269396616e7d6f6ac94558b4bfa7717",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "sympy",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-12-15T08:25:36 | null | {"repository":{"description":"A computer algebra system written in pure Python","homepage":"http://sympy.org/","watchers":884,"stargazers":884,"forks":517,"fork":false,"size":158206,"owner":"sympy","private":false,"open_issues":152,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Python","created_at":"2010-04-30T13:37:14-07:00","pushed_at":"2013-12-14T23:25:02-08:00","master_branch":"master","organization":"sympy"},"actor_attributes":{"type":"User","name":"Francesco Bonazzi","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/sympy/sympy/pull/2680#discussion_r8354233"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/wajam/scala-commons/pulls/comments/8586171","id":8586171,"diff_hunk":"@@ -0,0 +1,94 @@\n+package com.wajam.gearman\n+\n+import org.scalatest.BeforeAndAfterAll\n+import org.scalatest.matchers.ShouldMatchers\n+import scala.concurrent.{Await, ExecutionContext}\n+import java.util.concurrent.{TimeoutException, Executors}\n+import com.wajam.gearman.impl.AsyncWajamGearmanClient\n+import scala.util.{Failure, Success}\n+import com.wajam.gearman.exception.{JobSubmissionException, JobExecutionException}\n+import scala.concurrent.duration._\n+\n+class TestWajamGearmanClient extends GearmanIntegrationTest with ShouldMatchers with BeforeAndAfterAll {\n+\n+ implicit val ec = ExecutionContext.fromExecutorService(Executors.newFixedThreadPool(10))\n+\n+ val client: WajamGearmanClient = new AsyncWajamGearmanClient(Seq(\"127.0.0.1\"))\n+\n+ val notWorkingClient: WajamGearmanClient = new AsyncWajamGearmanClient(Seq(\"nowhere.does.not.exist.nothing.none\"))\n+\n+ \"Working client\" should \"not fail when executeJob success data\" in {\n+ val data = Map(\"success\" -> \"success\")\n+ val f = client.executeJob(TEST_FUNCTION_NAME, data)\n+ f.onComplete {\n+ case Success(v) => data should equal(v)\n+ case Failure(e) => fail(\"Success data should return a success\")\n+ }\n+ Await.ready(f, 2.seconds)\n+ }\n+\n+ \"Working client\" should \"fail when executeJob fail data\" in {\n+ val data = Map(\"fail\" -> \"fail\")\n+ val f = client.executeJob(TEST_FUNCTION_NAME, data)\n+ f.onComplete {\n+ case Success(v) => fail(\"Fail data should return a failure\")\n+ case Failure(e) => evaluating {\n+ throw e\n+ } should produce[JobExecutionException]\n+ }\n+ Await.ready(f, 2.seconds)\n+ }\n+\n+ \"Working client\" should \"not fail when enqueueJob success data\" in {\n+ val data = Map(\"success\" -> \"success\")\n+ val f = client.enqueueJob(TEST_FUNCTION_NAME, data)\n+ f.onComplete {\n+ case Success(v) => data should equal(v)\n+ case Failure(e) => fail(\"Success data should return a success\")\n+ }\n+ Await.ready(f, 2.seconds)\n+ }\n+\n+ \"Working client\" should \"not fail when enqueueJob fail data\" in {\n+ val data = Map(\"fail\" -> \"fail\")\n+ val f = client.enqueueJob(TEST_FUNCTION_NAME, data)\n+ f.onComplete {\n+ case Success(v) => data should equal(v)\n+ case Failure(e) => fail(\"Success data should return a success\")\n+ }\n+ Await.ready(f, 2.seconds)\n+ }\n+\n+ \"Non working client\" should \"throw exception on first queuing/execute and then queue all others without executing them\" in {\n+ val data = Map(\"success\" -> \"success\")\n+\n+ val f1 = notWorkingClient.executeJob(TEST_FUNCTION_NAME, data)\n+ f1.onComplete {\n+ case Success(v) => fail(\"Success data should return a failure\")\n+ case Failure(e) => evaluating {\n+ throw e\n+ } should produce[JobSubmissionException]\n+ }\n+ Await.ready(f1, 2.seconds)\n+\n+ val f2 = notWorkingClient.executeJob(TEST_FUNCTION_NAME, data)\n+ evaluating {\n+ Await.ready(f2, 2.seconds)\n+ } should produce[TimeoutException]\n+\n+ val f3 = notWorkingClient.enqueueJob(TEST_FUNCTION_NAME, data)\n+ evaluating {\n+ Await.ready(f3, 2.seconds)\n+ } should produce[TimeoutException]\n+ }\n+\n+ override def beforeAll() = {\n+ super.beforeAll()\n+ }","path":"commons-gearman/src/it/scala/com/wajam/gearman/TestWajamGearmanClient.scala","position":87,"original_position":87,"commit_id":"0ccdb2cde9ff3793281ec6967a94882ca5e7e54c","original_commit_id":"0ccdb2cde9ff3793281ec6967a94882ca5e7e54c","user":{"login":"alexbergeron","id":1641227,"avatar_url":"https://gravatar.com/avatar/c19e9b93baae544e163f3983172a3ca8?d=https%3A%2F%2Fidenticons.github.com%2F322f3e9adcd6585464e5d086b03c4bd2.png&r=x","gravatar_id":"c19e9b93baae544e163f3983172a3ca8","url":"https://api.github.com/users/alexbergeron","html_url":"https://github.com/alexbergeron","followers_url":"https://api.github.com/users/alexbergeron/followers","following_url":"https://api.github.com/users/alexbergeron/following{/other_user}","gists_url":"https://api.github.com/users/alexbergeron/gists{/gist_id}","starred_url":"https://api.github.com/users/alexbergeron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexbergeron/subscriptions","organizations_url":"https://api.github.com/users/alexbergeron/orgs","repos_url":"https://api.github.com/users/alexbergeron/repos","events_url":"https://api.github.com/users/alexbergeron/events{/privacy}","received_events_url":"https://api.github.com/users/alexbergeron/received_events","type":"User","site_admin":false},"body":"useless","created_at":"2013-12-30T15:43:45Z","updated_at":"2013-12-30T15:43:45Z","html_url":"https://github.com/wajam/scala-commons/pull/29#discussion_r8586171","pull_request_url":"https://api.github.com/repos/wajam/scala-commons/pulls/29","_links":{"self":{"href":"https://api.github.com/repos/wajam/scala-commons/pulls/comments/8586171"},"html":{"href":"https://github.com/wajam/scala-commons/pull/29#discussion_r8586171"},"pull_request":{"href":"https://api.github.com/repos/wajam/scala-commons/pulls/29"}}}} | {
"id": 12952521,
"name": "scala-commons",
"url": "https://github.com/wajam/scala-commons"
} | {
"id": null,
"login": "alexbergeron",
"gravatar_id": "c19e9b93baae544e163f3983172a3ca8",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "wajam",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-12-30T15:43:45 | null | {"repository":{"description":"","watchers":0,"stargazers":0,"forks":0,"fork":false,"size":1584,"owner":"wajam","private":false,"open_issues":2,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Scala","created_at":"2013-09-19T08:48:59-07:00","pushed_at":"2013-12-27T13:39:11-08:00","master_branch":"master","organization":"wajam"},"actor_attributes":{"type":"User","name":"Alexandre Bergeron","company":"Wajam","location":"Montreal","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/wajam/scala-commons/pull/29#discussion_r8586171"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/wajam/nrv/pulls/comments/4344237","id":4344237,"body":"I think these two lines should be in DynamicClusterManager and only the code related to Zookeeper (i.e. the delete) should be in this class","diff_hunk":"@@ -145,6 +144,25 @@ class ZookeeperClusterManager(val zk: ZookeeperClient) extends DynamicClusterMan\n ServiceMemberVote.fromString(candidateMember, data)\n }\n \n+ protected def removeOldServiceMember(service: Service, oldServiceMember: ServiceMember) = {\n+ if (cluster.isLocalNode(oldServiceMember.node)) {\n+ //removing the memeber's own vote here, allowing the member's status to change\n+ //TODO: we assume the node is voting for itself, this may change when consensus is implemented.\n+ val path = ZookeeperClusterManager.zkMemberVotePath(service.name, oldServiceMember.token, oldServiceMember.token)\n+ zk.delete(path)\n+ }\n+ val event = oldServiceMember.setStatus(MemberStatus.Down, triggerEvent = true)\n+ service.removeMember(oldServiceMember)","path":"nrv-zookeeper/src/main/scala/com/wajam/nrv/zookeeper/cluster/ZookeeperClusterManager.scala","position":29,"original_position":29,"commit_id":"5a312e669d22554af5a237416a32090b9ed9d43b","original_commit_id":"5a312e669d22554af5a237416a32090b9ed9d43b","user":{"login":"mlaflamm","id":269187,"avatar_url":"https://secure.gravatar.com/avatar/8f8efe5f0b65ef96ef5266b835d92105?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"8f8efe5f0b65ef96ef5266b835d92105","url":"https://api.github.com/users/mlaflamm","html_url":"https://github.com/mlaflamm","followers_url":"https://api.github.com/users/mlaflamm/followers","following_url":"https://api.github.com/users/mlaflamm/following{/other_user}","gists_url":"https://api.github.com/users/mlaflamm/gists{/gist_id}","starred_url":"https://api.github.com/users/mlaflamm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlaflamm/subscriptions","organizations_url":"https://api.github.com/users/mlaflamm/orgs","repos_url":"https://api.github.com/users/mlaflamm/repos","events_url":"https://api.github.com/users/mlaflamm/events{/privacy}","received_events_url":"https://api.github.com/users/mlaflamm/received_events","type":"User"},"created_at":"2013-05-22T17:42:12Z","updated_at":"2013-05-22T17:42:12Z","html_url":"https://github.com/wajam/nrv/pull/174#discussion_r4344237","pull_request_url":"https://api.github.com/repos/wajam/nrv/pulls/174","_links":{"self":{"href":"https://api.github.com/repos/wajam/nrv/pulls/comments/4344237"},"html":{"href":"https://github.com/wajam/nrv/pull/174#discussion_r4344237"},"pull_request":{"href":"https://api.github.com/repos/wajam/nrv/pulls/174"}}}} | {
"id": 3846863,
"name": "nrv",
"url": "https://github.com/wajam/nrv"
} | {
"id": null,
"login": "mlaflamm",
"gravatar_id": "8f8efe5f0b65ef96ef5266b835d92105",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "wajam",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-05-22T17:42:12 | null | {"repository":{"description":"Fault-tolerant, cluster aware RPC framework","homepage":"","watchers":6,"stargazers":6,"forks":2,"fork":false,"size":1164,"owner":"wajam","private":false,"open_issues":1,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Scala","created_at":"2012-03-27T11:14:22-07:00","pushed_at":"2013-05-22T10:39:16-07:00","master_branch":"master","organization":"wajam"},"actor_attributes":{"type":"User","name":"Manuel Laflamme","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/wajam/nrv/pull/174#discussion_r4344237"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/xwiki/xwiki-platform/pulls/comments/6888623","id":6888623,"diff_hunk":"@@ -602,4 +602,12 @@ rendering.transformations = $xwikiRenderingTransformations\n #-# The default is:\n # activeinstalls.pingURL=http://extensions.xwiki.org/activeinstalls\n \n+#-------------------------------------------------------------------------------------\n+# Activity Stream\n+#-------------------------------------------------------------------------------------\n+\n+#-# [Since 5.3M1]\n+#-# A list of full qualified class names or events that the activity stream should ignore\n+activitystream.ignoredEvents=org.xwiki.bridge.event.WikiCreatingEvent,com.xpn.xwiki.internal.event.XARImportingEvent","path":"xwiki-platform-tools/xwiki-platform-tool-configuration-resources/src/main/resources/xwiki.properties.vm","position":10,"original_position":10,"commit_id":"e28e27f84be556d4411d7ec52732a548ebf1c599","original_commit_id":"e28e27f84be556d4411d7ec52732a548ebf1c599","user":{"login":"sdumitriu","id":88663,"avatar_url":"https://2.gravatar.com/avatar/8db1702678f2612f46f07eff86101f85?d=https%3A%2F%2Fidenticons.github.com%2F3707683e1b428db11aa97b12df8fdc1d.png","gravatar_id":"8db1702678f2612f46f07eff86101f85","url":"https://api.github.com/users/sdumitriu","html_url":"https://github.com/sdumitriu","followers_url":"https://api.github.com/users/sdumitriu/followers","following_url":"https://api.github.com/users/sdumitriu/following{/other_user}","gists_url":"https://api.github.com/users/sdumitriu/gists{/gist_id}","starred_url":"https://api.github.com/users/sdumitriu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdumitriu/subscriptions","organizations_url":"https://api.github.com/users/sdumitriu/orgs","repos_url":"https://api.github.com/users/sdumitriu/repos","events_url":"https://api.github.com/users/sdumitriu/events{/privacy}","received_events_url":"https://api.github.com/users/sdumitriu/received_events","type":"User","site_admin":false},"body":"Most of the settings in this file are commented out, with the default value set just as an example.","created_at":"2013-10-10T14:44:33Z","updated_at":"2013-10-10T14:44:33Z","html_url":"https://github.com/xwiki/xwiki-platform/pull/188#discussion_r6888623","pull_request_url":"https://api.github.com/repos/xwiki/xwiki-platform/pulls/188","_links":{"self":{"href":"https://api.github.com/repos/xwiki/xwiki-platform/pulls/comments/6888623"},"html":{"href":"https://github.com/xwiki/xwiki-platform/pull/188#discussion_r6888623"},"pull_request":{"href":"https://api.github.com/repos/xwiki/xwiki-platform/pulls/188"}}}} | {
"id": 1463490,
"name": "xwiki-platform",
"url": "https://github.com/xwiki/xwiki-platform"
} | {
"id": null,
"login": "sdumitriu",
"gravatar_id": "8db1702678f2612f46f07eff86101f85",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "xwiki",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-10-10T14:44:33 | null | {"repository":{"description":"The XWiki platform","homepage":"http://platform.xwiki.org/","watchers":69,"stargazers":69,"forks":86,"fork":false,"size":492189,"owner":"xwiki","private":false,"open_issues":30,"has_issues":false,"has_downloads":true,"has_wiki":false,"language":"Java","created_at":"2011-03-10T05:26:41-08:00","pushed_at":"2013-10-10T06:09:43-07:00","master_branch":"master","organization":"xwiki"},"actor_attributes":{"type":"User","name":"Sergiu Dumitriu","company":"","blog":"http://purl.org/net/sergiu/","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/xwiki/xwiki-platform/pull/188#discussion_r6888623"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/yahoo/mojito/pulls/comments/4688801","id":4688801,"body":"probably you can check `ac.data.get('foo')` and aggregate it to `mydata` value so you can test the flow of the data where `foo` is only set from client side, and travels to server and back to client (probably modified or aggregated).","diff_hunk":"@@ -0,0 +1,15 @@\n+YUI.add('LazyLoadRPC', function(Y, NAME) {\n+\n+ Y.namespace('mojito.controllers')[NAME] = {\n+ \n+ index: function(ac) {\n+ ac.done();\n+ },\n+\n+ lazyloadrpc: function(ac) {\n+ ac.data.set('mydata', \"mydatavalue\");","path":"tests/func/applications/frameworkapp/common/mojits/LazyLoadRPC/controller.server.js","position":10,"original_position":10,"commit_id":"463f94618872a09cb879b895f8e290926f65b8f7","original_commit_id":"463f94618872a09cb879b895f8e290926f65b8f7","user":{"login":"caridy","id":38969,"avatar_url":"https://secure.gravatar.com/avatar/fef48709416e18e4ccb263b248fd88e1?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"fef48709416e18e4ccb263b248fd88e1","url":"https://api.github.com/users/caridy","html_url":"https://github.com/caridy","followers_url":"https://api.github.com/users/caridy/followers","following_url":"https://api.github.com/users/caridy/following{/other_user}","gists_url":"https://api.github.com/users/caridy/gists{/gist_id}","starred_url":"https://api.github.com/users/caridy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caridy/subscriptions","organizations_url":"https://api.github.com/users/caridy/orgs","repos_url":"https://api.github.com/users/caridy/repos","events_url":"https://api.github.com/users/caridy/events{/privacy}","received_events_url":"https://api.github.com/users/caridy/received_events","type":"User"},"created_at":"2013-06-13T20:22:51Z","updated_at":"2013-06-13T20:22:51Z","html_url":"https://github.com/yahoo/mojito/pull/1168#discussion_r4688801","pull_request_url":"https://api.github.com/repos/yahoo/mojito/pulls/1168","_links":{"self":{"href":"https://api.github.com/repos/yahoo/mojito/pulls/comments/4688801"},"html":{"href":"https://github.com/yahoo/mojito/pull/1168#discussion_r4688801"},"pull_request":{"href":"https://api.github.com/repos/yahoo/mojito/pulls/1168"}}}} | {
"id": 3869830,
"name": "mojito",
"url": "https://github.com/yahoo/mojito"
} | {
"id": null,
"login": "caridy",
"gravatar_id": "fef48709416e18e4ccb263b248fd88e1",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "yahoo",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-06-13T20:22:51 | null | {"repository":{"description":"Yahoo! Mojito Framework","homepage":"","watchers":1387,"stargazers":1387,"forks":209,"fork":false,"size":12952,"owner":"yahoo","private":false,"open_issues":53,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"JavaScript","created_at":"2012-03-29T12:41:48-07:00","pushed_at":"2013-06-12T13:31:06-07:00","master_branch":"develop","organization":"yahoo"},"actor_attributes":{"type":"User","name":"Caridy Patino","company":"Yahoo! Inc.","blog":"http://caridy.name/","location":"Miami, FL.","email":"[email protected]"},"url":"https://github.com/yahoo/mojito/pull/1168#discussion_r4688801"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/yahoo/express-yui/pulls/comments/4600133","id":4600133,"body":"to maintain parity with the groups, we now also add the yui `version` as part of the path.","diff_hunk":"@@ -264,14 +265,14 @@ module.exports = {\n \n // first, yui core if it is marked as local\n if (config.local) {\n- handlers.push(combo.folder('yui', yui.path, options));\n+ handlers.push(combo.folder('yui-' + yui.version, yui.path, options));","path":"lib/middleware.js","position":22,"original_position":22,"commit_id":"e03035cd53a337ef3f51a2adca77306b2ba6325d","original_commit_id":"e03035cd53a337ef3f51a2adca77306b2ba6325d","user":{"login":"caridy","id":38969,"avatar_url":"https://secure.gravatar.com/avatar/fef48709416e18e4ccb263b248fd88e1?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"fef48709416e18e4ccb263b248fd88e1","url":"https://api.github.com/users/caridy","html_url":"https://github.com/caridy","followers_url":"https://api.github.com/users/caridy/followers","following_url":"https://api.github.com/users/caridy/following{/other_user}","gists_url":"https://api.github.com/users/caridy/gists{/gist_id}","starred_url":"https://api.github.com/users/caridy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caridy/subscriptions","organizations_url":"https://api.github.com/users/caridy/orgs","repos_url":"https://api.github.com/users/caridy/repos","events_url":"https://api.github.com/users/caridy/events{/privacy}","received_events_url":"https://api.github.com/users/caridy/received_events","type":"User"},"created_at":"2013-06-08T00:38:42Z","updated_at":"2013-06-08T00:38:42Z","html_url":"https://github.com/yahoo/express-yui/pull/8#discussion_r4600133","pull_request_url":"https://api.github.com/repos/yahoo/express-yui/pulls/8","_links":{"self":{"href":"https://api.github.com/repos/yahoo/express-yui/pulls/comments/4600133"},"html":{"href":"https://github.com/yahoo/express-yui/pull/8#discussion_r4600133"},"pull_request":{"href":"https://api.github.com/repos/yahoo/express-yui/pulls/8"}}}} | {
"id": 9967895,
"name": "express-yui",
"url": "https://github.com/yahoo/express-yui"
} | {
"id": null,
"login": "caridy",
"gravatar_id": "fef48709416e18e4ccb263b248fd88e1",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "yahoo",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-06-08T00:38:42 | null | {"repository":{"description":"Express extension for YUI Applications.","watchers":1,"stargazers":1,"forks":2,"fork":false,"size":224,"owner":"yahoo","private":false,"open_issues":4,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"JavaScript","created_at":"2013-05-09T13:34:25-07:00","pushed_at":"2013-05-30T09:29:04-07:00","master_branch":"master","organization":"yahoo"},"actor_attributes":{"type":"User","name":"Caridy Patino","company":"Yahoo! Inc.","blog":"http://caridy.name/","location":"Miami, FL.","email":"[email protected]"},"url":"https://github.com/yahoo/express-yui/pull/8#discussion_r4600133"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/AMPATH/openmrs-module-amrsreports/pulls/comments/4304684","id":4304684,"body":"insert a comment here noting the column letter, similar to other columns","diff_hunk":"@@ -82,6 +79,15 @@ public ReportDefinition getReportDefinition() {\n \t\tAgeAtEvaluationDateDataDefinition add = new AgeAtEvaluationDateDataDefinition();\n \t\tdsd.addColumn(\"Age\", add, nullString, new DecimalAgeConverter(2));\n \n+ PreferredAddressDataDefinition padd = new PreferredAddressDataDefinition();","path":"api/src/main/java/org/openmrs/module/amrsreports/reporting/provider/MOH361BReportProvider.java","position":33,"original_position":33,"commit_id":"b7efc173157615332f65396e6e8202d1c6ccf1ac","original_commit_id":"b7efc173157615332f65396e6e8202d1c6ccf1ac","user":{"login":"jlkeiper","id":857071,"avatar_url":"https://secure.gravatar.com/avatar/e5027bd347048bc7fbe79bf793f07cb4?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"e5027bd347048bc7fbe79bf793f07cb4","url":"https://api.github.com/users/jlkeiper","html_url":"https://github.com/jlkeiper","followers_url":"https://api.github.com/users/jlkeiper/followers","following_url":"https://api.github.com/users/jlkeiper/following{/other_user}","gists_url":"https://api.github.com/users/jlkeiper/gists{/gist_id}","starred_url":"https://api.github.com/users/jlkeiper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlkeiper/subscriptions","organizations_url":"https://api.github.com/users/jlkeiper/orgs","repos_url":"https://api.github.com/users/jlkeiper/repos","events_url":"https://api.github.com/users/jlkeiper/events{/privacy}","received_events_url":"https://api.github.com/users/jlkeiper/received_events","type":"User"},"created_at":"2013-05-20T20:25:17Z","updated_at":"2013-05-20T20:25:17Z","html_url":"https://github.com/AMPATH/openmrs-module-amrsreports/pull/66#discussion_r4304684","pull_request_url":"https://api.github.com/repos/AMPATH/openmrs-module-amrsreports/pulls/66","_links":{"self":{"href":"https://api.github.com/repos/AMPATH/openmrs-module-amrsreports/pulls/comments/4304684"},"html":{"href":"https://github.com/AMPATH/openmrs-module-amrsreports/pull/66#discussion_r4304684"},"pull_request":{"href":"https://api.github.com/repos/AMPATH/openmrs-module-amrsreports/pulls/66"}}}} | {
"id": 5444163,
"name": "openmrs-module-amrsreports",
"url": "https://github.com/AMPATH/openmrs-module-amrsreports"
} | {
"id": null,
"login": "jlkeiper",
"gravatar_id": "e5027bd347048bc7fbe79bf793f07cb4",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "AMPATH",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-05-20T20:25:17 | null | {"repository":{"description":"","watchers":0,"stargazers":0,"forks":5,"fork":false,"size":448,"owner":"AMPATH","private":false,"open_issues":2,"has_issues":false,"has_downloads":true,"has_wiki":false,"language":"JavaScript","created_at":"2012-08-16T13:24:29-07:00","pushed_at":"2013-05-13T12:04:42-07:00","master_branch":"master","organization":"AMPATH"},"actor_attributes":{"type":"User","name":"Jeremy Keiper","company":"AMPATH","location":"Indianapolis, IN","email":"[email protected]"},"url":"https://github.com/AMPATH/openmrs-module-amrsreports/pull/66#discussion_r4304684"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/Bukkit/CraftBukkit/pulls/comments/6762033","id":6762033,"body":"I did it, but I was thinking that maybe it would make sense to only validate if the player is getting banned as that is the only time the values are getting used.\r\n\r\nJust wanted to run that past you....","diff_hunk":"@@ -63,13 +63,22 @@ public boolean isBanned() {\n }\n \n public void setBanned(boolean value) {\n+ setBanned(value, \"(Unknown)\", \"Banned\");\n+ }\n+\n+ public void setBanned(boolean value, String banner) {\n+ setBanned(value, banner, \"Banned\");\n+ }\n+\n+ public void setBanned(boolean value, String banner, String reason) {\n if (value) {\n BanEntry entry = new BanEntry(name.toLowerCase());\n+ entry.setReason(reason);","path":"src/main/java/org/bukkit/craftbukkit/CraftOfflinePlayer.java","position":null,"original_position":14,"commit_id":"11c79c2ae38deb68c891b7766bcb56f9e38e16df","original_commit_id":"6f089fb4b10746febca1eb9ee1aaf0471511dd4c","user":{"login":"hawks008","id":1396368,"avatar_url":"https://2.gravatar.com/avatar/3c52f2aa222b7bd4204322f9eed027aa?d=https%3A%2F%2Fidenticons.github.com%2F73f2113c95cdf5d94dc043900c381d5d.png","gravatar_id":"3c52f2aa222b7bd4204322f9eed027aa","url":"https://api.github.com/users/hawks008","html_url":"https://github.com/hawks008","followers_url":"https://api.github.com/users/hawks008/followers","following_url":"https://api.github.com/users/hawks008/following{/other_user}","gists_url":"https://api.github.com/users/hawks008/gists{/gist_id}","starred_url":"https://api.github.com/users/hawks008/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hawks008/subscriptions","organizations_url":"https://api.github.com/users/hawks008/orgs","repos_url":"https://api.github.com/users/hawks008/repos","events_url":"https://api.github.com/users/hawks008/events{/privacy}","received_events_url":"https://api.github.com/users/hawks008/received_events","type":"User"},"created_at":"2013-10-04T07:35:28Z","updated_at":"2013-10-04T07:35:28Z","html_url":"https://github.com/Bukkit/CraftBukkit/pull/1250#discussion_r6762033","pull_request_url":"https://api.github.com/repos/Bukkit/CraftBukkit/pulls/1250","_links":{"self":{"href":"https://api.github.com/repos/Bukkit/CraftBukkit/pulls/comments/6762033"},"html":{"href":"https://github.com/Bukkit/CraftBukkit/pull/1250#discussion_r6762033"},"pull_request":{"href":"https://api.github.com/repos/Bukkit/CraftBukkit/pulls/1250"}}}} | {
"id": 1215253,
"name": "CraftBukkit",
"url": "https://github.com/Bukkit/CraftBukkit"
} | {
"id": null,
"login": "hawks008",
"gravatar_id": "3c52f2aa222b7bd4204322f9eed027aa",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "Bukkit",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-10-04T07:35:28 | null | {"repository":{"description":"The Minecraft Server Mod API Implementation","homepage":"http://bukkit.org","watchers":1895,"stargazers":1895,"forks":1194,"fork":false,"size":15569,"owner":"Bukkit","private":false,"open_issues":74,"has_issues":false,"has_downloads":true,"has_wiki":true,"language":"Java","created_at":"2011-01-02T16:10:05-08:00","pushed_at":"2013-09-20T07:15:28-07:00","master_branch":"master","organization":"Bukkit"},"actor_attributes":{"type":"User","name":"Jackson Isted","company":"CodeStrip Dev team","location":"Melbourne, Australia","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/Bukkit/CraftBukkit/pull/1250#discussion_r6762033"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/Bukkit/CraftBukkit/pulls/comments/3445694","id":3445694,"body":"What's the point of this method?","diff_hunk":"@@ -0,0 +1,61 @@\n+package net.minecraft.server;\n+\n+public class BlockDropper extends BlockDispenser {\n+\n+ private final IDispenseBehavior cR = new DispenseBehaviorItem();\n+\n+ protected BlockDropper(int i) {\n+ super(i);\n+ }\n+\n+ protected IDispenseBehavior a(ItemStack itemstack) {\n+ return this.cR;\n+ }\n+\n+ public TileEntity b(World world) {\n+ return new TileEntityDropper();\n+ }\n+\n+ // CraftBukkit start\n+ public void drop(World world, int i, int j, int k) { // CraftBukkit - drop method for dropper interface\n+ SourceBlock sourceblock = new SourceBlock(world, i, j, k);\n+ TileEntityDispenser tileentitydispenser = (TileEntityDispenser) sourceblock.getTileEntity();\n+\n+ if (tileentitydispenser != null) {\n+ int l = tileentitydispenser.j();\n+\n+ if (l < 0) {\n+ world.triggerEffect(1001, i, j, k, 0);\n+ } else {\n+ ItemStack itemstack = tileentitydispenser.getItem(l);\n+ int i1 = world.getData(i, j, k) & 7;\n+ IInventory iinventory = TileEntityHopper.b(world, (double) (i + Facing.b[i1]), (double) (j + Facing.c[i1]), (double) (k + Facing.d[i1]));\n+ ItemStack itemstack1;\n+\n+ if (iinventory != null) {\n+ itemstack1 = TileEntityHopper.a(iinventory, itemstack.cloneItemStack().a(1), Facing.OPPOSITE_FACING[i1]);\n+ if (itemstack1 == null) {\n+ itemstack1 = itemstack.cloneItemStack();\n+ if (--itemstack1.count == 0) {\n+ itemstack1 = null;\n+ }\n+ } else {\n+ itemstack1 = itemstack.cloneItemStack();\n+ }\n+ } else {\n+ itemstack1 = this.cR.a(sourceblock, itemstack);\n+ if (itemstack1 != null && itemstack1.count == 0) {\n+ itemstack1 = null;\n+ }\n+ }\n+\n+ tileentitydispenser.setItem(l, itemstack1);\n+ }\n+ }\n+ }\n+ \n+ public void dispense(World world, int i, int j, int k) {","path":"src/main/java/net/minecraft/server/BlockDropper.java","position":57,"original_position":57,"commit_id":"fc62a2536094b4a1b0794e9c98690335e0431444","original_commit_id":"fc62a2536094b4a1b0794e9c98690335e0431444","user":{"login":"evilmidget38","id":1179488,"avatar_url":"https://secure.gravatar.com/avatar/303765c10d04cccb31f61f061383aacc?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"303765c10d04cccb31f61f061383aacc","url":"https://api.github.com/users/evilmidget38","html_url":"https://github.com/evilmidget38","followers_url":"https://api.github.com/users/evilmidget38/followers","following_url":"https://api.github.com/users/evilmidget38/following","gists_url":"https://api.github.com/users/evilmidget38/gists{/gist_id}","starred_url":"https://api.github.com/users/evilmidget38/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evilmidget38/subscriptions","organizations_url":"https://api.github.com/users/evilmidget38/orgs","repos_url":"https://api.github.com/users/evilmidget38/repos","events_url":"https://api.github.com/users/evilmidget38/events{/privacy}","received_events_url":"https://api.github.com/users/evilmidget38/received_events","type":"User"},"created_at":"2013-03-20T05:44:58Z","updated_at":"2013-03-20T05:44:58Z","html_url":"https://github.com/Bukkit/CraftBukkit/pull/1071#discussion_r3445694","pull_request_url":"https://api.github.com/repos/Bukkit/CraftBukkit/pulls/1071","_links":{"self":{"href":"https://api.github.com/repos/Bukkit/CraftBukkit/pulls/comments/3445694"},"html":{"href":"https://github.com/Bukkit/CraftBukkit/pull/1071#discussion_r3445694"},"pull_request":{"href":"https://api.github.com/repos/Bukkit/CraftBukkit/pulls/1071"}}}} | {
"id": 1215253,
"name": "CraftBukkit",
"url": "https://github.com/Bukkit/CraftBukkit"
} | {
"id": null,
"login": "evilmidget38",
"gravatar_id": "303765c10d04cccb31f61f061383aacc",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "Bukkit",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-03-20T05:44:58 | null | {"repository":{"description":"The Minecraft Server Mod API Implementation","homepage":"http://bukkit.org","watchers":1780,"stargazers":1780,"forks":994,"fork":false,"size":2844,"owner":"Bukkit","private":false,"open_issues":73,"has_issues":false,"has_downloads":true,"has_wiki":true,"language":"Java","created_at":"2011-01-02T16:10:05-08:00","pushed_at":"2013-03-19T19:54:59-07:00","master_branch":"master","organization":"Bukkit"},"actor_attributes":{"type":"User","email":"[email protected]"},"url":"https://github.com/Bukkit/CraftBukkit/pull/1071#discussion_r3445694"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/EFForg/https-everywhere/pulls/comments/8518613","id":8518613,"diff_hunk":"@@ -205,20 +207,26 @@ function onHeadersReceived(details) {\n }\n \n // This event is needed due to the potential race between cookie permissions\n-// update and cookie transmission, becuase the cookie API is non-blocking..\n+// update and cookie transmission, because the cookie API is non-blocking.\n // It would be less perf impact to have a blocking version of the cookie API\n // available instead.\n+// WARNING: This is a very hot function.\n function onBeforeSendHeaders(details) {\n // XXX this function appears to enforce something equivalent to the secure\n // cookie flag by independent means. Is that really what it's supposed to\n // do?\n- var a = document.createElement(\"a\");\n- a.href = details.url;\n- var host = a.hostname;\n-\n+ // @@@ Agreed, this function is really weird. I'm not sure it's even useful\n+ // since we block WebRequests to HTTP sites (and maybe rewrite them to SSL)\n+ // we force cookies to be sent over HTTPS even if they don't have the flag\n+ // \"Secure\" set. (Unless I'm reading this wrong?)","path":"chromium/background.js","position":95,"original_position":95,"commit_id":"e8e35f251f54146850d7afa33984a69c8a2ddbf4","original_commit_id":"e8e35f251f54146850d7afa33984a69c8a2ddbf4","user":{"login":"diracdeltas","id":549654,"avatar_url":"https://gravatar.com/avatar/f05ea753c7b846f5ac64018cc741aeaa?d=https%3A%2F%2Fidenticons.github.com%2Fc903d86524a4e9276d7da9ef39f43742.png&r=x","gravatar_id":"f05ea753c7b846f5ac64018cc741aeaa","url":"https://api.github.com/users/diracdeltas","html_url":"https://github.com/diracdeltas","followers_url":"https://api.github.com/users/diracdeltas/followers","following_url":"https://api.github.com/users/diracdeltas/following{/other_user}","gists_url":"https://api.github.com/users/diracdeltas/gists{/gist_id}","starred_url":"https://api.github.com/users/diracdeltas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diracdeltas/subscriptions","organizations_url":"https://api.github.com/users/diracdeltas/orgs","repos_url":"https://api.github.com/users/diracdeltas/repos","events_url":"https://api.github.com/users/diracdeltas/events{/privacy}","received_events_url":"https://api.github.com/users/diracdeltas/received_events","type":"User","site_admin":false},"body":"ugh yeah there's some weirdness here. I think we need to do this for the case where we have an http to https rule for foo.example.com and example.com (but not *.example.com) and a securecookie rule for host=\"^\\.?example\\.com\". In that case, we're not forcing SSL on bar.example.com, so cookies for example.com could get sent over clear HTTP to bar.example.com before we've independently set the secure flag. ","created_at":"2013-12-21T22:13:59Z","updated_at":"2013-12-21T22:13:59Z","html_url":"https://github.com/EFForg/https-everywhere/pull/18#discussion_r8518613","pull_request_url":"https://api.github.com/repos/EFForg/https-everywhere/pulls/18","_links":{"self":{"href":"https://api.github.com/repos/EFForg/https-everywhere/pulls/comments/8518613"},"html":{"href":"https://github.com/EFForg/https-everywhere/pull/18#discussion_r8518613"},"pull_request":{"href":"https://api.github.com/repos/EFForg/https-everywhere/pulls/18"}}}} | {
"id": 14939303,
"name": "https-everywhere",
"url": "https://github.com/EFForg/https-everywhere"
} | {
"id": null,
"login": "diracdeltas",
"gravatar_id": "f05ea753c7b846f5ac64018cc741aeaa",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "EFForg",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-12-21T22:13:59 | null | {"repository":{"description":"The official Github mirror of the HTTPS Everywhere repository at https://gitweb.torproject.org/https-everywhere.git. You can send pull requests here.","homepage":"https://eff.org/https-everywhere","watchers":17,"stargazers":17,"forks":9,"fork":false,"size":22597,"owner":"EFForg","private":false,"open_issues":2,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"JavaScript","created_at":"2013-12-04T15:53:07-08:00","pushed_at":"2013-12-20T23:24:52-08:00","master_branch":"master","organization":"EFForg"},"actor_attributes":{"type":"User","name":"Yan Zhu","company":"EFF","blog":"https://zyan.scripts.mit.edu/blog","location":"San Francisco, CA","email":"[email protected]"},"url":"https://github.com/EFForg/https-everywhere/pull/18#discussion_r8518613"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/Itseez/opencv/pulls/comments/8155026","id":8155026,"diff_hunk":"@@ -176,9 +158,100 @@ int main( int argc, const char** argv )\n }\n \n cvDestroyWindow(\"result\");\n+ std::cout<< \"single-threaded sample has finished\" <<std::endl;\n return 0;\n }\n \n+///////////////////////////////////////detectfaces with multithreading////////////////////////////////////////////\n+#if defined(_MSC_VER) && (_MSC_VER >= 1700)\n+\n+#define MAX_THREADS 10\n+\n+static void detectFaces(std::string fileName)\n+{\n+ ocl::OclCascadeClassifier cascade;\n+ cascade.load(cascadeName);","path":"samples/ocl/facedetect.cpp","position":79,"original_position":79,"commit_id":"0a1ff0d42de3b9b40d5c153a6795e04f9a9da469","original_commit_id":"0a1ff0d42de3b9b40d5c153a6795e04f9a9da469","user":{"login":"apavlenko","id":2344952,"avatar_url":"https://2.gravatar.com/avatar/6b26ecc970c7e1c0994eb36b533d3ace?d=https%3A%2F%2Fidenticons.github.com%2F3f0b04604aefd8fd23686f1aefc62f41.png&r=x","gravatar_id":"6b26ecc970c7e1c0994eb36b533d3ace","url":"https://api.github.com/users/apavlenko","html_url":"https://github.com/apavlenko","followers_url":"https://api.github.com/users/apavlenko/followers","following_url":"https://api.github.com/users/apavlenko/following{/other_user}","gists_url":"https://api.github.com/users/apavlenko/gists{/gist_id}","starred_url":"https://api.github.com/users/apavlenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apavlenko/subscriptions","organizations_url":"https://api.github.com/users/apavlenko/orgs","repos_url":"https://api.github.com/users/apavlenko/repos","events_url":"https://api.github.com/users/apavlenko/events{/privacy}","received_events_url":"https://api.github.com/users/apavlenko/received_events","type":"User","site_admin":false},"body":"you need to check if cascade is loaded OK!","created_at":"2013-12-06T07:15:52Z","updated_at":"2013-12-06T07:15:52Z","html_url":"https://github.com/Itseez/opencv/pull/1872#discussion_r8155026","pull_request_url":"https://api.github.com/repos/Itseez/opencv/pulls/1872","_links":{"self":{"href":"https://api.github.com/repos/Itseez/opencv/pulls/comments/8155026"},"html":{"href":"https://github.com/Itseez/opencv/pull/1872#discussion_r8155026"},"pull_request":{"href":"https://api.github.com/repos/Itseez/opencv/pulls/1872"}}}} | {
"id": 5108051,
"name": "opencv",
"url": "https://github.com/Itseez/opencv"
} | {
"id": null,
"login": "apavlenko",
"gravatar_id": "6b26ecc970c7e1c0994eb36b533d3ace",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "Itseez",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-12-06T07:15:52 | null | {"repository":{"description":"Open Source Computer Vision Library","homepage":"opencv.org","watchers":1728,"stargazers":1728,"forks":1474,"fork":false,"size":370981,"owner":"Itseez","private":false,"open_issues":41,"has_issues":false,"has_downloads":true,"has_wiki":false,"language":"C++","created_at":"2012-07-19T02:40:17-07:00","pushed_at":"2013-12-05T05:05:30-08:00","master_branch":"master","organization":"Itseez"},"actor_attributes":{"type":"User","name":"Andrey Pavlenko","company":"Itseez","location":"Russia","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/Itseez/opencv/pull/1872#discussion_r8155026"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/Itseez/opencv/pulls/comments/6823547","id":6823547,"diff_hunk":"@@ -292,9 +292,11 @@ static void genTrainData(Mat& trainData, int trainDataRow, int trainDataCol,\n }\n }\n }\n+// TODO FIXIT: CvSVM::EPS_SVR case is crashed inside CPU implementation\n+// Anonymous enums are not supported well so cast them to 'int'\n INSTANTIATE_TEST_CASE_P(OCL_ML, SVM_OCL, testing::Combine(\n- Values(CvSVM::LINEAR, CvSVM::POLY, CvSVM::RBF, CvSVM::SIGMOID),\n- Values(CvSVM::C_SVC, CvSVM::NU_SVC, CvSVM::ONE_CLASS, CvSVM::EPS_SVR, CvSVM::NU_SVR),\n+ Values((int)CvSVM::LINEAR, (int)CvSVM::POLY, (int)CvSVM::RBF, (int)CvSVM::SIGMOID),\n+ Values((int)CvSVM::C_SVC, (int)CvSVM::NU_SVC, (int)CvSVM::ONE_CLASS, (int)CvSVM::NU_SVR),","path":"modules/ocl/test/test_ml.cpp","position":10,"original_position":10,"commit_id":"f63b0dfaf41c9f37f6c690f9a478f3aa4fd9f2d2","original_commit_id":"f63b0dfaf41c9f37f6c690f9a478f3aa4fd9f2d2","user":{"login":"alalek","id":4981219,"avatar_url":"https://2.gravatar.com/avatar/8f374d0f74f3fdc04d9213b6b2d56781?d=https%3A%2F%2Fidenticons.github.com%2F3b6325b66c3db84194ec02d4f86810a6.png","gravatar_id":"8f374d0f74f3fdc04d9213b6b2d56781","url":"https://api.github.com/users/alalek","html_url":"https://github.com/alalek","followers_url":"https://api.github.com/users/alalek/followers","following_url":"https://api.github.com/users/alalek/following{/other_user}","gists_url":"https://api.github.com/users/alalek/gists{/gist_id}","starred_url":"https://api.github.com/users/alalek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alalek/subscriptions","organizations_url":"https://api.github.com/users/alalek/orgs","repos_url":"https://api.github.com/users/alalek/repos","events_url":"https://api.github.com/users/alalek/events{/privacy}","received_events_url":"https://api.github.com/users/alalek/received_events","type":"User","site_admin":false},"body":"Naming enums is better. I believe that we shouldn't have anonymous enums...\r\n\r\nBTW, error was funny: `error C2664: 'testing::Values' : cannot convert parameter 1 from '' to ''`","created_at":"2013-10-08T12:07:29Z","updated_at":"2013-10-08T12:07:29Z","html_url":"https://github.com/Itseez/opencv/pull/1574#discussion_r6823547","pull_request_url":"https://api.github.com/repos/Itseez/opencv/pulls/1574","_links":{"self":{"href":"https://api.github.com/repos/Itseez/opencv/pulls/comments/6823547"},"html":{"href":"https://github.com/Itseez/opencv/pull/1574#discussion_r6823547"},"pull_request":{"href":"https://api.github.com/repos/Itseez/opencv/pulls/1574"}}}} | {
"id": 5108051,
"name": "opencv",
"url": "https://github.com/Itseez/opencv"
} | {
"id": null,
"login": "alalek",
"gravatar_id": "8f374d0f74f3fdc04d9213b6b2d56781",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "Itseez",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-10-08T12:07:29 | null | {"repository":{"description":"Open Source Computer Vision Library","homepage":"opencv.org","watchers":1366,"stargazers":1366,"forks":1184,"fork":false,"size":419968,"owner":"Itseez","private":false,"open_issues":37,"has_issues":false,"has_downloads":true,"has_wiki":false,"language":"C++","created_at":"2012-07-19T02:40:17-07:00","pushed_at":"2013-10-08T04:31:56-07:00","master_branch":"master","organization":"Itseez"},"actor_attributes":{"type":"User","name":"Alexander Alekhin","company":"Itseez","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/Itseez/opencv/pull/1574#discussion_r6823547"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/Mollom/MollomJava/pulls/comments/6692818","id":6692818,"body":"Should be \"custom whitelist\", no?","diff_hunk":"@@ -0,0 +1,136 @@\n+package com.mollom.client;\n+\n+import javax.xml.bind.annotation.XmlAccessType;\n+import javax.xml.bind.annotation.XmlAccessorType;\n+import javax.xml.bind.annotation.XmlRootElement;\n+\n+/**\n+ * Mollom automatically blocks unwanted content and learns from all participating sites to improve its filters.\n+ * On top of automatic filtering, you can define a custom blacklist.","path":"src/main/java/com/mollom/client/WhitelistEntry.java","position":9,"original_position":9,"commit_id":"c93a9755b60f6280d2252cf78ceeac04d5441876","original_commit_id":"c93a9755b60f6280d2252cf78ceeac04d5441876","user":{"login":"blackskad","id":109829,"avatar_url":"https://0.gravatar.com/avatar/221f38c025e1066f56997f039d28bbbf?d=https%3A%2F%2Fidenticons.github.com%2Fff58ffa77bb536d4ccfe43d6f6297887.png","gravatar_id":"221f38c025e1066f56997f039d28bbbf","url":"https://api.github.com/users/blackskad","html_url":"https://github.com/blackskad","followers_url":"https://api.github.com/users/blackskad/followers","following_url":"https://api.github.com/users/blackskad/following{/other_user}","gists_url":"https://api.github.com/users/blackskad/gists{/gist_id}","starred_url":"https://api.github.com/users/blackskad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blackskad/subscriptions","organizations_url":"https://api.github.com/users/blackskad/orgs","repos_url":"https://api.github.com/users/blackskad/repos","events_url":"https://api.github.com/users/blackskad/events{/privacy}","received_events_url":"https://api.github.com/users/blackskad/received_events","type":"User"},"created_at":"2013-10-01T16:59:30Z","updated_at":"2013-10-01T16:59:30Z","html_url":"https://github.com/Mollom/MollomJava/pull/1#discussion_r6692818","pull_request_url":"https://api.github.com/repos/Mollom/MollomJava/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/Mollom/MollomJava/pulls/comments/6692818"},"html":{"href":"https://github.com/Mollom/MollomJava/pull/1#discussion_r6692818"},"pull_request":{"href":"https://api.github.com/repos/Mollom/MollomJava/pulls/1"}}}} | {
"id": 8122176,
"name": "MollomJava",
"url": "https://github.com/Mollom/MollomJava"
} | {
"id": null,
"login": "blackskad",
"gravatar_id": "221f38c025e1066f56997f039d28bbbf",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "Mollom",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-10-01T16:59:30 | null | {"repository":{"description":"A Java client for Mollom","watchers":0,"stargazers":0,"forks":1,"fork":false,"size":244,"owner":"Mollom","private":false,"open_issues":1,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Java","created_at":"2013-02-10T04:06:58-08:00","pushed_at":"2013-09-29T20:40:18-07:00","master_branch":"master","organization":"Mollom"},"actor_attributes":{"type":"User","name":"Thomas Meire","blog":"http://zeus.ugent.be/~blackskad/blog","location":"Belgium","email":"[email protected]"},"url":"https://github.com/Mollom/MollomJava/pull/1#discussion_r6692818"} |
PullRequestReviewCommentEvent | true | {"comment":{"_links":{"html":{"href":"https://github.com/OpenRA/OpenRA/pull/2242#discussion_r2886751"},"self":{"href":"https://api.github.com/repos/OpenRA/OpenRA/pulls/comments/2886751"},"pull_request":{"href":"https://api.github.com/repos/OpenRA/OpenRA/pulls/2242"}},"body":"The isAdd check expression here is redundant; the if statement around it already takes care of that.","created_at":"2013-02-05T01:22:58Z","original_position":26,"original_commit_id":"cf1d4d0efb7cb888e2412dbd2d67144b5fcc32bc","position":26,"user":{"events_url":"https://api.github.com/users/JamesDunne/events{/privacy}","starred_url":"https://api.github.com/users/JamesDunne/starred{/owner}{/repo}","type":"User","gists_url":"https://api.github.com/users/JamesDunne/gists{/gist_id}","login":"JamesDunne","repos_url":"https://api.github.com/users/JamesDunne/repos","following_url":"https://api.github.com/users/JamesDunne/following","subscriptions_url":"https://api.github.com/users/JamesDunne/subscriptions","followers_url":"https://api.github.com/users/JamesDunne/followers","avatar_url":"https://secure.gravatar.com/avatar/9f41bfc370c185365fea540def0fcd55?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","id":538152,"gravatar_id":"9f41bfc370c185365fea540def0fcd55","organizations_url":"https://api.github.com/users/JamesDunne/orgs","received_events_url":"https://api.github.com/users/JamesDunne/received_events","url":"https://api.github.com/users/JamesDunne"},"commit_id":"cf1d4d0efb7cb888e2412dbd2d67144b5fcc32bc","id":2886751,"updated_at":"2013-02-05T01:22:58Z","path":"OpenRA.Mods.RA/Buildings/BibLayer.cs","url":"https://api.github.com/repos/OpenRA/OpenRA/pulls/comments/2886751"}} | {
"id": 959908,
"name": "OpenRA",
"url": "https://github.com/OpenRA/OpenRA"
} | {
"id": null,
"login": "JamesDunne",
"gravatar_id": "9f41bfc370c185365fea540def0fcd55",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "OpenRA",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-02-05T01:22:58 | null | {"repository":{"description":"An open-source implementation of the Red Alert engine using .NET/mono and OpenGL. Runs on Windows, Linux and OSX. Bugs at http://bugs.open-ra.org/","owner":"OpenRA","organization":"OpenRA","language":"C#","has_wiki":true,"pushed_at":"2013-02-04T10:08:32-08:00","forks":68,"fork":true,"size":10676,"watchers":208,"homepage":"http://open-ra.org","private":false,"open_issues":238,"master_branch":"bleed","stargazers":208,"has_issues":true,"has_downloads":true,"created_at":"2010-10-04T00:38:05-07:00"},"actor_attributes":{"name":"James Dunne","type":"User","blog":"http://bittwiddlers.org/","company":"bittwiddlers.org","location":"Chicago, IL","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/OpenRA/OpenRA/pull/2242#discussion_r2886751"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/OpenRA/OpenRA/pulls/comments/7234970","id":7234970,"diff_hunk":"@@ -21,9 +21,6 @@ cp -R $rootdir/usr root\n \n # Binaries go in /usr/games\n mv root/usr/bin/ root/usr/games/\n-sed \"s/\\/usr\\/bin\\//\\/usr\\/games\\//\" root/usr/share/applications/openra.desktop > temp","path":"packaging/linux/deb/buildpackage.sh","position":4,"original_position":4,"commit_id":"dfb4b1c54c7a928b4fc33ee74e92a2fcf24173fe","original_commit_id":"dfb4b1c54c7a928b4fc33ee74e92a2fcf24173fe","user":{"login":"pchote","id":167819,"avatar_url":"https://1.gravatar.com/avatar/9897916592aaea5d19fc01f505bc5f43?d=https%3A%2F%2Fidenticons.github.com%2F051fba0dfd589c5d9ffc2d4f19f4703d.png&r=x","gravatar_id":"9897916592aaea5d19fc01f505bc5f43","url":"https://api.github.com/users/pchote","html_url":"https://github.com/pchote","followers_url":"https://api.github.com/users/pchote/followers","following_url":"https://api.github.com/users/pchote/following{/other_user}","gists_url":"https://api.github.com/users/pchote/gists{/gist_id}","starred_url":"https://api.github.com/users/pchote/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pchote/subscriptions","organizations_url":"https://api.github.com/users/pchote/orgs","repos_url":"https://api.github.com/users/pchote/repos","events_url":"https://api.github.com/users/pchote/events{/privacy}","received_events_url":"https://api.github.com/users/pchote/received_events","type":"User","site_admin":false},"body":"Does openra.desktop already point to /usr/games?","created_at":"2013-10-26T20:38:59Z","updated_at":"2013-10-26T20:38:59Z","html_url":"https://github.com/OpenRA/OpenRA/pull/4009#discussion_r7234970","pull_request_url":"https://api.github.com/repos/OpenRA/OpenRA/pulls/4009","_links":{"self":{"href":"https://api.github.com/repos/OpenRA/OpenRA/pulls/comments/7234970"},"html":{"href":"https://github.com/OpenRA/OpenRA/pull/4009#discussion_r7234970"},"pull_request":{"href":"https://api.github.com/repos/OpenRA/OpenRA/pulls/4009"}}}} | {
"id": 959908,
"name": "OpenRA",
"url": "https://github.com/OpenRA/OpenRA"
} | {
"id": null,
"login": "pchote",
"gravatar_id": "9897916592aaea5d19fc01f505bc5f43",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "OpenRA",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-10-26T20:38:59 | null | {"repository":{"description":"An open-source implementation of the Red Alert engine using .NET/mono and OpenGL. Runs on Windows, Linux and Mac OS X.","homepage":"http://open-ra.org","watchers":401,"stargazers":401,"forks":136,"fork":true,"size":103504,"owner":"OpenRA","private":false,"open_issues":20,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"C#","created_at":"2010-10-04T00:38:05-07:00","pushed_at":"2013-10-26T01:19:43-07:00","master_branch":"bleed","organization":"OpenRA"},"actor_attributes":{"type":"User","name":"Paul Chote","location":"Wellington, New Zealand","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/OpenRA/OpenRA/pull/4009#discussion_r7234970"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/Theano/Theano/pulls/comments/5455428","id":5455428,"body":"Changed that. How do you know this? The only documentation I founc on PySlice_New is http://www.python.org/doc//current/c-api/slice.html","diff_hunk":"@@ -2941,6 +2941,184 @@ def construct_slices(curlen):\n \n out[0] = rval\n \n+ def c_code(self, node, name, inputs, out_, sub):\n+ if theano.tensor.extract_constant(node.inputs[0]) not in [0, 1]:\n+ raise NotImplementedError()\n+ # only works for the first two axis\n+ if len(inputs) != 3:\n+ # only works for two arrays\n+ raise NotImplementedError()\n+ if any([i.ndim != 2 for i in node.inputs[1:]]):\n+ # only works for type T.matrix\n+ raise NotImplementedError()\n+\n+ axis = inputs[0]\n+ input_1 = inputs[1]\n+ input_2 = inputs[2]\n+ axis = inputs[0]\n+ fail = sub['fail']\n+ out = out_[0]\n+\n+ str = \"\"\"\n+ int axis = PyInt_AsLong((PyObject*)%(axis)s);\n+ int nd = CudaNdarray_NDIM(%(input_1)s);\n+\n+ int dims_array1[nd];\n+ int errorcode;\n+ for(int i = 0; i<nd; i+=1){\n+ dims_array1[i] = CudaNdarray_HOST_DIMS(%(input_1)s)[i];\n+ }\n+\n+ nd = CudaNdarray_NDIM(%(input_2)s);\n+ int dims_array2[nd];\n+ for(int i = 0; i<nd; i+=1){\n+ dims_array2[i] = CudaNdarray_HOST_DIMS(%(input_2)s)[i];\n+ }\n+\n+ int dims_out[nd];\n+ if(axis==0)\n+ {\n+ dims_out[0] = dims_array1[0] + dims_array2[0];\n+ dims_out[1] = dims_array1[1];\n+ }\n+ if(axis==1)\n+ {\n+ dims_out[0] = dims_array1[0];\n+ dims_out[1] = dims_array1[1] + dims_array2[1];\n+ }\n+ if (CudaNdarray_prep_output(& %(out)s, 2, dims_out))\n+ {\n+ %(fail)s;\n+ }\n+\n+ PyObject *slice;\n+ PyObject *out_sub;\n+ PyObject *start, *stop, *step;\n+ step = NULL;\n+ \n+ if(axis==0)\n+ {\n+ start = PyInt_FromLong(0);\n+ stop = PyInt_FromLong(dims_array1[0]);\n+ slice = PySlice_New(start, stop, step);\n+ out_sub = CudaNdarray_Subscript((PyObject*)%(out)s, slice);\n+ errorcode = CudaNdarray_CopyFromCudaNdarray((CudaNdarray*)out_sub, %(input_1)s);\n+ if((slice == NULL) || (out_sub == NULL) || (errorcode != 0))\n+ {\n+ Py_XDECREF(slice);\n+ Py_XDECREF(out_sub);\n+ Py_XDECREF(start);\n+ Py_XDECREF(stop);\n+ Py_XDECREF(step);\n+ Py_XDECREF(%(out)s);\n+ %(fail)s;\n+ }\n+ Py_XDECREF(start);\n+ Py_XDECREF(slice);\n+ Py_XDECREF(out_sub);\n+\n+ start = stop;\n+ stop = PyInt_FromLong(PyInt_AsLong(start) + dims_array2[0]);\n+ slice = PySlice_New(start, stop, step);\n+ out_sub = CudaNdarray_Subscript((PyObject*)%(out)s, slice);\n+ errorcode = CudaNdarray_CopyFromCudaNdarray((CudaNdarray*)out_sub, %(input_2)s);\n+ if((slice == NULL) || (out_sub == NULL) || (errorcode != 0))\n+ {\n+ Py_XDECREF(slice);\n+ Py_XDECREF(out_sub);\n+ Py_XDECREF(start);\n+ Py_XDECREF(stop);\n+ Py_XDECREF(step);\n+ Py_XDECREF(%(out)s);\n+ %(fail)s;\n+ }\n+\n+ Py_XDECREF(slice);\n+ Py_XDECREF(out_sub);\n+ Py_XDECREF(start);\n+ Py_XDECREF(stop);\n+ Py_XDECREF(step);\n+ }\n+\n+ if(axis==1)\n+ {\n+ PyObject *slice_tuple;\n+ PyObject *full_slice;\n+ PyObject *section_slice;\n+ PyObject *start_axis2, *stop_axis2;\n+\n+ start = PyInt_FromLong(0);\n+ stop = PyInt_FromLong(dims_out[0]);","path":"theano/sandbox/cuda/basic_ops.py","position":111,"original_position":111,"commit_id":"6ecd6c6cfb8c06d8fd0bb73cf6924e1171e4d069","original_commit_id":"6ecd6c6cfb8c06d8fd0bb73cf6924e1171e4d069","user":{"login":"shackenberg","id":1042973,"avatar_url":"https://secure.gravatar.com/avatar/cf65ad115637f70708e5259ebaa83f3c?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"cf65ad115637f70708e5259ebaa83f3c","url":"https://api.github.com/users/shackenberg","html_url":"https://github.com/shackenberg","followers_url":"https://api.github.com/users/shackenberg/followers","following_url":"https://api.github.com/users/shackenberg/following{/other_user}","gists_url":"https://api.github.com/users/shackenberg/gists{/gist_id}","starred_url":"https://api.github.com/users/shackenberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shackenberg/subscriptions","organizations_url":"https://api.github.com/users/shackenberg/orgs","repos_url":"https://api.github.com/users/shackenberg/repos","events_url":"https://api.github.com/users/shackenberg/events{/privacy}","received_events_url":"https://api.github.com/users/shackenberg/received_events","type":"User"},"created_at":"2013-07-29T17:15:28Z","updated_at":"2013-07-29T17:15:28Z","html_url":"https://github.com/Theano/Theano/pull/1469#discussion_r5455428","pull_request_url":"https://api.github.com/repos/Theano/Theano/pulls/1469","_links":{"self":{"href":"https://api.github.com/repos/Theano/Theano/pulls/comments/5455428"},"html":{"href":"https://github.com/Theano/Theano/pull/1469#discussion_r5455428"},"pull_request":{"href":"https://api.github.com/repos/Theano/Theano/pulls/1469"}}}} | {
"id": 2183193,
"name": "Theano",
"url": "https://github.com/Theano/Theano"
} | {
"id": null,
"login": "shackenberg",
"gravatar_id": "cf65ad115637f70708e5259ebaa83f3c",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "Theano",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-07-29T17:15:28 | null | {"repository":{"description":"Optimizing GPU-meta-programming code generating array oriented optimizing math compiler in Python","homepage":"http://www.deeplearning.net/software/theano","watchers":303,"stargazers":303,"forks":109,"fork":false,"size":18935,"owner":"Theano","private":false,"open_issues":182,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Python","created_at":"2011-08-09T20:48:06-07:00","pushed_at":"2013-07-23T14:43:32-07:00","master_branch":"master","organization":"Theano"},"actor_attributes":{"type":"User","name":"Ludwig Schmidt-Hackenberg","blog":"ludwig.schmidt-hackenberg.net","location":"South-West Germany","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/Theano/Theano/pull/1469#discussion_r5455428"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/U-Play/profiles/pulls/comments/6980085","id":6980085,"diff_hunk":"@@ -28,7 +28,7 @@\n end\n \n When(/^I sign up via facebook$/) do\n- click_on t('landing.button')\n+ find(:xpath, '//div[ @class = \"cta-button\"]/..').click","path":"features/step_definitions/sign_in_steps.rb","position":5,"original_position":5,"commit_id":"bcf0216ab5534be805eda204a0d1c7dd346d7716","original_commit_id":"bcf0216ab5534be805eda204a0d1c7dd346d7716","user":{"login":"naps62","id":283819,"avatar_url":"https://0.gravatar.com/avatar/61eda798bacac5858264e7af2ab71791?d=https%3A%2F%2Fidenticons.github.com%2Fc8ae6fb6bb6d43177f7b815352c67230.png","gravatar_id":"61eda798bacac5858264e7af2ab71791","url":"https://api.github.com/users/naps62","html_url":"https://github.com/naps62","followers_url":"https://api.github.com/users/naps62/followers","following_url":"https://api.github.com/users/naps62/following{/other_user}","gists_url":"https://api.github.com/users/naps62/gists{/gist_id}","starred_url":"https://api.github.com/users/naps62/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/naps62/subscriptions","organizations_url":"https://api.github.com/users/naps62/orgs","repos_url":"https://api.github.com/users/naps62/repos","events_url":"https://api.github.com/users/naps62/events{/privacy}","received_events_url":"https://api.github.com/users/naps62/received_events","type":"User","site_admin":false},"body":"sei cerca de 0 de XPath, mas isto parece-me exactamente o mesmo que\r\n`find(:css, '.cta-button').click`\r\ntalvez com um `.first` lá para o meio ou algo parecido","created_at":"2013-10-15T18:23:51Z","updated_at":"2013-10-15T18:23:51Z","html_url":"https://github.com/U-Play/profiles/pull/144#discussion_r6980085","pull_request_url":"https://api.github.com/repos/U-Play/profiles/pulls/144","_links":{"self":{"href":"https://api.github.com/repos/U-Play/profiles/pulls/comments/6980085"},"html":{"href":"https://github.com/U-Play/profiles/pull/144#discussion_r6980085"},"pull_request":{"href":"https://api.github.com/repos/U-Play/profiles/pulls/144"}}}} | {
"id": 10749331,
"name": "profiles",
"url": "https://github.com/U-Play/profiles"
} | {
"id": null,
"login": "naps62",
"gravatar_id": "61eda798bacac5858264e7af2ab71791",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "U-Play",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-10-15T18:23:51 | null | {"repository":{"description":"","watchers":0,"stargazers":0,"forks":0,"fork":false,"size":5564,"owner":"U-Play","private":false,"open_issues":5,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Ruby","created_at":"2013-06-17T16:05:57-07:00","pushed_at":"2013-10-15T09:56:04-07:00","master_branch":"dev","organization":"U-Play"},"actor_attributes":{"type":"User","name":"Miguel Palhas","company":"University of Minho","blog":"https://github.com/naps62","location":"Braga, Portugal","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/U-Play/profiles/pull/144#discussion_r6980085"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/Umonya/DjangoWebsite/pulls/comments/4923107","id":4923107,"body":"snip","diff_hunk":"@@ -18,60 +22,154 @@ class Announcement(models.Model):\n Date Published set on creation.\n '''\n title = models.CharField(\n- max_length = 200,\n- unique = True)\n- body = models.TextField()\n-\n+ max_length=200,\n+ unique=True,\n+ blank=False)\n+ body = models.TextField(\n+ blank=False,)\n pub_date = models.DateField(\n- \"Date Published\",\n- default = timezone.now().date(),\n- editable = False)\n+ 'Date Published',\n+ auto_now=True)\n event_date = models.DateTimeField(\n- \"Event Date\",\n- default = timezone.now())\n- venue = models.CharField(max_length = 300, blank=True)\n- slug = models.SlugField(editable = False)\n+ 'Event Date',\n+ default=timezone.now(),\n+ blank=True,\n+ null=True)\n+ venue = models.CharField(\n+ max_length=300,\n+ default='UCT',\n+ blank=True,\n+ null=True)\n+ slug = models.SlugField(editable=False)\n \n class Meta:\n- ordering = [\"-pub_date\"]\n+ ordering = ['-pub_date']\n \n def __unicode__(self):\n- return u\"%s %s\" % (self.title, self.pub_date)\n+ return u'%s %s' % (self.title, self.pub_date)\n+\n+ is_valid_date = lambda s: s.event_date.date() >= s.pub_date\n+\n+ def clean(self):\n+","path":"umonya/umonya/apps/main/models.py","position":68,"original_position":68,"commit_id":"81872f217326d2618b3daba92be6fb17a9380a82","original_commit_id":"81872f217326d2618b3daba92be6fb17a9380a82","user":{"login":"ninas","id":280141,"avatar_url":"https://secure.gravatar.com/avatar/9cc712eff9910d29775684af2d14a347?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"9cc712eff9910d29775684af2d14a347","url":"https://api.github.com/users/ninas","html_url":"https://github.com/ninas","followers_url":"https://api.github.com/users/ninas/followers","following_url":"https://api.github.com/users/ninas/following{/other_user}","gists_url":"https://api.github.com/users/ninas/gists{/gist_id}","starred_url":"https://api.github.com/users/ninas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ninas/subscriptions","organizations_url":"https://api.github.com/users/ninas/orgs","repos_url":"https://api.github.com/users/ninas/repos","events_url":"https://api.github.com/users/ninas/events{/privacy}","received_events_url":"https://api.github.com/users/ninas/received_events","type":"User"},"created_at":"2013-06-27T18:34:07Z","updated_at":"2013-06-27T18:34:07Z","html_url":"https://github.com/Umonya/DjangoWebsite/pull/24#discussion_r4923107","pull_request_url":"https://api.github.com/repos/Umonya/DjangoWebsite/pulls/24","_links":{"self":{"href":"https://api.github.com/repos/Umonya/DjangoWebsite/pulls/comments/4923107"},"html":{"href":"https://github.com/Umonya/DjangoWebsite/pull/24#discussion_r4923107"},"pull_request":{"href":"https://api.github.com/repos/Umonya/DjangoWebsite/pulls/24"}}}} | {
"id": 10423625,
"name": "DjangoWebsite",
"url": "https://github.com/Umonya/DjangoWebsite"
} | {
"id": null,
"login": "ninas",
"gravatar_id": "9cc712eff9910d29775684af2d14a347",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "Umonya",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-06-27T18:34:07 | null | {"repository":{"description":"","watchers":2,"stargazers":2,"forks":4,"fork":false,"size":260,"owner":"Umonya","private":false,"open_issues":2,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Python","created_at":"2013-06-01T07:42:26-07:00","pushed_at":"2013-06-24T15:26:57-07:00","master_branch":"develop","organization":"Umonya"},"actor_attributes":{"type":"User","name":"Nina Schiff","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/Umonya/DjangoWebsite/pull/24#discussion_r4923107"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/VoltDB/voltdb/pulls/comments/3577360","id":3577360,"body":"Does this need to be called on node failures as well?","diff_hunk":"@@ -91,4 +92,11 @@ void shutdown()\n VoltDB.crashLocalVoltDB(\"Error shutting down GlobalServiceElector's LeaderElector\", true, e);\n }\n }\n+\n+ @Override\n+ public void noticedNewNode() {\n+ if (ExportManager.instance() != null) {\n+ ExportManager.instance().notifyOfClusterTopologyChange();","path":"src/frontend/org/voltdb/GlobalServiceElector.java","position":33,"original_position":33,"commit_id":"05b35ba7b8dd07cccb0a03f389a4d6c88fa6356e","original_commit_id":"05b35ba7b8dd07cccb0a03f389a4d6c88fa6356e","user":{"login":"nshi","id":10992,"avatar_url":"https://secure.gravatar.com/avatar/31d6c9f1b851446a43faf4afe5bbc8af?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"31d6c9f1b851446a43faf4afe5bbc8af","url":"https://api.github.com/users/nshi","html_url":"https://github.com/nshi","followers_url":"https://api.github.com/users/nshi/followers","following_url":"https://api.github.com/users/nshi/following","gists_url":"https://api.github.com/users/nshi/gists{/gist_id}","starred_url":"https://api.github.com/users/nshi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nshi/subscriptions","organizations_url":"https://api.github.com/users/nshi/orgs","repos_url":"https://api.github.com/users/nshi/repos","events_url":"https://api.github.com/users/nshi/events{/privacy}","received_events_url":"https://api.github.com/users/nshi/received_events","type":"User"},"created_at":"2013-03-28T19:49:52Z","updated_at":"2013-03-28T19:49:52Z","html_url":"https://github.com/VoltDB/voltdb/pull/442#discussion_r3577360","pull_request_url":"https://api.github.com/repos/VoltDB/voltdb/pulls/442","_links":{"self":{"href":"https://api.github.com/repos/VoltDB/voltdb/pulls/comments/3577360"},"html":{"href":"https://github.com/VoltDB/voltdb/pull/442#discussion_r3577360"},"pull_request":{"href":"https://api.github.com/repos/VoltDB/voltdb/pulls/442"}}}} | {
"id": 2445970,
"name": "voltdb",
"url": "https://github.com/VoltDB/voltdb"
} | {
"id": null,
"login": "nshi",
"gravatar_id": "31d6c9f1b851446a43faf4afe5bbc8af",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "VoltDB",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-03-28T19:49:52 | null | {"repository":{"description":"VoltDB","homepage":"http://community.voltdb.com/","watchers":116,"stargazers":116,"forks":29,"fork":false,"size":99840,"owner":"VoltDB","private":false,"open_issues":4,"has_issues":false,"has_downloads":true,"has_wiki":true,"language":"C++","created_at":"2011-09-23T11:46:12-07:00","pushed_at":"2013-03-28T12:37:48-07:00","master_branch":"master","organization":"VoltDB"},"actor_attributes":{"type":"User","name":"Ning Shi","company":"VoltDB Inc.","blog":"","location":"","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/VoltDB/voltdb/pull/442#discussion_r3577360"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/VoltDB/voltdb/pulls/comments/6440393","id":6440393,"body":"Comment about inner class and what it does.","diff_hunk":"@@ -836,7 +866,63 @@ protected void reflect() {\n }\n }\n \n- /**\n+ private final static Language.Visitor<Class<?>[], ProcedureRunner> parametersTypeRetriever =\n+ new Language.Visitor<Class<?>[], ProcedureRunner>() {\n+ @Override\n+ public Class<?>[] visitJava(ProcedureRunner p) {\n+ Method[] methods = p.m_procedure.getClass().getDeclaredMethods();\n+\n+ for (final Method m : methods) {\n+ String name = m.getName();\n+ if (name.equals(\"run\")) {\n+ if (Modifier.isPublic(m.getModifiers()) == false)\n+ continue;\n+ p.m_procMethod = m;\n+ return m.getParameterTypes();\n+ }\n+ }\n+ return null;\n+ }\n+ @Override\n+ public Class<?>[] visitGroovy(ProcedureRunner p) {\n+ return ((GroovyScriptProcedureDelegate)p.m_procedure).getParameterTypes();\n+ }\n+ };\n+\n+ private final static Language.Visitor<Map<String,SQLStmt>, ProcedureRunner> sqlStatementsRetriever =\n+ new Language.Visitor<Map<String,SQLStmt>, ProcedureRunner>() {\n+ @Override\n+ public Map<String, SQLStmt> visitJava(ProcedureRunner p) {\n+ Map<String, SQLStmt> stmtMap = null;\n+ try {\n+ stmtMap = ProcedureCompiler.getValidSQLStmts(null, p.m_procedureName, p.m_procedure.getClass(), p.m_procedure, true);\n+ } catch (Exception e1) {\n+ // shouldn't throw anything outside of the compiler\n+ e1.printStackTrace();\n+ }\n+ return stmtMap;\n+ }\n+ @Override\n+ public Map<String, SQLStmt> visitGroovy(ProcedureRunner p) {\n+ return ((GroovyScriptProcedureDelegate)p.m_procedure).getStatementMap();\n+ }\n+ };\n+\n+ protected boolean isProcedureStackTraceElement(StackTraceElement stel) {","path":"src/frontend/org/voltdb/ProcedureRunner.java","position":198,"original_position":198,"commit_id":"379c575049137fd70dbfd68be6a5c615e000b87a","original_commit_id":"379c575049137fd70dbfd68be6a5c615e000b87a","user":{"login":"akhanzode","id":1675698,"avatar_url":"https://1.gravatar.com/avatar/f344d8d642daa16f661eff68e5e5b819?d=https%3A%2F%2Fidenticons.github.com%2F8486fb019cecf64553fb3c8a2cae591b.png","gravatar_id":"f344d8d642daa16f661eff68e5e5b819","url":"https://api.github.com/users/akhanzode","html_url":"https://github.com/akhanzode","followers_url":"https://api.github.com/users/akhanzode/followers","following_url":"https://api.github.com/users/akhanzode/following{/other_user}","gists_url":"https://api.github.com/users/akhanzode/gists{/gist_id}","starred_url":"https://api.github.com/users/akhanzode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akhanzode/subscriptions","organizations_url":"https://api.github.com/users/akhanzode/orgs","repos_url":"https://api.github.com/users/akhanzode/repos","events_url":"https://api.github.com/users/akhanzode/events{/privacy}","received_events_url":"https://api.github.com/users/akhanzode/received_events","type":"User"},"created_at":"2013-09-18T17:37:26Z","updated_at":"2013-09-18T17:37:26Z","html_url":"https://github.com/VoltDB/voltdb/pull/674#discussion_r6440393","pull_request_url":"https://api.github.com/repos/VoltDB/voltdb/pulls/674","_links":{"self":{"href":"https://api.github.com/repos/VoltDB/voltdb/pulls/comments/6440393"},"html":{"href":"https://github.com/VoltDB/voltdb/pull/674#discussion_r6440393"},"pull_request":{"href":"https://api.github.com/repos/VoltDB/voltdb/pulls/674"}}}} | {
"id": 2445970,
"name": "voltdb",
"url": "https://github.com/VoltDB/voltdb"
} | {
"id": null,
"login": "akhanzode",
"gravatar_id": "f344d8d642daa16f661eff68e5e5b819",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "VoltDB",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-09-18T17:37:26 | null | {"repository":{"description":"VoltDB","homepage":"http://community.voltdb.com/","watchers":205,"stargazers":205,"forks":49,"fork":false,"size":253789,"owner":"VoltDB","private":false,"open_issues":12,"has_issues":false,"has_downloads":true,"has_wiki":true,"language":"C++","created_at":"2011-09-23T11:46:12-07:00","pushed_at":"2013-09-18T10:20:41-07:00","master_branch":"master","organization":"VoltDB"},"actor_attributes":{"type":"User","name":"Anish Khanzode","blog":"","location":"Boston,MA","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/VoltDB/voltdb/pull/674#discussion_r6440393"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/VoltDB/voltdb/pulls/comments/7518524","id":7518524,"diff_hunk":"@@ -359,13 +359,15 @@ VoltXMLElement voltGetColumnXML(Session session) throws HSQLParseException\n \n // if there is a default value for the column\n // and the column value is not NULL. (Ignore \"DEFAULT NULL\" in DDL)\n- if (exp != null && exp.valueData != null) {\n- exp.dataType = dataType;\n-\n- // add default value to body of column element\n- VoltXMLElement defaultElem = new VoltXMLElement(\"default\");\n- column.children.add(defaultElem);\n- defaultElem.children.add(exp.voltGetXML(session));\n+ if (exp != null) {\n+ if (exp.valueData != null || (exp instanceof FunctionSQL && ((FunctionSQL)exp).isValueFunction)) {\n+ exp.dataType = dataType;","path":"src/hsqldb19b3/org/hsqldb_voltpatches/ColumnSchema.java","position":13,"original_position":13,"commit_id":"a63aaf51c17e882e00a02ef04c0b0bed3260aff0","original_commit_id":"a63aaf51c17e882e00a02ef04c0b0bed3260aff0","user":{"login":"paulmartel","id":1512099,"avatar_url":"https://1.gravatar.com/avatar/6ead0214cbf028f95dcc28142fa4d7bd?d=https%3A%2F%2Fidenticons.github.com%2F316ff0e036a700bdd4c960e0836f66d1.png&r=x","gravatar_id":"6ead0214cbf028f95dcc28142fa4d7bd","url":"https://api.github.com/users/paulmartel","html_url":"https://github.com/paulmartel","followers_url":"https://api.github.com/users/paulmartel/followers","following_url":"https://api.github.com/users/paulmartel/following{/other_user}","gists_url":"https://api.github.com/users/paulmartel/gists{/gist_id}","starred_url":"https://api.github.com/users/paulmartel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulmartel/subscriptions","organizations_url":"https://api.github.com/users/paulmartel/orgs","repos_url":"https://api.github.com/users/paulmartel/repos","events_url":"https://api.github.com/users/paulmartel/events{/privacy}","received_events_url":"https://api.github.com/users/paulmartel/received_events","type":"User","site_admin":false},"body":"I think this line answers the question \"Why they are the same and it is an impossible case?\"\r\nBTW, I don't like this line -- it hides information instead of adding information and it is the only place in the getVoltXML where we change (corrupt?) the original HSQL object.\r\nBut I am just a little bit scared about removing this line unless we can stop paying so much attention to defaulttype in the ddlcompiler.","created_at":"2013-11-08T03:44:56Z","updated_at":"2013-11-08T03:44:56Z","html_url":"https://github.com/VoltDB/voltdb/pull/924#discussion_r7518524","pull_request_url":"https://api.github.com/repos/VoltDB/voltdb/pulls/924","_links":{"self":{"href":"https://api.github.com/repos/VoltDB/voltdb/pulls/comments/7518524"},"html":{"href":"https://github.com/VoltDB/voltdb/pull/924#discussion_r7518524"},"pull_request":{"href":"https://api.github.com/repos/VoltDB/voltdb/pulls/924"}}}} | {
"id": 2445970,
"name": "voltdb",
"url": "https://github.com/VoltDB/voltdb"
} | {
"id": null,
"login": "paulmartel",
"gravatar_id": "6ead0214cbf028f95dcc28142fa4d7bd",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "VoltDB",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-11-08T03:44:56 | null | {"repository":{"description":"VoltDB","homepage":"http://community.voltdb.com/","watchers":221,"stargazers":221,"forks":56,"fork":false,"size":262028,"owner":"VoltDB","private":false,"open_issues":10,"has_issues":false,"has_downloads":true,"has_wiki":true,"language":"C++","created_at":"2011-09-23T11:46:12-07:00","pushed_at":"2013-11-07T17:50:33-08:00","master_branch":"master","organization":"VoltDB"},"actor_attributes":{"type":"User","name":"Paul A Martel","company":"VoltDB","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/VoltDB/voltdb/pull/924#discussion_r7518524"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/VoltDB/voltdb/pulls/comments/6803185","id":6803185,"diff_hunk":"@@ -330,13 +312,12 @@ public int getHashedPartitionForParameter(int partitionValueType, Object partiti\n }\n }\n }\n- else if (getConfiguredHashinatorType() == HashinatorType.LEGACY","path":"src/frontend/org/voltdb/TheHashinator.java","position":88,"original_position":88,"commit_id":"a03c88eb0e7ae2a2b01db2b737c4e25df8e6b9b9","original_commit_id":"a03c88eb0e7ae2a2b01db2b737c4e25df8e6b9b9","user":{"login":"aweisberg","id":1047741,"avatar_url":"https://2.gravatar.com/avatar/42de74b49138cdf58a84b9f1982cf6db?d=https%3A%2F%2Fidenticons.github.com%2F1de127a8349452faa1da1a53ff3abace.png","gravatar_id":"42de74b49138cdf58a84b9f1982cf6db","url":"https://api.github.com/users/aweisberg","html_url":"https://github.com/aweisberg","followers_url":"https://api.github.com/users/aweisberg/followers","following_url":"https://api.github.com/users/aweisberg/following{/other_user}","gists_url":"https://api.github.com/users/aweisberg/gists{/gist_id}","starred_url":"https://api.github.com/users/aweisberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aweisberg/subscriptions","organizations_url":"https://api.github.com/users/aweisberg/orgs","repos_url":"https://api.github.com/users/aweisberg/repos","events_url":"https://api.github.com/users/aweisberg/events{/privacy}","received_events_url":"https://api.github.com/users/aweisberg/received_events","type":"User"},"body":"Why why is it safe to remove the check for legacy?","created_at":"2013-10-07T17:05:16Z","updated_at":"2013-10-07T17:05:16Z","html_url":"https://github.com/VoltDB/voltdb/pull/842#discussion_r6803185","pull_request_url":"https://api.github.com/repos/VoltDB/voltdb/pulls/842","_links":{"self":{"href":"https://api.github.com/repos/VoltDB/voltdb/pulls/comments/6803185"},"html":{"href":"https://github.com/VoltDB/voltdb/pull/842#discussion_r6803185"},"pull_request":{"href":"https://api.github.com/repos/VoltDB/voltdb/pulls/842"}}}} | {
"id": 2445970,
"name": "voltdb",
"url": "https://github.com/VoltDB/voltdb"
} | {
"id": null,
"login": "aweisberg",
"gravatar_id": "42de74b49138cdf58a84b9f1982cf6db",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "VoltDB",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-10-07T17:05:16 | null | {"repository":{"description":"VoltDB","homepage":"http://community.voltdb.com/","watchers":210,"stargazers":210,"forks":53,"fork":false,"size":261146,"owner":"VoltDB","private":false,"open_issues":11,"has_issues":false,"has_downloads":true,"has_wiki":true,"language":"C++","created_at":"2011-09-23T11:46:12-07:00","pushed_at":"2013-10-07T09:51:39-07:00","master_branch":"master","organization":"VoltDB"},"actor_attributes":{"type":"User","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/VoltDB/voltdb/pull/842#discussion_r6803185"} |
Subsets and Splits