Search is not available for this dataset
type
stringclasses 17
values | public
bool 2
classes | payload
stringlengths 2
1.27M
| repo
dict | actor
dict | org
dict | created_at
timestamp[us] | id
stringclasses 0
values | other
stringlengths 34
66.4k
|
|---|---|---|---|---|---|---|---|---|
PullRequestReviewCommentEvent | true | {"comment":{"original_commit_id":"9723fe83e2045f16494f5d6895aac661213ac7ea","_links":{"pull_request":{"href":"https://api.github.com/repos/mrjoes/sockjs-tornado/pulls/36"},"self":{"href":"https://api.github.com/repos/mrjoes/sockjs-tornado/pulls/comments/2596559"},"html":{"href":"https://github.com/mrjoes/sockjs-tornado/pull/36#discussion_r2596559"}},"id":2596559,"body":"fixed. should be unicode there. ","user":{"events_url":"https://api.github.com/users/benoitc/events{/privacy}","id":14498,"gists_url":"https://api.github.com/users/benoitc/gists{/gist_id}","repos_url":"https://api.github.com/users/benoitc/repos","avatar_url":"https://secure.gravatar.com/avatar/f04edc7cb2099745e5413c754d3d22f5?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","starred_url":"https://api.github.com/users/benoitc/starred{/owner}{/repo}","received_events_url":"https://api.github.com/users/benoitc/received_events","gravatar_id":"f04edc7cb2099745e5413c754d3d22f5","login":"benoitc","subscriptions_url":"https://api.github.com/users/benoitc/subscriptions","url":"https://api.github.com/users/benoitc","following_url":"https://api.github.com/users/benoitc/following","followers_url":"https://api.github.com/users/benoitc/followers","organizations_url":"https://api.github.com/users/benoitc/orgs","type":"User"},"original_position":17,"created_at":"2013-01-09T21:04:11Z","updated_at":"2013-01-09T21:04:11Z","commit_id":"4efb1005bc5ce3f68fa80247f184a673129c67eb","url":"https://api.github.com/repos/mrjoes/sockjs-tornado/pulls/comments/2596559","position":null,"path":"sockjs/tornado/util.py"}} | {
"id": 2927833,
"name": "sockjs-tornado",
"url": "https://github.com/mrjoes/sockjs-tornado"
} | {
"id": null,
"login": "benoitc",
"gravatar_id": "f04edc7cb2099745e5413c754d3d22f5",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-01-09T21:04:11 | null | {"repository":{"owner":"mrjoes","created_at":"2011-12-06T12:41:39-08:00","homepage":"","open_issues":7,"has_downloads":true,"description":"WebSocket emulation - Python server","pushed_at":"2012-11-13T04:28:28-08:00","forks":30,"fork":false,"size":160,"watchers":195,"has_wiki":true,"language":"Python","private":false,"stargazers":195,"has_issues":true},"actor_attributes":{"location":"Creil, France","email":"[email protected]","company":"Enki Multimedia","type":"User","name":"Benoit Chesneau","blog":"http://benoitc.im"},"url":"https://github.com/mrjoes/sockjs-tornado/pull/36#discussion_r2596559"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/bbatsov/rubocop/pulls/comments/4398986","id":4398986,"body":"Huh? You can use parser's interface for parsing buffers in memory. This will speed up tests quite a bit.","diff_hunk":"@@ -63,9 +63,13 @@ module ExitCodeMatchers\n # in ./support/ and its subdirectories.\n Dir[\"#{File.dirname(__FILE__)}/support/**/*.rb\"].each { |f| require f }\n \n-def inspect_source(cop, file, source)\n- ast, comments, tokens = Rubocop::CLI.rip_source(source.join(\"\\n\"))\n- cop.inspect(source, tokens, ast, comments)\n+def inspect_source(cop, source)\n+ Dir.mktmpdir do |tmpdir|\n+ path = File.join(tmpdir, 'file.rb')\n+ File.open(path, 'w') { |f| f.write(source.join(\"\\n\")) }\n+ ast, comments, tokens, _ = Rubocop::CLI.rip_source(path)\n+ cop.inspect(source, tokens, ast, comments)","path":"spec/spec_helper.rb","position":12,"original_position":12,"commit_id":"dac2bd50fc6fc6b0a14b1e90a0c6ec4c732c5b29","original_commit_id":"dac2bd50fc6fc6b0a14b1e90a0c6ec4c732c5b29","user":{"login":"whitequark","id":54771,"avatar_url":"https://secure.gravatar.com/avatar/89d887b50262bbe10225d36d974fdb0c?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"89d887b50262bbe10225d36d974fdb0c","url":"https://api.github.com/users/whitequark","html_url":"https://github.com/whitequark","followers_url":"https://api.github.com/users/whitequark/followers","following_url":"https://api.github.com/users/whitequark/following{/other_user}","gists_url":"https://api.github.com/users/whitequark/gists{/gist_id}","starred_url":"https://api.github.com/users/whitequark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whitequark/subscriptions","organizations_url":"https://api.github.com/users/whitequark/orgs","repos_url":"https://api.github.com/users/whitequark/repos","events_url":"https://api.github.com/users/whitequark/events{/privacy}","received_events_url":"https://api.github.com/users/whitequark/received_events","type":"User"},"created_at":"2013-05-27T11:05:01Z","updated_at":"2013-05-27T11:05:01Z","html_url":"https://github.com/bbatsov/rubocop/pull/202#discussion_r4398986","pull_request_url":"https://api.github.com/repos/bbatsov/rubocop/pulls/202","_links":{"self":{"href":"https://api.github.com/repos/bbatsov/rubocop/pulls/comments/4398986"},"html":{"href":"https://github.com/bbatsov/rubocop/pull/202#discussion_r4398986"},"pull_request":{"href":"https://api.github.com/repos/bbatsov/rubocop/pulls/202"}}}} | {
"id": 4095287,
"name": "rubocop",
"url": "https://github.com/bbatsov/rubocop"
} | {
"id": null,
"login": "whitequark",
"gravatar_id": "89d887b50262bbe10225d36d974fdb0c",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-05-27T11:05:01 | null | {"repository":{"description":"An experimental Ruby code analyzer, based on the community Ruby style guide.","homepage":"http://batsov.com/rubocop","watchers":495,"stargazers":495,"forks":33,"fork":false,"size":1624,"owner":"bbatsov","private":false,"open_issues":11,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Ruby","created_at":"2012-04-21T03:09:58-07:00","pushed_at":"2013-05-27T02:23:27-07:00","master_branch":"master"},"actor_attributes":{"type":"User","name":"Peter Zotov","company":"Evil Martians","blog":"http://whitequark.org","location":"Moscow, Russia","email":"[email protected]"},"url":"https://github.com/bbatsov/rubocop/pull/202#discussion_r4398986"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/slogsdon/vagrant-phalcon/pulls/comments/7716098","id":7716098,"diff_hunk":"@@ -27,42 +32,45 @@ else\n ./install\n wait\n \n- if [ ! -f '/etc/php5/mods-available/phalcon.ini' ]; then\n- # Ensure extension is loaded for php-cli and php-fpm\n- echo 'extension=phalcon.so' > /etc/php5/mods-available/phalcon.ini\n- ln -s /etc/php5/mods-available/phalcon.ini /etc/php5/cli/conf.d/phalcon.ini\n- ln -s /etc/php5/mods-available/phalcon.ini /etc/php5/fpm/conf.d/phalcon.ini\n+ # write ini config\n+ if ! (php --ri phalcon &>/dev/null); then\n+ if [ -d \"/etc/php5.d\" ]; then\n+ echo 'extension=phalcon.so' > /etc/php5.d/phalcon.ini\n+ elif [ -d \"/etc/php.d\" ]; then\n+ echo 'extension=phalcon.so' > /etc/php.d/phalcon.ini\n+ elif [ -d \"/etc/php5/mods-available\" ]; then\n+ echo 'extension=phalcon.so' > /etc/php5/mods-available/phalcon.ini\n+ [ -d '/etc/php5.d/cli' ] && ln -s /etc/php5/mods-available/phalcon.ini /etc/php5/cli/conf.d/phalcon.ini","path":"provision/shell/install_phalcon.sh","position":41,"original_position":41,"commit_id":"b89ecd215b207044354995de4066af78edf2ee5b","original_commit_id":"b89ecd215b207044354995de4066af78edf2ee5b","user":{"login":"slogsdon","id":647624,"avatar_url":"https://1.gravatar.com/avatar/50273ff02809593b620e59e10378d85a?d=https%3A%2F%2Fidenticons.github.com%2F4fb63421f5b829406a6dab385cb0ad19.png&r=x","gravatar_id":"50273ff02809593b620e59e10378d85a","url":"https://api.github.com/users/slogsdon","html_url":"https://github.com/slogsdon","followers_url":"https://api.github.com/users/slogsdon/followers","following_url":"https://api.github.com/users/slogsdon/following{/other_user}","gists_url":"https://api.github.com/users/slogsdon/gists{/gist_id}","starred_url":"https://api.github.com/users/slogsdon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slogsdon/subscriptions","organizations_url":"https://api.github.com/users/slogsdon/orgs","repos_url":"https://api.github.com/users/slogsdon/repos","events_url":"https://api.github.com/users/slogsdon/events{/privacy}","received_events_url":"https://api.github.com/users/slogsdon/received_events","type":"User","site_admin":false},"body":"Looks like there's a typo here and the next two lines in the tests. `/etc/php5.d` should be `/etc/php5`","created_at":"2013-11-18T03:38:13Z","updated_at":"2013-11-18T03:38:13Z","html_url":"https://github.com/slogsdon/vagrant-phalcon/pull/3#discussion_r7716098","pull_request_url":"https://api.github.com/repos/slogsdon/vagrant-phalcon/pulls/3","_links":{"self":{"href":"https://api.github.com/repos/slogsdon/vagrant-phalcon/pulls/comments/7716098"},"html":{"href":"https://github.com/slogsdon/vagrant-phalcon/pull/3#discussion_r7716098"},"pull_request":{"href":"https://api.github.com/repos/slogsdon/vagrant-phalcon/pulls/3"}}}} | {
"id": 11939906,
"name": "vagrant-phalcon",
"url": "https://github.com/slogsdon/vagrant-phalcon"
} | {
"id": null,
"login": "slogsdon",
"gravatar_id": "50273ff02809593b620e59e10378d85a",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-11-18T03:38:13 | null | {"repository":{"description":"a template for using Vagrant for developing PHP applications with Phalcon","watchers":36,"stargazers":36,"forks":8,"fork":false,"size":339,"owner":"slogsdon","private":false,"open_issues":1,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Ruby","created_at":"2013-08-06T19:50:59-07:00","pushed_at":"2013-08-10T06:19:08-07:00","master_branch":"master"},"actor_attributes":{"type":"User","name":"Shane Logsdon","company":"Blackstone Media / CityAnchor / RaspberryBadge","blog":"shanelogsdon.com","location":"Louisville, KY","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/slogsdon/vagrant-phalcon/pull/3#discussion_r7716098"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/stefanpenner/ember-app-kit/pulls/comments/6842548","id":6842548,"diff_hunk":"@@ -0,0 +1,88 @@\n+---\n+layout: default\n+title: \"Naming Conventions\"\n+permalink: naming-conventions.html\n+---\n+\n+When using Ember App Kit its important to keep in mind that the Resolver changes some of the naming conventions you would typically use out of the box with Ember, Ember Data and Handlebars. In this section we review some of these naming conventions.\n+\n+### Views and Templates\n+\n+Lets say we were using Ember out of the box with the following view:","path":"guides/naming-conventions.md","position":11,"original_position":11,"commit_id":"d7122e3c1f6e81bfed9b10794350eec1b9ea6c33","original_commit_id":"d7122e3c1f6e81bfed9b10794350eec1b9ea6c33","user":{"login":"jherdman","id":3300,"avatar_url":"https://2.gravatar.com/avatar/afd42fff23928a20972d60744fcdca4a?d=https%3A%2F%2Fidenticons.github.com%2F63bfd6e8f26d1d3537f4c5038264ef36.png","gravatar_id":"afd42fff23928a20972d60744fcdca4a","url":"https://api.github.com/users/jherdman","html_url":"https://github.com/jherdman","followers_url":"https://api.github.com/users/jherdman/followers","following_url":"https://api.github.com/users/jherdman/following{/other_user}","gists_url":"https://api.github.com/users/jherdman/gists{/gist_id}","starred_url":"https://api.github.com/users/jherdman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jherdman/subscriptions","organizations_url":"https://api.github.com/users/jherdman/orgs","repos_url":"https://api.github.com/users/jherdman/repos","events_url":"https://api.github.com/users/jherdman/events{/privacy}","received_events_url":"https://api.github.com/users/jherdman/received_events","type":"User","site_admin":false},"body":"Oh! Minor typo: \"Let's\", not \"Lets\".","created_at":"2013-10-08T22:31:28Z","updated_at":"2013-10-08T22:31:28Z","html_url":"https://github.com/stefanpenner/ember-app-kit/pull/223#discussion_r6842548","pull_request_url":"https://api.github.com/repos/stefanpenner/ember-app-kit/pulls/223","_links":{"self":{"href":"https://api.github.com/repos/stefanpenner/ember-app-kit/pulls/comments/6842548"},"html":{"href":"https://github.com/stefanpenner/ember-app-kit/pull/223#discussion_r6842548"},"pull_request":{"href":"https://api.github.com/repos/stefanpenner/ember-app-kit/pulls/223"}}}} | {
"id": 11080240,
"name": "ember-app-kit",
"url": "https://github.com/stefanpenner/ember-app-kit"
} | {
"id": null,
"login": "jherdman",
"gravatar_id": "afd42fff23928a20972d60744fcdca4a",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-10-08T22:31:28 | null | {"repository":{"description":"starting point for \"ambitious web applications\"","watchers":360,"stargazers":360,"forks":81,"fork":false,"size":2651,"owner":"stefanpenner","private":false,"open_issues":33,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"JavaScript","created_at":"2013-06-30T17:09:15-07:00","pushed_at":"2013-10-07T12:53:36-07:00","master_branch":"master"},"actor_attributes":{"type":"User","name":"James Herdman","company":"","blog":"http://jherdman.ca","location":"Toronto, ON","email":"[email protected]"},"url":"https://github.com/stefanpenner/ember-app-kit/pull/223#discussion_r6842548"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/ghub-yuichi/sample/pulls/comments/6711200","id":6711200,"body":"Good","diff_hunk":"@@ -5,5 +5,7 @@ This is a **sample**\n \n sample project\n \n+**ABC**","path":"README.md","position":4,"original_position":4,"commit_id":"8f851d7a13a1010ddc09192e00efbfbd5633e936","original_commit_id":"8f851d7a13a1010ddc09192e00efbfbd5633e936","user":{"login":"ghub-yuichi","id":5102855,"avatar_url":"https://0.gravatar.com/avatar/486b0c7a445862f77f2469ced74a0c07?d=https%3A%2F%2Fidenticons.github.com%2F32ce97ed0c502ba48861f8ac5537a577.png","gravatar_id":"486b0c7a445862f77f2469ced74a0c07","url":"https://api.github.com/users/ghub-yuichi","html_url":"https://github.com/ghub-yuichi","followers_url":"https://api.github.com/users/ghub-yuichi/followers","following_url":"https://api.github.com/users/ghub-yuichi/following{/other_user}","gists_url":"https://api.github.com/users/ghub-yuichi/gists{/gist_id}","starred_url":"https://api.github.com/users/ghub-yuichi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ghub-yuichi/subscriptions","organizations_url":"https://api.github.com/users/ghub-yuichi/orgs","repos_url":"https://api.github.com/users/ghub-yuichi/repos","events_url":"https://api.github.com/users/ghub-yuichi/events{/privacy}","received_events_url":"https://api.github.com/users/ghub-yuichi/received_events","type":"User"},"created_at":"2013-10-02T10:45:11Z","updated_at":"2013-10-02T10:45:11Z","html_url":"https://github.com/ghub-yuichi/sample/pull/3#discussion_r6711200","pull_request_url":"https://api.github.com/repos/ghub-yuichi/sample/pulls/3","_links":{"self":{"href":"https://api.github.com/repos/ghub-yuichi/sample/pulls/comments/6711200"},"html":{"href":"https://github.com/ghub-yuichi/sample/pull/3#discussion_r6711200"},"pull_request":{"href":"https://api.github.com/repos/ghub-yuichi/sample/pulls/3"}}}} | {
"id": 13237538,
"name": "sample",
"url": "https://github.com/ghub-yuichi/sample"
} | {
"id": null,
"login": "ghub-yuichi",
"gravatar_id": "486b0c7a445862f77f2469ced74a0c07",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-10-02T10:45:11 | null | {"repository":{"description":"sample project","watchers":0,"stargazers":0,"forks":0,"fork":false,"size":212,"owner":"ghub-yuichi","private":false,"open_issues":1,"has_issues":true,"has_downloads":true,"has_wiki":true,"created_at":"2013-10-01T00:31:05-07:00","pushed_at":"2013-10-02T03:43:40-07:00","master_branch":"master"},"actor_attributes":{"type":"User","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/ghub-yuichi/sample/pull/3#discussion_r6711200"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/benilovj/dbfit/pulls/comments/4573540","id":4573540,"body":"That is true if you are using a VM which I do not as my platform is Windows, hence the pull request. I can add a note about changing localhost if it isn't correct but the point mainly was to show how to access it by default and also about shutting it down cleanly.","diff_hunk":"@@ -81,6 +81,16 @@ The subsequent steps need to be followed on the project folder within the VM. To\n \n See the [ORACLE file](ORACLE.md).\n \n+#### Running from the build\n+\n+DbFit can be run from within the build area by running:\n+\n+ $ gradle start\n+\n+This will compile the source, copy the jars and resources to the `dist` directory and run up FitNesse with DbFit installed. Point your browser to [http://localhost:8085](http://localhost:8085) to access the running instance.","path":"CONTRIBUTING.md","position":10,"original_position":10,"commit_id":"55aae640a115c9dabaa3bc5a88cb9aa0fa7ddc01","original_commit_id":"55aae640a115c9dabaa3bc5a88cb9aa0fa7ddc01","user":{"login":"markhop","id":205925,"avatar_url":"https://secure.gravatar.com/avatar/0c1c25e923bcdb756c889e685d4bdc67?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"0c1c25e923bcdb756c889e685d4bdc67","url":"https://api.github.com/users/markhop","html_url":"https://github.com/markhop","followers_url":"https://api.github.com/users/markhop/followers","following_url":"https://api.github.com/users/markhop/following{/other_user}","gists_url":"https://api.github.com/users/markhop/gists{/gist_id}","starred_url":"https://api.github.com/users/markhop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markhop/subscriptions","organizations_url":"https://api.github.com/users/markhop/orgs","repos_url":"https://api.github.com/users/markhop/repos","events_url":"https://api.github.com/users/markhop/events{/privacy}","received_events_url":"https://api.github.com/users/markhop/received_events","type":"User"},"created_at":"2013-06-06T18:00:05Z","updated_at":"2013-06-06T18:00:05Z","html_url":"https://github.com/benilovj/dbfit/pull/123#discussion_r4573540","pull_request_url":"https://api.github.com/repos/benilovj/dbfit/pulls/123","_links":{"self":{"href":"https://api.github.com/repos/benilovj/dbfit/pulls/comments/4573540"},"html":{"href":"https://github.com/benilovj/dbfit/pull/123#discussion_r4573540"},"pull_request":{"href":"https://api.github.com/repos/benilovj/dbfit/pulls/123"}}}} | {
"id": 7283919,
"name": "dbfit",
"url": "https://github.com/benilovj/dbfit"
} | {
"id": null,
"login": "markhop",
"gravatar_id": "0c1c25e923bcdb756c889e685d4bdc67",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-06-06T18:00:05 | null | {"repository":{"description":"DbFit is a database testing framework that supports easy test-driven development of your database code.","homepage":"http://benilovj.github.com/dbfit","watchers":14,"stargazers":14,"forks":7,"fork":false,"size":916,"owner":"benilovj","private":false,"open_issues":49,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Java","created_at":"2012-12-22T00:26:13-08:00","pushed_at":"2013-05-30T14:08:11-07:00","master_branch":"master"},"actor_attributes":{"type":"User","name":"Mark Hopkins","company":"","blog":"","location":"Sheffield, United Kingdom","email":"[email protected]"},"url":"https://github.com/benilovj/dbfit/pull/123#discussion_r4573540"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/andymckay/tastypie-services/pulls/comments/3718486","id":3718486,"body":"80 chars","diff_hunk":"@@ -21,6 +26,27 @@ class Meta:\n serializer = Serializer(formats=['json'])\n \n def _handle_500(self, request, exception):\n+ import traceback\n+ import sys\n+ the_trace = '\\n'.join(traceback.format_exception(*(sys.exc_info())))\n+\n+ log = logging.getLogger('django.request.tastypie')\n+ log.error('Internal Server Error: %s' % request.path,\n+ exc_info=sys.exc_info(),\n+ extra={'status_code': 500, 'request': request})\n+\n+ # Only send email to admins if we're not in DEBUG mode\n+ if not (settings.DEBUG or isinstance(exception, (NotFound, ObjectDoesNotExist))):\n+ from django.core.mail import mail_admins\n+ subject = 'Error (%s IP): %s' % ((request.META.get('REMOTE_ADDR') in settings.INTERNAL_IPS and 'internal' or 'EXTERNAL'), request.path)","path":"tastypie_services/services.py","position":36,"original_position":36,"commit_id":"7a4acc91089c290d1b4f582e6fe1825bac45ccc9","original_commit_id":"7a4acc91089c290d1b4f582e6fe1825bac45ccc9","user":{"login":"mattbasta","id":279498,"avatar_url":"https://secure.gravatar.com/avatar/88fb40c25ad334d86f189821bbca1c9f?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"88fb40c25ad334d86f189821bbca1c9f","url":"https://api.github.com/users/mattbasta","html_url":"https://github.com/mattbasta","followers_url":"https://api.github.com/users/mattbasta/followers","following_url":"https://api.github.com/users/mattbasta/following","gists_url":"https://api.github.com/users/mattbasta/gists{/gist_id}","starred_url":"https://api.github.com/users/mattbasta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattbasta/subscriptions","organizations_url":"https://api.github.com/users/mattbasta/orgs","repos_url":"https://api.github.com/users/mattbasta/repos","events_url":"https://api.github.com/users/mattbasta/events{/privacy}","received_events_url":"https://api.github.com/users/mattbasta/received_events","type":"User"},"created_at":"2013-04-09T17:44:25Z","updated_at":"2013-04-09T17:44:25Z","html_url":"https://github.com/andymckay/tastypie-services/pull/1#discussion_r3718486","pull_request_url":"https://api.github.com/repos/andymckay/tastypie-services/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/andymckay/tastypie-services/pulls/comments/3718486"},"html":{"href":"https://github.com/andymckay/tastypie-services/pull/1#discussion_r3718486"},"pull_request":{"href":"https://api.github.com/repos/andymckay/tastypie-services/pulls/1"}}}} | {
"id": 7763851,
"name": "tastypie-services",
"url": "https://github.com/andymckay/tastypie-services"
} | {
"id": null,
"login": "mattbasta",
"gravatar_id": "88fb40c25ad334d86f189821bbca1c9f",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-04-09T17:44:25 | null | {"repository":{"description":"","watchers":1,"stargazers":1,"forks":1,"fork":false,"size":152,"owner":"andymckay","private":false,"open_issues":1,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Python","created_at":"2013-01-22T15:35:43-08:00","pushed_at":"2013-04-09T10:06:16-07:00","master_branch":"master"},"actor_attributes":{"type":"User","name":"Matt Basta","company":"Mozilla Corporation","blog":"http://mattbasta.com","location":"Mountain View, Ca","email":"[email protected]"},"url":"https://github.com/andymckay/tastypie-services/pull/1#discussion_r3718486"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/int3/doppio/pulls/comments/4492742","id":4492742,"body":"Aw man. I kindof wish you had git mv'd natives.coffee and edited it, since this is making a delta comparison difficult.\r\n\r\nI'm sure doing that for this change now is too much work, but food for future commits.","diff_hunk":"@@ -0,0 +1,1577 @@\n+\"use strict\"","path":"src/natives/main.coffee","position":1,"original_position":1,"commit_id":"527ced1ebad97aa2f1ea2b0fd10b5055b8f4df6f","original_commit_id":"527ced1ebad97aa2f1ea2b0fd10b5055b8f4df6f","user":{"login":"jvilk","id":1141042,"avatar_url":"https://secure.gravatar.com/avatar/6921fc1105cb69c5afe138c06a7f6ee8?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"6921fc1105cb69c5afe138c06a7f6ee8","url":"https://api.github.com/users/jvilk","html_url":"https://github.com/jvilk","followers_url":"https://api.github.com/users/jvilk/followers","following_url":"https://api.github.com/users/jvilk/following{/other_user}","gists_url":"https://api.github.com/users/jvilk/gists{/gist_id}","starred_url":"https://api.github.com/users/jvilk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jvilk/subscriptions","organizations_url":"https://api.github.com/users/jvilk/orgs","repos_url":"https://api.github.com/users/jvilk/repos","events_url":"https://api.github.com/users/jvilk/events{/privacy}","received_events_url":"https://api.github.com/users/jvilk/received_events","type":"User"},"created_at":"2013-06-02T23:06:11Z","updated_at":"2013-06-02T23:06:11Z","html_url":"https://github.com/int3/doppio/pull/223#discussion_r4492742","pull_request_url":"https://api.github.com/repos/int3/doppio/pulls/223","_links":{"self":{"href":"https://api.github.com/repos/int3/doppio/pulls/comments/4492742"},"html":{"href":"https://github.com/int3/doppio/pull/223#discussion_r4492742"},"pull_request":{"href":"https://api.github.com/repos/int3/doppio/pulls/223"}}}} | {
"id": 3434927,
"name": "doppio",
"url": "https://github.com/int3/doppio"
} | {
"id": null,
"login": "jvilk",
"gravatar_id": "6921fc1105cb69c5afe138c06a7f6ee8",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-06-02T23:06:11 | null | {"repository":{"description":"A JVM in Coffeescript.","homepage":"http://int3.github.io/doppio/","watchers":462,"stargazers":462,"forks":33,"fork":false,"size":1456,"owner":"int3","private":false,"open_issues":45,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"CoffeeScript","created_at":"2012-02-13T14:44:30-08:00","pushed_at":"2013-05-23T23:08:57-07:00","master_branch":"master"},"actor_attributes":{"type":"User","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/int3/doppio/pull/223#discussion_r4492742"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/mxcl/homebrew/pulls/comments/7972441","id":7972441,"diff_hunk":"@@ -0,0 +1,20 @@\n+require 'formula'\n+\n+class Dirt < Formula\n+ homepage 'https://github.com/yaxu/Dirt'\n+ head 'https://github.com/yaxu/Dirt.git'\n+ url 'https://github.com/yaxu/Dirt/archive/1c980c066e.tar.gz'\n+ sha1 '4bc5d45d57a6a14a193eab40af0cd00a5812134e'\n+ version '1c980c066e'\n+\n+ depends_on 'jack'\n+ depends_on 'liblo'\n+\n+ def install\n+ system \"make\", \"DESTDIR=#{prefix}\", \"install\"\n+ end\n+\n+ test do\n+ system \"[ -f #{bin}/dirt ]\"","path":"Library/Formula/dirt.rb","position":18,"original_position":18,"commit_id":"06220916efd22bcfea146fed542ee27f65414a66","original_commit_id":"06220916efd22bcfea146fed542ee27f65414a66","user":{"login":"mikemcquaid","id":125011,"avatar_url":"https://0.gravatar.com/avatar/215e0166d4d8265395c5d9076da73c70?d=https%3A%2F%2Fidenticons.github.com%2F19e490b885e34ade007230f7a58dc9a4.png&r=x","gravatar_id":"215e0166d4d8265395c5d9076da73c70","url":"https://api.github.com/users/mikemcquaid","html_url":"https://github.com/mikemcquaid","followers_url":"https://api.github.com/users/mikemcquaid/followers","following_url":"https://api.github.com/users/mikemcquaid/following{/other_user}","gists_url":"https://api.github.com/users/mikemcquaid/gists{/gist_id}","starred_url":"https://api.github.com/users/mikemcquaid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikemcquaid/subscriptions","organizations_url":"https://api.github.com/users/mikemcquaid/orgs","repos_url":"https://api.github.com/users/mikemcquaid/repos","events_url":"https://api.github.com/users/mikemcquaid/events{/privacy}","received_events_url":"https://api.github.com/users/mikemcquaid/received_events","type":"User","site_admin":false},"body":"@yaxu Ideally I'd like something that actually did something e.g. validate the config files. Otherwise help is better than nothing, yeh, thanks.","created_at":"2013-11-27T22:51:48Z","updated_at":"2013-11-27T22:51:48Z","html_url":"https://github.com/mxcl/homebrew/pull/24707#discussion_r7972441","pull_request_url":"https://api.github.com/repos/mxcl/homebrew/pulls/24707","_links":{"self":{"href":"https://api.github.com/repos/mxcl/homebrew/pulls/comments/7972441"},"html":{"href":"https://github.com/mxcl/homebrew/pull/24707#discussion_r7972441"},"pull_request":{"href":"https://api.github.com/repos/mxcl/homebrew/pulls/24707"}}}} | {
"id": 206084,
"name": "homebrew",
"url": "https://github.com/mxcl/homebrew"
} | {
"id": null,
"login": "mikemcquaid",
"gravatar_id": "215e0166d4d8265395c5d9076da73c70",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-11-27T22:51:48 | null | {"repository":{"description":"The missing package manager for OS X.","homepage":"http://brew.sh","watchers":14827,"stargazers":14827,"forks":7468,"fork":false,"size":1030003,"owner":"mxcl","private":false,"open_issues":278,"has_issues":true,"has_downloads":false,"has_wiki":true,"language":"Ruby","created_at":"2009-05-20T12:38:37-07:00","pushed_at":"2013-11-27T12:10:42-08:00","integrate_branch":"staging","master_branch":"master"},"actor_attributes":{"type":"User","name":"Mike McQuaid","company":"","blog":"mikemcquaid.com","location":"Edinburgh, Scotland","email":"[email protected]"},"url":"https://github.com/mxcl/homebrew/pull/24707#discussion_r7972441"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/fidelram/deepTools/pulls/comments/6679785","id":6679785,"body":"Maybe we should add a warning here. Lets imagine someone is using these options and cite it in a paper without knowing that smoothLength is actually resettet.","diff_hunk":"@@ -86,6 +86,9 @@ def parseArguments(args=None):\n \n args.extendPairedEnds = False if args.doNotExtendPairedEnds else True\n if args.scaleFactor != 1: args.normalizeTo1x = None\n+ if args.smoothLength <= args.binSize:\n+ args.smoothLength = None","path":"bin/bamCoverage","position":5,"original_position":5,"commit_id":"4b604fd0dd1c50509d5bb207c8ddc56f8981422f","original_commit_id":"4b604fd0dd1c50509d5bb207c8ddc56f8981422f","user":{"login":"bgruening","id":469983,"avatar_url":"https://1.gravatar.com/avatar/0d3b25c0462c70cbc963deba23a6297d?d=https%3A%2F%2Fidenticons.github.com%2Fea8a8f41d967d8296a802cf557ca4aa6.png","gravatar_id":"0d3b25c0462c70cbc963deba23a6297d","url":"https://api.github.com/users/bgruening","html_url":"https://github.com/bgruening","followers_url":"https://api.github.com/users/bgruening/followers","following_url":"https://api.github.com/users/bgruening/following{/other_user}","gists_url":"https://api.github.com/users/bgruening/gists{/gist_id}","starred_url":"https://api.github.com/users/bgruening/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bgruening/subscriptions","organizations_url":"https://api.github.com/users/bgruening/orgs","repos_url":"https://api.github.com/users/bgruening/repos","events_url":"https://api.github.com/users/bgruening/events{/privacy}","received_events_url":"https://api.github.com/users/bgruening/received_events","type":"User"},"created_at":"2013-10-01T07:32:57Z","updated_at":"2013-10-01T07:32:57Z","html_url":"https://github.com/fidelram/deepTools/pull/12#discussion_r6679785","pull_request_url":"https://api.github.com/repos/fidelram/deepTools/pulls/12","_links":{"self":{"href":"https://api.github.com/repos/fidelram/deepTools/pulls/comments/6679785"},"html":{"href":"https://github.com/fidelram/deepTools/pull/12#discussion_r6679785"},"pull_request":{"href":"https://api.github.com/repos/fidelram/deepTools/pulls/12"}}}} | {
"id": 11253779,
"name": "deepTools",
"url": "https://github.com/fidelram/deepTools"
} | {
"id": null,
"login": "bgruening",
"gravatar_id": "0d3b25c0462c70cbc963deba23a6297d",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-10-01T07:32:57 | null | {"repository":{"description":"Tools to process and analyze deep sequencing data.","watchers":4,"stargazers":4,"forks":2,"fork":false,"size":2981,"owner":"fidelram","private":false,"open_issues":4,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Python","created_at":"2013-07-08T05:30:28-07:00","pushed_at":"2013-10-01T00:10:20-07:00","master_branch":"master"},"actor_attributes":{"type":"User","name":"Björn Grüning","location":"Freiburg (Germany)","email":"[email protected]"},"url":"https://github.com/fidelram/deepTools/pull/12#discussion_r6679785"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/joshalbrecht/s3crate/pulls/comments/6364004","id":6364004,"body":"I'm curious why you left this outside of the try-except?","diff_hunk":"@@ -19,7 +61,26 @@ class LinuxFileTree(baseFolder: File, ec: ExecutionContext) extends LocalFileTre\n * @throws InaccessibleDataError wrapping all other non fatal errors\n * @return Return the appropriate FilePathType (folder, file, or symlink)\n */\n- def getFileType(file: File): FilePathType = throw new NotImplementedError()\n+ def getFileType(file: File): FilePathType = {\n+ //get Path from File\n+ val path = getPath(file) ","path":"src/main/scala/com/codexica/s3crate/filetree/local/LinuxFileTree.scala","position":67,"original_position":67,"commit_id":"fd88205fd66c6dd481dcb55beeb0ba9327e50cc0","original_commit_id":"fd88205fd66c6dd481dcb55beeb0ba9327e50cc0","user":{"login":"joshalbrecht","id":753892,"avatar_url":"https://0.gravatar.com/avatar/451e61f28488780fd131ba432fd77932?d=https%3A%2F%2Fidenticons.github.com%2F1b8d329457846c9302e9e112b8adeac0.png","gravatar_id":"451e61f28488780fd131ba432fd77932","url":"https://api.github.com/users/joshalbrecht","html_url":"https://github.com/joshalbrecht","followers_url":"https://api.github.com/users/joshalbrecht/followers","following_url":"https://api.github.com/users/joshalbrecht/following{/other_user}","gists_url":"https://api.github.com/users/joshalbrecht/gists{/gist_id}","starred_url":"https://api.github.com/users/joshalbrecht/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshalbrecht/subscriptions","organizations_url":"https://api.github.com/users/joshalbrecht/orgs","repos_url":"https://api.github.com/users/joshalbrecht/repos","events_url":"https://api.github.com/users/joshalbrecht/events{/privacy}","received_events_url":"https://api.github.com/users/joshalbrecht/received_events","type":"User"},"created_at":"2013-09-14T15:19:09Z","updated_at":"2013-09-14T15:19:09Z","html_url":"https://github.com/joshalbrecht/s3crate/pull/1#discussion_r6364004","pull_request_url":"https://api.github.com/repos/joshalbrecht/s3crate/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/joshalbrecht/s3crate/pulls/comments/6364004"},"html":{"href":"https://github.com/joshalbrecht/s3crate/pull/1#discussion_r6364004"},"pull_request":{"href":"https://api.github.com/repos/joshalbrecht/s3crate/pulls/1"}}}} | {
"id": 12670164,
"name": "s3crate",
"url": "https://github.com/joshalbrecht/s3crate"
} | {
"id": null,
"login": "joshalbrecht",
"gravatar_id": "451e61f28488780fd131ba432fd77932",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-09-14T15:19:09 | null | {"repository":{"description":"A secure, versioned (write-only), durable, efficient file synchronization system to uses S3 for storage","watchers":0,"stargazers":0,"forks":1,"fork":false,"size":367,"owner":"joshalbrecht","private":false,"open_issues":1,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Scala","created_at":"2013-09-07T12:18:35-07:00","pushed_at":"2013-09-13T12:30:17-07:00","master_branch":"master"},"actor_attributes":{"type":"User","name":"Josh Albrecht","company":"CloudFab","blog":"cloudfab.com","location":"Pittsburgh, PA","email":"[email protected]"},"url":"https://github.com/joshalbrecht/s3crate/pull/1#discussion_r6364004"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/gamerson/liferay-plugins/pulls/comments/5187231","id":5187231,"body":"Lets take the newline out.","diff_hunk":"@@ -0,0 +1,28 @@\n+/**\n+ * Copyright (c) 2000-2013 Liferay, Inc. All rights reserved.\n+ *\n+ * This library is free software; you can redistribute it and/or modify it under\n+ * the terms of the GNU Lesser General Public License as published by the Free\n+ * Software Foundation; either version 2.1 of the License, or (at your option)\n+ * any later version.\n+ *\n+ * This library is distributed in the hope that it will be useful, but WITHOUT\n+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS\n+ * FOR A PARTICULAR PURPOSE. See the GNU Lesser General Public License for more\n+ * details.\n+ */\n+\n+package com.liferay.servermanager.executor;\n+\n+/**\n+ * @author Cindy Li\n+ */\n+public class FMDebugPortExecutor extends DebugPortExecutor {\n+\n+\t@Override\n+\tprotected String getDebugPort() {\n+","path":"webs/server-manager-web/docroot/WEB-INF/src/com/liferay/servermanager/executor/FMDebugPortExecutor.java","position":24,"original_position":24,"commit_id":"6da4bf3d7a72d849f9a7e38fd2133ff395a44e43","original_commit_id":"6da4bf3d7a72d849f9a7e38fd2133ff395a44e43","user":{"login":"gamerson","id":595221,"avatar_url":"https://secure.gravatar.com/avatar/7fc2766b6aec8fe1803aefc4df1b8cf6?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"7fc2766b6aec8fe1803aefc4df1b8cf6","url":"https://api.github.com/users/gamerson","html_url":"https://github.com/gamerson","followers_url":"https://api.github.com/users/gamerson/followers","following_url":"https://api.github.com/users/gamerson/following{/other_user}","gists_url":"https://api.github.com/users/gamerson/gists{/gist_id}","starred_url":"https://api.github.com/users/gamerson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gamerson/subscriptions","organizations_url":"https://api.github.com/users/gamerson/orgs","repos_url":"https://api.github.com/users/gamerson/repos","events_url":"https://api.github.com/users/gamerson/events{/privacy}","received_events_url":"https://api.github.com/users/gamerson/received_events","type":"User"},"created_at":"2013-07-15T10:55:48Z","updated_at":"2013-07-15T10:55:48Z","html_url":"https://github.com/gamerson/liferay-plugins/pull/1#discussion_r5187231","pull_request_url":"https://api.github.com/repos/gamerson/liferay-plugins/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/gamerson/liferay-plugins/pulls/comments/5187231"},"html":{"href":"https://github.com/gamerson/liferay-plugins/pull/1#discussion_r5187231"},"pull_request":{"href":"https://api.github.com/repos/gamerson/liferay-plugins/pulls/1"}}}} | {
"id": 1929951,
"name": "liferay-plugins",
"url": "https://github.com/gamerson/liferay-plugins"
} | {
"id": null,
"login": "gamerson",
"gravatar_id": "7fc2766b6aec8fe1803aefc4df1b8cf6",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-07-15T10:55:48 | null | {"repository":{"description":"","homepage":"","watchers":1,"stargazers":1,"forks":0,"fork":true,"size":672,"owner":"gamerson","private":false,"open_issues":1,"has_issues":false,"has_downloads":true,"has_wiki":false,"language":"Java","created_at":"2011-06-21T08:47:45-07:00","pushed_at":"2013-07-14T20:03:06-07:00","master_branch":"master"},"actor_attributes":{"type":"User","name":"Gregory Amerson","company":"Liferay, Inc.","blog":"http://www.liferay.com/web/gregory.amerson/blog","location":"Dalian, China","email":"[email protected]"},"url":"https://github.com/gamerson/liferay-plugins/pull/1#discussion_r5187231"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/sindresorhus/pure/pulls/comments/6950680","id":6950680,"diff_hunk":"@@ -62,9 +64,10 @@ prompt_pure_precmd() {\n \t\tcommand git rev-parse --is-inside-work-tree &>/dev/null &&\n \t\t# check check if there is anything to pull\n \t\tcommand git fetch &>/dev/null &&\n+\t\tcommand git rev-parse --symbolic-full-name --abbrev-ref @'{u}' &>/dev/null &&\n \t\t(( $(command git rev-list --count HEAD...@'{u}' 2>/dev/null) > 0 )) &&\n \t\t# some crazy ansi magic to inject the symbol into the previous line\n-\t\tprintf \"\\e[A\\e[`prompt_pure_string_length $prompt_pure_preprompt`C\\e[90m⇣\\e[0m\\n\\e[2C\"\n+\t\tprint -Pn \"\\e[s\\e[A\\e[1G\\e[`prompt_pure_string_length $prompt_pure_preprompt`C%F{yellow}⇣%f\\e[u\"","path":"pure.zsh","position":19,"original_position":19,"commit_id":"97074087c0e5babbc4d9090fd56cbeb0fa8f2d36","original_commit_id":"97074087c0e5babbc4d9090fd56cbeb0fa8f2d36","user":{"login":"sindresorhus","id":170270,"avatar_url":"https://1.gravatar.com/avatar/d36a92237c75c5337c17b60d90686bf9?d=https%3A%2F%2Fidenticons.github.com%2F7fd6fb24bd6ad0594a07bfcc0bed6993.png","gravatar_id":"d36a92237c75c5337c17b60d90686bf9","url":"https://api.github.com/users/sindresorhus","html_url":"https://github.com/sindresorhus","followers_url":"https://api.github.com/users/sindresorhus/followers","following_url":"https://api.github.com/users/sindresorhus/following{/other_user}","gists_url":"https://api.github.com/users/sindresorhus/gists{/gist_id}","starred_url":"https://api.github.com/users/sindresorhus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sindresorhus/subscriptions","organizations_url":"https://api.github.com/users/sindresorhus/orgs","repos_url":"https://api.github.com/users/sindresorhus/repos","events_url":"https://api.github.com/users/sindresorhus/events{/privacy}","received_events_url":"https://api.github.com/users/sindresorhus/received_events","type":"User","site_admin":false},"body":"why `print -Pn`?","created_at":"2013-10-14T17:57:55Z","updated_at":"2013-10-14T17:57:55Z","html_url":"https://github.com/sindresorhus/pure/pull/30#discussion_r6950680","pull_request_url":"https://api.github.com/repos/sindresorhus/pure/pulls/30","_links":{"self":{"href":"https://api.github.com/repos/sindresorhus/pure/pulls/comments/6950680"},"html":{"href":"https://github.com/sindresorhus/pure/pull/30#discussion_r6950680"},"pull_request":{"href":"https://api.github.com/repos/sindresorhus/pure/pulls/30"}}}} | {
"id": 5890857,
"name": "pure",
"url": "https://github.com/sindresorhus/pure"
} | {
"id": null,
"login": "sindresorhus",
"gravatar_id": "d36a92237c75c5337c17b60d90686bf9",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-10-14T17:57:55 | null | {"repository":{"description":"Pretty, minimal and fast ZSH prompt","homepage":"http://sindresorhus.com","watchers":395,"stargazers":395,"forks":32,"fork":false,"size":585,"owner":"sindresorhus","private":false,"open_issues":10,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Shell","created_at":"2012-09-20T11:14:58-07:00","pushed_at":"2013-10-01T07:54:44-07:00","master_branch":"master"},"actor_attributes":{"type":"User","name":"Sindre Sorhus","company":"Passionate about creating stuff & moving the web forward. JavaScript developer. Open Source monomaniac. Doing; TodoMVC, TasteJS, Yeoman, Grunt, Bower","blog":"https://twitter.com/sindresorhus","location":"Norway","email":"[email protected]"},"url":"https://github.com/sindresorhus/pure/pull/30#discussion_r6950680"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/mxcl/homebrew/pulls/comments/6077380","id":6077380,"body":"Without it, when I run \r\n\r\n`brew uninstall fontforge; brew install fontforge --HEAD --debug --with-x`\r\n\r\nthen it fails. I press 5 to get a shell, and press up to get the previous command and rerun it, and this is what I get:\r\n\r\n```\r\n./configure --prefix=/usr/local/Cellar/fontforge/HEAD --enable-double --without-freetype-bytecode --without-cairo --without-pango --with-static-imagelibs --enable-pyextension\r\n...\r\nchecking for library containing XOpenDevice... -lXi\r\nchecking for library containing XkbQueryExtension... none required\r\nchecking for ZLIB... no\r\nconfigure: error: Package requirements (zlib) were not met:\r\n\r\nNo package 'zlib' found\r\n\r\nConsider adjusting the PKG_CONFIG_PATH environment variable if you\r\ninstalled software in a non-standard prefix.\r\n\r\nAlternatively, you may set the environment variables ZLIB_CFLAGS\r\nand ZLIB_LIBS to avoid the need to call pkg-config.\r\nSee the pkg-config man page for more details.\r\nbash-3.2$ \r\n```","diff_hunk":"@@ -51,6 +61,12 @@ def install\n # Fix linker error; see: http://trac.macports.org/ticket/25012\n ENV.append \"LDFLAGS\", \"-lintl\"\n \n+ # Add environment variables for system libs if building head","path":"Library/Formula/fontforge.rb","position":29,"original_position":29,"commit_id":"56e161361c26c7d49a95782a679f60fbb7ec7138","original_commit_id":"56e161361c26c7d49a95782a679f60fbb7ec7138","user":{"login":"davelab6","id":261579,"avatar_url":"https://0.gravatar.com/avatar/65c68dcaace6962cd1353c270eb0801b?d=https%3A%2F%2Fidenticons.github.com%2F3937502504b2c44cef3774de076d8948.png","gravatar_id":"65c68dcaace6962cd1353c270eb0801b","url":"https://api.github.com/users/davelab6","html_url":"https://github.com/davelab6","followers_url":"https://api.github.com/users/davelab6/followers","following_url":"https://api.github.com/users/davelab6/following{/other_user}","gists_url":"https://api.github.com/users/davelab6/gists{/gist_id}","starred_url":"https://api.github.com/users/davelab6/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davelab6/subscriptions","organizations_url":"https://api.github.com/users/davelab6/orgs","repos_url":"https://api.github.com/users/davelab6/repos","events_url":"https://api.github.com/users/davelab6/events{/privacy}","received_events_url":"https://api.github.com/users/davelab6/received_events","type":"User"},"created_at":"2013-08-30T00:45:11Z","updated_at":"2013-08-30T00:45:11Z","html_url":"https://github.com/mxcl/homebrew/pull/22201#discussion_r6077380","pull_request_url":"https://api.github.com/repos/mxcl/homebrew/pulls/22201","_links":{"self":{"href":"https://api.github.com/repos/mxcl/homebrew/pulls/comments/6077380"},"html":{"href":"https://github.com/mxcl/homebrew/pull/22201#discussion_r6077380"},"pull_request":{"href":"https://api.github.com/repos/mxcl/homebrew/pulls/22201"}}}} | {
"id": 206084,
"name": "homebrew",
"url": "https://github.com/mxcl/homebrew"
} | {
"id": null,
"login": "davelab6",
"gravatar_id": "65c68dcaace6962cd1353c270eb0801b",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-08-30T00:45:11 | null | {"repository":{"description":"The missing package manager for OS X.","homepage":"http://brew.sh","watchers":13716,"stargazers":13716,"forks":6792,"fork":false,"size":876006,"owner":"mxcl","private":false,"open_issues":315,"has_issues":true,"has_downloads":false,"has_wiki":true,"language":"Ruby","created_at":"2009-05-20T12:38:37-07:00","pushed_at":"2013-08-29T17:23:32-07:00","integrate_branch":"staging","master_branch":"master"},"actor_attributes":{"type":"User","name":"Dave Crossland","company":"Understanding Limited","blog":"http://understandinglimited.com","location":"","email":"[email protected]"},"url":"https://github.com/mxcl/homebrew/pull/22201#discussion_r6077380"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/dkomanov/fizteh-java-2013/pulls/comments/7022724","id":7022724,"diff_hunk":"@@ -0,0 +1,37 @@\n+package ru.fizteh.fivt.students.kislenko.filemap;\n+\n+import java.io.*;\n+import java.util.*;\n+\n+public class MapBuilder {\n+ void buildMap(State state) throws IOException {\n+ RandomAccessFile database = new RandomAccessFile(state.getPath().toFile(), \"rw\");","path":"src/ru/fizteh/fivt/students/kislenko/filemap/MapBuilder.java","position":8,"original_position":8,"commit_id":"421be77ed0ae214ee9fe266c677fc8052cac43a9","original_commit_id":"421be77ed0ae214ee9fe266c677fc8052cac43a9","user":{"login":"cymkuh","id":1057798,"avatar_url":"https://1.gravatar.com/avatar/fd7c2a85a59757ce3ddedccb8307dd23?d=https%3A%2F%2Fidenticons.github.com%2Ff10b5d47869e163a592a0774f1b526db.png","gravatar_id":"fd7c2a85a59757ce3ddedccb8307dd23","url":"https://api.github.com/users/cymkuh","html_url":"https://github.com/cymkuh","followers_url":"https://api.github.com/users/cymkuh/followers","following_url":"https://api.github.com/users/cymkuh/following{/other_user}","gists_url":"https://api.github.com/users/cymkuh/gists{/gist_id}","starred_url":"https://api.github.com/users/cymkuh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cymkuh/subscriptions","organizations_url":"https://api.github.com/users/cymkuh/orgs","repos_url":"https://api.github.com/users/cymkuh/repos","events_url":"https://api.github.com/users/cymkuh/events{/privacy}","received_events_url":"https://api.github.com/users/cymkuh/received_events","type":"User","site_admin":false},"body":"Вы принципиально не закрываете открытых дескрипторов?","created_at":"2013-10-17T03:10:31Z","updated_at":"2013-10-17T03:10:31Z","html_url":"https://github.com/dkomanov/fizteh-java-2013/pull/126#discussion_r7022724","pull_request_url":"https://api.github.com/repos/dkomanov/fizteh-java-2013/pulls/126","_links":{"self":{"href":"https://api.github.com/repos/dkomanov/fizteh-java-2013/pulls/comments/7022724"},"html":{"href":"https://github.com/dkomanov/fizteh-java-2013/pull/126#discussion_r7022724"},"pull_request":{"href":"https://api.github.com/repos/dkomanov/fizteh-java-2013/pulls/126"}}}} | {
"id": 12724757,
"name": "fizteh-java-2013",
"url": "https://github.com/dkomanov/fizteh-java-2013"
} | {
"id": null,
"login": "cymkuh",
"gravatar_id": "fd7c2a85a59757ce3ddedccb8307dd23",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-10-17T03:10:31 | null | {"repository":{"description":" Курс лекций и семинаров для студентов второго курса ФизТеха, факультет ФИВТ (2013 год).","watchers":0,"stargazers":0,"forks":64,"fork":false,"size":13533,"owner":"dkomanov","private":false,"open_issues":49,"has_issues":true,"has_downloads":true,"has_wiki":false,"language":"Java","created_at":"2013-09-10T01:51:23-07:00","pushed_at":"2013-10-16T18:17:50-07:00","master_branch":"master"},"actor_attributes":{"type":"User","name":"Fedor S. Lavrentyev","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/dkomanov/fizteh-java-2013/pull/126#discussion_r7022724"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/aliHafizji/Cheddar-Android/pulls/comments/3889823","id":3889823,"body":"This is needed for tablet interface. I haven't found another alternative, since the action bar is shared with both the list and list item fragments.\r\nWhat this means is that there would be 2 refresh buttons next to each other with the ability to distinguish between any","diff_hunk":"@@ -12,7 +12,6 @@ Get the latest source\n \n The project depends on some external libraries.\n \n- * [Android-PullToRefresh](https://github.com/chrisbanes/Android-PullToRefresh)","path":"README.md","position":4,"original_position":4,"commit_id":"efc90fe68228cbb520c3eb80c1138b7d0c9dd6d9","original_commit_id":"efc90fe68228cbb520c3eb80c1138b7d0c9dd6d9","user":{"login":"aliHafizji","id":283681,"avatar_url":"https://secure.gravatar.com/avatar/80d3de3c918b58aa4baa91414d03e795?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"80d3de3c918b58aa4baa91414d03e795","url":"https://api.github.com/users/aliHafizji","html_url":"https://github.com/aliHafizji","followers_url":"https://api.github.com/users/aliHafizji/followers","following_url":"https://api.github.com/users/aliHafizji/following","gists_url":"https://api.github.com/users/aliHafizji/gists{/gist_id}","starred_url":"https://api.github.com/users/aliHafizji/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aliHafizji/subscriptions","organizations_url":"https://api.github.com/users/aliHafizji/orgs","repos_url":"https://api.github.com/users/aliHafizji/repos","events_url":"https://api.github.com/users/aliHafizji/events{/privacy}","received_events_url":"https://api.github.com/users/aliHafizji/received_events","type":"User"},"created_at":"2013-04-22T05:15:28Z","updated_at":"2013-04-22T05:15:28Z","html_url":"https://github.com/aliHafizji/Cheddar-Android/pull/2#discussion_r3889823","pull_request_url":"https://api.github.com/repos/aliHafizji/Cheddar-Android/pulls/2","_links":{"self":{"href":"https://api.github.com/repos/aliHafizji/Cheddar-Android/pulls/comments/3889823"},"html":{"href":"https://github.com/aliHafizji/Cheddar-Android/pull/2#discussion_r3889823"},"pull_request":{"href":"https://api.github.com/repos/aliHafizji/Cheddar-Android/pulls/2"}}}} | {
"id": 6693804,
"name": "Cheddar-Android",
"url": "https://github.com/aliHafizji/Cheddar-Android"
} | {
"id": null,
"login": "aliHafizji",
"gravatar_id": "80d3de3c918b58aa4baa91414d03e795",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-04-22T05:15:28 | null | {"repository":{"description":"The Android version of Cheddar(https://github.com/nothingmagical/cheddar-ios)","watchers":27,"stargazers":27,"forks":3,"fork":false,"size":200,"owner":"aliHafizji","private":false,"open_issues":1,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Java","created_at":"2012-11-14T11:48:11-08:00","pushed_at":"2013-01-17T12:21:51-08:00","master_branch":"master"},"actor_attributes":{"type":"User","name":"Kauserali","blog":"https://twitter.com/Ali_hafizji","location":"India","email":"[email protected]"},"url":"https://github.com/aliHafizji/Cheddar-Android/pull/2#discussion_r3889823"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/DinaSaad/sharesoft-13/pulls/comments/3966973","id":3966973,"body":"Delete this print","diff_hunk":"@@ -203,10 +203,45 @@ def report_the_post(self, post, report_reason):\n reported_post.no_of_reports = reported_post.no_of_reports + 1\n reported_post.save() \n \n+ \n+ #c1_abdelrahman the method takes self as an argument. \n+ # It checks whether the user has the prevalage to post or not.\n+ #the return type is whether true or false. \n+ # if the user is not verfied the method returns false \n+ # else if the user is premium the method return true without checking any further condition. \n+ # but if the user is not premium but verfied then the method check the user's number of active posts if it is below three the method return true else it returns false.\n def can_post(self):\n- return self.is_verfied\n-\n+ no_of_user_active_posts = Post.objects.filter(seller = self).exclude(state='sold').exclude(state='Archived').count()\n+ print no_of_user_active_posts","path":"project/tager/tager_www/models.py","position":15,"original_position":15,"commit_id":"f94cc5e349e2e2a4278fe1475b8d9a446e4d87ca","original_commit_id":"f94cc5e349e2e2a4278fe1475b8d9a446e4d87ca","user":{"login":"BeshoSmile","id":3515278,"avatar_url":"https://secure.gravatar.com/avatar/aa0700cb606810d6e0148d64decb6a5a?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"aa0700cb606810d6e0148d64decb6a5a","url":"https://api.github.com/users/BeshoSmile","html_url":"https://github.com/BeshoSmile","followers_url":"https://api.github.com/users/BeshoSmile/followers","following_url":"https://api.github.com/users/BeshoSmile/following","gists_url":"https://api.github.com/users/BeshoSmile/gists{/gist_id}","starred_url":"https://api.github.com/users/BeshoSmile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BeshoSmile/subscriptions","organizations_url":"https://api.github.com/users/BeshoSmile/orgs","repos_url":"https://api.github.com/users/BeshoSmile/repos","events_url":"https://api.github.com/users/BeshoSmile/events{/privacy}","received_events_url":"https://api.github.com/users/BeshoSmile/received_events","type":"User"},"created_at":"2013-04-25T21:33:46Z","updated_at":"2013-04-25T21:33:46Z","html_url":"https://github.com/DinaSaad/sharesoft-13/pull/203#discussion_r3966973","pull_request_url":"https://api.github.com/repos/DinaSaad/sharesoft-13/pulls/203","_links":{"self":{"href":"https://api.github.com/repos/DinaSaad/sharesoft-13/pulls/comments/3966973"},"html":{"href":"https://github.com/DinaSaad/sharesoft-13/pull/203#discussion_r3966973"},"pull_request":{"href":"https://api.github.com/repos/DinaSaad/sharesoft-13/pulls/203"}}}} | {
"id": 7990870,
"name": "sharesoft-13",
"url": "https://github.com/DinaSaad/sharesoft-13"
} | {
"id": null,
"login": "BeshoSmile",
"gravatar_id": "aa0700cb606810d6e0148d64decb6a5a",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-04-25T21:33:46 | null | {"repository":{"description":"","watchers":1,"stargazers":1,"forks":0,"fork":false,"size":1352,"owner":"DinaSaad","private":false,"open_issues":70,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"JavaScript","created_at":"2013-02-03T05:29:50-08:00","pushed_at":"2013-04-25T14:02:42-07:00","master_branch":"master"},"actor_attributes":{"type":"User","name":"BeshoSmile","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/DinaSaad/sharesoft-13/pull/203#discussion_r3966973"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/dkomanov/fizteh-java-2013/pulls/comments/8534188","id":8534188,"diff_hunk":"@@ -0,0 +1,161 @@\n+package ru.fizteh.fivt.students.lizaignatyeva.database;\n+\n+import ru.fizteh.fivt.storage.structured.ColumnFormatException;\n+import ru.fizteh.fivt.storage.structured.Storeable;\n+import ru.fizteh.fivt.storage.structured.Table;\n+import ru.fizteh.fivt.storage.structured.TableProvider;\n+\n+import java.io.File;\n+import java.io.IOException;\n+import java.nio.file.Path;\n+import java.text.ParseException;\n+import java.util.HashMap;\n+import java.util.HashSet;\n+import java.util.List;\n+import java.util.zip.DataFormatException;\n+\n+public class MyTableProvider implements TableProvider {\n+ private Path directory;\n+\n+ private HashMap<String, MyTable> loadedTables;\n+\n+ public MyTableProvider(Path directory) {\n+ this.directory = directory;\n+ this.loadedTables = new HashMap<>();\n+ }\n+\n+ @Override\n+ public MyTable createTable(String name, List<Class<?>> columnTypes) throws IOException {\n+ checkTableName(name);\n+ if (columnTypes == null || columnTypes.size() == 0) {\n+ throw new IllegalArgumentException(\"TableProvider.createTable: null columnTypes is illegal\");\n+ }\n+ for (Class clazz : columnTypes) {\n+ if (clazz == null) {\n+ throw new IllegalArgumentException(\"TableProvider.createTable: null column type\");\n+ }\n+ }\n+ StoreableSignature storeableSignature = new StoreableSignature(columnTypes);\n+ MyStoreable storeable = new MyStoreable(storeableSignature); // test for class correctness\n+ MyTable table = new MyTable(directory, name, storeableSignature, this);\n+ if (MyTable.exists(directory, name)) {\n+ return null;\n+ }\n+ try {\n+ table.write();\n+ } catch (IOException e) {\n+ throw new IllegalArgumentException(\"TableProvider.createTable: name '\" + name + \"' failed: IO failure\");","path":"src/ru/fizteh/fivt/students/lizaignatyeva/database/MyTableProvider.java","position":47,"original_position":47,"commit_id":"0831bf361107245a8fcb691163b2ef798c952a5f","original_commit_id":"0831bf361107245a8fcb691163b2ef798c952a5f","user":{"login":"dkomanov","id":1158662,"avatar_url":"https://gravatar.com/avatar/0ea5f6f63ed38a93d2e881fc461e56b3?d=https%3A%2F%2Fidenticons.github.com%2F7ca4dceeaa033f89f0f922ab0f87efe7.png&r=x","gravatar_id":"0ea5f6f63ed38a93d2e881fc461e56b3","url":"https://api.github.com/users/dkomanov","html_url":"https://github.com/dkomanov","followers_url":"https://api.github.com/users/dkomanov/followers","following_url":"https://api.github.com/users/dkomanov/following{/other_user}","gists_url":"https://api.github.com/users/dkomanov/gists{/gist_id}","starred_url":"https://api.github.com/users/dkomanov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dkomanov/subscriptions","organizations_url":"https://api.github.com/users/dkomanov/orgs","repos_url":"https://api.github.com/users/dkomanov/repos","events_url":"https://api.github.com/users/dkomanov/events{/privacy}","received_events_url":"https://api.github.com/users/dkomanov/received_events","type":"User","site_admin":false},"body":"Тут cause","created_at":"2013-12-23T20:41:56Z","updated_at":"2013-12-23T20:41:56Z","html_url":"https://github.com/dkomanov/fizteh-java-2013/pull/441#discussion_r8534188","pull_request_url":"https://api.github.com/repos/dkomanov/fizteh-java-2013/pulls/441","_links":{"self":{"href":"https://api.github.com/repos/dkomanov/fizteh-java-2013/pulls/comments/8534188"},"html":{"href":"https://github.com/dkomanov/fizteh-java-2013/pull/441#discussion_r8534188"},"pull_request":{"href":"https://api.github.com/repos/dkomanov/fizteh-java-2013/pulls/441"}}}} | {
"id": 12724757,
"name": "fizteh-java-2013",
"url": "https://github.com/dkomanov/fizteh-java-2013"
} | {
"id": null,
"login": "dkomanov",
"gravatar_id": "0ea5f6f63ed38a93d2e881fc461e56b3",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-12-23T20:41:56 | null | {"repository":{"description":" Курс лекций и семинаров для студентов второго курса ФизТеха, факультет ФИВТ (2013 год).","watchers":3,"stargazers":3,"forks":70,"fork":false,"size":37590,"owner":"dkomanov","private":false,"open_issues":30,"has_issues":true,"has_downloads":true,"has_wiki":false,"language":"Java","created_at":"2013-09-10T01:51:23-07:00","pushed_at":"2013-12-23T11:14:11-08:00","master_branch":"master"},"actor_attributes":{"type":"User","name":"Dmitriy Komanov","blog":"http://dkomanov.livejournal.com","location":"Russia, Moscow","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/dkomanov/fizteh-java-2013/pull/441#discussion_r8534188"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/gregmarra/the-blue-alliance/pulls/comments/6504058","id":6504058,"body":"Yea this is simply to make the permission descriptions visible to the template.","diff_hunk":"@@ -33,7 +34,8 @@ def get(self, user_id):\n user = Account.get_by_id(user_id)\n \n self.template_values.update({\n- \"user\": user\n+ \"user\": user,\n+ \"permissions\": AccountPermissions.descriptions","path":"controllers/admin/admin_user_controller.py","position":14,"original_position":14,"commit_id":"c9859e303a3c0336604cd6a04ce7225425a1a80d","original_commit_id":"c9859e303a3c0336604cd6a04ce7225425a1a80d","user":{"login":"chrismarra","id":388350,"avatar_url":"https://1.gravatar.com/avatar/52036dd601713cb274f241b7375fe540?d=https%3A%2F%2Fidenticons.github.com%2F925cc68e315ab1fcb0face1aa83b3c09.png","gravatar_id":"52036dd601713cb274f241b7375fe540","url":"https://api.github.com/users/chrismarra","html_url":"https://github.com/chrismarra","followers_url":"https://api.github.com/users/chrismarra/followers","following_url":"https://api.github.com/users/chrismarra/following{/other_user}","gists_url":"https://api.github.com/users/chrismarra/gists{/gist_id}","starred_url":"https://api.github.com/users/chrismarra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrismarra/subscriptions","organizations_url":"https://api.github.com/users/chrismarra/orgs","repos_url":"https://api.github.com/users/chrismarra/repos","events_url":"https://api.github.com/users/chrismarra/events{/privacy}","received_events_url":"https://api.github.com/users/chrismarra/received_events","type":"User"},"created_at":"2013-09-22T01:48:33Z","updated_at":"2013-09-22T01:48:33Z","html_url":"https://github.com/gregmarra/the-blue-alliance/pull/757#discussion_r6504058","pull_request_url":"https://api.github.com/repos/gregmarra/the-blue-alliance/pulls/757","_links":{"self":{"href":"https://api.github.com/repos/gregmarra/the-blue-alliance/pulls/comments/6504058"},"html":{"href":"https://github.com/gregmarra/the-blue-alliance/pull/757#discussion_r6504058"},"pull_request":{"href":"https://api.github.com/repos/gregmarra/the-blue-alliance/pulls/757"}}}} | {
"id": 888427,
"name": "the-blue-alliance",
"url": "https://github.com/gregmarra/the-blue-alliance"
} | {
"id": null,
"login": "chrismarra",
"gravatar_id": "52036dd601713cb274f241b7375fe540",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-09-22T01:48:33 | null | {"repository":{"description":"FIRST Robotics match video archive website","homepage":"thebluealliance.com","watchers":48,"stargazers":48,"forks":20,"fork":false,"size":11863,"owner":"gregmarra","private":false,"open_issues":1,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"JavaScript","created_at":"2010-09-04T13:34:11-07:00","pushed_at":"2013-09-21T18:34:07-07:00","master_branch":"master"},"actor_attributes":{"type":"User","name":"Chris Marra","company":"The Blue Alliance","blog":"thebluealliance.net","email":"13c378527e052b1420bed89169dda6fe83c27555"},"url":"https://github.com/gregmarra/the-blue-alliance/pull/757#discussion_r6504058"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/lgtml/redis/pulls/comments/7777015","id":7777015,"diff_hunk":"@@ -630,6 +694,7 @@ void persistCommand(redisClient *c) {\n addReply(c,shared.czero);\n } else {\n if (removeExpire(c->db,c->argv[1])) {\n+ removeExpireNotify(c->db,c->argv[1]);","path":"src/db.c","position":135,"original_position":135,"commit_id":"8b3254b1a0d073f284f2748e65ee78fc347db010","original_commit_id":"8b3254b1a0d073f284f2748e65ee78fc347db010","user":{"login":"lgtml","id":823822,"avatar_url":"https://2.gravatar.com/avatar/e52f598cb1ac54aa9c45b2b665af260c?d=https%3A%2F%2Fidenticons.github.com%2Fa565f187d2bd3ebc1e238d8417d58554.png&r=x","gravatar_id":"e52f598cb1ac54aa9c45b2b665af260c","url":"https://api.github.com/users/lgtml","html_url":"https://github.com/lgtml","followers_url":"https://api.github.com/users/lgtml/followers","following_url":"https://api.github.com/users/lgtml/following{/other_user}","gists_url":"https://api.github.com/users/lgtml/gists{/gist_id}","starred_url":"https://api.github.com/users/lgtml/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lgtml/subscriptions","organizations_url":"https://api.github.com/users/lgtml/orgs","repos_url":"https://api.github.com/users/lgtml/repos","events_url":"https://api.github.com/users/lgtml/events{/privacy}","received_events_url":"https://api.github.com/users/lgtml/received_events","type":"User","site_admin":false},"body":"Nope it does not but makes sense to add it there more :)","created_at":"2013-11-19T23:20:18Z","updated_at":"2013-11-19T23:20:18Z","html_url":"https://github.com/lgtml/redis/pull/1#discussion_r7777015","pull_request_url":"https://api.github.com/repos/lgtml/redis/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/lgtml/redis/pulls/comments/7777015"},"html":{"href":"https://github.com/lgtml/redis/pull/1#discussion_r7777015"},"pull_request":{"href":"https://api.github.com/repos/lgtml/redis/pulls/1"}}}} | {
"id": 14219135,
"name": "redis",
"url": "https://github.com/lgtml/redis"
} | {
"id": null,
"login": "lgtml",
"gravatar_id": "e52f598cb1ac54aa9c45b2b665af260c",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-11-19T23:20:18 | null | {"repository":{"description":"Redis is an in-memory database that persists on disk. The data model is key-value, but many different kind of values are supported: Strings, Lists, Sets, Sorted Sets, Hashes","homepage":"http://redis.io","watchers":0,"stargazers":0,"forks":0,"fork":true,"size":7860,"owner":"lgtml","private":false,"open_issues":1,"has_issues":false,"has_downloads":true,"has_wiki":true,"language":"C","created_at":"2013-11-07T15:32:55-08:00","pushed_at":"2013-11-18T18:28:59-08:00","master_branch":"2.2"},"actor_attributes":{"type":"User","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/lgtml/redis/pull/1#discussion_r7777015"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/taea/ktra/pulls/comments/6320060","id":6320060,"body":"実はワザとです。\r\n後のコミットで直そうかなーと。\r\n\r\nツッコミありがとうござきます！！！","diff_hunk":"@@ -0,0 +1,32 @@\n+require 'spec_helper'\n+\n+describe Iteration do\n+ let(:iteration) { create(:iteration) }\n+ describe 'イテレーションが生成出来る' do\n+ subject { iteration }\n+ it { should be_instance_of Iteration }\n+ end\n+\n+ describe 'relations' do\n+ it { should have_many :tasks }\n+ end\n+\n+ describe '#total_point' do\n+ subject { iteration.total_point }\n+ context 'タスクが存在する場合' do\n+ let(:tasks) { [create(:task), create(:task)] }\n+ before do\n+ iteration.tasks = tasks\n+ end\n+ it '合計値が算出できること' do\n+ should eq tasks.size","path":"spec/models/iteration_spec.rb","position":22,"original_position":22,"commit_id":"3e2658c6eacca1e44b605d8fac0e487a6241f319","original_commit_id":"3e2658c6eacca1e44b605d8fac0e487a6241f319","user":{"login":"ppworks","id":536118,"avatar_url":"https://0.gravatar.com/avatar/40961ce2e3a7035867843b520000e5b3?d=https%3A%2F%2Fidenticons.github.com%2F76b9fdeba790feeaa47531117ff0ab60.png","gravatar_id":"40961ce2e3a7035867843b520000e5b3","url":"https://api.github.com/users/ppworks","html_url":"https://github.com/ppworks","followers_url":"https://api.github.com/users/ppworks/followers","following_url":"https://api.github.com/users/ppworks/following{/other_user}","gists_url":"https://api.github.com/users/ppworks/gists{/gist_id}","starred_url":"https://api.github.com/users/ppworks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ppworks/subscriptions","organizations_url":"https://api.github.com/users/ppworks/orgs","repos_url":"https://api.github.com/users/ppworks/repos","events_url":"https://api.github.com/users/ppworks/events{/privacy}","received_events_url":"https://api.github.com/users/ppworks/received_events","type":"User"},"created_at":"2013-09-12T12:32:23Z","updated_at":"2013-09-12T12:32:23Z","html_url":"https://github.com/taea/ktra/pull/18#discussion_r6320060","pull_request_url":"https://api.github.com/repos/taea/ktra/pulls/18","_links":{"self":{"href":"https://api.github.com/repos/taea/ktra/pulls/comments/6320060"},"html":{"href":"https://github.com/taea/ktra/pull/18#discussion_r6320060"},"pull_request":{"href":"https://api.github.com/repos/taea/ktra/pulls/18"}}}} | {
"id": 9670122,
"name": "ktra",
"url": "https://github.com/taea/ktra"
} | {
"id": null,
"login": "ppworks",
"gravatar_id": "40961ce2e3a7035867843b520000e5b3",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-09-12T12:32:23 | null | {"repository":{"description":"K-tra! The Lightweight Task Tracker","homepage":"http://ktra.herokuapp.com","watchers":8,"stargazers":8,"forks":0,"fork":false,"size":7988,"owner":"taea","private":false,"open_issues":5,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Ruby","created_at":"2013-04-25T04:18:34-07:00","pushed_at":"2013-09-12T04:40:53-07:00","master_branch":"master"},"actor_attributes":{"type":"User","name":"Naoto Koshikawa","company":"ppworks","blog":"http://ppworks.info","location":"Tokyo","email":"[email protected]"},"url":"https://github.com/taea/ktra/pull/18#discussion_r6320060"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/markmccanna1/rest_man/pulls/comments/6285256","id":6285256,"body":"remove 2 console.log's","diff_hunk":"@@ -1,55 +1,171 @@\n-var FloorPlan = {\n- init: function(){\n- this.draw = SVG('floorplan').size('100%','100%')\n- this.tables = new Array()\n- }\n+// var FloorPlan = {\n+// init: function(){\n+// this.draw = SVG('floorplan').size('100%','100%')\n+// this.tables = new Array()\n+// }\n+// }\n+\n+// var Table = {\n+// init: function(id){\n+// this.table = FloorPlan.draw.circle(100,100).attr({fill: 'white', class: 'table', id: 'table' + id})\n+// this.table.stroke({color: 'black', width: 2})\n+// this.table.draggable()\n+// this.table.center('5%', '35%')\n+// this.table.click(this.addClickEvent)\n+// FloorPlan.tables.push(this)\n+// this.chairs = new Array()\n+// return this\n+// },\n+\n+// addClickEvent: function(){\n+// elementId = this.attr('id')\n+// table = Table.getTableById(elementId)\n+// console.log(elementId)\n+// var idPat = /\\d/\n+// var dataTag = idPat.exec(elementId)[0]\n+// console.log(dataTag[0])\n+// var form = '<form action=\"/stream\" method=\"post\" id=\"check_in\"> <input type=\"submit\" value=\"Check In\"> <input type=\"hidden\" value=\"'+ elementId + '\" name=example> </form>'\n+// $('#header').append(form)\n+// table.table.fill('black')\n+// Table.table.click(null)\n+// },\n+\n+// getTableById: function(id){\n+// table = FloorPlan.tables.filter(function(element) {return element.table.attr('id') === id\n+// })\n+// return table[0]\n+// }\n+// }\n+\n+// $('document').ready(function() {\n+// if ($('body.customer_profiles').length) {\n+// console.log(\"Page generated by the customer controller.\");\n+// }\n+// if($('#floorplan').length){\n+// FloorPlan.init()\n+// // Table.init(1)\n+// }\n+// });\n+\n+// init: function(){\n+// window.setInterval(this.update, 5000)\n+// },\n+\n+// update: function(){\n+// $.get('/restaurant_profiles/carts', function(data){\n+// var test = $.each(data, function(k,v) {\n+// $.each(v, function(i, l){\n+// $('.pending-carts').append('<li><a href=\"carts/' + l.id + '\">' + l.id + '</a></li>')\n+// })\n+// })\n+// })\n+// }\n+\n+\n+\n+function drawTable(positionX, positionY, height, width, htmlId) {\n+ this.positionX = positionX\n+ this.positionY = positionY\n+ this.height = height\n+ this.width = width\n+ this.htmlId = htmlId\n+ this.draw()\n }\n \n-var Table = {\n- init: function(id){\n- this.table = FloorPlan.draw.circle(100,100).attr({fill: 'white', class: 'table', id: 'table' + id})\n- this.table.stroke({color: 'black', width: 2})\n- this.table.draggable()\n- this.table.center('5%', '35%')\n- this.table.click(this.addClickEvent)\n+drawTable.prototype = {\n \n- FloorPlan.tables.push(this)\n+ draw: function() {\n+ var nested = loadTables.drawing.nested()\n+ // nested.attr({id: 'svg_table' + id})\n+ this.drawing = nested.circle(this.width,this.height).attr({fill: 'white', class: 'table', id: this.htmlId})\n+ this.drawing.stroke({color: 'black', width: 2})\n+ this.drawing.center(this.positionX, this.positionY)\n+ }\n+}\n \n- this.chairs = new Array()\n- return this\n- },\n+function drawChair(positionX, positionY, height, width, htmlId) {\n+ this.positionX = positionX\n+ this.positionY = positionY\n+ this.height = height\n+ this.width = width\n+ this.htmlId = htmlId\n+ this.draw()\n+}\n \n- addClickEvent: function(){\n- elementId = this.attr('id')\n- table = Table.getTableById(elementId)\n- console.log(elementId)\n+drawChair.prototype = {\n \n- var idPat = /\\d/\n+ draw: function() {\n+ var nested = loadTables.drawing.nested()\n+ // nested.attr({id: 'svg_' + tableId + 'chair' + id})\n+ // var table = FloorPlan.getTableById(this.tableId)\n+ this.drawing = nested.rect(this.width, this.height).attr({class: 'seat', id: this.htmlId})\n+ this.drawing.move(this.positionX, this.positionY)\n+ }\n+}\n \n- var dataTag = idPat.exec(elementId)[0]\n+var loadTables = {\n \n- console.log(dataTag[0])\n+ init: function(){\n+ window.setInterval(this.update, 5000)\n+ },\n \n- var form = '<form action=\"/stream\" method=\"post\" id=\"check_in\"> <input type=\"submit\" value=\"Check In\"> <input type=\"hidden\" value=\"'+ elementId + '\" name=example> </form>'\n+ update: function(){\n+ this.floorPlan = null\n+ //this request should take the id of the restaurant that you want to get information from,\n+ //for now the controller route will simply send back the correct data\n+ // $.get('/get_floor_plan', function(data) {\n+ // console.log(2)\n+ // loadTables.floorPlan = data\n+ // console.log(data)\n+ // console.log(loadTables.floorPlan)\n+ // console.log(this)\n+ // })\n+ var url_id = window.location.pathname.split('/').reverse()[0];\n \n- $('#header').append(form)\n- table.table.fill('black')\n- Table.table.click(null)\n+ $.ajax({\n+ type: \"GET\",\n+ url: \"/get_floor_plan\",\n+ data: {id: url_id},\n+ async: false,\n+ success: function(data){\n+ loadTables.floorPlan = data\n+ console.log(loadTables.floorPlan)\n+ }\n+ })\n+ this.drawPlan()\n },\n \n- getTableById: function(id){\n- table = FloorPlan.tables.filter(function(element) {return element.table.attr('id') === id\n+ drawPlan: function(){\n+ this.drawing = SVG('get_floorplan').size('100%','100%')\n+ this.drawing.attr({id: 'floor'})\n+ this.drawing.stroke({color: 'black', width: 2})\n+\n+ console.log(this)\n+ console.log(this.floorPlan)","path":"app/assets/javascripts/customer/customer.js","position":173,"original_position":173,"commit_id":"7e355620a1feff56baf32b4668796955fa4b41d8","original_commit_id":"7e355620a1feff56baf32b4668796955fa4b41d8","user":{"login":"Kaina","id":3836751,"avatar_url":"https://2.gravatar.com/avatar/56de6032d27b703954898ae51edfda6c?d=https%3A%2F%2Fidenticons.github.com%2Fa2c54d5bc28271447f29bfb6a316bb9f.png","gravatar_id":"56de6032d27b703954898ae51edfda6c","url":"https://api.github.com/users/Kaina","html_url":"https://github.com/Kaina","followers_url":"https://api.github.com/users/Kaina/followers","following_url":"https://api.github.com/users/Kaina/following{/other_user}","gists_url":"https://api.github.com/users/Kaina/gists{/gist_id}","starred_url":"https://api.github.com/users/Kaina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kaina/subscriptions","organizations_url":"https://api.github.com/users/Kaina/orgs","repos_url":"https://api.github.com/users/Kaina/repos","events_url":"https://api.github.com/users/Kaina/events{/privacy}","received_events_url":"https://api.github.com/users/Kaina/received_events","type":"User"},"created_at":"2013-09-11T03:41:52Z","updated_at":"2013-09-11T03:41:52Z","html_url":"https://github.com/markmccanna1/rest_man/pull/25#discussion_r6285256","pull_request_url":"https://api.github.com/repos/markmccanna1/rest_man/pulls/25","_links":{"self":{"href":"https://api.github.com/repos/markmccanna1/rest_man/pulls/comments/6285256"},"html":{"href":"https://github.com/markmccanna1/rest_man/pull/25#discussion_r6285256"},"pull_request":{"href":"https://api.github.com/repos/markmccanna1/rest_man/pulls/25"}}}} | {
"id": 12619060,
"name": "rest_man",
"url": "https://github.com/markmccanna1/rest_man"
} | {
"id": null,
"login": "Kaina",
"gravatar_id": "56de6032d27b703954898ae51edfda6c",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-09-11T03:41:52 | null | {"repository":{"description":"","watchers":0,"stargazers":0,"forks":0,"fork":false,"size":2124,"owner":"markmccanna1","private":false,"open_issues":7,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Ruby","created_at":"2013-09-05T07:02:07-07:00","pushed_at":"2013-09-10T20:33:21-07:00","master_branch":"master"},"actor_attributes":{"type":"User","name":"John Schmotzer","location":"Pittsburgh, PA","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/markmccanna1/rest_man/pull/25#discussion_r6285256"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/gregorybesson/PlaygroundGame/pulls/comments/7997886","id":7997886,"diff_hunk":"@@ -382,6 +382,17 @@ public function registerAction()\n $lastEntry->setPlayerData($data);\n $sg->getEntryMapper()->update($lastEntry);\n \n+ // send email to player if defined in admin","path":"src/PlaygroundGame/Controller/Frontend/GameController.php","position":4,"original_position":4,"commit_id":"52c10f4259389ba64911284a73d0a34838f3ebc3","original_commit_id":"52c10f4259389ba64911284a73d0a34838f3ebc3","user":{"login":"stephaniefaureadfab","id":5805129,"avatar_url":"https://2.gravatar.com/avatar/02ea79635f71cc16863048a673418224?d=https%3A%2F%2Fidenticons.github.com%2Fb5033473be14ec59b07df9396a92ab3c.png&r=x","gravatar_id":"02ea79635f71cc16863048a673418224","url":"https://api.github.com/users/stephaniefaureadfab","html_url":"https://github.com/stephaniefaureadfab","followers_url":"https://api.github.com/users/stephaniefaureadfab/followers","following_url":"https://api.github.com/users/stephaniefaureadfab/following{/other_user}","gists_url":"https://api.github.com/users/stephaniefaureadfab/gists{/gist_id}","starred_url":"https://api.github.com/users/stephaniefaureadfab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephaniefaureadfab/subscriptions","organizations_url":"https://api.github.com/users/stephaniefaureadfab/orgs","repos_url":"https://api.github.com/users/stephaniefaureadfab/repos","events_url":"https://api.github.com/users/stephaniefaureadfab/events{/privacy}","received_events_url":"https://api.github.com/users/stephaniefaureadfab/received_events","type":"User","site_admin":false},"body":"Cette condition est prise en compte dans le service, si le champs d'email fourni est vide, on regarde si l'entry a un user associé et on utilise l'email de l'utilisateur pour envoyer le mail","created_at":"2013-11-29T09:37:16Z","updated_at":"2013-11-29T09:37:16Z","html_url":"https://github.com/gregorybesson/PlaygroundGame/pull/71#discussion_r7997886","pull_request_url":"https://api.github.com/repos/gregorybesson/PlaygroundGame/pulls/71","_links":{"self":{"href":"https://api.github.com/repos/gregorybesson/PlaygroundGame/pulls/comments/7997886"},"html":{"href":"https://github.com/gregorybesson/PlaygroundGame/pull/71#discussion_r7997886"},"pull_request":{"href":"https://api.github.com/repos/gregorybesson/PlaygroundGame/pulls/71"}}}} | {
"id": 12688006,
"name": "PlaygroundGame",
"url": "https://github.com/gregorybesson/PlaygroundGame"
} | {
"id": null,
"login": "stephaniefaureadfab",
"gravatar_id": "02ea79635f71cc16863048a673418224",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-11-29T09:37:16 | null | {"repository":{"description":"Playground Game Module","watchers":0,"stargazers":0,"forks":8,"fork":false,"size":1646,"owner":"gregorybesson","private":false,"open_issues":1,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"PHP","created_at":"2013-09-08T14:35:36-07:00","pushed_at":"2013-11-27T23:51:28-08:00","master_branch":"develop"},"actor_attributes":{"type":"User","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/gregorybesson/PlaygroundGame/pull/71#discussion_r7997886"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/rg3/youtube-dl/pulls/comments/3890554","id":3890554,"body":"I intended to override all arguments, but my message wasn't clear enough i think. If i should only override commandline args, i would add it in line 301 like this:\r\n\r\n```python\r\ncommandLineConf = sys.argv[1:] if not arguments else arguments\r\n```\r\n\r\n","diff_hunk":"@@ -298,8 +298,8 @@ def _find_term_columns():\n userConfFile = os.path.join(os.path.expanduser('~'), '.config', 'youtube-dl.conf')\n systemConf = _readOptions('/etc/youtube-dl.conf')\n userConf = _readOptions(userConfFile)\n- commandLineConf = sys.argv[1:]\n- argv = systemConf + userConf + commandLineConf\n+ commandLineConf = sys.argv[1:] \n+ argv = systemConf + userConf + commandLineConf if not arguments else arguments","path":"youtube_dl/__init__.py","position":16,"original_position":16,"commit_id":"b8ad4f02a2124c9e08570bfb2ab05f2024cb2fb7","original_commit_id":"b8ad4f02a2124c9e08570bfb2ab05f2024cb2fb7","user":{"login":"fp7","id":4173288,"avatar_url":"https://secure.gravatar.com/avatar/5612d787fab4efc50699a05c7472fa92?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"5612d787fab4efc50699a05c7472fa92","url":"https://api.github.com/users/fp7","html_url":"https://github.com/fp7","followers_url":"https://api.github.com/users/fp7/followers","following_url":"https://api.github.com/users/fp7/following","gists_url":"https://api.github.com/users/fp7/gists{/gist_id}","starred_url":"https://api.github.com/users/fp7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fp7/subscriptions","organizations_url":"https://api.github.com/users/fp7/orgs","repos_url":"https://api.github.com/users/fp7/repos","events_url":"https://api.github.com/users/fp7/events{/privacy}","received_events_url":"https://api.github.com/users/fp7/received_events","type":"User"},"created_at":"2013-04-22T07:36:15Z","updated_at":"2013-04-22T07:36:15Z","html_url":"https://github.com/rg3/youtube-dl/pull/792#discussion_r3890554","pull_request_url":"https://api.github.com/repos/rg3/youtube-dl/pulls/792","_links":{"self":{"href":"https://api.github.com/repos/rg3/youtube-dl/pulls/comments/3890554"},"html":{"href":"https://github.com/rg3/youtube-dl/pull/792#discussion_r3890554"},"pull_request":{"href":"https://api.github.com/repos/rg3/youtube-dl/pulls/792"}}}} | {
"id": 1039520,
"name": "youtube-dl",
"url": "https://github.com/rg3/youtube-dl"
} | {
"id": null,
"login": "fp7",
"gravatar_id": "5612d787fab4efc50699a05c7472fa92",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-04-22T07:36:15 | null | {"repository":{"description":"Small command-line program to download videos from YouTube.com and other video sites","homepage":"http://rg3.github.io/youtube-dl/","watchers":1634,"stargazers":1634,"forks":357,"fork":false,"size":5385,"owner":"rg3","private":false,"open_issues":185,"has_issues":true,"has_downloads":true,"has_wiki":false,"language":"Python","created_at":"2010-10-31T07:35:07-07:00","pushed_at":"2013-04-21T13:07:15-07:00","master_branch":"master"},"actor_attributes":{"type":"User","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/rg3/youtube-dl/pull/792#discussion_r3890554"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/steffanc/Tahoe/pulls/comments/7394648","id":7394648,"diff_hunk":"@@ -0,0 +1,53 @@\n+<RelativeLayout xmlns:android=\"http://schemas.android.com/apk/res/android\"\n+ xmlns:tools=\"http://schemas.android.com/tools\"\n+ android:layout_width=\"match_parent\"\n+ android:layout_height=\"match_parent\"\n+ tools:context=\".activities.RequestFulfillActivity\">\n+\n+\t<fragment\n+\t\tandroid:id=\"@+id/map\"\n+\t\tclass=\"com.google.android.gms.maps.SupportMapFragment\"\n+\t\tandroid:layout_width=\"fill_parent\"\n+\t\tandroid:layout_height=\"fill_parent\" />\n+\n+\t<LinearLayout\n+\t\tandroid:id=\"@+id/llClientInfo\"\n+\t\tandroid:layout_width=\"match_parent\"\n+\t\tandroid:layout_height=\"150dp\"\n+\t\tandroid:layout_alignParentBottom=\"true\"\n+\t\tandroid:orientation=\"horizontal\">\n+\n+\t\t<com.facebook.widget.ProfilePictureView\n+\t\t\tandroid:id=\"@+id/pvProfile\"\n+\t\t\tandroid:layout_width=\"150dp\"\n+\t\t\tandroid:layout_height=\"match_parent\" />\n+\n+\t\t<LinearLayout\n+\t\t\tandroid:id=\"@+id/llClientText\"\n+\t\t\tandroid:layout_width=\"match_parent\"\n+\t\t\tandroid:layout_height=\"match_parent\"\n+\t\t\tandroid:orientation=\"vertical\"\n+\t\t\tandroid:paddingLeft=\"5dp\"","path":"res/layout/activity_request_fulfill.xml","position":30,"original_position":30,"commit_id":"1a0fe2bf2325133fe2c83e315a98baa52a1e830f","original_commit_id":"1a0fe2bf2325133fe2c83e315a98baa52a1e830f","user":{"login":"rogerhu","id":326857,"avatar_url":"https://2.gravatar.com/avatar/30a32a2cf564458fe92cc81e50b74644?d=https%3A%2F%2Fidenticons.github.com%2F275b2d83d2c37c1397d4197ce41539e2.png&r=x","gravatar_id":"30a32a2cf564458fe92cc81e50b74644","url":"https://api.github.com/users/rogerhu","html_url":"https://github.com/rogerhu","followers_url":"https://api.github.com/users/rogerhu/followers","following_url":"https://api.github.com/users/rogerhu/following{/other_user}","gists_url":"https://api.github.com/users/rogerhu/gists{/gist_id}","starred_url":"https://api.github.com/users/rogerhu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rogerhu/subscriptions","organizations_url":"https://api.github.com/users/rogerhu/orgs","repos_url":"https://api.github.com/users/rogerhu/repos","events_url":"https://api.github.com/users/rogerhu/events{/privacy}","received_events_url":"https://api.github.com/users/rogerhu/received_events","type":"User","site_admin":false},"body":"Is the 5dp left needed? The layouts initially created by @azoff all had @dimen headers in the top most node. (@azoff -- do you remember how you got it?) Possible are you using Android Studio to create new Activities with the layout using the Android Studio tools?","created_at":"2013-11-04T07:11:01Z","updated_at":"2013-11-04T07:11:01Z","html_url":"https://github.com/steffanc/Tahoe/pull/63#discussion_r7394648","pull_request_url":"https://api.github.com/repos/steffanc/Tahoe/pulls/63","_links":{"self":{"href":"https://api.github.com/repos/steffanc/Tahoe/pulls/comments/7394648"},"html":{"href":"https://github.com/steffanc/Tahoe/pull/63#discussion_r7394648"},"pull_request":{"href":"https://api.github.com/repos/steffanc/Tahoe/pulls/63"}}}} | {
"id": 13762220,
"name": "Tahoe",
"url": "https://github.com/steffanc/Tahoe"
} | {
"id": null,
"login": "rogerhu",
"gravatar_id": "30a32a2cf564458fe92cc81e50b74644",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-11-04T07:11:01 | null | {"repository":{"description":"Tahoe real time marketplace for Android","watchers":1,"stargazers":1,"forks":1,"fork":false,"size":6457,"owner":"steffanc","private":false,"open_issues":12,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Java","created_at":"2013-10-21T20:35:39-07:00","pushed_at":"2013-11-03T22:54:53-08:00","master_branch":"master"},"actor_attributes":{"type":"User","name":"Roger Hu","blog":"http://hustoknow.blogspot.com","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/steffanc/Tahoe/pull/63#discussion_r7394648"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/slightair/yamiHikariGame/pulls/comments/5703698","id":5703698,"body":"メンバ変数にしたほうが、後で使うものかどうかが明確でよいと思う。","diff_hunk":"@@ -27,6 +29,18 @@ bool GradientLayer::init()\n _titleLabel->setAnchorPoint(ccp(0.5, 1.0));\n _titleLabel->setPosition(ccp(windowSize.width / 2, windowSize.height - TitleBarTitleMarginTop));\n this->addChild(_titleLabel);\n+\n+ CCLayerColor *leftButtonLayer = CCLayerColor::create((ccColor4B){0x00, 0x00, 0x00, 0x00}, TitleBarButtonWidth, TitleBarButtonHeight);\n+ CCLabelTTF *leftButtonLabel = CCLabelTTF::create(\"\", DefaultFontName, FontSizeNormal);\n+ leftButtonLabel->setPosition(ccp(TitleBarButtonWidth / 2, TitleBarButtonHeight / 2));\n+ _titleBarLeftButton = CCMenuItemLabel::create(leftButtonLayer);\n+ _titleBarLeftButton->addChild(leftButtonLabel, 0, kButtonLabelTag);","path":"yamiHikariGame/Classes/GradientLayer.cpp","position":18,"original_position":18,"commit_id":"53f8565f30b8f702200e69f0a2fb05443bcf9220","original_commit_id":"53f8565f30b8f702200e69f0a2fb05443bcf9220","user":{"login":"ichiko","id":1710357,"avatar_url":"https://secure.gravatar.com/avatar/eeba0ffd7217e6748fa212212ec81df0?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"eeba0ffd7217e6748fa212212ec81df0","url":"https://api.github.com/users/ichiko","html_url":"https://github.com/ichiko","followers_url":"https://api.github.com/users/ichiko/followers","following_url":"https://api.github.com/users/ichiko/following{/other_user}","gists_url":"https://api.github.com/users/ichiko/gists{/gist_id}","starred_url":"https://api.github.com/users/ichiko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ichiko/subscriptions","organizations_url":"https://api.github.com/users/ichiko/orgs","repos_url":"https://api.github.com/users/ichiko/repos","events_url":"https://api.github.com/users/ichiko/events{/privacy}","received_events_url":"https://api.github.com/users/ichiko/received_events","type":"User"},"created_at":"2013-08-12T07:00:34Z","updated_at":"2013-08-12T07:00:34Z","html_url":"https://github.com/slightair/yamiHikariGame/pull/11#discussion_r5703698","pull_request_url":"https://api.github.com/repos/slightair/yamiHikariGame/pulls/11","_links":{"self":{"href":"https://api.github.com/repos/slightair/yamiHikariGame/pulls/comments/5703698"},"html":{"href":"https://github.com/slightair/yamiHikariGame/pull/11#discussion_r5703698"},"pull_request":{"href":"https://api.github.com/repos/slightair/yamiHikariGame/pulls/11"}}}} | {
"id": 11450598,
"name": "yamiHikariGame",
"url": "https://github.com/slightair/yamiHikariGame"
} | {
"id": null,
"login": "ichiko",
"gravatar_id": "eeba0ffd7217e6748fa212212ec81df0",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-08-12T07:00:34 | null | {"repository":{"description":"yami no game","watchers":0,"stargazers":0,"forks":1,"fork":false,"size":6871,"owner":"slightair","private":false,"open_issues":3,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"C++","created_at":"2013-07-16T06:46:22-07:00","pushed_at":"2013-08-11T08:30:43-07:00","master_branch":"master"},"actor_attributes":{"type":"User","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/slightair/yamiHikariGame/pull/11#discussion_r5703698"} |
PullRequestReviewCommentEvent | true | {"comment":{"original_commit_id":"5f4222875b71bb473d8e25103c2d37982f9c0dde","position":79,"original_position":79,"user":{"organizations_url":"https://api.github.com/users/donny-dont/orgs","received_events_url":"https://api.github.com/users/donny-dont/received_events","subscriptions_url":"https://api.github.com/users/donny-dont/subscriptions","login":"donny-dont","avatar_url":"https://secure.gravatar.com/avatar/b3fd4cc798a8705026d2c088ab70fd9e?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","type":"User","repos_url":"https://api.github.com/users/donny-dont/repos","gravatar_id":"b3fd4cc798a8705026d2c088ab70fd9e","id":666297,"url":"https://api.github.com/users/donny-dont","following_url":"https://api.github.com/users/donny-dont/following","followers_url":"https://api.github.com/users/donny-dont/followers","gists_url":"https://api.github.com/users/donny-dont/gists{/gist_id}","events_url":"https://api.github.com/users/donny-dont/events{/privacy}","starred_url":"https://api.github.com/users/donny-dont/starred{/owner}{/repo}"},"commit_id":"5f4222875b71bb473d8e25103c2d37982f9c0dde","path":"lib/src/spectre/graphics_context.dart","_links":{"pull_request":{"href":"https://api.github.com/repos/johnmccutchan/spectre/pulls/18"},"self":{"href":"https://api.github.com/repos/johnmccutchan/spectre/pulls/comments/2628485"},"html":{"href":"https://github.com/johnmccutchan/spectre/pull/18#discussion_r2628485"}},"updated_at":"2013-01-13T03:54:25Z","id":2628485,"url":"https://api.github.com/repos/johnmccutchan/spectre/pulls/comments/2628485","created_at":"2013-01-13T03:54:25Z","body":"Cause you had said to not do that ;)"}} | {
"id": 4853848,
"name": "spectre",
"url": "https://github.com/johnmccutchan/spectre"
} | {
"id": null,
"login": "donny-dont",
"gravatar_id": "b3fd4cc798a8705026d2c088ab70fd9e",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-01-13T03:54:25 | null | {"repository":{"open_issues":2,"owner":"johnmccutchan","watchers":32,"has_wiki":true,"created_at":"2012-07-01T15:26:04-07:00","pushed_at":"2013-01-10T21:34:59-08:00","stargazers":32,"forks":7,"has_issues":true,"language":"Dart","fork":false,"size":368,"description":"Spectre Graphics Engine for Dart","private":false,"has_downloads":true},"actor_attributes":{"type":"User","location":"San Francisco, CA","name":"Don","blog":"http://www.donolmstead.me","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/johnmccutchan/spectre/pull/18#discussion_r2628485"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/maccesch/cmsplugin-contact/pulls/comments/6164144","id":6164144,"body":"No the from_email is set in the plugin admin form.","diff_hunk":"@@ -106,18 +106,21 @@ class ContactForm(self.contact_form, HoneyPotContactForm):\n else:\n return FormClass(request)\n \n- def send(self, form, site_email, attachments=None):\n- subject = form.cleaned_data['subject']\n- if not subject:\n- subject = _('No subject')\n+ def send(self, form, form_name, site_email, attachments=None):\n+ subject = form.cleaned_data['subject'] if form.cleaned_data['subject'] else _('No subject')\n+ from_email = getattr(settings, 'DEFAULT_FROM_EMAIL', form.cleaned_data['email'])","path":"cmsplugin_contact/cms_plugins.py","position":19,"original_position":19,"commit_id":"87c7be41c2aa63c21d926196e8bc3a66a9ceaf71","original_commit_id":"87c7be41c2aa63c21d926196e8bc3a66a9ceaf71","user":{"login":"maccesch","id":380881,"avatar_url":"https://0.gravatar.com/avatar/7c761f818d75155ed2be9f6d2e17e5ba?d=https%3A%2F%2Fidenticons.github.com%2F0d33107a43271e3c41a82e7299cd80da.png","gravatar_id":"7c761f818d75155ed2be9f6d2e17e5ba","url":"https://api.github.com/users/maccesch","html_url":"https://github.com/maccesch","followers_url":"https://api.github.com/users/maccesch/followers","following_url":"https://api.github.com/users/maccesch/following{/other_user}","gists_url":"https://api.github.com/users/maccesch/gists{/gist_id}","starred_url":"https://api.github.com/users/maccesch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maccesch/subscriptions","organizations_url":"https://api.github.com/users/maccesch/orgs","repos_url":"https://api.github.com/users/maccesch/repos","events_url":"https://api.github.com/users/maccesch/events{/privacy}","received_events_url":"https://api.github.com/users/maccesch/received_events","type":"User"},"created_at":"2013-09-04T19:33:38Z","updated_at":"2013-09-04T19:33:38Z","html_url":"https://github.com/maccesch/cmsplugin-contact/pull/49#discussion_r6164144","pull_request_url":"https://api.github.com/repos/maccesch/cmsplugin-contact/pulls/49","_links":{"self":{"href":"https://api.github.com/repos/maccesch/cmsplugin-contact/pulls/comments/6164144"},"html":{"href":"https://github.com/maccesch/cmsplugin-contact/pull/49#discussion_r6164144"},"pull_request":{"href":"https://api.github.com/repos/maccesch/cmsplugin-contact/pulls/49"}}}} | {
"id": 873619,
"name": "cmsplugin-contact",
"url": "https://github.com/maccesch/cmsplugin-contact"
} | {
"id": null,
"login": "maccesch",
"gravatar_id": "7c761f818d75155ed2be9f6d2e17e5ba",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-09-04T19:33:38 | null | {"repository":{"description":"Extendable contact plugin for django-cms with spam protection and i18n","homepage":"","watchers":54,"stargazers":54,"forks":37,"fork":true,"size":196,"owner":"maccesch","private":false,"open_issues":4,"has_issues":true,"has_downloads":true,"has_wiki":false,"language":"Python","created_at":"2010-08-30T17:45:56-07:00","pushed_at":"2013-09-04T05:36:07-07:00","master_branch":"master"},"actor_attributes":{"type":"User","name":"Marc-Stefan Cassola","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/maccesch/cmsplugin-contact/pull/49#discussion_r6164144"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/izuzak/FRISCjs/pulls/comments/7691808","id":7691808,"diff_hunk":"@@ -1,5 +1,110 @@\n var CFGNAMES = \"__friscConfigurationNames\";\n var isLocalStorageAvailable = 'localStorage' in window && window.localStorage !== null;\n+var maxMessagesLog = -1;\n+\n+// Memory Dumping\n+\n+$('#skrMemDump').click(function() {\n+ if (!$('#tempModalHold').length) {\n+ $('body').append( ''+\n+ '<div id=\"tempModalHold\">'+\n+ '<div class=\"modal fade\" id=\"tempModal\" tabindex=\"-1\" role=\"dialog\" aria-labelledby=\"tempModal\" aria-hidden=\"true\">'+\n+ '<div class=\"modal-dialog\">'+\n+ '<div class=\"modal-content\">'+\n+ '<div class=\"modal-header\">'+\n+ '<button type=\"button\" class=\"close\" data-dismiss=\"modal\" aria-hidden=\"true\">×</button>'+\n+ '<h4 class=\"modal-title\" id=\"tempModalHeader\">Modal title</h4>'+\n+ '</div>'+\n+ '<div class=\"modal-body\" id=\"tempModalBody\">'+\n+ ' <p>One fine body…</p>'+\n+ '</div>'+\n+ '<div class=\"modal-footer\" id=\"tempModalFooter\">'+\n+ '<button type=\"button\" class=\"btn btn-default\" data-dismiss=\"modal\">Close</button>'+\n+ '</div>'+\n+ '</div><!-- /.modal-content -->'+\n+ '</div><!-- /.modal-dialog -->'+\n+ '</div><!-- /.modal -->'+\n+ '</div>'+\n+ '');\n+ $('#tempModal').on('hidden', function () {\n+ $('#tempModalHold').remove();\n+ });\n+ }\n+\n+ $('#tempModalHeader').html( 'Text Memory Dump' );\n+ $('#tempModalBody').html( ''+\n+ '<div>'+\n+ ' <textarea style=\"width:98%; min-height:250px;\" id=\"skrMemDumpField\">'+\n+ ' </textarea>'+\n+ '</div>'+\n+ '' );\n+ $('#tempModalFooter').html( '<button type=\"button\" class=\"btn btn-danger\" data-dismiss=\"modal\" style=\"float:right; margin-left:5px;\">'+\n+ '<i class=\"icon-remove icon-white\"></i> Cancel'+\n+ '</button>'+\n+ ''+\n+ '<div style=\"float:right; margin-left:5px;\" class=\"btn-group\" data-toggle=\"buttons-radio\">'+\n+ '<button type=\"button\" class=\"btn btn-default skrMemDumpBut\">DEC</button>'+\n+ '<button type=\"button\" class=\"btn btn-default skrMemDumpBut active\">HEX</button>'+\n+ '</div>'+\n+ ''+\n+ '<div style=\"float:right; margin-left:5px;\" class=\"btn-group\" data-toggle=\"buttons-radio\">'+","path":"webapp/scripts/main.js","position":50,"original_position":50,"commit_id":"3d844f49daf8f532d6c9412467e2c3d831c39787","original_commit_id":"3d844f49daf8f532d6c9412467e2c3d831c39787","user":{"login":"izuzak","id":38924,"avatar_url":"https://0.gravatar.com/avatar/ff743b4cba28cc47ad65cb90212c1e51?d=https%3A%2F%2Fidenticons.github.com%2Fc9d53ae2d92c54f2a1aa6003bcadfb1d.png&r=x","gravatar_id":"ff743b4cba28cc47ad65cb90212c1e51","url":"https://api.github.com/users/izuzak","html_url":"https://github.com/izuzak","followers_url":"https://api.github.com/users/izuzak/followers","following_url":"https://api.github.com/users/izuzak/following{/other_user}","gists_url":"https://api.github.com/users/izuzak/gists{/gist_id}","starred_url":"https://api.github.com/users/izuzak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/izuzak/subscriptions","organizations_url":"https://api.github.com/users/izuzak/orgs","repos_url":"https://api.github.com/users/izuzak/repos","events_url":"https://api.github.com/users/izuzak/events{/privacy}","received_events_url":"https://api.github.com/users/izuzak/received_events","type":"User","site_admin":true},"body":"It would be :cool: to add a label here to explain what these 8/16/32 buttons do/change. If you agree, I'd do the same for the DE/HEX buttons as well, although it's much more clear what these button change.","created_at":"2013-11-15T15:01:52Z","updated_at":"2013-11-15T15:01:52Z","html_url":"https://github.com/izuzak/FRISCjs/pull/12#discussion_r7691808","pull_request_url":"https://api.github.com/repos/izuzak/FRISCjs/pulls/12","_links":{"self":{"href":"https://api.github.com/repos/izuzak/FRISCjs/pulls/comments/7691808"},"html":{"href":"https://github.com/izuzak/FRISCjs/pull/12#discussion_r7691808"},"pull_request":{"href":"https://api.github.com/repos/izuzak/FRISCjs/pulls/12"}}}} | {
"id": 1999512,
"name": "FRISCjs",
"url": "https://github.com/izuzak/FRISCjs"
} | {
"id": null,
"login": "izuzak",
"gravatar_id": "ff743b4cba28cc47ad65cb90212c1e51",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-11-15T15:01:52 | null | {"repository":{"description":"FRISC processor simulator in JavaScript","homepage":"izuzak.github.com/FRISCjs/webapp/","watchers":3,"stargazers":3,"forks":4,"fork":false,"size":692,"owner":"izuzak","private":false,"open_issues":1,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"JavaScript","created_at":"2011-07-05T02:02:31-07:00","pushed_at":"2013-10-04T01:31:05-07:00","master_branch":"master"},"actor_attributes":{"type":"User","name":"Ivan Žužak","company":"GitHub","blog":"http://ivanzuzak.info","location":"Zurich (Switzerland) and Zagreb (Croatia)","email":"[email protected]"},"url":"https://github.com/izuzak/FRISCjs/pull/12#discussion_r7691808"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/visionmedia/nib/pulls/comments/5467211","id":5467211,"body":"ah, yeah... that'd be nice :P","diff_hunk":"@@ -45,24 +45,27 @@ literal-join(string, literals)\n return result\n \n /*\n- * Replacing one value with another\n+ * Prepend matched argument with given prefix\n+ * set strict to false to check as “begin with”\n */\n \n-replace-args(args,argument,val)\n+prepend-args(args, prefix, argument, strict = true)","path":"lib/nib/vendor.styl","position":10,"original_position":10,"commit_id":"f631c512418a4a97db257b3d236ba075e19d4d22","original_commit_id":"f631c512418a4a97db257b3d236ba075e19d4d22","user":{"login":"slang800","id":1049204,"avatar_url":"https://secure.gravatar.com/avatar/aecf398d10b14985105a2ad2eb0f696e?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"aecf398d10b14985105a2ad2eb0f696e","url":"https://api.github.com/users/slang800","html_url":"https://github.com/slang800","followers_url":"https://api.github.com/users/slang800/followers","following_url":"https://api.github.com/users/slang800/following{/other_user}","gists_url":"https://api.github.com/users/slang800/gists{/gist_id}","starred_url":"https://api.github.com/users/slang800/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slang800/subscriptions","organizations_url":"https://api.github.com/users/slang800/orgs","repos_url":"https://api.github.com/users/slang800/repos","events_url":"https://api.github.com/users/slang800/events{/privacy}","received_events_url":"https://api.github.com/users/slang800/received_events","type":"User"},"created_at":"2013-07-30T02:08:00Z","updated_at":"2013-07-30T02:08:00Z","html_url":"https://github.com/visionmedia/nib/pull/207#discussion_r5467211","pull_request_url":"https://api.github.com/repos/visionmedia/nib/pulls/207","_links":{"self":{"href":"https://api.github.com/repos/visionmedia/nib/pulls/comments/5467211"},"html":{"href":"https://github.com/visionmedia/nib/pull/207#discussion_r5467211"},"pull_request":{"href":"https://api.github.com/repos/visionmedia/nib/pulls/207"}}}} | {
"id": 1570209,
"name": "nib",
"url": "https://github.com/visionmedia/nib"
} | {
"id": null,
"login": "slang800",
"gravatar_id": "aecf398d10b14985105a2ad2eb0f696e",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-07-30T02:08:00 | null | {"repository":{"description":"Stylus mixins, utilities, components, and gradient image generation","homepage":"http://visionmedia.github.com/nib/","watchers":774,"stargazers":774,"forks":128,"fork":false,"size":979,"owner":"visionmedia","private":false,"open_issues":64,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"JavaScript","created_at":"2011-04-04T18:42:41-07:00","pushed_at":"2013-07-29T15:58:33-07:00","master_branch":"master"},"actor_attributes":{"type":"User","name":"Sean Lang","email":"[email protected]"},"url":"https://github.com/visionmedia/nib/pull/207#discussion_r5467211"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/prezjordan/sabriel/pulls/comments/5441454","id":5441454,"body":":sunglasses: ","diff_hunk":"@@ -0,0 +1,8 @@\n+@avatarWidth: 40px;","path":"client/less/avatar.less","position":null,"original_position":1,"commit_id":"184b5ddba16d3ce64e30036eb0942871bc7e80a8","original_commit_id":"11633873b30f3c8d01185f65c95d78b907b21418","user":{"login":"prezjordan","id":287268,"avatar_url":"https://secure.gravatar.com/avatar/3517596df161030c3779c532f7844383?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"3517596df161030c3779c532f7844383","url":"https://api.github.com/users/prezjordan","html_url":"https://github.com/prezjordan","followers_url":"https://api.github.com/users/prezjordan/followers","following_url":"https://api.github.com/users/prezjordan/following{/other_user}","gists_url":"https://api.github.com/users/prezjordan/gists{/gist_id}","starred_url":"https://api.github.com/users/prezjordan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prezjordan/subscriptions","organizations_url":"https://api.github.com/users/prezjordan/orgs","repos_url":"https://api.github.com/users/prezjordan/repos","events_url":"https://api.github.com/users/prezjordan/events{/privacy}","received_events_url":"https://api.github.com/users/prezjordan/received_events","type":"User"},"created_at":"2013-07-28T23:35:30Z","updated_at":"2013-07-28T23:35:30Z","html_url":"https://github.com/prezjordan/sabriel/pull/11#discussion_r5441454","pull_request_url":"https://api.github.com/repos/prezjordan/sabriel/pulls/11","_links":{"self":{"href":"https://api.github.com/repos/prezjordan/sabriel/pulls/comments/5441454"},"html":{"href":"https://github.com/prezjordan/sabriel/pull/11#discussion_r5441454"},"pull_request":{"href":"https://api.github.com/repos/prezjordan/sabriel/pulls/11"}}}} | {
"id": 11624565,
"name": "sabriel",
"url": "https://github.com/prezjordan/sabriel"
} | {
"id": null,
"login": "prezjordan",
"gravatar_id": "3517596df161030c3779c532f7844383",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-07-28T23:35:30 | null | {"repository":{"description":"Debrief tool","watchers":1,"stargazers":1,"forks":1,"fork":false,"size":159,"owner":"prezjordan","private":false,"open_issues":4,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"JavaScript","created_at":"2013-07-23T19:36:43-07:00","pushed_at":"2013-07-28T16:35:14-07:00","master_branch":"master"},"actor_attributes":{"type":"User","name":"Jordan Scales","blog":"http://jordanscales.com","location":"NY / NJ","email":"[email protected]"},"url":"https://github.com/prezjordan/sabriel/pull/11#discussion_r5441454"} |
PullRequestReviewCommentEvent | true | {"comment":{"original_commit_id":"0c4cdf71262cd6d2470f906d6071cb0f50070a85","body":"Nice suggestion!","user":{"type":"User","following_url":"https://api.github.com/users/italomaia/following","avatar_url":"https://secure.gravatar.com/avatar/0ee8e726f356f729acdcf048ebe1bc54?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","events_url":"https://api.github.com/users/italomaia/events{/privacy}","id":14670,"repos_url":"https://api.github.com/users/italomaia/repos","organizations_url":"https://api.github.com/users/italomaia/orgs","login":"italomaia","received_events_url":"https://api.github.com/users/italomaia/received_events","starred_url":"https://api.github.com/users/italomaia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/italomaia/subscriptions","gists_url":"https://api.github.com/users/italomaia/gists{/gist_id}","followers_url":"https://api.github.com/users/italomaia/followers","gravatar_id":"0ee8e726f356f729acdcf048ebe1bc54","url":"https://api.github.com/users/italomaia"},"path":"model_mommy/tests/test_filling_fields.py","commit_id":"0c4cdf71262cd6d2470f906d6071cb0f50070a85","id":2559233,"original_position":5,"created_at":"2013-01-06T01:25:59Z","_links":{"self":{"href":"https://api.github.com/repos/vandersonmota/model_mommy/pulls/comments/2559233"},"pull_request":{"href":"https://api.github.com/repos/vandersonmota/model_mommy/pulls/58"},"html":{"href":"https://github.com/vandersonmota/model_mommy/pull/58#discussion_r2559233"}},"updated_at":"2013-01-06T01:25:59Z","position":5,"url":"https://api.github.com/repos/vandersonmota/model_mommy/pulls/comments/2559233"}} | {
"id": 1235616,
"name": "model_mommy",
"url": "https://github.com/vandersonmota/model_mommy"
} | {
"id": null,
"login": "italomaia",
"gravatar_id": "0ee8e726f356f729acdcf048ebe1bc54",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-01-06T01:25:59 | null | {"repository":{"stargazers":105,"owner":"vandersonmota","created_at":"2011-01-09T10:05:24-08:00","homepage":"","open_issues":9,"has_issues":true,"pushed_at":"2013-01-05T15:46:08-08:00","description":"Object factory for django","forks":27,"has_downloads":true,"fork":false,"size":232,"language":"Python","watchers":105,"private":false,"has_wiki":true},"actor_attributes":{"blog":"http://www.italomaia.com","type":"User","location":"Brasil","name":"Italo Maia","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/vandersonmota/model_mommy/pull/58#discussion_r2559233"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/jdegoes/blueeyes/pulls/comments/3860347","id":3860347,"body":"I really wish you'd explain in what way it is broken, with an example perhaps. You might not need it tomorrow, but six months from now it might not look obvious.","diff_hunk":"@@ -118,10 +119,12 @@ object JPathNode {\n }\n \n sealed case class JPathField(name: String) extends JPathNode {\n- override def toString = \".\" + name\n+ def render = \".\" + name\n+ override def toString = render //FIXME","path":"json/src/main/scala/blueeyes/json/JPath.scala","position":23,"original_position":23,"commit_id":"61f9b28771ebfee5fb4f4931e039c6242af37ab6","original_commit_id":"61f9b28771ebfee5fb4f4931e039c6242af37ab6","user":{"login":"dcsobral","id":141079,"avatar_url":"https://secure.gravatar.com/avatar/6d43da5df0e52fc31c55e6a227bb23f4?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"6d43da5df0e52fc31c55e6a227bb23f4","url":"https://api.github.com/users/dcsobral","html_url":"https://github.com/dcsobral","followers_url":"https://api.github.com/users/dcsobral/followers","following_url":"https://api.github.com/users/dcsobral/following","gists_url":"https://api.github.com/users/dcsobral/gists{/gist_id}","starred_url":"https://api.github.com/users/dcsobral/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcsobral/subscriptions","organizations_url":"https://api.github.com/users/dcsobral/orgs","repos_url":"https://api.github.com/users/dcsobral/repos","events_url":"https://api.github.com/users/dcsobral/events{/privacy}","received_events_url":"https://api.github.com/users/dcsobral/received_events","type":"User"},"created_at":"2013-04-18T18:40:05Z","updated_at":"2013-04-18T18:40:05Z","html_url":"https://github.com/jdegoes/blueeyes/pull/113#discussion_r3860347","pull_request_url":"https://api.github.com/repos/jdegoes/blueeyes/pulls/113","_links":{"self":{"href":"https://api.github.com/repos/jdegoes/blueeyes/pulls/comments/3860347"},"html":{"href":"https://github.com/jdegoes/blueeyes/pull/113#discussion_r3860347"},"pull_request":{"href":"https://api.github.com/repos/jdegoes/blueeyes/pulls/113"}}}} | {
"id": 981997,
"name": "blueeyes",
"url": "https://github.com/jdegoes/blueeyes"
} | {
"id": null,
"login": "dcsobral",
"gravatar_id": "6d43da5df0e52fc31c55e6a227bb23f4",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-04-18T18:40:05 | null | {"repository":{"description":"A lightweight Web 3.0 framework for Scala, featuring a purely asynchronous architecture, extremely high-performance, massive scalability, high usability, and a functional, composable design.","homepage":"github.com/jdegoes/blueeyes","watchers":550,"stargazers":550,"forks":42,"fork":false,"size":556,"owner":"jdegoes","private":false,"open_issues":7,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Scala","created_at":"2010-10-12T12:21:07-07:00","pushed_at":"2013-04-18T11:18:46-07:00","master_branch":"master"},"actor_attributes":{"type":"User","name":"Daniel Capo Sobral","company":"ACERP/EBC","blog":"http://dcsobral.blogspot.com","location":"Brasília, DF, Brazil","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/jdegoes/blueeyes/pull/113#discussion_r3860347"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/Alerion/shopping-helper/pulls/comments/6819377","id":6819377,"diff_hunk":"@@ -326,61 +315,88 @@ $(document).ready(function() {\n function disappear(){\r\n $('.alert').fadeOut(2000); \r\n }\r\n+\r\n var timer;\r\n+\r\n function add_delete(that,bool) {\r\n+\r\n var id = (bool) ? that.data('product_id') : that.attr('id').slice(7);\r\n- //є дві кнопки +- якщо тиснути на + продукт додається i + міняється на -\r\n- //також є кнопки в меню add, dell, при їх використанні + - міняються\r\n- //якщо продукт доданий до списку, при\r\n- //реалізація на сервері взалежності чи продукт в базі чи ні він дод або видаляється;\r\n- //символ з + на - (кнопка з add на del) на клієнті змінюється лише \r\n- //після успішного виконання на сервері\r\n- //може дод ще якусь перевірку?\r\n+ \r\n $.get('/history/add_to_list/?id='+id, function(data) {\r","path":"src/static/jquery/history.js","position":213,"original_position":213,"commit_id":"0730bd14638bad362fc320bb82b35d000fde6b2d","original_commit_id":"0730bd14638bad362fc320bb82b35d000fde6b2d","user":{"login":"Alerion","id":120177,"avatar_url":"https://2.gravatar.com/avatar/39ece719b1bd095b17bda3227bd0b659?d=https%3A%2F%2Fidenticons.github.com%2F84300452723156b5b70bc7c054423007.png","gravatar_id":"39ece719b1bd095b17bda3227bd0b659","url":"https://api.github.com/users/Alerion","html_url":"https://github.com/Alerion","followers_url":"https://api.github.com/users/Alerion/followers","following_url":"https://api.github.com/users/Alerion/following{/other_user}","gists_url":"https://api.github.com/users/Alerion/gists{/gist_id}","starred_url":"https://api.github.com/users/Alerion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Alerion/subscriptions","organizations_url":"https://api.github.com/users/Alerion/orgs","repos_url":"https://api.github.com/users/Alerion/repos","events_url":"https://api.github.com/users/Alerion/events{/privacy}","received_events_url":"https://api.github.com/users/Alerion/received_events","type":"User","site_admin":false},"body":"Не \"хардкодить\" URL.","created_at":"2013-10-08T08:19:54Z","updated_at":"2013-10-08T08:19:54Z","html_url":"https://github.com/Alerion/shopping-helper/pull/28#discussion_r6819377","pull_request_url":"https://api.github.com/repos/Alerion/shopping-helper/pulls/28","_links":{"self":{"href":"https://api.github.com/repos/Alerion/shopping-helper/pulls/comments/6819377"},"html":{"href":"https://github.com/Alerion/shopping-helper/pull/28#discussion_r6819377"},"pull_request":{"href":"https://api.github.com/repos/Alerion/shopping-helper/pulls/28"}}}} | {
"id": 11814675,
"name": "shopping-helper",
"url": "https://github.com/Alerion/shopping-helper"
} | {
"id": null,
"login": "Alerion",
"gravatar_id": "39ece719b1bd095b17bda3227bd0b659",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-10-08T08:19:54 | null | {"repository":{"description":"SoftServe IT Academy Lv-093.UI group project","homepage":"","watchers":3,"stargazers":3,"forks":6,"fork":false,"size":17631,"owner":"Alerion","private":false,"open_issues":7,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"JavaScript","created_at":"2013-08-01T03:57:01-07:00","pushed_at":"2013-10-07T10:50:13-07:00","master_branch":"master"},"actor_attributes":{"type":"User","name":"Dmytro Kostochko","company":"","blog":"http://djbook.ru/","location":"Ukraine, Lviv","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/Alerion/shopping-helper/pull/28#discussion_r6819377"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/mule-tester/github-connector/pulls/comments/7518744","id":7518744,"diff_hunk":"@@ -1,14 +1 @@\n-Mule GitHub Connector\n-=========================\n-\n-GitHub is a web-based hosting service for software development projects that use the Git revision control system.\n-\n-Installation and Usage\n-----------------------\n-\n-For information about usage and installation you can check our documentation at http://mulesoft.github.com/github-connector.\n-","path":"README.md","position":10,"original_position":10,"commit_id":"c6ab988f98ba1373711cda844444c4dc3486520e","original_commit_id":"c6ab988f98ba1373711cda844444c4dc3486520e","user":{"login":"mule-tester","id":5539058,"avatar_url":"https://0.gravatar.com/avatar/834603ab422bc692e9963bff90c43110?d=https%3A%2F%2Fidenticons.github.com%2F8ec76b30c54aea26f430b38547735097.png&r=x","gravatar_id":"834603ab422bc692e9963bff90c43110","url":"https://api.github.com/users/mule-tester","html_url":"https://github.com/mule-tester","followers_url":"https://api.github.com/users/mule-tester/followers","following_url":"https://api.github.com/users/mule-tester/following{/other_user}","gists_url":"https://api.github.com/users/mule-tester/gists{/gist_id}","starred_url":"https://api.github.com/users/mule-tester/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mule-tester/subscriptions","organizations_url":"https://api.github.com/users/mule-tester/orgs","repos_url":"https://api.github.com/users/mule-tester/repos","events_url":"https://api.github.com/users/mule-tester/events{/privacy}","received_events_url":"https://api.github.com/users/mule-tester/received_events","type":"User","site_admin":false},"body":"test comment body","created_at":"2013-11-08T04:07:19Z","updated_at":"2013-11-08T04:07:19Z","html_url":"https://github.com/mule-tester/github-connector/pull/1#discussion_r7518744","pull_request_url":"https://api.github.com/repos/mule-tester/github-connector/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/mule-tester/github-connector/pulls/comments/7518744"},"html":{"href":"https://github.com/mule-tester/github-connector/pull/1#discussion_r7518744"},"pull_request":{"href":"https://api.github.com/repos/mule-tester/github-connector/pulls/1"}}}} | {
"id": 14223613,
"name": "github-connector",
"url": "https://github.com/mule-tester/github-connector"
} | {
"id": null,
"login": "mule-tester",
"gravatar_id": "834603ab422bc692e9963bff90c43110",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-11-08T04:07:19 | null | {"repository":{"description":"","homepage":"","watchers":0,"stargazers":0,"forks":0,"fork":true,"size":181568,"owner":"mule-tester","private":false,"open_issues":1,"has_issues":false,"has_downloads":true,"has_wiki":true,"language":"Java","created_at":"2013-11-07T20:07:07-08:00","pushed_at":"2013-11-07T20:07:18-08:00","master_branch":"master"},"actor_attributes":{"type":"User","company":"MuleSoft","blog":"blogs.mulesoft.org","location":"Buenos Aires","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/mule-tester/github-connector/pull/1#discussion_r7518744"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/andreasgal/vtt.js/pulls/comments/6628119","id":6628119,"body":"That seems sane, yes. Question: why do you do the check on `window.mochaPhantomJS`? Since we only run this in the context of PhantomJS, is this really necessary?","diff_hunk":"@@ -0,0 +1,55 @@\n+<!DOCTYPE html>\n+<html>\n+<head>\n+<meta charset=\"utf-8\">\n+<link rel=\"stylesheet\" href=\"../../node_modules/mocha/mocha.css\"/>\n+<script src=\"../../dist/vtt.min.js\"></script>\n+</head>\n+\n+<body>\n+ <div id=\"mocha\"></div>\n+ <script src=\"../../node_modules/mocha/mocha.js\"></script>\n+ <script src=\"../../node_modules/chai/chai.js\"></script>\n+ <script>\n+ mocha.ui('bdd');\n+ mocha.reporter('html');\n+ var assert = chai.assert;","path":"tests/phantomjs/simple.html","position":16,"original_position":16,"commit_id":"c83d0f5b490f574cd950664cdda0e57aeab79077","original_commit_id":"c83d0f5b490f574cd950664cdda0e57aeab79077","user":{"login":"humphd","id":427398,"avatar_url":"https://0.gravatar.com/avatar/467b6f36e2a9ba3f0ec119eddaab6a62?d=https%3A%2F%2Fidenticons.github.com%2F897892c787116ffd91afe1045542c4d4.png","gravatar_id":"467b6f36e2a9ba3f0ec119eddaab6a62","url":"https://api.github.com/users/humphd","html_url":"https://github.com/humphd","followers_url":"https://api.github.com/users/humphd/followers","following_url":"https://api.github.com/users/humphd/following{/other_user}","gists_url":"https://api.github.com/users/humphd/gists{/gist_id}","starred_url":"https://api.github.com/users/humphd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/humphd/subscriptions","organizations_url":"https://api.github.com/users/humphd/orgs","repos_url":"https://api.github.com/users/humphd/repos","events_url":"https://api.github.com/users/humphd/events{/privacy}","received_events_url":"https://api.github.com/users/humphd/received_events","type":"User"},"created_at":"2013-09-27T13:55:16Z","updated_at":"2013-09-27T13:55:16Z","html_url":"https://github.com/andreasgal/vtt.js/pull/122#discussion_r6628119","pull_request_url":"https://api.github.com/repos/andreasgal/vtt.js/pulls/122","_links":{"self":{"href":"https://api.github.com/repos/andreasgal/vtt.js/pulls/comments/6628119"},"html":{"href":"https://github.com/andreasgal/vtt.js/pull/122#discussion_r6628119"},"pull_request":{"href":"https://api.github.com/repos/andreasgal/vtt.js/pulls/122"}}}} | {
"id": 11298679,
"name": "vtt.js",
"url": "https://github.com/andreasgal/vtt.js"
} | {
"id": null,
"login": "humphd",
"gravatar_id": "467b6f36e2a9ba3f0ec119eddaab6a62",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-09-27T13:55:16 | null | {"repository":{"description":"WebVTT parser in JavaScript","watchers":9,"stargazers":9,"forks":12,"fork":false,"size":1220,"owner":"andreasgal","private":false,"open_issues":21,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"JavaScript","created_at":"2013-07-09T18:22:14-07:00","pushed_at":"2013-09-25T13:30:51-07:00","master_branch":"master"},"actor_attributes":{"type":"User","name":"David Humphrey","blog":"http://vocamus.net/dave","location":"","email":"[email protected]"},"url":"https://github.com/andreasgal/vtt.js/pull/122#discussion_r6628119"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/anomalizer/ngx_aws_auth/pulls/comments/8010687","id":8010687,"diff_hunk":"@@ -110,19 +198,199 @@\n ngx_conf_merge_str_value(conf->access_key, prev->access_key, \"\");\n ngx_conf_merge_str_value(conf->secret, prev->secret, \"\");\n ngx_conf_merge_str_value(conf->chop_prefix, prev->chop_prefix, \"\");\n+ ngx_conf_merge_uint_value(conf->add_date, prev->add_date, 0);\n \n return NGX_CONF_OK;\n }\n \n+static int\n+ngx_http_cmp_hnames(const void *one, const void *two) {\n+ ngx_table_elt_t *first, *second;\n+ first = (ngx_table_elt_t *) one;\n+ second = (ngx_table_elt_t *) two;\n+\n+ return ngx_strcmp(first->key.data, second->key.data);","path":"ngx_http_aws_auth.c","position":146,"original_position":146,"commit_id":"65676b71cb4d14eb498cdace3122de2e0658d13b","original_commit_id":"65676b71cb4d14eb498cdace3122de2e0658d13b","user":{"login":"tarfik","id":5798173,"avatar_url":"https://2.gravatar.com/avatar/da254aec7dfdf981042a2a98be4afcf1?d=https%3A%2F%2Fidenticons.github.com%2F7261d66775754ef783ade6b7a494b0d8.png&r=x","gravatar_id":"da254aec7dfdf981042a2a98be4afcf1","url":"https://api.github.com/users/tarfik","html_url":"https://github.com/tarfik","followers_url":"https://api.github.com/users/tarfik/followers","following_url":"https://api.github.com/users/tarfik/following{/other_user}","gists_url":"https://api.github.com/users/tarfik/gists{/gist_id}","starred_url":"https://api.github.com/users/tarfik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tarfik/subscriptions","organizations_url":"https://api.github.com/users/tarfik/orgs","repos_url":"https://api.github.com/users/tarfik/repos","events_url":"https://api.github.com/users/tarfik/events{/privacy}","received_events_url":"https://api.github.com/users/tarfik/received_events","type":"User","site_admin":false},"body":"I will change header-key to lowercase.\r\n\r\n\r\n2013/11/30 Arvind Jayaprakash <[email protected]>\r\n\r\n> In ngx_http_aws_auth.c:\r\n>\r\n> >\r\n> > return NGX_CONF_OK;\r\n> > }\r\n> >\r\n> > +static int\r\n> > +ngx_http_cmp_hnames(const void *one, const void *two) {\r\n> > + ngx_table_elt_t *first, *second;\r\n> > + first = (ngx_table_elt_t *) one;\r\n> > + second = (ngx_table_elt_t *) two;\r\n> > +\r\n> > + return ngx_strcmp(first->key.data, second->key.data);\r\n>\r\n> If we do not assume that all inputs are lowercase, then we should use\r\n> ngx_strcasecmp instead of ngx_strcmp\r\n>\r\n> —\r\n> Reply to this email directly or view it on GitHub<https://github.com/anomalizer/ngx_aws_auth/pull/5/files#r8010327>\r\n> .\r\n>\r\n\r\n\r\n\r\n-- \r\nPozdrawiam\r\nDominik","created_at":"2013-11-30T11:07:13Z","updated_at":"2013-11-30T11:07:13Z","html_url":"https://github.com/anomalizer/ngx_aws_auth/pull/5#discussion_r8010687","pull_request_url":"https://api.github.com/repos/anomalizer/ngx_aws_auth/pulls/5","_links":{"self":{"href":"https://api.github.com/repos/anomalizer/ngx_aws_auth/pulls/comments/8010687"},"html":{"href":"https://github.com/anomalizer/ngx_aws_auth/pull/5#discussion_r8010687"},"pull_request":{"href":"https://api.github.com/repos/anomalizer/ngx_aws_auth/pulls/5"}}}} | {
"id": 1195063,
"name": "ngx_aws_auth",
"url": "https://github.com/anomalizer/ngx_aws_auth"
} | {
"id": null,
"login": "tarfik",
"gravatar_id": "da254aec7dfdf981042a2a98be4afcf1",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-11-30T11:07:13 | null | {"repository":{"description":"nginx module to proxy to authenticated AWS services","homepage":"","watchers":55,"stargazers":55,"forks":17,"fork":false,"size":336,"owner":"anomalizer","private":false,"open_issues":2,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"C","created_at":"2010-12-23T23:12:43-08:00","pushed_at":"2013-11-29T22:59:06-08:00","master_branch":"master"},"actor_attributes":{"type":"User","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/anomalizer/ngx_aws_auth/pull/5#discussion_r8010687"} |
PullRequestReviewCommentEvent | true | {"comment":{"original_position":63,"user":{"type":"User","followers_url":"https://api.github.com/users/tumb1er/followers","login":"tumb1er","id":1587241,"avatar_url":"https://secure.gravatar.com/avatar/b84cd7dbbc3cfdcfd5d269470f386993?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","repos_url":"https://api.github.com/users/tumb1er/repos","url":"https://api.github.com/users/tumb1er","following_url":"https://api.github.com/users/tumb1er/following","events_url":"https://api.github.com/users/tumb1er/events{/privacy}","gravatar_id":"b84cd7dbbc3cfdcfd5d269470f386993","received_events_url":"https://api.github.com/users/tumb1er/received_events","gists_url":"https://api.github.com/users/tumb1er/gists{/gist_id}","organizations_url":"https://api.github.com/users/tumb1er/orgs","starred_url":"https://api.github.com/users/tumb1er/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tumb1er/subscriptions"},"path":"cacheops/invalidation.py","id":2758938,"url":"https://api.github.com/repos/Suor/django-cacheops/pulls/comments/2758938","created_at":"2013-01-24T14:46:34Z","commit_id":"dc7a00ce31eddb5d69bda56f9dc20c5567b59551","body":"Please show an example when it can happen. ","updated_at":"2013-01-24T14:46:34Z","original_commit_id":"dc7a00ce31eddb5d69bda56f9dc20c5567b59551","position":63,"_links":{"pull_request":{"href":"https://api.github.com/repos/Suor/django-cacheops/pulls/27"},"html":{"href":"https://github.com/Suor/django-cacheops/pull/27#discussion_r2758938"},"self":{"href":"https://api.github.com/repos/Suor/django-cacheops/pulls/comments/2758938"}}}} | {
"id": 1846638,
"name": "django-cacheops",
"url": "https://github.com/Suor/django-cacheops"
} | {
"id": null,
"login": "tumb1er",
"gravatar_id": "b84cd7dbbc3cfdcfd5d269470f386993",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-01-24T14:46:34 | null | {"repository":{"owner":"Suor","has_issues":true,"homepage":"","watchers":89,"has_downloads":true,"created_at":"2011-06-04T05:25:47-07:00","stargazers":89,"open_issues":6,"description":"A slick ORM cache with automatic granular event-driven invalidation.","pushed_at":"2012-12-24T08:52:25-08:00","forks":12,"language":"Python","fork":false,"size":136,"has_wiki":true,"private":false},"actor_attributes":{"type":"User","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/Suor/django-cacheops/pull/27#discussion_r2758938"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/bdpayne/libvmi/pulls/comments/5407988","id":5407988,"body":"root@guanglin-Z68A-D3H-B3:~/libvmi-forked/tools/performance# make\r\ngcc -Wall -Werror -O3 -Wp,-MD,.kern_sym.d -o kern_sym kern_sym.c common.c -lxenctrl -lvmi -lm\r\ngcc -Wall -Werror -O3 -Wp,-MD,.virt_addr.d -o virt_addr virt_addr.c common.c -lxenctrl -lvmi -lm\r\nvirt_addr.c: In function ‘main’:\r\nvirt_addr.c:44:8: error: variable ‘paddr’ set but not used [-Werror=unused-but-set-variable]\r\ncc1: all warnings being treated as errors\r\nmake: *** [virt_addr] Error 1\r\n","diff_hunk":"@@ -1,7 +1,7 @@\n CC = gcc\n \n CFLAGS += -Wall\n-CFLAGS += -Werror\n+CFLAGS += #-Werror","path":"tools/performance/Makefile","position":5,"original_position":5,"commit_id":"66657ecf2105990569b29c2a00fd2a072d2b39e2","original_commit_id":"66657ecf2105990569b29c2a00fd2a072d2b39e2","user":{"login":"mzguanglin","id":667845,"avatar_url":"https://secure.gravatar.com/avatar/c75f2c96fc02c50c2c10faaa27bc227c?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"c75f2c96fc02c50c2c10faaa27bc227c","url":"https://api.github.com/users/mzguanglin","html_url":"https://github.com/mzguanglin","followers_url":"https://api.github.com/users/mzguanglin/followers","following_url":"https://api.github.com/users/mzguanglin/following{/other_user}","gists_url":"https://api.github.com/users/mzguanglin/gists{/gist_id}","starred_url":"https://api.github.com/users/mzguanglin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mzguanglin/subscriptions","organizations_url":"https://api.github.com/users/mzguanglin/orgs","repos_url":"https://api.github.com/users/mzguanglin/repos","events_url":"https://api.github.com/users/mzguanglin/events{/privacy}","received_events_url":"https://api.github.com/users/mzguanglin/received_events","type":"User"},"created_at":"2013-07-25T19:47:01Z","updated_at":"2013-07-25T19:47:01Z","html_url":"https://github.com/bdpayne/libvmi/pull/87#discussion_r5407988","pull_request_url":"https://api.github.com/repos/bdpayne/libvmi/pulls/87","_links":{"self":{"href":"https://api.github.com/repos/bdpayne/libvmi/pulls/comments/5407988"},"html":{"href":"https://github.com/bdpayne/libvmi/pull/87#discussion_r5407988"},"pull_request":{"href":"https://api.github.com/repos/bdpayne/libvmi/pulls/87"}}}} | {
"id": 7414172,
"name": "libvmi",
"url": "https://github.com/bdpayne/libvmi"
} | {
"id": null,
"login": "mzguanglin",
"gravatar_id": "c75f2c96fc02c50c2c10faaa27bc227c",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-07-25T19:47:01 | null | {"repository":{"description":"","watchers":11,"stargazers":11,"forks":16,"fork":false,"size":2167,"owner":"bdpayne","private":false,"open_issues":1,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"C","created_at":"2013-01-02T14:06:12-08:00","pushed_at":"2013-07-25T12:28:22-07:00","master_branch":"master"},"actor_attributes":{"type":"User","name":"Guanglin Xu","company":"Carnegie Mellon University","blog":"http://www.andrew.cmu.edu/user/guanglin/","location":"Pittsburgh, PA 15213, USA","email":"[email protected]"},"url":"https://github.com/bdpayne/libvmi/pull/87#discussion_r5407988"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/breunigs/ingress-intel-total-conversion/pulls/comments/3210602","id":3210602,"body":"(and clone that array for local use/modification)","diff_hunk":"@@ -69,32 +69,74 @@ window.getAvgResoDist = function(d) {\n \n window.getAttackApGain = function(d) {\n var resoCount = 0;\n+ var maxResonators = [ 0, 8, 4, 4, 4, 2, 2, 1, 1 ];","path":"code/portal_info.js","position":4,"original_position":4,"commit_id":"98e1a9c9e00c64c125b766b8c84cc51631caf84c","original_commit_id":"98e1a9c9e00c64c125b766b8c84cc51631caf84c","user":{"login":"breunigs","id":307954,"avatar_url":"https://secure.gravatar.com/avatar/10023f6ee01782524d34026c32c528c0?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"10023f6ee01782524d34026c32c528c0","url":"https://api.github.com/users/breunigs","html_url":"https://github.com/breunigs","followers_url":"https://api.github.com/users/breunigs/followers","following_url":"https://api.github.com/users/breunigs/following","gists_url":"https://api.github.com/users/breunigs/gists{/gist_id}","starred_url":"https://api.github.com/users/breunigs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/breunigs/subscriptions","organizations_url":"https://api.github.com/users/breunigs/orgs","repos_url":"https://api.github.com/users/breunigs/repos","events_url":"https://api.github.com/users/breunigs/events{/privacy}","received_events_url":"https://api.github.com/users/breunigs/received_events","type":"User"},"created_at":"2013-03-01T20:33:54Z","updated_at":"2013-03-01T20:33:54Z","_links":{"self":{"href":"https://api.github.com/repos/breunigs/ingress-intel-total-conversion/pulls/comments/3210602"},"html":{"href":"https://github.com/breunigs/ingress-intel-total-conversion/pull/336#discussion_r3210602"},"pull_request":{"href":"https://api.github.com/repos/breunigs/ingress-intel-total-conversion/pulls/336"}}}} | {
"id": 7957605,
"name": "ingress-intel-total-conversion",
"url": "https://github.com/breunigs/ingress-intel-total-conversion"
} | {
"id": null,
"login": "breunigs",
"gravatar_id": "10023f6ee01782524d34026c32c528c0",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-03-01T20:33:54 | null | {"repository":{"description":"Ingress Intel Total Conversion (IITC) UserScript. Redefines your intel map experiences and is easily extendable. ","homepage":"","watchers":334,"stargazers":334,"forks":126,"fork":false,"size":1360,"owner":"breunigs","private":false,"open_issues":51,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"JavaScript","created_at":"2013-02-01T04:10:17-08:00","pushed_at":"2013-03-01T05:49:55-08:00","master_branch":"gh-pages"},"actor_attributes":{"type":"User","name":"Stefan Breunig","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/breunigs/ingress-intel-total-conversion/pull/336#discussion_r3210602"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/ghoneycutt/puppet-module-ssh/pulls/comments/7006336","id":7006336,"diff_hunk":"@@ -1,19 +1,6 @@\n-# == Class: ssh\n+# ## Class: ssh ##","path":"manifests/init.pp","position":2,"original_position":2,"commit_id":"78ed132af312c6b30745a9646ac58d8783f3b8fb","original_commit_id":"78ed132af312c6b30745a9646ac58d8783f3b8fb","user":{"login":"ghoneycutt","id":313891,"avatar_url":"https://2.gravatar.com/avatar/ed44598531ce06b07e12ef0e281e3c40?d=https%3A%2F%2Fidenticons.github.com%2F63c40a270638d4ea6fb91fbefef668b0.png","gravatar_id":"ed44598531ce06b07e12ef0e281e3c40","url":"https://api.github.com/users/ghoneycutt","html_url":"https://github.com/ghoneycutt","followers_url":"https://api.github.com/users/ghoneycutt/followers","following_url":"https://api.github.com/users/ghoneycutt/following{/other_user}","gists_url":"https://api.github.com/users/ghoneycutt/gists{/gist_id}","starred_url":"https://api.github.com/users/ghoneycutt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ghoneycutt/subscriptions","organizations_url":"https://api.github.com/users/ghoneycutt/orgs","repos_url":"https://api.github.com/users/ghoneycutt/repos","events_url":"https://api.github.com/users/ghoneycutt/events{/privacy}","received_events_url":"https://api.github.com/users/ghoneycutt/received_events","type":"User","site_admin":false},"body":"We are not very consistent, but <pre>== Class: ssh</pre> is the winner. I initially tried out the other way, because it renders in markdown. But that was back when we documented things 2x.","created_at":"2013-10-16T16:08:18Z","updated_at":"2013-10-16T16:08:18Z","html_url":"https://github.com/ghoneycutt/puppet-module-ssh/pull/16#discussion_r7006336","pull_request_url":"https://api.github.com/repos/ghoneycutt/puppet-module-ssh/pulls/16","_links":{"self":{"href":"https://api.github.com/repos/ghoneycutt/puppet-module-ssh/pulls/comments/7006336"},"html":{"href":"https://github.com/ghoneycutt/puppet-module-ssh/pull/16#discussion_r7006336"},"pull_request":{"href":"https://api.github.com/repos/ghoneycutt/puppet-module-ssh/pulls/16"}}}} | {
"id": 10101924,
"name": "puppet-module-ssh",
"url": "https://github.com/ghoneycutt/puppet-module-ssh"
} | {
"id": null,
"login": "ghoneycutt",
"gravatar_id": "ed44598531ce06b07e12ef0e281e3c40",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-10-16T16:08:18 | null | {"repository":{"description":"Puppet module to manage SSH","watchers":3,"stargazers":3,"forks":10,"fork":false,"size":206,"owner":"ghoneycutt","private":false,"open_issues":3,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Puppet","created_at":"2013-05-16T06:36:22-07:00","pushed_at":"2013-10-15T10:04:36-07:00","master_branch":"master"},"actor_attributes":{"type":"User","name":"Garrett Honeycutt","blog":"http://garretthoneycutt.com","location":"Stockholm && Indianapolis","email":"[email protected]"},"url":"https://github.com/ghoneycutt/puppet-module-ssh/pull/16#discussion_r7006336"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/hrydgard/ppsspp/pulls/comments/6963617","id":6963617,"diff_hunk":"@@ -360,17 +360,42 @@ void PSP_RunLoopFor(int cycles) {\n \treturn coreParameter;\n }\n \n+std::string GetSysDirectory(PSPDirectories directoryType) {\n+\tswitch (directoryType) {\n+\tcase DIRECTORY_CHEATS:\n+\t\treturn g_Config.memCardDirectory + \"/PSP/Cheats/\";","path":"Core/System.cpp","position":7,"original_position":7,"commit_id":"19f527d7f5d3dcffa0a19d964b67dd5a9ee01a78","original_commit_id":"19f527d7f5d3dcffa0a19d964b67dd5a9ee01a78","user":{"login":"unknownbrackets","id":191233,"avatar_url":"https://1.gravatar.com/avatar/f10adb38bc3813ae73942676eb05046e?d=https%3A%2F%2Fidenticons.github.com%2F6afebdf26f6830726f8d25a527fe4e3f.png","gravatar_id":"f10adb38bc3813ae73942676eb05046e","url":"https://api.github.com/users/unknownbrackets","html_url":"https://github.com/unknownbrackets","followers_url":"https://api.github.com/users/unknownbrackets/followers","following_url":"https://api.github.com/users/unknownbrackets/following{/other_user}","gists_url":"https://api.github.com/users/unknownbrackets/gists{/gist_id}","starred_url":"https://api.github.com/users/unknownbrackets/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unknownbrackets/subscriptions","organizations_url":"https://api.github.com/users/unknownbrackets/orgs","repos_url":"https://api.github.com/users/unknownbrackets/repos","events_url":"https://api.github.com/users/unknownbrackets/events{/privacy}","received_events_url":"https://api.github.com/users/unknownbrackets/received_events","type":"User","site_admin":false},"body":"`g_Config.memCardDirectory` generally has a trailing slash. I recommend not changing this, it'd probably be dangerous.\r\n\r\n-[Unknown]","created_at":"2013-10-15T06:35:15Z","updated_at":"2013-10-15T06:35:15Z","html_url":"https://github.com/hrydgard/ppsspp/pull/4198#discussion_r6963617","pull_request_url":"https://api.github.com/repos/hrydgard/ppsspp/pulls/4198","_links":{"self":{"href":"https://api.github.com/repos/hrydgard/ppsspp/pulls/comments/6963617"},"html":{"href":"https://github.com/hrydgard/ppsspp/pull/4198#discussion_r6963617"},"pull_request":{"href":"https://api.github.com/repos/hrydgard/ppsspp/pulls/4198"}}}} | {
"id": 6486826,
"name": "ppsspp",
"url": "https://github.com/hrydgard/ppsspp"
} | {
"id": null,
"login": "unknownbrackets",
"gravatar_id": "f10adb38bc3813ae73942676eb05046e",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-10-15T06:35:15 | null | {"repository":{"description":"A PSP emulator for Android, Windows, Mac, Linux and Blackberry 10, written in C++. Want to contribute? Join us in #ppsspp on EFnet (IRC) or just send pull requests / issues.","homepage":"http://www.ppsspp.org","watchers":737,"stargazers":737,"forks":410,"fork":false,"size":149755,"owner":"hrydgard","private":false,"open_issues":5,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"C++","created_at":"2012-11-01T01:41:48-07:00","pushed_at":"2013-10-14T22:29:03-07:00","master_branch":"master"},"actor_attributes":{"type":"User","name":"Unknown W. Brackets","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/hrydgard/ppsspp/pull/4198#discussion_r6963617"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/Azanor/thaumcraft/pulls/comments/7762373","id":7762373,"diff_hunk":"@@ -51,9 +51,9 @@ tile.blockCustomOre.0.name=Zinnobererz\n tile.blockCustomOre.1.name=Luft-Durchzogener Stein\n tile.blockCustomOre.2.name=Feuer-Durchzogener Stein\n tile.blockCustomOre.3.name=Wasser-Durchzogener Stein\n-tile.blockCustomOre.4.name=Ordnung-Durchzogener Stein\n-tile.blockCustomOre.5.name=Entropie-Durchzogener Stein\n-tile.blockCustomOre.6.name=Trüber Durchzogener Stein\n+tile.blockCustomOre.4.name=Erde-Durchzogener Stein\n+tile.blockCustomOre.5.name=Reinheit-Durchzogener Stein","path":"de_DE.lang","position":8,"original_position":8,"commit_id":"d9899c775182ee0da9068ed7e3a9b39a6e17038e","original_commit_id":"d9899c775182ee0da9068ed7e3a9b39a6e17038e","user":{"login":"Vexatos","id":4135064,"avatar_url":"https://0.gravatar.com/avatar/7b4b15f59f1cef4cbe60e69ad650fa6b?d=https%3A%2F%2Fidenticons.github.com%2F6e02b2a44328f0a1030352e7c070f404.png&r=x","gravatar_id":"7b4b15f59f1cef4cbe60e69ad650fa6b","url":"https://api.github.com/users/Vexatos","html_url":"https://github.com/Vexatos","followers_url":"https://api.github.com/users/Vexatos/followers","following_url":"https://api.github.com/users/Vexatos/following{/other_user}","gists_url":"https://api.github.com/users/Vexatos/gists{/gist_id}","starred_url":"https://api.github.com/users/Vexatos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Vexatos/subscriptions","organizations_url":"https://api.github.com/users/Vexatos/orgs","repos_url":"https://api.github.com/users/Vexatos/repos","events_url":"https://api.github.com/users/Vexatos/events{/privacy}","received_events_url":"https://api.github.com/users/Vexatos/received_events","type":"User","site_admin":false},"body":"\"Order\" means \"Ordnung\", not \"Reinheit\", that would be purity, in Latin \"munditia\"","created_at":"2013-11-19T16:23:39Z","updated_at":"2013-11-19T16:23:39Z","html_url":"https://github.com/Azanor/thaumcraft/pull/305#discussion_r7762373","pull_request_url":"https://api.github.com/repos/Azanor/thaumcraft/pulls/305","_links":{"self":{"href":"https://api.github.com/repos/Azanor/thaumcraft/pulls/comments/7762373"},"html":{"href":"https://github.com/Azanor/thaumcraft/pull/305#discussion_r7762373"},"pull_request":{"href":"https://api.github.com/repos/Azanor/thaumcraft/pulls/305"}}}} | {
"id": 13381132,
"name": "thaumcraft",
"url": "https://github.com/Azanor/thaumcraft"
} | {
"id": null,
"login": "Vexatos",
"gravatar_id": "7b4b15f59f1cef4cbe60e69ad650fa6b",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-11-19T16:23:39 | null | {"repository":{"description":"Thaumcraft localization files & bug reports","homepage":"","watchers":19,"stargazers":19,"forks":64,"fork":false,"size":1379,"owner":"Azanor","private":false,"open_issues":29,"has_issues":true,"has_downloads":true,"has_wiki":true,"created_at":"2013-10-07T03:41:13-07:00","pushed_at":"2013-11-19T06:27:13-08:00","master_branch":"master"},"actor_attributes":{"type":"User","name":"Vexatos","company":"Pastry Fork, Inc.","location":"Germany","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/Azanor/thaumcraft/pull/305#discussion_r7762373"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/chaitanyagupta/XCDataModelPrinter/pulls/comments/5836691","id":5836691,"body":"There's no need to use sets here -- you can just use `-[NSMutableArray removeObjectsInArray:]` I think.","diff_hunk":"@@ -119,7 +142,20 @@ - (BOOL)printPath:(NSString *)path {\n }\n [entityStr appendFormat:@\" (%@)\", [entity managedObjectClassName]];\n NSPrintf(@\"%@\\n\", entityStr);\n- NSMutableArray *properties = [NSMutableArray arrayWithArray:[entity properties]];\n+ \n+ NSMutableArray *properties = nil;\n+ \n+ if (self._mode == MOMPrinterIncludeSuperclassProperties) {\n+ properties = [NSMutableArray arrayWithArray:[entity properties]];\n+ } else {\n+ // Filter out properties that belong to superclasses.\n+ NSSet *superentityProperties = [NSSet setWithArray:[superentity properties]];\n+ NSMutableSet *entityProperties = [NSMutableSet setWithArray:[entity properties]];\n+ [entityProperties minusSet:superentityProperties];","path":"src/MOMPrinter.m","position":46,"original_position":46,"commit_id":"af65be8328d9d4957691ec0c720e3f96789bee44","original_commit_id":"af65be8328d9d4957691ec0c720e3f96789bee44","user":{"login":"chaitanyagupta","id":35972,"avatar_url":"https://1.gravatar.com/avatar/deeb3927acbdada482f11ddbfe2bc7f0?d=https%3A%2F%2Fidenticons.github.com%2F33ca818e77cf91be0c24c27d53b15826.png","gravatar_id":"deeb3927acbdada482f11ddbfe2bc7f0","url":"https://api.github.com/users/chaitanyagupta","html_url":"https://github.com/chaitanyagupta","followers_url":"https://api.github.com/users/chaitanyagupta/followers","following_url":"https://api.github.com/users/chaitanyagupta/following{/other_user}","gists_url":"https://api.github.com/users/chaitanyagupta/gists{/gist_id}","starred_url":"https://api.github.com/users/chaitanyagupta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chaitanyagupta/subscriptions","organizations_url":"https://api.github.com/users/chaitanyagupta/orgs","repos_url":"https://api.github.com/users/chaitanyagupta/repos","events_url":"https://api.github.com/users/chaitanyagupta/events{/privacy}","received_events_url":"https://api.github.com/users/chaitanyagupta/received_events","type":"User"},"created_at":"2013-08-19T08:24:41Z","updated_at":"2013-08-19T08:24:41Z","html_url":"https://github.com/chaitanyagupta/XCDataModelPrinter/pull/1#discussion_r5836691","pull_request_url":"https://api.github.com/repos/chaitanyagupta/XCDataModelPrinter/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/chaitanyagupta/XCDataModelPrinter/pulls/comments/5836691"},"html":{"href":"https://github.com/chaitanyagupta/XCDataModelPrinter/pull/1#discussion_r5836691"},"pull_request":{"href":"https://api.github.com/repos/chaitanyagupta/XCDataModelPrinter/pulls/1"}}}} | {
"id": 4283921,
"name": "XCDataModelPrinter",
"url": "https://github.com/chaitanyagupta/XCDataModelPrinter"
} | {
"id": null,
"login": "chaitanyagupta",
"gravatar_id": "deeb3927acbdada482f11ddbfe2bc7f0",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-08-19T08:24:41 | null | {"repository":{"description":"Print a textual representation of xcdatamodel files so you can easily diff them -- primarily created for use with git-diff","homepage":"","watchers":29,"stargazers":29,"forks":2,"fork":false,"size":111,"owner":"chaitanyagupta","private":false,"open_issues":1,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Objective-C","created_at":"2012-05-10T05:02:32-07:00","pushed_at":"2012-05-24T22:45:54-07:00","master_branch":"master"},"actor_attributes":{"type":"User","name":"Chaitanya Gupta","blog":"http://chaitanyagupta.com","location":"Gurgaon, India","email":"[email protected]"},"url":"https://github.com/chaitanyagupta/XCDataModelPrinter/pull/1#discussion_r5836691"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/lballabio/quantlib/pulls/comments/7888158","id":7888158,"diff_hunk":"@@ -0,0 +1,82 @@\n+/* -*- mode: c++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */\n+\n+/*\n+ Copyright (C) 2007 François du Vignaud\n+ Copyright (C) 2007 Giorgio Facchinetti\n+ Copyright (C) 2013 Peter Caspers\n+\n+ This file is part of QuantLib, a free-software/open-source library\n+ for financial quantitative analysts and developers - http://quantlib.org/\n+\n+ QuantLib is free software: you can redistribute it and/or modify it\n+ under the terms of the QuantLib license. You should have received a\n+ copy of the license along with this program; if not, please email\n+ <[email protected]>. The license is also available online at\n+ <http://quantlib.org/license.shtml>.\n+\n+ This program is distributed in the hope that it will be useful, but WITHOUT\n+ ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS\n+ FOR A PARTICULAR PURPOSE. See the license for more details.\n+*/\n+\n+#include <ql/math/optimization/projection.hpp>\n+\n+namespace QuantLib {\n+\n+ Projection::Projection(const Array ¶metersValues,\n+ const std::vector<bool> ¶metersFreedoms)\n+ : numberOfFreeParameters_(0), fixedParameters_(parametersValues),\n+ actualParameters_(parametersValues),\n+ parametersFreedoms_(parametersFreedoms) {\n+\n+ if (parametersFreedoms_.size() == 0)\n+ parametersFreedoms_ =\n+ std::vector<bool>(actualParameters_.size(), false);\n+\n+ QL_REQUIRE(fixedParameters_.size() == parametersFreedoms_.size(),\n+ \"fixedParameters_.size()!=parametersFreedoms_.size()\");\n+ for (Size i = 0; i < parametersFreedoms_.size(); i++)\n+ if (!parametersFreedoms_[i])\n+ numberOfFreeParameters_++;","path":"QuantLib/ql/math/optimization/projection.cpp","position":40,"original_position":40,"commit_id":"5b29c6e075b901a119fa0e614682c39a66806058","original_commit_id":"5b29c6e075b901a119fa0e614682c39a66806058","user":{"login":"lballabio","id":170560,"avatar_url":"https://0.gravatar.com/avatar/97d48f903085f5d2283cc63a80cfa825?d=https%3A%2F%2Fidenticons.github.com%2Ff17954b909303aa5a41f1025724dfbb1.png&r=x","gravatar_id":"97d48f903085f5d2283cc63a80cfa825","url":"https://api.github.com/users/lballabio","html_url":"https://github.com/lballabio","followers_url":"https://api.github.com/users/lballabio/followers","following_url":"https://api.github.com/users/lballabio/following{/other_user}","gists_url":"https://api.github.com/users/lballabio/gists{/gist_id}","starred_url":"https://api.github.com/users/lballabio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lballabio/subscriptions","organizations_url":"https://api.github.com/users/lballabio/orgs","repos_url":"https://api.github.com/users/lballabio/repos","events_url":"https://api.github.com/users/lballabio/events{/privacy}","received_events_url":"https://api.github.com/users/lballabio/received_events","type":"User","site_admin":false},"body":"I would have expected that `parametersFreedom_[i] = true` meant that the parameter were free, not the other way around.\r\nI realize this comes from the current `ProjectedCostFunction` code and thus we can't change the behavior, but at least I'd change the parameter name. Do you have any suggestions?","created_at":"2013-11-25T11:20:54Z","updated_at":"2013-11-25T11:20:54Z","html_url":"https://github.com/lballabio/quantlib/pull/48#discussion_r7888158","pull_request_url":"https://api.github.com/repos/lballabio/quantlib/pulls/48","_links":{"self":{"href":"https://api.github.com/repos/lballabio/quantlib/pulls/comments/7888158"},"html":{"href":"https://github.com/lballabio/quantlib/pull/48#discussion_r7888158"},"pull_request":{"href":"https://api.github.com/repos/lballabio/quantlib/pulls/48"}}}} | {
"id": 10521431,
"name": "quantlib",
"url": "https://github.com/lballabio/quantlib"
} | {
"id": null,
"login": "lballabio",
"gravatar_id": "97d48f903085f5d2283cc63a80cfa825",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-11-25T11:20:54 | null | {"repository":{"description":"The QuantLib C++ library and extensions","homepage":"http://quantlib.org","watchers":54,"stargazers":54,"forks":88,"fork":false,"size":409331,"owner":"lballabio","private":false,"open_issues":0,"has_issues":true,"has_downloads":true,"has_wiki":false,"language":"C++","created_at":"2013-06-06T00:47:12-07:00","pushed_at":"2013-11-25T00:06:34-08:00","master_branch":"master"},"actor_attributes":{"type":"User","name":"Luigi Ballabio","blog":"http://implementingquantlib.blogspot.com","location":"Milan, Italy","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/lballabio/quantlib/pull/48#discussion_r7888158"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/daleharvey/pouchdb/pulls/comments/8067822","id":8067822,"diff_hunk":"@@ -229,23 +229,38 @@ function IdbPouch(opts, callback) {\n \"Attachments need to be base64 encoded\");\n return PouchUtils.call(callback, err);\n }\n- att.digest = 'md5-' + PouchUtils.Crypto.MD5(data);\n+ var buffer = new Uint8Array(data);","path":"src/adapters/pouch.idb.js","position":5,"original_position":5,"commit_id":"c24a34b4a2f01bceff4bed6a66387435ea841302","original_commit_id":"c24a34b4a2f01bceff4bed6a66387435ea841302","user":{"login":"calvinmetcalf","id":1128607,"avatar_url":"https://2.gravatar.com/avatar/e8153037a068f1c32e546f82729a64a5?d=https%3A%2F%2Fidenticons.github.com%2F88e1c860425cda43d74838438768616b.png&r=x","gravatar_id":"e8153037a068f1c32e546f82729a64a5","url":"https://api.github.com/users/calvinmetcalf","html_url":"https://github.com/calvinmetcalf","followers_url":"https://api.github.com/users/calvinmetcalf/followers","following_url":"https://api.github.com/users/calvinmetcalf/following{/other_user}","gists_url":"https://api.github.com/users/calvinmetcalf/gists{/gist_id}","starred_url":"https://api.github.com/users/calvinmetcalf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/calvinmetcalf/subscriptions","organizations_url":"https://api.github.com/users/calvinmetcalf/orgs","repos_url":"https://api.github.com/users/calvinmetcalf/repos","events_url":"https://api.github.com/users/calvinmetcalf/events{/privacy}","received_events_url":"https://api.github.com/users/calvinmetcalf/received_events","type":"User","site_admin":false},"body":"two issues\r\n\r\n1. all browsers claim to be Mozilla\r\n2. why exactly are you trying to create a typed array from a string?","created_at":"2013-12-03T17:37:26Z","updated_at":"2013-12-03T17:37:26Z","html_url":"https://github.com/daleharvey/pouchdb/pull/1078#discussion_r8067822","pull_request_url":"https://api.github.com/repos/daleharvey/pouchdb/pulls/1078","_links":{"self":{"href":"https://api.github.com/repos/daleharvey/pouchdb/pulls/comments/8067822"},"html":{"href":"https://github.com/daleharvey/pouchdb/pull/1078#discussion_r8067822"},"pull_request":{"href":"https://api.github.com/repos/daleharvey/pouchdb/pulls/1078"}}}} | {
"id": 714074,
"name": "pouchdb",
"url": "https://github.com/daleharvey/pouchdb"
} | {
"id": null,
"login": "calvinmetcalf",
"gravatar_id": "e8153037a068f1c32e546f82729a64a5",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-12-03T17:37:26 | null | {"repository":{"description":"PouchDB is a pocket-sized database.","homepage":"","watchers":1880,"stargazers":1880,"forks":203,"fork":false,"size":40467,"owner":"daleharvey","private":false,"open_issues":96,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"JavaScript","created_at":"2010-06-10T11:34:24-07:00","pushed_at":"2013-12-03T02:03:02-08:00","master_branch":"master"},"actor_attributes":{"type":"User","name":"Calvin Metcalf","company":"App Geo","blog":"http://calvinmetcalf.com/","location":"Boston","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/daleharvey/pouchdb/pull/1078#discussion_r8067822"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/stfalcon/fwdays/pulls/comments/6118643","id":6118643,"body":"после переноса константы в класс ее можно вызвать self::COUNT...","diff_hunk":"@@ -30,7 +30,33 @@ public function indexAction($event_slug)\n /** @var $ticketRepository \\Stfalcon\\Bundle\\EventBundle\\Repository\\TicketRepository */\n $ticketRepository = $this->getDoctrine()->getManager()->getRepository('StfalconEventBundle:Ticket');\n \n- $participants = $ticketRepository->findTicketsByEventGroupByUser($event);\n+ $participants = $ticketRepository->findTicketsByEventGroupByUser($event, COUNT_PARTICIPANTS);\n+\n+ return array(\n+ 'event' => $event,\n+ 'participants' => $participants\n+ );\n+ }\n+\n+ /**\n+ * List of participants\n+ *\n+ * @param string $event_slug\n+ * @param int $offset\n+ *\n+ * @return array\n+ *\n+ * @Route(\"/event/{event_slug}/participants/{offset}\", name=\"event_list_participants\")\n+ * @Template()\n+ */\n+ public function listParticipantsAction($event_slug, $offset)\n+ {\n+ $event = $this->getEventBySlug($event_slug);\n+\n+ /** @var $ticketRepository \\Stfalcon\\Bundle\\EventBundle\\Repository\\TicketRepository */\n+ $ticketRepository = $this->getDoctrine()->getManager()->getRepository('StfalconEventBundle:Ticket');\n+\n+ $participants = $ticketRepository->findTicketsByEventGroupByUser($event, COUNT_PARTICIPANTS, $offset);","path":"src/Stfalcon/Bundle/EventBundle/Controller/ParticipantController.php","position":40,"original_position":40,"commit_id":"eb48766ff858306fad39db92de4d5b62f287ea5f","original_commit_id":"eb48766ff858306fad39db92de4d5b62f287ea5f","user":{"login":"fre5h","id":815865,"avatar_url":"https://1.gravatar.com/avatar/af782ccac6b5343c6544f1db45334485?d=https%3A%2F%2Fidenticons.github.com%2Fe46d8fc4fb8bc8b6be54567e2a8e9449.png","gravatar_id":"af782ccac6b5343c6544f1db45334485","url":"https://api.github.com/users/fre5h","html_url":"https://github.com/fre5h","followers_url":"https://api.github.com/users/fre5h/followers","following_url":"https://api.github.com/users/fre5h/following{/other_user}","gists_url":"https://api.github.com/users/fre5h/gists{/gist_id}","starred_url":"https://api.github.com/users/fre5h/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fre5h/subscriptions","organizations_url":"https://api.github.com/users/fre5h/orgs","repos_url":"https://api.github.com/users/fre5h/repos","events_url":"https://api.github.com/users/fre5h/events{/privacy}","received_events_url":"https://api.github.com/users/fre5h/received_events","type":"User"},"created_at":"2013-09-03T07:13:29Z","updated_at":"2013-09-03T07:13:29Z","html_url":"https://github.com/stfalcon/fwdays/pull/140#discussion_r6118643","pull_request_url":"https://api.github.com/repos/stfalcon/fwdays/pulls/140","_links":{"self":{"href":"https://api.github.com/repos/stfalcon/fwdays/pulls/comments/6118643"},"html":{"href":"https://github.com/stfalcon/fwdays/pull/140#discussion_r6118643"},"pull_request":{"href":"https://api.github.com/repos/stfalcon/fwdays/pulls/140"}}}} | {
"id": 2181023,
"name": "fwdays",
"url": "https://github.com/stfalcon/fwdays"
} | {
"id": null,
"login": "fre5h",
"gravatar_id": "af782ccac6b5343c6544f1db45334485",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-09-03T07:13:29 | null | {"repository":{"description":"Powered by Symfony2. Site for conference \"Frameworks Days\"","homepage":"","watchers":15,"stargazers":15,"forks":19,"fork":false,"size":544,"owner":"stfalcon","private":false,"open_issues":2,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"PHP","created_at":"2011-08-09T11:52:34-07:00","pushed_at":"2013-09-02T03:09:45-07:00","master_branch":"master"},"actor_attributes":{"type":"User","name":"Artem Genvald","company":"Web Studio Stfalcon.com","blog":"http://fre5h.github.io/","location":"Ukraine, Khmelnytskyi","email":"[email protected]"},"url":"https://github.com/stfalcon/fwdays/pull/140#discussion_r6118643"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/nzakas/eslint/pulls/comments/5570568","id":5570568,"body":"I believe you're missing `.md`.","diff_hunk":"@@ -42,6 +42,7 @@ These are rules designed to prevent you from making mistakes. They either prescr\n * [no-loop-func](no-loop-func.md) - disallow creation of functions within loops\n * [no-empty-label](no-empty-label.md) - disallow use of labels for anything other then loops and switches\n * [unnecessary-strict](unnecessary-strict.md) - disallow unnecessary use of `\"use strict\";` when already in strict mode\n+* [no-unused-vars](no-unused-vars) - disallow declaration of variables that are not used in the code","path":"docs/rules/README.md","position":4,"original_position":4,"commit_id":"6cd101023bf4a18b6519da8ccff9aac8adf79d1b","original_commit_id":"6cd101023bf4a18b6519da8ccff9aac8adf79d1b","user":{"login":"michaelficarra","id":218840,"avatar_url":"https://secure.gravatar.com/avatar/24fb0088507077f7852adaec4f6b679f?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"24fb0088507077f7852adaec4f6b679f","url":"https://api.github.com/users/michaelficarra","html_url":"https://github.com/michaelficarra","followers_url":"https://api.github.com/users/michaelficarra/followers","following_url":"https://api.github.com/users/michaelficarra/following{/other_user}","gists_url":"https://api.github.com/users/michaelficarra/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelficarra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelficarra/subscriptions","organizations_url":"https://api.github.com/users/michaelficarra/orgs","repos_url":"https://api.github.com/users/michaelficarra/repos","events_url":"https://api.github.com/users/michaelficarra/events{/privacy}","received_events_url":"https://api.github.com/users/michaelficarra/received_events","type":"User"},"created_at":"2013-08-04T20:56:39Z","updated_at":"2013-08-04T20:56:39Z","html_url":"https://github.com/nzakas/eslint/pull/203#discussion_r5570568","pull_request_url":"https://api.github.com/repos/nzakas/eslint/pulls/203","_links":{"self":{"href":"https://api.github.com/repos/nzakas/eslint/pulls/comments/5570568"},"html":{"href":"https://github.com/nzakas/eslint/pull/203#discussion_r5570568"},"pull_request":{"href":"https://api.github.com/repos/nzakas/eslint/pulls/203"}}}} | {
"id": 11061773,
"name": "eslint",
"url": "https://github.com/nzakas/eslint"
} | {
"id": null,
"login": "michaelficarra",
"gravatar_id": "24fb0088507077f7852adaec4f6b679f",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-08-04T20:56:39 | null | {"repository":{"description":"A tool for identifying and reporting on patterns in JavaScript.","watchers":404,"stargazers":404,"forks":41,"fork":false,"size":2070,"owner":"nzakas","private":false,"open_issues":16,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"JavaScript","created_at":"2013-06-29T16:59:48-07:00","pushed_at":"2013-08-04T11:54:32-07:00","master_branch":"master"},"actor_attributes":{"type":"User","name":"Michael Ficarra","company":"Groupon","blog":"https://twitter.com/jspedant","location":"Chicago, IL","email":"[email protected]"},"url":"https://github.com/nzakas/eslint/pull/203#discussion_r5570568"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/gordon-morehouse/share2grandma/pulls/comments/7707048","id":7707048,"diff_hunk":"@@ -0,0 +1,17 @@\n+\"\"\"","path":"share2grandma/settings/local_sqlite.py","position":1,"original_position":1,"commit_id":"e90ab7bc8234bfc926f696b923f7ef8ae0bd6b28","original_commit_id":"713dc6cb15fafdb2ad7327941bb97ba668af5d10","user":{"login":"gordon-morehouse","id":304300,"avatar_url":"https://1.gravatar.com/avatar/085ce9f4641f31e642d1218237279de3?d=https%3A%2F%2Fidenticons.github.com%2Fafa03e579ebd093471741dae688c6dd4.png&r=x","gravatar_id":"085ce9f4641f31e642d1218237279de3","url":"https://api.github.com/users/gordon-morehouse","html_url":"https://github.com/gordon-morehouse","followers_url":"https://api.github.com/users/gordon-morehouse/followers","following_url":"https://api.github.com/users/gordon-morehouse/following{/other_user}","gists_url":"https://api.github.com/users/gordon-morehouse/gists{/gist_id}","starred_url":"https://api.github.com/users/gordon-morehouse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gordon-morehouse/subscriptions","organizations_url":"https://api.github.com/users/gordon-morehouse/orgs","repos_url":"https://api.github.com/users/gordon-morehouse/repos","events_url":"https://api.github.com/users/gordon-morehouse/events{/privacy}","received_events_url":"https://api.github.com/users/gordon-morehouse/received_events","type":"User","site_admin":false},"body":"Will you soon stop?","created_at":"2013-11-16T00:46:14Z","updated_at":"2013-11-16T00:46:14Z","html_url":"https://github.com/gordon-morehouse/share2grandma/pull/27#discussion_r7707048","pull_request_url":"https://api.github.com/repos/gordon-morehouse/share2grandma/pulls/27","_links":{"self":{"href":"https://api.github.com/repos/gordon-morehouse/share2grandma/pulls/comments/7707048"},"html":{"href":"https://github.com/gordon-morehouse/share2grandma/pull/27#discussion_r7707048"},"pull_request":{"href":"https://api.github.com/repos/gordon-morehouse/share2grandma/pulls/27"}}}} | {
"id": 9226141,
"name": "share2grandma",
"url": "https://github.com/gordon-morehouse/share2grandma"
} | {
"id": null,
"login": "gordon-morehouse",
"gravatar_id": "085ce9f4641f31e642d1218237279de3",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-11-16T00:46:14 | null | {"repository":{"description":"share2grandma is a web application designed to make it easy to share photos, web pages, blogs and more to family and friends who don't use a computer. And with share2grandma, they don't need a computer. http://www.share2grandma.com/","homepage":"","watchers":2,"stargazers":2,"forks":1,"fork":false,"size":1250,"owner":"gordon-morehouse","private":false,"open_issues":1,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Python","created_at":"2013-04-04T12:29:31-07:00","pushed_at":"2013-11-14T22:25:55-08:00","master_branch":"master"},"actor_attributes":{"type":"User","name":"Gordon Morehouse","blog":"http://gordon.morehouse.me/","location":"Portland, Oregon, USA","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/gordon-morehouse/share2grandma/pull/27#discussion_r7707048"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/gordon-morehouse/share2grandma/pulls/comments/7114275","id":7114275,"diff_hunk":"@@ -0,0 +1,34 @@\n+{% extends \"base.html\" %}","path":"accounts/templates/social_auth/usersocialauth_list.html","position":1,"original_position":1,"commit_id":"b3a801ee25856a7808c588adc991e3bcfdf46ae7","original_commit_id":"2011bf4e64d4ad7632b8c4b633747d6b5600c76b","user":{"login":"georgedorn","id":239067,"avatar_url":"https://0.gravatar.com/avatar/8d382401a5b19fcd6908d64765a90fd2?d=https%3A%2F%2Fidenticons.github.com%2F8f46a8a62849eef86dd9dce27f918180.png","gravatar_id":"8d382401a5b19fcd6908d64765a90fd2","url":"https://api.github.com/users/georgedorn","html_url":"https://github.com/georgedorn","followers_url":"https://api.github.com/users/georgedorn/followers","following_url":"https://api.github.com/users/georgedorn/following{/other_user}","gists_url":"https://api.github.com/users/georgedorn/gists{/gist_id}","starred_url":"https://api.github.com/users/georgedorn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/georgedorn/subscriptions","organizations_url":"https://api.github.com/users/georgedorn/orgs","repos_url":"https://api.github.com/users/georgedorn/repos","events_url":"https://api.github.com/users/georgedorn/events{/privacy}","received_events_url":"https://api.github.com/users/georgedorn/received_events","type":"User","site_admin":false},"body":"Added trans/blocktrans for english bits.","created_at":"2013-10-22T01:26:08Z","updated_at":"2013-10-22T01:26:08Z","html_url":"https://github.com/gordon-morehouse/share2grandma/pull/22#discussion_r7114275","pull_request_url":"https://api.github.com/repos/gordon-morehouse/share2grandma/pulls/22","_links":{"self":{"href":"https://api.github.com/repos/gordon-morehouse/share2grandma/pulls/comments/7114275"},"html":{"href":"https://github.com/gordon-morehouse/share2grandma/pull/22#discussion_r7114275"},"pull_request":{"href":"https://api.github.com/repos/gordon-morehouse/share2grandma/pulls/22"}}}} | {
"id": 9226141,
"name": "share2grandma",
"url": "https://github.com/gordon-morehouse/share2grandma"
} | {
"id": null,
"login": "georgedorn",
"gravatar_id": "8d382401a5b19fcd6908d64765a90fd2",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-10-22T01:26:08 | null | {"repository":{"description":"share2grandma is a web application designed to make it easy to share photos, web pages, blogs and more to family and friends who don't use a computer. And with share2grandma, they don't need a computer. http://www.share2grandma.com/","homepage":"","watchers":2,"stargazers":2,"forks":1,"fork":false,"size":1101,"owner":"gordon-morehouse","private":false,"open_issues":2,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Python","created_at":"2013-04-04T12:29:31-07:00","pushed_at":"2013-10-21T18:25:25-07:00","master_branch":"master"},"actor_attributes":{"type":"User","name":"George Dorn","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/gordon-morehouse/share2grandma/pull/22#discussion_r7114275"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/vkaravir/a-plus/pulls/comments/3027796","id":3027796,"body":"Not exactly related to this line, but would it be possible to add docstrings to the model classes in this file. This should ease understanding the roles of various models and renderers included here. ","path":"apps/models.py","position":14,"original_position":14,"commit_id":"08258128a1c4b36735d751770c4f2a8c8c43b3ba","original_commit_id":"08258128a1c4b36735d751770c4f2a8c8c43b3ba","user":{"login":"ihantola","id":157458,"avatar_url":"https://secure.gravatar.com/avatar/27cdf3e2bf55d526ba003de55a6fd663?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"27cdf3e2bf55d526ba003de55a6fd663","url":"https://api.github.com/users/ihantola","followers_url":"https://api.github.com/users/ihantola/followers","following_url":"https://api.github.com/users/ihantola/following","gists_url":"https://api.github.com/users/ihantola/gists{/gist_id}","starred_url":"https://api.github.com/users/ihantola/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ihantola/subscriptions","organizations_url":"https://api.github.com/users/ihantola/orgs","repos_url":"https://api.github.com/users/ihantola/repos","events_url":"https://api.github.com/users/ihantola/events{/privacy}","received_events_url":"https://api.github.com/users/ihantola/received_events","type":"User"},"created_at":"2013-02-15T12:17:56Z","updated_at":"2013-02-15T12:17:56Z","_links":{"self":{"href":"https://api.github.com/repos/vkaravir/a-plus/pulls/comments/3027796"},"html":{"href":"https://github.com/vkaravir/a-plus/pull/88#discussion_r3027796"},"pull_request":{"href":"https://api.github.com/repos/vkaravir/a-plus/pulls/88"}}}} | {
"id": 5931298,
"name": "a-plus",
"url": "https://github.com/vkaravir/a-plus"
} | {
"id": null,
"login": "ihantola",
"gravatar_id": "27cdf3e2bf55d526ba003de55a6fd663",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-02-15T12:17:56 | null | {"repository":{"description":"","watchers":0,"stargazers":0,"forks":6,"fork":false,"size":396,"owner":"vkaravir","private":false,"open_issues":31,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Python","created_at":"2012-09-24T00:42:30-07:00","pushed_at":"2013-02-15T00:55:21-08:00","master_branch":"master"},"actor_attributes":{"name":"Petri Ihantola","type":"User","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/vkaravir/a-plus/pull/88#discussion_r3027796"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/RWOverdijk/AssetManager/pulls/comments/3784447","id":3784447,"body":"No need for this check","diff_hunk":"@@ -149,4 +149,29 @@ public function testResolveAssetSuccess()\n $this->assertEquals($mimetype, $asset->mimetype);\n $this->assertEquals($asset->dump(), file_get_contents(__FILE__));\n }\n+\n+ public function testResolveHttpAssetSuccess()\n+ {\n+ $resolver = new MapResolver;\n+\n+ $this->assertTrue($resolver instanceof MimeResolverAwareInterface);","path":"tests/AssetManagerTest/Resolver/MapResolverTest.php","position":9,"original_position":9,"commit_id":"c5453d63e936d6d6a6dd47443200c47e62150d8c","original_commit_id":"c5453d63e936d6d6a6dd47443200c47e62150d8c","user":{"login":"Ocramius","id":154256,"avatar_url":"https://secure.gravatar.com/avatar/3cf7a8ab0bccee5b65d39b50a170a555?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"3cf7a8ab0bccee5b65d39b50a170a555","url":"https://api.github.com/users/Ocramius","html_url":"https://github.com/Ocramius","followers_url":"https://api.github.com/users/Ocramius/followers","following_url":"https://api.github.com/users/Ocramius/following","gists_url":"https://api.github.com/users/Ocramius/gists{/gist_id}","starred_url":"https://api.github.com/users/Ocramius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ocramius/subscriptions","organizations_url":"https://api.github.com/users/Ocramius/orgs","repos_url":"https://api.github.com/users/Ocramius/repos","events_url":"https://api.github.com/users/Ocramius/events{/privacy}","received_events_url":"https://api.github.com/users/Ocramius/received_events","type":"User"},"created_at":"2013-04-13T19:53:35Z","updated_at":"2013-04-13T19:53:35Z","html_url":"https://github.com/RWOverdijk/AssetManager/pull/88#discussion_r3784447","pull_request_url":"https://api.github.com/repos/RWOverdijk/AssetManager/pulls/88","_links":{"self":{"href":"https://api.github.com/repos/RWOverdijk/AssetManager/pulls/comments/3784447"},"html":{"href":"https://github.com/RWOverdijk/AssetManager/pull/88#discussion_r3784447"},"pull_request":{"href":"https://api.github.com/repos/RWOverdijk/AssetManager/pulls/88"}}}} | {
"id": 5399788,
"name": "AssetManager",
"url": "https://github.com/RWOverdijk/AssetManager"
} | {
"id": null,
"login": "Ocramius",
"gravatar_id": "3cf7a8ab0bccee5b65d39b50a170a555",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-04-13T19:53:35 | null | {"repository":{"description":"AssetManager written for zf2. Managing assets for zend framework 2","homepage":"","watchers":65,"stargazers":65,"forks":19,"fork":false,"size":356,"owner":"RWOverdijk","private":false,"open_issues":6,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"PHP","created_at":"2012-08-13T07:12:13-07:00","pushed_at":"2013-03-14T11:13:20-07:00","master_branch":"master"},"actor_attributes":{"type":"User","name":"Marco Pivetta","company":"Com2-Gmbh","blog":"http://ocramius.github.com/","location":"Germany","email":"[email protected]"},"url":"https://github.com/RWOverdijk/AssetManager/pull/88#discussion_r3784447"} |
PullRequestReviewCommentEvent | true | {"comment":{"path":"src/SlmQueue/Queue/QueueInterface.php","commit_id":"92fc63f90bbdcfc1c9e9cfac974b2ed36b94cc51","body":"Ok I'm going to change to add an array options to push (and delete and pop ?). But I'll keep the metadata things, because SQS has some information more than id (like receiptHandle).","position":27,"_links":{"html":{"href":"https://github.com/juriansluiman/SlmQueue/pull/7#discussion_r2940925"},"pull_request":{"href":"https://api.github.com/repos/juriansluiman/SlmQueue/pulls/7"},"self":{"href":"https://api.github.com/repos/juriansluiman/SlmQueue/pulls/comments/2940925"}},"url":"https://api.github.com/repos/juriansluiman/SlmQueue/pulls/comments/2940925","id":2940925,"original_position":31,"created_at":"2013-02-08T10:51:11Z","updated_at":"2013-02-08T10:51:11Z","user":{"events_url":"https://api.github.com/users/bakura10/events{/privacy}","following_url":"https://api.github.com/users/bakura10/following","subscriptions_url":"https://api.github.com/users/bakura10/subscriptions","gists_url":"https://api.github.com/users/bakura10/gists{/gist_id}","gravatar_id":"2c3202718f850e5822f31a72b904668e","starred_url":"https://api.github.com/users/bakura10/starred{/owner}{/repo}","received_events_url":"https://api.github.com/users/bakura10/received_events","url":"https://api.github.com/users/bakura10","id":1198915,"avatar_url":"https://secure.gravatar.com/avatar/2c3202718f850e5822f31a72b904668e?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","organizations_url":"https://api.github.com/users/bakura10/orgs","followers_url":"https://api.github.com/users/bakura10/followers","repos_url":"https://api.github.com/users/bakura10/repos","type":"User","login":"bakura10"},"original_commit_id":"d22c9e6878241441988d3e38a7bacd25ada7ce6e"}} | {
"id": 3900903,
"name": "SlmQueue",
"url": "https://github.com/juriansluiman/SlmQueue"
} | {
"id": null,
"login": "bakura10",
"gravatar_id": "2c3202718f850e5822f31a72b904668e",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-02-08T10:51:11 | null | {"repository":{"forks":2,"has_downloads":true,"homepage":"","owner":"juriansluiman","created_at":"2012-04-02T06:33:29-07:00","description":"Zend Framework 2 integration of job queue management with Beanstalk","open_issues":1,"has_issues":true,"has_wiki":true,"language":"PHP","fork":false,"size":160,"watchers":6,"private":false,"stargazers":6,"pushed_at":"2013-02-04T13:27:20-08:00"},"actor_attributes":{"location":"Paris, France","name":"Michaël Gallego","type":"User","blog":"http://www.michaelgallego.fr","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/juriansluiman/SlmQueue/pull/7#discussion_r2940925"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/joshpc/testasaurus-server/pulls/comments/6091155","id":6091155,"body":"Are these ever going to be shown on the web? can probably drop the :html","diff_hunk":"@@ -0,0 +1,62 @@\n+class TestRunCaseCommentController < ApplicationController\n+\trespond_to :json, :html","path":"app/controllers/test_run_case_comment_controller.rb","position":2,"original_position":2,"commit_id":"cc5426ede08b17f54c927e45b9fb0a7e57c866ce","original_commit_id":"cc5426ede08b17f54c927e45b9fb0a7e57c866ce","user":{"login":"j-mutter","id":1273044,"avatar_url":"https://0.gravatar.com/avatar/d3d4a2eae53de90b54762ecbf065a944?d=https%3A%2F%2Fidenticons.github.com%2F1a3f56d4c61b60d15d155d3e26f65d95.png","gravatar_id":"d3d4a2eae53de90b54762ecbf065a944","url":"https://api.github.com/users/j-mutter","html_url":"https://github.com/j-mutter","followers_url":"https://api.github.com/users/j-mutter/followers","following_url":"https://api.github.com/users/j-mutter/following{/other_user}","gists_url":"https://api.github.com/users/j-mutter/gists{/gist_id}","starred_url":"https://api.github.com/users/j-mutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/j-mutter/subscriptions","organizations_url":"https://api.github.com/users/j-mutter/orgs","repos_url":"https://api.github.com/users/j-mutter/repos","events_url":"https://api.github.com/users/j-mutter/events{/privacy}","received_events_url":"https://api.github.com/users/j-mutter/received_events","type":"User"},"created_at":"2013-08-30T17:10:57Z","updated_at":"2013-08-30T17:10:57Z","html_url":"https://github.com/joshpc/testasaurus-server/pull/13#discussion_r6091155","pull_request_url":"https://api.github.com/repos/joshpc/testasaurus-server/pulls/13","_links":{"self":{"href":"https://api.github.com/repos/joshpc/testasaurus-server/pulls/comments/6091155"},"html":{"href":"https://github.com/joshpc/testasaurus-server/pull/13#discussion_r6091155"},"pull_request":{"href":"https://api.github.com/repos/joshpc/testasaurus-server/pulls/13"}}}} | {
"id": 6819585,
"name": "testasaurus-server",
"url": "https://github.com/joshpc/testasaurus-server"
} | {
"id": null,
"login": "j-mutter",
"gravatar_id": "d3d4a2eae53de90b54762ecbf065a944",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-08-30T17:10:57 | null | {"repository":{"description":"Server for the Testasaurus Rex project, a simple test-case management tool.","watchers":1,"stargazers":1,"forks":0,"fork":false,"size":1452,"owner":"joshpc","private":false,"open_issues":2,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Ruby","created_at":"2012-11-22T14:13:37-08:00","pushed_at":"2013-08-29T18:45:20-07:00","master_branch":"master"},"actor_attributes":{"type":"User","name":"Justin Mutter","company":"Shopify","location":"Ottawa, Canada","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/joshpc/testasaurus-server/pull/13#discussion_r6091155"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/hrydgard/ppsspp/pulls/comments/6137040","id":6137040,"body":"I get what this function does but it deserves a descriptive comment, I think.","diff_hunk":"@@ -0,0 +1,188 @@\n+// Copyright (c) 2012- PPSSPP Project.\n+\n+// This program is free software: you can redistribute it and/or modify\n+// it under the terms of the GNU General Public License as published by\n+// the Free Software Foundation, version 2.0 or later versions.\n+\n+// This program is distributed in the hope that it will be useful,\n+// but WITHOUT ANY WARRANTY; without even the implied warranty of\n+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the\n+// GNU General Public License 2.0 for more details.\n+\n+// A copy of the GPL 2.0 should have been included with the program.\n+// If not, see http://www.gnu.org/licenses/\n+\n+// Official git repository and contact information can be found at\n+// https://github.com/hrydgard/ppsspp and http://www.ppsspp.org/.\n+\n+#pragma once\n+\n+#include <vector>\n+#include <map>\n+#include <algorithm>\n+#include \"Core/HLE/sceKernelThread.h\"\n+\n+namespace HLEKernel\n+{\n+\n+template <typename WaitInfoType, typename PauseType>","path":"Core/HLE/KernelWaitHelpers.h","position":28,"original_position":28,"commit_id":"4ac0f7a34529f800f13d9ca31dc62d43dd3bdcbd","original_commit_id":"4ac0f7a34529f800f13d9ca31dc62d43dd3bdcbd","user":{"login":"hrydgard","id":130929,"avatar_url":"https://1.gravatar.com/avatar/2d47f033439c83a9aa9a9212e8b93096?d=https%3A%2F%2Fidenticons.github.com%2Fe161de87087c9facb087f3c79d5fd9db.png","gravatar_id":"2d47f033439c83a9aa9a9212e8b93096","url":"https://api.github.com/users/hrydgard","html_url":"https://github.com/hrydgard","followers_url":"https://api.github.com/users/hrydgard/followers","following_url":"https://api.github.com/users/hrydgard/following{/other_user}","gists_url":"https://api.github.com/users/hrydgard/gists{/gist_id}","starred_url":"https://api.github.com/users/hrydgard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hrydgard/subscriptions","organizations_url":"https://api.github.com/users/hrydgard/orgs","repos_url":"https://api.github.com/users/hrydgard/repos","events_url":"https://api.github.com/users/hrydgard/events{/privacy}","received_events_url":"https://api.github.com/users/hrydgard/received_events","type":"User"},"created_at":"2013-09-03T20:30:58Z","updated_at":"2013-09-03T20:30:58Z","html_url":"https://github.com/hrydgard/ppsspp/pull/3583#discussion_r6137040","pull_request_url":"https://api.github.com/repos/hrydgard/ppsspp/pulls/3583","_links":{"self":{"href":"https://api.github.com/repos/hrydgard/ppsspp/pulls/comments/6137040"},"html":{"href":"https://github.com/hrydgard/ppsspp/pull/3583#discussion_r6137040"},"pull_request":{"href":"https://api.github.com/repos/hrydgard/ppsspp/pulls/3583"}}}} | {
"id": 6486826,
"name": "ppsspp",
"url": "https://github.com/hrydgard/ppsspp"
} | {
"id": null,
"login": "hrydgard",
"gravatar_id": "2d47f033439c83a9aa9a9212e8b93096",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-09-03T20:30:58 | null | {"repository":{"description":"A PSP emulator for Android, Windows, Mac, Linux and Blackberry 10, written in C++. Want to contribute? Join us in #ppsspp on EFnet (IRC) or just send pull requests / issues.","homepage":"http://www.ppsspp.org","watchers":673,"stargazers":673,"forks":367,"fork":false,"size":10316,"owner":"hrydgard","private":false,"open_issues":519,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"C++","created_at":"2012-11-01T01:41:48-07:00","pushed_at":"2013-09-03T13:25:56-07:00","master_branch":"master"},"actor_attributes":{"type":"User","name":"Henrik Rydgård","company":"","blog":"http://www.henrikrydgard.com/","location":"Stockholm, Sweden","email":"[email protected]"},"url":"https://github.com/hrydgard/ppsspp/pull/3583#discussion_r6137040"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/crazy2be/buildblast/pulls/comments/5917221","id":5917221,"body":"Why thank you.\r\n\r\nIt might get more complex as we make our time-sync smoother, but it's pretty simple for now.","diff_hunk":"@@ -0,0 +1,69 @@\n+function Clock(conn) {\n+\tvar self = this;\n+\n+\tvar curTime = 0;\n+\t// Only updated after you call .update(). This way, all\n+\t// things querying the time in a frame will get the\n+\t// same time.\n+\tself.time = function () {\n+\t\treturn curTime;\n+\t};\n+\n+\t// Actual client <-> server offset, according to most\n+\t// recent sync.\n+\tvar offset = 0;\n+\t// How much of the offset we've actually applied. We\n+\t// don't want to apply it all at once, because that will\n+\t// cause lots of jerk.\n+\tvar appliedOffset = 0;\n+\tvar prevNow = now();\n+\tself.update = function () {\n+\t\tvar curNow = now();\n+\t\tvar dt = curNow - prevNow;\n+\t\tvar doff = offset - appliedOffset;\n+\t\tappliedOffset += min(abs(dt*0.5), abs(doff)) * signum(doff);\n+\n+\t\tcurTime = appliedOffset + curNow;\n+\t\tprevNow = curNow;\n+\t};\n+\n+\tfunction signum(n) {\n+\t\tif (n > 0) return 1;\n+\t\telse if (n < 0) return -1;\n+\t\telse return 0;\n+\t}\n+\n+\tself.init = function (serverTime) {\n+\t\toffset = calcOffset(clientTime, serverTime, serverTime, now());\n+\t\t// We want to apply the initial offset right away\n+\t\tappliedOffset = offset;\n+\t\tconn.on('ntp-sync', proccessSync);\n+\t\tstartSync();\n+\t}\n+\n+\tvar clientTime = now();\n+\tfunction startSync() {\n+\t\tclientTime = now();\n+\t\tconn.queue('ntp-sync', {});\n+\t}\n+\n+\t// http://en.wikipedia.org/wiki/Network_Time_Protocol\n+\tfunction calcOffset(t0, t1, t2, t3) {\n+\t\tvar newOffset = ((t1 - t0) + (t2 - t3)) / 2;\n+\t\tconsole.log(\"Syncronized time with server. We were off by \", offset - newOffset, \"ms.\");\n+\t\tconsole.log(\"Round trip connection based ping is\", t3 - t0, \"ms\");\n+\t\treturn newOffset;\n+\t}\n+\n+\tfunction proccessSync(payload) {\n+\t\tvar serverTime = payload.ServerTime;\n+\t\toffset = calcOffset(clientTime, serverTime, serverTime, now());\n+\n+\t\t// Re-sync in 5 seconds\n+\t\tsetTimeout(startSync, 5000);\n+\t}\n+\n+\tfunction now() {\n+\t\treturn window.performance.now();\n+\t}\n+}","path":"client/js/clock.js","position":69,"original_position":69,"commit_id":"31a3bc0ee2cb211a90526abb680f0a12e2e40ba7","original_commit_id":"31a3bc0ee2cb211a90526abb680f0a12e2e40ba7","user":{"login":"crazy2be","id":667720,"avatar_url":"https://2.gravatar.com/avatar/7243fe3ca4a48e39ba83c10b5f412ec3?d=https%3A%2F%2Fidenticons.github.com%2F2a00f4643fdf98740b32ee8f4428d07d.png","gravatar_id":"7243fe3ca4a48e39ba83c10b5f412ec3","url":"https://api.github.com/users/crazy2be","html_url":"https://github.com/crazy2be","followers_url":"https://api.github.com/users/crazy2be/followers","following_url":"https://api.github.com/users/crazy2be/following{/other_user}","gists_url":"https://api.github.com/users/crazy2be/gists{/gist_id}","starred_url":"https://api.github.com/users/crazy2be/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crazy2be/subscriptions","organizations_url":"https://api.github.com/users/crazy2be/orgs","repos_url":"https://api.github.com/users/crazy2be/repos","events_url":"https://api.github.com/users/crazy2be/events{/privacy}","received_events_url":"https://api.github.com/users/crazy2be/received_events","type":"User"},"created_at":"2013-08-22T06:12:40Z","updated_at":"2013-08-22T06:12:40Z","html_url":"https://github.com/crazy2be/buildblast/pull/109#discussion_r5917221","pull_request_url":"https://api.github.com/repos/crazy2be/buildblast/pulls/109","_links":{"self":{"href":"https://api.github.com/repos/crazy2be/buildblast/pulls/comments/5917221"},"html":{"href":"https://github.com/crazy2be/buildblast/pull/109#discussion_r5917221"},"pull_request":{"href":"https://api.github.com/repos/crazy2be/buildblast/pulls/109"}}}} | {
"id": 7845874,
"name": "buildblast",
"url": "https://github.com/crazy2be/buildblast"
} | {
"id": null,
"login": "crazy2be",
"gravatar_id": "7243fe3ca4a48e39ba83c10b5f412ec3",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-08-22T06:12:40 | null | {"repository":{"description":"Build a base, shoot intruders","watchers":2,"stargazers":2,"forks":0,"fork":false,"size":18273,"owner":"crazy2be","private":false,"open_issues":19,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"JavaScript","created_at":"2013-01-26T16:24:56-08:00","pushed_at":"2013-08-21T21:01:24-07:00","master_branch":"master"},"actor_attributes":{"type":"User","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/crazy2be/buildblast/pull/109#discussion_r5917221"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/rs/zkfarmer/pulls/comments/6993539","id":6993539,"diff_hunk":"@@ -130,6 +133,27 @@ Usage for the `zkfarmer export` command:\n predicates separeted by commas (ex:\n enabled=0,replication_delay<10,!maintenance)\n \n+One-way Sync to Zookeeper\n+-------------------------\n+\n+`zkfarmer export` will copy export the configuration from zookeeper to the local filesystem while `zkfarmer join` will keep a znode in sync with a part of the local filesystem. In certain case, the bidirectional sync of `zkfarmer join` may be undesirable. In this case, you can use `zkfarmer import` which acts like `zkfarmer join` but does not react to remote changes. Only a local change will trigger a synchronisation to ZooKeeper. The most common use-case for this command is the use of `--common` flag.","path":"README.md","position":null,"original_position":28,"commit_id":"4b3144b93a32cfb7b98a126a8481ace1c3de7b97","original_commit_id":"63aca46ae6d38ea95abfc3b2273cec749c86d0b8","user":{"login":"vincentbernat","id":631446,"avatar_url":"https://2.gravatar.com/avatar/2c0bde3f5628f35390c42fe505b79da4?d=https%3A%2F%2Fidenticons.github.com%2Fe882a1e876ed3fa422304f4ef61609bf.png","gravatar_id":"2c0bde3f5628f35390c42fe505b79da4","url":"https://api.github.com/users/vincentbernat","html_url":"https://github.com/vincentbernat","followers_url":"https://api.github.com/users/vincentbernat/followers","following_url":"https://api.github.com/users/vincentbernat/following{/other_user}","gists_url":"https://api.github.com/users/vincentbernat/gists{/gist_id}","starred_url":"https://api.github.com/users/vincentbernat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vincentbernat/subscriptions","organizations_url":"https://api.github.com/users/vincentbernat/orgs","repos_url":"https://api.github.com/users/vincentbernat/repos","events_url":"https://api.github.com/users/vincentbernat/events{/privacy}","received_events_url":"https://api.github.com/users/vincentbernat/received_events","type":"User","site_admin":false},"body":"I picked copy.","created_at":"2013-10-16T06:59:43Z","updated_at":"2013-10-16T06:59:43Z","html_url":"https://github.com/rs/zkfarmer/pull/36#discussion_r6993539","pull_request_url":"https://api.github.com/repos/rs/zkfarmer/pulls/36","_links":{"self":{"href":"https://api.github.com/repos/rs/zkfarmer/pulls/comments/6993539"},"html":{"href":"https://github.com/rs/zkfarmer/pull/36#discussion_r6993539"},"pull_request":{"href":"https://api.github.com/repos/rs/zkfarmer/pulls/36"}}}} | {
"id": 3175676,
"name": "zkfarmer",
"url": "https://github.com/rs/zkfarmer"
} | {
"id": null,
"login": "vincentbernat",
"gravatar_id": "2c0bde3f5628f35390c42fe505b79da4",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-10-16T06:59:43 | null | {"repository":{"description":"ZkFarmer is a set of tools to easily manage distributed server farms using Apache ZooKeeper","homepage":"","watchers":38,"stargazers":38,"forks":8,"fork":false,"size":292,"owner":"rs","private":false,"open_issues":1,"has_issues":true,"has_downloads":true,"has_wiki":false,"language":"Python","created_at":"2012-01-13T17:09:15-08:00","pushed_at":"2013-10-04T12:18:59-07:00","master_branch":"master"},"actor_attributes":{"type":"User","name":"Vincent Bernat","company":"Dailymotion","blog":"http://vincent.bernat.im","location":"Paris","email":"[email protected]"},"url":"https://github.com/rs/zkfarmer/pull/36#discussion_r6993539"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/alexesba/tdd_agenda_app/pulls/comments/6441600","id":6441600,"body":"and where is the assertion on this? ","diff_hunk":"@@ -26,18 +26,17 @@\n \n it 'should creates a new agenda' do \n post :create, agenda: { first_name: 'Pepe', last_name: 'paramo', email: '[email protected]', phone_number: 3121155046 }\n- response.should redirect_to(agenda_index_path)\n- end\n \n+ expect(response).to be_success\n+ expect(response.status).to eq(200)\n+ end\n end\n \n context 'when fails' do \n \n- pending\n- # it 'should not create a new agenda contact' do \n- # post :create, agenda: {}\n- # response.shoul_be redirect_to(new_agenda_path)\n- # end\n+ it 'should not create a new agenda contact' do \n+ post :create, agenda: { first_name: ''}","path":"spec/controllers/agenda_controller_spec.rb","position":38,"original_position":38,"commit_id":"64f26cda71c393eec5a4eab0fa088d53c1588b9d","original_commit_id":"64f26cda71c393eec5a4eab0fa088d53c1588b9d","user":{"login":"alexesba","id":579793,"avatar_url":"https://0.gravatar.com/avatar/2c7d903d71d0d73f7668df5d6398c412?d=https%3A%2F%2Fidenticons.github.com%2F4597a8310c7434d86f47d46bfa67ec92.png","gravatar_id":"2c7d903d71d0d73f7668df5d6398c412","url":"https://api.github.com/users/alexesba","html_url":"https://github.com/alexesba","followers_url":"https://api.github.com/users/alexesba/followers","following_url":"https://api.github.com/users/alexesba/following{/other_user}","gists_url":"https://api.github.com/users/alexesba/gists{/gist_id}","starred_url":"https://api.github.com/users/alexesba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexesba/subscriptions","organizations_url":"https://api.github.com/users/alexesba/orgs","repos_url":"https://api.github.com/users/alexesba/repos","events_url":"https://api.github.com/users/alexesba/events{/privacy}","received_events_url":"https://api.github.com/users/alexesba/received_events","type":"User"},"created_at":"2013-09-18T18:16:38Z","updated_at":"2013-09-18T18:16:38Z","html_url":"https://github.com/alexesba/tdd_agenda_app/pull/1#discussion_r6441600","pull_request_url":"https://api.github.com/repos/alexesba/tdd_agenda_app/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/alexesba/tdd_agenda_app/pulls/comments/6441600"},"html":{"href":"https://github.com/alexesba/tdd_agenda_app/pull/1#discussion_r6441600"},"pull_request":{"href":"https://api.github.com/repos/alexesba/tdd_agenda_app/pulls/1"}}}} | {
"id": 12777656,
"name": "tdd_agenda_app",
"url": "https://github.com/alexesba/tdd_agenda_app"
} | {
"id": null,
"login": "alexesba",
"gravatar_id": "2c7d903d71d0d73f7668df5d6398c412",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-09-18T18:16:38 | null | {"repository":{"description":"","watchers":0,"stargazers":0,"forks":0,"fork":false,"size":128,"owner":"alexesba","private":false,"open_issues":1,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Ruby","created_at":"2013-09-12T00:28:13-07:00","pushed_at":"2013-09-17T14:53:25-07:00","master_branch":"master"},"actor_attributes":{"type":"User","name":"Alejandro Espinoza Bautista","company":"zaznova","blog":"www.zaznova.com","location":"colima","email":"[email protected]"},"url":"https://github.com/alexesba/tdd_agenda_app/pull/1#discussion_r6441600"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/chriso/klein.php/pulls/comments/4718452","id":4718452,"body":"This was in case I had to change one of the values, since its really an abstraction of the `dispatch()` method's behavior. I guess I don't need them for now, though. :P","diff_hunk":"@@ -643,6 +619,42 @@ protected function compileRoute($route)\n }\n \n /**\n+ * Handle a response callback\n+ *\n+ * This handles common exceptions and their output\n+ * to keep the \"dispatch()\" method DRY\n+ *\n+ * @param callable $callback\n+ * @param int $matched\n+ * @param int $methods_matched\n+ * @access protected\n+ * @return void\n+ */\n+ protected function handleResponseCallback(&$callback, &$matched, &$methods_matched)","path":"Klein/Klein.php","position":134,"original_position":134,"commit_id":"d9aaa9c690fff2ee149c07e19616fa7d74b8fb87","original_commit_id":"d9aaa9c690fff2ee149c07e19616fa7d74b8fb87","user":{"login":"Rican7","id":742384,"avatar_url":"https://secure.gravatar.com/avatar/b1f29baa850d1c75f17d33c4d24c4db6?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"b1f29baa850d1c75f17d33c4d24c4db6","url":"https://api.github.com/users/Rican7","html_url":"https://github.com/Rican7","followers_url":"https://api.github.com/users/Rican7/followers","following_url":"https://api.github.com/users/Rican7/following{/other_user}","gists_url":"https://api.github.com/users/Rican7/gists{/gist_id}","starred_url":"https://api.github.com/users/Rican7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rican7/subscriptions","organizations_url":"https://api.github.com/users/Rican7/orgs","repos_url":"https://api.github.com/users/Rican7/repos","events_url":"https://api.github.com/users/Rican7/events{/privacy}","received_events_url":"https://api.github.com/users/Rican7/received_events","type":"User"},"created_at":"2013-06-17T06:15:59Z","updated_at":"2013-06-17T06:15:59Z","html_url":"https://github.com/chriso/klein.php/pull/106#discussion_r4718452","pull_request_url":"https://api.github.com/repos/chriso/klein.php/pulls/106","_links":{"self":{"href":"https://api.github.com/repos/chriso/klein.php/pulls/comments/4718452"},"html":{"href":"https://github.com/chriso/klein.php/pull/106#discussion_r4718452"},"pull_request":{"href":"https://api.github.com/repos/chriso/klein.php/pulls/106"}}}} | {
"id": 1566536,
"name": "klein.php",
"url": "https://github.com/chriso/klein.php"
} | {
"id": null,
"login": "Rican7",
"gravatar_id": "b1f29baa850d1c75f17d33c4d24c4db6",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-06-17T06:15:59 | null | {"repository":{"description":"A lightning fast router for PHP","homepage":"http://chriso.github.io/klein.php/","watchers":727,"stargazers":727,"forks":78,"fork":false,"size":260,"owner":"chriso","private":false,"open_issues":4,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"PHP","created_at":"2011-04-04T03:47:14-07:00","pushed_at":"2013-06-16T16:45:46-07:00","master_branch":"master"},"actor_attributes":{"type":"User","name":"Trevor N. Suarez","company":"One Mighty Roar","blog":"http://blennd.com/","location":"Boston, MA","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/chriso/klein.php/pull/106#discussion_r4718452"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/mikel/mail/pulls/comments/5664553","id":5664553,"body":"Assumes that `value` is always a `String`, but it may be a `Mail::Body`","diff_hunk":"@@ -1134,6 +1134,7 @@ def default( sym, val = nil )\n # mail.parts.length #=> 2\n # mail.parts.last.content_type.content_type #=> 'This is a body'\n def body=(value)\n+ value = CharsetCodec.find(@charset).preprocess(value)","path":"lib/mail/message.rb","position":4,"original_position":4,"commit_id":"82881c1bc028d2e393299fd9d2b1b74ef5ec61d4","original_commit_id":"82881c1bc028d2e393299fd9d2b1b74ef5ec61d4","user":{"login":"jeremy","id":199,"avatar_url":"https://secure.gravatar.com/avatar/24d2f8804e6bb4b7ea6bd11e0a586470?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"24d2f8804e6bb4b7ea6bd11e0a586470","url":"https://api.github.com/users/jeremy","html_url":"https://github.com/jeremy","followers_url":"https://api.github.com/users/jeremy/followers","following_url":"https://api.github.com/users/jeremy/following{/other_user}","gists_url":"https://api.github.com/users/jeremy/gists{/gist_id}","starred_url":"https://api.github.com/users/jeremy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeremy/subscriptions","organizations_url":"https://api.github.com/users/jeremy/orgs","repos_url":"https://api.github.com/users/jeremy/repos","events_url":"https://api.github.com/users/jeremy/events{/privacy}","received_events_url":"https://api.github.com/users/jeremy/received_events","type":"User"},"created_at":"2013-08-08T17:48:47Z","updated_at":"2013-08-08T17:48:47Z","html_url":"https://github.com/mikel/mail/pull/595#discussion_r5664553","pull_request_url":"https://api.github.com/repos/mikel/mail/pulls/595","_links":{"self":{"href":"https://api.github.com/repos/mikel/mail/pulls/comments/5664553"},"html":{"href":"https://github.com/mikel/mail/pull/595#discussion_r5664553"},"pull_request":{"href":"https://api.github.com/repos/mikel/mail/pulls/595"}}}} | {
"id": 79352,
"name": "mail",
"url": "https://github.com/mikel/mail"
} | {
"id": null,
"login": "jeremy",
"gravatar_id": "24d2f8804e6bb4b7ea6bd11e0a586470",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-08-08T17:48:47 | null | {"repository":{"description":"A Really Ruby Mail Library","homepage":"","watchers":1508,"stargazers":1508,"forks":344,"fork":false,"size":6059,"owner":"mikel","private":false,"open_issues":2,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Ruby","created_at":"2008-11-21T19:16:54-08:00","pushed_at":"2013-07-26T03:59:23-07:00","master_branch":"master"},"actor_attributes":{"type":"User","name":"Jeremy Kemper","company":"37signals","blog":"http://bitsweat.net","location":"Tempe, AZ","email":"[email protected]"},"url":"https://github.com/mikel/mail/pull/595#discussion_r5664553"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/donnfelker/android-bootstrap/pulls/comments/7548714","id":7548714,"diff_hunk":"@@ -34,28 +34,30 @@ public int getCount() {\n }\n \n @Override\n- public Fragment getItem(int position) {\n- Bundle bundle = new Bundle();\n+ public Fragment getItem(final int position) {\n+ final Fragment result;\n switch (position) {\n case 0:\n- NewsListFragment newsFragment = new NewsListFragment();\n- newsFragment.setArguments(bundle);\n- return newsFragment;\n+ result = new NewsListFragment();\n+ break;\n case 1:\n- UserListFragment userListFragment = new UserListFragment();\n- userListFragment.setArguments(bundle);\n- return userListFragment;\n+ result = new UserListFragment();\n+ break;\n case 2:\n- CheckInsListFragment checkInsFragment = new CheckInsListFragment();\n- checkInsFragment.setArguments(bundle);\n- return checkInsFragment;\n+ result = new CheckInsListFragment();\n+ break;\n default:\n- return null;\n+ result = null;\n+ break;\n+ }\n+ if (result != null) {\n+ result.setArguments(new Bundle()); //TODO do we need this?","path":"app/src/main/java/com/donnfelker/android/bootstrap/ui/BootstrapPagerAdapter.java","position":42,"original_position":42,"commit_id":"e353a9ffb2829028815eb2d7d2368e3a535050bf","original_commit_id":"e353a9ffb2829028815eb2d7d2368e3a535050bf","user":{"login":"danielkutik","id":906457,"avatar_url":"https://1.gravatar.com/avatar/0872aa785535da245c1bf0ff4e413048?d=https%3A%2F%2Fidenticons.github.com%2F46acfecaa413e89e0d973e15d4ffff86.png&r=x","gravatar_id":"0872aa785535da245c1bf0ff4e413048","url":"https://api.github.com/users/danielkutik","html_url":"https://github.com/danielkutik","followers_url":"https://api.github.com/users/danielkutik/followers","following_url":"https://api.github.com/users/danielkutik/following{/other_user}","gists_url":"https://api.github.com/users/danielkutik/gists{/gist_id}","starred_url":"https://api.github.com/users/danielkutik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielkutik/subscriptions","organizations_url":"https://api.github.com/users/danielkutik/orgs","repos_url":"https://api.github.com/users/danielkutik/repos","events_url":"https://api.github.com/users/danielkutik/events{/privacy}","received_events_url":"https://api.github.com/users/danielkutik/received_events","type":"User","site_admin":false},"body":"See TODO: I'm not really getting why we put here an empty instance of `Bundle`","created_at":"2013-11-10T14:13:41Z","updated_at":"2013-11-10T14:13:41Z","html_url":"https://github.com/donnfelker/android-bootstrap/pull/69#discussion_r7548714","pull_request_url":"https://api.github.com/repos/donnfelker/android-bootstrap/pulls/69","_links":{"self":{"href":"https://api.github.com/repos/donnfelker/android-bootstrap/pulls/comments/7548714"},"html":{"href":"https://github.com/donnfelker/android-bootstrap/pull/69#discussion_r7548714"},"pull_request":{"href":"https://api.github.com/repos/donnfelker/android-bootstrap/pulls/69"}}}} | {
"id": 5689093,
"name": "android-bootstrap",
"url": "https://github.com/donnfelker/android-bootstrap"
} | {
"id": null,
"login": "danielkutik",
"gravatar_id": "0872aa785535da245c1bf0ff4e413048",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-11-10T14:13:41 | null | {"repository":{"description":"A template/bootstrap/boilerplate application that includes tons of great open source tools and frameworks. ","watchers":1740,"stargazers":1740,"forks":491,"fork":false,"size":1933,"owner":"donnfelker","private":false,"open_issues":23,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Java","created_at":"2012-09-05T08:19:13-07:00","pushed_at":"2013-11-09T12:36:54-08:00","master_branch":"master"},"actor_attributes":{"type":"User","name":"Daniel Kutik","blog":"https://twitter.com/danielkutik/","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/donnfelker/android-bootstrap/pull/69#discussion_r7548714"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/macnibblet/MCNElasticSearch/pulls/comments/6229039","id":6229039,"body":"","diff_hunk":"@@ -0,0 +1,103 @@\n+<?php\n+/**\n+ * @author Antoine Hedgecock <[email protected]>\n+ *\n+ * @copyright PMG Media Group AB\n+ */\n+\n+namespace MCNElasticSearch\\Service;\n+use Elastica\\Client;\n+use Elastica\\Type\\Mapping;\n+use Elastica\\Type;\n+use MCNElasticSearch\\Options\\TypeMappingOptions;\n+use Zend\\EventManager\\EventManagerAwareTrait;\n+use Zend\\EventManager\\EventManagerInterface;\n+use Zend\\Log\\Logger;\n+use Zend\\Stdlib\\Hydrator\\ClassMethods;\n+\n+/**\n+ * Class MappingService\n+ */\n+class MappingService implements MappingServiceInterface\n+{\n+ use EventManagerAwareTrait;\n+\n+ /**\n+ * @var \\Elastica\\Client\n+ */\n+ protected $client;\n+\n+ /**\n+ * @var MetadataService\n+ */\n+ protected $metadata;\n+\n+ /**\n+ * @param \\Elastica\\Client $client\n+ * @param MetadataService $metadata\n+ */\n+ public function __construct(Client $client, MetadataService $metadata)\n+ {\n+ $this->client = $client;\n+ $this->metadata = $metadata;\n+ }\n+\n+ public function build(array $types = [])\n+ {\n+ $mappings = $this->metadata->getAllTypeMappings();\n+\n+ if ($types !== null) {\n+ array_filter($mappings, function(TypeMappingOptions $t) use ($types) {\n+ return in_array($t->getName(), $types);\n+ });\n+ }\n+\n+ $hydrator = new ClassMethods();\n+\n+ /** @var $options \\MCNElasticSearch\\Options\\TypeMappingOptions */\n+ foreach ($mappings as $options) {\n+\n+ $type = $this->client->getIndex($options->getIndex())\n+ ->getType($options->getName());\n+\n+ $mapping = new Mapping($type);\n+ $hydrator->hydrate($options->toArray(), $mapping);\n+\n+ $response = $mapping->send();\n+ if (! $response->isOk()) {\n+ $this->getEventManager()->trigger(__FUNCTION__ . '.error', $this, [ 'response' => $response ]);\n+ throw new Exception\\RuntimeException(\n+ sprintf(\n+ 'Error updating \"%s\" mapping: %s', $options->getName(), $response->getError()\n+ )\n+ );\n+ }\n+ }\n+ }\n+\n+ public function delete(array $types = [])\n+ {\n+ $mappings = $this->metadata->getAllTypeMappings();\n+\n+ if ($types !== null) {\n+ array_filter($mappings, function(TypeMappingOptions $t) use ($types) {\n+ return in_array($t->getName(), $types);\n+ });\n+ }\n+\n+ foreach ($mappings as $options) {\n+\n+ // Delete the type","path":"src/MCNElasticSearch/Service/MappingService.php","position":90,"original_position":90,"commit_id":"ae9ee6c33303c27616221dec33853d2f25cab321","original_commit_id":"ae9ee6c33303c27616221dec33853d2f25cab321","user":{"login":"Ocramius","id":154256,"avatar_url":"https://1.gravatar.com/avatar/3cf7a8ab0bccee5b65d39b50a170a555?d=https%3A%2F%2Fidenticons.github.com%2F4f1c4fba7ee1878fdf1dbafb8164a229.png","gravatar_id":"3cf7a8ab0bccee5b65d39b50a170a555","url":"https://api.github.com/users/Ocramius","html_url":"https://github.com/Ocramius","followers_url":"https://api.github.com/users/Ocramius/followers","following_url":"https://api.github.com/users/Ocramius/following{/other_user}","gists_url":"https://api.github.com/users/Ocramius/gists{/gist_id}","starred_url":"https://api.github.com/users/Ocramius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ocramius/subscriptions","organizations_url":"https://api.github.com/users/Ocramius/orgs","repos_url":"https://api.github.com/users/Ocramius/repos","events_url":"https://api.github.com/users/Ocramius/events{/privacy}","received_events_url":"https://api.github.com/users/Ocramius/received_events","type":"User"},"created_at":"2013-09-08T22:45:08Z","updated_at":"2013-09-08T22:45:08Z","html_url":"https://github.com/macnibblet/MCNElasticSearch/pull/1#discussion_r6229039","pull_request_url":"https://api.github.com/repos/macnibblet/MCNElasticSearch/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/macnibblet/MCNElasticSearch/pulls/comments/6229039"},"html":{"href":"https://github.com/macnibblet/MCNElasticSearch/pull/1#discussion_r6229039"},"pull_request":{"href":"https://api.github.com/repos/macnibblet/MCNElasticSearch/pulls/1"}}}} | {
"id": 12670984,
"name": "MCNElasticSearch",
"url": "https://github.com/macnibblet/MCNElasticSearch"
} | {
"id": null,
"login": "Ocramius",
"gravatar_id": "3cf7a8ab0bccee5b65d39b50a170a555",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-09-08T22:45:08 | null | {"repository":{"description":"","watchers":2,"stargazers":2,"forks":0,"fork":false,"size":216,"owner":"macnibblet","private":false,"open_issues":1,"has_issues":true,"has_downloads":true,"has_wiki":true,"created_at":"2013-09-07T13:22:06-07:00","pushed_at":"2013-09-08T06:29:28-07:00","master_branch":"master"},"actor_attributes":{"type":"User","name":"Marco Pivetta","company":"","blog":"http://ocramius.github.io/","location":"Germany","email":"[email protected]"},"url":"https://github.com/macnibblet/MCNElasticSearch/pull/1#discussion_r6229039"} |
PullRequestReviewCommentEvent | true | {"comment":{"path":"EventListener/RequestListener.php","user":{"organizations_url":"https://api.github.com/users/suncat2000/orgs","received_events_url":"https://api.github.com/users/suncat2000/received_events","url":"https://api.github.com/users/suncat2000","subscriptions_url":"https://api.github.com/users/suncat2000/subscriptions","followers_url":"https://api.github.com/users/suncat2000/followers","type":"User","id":1162437,"gravatar_id":"a28e09bc0165a7c79d7b1fa1abda0f04","repos_url":"https://api.github.com/users/suncat2000/repos","gists_url":"https://api.github.com/users/suncat2000/gists{/gist_id}","following_url":"https://api.github.com/users/suncat2000/following","starred_url":"https://api.github.com/users/suncat2000/starred{/owner}{/repo}","avatar_url":"https://secure.gravatar.com/avatar/a28e09bc0165a7c79d7b1fa1abda0f04?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","events_url":"https://api.github.com/users/suncat2000/events{/privacy}","login":"suncat2000"},"commit_id":"4ed126b700d486ef0bf7bcf37f450c213a8bd98d","original_commit_id":"4ed126b700d486ef0bf7bcf37f450c213a8bd98d","position":43,"_links":{"html":{"href":"https://github.com/suncat2000/MobileDetectBundle/pull/17#discussion_r2877117"},"self":{"href":"https://api.github.com/repos/suncat2000/MobileDetectBundle/pulls/comments/2877117"},"pull_request":{"href":"https://api.github.com/repos/suncat2000/MobileDetectBundle/pulls/17"}},"url":"https://api.github.com/repos/suncat2000/MobileDetectBundle/pulls/comments/2877117","id":2877117,"body":"This comment refers to the line:\r\n\r\n`$this->needModifyResponse = true;`\r\n\r\nProbably better to write it:\r\n\r\n```\r\n /**\r\n * If not need redirecting\r\n */\r\n\r\n // Sets the flag for the response handle\r\n $this->needModifyResponse = true;\r\n\r\n // Checking the need to modify the Response and set closure\r\n if ($this->needTabletResponseModify()) {\r\n $this->deviceView->setTabletView();\r\n\r\n return;\r\n }\r\n```\r\nor something like that.\r\n\r\nThanks for help and sorry for my English!","created_at":"2013-02-04T15:08:02Z","updated_at":"2013-02-04T15:08:02Z","original_position":43}} | {
"id": 4434616,
"name": "MobileDetectBundle",
"url": "https://github.com/suncat2000/MobileDetectBundle"
} | {
"id": null,
"login": "suncat2000",
"gravatar_id": "a28e09bc0165a7c79d7b1fa1abda0f04",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-02-04T15:08:02 | null | {"repository":{"forks":7,"owner":"suncat2000","has_downloads":true,"open_issues":3,"homepage":"","has_wiki":false,"watchers":40,"created_at":"2012-05-24T08:44:55-07:00","fork":false,"size":176,"description":"Symfony2 bundle for detect mobile devices, manage mobile view and redirect to the mobile and tablet version.","stargazers":40,"private":false,"language":"PHP","has_issues":true,"pushed_at":"2013-02-04T04:25:18-08:00"},"actor_attributes":{"name":"Nick","type":"User","location":"Moscow","blog":"","company":"","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/suncat2000/MobileDetectBundle/pull/17#discussion_r2877117"} |
PullRequestReviewCommentEvent | true | {"comment":{"original_commit_id":"e1e66cd2c1f2102c11adb5e15550b17da9a724ab","user":{"events_url":"https://api.github.com/users/ksteph/events{/privacy}","url":"https://api.github.com/users/ksteph","type":"User","followers_url":"https://api.github.com/users/ksteph/followers","starred_url":"https://api.github.com/users/ksteph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ksteph/subscriptions","id":656060,"following_url":"https://api.github.com/users/ksteph/following","gists_url":"https://api.github.com/users/ksteph/gists{/gist_id}","login":"ksteph","avatar_url":"https://secure.gravatar.com/avatar/db33bfeeed3470c436636cf0dcbe58b2?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","organizations_url":"https://api.github.com/users/ksteph/orgs","gravatar_id":"db33bfeeed3470c436636cf0dcbe58b2","repos_url":"https://api.github.com/users/ksteph/repos","received_events_url":"https://api.github.com/users/ksteph/received_events"},"url":"https://api.github.com/repos/ksteph/KnowMap/pulls/comments/2821158","original_position":158,"position":158,"id":2821158,"_links":{"html":{"href":"https://github.com/ksteph/KnowMap/pull/54#discussion_r2821158"},"pull_request":{"href":"https://api.github.com/repos/ksteph/KnowMap/pulls/54"},"self":{"href":"https://api.github.com/repos/ksteph/KnowMap/pulls/comments/2821158"}},"body":"This is a map from the nodes ID to the node's data. It is used in a bunch of places, just search for where it appears in the code.","commit_id":"e1e66cd2c1f2102c11adb5e15550b17da9a724ab","created_at":"2013-01-30T04:08:12Z","updated_at":"2013-01-30T04:08:12Z","path":"app/assets/javascripts/map.js"}} | {
"id": 4628743,
"name": "KnowMap",
"url": "https://github.com/ksteph/KnowMap"
} | {
"id": null,
"login": "ksteph",
"gravatar_id": "db33bfeeed3470c436636cf0dcbe58b2",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-01-30T04:08:12 | null | {"repository":{"description":"Knowledge Map interface for research on displaying knowledge in a graphical map format.","pushed_at":"2012-12-17T20:52:27-08:00","forks":2,"owner":"ksteph","language":"JavaScript","watchers":3,"has_wiki":true,"stargazers":3,"open_issues":13,"fork":false,"size":388,"homepage":"","private":false,"created_at":"2012-06-11T11:44:04-07:00","has_issues":true,"has_downloads":true,"master_branch":"perlin_issue"},"actor_attributes":{"type":"User","name":"Kristin","blog":"www.cs.berkeley.edu/~ksteph","company":"UC Berkeley","email":"[email protected]"},"url":"https://github.com/ksteph/KnowMap/pull/54#discussion_r2821158"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/ebryn/ember-model/pulls/comments/5403542","id":5403542,"body":"nit: Indent level.","diff_hunk":"@@ -441,7 +441,15 @@ Ember.Model.reopenClass({\n },\n \n _findFetchAll: function(isFetch) {\n- if (this._findAllRecordArray) { return this._findAllRecordArray; }\n+ if (this._findAllRecordArray) { \n+ if( isFetch) {\n+ return new Ember.RSVP.Promise(function(resolve) {\n+ resolve(this._findAllRecordArray);\n+ });\n+ } else {\n+ return this._findAllRecordArray;","path":"packages/ember-model/lib/model.js","position":11,"original_position":11,"commit_id":"cb0dcb2d3dbd8ec4b9a2c6adf4fdab7fcb098407","original_commit_id":"cb0dcb2d3dbd8ec4b9a2c6adf4fdab7fcb098407","user":{"login":"eventualbuddha","id":1938,"avatar_url":"https://secure.gravatar.com/avatar/2fa6f8598d6acd60c3729791651a6336?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"2fa6f8598d6acd60c3729791651a6336","url":"https://api.github.com/users/eventualbuddha","html_url":"https://github.com/eventualbuddha","followers_url":"https://api.github.com/users/eventualbuddha/followers","following_url":"https://api.github.com/users/eventualbuddha/following{/other_user}","gists_url":"https://api.github.com/users/eventualbuddha/gists{/gist_id}","starred_url":"https://api.github.com/users/eventualbuddha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eventualbuddha/subscriptions","organizations_url":"https://api.github.com/users/eventualbuddha/orgs","repos_url":"https://api.github.com/users/eventualbuddha/repos","events_url":"https://api.github.com/users/eventualbuddha/events{/privacy}","received_events_url":"https://api.github.com/users/eventualbuddha/received_events","type":"User"},"created_at":"2013-07-25T17:13:17Z","updated_at":"2013-07-25T17:13:17Z","html_url":"https://github.com/ebryn/ember-model/pull/176#discussion_r5403542","pull_request_url":"https://api.github.com/repos/ebryn/ember-model/pulls/176","_links":{"self":{"href":"https://api.github.com/repos/ebryn/ember-model/pulls/comments/5403542"},"html":{"href":"https://github.com/ebryn/ember-model/pull/176#discussion_r5403542"},"pull_request":{"href":"https://api.github.com/repos/ebryn/ember-model/pulls/176"}}}} | {
"id": 8831394,
"name": "ember-model",
"url": "https://github.com/ebryn/ember-model"
} | {
"id": null,
"login": "eventualbuddha",
"gravatar_id": "2fa6f8598d6acd60c3729791651a6336",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-07-25T17:13:17 | null | {"repository":{"description":"A lightweight model library for Ember.js","homepage":"","watchers":188,"stargazers":188,"forks":64,"fork":false,"size":1089,"owner":"ebryn","private":false,"open_issues":15,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"JavaScript","created_at":"2013-03-17T00:31:40-07:00","pushed_at":"2013-07-24T19:22:04-07:00","master_branch":"master"},"actor_attributes":{"type":"User","name":"Brian Donovan","company":"","blog":"http://brian-donovan.com/","location":"San Francisco","email":"[email protected]"},"url":"https://github.com/ebryn/ember-model/pull/176#discussion_r5403542"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/brandonblack/mongo-tools/pulls/comments/3091541","id":3091541,"body":"We'll need to change this up, but I'll throw that into a different task","path":"app/assets/javascripts/explorer.js","position":11,"original_position":11,"commit_id":"f6cd6d4923a6ac1b0cfd03adf297258ecab5dc7c","original_commit_id":"f6cd6d4923a6ac1b0cfd03adf297258ecab5dc7c","user":{"login":"drcapulet","id":50848,"avatar_url":"https://secure.gravatar.com/avatar/cdb89171751e2a84750e0317f5dc1a67?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"cdb89171751e2a84750e0317f5dc1a67","url":"https://api.github.com/users/drcapulet","html_url":"https://github.com/drcapulet","followers_url":"https://api.github.com/users/drcapulet/followers","following_url":"https://api.github.com/users/drcapulet/following","gists_url":"https://api.github.com/users/drcapulet/gists{/gist_id}","starred_url":"https://api.github.com/users/drcapulet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drcapulet/subscriptions","organizations_url":"https://api.github.com/users/drcapulet/orgs","repos_url":"https://api.github.com/users/drcapulet/repos","events_url":"https://api.github.com/users/drcapulet/events{/privacy}","received_events_url":"https://api.github.com/users/drcapulet/received_events","type":"User"},"created_at":"2013-02-21T00:03:14Z","updated_at":"2013-02-21T00:03:14Z","_links":{"self":{"href":"https://api.github.com/repos/brandonblack/mongo-tools/pulls/comments/3091541"},"html":{"href":"https://github.com/brandonblack/mongo-tools/pull/44#discussion_r3091541"},"pull_request":{"href":"https://api.github.com/repos/brandonblack/mongo-tools/pulls/44"}}}} | {
"id": 7614054,
"name": "mongo-tools",
"url": "https://github.com/brandonblack/mongo-tools"
} | {
"id": null,
"login": "drcapulet",
"gravatar_id": "cdb89171751e2a84750e0317f5dc1a67",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-02-21T00:03:14 | null | {"repository":{"description":"A collection of helpful tools for using, monitoring and administrating MongoDB.","watchers":5,"stargazers":5,"forks":12,"fork":false,"size":236,"owner":"brandonblack","private":false,"open_issues":10,"has_issues":true,"has_downloads":true,"has_wiki":true,"created_at":"2013-01-14T14:34:42-08:00","pushed_at":"2013-02-16T21:15:57-08:00","master_branch":"master"},"actor_attributes":{"name":"Alex Coomans","blog":"alexcoomans.com","location":"Austin, TX","email":"[email protected]","type":"User"},"url":"https://github.com/brandonblack/mongo-tools/pull/44#discussion_r3091541"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/bem/bem-core/pulls/comments/5749484","id":5749484,"body":"в самом ядре не предоставляет, но с использованием его могут быть написаны блоки, которые будут предоставлять. хочется не сбить читателя с толку. может лучше вообще выкинуть эту фразу?","diff_hunk":"@@ -0,0 +1,1208 @@\n+<!--# i-bem.js: Руководство пользователя-->\n+\n+# Общие сведения #\n+\n+## i-bem.js: Клиентский Javascript-фреймворк для БЭМ ##\n+\n+i-bem.js — специализированный JavaScript-фреймворк для веб-разработки в рамках [БЭМ-методологии](http://ru.bem.info/method/). \n+С помощью i-bem.js можно:\n+\n+ * разрабатывать веб-интерфейс в терминах блоков, элементов, модификаторов;\n+ * описывать логику работы блока в декларативном стиле — как набор состояний;\n+ * легко интегрировать JavaScript-код с CSS в стиле БЭМ и BEMHTML-шаблонами;\n+ * гибко переопределять поведение библиотечных блоков.\n+\n+i-bem.js не может:\n+\n+ * работать с состоянием на сервере (только клиентский JavaScript);","path":"common.docs/i-bem.js/i-bem.js.ru.md","position":17,"original_position":17,"commit_id":"7735f57d78d583ad6c22328b31248dd540311fe3","original_commit_id":"081e139ac701fbc4640f77c0ee76989009720fbd","user":{"login":"tadatuta","id":475746,"avatar_url":"https://secure.gravatar.com/avatar/e04f76a31452c9d6974b03fe4c183b5d?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"e04f76a31452c9d6974b03fe4c183b5d","url":"https://api.github.com/users/tadatuta","html_url":"https://github.com/tadatuta","followers_url":"https://api.github.com/users/tadatuta/followers","following_url":"https://api.github.com/users/tadatuta/following{/other_user}","gists_url":"https://api.github.com/users/tadatuta/gists{/gist_id}","starred_url":"https://api.github.com/users/tadatuta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tadatuta/subscriptions","organizations_url":"https://api.github.com/users/tadatuta/orgs","repos_url":"https://api.github.com/users/tadatuta/repos","events_url":"https://api.github.com/users/tadatuta/events{/privacy}","received_events_url":"https://api.github.com/users/tadatuta/received_events","type":"User"},"created_at":"2013-08-13T21:22:37Z","updated_at":"2013-08-13T21:22:37Z","html_url":"https://github.com/bem/bem-core/pull/206#discussion_r5749484","pull_request_url":"https://api.github.com/repos/bem/bem-core/pulls/206","_links":{"self":{"href":"https://api.github.com/repos/bem/bem-core/pulls/comments/5749484"},"html":{"href":"https://github.com/bem/bem-core/pull/206#discussion_r5749484"},"pull_request":{"href":"https://api.github.com/repos/bem/bem-core/pulls/206"}}}} | {
"id": 8100172,
"name": "bem-core",
"url": "https://github.com/bem/bem-core"
} | {
"id": null,
"login": "tadatuta",
"gravatar_id": "e04f76a31452c9d6974b03fe4c183b5d",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "bem",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-08-13T21:22:37 | null | {"repository":{"description":"BEM Core Library — Work in progress, do not use in production","watchers":14,"stargazers":14,"forks":17,"fork":false,"size":1534,"owner":"bem","private":false,"open_issues":42,"has_issues":true,"has_downloads":true,"has_wiki":false,"language":"JavaScript","created_at":"2013-02-08T11:53:17-08:00","pushed_at":"2013-08-13T12:31:22-07:00","master_branch":"v1","organization":"bem"},"actor_attributes":{"type":"User","name":"Vladimir Grinenko","company":"Tadatuta","blog":"http://tadatuta.ru/","location":"Ukraine, Alushta","email":"[email protected]"},"url":"https://github.com/bem/bem-core/pull/206#discussion_r5749484"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/bem/project-stub/pulls/comments/4950626","id":4950626,"body":"@dfilatov Дима, я правильно понимаю, что все-таки есть смысл вставлять ``jquery`` в ДОМ заранее, т.к. тогда загрузка будет идти параллельно с бандловым js-файлом?","diff_hunk":"@@ -27,7 +27,6 @@\n 'footer content goes here'\n ]\n },\n- { block: 'i-jquery', mods: { version: '1.8.3' } },","path":"desktop.bundles/index/index.bemjson.js","position":11,"original_position":11,"commit_id":"241c2db810934645798b465da2b1a05bb556134d","original_commit_id":"241c2db810934645798b465da2b1a05bb556134d","user":{"login":"tadatuta","id":475746,"avatar_url":"https://secure.gravatar.com/avatar/e04f76a31452c9d6974b03fe4c183b5d?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"e04f76a31452c9d6974b03fe4c183b5d","url":"https://api.github.com/users/tadatuta","html_url":"https://github.com/tadatuta","followers_url":"https://api.github.com/users/tadatuta/followers","following_url":"https://api.github.com/users/tadatuta/following{/other_user}","gists_url":"https://api.github.com/users/tadatuta/gists{/gist_id}","starred_url":"https://api.github.com/users/tadatuta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tadatuta/subscriptions","organizations_url":"https://api.github.com/users/tadatuta/orgs","repos_url":"https://api.github.com/users/tadatuta/repos","events_url":"https://api.github.com/users/tadatuta/events{/privacy}","received_events_url":"https://api.github.com/users/tadatuta/received_events","type":"User"},"created_at":"2013-06-29T00:06:59Z","updated_at":"2013-06-29T00:06:59Z","html_url":"https://github.com/bem/project-stub/pull/13#discussion_r4950626","pull_request_url":"https://api.github.com/repos/bem/project-stub/pulls/13","_links":{"self":{"href":"https://api.github.com/repos/bem/project-stub/pulls/comments/4950626"},"html":{"href":"https://github.com/bem/project-stub/pull/13#discussion_r4950626"},"pull_request":{"href":"https://api.github.com/repos/bem/project-stub/pulls/13"}}}} | {
"id": 5715599,
"name": "project-stub",
"url": "https://github.com/bem/project-stub"
} | {
"id": null,
"login": "tadatuta",
"gravatar_id": "e04f76a31452c9d6974b03fe4c183b5d",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "bem",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-06-29T00:06:59 | null | {"repository":{"description":"Simple BEM project exampe","watchers":20,"stargazers":20,"forks":32,"fork":false,"size":260,"owner":"bem","private":false,"open_issues":3,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"JavaScript","created_at":"2012-09-07T03:48:30-07:00","pushed_at":"2013-06-20T06:08:58-07:00","master_branch":"master","organization":"bem"},"actor_attributes":{"type":"User","name":"Vladimir Grinenko","company":"Tadatuta","blog":"http://tadatuta.ru/","location":"Ukraine, Alushta","email":"[email protected]"},"url":"https://github.com/bem/project-stub/pull/13#discussion_r4950626"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/edx/edx-platform/pulls/comments/7144015","id":7144015,"diff_hunk":"@@ -229,11 +239,24 @@ def check_subtask_is_valid(entry_id, current_task_id):\n subtask_status = subtask_status_info[current_task_id]\n subtask_state = subtask_status.get('state')\n if subtask_state in READY_STATES:\n- format_str = \"Unexpected task_id '{}': already completed - status {} for subtask of instructor task '{}'\"\n- msg = format_str.format(current_task_id, subtask_status, entry)\n+ format_str = \"Unexpected task_id '{}': already completed - status {} for subtask of instructor task '{}': rejecting task {}\"\n+ msg = format_str.format(current_task_id, subtask_status, entry, new_subtask_status)\n TASK_LOG.warning(msg)\n raise DuplicateTaskException(msg)\n \n+ # Confirm that the InstructorTask doesn't think that this subtask is already being\n+ # retried by another task.\n+ if subtask_state == RETRY:\n+ # Check to see if the input number of retries is less than the recorded number.\n+ # If so, then this is an earlier version of the task, and a duplicate.\n+ new_retry_count = _get_retry_count(new_subtask_status)\n+ current_retry_count = _get_retry_count(subtask_status)\n+ if new_retry_count < current_retry_count:","path":"lms/djangoapps/instructor_task/subtasks.py","position":75,"original_position":75,"commit_id":"16b85c0c2ad8d51db549e5bf6371f39488d867f1","original_commit_id":"16b85c0c2ad8d51db549e5bf6371f39488d867f1","user":{"login":"rocha","id":51551,"avatar_url":"https://2.gravatar.com/avatar/5c504173a0189ef30c525c5aa38c591f?d=https%3A%2F%2Fidenticons.github.com%2Fd5873360bcb11868e074da394e7e1fd8.png","gravatar_id":"5c504173a0189ef30c525c5aa38c591f","url":"https://api.github.com/users/rocha","html_url":"https://github.com/rocha","followers_url":"https://api.github.com/users/rocha/followers","following_url":"https://api.github.com/users/rocha/following{/other_user}","gists_url":"https://api.github.com/users/rocha/gists{/gist_id}","starred_url":"https://api.github.com/users/rocha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rocha/subscriptions","organizations_url":"https://api.github.com/users/rocha/orgs","repos_url":"https://api.github.com/users/rocha/repos","events_url":"https://api.github.com/users/rocha/events{/privacy}","received_events_url":"https://api.github.com/users/rocha/received_events","type":"User","site_admin":false},"body":"What happens if `new_retry_count` is equal to `current_retry_count`? Doesn't that also mean that the task is duplicate too? Most likely I am not following correctly how the `new_subtask_status` is being created.","created_at":"2013-10-22T23:20:14Z","updated_at":"2013-10-22T23:20:14Z","html_url":"https://github.com/edx/edx-platform/pull/1458#discussion_r7144015","pull_request_url":"https://api.github.com/repos/edx/edx-platform/pulls/1458","_links":{"self":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/comments/7144015"},"html":{"href":"https://github.com/edx/edx-platform/pull/1458#discussion_r7144015"},"pull_request":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/1458"}}}} | {
"id": 10391073,
"name": "edx-platform",
"url": "https://github.com/edx/edx-platform"
} | {
"id": null,
"login": "rocha",
"gravatar_id": "5c504173a0189ef30c525c5aa38c591f",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "edx",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-10-22T23:20:14 | null | {"repository":{"description":"the edX learning management system (LMS) and course authoring tool, Studio","homepage":"http://code.edx.org/","watchers":697,"stargazers":697,"forks":302,"fork":false,"size":745887,"owner":"edx","private":false,"open_issues":72,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Python","created_at":"2013-05-30T13:20:38-07:00","pushed_at":"2013-10-22T16:19:43-07:00","master_branch":"master","organization":"edx"},"actor_attributes":{"type":"User","name":"Carlos Andrés Rocha","blog":"http://www.google.com/profiles/carlos.rocha","location":"Cambridge, MA","email":"[email protected]"},"url":"https://github.com/edx/edx-platform/pull/1458#discussion_r7144015"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/edx/edx-platform/pulls/comments/6578160","id":6578160,"body":"I'm only going to create one course mode per course, in \"honor\" mode and in usd, with min_price being the actual price we'll charge.\r\nFor now, I only want to use 1 type of currency across a platform installation for PaidCourseRegistration mode, so that's why I'm filtering on currency.\r\nI'm using filter instead of get because I'd rather get an empty list back when nothing is found rather than an exception. The empty list can be directly given to the template, which will know what to do with it, without having to write exception handlers.\r\n\r\n\r\n\r\nOn Sep 25, 2013, at 6:41 AM, Diana Huang <[email protected]> wrote:\r\n\r\n> In lms/djangoapps/courseware/views.py:\r\n> \r\n> > @@ -604,10 +605,31 @@ def course_about(request, course_id):\r\n> > show_courseware_link = (has_access(request.user, course, 'load') or\r\n> > settings.MITX_FEATURES.get('ENABLE_LMS_MIGRATION'))\r\n> > \r\n> > + # Note: this is a flow for payment for course registration, not the Verified Certificate flow.\r\n> > + registration_prices = []\r\n> > + in_cart = False\r\n> > + reg_then_add_to_cart_link = \"\"\r\n> > + if settings.MITX_FEATURES.get('ENABLE_PAID_COURSE_REGISTRATION'):\r\n> > + registration_prices = (CourseMode.objects\r\n> > + .filter(course_id=course_id,\r\n> > + currency=settings.PAID_COURSE_REGISTRATION_CURRENCY[0],\r\n> > + mode_slug=CourseMode.DEFAULT_MODE_SLUG,)\r\n> > + .values_list('min_price', flat=True))\r\n> I'm a little confused by how the course modes are going to be set up for this feature. I think originally we wanted it so that each course mode would only have one entry in the table per course. I'm open to using them more flexibly, but I'm a little confused by what you're doing here.\r\n> \r\n> —\r\n> Reply to this email directly or view it on GitHub.\r\n> ","diff_hunk":"@@ -604,10 +605,31 @@ def course_about(request, course_id):\n show_courseware_link = (has_access(request.user, course, 'load') or\n settings.MITX_FEATURES.get('ENABLE_LMS_MIGRATION'))\n \n+ # Note: this is a flow for payment for course registration, not the Verified Certificate flow.\n+ registration_prices = []\n+ in_cart = False\n+ reg_then_add_to_cart_link = \"\"\n+ if settings.MITX_FEATURES.get('ENABLE_PAID_COURSE_REGISTRATION'):\n+ registration_prices = (CourseMode.objects\n+ .filter(course_id=course_id,\n+ currency=settings.PAID_COURSE_REGISTRATION_CURRENCY[0],\n+ mode_slug=CourseMode.DEFAULT_MODE_SLUG,)\n+ .values_list('min_price', flat=True))","path":"lms/djangoapps/courseware/views.py","position":21,"original_position":21,"commit_id":"1a626232a40b679df7be052413002739794cccb0","original_commit_id":"042f81cf30227f75243799ac3745d284aa63556b","user":{"login":"jbau","id":721283,"avatar_url":"https://0.gravatar.com/avatar/9a95d201032b8c18ef4833cb9784a39d?d=https%3A%2F%2Fidenticons.github.com%2Fbc0b251e957d75904d11daa14803edbd.png","gravatar_id":"9a95d201032b8c18ef4833cb9784a39d","url":"https://api.github.com/users/jbau","html_url":"https://github.com/jbau","followers_url":"https://api.github.com/users/jbau/followers","following_url":"https://api.github.com/users/jbau/following{/other_user}","gists_url":"https://api.github.com/users/jbau/gists{/gist_id}","starred_url":"https://api.github.com/users/jbau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbau/subscriptions","organizations_url":"https://api.github.com/users/jbau/orgs","repos_url":"https://api.github.com/users/jbau/repos","events_url":"https://api.github.com/users/jbau/events{/privacy}","received_events_url":"https://api.github.com/users/jbau/received_events","type":"User"},"created_at":"2013-09-25T16:50:21Z","updated_at":"2013-09-25T16:50:21Z","html_url":"https://github.com/edx/edx-platform/pull/1118#discussion_r6578160","pull_request_url":"https://api.github.com/repos/edx/edx-platform/pulls/1118","_links":{"self":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/comments/6578160"},"html":{"href":"https://github.com/edx/edx-platform/pull/1118#discussion_r6578160"},"pull_request":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/1118"}}}} | {
"id": 10391073,
"name": "edx-platform",
"url": "https://github.com/edx/edx-platform"
} | {
"id": null,
"login": "jbau",
"gravatar_id": "9a95d201032b8c18ef4833cb9784a39d",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "edx",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-09-25T16:50:21 | null | {"repository":{"description":"the edX learning management system (LMS) and course authoring tool, Studio","homepage":"http://code.edx.org/","watchers":625,"stargazers":625,"forks":262,"fork":false,"size":676489,"owner":"edx","private":false,"open_issues":71,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Python","created_at":"2013-05-30T13:20:38-07:00","pushed_at":"2013-09-25T09:50:05-07:00","master_branch":"master","organization":"edx"},"actor_attributes":{"type":"User","name":"Jason Bau","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/edx/edx-platform/pull/1118#discussion_r6578160"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/edx/edx-platform/pulls/comments/5789436","id":5789436,"body":"Correct, this allows scripts that depend on `RequireJS.require` and so on to continue working properly.","diff_hunk":"@@ -0,0 +1,26 @@\n+## This file is designed to load all the XModule Javascript files in one wad\n+## using requirejs. It is passed through the Mako template system, which\n+## populates the `urls` variable with a list of paths to XModule JS files.\n+## These files assume that several libraries are available and bound to\n+## variables in the global context, so we load those libraries with requirejs\n+## and attach them to the global context manually.\n+define([\"jquery\", \"youtube\", \"mathjax\", \"codemirror\", \"tinymce\", \"jquery.tinymce\"],\n+ function($, YT, MathJax, CodeMirror, tinyMCE) {\n+ window.$ = $;\n+ window.YT = YT;\n+ window.MathJax = MathJax;\n+ window.CodeMirror = CodeMirror;\n+ window.tinyMCE = tinyMCE;\n+ window.RequireJS = {","path":"common/djangoapps/pipeline_js/templates/xmodule.js","position":14,"original_position":14,"commit_id":"30f77e4a36318dd5633103720fdad2159d0e69cd","original_commit_id":"30f77e4a36318dd5633103720fdad2159d0e69cd","user":{"login":"singingwolfboy","id":132355,"avatar_url":"https://secure.gravatar.com/avatar/42c77de97965d620ba0b6ae624c3ba7b?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"42c77de97965d620ba0b6ae624c3ba7b","url":"https://api.github.com/users/singingwolfboy","html_url":"https://github.com/singingwolfboy","followers_url":"https://api.github.com/users/singingwolfboy/followers","following_url":"https://api.github.com/users/singingwolfboy/following{/other_user}","gists_url":"https://api.github.com/users/singingwolfboy/gists{/gist_id}","starred_url":"https://api.github.com/users/singingwolfboy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/singingwolfboy/subscriptions","organizations_url":"https://api.github.com/users/singingwolfboy/orgs","repos_url":"https://api.github.com/users/singingwolfboy/repos","events_url":"https://api.github.com/users/singingwolfboy/events{/privacy}","received_events_url":"https://api.github.com/users/singingwolfboy/received_events","type":"User"},"created_at":"2013-08-15T13:15:28Z","updated_at":"2013-08-15T13:15:28Z","html_url":"https://github.com/edx/edx-platform/pull/662#discussion_r5789436","pull_request_url":"https://api.github.com/repos/edx/edx-platform/pulls/662","_links":{"self":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/comments/5789436"},"html":{"href":"https://github.com/edx/edx-platform/pull/662#discussion_r5789436"},"pull_request":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/662"}}}} | {
"id": 10391073,
"name": "edx-platform",
"url": "https://github.com/edx/edx-platform"
} | {
"id": null,
"login": "singingwolfboy",
"gravatar_id": "42c77de97965d620ba0b6ae624c3ba7b",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "edx",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-08-15T13:15:28 | null | {"repository":{"description":"the edX learning management system (LMS) and course authoring tool, Studio","homepage":"http://code.edx.org/","watchers":519,"stargazers":519,"forks":210,"fork":false,"size":377966,"owner":"edx","private":false,"open_issues":59,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Python","created_at":"2013-05-30T13:20:38-07:00","pushed_at":"2013-08-15T05:54:53-07:00","master_branch":"master","organization":"edx"},"actor_attributes":{"type":"User","name":"David Baumgold","company":"edX","blog":"http://davidbaumgold.com","location":"Massachusetts, USA","email":"[email protected]"},"url":"https://github.com/edx/edx-platform/pull/662#discussion_r5789436"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/edx/edx-platform/pulls/comments/7380211","id":7380211,"diff_hunk":"@@ -459,19 +465,18 @@ def change_enrollment(request):\n \n elif action == \"unenroll\":\n try:\n- CourseEnrollment.unenroll(user, course_id)\n-\n- org, course_num, run = course_id.split(\"/\")\n- dog_stats_api.increment(\n- \"common.student.unenrollment\",\n- tags=[\"org:{0}\".format(org),\n- \"course:{0}\".format(course_num),\n- \"run:{0}\".format(run)]\n- )\n-\n- return HttpResponse()\n+ CourseEnrollment.enrollment_mode_for_user(user, course_id)","path":"common/djangoapps/student/views.py","position":51,"original_position":51,"commit_id":"6d6b15a410c79e743324eb0cc300d4e871138010","original_commit_id":"6d6b15a410c79e743324eb0cc300d4e871138010","user":{"login":"dianakhuang","id":2952947,"avatar_url":"https://0.gravatar.com/avatar/8fe3b51416cd4d905e482e84b0210d26?d=https%3A%2F%2Fidenticons.github.com%2F4774394580f4abab23e3ec6378947c5c.png&r=x","gravatar_id":"8fe3b51416cd4d905e482e84b0210d26","url":"https://api.github.com/users/dianakhuang","html_url":"https://github.com/dianakhuang","followers_url":"https://api.github.com/users/dianakhuang/followers","following_url":"https://api.github.com/users/dianakhuang/following{/other_user}","gists_url":"https://api.github.com/users/dianakhuang/gists{/gist_id}","starred_url":"https://api.github.com/users/dianakhuang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dianakhuang/subscriptions","organizations_url":"https://api.github.com/users/dianakhuang/orgs","repos_url":"https://api.github.com/users/dianakhuang/repos","events_url":"https://api.github.com/users/dianakhuang/events{/privacy}","received_events_url":"https://api.github.com/users/dianakhuang/received_events","type":"User","site_admin":false},"body":"I'm a little confused about what you're doing here. It seems like you are trying to access the enrollment's mode to test to see if it exists before catching the exception, which will work, but I think it would be clearer that you're only testing for whether or not they're enrolled by using a simple `if` statement along with `CourseEnrollment.is_enrolled`.\r\n\r\n(For historical context, we used to test for enrollment by seeing if the enrollment object existed, but we're moving away from that now. I think this is an artifact of those dark times.)","created_at":"2013-11-01T20:11:48Z","updated_at":"2013-11-01T20:11:48Z","html_url":"https://github.com/edx/edx-platform/pull/1529#discussion_r7380211","pull_request_url":"https://api.github.com/repos/edx/edx-platform/pulls/1529","_links":{"self":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/comments/7380211"},"html":{"href":"https://github.com/edx/edx-platform/pull/1529#discussion_r7380211"},"pull_request":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/1529"}}}} | {
"id": 10391073,
"name": "edx-platform",
"url": "https://github.com/edx/edx-platform"
} | {
"id": null,
"login": "dianakhuang",
"gravatar_id": "8fe3b51416cd4d905e482e84b0210d26",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "edx",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-11-01T20:11:48 | null | {"repository":{"description":"the edX learning management system (LMS) and course authoring tool, Studio","homepage":"http://code.edx.org/","watchers":723,"stargazers":723,"forks":315,"fork":false,"size":749829,"owner":"edx","private":false,"open_issues":74,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Python","created_at":"2013-05-30T13:20:38-07:00","pushed_at":"2013-11-01T13:10:57-07:00","master_branch":"master","organization":"edx"},"actor_attributes":{"type":"User","name":"Diana Huang","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/edx/edx-platform/pull/1529#discussion_r7380211"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/edx/configuration/pulls/comments/6717362","id":6717362,"body":"The wheel package list is not created dynamically","diff_hunk":"@@ -89,7 +89,27 @@\n \n # Python plays that need to be run after platform updates.\n \n+# Install wheel archives before populating the virtualenv\n+# to speed up installation\n+\n+- name: Download the wheel archive\n+ get_url: url={{edxapp_wheel_url}}/{{edxapp_wheel_archive}}.tar.gz dest=/var/tmp\n+\n+- name: Untar the wheel archive\n+ shell: >\n+ tar -xzf {{edxapp_wheel_archive}}.tar.gz \n+ chdir=/var/tmp \n+ creates=/var/tmp/{{edxapp_wheel_archive}}\n+ \n+- name: Install from wheel files\n+ shell: >\n+ {{venv_dir}}/bin/pip install --use-wheel --no-index --find-links=/var/tmp/{{edxapp_wheel_archive}} {{item}}","path":"playbooks/roles/edxapp/tasks/deploy.yml","position":null,"original_position":18,"commit_id":"bc7fd2aaa6793f0e0b644eab89a2913d119d4439","original_commit_id":"2a937f28c978b40331c840de3cd2b7b3c6edc107","user":{"login":"jarv","id":749175,"avatar_url":"https://1.gravatar.com/avatar/979f5e9f6b44db629337930a10388507?d=https%3A%2F%2Fidenticons.github.com%2Fc1cd0752ec6b0b1154b60103c018834a.png","gravatar_id":"979f5e9f6b44db629337930a10388507","url":"https://api.github.com/users/jarv","html_url":"https://github.com/jarv","followers_url":"https://api.github.com/users/jarv/followers","following_url":"https://api.github.com/users/jarv/following{/other_user}","gists_url":"https://api.github.com/users/jarv/gists{/gist_id}","starred_url":"https://api.github.com/users/jarv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jarv/subscriptions","organizations_url":"https://api.github.com/users/jarv/orgs","repos_url":"https://api.github.com/users/jarv/repos","events_url":"https://api.github.com/users/jarv/events{/privacy}","received_events_url":"https://api.github.com/users/jarv/received_events","type":"User"},"created_at":"2013-10-02T14:59:45Z","updated_at":"2013-10-02T14:59:45Z","html_url":"https://github.com/edx/configuration/pull/303#discussion_r6717362","pull_request_url":"https://api.github.com/repos/edx/configuration/pulls/303","_links":{"self":{"href":"https://api.github.com/repos/edx/configuration/pulls/comments/6717362"},"html":{"href":"https://github.com/edx/configuration/pull/303#discussion_r6717362"},"pull_request":{"href":"https://api.github.com/repos/edx/configuration/pulls/303"}}}} | {
"id": 9478219,
"name": "configuration",
"url": "https://github.com/edx/configuration"
} | {
"id": null,
"login": "jarv",
"gravatar_id": "979f5e9f6b44db629337930a10388507",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "edx",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-10-02T14:59:45 | null | {"repository":{"description":"a simple, but flexible, way for anyone to stand up an instance of the edX platform that is fully configured and ready-to-go","homepage":"","watchers":73,"stargazers":73,"forks":39,"fork":false,"size":6188,"owner":"edx","private":false,"open_issues":17,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Python","created_at":"2013-04-16T10:23:42-07:00","pushed_at":"2013-10-02T07:59:06-07:00","master_branch":"master","organization":"edx"},"actor_attributes":{"type":"User","name":"John Jarvis","blog":"http://jarv.org","email":"[email protected]"},"url":"https://github.com/edx/configuration/pull/303#discussion_r6717362"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/edx/edx-platform/pulls/comments/7408900","id":7408900,"diff_hunk":"@@ -80,6 +80,18 @@ def seed():\n }\n }\n \n+# Enable asset pipeline\n+#\n+# PIPELINE is used by common/djangoapps/pipeline_mako/__init__.py\n+# PIPELINE_ENABLED is used by django-pipeline as described\n+# here: https://django-pipeline.readthedocs.org/en/latest/usage.html\n+#\n+# `PipelineFinder` is explained here: http://django-pipeline.readthedocs.org/en/1.1.24/storages.html","path":"cms/envs/acceptance.py","position":10,"original_position":10,"commit_id":"18f6c8e799da4d9d2d7574f02f366061cd335cad","original_commit_id":"18f6c8e799da4d9d2d7574f02f366061cd335cad","user":{"login":"cpennington","id":30236,"avatar_url":"https://1.gravatar.com/avatar/bf7434838ed52e9c1c4536d064451605?d=https%3A%2F%2Fidenticons.github.com%2Fe9a0ddc40651a765e246e1f4b8c3d3c8.png&r=x","gravatar_id":"bf7434838ed52e9c1c4536d064451605","url":"https://api.github.com/users/cpennington","html_url":"https://github.com/cpennington","followers_url":"https://api.github.com/users/cpennington/followers","following_url":"https://api.github.com/users/cpennington/following{/other_user}","gists_url":"https://api.github.com/users/cpennington/gists{/gist_id}","starred_url":"https://api.github.com/users/cpennington/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cpennington/subscriptions","organizations_url":"https://api.github.com/users/cpennington/orgs","repos_url":"https://api.github.com/users/cpennington/repos","events_url":"https://api.github.com/users/cpennington/events{/privacy}","received_events_url":"https://api.github.com/users/cpennington/received_events","type":"User","site_admin":false},"body":"You refer to `latest` in one comment, and `1.1.24` in another.","created_at":"2013-11-04T18:42:46Z","updated_at":"2013-11-04T18:42:46Z","html_url":"https://github.com/edx/edx-platform/pull/1567#discussion_r7408900","pull_request_url":"https://api.github.com/repos/edx/edx-platform/pulls/1567","_links":{"self":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/comments/7408900"},"html":{"href":"https://github.com/edx/edx-platform/pull/1567#discussion_r7408900"},"pull_request":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/1567"}}}} | {
"id": 10391073,
"name": "edx-platform",
"url": "https://github.com/edx/edx-platform"
} | {
"id": null,
"login": "cpennington",
"gravatar_id": "bf7434838ed52e9c1c4536d064451605",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "edx",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-11-04T18:42:46 | null | {"repository":{"description":"the edX learning management system (LMS) and course authoring tool, Studio","homepage":"http://code.edx.org/","watchers":727,"stargazers":727,"forks":321,"fork":false,"size":823563,"owner":"edx","private":false,"open_issues":69,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Python","created_at":"2013-05-30T13:20:38-07:00","pushed_at":"2013-11-04T10:41:38-08:00","master_branch":"master","organization":"edx"},"actor_attributes":{"type":"User","name":"Calen Pennington","company":"edX","blog":"","location":"Boston","email":"[email protected]"},"url":"https://github.com/edx/edx-platform/pull/1567#discussion_r7408900"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/edx/edx-platform/pulls/comments/5853108","id":5853108,"body":"From the context, it seems like the default value should be `{\"hits\": []}`","diff_hunk":"@@ -0,0 +1,185 @@\n+\"\"\"\n+Models for representation of search results\n+\"\"\"\n+\n+import json\n+import string\n+import logging\n+\n+import search.sorting\n+from xmodule.modulestore import Location\n+\n+import nltk\n+log = logging.getLogger(\"edx.search\")\n+\n+\n+class SearchResults:\n+ \"\"\"\n+ This is a collection of all search results to a query.\n+\n+ In addition to extending all of the standard collection methods (__len__, __getitem__, etc...)\n+ this lets you use custom sorts and filters on the included search results.\n+ \"\"\"\n+\n+ def __init__(self, response, **kwargs):\n+ \"\"\"kwargs should be the GET parameters from the original search request\n+ filters needs to be a dictionary that maps fields to allowed values\"\"\"\n+ raw_results = json.loads(response.content).get(\"hits\", {\"hits\": \"\"})[\"hits\"]","path":"common/djangoapps/search/models.py","position":27,"original_position":27,"commit_id":"2a95fc9151d735f0e5fcc59eb23b46d5ca95a95c","original_commit_id":"2a95fc9151d735f0e5fcc59eb23b46d5ca95a95c","user":{"login":"gwprice","id":4027165,"avatar_url":"https://2.gravatar.com/avatar/12245ad9b7a2b9c562375f6a790fe784?d=https%3A%2F%2Fidenticons.github.com%2F127edbb82f7ba09d548a9b6713afaffa.png","gravatar_id":"12245ad9b7a2b9c562375f6a790fe784","url":"https://api.github.com/users/gwprice","html_url":"https://github.com/gwprice","followers_url":"https://api.github.com/users/gwprice/followers","following_url":"https://api.github.com/users/gwprice/following{/other_user}","gists_url":"https://api.github.com/users/gwprice/gists{/gist_id}","starred_url":"https://api.github.com/users/gwprice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gwprice/subscriptions","organizations_url":"https://api.github.com/users/gwprice/orgs","repos_url":"https://api.github.com/users/gwprice/repos","events_url":"https://api.github.com/users/gwprice/events{/privacy}","received_events_url":"https://api.github.com/users/gwprice/received_events","type":"User"},"created_at":"2013-08-19T20:21:33Z","updated_at":"2013-08-19T20:21:33Z","html_url":"https://github.com/edx/edx-platform/pull/642#discussion_r5853108","pull_request_url":"https://api.github.com/repos/edx/edx-platform/pulls/642","_links":{"self":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/comments/5853108"},"html":{"href":"https://github.com/edx/edx-platform/pull/642#discussion_r5853108"},"pull_request":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/642"}}}} | {
"id": 10391073,
"name": "edx-platform",
"url": "https://github.com/edx/edx-platform"
} | {
"id": null,
"login": "gwprice",
"gravatar_id": "12245ad9b7a2b9c562375f6a790fe784",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "edx",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-08-19T20:21:33 | null | {"repository":{"description":"the edX learning management system (LMS) and course authoring tool, Studio","homepage":"http://code.edx.org/","watchers":524,"stargazers":524,"forks":217,"fork":false,"size":379124,"owner":"edx","private":false,"open_issues":60,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Python","created_at":"2013-05-30T13:20:38-07:00","pushed_at":"2013-08-19T13:19:13-07:00","master_branch":"master","organization":"edx"},"actor_attributes":{"type":"User","name":"Greg Price","company":"edX","location":"Cambridge, MA","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/edx/edx-platform/pull/642#discussion_r5853108"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/edx/edx-platform/pulls/comments/4922853","id":4922853,"body":"adds dynamic alt tag to course cover images in dashboard list","diff_hunk":"@@ -211,11 +211,11 @@ <h1 class=\"user-name\">${ user.username }</h1>\n \n % if course.id in show_courseware_links_for:\n <a href=\"${course_target}\" class=\"cover\">\n- <img src=\"${course_image_url(course)}\" />\n+ <img src=\"${course_image_url(course)}\" alt=\"${course.number} ${course.display_name_with_default} Cover Image\" />\n </a>\n % else:\n <div class=\"cover\">\n- <img src=\"${course_image_url(course)}\" />\n+ <img src=\"${course_image_url(course)}\" alt=\"${course.number} ${course.display_name_with_default} Cover Image\" />","path":"lms/templates/dashboard.html","position":10,"original_position":10,"commit_id":"4927577a38097d5b399c0958a33e0bc0c2a9fa08","original_commit_id":"4927577a38097d5b399c0958a33e0bc0c2a9fa08","user":{"login":"caesar2164","id":3364609,"avatar_url":"https://secure.gravatar.com/avatar/7e7443e981e702189b51e04f9c3c5ee1?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"7e7443e981e702189b51e04f9c3c5ee1","url":"https://api.github.com/users/caesar2164","html_url":"https://github.com/caesar2164","followers_url":"https://api.github.com/users/caesar2164/followers","following_url":"https://api.github.com/users/caesar2164/following{/other_user}","gists_url":"https://api.github.com/users/caesar2164/gists{/gist_id}","starred_url":"https://api.github.com/users/caesar2164/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caesar2164/subscriptions","organizations_url":"https://api.github.com/users/caesar2164/orgs","repos_url":"https://api.github.com/users/caesar2164/repos","events_url":"https://api.github.com/users/caesar2164/events{/privacy}","received_events_url":"https://api.github.com/users/caesar2164/received_events","type":"User"},"created_at":"2013-06-27T18:26:53Z","updated_at":"2013-06-27T18:26:53Z","html_url":"https://github.com/edx/edx-platform/pull/288#discussion_r4922853","pull_request_url":"https://api.github.com/repos/edx/edx-platform/pulls/288","_links":{"self":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/comments/4922853"},"html":{"href":"https://github.com/edx/edx-platform/pull/288#discussion_r4922853"},"pull_request":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/288"}}}} | {
"id": 10391073,
"name": "edx-platform",
"url": "https://github.com/edx/edx-platform"
} | {
"id": null,
"login": "caesar2164",
"gravatar_id": "7e7443e981e702189b51e04f9c3c5ee1",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "edx",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-06-27T18:26:53 | null | {"repository":{"description":"the edX learning management system (LMS) and course authoring tool, Studio","homepage":"http://code.edx.org/","watchers":398,"stargazers":398,"forks":121,"fork":false,"size":279420,"owner":"edx","private":false,"open_issues":40,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Python","created_at":"2013-05-30T13:20:38-07:00","pushed_at":"2013-06-27T11:01:54-07:00","master_branch":"master","organization":"edx"},"actor_attributes":{"type":"User","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/edx/edx-platform/pull/288#discussion_r4922853"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/edx/edx-platform/pulls/comments/7274299","id":7274299,"diff_hunk":"@@ -246,27 +253,43 @@ function (HTML5Video, Resizer) {\n // It is created on a onPlay event. Cleared on a onPause event.\n // Reinitialized on a onSeek event.\n function onSeek(params) {\n+ var duration = this.videoPlayer.duration(),\n+ newTime = params.time;\n+\n+ if (\n+ (typeof newTime !== 'number') ||","path":"common/lib/xmodule/xmodule/js/src/video/03_video_player.js","position":40,"original_position":40,"commit_id":"422884c4accbaa3545ed995b63e2390c0b127598","original_commit_id":"742a924908f33a9d8004bb52b9ce7d2609be188d","user":{"login":"valera-rozuvan","id":2273090,"avatar_url":"https://2.gravatar.com/avatar/937a84db1c29347e9c165db225c1ed79?d=https%3A%2F%2Fidenticons.github.com%2F178393688aa4a8739ddaa8593dedcdc0.png&r=x","gravatar_id":"937a84db1c29347e9c165db225c1ed79","url":"https://api.github.com/users/valera-rozuvan","html_url":"https://github.com/valera-rozuvan","followers_url":"https://api.github.com/users/valera-rozuvan/followers","following_url":"https://api.github.com/users/valera-rozuvan/following{/other_user}","gists_url":"https://api.github.com/users/valera-rozuvan/gists{/gist_id}","starred_url":"https://api.github.com/users/valera-rozuvan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/valera-rozuvan/subscriptions","organizations_url":"https://api.github.com/users/valera-rozuvan/orgs","repos_url":"https://api.github.com/users/valera-rozuvan/repos","events_url":"https://api.github.com/users/valera-rozuvan/events{/privacy}","received_events_url":"https://api.github.com/users/valera-rozuvan/received_events","type":"User","site_admin":false},"body":"= )","created_at":"2013-10-29T09:26:47Z","updated_at":"2013-10-29T09:26:47Z","html_url":"https://github.com/edx/edx-platform/pull/1480#discussion_r7274299","pull_request_url":"https://api.github.com/repos/edx/edx-platform/pulls/1480","_links":{"self":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/comments/7274299"},"html":{"href":"https://github.com/edx/edx-platform/pull/1480#discussion_r7274299"},"pull_request":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/1480"}}}} | {
"id": 10391073,
"name": "edx-platform",
"url": "https://github.com/edx/edx-platform"
} | {
"id": null,
"login": "valera-rozuvan",
"gravatar_id": "937a84db1c29347e9c165db225c1ed79",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "edx",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-10-29T09:26:47 | null | {"repository":{"description":"the edX learning management system (LMS) and course authoring tool, Studio","homepage":"http://code.edx.org/","watchers":717,"stargazers":717,"forks":309,"fork":false,"size":748146,"owner":"edx","private":false,"open_issues":70,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Python","created_at":"2013-05-30T13:20:38-07:00","pushed_at":"2013-10-29T01:54:29-07:00","master_branch":"master","organization":"edx"},"actor_attributes":{"type":"User","name":"Valera Rozuvan","company":"Innovecs","blog":"http://valera.rozuvan.net","location":"Kiev, Ukraine","email":"[email protected]"},"url":"https://github.com/edx/edx-platform/pull/1480#discussion_r7274299"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/edx/edx-platform/pulls/comments/5936837","id":5936837,"body":"Add a test for index_course","diff_hunk":"@@ -0,0 +1,45 @@\n+\"\"\"\n+Basic test for views in search\n+\"\"\"\n+\n+from collections import namedtuple\n+from BaseHTTPServer import BaseHTTPRequestHandler\n+\n+from django.test import TestCase\n+from django.test.utils import override_settings\n+import requests\n+\n+import search.views as views\n+from search.models import SearchResults\n+from mocks import StubServer, StubRequestHandler\n+\n+class PersonalServer(StubServer):\n+\n+ def log_request(self, request_type, path, content):\n+ self.requests.append(self.request(request_type, path, content))\n+ if path.endswith(\"_search\"):\n+ self.content = \"{}\"\n+\n+\n+class ViewTest(TestCase):","path":"common/djangoapps/search/tests/test_views.py","position":24,"original_position":24,"commit_id":"15b57724904e5584875392d240dda8e2e775418f","original_commit_id":"15b57724904e5584875392d240dda8e2e775418f","user":{"login":"gwprice","id":4027165,"avatar_url":"https://2.gravatar.com/avatar/12245ad9b7a2b9c562375f6a790fe784?d=https%3A%2F%2Fidenticons.github.com%2F127edbb82f7ba09d548a9b6713afaffa.png","gravatar_id":"12245ad9b7a2b9c562375f6a790fe784","url":"https://api.github.com/users/gwprice","html_url":"https://github.com/gwprice","followers_url":"https://api.github.com/users/gwprice/followers","following_url":"https://api.github.com/users/gwprice/following{/other_user}","gists_url":"https://api.github.com/users/gwprice/gists{/gist_id}","starred_url":"https://api.github.com/users/gwprice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gwprice/subscriptions","organizations_url":"https://api.github.com/users/gwprice/orgs","repos_url":"https://api.github.com/users/gwprice/repos","events_url":"https://api.github.com/users/gwprice/events{/privacy}","received_events_url":"https://api.github.com/users/gwprice/received_events","type":"User"},"created_at":"2013-08-22T21:01:18Z","updated_at":"2013-08-22T21:01:18Z","html_url":"https://github.com/edx/edx-platform/pull/642#discussion_r5936837","pull_request_url":"https://api.github.com/repos/edx/edx-platform/pulls/642","_links":{"self":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/comments/5936837"},"html":{"href":"https://github.com/edx/edx-platform/pull/642#discussion_r5936837"},"pull_request":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/642"}}}} | {
"id": 10391073,
"name": "edx-platform",
"url": "https://github.com/edx/edx-platform"
} | {
"id": null,
"login": "gwprice",
"gravatar_id": "12245ad9b7a2b9c562375f6a790fe784",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "edx",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-08-22T21:01:18 | null | {"repository":{"description":"the edX learning management system (LMS) and course authoring tool, Studio","homepage":"http://code.edx.org/","watchers":532,"stargazers":532,"forks":227,"fork":false,"size":402222,"owner":"edx","private":false,"open_issues":61,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Python","created_at":"2013-05-30T13:20:38-07:00","pushed_at":"2013-08-22T13:54:19-07:00","master_branch":"master","organization":"edx"},"actor_attributes":{"type":"User","name":"Greg Price","company":"edX","location":"Cambridge, MA","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/edx/edx-platform/pull/642#discussion_r5936837"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/edx/edx-platform/pulls/comments/4899486","id":4899486,"body":"Looks weird to be iterating over \"all_hints\" using a \"problem\". Can you think of better variable names for both?","diff_hunk":"@@ -0,0 +1,225 @@\n+'''\n+Views for hint management.\n+'''\n+\n+from collections import defaultdict\n+import csv\n+import json\n+import logging\n+from markupsafe import escape\n+import os\n+import re\n+import requests\n+from requests.status_codes import codes\n+import urllib\n+from collections import OrderedDict\n+\n+from StringIO import StringIO\n+\n+from django.conf import settings\n+from django.contrib.auth.models import User, Group\n+from django.http import HttpResponse, Http404\n+from django_future.csrf import ensure_csrf_cookie\n+from django.views.decorators.cache import cache_control\n+from mitxmako.shortcuts import render_to_response, render_to_string\n+from django.core.urlresolvers import reverse\n+\n+from courseware.courses import get_course_with_access\n+from courseware.models import XModuleContentField\n+from xmodule.modulestore import Location\n+from xmodule.modulestore.django import modulestore\n+\n+\n+@ensure_csrf_cookie\n+def hint_manager(request, course_id):\n+ try:\n+ course = get_course_with_access(request.user, course_id, 'staff', depth=None)\n+ except Http404:\n+ out = 'Sorry, but students are not allowed to access the hint manager!'\n+ return HttpResponse(out)\n+ if request.method == 'GET':\n+ out = get_hints(request, course_id, 'mod_queue')\n+ return render_to_response('courseware/hint_manager.html', out)\n+ field = request.POST['field']\n+ if not (field == 'mod_queue' or field == 'hints'):\n+ # Invalid field. (Don't let users continue - they may overwrite other db's)\n+ return \n+ if request.POST['op'] == 'delete hints':\n+ delete_hints(request, course_id, field)\n+ if request.POST['op'] == 'switch fields':\n+ pass\n+ if request.POST['op'] == 'change votes':\n+ change_votes(request, course_id, field)\n+ if request.POST['op'] == 'add hint':\n+ add_hint(request, course_id, field)\n+ if request.POST['op'] == 'approve':\n+ approve(request, course_id, field)\n+ rendered_html = render_to_string('courseware/hint_manager_inner.html', get_hints(request, course_id, field))\n+ return HttpResponse(json.dumps({'success': True, 'contents': rendered_html}))\n+\n+\n+\n+def get_hints(request, course_id, field):\n+ # field indicates the database entry that we are modifying.\n+ # Right now, the options are 'hints' or 'mod_queue'.\n+ # DON'T TRUST field attributes that come from ajax. Use an if statement\n+ # to make sure the field is valid before plugging into functions.\n+\n+ if field == 'mod_queue':\n+ other_field = 'hints'\n+ field_label = 'Hints Awaiting Moderation'\n+ other_field_label = 'Approved Hints'\n+ elif field == 'hints':\n+ other_field = 'mod_queue'\n+ field_label = 'Approved Hints'\n+ other_field_label = 'Hints Awaiting Moderation'\n+ chopped_id = '/'.join(course_id.split('/')[:-1])\n+ chopped_id = re.escape(chopped_id)\n+ all_hints = XModuleContentField.objects.filter(field_name=field, definition_id__regex=chopped_id)\n+ big_out_dict = {}\n+ name_dict = {}\n+ for problem in all_hints:","path":"lms/djangoapps/instructor/hint_manager.py","position":81,"original_position":81,"commit_id":"6d067380c383cc13fa060002e06cfade320163ad","original_commit_id":"6d067380c383cc13fa060002e06cfade320163ad","user":{"login":"rocha","id":51551,"avatar_url":"https://secure.gravatar.com/avatar/5c504173a0189ef30c525c5aa38c591f?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"5c504173a0189ef30c525c5aa38c591f","url":"https://api.github.com/users/rocha","html_url":"https://github.com/rocha","followers_url":"https://api.github.com/users/rocha/followers","following_url":"https://api.github.com/users/rocha/following{/other_user}","gists_url":"https://api.github.com/users/rocha/gists{/gist_id}","starred_url":"https://api.github.com/users/rocha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rocha/subscriptions","organizations_url":"https://api.github.com/users/rocha/orgs","repos_url":"https://api.github.com/users/rocha/repos","events_url":"https://api.github.com/users/rocha/events{/privacy}","received_events_url":"https://api.github.com/users/rocha/received_events","type":"User"},"created_at":"2013-06-26T19:02:04Z","updated_at":"2013-06-26T19:02:04Z","html_url":"https://github.com/edx/edx-platform/pull/275#discussion_r4899486","pull_request_url":"https://api.github.com/repos/edx/edx-platform/pulls/275","_links":{"self":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/comments/4899486"},"html":{"href":"https://github.com/edx/edx-platform/pull/275#discussion_r4899486"},"pull_request":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/275"}}}} | {
"id": 10391073,
"name": "edx-platform",
"url": "https://github.com/edx/edx-platform"
} | {
"id": null,
"login": "rocha",
"gravatar_id": "5c504173a0189ef30c525c5aa38c591f",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "edx",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-06-26T19:02:04 | null | {"repository":{"description":"the edX learning management system (LMS) and course authoring tool, Studio","homepage":"http://code.edx.org/","watchers":394,"stargazers":394,"forks":118,"fork":false,"size":279224,"owner":"edx","private":false,"open_issues":40,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Python","created_at":"2013-05-30T13:20:38-07:00","pushed_at":"2013-06-26T11:47:05-07:00","master_branch":"master","organization":"edx"},"actor_attributes":{"type":"User","name":"Carlos Andrés Rocha","blog":"http://www.google.com/profiles/carlos.rocha","location":"Cambridge, MA","email":"[email protected]"},"url":"https://github.com/edx/edx-platform/pull/275#discussion_r4899486"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/edx/edx-platform/pulls/comments/4969153","id":4969153,"body":"Yes, the whole file. Templates are purely to support xmodule create operations. They seem an application tier not an xmodule tier function. We have a lot of functionality at the persistence tier, model tier, etc which seems like it should be in another tier such as app tier. Part of the problem is not having a clean definition of the architecture's tiers. In this case, my comment is an editorial.","diff_hunk":"@@ -1,34 +1,18 @@\n \"\"\"\n-This module handles loading xmodule templates from disk into the modulestore.\n+This module handles loading xmodule templates\n These templates are used by the CMS to provide baseline content that\n-can be cloned when adding new modules to a course.\n+gives sample field values when adding new modules to a course.\n \n `Template`s are defined in x_module. They contain 3 attributes:\n- metadata: A dictionary with the template metadata. This should contain\n- any values for fields\n- * with scope Scope.settings\n- * that have values different than the field defaults\n- * and that are to be editable in Studio\n- data: A JSON value that defines the template content. This should be a dictionary\n- containing values for fields\n- * with scope Scope.content\n- * that have values different than the field defaults\n- * and that are to be editable in Studio\n- or, if the module uses a single Scope.content String field named `data`, this\n- should be a string containing the contents of that field\n- children: A list of Location urls that define the template children\n-\n-Templates are defined on XModuleDescriptor types, in the template attribute.\n+ metadata: A dictionary with the template metadata\n+ data: A JSON value that defines the template content\n \"\"\"\n \n-\n+# TODO should this move to cms since it's really only for module crud?","path":"common/lib/xmodule/xmodule/templates.py","position":29,"original_position":29,"commit_id":"41e7a979e04af4557326b462f61077d4596c6a2f","original_commit_id":"8aaaec8aadda5bda2f15a7b0479c9eedb743f72b","user":{"login":"dmitchell","id":475919,"avatar_url":"https://secure.gravatar.com/avatar/36268e32a487952477b6f129e590005f?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"36268e32a487952477b6f129e590005f","url":"https://api.github.com/users/dmitchell","html_url":"https://github.com/dmitchell","followers_url":"https://api.github.com/users/dmitchell/followers","following_url":"https://api.github.com/users/dmitchell/following{/other_user}","gists_url":"https://api.github.com/users/dmitchell/gists{/gist_id}","starred_url":"https://api.github.com/users/dmitchell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmitchell/subscriptions","organizations_url":"https://api.github.com/users/dmitchell/orgs","repos_url":"https://api.github.com/users/dmitchell/repos","events_url":"https://api.github.com/users/dmitchell/events{/privacy}","received_events_url":"https://api.github.com/users/dmitchell/received_events","type":"User"},"created_at":"2013-07-01T18:53:51Z","updated_at":"2013-07-01T18:53:51Z","html_url":"https://github.com/edx/edx-platform/pull/270#discussion_r4969153","pull_request_url":"https://api.github.com/repos/edx/edx-platform/pulls/270","_links":{"self":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/comments/4969153"},"html":{"href":"https://github.com/edx/edx-platform/pull/270#discussion_r4969153"},"pull_request":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/270"}}}} | {
"id": 10391073,
"name": "edx-platform",
"url": "https://github.com/edx/edx-platform"
} | {
"id": null,
"login": "dmitchell",
"gravatar_id": "36268e32a487952477b6f129e590005f",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "edx",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-07-01T18:53:51 | null | {"repository":{"description":"the edX learning management system (LMS) and course authoring tool, Studio","homepage":"http://code.edx.org/","watchers":408,"stargazers":408,"forks":131,"fork":false,"size":280268,"owner":"edx","private":false,"open_issues":47,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Python","created_at":"2013-05-30T13:20:38-07:00","pushed_at":"2013-07-01T11:53:46-07:00","master_branch":"master","organization":"edx"},"actor_attributes":{"type":"User","name":"Don Mitchell","company":"edX","email":"[email protected]"},"url":"https://github.com/edx/edx-platform/pull/270#discussion_r4969153"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/edx/edx-platform/pulls/comments/6694081","id":6694081,"body":"I've added a minified version to the repo as well, but since we only use this library for testing purposes, it's not really necessary.","diff_hunk":"@@ -0,0 +1,250 @@\n+define(function() {\n+","path":"common/static/js/vendor/Squire.js","position":2,"original_position":2,"commit_id":"434d728232a4c1ab5cef8debe5181972421d6707","original_commit_id":"994c3555fe2163772768719ed408604e5f9faa4d","user":{"login":"singingwolfboy","id":132355,"avatar_url":"https://1.gravatar.com/avatar/42c77de97965d620ba0b6ae624c3ba7b?d=https%3A%2F%2Fidenticons.github.com%2Fd8b65bc1ad622719a92542b55b34bc7a.png","gravatar_id":"42c77de97965d620ba0b6ae624c3ba7b","url":"https://api.github.com/users/singingwolfboy","html_url":"https://github.com/singingwolfboy","followers_url":"https://api.github.com/users/singingwolfboy/followers","following_url":"https://api.github.com/users/singingwolfboy/following{/other_user}","gists_url":"https://api.github.com/users/singingwolfboy/gists{/gist_id}","starred_url":"https://api.github.com/users/singingwolfboy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/singingwolfboy/subscriptions","organizations_url":"https://api.github.com/users/singingwolfboy/orgs","repos_url":"https://api.github.com/users/singingwolfboy/repos","events_url":"https://api.github.com/users/singingwolfboy/events{/privacy}","received_events_url":"https://api.github.com/users/singingwolfboy/received_events","type":"User"},"created_at":"2013-10-01T18:02:22Z","updated_at":"2013-10-01T18:02:22Z","html_url":"https://github.com/edx/edx-platform/pull/662#discussion_r6694081","pull_request_url":"https://api.github.com/repos/edx/edx-platform/pulls/662","_links":{"self":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/comments/6694081"},"html":{"href":"https://github.com/edx/edx-platform/pull/662#discussion_r6694081"},"pull_request":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/662"}}}} | {
"id": 10391073,
"name": "edx-platform",
"url": "https://github.com/edx/edx-platform"
} | {
"id": null,
"login": "singingwolfboy",
"gravatar_id": "42c77de97965d620ba0b6ae624c3ba7b",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "edx",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-10-01T18:02:22 | null | {"repository":{"description":"the edX learning management system (LMS) and course authoring tool, Studio","homepage":"http://code.edx.org/","watchers":644,"stargazers":644,"forks":269,"fork":false,"size":741381,"owner":"edx","private":false,"open_issues":67,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Python","created_at":"2013-05-30T13:20:38-07:00","pushed_at":"2013-10-01T10:58:44-07:00","master_branch":"master","organization":"edx"},"actor_attributes":{"type":"User","name":"David Baumgold","company":"edX","blog":"http://davidbaumgold.com","location":"Massachusetts, USA","email":"[email protected]"},"url":"https://github.com/edx/edx-platform/pull/662#discussion_r6694081"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/edx/configuration/pulls/comments/6895958","id":6895958,"diff_hunk":"@@ -0,0 +1,679 @@\n+#!/usr/bin/python\n+# This file is part of Ansible","path":"playbooks/library/ec2","position":2,"original_position":2,"commit_id":"c576f592254e9bb24185110ad05e90ec1bcf2102","original_commit_id":"c576f592254e9bb24185110ad05e90ec1bcf2102","user":{"login":"feanil","id":781561,"avatar_url":"https://0.gravatar.com/avatar/687ecabc061475a3ae38b3cfed47e700?d=https%3A%2F%2Fidenticons.github.com%2F8049031faa47b7f7e634986b1f426a3b.png","gravatar_id":"687ecabc061475a3ae38b3cfed47e700","url":"https://api.github.com/users/feanil","html_url":"https://github.com/feanil","followers_url":"https://api.github.com/users/feanil/followers","following_url":"https://api.github.com/users/feanil/following{/other_user}","gists_url":"https://api.github.com/users/feanil/gists{/gist_id}","starred_url":"https://api.github.com/users/feanil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/feanil/subscriptions","organizations_url":"https://api.github.com/users/feanil/orgs","repos_url":"https://api.github.com/users/feanil/repos","events_url":"https://api.github.com/users/feanil/events{/privacy}","received_events_url":"https://api.github.com/users/feanil/received_events","type":"User","site_admin":false},"body":"If this is a part of ansible why do we have to include it here? Is it not available until a later version?","created_at":"2013-10-10T18:31:43Z","updated_at":"2013-10-10T18:31:43Z","html_url":"https://github.com/edx/configuration/pull/319#discussion_r6895958","pull_request_url":"https://api.github.com/repos/edx/configuration/pulls/319","_links":{"self":{"href":"https://api.github.com/repos/edx/configuration/pulls/comments/6895958"},"html":{"href":"https://github.com/edx/configuration/pull/319#discussion_r6895958"},"pull_request":{"href":"https://api.github.com/repos/edx/configuration/pulls/319"}}}} | {
"id": 9478219,
"name": "configuration",
"url": "https://github.com/edx/configuration"
} | {
"id": null,
"login": "feanil",
"gravatar_id": "687ecabc061475a3ae38b3cfed47e700",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "edx",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-10-10T18:31:43 | null | {"repository":{"description":"a simple, but flexible, way for anyone to stand up an instance of the edX platform that is fully configured and ready-to-go","homepage":"","watchers":75,"stargazers":75,"forks":40,"fork":false,"size":6862,"owner":"edx","private":false,"open_issues":19,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Python","created_at":"2013-04-16T10:23:42-07:00","pushed_at":"2013-10-10T10:52:34-07:00","master_branch":"master","organization":"edx"},"actor_attributes":{"type":"User","name":"Feanil Patel","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/edx/configuration/pull/319#discussion_r6895958"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/edx/edx-platform/pulls/comments/5301829","id":5301829,"body":"Shouldn't translate a trademark (MITx, MIT, \"Massachusetts Institute of Technology\").\r\n\r\nMultiple instances on this page.","diff_hunk":"@@ -1,7 +1,8 @@\n+<%! from django.utils.translation import ugettext as _ %>\n <%inherit file=\"base.html\" />\n <%namespace name='static' file='../static_content.html'/>\n \n-<%block name=\"title\"><title>MITx</title></%block>\n+<%block name=\"title\"><title>${_(\"MITx\")}</title></%block>","path":"lms/templates/university_profile/mitx.html","position":6,"original_position":6,"commit_id":"e94cfb240ee5025b5df5d979034e782537c52e95","original_commit_id":"e94cfb240ee5025b5df5d979034e782537c52e95","user":{"login":"sarina","id":1985317,"avatar_url":"https://secure.gravatar.com/avatar/136faf64ffa4486f0038265b06756f52?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"136faf64ffa4486f0038265b06756f52","url":"https://api.github.com/users/sarina","html_url":"https://github.com/sarina","followers_url":"https://api.github.com/users/sarina/followers","following_url":"https://api.github.com/users/sarina/following{/other_user}","gists_url":"https://api.github.com/users/sarina/gists{/gist_id}","starred_url":"https://api.github.com/users/sarina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sarina/subscriptions","organizations_url":"https://api.github.com/users/sarina/orgs","repos_url":"https://api.github.com/users/sarina/repos","events_url":"https://api.github.com/users/sarina/events{/privacy}","received_events_url":"https://api.github.com/users/sarina/received_events","type":"User"},"created_at":"2013-07-19T20:15:20Z","updated_at":"2013-07-19T20:15:20Z","html_url":"https://github.com/edx/edx-platform/pull/433#discussion_r5301829","pull_request_url":"https://api.github.com/repos/edx/edx-platform/pulls/433","_links":{"self":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/comments/5301829"},"html":{"href":"https://github.com/edx/edx-platform/pull/433#discussion_r5301829"},"pull_request":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/433"}}}} | {
"id": 10391073,
"name": "edx-platform",
"url": "https://github.com/edx/edx-platform"
} | {
"id": null,
"login": "sarina",
"gravatar_id": "136faf64ffa4486f0038265b06756f52",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "edx",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-07-19T20:15:20 | null | {"repository":{"description":"the edX learning management system (LMS) and course authoring tool, Studio","homepage":"http://code.edx.org/","watchers":458,"stargazers":458,"forks":171,"fork":false,"size":288050,"owner":"edx","private":false,"open_issues":42,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Python","created_at":"2013-05-30T13:20:38-07:00","pushed_at":"2013-07-19T13:14:53-07:00","master_branch":"master","organization":"edx"},"actor_attributes":{"type":"User","name":"Sarina Canelake","location":"Cambridge, MA","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/edx/edx-platform/pull/433#discussion_r5301829"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/edx/edx-platform/pulls/comments/4764587","id":4764587,"body":"There are much safer ways to do this. I'd recommend using `mock.patch.dict()` to temporarily override the feature flags dict.","diff_hunk":"@@ -0,0 +1,414 @@\n+import logging\n+import datetime\n+import pytz\n+import random\n+\n+from uuid import uuid4\n+\n+from django.contrib.auth.models import User, Group\n+from django.conf import settings\n+from django.core.urlresolvers import reverse\n+from django.test.utils import override_settings\n+\n+import xmodule.modulestore.django\n+\n+# Need access to internal func to put users in the right group\n+from courseware.access import (has_access, _course_staff_group_name,\n+ course_beta_test_group_name)\n+\n+from mongo_login_helpers import MongoLoginHelpers\n+\n+from xmodule.modulestore.tests.factories import CourseFactory, ItemFactory\n+\n+log = logging.getLogger(\"mitx.\" + __name__)\n+\n+\n+def get_user(email):\n+ '''look up a user by email'''\n+ return User.objects.get(email=email)\n+\n+\n+def update_course(course, data):\n+ \"\"\"\n+ Updates the version of course in the mongo modulestore\n+ with the metadata in data and returns the updated version.\n+ \"\"\"\n+\n+ store = xmodule.modulestore.django.modulestore()\n+\n+ store.update_item(course.location, data)\n+\n+ store.update_metadata(course.location, data)\n+\n+ updated_course = store.get_instance(course.id, course.location)\n+\n+ return updated_course\n+\n+\n+def mongo_store_config(data_dir):\n+ '''\n+ Defines default module store using MongoModuleStore\n+\n+ Use of this config requires mongo to be running\n+ '''\n+ store = {\n+ 'default': {\n+ 'ENGINE': 'xmodule.modulestore.mongo.MongoModuleStore',\n+ 'OPTIONS': {\n+ 'default_class': 'xmodule.raw_module.RawDescriptor',\n+ 'host': 'localhost',\n+ 'db': 'test_xmodule',\n+ 'collection': 'modulestore_%s' % uuid4().hex,\n+ 'fs_root': data_dir,\n+ 'render_template': 'mitxmako.shortcuts.render_to_string',\n+ }\n+ }\n+ }\n+ store['direct'] = store['default']\n+ return store\n+\n+\n+TEST_DATA_DIR = settings.COMMON_TEST_DATA_ROOT\n+TEST_DATA_MONGO_MODULESTORE = mongo_store_config(TEST_DATA_DIR)\n+\n+\n+@override_settings(MODULESTORE=TEST_DATA_MONGO_MODULESTORE)\n+class TestViewAuth(MongoLoginHelpers):\n+ \"\"\"Check that view authentication works properly\"\"\"\n+\n+ def setUp(self):\n+ xmodule.modulestore.django._MODULESTORES = {}\n+\n+ self.full = CourseFactory.create(number='666', display_name='Robot_Sub_Course')\n+ self.course = CourseFactory.create()\n+ self.overview_chapter = ItemFactory.create(display_name='Overview')\n+ self.courseware_chapter = ItemFactory.create(display_name='courseware')\n+ self.sub_courseware_chapter = ItemFactory.create(parent_location=self.full.location,\n+ display_name='courseware')\n+ self.sub_overview_chapter = ItemFactory.create(parent_location=self.sub_courseware_chapter.location,\n+ display_name='Overview')\n+ self.progress_chapter = ItemFactory.create(parent_location=self.course.location,\n+ display_name='progress')\n+ self.info_chapter = ItemFactory.create(parent_location=self.course.location,\n+ display_name='info')\n+ self.welcome_section = ItemFactory.create(parent_location=self.overview_chapter.location,\n+ display_name='Welcome')\n+ self.somewhere_in_progress = ItemFactory.create(parent_location=self.progress_chapter.location,\n+ display_name='1')\n+\n+ # Create two accounts\n+ self.student = '[email protected]'\n+ self.instructor = '[email protected]'\n+ self.password = 'foo'\n+ self.create_account('u1', self.student, self.password)\n+ self.create_account('u2', self.instructor, self.password)\n+ self.activate_user(self.student)\n+ self.activate_user(self.instructor)\n+\n+ def test_instructor_pages(self):\n+ \"\"\"Make sure only instructors for the course\n+ or staff can load the instructor\n+ dashboard, the grade views, and student profile pages\"\"\"\n+\n+ # First, try with an enrolled student\n+ self.login(self.student, self.password)\n+ # shouldn't work before enroll\n+ response = self.client.get(reverse('courseware',\n+ kwargs={'course_id': self.course.id}))\n+\n+ self.assertRedirectsNoFollow(response,\n+ reverse('about_course',\n+ args=[self.course.id]))\n+ self.enroll(self.course)\n+ self.enroll(self.full)\n+ # should work now -- redirect to first page\n+ response = self.client.get(reverse('courseware',\n+ kwargs={'course_id': self.course.id}))\n+\n+ self.assertRedirectsNoFollow(response,\n+ reverse('courseware_section',\n+ kwargs={'course_id': self.course.id,\n+ 'chapter': 'Overview',\n+ 'section': 'Welcome'}))\n+\n+ def instructor_urls(course):\n+ \"list of urls that only instructors/staff should be able to see\"\n+ urls = [reverse(name, kwargs={'course_id': course.id}) for name in (\n+ 'instructor_dashboard',\n+ 'gradebook',\n+ 'grade_summary',)]\n+\n+ urls.append(reverse('student_progress',\n+ kwargs={'course_id': course.id,\n+ 'student_id': get_user(self.student).id}))\n+ return urls\n+\n+ # Randomly sample an instructor page\n+ url = random.choice(instructor_urls(self.course) +\n+ instructor_urls(self.full))\n+\n+ # Shouldn't be able to get to the instructor pages\n+ print 'checking for 404 on {0}'.format(url)\n+ self.check_for_get_code(404, url)\n+\n+ # Make the instructor staff in the toy course\n+ group_name = _course_staff_group_name(self.course.location)\n+ group = Group.objects.create(name=group_name)\n+ group.user_set.add(get_user(self.instructor))\n+\n+ self.logout()\n+ self.login(self.instructor, self.password)\n+\n+ # Now should be able to get to the toy course, but not the full course\n+ url = random.choice(instructor_urls(self.course))\n+ print 'checking for 200 on {0}'.format(url)\n+ self.check_for_get_code(200, url)\n+\n+ url = random.choice(instructor_urls(self.full))\n+ print 'checking for 404 on {0}'.format(url)\n+ self.check_for_get_code(404, url)\n+\n+ # now also make the instructor staff\n+ instructor = get_user(self.instructor)\n+ instructor.is_staff = True\n+ instructor.save()\n+\n+ # and now should be able to load both\n+ url = random.choice(instructor_urls(self.course) +\n+ instructor_urls(self.full))\n+\n+ print 'checking for 200 on {0}'.format(url)\n+ self.check_for_get_code(200, url)\n+\n+ def run_wrapped(self, test):\n+ \"\"\"","path":"lms/djangoapps/courseware/tests/test_view_authentication.py","position":184,"original_position":184,"commit_id":"905d884aa7a517bdc11cde348f5b8fb76ccef093","original_commit_id":"905d884aa7a517bdc11cde348f5b8fb76ccef093","user":{"login":"wedaly","id":2948394,"avatar_url":"https://secure.gravatar.com/avatar/44480ae60bb8231a1e95497a562aa0b7?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"44480ae60bb8231a1e95497a562aa0b7","url":"https://api.github.com/users/wedaly","html_url":"https://github.com/wedaly","followers_url":"https://api.github.com/users/wedaly/followers","following_url":"https://api.github.com/users/wedaly/following{/other_user}","gists_url":"https://api.github.com/users/wedaly/gists{/gist_id}","starred_url":"https://api.github.com/users/wedaly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wedaly/subscriptions","organizations_url":"https://api.github.com/users/wedaly/orgs","repos_url":"https://api.github.com/users/wedaly/repos","events_url":"https://api.github.com/users/wedaly/events{/privacy}","received_events_url":"https://api.github.com/users/wedaly/received_events","type":"User"},"created_at":"2013-06-19T02:25:28Z","updated_at":"2013-06-19T02:25:28Z","html_url":"https://github.com/edx/edx-platform/pull/204#discussion_r4764587","pull_request_url":"https://api.github.com/repos/edx/edx-platform/pulls/204","_links":{"self":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/comments/4764587"},"html":{"href":"https://github.com/edx/edx-platform/pull/204#discussion_r4764587"},"pull_request":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/204"}}}} | {
"id": 10391073,
"name": "edx-platform",
"url": "https://github.com/edx/edx-platform"
} | {
"id": null,
"login": "wedaly",
"gravatar_id": "44480ae60bb8231a1e95497a562aa0b7",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "edx",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-06-19T02:25:28 | null | {"repository":{"description":"the edX learning management system (LMS) and course authoring tool, Studio","homepage":"http://code.edx.org/","watchers":379,"stargazers":379,"forks":105,"fork":false,"size":278068,"owner":"edx","private":false,"open_issues":50,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Python","created_at":"2013-05-30T13:20:38-07:00","pushed_at":"2013-06-18T16:23:18-07:00","master_branch":"master","organization":"edx"},"actor_attributes":{"type":"User","name":"Will Daly","blog":"http://will-daly.com","location":"Boston, MA","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/edx/edx-platform/pull/204#discussion_r4764587"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/fog/fog/pulls/comments/3965559","id":3965559,"body":"Fixed in updated commit, thanks.","diff_hunk":"@@ -24,11 +24,12 @@ class Real\n # ==== See Also\n # http://docs.amazonwebservices.com/IAM/latest/APIReference/API_CreateUser.html\n #\n- def create_user(user_name, path = '/')\n+ def create_user(user_name, path = '/', create_date = Time.now)\n request(\n 'Action' => 'CreateUser',\n 'UserName' => user_name,\n 'Path' => path,","path":"lib/fog/aws/requests/iam/create_user.rb","position":9,"original_position":9,"commit_id":"e0e01816df9db553030a0aba97575a78264cdce0","original_commit_id":"e0e01816df9db553030a0aba97575a78264cdce0","user":{"login":"pcarrier","id":8641,"avatar_url":"https://secure.gravatar.com/avatar/a015a01b545b3861cb315bae98e44d1c?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"a015a01b545b3861cb315bae98e44d1c","url":"https://api.github.com/users/pcarrier","html_url":"https://github.com/pcarrier","followers_url":"https://api.github.com/users/pcarrier/followers","following_url":"https://api.github.com/users/pcarrier/following","gists_url":"https://api.github.com/users/pcarrier/gists{/gist_id}","starred_url":"https://api.github.com/users/pcarrier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pcarrier/subscriptions","organizations_url":"https://api.github.com/users/pcarrier/orgs","repos_url":"https://api.github.com/users/pcarrier/repos","events_url":"https://api.github.com/users/pcarrier/events{/privacy}","received_events_url":"https://api.github.com/users/pcarrier/received_events","type":"User"},"created_at":"2013-04-25T20:18:59Z","updated_at":"2013-04-25T20:18:59Z","html_url":"https://github.com/fog/fog/pull/1779#discussion_r3965559","pull_request_url":"https://api.github.com/repos/fog/fog/pulls/1779","_links":{"self":{"href":"https://api.github.com/repos/fog/fog/pulls/comments/3965559"},"html":{"href":"https://github.com/fog/fog/pull/1779#discussion_r3965559"},"pull_request":{"href":"https://api.github.com/repos/fog/fog/pulls/1779"}}}} | {
"id": 203666,
"name": "fog",
"url": "https://github.com/fog/fog"
} | {
"id": null,
"login": "pcarrier",
"gravatar_id": "a015a01b545b3861cb315bae98e44d1c",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "fog",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-04-25T20:18:59 | null | {"repository":{"description":"The Ruby cloud services library.","homepage":"http://fog.io","watchers":2480,"stargazers":2480,"forks":767,"fork":false,"size":1524,"owner":"fog","private":false,"open_issues":4,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Ruby","created_at":"2009-05-18T00:14:04-07:00","pushed_at":"2013-04-24T12:26:37-07:00","integrate_branch":"master","master_branch":"master","organization":"fog"},"actor_attributes":{"type":"User","name":"⨵⫝⨴","company":"Airbnb","blog":"http://gcarrier.fr/","location":"San Francisco","email":"[email protected]"},"url":"https://github.com/fog/fog/pull/1779#discussion_r3965559"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/gem/oq-engine/pulls/comments/3768191","id":3768191,"body":"What about ```GMFScenario```?","diff_hunk":"@@ -29,89 +30,210 @@\n from tests.utils import helpers\n \n \n-class UtilsTestCase(unittest.TestCase):\n+class GetResultExportPathTestCase(unittest.TestCase):\n \n def setUp(self):\n- class FakeLtRealization(object):\n- def __init__(self, gsim_lt_path):\n- self.gsim_lt_path = gsim_lt_path\n-\n- class FakeResult(object):\n- def __init__(self, lt_realization, imt, sa_period):\n- self.lt_realization = lt_realization\n- self.imt = imt\n- self.sa_period = sa_period\n+ self.FakeHazardCurve = namedtuple(\n+ 'HazardCurve',\n+ 'output, lt_realization, imt, sa_period, statistics, quantile'\n+ )\n+ self.FakeHazardMap = namedtuple(\n+ 'HazardMap',\n+ 'output, lt_realization, imt, sa_period, statistics, quantile'\n+ )\n+ self.FakeUHS = namedtuple(\n+ 'UHS',\n+ 'output, lt_realization, statistics, quantile'\n+ )\n+ self.FakeDisagg = namedtuple(\n+ 'Disagg',\n+ 'output, lt_realization, imt, sa_period'\n+ )\n+ self.FakeGMF = namedtuple(\n+ 'GMF',\n+ 'output, lt_realization'\n+ )","path":"tests/export/hazard_test.py","position":44,"original_position":44,"commit_id":"238f3d09b359181d2264d1afc44460d352bd5e11","original_commit_id":"238f3d09b359181d2264d1afc44460d352bd5e11","user":{"login":"matley","id":37626,"avatar_url":"https://secure.gravatar.com/avatar/666e5fb784d24139e15e6902c901ebb6?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"666e5fb784d24139e15e6902c901ebb6","url":"https://api.github.com/users/matley","html_url":"https://github.com/matley","followers_url":"https://api.github.com/users/matley/followers","following_url":"https://api.github.com/users/matley/following","gists_url":"https://api.github.com/users/matley/gists{/gist_id}","starred_url":"https://api.github.com/users/matley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matley/subscriptions","organizations_url":"https://api.github.com/users/matley/orgs","repos_url":"https://api.github.com/users/matley/repos","events_url":"https://api.github.com/users/matley/events{/privacy}","received_events_url":"https://api.github.com/users/matley/received_events","type":"User"},"created_at":"2013-04-12T08:09:07Z","updated_at":"2013-04-12T08:09:07Z","html_url":"https://github.com/gem/oq-engine/pull/1127#discussion_r3768191","pull_request_url":"https://api.github.com/repos/gem/oq-engine/pulls/1127","_links":{"self":{"href":"https://api.github.com/repos/gem/oq-engine/pulls/comments/3768191"},"html":{"href":"https://github.com/gem/oq-engine/pull/1127#discussion_r3768191"},"pull_request":{"href":"https://api.github.com/repos/gem/oq-engine/pulls/1127"}}}} | {
"id": 744916,
"name": "oq-engine",
"url": "https://github.com/gem/oq-engine"
} | {
"id": null,
"login": "matley",
"gravatar_id": "666e5fb784d24139e15e6902c901ebb6",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "gem",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-04-12T08:09:07 | null | {"repository":{"description":"OpenQuake's Engine for Seismic Hazard and Risk Analysis","homepage":"openquake.org","watchers":48,"stargazers":48,"forks":35,"fork":false,"size":7012,"owner":"gem","private":false,"open_issues":5,"has_issues":false,"has_downloads":true,"has_wiki":true,"language":"Python","created_at":"2010-06-28T07:59:42-07:00","pushed_at":"2013-04-11T23:49:14-07:00","master_branch":"master","organization":"gem"},"actor_attributes":{"type":"User","name":"Luigi Panzeri","location":"Pavia, Italy","email":"[email protected]"},"url":"https://github.com/gem/oq-engine/pull/1127#discussion_r3768191"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/opf/openproject/pulls/comments/4917746","id":4917746,"body":"Assuming you didn't remove the \"Reason\" => \"login needed\" on purpose, I'd suggest this code\r\n```ruby\r\nauthentication_scheme = if request.headers[\"X-ACCEPT-AUTH\"] == \"Session\"\r\n 'Session' else 'Basic'\r\nend\r\nformat.any(:xml, :js, :json) { head :unauthorized,\r\n \"Reason\" => \"login needed\",\r\n 'WWW-Authenticate' => authentication_scheme + ' realm=\"OpenProject API\"' }\r\n```","diff_hunk":"@@ -173,7 +173,12 @@ def require_login\n end\n respond_to do |format|\n format.any(:html, :atom) { redirect_to signin_path(:back_url => url) }\n- format.any(:xml, :js, :json) { head :unauthorized, \"Reason\" => \"login needed\" }\n+\n+ if request.headers[\"X-ACCEPT-AUTH\"] == \"Session\"\n+ format.any(:xml, :js, :json) { head :unauthorized, \"Reason\" => \"login needed\", 'WWW-Authenticate' => 'Session realm=\"OpenProject API\"' }\n+ else\n+ format.any(:xml, :js, :json) { head :unauthorized, 'WWW-Authenticate' => 'Basic realm=\"OpenProject API\"' }\n+ end","path":"app/controllers/application_controller.rb","position":10,"original_position":10,"commit_id":"90edb0db47d3dfab72389a27ec99f6c802c406b0","original_commit_id":"90edb0db47d3dfab72389a27ec99f6c802c406b0","user":{"login":"meeee","id":188986,"avatar_url":"https://secure.gravatar.com/avatar/3b5775a857876c4d7c229e4874518bfc?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"3b5775a857876c4d7c229e4874518bfc","url":"https://api.github.com/users/meeee","html_url":"https://github.com/meeee","followers_url":"https://api.github.com/users/meeee/followers","following_url":"https://api.github.com/users/meeee/following{/other_user}","gists_url":"https://api.github.com/users/meeee/gists{/gist_id}","starred_url":"https://api.github.com/users/meeee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meeee/subscriptions","organizations_url":"https://api.github.com/users/meeee/orgs","repos_url":"https://api.github.com/users/meeee/repos","events_url":"https://api.github.com/users/meeee/events{/privacy}","received_events_url":"https://api.github.com/users/meeee/received_events","type":"User"},"created_at":"2013-06-27T15:13:41Z","updated_at":"2013-06-27T15:13:41Z","html_url":"https://github.com/opf/openproject/pull/209#discussion_r4917746","pull_request_url":"https://api.github.com/repos/opf/openproject/pulls/209","_links":{"self":{"href":"https://api.github.com/repos/opf/openproject/pulls/comments/4917746"},"html":{"href":"https://github.com/opf/openproject/pull/209#discussion_r4917746"},"pull_request":{"href":"https://api.github.com/repos/opf/openproject/pulls/209"}}}} | {
"id": 6899875,
"name": "openproject",
"url": "https://github.com/opf/openproject"
} | {
"id": null,
"login": "meeee",
"gravatar_id": "3b5775a857876c4d7c229e4874518bfc",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "opf",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-06-27T15:13:41 | null | {"repository":{"description":"OpenProject is a web based project management system built on Ruby on Rails","homepage":"https://openproject.org","watchers":28,"stargazers":28,"forks":29,"fork":false,"size":3012,"owner":"opf","private":false,"open_issues":0,"has_issues":false,"has_downloads":true,"has_wiki":false,"language":"Ruby","created_at":"2012-11-28T01:59:11-08:00","pushed_at":"2013-06-27T07:59:21-07:00","master_branch":"feature/rails3","organization":"opf"},"actor_attributes":{"type":"User","name":"","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/opf/openproject/pull/209#discussion_r4917746"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/pry/pry/pulls/comments/8262835","id":8262835,"diff_hunk":"@@ -62,12 +62,25 @@\n meth.should == nil\n end\n \n- it 'should look up methods using klass.new.method syntax' do\n+ it 'should look up methods using klass.new.method syntax' do\n klass = Class.new { def hello; :hello; end }\n meth = Pry::Method.from_str(\"klass.new.hello\", Pry.binding_for(binding))\n meth.name.should == \"hello\"\n end\n \n+ it 'should take care of corner cases like mongo[] e.g Foo::Bar.new[]- issue 998' do\n+ klass = Class.new { def []; :hello; end }\n+ meth = Pry::Method.from_str(\"klass.new[]\", Pry.binding_for(binding))\n+ meth.name.should == \"[]\"\n+ end\n+\n+ it 'should take care of cases like $ mongo[] - issue 998' do\n+ f = Class.new { def []; :hello; end }\n+ binding.eval(\"f = {}\")","path":"spec/method_spec.rb","position":19,"original_position":19,"commit_id":"24ab88a307ba74b6b82d33995519a08fe50b3821","original_commit_id":"24ab88a307ba74b6b82d33995519a08fe50b3821","user":{"login":"robgleeson","id":77573,"avatar_url":"https://1.gravatar.com/avatar/22ca530c1db575f0a62b68c1900d8399?d=https%3A%2F%2Fidenticons.github.com%2Fdd6787e41fe18b1f6364c10ac07384f0.png&r=x","gravatar_id":"22ca530c1db575f0a62b68c1900d8399","url":"https://api.github.com/users/robgleeson","html_url":"https://github.com/robgleeson","followers_url":"https://api.github.com/users/robgleeson/followers","following_url":"https://api.github.com/users/robgleeson/following{/other_user}","gists_url":"https://api.github.com/users/robgleeson/gists{/gist_id}","starred_url":"https://api.github.com/users/robgleeson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robgleeson/subscriptions","organizations_url":"https://api.github.com/users/robgleeson/orgs","repos_url":"https://api.github.com/users/robgleeson/repos","events_url":"https://api.github.com/users/robgleeson/events{/privacy}","received_events_url":"https://api.github.com/users/robgleeson/received_events","type":"User","site_admin":false},"body":"ahhh, I see the problem!\r\nplease say, `f = Class.new { def []; :hello; end }.new` instead. ","created_at":"2013-12-11T11:00:13Z","updated_at":"2013-12-11T11:00:13Z","html_url":"https://github.com/pry/pry/pull/1039#discussion_r8262835","pull_request_url":"https://api.github.com/repos/pry/pry/pulls/1039","_links":{"self":{"href":"https://api.github.com/repos/pry/pry/pulls/comments/8262835"},"html":{"href":"https://github.com/pry/pry/pull/1039#discussion_r8262835"},"pull_request":{"href":"https://api.github.com/repos/pry/pry/pulls/1039"}}}} | {
"id": 1145832,
"name": "pry",
"url": "https://github.com/pry/pry"
} | {
"id": null,
"login": "robgleeson",
"gravatar_id": "22ca530c1db575f0a62b68c1900d8399",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "pry",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-12-11T11:00:13 | null | {"repository":{"description":"An IRB alternative and runtime developer console","homepage":"","watchers":2461,"stargazers":2461,"forks":209,"fork":false,"size":21327,"owner":"pry","private":false,"open_issues":90,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Ruby","created_at":"2010-12-07T00:10:47-08:00","pushed_at":"2013-12-09T13:28:21-08:00","master_branch":"master","organization":"pry"},"actor_attributes":{"type":"User","name":"Robert","company":"","blog":"","location":"Leiden, Netherlands","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/pry/pry/pull/1039#discussion_r8262835"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/ros/rosdistro/pulls/comments/4929262","id":4929262,"body":"`status:` has to go after `packages:` but before `tags:`","diff_hunk":"@@ -118,6 +118,7 @@ repositories:\n release: release/hydro/{package}/{version}\n url: https://github.com/ros-gbp/control_toolbox-release.git\n version: 1.10.1-0\n+ status: maintained","path":"hydro/release.yaml","position":4,"original_position":4,"commit_id":"6bea7eab45d4fe81a9d903944054ee2b018e2667","original_commit_id":"6bea7eab45d4fe81a9d903944054ee2b018e2667","user":{"login":"wjwwood","id":100427,"avatar_url":"https://secure.gravatar.com/avatar/e9b7130c915ff71c0812d99ff927e929?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"e9b7130c915ff71c0812d99ff927e929","url":"https://api.github.com/users/wjwwood","html_url":"https://github.com/wjwwood","followers_url":"https://api.github.com/users/wjwwood/followers","following_url":"https://api.github.com/users/wjwwood/following{/other_user}","gists_url":"https://api.github.com/users/wjwwood/gists{/gist_id}","starred_url":"https://api.github.com/users/wjwwood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wjwwood/subscriptions","organizations_url":"https://api.github.com/users/wjwwood/orgs","repos_url":"https://api.github.com/users/wjwwood/repos","events_url":"https://api.github.com/users/wjwwood/events{/privacy}","received_events_url":"https://api.github.com/users/wjwwood/received_events","type":"User"},"created_at":"2013-06-27T23:13:21Z","updated_at":"2013-06-27T23:13:21Z","html_url":"https://github.com/ros/rosdistro/pull/1111#discussion_r4929262","pull_request_url":"https://api.github.com/repos/ros/rosdistro/pulls/1111","_links":{"self":{"href":"https://api.github.com/repos/ros/rosdistro/pulls/comments/4929262"},"html":{"href":"https://github.com/ros/rosdistro/pull/1111#discussion_r4929262"},"pull_request":{"href":"https://api.github.com/repos/ros/rosdistro/pulls/1111"}}}} | {
"id": 3149845,
"name": "rosdistro",
"url": "https://github.com/ros/rosdistro"
} | {
"id": null,
"login": "wjwwood",
"gravatar_id": "e9b7130c915ff71c0812d99ff927e929",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "ros",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-06-27T23:13:21 | null | {"repository":{"description":"A list of repos to build into debians","homepage":"","watchers":65,"stargazers":65,"forks":226,"fork":false,"size":3776,"owner":"ros","private":false,"open_issues":7,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Python","created_at":"2012-01-10T16:13:17-08:00","pushed_at":"2013-06-27T15:37:26-07:00","master_branch":"master","organization":"ros"},"actor_attributes":{"type":"User","name":"William Woodall","company":"Willow Garage","blog":"wjwwood.github.com","location":"Menlo Park, CA","email":"[email protected]"},"url":"https://github.com/ros/rosdistro/pull/1111#discussion_r4929262"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/sbt/sbt-native-packager/pulls/comments/7854649","id":7854649,"diff_hunk":"@@ -42,26 +42,79 @@ object JavaServerAppPackaging {\n debianMakePrermScript <<= (normalizedName, target in Universal) map makeDebianPrermScript,\n debianMakePostinstScript <<= (normalizedName, target in Universal) map makeDebianPostinstScript)\n \n- private[this] final def makeDebianPrermScript(name: String, tmpDir: File): Option[File] = {\n+\n+ private def makeDebianUpstartScript(replacements: Seq[(String, String)], name: String, tmpDir: File): Option[File] =\n+ if (replacements.isEmpty) None\n+ else {\n+ val scriptBits = JavaAppUpstartScript.generateScript(replacements)\n+ val script = tmpDir / \"tmp\" / \"bin\" / (name + \".conf\")\n+ IO.write(script, scriptBits)\n+ Some(script)\n+ }\n+}\n+\n+\n+object JavaServerAppSysVinitPackaging extends JavaServerAppPackaging {\n+\n+ def settings: Seq[Setting[_]] =\n+ JavaAppPackaging.settings ++ debianSysVinitSettings\n+\n+ def debianSysVinitSettings: Seq[Setting[_]] = {\n+ Seq(\n+ debianSysVinitScriptReplacements <<= (maintainer in Debian, packageSummary in Debian, daemonUser in Debian,\n+ normalizedName, name, sbt.Keys.version, defaultLinuxInstallLocation, sbt.Keys.mainClass in Compile, scriptClasspath)\n+ map { (author, descr, daemonUser, normalizedName, name, version, installLocation, mainClass, cp) =>\n+ // TODO name-version is copied from UniversalPlugin. This should be consolidated into a setting (install location...)\n+ val appDir = installLocation + \"/\" + normalizedName\n+ val appClasspath = cp.map(appDir + \"/lib/\" + _).mkString(\":\")\n+\n+ JavaAppSysVinitScript.makeReplacements(\n+ author = author, description = descr,\n+ appDir = appDir,\n+ appName = name,\n+ appClasspath = appClasspath,\n+ appMainClass = mainClass.get,\n+ daemonUser = daemonUser\n+ )\n+ },\n+ debianMakeSysVinitScript <<= (debianSysVinitScriptReplacements, normalizedName, target in Universal) map makeDebianSysVinitScript,\n+ linuxPackageMappings in Debian <++= (debianMakeSysVinitScript, normalizedName) map { (script, name) =>\n+ for {\n+ s <- script.toSeq\n+ } yield LinuxPackageMapping(Seq(s -> (\"/etc/init.d/\" + name))).withPerms(\"0755\")\n+ },\n+ // TODO - only make these if the upstart config exists...\n+ debianMakePrermScript <<= (normalizedName, target in Universal) map makeDebianPrermScript,\n+ debianMakePostinstScript <<= (normalizedName, target in Universal) map makeDebianPostinstScript)\n+ }\n+\n+\n+ private def makeDebianSysVinitScript(replacements: Seq[(String, String)], name: String, tmpDir: File): Option[File] =","path":"src/main/scala/com/typesafe/sbt/packager/archetypes/JavaServerApplication.scala","position":61,"original_position":61,"commit_id":"c1a927ffbb6f02a5caadc44120e63066373e856b","original_commit_id":"c1a927ffbb6f02a5caadc44120e63066373e856b","user":{"login":"jsuereth","id":29006,"avatar_url":"https://1.gravatar.com/avatar/5ed293320c06809a24812f56861201ad?d=https%3A%2F%2Fidenticons.github.com%2F11a5b5ef81cff76a0a1f3d042f635df3.png&r=x","gravatar_id":"5ed293320c06809a24812f56861201ad","url":"https://api.github.com/users/jsuereth","html_url":"https://github.com/jsuereth","followers_url":"https://api.github.com/users/jsuereth/followers","following_url":"https://api.github.com/users/jsuereth/following{/other_user}","gists_url":"https://api.github.com/users/jsuereth/gists{/gist_id}","starred_url":"https://api.github.com/users/jsuereth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsuereth/subscriptions","organizations_url":"https://api.github.com/users/jsuereth/orgs","repos_url":"https://api.github.com/users/jsuereth/repos","events_url":"https://api.github.com/users/jsuereth/events{/privacy}","received_events_url":"https://api.github.com/users/jsuereth/received_events","type":"User","site_admin":false},"body":"Are their differences between System V init scripts in rpm vs. debian that would not let us re-use this mechanism?","created_at":"2013-11-22T12:38:59Z","updated_at":"2013-11-22T12:38:59Z","html_url":"https://github.com/sbt/sbt-native-packager/pull/85#discussion_r7854649","pull_request_url":"https://api.github.com/repos/sbt/sbt-native-packager/pulls/85","_links":{"self":{"href":"https://api.github.com/repos/sbt/sbt-native-packager/pulls/comments/7854649"},"html":{"href":"https://github.com/sbt/sbt-native-packager/pull/85#discussion_r7854649"},"pull_request":{"href":"https://api.github.com/repos/sbt/sbt-native-packager/pulls/85"}}}} | {
"id": 3016640,
"name": "sbt-native-packager",
"url": "https://github.com/sbt/sbt-native-packager"
} | {
"id": null,
"login": "jsuereth",
"gravatar_id": "5ed293320c06809a24812f56861201ad",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "sbt",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-11-22T12:38:59 | null | {"repository":{"description":"","homepage":"","watchers":111,"stargazers":111,"forks":41,"fork":false,"size":1351,"owner":"sbt","private":false,"open_issues":20,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Scala","created_at":"2011-12-19T18:04:49-08:00","pushed_at":"2013-11-20T06:25:02-08:00","master_branch":"master","organization":"sbt"},"actor_attributes":{"type":"User","name":"Josh Suereth","company":"Typesafe, Inc.","blog":"http://suereth.blogspot.com","location":"Pittsburgh, PA","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/sbt/sbt-native-packager/pull/85#discussion_r7854649"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/sbt/sbt-native-packager/pulls/comments/8436739","id":8436739,"diff_hunk":"@@ -62,9 +62,13 @@ object JavaServerAppPackaging {\n s <- script.toSeq\n } yield LinuxPackageMapping(Seq(s -> path)).withPerms(permissions)\n },\n- // TODO the /var/log should be generalized like defaultLinuxInstallLocation\n- linuxPackageMappings in Debian <+= (normalizedName) map {\n- name => packageTemplateMapping(\"/var/log/\" + name)()\n+ // TODO should we specify daemonGroup in configs?\n+ linuxPackageMappings in Debian <+= (normalizedName, defaultLinuxLogsLocation, target in Debian, daemonUser in Debian) map {\n+ (name, logsDir, target, user) =>\n+ // create empty var/log directory\n+ val d = target / logsDir\n+ d.mkdirs()\n+ LinuxPackageMapping(Seq(d -> s\"$logsDir/$name\"), LinuxFileMetaData(user, user))","path":"src/main/scala/com/typesafe/sbt/packager/archetypes/JavaServerApplication.scala","position":13,"original_position":13,"commit_id":"474c98f4a9b86c26e1000ff629ebf868446baa4d","original_commit_id":"474c98f4a9b86c26e1000ff629ebf868446baa4d","user":{"login":"kardapoltsev","id":1115466,"avatar_url":"https://gravatar.com/avatar/4138675e32b06c0e80b697a351980bdd?d=https%3A%2F%2Fidenticons.github.com%2F84f96edcab92083a4a89f42d2513d261.png&r=x","gravatar_id":"4138675e32b06c0e80b697a351980bdd","url":"https://api.github.com/users/kardapoltsev","html_url":"https://github.com/kardapoltsev","followers_url":"https://api.github.com/users/kardapoltsev/followers","following_url":"https://api.github.com/users/kardapoltsev/following{/other_user}","gists_url":"https://api.github.com/users/kardapoltsev/gists{/gist_id}","starred_url":"https://api.github.com/users/kardapoltsev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kardapoltsev/subscriptions","organizations_url":"https://api.github.com/users/kardapoltsev/orgs","repos_url":"https://api.github.com/users/kardapoltsev/repos","events_url":"https://api.github.com/users/kardapoltsev/events{/privacy}","received_events_url":"https://api.github.com/users/kardapoltsev/received_events","type":"User","site_admin":false},"body":"I don't know much about RPM. But I could check this tomorrow.\r\n","created_at":"2013-12-18T14:19:02Z","updated_at":"2013-12-18T14:19:02Z","html_url":"https://github.com/sbt/sbt-native-packager/pull/111#discussion_r8436739","pull_request_url":"https://api.github.com/repos/sbt/sbt-native-packager/pulls/111","_links":{"self":{"href":"https://api.github.com/repos/sbt/sbt-native-packager/pulls/comments/8436739"},"html":{"href":"https://github.com/sbt/sbt-native-packager/pull/111#discussion_r8436739"},"pull_request":{"href":"https://api.github.com/repos/sbt/sbt-native-packager/pulls/111"}}}} | {
"id": 3016640,
"name": "sbt-native-packager",
"url": "https://github.com/sbt/sbt-native-packager"
} | {
"id": null,
"login": "kardapoltsev",
"gravatar_id": "4138675e32b06c0e80b697a351980bdd",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "sbt",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-12-18T14:19:02 | null | {"repository":{"description":"","homepage":"","watchers":123,"stargazers":123,"forks":46,"fork":false,"size":1430,"owner":"sbt","private":false,"open_issues":1,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Scala","created_at":"2011-12-19T18:04:49-08:00","pushed_at":"2013-12-18T06:11:57-08:00","master_branch":"master","organization":"sbt"},"actor_attributes":{"type":"User","name":"Alexey Kardapoltsev","company":"frumatic","location":"Russia, Ufa","email":"[email protected]"},"url":"https://github.com/sbt/sbt-native-packager/pull/111#discussion_r8436739"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/ufz/ogs/pulls/comments/7394776","id":7394776,"diff_hunk":"@@ -0,0 +1,153 @@\n+/**\n+ * @file TestMeshNodeSearch.cpp\n+ * @author git blame TestMeshNodeSearch.cpp\n+ * @date Oct 28, 2013\n+ * @brief Test the implementation of class MeshNodeSearch.\n+ *\n+ * @copyright\n+ * Copyright (c) 2013, OpenGeoSys Community (http://www.opengeosys.org)\n+ * Distributed under a Modified BSD License.\n+ * See accompanying file LICENSE.txt or\n+ * http://www.opengeosys.org/LICENSE.txt\n+ */\n+\n+#include \"gtest/gtest.h\"\n+\n+#include \"Mesh.h\"\n+#include \"MeshGenerators/MeshGenerator.h\"\n+#include \"MeshGeoToolsLib/MeshNodeSearcher.h\"\n+\n+using namespace MeshLib;\n+\n+class MeshLibMeshNodeSearchInSimpleQuadMesh : public testing::Test\n+{\n+public:\n+\tMeshLibMeshNodeSearchInSimpleQuadMesh() :\n+\t\t_geometric_size(10.0), _number_of_subdivisions_per_direction(99),\n+\t\t_quad_mesh(MeshGenerator::generateRegularQuadMesh(_geometric_size, _number_of_subdivisions_per_direction))\n+\t{}\n+\n+protected:\n+\tconst double _geometric_size;\n+\tconst std::size_t _number_of_subdivisions_per_direction;\n+\tMesh* _quad_mesh;\n+};\n+\n+TEST_F(MeshLibMeshNodeSearchInSimpleQuadMesh, PointSearch)\n+{\n+\tASSERT_TRUE(_quad_mesh != nullptr);\n+\t// 1 create a geometry\n+\tGeoLib::Point pnt(0.0, 0.0, 0.0);\n+\n+\t// 2 perform search and compare results with expected vals\n+\tMeshGeoTools::MeshNodeSearcher mesh_node_searcher(*_quad_mesh);\n+\n+\t// find ORIGIN\n+\tASSERT_EQ(0, mesh_node_searcher.getMeshNodeIDForPoint(pnt));\n+\n+\tpnt[0] = 0.049;\n+\tpnt[1] = 0.049;\n+\tASSERT_EQ(0, mesh_node_searcher.getMeshNodeIDForPoint(pnt));\n+\n+\tpnt[0] = 0.051;\n+\tpnt[1] = 0.049;\n+\tASSERT_EQ(1, mesh_node_searcher.getMeshNodeIDForPoint(pnt));\n+\n+\tpnt[0] = 0.049;\n+\tpnt[1] = 0.051;\n+\tASSERT_EQ(100, mesh_node_searcher.getMeshNodeIDForPoint(pnt));\n+\n+\tpnt[0] = 0.051;\n+\tpnt[1] = 0.051;\n+\tASSERT_EQ(101, mesh_node_searcher.getMeshNodeIDForPoint(pnt));\n+","path":"Tests/MeshLib/TestMeshNodeSearch.cpp","position":68,"original_position":63,"commit_id":"aaff7e3163bf3f069224a90c78c365bc49fa8a6e","original_commit_id":"83a5e68874a5c619eaa740efb696149214624eb3","user":{"login":"TomFischer","id":800065,"avatar_url":"https://0.gravatar.com/avatar/13a70d0b1f82a7f25da7219c34793892?d=https%3A%2F%2Fidenticons.github.com%2F08bf5319b4272683ce82c147a28cb668.png&r=x","gravatar_id":"13a70d0b1f82a7f25da7219c34793892","url":"https://api.github.com/users/TomFischer","html_url":"https://github.com/TomFischer","followers_url":"https://api.github.com/users/TomFischer/followers","following_url":"https://api.github.com/users/TomFischer/following{/other_user}","gists_url":"https://api.github.com/users/TomFischer/gists{/gist_id}","starred_url":"https://api.github.com/users/TomFischer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TomFischer/subscriptions","organizations_url":"https://api.github.com/users/TomFischer/orgs","repos_url":"https://api.github.com/users/TomFischer/repos","events_url":"https://api.github.com/users/TomFischer/events{/privacy}","received_events_url":"https://api.github.com/users/TomFischer/received_events","type":"User","site_admin":false},"body":"The id of the first node that is found is returned.","created_at":"2013-11-04T07:34:18Z","updated_at":"2013-11-04T07:34:18Z","html_url":"https://github.com/ufz/ogs/pull/251#discussion_r7394776","pull_request_url":"https://api.github.com/repos/ufz/ogs/pulls/251","_links":{"self":{"href":"https://api.github.com/repos/ufz/ogs/pulls/comments/7394776"},"html":{"href":"https://github.com/ufz/ogs/pull/251#discussion_r7394776"},"pull_request":{"href":"https://api.github.com/repos/ufz/ogs/pulls/251"}}}} | {
"id": 1701384,
"name": "ogs",
"url": "https://github.com/ufz/ogs"
} | {
"id": null,
"login": "TomFischer",
"gravatar_id": "13a70d0b1f82a7f25da7219c34793892",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "ufz",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-11-04T07:34:18 | null | {"repository":{"description":"OGS source code","homepage":"www.opengeosys.org","watchers":12,"stargazers":12,"forks":19,"fork":false,"size":7925,"owner":"ufz","private":false,"open_issues":2,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"C++","created_at":"2011-05-04T07:09:57-07:00","pushed_at":"2013-11-03T06:19:06-08:00","master_branch":"master","organization":"ufz"},"actor_attributes":{"type":"User","name":"Tom Fischer","location":"Leipzig","email":"[email protected]"},"url":"https://github.com/ufz/ogs/pull/251#discussion_r7394776"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/ufz/ogs/pulls/comments/3053769","id":3053769,"body":"std::size_t?","path":"GeoLib/Polyline.cpp","position":12,"original_position":12,"commit_id":"73ab9cf567830737be1a462c263082f99e5916a7","original_commit_id":"73ab9cf567830737be1a462c263082f99e5916a7","user":{"login":"norihiro-w","id":800408,"avatar_url":"https://secure.gravatar.com/avatar/48dbb4167ba59bcbbc83427b10449404?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"48dbb4167ba59bcbbc83427b10449404","url":"https://api.github.com/users/norihiro-w","html_url":"https://github.com/norihiro-w","followers_url":"https://api.github.com/users/norihiro-w/followers","following_url":"https://api.github.com/users/norihiro-w/following","gists_url":"https://api.github.com/users/norihiro-w/gists{/gist_id}","starred_url":"https://api.github.com/users/norihiro-w/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/norihiro-w/subscriptions","organizations_url":"https://api.github.com/users/norihiro-w/orgs","repos_url":"https://api.github.com/users/norihiro-w/repos","events_url":"https://api.github.com/users/norihiro-w/events{/privacy}","received_events_url":"https://api.github.com/users/norihiro-w/received_events","type":"User"},"created_at":"2013-02-18T21:06:48Z","updated_at":"2013-02-18T21:06:48Z","_links":{"self":{"href":"https://api.github.com/repos/ufz/ogs/pulls/comments/3053769"},"html":{"href":"https://github.com/ufz/ogs/pull/83#discussion_r3053769"},"pull_request":{"href":"https://api.github.com/repos/ufz/ogs/pulls/83"}}}} | {
"id": 1701384,
"name": "ogs",
"url": "https://github.com/ufz/ogs"
} | {
"id": null,
"login": "norihiro-w",
"gravatar_id": "48dbb4167ba59bcbbc83427b10449404",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "ufz",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-02-18T21:06:48 | null | {"repository":{"description":"OGS source code","homepage":"www.opengeosys.org","watchers":12,"stargazers":12,"forks":17,"fork":false,"size":1052,"owner":"ufz","private":false,"open_issues":2,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"C++","created_at":"2011-05-04T07:09:57-07:00","pushed_at":"2013-02-15T02:58:33-08:00","master_branch":"master","organization":"ufz"},"actor_attributes":{"name":"Norihiro Watanabe","company":"Helmholtz Centre for Environmental Research - UFZ","location":"Leipzig","type":"User","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/ufz/ogs/pull/83#discussion_r3053769"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/w3c/web-platform-tests/pulls/comments/6662344","id":6662344,"body":"I reviewed this test and found no issues.","diff_hunk":"@@ -0,0 +1,63 @@\n+<!DOCTYPE html>\n+<title>Enumeration types</title>\n+<script src=\"http://w3c-test.org/resources/testharness.js\"></script>\n+<script src=\"http://w3c-test.org/resources/testharnessreport.js\"></script>\n+<script src=\"utils.js\"></script>\n+<div id=\"log\"></div>\n+\n+<div id=\"evenodd\" class=\"evenodd\"></div>\n+\n+<script>\n+// 4.2.20 Enumeration types\n+//","path":"WebIDL/tests/submissions/heycam/enum-type-001.html","position":12,"original_position":12,"commit_id":"c1c6cd373d8a1d73e717000767738fe33fdf223f","original_commit_id":"c1c6cd373d8a1d73e717000767738fe33fdf223f","user":{"login":"AFBarstow","id":662425,"avatar_url":"https://1.gravatar.com/avatar/473a1795f68c96a186ca8a93a318169b?d=https%3A%2F%2Fidenticons.github.com%2Fd4bc4336e9d77518fbfbfc8584f097de.png","gravatar_id":"473a1795f68c96a186ca8a93a318169b","url":"https://api.github.com/users/AFBarstow","html_url":"https://github.com/AFBarstow","followers_url":"https://api.github.com/users/AFBarstow/followers","following_url":"https://api.github.com/users/AFBarstow/following{/other_user}","gists_url":"https://api.github.com/users/AFBarstow/gists{/gist_id}","starred_url":"https://api.github.com/users/AFBarstow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AFBarstow/subscriptions","organizations_url":"https://api.github.com/users/AFBarstow/orgs","repos_url":"https://api.github.com/users/AFBarstow/repos","events_url":"https://api.github.com/users/AFBarstow/events{/privacy}","received_events_url":"https://api.github.com/users/AFBarstow/received_events","type":"User"},"created_at":"2013-09-30T16:17:39Z","updated_at":"2013-09-30T16:17:39Z","html_url":"https://github.com/w3c/web-platform-tests/pull/271#discussion_r6662344","pull_request_url":"https://api.github.com/repos/w3c/web-platform-tests/pulls/271","_links":{"self":{"href":"https://api.github.com/repos/w3c/web-platform-tests/pulls/comments/6662344"},"html":{"href":"https://github.com/w3c/web-platform-tests/pull/271#discussion_r6662344"},"pull_request":{"href":"https://api.github.com/repos/w3c/web-platform-tests/pulls/271"}}}} | {
"id": 3618133,
"name": "web-platform-tests",
"url": "https://github.com/w3c/web-platform-tests"
} | {
"id": null,
"login": "AFBarstow",
"gravatar_id": "473a1795f68c96a186ca8a93a318169b",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "w3c",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-09-30T16:17:39 | null | {"repository":{"description":"Test Suites for Web Platform specifications","homepage":"","watchers":174,"stargazers":174,"forks":240,"fork":false,"size":51683,"owner":"w3c","private":false,"open_issues":5,"has_issues":true,"has_downloads":true,"has_wiki":false,"language":"JavaScript","created_at":"2012-03-04T04:58:11-08:00","pushed_at":"2013-09-30T04:08:58-07:00","master_branch":"master","organization":"w3c"},"actor_attributes":{"type":"User","name":"Arthur Barstow","email":"[email protected]"},"url":"https://github.com/w3c/web-platform-tests/pull/271#discussion_r6662344"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/KAUG/angular.js/pulls/comments/4488254","id":4488254,"body":"기능성 -> 기능","diff_hunk":"@@ -4,217 +4,212 @@\n \n #FAQ\n \n+## 질문\n ## Questions\n \n-### Why is this project called \"AngularJS\"? Why is the namespace called \"ng\"?\n+### 왜 이 프로젝트는 \"AngularJS\"라고 불리는겁니까? 왜 네임스페이스(namespace)는 \"ng\"라고 불리나요?\n \n-Because HTML has Angular brackets and \"ng\" sounds like \"Angular\".\n+HTML는 Angular(모난) 괄호를 가지고 있고, \"ng\"발음이 \"Angular\"와 비슷하기 때문입니다.\n \n \n-### Is AngularJS a library, framework, plugin or a browser extension?\n+### AngularJS는 라이브러리 인가요? 아니면 프레임웍? 플러그인? 아니면 브라우저 익스텐션(browser extension)인가요?\n \n-AngularJS fits the definition of a framework the best, even though it's much more lightweight than\n-a typical framework and that's why many confuse it with a library.\n+일반적인 프레임웍보다 좀 더 많이 가볍기 때문에, 라이브러리라고 많이들 혼란스러워 하지만, AngularJS는 프레임웍의 정의와 가장 잘 들어맞는다고 하겠습니다.\n \n-AngularJS is 100% JavaScript, 100% client side and compatible with both desktop and mobile browsers.\n-So it's definitely not a plugin or some other native browser extension.\n+AngularJS는 100% 자바스크립트이며, 100% 클라이언트 사이드입니다. 또한, 데스크탑과 모바일 브라우저에 모두 호환가능합니다.\n+따라서, AngularJS는 명확하게 플러그인 또는 다른 어떤 네이티브(native) 브라우저 익스텐션도 아닙니다.\n \n \n-### Is AngularJS a templating system?\n+### AngularJS는 템플릿을 만드는 시스템인가요?\n \n-At the highest level, Angular does look like a just another templating system. But there is one\n-important reason why the Angular templating system is different, that makes it very good fit for\n-application development: bidirectional data binding. The template is compiled in the browser and\n-the compilation step produces a live view. This means you, the developers, don't need to write\n-code to constantly sync the view with the model and the model with the view as in other\n-templating systems.\n+최상 레벨(level)에서는, Angular가 단지 또 다른 하나의 템플릿 시스템으로 보이기도 합니다. 하지만, Angular템플릿 시스템이 템플릿이 아닌 중요한 이유가\n+있습니다. 이는 어플리케이션 개발(application development)에 매우 적합하다는 것입니다: 양방향 데이터 바인딩(bidirectional data binding).\n+템플릿은 브라우저에서 컴파일 됩니다. 그리고, 컴파일 과정은 라이브뷰(live view)를 만들어냅니다. 당신에게, 개발자로서 주는 의미는, 다른 템플릿 시스템에서와\n+같이 뷰(vioew)와 모델(model), 모델과 뷰를 연속적으로 동일하게 맞추기 위해서 코딩을 할 필요가 없다는 것입니다.\n \n \n-### Do I need to worry about security holes in AngularJS?\n+### AngularJS에서의 보안취약점(security holes)에 대해서 걱정해야 하나요?\n \n-Like any other technology, AngularJS is not impervious to attack. Angular does, however, provide\n-built-in protection from basic security holes including cross-site scripting and HTML injection\n-attacks. AngularJS does round-trip escaping on all strings for you and even offers XSRF protection\n-for server-side communication.\n+다른 어떤 기술들과 마찬가지로, AngularJS는 보안공격에 대해서 완벽하지는 않습니다. 그러나, Angular는 HTML 인젝션 공격(injection attacks)과\n+크로스사이트 스크립트(cross-site scripting)를 포함한 기초적인 보안취약으로부터 방어할 수 있는 내장 보안 시스템을 제공합니다. AngularJS는 모든 문자열에\n+대해서 왕복탈출(round-trip escaping)을 하고, 심지어 서버사이드 통신(communication)을 위해서 XSRF방어를 제공합니다.\n \n-AngularJS was designed to be compatible with other security measures like Content Security Policy\n-(CSP), HTTPS (SSL/TLS) and server-side authentication and authorization that greatly reduce the\n-possible attack vectors and we highly recommended their use.\n+AngularJS는 Content Security Policy(CSP), HTTPS (SSL/TLS) 그리고 서버사이드 입증, 또한 공격가능한 벡터(vectors)를 상당 수 줄여 줄 수 있는\n+인증과 같은, 다른 보안 방법들과 호환이 가능하도록 디자인 되었습니다. 그리고 이런 기능들을 사용하시길 강력히 추천하는 바입니다.\n \n \n-### Can I download the source, build, and host the AngularJS environment locally?\n+### 소스, 빌드를 다운 받을 수 있을까요? 그리고 AngularJS 환경을 로컬에서 호스트 할 수 있을까요?\n \n-Yes. See instructions in {@link downloading}.\n+네. {@link downloading}에서 지시서를 확인해보십시오.\n \n \n+### 어떤 브라우저들이 Angular작업이 가능한가요?\n \n-### What browsers does Angular work with?\n+저희는 Safari, Chrome, Firefox, Opera,IE8, IE9 그리고 모바일 브라우져(Android, Chrome Mobile, iOS Safari)와 같은 브라우저를 상대로\n+광범위한 적합 테스트(test suite)를 실시했습니다.\n \n-We run our extensive test suite against the following browsers: Safari, Chrome, Firefox, Opera,\n-IE8, IE9 and mobile browsers (Android, Chrome Mobile, iOS Safari).\n \n+### Angular성능은 어떻게 되나요?\n \n-### What's Angular's performance like?\n+초기시작(startup)시간은 네트워크 접속상태, 캐쉬(cashe)상태, 사용하는 브라우저, 사용가능한 하드웨어에 따라 상당히 달라집니다. 그러나, 일반적으로\n+붓스트랩(bootstrap)시간은 십여 밀리세컨(milliseconds) 에서 백여 밀리세컨까지로 측정됩니다.\n \n-The startup time heavily depends on your network connection, state of the cache, browser used and\n-available hardware, but typically we measure bootstrap time in tens or hundreds of milliseconds.\n+실시간(runtime)성능은 백엔드(backend)(백엔드로부터 데이터를 가져와야하는 앱의 경우)의 속도와 마찬가지로, 페이지에 사용한 바인딩(bindings)의 숫자와\n+복잡도에 상당한 영향을 받아 다양하게 변경될 것 입니다. 우리는 예증을 위해서, 대체적으로 백여개에서 천여개의 액티브 바인딩(active bindings)를 사용한 짤막한\n+앱을 빌드해봅니다.\n \n-The runtime performance will vary depending on the number and complexity of bindings on the page\n-as well as the speed of your backend (for apps that fetch data from the backend). Just for an\n-illustration we typically build snappy apps with hundreds or thousands of active bindings.\n+### 추가(include)해야할 angular.js파일이 얼마나 큰가요?\n \n+압축되고, 최소화된 파일 사이즈는 29KB 미만입니다.\n \n-### How big is the angular.js file that I need to include?\n \n-The size of the file is < 29KB compressed and minified.\n+### Angular와 함께 오픈소스 Closuer Library를 사용할 수 있나요?\n \n+네, {@link http://code.google.com/closure/library Closure Library}에서 Angular 위젯(widgets)를 사용하실 수 있습니다.\n \n-### Can I use the open-source Closure Library with Angular?\n+### Angular가 jQuery라이브러리를 사용하나요?\n \n-Yes, you can use widgets from the {@link http://code.google.com/closure/library Closure Library}\n-in Angular.\n+네. 어플리케이션이 붓스트랩할 때 앱 안에 라이브러리가 존재한다면 Angular는 {@link http://jquery.com/ jQuery}를 사용할 수 있습니다. 만약 당신의\n+스크립트 경로(script path)안에 jQuery가 존재하지 않으면 Angular는 우리가 {@link api/angular.element jQLite}라고 부르는 jQuery 서브셋(subset)\n+의 구현단을 대비책으로 사용할 것입니다.\n \n-### Does Angular use the jQuery library?\n \n-Yes, Angular can use {@link http://jquery.com/ jQuery} if it's present in your app when the\n-application is being bootstrapped. If jQuery is not present in your script path, Angular falls back\n-to its own implementation of the subset of jQuery that we call {@link api/angular.element jQLite}.\n+### Angular에서의 테스트가능성은 어떤가요?\n \n+기초단계부터 테스트가능하도록 디자인 되어있고, 매우 테스트 작업이 가능합니다. 매우 강력하게 독립적인 모의테스트(서버사이드 통신)를 제공하는 통합독립주입 프레임웍\n+(Integrated dependency injection framework)이 존재 합니다. 제세한 사항은 {@link api/ng service}를 참조하십시오.\n \n-### What is testability like in Angular?\n \n-Very testable and designed this way from ground up. It has an integrated dependency injection\n-framework, provides mocks for many heavy dependencies (server-side communication). See\n-{@link api/ng service} for details.\n+### 어떻게하면 Angular에 대해서 조금 더 배울 수 있을까요?\n \n-\n-### How can I learn more about Angular?\n-\n-Watch the July 17, 2012 talk\n+July 17, 2012 talk을 시청하십시오.\n \"{@link http://www.youtube.com/watch?v=1CpiB3Wk25U AngularJS Intro + Dependency Injection}\".\n \n \n-### How is Angular licensed?\n+### Angular는 어떤 라이센스입니까?\n+\n+MIT 라이센스 입니다.\n \n-The MIT License.\n+### Angular로고를 다운받고 사용할 수 있습니까?\n \n-### Can I download and use the Angular logo artwork?\n+네! \"{@link https://github.com/angular/angular.js/tree/master/images/logo angular.js/images/logo}\"아래, 저희 github 레포지토리에서\n+ 디자인 파일을 찾으실 수 있습니다.\n+그 로고 디자인은 \"{@link http://creativecommons.org/licenses/by-sa/3.0/Creative Commons Attribution-ShareAlike 3.0 Unported License}\"\n+라이센스 아래 제공됩니다. 만약 다른 사용처를 염두하신다면, 저희에게 연락주십시오.\n \n-Yes! You can find design files in our github repository, under \"{@link https://github.com/angular/angular.js/tree/master/images/logo \n-angular.js/images/logo}\"\n-The logo design is licensed under a \"{@link http://creativecommons.org/licenses/by-sa/3.0/ \n-Creative Commons Attribution-ShareAlike 3.0 Unported License}\". If you have some other use in mind, contact us.\n+### 어떻게 AngularJS 홍보품을 구할 수 있을까요?\n \n-### How can I get some AngularJS schwag?\n+저희가 참가하는 행사에는 종종 적은 양의 티셔츠와 스키터를 가지고 갑니다. 당신이 주문을 한다면, 저희 사은품 담당자는 현재 가지고 있는 템플렛을 사용하는 조건으로\n+ 당신을 위해 추가 생산작업을 기쁘게 임할 것입니다. 제작자들은 주문디자인을 파일로 가지고 있을 경우, 별도의 셋업 비용을 받지 않고 당신이 원하는 어떤 수량만큼\n+ 생산해 드릴 수 있습니다.\n \n-We often bring a few t-shirts and stickers to events where we're presenting. If you want to order your own, the folks who\n-make our schwag will be happy to do a custom run for you, based on our existing template. By using the design they have on file,\n-they'll waive the setup costs, and you can order any quantity you need.\n+**스티커**\n \n-**Stickers**\n-Contact Tom Witting (or anyone in sales) via email at [email protected], and tell him you want to order some AngularJS\n-stickers just like the ones in job #42711. You'll have to give them your own info for billing and shipping. \[email protected]로 이메일을 통하여 Tom Witting(또는 다른 영업부 직원)에게 연락하세요, 그리고 job #42711에 있는 것들과 같은 AngularJS\n+스키터를 주문하고 싶다고 말씀하세요.\n \n-As long as the design stays exactly the same, {@link http://www.stickergiant.com StickerGiant} will give you a reorder discount.\n+그 디자인이 같은 제품이라면 {@link http://www.stickergiant.com StickerGiant}에서 재 주문 할인을 드릴 겁니다.\n \n-**T-shirts**\n-Contact sales at {@link http://www.customink.com www.customink.com} and tell them you want some shirts with design name \"angularjs\",\n-just like past order #2106371. You'll have to give them your own info for billing and shipping.\n+**티셔츠**\n+{@link http://www.customink.com www.customink.com}를 통해서 영업부에 연락하세요 그리고 지난번 주문 번호 #2106371와 같이 \"angularjs\"이라\n+쓰인 디자인의 티셔츠를 원한다고 말씀하세요. 영수증발행과 배송을 위해 당신의 정보도 전달하셔야 할 것 입니다.\n \n-As long as the design stays exactly the same, CustomInk won't charge for any set up fees, and they'll give you a reorder discount.\n+그 디자인이 같은 제품이라면, CustomInk에서는 초기 셋팅 비용을 청구하지 않을 것이고, 재 주문 할인도 드릴 것 입니다.\n \n-## Common Pitfalls\n+## 일반적인 함정(Pitfalls)\n \n-The Angular support channel (#angularjs on Freenode) sees a number of recurring pitfalls that new users of Angular fall into.\n-This document aims to point them out before you discover them the hard way.\n+ Angular 지원채널(Freenode에서의 #angularjs)은 Angular 신규 사용자들이 반복해서 빠지고 있는 많은 함정을 알고 있습니다.\n+ 이 문서는 신규 사용자들이 어려움을 겪지 않도록 하는데 목적을 두고 있습니다.\n \n-### DOM Manipulation\n+### DOM 조작(Manipulation)\n \n-Stop trying to use jQuery to modify the DOM in controllers. Really.\n-That includes adding elements, removing elements, retrieving their contents, showing and hiding them.\n-Use built-in directives, or write your own where necessary, to do your DOM manipulation.\n-See below about duplicating functionality.\n+jQuery를 컨트롤러안의 DOM을 수정하는데 사용하는 것을 멈추십시오. 진짜로.\n+Angular는 엘리먼트(elements) 추가, 삭제, 컨텐츠(contents) 검색, 보이기 & 숨기기를 포함하고 있습니다.\n+DOM 조작을 하기위해서, 내장된 지시자(directives)를 사용하거나, 필요하다면 당신만의 지시자를 작성하십시오.\n+기능성(functionality) 복재에 대한 내용을 아래에서 확인하십시오.\n \n-If you're struggling to break the habit, consider removing jQuery from your app.\n-Really. Angular has the $http service and powerful directives that make it almost always unnecessary.\n-Angular's bundled jQLite has a handful of the features most commonly used in writing Angular directives, especially binding to events.\n+jQuery사용 습관을 버리는데 힘겨워하고 있다면, 당신의 앱(app)에서 jQuery를 없애 버리는 것을 고려해보십시오.\n+정말로, Angular는 jQuery가 거의 항상 필요 없게 하는 $http 서비스와 강력한 지시자를 가지고 있습니다.\n+Angular의 배포판 jQLite는 Angular 지시자 작성에, 특히 이벤트 바인딩에 아주 보편적으로 사용할 수 있는 작은 기능들이 있습니다.\n \n-### Trying to duplicate functionality that already exists\n+### 이미 존재하는 기능성 복재하기\n \n-There's a good chance that your app isn't the first to require certain functionality.\n-There are a few pieces of Angular that are particularly likely to be reimplemented out of old habits.\n+특정 기능성이 필요한 앱(app)이 당신게 처음이 아니라는게 좋은 기회가 됩니다.","path":"docs/content-ko/misc/faq.ngdoc","position":217,"original_position":217,"commit_id":"718dca3527bb4b389940cb1fc5aaa2cf9612b287","original_commit_id":"718dca3527bb4b389940cb1fc5aaa2cf9612b287","user":{"login":"haibane84","id":912457,"avatar_url":"https://secure.gravatar.com/avatar/e2c96492b90f902bf5ea44da1c907dd6?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"e2c96492b90f902bf5ea44da1c907dd6","url":"https://api.github.com/users/haibane84","html_url":"https://github.com/haibane84","followers_url":"https://api.github.com/users/haibane84/followers","following_url":"https://api.github.com/users/haibane84/following{/other_user}","gists_url":"https://api.github.com/users/haibane84/gists{/gist_id}","starred_url":"https://api.github.com/users/haibane84/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haibane84/subscriptions","organizations_url":"https://api.github.com/users/haibane84/orgs","repos_url":"https://api.github.com/users/haibane84/repos","events_url":"https://api.github.com/users/haibane84/events{/privacy}","received_events_url":"https://api.github.com/users/haibane84/received_events","type":"User"},"created_at":"2013-06-01T03:26:34Z","updated_at":"2013-06-01T03:26:34Z","html_url":"https://github.com/KAUG/angular.js/pull/25#discussion_r4488254","pull_request_url":"https://api.github.com/repos/KAUG/angular.js/pulls/25","_links":{"self":{"href":"https://api.github.com/repos/KAUG/angular.js/pulls/comments/4488254"},"html":{"href":"https://github.com/KAUG/angular.js/pull/25#discussion_r4488254"},"pull_request":{"href":"https://api.github.com/repos/KAUG/angular.js/pulls/25"}}}} | {
"id": 8678196,
"name": "angular.js",
"url": "https://github.com/KAUG/angular.js"
} | {
"id": null,
"login": "haibane84",
"gravatar_id": "e2c96492b90f902bf5ea44da1c907dd6",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "KAUG",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-06-01T03:26:34 | null | {"repository":{"description":"","homepage":"http://angularjs.org","watchers":4,"stargazers":4,"forks":14,"fork":true,"size":340,"owner":"KAUG","private":false,"open_issues":13,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"JavaScript","created_at":"2013-03-09T16:02:42-08:00","pushed_at":"2013-05-22T04:50:57-07:00","master_branch":"master","organization":"KAUG"},"actor_attributes":{"type":"User","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/KAUG/angular.js/pull/25#discussion_r4488254"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/NREL/OpenStudio/pulls/comments/7815805","id":7815805,"diff_hunk":"@@ -93,9 +302,19 @@ class UTILITIES_API EpwFile{\n /// get the actual year of the end date if there is one\r\n boost::optional<int> endDateActualYear() const;\r\n \r\n+ /// get the weather data\r\n+ std::vector<EpwDataPoint> data() const;\r\n+\r\n+ /// get a time series of a particular weather field\r\n+ // This will probably need to include the period at some point, but for now just dump everything into a time series\r\n+ boost::optional<TimeSeries> timeSeries(std::string field);\r","path":"openstudiocore/src/utilities/filetypes/EpwFile.hpp","position":240,"original_position":240,"commit_id":"1ecde377925b62fa57587bf111ba3d5e9046445d","original_commit_id":"1ecde377925b62fa57587bf111ba3d5e9046445d","user":{"login":"macumber","id":1327850,"avatar_url":"https://0.gravatar.com/avatar/fee1873120deaf9da6d62b4eb32bf5dc?d=https%3A%2F%2Fidenticons.github.com%2Fea7e272b05559864a6207482c7b311cf.png&r=x","gravatar_id":"fee1873120deaf9da6d62b4eb32bf5dc","url":"https://api.github.com/users/macumber","html_url":"https://github.com/macumber","followers_url":"https://api.github.com/users/macumber/followers","following_url":"https://api.github.com/users/macumber/following{/other_user}","gists_url":"https://api.github.com/users/macumber/gists{/gist_id}","starred_url":"https://api.github.com/users/macumber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/macumber/subscriptions","organizations_url":"https://api.github.com/users/macumber/orgs","repos_url":"https://api.github.com/users/macumber/repos","events_url":"https://api.github.com/users/macumber/events{/privacy}","received_events_url":"https://api.github.com/users/macumber/received_events","type":"User","site_admin":false},"body":"@jasondegraw I like this!","created_at":"2013-11-21T05:04:01Z","updated_at":"2013-11-21T05:04:01Z","html_url":"https://github.com/NREL/OpenStudio/pull/648#discussion_r7815805","pull_request_url":"https://api.github.com/repos/NREL/OpenStudio/pulls/648","_links":{"self":{"href":"https://api.github.com/repos/NREL/OpenStudio/pulls/comments/7815805"},"html":{"href":"https://github.com/NREL/OpenStudio/pull/648#discussion_r7815805"},"pull_request":{"href":"https://api.github.com/repos/NREL/OpenStudio/pulls/648"}}}} | {
"id": 11159552,
"name": "OpenStudio",
"url": "https://github.com/NREL/OpenStudio"
} | {
"id": null,
"login": "macumber",
"gravatar_id": "fee1873120deaf9da6d62b4eb32bf5dc",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "NREL",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-11-21T05:04:01 | null | {"repository":{"description":"OpenStudio is a cross-platform collection of software tools to support whole building energy modeling using EnergyPlus and advanced daylight analysis using Radiance.","homepage":"http://openstudio.nrel.gov/","watchers":26,"stargazers":26,"forks":25,"fork":false,"size":135794,"owner":"NREL","private":false,"open_issues":3,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"C++","created_at":"2013-07-03T12:34:37-07:00","pushed_at":"2013-11-20T16:04:58-08:00","master_branch":"develop","organization":"NREL"},"actor_attributes":{"type":"User","name":"Dan Macumber","company":"NREL","email":"[email protected]"},"url":"https://github.com/NREL/OpenStudio/pull/648#discussion_r7815805"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/Yelp/Tron/pulls/comments/2919064","id":2919064,"body":"Fair point. I've added a logger and change all error messages to use the logger.","path":"bin/tronfig","position":45,"original_position":45,"commit_id":"6ed264d748505bbd0563024ce60b991d376cb0dd","original_commit_id":"6ed264d748505bbd0563024ce60b991d376cb0dd","user":{"login":"dnephin","id":442180,"avatar_url":"https://secure.gravatar.com/avatar/996ae88559e4c401582326971c77c75a?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"996ae88559e4c401582326971c77c75a","url":"https://api.github.com/users/dnephin","followers_url":"https://api.github.com/users/dnephin/followers","following_url":"https://api.github.com/users/dnephin/following","gists_url":"https://api.github.com/users/dnephin/gists{/gist_id}","starred_url":"https://api.github.com/users/dnephin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dnephin/subscriptions","organizations_url":"https://api.github.com/users/dnephin/orgs","repos_url":"https://api.github.com/users/dnephin/repos","events_url":"https://api.github.com/users/dnephin/events{/privacy}","received_events_url":"https://api.github.com/users/dnephin/received_events","type":"User"},"created_at":"2013-02-06T23:00:18Z","updated_at":"2013-02-06T23:00:18Z","_links":{"self":{"href":"https://api.github.com/repos/Yelp/Tron/pulls/comments/2919064"},"html":{"href":"https://github.com/Yelp/Tron/pull/190#discussion_r2919064"},"pull_request":{"href":"https://api.github.com/repos/Yelp/Tron/pulls/190"}}}} | {
"id": 899771,
"name": "Tron",
"url": "https://github.com/Yelp/Tron"
} | {
"id": null,
"login": "dnephin",
"gravatar_id": "996ae88559e4c401582326971c77c75a",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "Yelp",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-02-06T23:00:18 | null | {"repository":{"description":"Next generation batch process scheduling and management","homepage":"","watchers":113,"stargazers":113,"forks":19,"fork":false,"size":772,"owner":"Yelp","private":false,"open_issues":46,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Python","created_at":"2010-09-09T13:54:04-07:00","pushed_at":"2013-01-15T15:24:18-08:00","integrate_branch":"next_release","organization":"Yelp"},"actor_attributes":{"name":"Daniel Nephin","blog":"danielnephin.net","location":"San Francisco","email":"[email protected]","type":"User"},"url":"https://github.com/Yelp/Tron/pull/190#discussion_r2919064"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/Yelp/Testify/pulls/comments/3575646","id":3575646,"body":"Weird spacing. Also please add a period to the end of the previous sentence.","diff_hunk":"@@ -378,33 +404,77 @@ def method_excluded(self, method):\n method_suites = set(getattr(method, '_suites', set()))\n return (self.__suites_exclude & method_suites)\n \n+ def __run_class_fixture(self, fixture_method, function_to_call, stage, callback_on_run_event, callback_on_complete_event, fire_events=True):\n+ self._stage = stage\n+\n+ result = TestResult(fixture_method)\n+ try:\n+ result.start()\n+ if fire_events:\n+ self.fire_event(callback_on_run_event, result)\n+ if self.__execute_block_recording_exceptions(function_to_call, result, is_class_level=True):\n+ result.end_in_success()\n+ else:\n+ self.failure_count += 1\n+ except (KeyboardInterrupt, SystemExit):\n+ result.end_in_interruption(sys.exc_info())\n+ raise\n+ finally:\n+ if fire_events:\n+ self.fire_event(callback_on_complete_event, result)\n \n def __enter_class_context_managers(self, fixture_methods, callback):\n- \"\"\"Transform each fixture_method into a context manager with contextlib.contextmanager, enter them recursively, and call callback\"\"\"\n+ \"\"\"Transform each fixture_method into a context manager with\n+ contextlib.contextmanager, enter them recursively, and call\n+ callback\n+ \"\"\"\n if fixture_methods:\n fixture_method = fixture_methods[0]\n ctm = contextmanager(fixture_method)()\n \n- enter_result = TestResult(fixture_method)\n- enter_result.start()\n- self.fire_event(self.EVENT_ON_RUN_CLASS_SETUP_METHOD, enter_result)\n- if self.__execute_block_recording_exceptions(ctm.__enter__, enter_result, is_class_level=True):\n- enter_result.end_in_success()\n- self.fire_event(self.EVENT_ON_COMPLETE_CLASS_SETUP_METHOD, enter_result)\n-\n- self.__enter_context_managers(fixture_methods[1:], callback)\n-\n- exit_result = TestResult(fixture_method)\n- exit_result.start()\n- self.fire_event(self.EVENT_ON_RUN_CLASS_TEARDOWN_METHOD, exit_result)\n- if self.__execute_block_recording_exceptions(lambda: ctm.__exit__(None, None, None), exit_result, is_class_level=True):\n- exit_result.end_in_success()\n- self.fire_event(self.EVENT_ON_COMPLETE_CLASS_TEARDOWN_METHOD, exit_result)\n+ if fixture_method._fixture_type == 'class_teardown':\n+ # class_teardown fixture is wrapped as\n+ # class_setup_teardown. We should not fire events for the\n+ # setup phase of this fake context manager.\n+ fire_events = False\n+ else:\n+ fire_events = True\n+\n+ self.__run_class_fixture(\n+ fixture_method,\n+ ctm.__enter__,\n+ self.STAGE_CLASS_SETUP,\n+ self.EVENT_ON_RUN_CLASS_SETUP_METHOD,\n+ self.EVENT_ON_COMPLETE_CLASS_SETUP_METHOD,\n+ fire_events\n+ )\n+\n+ self.__enter_class_context_managers(fixture_methods[1:], callback)\n+\n+ if fixture_method._fixture_type == 'class_setup':\n+ # class_setup fixture is wrapped as\n+ # class_setup_teardown. We should not fire events for the\n+ # teardown phase of this fake context manager.\n+ fire_events = False\n+ else:\n+ fire_events = True\n+\n+ self.__run_class_fixture(\n+ fixture_method,\n+ lambda: ctm.__exit__(None, None, None),\n+ self.STAGE_CLASS_TEARDOWN,\n+ self.EVENT_ON_RUN_CLASS_TEARDOWN_METHOD,\n+ self.EVENT_ON_COMPLETE_CLASS_TEARDOWN_METHOD,\n+ fire_events\n+ )\n else:\n callback()\n \n def __enter_context_managers(self, fixture_methods, callback):\n- \"\"\"Transform each fixture_method into a context manager with contextlib.contextmanager, enter them recursively, and call callback\"\"\"\n+ \"\"\"Transform each fixture_method into a context manager with\n+ contextlib.contextmanager, enter them recursively, and call\n+ callback\n+\t\t\"\"\"","path":"testify/test_case.py","position":208,"original_position":208,"commit_id":"8b1bf984b59ab90ed38e602dc79e56d9b12925ff","original_commit_id":"8b1bf984b59ab90ed38e602dc79e56d9b12925ff","user":{"login":"mrtyler","id":1369918,"avatar_url":"https://secure.gravatar.com/avatar/c2c1449b364fb55f826fc191b8ab8f21?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"c2c1449b364fb55f826fc191b8ab8f21","url":"https://api.github.com/users/mrtyler","html_url":"https://github.com/mrtyler","followers_url":"https://api.github.com/users/mrtyler/followers","following_url":"https://api.github.com/users/mrtyler/following","gists_url":"https://api.github.com/users/mrtyler/gists{/gist_id}","starred_url":"https://api.github.com/users/mrtyler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrtyler/subscriptions","organizations_url":"https://api.github.com/users/mrtyler/orgs","repos_url":"https://api.github.com/users/mrtyler/repos","events_url":"https://api.github.com/users/mrtyler/events{/privacy}","received_events_url":"https://api.github.com/users/mrtyler/received_events","type":"User"},"created_at":"2013-03-28T18:28:39Z","updated_at":"2013-03-28T18:28:39Z","html_url":"https://github.com/Yelp/Testify/pull/152#discussion_r3575646","pull_request_url":"https://api.github.com/repos/Yelp/Testify/pulls/152","_links":{"self":{"href":"https://api.github.com/repos/Yelp/Testify/pulls/comments/3575646"},"html":{"href":"https://github.com/Yelp/Testify/pull/152#discussion_r3575646"},"pull_request":{"href":"https://api.github.com/repos/Yelp/Testify/pulls/152"}}}} | {
"id": 376878,
"name": "Testify",
"url": "https://github.com/Yelp/Testify"
} | {
"id": null,
"login": "mrtyler",
"gravatar_id": "c2c1449b364fb55f826fc191b8ab8f21",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "Yelp",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-03-28T18:28:39 | null | {"repository":{"description":"A more pythonic testing framework.","homepage":"","watchers":141,"stargazers":141,"forks":37,"fork":false,"size":268,"owner":"Yelp","private":false,"open_issues":16,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Python","created_at":"2009-11-17T22:27:31-08:00","pushed_at":"2013-03-26T15:53:09-07:00","integrate_branch":"rhettg_integration","master_branch":"master","organization":"Yelp"},"actor_attributes":{"type":"User","name":"Tyler Roscoe","location":"San Francisco, CA","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/Yelp/Testify/pull/152#discussion_r3575646"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/akka/akka/pulls/comments/7213797","id":7213797,"diff_hunk":"@@ -133,15 +252,19 @@ private[persistence] trait Eventsourced extends Processor {\n * Command handler. Typically validates commands against current state (and/or by\n * communication with other actors). On successful validation, one or more events are\n * derived from a command and these events are then persisted by calling `persist`.\n- * Commands sent to event sourced processors should not be [[Persistent]] messages.\n+ * Commands sent to event sourced processors must not be [[Persistent]] or\n+ * [[PersistentBatch]] messages. In this case an `UnsupportedOperationException` is\n+ * thrown by the processor.\n */\n def receiveCommand: Receive\n \n /**\n- * INTERNAL API.\n+ * Asynchronously initializes this processor's command queue.\n */\n- final override protected[akka] def aroundReceive(receive: Receive, message: Any) {\n- currentState.aroundReceive(receive, message)\n+ @throws(classOf[Exception])\n+ override def preStart() {\n+ super.preStart()\n+ extension.commandQueues ! GetCommandQueue(self)","path":"akka-persistence/src/main/scala/akka/persistence/Eventsourced.scala","position":273,"original_position":273,"commit_id":"460f3fd1a48811587988637c601b3e4a085c401a","original_commit_id":"460f3fd1a48811587988637c601b3e4a085c401a","user":{"login":"rkuhn","id":470469,"avatar_url":"https://0.gravatar.com/avatar/262b1ab25e66b1e15a48fa3f68703aad?d=https%3A%2F%2Fidenticons.github.com%2Fbc4b39ad048b12d3159ac08d12b69fe2.png&r=x","gravatar_id":"262b1ab25e66b1e15a48fa3f68703aad","url":"https://api.github.com/users/rkuhn","html_url":"https://github.com/rkuhn","followers_url":"https://api.github.com/users/rkuhn/followers","following_url":"https://api.github.com/users/rkuhn/following{/other_user}","gists_url":"https://api.github.com/users/rkuhn/gists{/gist_id}","starred_url":"https://api.github.com/users/rkuhn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rkuhn/subscriptions","organizations_url":"https://api.github.com/users/rkuhn/orgs","repos_url":"https://api.github.com/users/rkuhn/repos","events_url":"https://api.github.com/users/rkuhn/events{/privacy}","received_events_url":"https://api.github.com/users/rkuhn/received_events","type":"User","site_admin":false},"body":"this must happen post restart as well, right?","created_at":"2013-10-25T11:59:30Z","updated_at":"2013-10-25T11:59:30Z","html_url":"https://github.com/akka/akka/pull/1808#discussion_r7213797","pull_request_url":"https://api.github.com/repos/akka/akka/pulls/1808","_links":{"self":{"href":"https://api.github.com/repos/akka/akka/pulls/comments/7213797"},"html":{"href":"https://github.com/akka/akka/pull/1808#discussion_r7213797"},"pull_request":{"href":"https://api.github.com/repos/akka/akka/pulls/1808"}}}} | {
"id": 130013,
"name": "akka",
"url": "https://github.com/akka/akka"
} | {
"id": null,
"login": "rkuhn",
"gravatar_id": "262b1ab25e66b1e15a48fa3f68703aad",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "akka",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-10-25T11:59:30 | null | {"repository":{"description":"Akka Project","homepage":"http://akka.io","watchers":2014,"stargazers":2014,"forks":474,"fork":false,"size":174217,"owner":"akka","private":false,"open_issues":8,"has_issues":true,"has_downloads":true,"has_wiki":false,"language":"Scala","created_at":"2009-02-16T04:51:54-08:00","pushed_at":"2013-10-25T01:54:33-07:00","integrate_branch":"staging","master_branch":"master","organization":"akka"},"actor_attributes":{"type":"User","name":"Roland Kuhn","company":"Typesafe Inc.","location":"Uppsala, Sweden","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/akka/akka/pull/1808#discussion_r7213797"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/akka/akka/pulls/comments/3652331","id":3652331,"body":"good point; will make it a constructor arg and add bounds checking","diff_hunk":"@@ -0,0 +1,854 @@\n+/**\n+ * Copyright (C) 2009-2013 Typesafe Inc. <http://www.typesafe.com>\n+ */\n+\n+package akka.io\n+\n+import java.lang.{ Iterable ⇒ JIterable }\n+import scala.annotation.tailrec\n+import scala.util.{ Try, Success, Failure }\n+import java.nio.ByteOrder\n+import akka.util.ByteString\n+import scala.collection.mutable\n+import akka.actor.ActorContext\n+import scala.concurrent.duration.FiniteDuration\n+import scala.collection.mutable.WrappedArray\n+\n+/**\n+ * Scala API: A pair of pipes, one for commands and one for events, plus a\n+ * management port. Commands travel from top to bottom, events from bottom to\n+ * top. All messages which need to be handled “in-order” (e.g. top-down or\n+ * bottom-up) need to be either events or commands; management messages are\n+ * processed in no particular order.\n+ *\n+ * Java base classes are provided in the form of [[AbstractPipePair]]\n+ * and [[AbstractSymmetricPipePair]] since the Scala function types can be\n+ * awkward to handle in Java.\n+ *\n+ * @see [[PipelineStage]]\n+ * @see [[AbstractPipePair]]\n+ * @see [[AbstractSymmetricPipePair]]\n+ * @see [[PipePairFactory]]\n+ */\n+trait PipePair[CmdAbove, CmdBelow, EvtAbove, EvtBelow] {\n+\n+ type Mgmt = PartialFunction[AnyRef, Iterable[Either[EvtAbove, CmdBelow]]]\n+\n+ /**\n+ * The command pipeline transforms injected commands from the upper stage\n+ * into commands for the stage below, but it can also emit events for the\n+ * upper stage. Any number of each can be generated.\n+ */\n+ def commandPipeline: CmdAbove ⇒ Iterable[Either[EvtAbove, CmdBelow]]\n+\n+ /**\n+ * The event pipeline transforms injected event from the lower stage\n+ * into event for the stage above, but it can also emit commands for the\n+ * stage below. Any number of each can be generated.\n+ */\n+ def eventPipeline: EvtBelow ⇒ Iterable[Either[EvtAbove, CmdBelow]]\n+\n+ /**\n+ * The management port allows sending broadcast messages to all stages\n+ * within this pipeline. This can be used to communicate with stages in the\n+ * middle without having to thread those messages through the surrounding\n+ * stages. Each stage can generate events and commands in response to a\n+ * command, and the aggregation of all those is returned.\n+ *\n+ * The default implementation ignores all management commands.\n+ */\n+ def managementPort: Mgmt = PartialFunction.empty\n+}\n+\n+/**\n+ * A convenience type for expressing a [[PipePair]] which has the same types\n+ * for commands and events.\n+ */\n+trait SymmetricPipePair[Above, Below] extends PipePair[Above, Below, Above, Below]\n+\n+object AbstractPipePair {\n+ val nothing = new java.util.ArrayList(0)\n+}\n+\n+/**\n+ * Java API: A pair of pipes, one for commands and one for events. Commands travel from\n+ * top to bottom, events from bottom to top.\n+ *\n+ * @see [[PipelineStage]]\n+ * @see [[AbstractSymmetricPipePair]]\n+ * @see [[PipePairFactory]]\n+ */\n+abstract class AbstractPipePair[CmdAbove, CmdBelow, EvtAbove, EvtBelow] {\n+\n+ /**\n+ * Commands reaching this pipe pair are transformed into a sequence of\n+ * commands for the next or events for the previous stage.\n+ *\n+ * Throwing exceptions within this method will abort processing of the whole\n+ * pipeline which this pipe pair is part of.\n+ *\n+ * @param cmd the incoming command\n+ * @return an Iterable of elements which are either events or commands\n+ *\n+ * @see [[#makeCommand]]\n+ * @see [[#makeEvent]]\n+ */\n+ def onCommand(cmd: CmdAbove): JIterable[Either[EvtAbove, CmdBelow]]\n+\n+ /**\n+ * Events reaching this pipe pair are transformed into a sequence of\n+ * commands for the next or events for the previous stage.\n+ *\n+ * Throwing exceptions within this method will abort processing of the whole\n+ * pipeline which this pipe pair is part of.\n+ *\n+ * @param cmd the incoming command\n+ * @return an Iterable of elements which are either events or commands\n+ *\n+ * @see [[#makeCommand]]\n+ * @see [[#makeEvent]]\n+ */\n+ def onEvent(event: EvtBelow): JIterable[Either[EvtAbove, CmdBelow]]\n+\n+ /**\n+ * Management commands are sent to all stages in a broadcast fashion,\n+ * conceptually in parallel (but not actually executing a stage\n+ * reentrantly in case of events or commands being generated in response\n+ * to a management command).\n+ */\n+ def onManagementCommand(cmd: AnyRef): JIterable[Either[EvtAbove, CmdBelow]] = new java.util.ArrayList(0)\n+\n+ /**\n+ * Helper method for wrapping a command which shall be emitted.\n+ */\n+ def makeCommand(cmd: CmdBelow): Either[EvtAbove, CmdBelow] = Right(cmd)\n+\n+ /**\n+ * Helper method for wrapping an event which shall be emitted.\n+ */\n+ def makeEvent(event: EvtAbove): Either[EvtAbove, CmdBelow] = Left(event)\n+\n+ /**\n+ * INTERNAL API: do not touch!\n+ */\n+ private[io] val cmd = {\n+ val l = new java.util.ArrayList[AnyRef](1)\n+ l add null\n+ l\n+ }\n+ /**\n+ * INTERNAL API: do not touch!\n+ */\n+ private[io] val evt = {\n+ val l = new java.util.ArrayList[AnyRef](1)\n+ l add null\n+ l\n+ }\n+\n+ /**\n+ * Wrap a single command for efficient return to the pipeline’s machinery.\n+ * This method avoids allocating a [[Right]] and an [[java.lang.Iterable]] by reusing\n+ * one such instance within the AbstractPipePair, hence it can be used ONLY ONCE by\n+ * each pipeline stage. Prototypic and safe usage looks like this:\n+ *\n+ * {{{\n+ * final MyResult result = ... ;\n+ * return singleCommand(result);\n+ * }}}\n+ *\n+ * @see PipelineContext#singleCommand\n+ */\n+ def singleCommand(cmd: CmdBelow): JIterable[Either[EvtAbove, CmdBelow]] = {\n+ this.cmd.set(0, cmd.asInstanceOf[AnyRef])\n+ this.cmd.asInstanceOf[JIterable[Either[EvtAbove, CmdBelow]]]\n+ }\n+\n+ /**\n+ * Wrap a single event for efficient return to the pipeline’s machinery.\n+ * This method avoids allocating a [[Left]] and an [[Iterable]] by reusing\n+ * one such instance within the AbstractPipePair, hence it can be used ONLY ONCE by\n+ * each pipeline stage. Prototypic and safe usage looks like this:\n+ *\n+ * {{{\n+ * final MyResult result = ... ;\n+ * return singleEvent(result);\n+ * }}}\n+ *\n+ * @see PipelineContext#singleEvent\n+ */\n+ def singleEvent(evt: EvtAbove): JIterable[Either[EvtAbove, CmdBelow]] = {\n+ this.evt.set(0, evt.asInstanceOf[AnyRef])\n+ this.evt.asInstanceOf[JIterable[Either[EvtAbove, CmdBelow]]]\n+ }\n+\n+ /**\n+ * A shared (and shareable) instance of an empty `Iterable[Either[EvtAbove, CmdBelow]]`.\n+ * Use this when processing does not yield any commands or events as result.\n+ */\n+ def nothing: JIterable[Either[EvtAbove, CmdBelow]] = AbstractPipePair.nothing.asInstanceOf[JIterable[Either[EvtAbove, CmdBelow]]]\n+\n+ /**\n+ * INTERNAL API: Dealias a possibly optimized return value such that it can\n+ * be safely used; this is never needed when only using public API.\n+ */\n+ def dealias[Cmd, Evt](msg: JIterable[Either[Evt, Cmd]]): JIterable[Either[Evt, Cmd]] = {\n+ if (msg eq cmd) mkIterable(Right(cmd.get(0).asInstanceOf[Cmd]))\n+ else if (msg eq evt) mkIterable(Left(evt.get(0).asInstanceOf[Evt]))\n+ else msg\n+ }\n+\n+ private def mkIterable[Cmd, Evt](e: Either[Evt, Cmd]): JIterable[Either[Evt, Cmd]] = {\n+ val a = new java.util.ArrayList[Either[Evt, Cmd]](1)\n+ a add e\n+ a\n+ }\n+}\n+\n+/**\n+ * A convenience type for expressing a [[AbstractPipePair]] which has the same types\n+ * for commands and events.\n+ */\n+abstract class AbstractSymmetricPipePair[Above, Below] extends AbstractPipePair[Above, Below, Above, Below]\n+\n+/**\n+ * This class contains static factory methods which produce [[PipePair]]\n+ * instances; those are needed within the implementation of [[PipelineStage#apply]].\n+ */\n+object PipePairFactory {\n+\n+ /**\n+ * Scala API: construct a [[PipePair]] from the two given functions; useful for not capturing `$outer` references.\n+ */\n+ def apply[CmdAbove, CmdBelow, EvtAbove, EvtBelow] //\n+ (commandPL: CmdAbove ⇒ Iterable[Either[EvtAbove, CmdBelow]],\n+ eventPL: EvtBelow ⇒ Iterable[Either[EvtAbove, CmdBelow]],\n+ management: PartialFunction[AnyRef, Iterable[Either[EvtAbove, CmdBelow]]] = PartialFunction.empty) =\n+ new PipePair[CmdAbove, CmdBelow, EvtAbove, EvtBelow] {\n+ override def commandPipeline = commandPL\n+ override def eventPipeline = eventPL\n+ override def managementPort = management\n+ }\n+\n+ private abstract class Converter[CmdAbove <: AnyRef, CmdBelow <: AnyRef, EvtAbove <: AnyRef, EvtBelow <: AnyRef] //\n+ (val ap: AbstractPipePair[CmdAbove, CmdBelow, EvtAbove, EvtBelow], ctx: PipelineContext) {\n+ import scala.collection.JavaConverters._\n+ protected def normalize(output: JIterable[Either[EvtAbove, CmdBelow]]): Iterable[Either[EvtAbove, CmdBelow]] =\n+ if (output eq AbstractPipePair.nothing) Nil\n+ else if (output eq ap.cmd) ctx.singleCommand(ap.cmd.get(0).asInstanceOf[CmdBelow])\n+ else if (output eq ap.evt) ctx.singleEvent(ap.evt.get(0).asInstanceOf[EvtAbove])\n+ else output.asScala\n+ }\n+\n+ /**\n+ * Java API: construct a [[PipePair]] from the given [[AbstractPipePair]].\n+ */\n+ def create[CmdAbove <: AnyRef, CmdBelow <: AnyRef, EvtAbove <: AnyRef, EvtBelow <: AnyRef] //\n+ (ctx: PipelineContext, ap: AbstractPipePair[CmdAbove, CmdBelow, EvtAbove, EvtBelow]) //\n+ : PipePair[CmdAbove, CmdBelow, EvtAbove, EvtBelow] =\n+ new Converter(ap, ctx) with PipePair[CmdAbove, CmdBelow, EvtAbove, EvtBelow] {\n+ override val commandPipeline = { cmd: CmdAbove ⇒ normalize(ap.onCommand(cmd)) }\n+ override val eventPipeline = { evt: EvtBelow ⇒ normalize(ap.onEvent(evt)) }\n+ override val managementPort: Mgmt = { case x ⇒ normalize(ap.onManagementCommand(x)) }\n+ }\n+\n+ /**\n+ * Java API: construct a [[PipePair]] from the given [[AbstractSymmetricPipePair]].\n+ */\n+ def create[Above <: AnyRef, Below <: AnyRef] //\n+ (ctx: PipelineContext, ap: AbstractSymmetricPipePair[Above, Below]): SymmetricPipePair[Above, Below] =\n+ new Converter(ap, ctx) with SymmetricPipePair[Above, Below] {\n+ override val commandPipeline = { cmd: Above ⇒ normalize(ap.onCommand(cmd)) }\n+ override val eventPipeline = { evt: Below ⇒ normalize(ap.onEvent(evt)) }\n+ override val managementPort: Mgmt = { case x ⇒ normalize(ap.onManagementCommand(x)) }\n+ }\n+}\n+\n+/**\n+ * This class contains static factory methods which turn a pipeline context\n+ * and a [[PipelineStage]] into readily usable pipelines.\n+ */\n+object PipelineFactory {\n+\n+ /**\n+ * Scala API: build the pipeline and return a pair of functions representing\n+ * the command and event pipelines. Each function returns the commands and\n+ * events resulting from running the pipeline on the given input, where the\n+ * the sequence of events is the first element of the returned pair and the\n+ * sequence of commands the second element.\n+ *\n+ * Exceptions thrown by the pipeline stages will not be caught.\n+ *\n+ * @param ctx The context object for this pipeline\n+ * @param stage The (composite) pipeline stage from whcih to build the pipeline\n+ * @return a pair of command and event pipeline functions\n+ */\n+ def buildFunctionTriple[Ctx <: PipelineContext, CmdAbove, CmdBelow, EvtAbove, EvtBelow] //\n+ (ctx: Ctx, stage: PipelineStage[Ctx, CmdAbove, CmdBelow, EvtAbove, EvtBelow]) //\n+ : (CmdAbove ⇒ (Iterable[EvtAbove], Iterable[CmdBelow]), //\n+ EvtBelow ⇒ (Iterable[EvtAbove], Iterable[CmdBelow]), //\n+ PartialFunction[AnyRef, (Iterable[EvtAbove], Iterable[CmdBelow])]) = {\n+ val pp = stage apply ctx\n+ val split: (Iterable[Either[EvtAbove, CmdBelow]]) ⇒ (Iterable[EvtAbove], Iterable[CmdBelow]) = { in ⇒\n+ if (in.isEmpty) (Nil, Nil)\n+ else if (in eq ctx.cmd) (Nil, Seq[CmdBelow](ctx.cmd(0)))\n+ else if (in eq ctx.evt) (Seq[EvtAbove](ctx.evt(0)), Nil)\n+ else {\n+ val cmds = Vector.newBuilder[CmdBelow]\n+ val evts = Vector.newBuilder[EvtAbove]\n+ in foreach {\n+ case Right(cmd) ⇒ cmds += cmd\n+ case Left(evt) ⇒ evts += evt\n+ }\n+ (evts.result, cmds.result)\n+ }\n+ }\n+ (pp.commandPipeline andThen split, pp.eventPipeline andThen split, pp.managementPort andThen split)\n+ }\n+\n+ /**\n+ * Scala API: build the pipeline attaching the given command and event sinks\n+ * to its outputs. Exceptions thrown within the pipeline stages will abort\n+ * processing (i.e. will not be processed in following stages) but will be\n+ * caught and passed as [[scala.util.Failure]] into the respective sink.\n+ *\n+ * Exceptions thrown while processing management commands are not caught.\n+ *\n+ * @param ctx The context object for this pipeline\n+ * @param stage The (composite) pipeline stage from whcih to build the pipeline\n+ * @param commandSink The function to invoke for commands or command failures\n+ * @param eventSink The function to invoke for events or event failures\n+ * @return a handle for injecting events or commands into the pipeline\n+ */\n+ def buildWithSinkFunctions[Ctx <: PipelineContext, CmdAbove, CmdBelow, EvtAbove, EvtBelow] //\n+ (ctx: Ctx,\n+ stage: PipelineStage[Ctx, CmdAbove, CmdBelow, EvtAbove, EvtBelow])(\n+ commandSink: Try[CmdBelow] ⇒ Unit,\n+ eventSink: Try[EvtAbove] ⇒ Unit): PipelineInjector[CmdAbove, EvtBelow] =\n+ new PipelineInjector[CmdAbove, EvtBelow] {\n+ val pl = stage(ctx)\n+ override def injectCommand(cmd: CmdAbove): Unit = {\n+ Try(pl.commandPipeline(cmd)) match {\n+ case f: Failure[_] ⇒ commandSink(f.asInstanceOf[Try[CmdBelow]])\n+ case Success(out) ⇒\n+ if (out.isEmpty) () // nothing\n+ else if (out eq ctx.cmd) commandSink(Success(ctx.cmd(0)))\n+ else if (out eq ctx.evt) eventSink(Success(ctx.evt(0)))\n+ else out foreach {\n+ case Right(cmd) ⇒ commandSink(Success(cmd))\n+ case Left(evt) ⇒ eventSink(Success(evt))\n+ }\n+ }\n+ }\n+ override def injectEvent(evt: EvtBelow): Unit = {\n+ Try(pl.eventPipeline(evt)) match {\n+ case f: Failure[_] ⇒ eventSink(f.asInstanceOf[Try[EvtAbove]])\n+ case Success(out) ⇒\n+ if (out.isEmpty) () // nothing\n+ else if (out eq ctx.cmd) commandSink(Success(ctx.cmd(0)))\n+ else if (out eq ctx.evt) eventSink(Success(ctx.evt(0)))\n+ else out foreach {\n+ case Right(cmd) ⇒ commandSink(Success(cmd))\n+ case Left(evt) ⇒ eventSink(Success(evt))\n+ }\n+ }\n+ }\n+ override def managementCommand(cmd: AnyRef): Unit = {\n+ val out = pl.managementPort(cmd)\n+ if (out.isEmpty) () // nothing\n+ else if (out eq ctx.cmd) commandSink(Success(ctx.cmd(0)))\n+ else if (out eq ctx.evt) eventSink(Success(ctx.evt(0)))\n+ else out foreach {\n+ case Right(cmd) ⇒ commandSink(Success(cmd))\n+ case Left(evt) ⇒ eventSink(Success(evt))\n+ }\n+ }\n+ }\n+\n+ /**\n+ * Java API: build the pipeline attaching the given callback object to its\n+ * outputs. Exceptions thrown within the pipeline stages will abort\n+ * processing (i.e. will not be processed in following stages) but will be\n+ * caught and passed as [[scala.util.Failure]] into the respective sink.\n+ *\n+ * Exceptions thrown while processing management commands are not caught.\n+ *\n+ * @param ctx The context object for this pipeline\n+ * @param stage The (composite) pipeline stage from whcih to build the pipeline\n+ * @param callback The [[PipelineSink]] to attach to the built pipeline\n+ * @return a handle for injecting events or commands into the pipeline\n+ */\n+ def buildWithSink[Ctx <: PipelineContext, CmdAbove, CmdBelow, EvtAbove, EvtBelow] //\n+ (ctx: Ctx,\n+ stage: PipelineStage[Ctx, CmdAbove, CmdBelow, EvtAbove, EvtBelow],\n+ callback: PipelineSink[CmdBelow, EvtAbove]): PipelineInjector[CmdAbove, EvtBelow] =\n+ buildWithSinkFunctions[Ctx, CmdAbove, CmdBelow, EvtAbove, EvtBelow](ctx, stage)({\n+ case Failure(thr) ⇒ callback.onCommandFailure(thr)\n+ case Success(cmd) ⇒ callback.onCommand(cmd)\n+ }, {\n+ case Failure(thr) ⇒ callback.onEventFailure(thr)\n+ case Success(evt) ⇒ callback.onEvent(evt)\n+ })\n+}\n+\n+/**\n+ * A handle for injecting commands and events into a pipeline. Commands travel\n+ * down (or to the right) through the stages, events travel in the opposite\n+ * direction.\n+ *\n+ * @see [[PipelineFactory#buildWithSinkFunctions]]\n+ * @see [[PipelineFactory#buildWithSink]]\n+ */\n+trait PipelineInjector[Cmd, Evt] {\n+\n+ /**\n+ * Inject the given command into the connected pipeline.\n+ */\n+ @throws(classOf[Exception])\n+ def injectCommand(cmd: Cmd): Unit\n+\n+ /**\n+ * Inject the given event into the connected pipeline.\n+ */\n+ @throws(classOf[Exception])\n+ def injectEvent(event: Evt): Unit\n+\n+ /**\n+ * Send a management command to all stages (in an unspecified order).\n+ */\n+ @throws(classOf[Exception])\n+ def managementCommand(cmd: AnyRef): Unit\n+}\n+\n+/**\n+ * A sink which can be attached by [[PipelineFactory#buildWithSink]] to a\n+ * pipeline when it is being built. The methods are called when commands,\n+ * events or their failures occur during evaluation of the pipeline (i.e.\n+ * when injection is triggered using the associated [[PipelineInjector]]).\n+ */\n+abstract class PipelineSink[Cmd, Evt] {\n+\n+ /**\n+ * This callback is invoked for every command generated by the pipeline.\n+ *\n+ * By default this does nothing.\n+ */\n+ @throws(classOf[Throwable])\n+ def onCommand(cmd: Cmd): Unit = {}\n+\n+ /**\n+ * This callback is invoked if an exception occurred while processing an\n+ * injected command. If this callback is invoked that no other callbacks will\n+ * be invoked for the same injection.\n+ *\n+ * By default this will just throw the exception.\n+ */\n+ @throws(classOf[Throwable])\n+ def onCommandFailure(thr: Throwable): Unit = throw thr\n+\n+ /**\n+ * This callback is invoked for every event generated by the pipeline.\n+ *\n+ * By default this does nothing.\n+ */\n+ @throws(classOf[Throwable])\n+ def onEvent(event: Evt): Unit = {}\n+\n+ /**\n+ * This callback is invoked if an exception occurred while processing an\n+ * injected event. If this callback is invoked that no other callbacks will\n+ * be invoked for the same injection.\n+ *\n+ * By default this will just throw the exception.\n+ */\n+ @throws(classOf[Throwable])\n+ def onEventFailure(thr: Throwable): Unit = throw thr\n+}\n+\n+/**\n+ * This base trait of each pipeline’s context provides optimized facilities\n+ * for generating single commands or events (i.e. the fast common case of 1:1\n+ * message transformations).\n+ *\n+ * <b>IMPORTANT NOTICE:</b>\n+ *\n+ * A PipelineContext MUST NOT be shared between multiple pipelines, it contains mutable\n+ * state without synchronization. You have been warned!\n+ *\n+ * @see AbstractPipelineContext see AbstractPipelineContext for a default implementation (Java)\n+ */\n+trait PipelineContext {\n+\n+ /**\n+ * INTERNAL API: do not touch!\n+ */\n+ private val cmdHolder = new Array[AnyRef](1)\n+ /**\n+ * INTERNAL API: do not touch!\n+ */\n+ private val evtHolder = new Array[AnyRef](1)\n+ /**\n+ * INTERNAL API: do not touch!\n+ */\n+ private[io] val cmd = WrappedArray.make(cmdHolder)\n+ /**\n+ * INTERNAL API: do not touch!\n+ */\n+ private[io] val evt = WrappedArray.make(evtHolder)\n+\n+ /**\n+ * Scala API: Wrap a single command for efficient return to the pipeline’s machinery.\n+ * This method avoids allocating a [[Right]] and an [[Iterable]] by reusing\n+ * one such instance within the PipelineContext, hence it can be used ONLY ONCE by\n+ * each pipeline stage. Prototypic and safe usage looks like this:\n+ *\n+ * {{{\n+ * override val commandPipeline = { cmd =>\n+ * val myResult = ...\n+ * ctx.singleCommand(myResult)\n+ * }\n+ * }}}\n+ *\n+ * @see AbstractPipePair#singleCommand see AbstractPipePair for the Java API\n+ */\n+ def singleCommand[Cmd <: AnyRef, Evt <: AnyRef](cmd: Cmd): Iterable[Either[Evt, Cmd]] = {\n+ cmdHolder(0) = cmd\n+ this.cmd\n+ }\n+\n+ /**\n+ * Scala API: Wrap a single event for efficient return to the pipeline’s machinery.\n+ * This method avoids allocating a [[Left]] and an [[Iterable]] by reusing\n+ * one such instance within the context, hence it can be used ONLY ONCE by\n+ * each pipeline stage. Prototypic and safe usage looks like this:\n+ *\n+ * {{{\n+ * override val eventPipeline = { cmd =>\n+ * val myResult = ...\n+ * ctx.singleEvent(myResult)\n+ * }\n+ * }}}\n+ *\n+ * @see AbstractPipePair#singleEvent see AbstractPipePair for the Java API\n+ */\n+ def singleEvent[Cmd <: AnyRef, Evt <: AnyRef](evt: Evt): Iterable[Either[Evt, Cmd]] = {\n+ evtHolder(0) = evt\n+ this.evt\n+ }\n+\n+ /**\n+ * A shared (and shareable) instance of an empty `Iterable[Either[EvtAbove, CmdBelow]]`.\n+ * Use this when processing does not yield any commands or events as result.\n+ */\n+ def nothing[Cmd, Evt]: Iterable[Either[Evt, Cmd]] = Nil\n+\n+ /**\n+ * INTERNAL API: Dealias a possibly optimized return value such that it can\n+ * be safely used; this is never needed when only using public API.\n+ */\n+ def dealias[Cmd, Evt](msg: Iterable[Either[Evt, Cmd]]): Iterable[Either[Evt, Cmd]] = {\n+ if (msg.isEmpty) Nil\n+ else if (msg eq cmd) Seq(Right(cmd(0)))\n+ else if (msg eq evt) Seq(Left(evt(0)))\n+ else msg\n+ }\n+}\n+\n+/**\n+ * This base trait of each pipeline’s context provides optimized facilities\n+ * for generating single commands or events (i.e. the fast common case of 1:1\n+ * message transformations).\n+ *\n+ * <b>IMPORTANT NOTICE:</b>\n+ *\n+ * A PipelineContext MUST NOT be shared between multiple pipelines, it contains mutable\n+ * state without synchronization. You have been warned!\n+ */\n+abstract class AbstractPipelineContext extends PipelineContext\n+\n+object PipelineStage {\n+\n+ /**\n+ * Java API: attach the two given stages such that the command output of the\n+ * first is fed into the command input of the second, and the event output of\n+ * the second is fed into the event input of the first. In other words:\n+ * sequence the stages such that the left one is on top of the right one.\n+ *\n+ * @param left the left or upper pipeline stage\n+ * @param right the right or lower pipeline stage\n+ * @return a pipeline stage representing the sequence of the two stages\n+ */\n+ def sequence[Ctx <: PipelineContext, CmdAbove, CmdBelow, CmdBelowBelow, EvtAbove, EvtBelow, EvtBelowBelow] //\n+ (left: PipelineStage[_ >: Ctx, CmdAbove, CmdBelow, EvtAbove, EvtBelow],\n+ right: PipelineStage[_ >: Ctx, CmdBelow, CmdBelowBelow, EvtBelow, EvtBelowBelow]) //\n+ : PipelineStage[Ctx, CmdAbove, CmdBelowBelow, EvtAbove, EvtBelowBelow] =\n+ left >> right\n+\n+ /**\n+ * Java API: combine the two stages such that the command pipeline of the\n+ * left stage is used and the event pipeline of the right, discarding the\n+ * other two sub-pipelines.\n+ *\n+ * @param left the command pipeline\n+ * @param right the event pipeline\n+ * @return a pipeline stage using the left command pipeline and the right event pipeline\n+ */\n+ def combine[Ctx <: PipelineContext, CmdAbove, CmdBelow, EvtAbove, EvtBelow] //\n+ (left: PipelineStage[Ctx, CmdAbove, CmdBelow, EvtAbove, EvtBelow],\n+ right: PipelineStage[Ctx, CmdAbove, CmdBelow, EvtAbove, EvtBelow]) //\n+ : PipelineStage[Ctx, CmdAbove, CmdBelow, EvtAbove, EvtBelow] =\n+ left | right\n+}\n+\n+/**\n+ * A [[PipelineStage]] which is symmetric in command and event types, i.e. it only\n+ * has one command and event type above and one below.\n+ */\n+abstract class SymmetricPipelineStage[Context <: PipelineContext, Above, Below] extends PipelineStage[Context, Above, Below, Above, Below]\n+\n+/**\n+ * A pipeline stage which can be combined with other stages to build a\n+ * protocol stack. The main function of this class is to serve as a factory\n+ * for the actual [[PipePair]] generated by the [[#apply]] method so that a\n+ * context object can be passed in.\n+ *\n+ * @see [[PipelineFactory]]\n+ */\n+abstract class PipelineStage[Context <: PipelineContext, CmdAbove, CmdBelow, EvtAbove, EvtBelow] { left ⇒\n+\n+ /**\n+ * Implement this method to generate this stage’s pair of command and event\n+ * functions.\n+ *\n+ * INTERNAL API: do not use this method to instantiate a pipeline!\n+ *\n+ * @see [[PipelineFactory]]\n+ * @see [[AbstractPipePair]]\n+ * @see [[AbstractSymmetricPipePair]]\n+ */\n+ protected[io] def apply(ctx: Context): PipePair[CmdAbove, CmdBelow, EvtAbove, EvtBelow]\n+\n+ /**\n+ * Scala API: attach the two given stages such that the command output of the\n+ * first is fed into the command input of the second, and the event output of\n+ * the second is fed into the event input of the first. In other words:\n+ * sequence the stages such that the left one is on top of the right one.\n+ *\n+ * @param right the right or lower pipeline stage\n+ * @return a pipeline stage representing the sequence of the two stages\n+ */\n+ def >>[CmdBelowBelow, EvtBelowBelow, BelowContext <: Context] //\n+ (right: PipelineStage[_ >: BelowContext, CmdBelow, CmdBelowBelow, EvtBelow, EvtBelowBelow]) //\n+ : PipelineStage[BelowContext, CmdAbove, CmdBelowBelow, EvtAbove, EvtBelowBelow] =\n+ new PipelineStage[BelowContext, CmdAbove, CmdBelowBelow, EvtAbove, EvtBelowBelow] {\n+\n+ protected[io] override def apply(ctx: BelowContext): PipePair[CmdAbove, CmdBelowBelow, EvtAbove, EvtBelowBelow] = {\n+\n+ val leftPL = left(ctx)\n+ val rightPL = right(ctx)\n+\n+ new PipePair[CmdAbove, CmdBelowBelow, EvtAbove, EvtBelowBelow] {\n+\n+ type Output = Either[EvtAbove, CmdBelowBelow]\n+\n+ import language.implicitConversions\n+ @inline implicit def narrowRight[A, B, C](in: Right[A, B]): Right[C, B] = in.asInstanceOf[Right[C, B]]\n+ @inline implicit def narrowLeft[A, B, C](in: Left[A, B]): Left[A, C] = in.asInstanceOf[Left[A, C]]\n+\n+ def loopLeft(input: Iterable[Either[EvtAbove, CmdBelow]]): Iterable[Output] = {\n+ if (input.isEmpty) Nil\n+ else if (input eq ctx.cmd) loopRight(rightPL.commandPipeline(ctx.cmd(0)))\n+ else if (input eq ctx.evt) ctx.evt\n+ else {\n+ val output = Vector.newBuilder[Output]\n+ input foreach {\n+ case Right(cmd) ⇒ output ++= ctx.dealias(loopRight(rightPL.commandPipeline(cmd)))\n+ case l @ Left(_) ⇒ output += l\n+ }\n+ output.result\n+ }\n+ }\n+\n+ def loopRight(input: Iterable[Either[EvtBelow, CmdBelowBelow]]): Iterable[Output] = {\n+ if (input.isEmpty) Nil\n+ else if (input eq ctx.cmd) ctx.cmd\n+ else if (input eq ctx.evt) loopLeft(leftPL.eventPipeline(ctx.evt(0)))\n+ else {\n+ val output = Vector.newBuilder[Output]\n+ input foreach {\n+ case r @ Right(_) ⇒ output += r\n+ case Left(evt) ⇒ output ++= ctx.dealias(loopLeft(leftPL.eventPipeline(evt)))\n+ }\n+ output.result\n+ }\n+ }\n+\n+ override val commandPipeline = { a: CmdAbove ⇒ loopLeft(leftPL.commandPipeline(a)) }\n+\n+ override val eventPipeline = { b: EvtBelowBelow ⇒ loopRight(rightPL.eventPipeline(b)) }\n+\n+ override val managementPort: PartialFunction[AnyRef, Iterable[Either[EvtAbove, CmdBelowBelow]]] = {\n+ case x ⇒\n+ val output = Vector.newBuilder[Output]\n+ output ++= ctx.dealias(loopLeft(leftPL.managementPort.applyOrElse(x, (_: AnyRef) ⇒ Nil)))\n+ output ++= ctx.dealias(loopRight(rightPL.managementPort.applyOrElse(x, (_: AnyRef) ⇒ Nil)))\n+ output.result\n+ }\n+ }\n+ }\n+ }\n+\n+ /**\n+ * Scala API: combine the two stages such that the command pipeline of the\n+ * left stage is used and the event pipeline of the right, discarding the\n+ * other two sub-pipelines.\n+ *\n+ * @param right the event pipeline\n+ * @return a pipeline stage using the left command pipeline and the right event pipeline\n+ */\n+ def |[RightContext <: Context] //\n+ (right: PipelineStage[_ >: RightContext, CmdAbove, CmdBelow, EvtAbove, EvtBelow]) //\n+ : PipelineStage[RightContext, CmdAbove, CmdBelow, EvtAbove, EvtBelow] =\n+ new PipelineStage[RightContext, CmdAbove, CmdBelow, EvtAbove, EvtBelow] {\n+ override def apply(ctx: RightContext): PipePair[CmdAbove, CmdBelow, EvtAbove, EvtBelow] =\n+ new PipePair[CmdAbove, CmdBelow, EvtAbove, EvtBelow] {\n+\n+ val leftPL = left(ctx)\n+ val rightPL = right(ctx)\n+\n+ override val commandPipeline = leftPL.commandPipeline\n+ override val eventPipeline = rightPL.eventPipeline\n+ override val managementPort: Mgmt = {\n+ case x ⇒\n+ val output = Vector.newBuilder[Either[EvtAbove, CmdBelow]]\n+ output ++= ctx.dealias(leftPL.managementPort(x))\n+ output ++= ctx.dealias(rightPL.managementPort(x))\n+ output.result\n+ }\n+ }\n+ }\n+}\n+\n+//#length-field-frame\n+/**\n+ * Pipeline stage for length-field encoded framing. It will prepend a\n+ * four-byte length header to the message; the header contains the length of\n+ * the resulting frame including header in big-endian representation.\n+ *\n+ * The `maxSize` argument is used to protect the communication channel sanity:\n+ * larger frames will not be sent (silently dropped) or received (in which case\n+ * stream decoding would be broken, hence throwing an IllegalArgumentException).\n+ */\n+class LengthFieldFrame(maxSize: Int)\n+ extends SymmetricPipelineStage[PipelineContext, ByteString, ByteString] {\n+\n+ override def apply(ctx: PipelineContext) =\n+ new SymmetricPipePair[ByteString, ByteString] {\n+ var buffer = None: Option[ByteString]\n+ implicit val byteOrder = ByteOrder.BIG_ENDIAN\n+\n+ /**\n+ * Extract as many complete frames as possible from the given ByteString\n+ * and return the remainder together with the extracted frames in reverse\n+ * order.\n+ */\n+ @tailrec\n+ def extractFrames(bs: ByteString, acc: List[ByteString]) //\n+ : (Option[ByteString], Seq[ByteString]) = {\n+ if (bs.isEmpty) {\n+ (None, acc)\n+ } else if (bs.length < 4) {\n+ (Some(bs.compact), acc)\n+ } else {\n+ val length = bs.iterator.getInt\n+ if (length > maxSize)\n+ throw new IllegalArgumentException(\n+ s\"received too large frame of size $length (max = $maxSize)\")\n+ if (bs.length >= length) {\n+ extractFrames(bs drop length, bs.slice(4, length) :: acc)\n+ } else {\n+ (Some(bs.compact), acc)\n+ }\n+ }\n+ }\n+\n+ /*\n+ * This is how commands (writes) are transformed: calculate length\n+ * including header, write that to a ByteStringBuilder and append the\n+ * payload data. The result is a single command (i.e. `Right(...)`).\n+ */\n+ override def commandPipeline =\n+ { bs: ByteString ⇒\n+ val length = bs.length + 4","path":"akka-actor/src/main/scala/akka/io/Pipelines.scala","position":781,"original_position":781,"commit_id":"ff78962c9fc585ca7a1f526ba25de7415706f712","original_commit_id":"ff78962c9fc585ca7a1f526ba25de7415706f712","user":{"login":"rkuhn","id":470469,"avatar_url":"https://secure.gravatar.com/avatar/262b1ab25e66b1e15a48fa3f68703aad?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"262b1ab25e66b1e15a48fa3f68703aad","url":"https://api.github.com/users/rkuhn","html_url":"https://github.com/rkuhn","followers_url":"https://api.github.com/users/rkuhn/followers","following_url":"https://api.github.com/users/rkuhn/following","gists_url":"https://api.github.com/users/rkuhn/gists{/gist_id}","starred_url":"https://api.github.com/users/rkuhn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rkuhn/subscriptions","organizations_url":"https://api.github.com/users/rkuhn/orgs","repos_url":"https://api.github.com/users/rkuhn/repos","events_url":"https://api.github.com/users/rkuhn/events{/privacy}","received_events_url":"https://api.github.com/users/rkuhn/received_events","type":"User"},"created_at":"2013-04-04T09:56:53Z","updated_at":"2013-04-04T09:56:53Z","html_url":"https://github.com/akka/akka/pull/1291#discussion_r3652331","pull_request_url":"https://api.github.com/repos/akka/akka/pulls/1291","_links":{"self":{"href":"https://api.github.com/repos/akka/akka/pulls/comments/3652331"},"html":{"href":"https://github.com/akka/akka/pull/1291#discussion_r3652331"},"pull_request":{"href":"https://api.github.com/repos/akka/akka/pulls/1291"}}}} | {
"id": 130013,
"name": "akka",
"url": "https://github.com/akka/akka"
} | {
"id": null,
"login": "rkuhn",
"gravatar_id": "262b1ab25e66b1e15a48fa3f68703aad",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "akka",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-04-04T09:56:53 | null | {"repository":{"description":"Akka Project","homepage":"http://akka.io","watchers":1598,"stargazers":1598,"forks":330,"fork":false,"size":18644,"owner":"akka","private":false,"open_issues":10,"has_issues":false,"has_downloads":true,"has_wiki":false,"language":"Scala","created_at":"2009-02-16T04:51:54-08:00","pushed_at":"2013-04-04T02:47:36-07:00","integrate_branch":"staging","master_branch":"master","organization":"akka"},"actor_attributes":{"type":"User","name":"Roland Kuhn","company":"Typesafe Inc.","location":"Uppsala, Sweden","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/akka/akka/pull/1291#discussion_r3652331"} |
Subsets and Splits