Search is not available for this dataset
type
stringclasses 17
values | public
bool 2
classes | payload
stringlengths 2
1.27M
| repo
dict | actor
dict | org
dict | created_at
timestamp[us] | id
stringclasses 0
values | other
stringlengths 34
66.4k
|
|---|---|---|---|---|---|---|---|---|
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/ipython/xkcd-font/pulls/comments/6049514","id":6049514,"body":"Has @randallmunroe actually OKed this license specifically for the font?","diff_hunk":"@@ -3,7 +3,7 @@ FontName: xkcd-Regular\n FullName: xkcd Regular\n FamilyName: xkcd\n Weight: Roman\n-Copyright: Untitled is a trademark of PYRS Fontlab Ltd. / Made with FontLab.\n+Copyright: xkcd is licensed under the Creative Commons Attribution-NonCommercial 3.0 License","path":"xkcd.sfd","position":5,"original_position":5,"commit_id":"51f1b759e1c67586ea5c7c85d54fd14fe036ddc0","original_commit_id":"51f1b759e1c67586ea5c7c85d54fd14fe036ddc0","user":{"login":"takluyver","id":327925,"avatar_url":"https://0.gravatar.com/avatar/7f1ae3f14fd5b87c2c3f7b36014e185c?d=https%3A%2F%2Fidenticons.github.com%2Fca06697d9cb91b1d055c2f1a0ece221b.png","gravatar_id":"7f1ae3f14fd5b87c2c3f7b36014e185c","url":"https://api.github.com/users/takluyver","html_url":"https://github.com/takluyver","followers_url":"https://api.github.com/users/takluyver/followers","following_url":"https://api.github.com/users/takluyver/following{/other_user}","gists_url":"https://api.github.com/users/takluyver/gists{/gist_id}","starred_url":"https://api.github.com/users/takluyver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/takluyver/subscriptions","organizations_url":"https://api.github.com/users/takluyver/orgs","repos_url":"https://api.github.com/users/takluyver/repos","events_url":"https://api.github.com/users/takluyver/events{/privacy}","received_events_url":"https://api.github.com/users/takluyver/received_events","type":"User"},"created_at":"2013-08-28T23:21:38Z","updated_at":"2013-08-28T23:21:38Z","html_url":"https://github.com/ipython/xkcd-font/pull/6#discussion_r6049514","pull_request_url":"https://api.github.com/repos/ipython/xkcd-font/pulls/6","_links":{"self":{"href":"https://api.github.com/repos/ipython/xkcd-font/pulls/comments/6049514"},"html":{"href":"https://github.com/ipython/xkcd-font/pull/6#discussion_r6049514"},"pull_request":{"href":"https://api.github.com/repos/ipython/xkcd-font/pulls/6"}}}} | {
"id": 12418387,
"name": "xkcd-font",
"url": "https://github.com/ipython/xkcd-font"
} | {
"id": null,
"login": "takluyver",
"gravatar_id": "7f1ae3f14fd5b87c2c3f7b36014e185c",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "ipython",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-08-28T23:21:38 | null | {"repository":{"description":"The xkcd font","homepage":"","watchers":3,"stargazers":3,"forks":2,"fork":false,"size":195,"owner":"ipython","private":false,"open_issues":3,"has_issues":true,"has_downloads":true,"has_wiki":true,"created_at":"2013-08-27T14:50:45-07:00","pushed_at":"2013-08-28T13:24:31-07:00","master_branch":"master","organization":"ipython"},"actor_attributes":{"type":"User","name":"Thomas Kluyver","location":"UK","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/ipython/xkcd-font/pull/6#discussion_r6049514"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/iron-io/iron_mq_python/pulls/comments/3439254","id":3439254,"body":"We highly recommend you use the new syntax, explained below.","diff_hunk":"@@ -21,95 +17,460 @@ or just copy `iron_mq.py` and include it in your script:\n from iron_mq import *\n ```\n \n-## Configure\n+2\\. [Setup your Iron.io credentials](http://dev.iron.io/mq/reference/configuration/)\n+\n+3\\. Create an IronMQ client object:\n \n ```python\n ironmq = IronMQ()\n+# or pass credentials\n+ironmq = IronMQ(project_id='500f7b....b0f302e9', token='Et1En7.....0LuW39Q')\n ```\n \n-will try reasonable defaults, accepting following optionally:\n \n+## The Basics\n+\n+### Get Queues List\n+\n+```python\n+queues = ironmq.queues() # ['queue1 name', 'queue2 name', ...]\n ```\n-ironmq = IronMQ(host=\"mq-aws-us-east-1.iron.io\",\n- project_id=\"500f7b....b0f302e9\",\n- token=\"Et1En7.....0LuW39Q\",\n- protocol=\"https\", port=443,\n- api_version=1,\n- config_file=None)\n+\n+returns list of `Queue` objects.\n+\n+--\n+\n+### Get a Queue Object\n+\n+You can have as many queues as you want, each with their own unique set of messages.\n+\n+```python\n+queue = ironmq.get('my_queue')\n+# aliases\n+queue = ironmq.queue('my_queue')\n+queue = ironmq.get_queue('my_queue')\n ```\n \n-## The Basics\n+Now you can use it.\n+\n+--\n+\n+### Post a Message on a Queue\n+\n+Messages are placed on the queue in a FIFO arrangement.\n+If a queue does not exist, it will be created upon the first posting of a message.\n+\n+```python\n+queue.post('hello world!')\n+```\n+\n+--\n+\n+### Retrieve Queue Information\n+\n+```python\n+q_info = queue.info()\n+\n+q_id = queue.id()\n+q_size = queue.size()\n+q_name = queue.name\n+```\n+\n+--\n+\n+### Get a Message off a Queue\n+\n+```python\n+msg = queue.get()\n+\n+data = msg.body\n+```\n+\n+When you pop/get a message from the queue, it is no longer on the queue but it still exists within the system.\n+You have to explicitly delete the message or else it will go back onto the queue after the `timeout`.\n+The default `timeout` is 60 seconds. Minimal `timeout` is 30 seconds.\n+\n+--\n+\n+### Delete a Message from a Queue\n+\n+```python\n+msg.delete()\n+```\n+\n+Be sure to delete a message from the queue when you're done with it.\n+\n+--\n+\n+\n+## Important Notes on Backward Compatibility\n+\n+New client library (version 0.4) includes partial backward compatibility with previous version (0.3).\n+Please, read this notes before you will update your client library.\n+\n+* `queue.get()` instantiates `Message` object instead returning a raw response body.\n+To have the same behavior as in version 0.3 set `instantiate` keyword argument to `False`.\n+\n+* `queue.post()` accepts list of messages' bodies by default in new version.\n+To pass prepared `dict` for messages set `raw` keyword argument to `True`.\n+Example:\n+```python\n+message = {'body': 'my body', 'timeout': 300, 'delay': 120}\n+queue.post(message, raw=True)\n+```\n+\n+* `queue.delete(message_id)` is deprecated.\n+Because `queue.delete()` method is used for queue deletion (not supported in version 0.3).\n+\n+* List of unsupported methods (all of them were deprecated in version 0.3):\n+ * `getQueues()`\n+ * `getQueueDetails()`\n+ * `deleteMessage()`\n+ * `postMessage()`\n+ * `getMessage()`\n+ * `clearQueue()`\n+\n+We are highly recomend to use new syntax explained hereinafter.","path":"README.md","position":147,"original_position":147,"commit_id":"17185674adedf5d2a3fc9b95f993cd57e5738fbc","original_commit_id":"17185674adedf5d2a3fc9b95f993cd57e5738fbc","user":{"login":"paddyforan","id":59249,"avatar_url":"https://secure.gravatar.com/avatar/ce539e18df8adc26ecddf0e0273ee3d8?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"ce539e18df8adc26ecddf0e0273ee3d8","url":"https://api.github.com/users/paddyforan","html_url":"https://github.com/paddyforan","followers_url":"https://api.github.com/users/paddyforan/followers","following_url":"https://api.github.com/users/paddyforan/following","gists_url":"https://api.github.com/users/paddyforan/gists{/gist_id}","starred_url":"https://api.github.com/users/paddyforan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paddyforan/subscriptions","organizations_url":"https://api.github.com/users/paddyforan/orgs","repos_url":"https://api.github.com/users/paddyforan/repos","events_url":"https://api.github.com/users/paddyforan/events{/privacy}","received_events_url":"https://api.github.com/users/paddyforan/received_events","type":"User"},"created_at":"2013-03-19T19:49:58Z","updated_at":"2013-03-19T19:49:58Z","html_url":"https://github.com/iron-io/iron_mq_python/pull/15#discussion_r3439254","pull_request_url":"https://api.github.com/repos/iron-io/iron_mq_python/pulls/15","_links":{"self":{"href":"https://api.github.com/repos/iron-io/iron_mq_python/pulls/comments/3439254"},"html":{"href":"https://github.com/iron-io/iron_mq_python/pull/15#discussion_r3439254"},"pull_request":{"href":"https://api.github.com/repos/iron-io/iron_mq_python/pulls/15"}}}} | {
"id": 2871443,
"name": "iron_mq_python",
"url": "https://github.com/iron-io/iron_mq_python"
} | {
"id": null,
"login": "paddyforan",
"gravatar_id": "ce539e18df8adc26ecddf0e0273ee3d8",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "iron-io",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-03-19T19:49:58 | null | {"repository":{"description":"Python client for IronMQ.","homepage":"www.iron.io","watchers":20,"stargazers":20,"forks":14,"fork":false,"size":156,"owner":"iron-io","private":false,"open_issues":4,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Python","created_at":"2011-11-28T16:24:38-08:00","pushed_at":"2013-03-06T07:31:29-08:00","master_branch":"master","organization":"iron-io"},"actor_attributes":{"type":"User","name":"Paddy Foran","company":"Second Bit","blog":"http://paddy.io","location":"Buffalo, NY","email":"[email protected]"},"url":"https://github.com/iron-io/iron_mq_python/pull/15#discussion_r3439254"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/jbossas/jboss-as/pulls/comments/3199784","id":3199784,"body":"I'm not sure why this change from Injector to InjectedValue is needed.\r\n","diff_hunk":"@@ -146,11 +145,11 @@ public EJBRemoteConnectorService getValue() throws IllegalStateException, Illega\n return endpointValue;\n }\n \n- public Injector<TransactionManager> getTransactionManagerInjector() {\n+ public InjectedValue<TransactionManager> getTransactionManagerInjector() {","path":"ejb3/src/main/java/org/jboss/as/ejb3/remote/EJBRemoteConnectorService.java","position":13,"original_position":13,"commit_id":"748014afb73740bee681444b2f05c25c9952d28a","original_commit_id":"748014afb73740bee681444b2f05c25c9952d28a","user":{"login":"jaikiran","id":143523,"avatar_url":"https://secure.gravatar.com/avatar/4978e27b761ffaeac96b5c22c01dfe10?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"4978e27b761ffaeac96b5c22c01dfe10","url":"https://api.github.com/users/jaikiran","html_url":"https://github.com/jaikiran","followers_url":"https://api.github.com/users/jaikiran/followers","following_url":"https://api.github.com/users/jaikiran/following","gists_url":"https://api.github.com/users/jaikiran/gists{/gist_id}","starred_url":"https://api.github.com/users/jaikiran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaikiran/subscriptions","organizations_url":"https://api.github.com/users/jaikiran/orgs","repos_url":"https://api.github.com/users/jaikiran/repos","events_url":"https://api.github.com/users/jaikiran/events{/privacy}","received_events_url":"https://api.github.com/users/jaikiran/received_events","type":"User"},"created_at":"2013-03-01T02:27:02Z","updated_at":"2013-03-01T02:27:02Z","_links":{"self":{"href":"https://api.github.com/repos/jbossas/jboss-as/pulls/comments/3199784"},"html":{"href":"https://github.com/jbossas/jboss-as/pull/4103#discussion_r3199784"},"pull_request":{"href":"https://api.github.com/repos/jbossas/jboss-as/pulls/4103"}}}} | {
"id": 764708,
"name": "jboss-as",
"url": "https://github.com/jbossas/jboss-as"
} | {
"id": null,
"login": "jaikiran",
"gravatar_id": "4978e27b761ffaeac96b5c22c01dfe10",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "jbossas",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-03-01T02:27:02 | null | {"repository":{"description":"JBoss Application Server","homepage":"","watchers":760,"stargazers":760,"forks":673,"fork":false,"size":36588,"owner":"jbossas","private":false,"open_issues":22,"has_issues":true,"has_downloads":true,"has_wiki":false,"language":"Java","created_at":"2010-07-08T13:46:07-07:00","pushed_at":"2013-02-28T16:53:18-08:00","master_branch":"master","organization":"jbossas"},"actor_attributes":{"type":"User","name":"Jaikiran","company":"RedHat JBoss","blog":"http://www.jaitechwriteups.blogspot.com/","location":"India","email":"[email protected]"},"url":"https://github.com/jbossas/jboss-as/pull/4103#discussion_r3199784"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/jclouds/jclouds-labs-openstack/pulls/comments/7656187","id":7656187,"diff_hunk":"@@ -0,0 +1,145 @@\n+/*\n+ * Licensed to jclouds, Inc. (jclouds) under one or more\n+ * contributor license agreements. See the NOTICE file\n+ * distributed with this work for additional information\n+ * regarding copyright ownership. jclouds licenses this file\n+ * to you under the Apache License, Version 2.0 (the\n+ * \"License\"); you may not use this file except in compliance\n+ * with the License. You may obtain a copy of the License at\n+ *\n+ * http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing,\n+ * software distributed under the License is distributed on an\n+ * \"AS IS\" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY\n+ * KIND, either express or implied. See the License for the\n+ * specific language governing permissions and limitations\n+ * under the License.\n+ */\n+package org.jclouds.openstack.marconi.v1.domain;\n+\n+import com.google.common.base.Objects;\n+import org.jclouds.domain.JsonBall;\n+\n+import static com.google.common.base.Preconditions.checkArgument;\n+import static com.google.common.base.Preconditions.checkNotNull;\n+import static java.lang.Integer.getInteger;\n+import static org.jclouds.openstack.marconi.v1.config.MarconiProperties.MESSAGE_BODY_MAX_IN_BYTES;\n+import static org.jclouds.openstack.marconi.v1.config.MarconiProperties.TTL_MAX_IN_SEC;\n+import static org.jclouds.openstack.marconi.v1.config.MarconiProperties.TTL_MIN_IN_SEC;\n+\n+/**\n+ * A message to be sent to a queue.\n+ *\n+ * @author Everett Toews\n+ */\n+public class CreateMessage {\n+\n+ private int ttl;\n+ private String body;\n+\n+ protected CreateMessage(int ttl, String body) {\n+ this.ttl = ttl;\n+ this.body = checkNotNull(body, \"body required\");\n+ }\n+\n+ /**\n+ * @see Builder#ttl(int)\n+ */\n+ public int getTTL() {\n+ return ttl;\n+ }\n+\n+ /**\n+ * @see Builder#body(String)\n+ */\n+ public String getBody() {\n+ return body;\n+ }\n+\n+ @Override\n+ public int hashCode() {\n+ return Objects.hashCode(ttl, body);\n+ }\n+\n+ @Override\n+ public boolean equals(Object obj) {\n+ if (this == obj) return true;\n+ if (obj == null || getClass() != obj.getClass()) return false;\n+ CreateMessage that = CreateMessage.class.cast(obj);\n+ return Objects.equal(this.ttl, that.ttl) && Objects.equal(this.body, that.body);\n+ }\n+\n+ protected Objects.ToStringHelper string() {\n+ return Objects.toStringHelper(this)\n+ .add(\"ttl\", ttl).add(\"body\", body);\n+ }\n+\n+ @Override\n+ public String toString() {\n+ return string().toString();\n+ }\n+\n+ public static Builder builder() {\n+ return new ConcreteBuilder();\n+ }\n+\n+ public Builder toBuilder() {\n+ return new ConcreteBuilder().fromMessage(this);\n+ }\n+\n+ public static abstract class Builder {\n+ protected abstract Builder self();\n+\n+ protected int ttl;\n+ protected String body;\n+\n+ /**\n+ * @param ttl The time-to-live of the message in seconds. The ttl attribute specifies how long the server waits\n+ * before marking the message as expired and removing it from the queue. The valid range of values for\n+ * the ttl are configurable by your cloud provider. To discover them use\n+ * {@code Integer.getInteger(MarconiProperties.TTL_MIN_IN_SEC)} and\n+ * {@code Integer.getInteger(MarconiProperties.TTL_MAX_IN_SEC)}. This method already checks that\n+ * range.\n+ * </p>\n+ * Note that the server might not actually delete the message until its age has reached up to\n+ * (ttl + 60) seconds, to allow for flexibility in storage implementations.\n+ */\n+ public Builder ttl(int ttl) {\n+ checkArgument(ttl >= getInteger(TTL_MIN_IN_SEC), \"ttl must be >= %s\", getInteger(TTL_MIN_IN_SEC));\n+ checkArgument(ttl <= getInteger(TTL_MAX_IN_SEC), \"ttl must be <= %s\", getInteger(TTL_MAX_IN_SEC));","path":"openstack-marconi/src/main/java/org/jclouds/openstack/marconi/v1/domain/CreateMessage.java","position":110,"original_position":110,"commit_id":"2e29156b95955394c3bca2b0fb9e2abc91ab85f6","original_commit_id":"b23991418216b837cef5f5dc9268ead52f79e7a8","user":{"login":"everett-toews","id":634901,"avatar_url":"https://1.gravatar.com/avatar/39ffccdc20c86a170de39e22f43959c8?d=https%3A%2F%2Fidenticons.github.com%2F52c602a57a3c80ab9f76457cd723df6c.png&r=x","gravatar_id":"39ffccdc20c86a170de39e22f43959c8","url":"https://api.github.com/users/everett-toews","html_url":"https://github.com/everett-toews","followers_url":"https://api.github.com/users/everett-toews/followers","following_url":"https://api.github.com/users/everett-toews/following{/other_user}","gists_url":"https://api.github.com/users/everett-toews/gists{/gist_id}","starred_url":"https://api.github.com/users/everett-toews/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/everett-toews/subscriptions","organizations_url":"https://api.github.com/users/everett-toews/orgs","repos_url":"https://api.github.com/users/everett-toews/repos","events_url":"https://api.github.com/users/everett-toews/events{/privacy}","received_events_url":"https://api.github.com/users/everett-toews/received_events","type":"User","site_admin":false},"body":"This got removed.","created_at":"2013-11-14T11:30:22Z","updated_at":"2013-11-14T11:30:22Z","html_url":"https://github.com/jclouds/jclouds-labs-openstack/pull/46#discussion_r7656187","pull_request_url":"https://api.github.com/repos/jclouds/jclouds-labs-openstack/pulls/46","_links":{"self":{"href":"https://api.github.com/repos/jclouds/jclouds-labs-openstack/pulls/comments/7656187"},"html":{"href":"https://github.com/jclouds/jclouds-labs-openstack/pull/46#discussion_r7656187"},"pull_request":{"href":"https://api.github.com/repos/jclouds/jclouds-labs-openstack/pulls/46"}}}} | {
"id": 10040986,
"name": "jclouds-labs-openstack",
"url": "https://github.com/jclouds/jclouds-labs-openstack"
} | {
"id": null,
"login": "everett-toews",
"gravatar_id": "39ffccdc20c86a170de39e22f43959c8",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "jclouds",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-11-14T11:30:22 | null | {"repository":{"description":"Read-only mirror of ASF Git Repo for jclouds labs-openstack. Although this is a \"labs\" repository, some of the providers and APIs here are production ready. Please review the table below or the README in each sub-directory to determine if the provider or API is production ready.","homepage":"","watchers":3,"stargazers":3,"forks":12,"fork":false,"size":1179,"owner":"jclouds","private":false,"open_issues":2,"has_issues":false,"has_downloads":true,"has_wiki":false,"language":"Java","created_at":"2013-05-13T13:48:21-07:00","pushed_at":"2013-11-11T15:18:57-08:00","master_branch":"master","organization":"jclouds"},"actor_attributes":{"type":"User","name":"Everett Toews","company":"Rackspace Inc.","blog":"blog.phymata.com","location":"Austin, TX","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/jclouds/jclouds-labs-openstack/pull/46#discussion_r7656187"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/jclouds/jclouds-examples/pulls/comments/5439235","id":5439235,"body":"It would. But these examples need to work with officially released versions of jclouds, not snapshots. unwrapApi isn't in 1.6.x so I can't use it here. :(","diff_hunk":"@@ -0,0 +1,267 @@\n+/*\n+ * Licensed to the Apache Software Foundation (ASF) under one\n+ * or more contributor license agreements. See the NOTICE file\n+ * distributed with this work for additional information\n+ * regarding copyright ownership. The ASF licenses this file\n+ * to you under the Apache License, Version 2.0 (the\n+ * \"License\"); you may not use this file except in compliance\n+ * with the License. You may obtain a copy of the License at\n+ * \n+ * http://www.apache.org/licenses/LICENSE-2.0\n+ * \n+ * Unless required by applicable law or agreed to in writing,\n+ * software distributed under the License is distributed on an\n+ * \"AS IS\" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY\n+ * KIND, either express or implied. See the License for the\n+ * specific language governing permissions and limitations\n+ * under the License.\n+ */\n+package org.jclouds.examples.rackspace.cloudfiles;\n+\n+import static com.google.common.base.Preconditions.checkArgument;\n+import static java.util.concurrent.Executors.newFixedThreadPool;\n+\n+import java.io.Closeable;\n+import java.io.File;\n+import java.net.URI;\n+import java.util.List;\n+import java.util.concurrent.Callable;\n+import java.util.concurrent.ExecutionException;\n+\n+import org.jclouds.ContextBuilder;\n+import org.jclouds.blobstore.BlobStore;\n+import org.jclouds.blobstore.BlobStoreContext;\n+import org.jclouds.blobstore.domain.Blob;\n+import org.jclouds.cloudfiles.CloudFilesApiMetadata;\n+import org.jclouds.cloudfiles.CloudFilesClient;\n+import org.jclouds.logging.slf4j.config.SLF4JLoggingModule;\n+\n+import com.google.common.collect.ImmutableSet;\n+import com.google.common.collect.Lists;\n+import com.google.common.util.concurrent.FutureCallback;\n+import com.google.common.util.concurrent.Futures;\n+import com.google.common.util.concurrent.ListenableFuture;\n+import com.google.common.util.concurrent.ListeningExecutorService;\n+import com.google.common.util.concurrent.MoreExecutors;\n+import com.google.inject.Module;\n+\n+/**\n+ * Upload an entire directory and all of its sub-directories to a Cloud Files container. The local directory hierarchy\n+ * will be mimicked as pseudo-hierarchical directories (http://j.mp/rax-hier) within the container. This is a great\n+ * way to upload content for a static website (http://j.mp/rax-static). \n+ * \n+ * @author Everett Toews\n+ */\n+public class UploadDirectoryToCDN implements Closeable {\n+ // The provider configures jclouds To use the Rackspace Cloud (US)\n+ // To use the Rackspace Cloud (UK) set the provider to \"cloudfiles-uk\"\n+ public static final String PROVIDER = \"cloudfiles-us\";\n+ public static final int THREADS = 10;\n+ \n+ private final BlobStore storage;\n+ private final CloudFilesClient rackspace;\n+\n+ /**\n+ * To get a username and API key see http://www.jclouds.org/documentation/quickstart/rackspace/\n+ * \n+ * The first argument (args[0]) must be your username\n+ * The second argument (args[1]) must be your API key\n+ * The third argument (args[2]) must be the path to the local directory\n+ * The fourth argument (args[3]) must be the remote container name\n+ */\n+ public static void main(String[] args) {\n+ UploadDirectoryToCDN uploadDirToCDN = new UploadDirectoryToCDN(args[0], args[1]);\n+\n+ try {\n+ uploadDirToCDN.uploadDirectory(args[2], args[3]);\n+ uploadDirToCDN.enableCdnContainer(args[3]);\n+ }\n+ catch (Exception e) {\n+ e.printStackTrace();\n+ }\n+ finally { \n+ uploadDirToCDN.close();\n+ }\n+ }\n+ \n+ public UploadDirectoryToCDN(String username, String apiKey) {\n+ Iterable<Module> modules = ImmutableSet.<Module> of(new SLF4JLoggingModule());\n+ \n+ BlobStoreContext context = ContextBuilder.newBuilder(PROVIDER)\n+ .credentials(username, apiKey)\n+ .modules(modules)\n+ .buildView(BlobStoreContext.class);\n+ storage = context.getBlobStore();\n+ rackspace = context.unwrap(CloudFilesApiMetadata.CONTEXT_TOKEN).getApi();","path":"rackspace/src/main/java/org/jclouds/examples/rackspace/cloudfiles/UploadDirectoryToCDN.java","position":95,"original_position":95,"commit_id":"a53b9570f83101ff5a2503352b39f627462d12f8","original_commit_id":"a53b9570f83101ff5a2503352b39f627462d12f8","user":{"login":"everett-toews","id":634901,"avatar_url":"https://secure.gravatar.com/avatar/39ffccdc20c86a170de39e22f43959c8?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"39ffccdc20c86a170de39e22f43959c8","url":"https://api.github.com/users/everett-toews","html_url":"https://github.com/everett-toews","followers_url":"https://api.github.com/users/everett-toews/followers","following_url":"https://api.github.com/users/everett-toews/following{/other_user}","gists_url":"https://api.github.com/users/everett-toews/gists{/gist_id}","starred_url":"https://api.github.com/users/everett-toews/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/everett-toews/subscriptions","organizations_url":"https://api.github.com/users/everett-toews/orgs","repos_url":"https://api.github.com/users/everett-toews/repos","events_url":"https://api.github.com/users/everett-toews/events{/privacy}","received_events_url":"https://api.github.com/users/everett-toews/received_events","type":"User"},"created_at":"2013-07-28T04:27:31Z","updated_at":"2013-07-28T04:27:31Z","html_url":"https://github.com/jclouds/jclouds-examples/pull/11#discussion_r5439235","pull_request_url":"https://api.github.com/repos/jclouds/jclouds-examples/pulls/11","_links":{"self":{"href":"https://api.github.com/repos/jclouds/jclouds-examples/pulls/comments/5439235"},"html":{"href":"https://github.com/jclouds/jclouds-examples/pull/11#discussion_r5439235"},"pull_request":{"href":"https://api.github.com/repos/jclouds/jclouds-examples/pulls/11"}}}} | {
"id": 10041016,
"name": "jclouds-examples",
"url": "https://github.com/jclouds/jclouds-examples"
} | {
"id": null,
"login": "everett-toews",
"gravatar_id": "39ffccdc20c86a170de39e22f43959c8",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "jclouds",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-07-28T04:27:31 | null | {"repository":{"description":"Read-only mirror of ASF Git Repo for jclouds examples","watchers":6,"stargazers":6,"forks":12,"fork":false,"size":829,"owner":"jclouds","private":false,"open_issues":2,"has_issues":false,"has_downloads":true,"has_wiki":false,"language":"Java","created_at":"2013-05-13T13:49:37-07:00","pushed_at":"2013-07-04T11:32:07-07:00","master_branch":"master","organization":"jclouds"},"actor_attributes":{"type":"User","name":"Everett Toews","company":"Rackspace Inc.","blog":"rackspace.com","location":"Austin, TX","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/jclouds/jclouds-examples/pull/11#discussion_r5439235"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/jclouds/jclouds/pulls/comments/8053684","id":8053684,"diff_hunk":"@@ -41,7 +41,7 @@\n import org.jclouds.atmos.domain.UserMetadata;\n import org.jclouds.atmos.options.ListOptions;\n import org.jclouds.atmos.options.PutOptions;\n-import org.jclouds.blobstore.LocalAsyncBlobStore;\n+import org.jclouds.blobstore.config.LocalBlobStore;","path":"apis/atmos/src/test/java/org/jclouds/atmos/internal/StubAtmosAsyncClient.java","position":5,"original_position":5,"commit_id":"5606904045b6a5cfa6995e49c84601158826cd68","original_commit_id":"5606904045b6a5cfa6995e49c84601158826cd68","user":{"login":"demobox","id":223702,"avatar_url":"https://0.gravatar.com/avatar/e2561ae503aae3d6fac85f8fe228d5ce?d=https%3A%2F%2Fidenticons.github.com%2F135af45e3b6e6e9cda07e8c40e6aa48d.png&r=x","gravatar_id":"e2561ae503aae3d6fac85f8fe228d5ce","url":"https://api.github.com/users/demobox","html_url":"https://github.com/demobox","followers_url":"https://api.github.com/users/demobox/followers","following_url":"https://api.github.com/users/demobox/following{/other_user}","gists_url":"https://api.github.com/users/demobox/gists{/gist_id}","starred_url":"https://api.github.com/users/demobox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/demobox/subscriptions","organizations_url":"https://api.github.com/users/demobox/orgs","repos_url":"https://api.github.com/users/demobox/repos","events_url":"https://api.github.com/users/demobox/events{/privacy}","received_events_url":"https://api.github.com/users/demobox/received_events","type":"User","site_admin":false},"body":"Any reason why `LocalBlobStore` is in the `config` package, by the way?","created_at":"2013-12-03T08:59:42Z","updated_at":"2013-12-03T08:59:42Z","html_url":"https://github.com/jclouds/jclouds/pull/220#discussion_r8053684","pull_request_url":"https://api.github.com/repos/jclouds/jclouds/pulls/220","_links":{"self":{"href":"https://api.github.com/repos/jclouds/jclouds/pulls/comments/8053684"},"html":{"href":"https://github.com/jclouds/jclouds/pull/220#discussion_r8053684"},"pull_request":{"href":"https://api.github.com/repos/jclouds/jclouds/pulls/220"}}}} | {
"id": 10040960,
"name": "jclouds",
"url": "https://github.com/jclouds/jclouds"
} | {
"id": null,
"login": "demobox",
"gravatar_id": "e2561ae503aae3d6fac85f8fe228d5ce",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "jclouds",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-12-03T08:59:42 | null | {"repository":{"description":"Read-only mirror of ASF Git Repo for jclouds","watchers":48,"stargazers":48,"forks":87,"fork":false,"size":143949,"owner":"jclouds","private":false,"open_issues":19,"has_issues":false,"has_downloads":true,"has_wiki":false,"language":"Java","created_at":"2013-05-13T13:47:29-07:00","pushed_at":"2013-12-02T10:30:37-08:00","master_branch":"master","organization":"jclouds"},"actor_attributes":{"type":"User","name":"Andrew Phillips","company":"XebiaLabs","blog":"http://blog.xebialabs.com/author/aphillips","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/jclouds/jclouds/pull/220#discussion_r8053684"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/jubatus/website/pulls/comments/7717451","id":7717451,"diff_hunk":"@@ -0,0 +1,147 @@\n+Clustering\n+----------\n+\n+* See `IDL definition <https://github.com/jubatus/jubatus/blob/master/jubatus/server/server/clustering.idl>`_ for detailed specification.\n+* See :doc:`method` for detailed description of algorithms used in this server.\n+\n+Configuration\n+~~~~~~~~~~~~~\n+\n+configuration is given as a JSON file.\n+We show each filed below:\n+\n+.. describe:: method\n+\n+ Soecify algorithm for clustering.\n+ You can use these algorithms.\n+\n+ .. table::\n+\n+ ==================== ===================================\n+ Vaule Method\n+ ==================== ===================================\n+ ``\"kmeans\"`` Use k-means\n+ ``\"gmm\"`` Use Gaussian Mixture Model\n+ ==================== ===================================\n+\n+.. describe:: parameter\n+\n+ Specify parameters for the algorithm.\n+ \n+ :k:\n+ Number of clusters.\n+ (Integer)\n+\n+ :compressor_method:\n+ Specify alghorithm for compressing points\n+ You can choose in ``simple``, ``compressive_kmeans`` and ``compressive_gmm``. \n+\n+ :bucket_size:\n+ Number of bulk compression size.\n+ You should set equal to dataset size.\n+ (Integer)\n+\n+ :bucket_length:\n+ Size of mini batch clustering.\n+ (Integer)\n+\n+ :compresed_bucket_size:\n+ Number of compressed bucket_size.\n+ Compression ratio = (compressed_bucket_size/bucket_size)\n+ (Integer)\n+\n+ :bicriteria_base_size:\n+ Number of compress roughness.\n+ (Integer)\n+\n+ :forgetting_factor:\n+ forgetting factor\n+ (double)\n+\n+ :forgetting_threshold:\n+ When summation of forgetting factors are this value, It will not compress more.","path":"source/en/api_clustering.rst","position":62,"original_position":62,"commit_id":"d956042a0d0bcc45a06cc8e764f8d97e6be69af4","original_commit_id":"d956042a0d0bcc45a06cc8e764f8d97e6be69af4","user":{"login":"beam2d","id":392019,"avatar_url":"https://2.gravatar.com/avatar/cd89dd1a2c3dcf046cde75f140782db6?d=https%3A%2F%2Fidenticons.github.com%2F8ab2f510d232767f207dc7542417d902.png&r=x","gravatar_id":"cd89dd1a2c3dcf046cde75f140782db6","url":"https://api.github.com/users/beam2d","html_url":"https://github.com/beam2d","followers_url":"https://api.github.com/users/beam2d/followers","following_url":"https://api.github.com/users/beam2d/following{/other_user}","gists_url":"https://api.github.com/users/beam2d/gists{/gist_id}","starred_url":"https://api.github.com/users/beam2d/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beam2d/subscriptions","organizations_url":"https://api.github.com/users/beam2d/orgs","repos_url":"https://api.github.com/users/beam2d/repos","events_url":"https://api.github.com/users/beam2d/events{/privacy}","received_events_url":"https://api.github.com/users/beam2d/received_events","type":"User","site_admin":false},"body":"\"When the summation of forgetting factors exceeds this value, it will not compress any more\" may be better.","created_at":"2013-11-18T06:50:52Z","updated_at":"2013-11-18T06:50:52Z","html_url":"https://github.com/jubatus/website/pull/80#discussion_r7717451","pull_request_url":"https://api.github.com/repos/jubatus/website/pulls/80","_links":{"self":{"href":"https://api.github.com/repos/jubatus/website/pulls/comments/7717451"},"html":{"href":"https://github.com/jubatus/website/pull/80#discussion_r7717451"},"pull_request":{"href":"https://api.github.com/repos/jubatus/website/pulls/80"}}}} | {
"id": 2644458,
"name": "website",
"url": "https://github.com/jubatus/website"
} | {
"id": null,
"login": "beam2d",
"gravatar_id": "cd89dd1a2c3dcf046cde75f140782db6",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "jubatus",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-11-18T06:50:52 | null | {"repository":{"description":"Source of the official website","homepage":"http://jubat.us","watchers":7,"stargazers":7,"forks":19,"fork":false,"size":2571,"owner":"jubatus","private":false,"open_issues":19,"has_issues":true,"has_downloads":true,"has_wiki":false,"language":"Python","created_at":"2011-10-25T08:49:38-07:00","pushed_at":"2013-11-14T22:13:20-08:00","master_branch":"master","organization":"jubatus"},"actor_attributes":{"type":"User","name":"Seiya Tokui","blog":"blog.beam2d.net","location":"Tokyo","email":"[email protected]"},"url":"https://github.com/jubatus/website/pull/80#discussion_r7717451"} |
PullRequestReviewCommentEvent | true | {"comment":{"id":2752467,"created_at":"2013-01-24T01:24:36Z","position":206,"url":"https://api.github.com/repos/karelia/BSManagedDocument/pulls/comments/2752467","original_position":206,"commit_id":"0b945dd8a1de8ca3e978fad354040795bb530ab5","updated_at":"2013-01-24T01:24:36Z","user":{"id":165011,"url":"https://api.github.com/users/mikeabdullah","received_events_url":"https://api.github.com/users/mikeabdullah/received_events","login":"mikeabdullah","gists_url":"https://api.github.com/users/mikeabdullah/gists{/gist_id}","type":"User","avatar_url":"https://secure.gravatar.com/avatar/5be047f7a7d4903252d6aa268d2ed6c9?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"5be047f7a7d4903252d6aa268d2ed6c9","following_url":"https://api.github.com/users/mikeabdullah/following","followers_url":"https://api.github.com/users/mikeabdullah/followers","organizations_url":"https://api.github.com/users/mikeabdullah/orgs","repos_url":"https://api.github.com/users/mikeabdullah/repos","events_url":"https://api.github.com/users/mikeabdullah/events{/privacy}","starred_url":"https://api.github.com/users/mikeabdullah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikeabdullah/subscriptions"},"path":"BSManagedDocument.m","original_commit_id":"0b945dd8a1de8ca3e978fad354040795bb530ab5","_links":{"self":{"href":"https://api.github.com/repos/karelia/BSManagedDocument/pulls/comments/2752467"},"pull_request":{"href":"https://api.github.com/repos/karelia/BSManagedDocument/pulls/8"},"html":{"href":"https://github.com/karelia/BSManagedDocument/pull/8#discussion_r2752467"}},"body":"Well the locking mechanism deliberately allows nested locking from the same thread. You'd have to go pretty far out of your way to deadlock it. It's so unlikely I figure anyone in that situation has either got bigger problems (in over their head re: threading) or is advanced enough to figure out the issue."}} | {
"id": 6505709,
"name": "BSManagedDocument",
"url": "https://github.com/karelia/BSManagedDocument"
} | {
"id": null,
"login": "mikeabdullah",
"gravatar_id": "5be047f7a7d4903252d6aa268d2ed6c9",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "karelia",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-01-24T01:24:36 | null | {"repository":{"stargazers":7,"open_issues":1,"description":"","owner":"karelia","pushed_at":"2013-01-23T16:51:21-08:00","forks":8,"language":"Objective-C","organization":"karelia","has_issues":true,"has_downloads":true,"master_branch":"ksmanageddocument","fork":false,"size":236,"watchers":7,"private":false,"has_wiki":true,"created_at":"2012-11-02T05:20:01-07:00"},"actor_attributes":{"location":"UK","type":"User","company":"Karelia Software","name":"Mike Abdullah","blog":"http://mikeabdullah.net","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/karelia/BSManagedDocument/pull/8#discussion_r2752467"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/libgit2/objective-git/pulls/comments/6508580","id":6508580,"body":"Unnecessary space between `^` and `(`","diff_hunk":"@@ -0,0 +1,60 @@\n+//\n+// NSArray+StringArraySpec.m\n+// ObjectiveGitFramework\n+//\n+// Created by Danny Greg on 22/08/2013.\n+// Copyright (c) 2013 GitHub, Inc. All rights reserved.\n+//\n+\n+SpecBegin(StringArray)\n+\n+describe(@\"String arrays\", ^{\n+\t__block NSArray *originalArray = nil;\n+\t__block git_strarray strArray;\n+\t\n+\tbeforeEach(^{\n+\t\toriginalArray = @[ @\"First\", @\"Second\", @\"Third\", @\"Fourth\", @\"Fifth\", @\"Sixth\" ];\n+\t\tstrArray = originalArray.git_strarray;\n+\t});\n+\t\n+\tafterEach(^{\n+\t\tgit_strarray_free(&strArray);\n+\t});\n+\t\n+\tit(@\"should return null for an empty array\", ^{\n+\t\tNSArray *emptyArray = [NSArray array];\n+\t\texpect(emptyArray.git_strarray.count).to.equal(0);\n+\t\texpect(emptyArray.git_strarray.strings).to.beNil();\n+\t});\n+\n+\tvoid (^validateStrArray)(git_strarray) = ^ (git_strarray arrayToValidate) {","path":"ObjectiveGitTests/NSArray+StringArraySpec.m","position":30,"original_position":30,"commit_id":"c044ae8829d55469403fc39950a992454c886514","original_commit_id":"c044ae8829d55469403fc39950a992454c886514","user":{"login":"jspahrsummers","id":432536,"avatar_url":"https://1.gravatar.com/avatar/cac992bb300ed4f3ed5c2a6049e552f9?d=https%3A%2F%2Fidenticons.github.com%2F109cfb1cc6c3edc0afdcf6a670eb0f33.png","gravatar_id":"cac992bb300ed4f3ed5c2a6049e552f9","url":"https://api.github.com/users/jspahrsummers","html_url":"https://github.com/jspahrsummers","followers_url":"https://api.github.com/users/jspahrsummers/followers","following_url":"https://api.github.com/users/jspahrsummers/following{/other_user}","gists_url":"https://api.github.com/users/jspahrsummers/gists{/gist_id}","starred_url":"https://api.github.com/users/jspahrsummers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jspahrsummers/subscriptions","organizations_url":"https://api.github.com/users/jspahrsummers/orgs","repos_url":"https://api.github.com/users/jspahrsummers/repos","events_url":"https://api.github.com/users/jspahrsummers/events{/privacy}","received_events_url":"https://api.github.com/users/jspahrsummers/received_events","type":"User"},"created_at":"2013-09-23T06:52:37Z","updated_at":"2013-09-23T06:52:37Z","html_url":"https://github.com/libgit2/objective-git/pull/239#discussion_r6508580","pull_request_url":"https://api.github.com/repos/libgit2/objective-git/pulls/239","_links":{"self":{"href":"https://api.github.com/repos/libgit2/objective-git/pulls/comments/6508580"},"html":{"href":"https://github.com/libgit2/objective-git/pull/239#discussion_r6508580"},"pull_request":{"href":"https://api.github.com/repos/libgit2/objective-git/pulls/239"}}}} | {
"id": 1427977,
"name": "objective-git",
"url": "https://github.com/libgit2/objective-git"
} | {
"id": null,
"login": "jspahrsummers",
"gravatar_id": "cac992bb300ed4f3ed5c2a6049e552f9",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "libgit2",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-09-23T06:52:37 | null | {"repository":{"description":"Objective-C bindings to libgit2","homepage":"","watchers":442,"stargazers":442,"forks":88,"fork":false,"size":18810,"owner":"libgit2","private":false,"open_issues":22,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Objective-C","created_at":"2011-03-01T13:28:58-08:00","pushed_at":"2013-09-18T14:34:21-07:00","master_branch":"master","organization":"libgit2"},"actor_attributes":{"type":"User","name":"Justin Spahr-Summers","company":"GitHub","blog":"jspahrsummers.github.com","location":"Seattle, WA","email":"[email protected]"},"url":"https://github.com/libgit2/objective-git/pull/239#discussion_r6508580"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/libgit2/objective-git/pulls/comments/7550608","id":7550608,"diff_hunk":"@@ -0,0 +1,92 @@\n+//\n+// GTBlobSpec.m\n+// ObjectiveGitFramework\n+//\n+// Created by Etienne Samson on 2013-11-07.\n+// Copyright (c) 2013 GitHub, Inc. All rights reserved.\n+//\n+\n+#import \"GTBlob.h\"\n+\n+SpecBegin(GTBlob)\n+\n+__block GTRepository *repository;\n+__block NSString *blobSHA;\n+__block GTBlob *blob;\n+__block NSError *error;\n+\n+beforeEach(^{\n+\terror = nil;\n+});\n+\n+describe(@\"blob properties can be accessed\", ^{\n+\tbeforeEach(^{\n+\t\trepository = self.bareFixtureRepository;\n+\t\tblobSHA = @\"fa49b077972391ad58037050f2a75f74e3671e92\";\n+\t\tblob = [repository lookupObjectBySHA:blobSHA objectType:GTObjectTypeBlob error:NULL];\n+\t\texpect(blob).notTo.beNil();","path":"ObjectiveGitTests/GTBlobSpec.m","position":22,"original_position":27,"commit_id":"78a25aa72b2e1482fd50dc1bcdca49eedea03cad","original_commit_id":"9c2c3e2741d58dce8bcdb694ce173a3dccff410e","user":{"login":"alanjrogers","id":22635,"avatar_url":"https://2.gravatar.com/avatar/e7c5b25cc6a66344d4bdae461a9129ec?d=https%3A%2F%2Fidenticons.github.com%2Fc16117de1309f508633dae03c0804a0b.png&r=x","gravatar_id":"e7c5b25cc6a66344d4bdae461a9129ec","url":"https://api.github.com/users/alanjrogers","html_url":"https://github.com/alanjrogers","followers_url":"https://api.github.com/users/alanjrogers/followers","following_url":"https://api.github.com/users/alanjrogers/following{/other_user}","gists_url":"https://api.github.com/users/alanjrogers/gists{/gist_id}","starred_url":"https://api.github.com/users/alanjrogers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alanjrogers/subscriptions","organizations_url":"https://api.github.com/users/alanjrogers/orgs","repos_url":"https://api.github.com/users/alanjrogers/repos","events_url":"https://api.github.com/users/alanjrogers/events{/privacy}","received_events_url":"https://api.github.com/users/alanjrogers/received_events","type":"User","site_admin":true},"body":"LOL yeah, it looks like we're actually 50/50 on this even in the GitHub for Mac codebase.","created_at":"2013-11-10T23:39:07Z","updated_at":"2013-11-10T23:39:07Z","html_url":"https://github.com/libgit2/objective-git/pull/292#discussion_r7550608","pull_request_url":"https://api.github.com/repos/libgit2/objective-git/pulls/292","_links":{"self":{"href":"https://api.github.com/repos/libgit2/objective-git/pulls/comments/7550608"},"html":{"href":"https://github.com/libgit2/objective-git/pull/292#discussion_r7550608"},"pull_request":{"href":"https://api.github.com/repos/libgit2/objective-git/pulls/292"}}}} | {
"id": 1427977,
"name": "objective-git",
"url": "https://github.com/libgit2/objective-git"
} | {
"id": null,
"login": "alanjrogers",
"gravatar_id": "e7c5b25cc6a66344d4bdae461a9129ec",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "libgit2",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-11-10T23:39:07 | null | {"repository":{"description":"Objective-C bindings to libgit2","homepage":"","watchers":462,"stargazers":462,"forks":98,"fork":false,"size":20286,"owner":"libgit2","private":false,"open_issues":21,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Objective-C","created_at":"2011-03-01T13:28:58-08:00","pushed_at":"2013-11-09T05:40:07-08:00","master_branch":"master","organization":"libgit2"},"actor_attributes":{"type":"User","name":"Alan Rogers","company":"GitHub Inc.","blog":"","location":"Melbourne, Australia","email":"[email protected]"},"url":"https://github.com/libgit2/objective-git/pull/292#discussion_r7550608"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/libgit2/objective-git/pulls/comments/6802066","id":6802066,"diff_hunk":"@@ -0,0 +1,62 @@\n+#!/bin/sh\n+\n+function xcode_major_version {\n+ local XCODE_VERSION=`/usr/bin/xcodebuild -version | head -n 1 | sed -E 's/Xcode ([0-9\\.]*)/\\1/'`\n+\n+ local XCODE_MAJOR_VERSION=`echo $XCODE_VERSION | awk -F '.' '{ print $1 }'`\n+\n+ echo $XCODE_MAJOR_VERSION\n+}\n+\n+function prepare_build_variables {\n+ local DIR=\"$( cd \"$( dirname \"${BASH_SOURCE[0]}\" )\" && pwd )\"\n+ CURRENT_PATH=`dirname ${DIR}`","path":"script/update_ios_lib","position":13,"original_position":13,"commit_id":"2b691775b20526bf4077ec6ea53ff4beae903103","original_commit_id":"2b691775b20526bf4077ec6ea53ff4beae903103","user":{"login":"jspahrsummers","id":432536,"avatar_url":"https://0.gravatar.com/avatar/cac992bb300ed4f3ed5c2a6049e552f9?d=https%3A%2F%2Fidenticons.github.com%2F109cfb1cc6c3edc0afdcf6a670eb0f33.png","gravatar_id":"cac992bb300ed4f3ed5c2a6049e552f9","url":"https://api.github.com/users/jspahrsummers","html_url":"https://github.com/jspahrsummers","followers_url":"https://api.github.com/users/jspahrsummers/followers","following_url":"https://api.github.com/users/jspahrsummers/following{/other_user}","gists_url":"https://api.github.com/users/jspahrsummers/gists{/gist_id}","starred_url":"https://api.github.com/users/jspahrsummers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jspahrsummers/subscriptions","organizations_url":"https://api.github.com/users/jspahrsummers/orgs","repos_url":"https://api.github.com/users/jspahrsummers/repos","events_url":"https://api.github.com/users/jspahrsummers/events{/privacy}","received_events_url":"https://api.github.com/users/jspahrsummers/received_events","type":"User"},"body":"This is unused, and is equivalent to `$PWD` anyways.","created_at":"2013-10-07T16:24:12Z","updated_at":"2013-10-07T16:24:12Z","html_url":"https://github.com/libgit2/objective-git/pull/269#discussion_r6802066","pull_request_url":"https://api.github.com/repos/libgit2/objective-git/pulls/269","_links":{"self":{"href":"https://api.github.com/repos/libgit2/objective-git/pulls/comments/6802066"},"html":{"href":"https://github.com/libgit2/objective-git/pull/269#discussion_r6802066"},"pull_request":{"href":"https://api.github.com/repos/libgit2/objective-git/pulls/269"}}}} | {
"id": 1427977,
"name": "objective-git",
"url": "https://github.com/libgit2/objective-git"
} | {
"id": null,
"login": "jspahrsummers",
"gravatar_id": "cac992bb300ed4f3ed5c2a6049e552f9",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "libgit2",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-10-07T16:24:12 | null | {"repository":{"description":"Objective-C bindings to libgit2","homepage":"","watchers":448,"stargazers":448,"forks":89,"fork":false,"size":19150,"owner":"libgit2","private":false,"open_issues":17,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Objective-C","created_at":"2011-03-01T13:28:58-08:00","pushed_at":"2013-10-06T16:16:05-07:00","master_branch":"master","organization":"libgit2"},"actor_attributes":{"type":"User","name":"Justin Spahr-Summers","company":"GitHub","blog":"jspahrsummers.github.com","location":"Seattle, WA","email":"[email protected]"},"url":"https://github.com/libgit2/objective-git/pull/269#discussion_r6802066"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/libgit2/libgit2/pulls/comments/7636295","id":7636295,"diff_hunk":"@@ -662,7 +662,7 @@ void gitno_connection_data_free_ptrs(gitno_connection_data *d)\n static char* unescape(char *str)\n {\n \tint x, y;\n-\tint len = strlen(str);\n+\tsize_t len = strlen(str);","path":"src/netops.c","position":5,"original_position":5,"commit_id":"fb190bbbd06952b369b4fb6c06fa827802671332","original_commit_id":"fb190bbbd06952b369b4fb6c06fa827802671332","user":{"login":"arrbee","id":103350,"avatar_url":"https://1.gravatar.com/avatar/66e82696b38beea60f0e0afe40b0c870?d=https%3A%2F%2Fidenticons.github.com%2F483f75935678d0ad179292518e4f6fc9.png&r=x","gravatar_id":"66e82696b38beea60f0e0afe40b0c870","url":"https://api.github.com/users/arrbee","html_url":"https://github.com/arrbee","followers_url":"https://api.github.com/users/arrbee/followers","following_url":"https://api.github.com/users/arrbee/following{/other_user}","gists_url":"https://api.github.com/users/arrbee/gists{/gist_id}","starred_url":"https://api.github.com/users/arrbee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arrbee/subscriptions","organizations_url":"https://api.github.com/users/arrbee/orgs","repos_url":"https://api.github.com/users/arrbee/repos","events_url":"https://api.github.com/users/arrbee/events{/privacy}","received_events_url":"https://api.github.com/users/arrbee/received_events","type":"User","site_admin":true},"body":"On my system, this change added a warning instead of eliminating one.","created_at":"2013-11-13T18:58:30Z","updated_at":"2013-11-13T18:58:30Z","html_url":"https://github.com/libgit2/libgit2/pull/1957#discussion_r7636295","pull_request_url":"https://api.github.com/repos/libgit2/libgit2/pulls/1957","_links":{"self":{"href":"https://api.github.com/repos/libgit2/libgit2/pulls/comments/7636295"},"html":{"href":"https://github.com/libgit2/libgit2/pull/1957#discussion_r7636295"},"pull_request":{"href":"https://api.github.com/repos/libgit2/libgit2/pulls/1957"}}}} | {
"id": 901662,
"name": "libgit2",
"url": "https://github.com/libgit2/libgit2"
} | {
"id": null,
"login": "arrbee",
"gravatar_id": "66e82696b38beea60f0e0afe40b0c870",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "libgit2",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-11-13T18:58:30 | null | {"repository":{"description":"The Library","homepage":"http://libgit2.github.com","watchers":2987,"stargazers":2987,"forks":659,"fork":false,"size":41206,"owner":"libgit2","private":false,"open_issues":77,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"C","created_at":"2010-09-10T09:17:48-07:00","pushed_at":"2013-11-13T09:41:24-08:00","master_branch":"development","organization":"libgit2"},"actor_attributes":{"type":"User","name":"Russell Belfer","company":"GitHub","location":"San Francisco, CA","email":"[email protected]"},"url":"https://github.com/libgit2/libgit2/pull/1957#discussion_r7636295"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/libgit2/objective-git/pulls/comments/6935355","id":6935355,"diff_hunk":"@@ -130,4 +133,19 @@\n // Returns a new GTTree, or nil if an error occurred.\n - (GTTree *)writeTree:(NSError **)error;\n \n+// Enumerate through any conflicts in the index, running the provided block each\n+// time.\n+//\n+// Immediately returns `YES` if there are no conflicts in the index.","path":"Classes/GTIndex.h","position":17,"original_position":17,"commit_id":"d748a08955ddc2e3b63360ac34ad2923cf9e31df","original_commit_id":"d748a08955ddc2e3b63360ac34ad2923cf9e31df","user":{"login":"dannygreg","id":62405,"avatar_url":"https://1.gravatar.com/avatar/c2e40adce99a3780789b370a2bfa02f6?d=https%3A%2F%2Fidenticons.github.com%2F50011d0dfb7fef8a77b64b35d7a8cd22.png","gravatar_id":"c2e40adce99a3780789b370a2bfa02f6","url":"https://api.github.com/users/dannygreg","html_url":"https://github.com/dannygreg","followers_url":"https://api.github.com/users/dannygreg/followers","following_url":"https://api.github.com/users/dannygreg/following{/other_user}","gists_url":"https://api.github.com/users/dannygreg/gists{/gist_id}","starred_url":"https://api.github.com/users/dannygreg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dannygreg/subscriptions","organizations_url":"https://api.github.com/users/dannygreg/orgs","repos_url":"https://api.github.com/users/dannygreg/repos","events_url":"https://api.github.com/users/dannygreg/events{/privacy}","received_events_url":"https://api.github.com/users/dannygreg/received_events","type":"User","site_admin":true},"body":"Indeed, that's the problem of writing the returns statement last I guess :p.","created_at":"2013-10-13T18:43:14Z","updated_at":"2013-10-13T18:43:14Z","html_url":"https://github.com/libgit2/objective-git/pull/274#discussion_r6935355","pull_request_url":"https://api.github.com/repos/libgit2/objective-git/pulls/274","_links":{"self":{"href":"https://api.github.com/repos/libgit2/objective-git/pulls/comments/6935355"},"html":{"href":"https://github.com/libgit2/objective-git/pull/274#discussion_r6935355"},"pull_request":{"href":"https://api.github.com/repos/libgit2/objective-git/pulls/274"}}}} | {
"id": 1427977,
"name": "objective-git",
"url": "https://github.com/libgit2/objective-git"
} | {
"id": null,
"login": "dannygreg",
"gravatar_id": "c2e40adce99a3780789b370a2bfa02f6",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "libgit2",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-10-13T18:43:14 | null | {"repository":{"description":"Objective-C bindings to libgit2","homepage":"","watchers":451,"stargazers":451,"forks":89,"fork":false,"size":19655,"owner":"libgit2","private":false,"open_issues":17,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Objective-C","created_at":"2011-03-01T13:28:58-08:00","pushed_at":"2013-10-13T00:40:16-07:00","master_branch":"master","organization":"libgit2"},"actor_attributes":{"type":"User","name":"Danny Greg","company":"GitHub","blog":"dannygreg.com","email":"[email protected]"},"url":"https://github.com/libgit2/objective-git/pull/274#discussion_r6935355"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/comments/4835183","id":4835183,"body":"Or not! Maybe this was from a test I never committed. It allows us to insert a mock CachingReader without having to pass CachingReader in to the EngineBuffer constructor.","diff_hunk":"@@ -905,6 +905,7 @@ void EngineBuffer::slotEjectTrack(double v) {\n }\n }\n \n+/*","path":"src/engine/enginebuffer.cpp","position":4,"original_position":4,"commit_id":"f8df430e47102b2e5a9a495fc9e3378ac6eb9eb0","original_commit_id":"f8df430e47102b2e5a9a495fc9e3378ac6eb9eb0","user":{"login":"rryan","id":26527,"avatar_url":"https://secure.gravatar.com/avatar/169672d4f18bf00666136d090a74693f?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"169672d4f18bf00666136d090a74693f","url":"https://api.github.com/users/rryan","html_url":"https://github.com/rryan","followers_url":"https://api.github.com/users/rryan/followers","following_url":"https://api.github.com/users/rryan/following{/other_user}","gists_url":"https://api.github.com/users/rryan/gists{/gist_id}","starred_url":"https://api.github.com/users/rryan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rryan/subscriptions","organizations_url":"https://api.github.com/users/rryan/orgs","repos_url":"https://api.github.com/users/rryan/repos","events_url":"https://api.github.com/users/rryan/events{/privacy}","received_events_url":"https://api.github.com/users/rryan/received_events","type":"User"},"created_at":"2013-06-24T02:01:51Z","updated_at":"2013-06-24T02:01:51Z","html_url":"https://github.com/mixxxdj/mixxx/pull/24#discussion_r4835183","pull_request_url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/24","_links":{"self":{"href":"https://api.github.com/repos/mixxxdj/mixxx/pulls/comments/4835183"},"html":{"href":"https://github.com/mixxxdj/mixxx/pull/24#discussion_r4835183"},"pull_request":{"href":"https://api.github.com/repos/mixxxdj/mixxx/pulls/24"}}}} | {
"id": 10126031,
"name": "mixxx",
"url": "https://github.com/mixxxdj/mixxx"
} | {
"id": null,
"login": "rryan",
"gravatar_id": "169672d4f18bf00666136d090a74693f",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "mixxxdj",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-06-24T02:01:51 | null | {"repository":{"description":"Mixxx is Free DJ software that gives you everything you need to perform live mixes.","homepage":"http://mixxx.org","watchers":12,"stargazers":12,"forks":17,"fork":false,"size":30984,"owner":"mixxxdj","private":false,"open_issues":14,"has_issues":false,"has_downloads":true,"has_wiki":false,"language":"C++","created_at":"2013-05-17T08:14:38-07:00","pushed_at":"2013-06-23T09:44:25-07:00","master_branch":"master","organization":"mixxxdj"},"actor_attributes":{"type":"User","name":"RJ Ryan","blog":"rustyryan.net","location":"Cambridge, MA","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/mixxxdj/mixxx/pull/24#discussion_r4835183"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/comments/8519335","id":8519335,"diff_hunk":"@@ -203,27 +210,24 @@ void VinylControlXwax::analyzeSamples(const short *samples, size_t nFrames)\n // polling everytime we get a buffer.\n \n \n- //Check if vinyl control is enabled...\n- bIsEnabled = checkEnabled(bIsEnabled, enabled->get());\n+ // Check if vinyl control is enabled...\n+ m_bIsEnabled = checkEnabled(m_bIsEnabled, enabled->get());\n \n- //Get the pitch range from the prefs.\n- fRateRange = rateRange->get();\n-\n- if(bHaveSignal)\n- {\n+ if(bHaveSignal) {\n // Always analyze the input samples\n- iPosition = timecoder_get_position(&timecoder, NULL);\n+ m_iPosition = timecoder_get_position(&timecoder, NULL);\n //Notify the UI if the timecode quality is good\n- establishQuality(iPosition != -1);\n+ establishQuality(m_iPosition != -1);\n }\n \n //are we even playing and enabled at all?\n- if (!bIsEnabled)\n+ if (!m_bIsEnabled)\n return;\n \n- dVinylPitch = timecoder_get_pitch(&timecoder);\n+ double dVinylPitch = timecoder_get_pitch(&timecoder);\n \n- //if no track loaded, let track selection work but that's it\n+ // if no track loaded, let track selection work but that's it\n+ // TODO(rryan): This is dead code since duration is always non-NULL.\n if (duration == NULL)","path":"src/vinylcontrol/vinylcontrolxwax.cpp","position":211,"original_position":211,"commit_id":"d89e9ec252863683d3040985f2ead2a953fda7a1","original_commit_id":"d89e9ec252863683d3040985f2ead2a953fda7a1","user":{"login":"ywwg","id":888940,"avatar_url":"https://gravatar.com/avatar/4014ed6d62e2c214b8be9099508e0a10?d=https%3A%2F%2Fidenticons.github.com%2F2e458729f93d1bb468225584e2b1b10a.png&r=x","gravatar_id":"4014ed6d62e2c214b8be9099508e0a10","url":"https://api.github.com/users/ywwg","html_url":"https://github.com/ywwg","followers_url":"https://api.github.com/users/ywwg/followers","following_url":"https://api.github.com/users/ywwg/following{/other_user}","gists_url":"https://api.github.com/users/ywwg/gists{/gist_id}","starred_url":"https://api.github.com/users/ywwg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ywwg/subscriptions","organizations_url":"https://api.github.com/users/ywwg/orgs","repos_url":"https://api.github.com/users/ywwg/repos","events_url":"https://api.github.com/users/ywwg/events{/privacy}","received_events_url":"https://api.github.com/users/ywwg/received_events","type":"User","site_admin":false},"body":"it looks like we always set duration == 0 when we unload a track, so I think that's the right change.","created_at":"2013-12-22T05:03:07Z","updated_at":"2013-12-22T05:03:07Z","html_url":"https://github.com/mixxxdj/mixxx/pull/129#discussion_r8519335","pull_request_url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/129","_links":{"self":{"href":"https://api.github.com/repos/mixxxdj/mixxx/pulls/comments/8519335"},"html":{"href":"https://github.com/mixxxdj/mixxx/pull/129#discussion_r8519335"},"pull_request":{"href":"https://api.github.com/repos/mixxxdj/mixxx/pulls/129"}}}} | {
"id": 10126031,
"name": "mixxx",
"url": "https://github.com/mixxxdj/mixxx"
} | {
"id": null,
"login": "ywwg",
"gravatar_id": "4014ed6d62e2c214b8be9099508e0a10",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "mixxxdj",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-12-22T05:03:07 | null | {"repository":{"description":"Mixxx is Free DJ software that gives you everything you need to perform live mixes.","homepage":"http://mixxx.org","watchers":48,"stargazers":48,"forks":51,"fork":false,"size":290529,"owner":"mixxxdj","private":false,"open_issues":13,"has_issues":false,"has_downloads":true,"has_wiki":false,"language":"C++","created_at":"2013-05-17T08:14:38-07:00","pushed_at":"2013-12-21T20:59:07-08:00","master_branch":"master","organization":"mixxxdj"},"actor_attributes":{"type":"User","name":"Owen Williams","blog":"mixxx.org","email":"[email protected]"},"url":"https://github.com/mixxxdj/mixxx/pull/129#discussion_r8519335"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/mongodb/mongo-php-driver/pulls/comments/5965841","id":5965841,"body":"I don't understand why? It's a valid document at this point already, just not with the things that should be in there. ","diff_hunk":"@@ -819,41 +830,142 @@ zval *php_mongodb_runcommand(zval *zmongoclient, mongo_read_preference *read_pre\n \tMONGO_METHOD(MongoCursor, getNext, retval, cursor);\n \tclear_exception(retval TSRMLS_CC);\n \n+\t/* Before we destroy the cursor, we figure out which connection was used.\n+\t * Yes, this is quite ugly but necessary for cursor commands. */\n+\tif (used_connection) {\n+\t\t*used_connection = cursor_tmp->connection;\n+\t}\n+\n \tzend_objects_store_del_ref(cursor TSRMLS_CC);\n \tzval_ptr_dtor(&cursor);\n \n \treturn retval;\n }\n+/* }}} */\n \n-zval* mongo_db__create_fake_cursor(mongo_connection *connection, char *database, zval *cmd TSRMLS_DC)\n+PHP_METHOD(MongoDB, command)\n+{\n+\tzval *cmd, *retval, *options = NULL;\n+\tmongo_db *db;\n+\n+\tif (zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, \"z|a\", &cmd, &options) == FAILURE) {\n+\t\treturn;\n+\t}\n+\n+\tMUST_BE_ARRAY_OR_OBJECT(1, cmd);\n+\n+\tPHP_MONGO_GET_DB(getThis());\n+\n+\tretval = php_mongodb_runcommand(db->link, &db->read_pref, Z_STRVAL_P(db->name), Z_STRLEN_P(db->name), cmd, options, 0, NULL TSRMLS_CC);\n+\tif (retval) {\n+\t\tRETVAL_ZVAL(retval, 0, 1);\n+\t}\n+}\n+\n+/* {{{ Command cursor helpers */\n+static int mongo_db_get_cursor_id(zval *document, int64_t *cursor_id TSRMLS_DC)\n+{\n+\tzval **cursor = NULL, **id = NULL;\n+\tzval *id_value;\n+\n+\tif (Z_TYPE_P(document) != IS_ARRAY) {\n+\t\treturn FAILURE;\n+\t}\n+\n+\tif (zend_hash_find(Z_ARRVAL_P(document), \"cursor\", sizeof(\"cursor\"), (void **)&cursor) == FAILURE) {\n+\t\treturn FAILURE;\n+\t}\n+\tif (Z_TYPE_PP(cursor) != IS_ARRAY) {\n+\t\treturn FAILURE;\n+\t}\n+\tif (zend_hash_find(Z_ARRVAL_PP(cursor), \"id\", sizeof(\"id\"), (void **)&id) == FAILURE) {\n+\t\treturn FAILURE;\n+\t}\n+\tif (Z_TYPE_PP(id) != IS_OBJECT || Z_OBJCE_PP(id) != mongo_ce_Int64) {\n+\t\treturn FAILURE;\n+\t}\n+\tid_value = zend_read_property(mongo_ce_Int64, *id, \"value\", strlen(\"value\"), NOISY TSRMLS_CC);\n+\tif (Z_TYPE_P(id_value) != IS_STRING) {\n+\t\treturn FAILURE;\n+\t}\n+\t*cursor_id = strtoll(Z_STRVAL_P(id_value), NULL, 10);\n+\n+\treturn SUCCESS;\n+}\n+\n+PHP_METHOD(MongoDB, cursorCommand)\n+{\n+\tzval *cmd, *retval, *options = NULL;\n+\tmongo_db *db;\n+\tzval *cursor_option;\n+\tint64_t cursor_id;\n+\tmongo_connection *connection;\n+\n+\tif (zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, \"a|a\", &cmd, &options) == FAILURE) {\n+\t\treturn;\n+\t}\n+\n+\tMUST_BE_ARRAY_OR_OBJECT(1, cmd);\n+\n+\t/* Force cursor option */\n+\tMAKE_STD_ZVAL(cursor_option);\n+\tarray_init(cursor_option);\n+\tadd_assoc_long(cursor_option, \"batchSize\", 0);\n+\tadd_assoc_zval(cmd, \"cursor\", cursor_option);\n+\n+\tPHP_MONGO_GET_DB(getThis());\n+\n+\tretval = php_mongodb_runcommand(db->link, &db->read_pref, Z_STRVAL_P(db->name), Z_STRLEN_P(db->name), cmd, options, 1, (mongo_connection**) &connection TSRMLS_CC);\n+\n+\tif (!retval) {\n+\t\treturn;\n+\t}\n+\n+\t/* Checks for the \"ok\" flag in the document */\n+\tif (php_mongo_trigger_error_on_command_failure(retval TSRMLS_CC) == FAILURE) {\n+\t\tzval_ptr_dtor(&retval);\n+\t\tRETURN_FALSE;\n+\t}\n+\n+\t/* Fetch the 64bit cursor ID for our psuedo cursor */\n+\tif (mongo_db_get_cursor_id(retval, &cursor_id TSRMLS_CC) == FAILURE) {\n+\t\tzend_throw_exception(mongo_ce_ResultException, \"The returned document does not return a valid cursor ID\", 3 TSRMLS_CC);","path":"db.c","position":263,"original_position":263,"commit_id":"8ad6da692343fd387a8f59bbbde9af93ae5950de","original_commit_id":"8ad6da692343fd387a8f59bbbde9af93ae5950de","user":{"login":"derickr","id":208074,"avatar_url":"https://1.gravatar.com/avatar/2ef995275795830995d4241368713176?d=https%3A%2F%2Fidenticons.github.com%2F5350e19da7a913fef8751229986a509c.png","gravatar_id":"2ef995275795830995d4241368713176","url":"https://api.github.com/users/derickr","html_url":"https://github.com/derickr","followers_url":"https://api.github.com/users/derickr/followers","following_url":"https://api.github.com/users/derickr/following{/other_user}","gists_url":"https://api.github.com/users/derickr/gists{/gist_id}","starred_url":"https://api.github.com/users/derickr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/derickr/subscriptions","organizations_url":"https://api.github.com/users/derickr/orgs","repos_url":"https://api.github.com/users/derickr/repos","events_url":"https://api.github.com/users/derickr/events{/privacy}","received_events_url":"https://api.github.com/users/derickr/received_events","type":"User"},"created_at":"2013-08-24T13:46:08Z","updated_at":"2013-08-24T13:46:08Z","html_url":"https://github.com/mongodb/mongo-php-driver/pull/515#discussion_r5965841","pull_request_url":"https://api.github.com/repos/mongodb/mongo-php-driver/pulls/515","_links":{"self":{"href":"https://api.github.com/repos/mongodb/mongo-php-driver/pulls/comments/5965841"},"html":{"href":"https://github.com/mongodb/mongo-php-driver/pull/515#discussion_r5965841"},"pull_request":{"href":"https://api.github.com/repos/mongodb/mongo-php-driver/pulls/515"}}}} | {
"id": 121842,
"name": "mongo-php-driver",
"url": "https://github.com/mongodb/mongo-php-driver"
} | {
"id": null,
"login": "derickr",
"gravatar_id": "2ef995275795830995d4241368713176",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "mongodb",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-08-24T13:46:08 | null | {"repository":{"description":"Officially supported PHP driver for MongoDB","homepage":"http://www.mongodb.org/display/DOCS/PHP+Language+Center","watchers":729,"stargazers":729,"forks":167,"fork":false,"size":8812,"owner":"mongodb","private":false,"open_issues":6,"has_issues":false,"has_downloads":true,"has_wiki":false,"language":"PHP","created_at":"2009-02-04T13:30:35-08:00","pushed_at":"2013-08-23T14:14:44-07:00","master_branch":"master","organization":"mongodb"},"actor_attributes":{"type":"User","name":"Derick Rethans","company":"","blog":"http://derickrethans.nl","location":"London, England","email":"[email protected]"},"url":"https://github.com/mongodb/mongo-php-driver/pull/515#discussion_r5965841"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/mongodb/mongo-php-driver/pulls/comments/4085319","id":4085319,"body":"@bjori: I believe at this point, any status `2` response was indicative of a cursor timeout, correct?","diff_hunk":"@@ -183,7 +183,15 @@ int php_mongo_get_reply(mongo_cursor *cursor, zval *errmsg TSRMLS_DC)\n \n \tstatus = get_cursor_header(cursor->connection, cursor, (char**) &error_message TSRMLS_CC);\n \tif (status == -1 || status > 0) {\n-\t\tmongo_cursor_throw(cursor->connection, status TSRMLS_CC, \"%s\", error_message);\n+\t\tzend_class_entry *exception_ce;\n+\n+\t\tif (status == 2 || status == 80) {","path":"cursor.c","position":16,"original_position":16,"commit_id":"c722b78040eb56472cdf68cd6982a683060a24d3","original_commit_id":"c722b78040eb56472cdf68cd6982a683060a24d3","user":{"login":"jmikola","id":244663,"avatar_url":"https://secure.gravatar.com/avatar/f23700b51dc0c196c1dc02f84aeeecdf?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"f23700b51dc0c196c1dc02f84aeeecdf","url":"https://api.github.com/users/jmikola","html_url":"https://github.com/jmikola","followers_url":"https://api.github.com/users/jmikola/followers","following_url":"https://api.github.com/users/jmikola/following{/other_user}","gists_url":"https://api.github.com/users/jmikola/gists{/gist_id}","starred_url":"https://api.github.com/users/jmikola/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmikola/subscriptions","organizations_url":"https://api.github.com/users/jmikola/orgs","repos_url":"https://api.github.com/users/jmikola/repos","events_url":"https://api.github.com/users/jmikola/events{/privacy}","received_events_url":"https://api.github.com/users/jmikola/received_events","type":"User"},"created_at":"2013-05-04T17:20:31Z","updated_at":"2013-05-04T17:20:31Z","html_url":"https://github.com/mongodb/mongo-php-driver/pull/432#discussion_r4085319","pull_request_url":"https://api.github.com/repos/mongodb/mongo-php-driver/pulls/432","_links":{"self":{"href":"https://api.github.com/repos/mongodb/mongo-php-driver/pulls/comments/4085319"},"html":{"href":"https://github.com/mongodb/mongo-php-driver/pull/432#discussion_r4085319"},"pull_request":{"href":"https://api.github.com/repos/mongodb/mongo-php-driver/pulls/432"}}}} | {
"id": 121842,
"name": "mongo-php-driver",
"url": "https://github.com/mongodb/mongo-php-driver"
} | {
"id": null,
"login": "jmikola",
"gravatar_id": "f23700b51dc0c196c1dc02f84aeeecdf",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "mongodb",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-05-04T17:20:31 | null | {"repository":{"description":"Officially supported PHP driver for MongoDB","homepage":"http://www.mongodb.org/display/DOCS/PHP+Language+Center","watchers":673,"stargazers":673,"forks":147,"fork":false,"size":11586,"owner":"mongodb","private":false,"open_issues":5,"has_issues":false,"has_downloads":true,"has_wiki":false,"language":"PHP","created_at":"2009-02-04T13:30:35-08:00","pushed_at":"2013-05-02T13:21:12-07:00","master_branch":"master","organization":"mongodb"},"actor_attributes":{"type":"User","name":"Jeremy Mikola","company":"10gen","blog":"http://jmikola.net","location":"Hoboken, NJ","email":"[email protected]"},"url":"https://github.com/mongodb/mongo-php-driver/pull/432#discussion_r4085319"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/mozilla/mcom-tests/pulls/comments/5933811","id":5933811,"body":"This doesn't seem right to me -- does/should /xbl/ really go to/get redirected to /NPL/?\r\n\r\nAlso, shouldn't there be a separate NPL test, if the above is true?","diff_hunk":"@@ -161,3 +161,34 @@ def test_locale_redirect_for_newsletter(self, mozwebqa):\n url = mozwebqa.base_url + '/newsletter'\n response = requests.get(url, headers={'Accept-Language': 'pl'})\n Assert.equal(response.url, mozwebqa.base_url + '/pl/newsletter/')\n+\n+ @pytest.mark.nondestructive\n+ def test_mpl_redirect(self, mozwebqa):\n+ url = mozwebqa.base_url + '/MPL'\n+ response = requests.get(url, headers={'Accept-Language': 'en-US'})\n+ Assert.not_equal(response.status_code, 404)\n+\n+ @pytest.mark.nondestructive\n+ def test_xbl_redirect(self, mozwebqa):","path":"tests/test_redirect.py","position":12,"original_position":12,"commit_id":"bf9d3577d3334997dadf25ca4cee9c89bd1a342f","original_commit_id":"bf9d3577d3334997dadf25ca4cee9c89bd1a342f","user":{"login":"stephendonner","id":387249,"avatar_url":"https://1.gravatar.com/avatar/1777a6697ad64ddbdcefa432f5ec22a6?d=https%3A%2F%2Fidenticons.github.com%2Fe92004a1af5b560110ae2c2cc9534e5d.png","gravatar_id":"1777a6697ad64ddbdcefa432f5ec22a6","url":"https://api.github.com/users/stephendonner","html_url":"https://github.com/stephendonner","followers_url":"https://api.github.com/users/stephendonner/followers","following_url":"https://api.github.com/users/stephendonner/following{/other_user}","gists_url":"https://api.github.com/users/stephendonner/gists{/gist_id}","starred_url":"https://api.github.com/users/stephendonner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephendonner/subscriptions","organizations_url":"https://api.github.com/users/stephendonner/orgs","repos_url":"https://api.github.com/users/stephendonner/repos","events_url":"https://api.github.com/users/stephendonner/events{/privacy}","received_events_url":"https://api.github.com/users/stephendonner/received_events","type":"User"},"created_at":"2013-08-22T19:09:13Z","updated_at":"2013-08-22T19:09:13Z","html_url":"https://github.com/mozilla/mcom-tests/pull/227#discussion_r5933811","pull_request_url":"https://api.github.com/repos/mozilla/mcom-tests/pulls/227","_links":{"self":{"href":"https://api.github.com/repos/mozilla/mcom-tests/pulls/comments/5933811"},"html":{"href":"https://github.com/mozilla/mcom-tests/pull/227#discussion_r5933811"},"pull_request":{"href":"https://api.github.com/repos/mozilla/mcom-tests/pulls/227"}}}} | {
"id": 1613982,
"name": "mcom-tests",
"url": "https://github.com/mozilla/mcom-tests"
} | {
"id": null,
"login": "stephendonner",
"gravatar_id": "1777a6697ad64ddbdcefa432f5ec22a6",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "mozilla",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-08-22T19:09:13 | null | {"repository":{"description":"","homepage":"","watchers":18,"stargazers":18,"forks":34,"fork":false,"size":817,"owner":"mozilla","private":false,"open_issues":9,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Python","created_at":"2011-04-14T05:24:33-07:00","pushed_at":"2013-08-13T17:21:07-07:00","master_branch":"master","organization":"mozilla"},"actor_attributes":{"type":"User","name":"Stephen Donner","company":"Mozilla Corporation","blog":"http://weblogs.mozillazine.org/stephend","location":"Mountain View, CA","email":"[email protected]"},"url":"https://github.com/mozilla/mcom-tests/pull/227#discussion_r5933811"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/mozilla/pdf.js/pulls/comments/7987545","id":7987545,"diff_hunk":"@@ -814,6 +819,7 @@ var PDFView = {\n mozL10n.get('page_of', {pageCount: pagesCount}, 'of {{pageCount}}');\n document.getElementById('pageNumber').max = pagesCount;\n \n+ var prefs = PDFView.prefs = new Preferences();","path":"web/viewer.js","position":34,"original_position":34,"commit_id":"60610cd625d46d7d73439ac93eae66d7c3504c69","original_commit_id":"60610cd625d46d7d73439ac93eae66d7c3504c69","user":{"login":"Rob--W","id":1365071,"avatar_url":"https://2.gravatar.com/avatar/c916d92c098426d84778a7910cc32b39?d=https%3A%2F%2Fidenticons.github.com%2Ffa390125ecd6a3f22d01712909ce84ae.png&r=x","gravatar_id":"c916d92c098426d84778a7910cc32b39","url":"https://api.github.com/users/Rob--W","html_url":"https://github.com/Rob--W","followers_url":"https://api.github.com/users/Rob--W/followers","following_url":"https://api.github.com/users/Rob--W/following{/other_user}","gists_url":"https://api.github.com/users/Rob--W/gists{/gist_id}","starred_url":"https://api.github.com/users/Rob--W/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rob--W/subscriptions","organizations_url":"https://api.github.com/users/Rob--W/orgs","repos_url":"https://api.github.com/users/Rob--W/repos","events_url":"https://api.github.com/users/Rob--W/events{/privacy}","received_events_url":"https://api.github.com/users/Rob--W/received_events","type":"User","site_admin":false},"body":"I agree that using preferences in a single file (viewer.js) gives a better overview (even though \"hunting for them in different files\" is straightforwards with any decent text editor or CLI. `grep -r 'Preferences\\.'`).\r\n\r\nYour suggestion works for *getting* the preference, but it does not help at setting the preference (Hand tool can be toggled using <kbd>H</kbd> shortcut, or by clicking the button in the secondary toolbar). Because the preferences are currently initialized only when the PDF is loaded, it is not possible to reliably use the Preferences API outside that specific code block.","created_at":"2013-11-28T15:36:24Z","updated_at":"2013-11-28T15:36:24Z","html_url":"https://github.com/mozilla/pdf.js/pull/3850#discussion_r7987545","pull_request_url":"https://api.github.com/repos/mozilla/pdf.js/pulls/3850","_links":{"self":{"href":"https://api.github.com/repos/mozilla/pdf.js/pulls/comments/7987545"},"html":{"href":"https://github.com/mozilla/pdf.js/pull/3850#discussion_r7987545"},"pull_request":{"href":"https://api.github.com/repos/mozilla/pdf.js/pulls/3850"}}}} | {
"id": 1663468,
"name": "pdf.js",
"url": "https://github.com/mozilla/pdf.js"
} | {
"id": null,
"login": "Rob--W",
"gravatar_id": "c916d92c098426d84778a7910cc32b39",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "mozilla",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-11-28T15:36:24 | null | {"repository":{"description":"PDF Reader in JavaScript","homepage":"","watchers":7277,"stargazers":7277,"forks":1352,"fork":false,"size":83301,"owner":"mozilla","private":false,"open_issues":4,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"JavaScript","created_at":"2011-04-25T23:32:03-07:00","pushed_at":"2013-11-26T11:14:12-08:00","master_branch":"master","organization":"mozilla"},"actor_attributes":{"type":"User","name":"Rob Wu","blog":"https://robwu.nl/","location":"The Netherlands","email":"[email protected]"},"url":"https://github.com/mozilla/pdf.js/pull/3850#discussion_r7987545"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/mozilla/openbadges/pulls/comments/3340974","id":3340974,"body":"I added it when jp and I were debugging things. `port` used to be what `remote_port` is now, and we used to just hardcode the app port to whatever (or use `up` to determine the binding port). At some point, someone changed it so the port is now bound based on the configuration, so we had to add back in something with the semantics of the original.","diff_hunk":"@@ -1,21 +1,54 @@\n const test = require('tap').test;\n const utils = require('../lib/utils');\n \n-var conf = require('../lib/configuration');\n+function makeTestConf(opts) {\n+ function get(key) { return this[key] }\n+ opts.get = get;\n+ return opts;\n+}\n+\n+test('utils#determinePort', function (t) {\n+ t.same(utils.determinePort(makeTestConf({\n+ protocol: 'http', port: '80',\n+ })), null);\n+ t.same(utils.determinePort(makeTestConf({\n+ protocol: 'https', port: '443',\n+ })), null);\n+ t.same(utils.determinePort(makeTestConf({\n+ protocol: 'http', port: 8000, remote_port: '80',","path":"test/utils.test.js","position":19,"original_position":19,"commit_id":"0ae9801bdaa0da1ebacdd9881deace2a438001b6","original_commit_id":"95c2c6efba2dad779960dcdc390468e9af5053c2","user":{"login":"brianloveswords","id":166258,"avatar_url":"https://secure.gravatar.com/avatar/b3898d14200a393d1410d663758b6edb?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"b3898d14200a393d1410d663758b6edb","url":"https://api.github.com/users/brianloveswords","html_url":"https://github.com/brianloveswords","followers_url":"https://api.github.com/users/brianloveswords/followers","following_url":"https://api.github.com/users/brianloveswords/following","gists_url":"https://api.github.com/users/brianloveswords/gists{/gist_id}","starred_url":"https://api.github.com/users/brianloveswords/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brianloveswords/subscriptions","organizations_url":"https://api.github.com/users/brianloveswords/orgs","repos_url":"https://api.github.com/users/brianloveswords/repos","events_url":"https://api.github.com/users/brianloveswords/events{/privacy}","received_events_url":"https://api.github.com/users/brianloveswords/received_events","type":"User"},"created_at":"2013-03-12T18:44:09Z","updated_at":"2013-03-12T18:44:09Z","html_url":"https://github.com/mozilla/openbadges/pull/757#discussion_r3340974","pull_request_url":"https://api.github.com/repos/mozilla/openbadges/pulls/757","_links":{"self":{"href":"https://api.github.com/repos/mozilla/openbadges/pulls/comments/3340974"},"html":{"href":"https://github.com/mozilla/openbadges/pull/757#discussion_r3340974"},"pull_request":{"href":"https://api.github.com/repos/mozilla/openbadges/pulls/757"}}}} | {
"id": 1726649,
"name": "openbadges",
"url": "https://github.com/mozilla/openbadges"
} | {
"id": null,
"login": "brianloveswords",
"gravatar_id": "b3898d14200a393d1410d663758b6edb",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "mozilla",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-03-12T18:44:09 | null | {"repository":{"description":"Mozilla Open Badges project. Currently in beta.","homepage":"http://openbadges.org/","watchers":321,"stargazers":321,"forks":80,"fork":false,"size":1020,"owner":"mozilla","private":false,"open_issues":190,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"JavaScript","created_at":"2011-05-09T23:51:42-07:00","pushed_at":"2013-03-12T11:16:26-07:00","master_branch":"development","organization":"mozilla"},"actor_attributes":{"type":"User","name":"Brian J Brennan","company":"Mozilla Foundation","blog":"http://bjb.io","location":"Brooklyn, New York","email":"[email protected]"},"url":"https://github.com/mozilla/openbadges/pull/757#discussion_r3340974"} |
PullRequestReviewCommentEvent | true | {"comment":{"body":"Nit: don't really need the else here since the conditional always terminates with a `return`","url":"https://api.github.com/repos/mozilla/openbadges/pulls/comments/2703982","original_commit_id":"cf04ec756be97f7bde5b087552b41d7b60c37730","updated_at":"2013-01-19T00:21:41Z","id":2703982,"original_position":8,"_links":{"html":{"href":"https://github.com/mozilla/openbadges/pull/471#discussion_r2703982"},"pull_request":{"href":"https://api.github.com/repos/mozilla/openbadges/pulls/471"},"self":{"href":"https://api.github.com/repos/mozilla/openbadges/pulls/comments/2703982"}},"path":"app.js","created_at":"2013-01-19T00:21:41Z","user":{"starred_url":"https://api.github.com/users/brianloveswords/starred{/owner}{/repo}","following_url":"https://api.github.com/users/brianloveswords/following","followers_url":"https://api.github.com/users/brianloveswords/followers","repos_url":"https://api.github.com/users/brianloveswords/repos","received_events_url":"https://api.github.com/users/brianloveswords/received_events","url":"https://api.github.com/users/brianloveswords","avatar_url":"https://secure.gravatar.com/avatar/b3898d14200a393d1410d663758b6edb?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","id":166258,"gists_url":"https://api.github.com/users/brianloveswords/gists{/gist_id}","login":"brianloveswords","organizations_url":"https://api.github.com/users/brianloveswords/orgs","type":"User","subscriptions_url":"https://api.github.com/users/brianloveswords/subscriptions","gravatar_id":"b3898d14200a393d1410d663758b6edb","events_url":"https://api.github.com/users/brianloveswords/events{/privacy}"},"position":8,"commit_id":"cf04ec756be97f7bde5b087552b41d7b60c37730"}} | {
"id": 1726649,
"name": "openbadges",
"url": "https://github.com/mozilla/openbadges"
} | {
"id": null,
"login": "brianloveswords",
"gravatar_id": "b3898d14200a393d1410d663758b6edb",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "mozilla",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-01-19T00:21:41 | null | {"repository":{"pushed_at":"2013-01-18T16:13:11-08:00","homepage":"http://openbadges.org/","forks":68,"owner":"mozilla","created_at":"2011-05-09T23:51:42-07:00","organization":"mozilla","has_issues":true,"has_downloads":true,"description":"Mozilla Open Badges project. Currently in beta.","open_issues":149,"watchers":293,"has_wiki":true,"fork":false,"size":284,"stargazers":293,"language":"JavaScript","private":false,"master_branch":"development"},"actor_attributes":{"company":"Mozilla Foundation","name":"Brian J Brennan","blog":"http://bjb.io","email":"[email protected]","type":"User","location":"Brooklyn, New York"},"url":"https://github.com/mozilla/openbadges/pull/471#discussion_r2703982"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/mozilla/lumbergh/pulls/comments/7027317","id":7027317,"diff_hunk":"@@ -195,3 +200,499 @@\n @media (min-width: 1281px) {\n #splash { background-image: url(/static/img/careers-banner-2560.jpg); }\n }\n+\n+/* -------------------------------------------------------------------\n+ Life at Mozilla\n+ ------------------------------------------------------------------- */\n+\n+#life {\n+ overflow: hidden; _overflow: visible; zoom: 1; /* clearfix */\n+ padding: 20px 0;\n+ background: #414f5a url(/static/img/perks-bg.png) top center;\n+ color: #fff;\n+ font-size: 15px;\n+}\n+\n+.life-head {\n+ margin: 0 0 15px 0;\n+ color: #a2a2a9;\n+ font-size: 26px;\n+}\n+\n+.life-intro-head {\n+ margin: 15px 0;\n+ font-family: 'Open Sans Light',sans-serif;\n+ font-size: 38px;\n+}\n+\n+#life-gallery {\n+ margin: 30px 0;\n+ height: 226px;\n+}\n+\n+.life-perks-head {\n+ font-size: 21px;\n+ font-weight: bold;\n+}\n+\n+#life-perks {\n+ position: relative;\n+ text-align: center;\n+}\n+\n+.life-perk {\n+ width: 100%;\n+ float: left;\n+ padding: 0 0 20px 0;\n+ text-align: center;\n+ vertical-align: top;\n+}\n+\n+.life-perk > h4 {\n+ position: relative;\n+ padding-top: 85px;\n+ font-weight: bold;\n+ text-transform: uppercase;\n+}\n+\n+ .life-perk > h4:before,\n+ .life-perk > h4:after {\n+ content: '\\e005';\n+ position: absolute;\n+ top: 0;\n+ left: 50%;\n+ display: block;\n+ height: 70px;\n+ width: 80px;\n+ margin-left: -40px;\n+ font-size: 74px;\n+ line-height: 70px;\n+ text-align: center;\n+ }\n+\n+ .life-perk > h4:before {\n+ color: #2e3a42;\n+\n+ }\n+ .life-perk > h4:after {\n+ content: '';\n+ margin-top: -2px;\n+ color: #4a5966;\n+ font-size: 40px;\n+ }\n+\n+ .life-perk-medical > h4:after { content: '\\e001'; margin-top: 2px; }\n+ .life-perk-quarterly > h4:after { content: '\\e00d'; margin-top: -2px; }\n+ .life-perk-remote > h4:after { content: '\\e004'; padding-left: 1px; font-size: 30px; }\n+ .life-perk-personal > h4:after { content: '\\e007'; margin-top: 0px; }\n+ .life-perk-office > h4:after { content: '\\e00a'; padding-left: 1px; }\n+ .life-perk-snacks > h4:after { content: '\\e008'; margin-top: 0px; }\n+\n+@media (min-width: 680px) {\n+\n+ #life {\n+ padding: 30px 0;\n+ }\n+\n+ .life-head {\n+ display:none;\n+ }\n+\n+ .life-intro-head {\n+ font-size: 28px;\n+ }\n+\n+ .life-intro-head,\n+ .life-intro {\n+ margin-left: auto;\n+ margin-right: auto;\n+ max-width: 460px;\n+ text-align: center;\n+ }\n+\n+ #life-gallery {\n+ margin: 50px 0;\n+ height: 345px;\n+ }\n+\n+ #life-perks-perks {\n+ margin:0 -20px 0 0;\n+\n+ }\n+\n+ .life-perk {\n+ display: inline-block;\n+ moz-box-sizing: border-box;\n+ box-sizing: border-box;\n+ width: 33.3%;\n+ float: left;\n+ padding-right: 20px;\n+ text-align: left;\n+ vertical-align: top;\n+ }\n+\n+ .life-perk:nth-child(3n+1) {\n+ clear: both;\n+ }\n+\n+ .life-perk > h4:before,\n+ .life-perk > h4:after {\n+ left: 0;\n+ margin-left: -6px;\n+ }\n+}\n+\n+@media (min-width: 921px) {\n+\n+ #life {\n+ padding: 50px 0;\n+ }\n+\n+ .life-intro-head {\n+ max-width: 620px;\n+ font-size: 38px;\n+ }\n+\n+ .life-intro {\n+ max-width: 620px;\n+ }\n+\n+ #life-gallery {\n+ height: 460px;\n+ margin: 60px 0;\n+ }\n+\n+ .life-perks-head {\n+ font-size: 26px;\n+ }\n+\n+\n+}\n+\n+\n+ /* - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -\n+ Life - Carousel\n+ - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - */\n+\n+/* javascript enabled but no media query support */\n+#life-gallery { display: none;}\n+\n+/* no javascript and no media queries */\n+.js-disabled #life-gallery {\n+ display: block;\n+ height: 345px;\n+ background-image: url(/static/img/gallery/gallery-tablet-1.jpg);\n+}\n+\n+/* real browsers\n+ - height set by media queries\n+ - other configerations set by class added by js\n+ */\n+\n+@media (max-width:680px) {\n+ #life-gallery,\n+ #life-blocks { height:225px; }","path":"careers/careers/static/css/careers.css","position":218,"original_position":218,"commit_id":"a81f213e957d0eb39672efea40e8bc9f617a03b0","original_commit_id":"a81f213e957d0eb39672efea40e8bc9f617a03b0","user":{"login":"alexgibson","id":400117,"avatar_url":"https://0.gravatar.com/avatar/36de55354bf2cfda4c8eafda6a33e0c4?d=https%3A%2F%2Fidenticons.github.com%2F6a4365c900c301ea693fb0a69eef7559.png","gravatar_id":"36de55354bf2cfda4c8eafda6a33e0c4","url":"https://api.github.com/users/alexgibson","html_url":"https://github.com/alexgibson","followers_url":"https://api.github.com/users/alexgibson/followers","following_url":"https://api.github.com/users/alexgibson/following{/other_user}","gists_url":"https://api.github.com/users/alexgibson/gists{/gist_id}","starred_url":"https://api.github.com/users/alexgibson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexgibson/subscriptions","organizations_url":"https://api.github.com/users/alexgibson/orgs","repos_url":"https://api.github.com/users/alexgibson/repos","events_url":"https://api.github.com/users/alexgibson/events{/privacy}","received_events_url":"https://api.github.com/users/alexgibson/received_events","type":"User","site_admin":false},"body":"Let's put the property on its own line here (same with selectors below)","created_at":"2013-10-17T09:26:09Z","updated_at":"2013-10-17T09:26:09Z","html_url":"https://github.com/mozilla/lumbergh/pull/57#discussion_r7027317","pull_request_url":"https://api.github.com/repos/mozilla/lumbergh/pulls/57","_links":{"self":{"href":"https://api.github.com/repos/mozilla/lumbergh/pulls/comments/7027317"},"html":{"href":"https://github.com/mozilla/lumbergh/pull/57#discussion_r7027317"},"pull_request":{"href":"https://api.github.com/repos/mozilla/lumbergh/pulls/57"}}}} | {
"id": 2803877,
"name": "lumbergh",
"url": "https://github.com/mozilla/lumbergh"
} | {
"id": null,
"login": "alexgibson",
"gravatar_id": "36de55354bf2cfda4c8eafda6a33e0c4",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "mozilla",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-10-17T09:26:09 | null | {"repository":{"description":"Whaaaat's happening? Careers website... Mmmkay?","homepage":"http://careers.mozilla.org","watchers":7,"stargazers":7,"forks":15,"fork":false,"size":27832,"owner":"mozilla","private":false,"open_issues":9,"has_issues":true,"has_downloads":true,"has_wiki":false,"language":"Python","created_at":"2011-11-18T08:36:34-08:00","pushed_at":"2013-10-16T07:02:31-07:00","master_branch":"master","organization":"mozilla"},"actor_attributes":{"type":"User","name":"Alex Gibson","company":"Mozilla","blog":"http://alxgbsn.co.uk","location":"Newcastle upon Tyne, UK","email":"[email protected]"},"url":"https://github.com/mozilla/lumbergh/pull/57#discussion_r7027317"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/mozilla/gaia-ui-tests/pulls/comments/5112862","id":5112862,"body":"we define a notification as a `title` and a `body` so I think is appropriate ","diff_hunk":"@@ -0,0 +1,32 @@\n+# This Source Code Form is subject to the terms of the Mozilla Public\n+# License, v. 2.0. If a copy of the MPL was not distributed with this\n+# file, You can obtain one at http://mozilla.org/MPL/2.0/.\n+\n+from gaiatest.apps.base import Base\n+from gaiatest.apps.base import PageRegion\n+\n+\n+class UtilityTray(Base):\n+ _notification_container_locator = ('id', 'notifications-container')\n+ _desktop_notifications_locator = ('css selector', '#desktop-notifications-container .notification')\n+ _notification_clear_locator = ('id', 'notification-clear')\n+\n+ def wait_for_notification_container_displayed(self):\n+ # Marionette cannot read the displayed state of the notification container so we wait for its state\n+ self.wait_for_condition(lambda m: m.find_element(*self._notification_container_locator).location['y'] > 0)\n+\n+ @property\n+ def notifications(self):\n+ return [Notification(self.marionette, notification)\n+ for notification in self.marionette.find_elements(*self._desktop_notifications_locator)]\n+\n+ def tap_clear_all(self):\n+ self.marionette.find_element(*self._notification_clear_locator).tap()\n+\n+\n+class Notification(PageRegion):\n+ _body_locator = ('css selector', 'div.detail')\n+\n+ @property\n+ def body(self):","path":"gaiatest/apps/system/regions/utility_tray.py","position":31,"original_position":31,"commit_id":"030fd14cbbe32a146b0163af4e35a27596ca896f","original_commit_id":"030fd14cbbe32a146b0163af4e35a27596ca896f","user":{"login":"bebef1987","id":703611,"avatar_url":"https://secure.gravatar.com/avatar/77a6657b87d0604634d880dfda11e336?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"77a6657b87d0604634d880dfda11e336","url":"https://api.github.com/users/bebef1987","html_url":"https://github.com/bebef1987","followers_url":"https://api.github.com/users/bebef1987/followers","following_url":"https://api.github.com/users/bebef1987/following{/other_user}","gists_url":"https://api.github.com/users/bebef1987/gists{/gist_id}","starred_url":"https://api.github.com/users/bebef1987/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bebef1987/subscriptions","organizations_url":"https://api.github.com/users/bebef1987/orgs","repos_url":"https://api.github.com/users/bebef1987/repos","events_url":"https://api.github.com/users/bebef1987/events{/privacy}","received_events_url":"https://api.github.com/users/bebef1987/received_events","type":"User"},"created_at":"2013-07-10T11:54:54Z","updated_at":"2013-07-10T11:54:54Z","html_url":"https://github.com/mozilla/gaia-ui-tests/pull/1068#discussion_r5112862","pull_request_url":"https://api.github.com/repos/mozilla/gaia-ui-tests/pulls/1068","_links":{"self":{"href":"https://api.github.com/repos/mozilla/gaia-ui-tests/pulls/comments/5112862"},"html":{"href":"https://github.com/mozilla/gaia-ui-tests/pull/1068#discussion_r5112862"},"pull_request":{"href":"https://api.github.com/repos/mozilla/gaia-ui-tests/pulls/1068"}}}} | {
"id": 6697439,
"name": "gaia-ui-tests",
"url": "https://github.com/mozilla/gaia-ui-tests"
} | {
"id": null,
"login": "bebef1987",
"gravatar_id": "77a6657b87d0604634d880dfda11e336",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "mozilla",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-07-10T11:54:54 | null | {"repository":{"description":"UI tests for Gaia","watchers":10,"stargazers":10,"forks":63,"fork":false,"size":2536,"owner":"mozilla","private":false,"open_issues":5,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Python","created_at":"2012-11-14T16:41:29-08:00","pushed_at":"2013-07-10T04:02:12-07:00","master_branch":"master","organization":"mozilla"},"actor_attributes":{"type":"User","name":"Florin Strugariu","company":" ","location":"Romania","email":"[email protected]"},"url":"https://github.com/mozilla/gaia-ui-tests/pull/1068#discussion_r5112862"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/mozilla/kitsune/pulls/comments/4950175","id":4950175,"body":"Docstring formatting.","diff_hunk":"@@ -0,0 +1,229 @@\n+from functools import wraps\n+import re\n+import time\n+\n+from tower import ugettext as _\n+\n+from django.conf import settings\n+from django.http import HttpResponse, HttpResponseBadRequest\n+\n+from kitsune.offline.index import TFIDFIndex, find_word_locations_western\n+from kitsune.wiki.config import CATEGORIES\n+from kitsune.wiki.models import Document\n+\n+\n+_noscript_regex = re.compile(r'<noscript>.*?</noscript>', flags=re.DOTALL)\n+\n+\n+def bundle_key(locale, product_slug):\n+ \"\"\"The key for a bundle as stored in client-side's indexeddb. The\n+ arguments to this function must be strings. This key is used for the index.\n+ \"\"\"\n+ return locale + '~' + product_slug\n+\n+\n+def doc_key(locale, doc_slug):\n+ \"\"\"The key for a document as stored in client-side's indexeddb. The\n+ arguments to this function must be strings.\n+ \"\"\"\n+ return locale + '~' + doc_slug\n+\n+\n+def topic_key(locale, product_slug, topic_slug):\n+ \"\"\"The key for a topic as stored in client-side's indexeddb. The","path":"kitsune/offline/utils.py","position":33,"original_position":33,"commit_id":"af225d17fe48920396bdd869d14d2a96a37f3860","original_commit_id":"af225d17fe48920396bdd869d14d2a96a37f3860","user":{"login":"mythmon","id":305049,"avatar_url":"https://secure.gravatar.com/avatar/c6b8139c802fb2123f01ad1ee173dbd4?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"c6b8139c802fb2123f01ad1ee173dbd4","url":"https://api.github.com/users/mythmon","html_url":"https://github.com/mythmon","followers_url":"https://api.github.com/users/mythmon/followers","following_url":"https://api.github.com/users/mythmon/following{/other_user}","gists_url":"https://api.github.com/users/mythmon/gists{/gist_id}","starred_url":"https://api.github.com/users/mythmon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mythmon/subscriptions","organizations_url":"https://api.github.com/users/mythmon/orgs","repos_url":"https://api.github.com/users/mythmon/repos","events_url":"https://api.github.com/users/mythmon/events{/privacy}","received_events_url":"https://api.github.com/users/mythmon/received_events","type":"User"},"created_at":"2013-06-28T23:10:41Z","updated_at":"2013-06-28T23:10:41Z","html_url":"https://github.com/mozilla/kitsune/pull/1444#discussion_r4950175","pull_request_url":"https://api.github.com/repos/mozilla/kitsune/pulls/1444","_links":{"self":{"href":"https://api.github.com/repos/mozilla/kitsune/pulls/comments/4950175"},"html":{"href":"https://github.com/mozilla/kitsune/pull/1444#discussion_r4950175"},"pull_request":{"href":"https://api.github.com/repos/mozilla/kitsune/pulls/1444"}}}} | {
"id": 489645,
"name": "kitsune",
"url": "https://github.com/mozilla/kitsune"
} | {
"id": null,
"login": "mythmon",
"gravatar_id": "c6b8139c802fb2123f01ad1ee173dbd4",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "mozilla",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-06-28T23:10:41 | null | {"repository":{"description":"Platform for Firefox Help","homepage":"http://support.mozilla.com/","watchers":159,"stargazers":159,"forks":108,"fork":false,"size":3076,"owner":"mozilla","private":false,"open_issues":3,"has_issues":false,"has_downloads":false,"has_wiki":false,"language":"Python","created_at":"2010-01-26T10:53:57-08:00","pushed_at":"2013-06-28T15:50:40-07:00","integrate_branch":"development","master_branch":"master","organization":"mozilla"},"actor_attributes":{"type":"User","name":"Mike Cooper","company":"Mozilla","blog":"http://mythmon.com","location":"Mountain View, CA","email":"[email protected]"},"url":"https://github.com/mozilla/kitsune/pull/1444#discussion_r4950175"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/mozilla/openbadges/pulls/comments/3081983","id":3081983,"body":"Same as above, move before function body.","path":"models/user.js","position":5,"original_position":5,"commit_id":"38d42f07bd5cf069ea567295145e0f2c5f7a95ba","original_commit_id":"38d42f07bd5cf069ea567295145e0f2c5f7a95ba","user":{"login":"brianloveswords","id":166258,"avatar_url":"https://secure.gravatar.com/avatar/b3898d14200a393d1410d663758b6edb?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"b3898d14200a393d1410d663758b6edb","url":"https://api.github.com/users/brianloveswords","html_url":"https://github.com/brianloveswords","followers_url":"https://api.github.com/users/brianloveswords/followers","following_url":"https://api.github.com/users/brianloveswords/following","gists_url":"https://api.github.com/users/brianloveswords/gists{/gist_id}","starred_url":"https://api.github.com/users/brianloveswords/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brianloveswords/subscriptions","organizations_url":"https://api.github.com/users/brianloveswords/orgs","repos_url":"https://api.github.com/users/brianloveswords/repos","events_url":"https://api.github.com/users/brianloveswords/events{/privacy}","received_events_url":"https://api.github.com/users/brianloveswords/received_events","type":"User"},"created_at":"2013-02-20T15:19:12Z","updated_at":"2013-02-20T15:19:12Z","_links":{"self":{"href":"https://api.github.com/repos/mozilla/openbadges/pulls/comments/3081983"},"html":{"href":"https://github.com/mozilla/openbadges/pull/546#discussion_r3081983"},"pull_request":{"href":"https://api.github.com/repos/mozilla/openbadges/pulls/546"}}}} | {
"id": 1726649,
"name": "openbadges",
"url": "https://github.com/mozilla/openbadges"
} | {
"id": null,
"login": "brianloveswords",
"gravatar_id": "b3898d14200a393d1410d663758b6edb",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "mozilla",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-02-20T15:19:12 | null | {"repository":{"description":"Mozilla Open Badges project. Currently in beta.","homepage":"http://openbadges.org/","watchers":312,"stargazers":312,"forks":77,"fork":false,"size":520,"owner":"mozilla","private":false,"open_issues":198,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"JavaScript","created_at":"2011-05-09T23:51:42-07:00","pushed_at":"2013-02-19T08:56:11-08:00","master_branch":"development","organization":"mozilla"},"actor_attributes":{"name":"Brian J Brennan","company":"Mozilla Foundation","blog":"http://bjb.io","location":"Brooklyn, New York","email":"[email protected]","type":"User"},"url":"https://github.com/mozilla/openbadges/pull/546#discussion_r3081983"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/mozilla/zippy/pulls/comments/6667966","id":6667966,"body":"I'm slightly worried because I think tests are async","diff_hunk":"@@ -0,0 +1,105 @@\n+var bunyan = require('bunyan');\n+var fs = require('fs');\n+var restify = require('restify');\n+\n+var zippy = require('../lib');\n+\n+var CLIENT;\n+var SERVER;\n+var SOCK = '.zippy_sock';\n+\n+function randomUUID() {\n+ return 'xxxxxxxx-xxxx-4xxx-yxxx-xxxxxxxxxxxx'.replace(/[xy]/g, function(c) {\n+ var r = Math.random()*16|0, v = c == 'x' ? r : (r&0x3|0x8);\n+ return v.toString(16);\n+ });\n+}\n+\n+module.exports = {\n+ setUp: function (cb) {\n+ var log = bunyan.createLogger({\n+ name: 'zippy_unit_test',\n+ level: process.env.LOG_LEVEL || 'info',\n+ serializers: restify.bunyan.serializers,\n+ stream: process.stdout\n+ });\n+\n+ // TODO(davidbgk): find an easy way to launch tests against\n+ // an external provider.\n+ SERVER = zippy.createServer({","path":"test/sellers.test.js","position":29,"original_position":29,"commit_id":"2cfbb7fc366526fb0d46a2e72e86f36b4f419cac","original_commit_id":"2cfbb7fc366526fb0d46a2e72e86f36b4f419cac","user":{"login":"kumar303","id":55398,"avatar_url":"https://0.gravatar.com/avatar/3e7e975f0fa432f4ae6604f72c132309?d=https%3A%2F%2Fidenticons.github.com%2F01074d0e0ca64dd52127d542d631eef0.png","gravatar_id":"3e7e975f0fa432f4ae6604f72c132309","url":"https://api.github.com/users/kumar303","html_url":"https://github.com/kumar303","followers_url":"https://api.github.com/users/kumar303/followers","following_url":"https://api.github.com/users/kumar303/following{/other_user}","gists_url":"https://api.github.com/users/kumar303/gists{/gist_id}","starred_url":"https://api.github.com/users/kumar303/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kumar303/subscriptions","organizations_url":"https://api.github.com/users/kumar303/orgs","repos_url":"https://api.github.com/users/kumar303/repos","events_url":"https://api.github.com/users/kumar303/events{/privacy}","received_events_url":"https://api.github.com/users/kumar303/received_events","type":"User"},"created_at":"2013-09-30T19:20:30Z","updated_at":"2013-09-30T19:20:30Z","html_url":"https://github.com/mozilla/zippy/pull/1#discussion_r6667966","pull_request_url":"https://api.github.com/repos/mozilla/zippy/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/mozilla/zippy/pulls/comments/6667966"},"html":{"href":"https://github.com/mozilla/zippy/pull/1#discussion_r6667966"},"pull_request":{"href":"https://api.github.com/repos/mozilla/zippy/pulls/1"}}}} | {
"id": 13070234,
"name": "zippy",
"url": "https://github.com/mozilla/zippy"
} | {
"id": null,
"login": "kumar303",
"gravatar_id": "3e7e975f0fa432f4ae6604f72c132309",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "mozilla",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-09-30T19:20:30 | null | {"repository":{"description":"A reference implementation for payment providers for the Firefox Marketplace.","homepage":"http://zippypayments.readthedocs.org/","watchers":1,"stargazers":1,"forks":2,"fork":false,"size":692,"owner":"mozilla","private":false,"open_issues":1,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Python","created_at":"2013-09-24T09:24:04-07:00","pushed_at":"2013-09-24T12:07:43-07:00","master_branch":"master","organization":"mozilla"},"actor_attributes":{"type":"User","name":"Kumar McMillan","company":"Mozilla","blog":"http://farmdev.com/","location":"Chicago, IL","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/mozilla/zippy/pull/1#discussion_r6667966"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/mozilla/addon-sdk/pulls/comments/3232745","id":3232745,"body":"Close this PR then, the impact of this change either way is not huge. Let's deprecate it, fix add-on builder helper and close this issue as wontfix.","diff_hunk":"@@ -258,7 +266,11 @@ exports.whenContentLoaded = function whenContentLoaded(callback) {\n \n Object.defineProperty(exports, 'activeTab', {\n get: function() {\n- return getSelectedTab(getMostRecentBrowserWindow());\n+ let window = getMostRecentBrowserWindow();\n+ // Ignore private windows when addon doesn't have the related permission\n+ if (ignoreWindow(window))","path":"lib/sdk/deprecated/tab-browser.js","position":36,"original_position":36,"commit_id":"af8f1985a125e62865accce820a431922b8bca8a","original_commit_id":"af8f1985a125e62865accce820a431922b8bca8a","user":{"login":"canuckistani","id":104315,"avatar_url":"https://secure.gravatar.com/avatar/f55b8cc42987a9258e073e3165e18d68?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"f55b8cc42987a9258e073e3165e18d68","url":"https://api.github.com/users/canuckistani","html_url":"https://github.com/canuckistani","followers_url":"https://api.github.com/users/canuckistani/followers","following_url":"https://api.github.com/users/canuckistani/following","gists_url":"https://api.github.com/users/canuckistani/gists{/gist_id}","starred_url":"https://api.github.com/users/canuckistani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/canuckistani/subscriptions","organizations_url":"https://api.github.com/users/canuckistani/orgs","repos_url":"https://api.github.com/users/canuckistani/repos","events_url":"https://api.github.com/users/canuckistani/events{/privacy}","received_events_url":"https://api.github.com/users/canuckistani/received_events","type":"User"},"created_at":"2013-03-04T21:30:10Z","updated_at":"2013-03-04T21:30:10Z","_links":{"self":{"href":"https://api.github.com/repos/mozilla/addon-sdk/pulls/comments/3232745"},"html":{"href":"https://github.com/mozilla/addon-sdk/pull/820#discussion_r3232745"},"pull_request":{"href":"https://api.github.com/repos/mozilla/addon-sdk/pulls/820"}}}} | {
"id": 748030,
"name": "addon-sdk",
"url": "https://github.com/mozilla/addon-sdk"
} | {
"id": null,
"login": "canuckistani",
"gravatar_id": "f55b8cc42987a9258e073e3165e18d68",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "mozilla",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-03-04T21:30:10 | null | {"repository":{"description":"The Add-on SDK repository.","homepage":"https://wiki.mozilla.org/Labs/Jetpack","watchers":259,"stargazers":259,"forks":110,"fork":false,"size":8152,"owner":"mozilla","private":false,"open_issues":36,"has_issues":false,"has_downloads":true,"has_wiki":true,"language":"JavaScript","created_at":"2010-06-29T17:38:20-07:00","pushed_at":"2013-03-04T12:53:24-08:00","master_branch":"master","organization":"mozilla"},"actor_attributes":{"type":"User","name":"Jeff Griffiths","company":"","location":"Vancouver, BC","email":"[email protected]"},"url":"https://github.com/mozilla/addon-sdk/pull/820#discussion_r3232745"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/mozilla/popcorn.webmaker.org/pulls/comments/5605991","id":5605991,"body":"Ah cool, so prop is always going to have *just* what has changed?\r\n\r\nThat's good to know :)","diff_hunk":"@@ -213,6 +214,12 @@\n });\n });\n \n+ _this.attachInputChangeHandler( _titleInput, trackEvent, \"title\", function( te, prop ) {\n+ updateTrackEvent( te, {","path":"public/templates/assets/editors/image/image-editor.js","position":13,"original_position":13,"commit_id":"87037fb51c168262d9e9c67c18da58cac8b03ffb","original_commit_id":"87037fb51c168262d9e9c67c18da58cac8b03ffb","user":{"login":"ScottDowne","id":197334,"avatar_url":"https://secure.gravatar.com/avatar/1a093ac74891befc97476eb9335b8d20?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"1a093ac74891befc97476eb9335b8d20","url":"https://api.github.com/users/ScottDowne","html_url":"https://github.com/ScottDowne","followers_url":"https://api.github.com/users/ScottDowne/followers","following_url":"https://api.github.com/users/ScottDowne/following{/other_user}","gists_url":"https://api.github.com/users/ScottDowne/gists{/gist_id}","starred_url":"https://api.github.com/users/ScottDowne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ScottDowne/subscriptions","organizations_url":"https://api.github.com/users/ScottDowne/orgs","repos_url":"https://api.github.com/users/ScottDowne/repos","events_url":"https://api.github.com/users/ScottDowne/events{/privacy}","received_events_url":"https://api.github.com/users/ScottDowne/received_events","type":"User"},"created_at":"2013-08-06T14:52:13Z","updated_at":"2013-08-06T14:52:13Z","html_url":"https://github.com/mozilla/popcorn.webmaker.org/pull/147#discussion_r5605991","pull_request_url":"https://api.github.com/repos/mozilla/popcorn.webmaker.org/pulls/147","_links":{"self":{"href":"https://api.github.com/repos/mozilla/popcorn.webmaker.org/pulls/comments/5605991"},"html":{"href":"https://github.com/mozilla/popcorn.webmaker.org/pull/147#discussion_r5605991"},"pull_request":{"href":"https://api.github.com/repos/mozilla/popcorn.webmaker.org/pulls/147"}}}} | {
"id": 9989556,
"name": "popcorn.webmaker.org",
"url": "https://github.com/mozilla/popcorn.webmaker.org"
} | {
"id": null,
"login": "ScottDowne",
"gravatar_id": "1a093ac74891befc97476eb9335b8d20",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "mozilla",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-08-06T14:52:13 | null | {"repository":{"description":"","watchers":8,"stargazers":8,"forks":19,"fork":false,"size":7305,"owner":"mozilla","private":false,"open_issues":49,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"JavaScript","created_at":"2013-05-10T13:15:43-07:00","pushed_at":"2013-08-06T07:42:30-07:00","master_branch":"master","organization":"mozilla"},"actor_attributes":{"type":"User","name":"ScottDowne","blog":"http://scottdowne.blogspot.com/","email":"[email protected]"},"url":"https://github.com/mozilla/popcorn.webmaker.org/pull/147#discussion_r5605991"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/mozilla/zamboni/pulls/comments/8060028","id":8060028,"diff_hunk":"@@ -24,66 +24,48 @@ class ReviewingView(ListAPIView):\n def get_queryset(self):\n return [row['app'] for row in AppsReviewing(self.request).get_apps()]\n \n+SEARCH_FIELDS = ['device_types', 'id', 'is_escalated', 'is_packaged',\n+ 'latest_version', 'name', 'premium_type', 'price', 'slug',\n+ 'status']\n \n-class ReviewersSearchResource(SearchResource):\n \n- class Meta(SearchResource.Meta):\n- resource_name = 'search'\n- authorization = PermissionAuthorization('Apps', 'Review')\n- fields = ['device_types', 'id', 'is_escalated', 'is_packaged',\n- 'latest_version', 'name', 'premium_type', 'price', 'slug',\n- 'status']\n+class ReviewersSearchResultSerializer(SearchResultSerializer):\n+ def serialize(self, request, app):\n+ full_data = SearchResultSerializer.serialize(self, request, app)\n+ data = {}\n+ for k in SEARCH_FIELDS:\n+ data[k] = full_data.get(k)\n+ return data\n \n- def get_search_data(self, request):\n- form = ApiReviewersSearchForm(request.GET if request else None)\n- if not form.is_valid():\n- raise self.form_errors(form)\n- return form.cleaned_data\n-\n- def get_feature_profile(self, request):\n- # We don't want automatic feature profile filtering in the reviewers\n- # API.\n- return None\n-\n- def get_region(self, request):\n- # We don't want automatic region filtering in the reviewers API.\n- return None\n-\n- def apply_filters(self, request, qs, data=None):\n- qs = super(ReviewersSearchResource, self).apply_filters(request, qs,\n- data=data)\n- for k in ('has_info_request', 'has_editor_comment'):\n- if data.get(k, None) is not None:\n- qs = qs.filter(**{\n- 'latest_version.%s' % k: data[k]\n- })\n- if data.get('is_escalated', None) is not None:\n- qs = qs.filter(is_escalated=data['is_escalated'])\n- return qs\n-\n- def get_query(self, request, base_filters=None):\n- form_data = self.get_search_data(request)\n-\n- if base_filters is None:\n- base_filters = {}\n- if form_data.get('status') != 'any':\n- base_filters['status'] = form_data.get('status')\n- return S(WebappIndexer).filter(**base_filters)\n-\n- def dehydrate(self, bundle):\n- bundle = super(ReviewersSearchResource, self).dehydrate(bundle)\n \n- # Add reviewer-specific stuff that's not in the standard dehydrate.\n- bundle.data['latest_version'] = bundle.obj.latest_version\n- bundle.data['is_escalated'] = bundle.obj.is_escalated\n-\n- # Throw away anything not in _meta.fields.\n- filtered_data = {}\n- for k in self._meta.fields:\n- filtered_data[k] = bundle.data[k]\n- bundle.data = filtered_data\n+class ReviewersSearchView(SearchView):\n+ cors_allowed_methods = ['get']\n+ authentication_classes = [RestSharedSecretAuthentication,\n+ RestOAuthAuthentication]\n+ permission_classes = [GroupPermission('Apps', 'Review')]\n+ serializer_class = ReviewersSearchResultSerializer\n \n- return bundle\n+ def get(self, request, *args, **kwargs):\n+ form_data = self.get_search_data(request, ApiReviewersSearchForm)\n+ base_filters = {'type': form_data['type']}\n+ if form_data.get('status') != 'any':\n+ base_filters['status'] = form_data.get('status')\n+ qs = S(WebappIndexer).filter(**base_filters)\n+ qs = self.apply_filters(request, qs, data=form_data)\n+ qs = apply_reviewer_filters(request, qs, data=form_data)\n+ page = self.paginate_queryset(qs)\n+ return Response(self.get_pagination_serializer(page).data)\n+\n+\n+def apply_reviewer_filters(request, qs, data=None):","path":"mkt/reviewers/api.py","position":108,"original_position":108,"commit_id":"e164346372533a944bcb34a44ea06137cb73bff9","original_commit_id":"e164346372533a944bcb34a44ea06137cb73bff9","user":{"login":"diox","id":187006,"avatar_url":"https://1.gravatar.com/avatar/20b505802a9464e50eac02c1f5189666?d=https%3A%2F%2Fidenticons.github.com%2F19c23a35c7bdf8b6bed7ea7d8ea107fb.png&r=x","gravatar_id":"20b505802a9464e50eac02c1f5189666","url":"https://api.github.com/users/diox","html_url":"https://github.com/diox","followers_url":"https://api.github.com/users/diox/followers","following_url":"https://api.github.com/users/diox/following{/other_user}","gists_url":"https://api.github.com/users/diox/gists{/gist_id}","starred_url":"https://api.github.com/users/diox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diox/subscriptions","organizations_url":"https://api.github.com/users/diox/orgs","repos_url":"https://api.github.com/users/diox/repos","events_url":"https://api.github.com/users/diox/events{/privacy}","received_events_url":"https://api.github.com/users/diox/received_events","type":"User","site_admin":false},"body":"Doesn't need to live outside the class.","created_at":"2013-12-03T14:00:08Z","updated_at":"2013-12-03T14:00:08Z","html_url":"https://github.com/mozilla/zamboni/pull/1451#discussion_r8060028","pull_request_url":"https://api.github.com/repos/mozilla/zamboni/pulls/1451","_links":{"self":{"href":"https://api.github.com/repos/mozilla/zamboni/pulls/comments/8060028"},"html":{"href":"https://github.com/mozilla/zamboni/pull/1451#discussion_r8060028"},"pull_request":{"href":"https://api.github.com/repos/mozilla/zamboni/pulls/1451"}}}} | {
"id": 347655,
"name": "zamboni",
"url": "https://github.com/mozilla/zamboni"
} | {
"id": null,
"login": "diox",
"gravatar_id": "20b505802a9464e50eac02c1f5189666",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "mozilla",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-12-03T14:00:08 | null | {"repository":{"description":"The Firefox Marketplace and addons.mozilla.org","homepage":"http://zamboni.readthedocs.org/en/latest/","watchers":382,"stargazers":382,"forks":198,"fork":false,"size":187641,"owner":"mozilla","private":false,"open_issues":25,"has_issues":true,"has_downloads":false,"has_wiki":false,"language":"Python","created_at":"2009-10-23T12:35:34-07:00","pushed_at":"2013-12-03T05:36:27-08:00","master_branch":"master","organization":"mozilla"},"actor_attributes":{"type":"User","name":"Mathieu Pillard","company":"Mozilla","blog":"http://virgule.net/","location":"Paris, France","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/mozilla/zamboni/pull/1451#discussion_r8060028"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/mozilla/addon-sdk/pulls/comments/7541883","id":7541883,"diff_hunk":"@@ -0,0 +1,82 @@\n+/* This Source Code Form is subject to the terms of the Mozilla Public\n+* License, v. 2.0. If a copy of the MPL was not distributed with this\n+* file, You can obtain one at http://mozilla.org/MPL/2.0/. */\n+'use strict';\n+\n+module.metadata = {\n+ 'stability': 'experimental',\n+ 'engines': {\n+ 'Firefox': '*',\n+ 'Fennec': '*'\n+ }\n+};\n+\n+const { Class } = require('../core/heritage');\n+const { Disposable } = require('../core/disposable');\n+const { off, emit, setListeners } = require('../event/core');\n+const { EventTarget } = require('../event/target');\n+const { ns } = require('../core/namespace');\n+const { id: addonID } = require('../self');\n+const { contract: menuitemContract } = require('./menuitem/contract');\n+const { create, update, dispose } = require('./menuitem/view');\n+const { ensure } = require('../system/unload');\n+const { identify } = require('./id');\n+const { uuid } = require('../util/uuid');\n+const { MENUS } = require('./menuitem/constants');\n+const { models, modelFor } = require('./menuitem/namespace');\n+const { contract } = require('../util/contract');\n+\n+const menuitemMS = ns();\n+\n+// exporting list of menu constants\n+Object.keys(MENUS).forEach(function(key) {\n+ exports[key] = MENUS[key];\n+})\n+\n+const Menuitem = Class({\n+ implements: [ Disposable ],\n+ extends: EventTarget,\n+ setup: function(options) {\n+ // inital validation for the model information\n+ let model = menuitemContract(options);\n+\n+ // save the model information\n+ models.set(this, model);","path":"lib/sdk/ui/menuitem.js","position":48,"original_position":44,"commit_id":"cdcfcfd86e4eb471509a701750e2d1c55b76aa03","original_commit_id":"7a46d62a47a0185ca2852c2bba8bfe1f3a93726c","user":{"login":"Gozala","id":21236,"avatar_url":"https://2.gravatar.com/avatar/9289db62d5c34afb4f277a5215e05c83?d=https%3A%2F%2Fidenticons.github.com%2Fc35624e2cceae64a8589f7aa04c411b2.png&r=x","gravatar_id":"9289db62d5c34afb4f277a5215e05c83","url":"https://api.github.com/users/Gozala","html_url":"https://github.com/Gozala","followers_url":"https://api.github.com/users/Gozala/followers","following_url":"https://api.github.com/users/Gozala/following{/other_user}","gists_url":"https://api.github.com/users/Gozala/gists{/gist_id}","starred_url":"https://api.github.com/users/Gozala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gozala/subscriptions","organizations_url":"https://api.github.com/users/Gozala/orgs","repos_url":"https://api.github.com/users/Gozala/repos","events_url":"https://api.github.com/users/Gozala/events{/privacy}","received_events_url":"https://api.github.com/users/Gozala/received_events","type":"User","site_admin":false},"body":"Ignore it.","created_at":"2013-11-08T23:12:16Z","updated_at":"2013-11-08T23:12:16Z","html_url":"https://github.com/mozilla/addon-sdk/pull/1269#discussion_r7541883","pull_request_url":"https://api.github.com/repos/mozilla/addon-sdk/pulls/1269","_links":{"self":{"href":"https://api.github.com/repos/mozilla/addon-sdk/pulls/comments/7541883"},"html":{"href":"https://github.com/mozilla/addon-sdk/pull/1269#discussion_r7541883"},"pull_request":{"href":"https://api.github.com/repos/mozilla/addon-sdk/pulls/1269"}}}} | {
"id": 748030,
"name": "addon-sdk",
"url": "https://github.com/mozilla/addon-sdk"
} | {
"id": null,
"login": "Gozala",
"gravatar_id": "9289db62d5c34afb4f277a5215e05c83",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "mozilla",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-11-08T23:12:16 | null | {"repository":{"description":"The Add-on SDK repository.","homepage":"https://wiki.mozilla.org/Labs/Jetpack","watchers":335,"stargazers":335,"forks":160,"fork":false,"size":35396,"owner":"mozilla","private":false,"open_issues":1,"has_issues":false,"has_downloads":true,"has_wiki":true,"language":"JavaScript","created_at":"2010-06-29T17:38:20-07:00","pushed_at":"2013-11-08T10:41:02-08:00","master_branch":"master","organization":"mozilla"},"actor_attributes":{"type":"User","name":"Irakli Gozalishvili","company":"Mozilla","blog":"http://jeditoolkit.com/","location":"San Francisco, USA","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/mozilla/addon-sdk/pull/1269#discussion_r7541883"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/mozilla/popcorn.webmaker.org/pulls/comments/8031943","id":8031943,"diff_hunk":"@@ -0,0 +1,24 @@\n+/* This Source Code Form is subject to the terms of the MIT license\n+ * If a copy of the MIT license was not distributed with this file, you can\n+ * obtain one at https://raw.github.com/mozilla/butter/master/LICENSE */\n+(function() {\n+\n+ define([ \"../../external/PluginDetect/PluginDetect_Flash\", \"util/warn\", \"localized\" ],\n+ function( PluginDetect, Warn, Localized ){\n+\n+ // Hard coded value for now. We need to chat with whoever is in charge of Mozilla's\n+ // PFS2 instance to see if we can use the service / what limitations there might be\n+ var MIN_FLASH_VERSION = 11;\n+\n+ var flashVersion;\n+\n+ return {\n+ check: function() {","path":"public/src/util/accepted-flash.js","position":16,"original_position":16,"commit_id":"d6b5a89ae15ab28bf35af9cfc0e1b12dfbebfd24","original_commit_id":"d6b5a89ae15ab28bf35af9cfc0e1b12dfbebfd24","user":{"login":"ScottDowne","id":197334,"avatar_url":"https://0.gravatar.com/avatar/1a093ac74891befc97476eb9335b8d20?d=https%3A%2F%2Fidenticons.github.com%2F247fc508066313ba6b4aedaff3ca33de.png&r=x","gravatar_id":"1a093ac74891befc97476eb9335b8d20","url":"https://api.github.com/users/ScottDowne","html_url":"https://github.com/ScottDowne","followers_url":"https://api.github.com/users/ScottDowne/followers","following_url":"https://api.github.com/users/ScottDowne/following{/other_user}","gists_url":"https://api.github.com/users/ScottDowne/gists{/gist_id}","starred_url":"https://api.github.com/users/ScottDowne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ScottDowne/subscriptions","organizations_url":"https://api.github.com/users/ScottDowne/orgs","repos_url":"https://api.github.com/users/ScottDowne/repos","events_url":"https://api.github.com/users/ScottDowne/events{/privacy}","received_events_url":"https://api.github.com/users/ScottDowne/received_events","type":"User","site_admin":false},"body":"I also think the name of this function implies it only checks, but it is actually doing two things.","created_at":"2013-12-02T17:10:54Z","updated_at":"2013-12-02T17:10:54Z","html_url":"https://github.com/mozilla/popcorn.webmaker.org/pull/337#discussion_r8031943","pull_request_url":"https://api.github.com/repos/mozilla/popcorn.webmaker.org/pulls/337","_links":{"self":{"href":"https://api.github.com/repos/mozilla/popcorn.webmaker.org/pulls/comments/8031943"},"html":{"href":"https://github.com/mozilla/popcorn.webmaker.org/pull/337#discussion_r8031943"},"pull_request":{"href":"https://api.github.com/repos/mozilla/popcorn.webmaker.org/pulls/337"}}}} | {
"id": 9989556,
"name": "popcorn.webmaker.org",
"url": "https://github.com/mozilla/popcorn.webmaker.org"
} | {
"id": null,
"login": "ScottDowne",
"gravatar_id": "1a093ac74891befc97476eb9335b8d20",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "mozilla",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-12-02T17:10:54 | null | {"repository":{"description":"","watchers":23,"stargazers":23,"forks":36,"fork":false,"size":13413,"owner":"mozilla","private":false,"open_issues":31,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"JavaScript","created_at":"2013-05-10T13:15:43-07:00","pushed_at":"2013-12-02T08:50:52-08:00","master_branch":"master","organization":"mozilla"},"actor_attributes":{"type":"User","name":"ScottDowne","blog":"http://scottdowne.blogspot.com/","email":"[email protected]"},"url":"https://github.com/mozilla/popcorn.webmaker.org/pull/337#discussion_r8031943"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/mozilla/r2d2b2g/pulls/comments/5126380","id":5126380,"body":"Nice catch!","diff_hunk":"@@ -15,3 +15,13 @@ addon/data/win32/adb\n \n # locale repositories cloned by build/make-locales.py\n gaia-l10n\n+\n+# native code objects not covered by standard global gitignores\n+android-tools/adb-bin/adb\n+android-tools/win-out\n+*.idb\n+*.pdb\n+\n+# local build configuration options\n+local.mk","path":".gitignore","position":12,"original_position":12,"commit_id":"7096542b8a48bb2e65af9c69cb565548eb55ebb6","original_commit_id":"7096542b8a48bb2e65af9c69cb565548eb55ebb6","user":{"login":"mykmelez","id":305455,"avatar_url":"https://secure.gravatar.com/avatar/4bcc1646956acd3ee25234b34da91414?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"4bcc1646956acd3ee25234b34da91414","url":"https://api.github.com/users/mykmelez","html_url":"https://github.com/mykmelez","followers_url":"https://api.github.com/users/mykmelez/followers","following_url":"https://api.github.com/users/mykmelez/following{/other_user}","gists_url":"https://api.github.com/users/mykmelez/gists{/gist_id}","starred_url":"https://api.github.com/users/mykmelez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mykmelez/subscriptions","organizations_url":"https://api.github.com/users/mykmelez/orgs","repos_url":"https://api.github.com/users/mykmelez/repos","events_url":"https://api.github.com/users/mykmelez/events{/privacy}","received_events_url":"https://api.github.com/users/mykmelez/received_events","type":"User"},"created_at":"2013-07-10T20:31:54Z","updated_at":"2013-07-10T20:31:54Z","html_url":"https://github.com/mozilla/r2d2b2g/pull/663#discussion_r5126380","pull_request_url":"https://api.github.com/repos/mozilla/r2d2b2g/pulls/663","_links":{"self":{"href":"https://api.github.com/repos/mozilla/r2d2b2g/pulls/comments/5126380"},"html":{"href":"https://github.com/mozilla/r2d2b2g/pull/663#discussion_r5126380"},"pull_request":{"href":"https://api.github.com/repos/mozilla/r2d2b2g/pulls/663"}}}} | {
"id": 5707670,
"name": "r2d2b2g",
"url": "https://github.com/mozilla/r2d2b2g"
} | {
"id": null,
"login": "mykmelez",
"gravatar_id": "4bcc1646956acd3ee25234b34da91414",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "mozilla",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-07-10T20:31:54 | null | {"repository":{"description":"Firefox OS Simulator is a test environment for Firefox OS. Use it to test your apps in a Firefox OS-like environment that looks and feels like a mobile phone.","homepage":"https://addons.mozilla.org/en-US/firefox/addon/firefox-os-simulator/","watchers":368,"stargazers":368,"forks":108,"fork":false,"size":1028,"owner":"mozilla","private":false,"open_issues":76,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"JavaScript","created_at":"2012-09-06T12:51:04-07:00","pushed_at":"2013-07-09T12:33:23-07:00","master_branch":"master","organization":"mozilla"},"actor_attributes":{"type":"User","name":"Myk Melez","company":"Mozilla","blog":"http://www.mykzilla.org/","location":"The Internet","email":"[email protected]"},"url":"https://github.com/mozilla/r2d2b2g/pull/663#discussion_r5126380"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/mozilla/solitude/pulls/comments/6899918","id":6899918,"diff_hunk":"@@ -1,17 +1,21 @@\n from datetime import datetime, timedelta\n \n-from mock import patch\n+from mock import ANY, Mock, patch\n \n from django.conf import settings\n from django.core.exceptions import ValidationError\n+from django.test import RequestFactory\n \n from lib.transactions import constants\n-from lib.transactions.forms import check_status\n+from lib.transactions.forms import check_status, UpdateForm\n from solitude.base import APITest\n \n \n @patch.object(settings, 'TRANSACTION_LOCKDOWN', 60)\n-class TestModel(APITest):\n+class TestForm(APITest):\n+\n+ def setUp(self):","path":"lib/transactions/tests/test_forms.py","position":20,"original_position":20,"commit_id":"ee8c187d2f53868f360a33cc4190bcf87e6a0d91","original_commit_id":"ee8c187d2f53868f360a33cc4190bcf87e6a0d91","user":{"login":"kumar303","id":55398,"avatar_url":"https://1.gravatar.com/avatar/3e7e975f0fa432f4ae6604f72c132309?d=https%3A%2F%2Fidenticons.github.com%2F01074d0e0ca64dd52127d542d631eef0.png","gravatar_id":"3e7e975f0fa432f4ae6604f72c132309","url":"https://api.github.com/users/kumar303","html_url":"https://github.com/kumar303","followers_url":"https://api.github.com/users/kumar303/followers","following_url":"https://api.github.com/users/kumar303/following{/other_user}","gists_url":"https://api.github.com/users/kumar303/gists{/gist_id}","starred_url":"https://api.github.com/users/kumar303/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kumar303/subscriptions","organizations_url":"https://api.github.com/users/kumar303/orgs","repos_url":"https://api.github.com/users/kumar303/repos","events_url":"https://api.github.com/users/kumar303/events{/privacy}","received_events_url":"https://api.github.com/users/kumar303/received_events","type":"User","site_admin":false},"body":"call ``super().setUp()`` here?","created_at":"2013-10-10T20:37:22Z","updated_at":"2013-10-10T20:37:22Z","html_url":"https://github.com/mozilla/solitude/pull/143#discussion_r6899918","pull_request_url":"https://api.github.com/repos/mozilla/solitude/pulls/143","_links":{"self":{"href":"https://api.github.com/repos/mozilla/solitude/pulls/comments/6899918"},"html":{"href":"https://github.com/mozilla/solitude/pull/143#discussion_r6899918"},"pull_request":{"href":"https://api.github.com/repos/mozilla/solitude/pulls/143"}}}} | {
"id": 4566171,
"name": "solitude",
"url": "https://github.com/mozilla/solitude"
} | {
"id": null,
"login": "kumar303",
"gravatar_id": "3e7e975f0fa432f4ae6604f72c132309",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "mozilla",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-10-10T20:37:22 | null | {"repository":{"description":"A server for processing payments for Mozilla’s Marketplace and Add-ons site.","homepage":"http://readthedocs.org/docs/solitude/en/latest/","watchers":18,"stargazers":18,"forks":15,"fork":false,"size":3288,"owner":"mozilla","private":false,"open_issues":1,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Python","created_at":"2012-06-05T15:13:53-07:00","pushed_at":"2013-10-10T12:04:20-07:00","master_branch":"master","organization":"mozilla"},"actor_attributes":{"type":"User","name":"Kumar McMillan","company":"Mozilla","blog":"http://farmdev.com/","location":"Chicago, IL","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/mozilla/solitude/pull/143#discussion_r6899918"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/mozilla/login.webmaker.org/pulls/comments/4122823","id":4122823,"body":"I strongly suspect that this is not needed, and if it is, then it's a bug. However, to leave this in, use the same environment variable for both cookieParser and cookieSession so it's easy to remove the unneeded bit later","diff_hunk":"@@ -5,25 +5,46 @@\n * You can obtain one at http://mozilla.org/MPL/2.0/. */\n \n var express = require( \"express\" ),\n- env = require( \"../../config/environment\" );\n+ env = require( \"../../config/environment\" ),\n+ localhose = require( \"localhose\" );\n+\n+localhose.set(\"login.webmaker.local\", \"thimble.webmaker.local\", \"popcorn.webmaker.local\");\n \n var app1 = express();\n var app2 = express();\n- \n+\n // Configuration\n function configure( app ){\n app.configure( function(){\n app.set( \"views\", __dirname + \"/views\" );\n app.set( \"view engine\", \"ejs\" );\n+ app.use( express.cookieParser( env.get(\"PARSER_SECRET\") ) );","path":"app/dev/servers.js","position":19,"original_position":19,"commit_id":"82d09401c480951da0fc5258feef3e2ee3b7d41a","original_commit_id":"82d09401c480951da0fc5258feef3e2ee3b7d41a","user":{"login":"jbuck","id":578466,"avatar_url":"https://secure.gravatar.com/avatar/7fc0a83242c7c0d724124a7a0536ee38?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"7fc0a83242c7c0d724124a7a0536ee38","url":"https://api.github.com/users/jbuck","html_url":"https://github.com/jbuck","followers_url":"https://api.github.com/users/jbuck/followers","following_url":"https://api.github.com/users/jbuck/following{/other_user}","gists_url":"https://api.github.com/users/jbuck/gists{/gist_id}","starred_url":"https://api.github.com/users/jbuck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbuck/subscriptions","organizations_url":"https://api.github.com/users/jbuck/orgs","repos_url":"https://api.github.com/users/jbuck/repos","events_url":"https://api.github.com/users/jbuck/events{/privacy}","received_events_url":"https://api.github.com/users/jbuck/received_events","type":"User"},"created_at":"2013-05-07T20:59:13Z","updated_at":"2013-05-07T20:59:13Z","html_url":"https://github.com/mozilla/login.webmaker.org/pull/47#discussion_r4122823","pull_request_url":"https://api.github.com/repos/mozilla/login.webmaker.org/pulls/47","_links":{"self":{"href":"https://api.github.com/repos/mozilla/login.webmaker.org/pulls/comments/4122823"},"html":{"href":"https://github.com/mozilla/login.webmaker.org/pull/47#discussion_r4122823"},"pull_request":{"href":"https://api.github.com/repos/mozilla/login.webmaker.org/pulls/47"}}}} | {
"id": 5799212,
"name": "login.webmaker.org",
"url": "https://github.com/mozilla/login.webmaker.org"
} | {
"id": null,
"login": "jbuck",
"gravatar_id": "7fc0a83242c7c0d724124a7a0536ee38",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "mozilla",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-05-07T20:59:13 | null | {"repository":{"description":"","watchers":1,"stargazers":1,"forks":10,"fork":false,"size":356,"owner":"mozilla","private":false,"open_issues":1,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"JavaScript","created_at":"2012-09-13T11:40:20-07:00","pushed_at":"2013-05-04T09:05:54-07:00","master_branch":"master","organization":"mozilla"},"actor_attributes":{"type":"User","name":"Jon Buckley","company":"Mozilla Foundation","blog":"http://jbuckley.ca/","location":"Toronto, ON","email":"[email protected]"},"url":"https://github.com/mozilla/login.webmaker.org/pull/47#discussion_r4122823"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/mozilla/remo/pulls/comments/5473555","id":5473555,"body":"Same here.","diff_hunk":"@@ -34,8 +34,8 @@ function initialize_map() {\n 'OpenStreetMap</a> contributors, <a href=\"http://creativecommons.org/' +\n 'licenses/by-sa/2.0/\">CC-BY-SA</a>, Imagery © ' +\n '<a href=\"http://cloudmade.com\">CloudMade</a>');\n- var cloudmade = new L.TileLayer('http://{s}.tile.cloudmade.com/' +\n- 'b465ca1b6fe040dba7eec0291ecb7a8c/' +\n+ var cloudmade = new L.TileLayer('https://ssl_tiles.cloudmade.com/' +","path":"media/js/remo/profiles_people.js","position":6,"original_position":6,"commit_id":"ef3cc5ac891b0d63501c970da9b864d3dffb67e3","original_commit_id":"ef3cc5ac891b0d63501c970da9b864d3dffb67e3","user":{"login":"glogiotatidis","id":584352,"avatar_url":"https://secure.gravatar.com/avatar/7b74caf316a6c6716977fe84b56774c1?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"7b74caf316a6c6716977fe84b56774c1","url":"https://api.github.com/users/glogiotatidis","html_url":"https://github.com/glogiotatidis","followers_url":"https://api.github.com/users/glogiotatidis/followers","following_url":"https://api.github.com/users/glogiotatidis/following{/other_user}","gists_url":"https://api.github.com/users/glogiotatidis/gists{/gist_id}","starred_url":"https://api.github.com/users/glogiotatidis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glogiotatidis/subscriptions","organizations_url":"https://api.github.com/users/glogiotatidis/orgs","repos_url":"https://api.github.com/users/glogiotatidis/repos","events_url":"https://api.github.com/users/glogiotatidis/events{/privacy}","received_events_url":"https://api.github.com/users/glogiotatidis/received_events","type":"User"},"created_at":"2013-07-30T11:16:02Z","updated_at":"2013-07-30T11:16:02Z","html_url":"https://github.com/mozilla/remo/pull/446#discussion_r5473555","pull_request_url":"https://api.github.com/repos/mozilla/remo/pulls/446","_links":{"self":{"href":"https://api.github.com/repos/mozilla/remo/pulls/comments/5473555"},"html":{"href":"https://github.com/mozilla/remo/pull/446#discussion_r5473555"},"pull_request":{"href":"https://api.github.com/repos/mozilla/remo/pulls/446"}}}} | {
"id": 3167000,
"name": "remo",
"url": "https://github.com/mozilla/remo"
} | {
"id": null,
"login": "glogiotatidis",
"gravatar_id": "7b74caf316a6c6716977fe84b56774c1",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "mozilla",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-07-30T11:16:02 | null | {"repository":{"description":"Mozilla Reps","homepage":"http://reps.mozilla.org","watchers":26,"stargazers":26,"forks":32,"fork":false,"size":13077,"owner":"mozilla","private":false,"open_issues":3,"has_issues":false,"has_downloads":true,"has_wiki":false,"language":"Python","created_at":"2012-01-12T15:41:29-08:00","pushed_at":"2013-07-29T09:28:05-07:00","master_branch":"master","organization":"mozilla"},"actor_attributes":{"type":"User","name":"Giorgos Logiotatidis","company":"Mozilla","blog":"http://www.sealabs.net/seadog","location":"Athens, Greece","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/mozilla/remo/pull/446#discussion_r5473555"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/mozilla/commbadge/pulls/comments/5078586","id":5078586,"body":"`thread` may be more descriptive","diff_hunk":"@@ -0,0 +1,27 @@\n+{% macro thread_detail(t) %}","path":"hearth/templates/_macros/thread_detail.html","position":1,"original_position":1,"commit_id":"94d8697f58c991293e576ef610311c6f59164c2d","original_commit_id":"94d8697f58c991293e576ef610311c6f59164c2d","user":{"login":"cvan","id":203725,"avatar_url":"https://secure.gravatar.com/avatar/47de0e6948b289c9b4b4be0d6d66c0f4?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"47de0e6948b289c9b4b4be0d6d66c0f4","url":"https://api.github.com/users/cvan","html_url":"https://github.com/cvan","followers_url":"https://api.github.com/users/cvan/followers","following_url":"https://api.github.com/users/cvan/following{/other_user}","gists_url":"https://api.github.com/users/cvan/gists{/gist_id}","starred_url":"https://api.github.com/users/cvan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cvan/subscriptions","organizations_url":"https://api.github.com/users/cvan/orgs","repos_url":"https://api.github.com/users/cvan/repos","events_url":"https://api.github.com/users/cvan/events{/privacy}","received_events_url":"https://api.github.com/users/cvan/received_events","type":"User"},"created_at":"2013-07-08T22:51:15Z","updated_at":"2013-07-08T22:51:15Z","html_url":"https://github.com/mozilla/commbadge/pull/1#discussion_r5078586","pull_request_url":"https://api.github.com/repos/mozilla/commbadge/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/mozilla/commbadge/pulls/comments/5078586"},"html":{"href":"https://github.com/mozilla/commbadge/pull/1#discussion_r5078586"},"pull_request":{"href":"https://api.github.com/repos/mozilla/commbadge/pulls/1"}}}} | {
"id": 10651575,
"name": "commbadge",
"url": "https://github.com/mozilla/commbadge"
} | {
"id": null,
"login": "cvan",
"gravatar_id": "47de0e6948b289c9b4b4be0d6d66c0f4",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "mozilla",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-07-08T22:51:15 | null | {"repository":{"description":"Firefox Marketplace Communication Dashboard","watchers":1,"stargazers":1,"forks":2,"fork":false,"size":1752,"owner":"mozilla","private":false,"open_issues":1,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"JavaScript","created_at":"2013-06-12T13:36:52-07:00","pushed_at":"2013-07-03T18:18:07-07:00","master_branch":"master","organization":"mozilla"},"actor_attributes":{"type":"User","name":"Christopher Van","company":"Mozilla","location":"Mountain View, CA","email":"[email protected]"},"url":"https://github.com/mozilla/commbadge/pull/1#discussion_r5078586"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/mozilla/fireplace/pulls/comments/3981176","id":3981176,"body":"@mattbasta help!","diff_hunk":"@@ -14,11 +14,15 @@ var routes = [\n {pattern: '^/app/([^/<>\"\\']+)$', view_name: 'app'},\n {pattern: '^/search$', view_name: 'search'},\n {pattern: '^/category/([^/<>\"\\']+)$', view_name: 'category'},\n+\n+ // @mattbasta: How can I have two different URLs share the same views/<view_name>.js","path":"hearth/media/js/routes.js","position":5,"original_position":5,"commit_id":"a2fd98d3a6cf9ae714994f71fb020f7db6dda2d8","original_commit_id":"a2fd98d3a6cf9ae714994f71fb020f7db6dda2d8","user":{"login":"cvan","id":203725,"avatar_url":"https://secure.gravatar.com/avatar/47de0e6948b289c9b4b4be0d6d66c0f4?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"47de0e6948b289c9b4b4be0d6d66c0f4","url":"https://api.github.com/users/cvan","html_url":"https://github.com/cvan","followers_url":"https://api.github.com/users/cvan/followers","following_url":"https://api.github.com/users/cvan/following","gists_url":"https://api.github.com/users/cvan/gists{/gist_id}","starred_url":"https://api.github.com/users/cvan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cvan/subscriptions","organizations_url":"https://api.github.com/users/cvan/orgs","repos_url":"https://api.github.com/users/cvan/repos","events_url":"https://api.github.com/users/cvan/events{/privacy}","received_events_url":"https://api.github.com/users/cvan/received_events","type":"User"},"created_at":"2013-04-26T17:34:59Z","updated_at":"2013-04-26T17:34:59Z","html_url":"https://github.com/mozilla/fireplace/pull/82#discussion_r3981176","pull_request_url":"https://api.github.com/repos/mozilla/fireplace/pulls/82","_links":{"self":{"href":"https://api.github.com/repos/mozilla/fireplace/pulls/comments/3981176"},"html":{"href":"https://github.com/mozilla/fireplace/pull/82#discussion_r3981176"},"pull_request":{"href":"https://api.github.com/repos/mozilla/fireplace/pulls/82"}}}} | {
"id": 8046076,
"name": "fireplace",
"url": "https://github.com/mozilla/fireplace"
} | {
"id": null,
"login": "cvan",
"gravatar_id": "47de0e6948b289c9b4b4be0d6d66c0f4",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "mozilla",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-04-26T17:34:59 | null | {"repository":{"description":"Ignition, the Remix","homepage":"https://marketplace.firefox.com/","watchers":8,"stargazers":8,"forks":9,"fork":true,"size":1292,"owner":"mozilla","private":false,"open_issues":3,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"JavaScript","created_at":"2013-02-05T22:41:06-08:00","pushed_at":"2013-04-25T15:55:12-07:00","master_branch":"master","organization":"mozilla"},"actor_attributes":{"type":"User","name":"Chris Van","company":"Mozilla","location":"Mountain View, CA","email":"[email protected]"},"url":"https://github.com/mozilla/fireplace/pull/82#discussion_r3981176"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/mozilla/rust/pulls/comments/6399306","id":6399306,"body":"I based these error messages off of the ones that `bytes!()` produces. Is `bytes!()` is wrong?","diff_hunk":"@@ -0,0 +1,98 @@\n+// Copyright 2013 The Rust Project Developers. See the COPYRIGHT\n+// file at the top-level directory of this distribution and at\n+// http://rust-lang.org/COPYRIGHT.\n+//\n+// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or\n+// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license\n+// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your\n+// option. This file may not be copied, modified, or distributed\n+// except according to those terms.\n+\n+/* The compiler code necessary to support the fourcc! extension. */\n+\n+// fourcc!() is called with a single 4-character string, and an optional ident\n+// that is either `big` or `little`. If the ident is omitted it is assumed to\n+// be the platform-native value. It returns a u32.\n+\n+use ast;\n+use codemap::{Span, mk_sp};\n+use ext::base::*;\n+use ext::base;\n+use ext::build::AstBuilder;\n+use parse;\n+use parse::token;\n+use parse::token::intern;\n+\n+use std::ascii::AsciiCast;\n+\n+pub fn expand_syntax_ext(cx: @ExtCtxt, sp: Span, tts: &[ast::token_tree]) -> base::MacResult {\n+ let (expr, endian) = parse_tts(cx, tts);\n+\n+ let little = match endian {\n+ None => cfg!(target_endian = \"little\"),\n+ Some(Ident{ident, span}) => {\n+ if ident.name == intern(\"little\") {\n+ true\n+ } else if ident.name == intern(\"big\") {\n+ false\n+ } else {\n+ cx.span_err(span, \"Invalid endian directive in fourcc!\");","path":"src/libsyntax/ext/fourcc.rs","position":39,"original_position":39,"commit_id":"d6e5379c5077b22ebd0e64d8168edba0c6b942f4","original_commit_id":"d6e5379c5077b22ebd0e64d8168edba0c6b942f4","user":{"login":"kballard","id":714,"avatar_url":"https://1.gravatar.com/avatar/6451ee8093c9cedc94f6c813b4dde2c5?d=https%3A%2F%2Fidenticons.github.com%2Fd14220ee66aeec73c49038385428ec4c.png","gravatar_id":"6451ee8093c9cedc94f6c813b4dde2c5","url":"https://api.github.com/users/kballard","html_url":"https://github.com/kballard","followers_url":"https://api.github.com/users/kballard/followers","following_url":"https://api.github.com/users/kballard/following{/other_user}","gists_url":"https://api.github.com/users/kballard/gists{/gist_id}","starred_url":"https://api.github.com/users/kballard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kballard/subscriptions","organizations_url":"https://api.github.com/users/kballard/orgs","repos_url":"https://api.github.com/users/kballard/repos","events_url":"https://api.github.com/users/kballard/events{/privacy}","received_events_url":"https://api.github.com/users/kballard/received_events","type":"User"},"created_at":"2013-09-17T09:01:51Z","updated_at":"2013-09-17T09:01:51Z","html_url":"https://github.com/mozilla/rust/pull/9255#discussion_r6399306","pull_request_url":"https://api.github.com/repos/mozilla/rust/pulls/9255","_links":{"self":{"href":"https://api.github.com/repos/mozilla/rust/pulls/comments/6399306"},"html":{"href":"https://github.com/mozilla/rust/pull/9255#discussion_r6399306"},"pull_request":{"href":"https://api.github.com/repos/mozilla/rust/pulls/9255"}}}} | {
"id": 724712,
"name": "rust",
"url": "https://github.com/mozilla/rust"
} | {
"id": null,
"login": "kballard",
"gravatar_id": "6451ee8093c9cedc94f6c813b4dde2c5",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "mozilla",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-09-17T09:01:51 | null | {"repository":{"description":"a safe, concurrent, practical language","homepage":"http://www.rust-lang.org","watchers":3026,"stargazers":3026,"forks":596,"fork":false,"size":168144,"owner":"mozilla","private":false,"open_issues":1339,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Rust","created_at":"2010-06-16T13:39:03-07:00","pushed_at":"2013-09-17T01:00:47-07:00","integrate_branch":"master","master_branch":"master","organization":"mozilla"},"actor_attributes":{"type":"User","name":"Kevin Ballard","company":"","blog":"http://kevin.sb.org","location":"San Francisco, CA","email":"[email protected]"},"url":"https://github.com/mozilla/rust/pull/9255#discussion_r6399306"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/mozilla/pdf.js/pulls/comments/6363737","id":6363737,"body":"Just this line? Do you think that moving this line enhances readability / ease of maintenance? Note that it strongly depends on the preceeding lines (`this.handTool` (`this = PDFView`) is only defined a few lines back).","diff_hunk":"@@ -203,6 +205,26 @@ var PDFView = {\n this.watchScroll(thumbnailContainer, this.thumbnailViewScroll,\n this.renderHighestPriority.bind(this));\n \n+ var toggleHandTool = document.getElementById('toggleHandTool');\n+ this.handTool = new GrabToPan({\n+ element: this.container,\n+ onActiveChanged: function(isActive) {\n+ if (isActive) {\n+ toggleHandTool.title =\n+ mozL10n.get('hand_tool_disable', null, 'Disable hand tool');\n+ toggleHandTool.firstElementChild.textContent =\n+ mozL10n.get('hand_tool_disable_label', null, 'Disable hand tool');\n+ } else {\n+ toggleHandTool.title =\n+ mozL10n.get('hand_tool_enable', null, 'Enable hand tool');\n+ toggleHandTool.firstElementChild.textContent =\n+ mozL10n.get('hand_tool_enable_label', null, 'Enable hand tool');\n+ }\n+ }\n+ });\n+ toggleHandTool.addEventListener('click', this.handTool.toggle, false);","path":"web/viewer.js","position":39,"original_position":39,"commit_id":"652874aedf8c1f5dfd4399bb0177800b72d49a74","original_commit_id":"652874aedf8c1f5dfd4399bb0177800b72d49a74","user":{"login":"Rob--W","id":1365071,"avatar_url":"https://0.gravatar.com/avatar/c916d92c098426d84778a7910cc32b39?d=https%3A%2F%2Fidenticons.github.com%2Ffa390125ecd6a3f22d01712909ce84ae.png","gravatar_id":"c916d92c098426d84778a7910cc32b39","url":"https://api.github.com/users/Rob--W","html_url":"https://github.com/Rob--W","followers_url":"https://api.github.com/users/Rob--W/followers","following_url":"https://api.github.com/users/Rob--W/following{/other_user}","gists_url":"https://api.github.com/users/Rob--W/gists{/gist_id}","starred_url":"https://api.github.com/users/Rob--W/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rob--W/subscriptions","organizations_url":"https://api.github.com/users/Rob--W/orgs","repos_url":"https://api.github.com/users/Rob--W/repos","events_url":"https://api.github.com/users/Rob--W/events{/privacy}","received_events_url":"https://api.github.com/users/Rob--W/received_events","type":"User"},"created_at":"2013-09-14T12:24:22Z","updated_at":"2013-09-14T12:24:22Z","html_url":"https://github.com/mozilla/pdf.js/pull/3684#discussion_r6363737","pull_request_url":"https://api.github.com/repos/mozilla/pdf.js/pulls/3684","_links":{"self":{"href":"https://api.github.com/repos/mozilla/pdf.js/pulls/comments/6363737"},"html":{"href":"https://github.com/mozilla/pdf.js/pull/3684#discussion_r6363737"},"pull_request":{"href":"https://api.github.com/repos/mozilla/pdf.js/pulls/3684"}}}} | {
"id": 1663468,
"name": "pdf.js",
"url": "https://github.com/mozilla/pdf.js"
} | {
"id": null,
"login": "Rob--W",
"gravatar_id": "c916d92c098426d84778a7910cc32b39",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "mozilla",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-09-14T12:24:22 | null | {"repository":{"description":"PDF Reader in JavaScript","homepage":"","watchers":6791,"stargazers":6791,"forks":1182,"fork":false,"size":80722,"owner":"mozilla","private":false,"open_issues":437,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"JavaScript","created_at":"2011-04-25T23:32:03-07:00","pushed_at":"2013-09-10T13:45:56-07:00","master_branch":"master","organization":"mozilla"},"actor_attributes":{"type":"User","name":"Rob Wu","blog":"https://robwu.nl/","location":"The Netherlands","email":"[email protected]"},"url":"https://github.com/mozilla/pdf.js/pull/3684#discussion_r6363737"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/mozilla/zamboni/pulls/comments/4990951","id":4990951,"body":"`or` should go on line above","diff_hunk":"@@ -151,7 +156,12 @@ def _make_premium(self):\n price_id=self._initial_price_id())\n \n def is_paid(self):\n- return self.addon.premium_type in amo.ADDON_PREMIUMS\n+ is_paid = (self.addon.premium_type in amo.ADDON_PREMIUMS\n+ or self.is_free_inapp())","path":"mkt/developers/forms_payments.py","position":51,"original_position":51,"commit_id":"db1064a964067fcb2a4d31a1b38e9bb9f483b051","original_commit_id":"db1064a964067fcb2a4d31a1b38e9bb9f483b051","user":{"login":"cvan","id":203725,"avatar_url":"https://secure.gravatar.com/avatar/47de0e6948b289c9b4b4be0d6d66c0f4?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"47de0e6948b289c9b4b4be0d6d66c0f4","url":"https://api.github.com/users/cvan","html_url":"https://github.com/cvan","followers_url":"https://api.github.com/users/cvan/followers","following_url":"https://api.github.com/users/cvan/following{/other_user}","gists_url":"https://api.github.com/users/cvan/gists{/gist_id}","starred_url":"https://api.github.com/users/cvan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cvan/subscriptions","organizations_url":"https://api.github.com/users/cvan/orgs","repos_url":"https://api.github.com/users/cvan/repos","events_url":"https://api.github.com/users/cvan/events{/privacy}","received_events_url":"https://api.github.com/users/cvan/received_events","type":"User"},"created_at":"2013-07-02T17:51:44Z","updated_at":"2013-07-02T17:51:44Z","html_url":"https://github.com/mozilla/zamboni/pull/863#discussion_r4990951","pull_request_url":"https://api.github.com/repos/mozilla/zamboni/pulls/863","_links":{"self":{"href":"https://api.github.com/repos/mozilla/zamboni/pulls/comments/4990951"},"html":{"href":"https://github.com/mozilla/zamboni/pull/863#discussion_r4990951"},"pull_request":{"href":"https://api.github.com/repos/mozilla/zamboni/pulls/863"}}}} | {
"id": 347655,
"name": "zamboni",
"url": "https://github.com/mozilla/zamboni"
} | {
"id": null,
"login": "cvan",
"gravatar_id": "47de0e6948b289c9b4b4be0d6d66c0f4",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "mozilla",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-07-02T17:51:44 | null | {"repository":{"description":"A clandestine operation to make AMO happy","homepage":"http://zamboni.readthedocs.org/en/latest/","watchers":360,"stargazers":360,"forks":148,"fork":false,"size":31144,"owner":"mozilla","private":false,"open_issues":13,"has_issues":true,"has_downloads":false,"has_wiki":false,"language":"Python","created_at":"2009-10-23T12:35:34-07:00","pushed_at":"2013-07-02T10:46:55-07:00","master_branch":"master","organization":"mozilla"},"actor_attributes":{"type":"User","name":"Christopher Van","company":"Mozilla","location":"Mountain View, CA","email":"[email protected]"},"url":"https://github.com/mozilla/zamboni/pull/863#discussion_r4990951"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/mozilla/shumway/pulls/comments/6572094","id":6572094,"body":"I'd very much like to keep the processing of move for morphRecords here. Doing it below might be a very small reduction in LOC, (I'm not sure it is, even) but it decreases clarity quite a bit. This stuff is complicated enough and dependent on weirdness in the format enough that I'd like the code to be as clear as possible.","diff_hunk":"@@ -173,12 +168,6 @@ function convertRecordsToStyledPaths(records, fillPaths, linePaths,\n if (record.move) {\n x = record.moveX|0;\n y = record.moveY|0;\n- if (isMorph) {\n- morphX = morphRecord.moveX|0;\n- morphY = morphRecord.moveY|0;\n- }\n- } else if (isMorph) {\n- morphsOffset++;","path":"src/swf/shape.js","position":33,"original_position":33,"commit_id":"b104eda4e71caa249bca9676c0d76822d50b0aaf","original_commit_id":"b104eda4e71caa249bca9676c0d76822d50b0aaf","user":{"login":"tschneidereit","id":56359,"avatar_url":"https://0.gravatar.com/avatar/38540f0209aedc2e6447044c25bc0e9c?d=https%3A%2F%2Fidenticons.github.com%2F51f887a188fe1685b01df389d918530d.png","gravatar_id":"38540f0209aedc2e6447044c25bc0e9c","url":"https://api.github.com/users/tschneidereit","html_url":"https://github.com/tschneidereit","followers_url":"https://api.github.com/users/tschneidereit/followers","following_url":"https://api.github.com/users/tschneidereit/following{/other_user}","gists_url":"https://api.github.com/users/tschneidereit/gists{/gist_id}","starred_url":"https://api.github.com/users/tschneidereit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tschneidereit/subscriptions","organizations_url":"https://api.github.com/users/tschneidereit/orgs","repos_url":"https://api.github.com/users/tschneidereit/repos","events_url":"https://api.github.com/users/tschneidereit/events{/privacy}","received_events_url":"https://api.github.com/users/tschneidereit/received_events","type":"User"},"created_at":"2013-09-25T13:33:44Z","updated_at":"2013-09-25T13:33:44Z","html_url":"https://github.com/mozilla/shumway/pull/711#discussion_r6572094","pull_request_url":"https://api.github.com/repos/mozilla/shumway/pulls/711","_links":{"self":{"href":"https://api.github.com/repos/mozilla/shumway/pulls/comments/6572094"},"html":{"href":"https://github.com/mozilla/shumway/pull/711#discussion_r6572094"},"pull_request":{"href":"https://api.github.com/repos/mozilla/shumway/pulls/711"}}}} | {
"id": 3006455,
"name": "shumway",
"url": "https://github.com/mozilla/shumway"
} | {
"id": null,
"login": "tschneidereit",
"gravatar_id": "38540f0209aedc2e6447044c25bc0e9c",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "mozilla",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-09-25T13:33:44 | null | {"repository":{"description":"Shumway is a Flash VM and runtime written in JavaScript","homepage":"","watchers":1174,"stargazers":1174,"forks":109,"fork":false,"size":30840,"owner":"mozilla","private":false,"open_issues":18,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"ActionScript","created_at":"2011-12-18T07:22:51-08:00","pushed_at":"2013-09-25T05:08:55-07:00","master_branch":"master","organization":"mozilla"},"actor_attributes":{"type":"User","name":"Till Schneidereit","company":"Mozilla","blog":"http://tillschneidereit.net/","location":"Hamburg, Germany","email":"[email protected]"},"url":"https://github.com/mozilla/shumway/pull/711#discussion_r6572094"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/mozilla/bedrock/pulls/comments/5930425","id":5930425,"body":"Should we cache-bust the other font urls as well? Plus flushing the CDN.","diff_hunk":"@@ -4,8 +4,8 @@\n \n @font-face {\n font-family: 'Open Sans Light';\n- src: url('/media/fonts/OpenSans-Light-webfont.eot');\n- src: url('/media/fonts/OpenSans-Light-webfont.eot?#iefix') format('embedded-opentype'),\n+ src: url('/media/fonts/OpenSans-Light-webfont.eot?#2013');\n+ src: url('/media/fonts/OpenSans-Light-webfont.eot?#iefix2013') format('embedded-opentype'),\n url('/media/fonts/OpenSans-Light-webfont.woff') format('woff'),","path":"media/css/sandstone/fonts.less","position":8,"original_position":8,"commit_id":"fca2c3f576efca755d581ad6c7c85ad845b01b6a","original_commit_id":"fca2c3f576efca755d581ad6c7c85ad845b01b6a","user":{"login":"craigcook","id":205591,"avatar_url":"https://0.gravatar.com/avatar/3b7f519c31ada9be3fb3bd4532df919c?d=https%3A%2F%2Fidenticons.github.com%2F9217c134391f07b16dcf82f5ac6006de.png","gravatar_id":"3b7f519c31ada9be3fb3bd4532df919c","url":"https://api.github.com/users/craigcook","html_url":"https://github.com/craigcook","followers_url":"https://api.github.com/users/craigcook/followers","following_url":"https://api.github.com/users/craigcook/following{/other_user}","gists_url":"https://api.github.com/users/craigcook/gists{/gist_id}","starred_url":"https://api.github.com/users/craigcook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/craigcook/subscriptions","organizations_url":"https://api.github.com/users/craigcook/orgs","repos_url":"https://api.github.com/users/craigcook/repos","events_url":"https://api.github.com/users/craigcook/events{/privacy}","received_events_url":"https://api.github.com/users/craigcook/received_events","type":"User"},"created_at":"2013-08-22T17:15:19Z","updated_at":"2013-08-22T17:15:19Z","html_url":"https://github.com/mozilla/bedrock/pull/1184#discussion_r5930425","pull_request_url":"https://api.github.com/repos/mozilla/bedrock/pulls/1184","_links":{"self":{"href":"https://api.github.com/repos/mozilla/bedrock/pulls/comments/5930425"},"html":{"href":"https://github.com/mozilla/bedrock/pull/1184#discussion_r5930425"},"pull_request":{"href":"https://api.github.com/repos/mozilla/bedrock/pulls/1184"}}}} | {
"id": 1616665,
"name": "bedrock",
"url": "https://github.com/mozilla/bedrock"
} | {
"id": null,
"login": "craigcook",
"gravatar_id": "3b7f519c31ada9be3fb3bd4532df919c",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "mozilla",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-08-22T17:15:19 | null | {"repository":{"description":"Making mozilla.org awesome, one pebble at a time","homepage":"http://mozilla.org","watchers":118,"stargazers":118,"forks":166,"fork":false,"size":214124,"owner":"mozilla","private":false,"open_issues":6,"has_issues":true,"has_downloads":true,"has_wiki":false,"language":"Python","created_at":"2011-04-14T15:57:57-07:00","pushed_at":"2013-08-22T06:30:55-07:00","master_branch":"master","organization":"mozilla"},"actor_attributes":{"type":"User","name":"Craig Cook","company":"Mozilla","blog":"http://focalcurve.com","location":"California","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/mozilla/bedrock/pull/1184#discussion_r5930425"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/mozilla/addon-sdk/pulls/comments/4736840","id":4736840,"body":"And if it isn't a port?","diff_hunk":"@@ -0,0 +1,322 @@\n+/* This Source Code Form is subject to the terms of the Mozilla Public\n+ * License, v. 2.0. If a copy of the MPL was not distributed with this\n+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.\n+ */\n+\"use strict\";\n+\n+module.metadata = {\n+ \"stability\": \"experimental\"\n+};\n+\n+\n+const { Cc, Ci, CC } = require(\"chrome\");\n+\n+const { DuplexStream, InputStream, OutputStream } = require(\"./stream\");\n+const { emit, off } = require(\"../event/core\");\n+const { EventTarget } = require(\"../event/target\");\n+const { Buffer } = require(\"./buffer\");\n+const { Class } = require(\"../core/heritage\");\n+\n+const threadManager = Cc[\"@mozilla.org/thread-manager;1\"].\n+ getService(Ci.nsIThreadManager);\n+const { createTransport } = Cc[\"@mozilla.org/network/socket-transport-service;1\"].\n+ getService(Ci.nsISocketTransportService);\n+const makeServerSocket = CC(\"@mozilla.org/network/server-socket;1\",\n+ \"nsIServerSocket\");\n+const StreamPump = CC(\"@mozilla.org/network/input-stream-pump;1\",\n+ \"nsIInputStreamPump\", \"init\");\n+const StreamCopier = CC(\"@mozilla.org/network/async-stream-copier;1\",\n+ \"nsIAsyncStreamCopier\", \"init\");\n+const BinaryInputStream = CC(\"@mozilla.org/binaryinputstream;1\",\n+ \"nsIBinaryInputStream\", \"setInputStream\");\n+const BinaryOutputStream = CC(\"@mozilla.org/binaryoutputstream;1\",\n+ \"nsIBinaryOutputStream\", \"setOutputStream\");\n+\n+const {\n+ STATUS_RESOLVING, STATUS_CONNECTING_TO,\n+ STATUS_CONNECTED_TO, STATUS_SENDING_TO,\n+ STATUS_WAITING_FOR, STATUS_RECEIVING_FROM,\n+\n+ TIMEOUT_CONNECT, TIMEOUT_READ_WRITE\n+} = Ci.nsISocketTransport;\n+\n+const BACKLOG = -1;\n+const CONNECTING = \"opening\";\n+const OPEN = \"open\";\n+const CLOSED = \"closed\";\n+const READ = \"readOnly\";\n+const WRITE = \"writeOnly\";\n+const ENCODING_UTF8 = \"utf-8\";\n+const ENCODING_BINARY = \"binary\";\n+\n+const STATE_EVENTS = {\n+ open: \"connect\",\n+ writeOnly: \"end\",\n+ closed: \"close\"\n+};\n+\n+let isPort = (x) => parseInt(x) >= 0\n+\n+let accessor = () => {\n+ let map = new WeakMap();\n+ return (fd, value) => {\n+ if (value === null) map.delete(fd);\n+ if (value !== undefined) map.set(fd, value);\n+ return map.get(fd);\n+ }\n+}\n+\n+let onStatus = (socket) => {\n+ let state = socket.readyState;\n+ //if (previous !== state) {\n+ switch (state) {\n+ case CONNECTING:\n+ break;\n+ case OPEN:\n+ emit(socket, \"connect\");\n+ break;\n+ case WRITE:\n+ emit(socket, \"end\");\n+ break;\n+ case READ:\n+ break;\n+ case CLOSED:\n+ emit(socket, \"close\");\n+ break;\n+ }\n+ //}\n+}\n+\n+let nsITransport = accessor();\n+let isConnecting = accessor();\n+\n+const Socket = Class({\n+ extends: DuplexStream,\n+ initialize: function(options) {\n+ options = options || {};\n+\n+ if (\"server\" in options)\n+ this.server = options.server;\n+\n+ // This is client connected to your server.\n+ if (\"transport\" in options) {\n+ let transport = nsITransport(this, options.transport);\n+\n+ let asyncInputStream = transport.openInputStream(null, 0, 0);\n+ let asyncOutputStream = transport.openOutputStream(null, 0, 0);\n+\n+ let binaryInputStream = BinaryInputStream(asyncInputStream);\n+ let binaryOutputStream = BinaryOutputStream(asyncOutputStream);\n+\n+ let pump = StreamPump(asyncInputStream, -1, -1, 0, 0, false);\n+\n+\n+ transport.setEventSink({\n+ onTransportStatus: (transport, status, progress, total) => {\n+ let state = this.readyState;\n+ switch (status) {\n+ case STATUS_RESOLVING:\n+ isConnecting(this, true);\n+ break;\n+ case STATUS_CONNECTING_TO:\n+ isConnecting(this, true);\n+ break;\n+ case STATUS_CONNECTED_TO:\n+ isConnecting(this, false);\n+ this.readable = true;\n+ this.writable = true;\n+ break;\n+ case STATUS_SENDING_TO:\n+ return;\n+ case STATUS_WAITING_FOR:\n+ return;\n+ case STATUS_RECEIVING_FROM:\n+ return;\n+ }\n+\n+ emit(this, \"readyState\", state);\n+ onStatus(this);\n+ }\n+ }, threadManager.currentThread);\n+\n+ OutputStream.prototype.initialize.call(this, {\n+ asyncOutputStream: asyncOutputStream,\n+ output: binaryOutputStream\n+ });\n+\n+\n+ InputStream.prototype.initialize.call(this, {\n+ input: binaryInputStream,\n+ pump: pump\n+ });\n+\n+ this.read();\n+ }\n+ },\n+ bufferSize: 0,\n+ fd: null,\n+ type: null,\n+ resolving: false,\n+ get readyState() {\n+ if (isConnecting(this)) return CONNECTING;\n+ else if (this.readable && this.writable) return OPEN;\n+ else if (this.readable && !this.writable) return READ;\n+ else if (!this.readable && this.writable) return WRITE;\n+ else return CLOSED;\n+ },\n+ get remoteAddress() isConnecting(this) ? null : nsITransport(this).host,\n+ get remotePort() isConnecting(this) ? null : nsITransport(this).port,\n+ address: function address() {\n+ },\n+ setNoDelay: function setNoDelay() {\n+ },\n+ setKeepAlive: function setKeepAlive() {\n+ },\n+ setSecure: function setSecure() {\n+ },\n+ setTimeout: function setTimeout(time, callback) {\n+ if (callback) this.once(\"timeout\", callback);\n+\n+ nsITransport(this).setTimeout(time, TIMEOUT_READ_WRITE);\n+ },\n+ open: function open(fd, type) {\n+ throw Error(\"Not implemented\");\n+ },\n+ connect: function connect(port, host) {\n+ try {\n+ this.initialize({\n+ transport: createTransport(null, 0, host, port, null)\n+ });\n+ } catch(error) {\n+ emit(this, \"error\", error);\n+ }\n+ },\n+ setEncoding: function setEncoding(encoding) {\n+ },\n+ end: function end(data, encoding) {\n+ try {\n+ this.readable = false;\n+ this.writable = false;\n+\n+ nsITransport(this).close(0);\n+ onStatus(this);\n+ } catch(error) {\n+ emit(this, \"error\", error);\n+ }\n+ }\n+});\n+exports.Socket = Socket;\n+\n+let nsIServerSocket = accessor();\n+\n+const Server = Class({\n+ extends: EventTarget,\n+ initialize: function(options, listener) {\n+ options = options || {};\n+ if (\"loopbackOnly\" in options)\n+ this.loopbackOnly = !!options.loopbackOnly;\n+ if (\"maxConnections\" in options)\n+ this.maxConnections = options.maxConnections;\n+ if (\"connections\" in options)\n+ this.connections = options.connections;\n+\n+ nsIServerSocket(this, makeServerSocket());\n+\n+ if (listener) this.on(\"connection\", listener);\n+\n+ },\n+ type: null,\n+ get port() (nsIServerSocket(this) || 0).port,\n+ host: null,\n+ /**\n+ * The number of concurrent connections on the server.\n+ */\n+ connections: 0,\n+ /**\n+ * Set this property to reject connections when the server's connection\n+ * count gets high.\n+ */\n+ maxConnections: -1,\n+ /**\n+ * Returns the bound address of the server as seen by the operating system.\n+ * Useful to find which port was assigned when giving getting an OS-assigned\n+ * address.\n+ */\n+ address: function() this.host + ':' + this.port,\n+ listenFD: function listenFD(fd, type) {\n+ throw Error('Not implemented');\n+ },\n+ listen: function listen(port, host, callback) {\n+ let server = this;\n+ let connections = 0;\n+\n+ if (this.fd) throw Error(\"Server already opened\");\n+\n+ if (!callback) {\n+ callback = host\n+ host = \"localhost\"\n+ }\n+\n+ if (callback) this.on(\"listening\", callback)\n+\n+ if (isPort(port)) {","path":"lib/sdk/io/net.js","position":262,"original_position":262,"commit_id":"3168b816e5d3eef9c36f0cf9fee9d3a3f5ef4115","original_commit_id":"3168b816e5d3eef9c36f0cf9fee9d3a3f5ef4115","user":{"login":"Mossop","id":437326,"avatar_url":"https://secure.gravatar.com/avatar/362f7fbd402cbbcc24cc12580712aa62?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"362f7fbd402cbbcc24cc12580712aa62","url":"https://api.github.com/users/Mossop","html_url":"https://github.com/Mossop","followers_url":"https://api.github.com/users/Mossop/followers","following_url":"https://api.github.com/users/Mossop/following{/other_user}","gists_url":"https://api.github.com/users/Mossop/gists{/gist_id}","starred_url":"https://api.github.com/users/Mossop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mossop/subscriptions","organizations_url":"https://api.github.com/users/Mossop/orgs","repos_url":"https://api.github.com/users/Mossop/repos","events_url":"https://api.github.com/users/Mossop/events{/privacy}","received_events_url":"https://api.github.com/users/Mossop/received_events","type":"User"},"created_at":"2013-06-17T22:27:34Z","updated_at":"2013-06-17T22:27:34Z","html_url":"https://github.com/mozilla/addon-sdk/pull/1034#discussion_r4736840","pull_request_url":"https://api.github.com/repos/mozilla/addon-sdk/pulls/1034","_links":{"self":{"href":"https://api.github.com/repos/mozilla/addon-sdk/pulls/comments/4736840"},"html":{"href":"https://github.com/mozilla/addon-sdk/pull/1034#discussion_r4736840"},"pull_request":{"href":"https://api.github.com/repos/mozilla/addon-sdk/pulls/1034"}}}} | {
"id": 748030,
"name": "addon-sdk",
"url": "https://github.com/mozilla/addon-sdk"
} | {
"id": null,
"login": "Mossop",
"gravatar_id": "362f7fbd402cbbcc24cc12580712aa62",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "mozilla",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-06-17T22:27:34 | null | {"repository":{"description":"The Add-on SDK repository.","homepage":"https://wiki.mozilla.org/Labs/Jetpack","watchers":292,"stargazers":292,"forks":134,"fork":false,"size":8632,"owner":"mozilla","private":false,"open_issues":61,"has_issues":false,"has_downloads":true,"has_wiki":true,"language":"JavaScript","created_at":"2010-06-29T17:38:20-07:00","pushed_at":"2013-06-14T17:01:59-07:00","master_branch":"master","organization":"mozilla"},"actor_attributes":{"type":"User","name":"Dave Townsend","company":"Mozilla Corporation","blog":"http://www.oxymoronical.com","location":"Camarillo, CA","email":"[email protected]"},"url":"https://github.com/mozilla/addon-sdk/pull/1034#discussion_r4736840"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/mozilla/bedrock/pulls/comments/3965856","id":3965856,"body":"Consistify tabindex attr value as a Number here.","diff_hunk":"@@ -73,518 +71,307 @@\n * @author Steven Garrity <[email protected]>\n */\n \n-function Tabzilla()\n-{\n- if (typeof jQuery != 'undefined' && jQuery) {\n- jQuery(document).ready(Tabzilla.init);\n- } else {\n- Tabzilla.run();\n- }\n-}\n-\n-Tabzilla.READY_POLL_INTERVAL = 40;\n-Tabzilla.readyInterval = null;\n-Tabzilla.jQueryCDNSrc =\n- '//mozorg.cdn.mozilla.net/media/js/libs/jquery-1.7.1.min.js';\n-\n-Tabzilla.LINK_TITLE = {\n- CLOSED: '{{ _('Mozilla links')|js_escape }}',\n- OPENED: '{{ _('Close (Esc)')|js_escape }}'\n-}\n-\n-/**\n- * Whether or not Tabzilla is in small mode\n- *\n- * @var Boolean\n- */\n-Tabzilla.smallMode = false;\n-\n-/**\n- * Whether or not min/max width media queries are supported in CSS\n- *\n- * If not supported, the small mode is never triggered.\n- *\n- * @var Boolean\n- */\n-Tabzilla.hasMediaQueryWidths = (function(){\n- return !(/MSIE\\ (4|5|6|7|8)/.test(navigator.userAgent));\n-})();\n-\n-/**\n- * Sets up the DOMReady event for Tabzilla\n- *\n- * Adapted from the YUI Event component. Defined in Tabzilla so we do not\n- * depend on YUI or jQuery. The YUI DOMReady implementation is based on work\n- * Dean Edwards, John Resig, Matthias Miller and Diego Perini.\n- */\n-Tabzilla.run = function()\n-{\n- var webkit = 0, isIE = false, ua = navigator.userAgent;\n- var m = ua.match(/AppleWebKit\\/([^\\s]*)/);\n-\n- if (m && m[1]) {\n- webkit = parseInt(m[1], 10);\n- } else {\n- m = ua.match(/Opera[\\s\\/]([^\\s]*)/);\n- if (!m || !m[1]) {\n- m = ua.match(/MSIE\\s([^;]*)/);\n- if (m && m[1]) {\n- isIE = true;\n- }\n+;(function () {\n+ 'use strict';\n+ var panel;\n+ var tabzillaNav;\n+ var headlines;\n+ var tab;\n+ var opened = false;\n+ var hasMediaQueries = ('matchMedia' in window);\n+ var isGT_IE8 = function() {\n+ return !(/MSIE\\ (4|5|6|7|8)/.test(navigator.userAgent));\n+ };\n+ var mode = 'wide';\n+ var checkMode = function () {\n+ var currentMode = getMode();\n+ if (mode !== currentMode) {\n+ mode = currentMode;\n+ setMode();\n }\n- }\n-\n- // Internet Explorer: use the readyState of a defered script.\n- // This isolates what appears to be a safe moment to manipulate\n- // the DOM prior to when the document's readyState suggests\n- // it is safe to do so.\n- if (isIE) {\n- if (self !== self.top) {\n- document.onreadystatechange = function() {\n- if (document.readyState == 'complete') {\n- document.onreadystatechange = null;\n- Tabzilla.ready();\n- }\n- };\n+ };\n+ var getMode = function() {\n+ if ((isGT_IE8() || hasMediaQueries) && ($(window).outerWidth() <= 719)) {\n+ return 'compact';\n } else {\n- var n = document.createElement('p');\n- Tabzilla.readyInterval = setInterval(function() {\n- try {\n- // throws an error if doc is not ready\n- n.doScroll('left');\n- clearInterval(Tabzilla.readyInterval);\n- Tabzilla.readyInterval = null;\n- Tabzilla.ready();\n- n = null;\n- } catch (ex) {\n- }\n- }, Tabzilla.READY_POLL_INTERVAL);\n+ return 'wide';\n }\n-\n- // The document's readyState in Safari currently will\n- // change to loaded/complete before images are loaded.\n- } else if (webkit && webkit < 525) {\n- Tabzilla.readyInterval = setInterval(function() {\n- var rs = document.readyState;\n- if ('loaded' == rs || 'complete' == rs) {\n- clearInterval(Tabzilla.readyInterval);\n- Tabzilla.readyInterval = null;\n- Tabzilla.ready();\n- }\n- }, Tabzilla.READY_POLL_INTERVAL);\n-\n- // FireFox and Opera: These browsers provide a event for this\n- // moment. The latest WebKit releases now support this event.\n- } else {\n- var rs = document.readyState;\n- if (rs == 'interactive' || rs == 'complete') {\n- Tabzilla.ready();\n+ };\n+ var setMode = function () {\n+ if (mode === 'wide') {\n+ leaveCompactMode();\n } else {\n- Tabzilla.addEventListener(document, 'DOMContentLoaded', Tabzilla.ready);\n+ enterCompactMode();\n }\n- }\n-};\n-\n-Tabzilla.ready = function()\n-{\n- if (!Tabzilla.DOMReady) {\n- Tabzilla.DOMReady = true;\n-\n- var onLoad = function() {\n- Tabzilla.init();\n- Tabzilla.removeEventListener(\n- document,\n- 'DOMContentLoaded',\n- Tabzilla.ready\n- );\n- };\n-\n- // if we don't have jQuery, dynamically load jQuery from CDN\n- if (typeof jQuery == 'undefined') {\n- var script = document.createElement('script');\n-\n- if (script.readyState) {\n- // IE\n- script.onreadystatechange = function() {\n- if ( script.readyState == 'loaded'\n- || script.readyState == 'complete'\n- ) {\n- onLoad();\n+ };\n+ var leaveCompactMode = function () {\n+ removeCompactModeAttributes();\n+ removeCompactModeEvents();\n+ panel.focus();\n+ };\n+ var enterCompactMode = function () {\n+ addCompactModeAttributes();\n+ addCompactModeEvents();\n+ };\n+ var addCompactModeAttributes = function () {\n+ tabzillaNav.find('>ul').attr('role', 'presentation');\n+\n+ headlines.each(function(i) {\n+ $(this).attr({\n+ 'id': 'tab-'+i,\n+ 'aria-controls': 'panel-'+i,\n+ 'tabindex': '-1',\n+ 'role': 'tab',\n+ 'aria-expanded': false\n+ });\n+ });\n+ if (!tabzillaNav.find('h2[tabindex=0]').length) {\n+ tabzillaNav.find('h2:first').attr('tabindex', 0);\n+ }\n+ tabzillaNav.find('div').each(function(i) {\n+ $(this).attr({\n+ 'id': 'panel-'+i,\n+ 'aria-labeledby': 'tab-'+i,\n+ 'role': 'tabpanel'\n+ }).css('display','none');\n+ });\n+ };\n+ var removeCompactModeAttributes = function () {\n+ headlines.removeAttr('id aria-controls tabindex role aria-expanded');\n+ tabzillaNav.find('div').removeAttr('id aria-labeledby role style');\n+ };\n+ var addCompactModeEvents = function () {\n+ tabzillaNav.on('click.submenu', 'h2', function (event){\n+ event.preventDefault();\n+ var div = $(event.target).next('div');\n+ $(event.target).attr('aria-expanded', div.is(':hidden'));\n+ div.toggle();\n+ });\n+ tabzillaNav.on('keydown.submenu', function (event){\n+ var which = event.which;\n+ var target = $(event.target);\n+ // enter or space\n+ if (which === 13 || which === 32) {\n+ event.preventDefault();\n+ target.trigger('click');\n+ }\n+ // up or left\n+ if (which === 37 || which === 38) {\n+ event.preventDefault();\n+ headlines.each(function(i) {\n+ if (i > 0 && $(this).attr('tabindex') === 0) {\n+ $(this).attr('tabindex', '-1');","path":"apps/tabzilla/templates/tabzilla/tabzilla.js","position":231,"original_position":231,"commit_id":"9fbff4b451556a1ca46721ba36c1ef111743ba8f","original_commit_id":"9fbff4b451556a1ca46721ba36c1ef111743ba8f","user":{"login":"gauthierm","id":120511,"avatar_url":"https://secure.gravatar.com/avatar/26e679b0cb3411bbedbba66ca6db1cad?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"26e679b0cb3411bbedbba66ca6db1cad","url":"https://api.github.com/users/gauthierm","html_url":"https://github.com/gauthierm","followers_url":"https://api.github.com/users/gauthierm/followers","following_url":"https://api.github.com/users/gauthierm/following","gists_url":"https://api.github.com/users/gauthierm/gists{/gist_id}","starred_url":"https://api.github.com/users/gauthierm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gauthierm/subscriptions","organizations_url":"https://api.github.com/users/gauthierm/orgs","repos_url":"https://api.github.com/users/gauthierm/repos","events_url":"https://api.github.com/users/gauthierm/events{/privacy}","received_events_url":"https://api.github.com/users/gauthierm/received_events","type":"User"},"created_at":"2013-04-25T20:35:07Z","updated_at":"2013-04-25T20:35:07Z","html_url":"https://github.com/mozilla/bedrock/pull/689#discussion_r3965856","pull_request_url":"https://api.github.com/repos/mozilla/bedrock/pulls/689","_links":{"self":{"href":"https://api.github.com/repos/mozilla/bedrock/pulls/comments/3965856"},"html":{"href":"https://github.com/mozilla/bedrock/pull/689#discussion_r3965856"},"pull_request":{"href":"https://api.github.com/repos/mozilla/bedrock/pulls/689"}}}} | {
"id": 1616665,
"name": "bedrock",
"url": "https://github.com/mozilla/bedrock"
} | {
"id": null,
"login": "gauthierm",
"gravatar_id": "26e679b0cb3411bbedbba66ca6db1cad",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "mozilla",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-04-25T20:35:07 | null | {"repository":{"description":"Making mozilla.org awesome, one pebble at a time","homepage":"http://mozilla.org","watchers":102,"stargazers":102,"forks":134,"fork":false,"size":1552,"owner":"mozilla","private":false,"open_issues":23,"has_issues":true,"has_downloads":true,"has_wiki":false,"language":"Python","created_at":"2011-04-14T15:57:57-07:00","pushed_at":"2013-04-25T12:43:37-07:00","master_branch":"master","organization":"mozilla"},"actor_attributes":{"type":"User","name":"Michael Gauthier","company":"silverorange","location":"Charlottetown, PEI","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/mozilla/bedrock/pull/689#discussion_r3965856"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/mozilla/fireplace/pulls/comments/4893381","id":4893381,"body":"This should probably go outside of the `done()`.","diff_hunk":"@@ -54,6 +54,7 @@ define('views/feedback',\n builder.start('settings/feedback.html').done(function() {\n $('.feedback').removeClass('modal');\n addFeedbackModal();\n+ $('.linefit').linefit();","path":"hearth/media/js/views/feedback.js","position":13,"original_position":13,"commit_id":"db79e1b107134a2fe5f06bc9ff3b80f1b62fe7c8","original_commit_id":"db79e1b107134a2fe5f06bc9ff3b80f1b62fe7c8","user":{"login":"mattbasta","id":279498,"avatar_url":"https://secure.gravatar.com/avatar/88fb40c25ad334d86f189821bbca1c9f?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"88fb40c25ad334d86f189821bbca1c9f","url":"https://api.github.com/users/mattbasta","html_url":"https://github.com/mattbasta","followers_url":"https://api.github.com/users/mattbasta/followers","following_url":"https://api.github.com/users/mattbasta/following{/other_user}","gists_url":"https://api.github.com/users/mattbasta/gists{/gist_id}","starred_url":"https://api.github.com/users/mattbasta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattbasta/subscriptions","organizations_url":"https://api.github.com/users/mattbasta/orgs","repos_url":"https://api.github.com/users/mattbasta/repos","events_url":"https://api.github.com/users/mattbasta/events{/privacy}","received_events_url":"https://api.github.com/users/mattbasta/received_events","type":"User"},"created_at":"2013-06-26T15:16:19Z","updated_at":"2013-06-26T15:16:19Z","html_url":"https://github.com/mozilla/fireplace/pull/199#discussion_r4893381","pull_request_url":"https://api.github.com/repos/mozilla/fireplace/pulls/199","_links":{"self":{"href":"https://api.github.com/repos/mozilla/fireplace/pulls/comments/4893381"},"html":{"href":"https://github.com/mozilla/fireplace/pull/199#discussion_r4893381"},"pull_request":{"href":"https://api.github.com/repos/mozilla/fireplace/pulls/199"}}}} | {
"id": 8046076,
"name": "fireplace",
"url": "https://github.com/mozilla/fireplace"
} | {
"id": null,
"login": "mattbasta",
"gravatar_id": "88fb40c25ad334d86f189821bbca1c9f",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "mozilla",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-06-26T15:16:19 | null | {"repository":{"description":"Ignition, the Remix","homepage":"https://marketplace.firefox.com/","watchers":13,"stargazers":13,"forks":31,"fork":true,"size":3292,"owner":"mozilla","private":false,"open_issues":2,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"JavaScript","created_at":"2013-02-05T22:41:06-08:00","pushed_at":"2013-06-26T08:14:39-07:00","master_branch":"master","organization":"mozilla"},"actor_attributes":{"type":"User","name":"Matt Basta","company":"Mozilla Corporation","blog":"http://mattbasta.com","location":"Mountain View, Ca","email":"[email protected]"},"url":"https://github.com/mozilla/fireplace/pull/199#discussion_r4893381"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/mozilla/togetherjs/pulls/comments/7904347","id":7904347,"diff_hunk":"@@ -21,6 +21,7 @@\n \"less-middleware\": \"~0.1.9\",\n \"newrelic\": \"0.9.20\",\n \"grunt-amd-check\": \"~0.5.1\",\n+ \"webmaker-i18n\": \"https://github.com/mozilla/node-webmaker-i18n/archive/v0.2.3.tar.gz\",","path":"package.json","position":4,"original_position":4,"commit_id":"3f168405ca3b1b985d356cf1bb06b72e24f82dee","original_commit_id":"3f168405ca3b1b985d356cf1bb06b72e24f82dee","user":{"login":"ianb","id":44390,"avatar_url":"https://1.gravatar.com/avatar/cc8334869c9d2a9e603017f2da805eb3?d=https%3A%2F%2Fidenticons.github.com%2F58caf27a48e7930aefd5437298d64a70.png&r=x","gravatar_id":"cc8334869c9d2a9e603017f2da805eb3","url":"https://api.github.com/users/ianb","html_url":"https://github.com/ianb","followers_url":"https://api.github.com/users/ianb/followers","following_url":"https://api.github.com/users/ianb/following{/other_user}","gists_url":"https://api.github.com/users/ianb/gists{/gist_id}","starred_url":"https://api.github.com/users/ianb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ianb/subscriptions","organizations_url":"https://api.github.com/users/ianb/orgs","repos_url":"https://api.github.com/users/ianb/repos","events_url":"https://api.github.com/users/ianb/events{/privacy}","received_events_url":"https://api.github.com/users/ianb/received_events","type":"User","site_admin":false},"body":"Are we using anything from this library? I would guess we are not.","created_at":"2013-11-25T20:47:16Z","updated_at":"2013-11-25T20:47:16Z","html_url":"https://github.com/mozilla/togetherjs/pull/921#discussion_r7904347","pull_request_url":"https://api.github.com/repos/mozilla/togetherjs/pulls/921","_links":{"self":{"href":"https://api.github.com/repos/mozilla/togetherjs/pulls/comments/7904347"},"html":{"href":"https://github.com/mozilla/togetherjs/pull/921#discussion_r7904347"},"pull_request":{"href":"https://api.github.com/repos/mozilla/togetherjs/pulls/921"}}}} | {
"id": 7009393,
"name": "togetherjs",
"url": "https://github.com/mozilla/togetherjs"
} | {
"id": null,
"login": "ianb",
"gravatar_id": "cc8334869c9d2a9e603017f2da805eb3",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "mozilla",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-11-25T20:47:16 | null | {"repository":{"description":"A service for your website that makes it surprisingly easy to collaborate in real-time.","homepage":"https://togetherjs.com","watchers":3659,"stargazers":3659,"forks":349,"fork":false,"size":33868,"owner":"mozilla","private":false,"open_issues":231,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"JavaScript","created_at":"2012-12-04T16:15:41-08:00","pushed_at":"2013-11-25T12:05:56-08:00","master_branch":"develop","organization":"mozilla"},"actor_attributes":{"type":"User","name":"Ian Bicking","company":"http://mozilla.org","blog":"http://blog.ianbicking.org","location":"Minneapolis, Minnesota, USA","email":"[email protected]"},"url":"https://github.com/mozilla/togetherjs/pull/921#discussion_r7904347"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/mozilla/mozmill-ci/pulls/comments/7767538","id":7767538,"diff_hunk":"@@ -0,0 +1,74 @@\n+#!/usr/bin/env python\n+\n+# This Source Code Form is subject to the terms of the Mozilla Public\n+# License, v. 2.0. If a copy of the MPL was not distributed with this\n+# file, You can obtain one at http://mozilla.org/MPL/2.0/.\n+\n+import os\n+import re\n+from subprocess import call\n+import urllib2\n+\n+from mozdownload import DirectScraper","path":"start.py","position":12,"original_position":12,"commit_id":"fa9aa60259e2b1be2e3c46849db9ba527f27710e","original_commit_id":"fa9aa60259e2b1be2e3c46849db9ba527f27710e","user":{"login":"Nebelhom","id":2185557,"avatar_url":"https://0.gravatar.com/avatar/ba73fbde03f670c69188f59371b2b6a2?d=https%3A%2F%2Fidenticons.github.com%2Fb1b2140338732a034fc30d3476f6d227.png&r=x","gravatar_id":"ba73fbde03f670c69188f59371b2b6a2","url":"https://api.github.com/users/Nebelhom","html_url":"https://github.com/Nebelhom","followers_url":"https://api.github.com/users/Nebelhom/followers","following_url":"https://api.github.com/users/Nebelhom/following{/other_user}","gists_url":"https://api.github.com/users/Nebelhom/gists{/gist_id}","starred_url":"https://api.github.com/users/Nebelhom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nebelhom/subscriptions","organizations_url":"https://api.github.com/users/Nebelhom/orgs","repos_url":"https://api.github.com/users/Nebelhom/repos","events_url":"https://api.github.com/users/Nebelhom/events{/privacy}","received_events_url":"https://api.github.com/users/Nebelhom/received_events","type":"User","site_admin":false},"body":"What do you suggest as a solution? Copy and paste the download function of the scraper and slim it down?","created_at":"2013-11-19T18:50:59Z","updated_at":"2013-11-19T18:50:59Z","html_url":"https://github.com/mozilla/mozmill-ci/pull/340#discussion_r7767538","pull_request_url":"https://api.github.com/repos/mozilla/mozmill-ci/pulls/340","_links":{"self":{"href":"https://api.github.com/repos/mozilla/mozmill-ci/pulls/comments/7767538"},"html":{"href":"https://github.com/mozilla/mozmill-ci/pull/340#discussion_r7767538"},"pull_request":{"href":"https://api.github.com/repos/mozilla/mozmill-ci/pulls/340"}}}} | {
"id": 3037564,
"name": "mozmill-ci",
"url": "https://github.com/mozilla/mozmill-ci"
} | {
"id": null,
"login": "Nebelhom",
"gravatar_id": "ba73fbde03f670c69188f59371b2b6a2",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "mozilla",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-11-19T18:50:59 | null | {"repository":{"description":"Mozmill test-runs driven by Pulse and Jenkins","homepage":"https://wiki.mozilla.org/Auto-tools/Automation_Development/Projects/Mozmill_Automation/Mozmill_CI","watchers":9,"stargazers":9,"forks":12,"fork":false,"size":55504,"owner":"mozilla","private":false,"open_issues":57,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Python","created_at":"2011-12-22T16:33:51-08:00","pushed_at":"2013-11-19T01:37:58-08:00","master_branch":"master","organization":"mozilla"},"actor_attributes":{"type":"User","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/mozilla/mozmill-ci/pull/340#discussion_r7767538"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/mozilla/socorro-crashstats/pulls/comments/4364996","id":4364996,"body":"Thanks for teaching me python :)\r\n\r\nMy point is this; you don't want to parse the `start_date` and `end_date` when you're doing going to use them. What you can do is one of two:\r\n\r\n```python\r\nfor ....\r\n if params['product'] != version['product']:\r\n continue\r\n start_date = isodate.parse_date(version['start_date'])\r\n end_date = isodate.parse_date(version['end_date'])\r\n if start_date ...\r\n```\r\n\r\n...or...\r\n\r\n```python\r\nfor ....\r\n if (\r\n params['product'] != version['product'] and :\r\n isodate.parse_date(version['start_date']) <= now and\r\n isodate.parse_date(version['end_date']) >= now\r\n ):\r\n data['available_versions'].append(version['version'])\r\n```\r\n\r\nIt's no biggie. It's just bad practice to compute things you certainly won't be needing. E.g.\r\n\r\n```\r\nfor company in all_us_charities:\r\n verdict = audit_all_taxes(company) # expensive computation\r\n if re.findall('Tea', company):\r\n print \"Audited\", company, \"Verdict:\", verdict\r\n```","diff_hunk":"@@ -467,6 +467,18 @@ def daily(request):\n for x in request.currentversions\n if x['product'] == params['product'] and x['featured']\n ]\n+ \n+ data['available_versions'] = []\n+ now = datetime.datetime.utcnow().date()\n+ for version in request.currentversions:\n+ start_date = isodate.parse_date(version['start_date'])\n+ end_date = isodate.parse_date(version['end_date'])\n+ if(\n+ params['product'] == version['product'] and","path":"crashstats/crashstats/views.py","position":11,"original_position":11,"commit_id":"2557efeae03635a0f3d4a3b68a00df197a7d585a","original_commit_id":"2557efeae03635a0f3d4a3b68a00df197a7d585a","user":{"login":"peterbe","id":26739,"avatar_url":"https://secure.gravatar.com/avatar/37d081c393f95a14e2704af38ecc4c8d?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"37d081c393f95a14e2704af38ecc4c8d","url":"https://api.github.com/users/peterbe","html_url":"https://github.com/peterbe","followers_url":"https://api.github.com/users/peterbe/followers","following_url":"https://api.github.com/users/peterbe/following{/other_user}","gists_url":"https://api.github.com/users/peterbe/gists{/gist_id}","starred_url":"https://api.github.com/users/peterbe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peterbe/subscriptions","organizations_url":"https://api.github.com/users/peterbe/orgs","repos_url":"https://api.github.com/users/peterbe/repos","events_url":"https://api.github.com/users/peterbe/events{/privacy}","received_events_url":"https://api.github.com/users/peterbe/received_events","type":"User"},"created_at":"2013-05-23T17:06:00Z","updated_at":"2013-05-23T17:06:00Z","html_url":"https://github.com/mozilla/socorro-crashstats/pull/349#discussion_r4364996","pull_request_url":"https://api.github.com/repos/mozilla/socorro-crashstats/pulls/349","_links":{"self":{"href":"https://api.github.com/repos/mozilla/socorro-crashstats/pulls/comments/4364996"},"html":{"href":"https://github.com/mozilla/socorro-crashstats/pull/349#discussion_r4364996"},"pull_request":{"href":"https://api.github.com/repos/mozilla/socorro-crashstats/pulls/349"}}}} | {
"id": 4291939,
"name": "socorro-crashstats",
"url": "https://github.com/mozilla/socorro-crashstats"
} | {
"id": null,
"login": "peterbe",
"gravatar_id": "37d081c393f95a14e2704af38ecc4c8d",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "mozilla",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-05-23T17:06:00 | null | {"repository":{"description":"crash-stats.m.o web UI using playdoh (Mozilla's django-based framework)","homepage":"https://github.com/mozilla/socorro","watchers":19,"stargazers":19,"forks":19,"fork":false,"size":568,"owner":"mozilla","private":false,"open_issues":9,"has_issues":false,"has_downloads":true,"has_wiki":false,"language":"Python","created_at":"2012-05-10T18:30:29-07:00","pushed_at":"2013-05-23T08:18:08-07:00","master_branch":"master","organization":"mozilla"},"actor_attributes":{"type":"User","name":"Peter Bengtsson","company":"Mozilla","blog":"www.peterbe.com","location":"Mountain View, California","email":"[email protected]"},"url":"https://github.com/mozilla/socorro-crashstats/pull/349#discussion_r4364996"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/mozilla/popcorn.webmaker.org/pulls/comments/5659451","id":5659451,"body":"Let's try altering this a bit to use readystate checks (untested):\r\n\r\n```javascript\r\nfunction ready( json ) {\r\n _readyCallback = _readyCallback || function(){};\r\n\r\n function domReady() {\r\n // If the DOM isn't ready yet, repeat when it is\r\n if ( document.readyState !== \"complete\" ) {\r\n document.onreadystatechange = domReady;\r\n return;\r\n }\r\n document.onreadystatechange = null;\r\n _strings = json;\r\n _isReady = true;\r\n _readyCallback();\r\n }\r\n\r\n domReady(); \r\n}\r\n```","diff_hunk":"@@ -0,0 +1,54 @@\n+define( [ '../util/xhr' ], function( xhr ) {\n+ var _strings,\n+ _readyCallback = function (){},\n+ _isReady = false;\n+\n+ function ready( json ) {\n+ _readyCallback = _readyCallback || function(){};\n+\n+ function domReady() {\n+ document.removeEventListener( \"DOMContentLoaded\", domReady, false );\n+ _strings = json;\n+ _isReady = true;\n+ _readyCallback();\n+ }\n+ document.addEventListener( \"DOMContentLoaded\", domReady, false );","path":"public/src/core/localized.js","position":15,"original_position":15,"commit_id":"558a33079bf4f6838c478dd4a01a599cbffea8fb","original_commit_id":"558a33079bf4f6838c478dd4a01a599cbffea8fb","user":{"login":"humphd","id":427398,"avatar_url":"https://secure.gravatar.com/avatar/467b6f36e2a9ba3f0ec119eddaab6a62?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"467b6f36e2a9ba3f0ec119eddaab6a62","url":"https://api.github.com/users/humphd","html_url":"https://github.com/humphd","followers_url":"https://api.github.com/users/humphd/followers","following_url":"https://api.github.com/users/humphd/following{/other_user}","gists_url":"https://api.github.com/users/humphd/gists{/gist_id}","starred_url":"https://api.github.com/users/humphd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/humphd/subscriptions","organizations_url":"https://api.github.com/users/humphd/orgs","repos_url":"https://api.github.com/users/humphd/repos","events_url":"https://api.github.com/users/humphd/events{/privacy}","received_events_url":"https://api.github.com/users/humphd/received_events","type":"User"},"created_at":"2013-08-08T14:50:18Z","updated_at":"2013-08-08T14:50:18Z","html_url":"https://github.com/mozilla/popcorn.webmaker.org/pull/152#discussion_r5659451","pull_request_url":"https://api.github.com/repos/mozilla/popcorn.webmaker.org/pulls/152","_links":{"self":{"href":"https://api.github.com/repos/mozilla/popcorn.webmaker.org/pulls/comments/5659451"},"html":{"href":"https://github.com/mozilla/popcorn.webmaker.org/pull/152#discussion_r5659451"},"pull_request":{"href":"https://api.github.com/repos/mozilla/popcorn.webmaker.org/pulls/152"}}}} | {
"id": 9989556,
"name": "popcorn.webmaker.org",
"url": "https://github.com/mozilla/popcorn.webmaker.org"
} | {
"id": null,
"login": "humphd",
"gravatar_id": "467b6f36e2a9ba3f0ec119eddaab6a62",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "mozilla",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-08-08T14:50:18 | null | {"repository":{"description":"","watchers":8,"stargazers":8,"forks":19,"fork":false,"size":7395,"owner":"mozilla","private":false,"open_issues":53,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"JavaScript","created_at":"2013-05-10T13:15:43-07:00","pushed_at":"2013-08-07T10:29:20-07:00","master_branch":"master","organization":"mozilla"},"actor_attributes":{"type":"User","name":"David Humphrey","blog":"http://vocamus.net/dave","location":"","email":"[email protected]"},"url":"https://github.com/mozilla/popcorn.webmaker.org/pull/152#discussion_r5659451"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/mozilla/gaia-ui-tests/pulls/comments/4942916","id":4942916,"body":"Yeah typo.","diff_hunk":"@@ -0,0 +1,79 @@\n+# This Source Code Form is subject to the terms of the Mozilla Public\n+# License, v. 2.0. If a copy of the MPL was not distributed with this\n+# file, You can obtain one at http://mozilla.org/MPL/2.0/.\n+\n+import time\n+\n+from gaiatest import GaiaTestCase\n+from gaiatest.apps.email.app import Email\n+from gaiatest.mocks.email_message import EmailMessage\n+\n+\n+class TestReceiveActiveSyncEmail(GaiaTestCase):\n+\n+ def setUp(self):\n+ GaiaTestCase.setUp(self)\n+ self.connect_to_network()\n+\n+ senders_account = self.testvars['email']['IMAP']\n+ self.email_message = EmailMessage(senders_account)\n+\n+ def test_receive_active_sync_email(self):\n+ # setup ActiveSync account\n+ email = Email(self.marionette)\n+ email.launch()\n+\n+ email.setup_active_sync_email(\n+ self.testvars['email']['ActiveSync'])\n+\n+ # wait for sync to complete\n+ email.wait_for_emails_to_sync()\n+\n+ # send email to active sync account\n+ recipients_email = self.testvars['email']['ActiveSync']\n+ current_time = time.time()\n+ subject = 'Test subject %s' % current_time\n+ message = 'Test message %s' % current_time\n+ mock_email = self.email_message.send(recipients_email['email'],\n+ subject, message)\n+\n+ # wait for the email to arrive\n+ email.wait_for_email(subject)\n+\n+ # check if the sender's email address is fine\n+ self.assertEqual(email.mails[0].senders_email,\n+ mock_email.senders_email,\n+ 'Senders\\'s email on the inbox screen is incorrect. '\n+ 'Expected email is %s. Actual email is %s.' % (\n+ mock_email.senders_email,\n+ emails.mails[0].senders_email))","path":"gaiatest/tests/email/test_receive_active_sync_email.py","position":49,"original_position":49,"commit_id":"0e81f848fd73c74427f175da4ef022fd9f224509","original_commit_id":"0e81f848fd73c74427f175da4ef022fd9f224509","user":{"login":"vaidik","id":542077,"avatar_url":"https://secure.gravatar.com/avatar/9f2a1db7d95b36b91c2b97dab2941cf6?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"9f2a1db7d95b36b91c2b97dab2941cf6","url":"https://api.github.com/users/vaidik","html_url":"https://github.com/vaidik","followers_url":"https://api.github.com/users/vaidik/followers","following_url":"https://api.github.com/users/vaidik/following{/other_user}","gists_url":"https://api.github.com/users/vaidik/gists{/gist_id}","starred_url":"https://api.github.com/users/vaidik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vaidik/subscriptions","organizations_url":"https://api.github.com/users/vaidik/orgs","repos_url":"https://api.github.com/users/vaidik/repos","events_url":"https://api.github.com/users/vaidik/events{/privacy}","received_events_url":"https://api.github.com/users/vaidik/received_events","type":"User"},"created_at":"2013-06-28T17:07:57Z","updated_at":"2013-06-28T17:07:57Z","html_url":"https://github.com/mozilla/gaia-ui-tests/pull/1024#discussion_r4942916","pull_request_url":"https://api.github.com/repos/mozilla/gaia-ui-tests/pulls/1024","_links":{"self":{"href":"https://api.github.com/repos/mozilla/gaia-ui-tests/pulls/comments/4942916"},"html":{"href":"https://github.com/mozilla/gaia-ui-tests/pull/1024#discussion_r4942916"},"pull_request":{"href":"https://api.github.com/repos/mozilla/gaia-ui-tests/pulls/1024"}}}} | {
"id": 6697439,
"name": "gaia-ui-tests",
"url": "https://github.com/mozilla/gaia-ui-tests"
} | {
"id": null,
"login": "vaidik",
"gravatar_id": "9f2a1db7d95b36b91c2b97dab2941cf6",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "mozilla",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-06-28T17:07:57 | null | {"repository":{"description":"UI tests for Gaia","watchers":10,"stargazers":10,"forks":63,"fork":false,"size":2428,"owner":"mozilla","private":false,"open_issues":78,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Python","created_at":"2012-11-14T16:41:29-08:00","pushed_at":"2013-06-28T07:43:12-07:00","master_branch":"master","organization":"mozilla"},"actor_attributes":{"type":"User","name":"Vaidik Kapoor","blog":"www.vaidikkapoor.info","location":"New Delhi, India","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/mozilla/gaia-ui-tests/pull/1024#discussion_r4942916"} |
PullRequestReviewCommentEvent | true | {"comment":{"created_at":"2013-01-28T22:44:47Z","updated_at":"2013-01-28T22:44:47Z","body":"Oops. Thanks for this. :-)","position":5,"commit_id":"c35836dd4a6a4d35d3d6d06fc00e198bde7d6c9f","original_commit_id":"c35836dd4a6a4d35d3d6d06fc00e198bde7d6c9f","id":2801133,"original_position":5,"user":{"subscriptions_url":"https://api.github.com/users/erikrose/subscriptions","events_url":"https://api.github.com/users/erikrose/events{/privacy}","repos_url":"https://api.github.com/users/erikrose/repos","avatar_url":"https://secure.gravatar.com/avatar/996133d4acd5aa2e687acbe5bd3da2c8?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","starred_url":"https://api.github.com/users/erikrose/starred{/owner}{/repo}","organizations_url":"https://api.github.com/users/erikrose/orgs","id":295816,"followers_url":"https://api.github.com/users/erikrose/followers","gravatar_id":"996133d4acd5aa2e687acbe5bd3da2c8","received_events_url":"https://api.github.com/users/erikrose/received_events","type":"User","following_url":"https://api.github.com/users/erikrose/following","login":"erikrose","url":"https://api.github.com/users/erikrose","gists_url":"https://api.github.com/users/erikrose/gists{/gist_id}"},"path":"makefile","url":"https://api.github.com/repos/mozilla/dxr/pulls/comments/2801133","_links":{"html":{"href":"https://github.com/mozilla/dxr/pull/80#discussion_r2801133"},"self":{"href":"https://api.github.com/repos/mozilla/dxr/pulls/comments/2801133"},"pull_request":{"href":"https://api.github.com/repos/mozilla/dxr/pulls/80"}}}} | {
"id": 1795049,
"name": "dxr",
"url": "https://github.com/mozilla/dxr"
} | {
"id": null,
"login": "erikrose",
"gravatar_id": "996133d4acd5aa2e687acbe5bd3da2c8",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "mozilla",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-01-28T22:44:47 | null | {"repository":{"stargazers":73,"owner":"mozilla","has_downloads":true,"open_issues":7,"organization":"mozilla","homepage":"","master_branch":"testing","fork":false,"size":312,"has_wiki":true,"created_at":"2011-05-24T11:52:38-07:00","description":"An intelligent source code browser","watchers":73,"private":false,"has_issues":true,"pushed_at":"2013-01-28T14:11:59-08:00","integrate_branch":"dxr-clang","forks":35,"language":"Python"},"actor_attributes":{"name":"Erik Rose","company":"Mozilla","blog":"http://www.ploneforeducation.com/","location":"Mountain View, CA","email":"[email protected]","type":"User"},"url":"https://github.com/mozilla/dxr/pull/80#discussion_r2801133"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/mozilla/zamboni/pulls/comments/7041202","id":7041202,"diff_hunk":"@@ -76,6 +76,13 @@ def approve_rereview(theme):\n reupload = rereview[0]\n \n if reupload.header_path != reupload.theme.header_path:\n+ create_persona_preview_images(\n+ src=reupload.header_path,","path":"mkt/reviewers/tasks.py","position":5,"original_position":5,"commit_id":"678651d8e02dd568cbce42a832e71e77df4fa128","original_commit_id":"678651d8e02dd568cbce42a832e71e77df4fa128","user":{"login":"cvan","id":203725,"avatar_url":"https://0.gravatar.com/avatar/47de0e6948b289c9b4b4be0d6d66c0f4?d=https%3A%2F%2Fidenticons.github.com%2Fe8d88d4bdf0c8bb9968e62c64a9d8df1.png","gravatar_id":"47de0e6948b289c9b4b4be0d6d66c0f4","url":"https://api.github.com/users/cvan","html_url":"https://github.com/cvan","followers_url":"https://api.github.com/users/cvan/followers","following_url":"https://api.github.com/users/cvan/following{/other_user}","gists_url":"https://api.github.com/users/cvan/gists{/gist_id}","starred_url":"https://api.github.com/users/cvan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cvan/subscriptions","organizations_url":"https://api.github.com/users/cvan/orgs","repos_url":"https://api.github.com/users/cvan/repos","events_url":"https://api.github.com/users/cvan/events{/privacy}","received_events_url":"https://api.github.com/users/cvan/received_events","type":"User","site_admin":false},"body":"lack of indentation it looks like here? can ya indent by four spaces?","created_at":"2013-10-17T18:05:58Z","updated_at":"2013-10-17T18:05:58Z","html_url":"https://github.com/mozilla/zamboni/pull/1262#discussion_r7041202","pull_request_url":"https://api.github.com/repos/mozilla/zamboni/pulls/1262","_links":{"self":{"href":"https://api.github.com/repos/mozilla/zamboni/pulls/comments/7041202"},"html":{"href":"https://github.com/mozilla/zamboni/pull/1262#discussion_r7041202"},"pull_request":{"href":"https://api.github.com/repos/mozilla/zamboni/pulls/1262"}}}} | {
"id": 347655,
"name": "zamboni",
"url": "https://github.com/mozilla/zamboni"
} | {
"id": null,
"login": "cvan",
"gravatar_id": "47de0e6948b289c9b4b4be0d6d66c0f4",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "mozilla",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-10-17T18:05:58 | null | {"repository":{"description":"A clandestine operation to make AMO happy","homepage":"http://zamboni.readthedocs.org/en/latest/","watchers":373,"stargazers":373,"forks":188,"fork":false,"size":147435,"owner":"mozilla","private":false,"open_issues":24,"has_issues":true,"has_downloads":false,"has_wiki":false,"language":"Python","created_at":"2009-10-23T12:35:34-07:00","pushed_at":"2013-10-17T09:19:21-07:00","master_branch":"master","organization":"mozilla"},"actor_attributes":{"type":"User","name":"Christopher Van","company":"Mozilla","location":"Mountain View, CA","email":"[email protected]"},"url":"https://github.com/mozilla/zamboni/pull/1262#discussion_r7041202"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/mozilla/gaia-ui-tests/pulls/comments/5664311","id":5664311,"body":"Sorry about this. I thought I changed this before squashing the commits.","diff_hunk":"@@ -11,7 +11,7 @@\n class TestSmsWithAttachments(GaiaTestCase):\n \n def test_sms_send(self):\n- self.connect_to_network()\n+ self.data_layer.connect_to_cell_data()","path":"gaiatest/tests/messages/test_sms_with_attachments.py","position":5,"original_position":5,"commit_id":"b1f5f700d9122aa43b181fc37673fa5445236483","original_commit_id":"b1f5f700d9122aa43b181fc37673fa5445236483","user":{"login":"vaidik","id":542077,"avatar_url":"https://secure.gravatar.com/avatar/9f2a1db7d95b36b91c2b97dab2941cf6?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"9f2a1db7d95b36b91c2b97dab2941cf6","url":"https://api.github.com/users/vaidik","html_url":"https://github.com/vaidik","followers_url":"https://api.github.com/users/vaidik/followers","following_url":"https://api.github.com/users/vaidik/following{/other_user}","gists_url":"https://api.github.com/users/vaidik/gists{/gist_id}","starred_url":"https://api.github.com/users/vaidik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vaidik/subscriptions","organizations_url":"https://api.github.com/users/vaidik/orgs","repos_url":"https://api.github.com/users/vaidik/repos","events_url":"https://api.github.com/users/vaidik/events{/privacy}","received_events_url":"https://api.github.com/users/vaidik/received_events","type":"User"},"created_at":"2013-08-08T17:40:26Z","updated_at":"2013-08-08T17:40:26Z","html_url":"https://github.com/mozilla/gaia-ui-tests/pull/1218#discussion_r5664311","pull_request_url":"https://api.github.com/repos/mozilla/gaia-ui-tests/pulls/1218","_links":{"self":{"href":"https://api.github.com/repos/mozilla/gaia-ui-tests/pulls/comments/5664311"},"html":{"href":"https://github.com/mozilla/gaia-ui-tests/pull/1218#discussion_r5664311"},"pull_request":{"href":"https://api.github.com/repos/mozilla/gaia-ui-tests/pulls/1218"}}}} | {
"id": 6697439,
"name": "gaia-ui-tests",
"url": "https://github.com/mozilla/gaia-ui-tests"
} | {
"id": null,
"login": "vaidik",
"gravatar_id": "9f2a1db7d95b36b91c2b97dab2941cf6",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "mozilla",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-08-08T17:40:26 | null | {"repository":{"description":"UI tests for Gaia","watchers":13,"stargazers":13,"forks":64,"fork":false,"size":12889,"owner":"mozilla","private":false,"open_issues":71,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Python","created_at":"2012-11-14T16:41:29-08:00","pushed_at":"2013-08-08T10:19:10-07:00","master_branch":"master","organization":"mozilla"},"actor_attributes":{"type":"User","name":"Vaidik Kapoor","blog":"www.vaidikkapoor.info","location":"New Delhi, India","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/mozilla/gaia-ui-tests/pull/1218#discussion_r5664311"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/mozilla/fireplace/pulls/comments/5023550","id":5023550,"body":"check for `http:`, as we could have an image named `http.png`","diff_hunk":"@@ -0,0 +1,83 @@\n+var fs = require('fs'),\n+ path = require('path'),\n+ utils = require('./scripts/utils.js');\n+\n+blacklist = [\n+ 'require.js',\n+ 'settings_inferno.js',\n+ 'settings_local.js',\n+ 'settings_travis.js',\n+ 'stick.js',\n+ 'suggestions.js',\n+\n+ 'splash.styl.css',\n+ 'suggestions.styl.css',\n+]\n+\n+var assets_directory = 'hearth';\n+\n+function concatJS(includes, output_file) {\n+ var output = '';\n+ includes.forEach(function(include) {\n+ if (include.lastIndexOf('.js') === (include.length - 3)) {\n+ output += fs.readFileSync(__dirname + '/' + include, {encoding: 'utf-8'});\n+ } else {\n+ utils.globSync(include, '.js', function(err, results) {\n+ results.forEach(function(file) {\n+ if (blacklist.indexOf(path.basename(file)) === -1) {\n+ output += fs.readFileSync(__dirname + '/' + file, {encoding: 'utf-8'});\n+ }\n+ });\n+ });\n+ }\n+ });\n+ fs.writeFileSync(__dirname + '/' + output_file, output);\n+}\n+\n+function concatCSS(includes, output_file) {\n+ var output = '',\n+ match;\n+ var css_pattern = new RegExp('href=\"(/media/css/.+.styl.css)\"', 'g');\n+\n+ includes.forEach(function(include) {\n+ var include_path = [__dirname, '/', include].join('');\n+ if (include.lastIndexOf('.html') === (include.length - 5)) {\n+ while (match = css_pattern.exec(\n+ fs.readFileSync(include_path, {encoding: 'utf-8'}))) {\n+ if (blacklist.indexOf(path.basename(match[1])) === -1) {\n+ output += fs.readFileSync(assets_directory + match[1], {encoding: 'utf-8'});\n+ }\n+ }\n+ }\n+ });\n+\n+ var url_pattern = /url\\(([^)]+)\\)/g;\n+ output = output.replace(url_pattern, function(match, url, offset, string) {\n+ url = url.replace(/\"|'/g, '');\n+ if (url.indexOf('http') === 0 || match[1].indexOf('data:') !== -1) {","path":"build.js","position":57,"original_position":57,"commit_id":"62ddaedb8d856eb4b0b339cc1ff30ce0554dba55","original_commit_id":"62ddaedb8d856eb4b0b339cc1ff30ce0554dba55","user":{"login":"cvan","id":203725,"avatar_url":"https://secure.gravatar.com/avatar/47de0e6948b289c9b4b4be0d6d66c0f4?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"47de0e6948b289c9b4b4be0d6d66c0f4","url":"https://api.github.com/users/cvan","html_url":"https://github.com/cvan","followers_url":"https://api.github.com/users/cvan/followers","following_url":"https://api.github.com/users/cvan/following{/other_user}","gists_url":"https://api.github.com/users/cvan/gists{/gist_id}","starred_url":"https://api.github.com/users/cvan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cvan/subscriptions","organizations_url":"https://api.github.com/users/cvan/orgs","repos_url":"https://api.github.com/users/cvan/repos","events_url":"https://api.github.com/users/cvan/events{/privacy}","received_events_url":"https://api.github.com/users/cvan/received_events","type":"User"},"created_at":"2013-07-04T00:55:44Z","updated_at":"2013-07-04T00:55:44Z","html_url":"https://github.com/mozilla/fireplace/pull/210#discussion_r5023550","pull_request_url":"https://api.github.com/repos/mozilla/fireplace/pulls/210","_links":{"self":{"href":"https://api.github.com/repos/mozilla/fireplace/pulls/comments/5023550"},"html":{"href":"https://github.com/mozilla/fireplace/pull/210#discussion_r5023550"},"pull_request":{"href":"https://api.github.com/repos/mozilla/fireplace/pulls/210"}}}} | {
"id": 8046076,
"name": "fireplace",
"url": "https://github.com/mozilla/fireplace"
} | {
"id": null,
"login": "cvan",
"gravatar_id": "47de0e6948b289c9b4b4be0d6d66c0f4",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "mozilla",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-07-04T00:55:44 | null | {"repository":{"description":"Ignition, the Remix","homepage":"https://marketplace.firefox.com/","watchers":13,"stargazers":13,"forks":32,"fork":true,"size":3944,"owner":"mozilla","private":false,"open_issues":3,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"JavaScript","created_at":"2013-02-05T22:41:06-08:00","pushed_at":"2013-07-03T15:05:43-07:00","master_branch":"master","organization":"mozilla"},"actor_attributes":{"type":"User","name":"Christopher Van","company":"Mozilla","location":"Mountain View, CA","email":"[email protected]"},"url":"https://github.com/mozilla/fireplace/pull/210#discussion_r5023550"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/mozilla/webmaker-ui/pulls/comments/6867690","id":6867690,"diff_hunk":"@@ -13,18 +13,20 @@ define([ \"text!./webmaker-ui-fragments.html\" ], function(_fragments) {\n // URL redirector for language picker\n UI.langPicker = function(elem) {\n UI.select(elem, function(selectedLang) {\n- var href = document.location.pathname,\n+ var matchesLang,\n+ href = document.location.pathname,\n lang = document.querySelector(\"html\").lang,\n supportedLanguages = elem.getAttribute(\"data-supported\"),\n // matches any of these: \n // `en`, `en-us`, `en-US` or `ady` \n matches = href.match(/([a-z]{2,3})([-]([a-zA-Z]{2}))?/);\n+ matchesLang = matches && matches[2] ? matches[1].toLowerCase() + matches[2].toUpperCase() : matches[1].toLowerCase();","path":"ui.js","position":12,"original_position":12,"commit_id":"80f27219c3ff50c528748bc34ade76cc8254e8ed","original_commit_id":"80f27219c3ff50c528748bc34ade76cc8254e8ed","user":{"login":"humphd","id":427398,"avatar_url":"https://2.gravatar.com/avatar/467b6f36e2a9ba3f0ec119eddaab6a62?d=https%3A%2F%2Fidenticons.github.com%2F897892c787116ffd91afe1045542c4d4.png","gravatar_id":"467b6f36e2a9ba3f0ec119eddaab6a62","url":"https://api.github.com/users/humphd","html_url":"https://github.com/humphd","followers_url":"https://api.github.com/users/humphd/followers","following_url":"https://api.github.com/users/humphd/following{/other_user}","gists_url":"https://api.github.com/users/humphd/gists{/gist_id}","starred_url":"https://api.github.com/users/humphd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/humphd/subscriptions","organizations_url":"https://api.github.com/users/humphd/orgs","repos_url":"https://api.github.com/users/humphd/repos","events_url":"https://api.github.com/users/humphd/events{/privacy}","received_events_url":"https://api.github.com/users/humphd/received_events","type":"User","site_admin":false},"body":"`matches && matches.length > 2` might be better for this initial check.","created_at":"2013-10-09T19:34:31Z","updated_at":"2013-10-09T19:34:31Z","html_url":"https://github.com/mozilla/webmaker-ui/pull/5#discussion_r6867690","pull_request_url":"https://api.github.com/repos/mozilla/webmaker-ui/pulls/5","_links":{"self":{"href":"https://api.github.com/repos/mozilla/webmaker-ui/pulls/comments/6867690"},"html":{"href":"https://github.com/mozilla/webmaker-ui/pull/5#discussion_r6867690"},"pull_request":{"href":"https://api.github.com/repos/mozilla/webmaker-ui/pulls/5"}}}} | {
"id": 13037185,
"name": "webmaker-ui",
"url": "https://github.com/mozilla/webmaker-ui"
} | {
"id": null,
"login": "humphd",
"gravatar_id": "467b6f36e2a9ba3f0ec119eddaab6a62",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "mozilla",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-10-09T19:34:31 | null | {"repository":{"description":"Webmaker ui","homepage":"","watchers":0,"stargazers":0,"forks":1,"fork":false,"size":228,"owner":"mozilla","private":false,"open_issues":1,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"JavaScript","created_at":"2013-09-23T06:57:25-07:00","pushed_at":"2013-10-02T11:05:18-07:00","master_branch":"master","organization":"mozilla"},"actor_attributes":{"type":"User","name":"David Humphrey","blog":"http://vocamus.net/dave","location":"","email":"[email protected]"},"url":"https://github.com/mozilla/webmaker-ui/pull/5#discussion_r6867690"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/mozilla/webmaker.org/pulls/comments/7415870","id":7415870,"diff_hunk":"@@ -4,8 +4,11 @@ define(['jquery', '/bower/webmaker-ui/ui.js', 'sso-ux'],\n var lang = $('html').attr('lang');\n \n navigator.idSSO.app.onlogin = function(user) {\n+ var rdomain = document.referrer.split( \"\\/\" )[ 2 ];\n if( document.referrer.indexOf( 'events' ) !== -1 ){\n window.location = \"/\" + lang + \"/events\";\n+ } else if ( rdomain == \"localhost:7777\" || rdomain == \"webmaker.org\" || rdomain == \"makes.org\" ){\n+ window.location.replace( document.referrer );","path":"public/js/user/login.js","position":8,"original_position":8,"commit_id":"fddeff19a4e357e98b071d19d6136c572e56867b","original_commit_id":"fddeff19a4e357e98b071d19d6136c572e56867b","user":{"login":"jbuck","id":578466,"avatar_url":"https://0.gravatar.com/avatar/7fc0a83242c7c0d724124a7a0536ee38?d=https%3A%2F%2Fidenticons.github.com%2Fd461f4735fd7a82f2f5a4cbd1aa4996b.png&r=x","gravatar_id":"7fc0a83242c7c0d724124a7a0536ee38","url":"https://api.github.com/users/jbuck","html_url":"https://github.com/jbuck","followers_url":"https://api.github.com/users/jbuck/followers","following_url":"https://api.github.com/users/jbuck/following{/other_user}","gists_url":"https://api.github.com/users/jbuck/gists{/gist_id}","starred_url":"https://api.github.com/users/jbuck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbuck/subscriptions","organizations_url":"https://api.github.com/users/jbuck/orgs","repos_url":"https://api.github.com/users/jbuck/repos","events_url":"https://api.github.com/users/jbuck/events{/privacy}","received_events_url":"https://api.github.com/users/jbuck/received_events","type":"User","site_admin":false},"body":"I wonder if this should be a server-side redirect so that the server can verify which URLs it can redirect to? It's awfully annoying to have to hardcode these URLs","created_at":"2013-11-04T22:26:01Z","updated_at":"2013-11-04T22:26:01Z","html_url":"https://github.com/mozilla/webmaker.org/pull/476#discussion_r7415870","pull_request_url":"https://api.github.com/repos/mozilla/webmaker.org/pulls/476","_links":{"self":{"href":"https://api.github.com/repos/mozilla/webmaker.org/pulls/comments/7415870"},"html":{"href":"https://github.com/mozilla/webmaker.org/pull/476#discussion_r7415870"},"pull_request":{"href":"https://api.github.com/repos/mozilla/webmaker.org/pulls/476"}}}} | {
"id": 8780590,
"name": "webmaker.org",
"url": "https://github.com/mozilla/webmaker.org"
} | {
"id": null,
"login": "jbuck",
"gravatar_id": "7fc0a83242c7c0d724124a7a0536ee38",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "mozilla",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-11-04T22:26:01 | null | {"repository":{"description":"Where all the stuff gets made","homepage":"https://webmaker.org","watchers":13,"stargazers":13,"forks":32,"fork":false,"size":20459,"owner":"mozilla","private":false,"open_issues":58,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"JavaScript","created_at":"2013-03-14T10:01:22-07:00","pushed_at":"2013-11-04T07:44:34-08:00","master_branch":"master","organization":"mozilla"},"actor_attributes":{"type":"User","name":"Jon Buckley","company":"Mozilla Foundation","blog":"http://jbuckley.ca/","location":"Toronto, ON","email":"[email protected]"},"url":"https://github.com/mozilla/webmaker.org/pull/476#discussion_r7415870"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/mozilla/lumbergh/pulls/comments/6964947","id":6964947,"diff_hunk":"@@ -17,9 +16,9 @@\n differentListInit();\n knowBoxInit();\n testimonialsInit();\n+\tgalleryInit();","path":"careers/university/static/js/university.js","position":16,"original_position":16,"commit_id":"487a271027c0a53a8ba8b847369e1d500b94c79f","original_commit_id":"487a271027c0a53a8ba8b847369e1d500b94c79f","user":{"login":"alexgibson","id":400117,"avatar_url":"https://0.gravatar.com/avatar/36de55354bf2cfda4c8eafda6a33e0c4?d=https%3A%2F%2Fidenticons.github.com%2F6a4365c900c301ea693fb0a69eef7559.png","gravatar_id":"36de55354bf2cfda4c8eafda6a33e0c4","url":"https://api.github.com/users/alexgibson","html_url":"https://github.com/alexgibson","followers_url":"https://api.github.com/users/alexgibson/followers","following_url":"https://api.github.com/users/alexgibson/following{/other_user}","gists_url":"https://api.github.com/users/alexgibson/gists{/gist_id}","starred_url":"https://api.github.com/users/alexgibson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexgibson/subscriptions","organizations_url":"https://api.github.com/users/alexgibson/orgs","repos_url":"https://api.github.com/users/alexgibson/repos","events_url":"https://api.github.com/users/alexgibson/events{/privacy}","received_events_url":"https://api.github.com/users/alexgibson/received_events","type":"User","site_admin":false},"body":"Fix indentation (mixed tabs & spaces)","created_at":"2013-10-15T08:20:22Z","updated_at":"2013-10-15T08:20:22Z","html_url":"https://github.com/mozilla/lumbergh/pull/51#discussion_r6964947","pull_request_url":"https://api.github.com/repos/mozilla/lumbergh/pulls/51","_links":{"self":{"href":"https://api.github.com/repos/mozilla/lumbergh/pulls/comments/6964947"},"html":{"href":"https://github.com/mozilla/lumbergh/pull/51#discussion_r6964947"},"pull_request":{"href":"https://api.github.com/repos/mozilla/lumbergh/pulls/51"}}}} | {
"id": 2803877,
"name": "lumbergh",
"url": "https://github.com/mozilla/lumbergh"
} | {
"id": null,
"login": "alexgibson",
"gravatar_id": "36de55354bf2cfda4c8eafda6a33e0c4",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "mozilla",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-10-15T08:20:22 | null | {"repository":{"description":"Whaaaat's happening? Careers website... Mmmkay?","homepage":"http://careers.mozilla.org","watchers":7,"stargazers":7,"forks":14,"fork":false,"size":26397,"owner":"mozilla","private":false,"open_issues":6,"has_issues":true,"has_downloads":true,"has_wiki":false,"language":"Python","created_at":"2011-11-18T08:36:34-08:00","pushed_at":"2013-10-14T21:30:06-07:00","master_branch":"master","organization":"mozilla"},"actor_attributes":{"type":"User","name":"Alex Gibson","company":"Mozilla","blog":"http://alxgbsn.co.uk","location":"Newcastle upon Tyne, UK","email":"[email protected]"},"url":"https://github.com/mozilla/lumbergh/pull/51#discussion_r6964947"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/mozilla/mozmill-automation/pulls/comments/8155545","id":8155545,"diff_hunk":"@@ -86,3 +86,61 @@ def remove(self):\n \"\"\"Remove the repository from the local disk\"\"\"\n \n shutil.rmtree(self.path, True)\n+\n+class GitRepository(object):\n+ \"\"\"Class to work with a git repository\"\"\"\n+\n+ def __init__(self, url=None):\n+ self.command = \"git\"\n+ self.url = url","path":"mozmill_automation/repository.py","position":10,"original_position":10,"commit_id":"52b8c5395c11000337a289e29db057169c8193cc","original_commit_id":"52b8c5395c11000337a289e29db057169c8193cc","user":{"login":"whimboo","id":129603,"avatar_url":"https://2.gravatar.com/avatar/4ab832a8d5cae15967c0da59ebfb83f7?d=https%3A%2F%2Fidenticons.github.com%2F78ef38bdb7b437ec8f34474b5eeff469.png&r=x","gravatar_id":"4ab832a8d5cae15967c0da59ebfb83f7","url":"https://api.github.com/users/whimboo","html_url":"https://github.com/whimboo","followers_url":"https://api.github.com/users/whimboo/followers","following_url":"https://api.github.com/users/whimboo/following{/other_user}","gists_url":"https://api.github.com/users/whimboo/gists{/gist_id}","starred_url":"https://api.github.com/users/whimboo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whimboo/subscriptions","organizations_url":"https://api.github.com/users/whimboo/orgs","repos_url":"https://api.github.com/users/whimboo/repos","events_url":"https://api.github.com/users/whimboo/events{/privacy}","received_events_url":"https://api.github.com/users/whimboo/received_events","type":"User","site_admin":false},"body":"I like the addition of git repositories but we haven't done this so far because there was no easy to install package for git via pip/setuptools available. Has this been changed meanwhile? We cannot really rely on a possible installed system wide package via its own package manager.","created_at":"2013-12-06T08:08:53Z","updated_at":"2013-12-06T08:08:53Z","html_url":"https://github.com/mozilla/mozmill-automation/pull/112#discussion_r8155545","pull_request_url":"https://api.github.com/repos/mozilla/mozmill-automation/pulls/112","_links":{"self":{"href":"https://api.github.com/repos/mozilla/mozmill-automation/pulls/comments/8155545"},"html":{"href":"https://github.com/mozilla/mozmill-automation/pull/112#discussion_r8155545"},"pull_request":{"href":"https://api.github.com/repos/mozilla/mozmill-automation/pulls/112"}}}} | {
"id": 4324734,
"name": "mozmill-automation",
"url": "https://github.com/mozilla/mozmill-automation"
} | {
"id": null,
"login": "whimboo",
"gravatar_id": "4ab832a8d5cae15967c0da59ebfb83f7",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "mozilla",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-12-06T08:08:53 | null | {"repository":{"description":"Automation scripts for Mozmill test execution","watchers":5,"stargazers":5,"forks":16,"fork":false,"size":595,"owner":"mozilla","private":false,"open_issues":7,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Python","created_at":"2012-05-14T07:16:18-07:00","pushed_at":"2013-11-29T06:55:17-08:00","master_branch":"master","organization":"mozilla"},"actor_attributes":{"type":"User","name":"Henrik Skupin","company":"Mozilla","blog":"http://www.hskupin.info","email":"[email protected]"},"url":"https://github.com/mozilla/mozmill-automation/pull/112#discussion_r8155545"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/mozilla/mozillians/pulls/comments/4934060","id":4934060,"body":"Not much harm can be caused. We only have a for loop which can be gracefully skipped without curated groups. Given that we'll always have curated groups in our servers, this can be only visually wrong on local development sites. And it's an `if` less!","diff_hunk":"@@ -85,26 +85,28 @@\n {% endif %}\n {% if not people and not groups %}\n <div class=\"well\">\n- {% trans invite=url('invite'), query=form.cleaned_data.q %}\n- <p id=\"not-found\">\n+ <p id=\"not-found\">\n+ {% trans query=form.cleaned_data.q %}\n Sorry, we cannot find a group or person related to \"{{ query }}\".\n- </p>\n+ {% endtrans %}\n+ </p>\n+ {% if user.is_authenticated() %}\n <p>\n- Maybe they're not a Mozillian yet?\n- <a href=\"{{ invite }}\">Invite this person</a> to create a profile.\n+ {% trans invite=url('invite') %}\n+ Maybe they're not a Mozillian yet?\n+ <a href=\"{{ invite }}\">Invite this person</a> to create a profile.\n+ {% endtrans %}\n </p>\n- {% endtrans %}\n- {% if curated_groups %}","path":"apps/phonebook/templates/phonebook/search.html","position":84,"original_position":84,"commit_id":"c50a6086f1567180b87b088458f172f4d2af3d61","original_commit_id":"c50a6086f1567180b87b088458f172f4d2af3d61","user":{"login":"glogiotatidis","id":584352,"avatar_url":"https://secure.gravatar.com/avatar/7b74caf316a6c6716977fe84b56774c1?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"7b74caf316a6c6716977fe84b56774c1","url":"https://api.github.com/users/glogiotatidis","html_url":"https://github.com/glogiotatidis","followers_url":"https://api.github.com/users/glogiotatidis/followers","following_url":"https://api.github.com/users/glogiotatidis/following{/other_user}","gists_url":"https://api.github.com/users/glogiotatidis/gists{/gist_id}","starred_url":"https://api.github.com/users/glogiotatidis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glogiotatidis/subscriptions","organizations_url":"https://api.github.com/users/glogiotatidis/orgs","repos_url":"https://api.github.com/users/glogiotatidis/repos","events_url":"https://api.github.com/users/glogiotatidis/events{/privacy}","received_events_url":"https://api.github.com/users/glogiotatidis/received_events","type":"User"},"created_at":"2013-06-28T07:49:54Z","updated_at":"2013-06-28T07:49:54Z","html_url":"https://github.com/mozilla/mozillians/pull/528#discussion_r4934060","pull_request_url":"https://api.github.com/repos/mozilla/mozillians/pulls/528","_links":{"self":{"href":"https://api.github.com/repos/mozilla/mozillians/pulls/comments/4934060"},"html":{"href":"https://github.com/mozilla/mozillians/pull/528#discussion_r4934060"},"pull_request":{"href":"https://api.github.com/repos/mozilla/mozillians/pulls/528"}}}} | {
"id": 1799884,
"name": "mozillians",
"url": "https://github.com/mozilla/mozillians"
} | {
"id": null,
"login": "glogiotatidis",
"gravatar_id": "7b74caf316a6c6716977fe84b56774c1",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "mozilla",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-06-28T07:49:54 | null | {"repository":{"description":"Mozilla community directory -- A centralized directory of all Mozilla contributors!","homepage":"https://mozillians.org/","watchers":78,"stargazers":78,"forks":79,"fork":false,"size":864,"owner":"mozilla","private":false,"open_issues":1,"has_issues":false,"has_downloads":true,"has_wiki":false,"language":"Python","created_at":"2011-05-25T09:38:54-07:00","pushed_at":"2013-06-27T18:10:48-07:00","master_branch":"master","organization":"mozilla"},"actor_attributes":{"type":"User","name":"Giorgos Logiotatidis","company":"Mozilla","blog":"http://www.sealabs.net/seadog","location":"Athens, Greece","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/mozilla/mozillians/pull/528#discussion_r4934060"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/mozilla/funfactory/pulls/comments/6357350","id":6357350,"body":"I'm not. I liked what I had. I'm just following the review.","diff_hunk":"@@ -31,12 +34,19 @@ def __init__(self):\n \"loaded. Consider removing funfactory.middleware.\"\n \"LocaleURLMiddleware from your MIDDLEWARE_CLASSES setting.\")\n \n+ def _is_lang_change(self, request):\n+ \"\"\"Return True if the lang param is present and URL isn't exempt.\"\"\"\n+ if 'lang' not in request.GET:\n+ return False\n+\n+ return not any(request.path.endswith(url) for url in EXEMPT_URLS)","path":"funfactory/middleware.py","position":19,"original_position":19,"commit_id":"fd31ccc2c449054b25d0855861a1aa3149253913","original_commit_id":"fd31ccc2c449054b25d0855861a1aa3149253913","user":{"login":"pmclanahan","id":19934,"avatar_url":"https://0.gravatar.com/avatar/f0287ea2cfd2cefcc61d774dc118a278?d=https%3A%2F%2Fidenticons.github.com%2F18b56cded3b3905ae2b151d1c7fe54ce.png","gravatar_id":"f0287ea2cfd2cefcc61d774dc118a278","url":"https://api.github.com/users/pmclanahan","html_url":"https://github.com/pmclanahan","followers_url":"https://api.github.com/users/pmclanahan/followers","following_url":"https://api.github.com/users/pmclanahan/following{/other_user}","gists_url":"https://api.github.com/users/pmclanahan/gists{/gist_id}","starred_url":"https://api.github.com/users/pmclanahan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmclanahan/subscriptions","organizations_url":"https://api.github.com/users/pmclanahan/orgs","repos_url":"https://api.github.com/users/pmclanahan/repos","events_url":"https://api.github.com/users/pmclanahan/events{/privacy}","received_events_url":"https://api.github.com/users/pmclanahan/received_events","type":"User"},"created_at":"2013-09-13T19:58:33Z","updated_at":"2013-09-13T19:58:33Z","html_url":"https://github.com/mozilla/funfactory/pull/55#discussion_r6357350","pull_request_url":"https://api.github.com/repos/mozilla/funfactory/pulls/55","_links":{"self":{"href":"https://api.github.com/repos/mozilla/funfactory/pulls/comments/6357350"},"html":{"href":"https://github.com/mozilla/funfactory/pull/55#discussion_r6357350"},"pull_request":{"href":"https://api.github.com/repos/mozilla/funfactory/pulls/55"}}}} | {
"id": 2055934,
"name": "funfactory",
"url": "https://github.com/mozilla/funfactory"
} | {
"id": null,
"login": "pmclanahan",
"gravatar_id": "f0287ea2cfd2cefcc61d774dc118a278",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "mozilla",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-09-13T19:58:33 | null | {"repository":{"description":"The library to power Playdoh, Mozilla's Django template. File issues in playdoh:","homepage":"https://github.com/mozilla/playdoh","watchers":58,"stargazers":58,"forks":24,"fork":false,"size":265,"owner":"mozilla","private":false,"open_issues":4,"has_issues":false,"has_downloads":true,"has_wiki":false,"language":"Python","created_at":"2011-07-15T15:43:59-07:00","pushed_at":"2013-09-11T10:52:20-07:00","master_branch":"master","organization":"mozilla"},"actor_attributes":{"type":"User","name":"Paul McLanahan","company":"Mozilla","blog":"http://pmac.io","location":"Durham, NC, USA","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/mozilla/funfactory/pull/55#discussion_r6357350"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/mozilla/talkilla/pulls/comments/7610818","id":7610818,"diff_hunk":"@@ -27,6 +27,8 @@ var TalkillaSPA = (function() {\n _onServerEvent: function(type, event) {\n if (type === \"unauthorized\")\n this.port.post(\"reauth-needed\");\n+ else if (type === \"connected\")\n+ this.port.post(type, {email: this.email});","path":"static/js/spa/talkilla_spa.js","position":5,"original_position":5,"commit_id":"d5dad3a4bc9cf55e6939bed41ce76777cfe97f36","original_commit_id":"d5dad3a4bc9cf55e6939bed41ce76777cfe97f36","user":{"login":"Standard8","id":520844,"avatar_url":"https://0.gravatar.com/avatar/5ae84093298e3aa77dda526e060df7d3?d=https%3A%2F%2Fidenticons.github.com%2F867a03559e986ce383cc4d441f29f29e.png&r=x","gravatar_id":"5ae84093298e3aa77dda526e060df7d3","url":"https://api.github.com/users/Standard8","html_url":"https://github.com/Standard8","followers_url":"https://api.github.com/users/Standard8/followers","following_url":"https://api.github.com/users/Standard8/following{/other_user}","gists_url":"https://api.github.com/users/Standard8/gists{/gist_id}","starred_url":"https://api.github.com/users/Standard8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Standard8/subscriptions","organizations_url":"https://api.github.com/users/Standard8/orgs","repos_url":"https://api.github.com/users/Standard8/repos","events_url":"https://api.github.com/users/Standard8/events{/privacy}","received_events_url":"https://api.github.com/users/Standard8/received_events","type":"User","site_admin":false},"body":"This doesn't match the API which we currently agreed upon:\r\n\r\ndata: {\r\n addresses: [{type: \"pstn\", value: \"+33698234520\"},\r\n {type: \"email\", value: \"[email protected]\"}],\r\n capabilities: [\"call\"],\r\n settingURL: \"https://operator.com/settings\"\r\n }\r\n\r\nAlthough we don't support capabilities and settingURL atm, I think we should still support the addresses item with just the first item in the array for now.","created_at":"2013-11-12T22:58:38Z","updated_at":"2013-11-12T22:58:38Z","html_url":"https://github.com/mozilla/talkilla/pull/302#discussion_r7610818","pull_request_url":"https://api.github.com/repos/mozilla/talkilla/pulls/302","_links":{"self":{"href":"https://api.github.com/repos/mozilla/talkilla/pulls/comments/7610818"},"html":{"href":"https://github.com/mozilla/talkilla/pull/302#discussion_r7610818"},"pull_request":{"href":"https://api.github.com/repos/mozilla/talkilla/pulls/302"}}}} | {
"id": 8809222,
"name": "talkilla",
"url": "https://github.com/mozilla/talkilla"
} | {
"id": null,
"login": "Standard8",
"gravatar_id": "5ae84093298e3aa77dda526e060df7d3",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "mozilla",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-11-12T22:58:38 | null | {"repository":{"description":"Video call exploration","homepage":"https://wiki.mozilla.org/Talkilla","watchers":50,"stargazers":50,"forks":30,"fork":false,"size":7372,"owner":"mozilla","private":false,"open_issues":4,"has_issues":false,"has_downloads":true,"has_wiki":false,"language":"JavaScript","created_at":"2013-03-15T14:21:40-07:00","pushed_at":"2013-11-12T05:07:46-08:00","master_branch":"master","organization":"mozilla"},"actor_attributes":{"type":"User","name":"Mark Banner","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/mozilla/talkilla/pull/302#discussion_r7610818"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/mozilla/browserid/pulls/comments/4803402","id":4803402,"body":"I suppose we could check for navigator.mozId","diff_hunk":"@@ -33,16 +33,25 @@\n setTimeout(function() { cb(email); }, 0);\n };\n \n+ var ipServer = 'https://login.persona.org';\n+ if (navigator.userAgent ===\n+ \"Mozilla/5.0 (Mobile; rv:18.0) Gecko/18.0 Firefox/18.0\") {","path":"resources/static/authentication_api.js","position":6,"original_position":6,"commit_id":"34be8e53764f9e7b99ed92b6c5fe4d5958a28aed","original_commit_id":"34be8e53764f9e7b99ed92b6c5fe4d5958a28aed","user":{"login":"shane-tomlinson","id":848085,"avatar_url":"https://secure.gravatar.com/avatar/b7581393f6d1960ea7721789cbbe5c36?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"b7581393f6d1960ea7721789cbbe5c36","url":"https://api.github.com/users/shane-tomlinson","html_url":"https://github.com/shane-tomlinson","followers_url":"https://api.github.com/users/shane-tomlinson/followers","following_url":"https://api.github.com/users/shane-tomlinson/following{/other_user}","gists_url":"https://api.github.com/users/shane-tomlinson/gists{/gist_id}","starred_url":"https://api.github.com/users/shane-tomlinson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shane-tomlinson/subscriptions","organizations_url":"https://api.github.com/users/shane-tomlinson/orgs","repos_url":"https://api.github.com/users/shane-tomlinson/repos","events_url":"https://api.github.com/users/shane-tomlinson/events{/privacy}","received_events_url":"https://api.github.com/users/shane-tomlinson/received_events","type":"User"},"created_at":"2013-06-20T18:14:34Z","updated_at":"2013-06-20T18:14:34Z","html_url":"https://github.com/mozilla/browserid/pull/3567#discussion_r4803402","pull_request_url":"https://api.github.com/repos/mozilla/browserid/pulls/3567","_links":{"self":{"href":"https://api.github.com/repos/mozilla/browserid/pulls/comments/4803402"},"html":{"href":"https://github.com/mozilla/browserid/pull/3567#discussion_r4803402"},"pull_request":{"href":"https://api.github.com/repos/mozilla/browserid/pulls/3567"}}}} | {
"id": 1578548,
"name": "browserid",
"url": "https://github.com/mozilla/browserid"
} | {
"id": null,
"login": "shane-tomlinson",
"gravatar_id": "b7581393f6d1960ea7721789cbbe5c36",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "mozilla",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-06-20T18:14:34 | null | {"repository":{"description":"Persona is a secure, distributed, and easy to use identification system.","homepage":"https://login.persona.org","watchers":1350,"stargazers":1350,"forks":159,"fork":false,"size":2812,"owner":"mozilla","private":false,"open_issues":441,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"JavaScript","created_at":"2011-04-06T11:28:20-07:00","pushed_at":"2013-06-20T04:37:45-07:00","master_branch":"dev","organization":"mozilla"},"actor_attributes":{"type":"User","name":"Shane Tomlinson","company":"Mozilla","blog":"https://shanetomlinson.com","location":"London, UK","email":"[email protected]"},"url":"https://github.com/mozilla/browserid/pull/3567#discussion_r4803402"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/mozilla/mozmill-ci/pulls/comments/5910309","id":5910309,"body":"I'm not sure we want this change, and if we do it should be in a separate PR","diff_hunk":"@@ -943,5 +1063,5 @@ index 5ad3a45..84a8183 100644\n <defaultSuffix>@mozilla.com</defaultSuffix>\n + <hudsonUrl>http://mm-ci-master.qa.scl3.mozilla.com:8080/</hudsonUrl>\n <adminAddress>[email protected]</adminAddress>\n- <smtpHost>smtp.mozilla.com</smtpHost>\n- <useSsl>true</useSsl>\n+ <smtpHost>smtp.mozilla.org</smtpHost>","path":"config/production/jenkins.patch","position":162,"original_position":162,"commit_id":"097b7bddacc764c2bfdd366569ef9a417e5173fb","original_commit_id":"097b7bddacc764c2bfdd366569ef9a417e5173fb","user":{"login":"davehunt","id":122800,"avatar_url":"https://1.gravatar.com/avatar/fd74178aadc963ffc6397ad1e22d8ce7?d=https%3A%2F%2Fidenticons.github.com%2F40947268c085716bd36a68d080755d7f.png","gravatar_id":"fd74178aadc963ffc6397ad1e22d8ce7","url":"https://api.github.com/users/davehunt","html_url":"https://github.com/davehunt","followers_url":"https://api.github.com/users/davehunt/followers","following_url":"https://api.github.com/users/davehunt/following{/other_user}","gists_url":"https://api.github.com/users/davehunt/gists{/gist_id}","starred_url":"https://api.github.com/users/davehunt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davehunt/subscriptions","organizations_url":"https://api.github.com/users/davehunt/orgs","repos_url":"https://api.github.com/users/davehunt/repos","events_url":"https://api.github.com/users/davehunt/events{/privacy}","received_events_url":"https://api.github.com/users/davehunt/received_events","type":"User"},"created_at":"2013-08-21T21:45:20Z","updated_at":"2013-08-21T21:45:20Z","html_url":"https://github.com/mozilla/mozmill-ci/pull/262#discussion_r5910309","pull_request_url":"https://api.github.com/repos/mozilla/mozmill-ci/pulls/262","_links":{"self":{"href":"https://api.github.com/repos/mozilla/mozmill-ci/pulls/comments/5910309"},"html":{"href":"https://github.com/mozilla/mozmill-ci/pull/262#discussion_r5910309"},"pull_request":{"href":"https://api.github.com/repos/mozilla/mozmill-ci/pulls/262"}}}} | {
"id": 3037564,
"name": "mozmill-ci",
"url": "https://github.com/mozilla/mozmill-ci"
} | {
"id": null,
"login": "davehunt",
"gravatar_id": "fd74178aadc963ffc6397ad1e22d8ce7",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "mozilla",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-08-21T21:45:20 | null | {"repository":{"description":"Mozmill test-runs driven by Pulse and Jenkins","homepage":"https://wiki.mozilla.org/Auto-tools/Automation_Development/Projects/Mozmill_Automation/Mozmill_CI","watchers":8,"stargazers":8,"forks":8,"fork":false,"size":50854,"owner":"mozilla","private":false,"open_issues":46,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Python","created_at":"2011-12-22T16:33:51-08:00","pushed_at":"2013-08-19T12:20:43-07:00","master_branch":"master","organization":"mozilla"},"actor_attributes":{"type":"User","name":"Dave Hunt","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/mozilla/mozmill-ci/pull/262#discussion_r5910309"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/mozilla/zamboni/pulls/comments/8052304","id":8052304,"diff_hunk":"@@ -81,6 +81,36 @@ The ``REDIS_BACKEND`` is parsed like ``CACHE_BACKEND`` if you need something\n other than the default settings.\n \n \n+-------\n+Node.js\n+-------\n+\n+`Node.js <http://nodejs.org/>`_ is needed for Stylus and LESS, which in turn\n+are needed to precompile the CSS files.\n+\n+If you want to serve the CSS files from another domain than the webserver, you\n+will need to precompile them. Otherwise you can have them compiled on the fly,\n+using javascript in your browser, if you set ``LESS_PREPROCESS = False`` in","path":"docs/topics/install-zamboni/advanced-installation.rst","position":13,"original_position":13,"commit_id":"fe28a97661d2fcf11965957a599570174dd34891","original_commit_id":"e21868171fe46895e1b9df1b0e049ee40ab582d2","user":{"login":"cvan","id":203725,"avatar_url":"https://0.gravatar.com/avatar/47de0e6948b289c9b4b4be0d6d66c0f4?d=https%3A%2F%2Fidenticons.github.com%2Fe8d88d4bdf0c8bb9968e62c64a9d8df1.png&r=x","gravatar_id":"47de0e6948b289c9b4b4be0d6d66c0f4","url":"https://api.github.com/users/cvan","html_url":"https://github.com/cvan","followers_url":"https://api.github.com/users/cvan/followers","following_url":"https://api.github.com/users/cvan/following{/other_user}","gists_url":"https://api.github.com/users/cvan/gists{/gist_id}","starred_url":"https://api.github.com/users/cvan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cvan/subscriptions","organizations_url":"https://api.github.com/users/cvan/orgs","repos_url":"https://api.github.com/users/cvan/repos","events_url":"https://api.github.com/users/cvan/events{/privacy}","received_events_url":"https://api.github.com/users/cvan/received_events","type":"User","site_admin":false},"body":"yeah, don't worry about it. we'll/I'll fix it in `jingo-minify` later.","created_at":"2013-12-03T07:29:58Z","updated_at":"2013-12-03T07:29:58Z","html_url":"https://github.com/mozilla/zamboni/pull/1464#discussion_r8052304","pull_request_url":"https://api.github.com/repos/mozilla/zamboni/pulls/1464","_links":{"self":{"href":"https://api.github.com/repos/mozilla/zamboni/pulls/comments/8052304"},"html":{"href":"https://github.com/mozilla/zamboni/pull/1464#discussion_r8052304"},"pull_request":{"href":"https://api.github.com/repos/mozilla/zamboni/pulls/1464"}}}} | {
"id": 347655,
"name": "zamboni",
"url": "https://github.com/mozilla/zamboni"
} | {
"id": null,
"login": "cvan",
"gravatar_id": "47de0e6948b289c9b4b4be0d6d66c0f4",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "mozilla",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-12-03T07:29:58 | null | {"repository":{"description":"The Firefox Marketplace and addons.mozilla.org","homepage":"http://zamboni.readthedocs.org/en/latest/","watchers":382,"stargazers":382,"forks":198,"fork":false,"size":187310,"owner":"mozilla","private":false,"open_issues":27,"has_issues":true,"has_downloads":false,"has_wiki":false,"language":"Python","created_at":"2009-10-23T12:35:34-07:00","pushed_at":"2013-12-02T19:10:59-08:00","master_branch":"master","organization":"mozilla"},"actor_attributes":{"type":"User","name":"Christopher Van","company":"Mozilla","location":"Mountain View, CA","email":"[email protected]"},"url":"https://github.com/mozilla/zamboni/pull/1464#discussion_r8052304"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/mozilla/fjord/pulls/comments/8061854","id":8061854,"diff_hunk":"@@ -95,34 +95,40 @@\n \n <div class=\"clearfix\"></div>\n \n- <div class=\"container\">\n- <h3>Bigrams</h3>\n- </div>\n+ {% if first_facet_bi or second_facet_bi %}\n+ <div id=\"permalink\">\n+ <h3>Permalink for this report</h3>\n+ <input type=\"text\" value=\"{{ permalink }}\" />","path":"fjord/analytics/templates/analytics/analytics_occurrences_comparison.html","position":42,"original_position":42,"commit_id":"137561dd997c92d0bc480259d915c62ae625e4f1","original_commit_id":"137561dd997c92d0bc480259d915c62ae625e4f1","user":{"login":"rlr","id":36629,"avatar_url":"https://1.gravatar.com/avatar/00e30f0c3219349c80f3ff7aacc9d34a?d=https%3A%2F%2Fidenticons.github.com%2Faa5d5b1b36318c95dffe1d6c4e153f2d.png&r=x","gravatar_id":"00e30f0c3219349c80f3ff7aacc9d34a","url":"https://api.github.com/users/rlr","html_url":"https://github.com/rlr","followers_url":"https://api.github.com/users/rlr/followers","following_url":"https://api.github.com/users/rlr/following{/other_user}","gists_url":"https://api.github.com/users/rlr/gists{/gist_id}","starred_url":"https://api.github.com/users/rlr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rlr/subscriptions","organizations_url":"https://api.github.com/users/rlr/orgs","repos_url":"https://api.github.com/users/rlr/repos","events_url":"https://api.github.com/users/rlr/events{/privacy}","received_events_url":"https://api.github.com/users/rlr/received_events","type":"User","site_admin":false},"body":"You can add `readonly` attribute to this... if you want.","created_at":"2013-12-03T15:04:31Z","updated_at":"2013-12-03T15:04:31Z","html_url":"https://github.com/mozilla/fjord/pull/181#discussion_r8061854","pull_request_url":"https://api.github.com/repos/mozilla/fjord/pulls/181","_links":{"self":{"href":"https://api.github.com/repos/mozilla/fjord/pulls/comments/8061854"},"html":{"href":"https://github.com/mozilla/fjord/pull/181#discussion_r8061854"},"pull_request":{"href":"https://api.github.com/repos/mozilla/fjord/pulls/181"}}}} | {
"id": 5197539,
"name": "fjord",
"url": "https://github.com/mozilla/fjord"
} | {
"id": null,
"login": "rlr",
"gravatar_id": "00e30f0c3219349c80f3ff7aacc9d34a",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "mozilla",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-12-03T15:04:31 | null | {"repository":{"description":"Software that runs the new input.mozilla.org","watchers":10,"stargazers":10,"forks":18,"fork":false,"size":9032,"owner":"mozilla","private":false,"open_issues":1,"has_issues":false,"has_downloads":true,"has_wiki":false,"language":"Python","created_at":"2012-07-26T14:25:00-07:00","pushed_at":"2013-11-27T08:22:40-08:00","master_branch":"master","organization":"mozilla"},"actor_attributes":{"type":"User","name":"ricky rosario","company":"Mozilla","blog":"http://rickyrosario.com","location":"south florida","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/mozilla/fjord/pull/181#discussion_r8061854"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/mozilla/zamboni/pulls/comments/4749865","id":4749865,"body":"Thanks Rob, this feature might be being pulled but I'll be sure to update if it's going to land. Cheers for the heads-up.","diff_hunk":"@@ -0,0 +1,5 @@\n+ALTER TABLE prices ADD COLUMN method int(11) UNSIGNED NOT NULL;\n+/* Make everything all payment methods */\n+UPDATE prices SET method = 2;\n+/* Make micro payment tiers < 0.99 carrier only */\n+UPDATE prices SET method = 0 WHERE price < '0.99' and price > '0.00';","path":"migrations/615-add-method-to-tiers.sql","position":5,"original_position":5,"commit_id":"49b90eed16ba9adb6538b3c62fe77c07b7b64f8f","original_commit_id":"49b90eed16ba9adb6538b3c62fe77c07b7b64f8f","user":{"login":"muffinresearch","id":1514,"avatar_url":"https://secure.gravatar.com/avatar/86cf2c38bd61ffc99251cbd5d6ec2dfd?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"86cf2c38bd61ffc99251cbd5d6ec2dfd","url":"https://api.github.com/users/muffinresearch","html_url":"https://github.com/muffinresearch","followers_url":"https://api.github.com/users/muffinresearch/followers","following_url":"https://api.github.com/users/muffinresearch/following{/other_user}","gists_url":"https://api.github.com/users/muffinresearch/gists{/gist_id}","starred_url":"https://api.github.com/users/muffinresearch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/muffinresearch/subscriptions","organizations_url":"https://api.github.com/users/muffinresearch/orgs","repos_url":"https://api.github.com/users/muffinresearch/repos","events_url":"https://api.github.com/users/muffinresearch/events{/privacy}","received_events_url":"https://api.github.com/users/muffinresearch/received_events","type":"User"},"created_at":"2013-06-18T14:55:13Z","updated_at":"2013-06-18T14:55:13Z","html_url":"https://github.com/mozilla/zamboni/pull/811#discussion_r4749865","pull_request_url":"https://api.github.com/repos/mozilla/zamboni/pulls/811","_links":{"self":{"href":"https://api.github.com/repos/mozilla/zamboni/pulls/comments/4749865"},"html":{"href":"https://github.com/mozilla/zamboni/pull/811#discussion_r4749865"},"pull_request":{"href":"https://api.github.com/repos/mozilla/zamboni/pulls/811"}}}} | {
"id": 347655,
"name": "zamboni",
"url": "https://github.com/mozilla/zamboni"
} | {
"id": null,
"login": "muffinresearch",
"gravatar_id": "86cf2c38bd61ffc99251cbd5d6ec2dfd",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "mozilla",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-06-18T14:55:13 | null | {"repository":{"description":"A clandestine operation to make AMO happy","homepage":"http://zamboni.readthedocs.org/en/latest/","watchers":355,"stargazers":355,"forks":149,"fork":false,"size":30108,"owner":"mozilla","private":false,"open_issues":18,"has_issues":true,"has_downloads":false,"has_wiki":false,"language":"Python","created_at":"2009-10-23T12:35:34-07:00","pushed_at":"2013-06-18T03:34:57-07:00","master_branch":"master","organization":"mozilla"},"actor_attributes":{"type":"User","name":"Stuart Colville","company":"Mozilla","blog":"http://muffinresearch.co.uk/","location":"United Kingdom","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/mozilla/zamboni/pull/811#discussion_r4749865"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/mozilla/gaia-ui-tests/pulls/comments/3873579","id":3873579,"body":"As mentioned in a previous comment, we are elsewhere assuming that there are no favourites. We should make this explicit and use zero instead of the `initial_favorite_count`","diff_hunk":"@@ -31,32 +28,22 @@ def test_add_to_favorite(self):\n self.wait_for_condition(lambda m: self.data_layer.is_fm_radio_enabled)\n \n # save the initial count of favorite stations\n- initial_favorite_count = len(self.marionette.find_elements(*self._favorite_list_locator))\n-\n- # save the current frequency\n- current_frequency = float(self.marionette.find_element(*self._frequency_display_locator).text)\n+ initial_favorite_count = len(self.fm_radio.favorite_channels)","path":"gaiatest/tests/fmradio/test_fmradio_add_to_favorite.py","position":32,"original_position":32,"commit_id":"8cf9578b5243164ac5f55a923c07643afaf79603","original_commit_id":"8cf9578b5243164ac5f55a923c07643afaf79603","user":{"login":"davehunt","id":122800,"avatar_url":"https://secure.gravatar.com/avatar/fd74178aadc963ffc6397ad1e22d8ce7?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"fd74178aadc963ffc6397ad1e22d8ce7","url":"https://api.github.com/users/davehunt","html_url":"https://github.com/davehunt","followers_url":"https://api.github.com/users/davehunt/followers","following_url":"https://api.github.com/users/davehunt/following","gists_url":"https://api.github.com/users/davehunt/gists{/gist_id}","starred_url":"https://api.github.com/users/davehunt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davehunt/subscriptions","organizations_url":"https://api.github.com/users/davehunt/orgs","repos_url":"https://api.github.com/users/davehunt/repos","events_url":"https://api.github.com/users/davehunt/events{/privacy}","received_events_url":"https://api.github.com/users/davehunt/received_events","type":"User"},"created_at":"2013-04-19T13:43:47Z","updated_at":"2013-04-19T13:43:47Z","html_url":"https://github.com/mozilla/gaia-ui-tests/pull/697#discussion_r3873579","pull_request_url":"https://api.github.com/repos/mozilla/gaia-ui-tests/pulls/697","_links":{"self":{"href":"https://api.github.com/repos/mozilla/gaia-ui-tests/pulls/comments/3873579"},"html":{"href":"https://github.com/mozilla/gaia-ui-tests/pull/697#discussion_r3873579"},"pull_request":{"href":"https://api.github.com/repos/mozilla/gaia-ui-tests/pulls/697"}}}} | {
"id": 6697439,
"name": "gaia-ui-tests",
"url": "https://github.com/mozilla/gaia-ui-tests"
} | {
"id": null,
"login": "davehunt",
"gravatar_id": "fd74178aadc963ffc6397ad1e22d8ce7",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "mozilla",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-04-19T13:43:47 | null | {"repository":{"description":"UI tests for Gaia","watchers":7,"stargazers":7,"forks":59,"fork":false,"size":2340,"owner":"mozilla","private":false,"open_issues":81,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Python","created_at":"2012-11-14T16:41:29-08:00","pushed_at":"2013-04-19T05:42:43-07:00","master_branch":"master","organization":"mozilla"},"actor_attributes":{"type":"User","name":"Dave Hunt","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/mozilla/gaia-ui-tests/pull/697#discussion_r3873579"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/mozilla/addon-sdk/pulls/comments/7106882","id":7106882,"diff_hunk":"@@ -85,10 +125,14 @@ Buffer.concat = function(list, length) {\n \n // Node buffer is very much like Uint8Array although it has bunch of methods\n // that typically can be used in combination with `DataView` while preserving\n-// access by index. Since in SDK echo module has it's own set of bult-ins it\n+// access by index. Since in SDK each module has it's own set of bult-ins it\n // ok to patch ours to make it nodejs Buffer compatible.\n Buffer.prototype = Uint8Array.prototype;\n Object.defineProperties(Buffer.prototype, {\n+ parent: {","path":"lib/sdk/io/buffer.js","position":116,"original_position":103,"commit_id":"e3f238369c26c71efd8518ff4acd9f29f0ca37c5","original_commit_id":"d6d4cc33433eec639de94ecd7ddf9e9ca6bae989","user":{"login":"Gozala","id":21236,"avatar_url":"https://1.gravatar.com/avatar/9289db62d5c34afb4f277a5215e05c83?d=https%3A%2F%2Fidenticons.github.com%2Fc35624e2cceae64a8589f7aa04c411b2.png","gravatar_id":"9289db62d5c34afb4f277a5215e05c83","url":"https://api.github.com/users/Gozala","html_url":"https://github.com/Gozala","followers_url":"https://api.github.com/users/Gozala/followers","following_url":"https://api.github.com/users/Gozala/following{/other_user}","gists_url":"https://api.github.com/users/Gozala/gists{/gist_id}","starred_url":"https://api.github.com/users/Gozala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gozala/subscriptions","organizations_url":"https://api.github.com/users/Gozala/orgs","repos_url":"https://api.github.com/users/Gozala/repos","events_url":"https://api.github.com/users/Gozala/events{/privacy}","received_events_url":"https://api.github.com/users/Gozala/received_events","type":"User","site_admin":false},"body":"I'm not yet sure why modifying this property is needed, but access in weak maps is significantly slower than a property access, so I'd suggest using plain property here.","created_at":"2013-10-21T20:23:59Z","updated_at":"2013-10-21T20:23:59Z","html_url":"https://github.com/mozilla/addon-sdk/pull/1252#discussion_r7106882","pull_request_url":"https://api.github.com/repos/mozilla/addon-sdk/pulls/1252","_links":{"self":{"href":"https://api.github.com/repos/mozilla/addon-sdk/pulls/comments/7106882"},"html":{"href":"https://github.com/mozilla/addon-sdk/pull/1252#discussion_r7106882"},"pull_request":{"href":"https://api.github.com/repos/mozilla/addon-sdk/pulls/1252"}}}} | {
"id": 748030,
"name": "addon-sdk",
"url": "https://github.com/mozilla/addon-sdk"
} | {
"id": null,
"login": "Gozala",
"gravatar_id": "9289db62d5c34afb4f277a5215e05c83",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "mozilla",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-10-21T20:23:59 | null | {"repository":{"description":"The Add-on SDK repository.","homepage":"https://wiki.mozilla.org/Labs/Jetpack","watchers":331,"stargazers":331,"forks":158,"fork":false,"size":35085,"owner":"mozilla","private":false,"open_issues":0,"has_issues":false,"has_downloads":true,"has_wiki":true,"language":"JavaScript","created_at":"2010-06-29T17:38:20-07:00","pushed_at":"2013-10-21T01:45:28-07:00","master_branch":"master","organization":"mozilla"},"actor_attributes":{"type":"User","name":"Irakli Gozalishvili","company":"Mozilla","blog":"http://jeditoolkit.com/","location":"San Francisco, USA","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/mozilla/addon-sdk/pull/1252#discussion_r7106882"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/mozilla/rust/pulls/comments/6645304","id":6645304,"body":"It's intended to clearly introduce the purpose of them before getting into the jargon. I had the same examples there before, but apparently no one got to reading them.","diff_hunk":"@@ -923,22 +923,57 @@ custom destructors.\n \n # Boxes\n \n-Many modern languages represent values as pointers to heap memory by\n-default. In contrast, Rust, like C and C++, represents such types directly.\n-Another way to say this is that aggregate data in Rust are *unboxed*. This\n-means that if you `let x = Point { x: 1f, y: 1f };`, you are creating a struct\n-on the stack. If you then copy it into a data structure, you copy the entire\n-struct, not just a pointer.\n+A value in Rust is stored directly inside the owner. If a `struct` contains\n+four `int` fields, it will be four times as large as a single `int`. The\n+following `struct` type is invalid, as it would have an infinite size:\n \n-For small structs like `Point`, this is usually more efficient than allocating\n-memory and indirecting through a pointer. But for big structs, or mutable\n-state, it can be useful to have a single copy on the stack or on the heap, and\n-refer to that through a pointer.\n+~~~~ {.xfail-test}\n+struct List {\n+ next: Option<List>,\n+ data: int\n+}\n+~~~~\n+\n+> ***Note:*** The `Option` type is an enum representing an *optional* value.\n+> It's comparable to a nullable pointer in many other languages, but stores the\n+> contained value unboxed.\n+\n+An *owned box* (`~`) uses a heap allocation to provide the invariant of always","path":"doc/tutorial.md","position":29,"original_position":29,"commit_id":"b4fe31629772f4661e683f120c9f3e1185309c82","original_commit_id":"b4fe31629772f4661e683f120c9f3e1185309c82","user":{"login":"thestinger","id":1505226,"avatar_url":"https://0.gravatar.com/avatar/0d3dda58e2ef5ba8dc98f5e46997262c?d=https%3A%2F%2Fidenticons.github.com%2F4a10d28bce2b86baf1f35702c4d05c3a.png","gravatar_id":"0d3dda58e2ef5ba8dc98f5e46997262c","url":"https://api.github.com/users/thestinger","html_url":"https://github.com/thestinger","followers_url":"https://api.github.com/users/thestinger/followers","following_url":"https://api.github.com/users/thestinger/following{/other_user}","gists_url":"https://api.github.com/users/thestinger/gists{/gist_id}","starred_url":"https://api.github.com/users/thestinger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thestinger/subscriptions","organizations_url":"https://api.github.com/users/thestinger/orgs","repos_url":"https://api.github.com/users/thestinger/repos","events_url":"https://api.github.com/users/thestinger/events{/privacy}","received_events_url":"https://api.github.com/users/thestinger/received_events","type":"User"},"created_at":"2013-09-28T20:45:56Z","updated_at":"2013-09-28T20:45:56Z","html_url":"https://github.com/mozilla/rust/pull/9589#discussion_r6645304","pull_request_url":"https://api.github.com/repos/mozilla/rust/pulls/9589","_links":{"self":{"href":"https://api.github.com/repos/mozilla/rust/pulls/comments/6645304"},"html":{"href":"https://github.com/mozilla/rust/pull/9589#discussion_r6645304"},"pull_request":{"href":"https://api.github.com/repos/mozilla/rust/pulls/9589"}}}} | {
"id": 724712,
"name": "rust",
"url": "https://github.com/mozilla/rust"
} | {
"id": null,
"login": "thestinger",
"gravatar_id": "0d3dda58e2ef5ba8dc98f5e46997262c",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "mozilla",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-09-28T20:45:56 | null | {"repository":{"description":"a safe, concurrent, practical language","homepage":"http://www.rust-lang.org","watchers":3130,"stargazers":3130,"forks":626,"fork":false,"size":174179,"owner":"mozilla","private":false,"open_issues":1375,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Rust","created_at":"2010-06-16T13:39:03-07:00","pushed_at":"2013-09-28T12:46:04-07:00","integrate_branch":"master","master_branch":"master","organization":"mozilla"},"actor_attributes":{"type":"User","name":"Daniel Micay","location":"Toronto, Ontario, Canada","email":"[email protected]"},"url":"https://github.com/mozilla/rust/pull/9589#discussion_r6645304"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/mozilla/django-browserid/pulls/comments/4395348","id":4395348,"body":"Ah, it's not dispatch's fault, it's the tests above.\r\n\r\nEarlier in the file, we reload the `views` module: https://github.com/mozilla/django-browserid/blob/1b968fd77ae38bacdb7d384b9b9d7e3031459d4d/django_browserid/tests/test_views.py#L36\r\n\r\nBecause `MyVerifyClass` is defined when the test module is first loaded, it uses an old version of the `Verify` class. By the time the new tests run, it has been replaced, and the code things they're different classes (if you run `id()` on both of the class objects they indeed return different ids).\r\n\r\nThe reloading of `views` is a bit of a hack anyway. We can fix this by making `failure_url` and `success_url` on the class into properties that pull from the settings instead of attributes that pull at definition time. Then, remove the reloading from `test_views.py`, replace `BaseFormView` with `Verify` again, and BAM. Working tests with less hackery.","diff_hunk":"@@ -142,4 +142,4 @@ def get_failure_url(self):\n def dispatch(self, request, *args, **kwargs):\n \"\"\"Run some sanity checks on the request prior to dispatching it.\"\"\"\n sanity_checks(request)\n- return super(Verify, self).dispatch(request, *args, **kwargs)\n+ return super(BaseFormView, self).dispatch(request, *args, **kwargs)","path":"django_browserid/views.py","position":5,"original_position":5,"commit_id":"9e9aa596728cc113edcbde7ac650e3515c76c0da","original_commit_id":"9e9aa596728cc113edcbde7ac650e3515c76c0da","user":{"login":"Osmose","id":193106,"avatar_url":"https://secure.gravatar.com/avatar/817d3482f5d376f7665718496ad7e3c6?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"817d3482f5d376f7665718496ad7e3c6","url":"https://api.github.com/users/Osmose","html_url":"https://github.com/Osmose","followers_url":"https://api.github.com/users/Osmose/followers","following_url":"https://api.github.com/users/Osmose/following{/other_user}","gists_url":"https://api.github.com/users/Osmose/gists{/gist_id}","starred_url":"https://api.github.com/users/Osmose/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Osmose/subscriptions","organizations_url":"https://api.github.com/users/Osmose/orgs","repos_url":"https://api.github.com/users/Osmose/repos","events_url":"https://api.github.com/users/Osmose/events{/privacy}","received_events_url":"https://api.github.com/users/Osmose/received_events","type":"User"},"created_at":"2013-05-26T22:47:51Z","updated_at":"2013-05-26T22:47:51Z","html_url":"https://github.com/mozilla/django-browserid/pull/169#discussion_r4395348","pull_request_url":"https://api.github.com/repos/mozilla/django-browserid/pulls/169","_links":{"self":{"href":"https://api.github.com/repos/mozilla/django-browserid/pulls/comments/4395348"},"html":{"href":"https://github.com/mozilla/django-browserid/pull/169#discussion_r4395348"},"pull_request":{"href":"https://api.github.com/repos/mozilla/django-browserid/pulls/169"}}}} | {
"id": 2074787,
"name": "django-browserid",
"url": "https://github.com/mozilla/django-browserid"
} | {
"id": null,
"login": "Osmose",
"gravatar_id": "817d3482f5d376f7665718496ad7e3c6",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "mozilla",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-05-26T22:47:51 | null | {"repository":{"description":"Django application for adding BrowserID support.","homepage":"","watchers":134,"stargazers":134,"forks":55,"fork":false,"size":320,"owner":"mozilla","private":false,"open_issues":16,"has_issues":true,"has_downloads":true,"has_wiki":false,"language":"Python","created_at":"2011-07-19T14:55:24-07:00","pushed_at":"2013-05-14T09:27:21-07:00","master_branch":"master","organization":"mozilla"},"actor_attributes":{"type":"User","name":"Michael Kelly","company":"Mozilla","blog":"http://mkelly.me/","location":"Melbourne, FL","email":"[email protected]"},"url":"https://github.com/mozilla/django-browserid/pull/169#discussion_r4395348"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/mozilla/Addon-Tests/pulls/comments/8264152","id":8264152,"diff_hunk":"@@ -168,6 +168,7 @@ def site_navigation_menus(self):\n return [HeaderMenu(self.testsetup, web_element) for web_element in self.selenium.find_elements(*self._site_navigation_menus_locator)]\n \n def click_complete_themes(self):\n+ self.selenium.maximize_window()","path":"pages/desktop/base.py","position":4,"original_position":4,"commit_id":"268484e31510c34cde649a92177cbe061a5b23c6","original_commit_id":"268484e31510c34cde649a92177cbe061a5b23c6","user":{"login":"AlinT","id":1001470,"avatar_url":"https://1.gravatar.com/avatar/8fd72361ddf401e0ed1b976dd22ac39d?d=https%3A%2F%2Fidenticons.github.com%2Ffcb1e76c15f46ed1da13b6409f11ea6f.png&r=x","gravatar_id":"8fd72361ddf401e0ed1b976dd22ac39d","url":"https://api.github.com/users/AlinT","html_url":"https://github.com/AlinT","followers_url":"https://api.github.com/users/AlinT/followers","following_url":"https://api.github.com/users/AlinT/following{/other_user}","gists_url":"https://api.github.com/users/AlinT/gists{/gist_id}","starred_url":"https://api.github.com/users/AlinT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlinT/subscriptions","organizations_url":"https://api.github.com/users/AlinT/orgs","repos_url":"https://api.github.com/users/AlinT/repos","events_url":"https://api.github.com/users/AlinT/events{/privacy}","received_events_url":"https://api.github.com/users/AlinT/received_events","type":"User","site_admin":false},"body":"I think we should use this for all the pages, so I recommend moving it accordingly","created_at":"2013-12-11T12:10:30Z","updated_at":"2013-12-11T12:10:30Z","html_url":"https://github.com/mozilla/Addon-Tests/pull/677#discussion_r8264152","pull_request_url":"https://api.github.com/repos/mozilla/Addon-Tests/pulls/677","_links":{"self":{"href":"https://api.github.com/repos/mozilla/Addon-Tests/pulls/comments/8264152"},"html":{"href":"https://github.com/mozilla/Addon-Tests/pull/677#discussion_r8264152"},"pull_request":{"href":"https://api.github.com/repos/mozilla/Addon-Tests/pulls/677"}}}} | {
"id": 1735239,
"name": "Addon-Tests",
"url": "https://github.com/mozilla/Addon-Tests"
} | {
"id": null,
"login": "AlinT",
"gravatar_id": "8fd72361ddf401e0ed1b976dd22ac39d",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "mozilla",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-12-11T12:10:30 | null | {"repository":{"description":"Selenium Tests for addons.mozilla.org","homepage":"","watchers":79,"stargazers":79,"forks":72,"fork":false,"size":4384,"owner":"mozilla","private":false,"open_issues":6,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Python","created_at":"2011-05-11T13:39:29-07:00","pushed_at":"2013-12-02T14:19:42-08:00","master_branch":"master","organization":"mozilla"},"actor_attributes":{"type":"User","name":"Trif Andrei-Alin","email":"[email protected]"},"url":"https://github.com/mozilla/Addon-Tests/pull/677#discussion_r8264152"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/mozilla/mozillians/pulls/comments/2961588","id":2961588,"body":"This is not going to work, because `--recursive` is required to clone submodules along with the repo. Maybe you can directly point to the `installation` documentation which has more complete instructions on how to setup your environment?","path":"docs/contribute.rst","position":21,"original_position":21,"commit_id":"425bdbb03270e3bfd0216324ec16b1d2a2a63b29","original_commit_id":"425bdbb03270e3bfd0216324ec16b1d2a2a63b29","user":{"login":"glogiotatidis","id":584352,"avatar_url":"https://secure.gravatar.com/avatar/7b74caf316a6c6716977fe84b56774c1?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"7b74caf316a6c6716977fe84b56774c1","url":"https://api.github.com/users/glogiotatidis","followers_url":"https://api.github.com/users/glogiotatidis/followers","following_url":"https://api.github.com/users/glogiotatidis/following","gists_url":"https://api.github.com/users/glogiotatidis/gists{/gist_id}","starred_url":"https://api.github.com/users/glogiotatidis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glogiotatidis/subscriptions","organizations_url":"https://api.github.com/users/glogiotatidis/orgs","repos_url":"https://api.github.com/users/glogiotatidis/repos","events_url":"https://api.github.com/users/glogiotatidis/events{/privacy}","received_events_url":"https://api.github.com/users/glogiotatidis/received_events","type":"User"},"created_at":"2013-02-11T14:18:33Z","updated_at":"2013-02-11T14:18:33Z","_links":{"self":{"href":"https://api.github.com/repos/mozilla/mozillians/pulls/comments/2961588"},"html":{"href":"https://github.com/mozilla/mozillians/pull/391#discussion_r2961588"},"pull_request":{"href":"https://api.github.com/repos/mozilla/mozillians/pulls/391"}}}} | {
"id": 1799884,
"name": "mozillians",
"url": "https://github.com/mozilla/mozillians"
} | {
"id": null,
"login": "glogiotatidis",
"gravatar_id": "7b74caf316a6c6716977fe84b56774c1",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "mozilla",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-02-11T14:18:33 | null | {"repository":{"description":"Mozilla community directory -- A centralized directory of all Mozilla contributors!","homepage":"https://mozillians.org/","watchers":65,"stargazers":65,"forks":51,"fork":false,"size":428,"owner":"mozilla","private":false,"open_issues":15,"has_issues":false,"has_downloads":true,"has_wiki":false,"language":"Python","created_at":"2011-05-25T09:38:54-07:00","pushed_at":"2013-02-07T08:33:54-08:00","master_branch":"master","organization":"mozilla"},"actor_attributes":{"name":"Giorgos Logiotatidis","company":"Mozilla","blog":"http://www.sealabs.net/seadog","location":"Athens, Greece","type":"User","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/mozilla/mozillians/pull/391#discussion_r2961588"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/mozilla/webpay/pulls/comments/4228772","id":4228772,"body":"combine these two if statements with ``&&`` ?","diff_hunk":"@@ -81,9 +111,25 @@ require(['cli'], function(cli) {\n stopWatching();\n }).on('click', '.pinbox', function(e) {\n $pinInput.focus();\n+ }).on('keypress', '.pinbox input', function(e) {\n+ // Don't show error for backspace/tab etc\n+ if (!isAllowedKeyEvent(e)) {\n+ if (!isNumericKeyEvent(e)) {","path":"media/js/pin/pin.js","position":72,"original_position":72,"commit_id":"9ce3dc6b4d206bb04db464be51454dc7bb1d4eba","original_commit_id":"9ce3dc6b4d206bb04db464be51454dc7bb1d4eba","user":{"login":"kumar303","id":55398,"avatar_url":"https://secure.gravatar.com/avatar/3e7e975f0fa432f4ae6604f72c132309?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"3e7e975f0fa432f4ae6604f72c132309","url":"https://api.github.com/users/kumar303","html_url":"https://github.com/kumar303","followers_url":"https://api.github.com/users/kumar303/followers","following_url":"https://api.github.com/users/kumar303/following{/other_user}","gists_url":"https://api.github.com/users/kumar303/gists{/gist_id}","starred_url":"https://api.github.com/users/kumar303/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kumar303/subscriptions","organizations_url":"https://api.github.com/users/kumar303/orgs","repos_url":"https://api.github.com/users/kumar303/repos","events_url":"https://api.github.com/users/kumar303/events{/privacy}","received_events_url":"https://api.github.com/users/kumar303/received_events","type":"User"},"created_at":"2013-05-15T05:29:03Z","updated_at":"2013-05-15T05:29:03Z","html_url":"https://github.com/mozilla/webpay/pull/119#discussion_r4228772","pull_request_url":"https://api.github.com/repos/mozilla/webpay/pulls/119","_links":{"self":{"href":"https://api.github.com/repos/mozilla/webpay/pulls/comments/4228772"},"html":{"href":"https://github.com/mozilla/webpay/pull/119#discussion_r4228772"},"pull_request":{"href":"https://api.github.com/repos/mozilla/webpay/pulls/119"}}}} | {
"id": 6037696,
"name": "webpay",
"url": "https://github.com/mozilla/webpay"
} | {
"id": null,
"login": "kumar303",
"gravatar_id": "3e7e975f0fa432f4ae6604f72c132309",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "mozilla",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-05-15T05:29:03 | null | {"repository":{"description":"Webpay is an implementation of the WebPaymentProvider spec","homepage":"","watchers":12,"stargazers":12,"forks":19,"fork":false,"size":11352,"owner":"mozilla","private":false,"open_issues":2,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Python","created_at":"2012-10-01T16:10:24-07:00","pushed_at":"2013-05-14T17:16:49-07:00","master_branch":"master","organization":"mozilla"},"actor_attributes":{"type":"User","name":"Kumar McMillan","company":"Mozilla","blog":"http://farmdev.com/","location":"Chicago, IL","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/mozilla/webpay/pull/119#discussion_r4228772"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/mozilla/webpay/pulls/comments/6398561","id":6398561,"body":"is this bango specific or could it go in one of the constants.py files?","diff_hunk":"@@ -7,15 +7,20 @@\n \n from django_paranoia.decorators import require_GET, require_POST\n from slumber.exceptions import HttpClientError\n-from tower import ugettext as _\n+from tower import ugettext_lazy\n \n from lib.solitude.api import client\n from webpay.bango.auth import basic, NoHeader, WrongHeader\n+from webpay.base import dev_messages as msg\n from webpay.base.logger import getLogger\n from webpay.base.utils import _error\n from webpay.pay import tasks\n \n+user_error_msg = ugettext_lazy(\n+ u'There was an internal error processing the payment. '\n+ u'Try again or contact Mozilla if it persists.')\n log = getLogger('w.bango')\n+RECORDED_OK = 'RECORDED_OK'","path":"webpay/bango/views.py","position":18,"original_position":18,"commit_id":"4f7bb35576f47fb3a13016605961938546ef6d7d","original_commit_id":"4f7bb35576f47fb3a13016605961938546ef6d7d","user":{"login":"andymckay","id":74699,"avatar_url":"https://2.gravatar.com/avatar/ad304e7a7d4f6fba05a81b10810fe6fd?d=https%3A%2F%2Fidenticons.github.com%2F573904d41889ede6ef7f0c66c09a4488.png","gravatar_id":"ad304e7a7d4f6fba05a81b10810fe6fd","url":"https://api.github.com/users/andymckay","html_url":"https://github.com/andymckay","followers_url":"https://api.github.com/users/andymckay/followers","following_url":"https://api.github.com/users/andymckay/following{/other_user}","gists_url":"https://api.github.com/users/andymckay/gists{/gist_id}","starred_url":"https://api.github.com/users/andymckay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andymckay/subscriptions","organizations_url":"https://api.github.com/users/andymckay/orgs","repos_url":"https://api.github.com/users/andymckay/repos","events_url":"https://api.github.com/users/andymckay/events{/privacy}","received_events_url":"https://api.github.com/users/andymckay/received_events","type":"User"},"created_at":"2013-09-17T08:19:21Z","updated_at":"2013-09-17T08:19:21Z","html_url":"https://github.com/mozilla/webpay/pull/291#discussion_r6398561","pull_request_url":"https://api.github.com/repos/mozilla/webpay/pulls/291","_links":{"self":{"href":"https://api.github.com/repos/mozilla/webpay/pulls/comments/6398561"},"html":{"href":"https://github.com/mozilla/webpay/pull/291#discussion_r6398561"},"pull_request":{"href":"https://api.github.com/repos/mozilla/webpay/pulls/291"}}}} | {
"id": 6037696,
"name": "webpay",
"url": "https://github.com/mozilla/webpay"
} | {
"id": null,
"login": "andymckay",
"gravatar_id": "ad304e7a7d4f6fba05a81b10810fe6fd",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "mozilla",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-09-17T08:19:21 | null | {"repository":{"description":"Webpay is an implementation of the WebPaymentProvider spec","homepage":"","watchers":18,"stargazers":18,"forks":42,"fork":false,"size":49944,"owner":"mozilla","private":false,"open_issues":4,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Python","created_at":"2012-10-01T16:10:24-07:00","pushed_at":"2013-09-16T13:56:49-07:00","master_branch":"master","organization":"mozilla"},"actor_attributes":{"type":"User","name":"Andy McKay","company":"Mozilla","blog":"http://mozilla.com/","location":"Vancouver, BC","email":"[email protected]"},"url":"https://github.com/mozilla/webpay/pull/291#discussion_r6398561"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/numenta/nupic.tools/pulls/comments/5686771","id":5686771,"body":"Declare all variables at the top of the function scope. ","diff_hunk":"@@ -0,0 +1,133 @@\n+var jsdom = require(\"jsdom\");\n+var nodeURL = require(\"url\");\n+var jsonUtils = require('../utils/json');\n+\n+var outputType;\n+var total;\n+var numberSubsHTML;\n+var numberSubsNoDigest;\n+var numberSubsDigest;\n+\n+var requestCount;\n+var urls = [];\n+var data = [];\n+\n+var monthNames = [ \"January\", \"February\", \"March\", \"April\", \"May\", \"June\", \"July\", \"August\", \"September\", \"October\", \"November\", \"December\"];\n+var month;\n+var year;\n+var arrayPos;\n+\n+function mailingListReporter (request, response) {\n+\n+if(nodeURL.parse(request.url,false,true).pathname.split(\".\").pop() == \"json\")\n+ outputType = \"JSON\";\n+else\n+ outputType = \"HTML\";\n+\n+urls = [];\n+data = [];\n+requestCount = 0;\n+\n+urls.push({\"url\":\"http://lists.numenta.org/mailman/roster/nupic_lists.numenta.org\"});\n+\n+month = 4; //Start in May\n+year = 2013; //Start in 2013\n+var date = new Date();","path":"handlers/mailingListReporter.js","position":35,"original_position":35,"commit_id":"9f5b75a2cd7424cfa444b6ee33b3eb1177fe5ea5","original_commit_id":"9f5b75a2cd7424cfa444b6ee33b3eb1177fe5ea5","user":{"login":"rhyolight","id":15566,"avatar_url":"https://secure.gravatar.com/avatar/92b95d73c678f23c6060e63bff3dbcbd?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"92b95d73c678f23c6060e63bff3dbcbd","url":"https://api.github.com/users/rhyolight","html_url":"https://github.com/rhyolight","followers_url":"https://api.github.com/users/rhyolight/followers","following_url":"https://api.github.com/users/rhyolight/following{/other_user}","gists_url":"https://api.github.com/users/rhyolight/gists{/gist_id}","starred_url":"https://api.github.com/users/rhyolight/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhyolight/subscriptions","organizations_url":"https://api.github.com/users/rhyolight/orgs","repos_url":"https://api.github.com/users/rhyolight/repos","events_url":"https://api.github.com/users/rhyolight/events{/privacy}","received_events_url":"https://api.github.com/users/rhyolight/received_events","type":"User"},"created_at":"2013-08-09T16:15:27Z","updated_at":"2013-08-09T16:15:27Z","html_url":"https://github.com/numenta/nupic.tools/pull/4#discussion_r5686771","pull_request_url":"https://api.github.com/repos/numenta/nupic.tools/pulls/4","_links":{"self":{"href":"https://api.github.com/repos/numenta/nupic.tools/pulls/comments/5686771"},"html":{"href":"https://github.com/numenta/nupic.tools/pull/4#discussion_r5686771"},"pull_request":{"href":"https://api.github.com/repos/numenta/nupic.tools/pulls/4"}}}} | {
"id": 10611388,
"name": "nupic.tools",
"url": "https://github.com/numenta/nupic.tools"
} | {
"id": null,
"login": "rhyolight",
"gravatar_id": "92b95d73c678f23c6060e63bff3dbcbd",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "numenta",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-08-09T16:15:27 | null | {"repository":{"description":"Server for tooling around the development process for the NuPIC project.","watchers":3,"stargazers":3,"forks":3,"fork":false,"size":289,"owner":"numenta","private":false,"open_issues":2,"has_issues":false,"has_downloads":true,"has_wiki":true,"language":"JavaScript","created_at":"2013-06-10T16:11:35-07:00","pushed_at":"2013-08-08T08:39:40-07:00","master_branch":"master","organization":"numenta"},"actor_attributes":{"type":"User","name":"Matthew Taylor","company":"Numenta","blog":"http://rhyolight.posterous.com","location":"Cupertino, CA","email":"[email protected]"},"url":"https://github.com/numenta/nupic.tools/pull/4#discussion_r5686771"} |
PullRequestReviewCommentEvent | true | {"comment":{"_links":{"pull_request":{"href":"https://api.github.com/repos/openmrs/openmrs-core/pulls/200"},"html":{"href":"https://github.com/openmrs/openmrs-core/pull/200#discussion_r2761298"},"self":{"href":"https://api.github.com/repos/openmrs/openmrs-core/pulls/comments/2761298"}},"path":"web/src/test/java/org/openmrs/scheduler/web/controller/SchedulerFormControllerTest.java","commit_id":"32881640e061f32fa1ff781adcd18e392c44fdf3","body":"remove this so that this remains silent","user":{"gravatar_id":"5cd6c4175104cf104a7a9911d434c4cd","subscriptions_url":"https://api.github.com/users/wluyima/subscriptions","repos_url":"https://api.github.com/users/wluyima/repos","type":"User","login":"wluyima","following_url":"https://api.github.com/users/wluyima/following","gists_url":"https://api.github.com/users/wluyima/gists{/gist_id}","organizations_url":"https://api.github.com/users/wluyima/orgs","starred_url":"https://api.github.com/users/wluyima/starred{/owner}{/repo}","received_events_url":"https://api.github.com/users/wluyima/received_events","followers_url":"https://api.github.com/users/wluyima/followers","avatar_url":"https://secure.gravatar.com/avatar/5cd6c4175104cf104a7a9911d434c4cd?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","url":"https://api.github.com/users/wluyima","id":1395907,"events_url":"https://api.github.com/users/wluyima/events{/privacy}"},"original_position":128,"original_commit_id":"32881640e061f32fa1ff781adcd18e392c44fdf3","updated_at":"2013-01-24T17:01:06Z","url":"https://api.github.com/repos/openmrs/openmrs-core/pulls/comments/2761298","position":128,"id":2761298,"created_at":"2013-01-24T17:01:06Z"}} | {
"id": 5187976,
"name": "openmrs-core",
"url": "https://github.com/openmrs/openmrs-core"
} | {
"id": null,
"login": "wluyima",
"gravatar_id": "5cd6c4175104cf104a7a9911d434c4cd",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "openmrs",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-01-24T17:01:06 | null | {"repository":{"owner":"openmrs","homepage":"http://openmrs.org","watchers":32,"has_wiki":false,"created_at":"2012-07-25T21:54:29-07:00","stargazers":32,"open_issues":39,"description":"OpenMRS API and web application code","pushed_at":"2013-01-23T21:32:11-08:00","forks":159,"language":"Java","organization":"openmrs","fork":false,"size":17840,"has_issues":false,"private":false,"has_downloads":true},"actor_attributes":{"type":"User","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/openmrs/openmrs-core/pull/200#discussion_r2761298"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/oxilion/puppet-foreman/pulls/comments/8496010","id":8496010,"diff_hunk":"@@ -138,7 +154,12 @@\n $db_adapter_real = $db_adapter\n }\n class { 'foreman::install': } ~>\n- class { 'foreman::config': } ~>\n+ class { 'foreman::config':\n+ ssl_cert => $ssl_cert,\n+ ssl_key => $ssl_key,\n+ ssl_ca => $ssl_ca,\n+ ssl_chain => $ssl_ca,","path":"manifests/init.pp","position":43,"original_position":43,"commit_id":"13f5a33ff0fc75541fcfeb0ef177ef9f54035bc3","original_commit_id":"13f5a33ff0fc75541fcfeb0ef177ef9f54035bc3","user":{"login":"ekohl","id":155810,"avatar_url":"https://gravatar.com/avatar/0a94fde0a807ef39cf12c60b9422a34f?d=https%3A%2F%2Fidenticons.github.com%2F24dbf99d42a434bf0593538f44cca229.png&r=x","gravatar_id":"0a94fde0a807ef39cf12c60b9422a34f","url":"https://api.github.com/users/ekohl","html_url":"https://github.com/ekohl","followers_url":"https://api.github.com/users/ekohl/followers","following_url":"https://api.github.com/users/ekohl/following{/other_user}","gists_url":"https://api.github.com/users/ekohl/gists{/gist_id}","starred_url":"https://api.github.com/users/ekohl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ekohl/subscriptions","organizations_url":"https://api.github.com/users/ekohl/orgs","repos_url":"https://api.github.com/users/ekohl/repos","events_url":"https://api.github.com/users/ekohl/events{/privacy}","received_events_url":"https://api.github.com/users/ekohl/received_events","type":"User","site_admin":false},"body":"This should not be needed.","created_at":"2013-12-20T10:00:10Z","updated_at":"2013-12-20T10:00:10Z","html_url":"https://github.com/oxilion/puppet-foreman/pull/3#discussion_r8496010","pull_request_url":"https://api.github.com/repos/oxilion/puppet-foreman/pulls/3","_links":{"self":{"href":"https://api.github.com/repos/oxilion/puppet-foreman/pulls/comments/8496010"},"html":{"href":"https://github.com/oxilion/puppet-foreman/pull/3#discussion_r8496010"},"pull_request":{"href":"https://api.github.com/repos/oxilion/puppet-foreman/pulls/3"}}}} | {
"id": 8927512,
"name": "puppet-foreman",
"url": "https://github.com/oxilion/puppet-foreman"
} | {
"id": null,
"login": "ekohl",
"gravatar_id": "0a94fde0a807ef39cf12c60b9422a34f",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "oxilion",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-12-20T10:00:10 | null | {"repository":{"description":"Puppet module for Foreman","homepage":"","watchers":0,"stargazers":0,"forks":0,"fork":true,"size":425,"owner":"oxilion","private":false,"open_issues":1,"has_issues":false,"has_downloads":true,"has_wiki":true,"language":"Puppet","created_at":"2013-03-21T04:41:58-07:00","pushed_at":"2013-12-19T01:20:43-08:00","master_branch":"master","organization":"oxilion"},"actor_attributes":{"type":"User","name":"Ewoud Kohl van Wijngaarden","company":"Oxilion","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/oxilion/puppet-foreman/pull/3#discussion_r8496010"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/pfsense/pfsense/pulls/comments/4053890","id":4053890,"body":"This is not your private repo!","diff_hunk":"@@ -2,3 +2,4 @@\n _notes/\n # Ignore Vim swap files\n .*.swp\n+/nbproject/private/","path":".gitignore","position":4,"original_position":4,"commit_id":"df455593bea896a16abc3670b7bf3f9abaf9cafc","original_commit_id":"df455593bea896a16abc3670b7bf3f9abaf9cafc","user":{"login":"ermal","id":185253,"avatar_url":"https://secure.gravatar.com/avatar/ada44811ee680f8b24bd3b0936a076ee?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"ada44811ee680f8b24bd3b0936a076ee","url":"https://api.github.com/users/ermal","html_url":"https://github.com/ermal","followers_url":"https://api.github.com/users/ermal/followers","following_url":"https://api.github.com/users/ermal/following","gists_url":"https://api.github.com/users/ermal/gists{/gist_id}","starred_url":"https://api.github.com/users/ermal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ermal/subscriptions","organizations_url":"https://api.github.com/users/ermal/orgs","repos_url":"https://api.github.com/users/ermal/repos","events_url":"https://api.github.com/users/ermal/events{/privacy}","received_events_url":"https://api.github.com/users/ermal/received_events","type":"User"},"created_at":"2013-05-02T12:54:43Z","updated_at":"2013-05-02T12:54:43Z","html_url":"https://github.com/pfsense/pfsense/pull/621#discussion_r4053890","pull_request_url":"https://api.github.com/repos/pfsense/pfsense/pulls/621","_links":{"self":{"href":"https://api.github.com/repos/pfsense/pfsense/pulls/comments/4053890"},"html":{"href":"https://github.com/pfsense/pfsense/pull/621#discussion_r4053890"},"pull_request":{"href":"https://api.github.com/repos/pfsense/pfsense/pulls/621"}}}} | {
"id": 1740040,
"name": "pfsense",
"url": "https://github.com/pfsense/pfsense"
} | {
"id": null,
"login": "ermal",
"gravatar_id": "ada44811ee680f8b24bd3b0936a076ee",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "pfsense",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-05-02T12:54:43 | null | {"repository":{"description":"Main repository for pfSense","homepage":"http://www.pfsense.org","watchers":229,"stargazers":229,"forks":125,"fork":false,"size":6400,"owner":"pfsense","private":false,"open_issues":4,"has_issues":false,"has_downloads":true,"has_wiki":true,"language":"PHP","created_at":"2011-05-12T12:44:21-07:00","pushed_at":"2013-05-01T13:39:19-07:00","master_branch":"master","organization":"pfsense"},"actor_attributes":{"type":"User","name":"Ermal Luçi","company":"BSD Perimeter","location":"Albania","email":"[email protected]"},"url":"https://github.com/pfsense/pfsense/pull/621#discussion_r4053890"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/phpspec/Symfony2Extension/pulls/comments/6363899","id":6363899,"body":"I reverted it until (if) the PR is (not) accepted.","diff_hunk":"@@ -0,0 +1,7 @@\n+extensions:\n+ PhpSpec\\Symfony2Extension\\Extension:","path":"phpspec.yml","position":null,"original_position":2,"commit_id":"0e97ad443a7c360c6882b945111c691a376780e1","original_commit_id":"11feb78854af9218b7fff4d9d4c9d3b16e680464","user":{"login":"docteurklein","id":109846,"avatar_url":"https://1.gravatar.com/avatar/d18e2c9cdd3add22170bbd4ec3937176?d=https%3A%2F%2Fidenticons.github.com%2F7d65b50780ad5353d2feaa269a640a92.png","gravatar_id":"d18e2c9cdd3add22170bbd4ec3937176","url":"https://api.github.com/users/docteurklein","html_url":"https://github.com/docteurklein","followers_url":"https://api.github.com/users/docteurklein/followers","following_url":"https://api.github.com/users/docteurklein/following{/other_user}","gists_url":"https://api.github.com/users/docteurklein/gists{/gist_id}","starred_url":"https://api.github.com/users/docteurklein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docteurklein/subscriptions","organizations_url":"https://api.github.com/users/docteurklein/orgs","repos_url":"https://api.github.com/users/docteurklein/repos","events_url":"https://api.github.com/users/docteurklein/events{/privacy}","received_events_url":"https://api.github.com/users/docteurklein/received_events","type":"User"},"created_at":"2013-09-14T14:19:23Z","updated_at":"2013-09-14T14:19:23Z","html_url":"https://github.com/phpspec/Symfony2Extension/pull/3#discussion_r6363899","pull_request_url":"https://api.github.com/repos/phpspec/Symfony2Extension/pulls/3","_links":{"self":{"href":"https://api.github.com/repos/phpspec/Symfony2Extension/pulls/comments/6363899"},"html":{"href":"https://github.com/phpspec/Symfony2Extension/pull/3#discussion_r6363899"},"pull_request":{"href":"https://api.github.com/repos/phpspec/Symfony2Extension/pulls/3"}}}} | {
"id": 11683074,
"name": "Symfony2Extension",
"url": "https://github.com/phpspec/Symfony2Extension"
} | {
"id": null,
"login": "docteurklein",
"gravatar_id": "d18e2c9cdd3add22170bbd4ec3937176",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "phpspec",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-09-14T14:19:23 | null | {"repository":{"description":"Symfony2 extension for PhpSpec","watchers":11,"stargazers":11,"forks":5,"fork":false,"size":177,"owner":"phpspec","private":false,"open_issues":3,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"PHP","created_at":"2013-07-26T03:02:43-07:00","pushed_at":"2013-09-02T15:03:14-07:00","master_branch":"master","organization":"phpspec"},"actor_attributes":{"type":"User","name":"Florian Klein","company":"KnpLabs","blog":"http://www.knplabs.com","location":"Nantes, France","email":"[email protected]"},"url":"https://github.com/phpspec/Symfony2Extension/pull/3#discussion_r6363899"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/pymssql/pymssql/pulls/comments/8558625","id":8558625,"diff_hunk":"@@ -219,6 +219,9 @@ cdef int err_handler(DBPROCESS *dbproc, int severity, int dberr, int oserr,\n mssql_lastmsgno = &(<MSSQLConnection>conn).last_msg_no\n mssql_lastmsgseverity = &(<MSSQLConnection>conn).last_msg_severity\n mssql_lastmsgstate = &(<MSSQLConnection>conn).last_msg_state\n+ if DBDEAD(dbproc):\n+ log(\"+++ err_handler: dbproc is dead; killing conn...\\n\")\n+ conn.mark_disconnected()","path":"_mssql.pyx","position":6,"original_position":6,"commit_id":"790257214e143f70418a1c731c992fa313ceac4a","original_commit_id":"790257214e143f70418a1c731c992fa313ceac4a","user":{"login":"msabramo","id":305268,"avatar_url":"https://gravatar.com/avatar/3d91a2f54a0ad7f3044458a064ea7a84?d=https%3A%2F%2Fidenticons.github.com%2F0d145b716defe62e054bf09c2e78a9e4.png&r=x","gravatar_id":"3d91a2f54a0ad7f3044458a064ea7a84","url":"https://api.github.com/users/msabramo","html_url":"https://github.com/msabramo","followers_url":"https://api.github.com/users/msabramo/followers","following_url":"https://api.github.com/users/msabramo/following{/other_user}","gists_url":"https://api.github.com/users/msabramo/gists{/gist_id}","starred_url":"https://api.github.com/users/msabramo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msabramo/subscriptions","organizations_url":"https://api.github.com/users/msabramo/orgs","repos_url":"https://api.github.com/users/msabramo/repos","events_url":"https://api.github.com/users/msabramo/events{/privacy}","received_events_url":"https://api.github.com/users/msabramo/received_events","type":"User","site_admin":false},"body":"Well, I also wondered this and looked at this for a while. I considered returning `INT_EXIT` as I think you had suggested, but now I think that `INT_CANCEL` is appropriate.\r\n\r\nLooking at various docs and at the actual code (https://gitorious.org/freetds/freetds/source/52e59affc0110c5ddd379ef1e45c4554123f27b5:src/dblib/dblib.c#L7976), there are 4 possible return values for an error handler:\r\n\r\n1. `INT_CONTINUE` -- \"The db-lib function will retry the operation.\" (https://gitorious.org/freetds/freetds/source/52e59affc0110c5ddd379ef1e45c4554123f27b5:src/dblib/dblib.c#L7826) -- clearly not what we want if `DBDEAD(dbproc)` is true.\r\n2. `INT_TIMEOUT` -- \"The db-lib function will cancel the operation and return FAIL. \\a dbproc remains useable.\" (https://gitorious.org/freetds/freetds/source/52e59affc0110c5ddd379ef1e45c4554123f27b5:src/dblib/dblib.c#L7825) -- We don't want the dbproc to remain useable if `DBDEAD(dbproc)` is true.\r\n3. `INT_EXIT` -- this looks tempting initially. When running in Sybase compatibility mode, this calls `exit(3)`, which will kill the entire OS process, which is nice for a command-line program like `tsql`, but not so nice for a web server. When running in Microsoft compatibility mode (what we should be using), this simply gets converted to `INT_CANCEL` (see https://gitorious.org/freetds/freetds/source/52e59affc0110c5ddd379ef1e45c4554123f27b5:src/dblib/dblib.c#L7999)\r\n\"If Sybase semantics are used, this function notifies\r\n * the user and calls exit(3). If Microsoft semantics are used, this function returns INT_CANCEL.\" (https://gitorious.org/freetds/freetds/source/52e59affc0110c5ddd379ef1e45c4554123f27b5:src/dblib/dblib.c#L7828)\r\n4. `INT_CANCEL` -- \"The db-lib function that encountered the error will return FAIL.\" (https://gitorious.org/freetds/freetds/source/52e59affc0110c5ddd379ef1e45c4554123f27b5:src/dblib/dblib.c#L7824) -- This is what we want.\r\n","created_at":"2013-12-26T18:34:15Z","updated_at":"2013-12-26T18:34:15Z","html_url":"https://github.com/pymssql/pymssql/pull/147#discussion_r8558625","pull_request_url":"https://api.github.com/repos/pymssql/pymssql/pulls/147","_links":{"self":{"href":"https://api.github.com/repos/pymssql/pymssql/pulls/comments/8558625"},"html":{"href":"https://github.com/pymssql/pymssql/pull/147#discussion_r8558625"},"pull_request":{"href":"https://api.github.com/repos/pymssql/pymssql/pulls/147"}}}} | {
"id": 12704584,
"name": "pymssql",
"url": "https://github.com/pymssql/pymssql"
} | {
"id": null,
"login": "msabramo",
"gravatar_id": "3d91a2f54a0ad7f3044458a064ea7a84",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "pymssql",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-12-26T18:34:15 | null | {"repository":{"description":"The new official home for pymssql","watchers":12,"stargazers":12,"forks":4,"fork":false,"size":8901,"owner":"pymssql","private":false,"open_issues":18,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"C","created_at":"2013-09-09T08:10:18-07:00","pushed_at":"2013-12-26T09:21:44-08:00","master_branch":"master","organization":"pymssql"},"actor_attributes":{"type":"User","name":"Marc Abramowitz","company":"SurveyMonkey","blog":"http://marc-abramowitz.com","location":"San Jose, California, USA","email":"[email protected]"},"url":"https://github.com/pymssql/pymssql/pull/147#discussion_r8558625"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/pyrocms/pyrocms/pulls/comments/4235580","id":4235580,"body":"Sorry I replied.","diff_hunk":"@@ -115,6 +115,47 @@ public function check_access($group_id, $module = null)\n \t\t\t->where('group_id', $group_id)\n \t\t\t->count_all_results('permissions') > 0;\n \t}\n+\t\n+\t\t/**\n+\t * Get a rule & role based on the ID\n+\t *\n+\t * @param int $group_id The id for the group to get the rule for.\n+\t * @param null|string $module The module to check access against\n+\t * @param $role The role to check access against\n+\t * @return int\n+\t */\n+\t\n+\tpublic function check_access_role($group_id, $module = null,$role = null)\n+\t{\n+\t\t$count = 0;\n+\t\t// If no module is set, just make sure they have SOMETHING\n+\t\tif ($module !== null)\n+\t\t{\n+\t\t\t$this->db->where('module', $module);\n+\t\t}\n+\n+\t\t//get the group\n+\t\t$this->db->where('group_id',$group_id);\n+\t\t$this->db->from('permissions');\n+\t\t$query = $this->db->get();\n+\t\t\t\n+\t\t//iterate over the rows in the result \n+\t\tforeach ($query->result() as $row)\n+\t\t{\n+\t\t\t//parse the json string\n+\t\t\t$json = $row->roles;","path":"system/cms/modules/permissions/models/permission_m.php","position":32,"original_position":32,"commit_id":"9b66793c84d42fd4fefc106f2869c9632e025ac8","original_commit_id":"9b66793c84d42fd4fefc106f2869c9632e025ac8","user":{"login":"philsturgeon","id":67381,"avatar_url":"https://secure.gravatar.com/avatar/14df293d6c5cd6f05996dfc606a6a951?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"14df293d6c5cd6f05996dfc606a6a951","url":"https://api.github.com/users/philsturgeon","html_url":"https://github.com/philsturgeon","followers_url":"https://api.github.com/users/philsturgeon/followers","following_url":"https://api.github.com/users/philsturgeon/following{/other_user}","gists_url":"https://api.github.com/users/philsturgeon/gists{/gist_id}","starred_url":"https://api.github.com/users/philsturgeon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philsturgeon/subscriptions","organizations_url":"https://api.github.com/users/philsturgeon/orgs","repos_url":"https://api.github.com/users/philsturgeon/repos","events_url":"https://api.github.com/users/philsturgeon/events{/privacy}","received_events_url":"https://api.github.com/users/philsturgeon/received_events","type":"User"},"created_at":"2013-05-15T14:32:52Z","updated_at":"2013-05-15T14:32:52Z","html_url":"https://github.com/pyrocms/pyrocms/pull/2708#discussion_r4235580","pull_request_url":"https://api.github.com/repos/pyrocms/pyrocms/pulls/2708","_links":{"self":{"href":"https://api.github.com/repos/pyrocms/pyrocms/pulls/comments/4235580"},"html":{"href":"https://github.com/pyrocms/pyrocms/pull/2708#discussion_r4235580"},"pull_request":{"href":"https://api.github.com/repos/pyrocms/pyrocms/pulls/2708"}}}} | {
"id": 759578,
"name": "pyrocms",
"url": "https://github.com/pyrocms/pyrocms"
} | {
"id": null,
"login": "philsturgeon",
"gravatar_id": "14df293d6c5cd6f05996dfc606a6a951",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "pyrocms",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-05-15T14:32:52 | null | {"repository":{"description":"PyroCMS is an MVC PHP Content Management System built to be easy to use, theme and develop with. It is used by individuals and organizations of all sizes around the world.","homepage":"https://www.pyrocms.com/","watchers":1465,"stargazers":1465,"forks":654,"fork":false,"size":32048,"owner":"pyrocms","private":false,"open_issues":103,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"PHP","created_at":"2010-07-06T05:55:25-07:00","pushed_at":"2013-05-14T13:50:13-07:00","integrate_branch":"develop","master_branch":"2.3/develop","organization":"pyrocms"},"actor_attributes":{"type":"User","name":"Phil Sturgeon","company":"Kaptu.re","blog":"http://philsturgeon.co.uk/","location":"Williamsburg, New York","email":"[email protected]"},"url":"https://github.com/pyrocms/pyrocms/pull/2708#discussion_r4235580"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/scummvm/scummvm/pulls/comments/7725868","id":7725868,"diff_hunk":"@@ -41,15 +42,19 @@\n \t{\"dirtysplit\", \"Dirty Split\"},\n \t{\"dreamscape\", \"Dreamscape\"},\n \t{\"escapemansion\", \"Escape from the Mansion\"},\n+\t{\"framed\", \"Framed\"},\n \t{\"ghostsheet\", \"Ghost in the Sheet\"},\n \t{\"hamlet\", \"Hamlet or the last game without MMORPS features, shaders and product placement\"},\n \t{\"helga\", \"Helga Deep In Trouble\"},\n \t{\"jamesperis\", \"James Peris: No License Nor Control\"},\n+\t{\"kulivocko\", \"Kulivocko\"},\n \t{\"looky\", \"Looky\"},\n \t{\"julia\", \"J.U.L.I.A.\"},\n \t{\"mirage\", \"Mirage\"},\n \t{\"paintaria\", \"Paintaria\"},\n \t{\"pigeons\", \"Pigeons in the Park\"},\n+\t{\"projectdoom\" \"Project: Doom\"\n+\t{\"lonelyrobot\" \"Projectlonelyrobot\"","path":"engines/wintermute/detection_tables.h","position":27,"original_position":27,"commit_id":"1c3d5d7631e212a01b28d639114498cf6ac3e4f3","original_commit_id":"1c3d5d7631e212a01b28d639114498cf6ac3e4f3","user":{"login":"somaen","id":543402,"avatar_url":"https://2.gravatar.com/avatar/56a5794477b5e955b43be3eac341b358?d=https%3A%2F%2Fidenticons.github.com%2F12b15cdc17fca47744b19e213c62dbb1.png&r=x","gravatar_id":"56a5794477b5e955b43be3eac341b358","url":"https://api.github.com/users/somaen","html_url":"https://github.com/somaen","followers_url":"https://api.github.com/users/somaen/followers","following_url":"https://api.github.com/users/somaen/following{/other_user}","gists_url":"https://api.github.com/users/somaen/gists{/gist_id}","starred_url":"https://api.github.com/users/somaen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/somaen/subscriptions","organizations_url":"https://api.github.com/users/somaen/orgs","repos_url":"https://api.github.com/users/somaen/repos","events_url":"https://api.github.com/users/somaen/events{/privacy}","received_events_url":"https://api.github.com/users/somaen/received_events","type":"User","site_admin":false},"body":"Is this really the name of the game? (with no spaces)","created_at":"2013-11-18T15:03:18Z","updated_at":"2013-11-18T15:03:18Z","html_url":"https://github.com/scummvm/scummvm/pull/412#discussion_r7725868","pull_request_url":"https://api.github.com/repos/scummvm/scummvm/pulls/412","_links":{"self":{"href":"https://api.github.com/repos/scummvm/scummvm/pulls/comments/7725868"},"html":{"href":"https://github.com/scummvm/scummvm/pull/412#discussion_r7725868"},"pull_request":{"href":"https://api.github.com/repos/scummvm/scummvm/pulls/412"}}}} | {
"id": 1358940,
"name": "scummvm",
"url": "https://github.com/scummvm/scummvm"
} | {
"id": null,
"login": "somaen",
"gravatar_id": "56a5794477b5e955b43be3eac341b358",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "scummvm",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-11-18T15:03:18 | null | {"repository":{"description":"ScummVM main repository","homepage":"http://www.scummvm.org/","watchers":314,"stargazers":314,"forks":173,"fork":false,"size":188861,"owner":"scummvm","private":false,"open_issues":20,"has_issues":false,"has_downloads":true,"has_wiki":false,"language":"C++","created_at":"2011-02-12T07:50:57-08:00","pushed_at":"2013-11-18T06:50:41-08:00","integrate_branch":"master","master_branch":"master","organization":"scummvm"},"actor_attributes":{"type":"User","name":"Einar Johan Trøan Sømåen","location":"Norway","email":"[email protected]"},"url":"https://github.com/scummvm/scummvm/pull/412#discussion_r7725868"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/symfony/symfony/pulls/comments/5533734","id":5533734,"body":"Should be `null !== $application` to match CS.","diff_hunk":"@@ -52,6 +52,16 @@ public function __construct(Command $command)\n */\n public function execute(array $input, array $options = array())\n {\n+ // set the command name automatically if the application requires\n+ // this argument and no command name was passed\n+ $application = $this->command->getApplication();\n+ if ($application != null) {","path":"src/Symfony/Component/Console/Tester/CommandTester.php","position":7,"original_position":7,"commit_id":"ac3cd99b80d144a2df0e7f77b0b5354f5684a9cd","original_commit_id":"ac3cd99b80d144a2df0e7f77b0b5354f5684a9cd","user":{"login":"stloyd","id":67402,"avatar_url":"https://secure.gravatar.com/avatar/b494363ed38b483b240180920c0d38c2?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"b494363ed38b483b240180920c0d38c2","url":"https://api.github.com/users/stloyd","html_url":"https://github.com/stloyd","followers_url":"https://api.github.com/users/stloyd/followers","following_url":"https://api.github.com/users/stloyd/following{/other_user}","gists_url":"https://api.github.com/users/stloyd/gists{/gist_id}","starred_url":"https://api.github.com/users/stloyd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stloyd/subscriptions","organizations_url":"https://api.github.com/users/stloyd/orgs","repos_url":"https://api.github.com/users/stloyd/repos","events_url":"https://api.github.com/users/stloyd/events{/privacy}","received_events_url":"https://api.github.com/users/stloyd/received_events","type":"User"},"created_at":"2013-08-01T16:24:04Z","updated_at":"2013-08-01T16:24:04Z","html_url":"https://github.com/symfony/symfony/pull/8626#discussion_r5533734","pull_request_url":"https://api.github.com/repos/symfony/symfony/pulls/8626","_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments/5533734"},"html":{"href":"https://github.com/symfony/symfony/pull/8626#discussion_r5533734"},"pull_request":{"href":"https://api.github.com/repos/symfony/symfony/pulls/8626"}}}} | {
"id": 458058,
"name": "symfony",
"url": "https://github.com/symfony/symfony"
} | {
"id": null,
"login": "stloyd",
"gravatar_id": "b494363ed38b483b240180920c0d38c2",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "symfony",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-08-01T16:24:04 | null | {"repository":{"description":"The Symfony PHP framework","homepage":"symfony.com","watchers":6911,"stargazers":6911,"forks":2459,"fork":false,"size":71299,"owner":"symfony","private":false,"open_issues":683,"has_issues":true,"has_downloads":false,"has_wiki":false,"language":"PHP","created_at":"2010-01-04T06:21:21-08:00","pushed_at":"2013-08-01T09:22:47-07:00","master_branch":"master","organization":"symfony"},"actor_attributes":{"type":"User","name":"Joseph Bielawski","company":"","blog":"http://webhelp.pl/","location":"Łowicz/Warsaw, Poland","email":"[email protected]"},"url":"https://github.com/symfony/symfony/pull/8626#discussion_r5533734"} |
PullRequestReviewCommentEvent | true | {"comment":{"id":2560002,"url":"https://api.github.com/repos/symfony/symfony-docs/pulls/comments/2560002","user":{"subscriptions_url":"https://api.github.com/users/WouterJ/subscriptions","gravatar_id":"331582449435f5efa35be870ab76f1a9","id":749025,"url":"https://api.github.com/users/WouterJ","repos_url":"https://api.github.com/users/WouterJ/repos","type":"User","gists_url":"https://api.github.com/users/WouterJ/gists{/gist_id}","followers_url":"https://api.github.com/users/WouterJ/followers","organizations_url":"https://api.github.com/users/WouterJ/orgs","received_events_url":"https://api.github.com/users/WouterJ/received_events","avatar_url":"https://secure.gravatar.com/avatar/331582449435f5efa35be870ab76f1a9?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","starred_url":"https://api.github.com/users/WouterJ/starred{/owner}{/repo}","login":"WouterJ","following_url":"https://api.github.com/users/WouterJ/following","events_url":"https://api.github.com/users/WouterJ/events{/privacy}"},"path":"components/dependency_injection/configurators.rst","position":48,"_links":{"pull_request":{"href":"https://api.github.com/repos/symfony/symfony-docs/pulls/2110"},"self":{"href":"https://api.github.com/repos/symfony/symfony-docs/pulls/comments/2560002"},"html":{"href":"https://github.com/symfony/symfony-docs/pull/2110#discussion_r2560002"}},"original_position":48,"body":"same here","created_at":"2013-01-06T13:40:20Z","commit_id":"5d1f416e0bb3a3dafc84a17c77410641bf96e430","original_commit_id":"5d1f416e0bb3a3dafc84a17c77410641bf96e430","updated_at":"2013-01-06T13:40:20Z"}} | {
"id": 521583,
"name": "symfony-docs",
"url": "https://github.com/symfony/symfony-docs"
} | {
"id": null,
"login": "WouterJ",
"gravatar_id": "331582449435f5efa35be870ab76f1a9",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "symfony",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-01-06T13:40:20 | null | {"repository":{"stargazers":811,"has_downloads":false,"owner":"symfony","created_at":"2010-02-17T00:43:51-08:00","homepage":"http://symfony.com/doc/current/","open_issues":148,"has_wiki":false,"pushed_at":"2013-01-06T03:02:11-08:00","description":"The Symfony2 documentation","forks":669,"organization":"symfony","fork":false,"size":1756,"watchers":811,"private":false,"has_issues":true},"actor_attributes":{"email":"[email protected]","type":"User","name":"Wouter J","blog":"http://wouterj.nl","location":"Netherlands"},"url":"https://github.com/symfony/symfony-docs/pull/2110#discussion_r2560002"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/symfony/symfony/pulls/comments/8364370","id":8364370,"diff_hunk":"@@ -0,0 +1,142 @@\n+<?php\n+\n+/*\n+ * This file is part of the Symfony package.\n+ *\n+ * (c) Fabien Potencier <[email protected]>\n+ *\n+ * For the full copyright and license information, please view the LICENSE\n+ * file that was distributed with this source code.\n+ */\n+\n+namespace Symfony\\Component\\HttpFoundation;\n+\n+/**\n+ * SocketResponse represents a HTTP response whose content is read from a file handle.\n+ *\n+ * A SocketResponse uses a PHP file handle for its content.\n+ *\n+ * The socket handle needs to be readable, e.g. $handle = fopen(\"example.txt\", \"r\");\n+ *\n+ * @author Sascha Schimke <[email protected]>\n+ */\n+class SocketResponse extends Response\n+{\n+ private $handle;\n+ private $close;\n+ private $sent;\n+\n+ /**\n+ * Constructor\n+ *\n+ * @param resource $handle A readable file handle\n+ * @param int $status The response status code\n+ * @param array $headers An array of response headers\n+ * @param bool $close Close socket handle after sending content","path":"src/Symfony/Component/HttpFoundation/SocketResponse.php","position":35,"original_position":35,"commit_id":"991dd8b8474743d4b537288f357a8086f65257bf","original_commit_id":"991dd8b8474743d4b537288f357a8086f65257bf","user":{"login":"cordoval","id":328359,"avatar_url":"https://gravatar.com/avatar/ab2a6b877dd41427c660a3d6a170cc71?d=https%3A%2F%2Fidenticons.github.com%2Fbaab6a6fd290d8efddc3f5e0fa0fdcf1.png&r=x","gravatar_id":"ab2a6b877dd41427c660a3d6a170cc71","url":"https://api.github.com/users/cordoval","html_url":"https://github.com/cordoval","followers_url":"https://api.github.com/users/cordoval/followers","following_url":"https://api.github.com/users/cordoval/following{/other_user}","gists_url":"https://api.github.com/users/cordoval/gists{/gist_id}","starred_url":"https://api.github.com/users/cordoval/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cordoval/subscriptions","organizations_url":"https://api.github.com/users/cordoval/orgs","repos_url":"https://api.github.com/users/cordoval/repos","events_url":"https://api.github.com/users/cordoval/events{/privacy}","received_events_url":"https://api.github.com/users/cordoval/received_events","type":"User","site_admin":false},"body":"I think ubot is not equipped yet with a bool -> Boolean rule","created_at":"2013-12-16T11:51:05Z","updated_at":"2013-12-16T11:51:05Z","html_url":"https://github.com/symfony/symfony/pull/9753#discussion_r8364370","pull_request_url":"https://api.github.com/repos/symfony/symfony/pulls/9753","_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments/8364370"},"html":{"href":"https://github.com/symfony/symfony/pull/9753#discussion_r8364370"},"pull_request":{"href":"https://api.github.com/repos/symfony/symfony/pulls/9753"}}}} | {
"id": 458058,
"name": "symfony",
"url": "https://github.com/symfony/symfony"
} | {
"id": null,
"login": "cordoval",
"gravatar_id": "ab2a6b877dd41427c660a3d6a170cc71",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "symfony",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-12-16T11:51:05 | null | {"repository":{"description":"The Symfony PHP framework","homepage":"symfony.com","watchers":7486,"stargazers":7486,"forks":2763,"fork":false,"size":116039,"owner":"symfony","private":false,"open_issues":22,"has_issues":true,"has_downloads":false,"has_wiki":false,"language":"PHP","created_at":"2010-01-04T06:21:21-08:00","pushed_at":"2013-12-15T10:46:58-08:00","master_branch":"master","organization":"symfony"},"actor_attributes":{"type":"User","name":"Luis Cordova","company":"Weyland & Cordova Corporation - Prometheus Project","blog":"http://www.craftitonline.com","location":"LV-233","email":"[email protected]"},"url":"https://github.com/symfony/symfony/pull/9753#discussion_r8364370"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/symfony/symfony-docs/pulls/comments/8353366","id":8353366,"diff_hunk":"@@ -1711,6 +1644,113 @@ In the above configuration, users with ``ROLE_ADMIN`` role will also have the\n ``ROLE_USER`` role. The ``ROLE_SUPER_ADMIN`` role has ``ROLE_ADMIN``, ``ROLE_ALLOWED_TO_SWITCH``\n and ``ROLE_USER`` (inherited from ``ROLE_ADMIN``).\n \n+Access Control\n+--------------\n+\n+Now that you have Users, Roles, we can go further than URL patterns based authorization.\n+\n+.. _book-security-securing-controller:\n+\n+Access Control in Controllers\n+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n+\n+Protecting your application based on URL patterns is easy, but may not be\n+fine-grained enough in certain cases. When necessary, you can easily force\n+authorization from inside a controller::\n+\n+ // ...\n+ use Symfony\\Component\\Security\\Core\\Exception\\AccessDeniedException;\n+\n+ public function helloAction($name)\n+ {\n+ if (false === $this->get('security.context')->isGranted('ROLE_ADMIN')) {\n+ throw new AccessDeniedException();\n+ }\n+\n+ // ...\n+ }\n+\n+.. note::\n+\n+ A firewall must be active or an exception will be thrown when the ``isGranted``","path":"book/security.rst","position":106,"original_position":106,"commit_id":"29c1994e11af7260afc15233563c151bf1d4e6aa","original_commit_id":"29c1994e11af7260afc15233563c151bf1d4e6aa","user":{"login":"WouterJ","id":749025,"avatar_url":"https://gravatar.com/avatar/331582449435f5efa35be870ab76f1a9?d=https%3A%2F%2Fidenticons.github.com%2Fcad34e5c3d17a170a47cbd06fe684d6b.png&r=x","gravatar_id":"331582449435f5efa35be870ab76f1a9","url":"https://api.github.com/users/WouterJ","html_url":"https://github.com/WouterJ","followers_url":"https://api.github.com/users/WouterJ/followers","following_url":"https://api.github.com/users/WouterJ/following{/other_user}","gists_url":"https://api.github.com/users/WouterJ/gists{/gist_id}","starred_url":"https://api.github.com/users/WouterJ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WouterJ/subscriptions","organizations_url":"https://api.github.com/users/WouterJ/orgs","repos_url":"https://api.github.com/users/WouterJ/repos","events_url":"https://api.github.com/users/WouterJ/events{/privacy}","received_events_url":"https://api.github.com/users/WouterJ/received_events","type":"User","site_admin":false},"body":"we always use `isGranted()` (including parenthesis) ","created_at":"2013-12-14T22:41:33Z","updated_at":"2013-12-14T22:41:33Z","html_url":"https://github.com/symfony/symfony-docs/pull/3339#discussion_r8353366","pull_request_url":"https://api.github.com/repos/symfony/symfony-docs/pulls/3339","_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony-docs/pulls/comments/8353366"},"html":{"href":"https://github.com/symfony/symfony-docs/pull/3339#discussion_r8353366"},"pull_request":{"href":"https://api.github.com/repos/symfony/symfony-docs/pulls/3339"}}}} | {
"id": 521583,
"name": "symfony-docs",
"url": "https://github.com/symfony/symfony-docs"
} | {
"id": null,
"login": "WouterJ",
"gravatar_id": "331582449435f5efa35be870ab76f1a9",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "symfony",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-12-14T22:41:33 | null | {"repository":{"description":"The Symfony2 documentation","homepage":"http://symfony.com/doc/current/","watchers":864,"stargazers":864,"forks":1128,"fork":false,"size":23960,"owner":"symfony","private":false,"open_issues":193,"has_issues":true,"has_downloads":false,"has_wiki":false,"language":"Lasso","created_at":"2010-02-17T00:43:51-08:00","pushed_at":"2013-12-11T22:13:32-08:00","master_branch":"master","organization":"symfony"},"actor_attributes":{"type":"User","name":"Wouter J","blog":"http://wouterj.nl","location":"Netherlands","email":"[email protected]"},"url":"https://github.com/symfony/symfony-docs/pull/3339#discussion_r8353366"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/symfony/symfony/pulls/comments/8553812","id":8553812,"diff_hunk":"@@ -25,6 +25,47 @@\n abstract class FileDumper implements DumperInterface\n {\n /**\n+ * A template for the relative paths to files.\n+ *\n+ * @var string\n+ */\n+ private $relativePathTemplate;\n+\n+ /**\n+ * Creates a new file dumper.\n+ *\n+ * @param string $relativePathTemplate A template for the relative paths to files\n+ */\n+ public function __construct($relativePathTemplate = '{domain}.{locale}.{extension}')","path":"src/Symfony/Component/Translation/Dumper/FileDumper.php","position":15,"original_position":15,"commit_id":"a754fb8476d584dde1aad1879c2f24a1aac85696","original_commit_id":"a754fb8476d584dde1aad1879c2f24a1aac85696","user":{"login":"fabpot","id":47313,"avatar_url":"https://gravatar.com/avatar/f1a2c5905e121d09feba5ad73898ffca?d=https%3A%2F%2Fidenticons.github.com%2Fc84b270aa5893770d53468e5ccd5d512.png&r=x","gravatar_id":"f1a2c5905e121d09feba5ad73898ffca","url":"https://api.github.com/users/fabpot","html_url":"https://github.com/fabpot","followers_url":"https://api.github.com/users/fabpot/followers","following_url":"https://api.github.com/users/fabpot/following{/other_user}","gists_url":"https://api.github.com/users/fabpot/gists{/gist_id}","starred_url":"https://api.github.com/users/fabpot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabpot/subscriptions","organizations_url":"https://api.github.com/users/fabpot/orgs","repos_url":"https://api.github.com/users/fabpot/repos","events_url":"https://api.github.com/users/fabpot/events{/privacy}","received_events_url":"https://api.github.com/users/fabpot/received_events","type":"User","site_admin":false},"body":"again, as it should be relatively rare, just being to change the default via the setter seems fine to me.","created_at":"2013-12-26T08:44:57Z","updated_at":"2013-12-26T08:44:57Z","html_url":"https://github.com/symfony/symfony/pull/9852#discussion_r8553812","pull_request_url":"https://api.github.com/repos/symfony/symfony/pulls/9852","_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments/8553812"},"html":{"href":"https://github.com/symfony/symfony/pull/9852#discussion_r8553812"},"pull_request":{"href":"https://api.github.com/repos/symfony/symfony/pulls/9852"}}}} | {
"id": 458058,
"name": "symfony",
"url": "https://github.com/symfony/symfony"
} | {
"id": null,
"login": "fabpot",
"gravatar_id": "f1a2c5905e121d09feba5ad73898ffca",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "symfony",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-12-26T08:44:57 | null | {"repository":{"description":"The Symfony PHP framework","homepage":"symfony.com","watchers":7526,"stargazers":7526,"forks":2779,"fork":false,"size":116163,"owner":"symfony","private":false,"open_issues":8,"has_issues":true,"has_downloads":false,"has_wiki":false,"language":"PHP","created_at":"2010-01-04T06:21:21-08:00","pushed_at":"2013-12-26T00:07:46-08:00","master_branch":"master","organization":"symfony"},"actor_attributes":{"type":"User","name":"Fabien Potencier","company":"SensioLabs","blog":"http://fabien.potencier.org/","location":"Paris, France","email":"[email protected]"},"url":"https://github.com/symfony/symfony/pull/9852#discussion_r8553812"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/symfony/symfony/pulls/comments/3188039","id":3188039,"body":"`Adapter \"%s\" does not exist.`.","diff_hunk":"@@ -97,12 +98,50 @@ public function addAdapter(Adapter\\AdapterInterface $adapter, $priority = 0)\n $this->adapters[$adapter->getName()] = array(\n 'adapter' => $adapter,\n 'priority' => $priority,\n+ 'selected' => false,\n );\n \n return $this->sortAdapters();\n }\n \n /**\n+ * Removes adapter selection adapter to use best one.\n+ *\n+ * @return Finder The current Finder instance\n+ */\n+ public function useBestAdapter()\n+ {\n+ $this->adapters = array_map(function (array $properties) {\n+ $properties['selected'] = false;\n+\n+ return $properties;\n+ }, $this->adapters);\n+\n+ return $this->sortAdapters();\n+ }\n+\n+ /**\n+ * Selects the adapter to use.\n+ *\n+ * @param string $name\n+ *\n+ * @throws \\InvalidArgumentException\n+ *\n+ * @return Finder The current Finder instance\n+ */\n+ public function setAdapter($name)\n+ {\n+ if (!isset($this->adapters[$name])) {\n+ throw new \\InvalidArgumentException(sprintf('There is no registered adapter with \"%s\" name.', $name));","path":"src/Symfony/Component/Finder/Finder.php","position":46,"original_position":46,"commit_id":"489b94b9f2ca2289d5f4b4cbd9686d8ed8f84da9","original_commit_id":"489b94b9f2ca2289d5f4b4cbd9686d8ed8f84da9","user":{"login":"fabpot","id":47313,"avatar_url":"https://secure.gravatar.com/avatar/f1a2c5905e121d09feba5ad73898ffca?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"f1a2c5905e121d09feba5ad73898ffca","url":"https://api.github.com/users/fabpot","html_url":"https://github.com/fabpot","followers_url":"https://api.github.com/users/fabpot/followers","following_url":"https://api.github.com/users/fabpot/following","gists_url":"https://api.github.com/users/fabpot/gists{/gist_id}","starred_url":"https://api.github.com/users/fabpot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabpot/subscriptions","organizations_url":"https://api.github.com/users/fabpot/orgs","repos_url":"https://api.github.com/users/fabpot/repos","events_url":"https://api.github.com/users/fabpot/events{/privacy}","received_events_url":"https://api.github.com/users/fabpot/received_events","type":"User"},"created_at":"2013-02-28T13:04:05Z","updated_at":"2013-02-28T13:04:05Z","_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments/3188039"},"html":{"href":"https://github.com/symfony/symfony/pull/7212#discussion_r3188039"},"pull_request":{"href":"https://api.github.com/repos/symfony/symfony/pulls/7212"}}}} | {
"id": 458058,
"name": "symfony",
"url": "https://github.com/symfony/symfony"
} | {
"id": null,
"login": "fabpot",
"gravatar_id": "f1a2c5905e121d09feba5ad73898ffca",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "symfony",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-02-28T13:04:05 | null | {"repository":{"description":"The Symfony PHP framework","homepage":"symfony.com","watchers":6219,"stargazers":6219,"forks":2066,"fork":false,"size":34872,"owner":"symfony","private":false,"open_issues":583,"has_issues":true,"has_downloads":false,"has_wiki":false,"language":"PHP","created_at":"2010-01-04T06:21:21-08:00","pushed_at":"2013-02-28T04:27:34-08:00","master_branch":"master","organization":"symfony"},"actor_attributes":{"type":"User","name":"Fabien Potencier","company":"SensioLabs","blog":"http://fabien.potencier.org/","location":"Paris, France","email":"[email protected]"},"url":"https://github.com/symfony/symfony/pull/7212#discussion_r3188039"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/symfony/symfony/pulls/comments/6109835","id":6109835,"body":"``#`` is an unfortunate choice IMO. It forces to enclose the string in quotes otherwise it is parsed as a comment (and it will be hard to debug in such case)","diff_hunk":"@@ -311,6 +312,8 @@ private function resolveServices($value)\n {\n if (is_array($value)) {\n $value = array_map(array($this, 'resolveServices'), $value);\n+ } elseif (is_string($value) && 0 === strpos($value, '#')) {","path":"src/Symfony/Component/DependencyInjection/Loader/YamlFileLoader.php","position":12,"original_position":12,"commit_id":"f4d7f53c0054bd4913eae4ce58a5d255e3120bca","original_commit_id":"f4d7f53c0054bd4913eae4ce58a5d255e3120bca","user":{"login":"stof","id":439401,"avatar_url":"https://0.gravatar.com/avatar/7894bbdf1c05b18a1444ad8c76c9d583?d=https%3A%2F%2Fidenticons.github.com%2Fd339b80a37d1fe7e96192364ab2d75fe.png","gravatar_id":"7894bbdf1c05b18a1444ad8c76c9d583","url":"https://api.github.com/users/stof","html_url":"https://github.com/stof","followers_url":"https://api.github.com/users/stof/followers","following_url":"https://api.github.com/users/stof/following{/other_user}","gists_url":"https://api.github.com/users/stof/gists{/gist_id}","starred_url":"https://api.github.com/users/stof/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stof/subscriptions","organizations_url":"https://api.github.com/users/stof/orgs","repos_url":"https://api.github.com/users/stof/repos","events_url":"https://api.github.com/users/stof/events{/privacy}","received_events_url":"https://api.github.com/users/stof/received_events","type":"User"},"created_at":"2013-09-02T12:25:49Z","updated_at":"2013-09-02T12:25:49Z","html_url":"https://github.com/symfony/symfony/pull/8913#discussion_r6109835","pull_request_url":"https://api.github.com/repos/symfony/symfony/pulls/8913","_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments/6109835"},"html":{"href":"https://github.com/symfony/symfony/pull/8913#discussion_r6109835"},"pull_request":{"href":"https://api.github.com/repos/symfony/symfony/pulls/8913"}}}} | {
"id": 458058,
"name": "symfony",
"url": "https://github.com/symfony/symfony"
} | {
"id": null,
"login": "stof",
"gravatar_id": "7894bbdf1c05b18a1444ad8c76c9d583",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "symfony",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-09-02T12:25:49 | null | {"repository":{"description":"The Symfony PHP framework","homepage":"symfony.com","watchers":7055,"stargazers":7055,"forks":2521,"fork":false,"size":49376,"owner":"symfony","private":false,"open_issues":692,"has_issues":true,"has_downloads":false,"has_wiki":false,"language":"PHP","created_at":"2010-01-04T06:21:21-08:00","pushed_at":"2013-08-31T04:26:09-07:00","master_branch":"master","organization":"symfony"},"actor_attributes":{"type":"User","name":"Christophe Coevoet","company":"Incenteev","location":"Paris","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/symfony/symfony/pull/8913#discussion_r6109835"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/symfony/symfony/pulls/comments/6320957","id":6320957,"body":"Did not find a better way to avoid a double registration.","diff_hunk":"@@ -0,0 +1,39 @@\n+<?php\n+\n+/*\n+ * This file is part of the Symfony package.\n+ *\n+ * (c) Fabien Potencier <[email protected]>\n+ *\n+ * For the full copyright and license information, please view the LICENSE\n+ * file that was distributed with this source code.\n+ */\n+\n+namespace Symfony\\Bundle\\FrameworkBundle\\DependencyInjection\\Compiler;\n+\n+use Symfony\\Component\\DependencyInjection\\Compiler\\CompilerPassInterface;\n+use Symfony\\Component\\DependencyInjection\\ContainerBuilder;\n+use Symfony\\Component\\DependencyInjection\\Definition;\n+use Symfony\\Component\\Finder\\Finder;\n+use Symfony\\Component\\HttpKernel\\Bundle\\Bundle;\n+\n+class CommandPass implements CompilerPassInterface\n+{\n+\n+ public function process(ContainerBuilder $container)\n+ {\n+ $commandServices = $container->findTaggedServiceIds('console.command');\n+\n+ foreach ($commandServices as $serviceId => $tag) {\n+ $class = $container->getParameterBag()->resolveValue($container->getDefinition($serviceId)->getClass());\n+ $r = new \\ReflectionClass($class);\n+ if (!$r->isSubclassOf('Symfony\\\\Component\\\\Console\\\\Command\\\\Command')) {\n+ throw new \\InvalidArgumentException(sprintf('The service \"%s\" tagged \"console.command\" must be a subclass of \"Symfony\\\\Component\\\\Console\\\\Command\\\\Command\"', $serviceId));\n+ }\n+ $alias = '__commands__.'.strtolower(str_replace('\\\\', '_', $class));\n+ $container->setAlias($alias, $serviceId);","path":"src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Compiler/CommandPass.php","position":34,"original_position":34,"commit_id":"7b1ffae604347d1ec6cb79c7e48724f1cbf35825","original_commit_id":"7b1ffae604347d1ec6cb79c7e48724f1cbf35825","user":{"login":"lyrixx","id":408368,"avatar_url":"https://0.gravatar.com/avatar/7602f2751868682b296171f58589c851?d=https%3A%2F%2Fidenticons.github.com%2Ff4d7577635a0a2695709d5afcd15f5ca.png","gravatar_id":"7602f2751868682b296171f58589c851","url":"https://api.github.com/users/lyrixx","html_url":"https://github.com/lyrixx","followers_url":"https://api.github.com/users/lyrixx/followers","following_url":"https://api.github.com/users/lyrixx/following{/other_user}","gists_url":"https://api.github.com/users/lyrixx/gists{/gist_id}","starred_url":"https://api.github.com/users/lyrixx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lyrixx/subscriptions","organizations_url":"https://api.github.com/users/lyrixx/orgs","repos_url":"https://api.github.com/users/lyrixx/repos","events_url":"https://api.github.com/users/lyrixx/events{/privacy}","received_events_url":"https://api.github.com/users/lyrixx/received_events","type":"User"},"created_at":"2013-09-12T13:12:39Z","updated_at":"2013-09-12T13:12:39Z","html_url":"https://github.com/symfony/symfony/pull/8940#discussion_r6320957","pull_request_url":"https://api.github.com/repos/symfony/symfony/pulls/8940","_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments/6320957"},"html":{"href":"https://github.com/symfony/symfony/pull/8940#discussion_r6320957"},"pull_request":{"href":"https://api.github.com/repos/symfony/symfony/pulls/8940"}}}} | {
"id": 458058,
"name": "symfony",
"url": "https://github.com/symfony/symfony"
} | {
"id": null,
"login": "lyrixx",
"gravatar_id": "7602f2751868682b296171f58589c851",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "symfony",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-09-12T13:12:39 | null | {"repository":{"description":"The Symfony PHP framework","homepage":"symfony.com","watchers":7085,"stargazers":7085,"forks":2528,"fork":false,"size":103711,"owner":"symfony","private":false,"open_issues":682,"has_issues":true,"has_downloads":false,"has_wiki":false,"language":"PHP","created_at":"2010-01-04T06:21:21-08:00","pushed_at":"2013-09-12T05:59:59-07:00","master_branch":"master","organization":"symfony"},"actor_attributes":{"type":"User","name":"Grégoire Pineau","company":"SensioLabs","blog":"http://blog.lyrixx.info","location":"Paris","email":"[email protected]"},"url":"https://github.com/symfony/symfony/pull/8940#discussion_r6320957"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/symfony/symfony-docs/pulls/comments/7396308","id":7396308,"diff_hunk":"@@ -642,14 +642,14 @@ Don't forget also to update your database schema:\n \n php app/console doctrine:schema:update --force\n \n-This will create the ``acme_role`` table and a ``user_role`` that stores\n-the many-to-many relationship between ``acme_user`` and ``acme_role``. If\n+This will create the ``acme_roles`` table and a ``user_role`` that stores\n+the many-to-many relationship between ``acme_users`` and ``acme_roles``. If\n you had one user linked to one role, your database might look something like\n this:\n \n .. code-block:: text\n \n- $ mysql> select * from acme_role;\n+ $ mysql> select * from acme_roles;","path":"cookbook/security/entity_provider.rst","position":14,"original_position":14,"commit_id":"f5a201d5613a7303c4e220e8bbabb55fb0b9256c","original_commit_id":"f5a201d5613a7303c4e220e8bbabb55fb0b9256c","user":{"login":"xabbuh","id":1957048,"avatar_url":"https://0.gravatar.com/avatar/b5fe043ff5cd47b3b35d95e78fce5539?d=https%3A%2F%2Fidenticons.github.com%2F9783d5b0ef8edb092e0779a155cfa8c0.png&r=x","gravatar_id":"b5fe043ff5cd47b3b35d95e78fce5539","url":"https://api.github.com/users/xabbuh","html_url":"https://github.com/xabbuh","followers_url":"https://api.github.com/users/xabbuh/followers","following_url":"https://api.github.com/users/xabbuh/following{/other_user}","gists_url":"https://api.github.com/users/xabbuh/gists{/gist_id}","starred_url":"https://api.github.com/users/xabbuh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xabbuh/subscriptions","organizations_url":"https://api.github.com/users/xabbuh/orgs","repos_url":"https://api.github.com/users/xabbuh/repos","events_url":"https://api.github.com/users/xabbuh/events{/privacy}","received_events_url":"https://api.github.com/users/xabbuh/received_events","type":"User","site_admin":false},"body":":+1: for singular names for this is the default behaviour if you don't set the table name explicitly.","created_at":"2013-11-04T10:01:01Z","updated_at":"2013-11-04T10:01:01Z","html_url":"https://github.com/symfony/symfony-docs/pull/3116#discussion_r7396308","pull_request_url":"https://api.github.com/repos/symfony/symfony-docs/pulls/3116","_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony-docs/pulls/comments/7396308"},"html":{"href":"https://github.com/symfony/symfony-docs/pull/3116#discussion_r7396308"},"pull_request":{"href":"https://api.github.com/repos/symfony/symfony-docs/pulls/3116"}}}} | {
"id": 521583,
"name": "symfony-docs",
"url": "https://github.com/symfony/symfony-docs"
} | {
"id": null,
"login": "xabbuh",
"gravatar_id": "b5fe043ff5cd47b3b35d95e78fce5539",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "symfony",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-11-04T10:01:01 | null | {"repository":{"description":"The Symfony2 documentation","homepage":"http://symfony.com/doc/current/","watchers":856,"stargazers":856,"forks":1061,"fork":false,"size":22380,"owner":"symfony","private":false,"open_issues":137,"has_issues":true,"has_downloads":false,"has_wiki":false,"language":"Lasso","created_at":"2010-02-17T00:43:51-08:00","pushed_at":"2013-11-03T12:39:36-08:00","master_branch":"master","organization":"symfony"},"actor_attributes":{"type":"User","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/symfony/symfony-docs/pull/3116#discussion_r7396308"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/symfony/symfony-docs/pulls/comments/3260271","id":3260271,"body":"use double backtricks around `*` to create an inline code block","diff_hunk":"@@ -952,6 +952,26 @@ should render with the subdirectory (e.g. ``/my_app/images/logo.png``). The\n ``asset`` function takes care of this by determining how your application is\n being used and generating the correct paths accordingly.\n \n+.. tip::\n+ \n+ .. versionadded:: 2.3.0\n+ Regex css and js matching added\n+\n+ You also can match js or css file with *, the first matched asset file will be included.","path":"book/templating.rst","position":9,"original_position":9,"commit_id":"f20095103241e6736d00cf1e92bc48a0ffd4d819","original_commit_id":"f20095103241e6736d00cf1e92bc48a0ffd4d819","user":{"login":"WouterJ","id":749025,"avatar_url":"https://secure.gravatar.com/avatar/331582449435f5efa35be870ab76f1a9?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"331582449435f5efa35be870ab76f1a9","url":"https://api.github.com/users/WouterJ","html_url":"https://github.com/WouterJ","followers_url":"https://api.github.com/users/WouterJ/followers","following_url":"https://api.github.com/users/WouterJ/following","gists_url":"https://api.github.com/users/WouterJ/gists{/gist_id}","starred_url":"https://api.github.com/users/WouterJ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WouterJ/subscriptions","organizations_url":"https://api.github.com/users/WouterJ/orgs","repos_url":"https://api.github.com/users/WouterJ/repos","events_url":"https://api.github.com/users/WouterJ/events{/privacy}","received_events_url":"https://api.github.com/users/WouterJ/received_events","type":"User"},"created_at":"2013-03-06T12:32:26Z","updated_at":"2013-03-06T12:32:26Z","_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony-docs/pulls/comments/3260271"},"html":{"href":"https://github.com/symfony/symfony-docs/pull/2276#discussion_r3260271"},"pull_request":{"href":"https://api.github.com/repos/symfony/symfony-docs/pulls/2276"}}}} | {
"id": 521583,
"name": "symfony-docs",
"url": "https://github.com/symfony/symfony-docs"
} | {
"id": null,
"login": "WouterJ",
"gravatar_id": "331582449435f5efa35be870ab76f1a9",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "symfony",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-03-06T12:32:26 | null | {"repository":{"description":"The Symfony2 documentation","homepage":"http://symfony.com/doc/current/","watchers":813,"stargazers":813,"forks":738,"fork":false,"size":1980,"owner":"symfony","private":false,"open_issues":128,"has_issues":true,"has_downloads":false,"has_wiki":false,"created_at":"2010-02-17T00:43:51-08:00","pushed_at":"2013-03-03T18:10:43-08:00","master_branch":"master","organization":"symfony"},"actor_attributes":{"type":"User","name":"Wouter J","blog":"http://wouterj.nl","location":"Netherlands","email":"[email protected]"},"url":"https://github.com/symfony/symfony-docs/pull/2276#discussion_r3260271"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/symfony/symfony/pulls/comments/3150449","id":3150449,"body":"allright my liege :)","diff_hunk":"@@ -38,4 +39,20 @@ public function current()\n {\n return new SplFileInfo(parent::current()->getPathname(), $this->getSubPath(), $this->getSubPathname());\n }\n+\n+ /**\n+ * @return mixed object\n+ *\n+ * @throws AccessDeniedException\n+ */\n+ public function getChildren()\n+ {\n+ // Seems like a hack, but the purpose is to turn the \\UnexpectedValueException thrown by the\n+ // \\RecursiveDirectoryIterator if directory is not 'opnable' into an AccessDeniedException.","path":"src/Symfony/Component/Finder/Iterator/RecursiveDirectoryIterator.php","position":null,"original_position":21,"commit_id":"f9fd0e3ea5276571af6713fc9d92810402cc4da2","original_commit_id":"0582fb99e9596193e74e31a042f3eea8f9acd49f","user":{"login":"jfsimon","id":119407,"avatar_url":"https://secure.gravatar.com/avatar/a5806f8779978cc2f1ee20f66e4b5948?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"a5806f8779978cc2f1ee20f66e4b5948","url":"https://api.github.com/users/jfsimon","html_url":"https://github.com/jfsimon","followers_url":"https://api.github.com/users/jfsimon/followers","following_url":"https://api.github.com/users/jfsimon/following","gists_url":"https://api.github.com/users/jfsimon/gists{/gist_id}","starred_url":"https://api.github.com/users/jfsimon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jfsimon/subscriptions","organizations_url":"https://api.github.com/users/jfsimon/orgs","repos_url":"https://api.github.com/users/jfsimon/repos","events_url":"https://api.github.com/users/jfsimon/events{/privacy}","received_events_url":"https://api.github.com/users/jfsimon/received_events","type":"User"},"created_at":"2013-02-26T10:14:12Z","updated_at":"2013-02-26T10:14:12Z","_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments/3150449"},"html":{"href":"https://github.com/symfony/symfony/pull/7050#discussion_r3150449"},"pull_request":{"href":"https://api.github.com/repos/symfony/symfony/pulls/7050"}}}} | {
"id": 458058,
"name": "symfony",
"url": "https://github.com/symfony/symfony"
} | {
"id": null,
"login": "jfsimon",
"gravatar_id": "a5806f8779978cc2f1ee20f66e4b5948",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "symfony",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-02-26T10:14:12 | null | {"repository":{"description":"The Symfony PHP framework","homepage":"symfony.com","watchers":6211,"stargazers":6211,"forks":2057,"fork":false,"size":34984,"owner":"symfony","private":false,"open_issues":575,"has_issues":true,"has_downloads":false,"has_wiki":false,"language":"PHP","created_at":"2010-01-04T06:21:21-08:00","pushed_at":"2013-02-26T01:42:16-08:00","master_branch":"master","organization":"symfony"},"actor_attributes":{"type":"User","name":"Jean-François Simon","company":"SensioLabs","blog":"http://www.jfsimon.fr","location":"Paris, France","email":"[email protected]"},"url":"https://github.com/symfony/symfony/pull/7050#discussion_r3150449"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/symfony/symfony-docs/pulls/comments/3887373","id":3887373,"body":"could you please change this to an api link?\r\n\r\n````rst\r\n:method:`Symfony\\\\Component\\\\Security\\\\....::supportsAttribute`\r\n````","diff_hunk":"@@ -100,6 +100,14 @@ and compare the IP address against a set of blacklisted IP addresses:\n That's it! The voter is done. The next step is to inject the voter into\n the security layer. This can be done easily through the service container.\n \n+.. tip::\n+\n+ The methods supportsAttribute() and supportsClass() are not being called","path":"cookbook/security/voters.rst","position":6,"original_position":6,"commit_id":"ce4f418093938f9325c9f92cd6830959abf93fd0","original_commit_id":"ce4f418093938f9325c9f92cd6830959abf93fd0","user":{"login":"WouterJ","id":749025,"avatar_url":"https://secure.gravatar.com/avatar/331582449435f5efa35be870ab76f1a9?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"331582449435f5efa35be870ab76f1a9","url":"https://api.github.com/users/WouterJ","html_url":"https://github.com/WouterJ","followers_url":"https://api.github.com/users/WouterJ/followers","following_url":"https://api.github.com/users/WouterJ/following","gists_url":"https://api.github.com/users/WouterJ/gists{/gist_id}","starred_url":"https://api.github.com/users/WouterJ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WouterJ/subscriptions","organizations_url":"https://api.github.com/users/WouterJ/orgs","repos_url":"https://api.github.com/users/WouterJ/repos","events_url":"https://api.github.com/users/WouterJ/events{/privacy}","received_events_url":"https://api.github.com/users/WouterJ/received_events","type":"User"},"created_at":"2013-04-21T15:42:17Z","updated_at":"2013-04-21T15:42:17Z","html_url":"https://github.com/symfony/symfony-docs/pull/2532#discussion_r3887373","pull_request_url":"https://api.github.com/repos/symfony/symfony-docs/pulls/2532","_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony-docs/pulls/comments/3887373"},"html":{"href":"https://github.com/symfony/symfony-docs/pull/2532#discussion_r3887373"},"pull_request":{"href":"https://api.github.com/repos/symfony/symfony-docs/pulls/2532"}}}} | {
"id": 521583,
"name": "symfony-docs",
"url": "https://github.com/symfony/symfony-docs"
} | {
"id": null,
"login": "WouterJ",
"gravatar_id": "331582449435f5efa35be870ab76f1a9",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "symfony",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-04-21T15:42:17 | null | {"repository":{"description":"The Symfony2 documentation","homepage":"http://symfony.com/doc/current/","watchers":822,"stargazers":822,"forks":814,"fork":false,"size":2320,"owner":"symfony","private":false,"open_issues":173,"has_issues":true,"has_downloads":false,"has_wiki":false,"language":"Lasso","created_at":"2010-02-17T00:43:51-08:00","pushed_at":"2013-04-21T08:24:18-07:00","master_branch":"master","organization":"symfony"},"actor_attributes":{"type":"User","name":"Wouter J","blog":"http://wouterj.nl","location":"Netherlands","email":"[email protected]"},"url":"https://github.com/symfony/symfony-docs/pull/2532#discussion_r3887373"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/sysapps/telephony/pulls/comments/4575937","id":4575937,"body":"Wrapping block level elements inside a `<p>` will result in invalid HTML. `<p>` can only contain text and inline elements (like span, strong, etc.). ","diff_hunk":"@@ -1496,22 +1500,22 @@\n </ol>\n </li>\n </ol>\n- <figure>\n+ <p><figure>\n <img src=\"images/inbound_call_state_diagram.gif\" alt=\n \"Inbound Call State Diagram\" title=\"Inbound Call State Diagram\">\n <figcaption>\n The figure depicts the most usual state transitions for received\n- calls:\n+ calls.\n </figcaption>\n- </figure>\n- <figure>\n- <img src=\"images/inbound_call_state_diagram.gif\" alt=\n+ </figure></p>\n+ <p><figure>\n+ <img src=\"images/outbound_call_state_diagram.gif\" alt=\n \"Inbound Call State Diagram\" title=\"Inbound Call State Diagram\">\n <figcaption>\n The figure depicts the most usual state transitions for dialed\n calls.\n </figcaption>\n- </figure>\n+ </figure></p>","path":"index.html","position":158,"original_position":158,"commit_id":"ddbd185d54522b75b0a9ab49e3f58c6815672b8f","original_commit_id":"ddbd185d54522b75b0a9ab49e3f58c6815672b8f","user":{"login":"marcoscaceres","id":870154,"avatar_url":"https://secure.gravatar.com/avatar/6ad0fc0ed3dd7dc144c557a225a78dbc?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"6ad0fc0ed3dd7dc144c557a225a78dbc","url":"https://api.github.com/users/marcoscaceres","html_url":"https://github.com/marcoscaceres","followers_url":"https://api.github.com/users/marcoscaceres/followers","following_url":"https://api.github.com/users/marcoscaceres/following{/other_user}","gists_url":"https://api.github.com/users/marcoscaceres/gists{/gist_id}","starred_url":"https://api.github.com/users/marcoscaceres/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcoscaceres/subscriptions","organizations_url":"https://api.github.com/users/marcoscaceres/orgs","repos_url":"https://api.github.com/users/marcoscaceres/repos","events_url":"https://api.github.com/users/marcoscaceres/events{/privacy}","received_events_url":"https://api.github.com/users/marcoscaceres/received_events","type":"User"},"created_at":"2013-06-06T19:39:31Z","updated_at":"2013-06-06T19:39:31Z","html_url":"https://github.com/sysapps/telephony/pull/76#discussion_r4575937","pull_request_url":"https://api.github.com/repos/sysapps/telephony/pulls/76","_links":{"self":{"href":"https://api.github.com/repos/sysapps/telephony/pulls/comments/4575937"},"html":{"href":"https://github.com/sysapps/telephony/pull/76#discussion_r4575937"},"pull_request":{"href":"https://api.github.com/repos/sysapps/telephony/pulls/76"}}}} | {
"id": 8797108,
"name": "telephony",
"url": "https://github.com/sysapps/telephony"
} | {
"id": null,
"login": "marcoscaceres",
"gravatar_id": "6ad0fc0ed3dd7dc144c557a225a78dbc",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "sysapps",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-06-06T19:39:31 | null | {"repository":{"description":"API to manage telephony calls","homepage":"http://www.w3.org/2012/sysapps/telephony/","watchers":3,"stargazers":3,"forks":6,"fork":false,"size":236,"owner":"sysapps","private":false,"open_issues":1,"has_issues":true,"has_downloads":true,"has_wiki":true,"created_at":"2013-03-15T03:49:49-07:00","pushed_at":"2013-06-06T08:17:05-07:00","master_branch":"gh-pages","organization":"sysapps"},"actor_attributes":{"type":"User","name":"Marcos Caceres","company":"Mozilla","blog":"http://marcosc.com","location":"Around the world, around the world...","email":"[email protected]"},"url":"https://github.com/sysapps/telephony/pull/76#discussion_r4575937"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/twitter/commons/pulls/comments/5518565","id":5518565,"body":"Also, please be consistent about single and double quotes.","diff_hunk":"@@ -17,30 +17,40 @@ limitations under the License.\n -->\n \n <html>\n- <title>Logger Config</title>\n- <body>\n- <form action='' method='post'>\n- <select name='logger'>\n- $loggers:{<option value='$it.name$'>$it.name$}$\n- </select>\n- <select name='level'>\n- $levels:{<option value='$it$'>$it$}$\n- </select>\n- <input type='submit' value='Go'>\n- </form>\n-\n- $if(configChange)$\n- <br />\n- <i>$configChange$</i>\n- <br />\n- $endif$\n-\n- <table border=1 cellpadding=0 cellspacing=0 align=left>\n- <tr>\n- <th>Logger</th>\n- <th>Level</th>\n- </tr>\n- $loggers:{<tr><td>$it.name$</td><td>$it.level$</td></tr>}$\n- </table>\n- </body>\n+ <title>Logger Config </title>\n+ <body>\n+ <script src=\"http://ajax.googleapis.com/ajax/libs/jquery/1.10.1/jquery.min.js\"></script>\n+ <table border=1 cellpadding=0 cellspacing=0 align=left>\n+ <tr>\n+\t <th>Logger</th>\n+ <th>Level</th>\n+ </tr>\n+ $loggers:{ logger | \n+ <tr>\n+ <td>\n+ $logger.name$\n+ </td>\n+ <td>\n+ <select id = \"$logger.name$\" name='level' class = 'selectlevels' data-loglevel = \"$logger.level$\">","path":"src/resources/com/twitter/common/net/http/handlers/logconfig.st","position":44,"original_position":44,"commit_id":"dd2cec904b17354b0481e7abe2f4dd4e06aebea9","original_commit_id":"dd2cec904b17354b0481e7abe2f4dd4e06aebea9","user":{"login":"wfarner","id":422563,"avatar_url":"https://secure.gravatar.com/avatar/359afee74ee2d0e8d5f0f75029908184?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"359afee74ee2d0e8d5f0f75029908184","url":"https://api.github.com/users/wfarner","html_url":"https://github.com/wfarner","followers_url":"https://api.github.com/users/wfarner/followers","following_url":"https://api.github.com/users/wfarner/following{/other_user}","gists_url":"https://api.github.com/users/wfarner/gists{/gist_id}","starred_url":"https://api.github.com/users/wfarner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wfarner/subscriptions","organizations_url":"https://api.github.com/users/wfarner/orgs","repos_url":"https://api.github.com/users/wfarner/repos","events_url":"https://api.github.com/users/wfarner/events{/privacy}","received_events_url":"https://api.github.com/users/wfarner/received_events","type":"User"},"created_at":"2013-07-31T23:02:03Z","updated_at":"2013-07-31T23:02:03Z","html_url":"https://github.com/twitter/commons/pull/164#discussion_r5518565","pull_request_url":"https://api.github.com/repos/twitter/commons/pulls/164","_links":{"self":{"href":"https://api.github.com/repos/twitter/commons/pulls/comments/5518565"},"html":{"href":"https://github.com/twitter/commons/pull/164#discussion_r5518565"},"pull_request":{"href":"https://api.github.com/repos/twitter/commons/pulls/164"}}}} | {
"id": 1424005,
"name": "commons",
"url": "https://github.com/twitter/commons"
} | {
"id": null,
"login": "wfarner",
"gravatar_id": "359afee74ee2d0e8d5f0f75029908184",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "twitter",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-07-31T23:02:03 | null | {"repository":{"description":"Twitter common libraries for python and the JVM","homepage":"http://twitter.github.com/commons","watchers":550,"stargazers":550,"forks":120,"fork":false,"size":110344,"owner":"twitter","private":false,"open_issues":22,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Java","created_at":"2011-02-28T16:10:02-08:00","pushed_at":"2013-07-29T15:56:40-07:00","master_branch":"master","organization":"twitter"},"actor_attributes":{"type":"User","name":"Bill Farner","company":"Twitter","location":"San Francisco, CA","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/twitter/commons/pull/164#discussion_r5518565"} |
PullRequestReviewCommentEvent | true | {"comment":{"user":{"received_events_url":"https://api.github.com/users/mariusaeriksen/received_events","organizations_url":"https://api.github.com/users/mariusaeriksen/orgs","repos_url":"https://api.github.com/users/mariusaeriksen/repos","avatar_url":"https://secure.gravatar.com/avatar/0be8dfe28d138dcd76466b47df2fb8d0?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"0be8dfe28d138dcd76466b47df2fb8d0","type":"User","login":"mariusaeriksen","followers_url":"https://api.github.com/users/mariusaeriksen/followers","id":32104,"events_url":"https://api.github.com/users/mariusaeriksen/events{/privacy}","subscriptions_url":"https://api.github.com/users/mariusaeriksen/subscriptions","url":"https://api.github.com/users/mariusaeriksen","starred_url":"https://api.github.com/users/mariusaeriksen/starred{/owner}{/repo}","following_url":"https://api.github.com/users/mariusaeriksen/following","gists_url":"https://api.github.com/users/mariusaeriksen/gists{/gist_id}"},"path":"util-core/src/main/scala/com/twitter/util/Timer.scala","created_at":"2013-01-14T17:50:54Z","body":"this import is redundant.","_links":{"pull_request":{"href":"https://api.github.com/repos/twitter/util/pulls/51"},"html":{"href":"https://github.com/twitter/util/pull/51#discussion_r2637925"},"self":{"href":"https://api.github.com/repos/twitter/util/pulls/comments/2637925"}},"id":2637925,"original_commit_id":"e978154179d35984277fe7fbb10723e39b206a3e","updated_at":"2013-01-14T17:50:54Z","url":"https://api.github.com/repos/twitter/util/pulls/comments/2637925","position":8,"commit_id":"e978154179d35984277fe7fbb10723e39b206a3e","original_position":8}} | {
"id": 1527969,
"name": "util",
"url": "https://github.com/twitter/util"
} | {
"id": null,
"login": "mariusaeriksen",
"gravatar_id": "0be8dfe28d138dcd76466b47df2fb8d0",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "twitter",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-01-14T17:50:54 | null | {"repository":{"watchers":416,"owner":"twitter","has_issues":true,"pushed_at":"2013-01-11T10:40:02-08:00","description":"Wonderful reusable code from Twitter","stargazers":416,"forks":75,"organization":"twitter","language":"Scala","has_downloads":true,"fork":false,"size":312,"created_at":"2011-03-25T18:23:21-07:00","open_issues":10,"has_wiki":true,"private":false,"homepage":"http://twitter.github.com/util"},"actor_attributes":{"blog":"http://monkey.org/~marius/","type":"User","email":"[email protected]","location":"sf, ca","name":"marius a. eriksen","company":"twitter"},"url":"https://github.com/twitter/util/pull/51#discussion_r2637925"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/twitter/summingbird/pulls/comments/7713473","id":7713473,"diff_hunk":"@@ -44,14 +43,27 @@ import java.util.{ Map => JMap }\n * effectively pushing back against latency bumps in the host.\n *\n * The allowed latency before a future is forced is equal to\n- * (MaxWaitingFutures * execute latency).\n+ * (MaxWaitingFutures * execute la`tency).","path":"summingbird-storm/src/main/scala/com/twitter/summingbird/storm/SummerBolt.scala","position":24,"original_position":24,"commit_id":"d26e3a01bd03f096779e277d8ce38a9180e05dcb","original_commit_id":"d26e3a01bd03f096779e277d8ce38a9180e05dcb","user":{"login":"ianoc","id":446652,"avatar_url":"https://1.gravatar.com/avatar/36ce3c50fa3c11de597342acef7d93af?d=https%3A%2F%2Fidenticons.github.com%2F50b82611bc4f275a8bd4a38d2ebaa89a.png&r=x","gravatar_id":"36ce3c50fa3c11de597342acef7d93af","url":"https://api.github.com/users/ianoc","html_url":"https://github.com/ianoc","followers_url":"https://api.github.com/users/ianoc/followers","following_url":"https://api.github.com/users/ianoc/following{/other_user}","gists_url":"https://api.github.com/users/ianoc/gists{/gist_id}","starred_url":"https://api.github.com/users/ianoc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ianoc/subscriptions","organizations_url":"https://api.github.com/users/ianoc/orgs","repos_url":"https://api.github.com/users/ianoc/repos","events_url":"https://api.github.com/users/ianoc/events{/privacy}","received_events_url":"https://api.github.com/users/ianoc/received_events","type":"User","site_admin":false},"body":"typo?","created_at":"2013-11-17T18:15:18Z","updated_at":"2013-11-17T18:15:18Z","html_url":"https://github.com/twitter/summingbird/pull/365#discussion_r7713473","pull_request_url":"https://api.github.com/repos/twitter/summingbird/pulls/365","_links":{"self":{"href":"https://api.github.com/repos/twitter/summingbird/pulls/comments/7713473"},"html":{"href":"https://github.com/twitter/summingbird/pull/365#discussion_r7713473"},"pull_request":{"href":"https://api.github.com/repos/twitter/summingbird/pulls/365"}}}} | {
"id": 5957708,
"name": "summingbird",
"url": "https://github.com/twitter/summingbird"
} | {
"id": null,
"login": "ianoc",
"gravatar_id": "36ce3c50fa3c11de597342acef7d93af",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "twitter",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-11-17T18:15:18 | null | {"repository":{"description":"Streaming MapReduce with Scalding and Storm","homepage":"https://twitter.com/summingbird","watchers":576,"stargazers":576,"forks":77,"fork":false,"size":7416,"owner":"twitter","private":false,"open_issues":83,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Scala","created_at":"2012-09-25T15:38:35-07:00","pushed_at":"2013-11-15T21:24:25-08:00","master_branch":"develop","organization":"twitter"},"actor_attributes":{"type":"User","name":"Ian O'Connell","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/twitter/summingbird/pull/365#discussion_r7713473"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/twitter/zipkin/pulls/comments/5347130","id":5347130,"body":"you aren't checking whether cache.put has succeeded, is that ok?","diff_hunk":"@@ -0,0 +1,162 @@\n+package com.twitter.zipkin.storage.hbase.mapping\n+\n+import com.twitter.hbase.utils.{Retry, ThreadProvider}\n+import com.twitter.logging.Logger\n+import com.twitter.util.{Await, ExecutorServiceFuturePool, Future}\n+import com.twitter.zipkin.hbase.TableLayouts\n+import com.twitter.zipkin.storage.hbase.utils.{HBaseTable, IDGenerator, ByteBufferUtil}\n+import java.nio.ByteBuffer\n+import java.util.concurrent.ConcurrentHashMap\n+import org.apache.hadoop.hbase.client._\n+import org.apache.hadoop.hbase.util.Bytes\n+\n+trait Mapper[T <: Mapping] {\n+ val log = Logger.get(getClass.getName)\n+\n+ val mappingTable: HBaseTable\n+ val qualBytes: Array[Byte]\n+ val idGen: IDGenerator\n+ val parentId: Long\n+ val typeBytes: Array[Byte]\n+\n+\n+ private lazy val cache = new ConcurrentHashMap[ByteBuffer, T]()\n+ private lazy val pool = new ExecutorServiceFuturePool(ThreadProvider.defaultExecutor)\n+ private val emptyBytes: Array[Byte] = Array[Byte]()\n+\n+ /**\n+ * All implementations need to provide their own implementation that creates\n+ * whichever type of mapping is being generated.\n+ *\n+ * @param id The id of the mapping. A positive Long.\n+ * @param value The value that is being mapped to an id.\n+ * @return New Mapping object to represent id <-> value.\n+ */\n+ protected def createInternal(id: Long, value: Array[Byte]): T\n+\n+ /**\n+ * Get the mapping for a name.\n+ * @param name\n+ * @return\n+ */\n+ def get(name: String): Future[T] = {\n+ val normString = name.toLowerCase\n+ if (normString.equals(\"\")) {\n+ throw new Exception(\"Can't get empty string\")\n+ }\n+ get(ByteBuffer.wrap(Bytes.toBytes(normString)))\n+ }\n+\n+ def get(value: ByteBuffer): Future[T] = {\n+ val result = Retry(100) {\n+ val cachedOption: Option[Future[T]] = Option(cache.get(value)).map(Future.value)\n+\n+ val mapping: Future[T] = cachedOption.getOrElse {\n+ // Spin up a pool future here as we need to await fully to make sure that it's durable before returning.\n+ pool {\n+ val valueBytes: Array[Byte] = ByteBufferUtil.getBytesFromByteBuffer(value)\n+ val fromOrToHBase: Future[T] = getFromHBase(valueBytes).flatMap { mo =>\n+ mo match {\n+ // If there is already a mapping wrap the mapping in a future after putting it in the cache.\n+ case Some(mapping) => {\n+ cache.put(ByteBuffer.wrap(mapping.value), mapping)\n+ Future.value(mapping)\n+ }\n+ // If there was no mapping on HBase then try and create and store a new mapping.\n+ case None => createProposed(valueBytes).flatMap { pm => store(pm)}\n+ }\n+ }\n+ Await.result(fromOrToHBase)\n+ }\n+ }\n+ mapping\n+ }\n+ result\n+ }\n+\n+ def getAll: Future[Set[T]] = {\n+ val maxToLoad = 100000\n+ val scan = new Scan()\n+ scan.setMaxVersions(1)\n+ scan.setCaching(maxToLoad)\n+ scan.addColumn(TableLayouts.mappingForwardFamily, qualBytes)\n+ /*\n+ Yes turn on caching for a scan.\n+\n+ GASP!!!\n+\n+ This should be a small table and it will greatly help with\n+ creating more mappings if this is in cache.\n+ */\n+ scan.setCacheBlocks(true)\n+ mappingTable.scan(scan, maxToLoad).map { results =>\n+ val mappings = results.map(createFromResult)\n+ mappings.foreach { m => cache.put(ByteBuffer.wrap(m.value), m)}","path":"zipkin-hbase/src/main/scala/com/twitter/zipkin/storage/hbase/mapping/Mapper.scala","position":94,"original_position":94,"commit_id":"0c6f4b498239d74d348dcfe4790ff4387de91dae","original_commit_id":"0c6f4b498239d74d348dcfe4790ff4387de91dae","user":{"login":"mosesn","id":156562,"avatar_url":"https://secure.gravatar.com/avatar/7ead26d6d4d0eeaece9e66ce021871a1?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"7ead26d6d4d0eeaece9e66ce021871a1","url":"https://api.github.com/users/mosesn","html_url":"https://github.com/mosesn","followers_url":"https://api.github.com/users/mosesn/followers","following_url":"https://api.github.com/users/mosesn/following{/other_user}","gists_url":"https://api.github.com/users/mosesn/gists{/gist_id}","starred_url":"https://api.github.com/users/mosesn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mosesn/subscriptions","organizations_url":"https://api.github.com/users/mosesn/orgs","repos_url":"https://api.github.com/users/mosesn/repos","events_url":"https://api.github.com/users/mosesn/events{/privacy}","received_events_url":"https://api.github.com/users/mosesn/received_events","type":"User"},"created_at":"2013-07-23T15:03:49Z","updated_at":"2013-07-23T15:03:49Z","html_url":"https://github.com/twitter/zipkin/pull/274#discussion_r5347130","pull_request_url":"https://api.github.com/repos/twitter/zipkin/pulls/274","_links":{"self":{"href":"https://api.github.com/repos/twitter/zipkin/pulls/comments/5347130"},"html":{"href":"https://github.com/twitter/zipkin/pull/274#discussion_r5347130"},"pull_request":{"href":"https://api.github.com/repos/twitter/zipkin/pulls/274"}}}} | {
"id": 4576305,
"name": "zipkin",
"url": "https://github.com/twitter/zipkin"
} | {
"id": null,
"login": "mosesn",
"gravatar_id": "7ead26d6d4d0eeaece9e66ce021871a1",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "twitter",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-07-23T15:03:49 | null | {"repository":{"description":"Zipkin is a distributed tracing system","homepage":"http://twitter.github.com/zipkin","watchers":1079,"stargazers":1079,"forks":96,"fork":false,"size":3919,"owner":"twitter","private":false,"open_issues":30,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Scala","created_at":"2012-06-06T11:26:16-07:00","pushed_at":"2013-07-22T17:24:03-07:00","master_branch":"master","organization":"twitter"},"actor_attributes":{"type":"User","name":"Moses Nakamura","company":"Tumblr","location":"New York City","email":"[email protected]"},"url":"https://github.com/twitter/zipkin/pull/274#discussion_r5347130"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/twitter/storehaus/pulls/comments/3693612","id":3693612,"body":"I guess the next release is a binary incompatible one, so you can disregard. If you agree, we can just merge this now.","diff_hunk":"@@ -51,21 +51,34 @@ object FutureOps {\n }\n }\n \n- /** Given a Seq of equivalent Futures, return the first non-exceptional, unless all are exceptions */\n- def selectFirstSuccessfulTrial[T](futures: Seq[Future[T]]): Future[T] =\n+ /** Given a Seq of equivalent Futures, return the first\n+ * non-exceptional that passes the supplied predicate. If all\n+ * futures fail to succeed or pass the predicate, the final future\n+ * to complete will be returned. */\n+ def selectFirstSuccessfulTrial[T](futures: Seq[Future[T]])(pred: T => Boolean): Future[T] =","path":"storehaus-core/src/main/scala/com/twitter/storehaus/FutureOps.scala","position":10,"original_position":10,"commit_id":"ec066e9a60f0428b01e01c3323e8345d26f119dc","original_commit_id":"ec066e9a60f0428b01e01c3323e8345d26f119dc","user":{"login":"johnynek","id":67958,"avatar_url":"https://secure.gravatar.com/avatar/fa94a62940f16a371fdd3e6e8e12c3a1?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"fa94a62940f16a371fdd3e6e8e12c3a1","url":"https://api.github.com/users/johnynek","html_url":"https://github.com/johnynek","followers_url":"https://api.github.com/users/johnynek/followers","following_url":"https://api.github.com/users/johnynek/following","gists_url":"https://api.github.com/users/johnynek/gists{/gist_id}","starred_url":"https://api.github.com/users/johnynek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnynek/subscriptions","organizations_url":"https://api.github.com/users/johnynek/orgs","repos_url":"https://api.github.com/users/johnynek/repos","events_url":"https://api.github.com/users/johnynek/events{/privacy}","received_events_url":"https://api.github.com/users/johnynek/received_events","type":"User"},"created_at":"2013-04-08T13:11:17Z","updated_at":"2013-04-08T13:11:17Z","html_url":"https://github.com/twitter/storehaus/pull/75#discussion_r3693612","pull_request_url":"https://api.github.com/repos/twitter/storehaus/pulls/75","_links":{"self":{"href":"https://api.github.com/repos/twitter/storehaus/pulls/comments/3693612"},"html":{"href":"https://github.com/twitter/storehaus/pull/75#discussion_r3693612"},"pull_request":{"href":"https://api.github.com/repos/twitter/storehaus/pulls/75"}}}} | {
"id": 7762878,
"name": "storehaus",
"url": "https://github.com/twitter/storehaus"
} | {
"id": null,
"login": "johnynek",
"gravatar_id": "fa94a62940f16a371fdd3e6e8e12c3a1",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "twitter",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-04-08T13:11:17 | null | {"repository":{"description":"Storehaus is a library that makes it easy to work with asynchronous key value stores","homepage":"","watchers":76,"stargazers":76,"forks":2,"fork":false,"size":560,"owner":"twitter","private":false,"open_issues":22,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Scala","created_at":"2013-01-22T14:34:05-08:00","pushed_at":"2013-04-05T11:04:55-07:00","master_branch":"develop","organization":"twitter"},"actor_attributes":{"type":"User","name":"P. Oscar Boykin","company":"Twitter","blog":"http://pobox.com/~boykin","location":"San Francisco","email":"[email protected]"},"url":"https://github.com/twitter/storehaus/pull/75#discussion_r3693612"} |
Subsets and Splits