idx
int64 | func_before
string | Vulnerability Classification
string | vul
int64 | func_after
string | patch
string | CWE ID
string | lines_before
string | lines_after
string |
|---|---|---|---|---|---|---|---|---|
150,900 |
void WT_NoiseGenerator (S_WT_VOICE *pWTVoice, S_WT_INT_FRAME *pWTIntFrame)
{
EAS_PCM *pOutputBuffer;
EAS_I32 phaseInc;
EAS_I32 tmp0;
EAS_I32 tmp1;
EAS_I32 nInterpolatedSample;
EAS_I32 numSamples;
/* initialize some local variables */
numSamples = pWTIntFrame->numSamples;
if (numSamples <= 0) {
ALOGE("b/26366256");
return;
}
pOutputBuffer = pWTIntFrame->pAudioBuffer;
phaseInc = pWTIntFrame->frame.phaseIncrement;
/* get last two samples generated */
/*lint -e{704} <avoid divide for performance>*/
tmp0 = (EAS_I32) (pWTVoice->phaseAccum) >> 18;
/*lint -e{704} <avoid divide for performance>*/
tmp1 = (EAS_I32) (pWTVoice->loopEnd) >> 18;
/* generate a buffer of noise */
while (numSamples--) {
nInterpolatedSample = MULT_AUDIO_COEF( tmp0, (PHASE_ONE - pWTVoice->phaseFrac));
nInterpolatedSample += MULT_AUDIO_COEF( tmp1, pWTVoice->phaseFrac);
*pOutputBuffer++ = (EAS_PCM) nInterpolatedSample;
/* update PRNG */
pWTVoice->phaseFrac += (EAS_U32) phaseInc;
if (GET_PHASE_INT_PART(pWTVoice->phaseFrac)) {
tmp0 = tmp1;
pWTVoice->phaseAccum = pWTVoice->loopEnd;
pWTVoice->loopEnd = (5 * pWTVoice->loopEnd + 1);
tmp1 = (EAS_I32) (pWTVoice->loopEnd) >> 18;
pWTVoice->phaseFrac = GET_PHASE_FRAC_PART(pWTVoice->phaseFrac);
}
}
}
|
DoS Exec Code Overflow Mem. Corr.
| 1 |
void WT_NoiseGenerator (S_WT_VOICE *pWTVoice, S_WT_INT_FRAME *pWTIntFrame)
{
EAS_PCM *pOutputBuffer;
EAS_I32 phaseInc;
EAS_I32 tmp0;
EAS_I32 tmp1;
EAS_I32 nInterpolatedSample;
EAS_I32 numSamples;
/* initialize some local variables */
numSamples = pWTIntFrame->numSamples;
if (numSamples <= 0) {
ALOGE("b/26366256");
android_errorWriteLog(0x534e4554, "26366256");
return;
}
pOutputBuffer = pWTIntFrame->pAudioBuffer;
phaseInc = pWTIntFrame->frame.phaseIncrement;
/* get last two samples generated */
/*lint -e{704} <avoid divide for performance>*/
tmp0 = (EAS_I32) (pWTVoice->phaseAccum) >> 18;
/*lint -e{704} <avoid divide for performance>*/
tmp1 = (EAS_I32) (pWTVoice->loopEnd) >> 18;
/* generate a buffer of noise */
while (numSamples--) {
nInterpolatedSample = MULT_AUDIO_COEF( tmp0, (PHASE_ONE - pWTVoice->phaseFrac));
nInterpolatedSample += MULT_AUDIO_COEF( tmp1, pWTVoice->phaseFrac);
*pOutputBuffer++ = (EAS_PCM) nInterpolatedSample;
/* update PRNG */
pWTVoice->phaseFrac += (EAS_U32) phaseInc;
if (GET_PHASE_INT_PART(pWTVoice->phaseFrac)) {
tmp0 = tmp1;
pWTVoice->phaseAccum = pWTVoice->loopEnd;
pWTVoice->loopEnd = (5 * pWTVoice->loopEnd + 1);
tmp1 = (EAS_I32) (pWTVoice->loopEnd) >> 18;
pWTVoice->phaseFrac = GET_PHASE_FRAC_PART(pWTVoice->phaseFrac);
}
}
}
|
@@ -33,6 +33,7 @@
*------------------------------------
*/
#include "log/log.h"
+#include <cutils/log.h>
#include "eas_types.h"
#include "eas_math.h"
@@ -92,6 +93,7 @@
numSamples = pWTIntFrame->numSamples;
if (numSamples <= 0) {
ALOGE("b/26366256");
+ android_errorWriteLog(0x534e4554, "26366256");
return;
}
pMixBuffer = pWTIntFrame->pMixBuffer;
@@ -190,6 +192,7 @@
numSamples = pWTIntFrame->numSamples;
if (numSamples <= 0) {
ALOGE("b/26366256");
+ android_errorWriteLog(0x534e4554, "26366256");
return;
}
pOutputBuffer = pWTIntFrame->pAudioBuffer;
@@ -287,6 +290,7 @@
numSamples = pWTIntFrame->numSamples;
if (numSamples <= 0) {
ALOGE("b/26366256");
+ android_errorWriteLog(0x534e4554, "26366256");
return;
}
pOutputBuffer = pWTIntFrame->pAudioBuffer;
@@ -379,6 +383,7 @@
numSamples = pWTIntFrame->numSamples;
if (numSamples <= 0) {
ALOGE("b/26366256");
+ android_errorWriteLog(0x534e4554, "26366256");
return;
}
pAudioBuffer = pWTIntFrame->pAudioBuffer;
@@ -446,6 +451,7 @@
numSamples = pWTIntFrame->numSamples;
if (numSamples <= 0) {
ALOGE("b/26366256");
+ android_errorWriteLog(0x534e4554, "26366256");
return;
}
pOutputBuffer = pWTIntFrame->pAudioBuffer;
@@ -593,6 +599,7 @@
numSamples = pWTIntFrame->numSamples;
if (numSamples <= 0) {
ALOGE("b/26366256");
+ android_errorWriteLog(0x534e4554, "26366256");
return;
}
pMixBuffer = pWTIntFrame->pMixBuffer;
|
CWE-119
| null |
android_errorWriteLog(0x534e4554, "26366256");
|
150,901 |
void WT_VoiceFilter (S_FILTER_CONTROL *pFilter, S_WT_INT_FRAME *pWTIntFrame)
{
EAS_PCM *pAudioBuffer;
EAS_I32 k;
EAS_I32 b1;
EAS_I32 b2;
EAS_I32 z1;
EAS_I32 z2;
EAS_I32 acc0;
EAS_I32 acc1;
EAS_I32 numSamples;
/* initialize some local variables */
numSamples = pWTIntFrame->numSamples;
if (numSamples <= 0) {
ALOGE("b/26366256");
return;
}
pAudioBuffer = pWTIntFrame->pAudioBuffer;
z1 = pFilter->z1;
z2 = pFilter->z2;
b1 = -pWTIntFrame->frame.b1;
/*lint -e{702} <avoid divide> */
b2 = -pWTIntFrame->frame.b2 >> 1;
/*lint -e{702} <avoid divide> */
k = pWTIntFrame->frame.k >> 1;
while (numSamples--)
{
/* do filter calculations */
acc0 = *pAudioBuffer;
acc1 = z1 * b1;
acc1 += z2 * b2;
acc0 = acc1 + k * acc0;
z2 = z1;
/*lint -e{702} <avoid divide> */
z1 = acc0 >> 14;
*pAudioBuffer++ = (EAS_I16) z1;
}
/* save delay values */
pFilter->z1 = (EAS_I16) z1;
pFilter->z2 = (EAS_I16) z2;
}
|
DoS Exec Code Overflow Mem. Corr.
| 1 |
void WT_VoiceFilter (S_FILTER_CONTROL *pFilter, S_WT_INT_FRAME *pWTIntFrame)
{
EAS_PCM *pAudioBuffer;
EAS_I32 k;
EAS_I32 b1;
EAS_I32 b2;
EAS_I32 z1;
EAS_I32 z2;
EAS_I32 acc0;
EAS_I32 acc1;
EAS_I32 numSamples;
/* initialize some local variables */
numSamples = pWTIntFrame->numSamples;
if (numSamples <= 0) {
ALOGE("b/26366256");
android_errorWriteLog(0x534e4554, "26366256");
return;
}
pAudioBuffer = pWTIntFrame->pAudioBuffer;
z1 = pFilter->z1;
z2 = pFilter->z2;
b1 = -pWTIntFrame->frame.b1;
/*lint -e{702} <avoid divide> */
b2 = -pWTIntFrame->frame.b2 >> 1;
/*lint -e{702} <avoid divide> */
k = pWTIntFrame->frame.k >> 1;
while (numSamples--)
{
/* do filter calculations */
acc0 = *pAudioBuffer;
acc1 = z1 * b1;
acc1 += z2 * b2;
acc0 = acc1 + k * acc0;
z2 = z1;
/*lint -e{702} <avoid divide> */
z1 = acc0 >> 14;
*pAudioBuffer++ = (EAS_I16) z1;
}
/* save delay values */
pFilter->z1 = (EAS_I16) z1;
pFilter->z2 = (EAS_I16) z2;
}
|
@@ -33,6 +33,7 @@
*------------------------------------
*/
#include "log/log.h"
+#include <cutils/log.h>
#include "eas_types.h"
#include "eas_math.h"
@@ -92,6 +93,7 @@
numSamples = pWTIntFrame->numSamples;
if (numSamples <= 0) {
ALOGE("b/26366256");
+ android_errorWriteLog(0x534e4554, "26366256");
return;
}
pMixBuffer = pWTIntFrame->pMixBuffer;
@@ -190,6 +192,7 @@
numSamples = pWTIntFrame->numSamples;
if (numSamples <= 0) {
ALOGE("b/26366256");
+ android_errorWriteLog(0x534e4554, "26366256");
return;
}
pOutputBuffer = pWTIntFrame->pAudioBuffer;
@@ -287,6 +290,7 @@
numSamples = pWTIntFrame->numSamples;
if (numSamples <= 0) {
ALOGE("b/26366256");
+ android_errorWriteLog(0x534e4554, "26366256");
return;
}
pOutputBuffer = pWTIntFrame->pAudioBuffer;
@@ -379,6 +383,7 @@
numSamples = pWTIntFrame->numSamples;
if (numSamples <= 0) {
ALOGE("b/26366256");
+ android_errorWriteLog(0x534e4554, "26366256");
return;
}
pAudioBuffer = pWTIntFrame->pAudioBuffer;
@@ -446,6 +451,7 @@
numSamples = pWTIntFrame->numSamples;
if (numSamples <= 0) {
ALOGE("b/26366256");
+ android_errorWriteLog(0x534e4554, "26366256");
return;
}
pOutputBuffer = pWTIntFrame->pAudioBuffer;
@@ -593,6 +599,7 @@
numSamples = pWTIntFrame->numSamples;
if (numSamples <= 0) {
ALOGE("b/26366256");
+ android_errorWriteLog(0x534e4554, "26366256");
return;
}
pMixBuffer = pWTIntFrame->pMixBuffer;
|
CWE-119
| null |
android_errorWriteLog(0x534e4554, "26366256");
|
150,902 |
void WT_VoiceGain (S_WT_VOICE *pWTVoice, S_WT_INT_FRAME *pWTIntFrame)
{
EAS_I32 *pMixBuffer;
EAS_PCM *pInputBuffer;
EAS_I32 gain;
EAS_I32 gainIncrement;
EAS_I32 tmp0;
EAS_I32 tmp1;
EAS_I32 tmp2;
EAS_I32 numSamples;
#if (NUM_OUTPUT_CHANNELS == 2)
EAS_I32 gainLeft, gainRight;
#endif
/* initialize some local variables */
numSamples = pWTIntFrame->numSamples;
if (numSamples <= 0) {
ALOGE("b/26366256");
return;
}
pMixBuffer = pWTIntFrame->pMixBuffer;
pInputBuffer = pWTIntFrame->pAudioBuffer;
/*lint -e{703} <avoid multiply for performance>*/
gainIncrement = (pWTIntFrame->frame.gainTarget - pWTIntFrame->prevGain) << (16 - SYNTH_UPDATE_PERIOD_IN_BITS);
if (gainIncrement < 0)
gainIncrement++;
/*lint -e{703} <avoid multiply for performance>*/
gain = pWTIntFrame->prevGain << 16;
#if (NUM_OUTPUT_CHANNELS == 2)
gainLeft = pWTVoice->gainLeft;
gainRight = pWTVoice->gainRight;
#endif
while (numSamples--) {
/* incremental gain step to prevent zipper noise */
tmp0 = *pInputBuffer++;
gain += gainIncrement;
/*lint -e{704} <avoid divide>*/
tmp2 = gain >> 16;
/* scale sample by gain */
tmp2 *= tmp0;
/* stereo output */
#if (NUM_OUTPUT_CHANNELS == 2)
/*lint -e{704} <avoid divide>*/
tmp2 = tmp2 >> 14;
/* get the current sample in the final mix buffer */
tmp1 = *pMixBuffer;
/* left channel */
tmp0 = tmp2 * gainLeft;
/*lint -e{704} <avoid divide>*/
tmp0 = tmp0 >> NUM_MIXER_GUARD_BITS;
tmp1 += tmp0;
*pMixBuffer++ = tmp1;
/* get the current sample in the final mix buffer */
tmp1 = *pMixBuffer;
/* right channel */
tmp0 = tmp2 * gainRight;
/*lint -e{704} <avoid divide>*/
tmp0 = tmp0 >> NUM_MIXER_GUARD_BITS;
tmp1 += tmp0;
*pMixBuffer++ = tmp1;
/* mono output */
#else
/* get the current sample in the final mix buffer */
tmp1 = *pMixBuffer;
/*lint -e{704} <avoid divide>*/
tmp2 = tmp2 >> (NUM_MIXER_GUARD_BITS - 1);
tmp1 += tmp2;
*pMixBuffer++ = tmp1;
#endif
}
}
|
DoS Exec Code Overflow Mem. Corr.
| 1 |
void WT_VoiceGain (S_WT_VOICE *pWTVoice, S_WT_INT_FRAME *pWTIntFrame)
{
EAS_I32 *pMixBuffer;
EAS_PCM *pInputBuffer;
EAS_I32 gain;
EAS_I32 gainIncrement;
EAS_I32 tmp0;
EAS_I32 tmp1;
EAS_I32 tmp2;
EAS_I32 numSamples;
#if (NUM_OUTPUT_CHANNELS == 2)
EAS_I32 gainLeft, gainRight;
#endif
/* initialize some local variables */
numSamples = pWTIntFrame->numSamples;
if (numSamples <= 0) {
ALOGE("b/26366256");
android_errorWriteLog(0x534e4554, "26366256");
return;
}
pMixBuffer = pWTIntFrame->pMixBuffer;
pInputBuffer = pWTIntFrame->pAudioBuffer;
/*lint -e{703} <avoid multiply for performance>*/
gainIncrement = (pWTIntFrame->frame.gainTarget - pWTIntFrame->prevGain) << (16 - SYNTH_UPDATE_PERIOD_IN_BITS);
if (gainIncrement < 0)
gainIncrement++;
/*lint -e{703} <avoid multiply for performance>*/
gain = pWTIntFrame->prevGain << 16;
#if (NUM_OUTPUT_CHANNELS == 2)
gainLeft = pWTVoice->gainLeft;
gainRight = pWTVoice->gainRight;
#endif
while (numSamples--) {
/* incremental gain step to prevent zipper noise */
tmp0 = *pInputBuffer++;
gain += gainIncrement;
/*lint -e{704} <avoid divide>*/
tmp2 = gain >> 16;
/* scale sample by gain */
tmp2 *= tmp0;
/* stereo output */
#if (NUM_OUTPUT_CHANNELS == 2)
/*lint -e{704} <avoid divide>*/
tmp2 = tmp2 >> 14;
/* get the current sample in the final mix buffer */
tmp1 = *pMixBuffer;
/* left channel */
tmp0 = tmp2 * gainLeft;
/*lint -e{704} <avoid divide>*/
tmp0 = tmp0 >> NUM_MIXER_GUARD_BITS;
tmp1 += tmp0;
*pMixBuffer++ = tmp1;
/* get the current sample in the final mix buffer */
tmp1 = *pMixBuffer;
/* right channel */
tmp0 = tmp2 * gainRight;
/*lint -e{704} <avoid divide>*/
tmp0 = tmp0 >> NUM_MIXER_GUARD_BITS;
tmp1 += tmp0;
*pMixBuffer++ = tmp1;
/* mono output */
#else
/* get the current sample in the final mix buffer */
tmp1 = *pMixBuffer;
/*lint -e{704} <avoid divide>*/
tmp2 = tmp2 >> (NUM_MIXER_GUARD_BITS - 1);
tmp1 += tmp2;
*pMixBuffer++ = tmp1;
#endif
}
}
|
@@ -33,6 +33,7 @@
*------------------------------------
*/
#include "log/log.h"
+#include <cutils/log.h>
#include "eas_types.h"
#include "eas_math.h"
@@ -92,6 +93,7 @@
numSamples = pWTIntFrame->numSamples;
if (numSamples <= 0) {
ALOGE("b/26366256");
+ android_errorWriteLog(0x534e4554, "26366256");
return;
}
pMixBuffer = pWTIntFrame->pMixBuffer;
@@ -190,6 +192,7 @@
numSamples = pWTIntFrame->numSamples;
if (numSamples <= 0) {
ALOGE("b/26366256");
+ android_errorWriteLog(0x534e4554, "26366256");
return;
}
pOutputBuffer = pWTIntFrame->pAudioBuffer;
@@ -287,6 +290,7 @@
numSamples = pWTIntFrame->numSamples;
if (numSamples <= 0) {
ALOGE("b/26366256");
+ android_errorWriteLog(0x534e4554, "26366256");
return;
}
pOutputBuffer = pWTIntFrame->pAudioBuffer;
@@ -379,6 +383,7 @@
numSamples = pWTIntFrame->numSamples;
if (numSamples <= 0) {
ALOGE("b/26366256");
+ android_errorWriteLog(0x534e4554, "26366256");
return;
}
pAudioBuffer = pWTIntFrame->pAudioBuffer;
@@ -446,6 +451,7 @@
numSamples = pWTIntFrame->numSamples;
if (numSamples <= 0) {
ALOGE("b/26366256");
+ android_errorWriteLog(0x534e4554, "26366256");
return;
}
pOutputBuffer = pWTIntFrame->pAudioBuffer;
@@ -593,6 +599,7 @@
numSamples = pWTIntFrame->numSamples;
if (numSamples <= 0) {
ALOGE("b/26366256");
+ android_errorWriteLog(0x534e4554, "26366256");
return;
}
pMixBuffer = pWTIntFrame->pMixBuffer;
|
CWE-119
| null |
android_errorWriteLog(0x534e4554, "26366256");
|
150,903 |
EAS_BOOL WT_CheckSampleEnd (S_WT_VOICE *pWTVoice, S_WT_INT_FRAME *pWTIntFrame, EAS_BOOL update)
{
EAS_U32 endPhaseAccum;
EAS_U32 endPhaseFrac;
EAS_I32 numSamples;
EAS_BOOL done = EAS_FALSE;
/* check to see if we hit the end of the waveform this time */
/*lint -e{703} use shift for performance */
endPhaseFrac = pWTVoice->phaseFrac + (pWTIntFrame->frame.phaseIncrement << SYNTH_UPDATE_PERIOD_IN_BITS);
endPhaseAccum = pWTVoice->phaseAccum + GET_PHASE_INT_PART(endPhaseFrac);
if (endPhaseAccum >= pWTVoice->loopEnd)
{
/* calculate how far current ptr is from end */
numSamples = (EAS_I32) (pWTVoice->loopEnd - pWTVoice->phaseAccum);
/* now account for the fractional portion */
/*lint -e{703} use shift for performance */
numSamples = (EAS_I32) ((numSamples << NUM_PHASE_FRAC_BITS) - pWTVoice->phaseFrac);
if (pWTIntFrame->frame.phaseIncrement) {
pWTIntFrame->numSamples = 1 + (numSamples / pWTIntFrame->frame.phaseIncrement);
} else {
pWTIntFrame->numSamples = numSamples;
}
if (pWTIntFrame->numSamples < 0) {
ALOGE("b/26366256");
pWTIntFrame->numSamples = 0;
}
/* sound will be done this frame */
done = EAS_TRUE;
}
/* update data for off-chip synth */
if (update)
{
pWTVoice->phaseFrac = endPhaseFrac;
pWTVoice->phaseAccum = endPhaseAccum;
}
return done;
}
|
DoS Exec Code Overflow Mem. Corr.
| 1 |
EAS_BOOL WT_CheckSampleEnd (S_WT_VOICE *pWTVoice, S_WT_INT_FRAME *pWTIntFrame, EAS_BOOL update)
{
EAS_U32 endPhaseAccum;
EAS_U32 endPhaseFrac;
EAS_I32 numSamples;
EAS_BOOL done = EAS_FALSE;
/* check to see if we hit the end of the waveform this time */
/*lint -e{703} use shift for performance */
endPhaseFrac = pWTVoice->phaseFrac + (pWTIntFrame->frame.phaseIncrement << SYNTH_UPDATE_PERIOD_IN_BITS);
endPhaseAccum = pWTVoice->phaseAccum + GET_PHASE_INT_PART(endPhaseFrac);
if (endPhaseAccum >= pWTVoice->loopEnd)
{
/* calculate how far current ptr is from end */
numSamples = (EAS_I32) (pWTVoice->loopEnd - pWTVoice->phaseAccum);
/* now account for the fractional portion */
/*lint -e{703} use shift for performance */
numSamples = (EAS_I32) ((numSamples << NUM_PHASE_FRAC_BITS) - pWTVoice->phaseFrac);
if (pWTIntFrame->frame.phaseIncrement) {
pWTIntFrame->numSamples = 1 + (numSamples / pWTIntFrame->frame.phaseIncrement);
} else {
pWTIntFrame->numSamples = numSamples;
}
if (pWTIntFrame->numSamples < 0) {
ALOGE("b/26366256");
android_errorWriteLog(0x534e4554, "26366256");
pWTIntFrame->numSamples = 0;
}
/* sound will be done this frame */
done = EAS_TRUE;
}
/* update data for off-chip synth */
if (update)
{
pWTVoice->phaseFrac = endPhaseFrac;
pWTVoice->phaseAccum = endPhaseAccum;
}
return done;
}
|
@@ -29,6 +29,7 @@
// includes
#include "log/log.h"
+#include <cutils/log.h>
#include "eas_data.h"
#include "eas_report.h"
@@ -471,6 +472,7 @@
}
if (pWTIntFrame->numSamples < 0) {
ALOGE("b/26366256");
+ android_errorWriteLog(0x534e4554, "26366256");
pWTIntFrame->numSamples = 0;
}
|
CWE-119
| null |
android_errorWriteLog(0x534e4554, "26366256");
|
150,904 |
void impeg2d_dec_p_mb_params(dec_state_t *ps_dec)
{
stream_t *ps_stream = &ps_dec->s_bit_stream;
UWORD16 u2_mb_addr_incr;
UWORD16 u2_total_len;
UWORD16 u2_len;
UWORD16 u2_mb_type;
UWORD32 u4_next_word;
const dec_mb_params_t *ps_dec_mb_params;
if(impeg2d_bit_stream_nxt(ps_stream,1) == 1)
{
impeg2d_bit_stream_flush(ps_stream,1);
}
else
{
u2_mb_addr_incr = impeg2d_get_mb_addr_incr(ps_stream);
if(0 == ps_dec->u2_first_mb)
{
/****************************************************************/
/* If the 2nd member of a field picture pair is a P picture and */
/* the first one was an I picture, there cannot be any skipped */
/* MBs in the second field picture */
/****************************************************************/
/*
if((dec->picture_structure != FRAME_PICTURE) &&
(dec->f->FieldFuncCall != 0) &&
(dec->las->u1_last_coded_vop_type == I))
{
core0_err_handler((void *)(VOLParams),
ITTMPEG2_ERR_INVALID_MB_SKIP);
}
*/
/****************************************************************/
/* In MPEG-2, the last MB of the row cannot be skipped and the */
/* MBAddrIncr cannot be such that it will take the current MB */
/* beyond the current row */
/* In MPEG-1, the slice could start and end anywhere and is not */
/* restricted to a row like in MPEG-2. Hence this check should */
/* not be done for MPEG-1 streams. */
/****************************************************************/
if(ps_dec->u2_is_mpeg2 && ((ps_dec->u2_mb_x + u2_mb_addr_incr) > ps_dec->u2_num_horiz_mb) )
{
u2_mb_addr_incr = ps_dec->u2_num_horiz_mb - ps_dec->u2_mb_x;
}
impeg2d_dec_skip_mbs(ps_dec, (UWORD16)(u2_mb_addr_incr - 1));
}
}
u4_next_word = (UWORD16)impeg2d_bit_stream_nxt(ps_stream,16);
/*-----------------------------------------------------------------------*/
/* MB type */
/*-----------------------------------------------------------------------*/
{
u2_mb_type = ps_dec->pu2_mb_type[BITS((UWORD16)u4_next_word,15,10)];
u2_len = BITS(u2_mb_type,15,8);
u2_total_len = u2_len;
u4_next_word = (UWORD16)LSW((UWORD16)u4_next_word << u2_len);
}
/*-----------------------------------------------------------------------*/
/* motion type */
/*-----------------------------------------------------------------------*/
{
if((u2_mb_type & MB_FORW_OR_BACK) && ps_dec->u2_read_motion_type)
{
WORD32 i4_motion_type;
ps_dec->u2_motion_type = BITS((UWORD16)u4_next_word,15,14);
u2_total_len += MB_MOTION_TYPE_LEN;
u4_next_word = (UWORD16)LSW((UWORD16)u4_next_word << MB_MOTION_TYPE_LEN);
i4_motion_type = ps_dec->u2_motion_type;
if((i4_motion_type == 0) ||
(i4_motion_type == 4) ||
(i4_motion_type > 7))
{
i4_motion_type = 1;
}
}
}
/*-----------------------------------------------------------------------*/
/* dct type */
/*-----------------------------------------------------------------------*/
{
if((u2_mb_type & MB_CODED) && ps_dec->u2_read_dct_type)
{
ps_dec->u2_field_dct = BIT((UWORD16)u4_next_word,15);
u2_total_len += MB_DCT_TYPE_LEN;
u4_next_word = (UWORD16)LSW((UWORD16)u4_next_word << MB_DCT_TYPE_LEN);
}
}
/*-----------------------------------------------------------------------*/
/* Quant scale code */
/*-----------------------------------------------------------------------*/
if(u2_mb_type & MB_QUANT)
{
UWORD16 u2_quant_scale_code;
u2_quant_scale_code = BITS((UWORD16)u4_next_word,15,11);
ps_dec->u1_quant_scale = (ps_dec->u2_q_scale_type) ?
gau1_impeg2_non_linear_quant_scale[u2_quant_scale_code] : (u2_quant_scale_code << 1);
u2_total_len += MB_QUANT_SCALE_CODE_LEN;
}
impeg2d_bit_stream_flush(ps_stream,u2_total_len);
/*-----------------------------------------------------------------------*/
/* Set the function pointers */
/*-----------------------------------------------------------------------*/
ps_dec->u2_coded_mb = (UWORD16)(u2_mb_type & MB_CODED);
if(u2_mb_type & MB_FORW_OR_BACK)
{
UWORD16 refPic = !(u2_mb_type & MB_MV_FORW);
UWORD16 index = (ps_dec->u2_motion_type);
ps_dec->u2_prev_intra_mb = 0;
ps_dec->e_mb_pred = (e_pred_direction_t)refPic;
ps_dec_mb_params = &ps_dec->ps_func_forw_or_back[index];
ps_dec->s_mb_type = ps_dec_mb_params->s_mb_type;
ps_dec_mb_params->pf_func_mb_params(ps_dec);
}
else if(u2_mb_type & MB_TYPE_INTRA)
{
ps_dec->u2_prev_intra_mb = 1;
impeg2d_dec_intra_mb(ps_dec);
}
else
{
ps_dec->u2_prev_intra_mb = 0;
ps_dec->e_mb_pred = FORW;
ps_dec->u2_motion_type = 0;
impeg2d_dec_0mv_coded_mb(ps_dec);
}
/*-----------------------------------------------------------------------*/
/* decode cbp */
/*-----------------------------------------------------------------------*/
if((u2_mb_type & MB_TYPE_INTRA))
{
ps_dec->u2_cbp = 0x3f;
ps_dec->u2_prev_intra_mb = 1;
}
else
{
ps_dec->u2_prev_intra_mb = 0;
ps_dec->u2_def_dc_pred[Y_LUMA] = 128 << ps_dec->u2_intra_dc_precision;
ps_dec->u2_def_dc_pred[U_CHROMA] = 128 << ps_dec->u2_intra_dc_precision;
ps_dec->u2_def_dc_pred[V_CHROMA] = 128 << ps_dec->u2_intra_dc_precision;
if((ps_dec->u2_coded_mb))
{
UWORD16 cbpValue;
cbpValue = gau2_impeg2d_cbp_code[impeg2d_bit_stream_nxt(ps_stream,MB_CBP_LEN)];
ps_dec->u2_cbp = cbpValue & 0xFF;
impeg2d_bit_stream_flush(ps_stream,(cbpValue >> 8) & 0x0FF);
}
else
{
ps_dec->u2_cbp = 0;
}
}
}
|
DoS Exec Code Overflow Mem. Corr.
| 1 |
void impeg2d_dec_p_mb_params(dec_state_t *ps_dec)
WORD32 impeg2d_dec_p_mb_params(dec_state_t *ps_dec)
{
stream_t *ps_stream = &ps_dec->s_bit_stream;
UWORD16 u2_mb_addr_incr;
UWORD16 u2_total_len;
UWORD16 u2_len;
UWORD16 u2_mb_type;
UWORD32 u4_next_word;
const dec_mb_params_t *ps_dec_mb_params;
if(impeg2d_bit_stream_nxt(ps_stream,1) == 1)
{
impeg2d_bit_stream_flush(ps_stream,1);
}
else
{
u2_mb_addr_incr = impeg2d_get_mb_addr_incr(ps_stream);
if(0 == ps_dec->u2_first_mb)
{
/****************************************************************/
/* If the 2nd member of a field picture pair is a P picture and */
/* the first one was an I picture, there cannot be any skipped */
/* MBs in the second field picture */
/****************************************************************/
/*
if((dec->picture_structure != FRAME_PICTURE) &&
(dec->f->FieldFuncCall != 0) &&
(dec->las->u1_last_coded_vop_type == I))
{
core0_err_handler((void *)(VOLParams),
ITTMPEG2_ERR_INVALID_MB_SKIP);
}
*/
/****************************************************************/
/* In MPEG-2, the last MB of the row cannot be skipped and the */
/* MBAddrIncr cannot be such that it will take the current MB */
/* beyond the current row */
/* In MPEG-1, the slice could start and end anywhere and is not */
/* restricted to a row like in MPEG-2. Hence this check should */
/* not be done for MPEG-1 streams. */
/****************************************************************/
if(ps_dec->u2_is_mpeg2 && ((ps_dec->u2_mb_x + u2_mb_addr_incr) > ps_dec->u2_num_horiz_mb) )
{
u2_mb_addr_incr = ps_dec->u2_num_horiz_mb - ps_dec->u2_mb_x;
}
impeg2d_dec_skip_mbs(ps_dec, (UWORD16)(u2_mb_addr_incr - 1));
}
}
u4_next_word = (UWORD16)impeg2d_bit_stream_nxt(ps_stream,16);
/*-----------------------------------------------------------------------*/
/* MB type */
/*-----------------------------------------------------------------------*/
{
u2_mb_type = ps_dec->pu2_mb_type[BITS((UWORD16)u4_next_word,15,10)];
u2_len = BITS(u2_mb_type,15,8);
u2_total_len = u2_len;
u4_next_word = (UWORD16)LSW((UWORD16)u4_next_word << u2_len);
}
/*-----------------------------------------------------------------------*/
/* motion type */
/*-----------------------------------------------------------------------*/
{
if((u2_mb_type & MB_FORW_OR_BACK) && ps_dec->u2_read_motion_type)
{
WORD32 i4_motion_type;
ps_dec->u2_motion_type = BITS((UWORD16)u4_next_word,15,14);
u2_total_len += MB_MOTION_TYPE_LEN;
u4_next_word = (UWORD16)LSW((UWORD16)u4_next_word << MB_MOTION_TYPE_LEN);
i4_motion_type = ps_dec->u2_motion_type;
if((i4_motion_type == 0) ||
(i4_motion_type == 4) ||
(i4_motion_type > 7))
{
i4_motion_type = 1;
}
}
}
/*-----------------------------------------------------------------------*/
/* dct type */
/*-----------------------------------------------------------------------*/
{
if((u2_mb_type & MB_CODED) && ps_dec->u2_read_dct_type)
{
ps_dec->u2_field_dct = BIT((UWORD16)u4_next_word,15);
u2_total_len += MB_DCT_TYPE_LEN;
u4_next_word = (UWORD16)LSW((UWORD16)u4_next_word << MB_DCT_TYPE_LEN);
}
}
/*-----------------------------------------------------------------------*/
/* Quant scale code */
/*-----------------------------------------------------------------------*/
if(u2_mb_type & MB_QUANT)
{
UWORD16 u2_quant_scale_code;
u2_quant_scale_code = BITS((UWORD16)u4_next_word,15,11);
ps_dec->u1_quant_scale = (ps_dec->u2_q_scale_type) ?
gau1_impeg2_non_linear_quant_scale[u2_quant_scale_code] : (u2_quant_scale_code << 1);
u2_total_len += MB_QUANT_SCALE_CODE_LEN;
}
impeg2d_bit_stream_flush(ps_stream,u2_total_len);
/*-----------------------------------------------------------------------*/
/* Set the function pointers */
/*-----------------------------------------------------------------------*/
ps_dec->u2_coded_mb = (UWORD16)(u2_mb_type & MB_CODED);
if(u2_mb_type & MB_FORW_OR_BACK)
{
UWORD16 refPic = !(u2_mb_type & MB_MV_FORW);
UWORD16 index = (ps_dec->u2_motion_type);
ps_dec->u2_prev_intra_mb = 0;
ps_dec->e_mb_pred = (e_pred_direction_t)refPic;
ps_dec_mb_params = &ps_dec->ps_func_forw_or_back[index];
ps_dec->s_mb_type = ps_dec_mb_params->s_mb_type;
if(NULL == ps_dec_mb_params->pf_func_mb_params)
return -1;
ps_dec_mb_params->pf_func_mb_params(ps_dec);
}
else if(u2_mb_type & MB_TYPE_INTRA)
{
ps_dec->u2_prev_intra_mb = 1;
impeg2d_dec_intra_mb(ps_dec);
}
else
{
ps_dec->u2_prev_intra_mb = 0;
ps_dec->e_mb_pred = FORW;
ps_dec->u2_motion_type = 0;
impeg2d_dec_0mv_coded_mb(ps_dec);
}
/*-----------------------------------------------------------------------*/
/* decode cbp */
/*-----------------------------------------------------------------------*/
if((u2_mb_type & MB_TYPE_INTRA))
{
ps_dec->u2_cbp = 0x3f;
ps_dec->u2_prev_intra_mb = 1;
}
else
{
ps_dec->u2_prev_intra_mb = 0;
ps_dec->u2_def_dc_pred[Y_LUMA] = 128 << ps_dec->u2_intra_dc_precision;
ps_dec->u2_def_dc_pred[U_CHROMA] = 128 << ps_dec->u2_intra_dc_precision;
ps_dec->u2_def_dc_pred[V_CHROMA] = 128 << ps_dec->u2_intra_dc_precision;
if((ps_dec->u2_coded_mb))
{
UWORD16 cbpValue;
cbpValue = gau2_impeg2d_cbp_code[impeg2d_bit_stream_nxt(ps_stream,MB_CBP_LEN)];
ps_dec->u2_cbp = cbpValue & 0xFF;
impeg2d_bit_stream_flush(ps_stream,(cbpValue >> 8) & 0x0FF);
}
else
{
ps_dec->u2_cbp = 0;
}
}
return 0;
}
|
@@ -60,7 +60,7 @@
*
* Values Returned : None
*******************************************************************************/
-void impeg2d_dec_p_mb_params(dec_state_t *ps_dec)
+WORD32 impeg2d_dec_p_mb_params(dec_state_t *ps_dec)
{
stream_t *ps_stream = &ps_dec->s_bit_stream;
UWORD16 u2_mb_addr_incr;
@@ -180,6 +180,8 @@
ps_dec->e_mb_pred = (e_pred_direction_t)refPic;
ps_dec_mb_params = &ps_dec->ps_func_forw_or_back[index];
ps_dec->s_mb_type = ps_dec_mb_params->s_mb_type;
+ if(NULL == ps_dec_mb_params->pf_func_mb_params)
+ return -1;
ps_dec_mb_params->pf_func_mb_params(ps_dec);
}
@@ -223,6 +225,7 @@
ps_dec->u2_cbp = 0;
}
}
+ return 0;
}
@@ -237,7 +240,7 @@
*
* Values Returned : None
*******************************************************************************/
-void impeg2d_dec_pnb_mb_params(dec_state_t *ps_dec)
+WORD32 impeg2d_dec_pnb_mb_params(dec_state_t *ps_dec)
{
stream_t *ps_stream = &ps_dec->s_bit_stream;
UWORD16 u2_mb_addr_incr;
@@ -373,6 +376,8 @@
ps_dec->e_mb_pred = BIDIRECT;
ps_dec_mb_params = &ps_dec->ps_func_bi_direct[u2_index];
ps_dec->s_mb_type = ps_dec_mb_params->s_mb_type;
+ if(NULL == ps_dec_mb_params->pf_func_mb_params)
+ return -1;
ps_dec_mb_params->pf_func_mb_params(ps_dec);
}
else if(u2_mb_type & MB_FORW_OR_BACK)
@@ -384,6 +389,8 @@
ps_dec->e_mb_pred = (e_pred_direction_t)u2_refPic;
ps_dec_mb_params = &ps_dec->ps_func_forw_or_back[u2_index];
ps_dec->s_mb_type = ps_dec_mb_params->s_mb_type;
+ if(NULL == ps_dec_mb_params->pf_func_mb_params)
+ return -1;
ps_dec_mb_params->pf_func_mb_params(ps_dec);
}
@@ -427,6 +434,7 @@
ps_dec->u2_cbp = 0;
}
}
+ return 0;
}
/*******************************************************************************
@@ -469,7 +477,7 @@
do
{
UWORD32 u4_x_offset, u4_y_offset;
-
+ WORD32 ret;
UWORD32 u4_x_dst_offset = 0;
@@ -482,10 +490,12 @@
if(ps_dec->e_pic_type == B_PIC)
- impeg2d_dec_pnb_mb_params(ps_dec);
+ ret = impeg2d_dec_pnb_mb_params(ps_dec);
else
- impeg2d_dec_p_mb_params(ps_dec);
+ ret = impeg2d_dec_p_mb_params(ps_dec);
+ if(ret)
+ return IMPEG2D_MB_TEX_DECODE_ERR;
IMPEG2D_TRACE_MB_START(ps_dec->u2_mb_x, ps_dec->u2_mb_y);
u4_x_dst_offset = u4_frm_offset + (ps_dec->u2_mb_x << 4);
|
CWE-119
| null |
WORD32 impeg2d_dec_p_mb_params(dec_state_t *ps_dec)
if(NULL == ps_dec_mb_params->pf_func_mb_params)
return -1;
return 0;
|
150,905 |
void impeg2d_dec_pnb_mb_params(dec_state_t *ps_dec)
{
stream_t *ps_stream = &ps_dec->s_bit_stream;
UWORD16 u2_mb_addr_incr;
UWORD16 u2_total_len;
UWORD16 u2_len;
UWORD16 u2_mb_type;
UWORD32 u4_next_word;
const dec_mb_params_t *ps_dec_mb_params;
if(impeg2d_bit_stream_nxt(ps_stream,1) == 1)
{
impeg2d_bit_stream_flush(ps_stream,1);
}
else
{
u2_mb_addr_incr = impeg2d_get_mb_addr_incr(ps_stream);
if(ps_dec->u2_first_mb)
{
/****************************************************************/
/* Section 6.3.17 */
/* The first MB of a slice cannot be skipped */
/* But the mb_addr_incr can be > 1, because at the beginning of */
/* a slice, it indicates the offset from the last MB in the */
/* previous row. Hence for the first slice in a row, the */
/* mb_addr_incr needs to be 1. */
/****************************************************************/
/* MB_x is set to zero whenever MB_y changes. */
ps_dec->u2_mb_x = u2_mb_addr_incr - 1;
/* For error resilience */
ps_dec->u2_mb_x = MIN(ps_dec->u2_mb_x, (ps_dec->u2_num_horiz_mb - 1));
/****************************************************************/
/* mb_addr_incr is forced to 1 because in this decoder it is used */
/* more as an indicator of the number of MBs skipped than the */
/* as defined by the standard (Section 6.3.17) */
/****************************************************************/
u2_mb_addr_incr = 1;
ps_dec->u2_first_mb = 0;
}
else
{
/****************************************************************/
/* In MPEG-2, the last MB of the row cannot be skipped and the */
/* mb_addr_incr cannot be such that it will take the current MB */
/* beyond the current row */
/* In MPEG-1, the slice could start and end anywhere and is not */
/* restricted to a row like in MPEG-2. Hence this check should */
/* not be done for MPEG-1 streams. */
/****************************************************************/
if(ps_dec->u2_is_mpeg2 &&
((ps_dec->u2_mb_x + u2_mb_addr_incr) > ps_dec->u2_num_horiz_mb))
{
u2_mb_addr_incr = ps_dec->u2_num_horiz_mb - ps_dec->u2_mb_x;
}
impeg2d_dec_skip_mbs(ps_dec, (UWORD16)(u2_mb_addr_incr - 1));
}
}
u4_next_word = (UWORD16)impeg2d_bit_stream_nxt(ps_stream,16);
/*-----------------------------------------------------------------------*/
/* MB type */
/*-----------------------------------------------------------------------*/
{
u2_mb_type = ps_dec->pu2_mb_type[BITS((UWORD16)u4_next_word,15,10)];
u2_len = BITS(u2_mb_type,15,8);
u2_total_len = u2_len;
u4_next_word = (UWORD16)LSW((UWORD16)u4_next_word << u2_len);
}
/*-----------------------------------------------------------------------*/
/* motion type */
/*-----------------------------------------------------------------------*/
{
WORD32 i4_motion_type = ps_dec->u2_motion_type;
if((u2_mb_type & MB_FORW_OR_BACK) && ps_dec->u2_read_motion_type)
{
ps_dec->u2_motion_type = BITS((UWORD16)u4_next_word,15,14);
u2_total_len += MB_MOTION_TYPE_LEN;
u4_next_word = (UWORD16)LSW((UWORD16)u4_next_word << MB_MOTION_TYPE_LEN);
i4_motion_type = ps_dec->u2_motion_type;
}
if ((u2_mb_type & MB_FORW_OR_BACK) &&
((i4_motion_type == 0) ||
(i4_motion_type == 3) ||
(i4_motion_type == 4) ||
(i4_motion_type >= 7)))
{
i4_motion_type = 1;
}
}
/*-----------------------------------------------------------------------*/
/* dct type */
/*-----------------------------------------------------------------------*/
{
if((u2_mb_type & MB_CODED) && ps_dec->u2_read_dct_type)
{
ps_dec->u2_field_dct = BIT((UWORD16)u4_next_word,15);
u2_total_len += MB_DCT_TYPE_LEN;
u4_next_word = (UWORD16)LSW((UWORD16)u4_next_word << MB_DCT_TYPE_LEN);
}
}
/*-----------------------------------------------------------------------*/
/* Quant scale code */
/*-----------------------------------------------------------------------*/
if(u2_mb_type & MB_QUANT)
{
UWORD16 u2_quant_scale_code;
u2_quant_scale_code = BITS((UWORD16)u4_next_word,15,11);
ps_dec->u1_quant_scale = (ps_dec->u2_q_scale_type) ?
gau1_impeg2_non_linear_quant_scale[u2_quant_scale_code] : (u2_quant_scale_code << 1);
u2_total_len += MB_QUANT_SCALE_CODE_LEN;
}
impeg2d_bit_stream_flush(ps_stream,u2_total_len);
/*-----------------------------------------------------------------------*/
/* Set the function pointers */
/*-----------------------------------------------------------------------*/
ps_dec->u2_coded_mb = (UWORD16)(u2_mb_type & MB_CODED);
if(u2_mb_type & MB_BIDRECT)
{
UWORD16 u2_index = (ps_dec->u2_motion_type);
ps_dec->u2_prev_intra_mb = 0;
ps_dec->e_mb_pred = BIDIRECT;
ps_dec_mb_params = &ps_dec->ps_func_bi_direct[u2_index];
ps_dec->s_mb_type = ps_dec_mb_params->s_mb_type;
ps_dec_mb_params->pf_func_mb_params(ps_dec);
}
else if(u2_mb_type & MB_FORW_OR_BACK)
{
UWORD16 u2_refPic = !(u2_mb_type & MB_MV_FORW);
UWORD16 u2_index = (ps_dec->u2_motion_type);
ps_dec->u2_prev_intra_mb = 0;
ps_dec->e_mb_pred = (e_pred_direction_t)u2_refPic;
ps_dec_mb_params = &ps_dec->ps_func_forw_or_back[u2_index];
ps_dec->s_mb_type = ps_dec_mb_params->s_mb_type;
ps_dec_mb_params->pf_func_mb_params(ps_dec);
}
else if(u2_mb_type & MB_TYPE_INTRA)
{
ps_dec->u2_prev_intra_mb = 1;
impeg2d_dec_intra_mb(ps_dec);
}
else
{
ps_dec->u2_prev_intra_mb =0;
ps_dec->e_mb_pred = FORW;
ps_dec->u2_motion_type = 0;
impeg2d_dec_0mv_coded_mb(ps_dec);
}
/*-----------------------------------------------------------------------*/
/* decode cbp */
/*-----------------------------------------------------------------------*/
if((u2_mb_type & MB_TYPE_INTRA))
{
ps_dec->u2_cbp = 0x3f;
ps_dec->u2_prev_intra_mb = 1;
}
else
{
ps_dec->u2_prev_intra_mb = 0;
ps_dec->u2_def_dc_pred[Y_LUMA] = 128 << ps_dec->u2_intra_dc_precision;
ps_dec->u2_def_dc_pred[U_CHROMA] = 128 << ps_dec->u2_intra_dc_precision;
ps_dec->u2_def_dc_pred[V_CHROMA] = 128 << ps_dec->u2_intra_dc_precision;
if((ps_dec->u2_coded_mb))
{
UWORD16 cbpValue;
cbpValue = gau2_impeg2d_cbp_code[impeg2d_bit_stream_nxt(ps_stream,MB_CBP_LEN)];
ps_dec->u2_cbp = cbpValue & 0xFF;
impeg2d_bit_stream_flush(ps_stream,(cbpValue >> 8) & 0x0FF);
}
else
{
ps_dec->u2_cbp = 0;
}
}
}
|
DoS Exec Code Overflow Mem. Corr.
| 1 |
void impeg2d_dec_pnb_mb_params(dec_state_t *ps_dec)
WORD32 impeg2d_dec_pnb_mb_params(dec_state_t *ps_dec)
{
stream_t *ps_stream = &ps_dec->s_bit_stream;
UWORD16 u2_mb_addr_incr;
UWORD16 u2_total_len;
UWORD16 u2_len;
UWORD16 u2_mb_type;
UWORD32 u4_next_word;
const dec_mb_params_t *ps_dec_mb_params;
if(impeg2d_bit_stream_nxt(ps_stream,1) == 1)
{
impeg2d_bit_stream_flush(ps_stream,1);
}
else
{
u2_mb_addr_incr = impeg2d_get_mb_addr_incr(ps_stream);
if(ps_dec->u2_first_mb)
{
/****************************************************************/
/* Section 6.3.17 */
/* The first MB of a slice cannot be skipped */
/* But the mb_addr_incr can be > 1, because at the beginning of */
/* a slice, it indicates the offset from the last MB in the */
/* previous row. Hence for the first slice in a row, the */
/* mb_addr_incr needs to be 1. */
/****************************************************************/
/* MB_x is set to zero whenever MB_y changes. */
ps_dec->u2_mb_x = u2_mb_addr_incr - 1;
/* For error resilience */
ps_dec->u2_mb_x = MIN(ps_dec->u2_mb_x, (ps_dec->u2_num_horiz_mb - 1));
/****************************************************************/
/* mb_addr_incr is forced to 1 because in this decoder it is used */
/* more as an indicator of the number of MBs skipped than the */
/* as defined by the standard (Section 6.3.17) */
/****************************************************************/
u2_mb_addr_incr = 1;
ps_dec->u2_first_mb = 0;
}
else
{
/****************************************************************/
/* In MPEG-2, the last MB of the row cannot be skipped and the */
/* mb_addr_incr cannot be such that it will take the current MB */
/* beyond the current row */
/* In MPEG-1, the slice could start and end anywhere and is not */
/* restricted to a row like in MPEG-2. Hence this check should */
/* not be done for MPEG-1 streams. */
/****************************************************************/
if(ps_dec->u2_is_mpeg2 &&
((ps_dec->u2_mb_x + u2_mb_addr_incr) > ps_dec->u2_num_horiz_mb))
{
u2_mb_addr_incr = ps_dec->u2_num_horiz_mb - ps_dec->u2_mb_x;
}
impeg2d_dec_skip_mbs(ps_dec, (UWORD16)(u2_mb_addr_incr - 1));
}
}
u4_next_word = (UWORD16)impeg2d_bit_stream_nxt(ps_stream,16);
/*-----------------------------------------------------------------------*/
/* MB type */
/*-----------------------------------------------------------------------*/
{
u2_mb_type = ps_dec->pu2_mb_type[BITS((UWORD16)u4_next_word,15,10)];
u2_len = BITS(u2_mb_type,15,8);
u2_total_len = u2_len;
u4_next_word = (UWORD16)LSW((UWORD16)u4_next_word << u2_len);
}
/*-----------------------------------------------------------------------*/
/* motion type */
/*-----------------------------------------------------------------------*/
{
WORD32 i4_motion_type = ps_dec->u2_motion_type;
if((u2_mb_type & MB_FORW_OR_BACK) && ps_dec->u2_read_motion_type)
{
ps_dec->u2_motion_type = BITS((UWORD16)u4_next_word,15,14);
u2_total_len += MB_MOTION_TYPE_LEN;
u4_next_word = (UWORD16)LSW((UWORD16)u4_next_word << MB_MOTION_TYPE_LEN);
i4_motion_type = ps_dec->u2_motion_type;
}
if ((u2_mb_type & MB_FORW_OR_BACK) &&
((i4_motion_type == 0) ||
(i4_motion_type == 3) ||
(i4_motion_type == 4) ||
(i4_motion_type >= 7)))
{
i4_motion_type = 1;
}
}
/*-----------------------------------------------------------------------*/
/* dct type */
/*-----------------------------------------------------------------------*/
{
if((u2_mb_type & MB_CODED) && ps_dec->u2_read_dct_type)
{
ps_dec->u2_field_dct = BIT((UWORD16)u4_next_word,15);
u2_total_len += MB_DCT_TYPE_LEN;
u4_next_word = (UWORD16)LSW((UWORD16)u4_next_word << MB_DCT_TYPE_LEN);
}
}
/*-----------------------------------------------------------------------*/
/* Quant scale code */
/*-----------------------------------------------------------------------*/
if(u2_mb_type & MB_QUANT)
{
UWORD16 u2_quant_scale_code;
u2_quant_scale_code = BITS((UWORD16)u4_next_word,15,11);
ps_dec->u1_quant_scale = (ps_dec->u2_q_scale_type) ?
gau1_impeg2_non_linear_quant_scale[u2_quant_scale_code] : (u2_quant_scale_code << 1);
u2_total_len += MB_QUANT_SCALE_CODE_LEN;
}
impeg2d_bit_stream_flush(ps_stream,u2_total_len);
/*-----------------------------------------------------------------------*/
/* Set the function pointers */
/*-----------------------------------------------------------------------*/
ps_dec->u2_coded_mb = (UWORD16)(u2_mb_type & MB_CODED);
if(u2_mb_type & MB_BIDRECT)
{
UWORD16 u2_index = (ps_dec->u2_motion_type);
ps_dec->u2_prev_intra_mb = 0;
ps_dec->e_mb_pred = BIDIRECT;
ps_dec_mb_params = &ps_dec->ps_func_bi_direct[u2_index];
ps_dec->s_mb_type = ps_dec_mb_params->s_mb_type;
if(NULL == ps_dec_mb_params->pf_func_mb_params)
return -1;
ps_dec_mb_params->pf_func_mb_params(ps_dec);
}
else if(u2_mb_type & MB_FORW_OR_BACK)
{
UWORD16 u2_refPic = !(u2_mb_type & MB_MV_FORW);
UWORD16 u2_index = (ps_dec->u2_motion_type);
ps_dec->u2_prev_intra_mb = 0;
ps_dec->e_mb_pred = (e_pred_direction_t)u2_refPic;
ps_dec_mb_params = &ps_dec->ps_func_forw_or_back[u2_index];
ps_dec->s_mb_type = ps_dec_mb_params->s_mb_type;
if(NULL == ps_dec_mb_params->pf_func_mb_params)
return -1;
ps_dec_mb_params->pf_func_mb_params(ps_dec);
}
else if(u2_mb_type & MB_TYPE_INTRA)
{
ps_dec->u2_prev_intra_mb = 1;
impeg2d_dec_intra_mb(ps_dec);
}
else
{
ps_dec->u2_prev_intra_mb =0;
ps_dec->e_mb_pred = FORW;
ps_dec->u2_motion_type = 0;
impeg2d_dec_0mv_coded_mb(ps_dec);
}
/*-----------------------------------------------------------------------*/
/* decode cbp */
/*-----------------------------------------------------------------------*/
if((u2_mb_type & MB_TYPE_INTRA))
{
ps_dec->u2_cbp = 0x3f;
ps_dec->u2_prev_intra_mb = 1;
}
else
{
ps_dec->u2_prev_intra_mb = 0;
ps_dec->u2_def_dc_pred[Y_LUMA] = 128 << ps_dec->u2_intra_dc_precision;
ps_dec->u2_def_dc_pred[U_CHROMA] = 128 << ps_dec->u2_intra_dc_precision;
ps_dec->u2_def_dc_pred[V_CHROMA] = 128 << ps_dec->u2_intra_dc_precision;
if((ps_dec->u2_coded_mb))
{
UWORD16 cbpValue;
cbpValue = gau2_impeg2d_cbp_code[impeg2d_bit_stream_nxt(ps_stream,MB_CBP_LEN)];
ps_dec->u2_cbp = cbpValue & 0xFF;
impeg2d_bit_stream_flush(ps_stream,(cbpValue >> 8) & 0x0FF);
}
else
{
ps_dec->u2_cbp = 0;
}
}
return 0;
}
|
@@ -60,7 +60,7 @@
*
* Values Returned : None
*******************************************************************************/
-void impeg2d_dec_p_mb_params(dec_state_t *ps_dec)
+WORD32 impeg2d_dec_p_mb_params(dec_state_t *ps_dec)
{
stream_t *ps_stream = &ps_dec->s_bit_stream;
UWORD16 u2_mb_addr_incr;
@@ -180,6 +180,8 @@
ps_dec->e_mb_pred = (e_pred_direction_t)refPic;
ps_dec_mb_params = &ps_dec->ps_func_forw_or_back[index];
ps_dec->s_mb_type = ps_dec_mb_params->s_mb_type;
+ if(NULL == ps_dec_mb_params->pf_func_mb_params)
+ return -1;
ps_dec_mb_params->pf_func_mb_params(ps_dec);
}
@@ -223,6 +225,7 @@
ps_dec->u2_cbp = 0;
}
}
+ return 0;
}
@@ -237,7 +240,7 @@
*
* Values Returned : None
*******************************************************************************/
-void impeg2d_dec_pnb_mb_params(dec_state_t *ps_dec)
+WORD32 impeg2d_dec_pnb_mb_params(dec_state_t *ps_dec)
{
stream_t *ps_stream = &ps_dec->s_bit_stream;
UWORD16 u2_mb_addr_incr;
@@ -373,6 +376,8 @@
ps_dec->e_mb_pred = BIDIRECT;
ps_dec_mb_params = &ps_dec->ps_func_bi_direct[u2_index];
ps_dec->s_mb_type = ps_dec_mb_params->s_mb_type;
+ if(NULL == ps_dec_mb_params->pf_func_mb_params)
+ return -1;
ps_dec_mb_params->pf_func_mb_params(ps_dec);
}
else if(u2_mb_type & MB_FORW_OR_BACK)
@@ -384,6 +389,8 @@
ps_dec->e_mb_pred = (e_pred_direction_t)u2_refPic;
ps_dec_mb_params = &ps_dec->ps_func_forw_or_back[u2_index];
ps_dec->s_mb_type = ps_dec_mb_params->s_mb_type;
+ if(NULL == ps_dec_mb_params->pf_func_mb_params)
+ return -1;
ps_dec_mb_params->pf_func_mb_params(ps_dec);
}
@@ -427,6 +434,7 @@
ps_dec->u2_cbp = 0;
}
}
+ return 0;
}
/*******************************************************************************
@@ -469,7 +477,7 @@
do
{
UWORD32 u4_x_offset, u4_y_offset;
-
+ WORD32 ret;
UWORD32 u4_x_dst_offset = 0;
@@ -482,10 +490,12 @@
if(ps_dec->e_pic_type == B_PIC)
- impeg2d_dec_pnb_mb_params(ps_dec);
+ ret = impeg2d_dec_pnb_mb_params(ps_dec);
else
- impeg2d_dec_p_mb_params(ps_dec);
+ ret = impeg2d_dec_p_mb_params(ps_dec);
+ if(ret)
+ return IMPEG2D_MB_TEX_DECODE_ERR;
IMPEG2D_TRACE_MB_START(ps_dec->u2_mb_x, ps_dec->u2_mb_y);
u4_x_dst_offset = u4_frm_offset + (ps_dec->u2_mb_x << 4);
|
CWE-119
| null |
WORD32 impeg2d_dec_pnb_mb_params(dec_state_t *ps_dec)
if(NULL == ps_dec_mb_params->pf_func_mb_params)
return -1;
if(NULL == ps_dec_mb_params->pf_func_mb_params)
return -1;
return 0;
|
150,906 |
int equalizer_get_parameter(effect_context_t *context, effect_param_t *p,
uint32_t *size)
{
equalizer_context_t *eq_ctxt = (equalizer_context_t *)context;
int voffset = ((p->psize - 1) / sizeof(int32_t) + 1) * sizeof(int32_t);
int32_t *param_tmp = (int32_t *)p->data;
int32_t param = *param_tmp++;
int32_t param2;
char *name;
void *value = p->data + voffset;
int i;
ALOGV("%s", __func__);
p->status = 0;
switch (param) {
case EQ_PARAM_NUM_BANDS:
case EQ_PARAM_CUR_PRESET:
case EQ_PARAM_GET_NUM_OF_PRESETS:
case EQ_PARAM_BAND_LEVEL:
case EQ_PARAM_GET_BAND:
if (p->vsize < sizeof(int16_t))
p->status = -EINVAL;
p->vsize = sizeof(int16_t);
break;
case EQ_PARAM_LEVEL_RANGE:
if (p->vsize < 2 * sizeof(int16_t))
p->status = -EINVAL;
p->vsize = 2 * sizeof(int16_t);
break;
case EQ_PARAM_BAND_FREQ_RANGE:
if (p->vsize < 2 * sizeof(int32_t))
p->status = -EINVAL;
p->vsize = 2 * sizeof(int32_t);
break;
case EQ_PARAM_CENTER_FREQ:
if (p->vsize < sizeof(int32_t))
p->status = -EINVAL;
p->vsize = sizeof(int32_t);
break;
case EQ_PARAM_GET_PRESET_NAME:
break;
case EQ_PARAM_PROPERTIES:
if (p->vsize < (2 + NUM_EQ_BANDS) * sizeof(uint16_t))
p->status = -EINVAL;
p->vsize = (2 + NUM_EQ_BANDS) * sizeof(uint16_t);
break;
default:
p->status = -EINVAL;
}
*size = sizeof(effect_param_t) + voffset + p->vsize;
if (p->status != 0)
return 0;
switch (param) {
case EQ_PARAM_NUM_BANDS:
ALOGV("%s: EQ_PARAM_NUM_BANDS", __func__);
*(uint16_t *)value = (uint16_t)NUM_EQ_BANDS;
break;
case EQ_PARAM_LEVEL_RANGE:
ALOGV("%s: EQ_PARAM_LEVEL_RANGE", __func__);
*(int16_t *)value = -1500;
*((int16_t *)value + 1) = 1500;
break;
case EQ_PARAM_BAND_LEVEL:
ALOGV("%s: EQ_PARAM_BAND_LEVEL", __func__);
param2 = *param_tmp;
if (param2 >= NUM_EQ_BANDS) {
p->status = -EINVAL;
break;
}
*(int16_t *)value = (int16_t)equalizer_get_band_level(eq_ctxt, param2);
break;
case EQ_PARAM_CENTER_FREQ:
ALOGV("%s: EQ_PARAM_CENTER_FREQ", __func__);
param2 = *param_tmp;
if (param2 >= NUM_EQ_BANDS) {
p->status = -EINVAL;
break;
}
*(int32_t *)value = equalizer_get_center_frequency(eq_ctxt, param2);
break;
case EQ_PARAM_BAND_FREQ_RANGE:
ALOGV("%s: EQ_PARAM_BAND_FREQ_RANGE", __func__);
param2 = *param_tmp;
if (param2 >= NUM_EQ_BANDS) {
p->status = -EINVAL;
break;
}
equalizer_get_band_freq_range(eq_ctxt, param2, (uint32_t *)value,
((uint32_t *)value + 1));
break;
case EQ_PARAM_GET_BAND:
ALOGV("%s: EQ_PARAM_GET_BAND", __func__);
param2 = *param_tmp;
*(uint16_t *)value = (uint16_t)equalizer_get_band(eq_ctxt, param2);
break;
case EQ_PARAM_CUR_PRESET:
ALOGV("%s: EQ_PARAM_CUR_PRESET", __func__);
*(uint16_t *)value = (uint16_t)equalizer_get_preset(eq_ctxt);
break;
case EQ_PARAM_GET_NUM_OF_PRESETS:
ALOGV("%s: EQ_PARAM_GET_NUM_OF_PRESETS", __func__);
*(uint16_t *)value = (uint16_t)equalizer_get_num_presets(eq_ctxt);
break;
case EQ_PARAM_GET_PRESET_NAME:
ALOGV("%s: EQ_PARAM_GET_PRESET_NAME", __func__);
param2 = *param_tmp;
ALOGV("param2: %d", param2);
if (param2 >= equalizer_get_num_presets(eq_ctxt)) {
p->status = -EINVAL;
break;
}
name = (char *)value;
strlcpy(name, equalizer_get_preset_name(eq_ctxt, param2), p->vsize - 1);
name[p->vsize - 1] = 0;
p->vsize = strlen(name) + 1;
break;
case EQ_PARAM_PROPERTIES: {
ALOGV("%s: EQ_PARAM_PROPERTIES", __func__);
int16_t *prop = (int16_t *)value;
prop[0] = (int16_t)equalizer_get_preset(eq_ctxt);
prop[1] = (int16_t)NUM_EQ_BANDS;
for (i = 0; i < NUM_EQ_BANDS; i++) {
prop[2 + i] = (int16_t)equalizer_get_band_level(eq_ctxt, i);
}
} break;
default:
p->status = -EINVAL;
break;
}
return 0;
}
|
+Info
| 1 |
int equalizer_get_parameter(effect_context_t *context, effect_param_t *p,
uint32_t *size)
{
equalizer_context_t *eq_ctxt = (equalizer_context_t *)context;
int voffset = ((p->psize - 1) / sizeof(int32_t) + 1) * sizeof(int32_t);
int32_t *param_tmp = (int32_t *)p->data;
int32_t param = *param_tmp++;
int32_t param2;
char *name;
void *value = p->data + voffset;
int i;
ALOGV("%s", __func__);
p->status = 0;
switch (param) {
case EQ_PARAM_NUM_BANDS:
case EQ_PARAM_CUR_PRESET:
case EQ_PARAM_GET_NUM_OF_PRESETS:
case EQ_PARAM_BAND_LEVEL:
case EQ_PARAM_GET_BAND:
if (p->vsize < sizeof(int16_t))
p->status = -EINVAL;
p->vsize = sizeof(int16_t);
break;
case EQ_PARAM_LEVEL_RANGE:
if (p->vsize < 2 * sizeof(int16_t))
p->status = -EINVAL;
p->vsize = 2 * sizeof(int16_t);
break;
case EQ_PARAM_BAND_FREQ_RANGE:
if (p->vsize < 2 * sizeof(int32_t))
p->status = -EINVAL;
p->vsize = 2 * sizeof(int32_t);
break;
case EQ_PARAM_CENTER_FREQ:
if (p->vsize < sizeof(int32_t))
p->status = -EINVAL;
p->vsize = sizeof(int32_t);
break;
case EQ_PARAM_GET_PRESET_NAME:
break;
case EQ_PARAM_PROPERTIES:
if (p->vsize < (2 + NUM_EQ_BANDS) * sizeof(uint16_t))
p->status = -EINVAL;
p->vsize = (2 + NUM_EQ_BANDS) * sizeof(uint16_t);
break;
default:
p->status = -EINVAL;
}
*size = sizeof(effect_param_t) + voffset + p->vsize;
if (p->status != 0)
return 0;
switch (param) {
case EQ_PARAM_NUM_BANDS:
ALOGV("%s: EQ_PARAM_NUM_BANDS", __func__);
*(uint16_t *)value = (uint16_t)NUM_EQ_BANDS;
break;
case EQ_PARAM_LEVEL_RANGE:
ALOGV("%s: EQ_PARAM_LEVEL_RANGE", __func__);
*(int16_t *)value = -1500;
*((int16_t *)value + 1) = 1500;
break;
case EQ_PARAM_BAND_LEVEL:
ALOGV("%s: EQ_PARAM_BAND_LEVEL", __func__);
param2 = *param_tmp;
if (param2 < 0 || param2 >= NUM_EQ_BANDS) {
p->status = -EINVAL;
if (param2 < 0) {
android_errorWriteLog(0x534e4554, "32438598");
ALOGW("\tERROR EQ_PARAM_BAND_LEVEL band %d", param2);
}
break;
}
*(int16_t *)value = (int16_t)equalizer_get_band_level(eq_ctxt, param2);
break;
case EQ_PARAM_CENTER_FREQ:
ALOGV("%s: EQ_PARAM_CENTER_FREQ", __func__);
param2 = *param_tmp;
if (param2 < 0 || param2 >= NUM_EQ_BANDS) {
p->status = -EINVAL;
if (param2 < 0) {
android_errorWriteLog(0x534e4554, "32436341");
ALOGW("\tERROR EQ_PARAM_CENTER_FREQ band %d", param2);
}
break;
}
*(int32_t *)value = equalizer_get_center_frequency(eq_ctxt, param2);
break;
case EQ_PARAM_BAND_FREQ_RANGE:
ALOGV("%s: EQ_PARAM_BAND_FREQ_RANGE", __func__);
param2 = *param_tmp;
if (param2 < 0 || param2 >= NUM_EQ_BANDS) {
p->status = -EINVAL;
if (param2 < 0) {
android_errorWriteLog(0x534e4554, "32247948");
ALOGW("\tERROR EQ_PARAM_BAND_FREQ_RANGE band %d", param2);
}
break;
}
equalizer_get_band_freq_range(eq_ctxt, param2, (uint32_t *)value,
((uint32_t *)value + 1));
break;
case EQ_PARAM_GET_BAND:
ALOGV("%s: EQ_PARAM_GET_BAND", __func__);
param2 = *param_tmp;
*(uint16_t *)value = (uint16_t)equalizer_get_band(eq_ctxt, param2);
break;
case EQ_PARAM_CUR_PRESET:
ALOGV("%s: EQ_PARAM_CUR_PRESET", __func__);
*(uint16_t *)value = (uint16_t)equalizer_get_preset(eq_ctxt);
break;
case EQ_PARAM_GET_NUM_OF_PRESETS:
ALOGV("%s: EQ_PARAM_GET_NUM_OF_PRESETS", __func__);
*(uint16_t *)value = (uint16_t)equalizer_get_num_presets(eq_ctxt);
break;
case EQ_PARAM_GET_PRESET_NAME:
ALOGV("%s: EQ_PARAM_GET_PRESET_NAME", __func__);
param2 = *param_tmp;
ALOGV("param2: %d", param2);
if (param2 >= equalizer_get_num_presets(eq_ctxt)) {
p->status = -EINVAL;
break;
}
name = (char *)value;
strlcpy(name, equalizer_get_preset_name(eq_ctxt, param2), p->vsize - 1);
name[p->vsize - 1] = 0;
p->vsize = strlen(name) + 1;
break;
case EQ_PARAM_PROPERTIES: {
ALOGV("%s: EQ_PARAM_PROPERTIES", __func__);
int16_t *prop = (int16_t *)value;
prop[0] = (int16_t)equalizer_get_preset(eq_ctxt);
prop[1] = (int16_t)NUM_EQ_BANDS;
for (i = 0; i < NUM_EQ_BANDS; i++) {
prop[2 + i] = (int16_t)equalizer_get_band_level(eq_ctxt, i);
}
} break;
default:
p->status = -EINVAL;
break;
}
return 0;
}
|
@@ -265,8 +265,12 @@
case EQ_PARAM_BAND_LEVEL:
ALOGV("%s: EQ_PARAM_BAND_LEVEL", __func__);
param2 = *param_tmp;
- if (param2 >= NUM_EQ_BANDS) {
+ if (param2 < 0 || param2 >= NUM_EQ_BANDS) {
p->status = -EINVAL;
+ if (param2 < 0) {
+ android_errorWriteLog(0x534e4554, "32438598");
+ ALOGW("\tERROR EQ_PARAM_BAND_LEVEL band %d", param2);
+ }
break;
}
*(int16_t *)value = (int16_t)equalizer_get_band_level(eq_ctxt, param2);
@@ -275,8 +279,12 @@
case EQ_PARAM_CENTER_FREQ:
ALOGV("%s: EQ_PARAM_CENTER_FREQ", __func__);
param2 = *param_tmp;
- if (param2 >= NUM_EQ_BANDS) {
- p->status = -EINVAL;
+ if (param2 < 0 || param2 >= NUM_EQ_BANDS) {
+ p->status = -EINVAL;
+ if (param2 < 0) {
+ android_errorWriteLog(0x534e4554, "32436341");
+ ALOGW("\tERROR EQ_PARAM_CENTER_FREQ band %d", param2);
+ }
break;
}
*(int32_t *)value = equalizer_get_center_frequency(eq_ctxt, param2);
@@ -285,8 +293,12 @@
case EQ_PARAM_BAND_FREQ_RANGE:
ALOGV("%s: EQ_PARAM_BAND_FREQ_RANGE", __func__);
param2 = *param_tmp;
- if (param2 >= NUM_EQ_BANDS) {
+ if (param2 < 0 || param2 >= NUM_EQ_BANDS) {
p->status = -EINVAL;
+ if (param2 < 0) {
+ android_errorWriteLog(0x534e4554, "32247948");
+ ALOGW("\tERROR EQ_PARAM_BAND_FREQ_RANGE band %d", param2);
+ }
break;
}
equalizer_get_band_freq_range(eq_ctxt, param2, (uint32_t *)value,
|
CWE-200
|
if (param2 >= NUM_EQ_BANDS) {
if (param2 >= NUM_EQ_BANDS) {
p->status = -EINVAL;
if (param2 >= NUM_EQ_BANDS) {
|
if (param2 < 0 || param2 >= NUM_EQ_BANDS) {
if (param2 < 0) {
android_errorWriteLog(0x534e4554, "32438598");
ALOGW("\tERROR EQ_PARAM_BAND_LEVEL band %d", param2);
}
if (param2 < 0 || param2 >= NUM_EQ_BANDS) {
p->status = -EINVAL;
if (param2 < 0) {
android_errorWriteLog(0x534e4554, "32436341");
ALOGW("\tERROR EQ_PARAM_CENTER_FREQ band %d", param2);
}
if (param2 < 0 || param2 >= NUM_EQ_BANDS) {
if (param2 < 0) {
android_errorWriteLog(0x534e4554, "32247948");
ALOGW("\tERROR EQ_PARAM_BAND_FREQ_RANGE band %d", param2);
}
|
150,907 |
uint8_t rfc_parse_data(tRFC_MCB* p_mcb, MX_FRAME* p_frame, BT_HDR* p_buf) {
uint8_t ead, eal, fcs;
uint8_t* p_data = (uint8_t*)(p_buf + 1) + p_buf->offset;
uint8_t* p_start = p_data;
uint16_t len;
if (p_buf->len < RFCOMM_CTRL_FRAME_LEN) {
RFCOMM_TRACE_ERROR("Bad Length1: %d", p_buf->len);
return (RFC_EVENT_BAD_FRAME);
}
RFCOMM_PARSE_CTRL_FIELD(ead, p_frame->cr, p_frame->dlci, p_data);
if (!ead) {
RFCOMM_TRACE_ERROR("Bad Address(EA must be 1)");
return (RFC_EVENT_BAD_FRAME);
}
RFCOMM_PARSE_TYPE_FIELD(p_frame->type, p_frame->pf, p_data);
RFCOMM_PARSE_LEN_FIELD(eal, len, p_data);
p_buf->len -= (3 + !ead + !eal + 1); /* Additional 1 for FCS */
p_buf->offset += (3 + !ead + !eal);
/* handle credit if credit based flow control */
if ((p_mcb->flow == PORT_FC_CREDIT) && (p_frame->type == RFCOMM_UIH) &&
(p_frame->dlci != RFCOMM_MX_DLCI) && (p_frame->pf == 1)) {
p_frame->credit = *p_data++;
p_buf->len--;
p_buf->offset++;
} else
p_frame->credit = 0;
if (p_buf->len != len) {
RFCOMM_TRACE_ERROR("Bad Length2 %d %d", p_buf->len, len);
return (RFC_EVENT_BAD_FRAME);
}
fcs = *(p_data + len);
/* All control frames that we are sending are sent with P=1, expect */
/* reply with F=1 */
/* According to TS 07.10 spec ivalid frames are discarded without */
/* notification to the sender */
switch (p_frame->type) {
case RFCOMM_SABME:
if (RFCOMM_FRAME_IS_RSP(p_mcb->is_initiator, p_frame->cr) ||
!p_frame->pf || len || !RFCOMM_VALID_DLCI(p_frame->dlci) ||
!rfc_check_fcs(RFCOMM_CTRL_FRAME_LEN, p_start, fcs)) {
RFCOMM_TRACE_ERROR("Bad SABME");
return (RFC_EVENT_BAD_FRAME);
} else
return (RFC_EVENT_SABME);
case RFCOMM_UA:
if (RFCOMM_FRAME_IS_CMD(p_mcb->is_initiator, p_frame->cr) ||
!p_frame->pf || len || !RFCOMM_VALID_DLCI(p_frame->dlci) ||
!rfc_check_fcs(RFCOMM_CTRL_FRAME_LEN, p_start, fcs)) {
RFCOMM_TRACE_ERROR("Bad UA");
return (RFC_EVENT_BAD_FRAME);
} else
return (RFC_EVENT_UA);
case RFCOMM_DM:
if (RFCOMM_FRAME_IS_CMD(p_mcb->is_initiator, p_frame->cr) || len ||
!RFCOMM_VALID_DLCI(p_frame->dlci) ||
!rfc_check_fcs(RFCOMM_CTRL_FRAME_LEN, p_start, fcs)) {
RFCOMM_TRACE_ERROR("Bad DM");
return (RFC_EVENT_BAD_FRAME);
} else
return (RFC_EVENT_DM);
case RFCOMM_DISC:
if (RFCOMM_FRAME_IS_RSP(p_mcb->is_initiator, p_frame->cr) ||
!p_frame->pf || len || !RFCOMM_VALID_DLCI(p_frame->dlci) ||
!rfc_check_fcs(RFCOMM_CTRL_FRAME_LEN, p_start, fcs)) {
RFCOMM_TRACE_ERROR("Bad DISC");
return (RFC_EVENT_BAD_FRAME);
} else
return (RFC_EVENT_DISC);
case RFCOMM_UIH:
if (!RFCOMM_VALID_DLCI(p_frame->dlci)) {
RFCOMM_TRACE_ERROR("Bad UIH - invalid DLCI");
return (RFC_EVENT_BAD_FRAME);
} else if (!rfc_check_fcs(2, p_start, fcs)) {
RFCOMM_TRACE_ERROR("Bad UIH - FCS");
return (RFC_EVENT_BAD_FRAME);
} else if (RFCOMM_FRAME_IS_RSP(p_mcb->is_initiator, p_frame->cr)) {
/* we assume that this is ok to allow bad implementations to work */
RFCOMM_TRACE_ERROR("Bad UIH - response");
return (RFC_EVENT_UIH);
} else
return (RFC_EVENT_UIH);
}
return (RFC_EVENT_BAD_FRAME);
}
| null | 1 |
uint8_t rfc_parse_data(tRFC_MCB* p_mcb, MX_FRAME* p_frame, BT_HDR* p_buf) {
uint8_t ead, eal, fcs;
uint8_t* p_data = (uint8_t*)(p_buf + 1) + p_buf->offset;
uint8_t* p_start = p_data;
uint16_t len;
if (p_buf->len < RFCOMM_CTRL_FRAME_LEN) {
RFCOMM_TRACE_ERROR("Bad Length1: %d", p_buf->len);
return (RFC_EVENT_BAD_FRAME);
}
RFCOMM_PARSE_CTRL_FIELD(ead, p_frame->cr, p_frame->dlci, p_data);
if (!ead) {
RFCOMM_TRACE_ERROR("Bad Address(EA must be 1)");
return (RFC_EVENT_BAD_FRAME);
}
RFCOMM_PARSE_TYPE_FIELD(p_frame->type, p_frame->pf, p_data);
eal = *(p_data)&RFCOMM_EA;
len = *(p_data)++ >> RFCOMM_SHIFT_LENGTH1;
if (eal == 0 && p_buf->len < RFCOMM_CTRL_FRAME_LEN) {
len += (*(p_data)++ << RFCOMM_SHIFT_LENGTH2);
} else if (eal == 0) {
RFCOMM_TRACE_ERROR("Bad Length when EAL = 0: %d", p_buf->len);
android_errorWriteLog(0x534e4554, "78288018");
return RFC_EVENT_BAD_FRAME;
}
p_buf->len -= (3 + !ead + !eal + 1); /* Additional 1 for FCS */
p_buf->offset += (3 + !ead + !eal);
/* handle credit if credit based flow control */
if ((p_mcb->flow == PORT_FC_CREDIT) && (p_frame->type == RFCOMM_UIH) &&
(p_frame->dlci != RFCOMM_MX_DLCI) && (p_frame->pf == 1)) {
p_frame->credit = *p_data++;
p_buf->len--;
p_buf->offset++;
} else
p_frame->credit = 0;
if (p_buf->len != len) {
RFCOMM_TRACE_ERROR("Bad Length2 %d %d", p_buf->len, len);
return (RFC_EVENT_BAD_FRAME);
}
fcs = *(p_data + len);
/* All control frames that we are sending are sent with P=1, expect */
/* reply with F=1 */
/* According to TS 07.10 spec ivalid frames are discarded without */
/* notification to the sender */
switch (p_frame->type) {
case RFCOMM_SABME:
if (RFCOMM_FRAME_IS_RSP(p_mcb->is_initiator, p_frame->cr) ||
!p_frame->pf || len || !RFCOMM_VALID_DLCI(p_frame->dlci) ||
!rfc_check_fcs(RFCOMM_CTRL_FRAME_LEN, p_start, fcs)) {
RFCOMM_TRACE_ERROR("Bad SABME");
return (RFC_EVENT_BAD_FRAME);
} else
return (RFC_EVENT_SABME);
case RFCOMM_UA:
if (RFCOMM_FRAME_IS_CMD(p_mcb->is_initiator, p_frame->cr) ||
!p_frame->pf || len || !RFCOMM_VALID_DLCI(p_frame->dlci) ||
!rfc_check_fcs(RFCOMM_CTRL_FRAME_LEN, p_start, fcs)) {
RFCOMM_TRACE_ERROR("Bad UA");
return (RFC_EVENT_BAD_FRAME);
} else
return (RFC_EVENT_UA);
case RFCOMM_DM:
if (RFCOMM_FRAME_IS_CMD(p_mcb->is_initiator, p_frame->cr) || len ||
!RFCOMM_VALID_DLCI(p_frame->dlci) ||
!rfc_check_fcs(RFCOMM_CTRL_FRAME_LEN, p_start, fcs)) {
RFCOMM_TRACE_ERROR("Bad DM");
return (RFC_EVENT_BAD_FRAME);
} else
return (RFC_EVENT_DM);
case RFCOMM_DISC:
if (RFCOMM_FRAME_IS_RSP(p_mcb->is_initiator, p_frame->cr) ||
!p_frame->pf || len || !RFCOMM_VALID_DLCI(p_frame->dlci) ||
!rfc_check_fcs(RFCOMM_CTRL_FRAME_LEN, p_start, fcs)) {
RFCOMM_TRACE_ERROR("Bad DISC");
return (RFC_EVENT_BAD_FRAME);
} else
return (RFC_EVENT_DISC);
case RFCOMM_UIH:
if (!RFCOMM_VALID_DLCI(p_frame->dlci)) {
RFCOMM_TRACE_ERROR("Bad UIH - invalid DLCI");
return (RFC_EVENT_BAD_FRAME);
} else if (!rfc_check_fcs(2, p_start, fcs)) {
RFCOMM_TRACE_ERROR("Bad UIH - FCS");
return (RFC_EVENT_BAD_FRAME);
} else if (RFCOMM_FRAME_IS_RSP(p_mcb->is_initiator, p_frame->cr)) {
/* we assume that this is ok to allow bad implementations to work */
RFCOMM_TRACE_ERROR("Bad UIH - response");
return (RFC_EVENT_UIH);
} else
return (RFC_EVENT_UIH);
}
return (RFC_EVENT_BAD_FRAME);
}
|
@@ -517,7 +517,16 @@
return (RFC_EVENT_BAD_FRAME);
}
RFCOMM_PARSE_TYPE_FIELD(p_frame->type, p_frame->pf, p_data);
- RFCOMM_PARSE_LEN_FIELD(eal, len, p_data);
+
+ eal = *(p_data)&RFCOMM_EA;
+ len = *(p_data)++ >> RFCOMM_SHIFT_LENGTH1;
+ if (eal == 0 && p_buf->len < RFCOMM_CTRL_FRAME_LEN) {
+ len += (*(p_data)++ << RFCOMM_SHIFT_LENGTH2);
+ } else if (eal == 0) {
+ RFCOMM_TRACE_ERROR("Bad Length when EAL = 0: %d", p_buf->len);
+ android_errorWriteLog(0x534e4554, "78288018");
+ return RFC_EVENT_BAD_FRAME;
+ }
p_buf->len -= (3 + !ead + !eal + 1); /* Additional 1 for FCS */
p_buf->offset += (3 + !ead + !eal);
|
CWE-125
|
RFCOMM_PARSE_LEN_FIELD(eal, len, p_data);
|
eal = *(p_data)&RFCOMM_EA;
len = *(p_data)++ >> RFCOMM_SHIFT_LENGTH1;
if (eal == 0 && p_buf->len < RFCOMM_CTRL_FRAME_LEN) {
len += (*(p_data)++ << RFCOMM_SHIFT_LENGTH2);
} else if (eal == 0) {
RFCOMM_TRACE_ERROR("Bad Length when EAL = 0: %d", p_buf->len);
android_errorWriteLog(0x534e4554, "78288018");
return RFC_EVENT_BAD_FRAME;
}
|
150,908 |
uint8_t rfc_parse_data(tRFC_MCB* p_mcb, MX_FRAME* p_frame, BT_HDR* p_buf) {
uint8_t ead, eal, fcs;
uint8_t* p_data = (uint8_t*)(p_buf + 1) + p_buf->offset;
uint8_t* p_start = p_data;
uint16_t len;
if (p_buf->len < RFCOMM_CTRL_FRAME_LEN) {
RFCOMM_TRACE_ERROR("Bad Length1: %d", p_buf->len);
return (RFC_EVENT_BAD_FRAME);
}
RFCOMM_PARSE_CTRL_FIELD(ead, p_frame->cr, p_frame->dlci, p_data);
if (!ead) {
RFCOMM_TRACE_ERROR("Bad Address(EA must be 1)");
return (RFC_EVENT_BAD_FRAME);
}
RFCOMM_PARSE_TYPE_FIELD(p_frame->type, p_frame->pf, p_data);
eal = *(p_data)&RFCOMM_EA;
len = *(p_data)++ >> RFCOMM_SHIFT_LENGTH1;
if (eal == 0 && p_buf->len < RFCOMM_CTRL_FRAME_LEN) {
len += (*(p_data)++ << RFCOMM_SHIFT_LENGTH2);
} else if (eal == 0) {
RFCOMM_TRACE_ERROR("Bad Length when EAL = 0: %d", p_buf->len);
android_errorWriteLog(0x534e4554, "78288018");
return RFC_EVENT_BAD_FRAME;
}
p_buf->len -= (3 + !ead + !eal + 1); /* Additional 1 for FCS */
p_buf->offset += (3 + !ead + !eal);
/* handle credit if credit based flow control */
if ((p_mcb->flow == PORT_FC_CREDIT) && (p_frame->type == RFCOMM_UIH) &&
(p_frame->dlci != RFCOMM_MX_DLCI) && (p_frame->pf == 1)) {
p_frame->credit = *p_data++;
p_buf->len--;
p_buf->offset++;
} else
p_frame->credit = 0;
if (p_buf->len != len) {
RFCOMM_TRACE_ERROR("Bad Length2 %d %d", p_buf->len, len);
return (RFC_EVENT_BAD_FRAME);
}
fcs = *(p_data + len);
/* All control frames that we are sending are sent with P=1, expect */
/* reply with F=1 */
/* According to TS 07.10 spec ivalid frames are discarded without */
/* notification to the sender */
switch (p_frame->type) {
case RFCOMM_SABME:
if (RFCOMM_FRAME_IS_RSP(p_mcb->is_initiator, p_frame->cr) ||
!p_frame->pf || len || !RFCOMM_VALID_DLCI(p_frame->dlci) ||
!rfc_check_fcs(RFCOMM_CTRL_FRAME_LEN, p_start, fcs)) {
RFCOMM_TRACE_ERROR("Bad SABME");
return (RFC_EVENT_BAD_FRAME);
} else
return (RFC_EVENT_SABME);
case RFCOMM_UA:
if (RFCOMM_FRAME_IS_CMD(p_mcb->is_initiator, p_frame->cr) ||
!p_frame->pf || len || !RFCOMM_VALID_DLCI(p_frame->dlci) ||
!rfc_check_fcs(RFCOMM_CTRL_FRAME_LEN, p_start, fcs)) {
RFCOMM_TRACE_ERROR("Bad UA");
return (RFC_EVENT_BAD_FRAME);
} else
return (RFC_EVENT_UA);
case RFCOMM_DM:
if (RFCOMM_FRAME_IS_CMD(p_mcb->is_initiator, p_frame->cr) || len ||
!RFCOMM_VALID_DLCI(p_frame->dlci) ||
!rfc_check_fcs(RFCOMM_CTRL_FRAME_LEN, p_start, fcs)) {
RFCOMM_TRACE_ERROR("Bad DM");
return (RFC_EVENT_BAD_FRAME);
} else
return (RFC_EVENT_DM);
case RFCOMM_DISC:
if (RFCOMM_FRAME_IS_RSP(p_mcb->is_initiator, p_frame->cr) ||
!p_frame->pf || len || !RFCOMM_VALID_DLCI(p_frame->dlci) ||
!rfc_check_fcs(RFCOMM_CTRL_FRAME_LEN, p_start, fcs)) {
RFCOMM_TRACE_ERROR("Bad DISC");
return (RFC_EVENT_BAD_FRAME);
} else
return (RFC_EVENT_DISC);
case RFCOMM_UIH:
if (!RFCOMM_VALID_DLCI(p_frame->dlci)) {
RFCOMM_TRACE_ERROR("Bad UIH - invalid DLCI");
return (RFC_EVENT_BAD_FRAME);
} else if (!rfc_check_fcs(2, p_start, fcs)) {
RFCOMM_TRACE_ERROR("Bad UIH - FCS");
return (RFC_EVENT_BAD_FRAME);
} else if (RFCOMM_FRAME_IS_RSP(p_mcb->is_initiator, p_frame->cr)) {
/* we assume that this is ok to allow bad implementations to work */
RFCOMM_TRACE_ERROR("Bad UIH - response");
return (RFC_EVENT_UIH);
} else
return (RFC_EVENT_UIH);
}
return (RFC_EVENT_BAD_FRAME);
}
| null | 1 |
uint8_t rfc_parse_data(tRFC_MCB* p_mcb, MX_FRAME* p_frame, BT_HDR* p_buf) {
uint8_t ead, eal, fcs;
uint8_t* p_data = (uint8_t*)(p_buf + 1) + p_buf->offset;
uint8_t* p_start = p_data;
uint16_t len;
if (p_buf->len < RFCOMM_CTRL_FRAME_LEN) {
RFCOMM_TRACE_ERROR("Bad Length1: %d", p_buf->len);
return (RFC_EVENT_BAD_FRAME);
}
RFCOMM_PARSE_CTRL_FIELD(ead, p_frame->cr, p_frame->dlci, p_data);
if (!ead) {
RFCOMM_TRACE_ERROR("Bad Address(EA must be 1)");
return (RFC_EVENT_BAD_FRAME);
}
RFCOMM_PARSE_TYPE_FIELD(p_frame->type, p_frame->pf, p_data);
eal = *(p_data)&RFCOMM_EA;
len = *(p_data)++ >> RFCOMM_SHIFT_LENGTH1;
if (eal == 0 && p_buf->len > RFCOMM_CTRL_FRAME_LEN) {
len += (*(p_data)++ << RFCOMM_SHIFT_LENGTH2);
} else if (eal == 0) {
RFCOMM_TRACE_ERROR("Bad Length when EAL = 0: %d", p_buf->len);
android_errorWriteLog(0x534e4554, "78288018");
return RFC_EVENT_BAD_FRAME;
}
p_buf->len -= (3 + !ead + !eal + 1); /* Additional 1 for FCS */
p_buf->offset += (3 + !ead + !eal);
/* handle credit if credit based flow control */
if ((p_mcb->flow == PORT_FC_CREDIT) && (p_frame->type == RFCOMM_UIH) &&
(p_frame->dlci != RFCOMM_MX_DLCI) && (p_frame->pf == 1)) {
p_frame->credit = *p_data++;
p_buf->len--;
p_buf->offset++;
} else
p_frame->credit = 0;
if (p_buf->len != len) {
RFCOMM_TRACE_ERROR("Bad Length2 %d %d", p_buf->len, len);
return (RFC_EVENT_BAD_FRAME);
}
fcs = *(p_data + len);
/* All control frames that we are sending are sent with P=1, expect */
/* reply with F=1 */
/* According to TS 07.10 spec ivalid frames are discarded without */
/* notification to the sender */
switch (p_frame->type) {
case RFCOMM_SABME:
if (RFCOMM_FRAME_IS_RSP(p_mcb->is_initiator, p_frame->cr) ||
!p_frame->pf || len || !RFCOMM_VALID_DLCI(p_frame->dlci) ||
!rfc_check_fcs(RFCOMM_CTRL_FRAME_LEN, p_start, fcs)) {
RFCOMM_TRACE_ERROR("Bad SABME");
return (RFC_EVENT_BAD_FRAME);
} else
return (RFC_EVENT_SABME);
case RFCOMM_UA:
if (RFCOMM_FRAME_IS_CMD(p_mcb->is_initiator, p_frame->cr) ||
!p_frame->pf || len || !RFCOMM_VALID_DLCI(p_frame->dlci) ||
!rfc_check_fcs(RFCOMM_CTRL_FRAME_LEN, p_start, fcs)) {
RFCOMM_TRACE_ERROR("Bad UA");
return (RFC_EVENT_BAD_FRAME);
} else
return (RFC_EVENT_UA);
case RFCOMM_DM:
if (RFCOMM_FRAME_IS_CMD(p_mcb->is_initiator, p_frame->cr) || len ||
!RFCOMM_VALID_DLCI(p_frame->dlci) ||
!rfc_check_fcs(RFCOMM_CTRL_FRAME_LEN, p_start, fcs)) {
RFCOMM_TRACE_ERROR("Bad DM");
return (RFC_EVENT_BAD_FRAME);
} else
return (RFC_EVENT_DM);
case RFCOMM_DISC:
if (RFCOMM_FRAME_IS_RSP(p_mcb->is_initiator, p_frame->cr) ||
!p_frame->pf || len || !RFCOMM_VALID_DLCI(p_frame->dlci) ||
!rfc_check_fcs(RFCOMM_CTRL_FRAME_LEN, p_start, fcs)) {
RFCOMM_TRACE_ERROR("Bad DISC");
return (RFC_EVENT_BAD_FRAME);
} else
return (RFC_EVENT_DISC);
case RFCOMM_UIH:
if (!RFCOMM_VALID_DLCI(p_frame->dlci)) {
RFCOMM_TRACE_ERROR("Bad UIH - invalid DLCI");
return (RFC_EVENT_BAD_FRAME);
} else if (!rfc_check_fcs(2, p_start, fcs)) {
RFCOMM_TRACE_ERROR("Bad UIH - FCS");
return (RFC_EVENT_BAD_FRAME);
} else if (RFCOMM_FRAME_IS_RSP(p_mcb->is_initiator, p_frame->cr)) {
/* we assume that this is ok to allow bad implementations to work */
RFCOMM_TRACE_ERROR("Bad UIH - response");
return (RFC_EVENT_UIH);
} else
return (RFC_EVENT_UIH);
}
return (RFC_EVENT_BAD_FRAME);
}
|
@@ -520,7 +520,7 @@
eal = *(p_data)&RFCOMM_EA;
len = *(p_data)++ >> RFCOMM_SHIFT_LENGTH1;
- if (eal == 0 && p_buf->len < RFCOMM_CTRL_FRAME_LEN) {
+ if (eal == 0 && p_buf->len > RFCOMM_CTRL_FRAME_LEN) {
len += (*(p_data)++ << RFCOMM_SHIFT_LENGTH2);
} else if (eal == 0) {
RFCOMM_TRACE_ERROR("Bad Length when EAL = 0: %d", p_buf->len);
|
CWE-125
|
if (eal == 0 && p_buf->len < RFCOMM_CTRL_FRAME_LEN) {
|
if (eal == 0 && p_buf->len > RFCOMM_CTRL_FRAME_LEN) {
|
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.