Thanks Dan. And the changes were very clever. Some of his rule changes 
actually did make thing more readable and he is highly skilled at 
regular expressions.  I have found that readability and 
understandability is important in maintaining code. I think in a group 
project that it's more important.Daniel Quinlan wrote:>This is not a big deal, but I think Marc has a good point.  The
>performance difference is probably insignificant.  On the other hand, we
>continually have errors in regular expressions, often when "excessive
>cleverness" has been applied.
>
>This seems like a pretty good example of premature/excessive
>optimization.  There is no data showing that the relevant code is run
>for any significant period of time or that these changes produce a
>measurable improvement in performance.  Maybe they do, but it would be
>nice to know before we complicate every regular expression.
>
>In contrast, your changes to the eval loops in PerMsgStatus.pm were
>great.  The code was responsible for a lot of our execution time and
>there was a huge speed improvement.  Even better, the code was just as
>easy to understand as the original.
>
>Dan
>
>  
>
-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf
_______________________________________________
Spamassassin-devel mailing list
Spamassassin-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/spamassassin-devel
