Actually, the US Army screwed up.  He was supposed to get a DISHONORABLE discharge, but even his lawyer was surprised when he did not.  If he had received a dishonorable discharge he would NOT have been able to purchase a firearm.