SWE-bench: Can Language Models Resolve Real-World GitHub Issues?
Paper • 2310.06770 • Published • 9
instance_id stringlengths 17 39 | repo stringclasses 8
values | issue_id stringlengths 14 34 | pr_id stringlengths 14 34 | linking_methods sequencelengths 1 3 | base_commit stringlengths 40 40 | merge_commit stringlengths 0 40 ⌀ | hints_text sequencelengths 0 106 | resolved_comments sequencelengths 0 119 | created_at timestamp[ns, tz=UTC] | labeled_as sequencelengths 0 7 | problem_title stringlengths 7 174 | problem_statement stringlengths 0 55.4k | gold_files sequencelengths 0 10 | gold_files_postpatch sequencelengths 1 10 | test_files sequencelengths 0 60 | gold_patch stringlengths 220 5.83M | test_patch stringlengths 386 194k ⌀ | split_random stringclasses 3
values | split_time stringclasses 3
values | issue_start_time timestamp[ns] | issue_created_at timestamp[ns, tz=UTC] | issue_by_user stringlengths 3 21 | split_repo stringclasses 3
values |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
square/retrofit/63_66 | square/retrofit | square/retrofit/63 | square/retrofit/66 | [
"timestamp(timedelta=611.0, similarity=0.9184791542342733)"
] | e997c7218efa52faf9b91022a8f9ad46091aa05c | 292340be8ce436aad6b50fb7706bc0ae86d02704 | [
"`Fetcher` removed.\n"
] | [
"`1f *` is way cuter than (float) . . . fun.\n\nNit: it isn't 'percent' anymore, it's 'fraction'\n",
"Say `Guarded by 'this'` rather than `Synchronized on 'this'.` ?\n"
] | 2012-10-17T06:28:33 | [] | Change Fetcher API To Report Progress as Float | From @swankjesse on #62:
> It would be more conventional for the progress listener to just take a float between 0 and 1. It's sort of weird that a UI decision (progress update granularity) is being decided here.
>
> In slow transfers (say 1MiB over 3G) using percent is lame because multiple reads may yield the same p... | [
"http/src/main/java/retrofit/http/Fetcher.java",
"http/src/main/java/retrofit/http/ProgressListener.java"
] | [
"http/src/main/java/retrofit/http/Fetcher.java",
"http/src/main/java/retrofit/http/ProgressListener.java"
] | [
"http/src/test/java/retrofit/http/FetcherTest.java"
] | diff --git a/http/src/main/java/retrofit/http/Fetcher.java b/http/src/main/java/retrofit/http/Fetcher.java
index 8f4d1f66e8..37cc0df1c3 100644
--- a/http/src/main/java/retrofit/http/Fetcher.java
+++ b/http/src/main/java/retrofit/http/Fetcher.java
@@ -71,9 +71,6 @@ public void run() {
}
static class DownloadHand... | diff --git a/http/src/test/java/retrofit/http/FetcherTest.java b/http/src/test/java/retrofit/http/FetcherTest.java
index cbddcff439..589ccc9b84 100644
--- a/http/src/test/java/retrofit/http/FetcherTest.java
+++ b/http/src/test/java/retrofit/http/FetcherTest.java
@@ -17,7 +17,7 @@
import java.util.Arrays;
import java.... | test | train | 2012-10-17T08:07:13 | 2012-10-16T00:06:09 | JakeWharton | val |
square/retrofit/105_106 | square/retrofit | square/retrofit/105 | square/retrofit/106 | [
"timestamp(timedelta=83.0, similarity=0.8480295100306232)"
] | 05db64dbebe4873cc36099e14a6eb7bd4858dace | 3eac5515bfebfafa8a8af3742705e400f85bb248 | [] | [] | 2012-11-28T05:57:22 | [] | Change Thread Names Based On Current Request | To make thread dump debugging a lot more clear.
| [
"retrofit/src/main/java/retrofit/http/Platform.java",
"retrofit/src/main/java/retrofit/http/RestAdapter.java"
] | [
"retrofit/src/main/java/retrofit/http/Platform.java",
"retrofit/src/main/java/retrofit/http/RestAdapter.java"
] | [] | diff --git a/retrofit/src/main/java/retrofit/http/Platform.java b/retrofit/src/main/java/retrofit/http/Platform.java
index 377cdcc596..fa72a470c4 100644
--- a/retrofit/src/main/java/retrofit/http/Platform.java
+++ b/retrofit/src/main/java/retrofit/http/Platform.java
@@ -14,6 +14,7 @@
import static android.os.Process... | null | train | train | 2012-11-28T06:32:02 | 2012-11-28T01:04:31 | JakeWharton | val |
square/retrofit/113_115 | square/retrofit | square/retrofit/113 | square/retrofit/115 | [
"timestamp(timedelta=1170.0, similarity=0.850510378883364)"
] | bc304b3093193e79c9c2094b2caecde852888f1e | 2adc5af775727d56e6bdbd8417ddad9f1ef7fd4f | [
"See #115 for pull request.\n"
] | [] | 2012-12-10T21:36:25 | [] | If no parameters are present after creating request, do not append ? to URI | I have noticed that the ? is always present at the end of URIs. This is completely valid, I suspect, but it was unexpected when I was making some Robolectric unit tests to check if the thing was sending the information to the correct URI. Perhaps, if the parameters are empty (as in there are no parameters to be appende... | [
"retrofit/src/main/java/retrofit/http/HttpMethodType.java"
] | [
"retrofit/src/main/java/retrofit/http/HttpMethodType.java"
] | [
"retrofit/src/test/java/retrofit/http/RestAdapterTest.java"
] | diff --git a/retrofit/src/main/java/retrofit/http/HttpMethodType.java b/retrofit/src/main/java/retrofit/http/HttpMethodType.java
index d1a58e973a..fc981b49b8 100644
--- a/retrofit/src/main/java/retrofit/http/HttpMethodType.java
+++ b/retrofit/src/main/java/retrofit/http/HttpMethodType.java
@@ -84,6 +84,9 @@ private sta... | diff --git a/retrofit/src/test/java/retrofit/http/RestAdapterTest.java b/retrofit/src/test/java/retrofit/http/RestAdapterTest.java
index 87552a85ac..d7ead7d0ad 100644
--- a/retrofit/src/test/java/retrofit/http/RestAdapterTest.java
+++ b/retrofit/src/test/java/retrofit/http/RestAdapterTest.java
@@ -49,7 +49,8 @@ public ... | val | train | 2012-12-06T05:18:41 | 2012-12-06T23:30:52 | thorinside | val |
square/retrofit/112_127 | square/retrofit | square/retrofit/112 | square/retrofit/127 | [
"timestamp(timedelta=62234.0, similarity=0.9450963938144088)"
] | 6800bb199a4f23b76c43c543e5bfe83383e8c8e0 | dc4fd8cda39016cf9f38441416a4000d50753d72 | [
"#127 \n"
] | [
"Rather than doing a loop with two splits, you might be better off with a single regex. Perhaps a case-insensitive pattern like `(?i)\\Wcharset=([^\\s]+)`\n\n(From Guava's tests, content types look like this: `application/atom+xml; a=1; a=2; b=3`)\n",
"Guava's tests suggest that charset can be in upper case.\n",
... | 2012-12-19T04:09:14 | [] | Force UTF8 everywhere. Blow-up otherwise. | It will please @swankjesse.
| [
"retrofit/src/main/java/retrofit/http/GsonConverter.java",
"retrofit/src/main/java/retrofit/http/HttpMethodType.java",
"retrofit/src/main/java/retrofit/http/RestAdapter.java",
"retrofit/src/main/java/retrofit/http/Types.java"
] | [
"retrofit/src/main/java/retrofit/http/GsonConverter.java",
"retrofit/src/main/java/retrofit/http/HttpMethodType.java",
"retrofit/src/main/java/retrofit/http/RestAdapter.java",
"retrofit/src/main/java/retrofit/http/Utils.java"
] | [
"retrofit/src/test/java/retrofit/http/UtilsTest.java"
] | diff --git a/retrofit/src/main/java/retrofit/http/GsonConverter.java b/retrofit/src/main/java/retrofit/http/GsonConverter.java
index 01213902b6..6dbb992be9 100644
--- a/retrofit/src/main/java/retrofit/http/GsonConverter.java
+++ b/retrofit/src/main/java/retrofit/http/GsonConverter.java
@@ -12,13 +12,14 @@
import retro... | diff --git a/retrofit/src/test/java/retrofit/http/UtilsTest.java b/retrofit/src/test/java/retrofit/http/UtilsTest.java
new file mode 100644
index 0000000000..e529f7f033
--- /dev/null
+++ b/retrofit/src/test/java/retrofit/http/UtilsTest.java
@@ -0,0 +1,24 @@
+// Copyright 2012 Square, Inc.
+package retrofit.http;
+
+imp... | val | train | 2012-12-19T05:21:53 | 2012-12-06T05:59:59 | JakeWharton | val |
square/retrofit/122_129 | square/retrofit | square/retrofit/122 | square/retrofit/129 | [
"keyword_pr_to_issue"
] | 5fecbc6381f538658a63e9675449467f27170ea2 | 9942d8e08ec1c5346863207e77d8885416edca8b | [
"Fixed by #129.\n"
] | [
"not doing this per-request is very good\n",
"HashSet --> LinkedHashSet\n",
"HashMap --> LinkedHashMap\n",
"Would it be better to create all the methods eagerly? I could go either way myself.\n\nNot that I offer any alternatives, but Method.equals() is a painfully slow method. It uses toString(). Sigh.\n",
... | 2012-12-19T10:04:07 | [] | Lazily Cache Endpoint Metadata | We calculate a lot of metadata on endpoint definitions with every invocation. The heavy hitters should be cached in the anonymous proxy class generated by `RestAdapter` to avoid doing reflection on every API call.
Might be useful to abstract everything into a POJO and use a `Map<Method, MethodMetadata>` or something.
| [
"retrofit/src/main/java/retrofit/http/HttpRequestBuilder.java",
"retrofit/src/main/java/retrofit/http/Platform.java",
"retrofit/src/main/java/retrofit/http/RequestLine.java",
"retrofit/src/main/java/retrofit/http/RestAdapter.java",
"retrofit/src/main/java/retrofit/http/Utils.java"
] | [
"retrofit/src/main/java/retrofit/http/HttpRequestBuilder.java",
"retrofit/src/main/java/retrofit/http/Platform.java",
"retrofit/src/main/java/retrofit/http/RestAdapter.java",
"retrofit/src/main/java/retrofit/http/Utils.java"
] | [
"retrofit/src/test/java/retrofit/http/HttpRequestBuilderTest.java",
"retrofit/src/test/java/retrofit/http/RestAdapterTest.java"
] | diff --git a/retrofit/src/main/java/retrofit/http/HttpRequestBuilder.java b/retrofit/src/main/java/retrofit/http/HttpRequestBuilder.java
index 37a283e851..4c919f896e 100644
--- a/retrofit/src/main/java/retrofit/http/HttpRequestBuilder.java
+++ b/retrofit/src/main/java/retrofit/http/HttpRequestBuilder.java
@@ -1,22 +1,2... | diff --git a/retrofit/src/test/java/retrofit/http/HttpRequestBuilderTest.java b/retrofit/src/test/java/retrofit/http/HttpRequestBuilderTest.java
index 59077f472b..b13e752130 100644
--- a/retrofit/src/test/java/retrofit/http/HttpRequestBuilderTest.java
+++ b/retrofit/src/test/java/retrofit/http/HttpRequestBuilderTest.ja... | test | train | 2012-12-19T22:27:50 | 2012-12-18T07:58:43 | JakeWharton | val |
square/retrofit/130_132 | square/retrofit | square/retrofit/130 | square/retrofit/132 | [
"keyword_issue_to_pr",
"keyword_pr_to_issue"
] | 89fd13bbe7af39573cce9e6d3cfd61d3f5bb7b2d | 8e92fdaf54bc1f3293c0de59e4e85ba97c200333 | [
"Fixed by #132 .\n"
] | [
"use `Class<?>` here. Otherwise somebody might accidentally pass a parameterized type, and that'll never work in comparison against `getDeclaringClass()`.\n"
] | 2012-12-20T21:25:22 | [] | Calling Non-endpoint Methods Triggers Logic | We need to only proceed trying to make an HTTP request if the method invoked on the `InvocationHandler` is annotated with one of our HTTP verb annotations.
| [
"retrofit/src/main/java/retrofit/http/RestAdapter.java"
] | [
"retrofit/src/main/java/retrofit/http/RestAdapter.java"
] | [
"retrofit/src/test/java/retrofit/http/RestAdapterTest.java"
] | diff --git a/retrofit/src/main/java/retrofit/http/RestAdapter.java b/retrofit/src/main/java/retrofit/http/RestAdapter.java
index 37c9647df5..4e3fc72464 100644
--- a/retrofit/src/main/java/retrofit/http/RestAdapter.java
+++ b/retrofit/src/main/java/retrofit/http/RestAdapter.java
@@ -5,6 +5,7 @@
import java.io.Unsupport... | diff --git a/retrofit/src/test/java/retrofit/http/RestAdapterTest.java b/retrofit/src/test/java/retrofit/http/RestAdapterTest.java
index 068ec3da3b..9b3a6f03ae 100644
--- a/retrofit/src/test/java/retrofit/http/RestAdapterTest.java
+++ b/retrofit/src/test/java/retrofit/http/RestAdapterTest.java
@@ -539,7 +539,6 @@ publi... | train | train | 2012-12-20T22:06:40 | 2012-12-19T23:51:45 | JakeWharton | val |
square/retrofit/154_158 | square/retrofit | square/retrofit/154 | square/retrofit/158 | [
"timestamp(timedelta=6.0, similarity=0.8424064248324534)"
] | a7755edc83d3907204093840a7c15d954120c926 | ab81d9058ef899ecd91f81e4d195b920c157e6ff | [
"I was going to take a stab at this, but according to http://stackoverflow.com/questions/4669692/valid-characters-for-directory-part-of-a-url-for-short-links and the referenced RFCs, this appears to be appropriate behavior for a URL path. Maybe there is something I'm missing, but it appears that { and } require per... | [
"You can just `return` here and drop the first and last line.\n",
"All the changes in this file need to be two-space indentation instead of four.\n",
"Sorry, do you guys have a format template for eclipse? I'm fighting my own\ntemplate to try to keep things styled like the rest of the project.\nOn Feb 24, 2013 ... | 2013-02-24T18:40:10 | [] | Path Params Are Incorrectly Encoded As Query Params | ``` java
@GET("/foo/{bar}/")
Response a(@Name("bar") String bar)
```
``` java
a("{baz}");
```
is incorrectly encoded to `/foo/%7Bpbaz%7D/` instead of `/foo/{baz}/`.
| [
"retrofit/src/main/java/retrofit/http/RequestBuilder.java"
] | [
"retrofit/src/main/java/retrofit/http/RequestBuilder.java"
] | [
"retrofit/src/test/java/retrofit/http/RequestBuilderTest.java"
] | diff --git a/retrofit/src/main/java/retrofit/http/RequestBuilder.java b/retrofit/src/main/java/retrofit/http/RequestBuilder.java
index 2fe5394137..d73adcdd8b 100644
--- a/retrofit/src/main/java/retrofit/http/RequestBuilder.java
+++ b/retrofit/src/main/java/retrofit/http/RequestBuilder.java
@@ -88,12 +88,7 @@ Request bu... | diff --git a/retrofit/src/test/java/retrofit/http/RequestBuilderTest.java b/retrofit/src/test/java/retrofit/http/RequestBuilderTest.java
index 7615893a2d..7de05d4f12 100644
--- a/retrofit/src/test/java/retrofit/http/RequestBuilderTest.java
+++ b/retrofit/src/test/java/retrofit/http/RequestBuilderTest.java
@@ -76,6 +76,... | val | train | 2013-02-22T16:32:06 | 2013-02-20T07:53:09 | JakeWharton | val |
square/retrofit/163_164 | square/retrofit | square/retrofit/163 | square/retrofit/164 | [
"timestamp(timedelta=2.0, similarity=0.8664043957630777)"
] | db20a59b2819fbe4fe7e9a8478b726b592dc3971 | 258e289385c75d2f3104d487eba98731358a28ae | [
"We force the implementations of `Client` to parse the \"Content-Type\" header in order to create a `TypedInput` for the response. This `TypedInput` is handed directly to the response converter which is responsible for decoding the bytes in accordance to the MIME type and encoding. Having the iteration here is not ... | [] | 2013-03-07T17:15:20 | [] | Relax UTF-8 requirements or make configurable | In RestAdapter.invokeRequest(RestMethodInfo methodDetails, Object[] args)
this check (line ~186)
``` java
for (Header header : headers) {
if (HTTP.CONTENT_TYPE.equalsIgnoreCase(header.getName()) //
&& !UTF_8.equalsIgnoreCase(Utils.parseCharset(header.getValue()))) {
throw n... | [
"retrofit/src/main/java/retrofit/http/GsonConverter.java",
"retrofit/src/main/java/retrofit/http/RequestBuilder.java",
"retrofit/src/main/java/retrofit/http/RestAdapter.java",
"retrofit/src/main/java/retrofit/http/Utils.java"
] | [
"retrofit/src/main/java/retrofit/http/GsonConverter.java",
"retrofit/src/main/java/retrofit/http/RequestBuilder.java",
"retrofit/src/main/java/retrofit/http/RestAdapter.java",
"retrofit/src/main/java/retrofit/http/Utils.java"
] | [
"retrofit/src/test/java/retrofit/http/UtilsTest.java"
] | diff --git a/retrofit/src/main/java/retrofit/http/GsonConverter.java b/retrofit/src/main/java/retrofit/http/GsonConverter.java
index ae032b3e68..a2372291bb 100644
--- a/retrofit/src/main/java/retrofit/http/GsonConverter.java
+++ b/retrofit/src/main/java/retrofit/http/GsonConverter.java
@@ -11,8 +11,6 @@
import retrofi... | diff --git a/retrofit/src/test/java/retrofit/http/UtilsTest.java b/retrofit/src/test/java/retrofit/http/UtilsTest.java
index a81347f377..5176f02309 100644
--- a/retrofit/src/test/java/retrofit/http/UtilsTest.java
+++ b/retrofit/src/test/java/retrofit/http/UtilsTest.java
@@ -4,21 +4,20 @@
import org.junit.Test;
impo... | train | train | 2013-03-07T10:09:00 | 2013-03-07T15:59:55 | brh | val |
square/retrofit/142_180 | square/retrofit | square/retrofit/142 | square/retrofit/180 | [
"timestamp(timedelta=2.0, similarity=0.9750595156461359)"
] | 2fcabb79e66d572725c72950e4a73dab1e328985 | ee8bca47f9ba7cc2c5dd83b665b8f0d642209d8d | [
"Sadly this doesn't save as much work as you'd hope. The `Object...` means that the arguments get boxed into an array, after any primitive arguments get boxed into their wrapper types. Worst of all, values that need to be computed still need to be computed:\n\n```\n Log.debug(\"The result is %s\", someExpensiveOp... | [
"What's with the ugly arrow?\n",
"Include request duration? length?\n",
"Indicated direction of data. Without they look very similar in the logs flying by.\n"
] | 2013-04-12T04:24:31 | [] | Abstract Logging API | Easier control over sending the logs. And deferring string replacements using something like:
``` java
public void log(String message, Object... args);
```
| [
"retrofit/src/main/java/retrofit/http/Platform.java",
"retrofit/src/main/java/retrofit/http/RestAdapter.java"
] | [
"retrofit/src/main/java/retrofit/http/Platform.java",
"retrofit/src/main/java/retrofit/http/RestAdapter.java"
] | [] | diff --git a/retrofit/src/main/java/retrofit/http/Platform.java b/retrofit/src/main/java/retrofit/http/Platform.java
index 28ad856133..da9bfc7fee 100644
--- a/retrofit/src/main/java/retrofit/http/Platform.java
+++ b/retrofit/src/main/java/retrofit/http/Platform.java
@@ -2,6 +2,7 @@
import android.os.Build;
import a... | null | train | train | 2013-03-30T00:50:17 | 2013-02-12T05:28:47 | JakeWharton | val |
square/retrofit/188_190 | square/retrofit | square/retrofit/188 | square/retrofit/190 | [
"timestamp(timedelta=1.0, similarity=0.9123221038546971)"
] | 1af9c9595077a7cfc0c30c3669208cc5bd047407 | 1c5b74c8ed760755195ca6082c6d9890296eae38 | [] | [] | 2013-05-04T03:06:18 | [] | Clear Thread Name When Idle | Reset the thread name to "Retrofit-Idle" when the background operations complete.
| [
"retrofit/src/main/java/retrofit/http/Platform.java",
"retrofit/src/main/java/retrofit/http/RestAdapter.java"
] | [
"retrofit/src/main/java/retrofit/http/Platform.java",
"retrofit/src/main/java/retrofit/http/RestAdapter.java"
] | [] | diff --git a/retrofit/src/main/java/retrofit/http/Platform.java b/retrofit/src/main/java/retrofit/http/Platform.java
index da9bfc7fee..1a8de06d21 100644
--- a/retrofit/src/main/java/retrofit/http/Platform.java
+++ b/retrofit/src/main/java/retrofit/http/Platform.java
@@ -7,7 +7,6 @@
import java.util.concurrent.Executor... | null | train | train | 2013-05-04T04:01:42 | 2013-05-02T18:20:14 | JakeWharton | val |
square/retrofit/199_201 | square/retrofit | square/retrofit/199 | square/retrofit/201 | [
"timestamp(timedelta=1.0, similarity=0.889659614331013)"
] | 6ce88d01a3264cbbbb5bc94ff3fce0976075f08f | bca23bc0e8e8302945f19c29fb2c2feb95e8adc5 | [
"Ah so it looks like the regular expression that matches path params does not accept digits -- `private static final Pattern PATH_PARAMETERS = Pattern.compile(\"\\\\{([a-z_-]+)\\\\}\");` at https://github.com/square/retrofit/blob/master/retrofit/src/main/java/retrofit/http/RestMethodInfo.java#L18.\n\nWas it intenti... | [] | 2013-05-09T09:12:18 | [] | Named path params ending with digits should be valid | The following test should pass: https://github.com/matthewmichihara/retrofit/commit/abfade69c7ab213fd07dbcc2604f5942c3324114
| [
"retrofit/src/main/java/retrofit/http/RestMethodInfo.java"
] | [
"retrofit/src/main/java/retrofit/http/RestMethodInfo.java"
] | [
"retrofit/src/test/java/retrofit/http/RestMethodInfoTest.java"
] | diff --git a/retrofit/src/main/java/retrofit/http/RestMethodInfo.java b/retrofit/src/main/java/retrofit/http/RestMethodInfo.java
index e7ac42b56e..8591265de1 100644
--- a/retrofit/src/main/java/retrofit/http/RestMethodInfo.java
+++ b/retrofit/src/main/java/retrofit/http/RestMethodInfo.java
@@ -15,7 +15,10 @@
/** Cache... | diff --git a/retrofit/src/test/java/retrofit/http/RestMethodInfoTest.java b/retrofit/src/test/java/retrofit/http/RestMethodInfoTest.java
index 80255d253c..7591ecfd38 100644
--- a/retrofit/src/test/java/retrofit/http/RestMethodInfoTest.java
+++ b/retrofit/src/test/java/retrofit/http/RestMethodInfoTest.java
@@ -31,6 +31,... | test | train | 2013-05-09T03:24:11 | 2013-05-09T01:44:40 | matthewmichihara | val |
square/retrofit/193_223 | square/retrofit | square/retrofit/193 | square/retrofit/223 | [
"keyword_issue_to_pr"
] | b1dc27cb52903b298af02324f1df6468dac37945 | 7f081c863751bd6b1f9c845d0038d959b74c8946 | [
"Is there a standard for object to XML mapping? GSON and Jackson are the canonical JSON mappers, protocol buffers are protocol buffers, etc.\n",
"Most common is jaxb. It it is a wreck for generic types. Ex. it forces you to make classes like `Things` as `List<Thing>` isn't possible at top-level. Jackson 2+ ha... | [
"probably need addQueryParam, unless addPathParam implies this. (ex. many signatures are query parameters)\n",
"I'm ok leaving this out, but affecting the body of the request often comes up in crappier apis (like SOAP). If we leave this out, I'd need to do it in a custom http impl I think.\n",
"I had query in... | 2013-05-25T03:03:41 | [] | XML api sample | Would be nice to be able to easily use retrofit for XML apis like AWS. I'll volunteer to make a sample, if you don't mind giving me pointers as to what might be needed in abstract.
| [
"CHANGELOG.md",
"pom.xml",
"retrofit-samples/github-client/pom.xml",
"retrofit-samples/pom.xml",
"retrofit/pom.xml",
"retrofit/src/main/java/retrofit/RequestBuilder.java",
"retrofit/src/main/java/retrofit/RequestHeaders.java",
"retrofit/src/main/java/retrofit/RestAdapter.java",
"retrofit/src/main/ja... | [
"CHANGELOG.md",
"pom.xml",
"retrofit-samples/github-client/pom.xml",
"retrofit-samples/pom.xml",
"retrofit/pom.xml",
"retrofit/src/main/java/retrofit/RequestBuilder.java",
"retrofit/src/main/java/retrofit/RequestInterceptor.java",
"retrofit/src/main/java/retrofit/RestAdapter.java",
"retrofit/src/mai... | [
"retrofit/src/test/java/retrofit/RequestBuilderTest.java",
"retrofit/src/test/java/retrofit/RestAdapterTest.java",
"retrofit/src/test/java/retrofit/RestMethodInfoTest.java"
] | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 4ea6cde500..91e269fb94 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,6 +1,14 @@
Change Log
==========
+Version 1.1.0 *(In Development)*
+--------------------------------
+
+ * Introduce `RequestInterceptor` to replace `RequestHeaders`. An interceptor provided to t... | diff --git a/retrofit/src/test/java/retrofit/RequestBuilderTest.java b/retrofit/src/test/java/retrofit/RequestBuilderTest.java
index 0f0b207569..11fe09615d 100644
--- a/retrofit/src/test/java/retrofit/RequestBuilderTest.java
+++ b/retrofit/src/test/java/retrofit/RequestBuilderTest.java
@@ -21,7 +21,13 @@
import stat... | train | train | 2013-06-03T08:52:03 | 2013-05-07T19:05:14 | codefromthecrypt | val |
square/retrofit/221_246 | square/retrofit | square/retrofit/221 | square/retrofit/246 | [
"timestamp(timedelta=0.0, similarity=0.8643421939391179)",
"keyword_pr_to_issue"
] | c7484864352c6367300a5ae398880450d6b843ff | 738e41c113c0429d6ae51d68d5f55c79d5988c15 | [
"Yep. Good catch!\n",
"Is there any method allowing custom timeout value in retrofit?\n",
"@uKL No. It's an HTTP client configuration and thus should be configured there. We will provide defaults for use with the default HTTP clients, though.\n",
"Roger that. So I'll have to implement _Client_ interface and c... | [] | 2013-06-24T23:05:26 | [] | UrlConnectionClient default timeouts behavior | I think that the connection and read timeout in `UrlConnectionClient.java` should be set to specific values other than the defaults.
With OkHttp the default are 0 for both of them.
The [documentation](http://developer.android.com/reference/java/net/URLConnection.html#setReadTimeout%28int%29) for ReadTimeout says:
> S... | [
"retrofit/src/main/java/retrofit/client/ApacheClient.java",
"retrofit/src/main/java/retrofit/client/OkClient.java",
"retrofit/src/main/java/retrofit/client/UrlConnectionClient.java"
] | [
"retrofit/src/main/java/retrofit/client/ApacheClient.java",
"retrofit/src/main/java/retrofit/client/Defaults.java",
"retrofit/src/main/java/retrofit/client/OkClient.java",
"retrofit/src/main/java/retrofit/client/UrlConnectionClient.java"
] | [] | diff --git a/retrofit/src/main/java/retrofit/client/ApacheClient.java b/retrofit/src/main/java/retrofit/client/ApacheClient.java
index 1b75da3d19..480f1cd14c 100644
--- a/retrofit/src/main/java/retrofit/client/ApacheClient.java
+++ b/retrofit/src/main/java/retrofit/client/ApacheClient.java
@@ -32,17 +32,27 @@
import o... | null | test | train | 2013-06-20T21:40:55 | 2013-05-21T21:52:03 | niqo01 | val |
square/retrofit/250_251 | square/retrofit | square/retrofit/250 | square/retrofit/251 | [
"timestamp(timedelta=0.0, similarity=0.8664596156238292)"
] | 37b2290403a2840147c8c70f07c4cde111f5f9ed | 25f9145e018c871b5bbcfd3cd82213e4325ff676 | [] | [] | 2013-06-25T20:21:07 | [] | Allow to pass null for @Part | [
"retrofit/src/main/java/retrofit/RequestBuilder.java",
"retrofit/src/main/java/retrofit/mime/MultipartTypedOutput.java"
] | [
"retrofit/src/main/java/retrofit/RequestBuilder.java",
"retrofit/src/main/java/retrofit/mime/MultipartTypedOutput.java"
] | [
"retrofit/src/test/java/retrofit/RequestBuilderTest.java"
] | diff --git a/retrofit/src/main/java/retrofit/RequestBuilder.java b/retrofit/src/main/java/retrofit/RequestBuilder.java
index 5023b2e428..0b85c4369e 100644
--- a/retrofit/src/main/java/retrofit/RequestBuilder.java
+++ b/retrofit/src/main/java/retrofit/RequestBuilder.java
@@ -167,14 +167,12 @@ void setArguments(Object[] ... | diff --git a/retrofit/src/test/java/retrofit/RequestBuilderTest.java b/retrofit/src/test/java/retrofit/RequestBuilderTest.java
index 8d916123f5..0266007289 100644
--- a/retrofit/src/test/java/retrofit/RequestBuilderTest.java
+++ b/retrofit/src/test/java/retrofit/RequestBuilderTest.java
@@ -315,6 +315,30 @@ public class... | train | train | 2013-06-25T20:20:12 | 2013-06-25T20:00:10 | dnkoutso | val |
Copyright 2024 Feedback2Code
Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.