Danish Foundation Models org
edited 15 days ago

This PR adds Memo from:
https://huggingface.co/datasets/chcaa/memo-canonical-novels

It includes a create.py documenting sample creation and a readme.

Before pushing, I made sure to run the make test to ensure that the dataset could be loaded and make bump-version.

I also made minor changes to the pyproject.toml, notably moved script-specific dependencies to the script itself (following the new standard for declaring in script dependencies). E.g. can be uses via. UV, though it is a pep standard.

This should make the script more reproducible.

KennethEnevoldsen changed pull request status to open
Danish Foundation Models org

@kris927b do you have the time to review this?

Danish Foundation Models org

@KennethEnevoldsen Looks good to me.

With the new way of adding dependencies to the individual it might make sense to add a note in the CONTRIBUTING.md file about it?

Danish Foundation Models org

Fixed!

KennethEnevoldsen changed pull request status to merged
Your need to confirm your account before you can post a new comment.

Sign up or log in to comment