[17:30:07] bearND: did you have a chance to see my comment regarding my login problem into the app [17:34:05] https://phabricator.wikimedia.org/T150529 [17:54:21] matanya: I just responded on the ticket. BTW, niedzielski is current Android tech lead. We rotate this responsibility around every 6 months. [17:54:59] aha, cool, thankd bearND [18:48:39] hello all, I am noticing something weird with the explore in the bottom navigation bar in the wikipedia alpha app. [18:48:56] It doesn't seem to be displaying correctly all the time [18:49:13] Sometimes the Wikipedia logo shown in the top bar in the explore feed also doesn't seem to be displaying correctly (i.e.) sometimes some letters are missing [18:49:33] Is this a known issue? [19:04:21] dr0ptp4kt: product planning? [19:04:44] correction: explore in the first message refers to the "explore icon" [19:04:45] olliv: there shortly [19:14:40] kaartic: i don't think so. if you can repro, would you mind reporting a bug here? https://phabricator.wikimedia.org/tag/wikipedia-android-app-backlog/ [19:14:59] (there's a link in the sidebar for reporting bugs) [19:19:49] hey niedzielski [19:20:01] do you have to test on a local instance? Or could you point to a parsoid/beta labs instance? [19:20:17] importing templates is always a bit of a pain [19:20:59] jdlrobson: hm, i was just assuming that most devs use local instances and had some secret sauce i didn't :] [19:21:39] jdlrobson: for a parsoid / beta labs instance, are you mirroring a wikipedia or how would that be different? [19:22:06] niedzielski: I am able to see this at random intervals. Not sure if this is reproducible all the time. What I have for proof is a couple of screenshots showing the problem ? Is it the worth creating a bug if it's not reproducible at random intervals? [19:22:39] *sorry about that ? after the third sentence [19:23:02] kaartic: screen shots would be perfect! repro steps are ideal but at least a clear demonstration of the bug is really helpful [19:23:14] kaartic: so i say make the bug :] [19:23:19] er, phab ticket [19:23:24] niedzielski: oh you want to test on mobilefrontend? [19:23:44] niedzielski: ok :) [19:24:11] niedzielski: you can cherrypick https://gerrit.wikimedia.org/r/313611 and use MCS :) [19:25:37] jdlrobson: well, i have changes in mobileapp and mobilefrontend. that looks like it would be good first test for the mobilefrontend changes! [19:34:06] nataliaharateh: FYI you should join #wikimedia-ios if you have not [20:09:02] dbrant: i just noticed that the set-cookie header isn’t on requests the first time on a fresh install. Is there a particular API that causes this header to start getting set? [20:09:43] coreyfloyd: hmm, that shouldn't be the case. [20:10:18] definitely seeing it… [20:10:33] i have to close and reopen the app to get it to start working [20:13:09] i'm getting it on the very first response (in our case from RestBase, but you should get it from api.php as well). [20:18:44] dbrant: weird [20:19:51] dbrant: the first call yo make to the announcements end pint or the first call you make to any rest base api? [20:20:27] and also… are you making any other calls in the app first before calling the announcements endpoint? [20:21:12] coreyfloyd: our first call is to the aggregated feed endpoint. I'm just about to wire up the call to the announcement endpoint, which will become first. I'll let you know if I get the cookie then. [20:24:37] dbrant: ok - actually the issue is different than i suspected… sometimes the cookie just isn’t there [20:24:56] dbrant: not sure how to repro yet [20:25:52] coreyfloyd: i'm pretty sure the server will always send back the cookie, as long as you don't include it in your request. [20:26:40] dbrant: oh… so we don’t manually control the cookies in the app really… so basically we need to guarantee that cookies aren’t sent with this request [20:29:01] coreyfloyd: when the app is first installed and launched, it should always receive the cookie because it doesn't have it yet. That's really all we're looking for. [20:31:35] dbrant: ok - I was checking on every request [20:31:43] looking now and confirming that behavior [20:31:52] we are sending the cookie back [20:32:48] coreyfloyd: yeah, that's kind of a "limitation" -- you won't be able to "update" the user's location unless you clear the cookie manually. [20:39:51] dbrant: got it… just checking the cookie and the header now [21:58:02] Volker_E: can you be in the office tomorrow? [22:09:08] nzr: you coming to meeting? [22:17:35] maxbinder: coming [23:15:08] jdlrobson: tomorrow is my bday and I'm def not in the office :P [23:15:16] booooooo to getting old! [23:25:55] jdlrobson: true dat