Beefy Boxes and Bandwidth Generously Provided by pair Networks Bob
laziness, impatience, and hubris

Re^6: Preferred technique for named subroutine parameters?

by Porculus (Hermit)
on May 23, 2009 at 23:07 UTC ( #765867=note: print w/ replies, xml ) Need Help??

in reply to Re^5: Preferred technique for named subroutine parameters?
in thread Preferred technique for named subroutine parameters?

More typing for you, less typing for the poor souls who are actually calling your function. Swings and roundabouts.

Frankly, all the arguments based on catching odd numbers of arguments ring a bit hollow. The most likely case for this kind of bug is where someone carelessly writes

some_function(foo => $foo, bar => @bar);

in which case using an anonymous hashref will only catch the problem if @bar has an even number of elements. That's a pretty marginal gain.

If you actually want your function to be robust, you still have to validate the parameters, or you're asking for all kinds of interesting fun when @bar is three elements long and $bar[1] eq 'foo' (or any other valid parameter name). So you still have to do extra typing, and you still have to throw runtime errors. In this case, having the parameters as a flat list is actually helpful: it means you can detect and warn about duplicate keys, instead of having them silently swallowed by the conversion to a hash.

Or you could be lazy and not validate ... but if you're not worried about even-lengthed garbage inputs, why do you care about odd-lengthed garbage inputs?

Comment on Re^6: Preferred technique for named subroutine parameters?
Select or Download Code
Re^7: Preferred technique for named subroutine parameters?
by bluto (Curate) on May 26, 2009 at 16:42 UTC
    ++. If you are going to write verification code, then it's worth verifying with something like Params::Validate. You can always disable it in production level code if performance becomes an issue.

Log In?

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://765867]
and the web crawler heard nothing...

How do I use this? | Other CB clients
Other Users?
As of 2014-03-15 23:37 GMT
Find Nodes?
    Voting Booth?

    Have you used a cryptocurrency?

    Results (322 votes), past polls