Skip to content
This repository

data-overlay-theme bug in 1.1 rc1 #3779

toddparker opened this Issue · 3 comments

2 participants

Todd Parker Scott Jehl
Todd Parker

If you set the overlay theme on a page, that theme swatch will then continue to override all subsequent dialog overlays until you refresh. To reproduce, go here:

  1. Click on the "custom overlay swatch" button near the bottom. This dialog has swatch "e" set for the overlay.
  2. Close the dialog, then open any other dialog on this page - the overlay swatch will remain E instead of using the default A swatch

This will also carry over onto other pages. If you navigate to the transitions page, all the dialogs there will have an E swatch.

Scott Jehl
Todd Parker

It's all yours!

Scott Jehl scottjehl closed this issue from a commit
parent is actually what we're looking for here, given that getInherit…
…edTheme mimics the closest() method. Fixes #3779
Scott Jehl scottjehl closed this in 054b9a4
Scott Jehl

That one was tricky. Think we're good now...

Something went wrong with that request. Please try again.