Skip to content
This repository

#612 Added ConfirmEmailAddress to RegisterRequest #983

wants to merge 1 commit into from

2 participants

Jesper Blad Jensen Andrew Nurse
Jesper Blad Jensen
deldy commented

This commit adds an extra confirm email field to the register page. Sorry for not commenting on the issue before looking at it, but just wanted to see if I could get all this pull-request stuff going :)

Feel free to decline, if the solution is not satisfactory.

Jesper Blad Jensen
deldy commented

Ahh, need this: Fix #612

Andrew Nurse

Thanks for the contribution! We'll take a look at it for the sprint we're starting on Monday (excellent timing, we're right at the start of a sprint :P)

Andrew Nurse

We decided not to take this specific fix, but you got us to start a big discussion on the subject of sign-in :). I think we've got a better solution in the following:

  1. No confirm prompts
  2. As soon as you've registered, you're signed in
  3. No need to confirm email just to log-in, confirmation is required for pushing packages
  4. If you mistype your email, you can still log in using your password and change it
  5. If you lose both, contact support (we'll have a clear process for that).
Andrew Nurse anurse closed this

Showing 1 unique commit by 1 author.

Mar 30, 2013
Jesper Blad Jensen Added ConfirmEmailAddress to RegisterRequest 4d4b167

Showing 1 changed file with 9 additions and 0 deletions. Show Diff Stats Hide Diff Stats

  1. 9  Website/RequestModels/RegisterRequest.cs
9  Website/RequestModels/RegisterRequest.cs
@@ -17,6 +17,15 @@ public class RegisterRequest
17 17
         public string EmailAddress { get; set; }
18 18
19 19
+        [Compare("EmailAddress")]
+        [Display(Name = "Email Confirmation")]
+        [DataType(DataType.EmailAddress)]
+        [Hint(
+            "Please reenter your email and ensure that it matches the one above."
+            )]
+        public string ConfirmEmailAddress { get; set; }
+        [Required]
20 29
21 30
22 31
             ErrorMessage =


Something went wrong with that request. Please try again.