
Approvals: 0/1

[09:51:39] <temporal_> pmlopes hi, I'm pushing the @GenModule → @ModuleGen improvement in codegen

[09:51:50] <temporal_> I will update all other modules to cope with this change

[09:51:58] <temporal_> so things may break for a couple of hours

[09:52:10] <temporal_> besides, good morning :-)

[09:58:59] <pmlopes> good morning. Sure no problem

[10:02:29] <temporal_> how's going vertxbus.js testing ?

[10:28:49] <Narigo> Hi there… quick question about the modules: How do I know if the module has a snapshot and how can I find it? Does cloudbees push snapshots for us or do we have to do it ourselves for all modules? :)

[10:31:56] <pmlopes> Narigo if you use maven you can configure it to lookup snapshots on sonatype snapshot reppo

[10:33:45] * ChanServ sets mode: +o purplefox [10:33:50] <pmlopes> something like this: [10:34:05] <pmlopes> then you don't need to always fetch and build all your snapshot dependencies [10:40:29] <Narigo> pmlopes, I just want to check if a vertx-mysql-postgresql-client 3.1.0-SNAPSHOT is somewhere :) [10:48:48] <pmlopes> all successful builds should upload the snapshot artifacts to sonatype, then with the settings i've shared you should be able to use it locally [10:56:24] <Narigo> pmlopes, is there a quick way to check - without setting up a project that tries to use it? :/ I'm asking because of this:!topic/vertx/HFGaXkVY0mo [10:59:05] <pmlopes> is this what you're looking for? [10:59:58] <Narigo> yes! Thanks! Ahh, I always looked at org/vertx/ … and wondered why there are only old things there ;) [11:03:02] <pmlopes> temporalfox_ if you can, could you review: ; ; :P [11:31:45] * ChanServ sets mode: +o purplefox

[12:12:14] * ChanServ sets mode: +o temporalfox [14:58:22] * ChanServ sets mode: +o purplefox

[16:11:25] <temporalfox> pmlopes will reivew them

[16:11:43] <temporalfox> I didnot get the IRC attention somehow

[16:18:52] <temporalfox> pmlopes I'm looking at invalid chars PR : why do we allow illegal characters in the status message setStatusMessage and don't fail somehow ?

[16:19:07] <temporalfox> instead of trying to correct the when status is invalid

[16:21:21] <pmlopes> well because the HTTP spec does not specify any escaping sequence for the status strings, for example we could replace new lines with “\\n” however browsers would not convert that back to newline, the spec states if one is to implement a escape sequence she must implement both server and client. Since we do not make web browsers, lets not do it ;)

[16:23:10] <temporalfox> I mean why do we not fail when setStatusMessage is invoked with an illegal string ?

[16:23:21] <temporalfox> instead of later changing the message if it's invalid

[16:23:49] <temporalfox> it would be less vertx-y ?

[16:25:58] <pmlopes> we were doing that, the code change is on the method: “unhandledFailure” however if it happens there we were not properly closing the connection and connections would stay open, since it would not be nice to just close I forced a valid error status message

[16:27:06] <temporalfox> ok

[16:27:45] <pmlopes> I could have just closed the socket, however that would also break the semantics of HTTP, an internal error should return “Internal Server Error” and and status code equal or above 500

[17:43:54] * ChanServ sets mode: +o purplefox [21:43:22] <Lecherito> One question, if I set the user on a routingContext that comes with route(), will that user be found in a later route(“/path/here”)? [21:47:54] <Sticky> the user should get a session, so assuming that user still has an open session then it should be set [21:50:45] <Lecherito> [21:50:48] <Lecherito> Is this example a good one [21:50:49] <Lecherito> ? [21:54:31] <Sticky> yeah that pretty much shows what is happening [22:10:30] <Lecherito> But I don't really need a Session, it is going to be Token thing for a rest service [22:40:45] * ChanServ sets mode: +o purplefox

[22:42:07] * ChanServ sets mode: +o temporalfox [22:52:18] * ChanServ sets mode: +o temporalfox

[23:12:53] <Lecherito> Sticky: no need for all those! Just doing a context.setUser, and clearing the user at the end did the work!

[23:12:54] <Lecherito> :D