anmolnar commented on a change in pull request #1133: ZOOKEEPER-1260:Audit 
logging in ZooKeeper servers.

 File path: 
 @@ -0,0 +1,37 @@
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ *
+ *
+ *
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.zookeeper.audit;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+ * Log4j based audit logger
+ */
+public class Log4jAuditLogger implements AuditLogger {
+    private static final Logger LOG = 
+    @Override
+    public void logAuditEvent(AuditEvent auditEvent) {
+        if 
 Review comment:
   Additionally this is currently a string comparison every time an audit event 
occurs. I rather use a boolean value for success/failure instead to make it as 
fast as possible.

This is an automated message from the Apache Git Service.
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

With regards,
Apache Git Services

Reply via email to