Gh9010 yahoo options parsing bug
closes #9010. Fix for Yahoo Options parse error for underlying prices of 1,000.00 or larger.

even better is to construct the frame and then try to coerce the columns with a try except around astype If it fails then do the replace and try again - will be much faster
 So you would prefer a solution where I leave Options's underlying_price member as a string, then in the _process_data method do an astype conversion and filter out the comma if an exception is thrown?
 yep will be more efficient 
 Correcting the column type in _process_data won't work -- it breaks get_near_stock_price(), because its call into chop_data() relies on underlying_price already being a float, and doesn't use _process_data. It also breaks the test_sample_page_price_quote_time1 and test_sample_page_price_quote_time2 tests, for the same reasons.

Doing the type checking / possible conversion in the _get_underlying_price() method will make the code cleaner and more cohesive, versus sprinkling around the checking and conversion login in multiple methods. I understand your performance concerns, especially about the locale methods ... but wouldn't simply filtering out the commas be nearly as quick?

Let me know your thoughts.
 I understand your point about simplicity, but string.replace() is deprecated in 2.x python and doesn't exist in python 3.x, and the pandas docs (http://pandas.pydata.org/pandas-docs/stable/install.html) claim to support both branches of python. String.join() works in both. 
 Thanks for the report, sturmd.

Is there any more housekeeping I need to do here to make sure this is ready for 0.16.0?
 @PollyP  `replace` was removed from the `string` helper module but still exists on the string type

i.e. 

``` python
In [1]: s = 'fof'

In [2]: s.replace('o', 'f')
Out[2]: 'fff'
```

will work fine in Python 3 but

``` python
In [3]: import string

In [4]: s = 'fof'

In [5]: string.replace(s, 'o', 'f')
```

won't. It's just some cruft they cleared up, the `replace` method has not been removed or deprecated on the string type.
 @PollyP 

pls address the above, rebase and squash. ping when green.
 OK, will do this this weekend.

On Fri, Jan 2, 2015 at 9:23 AM, jreback notifications@github.com wrote:

> @PollyP https://github.com/PollyP
> 
> pls address the above, rebase and squash. ping when green.
> 
> —
> Reply to this email directly or view it on GitHub
> https://github.com/pydata/pandas/pull/9024#issuecomment-68543990.
 I wound up syncing and reapplying my changes to create a new PR #9198. I believe it is ready to go.
 replaced by #9198 
