REGR: sample modifying `weights` inplace
- [x] tests added / passed
- [x] Ensure all linting tests pass, see [here](https://pandas.pydata.org/pandas-docs/dev/development/contributing.html#code-standards) for how to run them
- [x] whatsnew entry

Targeting 1.4 and no whatsnew since only a regression on master.

looks fine can you add a whatsnew note (1.4) reshaping is fine & ping on green. > looks fine can you add a whatsnew note (1.4) reshaping is fine & ping on green.

Didn't include a whatsnew because it is only a regression on master caused by #42233 > > looks fine can you add a whatsnew note (1.4) reshaping is fine & ping on green.
> 
> Didn't include a whatsnew because it is only a regression on master caused by #42233

kk cool thanks @mzeitlin11 