Deprecate Aliases as orient Argument in DataFrame.to_dict
- [ x] closes #32515
- [x ] tests added / passed
- [x ] passes `black pandas`
- [x ] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [x ] whatsnew entry
On board with the change but I think should wait until 2.0 since this could break things (though yes undocumented) Should deprecate for 1.1 I see that in c598b32 you reverted some code, ```pytest``` handles DeprecationWarning a bit different than the usual

```python
with pytest.raises(Exception):
    foo()
```

You can read more about how ```pytest``` deals with DeprecationWarning at https://docs.pytest.org/en/latest/warnings.html#ensuring-code-triggers-a-deprecation-warning

---

To sum it up, you catch DeprecationWarning by:

```python

with pytest.deprecated_call():
    foo()
``` @MomIsBestFriend Thanks for the patient review! :clap:  I've tried to add 
```
- :meth:`DataFrame.to_dict` will not accept short names for ``orient`` in future versions (:issue:`32515`)
```

into the deprecation section of the what's new 1.1.0 and the tests keep failing...
I've removed it. > I've tried to add
> 
> ```
> - :meth:`DataFrame.to_dict` will not accept short names for ``orient`` in future versions (:issue:`32515`)
> ```
> 
> into the deprecation section of the what's new 1.1.0 and the tests keep failing...
> I've removed it.

The error was just that you had trailing whitespace at the end of the line. Note looks good so if you add back in and delete trailing space should work /azp run <samp>
Azure Pipelines successfully started running 1 pipeline(s).<br>

</samp> Thanks @elmonsomiat - very impressive first contribution Just reading through some PRs to understand the contribution process better. I see this sentence in the documentation "Abbreviations are allowed. s indicates series and sp indicates split." Is a corresponding doc change needed for this? 

https://pandas.pydata.org/pandas-docs/stable/reference/api/pandas.DataFrame.to_dict.html Oh, yes, this sentence should be removed. This is not the case for `to_json` and I think they should be consistent.