TYP: make dtype required in _from_sequence_of_strings
- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [x] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.

> Error: /home/runner/work/pandas/pandas/pandas/core/arrays/base.py:334:EX03:pandas.api.extensions.ExtensionArray._from_sequence_of_strings:flake8 error: line 2, col 4: E121 continuation line under-indented for hanging indent

@mroeschke is this check new?  i dont see what it is complaining about good suggestion, seems to have done the trick This method is only ever called with a dtype object. There’s also a recent
issue about having a dedicated constructor for inference.

On Sat, Feb 3, 2024 at 2:02 PM Matthew Roeschke ***@***.***>
wrote:

> ***@***.**** commented on this pull request.
> ------------------------------
>
> In pandas/core/arrays/arrow/array.py
> <https://github.com/pandas-dev/pandas/pull/56519#discussion_r1477131965>:
>
> > @@ -316,7 +318,7 @@ def _from_sequence(
>
>      @classmethod
>      def _from_sequence_of_strings(
> -        cls, strings, *, dtype: Dtype | None = None, copy: bool = False
> +        cls, strings, *, dtype: ExtensionDtype, copy: bool = False
>
> At least for arrow, dtype=None was supposed to mean "let pa.array infer
> the type", and now that can't be done?
>
> —
> Reply to this email directly, view it on GitHub
> <https://github.com/pandas-dev/pandas/pull/56519#pullrequestreview-1861128307>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AB5UM6A7CJGWIEV5TNHGKELYR2XXLAVCNFSM6AAAAABAW7H2RSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQNRRGEZDQMZQG4>
> .
> You are receiving this because you authored the thread.Message ID:
> ***@***.***>
>
 Thanks @jbrockmendel 