MAINT: Fix issue in StataReader due to upstream changes
Avoid creating an array of dtypes to workaround NumPy future change

closes #35426

- [X] closes #35426
- [ ] tests added / passed
- [X] passes `black pandas`
- [X] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry

Probably no reason to do this for 1.1.0. Are you OK with waiting for 1.1.1 @simonjayhawkins? > Probably no reason to do this for 1.1.0. Are you OK with waiting for 1.1.1 @simonjayhawkins?

no problem. moving milestone. The Stata tests are no longer failing with Linux py37_np_dev on master so this won't need backport. Should we just close this as unneeded?  The second fix does appear to be
needed or at least a good idea since assigning Nan to an int array has a
funny smell.

On Wed, Jul 29, 2020, 11:33 Simon Hawkins <notifications@github.com> wrote:

> moving milestone. The Stata tests are no longer failing with Linux
> py37_np_dev on master so this won't need backport.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/pandas-dev/pandas/pull/35427#issuecomment-665585142>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ABKTSRJF4NFNURKEPDR4JMDR573I7ANCNFSM4PIUO5VA>
> .
>
 > The second fix does appear to be needed or at least a good idea since assigning Nan to an int array has a funny smell.

Thanks. I'm not sure where we are with numpy-dev. We still have 20 fails on master. not sure whether further changes in numpy will resolve these or we still have work to do.

> Should we just close this as unneeded? 

up to you.  @simonjayhawkins I reverted the second commit so this just a small, sensible always safe refactor. Restarted the Travis build, LGTM pending green @jbrockmendel green. Thanks @bashtage 