Changed read_csv type hint for na_values and added tests Issue#53813
- [ ] closes #53813
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
Hi @twoertwein and @lithomas1 thank you for the feedback. Do you know where the ellipses issue could be coming from? I only changed the na_values type hint for the read_csv() function. > Hi @twoertwein and @lithomas1 thank you for the feedback. Do you know where the ellipses issue could be coming from? I only changed the na_values type hint for the read_csv() function.

You seem to have changed it :) You can always use `git add --patch` to confirm individual changes you want to add.

You can simply replace `= ...` with `= None` in the non-overload definition.

The easiest way to remove the test is probably `git checkout <commit id from before your changes> pandas/tests/io/parser/test_na_values.py` and then add and commit that. Hi @twoertwein do the changes I made look good? > Hi @twoertwein do the changes I made look good?

Now you use `= None` everywhere. You want `= None` for the function definition that doesn't have the `@overload` but otherwise use `= ...`.

It might be better to use `Sequence` instead of `Iterable` (not sure whether any iterable is accepted).

You can remove the test changes you made. > > Hi @twoertwein do the changes I made look good?
> 
> Now you use `= None` everywhere. You want `= None` for the function definition that doesn't have the `@overload` but otherwise use `= ...`.
> 
> It might be better to use `Sequence` instead of `Iterable` (not sure whether any iterable is accepted).
> 
> You can remove the test changes you made.

Thank you for the feedback. I made the changes Thanks @kvn4 !