REF: move functions out of _testing/__init__
BC we don’t have __all__

On Mon, Jan 4, 2021 at 4:18 PM Jeff Reback <notifications@github.com> wrote:

> *@jreback* commented on this pull request.
> ------------------------------
>
> In pandas/_testing/__init__.py
> <https://github.com/pandas-dev/pandas/pull/38961#discussion_r551645232>:
>
> > @@ -55,6 +39,22 @@
>      Series,
>      bdate_range,
>  )
> +from pandas._testing._io import (  # noqa:F401
>
> umm why are these ignored?
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/pandas-dev/pandas/pull/38961#pullrequestreview-561436961>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AB5UM6CAIQ743IMYOMEU353SYJLFBANCNFSM4VT2H3HA>
> .
>
 Pet peeve for overlap with stdlib names

On Mon, Jan 4, 2021 at 4:17 PM Jeff Reback <notifications@github.com> wrote:

> *@jreback* requested changes on this pull request.
> ------------------------------
>
> In pandas/_testing/_io.py
> <https://github.com/pandas-dev/pandas/pull/38961#discussion_r551644894>:
>
> > @@ -0,0 +1,405 @@
> +import bz2
>
> why _io.py? this is *already* a private module.
> ------------------------------
>
> In pandas/_testing/_random.py
> <https://github.com/pandas-dev/pandas/pull/38961#discussion_r551644965>:
>
> > @@ -0,0 +1,48 @@
> +import string
> +
> +import numpy as np
>
> same comment
> ------------------------------
>
> In pandas/_testing/_warnings.py
> <https://github.com/pandas-dev/pandas/pull/38961#discussion_r551644987>:
>
> > @@ -0,0 +1,174 @@
> +from contextlib import contextmanager
> +import re
>
> same
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/pandas-dev/pandas/pull/38961#pullrequestreview-561436538>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AB5UM6HNABZZN22RJKZIIDTSYJLCFANCNFSM4VT2H3HA>
> .
>
 > BC we don’t have __all__
> […](#)
> On Mon, Jan 4, 2021 at 4:18 PM Jeff Reback ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In pandas/_testing/__init__.py <[#38961 (comment)](https://github.com/pandas-dev/pandas/pull/38961#discussion_r551645232)>: > @@ -55,6 +39,22 @@ Series, bdate_range, ) +from pandas._testing._io import ( # noqa:F401 umm why are these ignored? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <[#38961 (review)](https://github.com/pandas-dev/pandas/pull/38961#pullrequestreview-561436961)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB5UM6CAIQ743IMYOMEU353SYJLFBANCNFSM4VT2H3HA> .

should add :-> > should add

i think once we get the implementations out of this file thanks followon comment