mattricesound commited on
Commit
15b101a
·
1 Parent(s): b45dcb0

Fix bug in removing single effects

Browse files
Files changed (2) hide show
  1. cfg/effects/all.yaml +6 -6
  2. remfx/datasets.py +3 -3
cfg/effects/all.yaml CHANGED
@@ -32,9 +32,9 @@ effects:
32
  delay:
33
  _target_: remfx.effects.RandomPedalboardDelay
34
  sample_rate: ${sample_rate}
35
- min_delay_seconds: float = 0.1,
36
- max_delay_sconds: float = 1.0,
37
- min_feedback: float = 0.05,
38
- max_feedback: float = 0.6,
39
- min_mix: float = 0.2,
40
- max_mix: float = 0.7,
 
32
  delay:
33
  _target_: remfx.effects.RandomPedalboardDelay
34
  sample_rate: ${sample_rate}
35
+ min_delay_seconds: 0.1
36
+ max_delay_sconds: 1.0
37
+ min_feedback: 0.05
38
+ max_feedback: 0.6
39
+ min_mix: 0.2
40
+ max_mix: 0.7
remfx/datasets.py CHANGED
@@ -223,10 +223,10 @@ class VocalSet(Dataset):
223
  effect_indices = torch.arange(len(self.effects_to_remove))
224
  # Up to max_removed_effects
225
  if self.max_removed_effects != -1:
226
- num_kept_effects = int(torch.rand(1).item() * (self.max_removed_effects))
227
  else:
228
- num_kept_effects = len(self.effects_to_remove)
229
- effect_indices = effect_indices[: self.max_removed_effects]
230
  # Index in effect settings
231
  effect_names_to_apply = [self.effects_to_remove[i] for i in effect_indices]
232
  effects_to_apply = [self.effects[i] for i in effect_names_to_apply]
 
223
  effect_indices = torch.arange(len(self.effects_to_remove))
224
  # Up to max_removed_effects
225
  if self.max_removed_effects != -1:
226
+ num_removed_effects = int(torch.rand(1).item() * (self.max_removed_effects))
227
  else:
228
+ num_removed_effects = len(self.effects_to_remove)
229
+ effect_indices = effect_indices[:num_removed_effects]
230
  # Index in effect settings
231
  effect_names_to_apply = [self.effects_to_remove[i] for i in effect_indices]
232
  effects_to_apply = [self.effects[i] for i in effect_names_to_apply]