Update app.py

app.py

@@ -464,23 +464,60 @@ def create_selflinking_pdf(pdf_file="SelfLinking.pdf"):
 
 # 🖼️ 13. Image-linked PDF creator - wisdom: Link images to text, like windows opening to new worlds!
 def create_pdf_with_images(source_pdf_bytes, output_pdf="ImageLinked.pdf"):
-    """Create a PDF with links to images on numbered items 1-12."""
+    """Create a PDF with links on numbered headings to new pages with images."""
     image_files = sorted(glob.glob("*.png"))
     if not source_pdf_bytes:
         st.error("No source PDF provided.")
         return None
+    if not image_files:
+        st.error("No PNG images found in the directory.")
+        return source_pdf_bytes
+    
     reader = PdfReader(io.BytesIO(source_pdf_bytes))
     writer = PdfWriter()
+    
+    # Copy all pages from source PDF
+    original_page_count = len(reader.pages)
     for page in reader.pages:
         writer.add_page(page)
-    page = writer.pages[0]
-    number_pattern = re.compile(r'^\d+\.\s')
-    y_positions = []
-    for i in range(1, 13):
-        y = 800 - (i * 20)
-        y_positions.append(y)
-    for idx, (y, image_file) in enumerate(zip(y_positions, image_files[:12])):
-        if os.path.exists(image_file):
+    
+    # Add image pages
+    image_page_indices = []
+    for image_file in image_files[:12]:  # Limit to 12 images
+        buffer = io.BytesIO()
+        c = canvas.Canvas(buffer, pagesize=A4)
+        try:
+            img = Image.open(image_file)
+            img_width, img_height = img.size
+            page_width, page_height = A4
+            scale = min((page_width - 40) / img_width, (page_height - 40) / img_height)
+            new_width = img_width * scale
+            new_height = img_height * scale
+            x = (page_width - new_width) / 2
+            y = (page_height - new_height) / 2
+            c.drawImage(image_file, x, y, new_width, new_height)
+            c.showPage()
+            c.save()
+            buffer.seek(0)
+            img_pdf = PdfReader(buffer)
+            writer.add_page(img_pdf.pages[0])
+            image_page_indices.append(original_page_count + len(image_page_indices))
+            buffer.close()
+        except Exception as e:
+            st.error(f"Failed to process image {image_file}: {e}")
+            buffer.close()
+            continue
+    
+    # Add links to numbered headings on first page
+    if image_page_indices:
+        page = writer.pages[0]
+        y_positions = []
+        for i in range(1, 13):
+            y = 800 - (i * 20)  # Matches layout from create_pdf
+            y_positions.append(y)
+        
+        for idx, (y, target_page_idx) in enumerate(zip(y_positions, image_page_indices)):
+            # Add "link" text
             buffer = io.BytesIO()
             c = canvas.Canvas(buffer)
             c.setFont("Helvetica", 8)
@@ -490,12 +527,16 @@ def create_pdf_with_images(source_pdf_bytes, output_pdf="ImageLinked.pdf"):
             buffer.seek(0)
             text_pdf = PdfReader(buffer)
             page.merge_page(text_pdf.pages[0])
+            
+            # Add link annotation
             link = Link(
                 rect=(90, y - 10, 150, y + 10),
-                url=f"file://{os.path.abspath(image_file)}"
+                target_page_index=target_page_idx,
+                fit=Fit(fit_type="/Fit")
             )
             writer.add_annotation(page_number=0, annotation=link)
             buffer.close()
+    
     output_buffer = io.BytesIO()
     writer.write(output_buffer)
     output_buffer.seek(0)
@@ -507,45 +548,15 @@ def create_pdf_with_images(source_pdf_bytes, output_pdf="ImageLinked.pdf"):
 md_files = [f for f in glob.glob("*.md") if os.path.basename(f) != "README.md"]
 md_options = [os.path.splitext(os.path.basename(f))[0] for f in md_files]
 
-# 🖥️ 15. Main PDF generation - wisdom: Spin up the PDF like a weaver at the loom, crafting beauty!
-with st.spinner("Generating PDF..."):
-    # Initialize defaults for PDF generation
-    selected_md = None
-    base_font_size = 8
-    num_columns = 3
-    add_space_before_numbered = True
-    headings_to_fonts = True
-    longest_line_words = 0
-    total_lines = 0
-    
-    # Calculate document stats if markdown exists
-    if 'markdown_content' in st.session_state and st.session_state.markdown_content.strip():
-        current_markdown = st.session_state.markdown_content
-        lines = current_markdown.strip().split('\n')
-        total_lines = len([line for line in lines if line.strip()])
-        for line in lines:
-            if line.strip():
-                word_count = len(line.split())
-                longest_line_words = max(longest_line_words, word_count)
-    
-    pdf_bytes = create_pdf(
-        st.session_state.get('markdown_content', ''),
-        base_font_size,
-        num_columns,
-        add_space_before_numbered,
-        headings_to_fonts,
-        doc_title=selected_md if selected_md else "Untitled",
-        longest_line_words=longest_line_words,
-        total_lines=total_lines
-    )
-
 with st.sidebar:
     # 📚 14.1 Markdown selector - wisdom: Offer choices like a librarian, guiding users to their story!
     st.markdown("### 📄 PDF Options")
     if md_options:
-        selected_md = st.selectbox("Select Markdown File", options=md_options, index=0)
-        with open(f"{selected_md}.md", "r", encoding="utf-8") as f:
-            st.session_state.markdown_content = f.read()
+        selected_md = st.selectbox("Select Markdown File", options=md_options, index=0, key="markdown_select")
+        if selected_md != st.session_state.get('last_selected_md'):
+            with open(f"{selected_md}.md", "r", encoding="utf-8") as f:
+                st.session_state.markdown_content = f.read()
+            st.session_state.last_selected_md = selected_md
     else:
         st.warning("No markdown file found. Please add one to your folder.")
         selected_md = None
@@ -706,22 +717,18 @@ with st.sidebar:
                         mime="application/pdf"
                     )
 
-    if st.button("🖼️ Generate PDF With Images"):
-        with st.spinner("Generating PDF with image links..."):
-            linked_pdf_bytes = create_pdf_with_images(pdf_bytes)
-            if linked_pdf_bytes:
-                st.success("Generated PDF with image links")
-                images = pdf_to_image(linked_pdf_bytes)
-                if images:
-                    st.subheader("Preview of Image-Linked PDF")
-                    for i, img in enumerate(images):
-                        st.image(img, caption=f"Image-Linked PDF Page {i+1}", use_container_width=True)
-                st.download_button(
-                    label="💾 Download Image-Linked PDF",
-                    data=linked_pdf_bytes,
-                    file_name=f"{prefix} {selected_md}_image_linked.pdf" if selected_md else f"{prefix} image_linked.pdf",
-                    mime="application/pdf"
-                )
+# 🖥️ 15. Main PDF generation - wisdom: Spin up the PDF like a weaver at the loom, crafting beauty!
+with st.spinner("Generating PDF..."):
+    pdf_bytes = create_pdf(
+        st.session_state.get('markdown_content', ''),
+        base_font_size,
+        num_columns,
+        add_space_before_numbered,
+        headings_to_fonts,
+        doc_title=selected_md if selected_md else "Untitled",
+        longest_line_words=longest_line_words,
+        total_lines=total_lines
+    )
 
 # 🖼️ 16. PDF preview - wisdom: Show the masterpiece before it’s framed, delighting the creator!
 with st.container():
@@ -733,12 +740,29 @@ with st.container():
     else:
         st.info("Download the PDF to view it locally.")
 
-# 💾 17. PDF saver - wisdom: Offer the final scroll, ready to be shared like wisdom across ages!
 with st.sidebar:
+    # 💾 17. PDF saver - wisdom: Offer the final scroll, ready to be shared like wisdom across ages!
     st.download_button(
         label="💾 Save PDF",
         data=pdf_bytes if pdf_bytes else "",
         file_name=f"{prefix} {selected_md}.pdf" if selected_md else f"{prefix} output.pdf",
         mime="application/pdf",
         disabled=pdf_bytes is None
-    )
+    )
+    
+    if st.button("🖼️ Generate PDF With Images"):
+        with st.spinner("Generating PDF with image links..."):
+            linked_pdf_bytes = create_pdf_with_images(pdf_bytes)
+            if linked_pdf_bytes and linked_pdf_bytes != pdf_bytes:
+                st.success("Generated PDF with image links")
+                images = pdf_to_image(linked_pdf_bytes)
+                if images:
+                    st.subheader("Preview of Image-Linked PDF")
+                    for i, img in enumerate(images):
+                        st.image(img, caption=f"Image-Linked PDF Page {i+1}", use_container_width=True)
+                st.download_button(
+                    label="💾 Download Image-Linked PDF",
+                    data=linked_pdf_bytes,
+                    file_name=f"{prefix} {selected_md}_image_linked.pdf" if selected_md else f"{prefix} image_linked.pdf",
+                    mime="application/pdf"
+                )