1876
double s = 10.0;
double r = 1.0;
double pi = 3.14159;
double surface_area;
if(r > 0.0) {
// complex math equations
surface_area = pi * r * s + pi * Math.pow(r, 2);
}
if(r > 1.0) {
// a complex set of math
surface_area = pi * r * s + pi * Math.pow(r, 2);
}
}
}
It is recommended to place the complex math into its own function and then call that function
whenever necessary.
Example Language: Java (Good)
public class Main {
private double ComplexMath(double r, double s) {
//complex math equations
double pi = Math.PI;
double surface_area = pi * r * s + pi * Math.pow(r, 2);
return surface_area;
}
public static void main(String[] args) {
double s = 10.0;
double r = 1.0;
double surface_area;
if(r > 0.0) {
surface_area = ComplexMath(r, s);
}
if(r > 1.0) {
surface_area = ComplexMath(r, s);
}
}
}
MemberOf Relationships
This MemberOf relationships table shows additional CWE Catgeories and Views that reference this
weakness as a member. This information is often useful in understanding where a weakness fits
within the context of external information sources.
Nature Type ID Name Page
MemberOf 1130 CISQ Quality Measures (2016) - Maintainability 1128 2441
MemberOf 1307 CISQ Quality Measures - Maintainability 1305 2484
MemberOf 1412 Comprehensive Categorization: Poor Coding Practices 1400 2538
Taxonomy Mappings
Mapped Taxonomy Name Node ID Fit Mapped Node Name
OMG ASCMM ASCMMMNT-