title: usb: cdns3: fix memory double free when handle zero packet
description: In the Linux kernel, the following vulnerability has been resolved:
usb: cdns3: fix memory double free when handle zero packet
829  if (request->complete) {
830          spin_unlock(&priv_dev->lock);
831          usb_gadget_giveback_request(&priv_ep->endpoint,
832                                    request);
833          spin_lock(&priv_dev->lock);
834  }
835
836  if (request->buf == priv_dev->zlp_buf)
837      cdns3_gadget_ep_free_request(&priv_ep->endpoint, request);
Driver append an additional zero packet request when queue a packet, which
length mod max packet size is 0. When transfer complete, run to line 831,
usb_gadget_giveback_request() will free this requestion. 836 condition is
true, so cdns3_gadget_ep_free_request() free this request again.
Log:
[ 1920.140696][  T150] BUG: KFENCE: use-after-free read in cdns3_gadget_giveback+0x134/0x2c0 [cdns3]
[ 1920.140696][  T150]
[ 1920.151837][  T150] Use-after-free read at 0x000000003d1cd10b (in kfence-#36):
[ 1920.159082][  T150]  cdns3_gadget_giveback+0x134/0x2c0 [cdns3]
[ 1920.164988][  T150]  cdns3_transfer_completed+0x438/0x5f8 [cdns3]
Add check at line 829, skip call usb_gadget_giveback_request() if it is
additional zero length packet request. Needn't call
usb_gadget_giveback_request() because it is allocated in this driver.
affected:
{
product: Linux
vendor: Linux
defaultStatus: unaffected
repo: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
versions:
version: 7733f6c32e36, lessThan: aad6132ae6e4, status: affected, versionType: git
version: 7733f6c32e36, lessThan: 1e204a8e9eb5, status: affected, versionType: git
version: 7733f6c32e36, lessThan: 3a2a909942b5, status: affected, versionType: git
version: 7733f6c32e36, lessThan: 9a52b694b066, status: affected, versionType: git
version: 7733f6c32e36, lessThan: 70e8038813f9, status: affected, versionType: git
version: 7733f6c32e36, lessThan: 92d20406a3d4, status: affected, versionType: git
version: 7733f6c32e36, lessThan: 5fd9e45f1ebc, status: affected, versionType: git
}
{
product: Linux
vendor: Linux
defaultStatus: affected
repo: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
versions:
version: 5.4, status: affected
version: 0, lessThan: 5.4, status: unaffected, versionType: custom
version: 5.4.270, lessThanOrEqual: 5.4.*, status: unaffected, versionType: custom
version: 5.10.211, lessThanOrEqual: 5.10.*, status: unaffected, versionType: custom
version: 5.15.150, lessThanOrEqual: 5.15.*, status: unaffected, versionType: custom
version: 6.1.80, lessThanOrEqual: 6.1.*, status: unaffected, versionType: custom
version: 6.6.19, lessThanOrEqual: 6.6.*, status: unaffected, versionType: custom
version: 6.7.7, lessThanOrEqual: 6.7.*, status: unaffected, versionType: custom
version: 6.8, lessThanOrEqual: *, status: unaffected, versionType: original_commit_for_fix
}
