title: erofs: fix lz4 inplace decompression
description: In the Linux kernel, the following vulnerability has been resolved:
erofs: fix lz4 inplace decompression
Currently EROFS can map another compressed buffer for inplace
decompression, that was used to handle the cases that some pages of
compressed data are actually not in-place I/O.
However, like most simple LZ77 algorithms, LZ4 expects the compressed
data is arranged at the end of the decompressed buffer and it
explicitly uses memmove() to handle overlapping:
__________________________________________________________
|_ direction of decompression --> ____ |_ compressed data _|
Although EROFS arranges compressed data like this, it typically maps two
individual virtual buffers so the relative order is uncertain.
Previously, it was hardly observed since LZ4 only uses memmove() for
short overlapped literals and x86/arm64 memmove implementations seem to
completely cover it up and they don't have this issue.  Juhyung reported
that EROFS data corruption can be found on a new Intel x86 processor.
After some analysis, it seems that recent x86 processors with the new
FSRM feature expose this issue with "rep movsb".
Let's strictly use the decompressed buffer for lz4 inplace
decompression for now.  Later, as an useful improvement, we could try
to tie up these two buffers together in the correct order.
affected:
{
product: Linux
vendor: Linux
defaultStatus: unaffected
repo: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
versions:
version: 0ffd71bcc3a0, lessThan: a0180e940cf1, status: affected, versionType: git
version: 0ffd71bcc3a0, lessThan: 77cbc04a1a86, status: affected, versionType: git
version: 0ffd71bcc3a0, lessThan: 33bf23c9940d, status: affected, versionType: git
version: 0ffd71bcc3a0, lessThan: f36d200a80a3, status: affected, versionType: git
version: 0ffd71bcc3a0, lessThan: bffc4cc334c5, status: affected, versionType: git
version: 0ffd71bcc3a0, lessThan: 3c12466b6b7b, status: affected, versionType: git
}
{
product: Linux
vendor: Linux
defaultStatus: affected
repo: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
versions:
version: 5.3, status: affected
version: 0, lessThan: 5.3, status: unaffected, versionType: custom
version: 5.10.211, lessThanOrEqual: 5.10.*, status: unaffected, versionType: custom
version: 5.15.150, lessThanOrEqual: 5.15.*, status: unaffected, versionType: custom
version: 6.1.76, lessThanOrEqual: 6.1.*, status: unaffected, versionType: custom
version: 6.6.15, lessThanOrEqual: 6.6.*, status: unaffected, versionType: custom
version: 6.7.3, lessThanOrEqual: 6.7.*, status: unaffected, versionType: custom
version: 6.8, lessThanOrEqual: *, status: unaffected, versionType: original_commit_for_fix
}
