

Philip Warner wrote:

> I get the following when I build from CVS:
>
> gcc -I../../../src/include  -I../../../src/interfaces/libpq -O2 -g -Wall
> -Wmissing-prototypes -Wmissing-declarations -o pg_dump pg_dump.o common.o
> pg_backup_archiver.o pg_backup_db.o pg_backup_custom.o pg_backup_files.o
> pg_backup_null.o pg_backup_tar.o  -L../../..
> /src/interfaces/libpq -lpq -lz -lcrypt -lnsl -ldl -lm -lreadline -lncurses
> -lz
> ../../../src/interfaces/libpq/libpq.so: undefined reference to
> `FailedAssertion'
> ../../../src/interfaces/libpq/libpq.so: undefined reference to
> `assert_enabled'
> ../../../src/interfaces/libpq/libpq.so: undefined reference to
> `ExceptionalCondition'
>
> Does anyone else have this problem?
>

I have already encountered the problem.
-DFRONTEND isn't set in the above command line.

For example the following line
    CFLAGS+= -DFRONTEND -I$(srcdir)
in makefiles doesn't work currently.

I found the recent change in Makefile.global.in.
ifeq ($(GCC), yes)
     override CFLAGS += -Wall -Wmissing-prototypes -Wmissing-declarations
endif

Do we have to override CFLAGS every time ?

Regards.

Hiroshi Inoue


Tue, 10 Oct 2000 19:56:40 +0900
Hiroshi Inoue <Inoue@tpf.co.jp>
Re: CVS broken?

I get the following when I build from CVS:

gcc -I../../../src/include  -I../../../src/interfaces/libpq -O2 -g -Wall
-Wmissing-prototypes -Wmissing-declarations -o pg_dump pg_dump.o common.o
pg_backup_archiver.o pg_backup_db.o pg_backup_custom.o pg_backup_files.o
pg_backup_null.o pg_backup_tar.o  -L../../..
/src/interfaces/libpq -lpq -lz -lcrypt -lnsl -ldl -lm -lreadline -lncurses
-lz
../../../src/interfaces/libpq/libpq.so: undefined reference to
`FailedAssertion'
../../../src/interfaces/libpq/libpq.so: undefined reference to
`assert_enabled'
../../../src/interfaces/libpq/libpq.so: undefined reference to
`ExceptionalCondition'

Does anyone else have this problem?

It's building under Linux i586 and there's some more context is below. The
rest of the log looks fine.


make[3]: Entering directory
`/home/pjw/work/postgresql-cvs/pgsql/src/bin/pg_dump'
make -C ../../../src/interfaces/libpq all
make[4]: Entering directory
`/home/pjw/work/postgresql-cvs/pgsql/src/interfaces/libpq'
make[4]: Nothing to be done for `all'.
make[4]: Leaving directory
`/home/pjw/work/postgresql-cvs/pgsql/src/interfaces/libpq'
gcc -c  -I../../../src/interfaces/libpq -I../../../src/include
-I../../../src/interfaces/libpq -O2 -g -Wall -Wmissing-prototypes -W
missing-declarations pg_dump.c -o pg_dump.o
gcc -c  -I../../../src/interfaces/libpq -I../../../src/include
-I../../../src/interfaces/libpq -O2 -g -Wall -Wmissing-prototypes -W
missing-declarations common.c -o common.o
gcc -c  -I../../../src/interfaces/libpq -I../../../src/include
-I../../../src/interfaces/libpq -O2 -g -Wall -Wmissing-prototypes -W
missing-declarations pg_backup_archiver.c -o pg_backup_archiver.o
gcc -c  -I../../../src/interfaces/libpq -I../../../src/include
-I../../../src/interfaces/libpq -O2 -g -Wall -Wmissing-prototypes -W
missing-declarations pg_backup_db.c -o pg_backup_db.o
gcc -c  -I../../../src/interfaces/libpq -I../../../src/include
-I../../../src/interfaces/libpq -O2 -g -Wall -Wmissing-prototypes -W
missing-declarations pg_backup_custom.c -o pg_backup_custom.o
gcc -c  -I../../../src/interfaces/libpq -I../../../src/include
-I../../../src/interfaces/libpq -O2 -g -Wall -Wmissing-prototypes -W
missing-declarations pg_backup_files.c -o pg_backup_files.o
gcc -c  -I../../../src/interfaces/libpq -I../../../src/include
-I../../../src/interfaces/libpq -O2 -g -Wall -Wmissing-prototypes -W
missing-declarations pg_backup_null.c -o pg_backup_null.o
gcc -c  -I../../../src/interfaces/libpq -I../../../src/include
-I../../../src/interfaces/libpq -O2 -g -Wall -Wmissing-prototypes -W
missing-declarations pg_backup_tar.c -o pg_backup_tar.o
gcc -I../../../src/include  -I../../../src/interfaces/libpq -O2 -g -Wall
-Wmissing-prototypes -Wmissing-declarations -o pg_dump pg_dump.o common.o
pg_backup_archiver.o pg_backup_db.o pg_backup_custom.o pg_backup_files.o
pg_backup_null.o pg_backup_tar.o  -L../../..
/src/interfaces/libpq -lpq -lz -lcrypt -lnsl -ldl -lm -lreadline -lncurses
-lz
../../../src/interfaces/libpq/libpq.so: undefined reference to
`FailedAssertion'
../../../src/interfaces/libpq/libpq.so: undefined reference to
`assert_enabled'
../../../src/interfaces/libpq/libpq.so: undefined reference to
`ExceptionalCondition'
collect2: ld returned 1 exit status
make[3]: *** [pg_dump] Error 1
make[3]: Leaving directory
`/home/pjw/work/postgresql-cvs/pgsql/src/bin/pg_dump'
make[2]: *** [all] Error 2
make[2]: Leaving directory `/home/pjw/work/postgresql-cvs/pgsql/src/bin'
make[1]: *** [all] Error 2
make[1]: Leaving directory `/home/pjw/work/postgresql-cvs/pgsql/src'
make: *** [all] Error 2


----------------------------------------------------------------
Philip Warner                    |     __---_____
Albatross Consulting Pty. Ltd.   |----/       -  \
(A.B.N. 75 008 659 498)          |          /(@)   ______---_
Tel: (+61) 0500 83 82 81         |                 _________  \
Fax: (+61) 0500 83 82 82         |                 ___________ |
Http://www.rhyme.com.au          |                /           \|
                                 |    --________--
PGP key available upon request,  |  /
and from pgp5.ai.mit.edu:11371   |/

Tue, 10 Oct 2000 21:37:53 +1000
Philip Warner <pjw@rhyme.com.au>
CVS broken?
> > -Wmissing-prototypes -Wmissing-declarations -o pg_dump pg_dump.o common.o
> > pg_backup_archiver.o pg_backup_db.o pg_backup_custom.o pg_backup_files.o
> > pg_backup_null.o pg_backup_tar.o  -L../../..
> > /src/interfaces/libpq -lpq -lz -lcrypt -lnsl -ldl -lm -lreadline -lncurses
> > -lz
> > ../../../src/interfaces/libpq/libpq.so: undefined reference to
> > `FailedAssertion'
> > ../../../src/interfaces/libpq/libpq.so: undefined reference to
> > `assert_enabled'
> > ../../../src/interfaces/libpq/libpq.so: undefined reference to
> > `ExceptionalCondition'
> >
> > Does anyone else have this problem?
> >
> 
> I have already encountered the problem.
> -DFRONTEND isn't set in the above command line.
> 
> For example the following line
>     CFLAGS+= -DFRONTEND -I$(srcdir)
> in makefiles doesn't work currently.
> 
> I found the recent change in Makefile.global.in.
> ifeq ($(GCC), yes)
>      override CFLAGS += -Wall -Wmissing-prototypes -Wmissing-declarations
> endif

OK, I have removed 'override' from CFLAGS, and committed.  Seems like it
came in with:

date: 2000/10/08 21:13:27;  author: petere;  state: Exp;  lines: +165 -137
Append "/postgresql" to (certain) installation subdirectories when
installing into a shared location.  Also Makefile.global organizational
cleanup.

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

Tue, 10 Oct 2000 09:06:18 -0400 (EDT)
Bruce Momjian <pgman@candle.pha.pa.us>
Re: CVS broken?
Hiroshi Inoue writes:

> For example the following line
>     CFLAGS+= -DFRONTEND -I$(srcdir)
> in makefiles doesn't work currently.
> 
> I found the recent change in Makefile.global.in.
> ifeq ($(GCC), yes)
>      override CFLAGS += -Wall -Wmissing-prototypes -Wmissing-declarations
> endif

Seems like a problem in make.  What versions are you using?

-- 
Peter Eisentraut      peter_e@gmx.net       http://yi.org/peter-e/


Tue, 10 Oct 2000 18:49:16 +0200 (CEST)
Peter Eisentraut <peter_e@gmx.net>
Re: CVS broken?


Peter Eisentraut wrote:

> Hiroshi Inoue writes:
>
> > For example the following line
> >     CFLAGS+= -DFRONTEND -I$(srcdir)
> > in makefiles doesn't work currently.
> >
> > I found the recent change in Makefile.global.in.
> > ifeq ($(GCC), yes)
> >      override CFLAGS += -Wall -Wmissing-prototypes -Wmissing-declarations
> > endif
>
> Seems like a problem in make.  What versions are you using?
>

I tried the following makefile in cygwin and linux 2.0.36.

[makefile]
#
override CFLAGS += -DDEFINE1
CFLAGS += -DDEFINE2

all: a.o

[cygwin]
$ make -v
GNU Make version 3.79.1, by Richard Stallman and Roland McGrath.
Built for i686-pc-cygwin
Copyright (C) 1988, 89, 90, 91, 92, 93, 94, 95, 96, 97, 98, 99, 2000
        Free Software Foundation, Inc.
...
$ make
gcc -DDEFINE1   -c -o a.o a.c
a.c:1: parse error before `{'
make: *** [a.o] Error 1

[linux]
$ make -v
GNU Make version 3.76.1, by Richard Stallman and Roland McGrath.
Copyright (C) 1988, 89, 90, 91, 92, 93, 94, 95, 96, 97
        Free Software Foundation, Inc.
...
$ make
cc -DDEFINE1   -c a.c -o a.o
a.c:1: parse error before `{'
make: *** [a.o] Error 1

-DDEFINE2 is expanded in neither case.

Regards.

Hiroshi Inoue


Wed, 11 Oct 2000 08:35:57 +0900
Hiroshi Inoue <Inoue@tpf.co.jp>
Re: CVS broken?