TODO:  I have added a syntax suggested by someone on IRC:

* Make it easier to create a database owned by someone who can't createdb,
  perhaps CREATE DATABASE dbname WITH USER = "user"
  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

Thu, 3 Jan 2002 03:00:44 -0500 (EST)
Bruce Momjian <pgman@candle.pha.pa.us>
Updated TODO item
Bruce Momjian wrote:

>TODO:  I have added a syntax suggested by someone on IRC:
>
>* Make it easier to create a database owned by someone who can't createdb,
>  perhaps CREATE DATABASE dbname WITH USER = "user"
>  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>
Perhaps  "CREATE DATABASE dbname WITH USER username" would fit a little 
better.   I'd love to see this one get done... ;-)



Thu, 03 Jan 2002 03:19:29 -0600
Thomas Swan <tswan-lst@ics.olemiss.edu>
Re: Updated TODO item
On Thu, 3 Jan 2002, Bruce Momjian wrote:

> TODO:  I have added a syntax suggested by someone on IRC:
> 
> * Make it easier to create a database owned by someone who can't createdb,
>   perhaps CREATE DATABASE dbname WITH USER = "user"
>   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Attached is a patch which implements this. Passes regression:

======================
 All 79 tests passed.
======================

This required the modification of the CreatedbStmt data structure. I've
ensured that all functions which interact with CreatedbStmt have been
modified.

Gavin
Fri, 4 Jan 2002 02:27:03 +1100 (EST)
Gavin Sherry <swm@linuxworld.com.au>
Re: [HACKERS] Updated TODO item
Thomas Swan wrote:
> Bruce Momjian wrote:
> 
> >TODO:  I have added a syntax suggested by someone on IRC:
> >
> >* Make it easier to create a database owned by someone who can't createdb,
> >  perhaps CREATE DATABASE dbname WITH USER = "user"
> >  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> >
> Perhaps  "CREATE DATABASE dbname WITH USER username" would fit a little 
> better.   I'd love to see this one get done... ;-)

Well, I had the equals sign because the documentation for other params
suggests it:

	CREATE DATABASE name
	    [ WITH [ LOCATION = 'dbpath' ]
	           [ TEMPLATE = template ]
	           [ ENCODING = encoding ] ]

Maybe we should make the equals optional for all these options.

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

Thu, 3 Jan 2002 12:21:11 -0500 (EST)
Bruce Momjian <pgman@candle.pha.pa.us>
Re: Updated TODO item

Thanks.  Saved for 7.3.

---------------------------------------------------------------------------

Gavin Sherry wrote:
> On Thu, 3 Jan 2002, Bruce Momjian wrote:
> 
> > TODO:  I have added a syntax suggested by someone on IRC:
> > 
> > * Make it easier to create a database owned by someone who can't createdb,
> >   perhaps CREATE DATABASE dbname WITH USER = "user"
> >   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> 
> Attached is a patch which implements this. Passes regression:
> 
> ======================
>  All 79 tests passed.
> ======================
> 
> This required the modification of the CreatedbStmt data structure. I've
> ensured that all functions which interact with CreatedbStmt have been
> modified.
> 
> Gavin

Content-Description: 

[ Attachment, skipping... ]

> 
> ---------------------------(end of broadcast)---------------------------
> TIP 2: you can get off all lists at once with the unregister command
>     (send "unregister YourEmailAddressHere" to majordomo@postgresql.org)

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

Thu, 3 Jan 2002 12:27:58 -0500 (EST)
Bruce Momjian <pgman@candle.pha.pa.us>
Re: [HACKERS] Updated TODO item





Bruce Momjian wrote:

Thomas Swan wrote:

Bruce Momjian wrote:

TODO:  I have added a syntax suggested by someone on IRC:* Make it easier to create a database owned by someone who can't createdb, perhaps CREATE DATABASE dbname WITH USER = "user" ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Perhaps  "CREATE DATABASE dbname WITH USER username" would fit a little better.   I'd love to see this one get done... ;-)

Well, I had the equals sign because the documentation for other paramssuggests it:	CREATE DATABASE name	    [ WITH [ LOCATION = 'dbpath' ]	           [ TEMPLATE = template ]	           [ ENCODING = encoding ] ]Maybe we should make the equals optional for all these options.

They need to be consistent.   I had forgotten that the existing syntax contained
the "=" character.  Either way would be fine, but the "user = " option would
definitely be a welcome addition.   I





Thu, 03 Jan 2002 12:17:39 -0600
Thomas Swan <tswan-lst@ics.olemiss.edu>
Re: Updated TODO item
Thomas Swan wrote:
> Bruce Momjian wrote:
> 
> >TODO:  I have added a syntax suggested by someone on IRC:
> >
> >* Make it easier to create a database owned by someone who can't createdb,
> >  perhaps CREATE DATABASE dbname WITH USER = "user"
> >  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> >
> Perhaps  "CREATE DATABASE dbname WITH USER username" would fit a little 
> better.   I'd love to see this one get done... ;-)

OK, I checked at CREATE DATABASE is the only command that has the equals
in WITH PARAM = VAL.  Added to TODO:

	* Make equals sign optional in CREATE DATABASE WITH param = 'val'

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

Thu, 3 Jan 2002 13:21:23 -0500 (EST)
Bruce Momjian <pgman@candle.pha.pa.us>
Re: Updated TODO item
On Thu, 3 Jan 2002, Bruce Momjian wrote:

> > Perhaps  "CREATE DATABASE dbname WITH USER username" would fit a little 
> > better.   I'd love to see this one get done... ;-)
> 
> Well, I had the equals sign because the documentation for other params
> suggests it:
> 
> 	CREATE DATABASE name
> 	    [ WITH [ LOCATION = 'dbpath' ]
> 	           [ TEMPLATE = template ]
> 	           [ ENCODING = encoding ] ]
> 
> Maybe we should make the equals optional for all these options.
> 

'WITH LOCATION dbpath', etc makes more sense. I'd be happy to revise my
patch to change this. Does anyone have any strong feelings against this?

Gavin


Fri, 4 Jan 2002 12:17:09 +1100 (EST)
Gavin Sherry <swm@linuxworld.com.au>
Re: Updated TODO item
On Thu, 3 Jan 2002, Bruce Momjian wrote:

> Thomas Swan wrote:
> > Bruce Momjian wrote:
> > 
> > >TODO:  I have added a syntax suggested by someone on IRC:
> > >
> > >* Make it easier to create a database owned by someone who can't createdb,
> > >  perhaps CREATE DATABASE dbname WITH USER = "user"
> > >  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> > >
> > Perhaps  "CREATE DATABASE dbname WITH USER username" would fit a little 
> > better.   I'd love to see this one get done... ;-)
> 
> OK, I checked at CREATE DATABASE is the only command that has the equals
> in WITH PARAM = VAL.  Added to TODO:
> 
> 	* Make equals sign optional in CREATE DATABASE WITH param = 'val'

I've revised my previous patch to handle this.

Gavin
Fri, 4 Jan 2002 12:56:34 +1100 (EST)
Gavin Sherry <swm@linuxworld.com.au>
Re: [HACKERS] Updated TODO item
Gavin Sherry wrote:
> On Thu, 3 Jan 2002, Bruce Momjian wrote:
> 
> > Thomas Swan wrote:
> > > Bruce Momjian wrote:
> > > 
> > > >TODO:  I have added a syntax suggested by someone on IRC:
> > > >
> > > >* Make it easier to create a database owned by someone who can't createdb,
> > > >  perhaps CREATE DATABASE dbname WITH USER = "user"
> > > >  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> > > >
> > > Perhaps  "CREATE DATABASE dbname WITH USER username" would fit a little 
> > > better.   I'd love to see this one get done... ;-)
> > 
> > OK, I checked at CREATE DATABASE is the only command that has the equals
> > in WITH PARAM = VAL.  Added to TODO:
> > 
> > 	* Make equals sign optional in CREATE DATABASE WITH param = 'val'
> 
> I've revised my previous patch to handle this.
> 

Thanks.  Saved for 7.3.

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

Thu, 3 Jan 2002 23:43:27 -0500 (EST)
Bruce Momjian <pgman@candle.pha.pa.us>
Re: [HACKERS] Updated TODO item
> * Make it easier to create a database owned by someone who can't createdb,
>   perhaps CREATE DATABASE dbname WITH USER = "user"
>   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Shouldn't that be

CREATE DATABASE dbname WITH OWNER = "user"

?

-- 
Kaare Rasmussen            --Linux, spil,--        Tlf:        3816 2582
Kaki Data                tshirts, merchandize      Fax:        3816 2501
Howitzvej 75               ï¿½ben 14.00-18.00        Web:      www.suse.dk
2000 Frederiksberg        Lï¿½rdag 11.00-17.00       Email: kar@kakidata.dk

Fri, 4 Jan 2002 17:47:51 +0100
Kaare Rasmussen <kar@webline.dk>
Re: Updated TODO item

Your patch has been added to the PostgreSQL unapplied patches list at:

	http://candle.pha.pa.us/cgi-bin/pgpatches

I will try to apply it within the next 48 hours.

---------------------------------------------------------------------------


Gavin Sherry wrote:
> On Thu, 3 Jan 2002, Bruce Momjian wrote:
> 
> > Thomas Swan wrote:
> > > Bruce Momjian wrote:
> > > 
> > > >TODO:  I have added a syntax suggested by someone on IRC:
> > > >
> > > >* Make it easier to create a database owned by someone who can't createdb,
> > > >  perhaps CREATE DATABASE dbname WITH USER = "user"
> > > >  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> > > >
> > > Perhaps  "CREATE DATABASE dbname WITH USER username" would fit a little 
> > > better.   I'd love to see this one get done... ;-)
> > 
> > OK, I checked at CREATE DATABASE is the only command that has the equals
> > in WITH PARAM = VAL.  Added to TODO:
> > 
> > 	* Make equals sign optional in CREATE DATABASE WITH param = 'val'
> 
> I've revised my previous patch to handle this.
> 
> Gavin

Content-Description: 

[ Attachment, skipping... ]

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

Fri, 22 Feb 2002 20:59:29 -0500 (EST)
Bruce Momjian <pgman@candle.pha.pa.us>
Re: Updated TODO item