The installed name of perl in needed in interfaces/Makefile.  This
seems to have been changed from perl to perl5 sometime between 6.5 and
6.5.2.  I missed discussion of this, I guess.

What was the rationale for making this change?

Cheers,
Brook

Mon, 1 Nov 1999 13:16:08 -0700 (MST)
Brook Milligan <brook@biology.nmsu.edu>
change in name of perl?
> The installed name of perl in needed in interfaces/Makefile.  This
> seems to have been changed from perl to perl5 sometime between 6.5 and
> 6.5.2.  I missed discussion of this, I guess.

You mean the directory name was changed?  I don't see any perl-mentioned
changes in these releases.

-- 
  Bruce Momjian                        |  http://www.op.net/~candle
  maillist@candle.pha.pa.us            |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

Mon, 1 Nov 1999 18:04:42 -0500 (EST)
Bruce Momjian <maillist@candle.pha.pa.us>
Re: [HACKERS] change in name of perl?
Bruce Momjian wrote:
> 
> > The installed name of perl in needed in interfaces/Makefile.  This
> > seems to have been changed from perl to perl5 sometime between 6.5 and
> > 6.5.2.  I missed discussion of this, I guess.
> 
> You mean the directory name was changed?  I don't see any perl-mentioned
> changes in these releases.

src/interfaces/Makefile:
-----------
perl5/Makefile: perl5/Makefile.PL
	cd perl5 && perl5 Makefile.PL

install-perl5: perl5/Makefile
	$(MAKE) -C perl5 clean
	cd perl5 && POSTGRES_HOME="$(POSTGRESDIR)" perl5 Makefile.PL
-----------
Should be:
-----------
perl5/Makefile: perl5/Makefile.PL
	cd perl5 && perl Makefile.PL

install-perl5: perl5/Makefile
	$(MAKE) -C perl5 clean
	cd perl5 && POSTGRES_HOME="$(POSTGRESDIR)" perl Makefile.PL
-----------
Which is the way it read in 6.5.1, IIANM.  I know that I didn't have to
patch this in 6.5.1.

--
Lamar Owen
WGCR Internet Radio
1 Peter 4:11

Mon, 01 Nov 1999 20:15:53 -0500
Lamar Owen <lamar.owen@wgcr.org>
Re: [HACKERS] change in name of perl?
> Bruce Momjian wrote:
> > 
> > > The installed name of perl in needed in interfaces/Makefile.  This
> > > seems to have been changed from perl to perl5 sometime between 6.5 and
> > > 6.5.2.  I missed discussion of this, I guess.
> > 
> > You mean the directory name was changed?  I don't see any perl-mentioned
> > changes in these releases.
> 
> src/interfaces/Makefile:
> -----------
> perl5/Makefile: perl5/Makefile.PL
> 	cd perl5 && perl5 Makefile.PL
> 
> install-perl5: perl5/Makefile
> 	$(MAKE) -C perl5 clean
> 	cd perl5 && POSTGRES_HOME="$(POSTGRESDIR)" perl5 Makefile.PL
> -----------
> Should be:
> -----------
> perl5/Makefile: perl5/Makefile.PL
> 	cd perl5 && perl Makefile.PL
> 
> install-perl5: perl5/Makefile
> 	$(MAKE) -C perl5 clean
> 	cd perl5 && POSTGRES_HOME="$(POSTGRESDIR)" perl Makefile.PL
> -----------
> Which is the way it read in 6.5.1, IIANM.  I know that I didn't have to
> patch this in 6.5.1.

Thanks again.

I had applied someone's patch so perl5 would be used, but that broke
many things.  I fixed the current tree to use $(PERL) as defined in
Makefile.global.  I just patched stable the same way.  Please test. 
Thanks.


-- 
  Bruce Momjian                        |  http://www.op.net/~candle
  maillist@candle.pha.pa.us            |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

Mon, 1 Nov 1999 21:35:48 -0500 (EST)
Bruce Momjian <maillist@candle.pha.pa.us>
Re: [HACKERS] change in name of perl?
On Mon, 01 Nov 1999, Bruce Momjian wrote:

> I had applied someone's patch so perl5 would be used, but that broke
> many things.  I fixed the current tree to use $(PERL) as defined in
> Makefile.global.  I just patched stable the same way.  Please test. 
> Thanks.

No joy.  the $(PERL) variable is apparently not being set -- the make goes out
at the line:
cd perl5 &&  Makefile.PL

(which should have that $(PERL) in there.....)

It is beginning to storm here, so I think I'd better shut down and unplug. 
Will have at it at work tomorrow.

--
Lamar Owen
WGCR Internet Radio
1 Peter 4:11

Mon, 1 Nov 1999 23:30:35 -0500
Lamar Owen <lamar.owen@wgcr.org>
Re: [HACKERS] change in name of perl?
> On Mon, 01 Nov 1999, Bruce Momjian wrote:
> 
> > I had applied someone's patch so perl5 would be used, but that broke
> > many things.  I fixed the current tree to use $(PERL) as defined in
> > Makefile.global.  I just patched stable the same way.  Please test. 
> > Thanks.
> 
> No joy.  the $(PERL) variable is apparently not being set -- the make goes out
> at the line:
> cd perl5 &&  Makefile.PL
> 
> (which should have that $(PERL) in there.....)
> 
> It is beginning to storm here, so I think I'd better shut down and unplug. 
> Will have at it at work tomorrow.

OK, fix applied.  Seems like that fix wasn't in stable tree either.

-- 
  Bruce Momjian                        |  http://www.op.net/~candle
  maillist@candle.pha.pa.us            |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

Mon, 1 Nov 1999 23:44:55 -0500 (EST)
Bruce Momjian <maillist@candle.pha.pa.us>
Re: [HACKERS] change in name of perl?
   OK, fix applied.  Seems like that fix wasn't in stable tree either.

Does this mean that 6.5.3-to-be and the current branch are both fixed?

Cheers,
Brook

Tue, 2 Nov 1999 08:11:20 -0700 (MST)
Brook Milligan <brook@biology.nmsu.edu>
Re: [HACKERS] change in name of perl?
>    OK, fix applied.  Seems like that fix wasn't in stable tree either.
> 
> Does this mean that 6.5.3-to-be and the current branch are both fixed?

Yes, the current branch had already been fixed.  I had not fixed the
6.5.* branch because I thought the breakage was only in current.


-- 
  Bruce Momjian                        |  http://www.op.net/~candle
  maillist@candle.pha.pa.us            |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

Tue, 2 Nov 1999 10:13:45 -0500 (EST)
Bruce Momjian <maillist@candle.pha.pa.us>
Re: [HACKERS] change in name of perl?
Bruce Momjian wrote:
> 
> >    OK, fix applied.  Seems like that fix wasn't in stable tree either.
> >
> > Does this mean that 6.5.3-to-be and the current branch are both fixed?
> 
> Yes, the current branch had already been fixed.  I had not fixed the
> 6.5.* branch because I thought the breakage was only in current.

That was my error, as I should have specified that I am currently only
building REL6_5_PATCHES in preparation for the release of 6.5.3, so that
I can have testing rpms out close to concurrently with the tarball
release.

Building REL6_5_PATCHES now.... and the make has successfully built the
perl client.  If something else goes wrong either before the binary
RPM's are written or after they are installed and tested, I'll let you
know.  But, it looks like 6.5.3 is ready.

--
Lamar Owen
WGCR Internet Radio
1 Peter 4:11

Tue, 02 Nov 1999 11:43:57 -0500
Lamar Owen <lamar.owen@wgcr.org>
Re: [HACKERS] change in name of perl?