Heads up to packagers:

src/bin/pgaccess/pgaccess.sh has been changed in CURRENT CVS to use
hardcoded PATH_TO_WISH and PGACCESS_HOME, rather than using __wish__ and
__POSTGRESDIR__.

Bruce??

--
Lamar Owen
WGCR Internet Radio
1 Peter 4:11

Fri, 31 Mar 2000 08:55:08 -0500
Lamar Owen <lamar.owen@wgcr.org>
pgAccess change
> Heads up to packagers:
> 
> src/bin/pgaccess/pgaccess.sh has been changed in CURRENT CVS to use
> hardcoded PATH_TO_WISH and PGACCESS_HOME, rather than using __wish__ and
> __POSTGRESDIR__.
> 
> Bruce??

Have I mentioned how much I hate installing pgaccess from a tarball
directly into our tree, and not knowing what is new about it.  Let me
mention that again...  :-)

Fixed.

-- 
  Bruce Momjian                        |  http://www.op.net/~candle
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

Fri, 31 Mar 2000 09:05:24 -0500 (EST)
Bruce Momjian <pgman@candle.pha.pa.us>
Re: pgAccess change
Bruce Momjian wrote:
 
> > Heads up to packagers:

> > src/bin/pgaccess/pgaccess.sh has been changed in CURRENT CVS to use
> > hardcoded PATH_TO_WISH and PGACCESS_HOME, rather than using __wish__ and
> > __POSTGRESDIR__.

> > Bruce??
 
> Have I mentioned how much I hate installing pgaccess from a tarball
> directly into our tree, and not knowing what is new about it.  Let me
> mention that again...  :-)

Yes, more than once.  Good to have the update; not good to have the
hard-coded stuff.
 
> Fixed.

Thanks.  I'm building a test RPM here so I can satisfy Tom's request for
regress results on CURRENT.  My rpm patchset barfed on pgaccess -- so I
investigated.  I fixed it in my local tree, but wanted to alert folk.

It's nice to have a machine now that will build the RPM in less than
five minutes :-)....

--
Lamar Owen
WGCR Internet Radio
1 PEter 4:11

Fri, 31 Mar 2000 09:23:01 -0500
Lamar Owen <lamar.owen@wgcr.org>
Re: pgAccess change
> Yes, more than once.  Good to have the update; not good to have the
> hard-coded stuff.
>  
> > Fixed.
> 
> Thanks.  I'm building a test RPM here so I can satisfy Tom's request for
> regress results on CURRENT.  My rpm patchset barfed on pgaccess -- so I
> investigated.  I fixed it in my local tree, but wanted to alert folk.
> 
> It's nice to have a machine now that will build the RPM in less than
> five minutes :-)....

Glad you found it.  That was the one file I had to modify to get it to
match our old version, and obviously I messed that up.


-- 
  Bruce Momjian                        |  http://www.op.net/~candle
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

Fri, 31 Mar 2000 09:27:32 -0500 (EST)
Bruce Momjian <pgman@candle.pha.pa.us>
Re: pgAccess change
Bruce Momjian wrote:
> > Thanks.  I'm building a test RPM here so I can satisfy Tom's request for
> > regress results on CURRENT.  My rpm patchset barfed on pgaccess -- so I
> > investigated.  I fixed it in my local tree, but wanted to alert folk.
 
> Glad you found it.  That was the one file I had to modify to get it to
> match our old version, and obviously I messed that up.

I'm going to take this opportunity to thank Marc for having a cvsweb
interface -- as I was able to see when the difference was introduced
using that interface.

Given the number of things you patch, Bruce, it shouldn't surprise
anyone that an occassional error is introduced -- that's why it's good
to have many sets of eyes looking at the code.  I can only have
nightmares about how many errors I could cause if I were applying
patches at that rate... :-)

--
Lamar Owen
WGCR Internet Radio
1 Peter 4:11

Fri, 31 Mar 2000 09:36:30 -0500
Lamar Owen <lamar.owen@wgcr.org>
Re: pgAccess change
> Bruce Momjian wrote:
> > > Thanks.  I'm building a test RPM here so I can satisfy Tom's request for
> > > regress results on CURRENT.  My rpm patchset barfed on pgaccess -- so I
> > > investigated.  I fixed it in my local tree, but wanted to alert folk.
>  
> > Glad you found it.  That was the one file I had to modify to get it to
> > match our old version, and obviously I messed that up.
> 
> I'm going to take this opportunity to thank Marc for having a cvsweb
> interface -- as I was able to see when the difference was introduced
> using that interface.
> 
> Given the number of things you patch, Bruce, it shouldn't surprise
> anyone that an occassional error is introduced -- that's why it's good
> to have many sets of eyes looking at the code.  I can only have
> nightmares about how many errors I could cause if I were applying
> patches at that rate... :-)

The problem with pgaccess is that is not a patch I can eyeball.  It is a
stand-alone tar file that writes over our files.  I am never sure what
is new or old until I see what files show as new, etc.

-- 
  Bruce Momjian                        |  http://www.op.net/~candle
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

Fri, 31 Mar 2000 09:44:20 -0500 (EST)
Bruce Momjian <pgman@candle.pha.pa.us>
Re: pgAccess change
On Fri, 31 Mar 2000, Lamar Owen wrote:

> Bruce Momjian wrote:
> > > Thanks.  I'm building a test RPM here so I can satisfy Tom's request for
> > > regress results on CURRENT.  My rpm patchset barfed on pgaccess -- so I
> > > investigated.  I fixed it in my local tree, but wanted to alert folk.
>  
> > Glad you found it.  That was the one file I had to modify to get it to
> > match our old version, and obviously I messed that up.
> 
> I'm going to take this opportunity to thank Marc for having a cvsweb
> interface -- as I was able to see when the difference was introduced
> using that interface.

Actually that was Hal that came up with that.

Vince.
-- 
==========================================================================
Vince Vielhaber -- KA8CSH    email: vev@michvhf.com    http://www.pop4.net
   128K ISDN: $24.95/mo or less - 56K Dialup: $17.95/mo or less at Pop4
        Online Campground Directory    http://www.camping-usa.com
       Online Giftshop Superstore    http://www.cloudninegifts.com
==========================================================================




Fri, 31 Mar 2000 09:45:47 -0500 (EST)
Vince Vielhaber <vev@michvhf.com>
Re: pgAccess change