Hello,

Followings are proposed fixes to jdbc.sgml(line numbers are for 7.1.3
doc). Comments?

jdbc.sgml

[invalid column's name in a SELECT statement]

lines 579

x  PreparedStatement ps = con.prepareStatement("SELECT oid FROM images WHERE name=?");

o  PreparedStatement ps = con.prepareStatement("SELECT imgoid FROM images WHERE imgname=?");


[the modifier in the document is different from the one in the source]

lines 1280
org.postgresql.geometric.PGcircle

x  public double radius

o  double radius  // in the source, here


[invalid return type]

lines 1996
org.postgresql.largeobject.LargeObject#read()

x  public void read(byte buf[],

o  public int read(byte buf[],


[the discription of arguments type is incorrectly]

lines 2419
a constructor of org.postgresql.util.Serialize

x  public Serialize(Connection c,
                    String type) throws SQLException

o  public Serialize(org.postgresql.Connection c,
                    String type) throws SQLException

lines 2462, 2504
org.postgresql.util.Seriarize#create()

x  public static void create(Connection con,
                             Object o) throws SQLException

o  public static void create(org.postgresql.Connection con,
                             Object o) throws SQLException

lines 2518
org.postgresql.util.Seriarize#create()

x  public static void create(Connection con,
                             Class o) throws SQLException

o  public static void create(org.postgresql.Connection con,
                             Class o) throws SQLException


[Cannot access to the page]

lines 2910

x  See John Dumas's Java Crypt page for the original source.

   http://www.zeh.com/local/jfd/crypt.html

(Sorry, I can't find a replacement page.)

Thanks.
----
Hiroyuki Yatabe(yatabe@sra.co.jp)
Software Research Associates, Inc.

Tue, 11 Sep 2001 12:52:56 +0900
Hiroyuki Yatabe <yatabe@sra.co.jp>
Proposals for jdbc.sgml(in 7.1.3 doc)
Thanks.  I am attaching the patch I applied.

> Hello,
> 
> Followings are proposed fixes to jdbc.sgml(line numbers are for 7.1.3
> doc). Comments?
> 
> jdbc.sgml
> 
> [invalid column's name in a SELECT statement]
> 
> lines 579
> 
> x  PreparedStatement ps = con.prepareStatement("SELECT oid FROM images WHERE name=?");
> 
> o  PreparedStatement ps = con.prepareStatement("SELECT imgoid FROM images WHERE imgname=?");
> 
> 
> [the modifier in the document is different from the one in the source]
> 
> lines 1280
> org.postgresql.geometric.PGcircle
> 
> x  public double radius
> 
> o  double radius  // in the source, here
> 
> 
> [invalid return type]
> 
> lines 1996
> org.postgresql.largeobject.LargeObject#read()
> 
> x  public void read(byte buf[],
> 
> o  public int read(byte buf[],
> 
> 
> [the discription of arguments type is incorrectly]
> 
> lines 2419
> a constructor of org.postgresql.util.Serialize
> 
> x  public Serialize(Connection c,
>                     String type) throws SQLException
> 
> o  public Serialize(org.postgresql.Connection c,
>                     String type) throws SQLException
> 
> lines 2462, 2504
> org.postgresql.util.Seriarize#create()
> 
> x  public static void create(Connection con,
>                              Object o) throws SQLException
> 
> o  public static void create(org.postgresql.Connection con,
>                              Object o) throws SQLException
> 
> lines 2518
> org.postgresql.util.Seriarize#create()
> 
> x  public static void create(Connection con,
>                              Class o) throws SQLException
> 
> o  public static void create(org.postgresql.Connection con,
>                              Class o) throws SQLException
> 
> 
> [Cannot access to the page]
> 
> lines 2910
> 
> x  See John Dumas's Java Crypt page for the original source.
> 
>    http://www.zeh.com/local/jfd/crypt.html
> 
> (Sorry, I can't find a replacement page.)
> 
> Thanks.
> ----
> Hiroyuki Yatabe(yatabe@sra.co.jp)
> Software Research Associates, Inc.
> 
> ---------------------------(end of broadcast)---------------------------
> TIP 1: subscribe and unsubscribe commands go to majordomo@postgresql.org
> 

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

Index: doc/src/sgml/jdbc.sgml
===================================================================
RCS file: /home/projects/pgsql/cvsroot/pgsql/doc/src/sgml/jdbc.sgml,v
retrieving revision 1.22
diff -c -r1.22 jdbc.sgml
*** doc/src/sgml/jdbc.sgml	2001/09/10 21:58:46	1.22
--- doc/src/sgml/jdbc.sgml	2001/09/12 15:46:13
***************
*** 576,587 ****
      <classname>Statement</classname> class can equally be used.)
  
  <programlisting>
! PreparedStatement ps = con.prepareStatement("SELECT oid FROM images WHERE name=?");
  ps.setString(1, "myimage.gif");
  ResultSet rs = ps.executeQuery();
  if (rs != null) {
      while(rs.next()) {
!         InputStream is = rs.getBinaryInputStream(1);
          // use the stream in some way here
          is.close();
      }
--- 576,587 ----
      <classname>Statement</classname> class can equally be used.)
  
  <programlisting>
! PreparedStatement ps = con.prepareStatement("SELECT imgoid FROM images WHERE imgname=?");
  ps.setString(1, "myimage.gif");
  ResultSet rs = ps.executeQuery();
  if (rs != null) {
      while(rs.next()) {
!         InputStream is = rs.getBinaryStream(1);
          // use the stream in some way here
          is.close();
      }
***************
*** 1277,1283 ****
             
            This is the center point
   
! public double radius
             
            This is the radius
     
--- 1277,1283 ----
             
            This is the center point
   
!  double radius
             
            This is the radius
     
***************
*** 1993,1999 ****
  
        <listitem>
  <synopsis>
! public void read(byte buf[],
                   int off,
                   int len) throws SQLException
  </synopsis>
--- 1993,1999 ----
  
        <listitem>
  <synopsis>
! public int read(byte buf[],
                   int off,
                   int len) throws SQLException
  </synopsis>
***************
*** 2416,2422 ****
  
  Constructors
  
!  public Serialize(Connection c,
                    String type) throws SQLException
  
            This creates an instance that can be used to serialize 
--- 2416,2422 ----
  
  Constructors
  
!  public Serialize(org.postgresql.Connection c,
                    String type) throws SQLException
  
            This creates an instance that can be used to serialize 
***************
*** 2459,2465 ****
          Throws: SQLException
                  on error
   
!  public static void create(Connection con,
                             Object o) throws SQLException
  
            This method is not used by the driver, but it creates a 
--- 2459,2465 ----
          Throws: SQLException
                  on error
   
!  public static void create(org.postgresql.Connection con,
                             Object o) throws SQLException
  
            This method is not used by the driver, but it creates a 
***************
*** 2501,2507 ****
          Throws: SQLException
                  on error
   
!  public static void create(Connection con,
                             Object o) throws SQLException
  
            This method is not used by the driver, but it creates a 
--- 2501,2507 ----
          Throws: SQLException
                  on error
   
!  public static void create(org.postgresql.Connection con,
                             Object o) throws SQLException
  
            This method is not used by the driver, but it creates a 
***************
*** 2907,2915 ****
     Contains static methods to encrypt and compare passwords with Unix 
  encrypted passwords.
  
!    See John Dumas's Java Crypt page for the original source.
  
!    http://www.zeh.com/local/jfd/crypt.html
  
  Methods
  
--- 2907,2915 ----
     Contains static methods to encrypt and compare passwords with Unix 
  encrypted passwords.
  
!    See John Dumas's Java Crypt page for the original source.  
  
!    (Invalid URL) http://www.zeh.com/local/jfd/crypt.html
  
  Methods
Wed, 12 Sep 2001 11:48:45 -0400 (EDT)
Bruce Momjian <pgman@candle.pha.pa.us>
Re: Proposals for jdbc.sgml(in 7.1.3 doc)