> Peter Eisentraut <peter_e@gmx.net> writes:
> > We're losing this battle anyway.  Look into 
> src/interfaces/libpq/libpq.rc.
> 
> Ugh.  Magnus, is there any reasonable way to generate that 
> thing on the fly on Win32?
It's the same thing as with version.h - e.g. not really :-( It can be done,
but I doubt it can be done cleanly.


> One could imagine fixing this in configure --- have configure generate
> libpq.rc from libpq.rc.in, and then treat libpq.rc as part of the
> distribution the same as we do for gram.c and so forth.  The version
> info could get substituted into config.h.win32 the same way, 
> I suppose.
> 
> This is pretty ugly, but you could look at it as being no different
> from providing gram.c for those without bison: ship those dependent
> files that can't be remade without tools that may not exist on the
> target platform.
> 
> You'll probably say "that's more trouble than it's worth", but version
> info in a file that's only used by a marginally-supported platform is
> just the kind of thing that humans will forget to update.

If it is possible to do that, then I think it would be the best. (And
putting it in both a .h and the .rc file). It wuold definitly make things
cleaner-looking for the end user :-)

I have no idea how to do this, though, so I can't submit a patch. But if
someone were to do it and tell me where/how it goes into a header, I can
update the win32 patch to work with it...

Regards,
 Magnus

Wed, 24 Jan 2001 16:48:32 +0100
Magnus Hagander <mha@sollentuna.net>
RE: FW: Postgresql on win32 
Magnus Hagander writes:

> > Peter Eisentraut <peter_e@gmx.net> writes:
> > > We're losing this battle anyway.  Look into
> > src/interfaces/libpq/libpq.rc.
> >
> > Ugh.  Magnus, is there any reasonable way to generate that
> > thing on the fly on Win32?
> It's the same thing as with version.h - e.g. not really :-( It can be done,
> but I doubt it can be done cleanly.

> I have no idea how to do this, though, so I can't submit a patch. But if
> someone were to do it and tell me where/how it goes into a header, I can
> update the win32 patch to work with it...

Since all files are now up to date for 7.1 I don't feel a lot of urge to
work on this right now.  Maybe when we change this version again.

But realistically we're going to have to hand-maintain config.h.win32
anyway to account for new configure tests.

-- 
Peter Eisentraut      peter_e@gmx.net       http://yi.org/peter-e/


Wed, 24 Jan 2001 21:36:15 +0100 (CET)
Peter Eisentraut <peter_e@gmx.net>
RE: FW: Postgresql on win32 
I have added ./include/config.h.win32 to the RELEASE_CHANGES update
list.

> Magnus Hagander writes:
> 
> > > Peter Eisentraut <peter_e@gmx.net> writes:
> > > > We're losing this battle anyway.  Look into
> > > src/interfaces/libpq/libpq.rc.
> > >
> > > Ugh.  Magnus, is there any reasonable way to generate that
> > > thing on the fly on Win32?
> > It's the same thing as with version.h - e.g. not really :-( It can be done,
> > but I doubt it can be done cleanly.
> 
> > I have no idea how to do this, though, so I can't submit a patch. But if
> > someone were to do it and tell me where/how it goes into a header, I can
> > update the win32 patch to work with it...
> 
> Since all files are now up to date for 7.1 I don't feel a lot of urge to
> work on this right now.  Maybe when we change this version again.
> 
> But realistically we're going to have to hand-maintain config.h.win32
> anyway to account for new configure tests.
> 
> -- 
> Peter Eisentraut      peter_e@gmx.net       http://yi.org/peter-e/
> 
> 


-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

Wed, 24 Jan 2001 19:01:32 -0500 (EST)
Bruce Momjian <pgman@candle.pha.pa.us>
Re: FW: Postgresql on win32