Fabien, Christopher:

It would be nice for pgAdmin & PhpPgAdmin to have GUI interfaces to 
pg_advisor, though.

Also, I would argue for this to be a GBorg/pgFoundry project rather than part 
of the core.  It's the sort of thing that could easily be database-version 
agnostic, and that SQL jockeys who are not Hackers could contribute to.

> Also, if they have a partial index on the FK, it's not good enough!  In
> CVS, IS NOT NULL partial indexes should be used, but in general all
> others still won't...

Whoa, there, partner!   Keep in mind that there are *often* reasons for using 
a partial index on an FK, or even no index at all!  The docs for pg_advisor 
need to reflect that it only catches little details the developer might 
otherwise have missed.   It's not smarter than a DBA.

-- 
Josh Berkus
Aglio Database Solutions
San Francisco

Thu, 25 Mar 2004 08:19:09 -0800
Josh Berkus <josh@agliodbs.com>
Re: pg_advisor schema proof of concept

> > Also, if they have a partial index on the FK, it's not good enough!  In
> > CVS, IS NOT NULL partial indexes should be used, but in general all
> > others still won't...
>
> Whoa, there, partner!   Keep in mind that there are *often* reasons for using
> a partial index on an FK, or even no index at all!  The docs for pg_advisor
> need to reflect that it only catches little details the developer might
> otherwise have missed.   It's not smarter than a DBA.

Sure.

That's why advices are "graded" from info to error in the current
preliminary version.

Advices that may or may not be good depending on undecidable elements
have a lower grade. For instance, most attributes should be "NOT NULL"
from a statistical point of view, but it is perfectly legitimate to
have nullable attributes mostly anywhere, so the corresponding advices
is just an "info".

-- 
Fabien Coelho - coelho@cri.ensmp.fr

Thu, 25 Mar 2004 17:31:15 +0100 (CET)
Fabien COELHO <coelho@cri.ensmp.fr>
Re: pg_advisor schema proof of concept
On Thu, 2004-03-25 at 11:31, Fabien COELHO wrote:
> 
> > > Also, if they have a partial index on the FK, it's not good enough!  In
> > > CVS, IS NOT NULL partial indexes should be used, but in general all
> > > others still won't...
> >
> > Whoa, there, partner!   Keep in mind that there are *often* reasons for using
> > a partial index on an FK, or even no index at all!  The docs for pg_advisor
> > need to reflect that it only catches little details the developer might
> > otherwise have missed.   It's not smarter than a DBA.
> 
> Sure.
> 
> That's why advices are "graded" from info to error in the current
> preliminary version.
> 
> Advices that may or may not be good depending on undecidable elements
> have a lower grade. For instance, most attributes should be "NOT NULL"
> from a statistical point of view, but it is perfectly legitimate to
> have nullable attributes mostly anywhere, so the corresponding advices
> is just an "info".
> 

Are you planning on making some type of differentiation on advise that
is performance based rather than advise that is theory based?  I see
both cases being hinted at and it seems like a subtle but important
piece of information...

Robert Treat
-- 
Build A Brighter Lamp :: Linux Apache {middleware} PostgreSQL


25 Mar 2004 16:59:33 -0500
Robert Treat <xzilla@users.sourceforge.net>
Re: pg_advisor schema proof of concept

Dear Josh,

> > That's why advices are "graded" from info to error in the current
> > preliminary version.
>
> > Advices that may or may not be good depending on undecidable elements
> > have a lower grade. For instance, most attributes should be "NOT NULL"
> > from a statistical point of view, but it is perfectly legitimate to
> > have nullable attributes mostly anywhere, so the corresponding advices
> > is just an "info".
>
> Are you planning on making some type of differentiation on advise that
> is performance based rather than advise that is theory based?  I see
> both cases being hinted at and it seems like a subtle but important
> piece of information...

The current working status is that advices have a grade (info notice
warning error) and a kind (design, performance, meta).

More precise and subtle classification can be though of, but the interest
depends on the total number of advices in the system. Now there is around
a dozen of them, so there is no urge. It is easy to add some more
classification if needed.

Another place where such information can be given is within the
description which illustrate the advice. I think maybe this would be a
better place.

> LAMP = Linux Apache {middleware} Postgres

[JOKE] What about renaming postgreSQL myPostgres? ;-)

-- 
Fabien Coelho - coelho@cri.ensmp.fr

Fri, 26 Mar 2004 08:14:15 +0100 (MET)
Fabien COELHO <coelho@cri.ensmp.fr>
Re: pg_advisor schema proof of concept
On Thursday 25 March 2004 21:59, Robert Treat wrote:
> On Thu, 2004-03-25 at 11:31, Fabien COELHO wrote:
>
> Are you planning on making some type of differentiation on advise that
> is performance based rather than advise that is theory based?  I see
> both cases being hinted at and it seems like a subtle but important
> piece of information...

Fabien already has - there is an "advice_kind" table, values: misc, design, 
performance.


-- 
  Richard Huxton
  Archonet Ltd

Fri, 26 Mar 2004 07:15:22 +0000
Richard Huxton <dev@archonet.com>
Re: pg_advisor schema proof of concept