This new patch corrects 2 new bugs:
bug 1:
EXEC SQL define JOKER '?';
EXEC SQL define LINE "LINE";
could not be parsed

bug 2:
EXEC SQL define LEN 2;
memset(dst, '?', LEN);

was translated into

memset(dst, '?', 2
#line XX "thefile.ec"
);

which could not be compiled with gcc for instance

Nicolas BAZIN
Fri, 8 Mar 2002 18:35:18 +1100
"Nicolas Bazin" <nbazin@ingenico.com.au>
Additional fixes to ecpg - please apply patch
It seems you patch is reversed.

Anyway, I will look into it. I will have to change it some though as it
contains C++ comments. :-)

Michael
-- 
Michael Meskes
Michael@Fam-Meskes.De
Go SF 49ers! Go Rhein Fire!
Use Debian GNU/Linux! Use PostgreSQL!

Sun, 10 Mar 2002 12:40:36 +0100
Michael Meskes <meskes@postgresql.org>
Re: Additional fixes to ecpg - please apply patch
On Fri, Mar 08, 2002 at 06:35:18PM +1100, Nicolas Bazin wrote:
> This new patch corrects 2 new bugs:

Slighlty differently fixed this in CVS.

Thanks for reporting the bugs. Please tell me of my fix is not
sufficient.

Michael
-- 
Michael Meskes
Michael@Fam-Meskes.De
Go SF 49ers! Go Rhein Fire!
Use Debian GNU/Linux! Use PostgreSQL!

Sun, 10 Mar 2002 13:10:36 +0100
Michael Meskes <meskes@postgresql.org>
Re: Additional fixes to ecpg - please apply patch
On Sun, Mar 10, 2002 at 12:40:36PM +0100, Michael Meskes wrote:
> 
> Anyway, I will look into it. I will have to change it some though as it
> contains C++ comments. :-)

Which are also valid C comments nowadays, IIRC.  OTOH not all compilers
seem to honour that change...


Jeroen


Sun, 10 Mar 2002 14:28:12 +0100
jtv <jtv@xs4all.nl>
Re: Additional fixes to ecpg - please apply patch
On Sun, Mar 10, 2002 at 02:28:12PM +0100, jtv wrote:
> On Sun, Mar 10, 2002 at 12:40:36PM +0100, Michael Meskes wrote:
> > 
> > Anyway, I will look into it. I will have to change it some though as it
> > contains C++ comments. :-)
> 
> Which are also valid C comments nowadays, IIRC.  OTOH not all compilers
> seem to honour that change...

Yes, that's what I meant. :-(

Michael
-- 
Michael Meskes
Michael@Fam-Meskes.De
Go SF 49ers! Go Rhein Fire!
Use Debian GNU/Linux! Use PostgreSQL!

Sun, 10 Mar 2002 15:39:06 +0100
Michael Meskes <meskes@postgresql.org>
Re: Additional fixes to ecpg - please apply patch
jtv wrote:
> On Sun, Mar 10, 2002 at 12:40:36PM +0100, Michael Meskes wrote:
> > 
> > Anyway, I will look into it. I will have to change it some though as it
> > contains C++ comments. :-)
> 
> Which are also valid C comments nowadays, IIRC.  OTOH not all compilers
> seem to honour that change...

We don't support // comments in PostgreSQL in C.  Too many platforms
don't accept them.  We are not targeting only modern systems.

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

Wed, 13 Mar 2002 16:39:06 -0500 (EST)
Bruce Momjian <pgman@candle.pha.pa.us>
Re: [HACKERS] Additional fixes to ecpg - please apply patch