At 01:27 PM 24/08/2004, Tom Lane wrote:
>I prefer declaring it as unsigned, which means you drop the
>\377 end instead ...

...I've used explicit values (128) since '\200' is -127.


----------------------------------------------------------------
Philip Warner                    |     __---_____
Albatross Consulting Pty. Ltd.   |----/       -  \
(A.B.N. 75 008 659 498)          |          /(@)   ______---_
Tel: (+61) 0500 83 82 81         |                 _________  \
Fax: (+61) 03 5330 3172          |                 ___________ |
Http://www.rhyme.com.au          |                /           \|
                                  |    --________--
PGP key available upon request,  |  /
and from pgp.mit.edu:11371       |/  


Tue, 24 Aug 2004 13:44:10 +1000
Philip Warner <pjw@rhyme.com.au>
Re: New warning in pg_dump 
Philip Warner <pjw@rhyme.com.au> writes:
> At 01:27 PM 24/08/2004, Tom Lane wrote:
>> I prefer declaring it as unsigned, which means you drop the
>> \377 end instead ...

> ...I've used explicit values (128) since '\200' is -127.

Actually I'd go with "(unsigned char) '\200'".  There's a bunch
of different possible viewpoints here of course, but given that
you are trying to mimic a backend flex file that speaks of \200-\377,
I'd opt for something that's clearly traceable to that form.

			regards, tom lane

Mon, 23 Aug 2004 23:52:32 -0400
Tom Lane <tgl@sss.pgh.pa.us>
Re: New warning in pg_dump 