I want to make a contribution.
It is a new (to pgsql) procedural language.
Currently it already works (but debugging output 
is not disabled yet).

I've got some questions and considerations, please, correct me
if I am wrong:

I understand that pgsql uses autoconf but not other autotools.
The best location for such contribution is in
src/pl/pl<lang-name>

Now, how do I include my PL into the build list?
What files must I provide? (preferrably, by borrowing
them from another PL, e.g. PLPERL or TCL])

Currently, I compile the C source by hands:
cc -fpic -I /pgsql/src/include -c plpfe.c
cc -shared -Wl,--rpath -Wl,/usr/local/lib -Wl,--rpath -Wl,
/usr/local/lib/pfe -o plpfe.so plpfe.o -lpfe

One part of the implementation resides in the pfe build tree,
but it needs postgres.h and fmgr.h

Currently I use
#include "/pgsql/src/include/postgres.h"
#include "/pgsql/src/include/fmgr.h"
(/pgsql is a symlink to the PostgreSQL*.*.* directory)
but IMO there should be a better way.

Should I publish the project as plpfe.sf.net, or there's
a better location?

I also composed PLSAMPLE (the same implementation
components, but empty). IMO, it (PLSAMPLE) also should be 
there in the PSQL distribution.


regards, mlg

Thu, 25 Sep 2003 11:36:40 +0400 (MSD)
mlg3 <mlg3@mail15.com>
PL contribution guidelines?
mlg3 writes:

> I understand that pgsql uses autoconf but not other autotools.
> The best location for such contribution is in
> src/pl/pl<lang-name>
>
> Now, how do I include my PL into the build list?
> What files must I provide? (preferrably, by borrowing
> them from another PL, e.g. PLPERL or TCL])

There is currently some disagreement about whether every now procedural
language implementation should be included in the core distribution.  If
you choose to distribute your package separately, you can take a look at
http://developer.postgresql.org/~petere/plsh.html as an example for how to
package it.

> I also composed PLSAMPLE (the same implementation
> components, but empty). IMO, it (PLSAMPLE) also should be
> there in the PSQL distribution.

I think there is enough documentation about this already.  Creating a PL
handler is not a common task.  But if you have concrete points that you
would like to have mentioned somewhere, please tell us about them.

-- 
Peter Eisentraut   peter_e@gmx.net


Thu, 25 Sep 2003 13:12:25 +0200 (CEST)
Peter Eisentraut <peter_e@gmx.net>
Re: PL contribution guidelines?
On Thu, 2003-09-25 at 07:12, Peter Eisentraut wrote:
> mlg3 writes:
> > Now, how do I include my PL into the build list?
> > What files must I provide? (preferrably, by borrowing
> > them from another PL, e.g. PLPERL or TCL])
> 
> There is currently some disagreement about whether every now procedural
> language implementation should be included in the core distribution.  If
> you choose to distribute your package separately, you can take a look at
> http://developer.postgresql.org/~petere/plsh.html as an example for how to
> package it.
> 

Is there? The last new procedural language that I recall was Joe's plr,
which IIRC was moved to gborg due to license issues with the R
libraries. <troll>darn gpl license..if only it was commercially dual
licensed</troll>

otherwise my understanding is that all of the other pl authors that
distribute outside of core do so either by their own choosing or because
the proposed implementation is not quite "ready for prime time" enough
to be included.

oh.. and i'm not forgetting plphp, but it has both licensing issues and
isn't ready for prime time.

Robert Treat 
-- 
Build A Brighter Lamp :: Linux Apache {middleware} PostgreSQL


25 Sep 2003 11:36:52 -0400
Robert Treat <xzilla@users.sourceforge.net>
Re: PL contribution guidelines?
On 25 Sep 2003, Robert Treat wrote:

> oh.. and i'm not forgetting plphp, but it has both licensing issues and
> isn't ready for prime time.

I thought there weren't any license issues, except mayhaps with the name.

http://www.php.net/license/3_0.txt


Thu, 25 Sep 2003 11:15:02 -0600 (MDT)
"scott.marlowe" <scott.marlowe@ihs.com>
Re: PL contribution guidelines?
scott.marlowe wrote:
> On 25 Sep 2003, Robert Treat wrote:
> 
> > oh.. and i'm not forgetting plphp, but it has both licensing issues and
> > isn't ready for prime time.
> 
> I thought there weren't any license issues, except mayhaps with the name.
> 
> http://www.php.net/license/3_0.txt

That is what I thought too.  Originally PlPHP was stated as being
released as GPL (which the author thought was used by PHP), but later
corrected to be the BSD license.

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

Thu, 25 Sep 2003 13:26:37 -0400 (EDT)
Bruce Momjian <pgman@candle.pha.pa.us>
Re: PL contribution guidelines?
Hello,

  Yes plPHP is under the BSD style PHP license. We are going to dual 
license on next release which is REAL soon
now.

Sincerley,

Joshua Drake


Bruce Momjian wrote:

>scott.marlowe wrote:
>  
>
>>On 25 Sep 2003, Robert Treat wrote:
>>
>>    
>>
>>>oh.. and i'm not forgetting plphp, but it has both licensing issues and
>>>isn't ready for prime time.
>>>      
>>>
>>I thought there weren't any license issues, except mayhaps with the name.
>>
>>http://www.php.net/license/3_0.txt
>>    
>>
>
>That is what I thought too.  Originally PlPHP was stated as being
>released as GPL (which the author thought was used by PHP), but later
>corrected to be the BSD license.
>
>  
>


Thu, 25 Sep 2003 13:01:28 -0700
"Joshua D. Drake" <jd@commandprompt.com>
Re: PL contribution guidelines?
On Thu, 2003-09-25 at 13:26, Bruce Momjian wrote:
> scott.marlowe wrote:
> > On 25 Sep 2003, Robert Treat wrote:
> > 
> > > oh.. and i'm not forgetting plphp, but it has both licensing issues and
> > > isn't ready for prime time.
> > 
> > I thought there weren't any license issues, except mayhaps with the name.
> > 
> > http://www.php.net/license/3_0.txt
> 
> That is what I thought too.  Originally PlPHP was stated as being
> released as GPL (which the author thought was used by PHP), but later
> corrected to be the BSD license.
> 

The naming issue was the one that had stuck in my head. 

(Noting that it isn't BSD licensed, it's PHP licensed, which might be a
problem for some, but seems fairly BSD compatible).  

Robert Treat
-- 
Build A Brighter Lamp :: Linux Apache {middleware} PostgreSQL


25 Sep 2003 16:14:36 -0400
Robert Treat <xzilla@users.sourceforge.net>
Re: PL contribution guidelines?