Hi,

I didn't download the beta but compared the CVS checkouts and it appears
the ecpg directory is still the one from 7.2 not the one tagged
big_bison. Will this one be moved into the mainstream source? Else we
would be stuck with a non-compatible parser.

If I shall move it, please tell me, I'm just not doing it before talking
to you guys.

Michael
-- 
Michael Meskes
Michael@Fam-Meskes.De
Go SF 49ers! Go Rhein Fire!
Use Debian GNU/Linux! Use PostgreSQL!

Sun, 8 Sep 2002 10:20:11 +0200
Michael Meskes <meskes@postgresql.org>
7.3beta and ecpg
Michael Meskes <meskes@postgresql.org> writes:
> I didn't download the beta but compared the CVS checkouts and it appears
> the ecpg directory is still the one from 7.2 not the one tagged
> big_bison. Will this one be moved into the mainstream source?

Well, I think we can't do that until postgresql.org has a version of
bison installed that will compile it.  And I'm really hesitant to see us
depending on a beta version of bison.  Any word on a new bison official
release?

We still have a few weeks until the situation gets critical, but maybe
it is time to start thinking about a fallback plan...

			regards, tom lane

Mon, 09 Sep 2002 09:38:39 -0400
Tom Lane <tgl@sss.pgh.pa.us>
Re: 7.3beta and ecpg 
On Mon, Sep 09, 2002 at 09:38:39AM -0400, Tom Lane wrote:
> Well, I think we can't do that until postgresql.org has a version of
> bison installed that will compile it.  And I'm really hesitant to see us
> depending on a beta version of bison.  Any word on a new bison official
> release?

No news yet. They just said "as soon as possible". :-)

Michael
-- 
Michael Meskes
Michael@Fam-Meskes.De
Go SF 49ers! Go Rhein Fire!
Use Debian GNU/Linux! Use PostgreSQL!

Mon, 9 Sep 2002 15:46:16 +0200
Michael Meskes <meskes@postgresql.org>
Re: 7.3beta and ecpg
Tom Lane wrote:
> Michael Meskes <meskes@postgresql.org> writes:
> > I didn't download the beta but compared the CVS checkouts and it appears
> > the ecpg directory is still the one from 7.2 not the one tagged
> > big_bison. Will this one be moved into the mainstream source?
> 
> Well, I think we can't do that until postgresql.org has a version of
> bison installed that will compile it.  And I'm really hesitant to see us
> depending on a beta version of bison.  Any word on a new bison official
> release?
> 
> We still have a few weeks until the situation gets critical, but maybe
> it is time to start thinking about a fallback plan...

IMHO, our fallback is to ship based on the bison beta.

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

Mon, 9 Sep 2002 22:17:22 -0400 (EDT)
Bruce Momjian <pgman@candle.pha.pa.us>
Re: 7.3beta and ecpg

I think we should stop playing around with ecpg.  Let's get the beta
bison on postgresql.org and package the proper ecpg version for
7.3beta2.  If we don't, we are going to get zero testing for 7.3 final.

Marc?

We will not find out if there are problems with the bison beta until we
ship it as part of beta and I don't think we have to be scared of just
because it is beta.

---------------------------------------------------------------------------

Michael Meskes wrote:
> Hi,
> 
> I didn't download the beta but compared the CVS checkouts and it appears
> the ecpg directory is still the one from 7.2 not the one tagged
> big_bison. Will this one be moved into the mainstream source? Else we
> would be stuck with a non-compatible parser.
> 
> If I shall move it, please tell me, I'm just not doing it before talking
> to you guys.
> 
> Michael
> -- 
> Michael Meskes
> Michael@Fam-Meskes.De
> Go SF 49ers! Go Rhein Fire!
> Use Debian GNU/Linux! Use PostgreSQL!
> 
> ---------------------------(end of broadcast)---------------------------
> TIP 5: Have you checked our extensive FAQ?
> 
> http://www.postgresql.org/users-lounge/docs/faq.html
> 

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

Wed, 11 Sep 2002 00:10:26 -0400 (EDT)
Bruce Momjian <pgman@candle.pha.pa.us>
Re: 7.3beta and ecpg
Bruce Momjian <pgman@candle.pha.pa.us> writes:
> We will not find out if there are problems with the bison beta until we
> ship it as part of beta and I don't think we have to be scared of just
> because it is beta.

No?  If there are bugs in it, they will break the main SQL parser, not
only ecpg.  I am scared.

My idea of a reasonable fallback is to add prebuilt-with-the-beta-bison
output files to the ecpg directory, but not anyplace else.  That is
ugly, but the effects of any bison problems will be limited to ecpg.

I am also still wondering if we couldn't tweak the grammar to eliminate
states so that ecpg would build with a standard bison.  That would be a
win all 'round, but it requires effort that we maybe don't have to
spend.

			regards, tom lane

Wed, 11 Sep 2002 00:45:06 -0400
Tom Lane <tgl@sss.pgh.pa.us>
Re: 7.3beta and ecpg 
Tom Lane dijo: 

> Bruce Momjian <pgman@candle.pha.pa.us> writes:
> > We will not find out if there are problems with the bison beta until we
> > ship it as part of beta and I don't think we have to be scared of just
> > because it is beta.
> 
> No?  If there are bugs in it, they will break the main SQL parser, not
> only ecpg.  I am scared.

Just for the record: bison 1.49b reports lots of "invalid character"
when processing plpgsql's grammar.  However, the regression test passes.
This is Linux/i686.

$ make gram.c -C src/pl/plpgsql/src
make: Entering directory `/home/alvherre/CVS/pgsql/src/pl/plpgsql/src'
bison -y  gram.y 
gram.y:101.24: invalid character: `,'
gram.y:102.25: invalid character: `,'
gram.y:104.26: invalid character: `,'
gram.y:104.44: invalid character: `,'
gram.y:106.24: invalid character: `,'
gram.y:108.29: invalid character: `,'
gram.y:108.46: invalid character: `,'
gram.y:111.24: invalid character: `,'
gram.y:112.22: invalid character: `,'
gram.y:112.37: invalid character: `,'
gram.y:117.25: invalid character: `,'
gram.y:121.24: invalid character: `,'
gram.y:121.36: invalid character: `,'
gram.y:121.47: invalid character: `,'
gram.y:122.23: invalid character: `,'
gram.y:123.25: invalid character: `,'
gram.y:123.34: invalid character: `,'
gram.y:123.45: invalid character: `,'
gram.y:123.57: invalid character: `,'
gram.y:124.25: invalid character: `,'
gram.y:124.43: invalid character: `,'
gram.y:124.55: invalid character: `,'
gram.y:125.23: invalid character: `,'
gram.y:125.34: invalid character: `,'
gram.y:125.47: invalid character: `,'
gram.y:126.29: invalid character: `,'
gram.y:126.43: invalid character: `,'
gram.y:127.23: invalid character: `,'
gram.y:127.35: invalid character: `,'
gram.y:130.25: invalid character: `,'
gram.y:134.26: invalid character: `,'

-- 
Alvaro Herrera (<alvherre[a]atentus.com>)
"El conflicto es el camino real hacia la union"


Wed, 11 Sep 2002 00:56:59 -0400 (CLT)
Alvaro Herrera <alvherre@atentus.com>
Re: 7.3beta and ecpg 
Tom Lane wrote:
> Bruce Momjian <pgman@candle.pha.pa.us> writes:
> > We will not find out if there are problems with the bison beta until we
> > ship it as part of beta and I don't think we have to be scared of just
> > because it is beta.
> 
> No?  If there are bugs in it, they will break the main SQL parser, not
> only ecpg.  I am scared.
> 
> My idea of a reasonable fallback is to add prebuilt-with-the-beta-bison
> output files to the ecpg directory, but not anyplace else.  That is
> ugly, but the effects of any bison problems will be limited to ecpg.

Yes, I assumed we would use the new bison only for ecpg.

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

Wed, 11 Sep 2002 01:39:04 -0400 (EDT)
Bruce Momjian <pgman@candle.pha.pa.us>
Re: 7.3beta and ecpg
On Wed, Sep 11, 2002 at 12:45:06AM -0400, Tom Lane wrote:
> No?  If there are bugs in it, they will break the main SQL parser, not
> only ecpg.  I am scared.

Actually there is one more problem. The backend introduced the EXECUTE
command just recently. However, this clashes with the embedded SQL
EXECUTE command. Since both may be called just with EXECUTE <name>,
there is no way to distinguish them.

I have no idea if there's a standard about execution of a plan but
couldn't/shouldn't it be named "EXECUTE PLAN" instead of just "EXECUTE"?

> I am also still wondering if we couldn't tweak the grammar to eliminate
> states so that ecpg would build with a standard bison.  That would be a
> win all 'round, but it requires effort that we maybe don't have to
> spend.

Actually I think it will need quite some effort, in particular since I
stay away from the backend grammar as much as possible. Once I change
the backend compatible part of the grammar I either have to make the
same changes to the backends parser or ecpg will soon be unmaintainable.

Michael

-- 
Michael Meskes
Michael@Fam-Meskes.De
Go SF 49ers! Go Rhein Fire!
Use Debian GNU/Linux! Use PostgreSQL!

Wed, 11 Sep 2002 10:21:43 +0200
Michael Meskes <meskes@postgresql.org>
Re: 7.3beta and ecpg
On Wed, Sep 11, 2002 at 12:56:59AM -0400, Alvaro Herrera wrote:
> Just for the record: bison 1.49b reports lots of "invalid character"
> when processing plpgsql's grammar.  However, the regression test passes.
> This is Linux/i686.
> 
> $ make gram.c -C src/pl/plpgsql/src
> make: Entering directory `/home/alvherre/CVS/pgsql/src/pl/plpgsql/src'
> bison -y  gram.y 
> gram.y:101.24: invalid character: `,'

No big deal. Just remove all the ','. The new bison does not like them
as seperators anymore. We will have to make that change in the near
future anyway.

Michael
-- 
Michael Meskes
Michael@Fam-Meskes.De
Go SF 49ers! Go Rhein Fire!
Use Debian GNU/Linux! Use PostgreSQL!

Wed, 11 Sep 2002 10:29:29 +0200
Michael Meskes <meskes@postgresql.org>
Re: 7.3beta and ecpg