How about removing LINUX_ELF from all Makefile.in's?

Michael

--
Dr. Michael Meskes, Project-Manager    | topsystem Systemhaus GmbH
meskes@topsystem.de                    | Europark A2, Adenauerstr. 20
meskes@debian.org                      | 52146 Wuerselen
Go SF49ers! Go Rhein Fire!             | Tel: (+49) 2405/4670-44
Use Debian GNU/Linux!                  | Fax: (+49) 2405/4670-10

> -----Original Message-----
> From:	The Hermit Hacker [SMTP:scrappy@hub.org]
> Sent:	Tuesday, April 21, 1998 2:01 PM
> To:	Constantin Teodorescu
> Cc:	Thomas G. Lockhart; Bruce Momjian; PostgreSQL-development
> Subject:	Re: [HACKERS] Re: [QUESTIONS] Configuration problems in
> PostgreSQL 6.3.2 on Linux-ELF
> 
> On Tue, 21 Apr 1998, Constantin Teodorescu wrote:
> 
> > The Hermit Hacker wrote:
> > > 
> > > On Tue, 21 Apr 1998, Thomas G. Lockhart wrote:
> > > 
> > > > > Yes, I asked earlier why LINUX_ELF was not being defined, and
> no Linux
> > > > > user offered an answer.  Solutions, folks?  When our own
> pgaccess guy
> > > > > can't get libpgtcl to compile, we have a problem.  Do we need
> a patch?
> > > >
> > > > Uh, I think this is a question for Marc. What would he expect to
> be
> > > > defined for a platform? I'm pretty sure LINUX_ELF is supposed to
> be
> > > > replaces with, for example, "defined(_GCC_) && defined(linux)"
> or
> > > > something to that effect.
> > > >
> > > > Marc?
> > > 
> > >         I sort of ignored this one, being a Linux problem :(
> Constantin,
> > > what sort of error message(s) are you seeing and where?  I'll be
> more
> > > attentive this time, promise :)
> > 
> > So. I tried to compile PostgreSQL from scratch, as I usual do with
> every
> > version.
> > $ cd /usr/src/postgresql-6.3.2
> > $ cd src
> > $ ./configure
> > 
> > At this point, it shows a lot of configuration files and usually
> asked
> > me if {linux-elf} it's ok for me.
> > This time, he didn't do so. He start running and checking all sort
> of
> > programs and libraries and finally ended.
> 
> 	I removed the "question" phase, since there was already the
> --with-template= feature in configure...it will try to determine and
> use
> what it feels is appropriate based on a 'uname -s', which doesn't take
> into consideration different versions of an OS...
> 
> > Compiling all (gmake all) I noticed that in src/interfaces/libpgtcl
> > there isn't a libpgtcl.so library and in src/interfaces/libpq there
> > isn't libpq.so.
> > 
> > I succeeded getting that libraries editing by hand the Makefile in
> those
> > two directories and introducing a new line LINUX_ELF=true, then make
> > clean and make again. I copied libpgtcl.so and libpq.so in my /lib
> > directory and PgAccess work now. But for someone who did not know
> how to
> > do that, it could be quit embarassing.
> 
> 	Thoughts on how this might be fixed? :(
> 
> 

Tue, 21 Apr 1998 14:08:36 +0200
"Meskes, Michael" <meskes@topsystem.de>
RE: [HACKERS] Re: [QUESTIONS] Configuration problems in PostgreSQ
	L 6.3.2 on Linux-ELF
Meskes, Michael wrote:
> 
> How about removing LINUX_ELF from all Makefile.in's?
> 

Removing ??? Why removing it ???

You mean that removing the ifdef's containing LINUX_ELF and making 'by
default' the shared libraries all the time.

-- 
Constantin Teodorescu
FLEX Consulting Braila, ROMANIA

Tue, 21 Apr 1998 15:19:41 +0300
Constantin Teodorescu <teo@flex.ro>
Re: [HACKERS] Re: [QUESTIONS] Configuration problems in PostgreSQ L
	6.3.2 on Linux-ELF
On Tue, 21 Apr 1998, Constantin Teodorescu wrote:

> Meskes, Michael wrote:
> > 
> > How about removing LINUX_ELF from all Makefile.in's?
> > 
> 
> Removing ??? Why removing it ???
> 
> You mean that removing the ifdef's containing LINUX_ELF and making 'by
> default' the shared libraries all the time.

	There has to be a better method of determining this...doesn't
there?  Is there a test we can add to configure to auto-determine an 'ELF'
system?  Then just change the makefile so that it gets rid of the
LINUX_ELF "stuff" with something that configure sets?

	There, try that.  I have it so that if 'with-template' is
linux_elf, it sets LINUX_ELF to yes in both Makefile's...let me know if
that does it for you...



Tue, 21 Apr 1998 08:39:16 -0400 (EDT)
The Hermit Hacker <scrappy@hub.org>
Re: [HACKERS] Re: [QUESTIONS] Configuration problems in PostgreSQ L
	6.3.2 on Linux-ELF
The Hermit Hacker wrote:
> 
>         There has to be a better method of determining this...doesn't
> there?  Is there a test we can add to configure to auto-determine an 'ELF'
> system?  Then just change the makefile so that it gets rid of the
> LINUX_ELF "stuff" with something that configure sets?
> 
>         There, try that.  I have it so that if 'with-template' is
> linux_elf, it sets LINUX_ELF to yes in both Makefile's...let me know if
> that does it for you...

I have experimented right now.

I ran ./configure --with-template=linux-elf
It says that it will use template/linux-elf configuration file but I
looked into Makefiels in libpq and libpgtcl directories and none of them
contains LINUX_ELF=true

-- 
Constantin Teodorescu
FLEX Consulting Braila, ROMANIA

Tue, 21 Apr 1998 15:51:29 +0300
Constantin Teodorescu <teo@flex.ro>
Re: [HACKERS] Re: [QUESTIONS] Configuration problems in PostgreSQ L
	6.3.2 on Linux-ELF
On Tue, 21 Apr 1998, Constantin Teodorescu wrote:

> The Hermit Hacker wrote:
> > 
> >         There has to be a better method of determining this...doesn't
> > there?  Is there a test we can add to configure to auto-determine an 'ELF'
> > system?  Then just change the makefile so that it gets rid of the
> > LINUX_ELF "stuff" with something that configure sets?
> > 
> >         There, try that.  I have it so that if 'with-template' is
> > linux_elf, it sets LINUX_ELF to yes in both Makefile's...let me know if
> > that does it for you...
> 
> I have experimented right now.
> 
> I ran ./configure --with-template=linux-elf
> It says that it will use template/linux-elf configuration file but I
> looked into Makefiels in libpq and libpgtcl directories and none of them
> contains LINUX_ELF=true

	This is with just new CVSup'd code? *raised eyebrow* 

	There should be (interfaces/libpq/Makefile.in):

# Shared library stuff
shlib := 
install-shlib-dep :=
ifeq ($(PORTNAME), linux)
  LINUX_ELF=@LINUX_ELF@
  ifdef LINUX_ELF
    install-shlib-dep := install-shlib
    shlib := libpq.so.$(SO_MAJOR_VERSION).$(SO_MINOR_VERSION)
    LDFLAGS_SL = -shared -soname libpq.so.$(SO_MAJOR_VERSION)
    CFLAGS += $(CFLAGS_SL)
  endif
endif




Tue, 21 Apr 1998 08:52:48 -0400 (EDT)
The Hermit Hacker <scrappy@hub.org>
Re: [HACKERS] Re: [QUESTIONS] Configuration problems in PostgreSQ L
	6.3.2 on Linux-ELF
On Tue, 21 Apr 1998, The Hermit Hacker wrote:

> On Tue, 21 Apr 1998, Constantin Teodorescu wrote:
> 
> > Meskes, Michael wrote:
> > > 
> > > How about removing LINUX_ELF from all Makefile.in's?
> > > 
> > 
> > Removing ??? Why removing it ???
> > 
> > You mean that removing the ifdef's containing LINUX_ELF and making 'by
> > default' the shared libraries all the time.
> 
> 	There has to be a better method of determining this...doesn't
> there?  Is there a test we can add to configure to auto-determine an 'ELF'
> system?  Then just change the makefile so that it gets rid of the
> LINUX_ELF "stuff" with something that configure sets?

file /lib/libc$(DLSUFFIX) | grep ELF

Maarten

_____________________________________________________________________________
| TU Delft, The Netherlands, Faculty of Information Technology and Systems  |
|                   Department of Electrical Engineering                    |
|           Computer Architecture and Digital Technique section             |
|                          M.Boekhold@et.tudelft.nl                         |
-----------------------------------------------------------------------------


Tue, 21 Apr 1998 15:49:46 +0200 (MET DST)
Maarten Boekhold <maartenb@dutepp2.et.tudelft.nl>
Re: [HACKERS] Re: [QUESTIONS] Configuration problems in PostgreSQ L
	6.3.2 on Linux-ELF
> 	There has to be a better method of determining this...doesn't
> there?  Is there a test we can add to configure to auto-determine an 'ELF'
> system?  Then just change the makefile so that it gets rid of the
> LINUX_ELF "stuff" with something that configure sets?
> 
> 	There, try that.  I have it so that if 'with-template' is
> linux_elf, it sets LINUX_ELF to yes in both Makefile's...let me know if
> that does it for you...

I believe no one is running non-elf Linux.  Am I correct?

-- 
Bruce Momjian                          |  830 Blythe Avenue
maillist@candle.pha.pa.us              |  Drexel Hill, Pennsylvania 19026
  +  If your life is a hard drive,     |  (610) 353-9879(w)
  +  Christ can be your backup.        |  (610) 853-3000(h)

Tue, 21 Apr 1998 12:19:02 -0400 (EDT)
Bruce Momjian <maillist@candle.pha.pa.us>
Re: [HACKERS] Re: [QUESTIONS] Configuration problems in PostgreSQ L
	6.3.2 on Linux-ELF