Hello,

I grabbed last nights snapshot to come up with a diff for
pg_dump to generate COMMENT ON statements for user-defined
descriptions. However, I believe pg_dump is currently in a
broken state with respect to the dumping of indexes,
possibly related to the current work done with
INDEX_MAX_KEYS. Can anyone confirm this?

Thanks for any info,

Mike Mascari



Sat, 15 Jan 2000 17:17:21 -0500
Mike Mascari <mascarm@mascari.com>
INDEX_MAX_KEYS and pg_dump
> Hello,
> 
> I grabbed last nights snapshot to come up with a diff for
> pg_dump to generate COMMENT ON statements for user-defined
> descriptions. However, I believe pg_dump is currently in a
> broken state with respect to the dumping of indexes,
> possibly related to the current work done with
> INDEX_MAX_KEYS. Can anyone confirm this?

I just looked and I don't see any problems.

-- 
  Bruce Momjian                        |  http://www.op.net/~candle
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

Sat, 15 Jan 2000 23:05:30 -0500 (EST)
Bruce Momjian <pgman@candle.pha.pa.us>
Re: [HACKERS] INDEX_MAX_KEYS and pg_dump
>> descriptions. However, I believe pg_dump is currently in a
>> broken state with respect to the dumping of indexes,
>> possibly related to the current work done with
>> INDEX_MAX_KEYS. Can anyone confirm this?

> I just looked and I don't see any problems.

It was broken --- I committed fixes for it at about 11PM EST.

(The same problem as for func args --- it wasn't coping with
zero suppression in oidvectorout/int2vectorout.)

			regards, tom lane

Sat, 15 Jan 2000 23:51:59 -0500
Tom Lane <tgl@sss.pgh.pa.us>
Re: [HACKERS] INDEX_MAX_KEYS and pg_dump 
> >> descriptions. However, I believe pg_dump is currently in a
> >> broken state with respect to the dumping of indexes,
> >> possibly related to the current work done with
> >> INDEX_MAX_KEYS. Can anyone confirm this?
> 
> > I just looked and I don't see any problems.
> 
> It was broken --- I committed fixes for it at about 11PM EST.
> 
> (The same problem as for func args --- it wasn't coping with
> zero suppression in oidvectorout/int2vectorout.)

Thanks.  I missed that.

-- 
  Bruce Momjian                        |  http://www.op.net/~candle
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

Sun, 16 Jan 2000 00:40:21 -0500 (EST)
Bruce Momjian <pgman@candle.pha.pa.us>
Re: [HACKERS] INDEX_MAX_KEYS and pg_dump