
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

While playing around with trying to add foreign keys to the 
\d table display in psql, I noticed that tableinfo.triggers 
is not used once it is set. I think it is meant to go here:

 /* count triggers */
        if (!error && tableinfo.hasrules)

as:

 /* count triggers */
        if (!error && tableinfo.triggers)


Does that seem right? Since the archive links on the web page, 
and cvs appear to be down, I cannot check if this has been 
already fixed. Also, after all the hullabaloo about cvs, is there 
a definitive page for using it? This one, maybe?:

http://developer.postgresql.org/TODO/docs/cvs.html

Thanks,
Greg Sabino Mullane
greg@turnstep.com PGP Key: 0x14964AC8 200110060755

-----BEGIN PGP SIGNATURE-----
Comment: http://www.turnstep.com/pgp.html

iQA/AwUBO77yubybkGcUlkrIEQKYCQCfW9SRNR3WqeHQyDlZ5QT67I7y0MoAn2zg
hNqKkxYnDBU6h60TUXsaK3m0
=h46E
-----END PGP SIGNATURE-----


Sat, 6 Oct 2001 08:00:54 -0400 (EDT)
"Greg Sabino Mullane" <greg@turnstep.com>
psql not showing triggers
[ There is text before PGP section. ]
> 
-- Start of PGP signed section.
> While playing around with trying to add foreign keys to the 
> \d table display in psql, I noticed that tableinfo.triggers 
> is not used once it is set. I think it is meant to go here:
> 
>  /* count triggers */
>         if (!error && tableinfo.hasrules)
> 
> as:
> 
>  /* count triggers */
>         if (!error && tableinfo.triggers)
> 
> 
> Does that seem right? Since the archive links on the web page, 
> and cvs appear to be down, I cannot check if this has been 
> already fixed. Also, after all the hullabaloo about cvs, is there 
> a definitive page for using it? This one, maybe?:
> 
> http://developer.postgresql.org/TODO/docs/cvs.html

Good catch.  Your guess was right, and it hadn not been fixed.  Patch
attached and applied.

As far as CVS, that page should be accurate.  It was updated a few days
ago with the correct information.

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

Index: src/bin/psql/describe.c
===================================================================
RCS file: /cvsroot/pgsql/src/bin/psql/describe.c,v
retrieving revision 1.39
diff -c -r1.39 describe.c
*** src/bin/psql/describe.c	2001/08/21 16:36:05	1.39
--- src/bin/psql/describe.c	2001/10/06 14:39:07
***************
*** 793,799 ****
  		}
  
  		/* count triggers */
! 		if (!error && tableinfo.hasrules)
  		{
  			sprintf(buf,
  					"SELECT t.tgname\n"
--- 793,799 ----
  		}
  
  		/* count triggers */
! 		if (!error && tableinfo.triggers)
  		{
  			sprintf(buf,
  					"SELECT t.tgname\n"
Sat, 6 Oct 2001 10:40:46 -0400 (EDT)
Bruce Momjian <pgman@candle.pha.pa.us>
Re: psql not showing triggers