Bruce Momjian kirjutas K, 06.11.2002 kell 08:19:
> I have copies of Peer Direct's (Jan's company) port of PostgreSQL to
> Win32, and SRA's port to Win32, and permission to generate a merged
> patch that can be applied to 7.4.

Great!
 
> Now that 7.3 is almost complete, I am going to start work on that.  I
> will post patches that deal with specific portability issues, like
> fork/exec and path separator handling, and once reviewed, apply them to
> the main CVS tree for 7.4.

What C compiler will you be working with ?

I hope that at least MingW should be supported ?

-------------
Hannu


06 Nov 2002 06:57:35 +0200
Hannu Krosing <hannu@tm.ee>
Re: Win32 port
I have copies of Peer Direct's (Jan's company) port of PostgreSQL to
Win32, and SRA's port to Win32, and permission to generate a merged
patch that can be applied to 7.4.

Now that 7.3 is almost complete, I am going to start work on that.  I
will post patches that deal with specific portability issues, like
fork/exec and path separator handling, and once reviewed, apply them to
the main CVS tree for 7.4.

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

Wed, 6 Nov 2002 01:19:35 -0500 (EST)
Bruce Momjian <pgman@candle.pha.pa.us>
Win32 port
Bruce Momjian wrote:
> 
> I have copies of Peer Direct's (Jan's company) port of PostgreSQL to
> Win32, and SRA's port to Win32, and permission to generate a merged
> patch that can be applied to 7.4.
> 
> Now that 7.3 is almost complete, I am going to start work on that.  I
> will post patches that deal with specific portability issues, like
> fork/exec and path separator handling, and once reviewed, apply them to
> the main CVS tree for 7.4.

Whoo Hooo!

:-)

+ Justin

 
> --
>   Bruce Momjian                        |  http://candle.pha.pa.us
>   pgman@candle.pha.pa.us               |  (610) 359-1001
>   +  If your life is a hard drive,     |  13 Roberts Road
>   +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073
> 
> ---------------------------(end of broadcast)---------------------------
> TIP 3: if posting/reading through Usenet, please send an appropriate
> subscribe-nomail command to majordomo@postgresql.org so that your
> message can get through to the mailing list cleanly

-- 
"My grandfather once told me that there are two kinds of people: those
who work and those who take the credit. He told me to try to be in the
first group; there was less competition there."
   - Indira Gandhi

Wed, 06 Nov 2002 17:32:35 +1100
Justin Clift <justin@postgresql.org>
Re: Win32 port
On Wed, 2002-11-06 at 01:32, Justin Clift wrote:
> Bruce Momjian wrote:
> > 
> > I have copies of Peer Direct's (Jan's company) port of PostgreSQL to
> > Win32, and SRA's port to Win32, and permission to generate a merged
> > patch that can be applied to 7.4.
> > 
> > Now that 7.3 is almost complete, I am going to start work on that.  I
> > will post patches that deal with specific portability issues, like
> > fork/exec and path separator handling, and once reviewed, apply them to
> > the main CVS tree for 7.4.
> 
> Whoo Hooo!
> 
> :-)
> 
> + Justin

Couldn't agree with Justin more.  Even though I won't use it in
production, We have developers that use postgres on their windows
laptops for development and cygwin just doesn't cut it.


06 Nov 2002 01:53:08 -0500
"Matthew T. O'Connor" <matthew@zeut.net>
Re: Win32 port
Hannu Krosing wrote:
> Bruce Momjian kirjutas K, 06.11.2002 kell 08:19:
> > I have copies of Peer Direct's (Jan's company) port of PostgreSQL to
> > Win32, and SRA's port to Win32, and permission to generate a merged
> > patch that can be applied to 7.4.
> 
> Great!
>  
> > Now that 7.3 is almost complete, I am going to start work on that.  I
> > will post patches that deal with specific portability issues, like
> > fork/exec and path separator handling, and once reviewed, apply them to
> > the main CVS tree for 7.4.
> 
> What C compiler will you be working with ?
> 
> I hope that at least MingW should be supported ?

Actually, I will be doing all the coding on BSD/OS.  I am more merging
patches than actual coding, though.  This will guarantee that the
patches will not affect the Unix platforms.  I will need help from
others to check the various Win32 compilers.

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

Wed, 6 Nov 2002 09:55:50 -0500 (EST)
Bruce Momjian <pgman@candle.pha.pa.us>
Re: Win32 port
Bruce Momjian wrote:
> 
> Hannu Krosing wrote:
> > Bruce Momjian kirjutas K, 06.11.2002 kell 08:19:
> > > I have copies of Peer Direct's (Jan's company) port of PostgreSQL to
> > > Win32, and SRA's port to Win32, and permission to generate a merged
> > > patch that can be applied to 7.4.
> >
> > Great!
> >
> > > Now that 7.3 is almost complete, I am going to start work on that.  I
> > > will post patches that deal with specific portability issues, like
> > > fork/exec and path separator handling, and once reviewed, apply them to
> > > the main CVS tree for 7.4.
> >
> > What C compiler will you be working with ?
> >
> > I hope that at least MingW should be supported ?
> 
> Actually, I will be doing all the coding on BSD/OS.  I am more merging
> patches than actual coding, though.  This will guarantee that the
> patches will not affect the Unix platforms.  I will need help from
> others to check the various Win32 compilers.

I was wondering about that. How will you be able to verify that you got
a Win32 port that at least compiles, if you're merging two different
Win32 approaches into the code on BSD? I don't expect that to work at
all.

To Hannu: the Windows port we did here depends on MS VC++ features like
the ability to specify in the project to substitute header files. I
don't know much about MingW and if you can do things like that with it.
Our port is a real 100% pure Win32 one without any portability crap like
cygwin. I don't think that's a big problem, since the binary results of
a MS VC compile are redistributable AFAIK. And you'd need VC++ only if
you want to do backend development under Windows, and who want's that
(Katie for sure, but that's another story ;-P )


Jan

-- 

#======================================================================#
# It's easier to get forgiveness for being wrong than for being right. #
# Let's break this rule - forgive me.                                  #
#================================================== JanWieck@Yahoo.com #

Wed, 06 Nov 2002 10:45:53 -0500
Jan Wieck <JanWieck@Yahoo.com>
Re: Win32 port
Jan Wieck wrote:
> > Actually, I will be doing all the coding on BSD/OS.  I am more merging
> > patches than actual coding, though.  This will guarantee that the
> > patches will not affect the Unix platforms.  I will need help from
> > others to check the various Win32 compilers.
> 
> I was wondering about that. How will you be able to verify that you got
> a Win32 port that at least compiles, if you're merging two different
> Win32 approaches into the code on BSD? I don't expect that to work at
> all.

It doesn't have to work on Win32 day 1.  I will do all the work I can. 
I will also be buying a machine that can compile this but right now I
want to get most of it in.

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

Wed, 6 Nov 2002 10:50:24 -0500 (EST)
Bruce Momjian <pgman@candle.pha.pa.us>
Re: Win32 port
Bruce Momjian wrote:
> Jan Wieck wrote:
> 
>>>Actually, I will be doing all the coding on BSD/OS.  I am more merging
>>>patches than actual coding, though.  This will guarantee that the
>>>patches will not affect the Unix platforms.  I will need help from
>>>others to check the various Win32 compilers.
>>
>>I was wondering about that. How will you be able to verify that you got
>>a Win32 port that at least compiles, if you're merging two different
>>Win32 approaches into the code on BSD? I don't expect that to work at
>>all.
> 
> It doesn't have to work on Win32 day 1.  I will do all the work I can. 
> I will also be buying a machine that can compile this but right now I
> want to get most of it in.
> 

Bruce, I can compile on VC++ (VS .Net) for you. Let me know when you're ready 
with a patch.

Joe


Wed, 06 Nov 2002 08:16:21 -0800
Joe Conway <mail@joeconway.com>
Re: Win32 port
Joe Conway wrote:
> Bruce Momjian wrote:
> > Jan Wieck wrote:
> > 
> >>>Actually, I will be doing all the coding on BSD/OS.  I am more merging
> >>>patches than actual coding, though.  This will guarantee that the
> >>>patches will not affect the Unix platforms.  I will need help from
> >>>others to check the various Win32 compilers.
> >>
> >>I was wondering about that. How will you be able to verify that you got
> >>a Win32 port that at least compiles, if you're merging two different
> >>Win32 approaches into the code on BSD? I don't expect that to work at
> >>all.
> > 
> > It doesn't have to work on Win32 day 1.  I will do all the work I can. 
> > I will also be buying a machine that can compile this but right now I
> > want to get most of it in.
> > 
> 
> Bruce, I can compile on VC++ (VS .Net) for you. Let me know when you're ready 
> with a patch.

Thanks.  That will be a help.  In fact, just running it through after I
make few commits should fix things up.

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

Wed, 6 Nov 2002 11:27:06 -0500 (EST)
Bruce Momjian <pgman@candle.pha.pa.us>
Re: Win32 port
Jan Wieck writes:

> To Hannu: the Windows port we did here depends on MS VC++ features like
> the ability to specify in the project to substitute header files. I
> don't know much about MingW and if you can do things like that with it.

Before long someone will port the Windows port to MinGW, so we should
resist attempts to use compiler-specific features in the same way that we
tend not to use vendors specific features in other ports.

-- 
Peter Eisentraut   peter_e@gmx.net


Wed, 6 Nov 2002 18:24:16 +0100 (CET)
Peter Eisentraut <peter_e@gmx.net>
Re: Win32 port
Peter Eisentraut wrote:
> 
> Jan Wieck writes:
> 
> > To Hannu: the Windows port we did here depends on MS VC++ features like
> > the ability to specify in the project to substitute header files. I
> > don't know much about MingW and if you can do things like that with it.
> 
> Before long someone will port the Windows port to MinGW, so we should
> resist attempts to use compiler-specific features in the same way that we
> tend not to use vendors specific features in other ports.

Absolutely.  With the present push by over 30 governments of countries,
and other large institutions around the world for adopting Open Source
software in significant ways, we'd be kind of short-sighted to do things
in a way that mostly limits people to using M$ products.

:-)

Regards and best wishes,

Justin Clift


> --
> Peter Eisentraut   peter_e@gmx.net
> 
> ---------------------------(end of broadcast)---------------------------
> TIP 3: if posting/reading through Usenet, please send an appropriate
> subscribe-nomail command to majordomo@postgresql.org so that your
> message can get through to the mailing list cleanly

-- 
"My grandfather once told me that there are two kinds of people: those
who work and those who take the credit. He told me to try to be in the
first group; there was less competition there."
   - Indira Gandhi

Thu, 07 Nov 2002 04:29:08 +1100
Justin Clift <justin@postgresql.org>
Re: Win32 port
Peter Eisentraut wrote:
> Jan Wieck writes:
> 
> > To Hannu: the Windows port we did here depends on MS VC++ features like
> > the ability to specify in the project to substitute header files. I
> > don't know much about MingW and if you can do things like that with it.
> 
> Before long someone will port the Windows port to MinGW, so we should
> resist attempts to use compiler-specific features in the same way that we
> tend not to use vendors specific features in other ports.

Agreed.  I will make as clean a patch as possible.  I think it is
doable.

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

Wed, 6 Nov 2002 12:51:55 -0500 (EST)
Bruce Momjian <pgman@candle.pha.pa.us>
Re: Win32 port
Here is a list of patch areas that I will address with the Win32 port:

	fork/exec
	loop rename test
	handle \r in COPY
	copydir for cp -r
	backslash tests
	rmdir not recursive for rm -r
	shared memory could map to new address in exec child
	compatibility defines
	file path separators
	root directory
	rename atomicity
	spinlock changes
	str[r]chr
	timeval for psql
	DWORD in help.c
	initdb

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

Wed, 6 Nov 2002 12:54:19 -0500 (EST)
Bruce Momjian <pgman@candle.pha.pa.us>
Re: Win32 port
Bruce Momjian wrote:
> 
> Peter Eisentraut wrote:
> > Jan Wieck writes:
> >
> > > To Hannu: the Windows port we did here depends on MS VC++ features like
> > > the ability to specify in the project to substitute header files. I
> > > don't know much about MingW and if you can do things like that with it.
> >
> > Before long someone will port the Windows port to MinGW, so we should
> > resist attempts to use compiler-specific features in the same way that we
> > tend not to use vendors specific features in other ports.
> 
> Agreed.  I will make as clean a patch as possible.  I think it is
> doable.

The thing with this particular feature was not to touch almost every
source file in the whole tree. The headers to #include in a clean Win32
world are totally different from what you #include in Unix.


Jan

-- 

#======================================================================#
# It's easier to get forgiveness for being wrong than for being right. #
# Let's break this rule - forgive me.                                  #
#================================================== JanWieck@Yahoo.com #

Wed, 06 Nov 2002 14:04:41 -0500
Jan Wieck <JanWieck@Yahoo.com>
Re: Win32 port
Bruce Momjian wrote:
> 
> Here is a list of patch areas that I will address with the Win32 port:
> 
>         fork/exec
>         loop rename test
>         handle \r in COPY
>         copydir for cp -r
>         backslash tests
>         rmdir not recursive for rm -r
>         shared memory could map to new address in exec child

That's actually not done in the port yet. Thomas once overhauled the
hashtable code and changed it from using offsets to pointers. This code
is used for shared hashtables, so the mapping has to be done at a fixed
address for now.


Jan

-- 

#======================================================================#
# It's easier to get forgiveness for being wrong than for being right. #
# Let's break this rule - forgive me.                                  #
#================================================== JanWieck@Yahoo.com #

Wed, 06 Nov 2002 14:09:50 -0500
Jan Wieck <JanWieck@Yahoo.com>
Re: Win32 port
Jan Wieck wrote:
> Bruce Momjian wrote:
> > 
> > Here is a list of patch areas that I will address with the Win32 port:
> > 
> >         fork/exec
> >         loop rename test
> >         handle \r in COPY
> >         copydir for cp -r
> >         backslash tests
> >         rmdir not recursive for rm -r
> >         shared memory could map to new address in exec child
> 
> That's actually not done in the port yet. Thomas once overhauled the
> hashtable code and changed it from using offsets to pointers. This code
> is used for shared hashtables, so the mapping has to be done at a fixed
> address for now.

OK, can we guarantee that fixed mapping will happen?

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

Wed, 6 Nov 2002 14:17:21 -0500 (EST)
Bruce Momjian <pgman@candle.pha.pa.us>
Re: Win32 port
Jan Wieck wrote:
> Bruce Momjian wrote:
> > 
> > Peter Eisentraut wrote:
> > > Jan Wieck writes:
> > >
> > > > To Hannu: the Windows port we did here depends on MS VC++ features like
> > > > the ability to specify in the project to substitute header files. I
> > > > don't know much about MingW and if you can do things like that with it.
> > >
> > > Before long someone will port the Windows port to MinGW, so we should
> > > resist attempts to use compiler-specific features in the same way that we
> > > tend not to use vendors specific features in other ports.
> > 
> > Agreed.  I will make as clean a patch as possible.  I think it is
> > doable.
> 
> The thing with this particular feature was not to touch almost every
> source file in the whole tree. The headers to #include in a clean Win32
> world are totally different from what you #include in Unix.

OK, I am looking at the SRA patch and I don't see a huge number of
#include changes.  Can you give an example?  Also, isn't there a way to
do this in a more centralized way, perhaps in c.h?

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

Wed, 6 Nov 2002 14:20:28 -0500 (EST)
Bruce Momjian <pgman@candle.pha.pa.us>
Re: Win32 port
Steve Howe wrote:
> Hello Bruce,
> 
> Wednesday, November 6, 2002, 3:19:35 AM, you wrote:
> 
> BM> I have copies of Peer Direct's (Jan's company) port of PostgreSQL to
> BM> Win32, and SRA's port to Win32, and permission to generate a merged
> BM> patch that can be applied to 7.4.
> 
> BM> Now that 7.3 is almost complete, I am going to start work on that.  I
> BM> will post patches that deal with specific portability issues, like
> BM> fork/exec and path separator handling, and once reviewed, apply them to
> BM> the main CVS tree for 7.4.
> Just wondering, what compiler are they using ?
> Will it compile using Mingw ?

I think the two projects are using MS C++, but it would be nice for
Mingw to work too.

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

Wed, 6 Nov 2002 18:33:32 -0500 (EST)
Bruce Momjian <pgman@candle.pha.pa.us>
Re: Win32 port
Hello Bruce,

Wednesday, November 6, 2002, 3:19:35 AM, you wrote:

BM> I have copies of Peer Direct's (Jan's company) port of PostgreSQL to
BM> Win32, and SRA's port to Win32, and permission to generate a merged
BM> patch that can be applied to 7.4.

BM> Now that 7.3 is almost complete, I am going to start work on that.  I
BM> will post patches that deal with specific portability issues, like
BM> fork/exec and path separator handling, and once reviewed, apply them to
BM> the main CVS tree for 7.4.
Just wondering, what compiler are they using ?
Will it compile using Mingw ?

------------- 
Best regards,
 Steve Howe                           mailto:howe@carcass.dhs.org


Wed, 6 Nov 2002 21:32:28 -0300
Steve Howe <howe@carcass.dhs.org>
Re: Win32 port
Hello Bruce,

Wednesday, November 6, 2002, 8:33:32 PM, you wrote:

BM> Steve Howe wrote:
>> Hello Bruce,
>> 
>> Wednesday, November 6, 2002, 3:19:35 AM, you wrote:
>> 
>> BM> I have copies of Peer Direct's (Jan's company) port of PostgreSQL to
>> BM> Win32, and SRA's port to Win32, and permission to generate a merged
>> BM> patch that can be applied to 7.4.
>> 
>> BM> Now that 7.3 is almost complete, I am going to start work on that.  I
>> BM> will post patches that deal with specific portability issues, like
>> BM> fork/exec and path separator handling, and once reviewed, apply them to
>> BM> the main CVS tree for 7.4.
>> Just wondering, what compiler are they using ?
>> Will it compile using Mingw ?

BM> I think the two projects are using MS C++, but it would be nice for
BM> Mingw to work too.
Or even (free) Borland C++ compiler, but I would be glad just to see
it working with Mingw...
It just makes no sense a free project like
PostgreSQL to be compiled only with a commercial compiler.

-------------
Best regards,
 Steve Howe                           mailto:howe@carcass.dhs.org


Wed, 6 Nov 2002 21:37:05 -0300
Steve Howe <howe@carcass.dhs.org>
Re: Win32 port