On OpenBSD 3.4, the diff options -b and -w have the interesting feature
(actually listed as a bug) that they ignore whitespace for preparing the
diff, but the exit status will be 1 nonetheless, if the files are at all
different.  This leads to several failures in the current regression
tests, because the expected files are off by some whitespace.

It appears we must not use the options for determining whether the test
failed, only for creating the diff output.  Or does anyone have a better
idea?

-- 
Peter Eisentraut   peter_e@gmx.net


Sat, 1 Nov 2003 04:06:00 +0100 (CET)
Peter Eisentraut <peter_e@gmx.net>
Problems with whitespace-ignoring diff options
Peter Eisentraut <peter_e@gmx.net> writes:
> It appears we must not use the options for determining whether the test
> failed, only for creating the diff output.  Or does anyone have a better
> idea?

AFAIK, there is no reason to ignore whitespace in determining whether a
test succeeded.  However, if a test fails, it is quite likely that a
whitespace-sensitive diff will produce many lines of uninteresting diff,
because of psql's habit of justifying column output --- any difference
in the data value length where the actual difference occurs would impact
all the rest of the query output, even though it's really "the same".

So if you can implement the above behavior easily, go for it.

Keep in mind though that a reported failure accompanied by *no* visible
diff would be highly annoying ;-).  Can we arrange to produce a
whitespace-sensitive diff output if the whitespace-insensitive kind
shows nothing?

			regards, tom lane

Fri, 31 Oct 2003 23:51:57 -0500
Tom Lane <tgl@sss.pgh.pa.us>
Re: Problems with whitespace-ignoring diff options 

Tom Lane <tgl@sss.pgh.pa.us> writes:

> However, if a test fails, it is quite likely that a whitespace-sensitive
> diff will produce many lines of uninteresting diff, because of psql's habit
> of justifying column output

Perhaps the regression tests should just do \pset format unaligned ?

-- 
greg


01 Nov 2003 11:11:58 -0500
Greg Stark <gsstark@mit.edu>
Re: Problems with whitespace-ignoring diff options