Rod Taylor wrote:
-- Start of PGP signed section.
> On Mon, 2004-03-08 at 15:46, Bruce Momjian wrote:
> > This doesn't look good.  If we throw a WARNING, why do we not insert
> > anything into pg_description.  Seems we should throw an error, or do the
> > insert with a warning.
> 
> It used to be an error, but that had problems with pg_restore (it
> doesn't like errors). When it was changed to a warning, I think it was
> still reasonable to leave it out of pg_description in anticipation of
> the syntax being changed to:
> 
> COMMENT ON DATABASE IS 'Hello';
> 
> The above always applies the comment to the current database.

OK, I added a comment to the C code:

        ereport(WARNING,    /* throw just a warning so pg_restore doesn't fail */

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

Mon, 8 Mar 2004 16:36:14 -0500 (EST)
Bruce Momjian <pgman@candle.pha.pa.us>
Re: COMMENT ON [GROUP/USER]