This resultmap patch and regression test result file allow the join 
regression test to succeed under Mingw.

cheers

andrew
Mon, 10 May 2004 13:15:57 -0400
Andrew Dunstan <andrew@dunslane.net>
patch for different join result order on regression test for win32

Agreed it is time to get this regression test working on MinGW.  I
suggest we add ORDER BY to the needed queries.  Tom as hoping to come up
with a better solution, but at this point I think we should just add the
ORDER BY rather than adding a different output file.

Comments?

---------------------------------------------------------------------------

Andrew Dunstan wrote:
> 
> This resultmap patch and regression test result file allow the join 
> regression test to succeed under Mingw.
> 
> cheers
> 
> andrew


-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

Mon, 10 May 2004 13:21:15 -0400 (EDT)
Bruce Momjian <pgman@candle.pha.pa.us>
Re: [PATCHES] patch for different join result order on regression
 test
Andrew Dunstan <andrew@dunslane.net> writes:
> This resultmap patch and regression test result file allow the join 
> regression test to succeed under Mingw.

This is the hard way to do it.  Instead of using the resultmap
mechanism, pretend the difference is a locale difference, and
just add the file as "join_1.out" (I think that's the right naming
convention, but check it).  I don't think we really need to tie this
to a specific OS, which is what the resultmap mechanism is intended
to do.  IIRC people have gotten similar differences on other OSes.

			regards, tom lane

Mon, 10 May 2004 15:20:56 -0400
Tom Lane <tgl@sss.pgh.pa.us>
Re: patch for different join result order on regression test for
	win32
Bruce Momjian <pgman@candle.pha.pa.us> writes:
> Agreed it is time to get this regression test working on MinGW.  I
> suggest we add ORDER BY to the needed queries.

Please do not do that.  This is a join test, not an ORDER BY test,
and I don't want it ignoring unordered join methods.

			regards, tom lane

Mon, 10 May 2004 15:21:57 -0400
Tom Lane <tgl@sss.pgh.pa.us>
Re: [PATCHES] patch for different join result order on regression
	test
Tom Lane wrote:
> Bruce Momjian <pgman@candle.pha.pa.us> writes:
> > Agreed it is time to get this regression test working on MinGW.  I
> > suggest we add ORDER BY to the needed queries.
> 
> Please do not do that.  This is a join test, not an ORDER BY test,
> and I don't want it ignoring unordered join methods.

Ah, OK.

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

Mon, 10 May 2004 15:23:40 -0400 (EDT)
Bruce Momjian <pgman@candle.pha.pa.us>
Re: [PATCHES] patch for different join result order on regression
Tom Lane wrote:

>Andrew Dunstan <andrew@dunslane.net> writes:
>  
>
>>This resultmap patch and regression test result file allow the join 
>>regression test to succeed under Mingw.
>>    
>>
>
>This is the hard way to do it.  Instead of using the resultmap
>mechanism, pretend the difference is a locale difference, and
>just add the file as "join_1.out" (I think that's the right naming
>convention, but check it).  I don't think we really need to tie this
>to a specific OS, which is what the resultmap mechanism is intended
>to do.  IIRC people have gotten similar differences on other OSes.
>
>  
>

I wondered about that.

Sounds good to me.

You are correct that ${EXPECTED}_[0-9].out is the syntax for alternative 
result files. So here "join_1.out" would be fine.

cheers

andrew

Mon, 10 May 2004 16:14:47 -0400
Andrew Dunstan <andrew@dunslane.net>
Re: patch for different join result order on regression
Andrew Dunstan wrote:

>
> This resultmap patch and regression test result file allow the join 
> regression test to succeed under Mingw.
>
>


Could someone please add the join result I posted in the original of 
this email (on May 10th) as src/test/regress/expected/join_1.out?

This is the one test I am failing on Win32.

Fixup patch for pg_regress.sh will be sent shortly, allowing "make 
check" to run cleanly.

cheers

andrew



Fri, 28 May 2004 15:31:14 -0400
Andrew Dunstan <andrew@dunslane.net>
Re: patch for different join result order on regression test for

Done.

---------------------------------------------------------------------------

Andrew Dunstan wrote:
> Andrew Dunstan wrote:
> 
> >
> > This resultmap patch and regression test result file allow the join 
> > regression test to succeed under Mingw.
> >
> >
> 
> 
> Could someone please add the join result I posted in the original of 
> this email (on May 10th) as src/test/regress/expected/join_1.out?
> 
> This is the one test I am failing on Win32.
> 
> Fixup patch for pg_regress.sh will be sent shortly, allowing "make 
> check" to run cleanly.
> 
> cheers
> 
> andrew
> 
> 
> 
> ---------------------------(end of broadcast)---------------------------
> TIP 3: if posting/reading through Usenet, please send an appropriate
>       subscribe-nomail command to majordomo@postgresql.org so that your
>       message can get through to the mailing list cleanly
> 

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

Mon, 12 Jul 2004 16:11:53 -0400 (EDT)
Bruce Momjian <pgman@candle.pha.pa.us>
Re: patch for different join result order on regression test