CVSROOT:	/home/projects/pgsql/cvsroot
Module name:	pgsql
Changes by:	scrappy@hub.org	01/09/07 11:01:45

Modified files:
	src/backend/utils/mb: encnames.c 

Log message:
	Remove variable length macros used in debugging, per Karel.


Fri, 7 Sep 2001 11:01:46 -0400 (EDT)
"Marc G. Fournier" <scrappy@hub.org>
pgsql/src/backend/utils/mb encnames.c
* Marc G. Fournier <scrappy@hub.org> [010907 10:06]:
> CVSROOT:	/home/projects/pgsql/cvsroot
> Module name:	pgsql
> Changes by:	scrappy@hub.org	01/09/07 11:01:45
> 
> Modified files:
> 	src/backend/utils/mb: encnames.c 
> 
> Log message:
> 	Remove variable length macros used in debugging, per Karel.

Now we die differently:

    -e "s,@configure@,$configure,g" \
    -e 's,@version@,7.2devel,g' \
  pg_config.sh >pg_config
chmod a+x pg_config
gmake[3]: Leaving directory `/home/ler/pg-dev/pgsql/src/bin/pg_config'
gmake[3]: Entering directory `/home/ler/pg-dev/pgsql/src/bin/pg_encoding'
gmake -C ../../../src/interfaces/libpq all
gmake[4]: Entering directory `/home/ler/pg-dev/pgsql/src/interfaces/libpq'
gmake[4]: Nothing to be done for `all'.
gmake[4]: Leaving directory `/home/ler/pg-dev/pgsql/src/interfaces/libpq'
cc -O -K inline -g -I../../../src/include -I/usr/local/include  -c -o pg_encoding.o pg_encoding.c
UX:cc: WARNING: debugging and optimization mutually exclusive; -O disabled
cc -O -K inline -g pg_encoding.o -L../../../src/interfaces/libpq -lpq -L/usr/local/lib -Wl,-R/usr/local/pgsql/lib -lz -lresolv -lgen -lld -lnsl -lsocket -ldl -lm -lreadline -ltermcap  -o pg_encoding
UX:cc: WARNING: debugging and optimization mutually exclusive; -O disabled
Undefined			first referenced
symbol  			    in file
pg_valid_server_encoding            pg_encoding.o
UX:ld: ERROR: Symbol referencing errors. No output written to pg_encoding
gmake[3]: *** [pg_encoding] Error 1
gmake[3]: Leaving directory `/home/ler/pg-dev/pgsql/src/bin/pg_encoding'
gmake[2]: *** [all] Error 2
gmake[2]: Leaving directory `/home/ler/pg-dev/pgsql/src/bin'
gmake[1]: *** [all] Error 2
gmake[1]: Leaving directory `/home/ler/pg-dev/pgsql/src'
gmake: *** [all] Error 2

configure input: 

CC=cc CXX=CC ./configure  --prefix=/usr/local/pgsql --enable-syslog \
	--with-CXX --with-perl --enable-multibyte --enable-cassert \
	--with-includes=/usr/local/include --with-libs=/usr/local/lib \
	--enable-debug \
	--with-tcl --with-tclconfig=/usr/local/lib \
	--with-tkconfig=/usr/local/lib  --enable-locale --with-python
> 
> 
> ---------------------------(end of broadcast)---------------------------
> TIP 4: Don't 'kill -9' the postmaster

-- 
Larry Rosenman                     http://www.lerctr.org/~ler
Phone: +1 972-414-9812                 E-Mail: ler@lerctr.org
US Mail: 1905 Steamboat Springs Drive, Garland, TX 75044-6749

Fri, 7 Sep 2001 10:18:45 -0500
Larry Rosenman <ler@lerctr.org>
Re: [COMMITTERS] pgsql/src/backend/utils/mb encnames.c

I am seeing no failure here with enable-multibyte and enable-locale.
Can you update cvs, do a make clean, and try again.

> * Marc G. Fournier <scrappy@hub.org> [010907 10:06]:
> > CVSROOT:	/home/projects/pgsql/cvsroot
> > Module name:	pgsql
> > Changes by:	scrappy@hub.org	01/09/07 11:01:45
> > 
> > Modified files:
> > 	src/backend/utils/mb: encnames.c 
> > 
> > Log message:
> > 	Remove variable length macros used in debugging, per Karel.
> 
> Now we die differently:
> 
>     -e "s,@configure@,$configure,g" \
>     -e 's,@version@,7.2devel,g' \
>   pg_config.sh >pg_config
> chmod a+x pg_config
> gmake[3]: Leaving directory `/home/ler/pg-dev/pgsql/src/bin/pg_config'
> gmake[3]: Entering directory `/home/ler/pg-dev/pgsql/src/bin/pg_encoding'
> gmake -C ../../../src/interfaces/libpq all
> gmake[4]: Entering directory `/home/ler/pg-dev/pgsql/src/interfaces/libpq'
> gmake[4]: Nothing to be done for `all'.
> gmake[4]: Leaving directory `/home/ler/pg-dev/pgsql/src/interfaces/libpq'
> cc -O -K inline -g -I../../../src/include -I/usr/local/include  -c -o pg_encoding.o pg_encoding.c
> UX:cc: WARNING: debugging and optimization mutually exclusive; -O disabled
> cc -O -K inline -g pg_encoding.o -L../../../src/interfaces/libpq -lpq -L/usr/local/lib -Wl,-R/usr/local/pgsql/lib -lz -lresolv -lgen -lld -lnsl -lsocket -ldl -lm -lreadline -ltermcap  -o pg_encoding
> UX:cc: WARNING: debugging and optimization mutually exclusive; -O disabled
> Undefined			first referenced
> symbol  			    in file
> pg_valid_server_encoding            pg_encoding.o
> UX:ld: ERROR: Symbol referencing errors. No output written to pg_encoding
> gmake[3]: *** [pg_encoding] Error 1
> gmake[3]: Leaving directory `/home/ler/pg-dev/pgsql/src/bin/pg_encoding'
> gmake[2]: *** [all] Error 2
> gmake[2]: Leaving directory `/home/ler/pg-dev/pgsql/src/bin'
> gmake[1]: *** [all] Error 2
> gmake[1]: Leaving directory `/home/ler/pg-dev/pgsql/src'
> gmake: *** [all] Error 2
> 
> configure input: 
> 
> CC=cc CXX=CC ./configure  --prefix=/usr/local/pgsql --enable-syslog \
> 	--with-CXX --with-perl --enable-multibyte --enable-cassert \
> 	--with-includes=/usr/local/include --with-libs=/usr/local/lib \
> 	--enable-debug \
> 	--with-tcl --with-tclconfig=/usr/local/lib \
> 	--with-tkconfig=/usr/local/lib  --enable-locale --with-python
> > 
> > 
> > ---------------------------(end of broadcast)---------------------------
> > TIP 4: Don't 'kill -9' the postmaster
> 
> -- 
> Larry Rosenman                     http://www.lerctr.org/~ler
> Phone: +1 972-414-9812                 E-Mail: ler@lerctr.org
> US Mail: 1905 Steamboat Springs Drive, Garland, TX 75044-6749
> 

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

Fri, 7 Sep 2001 12:12:19 -0400 (EDT)
Bruce Momjian <pgman@candle.pha.pa.us>
Re: [COMMITTERS] pgsql/src/backend/utils/mb encnames.c
Still Fails here....

LER

* Bruce Momjian <pgman@candle.pha.pa.us> [010907 11:27]:
> 
> I am seeing no failure here with enable-multibyte and enable-locale.
> Can you update cvs, do a make clean, and try again.
> 
> > * Marc G. Fournier <scrappy@hub.org> [010907 10:06]:
> > > CVSROOT:	/home/projects/pgsql/cvsroot
> > > Module name:	pgsql
> > > Changes by:	scrappy@hub.org	01/09/07 11:01:45
> > > 
> > > Modified files:
> > > 	src/backend/utils/mb: encnames.c 
> > > 
> > > Log message:
> > > 	Remove variable length macros used in debugging, per Karel.
> > 
> > Now we die differently:
> > 
> >     -e "s,@configure@,$configure,g" \
> >     -e 's,@version@,7.2devel,g' \
> >   pg_config.sh >pg_config
> > chmod a+x pg_config
> > gmake[3]: Leaving directory `/home/ler/pg-dev/pgsql/src/bin/pg_config'
> > gmake[3]: Entering directory `/home/ler/pg-dev/pgsql/src/bin/pg_encoding'
> > gmake -C ../../../src/interfaces/libpq all
> > gmake[4]: Entering directory `/home/ler/pg-dev/pgsql/src/interfaces/libpq'
> > gmake[4]: Nothing to be done for `all'.
> > gmake[4]: Leaving directory `/home/ler/pg-dev/pgsql/src/interfaces/libpq'
> > cc -O -K inline -g -I../../../src/include -I/usr/local/include  -c -o pg_encoding.o pg_encoding.c
> > UX:cc: WARNING: debugging and optimization mutually exclusive; -O disabled
> > cc -O -K inline -g pg_encoding.o -L../../../src/interfaces/libpq -lpq -L/usr/local/lib -Wl,-R/usr/local/pgsql/lib -lz -lresolv -lgen -lld -lnsl -lsocket -ldl -lm -lreadline -ltermcap  -o pg_encoding
> > UX:cc: WARNING: debugging and optimization mutually exclusive; -O disabled
> > Undefined			first referenced
> > symbol  			    in file
> > pg_valid_server_encoding            pg_encoding.o
> > UX:ld: ERROR: Symbol referencing errors. No output written to pg_encoding
> > gmake[3]: *** [pg_encoding] Error 1
> > gmake[3]: Leaving directory `/home/ler/pg-dev/pgsql/src/bin/pg_encoding'
> > gmake[2]: *** [all] Error 2
> > gmake[2]: Leaving directory `/home/ler/pg-dev/pgsql/src/bin'
> > gmake[1]: *** [all] Error 2
> > gmake[1]: Leaving directory `/home/ler/pg-dev/pgsql/src'
> > gmake: *** [all] Error 2
> > 
> > configure input: 
> > 
> > CC=cc CXX=CC ./configure  --prefix=/usr/local/pgsql --enable-syslog \
> > 	--with-CXX --with-perl --enable-multibyte --enable-cassert \
> > 	--with-includes=/usr/local/include --with-libs=/usr/local/lib \
> > 	--enable-debug \
> > 	--with-tcl --with-tclconfig=/usr/local/lib \
> > 	--with-tkconfig=/usr/local/lib  --enable-locale --with-python
> > > 
> > > 
> > > ---------------------------(end of broadcast)---------------------------
> > > TIP 4: Don't 'kill -9' the postmaster
> > 
> > -- 
> > Larry Rosenman                     http://www.lerctr.org/~ler
> > Phone: +1 972-414-9812                 E-Mail: ler@lerctr.org
> > US Mail: 1905 Steamboat Springs Drive, Garland, TX 75044-6749
> > 
> 
> -- 
>   Bruce Momjian                        |  http://candle.pha.pa.us
>   pgman@candle.pha.pa.us               |  (610) 853-3000
>   +  If your life is a hard drive,     |  830 Blythe Avenue
>   +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026
> 
> ---------------------------(end of broadcast)---------------------------
> TIP 1: subscribe and unsubscribe commands go to majordomo@postgresql.org

-- 
Larry Rosenman                     http://www.lerctr.org/~ler
Phone: +1 972-414-9812                 E-Mail: ler@lerctr.org
US Mail: 1905 Steamboat Springs Drive, Garland, TX 75044-6749

Fri, 7 Sep 2001 11:35:12 -0500
Larry Rosenman <ler@lerctr.org>
Re: [COMMITTERS] pgsql/src/backend/utils/mb encnames.c
Bruce Momjian <pgman@candle.pha.pa.us> writes:
> I am seeing no failure here with enable-multibyte and enable-locale.
> Can you update cvs, do a make clean, and try again.

pg_encoding builds okay here.

I think Marc said something about having recently changed the anon-CVS
server to be a mirror of the master CVS, rather than the same server.
This would mean that Larry might not be looking at the same sources
you are.  Maybe the mirror update interval needs to be tightened.

			regards, tom lane

Fri, 07 Sep 2001 13:01:10 -0400
Tom Lane <tgl@sss.pgh.pa.us>
Re: [BUGS] pgsql/src/backend/utils/mb encnames.c 
> Bruce Momjian <pgman@candle.pha.pa.us> writes:
> > I am seeing no failure here with enable-multibyte and enable-locale.
> > Can you update cvs, do a make clean, and try again.
> 
> pg_encoding builds okay here.
> 
> I think Marc said something about having recently changed the anon-CVS
> server to be a mirror of the master CVS, rather than the same server.
> This would mean that Larry might not be looking at the same sources
> you are.  Maybe the mirror update interval needs to be tightened.

I am on the phone with him now. I think the problem is that he is
linking pg_encoding binary against an old libpq.  He is researching why
this is happening.

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

Fri, 7 Sep 2001 13:02:56 -0400 (EDT)
Bruce Momjian <pgman@candle.pha.pa.us>
Re: [BUGS] pgsql/src/backend/utils/mb encnames.c
> Bruce Momjian <pgman@candle.pha.pa.us> writes:
> > I am seeing no failure here with enable-multibyte and enable-locale.
> > Can you update cvs, do a make clean, and try again.
> 
> pg_encoding builds okay here.
> 
> I think Marc said something about having recently changed the anon-CVS
> server to be a mirror of the master CVS, rather than the same server.
> This would mean that Larry might not be looking at the same sources
> you are.  Maybe the mirror update interval needs to be tightened.

OK, looks like an OS bug.  In the compile of pg_encoding:

gcc -O2 -pipe -m486 -Wall -Wmissing-prototypes -Wmissing-declarations -g
-Wall -O1 -Wmissing-prototypes -Wmissing-declarations
-I../../../src/include -I/usr/local/include/readline
-I/usr/contrib/include  -c -o pg_encoding.o pg_encoding.c
gcc -O2 -pipe -m486 -Wall -Wmissing-prototypes -Wmissing-declarations -g
-Wall -O1 -Wmissing-prototypes -Wmissing-declarations pg_encoding.o
-L../../../src/interfaces/libpq -lpq -L/usr/local/lib -L/usr/contrib/lib
-Wl,-rpath,/usr/local/pgsql/lib -g -Wall -O1 -Wmissing-prototypes
-Wmissing-declarations -lz -lcompat -lipc -ldl -lm -lutil -lreadline
-ltermcap  -o pg_encoding

The line:

	-L../../../src/interfaces/libpq -lpq

does not seem to search for libpq in the -L first, and probably checks
LD_RUN_PATH or something like that.  No idea but it seems only his OS is
affected.  Installing a new libpq in his install directory fixed it.

One possible cause would be to use a symlink to get to pgsql/src.  In
that case, ../../.. puts you in the symlink directory and not to the top
of the cvs tree.  That is not an issue for him, but a possible cause of
failure.

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

Fri, 7 Sep 2001 13:11:23 -0400 (EDT)
Bruce Momjian <pgman@candle.pha.pa.us>
Re: [BUGS] pgsql/src/backend/utils/mb encnames.c