Hello Bruce, 

I've just submitted a patch to the patches list which
implements Oracle's COMMENT statement. It will 
insert/update/delete the appropriate OID for the 
table or column targeted for the comment. It should
apply cleanly against current. If it passes your
scrutiny, I was wondering a couple of things:

1. Might it be possible for psql 
   (a.k.a Peter Eisentraut) to display the comments
   associated with tables, views, and columns in 
   its \d output? Or perhaps another \ command?

2. Should I write up SGML for it (as well as for 
   TRUNCATE TABLE)?

3. Should I expand it beyond ORACLE's syntax to 
   include functions, types, triggers, rules, etc.?

On the TODO list its listed as:

Allow pg_descriptions when creating types, tables,
columns, and functions 

Anyways, 

Hope its worth something,

Mike Mascari
(mascarim@yahoo.com)



=====

__________________________________________________
Do You Yahoo!?
Bid and sell for free at http://auctions.yahoo.com

Thu, 14 Oct 1999 18:31:34 -0700 (PDT)
Mike Mascari <mascarim@yahoo.com>
ORACLE COMMENT statement
> Hello Bruce, 
> 
> I've just submitted a patch to the patches list which
> implements Oracle's COMMENT statement. It will 
> insert/update/delete the appropriate OID for the 
> table or column targeted for the comment. It should
> apply cleanly against current. If it passes your
> scrutiny, I was wondering a couple of things:
> 
> 1. Might it be possible for psql 
>    (a.k.a Peter Eisentraut) to display the comments
>    associated with tables, views, and columns in 
>    its \d output? Or perhaps another \ command?

Sure.  \dd does that already.

> 
> 2. Should I write up SGML for it (as well as for 
>    TRUNCATE TABLE)?

I did that for Truncate.  You can see it in the docs.  If you want to
write on on this, that would be good.  It seems more complex.

> 
> 3. Should I expand it beyond ORACLE's syntax to 
>    include functions, types, triggers, rules, etc.?

Sure, why not.  \dd already handles it.

> 
> On the TODO list its listed as:
> 
> Allow pg_descriptions when creating types, tables,
> columns, and functions 

Yep.  Removed the 'table' entry, and marked it as done.


-- 
  Bruce Momjian                        |  http://www.op.net/~candle
  maillist@candle.pha.pa.us            |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

Thu, 14 Oct 1999 21:54:16 -0400 (EDT)
Bruce Momjian <maillist@candle.pha.pa.us>
Re: ORACLE COMMENT statement
> 2. Should I write up SGML for it (as well as for
>    TRUNCATE TABLE)?

Yes (though TRUNCATE TABLE has something already in
ref/truncate.sgml).

                    - Thomas

-- 
Thomas Lockhart				lockhart@alumni.caltech.edu
South Pasadena, California

Fri, 15 Oct 1999 05:49:16 +0000
Thomas Lockhart <lockhart@alumni.caltech.edu>
Re: [HACKERS] ORACLE COMMENT statement
On Oct 14, Mike Mascari mentioned:

> 1. Might it be possible for psql 
>    (a.k.a Peter Eisentraut) to display the comments
>    associated with tables, views, and columns in 
>    its \d output? Or perhaps another \ command?

I was sort of sitting in the holes for the below TODO to get finished. I
was thinking about the \d output as well, perhaps one could switch it on
and off somewhere. I'll see what I can do.

> Allow pg_descriptions when creating types, tables,
> columns, and functions 

	-Peter

-- 
Peter Eisentraut                  Sernanders vaeg 10:115
peter_e@gmx.net                   75262 Uppsala
http://yi.org/peter-e/            Sweden



Sat, 16 Oct 1999 02:50:16 +0200 (CEST)
Peter Eisentraut <peter_e@gmx.net>
Re: ORACLE COMMENT statement
I have another question regarding this: It seems that you can attach a
description (or comment, as it is) to any oid. (Not with this command, but
in general). Is this restricted to system oids (like below 16000 or
whatever it was)? Otherwise comments on any user tuple could be created.
Perhaps this should be explicitly prevented or allowed. In the latter case
perhaps the comment statement could be tweaked. Not sure. Just wondering.

	-Peter


On Oct 14, Mike Mascari mentioned:

> Hello Bruce, 
> 
> I've just submitted a patch to the patches list which
> implements Oracle's COMMENT statement. It will 
> insert/update/delete the appropriate OID for the 
> table or column targeted for the comment. It should
> apply cleanly against current. If it passes your
> scrutiny, I was wondering a couple of things:
> 
> 1. Might it be possible for psql 
>    (a.k.a Peter Eisentraut) to display the comments
>    associated with tables, views, and columns in 
>    its \d output? Or perhaps another \ command?
> 
> 2. Should I write up SGML for it (as well as for 
>    TRUNCATE TABLE)?
> 
> 3. Should I expand it beyond ORACLE's syntax to 
>    include functions, types, triggers, rules, etc.?
> 
> On the TODO list its listed as:
> 
> Allow pg_descriptions when creating types, tables,
> columns, and functions 


-- 
Peter Eisentraut                  Sernanders vaeg 10:115
peter_e@gmx.net                   75262 Uppsala
http://yi.org/peter-e/            Sweden


Sat, 16 Oct 1999 21:37:25 +0200 (CEST)
Peter Eisentraut <peter_e@gmx.net>
Re: ORACLE COMMENT statement