> The RelFileNodeEquals() bug we found on Monday proves that no one had
> yet done enough stress-testing on 7.1 to discover that multiple
> databases were broken.  Think about that for awhile before 
> you campaign for inserting untested new features at this point.
> We need to focus on TESTING, people, not new features.

I mostly sure that Oleg' changes touch *only* gist subdir (Oleg?)
so *nothing* will be broken in other areas. That's why I don't
object new gist in 7.1.

RelFileNodeEquals is quite another thing, thanks for fix again -:)

Vadim

Thu, 11 Jan 2001 09:35:07 -0800
"Mikheev, Vadim" <vmikheev@SECTORBASE.COM>
RE: AW: Re: GiST for 7.1 !! 
On Thu, 11 Jan 2001, Mikheev, Vadim wrote:

> > The RelFileNodeEquals() bug we found on Monday proves that no one had
> > yet done enough stress-testing on 7.1 to discover that multiple
> > databases were broken.  Think about that for awhile before
> > you campaign for inserting untested new features at this point.
> > We need to focus on TESTING, people, not new features.
>
> I mostly sure that Oleg' changes touch *only* gist subdir (Oleg?)

Yes, and only one file - gist.c

> so *nothing* will be broken in other areas. That's why I don't
> object new gist in 7.1.
>

We prepare regression test for RD-Tree in the same way as Gene
does for his contribution. I put all files on
http://www.sai.msu.su/~megera/postgres/gist/. btw, all Gene's
test for seg and cube in contrib area are passed. It would be better
Gene check his application himself.

I'm sorry for trouble with my submission  - I hoped we will be ready
before beta2,3, but we spent too many time to get old insertion
algoritm works with variable size keys until we realized it's just
not suitable for this.

I understand Tom's arguments and respect his experience, so I think it's
possible to put link to my page in 7.1 docs for people interested in
GiST features. Also, we found GiST part of postgres documentation
is too short, so we'll try to contribute something sometime later.
>From other side, GiST was too hidden for people, while it's very
powerfull feature and many people for sure really needs GiST power.
Frankly speaking I discovered GiST power myself by accident :-)
Now we have many plans to use GiST in our real life applications such as
Web site management system, full text search (killer application !),
data mining and others.

There are several improvements and new features we plan to add to GiST
which could be go to 7.2.

	Regards,
		Oleg
_____________________________________________________________
Oleg Bartunov, sci.researcher, hostmaster of AstroNet,
Sternberg Astronomical Institute, Moscow University (Russia)
Internet: oleg@sai.msu.su, http://www.sai.msu.su/~megera/
phone: +007(095)939-16-83, +007(095)939-23-83



Thu, 11 Jan 2001 22:16:57 +0300 (GMT)
Oleg Bartunov <oleg@sai.msu.su>
RE: AW: Re: GiST for 7.1 !! 
Oleg Bartunov <oleg@sai.msu.su> writes:
> I understand Tom's arguments and respect his experience, so I think it's
> possible to put link to my page in 7.1 docs for people interested in
> GiST features.

Bear in mind that I only have one core vote ;-).  We've already had some
private core discussion about whether to accept this patch now, and so
far I think I'm outvoted.

Did I understand you to say that you'd added some regression tests for
GiST?  That would lessen my unhappiness a little bit ...

			regards, tom lane

Thu, 11 Jan 2001 16:02:49 -0500
Tom Lane <tgl@sss.pgh.pa.us>
Re: AW: Re: GiST for 7.1 !! 
On Thu, 11 Jan 2001, Tom Lane wrote:

> Oleg Bartunov <oleg@sai.msu.su> writes:
> > I understand Tom's arguments and respect his experience, so I think it's
> > possible to put link to my page in 7.1 docs for people interested in
> > GiST features.
>
> Bear in mind that I only have one core vote ;-).  We've already had some
> private core discussion about whether to accept this patch now, and so
> far I think I'm outvoted.
>

There are several Tom Lane, judge by your activity. You probably need
several votes.

> Did I understand you to say that you'd added some regression tests for
> GiST?  That would lessen my unhappiness a little bit ...

Yes, we did. Currently all files are available from my page
http://www.sai.msu.su/~megera/postgres/gist/
I could submit them to hackers list if CORE people got consensus

	Regards,

		Oleg

>
> 			regards, tom lane
>

	Regards,
		Oleg
_____________________________________________________________
Oleg Bartunov, sci.researcher, hostmaster of AstroNet,
Sternberg Astronomical Institute, Moscow University (Russia)
Internet: oleg@sai.msu.su, http://www.sai.msu.su/~megera/
phone: +007(095)939-16-83, +007(095)939-23-83


Fri, 12 Jan 2001 00:12:51 +0300 (GMT)
Oleg Bartunov <oleg@sai.msu.su>
Re: AW: Re: GiST for 7.1 !! 
On Fri, 12 Jan 2001, Oleg Bartunov wrote:

> On Thu, 11 Jan 2001, Tom Lane wrote:
>
> > Oleg Bartunov <oleg@sai.msu.su> writes:
> > > I understand Tom's arguments and respect his experience, so I think it's
> > > possible to put link to my page in 7.1 docs for people interested in
> > > GiST features.
> >
> > Bear in mind that I only have one core vote ;-).  We've already had some
> > private core discussion about whether to accept this patch now, and so
> > far I think I'm outvoted.
> >
>
> There are several Tom Lane, judge by your activity. You probably need
> several votes.
>
> > Did I understand you to say that you'd added some regression tests for
> > GiST?  That would lessen my unhappiness a little bit ...
>
> Yes, we did. Currently all files are available from my page
> http://www.sai.msu.su/~megera/postgres/gist/
> I could submit them to hackers list if CORE people got consensus

Okay, if there are appropriate regression tests, I'm going to say go for
it ...

Does anyone have any objections to my downloading the tar file (doing that
now), committing the changes and wrapping up a quick Beta4 just so that we
have a tar ball that is testable right away?

Save Lamar and the other packagers a bit of work by avoiding beta3
packages :)




Thu, 11 Jan 2001 18:35:05 -0400 (AST)
The Hermit Hacker <scrappy@hub.org>
Re: AW: Re: GiST for 7.1 !! 

just downloaded it and can't find any regression tests ... ?

On Thu, 11 Jan 2001, The Hermit Hacker wrote:

> On Fri, 12 Jan 2001, Oleg Bartunov wrote:
>
> > On Thu, 11 Jan 2001, Tom Lane wrote:
> >
> > > Oleg Bartunov <oleg@sai.msu.su> writes:
> > > > I understand Tom's arguments and respect his experience, so I think it's
> > > > possible to put link to my page in 7.1 docs for people interested in
> > > > GiST features.
> > >
> > > Bear in mind that I only have one core vote ;-).  We've already had some
> > > private core discussion about whether to accept this patch now, and so
> > > far I think I'm outvoted.
> > >
> >
> > There are several Tom Lane, judge by your activity. You probably need
> > several votes.
> >
> > > Did I understand you to say that you'd added some regression tests for
> > > GiST?  That would lessen my unhappiness a little bit ...
> >
> > Yes, we did. Currently all files are available from my page
> > http://www.sai.msu.su/~megera/postgres/gist/
> > I could submit them to hackers list if CORE people got consensus
>
> Okay, if there are appropriate regression tests, I'm going to say go for
> it ...
>
> Does anyone have any objections to my downloading the tar file (doing that
> now), committing the changes and wrapping up a quick Beta4 just so that we
> have a tar ball that is testable right away?
>
> Save Lamar and the other packagers a bit of work by avoiding beta3
> packages :)
>
>
>
>

Marc G. Fournier                   ICQ#7615664               IRC Nick: Scrappy
Systems Administrator @ hub.org
primary: scrappy@hub.org           secondary: scrappy@{freebsd|postgresql}.org


Thu, 11 Jan 2001 18:40:46 -0400 (AST)
The Hermit Hacker <scrappy@hub.org>
Re: AW: Re: GiST for 7.1 !! 
The Hermit Hacker wrote:
> Save Lamar and the other packagers a bit of work by avoiding beta3
> packages :)

:-)

Well, working on those packages now.  Fun stuff.  I learn more about
more different parts of the code each new version, as the hang-ups
change from version to version.  Although, thanks to Karl DeBisschop, I
now have a new secret weapon in my war Bwahaha... :-)

There have been more changes since 7.0 than in any previous version I
can remember as far as the build goes.  Not a bad thing -- just a
learning experience.

At least the build won't change from beta3 to beta4.....
--
Lamar Owen
WGCR Internet Radio
1 Peter 4:11

Thu, 11 Jan 2001 17:41:56 -0500
Lamar Owen <lamar.owen@wgcr.org>
Re: AW: Re: GiST for 7.1 !!
On Thu, 11 Jan 2001, The Hermit Hacker wrote:

>
> just downloaded it and can't find any regression tests ... ?

it's in the contrib-intarray.tar.gz
gmake, gmake install, gmake installcheck


	Oleg
>
> On Thu, 11 Jan 2001, The Hermit Hacker wrote:
>
> > On Fri, 12 Jan 2001, Oleg Bartunov wrote:
> >
> > > On Thu, 11 Jan 2001, Tom Lane wrote:
> > >
> > > > Oleg Bartunov <oleg@sai.msu.su> writes:
> > > > > I understand Tom's arguments and respect his experience, so I think it's
> > > > > possible to put link to my page in 7.1 docs for people interested in
> > > > > GiST features.
> > > >
> > > > Bear in mind that I only have one core vote ;-).  We've already had some
> > > > private core discussion about whether to accept this patch now, and so
> > > > far I think I'm outvoted.
> > > >
> > >
> > > There are several Tom Lane, judge by your activity. You probably need
> > > several votes.
> > >
> > > > Did I understand you to say that you'd added some regression tests for
> > > > GiST?  That would lessen my unhappiness a little bit ...
> > >
> > > Yes, we did. Currently all files are available from my page
> > > http://www.sai.msu.su/~megera/postgres/gist/
> > > I could submit them to hackers list if CORE people got consensus
> >
> > Okay, if there are appropriate regression tests, I'm going to say go for
> > it ...
> >
> > Does anyone have any objections to my downloading the tar file (doing that
> > now), committing the changes and wrapping up a quick Beta4 just so that we
> > have a tar ball that is testable right away?
> >
> > Save Lamar and the other packagers a bit of work by avoiding beta3
> > packages :)
> >
> >
> >
> >
>
> Marc G. Fournier                   ICQ#7615664               IRC Nick: Scrappy
> Systems Administrator @ hub.org
> primary: scrappy@hub.org           secondary: scrappy@{freebsd|postgresql}.org
>

	Regards,
		Oleg
_____________________________________________________________
Oleg Bartunov, sci.researcher, hostmaster of AstroNet,
Sternberg Astronomical Institute, Moscow University (Russia)
Internet: oleg@sai.msu.su, http://www.sai.msu.su/~megera/
phone: +007(095)939-16-83, +007(095)939-23-83


Fri, 12 Jan 2001 02:08:15 +0300 (GMT)
Oleg Bartunov <oleg@sai.msu.su>
Re: AW: Re: GiST for 7.1 !! 
On Fri, 12 Jan 2001, Oleg Bartunov wrote:

> On Thu, 11 Jan 2001, The Hermit Hacker wrote:
>
> >
> > just downloaded it and can't find any regression tests ... ?
>
> it's in the contrib-intarray.tar.gz
> gmake, gmake install, gmake installcheck

erk, can we get this somehow done in such a way that its part of the
*standard* regression tests?  so when ppl do 'make test', the GiST stuff
is checked also?  My worry, as with others, isn't that GiST itself is
broken by the changes, its that *somehow* there is an interaction that is
with the rest of the system that isn't being tested ...



 >
>
> 	Oleg
> >
> > On Thu, 11 Jan 2001, The Hermit Hacker wrote:
> >
> > > On Fri, 12 Jan 2001, Oleg Bartunov wrote:
> > >
> > > > On Thu, 11 Jan 2001, Tom Lane wrote:
> > > >
> > > > > Oleg Bartunov <oleg@sai.msu.su> writes:
> > > > > > I understand Tom's arguments and respect his experience, so I think it's
> > > > > > possible to put link to my page in 7.1 docs for people interested in
> > > > > > GiST features.
> > > > >
> > > > > Bear in mind that I only have one core vote ;-).  We've already had some
> > > > > private core discussion about whether to accept this patch now, and so
> > > > > far I think I'm outvoted.
> > > > >
> > > >
> > > > There are several Tom Lane, judge by your activity. You probably need
> > > > several votes.
> > > >
> > > > > Did I understand you to say that you'd added some regression tests for
> > > > > GiST?  That would lessen my unhappiness a little bit ...
> > > >
> > > > Yes, we did. Currently all files are available from my page
> > > > http://www.sai.msu.su/~megera/postgres/gist/
> > > > I could submit them to hackers list if CORE people got consensus
> > >
> > > Okay, if there are appropriate regression tests, I'm going to say go for
> > > it ...
> > >
> > > Does anyone have any objections to my downloading the tar file (doing that
> > > now), committing the changes and wrapping up a quick Beta4 just so that we
> > > have a tar ball that is testable right away?
> > >
> > > Save Lamar and the other packagers a bit of work by avoiding beta3
> > > packages :)
> > >
> > >
> > >
> > >
> >
> > Marc G. Fournier                   ICQ#7615664               IRC Nick: Scrappy
> > Systems Administrator @ hub.org
> > primary: scrappy@hub.org           secondary: scrappy@{freebsd|postgresql}.org
> >
>
> 	Regards,
> 		Oleg
> _____________________________________________________________
> Oleg Bartunov, sci.researcher, hostmaster of AstroNet,
> Sternberg Astronomical Institute, Moscow University (Russia)
> Internet: oleg@sai.msu.su, http://www.sai.msu.su/~megera/
> phone: +007(095)939-16-83, +007(095)939-23-83
>
>

Marc G. Fournier                   ICQ#7615664               IRC Nick: Scrappy
Systems Administrator @ hub.org
primary: scrappy@hub.org           secondary: scrappy@{freebsd|postgresql}.org


Thu, 11 Jan 2001 19:21:53 -0400 (AST)
The Hermit Hacker <scrappy@hub.org>
Re: AW: Re: GiST for 7.1 !! 
On Thu, 11 Jan 2001, The Hermit Hacker wrote:

> On Fri, 12 Jan 2001, Oleg Bartunov wrote:
>
> > On Thu, 11 Jan 2001, The Hermit Hacker wrote:
> >
> > >
> > > just downloaded it and can't find any regression tests ... ?
> >
> > it's in the contrib-intarray.tar.gz
> > gmake, gmake install, gmake installcheck
>
> erk, can we get this somehow done in such a way that its part of the
> *standard* regression tests?  so when ppl do 'make test', the GiST stuff
> is checked also?  My worry, as with others, isn't that GiST itself is
> broken by the changes, its that *somehow* there is an interaction that is
> with the rest of the system that isn't being tested ...

No way, we need to load functions. there are several contributions
which depends on loaded functions. If you suggest how to do this
in general way, it would fine. To test GiST you need to define some
data structure ( in our case - RD-tree) and functions to access it

>
>
>
>  >
> >
> > 	Oleg
> > >
> > > On Thu, 11 Jan 2001, The Hermit Hacker wrote:
> > >
> > > > On Fri, 12 Jan 2001, Oleg Bartunov wrote:
> > > >
> > > > > On Thu, 11 Jan 2001, Tom Lane wrote:
> > > > >
> > > > > > Oleg Bartunov <oleg@sai.msu.su> writes:
> > > > > > > I understand Tom's arguments and respect his experience, so I think it's
> > > > > > > possible to put link to my page in 7.1 docs for people interested in
> > > > > > > GiST features.
> > > > > >
> > > > > > Bear in mind that I only have one core vote ;-).  We've already had some
> > > > > > private core discussion about whether to accept this patch now, and so
> > > > > > far I think I'm outvoted.
> > > > > >
> > > > >
> > > > > There are several Tom Lane, judge by your activity. You probably need
> > > > > several votes.
> > > > >
> > > > > > Did I understand you to say that you'd added some regression tests for
> > > > > > GiST?  That would lessen my unhappiness a little bit ...
> > > > >
> > > > > Yes, we did. Currently all files are available from my page
> > > > > http://www.sai.msu.su/~megera/postgres/gist/
> > > > > I could submit them to hackers list if CORE people got consensus
> > > >
> > > > Okay, if there are appropriate regression tests, I'm going to say go for
> > > > it ...
> > > >
> > > > Does anyone have any objections to my downloading the tar file (doing that
> > > > now), committing the changes and wrapping up a quick Beta4 just so that we
> > > > have a tar ball that is testable right away?
> > > >
> > > > Save Lamar and the other packagers a bit of work by avoiding beta3
> > > > packages :)
> > > >
> > > >
> > > >
> > > >
> > >
> > > Marc G. Fournier                   ICQ#7615664               IRC Nick: Scrappy
> > > Systems Administrator @ hub.org
> > > primary: scrappy@hub.org           secondary: scrappy@{freebsd|postgresql}.org
> > >
> >
> > 	Regards,
> > 		Oleg
> > _____________________________________________________________
> > Oleg Bartunov, sci.researcher, hostmaster of AstroNet,
> > Sternberg Astronomical Institute, Moscow University (Russia)
> > Internet: oleg@sai.msu.su, http://www.sai.msu.su/~megera/
> > phone: +007(095)939-16-83, +007(095)939-23-83
> >
> >
>
> Marc G. Fournier                   ICQ#7615664               IRC Nick: Scrappy
> Systems Administrator @ hub.org
> primary: scrappy@hub.org           secondary: scrappy@{freebsd|postgresql}.org
>

	Regards,
		Oleg
_____________________________________________________________
Oleg Bartunov, sci.researcher, hostmaster of AstroNet,
Sternberg Astronomical Institute, Moscow University (Russia)
Internet: oleg@sai.msu.su, http://www.sai.msu.su/~megera/
phone: +007(095)939-16-83, +007(095)939-23-83


Fri, 12 Jan 2001 02:36:49 +0300 (GMT)
Oleg Bartunov <oleg@sai.msu.su>
Re: AW: Re: GiST for 7.1 !! 
The Hermit Hacker <scrappy@hub.org> writes:
> Does anyone have any objections to my downloading the tar file (doing that
> now), committing the changes and wrapping up a quick Beta4 just so that we
> have a tar ball that is testable right away?

I think we oughta review the changes at least a little bit before
pushing out a beta4... go ahead and commit though...

			regards, tom lane

Thu, 11 Jan 2001 18:41:47 -0500
Tom Lane <tgl@sss.pgh.pa.us>
Re: AW: Re: GiST for 7.1 !! 
Lamar Owen <lamar.owen@wgcr.org> writes:
> There have been more changes since 7.0 than in any previous version I
> can remember as far as the build goes.

No surprise, considering the amount of work Peter E. has done on
cleaning up the configure, build, and install process --- exactly
the stuff that would affect RPM building.  I trust you're finding
that the changes are for the better.

Unless Peter has plans he hasn't mentioned, future revs shouldn't
see so much activity there.

			regards, tom lane

Thu, 11 Jan 2001 18:52:50 -0500
Tom Lane <tgl@sss.pgh.pa.us>
Re: AW: Re: GiST for 7.1 !! 