> On Mon, 9 Mar 1998, Andrew Martin wrote:
> 
> > > 	Then, using what was left, I did:
> > > 
> > > psql -e < db.dump 
> > > 
> > > 	Again.  Failed misearbly, with the following coming from the 'copy
> > > to <relname> from stdin;' section:
> > > 
> > > 344984  johnb   xgSldZdYEgIWo           clio.trends.ca  n       \N
> > 
> > I got something kind-of similar with a core dump... This was 'cos of a 
> > column name which is now a reserved word.
> 
> 	Ack, I fear you are correct...the third field above is 'password',
> which became a reserved word in v6.3...oh man, is this upgrade ever going
> to hurt...my 'db.dump' file is 84Meg...vi just loves it :)
> 
> 
I do think it would be a good idea if the pg_dumpall from the new release
looked for these now-reserved column names and warned the user. You could
then at least know where problems will occur. In upgrades from d/b versions
which support ALTER TABLE xxx RENAME COLUMN yyy TO zzz, you would actually
be able to do something about it before re-dumping...

Andrew

----------------------------------------------------------------------------
Dr. Andrew C.R. Martin                             University College London
EMAIL: (Work) martin@biochem.ucl.ac.uk    (Home) andrew@stagleys.demon.co.uk
URL:   http://www.biochem.ucl.ac.uk/~martin
Tel:   (Work) +44(0)171 419 3890                    (Home) +44(0)1372 275775

Mon, 9 Mar 1998 14:26:49 GMT
Andrew Martin <martin@biochemistry.ucl.ac.uk>
Re: [HACKERS] How to...?
> I do think it would be a good idea if the pg_dumpall from the new release
> looked for these now-reserved column names and warned the user. You could
> then at least know where problems will occur. In upgrades from d/b versions
> which support ALTER TABLE xxx RENAME COLUMN yyy TO zzz, you would actually
> be able to do something about it before re-dumping...

pg_dumpall is just a shell script.  You would have to do it in pg_dump. 
I hesistate to meddle with that code unless I have good reason for it. 
We could have a separate function that scans pg_attribute looking for
bad column names.

-- 
Bruce Momjian                          |  830 Blythe Avenue
maillist@candle.pha.pa.us              |  Drexel Hill, Pennsylvania 19026
  +  If your life is a hard drive,     |  (610) 353-9879(w)
  +  Christ can be your backup.        |  (610) 853-3000(h)

Mon, 9 Mar 1998 10:14:51 -0500 (EST)
Bruce Momjian <maillist@candle.pha.pa.us>
Re: [HACKERS] How to...?