He started his career at Leeds United in 1963, as the club came up out of the Second Division in 1963–64, and finished as First Division runners-up in 1964–65 and 1965–66. He also played in the 1967 and 1968 Inter-Cities Fairs Cup finals. He won both the Inter-Cities Fairs Cup and League Cup in 1968, before he was sold to Birmingham City. In 1969, he made a £100,000 move to Stoke City. He won the League Cup with Stoke in 1972, and also lifted the Watney Cup in 1973. He was moved on to Manchester United in 1976, and lifted both the FA Cup and Charity Shield in 1977. He was switched to Crewe Alexandra in December 1980, before joining Port Vale via Toronto Blizzard in August 1981. He was appointed player-manager at Rochdale in March 1983, before he resigned in March 1984.