As some believe Herod's family were converts to Judaism, his religious commitment was questioned by some elements of Jewish society. When John Hyrcanus conquered the region of Idumaea (the Edom of the Hebrew Bible) in 140–130 BCE, he required all Idumaeans to obey Jewish law or to leave; most Idumaeans thus converted to Judaism, which meant that they had to be circumcised, and many had intermarried with the Jews and adopted their customs. While Herod publicly identified himself as a Jew and was considered as such by some, this religious identification was undermined by the decadent lifestyle of the Herodians, which would have earned them the antipathy of observant Jews.