Hall began his career at the St Kilda Football Club where he twice led the club's goalkicking in 1999 and 2001. He is best known for his career with the Sydney Swans. He was one of the Swans' best players during his time at the club, topping the club goalkicking from 2002 to 2008 and co-captaining the side from 2005 to 2007, including the club's drought breaking premiership in 2005. He also featured heavily in the AFL's promotion in Sydney, gaining a similarly high-profile to Tony Lockett which saw him featured in a 2006 AFL and Swans joint promotion known as "Barry Hall Hall".