He was ordained in Port Glasgow and inducted to Pultneytown St. Andrew’s Church in Wick, Caithness in 1959 as 9th minister of Wick. After a successful merge with another local church, he was minister of Wick St. Andrew’s and Thrumster Church from 1961 to 1966. From 1966 to 1972 he was 1st minister of Mayfield and Easthouses Church in Dalkeith outside Edinburgh, before moving finally to Falkirk, as 8th minister of St. Andrew's West Parish Church. During his time in Falkirk, he was appointed president of the Scottish Evangelistic Council (1982–1985), convener of Community Care (1977–1985) and then convener of the Board of Social Responsibility of the Church of Scotland (1985–1989). As convener he visited Kenya as part of the International Christian Federation Conference for the Prevention of Alcoholism and Drug Addiction, and also toured the Holy Land. As convener he was responsible for the reports presented to Margaret Thatcher after her notorious Sermon on the Mound in 1988, which were interpreted as a rebuke to her speech.