Marshall began his career as a youth player with Tynecastle Boys Club before signing for Rangers in January 1980. He then suffered a broken leg playing for the Ibrox club's reserve side aged 15 and after failing to play for the first-team was sent out on loan to East Stirlingshire. Marshall then signed for Scottish Junior club Broxburn Athletic before returning to the senior ranks in December 1982 with East Fife, before signing for Falkirk and then Celtic in 1991 for £270,000, having turned down a chance to rejoin Rangers when it was made clear he would remain behind Andy Goram in the selection order.