Teh's early career was as an architect at PWD, New South Wales, Australia. He then moved to the Housing Commission in New South Wales before expanding his expertise with the Housing Trust in Kuala Lumpur and serving in the Penang City Council. In August 1959, he joined the Singapore Improvement Trust as an architect. He was promoted to Chief Architect, Building Department of the newly formed Housing and Development Board (HDB) in October 1959. Later he became the Chief Executive Officer of HDB from 1970 to January 1979. He was also the Chairman of Jurong Town Corporation between September 1976 to March 1979. He resigned from his posts to go into politics.