Raised in Cabra, Dublin, he began his career at Home Farm, before spending two years with Glentoran from 1965 to 1967. With Glentoran he won the Steel & Sons Cup and Irish Cup in 1966, and helped the club to win the Irish League title in 1966–67. He was sold to English First Division club Stoke City in March 1967 for a fee of £15,000, and went to on to help Stoke to win the League Cup in 1972. In total he spent 12 years with Stoke, scoring 67 goals in 333 league and cup appearances. He was a popular figure with Stoke fans due to his creative flair and dribbling ability, as well as his distinctive pale skin, bright ginger hair and sideburns.