As a player, he played as a forward. He play for multiple Scottish teams, including Dunfermline Athletic and Rangers. After retiring from playing, he started managing at East Stirlingshire. He would be hired by St Mirren, Aberdeen, and the Scotland national team, due to the death of Jock Stein. He was the manager of Scotland at the 1986 FIFA World Cup.