Smith signed as a defender with Dundee United in 1966, joining as a part-timer while working as an electrician. He was a decent player rather than a gifted one. In September 1975 he moved to Dumbarton, but returned to United in 1977. At the age of 29, a pelvic injury threatened his career and he was invited to join the Dundee United coaching staff by Jim McLean. His first team appearances were limited thereafter, but he remained a signed player and his final club match was in September 1980. In total, he made over 250 senior appearances, scoring three goals.