He played nearly 300 League games for Crystal Palace, Birmingham City. For a short time, he served as manager of Motherwell before leaving professional football to work as a PE teacher. He was the nephew of Bill Shankly.