He made his debut for Queen's Park at age 16. He would score 20 goals in 31 games for Queens Park. He joined St Johnstone in 1960 to try to get regular gametime. He would score a hat-trick for St Johnstone against Rangers. He signed for Dunfermline in 1964.