Macmillan served in the Grenadier Guards during the First World War. After the war he joined his family publishing company, then entered Parliament at the 1924 general election. After losing his seat in 1929, he regained it in 1931.