McDonald studied at the University of Sydney. He became a teacher, and rose to become President of the Teachers Federation of New South Wales. In 1922 he stood for election to the Australian House of Representatives, and won the new seat of Barton for the Labor Party. His main opponent was Hector Lamond, who had been the Nationalist member for the abolished seat of Illawarra.