title: XMLSigner No longer works in 4.6.2 - Malformed reference element
body: <p>After Upgrading an application from 3.5 to 4.6.2 The following block of code no longer works. I get "Malformed reference element" Errors, even though it worked just fine as a 3.5 application. The code fails with the above error on what should be a good reference. I've tried everything I can think of can cannot get the ASP.Net version working. I've built a testbed version as a console application which works fine until it gets to the last reference which fails with "Unable to resolve Uri Signature1.jpg." I've read that XMLSigner doesn't accept anything other than id, ID, and Id as elements to look for to match references, however I don't believe this to be the case because it works in the console application.</p>
  
  <p>The core of the question is:</p>
  
  <ol>
  <li>Why am I getting a "Malformed reference element" for <code>signedXMl.AddReference(new Reference("#Head01"));</code></li>
  <li>How do I fix the reference to the customer Signatures "src="Signature1.jpg""  </li>
  </ol>
  
  <p>Function in question:  </p>
  
  <pre><code>private XmlDocument SignDoc(XmlDocument doc, RSA key, X509Certificate x509cert, ArrayList alSignatures)
      {
          string signatureID = "TamperSealer01";
          Uri uri = new Uri(ConfigurationManager.AppSettings["SomeSetting"]); 
          XmlResolver resolver = new XmlSignatureResolver(uri);
          SignedXml signedXml = new SignedXml(doc);
          signedXml.Signature.Id = signatureID;
          signedXml.Resolver = resolver;
  
          // Add the key to the SignedXml responseDocument. 
          signedXml.SigningKey = key;
  
          // Create a new KeyInfo object.
          KeyInfo keyInfo = new KeyInfo();
          keyInfo.AddClause(new RSAKeyValue(key));
  
          KeyInfoX509Data x509Data = new KeyInfoX509Data(x509cert);
  
          string subjectName = x509cert.Subject;
          subjectName = subjectName.Replace("S=", "ST=");
          string tmpSubName = subjectName;
  
          tmpSubName = tmpSubName.Replace("O=A", "O=B");
          tmpSubName = tmpSubName.Replace("CN=A", "CN=B");
  
          x509Data.AddSubjectName(tmpSubName);
          x509Data.AddIssuerSerial(x509cert.Issuer, x509cert.GetSerialNumberString()); //GetIssuerName
          keyInfo.AddClause(x509Data);
          signedXml.KeyInfo = keyInfo;
  
          //TIMESTAMP
          XmlElement signaturePropertiesRoot = doc.CreateElement("SignatureProperties", "http://www.w3.org/2000/09/xmldsig#");
  
          DataObject signatureProperties = new DataObject();
          signatureProperties.Id = "TimeStamp";
          signatureProperties.Data = signaturePropertiesRoot.SelectNodes(".");
          signedXml.AddObject(signatureProperties);
  
          // and add a reference to the data object
          Reference propertiesRef = new Reference();
          propertiesRef.Uri = "#TimeStamp";
          propertiesRef.Type = "http://www.w3.org/2000/09/xmldsig#SignatureProperties";
          signedXml.AddReference(propertiesRef);
  
          XmlElement property = doc.CreateElement("SignatureProperty", "http://www.w3.org/2000/09/xmldsig#");
          property.SetAttribute("Id", "TamperSealer01TimeStamp");
          property.SetAttribute("Target", "#" + signedXml.Signature.Id);
          signaturePropertiesRoot.AppendChild(property);
  
          XmlElement timestamp = doc.CreateElement("DateTimeStamp", "http://www.w3.org/2000/09/xmldsig#");
          timestamp.SetAttribute("DateTime", String.Format("{0:s}Z", DateTime.Now.ToUniversalTime()));
          property.AppendChild(timestamp);
          signedXml.ComputeSignature();
  
          // References contains three strings "Head01", "Data01", and "View01"
          foreach (string docRef in references) 
          {
              // Create a reference to be signed.
              Reference tempRef = new Reference();
              tempRef.Uri = "#" + docRef;
              Logger.Current.LogInformation("DocRef: #" + docRef + ".");
              // Add the reference to the SignedXml object
              signedXml.AddReference(tempRef);
              signedXml.ComputeSignature(); //Immediately Fails here
          }
  
          // alSignatures only contains "Signature1.jpg" in this case. Don't yell at me for this crappy code, I didn't write it and plan on fixing it when everything else works.
          int ctr = 0;
          foreach (string str in alSignatures)
          {
              Reference testRef = new Reference();
              Uri relativeUri = new Uri(alSignatures[ctr].ToString(), UriKind.RelativeOrAbsolute);
              Logger.Current.LogInformation("Signature Reference: " + alSignatures[ctr].ToString());
              testRef.Uri = alSignatures[ctr].ToString();
              signedXml.AddReference(testRef);
              ctr += 1;
          }
  
          // Compute the signature.
          signedXml.ComputeSignature();
  
          // Get the XML representation of the signature and save it to an XmlElement object.
          XmlElement xmlDigitalSignature = signedXml.GetXml();
          XmlElement signaturesElement = doc.CreateElement("SIGNATURES", "http://www.mismo.org");
  
          signaturesElement.AppendChild(signedXml.GetXml());
          doc.DocumentElement.AppendChild(signaturesElement);
  
          key.Clear();
          key.Dispose();
          return doc;
  }
  </code></pre>
  
  <p>The XML it should be signing is minimally thus:</p>
  
  <pre><code>&lt;?xml version="1.0" encoding="UTF-8"?&gt;
  &lt;DOCUMENT MISMOVersionIdentifier="1.02"&gt;
      &lt;HEADER _ID="Head01"&gt;
          &lt;SIGNATURE_MODEL&gt;
              &lt;SIGNER AreaIDREF="Borrower1SignatureArea" SectionIDREF="BorrowerSignatures" SignatureIDREF="Borrower1SignatureLine" SignatureType="Image" TargetsIDREFS="View01" _RoleType="Borrower" _SignatureOrderNumber="1" /&gt;
              &lt;SIGNER SignatureIDREF="TamperSealer01" SignatureType="DigitalSignature" TargetsIDREFS="Head01 Data01 View01" _RoleType="TamperSealer" _SignatureOrderNumber="1" /&gt;
          &lt;/SIGNATURE_MODEL&gt;
      &lt;/HEADER&gt;
      &lt;DATA _ID="Data01"&gt;
          &lt;MAIN&gt;
          &lt;/MAIN&gt;
      &lt;/DATA&gt;
      &lt;VIEW _ID="View01" _MIMETypeDescription="text/html" _TaggedIndicator="True"&gt;
          &lt;html xmlns="http://www.w3.org/1999/xhtml"&gt;
              &lt;body&gt;
                  &lt;span class="dataEntered" id="BORROWER_Signer-Info"&gt;
                      &lt;SIGNATURE_SECTION _ID="BorrowerSignatures"&gt;
                          &lt;SIGNATURE_AREA _ID="Borrower1SignatureArea"&gt;
                              &lt;p class="right"&gt;
                                  &lt;SIGNATURE_ABOVE_LINE /&gt;
                                  &lt;SIGNATURE_IMAGE _EncodingTypeDescription="None" _ID="Borrower1SignatureLine" _MIMEType="image/jpeg"&gt;
                                      &lt;img align="right" alt="Signature file is missing - Invalid Document" src="Signature1.jpg" /&gt;
                                  &lt;/SIGNATURE_IMAGE&gt;
                              &lt;/p&gt;
                              &lt;p&gt;04/12/2011 12:00 PM&lt;/p&gt;
                          &lt;/SIGNATURE_AREA&gt;
                      &lt;/SIGNATURE_SECTION&gt;
                  &lt;/span&gt;
              &lt;/body&gt;
          &lt;/html&gt;
      &lt;/VIEW&gt;
  &lt;/DOCUMENT&gt;
  </code></pre>