The right to return is a show stopper since it effectively means the end of Israel as a safe haven for Jews from an Israeli point of view. It would effectively create two Palestinian states which is why the Palestinians insist on it.  Consider what happened to the Jews in other Arab countries. Where are they now? 

The settlements would likely be given up if the Palestinians were serious about peace. Israel did this in Gaza and got the Hamas Charter as a reward. Besides, the Palestinians were committing acts of terror against Israel prior to 1967.

Arab-Israelis enjoy full rights including local Sharia law within Israel.  Ask any of them if they would prefer living in another Arab country or the West Bank. The Druze in the Golan Heights readily admit their life is much better in Israel than in Syria.

BDS is viewed as simple antisemitism by the average Israeli and is having no real effect on Israel's economy. It is affecting the Palestinian economy however.  

Good luck with that.