Everyone who writes about the drop in numbers of self-identified Catholics misses one big issue, and it is one that simply flies over the heads of almost ALL Catholics.  It is the treatment of children and teens within the church. 
There is an over-emphasis on "Catholic education" that allows the kids who attend the parish school to be treated as royalty while the "public" kids are treated like third or fourth-class citizens!  
Although on average they total more than 66% of the children of the parish, they are made to feel inferior, their parents are looked down on by the parish, and there is no real, sincere program to truly include them in the life of the parish.  Don't make excuses about "but we have...program."  Be honest - there is almost NOTHING for these kids at the parish!  
Even while attending what was then called "CCD," for 9 or 10 years, my 2 sons NEVER were treated as true, important parish members.  And so, they did not become parish members - no wonder!!